Fix --without-x build.
[bpt/emacs.git] / src / ChangeLog
1 2012-07-28 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (init_iterator): Don't reference tip_frame in a build
4 --without-x. (Bug#11742)
5
6 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
7
8 Adjust GDB to reflect pvec_type changes (Bug#12036).
9 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
10 2012-07-04 changes to pseudovector representation. Problem
11 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
12
13 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
14
15 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
16 bus address.
17 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
18
19 2012-07-27 Eli Zaretskii <eliz@gnu.org>
20
21 * alloc.c (listn): Fix the order the arguments are consed onto the
22 list.
23
24 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
25 enumeration constants, as PURE and HEAP are too general, and clash
26 with other headers and sources, such as gmalloc.c and the
27 MS-Windows system headers. All users changed.
28
29 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
30
31 Revert last save_excursion_save and save_excursion_restore changes.
32 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
33 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
34
35 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
36
37 Fix recently-introduced typos in Windows port.
38 Reported by Martin Rudalics <rudalics@gmx.at>.
39 * w32.c (init_environment): Replace comma with semicolon.
40 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
41
42 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
43
44 Improve GDB symbol export (Bug#12036).
45 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
46 arms of an 'if', not using conditional expressions; otherwise GDB
47 complains about the types in the unevaluated arm when the argument
48 is an integer literal.
49 (xgetint): Simplify expression.
50 * alloc.c (gdb_make_enums_visible): New constant. This ports to
51 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
52 Zaretskii in <http://bugs.gnu.org/12036#13>.
53 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
54 needed now that we have gdb_make_enums_visible.
55 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
56 (enum enum_USE_LSB_TAG):
57 New enum types, packaging up enums that need to be exported to GDB.
58
59 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
60
61 Utility function to make a list from specified amount of objects.
62 * lisp.h (enum constype): New datatype.
63 (listn): New prototype.
64 * alloc.c (listn): New function.
65 (Fmemory_use_count, syms_of_alloc): Use it.
66 * buffer.c (syms_of_buffer): Likewise.
67 * callint.c (syms_of_callint): Likewise.
68 * charset.c (define_charset_internal): Likewise.
69 * coding.c (syms_of_coding): Likewise.
70 * keymap.c (syms_of_keymap): Likewise.
71 * search.c (syms_of_search): Likewise.
72 * syntax.c (syms_of_syntax): Likewise.
73 * w32.c (init_environment): Likewise.
74 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
75 * xdisp.c (syms_of_xdisp): Likewise.
76 * xfns.c (syms_of_xfns): Likewise.
77
78 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
79
80 Fast save_excursion_save and save_excursion_restore.
81 * lisp.h (struct Lisp_Excursion): New data type.
82 (PVEC_EXCURSION): New pseudovector type.
83 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
84 to deal with it. Adjust comments.
85 (init_marker, attach_marker): New prototype.
86 (unchain_marker): Adjust prototype.
87 * marker.c (attach_marker): Change to global.
88 (init_marker): New function.
89 * alloc.c (Fmake_marker, build_marker): Use it.
90 (build_marker): More easserts.
91 (mark_object): Handle struct Lisp_Excursion.
92 * editfns.c (save_excursion_save, save_excursion_restore):
93 Reimplement to use struct Lisp_Excursion. Add comments.
94
95 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
96
97 Fix export of symbols to GDB (Bug#12036).
98 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
99 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
100 emacs.c, as this is a more-suitable home. Had this been done earlier
101 the fix for 12036 would have avoided some of the problems noted in
102 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
103 would have been more obvious.
104 * emacs.c: Do not include <verify.h>; no longer needed.
105 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
106 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
107 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
108 Remove; now done in lisp.h.
109 * lisp.h (PUBLISH_TO_GDB): New macro.
110 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
111 (DATA_SEG_BITS): Use it.
112 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
113 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
114 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
115 not be usable in #if. This simplifies things.
116
117 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
118
119 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
120
121 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
122
123 Simplify export of symbols to GDB (Bug#12036).
124 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
125 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
126 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
127 Adjust to changes in lisp.h and emacs.c, by using
128 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
129 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
130 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
131 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
132 instead of gdb_valbits.
133 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
134 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
135 instead of gdb_array_mark_flag.
136 (xboolvector): Get size from $->size, not $->header.size.
137 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
138 (xreload, hook-run, hookpost-run): Remove.
139 * emacs.c: Include <verify.h>.
140 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
141 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
142 Remove.
143 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
144 (gdb_USE_LSB_TAG): New enum constants.
145 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
146 Also define these as enum constants, so they're visible to GDB.
147 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
148 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
149 as constants, so they're visible to GDB.
150 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
151 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
152 Now enum constants, not macros, so they're visible to GDB.
153 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
154 more convenient now. All uses changed.
155 (VALMASK) [USE_LSB_TAG]: Also define in this case.
156 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
157
158 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
159
160 Explicitly free restriction data that are not needed anymore.
161 * editfns.c (save_restriction_restore): Free restriction data.
162
163 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
164
165 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
166 add argument, tune behavior, and adjust all callers.
167
168 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
169
170 Use typedef for EMACS_INT, EMACS_UINT.
171 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
172 than macros. This simplifies debugging in the usual case, since
173 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
174 and it allows expressions involving EMACS_INT casts.
175 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
176
177 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
178
179 * nsterm.m (ns_read_socket): Return early if there is a modal
180 window (Bug#12043).
181
182 2012-07-25 Martin Rudalics <rudalics@gmx.at>
183
184 * frame.c (Fredirect_frame_focus): In doc-string don't mention
185 that FOCUS-FRAME can be omitted.
186
187 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
188
189 Adjust buffer text indirection counters at the end of Fkill_buffer.
190 * buffer.c (Fkill_buffer): Adjust indirection counters when the
191 buffer is definitely dead. This should really fix an issue reported
192 by Christoph Scholtes again. (Bug#12007).
193 (init_buffer_once): Initialize indirection counters of
194 buffer_defaults and buffer_local_symbols (for sanity and safety).
195
196 2012-07-24 Eli Zaretskii <eliz@gnu.org>
197
198 * xdisp.c (init_iterator): Don't compute dimensions of truncation
199 and continuation glyphs on tooltip frames, leave them at zero.
200 Avoids continued lines in tooltips. (Bug#11832)
201
202 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
203
204 Simplify copy_overlay.
205 * buffer.c (copy_overlay): Simplify. Use build_marker.
206 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
207
208 2012-07-23 Eli Zaretskii <eliz@gnu.org>
209
210 * print.c (print_object): Don't crash when a frame's name is nil
211 or invalid. (Bug#12025)
212
213 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
214 it signals an error when a tooltip frame is being created.
215
216 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
217
218 Cleanup miscellaneous objects allocation and initialization.
219 * alloc.c (allocate_misc): Change to static. Add argument to
220 specify the subtype. Adjust comment and users.
221 (build_overlay): New function.
222 * buffer.c (copy_overlays, Fmake_overlay): Use it.
223 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
224 (allocate_misc): Remove prototype.
225 (build_overlay): Add prototype.
226
227 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
228
229 Swap buffer text indirection counters in Fbuffer_swap_text.
230 * buffer.c (Fbuffer_swap_text): Swap indirections too.
231 This avoids crash reported by Christoph Scholtes at
232 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
233
234 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
235
236 * nsmenu.m (Popdown_data): New struct.
237 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
238 free Popdown_data.
239 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
240 (initWithContentRect): Make imgView and contentView non-static
241 and autorelease them. Also autorelease img and matrix (Bug#12005).
242 (dealloc): Remove (Bug#12005).
243
244 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
245
246 Adjust consing_since_gc when objects are explicitly freed.
247 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
248 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
249 (free_cons, free_misc): Subtract object size from consing_since_gc.
250
251 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
252
253 Simplify and cleanup markers positioning code.
254 * marker.c (attach_marker): More useful eassert.
255 (live_buffer, set_marker_internal): New function.
256 (Fset_marker, set_marker_restricted): Use set_marker_internal.
257 (set_marker_both, set_marker_restricted_both): Use live_buffer.
258
259 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
260
261 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
262 as it's limited by the amount of memory, not by INT_MAX.
263
264 2012-07-21 Eli Zaretskii <eliz@gnu.org>
265
266 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
267 in special-event-map. See the discussion at
268 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
269 for the reasons.
270
271 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
272 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
273 Fabrice Popineau <fabrice.popineau@supelec.fr>.
274
275 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
276
277 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
278 (conversationIdentifier): Return value is NSInteger.
279 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
280
281 2012-07-21 Chong Yidong <cyd@gnu.org>
282
283 * window.c (decode_any_window): Signal an error if the window is
284 on a dead frame (Bug#11984).
285
286 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
287
288 Add indirection counting to speed up Fkill_buffer.
289 * buffer.h (struct buffer): New member.
290 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
291 (Fmake_indirect_buffer): Set indirection counter to -1, increment
292 base buffer indirection counter.
293 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
294 (Fkill_buffer): Adjust indirection counters as needed, don't walk
295 through buffer list if indirection counter is 0.
296
297 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
298
299 Extend the value returned by Fgarbage_collect with heap statistics.
300 * alloc.c (Qheap): New symbol.
301 (syms_of_alloc): DEFSYM it.
302 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
303 (Fmemory_free): Remove.
304 (syms_of_alloc): Don't defsubr it.
305 * buffer.c (Fcompact_buffer): Remove.
306 (syms_of_buffer): Don't defsubr it.
307
308 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
309
310 Make maybe_gc inline.
311 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
312 * lisp.h (consing_since_gc, gc_relative_threshold)
313 (memory_full_cons_threshold): Revert declaration.
314 (maybe_gc): Remove prototype, define as inline.
315 * alloc.c: Remove old commented-out code.
316 (consing_since_gc, gc_relative_threshold)
317 (memory_full_cons_threshold): Revert to global.
318 (maybe_gc): Remove.
319
320 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
321
322 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
323 * lisp.h (build_unibyte_string): New function.
324 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
325 * sysdep.c, w32fns.c, xfns.c: Use it.
326 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
327 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
328 Adjust users accordingly.
329 * font.h (font_open_by_name): Adjust prototype.
330
331 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
332
333 Cleanup calls to Fgarbage_collect.
334 * lisp.h (maybe_gc): New prototype.
335 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
336 Remove declarations.
337 * alloc.c (maybe_gc): New function.
338 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
339 Make them static.
340 * bytecode.c (MAYBE_GC): Use maybe_gc.
341 * eval.c (eval_sub, Ffuncall): Likewise.
342 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
343 to avoid dependency from auto-save feature.
344
345 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
346
347 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
348 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
349 'for_each_per_buffer_object_at'.
350 All uses changed. It's better to use upper-case for macros that
351 cannot be implemented as functions, to give the reader a clue
352 that they're special.
353
354 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
355
356 * alloc.c (Fgarbage_collect): Tweak docstring.
357
358 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
359
360 Tweak the value returned from Fgarbage_collect again.
361 * alloc.c (Fgarbage_collect): New return value, as confirmed in
362 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
363 Adjust documentation.
364 (total_vector_bytes): Rename to total_vector_slots, adjust
365 accounting.
366 (total_free_vector_bytes): Rename to total_free_vector_slots,
367 adjust accounting.
368 (Qstring_bytes, Qvector_slots): New symbols.
369 (syms_of_alloc): DEFSYM them.
370
371 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
372
373 Buffer compaction primitive which may be used from Lisp.
374 * buffer.c (compact_buffer, Fcompact_buffer): New function.
375 (syms_of_buffer): Register Fcompact_buffer.
376 * alloc.c (Fgarbage_collect): Use compact_buffer.
377 * buffer.h (compact_buffer): New prototype.
378 (struct buffer_text): New member.
379
380 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
381
382 New macro to iterate over all buffers, miscellaneous cleanups.
383 * lisp.h (all_buffers): Remove declaration.
384 * buffer.h (all_buffers): Add declaration, with comment.
385 (for_each_buffer): New macro.
386 * alloc.c (Fgarbage_collect, mark_object): Use it.
387 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
388 (init_buffer): Likewise.
389 * data.c (Fset_default): Likewise.
390 * coding.c (code_conversion_restore): Remove redundant check
391 for dead buffer.
392 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
393
394 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
395
396 Fix bug that created negative-length intervals.
397 * intervals.c (merge_interval_right, merge_interval_left):
398 Do not zero out this interval if it is absorbed by its children,
399 as this interval's total length doesn't change in that case. See
400 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
401
402 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
403
404 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
405 when invoking (make-bool-vector N t) and N is a positive
406 multiple of 8 -- the last 8 bits were mistakenly cleared.
407
408 Remove some struct layout assumptions in bool vectors.
409 * alloc.c (bool_header_size): New constant.
410 (header_size, word_size): Move earlier, as they're now used earlier.
411 Use 'word_size' in a few more places, where it's appropriate.
412 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
413 padding before the data member of a bool vector.
414 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
415 than doing the check by hand with an abort ().
416
417 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
418
419 * eval.c (Fdefvar): Don't check constants since we only set the var if
420 it's not yet defined anyway (bug#11904).
421
422 * lisp.h (last_undo_boundary): Declare new var.
423 * keyboard.c (command_loop_1): Set it.
424 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
425 were auto-added by the command loop (bug#11774).
426
427 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
428
429 * w32font.c (Qsymbol): Remove local definition.
430 (syms_of_w32font): Don't DEFSYM it.
431
432 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
433
434 Fix sweep_vectors to handle large bool vectors correctly.
435 * alloc.c (sweep_vectors): Account total_vector_bytes for
436 bool vectors larger than VBLOCK_BYTES_MAX.
437
438 2012-07-18 Chong Yidong <cyd@gnu.org>
439
440 * frame.c (x_set_frame_parameters): Revert bogus change introduced
441 in 2012-05-25 commit by Paul Eggert (Bug#11738).
442
443 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
444
445 Return more descriptive data from Fgarbage_collect.
446 Suggested by Stefan Monnier in
447 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
448 * alloc.c (bounded_number): New function.
449 (total_buffers, total_vectors): New variable.
450 (total_string_size): Rename to total_string_bytes, adjust users.
451 (total_vector_size): Rename to total_vector_bytes, adjust users.
452 (sweep_vectors): Account total_vectors and total_vector_bytes.
453 (Fgarbage_collect): New return value. Adjust documentation.
454 (gc_sweep): Account total_buffers.
455 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
456 (VECTOR_SIZE): Remove.
457 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
458 (Qinterval, Qmisc): New symbols.
459 (syms_of_data): Initialize them.
460 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
461 (Qcons, Qbuffer): New declarations.
462
463 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
464
465 * alloc.c (Fmemory_free): Account for memory-free's own storage.
466 Round up, not down. Improve doc.
467
468 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
469
470 Restore old code in allocate_string_data to avoid Faset breakage.
471 Reported by Julien Danjou <julien@danjou.info> in
472 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
473 * alloc.c (allocate_string_data): Restore old code with minor
474 adjustments, fix comment to explain this subtle issue.
475
476 2012-07-17 Eli Zaretskii <eliz@gnu.org>
477
478 Remove FILE_SYSTEM_CASE.
479 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
480
481 * fileio.c (FILE_SYSTEM_CASE): Don't define.
482 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
483 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
484 call-process-region passes it through expand-file-name.
485
486 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
487
488 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
489
490 Fix crash when creating indirect buffer (Bug#11917)
491 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
492 Don't handle unbound variables specially if non-zero.
493 (Fbuffer_local_variables): Pass zero.
494 (clone_per_buffer_values): Pass non-zero.
495
496 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
497
498 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
499 to make the loop interruptible.
500
501 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
502
503 * gnutls.c (emacs_gnutls_handshake): Only retry if
504 GNUTLS_E_INTERRUPTED.
505
506 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
507
508 Cleanup and convert miscellaneous checks to eassert.
509 * alloc.c (mark_interval): Fix comment, partially rephrase
510 old comment from intervals.h (see below).
511 * intervals.c (find_interval, adjust_intervals_for_insertion)
512 (delete_interval, adjust_intervals_for_deletion)
513 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
514 Convert to eassert.
515 (adjust_intervals_for_insertion, make_new_interval):
516 Remove obsolete and unused code.
517 * intervals.h (struct interval): Remove obsolete comment.
518 * textprotp.c (erase_properties): Remove unused code.
519 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
520 (Fremove_list_of_text_properties): Convert to eassert.
521
522 2012-07-17 Chong Yidong <cyd@gnu.org>
523
524 * editfns.c (Finsert_char): Doc fix.
525
526 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
527
528 Fix previous change to make Fmemory_free always accurate.
529 * alloc.c (make_interval): Update total_free_intervals.
530 (make_float): Likewise for total_free_floats.
531 (free_cons, Fcons): Likewise for total_free_conses.
532 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
533 Likewise for total_free_vector_bytes.
534 (Fmake_symbol): Likewise for total_free_symbols.
535 (bytes_free): Remove.
536
537 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
538
539 Simple free memory accounting feature.
540 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
541 (sweep_vectors): Accumulate size of free vectors.
542 (Fgarbage_collect): Setup bytes_free.
543 (Fmemory_free): New function.
544 (syms_of_alloc): Register it.
545
546 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
547
548 Cleanup overlays checking.
549 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
550 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
551 eassert and OVERLAYP.
552 (sort_overlays): Change to use OVERLAYP.
553
554 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
555
556 * editfns.c (Finsert_char): Make it interactive, and make the
557 second arg optional. Copy interactive spec and docstring from
558 ucs-insert.
559
560 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
561
562 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
563 Unlike the other wrapped functions, fabs has an unspecified
564 effect on errno.
565
566 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
567
568 * nsterm.m (keyDown): Interpret flags without left/right bits
569 as the left key (Bug#11670).
570
571 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
572
573 Remove empty and useless init functions.
574 * lisp.h (init_character_once, init_fns, init_image)
575 (init_filelock, init_sound): Remove prototype.
576 * character.c (init_character_once): Remove.
577 * filelock.c (init_filelock): Likewise.
578 * fns.c (init_fns): Likewise.
579 * image.c (init_image): Likewise.
580 * sound.c (init_sound): Likewise.
581 * emacs.c (main): Adjust accordingly.
582
583 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
584
585 * gtkutil.h: Tiny cleanups.
586 (use_old_gtk_file_dialog): Remove useless declaration.
587 (xg_uses_old_file_dialog): Add suggested const attribute.
588
589 2012-07-15 Eli Zaretskii <eliz@gnu.org>
590
591 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
592 (bidi_paragraph_init): Use it to limit search forward for a strong
593 directional character in abnormally large paragraphs full of
594 neutral or weak characters. (Bug#11943)
595
596 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
597
598 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
599 the toolbar (Bug#9451).
600 (xg_make_tool_item): Give the widget event box a transparent
601 background.
602
603 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
604
605 Cleanup basic allocation variables and functions.
606 * alloc.c (ignore_warnings, init_intervals, init_float)
607 (init_cons, init_symbol, init_marker): Remove.
608 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
609 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
610 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
611 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
612 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
613 (staticidx, init_alloc_once, init_strings, free_ablock):
614 Remove redundant initialization.
615 * fns.c (init_weak_hash_tables): Remove.
616 * lisp.h (init_weak_hash_tables): Remove prototype.
617
618 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
619
620 Use zero_vector where appropriate.
621 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
622 accordingly.
623 * lisp.h (zero_vector): New declaration.
624 * font.c (null_vector): Remove.
625 (syms_of_font): Remove initialization and staticpro.
626 (font_list_entities, font_find_for_lface): Change to use zero_vector.
627 * keymap.c (Faccessible_keymaps): Likewise.
628
629 2012-07-15 Leo Liu <sdl.web@gmail.com>
630
631 * fringe.c: Fix typo in comments.
632
633 2012-07-14 Leo Liu <sdl.web@gmail.com>
634
635 * fringe.c: Add a new bitmap exclamation-mark.
636
637 2012-07-14 Eli Zaretskii <eliz@gnu.org>
638
639 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
640
641 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
642 (HAVE_MENUS): Don't define, defined by editing config.in with
643 msdos/sed2v2.inp.
644 (GMALLOC_INHIBIT_VALLOC): Don't define.
645 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
646
647 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
648
649 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
650
651 2012-07-14 Glenn Morris <rgm@gnu.org>
652
653 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
654 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
655 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
656
657 2012-07-13 Glenn Morris <rgm@gnu.org>
658
659 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
660
661 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
662 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
663
664 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
665
666 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
667 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
668 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
669 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
670 where appropriate.
671 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
672 as boolean expression.
673 (x_set_window_size): Remove unused variable toolbar.
674 (ns_get_color_default, ns_mod_to_lisp): Remove.
675 (ns_mouse_position): Remove unused variables xchar and ychar.
676 (ns_compute_glyph_string_overhangs): Remove unused variable face.
677 (ns_set_vertical_scroll_bar): Remove unused variable count.
678 (ns_delete_terminal): Remove unused variable i.
679 (ns_term_init): Remove unused variables r, g and b.
680 (mouseDown): Remove unused variable window.
681 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
682 (initFrameFromEmacs): Remove unused variable vbextra.
683 (mouseEntered): Remove unused variables p and dpyinfo.
684 (mouseExited): Remove unused variables p and r.
685 (ns_define_frame_cursor, ns_clear_frame_area)
686 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
687 (menuDown): Assign [sender tag] to variable and cast the variable.
688
689 * nsterm.h (menuDown): Add id as type to argument sender.
690 (ns_display_info_for_name): Add Lisp_Object argument.
691 (ns_term_init): Add Lisp_Object argument.
692 (ns_map_event_to_object): Add void argument.
693 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
694 prototype with arguments and only declare if __OBJC__.
695 (nxatoms_of_nsselect): Add void argument.
696 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
697 (ns_alloc_autorelease_pool): Add void argument.
698 (ns_release_autorelease_pool): Add void* argument.
699 (ns_get_defaults_value): Add const char* argument.
700
701 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
702 (initFromContents): Use SSDATA where appropriate.
703 (ns_update_menubar): Add braces to ambigous if-else.
704 (initWithTitle): Put () around assignment in if statement.
705 (ns_menu_show): Remove unused variables window and keymap.
706 (update_frame_tool_bar): Remove unused variable selected_p.
707 (initWithContentRect): Remove unused variable this_cmd_name.
708
709 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
710 appropriate.
711 (setXBMColor): Remove unused variable len.
712 (setPixmapData): Put () around assignment in loop statement.
713
714 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
715 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
716 where appropriate.
717 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
718 around assignment in loop statement.
719 (nsfont_open): Remove unused variable i.
720 (nsfont_open): Remove unused variable len.
721 (nsfont_draw): Remove unused variable cs.
722
723 * nsfns.m (x_set_icon_name, ns_set_name_internal)
724 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
725 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
726 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
727 (Fns_font_name, Fns_perform_service)
728 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
729 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
730 (ns_set_name): Remove unused variable view.
731 (x_set_menu_bar_lines): Remove unused variable olines.
732 (x_set_tool_bar_lines): Remove unused variable root_window.
733 (Fns_list_colors): Put () around assignment in while statement.
734 (Fns_perform_service): Remove unused variable len.
735 (Fns_display_usable_bounds): Remove unused variable top.
736 (syms_of_nsfns): Remove unused variable i.
737
738 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
739 memcpy (Bug#11907).
740
741 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
742
743 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
744 and free it with DestroyExceptionInfo (Bug#11558).
745
746 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
747
748 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
749 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
750 Set here, not in nt/config.nt.
751
752 2012-07-13 Eli Zaretskii <eliz@gnu.org>
753
754 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
755 cursor overflow into the last glyph on display line when the right
756 fringe is off. (Bug#11832)
757
758 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
759
760 * xdisp.c (produce_special_glyphs): Now static.
761 * dispextern.h (produce_special_glyphs): Remove decl.
762
763 2012-07-13 Glenn Morris <rgm@gnu.org>
764
765 * s/bsd-common, s/cygwin.h: Remove empty files.
766 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
767
768 * s/usg5-4-common.h (USG, USG5):
769 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
770 * s/sol2-6.h (SOLARIS2):
771 * s/irix6-5.h (IRIX6_5):
772 * s/hpux10-20.h (USG, USG5, HPUX):
773 * s/gnu-linux.h (USG, GNU_LINUX):
774 * s/freebsd.h (BSD_SYSTEM):
775 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
776 * s/cygwin.h (CYGWIN):
777 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
778 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
779
780 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
781
782 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
783
784 2012-07-13 Glenn Morris <rgm@gnu.org>
785
786 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
787
788 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
789
790 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
791 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
792
793 2012-07-12 Glenn Morris <rgm@gnu.org>
794
795 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
796
797 * process.c (init_process_emacs): Rename from init_process.
798 The old name is also the name of a Mach system call.
799 * lisp.h, emacs.c: Update for this name change.
800 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
801 longer needed.
802
803 2012-07-12 Eli Zaretskii <eliz@gnu.org>
804
805 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
806 memmove call that removes glyphs covered by the left truncation
807 glyph. Improve commentary.
808 (display_line): Fix display of continuation glyphs on GUI frames
809 when the right fringe is turned off and variable-size fonts are
810 used in the window. Move the code that appends a stretch glyph to
811 produce_special_glyphs, so that it could be used for truncation
812 and continuation glyphs alike.
813 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
814 glyph of a suitably computed width, to align the special glyphs at
815 the window margin. Code moved from display_line. (Bug#11832)
816
817 2012-07-12 Glenn Morris <rgm@gnu.org>
818
819 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
820
821 * s/gnu-linux.h, s/hpux10-20.h:
822 Do not unconditionally define HAVE_XRMSETDATABASE.
823
824 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
825
826 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
827
828 Fix typos that broke OS X build.
829 Reported by Randal L. Schwartz in
830 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
831 * nsterm.m (ns_timeout): Add missing local decl.
832 (ns_get_color): snprintf -> sprintf, to fix typo.
833
834 2012-07-12 Glenn Morris <rgm@gnu.org>
835
836 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
837 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
838 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
839 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
840
841 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
842 Move PTY_OPEN to configure.
843
844 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
845 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
846 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
847
848 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
849
850 Use empty_unibyte_string where applicable.
851 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
852 * lread.c (read1): Likewise.
853 * xsettings.c (syms_of_xsettings): Likewise.
854
855 2012-07-12 Glenn Morris <rgm@gnu.org>
856
857 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
858 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
859 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
860 * s/hpux10-20.h (RUN_TIME_REMAP):
861 * s/bsd-common.h (TABDLY): Move to configure.
862
863 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
864
865 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
866
867 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
868 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
869
870 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
871
872 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
873 * s/template.h: Move NARROWPROTO to configure.
874
875 2012-07-11 Glenn Morris <rgm@gnu.org>
876
877 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
878 unused since 2011-01-17 change to systty.h.
879
880 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
881 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
882 Move HAVE_PTYS and HAVE_SOCKETS to configure.
883
884 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
885
886 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
887
888 2012-07-11 Glenn Morris <rgm@gnu.org>
889
890 * s/darwin.h, s/gnu-linux.h, s/template.h:
891 Move INTERRUPT_INPUT to configure.
892
893 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
894
895 Minor adjustments to interning code.
896 * lisp.h (intern, intern_c_string): Redefine as static inline
897 wrappers for intern_1 and intern_c_string_1, respectively.
898 (intern_1, intern_c_string_1): Rename prototypes.
899 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
900 Vobarray checking.
901 * font.c (font_intern_prop): Likewise. Adjust comment.
902 * w32font.c (intern_font_name): Likewise.
903
904 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
905
906 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
907
908 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
909 of Fcar/Fcdr if possible.
910 * font.c (check_otf_features): Likewise.
911 * fontset.c (Fnew_fontset): Likewise.
912 * gnutls.c (Fgnutls_boot): Likewise.
913 * minibuf.c (read_minibuf): Likewise.
914 * msdos.c (IT_set_frame_parameters): Likewise.
915 * xmenu.c (Fx_popup_dialog): Likewise.
916 * w32menu.c (Fx_popup_dialog): Likewise.
917
918 2012-07-11 Glenn Morris <rgm@gnu.org>
919
920 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
921 since nothing has defined it on these platforms.
922
923 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
924 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
925
926 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
927 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
928 Move CLASH_DETECTION to configure.
929
930 * s/gnu.h: Remove file, which is now empty.
931
932 * s/gnu.h, s/gnu-linux.h:
933 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
934
935 2012-07-11 John Wiegley <johnw@newartisans.com>
936
937 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
938 function attribute, so we only use it if it exists in the
939 compiler.
940
941 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
942
943 Avoid call to strlen in fast_c_string_match_ignore_case.
944 * search.c (fast_c_string_match_ignore_case): Change to use
945 length argument. Adjust users accordingly.
946 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
947
948 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
949
950 Assume mkdir, rmdir.
951 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
952 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
953
954 Assume rename.
955 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
956
957 Assume perror.
958 * s/hpux10-20.h (HAVE_PERROR): Remove.
959 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
960 Remove dummy definition, as this problem was obsolete long ago.
961
962 Assume strerror.
963 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
964
965 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
966
967 Avoid calls to strlen in font processing functions.
968 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
969 (font_open_by_name): Change to use length argument. Adjust
970 users accordingly.
971 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
972 Adjust prototypes.
973 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
974 Change to return ptrdiff_t.
975 (xfont_list_pattern, xfont_match): Use length returned by
976 xfont_decode_coding_xlfd.
977 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
978
979 2012-07-11 Glenn Morris <rgm@gnu.org>
980
981 * s/darwin.h, s/freebsd.h, s/netbsd.h:
982 Move DONT_REOPEN_PTY to configure.
983
984 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
985 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
986
987 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
988
989 Remove "#define unix" that is no longer needed (Bug#11905).
990 * s/aix4-2.h (unix): Remove; no longer needed.
991
992 EMACS_TIME simplification (Bug#11875).
993 This replaces macros (which typically do not work in GDB)
994 with functions, typedefs and enums, making the code easier to debug.
995 The functional style also makes code easier to read and maintain.
996 * systime.h: Include <sys/time.h> on all hosts, not just if
997 WINDOWSNT, since 'struct timeval' is needed in general.
998 (EMACS_TIME): Now a typedef, not a macro.
999 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1000 not macros.
1001 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1002 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1003 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1004 (EMACS_TIME_LE): Now functions, not macros.
1005 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1006 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1007 which are not functions. All uses rewritten to use:
1008 (make_emacs_time): New function.
1009 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1010 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1011 not functions. All uses rewritten to use the following, respectively:
1012 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1013 (add_emacs_time, sub_emacs_time): New functions.
1014 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1015 * fileio.c (Fcopy_file):
1016 * xterm.c (XTflash): Get the current time closer to when it's used.
1017 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1018
1019 * bytecode.c (targets): Suppress -Woverride-init warnings.
1020
1021 Simplify by avoiding confusing use of strncpy etc.
1022 * doc.c (Fsnarf_documentation):
1023 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1024 * frame.c (Fmake_terminal_frame):
1025 * gtkutil.c (get_utf8_string):
1026 * lread.c (openp):
1027 * nsmenu.m (ns_update_menubar):
1028 * regex.c (regerror):
1029 Prefer memcpy to strncpy and strncat when either will do.
1030 * fileio.c (Fsubstitute_in_file_name):
1031 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1032 (menu_separator_name_p):
1033 * nsmenu.m (ns_update_menubar):
1034 Prefer memcmp to strncmp when either will do.
1035 * nsterm.m: Include <ftoastr.h>.
1036 (ns_get_color):
1037 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1038 Prefer snprintf to strncpy.
1039 * nsterm.m (ns_term_init):
1040 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1041 * nsterm.m (ns_term_init):
1042 Avoid the need for strncpy, by using build_string or
1043 make_unibyte_string directly. Use dtoastr, not snprintf.
1044 * process.c (Fmake_network_process): Diagnose service names that
1045 are too long, rather than silently truncating them or creating
1046 non-null-terminated names.
1047 (Fnetwork_interface_info): Likewise, for interface names.
1048 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1049 Prefer sprintf to strncat.
1050 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1051 Prefer vsnprintf to vsprintf + strncpy.
1052
1053 2012-07-10 Glenn Morris <rgm@gnu.org>
1054
1055 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1056 Clarify fallback case.
1057
1058 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1059
1060 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1061 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1062 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1063 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1064 where argument type is known to be a Lisp_Cons.
1065
1066 2012-07-10 Tom Tromey <tromey@redhat.com>
1067
1068 * bytecode.c (BYTE_CODE_THREADED): New macro.
1069 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1070 (enum byte_code_op): New type.
1071 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1072 (exec_byte_code): Use them. Use token threading when applicable.
1073
1074 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1075
1076 Optimize pure C strings initialization.
1077 * lisp.h (make_pure_string): Fix prototype.
1078 (build_pure_c_string): New function, defined as static inline. This
1079 provides a better opportunity to optimize away calls to strlen when
1080 the function is called with compile-time constant argument.
1081 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1082 argument, adjust users accordingly. Use build_pure_c_string where
1083 appropriate.
1084 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1085 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1086 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1087
1088 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1089
1090 Avoid calls to strlen in miscellaneous functions.
1091 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1092 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1093 * lread.c (openp): Likewise.
1094
1095 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1096
1097 Avoid calls to strlen in path processing functions.
1098 * fileio.c (file_name_as_directory): Add comment. Change to add
1099 srclen argument and return the length of result. Adjust users
1100 accordingly.
1101 (directory_file_name): Fix comment. Change to add srclen argument,
1102 swap 1st and 2nd arguments to obey the common convention. Adjust
1103 users accordingly.
1104 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1105
1106 2012-07-10 Glenn Morris <rgm@gnu.org>
1107
1108 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1109 Move PENDING_OUTPUT_COUNT definition to configure.
1110
1111 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1112 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1113 * s/gnu.h (DATA_START): Move definitions to configure.
1114
1115 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1116 We include usg5-4-common.h, which defines them both.
1117
1118 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1119 O_RDONLY already includes it).
1120
1121 Stop ns builds setting the EMACSLOADPATH environment variable.
1122 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1123 Now it does not set EMACSLOADPATH, just returns the load-path string.
1124 * nsterm.h: Update accordingly.
1125 * lread.c [HAVE_NS]: Include nsterm.h.
1126 (init_lread) [HAVE_NS]: Use ns_load_path.
1127 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1128
1129 2012-07-09 Glenn Morris <rgm@gnu.org>
1130
1131 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1132 since the included bsd-common.h does so.
1133
1134 Stop ns builds setting the EMACSPATH environment variable.
1135 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1136 (ns_init_paths): Do not set EMACSPATH.
1137 * nsterm.h (ns_exec_path): Add it.
1138 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1139 Use ns_exec_path.
1140
1141 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1142
1143 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1144
1145 * process.c (wait_reading_process_output): 'waitchannels' was unset
1146 when read_kbd || !NILP (wait_for_cell); fix this.
1147
1148 Add GCC-style 'const' attribute to functions that can use it.
1149 * character.h (char_resolve_modifier_mask):
1150 * keyboard.h (make_ctrl_char):
1151 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1152 (init_character_once, next_almost_prime, init_fns, init_image)
1153 (flush_pending_output, init_sound):
1154 * mem-limits.h (start_of_data):
1155 * menu.h (finish_menu_items):
1156 Add ATTRIBUTE_CONST.
1157 * emacs.c (DEFINE_DUMMY_FUNCTION):
1158 Declare the dummy function with ATTRIBUTE_CONST.
1159 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1160 Add decls with ATTRIBUTE_CONST.
1161
1162 Minor improvements to make_formatted_string.
1163 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1164 where int is good enough, as vsprintf returns an int.
1165 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1166
1167 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1168
1169 Use make_formatted_string to avoid double length calculation.
1170 * lisp.h (make_formatted_string): New prototype.
1171 * alloc.c (make_formatted_string): New function.
1172 * buffer.c (Fgenerate_new_buffer_name): Use it.
1173 * dbus.c (syms_of_dbusbind): Likewise.
1174 * editfns.c (Fcurrent_time_zone): Likewise.
1175 * filelock.c (get_boot_time): Likewise.
1176 * frame.c (make_terminal_frame, set_term_frame_name)
1177 (x_report_frame_params): Likewise.
1178 * image.c (gs_load): Likewise.
1179 * minibuf.c (get_minibuffer): Likewise.
1180 * msdos.c (dos_set_window_size): Likewise.
1181 * process.c (make_process): Likewise.
1182 * xdisp.c (ensure_echo_area_buffers): Likewise.
1183 * xsettings.c (apply_xft_settings): Likewise.
1184
1185 2012-07-09 Glenn Morris <rgm@gnu.org>
1186
1187 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1188 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1189 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1190 * nsterm.h (ns_etc_directory): Add it.
1191 * callproc.c [HAVE_NS]: Include nsterm.h.
1192 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1193
1194 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1195
1196 Move marker debugging code under MARKER_DEBUG.
1197 * marker.c (MARKER_DEBUG): Move marker debugging code under
1198 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1199 for bootstrap with --enable-checking (~3x slowdown reported
1200 by Juanma Barranquero <lekktu@gmail.com>).
1201 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1202
1203 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1204
1205 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1206 See <http://bugs.gnu.org/11825#29>.
1207
1208 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1209
1210 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1211 has no font, use the frame's font. (Bug#11813)
1212 (display_line): Add commentary about displaying truncation glyphs
1213 on GUI frames.
1214 (produce_special_glyphs): Move here from term.c.
1215
1216 * term.c (produce_special_glyphs): Move to xdisp.c.
1217
1218 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1219 section.
1220
1221 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1222
1223 * xdisp.c (display_line): Avoid warning about implicit declaration
1224 of FRAME_FONT.
1225
1226 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1227
1228 * lisp.h: Remove empty conditional.
1229
1230 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1231
1232 * lread.c (load_path_check): Now static.
1233
1234 Fix some minor --with-ns problems found by static checking.
1235 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1236 (x_set_font) [!HAVE_X_WINDOWS]:
1237 * image.c (xpm_load_image) [HAVE_NS]:
1238 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1239 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1240 Remove unused local.
1241 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1242 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1243 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1244 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1245 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1246 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1247 Fix pointer signedness problem.
1248 * xfaces.c (FRAME_X_FONT_TABLE):
1249 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1250
1251 2012-07-07 Glenn Morris <rgm@gnu.org>
1252
1253 * lread.c (load_path_check): New function, split from init_lread.
1254 (init_lread): Reorganize. Motivation:
1255 If EMACSLOADPATH is set, check/warn about that rather than the
1256 defaults, which we are not going to use. Hence we can remove
1257 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1258 Don't warn if site-lisp directories are missing.
1259 If not installed, start from a blank load-path, since
1260 PATH_LOADSEARCH refers to the eventual installation directories.
1261
1262 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1263
1264 Support truncation and continuation glyphs on GUI frames, when
1265 fringes are disabled. (Bug#11832)
1266 * xdisp.c (init_iterator): Get dimensions of truncation and
1267 continuation glyphs even if on GUI frames. Adjust
1268 it->last_visible_x on GUI frames when the left or right fringes,
1269 or both, are absent.
1270 (start_display, move_it_in_display_line_to): Handle the case of a
1271 GUI frame without a fringe to display continuation or truncation
1272 glyphs.
1273 (insert_left_trunc_glyphs): Support GUI frames: make sure
1274 truncation glyphs overwrite enough glyphs from the current line to
1275 have sufficient space in pixels.
1276 (display_line): Support truncation and continuation glyphs on GUI
1277 frames. If some spare pixels are left on the line after inserting
1278 the truncation glyphs, fill that space with a stretch glyph of a
1279 suitably computed width.
1280
1281 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1282 produce_glyphs, to support GUI sessions.
1283
1284 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1287
1288 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1289
1290 Do not require float-time's arg to fit in time_t (Bug#11825).
1291 This works better on hosts where time_t is unsigned, and where
1292 float-time is applied to the (negative) difference between two times.
1293 * editfns.c (decode_time_components): Last arg is now double *,
1294 not int *, and means to store all the result as a double, without
1295 worrying about whether the seconds part fits in time_t.
1296 All callers changed.
1297 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1298 All callers changed.
1299 (Ffloat_time): Do not fail merely because the specified time falls
1300 outside of time_t range.
1301
1302 2012-07-07 Glenn Morris <rgm@gnu.org>
1303
1304 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1305 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1306 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1307
1308 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1309
1310 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1311 Update dependencies.
1312
1313 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1314
1315 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1316
1317 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1318 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1319 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1320 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1321 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1322 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1323
1324 * xfont.c (compare_font_names): Redo to omit the need for casts.
1325
1326 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1327
1328 * xfns.c (Fx_change_window_property): Doc fix.
1329 * w32fns.c (Fx_change_window_property): Doc fix.
1330
1331 * w32fns.c (Fx_window_property): Accept the same arguments as the
1332 X Windows version. Doc fix.
1333 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1334
1335 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1336 Eli Zaretskii <eliz@gnu.org>
1337
1338 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1339 Windows-specific code from nt/config.nt moved here.
1340 Obsolete settings removed.
1341
1342 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1343
1344 * process.c: Avoid unnecessary calls to gettime.
1345 (wait_reading_process_output): Don't get the time of day
1346 when gobbling data immediately and not waiting, as there's no need
1347 for it in that case. This removes a FIXME.
1348
1349 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1350
1351 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1352 is defined (Bug#11768).
1353
1354 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1355
1356 Fix marker debugging code.
1357 * marker.c (byte_char_debug_check): Do not perform the check
1358 if buffer is not multibyte.
1359 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1360 Call byte_char_debug_check with correct arguments.
1361
1362 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1363
1364 Compile marker debugging code only if ENABLE_CHECKING is defined.
1365 * marker.c (byte_char_debug_check, count_markers):
1366 Use only if ENABLE_CHECKING is defined.
1367 (byte_debug_flag): Remove.
1368 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1369 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1370
1371 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1372
1373 Avoid code repetition in marker-related functions.
1374 * marker.c (attach_marker): New function.
1375 (Fset_marker, set_marker_restricted, set_marker_both)
1376 (set_marker_restricted_both): Use it.
1377 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1378 Consistently rename charno to charpos.
1379 (marker_position): Add eassert.
1380 (marker_byte_position): Convert to eassert.
1381
1382 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1383
1384 Simplify list operations in unchain_overlay and unchain_marker.
1385 * buffer.c (unchain_overlay): Simplify. Add comment.
1386 * marker.c (unchain_marker): Simplify. Fix comments.
1387
1388 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1389
1390 Introduce fast path for the widely used marker operation.
1391 * alloc.c (build_marker): New function.
1392 * lisp.h (build_marker): New prototype.
1393 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1394 * composite.c (autocmp_chars): Likewise.
1395 * editfns.c (buildmark): Remove.
1396 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1397 (save_restriction_save): Use build_marker.
1398 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1399 * window.c (save_window_save): Likewise.
1400
1401 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1402
1403 Do not use Fdelete_overlay in delete_all_overlays
1404 to avoid redundant calls to unchain_overlay.
1405 * buffer.c (drop_overlay): New function.
1406 (delete_all_overlays, Fdelete_overlay): Use it.
1407 * minibuf.c (get_minibuffer): Fix comment.
1408
1409 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 Port to OpenBSD 5.1 amd64.
1412 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1413 This is needed for OpenBSD, and should be harmless on all BSD systems.
1414 Also, include <sys/sysctl.h>, as it should be available on all
1415 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1416 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1417 use p_pid member, not kp_proc.pid.
1418
1419 2012-07-06 Glenn Morris <rgm@gnu.org>
1420
1421 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1422
1423 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1424
1425 More xmalloc and related cleanup.
1426 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1427 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1428 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1429 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1430 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1431 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1432 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1433 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1434 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1435 * xterm.c:
1436 Omit needless casts involving void * pointers and allocation.
1437 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1438 as the former is more robust if P's type is changed.
1439 Prefer xzalloc to xmalloc + memset 0.
1440 Simplify malloc-or-realloc to realloc.
1441 Don't worry about xmalloc returning a null pointer.
1442 Prefer xstrdup to xmalloc + strcpy.
1443 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1444 growing it.
1445 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1446 alloca of a constant.
1447
1448 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1449
1450 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1451 hscroll is larger than the line width. Fixes long and futile
1452 looping inside extend_face_to_end_of_line (on a TTY) producing
1453 glyphs that are not needed and thrown away.
1454
1455 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1456
1457 * marker.c (set_marker_restricted_both): Simplify by using
1458 clip_to_bounds.
1459
1460 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1461
1462 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1463
1464 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1465
1466 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1467 not defined (Bug#11768).
1468 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1469 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1470 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1471 followed by gtk_box_set_homogeneous (Bug#11768).
1472 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1473 (update_theme_scrollbar_width, xg_create_scroll_bar):
1474 Use gtk_scrollbar_new (Bug#11768).
1475 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1476 (is_box_type): New function (Bug#11768).
1477 (xg_tool_item_stale_p): Call is_box_type.
1478 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1479 with default display (Bug#11768).
1480
1481 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1482
1483 * xdisp.c (window_hscroll_limited): New function.
1484 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1485 coordinates when window's hscroll is set to insanely large
1486 values. (Bug#11857)
1487
1488 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1489
1490 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1491 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1492
1493 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1494
1495 Cleanup xmalloc.
1496 * lisp.h (xzalloc): New prototype. Omit needless casts.
1497 * alloc.c (xzalloc): New function. Omit needless casts.
1498 * charset.c: Omit needless casts. Convert all calls to
1499 xmalloc with following memset to xzalloc.
1500 * dispnew.c: Likewise.
1501 * fringe.c: Likewise.
1502 * image.c: Likewise.
1503 * sound.c: Likewise.
1504 * term.c: Likewise.
1505 * w32fns.c: Likewise.
1506 * w32font.c: Likewise.
1507 * w32term.c: Likewise.
1508 * xfaces.c: Likewise.
1509 * xfns.c: Likewise.
1510 * xterm.c: Likewise.
1511 * atimer.c: Omit needless casts.
1512 * buffer.c: Likewise.
1513 * callproc.c: Likewise.
1514 * ccl.c: Likewise.
1515 * coding.c: Likewise.
1516 * composite.c: Likewise.
1517 * doc.c: Likewise.
1518 * doprnt.c: Likewise.
1519 * editfns.c: Likewise.
1520 * emacs.c: Likewise.
1521 * eval.c: Likewise.
1522 * filelock.c: Likewise.
1523 * fns.c: Likewise.
1524 * gtkutil.c: Likewise.
1525 * keyboard.c: Likewise.
1526 * lisp.h: Likewise.
1527 * lread.c: Likewise.
1528 * minibuf.c: Likewise.
1529 * msdos.c: Likewise.
1530 * print.c: Likewise.
1531 * process.c: Likewise.
1532 * region-cache.c: Likewise.
1533 * search.c: Likewise.
1534 * sysdep.c: Likewise.
1535 * termcap.c: Likewise.
1536 * terminal.c: Likewise.
1537 * tparam.c: Likewise.
1538 * w16select.c: Likewise.
1539 * w32.c: Likewise.
1540 * w32reg.c: Likewise.
1541 * w32select.c: Likewise.
1542 * w32uniscribe.c: Likewise.
1543 * widget.c: Likewise.
1544 * xdisp.c: Likewise.
1545 * xmenu.c: Likewise.
1546 * xrdb.c: Likewise.
1547 * xselect.c: Likewise.
1548
1549 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1550
1551 * fileio.c (time_error_value): Check the right error number.
1552 Problem reported by Troels Nielsen in
1553 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1554
1555 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1556
1557 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1558 This should be fixed in a better way; see Eli Zaretskii in
1559 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1560 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1561
1562 * fileio.c (time_error_value): Rename from special_mtime.
1563 The old name's problems were noted by Eli Zaretskii in
1564 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1565
1566 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1567 This variable's comment says Emacs needs at least one GDB-visible
1568 symbol of type enum pvec_type, to work around GDB problems.
1569 The symbol's value doesn't matter.
1570
1571 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1572 that causes compilation to fail on pre-C99 compilers.
1573
1574 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1575
1576 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1577 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1578
1579 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1580
1581 * buffer.c (init_buffer_once): Fix initialization of
1582 headers for buffer_defaults and buffer_local_symbols.
1583 Reported by Juanma Barranquero <lekktu@gmail.com>.
1584
1585 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1586
1587 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1588 * lisp.h (enum pvec_type): Use fewer bits.
1589 (PSEUDOVECTOR_SIZE_BITS): New constant.
1590 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1591 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1592 change in pvec_type.
1593 (PSEUDOVECTOR_TYPEP): New macro.
1594 (TYPED_PSEUDOVECTORP): Use it.
1595 * fns.c (internal_equal): Adapt code to extract pvectype.
1596 * emacs.c (gdb_pvec_type): Update type.
1597 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1598 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1599 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1600 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1601 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1602 abusing vector->header.next.nbytes.
1603 (live_vector_p): Use PVEC_TYPE.
1604 (mark_object): Adapt code to extract pvectype. Use switch.
1605
1606 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1609 Tighten new eassert a bit.
1610
1611 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1612
1613 Fix compilation with --enable-gcc-warnings and -O1
1614 optimization level.
1615 * doprnt.c (doprnt): Change type of tem to int, initialize
1616 to avoid compiler warning. Add eassert.
1617 * search.c (simple_search): Initialize match_byte to avoid
1618 compiler warning. Add eassert.
1619
1620 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1621
1622 Avoid weird behavior with large horizontal scrolls.
1623 Without this change, for example, large hscroll values would
1624 mess up Emacs's display on Fedora 15 x86, presumably due to
1625 overflows in int calculations in the display code.
1626 Also, if buffers had long lines, Emacs would freeze.
1627 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1628 (set_window_hscroll): New function, containing the old guts of
1629 Fset_window_hscroll. Return the clipped value.
1630 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1631 This avoids the need to check against PTRDIFF_MAX.
1632
1633 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1634
1635 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1636
1637 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1638
1639 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1640
1641 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1642 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1643 since GCC 4.4.6 issues a bogus warning for them.
1644
1645 Fix bugs in file timestamp newness comparisons.
1646 * fileio.c (Ffile_newer_than_file_p):
1647 * lread.c (Fload): Use full timestamp resolution of files,
1648 not just the 1-second resolution, so that files that are only
1649 slightly newer still count as newer.
1650 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1651 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1652
1653 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1654
1655 * fileio.c: Improve handling of file time marker. (Bug#11852)
1656 (special_mtime): New function.
1657 (Finsert_file_contents, Fverify_visited_file_modtime):
1658 Use it to set special mtime values consistently.
1659
1660 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1661
1662 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1663 marker for non-existing file. (Bug#11852)
1664
1665 2012-07-03 Glenn Morris <rgm@gnu.org>
1666
1667 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1668 and did not make it into globals.h).
1669
1670 2012-07-03 Tom Tromey <tromey@redhat.com>
1671
1672 * window.c (Fset_window_margins, Fset_window_fringes)
1673 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1674 * textprop.c (Fprevious_property_change): No longer static.
1675 * syntax.c (Fsyntax_table_p): No longer static.
1676 * process.c (Fget_process, Fprocess_datagram_address): No longer
1677 static.
1678 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1679 * keyboard.c (Fcommand_execute): No longer static.
1680 Remove EXFUN.
1681 * insdel.c (Fcombine_after_change_execute): No longer static.
1682 * image.c (Finit_image_library): No longer static.
1683 * fileio.c (Fmake_symbolic_link): No longer static.
1684 * eval.c (Ffetch_bytecode): No longer static.
1685 * editfns.c (Fuser_full_name): No longer static.
1686 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1687 No longer static.
1688 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1689 static.
1690 * dired.c (Ffile_attributes): No longer static.
1691 * composite.c (Fcomposition_get_gstring): No longer static.
1692 * callproc.c (Fgetenv_internal): No longer static.
1693
1694 * ccl.h: Remove EXFUNs.
1695 * buffer.h: Remove EXFUNs.
1696 * dispextern.h: Remove EXFUNs.
1697 * intervals.h: Remove EXFUNs.
1698 * fontset.h: Remove EXFUN.
1699 * font.h: Remove EXFUNs.
1700 * dosfns.c (system_process_attributes): Remove EXFUN.
1701 * keymap.h: Remove EXFUNs.
1702 * lisp.h: Remove EXFUNs.
1703 * w32term.h: Remove EXFUNs.
1704 * window.h: Remove EXFUNs.
1705 * xsettings.h: Remove EXFUN.
1706 * xterm.h: Remove EXFUN.
1707
1708 2012-07-03 Glenn Morris <rgm@gnu.org>
1709
1710 * lisp.h (Frandom): Make it visible to C.
1711 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1712 buffer for invisible buffers. (Bug#1229)
1713
1714 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1715
1716 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1717 values which aren't power of 2.
1718 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1719 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1720 accordingly.
1721
1722 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1723
1724 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1725
1726 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1727
1728 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1729
1730 * alloc.c (allocate_vector_block): Remove redundant
1731 calls to mallopt if DOUG_LEA_MALLOC is defined.
1732 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1733 avoid calls to mallopt if zero_vector is returned.
1734
1735 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1736
1737 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1738 is enabled, avoid dereferencing NULL current_sblock if
1739 running undumped.
1740
1741 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1742
1743 Cleanup basic buffer management.
1744 * buffer.h (struct buffer): Change layout to use generic vector
1745 marking code. Fix some comments. Change type of 'clip_changed'
1746 to bitfield. Remove unused #ifndef old.
1747 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1748 (GET_OVERLAYS_AT): Fix indentation.
1749 (for_each_per_buffer_object_at): New macro.
1750 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1751 (Fbuffer_local_variables): Use it.
1752 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1753 * alloc.c (allocate_buffer): Adjust to match new layout of
1754 struct buffer. Fix comment.
1755 (mark_overlay): New function.
1756 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1757 Lisp area of struct buffer.
1758 (mark_object): Use it. Adjust marking of misc objects
1759 and related comments.
1760
1761 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1764 wrapper that is not needed because the wrapped code is a no-op (zero
1765 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1766 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1767
1768 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1769
1770 * alloc.c (mark_buffer): Simplify. Remove prototype.
1771 (mark_object): Add comment. Reorganize marking of vector-like
1772 objects. Use CHECK_LIVE for all vector-like objects except buffers
1773 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1774 redundant calls to mark_vectorlike for bool vectors.
1775
1776 2012-06-30 Glenn Morris <rgm@gnu.org>
1777
1778 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1779
1780 * epaths.in (PATH_SITELOADSEARCH): New.
1781 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1782 This is rather than relying on --enable-locallisppath elements
1783 having "site-lisp" in their names. (Bug#10208#25, 11658)
1784
1785 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1786
1787 * w32proc.c (sys_select): Accept and ignore one more argument.
1788
1789 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1790
1791 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1792 (pselect) [!MS_DOS]: Redirect to sys_select.
1793
1794 * sysdep.c: Don't include dos.h and dosfns.h.
1795
1796 * process.c (sys_select):
1797 * msdos.c (sys_select): Accept one more argument and ignore it.
1798
1799 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1800 adapt data types and code to that.
1801
1802 * dosfns.c:
1803 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1804 which clashes with the gnulib function of the same name.
1805
1806 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1807
1808 * font.c (font_style_to_value, font_style_symbolic)
1809 (font_prop_validate_style): Add type checks for values in
1810 font_style_table.
1811
1812 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1813 argument.
1814 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1815 uses.
1816
1817 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1818
1819 * xdisp.c (try_window_id): Undo last change.
1820
1821 * w32.c (getwd): Adjust commentary about startup_dir.
1822 (init_environment): Always call sys_access, even in non-MSVC
1823 builds. Don't chdir to the directory of the Emacs executable.
1824 This undoes code from 1997 which was justified by the need to
1825 "avoid conflicts when removing and renaming directories". But its
1826 downside was that every relative file name was being interpreted
1827 relative to the directory of the Emacs executable, which can never
1828 be TRT. In particular, it broke sys_access when called with
1829 relative file names.
1830 (sys_access): Map GetLastError to errno.
1831
1832 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1833
1834 * window.h (struct window): Change type of 'fringes_outside_margins'
1835 to bitfield. Fix comment. Adjust users accordingly.
1836 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1837 Adjust comment.
1838 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1839 to ptrdiff_t.
1840
1841 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1842
1843 * gnutls.c (emacs_gnutls_handshake):
1844 Add QUIT to make the loop interruptible.
1845
1846 2012-06-29 Glenn Morris <rgm@gnu.org>
1847
1848 * charset.c (init_charset): Make lack of etc/charsets fatal.
1849
1850 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1851
1852 * editfns.c (region_limit): Fix type mismatch.
1853
1854 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1855
1856 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1857 undefined. Convert from xassert to eassert.
1858 * nsmenu.m: Convert from xassert to eassert.
1859 * nsterm.m: Likewise.
1860
1861 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1862
1863 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1864
1865 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 Avoid integer overflow on scroll-left and scroll-right.
1868 * window.c (HSCROLL_MAX): New macro.
1869 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1870 overflow when requested scroll falls outside ptrdiff_t range.
1871
1872 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1873
1874 * window.h (struct window): Change type of 'hscroll',
1875 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1876 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1877 Adjust users accordingly.
1878 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1879 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1880 from EMACS_INT to ptrdiff_t.
1881 (make_window): Omit redundant initialization.
1882
1883 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1884
1885 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1886
1887 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1888
1889 * window.h (struct window): Change type of 'use_time' and
1890 'sequence_number' from Lisp_Object to int.
1891 * frame.c (make_frame): Adjust users accordingly.
1892 * print.c (print_object): Likewise.
1893 * window.c (select_window, Fwindow_use_time, make_parent_window)
1894 (make_window): Likewise.
1895
1896 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1897
1898 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1899 enabled with --enable-checking=[all,glyphs] configure option.
1900 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1901 adjust comments accordingly.
1902 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1903 undefined, adjust comments accordingly.
1904 * image.c: Likewise.
1905 * scroll.c: Likewise.
1906 * w32fns.c: Likewise.
1907 * w32term.c: Likewise.
1908 * xdisp.c: Likewise.
1909 * xfaces.c: Likewise.
1910 * xfns.c: Likewise.
1911 * xterm.c: Likewise.
1912
1913 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1914
1915 Generalize run-time debugging checks.
1916 * dispextern.h (XASSERTS): Remove.
1917 * fontset.c (xassert): Remove.
1918 Convert from xassert to eassert.
1919 * alloc.c: Convert from xassert to eassert.
1920 * bidi.c: Likewise.
1921 * dispnew.c: Likewise.
1922 * fns.c: Likewise.
1923 * fringe.c: Likewise.
1924 * ftfont.c: Likewise.
1925 * gtkutil.c: Likewise.
1926 * image.c: Likewise.
1927 * keyboard.c: Likewise.
1928 * menu.c: Likewise.
1929 * process.c: Likewise.
1930 * scroll.c: Likewise.
1931 * sound.c: Likewise.
1932 * term.c: Likewise.
1933 * w32console.c: Likewise.
1934 * w32fns.c: Likewise.
1935 * w32term.c: Likewise.
1936 * window.c: Likewise.
1937 * xdisp.c: Likewise.
1938 * xfaces.c: Likewise.
1939 * xfns.c: Likewise.
1940 * xselect.c: Likewise.
1941 * xterm.c: Likewise.
1942
1943 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1944
1945 * fns.c (maybe_resize_hash_table): Output message when growing the
1946 purify-hashtable.
1947
1948 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1949
1950 * alloc.c (allocate_string_data): Remove dead code.
1951 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1952 avoid GCC warning about unused macro.
1953
1954 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1955
1956 * alloc.c (allocate_string): Omit intervals initialization.
1957 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1958 as in make_pure_string and make_pure_c_string.
1959
1960 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1961
1962 * alloc.c (allocate_string): Fix last change.
1963
1964 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1965
1966 * alloc.c (allocate_string): Remove two redundant calls
1967 to memset, add explicit initialization where appropriate.
1968
1969 2012-06-27 Glenn Morris <rgm@gnu.org>
1970
1971 * lisp.mk (lisp): Remove paths.elc.
1972
1973 2012-06-27 Chong Yidong <cyd@gnu.org>
1974
1975 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1976
1977 2012-06-26 John Wiegley <johnw@newartisans.com>
1978
1979 * unexmacosx.c (copy_data_segment): Add two section names used
1980 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1981
1982 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1983 when building with Clang.
1984
1985 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1986
1987 * eval.c (Fapply): Allow calling it with a single argument.
1988
1989 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1990
1991 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1992 _stricmp and _strnicmp.
1993 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1994
1995 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1996
1997 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1998 allocated window.
1999 (allocate_process): Likewise for new process.
2000 (allocate_terminal): Change to use offsetof.
2001 (allocate_frame): Likewise.
2002 * frame.c (make_frame): Omit redundant initialization.
2003 * window.c (make_parent_window): Use memset.
2004 (make_window): Omit redundant initialization.
2005 * process.c (make_process): Omit redundant initialization.
2006 * terminal.c (create_terminal): Likewise.
2007
2008 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2009
2010 * term.c (delete_tty): Remove redundant call to memset.
2011
2012 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2013
2014 * alloc.c: Remove build_string.
2015 * lisp.h: Define build_string as static inline. This provides
2016 a better opportunity to optimize away calls to strlen when the
2017 function is called with compile-time constant argument.
2018 * image.c (imagemagick_error): Convert to build_string.
2019 * w32proc.c (sys_spawnve): Likewise.
2020 * xterm.c (x_term_init): Likewise.
2021
2022 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 Use sprintf return value instead of invoking strlen on result.
2025 In the old days this wasn't portable, since some sprintf
2026 implementations returned char *. But they died out years ago and
2027 Emacs already assumes sprintf returns int.
2028 Similarly for float_to_string.
2029 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2030 * ccl.c (ccl_driver):
2031 * character.c (string_escape_byte8):
2032 * data.c (Fnumber_to_string):
2033 * doprnt.c (doprnt):
2034 * print.c (print_object):
2035 * xdisp.c (message_dolog):
2036 * xfns.c (syms_of_xfns):
2037 Use sprintf or float_to_string result to avoid need to call strlen.
2038 * data.c (Fnumber_to_string):
2039 Use make_unibyte_string, since the string must be ASCII.
2040 * lisp.h, print.c (float_to_string): Now returns int length.
2041 * term.c (produce_glyphless_glyph):
2042 Use sprintf result rather than recomputing it.
2043
2044 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2045 * Makefile.in (ALL_CFLAGS):
2046 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2047 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2048
2049 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2050
2051 * dispextern.h (xstrcasecmp): Define to library function
2052 strcasecmp if available.
2053 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2054
2055 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2056
2057 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2058 Avoid comma operator.
2059 * menu.c (push_submenu_start, push_submenu_end)
2060 (push_left_right_boundary, push_menu_pane): Likewise.
2061 * msdos.c (dos_rawgetc): Likewise.
2062
2063 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2064
2065 * xfns.c (xic_create_fontsetname): Remove redundant calls
2066 to memset.
2067
2068 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2069
2070 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2071 sprintf already null-terminates its output.
2072
2073 * xfns.c (x_window): Remove redundant cast.
2074
2075 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2076
2077 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2078 `const char *' to `char *' to avoid compiler warning.
2079
2080 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2081
2082 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2083 instead of truncating it to 63 (admittedly a generous limit).
2084
2085 * process.c: Fix spelling and caps in comments.
2086
2087 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2088
2089 * emacs.c (setpgrp): Remove definition, unused.
2090 * sysdep.c (setpgrp): Remove definition, not used in this file.
2091
2092 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2093
2094 * makefile.w32-in: Update dependencies.
2095
2096 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2097
2098 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2099 (SYSTIME_H): Add nt/inc/sys/time.h.
2100
2101 * systime.h [WINDOWSNT]: Include sys/time.h.
2102
2103 * s/ms-w32.h (struct timespec): Definition moved from
2104 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2105
2106 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2107
2108 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2109 * buffer.h (buffer_slot_type_mismatch):
2110 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2111 * eval.c (unwind_to_catch):
2112 * image.c (my_png_error, my_error_exit):
2113 * keyboard.c (quit_throw_to_read_char, user_error)
2114 (Fexit_recursive_edit, Fabort_recursive_edit):
2115 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2116 (wrong_type_argument, buffer_overflow, __executable_start)
2117 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2118 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2119 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2120 (fatal):
2121 (child_setup) [!DOS_NT]:
2122 * lread.c (end_of_file_error, invalid_syntax):
2123 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2124 * puresize.h (pure_write_error):
2125 * search.c (matcher_overflow):
2126 * sound.c (sound_perror, alsa_sound_perror):
2127 * sysdep.c, syssignal.h (croak):
2128 * term.c (maybe_fatal, vfatal):
2129 * textprop.c (text_read_only):
2130 * undo.c (user_error):
2131 * unexmacosx.c (unexec_error):
2132 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2133 Use _Noreturn rather than NO_RETURN.
2134 No need for separate decl merely because of _Noreturn.
2135 * sound.c (sound_warning, parse_sound):
2136 Remove unnecessary forward decls.
2137
2138 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2141 * lisp.h (WAIT_READING_MAX): New macro.
2142 * dispnew.c (Fsleep_for, sit_for):
2143 * keyboard.c (kbd_buffer_get_event):
2144 * process.c (Faccept_process_output):
2145 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2146 This improves on the previous patch, which introduced a bug
2147 when time_t is unsigned and as wide as intmax_t.
2148 See <http://bugs.gnu.org/9000#51>.
2149
2150 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2151
2152 * dispnew.c (sit_for, Fsleep_for):
2153 * keyboard.c (kbd_buffer_get_event):
2154 * process.c (Faccept_process_output): Avoid compiler warnings when
2155 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2156
2157 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2158
2159 * makefile.w32-in: Update dependencies.
2160
2161 * w32.c (ltime): Add return type and declare static.
2162 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2163
2164 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2165
2166 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2167 Privately reported by Herbert J. Skuhra.
2168 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2169 All uses changed.
2170 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2171 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2172
2173 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2174
2175 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2176 last argument of make_unibyte_string.
2177
2178 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2179 language ID in the event parameters.
2180
2181 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2182 event.code, not the obscure "character set ID".
2183
2184 2012-06-23 Chong Yidong <cyd@gnu.org>
2185
2186 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2187
2188 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2189
2190 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2191 * w32.c (fdutimens): New function.
2192
2193 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2194
2195 * s/ms-w32.h (pselect): Redirect to sys_select.
2196
2197 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2198
2199 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2200 in the logic of incrementing and decrementing the value of
2201 use_relocatable_buffers.
2202
2203 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2204
2205 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2206 Privately reported by Herbert J. Skuhra.
2207 [__FreeBSD__]: Remove "*/" typo after "#include".
2208 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2209 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2210 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2211 Don't assume EMACS_TIME and struct timeval are the same type.
2212
2213 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2214
2215 Support higher-resolution time stamps (Bug#9000).
2216 The time stamps are only nanosecond-resolution at the C level,
2217 since that's the best that any real-world system supports now.
2218 But they are picosecond-resolution at the Lisp level, as that's
2219 easy, and leaves room for future OS improvements.
2220
2221 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2222 (LIBES): Use it.
2223
2224 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2225 Don't get current time unless it's needed.
2226
2227 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2228 now provides it if it's absent.
2229 (start_atimer): Port to higher-res time stamps.
2230 Check for time stamp overflow. Don't get current time more
2231 often than is needed.
2232
2233 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2234 Include systime.h, not time.h.
2235 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2236
2237 * dired.c: Include stat-time.h.
2238 (Ffile-attributes): File times now have higher resolution.
2239
2240 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2241 (struct image): Timestamp now has higher resolution.
2242
2243 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2244 has at least microseconds now. All uses removed.
2245 (update_frame, update_single_window, update_window, update_frame_1)
2246 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2247
2248 * editfns.c (time_overflow): Now extern.
2249 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2250 (float-time, Fformat_time_string, Fcurrent_time_string)
2251 (Fcurrent_time_zone): Accept and generate higher-resolution
2252 time stamps.
2253 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2254 (decode_time_components, lisp_seconds_argument): New functions.
2255 (make_time): Now static.
2256 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2257 Report an error if the time is invalid, rather than having the caller
2258 do that.
2259
2260 * fileio.c: Include <stat-time.h>
2261 (Fcopy_file): Copy higher-resolution time stamps.
2262 Prefer to set the time stamp via a file descriptor if that works.
2263 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2264 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2265 (Fvisited_file_modtime, Fset_visited_file_modtime):
2266 Support higher-resolution time stamps.
2267
2268 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2269
2270 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2271
2272 * image.c (prepare_image_for_display, clear_image_cache)
2273 (lookup_image): Port to higer-resolution time stamps.
2274
2275 * keyboard.c (start_polling, bind_polling_period):
2276 Check for time stamp overflow.
2277 (read_char, kbd_buffer_get_event, timer_start_idle)
2278 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2279 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2280 Port to higher-resolution time stamps. Do not assume time_t is signed.
2281 (decode_timer): New function. Timers are now vectors of length 9,
2282 not 8, to accommodate the picosecond component.
2283 (timer_check_2): Use it.
2284
2285 * nsterm.m (select_timeout, timeval_subtract): Remove.
2286 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2287 as they're a bit more accurate and handle overflow better.
2288 (ns_select): Change prototype to be compatible with pselect.
2289 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2290 * nsterm.h (ns_select): Adjust prototype.
2291
2292 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2293 us-resolution time stamps.
2294 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2295
2296 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2297
2298 * lisp.h (time_overflow): New decl.
2299 (wait_reading_process_output): First arg is now intmax_t, not int,
2300 to accommodate larger waits.
2301
2302 * process.h (struct Lisp_Process.read_output_delay):
2303 Now counts nanoseconds, not microseconds.
2304 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2305 EMACS_HAS_USECS.
2306 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2307 (wait_reading_process_output):
2308 Port to ns-resolution time stamps.
2309 (Faccept_process_output, wait_reading_process_output):
2310 Check for time stamp overflow. Do not assume time_t is signed.
2311 (select_wrapper): Remove; we now use pselect.
2312 (Fprocess_attributes): Now generates ns-resolution time stamps.
2313
2314 * sysdep.c: Include utimens.h. Don't include utime.h
2315 or worry about struct utimbuf; gnulib does that for us now.
2316 (gettimeofday): Remove; gnulib provides a substitute.
2317 (make_timeval): New function.
2318 (set_file_times): Now sets ns-resolution time stamps.
2319 New arg FD; all uses changed.
2320 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2321 (system_process_attributes):
2322 Now returns ns-resolution time stamp. All uses changed.
2323 Check for time stamp overflow.
2324
2325 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2326 provides a substitute now.
2327
2328 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2329 since it guarantees struct timespec.
2330 (EMACS_TIME): Now struct timespec, so that we can support
2331 ns-resolution time stamps.
2332 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2333 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2334 (EMACS_USECS): Remove.
2335 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2336 so multiply the arg by 1000 before storing it.
2337 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2338 New macros.
2339 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2340 Port to ns-resolution time stamps.
2341 (EMACS_TIME_NEG_P): Remove; replaced by....
2342 (EMACS_TIME_SIGN): New macro.
2343 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2344 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2345 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2346 (make_timeval, make_lisp_time, decode_time_components): New decls.
2347 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2348 that it mishandled time_t overflow. You can't compare by subtracting!
2349 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2350 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2351
2352 * term.c: Include <sys/time.h>.
2353 (timeval_to_Time): New function, for proper overflow wraparound.
2354 (term_mouse_position, term_mouse_click): Use it.
2355
2356 * undo.c (record_first_change): Support higher-resolution time stamps
2357 in the undo buffer.
2358 (Fprimitive_undo): Use them when restoring time stamps.
2359
2360 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2361 (w32_get_internal_run_time):
2362 Port to higher-resolution Emacs time stamps.
2363 (ltime): Now accepts single 64-bit integer, as that's more convenient
2364 for callers.
2365
2366 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2367
2368 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2369 for compatibility with pselect. Support ns-resolution time stamps.
2370
2371 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2372
2373 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2374 Check for time stamp overflow, and support ns-resolution time stamps.
2375
2376 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2377 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2378 (timeval_subtract): Remove; no longer needed.
2379 (XTflash, XTring_bell, x_wait_for_event):
2380 Port to ns-resolution time stamps. Don't assume time_t is signed.
2381
2382 2012-06-22 Chong Yidong <cyd@gnu.org>
2383
2384 * xdisp.c (x_consider_frame_title): Revert last change.
2385
2386 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2387
2388 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2389 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2390 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2391 staticidx goes up to 1597 out of 1600 = 0x640.)
2392
2393 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2394
2395 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2396 Otherwise, the umask might be mistakenly 0 while handling input signals.
2397
2398 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2399
2400 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2401
2402 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2403
2404 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2405 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2406 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2407 access to `contents' member of Lisp_Vector objects with AREF and ASET
2408 where appropriate.
2409
2410 2012-06-19 Chong Yidong <cyd@gnu.org>
2411
2412 * frame.c (delete_frame): When selecting a frame on a different
2413 text terminal, do not alter the terminal's top-frame.
2414
2415 * xdisp.c (format_mode_line_unwind_data): Record the target
2416 frame's selected window and its terminal's top-frame.
2417 (unwind_format_mode_line): Restore them.
2418 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2419 Callers changed.
2420 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2421 since tty frames can be explicitly named.
2422 (prepare_menu_bars): Likewise.
2423
2424 * term.c (Ftty_top_frame): New function.
2425
2426 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2427
2428 Port byte-code-meter to modern targets.
2429 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2430 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2431 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2432 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2433 (METER_1, METER_2): Simplify.
2434
2435 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2436
2437 * data.c (Fdefalias): Return `symbol' (bug#11686).
2438
2439 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2440
2441 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2442 gets killed during executing of this function (Bug#11665).
2443 Try to always return Qt when the buffer has been actually killed.
2444 (Vkill_buffer_query_functions): In doc-string say that functions
2445 run by this hook should not change the current buffer.
2446
2447 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2448
2449 Fix recently-introduced process.c problems found by static checking.
2450 * process.c (write_queue_push, write_queue_pop, send_process):
2451 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2452 (write_queue_pop): Fix pointer signedness problem.
2453 (send_process): Remove unused local.
2454
2455 2012-06-17 Chong Yidong <cyd@gnu.org>
2456
2457 * xdisp.c (redisplay_internal): No need to redisplay terminal
2458 frames that are not on top.
2459
2460 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2461
2462 * process.c (make_process): Initialize write_queue.
2463 (write_queue_push, write_queue_pop): New functions.
2464 (send_process): Use them to maintain correct ordering of process
2465 writes (Bug#10815).
2466
2467 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2468
2469 * lisp.h (eassert): Assume C89 or later.
2470 This removes the need for CHECK.
2471 (CHECK): Remove. Its comments about always evaluating its
2472 argument were confusing, as 'eassert' typically does not evaluate
2473 its argument.
2474
2475 * coding.c (produce_chars): Use ptrdiff_t, not int.
2476
2477 * xterm.c (x_draw_underwave): Check for integer overflow.
2478 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2479
2480 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2481
2482 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2483 referenced (Bug#11583).
2484
2485 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2486
2487 Implement wave-style variant of underlining.
2488 * dispextern.h (face_underline_type): New enum.
2489 (face): Add field for underline type.
2490 * nsterm.m (ns_draw_underwave): New function.
2491 (ns_draw_text_decoration): Use it.
2492 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2493 New functions.
2494 (x_draw_glyph_string): Use them.
2495 * xfaces.c (Qline, Qwave): New Lisp objects.
2496 (check_lface_attrs, merge_face_ref)
2497 (Finternal_set_lisp_face_attribute, realize_x_face):
2498 Handle wave-style underline face attributes.
2499 * xterm.c (x_draw_underwave): New function.
2500 (x_draw_glyph_string): Use it.
2501
2502 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2503
2504 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2505 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2506 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2507 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2508 ($(BLD)/w32select.$(O)): Update dependencies.
2509
2510 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2511
2512 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2513 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2514 * character.c (_fetch_multibyte_char_p): Remove.
2515 * alloc.c: Include "character.h" before "buffer.h".
2516 * bidi.c: Likewise.
2517 * buffer.c: Likewise.
2518 * bytecode.c: Likewise.
2519 * callint.c: Likewise.
2520 * callproc.c: Likewise.
2521 * casefiddle.c: Likewise.
2522 * casetab.c: Likewise.
2523 * category.c: Likewise.
2524 * cmds.c: Likewise.
2525 * coding.c: Likewise.
2526 * composite.c: Likewise.
2527 * dired.c: Likewise.
2528 * dispnew.c: Likewise.
2529 * doc.c: Likewise.
2530 * dosfns.c: Likewise.
2531 * editfns.c: Likewise.
2532 * emacs.c: Likewise.
2533 * fileio.c: Likewise.
2534 * filelock.c: Likewise.
2535 * font.c: Likewise.
2536 * fontset.c: Likewise.
2537 * fringe.c: Likewise.
2538 * indent.c: Likewise.
2539 * insdel.c: Likewise.
2540 * intervals.c: Likewise.
2541 * keyboard.c: Likewise.
2542 * keymap.c: Likewise.
2543 * lread.c: Likewise.
2544 * macros.c: Likewise.
2545 * marker.c: Likewise.
2546 * minibuf.c: Likewise.
2547 * nsfns.m: Likewise.
2548 * nsmenu.m: Likewise.
2549 * print.c: Likewise.
2550 * process.c: Likewise.
2551 * regex.c: Likewise.
2552 * region-cache.c: Likewise.
2553 * search.c: Likewise.
2554 * syntax.c: Likewise.
2555 * term.c: Likewise.
2556 * textprop.c: Likewise.
2557 * undo.c: Likewise.
2558 * unexsol.c: Likewise.
2559 * w16select.c: Likewise.
2560 * w32fns.c: Likewise.
2561 * w32menu.c: Likewise.
2562 * window.c: Likewise.
2563 * xdisp.c: Likewise.
2564 * xfns.c: Likewise.
2565 * xmenu.c: Likewise.
2566 * xml.c: Likewise.
2567 * xselect.c: Likewise.
2568
2569 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2570
2571 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2572 If all the glyphs of the glyph row came from strings, and we have no
2573 cursor positioning clues, put the cursor on the first glyph of the
2574 row.
2575 (handle_face_prop): Use chunk-relative overlay string index when
2576 indexing into it->string_overlays array. (Bug#11653)
2577 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2578 the rightmost. (Bug#11720)
2579
2580 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2581
2582 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2583 (CATEGORY_MEMBER): Enforce 1/0 value.
2584 * category.c (_temp_category_set): Remove.
2585
2586 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2587
2588 * window.c (Fdelete_other_windows_internal)
2589 (Fdelete_window_internal): Don't access frame's mouse highlight
2590 info of the initial frame. (Bug#11677)
2591
2592 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2593
2594 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2595 Assume USE_2_TAGS_FOR_INTS.
2596 (xreload): Adjust $tagmask width to match recent lisp.h change.
2597
2598 Simplify lisp.h in minor ways that should not affect code.
2599 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2600 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2601 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2602 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2603 (INTTYPEBITS): New macro, for clarity.
2604 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2605 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2606 Simplify now that USE_LSB_TAG is always defined.
2607 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2608 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2609
2610 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2611
2612 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2613
2614 2012-06-13 Glenn Morris <rgm@gnu.org>
2615
2616 * s/bsd-common.h (BSD4_3):
2617 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2618
2619 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2620
2621 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2622 instead of union.
2623 (XLI, XIL): Define.
2624 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2625 Use them.
2626 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2627 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2628 * alloc.c (widen_to_Lisp_Object): Remove.
2629 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2630 * frame.c (delete_frame): Remove outdated comment.
2631 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2632 USE_LISP_UNION_TYPE.
2633 (Fw32_unregister_hot_key): Likewise.
2634 (Fw32_toggle_lock_key): Likewise.
2635 * w32menu.c (add_menu_item): Likewise.
2636 (w32_menu_display_help): Use XIL instead of checking
2637 USE_LISP_UNION_TYPE.
2638 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2639 (init_heap): Likewise.
2640 * w32term.c (w32_read_socket): Update comment.
2641
2642 2012-06-13 Glenn Morris <rgm@gnu.org>
2643
2644 * s/usg5-4-common.h, src/s/unixware.h:
2645 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2646
2647 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2648
2649 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2650
2651 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2652 * alloc.c (make_number) [!defined make_number]:
2653 Remove, as lisp.h always defines this now.
2654 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2655 (roundup_size): Verify that it is a power of 2.
2656 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2657 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2658 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2659 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2660 USE_LSB_TAG now is always defined to be either 0 or 1.
2661 All uses changed.
2662 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2663 code works fine either way, and efficiency is not a concern here,
2664 as the union type is for debugging, not for production.
2665 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2666 Use an inline function on all platforms when using the union type,
2667 since this is simpler and 'static inline' can be used portably
2668 within Emacs now.
2669 (LISP_INITIALLY_ZERO): New macro.
2670 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2671 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2672
2673 2012-06-12 Glenn Morris <rgm@gnu.org>
2674
2675 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2676
2677 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2678
2679 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2680 Move BROKEN_SIGIO to configure.
2681
2682 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2683 Move NO_TERMIO to configure.
2684
2685 2012-06-12 Chong Yidong <cyd@gnu.org>
2686
2687 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2688 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2689 MagickExportImagePixels is undefined.
2690
2691 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 * image.c (imagemagick_load_image): Remove unused label.
2694
2695 2012-06-11 Glenn Morris <rgm@gnu.org>
2696
2697 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2698 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2699 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2700 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2701
2702 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2703
2704 * alloc.c (make_byte_code): New function.
2705 (Fmake_byte_code): Use it. Don't purify here.
2706 * lread.c (read1): Use it as well to avoid extra allocation.
2707
2708 2012-06-11 Chong Yidong <cyd@gnu.org>
2709
2710 * image.c (imagemagick_load_image): Implement transparency.
2711
2712 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2713
2714 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2715 account for preceding backslashes. (Bug#11663)
2716
2717 2012-06-09 Chong Yidong <cyd@gnu.org>
2718
2719 * term.c: Support italics in capable terminals (Bug#9652).
2720 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2721 (turn_on_face): Output using TS_enter_italic_mode if available.
2722 Don't handle unused blinking and alt-charset cases.
2723 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2724 and tty_alt_charset_p cases.
2725 (tty_capable_p, init_tty): Support italics.
2726
2727 * termchar.h (struct tty_display_info): Add field for italics.
2728 Remove unused blink field.
2729
2730 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2731 Handle slant.
2732
2733 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2734 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2735 tty_alt_charset_p. Add tty_italic_p.
2736
2737 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2738
2739 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2740 dbus_type_is_basic if available.
2741 (xd_extract_signed, xd_extract_unsigned): Rename from
2742 extract_signed and extract_unsigned, respectively. Adapt callers.
2743
2744 2012-06-09 Chong Yidong <cyd@gnu.org>
2745
2746 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2747
2748 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2749 case (Bug#9752).
2750
2751 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2752
2753 * xdisp.c (vmessage): Treat frame message as multibyte.
2754 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2755 would generate the diagnostic "Making \302\247 buffer-local while
2756 let-bound!".
2757
2758 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2759
2760 * dispnew.c (showing_window_margins_p): Undo last change, which
2761 was done due to an inadvertent commit.
2762 (adjust_frame_glyphs_for_frame_redisplay): Do call
2763 showing_window_margins_p.
2764
2765 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2766
2767 * eval.c (Fmake_var_non_special): New primitive.
2768 (syms_of_eval): Defsubr it.
2769 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2770
2771 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2772
2773 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2774 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2775
2776 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2777
2778 * alloc.c (allocate_vectorlike): Fix last change.
2779
2780 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2781
2782 Block-based vector allocation of small vectors.
2783 * lisp.h (struct vectorlike_header): New field `nbytes',
2784 adjust comment accordingly.
2785 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2786 to denote vector blocks. Adjust users (live_vector_p,
2787 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2788 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2789 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2790 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2791 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2792 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2793 (roundup_size): New constant.
2794 (struct vector_block): New data type.
2795 (vector_blocks, vector_free_lists, zero_vector): New variables.
2796 (all_vectors): Rename to `large_vectors'.
2797 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2798 (sweep_vectors): New functions.
2799 (allocate_vectorlike): Return `zero_vector' as the only vector of
2800 0 items. Allocate new vector from block if vector size is less than
2801 or equal to VBLOCK_BYTES_MAX.
2802 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2803 (init_alloc_once): Add call to init_vectors.
2804
2805 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2806
2807 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2808
2809 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 * doprnt.c (doprnt): Truncate multibyte char correctly.
2812 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2813 would mishandle a string argument "Xc" if X was a multibyte
2814 character of length 2: it would truncate after X's first byte
2815 rather than including all of X.
2816
2817 2012-06-06 Chong Yidong <cyd@gnu.org>
2818
2819 * buffer.c (word_wrap): Doc fix.
2820
2821 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2824
2825 2012-06-03 Glenn Morris <rgm@gnu.org>
2826
2827 * xdisp.c (tool-bar-style): Doc fix.
2828
2829 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2830
2831 * Makefile.in (PAXCTL): Define.
2832 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2833 binary via PaX flags if the paxctl utility is available.
2834 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2835 Restore PaX flags to their default. (Bug#11398)
2836
2837 2012-06-03 Chong Yidong <cyd@gnu.org>
2838
2839 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2840 buffer (Bug#11226).
2841
2842 2012-06-03 Chong Yidong <cyd@gnu.org>
2843
2844 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2845 (note_mode_line_or_margin_highlight): If there is no help echo,
2846 use mode-line-default-help-echo. Handle the case where the mouse
2847 position is past the end of the mode line string.
2848
2849 * buffer.c (buffer_local_value_1): New function, split from
2850 Fbuffer_local_value; can return Qunbound.
2851 (Fbuffer_local_value): Use it.
2852 (Vmode_line_format): Docstring tweaks.
2853
2854 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2855
2856 * sysdep.c (system_process_attributes): Improve comment.
2857
2858 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2859
2860 * keyboard.c: Export real-this-command to Elisp.
2861 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2862 and DEFVAR it. Update all users.
2863
2864 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2865
2866 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2867
2868 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2869 Convert pctcpu and pctmem to Lisp float properly.
2870 Let the compiler fold better, as 100.0/0x8000 is exact.
2871
2872 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2873
2874 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2875 cons_block.
2876
2877 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2880
2881 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2882
2883 For a 'struct window', replace some Lisp_Object fields to
2884 bitfields where appropriate, remove unused fields.
2885 * window.h (struct window): Remove unused 'last_mark_x' and
2886 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2887 change it's type from Lisp_Object to bitfield.
2888 Change type of 'force_start', 'optional_new_start',
2889 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2890 fields from Lisp_Object to bitfield. Adjust users accordingly.
2891
2892 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 Pacify gcc -Wdouble-precision when using Xaw.
2895 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2896 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2897 Use 'float' consistently, rather than 'float' in most places
2898 and 'double' in a couple of places.
2899
2900 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2901
2902 * xdisp.c (handle_stop): Detect whether we have overlay strings
2903 loaded by testing it->current.overlay_string_index to be
2904 non-negative, instead of checking whether n_overlay_strings is
2905 positive. (Bug#11587)
2906
2907 2012-05-31 Chong Yidong <cyd@gnu.org>
2908
2909 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2910
2911 * doc.c (Fsubstitute_command_keys): Doc fix.
2912
2913 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2914
2915 * search.c (search_buffer): Remove calls to
2916 r_alloc_inhibit_buffer_relocation, as it is now called by
2917 maybe_unify_char, which was the cause of relocation of buffer text
2918 in bug#11519.
2919
2920 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2921
2922 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2923 for the duration of call to load_charset, to avoid problems with
2924 callers of maybe_unify_char that access buffer text through C
2925 pointers.
2926
2927 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2928 decrement the inhibition flag, instead of just setting or
2929 resetting it.
2930
2931 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2932
2933 Remove obsolete '#define static' cruft.
2934 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2935 This #undef was "temporary" in 2000; it is no longer needed
2936 now that '#define static' has gone away.
2937 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2938 (gray_bitmap_bits): Remove; no longer needed.
2939 All uses replaced with definiens.
2940 * xterm.c: Include "bitmaps/gray.xbm".
2941
2942 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2943
2944 Clean up __executable_start, monstartup when --enable-profiling.
2945 The following changes affect the code only when profiling.
2946 * dispnew.c (__executable_start): Rename from safe_bcopy.
2947 Define only on platforms that need it.
2948 * emacs.c: Include <sys/gmon.h> when profiling.
2949 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2950 (__executable_start): Remove decl, since lisp.h does it now.
2951 (safe_bcopy): Remove decl; no longer has that name.
2952 (main): Coalesce #if into single bit of code, for simplicity.
2953 Cast pointers to uintptr_t, since standard libraries want integers
2954 and not pointers.
2955 * lisp.h (__executable_start): New decl.
2956
2957 2012-05-31 Glenn Morris <rgm@gnu.org>
2958
2959 * image.c (Fimagemagick_types): Doc fix.
2960
2961 2012-05-30 Jim Meyering <meyering@redhat.com>
2962
2963 * callproc.c (Fcall_process_region): Include directory component
2964 in mkstemp error message (Bug#11586).
2965
2966 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 * alloc.c, lisp.h (make_pure_vector): Now static.
2969
2970 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2971
2972 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2973 Move to byte-run.el.
2974 (Fautoload): Do the hash-doc more carefully.
2975 * data.c (Fdefalias): Purify definition, except for keymaps.
2976 (Qdefun): Move from eval.c.
2977 * lisp.h (Qdefun): Remove.
2978 * lread.c (read1): Tiny simplification.
2979
2980 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2981
2982 Do not create empty overlays with the evaporate property (Bug#9642).
2983 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2984 Bug#9642, but explicitly check that the buffer the overlay would
2985 be moved to is live and rearrange lines to make sure that errors
2986 will not put the overlay in an inconsistent state.
2987 (Fdelete_overlay): Cosmetics.
2988
2989 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2990
2991 * w32term.c (my_bring_window_to_top): New function.
2992 (x_raise_frame): Use handle returned by DeferWindowPos, which
2993 could be different from the original one.
2994 Call my_bring_window_to_top instead of my_set_foreground_window.
2995 (Bug#11513)
2996
2997 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2998 by calling BringWindowToTop.
2999
3000 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3001 (WM_EMACS_END): Increase by one.
3002
3003 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3004
3005 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3006 This avoids undefined behavior that might cause the eassert
3007 to not catch an out-of-range value.
3008
3009 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3010
3011 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3012 Update dependencies.
3013
3014 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3015
3016 * bidi.c (bidi_mirror_char): Fix last change.
3017
3018 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3019
3020 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3021 when referring to sectname field in printf format.
3022
3023 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3024
3025 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3026 Only r_alloc_inhibit_buffer_relocation needed to be added;
3027 the others were already declared.
3028
3029 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3030 before checking whether it's out of range. Put the check inside
3031 eassert. See
3032 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3033
3034 2012-05-27 Ken Brown <kbrown@cornell.edu>
3035
3036 * callproc.c (Fcall_process): Restore a line that was accidentally
3037 commented out in the 2011-02-13 change (bug#11547).
3038
3039 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3040
3041 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3042 defined on ralloc.c.
3043
3044 * buffer.c [REL_ALLOC]: Remove prototypes of
3045 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3046 they are now on lisp.h.
3047
3048 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3049
3050 * search.c (search_buffer): Use it to inhibit relocation of buffer
3051 text while re_search_2 is doing its job, because re_search_2 is
3052 passed C pointers to buffer text. (Bug#11519)
3053
3054 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3055 Update value to 24.
3056
3057 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3058 state after an additional call to move_it_in_display_line_to, keep
3059 the values of it->max_ascent and it->max_descent found for the
3060 entire line.
3061 (pos_visible_p): Revert the comparison against bottom_y to what it
3062 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3063 (Bug#11464)
3064
3065 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3066
3067 Fix coding-related core dumps with gcc -ftrapv.
3068 The code was computing A - B, where A and B are pointers, and B is
3069 random garbage. This can lead to core dumps on platforms that
3070 have special pointer registers, and it also leads to core dumps on
3071 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3072 A - B only when B is initialized properly.
3073 * coding.c (coding_set_source, coding_set_destination): Return void.
3074 (coding_change_source, coding_change_destinations): New functions,
3075 with the old behaviors of coding_set_source and coding_set_destination.
3076 All callers that need an offset changed to use these new functions.
3077
3078 2012-05-26 Glenn Morris <rgm@gnu.org>
3079
3080 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3081
3082 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3083
3084 Extend mouse support on W32 text-mode console.
3085 * xdisp.c (draw_row_with_mouse_face):
3086 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3087
3088 * w32console.c: Include window.h.
3089 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3090 New functions.
3091 (initialize_w32_display): Initialize mouse-highlight data.
3092
3093 * w32inevt.c: Include termchar.h and window.h.
3094 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3095 moves, call note_mouse_highlight. If help_echo changed, call
3096 gen_help_event to produce help-echo message in the echo area.
3097 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3098 highlight info.
3099
3100 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3101
3102 * lread.c (read1): Simplify slightly to avoid an overflow warning
3103 with GCC 4.7.0 on x86-64.
3104
3105 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3106
3107 * bidi.c (bidi_mirror_char): Revert last change: an int is
3108 definitely wide enough here.
3109
3110 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3111
3112 Fix integer width and related bugs (Bug#9874).
3113 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3114 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3115 (string_bytes, check_sblock, allocate_string_data):
3116 (compact_small_strings, Fmake_bool_vector, make_string)
3117 (make_unibyte_string, make_multibyte_string)
3118 (make_string_from_bytes, make_specified_string)
3119 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3120 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3121 (mark_vectorlike):
3122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3123 (allocate_pseudovector):
3124 Use int, not EMACS_INT, where int is wide enough.
3125 (inhibit_garbage_collection, Fgarbage_collect):
3126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3127 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3128 int might not be wide enough.
3129 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3130 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3131 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3132 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3133 (bidi_level_of_next_char, bidi_move_to_visually_next):
3134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3135 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3136 (Fkill_buffer, Fset_buffer_major_mode)
3137 (advance_to_char_boundary, Fbuffer_swap_text)
3138 (Fset_buffer_multibyte, overlays_at, overlays_in)
3139 (overlay_touches_p, struct sortvec, record_overlay_string)
3140 (overlay_strings, recenter_overlay_lists)
3141 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3142 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3143 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3144 (Foverlay_recenter, last_overlay_modification_hooks_used)
3145 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3146 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3147 (validate_region): Omit unnecessary test for b <= e,
3148 since that's guaranteed by the previous test.
3149 (adjust_overlays_for_delete): Avoid pos + length overflow.
3150 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3151 (report_overlay_modification):
3152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3153 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3154 Omit pointer cast, which isn't needed anyway, and doesn't work
3155 after the EMACS_INT -> ptrdiff_t change.
3156 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3157 * buffer.h: Adjust decls to match defn changes elsewhere.
3158 (struct buffer_text, struct buffer):
3159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3160 Use EMACS_INT, not int, where int might not be wide enough.
3161 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3162 not int, to avoid needless 32-bit limit on 64-bit hosts.
3163 (exec_byte_code): Use tighter memory-full test, one that checks
3164 for alloca overflow. Don't compute the address of the object just
3165 before an array, as that's not portable. Use EMACS_INT, not
3166 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3167 * callint.c (Fcall_interactively):
3168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3169 * callproc.c (call_process_kill, Fcall_process):
3170 Don't assume pid_t fits into an Emacs fixnum.
3171 (call_process_cleanup, Fcall_process, child_setup):
3172 Don't assume pid_t fits into int.
3173 (call_process_cleanup, Fcall_process, delete_temp_file)
3174 (Fcall_process_region):
3175 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3176 (Fcall_process): Simplify handling of volatile integers.
3177 Use int, not EMACS_INT, where int will do.
3178 * casefiddle.c (casify_object, casify_region, operate_on_word)
3179 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3181 (casify_object): Avoid integer overflow when overallocating buffer.
3182 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3183 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3184 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3185 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3186 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3187 integers are now checked earlier. All uses replaced with XINT.
3188 (ccl_driver):
3189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3190 For CCL_MapSingle, check that content and value are in int range.
3191 (ccl_driver, Fregister_code_conversion_map):
3192 Check that Vcode_version_map_vector is a vector.
3193 (resolve_symbol_ccl_program): Check that vector header is in range.
3194 Always copy the vector, so that we can check its contents reliably
3195 now rather than having to recheck each instruction as it's being
3196 executed. Check that vector words fit in 'int'.
3197 (ccl_get_compiled_code, Fregister_ccl_program)
3198 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3199 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3200 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3201 contents are in range.
3202 (Fccl_execute_on_string): Check that status is in range.
3203 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3204 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3205 Accept and return EMACS_INT, not int, because callers can pass values
3206 out of 'int' range.
3207 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3208 (multibyte_chars_in_text, parse_str_as_multibyte)
3209 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3210 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3211 (string_escape_byte8, Fget_byte):
3212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3213 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3214 avoid mishandling large integers.
3215 * character.h: Adjust decls to match defn changes elsewhere.
3216 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3217 (Ffind_charset_region):
3218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3219 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3220 (load_charset_map_from_vector, Fdefine_charset_internal):
3221 Don't assume fixnum fits in int.
3222 (load_charset_map_from_vector, Fmap_charset_chars):
3223 Remove now-unnecessary CHECK_NATNUMs.
3224 (Fdefine_charset_internal): Check ranges here, more carefully.
3225 Don't rely on undefined behavior with signed left shift overflow.
3226 Don't assume unsigned int fits into fixnum, or that fixnum fits
3227 into unsigned int. Don't require max_code to be a valid fixnum;
3228 that's not true for gb10830 4-byte on a 32-bit host. Allow
3229 invalid_code to be a cons, for the same reason. Require code_offset
3230 to be a character. Avoid int overflow if max_char is close
3231 to INT_MAX.
3232 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3233 this is intended anyway and avoids some undefined behavior.
3234 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3235 INDEX_TO_CODE_POINT, as that's what it expects.
3236 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3237 * charset.h (DECODE_CHAR): Return int, not unsigned;
3238 this is what was intended anyway, and it avoids undefined behavior.
3239 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3240 integer-overflow issues.
3241 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3242 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3243 where the argument is EMACS_INT, and this behavior is not intended.
3244 * chartab.c (Fmake_char_table, Fset_char_table_range)
3245 (uniprop_get_decoder, uniprop_get_encoder):
3246 Don't assume fixnum fits in int.
3247 * cmds.c (move_point): New function, that does the gist of
3248 Fforward_char and Fbackward_char, but does so while checking
3249 for integer overflow more accurately.
3250 (Fforward_char, Fbackward_char): Use it.
3251 (Fforward_line, Fend_of_line, internal_self_insert)
3252 (internal_self_insert):
3253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3254 Fix a FIXME, by checking for integer overflow when calculating
3255 target_clm and actual_clm.
3256 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3257 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3258 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3259 (coding_alloc_by_making_gap, alloc_destination)
3260 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3261 (encode_coding_utf_16, detect_coding_emacs_mule)
3262 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3263 (detect_coding_iso_2022, decode_coding_iso_2022)
3264 (encode_invocation_designation, encode_designation_at_bol)
3265 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3266 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3267 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3268 (encode_coding_ccl, encode_coding_raw_text)
3269 (detect_coding_charset, decode_coding_charset)
3270 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3271 (produce_composition, produce_charset, produce_annotation)
3272 (decode_coding, handle_composition_annotation)
3273 (handle_charset_annotation, consume_chars, decode_coding_gap)
3274 (decode_coding_object, encode_coding_object, detect_coding_system)
3275 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3276 (code_convert_region, code_convert_string)
3277 (Fdefine_coding_system_internal)
3278 (coding_set_source, coding_set_destination):
3279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3280 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3281 (Fdefine_coding_system_internal):
3282 Don't assume fixnums fit in int.
3283 (decode_coding_gap, decode_coding_object, encode_coding_object)
3284 (Fread_coding_system, Fdetect_coding_region)
3285 (Funencodable_char_position, Fcheck_coding_systems_region)
3286 (get_translation, handle_composition_annotation, consume_chars):
3287 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3288 (consume_chars): Rewrite to not calculate an address outside buffer.
3289 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3290 Don't access memory outside of the args array.
3291 (Fdefine_coding_system_internal): Check for charset-id overflow.
3292 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3293 result of ENCODE_CHAR.
3294 * coding.h: Adjust decls to match defn changes elsewhere.
3295 (struct coding_system):
3296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3297 * composite.c (get_composition_id, find_composition)
3298 (run_composition_function, update_compositions)
3299 (compose_text, composition_gstring_put_cache)
3300 (composition_gstring_p, composition_gstring_width)
3301 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3302 (composition_compute_stop_pos, composition_reseat_it)
3303 (composition_update_it, struct position_record)
3304 (find_automatic_composition, composition_adjust_point)
3305 (Fcomposition_get_gstring, Ffind_composition_internal):
3306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3307 (update_compositions):
3308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3309 * composite.h: Adjust decls to match defn changes elsewhere.
3310 (struct composition):
3311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3312 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3313 Do not attempt to compute the address of the object just before a
3314 buffer; this is not portable.
3315 (Faref, Faset):
3316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3317 (Faset): Use int, not EMACS_INT, where int is wide enough.
3318 (Fstring_to_number): Don't assume fixnums fit in int.
3319 (Frem): Don't assume arg is nonnegative.
3320 * dbusbind.c (xd_append_arg): Check for integers out of range.
3321 (Fdbus_call_method): Don't overflow the timeout int.
3322 (extract_signed, extract_unsigned): New functions.
3323 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3324 (xd_get_connection_references): Return ptrdiff_t, not int.
3325 All uses changed.
3326 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3327 (xd_read_message_1):
3328 Use int, not unsigned, where the dbus API uses int.
3329 (Fdbus_message_internal): Don't overflow mtype.
3330 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3331 * dired.c (directory_files_internal, file_name_completion, scmp)
3332 (file_name_completion_stat):
3333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3334 (file_name_completion): Don't overflow matchcount.
3335 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3336 * dispextern.h: Adjust decls to match defn changes elsewhere.
3337 (struct text_pos, struct glyph, struct bidi_saved_info)
3338 (struct bidi_string_data, struct bidi_it, struct composition_it)
3339 (struct it):
3340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3341 (struct display_pos, struct composition_it, struct it):
3342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3343 * dispnew.c (increment_matrix_positions)
3344 (increment_row_positions, mode_line_string)
3345 (marginal_area_string):
3346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3347 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3349 (duration_to_sec_usec): New function, to check for overflow better.
3350 (Fsleep_for, sit_for): Use it.
3351 * doc.c (get_doc_string, store_function_docstring):
3352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3353 (get_doc_string, Fsnarf_documentation):
3354 Use int, not EMACS_INT, where int is wide enough.
3355 (get_doc_string):
3356 Use SAFE_ALLOCA, not alloca.
3357 Check for overflow when converting EMACS_INT to off_t.
3358 * doprnt.c (doprnt):
3359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3360 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3361 Don't assume uid_t fits into fixnum.
3362 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3363 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3364 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3365 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3366 (general_insert_function)
3367 (Finsert_char, make_buffer_string, make_buffer_string_both)
3368 (update_buffer_properties, Fbuffer_substring)
3369 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3370 (Fsubst_char_in_region, check_translation)
3371 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3372 (transpose_markers, Ftranspose_regions):
3373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3374 (clip_to_bounds): Move to lisp.h as an inline function).
3375 (Fconstrain_to_field): Don't assume integers are nonnegative.
3376 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3377 (Fsubst_char_in_region, Fsave_restriction):
3378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3379 (Femacs_pid): Don't assume pid_t fits into fixnum.
3380 (lo_time): Use int, not EMACS_INT, when int suffices.
3381 (lisp_time_argument): Check for usec out of range.
3382 (Fencode_time): Don't assume fixnum fits in int.
3383 (Fuser_login_name, Fuser_full_name): Signal an error
3384 if a uid argument is out of range, rather than relying on
3385 undefined behavior.
3386 (Fformat_time_string): Remove now-unnecessary check.
3387 lisp_time_argument checks for out-of-range usec now.
3388 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3389 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3390 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3391 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3392 (init_cmdargs, Fdump_emacs):
3393 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3394 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3395 the bottom (typically) 32 bits of the fixnum.
3396 * eval.c (specpdl_size, call_debugger):
3397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3398 (when_entered_debugger, Fbacktrace_debug):
3399 Don't assume fixnum can fit in int.
3400 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3401 the object just before a buffer; this is not portable.
3402 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3403 (grow_specpdl, unbind_to):
3404 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3405 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3406 (grow_specpdl): Simplify allocation by using xpalloc.
3407 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3408 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3409 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3411 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3412 (a_write, e_write):
3413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3414 (Fcopy_file, non_regular_nbytes, read_non_regular)
3415 (Finsert_file_contents):
3416 Use int, not EMACS_INT, where int is wide enough.
3417 (READ_BUF_SIZE): Verify that it fits in int.
3418 (Finsert_file_contents): Check that counts are in proper range,
3419 rather than assuming fixnums fit into ptrdiff_t etc.
3420 Don't assume fixnums fit into int.
3421 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3422 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3423 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3424 (string_char_to_byte, string_byte_to_char)
3425 (string_make_multibyte, string_to_multibyte)
3426 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3427 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3428 (substring_both, Fdelete, internal_equal, Ffillarray)
3429 (Fclear_string, mapcar1)
3430 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3431 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3432 (larger_vector, make_hash_table, maybe_resize_hash_table)
3433 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3434 (Fmaphash, secure_hash):
3435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3436 (concat): Check for string index and length overflow.
3437 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3438 (Frequire):
3439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3440 (larger_vector): New API (vec, incr_min, size_max) replaces old
3441 one (vec, new_size, init). This catches size overflow.
3442 INIT was removed because it was always Qnil.
3443 All callers changed.
3444 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3445 the upper bound on a hash table index size.
3446 (make_hash_table, maybe_resize_hash_table): Use it.
3447 (secure_hash): Computer start_byte and end_byte only after
3448 they're known to be in ptrdiff_t range.
3449 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3450 (Ffont_get_glyphs, Ffont_at):
3451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3452 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3453 (Flist_fonts, Fopen_font):
3454 Don't assume fixnum can fit in int.
3455 (check_gstring): Don't assume index can fit in int.
3456 (font_match_p): Check that fixnum is a character, not a nonnegative
3457 fixnum, since the later code needs to stuff it into an int.
3458 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3459 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3460 conversion overflow issues.
3461 (Fopen_font): Check for integer out of range.
3462 (Ffont_get_glyphs): Don't assume index can fit in int.
3463 * font.h: Adjust decls to match defn changes elsewhere.
3464 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3465 integer overflow.
3466 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3467 printmax_t, where ptrdiff_t is wide enough.
3468 (Finternal_char_font):
3469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3470 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3471 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3472 (Fset_frame_position, x_set_frame_parameters)
3473 (x_set_line_spacing, x_set_border_width)
3474 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3475 Check that fixnums are in proper range for system types.
3476 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3478 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3479 Use SAFE_ALLOCA_LISP, not alloca.
3480 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3481 intptr_t is wide enough.
3482 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3483 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3484 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3485 Check for fixnum out of range.
3486 * ftfont.c (ftfont_list): Don't assume index fits in int.
3487 Check that fixnums are in proper range for system types.
3488 (ftfont_shape_by_flt):
3489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3490 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3492 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3493 Check that fixnums are in proper range for system types.
3494 * gnutls.h: Adjust decls to match defn changes elsewhere.
3495 * gtkutil.c (xg_dialog_run):
3496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3497 (update_frame_tool_bar):
3498 Check that fixnums are in proper range for system types.
3499 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3500 (lookup_image): Check that fixnums are in range for system types.
3501 * indent.c (last_known_column, last_known_column_point):
3502 (current_column_bol_cache):
3503 (skip_invisible, current_column, check_display_width):
3504 (check_display_width, scan_for_column, current_column_1)
3505 (Findent_to, Fcurrent_indentation, position_indentation)
3506 (indented_beyond_p, Fmove_to_column, compute_motion):
3507 (Fcompute_motion, Fvertical_motion):
3508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3509 (last_known_column_modified): Use EMACS_INT, not int.
3510 (check_display_width):
3511 (Fcompute_motion):
3512 Check that fixnums and floats are in proper range for system types.
3513 (compute_motion): Don't assume index or fixnum fits in int.
3514 (compute_motion, Fcompute_motion):
3515 Use int, not EMACS_INT, when it is wide enough.
3516 (vmotion): Omit local var start_hpos that is always 0; that way
3517 we don't need to worry about overflow in expressions involving it.
3518 * indent.h: Adjust decls to match defn changes elsewhere.
3519 (struct position):
3520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3521 Use int, not EMACS_INT, where int is wide enough.
3522 Remove unused members ovstring_chars_done and tab_offset;
3523 all uses removed.
3524 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3525 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3526 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3527 (make_gap, copy_text, insert, insert_and_inherit)
3528 (insert_before_markers, insert_before_markers_and_inherit)
3529 (insert_1, count_combining_before, count_combining_after)
3530 (insert_1_both, insert_from_string)
3531 (insert_from_string_before_markers, insert_from_string_1)
3532 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3533 (adjust_after_replace, adjust_after_insert, replace_range)
3534 (replace_range_2, del_range, del_range_1, del_range_byte)
3535 (del_range_both, del_range_2, modify_region)
3536 (prepare_to_modify_buffer, signal_before_change)
3537 (signal_after_change, Fcombine_after_change_execute):
3538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3539 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3540 (balance_an_interval, split_interval_right, split_interval_left)
3541 (find_interval, next_interval, update_interval)
3542 (adjust_intervals_for_insertion, delete_node, delete_interval)
3543 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3544 (static_offset_intervals, offset_intervals)
3545 (merge_interval_right, merge_interval_left, make_new_interval)
3546 (graft_intervals_into_buffer, temp_set_point_both)
3547 (temp_set_point, set_point, adjust_for_invis_intang)
3548 (set_point_both, move_if_not_intangible, get_property_and_range)
3549 (get_local_map, copy_intervals, copy_intervals_to_string)
3550 (compare_string_intervals, set_intervals_multibyte_1):
3551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3552 * intervals.h: Adjust decls to match defn changes elsewhere.
3553 (struct interval):
3554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3555 * keyboard.c (this_command_key_count, this_single_command_key_start)
3556 (before_command_key_count, before_command_echo_length, echo_now)
3557 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3558 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3559 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3560 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3562 (last_non_minibuf_size, last_point_position, echo_truncate)
3563 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3564 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3565 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3566 (stuff_buffered_input):
3567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3568 (last_auto_save, command_loop_1, read_char):
3569 Use EMACS_INT, not int, to avoid integer overflow.
3570 (record_char): Avoid overflow in total_keys computation.
3571 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3572 * keyboard.h: Adjust decls to match defn changes elsewhere.
3573 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3574 (Fkey_description, Fdescribe_vector, Flookup_key):
3575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3576 (click_position): New function, to check that positions are in range.
3577 (Fcurrent_active_maps):
3578 (describe_command):
3579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3580 (Faccessible_keymaps, Fkey_description):
3581 (preferred_sequence_p):
3582 Don't assume fixnum can fit into int.
3583 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3584 Check for integer overflow in size calculations.
3585 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3586 avoid mishandling large integers.
3587 * lisp.h: Adjust decls to match defn changes elsewhere.
3588 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3589 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3590 (struct Lisp_Marker):
3591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3592 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3593 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3594 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3595 All callers changed.
3596 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3597 Assume the arg has valid form, since it always does.
3598 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3599 unsigned integer system type.
3600 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3601 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3603 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3604 (duration_to_sec_usec): New decl.
3605 * lread.c (read_from_string_index, read_from_string_index_byte)
3606 (read_from_string_limit, readchar, unreadchar, openp)
3607 (read_internal_start, read1, oblookup):
3608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3609 (Fload, readevalloop, Feval_buffer, Feval_region):
3610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3611 (openp): Check for out-of-range argument to 'access'.
3612 (read1): Use int, not EMACS_INT, where int is wide enough.
3613 Don't assume fixnum fits into int.
3614 Fix off-by-one error that can read outside a buffer.
3615 (read_filtered_event): Use duration_to_sec_usec
3616 to do proper overflow checking on durations.
3617 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3618 in size calculation.
3619 (Fexecute_kbd_macro):
3620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3621 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3622 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3623 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3624 (set_marker_both, set_marker_restricted_both, marker_position)
3625 (marker_byte_position, Fbuffer_has_markers_at):
3626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3627 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3628 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3629 It now merely ensures that the menu is large enough, without
3630 necessarily growing it, as this avoids some integer overflow issues.
3631 All callers changed.
3632 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3634 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3635 Use SAFE_ALLOCA_LISP, not alloca.
3636 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3637 to EMACS_INT. Check that fixnums are in proper range for system types.
3638 * minibuf.c (minibuf_prompt_width, string_to_object)
3639 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3640 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3642 (get_minibuffer, read_minibuf_unwind):
3643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3644 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3645 this simplifies overflow checking. All callers changed.
3646 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3647 (Ftest_completion):
3648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3649 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3650 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3651 Check that fixnums are in proper range for system types.
3652 (Fx_create_frame, Fx_show_tip):
3653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3654 * nsfont.m (ns_findfonts, nsfont_list_family):
3655 Don't assume fixnum fits in long.
3656 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3658 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3659 wide enough.
3660 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3662 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3663 (PRINTDECLARE, PRINTPREPARE):
3664 (strout, print_string):
3665 (print, print_preprocess, print_check_string_charset_prop)
3666 (print_object):
3667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3668 (PRINTDECLARE):
3669 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3671 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3672 (printchar, strout): Use xpalloc to catch size calculation overflow.
3673 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3674 (print_error_message): Use SAFE_ALLOCA, not alloca.
3675 (print_object): Use int, not EMACS_INT, where int is wide enough.
3676 (print_depth, new_backquote_output, print_number_index):
3677 Use ptrdiff_t, not int, where int might not be wide enough.
3678 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3679 (Fset_process_window_size, Fformat_network_address)
3680 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3681 (sigchld_handler):
3682 Check that fixnums are in proper range for system types.
3683 (Fsignal_process): Simplify by avoiding a goto.
3684 Check for process-ids out of pid_t range rather than relying on
3685 undefined behavior.
3686 (process_tick, update_tick): Use EMACS_INT, not int.
3687 (Fformat_network_address, read_process_output, send_process)
3688 (Fprocess_send_region, status_notify):
3689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3690 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3691 (wait_reading_process_output, read_process_output, exec_sentinel):
3692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3693 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3694 (Faccept_process_output): Use duration_to_sec_usec to do proper
3695 overflow checking on durations.
3696 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3697 Don't assume pid_t fits in int.
3698 * process.h (struct Lisp_Process): Members tick and update_tick
3699 are now of type EMACS_INT, not int.
3700 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3701 configured --with-wide-int.
3702 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3703 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3704 * search.c (looking_at_1, string_match_1):
3705 (fast_string_match, fast_c_string_match_ignore_case)
3706 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3707 (scan_newline, find_before_next_newline, search_command)
3708 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3709 (set_search_regs, wordify):
3710 (Freplace_match):
3711 (Fmatch_data):
3712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3713 (string_match_1, search_buffer, set_search_regs):
3714 (Fmatch_data):
3715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3716 (wordify): Check for overflow in size calculation.
3717 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3718 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3719 Check that fixnums are in proper range for system types.
3720 * sound.c (struct sound_device)
3721 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3723 (Fplay_sound_internal):
3724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3725 * syntax.c (struct lisp_parse_state, find_start_modiff)
3726 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3727 (Fparse_partial_sexp):
3728 Don't assume fixnums can fit in int.
3729 (struct lisp_parse_state, find_start_pos, find_start_value)
3730 (find_start_value_byte, find_start_begv)
3731 (update_syntax_table, char_quoted, dec_bytepos)
3732 (find_defun_start, prev_char_comend_first, back_comment):
3733 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3734 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3736 (Finternal_describe_syntax_value): Check that match_lisp is a
3737 character, not an integer, since the code stuffs it into int.
3738 (scan_words, scan_sexps_forward):
3739 Check that fixnums are in proper range for system types.
3740 (Fforward_word):
3741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3742 (scan_sexps_forward):
3743 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3744 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3745 * syntax.h: Adjust decls to match defn changes elsewhere.
3746 (struct gl_state_s):
3747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3748 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3749 MOST_POSITIVE_FIXNUM.
3750 * sysdep.c (wait_for_termination_1, wait_for_termination)
3751 (interruptible_wait_for_termination, mkdir):
3752 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3753 (emacs_read, emacs_write):
3754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3755 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3756 and double all fit in int.
3757 * term.c (set_tty_color_mode):
3758 Check that fixnums are in proper range for system types.
3759 * termhooks.h (struct input_event):
3760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3761 * textprop.c (validate_interval_range, interval_of)
3762 (Fadd_text_properties, set_text_properties_1)
3763 (Fremove_text_properties, Fremove_list_of_text_properties)
3764 (Ftext_property_any, Ftext_property_not_all)
3765 (copy_text_properties, text_property_list, extend_property_ranges)
3766 (verify_interval_modification):
3767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3768 (Fnext_single_char_property_change)
3769 (Fprevious_single_char_property_change):
3770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3771 (copy_text_properties):
3772 Check for integer overflow in index calculation.
3773 * undo.c (last_boundary_position, record_point, record_insert)
3774 (record_delete, record_marker_adjustment, record_change)
3775 (record_property_change):
3776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3777 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3779 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3780 (Fx_hide_tip, Fx_file_dialog):
3781 * w32menu.c (set_frame_menubar):
3782 Use ptrdiff_t, not int, for consistency with rest of code.
3783 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3784 (select_window, Fdelete_other_windows_internal)
3785 (window_scroll_pixel_based, window_scroll_line_based)
3786 (Frecenter, Fset_window_configuration):
3787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3788 (Fset_window_hscroll, run_window_configuration_change_hook)
3789 (set_window_buffer, temp_output_buffer_show, scroll_command)
3790 (Fscroll_other_window, Frecenter):
3791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3792 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3793 Don't assume fixnum fits in int.
3794 (Fset_window_scroll_bars):
3795 Check that fixnums are in proper range for system types.
3796 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3797 (string_pos, c_string_pos, number_of_chars, init_iterator)
3798 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3799 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3800 (compute_display_string_end, handle_face_prop)
3801 (face_before_or_after_it_pos, handle_invisible_prop)
3802 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3803 (display_prop_intangible_p, string_buffer_position_lim)
3804 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3805 (get_overlay_strings_1, get_overlay_strings)
3806 (iterate_out_of_display_property, forward_to_next_line_start)
3807 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3808 (get_next_display_element, set_iterator_to_next)
3809 (get_visually_first_element, compute_stop_pos_backwards)
3810 (handle_stop_backwards, next_element_from_buffer)
3811 (move_it_in_display_line_to, move_it_in_display_line)
3812 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3813 (add_to_log, message_dolog, message_log_check_duplicate)
3814 (message2, message2_nolog, message3, message3_nolog
3815 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3816 (current_message_1, truncate_echo_area, truncate_message_1)
3817 (set_message, set_message_1, store_mode_line_noprop)
3818 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3819 (text_outside_line_unchanged_p, check_point_in_composition)
3820 (reconsider_clip_changes)
3821 (redisplay_internal, set_cursor_from_row, try_scrolling)
3822 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3823 (redisplay_window, find_last_unchanged_at_beg_row)
3824 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3825 (trailing_whitespace_p, find_row_edges, display_line)
3826 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3827 (display_mode_element, store_mode_line_string)
3828 (pint2str, pint2hrstr, decode_mode_spec)
3829 (display_count_lines, display_string, draw_glyphs)
3830 (x_produce_glyphs, x_insert_glyphs)
3831 (rows_from_pos_range, mouse_face_from_buffer_pos)
3832 (fast_find_string_pos, mouse_face_from_string_pos)
3833 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3835 (safe_call, init_from_display_pos, handle_fontified_prop)
3836 (handle_single_display_spec, load_overlay_strings)
3837 (with_echo_area_buffer, setup_echo_area_for_printing)
3838 (display_echo_area, echo_area_display)
3839 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3840 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3841 (redisplay_window, dump_glyph_row, display_mode_line)
3842 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3843 (handle_display_spec, display_prop_string_p):
3844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3845 (handle_single_display_spec, build_desired_tool_bar_string)
3846 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3847 (get_specified_cursor_type):
3848 Check that fixnums are in proper range for system types.
3849 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3850 (Flookup_image_map):
3851 Don't assume fixnums fit in int.
3852 (compare_overlay_entries):
3853 Avoid mishandling comparisons due to subtraction overflow.
3854 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3855 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3856 (handle_tool_bar_click):
3857 Use int, not unsigned, since we prefer signed and the signedness
3858 doesn't matter here.
3859 (get_next_display_element, next_element_from_display_vector):
3860 Use int, not EMACS_INT, when int is wide enough.
3861 (start_hourglass): Use duration_to_sec_usec to do proper
3862 overflow checking on durations.
3863 * xfaces.c (Fbitmap_spec_p):
3864 Check that fixnums are in proper range for system types.
3865 (compare_fonts_by_sort_order):
3866 Avoid mishandling comparisons due to subtraction overflow.
3867 (Fx_family_fonts, realize_basic_faces):
3868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3869 (Fx_family_fonts):
3870 Don't assume fixnum fits in int.
3871 Use SAFE_ALLOCA_LISP, not alloca.
3872 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3873 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3874 (face_at_buffer_position, face_for_overlay_string)
3875 (face_at_string_position):
3876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3877 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3878 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3879 (Fx_show_tip):
3880 Check that fixnums are in proper range for system types.
3881 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3882 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3884 (Fx_change_window_property): Don't assume fixnums fit in int.
3885 * xfont.c (xfont_chars_supported):
3886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3887 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3888 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3890 * xml.c (parse_region):
3891 * xrdb.c (magic_file_p):
3892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3893 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3894 (x_get_local_selection, x_reply_selection_request)
3895 (x_handle_selection_request, wait_for_property_change):
3896 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3897 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3898 short is wide enough.
3899 (x_send_client_event): Don't assume fixnum fits in int.
3900 * xterm.c (x_x_to_emacs_modifiers):
3901 Don't assume EMACS_INT overflows nicely into int.
3902 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3903 may come from Lisp.
3904 (handle_one_xevent): NATNUMP can eval its arg twice.
3905 (x_connection_closed):
3906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3907 * xterm.h: Adjust decls to match defn changes elsewhere.
3908 (struct scroll_bar): Use struct vectorlike_header
3909 rather than rolling our own approximation.
3910 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3911
3912 2012-05-25 Glenn Morris <rgm@gnu.org>
3913
3914 * lisp.mk (lisp): Update for more files being compiled now.
3915
3916 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3917
3918 * lread.c: Remove `read_pure' which makes no difference.
3919 (read_pure): Remove var.
3920 (unreadpure): Remove function.
3921 (readevalloop): Don't call read_list with -1 flag.
3922 (read1, read_vector): Don't test read_pure any more.
3923 (read_list): Simplify.
3924
3925 * fileio.c, character.h: Minor style tweaks.
3926
3927 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3928
3929 * window.h (clip_changed): Remove useless declaration.
3930
3931 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3932
3933 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3934 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3935
3936 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3937
3938 Remove src/m/*.
3939 This directory predates autoconf and is no longer needed nowadays.
3940 Move its few remaining bits of functionality to where they're needed.
3941 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3942 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3943 * m/template.h: Remove.
3944 * Makefile.in (M_FILE): Remove. All uses removed.
3945 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3946 * lisp.h (USE_LSB_TAG):
3947 * mem-limits.h (EXCEEDS_LISP_PTR):
3948 Use VAL_MAX, not VALBITS, in #if.
3949 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3950 (EMACS_UINT): Define unconditionally now.
3951 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3952 (BITS_PER_EMACS_INT): New constants, replacing
3953 what used to be in config.h, but not useful in #if.
3954 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3955 define them any more.
3956 (VAL_MAX): New macro.
3957 (VALMASK): Use it.
3958 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3959 BITS_PER_EMACS_INT, in #if.
3960 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3961 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3962 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3963 * s/ms-w32.h (DATA_START):
3964 Move here from removed file m/intel386.h.
3965 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3966 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3967
3968 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3969
3970 Assume C89 or later.
3971 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3972 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3973 (xrealloc):
3974 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3975 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3976 * textprop.c, tparam.c (NULL): Remove.
3977 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3978 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3979 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3980 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3981 * xterm.c (input_signal_count): Assume volatile works.
3982
3983 2012-05-21 Ken Brown <kbrown@cornell.edu>
3984
3985 * xgselect.c (xg_select): Fix first argument in call to 'select'
3986 (bug#11508).
3987
3988 2012-05-20 Ken Brown <kbrown@cornell.edu>
3989
3990 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3991 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3992
3993 2012-05-19 Ken Brown <kbrown@cornell.edu>
3994
3995 * xfns.c (x_in_use): Remove `static' qualifier.
3996 * xterm.h (x_in_use): Declare.
3997 * xgselect.c: Include xterm.h.
3998 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3999 and `display_arg' (bug#9754).
4000
4001 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4002
4003 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4004
4005 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4006 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4007
4008 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4009
4010 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4011
4012 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4013 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4014
4015 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4016 reference to image_cache->refcount.
4017 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4018
4019 2012-05-17 Juri Linkov <juri@jurta.org>
4020
4021 * search.c (Fword_search_regexp, Fword_search_backward)
4022 (Fword_search_forward, Fword_search_backward_lax)
4023 (Fword_search_forward_lax): Move functions to isearch.el
4024 (bug#10145, bug#11381).
4025
4026 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4027
4028 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4029
4030 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4031
4032 * lread.c (init_obarray): Declare Qt and Qnil as special.
4033
4034 2012-05-14 Glenn Morris <rgm@gnu.org>
4035
4036 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4037 Put "libexec" before "bin", for the sake of init_callproc_1.
4038
4039 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4040
4041 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4042
4043 * unexaix.c: Port to more-recent AIX compilers.
4044 (report_error, report_error_1, make_hdr, copy_sym)
4045 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4046 Make arguments const char *, not char *, to avoid violations of C
4047 standard and to fix some AIX warnings reported by Gilles Pion.
4048
4049 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4050
4051 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4052 already have overlays loaded.
4053 (handle_single_display_spec): Before returning without displaying
4054 fringe bitmap, synchronize the bidi iterator with the main display
4055 iterator, by calling iterate_out_of_display_property.
4056 (iterate_out_of_display_property): Detect buffer iteration by
4057 testing that it->string is a Lisp string.
4058 (get_next_display_element): When the current object is exhausted,
4059 and there's something on it->stack, call set_iterator_to_next to
4060 proceed with what's on the stack, instead of returning zero.
4061 (set_iterator_to_next): If called at the end of a Lisp string,
4062 proceed to consider_string_end without incrementing string
4063 position. Don't increment display vector index past the end of
4064 the display vector. (Bug#11417)
4065 (pos_visible_p): Don't report a position visible when move_it_to
4066 stopped at the last line of window, which happens to be scanned
4067 backwards by the bidi iteration. (Bug#11464)
4068
4069 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4070
4071 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4072 and right-margin display specs even if the spec is invalid or we
4073 are on a TTY, and thus unable to display on the fringes.
4074 That's because the text with the property will not be displayed anyway,
4075 so we need to signal to the caller that this is a "replacing"
4076 display spec. This fixes display when the spec is invalid or we
4077 are on a TTY.
4078
4079 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4080
4081 * unexaix.c (make_hdr): Fix typo in prototype.
4082 This bug broke the build on AIX. Problem reported by Gilles Pion.
4083
4084 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4085
4086 * keyboard.c (kbd_buffer_get_event): Read special events also in
4087 batch mode. (Bug#11415)
4088
4089 2012-05-12 Glenn Morris <rgm@gnu.org>
4090
4091 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4092
4093 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4094
4095 * lisp.mk (lisp): Add newcomment.elc.
4096
4097 2012-05-12 Glenn Morris <rgm@gnu.org>
4098
4099 * Makefile.in (MKDIR_P): New, set by configure.
4100 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4101
4102 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4103
4104 Remove unused function hourglass_started.
4105 * dispextern.h (hourglass_started):
4106 * w32fns.c (hourglass_started):
4107 * xdisp.c (hourglass_started): Remove.
4108
4109 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4110
4111 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4112 Update dependencies.
4113
4114 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4115
4116 * xgselect.c (xg_select): Put maxfds+1 into a var.
4117 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4118
4119 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4120
4121 2012-05-10 Dave Abrahams <dave@boostpro.com>
4122
4123 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4124 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4125
4126 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4127
4128 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4129 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4130 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4131 Initialize xd_registered_buses.
4132
4133 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 Untag more efficiently if USE_LSB_TAG.
4136 This is based on a proposal by YAMAMOTO Mitsuharu in
4137 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4138 For an admittedly artificial (nth 8000 longlist) benchmark on
4139 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4140 Emacs's overall text size by 1%.
4141 * lisp.h (XUNTAG): New macro.
4142 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4143 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4144 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4145 * eval.c (Fautoload):
4146 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4147 * frame.h (XFRAME): Use XUNTAG.
4148
4149 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4150 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4151 Remove unportable assumptions about print widths of types like
4152 dbus_uint32_t.
4153 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4154 intptr_t when converting between pointer and integer, to avoid GCC
4155 warnings about wrong width.
4156
4157 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4158
4159 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4160 stack for each reader_thread, instead of defaulting to 8MB
4161 determined by the linker. This avoids failures in creating
4162 subprocesses on Windows 7, see the discussion in this thread:
4163 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4164
4165 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4166
4167 Fix up display of the *Minibuf-0* buffer in the mini window.
4168 * keyboard.c (read_char): Don't clear the echo area if there's no
4169 message to clear.
4170 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4171 contents of *Minibuf-0*) if there's no message displayed in its stead.
4172
4173 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4174
4175 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4176 batch mode.
4177
4178 2012-05-06 Chong Yidong <cyd@gnu.org>
4179
4180 * lisp.mk (lisp): Update.
4181
4182 2012-05-05 Jim Meyering <meyering@redhat.com>
4183
4184 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4185
4186 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4187
4188 * data.c (PUT_ERROR): New macro.
4189 (syms_of_data): Use it. Add new error type `user-error'.
4190 * undo.c (user_error): New function.
4191 (Fprimitive_undo): Use it.
4192 * print.c (print_error_message): Adjust print style for `user-error'.
4193 * keyboard.c (user_error): New function.
4194 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4195
4196 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4197
4198 Do not limit current-time-string to years 1000..9999.
4199 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4200 (Fcurrent_time_string): Support any year that is supported by the
4201 underlying localtime representation. Don't use asctime, as it
4202 has undefined behavior for years outside the range -999..9999.
4203
4204 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4205
4206 Fix race conditions involving setenv, gmtime, localtime, asctime.
4207 Without this fix, interrupts could mess up code that uses these
4208 nonreentrant functions, since setting TZ invalidates existing
4209 tm_zone or tzname values, and since most of these functions return
4210 pointers to static storage.
4211 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4212 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4213 Grow the critical sections to include not just invoking
4214 localtime/gmtime, but also accessing these functions' results
4215 including their tm_zone values if any, and any related TZ setting.
4216 (format_time_string): Last arg is now struct tm *, not struct tm **,
4217 so that the struct tm is saved in the critical section.
4218 All callers changed. Simplify allocation of initial buffer, partly
4219 motivated by the fact that memory allocation needs to be outside
4220 the critical section.
4221
4222 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4223
4224 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4225 with RESET_INTERVAL.
4226
4227 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4228 Remove duplicated buffer name initialization.
4229
4230 2012-05-02 Jim Meyering <jim@meyering.net>
4231
4232 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4233
4234 * xfns.c (x_window): Use xstrdup (Bug#11375).
4235
4236 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4237
4238 * xdisp.c (pos_visible_p): If already at a newline from the
4239 display string before the 'while' loop, don't walk back the glyphs
4240 from it3.glyph_row. Solves assertion violation when the display
4241 string begins with a newline (egg.el). (Bug#11367)
4242
4243 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4244
4245 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4246 Move to simple.el.
4247
4248 2012-05-01 Glenn Morris <rgm@gnu.org>
4249
4250 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4251 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4252 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4253 All were removed before 23.1.
4254
4255 * dispnew.c: Remove HAVE_LIBNCURSES test;
4256 it is always true on relevant platforms.
4257
4258 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4259 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4260
4261 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4262
4263 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4264
4265 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4266 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4267 Remove.
4268
4269 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4270
4271 Do not avoid creating empty evaporating overlays (Bug#9642).
4272 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4273 That is, do not delete an evaporating overlay if it becomes
4274 empty after its bounds are adjusted to fit within its buffer.
4275 This fix caused other problems, and I'm reverting it until we get
4276 to the bottom of them.
4277
4278 2012-04-27 Chong Yidong <cyd@gnu.org>
4279
4280 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4281
4282 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4283
4284 * xdisp.c (pos_visible_p): If the window start position is beyond
4285 ZV, start the display from buffer beginning. Prevents assertion
4286 violation in init_iterator when the minibuffer window is scrolled
4287 via the scroll bar.
4288
4289 * window.c (window_scroll_pixel_based): Likewise.
4290
4291 2012-04-27 Chong Yidong <cyd@gnu.org>
4292
4293 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4294
4295 2012-04-27 Glenn Morris <rgm@gnu.org>
4296
4297 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4298 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4299
4300 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4301
4302 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4303 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4304
4305 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4306
4307 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4308 display element, check also the underlying string or buffer
4309 character. (Bug#11341)
4310
4311 * w32menu.c: Include w32heap.h.
4312 (add_menu_item): If the call to AppendMenuW (via
4313 unicode_append_menu) fails, disable Unicode menus only if we are
4314 running on Windows 9X/Me.
4315
4316 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4317
4318 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4319 (xgetint): Add missing shift for LSB tags.
4320
4321 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4322
4323 * keyboard.c (read_char): Don't wipe echo area for select window
4324 events: These might get delayed via `mouse-autoselect-window'
4325 (Bug#11304).
4326
4327 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4328
4329 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4330 manipulation of :loaded-from data.
4331
4332 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4333
4334 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4335 now a cons (bug#11311).
4336
4337 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4338
4339 Do not create empty overlays with the evaporate property (Bug#9642).
4340 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4341 if it becomes empty after its bounds are adjusted to fit within
4342 its buffer. Without this fix, in a nonempty buffer (let ((o
4343 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4344 yields an empty overlay that has the evaporate property, which is
4345 not supposed to happen.
4346
4347 Fix minor GTK3 problems found by static checking.
4348 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4349 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4350 (struct _EmacsFixedClass, emacs_fixed_get_type):
4351 Move decls here from emacsgtkfixed.h, since they needn't be public.
4352 (emacs_fixed_get_type): Now static.
4353 (emacs_fixed_class_init): Omit unused local.
4354 (emacs_fixed_child_type): Remove; unused.
4355 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4356 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4357 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4358 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4359 (EMACS_FIXED_GET_CLASS): Remove; unused.
4360 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4361
4362 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4363 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4364
4365 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4366
4367 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4368 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4369 (__malloc_size_t, __malloc_ptrdiff_t):
4370 Remove. All uses removed, replaced by the definiens if needed,
4371 since we can assume C89 or better now.
4372 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4373 (protect_malloc_state, align, get_contiguous_space)
4374 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4375 (malloc_atfork_handler_child, malloc_enable_thread)
4376 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4377 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4378 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4379 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4380 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4381 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4382 Define using prototypes, not old style.
4383 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4384 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4385 (align): Don't assume that signed integer overflow wraps around.
4386 Omit unused local var.
4387 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4388 (_free_internal_nolock, memalign, mallochook, reallochook):
4389 Omit no-longer-needed casts.
4390 (valloc): Use getpagesize, not __getpagesize.
4391 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4392 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4393
4394 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4395
4396 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4397
4398 Move functions from C to Lisp. Make non-blocking method calls
4399 the default. Implement further D-Bus standard interfaces.
4400
4401 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4402 (QCdbus_request_name_allow_replacement)
4403 (QCdbus_request_name_replace_existing)
4404 (QCdbus_request_name_do_not_queue)
4405 (QCdbus_request_name_reply_primary_owner)
4406 (QCdbus_request_name_reply_in_queue)
4407 (QCdbus_request_name_reply_exists)
4408 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4409 (QCdbus_registered_serial, QCdbus_registered_method)
4410 (QCdbus_registered_signal): New Lisp objects.
4411 (XD_DEBUG_MESSAGE): Use sizeof.
4412 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4413 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4414 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4415 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4416 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4417 (xd_signature, xd_append_arg): Allow float for integer types.
4418 (xd_get_connection_references): New function.
4419 (xd_get_connection_address): Rename from xd_initialize.
4420 Return cached address.
4421 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4422 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4423 level.
4424 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4425 Return number of refcounts.
4426 (Fdbus_get_unique_name): Make stronger parameter check.
4427 (Fdbus_message_internal): New defun.
4428 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4429 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4430 (Fdbus_send_signal, Fdbus_register_service)
4431 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4432 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4433 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4434 (Vdbus_compiled_version, Vdbus_runtime_version)
4435 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4436 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4437 (Vdbus_message_type_signal): New defvars.
4438 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4439 Adapt docstring.
4440
4441 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4442
4443 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4444 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4445 Do not assume ptrdiff_t is the same width as 'int'.
4446
4447 * alloc.c: Handle unusual debugging option combinations.
4448 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4449 since the two debugging options are incompatible.
4450 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4451 is defined.
4452 (mem_init, mem_insert, mem_insert_fixup):
4453 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4454 (NEED_MEM_INSERT): Remove; no longer needed.
4455
4456 2012-04-22 Leo Liu <sdl.web@gmail.com>
4457
4458 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4459
4460 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4461
4462 * sysdep.c [__FreeBSD__]: Minor cleanups.
4463 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4464 Use Emacs indenting style more consistently. Avoid some casts.
4465 Use 'double' consistently rather than mixing 'float' and 'double'.
4466
4467 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4468
4469 * sysdep.c (list_system_processes, system_process_attributes):
4470 Add implementation for FreeBSD (Bug#5243).
4471
4472 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4473
4474 * lisp.mk (lisp): Update.
4475
4476 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4477
4478 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4479 It is never used otherwise.
4480
4481 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4482
4483 * print.c (print_preprocess): Only check print_depth if print-circle
4484 is nil.
4485 (print_object): Check for cycles even when print-circle is nil and
4486 print-gensym is t, but only check print_depth if print-circle is nil.
4487
4488 2012-04-20 Chong Yidong <cyd@gnu.org>
4489
4490 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4491 set the status to "failed" and ensure that sentinel is run.
4492
4493 2012-04-20 Glenn Morris <rgm@gnu.org>
4494
4495 * process.c (Fset_process_inherit_coding_system_flag)
4496 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4497 (Fmake_network_process, Fmake_serial_process): Doc fix.
4498
4499 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4500
4501 * xdisp.c (string_buffer_position_lim): Limit starting position to
4502 BEGV.
4503 (set_cursor_from_row): If called for a mode-line or header-line
4504 row, return zero immediately.
4505 (try_cursor_movement): If inside continuation line, don't back up
4506 farther than the first row after the header line, if any.
4507 Don't consider the header-line row as "partially visible", even if
4508 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4509
4510 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4511
4512 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4513 (bug#11238).
4514
4515 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4516 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4517
4518 configure: new option --enable-gcc-warnings (Bug#11207)
4519 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4520 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4521 (ALL_CFLAGS): Use new macros rather than old.
4522 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4523 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4524 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4525 -Wunused-result, -Wunused-variable. This should go away once
4526 the Emacs and Gnulib regex code is merged.
4527 (xmalloc, xrealloc): Now static.
4528
4529 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4530
4531 * dired.c (Fsystem_groups): Remove unused local.
4532
4533 2012-04-17 Glenn Morris <rgm@gnu.org>
4534
4535 * dired.c (Fsystem_users): Doc fix.
4536
4537 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4538
4539 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4540 (syms_of_dired): Add them.
4541
4542 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4543
4544 Fix minor alloc.c problems found by static checking.
4545 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4546 New extern decls, to avoid calling undeclared functions.
4547 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4548 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4549 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4550 (NEED_MEM_INSERT): New macro.
4551 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4552 Remove one incorrect comment and fix another.
4553
4554 Fix minor ralloc.c problems found by static checking.
4555 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4556 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4557 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4558 (r_alloc_sbrk): Now static.
4559
4560 Improve ralloc.c interface checking.
4561 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4562 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4563 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4564 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4565 [REL_ALLOC]: ... to here, to check interface.
4566 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4567 Remove decls. This fixes an "It stinks!".
4568
4569 * alloc.c (which_symbols): Fix alignment issue / type clash.
4570
4571 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4572
4573 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4574 (struct Lisp_Misc_Any): Likewise.
4575 (struct Lisp_Free): Likewise.
4576 * alloc.c (union aligned_Lisp_Symbol): Define.
4577 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4578 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4579 (union aligned_Lisp_Misc): Define.
4580 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4581 aligned_Lisp_Misc instead of union Lisp_Misc.
4582 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4583
4584 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4585
4586 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4587 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4588 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4589 * s/netbsd.h, s/sol2-6.h:
4590 Remove definition of GC_MARK_STACK, since the default now works.
4591 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4592 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4593 no longer the default.
4594 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4595
4596 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4597
4598 * lread.c (lisp_file_lexically_bound_p):
4599 Fix hang at ";-*-\n" (bug#11238).
4600
4601 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4602
4603 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4604 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4605
4606 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4607
4608 * nsterm.m (constrainFrameRect): Always constrain when there is only
4609 one screen (Bug#10962).
4610
4611 2012-04-13 Ken Brown <kbrown@cornell.edu>
4612
4613 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4614
4615 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4616
4617 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4618
4619 2012-04-11 Daniel Colascione <dancol@dancol.org>
4620
4621 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4622 against is gone. It's better to use vfork now so that when Cygwin
4623 gains a new, working vfork, we use it automatically (bug#10398).
4624
4625 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4626
4627 * window.c (save_window_save): Obey window-point-insertion-type.
4628
4629 2012-04-11 Glenn Morris <rgm@gnu.org>
4630
4631 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4632
4633 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4634
4635 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4636
4637 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4638
4639 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4640 (force_quit_count): New var.
4641 (handle_interrupt): Use it.
4642
4643 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4644
4645 * w32.c (w32_delayed_load): Record the full path of the library
4646 being loaded (bug#10424).
4647
4648 2012-04-09 Glenn Morris <rgm@gnu.org>
4649
4650 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4651 not just in the obarray, before snarfing them. (Bug#11036)
4652
4653 * Makefile.in ($(leimdir)/leim-list.el):
4654 Pass EMACS rather than BUILT_EMACS.
4655
4656 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4657
4658 * process.c (make_process):
4659 * process.h: Add integer `gnutls_handshakes_tried' member to
4660 process struct.
4661
4662 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4663 Add convenience `GNUTLS_LOG2i' macro.
4664
4665 * gnutls.c (gnutls_log_function2i): Convenience log function.
4666 (emacs_gnutls_read): Use new log functions,
4667 `gnutls_handshakes_tried' process member, and
4668 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4669 attempts per process (connection).
4670
4671 2012-04-09 Chong Yidong <cyd@gnu.org>
4672
4673 * eval.c (Fuser_variable_p, user_variable_p_eh)
4674 (lisp_indirect_variable): Functions deleted.
4675 (Fdefvar): Caller changed.
4676
4677 * callint.c (Finteractive, Fcall_interactively):
4678 * minibuf.c (Fread_variable): Callers changed.
4679
4680 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4681
4682 * xdisp.c (set_cursor_from_row): If the display string appears in
4683 the buffer at position that is closer to point than the position
4684 after the display string, display the cursor on the first glyph of
4685 the display string. Fixes cursor display when a 'display' text
4686 property immediately follows invisible text. (Bug#11094)
4687
4688 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4689
4690 composite.c: use 'double' consistently
4691 * composite.c (get_composition_id): Use 'double' consistently
4692 instead of converting 'float' to 'double' and vice versa; this is
4693 easier to understand and avoids a GCC warning.
4694
4695 2012-04-09 Glenn Morris <rgm@gnu.org>
4696
4697 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4698 preparation for dumping it with emacs. (Bug#4789)
4699 (leimdir): New variable.
4700 ($(leimdir)/leim-list.el): New rule.
4701 (emacs$(EXEEXT)): Depend on leim-list.el.
4702
4703 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4704 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4705 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4706
4707 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4708
4709 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4710 proper alignment.
4711
4712 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4713
4714 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4715 Remove unused local variable.
4716
4717 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4718
4719 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4720 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4721 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4722 objects, as mark_maybe_pointer will catch them otherwise.
4723 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4724 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4725
4726 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4727
4728 Fix typo that broke non-Windows builds.
4729 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4730
4731 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4732
4733 Support building on MS-Windows with libxml2.
4734
4735 * makefile.w32-in (OBJ2): Add xml.$(O).
4736 (GLOBAL_SOURCES): Add xml.c.
4737 ($(BLD)/xml.$(O)): New dependency list.
4738
4739 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4740 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4741 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4742 [!WINDOWSNT]: New macros.
4743 (init_libxml2_functions, libxml2_loaded_p): New functions.
4744 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4745 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4746 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4747 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4748 linked in).
4749 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4750 Call init_libxml2_functions before calling libxml2 functions.
4751 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4752
4753 * emacs.c: Don't include libxml/parser.h.
4754 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4755 xmlCleanupParser directly.
4756
4757 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4758
4759 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4760
4761 * indent.c (Fvertical_motion): If there is a display string at
4762 point, use it.vpos to compute how many lines to backtrack after
4763 move_it_to point. (Bug#11133)
4764
4765 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4766
4767 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4768 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4769 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4770 macros related to unification of CJK characters. For the details,
4771 see the discussion following the message here:
4772 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4773
4774 2012-04-04 Chong Yidong <cyd@gnu.org>
4775
4776 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4777
4778 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4779
4780 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4781 instead of alloca. (Bug#11138)
4782
4783 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4784
4785 * w32menu.c (is_simple_dialog): Properly check lisp types.
4786 (Bug#11141)
4787
4788 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4789
4790 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4791 position we get to after a call to move_it_to fails the
4792 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4793 only if we wind up in a string from display property. (Bug#11063)
4794
4795 * window.c (Fdelete_other_windows_internal): Invalidate the row
4796 and column information about mouse highlight, so that redisplay
4797 restores it after reallocating the glyph matrices. (Bug#7464)
4798
4799 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4800 string comes from a `display' text property, use the buffer
4801 position of that property as if we actually saw that position in
4802 the row's glyphs.
4803 (move_it_by_lines): Remove the assertion that
4804 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4805 violated when there's a before-string at the beginning of a line.
4806 (Bug#11063)
4807
4808 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4809
4810 * xdisp.c (append_space_for_newline): If the default face was
4811 remapped, use the remapped face for the appended newline.
4812 (extend_face_to_end_of_line): Use the remapped default face for
4813 extending the face to the end of the line.
4814 (display_line): Call extend_face_to_end_of_line when the default
4815 face was remapped. (Bug#11068)
4816
4817 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4818
4819 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4820
4821 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4822
4823 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4824
4825 2012-03-27 Glenn Morris <rgm@gnu.org>
4826
4827 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4828 Doc fixes.
4829
4830 2012-03-26 Kenichi Handa <handa@m17n.org>
4831
4832 * dispextern.h (struct glyph): Fix previous change. Change the
4833 bit length of glyphless.ch to 25 (Bug#11082).
4834
4835 2012-03-26 Chong Yidong <cyd@gnu.org>
4836
4837 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4838 (command_loop_1): Use it; inhibit selection update for
4839 handle-select-window too (Bug#8996).
4840
4841 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4842
4843 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4844
4845 2012-03-25 Kenichi Handa <handa@m17n.org>
4846
4847 * dispextern.h (struct glyph): Change the bit length of
4848 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4849
4850 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4851
4852 * s/ms-w32.h (tzname): Include time.h before redirecting to
4853 _tzname. Fixes the MSVC build. (Bug#9960)
4854
4855 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4856
4857 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4858 characters.
4859
4860 * xterm.c (XTread_socket): Only modify handling_signal if
4861 !SYNC_INPUT. (Bug#11080)
4862
4863 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4864
4865 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4866 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4867 when fetching a multibyte character consumes more bytes than
4868 CHAR_BYTES returns, due to unification of CJK characters in
4869 string_char. (Bug#11073)
4870
4871 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4872
4873 * process.c (wait_reading_process_output): Handle pty disconnect
4874 by refraining from sending oneself a SIGCHLD (bug#10933).
4875
4876 2012-03-22 Chong Yidong <cyd@gnu.org>
4877
4878 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4879
4880 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4881 Mark string as coming from a prefix property.
4882 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4883 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4884
4885 2012-03-21 Chong Yidong <cyd@gnu.org>
4886
4887 * xfaces.c (Vface_remapping_alist): Doc fix.
4888
4889 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4890
4891 * w32proc.c (Fw32_set_console_codepage)
4892 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4893 Doc fixes.
4894
4895 2012-03-20 Chong Yidong <cyd@gnu.org>
4896
4897 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4898 to reflect default non-nil value of redisplay-dont-pause.
4899
4900 2012-03-19 Kenichi Handa <handa@m17n.org>
4901
4902 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4903 it fit in a valid range (Bug#11003).
4904
4905 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4906
4907 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4908 that is not from display property, accept the row as a "cursor
4909 row" if one of the string's character has a non-nil `cursor'
4910 property. Fixes cursor positioning when there are newlines in
4911 overlay strings, e.g. in icomplete.el. (Bug#11035)
4912
4913 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4914
4915 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4916
4917 2012-03-12 Chong Yidong <cyd@gnu.org>
4918
4919 * eval.c (inhibit_lisp_code): Rename from
4920 inhibit_window_configuration_change_hook; move from window.c.
4921
4922 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4923 * window.c (run_window_configuration_change_hook)
4924 (syms_of_window): Callers changed.
4925
4926 2012-03-11 Chong Yidong <cyd@gnu.org>
4927
4928 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4929
4930 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4931
4932 2012-03-10 Chong Yidong <cyd@gnu.org>
4933
4934 * frame.c (other_visible_frames): Don't assume the selected frame
4935 is visible (Bug#10955).
4936
4937 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4938
4939 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4940
4941 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4942
4943 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4944 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4945 zero (Bug#10954).
4946
4947 2012-03-03 Glenn Morris <rgm@gnu.org>
4948
4949 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4950
4951 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4952
4953 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4954 position past the first glyph_row that ends at ZV. (Bug#10902)
4955 (redisplay_window, next_element_from_string): Fix typos in
4956 comments.
4957 (redisplay_window): Pass to move_it_vertically the margin in
4958 pixels, not in screen lines.
4959
4960 2012-03-02 Glenn Morris <rgm@gnu.org>
4961
4962 * buffer.c (buffer-list-update-hook): Doc fix.
4963
4964 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4965
4966 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4967 push_it before setting up the iterator for the first overlay
4968 string, even if we have an empty string loaded.
4969 (next_overlay_string): If there's an empty string on the iterator
4970 stack, pop the stack. (Bug#10903)
4971
4972 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4973
4974 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4975 Suggested by Stefan Monnier in
4976 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4977 * alloc.c (widen_to_Lisp_Object): New static function.
4978 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4979 and widening them to Lisp_Objects. This would work even if
4980 USE_LSB_TAG is defined and wide integers are used, which might
4981 happen in a future version of Emacs.
4982
4983 2012-02-25 Chong Yidong <cyd@gnu.org>
4984
4985 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4986 Doc fix.
4987
4988 * xselect.c (Fx_selection_exists_p): Doc fix.
4989 (x_clipboard_manager_save_all): Print an informative message
4990 before saving to clipboard manager.
4991
4992 2012-02-24 Chong Yidong <cyd@gnu.org>
4993
4994 * keyboard.c (process_special_events): Handle all X selection
4995 requests in kbd_buffer, not just the next one (Bug#8869).
4996
4997 2012-02-23 Chong Yidong <cyd@gnu.org>
4998
4999 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5000 call when setting menu-bar-lines and tool-bar-lines parameters.
5001 (unwind_create_frame_1): New helper function.
5002
5003 * window.c (inhibit_window_configuration_change_hook): New var.
5004 (run_window_configuration_change_hook): Obey it.
5005 (syms_of_window): Initialize it.
5006
5007 2012-02-22 Chong Yidong <cyd@gnu.org>
5008
5009 * xterm.c (x_draw_image_relief): Add missing type check for
5010 Vtool_bar_button_margin (Bug#10743).
5011
5012 2012-02-21 Chong Yidong <cyd@gnu.org>
5013
5014 * fileio.c (Vfile_name_handler_alist): Doc fix.
5015
5016 * buffer.c (Fget_file_buffer): Protect against invalid file
5017 handler return value.
5018
5019 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5020
5021 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5022 when computing $valmask.
5023
5024 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5025 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5026 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5027 It's useless in that case, and it can cause problems on hosts
5028 that allocate halves of EMACS_INT values separately.
5029 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5030 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5031 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5032 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5033 it avoids undefined behavior on hosts where shifting right by more
5034 than the word width has undefined behavior.
5035
5036 2012-02-19 Chong Yidong <cyd@gnu.org>
5037
5038 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5039 (Funhandled_file_name_directory, Ffile_name_as_directory)
5040 (Fdirectory_file_name, Fexpand_file_name)
5041 (Fsubstitute_in_file_name): Protect against invalid file handler
5042 return values (Bug#10845).
5043
5044 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5045
5046 * .gdbinit (pitx): Fix incorrect references to fields of the
5047 iterator stack.
5048
5049 2012-02-17 Chong Yidong <cyd@gnu.org>
5050
5051 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5052
5053 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5054
5055 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5056 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5057
5058 2012-02-15 Chong Yidong <cyd@gnu.org>
5059
5060 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5061 marked as special. Also, starting docstrings with * is obsolete.
5062
5063 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5064
5065 * gnutls.c (emacs_gnutls_write): Fix last change.
5066
5067 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5068
5069 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5070 send_process.
5071
5072 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5073
5074 * keymap.c (Fsingle_key_description): Handle char ranges.
5075
5076 2012-02-12 Chong Yidong <cyd@gnu.org>
5077
5078 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5079 as that creates a dangerous corner case.
5080
5081 * window.c (Fdelete_window_internal): Invalidate the mouse
5082 highlight (Bug#9904).
5083
5084 2012-02-12 Glenn Morris <rgm@gnu.org>
5085
5086 * xselect.c (Fx_own_selection_internal)
5087 (Fx_get_selection_internal, Fx_disown_selection_internal)
5088 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5089 * nsselect.m (Fx_own_selection_internal)
5090 (Fx_disown_selection_internal, Fx_selection_exists_p)
5091 (Fx_selection_owner_p, Fx_get_selection_internal):
5092 Sync docs and argument specs with the xselect.c versions.
5093
5094 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5095
5096 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5097
5098 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5099
5100 * w32select.c (Fx_selection_exists_p): Sync doc string and
5101 argument list with xselect.c. (Bug#10783)
5102
5103 * w16select.c (Fx_selection_exists_p): Sync doc string and
5104 argument list with xselect.c. (Bug#10783)
5105
5106 2012-02-10 Glenn Morris <rgm@gnu.org>
5107
5108 * fns.c (Fsecure_hash): Doc fix.
5109
5110 2012-02-09 Kenichi Handa <handa@m17n.org>
5111
5112 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5113
5114 2012-02-07 Chong Yidong <cyd@gnu.org>
5115
5116 * buffer.c (Fbuffer_local_variables)
5117 (buffer_lisp_local_variables): Handle unbound vars correctly;
5118 don't let Qunbound leak into Lisp.
5119
5120 2012-02-07 Glenn Morris <rgm@gnu.org>
5121
5122 * image.c (Fimagemagick_types): Doc fix.
5123
5124 * image.c (imagemagick-render-type): Change it from a lisp object
5125 to an integer. Move the doc here from the lisp manual.
5126 Treat all values not equal to 0 the same.
5127
5128 2012-02-06 Chong Yidong <cyd@gnu.org>
5129
5130 * doc.c (store_function_docstring): Avoid applying docstring of
5131 alias to base function (Bug#2603).
5132
5133 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5134
5135 * .gdbinit (pp1, pv1): Remove redundant defines.
5136 (pr): Use pp.
5137
5138 2012-02-04 Chong Yidong <cyd@gnu.org>
5139
5140 * nsterm.m: Declare a global (Bug#10694).
5141
5142 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5143
5144 * w32.c (get_emacs_configuration_options):
5145 Include --enable-checking, if specified, in the return value.
5146
5147 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5148
5149 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5150 after rounding frame sizes. (Bug#9723)
5151
5152 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5153
5154 * keyboard.c (adjust_point_for_property): Don't position point
5155 before BEGV. (Bug#10696)
5156
5157 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5158
5159 Handle overflow when computing char display width (Bug#9496).
5160 * character.c (char_width): Return EMACS_INT, not int.
5161 (char_width, c_string_width): Check for overflow when
5162 computing the width; this is possible now that individual
5163 characters can have unbounded width. Problem introduced
5164 by merge from Emacs 23 on 2012-01-19.
5165
5166 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5167
5168 * dbusbind.c (Fdbus_register_method): Mention the return value
5169 :ignore in the docstring.
5170
5171 2012-02-02 Glenn Morris <rgm@gnu.org>
5172
5173 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5174
5175 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5176 Unconditionally set to t. (Bug#10673)
5177 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5178 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5179 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5180
5181 2012-02-02 Kenichi Handa <handa@m17n.org>
5182
5183 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5184 0, do not call append_composite_glyph.
5185
5186 2012-02-02 Kenichi Handa <handa@m17n.org>
5187
5188 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5189 NULL (Bug#6988).
5190 (x_produce_glyphs): If the component of a composition is a null
5191 string, set it->pixel_width to 1 to avoid zero-width glyph.
5192
5193 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5194
5195 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5196 first 2 arguments are identical. This makes inserting large
5197 output from a subprocess an order of magnitude faster on
5198 MS-Windows, where all sbrk'ed memory is always contiguous.
5199
5200 2012-01-31 Glenn Morris <rgm@gnu.org>
5201
5202 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5203 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5204 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5205
5206 2012-01-29 Glenn Morris <rgm@gnu.org>
5207
5208 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5209
5210 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5211
5212 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5213
5214 2012-01-28 Chong Yidong <cyd@gnu.org>
5215
5216 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5217
5218 2012-01-26 Chong Yidong <cyd@gnu.org>
5219
5220 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5221
5222 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5223 repeat counts (Bug#10507).
5224
5225 2012-01-26 Glenn Morris <rgm@gnu.org>
5226
5227 * lread.c (syms_of_lread): Doc fix.
5228
5229 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5230
5231 * coding.c (encode_designation_at_bol): Change return value to
5232 EMACS_INT.
5233
5234 2012-01-25 Chong Yidong <cyd@gnu.org>
5235
5236 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5237
5238 2012-01-21 Chong Yidong <cyd@gnu.org>
5239
5240 * floatfns.c (Fcopysign): Make the second argument non-optional,
5241 since nil is not allowed anyway.
5242
5243 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5244
5245 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5246 (send_process): Likewise.
5247
5248 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5249
5250 * window.c (save_window_save, Fcurrent_window_configuration)
5251 (Vwindow_persistent_parameters): Do not use Qstate.
5252 Rewrite doc-strings.
5253
5254 2012-01-19 Kenichi Handa <handa@m17n.org>
5255
5256 * character.c (char_width): New function.
5257 (Fchar_width, c_string_width, lisp_string_width):
5258 Use char_width (Bug#9496).
5259
5260 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5261
5262 * window.c (Vwindow_persistent_parameters): New variable.
5263 (Fset_window_configuration, save_window_save): Handle persistent
5264 window parameters.
5265
5266 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5267
5268 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5269 thrashing the stack of the thread. (Bug#9087)
5270
5271 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5272
5273 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5274
5275 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5276
5277 * xdisp.c (rows_from_pos_range): Handle the case where the
5278 highlight ends on a newline. (Bug#10464)
5279 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5280 he end column for display of highlight that ends on a newline
5281 before a R2L line.
5282
5283 2012-01-11 Glenn Morris <rgm@gnu.org>
5284
5285 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5286 from load-path also when installation-directory is nil. (Bug#10208)
5287
5288 2012-01-10 Glenn Morris <rgm@gnu.org>
5289
5290 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5291
5292 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5293 Update template values to be closer to their typical values these days.
5294
5295 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5296
5297 * xdisp.c (rows_from_pos_range): Accept additional argument
5298 DISP_STRING, and accept any glyph in a row whose object is that
5299 string as eligible for mouse highlight. Fixes mouse highlight of
5300 display strings from overlays. (Bug#10464)
5301
5302 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5303
5304 emacs: fix an auto-save permissions race condition (Bug#10400)
5305 * fileio.c (auto_saving_dir_umask): New static var.
5306 (Fmake_directory_internal): Use it.
5307 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5308 creating the directory. The old code temporarily assigns
5309 too-generous permissions to the directory.
5310 (do_auto_save_eh): Clear it.
5311 (Fdo_auto_save): Catch all errors, not just file errors, so
5312 that the var is always cleared.
5313
5314 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5315
5316 * search.c (scan_buffer): Pass character positions to
5317 know_region_cache, not byte positions. (Bug#6540)
5318
5319 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5320
5321 * w32.c (sys_rename): Report EXDEV when rename of a directory
5322 fails because the target is on another logical disk. (Bug#10284)
5323
5324 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5325
5326 * xterm.c (x_embed_request_focus): New function.
5327
5328 * xterm.h: Add prototype.
5329
5330 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5331
5332 2012-01-05 Glenn Morris <rgm@gnu.org>
5333
5334 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5335
5336 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5337
5338 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5339 Load gnutls_transport_set_lowat only if GnuTLS version is below
5340 2.11.1.
5341 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5342 GnuTLS versions below 2.11.1.
5343
5344 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5345
5346 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5347 to the doc string advising against its use for altering the way
5348 windows are scrolled.
5349
5350 2011-12-28 Kenichi Handa <handa@m17n.org>
5351
5352 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5353 coding-system ASCII compatible only when it does not produce BOM
5354 on encoding (Bug#10383).
5355
5356 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5357
5358 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5359 can scroll.
5360 (create_and_show_popup_menu): Always use menu_position_func for
5361 Gtk3 (Bug#10361).
5362
5363 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5364
5365 * callint.c (Fcall_interactively): Don't truncate prompt string.
5366
5367 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5368
5369 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5370 property that ends at ZV, so that the bidi iteration could be
5371 resumed from there (after widening). (Bug#10360)
5372
5373 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5374
5375 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5376
5377 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5378
5379 * nsterm.m (x_free_frame_resources):
5380 Release f->output_data.ns->miniimage.
5381 (ns_index_color): Fix indentation. Do not retain
5382 color_table->colors[i].
5383
5384 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5385 before returning.
5386
5387 * nsfns.m (x_set_background_color): Assign return value from
5388 ns_index_color to face-background instead of NSColor*.
5389 (ns_implicitly_set_icon_type): Fix indentation.
5390 Change assignment in for loop to comparison.
5391
5392 * emacs.c (ns_pool): New variable.
5393 (main): Assign ns_pool.
5394 (Fkill_emacs): Call ns_release_autorelease_pool.
5395
5396 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5397 autorelease fdesc, release fdAttrs and tdict.
5398 (ns_get_covering_families): Release charset.
5399 (ns_findfonts): Release NSFontDescriptor created with new.
5400 (ns_uni_to_glyphs): Fix indentation.
5401 (setString): Release attrStr before assigning new value.
5402
5403 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5404
5405 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5406 and NS_IMPL_COCOA.
5407 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5408 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5409
5410 2011-12-18 David Reitter <reitter@cmu.edu>
5411
5412 * nsterm.m (ns_term_init): Subscribe for notifications
5413 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5414 to method trackingNotification in EmacsMenu.
5415
5416 * nsmenu.m (trackingMenu): New variable.
5417 (trackingNotification): New method (from Aquamacs).
5418 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5419 from Aquamacs (Bug#7030).
5420
5421 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5422
5423 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5424 (symbol_to_nsstring): Fix indentation.
5425 (ns_symbol_to_pb): New function.
5426 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5427 (Fns_rotate_cut_buffers_internal): Remove.
5428 (Fns_store_selection_internal): Rename from
5429 Fns_store_cut_buffer_internal.
5430 (ns_get_foreign_selection, Fx_own_selection_internal)
5431 (Fx_disown_selection_internal, Fx_selection_exists_p)
5432 (Fns_get_selection_internal, Fns_store_selection_internal):
5433 Use ns_symbol_to_pb and check if return value is nil.
5434 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5435 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5436 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5437 renamed to Sns_store_selection_internal.
5438 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5439 and remove this function.
5440 (ns_handle_selection_clear): Remove, never used.
5441 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5442 here.
5443
5444 2011-12-17 Ken Brown <kbrown@cornell.edu>
5445
5446 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5447 GID is unknown (Bug#10257).
5448
5449 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5450
5451 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5452 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5453 which caused a build failure on GNU/Linux IA-64. This problem was
5454 introduced by my 2011-10-07 patch.
5455
5456 2011-12-15 Juri Linkov <juri@jurta.org>
5457
5458 * image.c (imagemagick_error): New function. (Bug#10112)
5459 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5460 Use `imagemagick_error' where ImageMagick functions return
5461 `MagickFalse'.
5462 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5463 proper order.
5464
5465 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5466
5467 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5468 fill background (Bug#8992).
5469
5470 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5471
5472 * window.c (Vwindow_combination_resize)
5473 (Vwindow_combination_limit): Use t instead of non-nil in
5474 doc-strings.
5475 (Vrecenter_redisplay): Add first sentence of doc-string on
5476 separate line.
5477 (Frecenter): Fix doc-string typo.
5478
5479 2011-12-11 Kenichi Handa <handa@m17n.org>
5480
5481 * coding.c (Funencodable_char_position): Pay attention to the
5482 buffer text relocation (Bug#9389).
5483
5484 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5485
5486 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5487 gtk_init (Bug#10100).
5488
5489 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5490
5491 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5492 IT->string is nil. (Bug#10263)
5493
5494 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5495
5496 * nsterm.h (x_free_frame_resources): Declare.
5497
5498 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5499 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5500
5501 * nsterm.h (ns_get_defaults_value): Declare.
5502
5503 * nsterm.m (ns_default): Call ns_get_defaults_value.
5504
5505 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5506
5507 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5508 (Bug#10170)
5509
5510 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5511
5512 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5513 that where the value of an _OBJC_* symbol points to is in the .bss
5514 section (Bug#10240).
5515
5516 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5517
5518 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5519 after the loop to call ccl_driver at least once (Bug#8619).
5520
5521 2011-12-08 Kenichi Handa <handa@m17n.org>
5522
5523 * ftfont.c (get_adstyle_property): Fix previous change
5524 (Bug#10233).
5525
5526 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5527
5528 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5529 dirs from the default value of EMACSLOADPATH (bug#10208).
5530
5531 2011-12-07 Glenn Morris <rgm@gnu.org>
5532
5533 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5534 installation and source directories as well. (Bug#10208)
5535
5536 2011-12-06 Chong Yidong <cyd@gnu.org>
5537
5538 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5539
5540 2011-12-06 Glenn Morris <rgm@gnu.org>
5541
5542 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5543 as an error, not just -1. (Bug#10217)
5544
5545 2011-12-05 Chong Yidong <cyd@gnu.org>
5546
5547 * keyboard.c (process_special_events): New function.
5548 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5549
5550 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5551
5552 * coding.c (encode_designation_at_bol): Don't use uninitialized
5553 local variable (Bug#9318).
5554
5555 2011-12-05 Kenichi Handa <handa@m17n.org>
5556
5557 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5558 return Qnil (Bug#8046, Bug#10193).
5559
5560 2011-12-05 Kenichi Handa <handa@m17n.org>
5561
5562 * coding.c (encode_designation_at_bol): New args charbuf_end and
5563 dst. Return the number of produced bytes. Callers changed.
5564 (coding_set_source): Return how many bytes coding->source was
5565 relocated.
5566 (coding_set_destination): Return how many bytes
5567 coding->destination was relocated.
5568 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5569 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5570
5571 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5572
5573 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5574 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5575 macro (Bug#9318).
5576
5577 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5578
5579 The following changes are to fix Bug#9318.
5580
5581 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5582 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5583 (encode_coding_iso_2022, encode_coding_sjis)
5584 (encode_coding_big5, encode_coding_charset): Use the above macros.
5585
5586 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5587
5588 * lisp.h (process_quit_flag): Fix external declaration.
5589
5590 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5591
5592 Don't macro-inline non-performance-critical code.
5593 * eval.c (process_quit_flag): New function.
5594 * lisp.h (QUIT): Use it.
5595
5596 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5597
5598 * nsfns.m (get_geometry_from_preferences): New function.
5599 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5600
5601 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5602
5603 * emacs.c (Qkill_emacs): Define.
5604 (syms_of_emacs): Initialize it.
5605 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5606 Qquit_flag to `kill-emacs' instead.
5607 (quit_throw_to_read_char): Add parameter `from_signal'.
5608 All callers changed. Call Fkill_emacs if requested and safe.
5609 * lisp.h (QUIT): Call Fkill_emacs if requested.
5610
5611 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5612
5613 * widget.c (update_wm_hints): Return if wmshell is null.
5614 (widget_update_wm_size_hints): New function.
5615
5616 * widget.h (widget_update_wm_size_hints): Declare.
5617
5618 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5619 widget_update_wm_size_hints (Bug#10104).
5620
5621 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5622
5623 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5624 before a newline, prepare the bidi iterator for consuming the
5625 newline, and keep the current paragraph direction. (Bug#10183)
5626 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5627
5628 2011-12-02 Juri Linkov <juri@jurta.org>
5629
5630 * search.c (Fword_search_regexp): New Lisp function created from
5631 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5632 (Fword_search_backward, Fword_search_forward)
5633 (Fword_search_backward_lax, Fword_search_forward_lax):
5634 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5635 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5636
5637 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5638
5639 * fileio.c (Finsert_file_contents): Move after-change-function call
5640 to before the "handled:" label, since all "goto handled" appear in
5641 cases where the *-change-functions have already been properly called
5642 (bug#10117).
5643
5644 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5645
5646 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5647 waiting for input. (Bug#10169)
5648
5649 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5650
5651 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5652 verifies glyph row's hash code--we have just reallocated the
5653 glyphs, so their contents can be complete garbage. (Bug#10164)
5654
5655 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5656
5657 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5658
5659 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5660
5661 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5662 attributes are tested _before_ calling verify_row_hash, to protect
5663 against GCC re-ordering of the tests. (Bug#10164)
5664
5665 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5666
5667 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5668
5669 * xterm.c (handle_one_xevent): Only set async_visible and friends
5670 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5671 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5672 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5673
5674 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5675
5676 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5677 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5678 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5679 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5680 All uses changed to use GCPRO1 etc.
5681 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5682 Revert to old implementation (i.e., before 2011-03-11).
5683
5684 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5685
5686 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5687 of scroll runs so as to avoid assigning disabled bogus rows and
5688 unnecessary graphics copy operations.
5689
5690 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5691
5692 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5693 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5694 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5695 (malloc, free, realloc, calloc): Redirect to e_* only when
5696 compiling Emacs.
5697
5698 * lisp.h (GCTYPEBITS): Move before first use.
5699 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5700 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5701 this macro definition.
5702
5703 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5704 _MSC_VER.
5705
5706 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5707
5708 * gtkutil.c (xg_create_frame_widgets):
5709 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5710 present with Gtk+ 2.0.
5711
5712 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5713
5714 * fileio.c (Finsert_file_contents): Undo previous change; see
5715 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5716
5717 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5718
5719 Rename locals to avoid shadowing.
5720 * fileio.c (Finsert_file_contents):
5721 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5722 * process.c (wait_reading_process_output):
5723 Rename inner 'proc' to 'p' to avoid shadowing.
5724 Indent for consistency with usual Emacs style.
5725
5726 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5727
5728 * xdisp.c (redisplay_window): If cursor row is not fully visible
5729 after recentering, and scroll-conservatively is set to a large
5730 number, scroll window by a few more lines to make the cursor fully
5731 visible and out of scroll-margin. (Bug#10105)
5732 (start_display): Don't move to the next line if the display should
5733 start at a newline that is part of a display vector or an overlay
5734 string. (Bug#10119)
5735
5736 2011-11-24 Juri Linkov <juri@jurta.org>
5737
5738 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5739 after the `MagickPingImage' call. (Bug#10112)
5740
5741 2011-11-23 Chong Yidong <cyd@gnu.org>
5742
5743 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5744
5745 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5746
5747 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5748 making another buffer current. (Bug#10114)
5749
5750 2011-11-23 Glenn Morris <rgm@gnu.org>
5751
5752 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5753
5754 2011-11-23 Chong Yidong <cyd@gnu.org>
5755
5756 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5757 using it (Bug#5984).
5758
5759 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5760
5761 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5762 and header-lines, as they don't have one computed for them.
5763 (Bug#10098)
5764
5765 * .gdbinit (prow): Make displayed values more self-explaining.
5766 Add row's hash code.
5767
5768 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5769
5770 * process.c (wait_reading_process_output): Fix asynchrounous
5771 GnuTLS socket handling on some versions of the GnuTLS library.
5772 (wait_reading_process_output): Add comment and URL.
5773
5774 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5775
5776 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5777
5778 2011-11-21 Chong Yidong <cyd@gnu.org>
5779
5780 * window.c (Fnext_window, Fprevious_window): Doc fix.
5781
5782 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5783
5784 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5785
5786 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5787
5788 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5789
5790 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5791
5792 * window.c (Fset_window_combination_limit): Rename argument
5793 STATUS to LIMIT.
5794 (Vwindow_combination_limit): Remove "status" from doc-string.
5795
5796 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5797
5798 * m/ibms390.h: Remove.
5799 * m/ibms390x.h: Don't include "ibms390.h".
5800
5801 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5802
5803 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5804 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5805
5806 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5807
5808 * casetab.c (Fset_case_table):
5809 * charset.c (Fcharset_after): Fix typos.
5810
5811 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5812
5813 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5814 Otherwise, valgrind does not work on some platforms.
5815 Problem reported by Andreas Schwab in
5816 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5817 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5818 is set, removing the need for VIRT_ADDRESS_VARIES.
5819 (PURE_P): Use a more-efficient implementation that needs just one
5820 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5821 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5822 to 4 (xorl, subq, cmpq, setbe).
5823 * alloc.c (pure): Always extern now, since that's the
5824 VIRT_ADDR_VARIES behavior.
5825 (PURE_POINTER_P): Use a single comparison, not two, for
5826 consistency with the new puresize.h.
5827 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5828 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5829 Remove VIRT_ADDR_VARIES no longer needed.
5830
5831 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5832
5833 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5834 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5835 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5836 behave as if the cursor position were at the window margin.
5837
5838 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5839 and the cursor position is out of bounds, behave as if the cursor
5840 position were at the window margin. (Bug#10075)
5841
5842 2011-11-18 Chong Yidong <cyd@gnu.org>
5843
5844 * window.c (Fwindow_combination_limit): Make first argument
5845 non-optional, since it is meaningless for live windows like the
5846 selected window.
5847
5848 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5849
5850 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5851
5852 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5853
5854 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5855 (graft_intervals_into_buffer): Simplify.
5856
5857 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5858
5859 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5860 hash values of the two rows.
5861 (copy_row_except_pointers): Preserve the used[] arrays and the
5862 hash values of the two rows. (Bug#10035)
5863 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5864
5865 * xdisp.c (row_hash): New function, body extracted from
5866 compute_line_metrics.
5867 (compute_line_metrics): Call row_hash, instead of computing the
5868 hash code inline.
5869
5870 * dispnew.c (verify_row_hash): Call row_hash for computing the
5871 hash code of a row, instead of duplicating code from xdisp.c.
5872
5873 * dispextern.h (row_hash): Add prototype.
5874
5875 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5876
5877 * frame.c (delete_frame): Don't delete the terminal when the last
5878 X frame is closed if emacs is built with GTK toolkit.
5879
5880 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5881
5882 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5883
5884 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5885
5886 * window.c (Vwindow_splits): Rename to
5887 Vwindow_combination_resize. Suggested by Juri Linkov.
5888 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5889 of Vwindow_splits.
5890
5891 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5892
5893 * nsfns.m (Fns_font_name):
5894 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5895
5896 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5897
5898 * window.h (window): Rename slot "nest" to "combination_limit".
5899 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5900 (Fset_window_nest): Rename to Fset_window_combination_limit.
5901 (Vwindow_nest): Rename to Vwindow_combination_limit.
5902 (recombine_windows, make_parent_window, make_window)
5903 (Fsplit_window_internal, saved_window)
5904 (Fset_window_configuration, save_window_save): Rename all
5905 occurrences of window_nest to window_combination_limit.
5906
5907 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5908
5909 * image.c (imagemagick_load_image): Fix typo.
5910
5911 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5912
5913 * xdisp.c (display_line): Move the call to
5914 highlight_trailing_whitespace before the call to
5915 compute_line_metrics, since the latter needs to see the final
5916 faces of all the glyphs to compute ROW's hash value.
5917 Fixes assertion violations in row_equal_p. (Bug#10035)
5918
5919 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5920
5921 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5922 just return (bug#10044).
5923
5924 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5925
5926 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5927 with user-defined heap size. Bump the default size of the temacs
5928 heap to 27MB, to avoid memory warning when running temacs.
5929 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5930
5931 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5932 current_matrix and desired_matrix. (Bug#9990)
5933 (verify_row_hash) [XASSERTS]: New function.
5934 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5935 that the hash value of glyph rows is correct.
5936
5937 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5938
5939 * window.h (window): Remove splits slot.
5940 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5941 (Fdelete_other_windows_internal, make_parent_window)
5942 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5943 (Fset_window_configuration, save_window_save): Don't deal with
5944 split status of windows.
5945 (saved_window): Remove splits slot.
5946 (Vwindow_splits): Rewrite doc-string.
5947
5948 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5949
5950 * xfns.c (unwind_create_frame):
5951 * nsfns.m (unwind_create_frame):
5952 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5953 Vframe_list (Bug#9999).
5954
5955 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5956
5957 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5958
5959 2011-11-11 Kenichi Handa <handa@m17n.org>
5960
5961 * callproc.c (Fcall_process): Set the member dst_multibyte of
5962 process_coding.
5963
5964 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5965
5966 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5967 avoid a crash (bug#9496).
5968
5969 2011-11-09 Chong Yidong <cyd@gnu.org>
5970
5971 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5972 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5973
5974 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5975
5976 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5977
5978 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5979
5980 Avoid some portability problems by eschewing 'extern inline' functions.
5981 The trivial performance wins aren't worth the portability hassles; see
5982 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5983 et seq.
5984 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5985 (window_box_width, window_box_left, window_box_left_offset)
5986 (window_box_right, window_box_right_offset): Undo previous change,
5987 by removing the "extern"s.
5988 * intervals.c (adjust_intervals_for_insertion)
5989 (adjust_intervals_for_deletion): Undo previous change,
5990 making these static again.
5991 (offset_intervals, temp_set_point_both, temp_set_point)
5992 (copy_intervals_to_string): No longer inline.
5993 * xdisp.c (window_text_bottom_y, window_box_width)
5994 (window_box_height, window_box_left_offset)
5995 (window_box_right_offset, window_box_left, window_box_right)
5996 (window_box): No longer inline.
5997
5998 2011-11-08 Chong Yidong <cyd@gnu.org>
5999
6000 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6001 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6002 Signal an error if not a live window.
6003 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6004 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6005
6006 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6007
6008 * lisp.h (syms_of_abbrev): Remove declaration.
6009 Reported by CHENG Gao <chenggao@royau.me>.
6010
6011 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6012
6013 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6014 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6015 of temacs in GUI mode.
6016
6017 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6018
6019 * window.h: Declare delete_all_child_windows instead of
6020 delete_all_subwindows.
6021 * window.c (Fwindow_nest, Fset_window_nest)
6022 (Fset_window_new_total, Fset_window_new_normal)
6023 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6024 (delete_all_subwindows): Rename to delete_all_child_windows.
6025 (Fdelete_other_windows_internal, Fset_window_configuration):
6026 Call delete_all_child_windows instead of delete_all_subwindows.
6027 * frame.c (delete_frame): Call delete_all_child_windows instead
6028 of delete_all_subwindows.
6029
6030 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6031
6032 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6033 This is also needed for porting to any host where GC_MARK_STACK is
6034 not GC_MAKE_GCPROS_NOOPS.
6035 (which_symbols): Use it.
6036
6037 2011-11-07 Kenichi Handa <handa@m17n.org>
6038
6039 * coding.c (coding_set_destination): Check coding->src_pos only
6040 when coding->src_object is a buffer (bug#9910).
6041
6042 * process.c (send_process): Set the member src_multibyte of coding
6043 to 0 (bug#9911) when sending a unibyte text.
6044
6045 * callproc.c (Fcall_process): Set the member src_multibyte of
6046 process_coding to 0 (bug#9912).
6047
6048 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6049
6050 * xmenu.c (cleanup_widget_value_tree): New function.
6051 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6052 calling free_menubar_widget_value_tree directly (Bug#9830).
6053
6054 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6055
6056 Fix some portability problems with 'inline'.
6057 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6058 (window_box_width, window_box_left, window_box_left_offset)
6059 (window_box_right, window_box_right_offset): Declare extern.
6060 Otherwise, these inline functions do not conform to C99 and
6061 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6062 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6063 * intervals.c (adjust_intervals_for_insertion)
6064 (adjust_intervals_for_deletion): Now extern, because otherwise the
6065 extern inline functions 'offset_intervals' couldn't refer to it.
6066 (static_offset_intervals): Remove.
6067 (offset_intervals): Rewrite using the old contents of
6068 static_offset_intervals. The old version didn't conform to C99
6069 because an extern inline function contained a reference to an
6070 identifier with static linkage.
6071
6072 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6073
6074 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6075 GC.
6076
6077 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6078
6079 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6080 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6081 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6082 return Qleft_to_right.
6083
6084 2011-11-06 Chong Yidong <cyd@gnu.org>
6085
6086 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6087 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6088 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6089 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6090 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6091 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6092 (Fwindow_vscroll): Doc fix.
6093 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6094 argument, since it makes no sense to pass a live window and for
6095 consistency with window-child.
6096
6097 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6098
6099 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6100 support MSVC.
6101
6102 2011-11-05 Jason Rumney <jasonr@gnu.org>
6103
6104 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6105 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6106 fonts (Bug#6029).
6107 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6108 bitwise arithmetic preventing use of unicode-sip and non-truetype
6109 opentype fonts.
6110
6111 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6112
6113 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6114 "emacs"-only part.
6115
6116 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6117 initialization code to keep similarity to xfns.c after changes
6118 from 2011-11-05.
6119
6120 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6121
6122 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6123 (unwind_create_frame): New function (Bug#9943).
6124 (Fx_create_frame): Restructure code to be more similar to the one in
6125 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6126 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6127 Move terminal->reference_count++ just before making the frame official
6128 (Bug#9943).
6129
6130 * nsterm.m (x_free_frame_resources): New function.
6131 (x_destroy_window): Move code to x_free_frame_resources.
6132
6133 * xfns.c (unwind_create_frame): Fix comment.
6134 (Fx_create_frame, x_create_tip_frame):
6135 Move terminal->reference_count++ just before making the frame
6136 official. Move initialization of image_cache_refcount and
6137 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6138
6139 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6140
6141 Support MSVC build with newer versions of Visual Studio.
6142 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6143 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6144 nt/gmake.defs.
6145
6146 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6147 which are not supported by MSVC.
6148 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6149 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6150 bitfields.
6151 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6152 types in bitfields.
6153 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6154
6155 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6156
6157 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6158
6159 Support MSVC build with newer versions of Visual Studio.
6160 * w32.c: Don't include w32api.h for MSVC.
6161 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6162
6163 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6164 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6165 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6166 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6167 e_* cousins.
6168 (alloca) [_MSC_VER]: Define to _alloca.
6169
6170 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6171
6172 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6173
6174 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6175
6176 * xdisp.c (note_mouse_highlight): If either of
6177 previous/next-single-property-change returns nil, treat that as
6178 the beginning or the end of the buffer. (Bug#9955)
6179
6180 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6181
6182 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6183 label is not null (Bug#9951).
6184 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6185 may be NULL.
6186
6187 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6188
6189 * window.c (Fwindow_body_size): Mention in the doc string that the
6190 return value is in frame's canonical units. (Bug#9949)
6191
6192 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6193
6194 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6195
6196 * w32fns.c (unwind_create_frame): If needed, free the glyph
6197 matrices of the partially constructed frame. (Bug#9943)
6198 * xfns.c (unwind_create_frame): Likewise.
6199
6200 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6201
6202 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6203 Don't stop backward scan on the continuation glyph, even though
6204 its CHARPOS is positive.
6205 (mouse_face_from_buffer_pos, note_mouse_highlight):
6206 Rename cover_string to disp_string.
6207
6208 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6209
6210 * window.c (temp_output_buffer_show): Don't use
6211 Vtemp_buffer_show_specifiers.
6212 (Vtemp_buffer_show_specifiers): Remove unused variable.
6213
6214 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6215
6216 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6217 past the beginning of the current glyph matrix.
6218
6219 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6220
6221 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6222 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6223 HAVE_GTK3 (Bug#9869).
6224
6225 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6226 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6227
6228 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6229
6230 * xterm.c: Declare x_handle_net_wm_state to return int.
6231 (handle_one_xevent): Check if we are iconified but don't have
6232 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6233 (get_current_wm_state): Return non-zero if not hidden,
6234 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6235 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6236 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6237 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6238
6239 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6240
6241 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6242 so that this new function doesn't get optimized away by a
6243 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6244
6245 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6246
6247 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6248
6249 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6250
6251 Fix the `xbytecode' command.
6252 * .gdbinit (xprintbytestr): New command.
6253 (xwhichsymbols): Rename from `which'; all callers changed.
6254 (xbytecode): Print the byte-code string as well.
6255
6256 2011-10-29 Kim Storm <storm@cua.dk>
6257
6258 * alloc.c (which_symbols): New function.
6259
6260 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6261
6262 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6263 line. (Bug#9903)
6264
6265 2011-10-29 Glenn Morris <rgm@gnu.org>
6266
6267 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6268 Not clear what it was for, and it causes various bugs. (Bug#9839)
6269
6270 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6271
6272 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6273 possible random value that matches one of those tested as
6274 condition to clear the mouse face.
6275
6276 2011-10-28 Chong Yidong <cyd@gnu.org>
6277
6278 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6279
6280 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6281
6282 * window.c (make_window): Initialize phys_cursor_on_p.
6283
6284 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6285
6286 * lisp.h (struct Lisp_Symbol): Update comments.
6287
6288 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6289
6290 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6291
6292 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6293
6294 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6295 <oslsachem@gmail.com> for helping to debug this.
6296
6297 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6298 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6299 (g_b_init_get_glyph_outline_w): New static variables.
6300 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6301 (GetGlyphOutlineW_Proc): New typedefs.
6302 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6303 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6304 New functions.
6305 (w32font_open_internal, compute_metrics):
6306 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6307 instead of calling the "wide" APIs directly.
6308
6309 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6310
6311 * w32.h (syms_of_w32font): Add prototype.
6312
6313 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6314
6315 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6316 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6317 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6318 (Fmove_to_window_line): Doc fix.
6319
6320 2011-10-27 Chong Yidong <cyd@gnu.org>
6321
6322 * process.c (make_process): Set gnutls_state to NULL.
6323
6324 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6325 non-NULL, regardless of GNUTLS_INITSTAGE.
6326 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6327 an error. Set process slots as soon as we allocate them.
6328
6329 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6330
6331 2011-10-27 Chong Yidong <cyd@gnu.org>
6332
6333 * gnutls.c (emacs_gnutls_deinit): New function.
6334 Deallocate credentials structures as well as calling gnutls_deinit.
6335 (Fgnutls_deinit, Fgnutls_boot): Use it.
6336
6337 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6338 (deactivate_process): Call emacs_gnutls_deinit.
6339
6340 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6341
6342 * image.c (x_create_x_image_and_pixmap):
6343 * w32.c (sys_rename, w32_delayed_load):
6344 * w32font.c (fill_in_logfont):
6345 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6346
6347 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6348
6349 * w32fns.c (w32_default_color_map): New function,
6350 extracted from Fw32_default_color_map.
6351 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6352
6353 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6354
6355 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6356
6357 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6358
6359 * keyboard.c (test_undefined): New function (bug#9751).
6360 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6361
6362 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6363
6364 * sysdep.c (init_sys_modes): Fix the check for the controlling
6365 terminal (Bug#6649).
6366
6367 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6368
6369 * dispextern.h (struct bidi_it): New member next_en_type.
6370
6371 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6372 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6373 current character, check also for next_en_type being WEAK_EN.
6374 (bidi_resolve_weak): Don't enter the expensive loop if the current
6375 position is before next_en_pos. Record the bidi type of the first
6376 non-ET, non-BN character we find, in addition to its position.
6377 (bidi_level_of_next_char): Invalidate next_en_type when
6378 next_en_pos is over-stepped.
6379
6380 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6381
6382 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6383 * editfns.c: Rewrite current-time-zone so that it invokes
6384 the equivalent of (format-time-string "%Z") to get the time zone name.
6385 This fixes a bug when the time zone name contains characters that
6386 need converting from the system time locale to Emacs internal format.
6387 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6388 that patch fixed format-time-string to do the conversion, but
6389 I forgot to fix current-time-zone.
6390 (format_time_string): New function, containing most of
6391 what Fformat_time_string used to contain.
6392 (Fformat_time_string): Rewrite in terms of format_time_string.
6393 This doesn't change this function's behavior.
6394 (current-time-zone): Rewrite to use format_time_string.
6395 This fixes the bug reported by Michael Schierl in
6396 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6397 Jason Rumney's 2007-06-07 change worked around this bug, but
6398 didn't fix it.
6399 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6400
6401 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6402
6403 * xdisp.c (start_display): If the character at POS is displayed
6404 via a display vector, reset IT->current.dpvec_index to zero.
6405 (try_window_reusing_current_matrix): If a line ends in a display
6406 vector or the next line starts in a display vector, continue
6407 redrawing the window even though the character position of
6408 start_row was reached.
6409 (Bug#9771, part 2)
6410
6411 2011-10-18 Chong Yidong <cyd@gnu.org>
6412
6413 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6414 with nobreak-char-display too.
6415
6416 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6417
6418 Fix part 3 of bug#9771.
6419 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6420 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6421 non-neutral characters if the current character is a paragraph
6422 separator (a.k.a. Newline). This avoids running the same
6423 expensive loop twice, once when we consume the preceding newline
6424 and the other time when the line actually needs to be displayed.
6425 Avoid the loop when we see neutrals on the base embedding level
6426 following a character whose directionality is the same as the
6427 paragraph's. This avoids running the expensive loop when a line
6428 ends in a long sequence of neutrals, like control characters.
6429 Add assertion against STRONG_AL type. Slightly rearrange code
6430 that determines the type of a neutral given the first non-neutral
6431 that follows it.
6432 (bidi_level_of_next_char): Set next_en_pos to zero when
6433 invalidating its info.
6434
6435 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6436
6437 * xdisp.c (push_display_prop): Determine whether to record string
6438 or buffer position by IT->string, not by IT->method. Allow
6439 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6440 (move_it_vertically_backward): Don't look for character position
6441 immediately after the newline when in a continuation line.
6442 (Bug#9771, part 1)
6443
6444 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6445
6446 * window.c (coordinates_in_window): Rewrite and delabelize
6447 vertical border check. (Bug#5357) (Bug#9618)
6448
6449 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6450
6451 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6452 errors in XSetWindowBorder (bug#9310).
6453
6454 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6455
6456 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6457 avoid crash when xmalloc overrun checking is enabled.
6458
6459 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6460
6461 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6462 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6463 cursor motion with <left> and <right> arrow keys.
6464
6465 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6466 some callers set that themselves.
6467
6468 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6469
6470 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6471 display string and the previous row comes from the same string and
6472 is empty. (Bug#9739) (Bug#9738)
6473
6474 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6475
6476 * doc.c (get_doc_string): Encode file name (bug#9735).
6477
6478 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6479
6480 * bidi.c (bidi_level_of_next_char):
6481 * xdisp.c (get_visually_first_element): Remove old incorrect
6482 comments regarding the Unicode Line Separator character.
6483
6484 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6485
6486 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6487
6488 * alloc.c (Fgc_status): Do not access beyond zombies array
6489 boundary if nzombies > MAX_ZOMBIES.
6490 * alloc.c (dump_zombies): Add missing format specifier.
6491
6492 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6493
6494 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6495 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6496
6497 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6498 Some packages use them to denote characters with modifiers.
6499
6500 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6501
6502 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6503 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6504 matching a pp-number. Rename parameter var to var1.
6505
6506 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6507
6508 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6509
6510 2011-10-08 Glenn Morris <rgm@gnu.org>
6511
6512 * callint.c (Fcall_interactively): Give a more explicit error for the
6513 'c' case with a non-character input. (Bug#8479)
6514
6515 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6516
6517 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6518 lines.
6519 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6520 lines that are hscrolled on the left.
6521
6522 * dispnew.c (buffer_posn_from_coords): Account for a possible
6523 presence of header-line. (Bug#4426)
6524
6525 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6526
6527 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6528 Don't advertise functionality which we discourage or doesn't work.
6529
6530 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6531
6532 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6533 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6534 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6535 this makes Emacs dump core during garbage collection on rare
6536 occasions. sizeof is obviously inferior to offsetof here, so
6537 stick with offsetof.
6538 (GC_POINTER_ALIGNMENT): New macro.
6539 (mark_memory): Omit 3rd (offset) arg; caller changed.
6540 Don't assume EMACS_INT alignment is the same as pointer alignment.
6541
6542 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6543
6544 * keyboard.c (read_key_sequence_remapped): New var.
6545 (read_key_sequence): Compute remapping in the right buffer.
6546 (command_loop_1): Use read_key_sequence's remapping directly.
6547
6548 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6549
6550 * dired.c (file_name_completion): Don't expand file name.
6551 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6552 before checking file name handler.
6553
6554 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6555 they've been requested explicitly (bug#9591).
6556
6557 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6558
6559 * keymap.c (Fsingle_key_description): Use make_specified_string
6560 instead of build_string to build string from push_key_description.
6561 (Bug#5193)
6562
6563 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6564
6565 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6566 This fixes a Y2038 bug on 64-bit hosts.
6567 * buffer.c (reset_buffer):
6568 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6569 (Fclear_buffer_auto_save_failure):
6570 Use 0, not -1, to represent an unset failure time, since time_t
6571 might not be signed.
6572
6573 Remove dependency on glibc malloc internals.
6574 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6575 Move back here from lisp.h, but with their new implementations.
6576 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6577 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6578 * charset.c (charset_table_init): New static var.
6579 (syms_of_charset): Use it instead of xmalloc. This removes a
6580 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6581 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6582 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6583 Move back to alloc.c.
6584 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6585 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6586
6587 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6588
6589 * nsterm.m (windowDidResize): Call x_set_window_size only when
6590 ns_in_resize is true. Otherwise set pixelwidth/height and
6591 call change_frame_size (Bug#9628).
6592
6593 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6594
6595 Port --enable-checking=all to Fedora 14 x86-64.
6596 * charset.c (syms_of_charset): Also account for glibc malloc's
6597 internal overhead when calculating the initial malloc maximum.
6598
6599 Port --enable-checking=all to Fedora 14 x86.
6600 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6601 Move to lisp.h.
6602 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6603 (overrun_check_realloc, overrun_check_free):
6604 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6605 That way, xmalloc returns a properly-aligned pointer even if
6606 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6607 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6608 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6609 into account when calculating the initial malloc maximum.
6610 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6611 Move here from alloc.c, so that charset.c can use it too.
6612 Properly align; the old code wasn't right for common 32-bit hosts
6613 when configured with --enable-checking=all.
6614 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6615 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6616
6617 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6618
6619 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6620 use EDOM.
6621
6622 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6623
6624 * xdisp.c (compute_display_string_end): If there's no display
6625 string at CHARPOS, return -1.
6626
6627 * bidi.c (bidi_fetch_char): When compute_display_string_end
6628 returns a negative value, treat the character as a normal
6629 character not covered by a display string. (Bug#9624)
6630
6631 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6632
6633 * lread.c (Fread_from_string): Fix typo in docstring.
6634
6635 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6636
6637 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6638 newline, reseat the iterator instead of bidi-iterating there one
6639 character at a time. (Bug#9610)
6640 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6641 TO_CHARPOS if the bidi iterator is at base embedding level.
6642
6643 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6644
6645 * lread.c (readevalloop): Use correct code for NBSP.
6646 (read1): Likewise. (Bug#9608)
6647
6648 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6649
6650 * dbusbind.c (Fdbus_register_signal): When service is not
6651 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6652
6653 2011-09-25 Glenn Morris <rgm@gnu.org>
6654
6655 * buffer.c (truncate-lines): Doc fix.
6656
6657 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6658
6659 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6660 (Fset_window_next_buffers): Doc fix.
6661
6662 2011-09-24 Glenn Morris <rgm@gnu.org>
6663
6664 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6665
6666 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6667
6668 Fix minor problems found by static checking.
6669 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6670 * indent.c (Fvertical_motion): Fix == vs = typo.
6671
6672 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6673
6674 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6675 Default value is now t. Doc fix.
6676
6677 * indent.c (Fvertical_motion): Compute and apply the overshoot
6678 logic when moving up, not only when moving down. Fix the
6679 confusing name and values of the it_overshoot_expected variable;
6680 logic changes accordingly. (Bug#9254) (Bug#9549)
6681
6682 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6683 CHARPOS is covered by a display string which includes newlines.
6684 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6685 is covered by a display string with embedded newlines.
6686
6687 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6688
6689 * dbusbind.c (Fdbus_register_signal): Add match rule to
6690 Vdbus_registered_objects_table. (Bug#9581)
6691 (Fdbus_register_method, Vdbus_registered_objects_table):
6692 Fix docstring.
6693
6694 2011-09-24 Jim Meyering <meyering@redhat.com>
6695
6696 do not ignore write error for any output size
6697 The previous change was incomplete.
6698 While it makes emacs --batch detect the vast majority of stdout
6699 write failures, errors were still ignored whenever the output size is
6700 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6701 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6702 && echo FAIL: ignored write error
6703 FAIL: ignored write error
6704 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6705 && echo FAIL: ignored write error
6706 FAIL: ignored write error
6707 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6708
6709 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6710
6711 * emacs.c (Fkill_emacs): In noninteractive mode exit
6712 non-successfully if a write error occurred on stdout. (Bug#9574)
6713
6714 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6715
6716 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6717 the xassert test.
6718
6719 * dispextern.h (struct it): Update the comment documenting what
6720 can it->OBJECT be.
6721
6722 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6723
6724 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6725 a display string, extend search for cursor position to end of row.
6726 (find_row_edges): If the row ends in a newline from a display
6727 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6728 Handle the case of a display string with multiple newlines.
6729 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6730 non-empty line. Fixes confusing cursor motion with arrow keys at
6731 the beginning of a line that starts with whitespace.
6732
6733 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6734
6735 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6736 (bug#9493).
6737
6738 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6739
6740 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6741 boolean (Bug#9154).
6742
6743 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6744
6745 * xdisp.c (display_line): Record maximum and minimum buffer
6746 positions even if no glyphs were produced (e.g., by a zero-width
6747 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6748 buffer positions that will be removed from the glyph row because
6749 they don't fit.
6750 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6751 column is beyond frame width: don't subtract 1 "pixel" when
6752 computing width of the stretch.
6753 (reseat_at_next_visible_line_start): Undo the change made on
6754 2011-09-17 that saved paragraph information and restored it after
6755 the call to `reseat'. (Bug#9545)
6756
6757 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6758
6759 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6760 and turn window cursor on if cleared (Bug#9415).
6761
6762 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6763
6764 * search.c (boyer_moore): Take unibyte characters from pattern
6765 literally. (Bug#9458)
6766
6767 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6768
6769 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6770
6771 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6772
6773 Fix minor problem found by static checking.
6774 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6775 initialized, to pacify gcc -Wuninitialized.
6776
6777 * fileio.c: Report proper errno when syscall falls.
6778 (Finsert_file_contents): Save and restore errno,
6779 so that report_file_error outputs the correct diagnostic.
6780 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6781
6782 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6783
6784 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6785
6786 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6787
6788 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6789 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6790
6791 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6792
6793 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6794 about the current paragraph and restore it after the call to reseat.
6795
6796 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6797 (bidi_find_paragraph_start): Search back for paragraph beginning
6798 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6799 (bidi_move_to_visually_next): Only trigger paragraph-related
6800 computations when the last character is a newline or at EOB, not
6801 just any NEUTRAL_B. (Bug#9470)
6802
6803 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6804 truncated lines if point is covered by a display string. (Bug#9524)
6805
6806 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6807
6808 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6809 (cons_to_x_long): New function.
6810 (lisp_data_to_selection_data): Use it. Correct the test for
6811 short-versus-long data; it was negated. Break out of vector
6812 loop, for efficiency, when a long datum is discovered.
6813
6814 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6815
6816 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6817
6818 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6819
6820 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6821 GCC PR/17406) by declaring this function with external scope.
6822
6823 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6824
6825 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6826 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6827
6828 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6829
6830 * editfns.c (Fformat): Correctly handle text properties on "%%".
6831
6832 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6833
6834 * xterm.c (x_draw_composite_glyph_string_foreground):
6835 * w32term.c (x_draw_composite_glyph_string_foreground):
6836 * term.c (encode_terminal_code):
6837 * composite.c (composition_update_it, get_composition_id):
6838 * xdisp.c (get_next_display_element)
6839 (fill_composite_glyph_string): Add comments about special meaning
6840 of TAB characters in a composition.
6841
6842 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6843
6844 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6845 This occurs when processing a multibyte format.
6846 Problem reported by Wolfgang Jenker.
6847
6848 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6849
6850 * xdisp.c (try_cursor_movement): Only check for exact match if
6851 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6852
6853 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6854
6855 Remove unused external symbols.
6856 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6857 * xdisp.c (calc_pixel_width_or_height): Now static.
6858 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6859 * indent.c (check_display_width):
6860 * w32term.c: Fix comment to match code.
6861 * xterm.c, xterm.h (x_catching_errors): Remove.
6862
6863 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6864
6865 * xselect.c: Use signed conversions more consistently (Bug#9498).
6866 (selection_data_to_lisp_data): Assume incoming selection data are
6867 signed integers, not unsigned. This is to be consistent with
6868 outgoing selection data, which was modified to use signed integers
6869 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6870 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6871 expects long, not unsigned long.
6872
6873 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6874
6875 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6876 computation of loop end. Reported by Johan Bockgård
6877 <bojohan@gnu.org>.
6878
6879 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6880
6881 * frame.c (Fother_visible_frames_p): Function deleted.
6882
6883 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6884
6885 * indent.c (compute_motion): Process display vector front to back
6886 rather than the other way around. (Bug#2496)
6887
6888 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6889
6890 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6891
6892 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6893
6894 * minibuf.c (Fread_from_minibuffer): Doc fix.
6895
6896 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6897
6898 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6899 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6900
6901 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6902
6903 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6904 value for non-existent files.
6905
6906 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6907
6908 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6909 set its "size" to -1. This will set the modtime_size field of
6910 the corresponding buffer to -1, which is what
6911 verify-visited-file-modtime expects for files that do not exist.
6912 (Bug#9139)
6913
6914 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6915
6916 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6917 here ...
6918 * lisp.h: ... from here. push_key_description is no longer
6919 defined in keyboard.c, so its declaration should not be in
6920 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6921 logically belongs with push_key_description.
6922
6923 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6924
6925 * buffer.h: Include <sys/types.h> instead of <time.h>.
6926 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6927 Problem reported by Herbert J. Skuhra.
6928
6929 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6930
6931 * xml.c (parse_region): Make the parsing work for
6932 non-comment-starting XML files again (bug#9144).
6933
6934 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6935
6936 * image.c (gif_load): Fix calculation of bottom and right corner.
6937 (Bug#9468)
6938
6939 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6940
6941 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6942 redisplay in small windows.
6943
6944 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6945
6946 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6947
6948 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6949
6950 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6951 Operate on live windows only.
6952
6953 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6954
6955 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6956
6957 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6958
6959 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6960 only under bidi iteration.
6961
6962 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6963
6964 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6965
6966 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6967
6968 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6969 Without this fix, the command to link temacs failed due to an
6970 undefined symbol __builtin_isnan. This is because
6971 /usr/include/iso/math_c99.h #defines isnan(x) to
6972 __builtin_isnan(x), but the bundled gcc, which identifies itself
6973 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6974 a __builtin_isnan.
6975 * floatfns.c (isnan): #undef, and then #define to a clone of
6976 what's in data.c.
6977 (Fisnan): Always define, since it's always available now.
6978 (syms_of_floatfns): Always define isnan at the Lisp level.
6979
6980 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6981
6982 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6983
6984 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6985
6986 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6987 The previous code assumed that file offsets (off_t values) fit in
6988 EMACS_INT variables, which is not true on typical 32-bit hosts.
6989 The code messed up by falsely reporting buffer overflow in cases
6990 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6991 when "big" contains more than 2**29 bytes, even though this
6992 inserts just one byte and does not overflow the buffer.
6993 (Finsert_file_contents): Store file offsets as off_t
6994 values, not as EMACS_INT values. Check for overflow when
6995 converting between EMACS_INT and off_t. When checking for
6996 buffer overflow or for overlap, take the offsets into account.
6997 Don't use EMACS_INT for small values where int suffices.
6998 When checking for overlap, fix a typo: ZV was used where
6999 ZV_BYTE was intended.
7000 (Fwrite_region): Don't assume off_t fits into 'long'.
7001 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7002
7003 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7004
7005 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7006
7007 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7008
7009 sprintf-related integer and memory overflow issues (Bug#9412).
7010
7011 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7012 (esprintf, exprintf, evxprintf): New functions.
7013 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7014 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7015 (modify_event_symbol): Do not assume that the length of
7016 name_alist_or_stem is safe to alloca and fits in int.
7017 (Fexecute_extended_command): Likewise for function name and binding.
7018 (Frecursion_depth): Wrap around reliably on integer overflow.
7019 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7020 since some callers pass EMACS_INT values.
7021 (Fsingle_key_description): Don't crash if symbol name contains more
7022 than MAX_ALLOCA bytes.
7023 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7024 (get_minibuffer): Arg is now EMACS_INT, not int.
7025 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7026 (esprintf, exprintf, evxprintf): New decls.
7027 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7028
7029 * dbusbind.c (signature_cat): New function.
7030 (xd_signature, Fdbus_register_signal):
7031 Do not overrun buffer; instead, report string overflow.
7032
7033 * dispnew.c (add_window_display_history): Don't overrun buffer.
7034 Truncate instead; this is OK since it's just a log.
7035
7036 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7037 even if the time zone offset is outlandishly large.
7038 Don't mishandle offset == INT_MIN.
7039
7040 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7041 when creating daemon; the previous buffer-overflow check was incorrect.
7042
7043 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7044 which has the guts of the old verror function.
7045
7046 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7047 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7048
7049 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7050 (font_unparse_xlfd): Don't blindly alloca long strings.
7051 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7052 fits in int, when using sprintf. Use single snprintf to count
7053 length of string rather than counting it via multiple sprintfs;
7054 that's simpler and more reliable.
7055 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7056 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7057 sprintf, in case result does not fit in int.
7058
7059 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7060 (fontset_from_font): Print it.
7061
7062 * frame.c (tty_frame_count): Now printmax_t, not int.
7063 (make_terminal_frame, set_term_frame_name): Print it.
7064 (x_report_frame_params): In X, window IDs are unsigned long,
7065 not signed long, so print them as unsigned.
7066 (validate_x_resource_name): Check for implausibly long names,
7067 and don't assume name length fits in 'int'.
7068 (x_get_resource_string): Don't blindly alloca invocation name;
7069 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7070 not fit in int.
7071
7072 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7073 (xg_check_special_colors, xg_set_geometry):
7074 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7075
7076 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7077 Use esprintf, not sprintf, in case result does not fit in int.
7078
7079 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7080 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7081 it as a large positive number.
7082 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7083 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7084
7085 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7086 in case result does not fit in int.
7087
7088 * print.c (float_to_string): Detect width overflow more reliably.
7089 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7090 buffer overrun. Don't assume list length fits in 'int'. Treat
7091 print length of 0 as 0, not as infinity; to be consistent with other
7092 uses of print length in this function. Don't overflow print length
7093 index. Don't assume hash table size fits in 'long', or that
7094 vectorlike size fits in 'unsigned long'.
7095
7096 * process.c (make_process): Use printmax_t, not int, to format
7097 process-name gensyms.
7098
7099 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7100
7101 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7102 to avoid potential buffer overrun.
7103
7104 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7105 if X resource line is longer than 512 bytes.
7106
7107 * xfns.c (x_window): Make sprintf buffer a bit bigger
7108 to avoid potential buffer overrun.
7109
7110 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7111
7112 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7113
7114 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7115
7116 Integer overflow fixes for scrolling, etc.
7117 Without these, Emacs silently mishandles large integers sometimes.
7118 For example, "C-u 4294967297 M-x recenter" was treated as if
7119 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7120
7121 * xdisp.c (try_window_id): Check Emacs fixnum range before
7122 converting to 'int'.
7123
7124 * window.c (window_scroll_line_based, Frecenter):
7125 Check that an Emacs fixnum is in range before assigning it to 'int'.
7126 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7127 values converted from Emacs fixnums.
7128 (Frecenter): Don't wrap around a line count if it is out of 'int'
7129 range; instead, treat it as an extreme value.
7130 (Fset_window_configuration, compare_window_configurations):
7131 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7132
7133 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7134 that can exceed INT_MAX. Check that EMACS_INT value is in range
7135 before assigning it to the (possibly-narrower) index.
7136 (match_limit): Don't assume that a fixnum can fit in 'int'.
7137
7138 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7139 exceed INT_MAX.
7140
7141 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7142 (Fvertical_motion): Don't wrap around LINES values that don't fit
7143 in 'int'. Instead, treat them as extreme values. This is good
7144 enough for windows, which can't have more than INT_MAX lines anyway.
7145
7146 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7147
7148 * Require libxml/parser.h to avoid compilation warning.
7149
7150 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7151
7152 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7153 since this reportedly can destroy thread storage.
7154
7155 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7156
7157 * syntax.c (find_defun_start): Update all cache variables if
7158 exiting early (Bug#9401).
7159
7160 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7161
7162 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7163
7164 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7165 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7166 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7167
7168 * term.c (tty_append_glyph): New function.
7169 (produce_stretch_glyph): Static function and its prototype deleted.
7170
7171 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7172 Add prototypes.
7173
7174 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7175
7176 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7177 when checking :margin (Bug#9390).
7178 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7179 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7180 so that the name doesn't mislead. All uses changed.
7181
7182 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7183
7184 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7185 set_tty_hooks.
7186
7187 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7188
7189 * xdisp.c (move_it_to): Don't bail out early when reaching
7190 position beyond to_charpos, if we are scanning backwards.
7191 (move_it_vertically_backward): When DY == 0, make sure we get to
7192 the first character in the line after the newline.
7193
7194 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7195
7196 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7197 (ccl_driver): Do not generate an out-of-range pointer.
7198 (Fccl_execute_on_string): Remove unnecessary check for
7199 integer overflow, noted by Stefan Monnier in
7200 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7201 Remove a FIXME that didn't need fixing.
7202 Simplify the newly-introduced buffer reallocation code.
7203
7204 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7205
7206 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7207
7208 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7209
7210 Integer and memory overflow issues (Bug#9196).
7211
7212 * doc.c (get_doc_string): Rework so that
7213 get_doc_string_buffer_size is the actual buffer size, rather than
7214 being 1 less than the actual buffer size; this makes xpalloc more
7215 convenient.
7216
7217 * image.c (x_allocate_bitmap_record, cache_image):
7218 * xselect.c (Fx_register_dnd_atom):
7219 Simplify previous changes by using xpalloc.
7220
7221 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7222 since either will do and ptrdiff_t is convenient with xpalloc.
7223
7224 * charset.c (charset_table_size)
7225 (struct charset_sort_data.priority): Now ptrdiff_t.
7226 (charset_compare): Don't overflow if priorities differ greatly.
7227 (Fsort_charsets): Don't assume list length fits in int.
7228 Check for size-calculation overflow when allocating sort data.
7229 (syms_of_charset): Allocate an initial charset table that is
7230 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7231
7232 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7233
7234 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7235 The actual value is always <= INT_MAX, and leaving it unsigned made
7236 overflow checking harder.
7237
7238 * dispextern.h (struct glyph_matrix.rows_allocated)
7239 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7240 with xpalloc. The values are still always <= INT_MAX.
7241
7242 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7243
7244 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7245 (SAFE_NALLOCA): New macro.
7246
7247 * region-cache.c (struct boundary.pos, find_cache_boundary)
7248 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7249 (set_cache_region, invalidate_region_cache)
7250 (revalidate_region_cache, know_region_cache, region_cache_forward)
7251 (region_cache_backward, pp_cache):
7252 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7253 so that ptrdiff_t * can be passed to xpalloc.
7254 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7255 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7256 (pp_cache): Don't assume cache_len fits in int.
7257 * region-cache.h: Adjust extern decls to match.
7258
7259 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7260 EMACS_INT, since either will do, for xpalloc.
7261
7262 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7263 (xnmalloc, xnrealloc, xpalloc): New functions.
7264
7265 * bidi.c (bidi_shelve_header_size): New constant.
7266 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7267 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7268
7269 * bidi.c (bidi_cache_shrink):
7270 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7271 (overlay_strings):
7272 Don't update size of array until after memory allocation succeeds,
7273 because xmalloc/xrealloc may not return.
7274 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7275 now that we have proper integer overflow checking.
7276 (record_overlay_string, overlay_strings): Catch overflows when
7277 calculating size of overlay_str_buf.
7278
7279 * callproc.c (Fcall_process): Check for size overflow when
7280 calculating size of args2.
7281 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7282 Normally we prefer signed values, but sticking with ptrdiff_t would
7283 require adding more-complicated checks.
7284
7285 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7286 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7287 Redo buffer-overflow calculations to avoid integer overflow.
7288 Add a FIXME comment where memory seems to be over-allocated.
7289
7290 * character.c (Fstring): Check for size-calculation overflow.
7291
7292 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7293 unnecessary integer overflow. Check for size overflow.
7294 (encode_coding_object): Don't update size until xmalloc succeeds.
7295
7296 * composite.c (get_composition_id): Check for overflow in glyph
7297 length calculations.
7298
7299 Integer and memory overflow fixes for display code.
7300 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7301 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7302 (scrolling_window): Check for overflow in size calculations.
7303 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7304 Don't assume glyph table len fits in int.
7305 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7306 (row_table_size): Now ptrdiff_t, not int.
7307 (scrolling_window): Avoid overflow in size calculations.
7308 Don't update size until allocation succeeds.
7309 * fns.c (concat): Check for overflow in size calculations.
7310 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7311 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7312 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7313
7314 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7315 (get_doc_string): Check for size calculation overflow.
7316 Don't update size until allocation succeeds.
7317 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7318 EMACS_INT, where ptrdiff_t will do.
7319 (Fsubstitute_command_keys): Check for string overflow.
7320
7321 * editfns.c (set_time_zone_rule): Don't assume environment length
7322 fits in int.
7323 (message_length): Now ptrdiff_t, not int.
7324 (Fmessage_box): Don't update size until allocation succeeds.
7325 Don't assume message length fits in int.
7326 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7327
7328 * emacs.c (main): Do not reallocate argv, since there is a null at
7329 the end that can be overwritten, and this way there's no need to
7330 worry about size-calculation overflow.
7331 (sort_args): Check for size-calculation overflow.
7332
7333 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7334 alloc succeeds.
7335 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7336
7337 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7338 (x_set_scroll_bar_width, x_figure_window_size):
7339 Check for integer overflow.
7340 (x_set_alpha): Do not assume XINT fits in int.
7341
7342 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7343 This is for the members text_lines, text_cols, total_lines, total_cols,
7344 where the system imposes an 'int' limit.
7345
7346 * fringe.c (Fdefine_fringe_bitmap):
7347 Don't update size until alloc works.
7348
7349 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7350 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7351
7352 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7353 Check for size-calculation overflow.
7354 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7355 do, as we prefer signed integers.
7356 (id_to_widget.max_size, id_to_widget.used)
7357 (xg_store_widget_in_map, xg_remove_widget_from_map)
7358 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7359 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7360 Use and return ptrdiff_t, not int.
7361 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7362 * gtkutil.h: Change prototypes to match the above.
7363
7364 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7365 are duplicate now that they've been promoted to lisp.h.
7366 (x_allocate_bitmap_record, x_alloc_image_color)
7367 (make_image_cache, cache_image, xpm_load):
7368 Don't update size until alloc is done.
7369 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7370 (x_detect_edges):
7371 Check for size calculation overflow.
7372 (ct_colors_allocated_max): New constant.
7373 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7374 overflow.
7375
7376 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7377 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7378 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7379 Use ptrdiff_t, not int, to count maps.
7380 (read_char_minibuf_menu_prompt): Check for overflow in size
7381 calculations. Don't update size until allocation succeeds.
7382 Redo calculations to avoid overflow.
7383 * keyboard.h: Change prototypes to match the above.
7384
7385 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7386 to count maps.
7387 (current_minor_maps): Check for size calculation overflow.
7388 * keymap.h: Change prototypes to match the above.
7389
7390 * lread.c (read1, init_obarray): Don't update size until alloc done.
7391
7392 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7393 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7394
7395 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7396 Now ptrdiff_t, not int.
7397 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7398 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7399
7400 * process.c (Fnetwork_interface_list): Check for overflow
7401 in size calculation.
7402
7403 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7404
7405 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7406 overflow. Don't bother calling xmalloc when xrealloc will do.
7407
7408 * search.c (Freplace_match): Check for size calculation overflow.
7409 (Fset_match_data): Don't assume list lengths fit in 'int'.
7410
7411 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7412 for command line length. Do not attempt to address one before the
7413 beginning of an array, as that's not portable.
7414
7415 * term.c (max_frame_lines): Remove; unused.
7416 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7417 not int.
7418 (encode_terminal_code, calculate_costs): Check for size
7419 calculation overflow.
7420 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7421 table lengths and related sizes. Don't update size until alloc
7422 done. Redo calculations to avoid overflow.
7423 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7424
7425 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7426 subtracting pointers.
7427 (gobble_line): Check for overflow more carefully. Don't update size
7428 until alloc done.
7429
7430 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7431 Don't update size until alloc done.
7432 Redo size calculations to avoid overflow.
7433 Check for size calculation overflow.
7434 (main) [DEBUG]: Fix typo in invoking tparam1.
7435
7436 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7437 Use ptrdiff_t, not int, for sizes.
7438 (store_mode_line_noprop_char): Don't update size until alloc done.
7439
7440 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7441 Use ptrdiff_t, not int, for sizes.
7442 (Finternal_make_lisp_face, cache_face):
7443 Check for size calculation overflow.
7444 (cache_face): Treat size calculation overflows as if they were
7445 memory exhaustion (the usual treatment), rather than aborting.
7446
7447 * xfns.c (x_encode_text, x_set_name_internal)
7448 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7449 sizes, since they can exceed INT_MAX in size. Check for size
7450 calculation overflow.
7451
7452 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7453 (xg_select): Check for size calculation overflow.
7454 Don't update size until alloc done.
7455
7456 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7457 as sprintf is limited to int lengths.
7458
7459 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7460 (X_LONG_MIN): New macros.
7461 Use them to make the following changes clearer.
7462 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7463 This change doesn't affect the value now, but it may help remind
7464 future maintainers not to raise the value too much later.
7465 (SELECTION_QUANTUM): Remove, replacing with ...
7466 (selection_quantum): ... new function, which avoids overflow.
7467 All uses changed.
7468 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7469 assumption that selection length fits in 'int'.
7470 (x_reply_selection_request, x_handle_selection_request)
7471 (x_get_window_property, receive_incremental_selection)
7472 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7473 (lisp_data_to_selection_data, clean_local_selection_data):
7474 Use ptrdiff_t, not int, to record length of selection.
7475 (x_reply_selection_request, x_get_window_property)
7476 (receive_incremental_selection, x_property_data_to_lisp):
7477 Redo calculations to avoid overflow.
7478 (x_reply_selection_request): When sending hint, ceiling it at
7479 X_LONG_MAX rather than relying on wraparound overflow to send
7480 something.
7481 (x_get_window_property, receive_incremental_selection)
7482 (lisp_data_to_selection_data, x_property_data_to_lisp):
7483 Check for size-calculation overflow.
7484 (x_get_window_property, receive_incremental_selection)
7485 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7486 Don't store size until memory allocation succeeds.
7487 (x_get_window_property): Plug memory leak on memory exhaustion.
7488 Don't double-block input; malloc is safe here. Don't assume 2**34
7489 - 4 fits in unsigned long. Add an xassert to check
7490 XGetWindowProperty overflow. Be more careful about overflow
7491 calculations, and distinguish size from memory overflow better.
7492 (receive_incremental_selection): When tracing, don't assume
7493 unsigned int is less than INT_MAX.
7494 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7495 harmful) conversions of unsigned short to int.
7496 (lisp_data_to_selection_data): Don't assume that integers
7497 in the range -65535 through -1 fit in an X unsigned short.
7498 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7499 result parameters unless successful. Rely on cons_to_unsigned
7500 to report problems with elements; the old code wasn't right anyway.
7501 (x_check_property_data): Check for int overflow; we cannot use
7502 a wider type due to X limits.
7503 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7504
7505 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7506
7507 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7508 (x_term_init): Check for size calculation overflow.
7509 (x_color_cells): Don't store size until memory allocation succeeds.
7510 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7511 Don't assume alloca size is less than MAX_ALLOCA.
7512 (x_term_init): Don't assume length fits in int (sprintf is limited
7513 to int size).
7514
7515 Use ptrdiff_t for composition IDs.
7516 * character.c (lisp_string_width):
7517 * composite.c (composition_table_size, n_compositions)
7518 (get_composition_id, composition_gstring_from_id):
7519 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7520 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7521 * window.c (Frecenter):
7522 Use ptrdiff_t, not int, for composition IDs.
7523 * composite.c (get_composition_id): Check for integer overflow.
7524 * composite.h: Adjust prototypes to match the above changes.
7525
7526 Use ptrdiff_t for hash table indexes.
7527 * category.c (hash_get_category_set):
7528 * ccl.c (ccl_driver):
7529 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7530 * coding.c (coding_system_charset_list, detect_coding_system):
7531 * coding.h (struct coding_system.id):
7532 * composite.c (get_composition_id, gstring_lookup_cache):
7533 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7534 * image.c (xpm_get_color_table_h):
7535 * lisp.h (hash_lookup, hash_put):
7536 * minibuf.c (Ftest_completion):
7537 Use ptrdiff_t for hash table indexes, not int (which is too
7538 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7539 32-bit --with-wide-int hosts).
7540
7541 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7542 Add a FIXME comment about memory leaks.
7543 (syms_of_charset): Don't assume xmalloc returns.
7544
7545 Don't assume that stated character widths fit in int.
7546 * character.c (Fchar_width, c_string_width, lisp_string_width):
7547 * character.h (CHAR_WIDTH):
7548 * indent.c (MULTIBYTE_BYTES_WIDTH):
7549 Use sanitize_char_width to avoid undefined and/or bad behavior
7550 with outlandish widths.
7551 * character.h (sanitize_tab_width): Rename from sanitize_width,
7552 now that we have two such functions. All uses changed.
7553 (sanitize_char_width): New inline function.
7554
7555 Don't assume that tab-width fits in int.
7556 * character.h (sanitize_width): New inline function.
7557 (SANE_TAB_WIDTH): New macro.
7558 (ASCII_CHAR_WIDTH): Use it.
7559 * indent.c (sane_tab_width): Remove. All uses replaced by
7560 SANE_TAB_WIDTH (current_buffer).
7561 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7562
7563 * fileio.c: Integer overflow issues with file modes.
7564 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7565
7566 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7567 Remove unreachable code.
7568 (read_hex, load_charset_map_from_file): Check for integer overflow.
7569
7570 * xterm.c: Don't go over XClientMessageEvent limit.
7571 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7572 (x_send_scroll_bar_event): Likewise. Check that the size does not
7573 exceed limits imposed by XClientMessageEvent, as well as the usual
7574 ptrdiff_t and size_t limits.
7575
7576 * keyboard.c: Overflow, signedness and related fixes.
7577 (make_lispy_movement): Use same integer type in forward decl
7578 that is used in the definition.
7579 (read_key_sequence, keyremap_step):
7580 Change bufsize argument back to int, undoing my 2011-03-30 change.
7581 We prefer signed types, and int is wide enough here.
7582 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7583 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7584 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7585 length, not size_t. Use ptrdiff_t for index, not int.
7586 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7587 possibility of integer overflow.
7588
7589 Overflow, signedness and related fixes for images.
7590
7591 * dispextern.h (struct it.stack[0].u.image.image_id)
7592 (struct_it.image_id, struct image.id, struct image_cache.size)
7593 (struct image_cache.used, struct image_cache.ref_count):
7594 * gtkutil.c (update_frame_tool_bar):
7595 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7596 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7597 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7598 * nsmenu.m (update_frame_tool_bar):
7599 * xdisp.c (calc_pixel_width_or_height):
7600 * xfns.c (image_cache_refcount):
7601 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7602 on typical 64-bit hosts.
7603
7604 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7605 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7606 Omit unnecessary casts to int.
7607 (parse_image_spec): Check that integers fall into 'int' range
7608 when the callers expect that.
7609 (image_ascent): Redo ascent calculation to avoid int overflow.
7610 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7611 (lookup_image): Remove unnecessary tests.
7612 (xbm_image_p): Locals are now of int, not EMACS_INT,
7613 since parse_image_check makes sure they fit into int.
7614 (png_load, gif_load, svg_load_image):
7615 Prefer int to unsigned where either will do.
7616 (tiff_handler): New function, combining the cores of the
7617 old tiff_error_handler and tiff_warning_handler.
7618 This function is rewritten to use vsnprintf and thereby avoid
7619 stack buffer overflows. It uses only the features of vsnprintf
7620 that are common to both POSIX and native Microsoft.
7621 (tiff_error_handler, tiff_warning_handler): Use it.
7622 (tiff_load, gif_load, imagemagick_load_image):
7623 Don't assume :index value fits in 'int'.
7624 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7625 (imagemagick_load_image): Check that crop parameters fit into
7626 the integer types that MagickCropImage accepts. Don't assume
7627 Vimagemagick_render_type has a nonnegative value. Don't assume
7628 size_t fits in 'long'.
7629 (gs_load): Use printmax_t to print the widest integers possible.
7630 Check for integer overflow when computing image height and width.
7631
7632 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7633
7634 * xdisp.c (redisplay_window): Don't force window start if point
7635 will be invisible in the resulting window. (Bug#9324)
7636
7637 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7638
7639 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7640 the display spec is of the form `(space ...)'.
7641 (handle_display_spec): Return the value returned by
7642 handle_single_display_spec, not just 1 or zero.
7643 (handle_single_display_spec): If the display spec is of the form
7644 `(space ...)', and specifies display in the text area, return 2
7645 rather than 1.
7646 (try_cursor_movement): Check for the need to scroll more
7647 accurately, and prefer exact match for point under bidi.
7648 Don't advance `row' beyond the last row of the window.
7649
7650 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7651 into disp_prop; all users changed.
7652
7653 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7654 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7655 for the text covered by the display property.
7656
7657 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7658
7659 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7660 Change return value to nil.
7661 (Frecord_buffer): Delete unused function.
7662
7663 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7664
7665 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7666 buffers, return left-to-right.
7667 (set_cursor_from_row): Consider candidate row a win if its glyph
7668 represents a newline and point is on that newline. Fixes cursor
7669 positioning on the newline at EOL of R2L text within L2R
7670 paragraph, and vice versa.
7671 (try_cursor_movement): Check continued rows, in addition to
7672 continuation rows. Fixes unwarranted scroll when point enters a
7673 continued line of R2L text within an L2R paragraph, or vice versa.
7674 (cursor_row_p): Consider the case of point being equal to
7675 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7676 from the end of a short line to the beginning of a continued line
7677 of R2L text within L2R paragraph.
7678 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7679 composed characters.
7680
7681 * bidi.c (bidi_check_type): Use xassert.
7682 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7683 members.
7684
7685 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7686
7687 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7688 a character.
7689
7690 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7691
7692 * nsfont.m (ns_otf_to_script): Fix typo.
7693
7694 2011-08-22 Kenichi Handa <handa@m17n.org>
7695
7696 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7697 extra slot even if the purpose is char-code-property-table.
7698
7699 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7700
7701 * xdisp.c (redisplay_window): When computing centering_position,
7702 account for the height of the header line. (Bug#8874)
7703
7704 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7705 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7706 candidate is selected by the mouse, and that candidate has a
7707 composed character under the mouse.
7708
7709 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7710 coordinates reported by pos-visible-in-window-p for a composed
7711 character in column zero.
7712
7713 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7714
7715 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7716
7717 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7718
7719 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7720 consider it a hit if to_charpos is anywhere in the range of the
7721 composed buffer positions.
7722
7723 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7724
7725 * image.c (gif_load): Don't assume that each subimage has the same
7726 dimensions as the base image. Handle disposal method that is
7727 "undefined" by the gif spec (Bug#9335).
7728
7729 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7730
7731 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7732 (Fcondition_case): Document `debug' symbol in error handler.
7733
7734 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7735
7736 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7737 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7738 from an Org mode buffer to a Speedbar frame.
7739
7740 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7741 a composition, take its buffer position from IT->cmp_it.charpos.
7742 Fixes cursor positioning at the beginning of a line that begins
7743 with a composed character.
7744
7745 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7746
7747 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7748 character bidirectional type, use STRONG_L instead. Fixes crashes
7749 in a buffer produced by `describe-categories'.
7750
7751 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7752 members before the level stack, so they would be saved and
7753 restored when copying iterator state. Fixes incorrect reordering
7754 around TABs covered by display properties.
7755
7756 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7757
7758 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7759
7760 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7761
7762 * eval.c (internal_condition_case, internal_condition_case_1)
7763 (internal_condition_case_2, internal_condition_case_n):
7764 Remove unnecessary aborts (Bug#9081).
7765
7766 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7767
7768 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7769 has no `load' handler, try opening the file locally. (Bug#9311)
7770
7771 2011-08-16 Ken Brown <kbrown@cornell.edu>
7772
7773 * gmalloc.c: Expand comment.
7774
7775 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7776
7777 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7778 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7779
7780 2011-08-16 Ken Brown <kbrown@cornell.edu>
7781
7782 Fix memory allocation problems in Cygwin build (Bug#9273).
7783
7784 * unexcw.c ( __malloc_initialized): Declare external variable.
7785 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7786
7787 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7788 New variables.
7789 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7790 dumped emacs.
7791 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7792 in the static heap.
7793 [CYGWIN] (special_realloc): New function.
7794 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7795 requests to realloc storage in the static heap.
7796
7797 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7798
7799 * bidi.c (bidi_initialize): Remove unused local.
7800
7801 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7802
7803 * bidimirror.h:
7804 * biditype.h: Remove file.
7805 * makefile.w32-in ($(BLD)/bidi.$(O)):
7806 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7807
7808 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7809
7810 * chartab.c: Improve commentary for the uniprop_table API.
7811
7812 * bidi.c (bidi_paragraph_init): Support zero value of
7813 bidi_ignore_explicit_marks_for_paragraph_level.
7814 (bidi_initialize): Use uniprop_table instead of including
7815 biditype.h and bidimirror.h.
7816
7817 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7818 coordinates of the iterator when restoring from ppos_it.
7819 (Bug#9296)
7820
7821 2011-08-14 Kenichi Handa <handa@m17n.org>
7822
7823 * process.c (create_process): Call setup_process_coding_systems
7824 after the pid of the process is set to -1 (Bug#8162).
7825
7826 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7827
7828 * xdisp.c (move_it_in_display_line_to): Don't invoke
7829 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7830 ppos_it. Fixes vertical cursor motion when line beginning is
7831 covered by an image. (Bug#9296)
7832
7833 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7834
7835 * nsterm.h (ns_run_ascript): Declare.
7836 (NSAPP_DATA2_RUNASSCRIPT): Define.
7837
7838 * nsfns.m (as_script, as_result, as_status): New static variables.
7839 (ns_run_ascript): New function.
7840 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7841 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7842 the event loop. Get status from as_status (Bug#7276).
7843
7844 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7845 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7846 the event loop (Bug#7276).
7847
7848 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7849
7850 * gnutls.c (QCgnutls_bootprop_priority)
7851 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7852 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7853 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7854 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7855 (QCgnutls_bootprop_verify_hostname_error)
7856 (QCgnutls_bootprop_callbacks_verify): Rename from
7857 Qgnutls_bootprop_..., all uses changed.
7858
7859 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7860 uses changed.
7861
7862 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7863
7864 * xfaces.c (Qframe_set_background_mode): Now static.
7865 * dispextern.h (Qframe_set_background_mode): Remove decl.
7866
7867 * process.c (Fnetwork_interface_info): Declare local only if needed.
7868
7869 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7870
7871 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7872 (Fnetwork_interface_list): Allocate in increments of bytes instead
7873 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7874 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7875 sockaddr.
7876 (struct ifflag_def): notrailers is smart on OSX.
7877 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7878 Get hardware address with getifaddrs if available.
7879
7880 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7881
7882 * xdisp.c (iterate_out_of_display_property): xassert that
7883 IT->position is set to within IT->object's boundaries. Break from
7884 the loop as soon as EOB is reached; avoids infloops in redisplay
7885 when IT->position is set up wrongly due to some bug.
7886 Set IT->current to match the bidi iterator unconditionally.
7887 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7888 entry. Force push_it to save on the stack the current
7889 buffer/string position, to be restored by pop_it. Fix flags in
7890 the iterator structure wrt the object coming from a display
7891 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7892 properties. (Bug#9284)
7893
7894 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7895
7896 * fontset.c (fontset_get_font_group): Add proper type checks.
7897 (Bug#9172)
7898
7899 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7900
7901 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7902 and LC_VERSION_MIN_MACOSX.
7903 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7904 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7905
7906 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7907
7908 * xdisp.c (forward_to_next_line_start): Allow to use the
7909 no-display-properties-and-no-overlays under bidi display.
7910 Set disp_pos in the bidi iterator to avoid searches for display
7911 properties and overlays.
7912
7913 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7914
7915 * editfns.c (Fset_time_zone_rule): Document relationship with the
7916 setenv function.
7917
7918 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7919 the font entity extracted from the cache (Bug#8109).
7920
7921 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7922
7923 * composite.c (autocmp_chars): Don't reset point. That is done by
7924 restore_point_unwind (Bug#5984).
7925
7926 2011-08-07 Juri Linkov <juri@jurta.org>
7927
7928 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7929 to show the arg `TIME' instead of `TIMEVAL'.
7930
7931 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7932
7933 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7934 display property strides EOL and includes a newline, as in
7935 longlines-mode. (Bug#9254)
7936 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7937 word-wrap under bidirectional display. (Bug#9224)
7938
7939 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7940 is non-zero, even if the data buffer is NULL. Fixes a crash in
7941 vertical-motion with longlines-mode. (Bug#9254)
7942
7943 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7944
7945 * bidi.c <bidi_cache_total_alloc>: Now static.
7946 (bidi_initialize): Initialize bidi_cache_total_alloc.
7947
7948 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7949 cache. (Bug#9221)
7950
7951 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7952 amount allocated this far in `bidi_cache_total_alloc'.
7953 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7954 non-zero, only free the data buffer without restoring the cache
7955 contents. All callers changed.
7956
7957 * dispextern.h (bidi_unshelve_cache): Update prototype.
7958
7959 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7960 (move_it_in_display_line, move_it_to)
7961 (move_it_vertically_backward, move_it_by_lines): Replace the call
7962 to xfree to an equivalent call to bidi_unshelve_cache.
7963 (move_it_in_display_line_to): Fix logic of returning
7964 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7965
7966 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7967
7968 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7969 came from a string character with a `cursor' property. (Bug#9229)
7970
7971 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7972
7973 * Makefile.in (LIB_PTHREAD): New variable.
7974 (LIBES): Add LIB_PTHREAD (Bug#9216).
7975
7976 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7977 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7978
7979 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7980
7981 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7982
7983 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7984
7985 * xterm.c (x_find_topmost_parent): New function.
7986 (x_set_frame_alpha): Find topmost parent window with
7987 x_find_topmost_parent and set the property there also (bug#9181).
7988 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7989
7990 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7991
7992 * callproc.c (Fcall_process): Avoid vfork clobbering
7993 the local vars buffer, coding_systems, current_dir.
7994
7995 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7996
7997 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7998
7999 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8000
8001 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8002 so that it is not optimized away.
8003
8004 * xdisp.c (compute_display_string_pos): Remove unused local.
8005
8006 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8007
8008 Fix slow cursor motion and scrolling in large buffers with
8009 selective display, like Org Mode buffers. (Bug#9218)
8010
8011 * dispextern.h (struct bidi_it): New member disp_prop_p.
8012
8013 * xdisp.c: Remove one-slot cache of display string positions.
8014 (compute_display_string_pos): Accept an additional argument
8015 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8016 for a display string or property. If found, set DISP_PROP_P
8017 non-zero.
8018
8019 * bidi.c (bidi_fetch_char): Accept an additional argument
8020 DISP_PROP_P, and pass it to compute_display_string_pos.
8021 Only handle text covered by a display string if DISP_PROP_P is returned
8022 non-zero. All callers of bidi_fetch_char changed.
8023
8024 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8025
8026 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8027
8028 2010-12-03 Don March <don@ohspite.net>
8029
8030 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8031 last character M-[char] is translated to ESC [char] (bug#7541).
8032
8033 2011-08-02 Kenichi Handa <handa@m17n.org>
8034
8035 * lisp.h (uniprop_table): Extern it.
8036
8037 * chartab.c (uniprop_table): Make it non-static.
8038
8039 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8040
8041 * xdisp.c (forward_to_next_line_start): Accept additional argument
8042 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8043 on the newline.
8044 (reseat_at_next_visible_line_start): Use the bidi iterator state
8045 returned by forward_to_next_line_start to restore the state of
8046 it->bidi_it after backing up to previous newline. (Bug#9212)
8047
8048 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8049
8050 * regex.c (re_comp): Protoize.
8051 (re_exec): Fix return type.
8052 (regexec): Fix type of `ret'. (Bug#9203)
8053
8054 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8055
8056 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8057 This is needed if max-image-size is a floating-point number.
8058
8059 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8060
8061 * print.c (print_object): Print empty symbol as ##.
8062
8063 * lread.c (read1): Read ## as empty symbol.
8064
8065 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8066
8067 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8068 setting frame foreground color (Bug#9175).
8069 (x_set_background_color): Likewise.
8070
8071 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8072 contents (Bug#9176).
8073 (EmacsTooltip -init): Remove bezels and add shadows to
8074 tooltip windows.
8075
8076 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8077 or scroll bar (Bug#8470).
8078
8079 * nsfont.m (nsfont_open): Remove assignment to voffset and
8080 unnecessary vars hshink, expand, hd, full_height, min_height.
8081 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8082
8083 * nsterm.h (nsfont_info): Remove voffset field.
8084
8085 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8086
8087 Implement strike-through and overline on NextStep (Bug#8863).
8088
8089 * nsfont.m (nsfont_open): Use underline position provided by font,
8090 instead of hard-coded value of 2.
8091 (nsfont_draw): Call ns_draw_text_decoration instead.
8092
8093 * nsterm.h: Add declaration for ns_draw_text_decoration.
8094
8095 * nsterm.m (ns_draw_text_decoration): New function for drawing
8096 underline, overline, and strike-through.
8097 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8098 ns_draw_text_decoration. Change treatment of cursor drawing to
8099 accommodate underlining, etc.
8100
8101 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8102
8103 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8104 default.
8105
8106 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8107
8108 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8109 Without this fix, if a signal arrives just after memory fills up,
8110 'malloc' might be invoked reentrantly.
8111
8112 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8113 In other words, assume that every image size is allowed, on non-X
8114 hosts. This assumption is probably wrong, but it lets Emacs compile.
8115
8116 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8117
8118 * regex.c (re_iswctype): Convert return values to boolean.
8119
8120 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8121
8122 * xdisp.c (compute_display_string_pos): Don't use cached display
8123 string position if the buffer had its restriction changed.
8124 (Bug#9184)
8125
8126 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8127
8128 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8129
8130 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8131
8132 Integer signedness and overflow and related fixes. (Bug#9079)
8133
8134 * bidi.c: Integer size and overflow fixes.
8135 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8136 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8137 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8138 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8139 (bidi_find_other_level_edge):
8140 Use ptrdiff_t instead of EMACS_INT where either will do.
8141 This works better on 32-bit hosts configured --with-wide-int.
8142 (bidi_cache_ensure_space): Check for size-calculation overflow.
8143 Use % rather than repeated addition, for better worst-case speed.
8144 Don't set bidi_cache_size until after xrealloc returns, because it
8145 might not return.
8146 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8147 (bidi_cache_ensure_space): Also check that the bidi cache size
8148 does not exceed that of the largest Lisp string or buffer. See Eli
8149 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8150
8151 * alloc.c (__malloc_size_t): Remove.
8152 All uses replaced by size_t. See Andreas Schwab's note
8153 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8154
8155 * image.c: Improve checking for integer overflow.
8156 (check_image_size): Assume that f is nonnull, since
8157 it is always nonnull in practice. This is one less thing to
8158 worry about when checking for integer overflow later.
8159 (x_check_image_size): New function, which checks for integer
8160 overflow issues inside X.
8161 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8162 This removes the need for a memory_full check.
8163 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8164 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8165 (xbm_read_bitmap_data): Change locals back to 'int', since
8166 their values must fit in 'int'.
8167 (xpm_load_image, png_load, tiff_load):
8168 Invoke x_create_x_image_and_pixmap earlier,
8169 to avoid much needless work if the image is too large.
8170 (tiff_load): Treat overly large images as if
8171 x_create_x_image_and_pixmap failed, not as malloc failures.
8172 (gs_load): Use x_check_image_size.
8173
8174 * gtkutil.c: Omit integer casts.
8175 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8176 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8177
8178 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8179
8180 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8181 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8182 would wrongly return t on a 64-bit host.
8183
8184 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8185 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8186 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8187 and therefore cause GCC to emit a bogus diagnostic in some cases.
8188
8189 * image.c: Integer signedness and overflow and related fixes.
8190 This is not an exhaustive set of fixes, but it's time to
8191 record what I've got.
8192 (lookup_pixel_color, check_image_size): Remove redundant decls.
8193 (check_image_size): Don't assume that arbitrary EMACS_INT values
8194 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8195 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8196 (tiff_load, imagemagick_load_image):
8197 Check for overflow in size calculations.
8198 (x_create_x_image_and_pixmap): Remove unnecessary test for
8199 xmalloc returning NULL; that can't happen.
8200 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8201 (xpm_color_bucket): Use better integer hashing function.
8202 (xpm_cache_color): Don't possibly over-allocate memory.
8203 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8204 (gif_memory_source):
8205 Use ptrdiff_t, not int or size_t, to record sizes.
8206 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8207 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8208 either works, as we prefer signed integers.
8209 (tiff_read_from_memory, tiff_write_from_memory):
8210 Return tsize_t, not size_t, since that's what the TIFF API wants.
8211 (tiff_read_from_memory): Don't fail simply because the read would
8212 go past EOF; instead, return a short read.
8213 (tiff_load): Omit no-longer-needed casts.
8214 (Fimagemagick_types): Don't assume size fits into 'int'.
8215
8216 Improve hashing quality when configured --with-wide-int.
8217 * fns.c (hash_string): New function, taken from sxhash_string.
8218 Do not discard information about ASCII character case; this
8219 discarding is no longer needed.
8220 (sxhash-string): Use it. Change sig to match it. Caller changed.
8221 * lisp.h: Declare it.
8222 * lread.c (hash_string): Remove, since we now use fns.c's version.
8223 The fns.c version returns a wider integer if --with-wide-int is
8224 specified, so this should help the quality of the hashing a bit.
8225
8226 * emacs.c: Integer overflow minor fix.
8227 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8228 Define only if GNU_LINUX.
8229 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8230
8231 * dispnew.c: Integer signedness and overflow fixes.
8232 Remove unnecessary forward decls, that were a maintenance hassle.
8233 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8234 All uses changed.
8235 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8236 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8237 (prepare_desired_row, line_draw_cost):
8238 Use int, not unsigned, where either works.
8239 (save_current_matrix, restore_current_matrix):
8240 Use ptrdiff_t, not size_t, where either works.
8241 (init_display): Check for overflow more accurately, and without
8242 relying on undefined behavior.
8243
8244 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8245 Remove, replacing with the new symbols in lisp.h. All uses changed.
8246 * fileio.c (make_temp_name):
8247 * filelock.c (lock_file_1, lock_file):
8248 * xdisp.c (message_dolog):
8249 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8250 Use pMd etc. instead.
8251 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8252 replacing the pWIDE etc. symbols removed from editfns.c.
8253
8254 * keyboard.h (num_input_events): Now uintmax_t.
8255 This is (very slightly) less likely to mess up due to wraparound.
8256 All uses changed.
8257
8258 * buffer.c: Integer signedness fixes.
8259 (alloc_buffer_text, enlarge_buffer_text):
8260 Use ptrdiff_t rather than size_t when either will do, as we prefer
8261 signed integers.
8262
8263 * alloc.c: Integer signedness and overflow fixes.
8264 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8265 (__malloc_size_t): Default to size_t, not to int.
8266 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8267 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8268 Prefer ptrdiff_t to size_t when either would do, as we prefer
8269 signed integers.
8270 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8271 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8272 Now const. Initialize with values that are in range even if char
8273 is signed.
8274 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8275 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8276 These functions do the right thing with sizes > 2**32.
8277 (check_depth): Now ptrdiff_t, not int.
8278 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8279 Adjust to new way of storing sizes. Check for size overflow bugs
8280 in rest of code.
8281 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8282 slightly wrong anyway, as it missed one instance of
8283 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8284 (refill_memory_reserve): Omit needless cast to size_t.
8285 (mark_object_loop_halt): Mark as externally visible.
8286
8287 * xselect.c: Integer signedness and overflow fixes.
8288 (Fx_register_dnd_atom, x_handle_dnd_message):
8289 Use ptrdiff_t, not size_t, since we prefer signed.
8290 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8291 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8292 x_dnd_atoms_size and x_dnd_atoms_length.
8293
8294 * doprnt.c: Prefer signed to unsigned when either works.
8295 * eval.c (verror):
8296 * doprnt.c (doprnt):
8297 * lisp.h (doprnt):
8298 * xdisp.c (vmessage):
8299 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8300 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8301 prefer signed arithmetic to avoid comparison confusion.
8302 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8303 but is a bit tricky.
8304
8305 Assume freestanding C89 headers, string.h, stdlib.h.
8306 * data.c, doprnt.c, floatfns.c, print.c:
8307 Include float.h unconditionally.
8308 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8309 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8310 * regex.c: Likewise for stddef.h, string.h.
8311 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8312 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8313 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8314 (STDC_HEADERS): Remove obsolete defines.
8315 * sysdep.c: Include limits.h unconditionally.
8316
8317 Assume support for memcmp, memcpy, memmove, memset.
8318 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8319 * regex.c (memcmp, memcpy):
8320 Remove; we assume C89 now.
8321
8322 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8323 (__malloc_safe_bcopy): Remove; no longer needed.
8324
8325 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8326 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8327 well either way, and we prefer signed to unsigned.
8328
8329 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8330
8331 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8332 closes the connection while we're reading (bug#9182).
8333
8334 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8335
8336 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8337 are specified (Bug#9168).
8338
8339 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8340
8341 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8342 Found by GCC static checking and --with-wide-int on a 32-bit host.
8343
8344 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8345
8346 * xdisp.c (compute_display_string_pos): Fix logic of caching
8347 previous display string position. Initialize cached_prev_pos to
8348 -1. Fixes slow-down at the beginning of a buffer.
8349
8350 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8351
8352 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8353 for attrs[LFACE_FONTSET_INDEX].
8354
8355 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8356
8357 * xml.c (parse_region): Remove unused local
8358 that was recently introduced.
8359
8360 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8361
8362 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8363 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8364
8365 * xdisp.c (move_it_in_display_line_to): Record the best matching
8366 position for TO_CHARPOS while scanning the line, and restore it on
8367 exit if none of the characters scanned was an exact match.
8368 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8369 when exact match is impossible due to invisible text, and the
8370 lines are truncated.
8371
8372 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8373
8374 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8375 for OSX >= 10.7.
8376
8377 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8378
8379 Fix a significant slow-down of cursor motion with C-n, C-p,
8380 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8381 auto-repeat under bidi redisplay in fontified buffers.
8382 * xdisp.c (compute_stop_pos_backwards): New function.
8383 (next_element_from_buffer): Call compute_stop_pos_backwards to
8384 find a suitable prev_stop when we find ourselves before
8385 base_level_stop.
8386 (reseat): Don't look for prev_stop, as that could mean a very long
8387 run.
8388 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8389 <cached_disp_overlay_modiff>: Cache for last found display string
8390 position.
8391 (compute_display_string_pos): Return the cached position if asked
8392 about the same buffer in the same area of character positions, and
8393 the buffer wasn't changed since the time the display string
8394 position was cached.
8395
8396 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8397
8398 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8399 is an integer, which is important for empty lines. (Bug#9149)
8400
8401 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8402
8403 * frame.c (Fmodify_frame_parameters): In tty case, update the
8404 default face if necessary (Bug#4238).
8405
8406 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8407
8408 * editfns.c (Fstring_to_char): No need to explain what a character
8409 is in the docstring (Bug#6576).
8410
8411 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8412
8413 * xml.c (parse_region): Make sure we always return a tree.
8414
8415 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8416
8417 * xml.c (parse_region): If a document contains only comments,
8418 return that, too.
8419
8420 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8421
8422 * xml.c (make_dom): Return comments, too.
8423
8424 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8425
8426 Port to OpenBSD.
8427 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8428 and the surrounding thread.
8429 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8430 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8431 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8432 timer goes off.
8433 * s/openbsd.h (BROKEN_SIGIO): Define.
8434 * unexelf.c (unexec) [__OpenBSD__]:
8435 Don't update the .mdebug section of the Alpha COFF symbol table.
8436
8437 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8438
8439 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8440 (bug#8460).
8441
8442 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8443
8444 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8445 This fixes some race conditions on the permissions of any newly
8446 created file.
8447
8448 * alloc.c (valid_pointer_p): Use pipe, not open.
8449 This fixes some permissions issues when debugging.
8450
8451 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8452 If fchown fails to set both uid and gid, try to set just gid,
8453 as that is sometimes allowed. Adjust the file's mode to eliminate
8454 setuid or setgid bits that are inappropriate if fchown fails.
8455
8456 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8457
8458 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8459 to compare Lisp_Objects.
8460 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8461 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8462 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8463
8464 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8465
8466 * lread.c (read_integer): Unread even EOF character.
8467 (read1): Likewise. Properly record start position of symbol.
8468
8469 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8470 symbol character follows.
8471
8472 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8473
8474 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8475 This works around a problem with the previous change to Fcopy_file.
8476 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8477 and without this change, GCC might complain about discarding
8478 fchown's return value.
8479
8480 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8481
8482 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8483
8484 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8485
8486 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8487
8488 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8489
8490 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8491 it's used from the C level.
8492
8493 * process.c: Use the same condition for POLL_FOR_INPUT in both
8494 keyboard.c and process.c (bug#1858).
8495
8496 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8497
8498 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8499 (Fgnutls_boot): Use it.
8500
8501 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8502
8503 * doc.c (Fsubstitute_command_keys): Revert last change.
8504
8505 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8506
8507 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8508 quotes the next character, and doesn't affect other longer
8509 sequences (bug#8935).
8510
8511 * lread.c (syms_of_lread): Clarify that is isn't only
8512 `eval-buffer' and `eval-defun' that's affected by
8513 `lexical-binding' (bug#8460).
8514
8515 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8516
8517 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8518 bidi redisplay when a line includes both an image and is truncated.
8519
8520 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8521
8522 Fix minor problems found by static checking.
8523 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8524 (elsz): Now a signed constant, not a size_t var. We prefer signed
8525 types to unsigned, to avoid integer comparison confusion. Without
8526 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8527 "cannot optimize loop, the loop counter may overflow", a symptom
8528 of the confusion.
8529 * indent.c (Fvertical_motion): Mark locals as initialized.
8530 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8531
8532 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8533
8534 * search.c (Fre_search_backward): Mention `case-fold-search' in
8535 all the re_search_* functions (bug#8138).
8536
8537 * keyboard.c (Fopen_dribble_file): Document when the file is
8538 closed (bug#8056).
8539
8540 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8541
8542 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8543 bidi_cache_idx.
8544
8545 Support bidi reordering of display and overlay strings.
8546 * xdisp.c (compute_display_string_pos)
8547 (compute_display_string_end): Accept additional argument STRING.
8548 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8549 (reseat_to_string): Initialize bidi_it->string.s and
8550 bidi_it->string.schars.
8551 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8552 NULL (avoids a crash in bidi_paragraph_init).
8553 Initialize itb.string.lstring.
8554 (init_iterator): Call bidi_init_it only of a valid
8555 buffer position was specified. Initialize paragraph_embedding to
8556 L2R.
8557 (reseat_to_string): Initialize the bidi iterator.
8558 (display_string): If we need to ignore text properties of
8559 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8560 original value of -1 will not work with bidi.)
8561 (compute_display_string_pos): First arg is now struct
8562 `text_pos *'; all callers changed. Support display properties on
8563 Lisp strings.
8564 (compute_display_string_end): Support display properties on Lisp
8565 strings.
8566 (init_iterator, reseat_1, reseat_to_string): Initialize the
8567 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8568 when iterating on a string not from display properties).
8569 (compute_display_string_pos, compute_display_string_end):
8570 Fix calculation of the object to scan. Fixes an error when using
8571 arrow keys.
8572 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8573 base_level_stop; instead, set base_level_stop to BEGV.
8574 Fixes crashes in vertical-motion.
8575 (next_element_from_buffer): Improve commentary for when
8576 the iterator is before prev_stop.
8577 (init_iterator): Initialize bidi_p from the default value of
8578 bidi-display-reordering, not from buffer-local value. Use the
8579 buffer-local value only if initializing for buffer iteration.
8580 (handle_invisible_prop): Support invisible properties on strings
8581 that are being bidi-reordered.
8582 (set_iterator_to_next): Support bidi reordering of C strings and
8583 Lisp strings.
8584 (next_element_from_string): Support bidi reordering of Lisp
8585 strings.
8586 (handle_stop_backwards): Support Lisp strings as well.
8587 (display_string): Support display of R2L glyph rows.
8588 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8589 (init_iterator): Don't initialize it->bidi_p for strings
8590 here.
8591 (reseat_to_string): Initialize it->bidi_p for strings here.
8592 (next_element_from_string, next_element_from_c_string)
8593 (next_element_from_buffer): Add xassert's for correspondence
8594 between IT's object being iterated and it->bidi_it.string
8595 structure.
8596 (face_before_or_after_it_pos): Support bidi iteration.
8597 (next_element_from_c_string): Handle the case of the first string
8598 character that is not the first one in the visual order.
8599 (get_visually_first_element): New function, refactored from common
8600 parts of next_element_from_buffer, next_element_from_string, and
8601 next_element_from_c_string.
8602 (tool_bar_lines_needed, redisplay_tool_bar)
8603 (display_menu_bar): Force left-to-right direction. Add a FIXME
8604 comment for making that be controlled by a user option.
8605 (push_it, pop_it): Save and restore the state of the
8606 bidi iterator. Save and restore the bidi_p flag.
8607 (pop_it): Iterate out of display property for string iteration as
8608 well.
8609 (iterate_out_of_display_property): Support iteration over strings.
8610 (handle_single_display_spec): Set up it->bidi_it for iteration
8611 over a display string, and call bidi_init_it.
8612 (handle_single_display_spec, next_overlay_string)
8613 (get_overlay_strings_1, push_display_prop): Set up the bidi
8614 iterator for displaying display or overlay strings.
8615 (forward_to_next_line_start): Don't use the shortcut if
8616 bidi-iterating.
8617 (back_to_previous_visible_line_start): If handle_display_prop
8618 pushed the iterator stack, restore the internal state of the bidi
8619 iterator by calling bidi_pop_it same number of times.
8620 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8621 and we are bidi-iterating, don't decrement the iterator position;
8622 instead, set the first_elt flag in the bidi iterator, to produce
8623 the same effect.
8624 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8625 (push_display_prop): xassert that we are iterating a buffer.
8626 (push_it, pop_it): Save and restore paragraph_embedding member.
8627 (handle_single_display_spec, next_overlay_string)
8628 (get_overlay_strings_1, reseat_1, reseat_to_string)
8629 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8630 correctly. Don't assume unibyte strings are not bidi-reordered.
8631 (compute_display_string_pos)
8632 (compute_display_string_end): Fix handling the case of C string.
8633 (push_it, pop_it): Save and restore from_disp_prop_p.
8634 (handle_single_display_spec, push_display_prop): Set the
8635 from_disp_prop_p flag.
8636 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8637 (pop_it): Call iterate_out_of_display_property only if we are
8638 popping after iteration over a string that came from a display
8639 property. Fix a typo in popping stretch info. Add an assertion
8640 for verifying that the iterator position is in sync with the bidi
8641 iterator.
8642 (handle_single_display_spec, get_overlay_strings_1)
8643 (push_display_prop): Fix initialization of paragraph direction for
8644 string when that of the parent object is not yet determined.
8645 (reseat_1): Call bidi_init_it to resync the bidi
8646 iterator with IT's position. (Bug#7616)
8647 (find_row_edges): If ROW->start.pos gives position
8648 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8649 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8650 Reset the from_disp_prop_p flag.
8651 (SAVE_IT, RESTORE_IT): New macros.
8652 (pos_visible_p, face_before_or_after_it_pos)
8653 (back_to_previous_visible_line_start)
8654 (move_it_in_display_line_to, move_it_in_display_line)
8655 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8656 (try_scrolling, redisplay_window, display_line): Use them when
8657 saving a temporary copy of the iterator and restoring it back.
8658 (back_to_previous_visible_line_start, reseat_1)
8659 (init_iterator): Empty the bidi cache "stack".
8660 (move_it_in_display_line_to): If iterator ended up at
8661 EOL, but we never saw any buffer positions smaller than
8662 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8663 motion in bidi-reordered lines.
8664 (move_it_in_display_line_to): Record prev_method and prev_pos
8665 immediately before the call to set_iterator_to_next. Fixes cursor
8666 motion in bidi-reordered lines with stretch glyphs and strings
8667 displayed in margins. (Bug#8133) (Bug#8867)
8668 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8669 TO_CHARPOS.
8670 (pos_visible_p): Support positions in bidi-reordered lines.
8671 Save and restore bidi cache.
8672
8673 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8674 (bidi_paragraph_info): Delete unused struct.
8675 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8676 (bidi_cache_start): New variable.
8677 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8678 to zero.
8679 (bidi_cache_fetch_state, bidi_cache_search)
8680 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8681 (bidi_cache_find, bidi_peek_at_next_level)
8682 (bidi_level_of_next_char, bidi_find_other_level_edge)
8683 (bidi_move_to_visually_next): Compare cache index with
8684 bidi_cache_start rather than with zero.
8685 (bidi_fetch_char): Accept new argument STRING; all callers
8686 changed. Support iteration over a string. Support strings with
8687 display properties. Support unibyte strings. Fix the type of
8688 `len' according to what STRING_CHAR_AND_LENGTH expects.
8689 (bidi_paragraph_init, bidi_resolve_explicit_1)
8690 (bidi_resolve_explicit, bidi_resolve_weak)
8691 (bidi_level_of_next_char, bidi_move_to_visually_next):
8692 Support iteration over a string.
8693 (bidi_set_sor_type, bidi_resolve_explicit_1)
8694 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8695 can now be zero (for strings); special values 0 and -1 were
8696 changed to -1 and -2, respectively.
8697 (bidi_char_at_pos): New function.
8698 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8699 Call it instead of FETCH_MULTIBYTE_CHAR.
8700 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8701 initialized to valid values.
8702 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8703 values.
8704 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8705 the test for valid cached positions. Fix the logic for looking up
8706 the sentinel state in the cache. GCPRO the Lisp string we are
8707 iterating.
8708 (bidi_push_it, bidi_pop_it): New functions.
8709 (bidi_initialize): Initialize the bidi cache start stack pointer.
8710 (bidi_cache_ensure_space): New function, refactored from part of
8711 bidi_cache_iterator_state. Don't assume the required size is just
8712 one BIDI_CACHE_CHUNK away.
8713 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8714 (bidi_count_bytes, bidi_char_at_pos): New functions.
8715 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8716 always valid if bidi_cache_idx is valid.
8717 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8718 is valid if it's going to be used.
8719 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8720 (bidi_cache_fetch_state, bidi_cache_search)
8721 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8722 (bidi_cache_iterator_state, bidi_cache_find)
8723 (bidi_find_other_level_edge, bidi_cache_start_stack):
8724 All variables related to cache indices are now EMACS_INT.
8725
8726 * dispextern.h (struct bidi_string_data): New structure.
8727 (struct bidi_it): New member `string'. Make flag members be 1-bit
8728 fields, and put them last in the struct.
8729 (compute_display_string_pos, compute_display_string_end):
8730 Update prototypes.
8731 (bidi_push_it, bidi_pop_it): Add prototypes.
8732 (struct iterator_stack_entry): New members bidi_p,
8733 paragraph_embedding, and from_disp_prop_p.
8734 (struct it): Member bidi_p is now a bit field 1 bit wide.
8735 (bidi_shelve_cache, bidi_unshelve_cache):
8736 Declare prototypes.
8737
8738 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8739 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8740 and vector-like objects.
8741
8742 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8743 cache around display iteration.
8744
8745 * window.c (Fwindow_end, window_scroll_pixel_based)
8746 (displayed_window_lines, Frecenter): Save and restore the bidi
8747 cache around display iteration.
8748
8749 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8750
8751 * editfns.c (Fdelete_region): Clarify the use of the named
8752 parameters (bug#6788).
8753
8754 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8755
8756 * indent.c (Fvertical_motion): Set and restore w->pointm when
8757 saving and restoring the window's buffer (Bug#9006).
8758
8759 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8760
8761 * editfns.c (Fstring_to_char): Clarify just what is returned
8762 (bug#6576). Text by Eli Zaretskii.
8763
8764 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8765
8766 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8767
8768 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8769
8770 * buffer.c (mmap_find): Fix a typo.
8771
8772 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8773
8774 Fix execution of x selection hooks.
8775 * xselect.c (Qx_lost_selection_functions)
8776 (Qx_sent_selection_functions): New vars.
8777 (syms_of_xselect): DEFSYM them.
8778 (x_handle_selection_request): Pass Qx_sent_selection_functions
8779 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8780 (x_handle_selection_clear,x_clear_frame_selections):
8781 Pass Qx_lost_selection_functions rather than
8782 Vx_lost_selection_functions to Frun_hook_with_args.
8783
8784 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8785
8786 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8787 The old code sometimes used this field without initializing it.
8788
8789 * alloc.c (gc_sweep): Don't read past end of array.
8790 In theory, the old code could also have corrupted Emacs internals,
8791 though it'd be very unlikely.
8792
8793 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8794
8795 * character.c (Fcharacterp): Don't advertise optional ignored
8796 argument. (Bug#4026)
8797
8798 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8799
8800 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8801 key" (bug#4257).
8802
8803 * window.c (Fset_window_start): Doc fix (bug#4199).
8804 (Fset_window_hscroll): Ditto.
8805
8806 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8807
8808 Fix minor new problems caught by GCC 4.6.1.
8809 * term.c (init_tty): Remove unused local.
8810 * xsettings.c (store_monospaced_changed): Define this function only
8811 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8812 not used otherwise.
8813
8814 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8815
8816 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8817
8818 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8819
8820 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8821 are the mini-buffer and the echo area (bug#3320).
8822
8823 * term.c (init_tty): Remove support for supdup, c10 and perq
8824 terminals, which are no longer supported (bug#1482).
8825
8826 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8827
8828 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8829
8830 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8831
8832 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8833 for non-popups (Bug#3642).
8834
8835 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8836
8837 * alloc.c (reset_malloc_hooks): Protoize.
8838 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8839 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8840 * cm.c (losecursor): Likewise.
8841 * data.c (fmod): Likewise.
8842 * dispnew.c (swap_glyphs_in_rows): Likewise.
8843 * emacs.c (memory_warning_signal): Likewise.
8844 * floatfns.c (float_error): Likewise.
8845 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8846 (otf_open, font_otf_capability, generate_otf_features)
8847 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8848 Likewise.
8849 * image.c (pbm_read_file): Likewise.
8850 * indent.c (string_display_width): Likewise.
8851 * intervals.c (check_for_interval, search_for_interval)
8852 (inc_interval_count, count_intervals, root_interval)
8853 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8854 * lread.c (defalias): Likewise.
8855 * ralloc.c (r_alloc_check): Likewise.
8856 * regex.c (set_image_of_range_1, set_image_of_range)
8857 (regex_grow_registers): Likewise.
8858 * sysdep.c (strerror): Likewise.
8859 * termcap.c (valid_filename_p, tprint, main): Likewise.
8860 * tparam.c (main): Likewise.
8861 * unexhp9k800.c (run_time_remap, save_data_space)
8862 (update_file_ptrs, read_header, write_header, calculate_checksum)
8863 (copy_file, copy_rest, display_header): Likewise.
8864 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8865 Likewise.
8866 * xdisp.c (check_it): Likewise.
8867 * xfaces.c (register_color, unregister_color, unregister_colors):
8868 Likewise.
8869 * xfns.c (print_fontset_result): Likewise.
8870 * xrdb.c (member, fatal, main): Likewise.
8871
8872 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8873
8874 Fix minor problems found by static checking (Bug#9031).
8875 * chartab.c (char_table_set_range, map_sub_char_table):
8876 Remove unused locals.
8877 (uniprop_table): Now static.
8878 * composite.c (_work_char): Remove unused static var.
8879
8880 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8881
8882 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8883
8884 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8885
8886 * gtkutil.c (qttip_cb): Remove code without function.
8887
8888 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8889
8890 * w32.c (pthread_sigmask): New stub.
8891
8892 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8893
8894 Use pthread_sigmask, not sigprocmask (Bug#9010).
8895 sigprocmask is portable only for single-threaded applications, and
8896 Emacs can be multi-threaded when it uses GTK.
8897 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8898 (LIBES): Use it.
8899 * callproc.c (Fcall_process):
8900 * process.c (create_process):
8901 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8902 Use pthread_sigmask, not sigprocmask.
8903
8904 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8905
8906 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8907 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8908 wrong (Bug#8591).
8909
8910 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8911
8912 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8913 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8914 (xg_hide_tooltip): Fix comment.
8915
8916 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8917 in registerServicesMenuSendTypes.
8918 (validRequestorForSendType): Don't check ns_return_types.
8919
8920 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8921 ns_return_type.
8922
8923 2011-07-08 Jason Rumney <jasonr@gnu.org>
8924
8925 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8926 SH_SHOW for hidden windows (Bug#5482).
8927
8928 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8929 frame struct members of non-existent frames (Bug#6284).
8930
8931 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8932
8933 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8934 variable firstTime not needed on OSX >= 10.6.
8935 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8936 >= 10.5. Use setKnobProportion, setDoubleValue.
8937
8938 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8939 (MAC_OS_X_VERSION_10_5): Define if not defined.
8940 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8941 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8942 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8943
8944 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8945 cString and lossyCString on OSX >= 10.4.
8946
8947 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8948 sizeToFit on OSX >= 10.2.
8949
8950 * nsimage.m (allocInitFromFile): Don't use deprecated method
8951 bestRepresentationForDevice on OSX >= 10.6.
8952
8953 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8954 to avoid warning.
8955
8956 * emacs.c: Declare unexec_init_emacs_zone.
8957
8958 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8959
8960 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8961
8962 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8963 on svcsMenu (Bug#8842).
8964
8965 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8966 ns_return_types.
8967 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8968
8969 * nsterm.m (QUTF8_STRING): Declare.
8970 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8971 (validRequestorForSendType): Return type is (id).
8972 Change indexOfObjectIdenticalTo to indexOfObject.
8973 Check if we have local selection before returning self (Bug#8842).
8974 (writeSelectionToPasteboard): Put local selection into paste board
8975 if we have a local selection (Bug#8842).
8976 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8977
8978 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8979 (ns_get_local_selection): Declare.
8980
8981 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8982
8983 * keymap.c (describe_map_tree): Don't insert a double newline at
8984 the end of the buffer (bug#1169) and return whether we inserted
8985 something.
8986
8987 * callint.c (Fcall_interactively): Change "reading args" to
8988 "providing args" to try to clarify what it does (bug#1010).
8989
8990 2011-07-07 Kenichi Handa <handa@m17n.org>
8991
8992 * composite.c (composition_compute_stop_pos): Ignore a static
8993 composition starting before CHARPOS (Bug#8915).
8994
8995 * xdisp.c (handle_composition_prop): Likewise.
8996
8997 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8998
8999 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9000 (Bug#9015)
9001
9002 2011-07-07 Kenichi Handa <handa@m17n.org>
9003
9004 * character.h (unicode_category_t): New enum type.
9005
9006 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9007 (Qchar_code_property_table): New variable.
9008 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9009 (UNIPROP_COMPRESSED_FORM_P): New macros.
9010 (char_table_ascii): Uncompress the compressed values.
9011 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9012 Uncompress the compressed values.
9013 (sub_char_table_ref_and_range): Likewise.
9014 (char_table_ref_and_range): Uncompress the compressed values.
9015 (sub_char_table_set): New arg is_uniprop. Callers changed.
9016 Uncompress the compressed values.
9017 (sub_char_table_set_range): Args changed. Callers changed.
9018 (char_table_set_range): Adjuted for the above change.
9019 (map_sub_char_table): Delete args default_val and parent. Add arg
9020 top. Give decoded values to a Lisp function.
9021 (map_char_table): Adjust for the above change. Give decoded
9022 values to a Lisp function. Gcpro more variables.
9023 (uniprop_table_uncompress)
9024 (uniprop_decode_value_run_length): New functions.
9025 (uniprop_decoder, uniprop_decoder_count): New variables.
9026 (uniprop_get_decoder, uniprop_encode_value_character)
9027 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9028 New functions.
9029 (uniprop_encoder, uniprop_encoder_count): New variables.
9030 (uniprop_get_encoder, uniprop_table)
9031 (Funicode_property_table_internal, Fget_unicode_property_internal)
9032 (Fput_unicode_property_internal): New functions.
9033 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9034 Sunicode_property_table_internal, Sget_unicode_property_internal,
9035 and Sput_unicode_property_internal. Defvar_lisp
9036 char-code-property-alist.
9037
9038 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9039 Vunicode_category_table.
9040
9041 * font.c (font_range): Adjust for the change of
9042 Vunicode_category_table.
9043
9044 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9045
9046 * m/iris4d.h: Remove file, move contents ...
9047 * s/irix6-5.h: ... here.
9048
9049 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9050
9051 Remove unportable assumption about struct layout (Bug#8884).
9052 * alloc.c (mark_buffer):
9053 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9054 (clone_per_buffer_values): Don't assume that
9055 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9056 This isn't true in general, and it's particularly not true
9057 if Emacs is configured with --with-wide-int.
9058 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9059 New macros, used in the buffer.c change.
9060
9061 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9062
9063 * xsettings.c: Use both GConf and GSettings if both are available.
9064 (store_config_changed_event): Add comment.
9065 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9066 (store_tool_bar_style_changed): New functions.
9067 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9068 (struct xsettings): Move font inside HAVE_XFT.
9069 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9070 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9071 Move inside HAVE_XFT.
9072 (something_changed_gsettingsCB): Rename from something_changedCB.
9073 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9074 also.
9075 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9076 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9077 (something_changed_gconfCB): Rename from something_changedCB.
9078 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9079 (parse_settings): Move check for font inside HAVE_XFT.
9080 (read_settings, apply_xft_settings): Add comment.
9081 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9082 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9083 call store_font_name_changed.
9084 (xft_settings_event): Add comment.
9085 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9086 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9087 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9088 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9089 (xsettings_initialize): Call init_gsettings last.
9090 (xsettings_get_system_font, xsettings_get_system_normal_font):
9091 Add comment.
9092
9093 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9094
9095 Random fixes. E.g., (random) never returned negative values.
9096 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9097 subseconds part to the entropy, as that's a bit more random.
9098 Prefer signed to unsigned, since the signedness doesn't matter and
9099 in general we prefer signed. When given a limit, use a
9100 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9101 latter isn't right if USE_2_TAGS_FOR_INTS.
9102 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9103 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9104
9105 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9106
9107 * textprop.c (text_property_stickiness):
9108 Obey Vtext_property_default_nonsticky.
9109 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9110 * w32fns.c (syms_of_w32fns):
9111 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9112
9113 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9114
9115 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9116 This is more efficient than Ffile_directory_p and avoids a minor race.
9117
9118 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9119
9120 * buffer.c (Foverlay_put): Say what the return value is
9121 (bug#7835).
9122
9123 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9124 is a directory before asking whether to use the file name
9125 (bug#7564).
9126 (barf_or_query_if_file_exists): Make the "File is a directory"
9127 error be more correct.
9128
9129 * fns.c (Frequire): Remove the mention of the .gz files, since
9130 that's installation-specific, but keep the mention of
9131 `get-load-suffixes'.
9132
9133 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9134
9135 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9136 Report string overflow if the output is too long.
9137
9138 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9139
9140 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9141 (syms_of_gnutls): Remove duplicate DEFSYM for
9142 Qgnutls_bootprop_verify_hostname_error, an error for
9143 Qgnutls_bootprop_verify_error (which is no longer used).
9144
9145 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9146 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9147 Also (re)move comments that are misplaced or no longer relevant.
9148
9149 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9150
9151 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9152
9153 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9154
9155 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9156 and background color parameters if they have been changed.
9157
9158 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9159
9160 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9161
9162 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9163
9164 * xsettings.c (SYSTEM_FONT): Define only when used.
9165 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9166
9167 * keymap.c (access_keymap_1): Now static.
9168
9169 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9170
9171 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9172 leave any prefix arg for the up event (Bug#1586).
9173
9174 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9175
9176 * lread.c (syms_of_lread): Mention single symbols defined by
9177 `defvar' or `defconst' (bug#7154).
9178
9179 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9180 (Frequire): Mention get-load-suffixes.
9181
9182 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9183
9184 * window.h (window): Remove clone_number slot.
9185 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9186 Remove.
9187 (make_parent_window, make_window, saved_window)
9188 (Fset_window_configuration, save_window_save): Don't deal with
9189 clone numbers.
9190 * buffer.c (Qclone_number): Remove declaration.
9191 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9192
9193 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9194
9195 Add multiple inheritance to keymaps.
9196 * keymap.c (Fmake_composed_keymap): New function.
9197 (Fset_keymap_parent): Simplify.
9198 (fix_submap_inheritance): Remove.
9199 (access_keymap_1): New function extracted from access_keymap to handle
9200 embedded parents and handle lists of maps.
9201 (access_keymap): Use it.
9202 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9203 (Fcopy_keymap): Handle embedded parents.
9204 (Fcommand_remapping, define_as_prefix): Simplify.
9205 (Fkey_binding): Simplify.
9206 (syms_of_keymap): Move minibuffer-local-completion-map,
9207 minibuffer-local-filename-completion-map,
9208 minibuffer-local-must-match-map, and
9209 minibuffer-local-filename-must-match-map to Elisp.
9210 (syms_of_keymap): Defsubr make-composed-keymap.
9211 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9212 (parse_menu_item): Trivial simplification.
9213
9214 2011-07-01 Glenn Morris <rgm@gnu.org>
9215
9216 * Makefile.in (SETTINGS_LIBS): Fix typo.
9217
9218 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9219
9220 * coding.c (Fencode_coding_string): Record the last coding system
9221 used, as the function doc string says (bug#8738).
9222
9223 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9224
9225 * xsettings.c (store_monospaced_changed): Take new font as arg and
9226 check for change against current_mono_font.
9227 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9228 (emacs_settings_constructor, emacs_settings_get_property)
9229 (emacs_settings_set_property, emacs_settings_class_init)
9230 (emacs_settings_init, gsettings_obj): Remove.
9231 (something_changedCB): New function for HAVE_GSETTINGS.
9232 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9233 with value as argument.
9234 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9235 g_settings_new (Bug#8967). Do not create gsettings_obj.
9236 Remove calls to g_settings_bind. Connect something_changedCB to
9237 "changed".
9238
9239 * xgselect.c: Add defined (HAVE_GSETTINGS).
9240 (xgselect_initialize): Ditto.
9241
9242 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9243 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9244 xg_select.
9245
9246 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9247
9248 * eval.c (struct backtrace): Simplify and port the data structure.
9249 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9250 signed bit field, as this assumption is not portable and it makes
9251 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9252 "char debug_on_exit : 1" as this is not portable either; instead,
9253 use the portable "unsigned int debug_on_exit : 1". Remove unused
9254 member evalargs. Remove obsolete comments about cc bombing out.
9255
9256 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9257
9258 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9259 Let HAVE_GSETTINGS override HAVE_GCONF.
9260 (store_monospaced_changed): New function.
9261 (EMACS_SETTINGS): A new type derived from GObject to handle
9262 GSettings notifications.
9263 (emacs_settings_constructor, emacs_settings_get_property)
9264 (emacs_settings_set_property, emacs_settings_class_init):
9265 New functions.
9266 (gsettings_client, gsettings_obj): New variables.
9267 (GSETTINGS_SCHEMA): New define.
9268 (something_changedCB): Call store_monospaced_changed.
9269 (init_gsettings): New function.
9270 (xsettings_initialize): Call init_gsettings.
9271 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9272 to NULL.
9273
9274 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9275 GCONF_CFLAGS/LIBS.
9276
9277 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9278
9279 * window.c (resize_root_window, grow_mini_window)
9280 (shrink_mini_window): Rename Qresize_root_window to
9281 Qwindow_resize_root_window and Qresize_root_window_vertically to
9282 Qwindow_resize_root_window_vertically.
9283
9284 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9285
9286 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9287
9288 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9289
9290 * makefile.w32-in: Redesign dependencies so they reflect more
9291 clearly which files are directly included by each source file,
9292 and not through other includes.
9293
9294 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9295
9296 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9297 (sort_overlays, overlay_strings): When an overlay's clone number
9298 matches the window's clone number process the overlay even if
9299 the overlay's window property doesn't match the current window.
9300
9301 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9302 (Fwindow_hchild): Rename to Fwindow_left_child.
9303 (Fwindow_next): Rename to Fwindow_next_sibling.
9304 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9305 (resize_window_check): Rename to window_resize_check.
9306 (resize_window_apply): Rename to window_resize_apply.
9307 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9308 (Fdelete_other_windows_internal, resize_frame_windows)
9309 (Fsplit_window_internal, Fdelete_window_internal)
9310 (grow_mini_window, shrink_mini_window)
9311 (Fresize_mini_window_internal): Fix callers accordingly.
9312
9313 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9314
9315 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9316 (emacs_fixed_set_min_size): Remove.
9317 (emacs_fixed_new): Take frame as argument.
9318
9319 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9320 (_EmacsFixedPrivate): Remove minwidth/height.
9321 Add struct frame *f.
9322 (emacs_fixed_init): Initialize priv->f.
9323 (get_parent_class, emacs_fixed_set_min_size): Remove.
9324 (emacs_fixed_new): Set priv->f to argument.
9325 (emacs_fixed_get_preferred_width)
9326 (emacs_fixed_get_preferred_height): Use min_width/height from
9327 frames size_hint to set minimum and natural (Bug#8919).
9328 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9329 and use min_width/height from frames size_hint to set
9330 min_width/height (Bug#8919).
9331
9332 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9333 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9334 Fix indentation.
9335
9336 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9337
9338 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9339 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9340 called at ZV.
9341
9342 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9343
9344 * process.c (wait_reading_process_output): Bypass select if
9345 waiting for a cell while ignoring keyboard input, and input is
9346 pending. Suggested by Jan Djärv (Bug#8869).
9347
9348 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9349
9350 Use gnulib's dup2 module instead of rolling our own.
9351 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9352
9353 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9354
9355 * dispnew.c (scrolling_window): Before scrolling, turn off a
9356 mouse-highlight in the window being scrolled.
9357
9358 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9359
9360 Move DEFSYM to lisp.h and use everywhere.
9361
9362 * character.h (DEFSYM): Move declaration...
9363 * lisp.h (DEFSYM): ...here.
9364
9365 * gnutls.c:
9366 * minibuf.c:
9367 * w32menu.c:
9368 * w32proc.c:
9369 * w32select.c: Don't include character.h.
9370
9371 * alloc.c (syms_of_alloc):
9372 * buffer.c (syms_of_buffer):
9373 * bytecode.c (syms_of_bytecode):
9374 * callint.c (syms_of_callint):
9375 * casefiddle.c (syms_of_casefiddle):
9376 * casetab.c (init_casetab_once):
9377 * category.c (init_category_once, syms_of_category):
9378 * ccl.c (syms_of_ccl):
9379 * cmds.c (syms_of_cmds):
9380 * composite.c (syms_of_composite):
9381 * dbusbind.c (syms_of_dbusbind):
9382 * dired.c (syms_of_dired):
9383 * dispnew.c (syms_of_display):
9384 * doc.c (syms_of_doc):
9385 * editfns.c (syms_of_editfns):
9386 * emacs.c (syms_of_emacs):
9387 * eval.c (syms_of_eval):
9388 * fileio.c (syms_of_fileio):
9389 * fns.c (syms_of_fns):
9390 * frame.c (syms_of_frame):
9391 * fringe.c (syms_of_fringe):
9392 * insdel.c (syms_of_insdel):
9393 * keymap.c (syms_of_keymap):
9394 * lread.c (init_obarray, syms_of_lread):
9395 * macros.c (syms_of_macros):
9396 * msdos.c (syms_of_msdos):
9397 * print.c (syms_of_print):
9398 * process.c (syms_of_process):
9399 * search.c (syms_of_search):
9400 * sound.c (syms_of_sound):
9401 * syntax.c (init_syntax_once, syms_of_syntax):
9402 * terminal.c (syms_of_terminal):
9403 * textprop.c (syms_of_textprop):
9404 * undo.c (syms_of_undo):
9405 * w32.c (globals_of_w32):
9406 * window.c (syms_of_window):
9407 * xdisp.c (syms_of_xdisp):
9408 * xfaces.c (syms_of_xfaces):
9409 * xfns.c (syms_of_xfns):
9410 * xmenu.c (syms_of_xmenu):
9411 * xsettings.c (syms_of_xsettings):
9412 * xterm.c (syms_of_xterm): Use DEFSYM.
9413
9414 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9415
9416 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9417
9418 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9419
9420 Integer and buffer overflow fixes (Bug#8873).
9421
9422 * print.c (printchar, strout): Check for string overflow.
9423 (PRINTPREPARE, printchar, strout):
9424 Don't set size unless allocation succeeds.
9425
9426 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9427 for sizes. Check for string overflow more accurately.
9428 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9429
9430 * macros.c: Integer and buffer overflow fixes.
9431 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9432 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9433 Use ptrdiff_t, not int, for sizes.
9434 Don't increment bufsize until after realloc succeeds.
9435 Check for size-calculation overflow.
9436 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9437
9438 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9439
9440 * lread.c: Integer overflow fixes.
9441 (read_integer): Radix is now EMACS_INT, not int,
9442 to improve quality of diagnostics for out-of-range radices.
9443 Calculate buffer size correctly for out-of-range radices.
9444 (read1): Check for integer overflow in radices, and in
9445 read-circle numbers.
9446 (read_escape): Avoid int overflow.
9447 (Fload, openp, read_buffer_size, read1)
9448 (substitute_object_recurse, read_vector, read_list, map_obarray):
9449 Use ptrdiff_t, not int, for sizes.
9450 (read1): Use EMACS_INT, not int, for sizes.
9451 Check for size overflow.
9452
9453 * image.c (cache_image): Check for size arithmetic overflow.
9454
9455 * lread.c: Integer overflow issues.
9456 (saved_doc_string_size, saved_doc_string_length)
9457 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9458 Now ptrdiff_t, not int.
9459 (read1): Don't assume doc string length fits in int. Check for
9460 out-of-range doc string lengths.
9461 (read_list): Don't assume file position fits in int.
9462 (read_escape): Check for hex character overflow.
9463
9464 2011-06-22 Leo Liu <sdl.web@gmail.com>
9465
9466 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9467 Move to minibuffer.el.
9468
9469 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9470
9471 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9472 The following patches are for when GLYPH_DEBUG && !XASSERT.
9473 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9474 * dispnew.c (flush_stdout):
9475 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9476 Mark as externally visible.
9477 * dispnew.c (check_window_matrix_pointers): Now static.
9478 * dispnew.c (window_to_frame_vpos):
9479 * xfns.c (unwind_create_frame):
9480 * xterm.c (x_check_font): Remove unused local.
9481 * scroll.c (CHECK_BOUNDS):
9482 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9483 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9484 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9485 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9486 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9487 Now static.
9488 (debug_method_add): Use va_list and vsprintf rather than relying
9489 on undefined behavior with wrong number of arguments.
9490 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9491 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9492 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9493 since we're not interested in debugging glyphs with old libraries.
9494 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9495 GCC 4.6.0's static checking.
9496
9497 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9498
9499 Integer overflow and signedness fixes (Bug#8873).
9500 A few related buffer overrun fixes, too.
9501
9502 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9503
9504 * dispextern.h (struct face.stipple):
9505 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9506 (x_bitmap_mask, x_allocate_bitmap_record)
9507 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9508 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9509 (x_create_bitmap_from_xpm_data):
9510 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9511 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9512 (.bitmaps_last):
9513 * xfaces.c (load_pixmap):
9514 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9515 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9516 (.bitmaps_last, struct x_output.icon_bitmap):
9517 Use ptrdiff_t, not int, for bitmap indexes.
9518 (x_allocate_bitmap_record): Check for size overflow.
9519 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9520
9521 Use ptrdiff_t, not int, for overlay counts.
9522 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9523 * editfns.c (overlays_around, get_pos_property):
9524 * textprop.c (get_char_property_and_overlay):
9525 * xdisp.c (next_overlay_change, note_mouse_highlight):
9526 * xfaces.c (face_at_buffer_position):
9527 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9528 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9529 (Fnext_overlay_change, Fprevious_overlay_change)
9530 (mouse_face_overlay_overlaps, Foverlays_in):
9531 Use ptrdiff_t, not int, for sizes.
9532 (overlays_at, overlays_in): Check for size-calculation overflow.
9533
9534 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9535
9536 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9537 (x_session_initialize): Do not assume string length fits in int.
9538
9539 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9540 This is unlikely, but can occur if DPI is outlandish.
9541
9542 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9543 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9544
9545 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9546 * xrdb.c (magic_file_p, search_magic_path):
9547 Omit last arg SUFFIX; it was always 0. All callers changed.
9548 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9549
9550 * xfont.c (xfont_match): Avoid need for strlen.
9551
9552 * xfns.c: Don't assume strlen fits in int.
9553 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9554
9555 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9556 not unsigned long, as we prefer signed integers. All callers changed.
9557 Detect integer overflow in repeat count.
9558 (message_dolog): Don't assume print length fits in 39 bytes.
9559 (display_mode_element): Don't assume strlen fits in int.
9560
9561 * termcap.c: Don't assume sizes fit in int and never overflow.
9562 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9563 (gobble_line): Check for size-calculation overflow.
9564
9565 * minibuf.c (Fread_buffer):
9566 * lread.c (intern, intern_c_string):
9567 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9568 Don't assume string length fits in int.
9569
9570 * keyboard.c (parse_tool_bar_item):
9571 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9572
9573 * font.c: Don't assume string length fits in int.
9574 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9575 Use ptrdiff_t, not int.
9576 (font_intern_prop): Don't assume string length fits in int.
9577 Don't assume integer property fits in fixnum.
9578 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9579
9580 * filelock.c: Fix some buffer overrun and integer overflow issues.
9581 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9582 Reformulate so as not to need the command string.
9583 Invoke gzip -cd rather than gunzip, as it's more portable.
9584 (lock_info_type, lock_file_1, lock_file):
9585 Don't assume pid_t and time_t fit in unsigned long.
9586 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9587 (current_lock_owner): Prefer signed type for sizes.
9588 Use memcpy, not strncpy, where memcpy is what is really wanted.
9589 Don't assume (via atoi) that time_t and pid_t fit in int.
9590 Check for time_t and/or pid_t out of range, e.g., via a network share.
9591 Don't alloca where an auto var works fine.
9592
9593 * fileio.c: Fix some integer overflow issues.
9594 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9595 Don't assume string length fits in int.
9596 (directory_file_name): Don't assume string length fits in long.
9597 (make_temp_name): Don't assume pid fits in int, or that its print
9598 length is less than 20.
9599
9600 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9601
9602 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9603
9604 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9605
9606 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9607 We prefer signed integers, even for size calculations.
9608
9609 * emacs.c: Don't assume string length fits in 'int'.
9610 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9611 (main): Don't invoke strlen when not needed.
9612
9613 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9614 (XD_DEBUG_MESSAGE): Don't waste a byte.
9615
9616 * callproc.c (getenv_internal_1, getenv_internal)
9617 (Fgetenv_internal):
9618 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9619
9620 * lread.c (invalid_syntax): Omit length argument.
9621 All uses changed. This doesn't fix a bug, but it simplifies the
9622 code away from its former Hollerith-constant appearance, and it's
9623 one less 'int' to worry about when looking at integer-overflow issues.
9624 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9625
9626 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9627 This didn't break anything, but it didn't help either.
9628 It's confusing to put a bogus integer in a place where the actual
9629 value does not matter.
9630 (LIST_END_P): Remove unused macro and its bogus comment.
9631 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9632
9633 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9634 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9635 implementation.
9636 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9637 We prefer signed types, and the value cannot exceed the EMACS_INT
9638 range anyway (because otherwise the length would not be representable).
9639 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9640 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9641 This avoids a GCC warning when WIDE_EMACS_INT.
9642
9643 * indent.c (sane_tab_width): New function.
9644 (current_column, scan_for_column, Findent_to, position_indentation)
9645 (compute_motion): Use it. This is just for clarity.
9646 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9647
9648 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9649
9650 * lisp.h (lint_assume): New macro.
9651 * composite.c (composition_gstring_put_cache):
9652 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9653
9654 * editfns.c, insdel.c:
9655 Omit unnecessary forward decls, to simplify future changes.
9656
9657 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9658
9659 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9660
9661 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9662 Use much-faster test for byte-length change.
9663 Don't assume string byte-length fits in 'int'.
9664 Check that character arg fits in 'int'.
9665 (mapcar1): Declare byte as byte, for clarity.
9666
9667 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9668
9669 * fns.c (concat): Catch string overflow earlier.
9670 Do not rely on integer wraparound.
9671
9672 * dispextern.h (struct it.overlay_strings_charpos)
9673 (struct it.selective): Now EMACS_INT, not int.
9674 * xdisp.c (forward_to_next_line_start)
9675 (back_to_previous_visible_line_start)
9676 (reseat_at_next_visible_line_start, next_element_from_buffer):
9677 Don't arbitrarily truncate the value of 'selective' to int.
9678
9679 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9680
9681 * composite.c: Don't truncate sizes to 'int'.
9682 (composition_gstring_p, composition_reseat_it)
9683 (composition_adjust_point): Use EMACS_INT, not int.
9684 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9685 not EMACS_UINT, for indexes.
9686
9687 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9688
9689 * buffer.c: Include <verify.h>.
9690 (struct sortvec.priority, struct sortstr.priority):
9691 Now EMACS_INT, not int.
9692 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9693 (struct sortstr.size, record_overlay_string)
9694 (struct sortstrlist.size, struct sortlist.used):
9695 Don't truncate size to int.
9696 (record_overlay_string): Check for size-calculation overflow.
9697 (init_buffer_once): Check at compile-time, not run-time.
9698
9699 2011-06-22 Jim Meyering <meyering@redhat.com>
9700
9701 Don't leak an XBM-image-sized buffer
9702 * image.c (xbm_load): Free the image buffer after using it.
9703
9704 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9705
9706 Port to Sun C.
9707 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9708 that Sun C diagnosed.
9709 * fns.c (secure_hash): Fix pointer signedness issue.
9710 * intervals.c (static_offset_intervals): New function.
9711 (offset_intervals): Use it.
9712
9713 2011-06-21 Leo Liu <sdl.web@gmail.com>
9714
9715 * deps.mk (fns.o):
9716 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9717 sha512.h.
9718
9719 * fns.c (secure_hash): Rename from crypto_hash_function and change
9720 the first arg to accept symbols.
9721 (Fsecure_hash): New primitive.
9722 (syms_of_fns): New symbols.
9723
9724 2011-06-20 Deniz Dogan <deniz@dogan.se>
9725
9726 * process.c (Fset_process_buffer): Clarify return value in
9727 docstring.
9728
9729 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9730
9731 * dispnew.c (add_window_display_history): Use BVAR.
9732
9733 * xdisp.c (debug_method_add): Use BVAR.
9734 (check_window_end, dump_glyph_matrix, dump_glyph)
9735 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9736
9737 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9738 Likewise.
9739
9740 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9741 check till after the cache is created in init_frame_faces.
9742
9743 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9744
9745 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9746
9747 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9748
9749 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9750 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9751 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9752
9753 Improve buffer-overflow checking (Bug#8873).
9754 * fileio.c (Finsert_file_contents):
9755 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9756 Remove the old (too-loose) buffer overflow checks.
9757 They weren't needed, since make_gap checks for buffer overflow.
9758 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9759 The old code merely checked for Emacs fixnum overflow, and relied
9760 on undefined (wraparound) behavior. The new code avoids undefined
9761 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9762
9763 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9764 Tune. Don't use wider integers than needed. Don't use alloca.
9765 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9766
9767 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9768
9769 * insdel.c, lisp.h (buffer_overflow): New function.
9770 (insert_from_buffer_1, replace_range, replace_range_2):
9771 * insdel.c (make_gap_larger):
9772 * editfns.c (Finsert_char):
9773 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9774
9775 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9776
9777 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9778
9779 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9780
9781 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9782 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9783
9784 * fileio.c: Don't assume EMACS_INT fits in off_t.
9785 (emacs_lseek): New static function.
9786 (Finsert_file_contents, Fwrite_region): Use it.
9787 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9788
9789 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9790
9791 * fns.c: Don't overflow int when computing a list length.
9792 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9793 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9794 truncation on 64-bit hosts. Check for QUIT every
9795 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9796 faster and is responsive enough.
9797 (Flength): Report an error instead of overflowing an integer.
9798 (Fsafe_length): Return a float if the value is not representable
9799 as a fixnum. This shouldn't happen except in contrived situations.
9800 (Fnthcdr, Fsort): Don't assume list length fits in int.
9801 (Fcopy_sequence): Don't assume vector length fits in int.
9802
9803 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9804 (header_size, word_size): New constants.
9805 (allocate_vectorlike): Don't check size overflow here.
9806 (allocate_vector): Check it here instead, since this is the only
9807 caller of allocate_vectorlike that could cause overflow.
9808 Check that the new vector's length is representable as a fixnum.
9809
9810 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9811 The previous code was bogus. For example, next_almost_prime (32)
9812 returned 39, which is undesirable as it is a multiple of 3; and
9813 next_almost_prime (24) returned 25, which is a multiple of 5 so
9814 why was the code bothering to check for multiples of 7?
9815
9816 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9817
9818 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9819
9820 Variadic C functions now count arguments with ptrdiff_t.
9821 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9822 Back then I didn't know that the Emacs coding style prefers signed int.
9823 Also, in the meantime I found a few more instances where arguments
9824 were being counted with int, which may truncate counts on 64-bit
9825 machines, or EMACS_INT, which may be unnecessarily wide.
9826 * lisp.h (struct Lisp_Subr.function.aMANY)
9827 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9828 Arg counts are now ptrdiff_t, not size_t.
9829 All variadic functions and their callers changed accordingly.
9830 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9831 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9832 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9833 * callint.c (Fcall_interactively): Check arg count for overflow,
9834 to avoid potential buffer overrun. Use signed char, not 'int',
9835 for 'varies' array, so that we needn't bother to check its size
9836 calculation for overflow.
9837 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9838 * eval.c (apply_lambda):
9839 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9840 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9841 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9842
9843 * callint.c (Fcall_interactively): Don't use index var as event count.
9844
9845 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9846 * mem-limits.h (SIZE): Remove; no longer used.
9847
9848 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9849
9850 Remove unnecessary casts.
9851 * xterm.c (x_term_init):
9852 * xfns.c (x_set_border_pixel):
9853 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9854 These aren't needed now that we assume ANSI C.
9855
9856 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9857 It's more likely to cause problems (due to unsigned overflow)
9858 than to cure them.
9859
9860 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9861
9862 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9863
9864 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9865
9866 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9867
9868 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9869
9870 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9871
9872 GLYPH_CODE_FACE returns EMACS_INT, not int.
9873 * dispextern.h (merge_faces):
9874 * xfaces.c (merge_faces):
9875 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9876 Don't assume EMACS_INT fits in int.
9877
9878 * character.h (CHAR_VALID_P): Remove unused parameter.
9879 * fontset.c, lisp.h, xdisp.c: All uses changed.
9880
9881 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9882
9883 * fns.c (concat): Minor tuning based on overflow analysis.
9884 This doesn't fix any bugs. Use int to hold character, instead
9885 of constantly refetching from Emacs object. Use XFASTINT, not
9886 XINT, for value known to be a character. Don't bother comparing
9887 a single byte to 0400, as it's always less.
9888
9889 * floatfns.c (Fexpt):
9890 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9891
9892 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9893 for characters.
9894
9895 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9896
9897 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9898 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9899 incorrectly succeed when S was a string, because 4294967386 was
9900 truncated before it was used.
9901
9902 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9903 Otherwise, an out-of-range integer could cause undefined behavior
9904 on a 64-bit host.
9905
9906 * composite.c: Use int, not EMACS_INT, for characters.
9907 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9908 EMACS_INT, for values that are known to be in character range.
9909 This doesn't fix any bugs but is the usual style inside Emacs and
9910 may generate better code on 32-bit machines.
9911
9912 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9913 This is for reasons similar to the recent CHAR_STRING fix.
9914 * charset.c (Fencode_char): Check that character arg is actually
9915 a character. Pass an int to ENCODE_CHAR.
9916 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9917 wider than 'int', as a compile-time check to prevent future regressions
9918 in this area.
9919
9920 * character.c (char_string): Remove unnecessary casts.
9921
9922 Make sure a 64-bit char is never passed to CHAR_STRING.
9923 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9924 by silently ignoring the top 32 bits, allowing some values
9925 that were far too large to be valid characters.
9926 * character.h: Include <verify.h>.
9927 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9928 arguments are no wider than unsigned, as a compile-time check
9929 to prevent future regressions in this area.
9930 * data.c (Faset):
9931 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9932 (Fsubst_char_in_region):
9933 * fns.c (concat):
9934 * xdisp.c (decode_mode_spec_coding):
9935 Adjust to CHAR_STRING's new requirement.
9936 * editfns.c (Finsert_char, Fsubst_char_in_region):
9937 * fns.c (concat): Check that character args are actually
9938 characters. Without this test, these functions did the wrong
9939 thing with wildly out-of-range values on 64-bit hosts.
9940
9941 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9942 These casts should not be needed on 32-bit hosts, either.
9943 * keyboard.c (read_char):
9944 * lread.c (Fload): Remove casts to unsigned.
9945
9946 * lisp.h (UNSIGNED_CMP): New macro.
9947 This fixes comparison bugs on 64-bit hosts.
9948 (ASCII_CHAR_P): Use it.
9949 * casefiddle.c (casify_object):
9950 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9951 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9952 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9953 * dispextern.h (FACE_FROM_ID):
9954 * keyboard.c (read_char): Use UNSIGNED_CMP.
9955
9956 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9957 not to EMACS_INT, to avoid GCC warning.
9958
9959 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9960
9961 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9962 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9963 isn't needed on 32-bit machines.
9964
9965 * buffer.c (Fgenerate_new_buffer_name):
9966 Use EMACS_INT for count, not int.
9967 (advance_to_char_boundary): Return EMACS_INT, not int.
9968
9969 * data.c (Qcompiled_function): Now static.
9970
9971 * window.c (window_body_lines): Now static.
9972
9973 * image.c (gif_load): Rename local to avoid shadowing.
9974
9975 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9976 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9977 * alloc.c (make_save_value): Integer argument is now of type
9978 ptrdiff_t, not int.
9979 (mark_object): Use ptrdiff_t, not int.
9980 * lisp.h (pD): New macro.
9981 * print.c (print_object): Use it.
9982
9983 * alloc.c: Use EMACS_INT, not int, to count objects.
9984 (total_conses, total_markers, total_symbols, total_vector_size)
9985 (total_free_conses, total_free_markers, total_free_symbols)
9986 (total_free_floats, total_floats, total_free_intervals)
9987 (total_intervals, total_strings, total_free_strings):
9988 Now EMACS_INT, not int. All uses changed.
9989 (Fgarbage_collect): Compute overall total using a double, so that
9990 integer overflow is less likely to be a problem. Check for overflow
9991 when converting back to an integer.
9992 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9993 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9994 These were 'int' variables that could overflow on 64-bit hosts;
9995 they were never used, so remove them instead of repairing them.
9996 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9997 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9998 Previously, this ceilinged at INT_MAX, but that doesn't work on
9999 64-bit machines.
10000 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10001
10002 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10003 (allocate_vectorlike): Check for ptrdiff_t overflow.
10004 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10005 when a (possibly-narrower) signed value would do just as well.
10006 We prefer using signed arithmetic, to avoid comparison confusion.
10007
10008 * alloc.c: Catch some string size overflows that we were missing.
10009 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10010 for convenience in STRING_BYTES_MAX.
10011 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10012 The definition here is exact; the one in lisp.h was approximate.
10013 (allocate_string_data): Check for string overflow. This catches
10014 some instances we weren't catching before. Also, it catches
10015 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10016 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10017 and ptrdiff_t and EMACS_INT are both 64 bits.
10018
10019 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10020 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10021 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10022
10023 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10024
10025 * alloc.c (Fmake_string): Check for out-of-range init.
10026
10027 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10028
10029 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10030
10031 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10032
10033 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10034 xg_get_default_scrollbar_width.
10035
10036 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10037 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10038 (style_changed_cb): Call update_theme_scrollbar_width and call
10039 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10040 all frames (Bug#8505).
10041 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10042 Call gtk_window_set_resizable if HAVE_GTK3.
10043 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10044 and height if HAVE_GTK3 (Bug#8505).
10045 (scroll_bar_width_for_theme): New variable.
10046 (update_theme_scrollbar_width): New function.
10047 (xg_get_default_scrollbar_width): Move code to
10048 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10049 (xg_initialize): Call update_theme_scrollbar_width.
10050
10051 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10052
10053 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10054
10055 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10056
10057 * frame.c (make_frame): Call other_buffer_safely instead of
10058 other_buffer.
10059
10060 * window.c (temp_output_buffer_show): Call display_buffer with
10061 second argument Vtemp_buffer_show_specifiers and reset latter
10062 immediately after the call.
10063 (Vtemp_buffer_show_specifiers): New variable.
10064 (auto_window_vscroll_p, next_screen_context_lines)
10065 (Vscroll_preserve_screen_position): Remove leading asterisks from
10066 doc-strings.
10067
10068 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10069
10070 Fix minor problems found by GCC 4.6.0 static checking.
10071 * buffer.c (Qclone_number): Remove for now, as it's unused.
10072 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10073 (record_buffer): Remove unused local.
10074 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10075 (set_frame_buffer_list): Remove; unused.
10076 * frame.h (other_visible_frames): Remove decl.
10077 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10078 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10079 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10080 if HAVE_GPM.
10081 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10082 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10083 Define only if HAVE_GPM.
10084 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10085 (update_hints_inhibit): Remove; never set. All uses removed.
10086 * widgetprv.h (emacsFrameClassRec): Remove decl.
10087 * window.c (delete_deletable_window): Now returns void, since it
10088 wasn't returning anything.
10089 (compare_window_configurations): Remove unused locals.
10090 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10091 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10092 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10093 the same widths as pointers. This follows up on the 2011-05-06 patch.
10094 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10095 * xterm.h: Likewise.
10096 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10097
10098 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10099
10100 * makefile.w32-in: Update dependencies.
10101 (LISP_H): Add lib/intprops.h.
10102
10103 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10104
10105 * image.c (gif_load): Add animation frame delay to the metadata.
10106 (syms_of_image): Use DEFSYM. New symbol `delay'.
10107
10108 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10109
10110 * window.c (delete_deletable_window): Re-add.
10111 (Fset_window_configuration): Rewrite to handle dead buffers and
10112 consequently deletable windows.
10113 (window_tree, Fwindow_tree): Remove. Supply functionality in
10114 window.el.
10115 (compare_window_configurations): Simplify code.
10116
10117 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10118
10119 * image.c (imagemagick_load_image): Fix type mismatch.
10120 (Fimagemagick_types): Likewise.
10121
10122 * window.h (replace_buffer_in_windows): Declare.
10123
10124 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10125
10126 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10127 Qclone_number. Remove external declaration of Qdelete_window.
10128 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10129 code.
10130 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10131 Run Qbuffer_list_update_hook if allowed.
10132 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10133 buffer list implementation.
10134 (other_buffer_safely): New function.
10135 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10136 calls to replace_buffer_in_windows and
10137 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10138 if allowed.
10139 (record_buffer): Inhibit quitting and rewrite using quittable
10140 functions. Run Qbuffer_list_update_hook if allowed.
10141 (Frecord_buffer, Funrecord_buffer): New functions.
10142 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10143 Move switch-to-buffer to window.el.
10144 (bury-buffer): Move to window.el.
10145 (Vbuffer_list_update_hook): New variable.
10146
10147 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10148 section.
10149
10150 * window.h (resize_frame_windows): Move up in code.
10151 (Fwindow_frame): Remove EXFUN.
10152 (replace_buffer_in_all_windows): Remove prototype.
10153 (replace_buffer_in_windows_safely): Add prototype.
10154
10155 * window.c: Declare Qdelete_window static again. Move down
10156 declaration of select_count.
10157 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10158 (Fother_window): Move to window.el.
10159 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10160 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10161 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10162 window.el.
10163 (replace_buffer_in_windows): Implement by calling
10164 Qreplace_buffer_in_windows.
10165 (replace_buffer_in_all_windows): Remove with some functionality
10166 moved into replace_buffer_in_windows_safely.
10167 (replace_buffer_in_windows_safely): New function.
10168 (select_window_norecord, select_frame_norecord): Move in front
10169 of run_window_configuration_change_hook. Remove now obsolete
10170 declarations.
10171 (Fset_window_buffer): Rewrite doc-string.
10172 Call Qrecord_window_buffer.
10173 (keys_of_window): Move binding for other-window to window.el.
10174
10175 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10176
10177 * dispextern.h (struct image): Replace data member, whose int_val
10178 and ptr_val fields were not used by anything, with a single
10179 lisp_val object.
10180
10181 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10182 (gif_clear_image, gif_load, imagemagick_load_image)
10183 (gs_clear_image, gs_load): Callers changed.
10184
10185 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10186
10187 * buffer.h: Include <time.h>, for time_t.
10188 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10189
10190 Fix minor problems found by static checking.
10191
10192 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10193
10194 Make identifiers static if they are not used in other modules.
10195 * data.c (Qcompiled_function, Qframe, Qvector):
10196 * image.c (QimageMagick, Qsvg):
10197 * minibuf.c (Qmetadata):
10198 * window.c (resize_window_check, resize_root_window): Now static.
10199 * window.h (resize_window_check, resize_root_window): Remove decls.
10200
10201 * window.c (window_deletion_count, delete_deletable_window):
10202 Remove; unused.
10203 (window_body_lines): Now static.
10204 (Fdelete_other_windows_internal): Mark vars as initialized.
10205 Make sure 'resize_failed' is initialized.
10206 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10207 (resize_window_apply): Remove unused local.
10208 * window.h (delete_deletable_window): Remove decl.
10209
10210 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10211 (imagemagick_load_image): Fix pointer signedness problem by changing
10212 last arg from unsigned char * to char *. All uses changed.
10213 Also, fix a local for similar reasons.
10214 Remove unused locals. Remove locals to avoid shadowing.
10215 (fn_rsvg_handle_free): Remove; unused.
10216 (svg_load, svg_load_image): Fix pointer signedness problem.
10217 (imagemagick_load_image): Don't use garbage pointer image_wand.
10218
10219 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10220
10221 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10222
10223 * image.c (gif_load): Fix omitted cast error introduced by
10224 2011-06-06 change.
10225
10226 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10227
10228 * window.h (resize_proportionally, orig_total_lines)
10229 (orig_top_line): Remove from window structure.
10230 (set_window_height, set_window_width, change_window_heights)
10231 (Fdelete_window): Remove prototypes.
10232 (resize_frame_windows): Remove duplicate declaration.
10233
10234 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10235
10236 * window.h (resize_frame_windows, resize_window_check)
10237 (delete_deletable_window, resize_root_window)
10238 (resize_frame_windows): Declare prototypes.
10239
10240 * window.c (resize_window_apply): Make definition be "static" to
10241 match the prototype.
10242
10243 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10244
10245 * window.c: Remove declarations of Qwindow_size_fixed,
10246 window_min_size_1, window_min_size_2, window_min_size,
10247 size_window, window_fixed_size_p, enlarge_window, delete_window.
10248 Remove static from declaration of Qdelete_window, it's
10249 temporarily needed by Fbury_buffer.
10250 (replace_window): Don't assign orig_top_line and
10251 orig_total_lines.
10252 (Fdelete_window, delete_window): Remove. Window deletion is
10253 handled by window.el.
10254 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10255 Replace Fdelete_window calls with calls to Qdelete_window.
10256 (Fdelete_other_windows): Remove. Deleting other windows is
10257 handled by window.el.
10258 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10259 handled in window.el.
10260 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10261 Window minimum sizes are handled in window.el.
10262 (shrink_windows, size_window, set_window_height)
10263 (set_window_width, change_window_heights, window_height)
10264 (window_width, CURBEG, CURSIZE, enlarge_window)
10265 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10266 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10267 handled in window.el.
10268 (make_dummy_parent): Rename to make_parent_window and give it a
10269 second argument horflag.
10270 (make_window): Don't set resize_proportionally any more.
10271 (Fsplit_window): Remove. Windows are split in window.el.
10272 (save_restore_action, save_restore_orig_size)
10273 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10274 Resize mini windows in window.el.
10275 (grow_mini_window, shrink_mini_window): Implement by calling
10276 Qresize_root_window_vertically, resize_window_check and
10277 resize_window_apply.
10278 (saved_window, Fset_window_configuration, save_window_save):
10279 Do not handle orig_top_line, orig_total_lines, and
10280 resize_proportionally.
10281 (window_min_height, window_min_width): Move to window.el.
10282 (keys_of_window): Move bindings for delete-other-windows,
10283 split-window, delete-window and enlarge-window to window.el.
10284
10285 * buffer.c: Temporarily extern Qdelete_window.
10286 (Fbury_buffer): Temporarily call Qdelete_window instead of
10287 Fdelete_window (Fbury_buffer will move to window.el soon).
10288
10289 * frame.c (set_menu_bar_lines_1): Remove code handling
10290 orig_top_line and orig_total_lines.
10291
10292 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10293 set_window_height but set heights directly.
10294 (change_frame_size_1): Use resize_frame_windows.
10295
10296 * xdisp.c (init_xdisp): Don't use set_window_height but set
10297 heights directly.
10298
10299 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10300 Use resize_frame_windows instead of change_window_heights and run
10301 run_window_configuration_change_hook.
10302
10303 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10304 instead of change_window_heights and run
10305 run_window_configuration_change_hook.
10306
10307 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10308
10309 * window.c (replace_window): Rename second argument REPLACEMENT to
10310 NEW. New third argument SETFLAG. Rewrite.
10311 (delete_window, make_dummy_parent): Call replace_window with
10312 third argument 1.
10313 (window_list_1): Move down in code.
10314 (run_window_configuration_change_hook): Move set_buffer part
10315 before select_frame_norecord part in order to unwind correctly.
10316 Rename count1 to count.
10317 (recombine_windows, delete_deletable_window, resize_root_window)
10318 (Fdelete_other_windows_internal)
10319 (Frun_window_configuration_change_hook, make_parent_window)
10320 (resize_window_check, resize_window_apply, Fresize_window_apply)
10321 (resize_frame_windows, Fsplit_window_internal)
10322 (Fdelete_window_internal, Fresize_mini_window_internal):
10323 New functions.
10324 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10325
10326 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10327
10328 * window.h (window): Add some new members to window structure -
10329 normal_lines, normal_cols, new_total, new_normal, clone_number,
10330 splits, nest, prev_buffers, next_buffers.
10331 (WINDOW_TOTAL_SIZE): Move here from window.c.
10332 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10333
10334 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10335 Remove.
10336 (make_dummy_parent): Set new members of windows structure.
10337 (make_window): Move down in code. Handle new members of window
10338 structure.
10339 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10340 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10341 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10342 (Fset_window_prev_buffers, Fwindow_next_buffers)
10343 (Fset_window_next_buffers, Fset_window_clone_number):
10344 New functions.
10345 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10346 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10347 Doc-string fixes.
10348 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10349 Argument WINDOW can be now internal window too.
10350 (Fwindow_use_time): Move up in code.
10351 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10352 Rewrite doc-string.
10353 (Fset_window_configuration, saved_window)
10354 (Fcurrent_window_configuration, save_window_save): Handle new
10355 members of window structure.
10356 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10357 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10358 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10359 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10360 Qget_mru_window, Qresize_root_window,
10361 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10362 Qauto_buffer_name; staticpro them.
10363
10364 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10365
10366 * window.c (Fwindow_total_size, Fwindow_left_column)
10367 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10368 (Fwindow_list_1): New functions.
10369 (window_box_text_cols): Replace with window_body_cols.
10370 (Fwindow_width, Fscroll_left, Fscroll_right):
10371 Use window_body_cols instead of window_box_text_cols.
10372 (delete_window, Fset_window_configuration):
10373 Call delete_all_subwindows with window as argument.
10374 (delete_all_subwindows): Take a window as argument and not a
10375 structure. Rewrite.
10376 (window_loop): Remove handling of GET_LRU_WINDOW and
10377 GET_LARGEST_WINDOW.
10378 (Fget_lru_window, Fget_largest_window): Move to window.el.
10379
10380 * window.h: Extern window_body_cols instead of
10381 window_box_text_cols. delete_all_subwindows now takes a
10382 Lisp_Object as argument.
10383
10384 * indent.c (compute_motion, Fcompute_motion):
10385 Use window_body_cols instead of window_box_text_cols.
10386
10387 * frame.c (delete_frame): Call delete_all_subwindows with root
10388 window as argument.
10389
10390 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10391
10392 * fns.c (Fputhash): Document return value.
10393
10394 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10395
10396 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10397
10398 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10399
10400 Cons<->int and similar integer overflow fixes (Bug#8794).
10401
10402 Check for overflow when converting integer to cons and back.
10403 * charset.c (Fdefine_charset_internal, Fdecode_char):
10404 Use cons_to_unsigned to catch overflow.
10405 (Fencode_char): Use INTEGER_TO_CONS.
10406 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10407 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10408 * data.c (long_to_cons, cons_to_long): Remove.
10409 (cons_to_unsigned, cons_to_signed): New functions.
10410 These signal an error for invalid or out-of-range values.
10411 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10412 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10413 * font.c (Ffont_variation_glyphs):
10414 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10415 * lisp.h: Include <intprops.h>.
10416 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10417 (cons_to_signed, cons_to_unsigned): New decls.
10418 (long_to_cons, cons_to_long): Remove decls.
10419 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10420 (Fprimitive_undo): Use CONS_TO_INTEGER.
10421 * xfns.c (Fx_window_property): Likewise.
10422 * xselect.c: Include <limits.h>.
10423 (x_own_selection, selection_data_to_lisp_data):
10424 Use INTEGER_TO_CONS.
10425 (x_handle_selection_request, x_handle_selection_clear)
10426 (x_get_foreign_selection, Fx_disown_selection_internal)
10427 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10428 (lisp_data_to_selection_data): Use cons_to_unsigned.
10429 (x_fill_property_data): Use cons_to_signed.
10430 Report values out of range.
10431
10432 Check for buffer and string overflow more precisely.
10433 * buffer.h (BUF_BYTES_MAX): New macro.
10434 * lisp.h (STRING_BYTES_MAX): New macro.
10435 * alloc.c (Fmake_string):
10436 * character.c (string_escape_byte8):
10437 * coding.c (coding_alloc_by_realloc):
10438 * doprnt.c (doprnt):
10439 * editfns.c (Fformat):
10440 * eval.c (verror):
10441 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10442 since they may not be the same number.
10443 * editfns.c (Finsert_char):
10444 * fileio.c (Finsert_file_contents):
10445 Likewise for BUF_BYTES_MAX.
10446
10447 * image.c: Use ptrdiff_t, not int, for sizes.
10448 (slurp_file): Switch from int to ptrdiff_t.
10449 All uses changed.
10450 (slurp_file): Check that file size fits in both size_t (for
10451 malloc) and ptrdiff_t (for sanity and safety).
10452
10453 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10454 if b->modtime has its maximal value.
10455
10456 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10457
10458 Don't assume time_t can fit into int.
10459 * buffer.h (struct buffer.modtime): Now time_t, not int.
10460 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10461 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10462
10463 Minor fixes for signed vs unsigned integers.
10464 * character.h (MAYBE_UNIFY_CHAR):
10465 * charset.c (maybe_unify_char):
10466 * keyboard.c (read_char, reorder_modifiers):
10467 XINT -> XFASTINT, since the integer must be nonnegative.
10468 * ftfont.c (ftfont_spec_pattern):
10469 * keymap.c (access_keymap, silly_event_symbol_error):
10470 XUINT -> XFASTINT, since the integer must be nonnegative.
10471 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10472 since it makes no difference and we prefer signed.
10473 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10474 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10475 nonnegative.
10476
10477 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10478
10479 * window.h (Fwindow_frame): Declare.
10480
10481 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10482
10483 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10484 (SPARE_MEMORY): Always define.
10485 (LARGE_REQUEST): Remove.
10486 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10487
10488 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10489
10490 * lisp.h: Move EXFUNS for Fframe_root_window,
10491 Fframe_first_window and Fset_frame_selected_window to window.h.
10492
10493 * window.h: Move EXFUNS for Fframe_root_window,
10494 Fframe_first_window and Fset_frame_selected_window here from
10495 lisp.h.
10496
10497 * frame.c (Fwindow_frame, Fframe_first_window)
10498 (Fframe_root_window, Fframe_selected_window)
10499 (Fset_frame_selected_window): Move to window.c.
10500 (Factive_minibuffer_window): Move to minibuf.c.
10501 (Fother_visible_frames_p): New function.
10502
10503 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10504
10505 * window.c (decode_window, decode_any_window): Move up in code.
10506 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10507 (inhibit_frame_unsplittable): Remove unused variable.
10508 (Fwindow_buffer): Move up and rewrite doc-string.
10509 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10510 (Fwindow_prev): New functions.
10511 (Fwindow_frame): Move here from frame.c. Accept any window as
10512 argument.
10513 (Fframe_root_window, Fframe_first_window)
10514 (Fframe_selected_window): Move here from frame.c. Accept frame
10515 or arbitrary window as argument. Update doc-strings.
10516 (Fminibuffer_window): Move up in code.
10517 (Fwindow_minibuffer_p): Move up in code and simplify.
10518 (Fset_frame_selected_window): Move here from frame.c.
10519 Marginal rewrite.
10520 (Fselected_window, select_window, Fselect_window): Move up in
10521 code. Minor doc-string fixes.
10522
10523 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10524
10525 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10526 Do not assume that spare memory exists; that assumption is valid
10527 only if SYSTEM_MALLOC.
10528 (LARGE_REQUEST): New macro, so that the issue of large requests
10529 is separated from the issue of spare memory.
10530
10531 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10532
10533 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10534 format. (Bug#8806)
10535
10536 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10537
10538 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10539 before statements.
10540
10541 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10542
10543 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10544
10545 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10546
10547 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10548 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10549
10550 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10551
10552 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10553
10554 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10555
10556 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10557 (x_clipboard_manager_save): Add return value.
10558 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10559 New error handlers.
10560 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10561 Obey Vx_select_enable_clipboard_manager. Catch errors in
10562 x_clipboard_manager_save (Bug#8779).
10563 (Vx_select_enable_clipboard_manager): New variable.
10564 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10565
10566 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10567
10568 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10569
10570 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10571
10572 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10573 in the current matrix if keep_current_p is non-zero.
10574
10575 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10576
10577 * bidi.c (bidi_level_of_next_char): Fix last change.
10578
10579 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10580
10581 Support bidi reordering of text covered by display properties.
10582
10583 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10584 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10585 (bidi_cache_search, bidi_cache_iterator_state)
10586 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10587 (bidi_level_of_next_char, bidi_move_to_visually_next):
10588 Support character positions inside a run of characters covered by a
10589 display string.
10590 (bidi_paragraph_init, bidi_resolve_explicit_1)
10591 (bidi_level_of_next_char): Call bidi_fetch_char and
10592 bidi_fetch_char_advance instead of FETCH_CHAR and
10593 FETCH_CHAR_ADVANCE.
10594 (bidi_init_it): Initialize new members.
10595 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10596 definitions.
10597 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10598 instead of using explicit *_CHAR codes.
10599 (bidi_resolve_explicit, bidi_resolve_weak):
10600 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10601 bidirectional text is supported only in multibyte buffers.
10602 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10603 it to initialize the frame_window_p member of struct bidi_it.
10604 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10605 (bidi_resolve_explicit, bidi_resolve_weak)
10606 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10607 bidi_it->nchars is non-positive.
10608 (bidi_level_of_next_char): Don't try to lookup the cache for the
10609 next/previous character if nothing is cached there yet, or if we
10610 were just reseat()'ed to a new position.
10611
10612 * xdisp.c (set_cursor_from_row): Set start and stop points
10613 according to the row's direction when priming the loop that looks
10614 for the glyph on which to display cursor.
10615 (single_display_spec_intangible_p): Function deleted.
10616 (display_prop_intangible_p): Reimplement to call
10617 handle_display_spec instead of single_display_spec_intangible_p.
10618 Accept 3 additional arguments needed by handle_display_spec.
10619 This fixes incorrect cursor motion across display property with complex
10620 values: lists, `(when COND...)' forms, etc.
10621 (single_display_spec_string_p): Support property values that are
10622 lists with the argument STRING its top-level element.
10623 (display_prop_string_p): Fix the condition for processing a
10624 property that is a list to be consistent with handle_display_spec.
10625 (handle_display_spec): New function, refactored from the
10626 last portion of handle_display_prop.
10627 (compute_display_string_pos): Accept additional argument
10628 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10629 value of a `display' property is a "replacing spec".
10630 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10631 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10632 the display property, but just return a value indicating whether
10633 the display property will replace the characters it covers.
10634 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10635 frame_window_p members of struct bidi_it.
10636 (compute_display_string_pos, compute_display_string_end):
10637 New functions.
10638 (push_it): Accept second argument POSITION, where pop_it should
10639 jump to continue iteration.
10640 (reseat_1): Initialize bidi_it.disp_pos.
10641
10642 * keyboard.c (adjust_point_for_property): Adjust the call to
10643 display_prop_intangible_p to its new signature.
10644
10645 * dispextern.h (struct bidi_it): New member frame_window_p.
10646 (bidi_init_it): Update prototypes.
10647 (display_prop_intangible_p): Update prototype.
10648 (compute_display_string_pos, compute_display_string_end):
10649 Declare prototypes.
10650 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10651 EMACS_INT.
10652
10653 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10654
10655 Malloc failure behavior now depends on size of allocation.
10656 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10657 * lisp.h: Change signatures accordingly.
10658 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10659 All callers changed. (Bug#8762)
10660
10661 * gnutls.c: Use Emacs's memory allocators.
10662 Without this change, the gnutls library would invoke malloc etc.
10663 directly, which causes problems on non-SYNC_INPUT hosts, and which
10664 runs afoul of improving memory_full behavior. (Bug#8761)
10665 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10666 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10667 xfree instead of the default malloc, realloc, free.
10668 (Fgnutls_boot): No need to check for memory allocation failure,
10669 since xmalloc does that for us.
10670
10671 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10672 * category.c (hash_get_category_set):
10673 * ccl.c (ccl_driver):
10674 * charset.c (Fdefine_charset_internal):
10675 * charset.h (struct charset.hash_index):
10676 * composite.c (get_composition_id, gstring_lookup_cache)
10677 (composition_gstring_put_cache):
10678 * composite.h (struct composition.hash_index):
10679 * dispextern.h (struct image.hash):
10680 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10681 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10682 (hashfn_equal, hashfn_user_defined, make_hash_table)
10683 (maybe_resize_hash_table, hash_lookup, hash_put)
10684 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10685 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10686 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10687 * image.c (make_image, search_image_cache, lookup_image)
10688 (xpm_put_color_table_h):
10689 * lisp.h (struct Lisp_Hash_Table):
10690 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10691 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10692 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10693 * alloc.c (allocate_vectorlike):
10694 Check for overflow in vector size calculations.
10695 * ccl.c (ccl_driver):
10696 Check for overflow when converting EMACS_INT to int.
10697 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10698 need to be updated by these changes.
10699 * fns.c (make_hash_table, maybe_resize_hash_table):
10700 Check for integer overflow with large hash tables.
10701 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10702 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10703 (SXHASH_REDUCE): New macro.
10704 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10705 Use it instead of discarding useful hash info with large hash values.
10706 (sxhash_float): New function.
10707 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10708 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10709 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10710 Rewrite to use FIXNUM_BITS, as this simplifies things.
10711 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10712 Adjust signatures to match updated version of code.
10713 (consing_since_gc): Now EMACS_INT, since a single hash table can
10714 use more than INT_MAX bytes.
10715
10716 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10717
10718 Make it possible to build with GCC-4.6+ -O2 -flto.
10719
10720 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10721
10722 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10723
10724 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10725 Call minibuffer-inactive-mode.
10726
10727 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10728
10729 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10730 Update dependencies.
10731
10732 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10733
10734 * data.c (init_data): Remove code for UTS, this system is not
10735 supported anymore.
10736
10737 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10738
10739 Don't force ./temacs to start in terminal mode.
10740
10741 * frame.c (make_initial_frame): Initialize faces in all cases, not
10742 only when CANNOT_DUMP is defined.
10743 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10744
10745 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10746
10747 * dispnew.c (add_window_display_history): Use const for the string
10748 pointer. Remove declaration, not needed.
10749
10750 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10751
10752 Use 'inline', not 'INLINE'.
10753 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10754 * alloc.c, fontset.c (INLINE): Remove.
10755 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10756 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10757 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10758 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10759 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10760
10761 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10762
10763 Make it possible to run ./temacs.
10764
10765 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10766 syms_of_callproc does the same thing. Remove test for
10767 "initialized", do it in the caller.
10768 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10769
10770 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10771
10772 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10773 (read_minibuf): Use get_minibuffer.
10774 (syms_of_minibuf): Use DEFSYM.
10775 (Qmetadata): New var.
10776 * data.c (Qbuffer): Don't make it static.
10777 (syms_of_data): Use DEFSYM.
10778
10779 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10780
10781 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10782 (CCL_CODE_MIN): New macro.
10783
10784 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10785
10786 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10787
10788 * eval.c (Qdebug): Now static.
10789 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10790 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10791 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10792
10793 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10794
10795 * image.c: Various fixes to ImageMagick code comments.
10796 (Fimagemagick_types): Doc fix.
10797
10798 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10799
10800 Minor fixes prompted by GCC 4.6.0 warnings.
10801
10802 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10803
10804 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10805 (x_clipboard_manager_save_all): Move extern decl to ...
10806 * xterm.h: ... here, so that it can be checked for consistency.
10807
10808 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10809
10810 * xselect.c (x_clipboard_manager_save_frame)
10811 (x_clipboard_manager_save_all): New functions.
10812 (Fx_clipboard_manager_save): Lisp function deleted.
10813
10814 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10815 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10816
10817 * xterm.h: Update prototype.
10818
10819 2011-05-28 William Xu <william.xwl@gmail.com>
10820
10821 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10822 exiting (Bug#8239).
10823
10824 2011-05-28 Jim Meyering <meyering@redhat.com>
10825
10826 Avoid a sign-extension bug in crypto_hash_function.
10827 * fns.c (to_uchar): Define.
10828 (crypto_hash_function): Use it to convert some newly-signed
10829 variables to unsigned, to avoid sign-extension bugs. For example,
10830 without this change, (md5 "truc") would evaluate to
10831 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10832 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10833 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10834
10835 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10836
10837 Integer overflow fixes.
10838
10839 * dbusbind.c: Serial number integer overflow fixes.
10840 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10841 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10842 to hold a serial number that is too large for a fixnum.
10843 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10844 Check for serial numbers out of range. Decode any serial number
10845 that was so large that it became a float. (Bug#8722)
10846
10847 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10848 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10849 Use XFASTINT rather than XUINT when numbers are nonnegative.
10850 (xd_append_arg, Fdbus_method_return_internal):
10851 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10852 arguments, check that Lisp number is nonnegative, rather than
10853 silently wrapping negative numbers around. (Bug#8722)
10854 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10855 (Bug#8722)
10856
10857 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10858
10859 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10860
10861 ccl: Add integer overflow checks.
10862 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10863 (IN_INT_RANGE): New macros.
10864 (ccl_driver): Use them to check for integer overflow when
10865 decoding a CCL program. Many of the new checks are whether XINT (x)
10866 fits in int; it doesn't always, on 64-bit hosts. The new version
10867 doesn't catch all possible integer overflows, but it's an
10868 improvement. (Bug#8719)
10869
10870 * alloc.c (make_event_array): Use XINT, not XUINT.
10871 There's no need for unsigned here.
10872
10873 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10874 This follows up to the 2011-05-06 change that substituted uintptr_t
10875 for EMACS_INT. This case wasn't caught back then.
10876
10877 Rework Fformat to avoid integer overflow issues.
10878 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10879 now (part of C89). Include <verify.h>.
10880 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10881 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10882 (Fformat): Avoid the prepass trying to compute sizes; it was only
10883 approximate and thus did not catch overflow reliably. Instead, walk
10884 through the format just once, formatting and computing sizes as we go,
10885 checking for integer overflow at every step, and allocating a larger
10886 buffer as needed. Keep track separately whether the format is
10887 multibyte. Keep only the most-recently calculated precision, rather
10888 than them all. Record whether each argument has been converted to
10889 string. Use EMACS_INT, not int, for byte and char and arg counts.
10890 Support field widths and precisions larger than INT_MAX. Avoid
10891 sprintf's undefined behavior with conversion specifications such as %#d
10892 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10893 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10894 formatting out-of-range floating point numbers with int
10895 formats. (Bug#8668)
10896
10897 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10898
10899 * data.c: Avoid integer truncation in expressions involving floats.
10900 * data.c: Include <intprops.h>.
10901 (arith_driver): When there's an integer overflow in an expression
10902 involving floating point, convert the integers to floating point
10903 so that the resulting value does not suffer from catastrophic
10904 integer truncation. For example, on a 64-bit host (* 4
10905 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10906 Do not rely on undefined behavior after integer overflow.
10907
10908 merge count_size_as_multibyte, parse_str_to_multibyte
10909 * character.c, character.h (count_size_as_multibyte):
10910 Rename from parse_str_to_multibyte; all uses changed.
10911 Check for integer overflow.
10912 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10913 since it's now a duplicate of the other. This is more of
10914 a character than a buffer op, so better that it's in character.c.
10915 * fns.c, print.c: Adjust to above changes.
10916
10917 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10918
10919 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10920
10921 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10922
10923 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10924 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10925 (x_clipboard_manager_save): Now static.
10926 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10927
10928 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10929 (crypto_hash_function): Now static.
10930 Fix pointer signedness problems. Avoid unnecessary initializations.
10931
10932 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10933
10934 * termhooks.h (Vselection_alist): Make it terminal-local.
10935
10936 * terminal.c (create_terminal): Initialize it.
10937
10938 * xselect.c: Support for clipboard managers.
10939 (Vselection_alist): Move to termhooks.h as terminal-local var.
10940 (LOCAL_SELECTION): New macro.
10941 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10942 (symbol_to_x_atom): Remove gratuitous arg.
10943 (x_handle_selection_request, lisp_data_to_selection_data)
10944 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10945 (x_own_selection, x_get_local_selection, x_convert_selection):
10946 New arg, specifying work frame. Use terminal-local Vselection_alist.
10947 (some_frame_on_display): Delete unused function.
10948 (Fx_own_selection_internal, Fx_get_selection_internal)
10949 (Fx_disown_selection_internal, Fx_selection_owner_p)
10950 (Fx_selection_exists_p): New optional frame arg.
10951 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10952 (x_handle_selection_clear): Don't treat other terminals with the
10953 same keyboard specially. Use the terminal-local Vselection_alist.
10954 (x_clear_frame_selections): Use Frun_hook_with_args.
10955
10956 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10957
10958 * xterm.h: Add support for those atoms.
10959
10960 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10961
10962 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10963 (converted_selections, conversion_fail_tag): New global variables.
10964 (x_selection_request_lisp_error): Free the above.
10965 (x_get_local_selection): Remove unnecessary code.
10966 (x_reply_selection_request): Args changed; handle arbitrary array
10967 of converted selections stored in converted_selections.
10968 Separate the XChangeProperty and SelectionNotify steps.
10969 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10970 (x_convert_selection): New function.
10971 (x_handle_selection_event): Simplify.
10972 (x_get_foreign_selection): Don't ignore incoming requests while
10973 waiting for an answer; this will fail when we implement
10974 SAVE_TARGETS, and seems unnecessary anyway.
10975 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10976 (Vx_sent_selection_functions): Doc fix.
10977
10978 2011-05-26 Leo Liu <sdl.web@gmail.com>
10979
10980 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10981
10982 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10983
10984 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10985
10986 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10987 for fringe update if it has periodic bitmap.
10988 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10989 and fringe_bitmap_periodic_p.
10990
10991 * fringe.c (get_fringe_bitmap_data): New function.
10992 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10993 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10994 row. Mark glyph row for fringe update if periodicity changed.
10995
10996 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10997 for fringe update unless it has periodic bitmap.
10998
10999 2011-05-25 Kenichi Handa <handa@m17n.org>
11000
11001 * xdisp.c (get_next_display_element): Set correct it->face_id for
11002 a static composition.
11003
11004 2011-05-24 Leo Liu <sdl.web@gmail.com>
11005
11006 * deps.mk (fns.o):
11007 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11008
11009 * fns.c (crypto_hash_function, Fsha1): New function.
11010 (Fmd5): Use crypto_hash_function.
11011 (syms_of_fns): Add Ssha1.
11012
11013 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11014
11015 * gnutls.c: Remove unused macros.
11016 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11017 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11018 Remove macros that are defined and never used.
11019 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11020
11021 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11022
11023 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11024 (Fx_get_selection_internal): Minor cleanup.
11025 (Fx_own_selection_internal): Rename arguments for consistency with
11026 select.el.
11027
11028 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11029
11030 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11031
11032 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11033
11034 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11035
11036 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11037
11038 * dispnew.c (scrolling_window): Don't exclude the case that the
11039 last enabled row in the desired matrix touches the bottom boundary.
11040
11041 2011-05-21 Glenn Morris <rgm@gnu.org>
11042
11043 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11044 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11045 and add some more files.
11046
11047 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11048
11049 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11050 report_file_error introduced by the change from 2011-05-07.
11051
11052 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11053
11054 * systime.h (Time): Define only if emacs is defined.
11055 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11056 where the include path doesn't have X11/X.h by default. See
11057 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11058
11059 2011-05-20 Kenichi Handa <handa@m17n.org>
11060
11061 * composite.c (find_automatic_composition): Fix previous change.
11062
11063 2011-05-20 Glenn Morris <rgm@gnu.org>
11064
11065 * lisp.mk: New file, split from Makefile.in.
11066 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11067 (shortlisp): Remove.
11068 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11069
11070 2011-05-19 Glenn Morris <rgm@gnu.org>
11071
11072 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11073 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11074 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11075 (lisp): Set the order to that of loadup.el.
11076 (shortlisp): Make it a copy of $lisp.
11077 (SOME_MACHINE_LISP): Remove.
11078 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11079 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11080
11081 2011-05-18 Kenichi Handa <handa@m17n.org>
11082
11083 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11084 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11085 (find_automatic_composition): Mostly rewrite for efficiency.
11086
11087 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11088
11089 * makefile.w32-in: Update dependencies.
11090
11091 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11092
11093 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11094 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11095
11096 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11097
11098 Fix some integer overflow issues, such as string length overflow.
11099
11100 * insdel.c (count_size_as_multibyte): Check for string overflow.
11101
11102 * character.c (lisp_string_width): Check for string overflow.
11103 Use EMACS_INT, not int, for string indexes and lengths; in
11104 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11105 the resulting string length overflows an EMACS_INT; instead,
11106 report a string overflow if no precision given. When checking for
11107 precision exhaustion, use a check that cannot possibly have
11108 integer overflow. (Bug#8675)
11109 * character.h (lisp_string_width): Adjust to new signature.
11110
11111 * alloc.c (string_overflow): New function.
11112 (Fmake_string): Use it. This doesn't change behavior, but saves
11113 a few bytes and will simplify future changes.
11114 * character.c (string_escape_byte8): Likewise.
11115 * lisp.h (string_overflow): New decl.
11116
11117 Fixups, following up to the user-interface timestamp change.
11118 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11119 for UI timestamps, instead of unsigned long.
11120 * msdos.c (mouse_get_pos): Likewise.
11121 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11122 * w32gui.h (Time): Define by including "systime.h" rather than by
11123 declaring it ourselves. (Bug#8664)
11124
11125 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11126 * image.c (clear_image_cache): Likewise.
11127
11128 * term.c (term_mouse_position): Don't assume time_t wraparound.
11129
11130 Be more systematic about user-interface timestamps.
11131 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11132 and sometimes 'EMACS_UINT', to represent these timestamps.
11133 This change causes it to use 'Time' uniformly, as that's what X uses.
11134 This makes the code easier to follow, and makes it easier to catch
11135 integer overflow bugs such as Bug#8664.
11136 * frame.c (Fmouse_position, Fmouse_pixel_position):
11137 Use Time, not unsigned long, for user-interface timestamps.
11138 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11139 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11140 * keyboard.h (last_event_timestamp): Likewise.
11141 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11142 * menu.h (xmenu_show): Likewise.
11143 * term.c (term_mouse_position): Likewise.
11144 * termhooks.h (struct input_event.timestamp): Likewise.
11145 (struct terminal.mouse_position_hook): Likewise.
11146 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11147 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11148 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11149 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11150 what it was before.
11151 * menu.h, termhooks.h: Include "systime.h", for Time.
11152
11153 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11154 Don't assume that the difference between two unsigned long values
11155 can fit into an integer. At this point, we know button_down_time
11156 <= event->timestamp, so the difference must be nonnegative, so
11157 there's no need to cast the result if double-click-time is
11158 nonnegative, as it should be; check that it's nonnegative, just in
11159 case. This bug is triggered when events are more than 2**31 ms
11160 apart (about 25 days). (Bug#8664)
11161
11162 * xselect.c (last_event_timestamp): Remove duplicate decl.
11163 (x_own_selection): Remove needless cast to unsigned long.
11164
11165 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11166 that always fit in int. Use a sentinel instead of a counter, to
11167 avoid a temp and to allay GCC's concerns about possible int overflow.
11168 * frame.h (struct frame): Use int for menu_bar_items_used
11169 instead of EMACS_INT, since it always fits in int.
11170
11171 * menu.c (grow_menu_items): Check for int overflow.
11172
11173 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11174
11175 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11176 Before, the code was not consistent. These values cannot exceed
11177 2**31 - 1 so there's no need to make them unsigned.
11178 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11179 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11180 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11181 as modifiers.
11182 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11183
11184 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11185 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11186 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11187 presumably because the widths might not match.
11188
11189 * window.c (size_window): Avoid needless test at loop start.
11190
11191 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11192
11193 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11194
11195 2011-05-12 Drew Adams <drew.adams@oracle.com>
11196
11197 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11198
11199 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11200
11201 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11202 `width' to `bar_area_x' and `bar_area_width', respectively.
11203 (x_scroll_run): Take account of fringe background extension.
11204
11205 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11206 Rename local vars `left' and `width' to `bar_area_x' and
11207 `bar_area_width', respectively.
11208 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11209 background extension.
11210
11211 2011-05-10 Jim Meyering <meyering@redhat.com>
11212
11213 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11214
11215 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11216
11217 * image.c (Finit_image_library): Return t for built-in image types,
11218 like pbm and xbm. (Bug#8640)
11219
11220 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11221
11222 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11223
11224 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11225
11226 * w32console.c (Fset_screen_color): Doc fix.
11227 (Fget_screen_color): New function.
11228 (syms_of_ntterm): Defsubr it.
11229
11230 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11231 unlink the temporary file if Fcall_process didn't create it in the
11232 first place.
11233 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11234 child process will be redirected to a file specified with `:file'.
11235 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11236 cue to call_process_cleanup not to close that handle.
11237
11238 2011-05-07 Ben Key <bkey76@gmail.com>
11239
11240 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11241 one of two shell specific rules, either bootstrap-temacs-CMD or
11242 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11243 to the previous implementation of the bootstrap-temacs rule.
11244 The bootstrap-temacs-CMD rule is similar to the previous
11245 implementation of the bootstrap-temacs rule except that it
11246 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11247 variable.
11248
11249 These changes, along with some changes to nt/configure.bat,
11250 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11251 earlier fix to add support for --cflags and --ldflags options
11252 that include quotes so that it works whether make uses cmd or
11253 sh as the shell.
11254
11255 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11256
11257 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11258 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11259 is a constant.
11260 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11261 a string. Handle both cases.
11262 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11263 (Fdbus_register_method): Use Qinvalid_function.
11264
11265 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11266
11267 * makefile.w32-in: Update dependencies.
11268 (LISP_H): Add inttypes.h and stdin.h.
11269 (PROCESS_H): Add unistd.h.
11270
11271 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11272
11273 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11274 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11275
11276 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11277
11278 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11279
11280 * term.c (vfatal): Remove stray call to va_end.
11281 It's not needed and the C Standard doesn't allow it here anyway.
11282
11283 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11284 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11285
11286 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11287 bytes.
11288
11289 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11290
11291 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11292
11293 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11294
11295 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11296
11297 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11298
11299 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11300 * charset.c (Fdefine_charset_internal): Don't initialize
11301 charset.code_space[15]. The value was garbage, on hosts with
11302 32-bit int (Bug#8600).
11303
11304 * lread.c (read_integer): Be more consistent with string-to-number.
11305 Use string_to_number to do the actual conversion; this avoids
11306 rounding errors and fixes some other screwups. Without this fix,
11307 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11308 (digit_to_number): Move earlier, for benefit of read_integer.
11309 Return -1 if the digit is out of range for the base, -2 if it is
11310 not a digit in any supported base. (Bug#8602)
11311
11312 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11313
11314 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11315 to match comment at start of function. This also removes a
11316 GCC warning about overflow in a 32+64-bit port.
11317
11318 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11319
11320 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11321 Reported by Stefan Monnier in
11322 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11323 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11324 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11325
11326 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11327 (EMACS_UINTPTR): Likewise, with uintptr_t.
11328
11329 * lisp.h: Prefer 64-bit EMACS_INT if available.
11330 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11331 on 32-bit hosts that have 64-bit int, so that they can access
11332 large files.
11333 However, temporarily disable this change unless the temporary
11334 symbol WIDE_EMACS_INT is defined.
11335
11336 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11337
11338 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11339 This removes an assumption that EMACS_INT and long are the same
11340 width as pointers. The assumption is true for Emacs porting targets
11341 now, but we want to make other targets possible.
11342 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11343 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11344 In the rest of the code, change types of integers that hold casted
11345 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11346 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11347 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11348 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11349 No need to cast type when ORing.
11350 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11351 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11352 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11353 assume EMACS_INT is the same width as char *.
11354 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11355 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11356 Remove no-longer-needed casts.
11357 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11358 (xg_tool_bar_help_callback, xg_make_tool_item):
11359 Use EMACS_INTPTR to hold an integer
11360 that will be cast to void *; this can avoid a GCC warning
11361 if EMACS_INT is not the same width as void *.
11362 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11363 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11364 (current_message_1, set_message_1):
11365 Use a local to convert to proper width without a cast.
11366 * xmenu.c (dialog_selection_callback): Likewise.
11367
11368 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11369 Also, don't assume VALBITS / RAND_BITS is less than 5,
11370 and don't rely on undefined behavior when shifting a 1 left into
11371 the sign bit.
11372 * lisp.h (get_random): Change signature to match.
11373
11374 * lread.c (hash_string): Use size_t, not int, for hash computation.
11375 Normally we prefer signed values; but hashing is special, because
11376 it's better to use unsigned division on hash table sizes so that
11377 the remainder is nonnegative. Also, size_t is the natural width
11378 for hashing into memory. The previous code used 'int', which doesn't
11379 retain enough info to hash well into very large tables.
11380 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11381
11382 * dbusbind.c: Don't possibly lose pointer info when converting.
11383 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11384 Use XPNTR rather than XHASH, so that the high-order bits of
11385 the pointer aren't lost when converting through void *.
11386
11387 * eval.c (Fautoload): Don't double-shift a pointer.
11388
11389 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11390
11391 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11392
11393 * gnutls.c (DEF_GNUTLS_FN):
11394 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11395
11396 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11397
11398 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11399 marker. (Bug#8610)
11400
11401 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11402
11403 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11404 New version that can reserve upto 2GB of heap space.
11405
11406 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11407
11408 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11409
11410 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11411
11412 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11413 `gnutls_certificate_set_x509_key_file'.
11414
11415 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11416
11417 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11418 Update dependencies.
11419
11420 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11421
11422 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11423 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11424 Remove unused parameter `fildes'.
11425 * process.c (read_process_output, send_process): Don't pass it.
11426
11427 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11428
11429 Fix previous change: the library cache is defined in w32.c.
11430 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11431 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11432
11433 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11434
11435 Implement dynamic loading of GnuTLS on Windows.
11436
11437 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11438 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11439 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11440 Declare.
11441
11442 * gnutls.c (Qgnutls_dll): Define.
11443 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11444 (gnutls_*): Declare function pointers.
11445 (init_gnutls_functions): New function to initialize function pointers.
11446 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11447 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11448 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11449 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11450 (emacs_gnutls_write, emacs_gnutls_read)
11451 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11452 (Fgnutls_available_p): New function.
11453 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11454 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11455 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11456
11457 * image.c: Include w32.h.
11458 (Vimage_type_cache): Delete.
11459 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11460 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11461 (w32_delayed_load): Move to w32.c.
11462
11463 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11464
11465 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11466 (w32_delayed_load): Move from image.c. When loading a library, record
11467 its filename in the :loaded-from property of the library id.
11468 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11469 Initialize and staticpro them.
11470 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11471
11472 * process.c: Include lisp.h before w32.h, not after.
11473 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11474 instead of gnutls_record_check_pending.
11475
11476 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11477
11478 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11479
11480 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11481 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11482 as passed in.
11483
11484 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11485
11486 * xterm.c (x_set_frame_alpha): Do not set property on anything
11487 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11488
11489 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11490
11491 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11492
11493 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11494
11495 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11496 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11497 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11498 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11499 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11500 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11501 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11502 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11503 (Qgnutls_bootprop_callbacks_verify): Make static.
11504
11505 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11506
11507 * callproc.c: Indentation fixup.
11508
11509 * sysdep.c (wait_for_termination_1): Make static.
11510 (wait_for_termination, interruptible_wait_for_termination):
11511 Move after wait_for_termination_1.
11512
11513 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11514
11515 * sysdep.c (interruptible_wait_for_termination): New function
11516 which is like wait_for_termination, but allows keyboard
11517 interruptions.
11518
11519 * callproc.c (Fcall_process): Add (:file "file") as an option for
11520 the STDOUT buffer.
11521 (Fcall_process_region): Ditto.
11522
11523 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11524
11525 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11526 rather than `XVECTOR (FOO)->size'.
11527
11528 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11529 inttypes.h, as a gnulib replacement is used if it not available in
11530 system headers.
11531
11532 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11533
11534 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11535 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11536 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11537
11538 * coding.c (coding_alloc_by_realloc): Error out if destination
11539 will grow beyond MOST_POSITIVE_FIXNUM.
11540 (decode_coding_emacs_mule): Abort if there isn't enough place in
11541 charbuf for the composition carryover bytes. Reserve an extra
11542 space for up to 2 characters produced in a loop.
11543 (decode_coding_iso_2022): Abort if there isn't enough place in
11544 charbuf for the composition carryover bytes.
11545
11546 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11547
11548 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11549 aborting when %lld or %lll format is passed.
11550 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11551 %llo or %llx format is passed. (Bug#8545)
11552
11553 * window.c (window_scroll_line_based): Use a marker instead of
11554 simple variables to record original value of point. (Bug#7952)
11555
11556 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11557 produced by %s or %c overflows available buffer space. (Bug#8545)
11558
11559 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11560
11561 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11562 (SIZE_MAX): Move defn after all includes, as they might #define it.
11563
11564 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11565
11566 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11567
11568 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11569
11570 * keyboard.c (Qdelayed_warnings_hook): Define.
11571 (command_loop_1): Run `delayed-warnings-hook'
11572 if Vdelayed_warnings_list is non-nil.
11573 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11574 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11575
11576 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11577
11578 * doprnt.c (doprnt): Don't return value smaller than the buffer
11579 size if the message was truncated. (Bug#8545).
11580
11581 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11582
11583 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11584 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11585
11586 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11587
11588 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11589
11590 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11591
11592 * makefile.w32-in: Update dependencies.
11593
11594 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11595
11596 Improve `doprnt' and its usage. (Bug#8545)
11597 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11598 `format_end'. Remove support for %l as a conversion specifier.
11599 Don't use xrealloc. Improve diagnostics when the %l size modifier
11600 is used. Update the commentary.
11601
11602 * eval.c (verror): Simplify calculation of size_t.
11603
11604 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11605 messages.
11606
11607 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11608
11609 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11610 change.
11611
11612 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11613
11614 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11615 This makes this file independent of the recent pseudovector change.
11616
11617 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11618
11619 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11620
11621 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11622 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11623 Remove unused local.
11624 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11625
11626 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11627 GCC 4.6.0 optimizes based on type-based alias analysis.
11628 For example, if b is of type struct buffer * and v of type struct
11629 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11630 != &v->size, and therefore "v->size = 1; b->size = 2; return
11631 v->size;" must therefore return 1. This assumption is incorrect
11632 for Emacs, since it type-puns struct Lisp_Vector * with many other
11633 types. To fix this problem, this patch adds a new type struct
11634 vectorlike_header that documents the constraints on layout of vectors
11635 and pseudovectors, and helps optimizing compilers not get fooled
11636 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11637 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11638 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11639 the size member.
11640 (XSETPVECTYPE): Rewrite in terms of new macro.
11641 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11642 This is a bit clearer, and further avoids the possibility of
11643 undesirable aliasing.
11644 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11645 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11646 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11647 since Lisp_Subr is a special case (no "next" field).
11648 (ASIZE): Now uses header.size rather than size.
11649 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11650 to avoid the hassle of writing XVECTOR (foo)->header.size.
11651 (struct vectorlike_header): New type.
11652 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11653 object, to help avoid aliasing.
11654 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11655 (SUBRP): Likewise, since Lisp_Subr is a special case.
11656 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11657 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11658 (struct Lisp_Hash_Table): Combine first two members into a single
11659 struct vectorlike_header member. All uses of "size" and "next" members
11660 changed to be "header.size" and "header.next".
11661 * buffer.h (struct buffer): Likewise.
11662 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11663 * frame.h (struct frame): Likewise.
11664 * process.h (struct Lisp_Process): Likewise.
11665 * termhooks.h (struct terminal): Likewise.
11666 * window.c (struct save_window_data, struct saved_window): Likewise.
11667 * window.h (struct window): Likewise.
11668 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11669 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11670 * buffer.c (init_buffer_once): Likewise.
11671 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11672 special case.
11673 * process.c (Fformat_network_address): Use local var for size,
11674 for brevity.
11675
11676 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11677
11678 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11679 * data.c (atof): Remove decl; no longer used or needed.
11680 (digit_to_number): Move to lread.c.
11681 (Fstring_to_number): Use new string_to_number function, to be
11682 consistent with how the Lisp reader treats infinities and NaNs.
11683 Do not assume that floating-point numbers represent EMACS_INT
11684 without losing information; this is not true on most 64-bit hosts.
11685 Avoid double-rounding errors, by insisting on integers when
11686 parsing non-base-10 numbers, as the documentation specifies.
11687 * lisp.h (string_to_number): New decl, replacing ...
11688 (isfloat_string): Remove.
11689 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11690 (read1): Do not accept +. and -. as integers; this
11691 appears to have been a coding error. Similarly, do not accept
11692 strings like +-1e0 as floating point numbers. Do not report
11693 overflow for integer overflows unless the base is not 10 which
11694 means we have no simple and reliable way to continue.
11695 Break out the floating-point parsing into a new
11696 function string_to_number, so that Fstring_to_number parses
11697 floating point numbers consistently with the Lisp reader.
11698 (digit_to_number): Move here from data.c. Make it static inline.
11699 (E_CHAR, EXP_INT): Remove, replacing with ...
11700 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11701 (string_to_number): New function, replacing isfloat_string.
11702 This function checks for valid syntax and produces the resulting
11703 Lisp float number too. Rework it so that string-to-number
11704 no longer mishandles examples like "1.0e+". Use strtoumax,
11705 so that overflow for non-base-10 numbers is reported only when
11706 there's no portable and simple way to convert to floating point.
11707
11708 * textprop.c (set_text_properties_1): Rewrite for clarity,
11709 and to avoid GCC warning about integer overflow.
11710
11711 * intervals.h (struct interval): Use EMACS_INT for members
11712 where EMACS_UINT might cause problems. See
11713 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11714 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11715 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11716 All uses changed.
11717 (offset_intervals): Tell GCC not to worry about length overflow
11718 when negating a negative length.
11719
11720 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11721 (overrun_check_free): Likewise.
11722
11723 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11724 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11725 word size.
11726
11727 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11728 (gnutls_make_error): Rename local to avoid shadowing.
11729 (gnutls_emacs_global_deinit): ifdef out; not used.
11730 (Fgnutls_boot): Use const for pointer to readonly storage.
11731 Comment out unused local. Fix pointer signedness problems.
11732
11733 * lread.c (openp): Don't stuff size_t into an 'int'.
11734 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11735 about possible signed overflow.
11736
11737 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11738 (GDK_KEY_g): Don't define if already defined.
11739 (xg_prepare_tooltip): Avoid pointer signedness problem.
11740 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11741
11742 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11743 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11744
11745 * xfns.c (Fx_window_property): Simplify a bit,
11746 to make a bit faster and to avoid GCC 4.6.0 warning.
11747 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11748
11749 * fns.c (internal_equal): Don't assume size_t fits in int.
11750
11751 * alloc.c (compact_small_strings): Tighten assertion a little.
11752
11753 Replace pEd with more-general pI, and fix some printf arg casts.
11754 * lisp.h (pI): New macro, generalizing old pEd macro to other
11755 conversion specifiers. For example, use "...%"pI"d..." rather
11756 than "...%"pEd"...".
11757 (pEd): Remove. All uses replaced with similar uses of pI.
11758 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11759 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11760 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11761 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11762 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11763 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11764 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11765 64-bit hosts.
11766 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11767 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11768 * print.c (safe_debug_print, print_object): Likewise.
11769 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11770 to int.
11771 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11772 avoiding the 0 flag, which is not portable.
11773 * process.c (Fmake_network_process): Use pI to avoid cast.
11774 * region-cache.c (pp_cache): Likewise.
11775 * xdisp.c (decode_mode_spec): Likewise.
11776 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11777 behavior on 64-bit hosts with printf arg.
11778 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11779 (x_stop_queuing_selection_requests): Likewise.
11780 (x_get_window_property): Don't truncate byte count to an 'int'
11781 when tracing.
11782
11783 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11784 here, since it parses constructs like leading '-' and spaces,
11785 which are not wanted; and it overflows with large numbers.
11786 Instead, simply match F[0-9]+, which is what is wanted anyway.
11787
11788 * alloc.c: Remove unportable assumptions about struct layout.
11789 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11790 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11791 (allocate_vectorlike, make_pure_vector): Use the new macros,
11792 plus offsetof, to remove unportable assumptions about struct layout.
11793 These assumptions hold on all porting targets that I know of, but
11794 they are not guaranteed, they're easy to remove, and removing them
11795 makes further changes easier.
11796
11797 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11798 This doesn't fix a bug but makes the code clearer.
11799 (string_overrun_cookie): Now const. Use initializers that
11800 don't formally overflow signed char, to avoid warnings.
11801 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11802 can cause Emacs to crash when string overrun checking is enabled.
11803 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11804 multiple of sizeof (EMACS_INT); it need not be, if
11805 alignof(EMACS_INT) < sizeof (EMACS_INT).
11806 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11807
11808 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11809
11810 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11811
11812 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11813
11814 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11815 supposed to be handshaking. (Bug#8556)
11816 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11817
11818 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11819
11820 * lisp.h (Qdebug): List symbol.
11821 * eval.c (Qdebug): Restore global linkage.
11822 * keyboard.c (debug-on-event): New variable.
11823 (handle_user_signal): Break into debugger when debug-on-event
11824 matches the current signal symbol.
11825
11826 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11827
11828 * alloc.c (check_sblock, check_string_bytes)
11829 (check_string_free_list): Convert to standard C.
11830
11831 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11832
11833 * w32.c (emacs_gnutls_push): Fix typo.
11834
11835 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11836
11837 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11838 "cast to pointer from integer of different size".
11839
11840 Improve doprnt and its use in verror. (Bug#8545)
11841 * doprnt.c (doprnt): Document the set of format control sequences
11842 supported by the function. Use SAFE_ALLOCA instead of always
11843 using `alloca'.
11844
11845 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11846 is one byte too soon. Don't use xrealloc; instead xfree and
11847 xmalloc anew.
11848
11849 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11850
11851 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11852 callbacks stage.
11853
11854 * gnutls.c: Renamed global_initialized to
11855 gnutls_global_initialized. Added internals for the
11856 :verify-hostname-error, :verify-error, and :verify-flags
11857 parameters of `gnutls-boot' and documented those parameters in the
11858 docstring. Start callback support.
11859 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11860 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11861 on error. Return error code.
11862 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11863 (emacs_gnutls_read): Likewise.
11864 (Fgnutls_boot): Return handshake error code.
11865 (emacs_gnutls_handle_error): New function.
11866 (wsaerror_to_errno): Likewise.
11867
11868 * w32.h (emacs_gnutls_pull): Add prototype.
11869 (emacs_gnutls_push): Likewise.
11870
11871 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11872 (emacs_gnutls_push): Likewise.
11873
11874 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11875
11876 * process.c (wait_reading_process_output): Check if GnuTLS
11877 buffered some data internally if no FDs are set for TLS
11878 connections.
11879
11880 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11881 (LIBS): Link to USER_LIBS.
11882 ($(BLD)/gnutls.$(0)): New target.
11883
11884 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11885
11886 * xdisp.c (handle_single_display_spec): Rename the
11887 display_replaced_before_p argument into display_replaced_p, to
11888 make it consistent with the commentary. Fix typos in the
11889 commentary.
11890
11891 * textprop.c (syms_of_textprop): Remove dead code.
11892 (copy_text_properties): Delete obsolete commentary about an
11893 interface that was deleted long ago. Fix typos in the description
11894 of arguments.
11895
11896 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11897 to changes in oldXMenu/XMenu.h from 2011-04-16.
11898 <menu_help_message, prev_menu_help_message>: Constify.
11899 (IT_menu_make_room): menu->help_text is now `const char **';
11900 adjust.
11901
11902 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11903 to changes in oldXMenu/XMenu.h from 2011-04-16.
11904 (struct XMenu): Declare `help_text' `const char **'.
11905
11906 * xfaces.c <Qunspecified>: Make extern again.
11907
11908 * syntax.c: Include sys/types.h before including regex.h, as
11909 required by POSIX.
11910
11911 * doc.c (get_doc_string): Improve the format passed to `error'.
11912
11913 * doprnt.c (doprnt): Improve commentary.
11914
11915 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11916
11917 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11918 them with etags.
11919
11920 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11921 changes in globals.h immediately force recompilation.
11922 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11923 $(CURDIR)/s/ms-w32.h.
11924 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11925
11926 * character.c (Fchar_direction): Function deleted.
11927 (syms_of_character): Don't defsubr it.
11928 <char-direction-table>: Deleted.
11929
11930 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11931
11932 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11933 * doprnt.c: Include limits.h.
11934 (SIZE_MAX): New macro.
11935 (doprnt): Return a size_t value. 2nd arg is now size_t.
11936 Many local variables are now size_t instead of int or unsigned.
11937 Improve overflow protection. Support `l' modifier for integer
11938 conversions. Support %l conversion. Don't assume an EMACS_INT
11939 argument for integer conversions and for %c.
11940
11941 * lisp.h (doprnt): Restore prototype.
11942
11943 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11944 $(SRC)/character.h.
11945
11946 * Makefile.in (base_obj): Add back doprnt.o.
11947
11948 * deps.mk (doprnt.o): Add back prerequisites.
11949 (callint.o): Depend on character.h.
11950
11951 * eval.c (internal_lisp_condition_case): Include the handler
11952 representation in the error message.
11953 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11954 when breaking from the loop.
11955
11956 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11957
11958 * callint.c (Fcall_interactively): When displaying error message
11959 about invalid control letter, pass the character's codepoint, not
11960 a pointer to its multibyte form. Improve display of the character
11961 in octal and display also its hex code.
11962
11963 * character.c (char_string): Use %x to display the (unsigned)
11964 codepoint of an invalid character, to avoid displaying a bogus
11965 negative value.
11966
11967 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11968 `error', not SYMBOL_NAME itself.
11969
11970 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11971 character arguments to `error'.
11972
11973 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11974 to `error' in error message about FINAL_CHAR argument. Make sure
11975 FINAL_CHAR is a character, and use %c when it is passed as
11976 argument to `error'.
11977
11978 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11979
11980 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11981
11982 * w32.c: Include <time.h>.
11983 (sys_localtime): New function.
11984
11985 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11986
11987 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11988
11989 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11990
11991 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11992
11993 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11994 zombies (Bug#8467).
11995
11996 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11997
11998 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11999 gl_state.e_property when gl_state.object is Qt.
12000
12001 * insdel.c (make_gap_larger): Remove limitation of buffer size
12002 to <= INT_MAX.
12003
12004 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12005
12006 * xdisp.c (lookup_glyphless_char_display)
12007 (produce_glyphless_glyph): Handle cons cell entry in
12008 glyphless-char-display.
12009 (Vglyphless_char_display): Document it.
12010
12011 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12012 glyphless-char-display.
12013
12014 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12015
12016 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12017
12018 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12019
12020 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12021 definition for no-X builds.
12022
12023 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12024
12025 Static checks with GCC 4.6.0 and non-default toolkits.
12026
12027 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12028
12029 * process.c (keyboard_bit_set): Define only if SIGIO.
12030 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12031 (send_process): Repair possible setjmp clobbering.
12032
12033 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12034
12035 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12036
12037 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12038
12039 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12040 Define only if needed.
12041
12042 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12043 by pacifying GCC about it. Maybe it's time to retire it?
12044 * xfaces.c (USG, __TIMEVAL__): Likewise.
12045
12046 * dispextern.h (struct redisplay_interface): Rename param
12047 to avoid shadowing.
12048 * termhooks.h (struct terminal): Likewise.
12049 * xterm.c (xembed_send_message): Likewise.
12050
12051 * insdel.c (make_gap_smaller): Define only if
12052 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12053
12054 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12055 it.
12056
12057 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12058 so that we aren't warned about unused symbols.
12059
12060 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12061
12062 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12063
12064 * xfns.c (x_real_positions): Mark locals as initialized.
12065
12066 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12067
12068 * xterm.c: Fix problems found by static analysis with other toolkits.
12069 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12070 (x_dispatch_event): Declare static if USE_GTK, and
12071 define if USE_GTK || USE_X_TOOLKIT.
12072 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12073 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12074 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12075 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12076
12077 * xmenu.c (menu_help_callback): Pointer type fixes.
12078 Use const pointers when pointing at readonly data. Avoid pointer
12079 signedness clashes.
12080 (FALSE): Remove unused macro.
12081 (update_frame_menubar): Remove unused decl.
12082
12083 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12084
12085 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12086 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12087 (single_menu_item): Rename local to avoid shadowing.
12088
12089 * keyboard.c (make_lispy_event): Remove unused local var.
12090
12091 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12092 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12093
12094 * bitmaps: Change bitmaps from unsigned char back to the X11
12095 compatible char. Avoid the old compiler warnings about
12096 out-of-range initializers by using, for example, '\xab' rather
12097 than 0xab.
12098
12099 * xgselect.c (xgselect_initialize): Check vs interface
12100 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12101
12102 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12103
12104 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12105 to read-only memory.
12106
12107 * fns.c (vector): Remove; this old hack is no longer needed.
12108
12109 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12110 Remove unused var.
12111 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12112
12113 * xrdb.c (x_load_resources): Omit unused local.
12114
12115 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12116 (x_window): Rename locals to avoid shadowing.
12117 (USG): Use the kludged USG macro, to pacify gcc.
12118
12119 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12120 (x_term_init): Remove local to avoid shadowing.
12121
12122 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12123
12124 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12125 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12126
12127 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12128
12129 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12130
12131 Fix regex.c, syntax.c and friends for buffers > 2GB.
12132 * syntax.h (struct gl_state_s): Declare character position members
12133 EMACS_INT.
12134
12135 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12136
12137 * textprop.c (verify_interval_modification, interval_of):
12138 Declare arguments EMACS_INT.
12139
12140 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12141 EMACS_INT.
12142
12143 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12144
12145 * indent.c (Fvertical_motion): Local variable it_start is now
12146 EMACS_INT.
12147
12148 * regex.c (re_match, re_match_2, re_match_2_internal)
12149 (bcmp_translate, regcomp, regexec, print_double_string)
12150 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12151 (re_compile_pattern, re_exec): Declare arguments and local
12152 variables `size_t' and `ssize_t' and return values `regoff_t', as
12153 appropriate.
12154 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12155 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12156 <compile_stack_type>: `size' and `avail' are now `size_t'.
12157
12158 * regex.h <regoff_t>: Use ssize_t, not int.
12159 (re_search, re_search_2, re_match, re_match_2): Arguments that
12160 specify buffer/string position and length are now ssize_t and
12161 size_t. Return type is regoff_t.
12162
12163 2011-04-16 Ben Key <bkey76@gmail.com>
12164
12165 * nsfont.m: Fixed bugs in ns_get_family and
12166 ns_descriptor_to_entity that were caused by using free to
12167 deallocate memory blocks that were allocated by xmalloc (via
12168 xstrdup). This caused Emacs to crash when compiled with
12169 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12170 --enable-checking=xmallocoverrun). xfree is now used to
12171 deallocate these memory blocks.
12172
12173 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12174
12175 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12176
12177 emacs_write: Accept and return EMACS_INT for sizes.
12178 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12179 et seq.
12180 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12181 Accept and return EMACS_INT.
12182 (emacs_gnutls_write): Return the number of bytes written on
12183 partial writes.
12184 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12185 (emacs_read, emacs_write): Remove check for negative size, as the
12186 Emacs source code has been audited now.
12187 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12188 (emacs_read, emacs_write): Use it.
12189 * process.c (send_process): Adjust to the new signatures of
12190 emacs_write and emacs_gnutls_write. Do not attempt to store
12191 a byte offset into an 'int'; it might overflow.
12192 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12193
12194 * sound.c: Don't assume sizes fit in 'int'.
12195 (struct sound_device.period_size, alsa_period_size):
12196 Return EMACS_INT, not int.
12197 (struct sound_device.write, vox_write, alsa_write):
12198 Accept EMACS_INT, not int.
12199 (wav_play, au_play): Use EMACS_INT to store sizes and to
12200 record read return values.
12201
12202 2011-04-15 Ben Key <bkey76@gmail.com>
12203
12204 * keyboard.c (Qundefined): Don't declare static since it is used
12205 in nsfns.m.
12206 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12207 static since they are used in nsfont.m.
12208
12209 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12210
12211 * process.c (Qprocessp): Don't declare static.
12212 * lisp.h (Qprocessp): Declare again.
12213
12214 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12215
12216 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12217
12218 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12219
12220 Improve C-level modularity by making more things 'static'.
12221
12222 Don't publish debugger-only interfaces to other modules.
12223 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12224 (verify_bytepos, count_markers): Move decls to the only modules
12225 that need them.
12226 * region-cache.h (pp_cache): Likewise.
12227 * window.h (check_all_windows): Likewise.
12228 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12229
12230 * sysdep.c (croak): Now static, if
12231 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12232 * syssignal.h (croak): Declare only if not static.
12233
12234 * alloc.c (refill_memory_reserve): Now static if
12235 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12236 * lisp.h (refill_memory_reserve): Declare only if not static.
12237
12238 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12239 Define only if USE_LUCID.
12240
12241 * xrdb.c (x_customization_string, x_rm_string): Now static.
12242
12243 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12244 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12245
12246 * xdisp.c (draw_row_with_mouse_face): Now static.
12247 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12248
12249 * window.h (check_all_windows): Mark externally visible.
12250
12251 * window.c (window_deletion_count): Now static.
12252
12253 * undo.c: Make symbols static if they're not exported.
12254 (last_undo_buffer, last_boundary_position, pending_boundary):
12255 Now static.
12256
12257 * textprop.c (interval_insert_behind_hooks): Now static.
12258 (interval_insert_in_front_hooks): Likewise.
12259
12260 * term.c: Make symbols static if they're not exported.
12261 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12262 (max_frame_lines, tty_set_terminal_modes):
12263 (tty_reset_terminal_modes, tty_turn_off_highlight):
12264 (get_tty_terminal): Now static.
12265 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12266 * termhooks.h (term_mouse_moveto): Do not declare if
12267 HAVE_WINDOW_SYSTEM.
12268 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12269 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12270
12271 * sysdep.c: Make symbols static if they're not exported.
12272 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12273 Now static.
12274 (sigprocmask_set, full_mask): Remove; unused.
12275 (wait_debugging): Mark as visible.
12276 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12277 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12278
12279 * syntax.c (syntax_temp): Define only if !__GNUC__.
12280
12281 * sound.c (current_sound_device, current_sound): Now static.
12282
12283 * search.c (searchbufs, searchbuf_head): Now static.
12284
12285 * scroll.c (scroll_cost): Remove; unused.
12286 * dispextern.h (scroll_cost): Remove decl.
12287
12288 * region-cache.h (pp_cache): Mark as externally visible.
12289
12290 * process.c: Make symbols static if they're not exported.
12291 (process_tick, update_tick, create_process, chan_process):
12292 (Vprocess_alist, proc_buffered_char, datagram_access):
12293 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12294 (deactivate_process): Mark defn as static, as well as decl.
12295 * lisp.h (create_process): Remove decl.
12296 * process.h (chan_process, Vprocess_alist): Remove decls.
12297
12298 * print.c: Make symbols static if they're not exported.
12299 (print_depth, new_backquote_output, being_printed, print_buffer):
12300 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12301 (print_interval, print_number_index, initial_stderr_stream):
12302 Now static.
12303 * lisp.h (Fprinc): Remove decl.
12304 (debug_output_compilation_hack): Mark as externally visible.
12305
12306 * sysdep.c (croak): Move decl from here to syssignal.h.
12307 * syssignal.h (croak): Put it here, so the API can be checked when
12308 'croak' is called from dissociate_if_controlling_tty.
12309
12310 * minibuf.c: Make symbols static if they're not exported.
12311 (minibuf_save_list, choose_minibuf_frame): Now static.
12312 * lisp.h (choose_minibuf_frame): Remove decl.
12313
12314 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12315
12316 * lread.c: Make symbols static if they're not exported.
12317 (read_objects, initial_obarray, oblookup_last_bucket_number):
12318 Now static.
12319 (make_symbol): Remove; unused.
12320 * lisp.h (initial_obarray, make_symbol): Remove decls.
12321
12322 * keyboard.c: Make symbols static if they're not exported.
12323 (single_kboard, recent_keys_index, total_keys, recent_keys):
12324 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12325 (this_single_command_key_start, echoing, last_auto_save):
12326 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12327 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12328 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12329 (Vlispy_mouse_stem, double_click_count):
12330 Now static.
12331 (force_auto_save_soon): Define only if SIGDANGER.
12332 (ignore_mouse_drag_p): Now static if
12333 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12334 (print_help): Remove; unused.
12335 (stop_character, last_timer_event): Mark as externally visible.
12336 * keyboard.h (ignore_mouse_drag_p): Declare only if
12337 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12338 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12339 * lisp.h (echoing): Remove decl.
12340 (force_auto_save_soon): Declare only if SIGDANGER.
12341 * xdisp.c (redisplay_window): Simplify code, to make it more
12342 obvious that ignore_mouse_drag_p is not accessed if !defined
12343 USE_GTK && !defined HAVE_NS.
12344
12345 * intervals.c: Make symbols static if they're not exported.
12346 (merge_properties_sticky, merge_interval_right, delete_interval):
12347 Now static.
12348 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12349
12350 * insdel.c: Make symbols static if they're not exported.
12351 However, leave prepare_to_modify_buffer alone. It's never
12352 called from outside this function, but that appears to be a bug.
12353 (combine_after_change_list, combine_after_change_buffer):
12354 (adjust_after_replace, signal_before_change): Now static.
12355 (adjust_after_replace_noundo): Remove; unused.
12356 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12357 (signal_before_change): Remove decls.
12358
12359 * indent.c (val_compute_motion, val_vmotion): Now static.
12360
12361 * image.c: Make symbols static if they're not exported.
12362 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12363 if USE_GTK.
12364 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12365 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12366
12367 * fringe.c (standard_bitmaps): Now static.
12368 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12369
12370 * frame.c: Make symbols static if they're not exported.
12371 (x_report_frame_params, make_terminal_frame): Now static.
12372 (get_frame_param): Now static, unless HAVE_NS.
12373 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12374 (x_get_resource_string): Remove; not used.
12375 * frame.h (make_terminal_frame, x_report_frame_params):
12376 (x_get_resource_string); Remove decls.
12377 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12378 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12379
12380 * font.c, fontset.c: Make symbols static if they're not exported.
12381 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12382 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12383 * font.c (font_close_object): Now static.
12384 * font.h (font_close_object): Remove.
12385 * fontset.c (FONTSET_OBJLIST): Remove.
12386 (free_realized_fontset) #if-0 the body, which does nothing.
12387 (face_suitable_for_char_p): #if-0, as it's never called.
12388 * fontset.h (face_suitable_for_char_p): Remove decl.
12389 * xfaces.c (face_at_string_position):
12390 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12391 since 0 is always ASCII.
12392
12393 * fns.c (weak_hash_tables): Now static.
12394
12395 * fileio.c: Make symbols static if they're not exported.
12396 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12397 (Vwrite_region_annotation_buffers): Now static.
12398
12399 * eval.c: Make symbols static if they're not exported.
12400 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12401 * lisp.h (backtrace_list): Remove decl.
12402
12403 * emacs.c: Make symbols static if they're not exported.
12404 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12405 (fatal_error_code, fatal_error_signal_hook, standard_args):
12406 Now static.
12407 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12408 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12409 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12410 * lisp.h (fatal_error_signal_hook): Remove decl.
12411 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12412
12413 * editfns.c: Move a (normally-unused) function to its only use.
12414 * editfns.c, lisp.h (get_operating_system_release): Remove.
12415 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12416 worth the hassle of breaking this out.
12417
12418 * xterm.c: Make symbols static if they're not exported.
12419 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12420 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12421 (x_destroy_window, x_delete_display):
12422 Now static.
12423 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12424 (x_mouse_leave): Remove; unused.
12425 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12426 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12427 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12428 Remove decls.
12429 (x_mouse_leave): Declare only if WINDOWSNT.
12430 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12431 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12432 USE_X_TOOLKIT.
12433
12434 * ftxfont.c: Make symbols static if they're not exported.
12435 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12436 HAVE_FREETYPE.
12437 * font.h (ftxfont_driver): Likewise.
12438
12439 * xfns.c: Make symbols static if they're not exported.
12440 (x_last_font_name, x_display_info_for_name):
12441 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12442 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12443 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12444 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12445 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12446 (last_show_tip_args): Now static.
12447 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12448 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12449 (x_screen_planes): Remove; unused.
12450 * dispextern.h (x_screen_planes): Remove decl.
12451
12452 * dispnew.c: Make symbols static if they're not exported.
12453 * dispextern.h (redraw_garbaged_frames, scrolling):
12454 (increment_row_positions): Remove.
12455 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12456 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12457 Now static.
12458 (redraw_garbaged_frames): Remove; unused.
12459
12460 * xfaces.c: Make symbols static if they're not exported.
12461 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12462 Remove decls.
12463 * xterm.h (defined_color): Remove decls.
12464 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12465 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12466 (menu_face_changed_default, defined_color, free_realized_face):
12467 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12468 (ascii_face_of_lisp_face): Remove; unused.
12469
12470 * xdisp.c: Make symbols static if they're not exported.
12471 * dispextern.h (scratch_glyph_row, window_box_edges):
12472 (glyph_to_pixel_coords, set_cursor_from_row):
12473 (get_next_display_element, set_iterator_to_next):
12474 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12475 (show_mouse_face): Remove decls
12476 * frame.h (message_buf_print): Likewise.
12477 * lisp.h (pop_message, set_message, check_point_in_composition):
12478 Likewise.
12479 * xterm.h (set_vertical_scroll_bar): Likewise.
12480 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12481 (message_buf_print, scratch_glyph_row, displayed_buffer):
12482 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12483 (get_next_display_element, show_mouse_face, window_box_edges):
12484 (frame_to_window_pixel_xy, check_point_in_composition):
12485 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12486 (glyph_to_pixel_coords): Remove; unused.
12487
12488 * dired.c (file_name_completion): Now static.
12489
12490 * dbusbind.c (xd_in_read_queued_messages): Now static.
12491
12492 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12493 * data.c (circular_list_error): Remove.
12494
12495 * commands.h (last_point_position, last_point_position_buffer):
12496 (last_point_position_window): Remove decls.
12497 * keyboard.c: Make these variables static.
12498
12499 * coding.h (coding, code_convert_region, encode_coding_gap):
12500 Remove decls.
12501 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12502 (iso_code_class, detect_coding, code_convert_region): Now static.
12503 (encode_coding_gap): Remove; unused.
12504
12505 * chartab.c (chartab_chars, chartab_bits): Now static.
12506
12507 * charset.h (charset_iso_8859_1): Remove decl.
12508 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12509 Now static.
12510
12511 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12512 * ccl.c (Vccl_program_table): Now static.
12513 (check_ccl_update): Remove; unused.
12514
12515 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12516 * category.h: ... from here.
12517 * category.c (check_category_table, set_category_set): Now static.
12518
12519 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12520 * lisp.h: Remove these decls.
12521
12522 * buffer.c (buffer_count): Remove unused var.
12523
12524 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12525 so that it's not optimized away.
12526 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12527 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12528 exported only to the debugger.
12529
12530 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12531 * atimer.h (run_all_atimers): Remove; not exported.
12532
12533 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12534 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12535 was inaccessible from Lisp.
12536 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12537 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12538
12539 alloc.c: Import and export fewer symbols, and remove unused items.
12540 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12541 is defined.
12542 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12543 it's not optimized away by whole-program optimization.
12544 (message_enable_multibyte, free_misc): Remove.
12545 (catchlist, handlerlist, mark_backtrace):
12546 Declare only if BYTE_MARK_STACK.
12547 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12548 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12549 (message_enable_multibyte): Remove decl.
12550 (free_misc, interval_free_list, float_block, float_block_index):
12551 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12552 (cons_free_list, last_marked_index):
12553 Now static.
12554 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12555 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12556 (mark_backtrace): Define only if BYTE_MARK_STACK.
12557 * xdisp.c (message_enable_multibyte): Now static.
12558
12559 Declare Lisp_Object Q* variables to be 'static' if not exported.
12560 This makes it easier for human readers (and static analyzers)
12561 to see whether these variables are used from other modules.
12562 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12563 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12564 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12565 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12566 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12567 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12568 * xmenu.c, xselect.c:
12569 Declare Q* vars static if they are not used in other modules.
12570 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12571 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12572 Remove decls of unexported vars.
12573 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12574
12575 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12576
12577 Make Emacs functions such as Fatom 'static' by default.
12578 This makes it easier for human readers (and static analyzers)
12579 to see whether these functions can be called from other modules.
12580 DEFUN now defines a static function. To make the function external
12581 so that it can be used in other C modules, use the new macro DEFUE.
12582 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12583 (Finit_image_library):
12584 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12585 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12586 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12587 Remove decls, since these functions are now static.
12588 (Funintern, Fget_internal_run_time): New decls, since these functions
12589 were already external.
12590
12591 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12592 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12593 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12594 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12595 * keyboard.c, keymap.c, lread.c:
12596 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12597 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12598 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12599 Mark functions with DEFUE instead of DEFUN,
12600 if they are used in other modules.
12601 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12602 decls for now-static functions.
12603 * buffer.h (Fdelete_overlay): Remove decl.
12604 * callproc.c (Fgetenv_internal): Mark as internal.
12605 * composite.c (Fremove_list_of_text_properties): Remove decl.
12606 (Fcomposition_get_gstring): New forward static decl.
12607 * composite.h (Fcomposite_get_gstring): Remove decl.
12608 * dired.c (Ffile_attributes): New forward static decl.
12609 * doc.c (Fdocumntation_property): New forward static decl.
12610 * eval.c (Ffetch_bytecode): New forward static decl.
12611 (Funintern): Remove extern decl; now in .h file where it belongs.
12612 * fileio.c (Fmake_symbolic_link): New forward static decl.
12613 * image.c (Finit_image_library): New forward static decl.
12614 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12615 * intervals.h (Fprevious_property_change):
12616 (Fremove_list_of_text_properties): Remove decls.
12617 * keyboard.c (Fthis_command_keys): Remove decl.
12618 (Fcommand_execute): New forward static decl.
12619 * keymap.c (Flookup_key): New forward static decl.
12620 (Fcopy_keymap): Now static.
12621 * keymap.h (Flookup_key): Remove decl.
12622 * process.c (Fget_process): New forward static decl.
12623 (Fprocess_datagram_address): Mark as internal.
12624 * syntax.c (Fsyntax_table_p): New forward static decl.
12625 (skip_chars): Remove duplicate decl.
12626 * textprop.c (Fprevious_property_change): New forward static decl.
12627 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12628 Now internal.
12629 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12630 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12631
12632 * editfns.c (Fformat): Remove unreachable code.
12633
12634 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12635
12636 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12637 change. (Bug#8496)
12638
12639 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12640
12641 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12642 when at ZV. (Bug#8487)
12643
12644 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12645
12646 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12647 (Bug#8437)
12648 * keyboard.c (parse_tool_bar_item): Likewise.
12649 * sound.c (sound_cleanup, alsa_close): Likewise.
12650 * termcap.c (tgetent): Likewise.
12651 * xfns.c (x_default_font_parameter): Likewise.
12652 * xsettings.c (read_and_apply_settings): Likewise.
12653
12654 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12655 (overrun_check_free): Protoize.
12656
12657 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12658
12659 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12660 since callers should never pass a negative size.
12661 Change the signature to match that of plain 'read' and 'write'; see
12662 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12663 * lisp.h: Update prototypes of emacs_write and emacs_read.
12664
12665 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12666
12667 * xdisp.c (redisplay_window): Don't try to determine the character
12668 position of the scroll margin if the window start point w->startp
12669 is outside the buffer's accessible region. (Bug#8468)
12670
12671 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12672
12673 Fix write-region and its subroutines for buffers > 2GB.
12674 * fileio.c (a_write, e_write): Modify declaration of arguments and
12675 local variables to support buffers larger than 2GB.
12676 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12677
12678 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12679 argument, local variables, and return value.
12680
12681 * lisp.h: Update prototypes of emacs_write and emacs_read.
12682
12683 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12684
12685 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12686
12687 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12688
12689 Fix more problems found by GCC 4.6.0's static checks.
12690
12691 * xdisp.c (vmessage): Use a better test for character truncation.
12692
12693 * charset.c (load_charset_map): <, not <=, for optimization,
12694 and to avoid potential problems with integer overflow.
12695 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12696 * casetab.c (set_identity, shuffle): Likewise.
12697 * editfns.c (Fformat): Likewise.
12698 * syntax.c (skip_chars): Likewise.
12699
12700 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12701 This also lets GCC 4.6.0 generate slightly better loop code.
12702
12703 * callint.c (Fcall_interactively): <, not <=, for optimization.
12704 (Fcall_interactively): Count the number of arguments produced,
12705 not the number of arguments given. This is simpler and lets GCC
12706 4.6.0 generate slightly better code.
12707
12708 * ftfont.c: Distingish more carefully between FcChar8 and char.
12709 The previous code passed unsigned char * to a functions like
12710 strlen and xstrcasecmp that expect char *, which does not
12711 conform to the C standard.
12712 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12713 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12714 char * when the C standard requires it.
12715
12716 * keyboard.c (read_char): Remove unused var.
12717
12718 * eval.c: Port to Windows vsnprintf (Bug#8435).
12719 Include <limits.h>.
12720 (SIZE_MAX): Define if the headers do not.
12721 (verror): Do not give up if vsnprintf returns a negative count.
12722 Instead, grow the buffer. This ports to Windows vsnprintf, which
12723 does not conform to C99. Problem reported by Eli Zaretskii.
12724 Also, simplify the allocation scheme, by avoiding the need for
12725 calling realloc, and removing the ALLOCATED variable.
12726
12727 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12728
12729 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12730 But keep the doprint source code for now, as we might revamp it
12731 and use it again (Bug#8435).
12732 * lisp.h (doprnt): Remove.
12733 * Makefile.in (base_obj): Remove doprnt.o.
12734 * deps.mk (doprnt.o): Remove.
12735
12736 error: Print 32- and 64-bit integers portably (Bug#8435).
12737 Without this change, on typical 64-bit hosts error ("...%d...", N)
12738 was used to print both 32- and 64-bit integers N, which relied on
12739 undefined behavior.
12740 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12741 * lisp.h (error, verror): Mark as printf-like functions.
12742 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12743 Report overflow in size calculations when allocating printf buffer.
12744 Do not truncate output string at its first null byte.
12745 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12746 Truncate the output at a character boundary, since vsnprintf does not
12747 do that.
12748 * charset.c (check_iso_charset_parameter): Convert internal
12749 character to string before calling 'error', since %c now has the
12750 printf meaning.
12751 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12752 overflow when computing char to be passed to 'error'. Do not
12753 pass Lisp_Object to 'error'; pass the integer instead.
12754 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12755 formatted with plain %d.
12756
12757 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12758
12759 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12760
12761 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12762
12763 * xterm.c (x_catch_errors): Remove duplicate declaration.
12764
12765 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12766
12767 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12768
12769 2011-04-10 Jim Meyering <meyering@redhat.com>
12770
12771 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12772 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12773 return ssize_t not "int", and use size_t as the buffer length.
12774 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12775 * gnutls.h: Update declarations.
12776 * process.c (read_process_output): Use ssize_t, to match.
12777 (send_process): Likewise.
12778
12779 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12780
12781 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12782
12783 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12784
12785 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12786 Use unsigned char, to match FcChar8 type definition.
12787
12788 * xterm.c (handle_one_xevent):
12789 * xmenu.c (create_and_show_popup_menu):
12790 * xselect.c (x_decline_selection_request)
12791 (x_reply_selection_request): Avoid type-punned deref of X events.
12792
12793 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12794
12795 Fix some uses of `int' instead of EMACS_INT.
12796 * search.c (string_match_1, fast_string_match)
12797 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12798 (scan_buffer, find_next_newline_no_quit)
12799 (find_before_next_newline, search_command, Freplace_match)
12800 (Fmatch_data): Make some `int' variables be EMACS_INT.
12801
12802 * xdisp.c (display_count_lines): 3rd argument and return value now
12803 EMACS_INT. All callers changed.
12804 (pint2hrstr): Last argument is now EMACS_INT.
12805
12806 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12807 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12808 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12809 (decode_coding_utf_16, decode_coding_emacs_mule)
12810 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12811 (decode_coding_ccl, decode_coding_charset)
12812 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12813 (decode_coding_iso_2022, decode_coding_emacs_mule)
12814 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12815 <char_offset, last_offset>: Declare EMACS_INT.
12816 (encode_coding_utf_8, encode_coding_utf_16)
12817 (encode_coding_emacs_mule, encode_invocation_designation)
12818 (encode_designation_at_bol, encode_coding_iso_2022)
12819 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12820 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12821 Declare EMACS_INT.
12822 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12823 (encode_invocation_designation): Last argument P_NCHARS is now
12824 EMACS_INT.
12825 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12826 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12827
12828 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12829 All users changed.
12830
12831 * ccl.c (Fccl_execute_on_string): Declare some variables
12832 EMACS_INT.
12833
12834 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12835
12836 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12837
12838 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12839
12840 * process.c (Fformat_network_address): Doc fix.
12841
12842 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12843
12844 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12845
12846 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12847
12848 * keyboard.c (read_char): Call Lisp function help-form-show,
12849 instead of using internal_with_output_to_temp_buffer.
12850 (Qhelp_form_show): New var.
12851 (syms_of_keyboard): Use DEFSYM macro.
12852
12853 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12854
12855 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12856
12857 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12858
12859 * process.c (Flist_processes): Remove to Lisp.
12860 (list_processes_1): Delete.
12861
12862 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12863
12864 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12865
12866 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12867
12868 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12869
12870 Fix more problems found by GCC 4.6.0's static checks.
12871
12872 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12873
12874 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12875
12876 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12877
12878 * xdisp.c (vmessage): Mark as a printf-like function.
12879
12880 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12881
12882 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12883
12884 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12885 printf-like functions.
12886 (tiff_load): Add casts to remove these marks before passing them
12887 to system-supplied API.
12888
12889 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12890
12891 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12892 This avoids several warnings with gcc -Wstrict-overflow.
12893 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12894 directly, rather than having caller test rule sign. This avoids
12895 some unnecessary tests.
12896 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12897 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12898 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12899
12900 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12901 (xfont_open): Avoid unnecessary tests.
12902
12903 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12904
12905 * composite.h, composite.c (composition_gstring_put_cache):
12906 Use EMACS_INT, not int, for length.
12907
12908 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12909 breaking out part of COMPOSITION_DECODE_RULE.
12910 (COMPOSITION_DECODE_RULE): Use it.
12911 * composite.c (get_composition_id): Remove unused local vars,
12912 by using the new macro.
12913
12914 * textprop.c (set_text_properties_1): Change while to do-while,
12915 since the condition is always true at first.
12916
12917 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12918 (interval_deletion_adjustment): Return unsigned value.
12919 All uses changed.
12920
12921 * process.c (list_processes_1, create_pty, read_process_output):
12922 (exec_sentinel): Remove vars that were set but not used.
12923 (create_pty): Remove unnecessary "volatile"s.
12924 (Fnetwork_interface_info): Avoid possibility of int overflow.
12925 (read_process_output): Do adaptive read buffering even if carryover.
12926 (read_process_output): Simplify nbytes computation if buffered.
12927
12928 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12929
12930 * syntax.c (scan_words): Remove var that was set but not used.
12931 (update_syntax_table): Use unsigned instead of int.
12932
12933 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12934 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12935 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12936
12937 * print.c (print_error_message): Avoid int overflow.
12938
12939 * font.c (font_list_entities): Redo for clarity,
12940 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12941
12942 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12943 (font_score): Avoid potential overflow in diff calculation.
12944
12945 * fns.c (substring_both): Remove var that is set but not used.
12946 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12947
12948 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12949
12950 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12951 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12952 can always succeed if overflow has undefined behavior.
12953
12954 * search.c (boyer_moore, wordify): Remove vars set but not used.
12955 (wordify): Omit three unnecessary tests.
12956
12957 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12958 All callers changed. This avoids the need for an unused var.
12959
12960 * casefiddle.c (casify_region): Remove var that is set but not used.
12961
12962 * dired.c (file_name_completion): Remove var that is set but not used.
12963
12964 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12965
12966 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12967 (Finsert_file_contents): Remove unnecessary code checking fd.
12968
12969 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12970 Check for integer overflow on size calculations.
12971
12972 * buffer.c (Fprevious_overlay_change): Remove var that is set
12973 but not used.
12974
12975 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12976 Remove vars that are set but not used.
12977 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12978 (timer_check_2): Mark vars as initialized.
12979
12980 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12981
12982 * image.c (lookup_image): Remove var that is set but not used.
12983 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12984
12985 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12986 that are set but not used.
12987
12988 * xfns.c (make_invisible_cursor): Don't return garbage
12989 if XCreateBitmapFromData fails (Bug#8410).
12990
12991 * xselect.c (x_get_local_selection, x_handle_property_notify):
12992 Remove vars that are set but not used.
12993
12994 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12995 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12996
12997 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12998 Remove var that is set but not used.
12999 (scroll_bar_windows_size): Now size_t, not int.
13000 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13001 Check for overflow.
13002
13003 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13004 (map_tty_color) [!defined MSDOS]: Likewise.
13005
13006 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13007
13008 * coding.c: Remove vars that are set but not used.
13009 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13010 All callers changed.
13011 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13012 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13013 (decode_coding_charset): Remove vars that are set but not used.
13014
13015 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13016 that is set but not used.
13017
13018 * print.c (print_object): Remove var that is set but not used.
13019
13020 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13021 The gnulib version avoids calling malloc in the usual case,
13022 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13023 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13024 * filelock.c (current_lock_owner): Likewise.
13025 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13026 * sysdep.c: Include allocator.h, careadlinkat.h.
13027 (emacs_no_realloc_allocator): New static constant.
13028 (emacs_readlink): New function.
13029 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13030 ../lib/careadlinkat.h.
13031
13032 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13033
13034 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13035 first non-nil return value).
13036
13037 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13038
13039 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13040 if not defined (Bug#8403).
13041
13042 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13043
13044 * xdisp.c (display_count_lines): Remove parameter `start',
13045 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13046 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13047 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13048 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13049 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13050 and thereabouts. All callers changed.
13051 (get_per_char_metric): Remove parameter `f', unused since
13052 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13053
13054 2011-04-02 Jim Meyering <meyering@redhat.com>
13055
13056 do not dereference NULL upon failed strdup
13057 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13058 (ns_get_family): Likewise.
13059
13060 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13061
13062 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13063
13064 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13065
13066 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13067 later (Bug#8403).
13068
13069 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13070
13071 Add lexical binding.
13072
13073 * window.c (Ftemp_output_buffer_show): New fun.
13074 (Fsave_window_excursion):
13075 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13076
13077 * lread.c (lisp_file_lexically_bound_p): New function.
13078 (Fload): Bind Qlexical_binding.
13079 (readevalloop): Remove `evalfun' arg.
13080 Bind Qinternal_interpreter_environment.
13081 (Feval_buffer): Bind Qlexical_binding.
13082 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13083 Mark as dynamic.
13084 (syms_of_lread): Declare `lexical-binding'.
13085
13086 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13087
13088 * keyboard.c (eval_dyn): New fun.
13089 (menu_item_eval_property): Use it.
13090
13091 * image.c (parse_image_spec): Use Ffunctionp.
13092
13093 * fns.c (concat, mapcar1): Accept byte-code-functions.
13094
13095 * eval.c (Fsetq): Handle lexical vars.
13096 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13097 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13098 (FletX, Flet): Obey lexical binding.
13099 (Fcommandp): Handle closures.
13100 (Feval): New `lexical' arg.
13101 (eval_sub): New function extracted from Feval. Use it almost
13102 everywhere where Feval was used. Look up vars in lexical env.
13103 Handle closures.
13104 (Ffunctionp): Move from subr.el.
13105 (Ffuncall): Handle closures.
13106 (apply_lambda): Remove `eval_flags'.
13107 (funcall_lambda): Handle closures and new byte-code-functions.
13108 (Fspecial_variable_p): New function.
13109 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13110 but without exporting it to Lisp.
13111
13112 * doc.c (Fdocumentation, store_function_docstring):
13113 * data.c (Finteractive_form): Handle closures.
13114
13115 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13116 interactive spec.
13117
13118 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13119 New byte-codes.
13120 (exec_byte_code): New function extracted from Fbyte_code to handle new
13121 calling convention for byte-code-functions. Add new byte-codes.
13122
13123 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13124
13125 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13126
13127 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13128
13129 * xdisp.c (redisplay_internal): Fix prototype.
13130
13131 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13132
13133 * xdisp.c (SCROLL_LIMIT): New macro.
13134 (try_scrolling): Use it when setting scroll_limit.
13135 Limit scrolling to 100 screen lines.
13136 (redisplay_window): Even when falling back on "recentering",
13137 position point in the window according to scroll-conservatively,
13138 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13139
13140 (try_scrolling): When point is above the window, allow searching
13141 as far as scroll_max, or one screenful, to compute vertical
13142 distance from PT to the scroll margin position. This prevents
13143 try_scrolling from unnecessarily failing when
13144 scroll-conservatively is set to a value slightly larger than the
13145 window height. Clean up the case of PT below the margin at bottom
13146 of window: scroll_max can no longer be INT_MAX. When aggressive
13147 scrolling is in use, don't let point enter the opposite scroll
13148 margin as result of the scroll.
13149 (syms_of_xdisp) <scroll-conservatively>: Document the
13150 threshold of 100 lines for never-recentering scrolling.
13151
13152 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13153
13154 * dispextern.h (move_it_by_lines):
13155 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13156 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13157 (message_log_check_duplicate): Remove parameters `prev_bol' and
13158 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13159 (redisplay_internal): Remove parameter `preserve_echo_area',
13160 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13161
13162 * indent.c (Fvertical_motion):
13163 * window.c (window_scroll_pixel_based, Frecenter):
13164 Don't pass `need_y_p' to `move_it_by_lines'.
13165
13166 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13167
13168 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13169 steal a few bits to be more compact.
13170 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13171 Remove unneeded casts.
13172
13173 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13174
13175 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13176
13177 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13178 binding" message (bug#7967).
13179
13180 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13181
13182 Fix more problems found by GCC 4.6.0's static checks.
13183
13184 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13185 Remove unused local var.
13186
13187 * editfns.c (Fmessage_box): Remove unused local var.
13188
13189 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13190 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13191 Omit unused local vars.
13192 * window.c (shrink_windows): Omit unused local var.
13193 * menu.c (digest_single_submenu): Omit unused local var.
13194 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13195 Omit unused local var.
13196
13197 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13198 Don't assume string length fits in int.
13199 (keyremap_step, read_key_sequence): Use size_t for sizes.
13200 (read_key_sequence): Don't check last_real_key_start redundantly.
13201
13202 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13203 instead of alloca (Bug#8344).
13204
13205 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13206 (Fbacktrace_frame): Don't assume nframes fits in int.
13207
13208 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13209
13210 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13211 concerns.
13212
13213 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13214
13215 * cm.c (calccost): Turn while-do into do-while, for clarity.
13216
13217 * keyboard.c (syms_of_keyboard): Use the same style as later
13218 in this function when indexing through an array. This also
13219 works around GCC bug 48267.
13220
13221 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13222
13223 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13224
13225 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13226 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13227
13228 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13229 This avoids undefined behavior on integer overflow, and is a bit
13230 more convenient anyway since it is compared to a size_t variable.
13231
13232 Variadic C functions now count arguments with size_t, not int.
13233 This avoids an unnecessary limitation on 64-bit machines, which
13234 caused (substring ...) to crash on large vectors (Bug#8344).
13235 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13236 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13237 All variadic functions and their callers changed accordingly.
13238 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13239 * data.c (arith_driver, float_arith_driver): Likewise.
13240 * editfns.c (general_insert_function): Likewise.
13241 * eval.c (struct backtrace.nargs, interactive_p)
13242 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13243 (funcall_lambda, mark_backtrace): Likewise.
13244 * fns.c (concat): Likewise.
13245 * frame.c (x_set_frame_parameters): Likewise.
13246 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13247 0 if not found, not -1. All callers changed.
13248
13249 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13250 (stack_copy_size): Now size_t, not int.
13251 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13252
13253 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13254
13255 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13256 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13257 All callers changed.
13258
13259 * lisp.h (multibyte_char_to_unibyte):
13260 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13261 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13262 * character.h (CHAR_TO_BYTE8):
13263 * cmds.c (internal_self_insert):
13264 * editfns.c (general_insert_function):
13265 * keymap.c (push_key_description):
13266 * search.c (Freplace_match):
13267 * xdisp.c (message_dolog, set_message_1): All callers changed.
13268
13269 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13270
13271 * keyboard.c (safe_run_hook_funcall): New function.
13272 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13273 don't set the hook to nil, but remove the offending function instead.
13274 (Qcommand_hook_internal): Remove, unused.
13275 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13276 Vcommand_hook_internal.
13277
13278 * eval.c (enum run_hooks_condition): Remove.
13279 (funcall_nil, funcall_not): New functions.
13280 (run_hook_with_args): Call each function through a `funcall' argument.
13281 Remove `cond' argument, now redundant.
13282 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13283 (Frun_hook_with_args_until_failure): Adjust accordingly.
13284 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13285
13286 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13287
13288 * dispextern.h (string_buffer_position): Remove declaration.
13289
13290 * print.c (strout): Remove parameter `multibyte', unused since
13291 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13292
13293 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13294 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13295 All callers changed.
13296
13297 * w32.c (_wsa_errlist): Use braces for struct initializers.
13298
13299 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13300 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13301 All callers changed.
13302 (string_buffer_position): Likewise. Also, make static (it's never
13303 used outside xdisp.c).
13304 (cursor_row_p): Remove parameter `w', unused since
13305 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13306 (decode_mode_spec): Remove parameter `precision', introduced during
13307 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13308 All callers changed.
13309
13310 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13311
13312 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13313
13314 2011-03-27 Anders Lindgren <andlind@gmail.com>
13315
13316 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13317 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13318 (ns_update_auto_hide_menu_bar): New functions.
13319 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13320 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13321 ns_constrain_all_frames.
13322 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13323 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13324
13325 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13326
13327 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13328
13329 2011-03-27 Glenn Morris <rgm@gnu.org>
13330
13331 * syssignal.h: Replace RETSIGTYPE with void.
13332 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13333 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13334 Replace SIGTYPE with void everywhere.
13335 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13336 * s/template.h (SIGTYPE): Remove commented out definition.
13337
13338 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13339
13340 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13341 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13342
13343 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13344
13345 * w32.c (read_unc_volume): Use parameter `henum', instead of
13346 global variable `wget_enum_handle'.
13347
13348 * keymap.c (describe_vector): Remove parameters `indices' and
13349 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13350 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13351
13352 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13353
13354 * keyboard.c (timer_check): Remove parameter `do_it_now',
13355 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13356 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13357 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13358
13359 * keyboard.c (read_char):
13360 * w32menu.c (w32_menu_display_help):
13361 * xmenu.c (show_help_event, menu_help_callback):
13362 Adjust calls to `show_help_echo'.
13363
13364 * gtkutil.c (xg_maybe_add_timer):
13365 * keyboard.c (readable_events):
13366 * process.c (wait_reading_process_output):
13367 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13368
13369 * insdel.c (adjust_markers_gap_motion):
13370 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13371 (gap_left, gap_right): Don't call it.
13372
13373 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13374
13375 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13376 incurred during fontification.
13377
13378 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13379
13380 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13381 (DEFVAR_PER_BUFFER): Don't pass it.
13382
13383 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13384 (scrolling_window): Don't pass it.
13385
13386 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13387
13388 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13389
13390 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13391 and `suffix'.
13392 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13393 of variables specific to SELinux and computation of `encoded_absname'.
13394
13395 * image.c (XPutPixel): Remove unused variable `height'.
13396
13397 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13398
13399 * unexw32.c (get_section_info): Remove unused variable `section'.
13400
13401 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13402 (system_process_attributes): Remove unused variable `sess'.
13403 (sys_read): Remove unused variable `err'.
13404
13405 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13406 (w32_wnd_proc): Remove unused variable `isdead'.
13407 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13408 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13409 (x_create_tip_frame): Remove unused variable `tem'.
13410
13411 * w32inevt.c (w32_console_read_socket):
13412 Remove unused variable `no_events'.
13413
13414 * w32term.c (x_draw_composite_glyph_string_foreground):
13415 Remove unused variable `width'.
13416
13417 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13418
13419 * w32term.c (x_set_glyph_string_clipping):
13420 Don't pass uninitialized region to CombineRgn.
13421
13422 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13423
13424 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13425 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13426 (Fx_close_connection): Remove unused variable `i'.
13427
13428 * w32font.c (w32font_draw): Return number of glyphs.
13429 (w32font_open_internal): Remove unused variable `i'.
13430 (w32font_driver): Add missing initializer.
13431
13432 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13433 (fill_in_menu): Remove unused variable `items_added'.
13434
13435 * w32term.c (last_mouse_press_frame): Remove static global variable.
13436 (w32_clip_to_row): Remove unused variable `f'.
13437 (x_delete_terminal): Remove unused variable `i'.
13438
13439 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13440 (NOTHING): Remove unused static global variable.
13441 (uniscribe_check_otf): Remove unused variable `table'.
13442 (uniscribe_font_driver): Add missing initializers.
13443
13444 2011-03-23 Julien Danjou <julien@danjou.info>
13445
13446 * term.c (Fsuspend_tty, Fresume_tty):
13447 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13448 * window.c (temp_output_buffer_show):
13449 * insdel.c (signal_before_change):
13450 * frame.c (Fhandle_switch_frame):
13451 * fileio.c (Fdo_auto_save):
13452 * emacs.c (Fkill_emacs):
13453 * editfns.c (save_excursion_restore):
13454 * cmds.c (internal_self_insert):
13455 * callint.c (Fcall_interactively):
13456 * buffer.c (Fkill_all_local_variables):
13457 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13458 Use Frun_hooks.
13459 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13460 unconditionally since it does the check itself.
13461
13462 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13463
13464 Fix more problems found by GCC 4.5.2's static checks.
13465
13466 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13467 the first time through the loop, since we know p0 < p1 then.
13468 This also avoids a gcc -Wstrict-overflow warning.
13469
13470 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13471 leading to a memory leak, possible in functions like
13472 load_charset_map_from_file that can allocate an unbounded number
13473 of objects (Bug#8318).
13474
13475 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13476 that could (at least in theory) be that large.
13477
13478 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13479 This is less likely to overflow, and avoids undefined behavior if
13480 overflow does occur. All callers changed. Use strtoul to scan
13481 for the unsigned long integer.
13482 (pint2hrstr): Simplify and tune code slightly.
13483 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13484
13485 * scroll.c (do_scrolling): Work around GCC bug 48228.
13486 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13487
13488 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13489 This also avoids a warning with gcc -Wstrict-overflow.
13490 (validate_x_resource_name): Simplify count usage.
13491 This also avoids a warning with gcc -Wstrict-overflow.
13492
13493 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13494 fail (Bug#8306).
13495
13496 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13497
13498 * process.c (Fmake_network_process): Use socklen_t, not int,
13499 where POSIX says socklen_t is required in portable programs.
13500 This fixes a porting bug on hosts like 64-bit HP-UX, where
13501 socklen_t is wider than int (Bug#8277).
13502 (Fmake_network_process, server_accept_connection):
13503 (wait_reading_process_output, read_process_output):
13504 Likewise.
13505
13506 * process.c: Rename or move locals to avoid shadowing.
13507 (list_processes_1, Fmake_network_process):
13508 (read_process_output_error_handler, exec_sentinel_error_handler):
13509 Rename or move locals.
13510 (Fmake_network_process): Define label "retry_connect" only if needed.
13511 (Fnetwork_interface_info): Fix pointer signedness.
13512 (process_send_signal): Add cast to avoid pointer signedness problem.
13513 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13514 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13515
13516 Make tparam.h and terminfo.c consistent.
13517 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13518 Include tparam.h instead, since it declares them.
13519 * cm.h (PC): Remove extern decl; tparam.h now does this.
13520 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13521 * terminfo.c: Include tparam.h, to check interfaces.
13522 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13523 (tparam): Adjust signature to match interface in tparam.h;
13524 this removes some undefined behavior. Check that outstring and len
13525 are zero, which they always are with Emacs.
13526 * tparam.h (PC, BC, UP): New extern decls.
13527
13528 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13529 (xftfont_open): Rename locals to avoid shadowing.
13530
13531 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13532 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13533 (OTF_TAG_SYM): Omit macro if not needed.
13534 (ftfont_list): Remove unused local.
13535 (get_adstyle_property, ftfont_pattern_entity):
13536 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13537 Rename locals to avoid shadowing.
13538
13539 * xfont.c (xfont_list_family): Mark var as initialized.
13540
13541 * xml.c (make_dom): Now static.
13542
13543 * composite.c (composition_compute_stop_pos): Rename local to
13544 avoid shadowing.
13545 (composition_reseat_it): Remove unused locals.
13546 (find_automatic_composition, composition_adjust_point): Likewise.
13547 (composition_update_it): Mark var as initialized.
13548 (find_automatic_composition): Mark vars as initialized,
13549 with a FIXME (Bug#8290).
13550
13551 character.h: Rename locals to avoid shadowing.
13552 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13553 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13554 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13555 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13556 to avoid shadowing.
13557
13558 * textprop.c (property_change_between_p): Remove; unused.
13559
13560 * intervals.c (interval_start_pos): Now static.
13561
13562 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13563
13564 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13565 Rename locals to avoid shadowing.
13566
13567 * sound.c (wav_play, au_play, Fplay_sound_internal):
13568 Fix pointer signedness.
13569 (alsa_choose_format): Remove unused local var.
13570 (wav_play): Initialize a variable to 0, to prevent undefined
13571 behavior (Bug#8278).
13572
13573 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13574
13575 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13576
13577 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13578 clobbering (Bug#8298).
13579 * sysdep.c (sys_subshell): Likewise.
13580 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13581
13582 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13583 This should get cleaned up, so that child_setup has the
13584 same signature on all platforms.
13585
13586 * callproc.c (call_process_cleanup): Now static.
13587 (relocate_fd): Rename locals to avoid shadowing.
13588
13589 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13590
13591 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13592 not to be necessary, and produces flickering.
13593
13594 2011-03-20 Glenn Morris <rgm@gnu.org>
13595
13596 * config.in: Remove file.
13597
13598 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13599
13600 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13601 are now in src/globals.h.
13602 (syms_of_minibuf): Remove spurious & from previous change.
13603
13604 2011-03-20 Leo Liu <sdl.web@gmail.com>
13605
13606 * minibuf.c (completing-read-function): New variable.
13607 (completing-read-default): Rename from completing-read.
13608 (completing-read): Call completing-read-function.
13609
13610 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13611
13612 * xfaces.c (Fx_load_color_file):
13613 Read color file from absolute filename (bug#8250).
13614
13615 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13616
13617 * makefile.w32-in: Update dependencies.
13618
13619 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13620
13621 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13622
13623 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13624
13625 Fix more problems found by GCC 4.5.2's static checks.
13626
13627 * process.c (make_serial_process_unwind, send_process_trap):
13628 (sigchld_handler): Now static.
13629
13630 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13631 That way, the code declares only the vars that it needs.
13632 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13633 * s/cygwin.h (PTY_ITERATION): Likewise.
13634 * s/darwin.h (PTY_ITERATION): Likewise.
13635 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13636
13637 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13638 * process.c (allocate_pty): Don't declare stb unless it's needed.
13639
13640 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13641 (CONSTANTLIM): Remove; unused.
13642 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13643 Define only if needed.
13644
13645 * unexelf.c (unexec): Name an expression,
13646 to avoid gcc -Wbad-function-cast warning.
13647 Use a different way to cause a compilation error if anyone uses
13648 n rather than nn, a way that does not involve shadowing.
13649 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13650
13651 * deps.mk (unexalpha.o): Remove; unused.
13652
13653 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13654 * unexec.h: New file.
13655 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13656 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13657 Depend on unexec.h.
13658 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13659 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13660 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13661 Change as necessary to match prototype in unexec.h.
13662
13663 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13664 shadowing.
13665 (back_comment, skip_chars): Mark vars as initialized.
13666
13667 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13668 Rename locals to avoid shadowing.
13669
13670 * lread.c (read1): Rewrite so as not to use empty "else".
13671 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13672
13673 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13674
13675 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13676 warning when compiling print.c.
13677
13678 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13679 instead of using an uninitialized var.
13680 (font_sort_entities): Mark var as initialized.
13681
13682 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13683
13684 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13685 pointers to constants.
13686 (font_parse_fcname): Remove unused vars.
13687 (font_delete_unmatched): Now static.
13688 (font_get_spec): Remove; unused.
13689 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13690 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13691 Rename or move locals to avoid shadowing.
13692
13693 * fns.c (require_nesting_list, require_unwind): Now static.
13694 (Ffillarray): Rename locals to avoid shadowing.
13695
13696 * floatfns.c (domain_error2): Define only if needed.
13697 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13698
13699 * alloc.c (mark_backtrace): Move decl from here ...
13700 * lisp.h: ... to here, so that it can be checked.
13701
13702 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13703 (Fdefvar): Rewrite so as not to use empty "else".
13704 (lisp_indirect_variable): Name an expression,
13705 to avoid gcc -Wbad-function-cast warning.
13706 (Fdefvar): Rename locals to avoid shadowing.
13707
13708 * callint.c (quotify_arg, quotify_args): Now static.
13709 (Fcall_interactively): Rename locals to avoid shadowing.
13710 Use const pointer when appropriate.
13711
13712 * lisp.h (get_system_name, get_operating_system_release):
13713 Move decls here, to check interfaces.
13714 * process.c (get_operating_system_release): Move decl to lisp.h.
13715 * xrdb.c (get_system_name): Likewise.
13716 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13717 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13718 some of which prompt warnings from gcc -Wbad-function-cast.
13719 (Fformat_time_string, Fencode_time, Finsert_char):
13720 (Ftranslate_region_internal, Fformat):
13721 Rename or remove local vars to avoid shadowing.
13722 (Ftranslate_region_internal): Mark var as initialized.
13723
13724 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13725 avoid shadowing.
13726
13727 * lisp.h (eassert): Check that the argument compiles, even if
13728 ENABLE_CHECKING is not defined.
13729
13730 * data.c (Findirect_variable): Name an expression, to avoid
13731 gcc -Wbad-function-cast warning.
13732 (default_value, arithcompare, arith_driver, arith_error): Now static.
13733 (store_symval_forwarding): Rename local to avoid shadowing.
13734 (Fmake_variable_buffer_local, Fmake_local_variable):
13735 Mark variables as initialized.
13736 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13737
13738 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13739 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13740 Rename locals to avoid shadowing.
13741 (mark_stack): Move local variables into the #ifdef region where
13742 they're used.
13743 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13744 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13745 needed otherwise.
13746 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13747 (GC_STRING_CHARS): Remove; not used.
13748 (Fmemory_limit): Cast sbrk's returned value to char *.
13749
13750 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13751 avoids undefined behavior in theory.
13752
13753 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13754
13755 Use functions, not macros, for up- and down-casing (Bug#8254).
13756 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13757 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13758 to use the following functions instead of these macros.
13759 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13760 EMACS_INT, since callers assume the returned value fits in int.
13761 (upcase1): Likewise, for UPCASE_TABLE.
13762 (uppercasep, lowercasep, upcase): New static inline functions.
13763 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13764 the race-condition problem in the old DOWNCASE.
13765
13766 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13767 Rename locals to avoid shadowing.
13768 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13769 (regex_compile, re_search_2, re_match_2_internal):
13770 Remove unused local vars.
13771 (FREE_VAR): Rewrite so as not to use empty "else",
13772 which gcc can warn about.
13773 (regex_compile, re_match_2_internal): Mark locals as initialized.
13774 (RETALLOC_IF): Define only if needed.
13775 (WORDCHAR_P): Likewise. This one is never needed, but is used
13776 only in a comment talking about a compiler bug, so put inside
13777 the #if 0 of that comment.
13778 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13779 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13780 Remove; unused.
13781
13782 * search.c (boyer_moore): Rename locals to avoid shadowing.
13783 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13784 (PREV_CHAR_BOUNDARY): Likewise.
13785
13786 * search.c (simple_search): Remove unused var.
13787
13788 * dired.c (compile_pattern): Move decl from here ...
13789 * lisp.h: ... to here, so that it can be checked.
13790 (struct re_registers): New forward decl.
13791
13792 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13793
13794 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13795 All uses changed.
13796 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13797 Rename locals to avoid shadowing.
13798 (Fvertical_motion): Mark locals as initialized.
13799
13800 * casefiddle.c (casify_object, casify_region): Now static.
13801 (casify_region): Mark local as initialized.
13802
13803 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13804
13805 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13806 New macros, so that the caller can use some names other than
13807 gcpro1, gcpro2, etc.
13808 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13809 of the new macros.
13810 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13811 argument, for consistency with GCPRO2_VAR, etc: it is now the
13812 prefix of the variable, not the variable itself. All uses
13813 changed.
13814 * dired.c (directory_files_internal, file_name_completion):
13815 Rename locals to avoid shadowing.
13816
13817 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13818 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13819 dired.c's scmp function, had undefined behavior.
13820 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13821 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13822 * buffer.h: ... to here, because these macros use current_buffer,
13823 and the new implementation with inline functions needs to have
13824 current_buffer in scope now, rather than later when the macros
13825 are used.
13826 (downcase, upcase1): New static inline functions.
13827 (DOWNCASE, UPCASE1): Reimplement using these functions.
13828 This avoids undefined behavior in expressions like
13829 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13830 from race conditions in accessing the global variables
13831 case_temp1 and case_temp2.
13832 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13833 * lisp.h (case_temp1, case_temp2): Remove their decls.
13834 * character.h (ASCII_CHAR_P): Move from here ...
13835 * lisp.h: ... to here, so that the inline functions mentioned
13836 above can use them.
13837
13838 * dired.c (directory_files_internal_unwind): Now static.
13839
13840 * fileio.c (file_name_as_directory, directory_file_name):
13841 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13842 Now static.
13843 (file_name_as_directory): Use const pointers when appropriate.
13844 (Fexpand_file_name): Likewise. In particular, newdir might
13845 point at constant storage, so make it a const pointer.
13846 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13847 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13848 signedness issues.
13849 (Fset_file_times, Finsert_file_contents, auto_save_error):
13850 Rename locals to avoid shadowing.
13851
13852 * minibuf.c (choose_minibuf_frame_1): Now static.
13853 (Ftry_completion, Fall_completions): Rename or remove locals
13854 to avoid shadowing.
13855
13856 * marker.c (bytepos_to_charpos): Remove; unused.
13857
13858 * lisp.h (verify_bytepos, count_markers): New decls,
13859 so that gcc does not warn that these functions aren't declared.
13860
13861 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13862 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13863 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13864 (copy_text): Remove unused local var.
13865
13866 * filelock.c (within_one_second): Now static.
13867 (lock_file_1): Rename local to avoid shadowing.
13868
13869 * buffer.c (fix_overlays_before): Mark locals as initialized.
13870 (fix_start_end_in_overlays): Likewise. This function should be
13871 simplified by using pointers-to-pointers, but that's a different
13872 matter.
13873 (switch_to_buffer_1): Now static.
13874 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13875 (report_overlay_modification): Rename locals to avoid shadowing.
13876
13877 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13878 Fix pointer signedness issue.
13879 (sys_subshell): Mark local as volatile if checking for lint,
13880 to suppress a gcc -Wclobbered warning that does not seem to be right.
13881 (MAXPATHLEN): Define only if needed.
13882
13883 * process.c (serial_open, serial_configure): Move decls from here ...
13884 * systty.h: ... to here, so that they can be checked.
13885
13886 * fns.c (get_random, seed_random): Move extern decls from here ...
13887 * lisp.h: ... to here, so that they can be checked.
13888
13889 * sysdep.c (reset_io): Now static.
13890 (wait_for_termination_signal): Remove; unused.
13891
13892 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13893 (copy_keymap_item, append_key, push_text_char_description):
13894 Now static.
13895 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13896 (DENSE_TABLE_SIZE): Remove; unused.
13897 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13898 (describe_map_tree):
13899 Rename locals to avoid shadowing.
13900
13901 * keyboard.c: Declare functions static if they are not used elsewhere.
13902 (echo_char, echo_dash, cmd_error, top_level_2):
13903 (poll_for_input, handle_async_input): Now static.
13904 (read_char, kbd_buffer_get_event, make_lispy_position):
13905 (make_lispy_event, make_lispy_movement, apply_modifiers):
13906 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13907 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13908 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13909 (read_key_sequence, read_char): Mark locals as initialized.
13910 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13911
13912 * keyboard.h (make_ctrl_char): New decl.
13913 (mark_kboards): Move decl here ...
13914 * alloc.c (mark_kboards): ... from here.
13915
13916 * lisp.h (force_auto_save_soon): New decl.
13917
13918 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13919 (DEFINE_DUMMY_FUNCTION): New macro.
13920 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13921 Use it.
13922 (main): Add casts to avoid warnings
13923 if GCC considers string literals to be constants.
13924
13925 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13926
13927 * dbusbind.c: Pointer signedness fixes.
13928 (xd_signature, xd_append_arg, xd_initialize):
13929 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13930 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13931 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13932 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13933
13934 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13935 if GCC considers string literals to be constants.
13936 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13937
13938 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13939
13940 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13941 (print_preprocess, print_object): New macro to fix last change.
13942
13943 * print.c (print_preprocess): Don't forget font objects.
13944
13945 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13946
13947 * emacs.c (USAGE3): Doc fixes.
13948
13949 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13950
13951 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13952 structure.
13953
13954 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13955
13956 * lisp.h (VWindow_system, Qfile_name_history):
13957 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13958 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13959 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13960
13961 * w32select.c: Don't #include "keyboard.h".
13962 (run_protected): Add extern declaration for waiting_for_input.
13963
13964 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13965 * w32console.c (detect_input_pending, read_input_pending)
13966 (encode_terminal_code):
13967 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13968 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13969 (w32_system_caret_y, Qfile_name_history):
13970 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13971 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13972 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13973 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13974 * w32proc.c (Qlocal, report_file_error):
13975 * w32term.c (Vwindow_system, updating_frame):
13976 * w32uniscribe.c (initialized, uniscribe_font_driver):
13977 Remove unneeded extern declarations.
13978
13979 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13980
13981 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13982
13983 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13984
13985 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13986 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13987 These macros can no longer be used for assignment.
13988
13989 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13990 Assign struct members directly, instead of using BUF_BEGV etc.
13991 (record_buffer_markers, fetch_buffer_markers): New functions for
13992 recording and fetching special buffer markers.
13993 (set_buffer_internal_1, set_buffer_temp): Use them.
13994
13995 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13996
13997 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13998
13999 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14000 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14001
14002 * xdisp.c (hscroll_window_tree):
14003 (reconsider_clip_changes): Use PT instead of BUF_PT.
14004
14005 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14006
14007 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14008 $(EMACS_ROOT)/lib/intprops.h.
14009
14010 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14011
14012 Fix more problems found by GCC 4.5.2's static checks.
14013
14014 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14015 to unsigned char * to avoid compiler diagnostic.
14016 (xg_free_frame_widgets): Make it clear that a local variable is
14017 needed only if USE_GTK_TOOLTIP.
14018 (gdk_window_get_screen): Make it clear that this macro is needed
14019 only if USE_GTK_TOOLTIP.
14020 (int_gtk_range_get_value): New function, which avoids a diagnostic
14021 from gcc -Wbad-function-cast.
14022 (xg_set_toolkit_scroll_bar_thumb): Use it.
14023 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14024 diagnostic from gcc -Wbad-function-cast.
14025 (get_utf8_string, xg_get_file_with_chooser):
14026 Rename locals to avoid shadowing.
14027 (create_dialog): Move locals to avoid shadowing.
14028
14029 * xgselect.c (xg_select): Remove unused var.
14030
14031 * image.c (four_corners_best): Mark locals as initialized.
14032 (gif_load): Initialize transparent_p to zero (Bug#8238).
14033 Mark another local as initialized.
14034 (my_png_error, my_error_exit): Mark with NO_RETURN.
14035
14036 * image.c (clear_image_cache): Now static.
14037 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14038 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14039 (x_edge_detection): Remove unnecessary cast that
14040 gcc -Wbad-function-cast diagnoses.
14041 (gif_load): Fix pointer signedness.
14042 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14043 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14044
14045 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14046
14047 Improve quality of tests for time stamp overflow.
14048 For example, without this patch (encode-time 0 0 0 1 1
14049 1152921504606846976) returns the obviously-bogus value (-948597
14050 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14051 reports time overflow. See
14052 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14053 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14054 * editfns.c: Include limits.h and intprops.h.
14055 (TIME_T_MIN, TIME_T_MAX): New macros.
14056 (time_overflow): Move earlier, to before first use.
14057 (hi_time, lo_time): New functions, for an accurate test for
14058 out-of-range times.
14059 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14060 (Fget_internal_run_time): Don't assume time_t fits in int.
14061 (make_time): Use list2 instead of Fcons twice.
14062 (Fdecode_time): More accurate test for out-of-range times.
14063 (check_tm_member): New function.
14064 (Fencode_time): Use it, to test for out-of-range times.
14065 (lisp_time_argument): Don't rely on undefined left-shift and
14066 right-shift behavior when checking for time stamp overflow.
14067
14068 * editfns.c (time_overflow): New function, refactoring common code.
14069 (Fformat_time_string, Fdecode_time, Fencode_time):
14070 (Fcurrent_time_string): Use it.
14071
14072 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14073 * dired.c (make_time): Move to ...
14074 * editfns.c (make_time): ... here.
14075 * systime.h: Note the move.
14076
14077 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14078
14079 * fringe.c (update_window_fringes): Remove unused variables.
14080
14081 * unexmacosx.c (copy_data_segment): Also copy __got section.
14082 (Bug#8223)
14083
14084 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14085
14086 * termcap.c [MSDOS]: Include "msdos.h".
14087 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14088 Constify `char *' arguments and their references according to
14089 prototypes in tparam.h.
14090
14091 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14092
14093 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14094 Adapt all references accordingly.
14095
14096 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14097
14098 2011-03-11 Tom Tromey <tromey@redhat.com>
14099
14100 * buffer.c (syms_of_buffer): Remove obsolete comment.
14101
14102 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14103
14104 * termhooks.h (encode_terminal_code): Declare prototype.
14105
14106 * msdos.c (encode_terminal_code): Don't declare prototype.
14107
14108 * term.c (encode_terminal_code): Now external again, used by
14109 w32console.c and msdos.c.
14110
14111 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14112 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14113
14114 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14115
14116 Fix some minor problems found by GCC 4.5.2's static checks.
14117
14118 * fringe.c (update_window_fringes): Mark locals as initialized
14119 (Bug#8227).
14120 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14121
14122 * alloc.c (mark_fringe_data): Move decl from here ...
14123 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14124 to check its interface.
14125 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14126
14127 * fontset.c (free_realized_fontset): Now static.
14128 (Fset_fontset_font): Rename local to avoid shadowing.
14129 (fontset_font): Mark local as initialized.
14130 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14131
14132 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14133
14134 * xselect.c (x_disown_buffer_selections): Remove; not used.
14135 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14136 (x_own_selection, Fx_disown_selection_internal): Rename locals
14137 to avoid shadowing.
14138 (x_handle_dnd_message): Remove local to avoid shadowing.
14139
14140 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14141 so that the caller can use some name other than gcpro1.
14142 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14143 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14144 (Fx_backspace_delete_keys_p):
14145 Use them to avoid shadowing, and rename vars to avoid shadowing.
14146 (x_decode_color, x_set_name, x_window): Now static.
14147 (Fx_create_frame): Add braces to silence GCC warning.
14148 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14149 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14150 Remove unused locals.
14151 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14152 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14153 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14154 macros.
14155
14156 * xterm.h (x_mouse_leave): New decl.
14157
14158 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14159 Remove unused functions.
14160 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14161 (x_calc_absolute_position): Now static.
14162 (XTread_socket): Don't define label "out" unless it's used.
14163 Don't declare local "event" unless it's used.
14164 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14165 unless they are used.
14166 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14167 (x_fatal_error_signal): Remove; not used.
14168 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14169 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14170 (x_error_catcher, x_connection_closed, x_error_handler):
14171 (x_error_quitter, xembed_send_message, x_iconify_frame):
14172 (my_log_handler): Rename locals to avoid shadowing.
14173 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14174 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14175
14176 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14177 Rename or move locals to avoid shadowing.
14178 (tty_defined_color, merge_face_heights): Now static.
14179 (free_realized_faces_for_fontset): Remove; not used.
14180 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14181 does not deduce is never used uninitialized.
14182 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14183 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14184
14185 * terminal.c (store_terminal_param): Now static.
14186
14187 * xmenu.c (menu_highlight_callback): Now static.
14188 (set_frame_menubar): Remove unused local.
14189 (xmenu_show): Rename parameter to avoid shadowing.
14190 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14191 since they might point to immutable storage.
14192 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14193 since it's unused otherwise.
14194
14195 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14196 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14197 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14198 avoids a gcc -Wuninitialized diagnostic.
14199 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14200 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14201 does not deduce are never used uninitialized.
14202
14203 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14204
14205 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14206 * window.c (window_loop, size_window):
14207 (run_window_configuration_change_hook, enlarge_window): Likewise.
14208
14209 * window.c (display_buffer): Now static.
14210 (size_window): Mark variables that gcc -Wuninitialized
14211 does not deduce are never used uninitialized.
14212 * window.h (check_all_windows): New decl, to forestall
14213 gcc -Wmissing-prototypes diagnostic.
14214 * dispextern.h (bidi_dump_cached_states): Likewise.
14215
14216 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14217 shadowing.
14218 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14219 Include <limits.h>.
14220 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14221 and to avoid gcc -Wuninitialized warning.
14222 (load_charset_map): Mark variables that gcc -Wuninitialized
14223 does not deduce are never used uninitialized.
14224 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14225
14226 * coding.c (coding_set_source, coding_set_destination):
14227 Use "else { /* comment */ }" rather than "else /* comment */;"
14228 for clarity, and to avoid gcc -Wempty-body warning.
14229 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14230 a block, when the outer 'i' will do.
14231 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14232 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14233 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14234 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14235 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14236 Rename locals to avoid shadowing.
14237 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14238 * coding.c (emacs_mule_char, encode_invocation_designation):
14239 Now static, since they're not used elsewhere.
14240 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14241 (decode_coding_object, encode_coding_object, detect_coding_system):
14242 (decode_coding_emacs_mule): Mark variables that gcc
14243 -Wuninitialized does not deduce are never used uninitialized.
14244 (detect_coding_iso_2022): Initialize a local variable that might
14245 be used uninitialized. Leave a FIXME because it's not clear that
14246 this initialization is needed. (Bug#8211)
14247 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14248 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14249 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14250 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14251 Remove unused macros.
14252
14253 * category.c (hash_get_category_set): Remove unused local var.
14254 (copy_category_table): Now static, since it's not used elsewhere.
14255 * character.c (string_count_byte8): Likewise.
14256
14257 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14258 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14259
14260 * chartab.c (copy_sub_char_table): Now static, since it's not used
14261 elsewhere.
14262 (sub_char_table_ref_and_range, char_table_ref_and_range):
14263 Rename locals to avoid shadowing.
14264 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14265
14266 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14267 (BIDI_BOB): Remove unused macro.
14268
14269 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14270 deduce are never used uninitialized.
14271 * term.c (encode_terminal_code): Likewise.
14272
14273 * term.c (encode_terminal_code): Now static. Remove unused local.
14274
14275 * tparam.h: New file.
14276 * term.c, tparam.h: Include it.
14277 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14278 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14279 Move these decls to tparam.h, and make them agree with what
14280 is actually in tparam.c. The previous trick of using incompatible
14281 decls in different modules does not conform to the C standard.
14282 All callers of tparam changed to use tparam's actual API.
14283 * tparam.c (tparam1, tparam, tgoto):
14284 Use const pointers where appropriate.
14285
14286 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14287 * cm.h (struct cm): Likewise.
14288 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14289 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14290 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14291 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14292 (turn_on_face, init_tty): Likewise.
14293 * termchar.h (struct tty_display_info): Likewise.
14294
14295 * term.c (term_mouse_position): Rename local to avoid shadowing.
14296
14297 * alloc.c (mark_ttys): Move decl from here ...
14298 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14299
14300 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14301
14302 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14303
14304 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14305
14306 * search.c (compile_pattern_1): Remove argument regp, unused since
14307 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14308 (compile_pattern): Don't pass it.
14309
14310 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14311
14312 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14313 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14314 for ! HAVE_GTK3.
14315 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14316
14317 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14318
14319 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14320 gdk_window_get_screen, gdk_window_get_geometry,
14321 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14322 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14323 (xg_get_pixbuf_from_pixmap): New function.
14324 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14325 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14326 Call xg_get_pixbuf_from_pixmap instead of
14327 gdk_pixbuf_get_from_drawable.
14328 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14329 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14330 (xg_check_special_colors): Use GtkStyleContext and its functions
14331 for HAVE_GTK3.
14332 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14333 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14334 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14335 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14336 Call gtk_widget_get_preferred_size.
14337 (xg_frame_resized): gdk_window_get_geometry only takes 5
14338 parameters.
14339 (xg_win_to_widget, xg_event_is_for_menubar):
14340 Call gdk_x11_window_lookup_for_display.
14341 (xg_set_widget_bg): New function.
14342 (delete_cb): New function.
14343 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14344 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14345 (xg_set_background_color): Call xg_set_widget_bg.
14346 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14347 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14348 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14349 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14350 if ! HAVE_GTK3.
14351 (update_frame_tool_bar): Call gtk_widget_hide.
14352 (xg_initialize): Use GDK_KEY_g.
14353
14354 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14355 if ! HAVE_GTK3
14356 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14357
14358 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14359 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14360 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14361
14362 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14363
14364 * w32xfns.c (select_palette): Check success of RealizePalette against
14365 GDI_ERROR, not zero.
14366
14367 See ChangeLog.11 for earlier changes.
14368
14369 ;; Local Variables:
14370 ;; coding: utf-8
14371 ;; End:
14372
14373 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14374
14375 This file is part of GNU Emacs.
14376
14377 GNU Emacs is free software: you can redistribute it and/or modify
14378 it under the terms of the GNU General Public License as published by
14379 the Free Software Foundation, either version 3 of the License, or
14380 (at your option) any later version.
14381
14382 GNU Emacs is distributed in the hope that it will be useful,
14383 but WITHOUT ANY WARRANTY; without even the implied warranty of
14384 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14385 GNU General Public License for more details.
14386
14387 You should have received a copy of the GNU General Public License
14388 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.