* fns.c (Fcopy_sequence): Don't assume vector length fits in int.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-14 Paul Eggert <eggert@cs.ucla.edu>
2
3 * fns.c: Don't overflow int when computing a list length.
4 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6 truncation on 64-bit hosts. Check for QUIT every
7 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8 faster and is responsive enough.
9 (Flength): Report an error instead of overflowing an integer.
10 (Fsafe_length): Return a float if the value is not representable
11 as a fixnum. This shouldn't happen except in contrived situations.
12 (Fnthcdr, Fsort): Don't assume list length fits in int.
13 (Fcopy_sequence): Don't assume vector length fits in int.
14
15 * alloc.c: Check that resized vectors' lengths fit in fixnums.
16 (header_size, word_size): New constants.
17 (allocate_vectorlike): Don't check size overflow here.
18 (allocate_vector): Check it here instead, since this is the only
19 caller of allocate_vectorlike that could cause overflow.
20 Check that the new vector's length is representable as a fixnum.
21
22 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
23 The previous code was bogus. For example, next_almost_prime (32)
24 returned 39, which is undesirable as it is a multiple of 3; and
25 next_almost_prime (24) returned 25, which is a multiple of 5 so
26 why was the code bothering to check for multiples of 7?
27
28 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
29
30 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
31
32 Variadic C functions now count arguments with ptrdiff_t.
33 This partly undoes my 2011-03-30 change, which replaced int with size_t.
34 Back then I didn't know that the Emacs coding style prefers signed int.
35 Also, in the meantime I found a few more instances where arguments
36 were being counted with int, which may truncate counts on 64-bit
37 machines, or EMACS_INT, which may be unnecessarily wide.
38 * lisp.h (struct Lisp_Subr.function.aMANY)
39 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
40 Arg counts are now ptrdiff_t, not size_t.
41 All variadic functions and their callers changed accordingly.
42 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
43 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
44 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
45 * callint.c (Fcall_interactively): Check arg count for overflow,
46 to avoid potential buffer overrun. Use signed char, not 'int',
47 for 'varies' array, so that we needn't bother to check its size
48 calculation for overflow.
49 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
50 * eval.c (apply_lambda):
51 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
52 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
53 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
54
55 * callint.c (Fcall_interactively): Don't use index var as event count.
56
57 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
58 * mem-limits.h (SIZE): Remove; no longer used.
59
60 2011-06-13 Paul Eggert <eggert@cs.ucla.edu>
61
62 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
63
64 Remove unnecessary casts.
65 * xterm.c (x_term_init):
66 * xfns.c (x_set_border_pixel):
67 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
68 These aren't needed now that we assume ANSI C.
69
70 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
71 It's more likely to cause problems (due to unsigned overflow)
72 than to cure them.
73
74 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
75
76 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
77
78 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
79
80 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
81
82 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
83
84 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
85
86 GLYPH_CODE_FACE returns EMACS_INT, not int.
87 * dispextern.h (merge_faces):
88 * xfaces.c (merge_faces):
89 * xdisp.c (get_next_display_element, next_element_from_display_vector):
90 Don't assume EMACS_INT fits in int.
91
92 * character.h (CHAR_VALID_P): Remove unused parameter.
93 * fontset.c, lisp.h, xdisp.c: All uses changed.
94
95 * editfns.c (Ftranslate_region_internal): Omit redundant test.
96
97 * fns.c (concat): Minor tuning based on overflow analysis.
98 This doesn't fix any bugs. Use int to hold character, instead
99 of constantly refetching from Emacs object. Use XFASTINT, not
100 XINT, for value known to be a character. Don't bother comparing
101 a single byte to 0400, as it's always less.
102
103 * floatfns.c (Fexpt):
104 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
105
106 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
107 for characters.
108
109 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
110
111 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
112 Without this fix, on a 64-bit host (aset S 0 4294967386) would
113 incorrectly succeed when S was a string, because 4294967386 was
114 truncated before it was used.
115
116 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
117 Otherwise, an out-of-range integer could cause undefined behavior
118 on a 64-bit host.
119
120 * composite.c: Use int, not EMACS_INT, for characters.
121 (fill_gstring_body, composition_compute_stop_pos): Use int, not
122 EMACS_INT, for values that are known to be in character range.
123 This doesn't fix any bugs but is the usual style inside Emacs and
124 may generate better code on 32-bit machines.
125
126 Make sure a 64-bit char is never passed to ENCODE_CHAR.
127 This is for reasons similar to the recent CHAR_STRING fix.
128 * charset.c (Fencode_char): Check that character arg is actually
129 a character. Pass an int to ENCODE_CHAR.
130 * charset.h (ENCODE_CHAR): Verify that the character argument is no
131 wider than 'int', as a compile-time check to prevent future regressions
132 in this area.
133
134 * character.c (char_string): Remove unnecessary casts.
135
136 Make sure a 64-bit char is never passed to CHAR_STRING.
137 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
138 by silently ignoring the top 32 bits, allowing some values
139 that were far too large to be valid characters.
140 * character.h: Include <verify.h>.
141 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
142 arguments are no wider than unsigned, as a compile-time check
143 to prevent future regressions in this area.
144 * data.c (Faset):
145 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
146 (Fsubst_char_in_region):
147 * fns.c (concat):
148 * xdisp.c (decode_mode_spec_coding):
149 Adjust to CHAR_STRING's new requirement.
150 * editfns.c (Finsert_char, Fsubst_char_in_region):
151 * fns.c (concat): Check that character args are actually
152 characters. Without this test, these functions did the wrong
153 thing with wildly out-of-range values on 64-bit hosts.
154
155 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
156 These casts should not be needed on 32-bit hosts, either.
157 * keyboard.c (read_char):
158 * lread.c (Fload): Remove casts to unsigned.
159
160 * lisp.h (UNSIGNED_CMP): New macro.
161 This fixes comparison bugs on 64-bit hosts.
162 (ASCII_CHAR_P): Use it.
163 * casefiddle.c (casify_object):
164 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
165 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
166 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
167 * dispextern.h (FACE_FROM_ID):
168 * keyboard.c (read_char): Use UNSIGNED_CMP.
169
170 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
171 not to EMACS_INT, to avoid GCC warning.
172
173 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
174
175 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
176 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
177 isn't needed on 32-bit machines.
178
179 * buffer.c (Fgenerate_new_buffer_name):
180 Use EMACS_INT for count, not int.
181 (advance_to_char_boundary): Return EMACS_INT, not int.
182
183 * data.c (Qcompiled_function): Now static.
184
185 * window.c (window_body_lines): Now static.
186
187 * image.c (gif_load): Rename local to avoid shadowing.
188
189 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
190 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
191 * alloc.c (make_save_value): Integer argument is now of type
192 ptrdiff_t, not int.
193 (mark_object): Use ptrdiff_t, not int.
194 * lisp.h (pD): New macro.
195 * print.c (print_object): Use it.
196
197 * alloc.c: Use EMACS_INT, not int, to count objects.
198 (total_conses, total_markers, total_symbols, total_vector_size)
199 (total_free_conses, total_free_markers, total_free_symbols)
200 (total_free_floats, total_floats, total_free_intervals)
201 (total_intervals, total_strings, total_free_strings):
202 Now EMACS_INT, not int. All uses changed.
203 (Fgarbage_collect): Compute overall total using a double, so that
204 integer overflow is less likely to be a problem. Check for overflow
205 when converting back to an integer.
206 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
207 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
208 These were 'int' variables that could overflow on 64-bit hosts;
209 they were never used, so remove them instead of repairing them.
210 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
211 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
212 Previously, this ceilinged at INT_MAX, but that doesn't work on
213 64-bit machines.
214 (allocate_pseudovector): Don't use EMACS_INT when int would do.
215
216 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
217 (allocate_vectorlike): Check for ptrdiff_t overflow.
218 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
219 when a (possibly-narrower) signed value would do just as well.
220 We prefer using signed arithmetic, to avoid comparison confusion.
221
222 * alloc.c: Catch some string size overflows that we were missing.
223 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
224 for convenience in STRING_BYTES_MAX.
225 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
226 The definition here is exact; the one in lisp.h was approximate.
227 (allocate_string_data): Check for string overflow. This catches
228 some instances we weren't catching before. Also, it catches
229 size_t overflow on (unusual) hosts where SIZE_MAX <= min
230 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
231 and ptrdiff_t and EMACS_INT are both 64 bits.
232
233 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
234 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
235 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
236
237 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
238
239 * alloc.c (Fmake_string): Check for out-of-range init.
240
241 2011-06-12 Martin Rudalics <rudalics@gmx.at>
242
243 * frame.c (make_frame): Call other_buffer_safely instead of
244 other_buffer.
245
246 * window.c (temp_output_buffer_show): Call display_buffer with
247 second argument Vtemp_buffer_show_specifiers and reset latter
248 immediately after the call.
249 (Vtemp_buffer_show_specifiers): New variable.
250 (auto_window_vscroll_p, next_screen_context_lines)
251 (Vscroll_preserve_screen_position): Remove leading asterisks from
252 doc-strings.
253
254 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
255
256 Fix minor problems found by GCC 4.6.0 static checking.
257 * buffer.c (Qclone_number): Remove for now, as it's unused.
258 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
259 (record_buffer): Remove unused local.
260 * frame.c (other_visible_frames, frame_buffer_list): Now static.
261 (set_frame_buffer_list): Remove; unused.
262 * frame.h (other_visible_frames): Remove decl.
263 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
264 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
265 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
266 if HAVE_GPM.
267 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
268 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
269 Define only if HAVE_GPM.
270 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
271 (update_hints_inhibit): Remove; never set. All uses removed.
272 * widgetprv.h (emacsFrameClassRec): Remove decl.
273 * window.c (delete_deletable_window): Now returns void, since it
274 wasn't returning anything.
275 (compare_window_configurations): Remove unused locals.
276 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
277 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
278 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
279 the same widths as pointers. This follows up on the 2011-05-06 patch.
280 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
281 * xterm.h: Likewise.
282 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
283
284 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
285
286 * makefile.w32-in: Update dependencies.
287 (LISP_H): Add lib/intprops.h.
288
289 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
290
291 * image.c (gif_load): Add animation frame delay to the metadata.
292 (syms_of_image): Use DEFSYM. New symbol `delay'.
293
294 2011-06-11 Martin Rudalics <rudalics@gmx.at>
295
296 * window.c (delete_deletable_window): Re-add.
297 (Fset_window_configuration): Rewrite to handle dead buffers and
298 consequently deletable windows.
299 (window_tree, Fwindow_tree): Remove. Supply functionality in
300 window.el.
301 (compare_window_configurations): Simplify code.
302
303 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
304
305 * image.c (imagemagick_load_image): Fix type mismatch.
306 (Fimagemagick_types): Likewise.
307
308 * window.h (replace_buffer_in_windows): Declare.
309
310 2011-06-11 Martin Rudalics <rudalics@gmx.at>
311
312 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
313 Qclone_number. Remove external declaration of Qdelete_window.
314 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
315 code.
316 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
317 Qbuffer_list_update_hook if allowed.
318 (Fother_buffer): Rewrite doc-string. Major rewrite for new
319 buffer list implementation.
320 (other_buffer_safely): New function.
321 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
322 calls to replace_buffer_in_windows and
323 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
324 if allowed.
325 (record_buffer): Inhibit quitting and rewrite using quittable
326 functions. Run Qbuffer_list_update_hook if allowed.
327 (Frecord_buffer, Funrecord_buffer): New functions.
328 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
329 switch-to-buffer to window.el.
330 (bury-buffer): Move to window.el.
331 (Vbuffer_list_update_hook): New variable.
332
333 * lisp.h (other_buffer_safely): Add prototype in buffer.c
334 section.
335
336 * window.h (resize_frame_windows): Move up in code.
337 (Fwindow_frame): Remove EXFUN.
338 (replace_buffer_in_all_windows): Remove prototype.
339 (replace_buffer_in_windows_safely): Add prototype.
340
341 * window.c: Declare Qdelete_window static again. Move down
342 declaration of select_count.
343 (Fnext_window, Fprevious_window): Rewrite doc-strings.
344 (Fother_window): Move to window.el.
345 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
346 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
347 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
348 window.el.
349 (replace_buffer_in_windows): Implement by calling
350 Qreplace_buffer_in_windows.
351 (replace_buffer_in_all_windows): Remove with some functionality
352 moved into replace_buffer_in_windows_safely.
353 (replace_buffer_in_windows_safely): New function.
354 (select_window_norecord, select_frame_norecord): Move in front
355 of run_window_configuration_change_hook. Remove now obsolete
356 declarations.
357 (Fset_window_buffer): Rewrite doc-string. Call
358 Qrecord_window_buffer.
359 (keys_of_window): Move binding for other-window to window.el.
360
361 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
362
363 * dispextern.h (struct image): Replace data member, whose int_val
364 and ptr_val fields were not used by anything, with a single
365 lisp_val object.
366
367 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
368 (gif_clear_image, gif_load, imagemagick_load_image)
369 (gs_clear_image, gs_load): Callers changed.
370
371 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
372
373 * buffer.h: Include <time.h>, for time_t.
374 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
375
376 Fix minor problems found by static checking.
377
378 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
379
380 Make identifiers static if they are not used in other modules.
381 * data.c (Qcompiled_function, Qframe, Qvector):
382 * image.c (QimageMagick, Qsvg):
383 * minibuf.c (Qmetadata):
384 * window.c (resize_window_check, resize_root_window): Now static.
385 * window.h (resize_window_check, resize_root_window): Remove decls.
386
387 * window.c (window_deletion_count, delete_deletable_window):
388 Remove; unused.
389 (window_body_lines): Now static.
390 (Fdelete_other_windows_internal): Mark vars as initialized.
391 Make sure 'resize_failed' is initialized.
392 (run_window_configuration_change_hook): Rename local to avoid shadowing.
393 (resize_window_apply): Remove unused local.
394 * window.h (delete_deletable_window): Remove decl.
395
396 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
397 (imagemagick_load_image): Fix pointer signedness problem by changing
398 last arg from unsigned char * to char *. All uses changed.
399 Also, fix a local for similar reasons.
400 Remove unused locals. Remove locals to avoid shadowing.
401 (fn_rsvg_handle_free): Remove; unused.
402 (svg_load, svg_load_image): Fix pointer signedness problem.
403 (imagemagick_load_image): Don't use garbage pointer image_wand.
404
405 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
406
407 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
408
409 * image.c (gif_load): Fix omitted cast error introduced by
410 2011-06-06 change.
411
412 2011-06-10 Martin Rudalics <rudalics@gmx.at>
413
414 * window.h (resize_proportionally, orig_total_lines)
415 (orig_top_line): Remove from window structure.
416 (set_window_height, set_window_width, change_window_heights)
417 (Fdelete_window): Remove prototypes.
418 (resize_frame_windows): Remove duplicate declaration.
419
420 2011-06-10 Eli Zaretskii <eliz@gnu.org>
421
422 * window.h (resize_frame_windows, resize_window_check)
423 (delete_deletable_window, resize_root_window)
424 (resize_frame_windows): Declare prototypes.
425
426 * window.c (resize_window_apply): Make definition be "static" to
427 match the prototype.
428
429 2011-06-10 Martin Rudalics <rudalics@gmx.at>
430
431 * window.c: Remove declarations of Qwindow_size_fixed,
432 window_min_size_1, window_min_size_2, window_min_size,
433 size_window, window_fixed_size_p, enlarge_window, delete_window.
434 Remove static from declaration of Qdelete_window, it's
435 temporarily needed by Fbury_buffer.
436 (replace_window): Don't assign orig_top_line and
437 orig_total_lines.
438 (Fdelete_window, delete_window): Remove. Window deletion is
439 handled by window.el.
440 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
441 Fdelete_window calls with calls to Qdelete_window.
442 (Fdelete_other_windows): Remove. Deleting other windows is
443 handled by window.el.
444 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
445 handled in window.el.
446 (window_min_size_2, window_min_size_1, window_min_size): Remove.
447 Window minimum sizes are handled in window.el.
448 (shrink_windows, size_window, set_window_height)
449 (set_window_width, change_window_heights, window_height)
450 (window_width, CURBEG, CURSIZE, enlarge_window)
451 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
452 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
453 handled in window.el.
454 (make_dummy_parent): Rename to make_parent_window and give it a
455 second argument horflag.
456 (make_window): Don't set resize_proportionally any more.
457 (Fsplit_window): Remove. Windows are split in window.el.
458 (save_restore_action, save_restore_orig_size)
459 (shrink_window_lowest_first, save_restore_orig_size): Remove.
460 Resize mini windows in window.el.
461 (grow_mini_window, shrink_mini_window): Implement by calling
462 Qresize_root_window_vertically, resize_window_check and
463 resize_window_apply.
464 (saved_window, Fset_window_configuration, save_window_save): Do
465 not handle orig_top_line, orig_total_lines, and
466 resize_proportionally.
467 (window_min_height, window_min_width): Move to window.el.
468 (keys_of_window): Move bindings for delete-other-windows,
469 split-window, delete-window and enlarge-window to window.el.
470
471 * buffer.c: Temporarily extern Qdelete_window.
472 (Fbury_buffer): Temporarily call Qdelete_window instead of
473 Fdelete_window (Fbury_buffer will move to window.el soon).
474
475 * frame.c (set_menu_bar_lines_1): Remove code handling
476 orig_top_line and orig_total_lines.
477
478 * dispnew.c (adjust_frame_glyphs_initially): Don't use
479 set_window_height but set heights directly.
480 (change_frame_size_1): Use resize_frame_windows.
481
482 * xdisp.c (init_xdisp): Don't use set_window_height but set
483 heights directly.
484
485 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
486 resize_frame_windows instead of change_window_heights and run
487 run_window_configuration_change_hook.
488
489 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
490 instead of change_window_heights and run
491 run_window_configuration_change_hook.
492
493 2011-06-09 Martin Rudalics <rudalics@gmx.at>
494
495 * window.c (replace_window): Rename second argument REPLACEMENT to
496 NEW. New third argument SETFLAG. Rewrite.
497 (delete_window, make_dummy_parent): Call replace_window with
498 third argument 1.
499 (window_list_1): Move down in code.
500 (run_window_configuration_change_hook): Move set_buffer part
501 before select_frame_norecord part in order to unwind correctly.
502 Rename count1 to count.
503 (recombine_windows, delete_deletable_window, resize_root_window)
504 (Fdelete_other_windows_internal)
505 (Frun_window_configuration_change_hook, make_parent_window)
506 (resize_window_check, resize_window_apply, Fresize_window_apply)
507 (resize_frame_windows, Fsplit_window_internal)
508 (Fdelete_window_internal, Fresize_mini_window_internal): New
509 functions.
510 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
511
512 2011-06-08 Martin Rudalics <rudalics@gmx.at>
513
514 * window.h (window): Add some new members to window structure -
515 normal_lines, normal_cols, new_total, new_normal, clone_number,
516 splits, nest, prev_buffers, next_buffers.
517 (WINDOW_TOTAL_SIZE): Move here from window.c.
518 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
519
520 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
521 Remove.
522 (make_dummy_parent): Set new members of windows structure.
523 (make_window): Move down in code. Handle new members of window
524 structure.
525 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
526 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
527 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
528 (Fset_window_prev_buffers, Fwindow_next_buffers)
529 (Fset_window_next_buffers, Fset_window_clone_number): New
530 functions.
531 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
532 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
533 Doc-string fixes.
534 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
535 Argument WINDOW can be now internal window too.
536 (Fwindow_use_time): Move up in code.
537 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
538 Rewrite doc-string.
539 (Fset_window_configuration, saved_window)
540 (Fcurrent_window_configuration, save_window_save): Handle new
541 members of window structure.
542 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
543 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
544 (syms_of_window): New Lisp objects Qrecord_window_buffer,
545 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
546 Qget_mru_window, Qresize_root_window,
547 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
548 Qauto_buffer_name; staticpro them.
549
550 2011-06-07 Martin Rudalics <rudalics@gmx.at>
551
552 * window.c (Fwindow_total_size, Fwindow_left_column)
553 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
554 (Fwindow_list_1): New functions.
555 (window_box_text_cols): Replace with window_body_cols.
556 (Fwindow_width, Fscroll_left, Fscroll_right): Use
557 window_body_cols instead of window_box_text_cols.
558 (delete_window, Fset_window_configuration): Call
559 delete_all_subwindows with window as argument.
560 (delete_all_subwindows): Take a window as argument and not a
561 structure. Rewrite.
562 (window_loop): Remove handling of GET_LRU_WINDOW and
563 GET_LARGEST_WINDOW.
564 (Fget_lru_window, Fget_largest_window): Move to window.el.
565
566 * window.h: Extern window_body_cols instead of
567 window_box_text_cols. delete_all_subwindows now takes a
568 Lisp_Object as argument.
569
570 * indent.c (compute_motion, Fcompute_motion): Use
571 window_body_cols instead of window_box_text_cols.
572
573 * frame.c (delete_frame): Call delete_all_subwindows with root
574 window as argument.
575
576 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
577
578 * fns.c (Fputhash): Document return value.
579
580 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
581
582 * image.c (gif_load): Implement gif89a spec "no disposal" method.
583
584 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
585
586 Cons<->int and similar integer overflow fixes (Bug#8794).
587
588 Check for overflow when converting integer to cons and back.
589 * charset.c (Fdefine_charset_internal, Fdecode_char):
590 Use cons_to_unsigned to catch overflow.
591 (Fencode_char): Use INTEGER_TO_CONS.
592 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
593 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
594 * data.c (long_to_cons, cons_to_long): Remove.
595 (cons_to_unsigned, cons_to_signed): New functions.
596 These signal an error for invalid or out-of-range values.
597 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
598 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
599 * font.c (Ffont_variation_glyphs):
600 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
601 * lisp.h: Include <intprops.h>.
602 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
603 (cons_to_signed, cons_to_unsigned): New decls.
604 (long_to_cons, cons_to_long): Remove decls.
605 * undo.c (record_first_change): Use INTEGER_TO_CONS.
606 (Fprimitive_undo): Use CONS_TO_INTEGER.
607 * xfns.c (Fx_window_property): Likewise.
608 * xselect.c: Include <limits.h>.
609 (x_own_selection, selection_data_to_lisp_data):
610 Use INTEGER_TO_CONS.
611 (x_handle_selection_request, x_handle_selection_clear)
612 (x_get_foreign_selection, Fx_disown_selection_internal)
613 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
614 (lisp_data_to_selection_data): Use cons_to_unsigned.
615 (x_fill_property_data): Use cons_to_signed.
616 Report values out of range.
617
618 Check for buffer and string overflow more precisely.
619 * buffer.h (BUF_BYTES_MAX): New macro.
620 * lisp.h (STRING_BYTES_MAX): New macro.
621 * alloc.c (Fmake_string):
622 * character.c (string_escape_byte8):
623 * coding.c (coding_alloc_by_realloc):
624 * doprnt.c (doprnt):
625 * editfns.c (Fformat):
626 * eval.c (verror):
627 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
628 since they may not be the same number.
629 * editfns.c (Finsert_char):
630 * fileio.c (Finsert_file_contents):
631 Likewise for BUF_BYTES_MAX.
632
633 * image.c: Use ptrdiff_t, not int, for sizes.
634 (slurp_file): Switch from int to ptrdiff_t.
635 All uses changed.
636 (slurp_file): Check that file size fits in both size_t (for
637 malloc) and ptrdiff_t (for sanity and safety).
638
639 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
640 if b->modtime has its maximal value.
641
642 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
643
644 Don't assume time_t can fit into int.
645 * buffer.h (struct buffer.modtime): Now time_t, not int.
646 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
647 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
648
649 Minor fixes for signed vs unsigned integers.
650 * character.h (MAYBE_UNIFY_CHAR):
651 * charset.c (maybe_unify_char):
652 * keyboard.c (read_char, reorder_modifiers):
653 XINT -> XFASTINT, since the integer must be nonnegative.
654 * ftfont.c (ftfont_spec_pattern):
655 * keymap.c (access_keymap, silly_event_symbol_error):
656 XUINT -> XFASTINT, since the integer must be nonnegative.
657 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
658 since it makes no difference and we prefer signed.
659 * keyboard.c (record_char): Use XUINT when all the neighbors do.
660 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
661 nonnegative.
662
663 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
664
665 * window.h (Fwindow_frame): Declare.
666
667 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
668
669 * alloc.c: Simplify handling of large-request failures (Bug#8800).
670 (SPARE_MEMORY): Always define.
671 (LARGE_REQUEST): Remove.
672 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
673
674 2011-06-06 Martin Rudalics <rudalics@gmx.at>
675
676 * lisp.h: Move EXFUNS for Fframe_root_window,
677 Fframe_first_window and Fset_frame_selected_window to window.h.
678
679 * window.h: Move EXFUNS for Fframe_root_window,
680 Fframe_first_window and Fset_frame_selected_window here from
681 lisp.h.
682
683 * frame.c (Fwindow_frame, Fframe_first_window)
684 (Fframe_root_window, Fframe_selected_window)
685 (Fset_frame_selected_window): Move to window.c.
686 (Factive_minibuffer_window): Move to minibuf.c.
687 (Fother_visible_frames_p): New function.
688
689 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
690
691 * window.c (decode_window, decode_any_window): Move up in code.
692 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
693 (inhibit_frame_unsplittable): Remove unused variable.
694 (Fwindow_buffer): Move up and rewrite doc-string.
695 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
696 (Fwindow_prev): New functions.
697 (Fwindow_frame): Move here from frame.c. Accept any window as
698 argument.
699 (Fframe_root_window, Fframe_first_window)
700 (Fframe_selected_window): Move here from frame.c. Accept frame
701 or arbitrary window as argument. Update doc-strings.
702 (Fminibuffer_window): Move up in code.
703 (Fwindow_minibuffer_p): Move up in code and simplify.
704 (Fset_frame_selected_window): Move here from frame.c.
705 Marginal rewrite.
706 (Fselected_window, select_window, Fselect_window): Move up in
707 code. Minor doc-string fixes.
708
709 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
710
711 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
712 Do not assume that spare memory exists; that assumption is valid
713 only if SYSTEM_MALLOC.
714 (LARGE_REQUEST): New macro, so that the issue of large requests
715 is separated from the issue of spare memory.
716
717 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
718
719 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
720 format. (Bug#8806)
721
722 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
723
724 * xfns.c (x_set_scroll_bar_default_width): Move declarations
725 before statements.
726
727 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
728
729 * gtkutil.c (xg_get_default_scrollbar_width): New function.
730
731 * gtkutil.h: Declare xg_get_default_scrollbar_width.
732
733 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
734 min width by calling x_set_scroll_bar_default_width (Bug#8505).
735
736 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
737
738 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
739
740 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
741
742 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
743 (x_clipboard_manager_save): Add return value.
744 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
745 New error handlers.
746 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
747 Obey Vx_select_enable_clipboard_manager. Catch errors in
748 x_clipboard_manager_save (Bug#8779).
749 (Vx_select_enable_clipboard_manager): New variable.
750 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
751
752 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
753
754 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
755
756 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
757
758 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
759 in the current matrix if keep_current_p is non-zero.
760
761 2011-06-04 Eli Zaretskii <eliz@gnu.org>
762
763 * bidi.c (bidi_level_of_next_char): Fix last change.
764
765 2011-06-03 Eli Zaretskii <eliz@gnu.org>
766
767 Support bidi reordering of text covered by display properties.
768
769 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
770 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
771 (bidi_cache_search, bidi_cache_iterator_state)
772 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
773 (bidi_level_of_next_char, bidi_move_to_visually_next):
774 Support character positions inside a run of characters covered by a
775 display string.
776 (bidi_paragraph_init, bidi_resolve_explicit_1)
777 (bidi_level_of_next_char): Call bidi_fetch_char and
778 bidi_fetch_char_advance instead of FETCH_CHAR and
779 FETCH_CHAR_ADVANCE.
780 (bidi_init_it): Initialize new members.
781 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
782 definitions.
783 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
784 instead of using explicit *_CHAR codes.
785 (bidi_resolve_explicit, bidi_resolve_weak):
786 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
787 bidirectional text is supported only in multibyte buffers.
788 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
789 it to initialize the frame_window_p member of struct bidi_it.
790 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
791 (bidi_resolve_explicit, bidi_resolve_weak)
792 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
793 bidi_it->nchars is non-positive.
794 (bidi_level_of_next_char): Don't try to lookup the cache for the
795 next/previous character if nothing is cached there yet, or if we
796 were just reseat()'ed to a new position.
797
798 * xdisp.c (set_cursor_from_row): Set start and stop points
799 according to the row's direction when priming the loop that looks
800 for the glyph on which to display cursor.
801 (single_display_spec_intangible_p): Function deleted.
802 (display_prop_intangible_p): Reimplement to call
803 handle_display_spec instead of single_display_spec_intangible_p.
804 Accept 3 additional arguments needed by handle_display_spec.
805 This fixes incorrect cursor motion across display property with complex
806 values: lists, `(when COND...)' forms, etc.
807 (single_display_spec_string_p): Support property values that are
808 lists with the argument STRING its top-level element.
809 (display_prop_string_p): Fix the condition for processing a
810 property that is a list to be consistent with handle_display_spec.
811 (handle_display_spec): New function, refactored from the
812 last portion of handle_display_prop.
813 (compute_display_string_pos): Accept additional argument
814 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
815 value of a `display' property is a "replacing spec".
816 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
817 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
818 the display property, but just return a value indicating whether
819 the display property will replace the characters it covers.
820 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
821 frame_window_p members of struct bidi_it.
822 (compute_display_string_pos, compute_display_string_end):
823 New functions.
824 (push_it): Accept second argument POSITION, where pop_it should
825 jump to continue iteration.
826 (reseat_1): Initialize bidi_it.disp_pos.
827
828 * keyboard.c (adjust_point_for_property): Adjust the call to
829 display_prop_intangible_p to its new signature.
830
831 * dispextern.h (struct bidi_it): New member frame_window_p.
832 (bidi_init_it): Update prototypes.
833 (display_prop_intangible_p): Update prototype.
834 (compute_display_string_pos, compute_display_string_end):
835 Declare prototypes.
836 (struct bidi_it): New members nchars and disp_pos. ch_len is now
837 EMACS_INT.
838
839 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
840
841 Malloc failure behavior now depends on size of allocation.
842 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
843 * lisp.h: Change signatures accordingly.
844 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
845 All callers changed. (Bug#8762)
846
847 * gnutls.c: Use Emacs's memory allocators.
848 Without this change, the gnutls library would invoke malloc etc.
849 directly, which causes problems on non-SYNC_INPUT hosts, and which
850 runs afoul of improving memory_full behavior. (Bug#8761)
851 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
852 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
853 xfree instead of the default malloc, realloc, free.
854 (Fgnutls_boot): No need to check for memory allocation failure,
855 since xmalloc does that for us.
856
857 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
858 * category.c (hash_get_category_set):
859 * ccl.c (ccl_driver):
860 * charset.c (Fdefine_charset_internal):
861 * charset.h (struct charset.hash_index):
862 * composite.c (get_composition_id, gstring_lookup_cache)
863 (composition_gstring_put_cache):
864 * composite.h (struct composition.hash_index):
865 * dispextern.h (struct image.hash):
866 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
867 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
868 (hashfn_equal, hashfn_user_defined, make_hash_table)
869 (maybe_resize_hash_table, hash_lookup, hash_put)
870 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
871 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
872 (Fsxhash, Fgethash, Fputhash, Fmaphash):
873 * image.c (make_image, search_image_cache, lookup_image)
874 (xpm_put_color_table_h):
875 * lisp.h (struct Lisp_Hash_Table):
876 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
877 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
878 for hashes and hash indexes, instead of 'unsigned' and 'int'.
879 * alloc.c (allocate_vectorlike):
880 Check for overflow in vector size calculations.
881 * ccl.c (ccl_driver):
882 Check for overflow when converting EMACS_INT to int.
883 * fns.c, image.c: Remove unnecessary static decls that would otherwise
884 need to be updated by these changes.
885 * fns.c (make_hash_table, maybe_resize_hash_table):
886 Check for integer overflow with large hash tables.
887 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
888 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
889 (SXHASH_REDUCE): New macro.
890 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
891 Use it instead of discarding useful hash info with large hash values.
892 (sxhash_float): New function.
893 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
894 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
895 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
896 Rewrite to use FIXNUM_BITS, as this simplifies things.
897 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
898 Adjust signatures to match updated version of code.
899 (consing_since_gc): Now EMACS_INT, since a single hash table can
900 use more than INT_MAX bytes.
901
902 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
903
904 Make it possible to build with GCC-4.6+ -O2 -flto.
905
906 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
907
908 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
909
910 * minibuf.c (get_minibuffer, read_minibuf_unwind):
911 Call minibuffer-inactive-mode.
912
913 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
914
915 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
916 Update dependencies.
917
918 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
919
920 * data.c (init_data): Remove code for UTS, this system is not
921 supported anymore.
922
923 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
924
925 Don't force ./temacs to start in terminal mode.
926
927 * frame.c (make_initial_frame): Initialize faces in all cases, not
928 only when CANNOT_DUMP is defined.
929 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
930
931 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
932
933 * dispnew.c (add_window_display_history): Use const for the string
934 pointer. Remove declaration, not needed.
935
936 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
937
938 Use 'inline', not 'INLINE'.
939 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
940 * alloc.c, fontset.c (INLINE): Remove.
941 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
942 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
943 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
944 * gmalloc.c (register_heapinfo): Use inline unconditionally.
945 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
946
947 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
948
949 Make it possible to run ./temacs.
950
951 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
952 syms_of_callproc does the same thing. Remove test for
953 "initialized", do it in the caller.
954 * emacs.c (main): Avoid calling set_initial_environment when dumping.
955
956 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
957
958 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
959 (read_minibuf): Use get_minibuffer.
960 (syms_of_minibuf): Use DEFSYM.
961 (Qmetadata): New var.
962 * data.c (Qbuffer): Don't make it static.
963 (syms_of_data): Use DEFSYM.
964
965 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
966
967 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
968 (CCL_CODE_MIN): New macro.
969
970 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
971
972 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
973
974 * eval.c (Qdebug): Now static.
975 * lisp.h (Qdebug): Remove decl. This reverts a part of the
976 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
977 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
978
979 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
980
981 * image.c: Various fixes to ImageMagick code comments.
982 (Fimagemagick_types): Doc fix.
983
984 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
985
986 Minor fixes prompted by GCC 4.6.0 warnings.
987
988 * xselect.c (converted_selections, conversion_fail_tag): Now static.
989
990 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
991 (x_clipboard_manager_save_all): Move extern decl to ...
992 * xterm.h: ... here, so that it can be checked for consistency.
993
994 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
995
996 * xselect.c (x_clipboard_manager_save_frame)
997 (x_clipboard_manager_save_all): New functions.
998 (Fx_clipboard_manager_save): Lisp function deleted.
999
1000 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1001 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1002
1003 * xterm.h: Update prototype.
1004
1005 2011-05-28 William Xu <william.xwl@gmail.com>
1006
1007 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1008 exiting (Bug#8239).
1009
1010 2011-05-28 Jim Meyering <meyering@redhat.com>
1011
1012 Avoid a sign-extension bug in crypto_hash_function.
1013 * fns.c (to_uchar): Define.
1014 (crypto_hash_function): Use it to convert some newly-signed
1015 variables to unsigned, to avoid sign-extension bugs. For example,
1016 without this change, (md5 "truc") would evaluate to
1017 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1018 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1019 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1020
1021 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 Integer overflow fixes.
1024
1025 * dbusbind.c: Serial number integer overflow fixes.
1026 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1027 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1028 to hold a serial number that is too large for a fixnum.
1029 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1030 Check for serial numbers out of range. Decode any serial number
1031 that was so large that it became a float. (Bug#8722)
1032
1033 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1034 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1035 Use XFASTINT rather than XUINT when numbers are nonnegative.
1036 (xd_append_arg, Fdbus_method_return_internal):
1037 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1038 arguments, check that Lisp number is nonnegative, rather than
1039 silently wrapping negative numbers around. (Bug#8722)
1040 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1041 (Bug#8722)
1042
1043 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1044
1045 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1046
1047 ccl: add integer overflow checks
1048 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1049 (IN_INT_RANGE): New macros.
1050 (ccl_driver): Use them to check for integer overflow when
1051 decoding a CCL program. Many of the new checks are whether XINT (x)
1052 fits in int; it doesn't always, on 64-bit hosts. The new version
1053 doesn't catch all possible integer overflows, but it's an
1054 improvement. (Bug#8719)
1055
1056 * alloc.c (make_event_array): Use XINT, not XUINT.
1057 There's no need for unsigned here.
1058
1059 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1060 This follows up to the 2011-05-06 change that substituted uintptr_t
1061 for EMACS_INT. This case wasn't caught back then.
1062
1063 Rework Fformat to avoid integer overflow issues.
1064 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1065 now (part of C89). Include <verify.h>.
1066 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1067 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1068 (Fformat): Avoid the prepass trying to compute sizes; it was only
1069 approximate and thus did not catch overflow reliably. Instead, walk
1070 through the format just once, formatting and computing sizes as we go,
1071 checking for integer overflow at every step, and allocating a larger
1072 buffer as needed. Keep track separately whether the format is
1073 multibyte. Keep only the most-recently calculated precision, rather
1074 than them all. Record whether each argument has been converted to
1075 string. Use EMACS_INT, not int, for byte and char and arg counts.
1076 Support field widths and precisions larger than INT_MAX. Avoid
1077 sprintf's undefined behavior with conversion specifications such as %#d
1078 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1079 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1080 formatting out-of-range floating point numbers with int
1081 formats. (Bug#8668)
1082
1083 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1084
1085 * data.c: Avoid integer truncation in expressions involving floats.
1086 * data.c: Include <intprops.h>.
1087 (arith_driver): When there's an integer overflow in an expression
1088 involving floating point, convert the integers to floating point
1089 so that the resulting value does not suffer from catastrophic
1090 integer truncation. For example, on a 64-bit host (* 4
1091 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1092 Do not rely on undefined behavior after integer overflow.
1093
1094 merge count_size_as_multibyte, parse_str_to_multibyte
1095 * character.c, character.h (count_size_as_multibyte):
1096 Rename from parse_str_to_multibyte; all uses changed.
1097 Check for integer overflow.
1098 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1099 since it's now a duplicate of the other. This is more of
1100 a character than a buffer op, so better that it's in character.c.
1101 * fns.c, print.c: Adjust to above changes.
1102
1103 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1104
1105 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1106
1107 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1108
1109 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1110 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1111 (x_clipboard_manager_save): Now static.
1112 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1113
1114 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1115 (crypto_hash_function): Now static.
1116 Fix pointer signedness problems. Avoid unnecessary initializations.
1117
1118 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1119
1120 * termhooks.h (Vselection_alist): Make it terminal-local.
1121
1122 * terminal.c (create_terminal): Initialize it.
1123
1124 * xselect.c: Support for clipboard managers.
1125 (Vselection_alist): Move to termhooks.h as terminal-local var.
1126 (LOCAL_SELECTION): New macro.
1127 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1128 (symbol_to_x_atom): Remove gratuitous arg.
1129 (x_handle_selection_request, lisp_data_to_selection_data)
1130 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1131 (x_own_selection, x_get_local_selection, x_convert_selection):
1132 New arg, specifying work frame. Use terminal-local Vselection_alist.
1133 (some_frame_on_display): Delete unused function.
1134 (Fx_own_selection_internal, Fx_get_selection_internal)
1135 (Fx_disown_selection_internal, Fx_selection_owner_p)
1136 (Fx_selection_exists_p): New optional frame arg.
1137 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1138 (x_handle_selection_clear): Don't treat other terminals with the
1139 same keyboard specially. Use the terminal-local Vselection_alist.
1140 (x_clear_frame_selections): Use Frun_hook_with_args.
1141
1142 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1143
1144 * xterm.h: Add support for those atoms.
1145
1146 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1147
1148 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1149 (converted_selections, conversion_fail_tag): New global variables.
1150 (x_selection_request_lisp_error): Free the above.
1151 (x_get_local_selection): Remove unnecessary code.
1152 (x_reply_selection_request): Args changed; handle arbitrary array
1153 of converted selections stored in converted_selections.
1154 Separate the XChangeProperty and SelectionNotify steps.
1155 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1156 (x_convert_selection): New function.
1157 (x_handle_selection_event): Simplify.
1158 (x_get_foreign_selection): Don't ignore incoming requests while
1159 waiting for an answer; this will fail when we implement
1160 SAVE_TARGETS, and seems unnecessary anyway.
1161 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1162 (Vx_sent_selection_functions): Doc fix.
1163
1164 2011-05-26 Leo Liu <sdl.web@gmail.com>
1165
1166 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1167
1168 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1169
1170 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1171
1172 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1173 for fringe update if it has periodic bitmap.
1174 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1175 and fringe_bitmap_periodic_p.
1176
1177 * fringe.c (get_fringe_bitmap_data): New function.
1178 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1179 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1180 row. Mark glyph row for fringe update if periodicity changed.
1181
1182 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1183 for fringe update unless it has periodic bitmap.
1184
1185 2011-05-25 Kenichi Handa <handa@m17n.org>
1186
1187 * xdisp.c (get_next_display_element): Set correct it->face_id for
1188 a static composition.
1189
1190 2011-05-24 Leo Liu <sdl.web@gmail.com>
1191
1192 * deps.mk (fns.o):
1193 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1194
1195 * fns.c (crypto_hash_function, Fsha1): New function.
1196 (Fmd5): Use crypto_hash_function.
1197 (syms_of_fns): Add Ssha1.
1198
1199 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * gnutls.c: Remove unused macros.
1202 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1203 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1204 Remove macros that are defined and never used.
1205 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1206
1207 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1208
1209 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1210 (Fx_get_selection_internal): Minor cleanup.
1211 (Fx_own_selection_internal): Rename arguments for consistency with
1212 select.el.
1213
1214 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1217
1218 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1219
1220 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1221
1222 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1223
1224 * dispnew.c (scrolling_window): Don't exclude the case that the
1225 last enabled row in the desired matrix touches the bottom boundary.
1226
1227 2011-05-21 Glenn Morris <rgm@gnu.org>
1228
1229 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1230 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1231 and add some more files.
1232
1233 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1234
1235 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1236 report_file_error introduced by the change from 2011-05-07.
1237
1238 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1239
1240 * systime.h (Time): Define only if emacs is defined.
1241 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1242 where the include path doesn't have X11/X.h by default. See
1243 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1244
1245 2011-05-20 Kenichi Handa <handa@m17n.org>
1246
1247 * composite.c (find_automatic_composition): Fix previous change.
1248
1249 2011-05-20 Glenn Morris <rgm@gnu.org>
1250
1251 * lisp.mk: New file, split from Makefile.in.
1252 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1253 (shortlisp): Remove.
1254 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1255
1256 2011-05-19 Glenn Morris <rgm@gnu.org>
1257
1258 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1259 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1260 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1261 (lisp): Set the order to that of loadup.el.
1262 (shortlisp): Make it a copy of $lisp.
1263 (SOME_MACHINE_LISP): Remove.
1264 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1265 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1266
1267 2011-05-18 Kenichi Handa <handa@m17n.org>
1268
1269 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1270 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1271 (find_automatic_composition): Mostly rewrite for efficiency.
1272
1273 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1274
1275 * makefile.w32-in: Update dependencies.
1276
1277 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1278
1279 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1280 revision 104625).
1281
1282 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 Fix some integer overflow issues, such as string length overflow.
1285
1286 * insdel.c (count_size_as_multibyte): Check for string overflow.
1287
1288 * character.c (lisp_string_width): Check for string overflow.
1289 Use EMACS_INT, not int, for string indexes and lengths; in
1290 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1291 the resulting string length overflows an EMACS_INT; instead,
1292 report a string overflow if no precision given. When checking for
1293 precision exhaustion, use a check that cannot possibly have
1294 integer overflow. (Bug#8675)
1295 * character.h (lisp_string_width): Adjust to new signature.
1296
1297 * alloc.c (string_overflow): New function.
1298 (Fmake_string): Use it. This doesn't change behavior, but saves
1299 a few bytes and will simplify future changes.
1300 * character.c (string_escape_byte8): Likewise.
1301 * lisp.h (string_overflow): New decl.
1302
1303 Fixups, following up to the user-interface timestamp change.
1304 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1305 for UI timestamps, instead of unsigned long.
1306 * msdos.c (mouse_get_pos): Likewise.
1307 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1308 * w32gui.h (Time): Define by including "systime.h" rather than by
1309 declaring it ourselves. (Bug#8664)
1310
1311 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1312 * image.c (clear_image_cache): Likewise.
1313
1314 * term.c (term_mouse_position): Don't assume time_t wraparound.
1315
1316 Be more systematic about user-interface timestamps.
1317 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1318 and sometimes 'EMACS_UINT', to represent these timestamps.
1319 This change causes it to use 'Time' uniformly, as that's what X uses.
1320 This makes the code easier to follow, and makes it easier to catch
1321 integer overflow bugs such as Bug#8664.
1322 * frame.c (Fmouse_position, Fmouse_pixel_position):
1323 Use Time, not unsigned long, for user-interface timestamps.
1324 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1325 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1326 * keyboard.h (last_event_timestamp): Likewise.
1327 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1328 * menu.h (xmenu_show): Likewise.
1329 * term.c (term_mouse_position): Likewise.
1330 * termhooks.h (struct input_event.timestamp): Likewise.
1331 (struct terminal.mouse_position_hook): Likewise.
1332 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1333 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1334 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1335 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1336 what it was before.
1337 * menu.h, termhooks.h: Include "systime.h", for Time.
1338
1339 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1340 Don't assume that the difference between two unsigned long values
1341 can fit into an integer. At this point, we know button_down_time
1342 <= event->timestamp, so the difference must be nonnegative, so
1343 there's no need to cast the result if double-click-time is
1344 nonnegative, as it should be; check that it's nonnegative, just in
1345 case. This bug is triggered when events are more than 2**31 ms
1346 apart (about 25 days). (Bug#8664)
1347
1348 * xselect.c (last_event_timestamp): Remove duplicate decl.
1349 (x_own_selection): Remove needless cast to unsigned long.
1350
1351 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1352 that always fit in int. Use a sentinel instead of a counter, to
1353 avoid a temp and to allay GCC's concerns about possible int overflow.
1354 * frame.h (struct frame): Use int for menu_bar_items_used
1355 instead of EMACS_INT, since it always fits in int.
1356
1357 * menu.c (grow_menu_items): Check for int overflow.
1358
1359 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1360
1361 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1362 Before, the code was not consistent. These values cannot exceed
1363 2**31 - 1 so there's no need to make them unsigned.
1364 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1365 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1366 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1367 as modifiers.
1368 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1369
1370 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1371 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1372 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1373 presumably because the widths might not match.
1374
1375 * window.c (size_window): Avoid needless test at loop start.
1376
1377 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1378
1379 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1380
1381 2011-05-12 Drew Adams <drew.adams@oracle.com>
1382
1383 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1384
1385 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1386
1387 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1388 `width' to `bar_area_x' and `bar_area_width', respectively.
1389 (x_scroll_run): Take account of fringe background extension.
1390
1391 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1392 Rename local vars `left' and `width' to `bar_area_x' and
1393 `bar_area_width', respectively.
1394 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1395 background extension.
1396
1397 2011-05-10 Jim Meyering <meyering@redhat.com>
1398
1399 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1400
1401 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1402
1403 * image.c (Finit_image_library): Return t for built-in image types,
1404 like pbm and xbm. (Bug#8640)
1405
1406 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1407
1408 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1409
1410 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1411
1412 * w32console.c (Fset_screen_color): Doc fix.
1413 (Fget_screen_color): New function.
1414 (syms_of_ntterm): Defsubr it.
1415
1416 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1417 unlink the temporary file if Fcall_process didn't create it in the
1418 first place.
1419 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1420 child process will be redirected to a file specified with `:file'.
1421 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1422 cue to call_process_cleanup not to close that handle.
1423
1424 2011-05-07 Ben Key <bkey76@gmail.com>
1425
1426 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1427 one of two shell specific rules, either bootstrap-temacs-CMD or
1428 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1429 to the previous implementation of the bootstrap-temacs rule.
1430 The bootstrap-temacs-CMD rule is similar to the previous
1431 implementation of the bootstrap-temacs rule except that it
1432 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1433 variable.
1434
1435 These changes, along with some changes to nt/configure.bat,
1436 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1437 earlier fix to add support for --cflags and --ldflags options
1438 that include quotes so that it works whether make uses cmd or
1439 sh as the shell.
1440
1441 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1442
1443 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1444 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1445 is a constant.
1446 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1447 a string. Handle both cases.
1448 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1449 (Fdbus_register_method): Use Qinvalid_function.
1450
1451 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1452
1453 * makefile.w32-in: Update dependencies.
1454 (LISP_H): Add inttypes.h and stdin.h.
1455 (PROCESS_H): Add unistd.h.
1456
1457 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1458
1459 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1460 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1461
1462 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1463
1464 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1465
1466 * term.c (vfatal): Remove stray call to va_end.
1467 It's not needed and the C Standard doesn't allow it here anyway.
1468
1469 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1470 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1471
1472 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1473 bytes.
1474
1475 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1476
1477 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1478
1479 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1480
1481 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1482
1483 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1484
1485 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1486 * charset.c (Fdefine_charset_internal): Don't initialize
1487 charset.code_space[15]. The value was garbage, on hosts with
1488 32-bit int (Bug#8600).
1489
1490 * lread.c (read_integer): Be more consistent with string-to-number.
1491 Use string_to_number to do the actual conversion; this avoids
1492 rounding errors and fixes some other screwups. Without this fix,
1493 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1494 (digit_to_number): Move earlier, for benefit of read_integer.
1495 Return -1 if the digit is out of range for the base, -2 if it is
1496 not a digit in any supported base. (Bug#8602)
1497
1498 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1499
1500 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1501 to match comment at start of function. This also removes a
1502 GCC warning about overflow in a 32+64-bit port.
1503
1504 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1505
1506 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1507 Reported by Stefan Monnier in
1508 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1509 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1510 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1511
1512 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1513 (EMACS_UINTPTR): Likewise, with uintptr_t.
1514
1515 * lisp.h: Prefer 64-bit EMACS_INT if available.
1516 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1517 on 32-bit hosts that have 64-bit int, so that they can access
1518 large files.
1519 However, temporarily disable this change unless the temporary
1520 symbol WIDE_EMACS_INT is defined.
1521
1522 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1523
1524 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1525 This removes an assumption that EMACS_INT and long are the same
1526 width as pointers. The assumption is true for Emacs porting targets
1527 now, but we want to make other targets possible.
1528 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1529 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1530 In the rest of the code, change types of integers that hold casted
1531 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1532 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1533 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1534 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1535 No need to cast type when ORing.
1536 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1537 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1538 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1539 assume EMACS_INT is the same width as char *.
1540 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1541 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1542 Remove no-longer-needed casts.
1543 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1544 (xg_tool_bar_help_callback, xg_make_tool_item):
1545 Use EMACS_INTPTR to hold an integer
1546 that will be cast to void *; this can avoid a GCC warning
1547 if EMACS_INT is not the same width as void *.
1548 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1549 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1550 (current_message_1, set_message_1):
1551 Use a local to convert to proper width without a cast.
1552 * xmenu.c (dialog_selection_callback): Likewise.
1553
1554 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1555 Also, don't assume VALBITS / RAND_BITS is less than 5,
1556 and don't rely on undefined behavior when shifting a 1 left into
1557 the sign bit.
1558 * lisp.h (get_random): Change signature to match.
1559
1560 * lread.c (hash_string): Use size_t, not int, for hash computation.
1561 Normally we prefer signed values; but hashing is special, because
1562 it's better to use unsigned division on hash table sizes so that
1563 the remainder is nonnegative. Also, size_t is the natural width
1564 for hashing into memory. The previous code used 'int', which doesn't
1565 retain enough info to hash well into very large tables.
1566 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1567
1568 * dbusbind.c: Don't possibly lose pointer info when converting.
1569 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1570 Use XPNTR rather than XHASH, so that the high-order bits of
1571 the pointer aren't lost when converting through void *.
1572
1573 * eval.c (Fautoload): Don't double-shift a pointer.
1574
1575 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1576
1577 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1578
1579 * gnutls.c (DEF_GNUTLS_FN):
1580 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1581
1582 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1583
1584 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1585 marker. (Bug#8610)
1586
1587 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1588
1589 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1590 New version that can reserve upto 2GB of heap space.
1591
1592 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1593
1594 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1595
1596 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1597
1598 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1599 `gnutls_certificate_set_x509_key_file'.
1600
1601 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1602
1603 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1604 Update dependencies.
1605
1606 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1607
1608 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1609 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1610 Remove unused parameter `fildes'.
1611 * process.c (read_process_output, send_process): Don't pass it.
1612
1613 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1614
1615 Fix previous change: the library cache is defined in w32.c.
1616 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1617 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1618
1619 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1620
1621 Implement dynamic loading of GnuTLS on Windows.
1622
1623 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1624 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1625 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1626 Declare.
1627
1628 * gnutls.c (Qgnutls_dll): Define.
1629 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1630 (gnutls_*): Declare function pointers.
1631 (init_gnutls_functions): New function to initialize function pointers.
1632 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1633 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1634 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1635 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1636 (emacs_gnutls_write, emacs_gnutls_read)
1637 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1638 (Fgnutls_available_p): New function.
1639 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1640 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1641 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1642
1643 * image.c: Include w32.h.
1644 (Vimage_type_cache): Delete.
1645 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1646 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1647 (w32_delayed_load): Move to w32.c.
1648
1649 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1650
1651 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1652 (w32_delayed_load): Move from image.c. When loading a library, record
1653 its filename in the :loaded-from property of the library id.
1654 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1655 Initialize and staticpro them.
1656 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1657
1658 * process.c: Include lisp.h before w32.h, not after.
1659 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1660 instead of gnutls_record_check_pending.
1661
1662 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1663
1664 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1665
1666 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1667 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1668 as passed in.
1669
1670 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1671
1672 * xterm.c (x_set_frame_alpha): Do not set property on anything
1673 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1674
1675 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1676
1677 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1678
1679 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1680
1681 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1682 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1683 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1684 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1685 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1686 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1687 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1688 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1689 (Qgnutls_bootprop_callbacks_verify): Make static.
1690
1691 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1692
1693 * callproc.c: Indentation fixup.
1694
1695 * sysdep.c (wait_for_termination_1): Make static.
1696 (wait_for_termination, interruptible_wait_for_termination):
1697 Move after wait_for_termination_1.
1698
1699 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1700
1701 * sysdep.c (interruptible_wait_for_termination): New function
1702 which is like wait_for_termination, but allows keyboard
1703 interruptions.
1704
1705 * callproc.c (Fcall_process): Add (:file "file") as an option for
1706 the STDOUT buffer.
1707 (Fcall_process_region): Ditto.
1708
1709 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1710
1711 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1712 rather than `XVECTOR (FOO)->size'.
1713
1714 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1715 inttypes.h, as a gnulib replacement is used if it not available in
1716 system headers.
1717
1718 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1719
1720 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1721 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1722 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1723
1724 * coding.c (coding_alloc_by_realloc): Error out if destination
1725 will grow beyond MOST_POSITIVE_FIXNUM.
1726 (decode_coding_emacs_mule): Abort if there isn't enough place in
1727 charbuf for the composition carryover bytes. Reserve an extra
1728 space for up to 2 characters produced in a loop.
1729 (decode_coding_iso_2022): Abort if there isn't enough place in
1730 charbuf for the composition carryover bytes.
1731
1732 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1733
1734 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1735 aborting when %lld or %lll format is passed.
1736 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1737 %llo or %llx format is passed. (Bug#8545)
1738
1739 * window.c (window_scroll_line_based): Use a marker instead of
1740 simple variables to record original value of point. (Bug#7952)
1741
1742 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1743 produced by %s or %c overflows available buffer space. (Bug#8545)
1744
1745 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1746
1747 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1748 (SIZE_MAX): Move defn after all includes, as they might #define it.
1749
1750 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1751
1752 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1753
1754 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1755
1756 * keyboard.c (Qdelayed_warnings_hook): Define.
1757 (command_loop_1): Run `delayed-warnings-hook'
1758 if Vdelayed_warnings_list is non-nil.
1759 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1760 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1761
1762 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1763
1764 * doprnt.c (doprnt): Don't return value smaller than the buffer
1765 size if the message was truncated. (Bug#8545).
1766
1767 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1768
1769 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1770 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1771
1772 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1775
1776 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1777
1778 * makefile.w32-in: Update dependencies.
1779
1780 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1781
1782 Improve `doprnt' and its usage. (Bug#8545)
1783 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1784 `format_end'. Remove support for %l as a conversion specifier.
1785 Don't use xrealloc. Improve diagnostics when the %l size modifier
1786 is used. Update the commentary.
1787
1788 * eval.c (verror): Simplify calculation of size_t.
1789
1790 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1791 messages.
1792
1793 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1794
1795 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1796 change.
1797
1798 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1799
1800 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1801 This makes this file independent of the recent pseudovector change.
1802
1803 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1804
1805 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1806
1807 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1808 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1809 Remove unused local.
1810 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1811
1812 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1813 GCC 4.6.0 optimizes based on type-based alias analysis.
1814 For example, if b is of type struct buffer * and v of type struct
1815 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1816 != &v->size, and therefore "v->size = 1; b->size = 2; return
1817 v->size;" must therefore return 1. This assumption is incorrect
1818 for Emacs, since it type-puns struct Lisp_Vector * with many other
1819 types. To fix this problem, this patch adds a new type struct
1820 vectorlike_header that documents the constraints on layout of vectors
1821 and pseudovectors, and helps optimizing compilers not get fooled
1822 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1823 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1824 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1825 the size member.
1826 (XSETPVECTYPE): Rewrite in terms of new macro.
1827 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1828 This is a bit clearer, and further avoids the possibility of
1829 undesirable aliasing.
1830 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1831 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1832 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1833 since Lisp_Subr is a special case (no "next" field).
1834 (ASIZE): Now uses header.size rather than size.
1835 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1836 to avoid the hassle of writing XVECTOR (foo)->header.size.
1837 (struct vectorlike_header): New type.
1838 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1839 object, to help avoid aliasing.
1840 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1841 (SUBRP): Likewise, since Lisp_Subr is a special case.
1842 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1843 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1844 (struct Lisp_Hash_Table): Combine first two members into a single
1845 struct vectorlike_header member. All uses of "size" and "next" members
1846 changed to be "header.size" and "header.next".
1847 * buffer.h (struct buffer): Likewise.
1848 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1849 * frame.h (struct frame): Likewise.
1850 * process.h (struct Lisp_Process): Likewise.
1851 * termhooks.h (struct terminal): Likewise.
1852 * window.c (struct save_window_data, struct saved_window): Likewise.
1853 * window.h (struct window): Likewise.
1854 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1855 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1856 * buffer.c (init_buffer_once): Likewise.
1857 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1858 special case.
1859 * process.c (Fformat_network_address): Use local var for size,
1860 for brevity.
1861
1862 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1863
1864 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1865 * data.c (atof): Remove decl; no longer used or needed.
1866 (digit_to_number): Move to lread.c.
1867 (Fstring_to_number): Use new string_to_number function, to be
1868 consistent with how the Lisp reader treats infinities and NaNs.
1869 Do not assume that floating-point numbers represent EMACS_INT
1870 without losing information; this is not true on most 64-bit hosts.
1871 Avoid double-rounding errors, by insisting on integers when
1872 parsing non-base-10 numbers, as the documentation specifies.
1873 * lisp.h (string_to_number): New decl, replacing ...
1874 (isfloat_string): Remove.
1875 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1876 (read1): Do not accept +. and -. as integers; this
1877 appears to have been a coding error. Similarly, do not accept
1878 strings like +-1e0 as floating point numbers. Do not report
1879 overflow for integer overflows unless the base is not 10 which
1880 means we have no simple and reliable way to continue.
1881 Break out the floating-point parsing into a new
1882 function string_to_number, so that Fstring_to_number parses
1883 floating point numbers consistently with the Lisp reader.
1884 (digit_to_number): Move here from data.c. Make it static inline.
1885 (E_CHAR, EXP_INT): Remove, replacing with ...
1886 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1887 (string_to_number): New function, replacing isfloat_string.
1888 This function checks for valid syntax and produces the resulting
1889 Lisp float number too. Rework it so that string-to-number
1890 no longer mishandles examples like "1.0e+". Use strtoumax,
1891 so that overflow for non-base-10 numbers is reported only when
1892 there's no portable and simple way to convert to floating point.
1893
1894 * textprop.c (set_text_properties_1): Rewrite for clarity,
1895 and to avoid GCC warning about integer overflow.
1896
1897 * intervals.h (struct interval): Use EMACS_INT for members
1898 where EMACS_UINT might cause problems. See
1899 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1900 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1901 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1902 All uses changed.
1903 (offset_intervals): Tell GCC not to worry about length overflow
1904 when negating a negative length.
1905
1906 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1907 (overrun_check_free): Likewise.
1908
1909 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1910 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1911 word size.
1912
1913 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1914 (gnutls_make_error): Rename local to avoid shadowing.
1915 (gnutls_emacs_global_deinit): ifdef out; not used.
1916 (Fgnutls_boot): Use const for pointer to readonly storage.
1917 Comment out unused local. Fix pointer signedness problems.
1918
1919 * lread.c (openp): Don't stuff size_t into an 'int'.
1920 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1921 about possible signed overflow.
1922
1923 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1924 (GDK_KEY_g): Don't define if already defined.
1925 (xg_prepare_tooltip): Avoid pointer signedness problem.
1926 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1927
1928 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1929 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1930
1931 * xfns.c (Fx_window_property): Simplify a bit,
1932 to make a bit faster and to avoid GCC 4.6.0 warning.
1933 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1934
1935 * fns.c (internal_equal): Don't assume size_t fits in int.
1936
1937 * alloc.c (compact_small_strings): Tighten assertion a little.
1938
1939 Replace pEd with more-general pI, and fix some printf arg casts.
1940 * lisp.h (pI): New macro, generalizing old pEd macro to other
1941 conversion specifiers. For example, use "...%"pI"d..." rather
1942 than "...%"pEd"...".
1943 (pEd): Remove. All uses replaced with similar uses of pI.
1944 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1945 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1946 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1947 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1948 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1949 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1950 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1951 64-bit hosts.
1952 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1953 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1954 * print.c (safe_debug_print, print_object): Likewise.
1955 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1956 to int.
1957 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1958 avoiding the 0 flag, which is not portable.
1959 * process.c (Fmake_network_process): Use pI to avoid cast.
1960 * region-cache.c (pp_cache): Likewise.
1961 * xdisp.c (decode_mode_spec): Likewise.
1962 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1963 behavior on 64-bit hosts with printf arg.
1964 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1965 (x_stop_queuing_selection_requests): Likewise.
1966 (x_get_window_property): Don't truncate byte count to an 'int'
1967 when tracing.
1968
1969 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1970 here, since it parses constructs like leading '-' and spaces,
1971 which are not wanted; and it overflows with large numbers.
1972 Instead, simply match F[0-9]+, which is what is wanted anyway.
1973
1974 * alloc.c: Remove unportable assumptions about struct layout.
1975 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1976 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1977 (allocate_vectorlike, make_pure_vector): Use the new macros,
1978 plus offsetof, to remove unportable assumptions about struct layout.
1979 These assumptions hold on all porting targets that I know of, but
1980 they are not guaranteed, they're easy to remove, and removing them
1981 makes further changes easier.
1982
1983 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1984 This doesn't fix a bug but makes the code clearer.
1985 (string_overrun_cookie): Now const. Use initializers that
1986 don't formally overflow signed char, to avoid warnings.
1987 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1988 can cause Emacs to crash when string overrun checking is enabled.
1989 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1990 multiple of sizeof (EMACS_INT); it need not be, if
1991 alignof(EMACS_INT) < sizeof (EMACS_INT).
1992 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1993
1994 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1995
1996 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1997
1998 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1999
2000 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2001 supposed to be handshaking. (Bug#8556)
2002 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2003
2004 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2005
2006 * lisp.h (Qdebug): List symbol.
2007 * eval.c (Qdebug): Restore global linkage.
2008 * keyboard.c (debug-on-event): New variable.
2009 (handle_user_signal): Break into debugger when debug-on-event
2010 matches the current signal symbol.
2011
2012 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2013
2014 * alloc.c (check_sblock, check_string_bytes)
2015 (check_string_free_list): Convert to standard C.
2016
2017 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2018
2019 * w32.c (emacs_gnutls_push): Fix typo.
2020
2021 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2022
2023 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2024 "cast to pointer from integer of different size".
2025
2026 Improve doprnt and its use in verror. (Bug#8545)
2027 * doprnt.c (doprnt): Document the set of format control sequences
2028 supported by the function. Use SAFE_ALLOCA instead of always
2029 using `alloca'.
2030
2031 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2032 is one byte too soon. Don't use xrealloc; instead xfree and
2033 xmalloc anew.
2034
2035 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2036
2037 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2038 callbacks stage.
2039
2040 * gnutls.c: Renamed global_initialized to
2041 gnutls_global_initialized. Added internals for the
2042 :verify-hostname-error, :verify-error, and :verify-flags
2043 parameters of `gnutls-boot' and documented those parameters in the
2044 docstring. Start callback support.
2045 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2046 unless a fatal error occured. Call gnutls_alert_send_appropriate
2047 on error. Return error code.
2048 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2049 (emacs_gnutls_read): Likewise.
2050 (Fgnutls_boot): Return handshake error code.
2051 (emacs_gnutls_handle_error): New function.
2052 (wsaerror_to_errno): Likewise.
2053
2054 * w32.h (emacs_gnutls_pull): Add prototype.
2055 (emacs_gnutls_push): Likewise.
2056
2057 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2058 (emacs_gnutls_push): Likewise.
2059
2060 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2061
2062 * process.c (wait_reading_process_output): Check if GnuTLS
2063 buffered some data internally if no FDs are set for TLS
2064 connections.
2065
2066 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2067 (LIBS): Link to USER_LIBS.
2068 ($(BLD)/gnutls.$(0)): New target.
2069
2070 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2071
2072 * xdisp.c (handle_single_display_spec): Rename the
2073 display_replaced_before_p argument into display_replaced_p, to
2074 make it consistent with the commentary. Fix typos in the
2075 commentary.
2076
2077 * textprop.c (syms_of_textprop): Remove dead code.
2078 (copy_text_properties): Delete obsolete commentary about an
2079 interface that was deleted long ago. Fix typos in the description
2080 of arguments.
2081
2082 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2083 to changes in oldXMenu/XMenu.h from 2011-04-16.
2084 <menu_help_message, prev_menu_help_message>: Constify.
2085 (IT_menu_make_room): menu->help_text is now `const char **';
2086 adjust.
2087
2088 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2089 to changes in oldXMenu/XMenu.h from 2011-04-16.
2090 (struct XMenu): Declare `help_text' `const char **'.
2091
2092 * xfaces.c <Qunspecified>: Make extern again.
2093
2094 * syntax.c: Include sys/types.h before including regex.h, as
2095 required by Posix.
2096
2097 * doc.c (get_doc_string): Improve the format passed to `error'.
2098
2099 * doprnt.c (doprnt): Improve commentary.
2100
2101 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2102
2103 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2104 them with etags.
2105
2106 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2107 changes in globals.h immediately force recompilation.
2108 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2109 $(CURDIR)/s/ms-w32.h.
2110 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2111
2112 * character.c (Fchar_direction): Function deleted.
2113 (syms_of_character): Don't defsubr it.
2114 <char-direction-table>: Deleted.
2115
2116 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2117
2118 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2119 * doprnt.c: Include limits.h.
2120 (SIZE_MAX): New macro.
2121 (doprnt): Return a size_t value. 2nd arg is now size_t.
2122 Many local variables are now size_t instead of int or unsigned.
2123 Improve overflow protection. Support `l' modifier for integer
2124 conversions. Support %l conversion. Don't assume an EMACS_INT
2125 argument for integer conversions and for %c.
2126
2127 * lisp.h (doprnt): Restore prototype.
2128
2129 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2130 $(SRC)/character.h.
2131
2132 * Makefile.in (base_obj): Add back doprnt.o.
2133
2134 * deps.mk (doprnt.o): Add back prerequisites.
2135 (callint.o): Depend on character.h.
2136
2137 * eval.c (internal_lisp_condition_case): Include the handler
2138 representation in the error message.
2139 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2140 when breaking from the loop.
2141
2142 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2143
2144 * callint.c (Fcall_interactively): When displaying error message
2145 about invalid control letter, pass the character's codepoint, not
2146 a pointer to its multibyte form. Improve display of the character
2147 in octal and display also its hex code.
2148
2149 * character.c (char_string): Use %x to display the (unsigned)
2150 codepoint of an invalid character, to avoid displaying a bogus
2151 negative value.
2152
2153 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2154 `error', not SYMBOL_NAME itself.
2155
2156 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2157 character arguments to `error'.
2158
2159 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2160 to `error' in error message about FINAL_CHAR argument. Make sure
2161 FINAL_CHAR is a character, and use %c when it is passed as
2162 argument to `error'.
2163
2164 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2165
2166 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2167
2168 * w32.c: Include <time.h>.
2169 (sys_localtime): New function.
2170
2171 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2172
2173 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2174
2175 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2176
2177 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2178
2179 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2180 zombies (Bug#8467).
2181
2182 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2183
2184 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2185 gl_state.e_property when gl_state.object is Qt.
2186
2187 * insdel.c (make_gap_larger): Remove limitation of buffer size
2188 to <= INT_MAX.
2189
2190 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2191
2192 * xdisp.c (lookup_glyphless_char_display)
2193 (produce_glyphless_glyph): Handle cons cell entry in
2194 glyphless-char-display.
2195 (Vglyphless_char_display): Document it.
2196
2197 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2198 glyphless-char-display.
2199
2200 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2201
2202 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2203
2204 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2205
2206 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2207 definition for no-X builds.
2208
2209 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2210
2211 Static checks with GCC 4.6.0 and non-default toolkits.
2212
2213 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2214
2215 * process.c (keyboard_bit_set): Define only if SIGIO.
2216 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2217 (send_process): Repair possible setjmp clobbering.
2218
2219 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2220
2221 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2222
2223 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2224
2225 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2226 Define only if needed.
2227
2228 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2229 by pacifying GCC about it. Maybe it's time to retire it?
2230 * xfaces.c (USG, __TIMEVAL__): Likewise.
2231
2232 * dispextern.h (struct redisplay_interface): Rename param
2233 to avoid shadowing.
2234 * termhooks.h (struct terminal): Likewise.
2235 * xterm.c (xembed_send_message): Likewise.
2236
2237 * insdel.c (make_gap_smaller): Define only if
2238 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2239
2240 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2241 it.
2242
2243 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2244 so that we aren't warned about unused symbols.
2245
2246 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2247
2248 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2249
2250 * xfns.c (x_real_positions): Mark locals as initialized.
2251
2252 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2253
2254 * xterm.c: Fix problems found by static analysis with other toolkits.
2255 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2256 (x_dispatch_event): Declare static if USE_GTK, and
2257 define if USE_GTK || USE_X_TOOLKIT.
2258 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2259 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2260 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2261 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2262
2263 * xmenu.c (menu_help_callback): Pointer type fixes.
2264 Use const pointers when pointing at readonly data. Avoid pointer
2265 signedness clashes.
2266 (FALSE): Remove unused macro.
2267 (update_frame_menubar): Remove unused decl.
2268
2269 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2270
2271 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2272 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2273 (single_menu_item): Rename local to avoid shadowing.
2274
2275 * keyboard.c (make_lispy_event): Remove unused local var.
2276
2277 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2278 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2279
2280 * bitmaps: Change bitmaps from unsigned char back to the X11
2281 compatible char. Avoid the old compiler warnings about
2282 out-of-range initializers by using, for example, '\xab' rather
2283 than 0xab.
2284
2285 * xgselect.c (xgselect_initialize): Check vs interface
2286 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2287
2288 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2289
2290 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2291 to read-only memory.
2292
2293 * fns.c (vector): Remove; this old hack is no longer needed.
2294
2295 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2296 Remove unused var.
2297 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2298
2299 * xrdb.c (x_load_resources): Omit unused local.
2300
2301 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2302 (x_window): Rename locals to avoid shadowing.
2303 (USG): Use the kludged USG macro, to pacify gcc.
2304
2305 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2306 (x_term_init): Remove local to avoid shadowing.
2307
2308 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2309
2310 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2311 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2312
2313 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2314
2315 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2316
2317 Fix regex.c, syntax.c and friends for buffers > 2GB.
2318 * syntax.h (struct gl_state_s): Declare character position members
2319 EMACS_INT.
2320
2321 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2322
2323 * textprop.c (verify_interval_modification, interval_of):
2324 Declare arguments EMACS_INT.
2325
2326 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2327 EMACS_INT.
2328
2329 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2330
2331 * indent.c (Fvertical_motion): Local variable it_start is now
2332 EMACS_INT.
2333
2334 * regex.c (re_match, re_match_2, re_match_2_internal)
2335 (bcmp_translate, regcomp, regexec, print_double_string)
2336 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2337 (re_compile_pattern, re_exec): Declare arguments and local
2338 variables `size_t' and `ssize_t' and return values `regoff_t', as
2339 appropriate.
2340 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2341 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2342 <compile_stack_type>: `size' and `avail' are now `size_t'.
2343
2344 * regex.h <regoff_t>: Use ssize_t, not int.
2345 (re_search, re_search_2, re_match, re_match_2): Arguments that
2346 specify buffer/string position and length are now ssize_t and
2347 size_t. Return type is regoff_t.
2348
2349 2011-04-16 Ben Key <bkey76@gmail.com>
2350
2351 * nsfont.m: Fixed bugs in ns_get_family and
2352 ns_descriptor_to_entity that were caused by using free to
2353 deallocate memory blocks that were allocated by xmalloc (via
2354 xstrdup). This caused Emacs to crash when compiled with
2355 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2356 --enable-checking=xmallocoverrun). xfree is now used to
2357 deallocate these memory blocks.
2358
2359 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2360
2361 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2362
2363 emacs_write: Accept and return EMACS_INT for sizes.
2364 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2365 et seq.
2366 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2367 Accept and return EMACS_INT.
2368 (emacs_gnutls_write): Return the number of bytes written on
2369 partial writes.
2370 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2371 (emacs_read, emacs_write): Remove check for negative size, as the
2372 Emacs source code has been audited now.
2373 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2374 (emacs_read, emacs_write): Use it.
2375 * process.c (send_process): Adjust to the new signatures of
2376 emacs_write and emacs_gnutls_write. Do not attempt to store
2377 a byte offset into an 'int'; it might overflow.
2378 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2379
2380 * sound.c: Don't assume sizes fit in 'int'.
2381 (struct sound_device.period_size, alsa_period_size):
2382 Return EMACS_INT, not int.
2383 (struct sound_device.write, vox_write, alsa_write):
2384 Accept EMACS_INT, not int.
2385 (wav_play, au_play): Use EMACS_INT to store sizes and to
2386 record read return values.
2387
2388 2011-04-15 Ben Key <bkey76@gmail.com>
2389
2390 * keyboard.c (Qundefined): Don't declare static since it is used
2391 in nsfns.m.
2392 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2393 static since they are used in nsfont.m.
2394
2395 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2396
2397 * process.c (Qprocessp): Don't declare static.
2398 * lisp.h (Qprocessp): Declare again.
2399
2400 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2401
2402 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2403
2404 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2405
2406 Improve C-level modularity by making more things 'static'.
2407
2408 Don't publish debugger-only interfaces to other modules.
2409 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2410 (verify_bytepos, count_markers): Move decls to the only modules
2411 that need them.
2412 * region-cache.h (pp_cache): Likewise.
2413 * window.h (check_all_windows): Likewise.
2414 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2415
2416 * sysdep.c (croak): Now static, if
2417 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2418 * syssignal.h (croak): Declare only if not static.
2419
2420 * alloc.c (refill_memory_reserve): Now static if
2421 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2422 * lisp.h (refill_memory_reserve): Declare only if not static.
2423
2424 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2425 Define only if USE_LUCID.
2426
2427 * xrdb.c (x_customization_string, x_rm_string): Now static.
2428
2429 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2430 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2431
2432 * xdisp.c (draw_row_with_mouse_face): Now static.
2433 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2434
2435 * window.h (check_all_windows): Mark externally visible.
2436
2437 * window.c (window_deletion_count): Now static.
2438
2439 * undo.c: Make symbols static if they're not exported.
2440 (last_undo_buffer, last_boundary_position, pending_boundary):
2441 Now static.
2442
2443 * textprop.c (interval_insert_behind_hooks): Now static.
2444 (interval_insert_in_front_hooks): Likewise.
2445
2446 * term.c: Make symbols static if they're not exported.
2447 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2448 (max_frame_lines, tty_set_terminal_modes):
2449 (tty_reset_terminal_modes, tty_turn_off_highlight):
2450 (get_tty_terminal): Now static.
2451 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2452 * termhooks.h (term_mouse_moveto): Do not declare if
2453 HAVE_WINDOW_SYSTEM.
2454 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2455 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2456
2457 * sysdep.c: Make symbols static if they're not exported.
2458 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2459 Now static.
2460 (sigprocmask_set, full_mask): Remove; unused.
2461 (wait_debugging): Mark as visible.
2462 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2463 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2464
2465 * syntax.c (syntax_temp): Define only if !__GNUC__.
2466
2467 * sound.c (current_sound_device, current_sound): Now static.
2468
2469 * search.c (searchbufs, searchbuf_head): Now static.
2470
2471 * scroll.c (scroll_cost): Remove; unused.
2472 * dispextern.h (scroll_cost): Remove decl.
2473
2474 * region-cache.h (pp_cache): Mark as externally visible.
2475
2476 * process.c: Make symbols static if they're not exported.
2477 (process_tick, update_tick, create_process, chan_process):
2478 (Vprocess_alist, proc_buffered_char, datagram_access):
2479 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2480 (deactivate_process): Mark defn as static, as well as decl.
2481 * lisp.h (create_process): Remove decl.
2482 * process.h (chan_process, Vprocess_alist): Remove decls.
2483
2484 * print.c: Make symbols static if they're not exported.
2485 (print_depth, new_backquote_output, being_printed, print_buffer):
2486 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2487 (print_interval, print_number_index, initial_stderr_stream):
2488 Now static.
2489 * lisp.h (Fprinc): Remove decl.
2490 (debug_output_compilation_hack): Mark as externally visible.
2491
2492 * sysdep.c (croak): Move decl from here to syssignal.h.
2493 * syssignal.h (croak): Put it here, so the API can be checked when
2494 'croak' is called from dissociate_if_controlling_tty.
2495
2496 * minibuf.c: Make symbols static if they're not exported.
2497 (minibuf_save_list, choose_minibuf_frame): Now static.
2498 * lisp.h (choose_minibuf_frame): Remove decl.
2499
2500 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2501
2502 * lread.c: Make symbols static if they're not exported.
2503 (read_objects, initial_obarray, oblookup_last_bucket_number):
2504 Now static.
2505 (make_symbol): Remove; unused.
2506 * lisp.h (initial_obarray, make_symbol): Remove decls.
2507
2508 * keyboard.c: Make symbols static if they're not exported.
2509 (single_kboard, recent_keys_index, total_keys, recent_keys):
2510 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2511 (this_single_command_key_start, echoing, last_auto_save):
2512 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2513 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2514 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2515 (Vlispy_mouse_stem, double_click_count):
2516 Now static.
2517 (force_auto_save_soon): Define only if SIGDANGER.
2518 (ignore_mouse_drag_p): Now static if
2519 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2520 (print_help): Remove; unused.
2521 (stop_character, last_timer_event): Mark as externally visible.
2522 * keyboard.h (ignore_mouse_drag_p): Declare only if
2523 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2524 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2525 * lisp.h (echoing): Remove decl.
2526 (force_auto_save_soon): Declare only if SIGDANGER.
2527 * xdisp.c (redisplay_window): Simplify code, to make it more
2528 obvious that ignore_mouse_drag_p is not accessed if !defined
2529 USE_GTK && !defined HAVE_NS.
2530
2531 * intervals.c: Make symbols static if they're not exported.
2532 (merge_properties_sticky, merge_interval_right, delete_interval):
2533 Now static.
2534 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2535
2536 * insdel.c: Make symbols static if they're not exported.
2537 However, leave prepare_to_modify_buffer alone. It's never
2538 called from outside this function, but that appears to be a bug.
2539 (combine_after_change_list, combine_after_change_buffer):
2540 (adjust_after_replace, signal_before_change): Now static.
2541 (adjust_after_replace_noundo): Remove; unused.
2542 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2543 (signal_before_change): Remove decls.
2544
2545 * indent.c (val_compute_motion, val_vmotion): Now static.
2546
2547 * image.c: Make symbols static if they're not exported.
2548 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2549 if USE_GTK.
2550 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2551 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2552
2553 * fringe.c (standard_bitmaps): Now static.
2554 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2555
2556 * frame.c: Make symbols static if they're not exported.
2557 (x_report_frame_params, make_terminal_frame): Now static.
2558 (get_frame_param): Now static, unless HAVE_NS.
2559 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2560 (x_get_resource_string): Remove; not used.
2561 * frame.h (make_terminal_frame, x_report_frame_params):
2562 (x_get_resource_string); Remove decls.
2563 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2564 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2565
2566 * font.c, fontset.c: Make symbols static if they're not exported.
2567 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2568 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2569 * font.c (font_close_object): Now static.
2570 * font.h (font_close_object): Remove.
2571 * fontset.c (FONTSET_OBJLIST): Remove.
2572 (free_realized_fontset) #if-0 the body, which does nothing.
2573 (face_suitable_for_char_p): #if-0, as it's never called.
2574 * fontset.h (face_suitable_for_char_p): Remove decl.
2575 * xfaces.c (face_at_string_position):
2576 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2577 since 0 is always ASCII.
2578
2579 * fns.c (weak_hash_tables): Now static.
2580
2581 * fileio.c: Make symbols static if they're not exported.
2582 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2583 (Vwrite_region_annotation_buffers): Now static.
2584
2585 * eval.c: Make symbols static if they're not exported.
2586 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2587 * lisp.h (backtrace_list): Remove decl.
2588
2589 * emacs.c: Make symbols static if they're not exported.
2590 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2591 (fatal_error_code, fatal_error_signal_hook, standard_args):
2592 Now static.
2593 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2594 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2595 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2596 * lisp.h (fatal_error_signal_hook): Remove decl.
2597 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2598
2599 * editfns.c: Move a (normally-unused) function to its only use.
2600 * editfns.c, lisp.h (get_operating_system_release): Remove.
2601 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2602 worth the hassle of breaking this out.
2603
2604 * xterm.c: Make symbols static if they're not exported.
2605 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2606 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2607 (x_destroy_window, x_delete_display):
2608 Now static.
2609 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2610 (x_mouse_leave): Remove; unused.
2611 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2612 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2613 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2614 Remove decls.
2615 (x_mouse_leave): Declare only if WINDOWSNT.
2616 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2617 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2618 USE_X_TOOLKIT.
2619
2620 * ftxfont.c: Make symbols static if they're not exported.
2621 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2622 HAVE_FREETYPE.
2623 * font.h (ftxfont_driver): Likewise.
2624
2625 * xfns.c: Make symbols static if they're not exported.
2626 (x_last_font_name, x_display_info_for_name):
2627 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2628 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2629 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2630 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2631 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2632 (last_show_tip_args): Now static.
2633 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2634 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2635 (x_screen_planes): Remove; unused.
2636 * dispextern.h (x_screen_planes): Remove decl.
2637
2638 * dispnew.c: Make symbols static if they're not exported.
2639 * dispextern.h (redraw_garbaged_frames, scrolling):
2640 (increment_row_positions): Remove.
2641 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2642 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2643 Now static.
2644 (redraw_garbaged_frames): Remove; unused.
2645
2646 * xfaces.c: Make symbols static if they're not exported.
2647 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2648 Remove decls.
2649 * xterm.h (defined_color): Remove decls.
2650 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2651 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2652 (menu_face_changed_default, defined_color, free_realized_face):
2653 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2654 (ascii_face_of_lisp_face): Remove; unused.
2655
2656 * xdisp.c: Make symbols static if they're not exported.
2657 * dispextern.h (scratch_glyph_row, window_box_edges):
2658 (glyph_to_pixel_coords, set_cursor_from_row):
2659 (get_next_display_element, set_iterator_to_next):
2660 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2661 (show_mouse_face): Remove decls
2662 * frame.h (message_buf_print): Likewise.
2663 * lisp.h (pop_message, set_message, check_point_in_composition):
2664 Likewise.
2665 * xterm.h (set_vertical_scroll_bar): Likewise.
2666 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2667 (message_buf_print, scratch_glyph_row, displayed_buffer):
2668 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2669 (get_next_display_element, show_mouse_face, window_box_edges):
2670 (frame_to_window_pixel_xy, check_point_in_composition):
2671 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2672 (glyph_to_pixel_coords): Remove; unused.
2673
2674 * dired.c (file_name_completion): Now static.
2675
2676 * dbusbind.c (xd_in_read_queued_messages): Now static.
2677
2678 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2679 * data.c (circular_list_error): Remove.
2680
2681 * commands.h (last_point_position, last_point_position_buffer):
2682 (last_point_position_window): Remove decls.
2683 * keyboard.c: Make these variables static.
2684
2685 * coding.h (coding, code_convert_region, encode_coding_gap):
2686 Remove decls.
2687 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2688 (iso_code_class, detect_coding, code_convert_region): Now static.
2689 (encode_coding_gap): Remove; unused.
2690
2691 * chartab.c (chartab_chars, chartab_bits): Now static.
2692
2693 * charset.h (charset_iso_8859_1): Remove decl.
2694 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2695 Now static.
2696
2697 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2698 * ccl.c (Vccl_program_table): Now static.
2699 (check_ccl_update): Remove; unused.
2700
2701 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2702 * category.h: ... from here.
2703 * category.c (check_category_table, set_category_set): Now static.
2704
2705 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2706 * lisp.h: Remove these decls.
2707
2708 * buffer.c (buffer_count): Remove unused var.
2709
2710 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2711 so that it's not optimized away.
2712 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2713 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2714 exported only to the debugger.
2715
2716 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2717 * atimer.h (run_all_atimers): Remove; not exported.
2718
2719 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2720 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2721 was inaccessible from Lisp.
2722 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2723 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2724
2725 alloc.c: Import and export fewer symbols, and remove unused items.
2726 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2727 is defined.
2728 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2729 it's not optimized away by whole-program optimization.
2730 (message_enable_multibyte, free_misc): Remove.
2731 (catchlist, handlerlist, mark_backtrace):
2732 Declare only if BYTE_MARK_STACK.
2733 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2734 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2735 (message_enable_multibyte): Remove decl.
2736 (free_misc, interval_free_list, float_block, float_block_index):
2737 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2738 (cons_free_list, last_marked_index):
2739 Now static.
2740 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2741 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2742 (mark_backtrace): Define only if BYTE_MARK_STACK.
2743 * xdisp.c (message_enable_multibyte): Now static.
2744
2745 Declare Lisp_Object Q* variables to be 'static' if not exported.
2746 This makes it easier for human readers (and static analyzers)
2747 to see whether these variables are used from other modules.
2748 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2749 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2750 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2751 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2752 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2753 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2754 * xmenu.c, xselect.c:
2755 Declare Q* vars static if they are not used in other modules.
2756 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2757 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2758 Remove decls of unexported vars.
2759 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2760
2761 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2762
2763 Make Emacs functions such as Fatom 'static' by default.
2764 This makes it easier for human readers (and static analyzers)
2765 to see whether these functions can be called from other modules.
2766 DEFUN now defines a static function. To make the function external
2767 so that it can be used in other C modules, use the new macro DEFUE.
2768 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2769 (Finit_image_library):
2770 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2771 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2772 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2773 Remove decls, since these functions are now static.
2774 (Funintern, Fget_internal_run_time): New decls, since these functions
2775 were already external.
2776
2777 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2778 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2779 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2780 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2781 * keyboard.c, keymap.c, lread.c:
2782 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2783 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2784 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2785 Mark functions with DEFUE instead of DEFUN,
2786 if they are used in other modules.
2787 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2788 decls for now-static functions.
2789 * buffer.h (Fdelete_overlay): Remove decl.
2790 * callproc.c (Fgetenv_internal): Mark as internal.
2791 * composite.c (Fremove_list_of_text_properties): Remove decl.
2792 (Fcomposition_get_gstring): New forward static decl.
2793 * composite.h (Fcomposite_get_gstring): Remove decl.
2794 * dired.c (Ffile_attributes): New forward static decl.
2795 * doc.c (Fdocumntation_property): New forward static decl.
2796 * eval.c (Ffetch_bytecode): New forward static decl.
2797 (Funintern): Remove extern decl; now in .h file where it belongs.
2798 * fileio.c (Fmake_symbolic_link): New forward static decl.
2799 * image.c (Finit_image_library): New forward static decl.
2800 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2801 * intervals.h (Fprevious_property_change):
2802 (Fremove_list_of_text_properties): Remove decls.
2803 * keyboard.c (Fthis_command_keys): Remove decl.
2804 (Fcommand_execute): New forward static decl.
2805 * keymap.c (Flookup_key): New forward static decl.
2806 (Fcopy_keymap): Now static.
2807 * keymap.h (Flookup_key): Remove decl.
2808 * process.c (Fget_process): New forward static decl.
2809 (Fprocess_datagram_address): Mark as internal.
2810 * syntax.c (Fsyntax_table_p): New forward static decl.
2811 (skip_chars): Remove duplicate decl.
2812 * textprop.c (Fprevious_property_change): New forward static decl.
2813 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2814 Now internal.
2815 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2816 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2817
2818 * editfns.c (Fformat): Remove unreachable code.
2819
2820 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2821
2822 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2823 change. (Bug#8496)
2824
2825 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2826
2827 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2828 when at ZV. (Bug#8487)
2829
2830 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2831
2832 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2833 (Bug#8437)
2834 * keyboard.c (parse_tool_bar_item): Likewise.
2835 * sound.c (sound_cleanup, alsa_close): Likewise.
2836 * termcap.c (tgetent): Likewise.
2837 * xfns.c (x_default_font_parameter): Likewise.
2838 * xsettings.c (read_and_apply_settings): Likewise.
2839
2840 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2841 (overrun_check_free): Protoize.
2842
2843 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2844
2845 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2846 since callers should never pass a negative size.
2847 Change the signature to match that of plain 'read' and 'write'; see
2848 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2849 * lisp.h: Update prototypes of emacs_write and emacs_read.
2850
2851 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2852
2853 * xdisp.c (redisplay_window): Don't try to determine the character
2854 position of the scroll margin if the window start point w->startp
2855 is outside the buffer's accessible region. (Bug#8468)
2856
2857 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2858
2859 Fix write-region and its subroutines for buffers > 2GB.
2860 * fileio.c (a_write, e_write): Modify declaration of arguments and
2861 local variables to support buffers larger than 2GB.
2862 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2863
2864 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2865 argument, local variables, and return value.
2866
2867 * lisp.h: Update prototypes of emacs_write and emacs_read.
2868
2869 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2870
2871 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2874
2875 Fix more problems found by GCC 4.6.0's static checks.
2876
2877 * xdisp.c (vmessage): Use a better test for character truncation.
2878
2879 * charset.c (load_charset_map): <, not <=, for optimization,
2880 and to avoid potential problems with integer overflow.
2881 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2882 * casetab.c (set_identity, shuffle): Likewise.
2883 * editfns.c (Fformat): Likewise.
2884 * syntax.c (skip_chars): Likewise.
2885
2886 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2887 This also lets GCC 4.6.0 generate slightly better loop code.
2888
2889 * callint.c (Fcall_interactively): <, not <=, for optimization.
2890 (Fcall_interactively): Count the number of arguments produced,
2891 not the number of arguments given. This is simpler and lets GCC
2892 4.6.0 generate slightly better code.
2893
2894 * ftfont.c: Distingish more carefully between FcChar8 and char.
2895 The previous code passed unsigned char * to a functions like
2896 strlen and xstrcasecmp that expect char *, which does not
2897 conform to the C standard.
2898 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2899 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2900 char * when the C standard requires it.
2901
2902 * keyboard.c (read_char): Remove unused var.
2903
2904 * eval.c: Port to Windows vsnprintf (Bug#8435).
2905 Include <limits.h>.
2906 (SIZE_MAX): Define if the headers do not.
2907 (verror): Do not give up if vsnprintf returns a negative count.
2908 Instead, grow the buffer. This ports to Windows vsnprintf, which
2909 does not conform to C99. Problem reported by Eli Zaretskii.
2910 Also, simplify the allocation scheme, by avoiding the need for
2911 calling realloc, and removing the ALLOCATED variable.
2912
2913 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2914
2915 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2916 But keep the doprint source code for now, as we might revamp it
2917 and use it again (Bug#8435).
2918 * lisp.h (doprnt): Remove.
2919 * Makefile.in (base_obj): Remove doprnt.o.
2920 * deps.mk (doprnt.o): Remove.
2921
2922 error: Print 32- and 64-bit integers portably (Bug#8435).
2923 Without this change, on typical 64-bit hosts error ("...%d...", N)
2924 was used to print both 32- and 64-bit integers N, which relied on
2925 undefined behavior.
2926 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2927 New macro.
2928 * lisp.h (error, verror): Mark as printf-like functions.
2929 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2930 Report overflow in size calculations when allocating printf buffer.
2931 Do not truncate output string at its first null byte.
2932 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2933 Truncate the output at a character boundary, since vsnprintf does not
2934 do that.
2935 * charset.c (check_iso_charset_parameter): Convert internal
2936 character to string before calling 'error', since %c now has the
2937 printf meaning.
2938 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2939 overflow when computing char to be passed to 'error'. Do not
2940 pass Lisp_Object to 'error'; pass the integer instead.
2941 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2942 formatted with plain %d.
2943
2944 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2945
2946 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2947
2948 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2949
2950 * xterm.c (x_catch_errors): Remove duplicate declaration.
2951
2952 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2953
2954 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2955
2956 2011-04-10 Jim Meyering <meyering@redhat.com>
2957
2958 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2959 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2960 return ssize_t not "int", and use size_t as the buffer length.
2961 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2962 * gnutls.h: Update declarations.
2963 * process.c (read_process_output): Use ssize_t, to match.
2964 (send_process): Likewise.
2965
2966 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2967
2968 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2969
2970 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2971
2972 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2973 Use unsigned char, to match FcChar8 type definition.
2974
2975 * xterm.c (handle_one_xevent):
2976 * xmenu.c (create_and_show_popup_menu):
2977 * xselect.c (x_decline_selection_request)
2978 (x_reply_selection_request): Avoid type-punned deref of X events.
2979
2980 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2981
2982 Fix some uses of `int' instead of EMACS_INT.
2983 * search.c (string_match_1, fast_string_match)
2984 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2985 (scan_buffer, find_next_newline_no_quit)
2986 (find_before_next_newline, search_command, Freplace_match)
2987 (Fmatch_data): Make some `int' variables be EMACS_INT.
2988
2989 * xdisp.c (display_count_lines): 3rd argument and return value now
2990 EMACS_INT. All callers changed.
2991 (pint2hrstr): Last argument is now EMACS_INT.
2992
2993 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2994 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2995 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2996 (decode_coding_utf_16, decode_coding_emacs_mule)
2997 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2998 (decode_coding_ccl, decode_coding_charset)
2999 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3000 (decode_coding_iso_2022, decode_coding_emacs_mule)
3001 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3002 <char_offset, last_offset>: Declare EMACS_INT.
3003 (encode_coding_utf_8, encode_coding_utf_16)
3004 (encode_coding_emacs_mule, encode_invocation_designation)
3005 (encode_designation_at_bol, encode_coding_iso_2022)
3006 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3007 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3008 Declare EMACS_INT.
3009 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3010 (encode_invocation_designation): Last argument P_NCHARS is now
3011 EMACS_INT.
3012 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3013 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3014
3015 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3016 All users changed.
3017
3018 * ccl.c (Fccl_execute_on_string): Declare some variables
3019 EMACS_INT.
3020
3021 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3022
3023 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3024
3025 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3026
3027 * process.c (Fformat_network_address): Doc fix.
3028
3029 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3030
3031 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3032
3033 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3034
3035 * keyboard.c (read_char): Call Lisp function help-form-show,
3036 instead of using internal_with_output_to_temp_buffer.
3037 (Qhelp_form_show): New var.
3038 (syms_of_keyboard): Use DEFSYM macro.
3039
3040 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3041
3042 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3043
3044 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3045
3046 * process.c (Flist_processes): Remove to Lisp.
3047 (list_processes_1): Delete.
3048
3049 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3050
3051 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3052
3053 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3054
3055 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3056
3057 Fix more problems found by GCC 4.6.0's static checks.
3058
3059 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3060
3061 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3062
3063 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3064
3065 * xdisp.c (vmessage): Mark as a printf-like function.
3066
3067 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3068
3069 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3070
3071 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3072 printf-like functions.
3073 (tiff_load): Add casts to remove these marks before passing them
3074 to system-supplied API.
3075
3076 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3077
3078 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3079 This avoids several warnings with gcc -Wstrict-overflow.
3080 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3081 directly, rather than having caller test rule sign. This avoids
3082 some unnecessary tests.
3083 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3084 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3085 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3086
3087 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3088 (xfont_open): Avoid unnecessary tests.
3089
3090 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3091
3092 * composite.h, composite.c (composition_gstring_put_cache):
3093 Use EMACS_INT, not int, for length.
3094
3095 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3096 breaking out part of COMPOSITION_DECODE_RULE.
3097 (COMPOSITION_DECODE_RULE): Use it.
3098 * composite.c (get_composition_id): Remove unused local vars,
3099 by using the new macro.
3100
3101 * textprop.c (set_text_properties_1): Change while to do-while,
3102 since the condition is always true at first.
3103
3104 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3105 (interval_deletion_adjustment): Return unsigned value.
3106 All uses changed.
3107
3108 * process.c (list_processes_1, create_pty, read_process_output):
3109 (exec_sentinel): Remove vars that were set but not used.
3110 (create_pty): Remove unnecessary "volatile"s.
3111 (Fnetwork_interface_info): Avoid possibility of int overflow.
3112 (read_process_output): Do adaptive read buffering even if carryover.
3113 (read_process_output): Simplify nbytes computation if buffered.
3114
3115 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3116
3117 * syntax.c (scan_words): Remove var that was set but not used.
3118 (update_syntax_table): Use unsigned instead of int.
3119
3120 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3121 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3122 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3123
3124 * print.c (print_error_message): Avoid int overflow.
3125
3126 * font.c (font_list_entities): Redo for clarity,
3127 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3128
3129 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3130 (font_score): Avoid potential overflow in diff calculation.
3131
3132 * fns.c (substring_both): Remove var that is set but not used.
3133 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3134
3135 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3136
3137 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3138 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3139 can always succeed if overflow has undefined behavior.
3140
3141 * search.c (boyer_moore, wordify): Remove vars set but not used.
3142 (wordify): Omit three unnecessary tests.
3143
3144 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3145 All callers changed. This avoids the need for an unused var.
3146
3147 * casefiddle.c (casify_region): Remove var that is set but not used.
3148
3149 * dired.c (file_name_completion): Remove var that is set but not used.
3150
3151 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3152
3153 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3154 (Finsert_file_contents): Remove unnecessary code checking fd.
3155
3156 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3157 Check for integer overflow on size calculations.
3158
3159 * buffer.c (Fprevious_overlay_change): Remove var that is set
3160 but not used.
3161
3162 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3163 Remove vars that are set but not used.
3164 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3165 (timer_check_2): Mark vars as initialized.
3166
3167 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3168
3169 * image.c (lookup_image): Remove var that is set but not used.
3170 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3171
3172 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3173 that are set but not used.
3174
3175 * xfns.c (make_invisible_cursor): Don't return garbage
3176 if XCreateBitmapFromData fails (Bug#8410).
3177
3178 * xselect.c (x_get_local_selection, x_handle_property_notify):
3179 Remove vars that are set but not used.
3180
3181 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3182 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3183
3184 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3185 Remove var that is set but not used.
3186 (scroll_bar_windows_size): Now size_t, not int.
3187 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3188 Check for overflow.
3189
3190 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3191 (map_tty_color) [!defined MSDOS]: Likewise.
3192
3193 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3194
3195 * coding.c: Remove vars that are set but not used.
3196 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3197 All callers changed.
3198 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3199 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3200 (decode_coding_charset): Remove vars that are set but not used.
3201
3202 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3203 that is set but not used.
3204
3205 * print.c (print_object): Remove var that is set but not used.
3206
3207 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3208 The gnulib version avoids calling malloc in the usual case,
3209 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3210 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3211 * filelock.c (current_lock_owner): Likewise.
3212 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3213 * sysdep.c: Include allocator.h, careadlinkat.h.
3214 (emacs_no_realloc_allocator): New static constant.
3215 (emacs_readlink): New function.
3216 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3217 ../lib/careadlinkat.h.
3218
3219 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3220
3221 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3222 first non-nil return value).
3223
3224 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3225
3226 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3227 if not defined (Bug#8403).
3228
3229 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3230
3231 * xdisp.c (display_count_lines): Remove parameter `start',
3232 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3233 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3234 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3235 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3236 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3237 and thereabouts. All callers changed.
3238 (get_per_char_metric): Remove parameter `f', unused since
3239 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3240
3241 2011-04-02 Jim Meyering <meyering@redhat.com>
3242
3243 do not dereference NULL upon failed strdup
3244 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3245 (ns_get_family): Likewise.
3246
3247 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3248
3249 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3250
3251 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3252
3253 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3254 later (Bug#8403).
3255
3256 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3257
3258 Add lexical binding.
3259
3260 * window.c (Ftemp_output_buffer_show): New fun.
3261 (Fsave_window_excursion):
3262 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3263
3264 * lread.c (lisp_file_lexically_bound_p): New function.
3265 (Fload): Bind Qlexical_binding.
3266 (readevalloop): Remove `evalfun' arg.
3267 Bind Qinternal_interpreter_environment.
3268 (Feval_buffer): Bind Qlexical_binding.
3269 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3270 Mark as dynamic.
3271 (syms_of_lread): Declare `lexical-binding'.
3272
3273 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3274
3275 * keyboard.c (eval_dyn): New fun.
3276 (menu_item_eval_property): Use it.
3277
3278 * image.c (parse_image_spec): Use Ffunctionp.
3279
3280 * fns.c (concat, mapcar1): Accept byte-code-functions.
3281
3282 * eval.c (Fsetq): Handle lexical vars.
3283 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3284 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3285 (FletX, Flet): Obey lexical binding.
3286 (Fcommandp): Handle closures.
3287 (Feval): New `lexical' arg.
3288 (eval_sub): New function extracted from Feval. Use it almost
3289 everywhere where Feval was used. Look up vars in lexical env.
3290 Handle closures.
3291 (Ffunctionp): Move from subr.el.
3292 (Ffuncall): Handle closures.
3293 (apply_lambda): Remove `eval_flags'.
3294 (funcall_lambda): Handle closures and new byte-code-functions.
3295 (Fspecial_variable_p): New function.
3296 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3297 but without exporting it to Lisp.
3298
3299 * doc.c (Fdocumentation, store_function_docstring):
3300 * data.c (Finteractive_form): Handle closures.
3301
3302 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3303 interactive spec.
3304
3305 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3306 New byte-codes.
3307 (exec_byte_code): New function extracted from Fbyte_code to handle new
3308 calling convention for byte-code-functions. Add new byte-codes.
3309
3310 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3311
3312 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3313
3314 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3315
3316 * xdisp.c (redisplay_internal): Fix prototype.
3317
3318 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3319
3320 * xdisp.c (SCROLL_LIMIT): New macro.
3321 (try_scrolling): Use it when setting scroll_limit.
3322 Limit scrolling to 100 screen lines.
3323 (redisplay_window): Even when falling back on "recentering",
3324 position point in the window according to scroll-conservatively,
3325 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3326
3327 (try_scrolling): When point is above the window, allow searching
3328 as far as scroll_max, or one screenful, to compute vertical
3329 distance from PT to the scroll margin position. This prevents
3330 try_scrolling from unnecessarily failing when
3331 scroll-conservatively is set to a value slightly larger than the
3332 window height. Clean up the case of PT below the margin at bottom
3333 of window: scroll_max can no longer be INT_MAX. When aggressive
3334 scrolling is in use, don't let point enter the opposite scroll
3335 margin as result of the scroll.
3336 (syms_of_xdisp) <scroll-conservatively>: Document the
3337 threshold of 100 lines for never-recentering scrolling.
3338
3339 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3340
3341 * dispextern.h (move_it_by_lines):
3342 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3343 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3344 (message_log_check_duplicate): Remove parameters `prev_bol' and
3345 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3346 (redisplay_internal): Remove parameter `preserve_echo_area',
3347 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3348
3349 * indent.c (Fvertical_motion):
3350 * window.c (window_scroll_pixel_based, Frecenter):
3351 Don't pass `need_y_p' to `move_it_by_lines'.
3352
3353 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3354
3355 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3356 steal a few bits to be more compact.
3357 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3358 Remove unneeded casts.
3359
3360 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3361
3362 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3363
3364 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3365 binding" message (bug#7967).
3366
3367 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3368
3369 Fix more problems found by GCC 4.6.0's static checks.
3370
3371 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3372 Remove unused local var.
3373
3374 * editfns.c (Fmessage_box): Remove unused local var.
3375
3376 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3377 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3378 Omit unused local vars.
3379 * window.c (shrink_windows): Omit unused local var.
3380 * menu.c (digest_single_submenu): Omit unused local var.
3381 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3382 Omit unused local var.
3383
3384 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3385 Don't assume string length fits in int.
3386 (keyremap_step, read_key_sequence): Use size_t for sizes.
3387 (read_key_sequence): Don't check last_real_key_start redundantly.
3388
3389 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3390 instead of alloca (Bug#8344).
3391
3392 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3393 (Fbacktrace_frame): Don't assume nframes fits in int.
3394
3395 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3396
3397 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3398 concerns.
3399
3400 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3401
3402 * cm.c (calccost): Turn while-do into do-while, for clarity.
3403
3404 * keyboard.c (syms_of_keyboard): Use the same style as later
3405 in this function when indexing through an array. This also
3406 works around GCC bug 48267.
3407
3408 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3409
3410 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3411
3412 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3413 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3414
3415 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3416 This avoids undefined behavior on integer overflow, and is a bit
3417 more convenient anyway since it is compared to a size_t variable.
3418
3419 Variadic C functions now count arguments with size_t, not int.
3420 This avoids an unnecessary limitation on 64-bit machines, which
3421 caused (substring ...) to crash on large vectors (Bug#8344).
3422 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3423 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3424 All variadic functions and their callers changed accordingly.
3425 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3426 * data.c (arith_driver, float_arith_driver): Likewise.
3427 * editfns.c (general_insert_function): Likewise.
3428 * eval.c (struct backtrace.nargs, interactive_p)
3429 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3430 (funcall_lambda, mark_backtrace): Likewise.
3431 * fns.c (concat): Likewise.
3432 * frame.c (x_set_frame_parameters): Likewise.
3433 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3434 0 if not found, not -1. All callers changed.
3435
3436 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3437 (stack_copy_size): Now size_t, not int.
3438 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3439
3440 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3441
3442 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3443 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3444 All callers changed.
3445
3446 * lisp.h (multibyte_char_to_unibyte):
3447 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3448 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3449 * character.h (CHAR_TO_BYTE8):
3450 * cmds.c (internal_self_insert):
3451 * editfns.c (general_insert_function):
3452 * keymap.c (push_key_description):
3453 * search.c (Freplace_match):
3454 * xdisp.c (message_dolog, set_message_1): All callers changed.
3455
3456 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3457
3458 * keyboard.c (safe_run_hook_funcall): New function.
3459 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3460 don't set the hook to nil, but remove the offending function instead.
3461 (Qcommand_hook_internal): Remove, unused.
3462 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3463 Vcommand_hook_internal.
3464
3465 * eval.c (enum run_hooks_condition): Remove.
3466 (funcall_nil, funcall_not): New functions.
3467 (run_hook_with_args): Call each function through a `funcall' argument.
3468 Remove `cond' argument, now redundant.
3469 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3470 (Frun_hook_with_args_until_failure): Adjust accordingly.
3471 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3472
3473 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3474
3475 * dispextern.h (string_buffer_position): Remove declaration.
3476
3477 * print.c (strout): Remove parameter `multibyte', unused since
3478 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3479
3480 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3481 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3482 All callers changed.
3483
3484 * w32.c (_wsa_errlist): Use braces for struct initializers.
3485
3486 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3487 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3488 All callers changed.
3489 (string_buffer_position): Likewise. Also, make static (it's never
3490 used outside xdisp.c).
3491 (cursor_row_p): Remove parameter `w', unused since
3492 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3493 (decode_mode_spec): Remove parameter `precision', introduced during
3494 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3495 All callers changed.
3496
3497 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3498
3499 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3500
3501 2011-03-27 Anders Lindgren <andlind@gmail.com>
3502
3503 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3504 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3505 (ns_update_auto_hide_menu_bar): New functions.
3506 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3507 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3508 ns_constrain_all_frames.
3509 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3510 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3511
3512 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3513
3514 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3515
3516 2011-03-27 Glenn Morris <rgm@gnu.org>
3517
3518 * syssignal.h: Replace RETSIGTYPE with void.
3519 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3520 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3521 Replace SIGTYPE with void everywhere.
3522 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3523 * s/template.h (SIGTYPE): Remove commented out definition.
3524
3525 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3526
3527 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3528 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3529
3530 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3531
3532 * w32.c (read_unc_volume): Use parameter `henum', instead of
3533 global variable `wget_enum_handle'.
3534
3535 * keymap.c (describe_vector): Remove parameters `indices' and
3536 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3537 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3538
3539 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3540
3541 * keyboard.c (timer_check): Remove parameter `do_it_now',
3542 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3543 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3544 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3545
3546 * keyboard.c (read_char):
3547 * w32menu.c (w32_menu_display_help):
3548 * xmenu.c (show_help_event, menu_help_callback):
3549 Adjust calls to `show_help_echo'.
3550
3551 * gtkutil.c (xg_maybe_add_timer):
3552 * keyboard.c (readable_events):
3553 * process.c (wait_reading_process_output):
3554 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3555
3556 * insdel.c (adjust_markers_gap_motion):
3557 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3558 (gap_left, gap_right): Don't call it.
3559
3560 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3561
3562 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3563 incurred during fontification.
3564
3565 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3566
3567 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3568 (DEFVAR_PER_BUFFER): Don't pass it.
3569
3570 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3571 (scrolling_window): Don't pass it.
3572
3573 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3574
3575 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3576
3577 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3578 and `suffix'.
3579 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3580 of variables specific to SELinux and computation of `encoded_absname'.
3581
3582 * image.c (XPutPixel): Remove unused variable `height'.
3583
3584 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3585
3586 * unexw32.c (get_section_info): Remove unused variable `section'.
3587
3588 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3589 (system_process_attributes): Remove unused variable `sess'.
3590 (sys_read): Remove unused variable `err'.
3591
3592 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3593 (w32_wnd_proc): Remove unused variable `isdead'.
3594 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3595 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3596 (x_create_tip_frame): Remove unused variable `tem'.
3597
3598 * w32inevt.c (w32_console_read_socket):
3599 Remove unused variable `no_events'.
3600
3601 * w32term.c (x_draw_composite_glyph_string_foreground):
3602 Remove unused variable `width'.
3603
3604 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3605
3606 * w32term.c (x_set_glyph_string_clipping):
3607 Don't pass uninitialized region to CombineRgn.
3608
3609 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3610
3611 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3612 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3613 (Fx_close_connection): Remove unused variable `i'.
3614
3615 * w32font.c (w32font_draw): Return number of glyphs.
3616 (w32font_open_internal): Remove unused variable `i'.
3617 (w32font_driver): Add missing initializer.
3618
3619 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3620 (fill_in_menu): Remove unused variable `items_added'.
3621
3622 * w32term.c (last_mouse_press_frame): Remove static global variable.
3623 (w32_clip_to_row): Remove unused variable `f'.
3624 (x_delete_terminal): Remove unused variable `i'.
3625
3626 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3627 (NOTHING): Remove unused static global variable.
3628 (uniscribe_check_otf): Remove unused variable `table'.
3629 (uniscribe_font_driver): Add missing initializers.
3630
3631 2011-03-23 Julien Danjou <julien@danjou.info>
3632
3633 * term.c (Fsuspend_tty, Fresume_tty):
3634 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3635 * window.c (temp_output_buffer_show):
3636 * insdel.c (signal_before_change):
3637 * frame.c (Fhandle_switch_frame):
3638 * fileio.c (Fdo_auto_save):
3639 * emacs.c (Fkill_emacs):
3640 * editfns.c (save_excursion_restore):
3641 * cmds.c (internal_self_insert):
3642 * callint.c (Fcall_interactively):
3643 * buffer.c (Fkill_all_local_variables):
3644 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3645 Use Frun_hooks.
3646 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3647 unconditionnaly since it does the check itself.
3648
3649 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3650
3651 Fix more problems found by GCC 4.5.2's static checks.
3652
3653 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3654 the first time through the loop, since we know p0 < p1 then.
3655 This also avoids a gcc -Wstrict-overflow warning.
3656
3657 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3658 leading to a memory leak, possible in functions like
3659 load_charset_map_from_file that can allocate an unbounded number
3660 of objects (Bug#8318).
3661
3662 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3663 that could (at least in theory) be that large.
3664
3665 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3666 This is less likely to overflow, and avoids undefined behavior if
3667 overflow does occur. All callers changed. Use strtoul to scan
3668 for the unsigned long integer.
3669 (pint2hrstr): Simplify and tune code slightly.
3670 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3671
3672 * scroll.c (do_scrolling): Work around GCC bug 48228.
3673 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3674
3675 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3676 This also avoids a warning with gcc -Wstrict-overflow.
3677 (validate_x_resource_name): Simplify count usage.
3678 This also avoids a warning with gcc -Wstrict-overflow.
3679
3680 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3681 fail (Bug#8306).
3682
3683 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3684
3685 * process.c (Fmake_network_process): Use socklen_t, not int,
3686 where POSIX says socklen_t is required in portable programs.
3687 This fixes a porting bug on hosts like 64-bit HP-UX, where
3688 socklen_t is wider than int (Bug#8277).
3689 (Fmake_network_process, server_accept_connection):
3690 (wait_reading_process_output, read_process_output):
3691 Likewise.
3692
3693 * process.c: Rename or move locals to avoid shadowing.
3694 (list_processes_1, Fmake_network_process):
3695 (read_process_output_error_handler, exec_sentinel_error_handler):
3696 Rename or move locals.
3697 (Fmake_network_process): Define label "retry_connect" only if needed.
3698 (Fnetwork_interface_info): Fix pointer signedness.
3699 (process_send_signal): Add cast to avoid pointer signedness problem.
3700 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3701 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3702
3703 Make tparam.h and terminfo.c consistent.
3704 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3705 Include tparam.h instead, since it declares them.
3706 * cm.h (PC): Remove extern decl; tparam.h now does this.
3707 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3708 * terminfo.c: Include tparam.h, to check interfaces.
3709 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3710 (tparam): Adjust signature to match interface in tparam.h;
3711 this removes some undefined behavior. Check that outstring and len
3712 are zero, which they always are with Emacs.
3713 * tparam.h (PC, BC, UP): New extern decls.
3714
3715 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3716 (xftfont_open): Rename locals to avoid shadowing.
3717
3718 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3719 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3720 (OTF_TAG_SYM): Omit macro if not needed.
3721 (ftfont_list): Remove unused local.
3722 (get_adstyle_property, ftfont_pattern_entity):
3723 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3724 Rename locals to avoid shadowing.
3725
3726 * xfont.c (xfont_list_family): Mark var as initialized.
3727
3728 * xml.c (make_dom): Now static.
3729
3730 * composite.c (composition_compute_stop_pos): Rename local to
3731 avoid shadowing.
3732 (composition_reseat_it): Remove unused locals.
3733 (find_automatic_composition, composition_adjust_point): Likewise.
3734 (composition_update_it): Mark var as initialized.
3735 (find_automatic_composition): Mark vars as initialized,
3736 with a FIXME (Bug#8290).
3737
3738 character.h: Rename locals to avoid shadowing.
3739 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3740 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3741 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3742 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3743 to avoid shadowing.
3744
3745 * textprop.c (property_change_between_p): Remove; unused.
3746
3747 * intervals.c (interval_start_pos): Now static.
3748
3749 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3750
3751 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3752 Rename locals to avoid shadowing.
3753
3754 * sound.c (wav_play, au_play, Fplay_sound_internal):
3755 Fix pointer signedness.
3756 (alsa_choose_format): Remove unused local var.
3757 (wav_play): Initialize a variable to 0, to prevent undefined
3758 behavior (Bug#8278).
3759
3760 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3761
3762 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3763
3764 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3765 clobbering (Bug#8298).
3766 * sysdep.c (sys_subshell): Likewise.
3767 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3768
3769 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3770 This should get cleaned up, so that child_setup has the
3771 same signature on all platforms.
3772
3773 * callproc.c (call_process_cleanup): Now static.
3774 (relocate_fd): Rename locals to avoid shadowing.
3775
3776 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3777
3778 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3779 not to be necessary, and produces flickering.
3780
3781 2011-03-20 Glenn Morris <rgm@gnu.org>
3782
3783 * config.in: Remove file.
3784
3785 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3786
3787 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3788 are now in src/globals.h.
3789 (syms_of_minibuf): Remove spurious & from previous change.
3790
3791 2011-03-20 Leo <sdl.web@gmail.com>
3792
3793 * minibuf.c (completing-read-function): New variable.
3794 (completing-read-default): Rename from completing-read.
3795 (completing-read): Call completing-read-function.
3796
3797 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3798
3799 * xfaces.c (Fx_load_color_file):
3800 Read color file from absolute filename (bug#8250).
3801
3802 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3803
3804 * makefile.w32-in: Update dependencies.
3805
3806 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3807
3808 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3809
3810 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 Fix more problems found by GCC 4.5.2's static checks.
3813
3814 * process.c (make_serial_process_unwind, send_process_trap):
3815 (sigchld_handler): Now static.
3816
3817 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3818 That way, the code declares only the vars that it needs.
3819 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3820 * s/cygwin.h (PTY_ITERATION): Likewise.
3821 * s/darwin.h (PTY_ITERATION): Likewise.
3822 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3823
3824 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3825 * process.c (allocate_pty): Don't declare stb unless it's needed.
3826
3827 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3828 (CONSTANTLIM): Remove; unused.
3829 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3830 Define only if needed.
3831
3832 * unexelf.c (unexec): Name an expression,
3833 to avoid gcc -Wbad-function-cast warning.
3834 Use a different way to cause a compilation error if anyone uses
3835 n rather than nn, a way that does not involve shadowing.
3836 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3837
3838 * deps.mk (unexalpha.o): Remove; unused.
3839
3840 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3841 * unexec.h: New file.
3842 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3843 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3844 Depend on unexec.h.
3845 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3846 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3847 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3848 Change as necessary to match prototype in unexec.h.
3849
3850 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3851 shadowing.
3852 (back_comment, skip_chars): Mark vars as initialized.
3853
3854 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3855 Rename locals to avoid shadowing.
3856
3857 * lread.c (read1): Rewrite so as not to use empty "else".
3858 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3859
3860 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3861
3862 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3863 warning when compiling print.c.
3864
3865 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3866 instead of using an uninitialized var.
3867 (font_sort_entities): Mark var as initialized.
3868
3869 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3870
3871 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3872 pointers to constants.
3873 (font_parse_fcname): Remove unused vars.
3874 (font_delete_unmatched): Now static.
3875 (font_get_spec): Remove; unused.
3876 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3877 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3878 Rename or move locals to avoid shadowing.
3879
3880 * fns.c (require_nesting_list, require_unwind): Now static.
3881 (Ffillarray): Rename locals to avoid shadowing.
3882
3883 * floatfns.c (domain_error2): Define only if needed.
3884 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3885
3886 * alloc.c (mark_backtrace): Move decl from here ...
3887 * lisp.h: ... to here, so that it can be checked.
3888
3889 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3890 (Fdefvar): Rewrite so as not to use empty "else".
3891 (lisp_indirect_variable): Name an expression,
3892 to avoid gcc -Wbad-function-cast warning.
3893 (Fdefvar): Rename locals to avoid shadowing.
3894
3895 * callint.c (quotify_arg, quotify_args): Now static.
3896 (Fcall_interactively): Rename locals to avoid shadowing.
3897 Use const pointer when appropriate.
3898
3899 * lisp.h (get_system_name, get_operating_system_release):
3900 Move decls here, to check interfaces.
3901 * process.c (get_operating_system_release): Move decl to lisp.h.
3902 * xrdb.c (get_system_name): Likewise.
3903 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3904 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3905 some of which prompt warnings from gcc -Wbad-function-cast.
3906 (Fformat_time_string, Fencode_time, Finsert_char):
3907 (Ftranslate_region_internal, Fformat):
3908 Rename or remove local vars to avoid shadowing.
3909 (Ftranslate_region_internal): Mark var as initialized.
3910
3911 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3912 avoid shadowing.
3913
3914 * lisp.h (eassert): Check that the argument compiles, even if
3915 ENABLE_CHECKING is not defined.
3916
3917 * data.c (Findirect_variable): Name an expression, to avoid
3918 gcc -Wbad-function-cast warning.
3919 (default_value, arithcompare, arith_driver, arith_error): Now static.
3920 (store_symval_forwarding): Rename local to avoid shadowing.
3921 (Fmake_variable_buffer_local, Fmake_local_variable):
3922 Mark variables as initialized.
3923 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3924
3925 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3926 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3927 Rename locals to avoid shadowing.
3928 (mark_stack): Move local variables into the #ifdef region where
3929 they're used.
3930 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3931 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3932 needed otherwise.
3933 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3934 (GC_STRING_CHARS): Remove; not used.
3935 (Fmemory_limit): Cast sbrk's returned value to char *.
3936
3937 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3938 avoids undefined behavior in theory.
3939
3940 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3941
3942 Use functions, not macros, for up- and down-casing (Bug#8254).
3943 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3944 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3945 to use the following functions instead of these macros.
3946 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3947 EMACS_INT, since callers assume the returned value fits in int.
3948 (upcase1): Likewise, for UPCASE_TABLE.
3949 (uppercasep, lowercasep, upcase): New static inline functions.
3950 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3951 the race-condition problem in the old DOWNCASE.
3952
3953 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3954 Rename locals to avoid shadowing.
3955 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3956 (regex_compile, re_search_2, re_match_2_internal):
3957 Remove unused local vars.
3958 (FREE_VAR): Rewrite so as not to use empty "else",
3959 which gcc can warn about.
3960 (regex_compile, re_match_2_internal): Mark locals as initialized.
3961 (RETALLOC_IF): Define only if needed.
3962 (WORDCHAR_P): Likewise. This one is never needed, but is used
3963 only in a comment talking about a compiler bug, so put inside
3964 the #if 0 of that comment.
3965 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3966 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3967 Remove; unused.
3968
3969 * search.c (boyer_moore): Rename locals to avoid shadowing.
3970 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3971 (PREV_CHAR_BOUNDARY): Likewise.
3972
3973 * search.c (simple_search): Remove unused var.
3974
3975 * dired.c (compile_pattern): Move decl from here ...
3976 * lisp.h: ... to here, so that it can be checked.
3977 (struct re_registers): New forward decl.
3978
3979 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3980
3981 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3982 All uses changed.
3983 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3984 Rename locals to avoid shadowing.
3985 (Fvertical_motion): Mark locals as initialized.
3986
3987 * casefiddle.c (casify_object, casify_region): Now static.
3988 (casify_region): Mark local as initialized.
3989
3990 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3991
3992 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3993 New macros, so that the caller can use some names other than
3994 gcpro1, gcpro2, etc.
3995 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3996 of the new macros.
3997 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3998 argument, for consistency with GCPRO2_VAR, etc: it is now the
3999 prefix of the variable, not the variable itself. All uses
4000 changed.
4001 * dired.c (directory_files_internal, file_name_completion):
4002 Rename locals to avoid shadowing.
4003
4004 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4005 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4006 dired.c's scmp function, had undefined behavior.
4007 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4008 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4009 * buffer.h: ... to here, because these macros use current_buffer,
4010 and the new implementation with inline functions needs to have
4011 current_buffer in scope now, rather than later when the macros
4012 are used.
4013 (downcase, upcase1): New static inline functions.
4014 (DOWNCASE, UPCASE1): Reimplement using these functions.
4015 This avoids undefined behavior in expressions like
4016 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4017 from race conditions in accessing the global variables
4018 case_temp1 and case_temp2.
4019 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4020 * lisp.h (case_temp1, case_temp2): Remove their decls.
4021 * character.h (ASCII_CHAR_P): Move from here ...
4022 * lisp.h: ... to here, so that the inline functions mentioned
4023 above can use them.
4024
4025 * dired.c (directory_files_internal_unwind): Now static.
4026
4027 * fileio.c (file_name_as_directory, directory_file_name):
4028 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4029 Now static.
4030 (file_name_as_directory): Use const pointers when appropriate.
4031 (Fexpand_file_name): Likewise. In particular, newdir might
4032 point at constant storage, so make it a const pointer.
4033 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4034 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4035 signedness issues.
4036 (Fset_file_times, Finsert_file_contents, auto_save_error):
4037 Rename locals to avoid shadowing.
4038
4039 * minibuf.c (choose_minibuf_frame_1): Now static.
4040 (Ftry_completion, Fall_completions): Rename or remove locals
4041 to avoid shadowing.
4042
4043 * marker.c (bytepos_to_charpos): Remove; unused.
4044
4045 * lisp.h (verify_bytepos, count_markers): New decls,
4046 so that gcc does not warn that these functions aren't declared.
4047
4048 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4049 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4050 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4051 (copy_text): Remove unused local var.
4052
4053 * filelock.c (within_one_second): Now static.
4054 (lock_file_1): Rename local to avoid shadowing.
4055
4056 * buffer.c (fix_overlays_before): Mark locals as initialized.
4057 (fix_start_end_in_overlays): Likewise. This function should be
4058 simplified by using pointers-to-pointers, but that's a different
4059 matter.
4060 (switch_to_buffer_1): Now static.
4061 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4062 (report_overlay_modification): Rename locals to avoid shadowing.
4063
4064 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4065 Fix pointer signedness issue.
4066 (sys_subshell): Mark local as volatile if checking for lint,
4067 to suppress a gcc -Wclobbered warning that does not seem to be right.
4068 (MAXPATHLEN): Define only if needed.
4069
4070 * process.c (serial_open, serial_configure): Move decls from here ...
4071 * systty.h: ... to here, so that they can be checked.
4072
4073 * fns.c (get_random, seed_random): Move extern decls from here ...
4074 * lisp.h: ... to here, so that they can be checked.
4075
4076 * sysdep.c (reset_io): Now static.
4077 (wait_for_termination_signal): Remove; unused.
4078
4079 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4080 (copy_keymap_item, append_key, push_text_char_description):
4081 Now static.
4082 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4083 (DENSE_TABLE_SIZE): Remove; unused.
4084 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4085 (describe_map_tree):
4086 Rename locals to avoid shadowing.
4087
4088 * keyboard.c: Declare functions static if they are not used elsewhere.
4089 (echo_char, echo_dash, cmd_error, top_level_2):
4090 (poll_for_input, handle_async_input): Now static.
4091 (read_char, kbd_buffer_get_event, make_lispy_position):
4092 (make_lispy_event, make_lispy_movement, apply_modifiers):
4093 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4094 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4095 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4096 (read_key_sequence, read_char): Mark locals as initialized.
4097 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4098
4099 * keyboard.h (make_ctrl_char): New decl.
4100 (mark_kboards): Move decl here ...
4101 * alloc.c (mark_kboards): ... from here.
4102
4103 * lisp.h (force_auto_save_soon): New decl.
4104
4105 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4106 (DEFINE_DUMMY_FUNCTION): New macro.
4107 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4108 Use it.
4109 (main): Add casts to avoid warnings
4110 if GCC considers string literals to be constants.
4111
4112 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4113
4114 * dbusbind.c: Pointer signedness fixes.
4115 (xd_signature, xd_append_arg, xd_initialize):
4116 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4117 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4118 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4119 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4120
4121 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4122 if GCC considers string literals to be constants.
4123 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4124
4125 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4126
4127 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4128 (print_preprocess, print_object): New macro to fix last change.
4129
4130 * print.c (print_preprocess): Don't forget font objects.
4131
4132 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4133
4134 * emacs.c (USAGE3): Doc fixes.
4135
4136 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4137
4138 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4139 structure.
4140
4141 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4142
4143 * lisp.h (VWindow_system, Qfile_name_history):
4144 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4145 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4146 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4147
4148 * w32select.c: Don't #include "keyboard.h".
4149 (run_protected): Add extern declaration for waiting_for_input.
4150
4151 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4152 * w32console.c (detect_input_pending, read_input_pending)
4153 (encode_terminal_code):
4154 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4155 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4156 (w32_system_caret_y, Qfile_name_history):
4157 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4158 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4159 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4160 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4161 * w32proc.c (Qlocal, report_file_error):
4162 * w32term.c (Vwindow_system, updating_frame):
4163 * w32uniscribe.c (initialized, uniscribe_font_driver):
4164 Remove unneeded extern declarations.
4165
4166 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4167
4168 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4169
4170 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4171
4172 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4173 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4174 These macros can no longer be used for assignment.
4175
4176 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4177 Assign struct members directly, instead of using BUF_BEGV etc.
4178 (record_buffer_markers, fetch_buffer_markers): New functions for
4179 recording and fetching special buffer markers.
4180 (set_buffer_internal_1, set_buffer_temp): Use them.
4181
4182 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4183
4184 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4185
4186 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4187 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4188
4189 * xdisp.c (hscroll_window_tree):
4190 (reconsider_clip_changes): Use PT instead of BUF_PT.
4191
4192 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4193
4194 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4195 $(EMACS_ROOT)/lib/intprops.h.
4196
4197 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4198
4199 Fix more problems found by GCC 4.5.2's static checks.
4200
4201 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4202 to unsigned char * to avoid compiler diagnostic.
4203 (xg_free_frame_widgets): Make it clear that a local variable is
4204 needed only if USE_GTK_TOOLTIP.
4205 (gdk_window_get_screen): Make it clear that this macro is needed
4206 only if USE_GTK_TOOLTIP.
4207 (int_gtk_range_get_value): New function, which avoids a diagnostic
4208 from gcc -Wbad-function-cast.
4209 (xg_set_toolkit_scroll_bar_thumb): Use it.
4210 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4211 diagnostic from gcc -Wbad-function-cast.
4212 (get_utf8_string, xg_get_file_with_chooser):
4213 Rename locals to avoid shadowing.
4214 (create_dialog): Move locals to avoid shadowing.
4215
4216 * xgselect.c (xg_select): Remove unused var.
4217
4218 * image.c (four_corners_best): Mark locals as initialized.
4219 (gif_load): Initialize transparent_p to zero (Bug#8238).
4220 Mark another local as initialized.
4221 (my_png_error, my_error_exit): Mark with NO_RETURN.
4222
4223 * image.c (clear_image_cache): Now static.
4224 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4225 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4226 (x_edge_detection): Remove unnecessary cast that
4227 gcc -Wbad-function-cast diagnoses.
4228 (gif_load): Fix pointer signedness.
4229 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4230 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4231
4232 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4233
4234 Improve quality of tests for time stamp overflow.
4235 For example, without this patch (encode-time 0 0 0 1 1
4236 1152921504606846976) returns the obviously-bogus value (-948597
4237 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4238 reports time overflow. See
4239 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4240 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4241 * editfns.c: Include limits.h and intprops.h.
4242 (TIME_T_MIN, TIME_T_MAX): New macros.
4243 (time_overflow): Move earlier, to before first use.
4244 (hi_time, lo_time): New functions, for an accurate test for
4245 out-of-range times.
4246 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4247 (Fget_internal_run_time): Don't assume time_t fits in int.
4248 (make_time): Use list2 instead of Fcons twice.
4249 (Fdecode_time): More accurate test for out-of-range times.
4250 (check_tm_member): New function.
4251 (Fencode_time): Use it, to test for out-of-range times.
4252 (lisp_time_argument): Don't rely on undefined left-shift and
4253 right-shift behavior when checking for time stamp overflow.
4254
4255 * editfns.c (time_overflow): New function, refactoring common code.
4256 (Fformat_time_string, Fdecode_time, Fencode_time):
4257 (Fcurrent_time_string): Use it.
4258
4259 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4260 * dired.c (make_time): Move to ...
4261 * editfns.c (make_time): ... here.
4262 * systime.h: Note the move.
4263
4264 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4265
4266 * fringe.c (update_window_fringes): Remove unused variables.
4267
4268 * unexmacosx.c (copy_data_segment): Also copy __got section.
4269 (Bug#8223)
4270
4271 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4272
4273 * termcap.c [MSDOS]: Include "msdos.h".
4274 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4275 Constify `char *' arguments and their references according to
4276 prototypes in tparam.h.
4277
4278 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4279
4280 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4281 Adapt all references accordingly.
4282
4283 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4284
4285 2011-03-11 Tom Tromey <tromey@redhat.com>
4286
4287 * buffer.c (syms_of_buffer): Remove obsolete comment.
4288
4289 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4290
4291 * termhooks.h (encode_terminal_code): Declare prototype.
4292
4293 * msdos.c (encode_terminal_code): Don't declare prototype.
4294
4295 * term.c (encode_terminal_code): Now external again, used by
4296 w32console.c and msdos.c.
4297
4298 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4299 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4300
4301 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4302
4303 Fix some minor problems found by GCC 4.5.2's static checks.
4304
4305 * fringe.c (update_window_fringes): Mark locals as initialized
4306 (Bug#8227).
4307 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4308
4309 * alloc.c (mark_fringe_data): Move decl from here ...
4310 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4311 to check its interface.
4312 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4313
4314 * fontset.c (free_realized_fontset): Now static.
4315 (Fset_fontset_font): Rename local to avoid shadowing.
4316 (fontset_font): Mark local as initialized.
4317 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4318
4319 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4320
4321 * xselect.c (x_disown_buffer_selections): Remove; not used.
4322 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4323 (x_own_selection, Fx_disown_selection_internal): Rename locals
4324 to avoid shadowing.
4325 (x_handle_dnd_message): Remove local to avoid shadowing.
4326
4327 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4328 so that the caller can use some name other than gcpro1.
4329 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4330 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4331 (Fx_backspace_delete_keys_p):
4332 Use them to avoid shadowing, and rename vars to avoid shadowing.
4333 (x_decode_color, x_set_name, x_window): Now static.
4334 (Fx_create_frame): Add braces to silence GCC warning.
4335 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4336 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4337 Remove unused locals.
4338 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4339 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4340 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4341 macros.
4342
4343 * xterm.h (x_mouse_leave): New decl.
4344
4345 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4346 Remove unused functions.
4347 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4348 (x_calc_absolute_position): Now static.
4349 (XTread_socket): Don't define label "out" unless it's used.
4350 Don't declare local "event" unless it's used.
4351 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4352 unless they are used.
4353 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4354 (x_fatal_error_signal): Remove; not used.
4355 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4356 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4357 (x_error_catcher, x_connection_closed, x_error_handler):
4358 (x_error_quitter, xembed_send_message, x_iconify_frame):
4359 (my_log_handler): Rename locals to avoid shadowing.
4360 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4361 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4362
4363 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4364 Rename or move locals to avoid shadowing.
4365 (tty_defined_color, merge_face_heights): Now static.
4366 (free_realized_faces_for_fontset): Remove; not used.
4367 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4368 does not deduce is never used uninitialized.
4369 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4370 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4371
4372 * terminal.c (store_terminal_param): Now static.
4373
4374 * xmenu.c (menu_highlight_callback): Now static.
4375 (set_frame_menubar): Remove unused local.
4376 (xmenu_show): Rename parameter to avoid shadowing.
4377 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4378 since they might point to immutable storage.
4379 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4380 since it's unused otherwise.
4381
4382 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4383 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4384 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4385 avoids a gcc -Wuninitialized diagnostic.
4386 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4387 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4388 does not deduce are never used uninitialized.
4389
4390 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4391
4392 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4393 * window.c (window_loop, size_window):
4394 (run_window_configuration_change_hook, enlarge_window): Likewise.
4395
4396 * window.c (display_buffer): Now static.
4397 (size_window): Mark variables that gcc -Wuninitialized
4398 does not deduce are never used uninitialized.
4399 * window.h (check_all_windows): New decl, to forestall
4400 gcc -Wmissing-prototypes diagnostic.
4401 * dispextern.h (bidi_dump_cached_states): Likewise.
4402
4403 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4404 shadowing.
4405 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4406 Include <limits.h>.
4407 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4408 and to avoid gcc -Wuninitialized warning.
4409 (load_charset_map): Mark variables that gcc -Wuninitialized
4410 does not deduce are never used uninitialized.
4411 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4412
4413 * coding.c (coding_set_source, coding_set_destination):
4414 Use "else { /* comment */ }" rather than "else /* comment */;"
4415 for clarity, and to avoid gcc -Wempty-body warning.
4416 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4417 a block, when the outer 'i' will do.
4418 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4419 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4420 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4421 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4422 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4423 Rename locals to avoid shadowing.
4424 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4425 * coding.c (emacs_mule_char, encode_invocation_designation):
4426 Now static, since they're not used elsewhere.
4427 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4428 (decode_coding_object, encode_coding_object, detect_coding_system):
4429 (decode_coding_emacs_mule): Mark variables that gcc
4430 -Wuninitialized does not deduce are never used uninitialized.
4431 (detect_coding_iso_2022): Initialize a local variable that might
4432 be used uninitialized. Leave a FIXME because it's not clear that
4433 this initialization is needed. (Bug#8211)
4434 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4435 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4436 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4437 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4438 Remove unused macros.
4439
4440 * category.c (hash_get_category_set): Remove unused local var.
4441 (copy_category_table): Now static, since it's not used elsewhere.
4442 * character.c (string_count_byte8): Likewise.
4443
4444 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4445 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4446
4447 * chartab.c (copy_sub_char_table): Now static, since it's not used
4448 elsewhere.
4449 (sub_char_table_ref_and_range, char_table_ref_and_range):
4450 Rename locals to avoid shadowing.
4451 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4452
4453 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4454 (BIDI_BOB): Remove unused macro.
4455
4456 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4457 deduce are never used uninitialized.
4458 * term.c (encode_terminal_code): Likewise.
4459
4460 * term.c (encode_terminal_code): Now static. Remove unused local.
4461
4462 * tparam.h: New file.
4463 * term.c, tparam.h: Include it.
4464 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4465 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4466 Move these decls to tparam.h, and make them agree with what
4467 is actually in tparam.c. The previous trick of using incompatible
4468 decls in different modules does not conform to the C standard.
4469 All callers of tparam changed to use tparam's actual API.
4470 * tparam.c (tparam1, tparam, tgoto):
4471 Use const pointers where appropriate.
4472
4473 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4474 * cm.h (struct cm): Likewise.
4475 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4476 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4477 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4478 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4479 (turn_on_face, init_tty): Likewise.
4480 * termchar.h (struct tty_display_info): Likewise.
4481
4482 * term.c (term_mouse_position): Rename local to avoid shadowing.
4483
4484 * alloc.c (mark_ttys): Move decl from here ...
4485 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4486
4487 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4488
4489 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4490
4491 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4492
4493 * search.c (compile_pattern_1): Remove argument regp, unused since
4494 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4495 (compile_pattern): Don't pass it.
4496
4497 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4498
4499 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4500 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4501 for ! HAVE_GTK3.
4502 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4503
4504 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4505
4506 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4507 gdk_window_get_screen, gdk_window_get_geometry,
4508 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4509 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4510 (xg_get_pixbuf_from_pixmap): New function.
4511 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4512 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4513 Call xg_get_pixbuf_from_pixmap instead of
4514 gdk_pixbuf_get_from_drawable.
4515 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4516 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4517 (xg_check_special_colors): Use GtkStyleContext and its functions
4518 for HAVE_GTK3.
4519 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4520 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4521 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4522 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4523 Call gtk_widget_get_preferred_size.
4524 (xg_frame_resized): gdk_window_get_geometry only takes 5
4525 parameters.
4526 (xg_win_to_widget, xg_event_is_for_menubar):
4527 Call gdk_x11_window_lookup_for_display.
4528 (xg_set_widget_bg): New function.
4529 (delete_cb): New function.
4530 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4531 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4532 (xg_set_background_color): Call xg_set_widget_bg.
4533 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4534 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4535 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4536 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4537 if ! HAVE_GTK3.
4538 (update_frame_tool_bar): Call gtk_widget_hide.
4539 (xg_initialize): Use GDK_KEY_g.
4540
4541 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4542 if ! HAVE_GTK3
4543 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4544
4545 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4546 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4547 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4548
4549 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4550
4551 * w32xfns.c (select_palette): Check success of RealizePalette against
4552 GDI_ERROR, not zero.
4553
4554 See ChangeLog.11 for earlier changes.
4555
4556 ;; Local Variables:
4557 ;; coding: utf-8
4558 ;; End:
4559
4560 Copyright (C) 2011 Free Software Foundation, Inc.
4561
4562 This file is part of GNU Emacs.
4563
4564 GNU Emacs is free software: you can redistribute it and/or modify
4565 it under the terms of the GNU General Public License as published by
4566 the Free Software Foundation, either version 3 of the License, or
4567 (at your option) any later version.
4568
4569 GNU Emacs is distributed in the hope that it will be useful,
4570 but WITHOUT ANY WARRANTY; without even the implied warranty of
4571 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4572 GNU General Public License for more details.
4573
4574 You should have received a copy of the GNU General Public License
4575 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.