1 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4 position past the first glyph_row that ends at ZV. (Bug#10902)
6 2012-03-02 Glenn Morris <rgm@gnu.org>
8 * buffer.c (buffer-list-update-hook): Doc fix.
10 2012-02-29 Eli Zaretskii <eliz@gnu.org>
12 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
13 push_it before setting up the iterator for the first overlay
14 string, even if we have an empty string loaded.
15 (next_overlay_string): If there's an empty string on the iterator
16 stack, pop the stack. (Bug#10903)
18 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
20 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
21 Suggested by Stefan Monnier in
22 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
23 * alloc.c (widen_to_Lisp_Object): New static function.
24 (mark_memory): Also mark Lisp_Objects by fetching pointer words
25 and widening them to Lisp_Objects. This would work even if
26 USE_LSB_TAG is defined and wide integers are used, which might
27 happen in a future version of Emacs.
29 2012-02-25 Chong Yidong <cyd@gnu.org>
31 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
34 * xselect.c (Fx_selection_exists_p): Doc fix.
35 (x_clipboard_manager_save_all): Print an informative message
36 before saving to clipboard manager.
38 2012-02-24 Chong Yidong <cyd@gnu.org>
40 * keyboard.c (process_special_events): Handle all X selection
41 requests in kbd_buffer, not just the next one (Bug#8869).
43 2012-02-23 Chong Yidong <cyd@gnu.org>
45 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
46 call when setting menu-bar-lines and tool-bar-lines parameters.
47 (unwind_create_frame_1): New helper function.
49 * window.c (inhibit_window_configuration_change_hook): New var.
50 (run_window_configuration_change_hook): Obey it.
51 (syms_of_window): Initialize it.
53 2012-02-22 Chong Yidong <cyd@gnu.org>
55 * xterm.c (x_draw_image_relief): Add missing type check for
56 Vtool_bar_button_margin (Bug#10743).
58 2012-02-21 Chong Yidong <cyd@gnu.org>
60 * fileio.c (Vfile_name_handler_alist): Doc fix.
62 * buffer.c (Fget_file_buffer): Protect against invalid file
65 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
67 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
68 when computing $valmask.
70 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
71 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
72 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
73 It's useless in that case, and it can cause problems on hosts
74 that allocate halves of EMACS_INT values separately.
75 Reported by Dan Horák. Diagnosed by Andreas Schwab in
76 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
77 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
78 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
79 it avoids undefined behavior on hosts where shifting right by more
80 than the word width has undefined behavior.
82 2012-02-19 Chong Yidong <cyd@gnu.org>
84 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
85 (Funhandled_file_name_directory, Ffile_name_as_directory)
86 (Fdirectory_file_name, Fexpand_file_name)
87 (Fsubstitute_in_file_name): Protect against invalid file handler
88 return values (Bug#10845).
90 2012-02-18 Eli Zaretskii <eliz@gnu.org>
92 * .gdbinit (pitx): Fix incorrect references to fields of the
95 2012-02-17 Chong Yidong <cyd@gnu.org>
97 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
99 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
101 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
102 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
104 2012-02-15 Chong Yidong <cyd@gnu.org>
106 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
107 marked as special. Also, starting docstrings with * is obsolete.
109 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
111 * gnutls.c (emacs_gnutls_write): Fix last change.
113 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
115 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
118 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
120 * keymap.c (Fsingle_key_description): Handle char ranges.
122 2012-02-12 Chong Yidong <cyd@gnu.org>
124 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
125 as that creates a dangerous corner case.
127 * window.c (Fdelete_window_internal): Invalidate the mouse
128 highlight (Bug#9904).
130 2012-02-12 Glenn Morris <rgm@gnu.org>
132 * xselect.c (Fx_own_selection_internal)
133 (Fx_get_selection_internal, Fx_disown_selection_internal)
134 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
135 * nsselect.m (Fx_own_selection_internal)
136 (Fx_disown_selection_internal, Fx_selection_exists_p)
137 (Fx_selection_owner_p, Fx_get_selection_internal):
138 Sync docs and argument specs with the xselect.c versions.
140 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
142 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
144 2012-02-11 Eli Zaretskii <eliz@gnu.org>
146 * w32select.c (Fx_selection_exists_p): Sync doc string and
147 argument list with xselect.c. (Bug#10783)
149 * w16select.c (Fx_selection_exists_p): Sync doc string and
150 argument list with xselect.c. (Bug#10783)
152 2012-02-10 Glenn Morris <rgm@gnu.org>
154 * fns.c (Fsecure_hash): Doc fix.
156 2012-02-09 Kenichi Handa <handa@m17n.org>
158 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
160 2012-02-07 Chong Yidong <cyd@gnu.org>
162 * buffer.c (Fbuffer_local_variables)
163 (buffer_lisp_local_variables): Handle unbound vars correctly;
164 don't let Qunbound leak into Lisp.
166 2012-02-07 Glenn Morris <rgm@gnu.org>
168 * image.c (Fimagemagick_types): Doc fix.
170 * image.c (imagemagick-render-type): Change it from a lisp object
171 to an integer. Move the doc here from the lisp manual.
172 Treat all values not equal to 0 the same.
174 2012-02-06 Chong Yidong <cyd@gnu.org>
176 * doc.c (store_function_docstring): Avoid applying docstring of
177 alias to base function (Bug#2603).
179 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
181 * .gdbinit (pp1, pv1): Remove redundant defines.
184 2012-02-04 Chong Yidong <cyd@gnu.org>
186 * nsterm.m: Declare a global (Bug#10694).
188 2012-02-04 Eli Zaretskii <eliz@gnu.org>
190 * w32.c (get_emacs_configuration_options): Include
191 --enable-checking, if specified, in the return value.
193 2012-02-04 Martin Rudalics <rudalics@gmx.at>
195 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
196 after rounding frame sizes. (Bug#9723)
198 2012-02-04 Eli Zaretskii <eliz@gnu.org>
200 * keyboard.c (adjust_point_for_property): Don't position point
201 before BEGV. (Bug#10696)
203 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
205 Handle overflow when computing char display width (Bug#9496).
206 * character.c (char_width): Return EMACS_INT, not int.
207 (char_width, c_string_width): Check for overflow when
208 computing the width; this is possible now that individual
209 characters can have unbounded width. Problem introduced
210 by merge from Emacs 23 on 2012-01-19.
212 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
214 * dbusbind.c (Fdbus_register_method): Mention the return value
215 :ignore in the docstring.
217 2012-02-02 Glenn Morris <rgm@gnu.org>
219 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
221 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
222 Unconditionally set to t. (Bug#10673)
223 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
224 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
225 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
227 2012-02-02 Kenichi Handa <handa@m17n.org>
229 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
230 0, do not call append_composite_glyph.
232 2012-02-02 Kenichi Handa <handa@m17n.org>
234 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
236 (x_produce_glyphs): If the component of a composition is a null
237 string, set it->pixel_width to 1 to avoid zero-width glyph.
239 2012-02-01 Eli Zaretskii <eliz@gnu.org>
241 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
242 first 2 arguments are identical. This makes inserting large
243 output from a subprocess an order of magnitude faster on
244 MS-Windows, where all sbrk'ed memory is always contiguous.
246 2012-01-31 Glenn Morris <rgm@gnu.org>
248 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
249 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
250 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
252 2012-01-29 Glenn Morris <rgm@gnu.org>
254 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
256 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
258 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
260 2012-01-28 Chong Yidong <cyd@gnu.org>
262 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
264 2012-01-26 Chong Yidong <cyd@gnu.org>
266 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
268 * search.c (Fsearch_forward, Fsearch_backward): Document negative
269 repeat counts (Bug#10507).
271 2012-01-26 Glenn Morris <rgm@gnu.org>
273 * lread.c (syms_of_lread): Doc fix.
275 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
277 * coding.c (encode_designation_at_bol): Change return value to
280 2012-01-25 Chong Yidong <cyd@gnu.org>
282 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
284 2012-01-21 Chong Yidong <cyd@gnu.org>
286 * floatfns.c (Fcopysign): Make the second argument non-optional,
287 since nil is not allowed anyway.
289 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
291 * process.c (read_process_output): Use p instead of XPROCESS (proc).
292 (send_process): Likewise.
294 2012-01-19 Martin Rudalics <rudalics@gmx.at>
296 * window.c (save_window_save, Fcurrent_window_configuration)
297 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
300 2012-01-19 Kenichi Handa <handa@m17n.org>
302 * character.c (char_width): New function.
303 (Fchar_width, c_string_width, lisp_string_width):
304 Use char_width (Bug#9496).
306 2012-01-16 Martin Rudalics <rudalics@gmx.at>
308 * window.c (Vwindow_persistent_parameters): New variable.
309 (Fset_window_configuration, save_window_save): Handle persistent
312 2012-01-14 Eli Zaretskii <eliz@gnu.org>
314 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
315 thrashing the stack of the thread. (Bug#9087)
317 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
319 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
321 2012-01-11 Eli Zaretskii <eliz@gnu.org>
323 * xdisp.c (rows_from_pos_range): Handle the case where the
324 highlight ends on a newline. (Bug#10464)
325 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
326 he end column for display of highlight that ends on a newline
329 2012-01-11 Glenn Morris <rgm@gnu.org>
331 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
332 from load-path also when installation-directory is nil. (Bug#10208)
334 2012-01-10 Glenn Morris <rgm@gnu.org>
336 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
338 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
339 Update template values to be closer to their typical values these days.
341 2012-01-09 Eli Zaretskii <eliz@gnu.org>
343 * xdisp.c (rows_from_pos_range): Accept additional argument
344 DISP_STRING, and accept any glyph in a row whose object is that
345 string as eligible for mouse highlight. Fixes mouse highlight of
346 display strings from overlays. (Bug#10464)
348 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
350 emacs: fix an auto-save permissions race condition (Bug#10400)
351 * fileio.c (auto_saving_dir_umask): New static var.
352 (Fmake_directory_internal): Use it.
353 (do_auto_save_make_dir): Set it, instead of invoking chmod after
354 creating the directory. The old code temporarily assigns
355 too-generous permissions to the directory.
356 (do_auto_save_eh): Clear it.
357 (Fdo_auto_save): Catch all errors, not just file errors, so
358 that the var is always cleared.
360 2012-01-07 Eli Zaretskii <eliz@gnu.org>
362 * search.c (scan_buffer): Pass character positions to
363 know_region_cache, not byte positions. (Bug#6540)
365 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
367 * w32.c (sys_rename): Report EXDEV when rename of a directory
368 fails because the target is on another logical disk. (Bug#10284)
370 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
372 * xterm.c (x_embed_request_focus): New function.
374 * xterm.h: Add prototype.
376 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
378 2012-01-05 Glenn Morris <rgm@gnu.org>
380 * emacs.c (emacs_copyright): Update short copyright year to 2012.
382 2012-01-01 Eli Zaretskii <eliz@gnu.org>
384 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
385 Load gnutls_transport_set_lowat only if GnuTLS version is below
387 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
388 GnuTLS versions below 2.11.1.
390 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
392 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
393 to the doc string advising against its use for altering the way
394 windows are scrolled.
396 2011-12-28 Kenichi Handa <handa@m17n.org>
398 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
399 coding-system ASCII compatible only when it does not produce BOM
400 on encoding (Bug#10383).
402 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
404 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
406 (create_and_show_popup_menu): Always use menu_position_func for
409 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
411 * callint.c (Fcall_interactively): Don't truncate prompt string.
413 2011-12-23 Eli Zaretskii <eliz@gnu.org>
415 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
416 property that ends at ZV, so that the bidi iteration could be
417 resumed from there (after widening). (Bug#10360)
419 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
421 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
423 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
425 * nsterm.m (x_free_frame_resources):
426 Release f->output_data.ns->miniimage.
427 (ns_index_color): Fix indentation. Do not retain
428 color_table->colors[i].
430 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
433 * nsfns.m (x_set_background_color): Assign return value from
434 ns_index_color to face-background instead of NSColor*.
435 (ns_implicitly_set_icon_type): Fix indentation.
436 Change assignment in for loop to comparison.
438 * emacs.c (ns_pool): New variable.
439 (main): Assign ns_pool.
440 (Fkill_emacs): Call ns_release_autorelease_pool.
442 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
443 autorelease fdesc, release fdAttrs and tdict.
444 (ns_get_covering_families): Release charset.
445 (ns_findfonts): Release NSFontDescriptor created with new.
446 (ns_uni_to_glyphs): Fix indentation.
447 (setString): Release attrStr before assigning new value.
449 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
451 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
453 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
454 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
456 2011-12-18 David Reitter <reitter@cmu.edu>
458 * nsterm.m (ns_term_init): Subscribe for notifications
459 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
460 to method trackingNotification in EmacsMenu.
462 * nsmenu.m (trackingMenu): New variable.
463 (trackingNotification): New method (from Aquamacs).
464 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
465 from Aquamacs (Bug#7030).
467 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
469 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
470 (symbol_to_nsstring): Fix indentation.
471 (ns_symbol_to_pb): New function.
472 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
473 (Fns_rotate_cut_buffers_internal): Removed.
474 (Fns_store_selection_internal): Renamed from
475 Fns_store_cut_buffer_internal.
476 (ns_get_foreign_selection, Fx_own_selection_internal)
477 (Fx_disown_selection_internal, Fx_selection_exists_p)
478 (Fns_get_selection_internal, Fns_store_selection_internal):
479 Use ns_symbol_to_pb and check if return value is nil.
480 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
481 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
482 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
483 renamed to Sns_store_selection_internal.
484 (ns_handle_selection_request): Move code to Fx_own_selection_internal
485 and remove this function.
486 (ns_handle_selection_clear): Remove, never used.
487 (Fx_own_selection_internal): Move code from ns_handle_selection_request
490 2011-12-17 Ken Brown <kbrown@cornell.edu>
492 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
493 GID is unknown (Bug#10257).
495 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
497 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
498 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
499 which caused a build failure on GNU/Linux IA-64. This problem was
500 introduced by my 2011-10-07 patch.
502 2011-12-15 Juri Linkov <juri@jurta.org>
504 * image.c (imagemagick_error): New function. (Bug#10112)
505 (imagemagick_load_image): Comment out `MagickSetResolution' call.
506 Use `imagemagick_error' where ImageMagick functions return
508 (Fimagemagick_types): Add `Fnreverse' to return the list in the
511 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
513 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
514 fill background (Bug#8992).
516 2011-12-13 Martin Rudalics <rudalics@gmx.at>
518 * window.c (Vwindow_combination_resize)
519 (Vwindow_combination_limit): Use t instead of non-nil in
521 (Vrecenter_redisplay): Add first sentence of doc-string on
523 (Frecenter): Fix doc-string typo.
525 2011-12-11 Kenichi Handa <handa@m17n.org>
527 * coding.c (Funencodable_char_position): Pay attention to the
528 buffer text relocation (Bug#9389).
530 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
532 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
533 gtk_init (Bug#10100).
535 2011-12-10 Eli Zaretskii <eliz@gnu.org>
537 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
538 IT->string is nil. (Bug#10263)
540 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
542 * nsterm.h (x_free_frame_resources): Declare.
544 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
545 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
547 * nsterm.h (ns_get_defaults_value): Declare.
549 * nsterm.m (ns_default): Call ns_get_defaults_value.
551 2011-12-09 Eli Zaretskii <eliz@gnu.org>
553 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
556 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
558 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
559 that where the value of an _OBJC_* symbol points to is in the .bss
562 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
564 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
565 after the loop to call ccl_driver at least once (Bug#8619).
567 2011-12-08 Kenichi Handa <handa@m17n.org>
569 * ftfont.c (get_adstyle_property): Fix previous change
572 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
574 * w32.c (init_environment): If no_site_lisp, remove site-lisp
575 dirs from the default value of EMACSLOADPATH (bug#10208).
577 2011-12-07 Glenn Morris <rgm@gnu.org>
579 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
580 installation and source directories as well. (Bug#10208)
582 2011-12-06 Chong Yidong <cyd@gnu.org>
584 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
586 2011-12-06 Glenn Morris <rgm@gnu.org>
588 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
589 as an error, not just -1. (Bug#10217)
591 2011-12-05 Chong Yidong <cyd@gnu.org>
593 * keyboard.c (process_special_events): New function.
594 (swallow_events, Finput_pending_p): Use it (Bug#10195).
596 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
598 * coding.c (encode_designation_at_bol): Don't use uninitialized
599 local variable (Bug#9318).
601 2011-12-05 Kenichi Handa <handa@m17n.org>
603 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
604 return Qnil (Bug#8046, Bug#10193).
606 2011-12-05 Kenichi Handa <handa@m17n.org>
608 * coding.c (encode_designation_at_bol): New args charbuf_end and
609 dst. Return the number of produced bytes. Callers changed.
610 (coding_set_source): Return how many bytes coding->source was
612 (coding_set_destination): Return how many bytes
613 coding->destination was relocated.
614 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
615 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
617 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
619 * coding.c (CODING_CHAR_CHARSET_P): New macro.
620 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
623 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
625 The following changes are to fix Bug#9318.
627 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
628 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
629 (encode_coding_iso_2022, encode_coding_sjis)
630 (encode_coding_big5, encode_coding_charset): Use the above macros.
632 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
634 * lisp.h (process_quit_flag): Fix external declaration.
636 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
638 Don't macro-inline non-performance-critical code.
639 * eval.c (process_quit_flag): New function.
640 * lisp.h (QUIT): Use it.
642 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
644 * nsfns.m (get_geometry_from_preferences): New function.
645 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
647 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
649 * emacs.c (Qkill_emacs): Define.
650 (syms_of_emacs): Initialize it.
651 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
652 Qquit_flag to `kill-emacs' instead.
653 (quit_throw_to_read_char): Add parameter `from_signal'.
654 All callers changed. Call Fkill_emacs if requested and safe.
655 * lisp.h (QUIT): Call Fkill_emacs if requested.
657 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
659 * widget.c (update_wm_hints): Return if wmshell is null.
660 (widget_update_wm_size_hints): New function.
662 * widget.h (widget_update_wm_size_hints): Declare.
664 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
665 widget_update_wm_size_hints (Bug#10104).
667 2011-12-03 Eli Zaretskii <eliz@gnu.org>
669 * xdisp.c (handle_invisible_prop): If the invisible text ends just
670 before a newline, prepare the bidi iterator for consuming the
671 newline, and keep the current paragraph direction. (Bug#10183)
672 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
674 2011-12-02 Juri Linkov <juri@jurta.org>
676 * search.c (Fword_search_regexp): New Lisp function created from
677 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
678 (Fword_search_backward, Fword_search_forward)
679 (Fword_search_backward_lax, Fword_search_forward_lax):
680 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
681 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
683 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
685 * fileio.c (Finsert_file_contents): Move after-change-function call
686 to before the "handled:" label, since all "goto handled" appear in
687 cases where the *-change-functions have already been properly called
690 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
692 * keyboard.c (interrupt_signal): Don't call kill-emacs when
693 waiting for input. (Bug#10169)
695 2011-11-30 Eli Zaretskii <eliz@gnu.org>
697 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
698 verifies glyph row's hash code--we have just reallocated the
699 glyphs, so their contents can be complete garbage. (Bug#10164)
701 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
703 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
705 2011-11-30 Eli Zaretskii <eliz@gnu.org>
707 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
708 attributes are tested _before_ calling verify_row_hash, to protect
709 against GCC re-ordering of the tests. (Bug#10164)
711 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
713 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
715 * xterm.c (handle_one_xevent): Only set async_visible and friends
716 if net_wm_state_hidden_seen is non-zero (Bug#10002)
717 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
718 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
720 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
722 Remove GCPRO-related macros that exist only to avoid shadowing locals.
723 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
724 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
725 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
726 All uses changed to use GCPRO1 etc.
727 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
728 Revert to old implementation (i.e., before 2011-03-11).
730 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
732 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
733 of scroll runs so as to avoid assigning disabled bogus rows and
734 unnecessary graphics copy operations.
736 2011-11-27 Eli Zaretskii <eliz@gnu.org>
738 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
739 (snprintf) [_MSC_VER]: Redirect to _snprintf.
740 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
741 (malloc, free, realloc, calloc): Redirect to e_* only when
744 * lisp.h (GCTYPEBITS): Move before first use.
745 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
746 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
747 this macro definition.
749 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
752 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
754 * gtkutil.c (xg_create_frame_widgets):
755 Call gtk_window_set_has_resize_grip (FALSE) if that function is
756 present with Gtk+ 2.0.
758 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
760 * fileio.c (Finsert_file_contents): Undo previous change; see
761 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
763 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
765 Rename locals to avoid shadowing.
766 * fileio.c (Finsert_file_contents):
767 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
768 * process.c (wait_reading_process_output):
769 Rename inner 'proc' to 'p' to avoid shadowing.
770 Indent for consistency with usual Emacs style.
772 2011-11-25 Eli Zaretskii <eliz@gnu.org>
774 * xdisp.c (redisplay_window): If cursor row is not fully visible
775 after recentering, and scroll-conservatively is set to a large
776 number, scroll window by a few more lines to make the cursor fully
777 visible and out of scroll-margin. (Bug#10105)
778 (start_display): Don't move to the next line if the display should
779 start at a newline that is part of a display vector or an overlay
782 2011-11-24 Juri Linkov <juri@jurta.org>
784 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
785 after the `MagickPingImage' call. (Bug#10112)
787 2011-11-23 Chong Yidong <cyd@gnu.org>
789 * window.c (Fcoordinates_in_window_p): Accept only live windows.
791 2011-11-23 Martin Rudalics <rudalics@gmx.at>
793 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
794 making another buffer current. (Bug#10114)
796 2011-11-23 Glenn Morris <rgm@gnu.org>
798 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
800 2011-11-23 Chong Yidong <cyd@gnu.org>
802 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
805 2011-11-22 Eli Zaretskii <eliz@gnu.org>
807 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
808 and header-lines, as they don't have one computed for them.
811 * .gdbinit (prow): Make displayed values more self-explaining.
814 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
816 * process.c (wait_reading_process_output): Fix asynchrounous
817 GnuTLS socket handling on some versions of the GnuTLS library.
818 (wait_reading_process_output): Add comment and URL.
820 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
822 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
824 2011-11-21 Chong Yidong <cyd@gnu.org>
826 * window.c (Fnext_window, Fprevious_window): Doc fix.
828 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
830 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
832 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
834 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
836 2011-11-20 Martin Rudalics <rudalics@gmx.at>
838 * window.c (Fset_window_combination_limit): Rename argument
840 (Vwindow_combination_limit): Remove "status" from doc-string.
842 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
844 * m/ibms390.h: Remove.
845 * m/ibms390x.h: Don't include "ibms390.h".
847 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
849 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
850 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
852 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
854 * casetab.c (Fset_case_table):
855 * charset.c (Fcharset_after): Fix typos.
857 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
859 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
860 Otherwise, valgrind does not work on some platforms.
861 Problem reported by Andreas Schwab in
862 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
863 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
864 is set, removing the need for VIRT_ADDRESS_VARIES.
865 (PURE_P): Use a more-efficient implementation that needs just one
866 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
867 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
868 to 4 (xorl, subq, cmpq, setbe).
869 * alloc.c (pure): Always extern now, since that's the
870 VIRT_ADDR_VARIES behavior.
871 (PURE_POINTER_P): Use a single comparison, not two, for
872 consistency with the new puresize.h.
873 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
874 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
875 Remove VIRT_ADDR_VARIES no longer needed.
877 2011-11-19 Eli Zaretskii <eliz@gnu.org>
879 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
880 (erase_phys_cursor, update_window_cursor, show_mouse_face)
881 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
882 behave as if the cursor position were at the window margin.
884 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
885 and the cursor position is out of bounds, behave as if the cursor
886 position were at the window margin. (Bug#10075)
888 2011-11-18 Chong Yidong <cyd@gnu.org>
890 * window.c (Fwindow_combination_limit): Make first argument
891 non-optional, since it is meaningless for live windows like the
894 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
896 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
898 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
900 * intervals.c: Fix grafting over the whole buffer (bug#10071).
901 (graft_intervals_into_buffer): Simplify.
903 2011-11-18 Eli Zaretskii <eliz@gnu.org>
905 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
906 hash values of the two rows.
907 (copy_row_except_pointers): Preserve the used[] arrays and the
908 hash values of the two rows. (Bug#10035)
909 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
911 * xdisp.c (row_hash): New function, body extracted from
912 compute_line_metrics.
913 (compute_line_metrics): Call row_hash, instead of computing the
916 * dispnew.c (verify_row_hash): Call row_hash for computing the
917 hash code of a row, instead of duplicating code from xdisp.c.
919 * dispextern.h (row_hash): Add prototype.
921 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
923 * frame.c (delete_frame): Don't delete the terminal when the last
924 X frame is closed if emacs is built with GTK toolkit.
926 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
928 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
930 2011-11-17 Martin Rudalics <rudalics@gmx.at>
932 * window.c (Vwindow_splits): Rename to
933 Vwindow_combination_resize. Suggested by Juri Linkov.
934 (Fsplit_window_internal): Use Vwindow_combination_resize instead
937 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
939 * nsfns.m (Fns_font_name):
940 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
942 2011-11-16 Martin Rudalics <rudalics@gmx.at>
944 * window.h (window): Rename slot "nest" to "combination_limit".
945 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
946 (Fset_window_nest): Rename to Fset_window_combination_limit.
947 (Vwindow_nest): Rename to Vwindow_combination_limit.
948 (recombine_windows, make_parent_window, make_window)
949 (Fsplit_window_internal, saved_window)
950 (Fset_window_configuration, save_window_save): Rename all
951 occurrences of window_nest to window_combination_limit.
953 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
955 * image.c (imagemagick_load_image): Fix typo.
957 2011-11-14 Eli Zaretskii <eliz@gnu.org>
959 * xdisp.c (display_line): Move the call to
960 highlight_trailing_whitespace before the call to
961 compute_line_metrics, since the latter needs to see the final
962 faces of all the glyphs to compute ROW's hash value.
963 Fixes assertion violations in row_equal_p. (Bug#10035)
965 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
967 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
968 just return (bug#10044).
970 2011-11-12 Eli Zaretskii <eliz@gnu.org>
972 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
973 with user-defined heap size. Bump the default size of the temacs
974 heap to 27MB, to avoid memory warning when running temacs.
975 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
977 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
978 current_matrix and desired_matrix. (Bug#9990)
979 (verify_row_hash) [XASSERTS]: New function.
980 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
981 that the hash value of glyph rows is correct.
983 2011-11-12 Martin Rudalics <rudalics@gmx.at>
985 * window.h (window): Remove splits slot.
986 * window.c (Fwindow_splits, Fset_window_splits): Remove.
987 (Fdelete_other_windows_internal, make_parent_window)
988 (make_window, Fsplit_window_internal, Fdelete_window_internal)
989 (Fset_window_configuration, save_window_save): Don't deal with
990 split status of windows.
991 (saved_window): Remove splits slot.
992 (Vwindow_splits): Rewrite doc-string.
994 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
996 * xfns.c (unwind_create_frame):
997 * nsfns.m (unwind_create_frame):
998 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
999 Vframe_list (Bug#9999).
1001 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1003 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1005 2011-11-11 Kenichi Handa <handa@m17n.org>
1007 * callproc.c (Fcall_process): Set the member dst_multibyte of
1010 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1012 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1013 avoid a crash (bug#9496).
1015 2011-11-09 Chong Yidong <cyd@gnu.org>
1017 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1018 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1020 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1022 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1024 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1026 Avoid some portability problems by eschewing 'extern inline' functions.
1027 The trivial performance wins aren't worth the portability hassles; see
1028 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1030 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1031 (window_box_width, window_box_left, window_box_left_offset)
1032 (window_box_right, window_box_right_offset): Undo previous change,
1033 by removing the "extern"s.
1034 * intervals.c (adjust_intervals_for_insertion)
1035 (adjust_intervals_for_deletion): Undo previous change,
1036 making these static again.
1037 (offset_intervals, temp_set_point_both, temp_set_point)
1038 (copy_intervals_to_string): No longer inline.
1039 * xdisp.c (window_text_bottom_y, window_box_width)
1040 (window_box_height, window_box_left_offset)
1041 (window_box_right_offset, window_box_left, window_box_right)
1042 (window_box): No longer inline.
1044 2011-11-08 Chong Yidong <cyd@gnu.org>
1046 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1047 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1048 Signal an error if not a live window.
1049 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1050 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1052 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1054 * lisp.h (syms_of_abbrev): Remove declaration.
1055 Reported by CHENG Gao <chenggao@royau.me>.
1057 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1059 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1060 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1061 of temacs in GUI mode.
1063 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1065 * window.h: Declare delete_all_child_windows instead of
1066 delete_all_subwindows.
1067 * window.c (Fwindow_nest, Fset_window_nest)
1068 (Fset_window_new_total, Fset_window_new_normal)
1069 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1070 (delete_all_subwindows): Rename to delete_all_child_windows.
1071 (Fdelete_other_windows_internal, Fset_window_configuration):
1072 Call delete_all_child_windows instead of delete_all_subwindows.
1073 * frame.c (delete_frame): Call delete_all_child_windows instead
1074 of delete_all_subwindows.
1076 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1078 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1079 This is also needed for porting to any host where GC_MARK_STACK is
1080 not GC_MAKE_GCPROS_NOOPS.
1081 (which_symbols): Use it.
1083 2011-11-07 Kenichi Handa <handa@m17n.org>
1085 * coding.c (coding_set_destination): Check coding->src_pos only
1086 when coding->src_object is a buffer (bug#9910).
1088 * process.c (send_process): Set the member src_multibyte of coding
1089 to 0 (bug#9911) when sending a unibyte text.
1091 * callproc.c (Fcall_process): Set the member src_multibyte of
1092 process_coding to 0 (bug#9912).
1094 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1096 * xmenu.c (cleanup_widget_value_tree): New function.
1097 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1098 calling free_menubar_widget_value_tree directly (Bug#9830).
1100 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1102 Fix some portability problems with 'inline'.
1103 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1104 (window_box_width, window_box_left, window_box_left_offset)
1105 (window_box_right, window_box_right_offset): Declare extern.
1106 Otherwise, these inline functions do not conform to C99 and
1107 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1108 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1109 * intervals.c (adjust_intervals_for_insertion)
1110 (adjust_intervals_for_deletion): Now extern, because otherwise the
1111 extern inline functions 'offset_intervals' couldn't refer to it.
1112 (static_offset_intervals): Remove.
1113 (offset_intervals): Rewrite using the old contents of
1114 static_offset_intervals. The old version didn't conform to C99
1115 because an extern inline function contained a reference to an
1116 identifier with static linkage.
1118 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1120 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1123 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1125 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1126 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1127 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1128 return Qleft_to_right.
1130 2011-11-06 Chong Yidong <cyd@gnu.org>
1132 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1133 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1134 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1135 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1136 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1137 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1138 (Fwindow_vscroll): Doc fix.
1139 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1140 argument, since it makes no sense to pass a live window and for
1141 consistency with window-child.
1143 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1145 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1148 2011-11-05 Jason Rumney <jasonr@gnu.org>
1150 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1151 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1153 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1154 bitwise arithmetic preventing use of unicode-sip and non-truetype
1157 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1159 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1162 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1163 initialization code to keep similarity to xfns.c after changes
1166 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1168 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1169 (unwind_create_frame): New function (Bug#9943).
1170 (Fx_create_frame): Restructure code to be more similar to the one in
1171 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1172 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1173 Move terminal->reference_count++ just before making the frame official
1176 * nsterm.m (x_free_frame_resources): New function.
1177 (x_destroy_window): Move code to x_free_frame_resources.
1179 * xfns.c (unwind_create_frame): Fix comment.
1180 (Fx_create_frame, x_create_tip_frame):
1181 Move terminal->reference_count++ just before making the frame
1182 official. Move initialization of image_cache_refcount and
1183 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1185 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1187 Support MSVC build with newer versions of Visual Studio.
1188 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1189 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1192 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1193 which are not supported by MSVC.
1194 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1195 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1197 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1199 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1201 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1203 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1205 Support MSVC build with newer versions of Visual Studio.
1206 * w32.c: Don't include w32api.h for MSVC.
1207 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1209 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1210 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1211 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1212 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1214 (alloca) [_MSC_VER]: Define to _alloca.
1216 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1218 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1220 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1222 * xdisp.c (note_mouse_highlight): If either of
1223 previous/next-single-property-change returns nil, treat that as
1224 the beginning or the end of the buffer. (Bug#9955)
1226 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1228 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1229 label is not null (Bug#9951).
1230 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1233 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1235 * window.c (Fwindow_body_size): Mention in the doc string that the
1236 return value is in frame's canonical units. (Bug#9949)
1238 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1240 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1242 * w32fns.c (unwind_create_frame): If needed, free the glyph
1243 matrices of the partially constructed frame. (Bug#9943)
1244 * xfns.c (unwind_create_frame): Likewise.
1246 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1248 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1249 Don't stop backward scan on the continuation glyph, even though
1250 its CHARPOS is positive.
1251 (mouse_face_from_buffer_pos, note_mouse_highlight):
1252 Rename cover_string to disp_string.
1254 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1256 * window.c (temp_output_buffer_show): Don't use
1257 Vtemp_buffer_show_specifiers.
1258 (Vtemp_buffer_show_specifiers): Remove unused variable.
1260 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1262 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1263 past the beginning of the current glyph matrix.
1265 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1267 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1268 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1269 HAVE_GTK3 (Bug#9869).
1271 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1272 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1274 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1276 * xterm.c: Declare x_handle_net_wm_state to return int.
1277 (handle_one_xevent): Check if we are iconified but don't have
1278 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1279 (get_current_wm_state): Return non-zero if not hidden,
1280 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1281 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1282 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1283 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1285 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1287 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1288 so that this new function doesn't get optimized away by a
1289 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1291 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1293 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1295 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1297 Fix the `xbytecode' command.
1298 * .gdbinit (xprintbytestr): New command.
1299 (xwhichsymbols): Rename from `which'; all callers changed.
1300 (xbytecode): Print the byte-code string as well.
1302 2011-10-29 Kim Storm <storm@cua.dk>
1304 * alloc.c (which_symbols): New function.
1306 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1308 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1311 2011-10-29 Glenn Morris <rgm@gnu.org>
1313 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1314 Not clear what it was for, and it causes various bugs. (Bug#9839)
1316 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1318 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1319 possible random value that matches one of those tested as
1320 condition to clear the mouse face.
1322 2011-10-28 Chong Yidong <cyd@gnu.org>
1324 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1326 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1328 * window.c (make_window): Initialize phys_cursor_on_p.
1330 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1332 * lisp.h (struct Lisp_Symbol): Update comments.
1334 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1336 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1338 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1340 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1341 <oslsachem@gmail.com> for helping to debug this.
1343 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1344 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1345 (g_b_init_get_glyph_outline_w): New static variables.
1346 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1347 (GetGlyphOutlineW_Proc): New typedefs.
1348 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1349 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1351 (w32font_open_internal, compute_metrics):
1352 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1353 instead of calling the "wide" APIs directly.
1355 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1357 * w32.h (syms_of_w32font): Add prototype.
1359 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1361 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1362 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1363 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1364 (Fmove_to_window_line): Doc fix.
1366 2011-10-27 Chong Yidong <cyd@gnu.org>
1368 * process.c (make_process): Set gnutls_state to NULL.
1370 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1371 non-NULL, regardless of GNUTLS_INITSTAGE.
1372 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1373 an error. Set process slots as soon as we allocate them.
1375 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1377 2011-10-27 Chong Yidong <cyd@gnu.org>
1379 * gnutls.c (emacs_gnutls_deinit): New function.
1380 Deallocate credentials structures as well as calling gnutls_deinit.
1381 (Fgnutls_deinit, Fgnutls_boot): Use it.
1383 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1384 (deactivate_process): Call emacs_gnutls_deinit.
1386 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1388 * image.c (x_create_x_image_and_pixmap):
1389 * w32.c (sys_rename, w32_delayed_load):
1390 * w32font.c (fill_in_logfont):
1391 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1393 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1395 * w32fns.c (w32_default_color_map): New function,
1396 extracted from Fw32_default_color_map.
1397 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1399 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1401 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1403 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1405 * keyboard.c (test_undefined): New function (bug#9751).
1406 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1408 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1410 * sysdep.c (init_sys_modes): Fix the check for the controlling
1411 terminal (Bug#6649).
1413 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1415 * dispextern.h (struct bidi_it): New member next_en_type.
1417 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1418 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1419 current character, check also for next_en_type being WEAK_EN.
1420 (bidi_resolve_weak): Don't enter the expensive loop if the current
1421 position is before next_en_pos. Record the bidi type of the first
1422 non-ET, non-BN character we find, in addition to its position.
1423 (bidi_level_of_next_char): Invalidate next_en_type when
1424 next_en_pos is over-stepped.
1426 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1428 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1429 * editfns.c: Rewrite current-time-zone so that it invokes
1430 the equivalent of (format-time-string "%Z") to get the time zone name.
1431 This fixes a bug when the time zone name contains characters that
1432 need converting from the system time locale to Emacs internal format.
1433 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1434 that patch fixed format-time-string to do the conversion, but
1435 I forgot to fix current-time-zone.
1436 (format_time_string): New function, containing most of
1437 what Fformat_time_string used to contain.
1438 (Fformat_time_string): Rewrite in terms of format_time_string.
1439 This doesn't change this function's behavior.
1440 (current-time-zone): Rewrite to use format_time_string.
1441 This fixes the bug reported by Michael Schierl in
1442 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1443 Jason Rumney's 2007-06-07 change worked around this bug, but
1445 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1447 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1449 * xdisp.c (start_display): If the character at POS is displayed
1450 via a display vector, reset IT->current.dpvec_index to zero.
1451 (try_window_reusing_current_matrix): If a line ends in a display
1452 vector or the next line starts in a display vector, continue
1453 redrawing the window even though the character position of
1454 start_row was reached.
1457 2011-10-18 Chong Yidong <cyd@gnu.org>
1459 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1460 with nobreak-char-display too.
1462 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1464 Fix part 3 of bug#9771.
1465 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1466 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1467 non-neutral characters if the current character is a paragraph
1468 separator (a.k.a. Newline). This avoids running the same
1469 expensive loop twice, once when we consume the preceding newline
1470 and the other time when the line actually needs to be displayed.
1471 Avoid the loop when we see neutrals on the base embedding level
1472 following a character whose directionality is the same as the
1473 paragraph's. This avoids running the expensive loop when a line
1474 ends in a long sequence of neutrals, like control characters.
1475 Add assertion against STRONG_AL type. Slightly rearrange code
1476 that determines the type of a neutral given the first non-neutral
1478 (bidi_level_of_next_char): Set next_en_pos to zero when
1479 invalidating its info.
1481 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1483 * xdisp.c (push_display_prop): Determine whether to record string
1484 or buffer position by IT->string, not by IT->method. Allow
1485 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1486 (move_it_vertically_backward): Don't look for character position
1487 immediately after the newline when in a continuation line.
1490 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1492 * window.c (coordinates_in_window): Rewrite and delabelize
1493 vertical border check. (Bug#5357) (Bug#9618)
1495 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1497 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1498 errors in XSetWindowBorder (bug#9310).
1500 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1502 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1503 avoid crash when xmalloc overrun checking is enabled.
1505 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1507 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1508 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1509 cursor motion with <left> and <right> arrow keys.
1511 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1512 some callers set that themselves.
1514 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1516 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1517 display string and the previous row comes from the same string and
1518 is empty. (Bug#9739) (Bug#9738)
1520 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1522 * doc.c (get_doc_string): Encode file name (bug#9735).
1524 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1526 * bidi.c (bidi_level_of_next_char):
1527 * xdisp.c (get_visually_first_element): Remove old incorrect
1528 comments regarding the Unicode Line Separator character.
1530 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1532 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1534 * alloc.c (Fgc_status): Do not access beyond zombies array
1535 boundary if nzombies > MAX_ZOMBIES.
1536 * alloc.c (dump_zombies): Add missing format specifier.
1538 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1540 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1541 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1543 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1544 Some packages use them to denote characters with modifiers.
1546 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1548 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1549 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1550 matching a pp-number. Rename parameter var to var1.
1552 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1554 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1556 2011-10-08 Glenn Morris <rgm@gnu.org>
1558 * callint.c (Fcall_interactively): Give a more explicit error for the
1559 'c' case with a non-character input. (Bug#8479)
1561 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1563 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1565 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1566 lines that are hscrolled on the left.
1568 * dispnew.c (buffer_posn_from_coords): Account for a possible
1569 presence of header-line. (Bug#4426)
1571 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1573 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1574 Don't advertise functionality which we discourage or doesn't work.
1576 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1578 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1579 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1580 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1581 this makes Emacs dump core during garbage collection on rare
1582 occasions. sizeof is obviously inferior to offsetof here, so
1583 stick with offsetof.
1584 (GC_POINTER_ALIGNMENT): New macro.
1585 (mark_memory): Omit 3rd (offset) arg; caller changed.
1586 Don't assume EMACS_INT alignment is the same as pointer alignment.
1588 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1590 * keyboard.c (read_key_sequence_remapped): New var.
1591 (read_key_sequence): Compute remapping in the right buffer.
1592 (command_loop_1): Use read_key_sequence's remapping directly.
1594 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1596 * dired.c (file_name_completion): Don't expand file name.
1597 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1598 before checking file name handler.
1600 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1601 they've been requested explicitly (bug#9591).
1603 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1605 * keymap.c (Fsingle_key_description): Use make_specified_string
1606 instead of build_string to build string from push_key_description.
1609 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1611 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1612 This fixes a Y2038 bug on 64-bit hosts.
1613 * buffer.c (reset_buffer):
1614 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1615 (Fclear_buffer_auto_save_failure):
1616 Use 0, not -1, to represent an unset failure time, since time_t
1617 might not be signed.
1619 Remove dependency on glibc malloc internals.
1620 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1621 Move back here from lisp.h, but with their new implementations.
1622 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1623 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1624 * charset.c (charset_table_init): New static var.
1625 (syms_of_charset): Use it instead of xmalloc. This removes a
1626 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1627 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1628 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1629 Move back to alloc.c.
1630 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1631 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1633 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1635 * nsterm.m (windowDidResize): Call x_set_window_size only when
1636 ns_in_resize is true. Otherwise set pixelwidth/height and
1637 call change_frame_size (Bug#9628).
1639 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1641 Port --enable-checking=all to Fedora 14 x86-64.
1642 * charset.c (syms_of_charset): Also account for glibc malloc's
1643 internal overhead when calculating the initial malloc maximum.
1645 Port --enable-checking=all to Fedora 14 x86.
1646 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1648 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1649 (overrun_check_realloc, overrun_check_free):
1650 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1651 That way, xmalloc returns a properly-aligned pointer even if
1652 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1653 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1654 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1655 into account when calculating the initial malloc maximum.
1656 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1657 Move here from alloc.c, so that charset.c can use it too.
1658 Properly align; the old code wasn't right for common 32-bit hosts
1659 when configured with --enable-checking=all.
1660 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1661 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1663 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1665 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1668 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1670 * xdisp.c (compute_display_string_end): If there's no display
1671 string at CHARPOS, return -1.
1673 * bidi.c (bidi_fetch_char): When compute_display_string_end
1674 returns a negative value, treat the character as a normal
1675 character not covered by a display string. (Bug#9624)
1677 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1679 * lread.c (Fread_from_string): Fix typo in docstring.
1681 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1683 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1684 newline, reseat the iterator instead of bidi-iterating there one
1685 character at a time. (Bug#9610)
1686 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1687 TO_CHARPOS if the bidi iterator is at base embedding level.
1689 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1691 * lread.c (readevalloop): Use correct code for NBSP.
1692 (read1): Likewise. (Bug#9608)
1694 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1696 * dbusbind.c (Fdbus_register_signal): When service is not
1697 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1699 2011-09-25 Glenn Morris <rgm@gnu.org>
1701 * buffer.c (truncate-lines): Doc fix.
1703 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1705 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1706 (Fset_window_next_buffers): Doc fix.
1708 2011-09-24 Glenn Morris <rgm@gnu.org>
1710 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1712 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1714 Fix minor problems found by static checking.
1715 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1716 * indent.c (Fvertical_motion): Fix == vs = typo.
1718 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1720 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1721 Default value is now t. Doc fix.
1723 * indent.c (Fvertical_motion): Compute and apply the overshoot
1724 logic when moving up, not only when moving down. Fix the
1725 confusing name and values of the it_overshoot_expected variable;
1726 logic changes accordingly. (Bug#9254) (Bug#9549)
1728 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1729 CHARPOS is covered by a display string which includes newlines.
1730 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1731 is covered by a display string with embedded newlines.
1733 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1735 * dbusbind.c (Fdbus_register_signal): Add match rule to
1736 Vdbus_registered_objects_table. (Bug#9581)
1737 (Fdbus_register_method, Vdbus_registered_objects_table):
1740 2011-09-24 Jim Meyering <meyering@redhat.com>
1742 do not ignore write error for any output size
1743 The previous change was incomplete.
1744 While it makes emacs --batch detect the vast majority of stdout
1745 write failures, errors were still ignored whenever the output size is
1746 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1747 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1748 && echo FAIL: ignored write error
1749 FAIL: ignored write error
1750 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1751 && echo FAIL: ignored write error
1752 FAIL: ignored write error
1753 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1755 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1757 * emacs.c (Fkill_emacs): In noninteractive mode exit
1758 non-successfully if a write error occurred on stdout. (Bug#9574)
1760 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1762 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1765 * dispextern.h (struct it): Update the comment documenting what
1768 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1770 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1771 a display string, extend search for cursor position to end of row.
1772 (find_row_edges): If the row ends in a newline from a display
1773 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1774 Handle the case of a display string with multiple newlines.
1775 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1776 non-empty line. Fixes confusing cursor motion with arrow keys at
1777 the beginning of a line that starts with whitespace.
1779 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1781 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1784 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1786 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1789 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1791 * xdisp.c (display_line): Record maximum and minimum buffer
1792 positions even if no glyphs were produced (e.g., by a zero-width
1793 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1794 buffer positions that will be removed from the glyph row because
1796 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1797 column is beyond frame width: don't subtract 1 "pixel" when
1798 computing width of the stretch.
1799 (reseat_at_next_visible_line_start): Undo the change made on
1800 2011-09-17 that saved paragraph information and restored it after
1801 the call to `reseat'. (Bug#9545)
1803 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1805 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1806 and turn window cursor on if cleared (Bug#9415).
1808 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1810 * search.c (boyer_moore): Take unibyte characters from pattern
1811 literally. (Bug#9458)
1813 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1815 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1817 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1819 Fix minor problem found by static checking.
1820 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1821 initialized, to pacify gcc -Wuninitialized.
1823 * fileio.c: Report proper errno when syscall falls.
1824 (Finsert_file_contents): Save and restore errno,
1825 so that report_file_error outputs the correct diagnostic.
1826 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1828 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1830 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1832 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1834 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1835 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1837 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1839 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1840 about the current paragraph and restore it after the call to reseat.
1842 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1843 (bidi_find_paragraph_start): Search back for paragraph beginning
1844 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1845 (bidi_move_to_visually_next): Only trigger paragraph-related
1846 computations when the last character is a newline or at EOB, not
1847 just any NEUTRAL_B. (Bug#9470)
1849 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1850 truncated lines if point is covered by a display string. (Bug#9524)
1852 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1854 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1855 (cons_to_x_long): New function.
1856 (lisp_data_to_selection_data): Use it. Correct the test for
1857 short-versus-long data; it was negated. Break out of vector
1858 loop, for efficiency, when a long datum is discovered.
1860 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1862 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1864 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1866 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1867 GCC PR/17406) by declaring this function with external scope.
1869 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1871 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1872 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1874 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1876 * editfns.c (Fformat): Correctly handle text properties on "%%".
1878 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1880 * xterm.c (x_draw_composite_glyph_string_foreground):
1881 * w32term.c (x_draw_composite_glyph_string_foreground):
1882 * term.c (encode_terminal_code):
1883 * composite.c (composition_update_it, get_composition_id):
1884 * xdisp.c (get_next_display_element)
1885 (fill_composite_glyph_string): Add comments about special meaning
1886 of TAB characters in a composition.
1888 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1890 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1891 This occurs when processing a multibyte format.
1892 Problem reported by Wolfgang Jenker.
1894 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1896 * xdisp.c (try_cursor_movement): Only check for exact match if
1897 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1899 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1901 Remove unused external symbols.
1902 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1903 * xdisp.c (calc_pixel_width_or_height): Now static.
1904 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1905 * indent.c (check_display_width):
1906 * w32term.c: Fix comment to match code.
1907 * xterm.c, xterm.h (x_catching_errors): Remove.
1909 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1911 * xselect.c: Use signed conversions more consistently (Bug#9498).
1912 (selection_data_to_lisp_data): Assume incoming selection data are
1913 signed integers, not unsigned. This is to be consistent with
1914 outgoing selection data, which was modified to use signed integers
1915 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1916 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1917 expects long, not unsigned long.
1919 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1921 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1922 computation of loop end. Reported by Johan Bockgård
1925 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1927 * frame.c (Fother_visible_frames_p): Function deleted.
1929 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1931 * indent.c (compute_motion): Process display vector front to back
1932 rather than the other way around. (Bug#2496)
1934 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1936 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1938 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1940 * minibuf.c (Fread_from_minibuffer): Doc fix.
1942 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1944 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1945 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1947 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1949 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1950 value for non-existent files.
1952 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1954 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1955 set its "size" to -1. This will set the modtime_size field of
1956 the corresponding buffer to -1, which is what
1957 verify-visited-file-modtime expects for files that do not exist.
1960 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1962 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1964 * lisp.h: ... from here. push_key_description is no longer
1965 defined in keyboard.c, so its declaration should not be in
1966 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1967 logically belongs with push_key_description.
1969 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1971 * buffer.h: Include <sys/types.h> instead of <time.h>.
1972 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1973 Problem reported by Herbert J. Skuhra.
1975 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1977 * xml.c (parse_region): Make the parsing work for
1978 non-comment-starting XML files again (bug#9144).
1980 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1982 * image.c (gif_load): Fix calculation of bottom and right corner.
1985 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1987 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1988 redisplay in small windows.
1990 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1992 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1994 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1996 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1997 Operate on live windows only.
1999 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2001 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2003 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2005 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2006 only under bidi iteration.
2008 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2010 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2012 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2014 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2015 Without this fix, the command to link temacs failed due to an
2016 undefined symbol __builtin_isnan. This is because
2017 /usr/include/iso/math_c99.h #defines isnan(x) to
2018 __builtin_isnan(x), but the bundled gcc, which identifies itself
2019 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2021 * floatfns.c (isnan): #undef, and then #define to a clone of
2023 (Fisnan): Always define, since it's always available now.
2024 (syms_of_floatfns): Always define isnan at the Lisp level.
2026 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2028 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2030 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2032 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2033 The previous code assumed that file offsets (off_t values) fit in
2034 EMACS_INT variables, which is not true on typical 32-bit hosts.
2035 The code messed up by falsely reporting buffer overflow in cases
2036 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2037 when "big" contains more than 2**29 bytes, even though this
2038 inserts just one byte and does not overflow the buffer.
2039 (Finsert_file_contents): Store file offsets as off_t
2040 values, not as EMACS_INT values. Check for overflow when
2041 converting between EMACS_INT and off_t. When checking for
2042 buffer overflow or for overlap, take the offsets into account.
2043 Don't use EMACS_INT for small values where int suffices.
2044 When checking for overlap, fix a typo: ZV was used where
2045 ZV_BYTE was intended.
2046 (Fwrite_region): Don't assume off_t fits into 'long'.
2047 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2049 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2051 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2053 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2055 sprintf-related integer and memory overflow issues (Bug#9412).
2057 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2058 (esprintf, exprintf, evxprintf): New functions.
2059 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2060 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2061 (modify_event_symbol): Do not assume that the length of
2062 name_alist_or_stem is safe to alloca and fits in int.
2063 (Fexecute_extended_command): Likewise for function name and binding.
2064 (Frecursion_depth): Wrap around reliably on integer overflow.
2065 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2066 since some callers pass EMACS_INT values.
2067 (Fsingle_key_description): Don't crash if symbol name contains more
2068 than MAX_ALLOCA bytes.
2069 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2070 (get_minibuffer): Arg is now EMACS_INT, not int.
2071 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2072 (esprintf, exprintf, evxprintf): New decls.
2073 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2075 * dbusbind.c (signature_cat): New function.
2076 (xd_signature, Fdbus_register_signal):
2077 Do not overrun buffer; instead, report string overflow.
2079 * dispnew.c (add_window_display_history): Don't overrun buffer.
2080 Truncate instead; this is OK since it's just a log.
2082 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2083 even if the time zone offset is outlandishly large.
2084 Don't mishandle offset == INT_MIN.
2086 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2087 when creating daemon; the previous buffer-overflow check was incorrect.
2089 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2090 which has the guts of the old verror function.
2092 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2093 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2095 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2096 (font_unparse_xlfd): Don't blindly alloca long strings.
2097 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2098 fits in int, when using sprintf. Use single snprintf to count
2099 length of string rather than counting it via multiple sprintfs;
2100 that's simpler and more reliable.
2101 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2102 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2103 sprintf, in case result does not fit in int.
2105 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2106 (fontset_from_font): Print it.
2108 * frame.c (tty_frame_count): Now printmax_t, not int.
2109 (make_terminal_frame, set_term_frame_name): Print it.
2110 (x_report_frame_params): In X, window IDs are unsigned long,
2111 not signed long, so print them as unsigned.
2112 (validate_x_resource_name): Check for implausibly long names,
2113 and don't assume name length fits in 'int'.
2114 (x_get_resource_string): Don't blindly alloca invocation name;
2115 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2118 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2119 (xg_check_special_colors, xg_set_geometry):
2120 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2122 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2123 Use esprintf, not sprintf, in case result does not fit in int.
2125 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2126 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2127 it as a large positive number.
2128 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2129 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2131 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2132 in case result does not fit in int.
2134 * print.c (float_to_string): Detect width overflow more reliably.
2135 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2136 buffer overrun. Don't assume list length fits in 'int'. Treat
2137 print length of 0 as 0, not as infinity; to be consistent with other
2138 uses of print length in this function. Don't overflow print length
2139 index. Don't assume hash table size fits in 'long', or that
2140 vectorlike size fits in 'unsigned long'.
2142 * process.c (make_process): Use printmax_t, not int, to format
2143 process-name gensyms.
2145 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2147 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2148 to avoid potential buffer overrun.
2150 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2151 if X resource line is longer than 512 bytes.
2153 * xfns.c (x_window): Make sprintf buffer a bit bigger
2154 to avoid potential buffer overrun.
2156 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2158 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2160 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2162 Integer overflow fixes for scrolling, etc.
2163 Without these, Emacs silently mishandles large integers sometimes.
2164 For example, "C-u 4294967297 M-x recenter" was treated as if
2165 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2167 * xdisp.c (try_window_id): Check Emacs fixnum range before
2168 converting to 'int'.
2170 * window.c (window_scroll_line_based, Frecenter):
2171 Check that an Emacs fixnum is in range before assigning it to 'int'.
2172 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2173 values converted from Emacs fixnums.
2174 (Frecenter): Don't wrap around a line count if it is out of 'int'
2175 range; instead, treat it as an extreme value.
2176 (Fset_window_configuration, compare_window_configurations):
2177 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2179 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2180 that can exceed INT_MAX. Check that EMACS_INT value is in range
2181 before assigning it to the (possibly-narrower) index.
2182 (match_limit): Don't assume that a fixnum can fit in 'int'.
2184 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2187 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2188 (Fvertical_motion): Don't wrap around LINES values that don't fit
2189 in 'int'. Instead, treat them as extreme values. This is good
2190 enough for windows, which can't have more than INT_MAX lines anyway.
2192 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2194 * Require libxml/parser.h to avoid compilation warning.
2196 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2198 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2199 since this reportedly can destroy thread storage.
2201 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2203 * syntax.c (find_defun_start): Update all cache variables if
2204 exiting early (Bug#9401).
2206 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2208 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2210 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2211 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2212 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2214 * term.c (tty_append_glyph): New function.
2215 (produce_stretch_glyph): Static function and its prototype deleted.
2217 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2220 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2222 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2223 when checking :margin (Bug#9390).
2224 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2225 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2226 so that the name doesn't mislead. All uses changed.
2228 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2230 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2233 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2235 * xdisp.c (move_it_to): Don't bail out early when reaching
2236 position beyond to_charpos, if we are scanning backwards.
2237 (move_it_vertically_backward): When DY == 0, make sure we get to
2238 the first character in the line after the newline.
2240 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2242 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2243 (ccl_driver): Do not generate an out-of-range pointer.
2244 (Fccl_execute_on_string): Remove unnecessary check for
2245 integer overflow, noted by Stefan Monnier in
2246 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2247 Remove a FIXME that didn't need fixing.
2248 Simplify the newly-introduced buffer reallocation code.
2250 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2252 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2254 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2256 Integer and memory overflow issues (Bug#9196).
2258 * doc.c (get_doc_string): Rework so that
2259 get_doc_string_buffer_size is the actual buffer size, rather than
2260 being 1 less than the actual buffer size; this makes xpalloc more
2263 * image.c (x_allocate_bitmap_record, cache_image):
2264 * xselect.c (Fx_register_dnd_atom):
2265 Simplify previous changes by using xpalloc.
2267 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2268 since either will do and ptrdiff_t is convenient with xpalloc.
2270 * charset.c (charset_table_size)
2271 (struct charset_sort_data.priority): Now ptrdiff_t.
2272 (charset_compare): Don't overflow if priorities differ greatly.
2273 (Fsort_charsets): Don't assume list length fits in int.
2274 Check for size-calculation overflow when allocating sort data.
2275 (syms_of_charset): Allocate an initial charset table that is
2276 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2278 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2280 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2281 The actual value is always <= INT_MAX, and leaving it unsigned made
2282 overflow checking harder.
2284 * dispextern.h (struct glyph_matrix.rows_allocated)
2285 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2286 with xpalloc. The values are still always <= INT_MAX.
2288 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2290 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2291 (SAFE_NALLOCA): New macro.
2293 * region-cache.c (struct boundary.pos, find_cache_boundary)
2294 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2295 (set_cache_region, invalidate_region_cache)
2296 (revalidate_region_cache, know_region_cache, region_cache_forward)
2297 (region_cache_backward, pp_cache):
2298 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2299 so that ptrdiff_t * can be passed to xpalloc.
2300 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2301 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2302 (pp_cache): Don't assume cache_len fits in int.
2303 * region-cache.h: Adjust extern decls to match.
2305 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2306 EMACS_INT, since either will do, for xpalloc.
2308 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2309 (xnmalloc, xnrealloc, xpalloc): New functions.
2311 * bidi.c (bidi_shelve_header_size): New constant.
2312 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2313 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2315 * bidi.c (bidi_cache_shrink):
2316 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2318 Don't update size of array until after memory allocation succeeds,
2319 because xmalloc/xrealloc may not return.
2320 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2321 now that we have proper integer overflow checking.
2322 (record_overlay_string, overlay_strings): Catch overflows when
2323 calculating size of overlay_str_buf.
2325 * callproc.c (Fcall_process): Check for size overflow when
2326 calculating size of args2.
2327 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2328 Normally we prefer signed values, but sticking with ptrdiff_t would
2329 require adding more-complicated checks.
2331 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2332 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2333 Redo buffer-overflow calculations to avoid integer overflow.
2334 Add a FIXME comment where memory seems to be over-allocated.
2336 * character.c (Fstring): Check for size-calculation overflow.
2338 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2339 unnecessary integer overflow. Check for size overflow.
2340 (encode_coding_object): Don't update size until xmalloc succeeds.
2342 * composite.c (get_composition_id): Check for overflow in glyph
2343 length calculations.
2345 Integer and memory overflow fixes for display code.
2346 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2347 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2348 (scrolling_window): Check for overflow in size calculations.
2349 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2350 Don't assume glyph table len fits in int.
2351 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2352 (row_table_size): Now ptrdiff_t, not int.
2353 (scrolling_window): Avoid overflow in size calculations.
2354 Don't update size until allocation succeeds.
2355 * fns.c (concat): Check for overflow in size calculations.
2356 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2357 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2358 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2360 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2361 (get_doc_string): Check for size calculation overflow.
2362 Don't update size until allocation succeeds.
2363 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2364 EMACS_INT, where ptrdiff_t will do.
2365 (Fsubstitute_command_keys): Check for string overflow.
2367 * editfns.c (set_time_zone_rule): Don't assume environment length
2369 (message_length): Now ptrdiff_t, not int.
2370 (Fmessage_box): Don't update size until allocation succeeds.
2371 Don't assume message length fits in int.
2372 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2374 * emacs.c (main): Do not reallocate argv, since there is a null at
2375 the end that can be overwritten, and this way there's no need to
2376 worry about size-calculation overflow.
2377 (sort_args): Check for size-calculation overflow.
2379 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2381 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2383 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2384 (x_set_scroll_bar_width, x_figure_window_size):
2385 Check for integer overflow.
2386 (x_set_alpha): Do not assume XINT fits in int.
2388 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2389 This is for the members text_lines, text_cols, total_lines, total_cols,
2390 where the system imposes an 'int' limit.
2392 * fringe.c (Fdefine_fringe_bitmap):
2393 Don't update size until alloc works.
2395 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2396 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2398 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2399 Check for size-calculation overflow.
2400 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2401 do, as we prefer signed integers.
2402 (id_to_widget.max_size, id_to_widget.used)
2403 (xg_store_widget_in_map, xg_remove_widget_from_map)
2404 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2405 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2406 Use and return ptrdiff_t, not int.
2407 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2408 * gtkutil.h: Change prototypes to match the above.
2410 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2411 are duplicate now that they've been promoted to lisp.h.
2412 (x_allocate_bitmap_record, x_alloc_image_color)
2413 (make_image_cache, cache_image, xpm_load):
2414 Don't update size until alloc is done.
2415 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2417 Check for size calculation overflow.
2418 (ct_colors_allocated_max): New constant.
2419 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2422 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2423 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2424 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2425 Use ptrdiff_t, not int, to count maps.
2426 (read_char_minibuf_menu_prompt): Check for overflow in size
2427 calculations. Don't update size until allocation succeeds.
2428 Redo calculations to avoid overflow.
2429 * keyboard.h: Change prototypes to match the above.
2431 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2433 (current_minor_maps): Check for size calculation overflow.
2434 * keymap.h: Change prototypes to match the above.
2436 * lread.c (read1, init_obarray): Don't update size until alloc done.
2438 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2439 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2441 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2442 Now ptrdiff_t, not int.
2443 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2444 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2446 * process.c (Fnetwork_interface_list): Check for overflow
2447 in size calculation.
2449 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2451 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2452 overflow. Don't bother calling xmalloc when xrealloc will do.
2454 * search.c (Freplace_match): Check for size calculation overflow.
2455 (Fset_match_data): Don't assume list lengths fit in 'int'.
2457 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2458 for command line length. Do not attempt to address one before the
2459 beginning of an array, as that's not portable.
2461 * term.c (max_frame_lines): Remove; unused.
2462 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2464 (encode_terminal_code, calculate_costs): Check for size
2465 calculation overflow.
2466 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2467 table lengths and related sizes. Don't update size until alloc
2468 done. Redo calculations to avoid overflow.
2469 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2471 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2472 subtracting pointers.
2473 (gobble_line): Check for overflow more carefully. Don't update size
2476 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2477 Don't update size until alloc done.
2478 Redo size calculations to avoid overflow.
2479 Check for size calculation overflow.
2480 (main) [DEBUG]: Fix typo in invoking tparam1.
2482 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2483 Use ptrdiff_t, not int, for sizes.
2484 (store_mode_line_noprop_char): Don't update size until alloc done.
2486 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2487 Use ptrdiff_t, not int, for sizes.
2488 (Finternal_make_lisp_face, cache_face):
2489 Check for size calculation overflow.
2490 (cache_face): Treat size calculation overflows as if they were
2491 memory exhaustion (the usual treatment), rather than aborting.
2493 * xfns.c (x_encode_text, x_set_name_internal)
2494 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2495 sizes, since they can exceed INT_MAX in size. Check for size
2496 calculation overflow.
2498 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2499 (xg_select): Check for size calculation overflow.
2500 Don't update size until alloc done.
2502 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2503 as sprintf is limited to int lengths.
2505 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2506 (X_LONG_MIN): New macros.
2507 Use them to make the following changes clearer.
2508 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2509 This change doesn't affect the value now, but it may help remind
2510 future maintainers not to raise the value too much later.
2511 (SELECTION_QUANTUM): Remove, replacing with ...
2512 (selection_quantum): ... new function, which avoids overflow.
2514 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2515 assumption that selection length fits in 'int'.
2516 (x_reply_selection_request, x_handle_selection_request)
2517 (x_get_window_property, receive_incremental_selection)
2518 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2519 (lisp_data_to_selection_data, clean_local_selection_data):
2520 Use ptrdiff_t, not int, to record length of selection.
2521 (x_reply_selection_request, x_get_window_property)
2522 (receive_incremental_selection, x_property_data_to_lisp):
2523 Redo calculations to avoid overflow.
2524 (x_reply_selection_request): When sending hint, ceiling it at
2525 X_LONG_MAX rather than relying on wraparound overflow to send
2527 (x_get_window_property, receive_incremental_selection)
2528 (lisp_data_to_selection_data, x_property_data_to_lisp):
2529 Check for size-calculation overflow.
2530 (x_get_window_property, receive_incremental_selection)
2531 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2532 Don't store size until memory allocation succeeds.
2533 (x_get_window_property): Plug memory leak on memory exhaustion.
2534 Don't double-block input; malloc is safe here. Don't assume 2**34
2535 - 4 fits in unsigned long. Add an xassert to check
2536 XGetWindowProperty overflow. Be more careful about overflow
2537 calculations, and distinguish size from memory overflow better.
2538 (receive_incremental_selection): When tracing, don't assume
2539 unsigned int is less than INT_MAX.
2540 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2541 harmful) conversions of unsigned short to int.
2542 (lisp_data_to_selection_data): Don't assume that integers
2543 in the range -65535 through -1 fit in an X unsigned short.
2544 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2545 result parameters unless successful. Rely on cons_to_unsigned
2546 to report problems with elements; the old code wasn't right anyway.
2547 (x_check_property_data): Check for int overflow; we cannot use
2548 a wider type due to X limits.
2549 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2551 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2553 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2554 (x_term_init): Check for size calculation overflow.
2555 (x_color_cells): Don't store size until memory allocation succeeds.
2556 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2557 Don't assume alloca size is less than MAX_ALLOCA.
2558 (x_term_init): Don't assume length fits in int (sprintf is limited
2561 Use ptrdiff_t for composition IDs.
2562 * character.c (lisp_string_width):
2563 * composite.c (composition_table_size, n_compositions)
2564 (get_composition_id, composition_gstring_from_id):
2565 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2566 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2567 * window.c (Frecenter):
2568 Use ptrdiff_t, not int, for composition IDs.
2569 * composite.c (get_composition_id): Check for integer overflow.
2570 * composite.h: Adjust prototypes to match the above changes.
2572 Use ptrdiff_t for hash table indexes.
2573 * category.c (hash_get_category_set):
2574 * ccl.c (ccl_driver):
2575 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2576 * coding.c (coding_system_charset_list, detect_coding_system):
2577 * coding.h (struct coding_system.id):
2578 * composite.c (get_composition_id, gstring_lookup_cache):
2579 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2580 * image.c (xpm_get_color_table_h):
2581 * lisp.h (hash_lookup, hash_put):
2582 * minibuf.c (Ftest_completion):
2583 Use ptrdiff_t for hash table indexes, not int (which is too
2584 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2585 32-bit --with-wide-int hosts).
2587 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2588 Add a FIXME comment about memory leaks.
2589 (syms_of_charset): Don't assume xmalloc returns.
2591 Don't assume that stated character widths fit in int.
2592 * character.c (Fchar_width, c_string_width, lisp_string_width):
2593 * character.h (CHAR_WIDTH):
2594 * indent.c (MULTIBYTE_BYTES_WIDTH):
2595 Use sanitize_char_width to avoid undefined and/or bad behavior
2596 with outlandish widths.
2597 * character.h (sanitize_tab_width): Rename from sanitize_width,
2598 now that we have two such functions. All uses changed.
2599 (sanitize_char_width): New inline function.
2601 Don't assume that tab-width fits in int.
2602 * character.h (sanitize_width): New inline function.
2603 (SANE_TAB_WIDTH): New macro.
2604 (ASCII_CHAR_WIDTH): Use it.
2605 * indent.c (sane_tab_width): Remove. All uses replaced by
2606 SANE_TAB_WIDTH (current_buffer).
2607 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2609 * fileio.c: Integer overflow issues with file modes.
2610 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2612 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2613 Remove unreachable code.
2614 (read_hex, load_charset_map_from_file): Check for integer overflow.
2616 * xterm.c: Don't go over XClientMessageEvent limit.
2617 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2618 (x_send_scroll_bar_event): Likewise. Check that the size does not
2619 exceed limits imposed by XClientMessageEvent, as well as the usual
2620 ptrdiff_t and size_t limits.
2622 * keyboard.c: Overflow, signedness and related fixes.
2623 (make_lispy_movement): Use same integer type in forward decl
2624 that is used in the definition.
2625 (read_key_sequence, keyremap_step):
2626 Change bufsize argument back to int, undoing my 2011-03-30 change.
2627 We prefer signed types, and int is wide enough here.
2628 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2629 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2630 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2631 length, not size_t. Use ptrdiff_t for index, not int.
2632 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2633 possibility of integer overflow.
2635 Overflow, signedness and related fixes for images.
2637 * dispextern.h (struct it.stack[0].u.image.image_id)
2638 (struct_it.image_id, struct image.id, struct image_cache.size)
2639 (struct image_cache.used, struct image_cache.ref_count):
2640 * gtkutil.c (update_frame_tool_bar):
2641 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2642 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2643 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2644 * nsmenu.m (update_frame_tool_bar):
2645 * xdisp.c (calc_pixel_width_or_height):
2646 * xfns.c (image_cache_refcount):
2647 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2648 on typical 64-bit hosts.
2650 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2651 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2652 Omit unnecessary casts to int.
2653 (parse_image_spec): Check that integers fall into 'int' range
2654 when the callers expect that.
2655 (image_ascent): Redo ascent calculation to avoid int overflow.
2656 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2657 (lookup_image): Remove unnecessary tests.
2658 (xbm_image_p): Locals are now of int, not EMACS_INT,
2659 since parse_image_check makes sure they fit into int.
2660 (png_load, gif_load, svg_load_image):
2661 Prefer int to unsigned where either will do.
2662 (tiff_handler): New function, combining the cores of the
2663 old tiff_error_handler and tiff_warning_handler.
2664 This function is rewritten to use vsnprintf and thereby avoid
2665 stack buffer overflows. It uses only the features of vsnprintf
2666 that are common to both POSIX and native Microsoft.
2667 (tiff_error_handler, tiff_warning_handler): Use it.
2668 (tiff_load, gif_load, imagemagick_load_image):
2669 Don't assume :index value fits in 'int'.
2670 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2671 (imagemagick_load_image): Check that crop parameters fit into
2672 the integer types that MagickCropImage accepts. Don't assume
2673 Vimagemagick_render_type has a nonnegative value. Don't assume
2674 size_t fits in 'long'.
2675 (gs_load): Use printmax_t to print the widest integers possible.
2676 Check for integer overflow when computing image height and width.
2678 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2680 * xdisp.c (redisplay_window): Don't force window start if point
2681 will be invisible in the resulting window. (Bug#9324)
2683 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2685 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2686 the display spec is of the form `(space ...)'.
2687 (handle_display_spec): Return the value returned by
2688 handle_single_display_spec, not just 1 or zero.
2689 (handle_single_display_spec): If the display spec is of the form
2690 `(space ...)', and specifies display in the text area, return 2
2692 (try_cursor_movement): Check for the need to scroll more
2693 accurately, and prefer exact match for point under bidi.
2694 Don't advance `row' beyond the last row of the window.
2696 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2697 into disp_prop; all users changed.
2699 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2700 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2701 for the text covered by the display property.
2703 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2705 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2706 Change return value to nil.
2707 (Frecord_buffer): Delete unused function.
2709 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2711 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2712 buffers, return left-to-right.
2713 (set_cursor_from_row): Consider candidate row a win if its glyph
2714 represents a newline and point is on that newline. Fixes cursor
2715 positioning on the newline at EOL of R2L text within L2R
2716 paragraph, and vice versa.
2717 (try_cursor_movement): Check continued rows, in addition to
2718 continuation rows. Fixes unwarranted scroll when point enters a
2719 continued line of R2L text within an L2R paragraph, or vice versa.
2720 (cursor_row_p): Consider the case of point being equal to
2721 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2722 from the end of a short line to the beginning of a continued line
2723 of R2L text within L2R paragraph.
2724 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2725 composed characters.
2727 * bidi.c (bidi_check_type): Use xassert.
2728 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2731 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2733 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2736 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2738 * nsfont.m (ns_otf_to_script): Fix typo.
2740 2011-08-22 Kenichi Handa <handa@m17n.org>
2742 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2743 extra slot even if the purpose is char-code-property-table.
2745 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2747 * xdisp.c (redisplay_window): When computing centering_position,
2748 account for the height of the header line. (Bug#8874)
2750 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2751 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2752 candidate is selected by the mouse, and that candidate has a
2753 composed character under the mouse.
2755 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2756 coordinates reported by pos-visible-in-window-p for a composed
2757 character in column zero.
2759 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2761 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2763 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2765 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2766 consider it a hit if to_charpos is anywhere in the range of the
2767 composed buffer positions.
2769 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2771 * image.c (gif_load): Don't assume that each subimage has the same
2772 dimensions as the base image. Handle disposal method that is
2773 "undefined" by the gif spec (Bug#9335).
2775 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2777 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2778 (Fcondition_case): Document `debug' symbol in error handler.
2780 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2782 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2783 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2784 from an Org mode buffer to a Speedbar frame.
2786 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2787 a composition, take its buffer position from IT->cmp_it.charpos.
2788 Fixes cursor positioning at the beginning of a line that begins
2789 with a composed character.
2791 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2793 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2794 character bidirectional type, use STRONG_L instead. Fixes crashes
2795 in a buffer produced by `describe-categories'.
2797 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2798 members before the level stack, so they would be saved and
2799 restored when copying iterator state. Fixes incorrect reordering
2800 around TABs covered by display properties.
2802 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2804 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2806 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2808 * eval.c (internal_condition_case, internal_condition_case_1)
2809 (internal_condition_case_2, internal_condition_case_n):
2810 Remove unnecessary aborts (Bug#9081).
2812 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2814 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2815 has no `load' handler, try opening the file locally. (Bug#9311)
2817 2011-08-16 Ken Brown <kbrown@cornell.edu>
2819 * gmalloc.c: Expand comment.
2821 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2823 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2824 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2826 2011-08-16 Ken Brown <kbrown@cornell.edu>
2828 Fix memory allocation problems in Cygwin build (Bug#9273).
2830 * unexcw.c ( __malloc_initialized): Declare external variable.
2831 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2833 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2835 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2837 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2839 [CYGWIN] (special_realloc): New function.
2840 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2841 requests to realloc storage in the static heap.
2843 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2845 * bidi.c (bidi_initialize): Remove unused local.
2847 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2850 * biditype.h: Remove file.
2851 * makefile.w32-in ($(BLD)/bidi.$(O)):
2852 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2854 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2856 * chartab.c: Improve commentary for the uniprop_table API.
2858 * bidi.c (bidi_paragraph_init): Support zero value of
2859 bidi_ignore_explicit_marks_for_paragraph_level.
2860 (bidi_initialize): Use uniprop_table instead of including
2861 biditype.h and bidimirror.h.
2863 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2864 coordinates of the iterator when restoring from ppos_it.
2867 2011-08-14 Kenichi Handa <handa@m17n.org>
2869 * process.c (create_process): Call setup_process_coding_systems
2870 after the pid of the process is set to -1 (Bug#8162).
2872 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2874 * xdisp.c (move_it_in_display_line_to): Don't invoke
2875 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2876 ppos_it. Fixes vertical cursor motion when line beginning is
2877 covered by an image. (Bug#9296)
2879 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2881 * nsterm.h (ns_run_ascript): Declare.
2882 (NSAPP_DATA2_RUNASSCRIPT): Define.
2884 * nsfns.m (as_script, as_result, as_status): New static variables.
2885 (ns_run_ascript): New function.
2886 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2887 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2888 the event loop. Get status from as_status (Bug#7276).
2890 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2891 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2892 the event loop (Bug#7276).
2894 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2896 * gnutls.c (QCgnutls_bootprop_priority)
2897 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2898 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2899 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2900 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2901 (QCgnutls_bootprop_verify_hostname_error)
2902 (QCgnutls_bootprop_callbacks_verify): Rename from
2903 Qgnutls_bootprop_..., all uses changed.
2905 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2908 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2910 * xfaces.c (Qframe_set_background_mode): Now static.
2911 * dispextern.h (Qframe_set_background_mode): Remove decl.
2913 * process.c (Fnetwork_interface_info): Declare local only if needed.
2915 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2917 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2918 (Fnetwork_interface_list): Allocate in increments of bytes instead
2919 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2920 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2922 (struct ifflag_def): notrailers is smart on OSX.
2923 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2924 Get hardware address with getifaddrs if available.
2926 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2928 * xdisp.c (iterate_out_of_display_property): xassert that
2929 IT->position is set to within IT->object's boundaries. Break from
2930 the loop as soon as EOB is reached; avoids infloops in redisplay
2931 when IT->position is set up wrongly due to some bug.
2932 Set IT->current to match the bidi iterator unconditionally.
2933 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2934 entry. Force push_it to save on the stack the current
2935 buffer/string position, to be restored by pop_it. Fix flags in
2936 the iterator structure wrt the object coming from a display
2937 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2938 properties. (Bug#9284)
2940 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2942 * fontset.c (fontset_get_font_group): Add proper type checks.
2945 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2947 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2948 and LC_VERSION_MIN_MACOSX.
2949 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2950 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2952 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2954 * xdisp.c (forward_to_next_line_start): Allow to use the
2955 no-display-properties-and-no-overlays under bidi display.
2956 Set disp_pos in the bidi iterator to avoid searches for display
2957 properties and overlays.
2959 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2961 * editfns.c (Fset_time_zone_rule): Document relationship with the
2964 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2965 the font entity extracted from the cache (Bug#8109).
2967 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2969 * composite.c (autocmp_chars): Don't reset point. That is done by
2970 restore_point_unwind (Bug#5984).
2972 2011-08-07 Juri Linkov <juri@jurta.org>
2974 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2975 to show the arg `TIME' instead of `TIMEVAL'.
2977 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2979 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2980 display property strides EOL and includes a newline, as in
2981 longlines-mode. (Bug#9254)
2982 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2983 word-wrap under bidirectional display. (Bug#9224)
2985 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2986 is non-zero, even if the data buffer is NULL. Fixes a crash in
2987 vertical-motion with longlines-mode. (Bug#9254)
2989 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2991 * bidi.c <bidi_cache_total_alloc>: Now static.
2992 (bidi_initialize): Initialize bidi_cache_total_alloc.
2994 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2997 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2998 amount allocated this far in `bidi_cache_total_alloc'.
2999 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3000 non-zero, only free the data buffer without restoring the cache
3001 contents. All callers changed.
3003 * dispextern.h (bidi_unshelve_cache): Update prototype.
3005 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3006 (move_it_in_display_line, move_it_to)
3007 (move_it_vertically_backward, move_it_by_lines): Replace the call
3008 to xfree to an equivalent call to bidi_unshelve_cache.
3009 (move_it_in_display_line_to): Fix logic of returning
3010 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3012 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3014 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3015 came from a string character with a `cursor' property. (Bug#9229)
3017 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3019 * Makefile.in (LIB_PTHREAD): New variable.
3020 (LIBES): Add LIB_PTHREAD (Bug#9216).
3022 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3023 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3025 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3027 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3029 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3031 * xterm.c (x_find_topmost_parent): New function.
3032 (x_set_frame_alpha): Find topmost parent window with
3033 x_find_topmost_parent and set the property there also (bug#9181).
3034 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3036 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3038 * callproc.c (Fcall_process): Avoid vfork clobbering
3039 the local vars buffer, coding_systems, current_dir.
3041 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3043 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3045 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3047 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3048 so that it is not optimized away.
3050 * xdisp.c (compute_display_string_pos): Remove unused local.
3052 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3054 Fix slow cursor motion and scrolling in large buffers with
3055 selective display, like Org Mode buffers. (Bug#9218)
3057 * dispextern.h (struct bidi_it): New member disp_prop_p.
3059 * xdisp.c: Remove one-slot cache of display string positions.
3060 (compute_display_string_pos): Accept an additional argument
3061 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3062 for a display string or property. If found, set DISP_PROP_P
3065 * bidi.c (bidi_fetch_char): Accept an additional argument
3066 DISP_PROP_P, and pass it to compute_display_string_pos.
3067 Only handle text covered by a display string if DISP_PROP_P is returned
3068 non-zero. All callers of bidi_fetch_char changed.
3070 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3072 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3074 2010-12-03 Don March <don@ohspite.net>
3076 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3077 last character M-[char] is translated to ESC [char] (bug#7541).
3079 2011-08-02 Kenichi Handa <handa@m17n.org>
3081 * lisp.h (uniprop_table): Extern it.
3083 * chartab.c (uniprop_table): Make it non-static.
3085 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3087 * xdisp.c (forward_to_next_line_start): Accept additional argument
3088 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3090 (reseat_at_next_visible_line_start): Use the bidi iterator state
3091 returned by forward_to_next_line_start to restore the state of
3092 it->bidi_it after backing up to previous newline. (Bug#9212)
3094 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3096 * regex.c (re_comp): Protoize.
3097 (re_exec): Fix return type.
3098 (regexec): Fix type of `ret'. (Bug#9203)
3100 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3102 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3103 This is needed if max-image-size is a floating-point number.
3105 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3107 * print.c (print_object): Print empty symbol as ##.
3109 * lread.c (read1): Read ## as empty symbol.
3111 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3113 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3114 setting frame foreground color (Bug#9175).
3115 (x_set_background_color): Likewise.
3117 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3118 contents (Bug#9176).
3119 (EmacsTooltip -init): Remove bezels and add shadows to
3122 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3123 or scroll bar (Bug#8470).
3125 * nsfont.m (nsfont_open): Remove assignment to voffset and
3126 unnecessary vars hshink, expand, hd, full_height, min_height.
3127 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3129 * nsterm.h (nsfont_info): Remove voffset field.
3131 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3133 Implement strike-through and overline on NextStep (Bug#8863).
3135 * nsfont.m (nsfont_open): Use underline position provided by font,
3136 instead of hard-coded value of 2.
3137 (nsfont_draw): Call ns_draw_text_decoration instead.
3139 * nsterm.h: Add declaration for ns_draw_text_decoration.
3141 * nsterm.m (ns_draw_text_decoration): New function for drawing
3142 underline, overline, and strike-through.
3143 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3144 ns_draw_text_decoration. Change treatment of cursor drawing to
3145 accommodate underlining, etc.
3147 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3149 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3152 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3154 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3155 Without this fix, if a signal arrives just after memory fills up,
3156 'malloc' might be invoked reentrantly.
3158 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3159 In other words, assume that every image size is allowed, on non-X
3160 hosts. This assumption is probably wrong, but it lets Emacs compile.
3162 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3164 * regex.c (re_iswctype): Convert return values to boolean.
3166 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3168 * xdisp.c (compute_display_string_pos): Don't use cached display
3169 string position if the buffer had its restriction changed.
3172 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3174 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3176 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3178 Integer signedness and overflow and related fixes. (Bug#9079)
3180 * bidi.c: Integer size and overflow fixes.
3181 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3182 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3183 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3184 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3185 (bidi_find_other_level_edge):
3186 Use ptrdiff_t instead of EMACS_INT where either will do.
3187 This works better on 32-bit hosts configured --with-wide-int.
3188 (bidi_cache_ensure_space): Check for size-calculation overflow.
3189 Use % rather than repeated addition, for better worst-case speed.
3190 Don't set bidi_cache_size until after xrealloc returns, because it
3192 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3193 (bidi_cache_ensure_space): Also check that the bidi cache size
3194 does not exceed that of the largest Lisp string or buffer. See Eli
3195 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3197 * alloc.c (__malloc_size_t): Remove.
3198 All uses replaced by size_t. See Andreas Schwab's note
3199 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3201 * image.c: Improve checking for integer overflow.
3202 (check_image_size): Assume that f is nonnull, since
3203 it is always nonnull in practice. This is one less thing to
3204 worry about when checking for integer overflow later.
3205 (x_check_image_size): New function, which checks for integer
3206 overflow issues inside X.
3207 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3208 This removes the need for a memory_full check.
3209 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3210 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3211 (xbm_read_bitmap_data): Change locals back to 'int', since
3212 their values must fit in 'int'.
3213 (xpm_load_image, png_load, tiff_load):
3214 Invoke x_create_x_image_and_pixmap earlier,
3215 to avoid much needless work if the image is too large.
3216 (tiff_load): Treat overly large images as if
3217 x_create_x_image_and_pixmap failed, not as malloc failures.
3218 (gs_load): Use x_check_image_size.
3220 * gtkutil.c: Omit integer casts.
3221 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3222 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3224 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3226 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3227 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3228 would wrongly return t on a 64-bit host.
3230 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3231 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3232 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3233 and therefore cause GCC to emit a bogus diagnostic in some cases.
3235 * image.c: Integer signedness and overflow and related fixes.
3236 This is not an exhaustive set of fixes, but it's time to
3237 record what I've got.
3238 (lookup_pixel_color, check_image_size): Remove redundant decls.
3239 (check_image_size): Don't assume that arbitrary EMACS_INT values
3240 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3241 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3242 (tiff_load, imagemagick_load_image):
3243 Check for overflow in size calculations.
3244 (x_create_x_image_and_pixmap): Remove unnecessary test for
3245 xmalloc returning NULL; that can't happen.
3246 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3247 (xpm_color_bucket): Use better integer hashing function.
3248 (xpm_cache_color): Don't possibly over-allocate memory.
3249 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3250 (gif_memory_source):
3251 Use ptrdiff_t, not int or size_t, to record sizes.
3252 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3253 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3254 either works, as we prefer signed integers.
3255 (tiff_read_from_memory, tiff_write_from_memory):
3256 Return tsize_t, not size_t, since that's what the TIFF API wants.
3257 (tiff_read_from_memory): Don't fail simply because the read would
3258 go past EOF; instead, return a short read.
3259 (tiff_load): Omit no-longer-needed casts.
3260 (Fimagemagick_types): Don't assume size fits into 'int'.
3262 Improve hashing quality when configured --with-wide-int.
3263 * fns.c (hash_string): New function, taken from sxhash_string.
3264 Do not discard information about ASCII character case; this
3265 discarding is no longer needed.
3266 (sxhash-string): Use it. Change sig to match it. Caller changed.
3267 * lisp.h: Declare it.
3268 * lread.c (hash_string): Remove, since we now use fns.c's version.
3269 The fns.c version returns a wider integer if --with-wide-int is
3270 specified, so this should help the quality of the hashing a bit.
3272 * emacs.c: Integer overflow minor fix.
3273 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3274 Define only if GNU_LINUX.
3275 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3277 * dispnew.c: Integer signedness and overflow fixes.
3278 Remove unnecessary forward decls, that were a maintenance hassle.
3279 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3281 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3282 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3283 (prepare_desired_row, line_draw_cost):
3284 Use int, not unsigned, where either works.
3285 (save_current_matrix, restore_current_matrix):
3286 Use ptrdiff_t, not size_t, where either works.
3287 (init_display): Check for overflow more accurately, and without
3288 relying on undefined behavior.
3290 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3291 Remove, replacing with the new symbols in lisp.h. All uses changed.
3292 * fileio.c (make_temp_name):
3293 * filelock.c (lock_file_1, lock_file):
3294 * xdisp.c (message_dolog):
3295 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3296 Use pMd etc. instead.
3297 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3298 replacing the pWIDE etc. symbols removed from editfns.c.
3300 * keyboard.h (num_input_events): Now uintmax_t.
3301 This is (very slightly) less likely to mess up due to wraparound.
3304 * buffer.c: Integer signedness fixes.
3305 (alloc_buffer_text, enlarge_buffer_text):
3306 Use ptrdiff_t rather than size_t when either will do, as we prefer
3309 * alloc.c: Integer signedness and overflow fixes.
3310 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3311 (__malloc_size_t): Default to size_t, not to int.
3312 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3313 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3314 Prefer ptrdiff_t to size_t when either would do, as we prefer
3316 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3317 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3318 Now const. Initialize with values that are in range even if char
3320 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3321 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3322 These functions do the right thing with sizes > 2**32.
3323 (check_depth): Now ptrdiff_t, not int.
3324 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3325 Adjust to new way of storing sizes. Check for size overflow bugs
3327 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3328 slightly wrong anyway, as it missed one instance of
3329 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3330 (refill_memory_reserve): Omit needless cast to size_t.
3331 (mark_object_loop_halt): Mark as externally visible.
3333 * xselect.c: Integer signedness and overflow fixes.
3334 (Fx_register_dnd_atom, x_handle_dnd_message):
3335 Use ptrdiff_t, not size_t, since we prefer signed.
3336 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3337 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3338 x_dnd_atoms_size and x_dnd_atoms_length.
3340 * doprnt.c: Prefer signed to unsigned when either works.
3342 * doprnt.c (doprnt):
3344 * xdisp.c (vmessage):
3345 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3346 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3347 prefer signed arithmetic to avoid comparison confusion.
3348 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3349 but is a bit tricky.
3351 Assume freestanding C89 headers, string.h, stdlib.h.
3352 * data.c, doprnt.c, floatfns.c, print.c:
3353 Include float.h unconditionally.
3354 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3355 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3356 * regex.c: Likewise for stddef.h, string.h.
3357 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3358 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3359 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3360 (STDC_HEADERS): Remove obsolete defines.
3361 * sysdep.c: Include limits.h unconditionally.
3363 Assume support for memcmp, memcpy, memmove, memset.
3364 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3365 * regex.c (memcmp, memcpy):
3366 Remove; we assume C89 now.
3368 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3369 (__malloc_safe_bcopy): Remove; no longer needed.
3371 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3372 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3373 well either way, and we prefer signed to unsigned.
3375 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3377 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3378 closes the connection while we're reading (bug#9182).
3380 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3382 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3383 are specified (Bug#9168).
3385 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3387 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3388 Found by GCC static checking and --with-wide-int on a 32-bit host.
3390 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3392 * xdisp.c (compute_display_string_pos): Fix logic of caching
3393 previous display string position. Initialize cached_prev_pos to
3394 -1. Fixes slow-down at the beginning of a buffer.
3396 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3398 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3399 for attrs[LFACE_FONTSET_INDEX].
3401 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3403 * xml.c (parse_region): Remove unused local
3404 that was recently introduced.
3406 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3408 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3409 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3411 * xdisp.c (move_it_in_display_line_to): Record the best matching
3412 position for TO_CHARPOS while scanning the line, and restore it on
3413 exit if none of the characters scanned was an exact match.
3414 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3415 when exact match is impossible due to invisible text, and the
3416 lines are truncated.
3418 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3420 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3423 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3425 Fix a significant slow-down of cursor motion with C-n, C-p,
3426 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3427 auto-repeat under bidi redisplay in fontified buffers.
3428 * xdisp.c (compute_stop_pos_backwards): New function.
3429 (next_element_from_buffer): Call compute_stop_pos_backwards to
3430 find a suitable prev_stop when we find ourselves before
3432 (reseat): Don't look for prev_stop, as that could mean a very long
3434 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3435 <cached_disp_overlay_modiff>: Cache for last found display string
3437 (compute_display_string_pos): Return the cached position if asked
3438 about the same buffer in the same area of character positions, and
3439 the buffer wasn't changed since the time the display string
3440 position was cached.
3442 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3444 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3445 is an integer, which is important for empty lines. (Bug#9149)
3447 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3449 * frame.c (Fmodify_frame_parameters): In tty case, update the
3450 default face if necessary (Bug#4238).
3452 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3454 * editfns.c (Fstring_to_char): No need to explain what a character
3455 is in the docstring (Bug#6576).
3457 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3459 * xml.c (parse_region): Make sure we always return a tree.
3461 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3463 * xml.c (parse_region): If a document contains only comments,
3466 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3468 * xml.c (make_dom): Return comments, too.
3470 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3473 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3474 and the surrounding thread.
3475 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3476 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3477 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3479 * s/openbsd.h (BROKEN_SIGIO): Define.
3480 * unexelf.c (unexec) [__OpenBSD__]:
3481 Don't update the .mdebug section of the Alpha COFF symbol table.
3483 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3485 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3488 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3490 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3491 This fixes some race conditions on the permissions of any newly
3494 * alloc.c (valid_pointer_p): Use pipe, not open.
3495 This fixes some permissions issues when debugging.
3497 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3498 If fchown fails to set both uid and gid, try to set just gid,
3499 as that is sometimes allowed. Adjust the file's mode to eliminate
3500 setuid or setgid bits that are inappropriate if fchown fails.
3502 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3504 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3505 to compare Lisp_Objects.
3506 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3507 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3508 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3510 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3512 * lread.c (read_integer): Unread even EOF character.
3513 (read1): Likewise. Properly record start position of symbol.
3515 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3516 symbol character follows.
3518 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3520 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3521 This works around a problem with the previous change to Fcopy_file.
3522 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3523 and without this change, GCC might complain about discarding
3524 fchown's return value.
3526 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3528 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3530 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3532 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3534 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3536 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3537 it's used from the C level.
3539 * process.c: Use the same condition for POLL_FOR_INPUT in both
3540 keyboard.c and process.c (bug#1858).
3542 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3544 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3545 (Fgnutls_boot): Use it.
3547 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3549 * doc.c (Fsubstitute_command_keys): Revert last change.
3551 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3553 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3554 quotes the next character, and doesn't affect other longer
3555 sequences (bug#8935).
3557 * lread.c (syms_of_lread): Clarify that is isn't only
3558 `eval-buffer' and `eval-defun' that's affected by
3559 `lexical-binding' (bug#8460).
3561 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3563 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3564 bidi redisplay when a line includes both an image and is truncated.
3566 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3568 Fix minor problems found by static checking.
3569 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3570 (elsz): Now a signed constant, not a size_t var. We prefer signed
3571 types to unsigned, to avoid integer comparison confusion. Without
3572 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3573 "cannot optimize loop, the loop counter may overflow", a symptom
3575 * indent.c (Fvertical_motion): Mark locals as initialized.
3576 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3578 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3580 * search.c (Fre_search_backward): Mention `case-fold-search' in
3581 all the re_search_* functions (bug#8138).
3583 * keyboard.c (Fopen_dribble_file): Document when the file is
3586 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3588 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3591 Support bidi reordering of display and overlay strings.
3592 * xdisp.c (compute_display_string_pos)
3593 (compute_display_string_end): Accept additional argument STRING.
3594 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3595 (reseat_to_string): Initialize bidi_it->string.s and
3596 bidi_it->string.schars.
3597 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3598 NULL (avoids a crash in bidi_paragraph_init).
3599 Initialize itb.string.lstring.
3600 (init_iterator): Call bidi_init_it only of a valid
3601 buffer position was specified. Initialize paragraph_embedding to
3603 (reseat_to_string): Initialize the bidi iterator.
3604 (display_string): If we need to ignore text properties of
3605 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3606 original value of -1 will not work with bidi.)
3607 (compute_display_string_pos): First arg is now struct
3608 `text_pos *'; all callers changed. Support display properties on
3610 (compute_display_string_end): Support display properties on Lisp
3612 (init_iterator, reseat_1, reseat_to_string): Initialize the
3613 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3614 when iterating on a string not from display properties).
3615 (compute_display_string_pos, compute_display_string_end):
3616 Fix calculation of the object to scan. Fixes an error when using
3618 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3619 base_level_stop; instead, set base_level_stop to BEGV.
3620 Fixes crashes in vertical-motion.
3621 (next_element_from_buffer): Improve commentary for when
3622 the iterator is before prev_stop.
3623 (init_iterator): Initialize bidi_p from the default value of
3624 bidi-display-reordering, not from buffer-local value. Use the
3625 buffer-local value only if initializing for buffer iteration.
3626 (handle_invisible_prop): Support invisible properties on strings
3627 that are being bidi-reordered.
3628 (set_iterator_to_next): Support bidi reordering of C strings and
3630 (next_element_from_string): Support bidi reordering of Lisp
3632 (handle_stop_backwards): Support Lisp strings as well.
3633 (display_string): Support display of R2L glyph rows.
3634 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3635 (init_iterator): Don't initialize it->bidi_p for strings
3637 (reseat_to_string): Initialize it->bidi_p for strings here.
3638 (next_element_from_string, next_element_from_c_string)
3639 (next_element_from_buffer): Add xassert's for correspondence
3640 between IT's object being iterated and it->bidi_it.string
3642 (face_before_or_after_it_pos): Support bidi iteration.
3643 (next_element_from_c_string): Handle the case of the first string
3644 character that is not the first one in the visual order.
3645 (get_visually_first_element): New function, refactored from common
3646 parts of next_element_from_buffer, next_element_from_string, and
3647 next_element_from_c_string.
3648 (tool_bar_lines_needed, redisplay_tool_bar)
3649 (display_menu_bar): Force left-to-right direction. Add a FIXME
3650 comment for making that be controlled by a user option.
3651 (push_it, pop_it): Save and restore the state of the
3652 bidi iterator. Save and restore the bidi_p flag.
3653 (pop_it): Iterate out of display property for string iteration as
3655 (iterate_out_of_display_property): Support iteration over strings.
3656 (handle_single_display_spec): Set up it->bidi_it for iteration
3657 over a display string, and call bidi_init_it.
3658 (handle_single_display_spec, next_overlay_string)
3659 (get_overlay_strings_1, push_display_prop): Set up the bidi
3660 iterator for displaying display or overlay strings.
3661 (forward_to_next_line_start): Don't use the shortcut if
3663 (back_to_previous_visible_line_start): If handle_display_prop
3664 pushed the iterator stack, restore the internal state of the bidi
3665 iterator by calling bidi_pop_it same number of times.
3666 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3667 and we are bidi-iterating, don't decrement the iterator position;
3668 instead, set the first_elt flag in the bidi iterator, to produce
3670 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3671 (push_display_prop): xassert that we are iterating a buffer.
3672 (push_it, pop_it): Save and restore paragraph_embedding member.
3673 (handle_single_display_spec, next_overlay_string)
3674 (get_overlay_strings_1, reseat_1, reseat_to_string)
3675 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3676 correctly. Don't assume unibyte strings are not bidi-reordered.
3677 (compute_display_string_pos)
3678 (compute_display_string_end): Fix handling the case of C string.
3679 (push_it, pop_it): Save and restore from_disp_prop_p.
3680 (handle_single_display_spec, push_display_prop): Set the
3681 from_disp_prop_p flag.
3682 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3683 (pop_it): Call iterate_out_of_display_property only if we are
3684 popping after iteration over a string that came from a display
3685 property. Fix a typo in popping stretch info. Add an assertion
3686 for verifying that the iterator position is in sync with the bidi
3688 (handle_single_display_spec, get_overlay_strings_1)
3689 (push_display_prop): Fix initialization of paragraph direction for
3690 string when that of the parent object is not yet determined.
3691 (reseat_1): Call bidi_init_it to resync the bidi
3692 iterator with IT's position. (Bug#7616)
3693 (find_row_edges): If ROW->start.pos gives position
3694 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3695 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3696 Reset the from_disp_prop_p flag.
3697 (SAVE_IT, RESTORE_IT): New macros.
3698 (pos_visible_p, face_before_or_after_it_pos)
3699 (back_to_previous_visible_line_start)
3700 (move_it_in_display_line_to, move_it_in_display_line)
3701 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3702 (try_scrolling, redisplay_window, display_line): Use them when
3703 saving a temporary copy of the iterator and restoring it back.
3704 (back_to_previous_visible_line_start, reseat_1)
3705 (init_iterator): Empty the bidi cache "stack".
3706 (move_it_in_display_line_to): If iterator ended up at
3707 EOL, but we never saw any buffer positions smaller than
3708 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3709 motion in bidi-reordered lines.
3710 (move_it_in_display_line_to): Record prev_method and prev_pos
3711 immediately before the call to set_iterator_to_next. Fixes cursor
3712 motion in bidi-reordered lines with stretch glyphs and strings
3713 displayed in margins. (Bug#8133) (Bug#8867)
3714 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3716 (pos_visible_p): Support positions in bidi-reordered lines.
3717 Save and restore bidi cache.
3719 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3720 (bidi_paragraph_info): Delete unused struct.
3721 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3722 (bidi_cache_start): New variable.
3723 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3725 (bidi_cache_fetch_state, bidi_cache_search)
3726 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3727 (bidi_cache_find, bidi_peek_at_next_level)
3728 (bidi_level_of_next_char, bidi_find_other_level_edge)
3729 (bidi_move_to_visually_next): Compare cache index with
3730 bidi_cache_start rather than with zero.
3731 (bidi_fetch_char): Accept new argument STRING; all callers
3732 changed. Support iteration over a string. Support strings with
3733 display properties. Support unibyte strings. Fix the type of
3734 `len' according to what STRING_CHAR_AND_LENGTH expects.
3735 (bidi_paragraph_init, bidi_resolve_explicit_1)
3736 (bidi_resolve_explicit, bidi_resolve_weak)
3737 (bidi_level_of_next_char, bidi_move_to_visually_next):
3738 Support iteration over a string.
3739 (bidi_set_sor_type, bidi_resolve_explicit_1)
3740 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3741 can now be zero (for strings); special values 0 and -1 were
3742 changed to -1 and -2, respectively.
3743 (bidi_char_at_pos): New function.
3744 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3745 Call it instead of FETCH_MULTIBYTE_CHAR.
3746 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3747 initialized to valid values.
3748 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3750 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3751 the test for valid cached positions. Fix the logic for looking up
3752 the sentinel state in the cache. GCPRO the Lisp string we are
3754 (bidi_push_it, bidi_pop_it): New functions.
3755 (bidi_initialize): Initialize the bidi cache start stack pointer.
3756 (bidi_cache_ensure_space): New function, refactored from part of
3757 bidi_cache_iterator_state. Don't assume the required size is just
3758 one BIDI_CACHE_CHUNK away.
3759 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3760 (bidi_count_bytes, bidi_char_at_pos): New functions.
3761 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3762 always valid if bidi_cache_idx is valid.
3763 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3764 is valid if it's going to be used.
3765 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3766 (bidi_cache_fetch_state, bidi_cache_search)
3767 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3768 (bidi_cache_iterator_state, bidi_cache_find)
3769 (bidi_find_other_level_edge, bidi_cache_start_stack):
3770 All variables related to cache indices are now EMACS_INT.
3772 * dispextern.h (struct bidi_string_data): New structure.
3773 (struct bidi_it): New member `string'. Make flag members be 1-bit
3774 fields, and put them last in the struct.
3775 (compute_display_string_pos, compute_display_string_end):
3777 (bidi_push_it, bidi_pop_it): Add prototypes.
3778 (struct iterator_stack_entry): New members bidi_p,
3779 paragraph_embedding, and from_disp_prop_p.
3780 (struct it): Member bidi_p is now a bit field 1 bit wide.
3781 (bidi_shelve_cache, bidi_unshelve_cache):
3784 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3785 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3786 and vector-like objects.
3788 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3789 cache around display iteration.
3791 * window.c (Fwindow_end, window_scroll_pixel_based)
3792 (displayed_window_lines, Frecenter): Save and restore the bidi
3793 cache around display iteration.
3795 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3797 * editfns.c (Fdelete_region): Clarify the use of the named
3798 parameters (bug#6788).
3800 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3802 * indent.c (Fvertical_motion): Set and restore w->pointm when
3803 saving and restoring the window's buffer (Bug#9006).
3805 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3807 * editfns.c (Fstring_to_char): Clarify just what is returned
3808 (bug#6576). Text by Eli Zaretskii.
3810 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3812 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3814 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3816 * buffer.c (mmap_find): Fix a typo.
3818 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3820 Fix execution of x selection hooks.
3821 * xselect.c (Qx_lost_selection_functions)
3822 (Qx_sent_selection_functions): New vars.
3823 (syms_of_xselect): DEFSYM them.
3824 (x_handle_selection_request): Pass Qx_sent_selection_functions
3825 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3826 (x_handle_selection_clear,x_clear_frame_selections):
3827 Pass Qx_lost_selection_functions rather than
3828 Vx_lost_selection_functions to Frun_hook_with_args.
3830 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3832 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3833 The old code sometimes used this field without initializing it.
3835 * alloc.c (gc_sweep): Don't read past end of array.
3836 In theory, the old code could also have corrupted Emacs internals,
3837 though it'd be very unlikely.
3839 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3841 * character.c (Fcharacterp): Don't advertise optional ignored
3842 argument. (Bug#4026)
3844 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3846 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3849 * window.c (Fset_window_start): Doc fix (bug#4199).
3850 (Fset_window_hscroll): Ditto.
3852 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3854 Fix minor new problems caught by GCC 4.6.1.
3855 * term.c (init_tty): Remove unused local.
3856 * xsettings.c (store_monospaced_changed): Define this function only
3857 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3860 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3862 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3864 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3866 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3867 are the mini-buffer and the echo area (bug#3320).
3869 * term.c (init_tty): Remove support for supdup, c10 and perq
3870 terminals, which are no longer supported (bug#1482).
3872 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3874 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3876 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3878 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3879 for non-popups (Bug#3642).
3881 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3883 * alloc.c (reset_malloc_hooks): Protoize.
3884 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3885 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3886 * cm.c (losecursor): Likewise.
3887 * data.c (fmod): Likewise.
3888 * dispnew.c (swap_glyphs_in_rows): Likewise.
3889 * emacs.c (memory_warning_signal): Likewise.
3890 * floatfns.c (float_error): Likewise.
3891 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3892 (otf_open, font_otf_capability, generate_otf_features)
3893 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3895 * image.c (pbm_read_file): Likewise.
3896 * indent.c (string_display_width): Likewise.
3897 * intervals.c (check_for_interval, search_for_interval)
3898 (inc_interval_count, count_intervals, root_interval)
3899 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3900 * lread.c (defalias): Likewise.
3901 * ralloc.c (r_alloc_check): Likewise.
3902 * regex.c (set_image_of_range_1, set_image_of_range)
3903 (regex_grow_registers): Likewise.
3904 * sysdep.c (strerror): Likewise.
3905 * termcap.c (valid_filename_p, tprint, main): Likewise.
3906 * tparam.c (main): Likewise.
3907 * unexhp9k800.c (run_time_remap, save_data_space)
3908 (update_file_ptrs, read_header, write_header, calculate_checksum)
3909 (copy_file, copy_rest, display_header): Likewise.
3910 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3912 * xdisp.c (check_it): Likewise.
3913 * xfaces.c (register_color, unregister_color, unregister_colors):
3915 * xfns.c (print_fontset_result): Likewise.
3916 * xrdb.c (member, fatal, main): Likewise.
3918 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3920 Fix minor problems found by static checking (Bug#9031).
3921 * chartab.c (char_table_set_range, map_sub_char_table):
3922 Remove unused locals.
3923 (uniprop_table): Now static.
3924 * composite.c (_work_char): Remove unused static var.
3926 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3928 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3930 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3932 * gtkutil.c (qttip_cb): Remove code without function.
3934 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3936 * w32.c (pthread_sigmask): New stub.
3938 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3940 Use pthread_sigmask, not sigprocmask (Bug#9010).
3941 sigprocmask is portable only for single-threaded applications, and
3942 Emacs can be multi-threaded when it uses GTK.
3943 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3945 * callproc.c (Fcall_process):
3946 * process.c (create_process):
3947 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3948 Use pthread_sigmask, not sigprocmask.
3950 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3952 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3953 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3956 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3958 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3959 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3960 (xg_hide_tooltip): Fix comment.
3962 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3963 in registerServicesMenuSendTypes.
3964 (validRequestorForSendType): Don't check ns_return_types.
3966 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3969 2011-07-08 Jason Rumney <jasonr@gnu.org>
3971 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3972 SH_SHOW for hidden windows (Bug#5482).
3974 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3975 frame struct members of non-existent frames (Bug#6284).
3977 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3979 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3980 variable firstTime not needed on OSX >= 10.6.
3981 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3982 >= 10.5. Use setKnobProportion, setDoubleValue.
3984 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3985 (MAC_OS_X_VERSION_10_5): Define if not defined.
3986 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3987 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3988 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3990 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3991 cString and lossyCString on OSX >= 10.4
3993 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3994 sizeToFit on OSX >= 10.2.
3996 * nsimage.m (allocInitFromFile): Don't use deprecated method
3997 bestRepresentationForDevice on OSX >= 10.6.
3999 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4002 * emacs.c: Declare unexec_init_emacs_zone.
4004 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4006 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4008 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4009 on svcsMenu (Bug#8842).
4011 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4013 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4015 * nsterm.m (QUTF8_STRING): Declare.
4016 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4017 (validRequestorForSendType): Return type is (id).
4018 Change indexOfObjectIdenticalTo to indexOfObject.
4019 Check if we have local selection before returning self (Bug#8842).
4020 (writeSelectionToPasteboard): Put local selection into paste board
4021 if we have a local selection (Bug#8842).
4022 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4024 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4025 (ns_get_local_selection): Declare.
4027 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4029 * keymap.c (describe_map_tree): Don't insert a double newline at
4030 the end of the buffer (bug#1169) and return whether we inserted
4033 * callint.c (Fcall_interactively): Change "reading args" to
4034 "providing args" to try to clarify what it does (bug#1010).
4036 2011-07-07 Kenichi Handa <handa@m17n.org>
4038 * composite.c (composition_compute_stop_pos): Ignore a static
4039 composition starting before CHARPOS (Bug#8915).
4041 * xdisp.c (handle_composition_prop): Likewise.
4043 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4045 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4048 2011-07-07 Kenichi Handa <handa@m17n.org>
4050 * character.h (unicode_category_t): New enum type.
4052 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4053 (Qchar_code_property_table): New variable.
4054 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4055 (UNIPROP_COMPRESSED_FORM_P): New macros.
4056 (char_table_ascii): Uncompress the compressed values.
4057 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4058 Uncompress the compressed values.
4059 (sub_char_table_ref_and_range): Likewise.
4060 (char_table_ref_and_range): Uncompress the compressed values.
4061 (sub_char_table_set): New arg is_uniprop. Callers changed.
4062 Uncompress the compressed values.
4063 (sub_char_table_set_range): Args changed. Callers changed.
4064 (char_table_set_range): Adjuted for the above change.
4065 (map_sub_char_table): Delete args default_val and parent. Add arg
4066 top. Give decoded values to a Lisp function.
4067 (map_char_table): Adjust for the above change. Give decoded
4068 values to a Lisp function. Gcpro more variables.
4069 (uniprop_table_uncompress)
4070 (uniprop_decode_value_run_length): New functions.
4071 (uniprop_decoder, uniprop_decoder_count): New variables.
4072 (uniprop_get_decoder, uniprop_encode_value_character)
4073 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4075 (uniprop_encoder, uniprop_encoder_count): New variables.
4076 (uniprop_get_encoder, uniprop_table)
4077 (Funicode_property_table_internal, Fget_unicode_property_internal)
4078 (Fput_unicode_property_internal): New functions.
4079 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4080 Sunicode_property_table_internal, Sget_unicode_property_internal,
4081 and Sput_unicode_property_internal. Defvar_lisp
4082 char-code-property-alist.
4084 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4085 Vunicode_category_table.
4087 * font.c (font_range): Adjust for the change of
4088 Vunicode_category_table.
4090 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4092 * m/iris4d.h: Remove file, move contents ...
4093 * s/irix6-5.h: ... here.
4095 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4097 Remove unportable assumption about struct layout (Bug#8884).
4098 * alloc.c (mark_buffer):
4099 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4100 (clone_per_buffer_values): Don't assume that
4101 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4102 This isn't true in general, and it's particularly not true
4103 if Emacs is configured with --with-wide-int.
4104 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4105 New macros, used in the buffer.c change.
4107 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4109 * xsettings.c: Use both GConf and GSettings if both are available.
4110 (store_config_changed_event): Add comment.
4111 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4112 (store_tool_bar_style_changed): New functions.
4113 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4114 (struct xsettings): Move font inside HAVE_XFT.
4115 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4116 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4117 Move inside HAVE_XFT.
4118 (something_changed_gsettingsCB): Rename from something_changedCB.
4119 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4121 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4122 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4123 (something_changed_gconfCB): Rename from something_changedCB.
4124 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4125 (parse_settings): Move check for font inside HAVE_XFT.
4126 (read_settings, apply_xft_settings): Add comment.
4127 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4128 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4129 call store_font_name_changed.
4130 (xft_settings_event): Add comment.
4131 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4132 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4133 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4134 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4135 (xsettings_initialize): Call init_gsettings last.
4136 (xsettings_get_system_font, xsettings_get_system_normal_font):
4139 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4141 Random fixes. E.g., (random) never returned negative values.
4142 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4143 subseconds part to the entropy, as that's a bit more random.
4144 Prefer signed to unsigned, since the signedness doesn't matter and
4145 in general we prefer signed. When given a limit, use a
4146 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4147 latter isn't right if USE_2_TAGS_FOR_INTS.
4148 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4149 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4151 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4153 * textprop.c (text_property_stickiness):
4154 Obey Vtext_property_default_nonsticky.
4155 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4156 * w32fns.c (syms_of_w32fns):
4157 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4159 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4161 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4162 This is more efficient than Ffile_directory_p and avoids a minor race.
4164 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4166 * buffer.c (Foverlay_put): Say what the return value is
4169 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4170 is a directory before asking whether to use the file name
4172 (barf_or_query_if_file_exists): Make the "File is a directory"
4173 error be more correct.
4175 * fns.c (Frequire): Remove the mention of the .gz files, since
4176 that's installation-specific, but keep the mention of
4177 `get-load-suffixes'.
4179 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4181 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4182 Report string overflow if the output is too long.
4184 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4186 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4187 (syms_of_gnutls): Remove duplicate DEFSYM for
4188 Qgnutls_bootprop_verify_hostname_error, an error for
4189 Qgnutls_bootprop_verify_error (which is no longer used).
4191 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4192 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4193 Also (re)move comments that are misplaced or no longer relevant.
4195 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4197 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4199 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4201 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4202 and background color parameters if they have been changed.
4204 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4206 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4208 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4210 * xsettings.c (SYSTEM_FONT): Define only when used.
4211 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4213 * keymap.c (access_keymap_1): Now static.
4215 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4217 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4218 leave any prefix arg for the up event (Bug#1586).
4220 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4222 * lread.c (syms_of_lread): Mention single symbols defined by
4223 `defvar' or `defconst' (bug#7154).
4225 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4226 (Frequire): Mention get-load-suffixes.
4228 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4230 * window.h (window): Remove clone_number slot.
4231 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4233 (make_parent_window, make_window, saved_window)
4234 (Fset_window_configuration, save_window_save): Don't deal with
4236 * buffer.c (Qclone_number): Remove declaration.
4237 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4239 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4241 Add multiple inheritance to keymaps.
4242 * keymap.c (Fmake_composed_keymap): New function.
4243 (Fset_keymap_parent): Simplify.
4244 (fix_submap_inheritance): Remove.
4245 (access_keymap_1): New function extracted from access_keymap to handle
4246 embedded parents and handle lists of maps.
4247 (access_keymap): Use it.
4248 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4249 (Fcopy_keymap): Handle embedded parents.
4250 (Fcommand_remapping, define_as_prefix): Simplify.
4251 (Fkey_binding): Simplify.
4252 (syms_of_keymap): Move minibuffer-local-completion-map,
4253 minibuffer-local-filename-completion-map,
4254 minibuffer-local-must-match-map, and
4255 minibuffer-local-filename-must-match-map to Elisp.
4256 (syms_of_keymap): Defsubr make-composed-keymap.
4257 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4258 (parse_menu_item): Trivial simplification.
4260 2011-07-01 Glenn Morris <rgm@gnu.org>
4262 * Makefile.in (SETTINGS_LIBS): Fix typo.
4264 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4266 * coding.c (Fencode_coding_string): Record the last coding system
4267 used, as the function doc string says (bug#8738).
4269 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4271 * xsettings.c (store_monospaced_changed): Take new font as arg and
4272 check for change against current_mono_font.
4273 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4274 (emacs_settings_constructor, emacs_settings_get_property)
4275 (emacs_settings_set_property, emacs_settings_class_init)
4276 (emacs_settings_init, gsettings_obj): Remove.
4277 (something_changedCB): New function for HAVE_GSETTINGS.
4278 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4279 with value as argument.
4280 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4281 g_settings_new (Bug#8967). Do not create gsettings_obj.
4282 Remove calls to g_settings_bind. Connect something_changedCB to
4285 * xgselect.c: Add defined (HAVE_GSETTINGS).
4286 (xgselect_initialize): Ditto.
4288 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4289 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4292 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4294 * eval.c (struct backtrace): Simplify and port the data structure.
4295 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4296 signed bit field, as this assumption is not portable and it makes
4297 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4298 "char debug_on_exit : 1" as this is not portable either; instead,
4299 use the portable "unsigned int debug_on_exit : 1". Remove unused
4300 member evalargs. Remove obsolete comments about cc bombing out.
4302 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4304 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4305 Let HAVE_GSETTINGS override HAVE_GCONF.
4306 (store_monospaced_changed): New function.
4307 (EMACS_SETTINGS): A new type derived from GObject to handle
4308 GSettings notifications.
4309 (emacs_settings_constructor, emacs_settings_get_property)
4310 (emacs_settings_set_property, emacs_settings_class_init):
4312 (gsettings_client, gsettings_obj): New variables.
4313 (GSETTINGS_SCHEMA): New define.
4314 (something_changedCB): Call store_monospaced_changed.
4315 (init_gsettings): New function.
4316 (xsettings_initialize): Call init_gsettings.
4317 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4320 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4323 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4325 * window.c (resize_root_window, grow_mini_window)
4326 (shrink_mini_window): Rename Qresize_root_window to
4327 Qwindow_resize_root_window and Qresize_root_window_vertically to
4328 Qwindow_resize_root_window_vertically.
4330 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4332 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4334 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4336 * makefile.w32-in: Redesign dependencies so they reflect more
4337 clearly which files are directly included by each source file,
4338 and not through other includes.
4340 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4342 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4343 (sort_overlays, overlay_strings): When an overlay's clone number
4344 matches the window's clone number process the overlay even if
4345 the overlay's window property doesn't match the current window.
4347 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4348 (Fwindow_hchild): Rename to Fwindow_left_child.
4349 (Fwindow_next): Rename to Fwindow_next_sibling.
4350 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4351 (resize_window_check): Rename to window_resize_check.
4352 (resize_window_apply): Rename to window_resize_apply.
4353 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4354 (Fdelete_other_windows_internal, resize_frame_windows)
4355 (Fsplit_window_internal, Fdelete_window_internal)
4356 (grow_mini_window, shrink_mini_window)
4357 (Fresize_mini_window_internal): Fix callers accordingly.
4359 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4361 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4362 (emacs_fixed_set_min_size): Remove.
4363 (emacs_fixed_new): Take frame as argument.
4365 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4366 (_EmacsFixedPrivate): Remove minwidth/height.
4367 Add struct frame *f.
4368 (emacs_fixed_init): Initialize priv->f.
4369 (get_parent_class, emacs_fixed_set_min_size): Remove.
4370 (emacs_fixed_new): Set priv->f to argument.
4371 (emacs_fixed_get_preferred_width)
4372 (emacs_fixed_get_preferred_height): Use min_width/height from
4373 frames size_hint to set minimum and natural (Bug#8919).
4374 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4375 and use min_width/height from frames size_hint to set
4376 min_width/height (Bug#8919).
4378 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4379 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4382 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4384 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4385 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4388 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4390 * process.c (wait_reading_process_output): Bypass select if
4391 waiting for a cell while ignoring keyboard input, and input is
4392 pending. Suggested by Jan Djärv (Bug#8869).
4394 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4396 Use gnulib's dup2 module instead of rolling our own.
4397 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4399 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4401 * dispnew.c (scrolling_window): Before scrolling, turn off a
4402 mouse-highlight in the window being scrolled.
4404 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4406 Move DEFSYM to lisp.h and use everywhere.
4408 * character.h (DEFSYM): Move declaration...
4409 * lisp.h (DEFSYM): ...here.
4415 * w32select.c: Don't include character.h.
4417 * alloc.c (syms_of_alloc):
4418 * buffer.c (syms_of_buffer):
4419 * bytecode.c (syms_of_bytecode):
4420 * callint.c (syms_of_callint):
4421 * casefiddle.c (syms_of_casefiddle):
4422 * casetab.c (init_casetab_once):
4423 * category.c (init_category_once, syms_of_category):
4424 * ccl.c (syms_of_ccl):
4425 * cmds.c (syms_of_cmds):
4426 * composite.c (syms_of_composite):
4427 * dbusbind.c (syms_of_dbusbind):
4428 * dired.c (syms_of_dired):
4429 * dispnew.c (syms_of_display):
4430 * doc.c (syms_of_doc):
4431 * editfns.c (syms_of_editfns):
4432 * emacs.c (syms_of_emacs):
4433 * eval.c (syms_of_eval):
4434 * fileio.c (syms_of_fileio):
4435 * fns.c (syms_of_fns):
4436 * frame.c (syms_of_frame):
4437 * fringe.c (syms_of_fringe):
4438 * insdel.c (syms_of_insdel):
4439 * keymap.c (syms_of_keymap):
4440 * lread.c (init_obarray, syms_of_lread):
4441 * macros.c (syms_of_macros):
4442 * msdos.c (syms_of_msdos):
4443 * print.c (syms_of_print):
4444 * process.c (syms_of_process):
4445 * search.c (syms_of_search):
4446 * sound.c (syms_of_sound):
4447 * syntax.c (init_syntax_once, syms_of_syntax):
4448 * terminal.c (syms_of_terminal):
4449 * textprop.c (syms_of_textprop):
4450 * undo.c (syms_of_undo):
4451 * w32.c (globals_of_w32):
4452 * window.c (syms_of_window):
4453 * xdisp.c (syms_of_xdisp):
4454 * xfaces.c (syms_of_xfaces):
4455 * xfns.c (syms_of_xfns):
4456 * xmenu.c (syms_of_xmenu):
4457 * xsettings.c (syms_of_xsettings):
4458 * xterm.c (syms_of_xterm): Use DEFSYM.
4460 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4462 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4464 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4466 Integer and buffer overflow fixes (Bug#8873).
4468 * print.c (printchar, strout): Check for string overflow.
4469 (PRINTPREPARE, printchar, strout):
4470 Don't set size unless allocation succeeds.
4472 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4473 for sizes. Check for string overflow more accurately.
4474 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4476 * macros.c: Integer and buffer overflow fixes.
4477 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4478 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4479 Use ptrdiff_t, not int, for sizes.
4480 Don't increment bufsize until after realloc succeeds.
4481 Check for size-calculation overflow.
4482 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4484 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4486 * lread.c: Integer overflow fixes.
4487 (read_integer): Radix is now EMACS_INT, not int,
4488 to improve quality of diagnostics for out-of-range radices.
4489 Calculate buffer size correctly for out-of-range radices.
4490 (read1): Check for integer overflow in radices, and in
4491 read-circle numbers.
4492 (read_escape): Avoid int overflow.
4493 (Fload, openp, read_buffer_size, read1)
4494 (substitute_object_recurse, read_vector, read_list, map_obarray):
4495 Use ptrdiff_t, not int, for sizes.
4496 (read1): Use EMACS_INT, not int, for sizes.
4497 Check for size overflow.
4499 * image.c (cache_image): Check for size arithmetic overflow.
4501 * lread.c: Integer overflow issues.
4502 (saved_doc_string_size, saved_doc_string_length)
4503 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4504 Now ptrdiff_t, not int.
4505 (read1): Don't assume doc string length fits in int. Check for
4506 out-of-range doc string lengths.
4507 (read_list): Don't assume file position fits in int.
4508 (read_escape): Check for hex character overflow.
4510 2011-06-22 Leo Liu <sdl.web@gmail.com>
4512 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4513 Move to minibuffer.el.
4515 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4517 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4518 The following patches are for when GLYPH_DEBUG && !XASSERT.
4519 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4520 * dispnew.c (flush_stdout):
4521 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4522 Mark as externally visible.
4523 * dispnew.c (check_window_matrix_pointers): Now static.
4524 * dispnew.c (window_to_frame_vpos):
4525 * xfns.c (unwind_create_frame):
4526 * xterm.c (x_check_font): Remove unused local.
4527 * scroll.c (CHECK_BOUNDS):
4528 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4529 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4530 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4531 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4532 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4534 (debug_method_add): Use va_list and vsprintf rather than relying
4535 on undefined behavior with wrong number of arguments.
4536 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4537 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4538 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4539 since we're not interested in debugging glyphs with old libraries.
4540 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4541 GCC 4.6.0's static checking.
4543 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4545 Integer overflow and signedness fixes (Bug#8873).
4546 A few related buffer overrun fixes, too.
4548 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4550 * dispextern.h (struct face.stipple):
4551 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4552 (x_bitmap_mask, x_allocate_bitmap_record)
4553 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4554 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4555 (x_create_bitmap_from_xpm_data):
4556 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4557 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4559 * xfaces.c (load_pixmap):
4560 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4561 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4562 (.bitmaps_last, struct x_output.icon_bitmap):
4563 Use ptrdiff_t, not int, for bitmap indexes.
4564 (x_allocate_bitmap_record): Check for size overflow.
4565 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4567 Use ptrdiff_t, not int, for overlay counts.
4568 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4569 * editfns.c (overlays_around, get_pos_property):
4570 * textprop.c (get_char_property_and_overlay):
4571 * xdisp.c (next_overlay_change, note_mouse_highlight):
4572 * xfaces.c (face_at_buffer_position):
4573 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4574 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4575 (Fnext_overlay_change, Fprevious_overlay_change)
4576 (mouse_face_overlay_overlaps, Foverlays_in):
4577 Use ptrdiff_t, not int, for sizes.
4578 (overlays_at, overlays_in): Check for size-calculation overflow.
4580 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4582 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4583 (x_session_initialize): Do not assume string length fits in int.
4585 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4586 This is unlikely, but can occur if DPI is outlandish.
4588 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4589 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4591 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4592 * xrdb.c (magic_file_p, search_magic_path):
4593 Omit last arg SUFFIX; it was always 0. All callers changed.
4594 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4596 * xfont.c (xfont_match): Avoid need for strlen.
4598 * xfns.c: Don't assume strlen fits in int.
4599 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4601 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4602 not unsigned long, as we prefer signed integers. All callers changed.
4603 Detect integer overflow in repeat count.
4604 (message_dolog): Don't assume print length fits in 39 bytes.
4605 (display_mode_element): Don't assume strlen fits in int.
4607 * termcap.c: Don't assume sizes fit in int and never overflow.
4608 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4609 (gobble_line): Check for size-calculation overflow.
4611 * minibuf.c (Fread_buffer):
4612 * lread.c (intern, intern_c_string):
4613 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4614 Don't assume string length fits in int.
4616 * keyboard.c (parse_tool_bar_item):
4617 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4619 * font.c: Don't assume string length fits in int.
4620 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4621 Use ptrdiff_t, not int.
4622 (font_intern_prop): Don't assume string length fits in int.
4623 Don't assume integer property fits in fixnum.
4624 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4626 * filelock.c: Fix some buffer overrun and integer overflow issues.
4627 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4628 Reformulate so as not to need the command string.
4629 Invoke gzip -cd rather than gunzip, as it's more portable.
4630 (lock_info_type, lock_file_1, lock_file):
4631 Don't assume pid_t and time_t fit in unsigned long.
4632 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4633 (current_lock_owner): Prefer signed type for sizes.
4634 Use memcpy, not strncpy, where memcpy is what is really wanted.
4635 Don't assume (via atoi) that time_t and pid_t fit in int.
4636 Check for time_t and/or pid_t out of range, e.g., via a network share.
4637 Don't alloca where an auto var works fine.
4639 * fileio.c: Fix some integer overflow issues.
4640 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4641 Don't assume string length fits in int.
4642 (directory_file_name): Don't assume string length fits in long.
4643 (make_temp_name): Don't assume pid fits in int, or that its print
4644 length is less than 20.
4646 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4648 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4650 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4652 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4653 We prefer signed integers, even for size calculations.
4655 * emacs.c: Don't assume string length fits in 'int'.
4656 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4657 (main): Don't invoke strlen when not needed.
4659 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4660 (XD_DEBUG_MESSAGE): Don't waste a byte.
4662 * callproc.c (getenv_internal_1, getenv_internal)
4664 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4666 * lread.c (invalid_syntax): Omit length argument.
4667 All uses changed. This doesn't fix a bug, but it simplifies the
4668 code away from its former Hollerith-constant appearance, and it's
4669 one less 'int' to worry about when looking at integer-overflow issues.
4670 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4672 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4673 This didn't break anything, but it didn't help either.
4674 It's confusing to put a bogus integer in a place where the actual
4675 value does not matter.
4676 (LIST_END_P): Remove unused macro and its bogus comment.
4677 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4679 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4680 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4682 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4683 We prefer signed types, and the value cannot exceed the EMACS_INT
4684 range anyway (because otherwise the length would not be representable).
4685 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4686 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4687 This avoids a GCC warning when WIDE_EMACS_INT.
4689 * indent.c (sane_tab_width): New function.
4690 (current_column, scan_for_column, Findent_to, position_indentation)
4691 (compute_motion): Use it. This is just for clarity.
4692 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4694 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4696 * lisp.h (lint_assume): New macro.
4697 * composite.c (composition_gstring_put_cache):
4698 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4700 * editfns.c, insdel.c:
4701 Omit unnecessary forward decls, to simplify future changes.
4703 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4705 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4707 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4708 Use much-faster test for byte-length change.
4709 Don't assume string byte-length fits in 'int'.
4710 Check that character arg fits in 'int'.
4711 (mapcar1): Declare byte as byte, for clarity.
4713 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4715 * fns.c (concat): Catch string overflow earlier.
4716 Do not rely on integer wraparound.
4718 * dispextern.h (struct it.overlay_strings_charpos)
4719 (struct it.selective): Now EMACS_INT, not int.
4720 * xdisp.c (forward_to_next_line_start)
4721 (back_to_previous_visible_line_start)
4722 (reseat_at_next_visible_line_start, next_element_from_buffer):
4723 Don't arbitrarily truncate the value of 'selective' to int.
4725 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4727 * composite.c: Don't truncate sizes to 'int'.
4728 (composition_gstring_p, composition_reseat_it)
4729 (composition_adjust_point): Use EMACS_INT, not int.
4730 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4731 not EMACS_UINT, for indexes.
4733 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4735 * buffer.c: Include <verify.h>.
4736 (struct sortvec.priority, struct sortstr.priority):
4737 Now EMACS_INT, not int.
4738 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4739 (struct sortstr.size, record_overlay_string)
4740 (struct sortstrlist.size, struct sortlist.used):
4741 Don't truncate size to int.
4742 (record_overlay_string): Check for size-calculation overflow.
4743 (init_buffer_once): Check at compile-time, not run-time.
4745 2011-06-22 Jim Meyering <meyering@redhat.com>
4747 Don't leak an XBM-image-sized buffer
4748 * image.c (xbm_load): Free the image buffer after using it.
4750 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4753 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4754 that Sun C diagnosed.
4755 * fns.c (secure_hash): Fix pointer signedness issue.
4756 * intervals.c (static_offset_intervals): New function.
4757 (offset_intervals): Use it.
4759 2011-06-21 Leo Liu <sdl.web@gmail.com>
4762 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4765 * fns.c (secure_hash): Rename from crypto_hash_function and change
4766 the first arg to accept symbols.
4767 (Fsecure_hash): New primitive.
4768 (syms_of_fns): New symbols.
4770 2011-06-20 Deniz Dogan <deniz@dogan.se>
4772 * process.c (Fset_process_buffer): Clarify return value in
4775 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4777 * dispnew.c (add_window_display_history): Use BVAR.
4779 * xdisp.c (debug_method_add): Use BVAR.
4780 (check_window_end, dump_glyph_matrix, dump_glyph)
4781 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4783 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4786 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4787 check till after the cache is created in init_frame_faces.
4789 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4791 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4793 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4795 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4796 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4797 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4799 Improve buffer-overflow checking (Bug#8873).
4800 * fileio.c (Finsert_file_contents):
4801 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4802 Remove the old (too-loose) buffer overflow checks.
4803 They weren't needed, since make_gap checks for buffer overflow.
4804 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4805 The old code merely checked for Emacs fixnum overflow, and relied
4806 on undefined (wraparound) behavior. The new code avoids undefined
4807 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4809 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4810 Tune. Don't use wider integers than needed. Don't use alloca.
4811 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4813 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4815 * insdel.c, lisp.h (buffer_overflow): New function.
4816 (insert_from_buffer_1, replace_range, replace_range_2):
4817 * insdel.c (make_gap_larger):
4818 * editfns.c (Finsert_char):
4819 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4821 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4823 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4825 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4827 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4828 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4830 * fileio.c: Don't assume EMACS_INT fits in off_t.
4831 (emacs_lseek): New static function.
4832 (Finsert_file_contents, Fwrite_region): Use it.
4833 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4835 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4837 * fns.c: Don't overflow int when computing a list length.
4838 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4839 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4840 truncation on 64-bit hosts. Check for QUIT every
4841 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4842 faster and is responsive enough.
4843 (Flength): Report an error instead of overflowing an integer.
4844 (Fsafe_length): Return a float if the value is not representable
4845 as a fixnum. This shouldn't happen except in contrived situations.
4846 (Fnthcdr, Fsort): Don't assume list length fits in int.
4847 (Fcopy_sequence): Don't assume vector length fits in int.
4849 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4850 (header_size, word_size): New constants.
4851 (allocate_vectorlike): Don't check size overflow here.
4852 (allocate_vector): Check it here instead, since this is the only
4853 caller of allocate_vectorlike that could cause overflow.
4854 Check that the new vector's length is representable as a fixnum.
4856 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4857 The previous code was bogus. For example, next_almost_prime (32)
4858 returned 39, which is undesirable as it is a multiple of 3; and
4859 next_almost_prime (24) returned 25, which is a multiple of 5 so
4860 why was the code bothering to check for multiples of 7?
4862 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4864 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4866 Variadic C functions now count arguments with ptrdiff_t.
4867 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4868 Back then I didn't know that the Emacs coding style prefers signed int.
4869 Also, in the meantime I found a few more instances where arguments
4870 were being counted with int, which may truncate counts on 64-bit
4871 machines, or EMACS_INT, which may be unnecessarily wide.
4872 * lisp.h (struct Lisp_Subr.function.aMANY)
4873 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4874 Arg counts are now ptrdiff_t, not size_t.
4875 All variadic functions and their callers changed accordingly.
4876 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4877 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4878 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4879 * callint.c (Fcall_interactively): Check arg count for overflow,
4880 to avoid potential buffer overrun. Use signed char, not 'int',
4881 for 'varies' array, so that we needn't bother to check its size
4882 calculation for overflow.
4883 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4884 * eval.c (apply_lambda):
4885 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4886 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4887 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4889 * callint.c (Fcall_interactively): Don't use index var as event count.
4891 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4892 * mem-limits.h (SIZE): Remove; no longer used.
4894 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4896 Remove unnecessary casts.
4897 * xterm.c (x_term_init):
4898 * xfns.c (x_set_border_pixel):
4899 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4900 These aren't needed now that we assume ANSI C.
4902 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4903 It's more likely to cause problems (due to unsigned overflow)
4906 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4908 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4910 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4912 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4914 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4916 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4918 GLYPH_CODE_FACE returns EMACS_INT, not int.
4919 * dispextern.h (merge_faces):
4920 * xfaces.c (merge_faces):
4921 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4922 Don't assume EMACS_INT fits in int.
4924 * character.h (CHAR_VALID_P): Remove unused parameter.
4925 * fontset.c, lisp.h, xdisp.c: All uses changed.
4927 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4929 * fns.c (concat): Minor tuning based on overflow analysis.
4930 This doesn't fix any bugs. Use int to hold character, instead
4931 of constantly refetching from Emacs object. Use XFASTINT, not
4932 XINT, for value known to be a character. Don't bother comparing
4933 a single byte to 0400, as it's always less.
4935 * floatfns.c (Fexpt):
4936 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4938 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4941 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4943 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4944 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4945 incorrectly succeed when S was a string, because 4294967386 was
4946 truncated before it was used.
4948 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4949 Otherwise, an out-of-range integer could cause undefined behavior
4952 * composite.c: Use int, not EMACS_INT, for characters.
4953 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4954 EMACS_INT, for values that are known to be in character range.
4955 This doesn't fix any bugs but is the usual style inside Emacs and
4956 may generate better code on 32-bit machines.
4958 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4959 This is for reasons similar to the recent CHAR_STRING fix.
4960 * charset.c (Fencode_char): Check that character arg is actually
4961 a character. Pass an int to ENCODE_CHAR.
4962 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4963 wider than 'int', as a compile-time check to prevent future regressions
4966 * character.c (char_string): Remove unnecessary casts.
4968 Make sure a 64-bit char is never passed to CHAR_STRING.
4969 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4970 by silently ignoring the top 32 bits, allowing some values
4971 that were far too large to be valid characters.
4972 * character.h: Include <verify.h>.
4973 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4974 arguments are no wider than unsigned, as a compile-time check
4975 to prevent future regressions in this area.
4977 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4978 (Fsubst_char_in_region):
4980 * xdisp.c (decode_mode_spec_coding):
4981 Adjust to CHAR_STRING's new requirement.
4982 * editfns.c (Finsert_char, Fsubst_char_in_region):
4983 * fns.c (concat): Check that character args are actually
4984 characters. Without this test, these functions did the wrong
4985 thing with wildly out-of-range values on 64-bit hosts.
4987 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4988 These casts should not be needed on 32-bit hosts, either.
4989 * keyboard.c (read_char):
4990 * lread.c (Fload): Remove casts to unsigned.
4992 * lisp.h (UNSIGNED_CMP): New macro.
4993 This fixes comparison bugs on 64-bit hosts.
4994 (ASCII_CHAR_P): Use it.
4995 * casefiddle.c (casify_object):
4996 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4997 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4998 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4999 * dispextern.h (FACE_FROM_ID):
5000 * keyboard.c (read_char): Use UNSIGNED_CMP.
5002 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5003 not to EMACS_INT, to avoid GCC warning.
5005 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5007 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5008 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5009 isn't needed on 32-bit machines.
5011 * buffer.c (Fgenerate_new_buffer_name):
5012 Use EMACS_INT for count, not int.
5013 (advance_to_char_boundary): Return EMACS_INT, not int.
5015 * data.c (Qcompiled_function): Now static.
5017 * window.c (window_body_lines): Now static.
5019 * image.c (gif_load): Rename local to avoid shadowing.
5021 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5022 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5023 * alloc.c (make_save_value): Integer argument is now of type
5025 (mark_object): Use ptrdiff_t, not int.
5026 * lisp.h (pD): New macro.
5027 * print.c (print_object): Use it.
5029 * alloc.c: Use EMACS_INT, not int, to count objects.
5030 (total_conses, total_markers, total_symbols, total_vector_size)
5031 (total_free_conses, total_free_markers, total_free_symbols)
5032 (total_free_floats, total_floats, total_free_intervals)
5033 (total_intervals, total_strings, total_free_strings):
5034 Now EMACS_INT, not int. All uses changed.
5035 (Fgarbage_collect): Compute overall total using a double, so that
5036 integer overflow is less likely to be a problem. Check for overflow
5037 when converting back to an integer.
5038 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5039 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5040 These were 'int' variables that could overflow on 64-bit hosts;
5041 they were never used, so remove them instead of repairing them.
5042 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5043 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5044 Previously, this ceilinged at INT_MAX, but that doesn't work on
5046 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5048 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5049 (allocate_vectorlike): Check for ptrdiff_t overflow.
5050 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5051 when a (possibly-narrower) signed value would do just as well.
5052 We prefer using signed arithmetic, to avoid comparison confusion.
5054 * alloc.c: Catch some string size overflows that we were missing.
5055 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5056 for convenience in STRING_BYTES_MAX.
5057 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5058 The definition here is exact; the one in lisp.h was approximate.
5059 (allocate_string_data): Check for string overflow. This catches
5060 some instances we weren't catching before. Also, it catches
5061 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5062 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5063 and ptrdiff_t and EMACS_INT are both 64 bits.
5065 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5066 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5067 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5069 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5071 * alloc.c (Fmake_string): Check for out-of-range init.
5073 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5075 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5077 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5079 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5080 xg_get_default_scrollbar_width.
5082 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5083 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5084 (style_changed_cb): Call update_theme_scrollbar_width and call
5085 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5086 all frames (Bug#8505).
5087 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5088 Call gtk_window_set_resizable if HAVE_GTK3.
5089 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5090 and height if HAVE_GTK3 (Bug#8505).
5091 (scroll_bar_width_for_theme): New variable.
5092 (update_theme_scrollbar_width): New function.
5093 (xg_get_default_scrollbar_width): Move code to
5094 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5095 (xg_initialize): Call update_theme_scrollbar_width.
5097 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5099 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5101 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5103 * frame.c (make_frame): Call other_buffer_safely instead of
5106 * window.c (temp_output_buffer_show): Call display_buffer with
5107 second argument Vtemp_buffer_show_specifiers and reset latter
5108 immediately after the call.
5109 (Vtemp_buffer_show_specifiers): New variable.
5110 (auto_window_vscroll_p, next_screen_context_lines)
5111 (Vscroll_preserve_screen_position): Remove leading asterisks from
5114 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5116 Fix minor problems found by GCC 4.6.0 static checking.
5117 * buffer.c (Qclone_number): Remove for now, as it's unused.
5118 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5119 (record_buffer): Remove unused local.
5120 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5121 (set_frame_buffer_list): Remove; unused.
5122 * frame.h (other_visible_frames): Remove decl.
5123 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5124 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5125 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5127 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5128 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5129 Define only if HAVE_GPM.
5130 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5131 (update_hints_inhibit): Remove; never set. All uses removed.
5132 * widgetprv.h (emacsFrameClassRec): Remove decl.
5133 * window.c (delete_deletable_window): Now returns void, since it
5134 wasn't returning anything.
5135 (compare_window_configurations): Remove unused locals.
5136 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5137 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5138 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5139 the same widths as pointers. This follows up on the 2011-05-06 patch.
5140 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5141 * xterm.h: Likewise.
5142 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5144 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5146 * makefile.w32-in: Update dependencies.
5147 (LISP_H): Add lib/intprops.h.
5149 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5151 * image.c (gif_load): Add animation frame delay to the metadata.
5152 (syms_of_image): Use DEFSYM. New symbol `delay'.
5154 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5156 * window.c (delete_deletable_window): Re-add.
5157 (Fset_window_configuration): Rewrite to handle dead buffers and
5158 consequently deletable windows.
5159 (window_tree, Fwindow_tree): Remove. Supply functionality in
5161 (compare_window_configurations): Simplify code.
5163 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5165 * image.c (imagemagick_load_image): Fix type mismatch.
5166 (Fimagemagick_types): Likewise.
5168 * window.h (replace_buffer_in_windows): Declare.
5170 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5172 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5173 Qclone_number. Remove external declaration of Qdelete_window.
5174 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5176 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5177 Run Qbuffer_list_update_hook if allowed.
5178 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5179 buffer list implementation.
5180 (other_buffer_safely): New function.
5181 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5182 calls to replace_buffer_in_windows and
5183 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5185 (record_buffer): Inhibit quitting and rewrite using quittable
5186 functions. Run Qbuffer_list_update_hook if allowed.
5187 (Frecord_buffer, Funrecord_buffer): New functions.
5188 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5189 Move switch-to-buffer to window.el.
5190 (bury-buffer): Move to window.el.
5191 (Vbuffer_list_update_hook): New variable.
5193 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5196 * window.h (resize_frame_windows): Move up in code.
5197 (Fwindow_frame): Remove EXFUN.
5198 (replace_buffer_in_all_windows): Remove prototype.
5199 (replace_buffer_in_windows_safely): Add prototype.
5201 * window.c: Declare Qdelete_window static again. Move down
5202 declaration of select_count.
5203 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5204 (Fother_window): Move to window.el.
5205 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5206 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5207 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5209 (replace_buffer_in_windows): Implement by calling
5210 Qreplace_buffer_in_windows.
5211 (replace_buffer_in_all_windows): Remove with some functionality
5212 moved into replace_buffer_in_windows_safely.
5213 (replace_buffer_in_windows_safely): New function.
5214 (select_window_norecord, select_frame_norecord): Move in front
5215 of run_window_configuration_change_hook. Remove now obsolete
5217 (Fset_window_buffer): Rewrite doc-string.
5218 Call Qrecord_window_buffer.
5219 (keys_of_window): Move binding for other-window to window.el.
5221 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5223 * dispextern.h (struct image): Replace data member, whose int_val
5224 and ptr_val fields were not used by anything, with a single
5227 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5228 (gif_clear_image, gif_load, imagemagick_load_image)
5229 (gs_clear_image, gs_load): Callers changed.
5231 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5233 * buffer.h: Include <time.h>, for time_t.
5234 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5236 Fix minor problems found by static checking.
5238 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5240 Make identifiers static if they are not used in other modules.
5241 * data.c (Qcompiled_function, Qframe, Qvector):
5242 * image.c (QimageMagick, Qsvg):
5243 * minibuf.c (Qmetadata):
5244 * window.c (resize_window_check, resize_root_window): Now static.
5245 * window.h (resize_window_check, resize_root_window): Remove decls.
5247 * window.c (window_deletion_count, delete_deletable_window):
5249 (window_body_lines): Now static.
5250 (Fdelete_other_windows_internal): Mark vars as initialized.
5251 Make sure 'resize_failed' is initialized.
5252 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5253 (resize_window_apply): Remove unused local.
5254 * window.h (delete_deletable_window): Remove decl.
5256 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5257 (imagemagick_load_image): Fix pointer signedness problem by changing
5258 last arg from unsigned char * to char *. All uses changed.
5259 Also, fix a local for similar reasons.
5260 Remove unused locals. Remove locals to avoid shadowing.
5261 (fn_rsvg_handle_free): Remove; unused.
5262 (svg_load, svg_load_image): Fix pointer signedness problem.
5263 (imagemagick_load_image): Don't use garbage pointer image_wand.
5265 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5267 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5269 * image.c (gif_load): Fix omitted cast error introduced by
5272 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5274 * window.h (resize_proportionally, orig_total_lines)
5275 (orig_top_line): Remove from window structure.
5276 (set_window_height, set_window_width, change_window_heights)
5277 (Fdelete_window): Remove prototypes.
5278 (resize_frame_windows): Remove duplicate declaration.
5280 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5282 * window.h (resize_frame_windows, resize_window_check)
5283 (delete_deletable_window, resize_root_window)
5284 (resize_frame_windows): Declare prototypes.
5286 * window.c (resize_window_apply): Make definition be "static" to
5287 match the prototype.
5289 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5291 * window.c: Remove declarations of Qwindow_size_fixed,
5292 window_min_size_1, window_min_size_2, window_min_size,
5293 size_window, window_fixed_size_p, enlarge_window, delete_window.
5294 Remove static from declaration of Qdelete_window, it's
5295 temporarily needed by Fbury_buffer.
5296 (replace_window): Don't assign orig_top_line and
5298 (Fdelete_window, delete_window): Remove. Window deletion is
5299 handled by window.el.
5300 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5301 Replace Fdelete_window calls with calls to Qdelete_window.
5302 (Fdelete_other_windows): Remove. Deleting other windows is
5303 handled by window.el.
5304 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5305 handled in window.el.
5306 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5307 Window minimum sizes are handled in window.el.
5308 (shrink_windows, size_window, set_window_height)
5309 (set_window_width, change_window_heights, window_height)
5310 (window_width, CURBEG, CURSIZE, enlarge_window)
5311 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5312 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5313 handled in window.el.
5314 (make_dummy_parent): Rename to make_parent_window and give it a
5315 second argument horflag.
5316 (make_window): Don't set resize_proportionally any more.
5317 (Fsplit_window): Remove. Windows are split in window.el.
5318 (save_restore_action, save_restore_orig_size)
5319 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5320 Resize mini windows in window.el.
5321 (grow_mini_window, shrink_mini_window): Implement by calling
5322 Qresize_root_window_vertically, resize_window_check and
5323 resize_window_apply.
5324 (saved_window, Fset_window_configuration, save_window_save):
5325 Do not handle orig_top_line, orig_total_lines, and
5326 resize_proportionally.
5327 (window_min_height, window_min_width): Move to window.el.
5328 (keys_of_window): Move bindings for delete-other-windows,
5329 split-window, delete-window and enlarge-window to window.el.
5331 * buffer.c: Temporarily extern Qdelete_window.
5332 (Fbury_buffer): Temporarily call Qdelete_window instead of
5333 Fdelete_window (Fbury_buffer will move to window.el soon).
5335 * frame.c (set_menu_bar_lines_1): Remove code handling
5336 orig_top_line and orig_total_lines.
5338 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5339 set_window_height but set heights directly.
5340 (change_frame_size_1): Use resize_frame_windows.
5342 * xdisp.c (init_xdisp): Don't use set_window_height but set
5345 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5346 Use resize_frame_windows instead of change_window_heights and run
5347 run_window_configuration_change_hook.
5349 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5350 instead of change_window_heights and run
5351 run_window_configuration_change_hook.
5353 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5355 * window.c (replace_window): Rename second argument REPLACEMENT to
5356 NEW. New third argument SETFLAG. Rewrite.
5357 (delete_window, make_dummy_parent): Call replace_window with
5359 (window_list_1): Move down in code.
5360 (run_window_configuration_change_hook): Move set_buffer part
5361 before select_frame_norecord part in order to unwind correctly.
5362 Rename count1 to count.
5363 (recombine_windows, delete_deletable_window, resize_root_window)
5364 (Fdelete_other_windows_internal)
5365 (Frun_window_configuration_change_hook, make_parent_window)
5366 (resize_window_check, resize_window_apply, Fresize_window_apply)
5367 (resize_frame_windows, Fsplit_window_internal)
5368 (Fdelete_window_internal, Fresize_mini_window_internal):
5370 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5372 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5374 * window.h (window): Add some new members to window structure -
5375 normal_lines, normal_cols, new_total, new_normal, clone_number,
5376 splits, nest, prev_buffers, next_buffers.
5377 (WINDOW_TOTAL_SIZE): Move here from window.c.
5378 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5380 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5382 (make_dummy_parent): Set new members of windows structure.
5383 (make_window): Move down in code. Handle new members of window
5385 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5386 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5387 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5388 (Fset_window_prev_buffers, Fwindow_next_buffers)
5389 (Fset_window_next_buffers, Fset_window_clone_number):
5391 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5392 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5394 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5395 Argument WINDOW can be now internal window too.
5396 (Fwindow_use_time): Move up in code.
5397 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5399 (Fset_window_configuration, saved_window)
5400 (Fcurrent_window_configuration, save_window_save): Handle new
5401 members of window structure.
5402 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5403 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5404 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5405 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5406 Qget_mru_window, Qresize_root_window,
5407 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5408 Qauto_buffer_name; staticpro them.
5410 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5412 * window.c (Fwindow_total_size, Fwindow_left_column)
5413 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5414 (Fwindow_list_1): New functions.
5415 (window_box_text_cols): Replace with window_body_cols.
5416 (Fwindow_width, Fscroll_left, Fscroll_right):
5417 Use window_body_cols instead of window_box_text_cols.
5418 (delete_window, Fset_window_configuration):
5419 Call delete_all_subwindows with window as argument.
5420 (delete_all_subwindows): Take a window as argument and not a
5422 (window_loop): Remove handling of GET_LRU_WINDOW and
5424 (Fget_lru_window, Fget_largest_window): Move to window.el.
5426 * window.h: Extern window_body_cols instead of
5427 window_box_text_cols. delete_all_subwindows now takes a
5428 Lisp_Object as argument.
5430 * indent.c (compute_motion, Fcompute_motion):
5431 Use window_body_cols instead of window_box_text_cols.
5433 * frame.c (delete_frame): Call delete_all_subwindows with root
5436 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5438 * fns.c (Fputhash): Document return value.
5440 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5442 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5444 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5446 Cons<->int and similar integer overflow fixes (Bug#8794).
5448 Check for overflow when converting integer to cons and back.
5449 * charset.c (Fdefine_charset_internal, Fdecode_char):
5450 Use cons_to_unsigned to catch overflow.
5451 (Fencode_char): Use INTEGER_TO_CONS.
5452 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5453 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5454 * data.c (long_to_cons, cons_to_long): Remove.
5455 (cons_to_unsigned, cons_to_signed): New functions.
5456 These signal an error for invalid or out-of-range values.
5457 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5458 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5459 * font.c (Ffont_variation_glyphs):
5460 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5461 * lisp.h: Include <intprops.h>.
5462 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5463 (cons_to_signed, cons_to_unsigned): New decls.
5464 (long_to_cons, cons_to_long): Remove decls.
5465 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5466 (Fprimitive_undo): Use CONS_TO_INTEGER.
5467 * xfns.c (Fx_window_property): Likewise.
5468 * xselect.c: Include <limits.h>.
5469 (x_own_selection, selection_data_to_lisp_data):
5470 Use INTEGER_TO_CONS.
5471 (x_handle_selection_request, x_handle_selection_clear)
5472 (x_get_foreign_selection, Fx_disown_selection_internal)
5473 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5474 (lisp_data_to_selection_data): Use cons_to_unsigned.
5475 (x_fill_property_data): Use cons_to_signed.
5476 Report values out of range.
5478 Check for buffer and string overflow more precisely.
5479 * buffer.h (BUF_BYTES_MAX): New macro.
5480 * lisp.h (STRING_BYTES_MAX): New macro.
5481 * alloc.c (Fmake_string):
5482 * character.c (string_escape_byte8):
5483 * coding.c (coding_alloc_by_realloc):
5484 * doprnt.c (doprnt):
5485 * editfns.c (Fformat):
5487 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5488 since they may not be the same number.
5489 * editfns.c (Finsert_char):
5490 * fileio.c (Finsert_file_contents):
5491 Likewise for BUF_BYTES_MAX.
5493 * image.c: Use ptrdiff_t, not int, for sizes.
5494 (slurp_file): Switch from int to ptrdiff_t.
5496 (slurp_file): Check that file size fits in both size_t (for
5497 malloc) and ptrdiff_t (for sanity and safety).
5499 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5500 if b->modtime has its maximal value.
5502 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5504 Don't assume time_t can fit into int.
5505 * buffer.h (struct buffer.modtime): Now time_t, not int.
5506 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5507 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5509 Minor fixes for signed vs unsigned integers.
5510 * character.h (MAYBE_UNIFY_CHAR):
5511 * charset.c (maybe_unify_char):
5512 * keyboard.c (read_char, reorder_modifiers):
5513 XINT -> XFASTINT, since the integer must be nonnegative.
5514 * ftfont.c (ftfont_spec_pattern):
5515 * keymap.c (access_keymap, silly_event_symbol_error):
5516 XUINT -> XFASTINT, since the integer must be nonnegative.
5517 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5518 since it makes no difference and we prefer signed.
5519 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5520 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5523 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5525 * window.h (Fwindow_frame): Declare.
5527 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5529 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5530 (SPARE_MEMORY): Always define.
5531 (LARGE_REQUEST): Remove.
5532 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5534 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5536 * lisp.h: Move EXFUNS for Fframe_root_window,
5537 Fframe_first_window and Fset_frame_selected_window to window.h.
5539 * window.h: Move EXFUNS for Fframe_root_window,
5540 Fframe_first_window and Fset_frame_selected_window here from
5543 * frame.c (Fwindow_frame, Fframe_first_window)
5544 (Fframe_root_window, Fframe_selected_window)
5545 (Fset_frame_selected_window): Move to window.c.
5546 (Factive_minibuffer_window): Move to minibuf.c.
5547 (Fother_visible_frames_p): New function.
5549 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5551 * window.c (decode_window, decode_any_window): Move up in code.
5552 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5553 (inhibit_frame_unsplittable): Remove unused variable.
5554 (Fwindow_buffer): Move up and rewrite doc-string.
5555 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5556 (Fwindow_prev): New functions.
5557 (Fwindow_frame): Move here from frame.c. Accept any window as
5559 (Fframe_root_window, Fframe_first_window)
5560 (Fframe_selected_window): Move here from frame.c. Accept frame
5561 or arbitrary window as argument. Update doc-strings.
5562 (Fminibuffer_window): Move up in code.
5563 (Fwindow_minibuffer_p): Move up in code and simplify.
5564 (Fset_frame_selected_window): Move here from frame.c.
5566 (Fselected_window, select_window, Fselect_window): Move up in
5567 code. Minor doc-string fixes.
5569 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5571 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5572 Do not assume that spare memory exists; that assumption is valid
5573 only if SYSTEM_MALLOC.
5574 (LARGE_REQUEST): New macro, so that the issue of large requests
5575 is separated from the issue of spare memory.
5577 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5579 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5582 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5584 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5587 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5589 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5591 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5593 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5594 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5596 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5598 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5600 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5602 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5603 (x_clipboard_manager_save): Add return value.
5604 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5606 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5607 Obey Vx_select_enable_clipboard_manager. Catch errors in
5608 x_clipboard_manager_save (Bug#8779).
5609 (Vx_select_enable_clipboard_manager): New variable.
5610 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5612 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5614 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5616 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5618 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5619 in the current matrix if keep_current_p is non-zero.
5621 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5623 * bidi.c (bidi_level_of_next_char): Fix last change.
5625 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5627 Support bidi reordering of text covered by display properties.
5629 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5630 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5631 (bidi_cache_search, bidi_cache_iterator_state)
5632 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5633 (bidi_level_of_next_char, bidi_move_to_visually_next):
5634 Support character positions inside a run of characters covered by a
5636 (bidi_paragraph_init, bidi_resolve_explicit_1)
5637 (bidi_level_of_next_char): Call bidi_fetch_char and
5638 bidi_fetch_char_advance instead of FETCH_CHAR and
5640 (bidi_init_it): Initialize new members.
5641 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5643 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5644 instead of using explicit *_CHAR codes.
5645 (bidi_resolve_explicit, bidi_resolve_weak):
5646 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5647 bidirectional text is supported only in multibyte buffers.
5648 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5649 it to initialize the frame_window_p member of struct bidi_it.
5650 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5651 (bidi_resolve_explicit, bidi_resolve_weak)
5652 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5653 bidi_it->nchars is non-positive.
5654 (bidi_level_of_next_char): Don't try to lookup the cache for the
5655 next/previous character if nothing is cached there yet, or if we
5656 were just reseat()'ed to a new position.
5658 * xdisp.c (set_cursor_from_row): Set start and stop points
5659 according to the row's direction when priming the loop that looks
5660 for the glyph on which to display cursor.
5661 (single_display_spec_intangible_p): Function deleted.
5662 (display_prop_intangible_p): Reimplement to call
5663 handle_display_spec instead of single_display_spec_intangible_p.
5664 Accept 3 additional arguments needed by handle_display_spec.
5665 This fixes incorrect cursor motion across display property with complex
5666 values: lists, `(when COND...)' forms, etc.
5667 (single_display_spec_string_p): Support property values that are
5668 lists with the argument STRING its top-level element.
5669 (display_prop_string_p): Fix the condition for processing a
5670 property that is a list to be consistent with handle_display_spec.
5671 (handle_display_spec): New function, refactored from the
5672 last portion of handle_display_prop.
5673 (compute_display_string_pos): Accept additional argument
5674 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5675 value of a `display' property is a "replacing spec".
5676 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5677 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5678 the display property, but just return a value indicating whether
5679 the display property will replace the characters it covers.
5680 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5681 frame_window_p members of struct bidi_it.
5682 (compute_display_string_pos, compute_display_string_end):
5684 (push_it): Accept second argument POSITION, where pop_it should
5685 jump to continue iteration.
5686 (reseat_1): Initialize bidi_it.disp_pos.
5688 * keyboard.c (adjust_point_for_property): Adjust the call to
5689 display_prop_intangible_p to its new signature.
5691 * dispextern.h (struct bidi_it): New member frame_window_p.
5692 (bidi_init_it): Update prototypes.
5693 (display_prop_intangible_p): Update prototype.
5694 (compute_display_string_pos, compute_display_string_end):
5696 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5699 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5701 Malloc failure behavior now depends on size of allocation.
5702 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5703 * lisp.h: Change signatures accordingly.
5704 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5705 All callers changed. (Bug#8762)
5707 * gnutls.c: Use Emacs's memory allocators.
5708 Without this change, the gnutls library would invoke malloc etc.
5709 directly, which causes problems on non-SYNC_INPUT hosts, and which
5710 runs afoul of improving memory_full behavior. (Bug#8761)
5711 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5712 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5713 xfree instead of the default malloc, realloc, free.
5714 (Fgnutls_boot): No need to check for memory allocation failure,
5715 since xmalloc does that for us.
5717 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5718 * category.c (hash_get_category_set):
5719 * ccl.c (ccl_driver):
5720 * charset.c (Fdefine_charset_internal):
5721 * charset.h (struct charset.hash_index):
5722 * composite.c (get_composition_id, gstring_lookup_cache)
5723 (composition_gstring_put_cache):
5724 * composite.h (struct composition.hash_index):
5725 * dispextern.h (struct image.hash):
5726 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5727 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5728 (hashfn_equal, hashfn_user_defined, make_hash_table)
5729 (maybe_resize_hash_table, hash_lookup, hash_put)
5730 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5731 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5732 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5733 * image.c (make_image, search_image_cache, lookup_image)
5734 (xpm_put_color_table_h):
5735 * lisp.h (struct Lisp_Hash_Table):
5736 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5737 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5738 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5739 * alloc.c (allocate_vectorlike):
5740 Check for overflow in vector size calculations.
5741 * ccl.c (ccl_driver):
5742 Check for overflow when converting EMACS_INT to int.
5743 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5744 need to be updated by these changes.
5745 * fns.c (make_hash_table, maybe_resize_hash_table):
5746 Check for integer overflow with large hash tables.
5747 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5748 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5749 (SXHASH_REDUCE): New macro.
5750 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5751 Use it instead of discarding useful hash info with large hash values.
5752 (sxhash_float): New function.
5753 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5754 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5755 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5756 Rewrite to use FIXNUM_BITS, as this simplifies things.
5757 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5758 Adjust signatures to match updated version of code.
5759 (consing_since_gc): Now EMACS_INT, since a single hash table can
5760 use more than INT_MAX bytes.
5762 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5764 Make it possible to build with GCC-4.6+ -O2 -flto.
5766 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5768 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5770 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5771 Call minibuffer-inactive-mode.
5773 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5775 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5776 Update dependencies.
5778 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5780 * data.c (init_data): Remove code for UTS, this system is not
5783 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5785 Don't force ./temacs to start in terminal mode.
5787 * frame.c (make_initial_frame): Initialize faces in all cases, not
5788 only when CANNOT_DUMP is defined.
5789 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5791 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5793 * dispnew.c (add_window_display_history): Use const for the string
5794 pointer. Remove declaration, not needed.
5796 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5798 Use 'inline', not 'INLINE'.
5799 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5800 * alloc.c, fontset.c (INLINE): Remove.
5801 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5802 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5803 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5804 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5805 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5807 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5809 Make it possible to run ./temacs.
5811 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5812 syms_of_callproc does the same thing. Remove test for
5813 "initialized", do it in the caller.
5814 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5816 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5818 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5819 (read_minibuf): Use get_minibuffer.
5820 (syms_of_minibuf): Use DEFSYM.
5821 (Qmetadata): New var.
5822 * data.c (Qbuffer): Don't make it static.
5823 (syms_of_data): Use DEFSYM.
5825 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5827 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5828 (CCL_CODE_MIN): New macro.
5830 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5832 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5834 * eval.c (Qdebug): Now static.
5835 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5836 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5837 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5839 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5841 * image.c: Various fixes to ImageMagick code comments.
5842 (Fimagemagick_types): Doc fix.
5844 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5846 Minor fixes prompted by GCC 4.6.0 warnings.
5848 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5850 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5851 (x_clipboard_manager_save_all): Move extern decl to ...
5852 * xterm.h: ... here, so that it can be checked for consistency.
5854 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5856 * xselect.c (x_clipboard_manager_save_frame)
5857 (x_clipboard_manager_save_all): New functions.
5858 (Fx_clipboard_manager_save): Lisp function deleted.
5860 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5861 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5863 * xterm.h: Update prototype.
5865 2011-05-28 William Xu <william.xwl@gmail.com>
5867 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5870 2011-05-28 Jim Meyering <meyering@redhat.com>
5872 Avoid a sign-extension bug in crypto_hash_function.
5873 * fns.c (to_uchar): Define.
5874 (crypto_hash_function): Use it to convert some newly-signed
5875 variables to unsigned, to avoid sign-extension bugs. For example,
5876 without this change, (md5 "truc") would evaluate to
5877 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5878 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5879 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5881 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5883 Integer overflow fixes.
5885 * dbusbind.c: Serial number integer overflow fixes.
5886 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5887 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5888 to hold a serial number that is too large for a fixnum.
5889 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5890 Check for serial numbers out of range. Decode any serial number
5891 that was so large that it became a float. (Bug#8722)
5893 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5894 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5895 Use XFASTINT rather than XUINT when numbers are nonnegative.
5896 (xd_append_arg, Fdbus_method_return_internal):
5897 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5898 arguments, check that Lisp number is nonnegative, rather than
5899 silently wrapping negative numbers around. (Bug#8722)
5900 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5903 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5905 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5907 ccl: Add integer overflow checks.
5908 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5909 (IN_INT_RANGE): New macros.
5910 (ccl_driver): Use them to check for integer overflow when
5911 decoding a CCL program. Many of the new checks are whether XINT (x)
5912 fits in int; it doesn't always, on 64-bit hosts. The new version
5913 doesn't catch all possible integer overflows, but it's an
5914 improvement. (Bug#8719)
5916 * alloc.c (make_event_array): Use XINT, not XUINT.
5917 There's no need for unsigned here.
5919 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5920 This follows up to the 2011-05-06 change that substituted uintptr_t
5921 for EMACS_INT. This case wasn't caught back then.
5923 Rework Fformat to avoid integer overflow issues.
5924 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5925 now (part of C89). Include <verify.h>.
5926 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5927 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5928 (Fformat): Avoid the prepass trying to compute sizes; it was only
5929 approximate and thus did not catch overflow reliably. Instead, walk
5930 through the format just once, formatting and computing sizes as we go,
5931 checking for integer overflow at every step, and allocating a larger
5932 buffer as needed. Keep track separately whether the format is
5933 multibyte. Keep only the most-recently calculated precision, rather
5934 than them all. Record whether each argument has been converted to
5935 string. Use EMACS_INT, not int, for byte and char and arg counts.
5936 Support field widths and precisions larger than INT_MAX. Avoid
5937 sprintf's undefined behavior with conversion specifications such as %#d
5938 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5939 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5940 formatting out-of-range floating point numbers with int
5943 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5945 * data.c: Avoid integer truncation in expressions involving floats.
5946 * data.c: Include <intprops.h>.
5947 (arith_driver): When there's an integer overflow in an expression
5948 involving floating point, convert the integers to floating point
5949 so that the resulting value does not suffer from catastrophic
5950 integer truncation. For example, on a 64-bit host (* 4
5951 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5952 Do not rely on undefined behavior after integer overflow.
5954 merge count_size_as_multibyte, parse_str_to_multibyte
5955 * character.c, character.h (count_size_as_multibyte):
5956 Rename from parse_str_to_multibyte; all uses changed.
5957 Check for integer overflow.
5958 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5959 since it's now a duplicate of the other. This is more of
5960 a character than a buffer op, so better that it's in character.c.
5961 * fns.c, print.c: Adjust to above changes.
5963 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5965 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5967 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5969 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5970 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5971 (x_clipboard_manager_save): Now static.
5972 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5974 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5975 (crypto_hash_function): Now static.
5976 Fix pointer signedness problems. Avoid unnecessary initializations.
5978 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5980 * termhooks.h (Vselection_alist): Make it terminal-local.
5982 * terminal.c (create_terminal): Initialize it.
5984 * xselect.c: Support for clipboard managers.
5985 (Vselection_alist): Move to termhooks.h as terminal-local var.
5986 (LOCAL_SELECTION): New macro.
5987 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5988 (symbol_to_x_atom): Remove gratuitous arg.
5989 (x_handle_selection_request, lisp_data_to_selection_data)
5990 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5991 (x_own_selection, x_get_local_selection, x_convert_selection):
5992 New arg, specifying work frame. Use terminal-local Vselection_alist.
5993 (some_frame_on_display): Delete unused function.
5994 (Fx_own_selection_internal, Fx_get_selection_internal)
5995 (Fx_disown_selection_internal, Fx_selection_owner_p)
5996 (Fx_selection_exists_p): New optional frame arg.
5997 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5998 (x_handle_selection_clear): Don't treat other terminals with the
5999 same keyboard specially. Use the terminal-local Vselection_alist.
6000 (x_clear_frame_selections): Use Frun_hook_with_args.
6002 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6004 * xterm.h: Add support for those atoms.
6006 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6008 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6009 (converted_selections, conversion_fail_tag): New global variables.
6010 (x_selection_request_lisp_error): Free the above.
6011 (x_get_local_selection): Remove unnecessary code.
6012 (x_reply_selection_request): Args changed; handle arbitrary array
6013 of converted selections stored in converted_selections.
6014 Separate the XChangeProperty and SelectionNotify steps.
6015 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6016 (x_convert_selection): New function.
6017 (x_handle_selection_event): Simplify.
6018 (x_get_foreign_selection): Don't ignore incoming requests while
6019 waiting for an answer; this will fail when we implement
6020 SAVE_TARGETS, and seems unnecessary anyway.
6021 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6022 (Vx_sent_selection_functions): Doc fix.
6024 2011-05-26 Leo Liu <sdl.web@gmail.com>
6026 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6028 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6030 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6032 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6033 for fringe update if it has periodic bitmap.
6034 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6035 and fringe_bitmap_periodic_p.
6037 * fringe.c (get_fringe_bitmap_data): New function.
6038 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6039 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6040 row. Mark glyph row for fringe update if periodicity changed.
6042 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6043 for fringe update unless it has periodic bitmap.
6045 2011-05-25 Kenichi Handa <handa@m17n.org>
6047 * xdisp.c (get_next_display_element): Set correct it->face_id for
6048 a static composition.
6050 2011-05-24 Leo Liu <sdl.web@gmail.com>
6053 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6055 * fns.c (crypto_hash_function, Fsha1): New function.
6056 (Fmd5): Use crypto_hash_function.
6057 (syms_of_fns): Add Ssha1.
6059 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6061 * gnutls.c: Remove unused macros.
6062 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6063 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6064 Remove macros that are defined and never used.
6065 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6067 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6069 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6070 (Fx_get_selection_internal): Minor cleanup.
6071 (Fx_own_selection_internal): Rename arguments for consistency with
6074 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6076 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6078 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6080 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6082 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6084 * dispnew.c (scrolling_window): Don't exclude the case that the
6085 last enabled row in the desired matrix touches the bottom boundary.
6087 2011-05-21 Glenn Morris <rgm@gnu.org>
6089 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6090 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6091 and add some more files.
6093 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6095 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6096 report_file_error introduced by the change from 2011-05-07.
6098 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6100 * systime.h (Time): Define only if emacs is defined.
6101 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6102 where the include path doesn't have X11/X.h by default. See
6103 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6105 2011-05-20 Kenichi Handa <handa@m17n.org>
6107 * composite.c (find_automatic_composition): Fix previous change.
6109 2011-05-20 Glenn Morris <rgm@gnu.org>
6111 * lisp.mk: New file, split from Makefile.in.
6112 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6113 (shortlisp): Remove.
6114 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6116 2011-05-19 Glenn Morris <rgm@gnu.org>
6118 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6119 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6120 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6121 (lisp): Set the order to that of loadup.el.
6122 (shortlisp): Make it a copy of $lisp.
6123 (SOME_MACHINE_LISP): Remove.
6124 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6125 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6127 2011-05-18 Kenichi Handa <handa@m17n.org>
6129 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6130 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6131 (find_automatic_composition): Mostly rewrite for efficiency.
6133 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6135 * makefile.w32-in: Update dependencies.
6137 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6139 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6140 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6142 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6144 Fix some integer overflow issues, such as string length overflow.
6146 * insdel.c (count_size_as_multibyte): Check for string overflow.
6148 * character.c (lisp_string_width): Check for string overflow.
6149 Use EMACS_INT, not int, for string indexes and lengths; in
6150 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6151 the resulting string length overflows an EMACS_INT; instead,
6152 report a string overflow if no precision given. When checking for
6153 precision exhaustion, use a check that cannot possibly have
6154 integer overflow. (Bug#8675)
6155 * character.h (lisp_string_width): Adjust to new signature.
6157 * alloc.c (string_overflow): New function.
6158 (Fmake_string): Use it. This doesn't change behavior, but saves
6159 a few bytes and will simplify future changes.
6160 * character.c (string_escape_byte8): Likewise.
6161 * lisp.h (string_overflow): New decl.
6163 Fixups, following up to the user-interface timestamp change.
6164 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6165 for UI timestamps, instead of unsigned long.
6166 * msdos.c (mouse_get_pos): Likewise.
6167 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6168 * w32gui.h (Time): Define by including "systime.h" rather than by
6169 declaring it ourselves. (Bug#8664)
6171 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6172 * image.c (clear_image_cache): Likewise.
6174 * term.c (term_mouse_position): Don't assume time_t wraparound.
6176 Be more systematic about user-interface timestamps.
6177 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6178 and sometimes 'EMACS_UINT', to represent these timestamps.
6179 This change causes it to use 'Time' uniformly, as that's what X uses.
6180 This makes the code easier to follow, and makes it easier to catch
6181 integer overflow bugs such as Bug#8664.
6182 * frame.c (Fmouse_position, Fmouse_pixel_position):
6183 Use Time, not unsigned long, for user-interface timestamps.
6184 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6185 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6186 * keyboard.h (last_event_timestamp): Likewise.
6187 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6188 * menu.h (xmenu_show): Likewise.
6189 * term.c (term_mouse_position): Likewise.
6190 * termhooks.h (struct input_event.timestamp): Likewise.
6191 (struct terminal.mouse_position_hook): Likewise.
6192 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6193 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6194 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6195 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6197 * menu.h, termhooks.h: Include "systime.h", for Time.
6199 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6200 Don't assume that the difference between two unsigned long values
6201 can fit into an integer. At this point, we know button_down_time
6202 <= event->timestamp, so the difference must be nonnegative, so
6203 there's no need to cast the result if double-click-time is
6204 nonnegative, as it should be; check that it's nonnegative, just in
6205 case. This bug is triggered when events are more than 2**31 ms
6206 apart (about 25 days). (Bug#8664)
6208 * xselect.c (last_event_timestamp): Remove duplicate decl.
6209 (x_own_selection): Remove needless cast to unsigned long.
6211 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6212 that always fit in int. Use a sentinel instead of a counter, to
6213 avoid a temp and to allay GCC's concerns about possible int overflow.
6214 * frame.h (struct frame): Use int for menu_bar_items_used
6215 instead of EMACS_INT, since it always fits in int.
6217 * menu.c (grow_menu_items): Check for int overflow.
6219 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6221 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6222 Before, the code was not consistent. These values cannot exceed
6223 2**31 - 1 so there's no need to make them unsigned.
6224 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6225 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6226 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6228 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6230 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6231 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6232 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6233 presumably because the widths might not match.
6235 * window.c (size_window): Avoid needless test at loop start.
6237 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6239 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6241 2011-05-12 Drew Adams <drew.adams@oracle.com>
6243 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6245 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6247 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6248 `width' to `bar_area_x' and `bar_area_width', respectively.
6249 (x_scroll_run): Take account of fringe background extension.
6251 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6252 Rename local vars `left' and `width' to `bar_area_x' and
6253 `bar_area_width', respectively.
6254 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6255 background extension.
6257 2011-05-10 Jim Meyering <meyering@redhat.com>
6259 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6261 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6263 * image.c (Finit_image_library): Return t for built-in image types,
6264 like pbm and xbm. (Bug#8640)
6266 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6268 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6270 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6272 * w32console.c (Fset_screen_color): Doc fix.
6273 (Fget_screen_color): New function.
6274 (syms_of_ntterm): Defsubr it.
6276 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6277 unlink the temporary file if Fcall_process didn't create it in the
6279 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6280 child process will be redirected to a file specified with `:file'.
6281 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6282 cue to call_process_cleanup not to close that handle.
6284 2011-05-07 Ben Key <bkey76@gmail.com>
6286 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6287 one of two shell specific rules, either bootstrap-temacs-CMD or
6288 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6289 to the previous implementation of the bootstrap-temacs rule.
6290 The bootstrap-temacs-CMD rule is similar to the previous
6291 implementation of the bootstrap-temacs rule except that it
6292 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6295 These changes, along with some changes to nt/configure.bat,
6296 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6297 earlier fix to add support for --cflags and --ldflags options
6298 that include quotes so that it works whether make uses cmd or
6301 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6303 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6304 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6306 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6307 a string. Handle both cases.
6308 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6309 (Fdbus_register_method): Use Qinvalid_function.
6311 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6313 * makefile.w32-in: Update dependencies.
6314 (LISP_H): Add inttypes.h and stdin.h.
6315 (PROCESS_H): Add unistd.h.
6317 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6319 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6320 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6322 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6324 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6326 * term.c (vfatal): Remove stray call to va_end.
6327 It's not needed and the C Standard doesn't allow it here anyway.
6329 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6330 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6332 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6335 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6337 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6339 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6341 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6343 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6345 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6346 * charset.c (Fdefine_charset_internal): Don't initialize
6347 charset.code_space[15]. The value was garbage, on hosts with
6348 32-bit int (Bug#8600).
6350 * lread.c (read_integer): Be more consistent with string-to-number.
6351 Use string_to_number to do the actual conversion; this avoids
6352 rounding errors and fixes some other screwups. Without this fix,
6353 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6354 (digit_to_number): Move earlier, for benefit of read_integer.
6355 Return -1 if the digit is out of range for the base, -2 if it is
6356 not a digit in any supported base. (Bug#8602)
6358 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6360 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6361 to match comment at start of function. This also removes a
6362 GCC warning about overflow in a 32+64-bit port.
6364 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6366 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6367 Reported by Stefan Monnier in
6368 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6369 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6370 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6372 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6373 (EMACS_UINTPTR): Likewise, with uintptr_t.
6375 * lisp.h: Prefer 64-bit EMACS_INT if available.
6376 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6377 on 32-bit hosts that have 64-bit int, so that they can access
6379 However, temporarily disable this change unless the temporary
6380 symbol WIDE_EMACS_INT is defined.
6382 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6384 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6385 This removes an assumption that EMACS_INT and long are the same
6386 width as pointers. The assumption is true for Emacs porting targets
6387 now, but we want to make other targets possible.
6388 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6389 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6390 In the rest of the code, change types of integers that hold casted
6391 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6392 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6393 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6394 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6395 No need to cast type when ORing.
6396 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6397 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6398 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6399 assume EMACS_INT is the same width as char *.
6400 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6401 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6402 Remove no-longer-needed casts.
6403 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6404 (xg_tool_bar_help_callback, xg_make_tool_item):
6405 Use EMACS_INTPTR to hold an integer
6406 that will be cast to void *; this can avoid a GCC warning
6407 if EMACS_INT is not the same width as void *.
6408 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6409 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6410 (current_message_1, set_message_1):
6411 Use a local to convert to proper width without a cast.
6412 * xmenu.c (dialog_selection_callback): Likewise.
6414 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6415 Also, don't assume VALBITS / RAND_BITS is less than 5,
6416 and don't rely on undefined behavior when shifting a 1 left into
6418 * lisp.h (get_random): Change signature to match.
6420 * lread.c (hash_string): Use size_t, not int, for hash computation.
6421 Normally we prefer signed values; but hashing is special, because
6422 it's better to use unsigned division on hash table sizes so that
6423 the remainder is nonnegative. Also, size_t is the natural width
6424 for hashing into memory. The previous code used 'int', which doesn't
6425 retain enough info to hash well into very large tables.
6426 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6428 * dbusbind.c: Don't possibly lose pointer info when converting.
6429 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6430 Use XPNTR rather than XHASH, so that the high-order bits of
6431 the pointer aren't lost when converting through void *.
6433 * eval.c (Fautoload): Don't double-shift a pointer.
6435 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6437 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6439 * gnutls.c (DEF_GNUTLS_FN):
6440 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6442 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6444 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6447 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6449 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6450 New version that can reserve upto 2GB of heap space.
6452 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6454 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6456 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6458 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6459 `gnutls_certificate_set_x509_key_file'.
6461 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6463 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6464 Update dependencies.
6466 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6468 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6469 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6470 Remove unused parameter `fildes'.
6471 * process.c (read_process_output, send_process): Don't pass it.
6473 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6475 Fix previous change: the library cache is defined in w32.c.
6476 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6477 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6479 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6481 Implement dynamic loading of GnuTLS on Windows.
6483 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6484 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6485 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6488 * gnutls.c (Qgnutls_dll): Define.
6489 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6490 (gnutls_*): Declare function pointers.
6491 (init_gnutls_functions): New function to initialize function pointers.
6492 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6493 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6494 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6495 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6496 (emacs_gnutls_write, emacs_gnutls_read)
6497 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6498 (Fgnutls_available_p): New function.
6499 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6500 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6501 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6503 * image.c: Include w32.h.
6504 (Vimage_type_cache): Delete.
6505 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6506 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6507 (w32_delayed_load): Move to w32.c.
6509 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6511 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6512 (w32_delayed_load): Move from image.c. When loading a library, record
6513 its filename in the :loaded-from property of the library id.
6514 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6515 Initialize and staticpro them.
6516 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6518 * process.c: Include lisp.h before w32.h, not after.
6519 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6520 instead of gnutls_record_check_pending.
6522 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6524 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6526 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6527 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6530 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6532 * xterm.c (x_set_frame_alpha): Do not set property on anything
6533 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6535 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6537 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6539 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6541 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6542 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6543 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6544 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6545 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6546 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6547 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6548 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6549 (Qgnutls_bootprop_callbacks_verify): Make static.
6551 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6553 * callproc.c: Indentation fixup.
6555 * sysdep.c (wait_for_termination_1): Make static.
6556 (wait_for_termination, interruptible_wait_for_termination):
6557 Move after wait_for_termination_1.
6559 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6561 * sysdep.c (interruptible_wait_for_termination): New function
6562 which is like wait_for_termination, but allows keyboard
6565 * callproc.c (Fcall_process): Add (:file "file") as an option for
6567 (Fcall_process_region): Ditto.
6569 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6571 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6572 rather than `XVECTOR (FOO)->size'.
6574 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6575 inttypes.h, as a gnulib replacement is used if it not available in
6578 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6580 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6581 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6582 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6584 * coding.c (coding_alloc_by_realloc): Error out if destination
6585 will grow beyond MOST_POSITIVE_FIXNUM.
6586 (decode_coding_emacs_mule): Abort if there isn't enough place in
6587 charbuf for the composition carryover bytes. Reserve an extra
6588 space for up to 2 characters produced in a loop.
6589 (decode_coding_iso_2022): Abort if there isn't enough place in
6590 charbuf for the composition carryover bytes.
6592 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6594 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6595 aborting when %lld or %lll format is passed.
6596 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6597 %llo or %llx format is passed. (Bug#8545)
6599 * window.c (window_scroll_line_based): Use a marker instead of
6600 simple variables to record original value of point. (Bug#7952)
6602 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6603 produced by %s or %c overflows available buffer space. (Bug#8545)
6605 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6607 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6608 (SIZE_MAX): Move defn after all includes, as they might #define it.
6610 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6612 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6614 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6616 * keyboard.c (Qdelayed_warnings_hook): Define.
6617 (command_loop_1): Run `delayed-warnings-hook'
6618 if Vdelayed_warnings_list is non-nil.
6619 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6620 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6622 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6624 * doprnt.c (doprnt): Don't return value smaller than the buffer
6625 size if the message was truncated. (Bug#8545).
6627 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6629 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6630 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6632 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6634 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6636 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6638 * makefile.w32-in: Update dependencies.
6640 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6642 Improve `doprnt' and its usage. (Bug#8545)
6643 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6644 `format_end'. Remove support for %l as a conversion specifier.
6645 Don't use xrealloc. Improve diagnostics when the %l size modifier
6646 is used. Update the commentary.
6648 * eval.c (verror): Simplify calculation of size_t.
6650 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6653 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6655 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6658 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6660 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6661 This makes this file independent of the recent pseudovector change.
6663 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6665 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6667 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6668 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6669 Remove unused local.
6670 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6672 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6673 GCC 4.6.0 optimizes based on type-based alias analysis.
6674 For example, if b is of type struct buffer * and v of type struct
6675 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6676 != &v->size, and therefore "v->size = 1; b->size = 2; return
6677 v->size;" must therefore return 1. This assumption is incorrect
6678 for Emacs, since it type-puns struct Lisp_Vector * with many other
6679 types. To fix this problem, this patch adds a new type struct
6680 vectorlike_header that documents the constraints on layout of vectors
6681 and pseudovectors, and helps optimizing compilers not get fooled
6682 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6683 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6684 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6686 (XSETPVECTYPE): Rewrite in terms of new macro.
6687 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6688 This is a bit clearer, and further avoids the possibility of
6689 undesirable aliasing.
6690 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6691 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6692 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6693 since Lisp_Subr is a special case (no "next" field).
6694 (ASIZE): Now uses header.size rather than size.
6695 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6696 to avoid the hassle of writing XVECTOR (foo)->header.size.
6697 (struct vectorlike_header): New type.
6698 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6699 object, to help avoid aliasing.
6700 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6701 (SUBRP): Likewise, since Lisp_Subr is a special case.
6702 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6703 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6704 (struct Lisp_Hash_Table): Combine first two members into a single
6705 struct vectorlike_header member. All uses of "size" and "next" members
6706 changed to be "header.size" and "header.next".
6707 * buffer.h (struct buffer): Likewise.
6708 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6709 * frame.h (struct frame): Likewise.
6710 * process.h (struct Lisp_Process): Likewise.
6711 * termhooks.h (struct terminal): Likewise.
6712 * window.c (struct save_window_data, struct saved_window): Likewise.
6713 * window.h (struct window): Likewise.
6714 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6715 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6716 * buffer.c (init_buffer_once): Likewise.
6717 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6719 * process.c (Fformat_network_address): Use local var for size,
6722 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6724 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6725 * data.c (atof): Remove decl; no longer used or needed.
6726 (digit_to_number): Move to lread.c.
6727 (Fstring_to_number): Use new string_to_number function, to be
6728 consistent with how the Lisp reader treats infinities and NaNs.
6729 Do not assume that floating-point numbers represent EMACS_INT
6730 without losing information; this is not true on most 64-bit hosts.
6731 Avoid double-rounding errors, by insisting on integers when
6732 parsing non-base-10 numbers, as the documentation specifies.
6733 * lisp.h (string_to_number): New decl, replacing ...
6734 (isfloat_string): Remove.
6735 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6736 (read1): Do not accept +. and -. as integers; this
6737 appears to have been a coding error. Similarly, do not accept
6738 strings like +-1e0 as floating point numbers. Do not report
6739 overflow for integer overflows unless the base is not 10 which
6740 means we have no simple and reliable way to continue.
6741 Break out the floating-point parsing into a new
6742 function string_to_number, so that Fstring_to_number parses
6743 floating point numbers consistently with the Lisp reader.
6744 (digit_to_number): Move here from data.c. Make it static inline.
6745 (E_CHAR, EXP_INT): Remove, replacing with ...
6746 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6747 (string_to_number): New function, replacing isfloat_string.
6748 This function checks for valid syntax and produces the resulting
6749 Lisp float number too. Rework it so that string-to-number
6750 no longer mishandles examples like "1.0e+". Use strtoumax,
6751 so that overflow for non-base-10 numbers is reported only when
6752 there's no portable and simple way to convert to floating point.
6754 * textprop.c (set_text_properties_1): Rewrite for clarity,
6755 and to avoid GCC warning about integer overflow.
6757 * intervals.h (struct interval): Use EMACS_INT for members
6758 where EMACS_UINT might cause problems. See
6759 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6760 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6761 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6763 (offset_intervals): Tell GCC not to worry about length overflow
6764 when negating a negative length.
6766 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6767 (overrun_check_free): Likewise.
6769 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6770 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6773 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6774 (gnutls_make_error): Rename local to avoid shadowing.
6775 (gnutls_emacs_global_deinit): ifdef out; not used.
6776 (Fgnutls_boot): Use const for pointer to readonly storage.
6777 Comment out unused local. Fix pointer signedness problems.
6779 * lread.c (openp): Don't stuff size_t into an 'int'.
6780 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6781 about possible signed overflow.
6783 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6784 (GDK_KEY_g): Don't define if already defined.
6785 (xg_prepare_tooltip): Avoid pointer signedness problem.
6786 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6788 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6789 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6791 * xfns.c (Fx_window_property): Simplify a bit,
6792 to make a bit faster and to avoid GCC 4.6.0 warning.
6793 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6795 * fns.c (internal_equal): Don't assume size_t fits in int.
6797 * alloc.c (compact_small_strings): Tighten assertion a little.
6799 Replace pEd with more-general pI, and fix some printf arg casts.
6800 * lisp.h (pI): New macro, generalizing old pEd macro to other
6801 conversion specifiers. For example, use "...%"pI"d..." rather
6802 than "...%"pEd"...".
6803 (pEd): Remove. All uses replaced with similar uses of pI.
6804 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6805 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6806 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6807 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6808 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6809 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6810 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6812 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6813 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6814 * print.c (safe_debug_print, print_object): Likewise.
6815 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6817 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6818 avoiding the 0 flag, which is not portable.
6819 * process.c (Fmake_network_process): Use pI to avoid cast.
6820 * region-cache.c (pp_cache): Likewise.
6821 * xdisp.c (decode_mode_spec): Likewise.
6822 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6823 behavior on 64-bit hosts with printf arg.
6824 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6825 (x_stop_queuing_selection_requests): Likewise.
6826 (x_get_window_property): Don't truncate byte count to an 'int'
6829 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6830 here, since it parses constructs like leading '-' and spaces,
6831 which are not wanted; and it overflows with large numbers.
6832 Instead, simply match F[0-9]+, which is what is wanted anyway.
6834 * alloc.c: Remove unportable assumptions about struct layout.
6835 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6836 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6837 (allocate_vectorlike, make_pure_vector): Use the new macros,
6838 plus offsetof, to remove unportable assumptions about struct layout.
6839 These assumptions hold on all porting targets that I know of, but
6840 they are not guaranteed, they're easy to remove, and removing them
6841 makes further changes easier.
6843 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6844 This doesn't fix a bug but makes the code clearer.
6845 (string_overrun_cookie): Now const. Use initializers that
6846 don't formally overflow signed char, to avoid warnings.
6847 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6848 can cause Emacs to crash when string overrun checking is enabled.
6849 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6850 multiple of sizeof (EMACS_INT); it need not be, if
6851 alignof(EMACS_INT) < sizeof (EMACS_INT).
6852 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6854 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6856 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6858 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6860 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6861 supposed to be handshaking. (Bug#8556)
6862 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6864 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6866 * lisp.h (Qdebug): List symbol.
6867 * eval.c (Qdebug): Restore global linkage.
6868 * keyboard.c (debug-on-event): New variable.
6869 (handle_user_signal): Break into debugger when debug-on-event
6870 matches the current signal symbol.
6872 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6874 * alloc.c (check_sblock, check_string_bytes)
6875 (check_string_free_list): Convert to standard C.
6877 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6879 * w32.c (emacs_gnutls_push): Fix typo.
6881 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6883 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6884 "cast to pointer from integer of different size".
6886 Improve doprnt and its use in verror. (Bug#8545)
6887 * doprnt.c (doprnt): Document the set of format control sequences
6888 supported by the function. Use SAFE_ALLOCA instead of always
6891 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6892 is one byte too soon. Don't use xrealloc; instead xfree and
6895 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6897 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6900 * gnutls.c: Renamed global_initialized to
6901 gnutls_global_initialized. Added internals for the
6902 :verify-hostname-error, :verify-error, and :verify-flags
6903 parameters of `gnutls-boot' and documented those parameters in the
6904 docstring. Start callback support.
6905 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6906 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6907 on error. Return error code.
6908 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6909 (emacs_gnutls_read): Likewise.
6910 (Fgnutls_boot): Return handshake error code.
6911 (emacs_gnutls_handle_error): New function.
6912 (wsaerror_to_errno): Likewise.
6914 * w32.h (emacs_gnutls_pull): Add prototype.
6915 (emacs_gnutls_push): Likewise.
6917 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6918 (emacs_gnutls_push): Likewise.
6920 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6922 * process.c (wait_reading_process_output): Check if GnuTLS
6923 buffered some data internally if no FDs are set for TLS
6926 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6927 (LIBS): Link to USER_LIBS.
6928 ($(BLD)/gnutls.$(0)): New target.
6930 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6932 * xdisp.c (handle_single_display_spec): Rename the
6933 display_replaced_before_p argument into display_replaced_p, to
6934 make it consistent with the commentary. Fix typos in the
6937 * textprop.c (syms_of_textprop): Remove dead code.
6938 (copy_text_properties): Delete obsolete commentary about an
6939 interface that was deleted long ago. Fix typos in the description
6942 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6943 to changes in oldXMenu/XMenu.h from 2011-04-16.
6944 <menu_help_message, prev_menu_help_message>: Constify.
6945 (IT_menu_make_room): menu->help_text is now `const char **';
6948 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6949 to changes in oldXMenu/XMenu.h from 2011-04-16.
6950 (struct XMenu): Declare `help_text' `const char **'.
6952 * xfaces.c <Qunspecified>: Make extern again.
6954 * syntax.c: Include sys/types.h before including regex.h, as
6957 * doc.c (get_doc_string): Improve the format passed to `error'.
6959 * doprnt.c (doprnt): Improve commentary.
6961 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6963 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6966 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6967 changes in globals.h immediately force recompilation.
6968 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6969 $(CURDIR)/s/ms-w32.h.
6970 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6972 * character.c (Fchar_direction): Function deleted.
6973 (syms_of_character): Don't defsubr it.
6974 <char-direction-table>: Deleted.
6976 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6978 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6979 * doprnt.c: Include limits.h.
6980 (SIZE_MAX): New macro.
6981 (doprnt): Return a size_t value. 2nd arg is now size_t.
6982 Many local variables are now size_t instead of int or unsigned.
6983 Improve overflow protection. Support `l' modifier for integer
6984 conversions. Support %l conversion. Don't assume an EMACS_INT
6985 argument for integer conversions and for %c.
6987 * lisp.h (doprnt): Restore prototype.
6989 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6992 * Makefile.in (base_obj): Add back doprnt.o.
6994 * deps.mk (doprnt.o): Add back prerequisites.
6995 (callint.o): Depend on character.h.
6997 * eval.c (internal_lisp_condition_case): Include the handler
6998 representation in the error message.
6999 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7000 when breaking from the loop.
7002 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7004 * callint.c (Fcall_interactively): When displaying error message
7005 about invalid control letter, pass the character's codepoint, not
7006 a pointer to its multibyte form. Improve display of the character
7007 in octal and display also its hex code.
7009 * character.c (char_string): Use %x to display the (unsigned)
7010 codepoint of an invalid character, to avoid displaying a bogus
7013 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7014 `error', not SYMBOL_NAME itself.
7016 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7017 character arguments to `error'.
7019 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7020 to `error' in error message about FINAL_CHAR argument. Make sure
7021 FINAL_CHAR is a character, and use %c when it is passed as
7022 argument to `error'.
7024 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7026 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7028 * w32.c: Include <time.h>.
7029 (sys_localtime): New function.
7031 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7033 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7035 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7037 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7039 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7042 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7044 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7045 gl_state.e_property when gl_state.object is Qt.
7047 * insdel.c (make_gap_larger): Remove limitation of buffer size
7050 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7052 * xdisp.c (lookup_glyphless_char_display)
7053 (produce_glyphless_glyph): Handle cons cell entry in
7054 glyphless-char-display.
7055 (Vglyphless_char_display): Document it.
7057 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7058 glyphless-char-display.
7060 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7062 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7064 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7066 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7067 definition for no-X builds.
7069 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7071 Static checks with GCC 4.6.0 and non-default toolkits.
7073 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7075 * process.c (keyboard_bit_set): Define only if SIGIO.
7076 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7077 (send_process): Repair possible setjmp clobbering.
7079 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7081 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7083 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7085 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7086 Define only if needed.
7088 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7089 by pacifying GCC about it. Maybe it's time to retire it?
7090 * xfaces.c (USG, __TIMEVAL__): Likewise.
7092 * dispextern.h (struct redisplay_interface): Rename param
7094 * termhooks.h (struct terminal): Likewise.
7095 * xterm.c (xembed_send_message): Likewise.
7097 * insdel.c (make_gap_smaller): Define only if
7098 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7100 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7103 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7104 so that we aren't warned about unused symbols.
7106 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7108 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7110 * xfns.c (x_real_positions): Mark locals as initialized.
7112 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7114 * xterm.c: Fix problems found by static analysis with other toolkits.
7115 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7116 (x_dispatch_event): Declare static if USE_GTK, and
7117 define if USE_GTK || USE_X_TOOLKIT.
7118 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7119 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7120 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7121 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7123 * xmenu.c (menu_help_callback): Pointer type fixes.
7124 Use const pointers when pointing at readonly data. Avoid pointer
7126 (FALSE): Remove unused macro.
7127 (update_frame_menubar): Remove unused decl.
7129 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7131 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7132 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7133 (single_menu_item): Rename local to avoid shadowing.
7135 * keyboard.c (make_lispy_event): Remove unused local var.
7137 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7138 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7140 * bitmaps: Change bitmaps from unsigned char back to the X11
7141 compatible char. Avoid the old compiler warnings about
7142 out-of-range initializers by using, for example, '\xab' rather
7145 * xgselect.c (xgselect_initialize): Check vs interface
7146 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7148 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7150 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7151 to read-only memory.
7153 * fns.c (vector): Remove; this old hack is no longer needed.
7155 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7157 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7159 * xrdb.c (x_load_resources): Omit unused local.
7161 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7162 (x_window): Rename locals to avoid shadowing.
7163 (USG): Use the kludged USG macro, to pacify gcc.
7165 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7166 (x_term_init): Remove local to avoid shadowing.
7168 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7170 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7171 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7173 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7175 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7177 Fix regex.c, syntax.c and friends for buffers > 2GB.
7178 * syntax.h (struct gl_state_s): Declare character position members
7181 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7183 * textprop.c (verify_interval_modification, interval_of):
7184 Declare arguments EMACS_INT.
7186 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7189 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7191 * indent.c (Fvertical_motion): Local variable it_start is now
7194 * regex.c (re_match, re_match_2, re_match_2_internal)
7195 (bcmp_translate, regcomp, regexec, print_double_string)
7196 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7197 (re_compile_pattern, re_exec): Declare arguments and local
7198 variables `size_t' and `ssize_t' and return values `regoff_t', as
7200 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7201 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7202 <compile_stack_type>: `size' and `avail' are now `size_t'.
7204 * regex.h <regoff_t>: Use ssize_t, not int.
7205 (re_search, re_search_2, re_match, re_match_2): Arguments that
7206 specify buffer/string position and length are now ssize_t and
7207 size_t. Return type is regoff_t.
7209 2011-04-16 Ben Key <bkey76@gmail.com>
7211 * nsfont.m: Fixed bugs in ns_get_family and
7212 ns_descriptor_to_entity that were caused by using free to
7213 deallocate memory blocks that were allocated by xmalloc (via
7214 xstrdup). This caused Emacs to crash when compiled with
7215 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7216 --enable-checking=xmallocoverrun). xfree is now used to
7217 deallocate these memory blocks.
7219 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7221 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7223 emacs_write: Accept and return EMACS_INT for sizes.
7224 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7226 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7227 Accept and return EMACS_INT.
7228 (emacs_gnutls_write): Return the number of bytes written on
7230 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7231 (emacs_read, emacs_write): Remove check for negative size, as the
7232 Emacs source code has been audited now.
7233 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7234 (emacs_read, emacs_write): Use it.
7235 * process.c (send_process): Adjust to the new signatures of
7236 emacs_write and emacs_gnutls_write. Do not attempt to store
7237 a byte offset into an 'int'; it might overflow.
7238 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7240 * sound.c: Don't assume sizes fit in 'int'.
7241 (struct sound_device.period_size, alsa_period_size):
7242 Return EMACS_INT, not int.
7243 (struct sound_device.write, vox_write, alsa_write):
7244 Accept EMACS_INT, not int.
7245 (wav_play, au_play): Use EMACS_INT to store sizes and to
7246 record read return values.
7248 2011-04-15 Ben Key <bkey76@gmail.com>
7250 * keyboard.c (Qundefined): Don't declare static since it is used
7252 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7253 static since they are used in nsfont.m.
7255 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7257 * process.c (Qprocessp): Don't declare static.
7258 * lisp.h (Qprocessp): Declare again.
7260 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7262 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7264 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7266 Improve C-level modularity by making more things 'static'.
7268 Don't publish debugger-only interfaces to other modules.
7269 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7270 (verify_bytepos, count_markers): Move decls to the only modules
7272 * region-cache.h (pp_cache): Likewise.
7273 * window.h (check_all_windows): Likewise.
7274 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7276 * sysdep.c (croak): Now static, if
7277 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7278 * syssignal.h (croak): Declare only if not static.
7280 * alloc.c (refill_memory_reserve): Now static if
7281 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7282 * lisp.h (refill_memory_reserve): Declare only if not static.
7284 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7285 Define only if USE_LUCID.
7287 * xrdb.c (x_customization_string, x_rm_string): Now static.
7289 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7290 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7292 * xdisp.c (draw_row_with_mouse_face): Now static.
7293 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7295 * window.h (check_all_windows): Mark externally visible.
7297 * window.c (window_deletion_count): Now static.
7299 * undo.c: Make symbols static if they're not exported.
7300 (last_undo_buffer, last_boundary_position, pending_boundary):
7303 * textprop.c (interval_insert_behind_hooks): Now static.
7304 (interval_insert_in_front_hooks): Likewise.
7306 * term.c: Make symbols static if they're not exported.
7307 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7308 (max_frame_lines, tty_set_terminal_modes):
7309 (tty_reset_terminal_modes, tty_turn_off_highlight):
7310 (get_tty_terminal): Now static.
7311 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7312 * termhooks.h (term_mouse_moveto): Do not declare if
7314 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7315 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7317 * sysdep.c: Make symbols static if they're not exported.
7318 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7320 (sigprocmask_set, full_mask): Remove; unused.
7321 (wait_debugging): Mark as visible.
7322 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7323 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7325 * syntax.c (syntax_temp): Define only if !__GNUC__.
7327 * sound.c (current_sound_device, current_sound): Now static.
7329 * search.c (searchbufs, searchbuf_head): Now static.
7331 * scroll.c (scroll_cost): Remove; unused.
7332 * dispextern.h (scroll_cost): Remove decl.
7334 * region-cache.h (pp_cache): Mark as externally visible.
7336 * process.c: Make symbols static if they're not exported.
7337 (process_tick, update_tick, create_process, chan_process):
7338 (Vprocess_alist, proc_buffered_char, datagram_access):
7339 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7340 (deactivate_process): Mark defn as static, as well as decl.
7341 * lisp.h (create_process): Remove decl.
7342 * process.h (chan_process, Vprocess_alist): Remove decls.
7344 * print.c: Make symbols static if they're not exported.
7345 (print_depth, new_backquote_output, being_printed, print_buffer):
7346 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7347 (print_interval, print_number_index, initial_stderr_stream):
7349 * lisp.h (Fprinc): Remove decl.
7350 (debug_output_compilation_hack): Mark as externally visible.
7352 * sysdep.c (croak): Move decl from here to syssignal.h.
7353 * syssignal.h (croak): Put it here, so the API can be checked when
7354 'croak' is called from dissociate_if_controlling_tty.
7356 * minibuf.c: Make symbols static if they're not exported.
7357 (minibuf_save_list, choose_minibuf_frame): Now static.
7358 * lisp.h (choose_minibuf_frame): Remove decl.
7360 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7362 * lread.c: Make symbols static if they're not exported.
7363 (read_objects, initial_obarray, oblookup_last_bucket_number):
7365 (make_symbol): Remove; unused.
7366 * lisp.h (initial_obarray, make_symbol): Remove decls.
7368 * keyboard.c: Make symbols static if they're not exported.
7369 (single_kboard, recent_keys_index, total_keys, recent_keys):
7370 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7371 (this_single_command_key_start, echoing, last_auto_save):
7372 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7373 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7374 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7375 (Vlispy_mouse_stem, double_click_count):
7377 (force_auto_save_soon): Define only if SIGDANGER.
7378 (ignore_mouse_drag_p): Now static if
7379 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7380 (print_help): Remove; unused.
7381 (stop_character, last_timer_event): Mark as externally visible.
7382 * keyboard.h (ignore_mouse_drag_p): Declare only if
7383 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7384 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7385 * lisp.h (echoing): Remove decl.
7386 (force_auto_save_soon): Declare only if SIGDANGER.
7387 * xdisp.c (redisplay_window): Simplify code, to make it more
7388 obvious that ignore_mouse_drag_p is not accessed if !defined
7389 USE_GTK && !defined HAVE_NS.
7391 * intervals.c: Make symbols static if they're not exported.
7392 (merge_properties_sticky, merge_interval_right, delete_interval):
7394 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7396 * insdel.c: Make symbols static if they're not exported.
7397 However, leave prepare_to_modify_buffer alone. It's never
7398 called from outside this function, but that appears to be a bug.
7399 (combine_after_change_list, combine_after_change_buffer):
7400 (adjust_after_replace, signal_before_change): Now static.
7401 (adjust_after_replace_noundo): Remove; unused.
7402 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7403 (signal_before_change): Remove decls.
7405 * indent.c (val_compute_motion, val_vmotion): Now static.
7407 * image.c: Make symbols static if they're not exported.
7408 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7410 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7411 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7413 * fringe.c (standard_bitmaps): Now static.
7414 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7416 * frame.c: Make symbols static if they're not exported.
7417 (x_report_frame_params, make_terminal_frame): Now static.
7418 (get_frame_param): Now static, unless HAVE_NS.
7419 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7420 (x_get_resource_string): Remove; not used.
7421 * frame.h (make_terminal_frame, x_report_frame_params):
7422 (x_get_resource_string); Remove decls.
7423 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7424 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7426 * font.c, fontset.c: Make symbols static if they're not exported.
7427 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7428 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7429 * font.c (font_close_object): Now static.
7430 * font.h (font_close_object): Remove.
7431 * fontset.c (FONTSET_OBJLIST): Remove.
7432 (free_realized_fontset) #if-0 the body, which does nothing.
7433 (face_suitable_for_char_p): #if-0, as it's never called.
7434 * fontset.h (face_suitable_for_char_p): Remove decl.
7435 * xfaces.c (face_at_string_position):
7436 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7437 since 0 is always ASCII.
7439 * fns.c (weak_hash_tables): Now static.
7441 * fileio.c: Make symbols static if they're not exported.
7442 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7443 (Vwrite_region_annotation_buffers): Now static.
7445 * eval.c: Make symbols static if they're not exported.
7446 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7447 * lisp.h (backtrace_list): Remove decl.
7449 * emacs.c: Make symbols static if they're not exported.
7450 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7451 (fatal_error_code, fatal_error_signal_hook, standard_args):
7453 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7454 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7455 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7456 * lisp.h (fatal_error_signal_hook): Remove decl.
7457 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7459 * editfns.c: Move a (normally-unused) function to its only use.
7460 * editfns.c, lisp.h (get_operating_system_release): Remove.
7461 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7462 worth the hassle of breaking this out.
7464 * xterm.c: Make symbols static if they're not exported.
7465 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7466 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7467 (x_destroy_window, x_delete_display):
7469 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7470 (x_mouse_leave): Remove; unused.
7471 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7472 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7473 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7475 (x_mouse_leave): Declare only if WINDOWSNT.
7476 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7477 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7480 * ftxfont.c: Make symbols static if they're not exported.
7481 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7483 * font.h (ftxfont_driver): Likewise.
7485 * xfns.c: Make symbols static if they're not exported.
7486 (x_last_font_name, x_display_info_for_name):
7487 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7488 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7489 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7490 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7491 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7492 (last_show_tip_args): Now static.
7493 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7494 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7495 (x_screen_planes): Remove; unused.
7496 * dispextern.h (x_screen_planes): Remove decl.
7498 * dispnew.c: Make symbols static if they're not exported.
7499 * dispextern.h (redraw_garbaged_frames, scrolling):
7500 (increment_row_positions): Remove.
7501 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7502 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7504 (redraw_garbaged_frames): Remove; unused.
7506 * xfaces.c: Make symbols static if they're not exported.
7507 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7509 * xterm.h (defined_color): Remove decls.
7510 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7511 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7512 (menu_face_changed_default, defined_color, free_realized_face):
7513 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7514 (ascii_face_of_lisp_face): Remove; unused.
7516 * xdisp.c: Make symbols static if they're not exported.
7517 * dispextern.h (scratch_glyph_row, window_box_edges):
7518 (glyph_to_pixel_coords, set_cursor_from_row):
7519 (get_next_display_element, set_iterator_to_next):
7520 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7521 (show_mouse_face): Remove decls
7522 * frame.h (message_buf_print): Likewise.
7523 * lisp.h (pop_message, set_message, check_point_in_composition):
7525 * xterm.h (set_vertical_scroll_bar): Likewise.
7526 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7527 (message_buf_print, scratch_glyph_row, displayed_buffer):
7528 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7529 (get_next_display_element, show_mouse_face, window_box_edges):
7530 (frame_to_window_pixel_xy, check_point_in_composition):
7531 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7532 (glyph_to_pixel_coords): Remove; unused.
7534 * dired.c (file_name_completion): Now static.
7536 * dbusbind.c (xd_in_read_queued_messages): Now static.
7538 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7539 * data.c (circular_list_error): Remove.
7541 * commands.h (last_point_position, last_point_position_buffer):
7542 (last_point_position_window): Remove decls.
7543 * keyboard.c: Make these variables static.
7545 * coding.h (coding, code_convert_region, encode_coding_gap):
7547 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7548 (iso_code_class, detect_coding, code_convert_region): Now static.
7549 (encode_coding_gap): Remove; unused.
7551 * chartab.c (chartab_chars, chartab_bits): Now static.
7553 * charset.h (charset_iso_8859_1): Remove decl.
7554 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7557 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7558 * ccl.c (Vccl_program_table): Now static.
7559 (check_ccl_update): Remove; unused.
7561 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7562 * category.h: ... from here.
7563 * category.c (check_category_table, set_category_set): Now static.
7565 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7566 * lisp.h: Remove these decls.
7568 * buffer.c (buffer_count): Remove unused var.
7570 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7571 so that it's not optimized away.
7572 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7573 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7574 exported only to the debugger.
7576 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7577 * atimer.h (run_all_atimers): Remove; not exported.
7579 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7580 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7581 was inaccessible from Lisp.
7582 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7583 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7585 alloc.c: Import and export fewer symbols, and remove unused items.
7586 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7588 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7589 it's not optimized away by whole-program optimization.
7590 (message_enable_multibyte, free_misc): Remove.
7591 (catchlist, handlerlist, mark_backtrace):
7592 Declare only if BYTE_MARK_STACK.
7593 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7594 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7595 (message_enable_multibyte): Remove decl.
7596 (free_misc, interval_free_list, float_block, float_block_index):
7597 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7598 (cons_free_list, last_marked_index):
7600 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7601 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7602 (mark_backtrace): Define only if BYTE_MARK_STACK.
7603 * xdisp.c (message_enable_multibyte): Now static.
7605 Declare Lisp_Object Q* variables to be 'static' if not exported.
7606 This makes it easier for human readers (and static analyzers)
7607 to see whether these variables are used from other modules.
7608 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7609 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7610 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7611 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7612 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7613 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7614 * xmenu.c, xselect.c:
7615 Declare Q* vars static if they are not used in other modules.
7616 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7617 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7618 Remove decls of unexported vars.
7619 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7621 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7623 Make Emacs functions such as Fatom 'static' by default.
7624 This makes it easier for human readers (and static analyzers)
7625 to see whether these functions can be called from other modules.
7626 DEFUN now defines a static function. To make the function external
7627 so that it can be used in other C modules, use the new macro DEFUE.
7628 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7629 (Finit_image_library):
7630 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7631 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7632 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7633 Remove decls, since these functions are now static.
7634 (Funintern, Fget_internal_run_time): New decls, since these functions
7635 were already external.
7637 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7638 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7639 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7640 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7641 * keyboard.c, keymap.c, lread.c:
7642 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7643 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7644 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7645 Mark functions with DEFUE instead of DEFUN,
7646 if they are used in other modules.
7647 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7648 decls for now-static functions.
7649 * buffer.h (Fdelete_overlay): Remove decl.
7650 * callproc.c (Fgetenv_internal): Mark as internal.
7651 * composite.c (Fremove_list_of_text_properties): Remove decl.
7652 (Fcomposition_get_gstring): New forward static decl.
7653 * composite.h (Fcomposite_get_gstring): Remove decl.
7654 * dired.c (Ffile_attributes): New forward static decl.
7655 * doc.c (Fdocumntation_property): New forward static decl.
7656 * eval.c (Ffetch_bytecode): New forward static decl.
7657 (Funintern): Remove extern decl; now in .h file where it belongs.
7658 * fileio.c (Fmake_symbolic_link): New forward static decl.
7659 * image.c (Finit_image_library): New forward static decl.
7660 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7661 * intervals.h (Fprevious_property_change):
7662 (Fremove_list_of_text_properties): Remove decls.
7663 * keyboard.c (Fthis_command_keys): Remove decl.
7664 (Fcommand_execute): New forward static decl.
7665 * keymap.c (Flookup_key): New forward static decl.
7666 (Fcopy_keymap): Now static.
7667 * keymap.h (Flookup_key): Remove decl.
7668 * process.c (Fget_process): New forward static decl.
7669 (Fprocess_datagram_address): Mark as internal.
7670 * syntax.c (Fsyntax_table_p): New forward static decl.
7671 (skip_chars): Remove duplicate decl.
7672 * textprop.c (Fprevious_property_change): New forward static decl.
7673 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7675 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7676 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7678 * editfns.c (Fformat): Remove unreachable code.
7680 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7682 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7685 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7687 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7688 when at ZV. (Bug#8487)
7690 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7692 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7694 * keyboard.c (parse_tool_bar_item): Likewise.
7695 * sound.c (sound_cleanup, alsa_close): Likewise.
7696 * termcap.c (tgetent): Likewise.
7697 * xfns.c (x_default_font_parameter): Likewise.
7698 * xsettings.c (read_and_apply_settings): Likewise.
7700 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7701 (overrun_check_free): Protoize.
7703 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7705 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7706 since callers should never pass a negative size.
7707 Change the signature to match that of plain 'read' and 'write'; see
7708 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7709 * lisp.h: Update prototypes of emacs_write and emacs_read.
7711 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7713 * xdisp.c (redisplay_window): Don't try to determine the character
7714 position of the scroll margin if the window start point w->startp
7715 is outside the buffer's accessible region. (Bug#8468)
7717 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7719 Fix write-region and its subroutines for buffers > 2GB.
7720 * fileio.c (a_write, e_write): Modify declaration of arguments and
7721 local variables to support buffers larger than 2GB.
7722 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7724 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7725 argument, local variables, and return value.
7727 * lisp.h: Update prototypes of emacs_write and emacs_read.
7729 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7731 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7733 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7735 Fix more problems found by GCC 4.6.0's static checks.
7737 * xdisp.c (vmessage): Use a better test for character truncation.
7739 * charset.c (load_charset_map): <, not <=, for optimization,
7740 and to avoid potential problems with integer overflow.
7741 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7742 * casetab.c (set_identity, shuffle): Likewise.
7743 * editfns.c (Fformat): Likewise.
7744 * syntax.c (skip_chars): Likewise.
7746 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7747 This also lets GCC 4.6.0 generate slightly better loop code.
7749 * callint.c (Fcall_interactively): <, not <=, for optimization.
7750 (Fcall_interactively): Count the number of arguments produced,
7751 not the number of arguments given. This is simpler and lets GCC
7752 4.6.0 generate slightly better code.
7754 * ftfont.c: Distingish more carefully between FcChar8 and char.
7755 The previous code passed unsigned char * to a functions like
7756 strlen and xstrcasecmp that expect char *, which does not
7757 conform to the C standard.
7758 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7759 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7760 char * when the C standard requires it.
7762 * keyboard.c (read_char): Remove unused var.
7764 * eval.c: Port to Windows vsnprintf (Bug#8435).
7766 (SIZE_MAX): Define if the headers do not.
7767 (verror): Do not give up if vsnprintf returns a negative count.
7768 Instead, grow the buffer. This ports to Windows vsnprintf, which
7769 does not conform to C99. Problem reported by Eli Zaretskii.
7770 Also, simplify the allocation scheme, by avoiding the need for
7771 calling realloc, and removing the ALLOCATED variable.
7773 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7775 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7776 But keep the doprint source code for now, as we might revamp it
7777 and use it again (Bug#8435).
7778 * lisp.h (doprnt): Remove.
7779 * Makefile.in (base_obj): Remove doprnt.o.
7780 * deps.mk (doprnt.o): Remove.
7782 error: Print 32- and 64-bit integers portably (Bug#8435).
7783 Without this change, on typical 64-bit hosts error ("...%d...", N)
7784 was used to print both 32- and 64-bit integers N, which relied on
7786 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7787 * lisp.h (error, verror): Mark as printf-like functions.
7788 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7789 Report overflow in size calculations when allocating printf buffer.
7790 Do not truncate output string at its first null byte.
7791 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7792 Truncate the output at a character boundary, since vsnprintf does not
7794 * charset.c (check_iso_charset_parameter): Convert internal
7795 character to string before calling 'error', since %c now has the
7797 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7798 overflow when computing char to be passed to 'error'. Do not
7799 pass Lisp_Object to 'error'; pass the integer instead.
7800 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7801 formatted with plain %d.
7803 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7805 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7807 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7809 * xterm.c (x_catch_errors): Remove duplicate declaration.
7811 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7813 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7815 2011-04-10 Jim Meyering <meyering@redhat.com>
7817 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7818 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7819 return ssize_t not "int", and use size_t as the buffer length.
7820 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7821 * gnutls.h: Update declarations.
7822 * process.c (read_process_output): Use ssize_t, to match.
7823 (send_process): Likewise.
7825 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7827 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7829 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7831 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7832 Use unsigned char, to match FcChar8 type definition.
7834 * xterm.c (handle_one_xevent):
7835 * xmenu.c (create_and_show_popup_menu):
7836 * xselect.c (x_decline_selection_request)
7837 (x_reply_selection_request): Avoid type-punned deref of X events.
7839 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7841 Fix some uses of `int' instead of EMACS_INT.
7842 * search.c (string_match_1, fast_string_match)
7843 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7844 (scan_buffer, find_next_newline_no_quit)
7845 (find_before_next_newline, search_command, Freplace_match)
7846 (Fmatch_data): Make some `int' variables be EMACS_INT.
7848 * xdisp.c (display_count_lines): 3rd argument and return value now
7849 EMACS_INT. All callers changed.
7850 (pint2hrstr): Last argument is now EMACS_INT.
7852 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7853 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7854 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7855 (decode_coding_utf_16, decode_coding_emacs_mule)
7856 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7857 (decode_coding_ccl, decode_coding_charset)
7858 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7859 (decode_coding_iso_2022, decode_coding_emacs_mule)
7860 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7861 <char_offset, last_offset>: Declare EMACS_INT.
7862 (encode_coding_utf_8, encode_coding_utf_16)
7863 (encode_coding_emacs_mule, encode_invocation_designation)
7864 (encode_designation_at_bol, encode_coding_iso_2022)
7865 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7866 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7868 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7869 (encode_invocation_designation): Last argument P_NCHARS is now
7871 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7872 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7874 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7877 * ccl.c (Fccl_execute_on_string): Declare some variables
7880 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7882 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7884 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7886 * process.c (Fformat_network_address): Doc fix.
7888 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7890 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7892 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7894 * keyboard.c (read_char): Call Lisp function help-form-show,
7895 instead of using internal_with_output_to_temp_buffer.
7896 (Qhelp_form_show): New var.
7897 (syms_of_keyboard): Use DEFSYM macro.
7899 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7901 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7903 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7905 * process.c (Flist_processes): Remove to Lisp.
7906 (list_processes_1): Delete.
7908 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7910 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7912 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7914 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7916 Fix more problems found by GCC 4.6.0's static checks.
7918 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7920 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7922 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7924 * xdisp.c (vmessage): Mark as a printf-like function.
7926 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7928 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7930 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7931 printf-like functions.
7932 (tiff_load): Add casts to remove these marks before passing them
7933 to system-supplied API.
7935 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7937 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7938 This avoids several warnings with gcc -Wstrict-overflow.
7939 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7940 directly, rather than having caller test rule sign. This avoids
7941 some unnecessary tests.
7942 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7943 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7944 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7946 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7947 (xfont_open): Avoid unnecessary tests.
7949 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7951 * composite.h, composite.c (composition_gstring_put_cache):
7952 Use EMACS_INT, not int, for length.
7954 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7955 breaking out part of COMPOSITION_DECODE_RULE.
7956 (COMPOSITION_DECODE_RULE): Use it.
7957 * composite.c (get_composition_id): Remove unused local vars,
7958 by using the new macro.
7960 * textprop.c (set_text_properties_1): Change while to do-while,
7961 since the condition is always true at first.
7963 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7964 (interval_deletion_adjustment): Return unsigned value.
7967 * process.c (list_processes_1, create_pty, read_process_output):
7968 (exec_sentinel): Remove vars that were set but not used.
7969 (create_pty): Remove unnecessary "volatile"s.
7970 (Fnetwork_interface_info): Avoid possibility of int overflow.
7971 (read_process_output): Do adaptive read buffering even if carryover.
7972 (read_process_output): Simplify nbytes computation if buffered.
7974 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7976 * syntax.c (scan_words): Remove var that was set but not used.
7977 (update_syntax_table): Use unsigned instead of int.
7979 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7980 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7981 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7983 * print.c (print_error_message): Avoid int overflow.
7985 * font.c (font_list_entities): Redo for clarity,
7986 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7988 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7989 (font_score): Avoid potential overflow in diff calculation.
7991 * fns.c (substring_both): Remove var that is set but not used.
7992 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7994 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7996 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7997 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7998 can always succeed if overflow has undefined behavior.
8000 * search.c (boyer_moore, wordify): Remove vars set but not used.
8001 (wordify): Omit three unnecessary tests.
8003 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8004 All callers changed. This avoids the need for an unused var.
8006 * casefiddle.c (casify_region): Remove var that is set but not used.
8008 * dired.c (file_name_completion): Remove var that is set but not used.
8010 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8012 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8013 (Finsert_file_contents): Remove unnecessary code checking fd.
8015 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8016 Check for integer overflow on size calculations.
8018 * buffer.c (Fprevious_overlay_change): Remove var that is set
8021 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8022 Remove vars that are set but not used.
8023 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8024 (timer_check_2): Mark vars as initialized.
8026 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8028 * image.c (lookup_image): Remove var that is set but not used.
8029 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8031 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8032 that are set but not used.
8034 * xfns.c (make_invisible_cursor): Don't return garbage
8035 if XCreateBitmapFromData fails (Bug#8410).
8037 * xselect.c (x_get_local_selection, x_handle_property_notify):
8038 Remove vars that are set but not used.
8040 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8041 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8043 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8044 Remove var that is set but not used.
8045 (scroll_bar_windows_size): Now size_t, not int.
8046 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8049 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8050 (map_tty_color) [!defined MSDOS]: Likewise.
8052 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8054 * coding.c: Remove vars that are set but not used.
8055 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8056 All callers changed.
8057 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8058 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8059 (decode_coding_charset): Remove vars that are set but not used.
8061 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8062 that is set but not used.
8064 * print.c (print_object): Remove var that is set but not used.
8066 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8067 The gnulib version avoids calling malloc in the usual case,
8068 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8069 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8070 * filelock.c (current_lock_owner): Likewise.
8071 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8072 * sysdep.c: Include allocator.h, careadlinkat.h.
8073 (emacs_no_realloc_allocator): New static constant.
8074 (emacs_readlink): New function.
8075 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8076 ../lib/careadlinkat.h.
8078 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8080 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8081 first non-nil return value).
8083 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8085 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8086 if not defined (Bug#8403).
8088 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8090 * xdisp.c (display_count_lines): Remove parameter `start',
8091 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8092 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8093 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8094 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8095 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8096 and thereabouts. All callers changed.
8097 (get_per_char_metric): Remove parameter `f', unused since
8098 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8100 2011-04-02 Jim Meyering <meyering@redhat.com>
8102 do not dereference NULL upon failed strdup
8103 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8104 (ns_get_family): Likewise.
8106 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8108 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8110 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8112 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8115 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8117 Add lexical binding.
8119 * window.c (Ftemp_output_buffer_show): New fun.
8120 (Fsave_window_excursion):
8121 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8123 * lread.c (lisp_file_lexically_bound_p): New function.
8124 (Fload): Bind Qlexical_binding.
8125 (readevalloop): Remove `evalfun' arg.
8126 Bind Qinternal_interpreter_environment.
8127 (Feval_buffer): Bind Qlexical_binding.
8128 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8130 (syms_of_lread): Declare `lexical-binding'.
8132 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8134 * keyboard.c (eval_dyn): New fun.
8135 (menu_item_eval_property): Use it.
8137 * image.c (parse_image_spec): Use Ffunctionp.
8139 * fns.c (concat, mapcar1): Accept byte-code-functions.
8141 * eval.c (Fsetq): Handle lexical vars.
8142 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8143 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8144 (FletX, Flet): Obey lexical binding.
8145 (Fcommandp): Handle closures.
8146 (Feval): New `lexical' arg.
8147 (eval_sub): New function extracted from Feval. Use it almost
8148 everywhere where Feval was used. Look up vars in lexical env.
8150 (Ffunctionp): Move from subr.el.
8151 (Ffuncall): Handle closures.
8152 (apply_lambda): Remove `eval_flags'.
8153 (funcall_lambda): Handle closures and new byte-code-functions.
8154 (Fspecial_variable_p): New function.
8155 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8156 but without exporting it to Lisp.
8158 * doc.c (Fdocumentation, store_function_docstring):
8159 * data.c (Finteractive_form): Handle closures.
8161 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8164 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8166 (exec_byte_code): New function extracted from Fbyte_code to handle new
8167 calling convention for byte-code-functions. Add new byte-codes.
8169 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8171 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8173 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8175 * xdisp.c (redisplay_internal): Fix prototype.
8177 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8179 * xdisp.c (SCROLL_LIMIT): New macro.
8180 (try_scrolling): Use it when setting scroll_limit.
8181 Limit scrolling to 100 screen lines.
8182 (redisplay_window): Even when falling back on "recentering",
8183 position point in the window according to scroll-conservatively,
8184 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8186 (try_scrolling): When point is above the window, allow searching
8187 as far as scroll_max, or one screenful, to compute vertical
8188 distance from PT to the scroll margin position. This prevents
8189 try_scrolling from unnecessarily failing when
8190 scroll-conservatively is set to a value slightly larger than the
8191 window height. Clean up the case of PT below the margin at bottom
8192 of window: scroll_max can no longer be INT_MAX. When aggressive
8193 scrolling is in use, don't let point enter the opposite scroll
8194 margin as result of the scroll.
8195 (syms_of_xdisp) <scroll-conservatively>: Document the
8196 threshold of 100 lines for never-recentering scrolling.
8198 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8200 * dispextern.h (move_it_by_lines):
8201 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8202 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8203 (message_log_check_duplicate): Remove parameters `prev_bol' and
8204 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8205 (redisplay_internal): Remove parameter `preserve_echo_area',
8206 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8208 * indent.c (Fvertical_motion):
8209 * window.c (window_scroll_pixel_based, Frecenter):
8210 Don't pass `need_y_p' to `move_it_by_lines'.
8212 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8214 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8215 steal a few bits to be more compact.
8216 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8217 Remove unneeded casts.
8219 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8221 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8223 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8224 binding" message (bug#7967).
8226 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8228 Fix more problems found by GCC 4.6.0's static checks.
8230 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8231 Remove unused local var.
8233 * editfns.c (Fmessage_box): Remove unused local var.
8235 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8236 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8237 Omit unused local vars.
8238 * window.c (shrink_windows): Omit unused local var.
8239 * menu.c (digest_single_submenu): Omit unused local var.
8240 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8241 Omit unused local var.
8243 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8244 Don't assume string length fits in int.
8245 (keyremap_step, read_key_sequence): Use size_t for sizes.
8246 (read_key_sequence): Don't check last_real_key_start redundantly.
8248 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8249 instead of alloca (Bug#8344).
8251 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8252 (Fbacktrace_frame): Don't assume nframes fits in int.
8254 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8256 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8259 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8261 * cm.c (calccost): Turn while-do into do-while, for clarity.
8263 * keyboard.c (syms_of_keyboard): Use the same style as later
8264 in this function when indexing through an array. This also
8265 works around GCC bug 48267.
8267 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8269 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8271 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8272 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8274 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8275 This avoids undefined behavior on integer overflow, and is a bit
8276 more convenient anyway since it is compared to a size_t variable.
8278 Variadic C functions now count arguments with size_t, not int.
8279 This avoids an unnecessary limitation on 64-bit machines, which
8280 caused (substring ...) to crash on large vectors (Bug#8344).
8281 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8282 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8283 All variadic functions and their callers changed accordingly.
8284 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8285 * data.c (arith_driver, float_arith_driver): Likewise.
8286 * editfns.c (general_insert_function): Likewise.
8287 * eval.c (struct backtrace.nargs, interactive_p)
8288 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8289 (funcall_lambda, mark_backtrace): Likewise.
8290 * fns.c (concat): Likewise.
8291 * frame.c (x_set_frame_parameters): Likewise.
8292 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8293 0 if not found, not -1. All callers changed.
8295 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8296 (stack_copy_size): Now size_t, not int.
8297 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8299 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8301 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8302 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8303 All callers changed.
8305 * lisp.h (multibyte_char_to_unibyte):
8306 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8307 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8308 * character.h (CHAR_TO_BYTE8):
8309 * cmds.c (internal_self_insert):
8310 * editfns.c (general_insert_function):
8311 * keymap.c (push_key_description):
8312 * search.c (Freplace_match):
8313 * xdisp.c (message_dolog, set_message_1): All callers changed.
8315 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8317 * keyboard.c (safe_run_hook_funcall): New function.
8318 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8319 don't set the hook to nil, but remove the offending function instead.
8320 (Qcommand_hook_internal): Remove, unused.
8321 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8322 Vcommand_hook_internal.
8324 * eval.c (enum run_hooks_condition): Remove.
8325 (funcall_nil, funcall_not): New functions.
8326 (run_hook_with_args): Call each function through a `funcall' argument.
8327 Remove `cond' argument, now redundant.
8328 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8329 (Frun_hook_with_args_until_failure): Adjust accordingly.
8330 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8332 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8334 * dispextern.h (string_buffer_position): Remove declaration.
8336 * print.c (strout): Remove parameter `multibyte', unused since
8337 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8339 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8340 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8341 All callers changed.
8343 * w32.c (_wsa_errlist): Use braces for struct initializers.
8345 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8346 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8347 All callers changed.
8348 (string_buffer_position): Likewise. Also, make static (it's never
8349 used outside xdisp.c).
8350 (cursor_row_p): Remove parameter `w', unused since
8351 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8352 (decode_mode_spec): Remove parameter `precision', introduced during
8353 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8354 All callers changed.
8356 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8358 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8360 2011-03-27 Anders Lindgren <andlind@gmail.com>
8362 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8363 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8364 (ns_update_auto_hide_menu_bar): New functions.
8365 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8366 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8367 ns_constrain_all_frames.
8368 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8369 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8371 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8373 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8375 2011-03-27 Glenn Morris <rgm@gnu.org>
8377 * syssignal.h: Replace RETSIGTYPE with void.
8378 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8379 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8380 Replace SIGTYPE with void everywhere.
8381 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8382 * s/template.h (SIGTYPE): Remove commented out definition.
8384 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8386 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8387 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8389 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8391 * w32.c (read_unc_volume): Use parameter `henum', instead of
8392 global variable `wget_enum_handle'.
8394 * keymap.c (describe_vector): Remove parameters `indices' and
8395 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8396 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8398 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8400 * keyboard.c (timer_check): Remove parameter `do_it_now',
8401 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8402 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8403 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8405 * keyboard.c (read_char):
8406 * w32menu.c (w32_menu_display_help):
8407 * xmenu.c (show_help_event, menu_help_callback):
8408 Adjust calls to `show_help_echo'.
8410 * gtkutil.c (xg_maybe_add_timer):
8411 * keyboard.c (readable_events):
8412 * process.c (wait_reading_process_output):
8413 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8415 * insdel.c (adjust_markers_gap_motion):
8416 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8417 (gap_left, gap_right): Don't call it.
8419 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8421 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8422 incurred during fontification.
8424 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8426 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8427 (DEFVAR_PER_BUFFER): Don't pass it.
8429 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8430 (scrolling_window): Don't pass it.
8432 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8434 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8436 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8438 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8439 of variables specific to SELinux and computation of `encoded_absname'.
8441 * image.c (XPutPixel): Remove unused variable `height'.
8443 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8445 * unexw32.c (get_section_info): Remove unused variable `section'.
8447 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8448 (system_process_attributes): Remove unused variable `sess'.
8449 (sys_read): Remove unused variable `err'.
8451 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8452 (w32_wnd_proc): Remove unused variable `isdead'.
8453 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8454 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8455 (x_create_tip_frame): Remove unused variable `tem'.
8457 * w32inevt.c (w32_console_read_socket):
8458 Remove unused variable `no_events'.
8460 * w32term.c (x_draw_composite_glyph_string_foreground):
8461 Remove unused variable `width'.
8463 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8465 * w32term.c (x_set_glyph_string_clipping):
8466 Don't pass uninitialized region to CombineRgn.
8468 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8470 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8471 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8472 (Fx_close_connection): Remove unused variable `i'.
8474 * w32font.c (w32font_draw): Return number of glyphs.
8475 (w32font_open_internal): Remove unused variable `i'.
8476 (w32font_driver): Add missing initializer.
8478 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8479 (fill_in_menu): Remove unused variable `items_added'.
8481 * w32term.c (last_mouse_press_frame): Remove static global variable.
8482 (w32_clip_to_row): Remove unused variable `f'.
8483 (x_delete_terminal): Remove unused variable `i'.
8485 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8486 (NOTHING): Remove unused static global variable.
8487 (uniscribe_check_otf): Remove unused variable `table'.
8488 (uniscribe_font_driver): Add missing initializers.
8490 2011-03-23 Julien Danjou <julien@danjou.info>
8492 * term.c (Fsuspend_tty, Fresume_tty):
8493 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8494 * window.c (temp_output_buffer_show):
8495 * insdel.c (signal_before_change):
8496 * frame.c (Fhandle_switch_frame):
8497 * fileio.c (Fdo_auto_save):
8498 * emacs.c (Fkill_emacs):
8499 * editfns.c (save_excursion_restore):
8500 * cmds.c (internal_self_insert):
8501 * callint.c (Fcall_interactively):
8502 * buffer.c (Fkill_all_local_variables):
8503 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8505 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8506 unconditionally since it does the check itself.
8508 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8510 Fix more problems found by GCC 4.5.2's static checks.
8512 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8513 the first time through the loop, since we know p0 < p1 then.
8514 This also avoids a gcc -Wstrict-overflow warning.
8516 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8517 leading to a memory leak, possible in functions like
8518 load_charset_map_from_file that can allocate an unbounded number
8519 of objects (Bug#8318).
8521 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8522 that could (at least in theory) be that large.
8524 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8525 This is less likely to overflow, and avoids undefined behavior if
8526 overflow does occur. All callers changed. Use strtoul to scan
8527 for the unsigned long integer.
8528 (pint2hrstr): Simplify and tune code slightly.
8529 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8531 * scroll.c (do_scrolling): Work around GCC bug 48228.
8532 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8534 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8535 This also avoids a warning with gcc -Wstrict-overflow.
8536 (validate_x_resource_name): Simplify count usage.
8537 This also avoids a warning with gcc -Wstrict-overflow.
8539 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8542 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8544 * process.c (Fmake_network_process): Use socklen_t, not int,
8545 where POSIX says socklen_t is required in portable programs.
8546 This fixes a porting bug on hosts like 64-bit HP-UX, where
8547 socklen_t is wider than int (Bug#8277).
8548 (Fmake_network_process, server_accept_connection):
8549 (wait_reading_process_output, read_process_output):
8552 * process.c: Rename or move locals to avoid shadowing.
8553 (list_processes_1, Fmake_network_process):
8554 (read_process_output_error_handler, exec_sentinel_error_handler):
8555 Rename or move locals.
8556 (Fmake_network_process): Define label "retry_connect" only if needed.
8557 (Fnetwork_interface_info): Fix pointer signedness.
8558 (process_send_signal): Add cast to avoid pointer signedness problem.
8559 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8560 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8562 Make tparam.h and terminfo.c consistent.
8563 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8564 Include tparam.h instead, since it declares them.
8565 * cm.h (PC): Remove extern decl; tparam.h now does this.
8566 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8567 * terminfo.c: Include tparam.h, to check interfaces.
8568 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8569 (tparam): Adjust signature to match interface in tparam.h;
8570 this removes some undefined behavior. Check that outstring and len
8571 are zero, which they always are with Emacs.
8572 * tparam.h (PC, BC, UP): New extern decls.
8574 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8575 (xftfont_open): Rename locals to avoid shadowing.
8577 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8578 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8579 (OTF_TAG_SYM): Omit macro if not needed.
8580 (ftfont_list): Remove unused local.
8581 (get_adstyle_property, ftfont_pattern_entity):
8582 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8583 Rename locals to avoid shadowing.
8585 * xfont.c (xfont_list_family): Mark var as initialized.
8587 * xml.c (make_dom): Now static.
8589 * composite.c (composition_compute_stop_pos): Rename local to
8591 (composition_reseat_it): Remove unused locals.
8592 (find_automatic_composition, composition_adjust_point): Likewise.
8593 (composition_update_it): Mark var as initialized.
8594 (find_automatic_composition): Mark vars as initialized,
8595 with a FIXME (Bug#8290).
8597 character.h: Rename locals to avoid shadowing.
8598 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8599 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8600 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8601 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8604 * textprop.c (property_change_between_p): Remove; unused.
8606 * intervals.c (interval_start_pos): Now static.
8608 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8610 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8611 Rename locals to avoid shadowing.
8613 * sound.c (wav_play, au_play, Fplay_sound_internal):
8614 Fix pointer signedness.
8615 (alsa_choose_format): Remove unused local var.
8616 (wav_play): Initialize a variable to 0, to prevent undefined
8617 behavior (Bug#8278).
8619 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8621 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8623 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8624 clobbering (Bug#8298).
8625 * sysdep.c (sys_subshell): Likewise.
8626 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8628 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8629 This should get cleaned up, so that child_setup has the
8630 same signature on all platforms.
8632 * callproc.c (call_process_cleanup): Now static.
8633 (relocate_fd): Rename locals to avoid shadowing.
8635 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8637 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8638 not to be necessary, and produces flickering.
8640 2011-03-20 Glenn Morris <rgm@gnu.org>
8642 * config.in: Remove file.
8644 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8646 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8647 are now in src/globals.h.
8648 (syms_of_minibuf): Remove spurious & from previous change.
8650 2011-03-20 Leo Liu <sdl.web@gmail.com>
8652 * minibuf.c (completing-read-function): New variable.
8653 (completing-read-default): Rename from completing-read.
8654 (completing-read): Call completing-read-function.
8656 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8658 * xfaces.c (Fx_load_color_file):
8659 Read color file from absolute filename (bug#8250).
8661 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8663 * makefile.w32-in: Update dependencies.
8665 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8667 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8669 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8671 Fix more problems found by GCC 4.5.2's static checks.
8673 * process.c (make_serial_process_unwind, send_process_trap):
8674 (sigchld_handler): Now static.
8676 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8677 That way, the code declares only the vars that it needs.
8678 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8679 * s/cygwin.h (PTY_ITERATION): Likewise.
8680 * s/darwin.h (PTY_ITERATION): Likewise.
8681 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8683 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8684 * process.c (allocate_pty): Don't declare stb unless it's needed.
8686 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8687 (CONSTANTLIM): Remove; unused.
8688 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8689 Define only if needed.
8691 * unexelf.c (unexec): Name an expression,
8692 to avoid gcc -Wbad-function-cast warning.
8693 Use a different way to cause a compilation error if anyone uses
8694 n rather than nn, a way that does not involve shadowing.
8695 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8697 * deps.mk (unexalpha.o): Remove; unused.
8699 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8700 * unexec.h: New file.
8701 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8702 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8704 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8705 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8706 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8707 Change as necessary to match prototype in unexec.h.
8709 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8711 (back_comment, skip_chars): Mark vars as initialized.
8713 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8714 Rename locals to avoid shadowing.
8716 * lread.c (read1): Rewrite so as not to use empty "else".
8717 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8719 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8721 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8722 warning when compiling print.c.
8724 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8725 instead of using an uninitialized var.
8726 (font_sort_entities): Mark var as initialized.
8728 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8730 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8731 pointers to constants.
8732 (font_parse_fcname): Remove unused vars.
8733 (font_delete_unmatched): Now static.
8734 (font_get_spec): Remove; unused.
8735 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8736 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8737 Rename or move locals to avoid shadowing.
8739 * fns.c (require_nesting_list, require_unwind): Now static.
8740 (Ffillarray): Rename locals to avoid shadowing.
8742 * floatfns.c (domain_error2): Define only if needed.
8743 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8745 * alloc.c (mark_backtrace): Move decl from here ...
8746 * lisp.h: ... to here, so that it can be checked.
8748 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8749 (Fdefvar): Rewrite so as not to use empty "else".
8750 (lisp_indirect_variable): Name an expression,
8751 to avoid gcc -Wbad-function-cast warning.
8752 (Fdefvar): Rename locals to avoid shadowing.
8754 * callint.c (quotify_arg, quotify_args): Now static.
8755 (Fcall_interactively): Rename locals to avoid shadowing.
8756 Use const pointer when appropriate.
8758 * lisp.h (get_system_name, get_operating_system_release):
8759 Move decls here, to check interfaces.
8760 * process.c (get_operating_system_release): Move decl to lisp.h.
8761 * xrdb.c (get_system_name): Likewise.
8762 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8763 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8764 some of which prompt warnings from gcc -Wbad-function-cast.
8765 (Fformat_time_string, Fencode_time, Finsert_char):
8766 (Ftranslate_region_internal, Fformat):
8767 Rename or remove local vars to avoid shadowing.
8768 (Ftranslate_region_internal): Mark var as initialized.
8770 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8773 * lisp.h (eassert): Check that the argument compiles, even if
8774 ENABLE_CHECKING is not defined.
8776 * data.c (Findirect_variable): Name an expression, to avoid
8777 gcc -Wbad-function-cast warning.
8778 (default_value, arithcompare, arith_driver, arith_error): Now static.
8779 (store_symval_forwarding): Rename local to avoid shadowing.
8780 (Fmake_variable_buffer_local, Fmake_local_variable):
8781 Mark variables as initialized.
8782 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8784 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8785 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8786 Rename locals to avoid shadowing.
8787 (mark_stack): Move local variables into the #ifdef region where
8789 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8790 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8792 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8793 (GC_STRING_CHARS): Remove; not used.
8794 (Fmemory_limit): Cast sbrk's returned value to char *.
8796 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8797 avoids undefined behavior in theory.
8799 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8801 Use functions, not macros, for up- and down-casing (Bug#8254).
8802 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8803 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8804 to use the following functions instead of these macros.
8805 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8806 EMACS_INT, since callers assume the returned value fits in int.
8807 (upcase1): Likewise, for UPCASE_TABLE.
8808 (uppercasep, lowercasep, upcase): New static inline functions.
8809 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8810 the race-condition problem in the old DOWNCASE.
8812 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8813 Rename locals to avoid shadowing.
8814 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8815 (regex_compile, re_search_2, re_match_2_internal):
8816 Remove unused local vars.
8817 (FREE_VAR): Rewrite so as not to use empty "else",
8818 which gcc can warn about.
8819 (regex_compile, re_match_2_internal): Mark locals as initialized.
8820 (RETALLOC_IF): Define only if needed.
8821 (WORDCHAR_P): Likewise. This one is never needed, but is used
8822 only in a comment talking about a compiler bug, so put inside
8823 the #if 0 of that comment.
8824 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8825 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8828 * search.c (boyer_moore): Rename locals to avoid shadowing.
8829 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8830 (PREV_CHAR_BOUNDARY): Likewise.
8832 * search.c (simple_search): Remove unused var.
8834 * dired.c (compile_pattern): Move decl from here ...
8835 * lisp.h: ... to here, so that it can be checked.
8836 (struct re_registers): New forward decl.
8838 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8840 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8842 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8843 Rename locals to avoid shadowing.
8844 (Fvertical_motion): Mark locals as initialized.
8846 * casefiddle.c (casify_object, casify_region): Now static.
8847 (casify_region): Mark local as initialized.
8849 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8851 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8852 New macros, so that the caller can use some names other than
8853 gcpro1, gcpro2, etc.
8854 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8856 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8857 argument, for consistency with GCPRO2_VAR, etc: it is now the
8858 prefix of the variable, not the variable itself. All uses
8860 * dired.c (directory_files_internal, file_name_completion):
8861 Rename locals to avoid shadowing.
8863 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8864 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8865 dired.c's scmp function, had undefined behavior.
8866 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8867 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8868 * buffer.h: ... to here, because these macros use current_buffer,
8869 and the new implementation with inline functions needs to have
8870 current_buffer in scope now, rather than later when the macros
8872 (downcase, upcase1): New static inline functions.
8873 (DOWNCASE, UPCASE1): Reimplement using these functions.
8874 This avoids undefined behavior in expressions like
8875 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8876 from race conditions in accessing the global variables
8877 case_temp1 and case_temp2.
8878 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8879 * lisp.h (case_temp1, case_temp2): Remove their decls.
8880 * character.h (ASCII_CHAR_P): Move from here ...
8881 * lisp.h: ... to here, so that the inline functions mentioned
8884 * dired.c (directory_files_internal_unwind): Now static.
8886 * fileio.c (file_name_as_directory, directory_file_name):
8887 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8889 (file_name_as_directory): Use const pointers when appropriate.
8890 (Fexpand_file_name): Likewise. In particular, newdir might
8891 point at constant storage, so make it a const pointer.
8892 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8893 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8895 (Fset_file_times, Finsert_file_contents, auto_save_error):
8896 Rename locals to avoid shadowing.
8898 * minibuf.c (choose_minibuf_frame_1): Now static.
8899 (Ftry_completion, Fall_completions): Rename or remove locals
8902 * marker.c (bytepos_to_charpos): Remove; unused.
8904 * lisp.h (verify_bytepos, count_markers): New decls,
8905 so that gcc does not warn that these functions aren't declared.
8907 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8908 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8909 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8910 (copy_text): Remove unused local var.
8912 * filelock.c (within_one_second): Now static.
8913 (lock_file_1): Rename local to avoid shadowing.
8915 * buffer.c (fix_overlays_before): Mark locals as initialized.
8916 (fix_start_end_in_overlays): Likewise. This function should be
8917 simplified by using pointers-to-pointers, but that's a different
8919 (switch_to_buffer_1): Now static.
8920 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8921 (report_overlay_modification): Rename locals to avoid shadowing.
8923 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8924 Fix pointer signedness issue.
8925 (sys_subshell): Mark local as volatile if checking for lint,
8926 to suppress a gcc -Wclobbered warning that does not seem to be right.
8927 (MAXPATHLEN): Define only if needed.
8929 * process.c (serial_open, serial_configure): Move decls from here ...
8930 * systty.h: ... to here, so that they can be checked.
8932 * fns.c (get_random, seed_random): Move extern decls from here ...
8933 * lisp.h: ... to here, so that they can be checked.
8935 * sysdep.c (reset_io): Now static.
8936 (wait_for_termination_signal): Remove; unused.
8938 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8939 (copy_keymap_item, append_key, push_text_char_description):
8941 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8942 (DENSE_TABLE_SIZE): Remove; unused.
8943 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8944 (describe_map_tree):
8945 Rename locals to avoid shadowing.
8947 * keyboard.c: Declare functions static if they are not used elsewhere.
8948 (echo_char, echo_dash, cmd_error, top_level_2):
8949 (poll_for_input, handle_async_input): Now static.
8950 (read_char, kbd_buffer_get_event, make_lispy_position):
8951 (make_lispy_event, make_lispy_movement, apply_modifiers):
8952 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8953 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8954 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8955 (read_key_sequence, read_char): Mark locals as initialized.
8956 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8958 * keyboard.h (make_ctrl_char): New decl.
8959 (mark_kboards): Move decl here ...
8960 * alloc.c (mark_kboards): ... from here.
8962 * lisp.h (force_auto_save_soon): New decl.
8964 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8965 (DEFINE_DUMMY_FUNCTION): New macro.
8966 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8968 (main): Add casts to avoid warnings
8969 if GCC considers string literals to be constants.
8971 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8973 * dbusbind.c: Pointer signedness fixes.
8974 (xd_signature, xd_append_arg, xd_initialize):
8975 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8976 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8977 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8978 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8980 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8981 if GCC considers string literals to be constants.
8982 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8984 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8986 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8987 (print_preprocess, print_object): New macro to fix last change.
8989 * print.c (print_preprocess): Don't forget font objects.
8991 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8993 * emacs.c (USAGE3): Doc fixes.
8995 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8997 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9000 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9002 * lisp.h (VWindow_system, Qfile_name_history):
9003 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9004 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9005 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9007 * w32select.c: Don't #include "keyboard.h".
9008 (run_protected): Add extern declaration for waiting_for_input.
9010 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9011 * w32console.c (detect_input_pending, read_input_pending)
9012 (encode_terminal_code):
9013 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9014 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9015 (w32_system_caret_y, Qfile_name_history):
9016 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9017 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9018 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9019 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9020 * w32proc.c (Qlocal, report_file_error):
9021 * w32term.c (Vwindow_system, updating_frame):
9022 * w32uniscribe.c (initialized, uniscribe_font_driver):
9023 Remove unneeded extern declarations.
9025 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9027 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9029 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9031 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9032 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9033 These macros can no longer be used for assignment.
9035 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9036 Assign struct members directly, instead of using BUF_BEGV etc.
9037 (record_buffer_markers, fetch_buffer_markers): New functions for
9038 recording and fetching special buffer markers.
9039 (set_buffer_internal_1, set_buffer_temp): Use them.
9041 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9043 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9045 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9046 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9048 * xdisp.c (hscroll_window_tree):
9049 (reconsider_clip_changes): Use PT instead of BUF_PT.
9051 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9053 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9054 $(EMACS_ROOT)/lib/intprops.h.
9056 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9058 Fix more problems found by GCC 4.5.2's static checks.
9060 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9061 to unsigned char * to avoid compiler diagnostic.
9062 (xg_free_frame_widgets): Make it clear that a local variable is
9063 needed only if USE_GTK_TOOLTIP.
9064 (gdk_window_get_screen): Make it clear that this macro is needed
9065 only if USE_GTK_TOOLTIP.
9066 (int_gtk_range_get_value): New function, which avoids a diagnostic
9067 from gcc -Wbad-function-cast.
9068 (xg_set_toolkit_scroll_bar_thumb): Use it.
9069 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9070 diagnostic from gcc -Wbad-function-cast.
9071 (get_utf8_string, xg_get_file_with_chooser):
9072 Rename locals to avoid shadowing.
9073 (create_dialog): Move locals to avoid shadowing.
9075 * xgselect.c (xg_select): Remove unused var.
9077 * image.c (four_corners_best): Mark locals as initialized.
9078 (gif_load): Initialize transparent_p to zero (Bug#8238).
9079 Mark another local as initialized.
9080 (my_png_error, my_error_exit): Mark with NO_RETURN.
9082 * image.c (clear_image_cache): Now static.
9083 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9084 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9085 (x_edge_detection): Remove unnecessary cast that
9086 gcc -Wbad-function-cast diagnoses.
9087 (gif_load): Fix pointer signedness.
9088 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9089 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9091 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9093 Improve quality of tests for time stamp overflow.
9094 For example, without this patch (encode-time 0 0 0 1 1
9095 1152921504606846976) returns the obviously-bogus value (-948597
9096 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9097 reports time overflow. See
9098 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9099 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9100 * editfns.c: Include limits.h and intprops.h.
9101 (TIME_T_MIN, TIME_T_MAX): New macros.
9102 (time_overflow): Move earlier, to before first use.
9103 (hi_time, lo_time): New functions, for an accurate test for
9105 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9106 (Fget_internal_run_time): Don't assume time_t fits in int.
9107 (make_time): Use list2 instead of Fcons twice.
9108 (Fdecode_time): More accurate test for out-of-range times.
9109 (check_tm_member): New function.
9110 (Fencode_time): Use it, to test for out-of-range times.
9111 (lisp_time_argument): Don't rely on undefined left-shift and
9112 right-shift behavior when checking for time stamp overflow.
9114 * editfns.c (time_overflow): New function, refactoring common code.
9115 (Fformat_time_string, Fdecode_time, Fencode_time):
9116 (Fcurrent_time_string): Use it.
9118 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9119 * dired.c (make_time): Move to ...
9120 * editfns.c (make_time): ... here.
9121 * systime.h: Note the move.
9123 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9125 * fringe.c (update_window_fringes): Remove unused variables.
9127 * unexmacosx.c (copy_data_segment): Also copy __got section.
9130 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9132 * termcap.c [MSDOS]: Include "msdos.h".
9133 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9134 Constify `char *' arguments and their references according to
9135 prototypes in tparam.h.
9137 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9139 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9140 Adapt all references accordingly.
9142 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9144 2011-03-11 Tom Tromey <tromey@redhat.com>
9146 * buffer.c (syms_of_buffer): Remove obsolete comment.
9148 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9150 * termhooks.h (encode_terminal_code): Declare prototype.
9152 * msdos.c (encode_terminal_code): Don't declare prototype.
9154 * term.c (encode_terminal_code): Now external again, used by
9155 w32console.c and msdos.c.
9157 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9158 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9160 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9162 Fix some minor problems found by GCC 4.5.2's static checks.
9164 * fringe.c (update_window_fringes): Mark locals as initialized
9166 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9168 * alloc.c (mark_fringe_data): Move decl from here ...
9169 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9170 to check its interface.
9171 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9173 * fontset.c (free_realized_fontset): Now static.
9174 (Fset_fontset_font): Rename local to avoid shadowing.
9175 (fontset_font): Mark local as initialized.
9176 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9178 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9180 * xselect.c (x_disown_buffer_selections): Remove; not used.
9181 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9182 (x_own_selection, Fx_disown_selection_internal): Rename locals
9184 (x_handle_dnd_message): Remove local to avoid shadowing.
9186 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9187 so that the caller can use some name other than gcpro1.
9188 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9189 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9190 (Fx_backspace_delete_keys_p):
9191 Use them to avoid shadowing, and rename vars to avoid shadowing.
9192 (x_decode_color, x_set_name, x_window): Now static.
9193 (Fx_create_frame): Add braces to silence GCC warning.
9194 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9195 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9196 Remove unused locals.
9197 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9198 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9199 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9202 * xterm.h (x_mouse_leave): New decl.
9204 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9205 Remove unused functions.
9206 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9207 (x_calc_absolute_position): Now static.
9208 (XTread_socket): Don't define label "out" unless it's used.
9209 Don't declare local "event" unless it's used.
9210 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9211 unless they are used.
9212 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9213 (x_fatal_error_signal): Remove; not used.
9214 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9215 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9216 (x_error_catcher, x_connection_closed, x_error_handler):
9217 (x_error_quitter, xembed_send_message, x_iconify_frame):
9218 (my_log_handler): Rename locals to avoid shadowing.
9219 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9220 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9222 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9223 Rename or move locals to avoid shadowing.
9224 (tty_defined_color, merge_face_heights): Now static.
9225 (free_realized_faces_for_fontset): Remove; not used.
9226 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9227 does not deduce is never used uninitialized.
9228 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9229 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9231 * terminal.c (store_terminal_param): Now static.
9233 * xmenu.c (menu_highlight_callback): Now static.
9234 (set_frame_menubar): Remove unused local.
9235 (xmenu_show): Rename parameter to avoid shadowing.
9236 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9237 since they might point to immutable storage.
9238 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9239 since it's unused otherwise.
9241 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9242 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9243 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9244 avoids a gcc -Wuninitialized diagnostic.
9245 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9246 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9247 does not deduce are never used uninitialized.
9249 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9251 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9252 * window.c (window_loop, size_window):
9253 (run_window_configuration_change_hook, enlarge_window): Likewise.
9255 * window.c (display_buffer): Now static.
9256 (size_window): Mark variables that gcc -Wuninitialized
9257 does not deduce are never used uninitialized.
9258 * window.h (check_all_windows): New decl, to forestall
9259 gcc -Wmissing-prototypes diagnostic.
9260 * dispextern.h (bidi_dump_cached_states): Likewise.
9262 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9264 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9266 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9267 and to avoid gcc -Wuninitialized warning.
9268 (load_charset_map): Mark variables that gcc -Wuninitialized
9269 does not deduce are never used uninitialized.
9270 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9272 * coding.c (coding_set_source, coding_set_destination):
9273 Use "else { /* comment */ }" rather than "else /* comment */;"
9274 for clarity, and to avoid gcc -Wempty-body warning.
9275 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9276 a block, when the outer 'i' will do.
9277 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9278 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9279 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9280 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9281 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9282 Rename locals to avoid shadowing.
9283 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9284 * coding.c (emacs_mule_char, encode_invocation_designation):
9285 Now static, since they're not used elsewhere.
9286 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9287 (decode_coding_object, encode_coding_object, detect_coding_system):
9288 (decode_coding_emacs_mule): Mark variables that gcc
9289 -Wuninitialized does not deduce are never used uninitialized.
9290 (detect_coding_iso_2022): Initialize a local variable that might
9291 be used uninitialized. Leave a FIXME because it's not clear that
9292 this initialization is needed. (Bug#8211)
9293 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9294 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9295 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9296 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9297 Remove unused macros.
9299 * category.c (hash_get_category_set): Remove unused local var.
9300 (copy_category_table): Now static, since it's not used elsewhere.
9301 * character.c (string_count_byte8): Likewise.
9303 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9304 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9306 * chartab.c (copy_sub_char_table): Now static, since it's not used
9308 (sub_char_table_ref_and_range, char_table_ref_and_range):
9309 Rename locals to avoid shadowing.
9310 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9312 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9313 (BIDI_BOB): Remove unused macro.
9315 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9316 deduce are never used uninitialized.
9317 * term.c (encode_terminal_code): Likewise.
9319 * term.c (encode_terminal_code): Now static. Remove unused local.
9321 * tparam.h: New file.
9322 * term.c, tparam.h: Include it.
9323 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9324 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9325 Move these decls to tparam.h, and make them agree with what
9326 is actually in tparam.c. The previous trick of using incompatible
9327 decls in different modules does not conform to the C standard.
9328 All callers of tparam changed to use tparam's actual API.
9329 * tparam.c (tparam1, tparam, tgoto):
9330 Use const pointers where appropriate.
9332 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9333 * cm.h (struct cm): Likewise.
9334 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9335 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9336 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9337 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9338 (turn_on_face, init_tty): Likewise.
9339 * termchar.h (struct tty_display_info): Likewise.
9341 * term.c (term_mouse_position): Rename local to avoid shadowing.
9343 * alloc.c (mark_ttys): Move decl from here ...
9344 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9346 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9348 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9350 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9352 * search.c (compile_pattern_1): Remove argument regp, unused since
9353 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9354 (compile_pattern): Don't pass it.
9356 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9358 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9359 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9361 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9363 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9365 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9366 gdk_window_get_screen, gdk_window_get_geometry,
9367 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9368 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9369 (xg_get_pixbuf_from_pixmap): New function.
9370 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9371 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9372 Call xg_get_pixbuf_from_pixmap instead of
9373 gdk_pixbuf_get_from_drawable.
9374 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9375 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9376 (xg_check_special_colors): Use GtkStyleContext and its functions
9378 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9379 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9380 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9381 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9382 Call gtk_widget_get_preferred_size.
9383 (xg_frame_resized): gdk_window_get_geometry only takes 5
9385 (xg_win_to_widget, xg_event_is_for_menubar):
9386 Call gdk_x11_window_lookup_for_display.
9387 (xg_set_widget_bg): New function.
9388 (delete_cb): New function.
9389 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9390 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9391 (xg_set_background_color): Call xg_set_widget_bg.
9392 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9393 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9394 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9395 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9397 (update_frame_tool_bar): Call gtk_widget_hide.
9398 (xg_initialize): Use GDK_KEY_g.
9400 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9402 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9404 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9405 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9406 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9408 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9410 * w32xfns.c (select_palette): Check success of RealizePalette against
9411 GDI_ERROR, not zero.
9413 See ChangeLog.11 for earlier changes.
9419 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9421 This file is part of GNU Emacs.
9423 GNU Emacs is free software: you can redistribute it and/or modify
9424 it under the terms of the GNU General Public License as published by
9425 the Free Software Foundation, either version 3 of the License, or
9426 (at your option) any later version.
9428 GNU Emacs is distributed in the hope that it will be useful,
9429 but WITHOUT ANY WARRANTY; without even the implied warranty of
9430 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9431 GNU General Public License for more details.
9433 You should have received a copy of the GNU General Public License
9434 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.