1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
3 * image.c: Integer and memory overflow fixes.
4 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
5 now that they've been promoted to lisp.h.
6 (x_allocate_bitmap_record, x_alloc_image_color)
7 (make_image_cache, cache_image, xpm_load):
8 Don't update size until alloc is done.
9 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
11 Check for size calculation overflow.
12 (ct_colors_allocated_max): New constant.
13 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
16 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
18 * gtkutil.c: Integer overflow fixes.
19 (get_utf8_string, xg_store_widget_in_map):
20 Check for size-calculation overflow.
21 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
22 do, as we prefer signed integers.
23 (id_to_widget.max_size, id_to_widget.used)
24 (xg_store_widget_in_map, xg_remove_widget_from_map)
25 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
26 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
27 Use and return ptrdiff_t, not int.
28 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
29 * gtkutil.h: Change prototypes to match the above.
31 * ftfont.c: Check for size overflow.
32 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
33 Check for integer overflow in size calculations.
35 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
37 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
38 This is for the members text_lines, text_cols, total_lines, total_cols,
39 where the system imposes an 'int' limit.
41 * frame.c: Integer overflow fixes.
42 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
43 (x_figure_window_size): Check for integer overflow.
44 (x_set_alpha): Do not assume XINT fits in int.
46 * eval.c: Integer and memory overflow fixes.
47 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
48 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
50 * emacs.c (main, sort_args): Check for size-calculation overflow.
52 * editfns.c: Integer and memory overflow fixes.
53 (set_time_zone_rule): Don't assume environment length fits in int.
54 (message_length): Now ptrdiff_t, not int.
55 (Fmessage_box): Don't update size until allocation succeeds.
56 Don't assume message length fits in int.
57 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
59 * doc.c: Integer and memory overflow fixes.
60 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
61 (get_doc_string): Check for size calculation overflow.
62 Don't update size until allocation succeeds.
63 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
64 EMACS_INT, where ptrdiff_t will do.
65 (Fsubstitute_command_keys): Check for string overflow.
67 Integer and memory overflow fixes for display code.
68 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
69 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
70 Check for overflow in size calculations.
71 (line_draw_cost, realloc_glyph_pool, add_row_entry):
72 Don't assume glyph table len fits in int.
73 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
74 (row_table_size): Now ptrdiff_t, not int.
75 (scrolling_window): Avoid overflow in size calculations.
76 Don't update size until allocation succeeds.
77 * fns.c (concat): Check for overflow in size calculations.
78 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
79 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
80 (NEXT_ALMOST_PRIME_LIMIT): New constant.
82 * composite.c: Integer overflow fixes.
83 (get_composition_id): Check for overflow in glyph length calculations.
85 * coding.c: Integer and memory overflow fixes.
86 (produce_chars): Redo buffer-overflow calculations to avoid
87 unnecessary integer overflow. Check for size overflow.
88 (encode_coding_object): Don't update size until xmalloc succeeds.
90 * character.c (Fstring): Check for size-calculation overflow.
92 * ccl.c: Integer and memory overflow fixes.
93 (Fccl_execute_on_string): Check for memory overflow.
94 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
95 Redo buffer-overflow calculations to avoid integer overflow.
97 * callproc.c (child_setup): Don't assume strlen fits in int.
99 * buffer.c: Memory overflow fixes.
100 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
101 Don't update size of array until after memory allocation succeeds,
102 because xmalloc/xrealloc may not return.
104 * bidi.c: Integer overflow fix.
105 (bidi_shelve_header_size): New constant.
106 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
107 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
109 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
111 Use ptrdiff_t for composition IDs.
112 * character.c (lisp_string_width):
113 * composite.c (composition_table_size, n_compositions)
114 (get_composition_id, composition_gstring_from_id):
115 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
116 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
117 * window.c (Frecenter):
118 Use ptrdiff_t, not int, for composition IDs.
119 * composite.c (get_composition_id): Check for integer overflow.
120 * composite.h: Adjust prototypes to match the above changes.
122 Use ptrdiff_t for hash table indexes.
123 * category.c (hash_get_category_set):
124 * ccl.c (ccl_driver):
125 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
126 * coding.c (coding_system_charset_list, detect_coding_system):
127 * coding.h (struct coding_system.id):
128 * composite.c (get_composition_id, gstring_lookup_cache):
129 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
130 * image.c (xpm_get_color_table_h):
131 * lisp.h (hash_lookup, hash_put):
132 * minibuf.c (Ftest_completion):
133 Use ptrdiff_t for hash table indexes, not int (which is too
134 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
135 32-bit --with-wide-int hosts).
137 * charset.c (Fdefine_charset_internal): Check for integer overflow.
138 Add a FIXME comment about memory leaks.
139 (syms_of_charset): Don't assume xmalloc returns.
141 Don't assume that stated character widths fit in int.
142 * character.c (Fchar_width, c_string_width, lisp_string_width):
143 * character.h (CHAR_WIDTH):
144 * indent.c (MULTIBYTE_BYTES_WIDTH):
145 Use sanitize_char_width to avoid undefined and/or bad behavior
146 with outlandish widths.
147 * character.h (sanitize_tab_width): Renamed from sanitize_width,
148 now that we have two such functions. All uses changed.
149 (sanitize_char_width): New inline function.
151 Don't assume that tab-width fits in int.
152 * character.h (sanitize_width): New inline function.
153 (SANE_TAB_WIDTH): New macro.
154 (ASCII_CHAR_WIDTH): Use it.
155 * indent.c (sane_tab_width): Remove. All uses replaced by
156 SANE_TAB_WIDTH (current_buffer).
157 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
159 * fileio.c: Integer overflow issues with file modes.
160 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
162 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
163 Remove unreachable code.
164 (read_hex, load_charset_map_from_file): Check for integer overflow.
166 * xterm.c: don't go over XClientMessageEvent limit
167 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
168 (x_send_scroll_bar_event): Likewise. Check that the size does not
169 exceed limits imposed by XClientMessageEvent, as well as the usual
170 ptrdiff_t and size_t limits.
172 * keyboard.c: Overflow, signedness and related fixes.
173 (make_lispy_movement): Use same integer type in forward decl
174 that is used in the definition.
175 (read_key_sequence, keyremap_step):
176 Change bufsize argument back to int, undoing my 2011-03-30 change.
177 We prefer signed types, and int is wide enough here.
178 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
179 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
180 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
181 length, not size_t. Use ptrdiff_t for index, not int.
182 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
183 possibility of integer overflow.
185 Overflow, signedness and related fixes for images.
187 * dispextern.h (struct it.stack[0].u.image.image_id)
188 (struct_it.image_id, struct image.id, struct image_cache.size)
189 (struct image_cache.used, struct image_cache.ref_count):
190 * gtkutil.c (update_frame_tool_bar):
191 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
192 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
193 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
194 * nsmenu.m (update_frame_tool_bar):
195 * xdisp.c (calc_pixel_width_or_height):
196 * xfns.c (image_cache_refcount):
197 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
198 on typical 64-bit hosts.
200 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
201 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
202 Omit unnecessary casts to int.
203 (parse_image_spec): Check that integers fall into 'int' range
204 when the callers expect that.
205 (image_ascent): Redo ascent calculation to avoid int overflow.
206 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
207 (lookup_image): Remove unnecessary tests.
208 (xbm_image_p): Locals are now of int, not EMACS_INT,
209 since parse_image_check makes sure they fit into int.
210 (png_load, gif_load, svg_load_image):
211 Prefer int to unsigned where either will do.
212 (tiff_handler): New function, combining the cores of the
213 old tiff_error_handler and tiff_warning_handler. This
214 function is rewritten to use vsnprintf and thereby avoid
215 stack buffer overflows. It uses only the features of vsnprintf
216 that are common to both POSIX and native Microsoft.
217 (tiff_error_handler, tiff_warning_handler): Use it.
218 (tiff_load, gif_load, imagemagick_load_image):
219 Don't assume :index value fits in 'int'.
220 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
221 (imagemagick_load_image): Check that crop parameters fit into
222 the integer types that MagickCropImage accepts. Don't assume
223 Vimagemagick_render_type has a nonnegative value. Don't assume
224 size_t fits in 'long'.
225 (gs_load): Use printmax_t to print the widest integers possible.
226 Check for integer overflow when computing image height and width.
228 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
230 Integer signedness and overflow and related fixes. (Bug#9079)
232 * bidi.c: Integer size and overflow fixes.
233 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
234 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
235 (bidi_cache_find_level_change, bidi_cache_ensure_space)
236 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
237 (bidi_find_other_level_edge):
238 Use ptrdiff_t instead of EMACS_INT where either will do.
239 This works better on 32-bit hosts configured --with-wide-int.
240 (bidi_cache_ensure_space): Check for size-calculation overflow.
241 Use % rather than repeated addition, for better worst-case speed.
242 Don't set bidi_cache_size until after xrealloc returns, because it
244 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
245 (bidi_cache_ensure_space): Also check that the bidi cache size
246 does not exceed that of the largest Lisp string or buffer. See Eli
247 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
249 * alloc.c (__malloc_size_t): Remove.
250 All uses replaced by size_t. See Andreas Schwab's note
251 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
253 * image.c: Improve checking for integer overflow.
254 (check_image_size): Assume that f is nonnull, since
255 it is always nonnull in practice. This is one less thing to
256 worry about when checking for integer overflow later.
257 (x_check_image_size): New function, which checks for integer
258 overflow issues inside X.
259 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
260 This removes the need for a memory_full check.
261 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
262 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
263 (xbm_read_bitmap_data): Change locals back to 'int', since
264 their values must fit in 'int'.
265 (xpm_load_image, png_load, tiff_load):
266 Invoke x_create_x_image_and_pixmap earlier,
267 to avoid much needless work if the image is too large.
268 (tiff_load): Treat overly large images as if
269 x_create_x_image_and_pixmap failed, not as malloc failures.
270 (gs_load): Use x_check_image_size.
272 * gtkutil.c: Omit integer casts.
273 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
274 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
276 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
278 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
279 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
280 would wrongly return t on a 64-bit host.
282 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
283 The plain *_OVERFLOW macros run afoul of GCC bug 49705
284 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
285 and therefore cause GCC to emit a bogus diagnostic in some cases.
287 * image.c: Integer signedness and overflow and related fixes.
288 This is not an exhaustive set of fixes, but it's time to
289 record what I've got.
290 (lookup_pixel_color, check_image_size): Remove redundant decls.
291 (check_image_size): Don't assume that arbitrary EMACS_INT values
292 fit in 'int', or that arbitrary 'double' values fit in 'int'.
293 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
294 (tiff_load, imagemagick_load_image):
295 Check for overflow in size calculations.
296 (x_create_x_image_and_pixmap): Remove unnecessary test for
297 xmalloc returning NULL; that can't happen.
298 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
299 (xpm_color_bucket): Use better integer hashing function.
300 (xpm_cache_color): Don't possibly over-allocate memory.
301 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
303 Use ptrdiff_t, not int or size_t, to record sizes.
304 (png_load): Don't assume values greater than 2**31 fit in 'int'.
305 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
306 either works, as we prefer signed integers.
307 (tiff_read_from_memory, tiff_write_from_memory):
308 Return tsize_t, not size_t, since that's what the TIFF API wants.
309 (tiff_read_from_memory): Don't fail simply because the read would
310 go past EOF; instead, return a short read.
311 (tiff_load): Omit no-longer-needed casts.
312 (Fimagemagick_types): Don't assume size fits into 'int'.
314 Improve hashing quality when configured --with-wide-int.
315 * fns.c (hash_string): New function, taken from sxhash_string.
316 Do not discard information about ASCII character case; this
317 discarding is no longer needed.
318 (sxhash-string): Use it. Change sig to match it. Caller changed.
319 * lisp.h: Declare it.
320 * lread.c (hash_string): Remove, since we now use fns.c's version.
321 The fns.c version returns a wider integer if --with-wide-int is
322 specified, so this should help the quality of the hashing a bit.
324 * emacs.c: Integer overflow minor fix.
325 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
326 Define only if GNU_LINUX.
327 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
329 * dispnew.c: Integer signedness and overflow fixes.
330 Remove unnecessary forward decls, that were a maintenance hassle.
331 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
333 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
334 (scrolling_window): Use ptrdiff_t, not int, for byte count.
335 (prepare_desired_row, line_draw_cost):
336 Use int, not unsigned, where either works.
337 (save_current_matrix, restore_current_matrix):
338 Use ptrdiff_t, not size_t, where either works.
339 (init_display): Check for overflow more accurately, and without
340 relying on undefined behavior.
342 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
343 Remove, replacing with the new symbols in lisp.h. All uses changed.
344 * fileio.c (make_temp_name):
345 * filelock.c (lock_file_1, lock_file):
346 * xdisp.c (message_dolog):
347 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
348 Use pMd etc. instead.
349 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
350 replacing the pWIDE etc. symbols removed from editfns.c.
352 * keyboard.h (num_input_events): Now uintmax_t.
353 This is (very slightly) less likely to mess up due to wraparound.
356 * buffer.c: Integer signedness fixes.
357 (alloc_buffer_text, enlarge_buffer_text):
358 Use ptrdiff_t rather than size_t when either will do, as we prefer
361 * alloc.c: Integer signedness and overflow fixes.
362 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
363 (__malloc_size_t): Default to size_t, not to int.
364 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
365 (Fgarbage_collect, mark_object_loop_halt, mark_object):
366 Prefer ptrdiff_t to size_t when either would do, as we prefer
368 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
369 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
370 Now const. Initialize with values that are in range even if char
372 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
373 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
374 These functions do the right thing with sizes > 2**32.
375 (check_depth): Now ptrdiff_t, not int.
376 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
377 Adjust to new way of storing sizes. Check for size overflow bugs
379 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
380 slightly wrong anyway, as it missed one instance of
381 XMALLOC_OVERRUN_CHECK_OVERHEAD.
382 (refill_memory_reserve): Omit needless cast to size_t.
383 (mark_object_loop_halt): Mark as externally visible.
385 * xselect.c: Integer signedness and overflow fixes.
386 (Fx_register_dnd_atom, x_handle_dnd_message):
387 Use ptrdiff_t, not size_t, since we prefer signed.
388 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
389 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
390 x_dnd_atoms_size and x_dnd_atoms_length.
392 * doprnt.c: Prefer signed to unsigned when either works.
396 * xdisp.c (vmessage):
397 Use ptrdiff_t, not size_t, when using or implementing doprnt,
398 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
399 prefer signed arithmetic to avoid comparison confusion.
400 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
403 Assume freestanding C89 headers, string.h, stdlib.h.
404 * data.c, doprnt.c, floatfns.c, print.c:
405 Include float.h unconditionally.
406 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
407 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
408 * regex.c: Likewise for stddef.h, string.h.
409 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
410 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
411 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
412 (STDC_HEADERS): Remove obsolete defines.
413 * sysdep.c: Include limits.h unconditionally.
415 Assume support for memcmp, memcpy, memmove, memset.
416 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
417 * regex.c (memcmp, memcpy):
418 Remove; we assume C89 now.
420 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
421 (__malloc_safe_bcopy): Remove; no longer needed.
423 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
424 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
425 well either way, and we prefer signed to unsigned.
427 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
430 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
431 and the surrounding thread.
432 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
433 rather than fgets, and retry after EINTR. Otherwise, 'emacs
434 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
436 * s/openbsd.h (BROKEN_SIGIO): Define.
437 * unexelf.c (unexec) [__OpenBSD__]:
438 Don't update the .mdebug section of the Alpha COFF symbol table.
440 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
442 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
445 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
447 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
448 This fixes some race conditions on the permissions of any newly
451 * alloc.c (valid_pointer_p): Use pipe, not open.
452 This fixes some permissions issues when debugging.
454 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
455 If fchown fails to set both uid and gid, try to set just gid,
456 as that is sometimes allowed. Adjust the file's mode to eliminate
457 setuid or setgid bits that are inappropriate if fchown fails.
459 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
461 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
462 to compare Lisp_Objects.
463 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
464 global_gnutls_log_level, don't mistake it for a Lisp_Object.
465 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
467 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
469 * lread.c (read_integer): Unread even EOF character.
470 (read1): Likewise. Properly record start position of symbol.
472 * lread.c (read1): Read `#:' as empty uninterned symbol if no
473 symbol character follows.
475 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
477 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
478 This works around a problem with the previous change to Fcopy_file.
479 Recent glibc declares fchown with __attribute__((warn_unused_result)),
480 and without this change, GCC might complain about discarding
481 fchown's return value.
483 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
485 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
487 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
489 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
491 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
493 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
494 it's used from the C level.
496 * process.c: Use the same condition for POLL_FOR_INPUT in both
497 keyboard.c and process.c (bug#1858).
499 2011-07-09 Lawrence Mitchell <wence@gmx.li>
501 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
502 (Fgnutls_boot): Use it.
504 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
506 * doc.c (Fsubstitute_command_keys): Revert last change.
508 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
510 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
511 quotes the next character, and doesn't affect other longer
512 sequences (bug#8935).
514 * lread.c (syms_of_lread): Clarify that is isn't only
515 `eval-buffer' and `eval-defun' that's affected by
516 `lexical-binding' (bug#8460).
518 2011-07-15 Eli Zaretskii <eliz@gnu.org>
520 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
521 bidi redisplay when a line includes both an image and is
524 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
526 Fix minor problems found by static checking.
527 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
528 (elsz): Now a signed constant, not a size_t var. We prefer signed
529 types to unsigned, to avoid integer comparison confusion. Without
530 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
531 "cannot optimize loop, the loop counter may overflow", a symptom
533 * indent.c (Fvertical_motion): Mark locals as initialized.
534 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
536 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
538 * search.c (Fre_search_backward): Mention `case-fold-search' in
539 all the re_search_* functions (bug#8138).
541 * keyboard.c (Fopen_dribble_file): Document when the file is
544 2011-07-14 Eli Zaretskii <eliz@gnu.org>
546 * bidi.c (bidi_dump_cached_states): Fix format of displaying
549 Support bidi reordering of display and overlay strings.
550 * xdisp.c (compute_display_string_pos)
551 (compute_display_string_end): Accept additional argument STRING.
552 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
553 (reseat_to_string): Initialize bidi_it->string.s and
554 bidi_it->string.schars.
555 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
556 NULL (avoids a crash in bidi_paragraph_init). Initialize
558 (init_iterator): Call bidi_init_it only of a valid
559 buffer position was specified. Initialize paragraph_embedding to
561 (reseat_to_string): Initialize the bidi iterator.
562 (display_string): If we need to ignore text properties of
563 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
564 original value of -1 will not work with bidi.)
565 (compute_display_string_pos): First arg is now struct
566 `text_pos *'; all callers changed. Support display properties on
568 (compute_display_string_end): Support display properties on Lisp
570 (init_iterator, reseat_1, reseat_to_string): Initialize the
571 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
572 when iterating on a string not from display properties).
573 (compute_display_string_pos, compute_display_string_end): Fix
574 calculation of the object to scan. Fixes an error when using
576 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
577 base_level_stop; instead, set base_level_stop to BEGV. Fixes
578 crashes in vertical-motion.
579 (next_element_from_buffer): Improve commentary for when
580 the iterator is before prev_stop.
581 (init_iterator): Initialize bidi_p from the default value of
582 bidi-display-reordering, not from buffer-local value. Use the
583 buffer-local value only if initializing for buffer iteration.
584 (handle_invisible_prop): Support invisible properties on strings
585 that are being bidi-reordered.
586 (set_iterator_to_next): Support bidi reordering of C strings and
588 (next_element_from_string): Support bidi reordering of Lisp
590 (handle_stop_backwards): Support Lisp strings as well.
591 (display_string): Support display of R2L glyph rows. Use
592 IT_STRING_CHARPOS when displaying from a Lisp string.
593 (init_iterator): Don't initialize it->bidi_p for strings
595 (reseat_to_string): Initialize it->bidi_p for strings here.
596 (next_element_from_string, next_element_from_c_string)
597 (next_element_from_buffer): Add xassert's for correspondence
598 between IT's object being iterated and it->bidi_it.string
600 (face_before_or_after_it_pos): Support bidi iteration.
601 (next_element_from_c_string): Handle the case of the first string
602 character that is not the first one in the visual order.
603 (get_visually_first_element): New function, refactored from common
604 parts of next_element_from_buffer, next_element_from_string, and
605 next_element_from_c_string.
606 (tool_bar_lines_needed, redisplay_tool_bar)
607 (display_menu_bar): Force left-to-right direction. Add a FIXME
608 comment for making that be controlled by a user option.
609 (push_it, pop_it): Save and restore the state of the
610 bidi iterator. Save and restore the bidi_p flag.
611 (pop_it): Iterate out of display property for string iteration as
613 (iterate_out_of_display_property): Support iteration over strings.
614 (handle_single_display_spec): Set up it->bidi_it for iteration
615 over a display string, and call bidi_init_it.
616 (handle_single_display_spec, next_overlay_string)
617 (get_overlay_strings_1, push_display_prop): Set up the bidi
618 iterator for displaying display or overlay strings.
619 (forward_to_next_line_start): Don't use the shortcut if
621 (back_to_previous_visible_line_start): If handle_display_prop
622 pushed the iterator stack, restore the internal state of the bidi
623 iterator by calling bidi_pop_it same number of times.
624 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
625 and we are bidi-iterating, don't decrement the iterator position;
626 instead, set the first_elt flag in the bidi iterator, to produce
628 (reseat_1): Remove redundant setting of string_from_display_prop_p.
629 (push_display_prop): xassert that we are iterating a buffer.
630 (push_it, pop_it): Save and restore paragraph_embedding member.
631 (handle_single_display_spec, next_overlay_string)
632 (get_overlay_strings_1, reseat_1, reseat_to_string)
633 (push_display_prop): Set up the `unibyte' member of bidi_it.string
634 correctly. Don't assume unibyte strings are not bidi-reordered.
635 (compute_display_string_pos)
636 (compute_display_string_end): Fix handling the case of C string.
637 (push_it, pop_it): Save and restore from_disp_prop_p.
638 (handle_single_display_spec, push_display_prop): Set the
639 from_disp_prop_p flag.
640 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
641 (pop_it): Call iterate_out_of_display_property only if we are
642 popping after iteration over a string that came from a display
643 property. Fix a typo in popping stretch info. Add an assertion
644 for verifying that the iterator position is in sync with the bidi
646 (handle_single_display_spec, get_overlay_strings_1)
647 (push_display_prop): Fix initialization of paragraph direction for
648 string when that of the parent object is not yet determined.
649 (reseat_1): Call bidi_init_it to resync the bidi
650 iterator with IT's position. (Bug#7616)
651 (find_row_edges): If ROW->start.pos gives position
652 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
653 (handle_stop, back_to_previous_visible_line_start, reseat_1):
654 Reset the from_disp_prop_p flag.
655 (SAVE_IT, RESTORE_IT): New macros.
656 (pos_visible_p, face_before_or_after_it_pos)
657 (back_to_previous_visible_line_start)
658 (move_it_in_display_line_to, move_it_in_display_line)
659 (move_it_to, move_it_vertically_backward, move_it_by_lines)
660 (try_scrolling, redisplay_window, display_line): Use them when
661 saving a temporary copy of the iterator and restoring it back.
662 (back_to_previous_visible_line_start, reseat_1)
663 (init_iterator): Empty the bidi cache "stack".
664 (move_it_in_display_line_to): If iterator ended up at
665 EOL, but we never saw any buffer positions smaller than
666 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
667 motion in bidi-reordered lines.
668 (move_it_in_display_line_to): Record prev_method and prev_pos
669 immediately before the call to set_iterator_to_next. Fixes cursor
670 motion in bidi-reordered lines with stretch glyphs and strings
671 displayed in margins. (Bug#8133) (Bug#8867)
672 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
674 (pos_visible_p): Support positions in bidi-reordered lines. Save
675 and restore bidi cache.
677 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
678 (bidi_paragraph_info): Delete unused struct.
679 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
680 (bidi_cache_start): New variable.
681 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
683 (bidi_cache_fetch_state, bidi_cache_search)
684 (bidi_cache_find_level_change, bidi_cache_iterator_state)
685 (bidi_cache_find, bidi_peek_at_next_level)
686 (bidi_level_of_next_char, bidi_find_other_level_edge)
687 (bidi_move_to_visually_next): Compare cache index with
688 bidi_cache_start rather than with zero.
689 (bidi_fetch_char): Accept new argument STRING; all callers
690 changed. Support iteration over a string. Support strings with
691 display properties. Support unibyte strings. Fix the type of
692 `len' according to what STRING_CHAR_AND_LENGTH expects.
693 (bidi_paragraph_init, bidi_resolve_explicit_1)
694 (bidi_resolve_explicit, bidi_resolve_weak)
695 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
696 iteration over a string.
697 (bidi_set_sor_type, bidi_resolve_explicit_1)
698 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
699 can now be zero (for strings); special values 0 and -1 were
700 changed to -1 and -2, respectively.
701 (bidi_char_at_pos): New function.
702 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
703 Call it instead of FETCH_MULTIBYTE_CHAR.
704 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
705 initialized to valid values.
706 (bidi_init_it): Don't initialize charpos and bytepos with invalid
708 (bidi_level_of_next_char): Allow the sentinel "position" to pass
709 the test for valid cached positions. Fix the logic for looking up
710 the sentinel state in the cache. GCPRO the Lisp string we are
712 (bidi_push_it, bidi_pop_it): New functions.
713 (bidi_initialize): Initialize the bidi cache start stack pointer.
714 (bidi_cache_ensure_space): New function, refactored from part of
715 bidi_cache_iterator_state. Don't assume the required size is just
716 one BIDI_CACHE_CHUNK away.
717 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
718 (bidi_count_bytes, bidi_char_at_pos): New functions.
719 (bidi_cache_search): Don't assume bidi_cache_last_idx is
720 always valid if bidi_cache_idx is valid.
721 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
722 is valid if it's going to be used.
723 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
724 (bidi_cache_fetch_state, bidi_cache_search)
725 (bidi_cache_find_level_change, bidi_cache_ensure_space)
726 (bidi_cache_iterator_state, bidi_cache_find)
727 (bidi_find_other_level_edge, bidi_cache_start_stack): All
728 variables related to cache indices are now EMACS_INT.
730 * dispextern.h (struct bidi_string_data): New structure.
731 (struct bidi_it): New member `string'. Make flag members be 1-bit
732 fields, and put them last in the struct.
733 (compute_display_string_pos, compute_display_string_end): Update
735 (bidi_push_it, bidi_pop_it): Add prototypes.
736 (struct iterator_stack_entry): New members bidi_p,
737 paragraph_embedding, and from_disp_prop_p.
738 (struct it): Member bidi_p is now a bit field 1 bit wide.
739 (bidi_shelve_cache, bidi_unshelve_cache): Declare
742 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
743 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
744 and vector-like objects.
746 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
747 cache around display iteration.
749 * window.c (Fwindow_end, window_scroll_pixel_based)
750 (displayed_window_lines, Frecenter): Save and restore the bidi
751 cache around display iteration.
753 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
755 * editfns.c (Fdelete_region): Clarify the use of the named
756 parameters (bug#6788).
758 2011-07-14 Martin Rudalics <rudalics@gmx.at>
760 * indent.c (Fvertical_motion): Set and restore w->pointm when
761 saving and restoring the window's buffer (Bug#9006).
763 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
765 * editfns.c (Fstring_to_char): Clarify just what is returned
766 (bug#6576). Text by Eli Zaretskii.
768 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
770 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
772 2011-07-13 Eli Zaretskii <eliz@gnu.org>
774 * buffer.c (mmap_find): Fix a typo.
776 2011-07-13 Johan Bockgård <bojohan@gnu.org>
778 Fix execution of x selection hooks.
779 * xselect.c (Qx_lost_selection_functions)
780 (Qx_sent_selection_functions): New vars.
781 (syms_of_xselect): DEFSYM them.
782 (x_handle_selection_request): Pass Qx_sent_selection_functions
783 rather than Vx_sent_selection_functions to Frun_hook_with_args.
784 (x_handle_selection_clear,x_clear_frame_selections):
785 Pass Qx_lost_selection_functions rather than
786 Vx_lost_selection_functions to Frun_hook_with_args.
788 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
790 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
791 The old code sometimes used this field without initializing it.
793 * alloc.c (gc_sweep): Don't read past end of array.
794 In theory, the old code could also have corrupted Emacs internals,
795 though it'd be very unlikely.
797 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
799 * character.c (Fcharacterp): Don't advertise optional ignored
802 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
804 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
807 * window.c (Fset_window_start): Doc fix (bug#4199).
808 (Fset_window_hscroll): Ditto.
810 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
812 Fix minor new problems caught by GCC 4.6.1.
813 * term.c (init_tty): Remove unused local.
814 * xsettings.c (store_monospaced_changed): Define this function only
815 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
818 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
820 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
822 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
824 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
825 are the mini-buffer and the echo area (bug#3320).
827 * term.c (init_tty): Remove support for supdup, c10 and perq
828 terminals, which are no longer supported (bug#1482).
830 2011-07-10 Johan Bockgård <bojohan@gnu.org>
832 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
834 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
836 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
837 for non-popups (Bug#3642).
839 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
841 * alloc.c (reset_malloc_hooks): Protoize.
842 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
843 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
844 * cm.c (losecursor): Likewise.
845 * data.c (fmod): Likewise.
846 * dispnew.c (swap_glyphs_in_rows): Likewise.
847 * emacs.c (memory_warning_signal): Likewise.
848 * floatfns.c (float_error): Likewise.
849 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
850 (otf_open, font_otf_capability, generate_otf_features)
851 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
853 * image.c (pbm_read_file): Likewise.
854 * indent.c (string_display_width): Likewise.
855 * intervals.c (check_for_interval, search_for_interval)
856 (inc_interval_count, count_intervals, root_interval)
857 (adjust_intervals_for_insertion, make_new_interval): Likewise.
858 * lread.c (defalias): Likewise.
859 * ralloc.c (r_alloc_check): Likewise.
860 * regex.c (set_image_of_range_1, set_image_of_range)
861 (regex_grow_registers): Likewise.
862 * sysdep.c (strerror): Likewise.
863 * termcap.c (valid_filename_p, tprint, main): Likewise.
864 * tparam.c (main): Likewise.
865 * unexhp9k800.c (run_time_remap, save_data_space)
866 (update_file_ptrs, read_header, write_header, calculate_checksum)
867 (copy_file, copy_rest, display_header): Likewise.
868 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
870 * xdisp.c (check_it): Likewise.
871 * xfaces.c (register_color, unregister_color, unregister_colors):
873 * xfns.c (print_fontset_result): Likewise.
874 * xrdb.c (member, fatal, main): Likewise.
876 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
878 Fix minor problems found by static checking (Bug#9031).
879 * chartab.c (char_table_set_range, map_sub_char_table):
880 Remove unused locals.
881 (uniprop_table): Now static.
882 * composite.c (_work_char): Remove unused static var.
884 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
886 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
888 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
890 * gtkutil.c (qttip_cb): Remove code without function.
892 2011-07-09 Eli Zaretskii <eliz@gnu.org>
894 * w32.c (pthread_sigmask): New stub.
896 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
898 Use pthread_sigmask, not sigprocmask (Bug#9010).
899 sigprocmask is portable only for single-threaded applications, and
900 Emacs can be multi-threaded when it uses GTK.
901 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
903 * callproc.c (Fcall_process):
904 * process.c (create_process):
905 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
906 Use pthread_sigmask, not sigprocmask.
908 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
910 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
911 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
914 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
916 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
917 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
918 (xg_hide_tooltip): Fix comment.
920 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
921 in registerServicesMenuSendTypes.
922 (validRequestorForSendType): Don't check ns_return_types.
924 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
927 2011-07-08 Jason Rumney <jasonr@gnu.org>
929 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
930 frame struct members of non-existent frames (Bug#6284).
932 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
934 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
935 variable firstTime not needed on OSX >= 10.6.
936 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
937 >= 10.5. Use setKnobProportion, setDoubleValue.
939 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
940 (MAC_OS_X_VERSION_10_5): Define if not defined.
941 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
942 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
943 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
945 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
946 cString and lossyCString on OSX >= 10.4
948 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
949 sizeToFit on OSX >= 10.2.
951 * nsimage.m (allocInitFromFile): Don't use deprecated method
952 bestRepresentationForDevice on OSX >= 10.6.
954 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
957 * emacs.c: Declare unexec_init_emacs_zone.
959 * nsgui.h: Fix compiler warning about gnulib redefining verify.
961 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
963 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
964 on svcsMenu (Bug#8842).
966 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
968 (Fns_list_services): Just return Qnil on 10.6, code not working there.
970 * nsterm.m (QUTF8_STRING): Declare.
971 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
972 (validRequestorForSendType): Return type is (id).
973 Change indexOfObjectIdenticalTo to indexOfObject.
974 Check if we have local selection before returning self (Bug#8842).
975 (writeSelectionToPasteboard): Put local selection into paste board
976 if we have a local selection (Bug#8842).
977 (syms_of_nsterm): DEFSYM QUTF8_STRING.
979 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
980 (ns_get_local_selection): Declare.
982 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
984 * keymap.c (describe_map_tree): Don't insert a double newline at
985 the end of the buffer (bug#1169) and return whether we inserted
988 * callint.c (Fcall_interactively): Change "reading args" to
989 "providing args" to try to clarify what it does (bug#1010).
991 2011-07-07 Kenichi Handa <handa@m17n.org>
993 * composite.c (composition_compute_stop_pos): Ignore a static
994 composition starting before CHARPOS (Bug#8915).
996 * xdisp.c (handle_composition_prop): Likewise.
998 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1000 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1003 2011-07-07 Kenichi Handa <handa@m17n.org>
1005 * character.h (unicode_category_t): New enum type.
1007 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1008 (Qchar_code_property_table): New variable.
1009 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1010 (UNIPROP_COMPRESSED_FORM_P): New macros.
1011 (char_table_ascii): Uncompress the compressed values.
1012 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1013 Uncompress the compressed values.
1014 (sub_char_table_ref_and_range): Likewise.
1015 (char_table_ref_and_range): Uncompress the compressed values.
1016 (sub_char_table_set): New arg is_uniprop. Callers changed.
1017 Uncompress the compressed values.
1018 (sub_char_table_set_range): Args changed. Callers changed.
1019 (char_table_set_range): Adjuted for the above change.
1020 (map_sub_char_table): Delete args default_val and parent. Add arg
1021 top. Give decoded values to a Lisp function.
1022 (map_char_table): Adjusted for the above change. Give decoded
1023 values to a Lisp function. Gcpro more variables.
1024 (uniprop_table_uncompress)
1025 (uniprop_decode_value_run_length): New functions.
1026 (uniprop_decoder, uniprop_decoder_count): New variables.
1027 (uniprop_get_decoder, uniprop_encode_value_character)
1028 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1030 (uniprop_encoder, uniprop_encoder_count): New variables.
1031 (uniprop_get_encoder, uniprop_table)
1032 (Funicode_property_table_internal, Fget_unicode_property_internal)
1033 (Fput_unicode_property_internal): New functions.
1034 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1035 Sunicode_property_table_internal, Sget_unicode_property_internal,
1036 and Sput_unicode_property_internal. Defvar_lisp
1037 char-code-property-alist.
1039 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1040 Vunicode_category_table.
1042 * font.c (font_range): Adjusted for the change of
1043 Vunicode_category_table.
1045 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1047 * m/iris4d.h: Remove file, move contents ...
1048 * s/irix6-5.h: ... here.
1050 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1052 Remove unportable assumption about struct layout (Bug#8884).
1053 * alloc.c (mark_buffer):
1054 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1055 (clone_per_buffer_values): Don't assume that
1056 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1057 This isn't true in general, and it's particularly not true
1058 if Emacs is configured with --with-wide-int.
1059 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1060 New macros, used in the buffer.c change.
1062 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1064 * xsettings.c: Use both GConf and GSettings if both are available.
1065 (store_config_changed_event): Add comment.
1066 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1067 (store_tool_bar_style_changed): New functions.
1068 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1069 (struct xsettings): Move font inside HAVE_XFT.
1070 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1071 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1072 Move inside HAVE_XFT.
1073 (something_changed_gsettingsCB): Renamed from something_changedCB.
1074 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1076 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1077 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1078 (something_changed_gconfCB): Renamed from something_changedCB.
1079 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1080 (parse_settings): Move check for font inside HAVE_XFT.
1081 (read_settings, apply_xft_settings): Add comment.
1082 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1083 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1084 call store_font_name_changed.
1085 (xft_settings_event): Add comment.
1086 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1087 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1088 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1089 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1090 (xsettings_initialize): Call init_gsettings last.
1091 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1094 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1096 Random fixes. E.g., (random) never returned negative values.
1097 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1098 subseconds part to the entropy, as that's a bit more random.
1099 Prefer signed to unsigned, since the signedness doesn't matter and
1100 in general we prefer signed. When given a limit, use a
1101 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1102 latter isn't right if USE_2_TAGS_FOR_INTS.
1103 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1104 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1106 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1108 * textprop.c (text_property_stickiness):
1109 Obey Vtext_property_default_nonsticky.
1110 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1111 * w32fns.c (syms_of_w32fns):
1112 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1114 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1116 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1117 This is more efficient than Ffile_directory_p and avoids a minor race.
1119 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1121 * buffer.c (Foverlay_put): Say what the return value is
1124 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1125 is a directory before asking whether to use the file name
1127 (barf_or_query_if_file_exists): Make the "File is a directory"
1128 error be more correct.
1130 * fns.c (Frequire): Remove the mention of the .gz files, since
1131 that's installation-specific, but keep the mention of
1132 `get-load-suffixes'.
1134 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1136 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1137 Report string overflow if the output is too long.
1139 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1141 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1142 (syms_of_gnutls): Remove duplicate DEFSYM for
1143 Qgnutls_bootprop_verify_hostname_error, an error for
1144 Qgnutls_bootprop_verify_error (which is no longer used).
1146 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1147 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1148 Also (re)move comments that are misplaced or no longer relevant.
1150 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1152 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1154 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1156 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1157 and background color parameters if they have been changed.
1159 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1161 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1163 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1165 * xsettings.c (SYSTEM_FONT): Define only when used.
1166 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1168 * keymap.c (access_keymap_1): Now static.
1170 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1172 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1173 leave any prefix arg for the up event (Bug#1586).
1175 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1177 * lread.c (syms_of_lread): Mention single symbols defined by
1178 `defvar' or `defconst' (bug#7154).
1180 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1181 (Frequire): Mention get-load-suffixes.
1183 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1185 * window.h (window): Remove clone_number slot.
1186 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1188 (make_parent_window, make_window, saved_window)
1189 (Fset_window_configuration, save_window_save): Don't deal with
1191 * buffer.c (Qclone_number): Remove declaration.
1192 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1194 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1196 Add multiple inheritance to keymaps.
1197 * keymap.c (Fmake_composed_keymap): New function.
1198 (Fset_keymap_parent): Simplify.
1199 (fix_submap_inheritance): Remove.
1200 (access_keymap_1): New function extracted from access_keymap to handle
1201 embedded parents and handle lists of maps.
1202 (access_keymap): Use it.
1203 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1204 (Fcopy_keymap): Handle embedded parents.
1205 (Fcommand_remapping, define_as_prefix): Simplify.
1206 (Fkey_binding): Simplify.
1207 (syms_of_keymap): Move minibuffer-local-completion-map,
1208 minibuffer-local-filename-completion-map,
1209 minibuffer-local-must-match-map, and
1210 minibuffer-local-filename-must-match-map to Elisp.
1211 (syms_of_keymap): Defsubr make-composed-keymap.
1212 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1213 (parse_menu_item): Trivial simplification.
1215 2011-07-01 Glenn Morris <rgm@gnu.org>
1217 * Makefile.in (SETTINGS_LIBS): Fix typo.
1219 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1221 * coding.c (Fencode_coding_string): Record the last coding system
1222 used, as the function doc string says (bug#8738).
1224 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1226 * xsettings.c (store_monospaced_changed): Take new font as arg and
1227 check for change against current_mono_font.
1228 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1229 (emacs_settings_constructor, emacs_settings_get_property)
1230 (emacs_settings_set_property, emacs_settings_class_init)
1231 (emacs_settings_init, gsettings_obj): Remove.
1232 (something_changedCB): New function for HAVE_GSETTINGS.
1233 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1234 with value as argument.
1235 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1236 g_settings_new (Bug#8967). Do not create gsettings_obj.
1237 Remove calls to g_settings_bind. Connect something_changedCB to
1240 * xgselect.c: Add defined (HAVE_GSETTINGS).
1241 (xgselect_initialize): Ditto.
1243 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1244 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1247 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1249 * eval.c (struct backtrace): Simplify and port the data structure.
1250 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1251 signed bit field, as this assumption is not portable and it makes
1252 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1253 "char debug_on_exit : 1" as this is not portable either; instead,
1254 use the portable "unsigned int debug_on_exit : 1". Remove unused
1255 member evalargs. Remove obsolete comments about cc bombing out.
1257 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1259 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1260 Let HAVE_GSETTINGS override HAVE_GCONF.
1261 (store_monospaced_changed): New function.
1262 (EMACS_SETTINGS): A new type derived from GObject to handle
1263 GSettings notifications.
1264 (emacs_settings_constructor, emacs_settings_get_property)
1265 (emacs_settings_set_property, emacs_settings_class_init):
1267 (gsettings_client, gsettings_obj): New variables.
1268 (GSETTINGS_SCHEMA): New define.
1269 (something_changedCB): Call store_monospaced_changed.
1270 (init_gsettings): New function.
1271 (xsettings_initialize): Call init_gsettings.
1272 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1275 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1278 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1280 * window.c (resize_root_window, grow_mini_window)
1281 (shrink_mini_window): Rename Qresize_root_window to
1282 Qwindow_resize_root_window and Qresize_root_window_vertically to
1283 Qwindow_resize_root_window_vertically.
1285 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1287 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1289 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1291 * makefile.w32-in: Redesign dependencies so they reflect more
1292 clearly which files are directly included by each source file,
1293 and not through other includes.
1295 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1297 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1298 (sort_overlays, overlay_strings): When an overlay's clone number
1299 matches the window's clone number process the overlay even if
1300 the overlay's window property doesn't match the current window.
1302 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1303 (Fwindow_hchild): Rename to Fwindow_left_child.
1304 (Fwindow_next): Rename to Fwindow_next_sibling.
1305 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1306 (resize_window_check): Rename to window_resize_check.
1307 (resize_window_apply): Rename to window_resize_apply.
1308 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1309 (Fdelete_other_windows_internal, resize_frame_windows)
1310 (Fsplit_window_internal, Fdelete_window_internal)
1311 (grow_mini_window, shrink_mini_window)
1312 (Fresize_mini_window_internal): Fix callers accordingly.
1314 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1316 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1317 (emacs_fixed_set_min_size): Remove.
1318 (emacs_fixed_new): Take frame as argument.
1320 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1321 (_EmacsFixedPrivate): Remove minwidth/height.
1322 Add struct frame *f.
1323 (emacs_fixed_init): Initialize priv->f.
1324 (get_parent_class, emacs_fixed_set_min_size): Remove.
1325 (emacs_fixed_new): Set priv->f to argument.
1326 (emacs_fixed_get_preferred_width)
1327 (emacs_fixed_get_preferred_height): Use min_width/height from
1328 frames size_hint to set minimum and natural (Bug#8919).
1329 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1330 and use min_width/height from frames size_hint to set
1331 min_width/height (Bug#8919).
1333 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1334 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1337 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1339 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1340 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1343 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1345 * process.c (wait_reading_process_output): Bypass select if
1346 waiting for a cell while ignoring keyboard input, and input is
1347 pending. Suggested by Jan Djärv (Bug#8869).
1349 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1351 Use gnulib's dup2 module instead of rolling our own.
1352 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1354 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1356 * dispnew.c (scrolling_window): Before scrolling, turn off a
1357 mouse-highlight in the window being scrolled.
1359 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1361 Move DEFSYM to lisp.h and use everywhere.
1363 * character.h (DEFSYM): Move declaration...
1364 * lisp.h (DEFSYM): ...here.
1370 * w32select.c: Don't include character.h.
1372 * alloc.c (syms_of_alloc):
1373 * buffer.c (syms_of_buffer):
1374 * bytecode.c (syms_of_bytecode):
1375 * callint.c (syms_of_callint):
1376 * casefiddle.c (syms_of_casefiddle):
1377 * casetab.c (init_casetab_once):
1378 * category.c (init_category_once, syms_of_category):
1379 * ccl.c (syms_of_ccl):
1380 * cmds.c (syms_of_cmds):
1381 * composite.c (syms_of_composite):
1382 * dbusbind.c (syms_of_dbusbind):
1383 * dired.c (syms_of_dired):
1384 * dispnew.c (syms_of_display):
1385 * doc.c (syms_of_doc):
1386 * editfns.c (syms_of_editfns):
1387 * emacs.c (syms_of_emacs):
1388 * eval.c (syms_of_eval):
1389 * fileio.c (syms_of_fileio):
1390 * fns.c (syms_of_fns):
1391 * frame.c (syms_of_frame):
1392 * fringe.c (syms_of_fringe):
1393 * insdel.c (syms_of_insdel):
1394 * keymap.c (syms_of_keymap):
1395 * lread.c (init_obarray, syms_of_lread):
1396 * macros.c (syms_of_macros):
1397 * msdos.c (syms_of_msdos):
1398 * print.c (syms_of_print):
1399 * process.c (syms_of_process):
1400 * search.c (syms_of_search):
1401 * sound.c (syms_of_sound):
1402 * syntax.c (init_syntax_once, syms_of_syntax):
1403 * terminal.c (syms_of_terminal):
1404 * textprop.c (syms_of_textprop):
1405 * undo.c (syms_of_undo):
1406 * w32.c (globals_of_w32):
1407 * window.c (syms_of_window):
1408 * xdisp.c (syms_of_xdisp):
1409 * xfaces.c (syms_of_xfaces):
1410 * xfns.c (syms_of_xfns):
1411 * xmenu.c (syms_of_xmenu):
1412 * xsettings.c (syms_of_xsettings):
1413 * xterm.c (syms_of_xterm): Use DEFSYM.
1415 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1417 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1419 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1421 Integer and buffer overflow fixes (Bug#8873).
1423 * print.c (printchar, strout): Check for string overflow.
1424 (PRINTPREPARE, printchar, strout):
1425 Don't set size unless allocation succeeds.
1427 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1428 for sizes. Check for string overflow more accurately.
1429 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1431 * macros.c: Integer and buffer overflow fixes.
1432 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1433 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1434 Use ptrdiff_t, not int, for sizes.
1435 Don't increment bufsize until after realloc succeeds.
1436 Check for size-calculation overflow.
1437 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1439 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1441 * lread.c: Integer overflow fixes.
1442 (read_integer): Radix is now EMACS_INT, not int,
1443 to improve quality of diagnostics for out-of-range radices.
1444 Calculate buffer size correctly for out-of-range radices.
1445 (read1): Check for integer overflow in radices, and in
1446 read-circle numbers.
1447 (read_escape): Avoid int overflow.
1448 (Fload, openp, read_buffer_size, read1)
1449 (substitute_object_recurse, read_vector, read_list, map_obarray):
1450 Use ptrdiff_t, not int, for sizes.
1451 (read1): Use EMACS_INT, not int, for sizes.
1452 Check for size overflow.
1454 * image.c (cache_image): Check for size arithmetic overflow.
1456 * lread.c: Integer overflow issues.
1457 (saved_doc_string_size, saved_doc_string_length)
1458 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1459 Now ptrdiff_t, not int.
1460 (read1): Don't assume doc string length fits in int. Check for
1461 out-of-range doc string lengths.
1462 (read_list): Don't assume file position fits in int.
1463 (read_escape): Check for hex character overflow.
1465 2011-06-22 Leo Liu <sdl.web@gmail.com>
1467 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1468 Move to minibuffer.el.
1470 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1472 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1473 The following patches are for when GLYPH_DEBUG && !XASSERT.
1474 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1475 * dispnew.c (flush_stdout):
1476 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1477 Mark as externally visible.
1478 * dispnew.c (check_window_matrix_pointers): Now static.
1479 * dispnew.c (window_to_frame_vpos):
1480 * xfns.c (unwind_create_frame):
1481 * xterm.c (x_check_font): Remove unused local.
1482 * scroll.c (CHECK_BOUNDS):
1483 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1484 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1485 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1486 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1487 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1489 (debug_method_add): Use va_list and vsprintf rather than relying
1490 on undefined behavior with wrong number of arguments.
1491 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1492 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1493 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1494 since we're not interested in debugging glyphs with old libraries.
1495 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1496 GCC 4.6.0's static checking.
1498 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1500 Integer overflow and signedness fixes (Bug#8873).
1501 A few related buffer overrun fixes, too.
1503 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1505 * dispextern.h (struct face.stipple):
1506 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1507 (x_bitmap_mask, x_allocate_bitmap_record)
1508 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1509 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1510 (x_create_bitmap_from_xpm_data):
1511 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1512 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1514 * xfaces.c (load_pixmap):
1515 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1516 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1517 (.bitmaps_last, struct x_output.icon_bitmap):
1518 Use ptrdiff_t, not int, for bitmap indexes.
1519 (x_allocate_bitmap_record): Check for size overflow.
1520 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1522 Use ptrdiff_t, not int, for overlay counts.
1523 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1524 * editfns.c (overlays_around, get_pos_property):
1525 * textprop.c (get_char_property_and_overlay):
1526 * xdisp.c (next_overlay_change, note_mouse_highlight):
1527 * xfaces.c (face_at_buffer_position):
1528 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1529 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1530 (Fnext_overlay_change, Fprevious_overlay_change)
1531 (mouse_face_overlay_overlaps, Foverlays_in):
1532 Use ptrdiff_t, not int, for sizes.
1533 (overlays_at, overlays_in): Check for size-calculation overflow.
1535 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1537 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1538 (x_session_initialize): Do not assume string length fits in int.
1540 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1541 This is unlikely, but can occur if DPI is outlandish.
1543 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1544 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1546 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1547 * xrdb.c (magic_file_p, search_magic_path):
1548 Omit last arg SUFFIX; it was always 0. All callers changed.
1549 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1551 * xfont.c (xfont_match): Avoid need for strlen.
1553 * xfns.c: Don't assume strlen fits in int.
1554 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1556 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1557 not unsigned long, as we prefer signed integers. All callers changed.
1558 Detect integer overflow in repeat count.
1559 (message_dolog): Don't assume print length fits in 39 bytes.
1560 (display_mode_element): Don't assume strlen fits in int.
1562 * termcap.c: Don't assume sizes fit in int and never overflow.
1563 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1564 (gobble_line): Check for size-calculation overflow.
1566 * minibuf.c (Fread_buffer):
1567 * lread.c (intern, intern_c_string):
1568 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1569 Don't assume string length fits in int.
1571 * keyboard.c (parse_tool_bar_item):
1572 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1574 * font.c: Don't assume string length fits in int.
1575 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1576 Use ptrdiff_t, not int.
1577 (font_intern_prop): Don't assume string length fits in int.
1578 Don't assume integer property fits in fixnum.
1579 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1581 * filelock.c: Fix some buffer overrun and integer overflow issues.
1582 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1583 Reformulate so as not to need the command string.
1584 Invoke gzip -cd rather than gunzip, as it's more portable.
1585 (lock_info_type, lock_file_1, lock_file):
1586 Don't assume pid_t and time_t fit in unsigned long.
1587 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1588 (current_lock_owner): Prefer signed type for sizes.
1589 Use memcpy, not strncpy, where memcpy is what is really wanted.
1590 Don't assume (via atoi) that time_t and pid_t fit in int.
1591 Check for time_t and/or pid_t out of range, e.g., via a network share.
1592 Don't alloca where an auto var works fine.
1594 * fileio.c: Fix some integer overflow issues.
1595 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1596 Don't assume string length fits in int.
1597 (directory_file_name): Don't assume string length fits in long.
1598 (make_temp_name): Don't assume pid fits in int, or that its print
1599 length is less than 20.
1601 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1603 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1605 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1607 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1608 We prefer signed integers, even for size calculations.
1610 * emacs.c: Don't assume string length fits in 'int'.
1611 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1612 (main): Don't invoke strlen when not needed.
1614 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1615 (XD_DEBUG_MESSAGE): Don't waste a byte.
1617 * callproc.c (getenv_internal_1, getenv_internal)
1619 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1621 * lread.c (invalid_syntax): Omit length argument.
1622 All uses changed. This doesn't fix a bug, but it simplifies the
1623 code away from its former Hollerith-constant appearance, and it's
1624 one less 'int' to worry about when looking at integer-overflow issues.
1625 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1627 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1628 This didn't break anything, but it didn't help either.
1629 It's confusing to put a bogus integer in a place where the actual
1630 value does not matter.
1631 (LIST_END_P): Remove unused macro and its bogus comment.
1632 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1634 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1635 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1637 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1638 We prefer signed types, and the value cannot exceed the EMACS_INT
1639 range anyway (because otherwise the length would not be representable).
1640 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1641 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1642 This avoids a GCC warning when WIDE_EMACS_INT.
1644 * indent.c (sane_tab_width): New function.
1645 (current_column, scan_for_column, Findent_to, position_indentation)
1646 (compute_motion): Use it. This is just for clarity.
1647 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1649 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1651 * lisp.h (lint_assume): New macro.
1652 * composite.c (composition_gstring_put_cache):
1653 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1655 * editfns.c, insdel.c:
1656 Omit unnecessary forward decls, to simplify future changes.
1658 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1660 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1662 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1663 Use much-faster test for byte-length change.
1664 Don't assume string byte-length fits in 'int'.
1665 Check that character arg fits in 'int'.
1666 (mapcar1): Declare byte as byte, for clarity.
1668 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1670 * fns.c (concat): Catch string overflow earlier.
1671 Do not rely on integer wraparound.
1673 * dispextern.h (struct it.overlay_strings_charpos)
1674 (struct it.selective): Now EMACS_INT, not int.
1675 * xdisp.c (forward_to_next_line_start)
1676 (back_to_previous_visible_line_start)
1677 (reseat_at_next_visible_line_start, next_element_from_buffer):
1678 Don't arbitrarily truncate the value of 'selective' to int.
1680 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1682 * composite.c: Don't truncate sizes to 'int'.
1683 (composition_gstring_p, composition_reseat_it)
1684 (composition_adjust_point): Use EMACS_INT, not int.
1685 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1686 not EMACS_UINT, for indexes.
1688 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1690 * buffer.c: Include <verify.h>.
1691 (struct sortvec.priority, struct sortstr.priority):
1692 Now EMACS_INT, not int.
1693 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1694 (struct sortstr.size, record_overlay_string)
1695 (struct sortstrlist.size, struct sortlist.used):
1696 Don't truncate size to int.
1697 (record_overlay_string): Check for size-calculation overflow.
1698 (init_buffer_once): Check at compile-time, not run-time.
1700 2011-06-22 Jim Meyering <meyering@redhat.com>
1702 Don't leak an XBM-image-sized buffer
1703 * image.c (xbm_load): Free the image buffer after using it.
1705 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1708 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1709 that Sun C diagnosed.
1710 * fns.c (secure_hash): Fix pointer signedness issue.
1711 * intervals.c (static_offset_intervals): New function.
1712 (offset_intervals): Use it.
1714 2011-06-21 Leo Liu <sdl.web@gmail.com>
1717 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1720 * fns.c (secure_hash): Rename from crypto_hash_function and change
1721 the first arg to accept symbols.
1722 (Fsecure_hash): New primitive.
1723 (syms_of_fns): New symbols.
1725 2011-06-20 Deniz Dogan <deniz@dogan.se>
1727 * process.c (Fset_process_buffer): Clarify return value in
1730 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1732 * dispnew.c (add_window_display_history): Use BVAR.
1734 * xdisp.c (debug_method_add): Use BVAR.
1735 (check_window_end, dump_glyph_matrix, dump_glyph)
1736 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1738 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1741 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1742 check till after the cache is created in init_frame_faces.
1744 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1746 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1748 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1750 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1751 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1752 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1754 Improve buffer-overflow checking (Bug#8873).
1755 * fileio.c (Finsert_file_contents):
1756 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1757 Remove the old (too-loose) buffer overflow checks.
1758 They weren't needed, since make_gap checks for buffer overflow.
1759 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1760 The old code merely checked for Emacs fixnum overflow, and relied
1761 on undefined (wraparound) behavior. The new code avoids undefined
1762 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1764 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1765 Tune. Don't use wider integers than needed. Don't use alloca.
1766 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1768 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1770 * insdel.c, lisp.h (buffer_overflow): New function.
1771 (insert_from_buffer_1, replace_range, replace_range_2):
1772 * insdel.c (make_gap_larger):
1773 * editfns.c (Finsert_char):
1774 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1776 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1778 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1780 Integer overflow and signedness fixes (Bug#8873).
1782 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1783 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1785 * fileio.c: Don't assume EMACS_INT fits in off_t.
1786 (emacs_lseek): New static function.
1787 (Finsert_file_contents, Fwrite_region): Use it.
1788 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1790 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1792 * fns.c: Don't overflow int when computing a list length.
1793 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1794 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1795 truncation on 64-bit hosts. Check for QUIT every
1796 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1797 faster and is responsive enough.
1798 (Flength): Report an error instead of overflowing an integer.
1799 (Fsafe_length): Return a float if the value is not representable
1800 as a fixnum. This shouldn't happen except in contrived situations.
1801 (Fnthcdr, Fsort): Don't assume list length fits in int.
1802 (Fcopy_sequence): Don't assume vector length fits in int.
1804 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1805 (header_size, word_size): New constants.
1806 (allocate_vectorlike): Don't check size overflow here.
1807 (allocate_vector): Check it here instead, since this is the only
1808 caller of allocate_vectorlike that could cause overflow.
1809 Check that the new vector's length is representable as a fixnum.
1811 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1812 The previous code was bogus. For example, next_almost_prime (32)
1813 returned 39, which is undesirable as it is a multiple of 3; and
1814 next_almost_prime (24) returned 25, which is a multiple of 5 so
1815 why was the code bothering to check for multiples of 7?
1817 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1819 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1821 Variadic C functions now count arguments with ptrdiff_t.
1822 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1823 Back then I didn't know that the Emacs coding style prefers signed int.
1824 Also, in the meantime I found a few more instances where arguments
1825 were being counted with int, which may truncate counts on 64-bit
1826 machines, or EMACS_INT, which may be unnecessarily wide.
1827 * lisp.h (struct Lisp_Subr.function.aMANY)
1828 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1829 Arg counts are now ptrdiff_t, not size_t.
1830 All variadic functions and their callers changed accordingly.
1831 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1832 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1833 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1834 * callint.c (Fcall_interactively): Check arg count for overflow,
1835 to avoid potential buffer overrun. Use signed char, not 'int',
1836 for 'varies' array, so that we needn't bother to check its size
1837 calculation for overflow.
1838 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1839 * eval.c (apply_lambda):
1840 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1841 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1842 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1844 * callint.c (Fcall_interactively): Don't use index var as event count.
1846 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1847 * mem-limits.h (SIZE): Remove; no longer used.
1849 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1851 Remove unnecessary casts.
1852 * xterm.c (x_term_init):
1853 * xfns.c (x_set_border_pixel):
1854 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1855 These aren't needed now that we assume ANSI C.
1857 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1858 It's more likely to cause problems (due to unsigned overflow)
1861 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1863 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1865 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1867 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1869 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1871 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1873 GLYPH_CODE_FACE returns EMACS_INT, not int.
1874 * dispextern.h (merge_faces):
1875 * xfaces.c (merge_faces):
1876 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1877 Don't assume EMACS_INT fits in int.
1879 * character.h (CHAR_VALID_P): Remove unused parameter.
1880 * fontset.c, lisp.h, xdisp.c: All uses changed.
1882 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1884 * fns.c (concat): Minor tuning based on overflow analysis.
1885 This doesn't fix any bugs. Use int to hold character, instead
1886 of constantly refetching from Emacs object. Use XFASTINT, not
1887 XINT, for value known to be a character. Don't bother comparing
1888 a single byte to 0400, as it's always less.
1890 * floatfns.c (Fexpt):
1891 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1893 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1896 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1898 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1899 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1900 incorrectly succeed when S was a string, because 4294967386 was
1901 truncated before it was used.
1903 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1904 Otherwise, an out-of-range integer could cause undefined behavior
1907 * composite.c: Use int, not EMACS_INT, for characters.
1908 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1909 EMACS_INT, for values that are known to be in character range.
1910 This doesn't fix any bugs but is the usual style inside Emacs and
1911 may generate better code on 32-bit machines.
1913 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1914 This is for reasons similar to the recent CHAR_STRING fix.
1915 * charset.c (Fencode_char): Check that character arg is actually
1916 a character. Pass an int to ENCODE_CHAR.
1917 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1918 wider than 'int', as a compile-time check to prevent future regressions
1921 * character.c (char_string): Remove unnecessary casts.
1923 Make sure a 64-bit char is never passed to CHAR_STRING.
1924 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1925 by silently ignoring the top 32 bits, allowing some values
1926 that were far too large to be valid characters.
1927 * character.h: Include <verify.h>.
1928 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1929 arguments are no wider than unsigned, as a compile-time check
1930 to prevent future regressions in this area.
1932 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1933 (Fsubst_char_in_region):
1935 * xdisp.c (decode_mode_spec_coding):
1936 Adjust to CHAR_STRING's new requirement.
1937 * editfns.c (Finsert_char, Fsubst_char_in_region):
1938 * fns.c (concat): Check that character args are actually
1939 characters. Without this test, these functions did the wrong
1940 thing with wildly out-of-range values on 64-bit hosts.
1942 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1943 These casts should not be needed on 32-bit hosts, either.
1944 * keyboard.c (read_char):
1945 * lread.c (Fload): Remove casts to unsigned.
1947 * lisp.h (UNSIGNED_CMP): New macro.
1948 This fixes comparison bugs on 64-bit hosts.
1949 (ASCII_CHAR_P): Use it.
1950 * casefiddle.c (casify_object):
1951 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1952 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1953 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1954 * dispextern.h (FACE_FROM_ID):
1955 * keyboard.c (read_char): Use UNSIGNED_CMP.
1957 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1958 not to EMACS_INT, to avoid GCC warning.
1960 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1962 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1963 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1964 isn't needed on 32-bit machines.
1966 * buffer.c (Fgenerate_new_buffer_name):
1967 Use EMACS_INT for count, not int.
1968 (advance_to_char_boundary): Return EMACS_INT, not int.
1970 * data.c (Qcompiled_function): Now static.
1972 * window.c (window_body_lines): Now static.
1974 * image.c (gif_load): Rename local to avoid shadowing.
1976 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1977 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1978 * alloc.c (make_save_value): Integer argument is now of type
1980 (mark_object): Use ptrdiff_t, not int.
1981 * lisp.h (pD): New macro.
1982 * print.c (print_object): Use it.
1984 * alloc.c: Use EMACS_INT, not int, to count objects.
1985 (total_conses, total_markers, total_symbols, total_vector_size)
1986 (total_free_conses, total_free_markers, total_free_symbols)
1987 (total_free_floats, total_floats, total_free_intervals)
1988 (total_intervals, total_strings, total_free_strings):
1989 Now EMACS_INT, not int. All uses changed.
1990 (Fgarbage_collect): Compute overall total using a double, so that
1991 integer overflow is less likely to be a problem. Check for overflow
1992 when converting back to an integer.
1993 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1994 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1995 These were 'int' variables that could overflow on 64-bit hosts;
1996 they were never used, so remove them instead of repairing them.
1997 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1998 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1999 Previously, this ceilinged at INT_MAX, but that doesn't work on
2001 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2003 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2004 (allocate_vectorlike): Check for ptrdiff_t overflow.
2005 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2006 when a (possibly-narrower) signed value would do just as well.
2007 We prefer using signed arithmetic, to avoid comparison confusion.
2009 * alloc.c: Catch some string size overflows that we were missing.
2010 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2011 for convenience in STRING_BYTES_MAX.
2012 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2013 The definition here is exact; the one in lisp.h was approximate.
2014 (allocate_string_data): Check for string overflow. This catches
2015 some instances we weren't catching before. Also, it catches
2016 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2017 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2018 and ptrdiff_t and EMACS_INT are both 64 bits.
2020 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2021 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2022 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2024 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2026 * alloc.c (Fmake_string): Check for out-of-range init.
2028 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2030 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2032 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2034 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2035 xg_get_default_scrollbar_width.
2037 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2038 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2039 (style_changed_cb): Call update_theme_scrollbar_width and call
2040 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2041 all frames (Bug#8505).
2042 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2043 Call gtk_window_set_resizable if HAVE_GTK3.
2044 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2045 and height if HAVE_GTK3 (Bug#8505).
2046 (scroll_bar_width_for_theme): New variable.
2047 (update_theme_scrollbar_width): New function.
2048 (xg_get_default_scrollbar_width): Move code to
2049 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2050 (xg_initialize): Call update_theme_scrollbar_width.
2052 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2054 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2056 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2058 * frame.c (make_frame): Call other_buffer_safely instead of
2061 * window.c (temp_output_buffer_show): Call display_buffer with
2062 second argument Vtemp_buffer_show_specifiers and reset latter
2063 immediately after the call.
2064 (Vtemp_buffer_show_specifiers): New variable.
2065 (auto_window_vscroll_p, next_screen_context_lines)
2066 (Vscroll_preserve_screen_position): Remove leading asterisks from
2069 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2071 Fix minor problems found by GCC 4.6.0 static checking.
2072 * buffer.c (Qclone_number): Remove for now, as it's unused.
2073 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2074 (record_buffer): Remove unused local.
2075 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2076 (set_frame_buffer_list): Remove; unused.
2077 * frame.h (other_visible_frames): Remove decl.
2078 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2079 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2080 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2082 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2083 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2084 Define only if HAVE_GPM.
2085 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2086 (update_hints_inhibit): Remove; never set. All uses removed.
2087 * widgetprv.h (emacsFrameClassRec): Remove decl.
2088 * window.c (delete_deletable_window): Now returns void, since it
2089 wasn't returning anything.
2090 (compare_window_configurations): Remove unused locals.
2091 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2092 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2093 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2094 the same widths as pointers. This follows up on the 2011-05-06 patch.
2095 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2096 * xterm.h: Likewise.
2097 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2099 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2101 * makefile.w32-in: Update dependencies.
2102 (LISP_H): Add lib/intprops.h.
2104 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2106 * image.c (gif_load): Add animation frame delay to the metadata.
2107 (syms_of_image): Use DEFSYM. New symbol `delay'.
2109 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2111 * window.c (delete_deletable_window): Re-add.
2112 (Fset_window_configuration): Rewrite to handle dead buffers and
2113 consequently deletable windows.
2114 (window_tree, Fwindow_tree): Remove. Supply functionality in
2116 (compare_window_configurations): Simplify code.
2118 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2120 * image.c (imagemagick_load_image): Fix type mismatch.
2121 (Fimagemagick_types): Likewise.
2123 * window.h (replace_buffer_in_windows): Declare.
2125 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2127 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2128 Qclone_number. Remove external declaration of Qdelete_window.
2129 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2131 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2132 Qbuffer_list_update_hook if allowed.
2133 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2134 buffer list implementation.
2135 (other_buffer_safely): New function.
2136 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2137 calls to replace_buffer_in_windows and
2138 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2140 (record_buffer): Inhibit quitting and rewrite using quittable
2141 functions. Run Qbuffer_list_update_hook if allowed.
2142 (Frecord_buffer, Funrecord_buffer): New functions.
2143 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2144 switch-to-buffer to window.el.
2145 (bury-buffer): Move to window.el.
2146 (Vbuffer_list_update_hook): New variable.
2148 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2151 * window.h (resize_frame_windows): Move up in code.
2152 (Fwindow_frame): Remove EXFUN.
2153 (replace_buffer_in_all_windows): Remove prototype.
2154 (replace_buffer_in_windows_safely): Add prototype.
2156 * window.c: Declare Qdelete_window static again. Move down
2157 declaration of select_count.
2158 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2159 (Fother_window): Move to window.el.
2160 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2161 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2162 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2164 (replace_buffer_in_windows): Implement by calling
2165 Qreplace_buffer_in_windows.
2166 (replace_buffer_in_all_windows): Remove with some functionality
2167 moved into replace_buffer_in_windows_safely.
2168 (replace_buffer_in_windows_safely): New function.
2169 (select_window_norecord, select_frame_norecord): Move in front
2170 of run_window_configuration_change_hook. Remove now obsolete
2172 (Fset_window_buffer): Rewrite doc-string. Call
2173 Qrecord_window_buffer.
2174 (keys_of_window): Move binding for other-window to window.el.
2176 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2178 * dispextern.h (struct image): Replace data member, whose int_val
2179 and ptr_val fields were not used by anything, with a single
2182 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2183 (gif_clear_image, gif_load, imagemagick_load_image)
2184 (gs_clear_image, gs_load): Callers changed.
2186 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2188 * buffer.h: Include <time.h>, for time_t.
2189 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2191 Fix minor problems found by static checking.
2193 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2195 Make identifiers static if they are not used in other modules.
2196 * data.c (Qcompiled_function, Qframe, Qvector):
2197 * image.c (QimageMagick, Qsvg):
2198 * minibuf.c (Qmetadata):
2199 * window.c (resize_window_check, resize_root_window): Now static.
2200 * window.h (resize_window_check, resize_root_window): Remove decls.
2202 * window.c (window_deletion_count, delete_deletable_window):
2204 (window_body_lines): Now static.
2205 (Fdelete_other_windows_internal): Mark vars as initialized.
2206 Make sure 'resize_failed' is initialized.
2207 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2208 (resize_window_apply): Remove unused local.
2209 * window.h (delete_deletable_window): Remove decl.
2211 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2212 (imagemagick_load_image): Fix pointer signedness problem by changing
2213 last arg from unsigned char * to char *. All uses changed.
2214 Also, fix a local for similar reasons.
2215 Remove unused locals. Remove locals to avoid shadowing.
2216 (fn_rsvg_handle_free): Remove; unused.
2217 (svg_load, svg_load_image): Fix pointer signedness problem.
2218 (imagemagick_load_image): Don't use garbage pointer image_wand.
2220 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2222 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2224 * image.c (gif_load): Fix omitted cast error introduced by
2227 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2229 * window.h (resize_proportionally, orig_total_lines)
2230 (orig_top_line): Remove from window structure.
2231 (set_window_height, set_window_width, change_window_heights)
2232 (Fdelete_window): Remove prototypes.
2233 (resize_frame_windows): Remove duplicate declaration.
2235 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2237 * window.h (resize_frame_windows, resize_window_check)
2238 (delete_deletable_window, resize_root_window)
2239 (resize_frame_windows): Declare prototypes.
2241 * window.c (resize_window_apply): Make definition be "static" to
2242 match the prototype.
2244 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2246 * window.c: Remove declarations of Qwindow_size_fixed,
2247 window_min_size_1, window_min_size_2, window_min_size,
2248 size_window, window_fixed_size_p, enlarge_window, delete_window.
2249 Remove static from declaration of Qdelete_window, it's
2250 temporarily needed by Fbury_buffer.
2251 (replace_window): Don't assign orig_top_line and
2253 (Fdelete_window, delete_window): Remove. Window deletion is
2254 handled by window.el.
2255 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2256 Fdelete_window calls with calls to Qdelete_window.
2257 (Fdelete_other_windows): Remove. Deleting other windows is
2258 handled by window.el.
2259 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2260 handled in window.el.
2261 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2262 Window minimum sizes are handled in window.el.
2263 (shrink_windows, size_window, set_window_height)
2264 (set_window_width, change_window_heights, window_height)
2265 (window_width, CURBEG, CURSIZE, enlarge_window)
2266 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2267 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2268 handled in window.el.
2269 (make_dummy_parent): Rename to make_parent_window and give it a
2270 second argument horflag.
2271 (make_window): Don't set resize_proportionally any more.
2272 (Fsplit_window): Remove. Windows are split in window.el.
2273 (save_restore_action, save_restore_orig_size)
2274 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2275 Resize mini windows in window.el.
2276 (grow_mini_window, shrink_mini_window): Implement by calling
2277 Qresize_root_window_vertically, resize_window_check and
2278 resize_window_apply.
2279 (saved_window, Fset_window_configuration, save_window_save): Do
2280 not handle orig_top_line, orig_total_lines, and
2281 resize_proportionally.
2282 (window_min_height, window_min_width): Move to window.el.
2283 (keys_of_window): Move bindings for delete-other-windows,
2284 split-window, delete-window and enlarge-window to window.el.
2286 * buffer.c: Temporarily extern Qdelete_window.
2287 (Fbury_buffer): Temporarily call Qdelete_window instead of
2288 Fdelete_window (Fbury_buffer will move to window.el soon).
2290 * frame.c (set_menu_bar_lines_1): Remove code handling
2291 orig_top_line and orig_total_lines.
2293 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2294 set_window_height but set heights directly.
2295 (change_frame_size_1): Use resize_frame_windows.
2297 * xdisp.c (init_xdisp): Don't use set_window_height but set
2300 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2301 resize_frame_windows instead of change_window_heights and run
2302 run_window_configuration_change_hook.
2304 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2305 instead of change_window_heights and run
2306 run_window_configuration_change_hook.
2308 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2310 * window.c (replace_window): Rename second argument REPLACEMENT to
2311 NEW. New third argument SETFLAG. Rewrite.
2312 (delete_window, make_dummy_parent): Call replace_window with
2314 (window_list_1): Move down in code.
2315 (run_window_configuration_change_hook): Move set_buffer part
2316 before select_frame_norecord part in order to unwind correctly.
2317 Rename count1 to count.
2318 (recombine_windows, delete_deletable_window, resize_root_window)
2319 (Fdelete_other_windows_internal)
2320 (Frun_window_configuration_change_hook, make_parent_window)
2321 (resize_window_check, resize_window_apply, Fresize_window_apply)
2322 (resize_frame_windows, Fsplit_window_internal)
2323 (Fdelete_window_internal, Fresize_mini_window_internal): New
2325 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2327 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2329 * window.h (window): Add some new members to window structure -
2330 normal_lines, normal_cols, new_total, new_normal, clone_number,
2331 splits, nest, prev_buffers, next_buffers.
2332 (WINDOW_TOTAL_SIZE): Move here from window.c.
2333 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2335 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2337 (make_dummy_parent): Set new members of windows structure.
2338 (make_window): Move down in code. Handle new members of window
2340 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2341 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2342 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2343 (Fset_window_prev_buffers, Fwindow_next_buffers)
2344 (Fset_window_next_buffers, Fset_window_clone_number): New
2346 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2347 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2349 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2350 Argument WINDOW can be now internal window too.
2351 (Fwindow_use_time): Move up in code.
2352 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2354 (Fset_window_configuration, saved_window)
2355 (Fcurrent_window_configuration, save_window_save): Handle new
2356 members of window structure.
2357 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2358 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2359 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2360 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2361 Qget_mru_window, Qresize_root_window,
2362 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2363 Qauto_buffer_name; staticpro them.
2365 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2367 * window.c (Fwindow_total_size, Fwindow_left_column)
2368 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2369 (Fwindow_list_1): New functions.
2370 (window_box_text_cols): Replace with window_body_cols.
2371 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2372 window_body_cols instead of window_box_text_cols.
2373 (delete_window, Fset_window_configuration): Call
2374 delete_all_subwindows with window as argument.
2375 (delete_all_subwindows): Take a window as argument and not a
2377 (window_loop): Remove handling of GET_LRU_WINDOW and
2379 (Fget_lru_window, Fget_largest_window): Move to window.el.
2381 * window.h: Extern window_body_cols instead of
2382 window_box_text_cols. delete_all_subwindows now takes a
2383 Lisp_Object as argument.
2385 * indent.c (compute_motion, Fcompute_motion): Use
2386 window_body_cols instead of window_box_text_cols.
2388 * frame.c (delete_frame): Call delete_all_subwindows with root
2391 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2393 * fns.c (Fputhash): Document return value.
2395 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2397 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2399 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2401 Cons<->int and similar integer overflow fixes (Bug#8794).
2403 Check for overflow when converting integer to cons and back.
2404 * charset.c (Fdefine_charset_internal, Fdecode_char):
2405 Use cons_to_unsigned to catch overflow.
2406 (Fencode_char): Use INTEGER_TO_CONS.
2407 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2408 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2409 * data.c (long_to_cons, cons_to_long): Remove.
2410 (cons_to_unsigned, cons_to_signed): New functions.
2411 These signal an error for invalid or out-of-range values.
2412 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2413 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2414 * font.c (Ffont_variation_glyphs):
2415 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2416 * lisp.h: Include <intprops.h>.
2417 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2418 (cons_to_signed, cons_to_unsigned): New decls.
2419 (long_to_cons, cons_to_long): Remove decls.
2420 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2421 (Fprimitive_undo): Use CONS_TO_INTEGER.
2422 * xfns.c (Fx_window_property): Likewise.
2423 * xselect.c: Include <limits.h>.
2424 (x_own_selection, selection_data_to_lisp_data):
2425 Use INTEGER_TO_CONS.
2426 (x_handle_selection_request, x_handle_selection_clear)
2427 (x_get_foreign_selection, Fx_disown_selection_internal)
2428 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2429 (lisp_data_to_selection_data): Use cons_to_unsigned.
2430 (x_fill_property_data): Use cons_to_signed.
2431 Report values out of range.
2433 Check for buffer and string overflow more precisely.
2434 * buffer.h (BUF_BYTES_MAX): New macro.
2435 * lisp.h (STRING_BYTES_MAX): New macro.
2436 * alloc.c (Fmake_string):
2437 * character.c (string_escape_byte8):
2438 * coding.c (coding_alloc_by_realloc):
2439 * doprnt.c (doprnt):
2440 * editfns.c (Fformat):
2442 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2443 since they may not be the same number.
2444 * editfns.c (Finsert_char):
2445 * fileio.c (Finsert_file_contents):
2446 Likewise for BUF_BYTES_MAX.
2448 * image.c: Use ptrdiff_t, not int, for sizes.
2449 (slurp_file): Switch from int to ptrdiff_t.
2451 (slurp_file): Check that file size fits in both size_t (for
2452 malloc) and ptrdiff_t (for sanity and safety).
2454 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2455 if b->modtime has its maximal value.
2457 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2459 Don't assume time_t can fit into int.
2460 * buffer.h (struct buffer.modtime): Now time_t, not int.
2461 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2462 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2464 Minor fixes for signed vs unsigned integers.
2465 * character.h (MAYBE_UNIFY_CHAR):
2466 * charset.c (maybe_unify_char):
2467 * keyboard.c (read_char, reorder_modifiers):
2468 XINT -> XFASTINT, since the integer must be nonnegative.
2469 * ftfont.c (ftfont_spec_pattern):
2470 * keymap.c (access_keymap, silly_event_symbol_error):
2471 XUINT -> XFASTINT, since the integer must be nonnegative.
2472 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2473 since it makes no difference and we prefer signed.
2474 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2475 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2478 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2480 * window.h (Fwindow_frame): Declare.
2482 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2484 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2485 (SPARE_MEMORY): Always define.
2486 (LARGE_REQUEST): Remove.
2487 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2489 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2491 * lisp.h: Move EXFUNS for Fframe_root_window,
2492 Fframe_first_window and Fset_frame_selected_window to window.h.
2494 * window.h: Move EXFUNS for Fframe_root_window,
2495 Fframe_first_window and Fset_frame_selected_window here from
2498 * frame.c (Fwindow_frame, Fframe_first_window)
2499 (Fframe_root_window, Fframe_selected_window)
2500 (Fset_frame_selected_window): Move to window.c.
2501 (Factive_minibuffer_window): Move to minibuf.c.
2502 (Fother_visible_frames_p): New function.
2504 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2506 * window.c (decode_window, decode_any_window): Move up in code.
2507 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2508 (inhibit_frame_unsplittable): Remove unused variable.
2509 (Fwindow_buffer): Move up and rewrite doc-string.
2510 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2511 (Fwindow_prev): New functions.
2512 (Fwindow_frame): Move here from frame.c. Accept any window as
2514 (Fframe_root_window, Fframe_first_window)
2515 (Fframe_selected_window): Move here from frame.c. Accept frame
2516 or arbitrary window as argument. Update doc-strings.
2517 (Fminibuffer_window): Move up in code.
2518 (Fwindow_minibuffer_p): Move up in code and simplify.
2519 (Fset_frame_selected_window): Move here from frame.c.
2521 (Fselected_window, select_window, Fselect_window): Move up in
2522 code. Minor doc-string fixes.
2524 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2526 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2527 Do not assume that spare memory exists; that assumption is valid
2528 only if SYSTEM_MALLOC.
2529 (LARGE_REQUEST): New macro, so that the issue of large requests
2530 is separated from the issue of spare memory.
2532 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2534 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2537 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2539 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2542 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2544 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2546 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2548 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2549 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2551 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2553 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2555 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2557 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2558 (x_clipboard_manager_save): Add return value.
2559 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2561 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2562 Obey Vx_select_enable_clipboard_manager. Catch errors in
2563 x_clipboard_manager_save (Bug#8779).
2564 (Vx_select_enable_clipboard_manager): New variable.
2565 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2567 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2569 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2571 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2573 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2574 in the current matrix if keep_current_p is non-zero.
2576 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2578 * bidi.c (bidi_level_of_next_char): Fix last change.
2580 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2582 Support bidi reordering of text covered by display properties.
2584 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2585 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2586 (bidi_cache_search, bidi_cache_iterator_state)
2587 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2588 (bidi_level_of_next_char, bidi_move_to_visually_next):
2589 Support character positions inside a run of characters covered by a
2591 (bidi_paragraph_init, bidi_resolve_explicit_1)
2592 (bidi_level_of_next_char): Call bidi_fetch_char and
2593 bidi_fetch_char_advance instead of FETCH_CHAR and
2595 (bidi_init_it): Initialize new members.
2596 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2598 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2599 instead of using explicit *_CHAR codes.
2600 (bidi_resolve_explicit, bidi_resolve_weak):
2601 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2602 bidirectional text is supported only in multibyte buffers.
2603 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2604 it to initialize the frame_window_p member of struct bidi_it.
2605 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2606 (bidi_resolve_explicit, bidi_resolve_weak)
2607 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2608 bidi_it->nchars is non-positive.
2609 (bidi_level_of_next_char): Don't try to lookup the cache for the
2610 next/previous character if nothing is cached there yet, or if we
2611 were just reseat()'ed to a new position.
2613 * xdisp.c (set_cursor_from_row): Set start and stop points
2614 according to the row's direction when priming the loop that looks
2615 for the glyph on which to display cursor.
2616 (single_display_spec_intangible_p): Function deleted.
2617 (display_prop_intangible_p): Reimplement to call
2618 handle_display_spec instead of single_display_spec_intangible_p.
2619 Accept 3 additional arguments needed by handle_display_spec.
2620 This fixes incorrect cursor motion across display property with complex
2621 values: lists, `(when COND...)' forms, etc.
2622 (single_display_spec_string_p): Support property values that are
2623 lists with the argument STRING its top-level element.
2624 (display_prop_string_p): Fix the condition for processing a
2625 property that is a list to be consistent with handle_display_spec.
2626 (handle_display_spec): New function, refactored from the
2627 last portion of handle_display_prop.
2628 (compute_display_string_pos): Accept additional argument
2629 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2630 value of a `display' property is a "replacing spec".
2631 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2632 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2633 the display property, but just return a value indicating whether
2634 the display property will replace the characters it covers.
2635 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2636 frame_window_p members of struct bidi_it.
2637 (compute_display_string_pos, compute_display_string_end):
2639 (push_it): Accept second argument POSITION, where pop_it should
2640 jump to continue iteration.
2641 (reseat_1): Initialize bidi_it.disp_pos.
2643 * keyboard.c (adjust_point_for_property): Adjust the call to
2644 display_prop_intangible_p to its new signature.
2646 * dispextern.h (struct bidi_it): New member frame_window_p.
2647 (bidi_init_it): Update prototypes.
2648 (display_prop_intangible_p): Update prototype.
2649 (compute_display_string_pos, compute_display_string_end):
2651 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2654 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2656 Malloc failure behavior now depends on size of allocation.
2657 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2658 * lisp.h: Change signatures accordingly.
2659 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2660 All callers changed. (Bug#8762)
2662 * gnutls.c: Use Emacs's memory allocators.
2663 Without this change, the gnutls library would invoke malloc etc.
2664 directly, which causes problems on non-SYNC_INPUT hosts, and which
2665 runs afoul of improving memory_full behavior. (Bug#8761)
2666 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2667 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2668 xfree instead of the default malloc, realloc, free.
2669 (Fgnutls_boot): No need to check for memory allocation failure,
2670 since xmalloc does that for us.
2672 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2673 * category.c (hash_get_category_set):
2674 * ccl.c (ccl_driver):
2675 * charset.c (Fdefine_charset_internal):
2676 * charset.h (struct charset.hash_index):
2677 * composite.c (get_composition_id, gstring_lookup_cache)
2678 (composition_gstring_put_cache):
2679 * composite.h (struct composition.hash_index):
2680 * dispextern.h (struct image.hash):
2681 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2682 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2683 (hashfn_equal, hashfn_user_defined, make_hash_table)
2684 (maybe_resize_hash_table, hash_lookup, hash_put)
2685 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2686 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2687 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2688 * image.c (make_image, search_image_cache, lookup_image)
2689 (xpm_put_color_table_h):
2690 * lisp.h (struct Lisp_Hash_Table):
2691 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2692 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2693 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2694 * alloc.c (allocate_vectorlike):
2695 Check for overflow in vector size calculations.
2696 * ccl.c (ccl_driver):
2697 Check for overflow when converting EMACS_INT to int.
2698 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2699 need to be updated by these changes.
2700 * fns.c (make_hash_table, maybe_resize_hash_table):
2701 Check for integer overflow with large hash tables.
2702 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2703 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2704 (SXHASH_REDUCE): New macro.
2705 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2706 Use it instead of discarding useful hash info with large hash values.
2707 (sxhash_float): New function.
2708 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2709 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2710 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2711 Rewrite to use FIXNUM_BITS, as this simplifies things.
2712 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2713 Adjust signatures to match updated version of code.
2714 (consing_since_gc): Now EMACS_INT, since a single hash table can
2715 use more than INT_MAX bytes.
2717 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2719 Make it possible to build with GCC-4.6+ -O2 -flto.
2721 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2723 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2725 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2726 Call minibuffer-inactive-mode.
2728 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2730 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2731 Update dependencies.
2733 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2735 * data.c (init_data): Remove code for UTS, this system is not
2738 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2740 Don't force ./temacs to start in terminal mode.
2742 * frame.c (make_initial_frame): Initialize faces in all cases, not
2743 only when CANNOT_DUMP is defined.
2744 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2746 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2748 * dispnew.c (add_window_display_history): Use const for the string
2749 pointer. Remove declaration, not needed.
2751 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2753 Use 'inline', not 'INLINE'.
2754 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2755 * alloc.c, fontset.c (INLINE): Remove.
2756 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2757 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2758 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2759 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2760 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2762 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2764 Make it possible to run ./temacs.
2766 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2767 syms_of_callproc does the same thing. Remove test for
2768 "initialized", do it in the caller.
2769 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2771 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2773 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2774 (read_minibuf): Use get_minibuffer.
2775 (syms_of_minibuf): Use DEFSYM.
2776 (Qmetadata): New var.
2777 * data.c (Qbuffer): Don't make it static.
2778 (syms_of_data): Use DEFSYM.
2780 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2782 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2783 (CCL_CODE_MIN): New macro.
2785 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2787 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2789 * eval.c (Qdebug): Now static.
2790 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2791 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2792 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2794 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2796 * image.c: Various fixes to ImageMagick code comments.
2797 (Fimagemagick_types): Doc fix.
2799 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2801 Minor fixes prompted by GCC 4.6.0 warnings.
2803 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2805 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2806 (x_clipboard_manager_save_all): Move extern decl to ...
2807 * xterm.h: ... here, so that it can be checked for consistency.
2809 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2811 * xselect.c (x_clipboard_manager_save_frame)
2812 (x_clipboard_manager_save_all): New functions.
2813 (Fx_clipboard_manager_save): Lisp function deleted.
2815 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2816 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2818 * xterm.h: Update prototype.
2820 2011-05-28 William Xu <william.xwl@gmail.com>
2822 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2825 2011-05-28 Jim Meyering <meyering@redhat.com>
2827 Avoid a sign-extension bug in crypto_hash_function.
2828 * fns.c (to_uchar): Define.
2829 (crypto_hash_function): Use it to convert some newly-signed
2830 variables to unsigned, to avoid sign-extension bugs. For example,
2831 without this change, (md5 "truc") would evaluate to
2832 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2833 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2834 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2836 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2838 Integer overflow fixes.
2840 * dbusbind.c: Serial number integer overflow fixes.
2841 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2842 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2843 to hold a serial number that is too large for a fixnum.
2844 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2845 Check for serial numbers out of range. Decode any serial number
2846 that was so large that it became a float. (Bug#8722)
2848 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2849 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2850 Use XFASTINT rather than XUINT when numbers are nonnegative.
2851 (xd_append_arg, Fdbus_method_return_internal):
2852 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2853 arguments, check that Lisp number is nonnegative, rather than
2854 silently wrapping negative numbers around. (Bug#8722)
2855 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2858 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2860 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2862 ccl: add integer overflow checks
2863 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2864 (IN_INT_RANGE): New macros.
2865 (ccl_driver): Use them to check for integer overflow when
2866 decoding a CCL program. Many of the new checks are whether XINT (x)
2867 fits in int; it doesn't always, on 64-bit hosts. The new version
2868 doesn't catch all possible integer overflows, but it's an
2869 improvement. (Bug#8719)
2871 * alloc.c (make_event_array): Use XINT, not XUINT.
2872 There's no need for unsigned here.
2874 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2875 This follows up to the 2011-05-06 change that substituted uintptr_t
2876 for EMACS_INT. This case wasn't caught back then.
2878 Rework Fformat to avoid integer overflow issues.
2879 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2880 now (part of C89). Include <verify.h>.
2881 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2882 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2883 (Fformat): Avoid the prepass trying to compute sizes; it was only
2884 approximate and thus did not catch overflow reliably. Instead, walk
2885 through the format just once, formatting and computing sizes as we go,
2886 checking for integer overflow at every step, and allocating a larger
2887 buffer as needed. Keep track separately whether the format is
2888 multibyte. Keep only the most-recently calculated precision, rather
2889 than them all. Record whether each argument has been converted to
2890 string. Use EMACS_INT, not int, for byte and char and arg counts.
2891 Support field widths and precisions larger than INT_MAX. Avoid
2892 sprintf's undefined behavior with conversion specifications such as %#d
2893 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2894 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2895 formatting out-of-range floating point numbers with int
2898 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2900 * data.c: Avoid integer truncation in expressions involving floats.
2901 * data.c: Include <intprops.h>.
2902 (arith_driver): When there's an integer overflow in an expression
2903 involving floating point, convert the integers to floating point
2904 so that the resulting value does not suffer from catastrophic
2905 integer truncation. For example, on a 64-bit host (* 4
2906 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2907 Do not rely on undefined behavior after integer overflow.
2909 merge count_size_as_multibyte, parse_str_to_multibyte
2910 * character.c, character.h (count_size_as_multibyte):
2911 Rename from parse_str_to_multibyte; all uses changed.
2912 Check for integer overflow.
2913 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2914 since it's now a duplicate of the other. This is more of
2915 a character than a buffer op, so better that it's in character.c.
2916 * fns.c, print.c: Adjust to above changes.
2918 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2920 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2922 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2924 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2925 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2926 (x_clipboard_manager_save): Now static.
2927 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2929 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2930 (crypto_hash_function): Now static.
2931 Fix pointer signedness problems. Avoid unnecessary initializations.
2933 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2935 * termhooks.h (Vselection_alist): Make it terminal-local.
2937 * terminal.c (create_terminal): Initialize it.
2939 * xselect.c: Support for clipboard managers.
2940 (Vselection_alist): Move to termhooks.h as terminal-local var.
2941 (LOCAL_SELECTION): New macro.
2942 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2943 (symbol_to_x_atom): Remove gratuitous arg.
2944 (x_handle_selection_request, lisp_data_to_selection_data)
2945 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2946 (x_own_selection, x_get_local_selection, x_convert_selection):
2947 New arg, specifying work frame. Use terminal-local Vselection_alist.
2948 (some_frame_on_display): Delete unused function.
2949 (Fx_own_selection_internal, Fx_get_selection_internal)
2950 (Fx_disown_selection_internal, Fx_selection_owner_p)
2951 (Fx_selection_exists_p): New optional frame arg.
2952 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2953 (x_handle_selection_clear): Don't treat other terminals with the
2954 same keyboard specially. Use the terminal-local Vselection_alist.
2955 (x_clear_frame_selections): Use Frun_hook_with_args.
2957 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2959 * xterm.h: Add support for those atoms.
2961 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2963 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2964 (converted_selections, conversion_fail_tag): New global variables.
2965 (x_selection_request_lisp_error): Free the above.
2966 (x_get_local_selection): Remove unnecessary code.
2967 (x_reply_selection_request): Args changed; handle arbitrary array
2968 of converted selections stored in converted_selections.
2969 Separate the XChangeProperty and SelectionNotify steps.
2970 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2971 (x_convert_selection): New function.
2972 (x_handle_selection_event): Simplify.
2973 (x_get_foreign_selection): Don't ignore incoming requests while
2974 waiting for an answer; this will fail when we implement
2975 SAVE_TARGETS, and seems unnecessary anyway.
2976 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2977 (Vx_sent_selection_functions): Doc fix.
2979 2011-05-26 Leo Liu <sdl.web@gmail.com>
2981 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2983 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2985 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2987 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2988 for fringe update if it has periodic bitmap.
2989 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2990 and fringe_bitmap_periodic_p.
2992 * fringe.c (get_fringe_bitmap_data): New function.
2993 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2994 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2995 row. Mark glyph row for fringe update if periodicity changed.
2997 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2998 for fringe update unless it has periodic bitmap.
3000 2011-05-25 Kenichi Handa <handa@m17n.org>
3002 * xdisp.c (get_next_display_element): Set correct it->face_id for
3003 a static composition.
3005 2011-05-24 Leo Liu <sdl.web@gmail.com>
3008 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3010 * fns.c (crypto_hash_function, Fsha1): New function.
3011 (Fmd5): Use crypto_hash_function.
3012 (syms_of_fns): Add Ssha1.
3014 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3016 * gnutls.c: Remove unused macros.
3017 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3018 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3019 Remove macros that are defined and never used.
3020 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3022 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3024 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3025 (Fx_get_selection_internal): Minor cleanup.
3026 (Fx_own_selection_internal): Rename arguments for consistency with
3029 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3031 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3033 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3035 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3037 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3039 * dispnew.c (scrolling_window): Don't exclude the case that the
3040 last enabled row in the desired matrix touches the bottom boundary.
3042 2011-05-21 Glenn Morris <rgm@gnu.org>
3044 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3045 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3046 and add some more files.
3048 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3050 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3051 report_file_error introduced by the change from 2011-05-07.
3053 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3055 * systime.h (Time): Define only if emacs is defined.
3056 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3057 where the include path doesn't have X11/X.h by default. See
3058 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3060 2011-05-20 Kenichi Handa <handa@m17n.org>
3062 * composite.c (find_automatic_composition): Fix previous change.
3064 2011-05-20 Glenn Morris <rgm@gnu.org>
3066 * lisp.mk: New file, split from Makefile.in.
3067 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3068 (shortlisp): Remove.
3069 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3071 2011-05-19 Glenn Morris <rgm@gnu.org>
3073 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3074 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3075 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3076 (lisp): Set the order to that of loadup.el.
3077 (shortlisp): Make it a copy of $lisp.
3078 (SOME_MACHINE_LISP): Remove.
3079 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3080 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3082 2011-05-18 Kenichi Handa <handa@m17n.org>
3084 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3085 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3086 (find_automatic_composition): Mostly rewrite for efficiency.
3088 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3090 * makefile.w32-in: Update dependencies.
3092 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3094 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3095 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3097 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3099 Fix some integer overflow issues, such as string length overflow.
3101 * insdel.c (count_size_as_multibyte): Check for string overflow.
3103 * character.c (lisp_string_width): Check for string overflow.
3104 Use EMACS_INT, not int, for string indexes and lengths; in
3105 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3106 the resulting string length overflows an EMACS_INT; instead,
3107 report a string overflow if no precision given. When checking for
3108 precision exhaustion, use a check that cannot possibly have
3109 integer overflow. (Bug#8675)
3110 * character.h (lisp_string_width): Adjust to new signature.
3112 * alloc.c (string_overflow): New function.
3113 (Fmake_string): Use it. This doesn't change behavior, but saves
3114 a few bytes and will simplify future changes.
3115 * character.c (string_escape_byte8): Likewise.
3116 * lisp.h (string_overflow): New decl.
3118 Fixups, following up to the user-interface timestamp change.
3119 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3120 for UI timestamps, instead of unsigned long.
3121 * msdos.c (mouse_get_pos): Likewise.
3122 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3123 * w32gui.h (Time): Define by including "systime.h" rather than by
3124 declaring it ourselves. (Bug#8664)
3126 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3127 * image.c (clear_image_cache): Likewise.
3129 * term.c (term_mouse_position): Don't assume time_t wraparound.
3131 Be more systematic about user-interface timestamps.
3132 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3133 and sometimes 'EMACS_UINT', to represent these timestamps.
3134 This change causes it to use 'Time' uniformly, as that's what X uses.
3135 This makes the code easier to follow, and makes it easier to catch
3136 integer overflow bugs such as Bug#8664.
3137 * frame.c (Fmouse_position, Fmouse_pixel_position):
3138 Use Time, not unsigned long, for user-interface timestamps.
3139 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3140 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3141 * keyboard.h (last_event_timestamp): Likewise.
3142 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3143 * menu.h (xmenu_show): Likewise.
3144 * term.c (term_mouse_position): Likewise.
3145 * termhooks.h (struct input_event.timestamp): Likewise.
3146 (struct terminal.mouse_position_hook): Likewise.
3147 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3148 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3149 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3150 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3152 * menu.h, termhooks.h: Include "systime.h", for Time.
3154 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3155 Don't assume that the difference between two unsigned long values
3156 can fit into an integer. At this point, we know button_down_time
3157 <= event->timestamp, so the difference must be nonnegative, so
3158 there's no need to cast the result if double-click-time is
3159 nonnegative, as it should be; check that it's nonnegative, just in
3160 case. This bug is triggered when events are more than 2**31 ms
3161 apart (about 25 days). (Bug#8664)
3163 * xselect.c (last_event_timestamp): Remove duplicate decl.
3164 (x_own_selection): Remove needless cast to unsigned long.
3166 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3167 that always fit in int. Use a sentinel instead of a counter, to
3168 avoid a temp and to allay GCC's concerns about possible int overflow.
3169 * frame.h (struct frame): Use int for menu_bar_items_used
3170 instead of EMACS_INT, since it always fits in int.
3172 * menu.c (grow_menu_items): Check for int overflow.
3174 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3176 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3177 Before, the code was not consistent. These values cannot exceed
3178 2**31 - 1 so there's no need to make them unsigned.
3179 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3180 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3181 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3183 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3185 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3186 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3187 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3188 presumably because the widths might not match.
3190 * window.c (size_window): Avoid needless test at loop start.
3192 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3194 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3196 2011-05-12 Drew Adams <drew.adams@oracle.com>
3198 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3200 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3202 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3203 `width' to `bar_area_x' and `bar_area_width', respectively.
3204 (x_scroll_run): Take account of fringe background extension.
3206 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3207 Rename local vars `left' and `width' to `bar_area_x' and
3208 `bar_area_width', respectively.
3209 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3210 background extension.
3212 2011-05-10 Jim Meyering <meyering@redhat.com>
3214 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3216 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3218 * image.c (Finit_image_library): Return t for built-in image types,
3219 like pbm and xbm. (Bug#8640)
3221 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3223 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3225 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3227 * w32console.c (Fset_screen_color): Doc fix.
3228 (Fget_screen_color): New function.
3229 (syms_of_ntterm): Defsubr it.
3231 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3232 unlink the temporary file if Fcall_process didn't create it in the
3234 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3235 child process will be redirected to a file specified with `:file'.
3236 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3237 cue to call_process_cleanup not to close that handle.
3239 2011-05-07 Ben Key <bkey76@gmail.com>
3241 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3242 one of two shell specific rules, either bootstrap-temacs-CMD or
3243 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3244 to the previous implementation of the bootstrap-temacs rule.
3245 The bootstrap-temacs-CMD rule is similar to the previous
3246 implementation of the bootstrap-temacs rule except that it
3247 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3250 These changes, along with some changes to nt/configure.bat,
3251 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3252 earlier fix to add support for --cflags and --ldflags options
3253 that include quotes so that it works whether make uses cmd or
3256 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3258 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3259 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3261 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3262 a string. Handle both cases.
3263 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3264 (Fdbus_register_method): Use Qinvalid_function.
3266 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3268 * makefile.w32-in: Update dependencies.
3269 (LISP_H): Add inttypes.h and stdin.h.
3270 (PROCESS_H): Add unistd.h.
3272 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3274 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3275 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3277 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3279 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3281 * term.c (vfatal): Remove stray call to va_end.
3282 It's not needed and the C Standard doesn't allow it here anyway.
3284 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3285 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3287 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3290 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3292 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3294 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3296 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3298 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3300 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3301 * charset.c (Fdefine_charset_internal): Don't initialize
3302 charset.code_space[15]. The value was garbage, on hosts with
3303 32-bit int (Bug#8600).
3305 * lread.c (read_integer): Be more consistent with string-to-number.
3306 Use string_to_number to do the actual conversion; this avoids
3307 rounding errors and fixes some other screwups. Without this fix,
3308 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3309 (digit_to_number): Move earlier, for benefit of read_integer.
3310 Return -1 if the digit is out of range for the base, -2 if it is
3311 not a digit in any supported base. (Bug#8602)
3313 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3315 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3316 to match comment at start of function. This also removes a
3317 GCC warning about overflow in a 32+64-bit port.
3319 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3321 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3322 Reported by Stefan Monnier in
3323 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3324 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3325 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3327 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3328 (EMACS_UINTPTR): Likewise, with uintptr_t.
3330 * lisp.h: Prefer 64-bit EMACS_INT if available.
3331 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3332 on 32-bit hosts that have 64-bit int, so that they can access
3334 However, temporarily disable this change unless the temporary
3335 symbol WIDE_EMACS_INT is defined.
3337 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3339 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3340 This removes an assumption that EMACS_INT and long are the same
3341 width as pointers. The assumption is true for Emacs porting targets
3342 now, but we want to make other targets possible.
3343 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3344 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3345 In the rest of the code, change types of integers that hold casted
3346 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3347 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3348 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3349 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3350 No need to cast type when ORing.
3351 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3352 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3353 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3354 assume EMACS_INT is the same width as char *.
3355 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3356 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3357 Remove no-longer-needed casts.
3358 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3359 (xg_tool_bar_help_callback, xg_make_tool_item):
3360 Use EMACS_INTPTR to hold an integer
3361 that will be cast to void *; this can avoid a GCC warning
3362 if EMACS_INT is not the same width as void *.
3363 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3364 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3365 (current_message_1, set_message_1):
3366 Use a local to convert to proper width without a cast.
3367 * xmenu.c (dialog_selection_callback): Likewise.
3369 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3370 Also, don't assume VALBITS / RAND_BITS is less than 5,
3371 and don't rely on undefined behavior when shifting a 1 left into
3373 * lisp.h (get_random): Change signature to match.
3375 * lread.c (hash_string): Use size_t, not int, for hash computation.
3376 Normally we prefer signed values; but hashing is special, because
3377 it's better to use unsigned division on hash table sizes so that
3378 the remainder is nonnegative. Also, size_t is the natural width
3379 for hashing into memory. The previous code used 'int', which doesn't
3380 retain enough info to hash well into very large tables.
3381 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3383 * dbusbind.c: Don't possibly lose pointer info when converting.
3384 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3385 Use XPNTR rather than XHASH, so that the high-order bits of
3386 the pointer aren't lost when converting through void *.
3388 * eval.c (Fautoload): Don't double-shift a pointer.
3390 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3392 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3394 * gnutls.c (DEF_GNUTLS_FN):
3395 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3397 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3399 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3402 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3404 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3405 New version that can reserve upto 2GB of heap space.
3407 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3409 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3411 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3413 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3414 `gnutls_certificate_set_x509_key_file'.
3416 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3418 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3419 Update dependencies.
3421 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3423 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3424 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3425 Remove unused parameter `fildes'.
3426 * process.c (read_process_output, send_process): Don't pass it.
3428 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3430 Fix previous change: the library cache is defined in w32.c.
3431 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3432 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3434 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3436 Implement dynamic loading of GnuTLS on Windows.
3438 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3439 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3440 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3443 * gnutls.c (Qgnutls_dll): Define.
3444 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3445 (gnutls_*): Declare function pointers.
3446 (init_gnutls_functions): New function to initialize function pointers.
3447 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3448 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3449 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3450 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3451 (emacs_gnutls_write, emacs_gnutls_read)
3452 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3453 (Fgnutls_available_p): New function.
3454 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3455 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3456 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3458 * image.c: Include w32.h.
3459 (Vimage_type_cache): Delete.
3460 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3461 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3462 (w32_delayed_load): Move to w32.c.
3464 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3466 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3467 (w32_delayed_load): Move from image.c. When loading a library, record
3468 its filename in the :loaded-from property of the library id.
3469 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3470 Initialize and staticpro them.
3471 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3473 * process.c: Include lisp.h before w32.h, not after.
3474 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3475 instead of gnutls_record_check_pending.
3477 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3479 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3481 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3482 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3485 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3487 * xterm.c (x_set_frame_alpha): Do not set property on anything
3488 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3490 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3492 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3494 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3496 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3497 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3498 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3499 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3500 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3501 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3502 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3503 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3504 (Qgnutls_bootprop_callbacks_verify): Make static.
3506 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3508 * callproc.c: Indentation fixup.
3510 * sysdep.c (wait_for_termination_1): Make static.
3511 (wait_for_termination, interruptible_wait_for_termination):
3512 Move after wait_for_termination_1.
3514 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3516 * sysdep.c (interruptible_wait_for_termination): New function
3517 which is like wait_for_termination, but allows keyboard
3520 * callproc.c (Fcall_process): Add (:file "file") as an option for
3522 (Fcall_process_region): Ditto.
3524 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3526 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3527 rather than `XVECTOR (FOO)->size'.
3529 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3530 inttypes.h, as a gnulib replacement is used if it not available in
3533 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3535 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3536 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3537 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3539 * coding.c (coding_alloc_by_realloc): Error out if destination
3540 will grow beyond MOST_POSITIVE_FIXNUM.
3541 (decode_coding_emacs_mule): Abort if there isn't enough place in
3542 charbuf for the composition carryover bytes. Reserve an extra
3543 space for up to 2 characters produced in a loop.
3544 (decode_coding_iso_2022): Abort if there isn't enough place in
3545 charbuf for the composition carryover bytes.
3547 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3549 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3550 aborting when %lld or %lll format is passed.
3551 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3552 %llo or %llx format is passed. (Bug#8545)
3554 * window.c (window_scroll_line_based): Use a marker instead of
3555 simple variables to record original value of point. (Bug#7952)
3557 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3558 produced by %s or %c overflows available buffer space. (Bug#8545)
3560 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3562 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3563 (SIZE_MAX): Move defn after all includes, as they might #define it.
3565 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3567 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3569 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3571 * keyboard.c (Qdelayed_warnings_hook): Define.
3572 (command_loop_1): Run `delayed-warnings-hook'
3573 if Vdelayed_warnings_list is non-nil.
3574 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3575 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3577 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3579 * doprnt.c (doprnt): Don't return value smaller than the buffer
3580 size if the message was truncated. (Bug#8545).
3582 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3584 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3585 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3587 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3589 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3591 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3593 * makefile.w32-in: Update dependencies.
3595 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3597 Improve `doprnt' and its usage. (Bug#8545)
3598 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3599 `format_end'. Remove support for %l as a conversion specifier.
3600 Don't use xrealloc. Improve diagnostics when the %l size modifier
3601 is used. Update the commentary.
3603 * eval.c (verror): Simplify calculation of size_t.
3605 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3608 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3610 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3613 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3615 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3616 This makes this file independent of the recent pseudovector change.
3618 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3620 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3622 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3623 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3624 Remove unused local.
3625 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3627 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3628 GCC 4.6.0 optimizes based on type-based alias analysis.
3629 For example, if b is of type struct buffer * and v of type struct
3630 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3631 != &v->size, and therefore "v->size = 1; b->size = 2; return
3632 v->size;" must therefore return 1. This assumption is incorrect
3633 for Emacs, since it type-puns struct Lisp_Vector * with many other
3634 types. To fix this problem, this patch adds a new type struct
3635 vectorlike_header that documents the constraints on layout of vectors
3636 and pseudovectors, and helps optimizing compilers not get fooled
3637 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3638 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3639 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3641 (XSETPVECTYPE): Rewrite in terms of new macro.
3642 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3643 This is a bit clearer, and further avoids the possibility of
3644 undesirable aliasing.
3645 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3646 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3647 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3648 since Lisp_Subr is a special case (no "next" field).
3649 (ASIZE): Now uses header.size rather than size.
3650 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3651 to avoid the hassle of writing XVECTOR (foo)->header.size.
3652 (struct vectorlike_header): New type.
3653 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3654 object, to help avoid aliasing.
3655 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3656 (SUBRP): Likewise, since Lisp_Subr is a special case.
3657 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3658 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3659 (struct Lisp_Hash_Table): Combine first two members into a single
3660 struct vectorlike_header member. All uses of "size" and "next" members
3661 changed to be "header.size" and "header.next".
3662 * buffer.h (struct buffer): Likewise.
3663 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3664 * frame.h (struct frame): Likewise.
3665 * process.h (struct Lisp_Process): Likewise.
3666 * termhooks.h (struct terminal): Likewise.
3667 * window.c (struct save_window_data, struct saved_window): Likewise.
3668 * window.h (struct window): Likewise.
3669 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3670 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3671 * buffer.c (init_buffer_once): Likewise.
3672 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3674 * process.c (Fformat_network_address): Use local var for size,
3677 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3679 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3680 * data.c (atof): Remove decl; no longer used or needed.
3681 (digit_to_number): Move to lread.c.
3682 (Fstring_to_number): Use new string_to_number function, to be
3683 consistent with how the Lisp reader treats infinities and NaNs.
3684 Do not assume that floating-point numbers represent EMACS_INT
3685 without losing information; this is not true on most 64-bit hosts.
3686 Avoid double-rounding errors, by insisting on integers when
3687 parsing non-base-10 numbers, as the documentation specifies.
3688 * lisp.h (string_to_number): New decl, replacing ...
3689 (isfloat_string): Remove.
3690 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3691 (read1): Do not accept +. and -. as integers; this
3692 appears to have been a coding error. Similarly, do not accept
3693 strings like +-1e0 as floating point numbers. Do not report
3694 overflow for integer overflows unless the base is not 10 which
3695 means we have no simple and reliable way to continue.
3696 Break out the floating-point parsing into a new
3697 function string_to_number, so that Fstring_to_number parses
3698 floating point numbers consistently with the Lisp reader.
3699 (digit_to_number): Move here from data.c. Make it static inline.
3700 (E_CHAR, EXP_INT): Remove, replacing with ...
3701 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3702 (string_to_number): New function, replacing isfloat_string.
3703 This function checks for valid syntax and produces the resulting
3704 Lisp float number too. Rework it so that string-to-number
3705 no longer mishandles examples like "1.0e+". Use strtoumax,
3706 so that overflow for non-base-10 numbers is reported only when
3707 there's no portable and simple way to convert to floating point.
3709 * textprop.c (set_text_properties_1): Rewrite for clarity,
3710 and to avoid GCC warning about integer overflow.
3712 * intervals.h (struct interval): Use EMACS_INT for members
3713 where EMACS_UINT might cause problems. See
3714 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3715 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3716 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3718 (offset_intervals): Tell GCC not to worry about length overflow
3719 when negating a negative length.
3721 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3722 (overrun_check_free): Likewise.
3724 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3725 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3728 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3729 (gnutls_make_error): Rename local to avoid shadowing.
3730 (gnutls_emacs_global_deinit): ifdef out; not used.
3731 (Fgnutls_boot): Use const for pointer to readonly storage.
3732 Comment out unused local. Fix pointer signedness problems.
3734 * lread.c (openp): Don't stuff size_t into an 'int'.
3735 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3736 about possible signed overflow.
3738 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3739 (GDK_KEY_g): Don't define if already defined.
3740 (xg_prepare_tooltip): Avoid pointer signedness problem.
3741 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3743 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3744 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3746 * xfns.c (Fx_window_property): Simplify a bit,
3747 to make a bit faster and to avoid GCC 4.6.0 warning.
3748 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3750 * fns.c (internal_equal): Don't assume size_t fits in int.
3752 * alloc.c (compact_small_strings): Tighten assertion a little.
3754 Replace pEd with more-general pI, and fix some printf arg casts.
3755 * lisp.h (pI): New macro, generalizing old pEd macro to other
3756 conversion specifiers. For example, use "...%"pI"d..." rather
3757 than "...%"pEd"...".
3758 (pEd): Remove. All uses replaced with similar uses of pI.
3759 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3760 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3761 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3762 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3763 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3764 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3765 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3767 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3768 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3769 * print.c (safe_debug_print, print_object): Likewise.
3770 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3772 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3773 avoiding the 0 flag, which is not portable.
3774 * process.c (Fmake_network_process): Use pI to avoid cast.
3775 * region-cache.c (pp_cache): Likewise.
3776 * xdisp.c (decode_mode_spec): Likewise.
3777 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3778 behavior on 64-bit hosts with printf arg.
3779 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3780 (x_stop_queuing_selection_requests): Likewise.
3781 (x_get_window_property): Don't truncate byte count to an 'int'
3784 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3785 here, since it parses constructs like leading '-' and spaces,
3786 which are not wanted; and it overflows with large numbers.
3787 Instead, simply match F[0-9]+, which is what is wanted anyway.
3789 * alloc.c: Remove unportable assumptions about struct layout.
3790 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3791 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3792 (allocate_vectorlike, make_pure_vector): Use the new macros,
3793 plus offsetof, to remove unportable assumptions about struct layout.
3794 These assumptions hold on all porting targets that I know of, but
3795 they are not guaranteed, they're easy to remove, and removing them
3796 makes further changes easier.
3798 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3799 This doesn't fix a bug but makes the code clearer.
3800 (string_overrun_cookie): Now const. Use initializers that
3801 don't formally overflow signed char, to avoid warnings.
3802 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3803 can cause Emacs to crash when string overrun checking is enabled.
3804 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3805 multiple of sizeof (EMACS_INT); it need not be, if
3806 alignof(EMACS_INT) < sizeof (EMACS_INT).
3807 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3809 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3811 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3813 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3815 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3816 supposed to be handshaking. (Bug#8556)
3817 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3819 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3821 * lisp.h (Qdebug): List symbol.
3822 * eval.c (Qdebug): Restore global linkage.
3823 * keyboard.c (debug-on-event): New variable.
3824 (handle_user_signal): Break into debugger when debug-on-event
3825 matches the current signal symbol.
3827 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3829 * alloc.c (check_sblock, check_string_bytes)
3830 (check_string_free_list): Convert to standard C.
3832 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3834 * w32.c (emacs_gnutls_push): Fix typo.
3836 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3838 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3839 "cast to pointer from integer of different size".
3841 Improve doprnt and its use in verror. (Bug#8545)
3842 * doprnt.c (doprnt): Document the set of format control sequences
3843 supported by the function. Use SAFE_ALLOCA instead of always
3846 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3847 is one byte too soon. Don't use xrealloc; instead xfree and
3850 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3852 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3855 * gnutls.c: Renamed global_initialized to
3856 gnutls_global_initialized. Added internals for the
3857 :verify-hostname-error, :verify-error, and :verify-flags
3858 parameters of `gnutls-boot' and documented those parameters in the
3859 docstring. Start callback support.
3860 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3861 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3862 on error. Return error code.
3863 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3864 (emacs_gnutls_read): Likewise.
3865 (Fgnutls_boot): Return handshake error code.
3866 (emacs_gnutls_handle_error): New function.
3867 (wsaerror_to_errno): Likewise.
3869 * w32.h (emacs_gnutls_pull): Add prototype.
3870 (emacs_gnutls_push): Likewise.
3872 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3873 (emacs_gnutls_push): Likewise.
3875 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3877 * process.c (wait_reading_process_output): Check if GnuTLS
3878 buffered some data internally if no FDs are set for TLS
3881 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3882 (LIBS): Link to USER_LIBS.
3883 ($(BLD)/gnutls.$(0)): New target.
3885 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3887 * xdisp.c (handle_single_display_spec): Rename the
3888 display_replaced_before_p argument into display_replaced_p, to
3889 make it consistent with the commentary. Fix typos in the
3892 * textprop.c (syms_of_textprop): Remove dead code.
3893 (copy_text_properties): Delete obsolete commentary about an
3894 interface that was deleted long ago. Fix typos in the description
3897 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3898 to changes in oldXMenu/XMenu.h from 2011-04-16.
3899 <menu_help_message, prev_menu_help_message>: Constify.
3900 (IT_menu_make_room): menu->help_text is now `const char **';
3903 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3904 to changes in oldXMenu/XMenu.h from 2011-04-16.
3905 (struct XMenu): Declare `help_text' `const char **'.
3907 * xfaces.c <Qunspecified>: Make extern again.
3909 * syntax.c: Include sys/types.h before including regex.h, as
3912 * doc.c (get_doc_string): Improve the format passed to `error'.
3914 * doprnt.c (doprnt): Improve commentary.
3916 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3918 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3921 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3922 changes in globals.h immediately force recompilation.
3923 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3924 $(CURDIR)/s/ms-w32.h.
3925 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3927 * character.c (Fchar_direction): Function deleted.
3928 (syms_of_character): Don't defsubr it.
3929 <char-direction-table>: Deleted.
3931 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3933 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3934 * doprnt.c: Include limits.h.
3935 (SIZE_MAX): New macro.
3936 (doprnt): Return a size_t value. 2nd arg is now size_t.
3937 Many local variables are now size_t instead of int or unsigned.
3938 Improve overflow protection. Support `l' modifier for integer
3939 conversions. Support %l conversion. Don't assume an EMACS_INT
3940 argument for integer conversions and for %c.
3942 * lisp.h (doprnt): Restore prototype.
3944 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3947 * Makefile.in (base_obj): Add back doprnt.o.
3949 * deps.mk (doprnt.o): Add back prerequisites.
3950 (callint.o): Depend on character.h.
3952 * eval.c (internal_lisp_condition_case): Include the handler
3953 representation in the error message.
3954 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3955 when breaking from the loop.
3957 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3959 * callint.c (Fcall_interactively): When displaying error message
3960 about invalid control letter, pass the character's codepoint, not
3961 a pointer to its multibyte form. Improve display of the character
3962 in octal and display also its hex code.
3964 * character.c (char_string): Use %x to display the (unsigned)
3965 codepoint of an invalid character, to avoid displaying a bogus
3968 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3969 `error', not SYMBOL_NAME itself.
3971 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3972 character arguments to `error'.
3974 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3975 to `error' in error message about FINAL_CHAR argument. Make sure
3976 FINAL_CHAR is a character, and use %c when it is passed as
3977 argument to `error'.
3979 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3981 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3983 * w32.c: Include <time.h>.
3984 (sys_localtime): New function.
3986 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3988 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3990 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3992 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3994 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3997 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3999 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4000 gl_state.e_property when gl_state.object is Qt.
4002 * insdel.c (make_gap_larger): Remove limitation of buffer size
4005 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4007 * xdisp.c (lookup_glyphless_char_display)
4008 (produce_glyphless_glyph): Handle cons cell entry in
4009 glyphless-char-display.
4010 (Vglyphless_char_display): Document it.
4012 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4013 glyphless-char-display.
4015 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4017 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4019 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4021 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4022 definition for no-X builds.
4024 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4026 Static checks with GCC 4.6.0 and non-default toolkits.
4028 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4030 * process.c (keyboard_bit_set): Define only if SIGIO.
4031 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4032 (send_process): Repair possible setjmp clobbering.
4034 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4036 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4038 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4040 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4041 Define only if needed.
4043 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4044 by pacifying GCC about it. Maybe it's time to retire it?
4045 * xfaces.c (USG, __TIMEVAL__): Likewise.
4047 * dispextern.h (struct redisplay_interface): Rename param
4049 * termhooks.h (struct terminal): Likewise.
4050 * xterm.c (xembed_send_message): Likewise.
4052 * insdel.c (make_gap_smaller): Define only if
4053 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4055 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4058 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4059 so that we aren't warned about unused symbols.
4061 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4063 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4065 * xfns.c (x_real_positions): Mark locals as initialized.
4067 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4069 * xterm.c: Fix problems found by static analysis with other toolkits.
4070 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4071 (x_dispatch_event): Declare static if USE_GTK, and
4072 define if USE_GTK || USE_X_TOOLKIT.
4073 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4074 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4075 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4076 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4078 * xmenu.c (menu_help_callback): Pointer type fixes.
4079 Use const pointers when pointing at readonly data. Avoid pointer
4081 (FALSE): Remove unused macro.
4082 (update_frame_menubar): Remove unused decl.
4084 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4086 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4087 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4088 (single_menu_item): Rename local to avoid shadowing.
4090 * keyboard.c (make_lispy_event): Remove unused local var.
4092 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4093 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4095 * bitmaps: Change bitmaps from unsigned char back to the X11
4096 compatible char. Avoid the old compiler warnings about
4097 out-of-range initializers by using, for example, '\xab' rather
4100 * xgselect.c (xgselect_initialize): Check vs interface
4101 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4103 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4105 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4106 to read-only memory.
4108 * fns.c (vector): Remove; this old hack is no longer needed.
4110 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4112 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4114 * xrdb.c (x_load_resources): Omit unused local.
4116 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4117 (x_window): Rename locals to avoid shadowing.
4118 (USG): Use the kludged USG macro, to pacify gcc.
4120 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4121 (x_term_init): Remove local to avoid shadowing.
4123 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4125 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4126 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4128 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4130 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4132 Fix regex.c, syntax.c and friends for buffers > 2GB.
4133 * syntax.h (struct gl_state_s): Declare character position members
4136 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4138 * textprop.c (verify_interval_modification, interval_of):
4139 Declare arguments EMACS_INT.
4141 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4144 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4146 * indent.c (Fvertical_motion): Local variable it_start is now
4149 * regex.c (re_match, re_match_2, re_match_2_internal)
4150 (bcmp_translate, regcomp, regexec, print_double_string)
4151 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4152 (re_compile_pattern, re_exec): Declare arguments and local
4153 variables `size_t' and `ssize_t' and return values `regoff_t', as
4155 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4156 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4157 <compile_stack_type>: `size' and `avail' are now `size_t'.
4159 * regex.h <regoff_t>: Use ssize_t, not int.
4160 (re_search, re_search_2, re_match, re_match_2): Arguments that
4161 specify buffer/string position and length are now ssize_t and
4162 size_t. Return type is regoff_t.
4164 2011-04-16 Ben Key <bkey76@gmail.com>
4166 * nsfont.m: Fixed bugs in ns_get_family and
4167 ns_descriptor_to_entity that were caused by using free to
4168 deallocate memory blocks that were allocated by xmalloc (via
4169 xstrdup). This caused Emacs to crash when compiled with
4170 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4171 --enable-checking=xmallocoverrun). xfree is now used to
4172 deallocate these memory blocks.
4174 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4176 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4178 emacs_write: Accept and return EMACS_INT for sizes.
4179 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4181 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4182 Accept and return EMACS_INT.
4183 (emacs_gnutls_write): Return the number of bytes written on
4185 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4186 (emacs_read, emacs_write): Remove check for negative size, as the
4187 Emacs source code has been audited now.
4188 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4189 (emacs_read, emacs_write): Use it.
4190 * process.c (send_process): Adjust to the new signatures of
4191 emacs_write and emacs_gnutls_write. Do not attempt to store
4192 a byte offset into an 'int'; it might overflow.
4193 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4195 * sound.c: Don't assume sizes fit in 'int'.
4196 (struct sound_device.period_size, alsa_period_size):
4197 Return EMACS_INT, not int.
4198 (struct sound_device.write, vox_write, alsa_write):
4199 Accept EMACS_INT, not int.
4200 (wav_play, au_play): Use EMACS_INT to store sizes and to
4201 record read return values.
4203 2011-04-15 Ben Key <bkey76@gmail.com>
4205 * keyboard.c (Qundefined): Don't declare static since it is used
4207 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4208 static since they are used in nsfont.m.
4210 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4212 * process.c (Qprocessp): Don't declare static.
4213 * lisp.h (Qprocessp): Declare again.
4215 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4217 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4219 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4221 Improve C-level modularity by making more things 'static'.
4223 Don't publish debugger-only interfaces to other modules.
4224 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4225 (verify_bytepos, count_markers): Move decls to the only modules
4227 * region-cache.h (pp_cache): Likewise.
4228 * window.h (check_all_windows): Likewise.
4229 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4231 * sysdep.c (croak): Now static, if
4232 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4233 * syssignal.h (croak): Declare only if not static.
4235 * alloc.c (refill_memory_reserve): Now static if
4236 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4237 * lisp.h (refill_memory_reserve): Declare only if not static.
4239 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4240 Define only if USE_LUCID.
4242 * xrdb.c (x_customization_string, x_rm_string): Now static.
4244 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4245 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4247 * xdisp.c (draw_row_with_mouse_face): Now static.
4248 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4250 * window.h (check_all_windows): Mark externally visible.
4252 * window.c (window_deletion_count): Now static.
4254 * undo.c: Make symbols static if they're not exported.
4255 (last_undo_buffer, last_boundary_position, pending_boundary):
4258 * textprop.c (interval_insert_behind_hooks): Now static.
4259 (interval_insert_in_front_hooks): Likewise.
4261 * term.c: Make symbols static if they're not exported.
4262 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4263 (max_frame_lines, tty_set_terminal_modes):
4264 (tty_reset_terminal_modes, tty_turn_off_highlight):
4265 (get_tty_terminal): Now static.
4266 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4267 * termhooks.h (term_mouse_moveto): Do not declare if
4269 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4270 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4272 * sysdep.c: Make symbols static if they're not exported.
4273 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4275 (sigprocmask_set, full_mask): Remove; unused.
4276 (wait_debugging): Mark as visible.
4277 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4278 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4280 * syntax.c (syntax_temp): Define only if !__GNUC__.
4282 * sound.c (current_sound_device, current_sound): Now static.
4284 * search.c (searchbufs, searchbuf_head): Now static.
4286 * scroll.c (scroll_cost): Remove; unused.
4287 * dispextern.h (scroll_cost): Remove decl.
4289 * region-cache.h (pp_cache): Mark as externally visible.
4291 * process.c: Make symbols static if they're not exported.
4292 (process_tick, update_tick, create_process, chan_process):
4293 (Vprocess_alist, proc_buffered_char, datagram_access):
4294 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4295 (deactivate_process): Mark defn as static, as well as decl.
4296 * lisp.h (create_process): Remove decl.
4297 * process.h (chan_process, Vprocess_alist): Remove decls.
4299 * print.c: Make symbols static if they're not exported.
4300 (print_depth, new_backquote_output, being_printed, print_buffer):
4301 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4302 (print_interval, print_number_index, initial_stderr_stream):
4304 * lisp.h (Fprinc): Remove decl.
4305 (debug_output_compilation_hack): Mark as externally visible.
4307 * sysdep.c (croak): Move decl from here to syssignal.h.
4308 * syssignal.h (croak): Put it here, so the API can be checked when
4309 'croak' is called from dissociate_if_controlling_tty.
4311 * minibuf.c: Make symbols static if they're not exported.
4312 (minibuf_save_list, choose_minibuf_frame): Now static.
4313 * lisp.h (choose_minibuf_frame): Remove decl.
4315 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4317 * lread.c: Make symbols static if they're not exported.
4318 (read_objects, initial_obarray, oblookup_last_bucket_number):
4320 (make_symbol): Remove; unused.
4321 * lisp.h (initial_obarray, make_symbol): Remove decls.
4323 * keyboard.c: Make symbols static if they're not exported.
4324 (single_kboard, recent_keys_index, total_keys, recent_keys):
4325 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4326 (this_single_command_key_start, echoing, last_auto_save):
4327 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4328 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4329 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4330 (Vlispy_mouse_stem, double_click_count):
4332 (force_auto_save_soon): Define only if SIGDANGER.
4333 (ignore_mouse_drag_p): Now static if
4334 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4335 (print_help): Remove; unused.
4336 (stop_character, last_timer_event): Mark as externally visible.
4337 * keyboard.h (ignore_mouse_drag_p): Declare only if
4338 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4339 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4340 * lisp.h (echoing): Remove decl.
4341 (force_auto_save_soon): Declare only if SIGDANGER.
4342 * xdisp.c (redisplay_window): Simplify code, to make it more
4343 obvious that ignore_mouse_drag_p is not accessed if !defined
4344 USE_GTK && !defined HAVE_NS.
4346 * intervals.c: Make symbols static if they're not exported.
4347 (merge_properties_sticky, merge_interval_right, delete_interval):
4349 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4351 * insdel.c: Make symbols static if they're not exported.
4352 However, leave prepare_to_modify_buffer alone. It's never
4353 called from outside this function, but that appears to be a bug.
4354 (combine_after_change_list, combine_after_change_buffer):
4355 (adjust_after_replace, signal_before_change): Now static.
4356 (adjust_after_replace_noundo): Remove; unused.
4357 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4358 (signal_before_change): Remove decls.
4360 * indent.c (val_compute_motion, val_vmotion): Now static.
4362 * image.c: Make symbols static if they're not exported.
4363 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4365 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4366 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4368 * fringe.c (standard_bitmaps): Now static.
4369 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4371 * frame.c: Make symbols static if they're not exported.
4372 (x_report_frame_params, make_terminal_frame): Now static.
4373 (get_frame_param): Now static, unless HAVE_NS.
4374 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4375 (x_get_resource_string): Remove; not used.
4376 * frame.h (make_terminal_frame, x_report_frame_params):
4377 (x_get_resource_string); Remove decls.
4378 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4379 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4381 * font.c, fontset.c: Make symbols static if they're not exported.
4382 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4383 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4384 * font.c (font_close_object): Now static.
4385 * font.h (font_close_object): Remove.
4386 * fontset.c (FONTSET_OBJLIST): Remove.
4387 (free_realized_fontset) #if-0 the body, which does nothing.
4388 (face_suitable_for_char_p): #if-0, as it's never called.
4389 * fontset.h (face_suitable_for_char_p): Remove decl.
4390 * xfaces.c (face_at_string_position):
4391 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4392 since 0 is always ASCII.
4394 * fns.c (weak_hash_tables): Now static.
4396 * fileio.c: Make symbols static if they're not exported.
4397 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4398 (Vwrite_region_annotation_buffers): Now static.
4400 * eval.c: Make symbols static if they're not exported.
4401 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4402 * lisp.h (backtrace_list): Remove decl.
4404 * emacs.c: Make symbols static if they're not exported.
4405 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4406 (fatal_error_code, fatal_error_signal_hook, standard_args):
4408 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4409 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4410 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4411 * lisp.h (fatal_error_signal_hook): Remove decl.
4412 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4414 * editfns.c: Move a (normally-unused) function to its only use.
4415 * editfns.c, lisp.h (get_operating_system_release): Remove.
4416 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4417 worth the hassle of breaking this out.
4419 * xterm.c: Make symbols static if they're not exported.
4420 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4421 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4422 (x_destroy_window, x_delete_display):
4424 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4425 (x_mouse_leave): Remove; unused.
4426 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4427 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4428 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4430 (x_mouse_leave): Declare only if WINDOWSNT.
4431 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4432 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4435 * ftxfont.c: Make symbols static if they're not exported.
4436 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4438 * font.h (ftxfont_driver): Likewise.
4440 * xfns.c: Make symbols static if they're not exported.
4441 (x_last_font_name, x_display_info_for_name):
4442 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4443 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4444 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4445 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4446 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4447 (last_show_tip_args): Now static.
4448 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4449 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4450 (x_screen_planes): Remove; unused.
4451 * dispextern.h (x_screen_planes): Remove decl.
4453 * dispnew.c: Make symbols static if they're not exported.
4454 * dispextern.h (redraw_garbaged_frames, scrolling):
4455 (increment_row_positions): Remove.
4456 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4457 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4459 (redraw_garbaged_frames): Remove; unused.
4461 * xfaces.c: Make symbols static if they're not exported.
4462 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4464 * xterm.h (defined_color): Remove decls.
4465 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4466 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4467 (menu_face_changed_default, defined_color, free_realized_face):
4468 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4469 (ascii_face_of_lisp_face): Remove; unused.
4471 * xdisp.c: Make symbols static if they're not exported.
4472 * dispextern.h (scratch_glyph_row, window_box_edges):
4473 (glyph_to_pixel_coords, set_cursor_from_row):
4474 (get_next_display_element, set_iterator_to_next):
4475 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4476 (show_mouse_face): Remove decls
4477 * frame.h (message_buf_print): Likewise.
4478 * lisp.h (pop_message, set_message, check_point_in_composition):
4480 * xterm.h (set_vertical_scroll_bar): Likewise.
4481 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4482 (message_buf_print, scratch_glyph_row, displayed_buffer):
4483 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4484 (get_next_display_element, show_mouse_face, window_box_edges):
4485 (frame_to_window_pixel_xy, check_point_in_composition):
4486 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4487 (glyph_to_pixel_coords): Remove; unused.
4489 * dired.c (file_name_completion): Now static.
4491 * dbusbind.c (xd_in_read_queued_messages): Now static.
4493 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4494 * data.c (circular_list_error): Remove.
4496 * commands.h (last_point_position, last_point_position_buffer):
4497 (last_point_position_window): Remove decls.
4498 * keyboard.c: Make these variables static.
4500 * coding.h (coding, code_convert_region, encode_coding_gap):
4502 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4503 (iso_code_class, detect_coding, code_convert_region): Now static.
4504 (encode_coding_gap): Remove; unused.
4506 * chartab.c (chartab_chars, chartab_bits): Now static.
4508 * charset.h (charset_iso_8859_1): Remove decl.
4509 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4512 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4513 * ccl.c (Vccl_program_table): Now static.
4514 (check_ccl_update): Remove; unused.
4516 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4517 * category.h: ... from here.
4518 * category.c (check_category_table, set_category_set): Now static.
4520 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4521 * lisp.h: Remove these decls.
4523 * buffer.c (buffer_count): Remove unused var.
4525 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4526 so that it's not optimized away.
4527 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4528 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4529 exported only to the debugger.
4531 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4532 * atimer.h (run_all_atimers): Remove; not exported.
4534 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4535 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4536 was inaccessible from Lisp.
4537 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4538 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4540 alloc.c: Import and export fewer symbols, and remove unused items.
4541 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4543 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4544 it's not optimized away by whole-program optimization.
4545 (message_enable_multibyte, free_misc): Remove.
4546 (catchlist, handlerlist, mark_backtrace):
4547 Declare only if BYTE_MARK_STACK.
4548 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4549 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4550 (message_enable_multibyte): Remove decl.
4551 (free_misc, interval_free_list, float_block, float_block_index):
4552 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4553 (cons_free_list, last_marked_index):
4555 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4556 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4557 (mark_backtrace): Define only if BYTE_MARK_STACK.
4558 * xdisp.c (message_enable_multibyte): Now static.
4560 Declare Lisp_Object Q* variables to be 'static' if not exported.
4561 This makes it easier for human readers (and static analyzers)
4562 to see whether these variables are used from other modules.
4563 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4564 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4565 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4566 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4567 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4568 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4569 * xmenu.c, xselect.c:
4570 Declare Q* vars static if they are not used in other modules.
4571 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4572 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4573 Remove decls of unexported vars.
4574 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4576 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4578 Make Emacs functions such as Fatom 'static' by default.
4579 This makes it easier for human readers (and static analyzers)
4580 to see whether these functions can be called from other modules.
4581 DEFUN now defines a static function. To make the function external
4582 so that it can be used in other C modules, use the new macro DEFUE.
4583 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4584 (Finit_image_library):
4585 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4586 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4587 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4588 Remove decls, since these functions are now static.
4589 (Funintern, Fget_internal_run_time): New decls, since these functions
4590 were already external.
4592 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4593 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4594 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4595 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4596 * keyboard.c, keymap.c, lread.c:
4597 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4598 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4599 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4600 Mark functions with DEFUE instead of DEFUN,
4601 if they are used in other modules.
4602 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4603 decls for now-static functions.
4604 * buffer.h (Fdelete_overlay): Remove decl.
4605 * callproc.c (Fgetenv_internal): Mark as internal.
4606 * composite.c (Fremove_list_of_text_properties): Remove decl.
4607 (Fcomposition_get_gstring): New forward static decl.
4608 * composite.h (Fcomposite_get_gstring): Remove decl.
4609 * dired.c (Ffile_attributes): New forward static decl.
4610 * doc.c (Fdocumntation_property): New forward static decl.
4611 * eval.c (Ffetch_bytecode): New forward static decl.
4612 (Funintern): Remove extern decl; now in .h file where it belongs.
4613 * fileio.c (Fmake_symbolic_link): New forward static decl.
4614 * image.c (Finit_image_library): New forward static decl.
4615 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4616 * intervals.h (Fprevious_property_change):
4617 (Fremove_list_of_text_properties): Remove decls.
4618 * keyboard.c (Fthis_command_keys): Remove decl.
4619 (Fcommand_execute): New forward static decl.
4620 * keymap.c (Flookup_key): New forward static decl.
4621 (Fcopy_keymap): Now static.
4622 * keymap.h (Flookup_key): Remove decl.
4623 * process.c (Fget_process): New forward static decl.
4624 (Fprocess_datagram_address): Mark as internal.
4625 * syntax.c (Fsyntax_table_p): New forward static decl.
4626 (skip_chars): Remove duplicate decl.
4627 * textprop.c (Fprevious_property_change): New forward static decl.
4628 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4630 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4631 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4633 * editfns.c (Fformat): Remove unreachable code.
4635 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4637 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4640 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4642 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4643 when at ZV. (Bug#8487)
4645 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4647 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4649 * keyboard.c (parse_tool_bar_item): Likewise.
4650 * sound.c (sound_cleanup, alsa_close): Likewise.
4651 * termcap.c (tgetent): Likewise.
4652 * xfns.c (x_default_font_parameter): Likewise.
4653 * xsettings.c (read_and_apply_settings): Likewise.
4655 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4656 (overrun_check_free): Protoize.
4658 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4660 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4661 since callers should never pass a negative size.
4662 Change the signature to match that of plain 'read' and 'write'; see
4663 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4664 * lisp.h: Update prototypes of emacs_write and emacs_read.
4666 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4668 * xdisp.c (redisplay_window): Don't try to determine the character
4669 position of the scroll margin if the window start point w->startp
4670 is outside the buffer's accessible region. (Bug#8468)
4672 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4674 Fix write-region and its subroutines for buffers > 2GB.
4675 * fileio.c (a_write, e_write): Modify declaration of arguments and
4676 local variables to support buffers larger than 2GB.
4677 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4679 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4680 argument, local variables, and return value.
4682 * lisp.h: Update prototypes of emacs_write and emacs_read.
4684 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4686 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4688 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4690 Fix more problems found by GCC 4.6.0's static checks.
4692 * xdisp.c (vmessage): Use a better test for character truncation.
4694 * charset.c (load_charset_map): <, not <=, for optimization,
4695 and to avoid potential problems with integer overflow.
4696 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4697 * casetab.c (set_identity, shuffle): Likewise.
4698 * editfns.c (Fformat): Likewise.
4699 * syntax.c (skip_chars): Likewise.
4701 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4702 This also lets GCC 4.6.0 generate slightly better loop code.
4704 * callint.c (Fcall_interactively): <, not <=, for optimization.
4705 (Fcall_interactively): Count the number of arguments produced,
4706 not the number of arguments given. This is simpler and lets GCC
4707 4.6.0 generate slightly better code.
4709 * ftfont.c: Distingish more carefully between FcChar8 and char.
4710 The previous code passed unsigned char * to a functions like
4711 strlen and xstrcasecmp that expect char *, which does not
4712 conform to the C standard.
4713 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4714 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4715 char * when the C standard requires it.
4717 * keyboard.c (read_char): Remove unused var.
4719 * eval.c: Port to Windows vsnprintf (Bug#8435).
4721 (SIZE_MAX): Define if the headers do not.
4722 (verror): Do not give up if vsnprintf returns a negative count.
4723 Instead, grow the buffer. This ports to Windows vsnprintf, which
4724 does not conform to C99. Problem reported by Eli Zaretskii.
4725 Also, simplify the allocation scheme, by avoiding the need for
4726 calling realloc, and removing the ALLOCATED variable.
4728 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4730 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4731 But keep the doprint source code for now, as we might revamp it
4732 and use it again (Bug#8435).
4733 * lisp.h (doprnt): Remove.
4734 * Makefile.in (base_obj): Remove doprnt.o.
4735 * deps.mk (doprnt.o): Remove.
4737 error: Print 32- and 64-bit integers portably (Bug#8435).
4738 Without this change, on typical 64-bit hosts error ("...%d...", N)
4739 was used to print both 32- and 64-bit integers N, which relied on
4741 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4743 * lisp.h (error, verror): Mark as printf-like functions.
4744 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4745 Report overflow in size calculations when allocating printf buffer.
4746 Do not truncate output string at its first null byte.
4747 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4748 Truncate the output at a character boundary, since vsnprintf does not
4750 * charset.c (check_iso_charset_parameter): Convert internal
4751 character to string before calling 'error', since %c now has the
4753 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4754 overflow when computing char to be passed to 'error'. Do not
4755 pass Lisp_Object to 'error'; pass the integer instead.
4756 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4757 formatted with plain %d.
4759 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4761 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4763 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4765 * xterm.c (x_catch_errors): Remove duplicate declaration.
4767 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4769 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4771 2011-04-10 Jim Meyering <meyering@redhat.com>
4773 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4774 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4775 return ssize_t not "int", and use size_t as the buffer length.
4776 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4777 * gnutls.h: Update declarations.
4778 * process.c (read_process_output): Use ssize_t, to match.
4779 (send_process): Likewise.
4781 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4783 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4785 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4787 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4788 Use unsigned char, to match FcChar8 type definition.
4790 * xterm.c (handle_one_xevent):
4791 * xmenu.c (create_and_show_popup_menu):
4792 * xselect.c (x_decline_selection_request)
4793 (x_reply_selection_request): Avoid type-punned deref of X events.
4795 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4797 Fix some uses of `int' instead of EMACS_INT.
4798 * search.c (string_match_1, fast_string_match)
4799 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4800 (scan_buffer, find_next_newline_no_quit)
4801 (find_before_next_newline, search_command, Freplace_match)
4802 (Fmatch_data): Make some `int' variables be EMACS_INT.
4804 * xdisp.c (display_count_lines): 3rd argument and return value now
4805 EMACS_INT. All callers changed.
4806 (pint2hrstr): Last argument is now EMACS_INT.
4808 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4809 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4810 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4811 (decode_coding_utf_16, decode_coding_emacs_mule)
4812 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4813 (decode_coding_ccl, decode_coding_charset)
4814 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4815 (decode_coding_iso_2022, decode_coding_emacs_mule)
4816 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4817 <char_offset, last_offset>: Declare EMACS_INT.
4818 (encode_coding_utf_8, encode_coding_utf_16)
4819 (encode_coding_emacs_mule, encode_invocation_designation)
4820 (encode_designation_at_bol, encode_coding_iso_2022)
4821 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4822 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4824 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4825 (encode_invocation_designation): Last argument P_NCHARS is now
4827 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4828 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4830 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4833 * ccl.c (Fccl_execute_on_string): Declare some variables
4836 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4838 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4840 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4842 * process.c (Fformat_network_address): Doc fix.
4844 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4846 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4848 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4850 * keyboard.c (read_char): Call Lisp function help-form-show,
4851 instead of using internal_with_output_to_temp_buffer.
4852 (Qhelp_form_show): New var.
4853 (syms_of_keyboard): Use DEFSYM macro.
4855 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4857 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4859 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4861 * process.c (Flist_processes): Remove to Lisp.
4862 (list_processes_1): Delete.
4864 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4866 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4868 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4870 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4872 Fix more problems found by GCC 4.6.0's static checks.
4874 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4876 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4878 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4880 * xdisp.c (vmessage): Mark as a printf-like function.
4882 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4884 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4886 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4887 printf-like functions.
4888 (tiff_load): Add casts to remove these marks before passing them
4889 to system-supplied API.
4891 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4893 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4894 This avoids several warnings with gcc -Wstrict-overflow.
4895 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4896 directly, rather than having caller test rule sign. This avoids
4897 some unnecessary tests.
4898 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4899 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4900 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4902 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4903 (xfont_open): Avoid unnecessary tests.
4905 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4907 * composite.h, composite.c (composition_gstring_put_cache):
4908 Use EMACS_INT, not int, for length.
4910 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4911 breaking out part of COMPOSITION_DECODE_RULE.
4912 (COMPOSITION_DECODE_RULE): Use it.
4913 * composite.c (get_composition_id): Remove unused local vars,
4914 by using the new macro.
4916 * textprop.c (set_text_properties_1): Change while to do-while,
4917 since the condition is always true at first.
4919 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4920 (interval_deletion_adjustment): Return unsigned value.
4923 * process.c (list_processes_1, create_pty, read_process_output):
4924 (exec_sentinel): Remove vars that were set but not used.
4925 (create_pty): Remove unnecessary "volatile"s.
4926 (Fnetwork_interface_info): Avoid possibility of int overflow.
4927 (read_process_output): Do adaptive read buffering even if carryover.
4928 (read_process_output): Simplify nbytes computation if buffered.
4930 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4932 * syntax.c (scan_words): Remove var that was set but not used.
4933 (update_syntax_table): Use unsigned instead of int.
4935 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4936 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4937 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4939 * print.c (print_error_message): Avoid int overflow.
4941 * font.c (font_list_entities): Redo for clarity,
4942 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4944 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4945 (font_score): Avoid potential overflow in diff calculation.
4947 * fns.c (substring_both): Remove var that is set but not used.
4948 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4950 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4952 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4953 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4954 can always succeed if overflow has undefined behavior.
4956 * search.c (boyer_moore, wordify): Remove vars set but not used.
4957 (wordify): Omit three unnecessary tests.
4959 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4960 All callers changed. This avoids the need for an unused var.
4962 * casefiddle.c (casify_region): Remove var that is set but not used.
4964 * dired.c (file_name_completion): Remove var that is set but not used.
4966 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4968 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4969 (Finsert_file_contents): Remove unnecessary code checking fd.
4971 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4972 Check for integer overflow on size calculations.
4974 * buffer.c (Fprevious_overlay_change): Remove var that is set
4977 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4978 Remove vars that are set but not used.
4979 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4980 (timer_check_2): Mark vars as initialized.
4982 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4984 * image.c (lookup_image): Remove var that is set but not used.
4985 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4987 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4988 that are set but not used.
4990 * xfns.c (make_invisible_cursor): Don't return garbage
4991 if XCreateBitmapFromData fails (Bug#8410).
4993 * xselect.c (x_get_local_selection, x_handle_property_notify):
4994 Remove vars that are set but not used.
4996 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4997 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4999 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5000 Remove var that is set but not used.
5001 (scroll_bar_windows_size): Now size_t, not int.
5002 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5005 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5006 (map_tty_color) [!defined MSDOS]: Likewise.
5008 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5010 * coding.c: Remove vars that are set but not used.
5011 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5012 All callers changed.
5013 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5014 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5015 (decode_coding_charset): Remove vars that are set but not used.
5017 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5018 that is set but not used.
5020 * print.c (print_object): Remove var that is set but not used.
5022 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5023 The gnulib version avoids calling malloc in the usual case,
5024 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5025 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5026 * filelock.c (current_lock_owner): Likewise.
5027 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5028 * sysdep.c: Include allocator.h, careadlinkat.h.
5029 (emacs_no_realloc_allocator): New static constant.
5030 (emacs_readlink): New function.
5031 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5032 ../lib/careadlinkat.h.
5034 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5036 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5037 first non-nil return value).
5039 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5041 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5042 if not defined (Bug#8403).
5044 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5046 * xdisp.c (display_count_lines): Remove parameter `start',
5047 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5048 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5049 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5050 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5051 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5052 and thereabouts. All callers changed.
5053 (get_per_char_metric): Remove parameter `f', unused since
5054 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5056 2011-04-02 Jim Meyering <meyering@redhat.com>
5058 do not dereference NULL upon failed strdup
5059 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5060 (ns_get_family): Likewise.
5062 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5064 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5066 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5068 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5071 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5073 Add lexical binding.
5075 * window.c (Ftemp_output_buffer_show): New fun.
5076 (Fsave_window_excursion):
5077 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5079 * lread.c (lisp_file_lexically_bound_p): New function.
5080 (Fload): Bind Qlexical_binding.
5081 (readevalloop): Remove `evalfun' arg.
5082 Bind Qinternal_interpreter_environment.
5083 (Feval_buffer): Bind Qlexical_binding.
5084 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5086 (syms_of_lread): Declare `lexical-binding'.
5088 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5090 * keyboard.c (eval_dyn): New fun.
5091 (menu_item_eval_property): Use it.
5093 * image.c (parse_image_spec): Use Ffunctionp.
5095 * fns.c (concat, mapcar1): Accept byte-code-functions.
5097 * eval.c (Fsetq): Handle lexical vars.
5098 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5099 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5100 (FletX, Flet): Obey lexical binding.
5101 (Fcommandp): Handle closures.
5102 (Feval): New `lexical' arg.
5103 (eval_sub): New function extracted from Feval. Use it almost
5104 everywhere where Feval was used. Look up vars in lexical env.
5106 (Ffunctionp): Move from subr.el.
5107 (Ffuncall): Handle closures.
5108 (apply_lambda): Remove `eval_flags'.
5109 (funcall_lambda): Handle closures and new byte-code-functions.
5110 (Fspecial_variable_p): New function.
5111 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5112 but without exporting it to Lisp.
5114 * doc.c (Fdocumentation, store_function_docstring):
5115 * data.c (Finteractive_form): Handle closures.
5117 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5120 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5122 (exec_byte_code): New function extracted from Fbyte_code to handle new
5123 calling convention for byte-code-functions. Add new byte-codes.
5125 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5127 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5129 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5131 * xdisp.c (redisplay_internal): Fix prototype.
5133 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5135 * xdisp.c (SCROLL_LIMIT): New macro.
5136 (try_scrolling): Use it when setting scroll_limit.
5137 Limit scrolling to 100 screen lines.
5138 (redisplay_window): Even when falling back on "recentering",
5139 position point in the window according to scroll-conservatively,
5140 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5142 (try_scrolling): When point is above the window, allow searching
5143 as far as scroll_max, or one screenful, to compute vertical
5144 distance from PT to the scroll margin position. This prevents
5145 try_scrolling from unnecessarily failing when
5146 scroll-conservatively is set to a value slightly larger than the
5147 window height. Clean up the case of PT below the margin at bottom
5148 of window: scroll_max can no longer be INT_MAX. When aggressive
5149 scrolling is in use, don't let point enter the opposite scroll
5150 margin as result of the scroll.
5151 (syms_of_xdisp) <scroll-conservatively>: Document the
5152 threshold of 100 lines for never-recentering scrolling.
5154 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5156 * dispextern.h (move_it_by_lines):
5157 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5158 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5159 (message_log_check_duplicate): Remove parameters `prev_bol' and
5160 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5161 (redisplay_internal): Remove parameter `preserve_echo_area',
5162 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5164 * indent.c (Fvertical_motion):
5165 * window.c (window_scroll_pixel_based, Frecenter):
5166 Don't pass `need_y_p' to `move_it_by_lines'.
5168 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5170 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5171 steal a few bits to be more compact.
5172 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5173 Remove unneeded casts.
5175 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5177 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5179 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5180 binding" message (bug#7967).
5182 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5184 Fix more problems found by GCC 4.6.0's static checks.
5186 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5187 Remove unused local var.
5189 * editfns.c (Fmessage_box): Remove unused local var.
5191 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5192 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5193 Omit unused local vars.
5194 * window.c (shrink_windows): Omit unused local var.
5195 * menu.c (digest_single_submenu): Omit unused local var.
5196 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5197 Omit unused local var.
5199 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5200 Don't assume string length fits in int.
5201 (keyremap_step, read_key_sequence): Use size_t for sizes.
5202 (read_key_sequence): Don't check last_real_key_start redundantly.
5204 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5205 instead of alloca (Bug#8344).
5207 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5208 (Fbacktrace_frame): Don't assume nframes fits in int.
5210 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5212 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5215 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5217 * cm.c (calccost): Turn while-do into do-while, for clarity.
5219 * keyboard.c (syms_of_keyboard): Use the same style as later
5220 in this function when indexing through an array. This also
5221 works around GCC bug 48267.
5223 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5225 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5227 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5228 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5230 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5231 This avoids undefined behavior on integer overflow, and is a bit
5232 more convenient anyway since it is compared to a size_t variable.
5234 Variadic C functions now count arguments with size_t, not int.
5235 This avoids an unnecessary limitation on 64-bit machines, which
5236 caused (substring ...) to crash on large vectors (Bug#8344).
5237 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5238 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5239 All variadic functions and their callers changed accordingly.
5240 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5241 * data.c (arith_driver, float_arith_driver): Likewise.
5242 * editfns.c (general_insert_function): Likewise.
5243 * eval.c (struct backtrace.nargs, interactive_p)
5244 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5245 (funcall_lambda, mark_backtrace): Likewise.
5246 * fns.c (concat): Likewise.
5247 * frame.c (x_set_frame_parameters): Likewise.
5248 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5249 0 if not found, not -1. All callers changed.
5251 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5252 (stack_copy_size): Now size_t, not int.
5253 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5255 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5257 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5258 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5259 All callers changed.
5261 * lisp.h (multibyte_char_to_unibyte):
5262 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5263 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5264 * character.h (CHAR_TO_BYTE8):
5265 * cmds.c (internal_self_insert):
5266 * editfns.c (general_insert_function):
5267 * keymap.c (push_key_description):
5268 * search.c (Freplace_match):
5269 * xdisp.c (message_dolog, set_message_1): All callers changed.
5271 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5273 * keyboard.c (safe_run_hook_funcall): New function.
5274 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5275 don't set the hook to nil, but remove the offending function instead.
5276 (Qcommand_hook_internal): Remove, unused.
5277 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5278 Vcommand_hook_internal.
5280 * eval.c (enum run_hooks_condition): Remove.
5281 (funcall_nil, funcall_not): New functions.
5282 (run_hook_with_args): Call each function through a `funcall' argument.
5283 Remove `cond' argument, now redundant.
5284 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5285 (Frun_hook_with_args_until_failure): Adjust accordingly.
5286 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5288 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5290 * dispextern.h (string_buffer_position): Remove declaration.
5292 * print.c (strout): Remove parameter `multibyte', unused since
5293 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5295 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5296 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5297 All callers changed.
5299 * w32.c (_wsa_errlist): Use braces for struct initializers.
5301 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5302 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5303 All callers changed.
5304 (string_buffer_position): Likewise. Also, make static (it's never
5305 used outside xdisp.c).
5306 (cursor_row_p): Remove parameter `w', unused since
5307 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5308 (decode_mode_spec): Remove parameter `precision', introduced during
5309 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5310 All callers changed.
5312 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5314 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5316 2011-03-27 Anders Lindgren <andlind@gmail.com>
5318 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5319 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5320 (ns_update_auto_hide_menu_bar): New functions.
5321 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5322 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5323 ns_constrain_all_frames.
5324 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5325 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5327 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5329 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5331 2011-03-27 Glenn Morris <rgm@gnu.org>
5333 * syssignal.h: Replace RETSIGTYPE with void.
5334 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5335 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5336 Replace SIGTYPE with void everywhere.
5337 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5338 * s/template.h (SIGTYPE): Remove commented out definition.
5340 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5342 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5343 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5345 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5347 * w32.c (read_unc_volume): Use parameter `henum', instead of
5348 global variable `wget_enum_handle'.
5350 * keymap.c (describe_vector): Remove parameters `indices' and
5351 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5352 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5354 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5356 * keyboard.c (timer_check): Remove parameter `do_it_now',
5357 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5358 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5359 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5361 * keyboard.c (read_char):
5362 * w32menu.c (w32_menu_display_help):
5363 * xmenu.c (show_help_event, menu_help_callback):
5364 Adjust calls to `show_help_echo'.
5366 * gtkutil.c (xg_maybe_add_timer):
5367 * keyboard.c (readable_events):
5368 * process.c (wait_reading_process_output):
5369 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5371 * insdel.c (adjust_markers_gap_motion):
5372 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5373 (gap_left, gap_right): Don't call it.
5375 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5377 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5378 incurred during fontification.
5380 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5382 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5383 (DEFVAR_PER_BUFFER): Don't pass it.
5385 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5386 (scrolling_window): Don't pass it.
5388 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5390 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5392 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5394 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5395 of variables specific to SELinux and computation of `encoded_absname'.
5397 * image.c (XPutPixel): Remove unused variable `height'.
5399 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5401 * unexw32.c (get_section_info): Remove unused variable `section'.
5403 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5404 (system_process_attributes): Remove unused variable `sess'.
5405 (sys_read): Remove unused variable `err'.
5407 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5408 (w32_wnd_proc): Remove unused variable `isdead'.
5409 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5410 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5411 (x_create_tip_frame): Remove unused variable `tem'.
5413 * w32inevt.c (w32_console_read_socket):
5414 Remove unused variable `no_events'.
5416 * w32term.c (x_draw_composite_glyph_string_foreground):
5417 Remove unused variable `width'.
5419 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5421 * w32term.c (x_set_glyph_string_clipping):
5422 Don't pass uninitialized region to CombineRgn.
5424 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5426 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5427 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5428 (Fx_close_connection): Remove unused variable `i'.
5430 * w32font.c (w32font_draw): Return number of glyphs.
5431 (w32font_open_internal): Remove unused variable `i'.
5432 (w32font_driver): Add missing initializer.
5434 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5435 (fill_in_menu): Remove unused variable `items_added'.
5437 * w32term.c (last_mouse_press_frame): Remove static global variable.
5438 (w32_clip_to_row): Remove unused variable `f'.
5439 (x_delete_terminal): Remove unused variable `i'.
5441 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5442 (NOTHING): Remove unused static global variable.
5443 (uniscribe_check_otf): Remove unused variable `table'.
5444 (uniscribe_font_driver): Add missing initializers.
5446 2011-03-23 Julien Danjou <julien@danjou.info>
5448 * term.c (Fsuspend_tty, Fresume_tty):
5449 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5450 * window.c (temp_output_buffer_show):
5451 * insdel.c (signal_before_change):
5452 * frame.c (Fhandle_switch_frame):
5453 * fileio.c (Fdo_auto_save):
5454 * emacs.c (Fkill_emacs):
5455 * editfns.c (save_excursion_restore):
5456 * cmds.c (internal_self_insert):
5457 * callint.c (Fcall_interactively):
5458 * buffer.c (Fkill_all_local_variables):
5459 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5461 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5462 unconditionnaly since it does the check itself.
5464 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5466 Fix more problems found by GCC 4.5.2's static checks.
5468 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5469 the first time through the loop, since we know p0 < p1 then.
5470 This also avoids a gcc -Wstrict-overflow warning.
5472 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5473 leading to a memory leak, possible in functions like
5474 load_charset_map_from_file that can allocate an unbounded number
5475 of objects (Bug#8318).
5477 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5478 that could (at least in theory) be that large.
5480 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5481 This is less likely to overflow, and avoids undefined behavior if
5482 overflow does occur. All callers changed. Use strtoul to scan
5483 for the unsigned long integer.
5484 (pint2hrstr): Simplify and tune code slightly.
5485 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5487 * scroll.c (do_scrolling): Work around GCC bug 48228.
5488 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5490 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5491 This also avoids a warning with gcc -Wstrict-overflow.
5492 (validate_x_resource_name): Simplify count usage.
5493 This also avoids a warning with gcc -Wstrict-overflow.
5495 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5498 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5500 * process.c (Fmake_network_process): Use socklen_t, not int,
5501 where POSIX says socklen_t is required in portable programs.
5502 This fixes a porting bug on hosts like 64-bit HP-UX, where
5503 socklen_t is wider than int (Bug#8277).
5504 (Fmake_network_process, server_accept_connection):
5505 (wait_reading_process_output, read_process_output):
5508 * process.c: Rename or move locals to avoid shadowing.
5509 (list_processes_1, Fmake_network_process):
5510 (read_process_output_error_handler, exec_sentinel_error_handler):
5511 Rename or move locals.
5512 (Fmake_network_process): Define label "retry_connect" only if needed.
5513 (Fnetwork_interface_info): Fix pointer signedness.
5514 (process_send_signal): Add cast to avoid pointer signedness problem.
5515 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5516 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5518 Make tparam.h and terminfo.c consistent.
5519 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5520 Include tparam.h instead, since it declares them.
5521 * cm.h (PC): Remove extern decl; tparam.h now does this.
5522 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5523 * terminfo.c: Include tparam.h, to check interfaces.
5524 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5525 (tparam): Adjust signature to match interface in tparam.h;
5526 this removes some undefined behavior. Check that outstring and len
5527 are zero, which they always are with Emacs.
5528 * tparam.h (PC, BC, UP): New extern decls.
5530 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5531 (xftfont_open): Rename locals to avoid shadowing.
5533 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5534 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5535 (OTF_TAG_SYM): Omit macro if not needed.
5536 (ftfont_list): Remove unused local.
5537 (get_adstyle_property, ftfont_pattern_entity):
5538 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5539 Rename locals to avoid shadowing.
5541 * xfont.c (xfont_list_family): Mark var as initialized.
5543 * xml.c (make_dom): Now static.
5545 * composite.c (composition_compute_stop_pos): Rename local to
5547 (composition_reseat_it): Remove unused locals.
5548 (find_automatic_composition, composition_adjust_point): Likewise.
5549 (composition_update_it): Mark var as initialized.
5550 (find_automatic_composition): Mark vars as initialized,
5551 with a FIXME (Bug#8290).
5553 character.h: Rename locals to avoid shadowing.
5554 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5555 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5556 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5557 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5560 * textprop.c (property_change_between_p): Remove; unused.
5562 * intervals.c (interval_start_pos): Now static.
5564 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5566 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5567 Rename locals to avoid shadowing.
5569 * sound.c (wav_play, au_play, Fplay_sound_internal):
5570 Fix pointer signedness.
5571 (alsa_choose_format): Remove unused local var.
5572 (wav_play): Initialize a variable to 0, to prevent undefined
5573 behavior (Bug#8278).
5575 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5577 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5579 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5580 clobbering (Bug#8298).
5581 * sysdep.c (sys_subshell): Likewise.
5582 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5584 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5585 This should get cleaned up, so that child_setup has the
5586 same signature on all platforms.
5588 * callproc.c (call_process_cleanup): Now static.
5589 (relocate_fd): Rename locals to avoid shadowing.
5591 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5593 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5594 not to be necessary, and produces flickering.
5596 2011-03-20 Glenn Morris <rgm@gnu.org>
5598 * config.in: Remove file.
5600 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5602 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5603 are now in src/globals.h.
5604 (syms_of_minibuf): Remove spurious & from previous change.
5606 2011-03-20 Leo <sdl.web@gmail.com>
5608 * minibuf.c (completing-read-function): New variable.
5609 (completing-read-default): Rename from completing-read.
5610 (completing-read): Call completing-read-function.
5612 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5614 * xfaces.c (Fx_load_color_file):
5615 Read color file from absolute filename (bug#8250).
5617 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5619 * makefile.w32-in: Update dependencies.
5621 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5623 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5625 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5627 Fix more problems found by GCC 4.5.2's static checks.
5629 * process.c (make_serial_process_unwind, send_process_trap):
5630 (sigchld_handler): Now static.
5632 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5633 That way, the code declares only the vars that it needs.
5634 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5635 * s/cygwin.h (PTY_ITERATION): Likewise.
5636 * s/darwin.h (PTY_ITERATION): Likewise.
5637 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5639 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5640 * process.c (allocate_pty): Don't declare stb unless it's needed.
5642 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5643 (CONSTANTLIM): Remove; unused.
5644 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5645 Define only if needed.
5647 * unexelf.c (unexec): Name an expression,
5648 to avoid gcc -Wbad-function-cast warning.
5649 Use a different way to cause a compilation error if anyone uses
5650 n rather than nn, a way that does not involve shadowing.
5651 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5653 * deps.mk (unexalpha.o): Remove; unused.
5655 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5656 * unexec.h: New file.
5657 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5658 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5660 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5661 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5662 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5663 Change as necessary to match prototype in unexec.h.
5665 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5667 (back_comment, skip_chars): Mark vars as initialized.
5669 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5670 Rename locals to avoid shadowing.
5672 * lread.c (read1): Rewrite so as not to use empty "else".
5673 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5675 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5677 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5678 warning when compiling print.c.
5680 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5681 instead of using an uninitialized var.
5682 (font_sort_entities): Mark var as initialized.
5684 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5686 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5687 pointers to constants.
5688 (font_parse_fcname): Remove unused vars.
5689 (font_delete_unmatched): Now static.
5690 (font_get_spec): Remove; unused.
5691 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5692 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5693 Rename or move locals to avoid shadowing.
5695 * fns.c (require_nesting_list, require_unwind): Now static.
5696 (Ffillarray): Rename locals to avoid shadowing.
5698 * floatfns.c (domain_error2): Define only if needed.
5699 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5701 * alloc.c (mark_backtrace): Move decl from here ...
5702 * lisp.h: ... to here, so that it can be checked.
5704 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5705 (Fdefvar): Rewrite so as not to use empty "else".
5706 (lisp_indirect_variable): Name an expression,
5707 to avoid gcc -Wbad-function-cast warning.
5708 (Fdefvar): Rename locals to avoid shadowing.
5710 * callint.c (quotify_arg, quotify_args): Now static.
5711 (Fcall_interactively): Rename locals to avoid shadowing.
5712 Use const pointer when appropriate.
5714 * lisp.h (get_system_name, get_operating_system_release):
5715 Move decls here, to check interfaces.
5716 * process.c (get_operating_system_release): Move decl to lisp.h.
5717 * xrdb.c (get_system_name): Likewise.
5718 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5719 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5720 some of which prompt warnings from gcc -Wbad-function-cast.
5721 (Fformat_time_string, Fencode_time, Finsert_char):
5722 (Ftranslate_region_internal, Fformat):
5723 Rename or remove local vars to avoid shadowing.
5724 (Ftranslate_region_internal): Mark var as initialized.
5726 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5729 * lisp.h (eassert): Check that the argument compiles, even if
5730 ENABLE_CHECKING is not defined.
5732 * data.c (Findirect_variable): Name an expression, to avoid
5733 gcc -Wbad-function-cast warning.
5734 (default_value, arithcompare, arith_driver, arith_error): Now static.
5735 (store_symval_forwarding): Rename local to avoid shadowing.
5736 (Fmake_variable_buffer_local, Fmake_local_variable):
5737 Mark variables as initialized.
5738 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5740 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5741 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5742 Rename locals to avoid shadowing.
5743 (mark_stack): Move local variables into the #ifdef region where
5745 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5746 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5748 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5749 (GC_STRING_CHARS): Remove; not used.
5750 (Fmemory_limit): Cast sbrk's returned value to char *.
5752 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5753 avoids undefined behavior in theory.
5755 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5757 Use functions, not macros, for up- and down-casing (Bug#8254).
5758 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5759 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5760 to use the following functions instead of these macros.
5761 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5762 EMACS_INT, since callers assume the returned value fits in int.
5763 (upcase1): Likewise, for UPCASE_TABLE.
5764 (uppercasep, lowercasep, upcase): New static inline functions.
5765 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5766 the race-condition problem in the old DOWNCASE.
5768 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5769 Rename locals to avoid shadowing.
5770 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5771 (regex_compile, re_search_2, re_match_2_internal):
5772 Remove unused local vars.
5773 (FREE_VAR): Rewrite so as not to use empty "else",
5774 which gcc can warn about.
5775 (regex_compile, re_match_2_internal): Mark locals as initialized.
5776 (RETALLOC_IF): Define only if needed.
5777 (WORDCHAR_P): Likewise. This one is never needed, but is used
5778 only in a comment talking about a compiler bug, so put inside
5779 the #if 0 of that comment.
5780 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5781 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5784 * search.c (boyer_moore): Rename locals to avoid shadowing.
5785 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5786 (PREV_CHAR_BOUNDARY): Likewise.
5788 * search.c (simple_search): Remove unused var.
5790 * dired.c (compile_pattern): Move decl from here ...
5791 * lisp.h: ... to here, so that it can be checked.
5792 (struct re_registers): New forward decl.
5794 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5796 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5798 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5799 Rename locals to avoid shadowing.
5800 (Fvertical_motion): Mark locals as initialized.
5802 * casefiddle.c (casify_object, casify_region): Now static.
5803 (casify_region): Mark local as initialized.
5805 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5807 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5808 New macros, so that the caller can use some names other than
5809 gcpro1, gcpro2, etc.
5810 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5812 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5813 argument, for consistency with GCPRO2_VAR, etc: it is now the
5814 prefix of the variable, not the variable itself. All uses
5816 * dired.c (directory_files_internal, file_name_completion):
5817 Rename locals to avoid shadowing.
5819 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5820 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5821 dired.c's scmp function, had undefined behavior.
5822 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5823 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5824 * buffer.h: ... to here, because these macros use current_buffer,
5825 and the new implementation with inline functions needs to have
5826 current_buffer in scope now, rather than later when the macros
5828 (downcase, upcase1): New static inline functions.
5829 (DOWNCASE, UPCASE1): Reimplement using these functions.
5830 This avoids undefined behavior in expressions like
5831 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5832 from race conditions in accessing the global variables
5833 case_temp1 and case_temp2.
5834 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5835 * lisp.h (case_temp1, case_temp2): Remove their decls.
5836 * character.h (ASCII_CHAR_P): Move from here ...
5837 * lisp.h: ... to here, so that the inline functions mentioned
5840 * dired.c (directory_files_internal_unwind): Now static.
5842 * fileio.c (file_name_as_directory, directory_file_name):
5843 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5845 (file_name_as_directory): Use const pointers when appropriate.
5846 (Fexpand_file_name): Likewise. In particular, newdir might
5847 point at constant storage, so make it a const pointer.
5848 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5849 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5851 (Fset_file_times, Finsert_file_contents, auto_save_error):
5852 Rename locals to avoid shadowing.
5854 * minibuf.c (choose_minibuf_frame_1): Now static.
5855 (Ftry_completion, Fall_completions): Rename or remove locals
5858 * marker.c (bytepos_to_charpos): Remove; unused.
5860 * lisp.h (verify_bytepos, count_markers): New decls,
5861 so that gcc does not warn that these functions aren't declared.
5863 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5864 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5865 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5866 (copy_text): Remove unused local var.
5868 * filelock.c (within_one_second): Now static.
5869 (lock_file_1): Rename local to avoid shadowing.
5871 * buffer.c (fix_overlays_before): Mark locals as initialized.
5872 (fix_start_end_in_overlays): Likewise. This function should be
5873 simplified by using pointers-to-pointers, but that's a different
5875 (switch_to_buffer_1): Now static.
5876 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5877 (report_overlay_modification): Rename locals to avoid shadowing.
5879 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5880 Fix pointer signedness issue.
5881 (sys_subshell): Mark local as volatile if checking for lint,
5882 to suppress a gcc -Wclobbered warning that does not seem to be right.
5883 (MAXPATHLEN): Define only if needed.
5885 * process.c (serial_open, serial_configure): Move decls from here ...
5886 * systty.h: ... to here, so that they can be checked.
5888 * fns.c (get_random, seed_random): Move extern decls from here ...
5889 * lisp.h: ... to here, so that they can be checked.
5891 * sysdep.c (reset_io): Now static.
5892 (wait_for_termination_signal): Remove; unused.
5894 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5895 (copy_keymap_item, append_key, push_text_char_description):
5897 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5898 (DENSE_TABLE_SIZE): Remove; unused.
5899 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5900 (describe_map_tree):
5901 Rename locals to avoid shadowing.
5903 * keyboard.c: Declare functions static if they are not used elsewhere.
5904 (echo_char, echo_dash, cmd_error, top_level_2):
5905 (poll_for_input, handle_async_input): Now static.
5906 (read_char, kbd_buffer_get_event, make_lispy_position):
5907 (make_lispy_event, make_lispy_movement, apply_modifiers):
5908 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5909 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5910 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5911 (read_key_sequence, read_char): Mark locals as initialized.
5912 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5914 * keyboard.h (make_ctrl_char): New decl.
5915 (mark_kboards): Move decl here ...
5916 * alloc.c (mark_kboards): ... from here.
5918 * lisp.h (force_auto_save_soon): New decl.
5920 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5921 (DEFINE_DUMMY_FUNCTION): New macro.
5922 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5924 (main): Add casts to avoid warnings
5925 if GCC considers string literals to be constants.
5927 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5929 * dbusbind.c: Pointer signedness fixes.
5930 (xd_signature, xd_append_arg, xd_initialize):
5931 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5932 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5933 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5934 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5936 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5937 if GCC considers string literals to be constants.
5938 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5940 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5942 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5943 (print_preprocess, print_object): New macro to fix last change.
5945 * print.c (print_preprocess): Don't forget font objects.
5947 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5949 * emacs.c (USAGE3): Doc fixes.
5951 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5953 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5956 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5958 * lisp.h (VWindow_system, Qfile_name_history):
5959 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5960 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5961 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5963 * w32select.c: Don't #include "keyboard.h".
5964 (run_protected): Add extern declaration for waiting_for_input.
5966 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5967 * w32console.c (detect_input_pending, read_input_pending)
5968 (encode_terminal_code):
5969 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5970 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5971 (w32_system_caret_y, Qfile_name_history):
5972 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5973 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5974 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5975 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5976 * w32proc.c (Qlocal, report_file_error):
5977 * w32term.c (Vwindow_system, updating_frame):
5978 * w32uniscribe.c (initialized, uniscribe_font_driver):
5979 Remove unneeded extern declarations.
5981 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5983 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5985 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5987 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5988 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5989 These macros can no longer be used for assignment.
5991 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5992 Assign struct members directly, instead of using BUF_BEGV etc.
5993 (record_buffer_markers, fetch_buffer_markers): New functions for
5994 recording and fetching special buffer markers.
5995 (set_buffer_internal_1, set_buffer_temp): Use them.
5997 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5999 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6001 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6002 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6004 * xdisp.c (hscroll_window_tree):
6005 (reconsider_clip_changes): Use PT instead of BUF_PT.
6007 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6009 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6010 $(EMACS_ROOT)/lib/intprops.h.
6012 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6014 Fix more problems found by GCC 4.5.2's static checks.
6016 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6017 to unsigned char * to avoid compiler diagnostic.
6018 (xg_free_frame_widgets): Make it clear that a local variable is
6019 needed only if USE_GTK_TOOLTIP.
6020 (gdk_window_get_screen): Make it clear that this macro is needed
6021 only if USE_GTK_TOOLTIP.
6022 (int_gtk_range_get_value): New function, which avoids a diagnostic
6023 from gcc -Wbad-function-cast.
6024 (xg_set_toolkit_scroll_bar_thumb): Use it.
6025 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6026 diagnostic from gcc -Wbad-function-cast.
6027 (get_utf8_string, xg_get_file_with_chooser):
6028 Rename locals to avoid shadowing.
6029 (create_dialog): Move locals to avoid shadowing.
6031 * xgselect.c (xg_select): Remove unused var.
6033 * image.c (four_corners_best): Mark locals as initialized.
6034 (gif_load): Initialize transparent_p to zero (Bug#8238).
6035 Mark another local as initialized.
6036 (my_png_error, my_error_exit): Mark with NO_RETURN.
6038 * image.c (clear_image_cache): Now static.
6039 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6040 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6041 (x_edge_detection): Remove unnecessary cast that
6042 gcc -Wbad-function-cast diagnoses.
6043 (gif_load): Fix pointer signedness.
6044 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6045 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6047 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6049 Improve quality of tests for time stamp overflow.
6050 For example, without this patch (encode-time 0 0 0 1 1
6051 1152921504606846976) returns the obviously-bogus value (-948597
6052 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6053 reports time overflow. See
6054 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6055 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6056 * editfns.c: Include limits.h and intprops.h.
6057 (TIME_T_MIN, TIME_T_MAX): New macros.
6058 (time_overflow): Move earlier, to before first use.
6059 (hi_time, lo_time): New functions, for an accurate test for
6061 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6062 (Fget_internal_run_time): Don't assume time_t fits in int.
6063 (make_time): Use list2 instead of Fcons twice.
6064 (Fdecode_time): More accurate test for out-of-range times.
6065 (check_tm_member): New function.
6066 (Fencode_time): Use it, to test for out-of-range times.
6067 (lisp_time_argument): Don't rely on undefined left-shift and
6068 right-shift behavior when checking for time stamp overflow.
6070 * editfns.c (time_overflow): New function, refactoring common code.
6071 (Fformat_time_string, Fdecode_time, Fencode_time):
6072 (Fcurrent_time_string): Use it.
6074 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6075 * dired.c (make_time): Move to ...
6076 * editfns.c (make_time): ... here.
6077 * systime.h: Note the move.
6079 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6081 * fringe.c (update_window_fringes): Remove unused variables.
6083 * unexmacosx.c (copy_data_segment): Also copy __got section.
6086 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6088 * termcap.c [MSDOS]: Include "msdos.h".
6089 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6090 Constify `char *' arguments and their references according to
6091 prototypes in tparam.h.
6093 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6095 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6096 Adapt all references accordingly.
6098 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6100 2011-03-11 Tom Tromey <tromey@redhat.com>
6102 * buffer.c (syms_of_buffer): Remove obsolete comment.
6104 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6106 * termhooks.h (encode_terminal_code): Declare prototype.
6108 * msdos.c (encode_terminal_code): Don't declare prototype.
6110 * term.c (encode_terminal_code): Now external again, used by
6111 w32console.c and msdos.c.
6113 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6114 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6116 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6118 Fix some minor problems found by GCC 4.5.2's static checks.
6120 * fringe.c (update_window_fringes): Mark locals as initialized
6122 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6124 * alloc.c (mark_fringe_data): Move decl from here ...
6125 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6126 to check its interface.
6127 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6129 * fontset.c (free_realized_fontset): Now static.
6130 (Fset_fontset_font): Rename local to avoid shadowing.
6131 (fontset_font): Mark local as initialized.
6132 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6134 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6136 * xselect.c (x_disown_buffer_selections): Remove; not used.
6137 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6138 (x_own_selection, Fx_disown_selection_internal): Rename locals
6140 (x_handle_dnd_message): Remove local to avoid shadowing.
6142 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6143 so that the caller can use some name other than gcpro1.
6144 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6145 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6146 (Fx_backspace_delete_keys_p):
6147 Use them to avoid shadowing, and rename vars to avoid shadowing.
6148 (x_decode_color, x_set_name, x_window): Now static.
6149 (Fx_create_frame): Add braces to silence GCC warning.
6150 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6151 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6152 Remove unused locals.
6153 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6154 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6155 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6158 * xterm.h (x_mouse_leave): New decl.
6160 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6161 Remove unused functions.
6162 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6163 (x_calc_absolute_position): Now static.
6164 (XTread_socket): Don't define label "out" unless it's used.
6165 Don't declare local "event" unless it's used.
6166 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6167 unless they are used.
6168 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6169 (x_fatal_error_signal): Remove; not used.
6170 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6171 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6172 (x_error_catcher, x_connection_closed, x_error_handler):
6173 (x_error_quitter, xembed_send_message, x_iconify_frame):
6174 (my_log_handler): Rename locals to avoid shadowing.
6175 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6176 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6178 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6179 Rename or move locals to avoid shadowing.
6180 (tty_defined_color, merge_face_heights): Now static.
6181 (free_realized_faces_for_fontset): Remove; not used.
6182 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6183 does not deduce is never used uninitialized.
6184 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6185 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6187 * terminal.c (store_terminal_param): Now static.
6189 * xmenu.c (menu_highlight_callback): Now static.
6190 (set_frame_menubar): Remove unused local.
6191 (xmenu_show): Rename parameter to avoid shadowing.
6192 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6193 since they might point to immutable storage.
6194 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6195 since it's unused otherwise.
6197 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6198 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6199 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6200 avoids a gcc -Wuninitialized diagnostic.
6201 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6202 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6203 does not deduce are never used uninitialized.
6205 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6207 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6208 * window.c (window_loop, size_window):
6209 (run_window_configuration_change_hook, enlarge_window): Likewise.
6211 * window.c (display_buffer): Now static.
6212 (size_window): Mark variables that gcc -Wuninitialized
6213 does not deduce are never used uninitialized.
6214 * window.h (check_all_windows): New decl, to forestall
6215 gcc -Wmissing-prototypes diagnostic.
6216 * dispextern.h (bidi_dump_cached_states): Likewise.
6218 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6220 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6222 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6223 and to avoid gcc -Wuninitialized warning.
6224 (load_charset_map): Mark variables that gcc -Wuninitialized
6225 does not deduce are never used uninitialized.
6226 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6228 * coding.c (coding_set_source, coding_set_destination):
6229 Use "else { /* comment */ }" rather than "else /* comment */;"
6230 for clarity, and to avoid gcc -Wempty-body warning.
6231 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6232 a block, when the outer 'i' will do.
6233 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6234 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6235 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6236 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6237 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6238 Rename locals to avoid shadowing.
6239 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6240 * coding.c (emacs_mule_char, encode_invocation_designation):
6241 Now static, since they're not used elsewhere.
6242 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6243 (decode_coding_object, encode_coding_object, detect_coding_system):
6244 (decode_coding_emacs_mule): Mark variables that gcc
6245 -Wuninitialized does not deduce are never used uninitialized.
6246 (detect_coding_iso_2022): Initialize a local variable that might
6247 be used uninitialized. Leave a FIXME because it's not clear that
6248 this initialization is needed. (Bug#8211)
6249 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6250 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6251 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6252 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6253 Remove unused macros.
6255 * category.c (hash_get_category_set): Remove unused local var.
6256 (copy_category_table): Now static, since it's not used elsewhere.
6257 * character.c (string_count_byte8): Likewise.
6259 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6260 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6262 * chartab.c (copy_sub_char_table): Now static, since it's not used
6264 (sub_char_table_ref_and_range, char_table_ref_and_range):
6265 Rename locals to avoid shadowing.
6266 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6268 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6269 (BIDI_BOB): Remove unused macro.
6271 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6272 deduce are never used uninitialized.
6273 * term.c (encode_terminal_code): Likewise.
6275 * term.c (encode_terminal_code): Now static. Remove unused local.
6277 * tparam.h: New file.
6278 * term.c, tparam.h: Include it.
6279 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6280 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6281 Move these decls to tparam.h, and make them agree with what
6282 is actually in tparam.c. The previous trick of using incompatible
6283 decls in different modules does not conform to the C standard.
6284 All callers of tparam changed to use tparam's actual API.
6285 * tparam.c (tparam1, tparam, tgoto):
6286 Use const pointers where appropriate.
6288 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6289 * cm.h (struct cm): Likewise.
6290 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6291 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6292 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6293 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6294 (turn_on_face, init_tty): Likewise.
6295 * termchar.h (struct tty_display_info): Likewise.
6297 * term.c (term_mouse_position): Rename local to avoid shadowing.
6299 * alloc.c (mark_ttys): Move decl from here ...
6300 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6302 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6304 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6306 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6308 * search.c (compile_pattern_1): Remove argument regp, unused since
6309 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6310 (compile_pattern): Don't pass it.
6312 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6314 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6315 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6317 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6319 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6321 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6322 gdk_window_get_screen, gdk_window_get_geometry,
6323 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6324 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6325 (xg_get_pixbuf_from_pixmap): New function.
6326 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6327 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6328 Call xg_get_pixbuf_from_pixmap instead of
6329 gdk_pixbuf_get_from_drawable.
6330 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6331 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6332 (xg_check_special_colors): Use GtkStyleContext and its functions
6334 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6335 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6336 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6337 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6338 Call gtk_widget_get_preferred_size.
6339 (xg_frame_resized): gdk_window_get_geometry only takes 5
6341 (xg_win_to_widget, xg_event_is_for_menubar):
6342 Call gdk_x11_window_lookup_for_display.
6343 (xg_set_widget_bg): New function.
6344 (delete_cb): New function.
6345 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6346 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6347 (xg_set_background_color): Call xg_set_widget_bg.
6348 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6349 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6350 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6351 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6353 (update_frame_tool_bar): Call gtk_widget_hide.
6354 (xg_initialize): Use GDK_KEY_g.
6356 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6358 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6360 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6361 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6362 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6364 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6366 * w32xfns.c (select_palette): Check success of RealizePalette against
6367 GDI_ERROR, not zero.
6369 See ChangeLog.11 for earlier changes.
6375 Copyright (C) 2011 Free Software Foundation, Inc.
6377 This file is part of GNU Emacs.
6379 GNU Emacs is free software: you can redistribute it and/or modify
6380 it under the terms of the GNU General Public License as published by
6381 the Free Software Foundation, either version 3 of the License, or
6382 (at your option) any later version.
6384 GNU Emacs is distributed in the hope that it will be useful,
6385 but WITHOUT ANY WARRANTY; without even the implied warranty of
6386 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6387 GNU General Public License for more details.
6389 You should have received a copy of the GNU General Public License
6390 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.