1 2011-10-26 Paul Eggert <eggert@cs.ucla.edu>
3 Fix integer width and related bugs (Bug#9874).
4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
117 Don't assume fixnum fits in int.
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
146 (Fforward_char, Fbackward_char): Use it.
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (ASSURE_DESTINATION, coding_alloc_by_realloc)
154 (coding_alloc_by_making_gap, alloc_destination)
155 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
156 (encode_coding_utf_16, detect_coding_emacs_mule)
157 (decode_coding_emacs_mule, encode_coding_emacs_mule)
158 (detect_coding_iso_2022, decode_coding_iso_2022)
159 (encode_invocation_designation, encode_designation_at_bol)
160 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
161 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
162 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
163 (encode_coding_ccl, encode_coding_raw_text)
164 (detect_coding_charset, decode_coding_charset)
165 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
166 (produce_composition, produce_charset, produce_annotation)
167 (decode_coding, handle_composition_annotation)
168 (handle_charset_annotation, consume_chars, decode_coding_gap)
169 (decode_coding_object, encode_coding_object, detect_coding_system)
170 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
171 (code_convert_region, code_convert_string)
172 (Fdefine_coding_system_internal):
173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
174 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
175 (Fdefine_coding_system_internal):
176 Don't assume fixnums fit in int.
177 (decode_coding_gap, decode_coding_object, encode_coding_object)
178 (Fread_coding_system, Fdetect_coding_region)
179 (Funencodable_char_position, Fcheck_coding_systems_region)
180 (get_translation, handle_composition_annotation, consume_chars):
181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
182 (consume_chars): Rewrite to not calculate an address outside buffer.
183 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
184 Don't access memory outside of the args array.
185 (Fdefine_coding_system_internal): Check for charset-id overflow.
186 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
187 result of ENCODE_CHAR.
188 * coding.h: Adjust decls to match defn changes elsewhere.
189 (struct coding_system):
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 * composite.c (get_composition_id, find_composition)
192 (run_composition_function, update_compositions)
193 (compose_text, composition_gstring_put_cache)
194 (composition_gstring_p, composition_gstring_width)
195 (fill_gstring_header, fill_gstring_body, autocmp_chars)
196 (composition_compute_stop_pos, composition_reseat_it)
197 (composition_update_it, struct position_record)
198 (find_automatic_composition, composition_adjust_point)
199 (Fcomposition_get_gstring, Ffind_composition_internal):
200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
201 (update_compositions):
202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
203 * composite.h: Adjust decls to match defn changes elsewhere.
204 (struct composition):
205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
206 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
207 Do not attempt to compute the address of the object just before a
208 buffer; this is not portable.
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
211 (Faset): Use int, not EMACS_INT, where int is wide enough.
212 (Fstring_to_number): Don't assume fixnums fit in int.
213 (Frem): Don't assume arg is nonnegative.
214 * dbusbind.c (xd_append_arg): Check for integers out of range.
215 (Fdbus_call_method): Don't overflow the timeout int.
216 * dired.c (directory_files_internal, file_name_completion, scmp)
217 (file_name_completion_stat):
218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
219 (file_name_completion): Don't overflow matchcount.
220 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
221 * dispextern.h: Adjust decls to match defn changes elsewhere.
222 (struct text_pos, struct glyph, struct bidi_saved_info)
223 (struct bidi_string_data, struct bidi_it, struct composition_it)
225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
226 (struct display_pos, struct composition_it, struct it):
227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
228 * dispnew.c (increment_matrix_positions)
229 (increment_row_positions, mode_line_string)
230 (marginal_area_string):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
232 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
234 (duration_to_sec_usec): New function, to check for overflow better.
235 (Fsleep_for, sit_for): Use it.
236 * doc.c (get_doc_string, store_function_docstring):
237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
238 (get_doc_string, Fsnarf_documentation):
239 Use int, not EMACS_INT, where int is wide enough.
241 Use SAFE_ALLOCA, not alloca.
242 Check for overflow when converting EMACS_INT to off_t.
244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
245 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
246 Don't assume uid_t fits into fixnum.
247 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
248 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
249 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
250 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
251 (general_insert_function)
252 (Finsert_char, make_buffer_string, make_buffer_string_both)
253 (update_buffer_properties, Fbuffer_substring)
254 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
255 (Fsubst_char_in_region, check_translation)
256 (Ftranslate_region_internal, save_restriction_restore, Fformat)
257 (transpose_markers, Ftranspose_regions):
258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
259 (clip_to_bounds): Move to lisp.h as an inline function).
260 (Fconstrain_to_field): Don't assume integers are nonnegative.
261 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
262 (Fsubst_char_in_region, Fsave_restriction):
263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
264 (Femacs_pid): Don't assume pid_t fits into fixnum.
265 (lo_time): Use int, not EMACS_INT, when int suffices.
266 (lisp_time_argument): Check for usec out of range.
267 (Fencode_time): Don't assume fixnum fits in int.
268 (Fuser_login_name, Fuser_full_name): Signal an error
269 if a uid argument is out of range, rather than relying on
271 (Fformat_time_string): Remove now-unnecessary check.
272 lisp_time_argument checks for out-of-range usec now.
273 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
274 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
275 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
276 (init_cmdargs, Fdump_emacs):
277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
278 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
279 the bottom (typically) 32 bits of the fixnum.
280 * eval.c (specpdl_size, call_debugger):
281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
282 (when_entered_debugger, Fbacktrace_debug):
283 Don't assume fixnum can fit in int.
284 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
285 the object just before a buffer; this is not portable.
286 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
287 (grow_specpdl, unbind_to):
288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
289 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
290 (grow_specpdl): Simplify allocation by using xpalloc.
291 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
292 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
293 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
295 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
298 (Fcopy_file, non_regular_nbytes, read_non_regular)
299 (Finsert_file_contents):
300 Use int, not EMACS_INT, where int is wide enough.
301 (READ_BUF_SIZE): Verify that it fits in int.
302 (Finsert_file_contents): Check that counts are in proper range,
303 rather than assuming fixnums fit into ptrdiff_t etc.
304 Don't assume fixnums fit into int.
305 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
306 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
307 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
308 (string_char_to_byte, string_byte_to_char)
309 (string_make_multibyte, string_to_multibyte)
310 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
311 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
312 (substring_both, Fdelete, internal_equal, Ffillarray)
313 (Fclear_string, mapcar1)
314 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
315 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
316 (larger_vector, make_hash_table, maybe_resize_hash_table)
317 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
318 (Fmaphash, secure_hash):
319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
320 (concat): Check for string index and length overflow.
321 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
324 (larger_vector): New API (vec, incr_min, size_max) replaces old
325 one (vec, new_size, init). This catches size overflow.
326 INIT was removed because it was always Qnil.
328 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
329 the upper bound on a hash table index size.
330 (make_hash_table, maybe_resize_hash_table): Use it.
331 (secure_hash): Computer start_byte and end_byte only after
332 they're known to be in ptrdiff_t range.
333 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
334 (Ffont_get_glyphs, Ffont_at):
335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
336 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
337 (Flist_fonts, Fopen_font):
338 Don't assume fixnum can fit in int.
339 (check_gstring): Don't assume index can fit in int.
340 (font_match_p): Check that fixnum is a character, not a nonnegative
341 fixnum, since the later code needs to stuff it into an int.
342 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
343 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
344 conversion overflow issues.
345 (Fopen_font): Check for integer out of range.
346 (Ffont_get_glyphs): Don't assume index can fit in int.
347 * font.h: Adjust decls to match defn changes elsewhere.
348 * fontset.c (reorder_font_vector): Redo score calculation to avoid
350 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
351 printmax_t, where ptrdiff_t is wide enough.
352 (Finternal_char_font):
353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
354 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
355 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
356 (Fset_frame_position, x_set_frame_parameters)
357 (x_set_line_spacing, x_set_border_width)
358 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
359 Check that fixnums are in proper range for system types.
360 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
362 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
363 Use SAFE_ALLOCA_LISP, not alloca.
364 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
365 intptr_t is wide enough.
366 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
367 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
368 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
369 Check for fixnum out of range.
370 * ftfont.c (ftfont_list): Don't assume index fits in int.
371 Check that fixnums are in proper range for system types.
372 (ftfont_shape_by_flt):
373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
374 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
376 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
377 Check that fixnums are in proper range for system types.
378 * gnutls.h: Adjust decls to match defn changes elsewhere.
379 * gtkutil.c (xg_dialog_run):
380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
381 (update_frame_tool_bar):
382 Check that fixnums are in proper range for system types.
383 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
384 (lookup_image): Check that fixnums are in range for system types.
385 * indent.c (last_known_column, last_known_column_point):
386 (current_column_bol_cache):
387 (skip_invisible, current_column, check_display_width):
388 (check_display_width, scan_for_column, current_column_1)
389 (Findent_to, Fcurrent_indentation, position_indentation)
390 (indented_beyond_p, Fmove_to_column, compute_motion):
391 (Fcompute_motion, Fvertical_motion):
392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
393 (last_known_column_modified): Use EMACS_INT, not int.
394 (check_display_width):
396 Check that fixnums and floats are in proper range for system types.
397 (compute_motion): Don't assume index or fixnum fits in int.
398 (compute_motion, Fcompute_motion):
399 Use int, not EMACS_INT, when it is wide enough.
400 (vmotion): Omit local var start_hpos that is always 0; that way
401 we don't need to worry about overflow in expressions involving it.
402 * indent.h: Adjust decls to match defn changes elsewhere.
404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
405 Use int, not EMACS_INT, where int is wide enough.
406 Remove unused members ovstring_chars_done and tab_offset;
408 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
409 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
410 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
411 (make_gap, copy_text, insert, insert_and_inherit)
412 (insert_before_markers, insert_before_markers_and_inherit)
413 (insert_1, count_combining_before, count_combining_after)
414 (insert_1_both, insert_from_string)
415 (insert_from_string_before_markers, insert_from_string_1)
416 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
417 (adjust_after_replace, adjust_after_insert, replace_range)
418 (replace_range_2, del_range, del_range_1, del_range_byte)
419 (del_range_both, del_range_2, modify_region)
420 (prepare_to_modify_buffer, signal_before_change)
421 (signal_after_change, Fcombine_after_change_execute):
422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
423 * intervals.c (traverse_intervals, rotate_right, rotate_left)
424 (balance_an_interval, split_interval_right, split_interval_left)
425 (find_interval, next_interval, update_interval)
426 (adjust_intervals_for_insertion, delete_node, delete_interval)
427 (interval_deletion_adjustment, adjust_intervals_for_deletion)
428 (static_offset_intervals, offset_intervals)
429 (merge_interval_right, merge_interval_left, make_new_interval)
430 (graft_intervals_into_buffer, temp_set_point_both)
431 (temp_set_point, set_point, adjust_for_invis_intang)
432 (set_point_both, move_if_not_intangible, get_property_and_range)
433 (get_local_map, copy_intervals, copy_intervals_to_string)
434 (compare_string_intervals, set_intervals_multibyte_1):
435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
436 * intervals.h: Adjust decls to match defn changes elsewhere.
438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
439 * keyboard.c (this_command_key_count, this_single_command_key_start)
440 (before_command_key_count, before_command_echo_length, echo_now)
441 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
442 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
443 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
444 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
446 (last_non_minibuf_size, last_point_position, echo_truncate)
447 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
448 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
449 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
450 (stuff_buffered_input):
451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
452 (last_auto_save, command_loop_1, read_char):
453 Use EMACS_INT, not int, to avoid integer overflow.
454 (record_char): Avoid overflow in total_keys computation.
455 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
456 * keyboard.h: Adjust decls to match defn changes elsewhere.
457 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
458 (Fkey_description, Fdescribe_vector, Flookup_key):
459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
460 (click_position): New function, to check that positions are in range.
461 (Fcurrent_active_maps):
463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
464 (Faccessible_keymaps, Fkey_description):
465 (preferred_sequence_p):
466 Don't assume fixnum can fit into int.
467 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
468 Check for integer overflow in size calculations.
469 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
470 avoid mishandling large integers.
471 * lisp.h: Adjust decls to match defn changes elsewhere.
472 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
473 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
474 (struct Lisp_Marker):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (clip_to_bounds): Now an inline function, moved here from editfns.c.
477 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
478 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
480 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
481 Assume the arg has valid form, since it always does.
482 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
483 unsigned integer system type.
484 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
485 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
487 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
488 (duration_to_sec_usec): New decl.
489 * lread.c (read_from_string_index, read_from_string_index_byte)
490 (read_from_string_limit, readchar, unreadchar, openp)
491 (read_internal_start, read1, oblookup):
492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
493 (Fload, readevalloop, Feval_buffer, Feval_region):
494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
495 (openp): Check for out-of-range argument to 'access'.
496 (read1): Use int, not EMACS_INT, where int is wide enough.
497 Don't assume fixnum fits into int.
498 Fix off-by-one error that can read outside a buffer.
499 (read_filtered_event): Use duration_to_sec_usec
500 to do proper overflow checking on durations.
501 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
503 (Fexecute_kbd_macro):
504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
505 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
506 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
507 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
508 (set_marker_both, set_marker_restricted_both, marker_position)
509 (marker_byte_position, Fbuffer_has_markers_at):
510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
511 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
512 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
513 It now merely ensures that the menu is large enough, without
514 necessarily growing it, as this avoids some integer overflow issues.
516 (keymap_panes, parse_single_submenu, Fx_popup_menu):
517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
518 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
519 Use SAFE_ALLOCA_LISP, not alloca.
520 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
521 to EMACS_INT. Check that fixnums are in proper range for system types.
522 * minibuf.c (minibuf_prompt_width, string_to_object)
523 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
524 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
526 (get_minibuffer, read_minibuf_unwind):
527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
528 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
529 this simplifies overflow checking. All callers changed.
530 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
533 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
534 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
535 Check that fixnums are in proper range for system types.
536 (Fx_create_frame, Fx_show_tip):
537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
538 * nsfont.m (ns_findfonts, nsfont_list_family):
539 Don't assume fixnum fits in long.
540 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
542 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
544 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
546 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
547 (PRINTDECLARE, PRINTPREPARE):
548 (strout, print_string):
549 (print, print_preprocess, print_check_string_charset_prop)
551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
553 (temp_output_buffer_setup, Fprin1_to_string, print_object):
554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
555 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
556 (printchar, strout): Use xpalloc to catch size calculation overflow.
557 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
558 (print_error_message): Use SAFE_ALLOCA, not alloca.
559 (print_object): Use int, not EMACS_INT, where int is wide enough.
560 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
561 (Fset_process_window_size, Fformat_network_address)
562 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
564 Check that fixnums are in proper range for system types.
565 (Fsignal_process): Simplify by avoiding a goto.
566 Check for process-ids out of pid_t range rather than relying on
568 (Fformat_network_address, read_process_output, send_process)
569 (Fprocess_send_region, status_notify):
570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
571 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
572 (wait_reading_process_output, read_process_output, exec_sentinel):
573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
574 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
575 (Faccept_process_output): Use duration_to_sec_usec to do proper
576 overflow checking on durations.
577 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
578 Don't assume pid_t fits in int.
579 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
580 configured --with-wide-int.
581 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
582 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
583 * search.c (looking_at_1, string_match_1):
584 (fast_string_match, fast_c_string_match_ignore_case)
585 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
586 (scan_newline, find_before_next_newline, search_command)
587 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
588 (set_search_regs, wordify):
591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
592 (string_match_1, search_buffer, set_search_regs):
594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
595 (wordify): Check for overflow in size calculation.
596 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
597 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
598 Check that fixnums are in proper range for system types.
599 * sound.c (struct sound_device)
600 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
602 (Fplay_sound_internal):
603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
604 * syntax.c (struct lisp_parse_state, find_start_modiff)
605 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
606 (Fparse_partial_sexp):
607 Don't assume fixnums can fit in int.
608 (struct lisp_parse_state, find_start_pos, find_start_value)
609 (find_start_value_byte, find_start_begv)
610 (update_syntax_table, char_quoted, dec_bytepos)
611 (find_defun_start, prev_char_comend_first, back_comment):
612 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
613 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
615 (Finternal_describe_syntax_value): Check that match_lisp is a
616 character, not an integer, since the code stuffs it into int.
617 (scan_words, scan_sexps_forward):
618 Check that fixnums are in proper range for system types.
620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
621 (scan_sexps_forward):
622 Use CHARACTERP, not INTEGERP, since the value must fit into int.
623 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
624 * syntax.h: Adjust decls to match defn changes elsewhere.
626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
627 * sysdep.c (wait_for_termination_1, wait_for_termination)
628 (interruptible_wait_for_termination, mkdir):
629 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
630 (emacs_read, emacs_write):
631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
633 and double all fit in int.
634 * term.c (set_tty_color_mode):
635 Check that fixnums are in proper range for system types.
636 * termhooks.h (struct input_event):
637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
638 * textprop.c (validate_interval_range, interval_of)
639 (Fadd_text_properties, set_text_properties_1)
640 (Fremove_text_properties, Fremove_list_of_text_properties)
641 (Ftext_property_any, Ftext_property_not_all)
642 (copy_text_properties, text_property_list, extend_property_ranges)
643 (verify_interval_modification):
644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
645 (Fnext_single_char_property_change)
646 (Fprevious_single_char_property_change):
647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
648 (copy_text_properties):
649 Check for integer overflow in index calculation.
650 * undo.c (last_boundary_position, record_point, record_insert)
651 (record_delete, record_marker_adjustment, record_change)
652 (record_property_change):
653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
654 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
656 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
657 (Fx_hide_tip, Fx_file_dialog):
658 * w32menu.c (set_frame_menubar):
659 Use ptrdiff_t, not int, for consistency with rest of code.
660 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
661 (select_window, Fdelete_other_windows_internal)
662 (window_scroll_pixel_based, window_scroll_line_based)
663 (Frecenter, Fset_window_configuration):
664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
665 (Fset_window_hscroll, run_window_configuration_change_hook)
666 (set_window_buffer, temp_output_buffer_show, scroll_command)
667 (Fscroll_other_window, Frecenter):
668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
669 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
670 Don't assume fixnum fits in int.
671 (Fset_window_scroll_bars):
672 Check that fixnums are in proper range for system types.
673 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
674 (string_pos, c_string_pos, number_of_chars, init_iterator)
675 (in_ellipses_for_invisible_text_p, init_from_display_pos)
676 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
677 (compute_display_string_end, handle_face_prop)
678 (face_before_or_after_it_pos, handle_invisible_prop)
679 (handle_display_prop, handle_display_spec, handle_single_display_spec)
680 (display_prop_intangible_p, string_buffer_position_lim)
681 (string_buffer_position, handle_composition_prop, load_overlay_strings)
682 (get_overlay_strings_1, get_overlay_strings)
683 (iterate_out_of_display_property, forward_to_next_line_start)
684 (back_to_previous_visible_line_start, reseat, reseat_to_string)
685 (get_next_display_element, set_iterator_to_next)
686 (get_visually_first_element, compute_stop_pos_backwards)
687 (handle_stop_backwards, next_element_from_buffer)
688 (move_it_in_display_line_to, move_it_in_display_line)
689 (move_it_to, move_it_vertically_backward, move_it_by_lines)
690 (add_to_log, message_dolog, message_log_check_duplicate)
691 (message2, message2_nolog, message3, message3_nolog
692 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
693 (current_message_1, truncate_echo_area, truncate_message_1)
694 (set_message, set_message_1, store_mode_line_noprop)
695 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
696 (text_outside_line_unchanged_p, check_point_in_composition)
697 (reconsider_clip_changes)
698 (redisplay_internal, set_cursor_from_row, try_scrolling)
699 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
700 (redisplay_window, find_last_unchanged_at_beg_row)
701 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
702 (trailing_whitespace_p, find_row_edges, display_line)
703 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
704 (display_mode_element, store_mode_line_string)
705 (pint2str, pint2hrstr, decode_mode_spec)
706 (display_count_lines, display_string, draw_glyphs)
707 (x_produce_glyphs, x_insert_glyphs)
708 (rows_from_pos_range, mouse_face_from_buffer_pos)
709 (fast_find_string_pos, mouse_face_from_string_pos)
710 (note_mode_line_or_margin_highlight, note_mouse_highlight):
711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
712 (safe_call, init_from_display_pos, handle_fontified_prop)
713 (handle_single_display_spec, load_overlay_strings)
714 (with_echo_area_buffer, setup_echo_area_for_printing)
715 (display_echo_area, echo_area_display)
716 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
717 (update_tool_bar, hscroll_window_tree, redisplay_internal)
718 (redisplay_window, dump_glyph_row, display_mode_line)
719 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
720 (handle_display_spec, display_prop_string_p):
721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
722 (handle_single_display_spec, build_desired_tool_bar_string)
723 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
724 (get_specified_cursor_type):
725 Check that fixnums are in proper range for system types.
726 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
728 Don't assume fixnums fit in int.
729 (compare_overlay_entries):
730 Avoid mishandling comparisons due to subtraction overflow.
731 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
732 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
733 (handle_tool_bar_click):
734 Use int, not unsigned, since we prefer signed and the signedness
736 (get_next_display_element, next_element_from_display_vector):
737 Use int, not EMACS_INT, when int is wide enough.
738 (start_hourglass): Use duration_to_sec_usec to do proper
739 overflow checking on durations.
740 * xfaces.c (Fbitmap_spec_p):
741 Check that fixnums are in proper range for system types.
742 (compare_fonts_by_sort_order):
743 Avoid mishandling comparisons due to subtraction overflow.
744 (Fx_family_fonts, realize_basic_faces):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
747 Don't assume fixnum fits in int.
748 Use SAFE_ALLOCA_LISP, not alloca.
749 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
750 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
751 (face_at_buffer_position, face_for_overlay_string)
752 (face_at_string_position):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
755 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
757 Check that fixnums are in proper range for system types.
758 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
759 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
761 (Fx_change_window_property): Don't assume fixnums fit in int.
762 * xfont.c (xfont_chars_supported):
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
765 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
767 * xml.c (parse_region):
768 * xrdb.c (magic_file_p):
769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
770 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
771 (x_get_local_selection, x_reply_selection_request)
772 (x_handle_selection_request, wait_for_property_change):
773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
774 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
775 short is wide enough.
776 (x_send_client_event): Don't assume fixnum fits in int.
777 * xterm.c (x_x_to_emacs_modifiers):
778 Don't assume EMACS_INT overflows nicely into int.
779 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
781 (handle_one_xevent): NATNUMP can eval its arg twice.
782 (x_connection_closed):
783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
784 * xterm.h: Adjust decls to match defn changes elsewhere.
785 (struct scroll_bar): Use struct vectorlike_header
786 rather than rolling our own approximation.
787 (SCROLL_BAR_VEC_SIZE): Remove; not used.
789 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
791 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
793 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
795 * keyboard.c (test_undefined): New function (bug#9751).
796 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
798 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
800 * sysdep.c (init_sys_modes): Fix the check for the controlling
803 2011-10-20 Eli Zaretskii <eliz@gnu.org>
805 * dispextern.h (struct bidi_it): New member next_en_type.
807 * bidi.c (bidi_line_init): Initialize the next_en_type member.
808 (bidi_resolve_explicit_1): When next_en_pos is valid for the
809 current character, check also for next_en_type being WEAK_EN.
810 (bidi_resolve_weak): Don't enter the expensive loop if the current
811 position is before next_en_pos. Record the bidi type of the first
812 non-ET, non-BN character we find, in addition to its position.
813 (bidi_level_of_next_char): Invalidate next_en_type when
814 next_en_pos is over-stepped.
816 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
818 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
819 * editfns.c: Rewrite current-time-zone so that it invokes
820 the equivalent of (format-time-string "%Z") to get the time zone name.
821 This fixes a bug when the time zone name contains characters that
822 need converting from the system time locale to Emacs internal format.
823 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
824 that patch fixed format-time-string to do the conversion, but
825 I forgot to fix current-time-zone.
826 (format_time_string): New function, containing most of
827 what Fformat_time_string used to contain.
828 (Fformat_time_string): Rewrite in terms of format_time_string.
829 This doesn't change this function's behavior.
830 (current-time-zone): Rewrite to use format_time_string.
831 This fixes the bug reported by Michael Schierl in
832 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
833 Jason Rumney's 2007-06-07 change worked around this bug, but
835 * systime.h (tzname, timezone): Remove no-longer-used declarations.
837 2011-10-19 Eli Zaretskii <eliz@gnu.org>
839 * xdisp.c (start_display): If the character at POS is displayed
840 via a display vector, reset IT->current.dpvec_index to zero.
841 (try_window_reusing_current_matrix): If a line ends in a display
842 vector or the next line starts in a display vector, continue
843 redrawing the window even though the character position of
844 start_row was reached.
847 2011-10-18 Chong Yidong <cyd@gnu.org>
849 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
850 with nobreak-char-display too.
852 2011-10-18 Eli Zaretskii <eliz@gnu.org>
854 Fix part 3 of bug#9771.
855 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
856 (bidi_resolve_neutral): Don't enter the expensive loop looking for
857 non-neutral characters if the current character is a paragraph
858 separator (a.k.a. Newline). This avoids running the same
859 expensive loop twice, once when we consume the preceding newline
860 and the other time when the line actually needs to be displayed.
861 Avoid the loop when we see neutrals on the base embedding level
862 following a character whose directionality is the same as the
863 paragraph's. This avoids running the expensive loop when a line
864 ends in a long sequence of neutrals, like control characters.
865 Add assertion against STRONG_AL type. Slightly rearrange code
866 that determines the type of a neutral given the first non-neutral
868 (bidi_level_of_next_char): Set next_en_pos to zero when
869 invalidating its info.
871 2011-10-17 Eli Zaretskii <eliz@gnu.org>
873 * xdisp.c (push_display_prop): Determine whether to record string
874 or buffer position by IT->string, not by IT->method. Allow
875 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
876 (move_it_vertically_backward): Don't look for character position
877 immediately after the newline when in a continuation line.
880 2011-10-15 Martin Rudalics <rudalics@gmx.at>
882 * window.c (coordinates_in_window): Rewrite and delabelize
883 vertical border check. (Bug#5357) (Bug#9618)
885 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
887 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
888 errors in XSetWindowBorder (bug#9310).
890 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
892 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
893 avoid crash when xmalloc overrun checking is enabled.
895 2011-10-13 Eli Zaretskii <eliz@gnu.org>
897 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
898 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
899 cursor motion with <left> and <right> arrow keys.
901 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
902 some callers set that themselves.
904 2011-10-12 Eli Zaretskii <eliz@gnu.org>
906 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
907 display string and the previous row comes from the same string and
908 is empty. (Bug#9739) (Bug#9738)
910 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
912 * doc.c (get_doc_string): Encode file name (bug#9735).
914 2011-10-12 Eli Zaretskii <eliz@gnu.org>
916 * bidi.c (bidi_level_of_next_char):
917 * xdisp.c (get_visually_first_element): Remove old incorrect
918 comments regarding the Unicode Line Separator character.
920 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
922 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
924 * alloc.c (Fgc_status): Do not access beyond zombies array
925 boundary if nzombies > MAX_ZOMBIES.
926 * alloc.c (dump_zombies): Add missing format specifier.
928 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
930 * xdisp.c (set_cursor_from_row): Simplify conditionals,
931 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
933 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
934 Some packages use them to denote characters with modifiers.
936 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
938 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
939 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
940 matching a pp-number. Rename parameter var to var1.
942 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
944 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
946 2011-10-08 Glenn Morris <rgm@gnu.org>
948 * callint.c (Fcall_interactively): Give a more explicit error for the
949 'c' case with a non-character input. (Bug#8479)
951 2011-10-08 Eli Zaretskii <eliz@gnu.org>
953 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
955 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
956 lines that are hscrolled on the left.
958 * dispnew.c (buffer_posn_from_coords): Account for a possible
959 presence of header-line. (Bug#4426)
961 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
963 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
964 Don't advertise functionality which we discourage or doesn't work.
966 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
968 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
969 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
970 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
971 this makes Emacs dump core during garbage collection on rare
972 occasions. sizeof is obviously inferior to offsetof here, so
974 (GC_POINTER_ALIGNMENT): New macro.
975 (mark_memory): Omit 3rd (offset) arg; caller changed.
976 Don't assume EMACS_INT alignment is the same as pointer alignment.
978 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
980 * keyboard.c (read_key_sequence_remapped): New var.
981 (read_key_sequence): Compute remapping in the right buffer.
982 (command_loop_1): Use read_key_sequence's remapping directly.
984 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
986 * dired.c (file_name_completion): Don't expand file name.
987 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
988 before checking file name handler.
990 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
991 they've been requested explicitly (bug#9591).
993 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
995 * keymap.c (Fsingle_key_description): Use make_specified_string
996 instead of build_string to build string from push_key_description.
999 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1001 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1002 This fixes a Y2038 bug on 64-bit hosts.
1003 * buffer.c (reset_buffer):
1004 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1005 (Fclear_buffer_auto_save_failure):
1006 Use 0, not -1, to represent an unset failure time, since time_t
1007 might not be signed.
1009 Remove dependency on glibc malloc internals.
1010 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1011 Move back here from lisp.h, but with their new implementations.
1012 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1013 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1014 * charset.c (charset_table_init): New static var.
1015 (syms_of_charset): Use it instead of xmalloc. This removes a
1016 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1017 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1018 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1019 Move back to alloc.c.
1020 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1021 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1023 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1025 * nsterm.m (windowDidResize): Call x_set_window_size only when
1026 ns_in_resize is true. Otherwise set pixelwidth/height and
1027 call change_frame_size (Bug#9628).
1029 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1031 Port --enable-checking=all to Fedora 14 x86-64.
1032 * charset.c (syms_of_charset): Also account for glibc malloc's
1033 internal overhead when calculating the initial malloc maximum.
1035 Port --enable-checking=all to Fedora 14 x86.
1036 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1038 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1039 (overrun_check_realloc, overrun_check_free):
1040 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1041 That way, xmalloc returns a properly-aligned pointer even if
1042 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1043 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1044 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1045 into account when calculating the initial malloc maximum.
1046 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1047 Move here from alloc.c, so that charset.c can use it too.
1048 Properly align; the old code wasn't right for common 32-bit hosts
1049 when configured with --enable-checking=all.
1050 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1051 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1053 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1055 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1058 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1060 * xdisp.c (compute_display_string_end): If there's no display
1061 string at CHARPOS, return -1.
1063 * bidi.c (bidi_fetch_char): When compute_display_string_end
1064 returns a negative value, treat the character as a normal
1065 character not covered by a display string. (Bug#9624)
1067 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1069 * lread.c (Fread_from_string): Fix typo in docstring.
1071 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1073 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1074 newline, reseat the iterator instead of bidi-iterating there one
1075 character at a time. (Bug#9610)
1076 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1077 TO_CHARPOS if the bidi iterator is at base embedding level.
1079 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1081 * lread.c (readevalloop): Use correct code for NBSP.
1082 (read1): Likewise. (Bug#9608)
1084 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1086 * dbusbind.c (Fdbus_register_signal): When service is not
1087 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1089 2011-09-25 Glenn Morris <rgm@gnu.org>
1091 * buffer.c (truncate-lines): Doc fix.
1093 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1095 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1096 (Fset_window_next_buffers): Doc fix.
1098 2011-09-24 Glenn Morris <rgm@gnu.org>
1100 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1102 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1104 Fix minor problems found by static checking.
1105 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1106 * indent.c (Fvertical_motion): Fix == vs = typo.
1108 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1110 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1111 Default value is now t. Doc fix.
1113 * indent.c (Fvertical_motion): Compute and apply the overshoot
1114 logic when moving up, not only when moving down. Fix the
1115 confusing name and values of the it_overshoot_expected variable;
1116 logic changes accordingly. (Bug#9254) (Bug#9549)
1118 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1119 CHARPOS is covered by a display string which includes newlines.
1120 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1121 is covered by a display string with embedded newlines.
1123 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1125 * dbusbind.c (Fdbus_register_signal): Add match rule to
1126 Vdbus_registered_objects_table. (Bug#9581)
1127 (Fdbus_register_method, Vdbus_registered_objects_table):
1130 2011-09-24 Jim Meyering <meyering@redhat.com>
1132 do not ignore write error for any output size
1133 The previous change was incomplete.
1134 While it makes emacs --batch detect the vast majority of stdout
1135 write failures, errors were still ignored whenever the output size is
1136 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1137 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1138 && echo FAIL: ignored write error
1139 FAIL: ignored write error
1140 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1141 && echo FAIL: ignored write error
1142 FAIL: ignored write error
1143 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1145 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1147 * emacs.c (Fkill_emacs): In noninteractive mode exit
1148 non-successfully if a write error occurred on stdout. (Bug#9574)
1150 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1152 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1155 * dispextern.h (struct it): Update the comment documenting what
1158 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1160 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1161 a display string, extend search for cursor position to end of row.
1162 (find_row_edges): If the row ends in a newline from a display
1163 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1164 Handle the case of a display string with multiple newlines.
1165 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1166 non-empty line. Fixes confusing cursor motion with arrow keys at
1167 the beginning of a line that starts with whitespace.
1169 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1171 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1174 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1176 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1179 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1181 * xdisp.c (display_line): Record maximum and minimum buffer
1182 positions even if no glyphs were produced (e.g., by a zero-width
1183 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1184 buffer positions that will be removed from the glyph row because
1186 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1187 column is beyond frame width: don't subtract 1 "pixel" when
1188 computing width of the stretch.
1189 (reseat_at_next_visible_line_start): Undo the change made on
1190 2011-09-17 that saved paragraph information and restored it after
1191 the call to `reseat'. (Bug#9545)
1193 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1195 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1196 and turn window cursor on if cleared (Bug#9415).
1198 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1200 * search.c (boyer_moore): Take unibyte characters from pattern
1201 literally. (Bug#9458)
1203 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1205 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1207 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1209 Fix minor problem found by static checking.
1210 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1211 initialized, to pacify gcc -Wuninitialized.
1213 * fileio.c: Report proper errno when syscall falls.
1214 (Finsert_file_contents): Save and restore errno,
1215 so that report_file_error outputs the correct diagnostic.
1216 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1218 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1220 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1222 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1224 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1225 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1227 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1229 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1230 about the current paragraph and restore it after the call to reseat.
1232 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1233 (bidi_find_paragraph_start): Search back for paragraph beginning
1234 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1235 (bidi_move_to_visually_next): Only trigger paragraph-related
1236 computations when the last character is a newline or at EOB, not
1237 just any NEUTRAL_B. (Bug#9470)
1239 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1240 truncated lines if point is covered by a display string. (Bug#9524)
1242 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1244 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1245 (cons_to_x_long): New function.
1246 (lisp_data_to_selection_data): Use it. Correct the test for
1247 short-versus-long data; it was negated. Break out of vector
1248 loop, for efficiency, when a long datum is discovered.
1250 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1252 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1254 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1256 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1257 GCC PR/17406) by declaring this function with external scope.
1259 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1261 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1262 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1264 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1266 * editfns.c (Fformat): Correctly handle text properties on "%%".
1268 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1270 * xterm.c (x_draw_composite_glyph_string_foreground):
1271 * w32term.c (x_draw_composite_glyph_string_foreground):
1272 * term.c (encode_terminal_code):
1273 * composite.c (composition_update_it, get_composition_id):
1274 * xdisp.c (get_next_display_element)
1275 (fill_composite_glyph_string): Add comments about special meaning
1276 of TAB characters in a composition.
1278 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1280 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1281 This occurs when processing a multibyte format.
1282 Problem reported by Wolfgang Jenker.
1284 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1286 * xdisp.c (try_cursor_movement): Only check for exact match if
1287 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1289 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1291 Remove unused external symbols.
1292 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1293 * xdisp.c (calc_pixel_width_or_height): Now static.
1294 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1295 * indent.c (check_display_width):
1296 * w32term.c: Fix comment to match code.
1297 * xterm.c, xterm.h (x_catching_errors): Remove.
1299 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1301 * xselect.c: Use signed conversions more consistently (Bug#9498).
1302 (selection_data_to_lisp_data): Assume incoming selection data are
1303 signed integers, not unsigned. This is to be consistent with
1304 outgoing selection data, which was modified to use signed integers
1305 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1306 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1307 expects long, not unsigned long.
1309 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1311 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1312 computation of loop end. Reported by Johan Bockgård
1315 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1317 * frame.c (Fother_visible_frames_p): Function deleted.
1319 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1321 * indent.c (compute_motion): Process display vector front to back
1322 rather than the other way around. (Bug#2496)
1324 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1326 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1328 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1330 * minibuf.c (Fread_from_minibuffer): Doc fix.
1332 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1334 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1335 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1337 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1339 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1340 value for non-existent files.
1342 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1344 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1345 set its "size" to -1. This will set the modtime_size field of
1346 the corresponding buffer to -1, which is what
1347 verify-visited-file-modtime expects for files that do not exist.
1350 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1352 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1354 * lisp.h: ... from here. push_key_description is no longer
1355 defined in keyboard.c, so its declaration should not be in
1356 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1357 logically belongs with push_key_description.
1359 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1361 * buffer.h: Include <sys/types.h> instead of <time.h>.
1362 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1363 Problem reported by Herbert J. Skuhra.
1365 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1367 * xml.c (parse_region): Make the parsing work for
1368 non-comment-starting XML files again (bug#9144).
1370 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1372 * image.c (gif_load): Fix calculation of bottom and right corner.
1375 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1377 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1378 redisplay in small windows.
1380 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1382 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1384 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1386 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1387 Operate on live windows only.
1389 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1391 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1393 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1395 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1396 only under bidi iteration.
1398 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1400 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1402 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1404 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1405 Without this fix, the command to link temacs failed due to an
1406 undefined symbol __builtin_isnan. This is because
1407 /usr/include/iso/math_c99.h #defines isnan(x) to
1408 __builtin_isnan(x), but the bundled gcc, which identifies itself
1409 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1411 * floatfns.c (isnan): #undef, and then #define to a clone of
1413 (Fisnan): Always define, since it's always available now.
1414 (syms_of_floatfns): Always define isnan at the Lisp level.
1416 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1418 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1420 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1422 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1423 The previous code assumed that file offsets (off_t values) fit in
1424 EMACS_INT variables, which is not true on typical 32-bit hosts.
1425 The code messed up by falsely reporting buffer overflow in cases
1426 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1427 when "big" contains more than 2**29 bytes, even though this
1428 inserts just one byte and does not overflow the buffer.
1429 (Finsert_file_contents): Store file offsets as off_t
1430 values, not as EMACS_INT values. Check for overflow when
1431 converting between EMACS_INT and off_t. When checking for
1432 buffer overflow or for overlap, take the offsets into account.
1433 Don't use EMACS_INT for small values where int suffices.
1434 When checking for overlap, fix a typo: ZV was used where
1435 ZV_BYTE was intended.
1436 (Fwrite_region): Don't assume off_t fits into 'long'.
1437 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1439 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1441 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1443 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1445 sprintf-related integer and memory overflow issues (Bug#9412).
1447 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1448 (esprintf, exprintf, evxprintf): New functions.
1449 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1450 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1451 (modify_event_symbol): Do not assume that the length of
1452 name_alist_or_stem is safe to alloca and fits in int.
1453 (Fexecute_extended_command): Likewise for function name and binding.
1454 (Frecursion_depth): Wrap around reliably on integer overflow.
1455 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1456 since some callers pass EMACS_INT values.
1457 (Fsingle_key_description): Don't crash if symbol name contains more
1458 than MAX_ALLOCA bytes.
1459 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1460 (get_minibuffer): Arg is now EMACS_INT, not int.
1461 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1462 (esprintf, exprintf, evxprintf): New decls.
1463 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1465 * dbusbind.c (signature_cat): New function.
1466 (xd_signature, Fdbus_register_signal):
1467 Do not overrun buffer; instead, report string overflow.
1469 * dispnew.c (add_window_display_history): Don't overrun buffer.
1470 Truncate instead; this is OK since it's just a log.
1472 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1473 even if the time zone offset is outlandishly large.
1474 Don't mishandle offset == INT_MIN.
1476 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1477 when creating daemon; the previous buffer-overflow check was incorrect.
1479 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1480 which has the guts of the old verror function.
1482 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1483 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1485 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1486 (font_unparse_xlfd): Don't blindly alloca long strings.
1487 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1488 fits in int, when using sprintf. Use single snprintf to count
1489 length of string rather than counting it via multiple sprintfs;
1490 that's simpler and more reliable.
1491 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1492 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1493 sprintf, in case result does not fit in int.
1495 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1496 (fontset_from_font): Print it.
1498 * frame.c (tty_frame_count): Now printmax_t, not int.
1499 (make_terminal_frame, set_term_frame_name): Print it.
1500 (x_report_frame_params): In X, window IDs are unsigned long,
1501 not signed long, so print them as unsigned.
1502 (validate_x_resource_name): Check for implausibly long names,
1503 and don't assume name length fits in 'int'.
1504 (x_get_resource_string): Don't blindly alloca invocation name;
1505 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1508 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1509 (xg_check_special_colors, xg_set_geometry):
1510 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1512 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1513 Use esprintf, not sprintf, in case result does not fit in int.
1515 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1516 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1517 it as a large positive number.
1518 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1519 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1521 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1522 in case result does not fit in int.
1524 * print.c (float_to_string): Detect width overflow more reliably.
1525 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1526 buffer overrun. Don't assume list length fits in 'int'. Treat
1527 print length of 0 as 0, not as infinity; to be consistent with other
1528 uses of print length in this function. Don't overflow print length
1529 index. Don't assume hash table size fits in 'long', or that
1530 vectorlike size fits in 'unsigned long'.
1532 * process.c (make_process): Use printmax_t, not int, to format
1533 process-name gensyms.
1535 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1537 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1538 to avoid potential buffer overrun.
1540 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1541 if X resource line is longer than 512 bytes.
1543 * xfns.c (x_window): Make sprintf buffer a bit bigger
1544 to avoid potential buffer overrun.
1546 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1548 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1550 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1552 Integer overflow fixes for scrolling, etc.
1553 Without these, Emacs silently mishandles large integers sometimes.
1554 For example, "C-u 4294967297 M-x recenter" was treated as if
1555 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1557 * xdisp.c (try_window_id): Check Emacs fixnum range before
1558 converting to 'int'.
1560 * window.c (window_scroll_line_based, Frecenter):
1561 Check that an Emacs fixnum is in range before assigning it to 'int'.
1562 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1563 values converted from Emacs fixnums.
1564 (Frecenter): Don't wrap around a line count if it is out of 'int'
1565 range; instead, treat it as an extreme value.
1566 (Fset_window_configuration, compare_window_configurations):
1567 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1569 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1570 that can exceed INT_MAX. Check that EMACS_INT value is in range
1571 before assigning it to the (possibly-narrower) index.
1572 (match_limit): Don't assume that a fixnum can fit in 'int'.
1574 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1577 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1578 (Fvertical_motion): Don't wrap around LINES values that don't fit
1579 in 'int'. Instead, treat them as extreme values. This is good
1580 enough for windows, which can't have more than INT_MAX lines anyway.
1582 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1584 * Require libxml/parser.h to avoid compilation warning.
1586 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1588 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1589 since this reportedly can destroy thread storage.
1591 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1593 * syntax.c (find_defun_start): Update all cache variables if
1594 exiting early (Bug#9401).
1596 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1598 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1600 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1601 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1602 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1604 * term.c (tty_append_glyph): New function.
1605 (produce_stretch_glyph): Static function and its prototype deleted.
1607 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1610 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1612 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1613 when checking :margin (Bug#9390).
1614 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1615 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1616 so that the name doesn't mislead. All uses changed.
1618 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1620 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1623 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1625 * xdisp.c (move_it_to): Don't bail out early when reaching
1626 position beyond to_charpos, if we are scanning backwards.
1627 (move_it_vertically_backward): When DY == 0, make sure we get to
1628 the first character in the line after the newline.
1630 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1632 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1633 (ccl_driver): Do not generate an out-of-range pointer.
1634 (Fccl_execute_on_string): Remove unnecessary check for
1635 integer overflow, noted by Stefan Monnier in
1636 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1637 Remove a FIXME that didn't need fixing.
1638 Simplify the newly-introduced buffer reallocation code.
1640 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1642 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1644 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1646 Integer and memory overflow issues (Bug#9196).
1648 * doc.c (get_doc_string): Rework so that
1649 get_doc_string_buffer_size is the actual buffer size, rather than
1650 being 1 less than the actual buffer size; this makes xpalloc more
1653 * image.c (x_allocate_bitmap_record, cache_image):
1654 * xselect.c (Fx_register_dnd_atom):
1655 Simplify previous changes by using xpalloc.
1657 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1658 since either will do and ptrdiff_t is convenient with xpalloc.
1660 * charset.c (charset_table_size)
1661 (struct charset_sort_data.priority): Now ptrdiff_t.
1662 (charset_compare): Don't overflow if priorities differ greatly.
1663 (Fsort_charsets): Don't assume list length fits in int.
1664 Check for size-calculation overflow when allocating sort data.
1665 (syms_of_charset): Allocate an initial charset table that is
1666 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1668 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1670 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1671 The actual value is always <= INT_MAX, and leaving it unsigned made
1672 overflow checking harder.
1674 * dispextern.h (struct glyph_matrix.rows_allocated)
1675 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1676 with xpalloc. The values are still always <= INT_MAX.
1678 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1680 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1681 (SAFE_NALLOCA): New macro.
1683 * region-cache.c (struct boundary.pos, find_cache_boundary)
1684 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1685 (set_cache_region, invalidate_region_cache)
1686 (revalidate_region_cache, know_region_cache, region_cache_forward)
1687 (region_cache_backward, pp_cache):
1688 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1689 so that ptrdiff_t * can be passed to xpalloc.
1690 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1691 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1692 (pp_cache): Don't assume cache_len fits in int.
1693 * region-cache.h: Adjust extern decls to match.
1695 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1696 EMACS_INT, since either will do, for xpalloc.
1698 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1699 (xnmalloc, xnrealloc, xpalloc): New functions.
1701 * bidi.c (bidi_shelve_header_size): New constant.
1702 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1703 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1705 * bidi.c (bidi_cache_shrink):
1706 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1708 Don't update size of array until after memory allocation succeeds,
1709 because xmalloc/xrealloc may not return.
1710 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1711 now that we have proper integer overflow checking.
1712 (record_overlay_string, overlay_strings): Catch overflows when
1713 calculating size of overlay_str_buf.
1715 * callproc.c (Fcall_process): Check for size overflow when
1716 calculating size of args2.
1717 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1718 Normally we prefer signed values, but sticking with ptrdiff_t would
1719 require adding more-complicated checks.
1721 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1722 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1723 Redo buffer-overflow calculations to avoid integer overflow.
1724 Add a FIXME comment where memory seems to be over-allocated.
1726 * character.c (Fstring): Check for size-calculation overflow.
1728 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1729 unnecessary integer overflow. Check for size overflow.
1730 (encode_coding_object): Don't update size until xmalloc succeeds.
1732 * composite.c (get_composition_id): Check for overflow in glyph
1733 length calculations.
1735 Integer and memory overflow fixes for display code.
1736 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1737 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1738 (scrolling_window): Check for overflow in size calculations.
1739 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1740 Don't assume glyph table len fits in int.
1741 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1742 (row_table_size): Now ptrdiff_t, not int.
1743 (scrolling_window): Avoid overflow in size calculations.
1744 Don't update size until allocation succeeds.
1745 * fns.c (concat): Check for overflow in size calculations.
1746 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1747 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1748 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1750 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1751 (get_doc_string): Check for size calculation overflow.
1752 Don't update size until allocation succeeds.
1753 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1754 EMACS_INT, where ptrdiff_t will do.
1755 (Fsubstitute_command_keys): Check for string overflow.
1757 * editfns.c (set_time_zone_rule): Don't assume environment length
1759 (message_length): Now ptrdiff_t, not int.
1760 (Fmessage_box): Don't update size until allocation succeeds.
1761 Don't assume message length fits in int.
1762 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1764 * emacs.c (main): Do not reallocate argv, since there is a null at
1765 the end that can be overwritten, and this way there's no need to
1766 worry about size-calculation overflow.
1767 (sort_args): Check for size-calculation overflow.
1769 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1771 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1773 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1774 (x_set_scroll_bar_width, x_figure_window_size):
1775 Check for integer overflow.
1776 (x_set_alpha): Do not assume XINT fits in int.
1778 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1779 This is for the members text_lines, text_cols, total_lines, total_cols,
1780 where the system imposes an 'int' limit.
1782 * fringe.c (Fdefine_fringe_bitmap):
1783 Don't update size until alloc works.
1785 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1786 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1788 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1789 Check for size-calculation overflow.
1790 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1791 do, as we prefer signed integers.
1792 (id_to_widget.max_size, id_to_widget.used)
1793 (xg_store_widget_in_map, xg_remove_widget_from_map)
1794 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1795 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1796 Use and return ptrdiff_t, not int.
1797 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1798 * gtkutil.h: Change prototypes to match the above.
1800 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1801 are duplicate now that they've been promoted to lisp.h.
1802 (x_allocate_bitmap_record, x_alloc_image_color)
1803 (make_image_cache, cache_image, xpm_load):
1804 Don't update size until alloc is done.
1805 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1807 Check for size calculation overflow.
1808 (ct_colors_allocated_max): New constant.
1809 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1812 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1813 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1814 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1815 Use ptrdiff_t, not int, to count maps.
1816 (read_char_minibuf_menu_prompt): Check for overflow in size
1817 calculations. Don't update size until allocation succeeds.
1818 Redo calculations to avoid overflow.
1819 * keyboard.h: Change prototypes to match the above.
1821 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1823 (current_minor_maps): Check for size calculation overflow.
1824 * keymap.h: Change prototypes to match the above.
1826 * lread.c (read1, init_obarray): Don't update size until alloc done.
1828 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1829 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1831 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1832 Now ptrdiff_t, not int.
1833 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1834 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1836 * process.c (Fnetwork_interface_list): Check for overflow
1837 in size calculation.
1839 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1841 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1842 overflow. Don't bother calling xmalloc when xrealloc will do.
1844 * search.c (Freplace_match): Check for size calculation overflow.
1845 (Fset_match_data): Don't assume list lengths fit in 'int'.
1847 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1848 for command line length. Do not attempt to address one before the
1849 beginning of an array, as that's not portable.
1851 * term.c (max_frame_lines): Remove; unused.
1852 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1854 (encode_terminal_code, calculate_costs): Check for size
1855 calculation overflow.
1856 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1857 table lengths and related sizes. Don't update size until alloc
1858 done. Redo calculations to avoid overflow.
1859 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1861 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1862 subtracting pointers.
1863 (gobble_line): Check for overflow more carefully. Don't update size
1866 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1867 Don't update size until alloc done.
1868 Redo size calculations to avoid overflow.
1869 Check for size calculation overflow.
1870 (main) [DEBUG]: Fix typo in invoking tparam1.
1872 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1873 Use ptrdiff_t, not int, for sizes.
1874 (store_mode_line_noprop_char): Don't update size until alloc done.
1876 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1877 Use ptrdiff_t, not int, for sizes.
1878 (Finternal_make_lisp_face, cache_face):
1879 Check for size calculation overflow.
1880 (cache_face): Treat size calculation overflows as if they were
1881 memory exhaustion (the usual treatment), rather than aborting.
1883 * xfns.c (x_encode_text, x_set_name_internal)
1884 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1885 sizes, since they can exceed INT_MAX in size. Check for size
1886 calculation overflow.
1888 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1889 (xg_select): Check for size calculation overflow.
1890 Don't update size until alloc done.
1892 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1893 as sprintf is limited to int lengths.
1895 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1896 (X_LONG_MIN): New macros.
1897 Use them to make the following changes clearer.
1898 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1899 This change doesn't affect the value now, but it may help remind
1900 future maintainers not to raise the value too much later.
1901 (SELECTION_QUANTUM): Remove, replacing with ...
1902 (selection_quantum): ... new function, which avoids overflow.
1904 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1905 assumption that selection length fits in 'int'.
1906 (x_reply_selection_request, x_handle_selection_request)
1907 (x_get_window_property, receive_incremental_selection)
1908 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1909 (lisp_data_to_selection_data, clean_local_selection_data):
1910 Use ptrdiff_t, not int, to record length of selection.
1911 (x_reply_selection_request, x_get_window_property)
1912 (receive_incremental_selection, x_property_data_to_lisp):
1913 Redo calculations to avoid overflow.
1914 (x_reply_selection_request): When sending hint, ceiling it at
1915 X_LONG_MAX rather than relying on wraparound overflow to send
1917 (x_get_window_property, receive_incremental_selection)
1918 (lisp_data_to_selection_data, x_property_data_to_lisp):
1919 Check for size-calculation overflow.
1920 (x_get_window_property, receive_incremental_selection)
1921 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1922 Don't store size until memory allocation succeeds.
1923 (x_get_window_property): Plug memory leak on memory exhaustion.
1924 Don't double-block input; malloc is safe here. Don't assume 2**34
1925 - 4 fits in unsigned long. Add an xassert to check
1926 XGetWindowProperty overflow. Be more careful about overflow
1927 calculations, and distinguish size from memory overflow better.
1928 (receive_incremental_selection): When tracing, don't assume
1929 unsigned int is less than INT_MAX.
1930 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1931 harmful) conversions of unsigned short to int.
1932 (lisp_data_to_selection_data): Don't assume that integers
1933 in the range -65535 through -1 fit in an X unsigned short.
1934 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1935 result parameters unless successful. Rely on cons_to_unsigned
1936 to report problems with elements; the old code wasn't right anyway.
1937 (x_check_property_data): Check for int overflow; we cannot use
1938 a wider type due to X limits.
1939 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1941 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1943 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1944 (x_term_init): Check for size calculation overflow.
1945 (x_color_cells): Don't store size until memory allocation succeeds.
1946 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1947 Don't assume alloca size is less than MAX_ALLOCA.
1948 (x_term_init): Don't assume length fits in int (sprintf is limited
1951 Use ptrdiff_t for composition IDs.
1952 * character.c (lisp_string_width):
1953 * composite.c (composition_table_size, n_compositions)
1954 (get_composition_id, composition_gstring_from_id):
1955 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1956 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1957 * window.c (Frecenter):
1958 Use ptrdiff_t, not int, for composition IDs.
1959 * composite.c (get_composition_id): Check for integer overflow.
1960 * composite.h: Adjust prototypes to match the above changes.
1962 Use ptrdiff_t for hash table indexes.
1963 * category.c (hash_get_category_set):
1964 * ccl.c (ccl_driver):
1965 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1966 * coding.c (coding_system_charset_list, detect_coding_system):
1967 * coding.h (struct coding_system.id):
1968 * composite.c (get_composition_id, gstring_lookup_cache):
1969 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1970 * image.c (xpm_get_color_table_h):
1971 * lisp.h (hash_lookup, hash_put):
1972 * minibuf.c (Ftest_completion):
1973 Use ptrdiff_t for hash table indexes, not int (which is too
1974 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1975 32-bit --with-wide-int hosts).
1977 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1978 Add a FIXME comment about memory leaks.
1979 (syms_of_charset): Don't assume xmalloc returns.
1981 Don't assume that stated character widths fit in int.
1982 * character.c (Fchar_width, c_string_width, lisp_string_width):
1983 * character.h (CHAR_WIDTH):
1984 * indent.c (MULTIBYTE_BYTES_WIDTH):
1985 Use sanitize_char_width to avoid undefined and/or bad behavior
1986 with outlandish widths.
1987 * character.h (sanitize_tab_width): Rename from sanitize_width,
1988 now that we have two such functions. All uses changed.
1989 (sanitize_char_width): New inline function.
1991 Don't assume that tab-width fits in int.
1992 * character.h (sanitize_width): New inline function.
1993 (SANE_TAB_WIDTH): New macro.
1994 (ASCII_CHAR_WIDTH): Use it.
1995 * indent.c (sane_tab_width): Remove. All uses replaced by
1996 SANE_TAB_WIDTH (current_buffer).
1997 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1999 * fileio.c: Integer overflow issues with file modes.
2000 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2002 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2003 Remove unreachable code.
2004 (read_hex, load_charset_map_from_file): Check for integer overflow.
2006 * xterm.c: don't go over XClientMessageEvent limit
2007 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2008 (x_send_scroll_bar_event): Likewise. Check that the size does not
2009 exceed limits imposed by XClientMessageEvent, as well as the usual
2010 ptrdiff_t and size_t limits.
2012 * keyboard.c: Overflow, signedness and related fixes.
2013 (make_lispy_movement): Use same integer type in forward decl
2014 that is used in the definition.
2015 (read_key_sequence, keyremap_step):
2016 Change bufsize argument back to int, undoing my 2011-03-30 change.
2017 We prefer signed types, and int is wide enough here.
2018 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2019 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2020 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2021 length, not size_t. Use ptrdiff_t for index, not int.
2022 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2023 possibility of integer overflow.
2025 Overflow, signedness and related fixes for images.
2027 * dispextern.h (struct it.stack[0].u.image.image_id)
2028 (struct_it.image_id, struct image.id, struct image_cache.size)
2029 (struct image_cache.used, struct image_cache.ref_count):
2030 * gtkutil.c (update_frame_tool_bar):
2031 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2032 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2033 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2034 * nsmenu.m (update_frame_tool_bar):
2035 * xdisp.c (calc_pixel_width_or_height):
2036 * xfns.c (image_cache_refcount):
2037 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2038 on typical 64-bit hosts.
2040 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2041 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2042 Omit unnecessary casts to int.
2043 (parse_image_spec): Check that integers fall into 'int' range
2044 when the callers expect that.
2045 (image_ascent): Redo ascent calculation to avoid int overflow.
2046 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2047 (lookup_image): Remove unnecessary tests.
2048 (xbm_image_p): Locals are now of int, not EMACS_INT,
2049 since parse_image_check makes sure they fit into int.
2050 (png_load, gif_load, svg_load_image):
2051 Prefer int to unsigned where either will do.
2052 (tiff_handler): New function, combining the cores of the
2053 old tiff_error_handler and tiff_warning_handler.
2054 This function is rewritten to use vsnprintf and thereby avoid
2055 stack buffer overflows. It uses only the features of vsnprintf
2056 that are common to both POSIX and native Microsoft.
2057 (tiff_error_handler, tiff_warning_handler): Use it.
2058 (tiff_load, gif_load, imagemagick_load_image):
2059 Don't assume :index value fits in 'int'.
2060 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2061 (imagemagick_load_image): Check that crop parameters fit into
2062 the integer types that MagickCropImage accepts. Don't assume
2063 Vimagemagick_render_type has a nonnegative value. Don't assume
2064 size_t fits in 'long'.
2065 (gs_load): Use printmax_t to print the widest integers possible.
2066 Check for integer overflow when computing image height and width.
2068 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2070 * xdisp.c (redisplay_window): Don't force window start if point
2071 will be invisible in the resulting window. (Bug#9324)
2073 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2075 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2076 the display spec is of the form `(space ...)'.
2077 (handle_display_spec): Return the value returned by
2078 handle_single_display_spec, not just 1 or zero.
2079 (handle_single_display_spec): If the display spec is of the form
2080 `(space ...)', and specifies display in the text area, return 2
2082 (try_cursor_movement): Check for the need to scroll more
2083 accurately, and prefer exact match for point under bidi.
2084 Don't advance `row' beyond the last row of the window.
2086 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2087 into disp_prop; all users changed.
2089 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2090 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2091 for the text covered by the display property.
2093 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2095 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2096 Change return value to nil.
2097 (Frecord_buffer): Delete unused function.
2099 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2101 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2102 buffers, return left-to-right.
2103 (set_cursor_from_row): Consider candidate row a win if its glyph
2104 represents a newline and point is on that newline. Fixes cursor
2105 positioning on the newline at EOL of R2L text within L2R
2106 paragraph, and vice versa.
2107 (try_cursor_movement): Check continued rows, in addition to
2108 continuation rows. Fixes unwarranted scroll when point enters a
2109 continued line of R2L text within an L2R paragraph, or vice versa.
2110 (cursor_row_p): Consider the case of point being equal to
2111 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2112 from the end of a short line to the beginning of a continued line
2113 of R2L text within L2R paragraph.
2114 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2115 composed characters.
2117 * bidi.c (bidi_check_type): Use xassert.
2118 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2121 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2123 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2126 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2128 * nsfont.m (ns_otf_to_script): Fix typo.
2130 2011-08-22 Kenichi Handa <handa@m17n.org>
2132 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2133 extra slot even if the purpose is char-code-property-table.
2135 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2137 * xdisp.c (redisplay_window): When computing centering_position,
2138 account for the height of the header line. (Bug#8874)
2140 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2141 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2142 candidate is selected by the mouse, and that candidate has a
2143 composed character under the mouse.
2145 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2146 coordinates reported by pos-visible-in-window-p for a composed
2147 character in column zero.
2149 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2151 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2153 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2155 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2156 consider it a hit if to_charpos is anywhere in the range of the
2157 composed buffer positions.
2159 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2161 * image.c (gif_load): Don't assume that each subimage has the same
2162 dimensions as the base image. Handle disposal method that is
2163 "undefined" by the gif spec (Bug#9335).
2165 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2167 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2168 (Fcondition_case): Document `debug' symbol in error handler.
2170 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2172 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2173 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2174 from an Org mode buffer to a Speedbar frame.
2176 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2177 a composition, take its buffer position from IT->cmp_it.charpos.
2178 Fixes cursor positioning at the beginning of a line that begins
2179 with a composed character.
2181 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2183 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2184 character bidirectional type, use STRONG_L instead. Fixes crashes
2185 in a buffer produced by `describe-categories'.
2187 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2188 members before the level stack, so they would be saved and
2189 restored when copying iterator state. Fixes incorrect reordering
2190 around TABs covered by display properties.
2192 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2194 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2196 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2198 * eval.c (internal_condition_case, internal_condition_case_1)
2199 (internal_condition_case_2, internal_condition_case_n):
2200 Remove unnecessary aborts (Bug#9081).
2202 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2204 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2205 has no `load' handler, try opening the file locally. (Bug#9311)
2207 2011-08-16 Ken Brown <kbrown@cornell.edu>
2209 * gmalloc.c: Expand comment.
2211 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2213 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2214 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2216 2011-08-16 Ken Brown <kbrown@cornell.edu>
2218 Fix memory allocation problems in Cygwin build (Bug#9273).
2220 * unexcw.c ( __malloc_initialized): Declare external variable.
2221 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2223 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2225 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2227 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2229 [CYGWIN] (special_realloc): New function.
2230 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2231 requests to realloc storage in the static heap.
2233 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2235 * bidi.c (bidi_initialize): Remove unused local.
2237 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2240 * biditype.h: Remove file.
2241 * makefile.w32-in ($(BLD)/bidi.$(O)):
2242 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2244 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2246 * chartab.c: Improve commentary for the uniprop_table API.
2248 * bidi.c (bidi_paragraph_init): Support zero value of
2249 bidi_ignore_explicit_marks_for_paragraph_level.
2250 (bidi_initialize): Use uniprop_table instead of including
2251 biditype.h and bidimirror.h.
2253 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2254 coordinates of the iterator when restoring from ppos_it.
2257 2011-08-14 Kenichi Handa <handa@m17n.org>
2259 * process.c (create_process): Call setup_process_coding_systems
2260 after the pid of the process is set to -1 (Bug#8162).
2262 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2264 * xdisp.c (move_it_in_display_line_to): Don't invoke
2265 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2266 ppos_it. Fixes vertical cursor motion when line beginning is
2267 covered by an image. (Bug#9296)
2269 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2271 * nsterm.h (ns_run_ascript): Declare.
2272 (NSAPP_DATA2_RUNASSCRIPT): Define.
2274 * nsfns.m (as_script, as_result, as_status): New static variables.
2275 (ns_run_ascript): New function.
2276 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2277 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2278 the event loop. Get status from as_status (Bug#7276).
2280 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2281 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2282 the event loop (Bug#7276).
2284 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2286 * gnutls.c (QCgnutls_bootprop_priority)
2287 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2288 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2289 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2290 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2291 (QCgnutls_bootprop_verify_hostname_error)
2292 (QCgnutls_bootprop_callbacks_verify): Rename from
2293 Qgnutls_bootprop_..., all uses changed.
2295 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2298 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2300 * xfaces.c (Qframe_set_background_mode): Now static.
2301 * dispextern.h (Qframe_set_background_mode): Remove decl.
2303 * process.c (Fnetwork_interface_info): Declare local only if needed.
2305 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2307 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2308 (Fnetwork_interface_list): Allocate in increments of bytes instead
2309 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2310 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2312 (struct ifflag_def): notrailers is smart on OSX.
2313 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2314 Get hardware address with getifaddrs if available.
2316 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2318 * xdisp.c (iterate_out_of_display_property): xassert that
2319 IT->position is set to within IT->object's boundaries. Break from
2320 the loop as soon as EOB is reached; avoids infloops in redisplay
2321 when IT->position is set up wrongly due to some bug.
2322 Set IT->current to match the bidi iterator unconditionally.
2323 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2324 entry. Force push_it to save on the stack the current
2325 buffer/string position, to be restored by pop_it. Fix flags in
2326 the iterator structure wrt the object coming from a display
2327 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2328 properties. (Bug#9284)
2330 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2332 * fontset.c (fontset_get_font_group): Add proper type checks.
2335 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2337 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2338 and LC_VERSION_MIN_MACOSX.
2339 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2340 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2342 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2344 * xdisp.c (forward_to_next_line_start): Allow to use the
2345 no-display-properties-and-no-overlays under bidi display.
2346 Set disp_pos in the bidi iterator to avoid searches for display
2347 properties and overlays.
2349 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2351 * editfns.c (Fset_time_zone_rule): Document relationship with the
2354 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2355 the font entity extracted from the cache (Bug#8109).
2357 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2359 * composite.c (autocmp_chars): Don't reset point. That is done by
2360 restore_point_unwind (Bug#5984).
2362 2011-08-07 Juri Linkov <juri@jurta.org>
2364 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2365 to show the arg `TIME' instead of `TIMEVAL'.
2367 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2369 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2370 display property strides EOL and includes a newline, as in
2371 longlines-mode. (Bug#9254)
2372 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2373 word-wrap under bidirectional display. (Bug#9224)
2375 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2376 is non-zero, even if the data buffer is NULL. Fixes a crash in
2377 vertical-motion with longlines-mode. (Bug#9254)
2379 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2381 * bidi.c <bidi_cache_total_alloc>: Now static.
2382 (bidi_initialize): Initialize bidi_cache_total_alloc.
2384 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2387 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2388 amount allocated this far in `bidi_cache_total_alloc'.
2389 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2390 non-zero, only free the data buffer without restoring the cache
2391 contents. All callers changed.
2393 * dispextern.h (bidi_unshelve_cache): Update prototype.
2395 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2396 (move_it_in_display_line, move_it_to)
2397 (move_it_vertically_backward, move_it_by_lines): Replace the call
2398 to xfree to an equivalent call to bidi_unshelve_cache.
2399 (move_it_in_display_line_to): Fix logic of returning
2400 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2402 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2404 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2405 came from a string character with a `cursor' property. (Bug#9229)
2407 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2409 * Makefile.in (LIB_PTHREAD): New variable.
2410 (LIBES): Add LIB_PTHREAD (Bug#9216).
2412 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2413 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2415 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2417 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2419 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2421 * xterm.c (x_find_topmost_parent): New function.
2422 (x_set_frame_alpha): Find topmost parent window with
2423 x_find_topmost_parent and set the property there also (bug#9181).
2424 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2426 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2428 * callproc.c (Fcall_process): Avoid vfork clobbering
2429 the local vars buffer, coding_systems, current_dir.
2431 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2433 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2435 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2437 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2438 so that it is not optimized away.
2440 * xdisp.c (compute_display_string_pos): Remove unused local.
2442 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2444 Fix slow cursor motion and scrolling in large buffers with
2445 selective display, like Org Mode buffers. (Bug#9218)
2447 * dispextern.h (struct bidi_it): New member disp_prop_p.
2449 * xdisp.c: Remove one-slot cache of display string positions.
2450 (compute_display_string_pos): Accept an additional argument
2451 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2452 for a display string or property. If found, set DISP_PROP_P
2455 * bidi.c (bidi_fetch_char): Accept an additional argument
2456 DISP_PROP_P, and pass it to compute_display_string_pos.
2457 Only handle text covered by a display string if DISP_PROP_P is returned
2458 non-zero. All callers of bidi_fetch_char changed.
2460 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2462 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2464 2010-12-03 Don March <don@ohspite.net>
2466 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2467 last character M-[char] is translated to ESC [char] (bug#7541).
2469 2011-08-02 Kenichi Handa <handa@m17n.org>
2471 * lisp.h (uniprop_table): Extern it.
2473 * chartab.c (uniprop_table): Make it non-static.
2475 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2477 * xdisp.c (forward_to_next_line_start): Accept additional argument
2478 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2480 (reseat_at_next_visible_line_start): Use the bidi iterator state
2481 returned by forward_to_next_line_start to restore the state of
2482 it->bidi_it after backing up to previous newline. (Bug#9212)
2484 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2486 * regex.c (re_comp): Protoize.
2487 (re_exec): Fix return type.
2488 (regexec): Fix type of `ret'. (Bug#9203)
2490 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2492 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2493 This is needed if max-image-size is a floating-point number.
2495 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2497 * print.c (print_object): Print empty symbol as ##.
2499 * lread.c (read1): Read ## as empty symbol.
2501 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2503 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2504 setting frame foreground color (Bug#9175).
2505 (x_set_background_color): Likewise.
2507 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2508 contents (Bug#9176).
2509 (EmacsTooltip -init): Remove bezels and add shadows to
2512 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2513 or scroll bar (Bug#8470).
2515 * nsfont.m (nsfont_open): Remove assignment to voffset and
2516 unnecessary vars hshink, expand, hd, full_height, min_height.
2517 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2519 * nsterm.h (nsfont_info): Remove voffset field.
2521 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2523 Implement strike-through and overline on NextStep (Bug#8863).
2525 * nsfont.m (nsfont_open): Use underline position provided by font,
2526 instead of hard-coded value of 2.
2527 (nsfont_draw): Call ns_draw_text_decoration instead.
2529 * nsterm.h: Add declaration for ns_draw_text_decoration.
2531 * nsterm.m (ns_draw_text_decoration): New function for drawing
2532 underline, overline, and strike-through.
2533 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2534 ns_draw_text_decoration. Change treatment of cursor drawing to
2535 accommodate underlining, etc.
2537 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2539 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2542 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2544 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2545 Without this fix, if a signal arrives just after memory fills up,
2546 'malloc' might be invoked reentrantly.
2548 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2549 In other words, assume that every image size is allowed, on non-X
2550 hosts. This assumption is probably wrong, but it lets Emacs compile.
2552 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2554 * regex.c (re_iswctype): Convert return values to boolean.
2556 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2558 * xdisp.c (compute_display_string_pos): Don't use cached display
2559 string position if the buffer had its restriction changed.
2562 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2564 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2566 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2568 Integer signedness and overflow and related fixes. (Bug#9079)
2570 * bidi.c: Integer size and overflow fixes.
2571 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2572 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2573 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2574 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2575 (bidi_find_other_level_edge):
2576 Use ptrdiff_t instead of EMACS_INT where either will do.
2577 This works better on 32-bit hosts configured --with-wide-int.
2578 (bidi_cache_ensure_space): Check for size-calculation overflow.
2579 Use % rather than repeated addition, for better worst-case speed.
2580 Don't set bidi_cache_size until after xrealloc returns, because it
2582 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2583 (bidi_cache_ensure_space): Also check that the bidi cache size
2584 does not exceed that of the largest Lisp string or buffer. See Eli
2585 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2587 * alloc.c (__malloc_size_t): Remove.
2588 All uses replaced by size_t. See Andreas Schwab's note
2589 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2591 * image.c: Improve checking for integer overflow.
2592 (check_image_size): Assume that f is nonnull, since
2593 it is always nonnull in practice. This is one less thing to
2594 worry about when checking for integer overflow later.
2595 (x_check_image_size): New function, which checks for integer
2596 overflow issues inside X.
2597 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2598 This removes the need for a memory_full check.
2599 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2600 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2601 (xbm_read_bitmap_data): Change locals back to 'int', since
2602 their values must fit in 'int'.
2603 (xpm_load_image, png_load, tiff_load):
2604 Invoke x_create_x_image_and_pixmap earlier,
2605 to avoid much needless work if the image is too large.
2606 (tiff_load): Treat overly large images as if
2607 x_create_x_image_and_pixmap failed, not as malloc failures.
2608 (gs_load): Use x_check_image_size.
2610 * gtkutil.c: Omit integer casts.
2611 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2612 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2614 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2616 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2617 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2618 would wrongly return t on a 64-bit host.
2620 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2621 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2622 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2623 and therefore cause GCC to emit a bogus diagnostic in some cases.
2625 * image.c: Integer signedness and overflow and related fixes.
2626 This is not an exhaustive set of fixes, but it's time to
2627 record what I've got.
2628 (lookup_pixel_color, check_image_size): Remove redundant decls.
2629 (check_image_size): Don't assume that arbitrary EMACS_INT values
2630 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2631 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2632 (tiff_load, imagemagick_load_image):
2633 Check for overflow in size calculations.
2634 (x_create_x_image_and_pixmap): Remove unnecessary test for
2635 xmalloc returning NULL; that can't happen.
2636 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2637 (xpm_color_bucket): Use better integer hashing function.
2638 (xpm_cache_color): Don't possibly over-allocate memory.
2639 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2640 (gif_memory_source):
2641 Use ptrdiff_t, not int or size_t, to record sizes.
2642 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2643 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2644 either works, as we prefer signed integers.
2645 (tiff_read_from_memory, tiff_write_from_memory):
2646 Return tsize_t, not size_t, since that's what the TIFF API wants.
2647 (tiff_read_from_memory): Don't fail simply because the read would
2648 go past EOF; instead, return a short read.
2649 (tiff_load): Omit no-longer-needed casts.
2650 (Fimagemagick_types): Don't assume size fits into 'int'.
2652 Improve hashing quality when configured --with-wide-int.
2653 * fns.c (hash_string): New function, taken from sxhash_string.
2654 Do not discard information about ASCII character case; this
2655 discarding is no longer needed.
2656 (sxhash-string): Use it. Change sig to match it. Caller changed.
2657 * lisp.h: Declare it.
2658 * lread.c (hash_string): Remove, since we now use fns.c's version.
2659 The fns.c version returns a wider integer if --with-wide-int is
2660 specified, so this should help the quality of the hashing a bit.
2662 * emacs.c: Integer overflow minor fix.
2663 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2664 Define only if GNU_LINUX.
2665 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2667 * dispnew.c: Integer signedness and overflow fixes.
2668 Remove unnecessary forward decls, that were a maintenance hassle.
2669 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2671 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2672 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2673 (prepare_desired_row, line_draw_cost):
2674 Use int, not unsigned, where either works.
2675 (save_current_matrix, restore_current_matrix):
2676 Use ptrdiff_t, not size_t, where either works.
2677 (init_display): Check for overflow more accurately, and without
2678 relying on undefined behavior.
2680 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2681 Remove, replacing with the new symbols in lisp.h. All uses changed.
2682 * fileio.c (make_temp_name):
2683 * filelock.c (lock_file_1, lock_file):
2684 * xdisp.c (message_dolog):
2685 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2686 Use pMd etc. instead.
2687 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2688 replacing the pWIDE etc. symbols removed from editfns.c.
2690 * keyboard.h (num_input_events): Now uintmax_t.
2691 This is (very slightly) less likely to mess up due to wraparound.
2694 * buffer.c: Integer signedness fixes.
2695 (alloc_buffer_text, enlarge_buffer_text):
2696 Use ptrdiff_t rather than size_t when either will do, as we prefer
2699 * alloc.c: Integer signedness and overflow fixes.
2700 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2701 (__malloc_size_t): Default to size_t, not to int.
2702 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2703 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2704 Prefer ptrdiff_t to size_t when either would do, as we prefer
2706 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2707 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2708 Now const. Initialize with values that are in range even if char
2710 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2711 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2712 These functions do the right thing with sizes > 2**32.
2713 (check_depth): Now ptrdiff_t, not int.
2714 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2715 Adjust to new way of storing sizes. Check for size overflow bugs
2717 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2718 slightly wrong anyway, as it missed one instance of
2719 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2720 (refill_memory_reserve): Omit needless cast to size_t.
2721 (mark_object_loop_halt): Mark as externally visible.
2723 * xselect.c: Integer signedness and overflow fixes.
2724 (Fx_register_dnd_atom, x_handle_dnd_message):
2725 Use ptrdiff_t, not size_t, since we prefer signed.
2726 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2727 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2728 x_dnd_atoms_size and x_dnd_atoms_length.
2730 * doprnt.c: Prefer signed to unsigned when either works.
2732 * doprnt.c (doprnt):
2734 * xdisp.c (vmessage):
2735 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2736 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2737 prefer signed arithmetic to avoid comparison confusion.
2738 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2739 but is a bit tricky.
2741 Assume freestanding C89 headers, string.h, stdlib.h.
2742 * data.c, doprnt.c, floatfns.c, print.c:
2743 Include float.h unconditionally.
2744 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2745 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2746 * regex.c: Likewise for stddef.h, string.h.
2747 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2748 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2749 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2750 (STDC_HEADERS): Remove obsolete defines.
2751 * sysdep.c: Include limits.h unconditionally.
2753 Assume support for memcmp, memcpy, memmove, memset.
2754 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2755 * regex.c (memcmp, memcpy):
2756 Remove; we assume C89 now.
2758 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2759 (__malloc_safe_bcopy): Remove; no longer needed.
2761 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2762 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2763 well either way, and we prefer signed to unsigned.
2765 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2767 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2768 closes the connection while we're reading (bug#9182).
2770 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2772 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2773 are specified (Bug#9168).
2775 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2777 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2778 Found by GCC static checking and --with-wide-int on a 32-bit host.
2780 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2782 * xdisp.c (compute_display_string_pos): Fix logic of caching
2783 previous display string position. Initialize cached_prev_pos to
2784 -1. Fixes slow-down at the beginning of a buffer.
2786 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2788 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2789 for attrs[LFACE_FONTSET_INDEX].
2791 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2793 * xml.c (parse_region): Remove unused local
2794 that was recently introduced.
2796 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2798 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2799 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2801 * xdisp.c (move_it_in_display_line_to): Record the best matching
2802 position for TO_CHARPOS while scanning the line, and restore it on
2803 exit if none of the characters scanned was an exact match.
2804 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2805 when exact match is impossible due to invisible text, and the
2806 lines are truncated.
2808 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2810 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2813 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2815 Fix a significant slow-down of cursor motion with C-n, C-p,
2816 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2817 auto-repeat under bidi redisplay in fontified buffers.
2818 * xdisp.c (compute_stop_pos_backwards): New function.
2819 (next_element_from_buffer): Call compute_stop_pos_backwards to
2820 find a suitable prev_stop when we find ourselves before
2822 (reseat): Don't look for prev_stop, as that could mean a very long
2824 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2825 <cached_disp_overlay_modiff>: Cache for last found display string
2827 (compute_display_string_pos): Return the cached position if asked
2828 about the same buffer in the same area of character positions, and
2829 the buffer wasn't changed since the time the display string
2830 position was cached.
2832 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2834 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2835 is an integer, which is important for empty lines. (Bug#9149)
2837 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2839 * frame.c (Fmodify_frame_parameters): In tty case, update the
2840 default face if necessary (Bug#4238).
2842 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2844 * editfns.c (Fstring_to_char): No need to explain what a character
2845 is in the docstring (Bug#6576).
2847 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2849 * xml.c (parse_region): Make sure we always return a tree.
2851 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2853 * xml.c (parse_region): If a document contains only comments,
2856 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2858 * xml.c (make_dom): Return comments, too.
2860 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2863 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2864 and the surrounding thread.
2865 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2866 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2867 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2869 * s/openbsd.h (BROKEN_SIGIO): Define.
2870 * unexelf.c (unexec) [__OpenBSD__]:
2871 Don't update the .mdebug section of the Alpha COFF symbol table.
2873 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2875 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2878 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2880 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2881 This fixes some race conditions on the permissions of any newly
2884 * alloc.c (valid_pointer_p): Use pipe, not open.
2885 This fixes some permissions issues when debugging.
2887 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2888 If fchown fails to set both uid and gid, try to set just gid,
2889 as that is sometimes allowed. Adjust the file's mode to eliminate
2890 setuid or setgid bits that are inappropriate if fchown fails.
2892 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2894 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2895 to compare Lisp_Objects.
2896 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2897 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2898 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2900 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2902 * lread.c (read_integer): Unread even EOF character.
2903 (read1): Likewise. Properly record start position of symbol.
2905 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2906 symbol character follows.
2908 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2910 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2911 This works around a problem with the previous change to Fcopy_file.
2912 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2913 and without this change, GCC might complain about discarding
2914 fchown's return value.
2916 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2918 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2920 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2922 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2924 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2926 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2927 it's used from the C level.
2929 * process.c: Use the same condition for POLL_FOR_INPUT in both
2930 keyboard.c and process.c (bug#1858).
2932 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2934 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2935 (Fgnutls_boot): Use it.
2937 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2939 * doc.c (Fsubstitute_command_keys): Revert last change.
2941 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2943 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2944 quotes the next character, and doesn't affect other longer
2945 sequences (bug#8935).
2947 * lread.c (syms_of_lread): Clarify that is isn't only
2948 `eval-buffer' and `eval-defun' that's affected by
2949 `lexical-binding' (bug#8460).
2951 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2953 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2954 bidi redisplay when a line includes both an image and is truncated.
2956 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2958 Fix minor problems found by static checking.
2959 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2960 (elsz): Now a signed constant, not a size_t var. We prefer signed
2961 types to unsigned, to avoid integer comparison confusion. Without
2962 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2963 "cannot optimize loop, the loop counter may overflow", a symptom
2965 * indent.c (Fvertical_motion): Mark locals as initialized.
2966 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2968 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2970 * search.c (Fre_search_backward): Mention `case-fold-search' in
2971 all the re_search_* functions (bug#8138).
2973 * keyboard.c (Fopen_dribble_file): Document when the file is
2976 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2978 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2981 Support bidi reordering of display and overlay strings.
2982 * xdisp.c (compute_display_string_pos)
2983 (compute_display_string_end): Accept additional argument STRING.
2984 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2985 (reseat_to_string): Initialize bidi_it->string.s and
2986 bidi_it->string.schars.
2987 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2988 NULL (avoids a crash in bidi_paragraph_init).
2989 Initialize itb.string.lstring.
2990 (init_iterator): Call bidi_init_it only of a valid
2991 buffer position was specified. Initialize paragraph_embedding to
2993 (reseat_to_string): Initialize the bidi iterator.
2994 (display_string): If we need to ignore text properties of
2995 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2996 original value of -1 will not work with bidi.)
2997 (compute_display_string_pos): First arg is now struct
2998 `text_pos *'; all callers changed. Support display properties on
3000 (compute_display_string_end): Support display properties on Lisp
3002 (init_iterator, reseat_1, reseat_to_string): Initialize the
3003 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3004 when iterating on a string not from display properties).
3005 (compute_display_string_pos, compute_display_string_end):
3006 Fix calculation of the object to scan. Fixes an error when using
3008 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3009 base_level_stop; instead, set base_level_stop to BEGV.
3010 Fixes crashes in vertical-motion.
3011 (next_element_from_buffer): Improve commentary for when
3012 the iterator is before prev_stop.
3013 (init_iterator): Initialize bidi_p from the default value of
3014 bidi-display-reordering, not from buffer-local value. Use the
3015 buffer-local value only if initializing for buffer iteration.
3016 (handle_invisible_prop): Support invisible properties on strings
3017 that are being bidi-reordered.
3018 (set_iterator_to_next): Support bidi reordering of C strings and
3020 (next_element_from_string): Support bidi reordering of Lisp
3022 (handle_stop_backwards): Support Lisp strings as well.
3023 (display_string): Support display of R2L glyph rows.
3024 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3025 (init_iterator): Don't initialize it->bidi_p for strings
3027 (reseat_to_string): Initialize it->bidi_p for strings here.
3028 (next_element_from_string, next_element_from_c_string)
3029 (next_element_from_buffer): Add xassert's for correspondence
3030 between IT's object being iterated and it->bidi_it.string
3032 (face_before_or_after_it_pos): Support bidi iteration.
3033 (next_element_from_c_string): Handle the case of the first string
3034 character that is not the first one in the visual order.
3035 (get_visually_first_element): New function, refactored from common
3036 parts of next_element_from_buffer, next_element_from_string, and
3037 next_element_from_c_string.
3038 (tool_bar_lines_needed, redisplay_tool_bar)
3039 (display_menu_bar): Force left-to-right direction. Add a FIXME
3040 comment for making that be controlled by a user option.
3041 (push_it, pop_it): Save and restore the state of the
3042 bidi iterator. Save and restore the bidi_p flag.
3043 (pop_it): Iterate out of display property for string iteration as
3045 (iterate_out_of_display_property): Support iteration over strings.
3046 (handle_single_display_spec): Set up it->bidi_it for iteration
3047 over a display string, and call bidi_init_it.
3048 (handle_single_display_spec, next_overlay_string)
3049 (get_overlay_strings_1, push_display_prop): Set up the bidi
3050 iterator for displaying display or overlay strings.
3051 (forward_to_next_line_start): Don't use the shortcut if
3053 (back_to_previous_visible_line_start): If handle_display_prop
3054 pushed the iterator stack, restore the internal state of the bidi
3055 iterator by calling bidi_pop_it same number of times.
3056 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3057 and we are bidi-iterating, don't decrement the iterator position;
3058 instead, set the first_elt flag in the bidi iterator, to produce
3060 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3061 (push_display_prop): xassert that we are iterating a buffer.
3062 (push_it, pop_it): Save and restore paragraph_embedding member.
3063 (handle_single_display_spec, next_overlay_string)
3064 (get_overlay_strings_1, reseat_1, reseat_to_string)
3065 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3066 correctly. Don't assume unibyte strings are not bidi-reordered.
3067 (compute_display_string_pos)
3068 (compute_display_string_end): Fix handling the case of C string.
3069 (push_it, pop_it): Save and restore from_disp_prop_p.
3070 (handle_single_display_spec, push_display_prop): Set the
3071 from_disp_prop_p flag.
3072 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3073 (pop_it): Call iterate_out_of_display_property only if we are
3074 popping after iteration over a string that came from a display
3075 property. Fix a typo in popping stretch info. Add an assertion
3076 for verifying that the iterator position is in sync with the bidi
3078 (handle_single_display_spec, get_overlay_strings_1)
3079 (push_display_prop): Fix initialization of paragraph direction for
3080 string when that of the parent object is not yet determined.
3081 (reseat_1): Call bidi_init_it to resync the bidi
3082 iterator with IT's position. (Bug#7616)
3083 (find_row_edges): If ROW->start.pos gives position
3084 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3085 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3086 Reset the from_disp_prop_p flag.
3087 (SAVE_IT, RESTORE_IT): New macros.
3088 (pos_visible_p, face_before_or_after_it_pos)
3089 (back_to_previous_visible_line_start)
3090 (move_it_in_display_line_to, move_it_in_display_line)
3091 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3092 (try_scrolling, redisplay_window, display_line): Use them when
3093 saving a temporary copy of the iterator and restoring it back.
3094 (back_to_previous_visible_line_start, reseat_1)
3095 (init_iterator): Empty the bidi cache "stack".
3096 (move_it_in_display_line_to): If iterator ended up at
3097 EOL, but we never saw any buffer positions smaller than
3098 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3099 motion in bidi-reordered lines.
3100 (move_it_in_display_line_to): Record prev_method and prev_pos
3101 immediately before the call to set_iterator_to_next. Fixes cursor
3102 motion in bidi-reordered lines with stretch glyphs and strings
3103 displayed in margins. (Bug#8133) (Bug#8867)
3104 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3106 (pos_visible_p): Support positions in bidi-reordered lines.
3107 Save and restore bidi cache.
3109 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3110 (bidi_paragraph_info): Delete unused struct.
3111 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3112 (bidi_cache_start): New variable.
3113 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3115 (bidi_cache_fetch_state, bidi_cache_search)
3116 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3117 (bidi_cache_find, bidi_peek_at_next_level)
3118 (bidi_level_of_next_char, bidi_find_other_level_edge)
3119 (bidi_move_to_visually_next): Compare cache index with
3120 bidi_cache_start rather than with zero.
3121 (bidi_fetch_char): Accept new argument STRING; all callers
3122 changed. Support iteration over a string. Support strings with
3123 display properties. Support unibyte strings. Fix the type of
3124 `len' according to what STRING_CHAR_AND_LENGTH expects.
3125 (bidi_paragraph_init, bidi_resolve_explicit_1)
3126 (bidi_resolve_explicit, bidi_resolve_weak)
3127 (bidi_level_of_next_char, bidi_move_to_visually_next):
3128 Support iteration over a string.
3129 (bidi_set_sor_type, bidi_resolve_explicit_1)
3130 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3131 can now be zero (for strings); special values 0 and -1 were
3132 changed to -1 and -2, respectively.
3133 (bidi_char_at_pos): New function.
3134 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3135 Call it instead of FETCH_MULTIBYTE_CHAR.
3136 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3137 initialized to valid values.
3138 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3140 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3141 the test for valid cached positions. Fix the logic for looking up
3142 the sentinel state in the cache. GCPRO the Lisp string we are
3144 (bidi_push_it, bidi_pop_it): New functions.
3145 (bidi_initialize): Initialize the bidi cache start stack pointer.
3146 (bidi_cache_ensure_space): New function, refactored from part of
3147 bidi_cache_iterator_state. Don't assume the required size is just
3148 one BIDI_CACHE_CHUNK away.
3149 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3150 (bidi_count_bytes, bidi_char_at_pos): New functions.
3151 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3152 always valid if bidi_cache_idx is valid.
3153 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3154 is valid if it's going to be used.
3155 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3156 (bidi_cache_fetch_state, bidi_cache_search)
3157 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3158 (bidi_cache_iterator_state, bidi_cache_find)
3159 (bidi_find_other_level_edge, bidi_cache_start_stack):
3160 All variables related to cache indices are now EMACS_INT.
3162 * dispextern.h (struct bidi_string_data): New structure.
3163 (struct bidi_it): New member `string'. Make flag members be 1-bit
3164 fields, and put them last in the struct.
3165 (compute_display_string_pos, compute_display_string_end):
3167 (bidi_push_it, bidi_pop_it): Add prototypes.
3168 (struct iterator_stack_entry): New members bidi_p,
3169 paragraph_embedding, and from_disp_prop_p.
3170 (struct it): Member bidi_p is now a bit field 1 bit wide.
3171 (bidi_shelve_cache, bidi_unshelve_cache):
3174 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3175 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3176 and vector-like objects.
3178 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3179 cache around display iteration.
3181 * window.c (Fwindow_end, window_scroll_pixel_based)
3182 (displayed_window_lines, Frecenter): Save and restore the bidi
3183 cache around display iteration.
3185 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3187 * editfns.c (Fdelete_region): Clarify the use of the named
3188 parameters (bug#6788).
3190 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3192 * indent.c (Fvertical_motion): Set and restore w->pointm when
3193 saving and restoring the window's buffer (Bug#9006).
3195 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3197 * editfns.c (Fstring_to_char): Clarify just what is returned
3198 (bug#6576). Text by Eli Zaretskii.
3200 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3202 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3204 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3206 * buffer.c (mmap_find): Fix a typo.
3208 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3210 Fix execution of x selection hooks.
3211 * xselect.c (Qx_lost_selection_functions)
3212 (Qx_sent_selection_functions): New vars.
3213 (syms_of_xselect): DEFSYM them.
3214 (x_handle_selection_request): Pass Qx_sent_selection_functions
3215 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3216 (x_handle_selection_clear,x_clear_frame_selections):
3217 Pass Qx_lost_selection_functions rather than
3218 Vx_lost_selection_functions to Frun_hook_with_args.
3220 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3222 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3223 The old code sometimes used this field without initializing it.
3225 * alloc.c (gc_sweep): Don't read past end of array.
3226 In theory, the old code could also have corrupted Emacs internals,
3227 though it'd be very unlikely.
3229 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3231 * character.c (Fcharacterp): Don't advertise optional ignored
3232 argument. (Bug#4026)
3234 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3236 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3239 * window.c (Fset_window_start): Doc fix (bug#4199).
3240 (Fset_window_hscroll): Ditto.
3242 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3244 Fix minor new problems caught by GCC 4.6.1.
3245 * term.c (init_tty): Remove unused local.
3246 * xsettings.c (store_monospaced_changed): Define this function only
3247 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3250 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3252 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3254 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3256 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3257 are the mini-buffer and the echo area (bug#3320).
3259 * term.c (init_tty): Remove support for supdup, c10 and perq
3260 terminals, which are no longer supported (bug#1482).
3262 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3264 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3266 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3268 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3269 for non-popups (Bug#3642).
3271 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3273 * alloc.c (reset_malloc_hooks): Protoize.
3274 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3275 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3276 * cm.c (losecursor): Likewise.
3277 * data.c (fmod): Likewise.
3278 * dispnew.c (swap_glyphs_in_rows): Likewise.
3279 * emacs.c (memory_warning_signal): Likewise.
3280 * floatfns.c (float_error): Likewise.
3281 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3282 (otf_open, font_otf_capability, generate_otf_features)
3283 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3285 * image.c (pbm_read_file): Likewise.
3286 * indent.c (string_display_width): Likewise.
3287 * intervals.c (check_for_interval, search_for_interval)
3288 (inc_interval_count, count_intervals, root_interval)
3289 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3290 * lread.c (defalias): Likewise.
3291 * ralloc.c (r_alloc_check): Likewise.
3292 * regex.c (set_image_of_range_1, set_image_of_range)
3293 (regex_grow_registers): Likewise.
3294 * sysdep.c (strerror): Likewise.
3295 * termcap.c (valid_filename_p, tprint, main): Likewise.
3296 * tparam.c (main): Likewise.
3297 * unexhp9k800.c (run_time_remap, save_data_space)
3298 (update_file_ptrs, read_header, write_header, calculate_checksum)
3299 (copy_file, copy_rest, display_header): Likewise.
3300 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3302 * xdisp.c (check_it): Likewise.
3303 * xfaces.c (register_color, unregister_color, unregister_colors):
3305 * xfns.c (print_fontset_result): Likewise.
3306 * xrdb.c (member, fatal, main): Likewise.
3308 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3310 Fix minor problems found by static checking (Bug#9031).
3311 * chartab.c (char_table_set_range, map_sub_char_table):
3312 Remove unused locals.
3313 (uniprop_table): Now static.
3314 * composite.c (_work_char): Remove unused static var.
3316 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3318 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3320 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3322 * gtkutil.c (qttip_cb): Remove code without function.
3324 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3326 * w32.c (pthread_sigmask): New stub.
3328 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3330 Use pthread_sigmask, not sigprocmask (Bug#9010).
3331 sigprocmask is portable only for single-threaded applications, and
3332 Emacs can be multi-threaded when it uses GTK.
3333 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3335 * callproc.c (Fcall_process):
3336 * process.c (create_process):
3337 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3338 Use pthread_sigmask, not sigprocmask.
3340 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3342 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3343 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3346 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3348 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3349 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3350 (xg_hide_tooltip): Fix comment.
3352 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3353 in registerServicesMenuSendTypes.
3354 (validRequestorForSendType): Don't check ns_return_types.
3356 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3359 2011-07-08 Jason Rumney <jasonr@gnu.org>
3361 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3362 frame struct members of non-existent frames (Bug#6284).
3364 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3366 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3367 variable firstTime not needed on OSX >= 10.6.
3368 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3369 >= 10.5. Use setKnobProportion, setDoubleValue.
3371 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3372 (MAC_OS_X_VERSION_10_5): Define if not defined.
3373 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3374 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3375 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3377 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3378 cString and lossyCString on OSX >= 10.4
3380 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3381 sizeToFit on OSX >= 10.2.
3383 * nsimage.m (allocInitFromFile): Don't use deprecated method
3384 bestRepresentationForDevice on OSX >= 10.6.
3386 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3389 * emacs.c: Declare unexec_init_emacs_zone.
3391 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3393 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3395 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3396 on svcsMenu (Bug#8842).
3398 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3400 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3402 * nsterm.m (QUTF8_STRING): Declare.
3403 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3404 (validRequestorForSendType): Return type is (id).
3405 Change indexOfObjectIdenticalTo to indexOfObject.
3406 Check if we have local selection before returning self (Bug#8842).
3407 (writeSelectionToPasteboard): Put local selection into paste board
3408 if we have a local selection (Bug#8842).
3409 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3411 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3412 (ns_get_local_selection): Declare.
3414 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3416 * keymap.c (describe_map_tree): Don't insert a double newline at
3417 the end of the buffer (bug#1169) and return whether we inserted
3420 * callint.c (Fcall_interactively): Change "reading args" to
3421 "providing args" to try to clarify what it does (bug#1010).
3423 2011-07-07 Kenichi Handa <handa@m17n.org>
3425 * composite.c (composition_compute_stop_pos): Ignore a static
3426 composition starting before CHARPOS (Bug#8915).
3428 * xdisp.c (handle_composition_prop): Likewise.
3430 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3432 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3435 2011-07-07 Kenichi Handa <handa@m17n.org>
3437 * character.h (unicode_category_t): New enum type.
3439 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3440 (Qchar_code_property_table): New variable.
3441 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3442 (UNIPROP_COMPRESSED_FORM_P): New macros.
3443 (char_table_ascii): Uncompress the compressed values.
3444 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3445 Uncompress the compressed values.
3446 (sub_char_table_ref_and_range): Likewise.
3447 (char_table_ref_and_range): Uncompress the compressed values.
3448 (sub_char_table_set): New arg is_uniprop. Callers changed.
3449 Uncompress the compressed values.
3450 (sub_char_table_set_range): Args changed. Callers changed.
3451 (char_table_set_range): Adjuted for the above change.
3452 (map_sub_char_table): Delete args default_val and parent. Add arg
3453 top. Give decoded values to a Lisp function.
3454 (map_char_table): Adjust for the above change. Give decoded
3455 values to a Lisp function. Gcpro more variables.
3456 (uniprop_table_uncompress)
3457 (uniprop_decode_value_run_length): New functions.
3458 (uniprop_decoder, uniprop_decoder_count): New variables.
3459 (uniprop_get_decoder, uniprop_encode_value_character)
3460 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3462 (uniprop_encoder, uniprop_encoder_count): New variables.
3463 (uniprop_get_encoder, uniprop_table)
3464 (Funicode_property_table_internal, Fget_unicode_property_internal)
3465 (Fput_unicode_property_internal): New functions.
3466 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3467 Sunicode_property_table_internal, Sget_unicode_property_internal,
3468 and Sput_unicode_property_internal. Defvar_lisp
3469 char-code-property-alist.
3471 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3472 Vunicode_category_table.
3474 * font.c (font_range): Adjust for the change of
3475 Vunicode_category_table.
3477 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3479 * m/iris4d.h: Remove file, move contents ...
3480 * s/irix6-5.h: ... here.
3482 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3484 Remove unportable assumption about struct layout (Bug#8884).
3485 * alloc.c (mark_buffer):
3486 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3487 (clone_per_buffer_values): Don't assume that
3488 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3489 This isn't true in general, and it's particularly not true
3490 if Emacs is configured with --with-wide-int.
3491 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3492 New macros, used in the buffer.c change.
3494 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3496 * xsettings.c: Use both GConf and GSettings if both are available.
3497 (store_config_changed_event): Add comment.
3498 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3499 (store_tool_bar_style_changed): New functions.
3500 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3501 (struct xsettings): Move font inside HAVE_XFT.
3502 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3503 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3504 Move inside HAVE_XFT.
3505 (something_changed_gsettingsCB): Rename from something_changedCB.
3506 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3508 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3509 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3510 (something_changed_gconfCB): Rename from something_changedCB.
3511 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3512 (parse_settings): Move check for font inside HAVE_XFT.
3513 (read_settings, apply_xft_settings): Add comment.
3514 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3515 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3516 call store_font_name_changed.
3517 (xft_settings_event): Add comment.
3518 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3519 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3520 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3521 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3522 (xsettings_initialize): Call init_gsettings last.
3523 (xsettings_get_system_font, xsettings_get_system_normal_font):
3526 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3528 Random fixes. E.g., (random) never returned negative values.
3529 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3530 subseconds part to the entropy, as that's a bit more random.
3531 Prefer signed to unsigned, since the signedness doesn't matter and
3532 in general we prefer signed. When given a limit, use a
3533 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3534 latter isn't right if USE_2_TAGS_FOR_INTS.
3535 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3536 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3538 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3540 * textprop.c (text_property_stickiness):
3541 Obey Vtext_property_default_nonsticky.
3542 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3543 * w32fns.c (syms_of_w32fns):
3544 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3546 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3548 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3549 This is more efficient than Ffile_directory_p and avoids a minor race.
3551 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3553 * buffer.c (Foverlay_put): Say what the return value is
3556 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3557 is a directory before asking whether to use the file name
3559 (barf_or_query_if_file_exists): Make the "File is a directory"
3560 error be more correct.
3562 * fns.c (Frequire): Remove the mention of the .gz files, since
3563 that's installation-specific, but keep the mention of
3564 `get-load-suffixes'.
3566 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3568 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3569 Report string overflow if the output is too long.
3571 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3573 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3574 (syms_of_gnutls): Remove duplicate DEFSYM for
3575 Qgnutls_bootprop_verify_hostname_error, an error for
3576 Qgnutls_bootprop_verify_error (which is no longer used).
3578 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3579 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3580 Also (re)move comments that are misplaced or no longer relevant.
3582 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3584 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3586 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3588 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3589 and background color parameters if they have been changed.
3591 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3593 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3595 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3597 * xsettings.c (SYSTEM_FONT): Define only when used.
3598 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3600 * keymap.c (access_keymap_1): Now static.
3602 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3604 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3605 leave any prefix arg for the up event (Bug#1586).
3607 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3609 * lread.c (syms_of_lread): Mention single symbols defined by
3610 `defvar' or `defconst' (bug#7154).
3612 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3613 (Frequire): Mention get-load-suffixes.
3615 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3617 * window.h (window): Remove clone_number slot.
3618 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3620 (make_parent_window, make_window, saved_window)
3621 (Fset_window_configuration, save_window_save): Don't deal with
3623 * buffer.c (Qclone_number): Remove declaration.
3624 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3626 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3628 Add multiple inheritance to keymaps.
3629 * keymap.c (Fmake_composed_keymap): New function.
3630 (Fset_keymap_parent): Simplify.
3631 (fix_submap_inheritance): Remove.
3632 (access_keymap_1): New function extracted from access_keymap to handle
3633 embedded parents and handle lists of maps.
3634 (access_keymap): Use it.
3635 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3636 (Fcopy_keymap): Handle embedded parents.
3637 (Fcommand_remapping, define_as_prefix): Simplify.
3638 (Fkey_binding): Simplify.
3639 (syms_of_keymap): Move minibuffer-local-completion-map,
3640 minibuffer-local-filename-completion-map,
3641 minibuffer-local-must-match-map, and
3642 minibuffer-local-filename-must-match-map to Elisp.
3643 (syms_of_keymap): Defsubr make-composed-keymap.
3644 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3645 (parse_menu_item): Trivial simplification.
3647 2011-07-01 Glenn Morris <rgm@gnu.org>
3649 * Makefile.in (SETTINGS_LIBS): Fix typo.
3651 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3653 * coding.c (Fencode_coding_string): Record the last coding system
3654 used, as the function doc string says (bug#8738).
3656 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3658 * xsettings.c (store_monospaced_changed): Take new font as arg and
3659 check for change against current_mono_font.
3660 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3661 (emacs_settings_constructor, emacs_settings_get_property)
3662 (emacs_settings_set_property, emacs_settings_class_init)
3663 (emacs_settings_init, gsettings_obj): Remove.
3664 (something_changedCB): New function for HAVE_GSETTINGS.
3665 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3666 with value as argument.
3667 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3668 g_settings_new (Bug#8967). Do not create gsettings_obj.
3669 Remove calls to g_settings_bind. Connect something_changedCB to
3672 * xgselect.c: Add defined (HAVE_GSETTINGS).
3673 (xgselect_initialize): Ditto.
3675 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3676 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3679 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3681 * eval.c (struct backtrace): Simplify and port the data structure.
3682 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3683 signed bit field, as this assumption is not portable and it makes
3684 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3685 "char debug_on_exit : 1" as this is not portable either; instead,
3686 use the portable "unsigned int debug_on_exit : 1". Remove unused
3687 member evalargs. Remove obsolete comments about cc bombing out.
3689 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3691 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3692 Let HAVE_GSETTINGS override HAVE_GCONF.
3693 (store_monospaced_changed): New function.
3694 (EMACS_SETTINGS): A new type derived from GObject to handle
3695 GSettings notifications.
3696 (emacs_settings_constructor, emacs_settings_get_property)
3697 (emacs_settings_set_property, emacs_settings_class_init):
3699 (gsettings_client, gsettings_obj): New variables.
3700 (GSETTINGS_SCHEMA): New define.
3701 (something_changedCB): Call store_monospaced_changed.
3702 (init_gsettings): New function.
3703 (xsettings_initialize): Call init_gsettings.
3704 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3707 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3710 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3712 * window.c (resize_root_window, grow_mini_window)
3713 (shrink_mini_window): Rename Qresize_root_window to
3714 Qwindow_resize_root_window and Qresize_root_window_vertically to
3715 Qwindow_resize_root_window_vertically.
3717 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3719 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3721 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3723 * makefile.w32-in: Redesign dependencies so they reflect more
3724 clearly which files are directly included by each source file,
3725 and not through other includes.
3727 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3729 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3730 (sort_overlays, overlay_strings): When an overlay's clone number
3731 matches the window's clone number process the overlay even if
3732 the overlay's window property doesn't match the current window.
3734 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3735 (Fwindow_hchild): Rename to Fwindow_left_child.
3736 (Fwindow_next): Rename to Fwindow_next_sibling.
3737 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3738 (resize_window_check): Rename to window_resize_check.
3739 (resize_window_apply): Rename to window_resize_apply.
3740 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3741 (Fdelete_other_windows_internal, resize_frame_windows)
3742 (Fsplit_window_internal, Fdelete_window_internal)
3743 (grow_mini_window, shrink_mini_window)
3744 (Fresize_mini_window_internal): Fix callers accordingly.
3746 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3748 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3749 (emacs_fixed_set_min_size): Remove.
3750 (emacs_fixed_new): Take frame as argument.
3752 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3753 (_EmacsFixedPrivate): Remove minwidth/height.
3754 Add struct frame *f.
3755 (emacs_fixed_init): Initialize priv->f.
3756 (get_parent_class, emacs_fixed_set_min_size): Remove.
3757 (emacs_fixed_new): Set priv->f to argument.
3758 (emacs_fixed_get_preferred_width)
3759 (emacs_fixed_get_preferred_height): Use min_width/height from
3760 frames size_hint to set minimum and natural (Bug#8919).
3761 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3762 and use min_width/height from frames size_hint to set
3763 min_width/height (Bug#8919).
3765 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3766 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3769 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3771 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3772 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3775 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3777 * process.c (wait_reading_process_output): Bypass select if
3778 waiting for a cell while ignoring keyboard input, and input is
3779 pending. Suggested by Jan Djärv (Bug#8869).
3781 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3783 Use gnulib's dup2 module instead of rolling our own.
3784 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3786 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3788 * dispnew.c (scrolling_window): Before scrolling, turn off a
3789 mouse-highlight in the window being scrolled.
3791 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3793 Move DEFSYM to lisp.h and use everywhere.
3795 * character.h (DEFSYM): Move declaration...
3796 * lisp.h (DEFSYM): ...here.
3802 * w32select.c: Don't include character.h.
3804 * alloc.c (syms_of_alloc):
3805 * buffer.c (syms_of_buffer):
3806 * bytecode.c (syms_of_bytecode):
3807 * callint.c (syms_of_callint):
3808 * casefiddle.c (syms_of_casefiddle):
3809 * casetab.c (init_casetab_once):
3810 * category.c (init_category_once, syms_of_category):
3811 * ccl.c (syms_of_ccl):
3812 * cmds.c (syms_of_cmds):
3813 * composite.c (syms_of_composite):
3814 * dbusbind.c (syms_of_dbusbind):
3815 * dired.c (syms_of_dired):
3816 * dispnew.c (syms_of_display):
3817 * doc.c (syms_of_doc):
3818 * editfns.c (syms_of_editfns):
3819 * emacs.c (syms_of_emacs):
3820 * eval.c (syms_of_eval):
3821 * fileio.c (syms_of_fileio):
3822 * fns.c (syms_of_fns):
3823 * frame.c (syms_of_frame):
3824 * fringe.c (syms_of_fringe):
3825 * insdel.c (syms_of_insdel):
3826 * keymap.c (syms_of_keymap):
3827 * lread.c (init_obarray, syms_of_lread):
3828 * macros.c (syms_of_macros):
3829 * msdos.c (syms_of_msdos):
3830 * print.c (syms_of_print):
3831 * process.c (syms_of_process):
3832 * search.c (syms_of_search):
3833 * sound.c (syms_of_sound):
3834 * syntax.c (init_syntax_once, syms_of_syntax):
3835 * terminal.c (syms_of_terminal):
3836 * textprop.c (syms_of_textprop):
3837 * undo.c (syms_of_undo):
3838 * w32.c (globals_of_w32):
3839 * window.c (syms_of_window):
3840 * xdisp.c (syms_of_xdisp):
3841 * xfaces.c (syms_of_xfaces):
3842 * xfns.c (syms_of_xfns):
3843 * xmenu.c (syms_of_xmenu):
3844 * xsettings.c (syms_of_xsettings):
3845 * xterm.c (syms_of_xterm): Use DEFSYM.
3847 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3849 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3851 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3853 Integer and buffer overflow fixes (Bug#8873).
3855 * print.c (printchar, strout): Check for string overflow.
3856 (PRINTPREPARE, printchar, strout):
3857 Don't set size unless allocation succeeds.
3859 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3860 for sizes. Check for string overflow more accurately.
3861 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3863 * macros.c: Integer and buffer overflow fixes.
3864 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3865 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3866 Use ptrdiff_t, not int, for sizes.
3867 Don't increment bufsize until after realloc succeeds.
3868 Check for size-calculation overflow.
3869 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3871 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3873 * lread.c: Integer overflow fixes.
3874 (read_integer): Radix is now EMACS_INT, not int,
3875 to improve quality of diagnostics for out-of-range radices.
3876 Calculate buffer size correctly for out-of-range radices.
3877 (read1): Check for integer overflow in radices, and in
3878 read-circle numbers.
3879 (read_escape): Avoid int overflow.
3880 (Fload, openp, read_buffer_size, read1)
3881 (substitute_object_recurse, read_vector, read_list, map_obarray):
3882 Use ptrdiff_t, not int, for sizes.
3883 (read1): Use EMACS_INT, not int, for sizes.
3884 Check for size overflow.
3886 * image.c (cache_image): Check for size arithmetic overflow.
3888 * lread.c: Integer overflow issues.
3889 (saved_doc_string_size, saved_doc_string_length)
3890 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3891 Now ptrdiff_t, not int.
3892 (read1): Don't assume doc string length fits in int. Check for
3893 out-of-range doc string lengths.
3894 (read_list): Don't assume file position fits in int.
3895 (read_escape): Check for hex character overflow.
3897 2011-06-22 Leo Liu <sdl.web@gmail.com>
3899 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3900 Move to minibuffer.el.
3902 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3904 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3905 The following patches are for when GLYPH_DEBUG && !XASSERT.
3906 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3907 * dispnew.c (flush_stdout):
3908 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3909 Mark as externally visible.
3910 * dispnew.c (check_window_matrix_pointers): Now static.
3911 * dispnew.c (window_to_frame_vpos):
3912 * xfns.c (unwind_create_frame):
3913 * xterm.c (x_check_font): Remove unused local.
3914 * scroll.c (CHECK_BOUNDS):
3915 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3916 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3917 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3918 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3919 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3921 (debug_method_add): Use va_list and vsprintf rather than relying
3922 on undefined behavior with wrong number of arguments.
3923 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3924 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3925 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3926 since we're not interested in debugging glyphs with old libraries.
3927 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3928 GCC 4.6.0's static checking.
3930 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3932 Integer overflow and signedness fixes (Bug#8873).
3933 A few related buffer overrun fixes, too.
3935 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3937 * dispextern.h (struct face.stipple):
3938 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3939 (x_bitmap_mask, x_allocate_bitmap_record)
3940 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3941 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3942 (x_create_bitmap_from_xpm_data):
3943 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3944 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3946 * xfaces.c (load_pixmap):
3947 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3948 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3949 (.bitmaps_last, struct x_output.icon_bitmap):
3950 Use ptrdiff_t, not int, for bitmap indexes.
3951 (x_allocate_bitmap_record): Check for size overflow.
3952 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3954 Use ptrdiff_t, not int, for overlay counts.
3955 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3956 * editfns.c (overlays_around, get_pos_property):
3957 * textprop.c (get_char_property_and_overlay):
3958 * xdisp.c (next_overlay_change, note_mouse_highlight):
3959 * xfaces.c (face_at_buffer_position):
3960 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3961 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3962 (Fnext_overlay_change, Fprevious_overlay_change)
3963 (mouse_face_overlay_overlaps, Foverlays_in):
3964 Use ptrdiff_t, not int, for sizes.
3965 (overlays_at, overlays_in): Check for size-calculation overflow.
3967 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3969 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3970 (x_session_initialize): Do not assume string length fits in int.
3972 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3973 This is unlikely, but can occur if DPI is outlandish.
3975 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3976 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3978 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3979 * xrdb.c (magic_file_p, search_magic_path):
3980 Omit last arg SUFFIX; it was always 0. All callers changed.
3981 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3983 * xfont.c (xfont_match): Avoid need for strlen.
3985 * xfns.c: Don't assume strlen fits in int.
3986 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3988 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3989 not unsigned long, as we prefer signed integers. All callers changed.
3990 Detect integer overflow in repeat count.
3991 (message_dolog): Don't assume print length fits in 39 bytes.
3992 (display_mode_element): Don't assume strlen fits in int.
3994 * termcap.c: Don't assume sizes fit in int and never overflow.
3995 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3996 (gobble_line): Check for size-calculation overflow.
3998 * minibuf.c (Fread_buffer):
3999 * lread.c (intern, intern_c_string):
4000 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4001 Don't assume string length fits in int.
4003 * keyboard.c (parse_tool_bar_item):
4004 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4006 * font.c: Don't assume string length fits in int.
4007 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4008 Use ptrdiff_t, not int.
4009 (font_intern_prop): Don't assume string length fits in int.
4010 Don't assume integer property fits in fixnum.
4011 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4013 * filelock.c: Fix some buffer overrun and integer overflow issues.
4014 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4015 Reformulate so as not to need the command string.
4016 Invoke gzip -cd rather than gunzip, as it's more portable.
4017 (lock_info_type, lock_file_1, lock_file):
4018 Don't assume pid_t and time_t fit in unsigned long.
4019 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4020 (current_lock_owner): Prefer signed type for sizes.
4021 Use memcpy, not strncpy, where memcpy is what is really wanted.
4022 Don't assume (via atoi) that time_t and pid_t fit in int.
4023 Check for time_t and/or pid_t out of range, e.g., via a network share.
4024 Don't alloca where an auto var works fine.
4026 * fileio.c: Fix some integer overflow issues.
4027 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4028 Don't assume string length fits in int.
4029 (directory_file_name): Don't assume string length fits in long.
4030 (make_temp_name): Don't assume pid fits in int, or that its print
4031 length is less than 20.
4033 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4035 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4037 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4039 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4040 We prefer signed integers, even for size calculations.
4042 * emacs.c: Don't assume string length fits in 'int'.
4043 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4044 (main): Don't invoke strlen when not needed.
4046 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4047 (XD_DEBUG_MESSAGE): Don't waste a byte.
4049 * callproc.c (getenv_internal_1, getenv_internal)
4051 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4053 * lread.c (invalid_syntax): Omit length argument.
4054 All uses changed. This doesn't fix a bug, but it simplifies the
4055 code away from its former Hollerith-constant appearance, and it's
4056 one less 'int' to worry about when looking at integer-overflow issues.
4057 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4059 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4060 This didn't break anything, but it didn't help either.
4061 It's confusing to put a bogus integer in a place where the actual
4062 value does not matter.
4063 (LIST_END_P): Remove unused macro and its bogus comment.
4064 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4066 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4067 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4069 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4070 We prefer signed types, and the value cannot exceed the EMACS_INT
4071 range anyway (because otherwise the length would not be representable).
4072 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4073 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4074 This avoids a GCC warning when WIDE_EMACS_INT.
4076 * indent.c (sane_tab_width): New function.
4077 (current_column, scan_for_column, Findent_to, position_indentation)
4078 (compute_motion): Use it. This is just for clarity.
4079 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4081 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4083 * lisp.h (lint_assume): New macro.
4084 * composite.c (composition_gstring_put_cache):
4085 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4087 * editfns.c, insdel.c:
4088 Omit unnecessary forward decls, to simplify future changes.
4090 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4092 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4094 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4095 Use much-faster test for byte-length change.
4096 Don't assume string byte-length fits in 'int'.
4097 Check that character arg fits in 'int'.
4098 (mapcar1): Declare byte as byte, for clarity.
4100 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4102 * fns.c (concat): Catch string overflow earlier.
4103 Do not rely on integer wraparound.
4105 * dispextern.h (struct it.overlay_strings_charpos)
4106 (struct it.selective): Now EMACS_INT, not int.
4107 * xdisp.c (forward_to_next_line_start)
4108 (back_to_previous_visible_line_start)
4109 (reseat_at_next_visible_line_start, next_element_from_buffer):
4110 Don't arbitrarily truncate the value of 'selective' to int.
4112 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4114 * composite.c: Don't truncate sizes to 'int'.
4115 (composition_gstring_p, composition_reseat_it)
4116 (composition_adjust_point): Use EMACS_INT, not int.
4117 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4118 not EMACS_UINT, for indexes.
4120 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4122 * buffer.c: Include <verify.h>.
4123 (struct sortvec.priority, struct sortstr.priority):
4124 Now EMACS_INT, not int.
4125 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4126 (struct sortstr.size, record_overlay_string)
4127 (struct sortstrlist.size, struct sortlist.used):
4128 Don't truncate size to int.
4129 (record_overlay_string): Check for size-calculation overflow.
4130 (init_buffer_once): Check at compile-time, not run-time.
4132 2011-06-22 Jim Meyering <meyering@redhat.com>
4134 Don't leak an XBM-image-sized buffer
4135 * image.c (xbm_load): Free the image buffer after using it.
4137 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4140 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4141 that Sun C diagnosed.
4142 * fns.c (secure_hash): Fix pointer signedness issue.
4143 * intervals.c (static_offset_intervals): New function.
4144 (offset_intervals): Use it.
4146 2011-06-21 Leo Liu <sdl.web@gmail.com>
4149 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4152 * fns.c (secure_hash): Rename from crypto_hash_function and change
4153 the first arg to accept symbols.
4154 (Fsecure_hash): New primitive.
4155 (syms_of_fns): New symbols.
4157 2011-06-20 Deniz Dogan <deniz@dogan.se>
4159 * process.c (Fset_process_buffer): Clarify return value in
4162 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4164 * dispnew.c (add_window_display_history): Use BVAR.
4166 * xdisp.c (debug_method_add): Use BVAR.
4167 (check_window_end, dump_glyph_matrix, dump_glyph)
4168 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4170 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4173 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4174 check till after the cache is created in init_frame_faces.
4176 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4178 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4180 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4182 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4183 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4184 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4186 Improve buffer-overflow checking (Bug#8873).
4187 * fileio.c (Finsert_file_contents):
4188 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4189 Remove the old (too-loose) buffer overflow checks.
4190 They weren't needed, since make_gap checks for buffer overflow.
4191 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4192 The old code merely checked for Emacs fixnum overflow, and relied
4193 on undefined (wraparound) behavior. The new code avoids undefined
4194 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4196 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4197 Tune. Don't use wider integers than needed. Don't use alloca.
4198 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4200 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4202 * insdel.c, lisp.h (buffer_overflow): New function.
4203 (insert_from_buffer_1, replace_range, replace_range_2):
4204 * insdel.c (make_gap_larger):
4205 * editfns.c (Finsert_char):
4206 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4208 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4210 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4212 Integer overflow and signedness fixes (Bug#8873).
4214 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4215 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4217 * fileio.c: Don't assume EMACS_INT fits in off_t.
4218 (emacs_lseek): New static function.
4219 (Finsert_file_contents, Fwrite_region): Use it.
4220 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4222 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4224 * fns.c: Don't overflow int when computing a list length.
4225 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4226 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4227 truncation on 64-bit hosts. Check for QUIT every
4228 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4229 faster and is responsive enough.
4230 (Flength): Report an error instead of overflowing an integer.
4231 (Fsafe_length): Return a float if the value is not representable
4232 as a fixnum. This shouldn't happen except in contrived situations.
4233 (Fnthcdr, Fsort): Don't assume list length fits in int.
4234 (Fcopy_sequence): Don't assume vector length fits in int.
4236 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4237 (header_size, word_size): New constants.
4238 (allocate_vectorlike): Don't check size overflow here.
4239 (allocate_vector): Check it here instead, since this is the only
4240 caller of allocate_vectorlike that could cause overflow.
4241 Check that the new vector's length is representable as a fixnum.
4243 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4244 The previous code was bogus. For example, next_almost_prime (32)
4245 returned 39, which is undesirable as it is a multiple of 3; and
4246 next_almost_prime (24) returned 25, which is a multiple of 5 so
4247 why was the code bothering to check for multiples of 7?
4249 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4251 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4253 Variadic C functions now count arguments with ptrdiff_t.
4254 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4255 Back then I didn't know that the Emacs coding style prefers signed int.
4256 Also, in the meantime I found a few more instances where arguments
4257 were being counted with int, which may truncate counts on 64-bit
4258 machines, or EMACS_INT, which may be unnecessarily wide.
4259 * lisp.h (struct Lisp_Subr.function.aMANY)
4260 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4261 Arg counts are now ptrdiff_t, not size_t.
4262 All variadic functions and their callers changed accordingly.
4263 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4264 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4265 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4266 * callint.c (Fcall_interactively): Check arg count for overflow,
4267 to avoid potential buffer overrun. Use signed char, not 'int',
4268 for 'varies' array, so that we needn't bother to check its size
4269 calculation for overflow.
4270 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4271 * eval.c (apply_lambda):
4272 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4273 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4274 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4276 * callint.c (Fcall_interactively): Don't use index var as event count.
4278 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4279 * mem-limits.h (SIZE): Remove; no longer used.
4281 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4283 Remove unnecessary casts.
4284 * xterm.c (x_term_init):
4285 * xfns.c (x_set_border_pixel):
4286 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4287 These aren't needed now that we assume ANSI C.
4289 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4290 It's more likely to cause problems (due to unsigned overflow)
4293 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4295 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4297 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4299 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4301 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4303 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4305 GLYPH_CODE_FACE returns EMACS_INT, not int.
4306 * dispextern.h (merge_faces):
4307 * xfaces.c (merge_faces):
4308 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4309 Don't assume EMACS_INT fits in int.
4311 * character.h (CHAR_VALID_P): Remove unused parameter.
4312 * fontset.c, lisp.h, xdisp.c: All uses changed.
4314 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4316 * fns.c (concat): Minor tuning based on overflow analysis.
4317 This doesn't fix any bugs. Use int to hold character, instead
4318 of constantly refetching from Emacs object. Use XFASTINT, not
4319 XINT, for value known to be a character. Don't bother comparing
4320 a single byte to 0400, as it's always less.
4322 * floatfns.c (Fexpt):
4323 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4325 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4328 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4330 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4331 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4332 incorrectly succeed when S was a string, because 4294967386 was
4333 truncated before it was used.
4335 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4336 Otherwise, an out-of-range integer could cause undefined behavior
4339 * composite.c: Use int, not EMACS_INT, for characters.
4340 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4341 EMACS_INT, for values that are known to be in character range.
4342 This doesn't fix any bugs but is the usual style inside Emacs and
4343 may generate better code on 32-bit machines.
4345 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4346 This is for reasons similar to the recent CHAR_STRING fix.
4347 * charset.c (Fencode_char): Check that character arg is actually
4348 a character. Pass an int to ENCODE_CHAR.
4349 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4350 wider than 'int', as a compile-time check to prevent future regressions
4353 * character.c (char_string): Remove unnecessary casts.
4355 Make sure a 64-bit char is never passed to CHAR_STRING.
4356 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4357 by silently ignoring the top 32 bits, allowing some values
4358 that were far too large to be valid characters.
4359 * character.h: Include <verify.h>.
4360 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4361 arguments are no wider than unsigned, as a compile-time check
4362 to prevent future regressions in this area.
4364 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4365 (Fsubst_char_in_region):
4367 * xdisp.c (decode_mode_spec_coding):
4368 Adjust to CHAR_STRING's new requirement.
4369 * editfns.c (Finsert_char, Fsubst_char_in_region):
4370 * fns.c (concat): Check that character args are actually
4371 characters. Without this test, these functions did the wrong
4372 thing with wildly out-of-range values on 64-bit hosts.
4374 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4375 These casts should not be needed on 32-bit hosts, either.
4376 * keyboard.c (read_char):
4377 * lread.c (Fload): Remove casts to unsigned.
4379 * lisp.h (UNSIGNED_CMP): New macro.
4380 This fixes comparison bugs on 64-bit hosts.
4381 (ASCII_CHAR_P): Use it.
4382 * casefiddle.c (casify_object):
4383 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4384 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4385 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4386 * dispextern.h (FACE_FROM_ID):
4387 * keyboard.c (read_char): Use UNSIGNED_CMP.
4389 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4390 not to EMACS_INT, to avoid GCC warning.
4392 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4394 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4395 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4396 isn't needed on 32-bit machines.
4398 * buffer.c (Fgenerate_new_buffer_name):
4399 Use EMACS_INT for count, not int.
4400 (advance_to_char_boundary): Return EMACS_INT, not int.
4402 * data.c (Qcompiled_function): Now static.
4404 * window.c (window_body_lines): Now static.
4406 * image.c (gif_load): Rename local to avoid shadowing.
4408 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4409 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4410 * alloc.c (make_save_value): Integer argument is now of type
4412 (mark_object): Use ptrdiff_t, not int.
4413 * lisp.h (pD): New macro.
4414 * print.c (print_object): Use it.
4416 * alloc.c: Use EMACS_INT, not int, to count objects.
4417 (total_conses, total_markers, total_symbols, total_vector_size)
4418 (total_free_conses, total_free_markers, total_free_symbols)
4419 (total_free_floats, total_floats, total_free_intervals)
4420 (total_intervals, total_strings, total_free_strings):
4421 Now EMACS_INT, not int. All uses changed.
4422 (Fgarbage_collect): Compute overall total using a double, so that
4423 integer overflow is less likely to be a problem. Check for overflow
4424 when converting back to an integer.
4425 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4426 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4427 These were 'int' variables that could overflow on 64-bit hosts;
4428 they were never used, so remove them instead of repairing them.
4429 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4430 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4431 Previously, this ceilinged at INT_MAX, but that doesn't work on
4433 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4435 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4436 (allocate_vectorlike): Check for ptrdiff_t overflow.
4437 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4438 when a (possibly-narrower) signed value would do just as well.
4439 We prefer using signed arithmetic, to avoid comparison confusion.
4441 * alloc.c: Catch some string size overflows that we were missing.
4442 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4443 for convenience in STRING_BYTES_MAX.
4444 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4445 The definition here is exact; the one in lisp.h was approximate.
4446 (allocate_string_data): Check for string overflow. This catches
4447 some instances we weren't catching before. Also, it catches
4448 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4449 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4450 and ptrdiff_t and EMACS_INT are both 64 bits.
4452 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4453 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4454 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4456 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4458 * alloc.c (Fmake_string): Check for out-of-range init.
4460 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4462 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4464 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4466 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4467 xg_get_default_scrollbar_width.
4469 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4470 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4471 (style_changed_cb): Call update_theme_scrollbar_width and call
4472 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4473 all frames (Bug#8505).
4474 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4475 Call gtk_window_set_resizable if HAVE_GTK3.
4476 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4477 and height if HAVE_GTK3 (Bug#8505).
4478 (scroll_bar_width_for_theme): New variable.
4479 (update_theme_scrollbar_width): New function.
4480 (xg_get_default_scrollbar_width): Move code to
4481 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4482 (xg_initialize): Call update_theme_scrollbar_width.
4484 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4486 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4488 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4490 * frame.c (make_frame): Call other_buffer_safely instead of
4493 * window.c (temp_output_buffer_show): Call display_buffer with
4494 second argument Vtemp_buffer_show_specifiers and reset latter
4495 immediately after the call.
4496 (Vtemp_buffer_show_specifiers): New variable.
4497 (auto_window_vscroll_p, next_screen_context_lines)
4498 (Vscroll_preserve_screen_position): Remove leading asterisks from
4501 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4503 Fix minor problems found by GCC 4.6.0 static checking.
4504 * buffer.c (Qclone_number): Remove for now, as it's unused.
4505 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4506 (record_buffer): Remove unused local.
4507 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4508 (set_frame_buffer_list): Remove; unused.
4509 * frame.h (other_visible_frames): Remove decl.
4510 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4511 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4512 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4514 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4515 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4516 Define only if HAVE_GPM.
4517 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4518 (update_hints_inhibit): Remove; never set. All uses removed.
4519 * widgetprv.h (emacsFrameClassRec): Remove decl.
4520 * window.c (delete_deletable_window): Now returns void, since it
4521 wasn't returning anything.
4522 (compare_window_configurations): Remove unused locals.
4523 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4524 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4525 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4526 the same widths as pointers. This follows up on the 2011-05-06 patch.
4527 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4528 * xterm.h: Likewise.
4529 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4531 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4533 * makefile.w32-in: Update dependencies.
4534 (LISP_H): Add lib/intprops.h.
4536 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4538 * image.c (gif_load): Add animation frame delay to the metadata.
4539 (syms_of_image): Use DEFSYM. New symbol `delay'.
4541 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4543 * window.c (delete_deletable_window): Re-add.
4544 (Fset_window_configuration): Rewrite to handle dead buffers and
4545 consequently deletable windows.
4546 (window_tree, Fwindow_tree): Remove. Supply functionality in
4548 (compare_window_configurations): Simplify code.
4550 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4552 * image.c (imagemagick_load_image): Fix type mismatch.
4553 (Fimagemagick_types): Likewise.
4555 * window.h (replace_buffer_in_windows): Declare.
4557 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4559 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4560 Qclone_number. Remove external declaration of Qdelete_window.
4561 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4563 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4564 Run Qbuffer_list_update_hook if allowed.
4565 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4566 buffer list implementation.
4567 (other_buffer_safely): New function.
4568 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4569 calls to replace_buffer_in_windows and
4570 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4572 (record_buffer): Inhibit quitting and rewrite using quittable
4573 functions. Run Qbuffer_list_update_hook if allowed.
4574 (Frecord_buffer, Funrecord_buffer): New functions.
4575 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4576 Move switch-to-buffer to window.el.
4577 (bury-buffer): Move to window.el.
4578 (Vbuffer_list_update_hook): New variable.
4580 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4583 * window.h (resize_frame_windows): Move up in code.
4584 (Fwindow_frame): Remove EXFUN.
4585 (replace_buffer_in_all_windows): Remove prototype.
4586 (replace_buffer_in_windows_safely): Add prototype.
4588 * window.c: Declare Qdelete_window static again. Move down
4589 declaration of select_count.
4590 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4591 (Fother_window): Move to window.el.
4592 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4593 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4594 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4596 (replace_buffer_in_windows): Implement by calling
4597 Qreplace_buffer_in_windows.
4598 (replace_buffer_in_all_windows): Remove with some functionality
4599 moved into replace_buffer_in_windows_safely.
4600 (replace_buffer_in_windows_safely): New function.
4601 (select_window_norecord, select_frame_norecord): Move in front
4602 of run_window_configuration_change_hook. Remove now obsolete
4604 (Fset_window_buffer): Rewrite doc-string.
4605 Call Qrecord_window_buffer.
4606 (keys_of_window): Move binding for other-window to window.el.
4608 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4610 * dispextern.h (struct image): Replace data member, whose int_val
4611 and ptr_val fields were not used by anything, with a single
4614 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4615 (gif_clear_image, gif_load, imagemagick_load_image)
4616 (gs_clear_image, gs_load): Callers changed.
4618 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4620 * buffer.h: Include <time.h>, for time_t.
4621 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4623 Fix minor problems found by static checking.
4625 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4627 Make identifiers static if they are not used in other modules.
4628 * data.c (Qcompiled_function, Qframe, Qvector):
4629 * image.c (QimageMagick, Qsvg):
4630 * minibuf.c (Qmetadata):
4631 * window.c (resize_window_check, resize_root_window): Now static.
4632 * window.h (resize_window_check, resize_root_window): Remove decls.
4634 * window.c (window_deletion_count, delete_deletable_window):
4636 (window_body_lines): Now static.
4637 (Fdelete_other_windows_internal): Mark vars as initialized.
4638 Make sure 'resize_failed' is initialized.
4639 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4640 (resize_window_apply): Remove unused local.
4641 * window.h (delete_deletable_window): Remove decl.
4643 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4644 (imagemagick_load_image): Fix pointer signedness problem by changing
4645 last arg from unsigned char * to char *. All uses changed.
4646 Also, fix a local for similar reasons.
4647 Remove unused locals. Remove locals to avoid shadowing.
4648 (fn_rsvg_handle_free): Remove; unused.
4649 (svg_load, svg_load_image): Fix pointer signedness problem.
4650 (imagemagick_load_image): Don't use garbage pointer image_wand.
4652 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4654 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4656 * image.c (gif_load): Fix omitted cast error introduced by
4659 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4661 * window.h (resize_proportionally, orig_total_lines)
4662 (orig_top_line): Remove from window structure.
4663 (set_window_height, set_window_width, change_window_heights)
4664 (Fdelete_window): Remove prototypes.
4665 (resize_frame_windows): Remove duplicate declaration.
4667 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4669 * window.h (resize_frame_windows, resize_window_check)
4670 (delete_deletable_window, resize_root_window)
4671 (resize_frame_windows): Declare prototypes.
4673 * window.c (resize_window_apply): Make definition be "static" to
4674 match the prototype.
4676 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4678 * window.c: Remove declarations of Qwindow_size_fixed,
4679 window_min_size_1, window_min_size_2, window_min_size,
4680 size_window, window_fixed_size_p, enlarge_window, delete_window.
4681 Remove static from declaration of Qdelete_window, it's
4682 temporarily needed by Fbury_buffer.
4683 (replace_window): Don't assign orig_top_line and
4685 (Fdelete_window, delete_window): Remove. Window deletion is
4686 handled by window.el.
4687 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4688 Replace Fdelete_window calls with calls to Qdelete_window.
4689 (Fdelete_other_windows): Remove. Deleting other windows is
4690 handled by window.el.
4691 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4692 handled in window.el.
4693 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4694 Window minimum sizes are handled in window.el.
4695 (shrink_windows, size_window, set_window_height)
4696 (set_window_width, change_window_heights, window_height)
4697 (window_width, CURBEG, CURSIZE, enlarge_window)
4698 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4699 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4700 handled in window.el.
4701 (make_dummy_parent): Rename to make_parent_window and give it a
4702 second argument horflag.
4703 (make_window): Don't set resize_proportionally any more.
4704 (Fsplit_window): Remove. Windows are split in window.el.
4705 (save_restore_action, save_restore_orig_size)
4706 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4707 Resize mini windows in window.el.
4708 (grow_mini_window, shrink_mini_window): Implement by calling
4709 Qresize_root_window_vertically, resize_window_check and
4710 resize_window_apply.
4711 (saved_window, Fset_window_configuration, save_window_save):
4712 Do not handle orig_top_line, orig_total_lines, and
4713 resize_proportionally.
4714 (window_min_height, window_min_width): Move to window.el.
4715 (keys_of_window): Move bindings for delete-other-windows,
4716 split-window, delete-window and enlarge-window to window.el.
4718 * buffer.c: Temporarily extern Qdelete_window.
4719 (Fbury_buffer): Temporarily call Qdelete_window instead of
4720 Fdelete_window (Fbury_buffer will move to window.el soon).
4722 * frame.c (set_menu_bar_lines_1): Remove code handling
4723 orig_top_line and orig_total_lines.
4725 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4726 set_window_height but set heights directly.
4727 (change_frame_size_1): Use resize_frame_windows.
4729 * xdisp.c (init_xdisp): Don't use set_window_height but set
4732 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4733 Use resize_frame_windows instead of change_window_heights and run
4734 run_window_configuration_change_hook.
4736 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4737 instead of change_window_heights and run
4738 run_window_configuration_change_hook.
4740 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4742 * window.c (replace_window): Rename second argument REPLACEMENT to
4743 NEW. New third argument SETFLAG. Rewrite.
4744 (delete_window, make_dummy_parent): Call replace_window with
4746 (window_list_1): Move down in code.
4747 (run_window_configuration_change_hook): Move set_buffer part
4748 before select_frame_norecord part in order to unwind correctly.
4749 Rename count1 to count.
4750 (recombine_windows, delete_deletable_window, resize_root_window)
4751 (Fdelete_other_windows_internal)
4752 (Frun_window_configuration_change_hook, make_parent_window)
4753 (resize_window_check, resize_window_apply, Fresize_window_apply)
4754 (resize_frame_windows, Fsplit_window_internal)
4755 (Fdelete_window_internal, Fresize_mini_window_internal):
4757 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4759 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4761 * window.h (window): Add some new members to window structure -
4762 normal_lines, normal_cols, new_total, new_normal, clone_number,
4763 splits, nest, prev_buffers, next_buffers.
4764 (WINDOW_TOTAL_SIZE): Move here from window.c.
4765 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4767 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4769 (make_dummy_parent): Set new members of windows structure.
4770 (make_window): Move down in code. Handle new members of window
4772 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4773 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4774 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4775 (Fset_window_prev_buffers, Fwindow_next_buffers)
4776 (Fset_window_next_buffers, Fset_window_clone_number):
4778 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4779 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4781 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4782 Argument WINDOW can be now internal window too.
4783 (Fwindow_use_time): Move up in code.
4784 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4786 (Fset_window_configuration, saved_window)
4787 (Fcurrent_window_configuration, save_window_save): Handle new
4788 members of window structure.
4789 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4790 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4791 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4792 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4793 Qget_mru_window, Qresize_root_window,
4794 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4795 Qauto_buffer_name; staticpro them.
4797 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4799 * window.c (Fwindow_total_size, Fwindow_left_column)
4800 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4801 (Fwindow_list_1): New functions.
4802 (window_box_text_cols): Replace with window_body_cols.
4803 (Fwindow_width, Fscroll_left, Fscroll_right):
4804 Use window_body_cols instead of window_box_text_cols.
4805 (delete_window, Fset_window_configuration):
4806 Call delete_all_subwindows with window as argument.
4807 (delete_all_subwindows): Take a window as argument and not a
4809 (window_loop): Remove handling of GET_LRU_WINDOW and
4811 (Fget_lru_window, Fget_largest_window): Move to window.el.
4813 * window.h: Extern window_body_cols instead of
4814 window_box_text_cols. delete_all_subwindows now takes a
4815 Lisp_Object as argument.
4817 * indent.c (compute_motion, Fcompute_motion):
4818 Use window_body_cols instead of window_box_text_cols.
4820 * frame.c (delete_frame): Call delete_all_subwindows with root
4823 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4825 * fns.c (Fputhash): Document return value.
4827 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4829 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4831 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4833 Cons<->int and similar integer overflow fixes (Bug#8794).
4835 Check for overflow when converting integer to cons and back.
4836 * charset.c (Fdefine_charset_internal, Fdecode_char):
4837 Use cons_to_unsigned to catch overflow.
4838 (Fencode_char): Use INTEGER_TO_CONS.
4839 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4840 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4841 * data.c (long_to_cons, cons_to_long): Remove.
4842 (cons_to_unsigned, cons_to_signed): New functions.
4843 These signal an error for invalid or out-of-range values.
4844 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4845 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4846 * font.c (Ffont_variation_glyphs):
4847 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4848 * lisp.h: Include <intprops.h>.
4849 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4850 (cons_to_signed, cons_to_unsigned): New decls.
4851 (long_to_cons, cons_to_long): Remove decls.
4852 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4853 (Fprimitive_undo): Use CONS_TO_INTEGER.
4854 * xfns.c (Fx_window_property): Likewise.
4855 * xselect.c: Include <limits.h>.
4856 (x_own_selection, selection_data_to_lisp_data):
4857 Use INTEGER_TO_CONS.
4858 (x_handle_selection_request, x_handle_selection_clear)
4859 (x_get_foreign_selection, Fx_disown_selection_internal)
4860 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4861 (lisp_data_to_selection_data): Use cons_to_unsigned.
4862 (x_fill_property_data): Use cons_to_signed.
4863 Report values out of range.
4865 Check for buffer and string overflow more precisely.
4866 * buffer.h (BUF_BYTES_MAX): New macro.
4867 * lisp.h (STRING_BYTES_MAX): New macro.
4868 * alloc.c (Fmake_string):
4869 * character.c (string_escape_byte8):
4870 * coding.c (coding_alloc_by_realloc):
4871 * doprnt.c (doprnt):
4872 * editfns.c (Fformat):
4874 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4875 since they may not be the same number.
4876 * editfns.c (Finsert_char):
4877 * fileio.c (Finsert_file_contents):
4878 Likewise for BUF_BYTES_MAX.
4880 * image.c: Use ptrdiff_t, not int, for sizes.
4881 (slurp_file): Switch from int to ptrdiff_t.
4883 (slurp_file): Check that file size fits in both size_t (for
4884 malloc) and ptrdiff_t (for sanity and safety).
4886 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4887 if b->modtime has its maximal value.
4889 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4891 Don't assume time_t can fit into int.
4892 * buffer.h (struct buffer.modtime): Now time_t, not int.
4893 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4894 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4896 Minor fixes for signed vs unsigned integers.
4897 * character.h (MAYBE_UNIFY_CHAR):
4898 * charset.c (maybe_unify_char):
4899 * keyboard.c (read_char, reorder_modifiers):
4900 XINT -> XFASTINT, since the integer must be nonnegative.
4901 * ftfont.c (ftfont_spec_pattern):
4902 * keymap.c (access_keymap, silly_event_symbol_error):
4903 XUINT -> XFASTINT, since the integer must be nonnegative.
4904 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4905 since it makes no difference and we prefer signed.
4906 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4907 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4910 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4912 * window.h (Fwindow_frame): Declare.
4914 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4916 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4917 (SPARE_MEMORY): Always define.
4918 (LARGE_REQUEST): Remove.
4919 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4921 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4923 * lisp.h: Move EXFUNS for Fframe_root_window,
4924 Fframe_first_window and Fset_frame_selected_window to window.h.
4926 * window.h: Move EXFUNS for Fframe_root_window,
4927 Fframe_first_window and Fset_frame_selected_window here from
4930 * frame.c (Fwindow_frame, Fframe_first_window)
4931 (Fframe_root_window, Fframe_selected_window)
4932 (Fset_frame_selected_window): Move to window.c.
4933 (Factive_minibuffer_window): Move to minibuf.c.
4934 (Fother_visible_frames_p): New function.
4936 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4938 * window.c (decode_window, decode_any_window): Move up in code.
4939 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4940 (inhibit_frame_unsplittable): Remove unused variable.
4941 (Fwindow_buffer): Move up and rewrite doc-string.
4942 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4943 (Fwindow_prev): New functions.
4944 (Fwindow_frame): Move here from frame.c. Accept any window as
4946 (Fframe_root_window, Fframe_first_window)
4947 (Fframe_selected_window): Move here from frame.c. Accept frame
4948 or arbitrary window as argument. Update doc-strings.
4949 (Fminibuffer_window): Move up in code.
4950 (Fwindow_minibuffer_p): Move up in code and simplify.
4951 (Fset_frame_selected_window): Move here from frame.c.
4953 (Fselected_window, select_window, Fselect_window): Move up in
4954 code. Minor doc-string fixes.
4956 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4958 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4959 Do not assume that spare memory exists; that assumption is valid
4960 only if SYSTEM_MALLOC.
4961 (LARGE_REQUEST): New macro, so that the issue of large requests
4962 is separated from the issue of spare memory.
4964 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4966 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4969 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4971 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4974 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4976 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4978 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4980 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4981 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4983 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4985 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4987 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4989 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4990 (x_clipboard_manager_save): Add return value.
4991 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4993 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4994 Obey Vx_select_enable_clipboard_manager. Catch errors in
4995 x_clipboard_manager_save (Bug#8779).
4996 (Vx_select_enable_clipboard_manager): New variable.
4997 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4999 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5001 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5003 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5005 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5006 in the current matrix if keep_current_p is non-zero.
5008 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5010 * bidi.c (bidi_level_of_next_char): Fix last change.
5012 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5014 Support bidi reordering of text covered by display properties.
5016 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5017 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5018 (bidi_cache_search, bidi_cache_iterator_state)
5019 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5020 (bidi_level_of_next_char, bidi_move_to_visually_next):
5021 Support character positions inside a run of characters covered by a
5023 (bidi_paragraph_init, bidi_resolve_explicit_1)
5024 (bidi_level_of_next_char): Call bidi_fetch_char and
5025 bidi_fetch_char_advance instead of FETCH_CHAR and
5027 (bidi_init_it): Initialize new members.
5028 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5030 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5031 instead of using explicit *_CHAR codes.
5032 (bidi_resolve_explicit, bidi_resolve_weak):
5033 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5034 bidirectional text is supported only in multibyte buffers.
5035 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5036 it to initialize the frame_window_p member of struct bidi_it.
5037 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5038 (bidi_resolve_explicit, bidi_resolve_weak)
5039 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5040 bidi_it->nchars is non-positive.
5041 (bidi_level_of_next_char): Don't try to lookup the cache for the
5042 next/previous character if nothing is cached there yet, or if we
5043 were just reseat()'ed to a new position.
5045 * xdisp.c (set_cursor_from_row): Set start and stop points
5046 according to the row's direction when priming the loop that looks
5047 for the glyph on which to display cursor.
5048 (single_display_spec_intangible_p): Function deleted.
5049 (display_prop_intangible_p): Reimplement to call
5050 handle_display_spec instead of single_display_spec_intangible_p.
5051 Accept 3 additional arguments needed by handle_display_spec.
5052 This fixes incorrect cursor motion across display property with complex
5053 values: lists, `(when COND...)' forms, etc.
5054 (single_display_spec_string_p): Support property values that are
5055 lists with the argument STRING its top-level element.
5056 (display_prop_string_p): Fix the condition for processing a
5057 property that is a list to be consistent with handle_display_spec.
5058 (handle_display_spec): New function, refactored from the
5059 last portion of handle_display_prop.
5060 (compute_display_string_pos): Accept additional argument
5061 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5062 value of a `display' property is a "replacing spec".
5063 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5064 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5065 the display property, but just return a value indicating whether
5066 the display property will replace the characters it covers.
5067 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5068 frame_window_p members of struct bidi_it.
5069 (compute_display_string_pos, compute_display_string_end):
5071 (push_it): Accept second argument POSITION, where pop_it should
5072 jump to continue iteration.
5073 (reseat_1): Initialize bidi_it.disp_pos.
5075 * keyboard.c (adjust_point_for_property): Adjust the call to
5076 display_prop_intangible_p to its new signature.
5078 * dispextern.h (struct bidi_it): New member frame_window_p.
5079 (bidi_init_it): Update prototypes.
5080 (display_prop_intangible_p): Update prototype.
5081 (compute_display_string_pos, compute_display_string_end):
5083 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5086 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5088 Malloc failure behavior now depends on size of allocation.
5089 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5090 * lisp.h: Change signatures accordingly.
5091 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5092 All callers changed. (Bug#8762)
5094 * gnutls.c: Use Emacs's memory allocators.
5095 Without this change, the gnutls library would invoke malloc etc.
5096 directly, which causes problems on non-SYNC_INPUT hosts, and which
5097 runs afoul of improving memory_full behavior. (Bug#8761)
5098 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5099 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5100 xfree instead of the default malloc, realloc, free.
5101 (Fgnutls_boot): No need to check for memory allocation failure,
5102 since xmalloc does that for us.
5104 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5105 * category.c (hash_get_category_set):
5106 * ccl.c (ccl_driver):
5107 * charset.c (Fdefine_charset_internal):
5108 * charset.h (struct charset.hash_index):
5109 * composite.c (get_composition_id, gstring_lookup_cache)
5110 (composition_gstring_put_cache):
5111 * composite.h (struct composition.hash_index):
5112 * dispextern.h (struct image.hash):
5113 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5114 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5115 (hashfn_equal, hashfn_user_defined, make_hash_table)
5116 (maybe_resize_hash_table, hash_lookup, hash_put)
5117 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5118 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5119 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5120 * image.c (make_image, search_image_cache, lookup_image)
5121 (xpm_put_color_table_h):
5122 * lisp.h (struct Lisp_Hash_Table):
5123 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5124 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5125 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5126 * alloc.c (allocate_vectorlike):
5127 Check for overflow in vector size calculations.
5128 * ccl.c (ccl_driver):
5129 Check for overflow when converting EMACS_INT to int.
5130 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5131 need to be updated by these changes.
5132 * fns.c (make_hash_table, maybe_resize_hash_table):
5133 Check for integer overflow with large hash tables.
5134 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5135 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5136 (SXHASH_REDUCE): New macro.
5137 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5138 Use it instead of discarding useful hash info with large hash values.
5139 (sxhash_float): New function.
5140 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5141 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5142 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5143 Rewrite to use FIXNUM_BITS, as this simplifies things.
5144 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5145 Adjust signatures to match updated version of code.
5146 (consing_since_gc): Now EMACS_INT, since a single hash table can
5147 use more than INT_MAX bytes.
5149 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5151 Make it possible to build with GCC-4.6+ -O2 -flto.
5153 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5155 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5157 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5158 Call minibuffer-inactive-mode.
5160 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5162 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5163 Update dependencies.
5165 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5167 * data.c (init_data): Remove code for UTS, this system is not
5170 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5172 Don't force ./temacs to start in terminal mode.
5174 * frame.c (make_initial_frame): Initialize faces in all cases, not
5175 only when CANNOT_DUMP is defined.
5176 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5178 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5180 * dispnew.c (add_window_display_history): Use const for the string
5181 pointer. Remove declaration, not needed.
5183 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5185 Use 'inline', not 'INLINE'.
5186 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5187 * alloc.c, fontset.c (INLINE): Remove.
5188 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5189 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5190 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5191 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5192 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5194 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5196 Make it possible to run ./temacs.
5198 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5199 syms_of_callproc does the same thing. Remove test for
5200 "initialized", do it in the caller.
5201 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5203 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5205 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5206 (read_minibuf): Use get_minibuffer.
5207 (syms_of_minibuf): Use DEFSYM.
5208 (Qmetadata): New var.
5209 * data.c (Qbuffer): Don't make it static.
5210 (syms_of_data): Use DEFSYM.
5212 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5214 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5215 (CCL_CODE_MIN): New macro.
5217 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5219 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5221 * eval.c (Qdebug): Now static.
5222 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5223 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5224 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5226 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5228 * image.c: Various fixes to ImageMagick code comments.
5229 (Fimagemagick_types): Doc fix.
5231 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5233 Minor fixes prompted by GCC 4.6.0 warnings.
5235 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5237 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5238 (x_clipboard_manager_save_all): Move extern decl to ...
5239 * xterm.h: ... here, so that it can be checked for consistency.
5241 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5243 * xselect.c (x_clipboard_manager_save_frame)
5244 (x_clipboard_manager_save_all): New functions.
5245 (Fx_clipboard_manager_save): Lisp function deleted.
5247 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5248 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5250 * xterm.h: Update prototype.
5252 2011-05-28 William Xu <william.xwl@gmail.com>
5254 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5257 2011-05-28 Jim Meyering <meyering@redhat.com>
5259 Avoid a sign-extension bug in crypto_hash_function.
5260 * fns.c (to_uchar): Define.
5261 (crypto_hash_function): Use it to convert some newly-signed
5262 variables to unsigned, to avoid sign-extension bugs. For example,
5263 without this change, (md5 "truc") would evaluate to
5264 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5265 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5266 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5268 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5270 Integer overflow fixes.
5272 * dbusbind.c: Serial number integer overflow fixes.
5273 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5274 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5275 to hold a serial number that is too large for a fixnum.
5276 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5277 Check for serial numbers out of range. Decode any serial number
5278 that was so large that it became a float. (Bug#8722)
5280 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5281 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5282 Use XFASTINT rather than XUINT when numbers are nonnegative.
5283 (xd_append_arg, Fdbus_method_return_internal):
5284 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5285 arguments, check that Lisp number is nonnegative, rather than
5286 silently wrapping negative numbers around. (Bug#8722)
5287 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5290 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5292 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5294 ccl: add integer overflow checks
5295 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5296 (IN_INT_RANGE): New macros.
5297 (ccl_driver): Use them to check for integer overflow when
5298 decoding a CCL program. Many of the new checks are whether XINT (x)
5299 fits in int; it doesn't always, on 64-bit hosts. The new version
5300 doesn't catch all possible integer overflows, but it's an
5301 improvement. (Bug#8719)
5303 * alloc.c (make_event_array): Use XINT, not XUINT.
5304 There's no need for unsigned here.
5306 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5307 This follows up to the 2011-05-06 change that substituted uintptr_t
5308 for EMACS_INT. This case wasn't caught back then.
5310 Rework Fformat to avoid integer overflow issues.
5311 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5312 now (part of C89). Include <verify.h>.
5313 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5314 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5315 (Fformat): Avoid the prepass trying to compute sizes; it was only
5316 approximate and thus did not catch overflow reliably. Instead, walk
5317 through the format just once, formatting and computing sizes as we go,
5318 checking for integer overflow at every step, and allocating a larger
5319 buffer as needed. Keep track separately whether the format is
5320 multibyte. Keep only the most-recently calculated precision, rather
5321 than them all. Record whether each argument has been converted to
5322 string. Use EMACS_INT, not int, for byte and char and arg counts.
5323 Support field widths and precisions larger than INT_MAX. Avoid
5324 sprintf's undefined behavior with conversion specifications such as %#d
5325 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5326 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5327 formatting out-of-range floating point numbers with int
5330 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5332 * data.c: Avoid integer truncation in expressions involving floats.
5333 * data.c: Include <intprops.h>.
5334 (arith_driver): When there's an integer overflow in an expression
5335 involving floating point, convert the integers to floating point
5336 so that the resulting value does not suffer from catastrophic
5337 integer truncation. For example, on a 64-bit host (* 4
5338 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5339 Do not rely on undefined behavior after integer overflow.
5341 merge count_size_as_multibyte, parse_str_to_multibyte
5342 * character.c, character.h (count_size_as_multibyte):
5343 Rename from parse_str_to_multibyte; all uses changed.
5344 Check for integer overflow.
5345 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5346 since it's now a duplicate of the other. This is more of
5347 a character than a buffer op, so better that it's in character.c.
5348 * fns.c, print.c: Adjust to above changes.
5350 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5352 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5354 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5356 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5357 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5358 (x_clipboard_manager_save): Now static.
5359 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5361 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5362 (crypto_hash_function): Now static.
5363 Fix pointer signedness problems. Avoid unnecessary initializations.
5365 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5367 * termhooks.h (Vselection_alist): Make it terminal-local.
5369 * terminal.c (create_terminal): Initialize it.
5371 * xselect.c: Support for clipboard managers.
5372 (Vselection_alist): Move to termhooks.h as terminal-local var.
5373 (LOCAL_SELECTION): New macro.
5374 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5375 (symbol_to_x_atom): Remove gratuitous arg.
5376 (x_handle_selection_request, lisp_data_to_selection_data)
5377 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5378 (x_own_selection, x_get_local_selection, x_convert_selection):
5379 New arg, specifying work frame. Use terminal-local Vselection_alist.
5380 (some_frame_on_display): Delete unused function.
5381 (Fx_own_selection_internal, Fx_get_selection_internal)
5382 (Fx_disown_selection_internal, Fx_selection_owner_p)
5383 (Fx_selection_exists_p): New optional frame arg.
5384 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5385 (x_handle_selection_clear): Don't treat other terminals with the
5386 same keyboard specially. Use the terminal-local Vselection_alist.
5387 (x_clear_frame_selections): Use Frun_hook_with_args.
5389 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5391 * xterm.h: Add support for those atoms.
5393 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5395 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5396 (converted_selections, conversion_fail_tag): New global variables.
5397 (x_selection_request_lisp_error): Free the above.
5398 (x_get_local_selection): Remove unnecessary code.
5399 (x_reply_selection_request): Args changed; handle arbitrary array
5400 of converted selections stored in converted_selections.
5401 Separate the XChangeProperty and SelectionNotify steps.
5402 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5403 (x_convert_selection): New function.
5404 (x_handle_selection_event): Simplify.
5405 (x_get_foreign_selection): Don't ignore incoming requests while
5406 waiting for an answer; this will fail when we implement
5407 SAVE_TARGETS, and seems unnecessary anyway.
5408 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5409 (Vx_sent_selection_functions): Doc fix.
5411 2011-05-26 Leo Liu <sdl.web@gmail.com>
5413 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5415 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5417 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5419 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5420 for fringe update if it has periodic bitmap.
5421 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5422 and fringe_bitmap_periodic_p.
5424 * fringe.c (get_fringe_bitmap_data): New function.
5425 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5426 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5427 row. Mark glyph row for fringe update if periodicity changed.
5429 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5430 for fringe update unless it has periodic bitmap.
5432 2011-05-25 Kenichi Handa <handa@m17n.org>
5434 * xdisp.c (get_next_display_element): Set correct it->face_id for
5435 a static composition.
5437 2011-05-24 Leo Liu <sdl.web@gmail.com>
5440 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5442 * fns.c (crypto_hash_function, Fsha1): New function.
5443 (Fmd5): Use crypto_hash_function.
5444 (syms_of_fns): Add Ssha1.
5446 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5448 * gnutls.c: Remove unused macros.
5449 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5450 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5451 Remove macros that are defined and never used.
5452 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5454 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5456 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5457 (Fx_get_selection_internal): Minor cleanup.
5458 (Fx_own_selection_internal): Rename arguments for consistency with
5461 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5463 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5465 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5467 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5469 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5471 * dispnew.c (scrolling_window): Don't exclude the case that the
5472 last enabled row in the desired matrix touches the bottom boundary.
5474 2011-05-21 Glenn Morris <rgm@gnu.org>
5476 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5477 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5478 and add some more files.
5480 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5482 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5483 report_file_error introduced by the change from 2011-05-07.
5485 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5487 * systime.h (Time): Define only if emacs is defined.
5488 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5489 where the include path doesn't have X11/X.h by default. See
5490 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5492 2011-05-20 Kenichi Handa <handa@m17n.org>
5494 * composite.c (find_automatic_composition): Fix previous change.
5496 2011-05-20 Glenn Morris <rgm@gnu.org>
5498 * lisp.mk: New file, split from Makefile.in.
5499 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5500 (shortlisp): Remove.
5501 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5503 2011-05-19 Glenn Morris <rgm@gnu.org>
5505 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5506 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5507 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5508 (lisp): Set the order to that of loadup.el.
5509 (shortlisp): Make it a copy of $lisp.
5510 (SOME_MACHINE_LISP): Remove.
5511 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5512 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5514 2011-05-18 Kenichi Handa <handa@m17n.org>
5516 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5517 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5518 (find_automatic_composition): Mostly rewrite for efficiency.
5520 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5522 * makefile.w32-in: Update dependencies.
5524 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5526 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5527 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5529 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5531 Fix some integer overflow issues, such as string length overflow.
5533 * insdel.c (count_size_as_multibyte): Check for string overflow.
5535 * character.c (lisp_string_width): Check for string overflow.
5536 Use EMACS_INT, not int, for string indexes and lengths; in
5537 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5538 the resulting string length overflows an EMACS_INT; instead,
5539 report a string overflow if no precision given. When checking for
5540 precision exhaustion, use a check that cannot possibly have
5541 integer overflow. (Bug#8675)
5542 * character.h (lisp_string_width): Adjust to new signature.
5544 * alloc.c (string_overflow): New function.
5545 (Fmake_string): Use it. This doesn't change behavior, but saves
5546 a few bytes and will simplify future changes.
5547 * character.c (string_escape_byte8): Likewise.
5548 * lisp.h (string_overflow): New decl.
5550 Fixups, following up to the user-interface timestamp change.
5551 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5552 for UI timestamps, instead of unsigned long.
5553 * msdos.c (mouse_get_pos): Likewise.
5554 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5555 * w32gui.h (Time): Define by including "systime.h" rather than by
5556 declaring it ourselves. (Bug#8664)
5558 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5559 * image.c (clear_image_cache): Likewise.
5561 * term.c (term_mouse_position): Don't assume time_t wraparound.
5563 Be more systematic about user-interface timestamps.
5564 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5565 and sometimes 'EMACS_UINT', to represent these timestamps.
5566 This change causes it to use 'Time' uniformly, as that's what X uses.
5567 This makes the code easier to follow, and makes it easier to catch
5568 integer overflow bugs such as Bug#8664.
5569 * frame.c (Fmouse_position, Fmouse_pixel_position):
5570 Use Time, not unsigned long, for user-interface timestamps.
5571 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5572 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5573 * keyboard.h (last_event_timestamp): Likewise.
5574 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5575 * menu.h (xmenu_show): Likewise.
5576 * term.c (term_mouse_position): Likewise.
5577 * termhooks.h (struct input_event.timestamp): Likewise.
5578 (struct terminal.mouse_position_hook): Likewise.
5579 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5580 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5581 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5582 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5584 * menu.h, termhooks.h: Include "systime.h", for Time.
5586 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5587 Don't assume that the difference between two unsigned long values
5588 can fit into an integer. At this point, we know button_down_time
5589 <= event->timestamp, so the difference must be nonnegative, so
5590 there's no need to cast the result if double-click-time is
5591 nonnegative, as it should be; check that it's nonnegative, just in
5592 case. This bug is triggered when events are more than 2**31 ms
5593 apart (about 25 days). (Bug#8664)
5595 * xselect.c (last_event_timestamp): Remove duplicate decl.
5596 (x_own_selection): Remove needless cast to unsigned long.
5598 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5599 that always fit in int. Use a sentinel instead of a counter, to
5600 avoid a temp and to allay GCC's concerns about possible int overflow.
5601 * frame.h (struct frame): Use int for menu_bar_items_used
5602 instead of EMACS_INT, since it always fits in int.
5604 * menu.c (grow_menu_items): Check for int overflow.
5606 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5608 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5609 Before, the code was not consistent. These values cannot exceed
5610 2**31 - 1 so there's no need to make them unsigned.
5611 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5612 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5613 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5615 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5617 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5618 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5619 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5620 presumably because the widths might not match.
5622 * window.c (size_window): Avoid needless test at loop start.
5624 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5626 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5628 2011-05-12 Drew Adams <drew.adams@oracle.com>
5630 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5632 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5634 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5635 `width' to `bar_area_x' and `bar_area_width', respectively.
5636 (x_scroll_run): Take account of fringe background extension.
5638 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5639 Rename local vars `left' and `width' to `bar_area_x' and
5640 `bar_area_width', respectively.
5641 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5642 background extension.
5644 2011-05-10 Jim Meyering <meyering@redhat.com>
5646 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5648 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5650 * image.c (Finit_image_library): Return t for built-in image types,
5651 like pbm and xbm. (Bug#8640)
5653 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5655 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5657 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5659 * w32console.c (Fset_screen_color): Doc fix.
5660 (Fget_screen_color): New function.
5661 (syms_of_ntterm): Defsubr it.
5663 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5664 unlink the temporary file if Fcall_process didn't create it in the
5666 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5667 child process will be redirected to a file specified with `:file'.
5668 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5669 cue to call_process_cleanup not to close that handle.
5671 2011-05-07 Ben Key <bkey76@gmail.com>
5673 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5674 one of two shell specific rules, either bootstrap-temacs-CMD or
5675 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5676 to the previous implementation of the bootstrap-temacs rule.
5677 The bootstrap-temacs-CMD rule is similar to the previous
5678 implementation of the bootstrap-temacs rule except that it
5679 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5682 These changes, along with some changes to nt/configure.bat,
5683 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5684 earlier fix to add support for --cflags and --ldflags options
5685 that include quotes so that it works whether make uses cmd or
5688 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5690 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5691 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5693 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5694 a string. Handle both cases.
5695 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5696 (Fdbus_register_method): Use Qinvalid_function.
5698 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5700 * makefile.w32-in: Update dependencies.
5701 (LISP_H): Add inttypes.h and stdin.h.
5702 (PROCESS_H): Add unistd.h.
5704 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5706 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5707 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5709 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5711 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5713 * term.c (vfatal): Remove stray call to va_end.
5714 It's not needed and the C Standard doesn't allow it here anyway.
5716 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5717 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5719 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5722 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5724 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5726 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5728 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5730 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5732 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5733 * charset.c (Fdefine_charset_internal): Don't initialize
5734 charset.code_space[15]. The value was garbage, on hosts with
5735 32-bit int (Bug#8600).
5737 * lread.c (read_integer): Be more consistent with string-to-number.
5738 Use string_to_number to do the actual conversion; this avoids
5739 rounding errors and fixes some other screwups. Without this fix,
5740 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5741 (digit_to_number): Move earlier, for benefit of read_integer.
5742 Return -1 if the digit is out of range for the base, -2 if it is
5743 not a digit in any supported base. (Bug#8602)
5745 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5747 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5748 to match comment at start of function. This also removes a
5749 GCC warning about overflow in a 32+64-bit port.
5751 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5753 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5754 Reported by Stefan Monnier in
5755 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5756 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5757 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5759 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5760 (EMACS_UINTPTR): Likewise, with uintptr_t.
5762 * lisp.h: Prefer 64-bit EMACS_INT if available.
5763 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5764 on 32-bit hosts that have 64-bit int, so that they can access
5766 However, temporarily disable this change unless the temporary
5767 symbol WIDE_EMACS_INT is defined.
5769 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5771 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5772 This removes an assumption that EMACS_INT and long are the same
5773 width as pointers. The assumption is true for Emacs porting targets
5774 now, but we want to make other targets possible.
5775 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5776 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5777 In the rest of the code, change types of integers that hold casted
5778 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5779 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5780 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5781 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5782 No need to cast type when ORing.
5783 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5784 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5785 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5786 assume EMACS_INT is the same width as char *.
5787 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5788 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5789 Remove no-longer-needed casts.
5790 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5791 (xg_tool_bar_help_callback, xg_make_tool_item):
5792 Use EMACS_INTPTR to hold an integer
5793 that will be cast to void *; this can avoid a GCC warning
5794 if EMACS_INT is not the same width as void *.
5795 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5796 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5797 (current_message_1, set_message_1):
5798 Use a local to convert to proper width without a cast.
5799 * xmenu.c (dialog_selection_callback): Likewise.
5801 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5802 Also, don't assume VALBITS / RAND_BITS is less than 5,
5803 and don't rely on undefined behavior when shifting a 1 left into
5805 * lisp.h (get_random): Change signature to match.
5807 * lread.c (hash_string): Use size_t, not int, for hash computation.
5808 Normally we prefer signed values; but hashing is special, because
5809 it's better to use unsigned division on hash table sizes so that
5810 the remainder is nonnegative. Also, size_t is the natural width
5811 for hashing into memory. The previous code used 'int', which doesn't
5812 retain enough info to hash well into very large tables.
5813 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5815 * dbusbind.c: Don't possibly lose pointer info when converting.
5816 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5817 Use XPNTR rather than XHASH, so that the high-order bits of
5818 the pointer aren't lost when converting through void *.
5820 * eval.c (Fautoload): Don't double-shift a pointer.
5822 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5824 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5826 * gnutls.c (DEF_GNUTLS_FN):
5827 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5829 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5831 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5834 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5836 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5837 New version that can reserve upto 2GB of heap space.
5839 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5841 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5843 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5845 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5846 `gnutls_certificate_set_x509_key_file'.
5848 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5850 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5851 Update dependencies.
5853 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5855 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5856 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5857 Remove unused parameter `fildes'.
5858 * process.c (read_process_output, send_process): Don't pass it.
5860 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5862 Fix previous change: the library cache is defined in w32.c.
5863 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5864 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5866 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5868 Implement dynamic loading of GnuTLS on Windows.
5870 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5871 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5872 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5875 * gnutls.c (Qgnutls_dll): Define.
5876 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5877 (gnutls_*): Declare function pointers.
5878 (init_gnutls_functions): New function to initialize function pointers.
5879 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5880 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5881 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5882 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5883 (emacs_gnutls_write, emacs_gnutls_read)
5884 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5885 (Fgnutls_available_p): New function.
5886 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5887 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5888 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5890 * image.c: Include w32.h.
5891 (Vimage_type_cache): Delete.
5892 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5893 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5894 (w32_delayed_load): Move to w32.c.
5896 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5898 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5899 (w32_delayed_load): Move from image.c. When loading a library, record
5900 its filename in the :loaded-from property of the library id.
5901 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5902 Initialize and staticpro them.
5903 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5905 * process.c: Include lisp.h before w32.h, not after.
5906 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5907 instead of gnutls_record_check_pending.
5909 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5911 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5913 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5914 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5917 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5919 * xterm.c (x_set_frame_alpha): Do not set property on anything
5920 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5922 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5924 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5926 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5928 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5929 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5930 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5931 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5932 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5933 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5934 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5935 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5936 (Qgnutls_bootprop_callbacks_verify): Make static.
5938 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5940 * callproc.c: Indentation fixup.
5942 * sysdep.c (wait_for_termination_1): Make static.
5943 (wait_for_termination, interruptible_wait_for_termination):
5944 Move after wait_for_termination_1.
5946 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5948 * sysdep.c (interruptible_wait_for_termination): New function
5949 which is like wait_for_termination, but allows keyboard
5952 * callproc.c (Fcall_process): Add (:file "file") as an option for
5954 (Fcall_process_region): Ditto.
5956 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5958 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5959 rather than `XVECTOR (FOO)->size'.
5961 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5962 inttypes.h, as a gnulib replacement is used if it not available in
5965 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5967 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5968 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5969 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5971 * coding.c (coding_alloc_by_realloc): Error out if destination
5972 will grow beyond MOST_POSITIVE_FIXNUM.
5973 (decode_coding_emacs_mule): Abort if there isn't enough place in
5974 charbuf for the composition carryover bytes. Reserve an extra
5975 space for up to 2 characters produced in a loop.
5976 (decode_coding_iso_2022): Abort if there isn't enough place in
5977 charbuf for the composition carryover bytes.
5979 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5981 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5982 aborting when %lld or %lll format is passed.
5983 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5984 %llo or %llx format is passed. (Bug#8545)
5986 * window.c (window_scroll_line_based): Use a marker instead of
5987 simple variables to record original value of point. (Bug#7952)
5989 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5990 produced by %s or %c overflows available buffer space. (Bug#8545)
5992 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5994 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5995 (SIZE_MAX): Move defn after all includes, as they might #define it.
5997 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5999 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6001 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6003 * keyboard.c (Qdelayed_warnings_hook): Define.
6004 (command_loop_1): Run `delayed-warnings-hook'
6005 if Vdelayed_warnings_list is non-nil.
6006 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6007 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6009 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6011 * doprnt.c (doprnt): Don't return value smaller than the buffer
6012 size if the message was truncated. (Bug#8545).
6014 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6016 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6017 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6019 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6021 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6023 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6025 * makefile.w32-in: Update dependencies.
6027 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6029 Improve `doprnt' and its usage. (Bug#8545)
6030 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6031 `format_end'. Remove support for %l as a conversion specifier.
6032 Don't use xrealloc. Improve diagnostics when the %l size modifier
6033 is used. Update the commentary.
6035 * eval.c (verror): Simplify calculation of size_t.
6037 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6040 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6042 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6045 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6047 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6048 This makes this file independent of the recent pseudovector change.
6050 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6052 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6054 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6055 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6056 Remove unused local.
6057 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6059 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6060 GCC 4.6.0 optimizes based on type-based alias analysis.
6061 For example, if b is of type struct buffer * and v of type struct
6062 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6063 != &v->size, and therefore "v->size = 1; b->size = 2; return
6064 v->size;" must therefore return 1. This assumption is incorrect
6065 for Emacs, since it type-puns struct Lisp_Vector * with many other
6066 types. To fix this problem, this patch adds a new type struct
6067 vectorlike_header that documents the constraints on layout of vectors
6068 and pseudovectors, and helps optimizing compilers not get fooled
6069 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6070 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6071 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6073 (XSETPVECTYPE): Rewrite in terms of new macro.
6074 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6075 This is a bit clearer, and further avoids the possibility of
6076 undesirable aliasing.
6077 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6078 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6079 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6080 since Lisp_Subr is a special case (no "next" field).
6081 (ASIZE): Now uses header.size rather than size.
6082 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6083 to avoid the hassle of writing XVECTOR (foo)->header.size.
6084 (struct vectorlike_header): New type.
6085 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6086 object, to help avoid aliasing.
6087 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6088 (SUBRP): Likewise, since Lisp_Subr is a special case.
6089 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6090 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6091 (struct Lisp_Hash_Table): Combine first two members into a single
6092 struct vectorlike_header member. All uses of "size" and "next" members
6093 changed to be "header.size" and "header.next".
6094 * buffer.h (struct buffer): Likewise.
6095 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6096 * frame.h (struct frame): Likewise.
6097 * process.h (struct Lisp_Process): Likewise.
6098 * termhooks.h (struct terminal): Likewise.
6099 * window.c (struct save_window_data, struct saved_window): Likewise.
6100 * window.h (struct window): Likewise.
6101 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6102 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6103 * buffer.c (init_buffer_once): Likewise.
6104 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6106 * process.c (Fformat_network_address): Use local var for size,
6109 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6111 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6112 * data.c (atof): Remove decl; no longer used or needed.
6113 (digit_to_number): Move to lread.c.
6114 (Fstring_to_number): Use new string_to_number function, to be
6115 consistent with how the Lisp reader treats infinities and NaNs.
6116 Do not assume that floating-point numbers represent EMACS_INT
6117 without losing information; this is not true on most 64-bit hosts.
6118 Avoid double-rounding errors, by insisting on integers when
6119 parsing non-base-10 numbers, as the documentation specifies.
6120 * lisp.h (string_to_number): New decl, replacing ...
6121 (isfloat_string): Remove.
6122 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6123 (read1): Do not accept +. and -. as integers; this
6124 appears to have been a coding error. Similarly, do not accept
6125 strings like +-1e0 as floating point numbers. Do not report
6126 overflow for integer overflows unless the base is not 10 which
6127 means we have no simple and reliable way to continue.
6128 Break out the floating-point parsing into a new
6129 function string_to_number, so that Fstring_to_number parses
6130 floating point numbers consistently with the Lisp reader.
6131 (digit_to_number): Move here from data.c. Make it static inline.
6132 (E_CHAR, EXP_INT): Remove, replacing with ...
6133 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6134 (string_to_number): New function, replacing isfloat_string.
6135 This function checks for valid syntax and produces the resulting
6136 Lisp float number too. Rework it so that string-to-number
6137 no longer mishandles examples like "1.0e+". Use strtoumax,
6138 so that overflow for non-base-10 numbers is reported only when
6139 there's no portable and simple way to convert to floating point.
6141 * textprop.c (set_text_properties_1): Rewrite for clarity,
6142 and to avoid GCC warning about integer overflow.
6144 * intervals.h (struct interval): Use EMACS_INT for members
6145 where EMACS_UINT might cause problems. See
6146 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6147 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6148 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6150 (offset_intervals): Tell GCC not to worry about length overflow
6151 when negating a negative length.
6153 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6154 (overrun_check_free): Likewise.
6156 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6157 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6160 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6161 (gnutls_make_error): Rename local to avoid shadowing.
6162 (gnutls_emacs_global_deinit): ifdef out; not used.
6163 (Fgnutls_boot): Use const for pointer to readonly storage.
6164 Comment out unused local. Fix pointer signedness problems.
6166 * lread.c (openp): Don't stuff size_t into an 'int'.
6167 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6168 about possible signed overflow.
6170 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6171 (GDK_KEY_g): Don't define if already defined.
6172 (xg_prepare_tooltip): Avoid pointer signedness problem.
6173 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6175 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6176 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6178 * xfns.c (Fx_window_property): Simplify a bit,
6179 to make a bit faster and to avoid GCC 4.6.0 warning.
6180 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6182 * fns.c (internal_equal): Don't assume size_t fits in int.
6184 * alloc.c (compact_small_strings): Tighten assertion a little.
6186 Replace pEd with more-general pI, and fix some printf arg casts.
6187 * lisp.h (pI): New macro, generalizing old pEd macro to other
6188 conversion specifiers. For example, use "...%"pI"d..." rather
6189 than "...%"pEd"...".
6190 (pEd): Remove. All uses replaced with similar uses of pI.
6191 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6192 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6193 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6194 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6195 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6196 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6197 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6199 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6200 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6201 * print.c (safe_debug_print, print_object): Likewise.
6202 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6204 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6205 avoiding the 0 flag, which is not portable.
6206 * process.c (Fmake_network_process): Use pI to avoid cast.
6207 * region-cache.c (pp_cache): Likewise.
6208 * xdisp.c (decode_mode_spec): Likewise.
6209 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6210 behavior on 64-bit hosts with printf arg.
6211 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6212 (x_stop_queuing_selection_requests): Likewise.
6213 (x_get_window_property): Don't truncate byte count to an 'int'
6216 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6217 here, since it parses constructs like leading '-' and spaces,
6218 which are not wanted; and it overflows with large numbers.
6219 Instead, simply match F[0-9]+, which is what is wanted anyway.
6221 * alloc.c: Remove unportable assumptions about struct layout.
6222 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6223 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6224 (allocate_vectorlike, make_pure_vector): Use the new macros,
6225 plus offsetof, to remove unportable assumptions about struct layout.
6226 These assumptions hold on all porting targets that I know of, but
6227 they are not guaranteed, they're easy to remove, and removing them
6228 makes further changes easier.
6230 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6231 This doesn't fix a bug but makes the code clearer.
6232 (string_overrun_cookie): Now const. Use initializers that
6233 don't formally overflow signed char, to avoid warnings.
6234 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6235 can cause Emacs to crash when string overrun checking is enabled.
6236 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6237 multiple of sizeof (EMACS_INT); it need not be, if
6238 alignof(EMACS_INT) < sizeof (EMACS_INT).
6239 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6241 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6243 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6245 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6247 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6248 supposed to be handshaking. (Bug#8556)
6249 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6251 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6253 * lisp.h (Qdebug): List symbol.
6254 * eval.c (Qdebug): Restore global linkage.
6255 * keyboard.c (debug-on-event): New variable.
6256 (handle_user_signal): Break into debugger when debug-on-event
6257 matches the current signal symbol.
6259 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6261 * alloc.c (check_sblock, check_string_bytes)
6262 (check_string_free_list): Convert to standard C.
6264 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6266 * w32.c (emacs_gnutls_push): Fix typo.
6268 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6270 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6271 "cast to pointer from integer of different size".
6273 Improve doprnt and its use in verror. (Bug#8545)
6274 * doprnt.c (doprnt): Document the set of format control sequences
6275 supported by the function. Use SAFE_ALLOCA instead of always
6278 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6279 is one byte too soon. Don't use xrealloc; instead xfree and
6282 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6284 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6287 * gnutls.c: Renamed global_initialized to
6288 gnutls_global_initialized. Added internals for the
6289 :verify-hostname-error, :verify-error, and :verify-flags
6290 parameters of `gnutls-boot' and documented those parameters in the
6291 docstring. Start callback support.
6292 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6293 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6294 on error. Return error code.
6295 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6296 (emacs_gnutls_read): Likewise.
6297 (Fgnutls_boot): Return handshake error code.
6298 (emacs_gnutls_handle_error): New function.
6299 (wsaerror_to_errno): Likewise.
6301 * w32.h (emacs_gnutls_pull): Add prototype.
6302 (emacs_gnutls_push): Likewise.
6304 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6305 (emacs_gnutls_push): Likewise.
6307 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6309 * process.c (wait_reading_process_output): Check if GnuTLS
6310 buffered some data internally if no FDs are set for TLS
6313 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6314 (LIBS): Link to USER_LIBS.
6315 ($(BLD)/gnutls.$(0)): New target.
6317 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6319 * xdisp.c (handle_single_display_spec): Rename the
6320 display_replaced_before_p argument into display_replaced_p, to
6321 make it consistent with the commentary. Fix typos in the
6324 * textprop.c (syms_of_textprop): Remove dead code.
6325 (copy_text_properties): Delete obsolete commentary about an
6326 interface that was deleted long ago. Fix typos in the description
6329 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6330 to changes in oldXMenu/XMenu.h from 2011-04-16.
6331 <menu_help_message, prev_menu_help_message>: Constify.
6332 (IT_menu_make_room): menu->help_text is now `const char **';
6335 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6336 to changes in oldXMenu/XMenu.h from 2011-04-16.
6337 (struct XMenu): Declare `help_text' `const char **'.
6339 * xfaces.c <Qunspecified>: Make extern again.
6341 * syntax.c: Include sys/types.h before including regex.h, as
6344 * doc.c (get_doc_string): Improve the format passed to `error'.
6346 * doprnt.c (doprnt): Improve commentary.
6348 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6350 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6353 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6354 changes in globals.h immediately force recompilation.
6355 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6356 $(CURDIR)/s/ms-w32.h.
6357 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6359 * character.c (Fchar_direction): Function deleted.
6360 (syms_of_character): Don't defsubr it.
6361 <char-direction-table>: Deleted.
6363 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6365 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6366 * doprnt.c: Include limits.h.
6367 (SIZE_MAX): New macro.
6368 (doprnt): Return a size_t value. 2nd arg is now size_t.
6369 Many local variables are now size_t instead of int or unsigned.
6370 Improve overflow protection. Support `l' modifier for integer
6371 conversions. Support %l conversion. Don't assume an EMACS_INT
6372 argument for integer conversions and for %c.
6374 * lisp.h (doprnt): Restore prototype.
6376 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6379 * Makefile.in (base_obj): Add back doprnt.o.
6381 * deps.mk (doprnt.o): Add back prerequisites.
6382 (callint.o): Depend on character.h.
6384 * eval.c (internal_lisp_condition_case): Include the handler
6385 representation in the error message.
6386 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6387 when breaking from the loop.
6389 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6391 * callint.c (Fcall_interactively): When displaying error message
6392 about invalid control letter, pass the character's codepoint, not
6393 a pointer to its multibyte form. Improve display of the character
6394 in octal and display also its hex code.
6396 * character.c (char_string): Use %x to display the (unsigned)
6397 codepoint of an invalid character, to avoid displaying a bogus
6400 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6401 `error', not SYMBOL_NAME itself.
6403 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6404 character arguments to `error'.
6406 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6407 to `error' in error message about FINAL_CHAR argument. Make sure
6408 FINAL_CHAR is a character, and use %c when it is passed as
6409 argument to `error'.
6411 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6413 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6415 * w32.c: Include <time.h>.
6416 (sys_localtime): New function.
6418 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6420 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6422 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6424 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6426 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6429 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6431 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6432 gl_state.e_property when gl_state.object is Qt.
6434 * insdel.c (make_gap_larger): Remove limitation of buffer size
6437 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6439 * xdisp.c (lookup_glyphless_char_display)
6440 (produce_glyphless_glyph): Handle cons cell entry in
6441 glyphless-char-display.
6442 (Vglyphless_char_display): Document it.
6444 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6445 glyphless-char-display.
6447 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6449 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6451 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6453 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6454 definition for no-X builds.
6456 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6458 Static checks with GCC 4.6.0 and non-default toolkits.
6460 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6462 * process.c (keyboard_bit_set): Define only if SIGIO.
6463 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6464 (send_process): Repair possible setjmp clobbering.
6466 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6468 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6470 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6472 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6473 Define only if needed.
6475 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6476 by pacifying GCC about it. Maybe it's time to retire it?
6477 * xfaces.c (USG, __TIMEVAL__): Likewise.
6479 * dispextern.h (struct redisplay_interface): Rename param
6481 * termhooks.h (struct terminal): Likewise.
6482 * xterm.c (xembed_send_message): Likewise.
6484 * insdel.c (make_gap_smaller): Define only if
6485 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6487 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6490 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6491 so that we aren't warned about unused symbols.
6493 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6495 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6497 * xfns.c (x_real_positions): Mark locals as initialized.
6499 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6501 * xterm.c: Fix problems found by static analysis with other toolkits.
6502 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6503 (x_dispatch_event): Declare static if USE_GTK, and
6504 define if USE_GTK || USE_X_TOOLKIT.
6505 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6506 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6507 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6508 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6510 * xmenu.c (menu_help_callback): Pointer type fixes.
6511 Use const pointers when pointing at readonly data. Avoid pointer
6513 (FALSE): Remove unused macro.
6514 (update_frame_menubar): Remove unused decl.
6516 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6518 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6519 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6520 (single_menu_item): Rename local to avoid shadowing.
6522 * keyboard.c (make_lispy_event): Remove unused local var.
6524 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6525 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6527 * bitmaps: Change bitmaps from unsigned char back to the X11
6528 compatible char. Avoid the old compiler warnings about
6529 out-of-range initializers by using, for example, '\xab' rather
6532 * xgselect.c (xgselect_initialize): Check vs interface
6533 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6535 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6537 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6538 to read-only memory.
6540 * fns.c (vector): Remove; this old hack is no longer needed.
6542 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6544 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6546 * xrdb.c (x_load_resources): Omit unused local.
6548 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6549 (x_window): Rename locals to avoid shadowing.
6550 (USG): Use the kludged USG macro, to pacify gcc.
6552 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6553 (x_term_init): Remove local to avoid shadowing.
6555 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6557 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6558 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6560 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6562 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6564 Fix regex.c, syntax.c and friends for buffers > 2GB.
6565 * syntax.h (struct gl_state_s): Declare character position members
6568 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6570 * textprop.c (verify_interval_modification, interval_of):
6571 Declare arguments EMACS_INT.
6573 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6576 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6578 * indent.c (Fvertical_motion): Local variable it_start is now
6581 * regex.c (re_match, re_match_2, re_match_2_internal)
6582 (bcmp_translate, regcomp, regexec, print_double_string)
6583 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6584 (re_compile_pattern, re_exec): Declare arguments and local
6585 variables `size_t' and `ssize_t' and return values `regoff_t', as
6587 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6588 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6589 <compile_stack_type>: `size' and `avail' are now `size_t'.
6591 * regex.h <regoff_t>: Use ssize_t, not int.
6592 (re_search, re_search_2, re_match, re_match_2): Arguments that
6593 specify buffer/string position and length are now ssize_t and
6594 size_t. Return type is regoff_t.
6596 2011-04-16 Ben Key <bkey76@gmail.com>
6598 * nsfont.m: Fixed bugs in ns_get_family and
6599 ns_descriptor_to_entity that were caused by using free to
6600 deallocate memory blocks that were allocated by xmalloc (via
6601 xstrdup). This caused Emacs to crash when compiled with
6602 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6603 --enable-checking=xmallocoverrun). xfree is now used to
6604 deallocate these memory blocks.
6606 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6608 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6610 emacs_write: Accept and return EMACS_INT for sizes.
6611 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6613 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6614 Accept and return EMACS_INT.
6615 (emacs_gnutls_write): Return the number of bytes written on
6617 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6618 (emacs_read, emacs_write): Remove check for negative size, as the
6619 Emacs source code has been audited now.
6620 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6621 (emacs_read, emacs_write): Use it.
6622 * process.c (send_process): Adjust to the new signatures of
6623 emacs_write and emacs_gnutls_write. Do not attempt to store
6624 a byte offset into an 'int'; it might overflow.
6625 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6627 * sound.c: Don't assume sizes fit in 'int'.
6628 (struct sound_device.period_size, alsa_period_size):
6629 Return EMACS_INT, not int.
6630 (struct sound_device.write, vox_write, alsa_write):
6631 Accept EMACS_INT, not int.
6632 (wav_play, au_play): Use EMACS_INT to store sizes and to
6633 record read return values.
6635 2011-04-15 Ben Key <bkey76@gmail.com>
6637 * keyboard.c (Qundefined): Don't declare static since it is used
6639 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6640 static since they are used in nsfont.m.
6642 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6644 * process.c (Qprocessp): Don't declare static.
6645 * lisp.h (Qprocessp): Declare again.
6647 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6649 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6651 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6653 Improve C-level modularity by making more things 'static'.
6655 Don't publish debugger-only interfaces to other modules.
6656 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6657 (verify_bytepos, count_markers): Move decls to the only modules
6659 * region-cache.h (pp_cache): Likewise.
6660 * window.h (check_all_windows): Likewise.
6661 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6663 * sysdep.c (croak): Now static, if
6664 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6665 * syssignal.h (croak): Declare only if not static.
6667 * alloc.c (refill_memory_reserve): Now static if
6668 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6669 * lisp.h (refill_memory_reserve): Declare only if not static.
6671 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6672 Define only if USE_LUCID.
6674 * xrdb.c (x_customization_string, x_rm_string): Now static.
6676 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6677 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6679 * xdisp.c (draw_row_with_mouse_face): Now static.
6680 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6682 * window.h (check_all_windows): Mark externally visible.
6684 * window.c (window_deletion_count): Now static.
6686 * undo.c: Make symbols static if they're not exported.
6687 (last_undo_buffer, last_boundary_position, pending_boundary):
6690 * textprop.c (interval_insert_behind_hooks): Now static.
6691 (interval_insert_in_front_hooks): Likewise.
6693 * term.c: Make symbols static if they're not exported.
6694 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6695 (max_frame_lines, tty_set_terminal_modes):
6696 (tty_reset_terminal_modes, tty_turn_off_highlight):
6697 (get_tty_terminal): Now static.
6698 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6699 * termhooks.h (term_mouse_moveto): Do not declare if
6701 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6702 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6704 * sysdep.c: Make symbols static if they're not exported.
6705 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6707 (sigprocmask_set, full_mask): Remove; unused.
6708 (wait_debugging): Mark as visible.
6709 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6710 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6712 * syntax.c (syntax_temp): Define only if !__GNUC__.
6714 * sound.c (current_sound_device, current_sound): Now static.
6716 * search.c (searchbufs, searchbuf_head): Now static.
6718 * scroll.c (scroll_cost): Remove; unused.
6719 * dispextern.h (scroll_cost): Remove decl.
6721 * region-cache.h (pp_cache): Mark as externally visible.
6723 * process.c: Make symbols static if they're not exported.
6724 (process_tick, update_tick, create_process, chan_process):
6725 (Vprocess_alist, proc_buffered_char, datagram_access):
6726 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6727 (deactivate_process): Mark defn as static, as well as decl.
6728 * lisp.h (create_process): Remove decl.
6729 * process.h (chan_process, Vprocess_alist): Remove decls.
6731 * print.c: Make symbols static if they're not exported.
6732 (print_depth, new_backquote_output, being_printed, print_buffer):
6733 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6734 (print_interval, print_number_index, initial_stderr_stream):
6736 * lisp.h (Fprinc): Remove decl.
6737 (debug_output_compilation_hack): Mark as externally visible.
6739 * sysdep.c (croak): Move decl from here to syssignal.h.
6740 * syssignal.h (croak): Put it here, so the API can be checked when
6741 'croak' is called from dissociate_if_controlling_tty.
6743 * minibuf.c: Make symbols static if they're not exported.
6744 (minibuf_save_list, choose_minibuf_frame): Now static.
6745 * lisp.h (choose_minibuf_frame): Remove decl.
6747 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6749 * lread.c: Make symbols static if they're not exported.
6750 (read_objects, initial_obarray, oblookup_last_bucket_number):
6752 (make_symbol): Remove; unused.
6753 * lisp.h (initial_obarray, make_symbol): Remove decls.
6755 * keyboard.c: Make symbols static if they're not exported.
6756 (single_kboard, recent_keys_index, total_keys, recent_keys):
6757 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6758 (this_single_command_key_start, echoing, last_auto_save):
6759 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6760 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6761 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6762 (Vlispy_mouse_stem, double_click_count):
6764 (force_auto_save_soon): Define only if SIGDANGER.
6765 (ignore_mouse_drag_p): Now static if
6766 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6767 (print_help): Remove; unused.
6768 (stop_character, last_timer_event): Mark as externally visible.
6769 * keyboard.h (ignore_mouse_drag_p): Declare only if
6770 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6771 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6772 * lisp.h (echoing): Remove decl.
6773 (force_auto_save_soon): Declare only if SIGDANGER.
6774 * xdisp.c (redisplay_window): Simplify code, to make it more
6775 obvious that ignore_mouse_drag_p is not accessed if !defined
6776 USE_GTK && !defined HAVE_NS.
6778 * intervals.c: Make symbols static if they're not exported.
6779 (merge_properties_sticky, merge_interval_right, delete_interval):
6781 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6783 * insdel.c: Make symbols static if they're not exported.
6784 However, leave prepare_to_modify_buffer alone. It's never
6785 called from outside this function, but that appears to be a bug.
6786 (combine_after_change_list, combine_after_change_buffer):
6787 (adjust_after_replace, signal_before_change): Now static.
6788 (adjust_after_replace_noundo): Remove; unused.
6789 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6790 (signal_before_change): Remove decls.
6792 * indent.c (val_compute_motion, val_vmotion): Now static.
6794 * image.c: Make symbols static if they're not exported.
6795 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6797 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6798 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6800 * fringe.c (standard_bitmaps): Now static.
6801 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6803 * frame.c: Make symbols static if they're not exported.
6804 (x_report_frame_params, make_terminal_frame): Now static.
6805 (get_frame_param): Now static, unless HAVE_NS.
6806 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6807 (x_get_resource_string): Remove; not used.
6808 * frame.h (make_terminal_frame, x_report_frame_params):
6809 (x_get_resource_string); Remove decls.
6810 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6811 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6813 * font.c, fontset.c: Make symbols static if they're not exported.
6814 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6815 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6816 * font.c (font_close_object): Now static.
6817 * font.h (font_close_object): Remove.
6818 * fontset.c (FONTSET_OBJLIST): Remove.
6819 (free_realized_fontset) #if-0 the body, which does nothing.
6820 (face_suitable_for_char_p): #if-0, as it's never called.
6821 * fontset.h (face_suitable_for_char_p): Remove decl.
6822 * xfaces.c (face_at_string_position):
6823 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6824 since 0 is always ASCII.
6826 * fns.c (weak_hash_tables): Now static.
6828 * fileio.c: Make symbols static if they're not exported.
6829 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6830 (Vwrite_region_annotation_buffers): Now static.
6832 * eval.c: Make symbols static if they're not exported.
6833 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6834 * lisp.h (backtrace_list): Remove decl.
6836 * emacs.c: Make symbols static if they're not exported.
6837 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6838 (fatal_error_code, fatal_error_signal_hook, standard_args):
6840 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6841 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6842 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6843 * lisp.h (fatal_error_signal_hook): Remove decl.
6844 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6846 * editfns.c: Move a (normally-unused) function to its only use.
6847 * editfns.c, lisp.h (get_operating_system_release): Remove.
6848 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6849 worth the hassle of breaking this out.
6851 * xterm.c: Make symbols static if they're not exported.
6852 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6853 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6854 (x_destroy_window, x_delete_display):
6856 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6857 (x_mouse_leave): Remove; unused.
6858 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6859 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6860 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6862 (x_mouse_leave): Declare only if WINDOWSNT.
6863 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6864 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6867 * ftxfont.c: Make symbols static if they're not exported.
6868 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6870 * font.h (ftxfont_driver): Likewise.
6872 * xfns.c: Make symbols static if they're not exported.
6873 (x_last_font_name, x_display_info_for_name):
6874 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6875 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6876 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6877 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6878 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6879 (last_show_tip_args): Now static.
6880 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6881 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6882 (x_screen_planes): Remove; unused.
6883 * dispextern.h (x_screen_planes): Remove decl.
6885 * dispnew.c: Make symbols static if they're not exported.
6886 * dispextern.h (redraw_garbaged_frames, scrolling):
6887 (increment_row_positions): Remove.
6888 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6889 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6891 (redraw_garbaged_frames): Remove; unused.
6893 * xfaces.c: Make symbols static if they're not exported.
6894 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6896 * xterm.h (defined_color): Remove decls.
6897 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6898 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6899 (menu_face_changed_default, defined_color, free_realized_face):
6900 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6901 (ascii_face_of_lisp_face): Remove; unused.
6903 * xdisp.c: Make symbols static if they're not exported.
6904 * dispextern.h (scratch_glyph_row, window_box_edges):
6905 (glyph_to_pixel_coords, set_cursor_from_row):
6906 (get_next_display_element, set_iterator_to_next):
6907 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6908 (show_mouse_face): Remove decls
6909 * frame.h (message_buf_print): Likewise.
6910 * lisp.h (pop_message, set_message, check_point_in_composition):
6912 * xterm.h (set_vertical_scroll_bar): Likewise.
6913 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6914 (message_buf_print, scratch_glyph_row, displayed_buffer):
6915 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6916 (get_next_display_element, show_mouse_face, window_box_edges):
6917 (frame_to_window_pixel_xy, check_point_in_composition):
6918 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6919 (glyph_to_pixel_coords): Remove; unused.
6921 * dired.c (file_name_completion): Now static.
6923 * dbusbind.c (xd_in_read_queued_messages): Now static.
6925 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6926 * data.c (circular_list_error): Remove.
6928 * commands.h (last_point_position, last_point_position_buffer):
6929 (last_point_position_window): Remove decls.
6930 * keyboard.c: Make these variables static.
6932 * coding.h (coding, code_convert_region, encode_coding_gap):
6934 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6935 (iso_code_class, detect_coding, code_convert_region): Now static.
6936 (encode_coding_gap): Remove; unused.
6938 * chartab.c (chartab_chars, chartab_bits): Now static.
6940 * charset.h (charset_iso_8859_1): Remove decl.
6941 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6944 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6945 * ccl.c (Vccl_program_table): Now static.
6946 (check_ccl_update): Remove; unused.
6948 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6949 * category.h: ... from here.
6950 * category.c (check_category_table, set_category_set): Now static.
6952 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6953 * lisp.h: Remove these decls.
6955 * buffer.c (buffer_count): Remove unused var.
6957 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6958 so that it's not optimized away.
6959 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6960 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6961 exported only to the debugger.
6963 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6964 * atimer.h (run_all_atimers): Remove; not exported.
6966 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6967 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6968 was inaccessible from Lisp.
6969 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6970 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6972 alloc.c: Import and export fewer symbols, and remove unused items.
6973 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6975 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6976 it's not optimized away by whole-program optimization.
6977 (message_enable_multibyte, free_misc): Remove.
6978 (catchlist, handlerlist, mark_backtrace):
6979 Declare only if BYTE_MARK_STACK.
6980 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6981 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6982 (message_enable_multibyte): Remove decl.
6983 (free_misc, interval_free_list, float_block, float_block_index):
6984 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6985 (cons_free_list, last_marked_index):
6987 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6988 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6989 (mark_backtrace): Define only if BYTE_MARK_STACK.
6990 * xdisp.c (message_enable_multibyte): Now static.
6992 Declare Lisp_Object Q* variables to be 'static' if not exported.
6993 This makes it easier for human readers (and static analyzers)
6994 to see whether these variables are used from other modules.
6995 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6996 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6997 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6998 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6999 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7000 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7001 * xmenu.c, xselect.c:
7002 Declare Q* vars static if they are not used in other modules.
7003 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7004 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7005 Remove decls of unexported vars.
7006 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7008 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7010 Make Emacs functions such as Fatom 'static' by default.
7011 This makes it easier for human readers (and static analyzers)
7012 to see whether these functions can be called from other modules.
7013 DEFUN now defines a static function. To make the function external
7014 so that it can be used in other C modules, use the new macro DEFUE.
7015 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7016 (Finit_image_library):
7017 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7018 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7019 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7020 Remove decls, since these functions are now static.
7021 (Funintern, Fget_internal_run_time): New decls, since these functions
7022 were already external.
7024 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7025 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7026 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7027 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7028 * keyboard.c, keymap.c, lread.c:
7029 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7030 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7031 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7032 Mark functions with DEFUE instead of DEFUN,
7033 if they are used in other modules.
7034 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7035 decls for now-static functions.
7036 * buffer.h (Fdelete_overlay): Remove decl.
7037 * callproc.c (Fgetenv_internal): Mark as internal.
7038 * composite.c (Fremove_list_of_text_properties): Remove decl.
7039 (Fcomposition_get_gstring): New forward static decl.
7040 * composite.h (Fcomposite_get_gstring): Remove decl.
7041 * dired.c (Ffile_attributes): New forward static decl.
7042 * doc.c (Fdocumntation_property): New forward static decl.
7043 * eval.c (Ffetch_bytecode): New forward static decl.
7044 (Funintern): Remove extern decl; now in .h file where it belongs.
7045 * fileio.c (Fmake_symbolic_link): New forward static decl.
7046 * image.c (Finit_image_library): New forward static decl.
7047 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7048 * intervals.h (Fprevious_property_change):
7049 (Fremove_list_of_text_properties): Remove decls.
7050 * keyboard.c (Fthis_command_keys): Remove decl.
7051 (Fcommand_execute): New forward static decl.
7052 * keymap.c (Flookup_key): New forward static decl.
7053 (Fcopy_keymap): Now static.
7054 * keymap.h (Flookup_key): Remove decl.
7055 * process.c (Fget_process): New forward static decl.
7056 (Fprocess_datagram_address): Mark as internal.
7057 * syntax.c (Fsyntax_table_p): New forward static decl.
7058 (skip_chars): Remove duplicate decl.
7059 * textprop.c (Fprevious_property_change): New forward static decl.
7060 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7062 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7063 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7065 * editfns.c (Fformat): Remove unreachable code.
7067 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7069 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7072 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7074 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7075 when at ZV. (Bug#8487)
7077 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7079 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7081 * keyboard.c (parse_tool_bar_item): Likewise.
7082 * sound.c (sound_cleanup, alsa_close): Likewise.
7083 * termcap.c (tgetent): Likewise.
7084 * xfns.c (x_default_font_parameter): Likewise.
7085 * xsettings.c (read_and_apply_settings): Likewise.
7087 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7088 (overrun_check_free): Protoize.
7090 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7092 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7093 since callers should never pass a negative size.
7094 Change the signature to match that of plain 'read' and 'write'; see
7095 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7096 * lisp.h: Update prototypes of emacs_write and emacs_read.
7098 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7100 * xdisp.c (redisplay_window): Don't try to determine the character
7101 position of the scroll margin if the window start point w->startp
7102 is outside the buffer's accessible region. (Bug#8468)
7104 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7106 Fix write-region and its subroutines for buffers > 2GB.
7107 * fileio.c (a_write, e_write): Modify declaration of arguments and
7108 local variables to support buffers larger than 2GB.
7109 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7111 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7112 argument, local variables, and return value.
7114 * lisp.h: Update prototypes of emacs_write and emacs_read.
7116 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7118 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7120 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7122 Fix more problems found by GCC 4.6.0's static checks.
7124 * xdisp.c (vmessage): Use a better test for character truncation.
7126 * charset.c (load_charset_map): <, not <=, for optimization,
7127 and to avoid potential problems with integer overflow.
7128 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7129 * casetab.c (set_identity, shuffle): Likewise.
7130 * editfns.c (Fformat): Likewise.
7131 * syntax.c (skip_chars): Likewise.
7133 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7134 This also lets GCC 4.6.0 generate slightly better loop code.
7136 * callint.c (Fcall_interactively): <, not <=, for optimization.
7137 (Fcall_interactively): Count the number of arguments produced,
7138 not the number of arguments given. This is simpler and lets GCC
7139 4.6.0 generate slightly better code.
7141 * ftfont.c: Distingish more carefully between FcChar8 and char.
7142 The previous code passed unsigned char * to a functions like
7143 strlen and xstrcasecmp that expect char *, which does not
7144 conform to the C standard.
7145 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7146 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7147 char * when the C standard requires it.
7149 * keyboard.c (read_char): Remove unused var.
7151 * eval.c: Port to Windows vsnprintf (Bug#8435).
7153 (SIZE_MAX): Define if the headers do not.
7154 (verror): Do not give up if vsnprintf returns a negative count.
7155 Instead, grow the buffer. This ports to Windows vsnprintf, which
7156 does not conform to C99. Problem reported by Eli Zaretskii.
7157 Also, simplify the allocation scheme, by avoiding the need for
7158 calling realloc, and removing the ALLOCATED variable.
7160 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7162 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7163 But keep the doprint source code for now, as we might revamp it
7164 and use it again (Bug#8435).
7165 * lisp.h (doprnt): Remove.
7166 * Makefile.in (base_obj): Remove doprnt.o.
7167 * deps.mk (doprnt.o): Remove.
7169 error: Print 32- and 64-bit integers portably (Bug#8435).
7170 Without this change, on typical 64-bit hosts error ("...%d...", N)
7171 was used to print both 32- and 64-bit integers N, which relied on
7173 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7175 * lisp.h (error, verror): Mark as printf-like functions.
7176 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7177 Report overflow in size calculations when allocating printf buffer.
7178 Do not truncate output string at its first null byte.
7179 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7180 Truncate the output at a character boundary, since vsnprintf does not
7182 * charset.c (check_iso_charset_parameter): Convert internal
7183 character to string before calling 'error', since %c now has the
7185 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7186 overflow when computing char to be passed to 'error'. Do not
7187 pass Lisp_Object to 'error'; pass the integer instead.
7188 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7189 formatted with plain %d.
7191 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7193 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7195 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7197 * xterm.c (x_catch_errors): Remove duplicate declaration.
7199 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7201 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7203 2011-04-10 Jim Meyering <meyering@redhat.com>
7205 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7206 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7207 return ssize_t not "int", and use size_t as the buffer length.
7208 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7209 * gnutls.h: Update declarations.
7210 * process.c (read_process_output): Use ssize_t, to match.
7211 (send_process): Likewise.
7213 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7215 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7217 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7219 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7220 Use unsigned char, to match FcChar8 type definition.
7222 * xterm.c (handle_one_xevent):
7223 * xmenu.c (create_and_show_popup_menu):
7224 * xselect.c (x_decline_selection_request)
7225 (x_reply_selection_request): Avoid type-punned deref of X events.
7227 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7229 Fix some uses of `int' instead of EMACS_INT.
7230 * search.c (string_match_1, fast_string_match)
7231 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7232 (scan_buffer, find_next_newline_no_quit)
7233 (find_before_next_newline, search_command, Freplace_match)
7234 (Fmatch_data): Make some `int' variables be EMACS_INT.
7236 * xdisp.c (display_count_lines): 3rd argument and return value now
7237 EMACS_INT. All callers changed.
7238 (pint2hrstr): Last argument is now EMACS_INT.
7240 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7241 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7242 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7243 (decode_coding_utf_16, decode_coding_emacs_mule)
7244 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7245 (decode_coding_ccl, decode_coding_charset)
7246 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7247 (decode_coding_iso_2022, decode_coding_emacs_mule)
7248 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7249 <char_offset, last_offset>: Declare EMACS_INT.
7250 (encode_coding_utf_8, encode_coding_utf_16)
7251 (encode_coding_emacs_mule, encode_invocation_designation)
7252 (encode_designation_at_bol, encode_coding_iso_2022)
7253 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7254 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7256 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7257 (encode_invocation_designation): Last argument P_NCHARS is now
7259 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7260 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7262 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7265 * ccl.c (Fccl_execute_on_string): Declare some variables
7268 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7270 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7272 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7274 * process.c (Fformat_network_address): Doc fix.
7276 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7278 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7280 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7282 * keyboard.c (read_char): Call Lisp function help-form-show,
7283 instead of using internal_with_output_to_temp_buffer.
7284 (Qhelp_form_show): New var.
7285 (syms_of_keyboard): Use DEFSYM macro.
7287 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7289 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7291 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7293 * process.c (Flist_processes): Remove to Lisp.
7294 (list_processes_1): Delete.
7296 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7298 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7300 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7302 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7304 Fix more problems found by GCC 4.6.0's static checks.
7306 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7308 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7310 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7312 * xdisp.c (vmessage): Mark as a printf-like function.
7314 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7316 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7318 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7319 printf-like functions.
7320 (tiff_load): Add casts to remove these marks before passing them
7321 to system-supplied API.
7323 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7325 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7326 This avoids several warnings with gcc -Wstrict-overflow.
7327 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7328 directly, rather than having caller test rule sign. This avoids
7329 some unnecessary tests.
7330 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7331 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7332 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7334 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7335 (xfont_open): Avoid unnecessary tests.
7337 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7339 * composite.h, composite.c (composition_gstring_put_cache):
7340 Use EMACS_INT, not int, for length.
7342 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7343 breaking out part of COMPOSITION_DECODE_RULE.
7344 (COMPOSITION_DECODE_RULE): Use it.
7345 * composite.c (get_composition_id): Remove unused local vars,
7346 by using the new macro.
7348 * textprop.c (set_text_properties_1): Change while to do-while,
7349 since the condition is always true at first.
7351 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7352 (interval_deletion_adjustment): Return unsigned value.
7355 * process.c (list_processes_1, create_pty, read_process_output):
7356 (exec_sentinel): Remove vars that were set but not used.
7357 (create_pty): Remove unnecessary "volatile"s.
7358 (Fnetwork_interface_info): Avoid possibility of int overflow.
7359 (read_process_output): Do adaptive read buffering even if carryover.
7360 (read_process_output): Simplify nbytes computation if buffered.
7362 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7364 * syntax.c (scan_words): Remove var that was set but not used.
7365 (update_syntax_table): Use unsigned instead of int.
7367 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7368 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7369 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7371 * print.c (print_error_message): Avoid int overflow.
7373 * font.c (font_list_entities): Redo for clarity,
7374 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7376 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7377 (font_score): Avoid potential overflow in diff calculation.
7379 * fns.c (substring_both): Remove var that is set but not used.
7380 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7382 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7384 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7385 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7386 can always succeed if overflow has undefined behavior.
7388 * search.c (boyer_moore, wordify): Remove vars set but not used.
7389 (wordify): Omit three unnecessary tests.
7391 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7392 All callers changed. This avoids the need for an unused var.
7394 * casefiddle.c (casify_region): Remove var that is set but not used.
7396 * dired.c (file_name_completion): Remove var that is set but not used.
7398 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7400 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7401 (Finsert_file_contents): Remove unnecessary code checking fd.
7403 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7404 Check for integer overflow on size calculations.
7406 * buffer.c (Fprevious_overlay_change): Remove var that is set
7409 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7410 Remove vars that are set but not used.
7411 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7412 (timer_check_2): Mark vars as initialized.
7414 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7416 * image.c (lookup_image): Remove var that is set but not used.
7417 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7419 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7420 that are set but not used.
7422 * xfns.c (make_invisible_cursor): Don't return garbage
7423 if XCreateBitmapFromData fails (Bug#8410).
7425 * xselect.c (x_get_local_selection, x_handle_property_notify):
7426 Remove vars that are set but not used.
7428 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7429 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7431 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7432 Remove var that is set but not used.
7433 (scroll_bar_windows_size): Now size_t, not int.
7434 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7437 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7438 (map_tty_color) [!defined MSDOS]: Likewise.
7440 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7442 * coding.c: Remove vars that are set but not used.
7443 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7444 All callers changed.
7445 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7446 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7447 (decode_coding_charset): Remove vars that are set but not used.
7449 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7450 that is set but not used.
7452 * print.c (print_object): Remove var that is set but not used.
7454 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7455 The gnulib version avoids calling malloc in the usual case,
7456 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7457 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7458 * filelock.c (current_lock_owner): Likewise.
7459 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7460 * sysdep.c: Include allocator.h, careadlinkat.h.
7461 (emacs_no_realloc_allocator): New static constant.
7462 (emacs_readlink): New function.
7463 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7464 ../lib/careadlinkat.h.
7466 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7468 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7469 first non-nil return value).
7471 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7473 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7474 if not defined (Bug#8403).
7476 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7478 * xdisp.c (display_count_lines): Remove parameter `start',
7479 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7480 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7481 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7482 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7483 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7484 and thereabouts. All callers changed.
7485 (get_per_char_metric): Remove parameter `f', unused since
7486 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7488 2011-04-02 Jim Meyering <meyering@redhat.com>
7490 do not dereference NULL upon failed strdup
7491 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7492 (ns_get_family): Likewise.
7494 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7496 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7498 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7500 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7503 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7505 Add lexical binding.
7507 * window.c (Ftemp_output_buffer_show): New fun.
7508 (Fsave_window_excursion):
7509 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7511 * lread.c (lisp_file_lexically_bound_p): New function.
7512 (Fload): Bind Qlexical_binding.
7513 (readevalloop): Remove `evalfun' arg.
7514 Bind Qinternal_interpreter_environment.
7515 (Feval_buffer): Bind Qlexical_binding.
7516 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7518 (syms_of_lread): Declare `lexical-binding'.
7520 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7522 * keyboard.c (eval_dyn): New fun.
7523 (menu_item_eval_property): Use it.
7525 * image.c (parse_image_spec): Use Ffunctionp.
7527 * fns.c (concat, mapcar1): Accept byte-code-functions.
7529 * eval.c (Fsetq): Handle lexical vars.
7530 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7531 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7532 (FletX, Flet): Obey lexical binding.
7533 (Fcommandp): Handle closures.
7534 (Feval): New `lexical' arg.
7535 (eval_sub): New function extracted from Feval. Use it almost
7536 everywhere where Feval was used. Look up vars in lexical env.
7538 (Ffunctionp): Move from subr.el.
7539 (Ffuncall): Handle closures.
7540 (apply_lambda): Remove `eval_flags'.
7541 (funcall_lambda): Handle closures and new byte-code-functions.
7542 (Fspecial_variable_p): New function.
7543 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7544 but without exporting it to Lisp.
7546 * doc.c (Fdocumentation, store_function_docstring):
7547 * data.c (Finteractive_form): Handle closures.
7549 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7552 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7554 (exec_byte_code): New function extracted from Fbyte_code to handle new
7555 calling convention for byte-code-functions. Add new byte-codes.
7557 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7559 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7561 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7563 * xdisp.c (redisplay_internal): Fix prototype.
7565 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7567 * xdisp.c (SCROLL_LIMIT): New macro.
7568 (try_scrolling): Use it when setting scroll_limit.
7569 Limit scrolling to 100 screen lines.
7570 (redisplay_window): Even when falling back on "recentering",
7571 position point in the window according to scroll-conservatively,
7572 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7574 (try_scrolling): When point is above the window, allow searching
7575 as far as scroll_max, or one screenful, to compute vertical
7576 distance from PT to the scroll margin position. This prevents
7577 try_scrolling from unnecessarily failing when
7578 scroll-conservatively is set to a value slightly larger than the
7579 window height. Clean up the case of PT below the margin at bottom
7580 of window: scroll_max can no longer be INT_MAX. When aggressive
7581 scrolling is in use, don't let point enter the opposite scroll
7582 margin as result of the scroll.
7583 (syms_of_xdisp) <scroll-conservatively>: Document the
7584 threshold of 100 lines for never-recentering scrolling.
7586 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7588 * dispextern.h (move_it_by_lines):
7589 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7590 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7591 (message_log_check_duplicate): Remove parameters `prev_bol' and
7592 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7593 (redisplay_internal): Remove parameter `preserve_echo_area',
7594 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7596 * indent.c (Fvertical_motion):
7597 * window.c (window_scroll_pixel_based, Frecenter):
7598 Don't pass `need_y_p' to `move_it_by_lines'.
7600 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7602 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7603 steal a few bits to be more compact.
7604 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7605 Remove unneeded casts.
7607 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7609 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7611 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7612 binding" message (bug#7967).
7614 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7616 Fix more problems found by GCC 4.6.0's static checks.
7618 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7619 Remove unused local var.
7621 * editfns.c (Fmessage_box): Remove unused local var.
7623 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7624 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7625 Omit unused local vars.
7626 * window.c (shrink_windows): Omit unused local var.
7627 * menu.c (digest_single_submenu): Omit unused local var.
7628 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7629 Omit unused local var.
7631 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7632 Don't assume string length fits in int.
7633 (keyremap_step, read_key_sequence): Use size_t for sizes.
7634 (read_key_sequence): Don't check last_real_key_start redundantly.
7636 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7637 instead of alloca (Bug#8344).
7639 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7640 (Fbacktrace_frame): Don't assume nframes fits in int.
7642 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7644 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7647 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7649 * cm.c (calccost): Turn while-do into do-while, for clarity.
7651 * keyboard.c (syms_of_keyboard): Use the same style as later
7652 in this function when indexing through an array. This also
7653 works around GCC bug 48267.
7655 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7657 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7659 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7660 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7662 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7663 This avoids undefined behavior on integer overflow, and is a bit
7664 more convenient anyway since it is compared to a size_t variable.
7666 Variadic C functions now count arguments with size_t, not int.
7667 This avoids an unnecessary limitation on 64-bit machines, which
7668 caused (substring ...) to crash on large vectors (Bug#8344).
7669 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7670 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7671 All variadic functions and their callers changed accordingly.
7672 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7673 * data.c (arith_driver, float_arith_driver): Likewise.
7674 * editfns.c (general_insert_function): Likewise.
7675 * eval.c (struct backtrace.nargs, interactive_p)
7676 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7677 (funcall_lambda, mark_backtrace): Likewise.
7678 * fns.c (concat): Likewise.
7679 * frame.c (x_set_frame_parameters): Likewise.
7680 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7681 0 if not found, not -1. All callers changed.
7683 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7684 (stack_copy_size): Now size_t, not int.
7685 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7687 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7689 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7690 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7691 All callers changed.
7693 * lisp.h (multibyte_char_to_unibyte):
7694 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7695 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7696 * character.h (CHAR_TO_BYTE8):
7697 * cmds.c (internal_self_insert):
7698 * editfns.c (general_insert_function):
7699 * keymap.c (push_key_description):
7700 * search.c (Freplace_match):
7701 * xdisp.c (message_dolog, set_message_1): All callers changed.
7703 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7705 * keyboard.c (safe_run_hook_funcall): New function.
7706 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7707 don't set the hook to nil, but remove the offending function instead.
7708 (Qcommand_hook_internal): Remove, unused.
7709 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7710 Vcommand_hook_internal.
7712 * eval.c (enum run_hooks_condition): Remove.
7713 (funcall_nil, funcall_not): New functions.
7714 (run_hook_with_args): Call each function through a `funcall' argument.
7715 Remove `cond' argument, now redundant.
7716 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7717 (Frun_hook_with_args_until_failure): Adjust accordingly.
7718 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7720 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7722 * dispextern.h (string_buffer_position): Remove declaration.
7724 * print.c (strout): Remove parameter `multibyte', unused since
7725 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7727 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7728 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7729 All callers changed.
7731 * w32.c (_wsa_errlist): Use braces for struct initializers.
7733 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7734 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7735 All callers changed.
7736 (string_buffer_position): Likewise. Also, make static (it's never
7737 used outside xdisp.c).
7738 (cursor_row_p): Remove parameter `w', unused since
7739 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7740 (decode_mode_spec): Remove parameter `precision', introduced during
7741 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7742 All callers changed.
7744 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7746 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7748 2011-03-27 Anders Lindgren <andlind@gmail.com>
7750 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7751 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7752 (ns_update_auto_hide_menu_bar): New functions.
7753 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7754 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7755 ns_constrain_all_frames.
7756 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7757 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7759 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7761 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7763 2011-03-27 Glenn Morris <rgm@gnu.org>
7765 * syssignal.h: Replace RETSIGTYPE with void.
7766 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7767 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7768 Replace SIGTYPE with void everywhere.
7769 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7770 * s/template.h (SIGTYPE): Remove commented out definition.
7772 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7774 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7775 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7777 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7779 * w32.c (read_unc_volume): Use parameter `henum', instead of
7780 global variable `wget_enum_handle'.
7782 * keymap.c (describe_vector): Remove parameters `indices' and
7783 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7784 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7786 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7788 * keyboard.c (timer_check): Remove parameter `do_it_now',
7789 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7790 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7791 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7793 * keyboard.c (read_char):
7794 * w32menu.c (w32_menu_display_help):
7795 * xmenu.c (show_help_event, menu_help_callback):
7796 Adjust calls to `show_help_echo'.
7798 * gtkutil.c (xg_maybe_add_timer):
7799 * keyboard.c (readable_events):
7800 * process.c (wait_reading_process_output):
7801 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7803 * insdel.c (adjust_markers_gap_motion):
7804 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7805 (gap_left, gap_right): Don't call it.
7807 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7809 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7810 incurred during fontification.
7812 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7814 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7815 (DEFVAR_PER_BUFFER): Don't pass it.
7817 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7818 (scrolling_window): Don't pass it.
7820 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7822 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7824 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7826 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7827 of variables specific to SELinux and computation of `encoded_absname'.
7829 * image.c (XPutPixel): Remove unused variable `height'.
7831 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7833 * unexw32.c (get_section_info): Remove unused variable `section'.
7835 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7836 (system_process_attributes): Remove unused variable `sess'.
7837 (sys_read): Remove unused variable `err'.
7839 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7840 (w32_wnd_proc): Remove unused variable `isdead'.
7841 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7842 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7843 (x_create_tip_frame): Remove unused variable `tem'.
7845 * w32inevt.c (w32_console_read_socket):
7846 Remove unused variable `no_events'.
7848 * w32term.c (x_draw_composite_glyph_string_foreground):
7849 Remove unused variable `width'.
7851 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7853 * w32term.c (x_set_glyph_string_clipping):
7854 Don't pass uninitialized region to CombineRgn.
7856 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7858 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7859 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7860 (Fx_close_connection): Remove unused variable `i'.
7862 * w32font.c (w32font_draw): Return number of glyphs.
7863 (w32font_open_internal): Remove unused variable `i'.
7864 (w32font_driver): Add missing initializer.
7866 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7867 (fill_in_menu): Remove unused variable `items_added'.
7869 * w32term.c (last_mouse_press_frame): Remove static global variable.
7870 (w32_clip_to_row): Remove unused variable `f'.
7871 (x_delete_terminal): Remove unused variable `i'.
7873 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7874 (NOTHING): Remove unused static global variable.
7875 (uniscribe_check_otf): Remove unused variable `table'.
7876 (uniscribe_font_driver): Add missing initializers.
7878 2011-03-23 Julien Danjou <julien@danjou.info>
7880 * term.c (Fsuspend_tty, Fresume_tty):
7881 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7882 * window.c (temp_output_buffer_show):
7883 * insdel.c (signal_before_change):
7884 * frame.c (Fhandle_switch_frame):
7885 * fileio.c (Fdo_auto_save):
7886 * emacs.c (Fkill_emacs):
7887 * editfns.c (save_excursion_restore):
7888 * cmds.c (internal_self_insert):
7889 * callint.c (Fcall_interactively):
7890 * buffer.c (Fkill_all_local_variables):
7891 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7893 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7894 unconditionnaly since it does the check itself.
7896 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7898 Fix more problems found by GCC 4.5.2's static checks.
7900 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7901 the first time through the loop, since we know p0 < p1 then.
7902 This also avoids a gcc -Wstrict-overflow warning.
7904 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7905 leading to a memory leak, possible in functions like
7906 load_charset_map_from_file that can allocate an unbounded number
7907 of objects (Bug#8318).
7909 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7910 that could (at least in theory) be that large.
7912 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7913 This is less likely to overflow, and avoids undefined behavior if
7914 overflow does occur. All callers changed. Use strtoul to scan
7915 for the unsigned long integer.
7916 (pint2hrstr): Simplify and tune code slightly.
7917 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7919 * scroll.c (do_scrolling): Work around GCC bug 48228.
7920 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7922 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7923 This also avoids a warning with gcc -Wstrict-overflow.
7924 (validate_x_resource_name): Simplify count usage.
7925 This also avoids a warning with gcc -Wstrict-overflow.
7927 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7930 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7932 * process.c (Fmake_network_process): Use socklen_t, not int,
7933 where POSIX says socklen_t is required in portable programs.
7934 This fixes a porting bug on hosts like 64-bit HP-UX, where
7935 socklen_t is wider than int (Bug#8277).
7936 (Fmake_network_process, server_accept_connection):
7937 (wait_reading_process_output, read_process_output):
7940 * process.c: Rename or move locals to avoid shadowing.
7941 (list_processes_1, Fmake_network_process):
7942 (read_process_output_error_handler, exec_sentinel_error_handler):
7943 Rename or move locals.
7944 (Fmake_network_process): Define label "retry_connect" only if needed.
7945 (Fnetwork_interface_info): Fix pointer signedness.
7946 (process_send_signal): Add cast to avoid pointer signedness problem.
7947 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7948 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7950 Make tparam.h and terminfo.c consistent.
7951 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7952 Include tparam.h instead, since it declares them.
7953 * cm.h (PC): Remove extern decl; tparam.h now does this.
7954 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7955 * terminfo.c: Include tparam.h, to check interfaces.
7956 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7957 (tparam): Adjust signature to match interface in tparam.h;
7958 this removes some undefined behavior. Check that outstring and len
7959 are zero, which they always are with Emacs.
7960 * tparam.h (PC, BC, UP): New extern decls.
7962 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7963 (xftfont_open): Rename locals to avoid shadowing.
7965 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7966 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7967 (OTF_TAG_SYM): Omit macro if not needed.
7968 (ftfont_list): Remove unused local.
7969 (get_adstyle_property, ftfont_pattern_entity):
7970 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7971 Rename locals to avoid shadowing.
7973 * xfont.c (xfont_list_family): Mark var as initialized.
7975 * xml.c (make_dom): Now static.
7977 * composite.c (composition_compute_stop_pos): Rename local to
7979 (composition_reseat_it): Remove unused locals.
7980 (find_automatic_composition, composition_adjust_point): Likewise.
7981 (composition_update_it): Mark var as initialized.
7982 (find_automatic_composition): Mark vars as initialized,
7983 with a FIXME (Bug#8290).
7985 character.h: Rename locals to avoid shadowing.
7986 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7987 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7988 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7989 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7992 * textprop.c (property_change_between_p): Remove; unused.
7994 * intervals.c (interval_start_pos): Now static.
7996 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7998 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7999 Rename locals to avoid shadowing.
8001 * sound.c (wav_play, au_play, Fplay_sound_internal):
8002 Fix pointer signedness.
8003 (alsa_choose_format): Remove unused local var.
8004 (wav_play): Initialize a variable to 0, to prevent undefined
8005 behavior (Bug#8278).
8007 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8009 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8011 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8012 clobbering (Bug#8298).
8013 * sysdep.c (sys_subshell): Likewise.
8014 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8016 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8017 This should get cleaned up, so that child_setup has the
8018 same signature on all platforms.
8020 * callproc.c (call_process_cleanup): Now static.
8021 (relocate_fd): Rename locals to avoid shadowing.
8023 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8025 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8026 not to be necessary, and produces flickering.
8028 2011-03-20 Glenn Morris <rgm@gnu.org>
8030 * config.in: Remove file.
8032 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8034 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8035 are now in src/globals.h.
8036 (syms_of_minibuf): Remove spurious & from previous change.
8038 2011-03-20 Leo <sdl.web@gmail.com>
8040 * minibuf.c (completing-read-function): New variable.
8041 (completing-read-default): Rename from completing-read.
8042 (completing-read): Call completing-read-function.
8044 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8046 * xfaces.c (Fx_load_color_file):
8047 Read color file from absolute filename (bug#8250).
8049 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8051 * makefile.w32-in: Update dependencies.
8053 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8055 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8057 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8059 Fix more problems found by GCC 4.5.2's static checks.
8061 * process.c (make_serial_process_unwind, send_process_trap):
8062 (sigchld_handler): Now static.
8064 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8065 That way, the code declares only the vars that it needs.
8066 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8067 * s/cygwin.h (PTY_ITERATION): Likewise.
8068 * s/darwin.h (PTY_ITERATION): Likewise.
8069 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8071 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8072 * process.c (allocate_pty): Don't declare stb unless it's needed.
8074 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8075 (CONSTANTLIM): Remove; unused.
8076 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8077 Define only if needed.
8079 * unexelf.c (unexec): Name an expression,
8080 to avoid gcc -Wbad-function-cast warning.
8081 Use a different way to cause a compilation error if anyone uses
8082 n rather than nn, a way that does not involve shadowing.
8083 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8085 * deps.mk (unexalpha.o): Remove; unused.
8087 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8088 * unexec.h: New file.
8089 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8090 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8092 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8093 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8094 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8095 Change as necessary to match prototype in unexec.h.
8097 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8099 (back_comment, skip_chars): Mark vars as initialized.
8101 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8102 Rename locals to avoid shadowing.
8104 * lread.c (read1): Rewrite so as not to use empty "else".
8105 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8107 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8109 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8110 warning when compiling print.c.
8112 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8113 instead of using an uninitialized var.
8114 (font_sort_entities): Mark var as initialized.
8116 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8118 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8119 pointers to constants.
8120 (font_parse_fcname): Remove unused vars.
8121 (font_delete_unmatched): Now static.
8122 (font_get_spec): Remove; unused.
8123 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8124 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8125 Rename or move locals to avoid shadowing.
8127 * fns.c (require_nesting_list, require_unwind): Now static.
8128 (Ffillarray): Rename locals to avoid shadowing.
8130 * floatfns.c (domain_error2): Define only if needed.
8131 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8133 * alloc.c (mark_backtrace): Move decl from here ...
8134 * lisp.h: ... to here, so that it can be checked.
8136 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8137 (Fdefvar): Rewrite so as not to use empty "else".
8138 (lisp_indirect_variable): Name an expression,
8139 to avoid gcc -Wbad-function-cast warning.
8140 (Fdefvar): Rename locals to avoid shadowing.
8142 * callint.c (quotify_arg, quotify_args): Now static.
8143 (Fcall_interactively): Rename locals to avoid shadowing.
8144 Use const pointer when appropriate.
8146 * lisp.h (get_system_name, get_operating_system_release):
8147 Move decls here, to check interfaces.
8148 * process.c (get_operating_system_release): Move decl to lisp.h.
8149 * xrdb.c (get_system_name): Likewise.
8150 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8151 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8152 some of which prompt warnings from gcc -Wbad-function-cast.
8153 (Fformat_time_string, Fencode_time, Finsert_char):
8154 (Ftranslate_region_internal, Fformat):
8155 Rename or remove local vars to avoid shadowing.
8156 (Ftranslate_region_internal): Mark var as initialized.
8158 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8161 * lisp.h (eassert): Check that the argument compiles, even if
8162 ENABLE_CHECKING is not defined.
8164 * data.c (Findirect_variable): Name an expression, to avoid
8165 gcc -Wbad-function-cast warning.
8166 (default_value, arithcompare, arith_driver, arith_error): Now static.
8167 (store_symval_forwarding): Rename local to avoid shadowing.
8168 (Fmake_variable_buffer_local, Fmake_local_variable):
8169 Mark variables as initialized.
8170 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8172 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8173 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8174 Rename locals to avoid shadowing.
8175 (mark_stack): Move local variables into the #ifdef region where
8177 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8178 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8180 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8181 (GC_STRING_CHARS): Remove; not used.
8182 (Fmemory_limit): Cast sbrk's returned value to char *.
8184 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8185 avoids undefined behavior in theory.
8187 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8189 Use functions, not macros, for up- and down-casing (Bug#8254).
8190 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8191 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8192 to use the following functions instead of these macros.
8193 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8194 EMACS_INT, since callers assume the returned value fits in int.
8195 (upcase1): Likewise, for UPCASE_TABLE.
8196 (uppercasep, lowercasep, upcase): New static inline functions.
8197 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8198 the race-condition problem in the old DOWNCASE.
8200 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8201 Rename locals to avoid shadowing.
8202 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8203 (regex_compile, re_search_2, re_match_2_internal):
8204 Remove unused local vars.
8205 (FREE_VAR): Rewrite so as not to use empty "else",
8206 which gcc can warn about.
8207 (regex_compile, re_match_2_internal): Mark locals as initialized.
8208 (RETALLOC_IF): Define only if needed.
8209 (WORDCHAR_P): Likewise. This one is never needed, but is used
8210 only in a comment talking about a compiler bug, so put inside
8211 the #if 0 of that comment.
8212 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8213 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8216 * search.c (boyer_moore): Rename locals to avoid shadowing.
8217 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8218 (PREV_CHAR_BOUNDARY): Likewise.
8220 * search.c (simple_search): Remove unused var.
8222 * dired.c (compile_pattern): Move decl from here ...
8223 * lisp.h: ... to here, so that it can be checked.
8224 (struct re_registers): New forward decl.
8226 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8228 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8230 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8231 Rename locals to avoid shadowing.
8232 (Fvertical_motion): Mark locals as initialized.
8234 * casefiddle.c (casify_object, casify_region): Now static.
8235 (casify_region): Mark local as initialized.
8237 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8239 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8240 New macros, so that the caller can use some names other than
8241 gcpro1, gcpro2, etc.
8242 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8244 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8245 argument, for consistency with GCPRO2_VAR, etc: it is now the
8246 prefix of the variable, not the variable itself. All uses
8248 * dired.c (directory_files_internal, file_name_completion):
8249 Rename locals to avoid shadowing.
8251 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8252 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8253 dired.c's scmp function, had undefined behavior.
8254 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8255 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8256 * buffer.h: ... to here, because these macros use current_buffer,
8257 and the new implementation with inline functions needs to have
8258 current_buffer in scope now, rather than later when the macros
8260 (downcase, upcase1): New static inline functions.
8261 (DOWNCASE, UPCASE1): Reimplement using these functions.
8262 This avoids undefined behavior in expressions like
8263 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8264 from race conditions in accessing the global variables
8265 case_temp1 and case_temp2.
8266 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8267 * lisp.h (case_temp1, case_temp2): Remove their decls.
8268 * character.h (ASCII_CHAR_P): Move from here ...
8269 * lisp.h: ... to here, so that the inline functions mentioned
8272 * dired.c (directory_files_internal_unwind): Now static.
8274 * fileio.c (file_name_as_directory, directory_file_name):
8275 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8277 (file_name_as_directory): Use const pointers when appropriate.
8278 (Fexpand_file_name): Likewise. In particular, newdir might
8279 point at constant storage, so make it a const pointer.
8280 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8281 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8283 (Fset_file_times, Finsert_file_contents, auto_save_error):
8284 Rename locals to avoid shadowing.
8286 * minibuf.c (choose_minibuf_frame_1): Now static.
8287 (Ftry_completion, Fall_completions): Rename or remove locals
8290 * marker.c (bytepos_to_charpos): Remove; unused.
8292 * lisp.h (verify_bytepos, count_markers): New decls,
8293 so that gcc does not warn that these functions aren't declared.
8295 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8296 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8297 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8298 (copy_text): Remove unused local var.
8300 * filelock.c (within_one_second): Now static.
8301 (lock_file_1): Rename local to avoid shadowing.
8303 * buffer.c (fix_overlays_before): Mark locals as initialized.
8304 (fix_start_end_in_overlays): Likewise. This function should be
8305 simplified by using pointers-to-pointers, but that's a different
8307 (switch_to_buffer_1): Now static.
8308 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8309 (report_overlay_modification): Rename locals to avoid shadowing.
8311 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8312 Fix pointer signedness issue.
8313 (sys_subshell): Mark local as volatile if checking for lint,
8314 to suppress a gcc -Wclobbered warning that does not seem to be right.
8315 (MAXPATHLEN): Define only if needed.
8317 * process.c (serial_open, serial_configure): Move decls from here ...
8318 * systty.h: ... to here, so that they can be checked.
8320 * fns.c (get_random, seed_random): Move extern decls from here ...
8321 * lisp.h: ... to here, so that they can be checked.
8323 * sysdep.c (reset_io): Now static.
8324 (wait_for_termination_signal): Remove; unused.
8326 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8327 (copy_keymap_item, append_key, push_text_char_description):
8329 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8330 (DENSE_TABLE_SIZE): Remove; unused.
8331 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8332 (describe_map_tree):
8333 Rename locals to avoid shadowing.
8335 * keyboard.c: Declare functions static if they are not used elsewhere.
8336 (echo_char, echo_dash, cmd_error, top_level_2):
8337 (poll_for_input, handle_async_input): Now static.
8338 (read_char, kbd_buffer_get_event, make_lispy_position):
8339 (make_lispy_event, make_lispy_movement, apply_modifiers):
8340 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8341 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8342 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8343 (read_key_sequence, read_char): Mark locals as initialized.
8344 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8346 * keyboard.h (make_ctrl_char): New decl.
8347 (mark_kboards): Move decl here ...
8348 * alloc.c (mark_kboards): ... from here.
8350 * lisp.h (force_auto_save_soon): New decl.
8352 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8353 (DEFINE_DUMMY_FUNCTION): New macro.
8354 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8356 (main): Add casts to avoid warnings
8357 if GCC considers string literals to be constants.
8359 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8361 * dbusbind.c: Pointer signedness fixes.
8362 (xd_signature, xd_append_arg, xd_initialize):
8363 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8364 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8365 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8366 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8368 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8369 if GCC considers string literals to be constants.
8370 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8372 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8374 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8375 (print_preprocess, print_object): New macro to fix last change.
8377 * print.c (print_preprocess): Don't forget font objects.
8379 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8381 * emacs.c (USAGE3): Doc fixes.
8383 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8385 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8388 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8390 * lisp.h (VWindow_system, Qfile_name_history):
8391 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8392 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8393 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8395 * w32select.c: Don't #include "keyboard.h".
8396 (run_protected): Add extern declaration for waiting_for_input.
8398 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8399 * w32console.c (detect_input_pending, read_input_pending)
8400 (encode_terminal_code):
8401 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8402 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8403 (w32_system_caret_y, Qfile_name_history):
8404 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8405 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8406 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8407 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8408 * w32proc.c (Qlocal, report_file_error):
8409 * w32term.c (Vwindow_system, updating_frame):
8410 * w32uniscribe.c (initialized, uniscribe_font_driver):
8411 Remove unneeded extern declarations.
8413 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8415 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8417 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8419 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8420 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8421 These macros can no longer be used for assignment.
8423 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8424 Assign struct members directly, instead of using BUF_BEGV etc.
8425 (record_buffer_markers, fetch_buffer_markers): New functions for
8426 recording and fetching special buffer markers.
8427 (set_buffer_internal_1, set_buffer_temp): Use them.
8429 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8431 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8433 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8434 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8436 * xdisp.c (hscroll_window_tree):
8437 (reconsider_clip_changes): Use PT instead of BUF_PT.
8439 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8441 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8442 $(EMACS_ROOT)/lib/intprops.h.
8444 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8446 Fix more problems found by GCC 4.5.2's static checks.
8448 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8449 to unsigned char * to avoid compiler diagnostic.
8450 (xg_free_frame_widgets): Make it clear that a local variable is
8451 needed only if USE_GTK_TOOLTIP.
8452 (gdk_window_get_screen): Make it clear that this macro is needed
8453 only if USE_GTK_TOOLTIP.
8454 (int_gtk_range_get_value): New function, which avoids a diagnostic
8455 from gcc -Wbad-function-cast.
8456 (xg_set_toolkit_scroll_bar_thumb): Use it.
8457 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8458 diagnostic from gcc -Wbad-function-cast.
8459 (get_utf8_string, xg_get_file_with_chooser):
8460 Rename locals to avoid shadowing.
8461 (create_dialog): Move locals to avoid shadowing.
8463 * xgselect.c (xg_select): Remove unused var.
8465 * image.c (four_corners_best): Mark locals as initialized.
8466 (gif_load): Initialize transparent_p to zero (Bug#8238).
8467 Mark another local as initialized.
8468 (my_png_error, my_error_exit): Mark with NO_RETURN.
8470 * image.c (clear_image_cache): Now static.
8471 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8472 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8473 (x_edge_detection): Remove unnecessary cast that
8474 gcc -Wbad-function-cast diagnoses.
8475 (gif_load): Fix pointer signedness.
8476 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8477 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8479 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8481 Improve quality of tests for time stamp overflow.
8482 For example, without this patch (encode-time 0 0 0 1 1
8483 1152921504606846976) returns the obviously-bogus value (-948597
8484 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8485 reports time overflow. See
8486 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8487 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8488 * editfns.c: Include limits.h and intprops.h.
8489 (TIME_T_MIN, TIME_T_MAX): New macros.
8490 (time_overflow): Move earlier, to before first use.
8491 (hi_time, lo_time): New functions, for an accurate test for
8493 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8494 (Fget_internal_run_time): Don't assume time_t fits in int.
8495 (make_time): Use list2 instead of Fcons twice.
8496 (Fdecode_time): More accurate test for out-of-range times.
8497 (check_tm_member): New function.
8498 (Fencode_time): Use it, to test for out-of-range times.
8499 (lisp_time_argument): Don't rely on undefined left-shift and
8500 right-shift behavior when checking for time stamp overflow.
8502 * editfns.c (time_overflow): New function, refactoring common code.
8503 (Fformat_time_string, Fdecode_time, Fencode_time):
8504 (Fcurrent_time_string): Use it.
8506 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8507 * dired.c (make_time): Move to ...
8508 * editfns.c (make_time): ... here.
8509 * systime.h: Note the move.
8511 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8513 * fringe.c (update_window_fringes): Remove unused variables.
8515 * unexmacosx.c (copy_data_segment): Also copy __got section.
8518 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8520 * termcap.c [MSDOS]: Include "msdos.h".
8521 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8522 Constify `char *' arguments and their references according to
8523 prototypes in tparam.h.
8525 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8527 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8528 Adapt all references accordingly.
8530 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8532 2011-03-11 Tom Tromey <tromey@redhat.com>
8534 * buffer.c (syms_of_buffer): Remove obsolete comment.
8536 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8538 * termhooks.h (encode_terminal_code): Declare prototype.
8540 * msdos.c (encode_terminal_code): Don't declare prototype.
8542 * term.c (encode_terminal_code): Now external again, used by
8543 w32console.c and msdos.c.
8545 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8546 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8548 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8550 Fix some minor problems found by GCC 4.5.2's static checks.
8552 * fringe.c (update_window_fringes): Mark locals as initialized
8554 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8556 * alloc.c (mark_fringe_data): Move decl from here ...
8557 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8558 to check its interface.
8559 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8561 * fontset.c (free_realized_fontset): Now static.
8562 (Fset_fontset_font): Rename local to avoid shadowing.
8563 (fontset_font): Mark local as initialized.
8564 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8566 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8568 * xselect.c (x_disown_buffer_selections): Remove; not used.
8569 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8570 (x_own_selection, Fx_disown_selection_internal): Rename locals
8572 (x_handle_dnd_message): Remove local to avoid shadowing.
8574 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8575 so that the caller can use some name other than gcpro1.
8576 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8577 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8578 (Fx_backspace_delete_keys_p):
8579 Use them to avoid shadowing, and rename vars to avoid shadowing.
8580 (x_decode_color, x_set_name, x_window): Now static.
8581 (Fx_create_frame): Add braces to silence GCC warning.
8582 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8583 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8584 Remove unused locals.
8585 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8586 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8587 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8590 * xterm.h (x_mouse_leave): New decl.
8592 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8593 Remove unused functions.
8594 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8595 (x_calc_absolute_position): Now static.
8596 (XTread_socket): Don't define label "out" unless it's used.
8597 Don't declare local "event" unless it's used.
8598 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8599 unless they are used.
8600 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8601 (x_fatal_error_signal): Remove; not used.
8602 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8603 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8604 (x_error_catcher, x_connection_closed, x_error_handler):
8605 (x_error_quitter, xembed_send_message, x_iconify_frame):
8606 (my_log_handler): Rename locals to avoid shadowing.
8607 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8608 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8610 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8611 Rename or move locals to avoid shadowing.
8612 (tty_defined_color, merge_face_heights): Now static.
8613 (free_realized_faces_for_fontset): Remove; not used.
8614 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8615 does not deduce is never used uninitialized.
8616 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8617 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8619 * terminal.c (store_terminal_param): Now static.
8621 * xmenu.c (menu_highlight_callback): Now static.
8622 (set_frame_menubar): Remove unused local.
8623 (xmenu_show): Rename parameter to avoid shadowing.
8624 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8625 since they might point to immutable storage.
8626 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8627 since it's unused otherwise.
8629 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8630 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8631 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8632 avoids a gcc -Wuninitialized diagnostic.
8633 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8634 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8635 does not deduce are never used uninitialized.
8637 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8639 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8640 * window.c (window_loop, size_window):
8641 (run_window_configuration_change_hook, enlarge_window): Likewise.
8643 * window.c (display_buffer): Now static.
8644 (size_window): Mark variables that gcc -Wuninitialized
8645 does not deduce are never used uninitialized.
8646 * window.h (check_all_windows): New decl, to forestall
8647 gcc -Wmissing-prototypes diagnostic.
8648 * dispextern.h (bidi_dump_cached_states): Likewise.
8650 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8652 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8654 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8655 and to avoid gcc -Wuninitialized warning.
8656 (load_charset_map): Mark variables that gcc -Wuninitialized
8657 does not deduce are never used uninitialized.
8658 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8660 * coding.c (coding_set_source, coding_set_destination):
8661 Use "else { /* comment */ }" rather than "else /* comment */;"
8662 for clarity, and to avoid gcc -Wempty-body warning.
8663 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8664 a block, when the outer 'i' will do.
8665 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8666 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8667 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8668 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8669 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8670 Rename locals to avoid shadowing.
8671 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8672 * coding.c (emacs_mule_char, encode_invocation_designation):
8673 Now static, since they're not used elsewhere.
8674 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8675 (decode_coding_object, encode_coding_object, detect_coding_system):
8676 (decode_coding_emacs_mule): Mark variables that gcc
8677 -Wuninitialized does not deduce are never used uninitialized.
8678 (detect_coding_iso_2022): Initialize a local variable that might
8679 be used uninitialized. Leave a FIXME because it's not clear that
8680 this initialization is needed. (Bug#8211)
8681 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8682 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8683 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8684 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8685 Remove unused macros.
8687 * category.c (hash_get_category_set): Remove unused local var.
8688 (copy_category_table): Now static, since it's not used elsewhere.
8689 * character.c (string_count_byte8): Likewise.
8691 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8692 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8694 * chartab.c (copy_sub_char_table): Now static, since it's not used
8696 (sub_char_table_ref_and_range, char_table_ref_and_range):
8697 Rename locals to avoid shadowing.
8698 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8700 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8701 (BIDI_BOB): Remove unused macro.
8703 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8704 deduce are never used uninitialized.
8705 * term.c (encode_terminal_code): Likewise.
8707 * term.c (encode_terminal_code): Now static. Remove unused local.
8709 * tparam.h: New file.
8710 * term.c, tparam.h: Include it.
8711 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8712 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8713 Move these decls to tparam.h, and make them agree with what
8714 is actually in tparam.c. The previous trick of using incompatible
8715 decls in different modules does not conform to the C standard.
8716 All callers of tparam changed to use tparam's actual API.
8717 * tparam.c (tparam1, tparam, tgoto):
8718 Use const pointers where appropriate.
8720 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8721 * cm.h (struct cm): Likewise.
8722 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8723 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8724 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8725 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8726 (turn_on_face, init_tty): Likewise.
8727 * termchar.h (struct tty_display_info): Likewise.
8729 * term.c (term_mouse_position): Rename local to avoid shadowing.
8731 * alloc.c (mark_ttys): Move decl from here ...
8732 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8734 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8736 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8738 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8740 * search.c (compile_pattern_1): Remove argument regp, unused since
8741 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8742 (compile_pattern): Don't pass it.
8744 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8746 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8747 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8749 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8751 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8753 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8754 gdk_window_get_screen, gdk_window_get_geometry,
8755 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8756 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8757 (xg_get_pixbuf_from_pixmap): New function.
8758 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8759 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8760 Call xg_get_pixbuf_from_pixmap instead of
8761 gdk_pixbuf_get_from_drawable.
8762 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8763 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8764 (xg_check_special_colors): Use GtkStyleContext and its functions
8766 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8767 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8768 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8769 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8770 Call gtk_widget_get_preferred_size.
8771 (xg_frame_resized): gdk_window_get_geometry only takes 5
8773 (xg_win_to_widget, xg_event_is_for_menubar):
8774 Call gdk_x11_window_lookup_for_display.
8775 (xg_set_widget_bg): New function.
8776 (delete_cb): New function.
8777 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8778 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8779 (xg_set_background_color): Call xg_set_widget_bg.
8780 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8781 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8782 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8783 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8785 (update_frame_tool_bar): Call gtk_widget_hide.
8786 (xg_initialize): Use GDK_KEY_g.
8788 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8790 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8792 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8793 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8794 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8796 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8798 * w32xfns.c (select_palette): Check success of RealizePalette against
8799 GDI_ERROR, not zero.
8801 See ChangeLog.11 for earlier changes.
8807 Copyright (C) 2011 Free Software Foundation, Inc.
8809 This file is part of GNU Emacs.
8811 GNU Emacs is free software: you can redistribute it and/or modify
8812 it under the terms of the GNU General Public License as published by
8813 the Free Software Foundation, either version 3 of the License, or
8814 (at your option) any later version.
8816 GNU Emacs is distributed in the hope that it will be useful,
8817 but WITHOUT ANY WARRANTY; without even the implied warranty of
8818 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8819 GNU General Public License for more details.
8821 You should have received a copy of the GNU General Public License
8822 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.