Small imagemagick doc fixes
[bpt/emacs.git] / src / ChangeLog
1 2012-02-07 Glenn Morris <rgm@gnu.org>
2
3 * image.c (Fimagemagick_types): Doc fix.
4
5 * image.c (imagemagick-render-type): Change it from a lisp object
6 to an integer. Move the doc here from the lisp manual.
7 Treat all values not equal to 0 the same.
8
9 2012-02-06 Chong Yidong <cyd@gnu.org>
10
11 * doc.c (store_function_docstring): Avoid applying docstring of
12 alias to base function (Bug#2603).
13
14 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
15
16 * .gdbinit (pp1, pv1): Remove redundant defines.
17 (pr): Use pp.
18
19 2012-02-04 Chong Yidong <cyd@gnu.org>
20
21 * nsterm.m: Declare a global (Bug#10694).
22
23 2012-02-04 Eli Zaretskii <eliz@gnu.org>
24
25 * w32.c (get_emacs_configuration_options): Include
26 --enable-checking, if specified, in the return value.
27
28 2012-02-04 Martin Rudalics <rudalics@gmx.at>
29
30 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
31 after rounding frame sizes. (Bug#9723)
32
33 2012-02-04 Eli Zaretskii <eliz@gnu.org>
34
35 * keyboard.c (adjust_point_for_property): Don't position point
36 before BEGV. (Bug#10696)
37
38 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
39
40 Handle overflow when computing char display width (Bug#9496).
41 * character.c (char_width): Return EMACS_INT, not int.
42 (char_width, c_string_width): Check for overflow when
43 computing the width; this is possible now that individual
44 characters can have unbounded width. Problem introduced
45 by merge from Emacs 23 on 2012-01-19.
46
47 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
48
49 * dbusbind.c (Fdbus_register_method): Mention the return value
50 :ignore in the docstring.
51
52 2012-02-02 Glenn Morris <rgm@gnu.org>
53
54 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
55
56 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
57 Unconditionally set to t. (Bug#10673)
58 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
59 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
60 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
61
62 2012-02-02 Kenichi Handa <handa@m17n.org>
63
64 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
65 0, do not call append_composite_glyph.
66
67 2012-02-02 Kenichi Handa <handa@m17n.org>
68
69 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
70 NULL (Bug#6988).
71 (x_produce_glyphs): If the component of a composition is a null
72 string, set it->pixel_width to 1 to avoid zero-width glyph.
73
74 2012-02-01 Eli Zaretskii <eliz@gnu.org>
75
76 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
77 first 2 arguments are identical. This makes inserting large
78 output from a subprocess an order of magnitude faster on
79 MS-Windows, where all sbrk'ed memory is always contiguous.
80
81 2012-01-31 Glenn Morris <rgm@gnu.org>
82
83 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
84 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
85 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
86
87 2012-01-29 Glenn Morris <rgm@gnu.org>
88
89 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
90
91 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
92
93 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
94
95 2012-01-28 Chong Yidong <cyd@gnu.org>
96
97 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
98
99 2012-01-26 Chong Yidong <cyd@gnu.org>
100
101 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
102
103 * search.c (Fsearch_forward, Fsearch_backward): Document negative
104 repeat counts (Bug#10507).
105
106 2012-01-26 Glenn Morris <rgm@gnu.org>
107
108 * lread.c (syms_of_lread): Doc fix.
109
110 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
111
112 * coding.c (encode_designation_at_bol): Change return value to
113 EMACS_INT.
114
115 2012-01-25 Chong Yidong <cyd@gnu.org>
116
117 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
118
119 2012-01-21 Chong Yidong <cyd@gnu.org>
120
121 * floatfns.c (Fcopysign): Make the second argument non-optional,
122 since nil is not allowed anyway.
123
124 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
125
126 * process.c (read_process_output): Use p instead of XPROCESS (proc).
127 (send_process): Likewise.
128
129 2012-01-19 Martin Rudalics <rudalics@gmx.at>
130
131 * window.c (save_window_save, Fcurrent_window_configuration)
132 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
133 doc-strings.
134
135 2012-01-19 Kenichi Handa <handa@m17n.org>
136
137 * character.c (char_width): New function.
138 (Fchar_width, c_string_width, lisp_string_width):
139 Use char_width (Bug#9496).
140
141 2012-01-16 Martin Rudalics <rudalics@gmx.at>
142
143 * window.c (Vwindow_persistent_parameters): New variable.
144 (Fset_window_configuration, save_window_save): Handle persistent
145 window parameters.
146
147 2012-01-14 Eli Zaretskii <eliz@gnu.org>
148
149 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
150 thrashing the stack of the thread. (Bug#9087)
151
152 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
153
154 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
155
156 2012-01-11 Eli Zaretskii <eliz@gnu.org>
157
158 * xdisp.c (rows_from_pos_range): Handle the case where the
159 highlight ends on a newline. (Bug#10464)
160 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
161 he end column for display of highlight that ends on a newline
162 before a R2L line.
163
164 2012-01-11 Glenn Morris <rgm@gnu.org>
165
166 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
167 from load-path also when installation-directory is nil. (Bug#10208)
168
169 2012-01-10 Glenn Morris <rgm@gnu.org>
170
171 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
172
173 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
174 Update template values to be closer to their typical values these days.
175
176 2012-01-09 Eli Zaretskii <eliz@gnu.org>
177
178 * xdisp.c (rows_from_pos_range): Accept additional argument
179 DISP_STRING, and accept any glyph in a row whose object is that
180 string as eligible for mouse highlight. Fixes mouse highlight of
181 display strings from overlays. (Bug#10464)
182
183 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
184
185 emacs: fix an auto-save permissions race condition (Bug#10400)
186 * fileio.c (auto_saving_dir_umask): New static var.
187 (Fmake_directory_internal): Use it.
188 (do_auto_save_make_dir): Set it, instead of invoking chmod after
189 creating the directory. The old code temporarily assigns
190 too-generous permissions to the directory.
191 (do_auto_save_eh): Clear it.
192 (Fdo_auto_save): Catch all errors, not just file errors, so
193 that the var is always cleared.
194
195 2012-01-07 Eli Zaretskii <eliz@gnu.org>
196
197 * search.c (scan_buffer): Pass character positions to
198 know_region_cache, not byte positions. (Bug#6540)
199
200 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
201
202 * w32.c (sys_rename): Report EXDEV when rename of a directory
203 fails because the target is on another logical disk. (Bug#10284)
204
205 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
206
207 * xterm.c (x_embed_request_focus): New function.
208
209 * xterm.h: Add prototype.
210
211 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
212
213 2012-01-05 Glenn Morris <rgm@gnu.org>
214
215 * emacs.c (emacs_copyright): Update short copyright year to 2012.
216
217 2012-01-01 Eli Zaretskii <eliz@gnu.org>
218
219 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
220 Load gnutls_transport_set_lowat only if GnuTLS version is below
221 2.11.1.
222 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
223 GnuTLS versions below 2.11.1.
224
225 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
226
227 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
228 to the doc string advising against its use for altering the way
229 windows are scrolled.
230
231 2011-12-28 Kenichi Handa <handa@m17n.org>
232
233 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
234 coding-system ASCII compatible only when it does not produce BOM
235 on encoding (Bug#10383).
236
237 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
238
239 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
240 can scroll.
241 (create_and_show_popup_menu): Always use menu_position_func for
242 Gtk3 (Bug#10361).
243
244 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
245
246 * callint.c (Fcall_interactively): Don't truncate prompt string.
247
248 2011-12-23 Eli Zaretskii <eliz@gnu.org>
249
250 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
251 property that ends at ZV, so that the bidi iteration could be
252 resumed from there (after widening). (Bug#10360)
253
254 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
255
256 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
257
258 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
259
260 * nsterm.m (x_free_frame_resources):
261 Release f->output_data.ns->miniimage.
262 (ns_index_color): Fix indentation. Do not retain
263 color_table->colors[i].
264
265 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
266 before returning.
267
268 * nsfns.m (x_set_background_color): Assign return value from
269 ns_index_color to face-background instead of NSColor*.
270 (ns_implicitly_set_icon_type): Fix indentation.
271 Change assignment in for loop to comparison.
272
273 * emacs.c (ns_pool): New variable.
274 (main): Assign ns_pool.
275 (Fkill_emacs): Call ns_release_autorelease_pool.
276
277 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
278 autorelease fdesc, release fdAttrs and tdict.
279 (ns_get_covering_families): Release charset.
280 (ns_findfonts): Release NSFontDescriptor created with new.
281 (ns_uni_to_glyphs): Fix indentation.
282 (setString): Release attrStr before assigning new value.
283
284 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
285
286 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
287 and NS_IMPL_COCOA.
288 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
289 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
290
291 2011-12-18 David Reitter <reitter@cmu.edu>
292
293 * nsterm.m (ns_term_init): Subscribe for notifications
294 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
295 to method trackingNotification in EmacsMenu.
296
297 * nsmenu.m (trackingMenu): New variable.
298 (trackingNotification): New method (from Aquamacs).
299 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
300 from Aquamacs (Bug#7030).
301
302 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
303
304 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
305 (symbol_to_nsstring): Fix indentation.
306 (ns_symbol_to_pb): New function.
307 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
308 (Fns_rotate_cut_buffers_internal): Removed.
309 (Fns_store_selection_internal): Renamed from
310 Fns_store_cut_buffer_internal.
311 (ns_get_foreign_selection, Fx_own_selection_internal)
312 (Fx_disown_selection_internal, Fx_selection_exists_p)
313 (Fns_get_selection_internal, Fns_store_selection_internal):
314 Use ns_symbol_to_pb and check if return value is nil.
315 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
316 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
317 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
318 renamed to Sns_store_selection_internal.
319 (ns_handle_selection_request): Move code to Fx_own_selection_internal
320 and remove this function.
321 (ns_handle_selection_clear): Remove, never used.
322 (Fx_own_selection_internal): Move code from ns_handle_selection_request
323 here.
324
325 2011-12-17 Ken Brown <kbrown@cornell.edu>
326
327 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
328 GID is unknown (Bug#10257).
329
330 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
331
332 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
333 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
334 which caused a build failure on GNU/Linux IA-64. This problem was
335 introduced by my 2011-10-07 patch.
336
337 2011-12-15 Juri Linkov <juri@jurta.org>
338
339 * image.c (imagemagick_error): New function. (Bug#10112)
340 (imagemagick_load_image): Comment out `MagickSetResolution' call.
341 Use `imagemagick_error' where ImageMagick functions return
342 `MagickFalse'.
343 (Fimagemagick_types): Add `Fnreverse' to return the list in the
344 proper order.
345
346 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
347
348 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
349 fill background (Bug#8992).
350
351 2011-12-13 Martin Rudalics <rudalics@gmx.at>
352
353 * window.c (Vwindow_combination_resize)
354 (Vwindow_combination_limit): Use t instead of non-nil in
355 doc-strings.
356 (Vrecenter_redisplay): Add first sentence of doc-string on
357 separate line.
358 (Frecenter): Fix doc-string typo.
359
360 2011-12-11 Kenichi Handa <handa@m17n.org>
361
362 * coding.c (Funencodable_char_position): Pay attention to the
363 buffer text relocation (Bug#9389).
364
365 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
366
367 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
368 gtk_init (Bug#10100).
369
370 2011-12-10 Eli Zaretskii <eliz@gnu.org>
371
372 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
373 IT->string is nil. (Bug#10263)
374
375 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
376
377 * nsterm.h (x_free_frame_resources): Declare.
378
379 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
380 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
381
382 * nsterm.h (ns_get_defaults_value): Declare.
383
384 * nsterm.m (ns_default): Call ns_get_defaults_value.
385
386 2011-12-09 Eli Zaretskii <eliz@gnu.org>
387
388 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
389 (Bug#10170)
390
391 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
392
393 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
394 that where the value of an _OBJC_* symbol points to is in the .bss
395 section (Bug#10240).
396
397 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
398
399 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
400 after the loop to call ccl_driver at least once (Bug#8619).
401
402 2011-12-08 Kenichi Handa <handa@m17n.org>
403
404 * ftfont.c (get_adstyle_property): Fix previous change
405 (Bug#10233).
406
407 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
408
409 * w32.c (init_environment): If no_site_lisp, remove site-lisp
410 dirs from the default value of EMACSLOADPATH (bug#10208).
411
412 2011-12-07 Glenn Morris <rgm@gnu.org>
413
414 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
415 installation and source directories as well. (Bug#10208)
416
417 2011-12-06 Chong Yidong <cyd@gnu.org>
418
419 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
420
421 2011-12-06 Glenn Morris <rgm@gnu.org>
422
423 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
424 as an error, not just -1. (Bug#10217)
425
426 2011-12-05 Chong Yidong <cyd@gnu.org>
427
428 * keyboard.c (process_special_events): New function.
429 (swallow_events, Finput_pending_p): Use it (Bug#10195).
430
431 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
432
433 * coding.c (encode_designation_at_bol): Don't use uninitialized
434 local variable (Bug#9318).
435
436 2011-12-05 Kenichi Handa <handa@m17n.org>
437
438 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
439 return Qnil (Bug#8046, Bug#10193).
440
441 2011-12-05 Kenichi Handa <handa@m17n.org>
442
443 * coding.c (encode_designation_at_bol): New args charbuf_end and
444 dst. Return the number of produced bytes. Callers changed.
445 (coding_set_source): Return how many bytes coding->source was
446 relocated.
447 (coding_set_destination): Return how many bytes
448 coding->destination was relocated.
449 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
450 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
451
452 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
453
454 * coding.c (CODING_CHAR_CHARSET_P): New macro.
455 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
456 macro (Bug#9318).
457
458 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
459
460 The following changes are to fix Bug#9318.
461
462 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
463 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
464 (encode_coding_iso_2022, encode_coding_sjis)
465 (encode_coding_big5, encode_coding_charset): Use the above macros.
466
467 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
468
469 * lisp.h (process_quit_flag): Fix external declaration.
470
471 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
472
473 Don't macro-inline non-performance-critical code.
474 * eval.c (process_quit_flag): New function.
475 * lisp.h (QUIT): Use it.
476
477 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
478
479 * nsfns.m (get_geometry_from_preferences): New function.
480 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
481
482 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
483
484 * emacs.c (Qkill_emacs): Define.
485 (syms_of_emacs): Initialize it.
486 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
487 Qquit_flag to `kill-emacs' instead.
488 (quit_throw_to_read_char): Add parameter `from_signal'.
489 All callers changed. Call Fkill_emacs if requested and safe.
490 * lisp.h (QUIT): Call Fkill_emacs if requested.
491
492 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
493
494 * widget.c (update_wm_hints): Return if wmshell is null.
495 (widget_update_wm_size_hints): New function.
496
497 * widget.h (widget_update_wm_size_hints): Declare.
498
499 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
500 widget_update_wm_size_hints (Bug#10104).
501
502 2011-12-03 Eli Zaretskii <eliz@gnu.org>
503
504 * xdisp.c (handle_invisible_prop): If the invisible text ends just
505 before a newline, prepare the bidi iterator for consuming the
506 newline, and keep the current paragraph direction. (Bug#10183)
507 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
508
509 2011-12-02 Juri Linkov <juri@jurta.org>
510
511 * search.c (Fword_search_regexp): New Lisp function created from
512 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
513 (Fword_search_backward, Fword_search_forward)
514 (Fword_search_backward_lax, Fword_search_forward_lax):
515 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
516 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
517
518 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
519
520 * fileio.c (Finsert_file_contents): Move after-change-function call
521 to before the "handled:" label, since all "goto handled" appear in
522 cases where the *-change-functions have already been properly called
523 (bug#10117).
524
525 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
526
527 * keyboard.c (interrupt_signal): Don't call kill-emacs when
528 waiting for input. (Bug#10169)
529
530 2011-11-30 Eli Zaretskii <eliz@gnu.org>
531
532 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
533 verifies glyph row's hash code--we have just reallocated the
534 glyphs, so their contents can be complete garbage. (Bug#10164)
535
536 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
537
538 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
539
540 2011-11-30 Eli Zaretskii <eliz@gnu.org>
541
542 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
543 attributes are tested _before_ calling verify_row_hash, to protect
544 against GCC re-ordering of the tests. (Bug#10164)
545
546 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
547
548 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
549
550 * xterm.c (handle_one_xevent): Only set async_visible and friends
551 if net_wm_state_hidden_seen is non-zero (Bug#10002)
552 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
553 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
554
555 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
556
557 Remove GCPRO-related macros that exist only to avoid shadowing locals.
558 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
559 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
560 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
561 All uses changed to use GCPRO1 etc.
562 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
563 Revert to old implementation (i.e., before 2011-03-11).
564
565 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
566
567 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
568 of scroll runs so as to avoid assigning disabled bogus rows and
569 unnecessary graphics copy operations.
570
571 2011-11-27 Eli Zaretskii <eliz@gnu.org>
572
573 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
574 (snprintf) [_MSC_VER]: Redirect to _snprintf.
575 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
576 (malloc, free, realloc, calloc): Redirect to e_* only when
577 compiling Emacs.
578
579 * lisp.h (GCTYPEBITS): Move before first use.
580 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
581 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
582 this macro definition.
583
584 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
585 _MSC_VER.
586
587 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
588
589 * gtkutil.c (xg_create_frame_widgets):
590 Call gtk_window_set_has_resize_grip (FALSE) if that function is
591 present with Gtk+ 2.0.
592
593 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
594
595 * fileio.c (Finsert_file_contents): Undo previous change; see
596 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
597
598 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
599
600 Rename locals to avoid shadowing.
601 * fileio.c (Finsert_file_contents):
602 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
603 * process.c (wait_reading_process_output):
604 Rename inner 'proc' to 'p' to avoid shadowing.
605 Indent for consistency with usual Emacs style.
606
607 2011-11-25 Eli Zaretskii <eliz@gnu.org>
608
609 * xdisp.c (redisplay_window): If cursor row is not fully visible
610 after recentering, and scroll-conservatively is set to a large
611 number, scroll window by a few more lines to make the cursor fully
612 visible and out of scroll-margin. (Bug#10105)
613 (start_display): Don't move to the next line if the display should
614 start at a newline that is part of a display vector or an overlay
615 string. (Bug#10119)
616
617 2011-11-24 Juri Linkov <juri@jurta.org>
618
619 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
620 after the `MagickPingImage' call. (Bug#10112)
621
622 2011-11-23 Chong Yidong <cyd@gnu.org>
623
624 * window.c (Fcoordinates_in_window_p): Accept only live windows.
625
626 2011-11-23 Martin Rudalics <rudalics@gmx.at>
627
628 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
629 making another buffer current. (Bug#10114)
630
631 2011-11-23 Glenn Morris <rgm@gnu.org>
632
633 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
634
635 2011-11-23 Chong Yidong <cyd@gnu.org>
636
637 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
638 using it (Bug#5984).
639
640 2011-11-22 Eli Zaretskii <eliz@gnu.org>
641
642 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
643 and header-lines, as they don't have one computed for them.
644 (Bug#10098)
645
646 * .gdbinit (prow): Make displayed values more self-explaining.
647 Add row's hash code.
648
649 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
650
651 * process.c (wait_reading_process_output): Fix asynchrounous
652 GnuTLS socket handling on some versions of the GnuTLS library.
653 (wait_reading_process_output): Add comment and URL.
654
655 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
656
657 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
658
659 2011-11-21 Chong Yidong <cyd@gnu.org>
660
661 * window.c (Fnext_window, Fprevious_window): Doc fix.
662
663 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
664
665 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
666
667 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
668
669 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
670
671 2011-11-20 Martin Rudalics <rudalics@gmx.at>
672
673 * window.c (Fset_window_combination_limit): Rename argument
674 STATUS to LIMIT.
675 (Vwindow_combination_limit): Remove "status" from doc-string.
676
677 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
678
679 * m/ibms390.h: Remove.
680 * m/ibms390x.h: Don't include "ibms390.h".
681
682 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
683
684 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
685 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
686
687 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
688
689 * casetab.c (Fset_case_table):
690 * charset.c (Fcharset_after): Fix typos.
691
692 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
693
694 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
695 Otherwise, valgrind does not work on some platforms.
696 Problem reported by Andreas Schwab in
697 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
698 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
699 is set, removing the need for VIRT_ADDRESS_VARIES.
700 (PURE_P): Use a more-efficient implementation that needs just one
701 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
702 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
703 to 4 (xorl, subq, cmpq, setbe).
704 * alloc.c (pure): Always extern now, since that's the
705 VIRT_ADDR_VARIES behavior.
706 (PURE_POINTER_P): Use a single comparison, not two, for
707 consistency with the new puresize.h.
708 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
709 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
710 Remove VIRT_ADDR_VARIES no longer needed.
711
712 2011-11-19 Eli Zaretskii <eliz@gnu.org>
713
714 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
715 (erase_phys_cursor, update_window_cursor, show_mouse_face)
716 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
717 behave as if the cursor position were at the window margin.
718
719 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
720 and the cursor position is out of bounds, behave as if the cursor
721 position were at the window margin. (Bug#10075)
722
723 2011-11-18 Chong Yidong <cyd@gnu.org>
724
725 * window.c (Fwindow_combination_limit): Make first argument
726 non-optional, since it is meaningless for live windows like the
727 selected window.
728
729 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
730
731 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
732
733 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
734
735 * intervals.c: Fix grafting over the whole buffer (bug#10071).
736 (graft_intervals_into_buffer): Simplify.
737
738 2011-11-18 Eli Zaretskii <eliz@gnu.org>
739
740 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
741 hash values of the two rows.
742 (copy_row_except_pointers): Preserve the used[] arrays and the
743 hash values of the two rows. (Bug#10035)
744 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
745
746 * xdisp.c (row_hash): New function, body extracted from
747 compute_line_metrics.
748 (compute_line_metrics): Call row_hash, instead of computing the
749 hash code inline.
750
751 * dispnew.c (verify_row_hash): Call row_hash for computing the
752 hash code of a row, instead of duplicating code from xdisp.c.
753
754 * dispextern.h (row_hash): Add prototype.
755
756 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
757
758 * frame.c (delete_frame): Don't delete the terminal when the last
759 X frame is closed if emacs is built with GTK toolkit.
760
761 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
762
763 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
764
765 2011-11-17 Martin Rudalics <rudalics@gmx.at>
766
767 * window.c (Vwindow_splits): Rename to
768 Vwindow_combination_resize. Suggested by Juri Linkov.
769 (Fsplit_window_internal): Use Vwindow_combination_resize instead
770 of Vwindow_splits.
771
772 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
773
774 * nsfns.m (Fns_font_name):
775 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
776
777 2011-11-16 Martin Rudalics <rudalics@gmx.at>
778
779 * window.h (window): Rename slot "nest" to "combination_limit".
780 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
781 (Fset_window_nest): Rename to Fset_window_combination_limit.
782 (Vwindow_nest): Rename to Vwindow_combination_limit.
783 (recombine_windows, make_parent_window, make_window)
784 (Fsplit_window_internal, saved_window)
785 (Fset_window_configuration, save_window_save): Rename all
786 occurrences of window_nest to window_combination_limit.
787
788 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
789
790 * image.c (imagemagick_load_image): Fix typo.
791
792 2011-11-14 Eli Zaretskii <eliz@gnu.org>
793
794 * xdisp.c (display_line): Move the call to
795 highlight_trailing_whitespace before the call to
796 compute_line_metrics, since the latter needs to see the final
797 faces of all the glyphs to compute ROW's hash value.
798 Fixes assertion violations in row_equal_p. (Bug#10035)
799
800 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
801
802 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
803 just return (bug#10044).
804
805 2011-11-12 Eli Zaretskii <eliz@gnu.org>
806
807 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
808 with user-defined heap size. Bump the default size of the temacs
809 heap to 27MB, to avoid memory warning when running temacs.
810 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
811
812 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
813 current_matrix and desired_matrix. (Bug#9990)
814 (verify_row_hash) [XASSERTS]: New function.
815 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
816 that the hash value of glyph rows is correct.
817
818 2011-11-12 Martin Rudalics <rudalics@gmx.at>
819
820 * window.h (window): Remove splits slot.
821 * window.c (Fwindow_splits, Fset_window_splits): Remove.
822 (Fdelete_other_windows_internal, make_parent_window)
823 (make_window, Fsplit_window_internal, Fdelete_window_internal)
824 (Fset_window_configuration, save_window_save): Don't deal with
825 split status of windows.
826 (saved_window): Remove splits slot.
827 (Vwindow_splits): Rewrite doc-string.
828
829 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
830
831 * xfns.c (unwind_create_frame):
832 * nsfns.m (unwind_create_frame):
833 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
834 Vframe_list (Bug#9999).
835
836 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
837
838 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
839
840 2011-11-11 Kenichi Handa <handa@m17n.org>
841
842 * callproc.c (Fcall_process): Set the member dst_multibyte of
843 process_coding.
844
845 2011-11-11 Johan Bockgård <bojohan@gnu.org>
846
847 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
848 avoid a crash (bug#9496).
849
850 2011-11-09 Chong Yidong <cyd@gnu.org>
851
852 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
853 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
854
855 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
856
857 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
858
859 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
860
861 Avoid some portability problems by eschewing 'extern inline' functions.
862 The trivial performance wins aren't worth the portability hassles; see
863 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
864 et seq.
865 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
866 (window_box_width, window_box_left, window_box_left_offset)
867 (window_box_right, window_box_right_offset): Undo previous change,
868 by removing the "extern"s.
869 * intervals.c (adjust_intervals_for_insertion)
870 (adjust_intervals_for_deletion): Undo previous change,
871 making these static again.
872 (offset_intervals, temp_set_point_both, temp_set_point)
873 (copy_intervals_to_string): No longer inline.
874 * xdisp.c (window_text_bottom_y, window_box_width)
875 (window_box_height, window_box_left_offset)
876 (window_box_right_offset, window_box_left, window_box_right)
877 (window_box): No longer inline.
878
879 2011-11-08 Chong Yidong <cyd@gnu.org>
880
881 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
882 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
883 Signal an error if not a live window.
884 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
885 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
886
887 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
888
889 * lisp.h (syms_of_abbrev): Remove declaration.
890 Reported by CHENG Gao <chenggao@royau.me>.
891
892 2011-11-07 Eli Zaretskii <eliz@gnu.org>
893
894 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
895 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
896 of temacs in GUI mode.
897
898 2011-11-07 Martin Rudalics <rudalics@gmx.at>
899
900 * window.h: Declare delete_all_child_windows instead of
901 delete_all_subwindows.
902 * window.c (Fwindow_nest, Fset_window_nest)
903 (Fset_window_new_total, Fset_window_new_normal)
904 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
905 (delete_all_subwindows): Rename to delete_all_child_windows.
906 (Fdelete_other_windows_internal, Fset_window_configuration):
907 Call delete_all_child_windows instead of delete_all_subwindows.
908 * frame.c (delete_frame): Call delete_all_child_windows instead
909 of delete_all_subwindows.
910
911 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
912
913 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
914 This is also needed for porting to any host where GC_MARK_STACK is
915 not GC_MAKE_GCPROS_NOOPS.
916 (which_symbols): Use it.
917
918 2011-11-07 Kenichi Handa <handa@m17n.org>
919
920 * coding.c (coding_set_destination): Check coding->src_pos only
921 when coding->src_object is a buffer (bug#9910).
922
923 * process.c (send_process): Set the member src_multibyte of coding
924 to 0 (bug#9911) when sending a unibyte text.
925
926 * callproc.c (Fcall_process): Set the member src_multibyte of
927 process_coding to 0 (bug#9912).
928
929 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
930
931 * xmenu.c (cleanup_widget_value_tree): New function.
932 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
933 calling free_menubar_widget_value_tree directly (Bug#9830).
934
935 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
936
937 Fix some portability problems with 'inline'.
938 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
939 (window_box_width, window_box_left, window_box_left_offset)
940 (window_box_right, window_box_right_offset): Declare extern.
941 Otherwise, these inline functions do not conform to C99 and
942 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
943 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
944 * intervals.c (adjust_intervals_for_insertion)
945 (adjust_intervals_for_deletion): Now extern, because otherwise the
946 extern inline functions 'offset_intervals' couldn't refer to it.
947 (static_offset_intervals): Remove.
948 (offset_intervals): Rewrite using the old contents of
949 static_offset_intervals. The old version didn't conform to C99
950 because an extern inline function contained a reference to an
951 identifier with static linkage.
952
953 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
954
955 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
956 GC.
957
958 2011-11-06 Eli Zaretskii <eliz@gnu.org>
959
960 * xdisp.c (init_iterator, reseat_to_string): Don't set the
961 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
962 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
963 return Qleft_to_right.
964
965 2011-11-06 Chong Yidong <cyd@gnu.org>
966
967 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
968 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
969 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
970 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
971 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
972 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
973 (Fwindow_vscroll): Doc fix.
974 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
975 argument, since it makes no sense to pass a live window and for
976 consistency with window-child.
977
978 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
979
980 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
981 support MSVC.
982
983 2011-11-05 Jason Rumney <jasonr@gnu.org>
984
985 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
986 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
987 fonts (Bug#6029).
988 (add_font_entity_to_list): Fix logic errors in mixed boolean and
989 bitwise arithmetic preventing use of unicode-sip and non-truetype
990 opentype fonts.
991
992 2011-11-05 Eli Zaretskii <eliz@gnu.org>
993
994 * s/ms-w32.h (fstat, stat, utime): Move redirections to
995 "emacs"-only part.
996
997 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
998 initialization code to keep similarity to xfns.c after changes
999 from 2011-11-05.
1000
1001 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1002
1003 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1004 (unwind_create_frame): New function (Bug#9943).
1005 (Fx_create_frame): Restructure code to be more similar to the one in
1006 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1007 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1008 Move terminal->reference_count++ just before making the frame official
1009 (Bug#9943).
1010
1011 * nsterm.m (x_free_frame_resources): New function.
1012 (x_destroy_window): Move code to x_free_frame_resources.
1013
1014 * xfns.c (unwind_create_frame): Fix comment.
1015 (Fx_create_frame, x_create_tip_frame):
1016 Move terminal->reference_count++ just before making the frame
1017 official. Move initialization of image_cache_refcount and
1018 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1019
1020 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1021
1022 Support MSVC build with newer versions of Visual Studio.
1023 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1024 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1025 nt/gmake.defs.
1026
1027 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1028 which are not supported by MSVC.
1029 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1030 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1031 bitfields.
1032 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1033 types in bitfields.
1034 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1035
1036 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1037
1038 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1039
1040 Support MSVC build with newer versions of Visual Studio.
1041 * w32.c: Don't include w32api.h for MSVC.
1042 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1043
1044 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1045 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1046 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1047 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1048 e_* cousins.
1049 (alloca) [_MSC_VER]: Define to _alloca.
1050
1051 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1052
1053 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1054
1055 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1056
1057 * xdisp.c (note_mouse_highlight): If either of
1058 previous/next-single-property-change returns nil, treat that as
1059 the beginning or the end of the buffer. (Bug#9955)
1060
1061 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1062
1063 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1064 label is not null (Bug#9951).
1065 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1066 may be NULL.
1067
1068 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1069
1070 * window.c (Fwindow_body_size): Mention in the doc string that the
1071 return value is in frame's canonical units. (Bug#9949)
1072
1073 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1074
1075 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1076
1077 * w32fns.c (unwind_create_frame): If needed, free the glyph
1078 matrices of the partially constructed frame. (Bug#9943)
1079 * xfns.c (unwind_create_frame): Likewise.
1080
1081 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1082
1083 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1084 Don't stop backward scan on the continuation glyph, even though
1085 its CHARPOS is positive.
1086 (mouse_face_from_buffer_pos, note_mouse_highlight):
1087 Rename cover_string to disp_string.
1088
1089 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1090
1091 * window.c (temp_output_buffer_show): Don't use
1092 Vtemp_buffer_show_specifiers.
1093 (Vtemp_buffer_show_specifiers): Remove unused variable.
1094
1095 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1096
1097 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1098 past the beginning of the current glyph matrix.
1099
1100 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1101
1102 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1103 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1104 HAVE_GTK3 (Bug#9869).
1105
1106 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1107 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1108
1109 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1110
1111 * xterm.c: Declare x_handle_net_wm_state to return int.
1112 (handle_one_xevent): Check if we are iconified but don't have
1113 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1114 (get_current_wm_state): Return non-zero if not hidden,
1115 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1116 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1117 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1118 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1119
1120 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1121
1122 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1123 so that this new function doesn't get optimized away by a
1124 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1125
1126 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1127
1128 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1129
1130 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1131
1132 Fix the `xbytecode' command.
1133 * .gdbinit (xprintbytestr): New command.
1134 (xwhichsymbols): Rename from `which'; all callers changed.
1135 (xbytecode): Print the byte-code string as well.
1136
1137 2011-10-29 Kim Storm <storm@cua.dk>
1138
1139 * alloc.c (which_symbols): New function.
1140
1141 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1142
1143 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1144 line. (Bug#9903)
1145
1146 2011-10-29 Glenn Morris <rgm@gnu.org>
1147
1148 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1149 Not clear what it was for, and it causes various bugs. (Bug#9839)
1150
1151 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1152
1153 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1154 possible random value that matches one of those tested as
1155 condition to clear the mouse face.
1156
1157 2011-10-28 Chong Yidong <cyd@gnu.org>
1158
1159 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1160
1161 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1162
1163 * window.c (make_window): Initialize phys_cursor_on_p.
1164
1165 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1166
1167 * lisp.h (struct Lisp_Symbol): Update comments.
1168
1169 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1170
1171 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1172
1173 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1174
1175 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1176 <oslsachem@gmail.com> for helping to debug this.
1177
1178 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1179 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1180 (g_b_init_get_glyph_outline_w): New static variables.
1181 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1182 (GetGlyphOutlineW_Proc): New typedefs.
1183 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1184 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1185 New functions.
1186 (w32font_open_internal, compute_metrics):
1187 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1188 instead of calling the "wide" APIs directly.
1189
1190 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1191
1192 * w32.h (syms_of_w32font): Add prototype.
1193
1194 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1195
1196 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1197 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1198 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1199 (Fmove_to_window_line): Doc fix.
1200
1201 2011-10-27 Chong Yidong <cyd@gnu.org>
1202
1203 * process.c (make_process): Set gnutls_state to NULL.
1204
1205 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1206 non-NULL, regardless of GNUTLS_INITSTAGE.
1207 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1208 an error. Set process slots as soon as we allocate them.
1209
1210 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1211
1212 2011-10-27 Chong Yidong <cyd@gnu.org>
1213
1214 * gnutls.c (emacs_gnutls_deinit): New function.
1215 Deallocate credentials structures as well as calling gnutls_deinit.
1216 (Fgnutls_deinit, Fgnutls_boot): Use it.
1217
1218 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1219 (deactivate_process): Call emacs_gnutls_deinit.
1220
1221 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1222
1223 * image.c (x_create_x_image_and_pixmap):
1224 * w32.c (sys_rename, w32_delayed_load):
1225 * w32font.c (fill_in_logfont):
1226 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1227
1228 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1229
1230 * w32fns.c (w32_default_color_map): New function,
1231 extracted from Fw32_default_color_map.
1232 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1233
1234 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1235
1236 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1237
1238 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1239
1240 * keyboard.c (test_undefined): New function (bug#9751).
1241 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1242
1243 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1244
1245 * sysdep.c (init_sys_modes): Fix the check for the controlling
1246 terminal (Bug#6649).
1247
1248 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1249
1250 * dispextern.h (struct bidi_it): New member next_en_type.
1251
1252 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1253 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1254 current character, check also for next_en_type being WEAK_EN.
1255 (bidi_resolve_weak): Don't enter the expensive loop if the current
1256 position is before next_en_pos. Record the bidi type of the first
1257 non-ET, non-BN character we find, in addition to its position.
1258 (bidi_level_of_next_char): Invalidate next_en_type when
1259 next_en_pos is over-stepped.
1260
1261 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1262
1263 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1264 * editfns.c: Rewrite current-time-zone so that it invokes
1265 the equivalent of (format-time-string "%Z") to get the time zone name.
1266 This fixes a bug when the time zone name contains characters that
1267 need converting from the system time locale to Emacs internal format.
1268 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1269 that patch fixed format-time-string to do the conversion, but
1270 I forgot to fix current-time-zone.
1271 (format_time_string): New function, containing most of
1272 what Fformat_time_string used to contain.
1273 (Fformat_time_string): Rewrite in terms of format_time_string.
1274 This doesn't change this function's behavior.
1275 (current-time-zone): Rewrite to use format_time_string.
1276 This fixes the bug reported by Michael Schierl in
1277 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1278 Jason Rumney's 2007-06-07 change worked around this bug, but
1279 didn't fix it.
1280 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1281
1282 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1283
1284 * xdisp.c (start_display): If the character at POS is displayed
1285 via a display vector, reset IT->current.dpvec_index to zero.
1286 (try_window_reusing_current_matrix): If a line ends in a display
1287 vector or the next line starts in a display vector, continue
1288 redrawing the window even though the character position of
1289 start_row was reached.
1290 (Bug#9771, part 2)
1291
1292 2011-10-18 Chong Yidong <cyd@gnu.org>
1293
1294 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1295 with nobreak-char-display too.
1296
1297 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1298
1299 Fix part 3 of bug#9771.
1300 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1301 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1302 non-neutral characters if the current character is a paragraph
1303 separator (a.k.a. Newline). This avoids running the same
1304 expensive loop twice, once when we consume the preceding newline
1305 and the other time when the line actually needs to be displayed.
1306 Avoid the loop when we see neutrals on the base embedding level
1307 following a character whose directionality is the same as the
1308 paragraph's. This avoids running the expensive loop when a line
1309 ends in a long sequence of neutrals, like control characters.
1310 Add assertion against STRONG_AL type. Slightly rearrange code
1311 that determines the type of a neutral given the first non-neutral
1312 that follows it.
1313 (bidi_level_of_next_char): Set next_en_pos to zero when
1314 invalidating its info.
1315
1316 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1317
1318 * xdisp.c (push_display_prop): Determine whether to record string
1319 or buffer position by IT->string, not by IT->method. Allow
1320 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1321 (move_it_vertically_backward): Don't look for character position
1322 immediately after the newline when in a continuation line.
1323 (Bug#9771, part 1)
1324
1325 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1326
1327 * window.c (coordinates_in_window): Rewrite and delabelize
1328 vertical border check. (Bug#5357) (Bug#9618)
1329
1330 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1331
1332 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1333 errors in XSetWindowBorder (bug#9310).
1334
1335 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1336
1337 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1338 avoid crash when xmalloc overrun checking is enabled.
1339
1340 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1341
1342 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1343 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1344 cursor motion with <left> and <right> arrow keys.
1345
1346 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1347 some callers set that themselves.
1348
1349 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1350
1351 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1352 display string and the previous row comes from the same string and
1353 is empty. (Bug#9739) (Bug#9738)
1354
1355 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1356
1357 * doc.c (get_doc_string): Encode file name (bug#9735).
1358
1359 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1360
1361 * bidi.c (bidi_level_of_next_char):
1362 * xdisp.c (get_visually_first_element): Remove old incorrect
1363 comments regarding the Unicode Line Separator character.
1364
1365 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1366
1367 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1368
1369 * alloc.c (Fgc_status): Do not access beyond zombies array
1370 boundary if nzombies > MAX_ZOMBIES.
1371 * alloc.c (dump_zombies): Add missing format specifier.
1372
1373 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1376 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1377
1378 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1379 Some packages use them to denote characters with modifiers.
1380
1381 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1382
1383 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1384 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1385 matching a pp-number. Rename parameter var to var1.
1386
1387 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1388
1389 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1390
1391 2011-10-08 Glenn Morris <rgm@gnu.org>
1392
1393 * callint.c (Fcall_interactively): Give a more explicit error for the
1394 'c' case with a non-character input. (Bug#8479)
1395
1396 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1397
1398 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1399 lines.
1400 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1401 lines that are hscrolled on the left.
1402
1403 * dispnew.c (buffer_posn_from_coords): Account for a possible
1404 presence of header-line. (Bug#4426)
1405
1406 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1407
1408 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1409 Don't advertise functionality which we discourage or doesn't work.
1410
1411 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1412
1413 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1414 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1415 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1416 this makes Emacs dump core during garbage collection on rare
1417 occasions. sizeof is obviously inferior to offsetof here, so
1418 stick with offsetof.
1419 (GC_POINTER_ALIGNMENT): New macro.
1420 (mark_memory): Omit 3rd (offset) arg; caller changed.
1421 Don't assume EMACS_INT alignment is the same as pointer alignment.
1422
1423 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1424
1425 * keyboard.c (read_key_sequence_remapped): New var.
1426 (read_key_sequence): Compute remapping in the right buffer.
1427 (command_loop_1): Use read_key_sequence's remapping directly.
1428
1429 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1430
1431 * dired.c (file_name_completion): Don't expand file name.
1432 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1433 before checking file name handler.
1434
1435 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1436 they've been requested explicitly (bug#9591).
1437
1438 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1439
1440 * keymap.c (Fsingle_key_description): Use make_specified_string
1441 instead of build_string to build string from push_key_description.
1442 (Bug#5193)
1443
1444 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1445
1446 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1447 This fixes a Y2038 bug on 64-bit hosts.
1448 * buffer.c (reset_buffer):
1449 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1450 (Fclear_buffer_auto_save_failure):
1451 Use 0, not -1, to represent an unset failure time, since time_t
1452 might not be signed.
1453
1454 Remove dependency on glibc malloc internals.
1455 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1456 Move back here from lisp.h, but with their new implementations.
1457 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1458 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1459 * charset.c (charset_table_init): New static var.
1460 (syms_of_charset): Use it instead of xmalloc. This removes a
1461 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1462 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1463 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1464 Move back to alloc.c.
1465 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1466 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1467
1468 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1469
1470 * nsterm.m (windowDidResize): Call x_set_window_size only when
1471 ns_in_resize is true. Otherwise set pixelwidth/height and
1472 call change_frame_size (Bug#9628).
1473
1474 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 Port --enable-checking=all to Fedora 14 x86-64.
1477 * charset.c (syms_of_charset): Also account for glibc malloc's
1478 internal overhead when calculating the initial malloc maximum.
1479
1480 Port --enable-checking=all to Fedora 14 x86.
1481 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1482 Move to lisp.h.
1483 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1484 (overrun_check_realloc, overrun_check_free):
1485 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1486 That way, xmalloc returns a properly-aligned pointer even if
1487 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1488 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1489 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1490 into account when calculating the initial malloc maximum.
1491 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1492 Move here from alloc.c, so that charset.c can use it too.
1493 Properly align; the old code wasn't right for common 32-bit hosts
1494 when configured with --enable-checking=all.
1495 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1496 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1497
1498 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1499
1500 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1501 use EDOM.
1502
1503 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1504
1505 * xdisp.c (compute_display_string_end): If there's no display
1506 string at CHARPOS, return -1.
1507
1508 * bidi.c (bidi_fetch_char): When compute_display_string_end
1509 returns a negative value, treat the character as a normal
1510 character not covered by a display string. (Bug#9624)
1511
1512 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1513
1514 * lread.c (Fread_from_string): Fix typo in docstring.
1515
1516 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1517
1518 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1519 newline, reseat the iterator instead of bidi-iterating there one
1520 character at a time. (Bug#9610)
1521 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1522 TO_CHARPOS if the bidi iterator is at base embedding level.
1523
1524 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1525
1526 * lread.c (readevalloop): Use correct code for NBSP.
1527 (read1): Likewise. (Bug#9608)
1528
1529 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1530
1531 * dbusbind.c (Fdbus_register_signal): When service is not
1532 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1533
1534 2011-09-25 Glenn Morris <rgm@gnu.org>
1535
1536 * buffer.c (truncate-lines): Doc fix.
1537
1538 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1539
1540 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1541 (Fset_window_next_buffers): Doc fix.
1542
1543 2011-09-24 Glenn Morris <rgm@gnu.org>
1544
1545 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1546
1547 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1548
1549 Fix minor problems found by static checking.
1550 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1551 * indent.c (Fvertical_motion): Fix == vs = typo.
1552
1553 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1554
1555 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1556 Default value is now t. Doc fix.
1557
1558 * indent.c (Fvertical_motion): Compute and apply the overshoot
1559 logic when moving up, not only when moving down. Fix the
1560 confusing name and values of the it_overshoot_expected variable;
1561 logic changes accordingly. (Bug#9254) (Bug#9549)
1562
1563 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1564 CHARPOS is covered by a display string which includes newlines.
1565 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1566 is covered by a display string with embedded newlines.
1567
1568 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1569
1570 * dbusbind.c (Fdbus_register_signal): Add match rule to
1571 Vdbus_registered_objects_table. (Bug#9581)
1572 (Fdbus_register_method, Vdbus_registered_objects_table):
1573 Fix docstring.
1574
1575 2011-09-24 Jim Meyering <meyering@redhat.com>
1576
1577 do not ignore write error for any output size
1578 The previous change was incomplete.
1579 While it makes emacs --batch detect the vast majority of stdout
1580 write failures, errors were still ignored whenever the output size is
1581 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1582 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1583 && echo FAIL: ignored write error
1584 FAIL: ignored write error
1585 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1586 && echo FAIL: ignored write error
1587 FAIL: ignored write error
1588 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1589
1590 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1591
1592 * emacs.c (Fkill_emacs): In noninteractive mode exit
1593 non-successfully if a write error occurred on stdout. (Bug#9574)
1594
1595 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1596
1597 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1598 the xassert test.
1599
1600 * dispextern.h (struct it): Update the comment documenting what
1601 can it->OBJECT be.
1602
1603 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1604
1605 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1606 a display string, extend search for cursor position to end of row.
1607 (find_row_edges): If the row ends in a newline from a display
1608 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1609 Handle the case of a display string with multiple newlines.
1610 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1611 non-empty line. Fixes confusing cursor motion with arrow keys at
1612 the beginning of a line that starts with whitespace.
1613
1614 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1615
1616 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1617 (bug#9493).
1618
1619 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1620
1621 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1622 boolean (Bug#9154).
1623
1624 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1625
1626 * xdisp.c (display_line): Record maximum and minimum buffer
1627 positions even if no glyphs were produced (e.g., by a zero-width
1628 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1629 buffer positions that will be removed from the glyph row because
1630 they don't fit.
1631 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1632 column is beyond frame width: don't subtract 1 "pixel" when
1633 computing width of the stretch.
1634 (reseat_at_next_visible_line_start): Undo the change made on
1635 2011-09-17 that saved paragraph information and restored it after
1636 the call to `reseat'. (Bug#9545)
1637
1638 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1639
1640 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1641 and turn window cursor on if cleared (Bug#9415).
1642
1643 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1644
1645 * search.c (boyer_moore): Take unibyte characters from pattern
1646 literally. (Bug#9458)
1647
1648 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1649
1650 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1651
1652 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1653
1654 Fix minor problem found by static checking.
1655 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1656 initialized, to pacify gcc -Wuninitialized.
1657
1658 * fileio.c: Report proper errno when syscall falls.
1659 (Finsert_file_contents): Save and restore errno,
1660 so that report_file_error outputs the correct diagnostic.
1661 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1662
1663 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1664
1665 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1666
1667 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1668
1669 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1670 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1671
1672 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1673
1674 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1675 about the current paragraph and restore it after the call to reseat.
1676
1677 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1678 (bidi_find_paragraph_start): Search back for paragraph beginning
1679 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1680 (bidi_move_to_visually_next): Only trigger paragraph-related
1681 computations when the last character is a newline or at EOB, not
1682 just any NEUTRAL_B. (Bug#9470)
1683
1684 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1685 truncated lines if point is covered by a display string. (Bug#9524)
1686
1687 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1688
1689 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1690 (cons_to_x_long): New function.
1691 (lisp_data_to_selection_data): Use it. Correct the test for
1692 short-versus-long data; it was negated. Break out of vector
1693 loop, for efficiency, when a long datum is discovered.
1694
1695 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1696
1697 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1698
1699 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1700
1701 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1702 GCC PR/17406) by declaring this function with external scope.
1703
1704 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1705
1706 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1707 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1708
1709 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1710
1711 * editfns.c (Fformat): Correctly handle text properties on "%%".
1712
1713 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1714
1715 * xterm.c (x_draw_composite_glyph_string_foreground):
1716 * w32term.c (x_draw_composite_glyph_string_foreground):
1717 * term.c (encode_terminal_code):
1718 * composite.c (composition_update_it, get_composition_id):
1719 * xdisp.c (get_next_display_element)
1720 (fill_composite_glyph_string): Add comments about special meaning
1721 of TAB characters in a composition.
1722
1723 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1726 This occurs when processing a multibyte format.
1727 Problem reported by Wolfgang Jenker.
1728
1729 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1730
1731 * xdisp.c (try_cursor_movement): Only check for exact match if
1732 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1733
1734 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1735
1736 Remove unused external symbols.
1737 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1738 * xdisp.c (calc_pixel_width_or_height): Now static.
1739 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1740 * indent.c (check_display_width):
1741 * w32term.c: Fix comment to match code.
1742 * xterm.c, xterm.h (x_catching_errors): Remove.
1743
1744 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 * xselect.c: Use signed conversions more consistently (Bug#9498).
1747 (selection_data_to_lisp_data): Assume incoming selection data are
1748 signed integers, not unsigned. This is to be consistent with
1749 outgoing selection data, which was modified to use signed integers
1750 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1751 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1752 expects long, not unsigned long.
1753
1754 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1755
1756 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1757 computation of loop end. Reported by Johan Bockgård
1758 <bojohan@gnu.org>.
1759
1760 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1761
1762 * frame.c (Fother_visible_frames_p): Function deleted.
1763
1764 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1765
1766 * indent.c (compute_motion): Process display vector front to back
1767 rather than the other way around. (Bug#2496)
1768
1769 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1770
1771 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1772
1773 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1774
1775 * minibuf.c (Fread_from_minibuffer): Doc fix.
1776
1777 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1778
1779 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1780 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1781
1782 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1783
1784 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1785 value for non-existent files.
1786
1787 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1788
1789 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1790 set its "size" to -1. This will set the modtime_size field of
1791 the corresponding buffer to -1, which is what
1792 verify-visited-file-modtime expects for files that do not exist.
1793 (Bug#9139)
1794
1795 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1798 here ...
1799 * lisp.h: ... from here. push_key_description is no longer
1800 defined in keyboard.c, so its declaration should not be in
1801 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1802 logically belongs with push_key_description.
1803
1804 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1805
1806 * buffer.h: Include <sys/types.h> instead of <time.h>.
1807 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1808 Problem reported by Herbert J. Skuhra.
1809
1810 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1811
1812 * xml.c (parse_region): Make the parsing work for
1813 non-comment-starting XML files again (bug#9144).
1814
1815 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1816
1817 * image.c (gif_load): Fix calculation of bottom and right corner.
1818 (Bug#9468)
1819
1820 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1821
1822 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1823 redisplay in small windows.
1824
1825 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1826
1827 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1828
1829 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1830
1831 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1832 Operate on live windows only.
1833
1834 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1835
1836 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1837
1838 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1839
1840 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1841 only under bidi iteration.
1842
1843 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1844
1845 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1846
1847 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1848
1849 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1850 Without this fix, the command to link temacs failed due to an
1851 undefined symbol __builtin_isnan. This is because
1852 /usr/include/iso/math_c99.h #defines isnan(x) to
1853 __builtin_isnan(x), but the bundled gcc, which identifies itself
1854 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1855 a __builtin_isnan.
1856 * floatfns.c (isnan): #undef, and then #define to a clone of
1857 what's in data.c.
1858 (Fisnan): Always define, since it's always available now.
1859 (syms_of_floatfns): Always define isnan at the Lisp level.
1860
1861 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1864
1865 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1868 The previous code assumed that file offsets (off_t values) fit in
1869 EMACS_INT variables, which is not true on typical 32-bit hosts.
1870 The code messed up by falsely reporting buffer overflow in cases
1871 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1872 when "big" contains more than 2**29 bytes, even though this
1873 inserts just one byte and does not overflow the buffer.
1874 (Finsert_file_contents): Store file offsets as off_t
1875 values, not as EMACS_INT values. Check for overflow when
1876 converting between EMACS_INT and off_t. When checking for
1877 buffer overflow or for overlap, take the offsets into account.
1878 Don't use EMACS_INT for small values where int suffices.
1879 When checking for overlap, fix a typo: ZV was used where
1880 ZV_BYTE was intended.
1881 (Fwrite_region): Don't assume off_t fits into 'long'.
1882 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1883
1884 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1885
1886 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1887
1888 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 sprintf-related integer and memory overflow issues (Bug#9412).
1891
1892 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1893 (esprintf, exprintf, evxprintf): New functions.
1894 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1895 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1896 (modify_event_symbol): Do not assume that the length of
1897 name_alist_or_stem is safe to alloca and fits in int.
1898 (Fexecute_extended_command): Likewise for function name and binding.
1899 (Frecursion_depth): Wrap around reliably on integer overflow.
1900 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1901 since some callers pass EMACS_INT values.
1902 (Fsingle_key_description): Don't crash if symbol name contains more
1903 than MAX_ALLOCA bytes.
1904 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1905 (get_minibuffer): Arg is now EMACS_INT, not int.
1906 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1907 (esprintf, exprintf, evxprintf): New decls.
1908 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1909
1910 * dbusbind.c (signature_cat): New function.
1911 (xd_signature, Fdbus_register_signal):
1912 Do not overrun buffer; instead, report string overflow.
1913
1914 * dispnew.c (add_window_display_history): Don't overrun buffer.
1915 Truncate instead; this is OK since it's just a log.
1916
1917 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1918 even if the time zone offset is outlandishly large.
1919 Don't mishandle offset == INT_MIN.
1920
1921 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1922 when creating daemon; the previous buffer-overflow check was incorrect.
1923
1924 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1925 which has the guts of the old verror function.
1926
1927 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1928 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1929
1930 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1931 (font_unparse_xlfd): Don't blindly alloca long strings.
1932 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1933 fits in int, when using sprintf. Use single snprintf to count
1934 length of string rather than counting it via multiple sprintfs;
1935 that's simpler and more reliable.
1936 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1937 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1938 sprintf, in case result does not fit in int.
1939
1940 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1941 (fontset_from_font): Print it.
1942
1943 * frame.c (tty_frame_count): Now printmax_t, not int.
1944 (make_terminal_frame, set_term_frame_name): Print it.
1945 (x_report_frame_params): In X, window IDs are unsigned long,
1946 not signed long, so print them as unsigned.
1947 (validate_x_resource_name): Check for implausibly long names,
1948 and don't assume name length fits in 'int'.
1949 (x_get_resource_string): Don't blindly alloca invocation name;
1950 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1951 not fit in int.
1952
1953 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1954 (xg_check_special_colors, xg_set_geometry):
1955 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1956
1957 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1958 Use esprintf, not sprintf, in case result does not fit in int.
1959
1960 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1961 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1962 it as a large positive number.
1963 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1964 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1965
1966 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1967 in case result does not fit in int.
1968
1969 * print.c (float_to_string): Detect width overflow more reliably.
1970 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1971 buffer overrun. Don't assume list length fits in 'int'. Treat
1972 print length of 0 as 0, not as infinity; to be consistent with other
1973 uses of print length in this function. Don't overflow print length
1974 index. Don't assume hash table size fits in 'long', or that
1975 vectorlike size fits in 'unsigned long'.
1976
1977 * process.c (make_process): Use printmax_t, not int, to format
1978 process-name gensyms.
1979
1980 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1981
1982 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1983 to avoid potential buffer overrun.
1984
1985 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1986 if X resource line is longer than 512 bytes.
1987
1988 * xfns.c (x_window): Make sprintf buffer a bit bigger
1989 to avoid potential buffer overrun.
1990
1991 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1992
1993 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1994
1995 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1996
1997 Integer overflow fixes for scrolling, etc.
1998 Without these, Emacs silently mishandles large integers sometimes.
1999 For example, "C-u 4294967297 M-x recenter" was treated as if
2000 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2001
2002 * xdisp.c (try_window_id): Check Emacs fixnum range before
2003 converting to 'int'.
2004
2005 * window.c (window_scroll_line_based, Frecenter):
2006 Check that an Emacs fixnum is in range before assigning it to 'int'.
2007 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2008 values converted from Emacs fixnums.
2009 (Frecenter): Don't wrap around a line count if it is out of 'int'
2010 range; instead, treat it as an extreme value.
2011 (Fset_window_configuration, compare_window_configurations):
2012 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2013
2014 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2015 that can exceed INT_MAX. Check that EMACS_INT value is in range
2016 before assigning it to the (possibly-narrower) index.
2017 (match_limit): Don't assume that a fixnum can fit in 'int'.
2018
2019 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2020 exceed INT_MAX.
2021
2022 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2023 (Fvertical_motion): Don't wrap around LINES values that don't fit
2024 in 'int'. Instead, treat them as extreme values. This is good
2025 enough for windows, which can't have more than INT_MAX lines anyway.
2026
2027 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2028
2029 * Require libxml/parser.h to avoid compilation warning.
2030
2031 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2032
2033 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2034 since this reportedly can destroy thread storage.
2035
2036 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2037
2038 * syntax.c (find_defun_start): Update all cache variables if
2039 exiting early (Bug#9401).
2040
2041 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2042
2043 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2044
2045 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2046 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2047 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2048
2049 * term.c (tty_append_glyph): New function.
2050 (produce_stretch_glyph): Static function and its prototype deleted.
2051
2052 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2053 Add prototypes.
2054
2055 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2056
2057 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2058 when checking :margin (Bug#9390).
2059 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2060 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2061 so that the name doesn't mislead. All uses changed.
2062
2063 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2064
2065 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2066 set_tty_hooks.
2067
2068 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2069
2070 * xdisp.c (move_it_to): Don't bail out early when reaching
2071 position beyond to_charpos, if we are scanning backwards.
2072 (move_it_vertically_backward): When DY == 0, make sure we get to
2073 the first character in the line after the newline.
2074
2075 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2078 (ccl_driver): Do not generate an out-of-range pointer.
2079 (Fccl_execute_on_string): Remove unnecessary check for
2080 integer overflow, noted by Stefan Monnier in
2081 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2082 Remove a FIXME that didn't need fixing.
2083 Simplify the newly-introduced buffer reallocation code.
2084
2085 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2086
2087 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2088
2089 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2090
2091 Integer and memory overflow issues (Bug#9196).
2092
2093 * doc.c (get_doc_string): Rework so that
2094 get_doc_string_buffer_size is the actual buffer size, rather than
2095 being 1 less than the actual buffer size; this makes xpalloc more
2096 convenient.
2097
2098 * image.c (x_allocate_bitmap_record, cache_image):
2099 * xselect.c (Fx_register_dnd_atom):
2100 Simplify previous changes by using xpalloc.
2101
2102 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2103 since either will do and ptrdiff_t is convenient with xpalloc.
2104
2105 * charset.c (charset_table_size)
2106 (struct charset_sort_data.priority): Now ptrdiff_t.
2107 (charset_compare): Don't overflow if priorities differ greatly.
2108 (Fsort_charsets): Don't assume list length fits in int.
2109 Check for size-calculation overflow when allocating sort data.
2110 (syms_of_charset): Allocate an initial charset table that is
2111 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2112
2113 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2114
2115 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2116 The actual value is always <= INT_MAX, and leaving it unsigned made
2117 overflow checking harder.
2118
2119 * dispextern.h (struct glyph_matrix.rows_allocated)
2120 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2121 with xpalloc. The values are still always <= INT_MAX.
2122
2123 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2124
2125 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2126 (SAFE_NALLOCA): New macro.
2127
2128 * region-cache.c (struct boundary.pos, find_cache_boundary)
2129 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2130 (set_cache_region, invalidate_region_cache)
2131 (revalidate_region_cache, know_region_cache, region_cache_forward)
2132 (region_cache_backward, pp_cache):
2133 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2134 so that ptrdiff_t * can be passed to xpalloc.
2135 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2136 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2137 (pp_cache): Don't assume cache_len fits in int.
2138 * region-cache.h: Adjust extern decls to match.
2139
2140 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2141 EMACS_INT, since either will do, for xpalloc.
2142
2143 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2144 (xnmalloc, xnrealloc, xpalloc): New functions.
2145
2146 * bidi.c (bidi_shelve_header_size): New constant.
2147 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2148 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2149
2150 * bidi.c (bidi_cache_shrink):
2151 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2152 (overlay_strings):
2153 Don't update size of array until after memory allocation succeeds,
2154 because xmalloc/xrealloc may not return.
2155 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2156 now that we have proper integer overflow checking.
2157 (record_overlay_string, overlay_strings): Catch overflows when
2158 calculating size of overlay_str_buf.
2159
2160 * callproc.c (Fcall_process): Check for size overflow when
2161 calculating size of args2.
2162 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2163 Normally we prefer signed values, but sticking with ptrdiff_t would
2164 require adding more-complicated checks.
2165
2166 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2167 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2168 Redo buffer-overflow calculations to avoid integer overflow.
2169 Add a FIXME comment where memory seems to be over-allocated.
2170
2171 * character.c (Fstring): Check for size-calculation overflow.
2172
2173 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2174 unnecessary integer overflow. Check for size overflow.
2175 (encode_coding_object): Don't update size until xmalloc succeeds.
2176
2177 * composite.c (get_composition_id): Check for overflow in glyph
2178 length calculations.
2179
2180 Integer and memory overflow fixes for display code.
2181 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2182 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2183 (scrolling_window): Check for overflow in size calculations.
2184 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2185 Don't assume glyph table len fits in int.
2186 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2187 (row_table_size): Now ptrdiff_t, not int.
2188 (scrolling_window): Avoid overflow in size calculations.
2189 Don't update size until allocation succeeds.
2190 * fns.c (concat): Check for overflow in size calculations.
2191 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2192 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2193 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2194
2195 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2196 (get_doc_string): Check for size calculation overflow.
2197 Don't update size until allocation succeeds.
2198 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2199 EMACS_INT, where ptrdiff_t will do.
2200 (Fsubstitute_command_keys): Check for string overflow.
2201
2202 * editfns.c (set_time_zone_rule): Don't assume environment length
2203 fits in int.
2204 (message_length): Now ptrdiff_t, not int.
2205 (Fmessage_box): Don't update size until allocation succeeds.
2206 Don't assume message length fits in int.
2207 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2208
2209 * emacs.c (main): Do not reallocate argv, since there is a null at
2210 the end that can be overwritten, and this way there's no need to
2211 worry about size-calculation overflow.
2212 (sort_args): Check for size-calculation overflow.
2213
2214 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2215 alloc succeeds.
2216 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2217
2218 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2219 (x_set_scroll_bar_width, x_figure_window_size):
2220 Check for integer overflow.
2221 (x_set_alpha): Do not assume XINT fits in int.
2222
2223 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2224 This is for the members text_lines, text_cols, total_lines, total_cols,
2225 where the system imposes an 'int' limit.
2226
2227 * fringe.c (Fdefine_fringe_bitmap):
2228 Don't update size until alloc works.
2229
2230 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2231 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2232
2233 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2234 Check for size-calculation overflow.
2235 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2236 do, as we prefer signed integers.
2237 (id_to_widget.max_size, id_to_widget.used)
2238 (xg_store_widget_in_map, xg_remove_widget_from_map)
2239 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2240 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2241 Use and return ptrdiff_t, not int.
2242 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2243 * gtkutil.h: Change prototypes to match the above.
2244
2245 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2246 are duplicate now that they've been promoted to lisp.h.
2247 (x_allocate_bitmap_record, x_alloc_image_color)
2248 (make_image_cache, cache_image, xpm_load):
2249 Don't update size until alloc is done.
2250 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2251 (x_detect_edges):
2252 Check for size calculation overflow.
2253 (ct_colors_allocated_max): New constant.
2254 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2255 overflow.
2256
2257 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2258 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2259 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2260 Use ptrdiff_t, not int, to count maps.
2261 (read_char_minibuf_menu_prompt): Check for overflow in size
2262 calculations. Don't update size until allocation succeeds.
2263 Redo calculations to avoid overflow.
2264 * keyboard.h: Change prototypes to match the above.
2265
2266 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2267 to count maps.
2268 (current_minor_maps): Check for size calculation overflow.
2269 * keymap.h: Change prototypes to match the above.
2270
2271 * lread.c (read1, init_obarray): Don't update size until alloc done.
2272
2273 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2274 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2275
2276 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2277 Now ptrdiff_t, not int.
2278 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2279 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2280
2281 * process.c (Fnetwork_interface_list): Check for overflow
2282 in size calculation.
2283
2284 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2285
2286 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2287 overflow. Don't bother calling xmalloc when xrealloc will do.
2288
2289 * search.c (Freplace_match): Check for size calculation overflow.
2290 (Fset_match_data): Don't assume list lengths fit in 'int'.
2291
2292 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2293 for command line length. Do not attempt to address one before the
2294 beginning of an array, as that's not portable.
2295
2296 * term.c (max_frame_lines): Remove; unused.
2297 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2298 not int.
2299 (encode_terminal_code, calculate_costs): Check for size
2300 calculation overflow.
2301 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2302 table lengths and related sizes. Don't update size until alloc
2303 done. Redo calculations to avoid overflow.
2304 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2305
2306 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2307 subtracting pointers.
2308 (gobble_line): Check for overflow more carefully. Don't update size
2309 until alloc done.
2310
2311 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2312 Don't update size until alloc done.
2313 Redo size calculations to avoid overflow.
2314 Check for size calculation overflow.
2315 (main) [DEBUG]: Fix typo in invoking tparam1.
2316
2317 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2318 Use ptrdiff_t, not int, for sizes.
2319 (store_mode_line_noprop_char): Don't update size until alloc done.
2320
2321 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2322 Use ptrdiff_t, not int, for sizes.
2323 (Finternal_make_lisp_face, cache_face):
2324 Check for size calculation overflow.
2325 (cache_face): Treat size calculation overflows as if they were
2326 memory exhaustion (the usual treatment), rather than aborting.
2327
2328 * xfns.c (x_encode_text, x_set_name_internal)
2329 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2330 sizes, since they can exceed INT_MAX in size. Check for size
2331 calculation overflow.
2332
2333 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2334 (xg_select): Check for size calculation overflow.
2335 Don't update size until alloc done.
2336
2337 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2338 as sprintf is limited to int lengths.
2339
2340 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2341 (X_LONG_MIN): New macros.
2342 Use them to make the following changes clearer.
2343 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2344 This change doesn't affect the value now, but it may help remind
2345 future maintainers not to raise the value too much later.
2346 (SELECTION_QUANTUM): Remove, replacing with ...
2347 (selection_quantum): ... new function, which avoids overflow.
2348 All uses changed.
2349 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2350 assumption that selection length fits in 'int'.
2351 (x_reply_selection_request, x_handle_selection_request)
2352 (x_get_window_property, receive_incremental_selection)
2353 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2354 (lisp_data_to_selection_data, clean_local_selection_data):
2355 Use ptrdiff_t, not int, to record length of selection.
2356 (x_reply_selection_request, x_get_window_property)
2357 (receive_incremental_selection, x_property_data_to_lisp):
2358 Redo calculations to avoid overflow.
2359 (x_reply_selection_request): When sending hint, ceiling it at
2360 X_LONG_MAX rather than relying on wraparound overflow to send
2361 something.
2362 (x_get_window_property, receive_incremental_selection)
2363 (lisp_data_to_selection_data, x_property_data_to_lisp):
2364 Check for size-calculation overflow.
2365 (x_get_window_property, receive_incremental_selection)
2366 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2367 Don't store size until memory allocation succeeds.
2368 (x_get_window_property): Plug memory leak on memory exhaustion.
2369 Don't double-block input; malloc is safe here. Don't assume 2**34
2370 - 4 fits in unsigned long. Add an xassert to check
2371 XGetWindowProperty overflow. Be more careful about overflow
2372 calculations, and distinguish size from memory overflow better.
2373 (receive_incremental_selection): When tracing, don't assume
2374 unsigned int is less than INT_MAX.
2375 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2376 harmful) conversions of unsigned short to int.
2377 (lisp_data_to_selection_data): Don't assume that integers
2378 in the range -65535 through -1 fit in an X unsigned short.
2379 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2380 result parameters unless successful. Rely on cons_to_unsigned
2381 to report problems with elements; the old code wasn't right anyway.
2382 (x_check_property_data): Check for int overflow; we cannot use
2383 a wider type due to X limits.
2384 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2385
2386 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2387
2388 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2389 (x_term_init): Check for size calculation overflow.
2390 (x_color_cells): Don't store size until memory allocation succeeds.
2391 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2392 Don't assume alloca size is less than MAX_ALLOCA.
2393 (x_term_init): Don't assume length fits in int (sprintf is limited
2394 to int size).
2395
2396 Use ptrdiff_t for composition IDs.
2397 * character.c (lisp_string_width):
2398 * composite.c (composition_table_size, n_compositions)
2399 (get_composition_id, composition_gstring_from_id):
2400 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2401 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2402 * window.c (Frecenter):
2403 Use ptrdiff_t, not int, for composition IDs.
2404 * composite.c (get_composition_id): Check for integer overflow.
2405 * composite.h: Adjust prototypes to match the above changes.
2406
2407 Use ptrdiff_t for hash table indexes.
2408 * category.c (hash_get_category_set):
2409 * ccl.c (ccl_driver):
2410 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2411 * coding.c (coding_system_charset_list, detect_coding_system):
2412 * coding.h (struct coding_system.id):
2413 * composite.c (get_composition_id, gstring_lookup_cache):
2414 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2415 * image.c (xpm_get_color_table_h):
2416 * lisp.h (hash_lookup, hash_put):
2417 * minibuf.c (Ftest_completion):
2418 Use ptrdiff_t for hash table indexes, not int (which is too
2419 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2420 32-bit --with-wide-int hosts).
2421
2422 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2423 Add a FIXME comment about memory leaks.
2424 (syms_of_charset): Don't assume xmalloc returns.
2425
2426 Don't assume that stated character widths fit in int.
2427 * character.c (Fchar_width, c_string_width, lisp_string_width):
2428 * character.h (CHAR_WIDTH):
2429 * indent.c (MULTIBYTE_BYTES_WIDTH):
2430 Use sanitize_char_width to avoid undefined and/or bad behavior
2431 with outlandish widths.
2432 * character.h (sanitize_tab_width): Rename from sanitize_width,
2433 now that we have two such functions. All uses changed.
2434 (sanitize_char_width): New inline function.
2435
2436 Don't assume that tab-width fits in int.
2437 * character.h (sanitize_width): New inline function.
2438 (SANE_TAB_WIDTH): New macro.
2439 (ASCII_CHAR_WIDTH): Use it.
2440 * indent.c (sane_tab_width): Remove. All uses replaced by
2441 SANE_TAB_WIDTH (current_buffer).
2442 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2443
2444 * fileio.c: Integer overflow issues with file modes.
2445 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2446
2447 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2448 Remove unreachable code.
2449 (read_hex, load_charset_map_from_file): Check for integer overflow.
2450
2451 * xterm.c: Don't go over XClientMessageEvent limit.
2452 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2453 (x_send_scroll_bar_event): Likewise. Check that the size does not
2454 exceed limits imposed by XClientMessageEvent, as well as the usual
2455 ptrdiff_t and size_t limits.
2456
2457 * keyboard.c: Overflow, signedness and related fixes.
2458 (make_lispy_movement): Use same integer type in forward decl
2459 that is used in the definition.
2460 (read_key_sequence, keyremap_step):
2461 Change bufsize argument back to int, undoing my 2011-03-30 change.
2462 We prefer signed types, and int is wide enough here.
2463 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2464 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2465 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2466 length, not size_t. Use ptrdiff_t for index, not int.
2467 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2468 possibility of integer overflow.
2469
2470 Overflow, signedness and related fixes for images.
2471
2472 * dispextern.h (struct it.stack[0].u.image.image_id)
2473 (struct_it.image_id, struct image.id, struct image_cache.size)
2474 (struct image_cache.used, struct image_cache.ref_count):
2475 * gtkutil.c (update_frame_tool_bar):
2476 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2477 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2478 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2479 * nsmenu.m (update_frame_tool_bar):
2480 * xdisp.c (calc_pixel_width_or_height):
2481 * xfns.c (image_cache_refcount):
2482 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2483 on typical 64-bit hosts.
2484
2485 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2486 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2487 Omit unnecessary casts to int.
2488 (parse_image_spec): Check that integers fall into 'int' range
2489 when the callers expect that.
2490 (image_ascent): Redo ascent calculation to avoid int overflow.
2491 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2492 (lookup_image): Remove unnecessary tests.
2493 (xbm_image_p): Locals are now of int, not EMACS_INT,
2494 since parse_image_check makes sure they fit into int.
2495 (png_load, gif_load, svg_load_image):
2496 Prefer int to unsigned where either will do.
2497 (tiff_handler): New function, combining the cores of the
2498 old tiff_error_handler and tiff_warning_handler.
2499 This function is rewritten to use vsnprintf and thereby avoid
2500 stack buffer overflows. It uses only the features of vsnprintf
2501 that are common to both POSIX and native Microsoft.
2502 (tiff_error_handler, tiff_warning_handler): Use it.
2503 (tiff_load, gif_load, imagemagick_load_image):
2504 Don't assume :index value fits in 'int'.
2505 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2506 (imagemagick_load_image): Check that crop parameters fit into
2507 the integer types that MagickCropImage accepts. Don't assume
2508 Vimagemagick_render_type has a nonnegative value. Don't assume
2509 size_t fits in 'long'.
2510 (gs_load): Use printmax_t to print the widest integers possible.
2511 Check for integer overflow when computing image height and width.
2512
2513 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2514
2515 * xdisp.c (redisplay_window): Don't force window start if point
2516 will be invisible in the resulting window. (Bug#9324)
2517
2518 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2519
2520 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2521 the display spec is of the form `(space ...)'.
2522 (handle_display_spec): Return the value returned by
2523 handle_single_display_spec, not just 1 or zero.
2524 (handle_single_display_spec): If the display spec is of the form
2525 `(space ...)', and specifies display in the text area, return 2
2526 rather than 1.
2527 (try_cursor_movement): Check for the need to scroll more
2528 accurately, and prefer exact match for point under bidi.
2529 Don't advance `row' beyond the last row of the window.
2530
2531 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2532 into disp_prop; all users changed.
2533
2534 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2535 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2536 for the text covered by the display property.
2537
2538 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2539
2540 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2541 Change return value to nil.
2542 (Frecord_buffer): Delete unused function.
2543
2544 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2545
2546 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2547 buffers, return left-to-right.
2548 (set_cursor_from_row): Consider candidate row a win if its glyph
2549 represents a newline and point is on that newline. Fixes cursor
2550 positioning on the newline at EOL of R2L text within L2R
2551 paragraph, and vice versa.
2552 (try_cursor_movement): Check continued rows, in addition to
2553 continuation rows. Fixes unwarranted scroll when point enters a
2554 continued line of R2L text within an L2R paragraph, or vice versa.
2555 (cursor_row_p): Consider the case of point being equal to
2556 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2557 from the end of a short line to the beginning of a continued line
2558 of R2L text within L2R paragraph.
2559 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2560 composed characters.
2561
2562 * bidi.c (bidi_check_type): Use xassert.
2563 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2564 members.
2565
2566 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2567
2568 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2569 a character.
2570
2571 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2572
2573 * nsfont.m (ns_otf_to_script): Fix typo.
2574
2575 2011-08-22 Kenichi Handa <handa@m17n.org>
2576
2577 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2578 extra slot even if the purpose is char-code-property-table.
2579
2580 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2581
2582 * xdisp.c (redisplay_window): When computing centering_position,
2583 account for the height of the header line. (Bug#8874)
2584
2585 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2586 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2587 candidate is selected by the mouse, and that candidate has a
2588 composed character under the mouse.
2589
2590 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2591 coordinates reported by pos-visible-in-window-p for a composed
2592 character in column zero.
2593
2594 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2595
2596 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2597
2598 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2599
2600 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2601 consider it a hit if to_charpos is anywhere in the range of the
2602 composed buffer positions.
2603
2604 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2605
2606 * image.c (gif_load): Don't assume that each subimage has the same
2607 dimensions as the base image. Handle disposal method that is
2608 "undefined" by the gif spec (Bug#9335).
2609
2610 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2611
2612 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2613 (Fcondition_case): Document `debug' symbol in error handler.
2614
2615 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2616
2617 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2618 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2619 from an Org mode buffer to a Speedbar frame.
2620
2621 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2622 a composition, take its buffer position from IT->cmp_it.charpos.
2623 Fixes cursor positioning at the beginning of a line that begins
2624 with a composed character.
2625
2626 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2627
2628 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2629 character bidirectional type, use STRONG_L instead. Fixes crashes
2630 in a buffer produced by `describe-categories'.
2631
2632 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2633 members before the level stack, so they would be saved and
2634 restored when copying iterator state. Fixes incorrect reordering
2635 around TABs covered by display properties.
2636
2637 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2638
2639 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2640
2641 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2642
2643 * eval.c (internal_condition_case, internal_condition_case_1)
2644 (internal_condition_case_2, internal_condition_case_n):
2645 Remove unnecessary aborts (Bug#9081).
2646
2647 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2648
2649 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2650 has no `load' handler, try opening the file locally. (Bug#9311)
2651
2652 2011-08-16 Ken Brown <kbrown@cornell.edu>
2653
2654 * gmalloc.c: Expand comment.
2655
2656 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2657
2658 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2659 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2660
2661 2011-08-16 Ken Brown <kbrown@cornell.edu>
2662
2663 Fix memory allocation problems in Cygwin build (Bug#9273).
2664
2665 * unexcw.c ( __malloc_initialized): Declare external variable.
2666 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2667
2668 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2669 New variables.
2670 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2671 dumped emacs.
2672 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2673 in the static heap.
2674 [CYGWIN] (special_realloc): New function.
2675 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2676 requests to realloc storage in the static heap.
2677
2678 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 * bidi.c (bidi_initialize): Remove unused local.
2681
2682 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2683
2684 * bidimirror.h:
2685 * biditype.h: Remove file.
2686 * makefile.w32-in ($(BLD)/bidi.$(O)):
2687 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2688
2689 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2690
2691 * chartab.c: Improve commentary for the uniprop_table API.
2692
2693 * bidi.c (bidi_paragraph_init): Support zero value of
2694 bidi_ignore_explicit_marks_for_paragraph_level.
2695 (bidi_initialize): Use uniprop_table instead of including
2696 biditype.h and bidimirror.h.
2697
2698 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2699 coordinates of the iterator when restoring from ppos_it.
2700 (Bug#9296)
2701
2702 2011-08-14 Kenichi Handa <handa@m17n.org>
2703
2704 * process.c (create_process): Call setup_process_coding_systems
2705 after the pid of the process is set to -1 (Bug#8162).
2706
2707 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2708
2709 * xdisp.c (move_it_in_display_line_to): Don't invoke
2710 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2711 ppos_it. Fixes vertical cursor motion when line beginning is
2712 covered by an image. (Bug#9296)
2713
2714 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2715
2716 * nsterm.h (ns_run_ascript): Declare.
2717 (NSAPP_DATA2_RUNASSCRIPT): Define.
2718
2719 * nsfns.m (as_script, as_result, as_status): New static variables.
2720 (ns_run_ascript): New function.
2721 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2722 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2723 the event loop. Get status from as_status (Bug#7276).
2724
2725 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2726 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2727 the event loop (Bug#7276).
2728
2729 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2730
2731 * gnutls.c (QCgnutls_bootprop_priority)
2732 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2733 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2734 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2735 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2736 (QCgnutls_bootprop_verify_hostname_error)
2737 (QCgnutls_bootprop_callbacks_verify): Rename from
2738 Qgnutls_bootprop_..., all uses changed.
2739
2740 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2741 uses changed.
2742
2743 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2744
2745 * xfaces.c (Qframe_set_background_mode): Now static.
2746 * dispextern.h (Qframe_set_background_mode): Remove decl.
2747
2748 * process.c (Fnetwork_interface_info): Declare local only if needed.
2749
2750 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2751
2752 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2753 (Fnetwork_interface_list): Allocate in increments of bytes instead
2754 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2755 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2756 sockaddr.
2757 (struct ifflag_def): notrailers is smart on OSX.
2758 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2759 Get hardware address with getifaddrs if available.
2760
2761 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2762
2763 * xdisp.c (iterate_out_of_display_property): xassert that
2764 IT->position is set to within IT->object's boundaries. Break from
2765 the loop as soon as EOB is reached; avoids infloops in redisplay
2766 when IT->position is set up wrongly due to some bug.
2767 Set IT->current to match the bidi iterator unconditionally.
2768 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2769 entry. Force push_it to save on the stack the current
2770 buffer/string position, to be restored by pop_it. Fix flags in
2771 the iterator structure wrt the object coming from a display
2772 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2773 properties. (Bug#9284)
2774
2775 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2776
2777 * fontset.c (fontset_get_font_group): Add proper type checks.
2778 (Bug#9172)
2779
2780 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2781
2782 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2783 and LC_VERSION_MIN_MACOSX.
2784 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2785 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2786
2787 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2788
2789 * xdisp.c (forward_to_next_line_start): Allow to use the
2790 no-display-properties-and-no-overlays under bidi display.
2791 Set disp_pos in the bidi iterator to avoid searches for display
2792 properties and overlays.
2793
2794 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2795
2796 * editfns.c (Fset_time_zone_rule): Document relationship with the
2797 setenv function.
2798
2799 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2800 the font entity extracted from the cache (Bug#8109).
2801
2802 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2803
2804 * composite.c (autocmp_chars): Don't reset point. That is done by
2805 restore_point_unwind (Bug#5984).
2806
2807 2011-08-07 Juri Linkov <juri@jurta.org>
2808
2809 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2810 to show the arg `TIME' instead of `TIMEVAL'.
2811
2812 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2813
2814 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2815 display property strides EOL and includes a newline, as in
2816 longlines-mode. (Bug#9254)
2817 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2818 word-wrap under bidirectional display. (Bug#9224)
2819
2820 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2821 is non-zero, even if the data buffer is NULL. Fixes a crash in
2822 vertical-motion with longlines-mode. (Bug#9254)
2823
2824 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2825
2826 * bidi.c <bidi_cache_total_alloc>: Now static.
2827 (bidi_initialize): Initialize bidi_cache_total_alloc.
2828
2829 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2830 cache. (Bug#9221)
2831
2832 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2833 amount allocated this far in `bidi_cache_total_alloc'.
2834 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2835 non-zero, only free the data buffer without restoring the cache
2836 contents. All callers changed.
2837
2838 * dispextern.h (bidi_unshelve_cache): Update prototype.
2839
2840 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2841 (move_it_in_display_line, move_it_to)
2842 (move_it_vertically_backward, move_it_by_lines): Replace the call
2843 to xfree to an equivalent call to bidi_unshelve_cache.
2844 (move_it_in_display_line_to): Fix logic of returning
2845 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2846
2847 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2848
2849 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2850 came from a string character with a `cursor' property. (Bug#9229)
2851
2852 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2853
2854 * Makefile.in (LIB_PTHREAD): New variable.
2855 (LIBES): Add LIB_PTHREAD (Bug#9216).
2856
2857 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2858 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2859
2860 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2861
2862 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2863
2864 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2865
2866 * xterm.c (x_find_topmost_parent): New function.
2867 (x_set_frame_alpha): Find topmost parent window with
2868 x_find_topmost_parent and set the property there also (bug#9181).
2869 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2870
2871 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 * callproc.c (Fcall_process): Avoid vfork clobbering
2874 the local vars buffer, coding_systems, current_dir.
2875
2876 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2877
2878 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2879
2880 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2881
2882 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2883 so that it is not optimized away.
2884
2885 * xdisp.c (compute_display_string_pos): Remove unused local.
2886
2887 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2888
2889 Fix slow cursor motion and scrolling in large buffers with
2890 selective display, like Org Mode buffers. (Bug#9218)
2891
2892 * dispextern.h (struct bidi_it): New member disp_prop_p.
2893
2894 * xdisp.c: Remove one-slot cache of display string positions.
2895 (compute_display_string_pos): Accept an additional argument
2896 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2897 for a display string or property. If found, set DISP_PROP_P
2898 non-zero.
2899
2900 * bidi.c (bidi_fetch_char): Accept an additional argument
2901 DISP_PROP_P, and pass it to compute_display_string_pos.
2902 Only handle text covered by a display string if DISP_PROP_P is returned
2903 non-zero. All callers of bidi_fetch_char changed.
2904
2905 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2906
2907 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2908
2909 2010-12-03 Don March <don@ohspite.net>
2910
2911 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2912 last character M-[char] is translated to ESC [char] (bug#7541).
2913
2914 2011-08-02 Kenichi Handa <handa@m17n.org>
2915
2916 * lisp.h (uniprop_table): Extern it.
2917
2918 * chartab.c (uniprop_table): Make it non-static.
2919
2920 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2921
2922 * xdisp.c (forward_to_next_line_start): Accept additional argument
2923 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2924 on the newline.
2925 (reseat_at_next_visible_line_start): Use the bidi iterator state
2926 returned by forward_to_next_line_start to restore the state of
2927 it->bidi_it after backing up to previous newline. (Bug#9212)
2928
2929 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2930
2931 * regex.c (re_comp): Protoize.
2932 (re_exec): Fix return type.
2933 (regexec): Fix type of `ret'. (Bug#9203)
2934
2935 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2938 This is needed if max-image-size is a floating-point number.
2939
2940 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2941
2942 * print.c (print_object): Print empty symbol as ##.
2943
2944 * lread.c (read1): Read ## as empty symbol.
2945
2946 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2947
2948 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2949 setting frame foreground color (Bug#9175).
2950 (x_set_background_color): Likewise.
2951
2952 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2953 contents (Bug#9176).
2954 (EmacsTooltip -init): Remove bezels and add shadows to
2955 tooltip windows.
2956
2957 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2958 or scroll bar (Bug#8470).
2959
2960 * nsfont.m (nsfont_open): Remove assignment to voffset and
2961 unnecessary vars hshink, expand, hd, full_height, min_height.
2962 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2963
2964 * nsterm.h (nsfont_info): Remove voffset field.
2965
2966 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2967
2968 Implement strike-through and overline on NextStep (Bug#8863).
2969
2970 * nsfont.m (nsfont_open): Use underline position provided by font,
2971 instead of hard-coded value of 2.
2972 (nsfont_draw): Call ns_draw_text_decoration instead.
2973
2974 * nsterm.h: Add declaration for ns_draw_text_decoration.
2975
2976 * nsterm.m (ns_draw_text_decoration): New function for drawing
2977 underline, overline, and strike-through.
2978 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2979 ns_draw_text_decoration. Change treatment of cursor drawing to
2980 accommodate underlining, etc.
2981
2982 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2983
2984 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2985 default.
2986
2987 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2988
2989 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2990 Without this fix, if a signal arrives just after memory fills up,
2991 'malloc' might be invoked reentrantly.
2992
2993 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2994 In other words, assume that every image size is allowed, on non-X
2995 hosts. This assumption is probably wrong, but it lets Emacs compile.
2996
2997 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2998
2999 * regex.c (re_iswctype): Convert return values to boolean.
3000
3001 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3002
3003 * xdisp.c (compute_display_string_pos): Don't use cached display
3004 string position if the buffer had its restriction changed.
3005 (Bug#9184)
3006
3007 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3008
3009 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3010
3011 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3012
3013 Integer signedness and overflow and related fixes. (Bug#9079)
3014
3015 * bidi.c: Integer size and overflow fixes.
3016 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3017 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3018 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3019 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3020 (bidi_find_other_level_edge):
3021 Use ptrdiff_t instead of EMACS_INT where either will do.
3022 This works better on 32-bit hosts configured --with-wide-int.
3023 (bidi_cache_ensure_space): Check for size-calculation overflow.
3024 Use % rather than repeated addition, for better worst-case speed.
3025 Don't set bidi_cache_size until after xrealloc returns, because it
3026 might not return.
3027 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3028 (bidi_cache_ensure_space): Also check that the bidi cache size
3029 does not exceed that of the largest Lisp string or buffer. See Eli
3030 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3031
3032 * alloc.c (__malloc_size_t): Remove.
3033 All uses replaced by size_t. See Andreas Schwab's note
3034 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3035
3036 * image.c: Improve checking for integer overflow.
3037 (check_image_size): Assume that f is nonnull, since
3038 it is always nonnull in practice. This is one less thing to
3039 worry about when checking for integer overflow later.
3040 (x_check_image_size): New function, which checks for integer
3041 overflow issues inside X.
3042 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3043 This removes the need for a memory_full check.
3044 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3045 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3046 (xbm_read_bitmap_data): Change locals back to 'int', since
3047 their values must fit in 'int'.
3048 (xpm_load_image, png_load, tiff_load):
3049 Invoke x_create_x_image_and_pixmap earlier,
3050 to avoid much needless work if the image is too large.
3051 (tiff_load): Treat overly large images as if
3052 x_create_x_image_and_pixmap failed, not as malloc failures.
3053 (gs_load): Use x_check_image_size.
3054
3055 * gtkutil.c: Omit integer casts.
3056 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3057 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3058
3059 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3060
3061 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3062 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3063 would wrongly return t on a 64-bit host.
3064
3065 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3066 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3067 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3068 and therefore cause GCC to emit a bogus diagnostic in some cases.
3069
3070 * image.c: Integer signedness and overflow and related fixes.
3071 This is not an exhaustive set of fixes, but it's time to
3072 record what I've got.
3073 (lookup_pixel_color, check_image_size): Remove redundant decls.
3074 (check_image_size): Don't assume that arbitrary EMACS_INT values
3075 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3076 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3077 (tiff_load, imagemagick_load_image):
3078 Check for overflow in size calculations.
3079 (x_create_x_image_and_pixmap): Remove unnecessary test for
3080 xmalloc returning NULL; that can't happen.
3081 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3082 (xpm_color_bucket): Use better integer hashing function.
3083 (xpm_cache_color): Don't possibly over-allocate memory.
3084 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3085 (gif_memory_source):
3086 Use ptrdiff_t, not int or size_t, to record sizes.
3087 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3088 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3089 either works, as we prefer signed integers.
3090 (tiff_read_from_memory, tiff_write_from_memory):
3091 Return tsize_t, not size_t, since that's what the TIFF API wants.
3092 (tiff_read_from_memory): Don't fail simply because the read would
3093 go past EOF; instead, return a short read.
3094 (tiff_load): Omit no-longer-needed casts.
3095 (Fimagemagick_types): Don't assume size fits into 'int'.
3096
3097 Improve hashing quality when configured --with-wide-int.
3098 * fns.c (hash_string): New function, taken from sxhash_string.
3099 Do not discard information about ASCII character case; this
3100 discarding is no longer needed.
3101 (sxhash-string): Use it. Change sig to match it. Caller changed.
3102 * lisp.h: Declare it.
3103 * lread.c (hash_string): Remove, since we now use fns.c's version.
3104 The fns.c version returns a wider integer if --with-wide-int is
3105 specified, so this should help the quality of the hashing a bit.
3106
3107 * emacs.c: Integer overflow minor fix.
3108 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3109 Define only if GNU_LINUX.
3110 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3111
3112 * dispnew.c: Integer signedness and overflow fixes.
3113 Remove unnecessary forward decls, that were a maintenance hassle.
3114 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3115 All uses changed.
3116 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3117 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3118 (prepare_desired_row, line_draw_cost):
3119 Use int, not unsigned, where either works.
3120 (save_current_matrix, restore_current_matrix):
3121 Use ptrdiff_t, not size_t, where either works.
3122 (init_display): Check for overflow more accurately, and without
3123 relying on undefined behavior.
3124
3125 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3126 Remove, replacing with the new symbols in lisp.h. All uses changed.
3127 * fileio.c (make_temp_name):
3128 * filelock.c (lock_file_1, lock_file):
3129 * xdisp.c (message_dolog):
3130 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3131 Use pMd etc. instead.
3132 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3133 replacing the pWIDE etc. symbols removed from editfns.c.
3134
3135 * keyboard.h (num_input_events): Now uintmax_t.
3136 This is (very slightly) less likely to mess up due to wraparound.
3137 All uses changed.
3138
3139 * buffer.c: Integer signedness fixes.
3140 (alloc_buffer_text, enlarge_buffer_text):
3141 Use ptrdiff_t rather than size_t when either will do, as we prefer
3142 signed integers.
3143
3144 * alloc.c: Integer signedness and overflow fixes.
3145 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3146 (__malloc_size_t): Default to size_t, not to int.
3147 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3148 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3149 Prefer ptrdiff_t to size_t when either would do, as we prefer
3150 signed integers.
3151 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3152 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3153 Now const. Initialize with values that are in range even if char
3154 is signed.
3155 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3156 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3157 These functions do the right thing with sizes > 2**32.
3158 (check_depth): Now ptrdiff_t, not int.
3159 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3160 Adjust to new way of storing sizes. Check for size overflow bugs
3161 in rest of code.
3162 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3163 slightly wrong anyway, as it missed one instance of
3164 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3165 (refill_memory_reserve): Omit needless cast to size_t.
3166 (mark_object_loop_halt): Mark as externally visible.
3167
3168 * xselect.c: Integer signedness and overflow fixes.
3169 (Fx_register_dnd_atom, x_handle_dnd_message):
3170 Use ptrdiff_t, not size_t, since we prefer signed.
3171 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3172 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3173 x_dnd_atoms_size and x_dnd_atoms_length.
3174
3175 * doprnt.c: Prefer signed to unsigned when either works.
3176 * eval.c (verror):
3177 * doprnt.c (doprnt):
3178 * lisp.h (doprnt):
3179 * xdisp.c (vmessage):
3180 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3181 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3182 prefer signed arithmetic to avoid comparison confusion.
3183 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3184 but is a bit tricky.
3185
3186 Assume freestanding C89 headers, string.h, stdlib.h.
3187 * data.c, doprnt.c, floatfns.c, print.c:
3188 Include float.h unconditionally.
3189 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3190 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3191 * regex.c: Likewise for stddef.h, string.h.
3192 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3193 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3194 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3195 (STDC_HEADERS): Remove obsolete defines.
3196 * sysdep.c: Include limits.h unconditionally.
3197
3198 Assume support for memcmp, memcpy, memmove, memset.
3199 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3200 * regex.c (memcmp, memcpy):
3201 Remove; we assume C89 now.
3202
3203 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3204 (__malloc_safe_bcopy): Remove; no longer needed.
3205
3206 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3207 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3208 well either way, and we prefer signed to unsigned.
3209
3210 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3211
3212 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3213 closes the connection while we're reading (bug#9182).
3214
3215 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3216
3217 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3218 are specified (Bug#9168).
3219
3220 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3221
3222 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3223 Found by GCC static checking and --with-wide-int on a 32-bit host.
3224
3225 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3226
3227 * xdisp.c (compute_display_string_pos): Fix logic of caching
3228 previous display string position. Initialize cached_prev_pos to
3229 -1. Fixes slow-down at the beginning of a buffer.
3230
3231 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3232
3233 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3234 for attrs[LFACE_FONTSET_INDEX].
3235
3236 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3237
3238 * xml.c (parse_region): Remove unused local
3239 that was recently introduced.
3240
3241 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3242
3243 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3244 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3245
3246 * xdisp.c (move_it_in_display_line_to): Record the best matching
3247 position for TO_CHARPOS while scanning the line, and restore it on
3248 exit if none of the characters scanned was an exact match.
3249 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3250 when exact match is impossible due to invisible text, and the
3251 lines are truncated.
3252
3253 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3254
3255 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3256 for OSX >= 10.7.
3257
3258 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3259
3260 Fix a significant slow-down of cursor motion with C-n, C-p,
3261 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3262 auto-repeat under bidi redisplay in fontified buffers.
3263 * xdisp.c (compute_stop_pos_backwards): New function.
3264 (next_element_from_buffer): Call compute_stop_pos_backwards to
3265 find a suitable prev_stop when we find ourselves before
3266 base_level_stop.
3267 (reseat): Don't look for prev_stop, as that could mean a very long
3268 run.
3269 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3270 <cached_disp_overlay_modiff>: Cache for last found display string
3271 position.
3272 (compute_display_string_pos): Return the cached position if asked
3273 about the same buffer in the same area of character positions, and
3274 the buffer wasn't changed since the time the display string
3275 position was cached.
3276
3277 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3278
3279 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3280 is an integer, which is important for empty lines. (Bug#9149)
3281
3282 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3283
3284 * frame.c (Fmodify_frame_parameters): In tty case, update the
3285 default face if necessary (Bug#4238).
3286
3287 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3288
3289 * editfns.c (Fstring_to_char): No need to explain what a character
3290 is in the docstring (Bug#6576).
3291
3292 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3293
3294 * xml.c (parse_region): Make sure we always return a tree.
3295
3296 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3297
3298 * xml.c (parse_region): If a document contains only comments,
3299 return that, too.
3300
3301 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3302
3303 * xml.c (make_dom): Return comments, too.
3304
3305 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3306
3307 Port to OpenBSD.
3308 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3309 and the surrounding thread.
3310 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3311 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3312 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3313 timer goes off.
3314 * s/openbsd.h (BROKEN_SIGIO): Define.
3315 * unexelf.c (unexec) [__OpenBSD__]:
3316 Don't update the .mdebug section of the Alpha COFF symbol table.
3317
3318 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3319
3320 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3321 (bug#8460).
3322
3323 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3326 This fixes some race conditions on the permissions of any newly
3327 created file.
3328
3329 * alloc.c (valid_pointer_p): Use pipe, not open.
3330 This fixes some permissions issues when debugging.
3331
3332 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3333 If fchown fails to set both uid and gid, try to set just gid,
3334 as that is sometimes allowed. Adjust the file's mode to eliminate
3335 setuid or setgid bits that are inappropriate if fchown fails.
3336
3337 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3338
3339 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3340 to compare Lisp_Objects.
3341 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3342 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3343 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3344
3345 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3346
3347 * lread.c (read_integer): Unread even EOF character.
3348 (read1): Likewise. Properly record start position of symbol.
3349
3350 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3351 symbol character follows.
3352
3353 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3354
3355 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3356 This works around a problem with the previous change to Fcopy_file.
3357 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3358 and without this change, GCC might complain about discarding
3359 fchown's return value.
3360
3361 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3362
3363 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3364
3365 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3366
3367 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3368
3369 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3370
3371 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3372 it's used from the C level.
3373
3374 * process.c: Use the same condition for POLL_FOR_INPUT in both
3375 keyboard.c and process.c (bug#1858).
3376
3377 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3378
3379 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3380 (Fgnutls_boot): Use it.
3381
3382 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3383
3384 * doc.c (Fsubstitute_command_keys): Revert last change.
3385
3386 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3387
3388 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3389 quotes the next character, and doesn't affect other longer
3390 sequences (bug#8935).
3391
3392 * lread.c (syms_of_lread): Clarify that is isn't only
3393 `eval-buffer' and `eval-defun' that's affected by
3394 `lexical-binding' (bug#8460).
3395
3396 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3397
3398 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3399 bidi redisplay when a line includes both an image and is truncated.
3400
3401 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 Fix minor problems found by static checking.
3404 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3405 (elsz): Now a signed constant, not a size_t var. We prefer signed
3406 types to unsigned, to avoid integer comparison confusion. Without
3407 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3408 "cannot optimize loop, the loop counter may overflow", a symptom
3409 of the confusion.
3410 * indent.c (Fvertical_motion): Mark locals as initialized.
3411 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3412
3413 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3414
3415 * search.c (Fre_search_backward): Mention `case-fold-search' in
3416 all the re_search_* functions (bug#8138).
3417
3418 * keyboard.c (Fopen_dribble_file): Document when the file is
3419 closed (bug#8056).
3420
3421 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3422
3423 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3424 bidi_cache_idx.
3425
3426 Support bidi reordering of display and overlay strings.
3427 * xdisp.c (compute_display_string_pos)
3428 (compute_display_string_end): Accept additional argument STRING.
3429 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3430 (reseat_to_string): Initialize bidi_it->string.s and
3431 bidi_it->string.schars.
3432 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3433 NULL (avoids a crash in bidi_paragraph_init).
3434 Initialize itb.string.lstring.
3435 (init_iterator): Call bidi_init_it only of a valid
3436 buffer position was specified. Initialize paragraph_embedding to
3437 L2R.
3438 (reseat_to_string): Initialize the bidi iterator.
3439 (display_string): If we need to ignore text properties of
3440 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3441 original value of -1 will not work with bidi.)
3442 (compute_display_string_pos): First arg is now struct
3443 `text_pos *'; all callers changed. Support display properties on
3444 Lisp strings.
3445 (compute_display_string_end): Support display properties on Lisp
3446 strings.
3447 (init_iterator, reseat_1, reseat_to_string): Initialize the
3448 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3449 when iterating on a string not from display properties).
3450 (compute_display_string_pos, compute_display_string_end):
3451 Fix calculation of the object to scan. Fixes an error when using
3452 arrow keys.
3453 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3454 base_level_stop; instead, set base_level_stop to BEGV.
3455 Fixes crashes in vertical-motion.
3456 (next_element_from_buffer): Improve commentary for when
3457 the iterator is before prev_stop.
3458 (init_iterator): Initialize bidi_p from the default value of
3459 bidi-display-reordering, not from buffer-local value. Use the
3460 buffer-local value only if initializing for buffer iteration.
3461 (handle_invisible_prop): Support invisible properties on strings
3462 that are being bidi-reordered.
3463 (set_iterator_to_next): Support bidi reordering of C strings and
3464 Lisp strings.
3465 (next_element_from_string): Support bidi reordering of Lisp
3466 strings.
3467 (handle_stop_backwards): Support Lisp strings as well.
3468 (display_string): Support display of R2L glyph rows.
3469 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3470 (init_iterator): Don't initialize it->bidi_p for strings
3471 here.
3472 (reseat_to_string): Initialize it->bidi_p for strings here.
3473 (next_element_from_string, next_element_from_c_string)
3474 (next_element_from_buffer): Add xassert's for correspondence
3475 between IT's object being iterated and it->bidi_it.string
3476 structure.
3477 (face_before_or_after_it_pos): Support bidi iteration.
3478 (next_element_from_c_string): Handle the case of the first string
3479 character that is not the first one in the visual order.
3480 (get_visually_first_element): New function, refactored from common
3481 parts of next_element_from_buffer, next_element_from_string, and
3482 next_element_from_c_string.
3483 (tool_bar_lines_needed, redisplay_tool_bar)
3484 (display_menu_bar): Force left-to-right direction. Add a FIXME
3485 comment for making that be controlled by a user option.
3486 (push_it, pop_it): Save and restore the state of the
3487 bidi iterator. Save and restore the bidi_p flag.
3488 (pop_it): Iterate out of display property for string iteration as
3489 well.
3490 (iterate_out_of_display_property): Support iteration over strings.
3491 (handle_single_display_spec): Set up it->bidi_it for iteration
3492 over a display string, and call bidi_init_it.
3493 (handle_single_display_spec, next_overlay_string)
3494 (get_overlay_strings_1, push_display_prop): Set up the bidi
3495 iterator for displaying display or overlay strings.
3496 (forward_to_next_line_start): Don't use the shortcut if
3497 bidi-iterating.
3498 (back_to_previous_visible_line_start): If handle_display_prop
3499 pushed the iterator stack, restore the internal state of the bidi
3500 iterator by calling bidi_pop_it same number of times.
3501 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3502 and we are bidi-iterating, don't decrement the iterator position;
3503 instead, set the first_elt flag in the bidi iterator, to produce
3504 the same effect.
3505 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3506 (push_display_prop): xassert that we are iterating a buffer.
3507 (push_it, pop_it): Save and restore paragraph_embedding member.
3508 (handle_single_display_spec, next_overlay_string)
3509 (get_overlay_strings_1, reseat_1, reseat_to_string)
3510 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3511 correctly. Don't assume unibyte strings are not bidi-reordered.
3512 (compute_display_string_pos)
3513 (compute_display_string_end): Fix handling the case of C string.
3514 (push_it, pop_it): Save and restore from_disp_prop_p.
3515 (handle_single_display_spec, push_display_prop): Set the
3516 from_disp_prop_p flag.
3517 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3518 (pop_it): Call iterate_out_of_display_property only if we are
3519 popping after iteration over a string that came from a display
3520 property. Fix a typo in popping stretch info. Add an assertion
3521 for verifying that the iterator position is in sync with the bidi
3522 iterator.
3523 (handle_single_display_spec, get_overlay_strings_1)
3524 (push_display_prop): Fix initialization of paragraph direction for
3525 string when that of the parent object is not yet determined.
3526 (reseat_1): Call bidi_init_it to resync the bidi
3527 iterator with IT's position. (Bug#7616)
3528 (find_row_edges): If ROW->start.pos gives position
3529 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3530 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3531 Reset the from_disp_prop_p flag.
3532 (SAVE_IT, RESTORE_IT): New macros.
3533 (pos_visible_p, face_before_or_after_it_pos)
3534 (back_to_previous_visible_line_start)
3535 (move_it_in_display_line_to, move_it_in_display_line)
3536 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3537 (try_scrolling, redisplay_window, display_line): Use them when
3538 saving a temporary copy of the iterator and restoring it back.
3539 (back_to_previous_visible_line_start, reseat_1)
3540 (init_iterator): Empty the bidi cache "stack".
3541 (move_it_in_display_line_to): If iterator ended up at
3542 EOL, but we never saw any buffer positions smaller than
3543 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3544 motion in bidi-reordered lines.
3545 (move_it_in_display_line_to): Record prev_method and prev_pos
3546 immediately before the call to set_iterator_to_next. Fixes cursor
3547 motion in bidi-reordered lines with stretch glyphs and strings
3548 displayed in margins. (Bug#8133) (Bug#8867)
3549 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3550 TO_CHARPOS.
3551 (pos_visible_p): Support positions in bidi-reordered lines.
3552 Save and restore bidi cache.
3553
3554 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3555 (bidi_paragraph_info): Delete unused struct.
3556 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3557 (bidi_cache_start): New variable.
3558 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3559 to zero.
3560 (bidi_cache_fetch_state, bidi_cache_search)
3561 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3562 (bidi_cache_find, bidi_peek_at_next_level)
3563 (bidi_level_of_next_char, bidi_find_other_level_edge)
3564 (bidi_move_to_visually_next): Compare cache index with
3565 bidi_cache_start rather than with zero.
3566 (bidi_fetch_char): Accept new argument STRING; all callers
3567 changed. Support iteration over a string. Support strings with
3568 display properties. Support unibyte strings. Fix the type of
3569 `len' according to what STRING_CHAR_AND_LENGTH expects.
3570 (bidi_paragraph_init, bidi_resolve_explicit_1)
3571 (bidi_resolve_explicit, bidi_resolve_weak)
3572 (bidi_level_of_next_char, bidi_move_to_visually_next):
3573 Support iteration over a string.
3574 (bidi_set_sor_type, bidi_resolve_explicit_1)
3575 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3576 can now be zero (for strings); special values 0 and -1 were
3577 changed to -1 and -2, respectively.
3578 (bidi_char_at_pos): New function.
3579 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3580 Call it instead of FETCH_MULTIBYTE_CHAR.
3581 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3582 initialized to valid values.
3583 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3584 values.
3585 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3586 the test for valid cached positions. Fix the logic for looking up
3587 the sentinel state in the cache. GCPRO the Lisp string we are
3588 iterating.
3589 (bidi_push_it, bidi_pop_it): New functions.
3590 (bidi_initialize): Initialize the bidi cache start stack pointer.
3591 (bidi_cache_ensure_space): New function, refactored from part of
3592 bidi_cache_iterator_state. Don't assume the required size is just
3593 one BIDI_CACHE_CHUNK away.
3594 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3595 (bidi_count_bytes, bidi_char_at_pos): New functions.
3596 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3597 always valid if bidi_cache_idx is valid.
3598 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3599 is valid if it's going to be used.
3600 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3601 (bidi_cache_fetch_state, bidi_cache_search)
3602 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3603 (bidi_cache_iterator_state, bidi_cache_find)
3604 (bidi_find_other_level_edge, bidi_cache_start_stack):
3605 All variables related to cache indices are now EMACS_INT.
3606
3607 * dispextern.h (struct bidi_string_data): New structure.
3608 (struct bidi_it): New member `string'. Make flag members be 1-bit
3609 fields, and put them last in the struct.
3610 (compute_display_string_pos, compute_display_string_end):
3611 Update prototypes.
3612 (bidi_push_it, bidi_pop_it): Add prototypes.
3613 (struct iterator_stack_entry): New members bidi_p,
3614 paragraph_embedding, and from_disp_prop_p.
3615 (struct it): Member bidi_p is now a bit field 1 bit wide.
3616 (bidi_shelve_cache, bidi_unshelve_cache):
3617 Declare prototypes.
3618
3619 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3620 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3621 and vector-like objects.
3622
3623 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3624 cache around display iteration.
3625
3626 * window.c (Fwindow_end, window_scroll_pixel_based)
3627 (displayed_window_lines, Frecenter): Save and restore the bidi
3628 cache around display iteration.
3629
3630 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3631
3632 * editfns.c (Fdelete_region): Clarify the use of the named
3633 parameters (bug#6788).
3634
3635 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3636
3637 * indent.c (Fvertical_motion): Set and restore w->pointm when
3638 saving and restoring the window's buffer (Bug#9006).
3639
3640 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3641
3642 * editfns.c (Fstring_to_char): Clarify just what is returned
3643 (bug#6576). Text by Eli Zaretskii.
3644
3645 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3646
3647 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3648
3649 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3650
3651 * buffer.c (mmap_find): Fix a typo.
3652
3653 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3654
3655 Fix execution of x selection hooks.
3656 * xselect.c (Qx_lost_selection_functions)
3657 (Qx_sent_selection_functions): New vars.
3658 (syms_of_xselect): DEFSYM them.
3659 (x_handle_selection_request): Pass Qx_sent_selection_functions
3660 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3661 (x_handle_selection_clear,x_clear_frame_selections):
3662 Pass Qx_lost_selection_functions rather than
3663 Vx_lost_selection_functions to Frun_hook_with_args.
3664
3665 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3666
3667 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3668 The old code sometimes used this field without initializing it.
3669
3670 * alloc.c (gc_sweep): Don't read past end of array.
3671 In theory, the old code could also have corrupted Emacs internals,
3672 though it'd be very unlikely.
3673
3674 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3675
3676 * character.c (Fcharacterp): Don't advertise optional ignored
3677 argument. (Bug#4026)
3678
3679 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3680
3681 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3682 key" (bug#4257).
3683
3684 * window.c (Fset_window_start): Doc fix (bug#4199).
3685 (Fset_window_hscroll): Ditto.
3686
3687 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3688
3689 Fix minor new problems caught by GCC 4.6.1.
3690 * term.c (init_tty): Remove unused local.
3691 * xsettings.c (store_monospaced_changed): Define this function only
3692 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3693 not used otherwise.
3694
3695 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3696
3697 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3698
3699 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3700
3701 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3702 are the mini-buffer and the echo area (bug#3320).
3703
3704 * term.c (init_tty): Remove support for supdup, c10 and perq
3705 terminals, which are no longer supported (bug#1482).
3706
3707 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3708
3709 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3710
3711 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3712
3713 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3714 for non-popups (Bug#3642).
3715
3716 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3717
3718 * alloc.c (reset_malloc_hooks): Protoize.
3719 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3720 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3721 * cm.c (losecursor): Likewise.
3722 * data.c (fmod): Likewise.
3723 * dispnew.c (swap_glyphs_in_rows): Likewise.
3724 * emacs.c (memory_warning_signal): Likewise.
3725 * floatfns.c (float_error): Likewise.
3726 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3727 (otf_open, font_otf_capability, generate_otf_features)
3728 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3729 Likewise.
3730 * image.c (pbm_read_file): Likewise.
3731 * indent.c (string_display_width): Likewise.
3732 * intervals.c (check_for_interval, search_for_interval)
3733 (inc_interval_count, count_intervals, root_interval)
3734 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3735 * lread.c (defalias): Likewise.
3736 * ralloc.c (r_alloc_check): Likewise.
3737 * regex.c (set_image_of_range_1, set_image_of_range)
3738 (regex_grow_registers): Likewise.
3739 * sysdep.c (strerror): Likewise.
3740 * termcap.c (valid_filename_p, tprint, main): Likewise.
3741 * tparam.c (main): Likewise.
3742 * unexhp9k800.c (run_time_remap, save_data_space)
3743 (update_file_ptrs, read_header, write_header, calculate_checksum)
3744 (copy_file, copy_rest, display_header): Likewise.
3745 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3746 Likewise.
3747 * xdisp.c (check_it): Likewise.
3748 * xfaces.c (register_color, unregister_color, unregister_colors):
3749 Likewise.
3750 * xfns.c (print_fontset_result): Likewise.
3751 * xrdb.c (member, fatal, main): Likewise.
3752
3753 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3754
3755 Fix minor problems found by static checking (Bug#9031).
3756 * chartab.c (char_table_set_range, map_sub_char_table):
3757 Remove unused locals.
3758 (uniprop_table): Now static.
3759 * composite.c (_work_char): Remove unused static var.
3760
3761 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3762
3763 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3764
3765 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3766
3767 * gtkutil.c (qttip_cb): Remove code without function.
3768
3769 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3770
3771 * w32.c (pthread_sigmask): New stub.
3772
3773 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3774
3775 Use pthread_sigmask, not sigprocmask (Bug#9010).
3776 sigprocmask is portable only for single-threaded applications, and
3777 Emacs can be multi-threaded when it uses GTK.
3778 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3779 (LIBES): Use it.
3780 * callproc.c (Fcall_process):
3781 * process.c (create_process):
3782 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3783 Use pthread_sigmask, not sigprocmask.
3784
3785 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3786
3787 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3788 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3789 wrong (Bug#8591).
3790
3791 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3792
3793 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3794 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3795 (xg_hide_tooltip): Fix comment.
3796
3797 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3798 in registerServicesMenuSendTypes.
3799 (validRequestorForSendType): Don't check ns_return_types.
3800
3801 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3802 ns_return_type.
3803
3804 2011-07-08 Jason Rumney <jasonr@gnu.org>
3805
3806 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3807 SH_SHOW for hidden windows (Bug#5482).
3808
3809 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3810 frame struct members of non-existent frames (Bug#6284).
3811
3812 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3813
3814 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3815 variable firstTime not needed on OSX >= 10.6.
3816 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3817 >= 10.5. Use setKnobProportion, setDoubleValue.
3818
3819 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3820 (MAC_OS_X_VERSION_10_5): Define if not defined.
3821 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3822 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3823 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3824
3825 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3826 cString and lossyCString on OSX >= 10.4
3827
3828 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3829 sizeToFit on OSX >= 10.2.
3830
3831 * nsimage.m (allocInitFromFile): Don't use deprecated method
3832 bestRepresentationForDevice on OSX >= 10.6.
3833
3834 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3835 to avoid warning.
3836
3837 * emacs.c: Declare unexec_init_emacs_zone.
3838
3839 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3840
3841 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3842
3843 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3844 on svcsMenu (Bug#8842).
3845
3846 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3847 ns_return_types.
3848 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3849
3850 * nsterm.m (QUTF8_STRING): Declare.
3851 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3852 (validRequestorForSendType): Return type is (id).
3853 Change indexOfObjectIdenticalTo to indexOfObject.
3854 Check if we have local selection before returning self (Bug#8842).
3855 (writeSelectionToPasteboard): Put local selection into paste board
3856 if we have a local selection (Bug#8842).
3857 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3858
3859 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3860 (ns_get_local_selection): Declare.
3861
3862 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3863
3864 * keymap.c (describe_map_tree): Don't insert a double newline at
3865 the end of the buffer (bug#1169) and return whether we inserted
3866 something.
3867
3868 * callint.c (Fcall_interactively): Change "reading args" to
3869 "providing args" to try to clarify what it does (bug#1010).
3870
3871 2011-07-07 Kenichi Handa <handa@m17n.org>
3872
3873 * composite.c (composition_compute_stop_pos): Ignore a static
3874 composition starting before CHARPOS (Bug#8915).
3875
3876 * xdisp.c (handle_composition_prop): Likewise.
3877
3878 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3879
3880 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3881 (Bug#9015)
3882
3883 2011-07-07 Kenichi Handa <handa@m17n.org>
3884
3885 * character.h (unicode_category_t): New enum type.
3886
3887 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3888 (Qchar_code_property_table): New variable.
3889 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3890 (UNIPROP_COMPRESSED_FORM_P): New macros.
3891 (char_table_ascii): Uncompress the compressed values.
3892 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3893 Uncompress the compressed values.
3894 (sub_char_table_ref_and_range): Likewise.
3895 (char_table_ref_and_range): Uncompress the compressed values.
3896 (sub_char_table_set): New arg is_uniprop. Callers changed.
3897 Uncompress the compressed values.
3898 (sub_char_table_set_range): Args changed. Callers changed.
3899 (char_table_set_range): Adjuted for the above change.
3900 (map_sub_char_table): Delete args default_val and parent. Add arg
3901 top. Give decoded values to a Lisp function.
3902 (map_char_table): Adjust for the above change. Give decoded
3903 values to a Lisp function. Gcpro more variables.
3904 (uniprop_table_uncompress)
3905 (uniprop_decode_value_run_length): New functions.
3906 (uniprop_decoder, uniprop_decoder_count): New variables.
3907 (uniprop_get_decoder, uniprop_encode_value_character)
3908 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3909 New functions.
3910 (uniprop_encoder, uniprop_encoder_count): New variables.
3911 (uniprop_get_encoder, uniprop_table)
3912 (Funicode_property_table_internal, Fget_unicode_property_internal)
3913 (Fput_unicode_property_internal): New functions.
3914 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3915 Sunicode_property_table_internal, Sget_unicode_property_internal,
3916 and Sput_unicode_property_internal. Defvar_lisp
3917 char-code-property-alist.
3918
3919 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3920 Vunicode_category_table.
3921
3922 * font.c (font_range): Adjust for the change of
3923 Vunicode_category_table.
3924
3925 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3926
3927 * m/iris4d.h: Remove file, move contents ...
3928 * s/irix6-5.h: ... here.
3929
3930 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3931
3932 Remove unportable assumption about struct layout (Bug#8884).
3933 * alloc.c (mark_buffer):
3934 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3935 (clone_per_buffer_values): Don't assume that
3936 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3937 This isn't true in general, and it's particularly not true
3938 if Emacs is configured with --with-wide-int.
3939 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3940 New macros, used in the buffer.c change.
3941
3942 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3943
3944 * xsettings.c: Use both GConf and GSettings if both are available.
3945 (store_config_changed_event): Add comment.
3946 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3947 (store_tool_bar_style_changed): New functions.
3948 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3949 (struct xsettings): Move font inside HAVE_XFT.
3950 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3951 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3952 Move inside HAVE_XFT.
3953 (something_changed_gsettingsCB): Rename from something_changedCB.
3954 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3955 also.
3956 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3957 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3958 (something_changed_gconfCB): Rename from something_changedCB.
3959 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3960 (parse_settings): Move check for font inside HAVE_XFT.
3961 (read_settings, apply_xft_settings): Add comment.
3962 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3963 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3964 call store_font_name_changed.
3965 (xft_settings_event): Add comment.
3966 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3967 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3968 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3969 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3970 (xsettings_initialize): Call init_gsettings last.
3971 (xsettings_get_system_font, xsettings_get_system_normal_font):
3972 Add comment.
3973
3974 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3975
3976 Random fixes. E.g., (random) never returned negative values.
3977 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3978 subseconds part to the entropy, as that's a bit more random.
3979 Prefer signed to unsigned, since the signedness doesn't matter and
3980 in general we prefer signed. When given a limit, use a
3981 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3982 latter isn't right if USE_2_TAGS_FOR_INTS.
3983 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3984 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3985
3986 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3987
3988 * textprop.c (text_property_stickiness):
3989 Obey Vtext_property_default_nonsticky.
3990 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3991 * w32fns.c (syms_of_w32fns):
3992 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3993
3994 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3995
3996 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3997 This is more efficient than Ffile_directory_p and avoids a minor race.
3998
3999 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4000
4001 * buffer.c (Foverlay_put): Say what the return value is
4002 (bug#7835).
4003
4004 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4005 is a directory before asking whether to use the file name
4006 (bug#7564).
4007 (barf_or_query_if_file_exists): Make the "File is a directory"
4008 error be more correct.
4009
4010 * fns.c (Frequire): Remove the mention of the .gz files, since
4011 that's installation-specific, but keep the mention of
4012 `get-load-suffixes'.
4013
4014 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4015
4016 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4017 Report string overflow if the output is too long.
4018
4019 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4020
4021 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4022 (syms_of_gnutls): Remove duplicate DEFSYM for
4023 Qgnutls_bootprop_verify_hostname_error, an error for
4024 Qgnutls_bootprop_verify_error (which is no longer used).
4025
4026 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4027 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4028 Also (re)move comments that are misplaced or no longer relevant.
4029
4030 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4031
4032 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4033
4034 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4035
4036 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4037 and background color parameters if they have been changed.
4038
4039 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4040
4041 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4042
4043 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4044
4045 * xsettings.c (SYSTEM_FONT): Define only when used.
4046 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4047
4048 * keymap.c (access_keymap_1): Now static.
4049
4050 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4051
4052 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4053 leave any prefix arg for the up event (Bug#1586).
4054
4055 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4056
4057 * lread.c (syms_of_lread): Mention single symbols defined by
4058 `defvar' or `defconst' (bug#7154).
4059
4060 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4061 (Frequire): Mention get-load-suffixes.
4062
4063 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4064
4065 * window.h (window): Remove clone_number slot.
4066 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4067 Remove.
4068 (make_parent_window, make_window, saved_window)
4069 (Fset_window_configuration, save_window_save): Don't deal with
4070 clone numbers.
4071 * buffer.c (Qclone_number): Remove declaration.
4072 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4073
4074 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4075
4076 Add multiple inheritance to keymaps.
4077 * keymap.c (Fmake_composed_keymap): New function.
4078 (Fset_keymap_parent): Simplify.
4079 (fix_submap_inheritance): Remove.
4080 (access_keymap_1): New function extracted from access_keymap to handle
4081 embedded parents and handle lists of maps.
4082 (access_keymap): Use it.
4083 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4084 (Fcopy_keymap): Handle embedded parents.
4085 (Fcommand_remapping, define_as_prefix): Simplify.
4086 (Fkey_binding): Simplify.
4087 (syms_of_keymap): Move minibuffer-local-completion-map,
4088 minibuffer-local-filename-completion-map,
4089 minibuffer-local-must-match-map, and
4090 minibuffer-local-filename-must-match-map to Elisp.
4091 (syms_of_keymap): Defsubr make-composed-keymap.
4092 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4093 (parse_menu_item): Trivial simplification.
4094
4095 2011-07-01 Glenn Morris <rgm@gnu.org>
4096
4097 * Makefile.in (SETTINGS_LIBS): Fix typo.
4098
4099 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4100
4101 * coding.c (Fencode_coding_string): Record the last coding system
4102 used, as the function doc string says (bug#8738).
4103
4104 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4105
4106 * xsettings.c (store_monospaced_changed): Take new font as arg and
4107 check for change against current_mono_font.
4108 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4109 (emacs_settings_constructor, emacs_settings_get_property)
4110 (emacs_settings_set_property, emacs_settings_class_init)
4111 (emacs_settings_init, gsettings_obj): Remove.
4112 (something_changedCB): New function for HAVE_GSETTINGS.
4113 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4114 with value as argument.
4115 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4116 g_settings_new (Bug#8967). Do not create gsettings_obj.
4117 Remove calls to g_settings_bind. Connect something_changedCB to
4118 "changed".
4119
4120 * xgselect.c: Add defined (HAVE_GSETTINGS).
4121 (xgselect_initialize): Ditto.
4122
4123 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4124 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4125 xg_select.
4126
4127 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4128
4129 * eval.c (struct backtrace): Simplify and port the data structure.
4130 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4131 signed bit field, as this assumption is not portable and it makes
4132 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4133 "char debug_on_exit : 1" as this is not portable either; instead,
4134 use the portable "unsigned int debug_on_exit : 1". Remove unused
4135 member evalargs. Remove obsolete comments about cc bombing out.
4136
4137 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4138
4139 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4140 Let HAVE_GSETTINGS override HAVE_GCONF.
4141 (store_monospaced_changed): New function.
4142 (EMACS_SETTINGS): A new type derived from GObject to handle
4143 GSettings notifications.
4144 (emacs_settings_constructor, emacs_settings_get_property)
4145 (emacs_settings_set_property, emacs_settings_class_init):
4146 New functions.
4147 (gsettings_client, gsettings_obj): New variables.
4148 (GSETTINGS_SCHEMA): New define.
4149 (something_changedCB): Call store_monospaced_changed.
4150 (init_gsettings): New function.
4151 (xsettings_initialize): Call init_gsettings.
4152 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4153 to NULL.
4154
4155 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4156 GCONF_CFLAGS/LIBS.
4157
4158 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4159
4160 * window.c (resize_root_window, grow_mini_window)
4161 (shrink_mini_window): Rename Qresize_root_window to
4162 Qwindow_resize_root_window and Qresize_root_window_vertically to
4163 Qwindow_resize_root_window_vertically.
4164
4165 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4166
4167 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4168
4169 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4170
4171 * makefile.w32-in: Redesign dependencies so they reflect more
4172 clearly which files are directly included by each source file,
4173 and not through other includes.
4174
4175 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4176
4177 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4178 (sort_overlays, overlay_strings): When an overlay's clone number
4179 matches the window's clone number process the overlay even if
4180 the overlay's window property doesn't match the current window.
4181
4182 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4183 (Fwindow_hchild): Rename to Fwindow_left_child.
4184 (Fwindow_next): Rename to Fwindow_next_sibling.
4185 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4186 (resize_window_check): Rename to window_resize_check.
4187 (resize_window_apply): Rename to window_resize_apply.
4188 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4189 (Fdelete_other_windows_internal, resize_frame_windows)
4190 (Fsplit_window_internal, Fdelete_window_internal)
4191 (grow_mini_window, shrink_mini_window)
4192 (Fresize_mini_window_internal): Fix callers accordingly.
4193
4194 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4195
4196 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4197 (emacs_fixed_set_min_size): Remove.
4198 (emacs_fixed_new): Take frame as argument.
4199
4200 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4201 (_EmacsFixedPrivate): Remove minwidth/height.
4202 Add struct frame *f.
4203 (emacs_fixed_init): Initialize priv->f.
4204 (get_parent_class, emacs_fixed_set_min_size): Remove.
4205 (emacs_fixed_new): Set priv->f to argument.
4206 (emacs_fixed_get_preferred_width)
4207 (emacs_fixed_get_preferred_height): Use min_width/height from
4208 frames size_hint to set minimum and natural (Bug#8919).
4209 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4210 and use min_width/height from frames size_hint to set
4211 min_width/height (Bug#8919).
4212
4213 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4214 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4215 Fix indentation.
4216
4217 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4218
4219 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4220 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4221 called at ZV.
4222
4223 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4224
4225 * process.c (wait_reading_process_output): Bypass select if
4226 waiting for a cell while ignoring keyboard input, and input is
4227 pending. Suggested by Jan Djärv (Bug#8869).
4228
4229 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4230
4231 Use gnulib's dup2 module instead of rolling our own.
4232 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4233
4234 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4235
4236 * dispnew.c (scrolling_window): Before scrolling, turn off a
4237 mouse-highlight in the window being scrolled.
4238
4239 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4240
4241 Move DEFSYM to lisp.h and use everywhere.
4242
4243 * character.h (DEFSYM): Move declaration...
4244 * lisp.h (DEFSYM): ...here.
4245
4246 * gnutls.c:
4247 * minibuf.c:
4248 * w32menu.c:
4249 * w32proc.c:
4250 * w32select.c: Don't include character.h.
4251
4252 * alloc.c (syms_of_alloc):
4253 * buffer.c (syms_of_buffer):
4254 * bytecode.c (syms_of_bytecode):
4255 * callint.c (syms_of_callint):
4256 * casefiddle.c (syms_of_casefiddle):
4257 * casetab.c (init_casetab_once):
4258 * category.c (init_category_once, syms_of_category):
4259 * ccl.c (syms_of_ccl):
4260 * cmds.c (syms_of_cmds):
4261 * composite.c (syms_of_composite):
4262 * dbusbind.c (syms_of_dbusbind):
4263 * dired.c (syms_of_dired):
4264 * dispnew.c (syms_of_display):
4265 * doc.c (syms_of_doc):
4266 * editfns.c (syms_of_editfns):
4267 * emacs.c (syms_of_emacs):
4268 * eval.c (syms_of_eval):
4269 * fileio.c (syms_of_fileio):
4270 * fns.c (syms_of_fns):
4271 * frame.c (syms_of_frame):
4272 * fringe.c (syms_of_fringe):
4273 * insdel.c (syms_of_insdel):
4274 * keymap.c (syms_of_keymap):
4275 * lread.c (init_obarray, syms_of_lread):
4276 * macros.c (syms_of_macros):
4277 * msdos.c (syms_of_msdos):
4278 * print.c (syms_of_print):
4279 * process.c (syms_of_process):
4280 * search.c (syms_of_search):
4281 * sound.c (syms_of_sound):
4282 * syntax.c (init_syntax_once, syms_of_syntax):
4283 * terminal.c (syms_of_terminal):
4284 * textprop.c (syms_of_textprop):
4285 * undo.c (syms_of_undo):
4286 * w32.c (globals_of_w32):
4287 * window.c (syms_of_window):
4288 * xdisp.c (syms_of_xdisp):
4289 * xfaces.c (syms_of_xfaces):
4290 * xfns.c (syms_of_xfns):
4291 * xmenu.c (syms_of_xmenu):
4292 * xsettings.c (syms_of_xsettings):
4293 * xterm.c (syms_of_xterm): Use DEFSYM.
4294
4295 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4296
4297 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4298
4299 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4300
4301 Integer and buffer overflow fixes (Bug#8873).
4302
4303 * print.c (printchar, strout): Check for string overflow.
4304 (PRINTPREPARE, printchar, strout):
4305 Don't set size unless allocation succeeds.
4306
4307 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4308 for sizes. Check for string overflow more accurately.
4309 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4310
4311 * macros.c: Integer and buffer overflow fixes.
4312 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4313 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4314 Use ptrdiff_t, not int, for sizes.
4315 Don't increment bufsize until after realloc succeeds.
4316 Check for size-calculation overflow.
4317 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4318
4319 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4320
4321 * lread.c: Integer overflow fixes.
4322 (read_integer): Radix is now EMACS_INT, not int,
4323 to improve quality of diagnostics for out-of-range radices.
4324 Calculate buffer size correctly for out-of-range radices.
4325 (read1): Check for integer overflow in radices, and in
4326 read-circle numbers.
4327 (read_escape): Avoid int overflow.
4328 (Fload, openp, read_buffer_size, read1)
4329 (substitute_object_recurse, read_vector, read_list, map_obarray):
4330 Use ptrdiff_t, not int, for sizes.
4331 (read1): Use EMACS_INT, not int, for sizes.
4332 Check for size overflow.
4333
4334 * image.c (cache_image): Check for size arithmetic overflow.
4335
4336 * lread.c: Integer overflow issues.
4337 (saved_doc_string_size, saved_doc_string_length)
4338 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4339 Now ptrdiff_t, not int.
4340 (read1): Don't assume doc string length fits in int. Check for
4341 out-of-range doc string lengths.
4342 (read_list): Don't assume file position fits in int.
4343 (read_escape): Check for hex character overflow.
4344
4345 2011-06-22 Leo Liu <sdl.web@gmail.com>
4346
4347 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4348 Move to minibuffer.el.
4349
4350 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4351
4352 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4353 The following patches are for when GLYPH_DEBUG && !XASSERT.
4354 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4355 * dispnew.c (flush_stdout):
4356 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4357 Mark as externally visible.
4358 * dispnew.c (check_window_matrix_pointers): Now static.
4359 * dispnew.c (window_to_frame_vpos):
4360 * xfns.c (unwind_create_frame):
4361 * xterm.c (x_check_font): Remove unused local.
4362 * scroll.c (CHECK_BOUNDS):
4363 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4364 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4365 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4366 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4367 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4368 Now static.
4369 (debug_method_add): Use va_list and vsprintf rather than relying
4370 on undefined behavior with wrong number of arguments.
4371 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4372 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4373 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4374 since we're not interested in debugging glyphs with old libraries.
4375 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4376 GCC 4.6.0's static checking.
4377
4378 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4379
4380 Integer overflow and signedness fixes (Bug#8873).
4381 A few related buffer overrun fixes, too.
4382
4383 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4384
4385 * dispextern.h (struct face.stipple):
4386 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4387 (x_bitmap_mask, x_allocate_bitmap_record)
4388 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4389 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4390 (x_create_bitmap_from_xpm_data):
4391 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4392 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4393 (.bitmaps_last):
4394 * xfaces.c (load_pixmap):
4395 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4396 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4397 (.bitmaps_last, struct x_output.icon_bitmap):
4398 Use ptrdiff_t, not int, for bitmap indexes.
4399 (x_allocate_bitmap_record): Check for size overflow.
4400 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4401
4402 Use ptrdiff_t, not int, for overlay counts.
4403 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4404 * editfns.c (overlays_around, get_pos_property):
4405 * textprop.c (get_char_property_and_overlay):
4406 * xdisp.c (next_overlay_change, note_mouse_highlight):
4407 * xfaces.c (face_at_buffer_position):
4408 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4409 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4410 (Fnext_overlay_change, Fprevious_overlay_change)
4411 (mouse_face_overlay_overlaps, Foverlays_in):
4412 Use ptrdiff_t, not int, for sizes.
4413 (overlays_at, overlays_in): Check for size-calculation overflow.
4414
4415 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4416
4417 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4418 (x_session_initialize): Do not assume string length fits in int.
4419
4420 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4421 This is unlikely, but can occur if DPI is outlandish.
4422
4423 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4424 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4425
4426 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4427 * xrdb.c (magic_file_p, search_magic_path):
4428 Omit last arg SUFFIX; it was always 0. All callers changed.
4429 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4430
4431 * xfont.c (xfont_match): Avoid need for strlen.
4432
4433 * xfns.c: Don't assume strlen fits in int.
4434 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4435
4436 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4437 not unsigned long, as we prefer signed integers. All callers changed.
4438 Detect integer overflow in repeat count.
4439 (message_dolog): Don't assume print length fits in 39 bytes.
4440 (display_mode_element): Don't assume strlen fits in int.
4441
4442 * termcap.c: Don't assume sizes fit in int and never overflow.
4443 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4444 (gobble_line): Check for size-calculation overflow.
4445
4446 * minibuf.c (Fread_buffer):
4447 * lread.c (intern, intern_c_string):
4448 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4449 Don't assume string length fits in int.
4450
4451 * keyboard.c (parse_tool_bar_item):
4452 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4453
4454 * font.c: Don't assume string length fits in int.
4455 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4456 Use ptrdiff_t, not int.
4457 (font_intern_prop): Don't assume string length fits in int.
4458 Don't assume integer property fits in fixnum.
4459 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4460
4461 * filelock.c: Fix some buffer overrun and integer overflow issues.
4462 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4463 Reformulate so as not to need the command string.
4464 Invoke gzip -cd rather than gunzip, as it's more portable.
4465 (lock_info_type, lock_file_1, lock_file):
4466 Don't assume pid_t and time_t fit in unsigned long.
4467 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4468 (current_lock_owner): Prefer signed type for sizes.
4469 Use memcpy, not strncpy, where memcpy is what is really wanted.
4470 Don't assume (via atoi) that time_t and pid_t fit in int.
4471 Check for time_t and/or pid_t out of range, e.g., via a network share.
4472 Don't alloca where an auto var works fine.
4473
4474 * fileio.c: Fix some integer overflow issues.
4475 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4476 Don't assume string length fits in int.
4477 (directory_file_name): Don't assume string length fits in long.
4478 (make_temp_name): Don't assume pid fits in int, or that its print
4479 length is less than 20.
4480
4481 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4482
4483 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4484
4485 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4486
4487 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4488 We prefer signed integers, even for size calculations.
4489
4490 * emacs.c: Don't assume string length fits in 'int'.
4491 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4492 (main): Don't invoke strlen when not needed.
4493
4494 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4495 (XD_DEBUG_MESSAGE): Don't waste a byte.
4496
4497 * callproc.c (getenv_internal_1, getenv_internal)
4498 (Fgetenv_internal):
4499 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4500
4501 * lread.c (invalid_syntax): Omit length argument.
4502 All uses changed. This doesn't fix a bug, but it simplifies the
4503 code away from its former Hollerith-constant appearance, and it's
4504 one less 'int' to worry about when looking at integer-overflow issues.
4505 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4506
4507 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4508 This didn't break anything, but it didn't help either.
4509 It's confusing to put a bogus integer in a place where the actual
4510 value does not matter.
4511 (LIST_END_P): Remove unused macro and its bogus comment.
4512 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4513
4514 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4515 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4516 implementation.
4517 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4518 We prefer signed types, and the value cannot exceed the EMACS_INT
4519 range anyway (because otherwise the length would not be representable).
4520 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4521 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4522 This avoids a GCC warning when WIDE_EMACS_INT.
4523
4524 * indent.c (sane_tab_width): New function.
4525 (current_column, scan_for_column, Findent_to, position_indentation)
4526 (compute_motion): Use it. This is just for clarity.
4527 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4528
4529 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4530
4531 * lisp.h (lint_assume): New macro.
4532 * composite.c (composition_gstring_put_cache):
4533 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4534
4535 * editfns.c, insdel.c:
4536 Omit unnecessary forward decls, to simplify future changes.
4537
4538 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4539
4540 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4541
4542 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4543 Use much-faster test for byte-length change.
4544 Don't assume string byte-length fits in 'int'.
4545 Check that character arg fits in 'int'.
4546 (mapcar1): Declare byte as byte, for clarity.
4547
4548 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4549
4550 * fns.c (concat): Catch string overflow earlier.
4551 Do not rely on integer wraparound.
4552
4553 * dispextern.h (struct it.overlay_strings_charpos)
4554 (struct it.selective): Now EMACS_INT, not int.
4555 * xdisp.c (forward_to_next_line_start)
4556 (back_to_previous_visible_line_start)
4557 (reseat_at_next_visible_line_start, next_element_from_buffer):
4558 Don't arbitrarily truncate the value of 'selective' to int.
4559
4560 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4561
4562 * composite.c: Don't truncate sizes to 'int'.
4563 (composition_gstring_p, composition_reseat_it)
4564 (composition_adjust_point): Use EMACS_INT, not int.
4565 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4566 not EMACS_UINT, for indexes.
4567
4568 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4569
4570 * buffer.c: Include <verify.h>.
4571 (struct sortvec.priority, struct sortstr.priority):
4572 Now EMACS_INT, not int.
4573 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4574 (struct sortstr.size, record_overlay_string)
4575 (struct sortstrlist.size, struct sortlist.used):
4576 Don't truncate size to int.
4577 (record_overlay_string): Check for size-calculation overflow.
4578 (init_buffer_once): Check at compile-time, not run-time.
4579
4580 2011-06-22 Jim Meyering <meyering@redhat.com>
4581
4582 Don't leak an XBM-image-sized buffer
4583 * image.c (xbm_load): Free the image buffer after using it.
4584
4585 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4586
4587 Port to Sun C.
4588 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4589 that Sun C diagnosed.
4590 * fns.c (secure_hash): Fix pointer signedness issue.
4591 * intervals.c (static_offset_intervals): New function.
4592 (offset_intervals): Use it.
4593
4594 2011-06-21 Leo Liu <sdl.web@gmail.com>
4595
4596 * deps.mk (fns.o):
4597 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4598 sha512.h.
4599
4600 * fns.c (secure_hash): Rename from crypto_hash_function and change
4601 the first arg to accept symbols.
4602 (Fsecure_hash): New primitive.
4603 (syms_of_fns): New symbols.
4604
4605 2011-06-20 Deniz Dogan <deniz@dogan.se>
4606
4607 * process.c (Fset_process_buffer): Clarify return value in
4608 docstring.
4609
4610 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4611
4612 * dispnew.c (add_window_display_history): Use BVAR.
4613
4614 * xdisp.c (debug_method_add): Use BVAR.
4615 (check_window_end, dump_glyph_matrix, dump_glyph)
4616 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4617
4618 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4619 Likewise.
4620
4621 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4622 check till after the cache is created in init_frame_faces.
4623
4624 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4625
4626 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4627
4628 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4629
4630 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4631 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4632 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4633
4634 Improve buffer-overflow checking (Bug#8873).
4635 * fileio.c (Finsert_file_contents):
4636 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4637 Remove the old (too-loose) buffer overflow checks.
4638 They weren't needed, since make_gap checks for buffer overflow.
4639 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4640 The old code merely checked for Emacs fixnum overflow, and relied
4641 on undefined (wraparound) behavior. The new code avoids undefined
4642 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4643
4644 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4645 Tune. Don't use wider integers than needed. Don't use alloca.
4646 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4647
4648 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4649
4650 * insdel.c, lisp.h (buffer_overflow): New function.
4651 (insert_from_buffer_1, replace_range, replace_range_2):
4652 * insdel.c (make_gap_larger):
4653 * editfns.c (Finsert_char):
4654 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4655
4656 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4657
4658 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4659
4660 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4661
4662 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4663 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4664
4665 * fileio.c: Don't assume EMACS_INT fits in off_t.
4666 (emacs_lseek): New static function.
4667 (Finsert_file_contents, Fwrite_region): Use it.
4668 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4669
4670 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4671
4672 * fns.c: Don't overflow int when computing a list length.
4673 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4674 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4675 truncation on 64-bit hosts. Check for QUIT every
4676 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4677 faster and is responsive enough.
4678 (Flength): Report an error instead of overflowing an integer.
4679 (Fsafe_length): Return a float if the value is not representable
4680 as a fixnum. This shouldn't happen except in contrived situations.
4681 (Fnthcdr, Fsort): Don't assume list length fits in int.
4682 (Fcopy_sequence): Don't assume vector length fits in int.
4683
4684 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4685 (header_size, word_size): New constants.
4686 (allocate_vectorlike): Don't check size overflow here.
4687 (allocate_vector): Check it here instead, since this is the only
4688 caller of allocate_vectorlike that could cause overflow.
4689 Check that the new vector's length is representable as a fixnum.
4690
4691 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4692 The previous code was bogus. For example, next_almost_prime (32)
4693 returned 39, which is undesirable as it is a multiple of 3; and
4694 next_almost_prime (24) returned 25, which is a multiple of 5 so
4695 why was the code bothering to check for multiples of 7?
4696
4697 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4698
4699 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4700
4701 Variadic C functions now count arguments with ptrdiff_t.
4702 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4703 Back then I didn't know that the Emacs coding style prefers signed int.
4704 Also, in the meantime I found a few more instances where arguments
4705 were being counted with int, which may truncate counts on 64-bit
4706 machines, or EMACS_INT, which may be unnecessarily wide.
4707 * lisp.h (struct Lisp_Subr.function.aMANY)
4708 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4709 Arg counts are now ptrdiff_t, not size_t.
4710 All variadic functions and their callers changed accordingly.
4711 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4712 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4713 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4714 * callint.c (Fcall_interactively): Check arg count for overflow,
4715 to avoid potential buffer overrun. Use signed char, not 'int',
4716 for 'varies' array, so that we needn't bother to check its size
4717 calculation for overflow.
4718 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4719 * eval.c (apply_lambda):
4720 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4721 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4722 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4723
4724 * callint.c (Fcall_interactively): Don't use index var as event count.
4725
4726 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4727 * mem-limits.h (SIZE): Remove; no longer used.
4728
4729 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4730
4731 Remove unnecessary casts.
4732 * xterm.c (x_term_init):
4733 * xfns.c (x_set_border_pixel):
4734 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4735 These aren't needed now that we assume ANSI C.
4736
4737 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4738 It's more likely to cause problems (due to unsigned overflow)
4739 than to cure them.
4740
4741 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4742
4743 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4744
4745 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4746
4747 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4748
4749 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4750
4751 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4752
4753 GLYPH_CODE_FACE returns EMACS_INT, not int.
4754 * dispextern.h (merge_faces):
4755 * xfaces.c (merge_faces):
4756 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4757 Don't assume EMACS_INT fits in int.
4758
4759 * character.h (CHAR_VALID_P): Remove unused parameter.
4760 * fontset.c, lisp.h, xdisp.c: All uses changed.
4761
4762 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4763
4764 * fns.c (concat): Minor tuning based on overflow analysis.
4765 This doesn't fix any bugs. Use int to hold character, instead
4766 of constantly refetching from Emacs object. Use XFASTINT, not
4767 XINT, for value known to be a character. Don't bother comparing
4768 a single byte to 0400, as it's always less.
4769
4770 * floatfns.c (Fexpt):
4771 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4772
4773 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4774 for characters.
4775
4776 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4777
4778 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4779 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4780 incorrectly succeed when S was a string, because 4294967386 was
4781 truncated before it was used.
4782
4783 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4784 Otherwise, an out-of-range integer could cause undefined behavior
4785 on a 64-bit host.
4786
4787 * composite.c: Use int, not EMACS_INT, for characters.
4788 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4789 EMACS_INT, for values that are known to be in character range.
4790 This doesn't fix any bugs but is the usual style inside Emacs and
4791 may generate better code on 32-bit machines.
4792
4793 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4794 This is for reasons similar to the recent CHAR_STRING fix.
4795 * charset.c (Fencode_char): Check that character arg is actually
4796 a character. Pass an int to ENCODE_CHAR.
4797 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4798 wider than 'int', as a compile-time check to prevent future regressions
4799 in this area.
4800
4801 * character.c (char_string): Remove unnecessary casts.
4802
4803 Make sure a 64-bit char is never passed to CHAR_STRING.
4804 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4805 by silently ignoring the top 32 bits, allowing some values
4806 that were far too large to be valid characters.
4807 * character.h: Include <verify.h>.
4808 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4809 arguments are no wider than unsigned, as a compile-time check
4810 to prevent future regressions in this area.
4811 * data.c (Faset):
4812 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4813 (Fsubst_char_in_region):
4814 * fns.c (concat):
4815 * xdisp.c (decode_mode_spec_coding):
4816 Adjust to CHAR_STRING's new requirement.
4817 * editfns.c (Finsert_char, Fsubst_char_in_region):
4818 * fns.c (concat): Check that character args are actually
4819 characters. Without this test, these functions did the wrong
4820 thing with wildly out-of-range values on 64-bit hosts.
4821
4822 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4823 These casts should not be needed on 32-bit hosts, either.
4824 * keyboard.c (read_char):
4825 * lread.c (Fload): Remove casts to unsigned.
4826
4827 * lisp.h (UNSIGNED_CMP): New macro.
4828 This fixes comparison bugs on 64-bit hosts.
4829 (ASCII_CHAR_P): Use it.
4830 * casefiddle.c (casify_object):
4831 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4832 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4833 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4834 * dispextern.h (FACE_FROM_ID):
4835 * keyboard.c (read_char): Use UNSIGNED_CMP.
4836
4837 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4838 not to EMACS_INT, to avoid GCC warning.
4839
4840 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4841
4842 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4843 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4844 isn't needed on 32-bit machines.
4845
4846 * buffer.c (Fgenerate_new_buffer_name):
4847 Use EMACS_INT for count, not int.
4848 (advance_to_char_boundary): Return EMACS_INT, not int.
4849
4850 * data.c (Qcompiled_function): Now static.
4851
4852 * window.c (window_body_lines): Now static.
4853
4854 * image.c (gif_load): Rename local to avoid shadowing.
4855
4856 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4857 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4858 * alloc.c (make_save_value): Integer argument is now of type
4859 ptrdiff_t, not int.
4860 (mark_object): Use ptrdiff_t, not int.
4861 * lisp.h (pD): New macro.
4862 * print.c (print_object): Use it.
4863
4864 * alloc.c: Use EMACS_INT, not int, to count objects.
4865 (total_conses, total_markers, total_symbols, total_vector_size)
4866 (total_free_conses, total_free_markers, total_free_symbols)
4867 (total_free_floats, total_floats, total_free_intervals)
4868 (total_intervals, total_strings, total_free_strings):
4869 Now EMACS_INT, not int. All uses changed.
4870 (Fgarbage_collect): Compute overall total using a double, so that
4871 integer overflow is less likely to be a problem. Check for overflow
4872 when converting back to an integer.
4873 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4874 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4875 These were 'int' variables that could overflow on 64-bit hosts;
4876 they were never used, so remove them instead of repairing them.
4877 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4878 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4879 Previously, this ceilinged at INT_MAX, but that doesn't work on
4880 64-bit machines.
4881 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4882
4883 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4884 (allocate_vectorlike): Check for ptrdiff_t overflow.
4885 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4886 when a (possibly-narrower) signed value would do just as well.
4887 We prefer using signed arithmetic, to avoid comparison confusion.
4888
4889 * alloc.c: Catch some string size overflows that we were missing.
4890 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4891 for convenience in STRING_BYTES_MAX.
4892 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4893 The definition here is exact; the one in lisp.h was approximate.
4894 (allocate_string_data): Check for string overflow. This catches
4895 some instances we weren't catching before. Also, it catches
4896 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4897 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4898 and ptrdiff_t and EMACS_INT are both 64 bits.
4899
4900 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4901 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4902 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4903
4904 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4905
4906 * alloc.c (Fmake_string): Check for out-of-range init.
4907
4908 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4909
4910 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4911
4912 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4913
4914 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4915 xg_get_default_scrollbar_width.
4916
4917 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4918 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4919 (style_changed_cb): Call update_theme_scrollbar_width and call
4920 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4921 all frames (Bug#8505).
4922 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4923 Call gtk_window_set_resizable if HAVE_GTK3.
4924 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4925 and height if HAVE_GTK3 (Bug#8505).
4926 (scroll_bar_width_for_theme): New variable.
4927 (update_theme_scrollbar_width): New function.
4928 (xg_get_default_scrollbar_width): Move code to
4929 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4930 (xg_initialize): Call update_theme_scrollbar_width.
4931
4932 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4933
4934 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4935
4936 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4937
4938 * frame.c (make_frame): Call other_buffer_safely instead of
4939 other_buffer.
4940
4941 * window.c (temp_output_buffer_show): Call display_buffer with
4942 second argument Vtemp_buffer_show_specifiers and reset latter
4943 immediately after the call.
4944 (Vtemp_buffer_show_specifiers): New variable.
4945 (auto_window_vscroll_p, next_screen_context_lines)
4946 (Vscroll_preserve_screen_position): Remove leading asterisks from
4947 doc-strings.
4948
4949 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4950
4951 Fix minor problems found by GCC 4.6.0 static checking.
4952 * buffer.c (Qclone_number): Remove for now, as it's unused.
4953 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4954 (record_buffer): Remove unused local.
4955 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4956 (set_frame_buffer_list): Remove; unused.
4957 * frame.h (other_visible_frames): Remove decl.
4958 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4959 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4960 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4961 if HAVE_GPM.
4962 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4963 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4964 Define only if HAVE_GPM.
4965 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4966 (update_hints_inhibit): Remove; never set. All uses removed.
4967 * widgetprv.h (emacsFrameClassRec): Remove decl.
4968 * window.c (delete_deletable_window): Now returns void, since it
4969 wasn't returning anything.
4970 (compare_window_configurations): Remove unused locals.
4971 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4972 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4973 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4974 the same widths as pointers. This follows up on the 2011-05-06 patch.
4975 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4976 * xterm.h: Likewise.
4977 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4978
4979 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4980
4981 * makefile.w32-in: Update dependencies.
4982 (LISP_H): Add lib/intprops.h.
4983
4984 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4985
4986 * image.c (gif_load): Add animation frame delay to the metadata.
4987 (syms_of_image): Use DEFSYM. New symbol `delay'.
4988
4989 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4990
4991 * window.c (delete_deletable_window): Re-add.
4992 (Fset_window_configuration): Rewrite to handle dead buffers and
4993 consequently deletable windows.
4994 (window_tree, Fwindow_tree): Remove. Supply functionality in
4995 window.el.
4996 (compare_window_configurations): Simplify code.
4997
4998 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4999
5000 * image.c (imagemagick_load_image): Fix type mismatch.
5001 (Fimagemagick_types): Likewise.
5002
5003 * window.h (replace_buffer_in_windows): Declare.
5004
5005 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5006
5007 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5008 Qclone_number. Remove external declaration of Qdelete_window.
5009 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5010 code.
5011 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5012 Run Qbuffer_list_update_hook if allowed.
5013 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5014 buffer list implementation.
5015 (other_buffer_safely): New function.
5016 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5017 calls to replace_buffer_in_windows and
5018 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5019 if allowed.
5020 (record_buffer): Inhibit quitting and rewrite using quittable
5021 functions. Run Qbuffer_list_update_hook if allowed.
5022 (Frecord_buffer, Funrecord_buffer): New functions.
5023 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5024 Move switch-to-buffer to window.el.
5025 (bury-buffer): Move to window.el.
5026 (Vbuffer_list_update_hook): New variable.
5027
5028 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5029 section.
5030
5031 * window.h (resize_frame_windows): Move up in code.
5032 (Fwindow_frame): Remove EXFUN.
5033 (replace_buffer_in_all_windows): Remove prototype.
5034 (replace_buffer_in_windows_safely): Add prototype.
5035
5036 * window.c: Declare Qdelete_window static again. Move down
5037 declaration of select_count.
5038 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5039 (Fother_window): Move to window.el.
5040 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5041 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5042 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5043 window.el.
5044 (replace_buffer_in_windows): Implement by calling
5045 Qreplace_buffer_in_windows.
5046 (replace_buffer_in_all_windows): Remove with some functionality
5047 moved into replace_buffer_in_windows_safely.
5048 (replace_buffer_in_windows_safely): New function.
5049 (select_window_norecord, select_frame_norecord): Move in front
5050 of run_window_configuration_change_hook. Remove now obsolete
5051 declarations.
5052 (Fset_window_buffer): Rewrite doc-string.
5053 Call Qrecord_window_buffer.
5054 (keys_of_window): Move binding for other-window to window.el.
5055
5056 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5057
5058 * dispextern.h (struct image): Replace data member, whose int_val
5059 and ptr_val fields were not used by anything, with a single
5060 lisp_val object.
5061
5062 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5063 (gif_clear_image, gif_load, imagemagick_load_image)
5064 (gs_clear_image, gs_load): Callers changed.
5065
5066 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5067
5068 * buffer.h: Include <time.h>, for time_t.
5069 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5070
5071 Fix minor problems found by static checking.
5072
5073 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5074
5075 Make identifiers static if they are not used in other modules.
5076 * data.c (Qcompiled_function, Qframe, Qvector):
5077 * image.c (QimageMagick, Qsvg):
5078 * minibuf.c (Qmetadata):
5079 * window.c (resize_window_check, resize_root_window): Now static.
5080 * window.h (resize_window_check, resize_root_window): Remove decls.
5081
5082 * window.c (window_deletion_count, delete_deletable_window):
5083 Remove; unused.
5084 (window_body_lines): Now static.
5085 (Fdelete_other_windows_internal): Mark vars as initialized.
5086 Make sure 'resize_failed' is initialized.
5087 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5088 (resize_window_apply): Remove unused local.
5089 * window.h (delete_deletable_window): Remove decl.
5090
5091 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5092 (imagemagick_load_image): Fix pointer signedness problem by changing
5093 last arg from unsigned char * to char *. All uses changed.
5094 Also, fix a local for similar reasons.
5095 Remove unused locals. Remove locals to avoid shadowing.
5096 (fn_rsvg_handle_free): Remove; unused.
5097 (svg_load, svg_load_image): Fix pointer signedness problem.
5098 (imagemagick_load_image): Don't use garbage pointer image_wand.
5099
5100 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5101
5102 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5103
5104 * image.c (gif_load): Fix omitted cast error introduced by
5105 2011-06-06 change.
5106
5107 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5108
5109 * window.h (resize_proportionally, orig_total_lines)
5110 (orig_top_line): Remove from window structure.
5111 (set_window_height, set_window_width, change_window_heights)
5112 (Fdelete_window): Remove prototypes.
5113 (resize_frame_windows): Remove duplicate declaration.
5114
5115 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5116
5117 * window.h (resize_frame_windows, resize_window_check)
5118 (delete_deletable_window, resize_root_window)
5119 (resize_frame_windows): Declare prototypes.
5120
5121 * window.c (resize_window_apply): Make definition be "static" to
5122 match the prototype.
5123
5124 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5125
5126 * window.c: Remove declarations of Qwindow_size_fixed,
5127 window_min_size_1, window_min_size_2, window_min_size,
5128 size_window, window_fixed_size_p, enlarge_window, delete_window.
5129 Remove static from declaration of Qdelete_window, it's
5130 temporarily needed by Fbury_buffer.
5131 (replace_window): Don't assign orig_top_line and
5132 orig_total_lines.
5133 (Fdelete_window, delete_window): Remove. Window deletion is
5134 handled by window.el.
5135 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5136 Replace Fdelete_window calls with calls to Qdelete_window.
5137 (Fdelete_other_windows): Remove. Deleting other windows is
5138 handled by window.el.
5139 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5140 handled in window.el.
5141 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5142 Window minimum sizes are handled in window.el.
5143 (shrink_windows, size_window, set_window_height)
5144 (set_window_width, change_window_heights, window_height)
5145 (window_width, CURBEG, CURSIZE, enlarge_window)
5146 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5147 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5148 handled in window.el.
5149 (make_dummy_parent): Rename to make_parent_window and give it a
5150 second argument horflag.
5151 (make_window): Don't set resize_proportionally any more.
5152 (Fsplit_window): Remove. Windows are split in window.el.
5153 (save_restore_action, save_restore_orig_size)
5154 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5155 Resize mini windows in window.el.
5156 (grow_mini_window, shrink_mini_window): Implement by calling
5157 Qresize_root_window_vertically, resize_window_check and
5158 resize_window_apply.
5159 (saved_window, Fset_window_configuration, save_window_save):
5160 Do not handle orig_top_line, orig_total_lines, and
5161 resize_proportionally.
5162 (window_min_height, window_min_width): Move to window.el.
5163 (keys_of_window): Move bindings for delete-other-windows,
5164 split-window, delete-window and enlarge-window to window.el.
5165
5166 * buffer.c: Temporarily extern Qdelete_window.
5167 (Fbury_buffer): Temporarily call Qdelete_window instead of
5168 Fdelete_window (Fbury_buffer will move to window.el soon).
5169
5170 * frame.c (set_menu_bar_lines_1): Remove code handling
5171 orig_top_line and orig_total_lines.
5172
5173 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5174 set_window_height but set heights directly.
5175 (change_frame_size_1): Use resize_frame_windows.
5176
5177 * xdisp.c (init_xdisp): Don't use set_window_height but set
5178 heights directly.
5179
5180 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5181 Use resize_frame_windows instead of change_window_heights and run
5182 run_window_configuration_change_hook.
5183
5184 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5185 instead of change_window_heights and run
5186 run_window_configuration_change_hook.
5187
5188 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5189
5190 * window.c (replace_window): Rename second argument REPLACEMENT to
5191 NEW. New third argument SETFLAG. Rewrite.
5192 (delete_window, make_dummy_parent): Call replace_window with
5193 third argument 1.
5194 (window_list_1): Move down in code.
5195 (run_window_configuration_change_hook): Move set_buffer part
5196 before select_frame_norecord part in order to unwind correctly.
5197 Rename count1 to count.
5198 (recombine_windows, delete_deletable_window, resize_root_window)
5199 (Fdelete_other_windows_internal)
5200 (Frun_window_configuration_change_hook, make_parent_window)
5201 (resize_window_check, resize_window_apply, Fresize_window_apply)
5202 (resize_frame_windows, Fsplit_window_internal)
5203 (Fdelete_window_internal, Fresize_mini_window_internal):
5204 New functions.
5205 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5206
5207 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5208
5209 * window.h (window): Add some new members to window structure -
5210 normal_lines, normal_cols, new_total, new_normal, clone_number,
5211 splits, nest, prev_buffers, next_buffers.
5212 (WINDOW_TOTAL_SIZE): Move here from window.c.
5213 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5214
5215 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5216 Remove.
5217 (make_dummy_parent): Set new members of windows structure.
5218 (make_window): Move down in code. Handle new members of window
5219 structure.
5220 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5221 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5222 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5223 (Fset_window_prev_buffers, Fwindow_next_buffers)
5224 (Fset_window_next_buffers, Fset_window_clone_number):
5225 New functions.
5226 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5227 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5228 Doc-string fixes.
5229 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5230 Argument WINDOW can be now internal window too.
5231 (Fwindow_use_time): Move up in code.
5232 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5233 Rewrite doc-string.
5234 (Fset_window_configuration, saved_window)
5235 (Fcurrent_window_configuration, save_window_save): Handle new
5236 members of window structure.
5237 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5238 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5239 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5240 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5241 Qget_mru_window, Qresize_root_window,
5242 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5243 Qauto_buffer_name; staticpro them.
5244
5245 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5246
5247 * window.c (Fwindow_total_size, Fwindow_left_column)
5248 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5249 (Fwindow_list_1): New functions.
5250 (window_box_text_cols): Replace with window_body_cols.
5251 (Fwindow_width, Fscroll_left, Fscroll_right):
5252 Use window_body_cols instead of window_box_text_cols.
5253 (delete_window, Fset_window_configuration):
5254 Call delete_all_subwindows with window as argument.
5255 (delete_all_subwindows): Take a window as argument and not a
5256 structure. Rewrite.
5257 (window_loop): Remove handling of GET_LRU_WINDOW and
5258 GET_LARGEST_WINDOW.
5259 (Fget_lru_window, Fget_largest_window): Move to window.el.
5260
5261 * window.h: Extern window_body_cols instead of
5262 window_box_text_cols. delete_all_subwindows now takes a
5263 Lisp_Object as argument.
5264
5265 * indent.c (compute_motion, Fcompute_motion):
5266 Use window_body_cols instead of window_box_text_cols.
5267
5268 * frame.c (delete_frame): Call delete_all_subwindows with root
5269 window as argument.
5270
5271 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5272
5273 * fns.c (Fputhash): Document return value.
5274
5275 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5276
5277 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5278
5279 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5280
5281 Cons<->int and similar integer overflow fixes (Bug#8794).
5282
5283 Check for overflow when converting integer to cons and back.
5284 * charset.c (Fdefine_charset_internal, Fdecode_char):
5285 Use cons_to_unsigned to catch overflow.
5286 (Fencode_char): Use INTEGER_TO_CONS.
5287 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5288 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5289 * data.c (long_to_cons, cons_to_long): Remove.
5290 (cons_to_unsigned, cons_to_signed): New functions.
5291 These signal an error for invalid or out-of-range values.
5292 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5293 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5294 * font.c (Ffont_variation_glyphs):
5295 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5296 * lisp.h: Include <intprops.h>.
5297 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5298 (cons_to_signed, cons_to_unsigned): New decls.
5299 (long_to_cons, cons_to_long): Remove decls.
5300 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5301 (Fprimitive_undo): Use CONS_TO_INTEGER.
5302 * xfns.c (Fx_window_property): Likewise.
5303 * xselect.c: Include <limits.h>.
5304 (x_own_selection, selection_data_to_lisp_data):
5305 Use INTEGER_TO_CONS.
5306 (x_handle_selection_request, x_handle_selection_clear)
5307 (x_get_foreign_selection, Fx_disown_selection_internal)
5308 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5309 (lisp_data_to_selection_data): Use cons_to_unsigned.
5310 (x_fill_property_data): Use cons_to_signed.
5311 Report values out of range.
5312
5313 Check for buffer and string overflow more precisely.
5314 * buffer.h (BUF_BYTES_MAX): New macro.
5315 * lisp.h (STRING_BYTES_MAX): New macro.
5316 * alloc.c (Fmake_string):
5317 * character.c (string_escape_byte8):
5318 * coding.c (coding_alloc_by_realloc):
5319 * doprnt.c (doprnt):
5320 * editfns.c (Fformat):
5321 * eval.c (verror):
5322 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5323 since they may not be the same number.
5324 * editfns.c (Finsert_char):
5325 * fileio.c (Finsert_file_contents):
5326 Likewise for BUF_BYTES_MAX.
5327
5328 * image.c: Use ptrdiff_t, not int, for sizes.
5329 (slurp_file): Switch from int to ptrdiff_t.
5330 All uses changed.
5331 (slurp_file): Check that file size fits in both size_t (for
5332 malloc) and ptrdiff_t (for sanity and safety).
5333
5334 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5335 if b->modtime has its maximal value.
5336
5337 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5338
5339 Don't assume time_t can fit into int.
5340 * buffer.h (struct buffer.modtime): Now time_t, not int.
5341 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5342 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5343
5344 Minor fixes for signed vs unsigned integers.
5345 * character.h (MAYBE_UNIFY_CHAR):
5346 * charset.c (maybe_unify_char):
5347 * keyboard.c (read_char, reorder_modifiers):
5348 XINT -> XFASTINT, since the integer must be nonnegative.
5349 * ftfont.c (ftfont_spec_pattern):
5350 * keymap.c (access_keymap, silly_event_symbol_error):
5351 XUINT -> XFASTINT, since the integer must be nonnegative.
5352 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5353 since it makes no difference and we prefer signed.
5354 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5355 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5356 nonnegative.
5357
5358 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5359
5360 * window.h (Fwindow_frame): Declare.
5361
5362 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5363
5364 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5365 (SPARE_MEMORY): Always define.
5366 (LARGE_REQUEST): Remove.
5367 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5368
5369 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5370
5371 * lisp.h: Move EXFUNS for Fframe_root_window,
5372 Fframe_first_window and Fset_frame_selected_window to window.h.
5373
5374 * window.h: Move EXFUNS for Fframe_root_window,
5375 Fframe_first_window and Fset_frame_selected_window here from
5376 lisp.h.
5377
5378 * frame.c (Fwindow_frame, Fframe_first_window)
5379 (Fframe_root_window, Fframe_selected_window)
5380 (Fset_frame_selected_window): Move to window.c.
5381 (Factive_minibuffer_window): Move to minibuf.c.
5382 (Fother_visible_frames_p): New function.
5383
5384 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5385
5386 * window.c (decode_window, decode_any_window): Move up in code.
5387 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5388 (inhibit_frame_unsplittable): Remove unused variable.
5389 (Fwindow_buffer): Move up and rewrite doc-string.
5390 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5391 (Fwindow_prev): New functions.
5392 (Fwindow_frame): Move here from frame.c. Accept any window as
5393 argument.
5394 (Fframe_root_window, Fframe_first_window)
5395 (Fframe_selected_window): Move here from frame.c. Accept frame
5396 or arbitrary window as argument. Update doc-strings.
5397 (Fminibuffer_window): Move up in code.
5398 (Fwindow_minibuffer_p): Move up in code and simplify.
5399 (Fset_frame_selected_window): Move here from frame.c.
5400 Marginal rewrite.
5401 (Fselected_window, select_window, Fselect_window): Move up in
5402 code. Minor doc-string fixes.
5403
5404 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5405
5406 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5407 Do not assume that spare memory exists; that assumption is valid
5408 only if SYSTEM_MALLOC.
5409 (LARGE_REQUEST): New macro, so that the issue of large requests
5410 is separated from the issue of spare memory.
5411
5412 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5413
5414 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5415 format. (Bug#8806)
5416
5417 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5418
5419 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5420 before statements.
5421
5422 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5423
5424 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5425
5426 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5427
5428 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5429 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5430
5431 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5432
5433 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5434
5435 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5436
5437 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5438 (x_clipboard_manager_save): Add return value.
5439 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5440 New error handlers.
5441 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5442 Obey Vx_select_enable_clipboard_manager. Catch errors in
5443 x_clipboard_manager_save (Bug#8779).
5444 (Vx_select_enable_clipboard_manager): New variable.
5445 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5446
5447 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5448
5449 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5450
5451 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5452
5453 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5454 in the current matrix if keep_current_p is non-zero.
5455
5456 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5457
5458 * bidi.c (bidi_level_of_next_char): Fix last change.
5459
5460 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5461
5462 Support bidi reordering of text covered by display properties.
5463
5464 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5465 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5466 (bidi_cache_search, bidi_cache_iterator_state)
5467 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5468 (bidi_level_of_next_char, bidi_move_to_visually_next):
5469 Support character positions inside a run of characters covered by a
5470 display string.
5471 (bidi_paragraph_init, bidi_resolve_explicit_1)
5472 (bidi_level_of_next_char): Call bidi_fetch_char and
5473 bidi_fetch_char_advance instead of FETCH_CHAR and
5474 FETCH_CHAR_ADVANCE.
5475 (bidi_init_it): Initialize new members.
5476 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5477 definitions.
5478 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5479 instead of using explicit *_CHAR codes.
5480 (bidi_resolve_explicit, bidi_resolve_weak):
5481 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5482 bidirectional text is supported only in multibyte buffers.
5483 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5484 it to initialize the frame_window_p member of struct bidi_it.
5485 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5486 (bidi_resolve_explicit, bidi_resolve_weak)
5487 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5488 bidi_it->nchars is non-positive.
5489 (bidi_level_of_next_char): Don't try to lookup the cache for the
5490 next/previous character if nothing is cached there yet, or if we
5491 were just reseat()'ed to a new position.
5492
5493 * xdisp.c (set_cursor_from_row): Set start and stop points
5494 according to the row's direction when priming the loop that looks
5495 for the glyph on which to display cursor.
5496 (single_display_spec_intangible_p): Function deleted.
5497 (display_prop_intangible_p): Reimplement to call
5498 handle_display_spec instead of single_display_spec_intangible_p.
5499 Accept 3 additional arguments needed by handle_display_spec.
5500 This fixes incorrect cursor motion across display property with complex
5501 values: lists, `(when COND...)' forms, etc.
5502 (single_display_spec_string_p): Support property values that are
5503 lists with the argument STRING its top-level element.
5504 (display_prop_string_p): Fix the condition for processing a
5505 property that is a list to be consistent with handle_display_spec.
5506 (handle_display_spec): New function, refactored from the
5507 last portion of handle_display_prop.
5508 (compute_display_string_pos): Accept additional argument
5509 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5510 value of a `display' property is a "replacing spec".
5511 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5512 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5513 the display property, but just return a value indicating whether
5514 the display property will replace the characters it covers.
5515 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5516 frame_window_p members of struct bidi_it.
5517 (compute_display_string_pos, compute_display_string_end):
5518 New functions.
5519 (push_it): Accept second argument POSITION, where pop_it should
5520 jump to continue iteration.
5521 (reseat_1): Initialize bidi_it.disp_pos.
5522
5523 * keyboard.c (adjust_point_for_property): Adjust the call to
5524 display_prop_intangible_p to its new signature.
5525
5526 * dispextern.h (struct bidi_it): New member frame_window_p.
5527 (bidi_init_it): Update prototypes.
5528 (display_prop_intangible_p): Update prototype.
5529 (compute_display_string_pos, compute_display_string_end):
5530 Declare prototypes.
5531 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5532 EMACS_INT.
5533
5534 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5535
5536 Malloc failure behavior now depends on size of allocation.
5537 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5538 * lisp.h: Change signatures accordingly.
5539 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5540 All callers changed. (Bug#8762)
5541
5542 * gnutls.c: Use Emacs's memory allocators.
5543 Without this change, the gnutls library would invoke malloc etc.
5544 directly, which causes problems on non-SYNC_INPUT hosts, and which
5545 runs afoul of improving memory_full behavior. (Bug#8761)
5546 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5547 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5548 xfree instead of the default malloc, realloc, free.
5549 (Fgnutls_boot): No need to check for memory allocation failure,
5550 since xmalloc does that for us.
5551
5552 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5553 * category.c (hash_get_category_set):
5554 * ccl.c (ccl_driver):
5555 * charset.c (Fdefine_charset_internal):
5556 * charset.h (struct charset.hash_index):
5557 * composite.c (get_composition_id, gstring_lookup_cache)
5558 (composition_gstring_put_cache):
5559 * composite.h (struct composition.hash_index):
5560 * dispextern.h (struct image.hash):
5561 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5562 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5563 (hashfn_equal, hashfn_user_defined, make_hash_table)
5564 (maybe_resize_hash_table, hash_lookup, hash_put)
5565 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5566 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5567 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5568 * image.c (make_image, search_image_cache, lookup_image)
5569 (xpm_put_color_table_h):
5570 * lisp.h (struct Lisp_Hash_Table):
5571 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5572 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5573 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5574 * alloc.c (allocate_vectorlike):
5575 Check for overflow in vector size calculations.
5576 * ccl.c (ccl_driver):
5577 Check for overflow when converting EMACS_INT to int.
5578 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5579 need to be updated by these changes.
5580 * fns.c (make_hash_table, maybe_resize_hash_table):
5581 Check for integer overflow with large hash tables.
5582 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5583 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5584 (SXHASH_REDUCE): New macro.
5585 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5586 Use it instead of discarding useful hash info with large hash values.
5587 (sxhash_float): New function.
5588 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5589 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5590 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5591 Rewrite to use FIXNUM_BITS, as this simplifies things.
5592 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5593 Adjust signatures to match updated version of code.
5594 (consing_since_gc): Now EMACS_INT, since a single hash table can
5595 use more than INT_MAX bytes.
5596
5597 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5598
5599 Make it possible to build with GCC-4.6+ -O2 -flto.
5600
5601 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5602
5603 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5604
5605 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5606 Call minibuffer-inactive-mode.
5607
5608 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5609
5610 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5611 Update dependencies.
5612
5613 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5614
5615 * data.c (init_data): Remove code for UTS, this system is not
5616 supported anymore.
5617
5618 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5619
5620 Don't force ./temacs to start in terminal mode.
5621
5622 * frame.c (make_initial_frame): Initialize faces in all cases, not
5623 only when CANNOT_DUMP is defined.
5624 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5625
5626 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5627
5628 * dispnew.c (add_window_display_history): Use const for the string
5629 pointer. Remove declaration, not needed.
5630
5631 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5632
5633 Use 'inline', not 'INLINE'.
5634 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5635 * alloc.c, fontset.c (INLINE): Remove.
5636 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5637 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5638 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5639 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5640 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5641
5642 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5643
5644 Make it possible to run ./temacs.
5645
5646 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5647 syms_of_callproc does the same thing. Remove test for
5648 "initialized", do it in the caller.
5649 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5650
5651 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5652
5653 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5654 (read_minibuf): Use get_minibuffer.
5655 (syms_of_minibuf): Use DEFSYM.
5656 (Qmetadata): New var.
5657 * data.c (Qbuffer): Don't make it static.
5658 (syms_of_data): Use DEFSYM.
5659
5660 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5661
5662 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5663 (CCL_CODE_MIN): New macro.
5664
5665 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5666
5667 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5668
5669 * eval.c (Qdebug): Now static.
5670 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5671 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5672 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5673
5674 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5675
5676 * image.c: Various fixes to ImageMagick code comments.
5677 (Fimagemagick_types): Doc fix.
5678
5679 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5680
5681 Minor fixes prompted by GCC 4.6.0 warnings.
5682
5683 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5684
5685 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5686 (x_clipboard_manager_save_all): Move extern decl to ...
5687 * xterm.h: ... here, so that it can be checked for consistency.
5688
5689 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5690
5691 * xselect.c (x_clipboard_manager_save_frame)
5692 (x_clipboard_manager_save_all): New functions.
5693 (Fx_clipboard_manager_save): Lisp function deleted.
5694
5695 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5696 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5697
5698 * xterm.h: Update prototype.
5699
5700 2011-05-28 William Xu <william.xwl@gmail.com>
5701
5702 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5703 exiting (Bug#8239).
5704
5705 2011-05-28 Jim Meyering <meyering@redhat.com>
5706
5707 Avoid a sign-extension bug in crypto_hash_function.
5708 * fns.c (to_uchar): Define.
5709 (crypto_hash_function): Use it to convert some newly-signed
5710 variables to unsigned, to avoid sign-extension bugs. For example,
5711 without this change, (md5 "truc") would evaluate to
5712 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5713 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5714 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5715
5716 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5717
5718 Integer overflow fixes.
5719
5720 * dbusbind.c: Serial number integer overflow fixes.
5721 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5722 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5723 to hold a serial number that is too large for a fixnum.
5724 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5725 Check for serial numbers out of range. Decode any serial number
5726 that was so large that it became a float. (Bug#8722)
5727
5728 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5729 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5730 Use XFASTINT rather than XUINT when numbers are nonnegative.
5731 (xd_append_arg, Fdbus_method_return_internal):
5732 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5733 arguments, check that Lisp number is nonnegative, rather than
5734 silently wrapping negative numbers around. (Bug#8722)
5735 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5736 (Bug#8722)
5737
5738 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5739
5740 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5741
5742 ccl: Add integer overflow checks.
5743 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5744 (IN_INT_RANGE): New macros.
5745 (ccl_driver): Use them to check for integer overflow when
5746 decoding a CCL program. Many of the new checks are whether XINT (x)
5747 fits in int; it doesn't always, on 64-bit hosts. The new version
5748 doesn't catch all possible integer overflows, but it's an
5749 improvement. (Bug#8719)
5750
5751 * alloc.c (make_event_array): Use XINT, not XUINT.
5752 There's no need for unsigned here.
5753
5754 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5755 This follows up to the 2011-05-06 change that substituted uintptr_t
5756 for EMACS_INT. This case wasn't caught back then.
5757
5758 Rework Fformat to avoid integer overflow issues.
5759 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5760 now (part of C89). Include <verify.h>.
5761 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5762 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5763 (Fformat): Avoid the prepass trying to compute sizes; it was only
5764 approximate and thus did not catch overflow reliably. Instead, walk
5765 through the format just once, formatting and computing sizes as we go,
5766 checking for integer overflow at every step, and allocating a larger
5767 buffer as needed. Keep track separately whether the format is
5768 multibyte. Keep only the most-recently calculated precision, rather
5769 than them all. Record whether each argument has been converted to
5770 string. Use EMACS_INT, not int, for byte and char and arg counts.
5771 Support field widths and precisions larger than INT_MAX. Avoid
5772 sprintf's undefined behavior with conversion specifications such as %#d
5773 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5774 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5775 formatting out-of-range floating point numbers with int
5776 formats. (Bug#8668)
5777
5778 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5779
5780 * data.c: Avoid integer truncation in expressions involving floats.
5781 * data.c: Include <intprops.h>.
5782 (arith_driver): When there's an integer overflow in an expression
5783 involving floating point, convert the integers to floating point
5784 so that the resulting value does not suffer from catastrophic
5785 integer truncation. For example, on a 64-bit host (* 4
5786 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5787 Do not rely on undefined behavior after integer overflow.
5788
5789 merge count_size_as_multibyte, parse_str_to_multibyte
5790 * character.c, character.h (count_size_as_multibyte):
5791 Rename from parse_str_to_multibyte; all uses changed.
5792 Check for integer overflow.
5793 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5794 since it's now a duplicate of the other. This is more of
5795 a character than a buffer op, so better that it's in character.c.
5796 * fns.c, print.c: Adjust to above changes.
5797
5798 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5799
5800 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5801
5802 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5803
5804 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5805 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5806 (x_clipboard_manager_save): Now static.
5807 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5808
5809 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5810 (crypto_hash_function): Now static.
5811 Fix pointer signedness problems. Avoid unnecessary initializations.
5812
5813 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5814
5815 * termhooks.h (Vselection_alist): Make it terminal-local.
5816
5817 * terminal.c (create_terminal): Initialize it.
5818
5819 * xselect.c: Support for clipboard managers.
5820 (Vselection_alist): Move to termhooks.h as terminal-local var.
5821 (LOCAL_SELECTION): New macro.
5822 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5823 (symbol_to_x_atom): Remove gratuitous arg.
5824 (x_handle_selection_request, lisp_data_to_selection_data)
5825 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5826 (x_own_selection, x_get_local_selection, x_convert_selection):
5827 New arg, specifying work frame. Use terminal-local Vselection_alist.
5828 (some_frame_on_display): Delete unused function.
5829 (Fx_own_selection_internal, Fx_get_selection_internal)
5830 (Fx_disown_selection_internal, Fx_selection_owner_p)
5831 (Fx_selection_exists_p): New optional frame arg.
5832 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5833 (x_handle_selection_clear): Don't treat other terminals with the
5834 same keyboard specially. Use the terminal-local Vselection_alist.
5835 (x_clear_frame_selections): Use Frun_hook_with_args.
5836
5837 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5838
5839 * xterm.h: Add support for those atoms.
5840
5841 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5842
5843 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5844 (converted_selections, conversion_fail_tag): New global variables.
5845 (x_selection_request_lisp_error): Free the above.
5846 (x_get_local_selection): Remove unnecessary code.
5847 (x_reply_selection_request): Args changed; handle arbitrary array
5848 of converted selections stored in converted_selections.
5849 Separate the XChangeProperty and SelectionNotify steps.
5850 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5851 (x_convert_selection): New function.
5852 (x_handle_selection_event): Simplify.
5853 (x_get_foreign_selection): Don't ignore incoming requests while
5854 waiting for an answer; this will fail when we implement
5855 SAVE_TARGETS, and seems unnecessary anyway.
5856 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5857 (Vx_sent_selection_functions): Doc fix.
5858
5859 2011-05-26 Leo Liu <sdl.web@gmail.com>
5860
5861 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5862
5863 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5864
5865 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5866
5867 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5868 for fringe update if it has periodic bitmap.
5869 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5870 and fringe_bitmap_periodic_p.
5871
5872 * fringe.c (get_fringe_bitmap_data): New function.
5873 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5874 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5875 row. Mark glyph row for fringe update if periodicity changed.
5876
5877 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5878 for fringe update unless it has periodic bitmap.
5879
5880 2011-05-25 Kenichi Handa <handa@m17n.org>
5881
5882 * xdisp.c (get_next_display_element): Set correct it->face_id for
5883 a static composition.
5884
5885 2011-05-24 Leo Liu <sdl.web@gmail.com>
5886
5887 * deps.mk (fns.o):
5888 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5889
5890 * fns.c (crypto_hash_function, Fsha1): New function.
5891 (Fmd5): Use crypto_hash_function.
5892 (syms_of_fns): Add Ssha1.
5893
5894 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5895
5896 * gnutls.c: Remove unused macros.
5897 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5898 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5899 Remove macros that are defined and never used.
5900 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5901
5902 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5903
5904 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5905 (Fx_get_selection_internal): Minor cleanup.
5906 (Fx_own_selection_internal): Rename arguments for consistency with
5907 select.el.
5908
5909 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5910
5911 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5912
5913 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5914
5915 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5916
5917 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5918
5919 * dispnew.c (scrolling_window): Don't exclude the case that the
5920 last enabled row in the desired matrix touches the bottom boundary.
5921
5922 2011-05-21 Glenn Morris <rgm@gnu.org>
5923
5924 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5925 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5926 and add some more files.
5927
5928 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5929
5930 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5931 report_file_error introduced by the change from 2011-05-07.
5932
5933 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5934
5935 * systime.h (Time): Define only if emacs is defined.
5936 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5937 where the include path doesn't have X11/X.h by default. See
5938 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5939
5940 2011-05-20 Kenichi Handa <handa@m17n.org>
5941
5942 * composite.c (find_automatic_composition): Fix previous change.
5943
5944 2011-05-20 Glenn Morris <rgm@gnu.org>
5945
5946 * lisp.mk: New file, split from Makefile.in.
5947 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5948 (shortlisp): Remove.
5949 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5950
5951 2011-05-19 Glenn Morris <rgm@gnu.org>
5952
5953 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5954 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5955 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5956 (lisp): Set the order to that of loadup.el.
5957 (shortlisp): Make it a copy of $lisp.
5958 (SOME_MACHINE_LISP): Remove.
5959 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5960 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5961
5962 2011-05-18 Kenichi Handa <handa@m17n.org>
5963
5964 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5965 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5966 (find_automatic_composition): Mostly rewrite for efficiency.
5967
5968 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5969
5970 * makefile.w32-in: Update dependencies.
5971
5972 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5973
5974 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5975 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5976
5977 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5978
5979 Fix some integer overflow issues, such as string length overflow.
5980
5981 * insdel.c (count_size_as_multibyte): Check for string overflow.
5982
5983 * character.c (lisp_string_width): Check for string overflow.
5984 Use EMACS_INT, not int, for string indexes and lengths; in
5985 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5986 the resulting string length overflows an EMACS_INT; instead,
5987 report a string overflow if no precision given. When checking for
5988 precision exhaustion, use a check that cannot possibly have
5989 integer overflow. (Bug#8675)
5990 * character.h (lisp_string_width): Adjust to new signature.
5991
5992 * alloc.c (string_overflow): New function.
5993 (Fmake_string): Use it. This doesn't change behavior, but saves
5994 a few bytes and will simplify future changes.
5995 * character.c (string_escape_byte8): Likewise.
5996 * lisp.h (string_overflow): New decl.
5997
5998 Fixups, following up to the user-interface timestamp change.
5999 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6000 for UI timestamps, instead of unsigned long.
6001 * msdos.c (mouse_get_pos): Likewise.
6002 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6003 * w32gui.h (Time): Define by including "systime.h" rather than by
6004 declaring it ourselves. (Bug#8664)
6005
6006 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6007 * image.c (clear_image_cache): Likewise.
6008
6009 * term.c (term_mouse_position): Don't assume time_t wraparound.
6010
6011 Be more systematic about user-interface timestamps.
6012 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6013 and sometimes 'EMACS_UINT', to represent these timestamps.
6014 This change causes it to use 'Time' uniformly, as that's what X uses.
6015 This makes the code easier to follow, and makes it easier to catch
6016 integer overflow bugs such as Bug#8664.
6017 * frame.c (Fmouse_position, Fmouse_pixel_position):
6018 Use Time, not unsigned long, for user-interface timestamps.
6019 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6020 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6021 * keyboard.h (last_event_timestamp): Likewise.
6022 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6023 * menu.h (xmenu_show): Likewise.
6024 * term.c (term_mouse_position): Likewise.
6025 * termhooks.h (struct input_event.timestamp): Likewise.
6026 (struct terminal.mouse_position_hook): Likewise.
6027 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6028 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6029 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6030 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6031 what it was before.
6032 * menu.h, termhooks.h: Include "systime.h", for Time.
6033
6034 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6035 Don't assume that the difference between two unsigned long values
6036 can fit into an integer. At this point, we know button_down_time
6037 <= event->timestamp, so the difference must be nonnegative, so
6038 there's no need to cast the result if double-click-time is
6039 nonnegative, as it should be; check that it's nonnegative, just in
6040 case. This bug is triggered when events are more than 2**31 ms
6041 apart (about 25 days). (Bug#8664)
6042
6043 * xselect.c (last_event_timestamp): Remove duplicate decl.
6044 (x_own_selection): Remove needless cast to unsigned long.
6045
6046 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6047 that always fit in int. Use a sentinel instead of a counter, to
6048 avoid a temp and to allay GCC's concerns about possible int overflow.
6049 * frame.h (struct frame): Use int for menu_bar_items_used
6050 instead of EMACS_INT, since it always fits in int.
6051
6052 * menu.c (grow_menu_items): Check for int overflow.
6053
6054 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6055
6056 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6057 Before, the code was not consistent. These values cannot exceed
6058 2**31 - 1 so there's no need to make them unsigned.
6059 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6060 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6061 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6062 as modifiers.
6063 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6064
6065 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6066 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6067 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6068 presumably because the widths might not match.
6069
6070 * window.c (size_window): Avoid needless test at loop start.
6071
6072 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6073
6074 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6075
6076 2011-05-12 Drew Adams <drew.adams@oracle.com>
6077
6078 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6079
6080 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6081
6082 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6083 `width' to `bar_area_x' and `bar_area_width', respectively.
6084 (x_scroll_run): Take account of fringe background extension.
6085
6086 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6087 Rename local vars `left' and `width' to `bar_area_x' and
6088 `bar_area_width', respectively.
6089 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6090 background extension.
6091
6092 2011-05-10 Jim Meyering <meyering@redhat.com>
6093
6094 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6095
6096 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6097
6098 * image.c (Finit_image_library): Return t for built-in image types,
6099 like pbm and xbm. (Bug#8640)
6100
6101 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6102
6103 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6104
6105 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6106
6107 * w32console.c (Fset_screen_color): Doc fix.
6108 (Fget_screen_color): New function.
6109 (syms_of_ntterm): Defsubr it.
6110
6111 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6112 unlink the temporary file if Fcall_process didn't create it in the
6113 first place.
6114 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6115 child process will be redirected to a file specified with `:file'.
6116 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6117 cue to call_process_cleanup not to close that handle.
6118
6119 2011-05-07 Ben Key <bkey76@gmail.com>
6120
6121 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6122 one of two shell specific rules, either bootstrap-temacs-CMD or
6123 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6124 to the previous implementation of the bootstrap-temacs rule.
6125 The bootstrap-temacs-CMD rule is similar to the previous
6126 implementation of the bootstrap-temacs rule except that it
6127 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6128 variable.
6129
6130 These changes, along with some changes to nt/configure.bat,
6131 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6132 earlier fix to add support for --cflags and --ldflags options
6133 that include quotes so that it works whether make uses cmd or
6134 sh as the shell.
6135
6136 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6137
6138 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6139 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6140 is a constant.
6141 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6142 a string. Handle both cases.
6143 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6144 (Fdbus_register_method): Use Qinvalid_function.
6145
6146 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6147
6148 * makefile.w32-in: Update dependencies.
6149 (LISP_H): Add inttypes.h and stdin.h.
6150 (PROCESS_H): Add unistd.h.
6151
6152 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6153
6154 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6155 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6156
6157 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6158
6159 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6160
6161 * term.c (vfatal): Remove stray call to va_end.
6162 It's not needed and the C Standard doesn't allow it here anyway.
6163
6164 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6165 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6166
6167 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6168 bytes.
6169
6170 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6171
6172 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6173
6174 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6175
6176 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6177
6178 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6179
6180 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6181 * charset.c (Fdefine_charset_internal): Don't initialize
6182 charset.code_space[15]. The value was garbage, on hosts with
6183 32-bit int (Bug#8600).
6184
6185 * lread.c (read_integer): Be more consistent with string-to-number.
6186 Use string_to_number to do the actual conversion; this avoids
6187 rounding errors and fixes some other screwups. Without this fix,
6188 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6189 (digit_to_number): Move earlier, for benefit of read_integer.
6190 Return -1 if the digit is out of range for the base, -2 if it is
6191 not a digit in any supported base. (Bug#8602)
6192
6193 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6194
6195 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6196 to match comment at start of function. This also removes a
6197 GCC warning about overflow in a 32+64-bit port.
6198
6199 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6200
6201 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6202 Reported by Stefan Monnier in
6203 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6204 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6205 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6206
6207 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6208 (EMACS_UINTPTR): Likewise, with uintptr_t.
6209
6210 * lisp.h: Prefer 64-bit EMACS_INT if available.
6211 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6212 on 32-bit hosts that have 64-bit int, so that they can access
6213 large files.
6214 However, temporarily disable this change unless the temporary
6215 symbol WIDE_EMACS_INT is defined.
6216
6217 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6218
6219 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6220 This removes an assumption that EMACS_INT and long are the same
6221 width as pointers. The assumption is true for Emacs porting targets
6222 now, but we want to make other targets possible.
6223 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6224 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6225 In the rest of the code, change types of integers that hold casted
6226 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6227 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6228 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6229 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6230 No need to cast type when ORing.
6231 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6232 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6233 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6234 assume EMACS_INT is the same width as char *.
6235 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6236 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6237 Remove no-longer-needed casts.
6238 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6239 (xg_tool_bar_help_callback, xg_make_tool_item):
6240 Use EMACS_INTPTR to hold an integer
6241 that will be cast to void *; this can avoid a GCC warning
6242 if EMACS_INT is not the same width as void *.
6243 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6244 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6245 (current_message_1, set_message_1):
6246 Use a local to convert to proper width without a cast.
6247 * xmenu.c (dialog_selection_callback): Likewise.
6248
6249 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6250 Also, don't assume VALBITS / RAND_BITS is less than 5,
6251 and don't rely on undefined behavior when shifting a 1 left into
6252 the sign bit.
6253 * lisp.h (get_random): Change signature to match.
6254
6255 * lread.c (hash_string): Use size_t, not int, for hash computation.
6256 Normally we prefer signed values; but hashing is special, because
6257 it's better to use unsigned division on hash table sizes so that
6258 the remainder is nonnegative. Also, size_t is the natural width
6259 for hashing into memory. The previous code used 'int', which doesn't
6260 retain enough info to hash well into very large tables.
6261 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6262
6263 * dbusbind.c: Don't possibly lose pointer info when converting.
6264 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6265 Use XPNTR rather than XHASH, so that the high-order bits of
6266 the pointer aren't lost when converting through void *.
6267
6268 * eval.c (Fautoload): Don't double-shift a pointer.
6269
6270 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6271
6272 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6273
6274 * gnutls.c (DEF_GNUTLS_FN):
6275 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6276
6277 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6278
6279 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6280 marker. (Bug#8610)
6281
6282 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6283
6284 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6285 New version that can reserve upto 2GB of heap space.
6286
6287 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6288
6289 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6290
6291 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6292
6293 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6294 `gnutls_certificate_set_x509_key_file'.
6295
6296 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6297
6298 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6299 Update dependencies.
6300
6301 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6302
6303 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6304 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6305 Remove unused parameter `fildes'.
6306 * process.c (read_process_output, send_process): Don't pass it.
6307
6308 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6309
6310 Fix previous change: the library cache is defined in w32.c.
6311 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6312 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6313
6314 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6315
6316 Implement dynamic loading of GnuTLS on Windows.
6317
6318 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6319 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6320 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6321 Declare.
6322
6323 * gnutls.c (Qgnutls_dll): Define.
6324 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6325 (gnutls_*): Declare function pointers.
6326 (init_gnutls_functions): New function to initialize function pointers.
6327 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6328 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6329 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6330 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6331 (emacs_gnutls_write, emacs_gnutls_read)
6332 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6333 (Fgnutls_available_p): New function.
6334 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6335 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6336 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6337
6338 * image.c: Include w32.h.
6339 (Vimage_type_cache): Delete.
6340 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6341 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6342 (w32_delayed_load): Move to w32.c.
6343
6344 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6345
6346 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6347 (w32_delayed_load): Move from image.c. When loading a library, record
6348 its filename in the :loaded-from property of the library id.
6349 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6350 Initialize and staticpro them.
6351 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6352
6353 * process.c: Include lisp.h before w32.h, not after.
6354 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6355 instead of gnutls_record_check_pending.
6356
6357 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6358
6359 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6360
6361 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6362 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6363 as passed in.
6364
6365 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6366
6367 * xterm.c (x_set_frame_alpha): Do not set property on anything
6368 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6369
6370 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6371
6372 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6373
6374 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6375
6376 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6377 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6378 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6379 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6380 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6381 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6382 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6383 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6384 (Qgnutls_bootprop_callbacks_verify): Make static.
6385
6386 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6387
6388 * callproc.c: Indentation fixup.
6389
6390 * sysdep.c (wait_for_termination_1): Make static.
6391 (wait_for_termination, interruptible_wait_for_termination):
6392 Move after wait_for_termination_1.
6393
6394 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6395
6396 * sysdep.c (interruptible_wait_for_termination): New function
6397 which is like wait_for_termination, but allows keyboard
6398 interruptions.
6399
6400 * callproc.c (Fcall_process): Add (:file "file") as an option for
6401 the STDOUT buffer.
6402 (Fcall_process_region): Ditto.
6403
6404 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6405
6406 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6407 rather than `XVECTOR (FOO)->size'.
6408
6409 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6410 inttypes.h, as a gnulib replacement is used if it not available in
6411 system headers.
6412
6413 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6414
6415 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6416 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6417 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6418
6419 * coding.c (coding_alloc_by_realloc): Error out if destination
6420 will grow beyond MOST_POSITIVE_FIXNUM.
6421 (decode_coding_emacs_mule): Abort if there isn't enough place in
6422 charbuf for the composition carryover bytes. Reserve an extra
6423 space for up to 2 characters produced in a loop.
6424 (decode_coding_iso_2022): Abort if there isn't enough place in
6425 charbuf for the composition carryover bytes.
6426
6427 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6428
6429 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6430 aborting when %lld or %lll format is passed.
6431 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6432 %llo or %llx format is passed. (Bug#8545)
6433
6434 * window.c (window_scroll_line_based): Use a marker instead of
6435 simple variables to record original value of point. (Bug#7952)
6436
6437 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6438 produced by %s or %c overflows available buffer space. (Bug#8545)
6439
6440 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6441
6442 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6443 (SIZE_MAX): Move defn after all includes, as they might #define it.
6444
6445 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6446
6447 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6448
6449 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6450
6451 * keyboard.c (Qdelayed_warnings_hook): Define.
6452 (command_loop_1): Run `delayed-warnings-hook'
6453 if Vdelayed_warnings_list is non-nil.
6454 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6455 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6456
6457 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6458
6459 * doprnt.c (doprnt): Don't return value smaller than the buffer
6460 size if the message was truncated. (Bug#8545).
6461
6462 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6463
6464 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6465 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6466
6467 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6468
6469 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6470
6471 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6472
6473 * makefile.w32-in: Update dependencies.
6474
6475 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6476
6477 Improve `doprnt' and its usage. (Bug#8545)
6478 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6479 `format_end'. Remove support for %l as a conversion specifier.
6480 Don't use xrealloc. Improve diagnostics when the %l size modifier
6481 is used. Update the commentary.
6482
6483 * eval.c (verror): Simplify calculation of size_t.
6484
6485 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6486 messages.
6487
6488 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6489
6490 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6491 change.
6492
6493 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6494
6495 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6496 This makes this file independent of the recent pseudovector change.
6497
6498 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6499
6500 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6501
6502 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6503 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6504 Remove unused local.
6505 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6506
6507 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6508 GCC 4.6.0 optimizes based on type-based alias analysis.
6509 For example, if b is of type struct buffer * and v of type struct
6510 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6511 != &v->size, and therefore "v->size = 1; b->size = 2; return
6512 v->size;" must therefore return 1. This assumption is incorrect
6513 for Emacs, since it type-puns struct Lisp_Vector * with many other
6514 types. To fix this problem, this patch adds a new type struct
6515 vectorlike_header that documents the constraints on layout of vectors
6516 and pseudovectors, and helps optimizing compilers not get fooled
6517 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6518 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6519 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6520 the size member.
6521 (XSETPVECTYPE): Rewrite in terms of new macro.
6522 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6523 This is a bit clearer, and further avoids the possibility of
6524 undesirable aliasing.
6525 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6526 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6527 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6528 since Lisp_Subr is a special case (no "next" field).
6529 (ASIZE): Now uses header.size rather than size.
6530 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6531 to avoid the hassle of writing XVECTOR (foo)->header.size.
6532 (struct vectorlike_header): New type.
6533 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6534 object, to help avoid aliasing.
6535 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6536 (SUBRP): Likewise, since Lisp_Subr is a special case.
6537 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6538 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6539 (struct Lisp_Hash_Table): Combine first two members into a single
6540 struct vectorlike_header member. All uses of "size" and "next" members
6541 changed to be "header.size" and "header.next".
6542 * buffer.h (struct buffer): Likewise.
6543 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6544 * frame.h (struct frame): Likewise.
6545 * process.h (struct Lisp_Process): Likewise.
6546 * termhooks.h (struct terminal): Likewise.
6547 * window.c (struct save_window_data, struct saved_window): Likewise.
6548 * window.h (struct window): Likewise.
6549 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6550 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6551 * buffer.c (init_buffer_once): Likewise.
6552 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6553 special case.
6554 * process.c (Fformat_network_address): Use local var for size,
6555 for brevity.
6556
6557 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6558
6559 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6560 * data.c (atof): Remove decl; no longer used or needed.
6561 (digit_to_number): Move to lread.c.
6562 (Fstring_to_number): Use new string_to_number function, to be
6563 consistent with how the Lisp reader treats infinities and NaNs.
6564 Do not assume that floating-point numbers represent EMACS_INT
6565 without losing information; this is not true on most 64-bit hosts.
6566 Avoid double-rounding errors, by insisting on integers when
6567 parsing non-base-10 numbers, as the documentation specifies.
6568 * lisp.h (string_to_number): New decl, replacing ...
6569 (isfloat_string): Remove.
6570 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6571 (read1): Do not accept +. and -. as integers; this
6572 appears to have been a coding error. Similarly, do not accept
6573 strings like +-1e0 as floating point numbers. Do not report
6574 overflow for integer overflows unless the base is not 10 which
6575 means we have no simple and reliable way to continue.
6576 Break out the floating-point parsing into a new
6577 function string_to_number, so that Fstring_to_number parses
6578 floating point numbers consistently with the Lisp reader.
6579 (digit_to_number): Move here from data.c. Make it static inline.
6580 (E_CHAR, EXP_INT): Remove, replacing with ...
6581 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6582 (string_to_number): New function, replacing isfloat_string.
6583 This function checks for valid syntax and produces the resulting
6584 Lisp float number too. Rework it so that string-to-number
6585 no longer mishandles examples like "1.0e+". Use strtoumax,
6586 so that overflow for non-base-10 numbers is reported only when
6587 there's no portable and simple way to convert to floating point.
6588
6589 * textprop.c (set_text_properties_1): Rewrite for clarity,
6590 and to avoid GCC warning about integer overflow.
6591
6592 * intervals.h (struct interval): Use EMACS_INT for members
6593 where EMACS_UINT might cause problems. See
6594 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6595 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6596 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6597 All uses changed.
6598 (offset_intervals): Tell GCC not to worry about length overflow
6599 when negating a negative length.
6600
6601 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6602 (overrun_check_free): Likewise.
6603
6604 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6605 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6606 word size.
6607
6608 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6609 (gnutls_make_error): Rename local to avoid shadowing.
6610 (gnutls_emacs_global_deinit): ifdef out; not used.
6611 (Fgnutls_boot): Use const for pointer to readonly storage.
6612 Comment out unused local. Fix pointer signedness problems.
6613
6614 * lread.c (openp): Don't stuff size_t into an 'int'.
6615 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6616 about possible signed overflow.
6617
6618 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6619 (GDK_KEY_g): Don't define if already defined.
6620 (xg_prepare_tooltip): Avoid pointer signedness problem.
6621 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6622
6623 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6624 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6625
6626 * xfns.c (Fx_window_property): Simplify a bit,
6627 to make a bit faster and to avoid GCC 4.6.0 warning.
6628 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6629
6630 * fns.c (internal_equal): Don't assume size_t fits in int.
6631
6632 * alloc.c (compact_small_strings): Tighten assertion a little.
6633
6634 Replace pEd with more-general pI, and fix some printf arg casts.
6635 * lisp.h (pI): New macro, generalizing old pEd macro to other
6636 conversion specifiers. For example, use "...%"pI"d..." rather
6637 than "...%"pEd"...".
6638 (pEd): Remove. All uses replaced with similar uses of pI.
6639 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6640 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6641 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6642 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6643 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6644 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6645 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6646 64-bit hosts.
6647 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6648 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6649 * print.c (safe_debug_print, print_object): Likewise.
6650 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6651 to int.
6652 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6653 avoiding the 0 flag, which is not portable.
6654 * process.c (Fmake_network_process): Use pI to avoid cast.
6655 * region-cache.c (pp_cache): Likewise.
6656 * xdisp.c (decode_mode_spec): Likewise.
6657 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6658 behavior on 64-bit hosts with printf arg.
6659 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6660 (x_stop_queuing_selection_requests): Likewise.
6661 (x_get_window_property): Don't truncate byte count to an 'int'
6662 when tracing.
6663
6664 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6665 here, since it parses constructs like leading '-' and spaces,
6666 which are not wanted; and it overflows with large numbers.
6667 Instead, simply match F[0-9]+, which is what is wanted anyway.
6668
6669 * alloc.c: Remove unportable assumptions about struct layout.
6670 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6671 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6672 (allocate_vectorlike, make_pure_vector): Use the new macros,
6673 plus offsetof, to remove unportable assumptions about struct layout.
6674 These assumptions hold on all porting targets that I know of, but
6675 they are not guaranteed, they're easy to remove, and removing them
6676 makes further changes easier.
6677
6678 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6679 This doesn't fix a bug but makes the code clearer.
6680 (string_overrun_cookie): Now const. Use initializers that
6681 don't formally overflow signed char, to avoid warnings.
6682 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6683 can cause Emacs to crash when string overrun checking is enabled.
6684 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6685 multiple of sizeof (EMACS_INT); it need not be, if
6686 alignof(EMACS_INT) < sizeof (EMACS_INT).
6687 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6688
6689 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6690
6691 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6692
6693 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6694
6695 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6696 supposed to be handshaking. (Bug#8556)
6697 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6698
6699 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6700
6701 * lisp.h (Qdebug): List symbol.
6702 * eval.c (Qdebug): Restore global linkage.
6703 * keyboard.c (debug-on-event): New variable.
6704 (handle_user_signal): Break into debugger when debug-on-event
6705 matches the current signal symbol.
6706
6707 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6708
6709 * alloc.c (check_sblock, check_string_bytes)
6710 (check_string_free_list): Convert to standard C.
6711
6712 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6713
6714 * w32.c (emacs_gnutls_push): Fix typo.
6715
6716 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6717
6718 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6719 "cast to pointer from integer of different size".
6720
6721 Improve doprnt and its use in verror. (Bug#8545)
6722 * doprnt.c (doprnt): Document the set of format control sequences
6723 supported by the function. Use SAFE_ALLOCA instead of always
6724 using `alloca'.
6725
6726 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6727 is one byte too soon. Don't use xrealloc; instead xfree and
6728 xmalloc anew.
6729
6730 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6731
6732 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6733 callbacks stage.
6734
6735 * gnutls.c: Renamed global_initialized to
6736 gnutls_global_initialized. Added internals for the
6737 :verify-hostname-error, :verify-error, and :verify-flags
6738 parameters of `gnutls-boot' and documented those parameters in the
6739 docstring. Start callback support.
6740 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6741 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6742 on error. Return error code.
6743 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6744 (emacs_gnutls_read): Likewise.
6745 (Fgnutls_boot): Return handshake error code.
6746 (emacs_gnutls_handle_error): New function.
6747 (wsaerror_to_errno): Likewise.
6748
6749 * w32.h (emacs_gnutls_pull): Add prototype.
6750 (emacs_gnutls_push): Likewise.
6751
6752 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6753 (emacs_gnutls_push): Likewise.
6754
6755 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6756
6757 * process.c (wait_reading_process_output): Check if GnuTLS
6758 buffered some data internally if no FDs are set for TLS
6759 connections.
6760
6761 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6762 (LIBS): Link to USER_LIBS.
6763 ($(BLD)/gnutls.$(0)): New target.
6764
6765 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6766
6767 * xdisp.c (handle_single_display_spec): Rename the
6768 display_replaced_before_p argument into display_replaced_p, to
6769 make it consistent with the commentary. Fix typos in the
6770 commentary.
6771
6772 * textprop.c (syms_of_textprop): Remove dead code.
6773 (copy_text_properties): Delete obsolete commentary about an
6774 interface that was deleted long ago. Fix typos in the description
6775 of arguments.
6776
6777 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6778 to changes in oldXMenu/XMenu.h from 2011-04-16.
6779 <menu_help_message, prev_menu_help_message>: Constify.
6780 (IT_menu_make_room): menu->help_text is now `const char **';
6781 adjust.
6782
6783 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6784 to changes in oldXMenu/XMenu.h from 2011-04-16.
6785 (struct XMenu): Declare `help_text' `const char **'.
6786
6787 * xfaces.c <Qunspecified>: Make extern again.
6788
6789 * syntax.c: Include sys/types.h before including regex.h, as
6790 required by Posix.
6791
6792 * doc.c (get_doc_string): Improve the format passed to `error'.
6793
6794 * doprnt.c (doprnt): Improve commentary.
6795
6796 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6797
6798 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6799 them with etags.
6800
6801 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6802 changes in globals.h immediately force recompilation.
6803 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6804 $(CURDIR)/s/ms-w32.h.
6805 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6806
6807 * character.c (Fchar_direction): Function deleted.
6808 (syms_of_character): Don't defsubr it.
6809 <char-direction-table>: Deleted.
6810
6811 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6812
6813 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6814 * doprnt.c: Include limits.h.
6815 (SIZE_MAX): New macro.
6816 (doprnt): Return a size_t value. 2nd arg is now size_t.
6817 Many local variables are now size_t instead of int or unsigned.
6818 Improve overflow protection. Support `l' modifier for integer
6819 conversions. Support %l conversion. Don't assume an EMACS_INT
6820 argument for integer conversions and for %c.
6821
6822 * lisp.h (doprnt): Restore prototype.
6823
6824 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6825 $(SRC)/character.h.
6826
6827 * Makefile.in (base_obj): Add back doprnt.o.
6828
6829 * deps.mk (doprnt.o): Add back prerequisites.
6830 (callint.o): Depend on character.h.
6831
6832 * eval.c (internal_lisp_condition_case): Include the handler
6833 representation in the error message.
6834 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6835 when breaking from the loop.
6836
6837 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6838
6839 * callint.c (Fcall_interactively): When displaying error message
6840 about invalid control letter, pass the character's codepoint, not
6841 a pointer to its multibyte form. Improve display of the character
6842 in octal and display also its hex code.
6843
6844 * character.c (char_string): Use %x to display the (unsigned)
6845 codepoint of an invalid character, to avoid displaying a bogus
6846 negative value.
6847
6848 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6849 `error', not SYMBOL_NAME itself.
6850
6851 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6852 character arguments to `error'.
6853
6854 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6855 to `error' in error message about FINAL_CHAR argument. Make sure
6856 FINAL_CHAR is a character, and use %c when it is passed as
6857 argument to `error'.
6858
6859 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6860
6861 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6862
6863 * w32.c: Include <time.h>.
6864 (sys_localtime): New function.
6865
6866 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6867
6868 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6869
6870 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6871
6872 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6873
6874 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6875 zombies (Bug#8467).
6876
6877 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6878
6879 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6880 gl_state.e_property when gl_state.object is Qt.
6881
6882 * insdel.c (make_gap_larger): Remove limitation of buffer size
6883 to <= INT_MAX.
6884
6885 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6886
6887 * xdisp.c (lookup_glyphless_char_display)
6888 (produce_glyphless_glyph): Handle cons cell entry in
6889 glyphless-char-display.
6890 (Vglyphless_char_display): Document it.
6891
6892 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6893 glyphless-char-display.
6894
6895 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6896
6897 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6898
6899 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6900
6901 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6902 definition for no-X builds.
6903
6904 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6905
6906 Static checks with GCC 4.6.0 and non-default toolkits.
6907
6908 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6909
6910 * process.c (keyboard_bit_set): Define only if SIGIO.
6911 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6912 (send_process): Repair possible setjmp clobbering.
6913
6914 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6915
6916 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6917
6918 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6919
6920 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6921 Define only if needed.
6922
6923 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6924 by pacifying GCC about it. Maybe it's time to retire it?
6925 * xfaces.c (USG, __TIMEVAL__): Likewise.
6926
6927 * dispextern.h (struct redisplay_interface): Rename param
6928 to avoid shadowing.
6929 * termhooks.h (struct terminal): Likewise.
6930 * xterm.c (xembed_send_message): Likewise.
6931
6932 * insdel.c (make_gap_smaller): Define only if
6933 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6934
6935 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6936 it.
6937
6938 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6939 so that we aren't warned about unused symbols.
6940
6941 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6942
6943 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6944
6945 * xfns.c (x_real_positions): Mark locals as initialized.
6946
6947 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6948
6949 * xterm.c: Fix problems found by static analysis with other toolkits.
6950 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6951 (x_dispatch_event): Declare static if USE_GTK, and
6952 define if USE_GTK || USE_X_TOOLKIT.
6953 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6954 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6955 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6956 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6957
6958 * xmenu.c (menu_help_callback): Pointer type fixes.
6959 Use const pointers when pointing at readonly data. Avoid pointer
6960 signedness clashes.
6961 (FALSE): Remove unused macro.
6962 (update_frame_menubar): Remove unused decl.
6963
6964 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6965
6966 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6967 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6968 (single_menu_item): Rename local to avoid shadowing.
6969
6970 * keyboard.c (make_lispy_event): Remove unused local var.
6971
6972 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6973 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6974
6975 * bitmaps: Change bitmaps from unsigned char back to the X11
6976 compatible char. Avoid the old compiler warnings about
6977 out-of-range initializers by using, for example, '\xab' rather
6978 than 0xab.
6979
6980 * xgselect.c (xgselect_initialize): Check vs interface
6981 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6982
6983 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6984
6985 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6986 to read-only memory.
6987
6988 * fns.c (vector): Remove; this old hack is no longer needed.
6989
6990 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6991 Remove unused var.
6992 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6993
6994 * xrdb.c (x_load_resources): Omit unused local.
6995
6996 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6997 (x_window): Rename locals to avoid shadowing.
6998 (USG): Use the kludged USG macro, to pacify gcc.
6999
7000 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7001 (x_term_init): Remove local to avoid shadowing.
7002
7003 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7004
7005 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7006 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7007
7008 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7009
7010 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7011
7012 Fix regex.c, syntax.c and friends for buffers > 2GB.
7013 * syntax.h (struct gl_state_s): Declare character position members
7014 EMACS_INT.
7015
7016 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7017
7018 * textprop.c (verify_interval_modification, interval_of):
7019 Declare arguments EMACS_INT.
7020
7021 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7022 EMACS_INT.
7023
7024 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7025
7026 * indent.c (Fvertical_motion): Local variable it_start is now
7027 EMACS_INT.
7028
7029 * regex.c (re_match, re_match_2, re_match_2_internal)
7030 (bcmp_translate, regcomp, regexec, print_double_string)
7031 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7032 (re_compile_pattern, re_exec): Declare arguments and local
7033 variables `size_t' and `ssize_t' and return values `regoff_t', as
7034 appropriate.
7035 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7036 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7037 <compile_stack_type>: `size' and `avail' are now `size_t'.
7038
7039 * regex.h <regoff_t>: Use ssize_t, not int.
7040 (re_search, re_search_2, re_match, re_match_2): Arguments that
7041 specify buffer/string position and length are now ssize_t and
7042 size_t. Return type is regoff_t.
7043
7044 2011-04-16 Ben Key <bkey76@gmail.com>
7045
7046 * nsfont.m: Fixed bugs in ns_get_family and
7047 ns_descriptor_to_entity that were caused by using free to
7048 deallocate memory blocks that were allocated by xmalloc (via
7049 xstrdup). This caused Emacs to crash when compiled with
7050 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7051 --enable-checking=xmallocoverrun). xfree is now used to
7052 deallocate these memory blocks.
7053
7054 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7055
7056 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7057
7058 emacs_write: Accept and return EMACS_INT for sizes.
7059 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7060 et seq.
7061 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7062 Accept and return EMACS_INT.
7063 (emacs_gnutls_write): Return the number of bytes written on
7064 partial writes.
7065 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7066 (emacs_read, emacs_write): Remove check for negative size, as the
7067 Emacs source code has been audited now.
7068 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7069 (emacs_read, emacs_write): Use it.
7070 * process.c (send_process): Adjust to the new signatures of
7071 emacs_write and emacs_gnutls_write. Do not attempt to store
7072 a byte offset into an 'int'; it might overflow.
7073 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7074
7075 * sound.c: Don't assume sizes fit in 'int'.
7076 (struct sound_device.period_size, alsa_period_size):
7077 Return EMACS_INT, not int.
7078 (struct sound_device.write, vox_write, alsa_write):
7079 Accept EMACS_INT, not int.
7080 (wav_play, au_play): Use EMACS_INT to store sizes and to
7081 record read return values.
7082
7083 2011-04-15 Ben Key <bkey76@gmail.com>
7084
7085 * keyboard.c (Qundefined): Don't declare static since it is used
7086 in nsfns.m.
7087 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7088 static since they are used in nsfont.m.
7089
7090 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7091
7092 * process.c (Qprocessp): Don't declare static.
7093 * lisp.h (Qprocessp): Declare again.
7094
7095 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7096
7097 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7098
7099 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7100
7101 Improve C-level modularity by making more things 'static'.
7102
7103 Don't publish debugger-only interfaces to other modules.
7104 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7105 (verify_bytepos, count_markers): Move decls to the only modules
7106 that need them.
7107 * region-cache.h (pp_cache): Likewise.
7108 * window.h (check_all_windows): Likewise.
7109 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7110
7111 * sysdep.c (croak): Now static, if
7112 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7113 * syssignal.h (croak): Declare only if not static.
7114
7115 * alloc.c (refill_memory_reserve): Now static if
7116 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7117 * lisp.h (refill_memory_reserve): Declare only if not static.
7118
7119 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7120 Define only if USE_LUCID.
7121
7122 * xrdb.c (x_customization_string, x_rm_string): Now static.
7123
7124 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7125 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7126
7127 * xdisp.c (draw_row_with_mouse_face): Now static.
7128 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7129
7130 * window.h (check_all_windows): Mark externally visible.
7131
7132 * window.c (window_deletion_count): Now static.
7133
7134 * undo.c: Make symbols static if they're not exported.
7135 (last_undo_buffer, last_boundary_position, pending_boundary):
7136 Now static.
7137
7138 * textprop.c (interval_insert_behind_hooks): Now static.
7139 (interval_insert_in_front_hooks): Likewise.
7140
7141 * term.c: Make symbols static if they're not exported.
7142 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7143 (max_frame_lines, tty_set_terminal_modes):
7144 (tty_reset_terminal_modes, tty_turn_off_highlight):
7145 (get_tty_terminal): Now static.
7146 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7147 * termhooks.h (term_mouse_moveto): Do not declare if
7148 HAVE_WINDOW_SYSTEM.
7149 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7150 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7151
7152 * sysdep.c: Make symbols static if they're not exported.
7153 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7154 Now static.
7155 (sigprocmask_set, full_mask): Remove; unused.
7156 (wait_debugging): Mark as visible.
7157 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7158 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7159
7160 * syntax.c (syntax_temp): Define only if !__GNUC__.
7161
7162 * sound.c (current_sound_device, current_sound): Now static.
7163
7164 * search.c (searchbufs, searchbuf_head): Now static.
7165
7166 * scroll.c (scroll_cost): Remove; unused.
7167 * dispextern.h (scroll_cost): Remove decl.
7168
7169 * region-cache.h (pp_cache): Mark as externally visible.
7170
7171 * process.c: Make symbols static if they're not exported.
7172 (process_tick, update_tick, create_process, chan_process):
7173 (Vprocess_alist, proc_buffered_char, datagram_access):
7174 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7175 (deactivate_process): Mark defn as static, as well as decl.
7176 * lisp.h (create_process): Remove decl.
7177 * process.h (chan_process, Vprocess_alist): Remove decls.
7178
7179 * print.c: Make symbols static if they're not exported.
7180 (print_depth, new_backquote_output, being_printed, print_buffer):
7181 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7182 (print_interval, print_number_index, initial_stderr_stream):
7183 Now static.
7184 * lisp.h (Fprinc): Remove decl.
7185 (debug_output_compilation_hack): Mark as externally visible.
7186
7187 * sysdep.c (croak): Move decl from here to syssignal.h.
7188 * syssignal.h (croak): Put it here, so the API can be checked when
7189 'croak' is called from dissociate_if_controlling_tty.
7190
7191 * minibuf.c: Make symbols static if they're not exported.
7192 (minibuf_save_list, choose_minibuf_frame): Now static.
7193 * lisp.h (choose_minibuf_frame): Remove decl.
7194
7195 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7196
7197 * lread.c: Make symbols static if they're not exported.
7198 (read_objects, initial_obarray, oblookup_last_bucket_number):
7199 Now static.
7200 (make_symbol): Remove; unused.
7201 * lisp.h (initial_obarray, make_symbol): Remove decls.
7202
7203 * keyboard.c: Make symbols static if they're not exported.
7204 (single_kboard, recent_keys_index, total_keys, recent_keys):
7205 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7206 (this_single_command_key_start, echoing, last_auto_save):
7207 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7208 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7209 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7210 (Vlispy_mouse_stem, double_click_count):
7211 Now static.
7212 (force_auto_save_soon): Define only if SIGDANGER.
7213 (ignore_mouse_drag_p): Now static if
7214 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7215 (print_help): Remove; unused.
7216 (stop_character, last_timer_event): Mark as externally visible.
7217 * keyboard.h (ignore_mouse_drag_p): Declare only if
7218 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7219 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7220 * lisp.h (echoing): Remove decl.
7221 (force_auto_save_soon): Declare only if SIGDANGER.
7222 * xdisp.c (redisplay_window): Simplify code, to make it more
7223 obvious that ignore_mouse_drag_p is not accessed if !defined
7224 USE_GTK && !defined HAVE_NS.
7225
7226 * intervals.c: Make symbols static if they're not exported.
7227 (merge_properties_sticky, merge_interval_right, delete_interval):
7228 Now static.
7229 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7230
7231 * insdel.c: Make symbols static if they're not exported.
7232 However, leave prepare_to_modify_buffer alone. It's never
7233 called from outside this function, but that appears to be a bug.
7234 (combine_after_change_list, combine_after_change_buffer):
7235 (adjust_after_replace, signal_before_change): Now static.
7236 (adjust_after_replace_noundo): Remove; unused.
7237 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7238 (signal_before_change): Remove decls.
7239
7240 * indent.c (val_compute_motion, val_vmotion): Now static.
7241
7242 * image.c: Make symbols static if they're not exported.
7243 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7244 if USE_GTK.
7245 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7246 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7247
7248 * fringe.c (standard_bitmaps): Now static.
7249 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7250
7251 * frame.c: Make symbols static if they're not exported.
7252 (x_report_frame_params, make_terminal_frame): Now static.
7253 (get_frame_param): Now static, unless HAVE_NS.
7254 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7255 (x_get_resource_string): Remove; not used.
7256 * frame.h (make_terminal_frame, x_report_frame_params):
7257 (x_get_resource_string); Remove decls.
7258 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7259 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7260
7261 * font.c, fontset.c: Make symbols static if they're not exported.
7262 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7263 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7264 * font.c (font_close_object): Now static.
7265 * font.h (font_close_object): Remove.
7266 * fontset.c (FONTSET_OBJLIST): Remove.
7267 (free_realized_fontset) #if-0 the body, which does nothing.
7268 (face_suitable_for_char_p): #if-0, as it's never called.
7269 * fontset.h (face_suitable_for_char_p): Remove decl.
7270 * xfaces.c (face_at_string_position):
7271 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7272 since 0 is always ASCII.
7273
7274 * fns.c (weak_hash_tables): Now static.
7275
7276 * fileio.c: Make symbols static if they're not exported.
7277 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7278 (Vwrite_region_annotation_buffers): Now static.
7279
7280 * eval.c: Make symbols static if they're not exported.
7281 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7282 * lisp.h (backtrace_list): Remove decl.
7283
7284 * emacs.c: Make symbols static if they're not exported.
7285 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7286 (fatal_error_code, fatal_error_signal_hook, standard_args):
7287 Now static.
7288 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7289 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7290 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7291 * lisp.h (fatal_error_signal_hook): Remove decl.
7292 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7293
7294 * editfns.c: Move a (normally-unused) function to its only use.
7295 * editfns.c, lisp.h (get_operating_system_release): Remove.
7296 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7297 worth the hassle of breaking this out.
7298
7299 * xterm.c: Make symbols static if they're not exported.
7300 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7301 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7302 (x_destroy_window, x_delete_display):
7303 Now static.
7304 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7305 (x_mouse_leave): Remove; unused.
7306 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7307 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7308 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7309 Remove decls.
7310 (x_mouse_leave): Declare only if WINDOWSNT.
7311 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7312 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7313 USE_X_TOOLKIT.
7314
7315 * ftxfont.c: Make symbols static if they're not exported.
7316 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7317 HAVE_FREETYPE.
7318 * font.h (ftxfont_driver): Likewise.
7319
7320 * xfns.c: Make symbols static if they're not exported.
7321 (x_last_font_name, x_display_info_for_name):
7322 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7323 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7324 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7325 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7326 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7327 (last_show_tip_args): Now static.
7328 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7329 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7330 (x_screen_planes): Remove; unused.
7331 * dispextern.h (x_screen_planes): Remove decl.
7332
7333 * dispnew.c: Make symbols static if they're not exported.
7334 * dispextern.h (redraw_garbaged_frames, scrolling):
7335 (increment_row_positions): Remove.
7336 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7337 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7338 Now static.
7339 (redraw_garbaged_frames): Remove; unused.
7340
7341 * xfaces.c: Make symbols static if they're not exported.
7342 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7343 Remove decls.
7344 * xterm.h (defined_color): Remove decls.
7345 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7346 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7347 (menu_face_changed_default, defined_color, free_realized_face):
7348 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7349 (ascii_face_of_lisp_face): Remove; unused.
7350
7351 * xdisp.c: Make symbols static if they're not exported.
7352 * dispextern.h (scratch_glyph_row, window_box_edges):
7353 (glyph_to_pixel_coords, set_cursor_from_row):
7354 (get_next_display_element, set_iterator_to_next):
7355 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7356 (show_mouse_face): Remove decls
7357 * frame.h (message_buf_print): Likewise.
7358 * lisp.h (pop_message, set_message, check_point_in_composition):
7359 Likewise.
7360 * xterm.h (set_vertical_scroll_bar): Likewise.
7361 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7362 (message_buf_print, scratch_glyph_row, displayed_buffer):
7363 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7364 (get_next_display_element, show_mouse_face, window_box_edges):
7365 (frame_to_window_pixel_xy, check_point_in_composition):
7366 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7367 (glyph_to_pixel_coords): Remove; unused.
7368
7369 * dired.c (file_name_completion): Now static.
7370
7371 * dbusbind.c (xd_in_read_queued_messages): Now static.
7372
7373 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7374 * data.c (circular_list_error): Remove.
7375
7376 * commands.h (last_point_position, last_point_position_buffer):
7377 (last_point_position_window): Remove decls.
7378 * keyboard.c: Make these variables static.
7379
7380 * coding.h (coding, code_convert_region, encode_coding_gap):
7381 Remove decls.
7382 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7383 (iso_code_class, detect_coding, code_convert_region): Now static.
7384 (encode_coding_gap): Remove; unused.
7385
7386 * chartab.c (chartab_chars, chartab_bits): Now static.
7387
7388 * charset.h (charset_iso_8859_1): Remove decl.
7389 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7390 Now static.
7391
7392 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7393 * ccl.c (Vccl_program_table): Now static.
7394 (check_ccl_update): Remove; unused.
7395
7396 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7397 * category.h: ... from here.
7398 * category.c (check_category_table, set_category_set): Now static.
7399
7400 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7401 * lisp.h: Remove these decls.
7402
7403 * buffer.c (buffer_count): Remove unused var.
7404
7405 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7406 so that it's not optimized away.
7407 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7408 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7409 exported only to the debugger.
7410
7411 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7412 * atimer.h (run_all_atimers): Remove; not exported.
7413
7414 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7415 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7416 was inaccessible from Lisp.
7417 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7418 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7419
7420 alloc.c: Import and export fewer symbols, and remove unused items.
7421 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7422 is defined.
7423 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7424 it's not optimized away by whole-program optimization.
7425 (message_enable_multibyte, free_misc): Remove.
7426 (catchlist, handlerlist, mark_backtrace):
7427 Declare only if BYTE_MARK_STACK.
7428 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7429 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7430 (message_enable_multibyte): Remove decl.
7431 (free_misc, interval_free_list, float_block, float_block_index):
7432 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7433 (cons_free_list, last_marked_index):
7434 Now static.
7435 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7436 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7437 (mark_backtrace): Define only if BYTE_MARK_STACK.
7438 * xdisp.c (message_enable_multibyte): Now static.
7439
7440 Declare Lisp_Object Q* variables to be 'static' if not exported.
7441 This makes it easier for human readers (and static analyzers)
7442 to see whether these variables are used from other modules.
7443 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7444 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7445 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7446 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7447 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7448 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7449 * xmenu.c, xselect.c:
7450 Declare Q* vars static if they are not used in other modules.
7451 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7452 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7453 Remove decls of unexported vars.
7454 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7455
7456 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7457
7458 Make Emacs functions such as Fatom 'static' by default.
7459 This makes it easier for human readers (and static analyzers)
7460 to see whether these functions can be called from other modules.
7461 DEFUN now defines a static function. To make the function external
7462 so that it can be used in other C modules, use the new macro DEFUE.
7463 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7464 (Finit_image_library):
7465 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7466 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7467 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7468 Remove decls, since these functions are now static.
7469 (Funintern, Fget_internal_run_time): New decls, since these functions
7470 were already external.
7471
7472 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7473 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7474 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7475 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7476 * keyboard.c, keymap.c, lread.c:
7477 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7478 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7479 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7480 Mark functions with DEFUE instead of DEFUN,
7481 if they are used in other modules.
7482 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7483 decls for now-static functions.
7484 * buffer.h (Fdelete_overlay): Remove decl.
7485 * callproc.c (Fgetenv_internal): Mark as internal.
7486 * composite.c (Fremove_list_of_text_properties): Remove decl.
7487 (Fcomposition_get_gstring): New forward static decl.
7488 * composite.h (Fcomposite_get_gstring): Remove decl.
7489 * dired.c (Ffile_attributes): New forward static decl.
7490 * doc.c (Fdocumntation_property): New forward static decl.
7491 * eval.c (Ffetch_bytecode): New forward static decl.
7492 (Funintern): Remove extern decl; now in .h file where it belongs.
7493 * fileio.c (Fmake_symbolic_link): New forward static decl.
7494 * image.c (Finit_image_library): New forward static decl.
7495 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7496 * intervals.h (Fprevious_property_change):
7497 (Fremove_list_of_text_properties): Remove decls.
7498 * keyboard.c (Fthis_command_keys): Remove decl.
7499 (Fcommand_execute): New forward static decl.
7500 * keymap.c (Flookup_key): New forward static decl.
7501 (Fcopy_keymap): Now static.
7502 * keymap.h (Flookup_key): Remove decl.
7503 * process.c (Fget_process): New forward static decl.
7504 (Fprocess_datagram_address): Mark as internal.
7505 * syntax.c (Fsyntax_table_p): New forward static decl.
7506 (skip_chars): Remove duplicate decl.
7507 * textprop.c (Fprevious_property_change): New forward static decl.
7508 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7509 Now internal.
7510 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7511 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7512
7513 * editfns.c (Fformat): Remove unreachable code.
7514
7515 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7516
7517 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7518 change. (Bug#8496)
7519
7520 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7521
7522 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7523 when at ZV. (Bug#8487)
7524
7525 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7526
7527 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7528 (Bug#8437)
7529 * keyboard.c (parse_tool_bar_item): Likewise.
7530 * sound.c (sound_cleanup, alsa_close): Likewise.
7531 * termcap.c (tgetent): Likewise.
7532 * xfns.c (x_default_font_parameter): Likewise.
7533 * xsettings.c (read_and_apply_settings): Likewise.
7534
7535 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7536 (overrun_check_free): Protoize.
7537
7538 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7539
7540 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7541 since callers should never pass a negative size.
7542 Change the signature to match that of plain 'read' and 'write'; see
7543 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7544 * lisp.h: Update prototypes of emacs_write and emacs_read.
7545
7546 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7547
7548 * xdisp.c (redisplay_window): Don't try to determine the character
7549 position of the scroll margin if the window start point w->startp
7550 is outside the buffer's accessible region. (Bug#8468)
7551
7552 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7553
7554 Fix write-region and its subroutines for buffers > 2GB.
7555 * fileio.c (a_write, e_write): Modify declaration of arguments and
7556 local variables to support buffers larger than 2GB.
7557 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7558
7559 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7560 argument, local variables, and return value.
7561
7562 * lisp.h: Update prototypes of emacs_write and emacs_read.
7563
7564 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7565
7566 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7567
7568 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7569
7570 Fix more problems found by GCC 4.6.0's static checks.
7571
7572 * xdisp.c (vmessage): Use a better test for character truncation.
7573
7574 * charset.c (load_charset_map): <, not <=, for optimization,
7575 and to avoid potential problems with integer overflow.
7576 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7577 * casetab.c (set_identity, shuffle): Likewise.
7578 * editfns.c (Fformat): Likewise.
7579 * syntax.c (skip_chars): Likewise.
7580
7581 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7582 This also lets GCC 4.6.0 generate slightly better loop code.
7583
7584 * callint.c (Fcall_interactively): <, not <=, for optimization.
7585 (Fcall_interactively): Count the number of arguments produced,
7586 not the number of arguments given. This is simpler and lets GCC
7587 4.6.0 generate slightly better code.
7588
7589 * ftfont.c: Distingish more carefully between FcChar8 and char.
7590 The previous code passed unsigned char * to a functions like
7591 strlen and xstrcasecmp that expect char *, which does not
7592 conform to the C standard.
7593 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7594 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7595 char * when the C standard requires it.
7596
7597 * keyboard.c (read_char): Remove unused var.
7598
7599 * eval.c: Port to Windows vsnprintf (Bug#8435).
7600 Include <limits.h>.
7601 (SIZE_MAX): Define if the headers do not.
7602 (verror): Do not give up if vsnprintf returns a negative count.
7603 Instead, grow the buffer. This ports to Windows vsnprintf, which
7604 does not conform to C99. Problem reported by Eli Zaretskii.
7605 Also, simplify the allocation scheme, by avoiding the need for
7606 calling realloc, and removing the ALLOCATED variable.
7607
7608 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7609
7610 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7611 But keep the doprint source code for now, as we might revamp it
7612 and use it again (Bug#8435).
7613 * lisp.h (doprnt): Remove.
7614 * Makefile.in (base_obj): Remove doprnt.o.
7615 * deps.mk (doprnt.o): Remove.
7616
7617 error: Print 32- and 64-bit integers portably (Bug#8435).
7618 Without this change, on typical 64-bit hosts error ("...%d...", N)
7619 was used to print both 32- and 64-bit integers N, which relied on
7620 undefined behavior.
7621 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7622 New macro.
7623 * lisp.h (error, verror): Mark as printf-like functions.
7624 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7625 Report overflow in size calculations when allocating printf buffer.
7626 Do not truncate output string at its first null byte.
7627 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7628 Truncate the output at a character boundary, since vsnprintf does not
7629 do that.
7630 * charset.c (check_iso_charset_parameter): Convert internal
7631 character to string before calling 'error', since %c now has the
7632 printf meaning.
7633 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7634 overflow when computing char to be passed to 'error'. Do not
7635 pass Lisp_Object to 'error'; pass the integer instead.
7636 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7637 formatted with plain %d.
7638
7639 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7640
7641 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7642
7643 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7644
7645 * xterm.c (x_catch_errors): Remove duplicate declaration.
7646
7647 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7648
7649 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7650
7651 2011-04-10 Jim Meyering <meyering@redhat.com>
7652
7653 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7654 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7655 return ssize_t not "int", and use size_t as the buffer length.
7656 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7657 * gnutls.h: Update declarations.
7658 * process.c (read_process_output): Use ssize_t, to match.
7659 (send_process): Likewise.
7660
7661 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7662
7663 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7664
7665 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7666
7667 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7668 Use unsigned char, to match FcChar8 type definition.
7669
7670 * xterm.c (handle_one_xevent):
7671 * xmenu.c (create_and_show_popup_menu):
7672 * xselect.c (x_decline_selection_request)
7673 (x_reply_selection_request): Avoid type-punned deref of X events.
7674
7675 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7676
7677 Fix some uses of `int' instead of EMACS_INT.
7678 * search.c (string_match_1, fast_string_match)
7679 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7680 (scan_buffer, find_next_newline_no_quit)
7681 (find_before_next_newline, search_command, Freplace_match)
7682 (Fmatch_data): Make some `int' variables be EMACS_INT.
7683
7684 * xdisp.c (display_count_lines): 3rd argument and return value now
7685 EMACS_INT. All callers changed.
7686 (pint2hrstr): Last argument is now EMACS_INT.
7687
7688 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7689 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7690 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7691 (decode_coding_utf_16, decode_coding_emacs_mule)
7692 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7693 (decode_coding_ccl, decode_coding_charset)
7694 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7695 (decode_coding_iso_2022, decode_coding_emacs_mule)
7696 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7697 <char_offset, last_offset>: Declare EMACS_INT.
7698 (encode_coding_utf_8, encode_coding_utf_16)
7699 (encode_coding_emacs_mule, encode_invocation_designation)
7700 (encode_designation_at_bol, encode_coding_iso_2022)
7701 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7702 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7703 Declare EMACS_INT.
7704 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7705 (encode_invocation_designation): Last argument P_NCHARS is now
7706 EMACS_INT.
7707 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7708 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7709
7710 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7711 All users changed.
7712
7713 * ccl.c (Fccl_execute_on_string): Declare some variables
7714 EMACS_INT.
7715
7716 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7717
7718 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7719
7720 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7721
7722 * process.c (Fformat_network_address): Doc fix.
7723
7724 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7725
7726 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7727
7728 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7729
7730 * keyboard.c (read_char): Call Lisp function help-form-show,
7731 instead of using internal_with_output_to_temp_buffer.
7732 (Qhelp_form_show): New var.
7733 (syms_of_keyboard): Use DEFSYM macro.
7734
7735 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7736
7737 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7738
7739 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7740
7741 * process.c (Flist_processes): Remove to Lisp.
7742 (list_processes_1): Delete.
7743
7744 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7745
7746 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7747
7748 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7749
7750 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7751
7752 Fix more problems found by GCC 4.6.0's static checks.
7753
7754 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7755
7756 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7757
7758 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7759
7760 * xdisp.c (vmessage): Mark as a printf-like function.
7761
7762 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7763
7764 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7765
7766 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7767 printf-like functions.
7768 (tiff_load): Add casts to remove these marks before passing them
7769 to system-supplied API.
7770
7771 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7772
7773 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7774 This avoids several warnings with gcc -Wstrict-overflow.
7775 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7776 directly, rather than having caller test rule sign. This avoids
7777 some unnecessary tests.
7778 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7779 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7780 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7781
7782 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7783 (xfont_open): Avoid unnecessary tests.
7784
7785 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7786
7787 * composite.h, composite.c (composition_gstring_put_cache):
7788 Use EMACS_INT, not int, for length.
7789
7790 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7791 breaking out part of COMPOSITION_DECODE_RULE.
7792 (COMPOSITION_DECODE_RULE): Use it.
7793 * composite.c (get_composition_id): Remove unused local vars,
7794 by using the new macro.
7795
7796 * textprop.c (set_text_properties_1): Change while to do-while,
7797 since the condition is always true at first.
7798
7799 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7800 (interval_deletion_adjustment): Return unsigned value.
7801 All uses changed.
7802
7803 * process.c (list_processes_1, create_pty, read_process_output):
7804 (exec_sentinel): Remove vars that were set but not used.
7805 (create_pty): Remove unnecessary "volatile"s.
7806 (Fnetwork_interface_info): Avoid possibility of int overflow.
7807 (read_process_output): Do adaptive read buffering even if carryover.
7808 (read_process_output): Simplify nbytes computation if buffered.
7809
7810 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7811
7812 * syntax.c (scan_words): Remove var that was set but not used.
7813 (update_syntax_table): Use unsigned instead of int.
7814
7815 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7816 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7817 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7818
7819 * print.c (print_error_message): Avoid int overflow.
7820
7821 * font.c (font_list_entities): Redo for clarity,
7822 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7823
7824 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7825 (font_score): Avoid potential overflow in diff calculation.
7826
7827 * fns.c (substring_both): Remove var that is set but not used.
7828 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7829
7830 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7831
7832 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7833 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7834 can always succeed if overflow has undefined behavior.
7835
7836 * search.c (boyer_moore, wordify): Remove vars set but not used.
7837 (wordify): Omit three unnecessary tests.
7838
7839 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7840 All callers changed. This avoids the need for an unused var.
7841
7842 * casefiddle.c (casify_region): Remove var that is set but not used.
7843
7844 * dired.c (file_name_completion): Remove var that is set but not used.
7845
7846 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7847
7848 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7849 (Finsert_file_contents): Remove unnecessary code checking fd.
7850
7851 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7852 Check for integer overflow on size calculations.
7853
7854 * buffer.c (Fprevious_overlay_change): Remove var that is set
7855 but not used.
7856
7857 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7858 Remove vars that are set but not used.
7859 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7860 (timer_check_2): Mark vars as initialized.
7861
7862 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7863
7864 * image.c (lookup_image): Remove var that is set but not used.
7865 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7866
7867 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7868 that are set but not used.
7869
7870 * xfns.c (make_invisible_cursor): Don't return garbage
7871 if XCreateBitmapFromData fails (Bug#8410).
7872
7873 * xselect.c (x_get_local_selection, x_handle_property_notify):
7874 Remove vars that are set but not used.
7875
7876 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7877 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7878
7879 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7880 Remove var that is set but not used.
7881 (scroll_bar_windows_size): Now size_t, not int.
7882 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7883 Check for overflow.
7884
7885 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7886 (map_tty_color) [!defined MSDOS]: Likewise.
7887
7888 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7889
7890 * coding.c: Remove vars that are set but not used.
7891 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7892 All callers changed.
7893 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7894 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7895 (decode_coding_charset): Remove vars that are set but not used.
7896
7897 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7898 that is set but not used.
7899
7900 * print.c (print_object): Remove var that is set but not used.
7901
7902 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7903 The gnulib version avoids calling malloc in the usual case,
7904 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7905 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7906 * filelock.c (current_lock_owner): Likewise.
7907 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7908 * sysdep.c: Include allocator.h, careadlinkat.h.
7909 (emacs_no_realloc_allocator): New static constant.
7910 (emacs_readlink): New function.
7911 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7912 ../lib/careadlinkat.h.
7913
7914 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7915
7916 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7917 first non-nil return value).
7918
7919 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7920
7921 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7922 if not defined (Bug#8403).
7923
7924 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7925
7926 * xdisp.c (display_count_lines): Remove parameter `start',
7927 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7928 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7929 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7930 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7931 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7932 and thereabouts. All callers changed.
7933 (get_per_char_metric): Remove parameter `f', unused since
7934 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7935
7936 2011-04-02 Jim Meyering <meyering@redhat.com>
7937
7938 do not dereference NULL upon failed strdup
7939 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7940 (ns_get_family): Likewise.
7941
7942 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7943
7944 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7945
7946 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7947
7948 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7949 later (Bug#8403).
7950
7951 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7952
7953 Add lexical binding.
7954
7955 * window.c (Ftemp_output_buffer_show): New fun.
7956 (Fsave_window_excursion):
7957 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7958
7959 * lread.c (lisp_file_lexically_bound_p): New function.
7960 (Fload): Bind Qlexical_binding.
7961 (readevalloop): Remove `evalfun' arg.
7962 Bind Qinternal_interpreter_environment.
7963 (Feval_buffer): Bind Qlexical_binding.
7964 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7965 Mark as dynamic.
7966 (syms_of_lread): Declare `lexical-binding'.
7967
7968 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7969
7970 * keyboard.c (eval_dyn): New fun.
7971 (menu_item_eval_property): Use it.
7972
7973 * image.c (parse_image_spec): Use Ffunctionp.
7974
7975 * fns.c (concat, mapcar1): Accept byte-code-functions.
7976
7977 * eval.c (Fsetq): Handle lexical vars.
7978 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7979 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7980 (FletX, Flet): Obey lexical binding.
7981 (Fcommandp): Handle closures.
7982 (Feval): New `lexical' arg.
7983 (eval_sub): New function extracted from Feval. Use it almost
7984 everywhere where Feval was used. Look up vars in lexical env.
7985 Handle closures.
7986 (Ffunctionp): Move from subr.el.
7987 (Ffuncall): Handle closures.
7988 (apply_lambda): Remove `eval_flags'.
7989 (funcall_lambda): Handle closures and new byte-code-functions.
7990 (Fspecial_variable_p): New function.
7991 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7992 but without exporting it to Lisp.
7993
7994 * doc.c (Fdocumentation, store_function_docstring):
7995 * data.c (Finteractive_form): Handle closures.
7996
7997 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7998 interactive spec.
7999
8000 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8001 New byte-codes.
8002 (exec_byte_code): New function extracted from Fbyte_code to handle new
8003 calling convention for byte-code-functions. Add new byte-codes.
8004
8005 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8006
8007 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8008
8009 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8010
8011 * xdisp.c (redisplay_internal): Fix prototype.
8012
8013 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8014
8015 * xdisp.c (SCROLL_LIMIT): New macro.
8016 (try_scrolling): Use it when setting scroll_limit.
8017 Limit scrolling to 100 screen lines.
8018 (redisplay_window): Even when falling back on "recentering",
8019 position point in the window according to scroll-conservatively,
8020 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8021
8022 (try_scrolling): When point is above the window, allow searching
8023 as far as scroll_max, or one screenful, to compute vertical
8024 distance from PT to the scroll margin position. This prevents
8025 try_scrolling from unnecessarily failing when
8026 scroll-conservatively is set to a value slightly larger than the
8027 window height. Clean up the case of PT below the margin at bottom
8028 of window: scroll_max can no longer be INT_MAX. When aggressive
8029 scrolling is in use, don't let point enter the opposite scroll
8030 margin as result of the scroll.
8031 (syms_of_xdisp) <scroll-conservatively>: Document the
8032 threshold of 100 lines for never-recentering scrolling.
8033
8034 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8035
8036 * dispextern.h (move_it_by_lines):
8037 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8038 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8039 (message_log_check_duplicate): Remove parameters `prev_bol' and
8040 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8041 (redisplay_internal): Remove parameter `preserve_echo_area',
8042 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8043
8044 * indent.c (Fvertical_motion):
8045 * window.c (window_scroll_pixel_based, Frecenter):
8046 Don't pass `need_y_p' to `move_it_by_lines'.
8047
8048 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8049
8050 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8051 steal a few bits to be more compact.
8052 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8053 Remove unneeded casts.
8054
8055 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8056
8057 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8058
8059 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8060 binding" message (bug#7967).
8061
8062 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8063
8064 Fix more problems found by GCC 4.6.0's static checks.
8065
8066 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8067 Remove unused local var.
8068
8069 * editfns.c (Fmessage_box): Remove unused local var.
8070
8071 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8072 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8073 Omit unused local vars.
8074 * window.c (shrink_windows): Omit unused local var.
8075 * menu.c (digest_single_submenu): Omit unused local var.
8076 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8077 Omit unused local var.
8078
8079 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8080 Don't assume string length fits in int.
8081 (keyremap_step, read_key_sequence): Use size_t for sizes.
8082 (read_key_sequence): Don't check last_real_key_start redundantly.
8083
8084 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8085 instead of alloca (Bug#8344).
8086
8087 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8088 (Fbacktrace_frame): Don't assume nframes fits in int.
8089
8090 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8091
8092 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8093 concerns.
8094
8095 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8096
8097 * cm.c (calccost): Turn while-do into do-while, for clarity.
8098
8099 * keyboard.c (syms_of_keyboard): Use the same style as later
8100 in this function when indexing through an array. This also
8101 works around GCC bug 48267.
8102
8103 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8104
8105 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8106
8107 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8108 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8109
8110 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8111 This avoids undefined behavior on integer overflow, and is a bit
8112 more convenient anyway since it is compared to a size_t variable.
8113
8114 Variadic C functions now count arguments with size_t, not int.
8115 This avoids an unnecessary limitation on 64-bit machines, which
8116 caused (substring ...) to crash on large vectors (Bug#8344).
8117 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8118 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8119 All variadic functions and their callers changed accordingly.
8120 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8121 * data.c (arith_driver, float_arith_driver): Likewise.
8122 * editfns.c (general_insert_function): Likewise.
8123 * eval.c (struct backtrace.nargs, interactive_p)
8124 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8125 (funcall_lambda, mark_backtrace): Likewise.
8126 * fns.c (concat): Likewise.
8127 * frame.c (x_set_frame_parameters): Likewise.
8128 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8129 0 if not found, not -1. All callers changed.
8130
8131 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8132 (stack_copy_size): Now size_t, not int.
8133 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8134
8135 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8136
8137 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8138 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8139 All callers changed.
8140
8141 * lisp.h (multibyte_char_to_unibyte):
8142 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8143 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8144 * character.h (CHAR_TO_BYTE8):
8145 * cmds.c (internal_self_insert):
8146 * editfns.c (general_insert_function):
8147 * keymap.c (push_key_description):
8148 * search.c (Freplace_match):
8149 * xdisp.c (message_dolog, set_message_1): All callers changed.
8150
8151 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8152
8153 * keyboard.c (safe_run_hook_funcall): New function.
8154 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8155 don't set the hook to nil, but remove the offending function instead.
8156 (Qcommand_hook_internal): Remove, unused.
8157 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8158 Vcommand_hook_internal.
8159
8160 * eval.c (enum run_hooks_condition): Remove.
8161 (funcall_nil, funcall_not): New functions.
8162 (run_hook_with_args): Call each function through a `funcall' argument.
8163 Remove `cond' argument, now redundant.
8164 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8165 (Frun_hook_with_args_until_failure): Adjust accordingly.
8166 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8167
8168 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8169
8170 * dispextern.h (string_buffer_position): Remove declaration.
8171
8172 * print.c (strout): Remove parameter `multibyte', unused since
8173 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8174
8175 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8176 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8177 All callers changed.
8178
8179 * w32.c (_wsa_errlist): Use braces for struct initializers.
8180
8181 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8182 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8183 All callers changed.
8184 (string_buffer_position): Likewise. Also, make static (it's never
8185 used outside xdisp.c).
8186 (cursor_row_p): Remove parameter `w', unused since
8187 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8188 (decode_mode_spec): Remove parameter `precision', introduced during
8189 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8190 All callers changed.
8191
8192 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8193
8194 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8195
8196 2011-03-27 Anders Lindgren <andlind@gmail.com>
8197
8198 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8199 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8200 (ns_update_auto_hide_menu_bar): New functions.
8201 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8202 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8203 ns_constrain_all_frames.
8204 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8205 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8206
8207 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8208
8209 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8210
8211 2011-03-27 Glenn Morris <rgm@gnu.org>
8212
8213 * syssignal.h: Replace RETSIGTYPE with void.
8214 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8215 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8216 Replace SIGTYPE with void everywhere.
8217 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8218 * s/template.h (SIGTYPE): Remove commented out definition.
8219
8220 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8221
8222 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8223 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8224
8225 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8226
8227 * w32.c (read_unc_volume): Use parameter `henum', instead of
8228 global variable `wget_enum_handle'.
8229
8230 * keymap.c (describe_vector): Remove parameters `indices' and
8231 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8232 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8233
8234 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8235
8236 * keyboard.c (timer_check): Remove parameter `do_it_now',
8237 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8238 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8239 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8240
8241 * keyboard.c (read_char):
8242 * w32menu.c (w32_menu_display_help):
8243 * xmenu.c (show_help_event, menu_help_callback):
8244 Adjust calls to `show_help_echo'.
8245
8246 * gtkutil.c (xg_maybe_add_timer):
8247 * keyboard.c (readable_events):
8248 * process.c (wait_reading_process_output):
8249 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8250
8251 * insdel.c (adjust_markers_gap_motion):
8252 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8253 (gap_left, gap_right): Don't call it.
8254
8255 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8256
8257 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8258 incurred during fontification.
8259
8260 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8261
8262 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8263 (DEFVAR_PER_BUFFER): Don't pass it.
8264
8265 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8266 (scrolling_window): Don't pass it.
8267
8268 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8269
8270 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8271
8272 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8273 and `suffix'.
8274 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8275 of variables specific to SELinux and computation of `encoded_absname'.
8276
8277 * image.c (XPutPixel): Remove unused variable `height'.
8278
8279 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8280
8281 * unexw32.c (get_section_info): Remove unused variable `section'.
8282
8283 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8284 (system_process_attributes): Remove unused variable `sess'.
8285 (sys_read): Remove unused variable `err'.
8286
8287 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8288 (w32_wnd_proc): Remove unused variable `isdead'.
8289 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8290 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8291 (x_create_tip_frame): Remove unused variable `tem'.
8292
8293 * w32inevt.c (w32_console_read_socket):
8294 Remove unused variable `no_events'.
8295
8296 * w32term.c (x_draw_composite_glyph_string_foreground):
8297 Remove unused variable `width'.
8298
8299 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8300
8301 * w32term.c (x_set_glyph_string_clipping):
8302 Don't pass uninitialized region to CombineRgn.
8303
8304 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8305
8306 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8307 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8308 (Fx_close_connection): Remove unused variable `i'.
8309
8310 * w32font.c (w32font_draw): Return number of glyphs.
8311 (w32font_open_internal): Remove unused variable `i'.
8312 (w32font_driver): Add missing initializer.
8313
8314 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8315 (fill_in_menu): Remove unused variable `items_added'.
8316
8317 * w32term.c (last_mouse_press_frame): Remove static global variable.
8318 (w32_clip_to_row): Remove unused variable `f'.
8319 (x_delete_terminal): Remove unused variable `i'.
8320
8321 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8322 (NOTHING): Remove unused static global variable.
8323 (uniscribe_check_otf): Remove unused variable `table'.
8324 (uniscribe_font_driver): Add missing initializers.
8325
8326 2011-03-23 Julien Danjou <julien@danjou.info>
8327
8328 * term.c (Fsuspend_tty, Fresume_tty):
8329 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8330 * window.c (temp_output_buffer_show):
8331 * insdel.c (signal_before_change):
8332 * frame.c (Fhandle_switch_frame):
8333 * fileio.c (Fdo_auto_save):
8334 * emacs.c (Fkill_emacs):
8335 * editfns.c (save_excursion_restore):
8336 * cmds.c (internal_self_insert):
8337 * callint.c (Fcall_interactively):
8338 * buffer.c (Fkill_all_local_variables):
8339 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8340 Use Frun_hooks.
8341 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8342 unconditionally since it does the check itself.
8343
8344 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8345
8346 Fix more problems found by GCC 4.5.2's static checks.
8347
8348 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8349 the first time through the loop, since we know p0 < p1 then.
8350 This also avoids a gcc -Wstrict-overflow warning.
8351
8352 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8353 leading to a memory leak, possible in functions like
8354 load_charset_map_from_file that can allocate an unbounded number
8355 of objects (Bug#8318).
8356
8357 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8358 that could (at least in theory) be that large.
8359
8360 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8361 This is less likely to overflow, and avoids undefined behavior if
8362 overflow does occur. All callers changed. Use strtoul to scan
8363 for the unsigned long integer.
8364 (pint2hrstr): Simplify and tune code slightly.
8365 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8366
8367 * scroll.c (do_scrolling): Work around GCC bug 48228.
8368 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8369
8370 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8371 This also avoids a warning with gcc -Wstrict-overflow.
8372 (validate_x_resource_name): Simplify count usage.
8373 This also avoids a warning with gcc -Wstrict-overflow.
8374
8375 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8376 fail (Bug#8306).
8377
8378 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8379
8380 * process.c (Fmake_network_process): Use socklen_t, not int,
8381 where POSIX says socklen_t is required in portable programs.
8382 This fixes a porting bug on hosts like 64-bit HP-UX, where
8383 socklen_t is wider than int (Bug#8277).
8384 (Fmake_network_process, server_accept_connection):
8385 (wait_reading_process_output, read_process_output):
8386 Likewise.
8387
8388 * process.c: Rename or move locals to avoid shadowing.
8389 (list_processes_1, Fmake_network_process):
8390 (read_process_output_error_handler, exec_sentinel_error_handler):
8391 Rename or move locals.
8392 (Fmake_network_process): Define label "retry_connect" only if needed.
8393 (Fnetwork_interface_info): Fix pointer signedness.
8394 (process_send_signal): Add cast to avoid pointer signedness problem.
8395 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8396 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8397
8398 Make tparam.h and terminfo.c consistent.
8399 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8400 Include tparam.h instead, since it declares them.
8401 * cm.h (PC): Remove extern decl; tparam.h now does this.
8402 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8403 * terminfo.c: Include tparam.h, to check interfaces.
8404 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8405 (tparam): Adjust signature to match interface in tparam.h;
8406 this removes some undefined behavior. Check that outstring and len
8407 are zero, which they always are with Emacs.
8408 * tparam.h (PC, BC, UP): New extern decls.
8409
8410 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8411 (xftfont_open): Rename locals to avoid shadowing.
8412
8413 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8414 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8415 (OTF_TAG_SYM): Omit macro if not needed.
8416 (ftfont_list): Remove unused local.
8417 (get_adstyle_property, ftfont_pattern_entity):
8418 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8419 Rename locals to avoid shadowing.
8420
8421 * xfont.c (xfont_list_family): Mark var as initialized.
8422
8423 * xml.c (make_dom): Now static.
8424
8425 * composite.c (composition_compute_stop_pos): Rename local to
8426 avoid shadowing.
8427 (composition_reseat_it): Remove unused locals.
8428 (find_automatic_composition, composition_adjust_point): Likewise.
8429 (composition_update_it): Mark var as initialized.
8430 (find_automatic_composition): Mark vars as initialized,
8431 with a FIXME (Bug#8290).
8432
8433 character.h: Rename locals to avoid shadowing.
8434 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8435 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8436 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8437 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8438 to avoid shadowing.
8439
8440 * textprop.c (property_change_between_p): Remove; unused.
8441
8442 * intervals.c (interval_start_pos): Now static.
8443
8444 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8445
8446 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8447 Rename locals to avoid shadowing.
8448
8449 * sound.c (wav_play, au_play, Fplay_sound_internal):
8450 Fix pointer signedness.
8451 (alsa_choose_format): Remove unused local var.
8452 (wav_play): Initialize a variable to 0, to prevent undefined
8453 behavior (Bug#8278).
8454
8455 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8456
8457 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8458
8459 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8460 clobbering (Bug#8298).
8461 * sysdep.c (sys_subshell): Likewise.
8462 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8463
8464 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8465 This should get cleaned up, so that child_setup has the
8466 same signature on all platforms.
8467
8468 * callproc.c (call_process_cleanup): Now static.
8469 (relocate_fd): Rename locals to avoid shadowing.
8470
8471 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8472
8473 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8474 not to be necessary, and produces flickering.
8475
8476 2011-03-20 Glenn Morris <rgm@gnu.org>
8477
8478 * config.in: Remove file.
8479
8480 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8481
8482 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8483 are now in src/globals.h.
8484 (syms_of_minibuf): Remove spurious & from previous change.
8485
8486 2011-03-20 Leo Liu <sdl.web@gmail.com>
8487
8488 * minibuf.c (completing-read-function): New variable.
8489 (completing-read-default): Rename from completing-read.
8490 (completing-read): Call completing-read-function.
8491
8492 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8493
8494 * xfaces.c (Fx_load_color_file):
8495 Read color file from absolute filename (bug#8250).
8496
8497 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8498
8499 * makefile.w32-in: Update dependencies.
8500
8501 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8502
8503 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8504
8505 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8506
8507 Fix more problems found by GCC 4.5.2's static checks.
8508
8509 * process.c (make_serial_process_unwind, send_process_trap):
8510 (sigchld_handler): Now static.
8511
8512 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8513 That way, the code declares only the vars that it needs.
8514 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8515 * s/cygwin.h (PTY_ITERATION): Likewise.
8516 * s/darwin.h (PTY_ITERATION): Likewise.
8517 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8518
8519 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8520 * process.c (allocate_pty): Don't declare stb unless it's needed.
8521
8522 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8523 (CONSTANTLIM): Remove; unused.
8524 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8525 Define only if needed.
8526
8527 * unexelf.c (unexec): Name an expression,
8528 to avoid gcc -Wbad-function-cast warning.
8529 Use a different way to cause a compilation error if anyone uses
8530 n rather than nn, a way that does not involve shadowing.
8531 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8532
8533 * deps.mk (unexalpha.o): Remove; unused.
8534
8535 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8536 * unexec.h: New file.
8537 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8538 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8539 Depend on unexec.h.
8540 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8541 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8542 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8543 Change as necessary to match prototype in unexec.h.
8544
8545 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8546 shadowing.
8547 (back_comment, skip_chars): Mark vars as initialized.
8548
8549 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8550 Rename locals to avoid shadowing.
8551
8552 * lread.c (read1): Rewrite so as not to use empty "else".
8553 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8554
8555 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8556
8557 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8558 warning when compiling print.c.
8559
8560 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8561 instead of using an uninitialized var.
8562 (font_sort_entities): Mark var as initialized.
8563
8564 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8565
8566 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8567 pointers to constants.
8568 (font_parse_fcname): Remove unused vars.
8569 (font_delete_unmatched): Now static.
8570 (font_get_spec): Remove; unused.
8571 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8572 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8573 Rename or move locals to avoid shadowing.
8574
8575 * fns.c (require_nesting_list, require_unwind): Now static.
8576 (Ffillarray): Rename locals to avoid shadowing.
8577
8578 * floatfns.c (domain_error2): Define only if needed.
8579 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8580
8581 * alloc.c (mark_backtrace): Move decl from here ...
8582 * lisp.h: ... to here, so that it can be checked.
8583
8584 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8585 (Fdefvar): Rewrite so as not to use empty "else".
8586 (lisp_indirect_variable): Name an expression,
8587 to avoid gcc -Wbad-function-cast warning.
8588 (Fdefvar): Rename locals to avoid shadowing.
8589
8590 * callint.c (quotify_arg, quotify_args): Now static.
8591 (Fcall_interactively): Rename locals to avoid shadowing.
8592 Use const pointer when appropriate.
8593
8594 * lisp.h (get_system_name, get_operating_system_release):
8595 Move decls here, to check interfaces.
8596 * process.c (get_operating_system_release): Move decl to lisp.h.
8597 * xrdb.c (get_system_name): Likewise.
8598 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8599 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8600 some of which prompt warnings from gcc -Wbad-function-cast.
8601 (Fformat_time_string, Fencode_time, Finsert_char):
8602 (Ftranslate_region_internal, Fformat):
8603 Rename or remove local vars to avoid shadowing.
8604 (Ftranslate_region_internal): Mark var as initialized.
8605
8606 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8607 avoid shadowing.
8608
8609 * lisp.h (eassert): Check that the argument compiles, even if
8610 ENABLE_CHECKING is not defined.
8611
8612 * data.c (Findirect_variable): Name an expression, to avoid
8613 gcc -Wbad-function-cast warning.
8614 (default_value, arithcompare, arith_driver, arith_error): Now static.
8615 (store_symval_forwarding): Rename local to avoid shadowing.
8616 (Fmake_variable_buffer_local, Fmake_local_variable):
8617 Mark variables as initialized.
8618 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8619
8620 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8621 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8622 Rename locals to avoid shadowing.
8623 (mark_stack): Move local variables into the #ifdef region where
8624 they're used.
8625 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8626 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8627 needed otherwise.
8628 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8629 (GC_STRING_CHARS): Remove; not used.
8630 (Fmemory_limit): Cast sbrk's returned value to char *.
8631
8632 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8633 avoids undefined behavior in theory.
8634
8635 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8636
8637 Use functions, not macros, for up- and down-casing (Bug#8254).
8638 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8639 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8640 to use the following functions instead of these macros.
8641 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8642 EMACS_INT, since callers assume the returned value fits in int.
8643 (upcase1): Likewise, for UPCASE_TABLE.
8644 (uppercasep, lowercasep, upcase): New static inline functions.
8645 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8646 the race-condition problem in the old DOWNCASE.
8647
8648 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8649 Rename locals to avoid shadowing.
8650 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8651 (regex_compile, re_search_2, re_match_2_internal):
8652 Remove unused local vars.
8653 (FREE_VAR): Rewrite so as not to use empty "else",
8654 which gcc can warn about.
8655 (regex_compile, re_match_2_internal): Mark locals as initialized.
8656 (RETALLOC_IF): Define only if needed.
8657 (WORDCHAR_P): Likewise. This one is never needed, but is used
8658 only in a comment talking about a compiler bug, so put inside
8659 the #if 0 of that comment.
8660 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8661 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8662 Remove; unused.
8663
8664 * search.c (boyer_moore): Rename locals to avoid shadowing.
8665 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8666 (PREV_CHAR_BOUNDARY): Likewise.
8667
8668 * search.c (simple_search): Remove unused var.
8669
8670 * dired.c (compile_pattern): Move decl from here ...
8671 * lisp.h: ... to here, so that it can be checked.
8672 (struct re_registers): New forward decl.
8673
8674 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8675
8676 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8677 All uses changed.
8678 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8679 Rename locals to avoid shadowing.
8680 (Fvertical_motion): Mark locals as initialized.
8681
8682 * casefiddle.c (casify_object, casify_region): Now static.
8683 (casify_region): Mark local as initialized.
8684
8685 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8686
8687 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8688 New macros, so that the caller can use some names other than
8689 gcpro1, gcpro2, etc.
8690 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8691 of the new macros.
8692 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8693 argument, for consistency with GCPRO2_VAR, etc: it is now the
8694 prefix of the variable, not the variable itself. All uses
8695 changed.
8696 * dired.c (directory_files_internal, file_name_completion):
8697 Rename locals to avoid shadowing.
8698
8699 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8700 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8701 dired.c's scmp function, had undefined behavior.
8702 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8703 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8704 * buffer.h: ... to here, because these macros use current_buffer,
8705 and the new implementation with inline functions needs to have
8706 current_buffer in scope now, rather than later when the macros
8707 are used.
8708 (downcase, upcase1): New static inline functions.
8709 (DOWNCASE, UPCASE1): Reimplement using these functions.
8710 This avoids undefined behavior in expressions like
8711 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8712 from race conditions in accessing the global variables
8713 case_temp1 and case_temp2.
8714 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8715 * lisp.h (case_temp1, case_temp2): Remove their decls.
8716 * character.h (ASCII_CHAR_P): Move from here ...
8717 * lisp.h: ... to here, so that the inline functions mentioned
8718 above can use them.
8719
8720 * dired.c (directory_files_internal_unwind): Now static.
8721
8722 * fileio.c (file_name_as_directory, directory_file_name):
8723 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8724 Now static.
8725 (file_name_as_directory): Use const pointers when appropriate.
8726 (Fexpand_file_name): Likewise. In particular, newdir might
8727 point at constant storage, so make it a const pointer.
8728 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8729 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8730 signedness issues.
8731 (Fset_file_times, Finsert_file_contents, auto_save_error):
8732 Rename locals to avoid shadowing.
8733
8734 * minibuf.c (choose_minibuf_frame_1): Now static.
8735 (Ftry_completion, Fall_completions): Rename or remove locals
8736 to avoid shadowing.
8737
8738 * marker.c (bytepos_to_charpos): Remove; unused.
8739
8740 * lisp.h (verify_bytepos, count_markers): New decls,
8741 so that gcc does not warn that these functions aren't declared.
8742
8743 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8744 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8745 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8746 (copy_text): Remove unused local var.
8747
8748 * filelock.c (within_one_second): Now static.
8749 (lock_file_1): Rename local to avoid shadowing.
8750
8751 * buffer.c (fix_overlays_before): Mark locals as initialized.
8752 (fix_start_end_in_overlays): Likewise. This function should be
8753 simplified by using pointers-to-pointers, but that's a different
8754 matter.
8755 (switch_to_buffer_1): Now static.
8756 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8757 (report_overlay_modification): Rename locals to avoid shadowing.
8758
8759 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8760 Fix pointer signedness issue.
8761 (sys_subshell): Mark local as volatile if checking for lint,
8762 to suppress a gcc -Wclobbered warning that does not seem to be right.
8763 (MAXPATHLEN): Define only if needed.
8764
8765 * process.c (serial_open, serial_configure): Move decls from here ...
8766 * systty.h: ... to here, so that they can be checked.
8767
8768 * fns.c (get_random, seed_random): Move extern decls from here ...
8769 * lisp.h: ... to here, so that they can be checked.
8770
8771 * sysdep.c (reset_io): Now static.
8772 (wait_for_termination_signal): Remove; unused.
8773
8774 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8775 (copy_keymap_item, append_key, push_text_char_description):
8776 Now static.
8777 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8778 (DENSE_TABLE_SIZE): Remove; unused.
8779 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8780 (describe_map_tree):
8781 Rename locals to avoid shadowing.
8782
8783 * keyboard.c: Declare functions static if they are not used elsewhere.
8784 (echo_char, echo_dash, cmd_error, top_level_2):
8785 (poll_for_input, handle_async_input): Now static.
8786 (read_char, kbd_buffer_get_event, make_lispy_position):
8787 (make_lispy_event, make_lispy_movement, apply_modifiers):
8788 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8789 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8790 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8791 (read_key_sequence, read_char): Mark locals as initialized.
8792 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8793
8794 * keyboard.h (make_ctrl_char): New decl.
8795 (mark_kboards): Move decl here ...
8796 * alloc.c (mark_kboards): ... from here.
8797
8798 * lisp.h (force_auto_save_soon): New decl.
8799
8800 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8801 (DEFINE_DUMMY_FUNCTION): New macro.
8802 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8803 Use it.
8804 (main): Add casts to avoid warnings
8805 if GCC considers string literals to be constants.
8806
8807 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8808
8809 * dbusbind.c: Pointer signedness fixes.
8810 (xd_signature, xd_append_arg, xd_initialize):
8811 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8812 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8813 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8814 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8815
8816 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8817 if GCC considers string literals to be constants.
8818 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8819
8820 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8821
8822 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8823 (print_preprocess, print_object): New macro to fix last change.
8824
8825 * print.c (print_preprocess): Don't forget font objects.
8826
8827 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8828
8829 * emacs.c (USAGE3): Doc fixes.
8830
8831 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8832
8833 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8834 structure.
8835
8836 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8837
8838 * lisp.h (VWindow_system, Qfile_name_history):
8839 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8840 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8841 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8842
8843 * w32select.c: Don't #include "keyboard.h".
8844 (run_protected): Add extern declaration for waiting_for_input.
8845
8846 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8847 * w32console.c (detect_input_pending, read_input_pending)
8848 (encode_terminal_code):
8849 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8850 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8851 (w32_system_caret_y, Qfile_name_history):
8852 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8853 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8854 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8855 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8856 * w32proc.c (Qlocal, report_file_error):
8857 * w32term.c (Vwindow_system, updating_frame):
8858 * w32uniscribe.c (initialized, uniscribe_font_driver):
8859 Remove unneeded extern declarations.
8860
8861 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8862
8863 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8864
8865 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8866
8867 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8868 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8869 These macros can no longer be used for assignment.
8870
8871 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8872 Assign struct members directly, instead of using BUF_BEGV etc.
8873 (record_buffer_markers, fetch_buffer_markers): New functions for
8874 recording and fetching special buffer markers.
8875 (set_buffer_internal_1, set_buffer_temp): Use them.
8876
8877 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8878
8879 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8880
8881 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8882 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8883
8884 * xdisp.c (hscroll_window_tree):
8885 (reconsider_clip_changes): Use PT instead of BUF_PT.
8886
8887 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8888
8889 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8890 $(EMACS_ROOT)/lib/intprops.h.
8891
8892 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8893
8894 Fix more problems found by GCC 4.5.2's static checks.
8895
8896 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8897 to unsigned char * to avoid compiler diagnostic.
8898 (xg_free_frame_widgets): Make it clear that a local variable is
8899 needed only if USE_GTK_TOOLTIP.
8900 (gdk_window_get_screen): Make it clear that this macro is needed
8901 only if USE_GTK_TOOLTIP.
8902 (int_gtk_range_get_value): New function, which avoids a diagnostic
8903 from gcc -Wbad-function-cast.
8904 (xg_set_toolkit_scroll_bar_thumb): Use it.
8905 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8906 diagnostic from gcc -Wbad-function-cast.
8907 (get_utf8_string, xg_get_file_with_chooser):
8908 Rename locals to avoid shadowing.
8909 (create_dialog): Move locals to avoid shadowing.
8910
8911 * xgselect.c (xg_select): Remove unused var.
8912
8913 * image.c (four_corners_best): Mark locals as initialized.
8914 (gif_load): Initialize transparent_p to zero (Bug#8238).
8915 Mark another local as initialized.
8916 (my_png_error, my_error_exit): Mark with NO_RETURN.
8917
8918 * image.c (clear_image_cache): Now static.
8919 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8920 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8921 (x_edge_detection): Remove unnecessary cast that
8922 gcc -Wbad-function-cast diagnoses.
8923 (gif_load): Fix pointer signedness.
8924 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8925 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8926
8927 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8928
8929 Improve quality of tests for time stamp overflow.
8930 For example, without this patch (encode-time 0 0 0 1 1
8931 1152921504606846976) returns the obviously-bogus value (-948597
8932 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8933 reports time overflow. See
8934 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8935 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8936 * editfns.c: Include limits.h and intprops.h.
8937 (TIME_T_MIN, TIME_T_MAX): New macros.
8938 (time_overflow): Move earlier, to before first use.
8939 (hi_time, lo_time): New functions, for an accurate test for
8940 out-of-range times.
8941 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8942 (Fget_internal_run_time): Don't assume time_t fits in int.
8943 (make_time): Use list2 instead of Fcons twice.
8944 (Fdecode_time): More accurate test for out-of-range times.
8945 (check_tm_member): New function.
8946 (Fencode_time): Use it, to test for out-of-range times.
8947 (lisp_time_argument): Don't rely on undefined left-shift and
8948 right-shift behavior when checking for time stamp overflow.
8949
8950 * editfns.c (time_overflow): New function, refactoring common code.
8951 (Fformat_time_string, Fdecode_time, Fencode_time):
8952 (Fcurrent_time_string): Use it.
8953
8954 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8955 * dired.c (make_time): Move to ...
8956 * editfns.c (make_time): ... here.
8957 * systime.h: Note the move.
8958
8959 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8960
8961 * fringe.c (update_window_fringes): Remove unused variables.
8962
8963 * unexmacosx.c (copy_data_segment): Also copy __got section.
8964 (Bug#8223)
8965
8966 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8967
8968 * termcap.c [MSDOS]: Include "msdos.h".
8969 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8970 Constify `char *' arguments and their references according to
8971 prototypes in tparam.h.
8972
8973 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8974
8975 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8976 Adapt all references accordingly.
8977
8978 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8979
8980 2011-03-11 Tom Tromey <tromey@redhat.com>
8981
8982 * buffer.c (syms_of_buffer): Remove obsolete comment.
8983
8984 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8985
8986 * termhooks.h (encode_terminal_code): Declare prototype.
8987
8988 * msdos.c (encode_terminal_code): Don't declare prototype.
8989
8990 * term.c (encode_terminal_code): Now external again, used by
8991 w32console.c and msdos.c.
8992
8993 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8994 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8995
8996 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8997
8998 Fix some minor problems found by GCC 4.5.2's static checks.
8999
9000 * fringe.c (update_window_fringes): Mark locals as initialized
9001 (Bug#8227).
9002 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9003
9004 * alloc.c (mark_fringe_data): Move decl from here ...
9005 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9006 to check its interface.
9007 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9008
9009 * fontset.c (free_realized_fontset): Now static.
9010 (Fset_fontset_font): Rename local to avoid shadowing.
9011 (fontset_font): Mark local as initialized.
9012 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9013
9014 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9015
9016 * xselect.c (x_disown_buffer_selections): Remove; not used.
9017 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9018 (x_own_selection, Fx_disown_selection_internal): Rename locals
9019 to avoid shadowing.
9020 (x_handle_dnd_message): Remove local to avoid shadowing.
9021
9022 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9023 so that the caller can use some name other than gcpro1.
9024 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9025 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9026 (Fx_backspace_delete_keys_p):
9027 Use them to avoid shadowing, and rename vars to avoid shadowing.
9028 (x_decode_color, x_set_name, x_window): Now static.
9029 (Fx_create_frame): Add braces to silence GCC warning.
9030 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9031 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9032 Remove unused locals.
9033 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9034 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9035 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9036 macros.
9037
9038 * xterm.h (x_mouse_leave): New decl.
9039
9040 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9041 Remove unused functions.
9042 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9043 (x_calc_absolute_position): Now static.
9044 (XTread_socket): Don't define label "out" unless it's used.
9045 Don't declare local "event" unless it's used.
9046 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9047 unless they are used.
9048 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9049 (x_fatal_error_signal): Remove; not used.
9050 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9051 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9052 (x_error_catcher, x_connection_closed, x_error_handler):
9053 (x_error_quitter, xembed_send_message, x_iconify_frame):
9054 (my_log_handler): Rename locals to avoid shadowing.
9055 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9056 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9057
9058 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9059 Rename or move locals to avoid shadowing.
9060 (tty_defined_color, merge_face_heights): Now static.
9061 (free_realized_faces_for_fontset): Remove; not used.
9062 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9063 does not deduce is never used uninitialized.
9064 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9065 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9066
9067 * terminal.c (store_terminal_param): Now static.
9068
9069 * xmenu.c (menu_highlight_callback): Now static.
9070 (set_frame_menubar): Remove unused local.
9071 (xmenu_show): Rename parameter to avoid shadowing.
9072 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9073 since they might point to immutable storage.
9074 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9075 since it's unused otherwise.
9076
9077 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9078 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9079 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9080 avoids a gcc -Wuninitialized diagnostic.
9081 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9082 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9083 does not deduce are never used uninitialized.
9084
9085 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9086
9087 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9088 * window.c (window_loop, size_window):
9089 (run_window_configuration_change_hook, enlarge_window): Likewise.
9090
9091 * window.c (display_buffer): Now static.
9092 (size_window): Mark variables that gcc -Wuninitialized
9093 does not deduce are never used uninitialized.
9094 * window.h (check_all_windows): New decl, to forestall
9095 gcc -Wmissing-prototypes diagnostic.
9096 * dispextern.h (bidi_dump_cached_states): Likewise.
9097
9098 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9099 shadowing.
9100 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9101 Include <limits.h>.
9102 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9103 and to avoid gcc -Wuninitialized warning.
9104 (load_charset_map): Mark variables that gcc -Wuninitialized
9105 does not deduce are never used uninitialized.
9106 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9107
9108 * coding.c (coding_set_source, coding_set_destination):
9109 Use "else { /* comment */ }" rather than "else /* comment */;"
9110 for clarity, and to avoid gcc -Wempty-body warning.
9111 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9112 a block, when the outer 'i' will do.
9113 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9114 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9115 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9116 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9117 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9118 Rename locals to avoid shadowing.
9119 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9120 * coding.c (emacs_mule_char, encode_invocation_designation):
9121 Now static, since they're not used elsewhere.
9122 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9123 (decode_coding_object, encode_coding_object, detect_coding_system):
9124 (decode_coding_emacs_mule): Mark variables that gcc
9125 -Wuninitialized does not deduce are never used uninitialized.
9126 (detect_coding_iso_2022): Initialize a local variable that might
9127 be used uninitialized. Leave a FIXME because it's not clear that
9128 this initialization is needed. (Bug#8211)
9129 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9130 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9131 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9132 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9133 Remove unused macros.
9134
9135 * category.c (hash_get_category_set): Remove unused local var.
9136 (copy_category_table): Now static, since it's not used elsewhere.
9137 * character.c (string_count_byte8): Likewise.
9138
9139 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9140 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9141
9142 * chartab.c (copy_sub_char_table): Now static, since it's not used
9143 elsewhere.
9144 (sub_char_table_ref_and_range, char_table_ref_and_range):
9145 Rename locals to avoid shadowing.
9146 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9147
9148 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9149 (BIDI_BOB): Remove unused macro.
9150
9151 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9152 deduce are never used uninitialized.
9153 * term.c (encode_terminal_code): Likewise.
9154
9155 * term.c (encode_terminal_code): Now static. Remove unused local.
9156
9157 * tparam.h: New file.
9158 * term.c, tparam.h: Include it.
9159 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9160 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9161 Move these decls to tparam.h, and make them agree with what
9162 is actually in tparam.c. The previous trick of using incompatible
9163 decls in different modules does not conform to the C standard.
9164 All callers of tparam changed to use tparam's actual API.
9165 * tparam.c (tparam1, tparam, tgoto):
9166 Use const pointers where appropriate.
9167
9168 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9169 * cm.h (struct cm): Likewise.
9170 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9171 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9172 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9173 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9174 (turn_on_face, init_tty): Likewise.
9175 * termchar.h (struct tty_display_info): Likewise.
9176
9177 * term.c (term_mouse_position): Rename local to avoid shadowing.
9178
9179 * alloc.c (mark_ttys): Move decl from here ...
9180 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9181
9182 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9183
9184 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9185
9186 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9187
9188 * search.c (compile_pattern_1): Remove argument regp, unused since
9189 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9190 (compile_pattern): Don't pass it.
9191
9192 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9193
9194 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9195 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9196 for ! HAVE_GTK3.
9197 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9198
9199 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9200
9201 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9202 gdk_window_get_screen, gdk_window_get_geometry,
9203 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9204 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9205 (xg_get_pixbuf_from_pixmap): New function.
9206 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9207 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9208 Call xg_get_pixbuf_from_pixmap instead of
9209 gdk_pixbuf_get_from_drawable.
9210 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9211 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9212 (xg_check_special_colors): Use GtkStyleContext and its functions
9213 for HAVE_GTK3.
9214 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9215 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9216 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9217 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9218 Call gtk_widget_get_preferred_size.
9219 (xg_frame_resized): gdk_window_get_geometry only takes 5
9220 parameters.
9221 (xg_win_to_widget, xg_event_is_for_menubar):
9222 Call gdk_x11_window_lookup_for_display.
9223 (xg_set_widget_bg): New function.
9224 (delete_cb): New function.
9225 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9226 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9227 (xg_set_background_color): Call xg_set_widget_bg.
9228 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9229 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9230 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9231 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9232 if ! HAVE_GTK3.
9233 (update_frame_tool_bar): Call gtk_widget_hide.
9234 (xg_initialize): Use GDK_KEY_g.
9235
9236 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9237 if ! HAVE_GTK3
9238 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9239
9240 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9241 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9242 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9243
9244 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9245
9246 * w32xfns.c (select_palette): Check success of RealizePalette against
9247 GDI_ERROR, not zero.
9248
9249 See ChangeLog.11 for earlier changes.
9250
9251 ;; Local Variables:
9252 ;; coding: utf-8
9253 ;; End:
9254
9255 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9256
9257 This file is part of GNU Emacs.
9258
9259 GNU Emacs is free software: you can redistribute it and/or modify
9260 it under the terms of the GNU General Public License as published by
9261 the Free Software Foundation, either version 3 of the License, or
9262 (at your option) any later version.
9263
9264 GNU Emacs is distributed in the hope that it will be useful,
9265 but WITHOUT ANY WARRANTY; without even the implied warranty of
9266 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9267 GNU General Public License for more details.
9268
9269 You should have received a copy of the GNU General Public License
9270 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.