1 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3 * image.c: Use ptrdiff_t, not int, for sizes.
4 (slurp_file): Switch from int to ptrdiff_t.
6 (slurp_file): Check that file size fits in both size_t (for
7 malloc) and ptrdiff_t (for sanity and safety).
9 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10 if b->modtime has its maximal value.
12 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
14 Don't assume time_t can fit into int.
15 * buffer.h (struct buffer.modtime): Now time_t, not int.
16 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
17 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
19 Minor fixes for signed vs unsigned integers.
20 * character.h (MAYBE_UNIFY_CHAR):
21 * charset.c (maybe_unify_char):
22 * keyboard.c (read_char, reorder_modifiers):
23 XINT -> XFASTINT, since the integer must be nonnegative.
24 * ftfont.c (ftfont_spec_pattern):
25 * keymap.c (access_keymap, silly_event_symbol_error):
26 XUINT -> XFASTINT, since the integer must be nonnegative.
27 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
28 since it makes no difference and we prefer signed.
29 * keyboard.c (record_char): Use XUINT when all the neighbors do.
30 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
33 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
35 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
36 Do not assume that spare memory exists; that assumption is valid
37 only if SYSTEM_MALLOC.
38 (LARGE_REQUEST): New macro, so that the issue of large requests
39 is separated from the issue of spare memory.
41 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
43 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
46 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
48 * xfns.c (x_set_scroll_bar_default_width): Move declarations
51 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
53 * gtkutil.c (xg_get_default_scrollbar_width): New function.
55 * gtkutil.h: Declare xg_get_default_scrollbar_width.
57 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
58 min width by calling x_set_scroll_bar_default_width (Bug#8505).
60 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
62 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
64 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
66 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
67 (x_clipboard_manager_save): Add return value.
68 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
70 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
71 Obey Vx_select_enable_clipboard_manager. Catch errors in
72 x_clipboard_manager_save (Bug#8779).
73 (Vx_select_enable_clipboard_manager): New variable.
74 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
76 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
78 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
80 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
82 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
83 in the current matrix if keep_current_p is non-zero.
85 2011-06-04 Eli Zaretskii <eliz@gnu.org>
87 * bidi.c (bidi_level_of_next_char): Fix last change.
89 2011-06-03 Eli Zaretskii <eliz@gnu.org>
91 Support bidi reordering of text covered by display properties.
93 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
94 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
95 (bidi_cache_search, bidi_cache_iterator_state)
96 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
97 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
98 character positions inside a run of characters covered by a
100 (bidi_paragraph_init, bidi_resolve_explicit_1)
101 (bidi_level_of_next_char): Call bidi_fetch_char and
102 bidi_fetch_char_advance instead of FETCH_CHAR and
104 (bidi_init_it): Initialize new members.
105 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
107 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
108 instead of using explicit *_CHAR codes.
109 (bidi_resolve_explicit, bidi_resolve_weak): Use
110 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
111 bidirectional text is supported only in multibyte buffers.
112 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
113 it to initialize the frame_window_p member of struct bidi_it.
114 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
115 (bidi_resolve_explicit, bidi_resolve_weak)
116 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
117 bidi_it->nchars is non-positive.
118 (bidi_level_of_next_char): Don't try to lookup the cache for the
119 next/previous character if nothing is cached there yet, or if we
120 were just reseat()'ed to a new position.
122 * xdisp.c (set_cursor_from_row): Set start and stop points
123 according to the row's direction when priming the loop that looks
124 for the glyph on which to display cursor.
125 (single_display_spec_intangible_p): Function deleted.
126 (display_prop_intangible_p): Reimplement to call
127 handle_display_spec instead of single_display_spec_intangible_p.
128 Accept 3 additional arguments needed by handle_display_spec. This
129 fixes incorrect cursor motion across display property with complex
130 values: lists, `(when COND...)' forms, etc.
131 (single_display_spec_string_p): Support property values that are
132 lists with the argument STRING its top-level element.
133 (display_prop_string_p): Fix the condition for processing a
134 property that is a list to be consistent with handle_display_spec.
135 (handle_display_spec): New function, refactored from the
136 last portion of handle_display_prop.
137 (compute_display_string_pos): Accept additional argument
138 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
139 value of a `display' property is a "replacing spec".
140 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
141 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
142 the display property, but just return a value indicating whether
143 the display property will replace the characters it covers.
144 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
145 frame_window_p members of struct bidi_it.
146 (compute_display_string_pos, compute_display_string_end): New
148 (push_it): Accept second argument POSITION, where pop_it should
149 jump to continue iteration.
150 (reseat_1): Initialize bidi_it.disp_pos.
152 * keyboard.c (adjust_point_for_property): Adjust the call to
153 display_prop_intangible_p to its new signature.
155 * dispextern.h (struct bidi_it): New member frame_window_p.
156 (bidi_init_it): Update prototypes.
157 (display_prop_intangible_p): Update prototype.
158 (compute_display_string_pos, compute_display_string_end): Declare
160 (struct bidi_it): New members nchars and disp_pos. ch_len is now
163 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
165 Malloc failure behavior now depends on size of allocation.
166 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
167 * lisp.h: Change signatures accordingly.
168 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
169 All callers changed. (Bug#8762)
171 * gnutls.c: Use Emacs's memory allocators.
172 Without this change, the gnutls library would invoke malloc etc.
173 directly, which causes problems on non-SYNC_INPUT hosts, and which
174 runs afoul of improving memory_full behavior. (Bug#8761)
175 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
176 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
177 xfree instead of the default malloc, realloc, free.
178 (Fgnutls_boot): No need to check for memory allocation failure,
179 since xmalloc does that for us.
181 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
182 * category.c (hash_get_category_set):
183 * ccl.c (ccl_driver):
184 * charset.c (Fdefine_charset_internal):
185 * charset.h (struct charset.hash_index):
186 * composite.c (get_composition_id, gstring_lookup_cache)
187 (composition_gstring_put_cache):
188 * composite.h (struct composition.hash_index):
189 * dispextern.h (struct image.hash):
190 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
191 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
192 (hashfn_equal, hashfn_user_defined, make_hash_table)
193 (maybe_resize_hash_table, hash_lookup, hash_put)
194 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
195 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
196 (Fsxhash, Fgethash, Fputhash, Fmaphash):
197 * image.c (make_image, search_image_cache, lookup_image)
198 (xpm_put_color_table_h):
199 * lisp.h (struct Lisp_Hash_Table):
200 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
201 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
202 for hashes and hash indexes, instead of 'unsigned' and 'int'.
203 * alloc.c (allocate_vectorlike):
204 Check for overflow in vector size calculations.
205 * ccl.c (ccl_driver):
206 Check for overflow when converting EMACS_INT to int.
207 * fns.c, image.c: Remove unnecessary static decls that would otherwise
208 need to be updated by these changes.
209 * fns.c (make_hash_table, maybe_resize_hash_table):
210 Check for integer overflow with large hash tables.
211 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
212 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
213 (SXHASH_REDUCE): New macro.
214 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
215 Use it instead of discarding useful hash info with large hash values.
216 (sxhash_float): New function.
217 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
218 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
219 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
220 Rewrite to use FIXNUM_BITS, as this simplifies things.
221 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
222 Adjust signatures to match updated version of code.
223 (consing_since_gc): Now EMACS_INT, since a single hash table can
224 use more than INT_MAX bytes.
226 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
228 Make it possible to build with GCC-4.6+ -O2 -flto.
230 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
232 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
234 * minibuf.c (get_minibuffer, read_minibuf_unwind):
235 Call minibuffer-inactive-mode.
237 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
239 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
242 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
244 * data.c (init_data): Remove code for UTS, this system is not
247 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
249 Don't force ./temacs to start in terminal mode.
251 * frame.c (make_initial_frame): Initialize faces in all cases, not
252 only when CANNOT_DUMP is defined.
253 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
255 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
257 * dispnew.c (add_window_display_history): Use const for the string
258 pointer. Remove declaration, not needed.
260 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
262 Use 'inline', not 'INLINE'.
263 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
264 * alloc.c, fontset.c (INLINE): Remove.
265 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
266 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
267 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
268 * gmalloc.c (register_heapinfo): Use inline unconditionally.
269 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
271 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
273 Make it possible to run ./temacs.
275 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
276 syms_of_callproc does the same thing. Remove test for
277 "initialized", do it in the caller.
278 * emacs.c (main): Avoid calling set_initial_environment when dumping.
280 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
282 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
283 (read_minibuf): Use get_minibuffer.
284 (syms_of_minibuf): Use DEFSYM.
285 (Qmetadata): New var.
286 * data.c (Qbuffer): Don't make it static.
287 (syms_of_data): Use DEFSYM.
289 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
291 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
292 (CCL_CODE_MIN): New macro.
294 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
296 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
298 * eval.c (Qdebug): Now static.
299 * lisp.h (Qdebug): Remove decl. This reverts a part of the
300 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
301 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
303 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
305 * image.c: Various fixes to ImageMagick code comments.
306 (Fimagemagick_types): Doc fix.
308 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
310 Minor fixes prompted by GCC 4.6.0 warnings.
312 * xselect.c (converted_selections, conversion_fail_tag): Now static.
314 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
315 (x_clipboard_manager_save_all): Move extern decl to ...
316 * xterm.h: ... here, so that it can be checked for consistency.
318 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
320 * xselect.c (x_clipboard_manager_save_frame)
321 (x_clipboard_manager_save_all): New functions.
322 (Fx_clipboard_manager_save): Lisp function deleted.
324 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
325 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
327 * xterm.h: Update prototype.
329 2011-05-28 William Xu <william.xwl@gmail.com>
331 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
334 2011-05-28 Jim Meyering <meyering@redhat.com>
336 Avoid a sign-extension bug in crypto_hash_function.
337 * fns.c (to_uchar): Define.
338 (crypto_hash_function): Use it to convert some newly-signed
339 variables to unsigned, to avoid sign-extension bugs. For example,
340 without this change, (md5 "truc") would evaluate to
341 45723a2aff78ff4fff7fff1114760e62 rather than the expected
342 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
343 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
345 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
347 Integer overflow fixes.
349 * dbusbind.c: Serial number integer overflow fixes.
350 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
351 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
352 to hold a serial number that is too large for a fixnum.
353 (Fdbus_method_return_internal, Fdbus_method_error_internal):
354 Check for serial numbers out of range. Decode any serial number
355 that was so large that it became a float. (Bug#8722)
357 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
358 (Fdbus_call_method, Fdbus_call_method_asynchronously):
359 Use XFASTINT rather than XUINT when numbers are nonnegative.
360 (xd_append_arg, Fdbus_method_return_internal):
361 (Fdbus_method_error_internal): Likewise. Also, for unsigned
362 arguments, check that Lisp number is nonnegative, rather than
363 silently wrapping negative numbers around. (Bug#8722)
364 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
367 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
369 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
371 ccl: add integer overflow checks
372 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
373 (IN_INT_RANGE): New macros.
374 (ccl_driver): Use them to check for integer overflow when
375 decoding a CCL program. Many of the new checks are whether XINT (x)
376 fits in int; it doesn't always, on 64-bit hosts. The new version
377 doesn't catch all possible integer overflows, but it's an
378 improvement. (Bug#8719)
380 * alloc.c (make_event_array): Use XINT, not XUINT.
381 There's no need for unsigned here.
383 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
384 This follows up to the 2011-05-06 change that substituted uintptr_t
385 for EMACS_INT. This case wasn't caught back then.
387 Rework Fformat to avoid integer overflow issues.
388 * editfns.c: Include <float.h> unconditionally, as it's everywhere
389 now (part of C89). Include <verify.h>.
390 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
391 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
392 (Fformat): Avoid the prepass trying to compute sizes; it was only
393 approximate and thus did not catch overflow reliably. Instead, walk
394 through the format just once, formatting and computing sizes as we go,
395 checking for integer overflow at every step, and allocating a larger
396 buffer as needed. Keep track separately whether the format is
397 multibyte. Keep only the most-recently calculated precision, rather
398 than them all. Record whether each argument has been converted to
399 string. Use EMACS_INT, not int, for byte and char and arg counts.
400 Support field widths and precisions larger than INT_MAX. Avoid
401 sprintf's undefined behavior with conversion specifications such as %#d
402 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
403 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
404 formatting out-of-range floating point numbers with int
407 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
409 * data.c: Avoid integer truncation in expressions involving floats.
410 * data.c: Include <intprops.h>.
411 (arith_driver): When there's an integer overflow in an expression
412 involving floating point, convert the integers to floating point
413 so that the resulting value does not suffer from catastrophic
414 integer truncation. For example, on a 64-bit host (* 4
415 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
416 Do not rely on undefined behavior after integer overflow.
418 merge count_size_as_multibyte, parse_str_to_multibyte
419 * character.c, character.h (count_size_as_multibyte):
420 Rename from parse_str_to_multibyte; all uses changed.
421 Check for integer overflow.
422 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
423 since it's now a duplicate of the other. This is more of
424 a character than a buffer op, so better that it's in character.c.
425 * fns.c, print.c: Adjust to above changes.
427 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
429 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
431 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
433 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
434 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
435 (x_clipboard_manager_save): Now static.
436 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
438 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
439 (crypto_hash_function): Now static.
440 Fix pointer signedness problems. Avoid unnecessary initializations.
442 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
444 * termhooks.h (Vselection_alist): Make it terminal-local.
446 * terminal.c (create_terminal): Initialize it.
448 * xselect.c: Support for clipboard managers.
449 (Vselection_alist): Move to termhooks.h as terminal-local var.
450 (LOCAL_SELECTION): New macro.
451 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
452 (symbol_to_x_atom): Remove gratuitous arg.
453 (x_handle_selection_request, lisp_data_to_selection_data)
454 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
455 (x_own_selection, x_get_local_selection, x_convert_selection):
456 New arg, specifying work frame. Use terminal-local Vselection_alist.
457 (some_frame_on_display): Delete unused function.
458 (Fx_own_selection_internal, Fx_get_selection_internal)
459 (Fx_disown_selection_internal, Fx_selection_owner_p)
460 (Fx_selection_exists_p): New optional frame arg.
461 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
462 (x_handle_selection_clear): Don't treat other terminals with the
463 same keyboard specially. Use the terminal-local Vselection_alist.
464 (x_clear_frame_selections): Use Frun_hook_with_args.
466 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
468 * xterm.h: Add support for those atoms.
470 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
472 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
473 (converted_selections, conversion_fail_tag): New global variables.
474 (x_selection_request_lisp_error): Free the above.
475 (x_get_local_selection): Remove unnecessary code.
476 (x_reply_selection_request): Args changed; handle arbitrary array
477 of converted selections stored in converted_selections.
478 Separate the XChangeProperty and SelectionNotify steps.
479 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
480 (x_convert_selection): New function.
481 (x_handle_selection_event): Simplify.
482 (x_get_foreign_selection): Don't ignore incoming requests while
483 waiting for an answer; this will fail when we implement
484 SAVE_TARGETS, and seems unnecessary anyway.
485 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
486 (Vx_sent_selection_functions): Doc fix.
488 2011-05-26 Leo Liu <sdl.web@gmail.com>
490 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
492 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
494 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
496 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
497 for fringe update if it has periodic bitmap.
498 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
499 and fringe_bitmap_periodic_p.
501 * fringe.c (get_fringe_bitmap_data): New function.
502 (draw_fringe_bitmap_1, update_window_fringes): Use it.
503 (update_window_fringes): Record periodicity of fringe bitmap in glyph
504 row. Mark glyph row for fringe update if periodicity changed.
506 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
507 for fringe update unless it has periodic bitmap.
509 2011-05-25 Kenichi Handa <handa@m17n.org>
511 * xdisp.c (get_next_display_element): Set correct it->face_id for
512 a static composition.
514 2011-05-24 Leo Liu <sdl.web@gmail.com>
517 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
519 * fns.c (crypto_hash_function, Fsha1): New function.
520 (Fmd5): Use crypto_hash_function.
521 (syms_of_fns): Add Ssha1.
523 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
525 * gnutls.c: Remove unused macros.
526 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
527 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
528 Remove macros that are defined and never used.
529 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
531 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
533 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
534 (Fx_get_selection_internal): Minor cleanup.
535 (Fx_own_selection_internal): Rename arguments for consistency with
538 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
540 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
542 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
544 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
546 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
548 * dispnew.c (scrolling_window): Don't exclude the case that the
549 last enabled row in the desired matrix touches the bottom boundary.
551 2011-05-21 Glenn Morris <rgm@gnu.org>
553 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
554 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
555 and add some more files.
557 2011-05-20 Eli Zaretskii <eliz@gnu.org>
559 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
560 report_file_error introduced by the change from 2011-05-07.
562 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
564 * systime.h (Time): Define only if emacs is defined.
565 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
566 where the include path doesn't have X11/X.h by default. See
567 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
569 2011-05-20 Kenichi Handa <handa@m17n.org>
571 * composite.c (find_automatic_composition): Fix previous change.
573 2011-05-20 Glenn Morris <rgm@gnu.org>
575 * lisp.mk: New file, split from Makefile.in.
576 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
578 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
580 2011-05-19 Glenn Morris <rgm@gnu.org>
582 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
583 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
584 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
585 (lisp): Set the order to that of loadup.el.
586 (shortlisp): Make it a copy of $lisp.
587 (SOME_MACHINE_LISP): Remove.
588 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
589 Use just $shortlisp, not $SOME_MACHINE_LISP too.
591 2011-05-18 Kenichi Handa <handa@m17n.org>
593 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
594 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
595 (find_automatic_composition): Mostly rewrite for efficiency.
597 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
599 * makefile.w32-in: Update dependencies.
601 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
603 * menu.c: Include limits.h (fixes the MS-Windows build broken by
606 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
608 Fix some integer overflow issues, such as string length overflow.
610 * insdel.c (count_size_as_multibyte): Check for string overflow.
612 * character.c (lisp_string_width): Check for string overflow.
613 Use EMACS_INT, not int, for string indexes and lengths; in
614 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
615 the resulting string length overflows an EMACS_INT; instead,
616 report a string overflow if no precision given. When checking for
617 precision exhaustion, use a check that cannot possibly have
618 integer overflow. (Bug#8675)
619 * character.h (lisp_string_width): Adjust to new signature.
621 * alloc.c (string_overflow): New function.
622 (Fmake_string): Use it. This doesn't change behavior, but saves
623 a few bytes and will simplify future changes.
624 * character.c (string_escape_byte8): Likewise.
625 * lisp.h (string_overflow): New decl.
627 Fixups, following up to the user-interface timestamp change.
628 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
629 for UI timestamps, instead of unsigned long.
630 * msdos.c (mouse_get_pos): Likewise.
631 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
632 * w32gui.h (Time): Define by including "systime.h" rather than by
633 declaring it ourselves. (Bug#8664)
635 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
636 * image.c (clear_image_cache): Likewise.
638 * term.c (term_mouse_position): Don't assume time_t wraparound.
640 Be more systematic about user-interface timestamps.
641 Before, the code sometimes used 'Time', sometimes 'unsigned long',
642 and sometimes 'EMACS_UINT', to represent these timestamps.
643 This change causes it to use 'Time' uniformly, as that's what X uses.
644 This makes the code easier to follow, and makes it easier to catch
645 integer overflow bugs such as Bug#8664.
646 * frame.c (Fmouse_position, Fmouse_pixel_position):
647 Use Time, not unsigned long, for user-interface timestamps.
648 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
649 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
650 * keyboard.h (last_event_timestamp): Likewise.
651 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
652 * menu.h (xmenu_show): Likewise.
653 * term.c (term_mouse_position): Likewise.
654 * termhooks.h (struct input_event.timestamp): Likewise.
655 (struct terminal.mouse_position_hook): Likewise.
656 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
657 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
658 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
659 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
661 * menu.h, termhooks.h: Include "systime.h", for Time.
663 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
664 Don't assume that the difference between two unsigned long values
665 can fit into an integer. At this point, we know button_down_time
666 <= event->timestamp, so the difference must be nonnegative, so
667 there's no need to cast the result if double-click-time is
668 nonnegative, as it should be; check that it's nonnegative, just in
669 case. This bug is triggered when events are more than 2**31 ms
670 apart (about 25 days). (Bug#8664)
672 * xselect.c (last_event_timestamp): Remove duplicate decl.
673 (x_own_selection): Remove needless cast to unsigned long.
675 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
676 that always fit in int. Use a sentinel instead of a counter, to
677 avoid a temp and to allay GCC's concerns about possible int overflow.
678 * frame.h (struct frame): Use int for menu_bar_items_used
679 instead of EMACS_INT, since it always fits in int.
681 * menu.c (grow_menu_items): Check for int overflow.
683 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
685 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
686 Before, the code was not consistent. These values cannot exceed
687 2**31 - 1 so there's no need to make them unsigned.
688 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
689 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
690 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
692 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
694 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
695 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
696 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
697 presumably because the widths might not match.
699 * window.c (size_window): Avoid needless test at loop start.
701 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
703 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
705 2011-05-12 Drew Adams <drew.adams@oracle.com>
707 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
709 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
711 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
712 `width' to `bar_area_x' and `bar_area_width', respectively.
713 (x_scroll_run): Take account of fringe background extension.
715 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
716 Rename local vars `left' and `width' to `bar_area_x' and
717 `bar_area_width', respectively.
718 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
719 background extension.
721 2011-05-10 Jim Meyering <meyering@redhat.com>
723 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
725 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
727 * image.c (Finit_image_library): Return t for built-in image types,
728 like pbm and xbm. (Bug#8640)
730 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
732 * w32menu.c (set_frame_menubar): Fix submenu allocation.
734 2011-05-07 Eli Zaretskii <eliz@gnu.org>
736 * w32console.c (Fset_screen_color): Doc fix.
737 (Fget_screen_color): New function.
738 (syms_of_ntterm): Defsubr it.
740 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
741 unlink the temporary file if Fcall_process didn't create it in the
743 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
744 child process will be redirected to a file specified with `:file'.
745 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
746 cue to call_process_cleanup not to close that handle.
748 2011-05-07 Ben Key <bkey76@gmail.com>
750 * makefile.w32-in: The bootstrap-temacs rule now makes use of
751 one of two shell specific rules, either bootstrap-temacs-CMD or
752 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
753 to the previous implementation of the bootstrap-temacs rule.
754 The bootstrap-temacs-CMD rule is similar to the previous
755 implementation of the bootstrap-temacs rule except that it
756 makes use of the ESC_CFLAGS variable instead of the CFLAGS
759 These changes, along with some changes to nt/configure.bat,
760 nt/gmake.defs, and nt/nmake.defs, are required to extend my
761 earlier fix to add support for --cflags and --ldflags options
762 that include quotes so that it works whether make uses cmd or
765 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
767 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
768 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
770 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
771 a string. Handle both cases.
772 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
773 (Fdbus_register_method): Use Qinvalid_function.
775 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
777 * makefile.w32-in: Update dependencies.
778 (LISP_H): Add inttypes.h and stdin.h.
779 (PROCESS_H): Add unistd.h.
781 2011-05-06 Eli Zaretskii <eliz@gnu.org>
783 * lread.c: Include limits.h (fixes the MS-Windows build broken by
784 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
786 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
788 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
790 * term.c (vfatal): Remove stray call to va_end.
791 It's not needed and the C Standard doesn't allow it here anyway.
793 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
794 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
796 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
799 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
801 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
803 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
805 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
807 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
809 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
810 * charset.c (Fdefine_charset_internal): Don't initialize
811 charset.code_space[15]. The value was garbage, on hosts with
812 32-bit int (Bug#8600).
814 * lread.c (read_integer): Be more consistent with string-to-number.
815 Use string_to_number to do the actual conversion; this avoids
816 rounding errors and fixes some other screwups. Without this fix,
817 for example, #x1fffffffffffffff was misread as -2305843009213693952.
818 (digit_to_number): Move earlier, for benefit of read_integer.
819 Return -1 if the digit is out of range for the base, -2 if it is
820 not a digit in any supported base. (Bug#8602)
822 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
824 * dispnew.c (scrolling_window): Return 1 if we scrolled,
825 to match comment at start of function. This also removes a
826 GCC warning about overflow in a 32+64-bit port.
828 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
830 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
831 Reported by Stefan Monnier in
832 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
833 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
834 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
836 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
837 (EMACS_UINTPTR): Likewise, with uintptr_t.
839 * lisp.h: Prefer 64-bit EMACS_INT if available.
840 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
841 on 32-bit hosts that have 64-bit int, so that they can access
843 However, temporarily disable this change unless the temporary
844 symbol WIDE_EMACS_INT is defined.
846 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
848 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
849 This removes an assumption that EMACS_INT and long are the same
850 width as pointers. The assumption is true for Emacs porting targets
851 now, but we want to make other targets possible.
852 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
853 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
854 In the rest of the code, change types of integers that hold casted
855 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
856 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
857 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
858 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
859 No need to cast type when ORing.
860 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
861 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
862 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
863 assume EMACS_INT is the same width as char *.
864 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
865 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
866 Remove no-longer-needed casts.
867 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
868 (xg_tool_bar_help_callback, xg_make_tool_item):
869 Use EMACS_INTPTR to hold an integer
870 that will be cast to void *; this can avoid a GCC warning
871 if EMACS_INT is not the same width as void *.
872 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
873 * xdisp.c (display_echo_area_1, resize_mini_window_1):
874 (current_message_1, set_message_1):
875 Use a local to convert to proper width without a cast.
876 * xmenu.c (dialog_selection_callback): Likewise.
878 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
879 Also, don't assume VALBITS / RAND_BITS is less than 5,
880 and don't rely on undefined behavior when shifting a 1 left into
882 * lisp.h (get_random): Change signature to match.
884 * lread.c (hash_string): Use size_t, not int, for hash computation.
885 Normally we prefer signed values; but hashing is special, because
886 it's better to use unsigned division on hash table sizes so that
887 the remainder is nonnegative. Also, size_t is the natural width
888 for hashing into memory. The previous code used 'int', which doesn't
889 retain enough info to hash well into very large tables.
890 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
892 * dbusbind.c: Don't possibly lose pointer info when converting.
893 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
894 Use XPNTR rather than XHASH, so that the high-order bits of
895 the pointer aren't lost when converting through void *.
897 * eval.c (Fautoload): Don't double-shift a pointer.
899 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
901 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
903 * gnutls.c (DEF_GNUTLS_FN):
904 * image.c (DEF_IMGLIB_FN): Make function pointers static.
906 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
908 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
911 2011-05-05 Eli Zaretskii <eliz@gnu.org>
913 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
914 New version that can reserve upto 2GB of heap space.
916 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
918 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
920 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
922 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
923 `gnutls_certificate_set_x509_key_file'.
925 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
927 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
930 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
932 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
933 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
934 Remove unused parameter `fildes'.
935 * process.c (read_process_output, send_process): Don't pass it.
937 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
939 Fix previous change: the library cache is defined in w32.c.
940 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
941 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
943 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
945 Implement dynamic loading of GnuTLS on Windows.
947 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
948 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
949 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
952 * gnutls.c (Qgnutls_dll): Define.
953 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
954 (gnutls_*): Declare function pointers.
955 (init_gnutls_functions): New function to initialize function pointers.
956 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
957 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
958 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
959 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
960 (emacs_gnutls_write, emacs_gnutls_read)
961 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
962 (Fgnutls_available_p): New function.
963 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
964 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
965 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
967 * image.c: Include w32.h.
968 (Vimage_type_cache): Delete.
969 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
970 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
971 (w32_delayed_load): Move to w32.c.
973 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
975 * w32.c (QCloaded_from, Vlibrary_cache): Define.
976 (w32_delayed_load): Move from image.c. When loading a library, record
977 its filename in the :loaded-from property of the library id.
978 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
979 Initialize and staticpro them.
980 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
982 * process.c: Include lisp.h before w32.h, not after.
983 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
984 instead of gnutls_record_check_pending.
986 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
988 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
990 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
991 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
994 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
996 * xterm.c (x_set_frame_alpha): Do not set property on anything
997 else than FRAME_X_OUTER_WINDOW (Bug#8608).
999 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1001 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1003 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1005 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1006 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1007 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1008 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1009 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1010 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1011 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1012 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1013 (Qgnutls_bootprop_callbacks_verify): Make static.
1015 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1017 * callproc.c: Indentation fixup.
1019 * sysdep.c (wait_for_termination_1): Make static.
1020 (wait_for_termination, interruptible_wait_for_termination):
1021 Move after wait_for_termination_1.
1023 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1025 * sysdep.c (interruptible_wait_for_termination): New function
1026 which is like wait_for_termination, but allows keyboard
1029 * callproc.c (Fcall_process): Add (:file "file") as an option for
1031 (Fcall_process_region): Ditto.
1033 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1035 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1036 rather than `XVECTOR (FOO)->size'.
1038 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1039 inttypes.h, as a gnulib replacement is used if it not available in
1042 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1044 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1045 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1046 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1048 * coding.c (coding_alloc_by_realloc): Error out if destination
1049 will grow beyond MOST_POSITIVE_FIXNUM.
1050 (decode_coding_emacs_mule): Abort if there isn't enough place in
1051 charbuf for the composition carryover bytes. Reserve an extra
1052 space for up to 2 characters produced in a loop.
1053 (decode_coding_iso_2022): Abort if there isn't enough place in
1054 charbuf for the composition carryover bytes.
1056 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1058 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1059 aborting when %lld or %lll format is passed.
1060 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1061 %llo or %llx format is passed. (Bug#8545)
1063 * window.c (window_scroll_line_based): Use a marker instead of
1064 simple variables to record original value of point. (Bug#7952)
1066 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1067 produced by %s or %c overflows available buffer space. (Bug#8545)
1069 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1071 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1072 (SIZE_MAX): Move defn after all includes, as they might #define it.
1074 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1076 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1078 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1080 * keyboard.c (Qdelayed_warnings_hook): Define.
1081 (command_loop_1): Run `delayed-warnings-hook'
1082 if Vdelayed_warnings_list is non-nil.
1083 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1084 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1086 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1088 * doprnt.c (doprnt): Don't return value smaller than the buffer
1089 size if the message was truncated. (Bug#8545).
1091 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1093 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1094 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1096 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1098 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1100 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1102 * makefile.w32-in: Update dependencies.
1104 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1106 Improve `doprnt' and its usage. (Bug#8545)
1107 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1108 `format_end'. Remove support for %l as a conversion specifier.
1109 Don't use xrealloc. Improve diagnostics when the %l size modifier
1110 is used. Update the commentary.
1112 * eval.c (verror): Simplify calculation of size_t.
1114 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1117 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1119 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1122 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1124 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1125 This makes this file independent of the recent pseudovector change.
1127 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1129 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1131 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1132 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1133 Remove unused local.
1134 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1136 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1137 GCC 4.6.0 optimizes based on type-based alias analysis.
1138 For example, if b is of type struct buffer * and v of type struct
1139 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1140 != &v->size, and therefore "v->size = 1; b->size = 2; return
1141 v->size;" must therefore return 1. This assumption is incorrect
1142 for Emacs, since it type-puns struct Lisp_Vector * with many other
1143 types. To fix this problem, this patch adds a new type struct
1144 vectorlike_header that documents the constraints on layout of vectors
1145 and pseudovectors, and helps optimizing compilers not get fooled
1146 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1147 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1148 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1150 (XSETPVECTYPE): Rewrite in terms of new macro.
1151 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1152 This is a bit clearer, and further avoids the possibility of
1153 undesirable aliasing.
1154 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1155 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1156 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1157 since Lisp_Subr is a special case (no "next" field).
1158 (ASIZE): Now uses header.size rather than size.
1159 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1160 to avoid the hassle of writing XVECTOR (foo)->header.size.
1161 (struct vectorlike_header): New type.
1162 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1163 object, to help avoid aliasing.
1164 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1165 (SUBRP): Likewise, since Lisp_Subr is a special case.
1166 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1167 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1168 (struct Lisp_Hash_Table): Combine first two members into a single
1169 struct vectorlike_header member. All uses of "size" and "next" members
1170 changed to be "header.size" and "header.next".
1171 * buffer.h (struct buffer): Likewise.
1172 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1173 * frame.h (struct frame): Likewise.
1174 * process.h (struct Lisp_Process): Likewise.
1175 * termhooks.h (struct terminal): Likewise.
1176 * window.c (struct save_window_data, struct saved_window): Likewise.
1177 * window.h (struct window): Likewise.
1178 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1179 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1180 * buffer.c (init_buffer_once): Likewise.
1181 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1183 * process.c (Fformat_network_address): Use local var for size,
1186 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1188 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1189 * data.c (atof): Remove decl; no longer used or needed.
1190 (digit_to_number): Move to lread.c.
1191 (Fstring_to_number): Use new string_to_number function, to be
1192 consistent with how the Lisp reader treats infinities and NaNs.
1193 Do not assume that floating-point numbers represent EMACS_INT
1194 without losing information; this is not true on most 64-bit hosts.
1195 Avoid double-rounding errors, by insisting on integers when
1196 parsing non-base-10 numbers, as the documentation specifies.
1197 * lisp.h (string_to_number): New decl, replacing ...
1198 (isfloat_string): Remove.
1199 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1200 (read1): Do not accept +. and -. as integers; this
1201 appears to have been a coding error. Similarly, do not accept
1202 strings like +-1e0 as floating point numbers. Do not report
1203 overflow for integer overflows unless the base is not 10 which
1204 means we have no simple and reliable way to continue.
1205 Break out the floating-point parsing into a new
1206 function string_to_number, so that Fstring_to_number parses
1207 floating point numbers consistently with the Lisp reader.
1208 (digit_to_number): Move here from data.c. Make it static inline.
1209 (E_CHAR, EXP_INT): Remove, replacing with ...
1210 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1211 (string_to_number): New function, replacing isfloat_string.
1212 This function checks for valid syntax and produces the resulting
1213 Lisp float number too. Rework it so that string-to-number
1214 no longer mishandles examples like "1.0e+". Use strtoumax,
1215 so that overflow for non-base-10 numbers is reported only when
1216 there's no portable and simple way to convert to floating point.
1218 * textprop.c (set_text_properties_1): Rewrite for clarity,
1219 and to avoid GCC warning about integer overflow.
1221 * intervals.h (struct interval): Use EMACS_INT for members
1222 where EMACS_UINT might cause problems. See
1223 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1224 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1225 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1227 (offset_intervals): Tell GCC not to worry about length overflow
1228 when negating a negative length.
1230 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1231 (overrun_check_free): Likewise.
1233 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1234 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1237 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1238 (gnutls_make_error): Rename local to avoid shadowing.
1239 (gnutls_emacs_global_deinit): ifdef out; not used.
1240 (Fgnutls_boot): Use const for pointer to readonly storage.
1241 Comment out unused local. Fix pointer signedness problems.
1243 * lread.c (openp): Don't stuff size_t into an 'int'.
1244 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1245 about possible signed overflow.
1247 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1248 (GDK_KEY_g): Don't define if already defined.
1249 (xg_prepare_tooltip): Avoid pointer signedness problem.
1250 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1252 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1253 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1255 * xfns.c (Fx_window_property): Simplify a bit,
1256 to make a bit faster and to avoid GCC 4.6.0 warning.
1257 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1259 * fns.c (internal_equal): Don't assume size_t fits in int.
1261 * alloc.c (compact_small_strings): Tighten assertion a little.
1263 Replace pEd with more-general pI, and fix some printf arg casts.
1264 * lisp.h (pI): New macro, generalizing old pEd macro to other
1265 conversion specifiers. For example, use "...%"pI"d..." rather
1266 than "...%"pEd"...".
1267 (pEd): Remove. All uses replaced with similar uses of pI.
1268 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1269 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1270 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1271 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1272 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1273 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1274 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1276 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1277 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1278 * print.c (safe_debug_print, print_object): Likewise.
1279 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1281 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1282 avoiding the 0 flag, which is not portable.
1283 * process.c (Fmake_network_process): Use pI to avoid cast.
1284 * region-cache.c (pp_cache): Likewise.
1285 * xdisp.c (decode_mode_spec): Likewise.
1286 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1287 behavior on 64-bit hosts with printf arg.
1288 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1289 (x_stop_queuing_selection_requests): Likewise.
1290 (x_get_window_property): Don't truncate byte count to an 'int'
1293 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1294 here, since it parses constructs like leading '-' and spaces,
1295 which are not wanted; and it overflows with large numbers.
1296 Instead, simply match F[0-9]+, which is what is wanted anyway.
1298 * alloc.c: Remove unportable assumptions about struct layout.
1299 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1300 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1301 (allocate_vectorlike, make_pure_vector): Use the new macros,
1302 plus offsetof, to remove unportable assumptions about struct layout.
1303 These assumptions hold on all porting targets that I know of, but
1304 they are not guaranteed, they're easy to remove, and removing them
1305 makes further changes easier.
1307 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1308 This doesn't fix a bug but makes the code clearer.
1309 (string_overrun_cookie): Now const. Use initializers that
1310 don't formally overflow signed char, to avoid warnings.
1311 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1312 can cause Emacs to crash when string overrun checking is enabled.
1313 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1314 multiple of sizeof (EMACS_INT); it need not be, if
1315 alignof(EMACS_INT) < sizeof (EMACS_INT).
1316 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1318 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1320 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1322 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1324 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1325 supposed to be handshaking. (Bug#8556)
1326 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1328 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1330 * lisp.h (Qdebug): List symbol.
1331 * eval.c (Qdebug): Restore global linkage.
1332 * keyboard.c (debug-on-event): New variable.
1333 (handle_user_signal): Break into debugger when debug-on-event
1334 matches the current signal symbol.
1336 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1338 * alloc.c (check_sblock, check_string_bytes)
1339 (check_string_free_list): Convert to standard C.
1341 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1343 * w32.c (emacs_gnutls_push): Fix typo.
1345 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1347 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1348 "cast to pointer from integer of different size".
1350 Improve doprnt and its use in verror. (Bug#8545)
1351 * doprnt.c (doprnt): Document the set of format control sequences
1352 supported by the function. Use SAFE_ALLOCA instead of always
1355 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1356 is one byte too soon. Don't use xrealloc; instead xfree and
1359 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1361 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1364 * gnutls.c: Renamed global_initialized to
1365 gnutls_global_initialized. Added internals for the
1366 :verify-hostname-error, :verify-error, and :verify-flags
1367 parameters of `gnutls-boot' and documented those parameters in the
1368 docstring. Start callback support.
1369 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1370 unless a fatal error occured. Call gnutls_alert_send_appropriate
1371 on error. Return error code.
1372 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1373 (emacs_gnutls_read): Likewise.
1374 (Fgnutls_boot): Return handshake error code.
1375 (emacs_gnutls_handle_error): New function.
1376 (wsaerror_to_errno): Likewise.
1378 * w32.h (emacs_gnutls_pull): Add prototype.
1379 (emacs_gnutls_push): Likewise.
1381 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1382 (emacs_gnutls_push): Likewise.
1384 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1386 * process.c (wait_reading_process_output): Check if GnuTLS
1387 buffered some data internally if no FDs are set for TLS
1390 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1391 (LIBS): Link to USER_LIBS.
1392 ($(BLD)/gnutls.$(0)): New target.
1394 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1396 * xdisp.c (handle_single_display_spec): Rename the
1397 display_replaced_before_p argument into display_replaced_p, to
1398 make it consistent with the commentary. Fix typos in the
1401 * textprop.c (syms_of_textprop): Remove dead code.
1402 (copy_text_properties): Delete obsolete commentary about an
1403 interface that was deleted long ago. Fix typos in the description
1406 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1407 to changes in oldXMenu/XMenu.h from 2011-04-16.
1408 <menu_help_message, prev_menu_help_message>: Constify.
1409 (IT_menu_make_room): menu->help_text is now `const char **';
1412 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1413 to changes in oldXMenu/XMenu.h from 2011-04-16.
1414 (struct XMenu): Declare `help_text' `const char **'.
1416 * xfaces.c <Qunspecified>: Make extern again.
1418 * syntax.c: Include sys/types.h before including regex.h, as
1421 * doc.c (get_doc_string): Improve the format passed to `error'.
1423 * doprnt.c (doprnt): Improve commentary.
1425 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1427 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1430 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1431 changes in globals.h immediately force recompilation.
1432 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1433 $(CURDIR)/s/ms-w32.h.
1434 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1436 * character.c (Fchar_direction): Function deleted.
1437 (syms_of_character): Don't defsubr it.
1438 <char-direction-table>: Deleted.
1440 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1442 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1443 * doprnt.c: Include limits.h.
1444 (SIZE_MAX): New macro.
1445 (doprnt): Return a size_t value. 2nd arg is now size_t.
1446 Many local variables are now size_t instead of int or unsigned.
1447 Improve overflow protection. Support `l' modifier for integer
1448 conversions. Support %l conversion. Don't assume an EMACS_INT
1449 argument for integer conversions and for %c.
1451 * lisp.h (doprnt): Restore prototype.
1453 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1456 * Makefile.in (base_obj): Add back doprnt.o.
1458 * deps.mk (doprnt.o): Add back prerequisites.
1459 (callint.o): Depend on character.h.
1461 * eval.c (internal_lisp_condition_case): Include the handler
1462 representation in the error message.
1463 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1464 when breaking from the loop.
1466 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1468 * callint.c (Fcall_interactively): When displaying error message
1469 about invalid control letter, pass the character's codepoint, not
1470 a pointer to its multibyte form. Improve display of the character
1471 in octal and display also its hex code.
1473 * character.c (char_string): Use %x to display the (unsigned)
1474 codepoint of an invalid character, to avoid displaying a bogus
1477 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1478 `error', not SYMBOL_NAME itself.
1480 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1481 character arguments to `error'.
1483 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1484 to `error' in error message about FINAL_CHAR argument. Make sure
1485 FINAL_CHAR is a character, and use %c when it is passed as
1486 argument to `error'.
1488 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1490 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1492 * w32.c: Include <time.h>.
1493 (sys_localtime): New function.
1495 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1497 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1499 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1501 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1503 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1506 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1508 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1509 gl_state.e_property when gl_state.object is Qt.
1511 * insdel.c (make_gap_larger): Remove limitation of buffer size
1514 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1516 * xdisp.c (lookup_glyphless_char_display)
1517 (produce_glyphless_glyph): Handle cons cell entry in
1518 glyphless-char-display.
1519 (Vglyphless_char_display): Document it.
1521 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1522 glyphless-char-display.
1524 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1526 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1528 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1530 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1531 definition for no-X builds.
1533 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1535 Static checks with GCC 4.6.0 and non-default toolkits.
1537 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1539 * process.c (keyboard_bit_set): Define only if SIGIO.
1540 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1541 (send_process): Repair possible setjmp clobbering.
1543 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1545 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1547 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1549 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1550 Define only if needed.
1552 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1553 by pacifying GCC about it. Maybe it's time to retire it?
1554 * xfaces.c (USG, __TIMEVAL__): Likewise.
1556 * dispextern.h (struct redisplay_interface): Rename param
1558 * termhooks.h (struct terminal): Likewise.
1559 * xterm.c (xembed_send_message): Likewise.
1561 * insdel.c (make_gap_smaller): Define only if
1562 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1564 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1567 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1568 so that we aren't warned about unused symbols.
1570 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1572 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1574 * xfns.c (x_real_positions): Mark locals as initialized.
1576 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1578 * xterm.c: Fix problems found by static analysis with other toolkits.
1579 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1580 (x_dispatch_event): Declare static if USE_GTK, and
1581 define if USE_GTK || USE_X_TOOLKIT.
1582 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1583 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1584 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1585 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1587 * xmenu.c (menu_help_callback): Pointer type fixes.
1588 Use const pointers when pointing at readonly data. Avoid pointer
1590 (FALSE): Remove unused macro.
1591 (update_frame_menubar): Remove unused decl.
1593 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1595 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1596 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1597 (single_menu_item): Rename local to avoid shadowing.
1599 * keyboard.c (make_lispy_event): Remove unused local var.
1601 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1602 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1604 * bitmaps: Change bitmaps from unsigned char back to the X11
1605 compatible char. Avoid the old compiler warnings about
1606 out-of-range initializers by using, for example, '\xab' rather
1609 * xgselect.c (xgselect_initialize): Check vs interface
1610 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1612 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1614 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1615 to read-only memory.
1617 * fns.c (vector): Remove; this old hack is no longer needed.
1619 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1621 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1623 * xrdb.c (x_load_resources): Omit unused local.
1625 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1626 (x_window): Rename locals to avoid shadowing.
1627 (USG): Use the kludged USG macro, to pacify gcc.
1629 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1630 (x_term_init): Remove local to avoid shadowing.
1632 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1634 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1635 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1637 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1639 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1641 Fix regex.c, syntax.c and friends for buffers > 2GB.
1642 * syntax.h (struct gl_state_s): Declare character position members
1645 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1647 * textprop.c (verify_interval_modification, interval_of):
1648 Declare arguments EMACS_INT.
1650 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1653 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1655 * indent.c (Fvertical_motion): Local variable it_start is now
1658 * regex.c (re_match, re_match_2, re_match_2_internal)
1659 (bcmp_translate, regcomp, regexec, print_double_string)
1660 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1661 (re_compile_pattern, re_exec): Declare arguments and local
1662 variables `size_t' and `ssize_t' and return values `regoff_t', as
1664 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1665 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1666 <compile_stack_type>: `size' and `avail' are now `size_t'.
1668 * regex.h <regoff_t>: Use ssize_t, not int.
1669 (re_search, re_search_2, re_match, re_match_2): Arguments that
1670 specify buffer/string position and length are now ssize_t and
1671 size_t. Return type is regoff_t.
1673 2011-04-16 Ben Key <bkey76@gmail.com>
1675 * nsfont.m: Fixed bugs in ns_get_family and
1676 ns_descriptor_to_entity that were caused by using free to
1677 deallocate memory blocks that were allocated by xmalloc (via
1678 xstrdup). This caused Emacs to crash when compiled with
1679 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1680 --enable-checking=xmallocoverrun). xfree is now used to
1681 deallocate these memory blocks.
1683 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1685 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1687 emacs_write: Accept and return EMACS_INT for sizes.
1688 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1690 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1691 Accept and return EMACS_INT.
1692 (emacs_gnutls_write): Return the number of bytes written on
1694 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1695 (emacs_read, emacs_write): Remove check for negative size, as the
1696 Emacs source code has been audited now.
1697 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1698 (emacs_read, emacs_write): Use it.
1699 * process.c (send_process): Adjust to the new signatures of
1700 emacs_write and emacs_gnutls_write. Do not attempt to store
1701 a byte offset into an 'int'; it might overflow.
1702 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1704 * sound.c: Don't assume sizes fit in 'int'.
1705 (struct sound_device.period_size, alsa_period_size):
1706 Return EMACS_INT, not int.
1707 (struct sound_device.write, vox_write, alsa_write):
1708 Accept EMACS_INT, not int.
1709 (wav_play, au_play): Use EMACS_INT to store sizes and to
1710 record read return values.
1712 2011-04-15 Ben Key <bkey76@gmail.com>
1714 * keyboard.c (Qundefined): Don't declare static since it is used
1716 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1717 static since they are used in nsfont.m.
1719 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1721 * process.c (Qprocessp): Don't declare static.
1722 * lisp.h (Qprocessp): Declare again.
1724 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1726 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1728 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1730 Improve C-level modularity by making more things 'static'.
1732 Don't publish debugger-only interfaces to other modules.
1733 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1734 (verify_bytepos, count_markers): Move decls to the only modules
1736 * region-cache.h (pp_cache): Likewise.
1737 * window.h (check_all_windows): Likewise.
1738 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1740 * sysdep.c (croak): Now static, if
1741 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1742 * syssignal.h (croak): Declare only if not static.
1744 * alloc.c (refill_memory_reserve): Now static if
1745 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1746 * lisp.h (refill_memory_reserve): Declare only if not static.
1748 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1749 Define only if USE_LUCID.
1751 * xrdb.c (x_customization_string, x_rm_string): Now static.
1753 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1754 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1756 * xdisp.c (draw_row_with_mouse_face): Now static.
1757 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1759 * window.h (check_all_windows): Mark externally visible.
1761 * window.c (window_deletion_count): Now static.
1763 * undo.c: Make symbols static if they're not exported.
1764 (last_undo_buffer, last_boundary_position, pending_boundary):
1767 * textprop.c (interval_insert_behind_hooks): Now static.
1768 (interval_insert_in_front_hooks): Likewise.
1770 * term.c: Make symbols static if they're not exported.
1771 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1772 (max_frame_lines, tty_set_terminal_modes):
1773 (tty_reset_terminal_modes, tty_turn_off_highlight):
1774 (get_tty_terminal): Now static.
1775 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1776 * termhooks.h (term_mouse_moveto): Do not declare if
1778 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1779 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1781 * sysdep.c: Make symbols static if they're not exported.
1782 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1784 (sigprocmask_set, full_mask): Remove; unused.
1785 (wait_debugging): Mark as visible.
1786 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1787 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1789 * syntax.c (syntax_temp): Define only if !__GNUC__.
1791 * sound.c (current_sound_device, current_sound): Now static.
1793 * search.c (searchbufs, searchbuf_head): Now static.
1795 * scroll.c (scroll_cost): Remove; unused.
1796 * dispextern.h (scroll_cost): Remove decl.
1798 * region-cache.h (pp_cache): Mark as externally visible.
1800 * process.c: Make symbols static if they're not exported.
1801 (process_tick, update_tick, create_process, chan_process):
1802 (Vprocess_alist, proc_buffered_char, datagram_access):
1803 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1804 (deactivate_process): Mark defn as static, as well as decl.
1805 * lisp.h (create_process): Remove decl.
1806 * process.h (chan_process, Vprocess_alist): Remove decls.
1808 * print.c: Make symbols static if they're not exported.
1809 (print_depth, new_backquote_output, being_printed, print_buffer):
1810 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1811 (print_interval, print_number_index, initial_stderr_stream):
1813 * lisp.h (Fprinc): Remove decl.
1814 (debug_output_compilation_hack): Mark as externally visible.
1816 * sysdep.c (croak): Move decl from here to syssignal.h.
1817 * syssignal.h (croak): Put it here, so the API can be checked when
1818 'croak' is called from dissociate_if_controlling_tty.
1820 * minibuf.c: Make symbols static if they're not exported.
1821 (minibuf_save_list, choose_minibuf_frame): Now static.
1822 * lisp.h (choose_minibuf_frame): Remove decl.
1824 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1826 * lread.c: Make symbols static if they're not exported.
1827 (read_objects, initial_obarray, oblookup_last_bucket_number):
1829 (make_symbol): Remove; unused.
1830 * lisp.h (initial_obarray, make_symbol): Remove decls.
1832 * keyboard.c: Make symbols static if they're not exported.
1833 (single_kboard, recent_keys_index, total_keys, recent_keys):
1834 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1835 (this_single_command_key_start, echoing, last_auto_save):
1836 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1837 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1838 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1839 (Vlispy_mouse_stem, double_click_count):
1841 (force_auto_save_soon): Define only if SIGDANGER.
1842 (ignore_mouse_drag_p): Now static if
1843 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1844 (print_help): Remove; unused.
1845 (stop_character, last_timer_event): Mark as externally visible.
1846 * keyboard.h (ignore_mouse_drag_p): Declare only if
1847 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1848 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1849 * lisp.h (echoing): Remove decl.
1850 (force_auto_save_soon): Declare only if SIGDANGER.
1851 * xdisp.c (redisplay_window): Simplify code, to make it more
1852 obvious that ignore_mouse_drag_p is not accessed if !defined
1853 USE_GTK && !defined HAVE_NS.
1855 * intervals.c: Make symbols static if they're not exported.
1856 (merge_properties_sticky, merge_interval_right, delete_interval):
1858 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1860 * insdel.c: Make symbols static if they're not exported.
1861 However, leave prepare_to_modify_buffer alone. It's never
1862 called from outside this function, but that appears to be a bug.
1863 (combine_after_change_list, combine_after_change_buffer):
1864 (adjust_after_replace, signal_before_change): Now static.
1865 (adjust_after_replace_noundo): Remove; unused.
1866 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1867 (signal_before_change): Remove decls.
1869 * indent.c (val_compute_motion, val_vmotion): Now static.
1871 * image.c: Make symbols static if they're not exported.
1872 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1874 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1875 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1877 * fringe.c (standard_bitmaps): Now static.
1878 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1880 * frame.c: Make symbols static if they're not exported.
1881 (x_report_frame_params, make_terminal_frame): Now static.
1882 (get_frame_param): Now static, unless HAVE_NS.
1883 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1884 (x_get_resource_string): Remove; not used.
1885 * frame.h (make_terminal_frame, x_report_frame_params):
1886 (x_get_resource_string); Remove decls.
1887 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1888 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1890 * font.c, fontset.c: Make symbols static if they're not exported.
1891 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1892 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1893 * font.c (font_close_object): Now static.
1894 * font.h (font_close_object): Remove.
1895 * fontset.c (FONTSET_OBJLIST): Remove.
1896 (free_realized_fontset) #if-0 the body, which does nothing.
1897 (face_suitable_for_char_p): #if-0, as it's never called.
1898 * fontset.h (face_suitable_for_char_p): Remove decl.
1899 * xfaces.c (face_at_string_position):
1900 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1901 since 0 is always ASCII.
1903 * fns.c (weak_hash_tables): Now static.
1905 * fileio.c: Make symbols static if they're not exported.
1906 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1907 (Vwrite_region_annotation_buffers): Now static.
1909 * eval.c: Make symbols static if they're not exported.
1910 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1911 * lisp.h (backtrace_list): Remove decl.
1913 * emacs.c: Make symbols static if they're not exported.
1914 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1915 (fatal_error_code, fatal_error_signal_hook, standard_args):
1917 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1918 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1919 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1920 * lisp.h (fatal_error_signal_hook): Remove decl.
1921 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1923 * editfns.c: Move a (normally-unused) function to its only use.
1924 * editfns.c, lisp.h (get_operating_system_release): Remove.
1925 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1926 worth the hassle of breaking this out.
1928 * xterm.c: Make symbols static if they're not exported.
1929 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1930 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1931 (x_destroy_window, x_delete_display):
1933 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1934 (x_mouse_leave): Remove; unused.
1935 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1936 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1937 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1939 (x_mouse_leave): Declare only if WINDOWSNT.
1940 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1941 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1944 * ftxfont.c: Make symbols static if they're not exported.
1945 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1947 * font.h (ftxfont_driver): Likewise.
1949 * xfns.c: Make symbols static if they're not exported.
1950 (x_last_font_name, x_display_info_for_name):
1951 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1952 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1953 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1954 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1955 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1956 (last_show_tip_args): Now static.
1957 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1958 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1959 (x_screen_planes): Remove; unused.
1960 * dispextern.h (x_screen_planes): Remove decl.
1962 * dispnew.c: Make symbols static if they're not exported.
1963 * dispextern.h (redraw_garbaged_frames, scrolling):
1964 (increment_row_positions): Remove.
1965 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1966 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1968 (redraw_garbaged_frames): Remove; unused.
1970 * xfaces.c: Make symbols static if they're not exported.
1971 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1973 * xterm.h (defined_color): Remove decls.
1974 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1975 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1976 (menu_face_changed_default, defined_color, free_realized_face):
1977 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1978 (ascii_face_of_lisp_face): Remove; unused.
1980 * xdisp.c: Make symbols static if they're not exported.
1981 * dispextern.h (scratch_glyph_row, window_box_edges):
1982 (glyph_to_pixel_coords, set_cursor_from_row):
1983 (get_next_display_element, set_iterator_to_next):
1984 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1985 (show_mouse_face): Remove decls
1986 * frame.h (message_buf_print): Likewise.
1987 * lisp.h (pop_message, set_message, check_point_in_composition):
1989 * xterm.h (set_vertical_scroll_bar): Likewise.
1990 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1991 (message_buf_print, scratch_glyph_row, displayed_buffer):
1992 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1993 (get_next_display_element, show_mouse_face, window_box_edges):
1994 (frame_to_window_pixel_xy, check_point_in_composition):
1995 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1996 (glyph_to_pixel_coords): Remove; unused.
1998 * dired.c (file_name_completion): Now static.
2000 * dbusbind.c (xd_in_read_queued_messages): Now static.
2002 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2003 * data.c (circular_list_error): Remove.
2005 * commands.h (last_point_position, last_point_position_buffer):
2006 (last_point_position_window): Remove decls.
2007 * keyboard.c: Make these variables static.
2009 * coding.h (coding, code_convert_region, encode_coding_gap):
2011 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2012 (iso_code_class, detect_coding, code_convert_region): Now static.
2013 (encode_coding_gap): Remove; unused.
2015 * chartab.c (chartab_chars, chartab_bits): Now static.
2017 * charset.h (charset_iso_8859_1): Remove decl.
2018 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2021 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2022 * ccl.c (Vccl_program_table): Now static.
2023 (check_ccl_update): Remove; unused.
2025 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2026 * category.h: ... from here.
2027 * category.c (check_category_table, set_category_set): Now static.
2029 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2030 * lisp.h: Remove these decls.
2032 * buffer.c (buffer_count): Remove unused var.
2034 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2035 so that it's not optimized away.
2036 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2037 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2038 exported only to the debugger.
2040 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2041 * atimer.h (run_all_atimers): Remove; not exported.
2043 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2044 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2045 was inaccessible from Lisp.
2046 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2047 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2049 alloc.c: Import and export fewer symbols, and remove unused items.
2050 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2052 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2053 it's not optimized away by whole-program optimization.
2054 (message_enable_multibyte, free_misc): Remove.
2055 (catchlist, handlerlist, mark_backtrace):
2056 Declare only if BYTE_MARK_STACK.
2057 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2058 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2059 (message_enable_multibyte): Remove decl.
2060 (free_misc, interval_free_list, float_block, float_block_index):
2061 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2062 (cons_free_list, last_marked_index):
2064 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2065 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2066 (mark_backtrace): Define only if BYTE_MARK_STACK.
2067 * xdisp.c (message_enable_multibyte): Now static.
2069 Declare Lisp_Object Q* variables to be 'static' if not exported.
2070 This makes it easier for human readers (and static analyzers)
2071 to see whether these variables are used from other modules.
2072 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2073 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2074 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2075 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2076 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2077 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2078 * xmenu.c, xselect.c:
2079 Declare Q* vars static if they are not used in other modules.
2080 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2081 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2082 Remove decls of unexported vars.
2083 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2085 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2087 Make Emacs functions such as Fatom 'static' by default.
2088 This makes it easier for human readers (and static analyzers)
2089 to see whether these functions can be called from other modules.
2090 DEFUN now defines a static function. To make the function external
2091 so that it can be used in other C modules, use the new macro DEFUE.
2092 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2093 (Finit_image_library):
2094 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2095 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2096 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2097 Remove decls, since these functions are now static.
2098 (Funintern, Fget_internal_run_time): New decls, since these functions
2099 were already external.
2101 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2102 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2103 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2104 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2105 * keyboard.c, keymap.c, lread.c:
2106 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2107 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2108 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2109 Mark functions with DEFUE instead of DEFUN,
2110 if they are used in other modules.
2111 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2112 decls for now-static functions.
2113 * buffer.h (Fdelete_overlay): Remove decl.
2114 * callproc.c (Fgetenv_internal): Mark as internal.
2115 * composite.c (Fremove_list_of_text_properties): Remove decl.
2116 (Fcomposition_get_gstring): New forward static decl.
2117 * composite.h (Fcomposite_get_gstring): Remove decl.
2118 * dired.c (Ffile_attributes): New forward static decl.
2119 * doc.c (Fdocumntation_property): New forward static decl.
2120 * eval.c (Ffetch_bytecode): New forward static decl.
2121 (Funintern): Remove extern decl; now in .h file where it belongs.
2122 * fileio.c (Fmake_symbolic_link): New forward static decl.
2123 * image.c (Finit_image_library): New forward static decl.
2124 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2125 * intervals.h (Fprevious_property_change):
2126 (Fremove_list_of_text_properties): Remove decls.
2127 * keyboard.c (Fthis_command_keys): Remove decl.
2128 (Fcommand_execute): New forward static decl.
2129 * keymap.c (Flookup_key): New forward static decl.
2130 (Fcopy_keymap): Now static.
2131 * keymap.h (Flookup_key): Remove decl.
2132 * process.c (Fget_process): New forward static decl.
2133 (Fprocess_datagram_address): Mark as internal.
2134 * syntax.c (Fsyntax_table_p): New forward static decl.
2135 (skip_chars): Remove duplicate decl.
2136 * textprop.c (Fprevious_property_change): New forward static decl.
2137 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2139 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2140 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2142 * editfns.c (Fformat): Remove unreachable code.
2144 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2146 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2149 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2151 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2152 when at ZV. (Bug#8487)
2154 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2156 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2158 * keyboard.c (parse_tool_bar_item): Likewise.
2159 * sound.c (sound_cleanup, alsa_close): Likewise.
2160 * termcap.c (tgetent): Likewise.
2161 * xfns.c (x_default_font_parameter): Likewise.
2162 * xsettings.c (read_and_apply_settings): Likewise.
2164 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2165 (overrun_check_free): Protoize.
2167 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2169 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2170 since callers should never pass a negative size.
2171 Change the signature to match that of plain 'read' and 'write'; see
2172 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2173 * lisp.h: Update prototypes of emacs_write and emacs_read.
2175 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2177 * xdisp.c (redisplay_window): Don't try to determine the character
2178 position of the scroll margin if the window start point w->startp
2179 is outside the buffer's accessible region. (Bug#8468)
2181 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2183 Fix write-region and its subroutines for buffers > 2GB.
2184 * fileio.c (a_write, e_write): Modify declaration of arguments and
2185 local variables to support buffers larger than 2GB.
2186 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2188 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2189 argument, local variables, and return value.
2191 * lisp.h: Update prototypes of emacs_write and emacs_read.
2193 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2195 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2197 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2199 Fix more problems found by GCC 4.6.0's static checks.
2201 * xdisp.c (vmessage): Use a better test for character truncation.
2203 * charset.c (load_charset_map): <, not <=, for optimization,
2204 and to avoid potential problems with integer overflow.
2205 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2206 * casetab.c (set_identity, shuffle): Likewise.
2207 * editfns.c (Fformat): Likewise.
2208 * syntax.c (skip_chars): Likewise.
2210 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2211 This also lets GCC 4.6.0 generate slightly better loop code.
2213 * callint.c (Fcall_interactively): <, not <=, for optimization.
2214 (Fcall_interactively): Count the number of arguments produced,
2215 not the number of arguments given. This is simpler and lets GCC
2216 4.6.0 generate slightly better code.
2218 * ftfont.c: Distingish more carefully between FcChar8 and char.
2219 The previous code passed unsigned char * to a functions like
2220 strlen and xstrcasecmp that expect char *, which does not
2221 conform to the C standard.
2222 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2223 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2224 char * when the C standard requires it.
2226 * keyboard.c (read_char): Remove unused var.
2228 * eval.c: Port to Windows vsnprintf (Bug#8435).
2230 (SIZE_MAX): Define if the headers do not.
2231 (verror): Do not give up if vsnprintf returns a negative count.
2232 Instead, grow the buffer. This ports to Windows vsnprintf, which
2233 does not conform to C99. Problem reported by Eli Zaretskii.
2234 Also, simplify the allocation scheme, by avoiding the need for
2235 calling realloc, and removing the ALLOCATED variable.
2237 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2239 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2240 But keep the doprint source code for now, as we might revamp it
2241 and use it again (Bug#8435).
2242 * lisp.h (doprnt): Remove.
2243 * Makefile.in (base_obj): Remove doprnt.o.
2244 * deps.mk (doprnt.o): Remove.
2246 error: Print 32- and 64-bit integers portably (Bug#8435).
2247 Without this change, on typical 64-bit hosts error ("...%d...", N)
2248 was used to print both 32- and 64-bit integers N, which relied on
2250 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2252 * lisp.h (error, verror): Mark as printf-like functions.
2253 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2254 Report overflow in size calculations when allocating printf buffer.
2255 Do not truncate output string at its first null byte.
2256 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2257 Truncate the output at a character boundary, since vsnprintf does not
2259 * charset.c (check_iso_charset_parameter): Convert internal
2260 character to string before calling 'error', since %c now has the
2262 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2263 overflow when computing char to be passed to 'error'. Do not
2264 pass Lisp_Object to 'error'; pass the integer instead.
2265 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2266 formatted with plain %d.
2268 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2270 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2272 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2274 * xterm.c (x_catch_errors): Remove duplicate declaration.
2276 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2278 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2280 2011-04-10 Jim Meyering <meyering@redhat.com>
2282 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2283 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2284 return ssize_t not "int", and use size_t as the buffer length.
2285 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2286 * gnutls.h: Update declarations.
2287 * process.c (read_process_output): Use ssize_t, to match.
2288 (send_process): Likewise.
2290 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2292 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2294 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2296 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2297 Use unsigned char, to match FcChar8 type definition.
2299 * xterm.c (handle_one_xevent):
2300 * xmenu.c (create_and_show_popup_menu):
2301 * xselect.c (x_decline_selection_request)
2302 (x_reply_selection_request): Avoid type-punned deref of X events.
2304 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2306 Fix some uses of `int' instead of EMACS_INT.
2307 * search.c (string_match_1, fast_string_match)
2308 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2309 (scan_buffer, find_next_newline_no_quit)
2310 (find_before_next_newline, search_command, Freplace_match)
2311 (Fmatch_data): Make some `int' variables be EMACS_INT.
2313 * xdisp.c (display_count_lines): 3rd argument and return value now
2314 EMACS_INT. All callers changed.
2315 (pint2hrstr): Last argument is now EMACS_INT.
2317 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2318 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2319 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2320 (decode_coding_utf_16, decode_coding_emacs_mule)
2321 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2322 (decode_coding_ccl, decode_coding_charset)
2323 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2324 (decode_coding_iso_2022, decode_coding_emacs_mule)
2325 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2326 <char_offset, last_offset>: Declare EMACS_INT.
2327 (encode_coding_utf_8, encode_coding_utf_16)
2328 (encode_coding_emacs_mule, encode_invocation_designation)
2329 (encode_designation_at_bol, encode_coding_iso_2022)
2330 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2331 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2333 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2334 (encode_invocation_designation): Last argument P_NCHARS is now
2336 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2337 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2339 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2342 * ccl.c (Fccl_execute_on_string): Declare some variables
2345 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2347 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2349 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2351 * process.c (Fformat_network_address): Doc fix.
2353 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2355 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2357 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2359 * keyboard.c (read_char): Call Lisp function help-form-show,
2360 instead of using internal_with_output_to_temp_buffer.
2361 (Qhelp_form_show): New var.
2362 (syms_of_keyboard): Use DEFSYM macro.
2364 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2366 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2368 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2370 * process.c (Flist_processes): Remove to Lisp.
2371 (list_processes_1): Delete.
2373 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2375 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2377 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2379 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2381 Fix more problems found by GCC 4.6.0's static checks.
2383 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2385 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2387 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2389 * xdisp.c (vmessage): Mark as a printf-like function.
2391 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2393 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2395 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2396 printf-like functions.
2397 (tiff_load): Add casts to remove these marks before passing them
2398 to system-supplied API.
2400 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2402 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2403 This avoids several warnings with gcc -Wstrict-overflow.
2404 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2405 directly, rather than having caller test rule sign. This avoids
2406 some unnecessary tests.
2407 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2408 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2409 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2411 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2412 (xfont_open): Avoid unnecessary tests.
2414 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2416 * composite.h, composite.c (composition_gstring_put_cache):
2417 Use EMACS_INT, not int, for length.
2419 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2420 breaking out part of COMPOSITION_DECODE_RULE.
2421 (COMPOSITION_DECODE_RULE): Use it.
2422 * composite.c (get_composition_id): Remove unused local vars,
2423 by using the new macro.
2425 * textprop.c (set_text_properties_1): Change while to do-while,
2426 since the condition is always true at first.
2428 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2429 (interval_deletion_adjustment): Return unsigned value.
2432 * process.c (list_processes_1, create_pty, read_process_output):
2433 (exec_sentinel): Remove vars that were set but not used.
2434 (create_pty): Remove unnecessary "volatile"s.
2435 (Fnetwork_interface_info): Avoid possibility of int overflow.
2436 (read_process_output): Do adaptive read buffering even if carryover.
2437 (read_process_output): Simplify nbytes computation if buffered.
2439 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2441 * syntax.c (scan_words): Remove var that was set but not used.
2442 (update_syntax_table): Use unsigned instead of int.
2444 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2445 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2446 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2448 * print.c (print_error_message): Avoid int overflow.
2450 * font.c (font_list_entities): Redo for clarity,
2451 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2453 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2454 (font_score): Avoid potential overflow in diff calculation.
2456 * fns.c (substring_both): Remove var that is set but not used.
2457 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2459 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2461 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2462 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2463 can always succeed if overflow has undefined behavior.
2465 * search.c (boyer_moore, wordify): Remove vars set but not used.
2466 (wordify): Omit three unnecessary tests.
2468 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2469 All callers changed. This avoids the need for an unused var.
2471 * casefiddle.c (casify_region): Remove var that is set but not used.
2473 * dired.c (file_name_completion): Remove var that is set but not used.
2475 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2477 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2478 (Finsert_file_contents): Remove unnecessary code checking fd.
2480 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2481 Check for integer overflow on size calculations.
2483 * buffer.c (Fprevious_overlay_change): Remove var that is set
2486 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2487 Remove vars that are set but not used.
2488 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2489 (timer_check_2): Mark vars as initialized.
2491 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2493 * image.c (lookup_image): Remove var that is set but not used.
2494 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2496 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2497 that are set but not used.
2499 * xfns.c (make_invisible_cursor): Don't return garbage
2500 if XCreateBitmapFromData fails (Bug#8410).
2502 * xselect.c (x_get_local_selection, x_handle_property_notify):
2503 Remove vars that are set but not used.
2505 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2506 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2508 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2509 Remove var that is set but not used.
2510 (scroll_bar_windows_size): Now size_t, not int.
2511 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2514 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2515 (map_tty_color) [!defined MSDOS]: Likewise.
2517 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2519 * coding.c: Remove vars that are set but not used.
2520 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2521 All callers changed.
2522 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2523 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2524 (decode_coding_charset): Remove vars that are set but not used.
2526 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2527 that is set but not used.
2529 * print.c (print_object): Remove var that is set but not used.
2531 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2532 The gnulib version avoids calling malloc in the usual case,
2533 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2534 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2535 * filelock.c (current_lock_owner): Likewise.
2536 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2537 * sysdep.c: Include allocator.h, careadlinkat.h.
2538 (emacs_no_realloc_allocator): New static constant.
2539 (emacs_readlink): New function.
2540 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2541 ../lib/careadlinkat.h.
2543 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2545 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2546 first non-nil return value).
2548 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2550 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2551 if not defined (Bug#8403).
2553 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2555 * xdisp.c (display_count_lines): Remove parameter `start',
2556 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2557 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2558 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2559 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2560 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2561 and thereabouts. All callers changed.
2562 (get_per_char_metric): Remove parameter `f', unused since
2563 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2565 2011-04-02 Jim Meyering <meyering@redhat.com>
2567 do not dereference NULL upon failed strdup
2568 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2569 (ns_get_family): Likewise.
2571 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2573 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2575 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2577 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2580 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2582 Add lexical binding.
2584 * window.c (Ftemp_output_buffer_show): New fun.
2585 (Fsave_window_excursion):
2586 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2588 * lread.c (lisp_file_lexically_bound_p): New function.
2589 (Fload): Bind Qlexical_binding.
2590 (readevalloop): Remove `evalfun' arg.
2591 Bind Qinternal_interpreter_environment.
2592 (Feval_buffer): Bind Qlexical_binding.
2593 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2595 (syms_of_lread): Declare `lexical-binding'.
2597 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2599 * keyboard.c (eval_dyn): New fun.
2600 (menu_item_eval_property): Use it.
2602 * image.c (parse_image_spec): Use Ffunctionp.
2604 * fns.c (concat, mapcar1): Accept byte-code-functions.
2606 * eval.c (Fsetq): Handle lexical vars.
2607 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2608 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2609 (FletX, Flet): Obey lexical binding.
2610 (Fcommandp): Handle closures.
2611 (Feval): New `lexical' arg.
2612 (eval_sub): New function extracted from Feval. Use it almost
2613 everywhere where Feval was used. Look up vars in lexical env.
2615 (Ffunctionp): Move from subr.el.
2616 (Ffuncall): Handle closures.
2617 (apply_lambda): Remove `eval_flags'.
2618 (funcall_lambda): Handle closures and new byte-code-functions.
2619 (Fspecial_variable_p): New function.
2620 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2621 but without exporting it to Lisp.
2623 * doc.c (Fdocumentation, store_function_docstring):
2624 * data.c (Finteractive_form): Handle closures.
2626 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2629 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2631 (exec_byte_code): New function extracted from Fbyte_code to handle new
2632 calling convention for byte-code-functions. Add new byte-codes.
2634 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2636 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2638 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2640 * xdisp.c (redisplay_internal): Fix prototype.
2642 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2644 * xdisp.c (SCROLL_LIMIT): New macro.
2645 (try_scrolling): Use it when setting scroll_limit.
2646 Limit scrolling to 100 screen lines.
2647 (redisplay_window): Even when falling back on "recentering",
2648 position point in the window according to scroll-conservatively,
2649 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2651 (try_scrolling): When point is above the window, allow searching
2652 as far as scroll_max, or one screenful, to compute vertical
2653 distance from PT to the scroll margin position. This prevents
2654 try_scrolling from unnecessarily failing when
2655 scroll-conservatively is set to a value slightly larger than the
2656 window height. Clean up the case of PT below the margin at bottom
2657 of window: scroll_max can no longer be INT_MAX. When aggressive
2658 scrolling is in use, don't let point enter the opposite scroll
2659 margin as result of the scroll.
2660 (syms_of_xdisp) <scroll-conservatively>: Document the
2661 threshold of 100 lines for never-recentering scrolling.
2663 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2665 * dispextern.h (move_it_by_lines):
2666 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2667 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2668 (message_log_check_duplicate): Remove parameters `prev_bol' and
2669 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2670 (redisplay_internal): Remove parameter `preserve_echo_area',
2671 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2673 * indent.c (Fvertical_motion):
2674 * window.c (window_scroll_pixel_based, Frecenter):
2675 Don't pass `need_y_p' to `move_it_by_lines'.
2677 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2679 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2680 steal a few bits to be more compact.
2681 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2682 Remove unneeded casts.
2684 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2686 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2688 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2689 binding" message (bug#7967).
2691 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2693 Fix more problems found by GCC 4.6.0's static checks.
2695 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2696 Remove unused local var.
2698 * editfns.c (Fmessage_box): Remove unused local var.
2700 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2701 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2702 Omit unused local vars.
2703 * window.c (shrink_windows): Omit unused local var.
2704 * menu.c (digest_single_submenu): Omit unused local var.
2705 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2706 Omit unused local var.
2708 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2709 Don't assume string length fits in int.
2710 (keyremap_step, read_key_sequence): Use size_t for sizes.
2711 (read_key_sequence): Don't check last_real_key_start redundantly.
2713 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2714 instead of alloca (Bug#8344).
2716 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2717 (Fbacktrace_frame): Don't assume nframes fits in int.
2719 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2721 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2724 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2726 * cm.c (calccost): Turn while-do into do-while, for clarity.
2728 * keyboard.c (syms_of_keyboard): Use the same style as later
2729 in this function when indexing through an array. This also
2730 works around GCC bug 48267.
2732 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2734 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2736 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2737 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2739 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2740 This avoids undefined behavior on integer overflow, and is a bit
2741 more convenient anyway since it is compared to a size_t variable.
2743 Variadic C functions now count arguments with size_t, not int.
2744 This avoids an unnecessary limitation on 64-bit machines, which
2745 caused (substring ...) to crash on large vectors (Bug#8344).
2746 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2747 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2748 All variadic functions and their callers changed accordingly.
2749 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2750 * data.c (arith_driver, float_arith_driver): Likewise.
2751 * editfns.c (general_insert_function): Likewise.
2752 * eval.c (struct backtrace.nargs, interactive_p)
2753 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2754 (funcall_lambda, mark_backtrace): Likewise.
2755 * fns.c (concat): Likewise.
2756 * frame.c (x_set_frame_parameters): Likewise.
2757 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2758 0 if not found, not -1. All callers changed.
2760 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2761 (stack_copy_size): Now size_t, not int.
2762 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2764 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2766 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2767 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2768 All callers changed.
2770 * lisp.h (multibyte_char_to_unibyte):
2771 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2772 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2773 * character.h (CHAR_TO_BYTE8):
2774 * cmds.c (internal_self_insert):
2775 * editfns.c (general_insert_function):
2776 * keymap.c (push_key_description):
2777 * search.c (Freplace_match):
2778 * xdisp.c (message_dolog, set_message_1): All callers changed.
2780 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2782 * keyboard.c (safe_run_hook_funcall): New function.
2783 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2784 don't set the hook to nil, but remove the offending function instead.
2785 (Qcommand_hook_internal): Remove, unused.
2786 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2787 Vcommand_hook_internal.
2789 * eval.c (enum run_hooks_condition): Remove.
2790 (funcall_nil, funcall_not): New functions.
2791 (run_hook_with_args): Call each function through a `funcall' argument.
2792 Remove `cond' argument, now redundant.
2793 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2794 (Frun_hook_with_args_until_failure): Adjust accordingly.
2795 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2797 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2799 * dispextern.h (string_buffer_position): Remove declaration.
2801 * print.c (strout): Remove parameter `multibyte', unused since
2802 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2804 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2805 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2806 All callers changed.
2808 * w32.c (_wsa_errlist): Use braces for struct initializers.
2810 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2811 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2812 All callers changed.
2813 (string_buffer_position): Likewise. Also, make static (it's never
2814 used outside xdisp.c).
2815 (cursor_row_p): Remove parameter `w', unused since
2816 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2817 (decode_mode_spec): Remove parameter `precision', introduced during
2818 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2819 All callers changed.
2821 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2823 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2825 2011-03-27 Anders Lindgren <andlind@gmail.com>
2827 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2828 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2829 (ns_update_auto_hide_menu_bar): New functions.
2830 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2831 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2832 ns_constrain_all_frames.
2833 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2834 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2836 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2838 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2840 2011-03-27 Glenn Morris <rgm@gnu.org>
2842 * syssignal.h: Replace RETSIGTYPE with void.
2843 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2844 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2845 Replace SIGTYPE with void everywhere.
2846 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2847 * s/template.h (SIGTYPE): Remove commented out definition.
2849 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2851 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2852 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2854 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2856 * w32.c (read_unc_volume): Use parameter `henum', instead of
2857 global variable `wget_enum_handle'.
2859 * keymap.c (describe_vector): Remove parameters `indices' and
2860 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2861 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2863 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2865 * keyboard.c (timer_check): Remove parameter `do_it_now',
2866 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2867 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2868 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2870 * keyboard.c (read_char):
2871 * w32menu.c (w32_menu_display_help):
2872 * xmenu.c (show_help_event, menu_help_callback):
2873 Adjust calls to `show_help_echo'.
2875 * gtkutil.c (xg_maybe_add_timer):
2876 * keyboard.c (readable_events):
2877 * process.c (wait_reading_process_output):
2878 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2880 * insdel.c (adjust_markers_gap_motion):
2881 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2882 (gap_left, gap_right): Don't call it.
2884 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2886 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2887 incurred during fontification.
2889 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2891 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2892 (DEFVAR_PER_BUFFER): Don't pass it.
2894 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2895 (scrolling_window): Don't pass it.
2897 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2899 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2901 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2903 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2904 of variables specific to SELinux and computation of `encoded_absname'.
2906 * image.c (XPutPixel): Remove unused variable `height'.
2908 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2910 * unexw32.c (get_section_info): Remove unused variable `section'.
2912 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2913 (system_process_attributes): Remove unused variable `sess'.
2914 (sys_read): Remove unused variable `err'.
2916 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2917 (w32_wnd_proc): Remove unused variable `isdead'.
2918 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2919 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2920 (x_create_tip_frame): Remove unused variable `tem'.
2922 * w32inevt.c (w32_console_read_socket):
2923 Remove unused variable `no_events'.
2925 * w32term.c (x_draw_composite_glyph_string_foreground):
2926 Remove unused variable `width'.
2928 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2930 * w32term.c (x_set_glyph_string_clipping):
2931 Don't pass uninitialized region to CombineRgn.
2933 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2935 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2936 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2937 (Fx_close_connection): Remove unused variable `i'.
2939 * w32font.c (w32font_draw): Return number of glyphs.
2940 (w32font_open_internal): Remove unused variable `i'.
2941 (w32font_driver): Add missing initializer.
2943 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2944 (fill_in_menu): Remove unused variable `items_added'.
2946 * w32term.c (last_mouse_press_frame): Remove static global variable.
2947 (w32_clip_to_row): Remove unused variable `f'.
2948 (x_delete_terminal): Remove unused variable `i'.
2950 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2951 (NOTHING): Remove unused static global variable.
2952 (uniscribe_check_otf): Remove unused variable `table'.
2953 (uniscribe_font_driver): Add missing initializers.
2955 2011-03-23 Julien Danjou <julien@danjou.info>
2957 * term.c (Fsuspend_tty, Fresume_tty):
2958 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2959 * window.c (temp_output_buffer_show):
2960 * insdel.c (signal_before_change):
2961 * frame.c (Fhandle_switch_frame):
2962 * fileio.c (Fdo_auto_save):
2963 * emacs.c (Fkill_emacs):
2964 * editfns.c (save_excursion_restore):
2965 * cmds.c (internal_self_insert):
2966 * callint.c (Fcall_interactively):
2967 * buffer.c (Fkill_all_local_variables):
2968 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2970 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2971 unconditionnaly since it does the check itself.
2973 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2975 Fix more problems found by GCC 4.5.2's static checks.
2977 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2978 the first time through the loop, since we know p0 < p1 then.
2979 This also avoids a gcc -Wstrict-overflow warning.
2981 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2982 leading to a memory leak, possible in functions like
2983 load_charset_map_from_file that can allocate an unbounded number
2984 of objects (Bug#8318).
2986 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2987 that could (at least in theory) be that large.
2989 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2990 This is less likely to overflow, and avoids undefined behavior if
2991 overflow does occur. All callers changed. Use strtoul to scan
2992 for the unsigned long integer.
2993 (pint2hrstr): Simplify and tune code slightly.
2994 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2996 * scroll.c (do_scrolling): Work around GCC bug 48228.
2997 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2999 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3000 This also avoids a warning with gcc -Wstrict-overflow.
3001 (validate_x_resource_name): Simplify count usage.
3002 This also avoids a warning with gcc -Wstrict-overflow.
3004 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3007 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3009 * process.c (Fmake_network_process): Use socklen_t, not int,
3010 where POSIX says socklen_t is required in portable programs.
3011 This fixes a porting bug on hosts like 64-bit HP-UX, where
3012 socklen_t is wider than int (Bug#8277).
3013 (Fmake_network_process, server_accept_connection):
3014 (wait_reading_process_output, read_process_output):
3017 * process.c: Rename or move locals to avoid shadowing.
3018 (list_processes_1, Fmake_network_process):
3019 (read_process_output_error_handler, exec_sentinel_error_handler):
3020 Rename or move locals.
3021 (Fmake_network_process): Define label "retry_connect" only if needed.
3022 (Fnetwork_interface_info): Fix pointer signedness.
3023 (process_send_signal): Add cast to avoid pointer signedness problem.
3024 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3025 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3027 Make tparam.h and terminfo.c consistent.
3028 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3029 Include tparam.h instead, since it declares them.
3030 * cm.h (PC): Remove extern decl; tparam.h now does this.
3031 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3032 * terminfo.c: Include tparam.h, to check interfaces.
3033 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3034 (tparam): Adjust signature to match interface in tparam.h;
3035 this removes some undefined behavior. Check that outstring and len
3036 are zero, which they always are with Emacs.
3037 * tparam.h (PC, BC, UP): New extern decls.
3039 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3040 (xftfont_open): Rename locals to avoid shadowing.
3042 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3043 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3044 (OTF_TAG_SYM): Omit macro if not needed.
3045 (ftfont_list): Remove unused local.
3046 (get_adstyle_property, ftfont_pattern_entity):
3047 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3048 Rename locals to avoid shadowing.
3050 * xfont.c (xfont_list_family): Mark var as initialized.
3052 * xml.c (make_dom): Now static.
3054 * composite.c (composition_compute_stop_pos): Rename local to
3056 (composition_reseat_it): Remove unused locals.
3057 (find_automatic_composition, composition_adjust_point): Likewise.
3058 (composition_update_it): Mark var as initialized.
3059 (find_automatic_composition): Mark vars as initialized,
3060 with a FIXME (Bug#8290).
3062 character.h: Rename locals to avoid shadowing.
3063 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3064 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3065 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3066 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3069 * textprop.c (property_change_between_p): Remove; unused.
3071 * intervals.c (interval_start_pos): Now static.
3073 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3075 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3076 Rename locals to avoid shadowing.
3078 * sound.c (wav_play, au_play, Fplay_sound_internal):
3079 Fix pointer signedness.
3080 (alsa_choose_format): Remove unused local var.
3081 (wav_play): Initialize a variable to 0, to prevent undefined
3082 behavior (Bug#8278).
3084 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3086 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3088 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3089 clobbering (Bug#8298).
3090 * sysdep.c (sys_subshell): Likewise.
3091 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3093 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3094 This should get cleaned up, so that child_setup has the
3095 same signature on all platforms.
3097 * callproc.c (call_process_cleanup): Now static.
3098 (relocate_fd): Rename locals to avoid shadowing.
3100 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3102 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3103 not to be necessary, and produces flickering.
3105 2011-03-20 Glenn Morris <rgm@gnu.org>
3107 * config.in: Remove file.
3109 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3111 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3112 are now in src/globals.h.
3113 (syms_of_minibuf): Remove spurious & from previous change.
3115 2011-03-20 Leo <sdl.web@gmail.com>
3117 * minibuf.c (completing-read-function): New variable.
3118 (completing-read-default): Rename from completing-read.
3119 (completing-read): Call completing-read-function.
3121 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3123 * xfaces.c (Fx_load_color_file):
3124 Read color file from absolute filename (bug#8250).
3126 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3128 * makefile.w32-in: Update dependencies.
3130 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3132 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3134 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3136 Fix more problems found by GCC 4.5.2's static checks.
3138 * process.c (make_serial_process_unwind, send_process_trap):
3139 (sigchld_handler): Now static.
3141 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3142 That way, the code declares only the vars that it needs.
3143 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3144 * s/cygwin.h (PTY_ITERATION): Likewise.
3145 * s/darwin.h (PTY_ITERATION): Likewise.
3146 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3148 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3149 * process.c (allocate_pty): Don't declare stb unless it's needed.
3151 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3152 (CONSTANTLIM): Remove; unused.
3153 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3154 Define only if needed.
3156 * unexelf.c (unexec): Name an expression,
3157 to avoid gcc -Wbad-function-cast warning.
3158 Use a different way to cause a compilation error if anyone uses
3159 n rather than nn, a way that does not involve shadowing.
3160 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3162 * deps.mk (unexalpha.o): Remove; unused.
3164 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3165 * unexec.h: New file.
3166 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3167 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3169 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3170 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3171 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3172 Change as necessary to match prototype in unexec.h.
3174 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3176 (back_comment, skip_chars): Mark vars as initialized.
3178 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3179 Rename locals to avoid shadowing.
3181 * lread.c (read1): Rewrite so as not to use empty "else".
3182 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3184 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3186 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3187 warning when compiling print.c.
3189 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3190 instead of using an uninitialized var.
3191 (font_sort_entities): Mark var as initialized.
3193 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3195 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3196 pointers to constants.
3197 (font_parse_fcname): Remove unused vars.
3198 (font_delete_unmatched): Now static.
3199 (font_get_spec): Remove; unused.
3200 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3201 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3202 Rename or move locals to avoid shadowing.
3204 * fns.c (require_nesting_list, require_unwind): Now static.
3205 (Ffillarray): Rename locals to avoid shadowing.
3207 * floatfns.c (domain_error2): Define only if needed.
3208 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3210 * alloc.c (mark_backtrace): Move decl from here ...
3211 * lisp.h: ... to here, so that it can be checked.
3213 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3214 (Fdefvar): Rewrite so as not to use empty "else".
3215 (lisp_indirect_variable): Name an expression,
3216 to avoid gcc -Wbad-function-cast warning.
3217 (Fdefvar): Rename locals to avoid shadowing.
3219 * callint.c (quotify_arg, quotify_args): Now static.
3220 (Fcall_interactively): Rename locals to avoid shadowing.
3221 Use const pointer when appropriate.
3223 * lisp.h (get_system_name, get_operating_system_release):
3224 Move decls here, to check interfaces.
3225 * process.c (get_operating_system_release): Move decl to lisp.h.
3226 * xrdb.c (get_system_name): Likewise.
3227 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3228 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3229 some of which prompt warnings from gcc -Wbad-function-cast.
3230 (Fformat_time_string, Fencode_time, Finsert_char):
3231 (Ftranslate_region_internal, Fformat):
3232 Rename or remove local vars to avoid shadowing.
3233 (Ftranslate_region_internal): Mark var as initialized.
3235 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3238 * lisp.h (eassert): Check that the argument compiles, even if
3239 ENABLE_CHECKING is not defined.
3241 * data.c (Findirect_variable): Name an expression, to avoid
3242 gcc -Wbad-function-cast warning.
3243 (default_value, arithcompare, arith_driver, arith_error): Now static.
3244 (store_symval_forwarding): Rename local to avoid shadowing.
3245 (Fmake_variable_buffer_local, Fmake_local_variable):
3246 Mark variables as initialized.
3247 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3249 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3250 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3251 Rename locals to avoid shadowing.
3252 (mark_stack): Move local variables into the #ifdef region where
3254 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3255 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3257 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3258 (GC_STRING_CHARS): Remove; not used.
3259 (Fmemory_limit): Cast sbrk's returned value to char *.
3261 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3262 avoids undefined behavior in theory.
3264 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3266 Use functions, not macros, for up- and down-casing (Bug#8254).
3267 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3268 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3269 to use the following functions instead of these macros.
3270 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3271 EMACS_INT, since callers assume the returned value fits in int.
3272 (upcase1): Likewise, for UPCASE_TABLE.
3273 (uppercasep, lowercasep, upcase): New static inline functions.
3274 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3275 the race-condition problem in the old DOWNCASE.
3277 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3278 Rename locals to avoid shadowing.
3279 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3280 (regex_compile, re_search_2, re_match_2_internal):
3281 Remove unused local vars.
3282 (FREE_VAR): Rewrite so as not to use empty "else",
3283 which gcc can warn about.
3284 (regex_compile, re_match_2_internal): Mark locals as initialized.
3285 (RETALLOC_IF): Define only if needed.
3286 (WORDCHAR_P): Likewise. This one is never needed, but is used
3287 only in a comment talking about a compiler bug, so put inside
3288 the #if 0 of that comment.
3289 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3290 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3293 * search.c (boyer_moore): Rename locals to avoid shadowing.
3294 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3295 (PREV_CHAR_BOUNDARY): Likewise.
3297 * search.c (simple_search): Remove unused var.
3299 * dired.c (compile_pattern): Move decl from here ...
3300 * lisp.h: ... to here, so that it can be checked.
3301 (struct re_registers): New forward decl.
3303 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3305 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3307 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3308 Rename locals to avoid shadowing.
3309 (Fvertical_motion): Mark locals as initialized.
3311 * casefiddle.c (casify_object, casify_region): Now static.
3312 (casify_region): Mark local as initialized.
3314 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3316 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3317 New macros, so that the caller can use some names other than
3318 gcpro1, gcpro2, etc.
3319 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3321 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3322 argument, for consistency with GCPRO2_VAR, etc: it is now the
3323 prefix of the variable, not the variable itself. All uses
3325 * dired.c (directory_files_internal, file_name_completion):
3326 Rename locals to avoid shadowing.
3328 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3329 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3330 dired.c's scmp function, had undefined behavior.
3331 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3332 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3333 * buffer.h: ... to here, because these macros use current_buffer,
3334 and the new implementation with inline functions needs to have
3335 current_buffer in scope now, rather than later when the macros
3337 (downcase, upcase1): New static inline functions.
3338 (DOWNCASE, UPCASE1): Reimplement using these functions.
3339 This avoids undefined behavior in expressions like
3340 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3341 from race conditions in accessing the global variables
3342 case_temp1 and case_temp2.
3343 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3344 * lisp.h (case_temp1, case_temp2): Remove their decls.
3345 * character.h (ASCII_CHAR_P): Move from here ...
3346 * lisp.h: ... to here, so that the inline functions mentioned
3349 * dired.c (directory_files_internal_unwind): Now static.
3351 * fileio.c (file_name_as_directory, directory_file_name):
3352 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3354 (file_name_as_directory): Use const pointers when appropriate.
3355 (Fexpand_file_name): Likewise. In particular, newdir might
3356 point at constant storage, so make it a const pointer.
3357 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3358 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3360 (Fset_file_times, Finsert_file_contents, auto_save_error):
3361 Rename locals to avoid shadowing.
3363 * minibuf.c (choose_minibuf_frame_1): Now static.
3364 (Ftry_completion, Fall_completions): Rename or remove locals
3367 * marker.c (bytepos_to_charpos): Remove; unused.
3369 * lisp.h (verify_bytepos, count_markers): New decls,
3370 so that gcc does not warn that these functions aren't declared.
3372 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3373 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3374 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3375 (copy_text): Remove unused local var.
3377 * filelock.c (within_one_second): Now static.
3378 (lock_file_1): Rename local to avoid shadowing.
3380 * buffer.c (fix_overlays_before): Mark locals as initialized.
3381 (fix_start_end_in_overlays): Likewise. This function should be
3382 simplified by using pointers-to-pointers, but that's a different
3384 (switch_to_buffer_1): Now static.
3385 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3386 (report_overlay_modification): Rename locals to avoid shadowing.
3388 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3389 Fix pointer signedness issue.
3390 (sys_subshell): Mark local as volatile if checking for lint,
3391 to suppress a gcc -Wclobbered warning that does not seem to be right.
3392 (MAXPATHLEN): Define only if needed.
3394 * process.c (serial_open, serial_configure): Move decls from here ...
3395 * systty.h: ... to here, so that they can be checked.
3397 * fns.c (get_random, seed_random): Move extern decls from here ...
3398 * lisp.h: ... to here, so that they can be checked.
3400 * sysdep.c (reset_io): Now static.
3401 (wait_for_termination_signal): Remove; unused.
3403 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3404 (copy_keymap_item, append_key, push_text_char_description):
3406 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3407 (DENSE_TABLE_SIZE): Remove; unused.
3408 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3409 (describe_map_tree):
3410 Rename locals to avoid shadowing.
3412 * keyboard.c: Declare functions static if they are not used elsewhere.
3413 (echo_char, echo_dash, cmd_error, top_level_2):
3414 (poll_for_input, handle_async_input): Now static.
3415 (read_char, kbd_buffer_get_event, make_lispy_position):
3416 (make_lispy_event, make_lispy_movement, apply_modifiers):
3417 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3418 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3419 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3420 (read_key_sequence, read_char): Mark locals as initialized.
3421 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3423 * keyboard.h (make_ctrl_char): New decl.
3424 (mark_kboards): Move decl here ...
3425 * alloc.c (mark_kboards): ... from here.
3427 * lisp.h (force_auto_save_soon): New decl.
3429 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3430 (DEFINE_DUMMY_FUNCTION): New macro.
3431 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3433 (main): Add casts to avoid warnings
3434 if GCC considers string literals to be constants.
3436 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3438 * dbusbind.c: Pointer signedness fixes.
3439 (xd_signature, xd_append_arg, xd_initialize):
3440 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3441 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3442 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3443 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3445 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3446 if GCC considers string literals to be constants.
3447 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3449 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3451 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3452 (print_preprocess, print_object): New macro to fix last change.
3454 * print.c (print_preprocess): Don't forget font objects.
3456 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3458 * emacs.c (USAGE3): Doc fixes.
3460 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3462 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3465 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3467 * lisp.h (VWindow_system, Qfile_name_history):
3468 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3469 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3470 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3472 * w32select.c: Don't #include "keyboard.h".
3473 (run_protected): Add extern declaration for waiting_for_input.
3475 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3476 * w32console.c (detect_input_pending, read_input_pending)
3477 (encode_terminal_code):
3478 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3479 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3480 (w32_system_caret_y, Qfile_name_history):
3481 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3482 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3483 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3484 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3485 * w32proc.c (Qlocal, report_file_error):
3486 * w32term.c (Vwindow_system, updating_frame):
3487 * w32uniscribe.c (initialized, uniscribe_font_driver):
3488 Remove unneeded extern declarations.
3490 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3492 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3494 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3496 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3497 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3498 These macros can no longer be used for assignment.
3500 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3501 Assign struct members directly, instead of using BUF_BEGV etc.
3502 (record_buffer_markers, fetch_buffer_markers): New functions for
3503 recording and fetching special buffer markers.
3504 (set_buffer_internal_1, set_buffer_temp): Use them.
3506 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3508 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3510 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3511 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3513 * xdisp.c (hscroll_window_tree):
3514 (reconsider_clip_changes): Use PT instead of BUF_PT.
3516 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3518 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3519 $(EMACS_ROOT)/lib/intprops.h.
3521 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3523 Fix more problems found by GCC 4.5.2's static checks.
3525 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3526 to unsigned char * to avoid compiler diagnostic.
3527 (xg_free_frame_widgets): Make it clear that a local variable is
3528 needed only if USE_GTK_TOOLTIP.
3529 (gdk_window_get_screen): Make it clear that this macro is needed
3530 only if USE_GTK_TOOLTIP.
3531 (int_gtk_range_get_value): New function, which avoids a diagnostic
3532 from gcc -Wbad-function-cast.
3533 (xg_set_toolkit_scroll_bar_thumb): Use it.
3534 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3535 diagnostic from gcc -Wbad-function-cast.
3536 (get_utf8_string, xg_get_file_with_chooser):
3537 Rename locals to avoid shadowing.
3538 (create_dialog): Move locals to avoid shadowing.
3540 * xgselect.c (xg_select): Remove unused var.
3542 * image.c (four_corners_best): Mark locals as initialized.
3543 (gif_load): Initialize transparent_p to zero (Bug#8238).
3544 Mark another local as initialized.
3545 (my_png_error, my_error_exit): Mark with NO_RETURN.
3547 * image.c (clear_image_cache): Now static.
3548 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3549 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3550 (x_edge_detection): Remove unnecessary cast that
3551 gcc -Wbad-function-cast diagnoses.
3552 (gif_load): Fix pointer signedness.
3553 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3554 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3556 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3558 Improve quality of tests for time stamp overflow.
3559 For example, without this patch (encode-time 0 0 0 1 1
3560 1152921504606846976) returns the obviously-bogus value (-948597
3561 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3562 reports time overflow. See
3563 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3564 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3565 * editfns.c: Include limits.h and intprops.h.
3566 (TIME_T_MIN, TIME_T_MAX): New macros.
3567 (time_overflow): Move earlier, to before first use.
3568 (hi_time, lo_time): New functions, for an accurate test for
3570 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3571 (Fget_internal_run_time): Don't assume time_t fits in int.
3572 (make_time): Use list2 instead of Fcons twice.
3573 (Fdecode_time): More accurate test for out-of-range times.
3574 (check_tm_member): New function.
3575 (Fencode_time): Use it, to test for out-of-range times.
3576 (lisp_time_argument): Don't rely on undefined left-shift and
3577 right-shift behavior when checking for time stamp overflow.
3579 * editfns.c (time_overflow): New function, refactoring common code.
3580 (Fformat_time_string, Fdecode_time, Fencode_time):
3581 (Fcurrent_time_string): Use it.
3583 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3584 * dired.c (make_time): Move to ...
3585 * editfns.c (make_time): ... here.
3586 * systime.h: Note the move.
3588 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3590 * fringe.c (update_window_fringes): Remove unused variables.
3592 * unexmacosx.c (copy_data_segment): Also copy __got section.
3595 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3597 * termcap.c [MSDOS]: Include "msdos.h".
3598 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3599 Constify `char *' arguments and their references according to
3600 prototypes in tparam.h.
3602 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3604 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3605 Adapt all references accordingly.
3607 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3609 2011-03-11 Tom Tromey <tromey@redhat.com>
3611 * buffer.c (syms_of_buffer): Remove obsolete comment.
3613 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3615 * termhooks.h (encode_terminal_code): Declare prototype.
3617 * msdos.c (encode_terminal_code): Don't declare prototype.
3619 * term.c (encode_terminal_code): Now external again, used by
3620 w32console.c and msdos.c.
3622 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3623 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3625 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3627 Fix some minor problems found by GCC 4.5.2's static checks.
3629 * fringe.c (update_window_fringes): Mark locals as initialized
3631 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3633 * alloc.c (mark_fringe_data): Move decl from here ...
3634 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3635 to check its interface.
3636 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3638 * fontset.c (free_realized_fontset): Now static.
3639 (Fset_fontset_font): Rename local to avoid shadowing.
3640 (fontset_font): Mark local as initialized.
3641 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3643 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3645 * xselect.c (x_disown_buffer_selections): Remove; not used.
3646 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3647 (x_own_selection, Fx_disown_selection_internal): Rename locals
3649 (x_handle_dnd_message): Remove local to avoid shadowing.
3651 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3652 so that the caller can use some name other than gcpro1.
3653 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3654 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3655 (Fx_backspace_delete_keys_p):
3656 Use them to avoid shadowing, and rename vars to avoid shadowing.
3657 (x_decode_color, x_set_name, x_window): Now static.
3658 (Fx_create_frame): Add braces to silence GCC warning.
3659 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3660 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3661 Remove unused locals.
3662 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3663 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3664 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3667 * xterm.h (x_mouse_leave): New decl.
3669 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3670 Remove unused functions.
3671 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3672 (x_calc_absolute_position): Now static.
3673 (XTread_socket): Don't define label "out" unless it's used.
3674 Don't declare local "event" unless it's used.
3675 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3676 unless they are used.
3677 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3678 (x_fatal_error_signal): Remove; not used.
3679 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3680 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3681 (x_error_catcher, x_connection_closed, x_error_handler):
3682 (x_error_quitter, xembed_send_message, x_iconify_frame):
3683 (my_log_handler): Rename locals to avoid shadowing.
3684 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3685 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3687 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3688 Rename or move locals to avoid shadowing.
3689 (tty_defined_color, merge_face_heights): Now static.
3690 (free_realized_faces_for_fontset): Remove; not used.
3691 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3692 does not deduce is never used uninitialized.
3693 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3694 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3696 * terminal.c (store_terminal_param): Now static.
3698 * xmenu.c (menu_highlight_callback): Now static.
3699 (set_frame_menubar): Remove unused local.
3700 (xmenu_show): Rename parameter to avoid shadowing.
3701 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3702 since they might point to immutable storage.
3703 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3704 since it's unused otherwise.
3706 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3707 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3708 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3709 avoids a gcc -Wuninitialized diagnostic.
3710 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3711 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3712 does not deduce are never used uninitialized.
3714 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3716 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3717 * window.c (window_loop, size_window):
3718 (run_window_configuration_change_hook, enlarge_window): Likewise.
3720 * window.c (display_buffer): Now static.
3721 (size_window): Mark variables that gcc -Wuninitialized
3722 does not deduce are never used uninitialized.
3723 * window.h (check_all_windows): New decl, to forestall
3724 gcc -Wmissing-prototypes diagnostic.
3725 * dispextern.h (bidi_dump_cached_states): Likewise.
3727 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3729 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3731 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3732 and to avoid gcc -Wuninitialized warning.
3733 (load_charset_map): Mark variables that gcc -Wuninitialized
3734 does not deduce are never used uninitialized.
3735 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3737 * coding.c (coding_set_source, coding_set_destination):
3738 Use "else { /* comment */ }" rather than "else /* comment */;"
3739 for clarity, and to avoid gcc -Wempty-body warning.
3740 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3741 a block, when the outer 'i' will do.
3742 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3743 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3744 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3745 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3746 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3747 Rename locals to avoid shadowing.
3748 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3749 * coding.c (emacs_mule_char, encode_invocation_designation):
3750 Now static, since they're not used elsewhere.
3751 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3752 (decode_coding_object, encode_coding_object, detect_coding_system):
3753 (decode_coding_emacs_mule): Mark variables that gcc
3754 -Wuninitialized does not deduce are never used uninitialized.
3755 (detect_coding_iso_2022): Initialize a local variable that might
3756 be used uninitialized. Leave a FIXME because it's not clear that
3757 this initialization is needed. (Bug#8211)
3758 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3759 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3760 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3761 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3762 Remove unused macros.
3764 * category.c (hash_get_category_set): Remove unused local var.
3765 (copy_category_table): Now static, since it's not used elsewhere.
3766 * character.c (string_count_byte8): Likewise.
3768 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3769 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3771 * chartab.c (copy_sub_char_table): Now static, since it's not used
3773 (sub_char_table_ref_and_range, char_table_ref_and_range):
3774 Rename locals to avoid shadowing.
3775 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3777 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3778 (BIDI_BOB): Remove unused macro.
3780 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3781 deduce are never used uninitialized.
3782 * term.c (encode_terminal_code): Likewise.
3784 * term.c (encode_terminal_code): Now static. Remove unused local.
3786 * tparam.h: New file.
3787 * term.c, tparam.h: Include it.
3788 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3789 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3790 Move these decls to tparam.h, and make them agree with what
3791 is actually in tparam.c. The previous trick of using incompatible
3792 decls in different modules does not conform to the C standard.
3793 All callers of tparam changed to use tparam's actual API.
3794 * tparam.c (tparam1, tparam, tgoto):
3795 Use const pointers where appropriate.
3797 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3798 * cm.h (struct cm): Likewise.
3799 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3800 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3801 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3802 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3803 (turn_on_face, init_tty): Likewise.
3804 * termchar.h (struct tty_display_info): Likewise.
3806 * term.c (term_mouse_position): Rename local to avoid shadowing.
3808 * alloc.c (mark_ttys): Move decl from here ...
3809 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3811 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3813 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3815 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3817 * search.c (compile_pattern_1): Remove argument regp, unused since
3818 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3819 (compile_pattern): Don't pass it.
3821 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3823 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3824 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3826 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3828 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3830 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3831 gdk_window_get_screen, gdk_window_get_geometry,
3832 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3833 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3834 (xg_get_pixbuf_from_pixmap): New function.
3835 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3836 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3837 Call xg_get_pixbuf_from_pixmap instead of
3838 gdk_pixbuf_get_from_drawable.
3839 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3840 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3841 (xg_check_special_colors): Use GtkStyleContext and its functions
3843 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3844 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3845 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3846 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3847 Call gtk_widget_get_preferred_size.
3848 (xg_frame_resized): gdk_window_get_geometry only takes 5
3850 (xg_win_to_widget, xg_event_is_for_menubar):
3851 Call gdk_x11_window_lookup_for_display.
3852 (xg_set_widget_bg): New function.
3853 (delete_cb): New function.
3854 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3855 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3856 (xg_set_background_color): Call xg_set_widget_bg.
3857 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3858 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3859 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3860 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3862 (update_frame_tool_bar): Call gtk_widget_hide.
3863 (xg_initialize): Use GDK_KEY_g.
3865 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3867 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3869 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3870 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3871 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3873 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3875 * w32xfns.c (select_palette): Check success of RealizePalette against
3876 GDI_ERROR, not zero.
3878 See ChangeLog.11 for earlier changes.
3884 Copyright (C) 2011 Free Software Foundation, Inc.
3886 This file is part of GNU Emacs.
3888 GNU Emacs is free software: you can redistribute it and/or modify
3889 it under the terms of the GNU General Public License as published by
3890 the Free Software Foundation, either version 3 of the License, or
3891 (at your option) any later version.
3893 GNU Emacs is distributed in the hope that it will be useful,
3894 but WITHOUT ANY WARRANTY; without even the implied warranty of
3895 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3896 GNU General Public License for more details.
3898 You should have received a copy of the GNU General Public License
3899 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.