* alloc.c: Check that resized vectors' lengths fit in fixnums.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-14 Paul Eggert <eggert@cs.ucla.edu>
2
3 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4 (header_size, word_size): New constants.
5 (allocate_vectorlike): Don't check size overflow here.
6 (allocate_vector): Check it here instead, since this is the only
7 caller of allocate_vectorlike that could cause overflow.
8 Check that the new vector's length is representable as a fixnum.
9
10 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
11 The previous code was bogus. For example, next_almost_prime (32)
12 returned 39, which is undesirable as it is a multiple of 3; and
13 next_almost_prime (24) returned 25, which is a multiple of 5 so
14 why was the code bothering to check for multiples of 7?
15
16 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
17
18 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
19
20 Variadic C functions now count arguments with ptrdiff_t.
21 This partly undoes my 2011-03-30 change, which replaced int with size_t.
22 Back then I didn't know that the Emacs coding style prefers signed int.
23 Also, in the meantime I found a few more instances where arguments
24 were being counted with int, which may truncate counts on 64-bit
25 machines, or EMACS_INT, which may be unnecessarily wide.
26 * lisp.h (struct Lisp_Subr.function.aMANY)
27 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
28 Arg counts are now ptrdiff_t, not size_t.
29 All variadic functions and their callers changed accordingly.
30 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
31 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
32 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
33 * callint.c (Fcall_interactively): Check arg count for overflow,
34 to avoid potential buffer overrun. Use signed char, not 'int',
35 for 'varies' array, so that we needn't bother to check its size
36 calculation for overflow.
37 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
38 * eval.c (apply_lambda):
39 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
40 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
41 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
42
43 * callint.c (Fcall_interactively): Don't use index var as event count.
44
45 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
46 * mem-limits.h (SIZE): Remove; no longer used.
47
48 2011-06-13 Paul Eggert <eggert@cs.ucla.edu>
49
50 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
51
52 Remove unnecessary casts.
53 * xterm.c (x_term_init):
54 * xfns.c (x_set_border_pixel):
55 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
56 These aren't needed now that we assume ANSI C.
57
58 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
59 It's more likely to cause problems (due to unsigned overflow)
60 than to cure them.
61
62 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
63
64 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
65
66 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
67
68 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
69
70 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
71
72 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
73
74 GLYPH_CODE_FACE returns EMACS_INT, not int.
75 * dispextern.h (merge_faces):
76 * xfaces.c (merge_faces):
77 * xdisp.c (get_next_display_element, next_element_from_display_vector):
78 Don't assume EMACS_INT fits in int.
79
80 * character.h (CHAR_VALID_P): Remove unused parameter.
81 * fontset.c, lisp.h, xdisp.c: All uses changed.
82
83 * editfns.c (Ftranslate_region_internal): Omit redundant test.
84
85 * fns.c (concat): Minor tuning based on overflow analysis.
86 This doesn't fix any bugs. Use int to hold character, instead
87 of constantly refetching from Emacs object. Use XFASTINT, not
88 XINT, for value known to be a character. Don't bother comparing
89 a single byte to 0400, as it's always less.
90
91 * floatfns.c (Fexpt):
92 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
93
94 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
95 for characters.
96
97 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
98
99 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
100 Without this fix, on a 64-bit host (aset S 0 4294967386) would
101 incorrectly succeed when S was a string, because 4294967386 was
102 truncated before it was used.
103
104 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
105 Otherwise, an out-of-range integer could cause undefined behavior
106 on a 64-bit host.
107
108 * composite.c: Use int, not EMACS_INT, for characters.
109 (fill_gstring_body, composition_compute_stop_pos): Use int, not
110 EMACS_INT, for values that are known to be in character range.
111 This doesn't fix any bugs but is the usual style inside Emacs and
112 may generate better code on 32-bit machines.
113
114 Make sure a 64-bit char is never passed to ENCODE_CHAR.
115 This is for reasons similar to the recent CHAR_STRING fix.
116 * charset.c (Fencode_char): Check that character arg is actually
117 a character. Pass an int to ENCODE_CHAR.
118 * charset.h (ENCODE_CHAR): Verify that the character argument is no
119 wider than 'int', as a compile-time check to prevent future regressions
120 in this area.
121
122 * character.c (char_string): Remove unnecessary casts.
123
124 Make sure a 64-bit char is never passed to CHAR_STRING.
125 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
126 by silently ignoring the top 32 bits, allowing some values
127 that were far too large to be valid characters.
128 * character.h: Include <verify.h>.
129 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
130 arguments are no wider than unsigned, as a compile-time check
131 to prevent future regressions in this area.
132 * data.c (Faset):
133 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
134 (Fsubst_char_in_region):
135 * fns.c (concat):
136 * xdisp.c (decode_mode_spec_coding):
137 Adjust to CHAR_STRING's new requirement.
138 * editfns.c (Finsert_char, Fsubst_char_in_region):
139 * fns.c (concat): Check that character args are actually
140 characters. Without this test, these functions did the wrong
141 thing with wildly out-of-range values on 64-bit hosts.
142
143 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
144 These casts should not be needed on 32-bit hosts, either.
145 * keyboard.c (read_char):
146 * lread.c (Fload): Remove casts to unsigned.
147
148 * lisp.h (UNSIGNED_CMP): New macro.
149 This fixes comparison bugs on 64-bit hosts.
150 (ASCII_CHAR_P): Use it.
151 * casefiddle.c (casify_object):
152 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
153 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
154 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
155 * dispextern.h (FACE_FROM_ID):
156 * keyboard.c (read_char): Use UNSIGNED_CMP.
157
158 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
159 not to EMACS_INT, to avoid GCC warning.
160
161 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
162
163 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
164 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
165 isn't needed on 32-bit machines.
166
167 * buffer.c (Fgenerate_new_buffer_name):
168 Use EMACS_INT for count, not int.
169 (advance_to_char_boundary): Return EMACS_INT, not int.
170
171 * data.c (Qcompiled_function): Now static.
172
173 * window.c (window_body_lines): Now static.
174
175 * image.c (gif_load): Rename local to avoid shadowing.
176
177 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
178 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
179 * alloc.c (make_save_value): Integer argument is now of type
180 ptrdiff_t, not int.
181 (mark_object): Use ptrdiff_t, not int.
182 * lisp.h (pD): New macro.
183 * print.c (print_object): Use it.
184
185 * alloc.c: Use EMACS_INT, not int, to count objects.
186 (total_conses, total_markers, total_symbols, total_vector_size)
187 (total_free_conses, total_free_markers, total_free_symbols)
188 (total_free_floats, total_floats, total_free_intervals)
189 (total_intervals, total_strings, total_free_strings):
190 Now EMACS_INT, not int. All uses changed.
191 (Fgarbage_collect): Compute overall total using a double, so that
192 integer overflow is less likely to be a problem. Check for overflow
193 when converting back to an integer.
194 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
195 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
196 These were 'int' variables that could overflow on 64-bit hosts;
197 they were never used, so remove them instead of repairing them.
198 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
199 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
200 Previously, this ceilinged at INT_MAX, but that doesn't work on
201 64-bit machines.
202 (allocate_pseudovector): Don't use EMACS_INT when int would do.
203
204 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
205 (allocate_vectorlike): Check for ptrdiff_t overflow.
206 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
207 when a (possibly-narrower) signed value would do just as well.
208 We prefer using signed arithmetic, to avoid comparison confusion.
209
210 * alloc.c: Catch some string size overflows that we were missing.
211 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
212 for convenience in STRING_BYTES_MAX.
213 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
214 The definition here is exact; the one in lisp.h was approximate.
215 (allocate_string_data): Check for string overflow. This catches
216 some instances we weren't catching before. Also, it catches
217 size_t overflow on (unusual) hosts where SIZE_MAX <= min
218 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
219 and ptrdiff_t and EMACS_INT are both 64 bits.
220
221 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
222 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
223 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
224
225 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
226
227 * alloc.c (Fmake_string): Check for out-of-range init.
228
229 2011-06-12 Martin Rudalics <rudalics@gmx.at>
230
231 * frame.c (make_frame): Call other_buffer_safely instead of
232 other_buffer.
233
234 * window.c (temp_output_buffer_show): Call display_buffer with
235 second argument Vtemp_buffer_show_specifiers and reset latter
236 immediately after the call.
237 (Vtemp_buffer_show_specifiers): New variable.
238 (auto_window_vscroll_p, next_screen_context_lines)
239 (Vscroll_preserve_screen_position): Remove leading asterisks from
240 doc-strings.
241
242 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
243
244 Fix minor problems found by GCC 4.6.0 static checking.
245 * buffer.c (Qclone_number): Remove for now, as it's unused.
246 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
247 (record_buffer): Remove unused local.
248 * frame.c (other_visible_frames, frame_buffer_list): Now static.
249 (set_frame_buffer_list): Remove; unused.
250 * frame.h (other_visible_frames): Remove decl.
251 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
252 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
253 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
254 if HAVE_GPM.
255 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
256 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
257 Define only if HAVE_GPM.
258 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
259 (update_hints_inhibit): Remove; never set. All uses removed.
260 * widgetprv.h (emacsFrameClassRec): Remove decl.
261 * window.c (delete_deletable_window): Now returns void, since it
262 wasn't returning anything.
263 (compare_window_configurations): Remove unused locals.
264 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
265 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
266 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
267 the same widths as pointers. This follows up on the 2011-05-06 patch.
268 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
269 * xterm.h: Likewise.
270 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
271
272 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
273
274 * makefile.w32-in: Update dependencies.
275 (LISP_H): Add lib/intprops.h.
276
277 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
278
279 * image.c (gif_load): Add animation frame delay to the metadata.
280 (syms_of_image): Use DEFSYM. New symbol `delay'.
281
282 2011-06-11 Martin Rudalics <rudalics@gmx.at>
283
284 * window.c (delete_deletable_window): Re-add.
285 (Fset_window_configuration): Rewrite to handle dead buffers and
286 consequently deletable windows.
287 (window_tree, Fwindow_tree): Remove. Supply functionality in
288 window.el.
289 (compare_window_configurations): Simplify code.
290
291 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
292
293 * image.c (imagemagick_load_image): Fix type mismatch.
294 (Fimagemagick_types): Likewise.
295
296 * window.h (replace_buffer_in_windows): Declare.
297
298 2011-06-11 Martin Rudalics <rudalics@gmx.at>
299
300 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
301 Qclone_number. Remove external declaration of Qdelete_window.
302 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
303 code.
304 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
305 Qbuffer_list_update_hook if allowed.
306 (Fother_buffer): Rewrite doc-string. Major rewrite for new
307 buffer list implementation.
308 (other_buffer_safely): New function.
309 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
310 calls to replace_buffer_in_windows and
311 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
312 if allowed.
313 (record_buffer): Inhibit quitting and rewrite using quittable
314 functions. Run Qbuffer_list_update_hook if allowed.
315 (Frecord_buffer, Funrecord_buffer): New functions.
316 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
317 switch-to-buffer to window.el.
318 (bury-buffer): Move to window.el.
319 (Vbuffer_list_update_hook): New variable.
320
321 * lisp.h (other_buffer_safely): Add prototype in buffer.c
322 section.
323
324 * window.h (resize_frame_windows): Move up in code.
325 (Fwindow_frame): Remove EXFUN.
326 (replace_buffer_in_all_windows): Remove prototype.
327 (replace_buffer_in_windows_safely): Add prototype.
328
329 * window.c: Declare Qdelete_window static again. Move down
330 declaration of select_count.
331 (Fnext_window, Fprevious_window): Rewrite doc-strings.
332 (Fother_window): Move to window.el.
333 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
334 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
335 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
336 window.el.
337 (replace_buffer_in_windows): Implement by calling
338 Qreplace_buffer_in_windows.
339 (replace_buffer_in_all_windows): Remove with some functionality
340 moved into replace_buffer_in_windows_safely.
341 (replace_buffer_in_windows_safely): New function.
342 (select_window_norecord, select_frame_norecord): Move in front
343 of run_window_configuration_change_hook. Remove now obsolete
344 declarations.
345 (Fset_window_buffer): Rewrite doc-string. Call
346 Qrecord_window_buffer.
347 (keys_of_window): Move binding for other-window to window.el.
348
349 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
350
351 * dispextern.h (struct image): Replace data member, whose int_val
352 and ptr_val fields were not used by anything, with a single
353 lisp_val object.
354
355 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
356 (gif_clear_image, gif_load, imagemagick_load_image)
357 (gs_clear_image, gs_load): Callers changed.
358
359 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
360
361 * buffer.h: Include <time.h>, for time_t.
362 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
363
364 Fix minor problems found by static checking.
365
366 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
367
368 Make identifiers static if they are not used in other modules.
369 * data.c (Qcompiled_function, Qframe, Qvector):
370 * image.c (QimageMagick, Qsvg):
371 * minibuf.c (Qmetadata):
372 * window.c (resize_window_check, resize_root_window): Now static.
373 * window.h (resize_window_check, resize_root_window): Remove decls.
374
375 * window.c (window_deletion_count, delete_deletable_window):
376 Remove; unused.
377 (window_body_lines): Now static.
378 (Fdelete_other_windows_internal): Mark vars as initialized.
379 Make sure 'resize_failed' is initialized.
380 (run_window_configuration_change_hook): Rename local to avoid shadowing.
381 (resize_window_apply): Remove unused local.
382 * window.h (delete_deletable_window): Remove decl.
383
384 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
385 (imagemagick_load_image): Fix pointer signedness problem by changing
386 last arg from unsigned char * to char *. All uses changed.
387 Also, fix a local for similar reasons.
388 Remove unused locals. Remove locals to avoid shadowing.
389 (fn_rsvg_handle_free): Remove; unused.
390 (svg_load, svg_load_image): Fix pointer signedness problem.
391 (imagemagick_load_image): Don't use garbage pointer image_wand.
392
393 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
394
395 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
396
397 * image.c (gif_load): Fix omitted cast error introduced by
398 2011-06-06 change.
399
400 2011-06-10 Martin Rudalics <rudalics@gmx.at>
401
402 * window.h (resize_proportionally, orig_total_lines)
403 (orig_top_line): Remove from window structure.
404 (set_window_height, set_window_width, change_window_heights)
405 (Fdelete_window): Remove prototypes.
406 (resize_frame_windows): Remove duplicate declaration.
407
408 2011-06-10 Eli Zaretskii <eliz@gnu.org>
409
410 * window.h (resize_frame_windows, resize_window_check)
411 (delete_deletable_window, resize_root_window)
412 (resize_frame_windows): Declare prototypes.
413
414 * window.c (resize_window_apply): Make definition be "static" to
415 match the prototype.
416
417 2011-06-10 Martin Rudalics <rudalics@gmx.at>
418
419 * window.c: Remove declarations of Qwindow_size_fixed,
420 window_min_size_1, window_min_size_2, window_min_size,
421 size_window, window_fixed_size_p, enlarge_window, delete_window.
422 Remove static from declaration of Qdelete_window, it's
423 temporarily needed by Fbury_buffer.
424 (replace_window): Don't assign orig_top_line and
425 orig_total_lines.
426 (Fdelete_window, delete_window): Remove. Window deletion is
427 handled by window.el.
428 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
429 Fdelete_window calls with calls to Qdelete_window.
430 (Fdelete_other_windows): Remove. Deleting other windows is
431 handled by window.el.
432 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
433 handled in window.el.
434 (window_min_size_2, window_min_size_1, window_min_size): Remove.
435 Window minimum sizes are handled in window.el.
436 (shrink_windows, size_window, set_window_height)
437 (set_window_width, change_window_heights, window_height)
438 (window_width, CURBEG, CURSIZE, enlarge_window)
439 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
440 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
441 handled in window.el.
442 (make_dummy_parent): Rename to make_parent_window and give it a
443 second argument horflag.
444 (make_window): Don't set resize_proportionally any more.
445 (Fsplit_window): Remove. Windows are split in window.el.
446 (save_restore_action, save_restore_orig_size)
447 (shrink_window_lowest_first, save_restore_orig_size): Remove.
448 Resize mini windows in window.el.
449 (grow_mini_window, shrink_mini_window): Implement by calling
450 Qresize_root_window_vertically, resize_window_check and
451 resize_window_apply.
452 (saved_window, Fset_window_configuration, save_window_save): Do
453 not handle orig_top_line, orig_total_lines, and
454 resize_proportionally.
455 (window_min_height, window_min_width): Move to window.el.
456 (keys_of_window): Move bindings for delete-other-windows,
457 split-window, delete-window and enlarge-window to window.el.
458
459 * buffer.c: Temporarily extern Qdelete_window.
460 (Fbury_buffer): Temporarily call Qdelete_window instead of
461 Fdelete_window (Fbury_buffer will move to window.el soon).
462
463 * frame.c (set_menu_bar_lines_1): Remove code handling
464 orig_top_line and orig_total_lines.
465
466 * dispnew.c (adjust_frame_glyphs_initially): Don't use
467 set_window_height but set heights directly.
468 (change_frame_size_1): Use resize_frame_windows.
469
470 * xdisp.c (init_xdisp): Don't use set_window_height but set
471 heights directly.
472
473 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
474 resize_frame_windows instead of change_window_heights and run
475 run_window_configuration_change_hook.
476
477 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
478 instead of change_window_heights and run
479 run_window_configuration_change_hook.
480
481 2011-06-09 Martin Rudalics <rudalics@gmx.at>
482
483 * window.c (replace_window): Rename second argument REPLACEMENT to
484 NEW. New third argument SETFLAG. Rewrite.
485 (delete_window, make_dummy_parent): Call replace_window with
486 third argument 1.
487 (window_list_1): Move down in code.
488 (run_window_configuration_change_hook): Move set_buffer part
489 before select_frame_norecord part in order to unwind correctly.
490 Rename count1 to count.
491 (recombine_windows, delete_deletable_window, resize_root_window)
492 (Fdelete_other_windows_internal)
493 (Frun_window_configuration_change_hook, make_parent_window)
494 (resize_window_check, resize_window_apply, Fresize_window_apply)
495 (resize_frame_windows, Fsplit_window_internal)
496 (Fdelete_window_internal, Fresize_mini_window_internal): New
497 functions.
498 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
499
500 2011-06-08 Martin Rudalics <rudalics@gmx.at>
501
502 * window.h (window): Add some new members to window structure -
503 normal_lines, normal_cols, new_total, new_normal, clone_number,
504 splits, nest, prev_buffers, next_buffers.
505 (WINDOW_TOTAL_SIZE): Move here from window.c.
506 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
507
508 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
509 Remove.
510 (make_dummy_parent): Set new members of windows structure.
511 (make_window): Move down in code. Handle new members of window
512 structure.
513 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
514 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
515 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
516 (Fset_window_prev_buffers, Fwindow_next_buffers)
517 (Fset_window_next_buffers, Fset_window_clone_number): New
518 functions.
519 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
520 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
521 Doc-string fixes.
522 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
523 Argument WINDOW can be now internal window too.
524 (Fwindow_use_time): Move up in code.
525 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
526 Rewrite doc-string.
527 (Fset_window_configuration, saved_window)
528 (Fcurrent_window_configuration, save_window_save): Handle new
529 members of window structure.
530 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
531 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
532 (syms_of_window): New Lisp objects Qrecord_window_buffer,
533 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
534 Qget_mru_window, Qresize_root_window,
535 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
536 Qauto_buffer_name; staticpro them.
537
538 2011-06-07 Martin Rudalics <rudalics@gmx.at>
539
540 * window.c (Fwindow_total_size, Fwindow_left_column)
541 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
542 (Fwindow_list_1): New functions.
543 (window_box_text_cols): Replace with window_body_cols.
544 (Fwindow_width, Fscroll_left, Fscroll_right): Use
545 window_body_cols instead of window_box_text_cols.
546 (delete_window, Fset_window_configuration): Call
547 delete_all_subwindows with window as argument.
548 (delete_all_subwindows): Take a window as argument and not a
549 structure. Rewrite.
550 (window_loop): Remove handling of GET_LRU_WINDOW and
551 GET_LARGEST_WINDOW.
552 (Fget_lru_window, Fget_largest_window): Move to window.el.
553
554 * window.h: Extern window_body_cols instead of
555 window_box_text_cols. delete_all_subwindows now takes a
556 Lisp_Object as argument.
557
558 * indent.c (compute_motion, Fcompute_motion): Use
559 window_body_cols instead of window_box_text_cols.
560
561 * frame.c (delete_frame): Call delete_all_subwindows with root
562 window as argument.
563
564 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
565
566 * fns.c (Fputhash): Document return value.
567
568 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
569
570 * image.c (gif_load): Implement gif89a spec "no disposal" method.
571
572 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
573
574 Cons<->int and similar integer overflow fixes (Bug#8794).
575
576 Check for overflow when converting integer to cons and back.
577 * charset.c (Fdefine_charset_internal, Fdecode_char):
578 Use cons_to_unsigned to catch overflow.
579 (Fencode_char): Use INTEGER_TO_CONS.
580 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
581 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
582 * data.c (long_to_cons, cons_to_long): Remove.
583 (cons_to_unsigned, cons_to_signed): New functions.
584 These signal an error for invalid or out-of-range values.
585 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
586 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
587 * font.c (Ffont_variation_glyphs):
588 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
589 * lisp.h: Include <intprops.h>.
590 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
591 (cons_to_signed, cons_to_unsigned): New decls.
592 (long_to_cons, cons_to_long): Remove decls.
593 * undo.c (record_first_change): Use INTEGER_TO_CONS.
594 (Fprimitive_undo): Use CONS_TO_INTEGER.
595 * xfns.c (Fx_window_property): Likewise.
596 * xselect.c: Include <limits.h>.
597 (x_own_selection, selection_data_to_lisp_data):
598 Use INTEGER_TO_CONS.
599 (x_handle_selection_request, x_handle_selection_clear)
600 (x_get_foreign_selection, Fx_disown_selection_internal)
601 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
602 (lisp_data_to_selection_data): Use cons_to_unsigned.
603 (x_fill_property_data): Use cons_to_signed.
604 Report values out of range.
605
606 Check for buffer and string overflow more precisely.
607 * buffer.h (BUF_BYTES_MAX): New macro.
608 * lisp.h (STRING_BYTES_MAX): New macro.
609 * alloc.c (Fmake_string):
610 * character.c (string_escape_byte8):
611 * coding.c (coding_alloc_by_realloc):
612 * doprnt.c (doprnt):
613 * editfns.c (Fformat):
614 * eval.c (verror):
615 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
616 since they may not be the same number.
617 * editfns.c (Finsert_char):
618 * fileio.c (Finsert_file_contents):
619 Likewise for BUF_BYTES_MAX.
620
621 * image.c: Use ptrdiff_t, not int, for sizes.
622 (slurp_file): Switch from int to ptrdiff_t.
623 All uses changed.
624 (slurp_file): Check that file size fits in both size_t (for
625 malloc) and ptrdiff_t (for sanity and safety).
626
627 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
628 if b->modtime has its maximal value.
629
630 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
631
632 Don't assume time_t can fit into int.
633 * buffer.h (struct buffer.modtime): Now time_t, not int.
634 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
635 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
636
637 Minor fixes for signed vs unsigned integers.
638 * character.h (MAYBE_UNIFY_CHAR):
639 * charset.c (maybe_unify_char):
640 * keyboard.c (read_char, reorder_modifiers):
641 XINT -> XFASTINT, since the integer must be nonnegative.
642 * ftfont.c (ftfont_spec_pattern):
643 * keymap.c (access_keymap, silly_event_symbol_error):
644 XUINT -> XFASTINT, since the integer must be nonnegative.
645 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
646 since it makes no difference and we prefer signed.
647 * keyboard.c (record_char): Use XUINT when all the neighbors do.
648 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
649 nonnegative.
650
651 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
652
653 * window.h (Fwindow_frame): Declare.
654
655 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
656
657 * alloc.c: Simplify handling of large-request failures (Bug#8800).
658 (SPARE_MEMORY): Always define.
659 (LARGE_REQUEST): Remove.
660 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
661
662 2011-06-06 Martin Rudalics <rudalics@gmx.at>
663
664 * lisp.h: Move EXFUNS for Fframe_root_window,
665 Fframe_first_window and Fset_frame_selected_window to window.h.
666
667 * window.h: Move EXFUNS for Fframe_root_window,
668 Fframe_first_window and Fset_frame_selected_window here from
669 lisp.h.
670
671 * frame.c (Fwindow_frame, Fframe_first_window)
672 (Fframe_root_window, Fframe_selected_window)
673 (Fset_frame_selected_window): Move to window.c.
674 (Factive_minibuffer_window): Move to minibuf.c.
675 (Fother_visible_frames_p): New function.
676
677 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
678
679 * window.c (decode_window, decode_any_window): Move up in code.
680 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
681 (inhibit_frame_unsplittable): Remove unused variable.
682 (Fwindow_buffer): Move up and rewrite doc-string.
683 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
684 (Fwindow_prev): New functions.
685 (Fwindow_frame): Move here from frame.c. Accept any window as
686 argument.
687 (Fframe_root_window, Fframe_first_window)
688 (Fframe_selected_window): Move here from frame.c. Accept frame
689 or arbitrary window as argument. Update doc-strings.
690 (Fminibuffer_window): Move up in code.
691 (Fwindow_minibuffer_p): Move up in code and simplify.
692 (Fset_frame_selected_window): Move here from frame.c.
693 Marginal rewrite.
694 (Fselected_window, select_window, Fselect_window): Move up in
695 code. Minor doc-string fixes.
696
697 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
698
699 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
700 Do not assume that spare memory exists; that assumption is valid
701 only if SYSTEM_MALLOC.
702 (LARGE_REQUEST): New macro, so that the issue of large requests
703 is separated from the issue of spare memory.
704
705 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
706
707 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
708 format. (Bug#8806)
709
710 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
711
712 * xfns.c (x_set_scroll_bar_default_width): Move declarations
713 before statements.
714
715 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
716
717 * gtkutil.c (xg_get_default_scrollbar_width): New function.
718
719 * gtkutil.h: Declare xg_get_default_scrollbar_width.
720
721 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
722 min width by calling x_set_scroll_bar_default_width (Bug#8505).
723
724 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
725
726 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
727
728 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
729
730 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
731 (x_clipboard_manager_save): Add return value.
732 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
733 New error handlers.
734 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
735 Obey Vx_select_enable_clipboard_manager. Catch errors in
736 x_clipboard_manager_save (Bug#8779).
737 (Vx_select_enable_clipboard_manager): New variable.
738 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
739
740 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
741
742 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
743
744 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
745
746 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
747 in the current matrix if keep_current_p is non-zero.
748
749 2011-06-04 Eli Zaretskii <eliz@gnu.org>
750
751 * bidi.c (bidi_level_of_next_char): Fix last change.
752
753 2011-06-03 Eli Zaretskii <eliz@gnu.org>
754
755 Support bidi reordering of text covered by display properties.
756
757 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
758 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
759 (bidi_cache_search, bidi_cache_iterator_state)
760 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
761 (bidi_level_of_next_char, bidi_move_to_visually_next):
762 Support character positions inside a run of characters covered by a
763 display string.
764 (bidi_paragraph_init, bidi_resolve_explicit_1)
765 (bidi_level_of_next_char): Call bidi_fetch_char and
766 bidi_fetch_char_advance instead of FETCH_CHAR and
767 FETCH_CHAR_ADVANCE.
768 (bidi_init_it): Initialize new members.
769 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
770 definitions.
771 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
772 instead of using explicit *_CHAR codes.
773 (bidi_resolve_explicit, bidi_resolve_weak):
774 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
775 bidirectional text is supported only in multibyte buffers.
776 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
777 it to initialize the frame_window_p member of struct bidi_it.
778 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
779 (bidi_resolve_explicit, bidi_resolve_weak)
780 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
781 bidi_it->nchars is non-positive.
782 (bidi_level_of_next_char): Don't try to lookup the cache for the
783 next/previous character if nothing is cached there yet, or if we
784 were just reseat()'ed to a new position.
785
786 * xdisp.c (set_cursor_from_row): Set start and stop points
787 according to the row's direction when priming the loop that looks
788 for the glyph on which to display cursor.
789 (single_display_spec_intangible_p): Function deleted.
790 (display_prop_intangible_p): Reimplement to call
791 handle_display_spec instead of single_display_spec_intangible_p.
792 Accept 3 additional arguments needed by handle_display_spec.
793 This fixes incorrect cursor motion across display property with complex
794 values: lists, `(when COND...)' forms, etc.
795 (single_display_spec_string_p): Support property values that are
796 lists with the argument STRING its top-level element.
797 (display_prop_string_p): Fix the condition for processing a
798 property that is a list to be consistent with handle_display_spec.
799 (handle_display_spec): New function, refactored from the
800 last portion of handle_display_prop.
801 (compute_display_string_pos): Accept additional argument
802 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
803 value of a `display' property is a "replacing spec".
804 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
805 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
806 the display property, but just return a value indicating whether
807 the display property will replace the characters it covers.
808 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
809 frame_window_p members of struct bidi_it.
810 (compute_display_string_pos, compute_display_string_end):
811 New functions.
812 (push_it): Accept second argument POSITION, where pop_it should
813 jump to continue iteration.
814 (reseat_1): Initialize bidi_it.disp_pos.
815
816 * keyboard.c (adjust_point_for_property): Adjust the call to
817 display_prop_intangible_p to its new signature.
818
819 * dispextern.h (struct bidi_it): New member frame_window_p.
820 (bidi_init_it): Update prototypes.
821 (display_prop_intangible_p): Update prototype.
822 (compute_display_string_pos, compute_display_string_end):
823 Declare prototypes.
824 (struct bidi_it): New members nchars and disp_pos. ch_len is now
825 EMACS_INT.
826
827 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
828
829 Malloc failure behavior now depends on size of allocation.
830 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
831 * lisp.h: Change signatures accordingly.
832 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
833 All callers changed. (Bug#8762)
834
835 * gnutls.c: Use Emacs's memory allocators.
836 Without this change, the gnutls library would invoke malloc etc.
837 directly, which causes problems on non-SYNC_INPUT hosts, and which
838 runs afoul of improving memory_full behavior. (Bug#8761)
839 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
840 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
841 xfree instead of the default malloc, realloc, free.
842 (Fgnutls_boot): No need to check for memory allocation failure,
843 since xmalloc does that for us.
844
845 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
846 * category.c (hash_get_category_set):
847 * ccl.c (ccl_driver):
848 * charset.c (Fdefine_charset_internal):
849 * charset.h (struct charset.hash_index):
850 * composite.c (get_composition_id, gstring_lookup_cache)
851 (composition_gstring_put_cache):
852 * composite.h (struct composition.hash_index):
853 * dispextern.h (struct image.hash):
854 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
855 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
856 (hashfn_equal, hashfn_user_defined, make_hash_table)
857 (maybe_resize_hash_table, hash_lookup, hash_put)
858 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
859 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
860 (Fsxhash, Fgethash, Fputhash, Fmaphash):
861 * image.c (make_image, search_image_cache, lookup_image)
862 (xpm_put_color_table_h):
863 * lisp.h (struct Lisp_Hash_Table):
864 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
865 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
866 for hashes and hash indexes, instead of 'unsigned' and 'int'.
867 * alloc.c (allocate_vectorlike):
868 Check for overflow in vector size calculations.
869 * ccl.c (ccl_driver):
870 Check for overflow when converting EMACS_INT to int.
871 * fns.c, image.c: Remove unnecessary static decls that would otherwise
872 need to be updated by these changes.
873 * fns.c (make_hash_table, maybe_resize_hash_table):
874 Check for integer overflow with large hash tables.
875 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
876 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
877 (SXHASH_REDUCE): New macro.
878 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
879 Use it instead of discarding useful hash info with large hash values.
880 (sxhash_float): New function.
881 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
882 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
883 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
884 Rewrite to use FIXNUM_BITS, as this simplifies things.
885 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
886 Adjust signatures to match updated version of code.
887 (consing_since_gc): Now EMACS_INT, since a single hash table can
888 use more than INT_MAX bytes.
889
890 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
891
892 Make it possible to build with GCC-4.6+ -O2 -flto.
893
894 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
895
896 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
897
898 * minibuf.c (get_minibuffer, read_minibuf_unwind):
899 Call minibuffer-inactive-mode.
900
901 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
902
903 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
904 Update dependencies.
905
906 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
907
908 * data.c (init_data): Remove code for UTS, this system is not
909 supported anymore.
910
911 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
912
913 Don't force ./temacs to start in terminal mode.
914
915 * frame.c (make_initial_frame): Initialize faces in all cases, not
916 only when CANNOT_DUMP is defined.
917 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
918
919 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
920
921 * dispnew.c (add_window_display_history): Use const for the string
922 pointer. Remove declaration, not needed.
923
924 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
925
926 Use 'inline', not 'INLINE'.
927 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
928 * alloc.c, fontset.c (INLINE): Remove.
929 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
930 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
931 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
932 * gmalloc.c (register_heapinfo): Use inline unconditionally.
933 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
934
935 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
936
937 Make it possible to run ./temacs.
938
939 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
940 syms_of_callproc does the same thing. Remove test for
941 "initialized", do it in the caller.
942 * emacs.c (main): Avoid calling set_initial_environment when dumping.
943
944 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
945
946 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
947 (read_minibuf): Use get_minibuffer.
948 (syms_of_minibuf): Use DEFSYM.
949 (Qmetadata): New var.
950 * data.c (Qbuffer): Don't make it static.
951 (syms_of_data): Use DEFSYM.
952
953 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
954
955 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
956 (CCL_CODE_MIN): New macro.
957
958 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
959
960 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
961
962 * eval.c (Qdebug): Now static.
963 * lisp.h (Qdebug): Remove decl. This reverts a part of the
964 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
965 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
966
967 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
968
969 * image.c: Various fixes to ImageMagick code comments.
970 (Fimagemagick_types): Doc fix.
971
972 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
973
974 Minor fixes prompted by GCC 4.6.0 warnings.
975
976 * xselect.c (converted_selections, conversion_fail_tag): Now static.
977
978 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
979 (x_clipboard_manager_save_all): Move extern decl to ...
980 * xterm.h: ... here, so that it can be checked for consistency.
981
982 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
983
984 * xselect.c (x_clipboard_manager_save_frame)
985 (x_clipboard_manager_save_all): New functions.
986 (Fx_clipboard_manager_save): Lisp function deleted.
987
988 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
989 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
990
991 * xterm.h: Update prototype.
992
993 2011-05-28 William Xu <william.xwl@gmail.com>
994
995 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
996 exiting (Bug#8239).
997
998 2011-05-28 Jim Meyering <meyering@redhat.com>
999
1000 Avoid a sign-extension bug in crypto_hash_function.
1001 * fns.c (to_uchar): Define.
1002 (crypto_hash_function): Use it to convert some newly-signed
1003 variables to unsigned, to avoid sign-extension bugs. For example,
1004 without this change, (md5 "truc") would evaluate to
1005 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1006 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1007 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1008
1009 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 Integer overflow fixes.
1012
1013 * dbusbind.c: Serial number integer overflow fixes.
1014 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1015 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1016 to hold a serial number that is too large for a fixnum.
1017 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1018 Check for serial numbers out of range. Decode any serial number
1019 that was so large that it became a float. (Bug#8722)
1020
1021 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1022 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1023 Use XFASTINT rather than XUINT when numbers are nonnegative.
1024 (xd_append_arg, Fdbus_method_return_internal):
1025 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1026 arguments, check that Lisp number is nonnegative, rather than
1027 silently wrapping negative numbers around. (Bug#8722)
1028 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1029 (Bug#8722)
1030
1031 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1032
1033 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1034
1035 ccl: add integer overflow checks
1036 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1037 (IN_INT_RANGE): New macros.
1038 (ccl_driver): Use them to check for integer overflow when
1039 decoding a CCL program. Many of the new checks are whether XINT (x)
1040 fits in int; it doesn't always, on 64-bit hosts. The new version
1041 doesn't catch all possible integer overflows, but it's an
1042 improvement. (Bug#8719)
1043
1044 * alloc.c (make_event_array): Use XINT, not XUINT.
1045 There's no need for unsigned here.
1046
1047 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1048 This follows up to the 2011-05-06 change that substituted uintptr_t
1049 for EMACS_INT. This case wasn't caught back then.
1050
1051 Rework Fformat to avoid integer overflow issues.
1052 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1053 now (part of C89). Include <verify.h>.
1054 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1055 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1056 (Fformat): Avoid the prepass trying to compute sizes; it was only
1057 approximate and thus did not catch overflow reliably. Instead, walk
1058 through the format just once, formatting and computing sizes as we go,
1059 checking for integer overflow at every step, and allocating a larger
1060 buffer as needed. Keep track separately whether the format is
1061 multibyte. Keep only the most-recently calculated precision, rather
1062 than them all. Record whether each argument has been converted to
1063 string. Use EMACS_INT, not int, for byte and char and arg counts.
1064 Support field widths and precisions larger than INT_MAX. Avoid
1065 sprintf's undefined behavior with conversion specifications such as %#d
1066 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1067 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1068 formatting out-of-range floating point numbers with int
1069 formats. (Bug#8668)
1070
1071 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1072
1073 * data.c: Avoid integer truncation in expressions involving floats.
1074 * data.c: Include <intprops.h>.
1075 (arith_driver): When there's an integer overflow in an expression
1076 involving floating point, convert the integers to floating point
1077 so that the resulting value does not suffer from catastrophic
1078 integer truncation. For example, on a 64-bit host (* 4
1079 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1080 Do not rely on undefined behavior after integer overflow.
1081
1082 merge count_size_as_multibyte, parse_str_to_multibyte
1083 * character.c, character.h (count_size_as_multibyte):
1084 Rename from parse_str_to_multibyte; all uses changed.
1085 Check for integer overflow.
1086 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1087 since it's now a duplicate of the other. This is more of
1088 a character than a buffer op, so better that it's in character.c.
1089 * fns.c, print.c: Adjust to above changes.
1090
1091 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1092
1093 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1094
1095 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1098 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1099 (x_clipboard_manager_save): Now static.
1100 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1101
1102 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1103 (crypto_hash_function): Now static.
1104 Fix pointer signedness problems. Avoid unnecessary initializations.
1105
1106 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1107
1108 * termhooks.h (Vselection_alist): Make it terminal-local.
1109
1110 * terminal.c (create_terminal): Initialize it.
1111
1112 * xselect.c: Support for clipboard managers.
1113 (Vselection_alist): Move to termhooks.h as terminal-local var.
1114 (LOCAL_SELECTION): New macro.
1115 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1116 (symbol_to_x_atom): Remove gratuitous arg.
1117 (x_handle_selection_request, lisp_data_to_selection_data)
1118 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1119 (x_own_selection, x_get_local_selection, x_convert_selection):
1120 New arg, specifying work frame. Use terminal-local Vselection_alist.
1121 (some_frame_on_display): Delete unused function.
1122 (Fx_own_selection_internal, Fx_get_selection_internal)
1123 (Fx_disown_selection_internal, Fx_selection_owner_p)
1124 (Fx_selection_exists_p): New optional frame arg.
1125 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1126 (x_handle_selection_clear): Don't treat other terminals with the
1127 same keyboard specially. Use the terminal-local Vselection_alist.
1128 (x_clear_frame_selections): Use Frun_hook_with_args.
1129
1130 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1131
1132 * xterm.h: Add support for those atoms.
1133
1134 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1135
1136 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1137 (converted_selections, conversion_fail_tag): New global variables.
1138 (x_selection_request_lisp_error): Free the above.
1139 (x_get_local_selection): Remove unnecessary code.
1140 (x_reply_selection_request): Args changed; handle arbitrary array
1141 of converted selections stored in converted_selections.
1142 Separate the XChangeProperty and SelectionNotify steps.
1143 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1144 (x_convert_selection): New function.
1145 (x_handle_selection_event): Simplify.
1146 (x_get_foreign_selection): Don't ignore incoming requests while
1147 waiting for an answer; this will fail when we implement
1148 SAVE_TARGETS, and seems unnecessary anyway.
1149 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1150 (Vx_sent_selection_functions): Doc fix.
1151
1152 2011-05-26 Leo Liu <sdl.web@gmail.com>
1153
1154 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1155
1156 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1157
1158 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1159
1160 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1161 for fringe update if it has periodic bitmap.
1162 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1163 and fringe_bitmap_periodic_p.
1164
1165 * fringe.c (get_fringe_bitmap_data): New function.
1166 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1167 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1168 row. Mark glyph row for fringe update if periodicity changed.
1169
1170 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1171 for fringe update unless it has periodic bitmap.
1172
1173 2011-05-25 Kenichi Handa <handa@m17n.org>
1174
1175 * xdisp.c (get_next_display_element): Set correct it->face_id for
1176 a static composition.
1177
1178 2011-05-24 Leo Liu <sdl.web@gmail.com>
1179
1180 * deps.mk (fns.o):
1181 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1182
1183 * fns.c (crypto_hash_function, Fsha1): New function.
1184 (Fmd5): Use crypto_hash_function.
1185 (syms_of_fns): Add Ssha1.
1186
1187 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1188
1189 * gnutls.c: Remove unused macros.
1190 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1191 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1192 Remove macros that are defined and never used.
1193 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1194
1195 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1196
1197 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1198 (Fx_get_selection_internal): Minor cleanup.
1199 (Fx_own_selection_internal): Rename arguments for consistency with
1200 select.el.
1201
1202 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1205
1206 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1207
1208 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1209
1210 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1211
1212 * dispnew.c (scrolling_window): Don't exclude the case that the
1213 last enabled row in the desired matrix touches the bottom boundary.
1214
1215 2011-05-21 Glenn Morris <rgm@gnu.org>
1216
1217 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1218 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1219 and add some more files.
1220
1221 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1222
1223 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1224 report_file_error introduced by the change from 2011-05-07.
1225
1226 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 * systime.h (Time): Define only if emacs is defined.
1229 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1230 where the include path doesn't have X11/X.h by default. See
1231 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1232
1233 2011-05-20 Kenichi Handa <handa@m17n.org>
1234
1235 * composite.c (find_automatic_composition): Fix previous change.
1236
1237 2011-05-20 Glenn Morris <rgm@gnu.org>
1238
1239 * lisp.mk: New file, split from Makefile.in.
1240 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1241 (shortlisp): Remove.
1242 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1243
1244 2011-05-19 Glenn Morris <rgm@gnu.org>
1245
1246 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1247 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1248 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1249 (lisp): Set the order to that of loadup.el.
1250 (shortlisp): Make it a copy of $lisp.
1251 (SOME_MACHINE_LISP): Remove.
1252 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1253 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1254
1255 2011-05-18 Kenichi Handa <handa@m17n.org>
1256
1257 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1258 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1259 (find_automatic_composition): Mostly rewrite for efficiency.
1260
1261 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1262
1263 * makefile.w32-in: Update dependencies.
1264
1265 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1266
1267 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1268 revision 104625).
1269
1270 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 Fix some integer overflow issues, such as string length overflow.
1273
1274 * insdel.c (count_size_as_multibyte): Check for string overflow.
1275
1276 * character.c (lisp_string_width): Check for string overflow.
1277 Use EMACS_INT, not int, for string indexes and lengths; in
1278 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1279 the resulting string length overflows an EMACS_INT; instead,
1280 report a string overflow if no precision given. When checking for
1281 precision exhaustion, use a check that cannot possibly have
1282 integer overflow. (Bug#8675)
1283 * character.h (lisp_string_width): Adjust to new signature.
1284
1285 * alloc.c (string_overflow): New function.
1286 (Fmake_string): Use it. This doesn't change behavior, but saves
1287 a few bytes and will simplify future changes.
1288 * character.c (string_escape_byte8): Likewise.
1289 * lisp.h (string_overflow): New decl.
1290
1291 Fixups, following up to the user-interface timestamp change.
1292 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1293 for UI timestamps, instead of unsigned long.
1294 * msdos.c (mouse_get_pos): Likewise.
1295 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1296 * w32gui.h (Time): Define by including "systime.h" rather than by
1297 declaring it ourselves. (Bug#8664)
1298
1299 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1300 * image.c (clear_image_cache): Likewise.
1301
1302 * term.c (term_mouse_position): Don't assume time_t wraparound.
1303
1304 Be more systematic about user-interface timestamps.
1305 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1306 and sometimes 'EMACS_UINT', to represent these timestamps.
1307 This change causes it to use 'Time' uniformly, as that's what X uses.
1308 This makes the code easier to follow, and makes it easier to catch
1309 integer overflow bugs such as Bug#8664.
1310 * frame.c (Fmouse_position, Fmouse_pixel_position):
1311 Use Time, not unsigned long, for user-interface timestamps.
1312 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1313 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1314 * keyboard.h (last_event_timestamp): Likewise.
1315 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1316 * menu.h (xmenu_show): Likewise.
1317 * term.c (term_mouse_position): Likewise.
1318 * termhooks.h (struct input_event.timestamp): Likewise.
1319 (struct terminal.mouse_position_hook): Likewise.
1320 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1321 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1322 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1323 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1324 what it was before.
1325 * menu.h, termhooks.h: Include "systime.h", for Time.
1326
1327 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1328 Don't assume that the difference between two unsigned long values
1329 can fit into an integer. At this point, we know button_down_time
1330 <= event->timestamp, so the difference must be nonnegative, so
1331 there's no need to cast the result if double-click-time is
1332 nonnegative, as it should be; check that it's nonnegative, just in
1333 case. This bug is triggered when events are more than 2**31 ms
1334 apart (about 25 days). (Bug#8664)
1335
1336 * xselect.c (last_event_timestamp): Remove duplicate decl.
1337 (x_own_selection): Remove needless cast to unsigned long.
1338
1339 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1340 that always fit in int. Use a sentinel instead of a counter, to
1341 avoid a temp and to allay GCC's concerns about possible int overflow.
1342 * frame.h (struct frame): Use int for menu_bar_items_used
1343 instead of EMACS_INT, since it always fits in int.
1344
1345 * menu.c (grow_menu_items): Check for int overflow.
1346
1347 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1348
1349 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1350 Before, the code was not consistent. These values cannot exceed
1351 2**31 - 1 so there's no need to make them unsigned.
1352 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1353 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1354 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1355 as modifiers.
1356 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1357
1358 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1359 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1360 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1361 presumably because the widths might not match.
1362
1363 * window.c (size_window): Avoid needless test at loop start.
1364
1365 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1366
1367 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1368
1369 2011-05-12 Drew Adams <drew.adams@oracle.com>
1370
1371 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1372
1373 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1374
1375 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1376 `width' to `bar_area_x' and `bar_area_width', respectively.
1377 (x_scroll_run): Take account of fringe background extension.
1378
1379 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1380 Rename local vars `left' and `width' to `bar_area_x' and
1381 `bar_area_width', respectively.
1382 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1383 background extension.
1384
1385 2011-05-10 Jim Meyering <meyering@redhat.com>
1386
1387 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1388
1389 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1390
1391 * image.c (Finit_image_library): Return t for built-in image types,
1392 like pbm and xbm. (Bug#8640)
1393
1394 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1395
1396 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1397
1398 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1399
1400 * w32console.c (Fset_screen_color): Doc fix.
1401 (Fget_screen_color): New function.
1402 (syms_of_ntterm): Defsubr it.
1403
1404 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1405 unlink the temporary file if Fcall_process didn't create it in the
1406 first place.
1407 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1408 child process will be redirected to a file specified with `:file'.
1409 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1410 cue to call_process_cleanup not to close that handle.
1411
1412 2011-05-07 Ben Key <bkey76@gmail.com>
1413
1414 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1415 one of two shell specific rules, either bootstrap-temacs-CMD or
1416 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1417 to the previous implementation of the bootstrap-temacs rule.
1418 The bootstrap-temacs-CMD rule is similar to the previous
1419 implementation of the bootstrap-temacs rule except that it
1420 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1421 variable.
1422
1423 These changes, along with some changes to nt/configure.bat,
1424 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1425 earlier fix to add support for --cflags and --ldflags options
1426 that include quotes so that it works whether make uses cmd or
1427 sh as the shell.
1428
1429 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1430
1431 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1432 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1433 is a constant.
1434 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1435 a string. Handle both cases.
1436 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1437 (Fdbus_register_method): Use Qinvalid_function.
1438
1439 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1440
1441 * makefile.w32-in: Update dependencies.
1442 (LISP_H): Add inttypes.h and stdin.h.
1443 (PROCESS_H): Add unistd.h.
1444
1445 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1446
1447 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1448 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1449
1450 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1451
1452 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1453
1454 * term.c (vfatal): Remove stray call to va_end.
1455 It's not needed and the C Standard doesn't allow it here anyway.
1456
1457 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1458 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1459
1460 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1461 bytes.
1462
1463 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1464
1465 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1466
1467 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1468
1469 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1470
1471 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1472
1473 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1474 * charset.c (Fdefine_charset_internal): Don't initialize
1475 charset.code_space[15]. The value was garbage, on hosts with
1476 32-bit int (Bug#8600).
1477
1478 * lread.c (read_integer): Be more consistent with string-to-number.
1479 Use string_to_number to do the actual conversion; this avoids
1480 rounding errors and fixes some other screwups. Without this fix,
1481 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1482 (digit_to_number): Move earlier, for benefit of read_integer.
1483 Return -1 if the digit is out of range for the base, -2 if it is
1484 not a digit in any supported base. (Bug#8602)
1485
1486 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1487
1488 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1489 to match comment at start of function. This also removes a
1490 GCC warning about overflow in a 32+64-bit port.
1491
1492 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1493
1494 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1495 Reported by Stefan Monnier in
1496 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1497 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1498 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1499
1500 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1501 (EMACS_UINTPTR): Likewise, with uintptr_t.
1502
1503 * lisp.h: Prefer 64-bit EMACS_INT if available.
1504 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1505 on 32-bit hosts that have 64-bit int, so that they can access
1506 large files.
1507 However, temporarily disable this change unless the temporary
1508 symbol WIDE_EMACS_INT is defined.
1509
1510 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1511
1512 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1513 This removes an assumption that EMACS_INT and long are the same
1514 width as pointers. The assumption is true for Emacs porting targets
1515 now, but we want to make other targets possible.
1516 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1517 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1518 In the rest of the code, change types of integers that hold casted
1519 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1520 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1521 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1522 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1523 No need to cast type when ORing.
1524 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1525 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1526 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1527 assume EMACS_INT is the same width as char *.
1528 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1529 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1530 Remove no-longer-needed casts.
1531 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1532 (xg_tool_bar_help_callback, xg_make_tool_item):
1533 Use EMACS_INTPTR to hold an integer
1534 that will be cast to void *; this can avoid a GCC warning
1535 if EMACS_INT is not the same width as void *.
1536 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1537 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1538 (current_message_1, set_message_1):
1539 Use a local to convert to proper width without a cast.
1540 * xmenu.c (dialog_selection_callback): Likewise.
1541
1542 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1543 Also, don't assume VALBITS / RAND_BITS is less than 5,
1544 and don't rely on undefined behavior when shifting a 1 left into
1545 the sign bit.
1546 * lisp.h (get_random): Change signature to match.
1547
1548 * lread.c (hash_string): Use size_t, not int, for hash computation.
1549 Normally we prefer signed values; but hashing is special, because
1550 it's better to use unsigned division on hash table sizes so that
1551 the remainder is nonnegative. Also, size_t is the natural width
1552 for hashing into memory. The previous code used 'int', which doesn't
1553 retain enough info to hash well into very large tables.
1554 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1555
1556 * dbusbind.c: Don't possibly lose pointer info when converting.
1557 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1558 Use XPNTR rather than XHASH, so that the high-order bits of
1559 the pointer aren't lost when converting through void *.
1560
1561 * eval.c (Fautoload): Don't double-shift a pointer.
1562
1563 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1564
1565 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1566
1567 * gnutls.c (DEF_GNUTLS_FN):
1568 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1569
1570 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1571
1572 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1573 marker. (Bug#8610)
1574
1575 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1576
1577 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1578 New version that can reserve upto 2GB of heap space.
1579
1580 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1581
1582 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1583
1584 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1585
1586 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1587 `gnutls_certificate_set_x509_key_file'.
1588
1589 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1590
1591 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1592 Update dependencies.
1593
1594 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1595
1596 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1597 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1598 Remove unused parameter `fildes'.
1599 * process.c (read_process_output, send_process): Don't pass it.
1600
1601 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1602
1603 Fix previous change: the library cache is defined in w32.c.
1604 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1605 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1606
1607 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1608
1609 Implement dynamic loading of GnuTLS on Windows.
1610
1611 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1612 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1613 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1614 Declare.
1615
1616 * gnutls.c (Qgnutls_dll): Define.
1617 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1618 (gnutls_*): Declare function pointers.
1619 (init_gnutls_functions): New function to initialize function pointers.
1620 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1621 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1622 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1623 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1624 (emacs_gnutls_write, emacs_gnutls_read)
1625 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1626 (Fgnutls_available_p): New function.
1627 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1628 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1629 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1630
1631 * image.c: Include w32.h.
1632 (Vimage_type_cache): Delete.
1633 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1634 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1635 (w32_delayed_load): Move to w32.c.
1636
1637 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1638
1639 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1640 (w32_delayed_load): Move from image.c. When loading a library, record
1641 its filename in the :loaded-from property of the library id.
1642 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1643 Initialize and staticpro them.
1644 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1645
1646 * process.c: Include lisp.h before w32.h, not after.
1647 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1648 instead of gnutls_record_check_pending.
1649
1650 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1651
1652 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1653
1654 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1655 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1656 as passed in.
1657
1658 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1659
1660 * xterm.c (x_set_frame_alpha): Do not set property on anything
1661 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1662
1663 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1664
1665 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1666
1667 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1668
1669 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1670 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1671 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1672 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1673 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1674 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1675 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1676 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1677 (Qgnutls_bootprop_callbacks_verify): Make static.
1678
1679 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1680
1681 * callproc.c: Indentation fixup.
1682
1683 * sysdep.c (wait_for_termination_1): Make static.
1684 (wait_for_termination, interruptible_wait_for_termination):
1685 Move after wait_for_termination_1.
1686
1687 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1688
1689 * sysdep.c (interruptible_wait_for_termination): New function
1690 which is like wait_for_termination, but allows keyboard
1691 interruptions.
1692
1693 * callproc.c (Fcall_process): Add (:file "file") as an option for
1694 the STDOUT buffer.
1695 (Fcall_process_region): Ditto.
1696
1697 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1698
1699 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1700 rather than `XVECTOR (FOO)->size'.
1701
1702 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1703 inttypes.h, as a gnulib replacement is used if it not available in
1704 system headers.
1705
1706 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1707
1708 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1709 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1710 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1711
1712 * coding.c (coding_alloc_by_realloc): Error out if destination
1713 will grow beyond MOST_POSITIVE_FIXNUM.
1714 (decode_coding_emacs_mule): Abort if there isn't enough place in
1715 charbuf for the composition carryover bytes. Reserve an extra
1716 space for up to 2 characters produced in a loop.
1717 (decode_coding_iso_2022): Abort if there isn't enough place in
1718 charbuf for the composition carryover bytes.
1719
1720 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1721
1722 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1723 aborting when %lld or %lll format is passed.
1724 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1725 %llo or %llx format is passed. (Bug#8545)
1726
1727 * window.c (window_scroll_line_based): Use a marker instead of
1728 simple variables to record original value of point. (Bug#7952)
1729
1730 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1731 produced by %s or %c overflows available buffer space. (Bug#8545)
1732
1733 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1734
1735 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1736 (SIZE_MAX): Move defn after all includes, as they might #define it.
1737
1738 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1739
1740 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1741
1742 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1743
1744 * keyboard.c (Qdelayed_warnings_hook): Define.
1745 (command_loop_1): Run `delayed-warnings-hook'
1746 if Vdelayed_warnings_list is non-nil.
1747 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1748 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1749
1750 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1751
1752 * doprnt.c (doprnt): Don't return value smaller than the buffer
1753 size if the message was truncated. (Bug#8545).
1754
1755 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1756
1757 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1758 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1759
1760 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1763
1764 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1765
1766 * makefile.w32-in: Update dependencies.
1767
1768 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1769
1770 Improve `doprnt' and its usage. (Bug#8545)
1771 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1772 `format_end'. Remove support for %l as a conversion specifier.
1773 Don't use xrealloc. Improve diagnostics when the %l size modifier
1774 is used. Update the commentary.
1775
1776 * eval.c (verror): Simplify calculation of size_t.
1777
1778 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1779 messages.
1780
1781 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1782
1783 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1784 change.
1785
1786 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1789 This makes this file independent of the recent pseudovector change.
1790
1791 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1792
1793 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1794
1795 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1796 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1797 Remove unused local.
1798 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1799
1800 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1801 GCC 4.6.0 optimizes based on type-based alias analysis.
1802 For example, if b is of type struct buffer * and v of type struct
1803 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1804 != &v->size, and therefore "v->size = 1; b->size = 2; return
1805 v->size;" must therefore return 1. This assumption is incorrect
1806 for Emacs, since it type-puns struct Lisp_Vector * with many other
1807 types. To fix this problem, this patch adds a new type struct
1808 vectorlike_header that documents the constraints on layout of vectors
1809 and pseudovectors, and helps optimizing compilers not get fooled
1810 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1811 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1812 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1813 the size member.
1814 (XSETPVECTYPE): Rewrite in terms of new macro.
1815 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1816 This is a bit clearer, and further avoids the possibility of
1817 undesirable aliasing.
1818 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1819 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1820 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1821 since Lisp_Subr is a special case (no "next" field).
1822 (ASIZE): Now uses header.size rather than size.
1823 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1824 to avoid the hassle of writing XVECTOR (foo)->header.size.
1825 (struct vectorlike_header): New type.
1826 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1827 object, to help avoid aliasing.
1828 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1829 (SUBRP): Likewise, since Lisp_Subr is a special case.
1830 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1831 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1832 (struct Lisp_Hash_Table): Combine first two members into a single
1833 struct vectorlike_header member. All uses of "size" and "next" members
1834 changed to be "header.size" and "header.next".
1835 * buffer.h (struct buffer): Likewise.
1836 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1837 * frame.h (struct frame): Likewise.
1838 * process.h (struct Lisp_Process): Likewise.
1839 * termhooks.h (struct terminal): Likewise.
1840 * window.c (struct save_window_data, struct saved_window): Likewise.
1841 * window.h (struct window): Likewise.
1842 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1843 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1844 * buffer.c (init_buffer_once): Likewise.
1845 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1846 special case.
1847 * process.c (Fformat_network_address): Use local var for size,
1848 for brevity.
1849
1850 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1851
1852 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1853 * data.c (atof): Remove decl; no longer used or needed.
1854 (digit_to_number): Move to lread.c.
1855 (Fstring_to_number): Use new string_to_number function, to be
1856 consistent with how the Lisp reader treats infinities and NaNs.
1857 Do not assume that floating-point numbers represent EMACS_INT
1858 without losing information; this is not true on most 64-bit hosts.
1859 Avoid double-rounding errors, by insisting on integers when
1860 parsing non-base-10 numbers, as the documentation specifies.
1861 * lisp.h (string_to_number): New decl, replacing ...
1862 (isfloat_string): Remove.
1863 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1864 (read1): Do not accept +. and -. as integers; this
1865 appears to have been a coding error. Similarly, do not accept
1866 strings like +-1e0 as floating point numbers. Do not report
1867 overflow for integer overflows unless the base is not 10 which
1868 means we have no simple and reliable way to continue.
1869 Break out the floating-point parsing into a new
1870 function string_to_number, so that Fstring_to_number parses
1871 floating point numbers consistently with the Lisp reader.
1872 (digit_to_number): Move here from data.c. Make it static inline.
1873 (E_CHAR, EXP_INT): Remove, replacing with ...
1874 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1875 (string_to_number): New function, replacing isfloat_string.
1876 This function checks for valid syntax and produces the resulting
1877 Lisp float number too. Rework it so that string-to-number
1878 no longer mishandles examples like "1.0e+". Use strtoumax,
1879 so that overflow for non-base-10 numbers is reported only when
1880 there's no portable and simple way to convert to floating point.
1881
1882 * textprop.c (set_text_properties_1): Rewrite for clarity,
1883 and to avoid GCC warning about integer overflow.
1884
1885 * intervals.h (struct interval): Use EMACS_INT for members
1886 where EMACS_UINT might cause problems. See
1887 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1888 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1889 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1890 All uses changed.
1891 (offset_intervals): Tell GCC not to worry about length overflow
1892 when negating a negative length.
1893
1894 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1895 (overrun_check_free): Likewise.
1896
1897 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1898 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1899 word size.
1900
1901 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1902 (gnutls_make_error): Rename local to avoid shadowing.
1903 (gnutls_emacs_global_deinit): ifdef out; not used.
1904 (Fgnutls_boot): Use const for pointer to readonly storage.
1905 Comment out unused local. Fix pointer signedness problems.
1906
1907 * lread.c (openp): Don't stuff size_t into an 'int'.
1908 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1909 about possible signed overflow.
1910
1911 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1912 (GDK_KEY_g): Don't define if already defined.
1913 (xg_prepare_tooltip): Avoid pointer signedness problem.
1914 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1915
1916 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1917 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1918
1919 * xfns.c (Fx_window_property): Simplify a bit,
1920 to make a bit faster and to avoid GCC 4.6.0 warning.
1921 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1922
1923 * fns.c (internal_equal): Don't assume size_t fits in int.
1924
1925 * alloc.c (compact_small_strings): Tighten assertion a little.
1926
1927 Replace pEd with more-general pI, and fix some printf arg casts.
1928 * lisp.h (pI): New macro, generalizing old pEd macro to other
1929 conversion specifiers. For example, use "...%"pI"d..." rather
1930 than "...%"pEd"...".
1931 (pEd): Remove. All uses replaced with similar uses of pI.
1932 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1933 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1934 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1935 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1936 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1937 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1938 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1939 64-bit hosts.
1940 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1941 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1942 * print.c (safe_debug_print, print_object): Likewise.
1943 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1944 to int.
1945 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1946 avoiding the 0 flag, which is not portable.
1947 * process.c (Fmake_network_process): Use pI to avoid cast.
1948 * region-cache.c (pp_cache): Likewise.
1949 * xdisp.c (decode_mode_spec): Likewise.
1950 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1951 behavior on 64-bit hosts with printf arg.
1952 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1953 (x_stop_queuing_selection_requests): Likewise.
1954 (x_get_window_property): Don't truncate byte count to an 'int'
1955 when tracing.
1956
1957 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1958 here, since it parses constructs like leading '-' and spaces,
1959 which are not wanted; and it overflows with large numbers.
1960 Instead, simply match F[0-9]+, which is what is wanted anyway.
1961
1962 * alloc.c: Remove unportable assumptions about struct layout.
1963 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1964 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1965 (allocate_vectorlike, make_pure_vector): Use the new macros,
1966 plus offsetof, to remove unportable assumptions about struct layout.
1967 These assumptions hold on all porting targets that I know of, but
1968 they are not guaranteed, they're easy to remove, and removing them
1969 makes further changes easier.
1970
1971 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1972 This doesn't fix a bug but makes the code clearer.
1973 (string_overrun_cookie): Now const. Use initializers that
1974 don't formally overflow signed char, to avoid warnings.
1975 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1976 can cause Emacs to crash when string overrun checking is enabled.
1977 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1978 multiple of sizeof (EMACS_INT); it need not be, if
1979 alignof(EMACS_INT) < sizeof (EMACS_INT).
1980 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1981
1982 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1983
1984 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1985
1986 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1987
1988 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1989 supposed to be handshaking. (Bug#8556)
1990 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1991
1992 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1993
1994 * lisp.h (Qdebug): List symbol.
1995 * eval.c (Qdebug): Restore global linkage.
1996 * keyboard.c (debug-on-event): New variable.
1997 (handle_user_signal): Break into debugger when debug-on-event
1998 matches the current signal symbol.
1999
2000 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2001
2002 * alloc.c (check_sblock, check_string_bytes)
2003 (check_string_free_list): Convert to standard C.
2004
2005 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2006
2007 * w32.c (emacs_gnutls_push): Fix typo.
2008
2009 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2010
2011 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2012 "cast to pointer from integer of different size".
2013
2014 Improve doprnt and its use in verror. (Bug#8545)
2015 * doprnt.c (doprnt): Document the set of format control sequences
2016 supported by the function. Use SAFE_ALLOCA instead of always
2017 using `alloca'.
2018
2019 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2020 is one byte too soon. Don't use xrealloc; instead xfree and
2021 xmalloc anew.
2022
2023 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2024
2025 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2026 callbacks stage.
2027
2028 * gnutls.c: Renamed global_initialized to
2029 gnutls_global_initialized. Added internals for the
2030 :verify-hostname-error, :verify-error, and :verify-flags
2031 parameters of `gnutls-boot' and documented those parameters in the
2032 docstring. Start callback support.
2033 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2034 unless a fatal error occured. Call gnutls_alert_send_appropriate
2035 on error. Return error code.
2036 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2037 (emacs_gnutls_read): Likewise.
2038 (Fgnutls_boot): Return handshake error code.
2039 (emacs_gnutls_handle_error): New function.
2040 (wsaerror_to_errno): Likewise.
2041
2042 * w32.h (emacs_gnutls_pull): Add prototype.
2043 (emacs_gnutls_push): Likewise.
2044
2045 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2046 (emacs_gnutls_push): Likewise.
2047
2048 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2049
2050 * process.c (wait_reading_process_output): Check if GnuTLS
2051 buffered some data internally if no FDs are set for TLS
2052 connections.
2053
2054 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2055 (LIBS): Link to USER_LIBS.
2056 ($(BLD)/gnutls.$(0)): New target.
2057
2058 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2059
2060 * xdisp.c (handle_single_display_spec): Rename the
2061 display_replaced_before_p argument into display_replaced_p, to
2062 make it consistent with the commentary. Fix typos in the
2063 commentary.
2064
2065 * textprop.c (syms_of_textprop): Remove dead code.
2066 (copy_text_properties): Delete obsolete commentary about an
2067 interface that was deleted long ago. Fix typos in the description
2068 of arguments.
2069
2070 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2071 to changes in oldXMenu/XMenu.h from 2011-04-16.
2072 <menu_help_message, prev_menu_help_message>: Constify.
2073 (IT_menu_make_room): menu->help_text is now `const char **';
2074 adjust.
2075
2076 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2077 to changes in oldXMenu/XMenu.h from 2011-04-16.
2078 (struct XMenu): Declare `help_text' `const char **'.
2079
2080 * xfaces.c <Qunspecified>: Make extern again.
2081
2082 * syntax.c: Include sys/types.h before including regex.h, as
2083 required by Posix.
2084
2085 * doc.c (get_doc_string): Improve the format passed to `error'.
2086
2087 * doprnt.c (doprnt): Improve commentary.
2088
2089 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2090
2091 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2092 them with etags.
2093
2094 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2095 changes in globals.h immediately force recompilation.
2096 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2097 $(CURDIR)/s/ms-w32.h.
2098 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2099
2100 * character.c (Fchar_direction): Function deleted.
2101 (syms_of_character): Don't defsubr it.
2102 <char-direction-table>: Deleted.
2103
2104 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2105
2106 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2107 * doprnt.c: Include limits.h.
2108 (SIZE_MAX): New macro.
2109 (doprnt): Return a size_t value. 2nd arg is now size_t.
2110 Many local variables are now size_t instead of int or unsigned.
2111 Improve overflow protection. Support `l' modifier for integer
2112 conversions. Support %l conversion. Don't assume an EMACS_INT
2113 argument for integer conversions and for %c.
2114
2115 * lisp.h (doprnt): Restore prototype.
2116
2117 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2118 $(SRC)/character.h.
2119
2120 * Makefile.in (base_obj): Add back doprnt.o.
2121
2122 * deps.mk (doprnt.o): Add back prerequisites.
2123 (callint.o): Depend on character.h.
2124
2125 * eval.c (internal_lisp_condition_case): Include the handler
2126 representation in the error message.
2127 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2128 when breaking from the loop.
2129
2130 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2131
2132 * callint.c (Fcall_interactively): When displaying error message
2133 about invalid control letter, pass the character's codepoint, not
2134 a pointer to its multibyte form. Improve display of the character
2135 in octal and display also its hex code.
2136
2137 * character.c (char_string): Use %x to display the (unsigned)
2138 codepoint of an invalid character, to avoid displaying a bogus
2139 negative value.
2140
2141 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2142 `error', not SYMBOL_NAME itself.
2143
2144 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2145 character arguments to `error'.
2146
2147 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2148 to `error' in error message about FINAL_CHAR argument. Make sure
2149 FINAL_CHAR is a character, and use %c when it is passed as
2150 argument to `error'.
2151
2152 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2153
2154 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2155
2156 * w32.c: Include <time.h>.
2157 (sys_localtime): New function.
2158
2159 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2160
2161 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2162
2163 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2164
2165 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2166
2167 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2168 zombies (Bug#8467).
2169
2170 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2171
2172 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2173 gl_state.e_property when gl_state.object is Qt.
2174
2175 * insdel.c (make_gap_larger): Remove limitation of buffer size
2176 to <= INT_MAX.
2177
2178 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2179
2180 * xdisp.c (lookup_glyphless_char_display)
2181 (produce_glyphless_glyph): Handle cons cell entry in
2182 glyphless-char-display.
2183 (Vglyphless_char_display): Document it.
2184
2185 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2186 glyphless-char-display.
2187
2188 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2189
2190 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2191
2192 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2193
2194 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2195 definition for no-X builds.
2196
2197 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2198
2199 Static checks with GCC 4.6.0 and non-default toolkits.
2200
2201 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2202
2203 * process.c (keyboard_bit_set): Define only if SIGIO.
2204 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2205 (send_process): Repair possible setjmp clobbering.
2206
2207 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2208
2209 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2210
2211 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2212
2213 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2214 Define only if needed.
2215
2216 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2217 by pacifying GCC about it. Maybe it's time to retire it?
2218 * xfaces.c (USG, __TIMEVAL__): Likewise.
2219
2220 * dispextern.h (struct redisplay_interface): Rename param
2221 to avoid shadowing.
2222 * termhooks.h (struct terminal): Likewise.
2223 * xterm.c (xembed_send_message): Likewise.
2224
2225 * insdel.c (make_gap_smaller): Define only if
2226 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2227
2228 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2229 it.
2230
2231 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2232 so that we aren't warned about unused symbols.
2233
2234 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2235
2236 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2237
2238 * xfns.c (x_real_positions): Mark locals as initialized.
2239
2240 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2241
2242 * xterm.c: Fix problems found by static analysis with other toolkits.
2243 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2244 (x_dispatch_event): Declare static if USE_GTK, and
2245 define if USE_GTK || USE_X_TOOLKIT.
2246 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2247 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2248 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2249 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2250
2251 * xmenu.c (menu_help_callback): Pointer type fixes.
2252 Use const pointers when pointing at readonly data. Avoid pointer
2253 signedness clashes.
2254 (FALSE): Remove unused macro.
2255 (update_frame_menubar): Remove unused decl.
2256
2257 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2258
2259 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2260 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2261 (single_menu_item): Rename local to avoid shadowing.
2262
2263 * keyboard.c (make_lispy_event): Remove unused local var.
2264
2265 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2266 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2267
2268 * bitmaps: Change bitmaps from unsigned char back to the X11
2269 compatible char. Avoid the old compiler warnings about
2270 out-of-range initializers by using, for example, '\xab' rather
2271 than 0xab.
2272
2273 * xgselect.c (xgselect_initialize): Check vs interface
2274 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2275
2276 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2277
2278 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2279 to read-only memory.
2280
2281 * fns.c (vector): Remove; this old hack is no longer needed.
2282
2283 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2284 Remove unused var.
2285 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2286
2287 * xrdb.c (x_load_resources): Omit unused local.
2288
2289 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2290 (x_window): Rename locals to avoid shadowing.
2291 (USG): Use the kludged USG macro, to pacify gcc.
2292
2293 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2294 (x_term_init): Remove local to avoid shadowing.
2295
2296 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2297
2298 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2299 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2300
2301 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2302
2303 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2304
2305 Fix regex.c, syntax.c and friends for buffers > 2GB.
2306 * syntax.h (struct gl_state_s): Declare character position members
2307 EMACS_INT.
2308
2309 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2310
2311 * textprop.c (verify_interval_modification, interval_of):
2312 Declare arguments EMACS_INT.
2313
2314 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2315 EMACS_INT.
2316
2317 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2318
2319 * indent.c (Fvertical_motion): Local variable it_start is now
2320 EMACS_INT.
2321
2322 * regex.c (re_match, re_match_2, re_match_2_internal)
2323 (bcmp_translate, regcomp, regexec, print_double_string)
2324 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2325 (re_compile_pattern, re_exec): Declare arguments and local
2326 variables `size_t' and `ssize_t' and return values `regoff_t', as
2327 appropriate.
2328 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2329 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2330 <compile_stack_type>: `size' and `avail' are now `size_t'.
2331
2332 * regex.h <regoff_t>: Use ssize_t, not int.
2333 (re_search, re_search_2, re_match, re_match_2): Arguments that
2334 specify buffer/string position and length are now ssize_t and
2335 size_t. Return type is regoff_t.
2336
2337 2011-04-16 Ben Key <bkey76@gmail.com>
2338
2339 * nsfont.m: Fixed bugs in ns_get_family and
2340 ns_descriptor_to_entity that were caused by using free to
2341 deallocate memory blocks that were allocated by xmalloc (via
2342 xstrdup). This caused Emacs to crash when compiled with
2343 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2344 --enable-checking=xmallocoverrun). xfree is now used to
2345 deallocate these memory blocks.
2346
2347 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2348
2349 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2350
2351 emacs_write: Accept and return EMACS_INT for sizes.
2352 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2353 et seq.
2354 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2355 Accept and return EMACS_INT.
2356 (emacs_gnutls_write): Return the number of bytes written on
2357 partial writes.
2358 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2359 (emacs_read, emacs_write): Remove check for negative size, as the
2360 Emacs source code has been audited now.
2361 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2362 (emacs_read, emacs_write): Use it.
2363 * process.c (send_process): Adjust to the new signatures of
2364 emacs_write and emacs_gnutls_write. Do not attempt to store
2365 a byte offset into an 'int'; it might overflow.
2366 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2367
2368 * sound.c: Don't assume sizes fit in 'int'.
2369 (struct sound_device.period_size, alsa_period_size):
2370 Return EMACS_INT, not int.
2371 (struct sound_device.write, vox_write, alsa_write):
2372 Accept EMACS_INT, not int.
2373 (wav_play, au_play): Use EMACS_INT to store sizes and to
2374 record read return values.
2375
2376 2011-04-15 Ben Key <bkey76@gmail.com>
2377
2378 * keyboard.c (Qundefined): Don't declare static since it is used
2379 in nsfns.m.
2380 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2381 static since they are used in nsfont.m.
2382
2383 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2384
2385 * process.c (Qprocessp): Don't declare static.
2386 * lisp.h (Qprocessp): Declare again.
2387
2388 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2389
2390 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2391
2392 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 Improve C-level modularity by making more things 'static'.
2395
2396 Don't publish debugger-only interfaces to other modules.
2397 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2398 (verify_bytepos, count_markers): Move decls to the only modules
2399 that need them.
2400 * region-cache.h (pp_cache): Likewise.
2401 * window.h (check_all_windows): Likewise.
2402 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2403
2404 * sysdep.c (croak): Now static, if
2405 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2406 * syssignal.h (croak): Declare only if not static.
2407
2408 * alloc.c (refill_memory_reserve): Now static if
2409 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2410 * lisp.h (refill_memory_reserve): Declare only if not static.
2411
2412 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2413 Define only if USE_LUCID.
2414
2415 * xrdb.c (x_customization_string, x_rm_string): Now static.
2416
2417 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2418 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2419
2420 * xdisp.c (draw_row_with_mouse_face): Now static.
2421 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2422
2423 * window.h (check_all_windows): Mark externally visible.
2424
2425 * window.c (window_deletion_count): Now static.
2426
2427 * undo.c: Make symbols static if they're not exported.
2428 (last_undo_buffer, last_boundary_position, pending_boundary):
2429 Now static.
2430
2431 * textprop.c (interval_insert_behind_hooks): Now static.
2432 (interval_insert_in_front_hooks): Likewise.
2433
2434 * term.c: Make symbols static if they're not exported.
2435 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2436 (max_frame_lines, tty_set_terminal_modes):
2437 (tty_reset_terminal_modes, tty_turn_off_highlight):
2438 (get_tty_terminal): Now static.
2439 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2440 * termhooks.h (term_mouse_moveto): Do not declare if
2441 HAVE_WINDOW_SYSTEM.
2442 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2443 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2444
2445 * sysdep.c: Make symbols static if they're not exported.
2446 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2447 Now static.
2448 (sigprocmask_set, full_mask): Remove; unused.
2449 (wait_debugging): Mark as visible.
2450 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2451 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2452
2453 * syntax.c (syntax_temp): Define only if !__GNUC__.
2454
2455 * sound.c (current_sound_device, current_sound): Now static.
2456
2457 * search.c (searchbufs, searchbuf_head): Now static.
2458
2459 * scroll.c (scroll_cost): Remove; unused.
2460 * dispextern.h (scroll_cost): Remove decl.
2461
2462 * region-cache.h (pp_cache): Mark as externally visible.
2463
2464 * process.c: Make symbols static if they're not exported.
2465 (process_tick, update_tick, create_process, chan_process):
2466 (Vprocess_alist, proc_buffered_char, datagram_access):
2467 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2468 (deactivate_process): Mark defn as static, as well as decl.
2469 * lisp.h (create_process): Remove decl.
2470 * process.h (chan_process, Vprocess_alist): Remove decls.
2471
2472 * print.c: Make symbols static if they're not exported.
2473 (print_depth, new_backquote_output, being_printed, print_buffer):
2474 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2475 (print_interval, print_number_index, initial_stderr_stream):
2476 Now static.
2477 * lisp.h (Fprinc): Remove decl.
2478 (debug_output_compilation_hack): Mark as externally visible.
2479
2480 * sysdep.c (croak): Move decl from here to syssignal.h.
2481 * syssignal.h (croak): Put it here, so the API can be checked when
2482 'croak' is called from dissociate_if_controlling_tty.
2483
2484 * minibuf.c: Make symbols static if they're not exported.
2485 (minibuf_save_list, choose_minibuf_frame): Now static.
2486 * lisp.h (choose_minibuf_frame): Remove decl.
2487
2488 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2489
2490 * lread.c: Make symbols static if they're not exported.
2491 (read_objects, initial_obarray, oblookup_last_bucket_number):
2492 Now static.
2493 (make_symbol): Remove; unused.
2494 * lisp.h (initial_obarray, make_symbol): Remove decls.
2495
2496 * keyboard.c: Make symbols static if they're not exported.
2497 (single_kboard, recent_keys_index, total_keys, recent_keys):
2498 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2499 (this_single_command_key_start, echoing, last_auto_save):
2500 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2501 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2502 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2503 (Vlispy_mouse_stem, double_click_count):
2504 Now static.
2505 (force_auto_save_soon): Define only if SIGDANGER.
2506 (ignore_mouse_drag_p): Now static if
2507 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2508 (print_help): Remove; unused.
2509 (stop_character, last_timer_event): Mark as externally visible.
2510 * keyboard.h (ignore_mouse_drag_p): Declare only if
2511 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2512 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2513 * lisp.h (echoing): Remove decl.
2514 (force_auto_save_soon): Declare only if SIGDANGER.
2515 * xdisp.c (redisplay_window): Simplify code, to make it more
2516 obvious that ignore_mouse_drag_p is not accessed if !defined
2517 USE_GTK && !defined HAVE_NS.
2518
2519 * intervals.c: Make symbols static if they're not exported.
2520 (merge_properties_sticky, merge_interval_right, delete_interval):
2521 Now static.
2522 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2523
2524 * insdel.c: Make symbols static if they're not exported.
2525 However, leave prepare_to_modify_buffer alone. It's never
2526 called from outside this function, but that appears to be a bug.
2527 (combine_after_change_list, combine_after_change_buffer):
2528 (adjust_after_replace, signal_before_change): Now static.
2529 (adjust_after_replace_noundo): Remove; unused.
2530 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2531 (signal_before_change): Remove decls.
2532
2533 * indent.c (val_compute_motion, val_vmotion): Now static.
2534
2535 * image.c: Make symbols static if they're not exported.
2536 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2537 if USE_GTK.
2538 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2539 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2540
2541 * fringe.c (standard_bitmaps): Now static.
2542 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2543
2544 * frame.c: Make symbols static if they're not exported.
2545 (x_report_frame_params, make_terminal_frame): Now static.
2546 (get_frame_param): Now static, unless HAVE_NS.
2547 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2548 (x_get_resource_string): Remove; not used.
2549 * frame.h (make_terminal_frame, x_report_frame_params):
2550 (x_get_resource_string); Remove decls.
2551 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2552 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2553
2554 * font.c, fontset.c: Make symbols static if they're not exported.
2555 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2556 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2557 * font.c (font_close_object): Now static.
2558 * font.h (font_close_object): Remove.
2559 * fontset.c (FONTSET_OBJLIST): Remove.
2560 (free_realized_fontset) #if-0 the body, which does nothing.
2561 (face_suitable_for_char_p): #if-0, as it's never called.
2562 * fontset.h (face_suitable_for_char_p): Remove decl.
2563 * xfaces.c (face_at_string_position):
2564 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2565 since 0 is always ASCII.
2566
2567 * fns.c (weak_hash_tables): Now static.
2568
2569 * fileio.c: Make symbols static if they're not exported.
2570 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2571 (Vwrite_region_annotation_buffers): Now static.
2572
2573 * eval.c: Make symbols static if they're not exported.
2574 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2575 * lisp.h (backtrace_list): Remove decl.
2576
2577 * emacs.c: Make symbols static if they're not exported.
2578 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2579 (fatal_error_code, fatal_error_signal_hook, standard_args):
2580 Now static.
2581 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2582 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2583 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2584 * lisp.h (fatal_error_signal_hook): Remove decl.
2585 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2586
2587 * editfns.c: Move a (normally-unused) function to its only use.
2588 * editfns.c, lisp.h (get_operating_system_release): Remove.
2589 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2590 worth the hassle of breaking this out.
2591
2592 * xterm.c: Make symbols static if they're not exported.
2593 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2594 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2595 (x_destroy_window, x_delete_display):
2596 Now static.
2597 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2598 (x_mouse_leave): Remove; unused.
2599 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2600 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2601 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2602 Remove decls.
2603 (x_mouse_leave): Declare only if WINDOWSNT.
2604 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2605 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2606 USE_X_TOOLKIT.
2607
2608 * ftxfont.c: Make symbols static if they're not exported.
2609 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2610 HAVE_FREETYPE.
2611 * font.h (ftxfont_driver): Likewise.
2612
2613 * xfns.c: Make symbols static if they're not exported.
2614 (x_last_font_name, x_display_info_for_name):
2615 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2616 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2617 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2618 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2619 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2620 (last_show_tip_args): Now static.
2621 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2622 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2623 (x_screen_planes): Remove; unused.
2624 * dispextern.h (x_screen_planes): Remove decl.
2625
2626 * dispnew.c: Make symbols static if they're not exported.
2627 * dispextern.h (redraw_garbaged_frames, scrolling):
2628 (increment_row_positions): Remove.
2629 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2630 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2631 Now static.
2632 (redraw_garbaged_frames): Remove; unused.
2633
2634 * xfaces.c: Make symbols static if they're not exported.
2635 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2636 Remove decls.
2637 * xterm.h (defined_color): Remove decls.
2638 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2639 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2640 (menu_face_changed_default, defined_color, free_realized_face):
2641 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2642 (ascii_face_of_lisp_face): Remove; unused.
2643
2644 * xdisp.c: Make symbols static if they're not exported.
2645 * dispextern.h (scratch_glyph_row, window_box_edges):
2646 (glyph_to_pixel_coords, set_cursor_from_row):
2647 (get_next_display_element, set_iterator_to_next):
2648 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2649 (show_mouse_face): Remove decls
2650 * frame.h (message_buf_print): Likewise.
2651 * lisp.h (pop_message, set_message, check_point_in_composition):
2652 Likewise.
2653 * xterm.h (set_vertical_scroll_bar): Likewise.
2654 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2655 (message_buf_print, scratch_glyph_row, displayed_buffer):
2656 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2657 (get_next_display_element, show_mouse_face, window_box_edges):
2658 (frame_to_window_pixel_xy, check_point_in_composition):
2659 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2660 (glyph_to_pixel_coords): Remove; unused.
2661
2662 * dired.c (file_name_completion): Now static.
2663
2664 * dbusbind.c (xd_in_read_queued_messages): Now static.
2665
2666 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2667 * data.c (circular_list_error): Remove.
2668
2669 * commands.h (last_point_position, last_point_position_buffer):
2670 (last_point_position_window): Remove decls.
2671 * keyboard.c: Make these variables static.
2672
2673 * coding.h (coding, code_convert_region, encode_coding_gap):
2674 Remove decls.
2675 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2676 (iso_code_class, detect_coding, code_convert_region): Now static.
2677 (encode_coding_gap): Remove; unused.
2678
2679 * chartab.c (chartab_chars, chartab_bits): Now static.
2680
2681 * charset.h (charset_iso_8859_1): Remove decl.
2682 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2683 Now static.
2684
2685 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2686 * ccl.c (Vccl_program_table): Now static.
2687 (check_ccl_update): Remove; unused.
2688
2689 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2690 * category.h: ... from here.
2691 * category.c (check_category_table, set_category_set): Now static.
2692
2693 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2694 * lisp.h: Remove these decls.
2695
2696 * buffer.c (buffer_count): Remove unused var.
2697
2698 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2699 so that it's not optimized away.
2700 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2701 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2702 exported only to the debugger.
2703
2704 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2705 * atimer.h (run_all_atimers): Remove; not exported.
2706
2707 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2708 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2709 was inaccessible from Lisp.
2710 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2711 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2712
2713 alloc.c: Import and export fewer symbols, and remove unused items.
2714 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2715 is defined.
2716 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2717 it's not optimized away by whole-program optimization.
2718 (message_enable_multibyte, free_misc): Remove.
2719 (catchlist, handlerlist, mark_backtrace):
2720 Declare only if BYTE_MARK_STACK.
2721 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2722 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2723 (message_enable_multibyte): Remove decl.
2724 (free_misc, interval_free_list, float_block, float_block_index):
2725 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2726 (cons_free_list, last_marked_index):
2727 Now static.
2728 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2729 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2730 (mark_backtrace): Define only if BYTE_MARK_STACK.
2731 * xdisp.c (message_enable_multibyte): Now static.
2732
2733 Declare Lisp_Object Q* variables to be 'static' if not exported.
2734 This makes it easier for human readers (and static analyzers)
2735 to see whether these variables are used from other modules.
2736 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2737 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2738 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2739 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2740 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2741 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2742 * xmenu.c, xselect.c:
2743 Declare Q* vars static if they are not used in other modules.
2744 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2745 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2746 Remove decls of unexported vars.
2747 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2748
2749 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2750
2751 Make Emacs functions such as Fatom 'static' by default.
2752 This makes it easier for human readers (and static analyzers)
2753 to see whether these functions can be called from other modules.
2754 DEFUN now defines a static function. To make the function external
2755 so that it can be used in other C modules, use the new macro DEFUE.
2756 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2757 (Finit_image_library):
2758 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2759 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2760 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2761 Remove decls, since these functions are now static.
2762 (Funintern, Fget_internal_run_time): New decls, since these functions
2763 were already external.
2764
2765 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2766 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2767 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2768 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2769 * keyboard.c, keymap.c, lread.c:
2770 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2771 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2772 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2773 Mark functions with DEFUE instead of DEFUN,
2774 if they are used in other modules.
2775 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2776 decls for now-static functions.
2777 * buffer.h (Fdelete_overlay): Remove decl.
2778 * callproc.c (Fgetenv_internal): Mark as internal.
2779 * composite.c (Fremove_list_of_text_properties): Remove decl.
2780 (Fcomposition_get_gstring): New forward static decl.
2781 * composite.h (Fcomposite_get_gstring): Remove decl.
2782 * dired.c (Ffile_attributes): New forward static decl.
2783 * doc.c (Fdocumntation_property): New forward static decl.
2784 * eval.c (Ffetch_bytecode): New forward static decl.
2785 (Funintern): Remove extern decl; now in .h file where it belongs.
2786 * fileio.c (Fmake_symbolic_link): New forward static decl.
2787 * image.c (Finit_image_library): New forward static decl.
2788 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2789 * intervals.h (Fprevious_property_change):
2790 (Fremove_list_of_text_properties): Remove decls.
2791 * keyboard.c (Fthis_command_keys): Remove decl.
2792 (Fcommand_execute): New forward static decl.
2793 * keymap.c (Flookup_key): New forward static decl.
2794 (Fcopy_keymap): Now static.
2795 * keymap.h (Flookup_key): Remove decl.
2796 * process.c (Fget_process): New forward static decl.
2797 (Fprocess_datagram_address): Mark as internal.
2798 * syntax.c (Fsyntax_table_p): New forward static decl.
2799 (skip_chars): Remove duplicate decl.
2800 * textprop.c (Fprevious_property_change): New forward static decl.
2801 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2802 Now internal.
2803 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2804 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2805
2806 * editfns.c (Fformat): Remove unreachable code.
2807
2808 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2809
2810 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2811 change. (Bug#8496)
2812
2813 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2814
2815 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2816 when at ZV. (Bug#8487)
2817
2818 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2819
2820 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2821 (Bug#8437)
2822 * keyboard.c (parse_tool_bar_item): Likewise.
2823 * sound.c (sound_cleanup, alsa_close): Likewise.
2824 * termcap.c (tgetent): Likewise.
2825 * xfns.c (x_default_font_parameter): Likewise.
2826 * xsettings.c (read_and_apply_settings): Likewise.
2827
2828 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2829 (overrun_check_free): Protoize.
2830
2831 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2832
2833 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2834 since callers should never pass a negative size.
2835 Change the signature to match that of plain 'read' and 'write'; see
2836 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2837 * lisp.h: Update prototypes of emacs_write and emacs_read.
2838
2839 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2840
2841 * xdisp.c (redisplay_window): Don't try to determine the character
2842 position of the scroll margin if the window start point w->startp
2843 is outside the buffer's accessible region. (Bug#8468)
2844
2845 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2846
2847 Fix write-region and its subroutines for buffers > 2GB.
2848 * fileio.c (a_write, e_write): Modify declaration of arguments and
2849 local variables to support buffers larger than 2GB.
2850 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2851
2852 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2853 argument, local variables, and return value.
2854
2855 * lisp.h: Update prototypes of emacs_write and emacs_read.
2856
2857 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2858
2859 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2860
2861 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2862
2863 Fix more problems found by GCC 4.6.0's static checks.
2864
2865 * xdisp.c (vmessage): Use a better test for character truncation.
2866
2867 * charset.c (load_charset_map): <, not <=, for optimization,
2868 and to avoid potential problems with integer overflow.
2869 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2870 * casetab.c (set_identity, shuffle): Likewise.
2871 * editfns.c (Fformat): Likewise.
2872 * syntax.c (skip_chars): Likewise.
2873
2874 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2875 This also lets GCC 4.6.0 generate slightly better loop code.
2876
2877 * callint.c (Fcall_interactively): <, not <=, for optimization.
2878 (Fcall_interactively): Count the number of arguments produced,
2879 not the number of arguments given. This is simpler and lets GCC
2880 4.6.0 generate slightly better code.
2881
2882 * ftfont.c: Distingish more carefully between FcChar8 and char.
2883 The previous code passed unsigned char * to a functions like
2884 strlen and xstrcasecmp that expect char *, which does not
2885 conform to the C standard.
2886 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2887 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2888 char * when the C standard requires it.
2889
2890 * keyboard.c (read_char): Remove unused var.
2891
2892 * eval.c: Port to Windows vsnprintf (Bug#8435).
2893 Include <limits.h>.
2894 (SIZE_MAX): Define if the headers do not.
2895 (verror): Do not give up if vsnprintf returns a negative count.
2896 Instead, grow the buffer. This ports to Windows vsnprintf, which
2897 does not conform to C99. Problem reported by Eli Zaretskii.
2898 Also, simplify the allocation scheme, by avoiding the need for
2899 calling realloc, and removing the ALLOCATED variable.
2900
2901 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2902
2903 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2904 But keep the doprint source code for now, as we might revamp it
2905 and use it again (Bug#8435).
2906 * lisp.h (doprnt): Remove.
2907 * Makefile.in (base_obj): Remove doprnt.o.
2908 * deps.mk (doprnt.o): Remove.
2909
2910 error: Print 32- and 64-bit integers portably (Bug#8435).
2911 Without this change, on typical 64-bit hosts error ("...%d...", N)
2912 was used to print both 32- and 64-bit integers N, which relied on
2913 undefined behavior.
2914 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2915 New macro.
2916 * lisp.h (error, verror): Mark as printf-like functions.
2917 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2918 Report overflow in size calculations when allocating printf buffer.
2919 Do not truncate output string at its first null byte.
2920 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2921 Truncate the output at a character boundary, since vsnprintf does not
2922 do that.
2923 * charset.c (check_iso_charset_parameter): Convert internal
2924 character to string before calling 'error', since %c now has the
2925 printf meaning.
2926 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2927 overflow when computing char to be passed to 'error'. Do not
2928 pass Lisp_Object to 'error'; pass the integer instead.
2929 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2930 formatted with plain %d.
2931
2932 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2933
2934 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2935
2936 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2937
2938 * xterm.c (x_catch_errors): Remove duplicate declaration.
2939
2940 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2941
2942 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2943
2944 2011-04-10 Jim Meyering <meyering@redhat.com>
2945
2946 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2947 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2948 return ssize_t not "int", and use size_t as the buffer length.
2949 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2950 * gnutls.h: Update declarations.
2951 * process.c (read_process_output): Use ssize_t, to match.
2952 (send_process): Likewise.
2953
2954 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2955
2956 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2957
2958 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2959
2960 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2961 Use unsigned char, to match FcChar8 type definition.
2962
2963 * xterm.c (handle_one_xevent):
2964 * xmenu.c (create_and_show_popup_menu):
2965 * xselect.c (x_decline_selection_request)
2966 (x_reply_selection_request): Avoid type-punned deref of X events.
2967
2968 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2969
2970 Fix some uses of `int' instead of EMACS_INT.
2971 * search.c (string_match_1, fast_string_match)
2972 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2973 (scan_buffer, find_next_newline_no_quit)
2974 (find_before_next_newline, search_command, Freplace_match)
2975 (Fmatch_data): Make some `int' variables be EMACS_INT.
2976
2977 * xdisp.c (display_count_lines): 3rd argument and return value now
2978 EMACS_INT. All callers changed.
2979 (pint2hrstr): Last argument is now EMACS_INT.
2980
2981 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2982 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2983 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2984 (decode_coding_utf_16, decode_coding_emacs_mule)
2985 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2986 (decode_coding_ccl, decode_coding_charset)
2987 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2988 (decode_coding_iso_2022, decode_coding_emacs_mule)
2989 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2990 <char_offset, last_offset>: Declare EMACS_INT.
2991 (encode_coding_utf_8, encode_coding_utf_16)
2992 (encode_coding_emacs_mule, encode_invocation_designation)
2993 (encode_designation_at_bol, encode_coding_iso_2022)
2994 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2995 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2996 Declare EMACS_INT.
2997 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2998 (encode_invocation_designation): Last argument P_NCHARS is now
2999 EMACS_INT.
3000 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3001 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3002
3003 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3004 All users changed.
3005
3006 * ccl.c (Fccl_execute_on_string): Declare some variables
3007 EMACS_INT.
3008
3009 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3010
3011 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3012
3013 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3014
3015 * process.c (Fformat_network_address): Doc fix.
3016
3017 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3018
3019 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3020
3021 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3022
3023 * keyboard.c (read_char): Call Lisp function help-form-show,
3024 instead of using internal_with_output_to_temp_buffer.
3025 (Qhelp_form_show): New var.
3026 (syms_of_keyboard): Use DEFSYM macro.
3027
3028 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3029
3030 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3031
3032 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3033
3034 * process.c (Flist_processes): Remove to Lisp.
3035 (list_processes_1): Delete.
3036
3037 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3038
3039 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3040
3041 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3042
3043 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 Fix more problems found by GCC 4.6.0's static checks.
3046
3047 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3048
3049 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3050
3051 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3052
3053 * xdisp.c (vmessage): Mark as a printf-like function.
3054
3055 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3056
3057 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3058
3059 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3060 printf-like functions.
3061 (tiff_load): Add casts to remove these marks before passing them
3062 to system-supplied API.
3063
3064 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3065
3066 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3067 This avoids several warnings with gcc -Wstrict-overflow.
3068 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3069 directly, rather than having caller test rule sign. This avoids
3070 some unnecessary tests.
3071 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3072 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3073 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3074
3075 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3076 (xfont_open): Avoid unnecessary tests.
3077
3078 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3079
3080 * composite.h, composite.c (composition_gstring_put_cache):
3081 Use EMACS_INT, not int, for length.
3082
3083 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3084 breaking out part of COMPOSITION_DECODE_RULE.
3085 (COMPOSITION_DECODE_RULE): Use it.
3086 * composite.c (get_composition_id): Remove unused local vars,
3087 by using the new macro.
3088
3089 * textprop.c (set_text_properties_1): Change while to do-while,
3090 since the condition is always true at first.
3091
3092 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3093 (interval_deletion_adjustment): Return unsigned value.
3094 All uses changed.
3095
3096 * process.c (list_processes_1, create_pty, read_process_output):
3097 (exec_sentinel): Remove vars that were set but not used.
3098 (create_pty): Remove unnecessary "volatile"s.
3099 (Fnetwork_interface_info): Avoid possibility of int overflow.
3100 (read_process_output): Do adaptive read buffering even if carryover.
3101 (read_process_output): Simplify nbytes computation if buffered.
3102
3103 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3104
3105 * syntax.c (scan_words): Remove var that was set but not used.
3106 (update_syntax_table): Use unsigned instead of int.
3107
3108 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3109 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3110 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3111
3112 * print.c (print_error_message): Avoid int overflow.
3113
3114 * font.c (font_list_entities): Redo for clarity,
3115 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3116
3117 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3118 (font_score): Avoid potential overflow in diff calculation.
3119
3120 * fns.c (substring_both): Remove var that is set but not used.
3121 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3122
3123 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3124
3125 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3126 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3127 can always succeed if overflow has undefined behavior.
3128
3129 * search.c (boyer_moore, wordify): Remove vars set but not used.
3130 (wordify): Omit three unnecessary tests.
3131
3132 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3133 All callers changed. This avoids the need for an unused var.
3134
3135 * casefiddle.c (casify_region): Remove var that is set but not used.
3136
3137 * dired.c (file_name_completion): Remove var that is set but not used.
3138
3139 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3140
3141 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3142 (Finsert_file_contents): Remove unnecessary code checking fd.
3143
3144 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3145 Check for integer overflow on size calculations.
3146
3147 * buffer.c (Fprevious_overlay_change): Remove var that is set
3148 but not used.
3149
3150 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3151 Remove vars that are set but not used.
3152 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3153 (timer_check_2): Mark vars as initialized.
3154
3155 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3156
3157 * image.c (lookup_image): Remove var that is set but not used.
3158 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3159
3160 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3161 that are set but not used.
3162
3163 * xfns.c (make_invisible_cursor): Don't return garbage
3164 if XCreateBitmapFromData fails (Bug#8410).
3165
3166 * xselect.c (x_get_local_selection, x_handle_property_notify):
3167 Remove vars that are set but not used.
3168
3169 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3170 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3171
3172 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3173 Remove var that is set but not used.
3174 (scroll_bar_windows_size): Now size_t, not int.
3175 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3176 Check for overflow.
3177
3178 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3179 (map_tty_color) [!defined MSDOS]: Likewise.
3180
3181 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3182
3183 * coding.c: Remove vars that are set but not used.
3184 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3185 All callers changed.
3186 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3187 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3188 (decode_coding_charset): Remove vars that are set but not used.
3189
3190 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3191 that is set but not used.
3192
3193 * print.c (print_object): Remove var that is set but not used.
3194
3195 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3196 The gnulib version avoids calling malloc in the usual case,
3197 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3198 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3199 * filelock.c (current_lock_owner): Likewise.
3200 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3201 * sysdep.c: Include allocator.h, careadlinkat.h.
3202 (emacs_no_realloc_allocator): New static constant.
3203 (emacs_readlink): New function.
3204 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3205 ../lib/careadlinkat.h.
3206
3207 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3208
3209 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3210 first non-nil return value).
3211
3212 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3213
3214 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3215 if not defined (Bug#8403).
3216
3217 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3218
3219 * xdisp.c (display_count_lines): Remove parameter `start',
3220 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3221 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3222 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3223 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3224 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3225 and thereabouts. All callers changed.
3226 (get_per_char_metric): Remove parameter `f', unused since
3227 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3228
3229 2011-04-02 Jim Meyering <meyering@redhat.com>
3230
3231 do not dereference NULL upon failed strdup
3232 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3233 (ns_get_family): Likewise.
3234
3235 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3236
3237 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3238
3239 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3240
3241 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3242 later (Bug#8403).
3243
3244 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3245
3246 Add lexical binding.
3247
3248 * window.c (Ftemp_output_buffer_show): New fun.
3249 (Fsave_window_excursion):
3250 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3251
3252 * lread.c (lisp_file_lexically_bound_p): New function.
3253 (Fload): Bind Qlexical_binding.
3254 (readevalloop): Remove `evalfun' arg.
3255 Bind Qinternal_interpreter_environment.
3256 (Feval_buffer): Bind Qlexical_binding.
3257 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3258 Mark as dynamic.
3259 (syms_of_lread): Declare `lexical-binding'.
3260
3261 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3262
3263 * keyboard.c (eval_dyn): New fun.
3264 (menu_item_eval_property): Use it.
3265
3266 * image.c (parse_image_spec): Use Ffunctionp.
3267
3268 * fns.c (concat, mapcar1): Accept byte-code-functions.
3269
3270 * eval.c (Fsetq): Handle lexical vars.
3271 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3272 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3273 (FletX, Flet): Obey lexical binding.
3274 (Fcommandp): Handle closures.
3275 (Feval): New `lexical' arg.
3276 (eval_sub): New function extracted from Feval. Use it almost
3277 everywhere where Feval was used. Look up vars in lexical env.
3278 Handle closures.
3279 (Ffunctionp): Move from subr.el.
3280 (Ffuncall): Handle closures.
3281 (apply_lambda): Remove `eval_flags'.
3282 (funcall_lambda): Handle closures and new byte-code-functions.
3283 (Fspecial_variable_p): New function.
3284 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3285 but without exporting it to Lisp.
3286
3287 * doc.c (Fdocumentation, store_function_docstring):
3288 * data.c (Finteractive_form): Handle closures.
3289
3290 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3291 interactive spec.
3292
3293 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3294 New byte-codes.
3295 (exec_byte_code): New function extracted from Fbyte_code to handle new
3296 calling convention for byte-code-functions. Add new byte-codes.
3297
3298 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3299
3300 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3301
3302 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3303
3304 * xdisp.c (redisplay_internal): Fix prototype.
3305
3306 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3307
3308 * xdisp.c (SCROLL_LIMIT): New macro.
3309 (try_scrolling): Use it when setting scroll_limit.
3310 Limit scrolling to 100 screen lines.
3311 (redisplay_window): Even when falling back on "recentering",
3312 position point in the window according to scroll-conservatively,
3313 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3314
3315 (try_scrolling): When point is above the window, allow searching
3316 as far as scroll_max, or one screenful, to compute vertical
3317 distance from PT to the scroll margin position. This prevents
3318 try_scrolling from unnecessarily failing when
3319 scroll-conservatively is set to a value slightly larger than the
3320 window height. Clean up the case of PT below the margin at bottom
3321 of window: scroll_max can no longer be INT_MAX. When aggressive
3322 scrolling is in use, don't let point enter the opposite scroll
3323 margin as result of the scroll.
3324 (syms_of_xdisp) <scroll-conservatively>: Document the
3325 threshold of 100 lines for never-recentering scrolling.
3326
3327 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3328
3329 * dispextern.h (move_it_by_lines):
3330 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3331 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3332 (message_log_check_duplicate): Remove parameters `prev_bol' and
3333 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3334 (redisplay_internal): Remove parameter `preserve_echo_area',
3335 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3336
3337 * indent.c (Fvertical_motion):
3338 * window.c (window_scroll_pixel_based, Frecenter):
3339 Don't pass `need_y_p' to `move_it_by_lines'.
3340
3341 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3342
3343 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3344 steal a few bits to be more compact.
3345 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3346 Remove unneeded casts.
3347
3348 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3349
3350 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3351
3352 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3353 binding" message (bug#7967).
3354
3355 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3356
3357 Fix more problems found by GCC 4.6.0's static checks.
3358
3359 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3360 Remove unused local var.
3361
3362 * editfns.c (Fmessage_box): Remove unused local var.
3363
3364 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3365 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3366 Omit unused local vars.
3367 * window.c (shrink_windows): Omit unused local var.
3368 * menu.c (digest_single_submenu): Omit unused local var.
3369 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3370 Omit unused local var.
3371
3372 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3373 Don't assume string length fits in int.
3374 (keyremap_step, read_key_sequence): Use size_t for sizes.
3375 (read_key_sequence): Don't check last_real_key_start redundantly.
3376
3377 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3378 instead of alloca (Bug#8344).
3379
3380 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3381 (Fbacktrace_frame): Don't assume nframes fits in int.
3382
3383 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3384
3385 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3386 concerns.
3387
3388 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3389
3390 * cm.c (calccost): Turn while-do into do-while, for clarity.
3391
3392 * keyboard.c (syms_of_keyboard): Use the same style as later
3393 in this function when indexing through an array. This also
3394 works around GCC bug 48267.
3395
3396 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3397
3398 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3399
3400 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3401 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3402
3403 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3404 This avoids undefined behavior on integer overflow, and is a bit
3405 more convenient anyway since it is compared to a size_t variable.
3406
3407 Variadic C functions now count arguments with size_t, not int.
3408 This avoids an unnecessary limitation on 64-bit machines, which
3409 caused (substring ...) to crash on large vectors (Bug#8344).
3410 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3411 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3412 All variadic functions and their callers changed accordingly.
3413 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3414 * data.c (arith_driver, float_arith_driver): Likewise.
3415 * editfns.c (general_insert_function): Likewise.
3416 * eval.c (struct backtrace.nargs, interactive_p)
3417 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3418 (funcall_lambda, mark_backtrace): Likewise.
3419 * fns.c (concat): Likewise.
3420 * frame.c (x_set_frame_parameters): Likewise.
3421 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3422 0 if not found, not -1. All callers changed.
3423
3424 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3425 (stack_copy_size): Now size_t, not int.
3426 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3427
3428 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3429
3430 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3431 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3432 All callers changed.
3433
3434 * lisp.h (multibyte_char_to_unibyte):
3435 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3436 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3437 * character.h (CHAR_TO_BYTE8):
3438 * cmds.c (internal_self_insert):
3439 * editfns.c (general_insert_function):
3440 * keymap.c (push_key_description):
3441 * search.c (Freplace_match):
3442 * xdisp.c (message_dolog, set_message_1): All callers changed.
3443
3444 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3445
3446 * keyboard.c (safe_run_hook_funcall): New function.
3447 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3448 don't set the hook to nil, but remove the offending function instead.
3449 (Qcommand_hook_internal): Remove, unused.
3450 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3451 Vcommand_hook_internal.
3452
3453 * eval.c (enum run_hooks_condition): Remove.
3454 (funcall_nil, funcall_not): New functions.
3455 (run_hook_with_args): Call each function through a `funcall' argument.
3456 Remove `cond' argument, now redundant.
3457 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3458 (Frun_hook_with_args_until_failure): Adjust accordingly.
3459 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3460
3461 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3462
3463 * dispextern.h (string_buffer_position): Remove declaration.
3464
3465 * print.c (strout): Remove parameter `multibyte', unused since
3466 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3467
3468 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3469 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3470 All callers changed.
3471
3472 * w32.c (_wsa_errlist): Use braces for struct initializers.
3473
3474 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3475 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3476 All callers changed.
3477 (string_buffer_position): Likewise. Also, make static (it's never
3478 used outside xdisp.c).
3479 (cursor_row_p): Remove parameter `w', unused since
3480 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3481 (decode_mode_spec): Remove parameter `precision', introduced during
3482 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3483 All callers changed.
3484
3485 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3486
3487 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3488
3489 2011-03-27 Anders Lindgren <andlind@gmail.com>
3490
3491 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3492 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3493 (ns_update_auto_hide_menu_bar): New functions.
3494 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3495 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3496 ns_constrain_all_frames.
3497 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3498 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3499
3500 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3501
3502 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3503
3504 2011-03-27 Glenn Morris <rgm@gnu.org>
3505
3506 * syssignal.h: Replace RETSIGTYPE with void.
3507 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3508 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3509 Replace SIGTYPE with void everywhere.
3510 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3511 * s/template.h (SIGTYPE): Remove commented out definition.
3512
3513 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3514
3515 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3516 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3517
3518 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3519
3520 * w32.c (read_unc_volume): Use parameter `henum', instead of
3521 global variable `wget_enum_handle'.
3522
3523 * keymap.c (describe_vector): Remove parameters `indices' and
3524 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3525 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3526
3527 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3528
3529 * keyboard.c (timer_check): Remove parameter `do_it_now',
3530 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3531 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3532 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3533
3534 * keyboard.c (read_char):
3535 * w32menu.c (w32_menu_display_help):
3536 * xmenu.c (show_help_event, menu_help_callback):
3537 Adjust calls to `show_help_echo'.
3538
3539 * gtkutil.c (xg_maybe_add_timer):
3540 * keyboard.c (readable_events):
3541 * process.c (wait_reading_process_output):
3542 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3543
3544 * insdel.c (adjust_markers_gap_motion):
3545 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3546 (gap_left, gap_right): Don't call it.
3547
3548 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3549
3550 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3551 incurred during fontification.
3552
3553 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3554
3555 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3556 (DEFVAR_PER_BUFFER): Don't pass it.
3557
3558 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3559 (scrolling_window): Don't pass it.
3560
3561 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3562
3563 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3564
3565 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3566 and `suffix'.
3567 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3568 of variables specific to SELinux and computation of `encoded_absname'.
3569
3570 * image.c (XPutPixel): Remove unused variable `height'.
3571
3572 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3573
3574 * unexw32.c (get_section_info): Remove unused variable `section'.
3575
3576 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3577 (system_process_attributes): Remove unused variable `sess'.
3578 (sys_read): Remove unused variable `err'.
3579
3580 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3581 (w32_wnd_proc): Remove unused variable `isdead'.
3582 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3583 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3584 (x_create_tip_frame): Remove unused variable `tem'.
3585
3586 * w32inevt.c (w32_console_read_socket):
3587 Remove unused variable `no_events'.
3588
3589 * w32term.c (x_draw_composite_glyph_string_foreground):
3590 Remove unused variable `width'.
3591
3592 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3593
3594 * w32term.c (x_set_glyph_string_clipping):
3595 Don't pass uninitialized region to CombineRgn.
3596
3597 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3598
3599 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3600 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3601 (Fx_close_connection): Remove unused variable `i'.
3602
3603 * w32font.c (w32font_draw): Return number of glyphs.
3604 (w32font_open_internal): Remove unused variable `i'.
3605 (w32font_driver): Add missing initializer.
3606
3607 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3608 (fill_in_menu): Remove unused variable `items_added'.
3609
3610 * w32term.c (last_mouse_press_frame): Remove static global variable.
3611 (w32_clip_to_row): Remove unused variable `f'.
3612 (x_delete_terminal): Remove unused variable `i'.
3613
3614 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3615 (NOTHING): Remove unused static global variable.
3616 (uniscribe_check_otf): Remove unused variable `table'.
3617 (uniscribe_font_driver): Add missing initializers.
3618
3619 2011-03-23 Julien Danjou <julien@danjou.info>
3620
3621 * term.c (Fsuspend_tty, Fresume_tty):
3622 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3623 * window.c (temp_output_buffer_show):
3624 * insdel.c (signal_before_change):
3625 * frame.c (Fhandle_switch_frame):
3626 * fileio.c (Fdo_auto_save):
3627 * emacs.c (Fkill_emacs):
3628 * editfns.c (save_excursion_restore):
3629 * cmds.c (internal_self_insert):
3630 * callint.c (Fcall_interactively):
3631 * buffer.c (Fkill_all_local_variables):
3632 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3633 Use Frun_hooks.
3634 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3635 unconditionnaly since it does the check itself.
3636
3637 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3638
3639 Fix more problems found by GCC 4.5.2's static checks.
3640
3641 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3642 the first time through the loop, since we know p0 < p1 then.
3643 This also avoids a gcc -Wstrict-overflow warning.
3644
3645 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3646 leading to a memory leak, possible in functions like
3647 load_charset_map_from_file that can allocate an unbounded number
3648 of objects (Bug#8318).
3649
3650 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3651 that could (at least in theory) be that large.
3652
3653 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3654 This is less likely to overflow, and avoids undefined behavior if
3655 overflow does occur. All callers changed. Use strtoul to scan
3656 for the unsigned long integer.
3657 (pint2hrstr): Simplify and tune code slightly.
3658 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3659
3660 * scroll.c (do_scrolling): Work around GCC bug 48228.
3661 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3662
3663 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3664 This also avoids a warning with gcc -Wstrict-overflow.
3665 (validate_x_resource_name): Simplify count usage.
3666 This also avoids a warning with gcc -Wstrict-overflow.
3667
3668 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3669 fail (Bug#8306).
3670
3671 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3672
3673 * process.c (Fmake_network_process): Use socklen_t, not int,
3674 where POSIX says socklen_t is required in portable programs.
3675 This fixes a porting bug on hosts like 64-bit HP-UX, where
3676 socklen_t is wider than int (Bug#8277).
3677 (Fmake_network_process, server_accept_connection):
3678 (wait_reading_process_output, read_process_output):
3679 Likewise.
3680
3681 * process.c: Rename or move locals to avoid shadowing.
3682 (list_processes_1, Fmake_network_process):
3683 (read_process_output_error_handler, exec_sentinel_error_handler):
3684 Rename or move locals.
3685 (Fmake_network_process): Define label "retry_connect" only if needed.
3686 (Fnetwork_interface_info): Fix pointer signedness.
3687 (process_send_signal): Add cast to avoid pointer signedness problem.
3688 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3689 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3690
3691 Make tparam.h and terminfo.c consistent.
3692 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3693 Include tparam.h instead, since it declares them.
3694 * cm.h (PC): Remove extern decl; tparam.h now does this.
3695 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3696 * terminfo.c: Include tparam.h, to check interfaces.
3697 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3698 (tparam): Adjust signature to match interface in tparam.h;
3699 this removes some undefined behavior. Check that outstring and len
3700 are zero, which they always are with Emacs.
3701 * tparam.h (PC, BC, UP): New extern decls.
3702
3703 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3704 (xftfont_open): Rename locals to avoid shadowing.
3705
3706 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3707 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3708 (OTF_TAG_SYM): Omit macro if not needed.
3709 (ftfont_list): Remove unused local.
3710 (get_adstyle_property, ftfont_pattern_entity):
3711 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3712 Rename locals to avoid shadowing.
3713
3714 * xfont.c (xfont_list_family): Mark var as initialized.
3715
3716 * xml.c (make_dom): Now static.
3717
3718 * composite.c (composition_compute_stop_pos): Rename local to
3719 avoid shadowing.
3720 (composition_reseat_it): Remove unused locals.
3721 (find_automatic_composition, composition_adjust_point): Likewise.
3722 (composition_update_it): Mark var as initialized.
3723 (find_automatic_composition): Mark vars as initialized,
3724 with a FIXME (Bug#8290).
3725
3726 character.h: Rename locals to avoid shadowing.
3727 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3728 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3729 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3730 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3731 to avoid shadowing.
3732
3733 * textprop.c (property_change_between_p): Remove; unused.
3734
3735 * intervals.c (interval_start_pos): Now static.
3736
3737 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3738
3739 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3740 Rename locals to avoid shadowing.
3741
3742 * sound.c (wav_play, au_play, Fplay_sound_internal):
3743 Fix pointer signedness.
3744 (alsa_choose_format): Remove unused local var.
3745 (wav_play): Initialize a variable to 0, to prevent undefined
3746 behavior (Bug#8278).
3747
3748 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3749
3750 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3751
3752 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3753 clobbering (Bug#8298).
3754 * sysdep.c (sys_subshell): Likewise.
3755 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3756
3757 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3758 This should get cleaned up, so that child_setup has the
3759 same signature on all platforms.
3760
3761 * callproc.c (call_process_cleanup): Now static.
3762 (relocate_fd): Rename locals to avoid shadowing.
3763
3764 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3765
3766 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3767 not to be necessary, and produces flickering.
3768
3769 2011-03-20 Glenn Morris <rgm@gnu.org>
3770
3771 * config.in: Remove file.
3772
3773 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3774
3775 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3776 are now in src/globals.h.
3777 (syms_of_minibuf): Remove spurious & from previous change.
3778
3779 2011-03-20 Leo <sdl.web@gmail.com>
3780
3781 * minibuf.c (completing-read-function): New variable.
3782 (completing-read-default): Rename from completing-read.
3783 (completing-read): Call completing-read-function.
3784
3785 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3786
3787 * xfaces.c (Fx_load_color_file):
3788 Read color file from absolute filename (bug#8250).
3789
3790 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3791
3792 * makefile.w32-in: Update dependencies.
3793
3794 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3795
3796 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3797
3798 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3799
3800 Fix more problems found by GCC 4.5.2's static checks.
3801
3802 * process.c (make_serial_process_unwind, send_process_trap):
3803 (sigchld_handler): Now static.
3804
3805 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3806 That way, the code declares only the vars that it needs.
3807 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3808 * s/cygwin.h (PTY_ITERATION): Likewise.
3809 * s/darwin.h (PTY_ITERATION): Likewise.
3810 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3811
3812 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3813 * process.c (allocate_pty): Don't declare stb unless it's needed.
3814
3815 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3816 (CONSTANTLIM): Remove; unused.
3817 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3818 Define only if needed.
3819
3820 * unexelf.c (unexec): Name an expression,
3821 to avoid gcc -Wbad-function-cast warning.
3822 Use a different way to cause a compilation error if anyone uses
3823 n rather than nn, a way that does not involve shadowing.
3824 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3825
3826 * deps.mk (unexalpha.o): Remove; unused.
3827
3828 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3829 * unexec.h: New file.
3830 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3831 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3832 Depend on unexec.h.
3833 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3834 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3835 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3836 Change as necessary to match prototype in unexec.h.
3837
3838 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3839 shadowing.
3840 (back_comment, skip_chars): Mark vars as initialized.
3841
3842 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3843 Rename locals to avoid shadowing.
3844
3845 * lread.c (read1): Rewrite so as not to use empty "else".
3846 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3847
3848 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3849
3850 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3851 warning when compiling print.c.
3852
3853 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3854 instead of using an uninitialized var.
3855 (font_sort_entities): Mark var as initialized.
3856
3857 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3858
3859 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3860 pointers to constants.
3861 (font_parse_fcname): Remove unused vars.
3862 (font_delete_unmatched): Now static.
3863 (font_get_spec): Remove; unused.
3864 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3865 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3866 Rename or move locals to avoid shadowing.
3867
3868 * fns.c (require_nesting_list, require_unwind): Now static.
3869 (Ffillarray): Rename locals to avoid shadowing.
3870
3871 * floatfns.c (domain_error2): Define only if needed.
3872 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3873
3874 * alloc.c (mark_backtrace): Move decl from here ...
3875 * lisp.h: ... to here, so that it can be checked.
3876
3877 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3878 (Fdefvar): Rewrite so as not to use empty "else".
3879 (lisp_indirect_variable): Name an expression,
3880 to avoid gcc -Wbad-function-cast warning.
3881 (Fdefvar): Rename locals to avoid shadowing.
3882
3883 * callint.c (quotify_arg, quotify_args): Now static.
3884 (Fcall_interactively): Rename locals to avoid shadowing.
3885 Use const pointer when appropriate.
3886
3887 * lisp.h (get_system_name, get_operating_system_release):
3888 Move decls here, to check interfaces.
3889 * process.c (get_operating_system_release): Move decl to lisp.h.
3890 * xrdb.c (get_system_name): Likewise.
3891 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3892 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3893 some of which prompt warnings from gcc -Wbad-function-cast.
3894 (Fformat_time_string, Fencode_time, Finsert_char):
3895 (Ftranslate_region_internal, Fformat):
3896 Rename or remove local vars to avoid shadowing.
3897 (Ftranslate_region_internal): Mark var as initialized.
3898
3899 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3900 avoid shadowing.
3901
3902 * lisp.h (eassert): Check that the argument compiles, even if
3903 ENABLE_CHECKING is not defined.
3904
3905 * data.c (Findirect_variable): Name an expression, to avoid
3906 gcc -Wbad-function-cast warning.
3907 (default_value, arithcompare, arith_driver, arith_error): Now static.
3908 (store_symval_forwarding): Rename local to avoid shadowing.
3909 (Fmake_variable_buffer_local, Fmake_local_variable):
3910 Mark variables as initialized.
3911 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3912
3913 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3914 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3915 Rename locals to avoid shadowing.
3916 (mark_stack): Move local variables into the #ifdef region where
3917 they're used.
3918 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3919 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3920 needed otherwise.
3921 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3922 (GC_STRING_CHARS): Remove; not used.
3923 (Fmemory_limit): Cast sbrk's returned value to char *.
3924
3925 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3926 avoids undefined behavior in theory.
3927
3928 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3929
3930 Use functions, not macros, for up- and down-casing (Bug#8254).
3931 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3932 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3933 to use the following functions instead of these macros.
3934 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3935 EMACS_INT, since callers assume the returned value fits in int.
3936 (upcase1): Likewise, for UPCASE_TABLE.
3937 (uppercasep, lowercasep, upcase): New static inline functions.
3938 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3939 the race-condition problem in the old DOWNCASE.
3940
3941 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3942 Rename locals to avoid shadowing.
3943 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3944 (regex_compile, re_search_2, re_match_2_internal):
3945 Remove unused local vars.
3946 (FREE_VAR): Rewrite so as not to use empty "else",
3947 which gcc can warn about.
3948 (regex_compile, re_match_2_internal): Mark locals as initialized.
3949 (RETALLOC_IF): Define only if needed.
3950 (WORDCHAR_P): Likewise. This one is never needed, but is used
3951 only in a comment talking about a compiler bug, so put inside
3952 the #if 0 of that comment.
3953 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3954 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3955 Remove; unused.
3956
3957 * search.c (boyer_moore): Rename locals to avoid shadowing.
3958 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3959 (PREV_CHAR_BOUNDARY): Likewise.
3960
3961 * search.c (simple_search): Remove unused var.
3962
3963 * dired.c (compile_pattern): Move decl from here ...
3964 * lisp.h: ... to here, so that it can be checked.
3965 (struct re_registers): New forward decl.
3966
3967 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3968
3969 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3970 All uses changed.
3971 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3972 Rename locals to avoid shadowing.
3973 (Fvertical_motion): Mark locals as initialized.
3974
3975 * casefiddle.c (casify_object, casify_region): Now static.
3976 (casify_region): Mark local as initialized.
3977
3978 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3979
3980 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3981 New macros, so that the caller can use some names other than
3982 gcpro1, gcpro2, etc.
3983 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3984 of the new macros.
3985 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3986 argument, for consistency with GCPRO2_VAR, etc: it is now the
3987 prefix of the variable, not the variable itself. All uses
3988 changed.
3989 * dired.c (directory_files_internal, file_name_completion):
3990 Rename locals to avoid shadowing.
3991
3992 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3993 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3994 dired.c's scmp function, had undefined behavior.
3995 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3996 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3997 * buffer.h: ... to here, because these macros use current_buffer,
3998 and the new implementation with inline functions needs to have
3999 current_buffer in scope now, rather than later when the macros
4000 are used.
4001 (downcase, upcase1): New static inline functions.
4002 (DOWNCASE, UPCASE1): Reimplement using these functions.
4003 This avoids undefined behavior in expressions like
4004 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4005 from race conditions in accessing the global variables
4006 case_temp1 and case_temp2.
4007 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4008 * lisp.h (case_temp1, case_temp2): Remove their decls.
4009 * character.h (ASCII_CHAR_P): Move from here ...
4010 * lisp.h: ... to here, so that the inline functions mentioned
4011 above can use them.
4012
4013 * dired.c (directory_files_internal_unwind): Now static.
4014
4015 * fileio.c (file_name_as_directory, directory_file_name):
4016 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4017 Now static.
4018 (file_name_as_directory): Use const pointers when appropriate.
4019 (Fexpand_file_name): Likewise. In particular, newdir might
4020 point at constant storage, so make it a const pointer.
4021 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4022 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4023 signedness issues.
4024 (Fset_file_times, Finsert_file_contents, auto_save_error):
4025 Rename locals to avoid shadowing.
4026
4027 * minibuf.c (choose_minibuf_frame_1): Now static.
4028 (Ftry_completion, Fall_completions): Rename or remove locals
4029 to avoid shadowing.
4030
4031 * marker.c (bytepos_to_charpos): Remove; unused.
4032
4033 * lisp.h (verify_bytepos, count_markers): New decls,
4034 so that gcc does not warn that these functions aren't declared.
4035
4036 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4037 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4038 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4039 (copy_text): Remove unused local var.
4040
4041 * filelock.c (within_one_second): Now static.
4042 (lock_file_1): Rename local to avoid shadowing.
4043
4044 * buffer.c (fix_overlays_before): Mark locals as initialized.
4045 (fix_start_end_in_overlays): Likewise. This function should be
4046 simplified by using pointers-to-pointers, but that's a different
4047 matter.
4048 (switch_to_buffer_1): Now static.
4049 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4050 (report_overlay_modification): Rename locals to avoid shadowing.
4051
4052 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4053 Fix pointer signedness issue.
4054 (sys_subshell): Mark local as volatile if checking for lint,
4055 to suppress a gcc -Wclobbered warning that does not seem to be right.
4056 (MAXPATHLEN): Define only if needed.
4057
4058 * process.c (serial_open, serial_configure): Move decls from here ...
4059 * systty.h: ... to here, so that they can be checked.
4060
4061 * fns.c (get_random, seed_random): Move extern decls from here ...
4062 * lisp.h: ... to here, so that they can be checked.
4063
4064 * sysdep.c (reset_io): Now static.
4065 (wait_for_termination_signal): Remove; unused.
4066
4067 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4068 (copy_keymap_item, append_key, push_text_char_description):
4069 Now static.
4070 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4071 (DENSE_TABLE_SIZE): Remove; unused.
4072 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4073 (describe_map_tree):
4074 Rename locals to avoid shadowing.
4075
4076 * keyboard.c: Declare functions static if they are not used elsewhere.
4077 (echo_char, echo_dash, cmd_error, top_level_2):
4078 (poll_for_input, handle_async_input): Now static.
4079 (read_char, kbd_buffer_get_event, make_lispy_position):
4080 (make_lispy_event, make_lispy_movement, apply_modifiers):
4081 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4082 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4083 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4084 (read_key_sequence, read_char): Mark locals as initialized.
4085 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4086
4087 * keyboard.h (make_ctrl_char): New decl.
4088 (mark_kboards): Move decl here ...
4089 * alloc.c (mark_kboards): ... from here.
4090
4091 * lisp.h (force_auto_save_soon): New decl.
4092
4093 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4094 (DEFINE_DUMMY_FUNCTION): New macro.
4095 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4096 Use it.
4097 (main): Add casts to avoid warnings
4098 if GCC considers string literals to be constants.
4099
4100 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4101
4102 * dbusbind.c: Pointer signedness fixes.
4103 (xd_signature, xd_append_arg, xd_initialize):
4104 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4105 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4106 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4107 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4108
4109 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4110 if GCC considers string literals to be constants.
4111 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4112
4113 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4114
4115 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4116 (print_preprocess, print_object): New macro to fix last change.
4117
4118 * print.c (print_preprocess): Don't forget font objects.
4119
4120 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4121
4122 * emacs.c (USAGE3): Doc fixes.
4123
4124 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4125
4126 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4127 structure.
4128
4129 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4130
4131 * lisp.h (VWindow_system, Qfile_name_history):
4132 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4133 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4134 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4135
4136 * w32select.c: Don't #include "keyboard.h".
4137 (run_protected): Add extern declaration for waiting_for_input.
4138
4139 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4140 * w32console.c (detect_input_pending, read_input_pending)
4141 (encode_terminal_code):
4142 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4143 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4144 (w32_system_caret_y, Qfile_name_history):
4145 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4146 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4147 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4148 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4149 * w32proc.c (Qlocal, report_file_error):
4150 * w32term.c (Vwindow_system, updating_frame):
4151 * w32uniscribe.c (initialized, uniscribe_font_driver):
4152 Remove unneeded extern declarations.
4153
4154 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4155
4156 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4157
4158 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4159
4160 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4161 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4162 These macros can no longer be used for assignment.
4163
4164 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4165 Assign struct members directly, instead of using BUF_BEGV etc.
4166 (record_buffer_markers, fetch_buffer_markers): New functions for
4167 recording and fetching special buffer markers.
4168 (set_buffer_internal_1, set_buffer_temp): Use them.
4169
4170 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4171
4172 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4173
4174 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4175 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4176
4177 * xdisp.c (hscroll_window_tree):
4178 (reconsider_clip_changes): Use PT instead of BUF_PT.
4179
4180 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4181
4182 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4183 $(EMACS_ROOT)/lib/intprops.h.
4184
4185 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4186
4187 Fix more problems found by GCC 4.5.2's static checks.
4188
4189 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4190 to unsigned char * to avoid compiler diagnostic.
4191 (xg_free_frame_widgets): Make it clear that a local variable is
4192 needed only if USE_GTK_TOOLTIP.
4193 (gdk_window_get_screen): Make it clear that this macro is needed
4194 only if USE_GTK_TOOLTIP.
4195 (int_gtk_range_get_value): New function, which avoids a diagnostic
4196 from gcc -Wbad-function-cast.
4197 (xg_set_toolkit_scroll_bar_thumb): Use it.
4198 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4199 diagnostic from gcc -Wbad-function-cast.
4200 (get_utf8_string, xg_get_file_with_chooser):
4201 Rename locals to avoid shadowing.
4202 (create_dialog): Move locals to avoid shadowing.
4203
4204 * xgselect.c (xg_select): Remove unused var.
4205
4206 * image.c (four_corners_best): Mark locals as initialized.
4207 (gif_load): Initialize transparent_p to zero (Bug#8238).
4208 Mark another local as initialized.
4209 (my_png_error, my_error_exit): Mark with NO_RETURN.
4210
4211 * image.c (clear_image_cache): Now static.
4212 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4213 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4214 (x_edge_detection): Remove unnecessary cast that
4215 gcc -Wbad-function-cast diagnoses.
4216 (gif_load): Fix pointer signedness.
4217 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4218 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4219
4220 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4221
4222 Improve quality of tests for time stamp overflow.
4223 For example, without this patch (encode-time 0 0 0 1 1
4224 1152921504606846976) returns the obviously-bogus value (-948597
4225 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4226 reports time overflow. See
4227 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4228 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4229 * editfns.c: Include limits.h and intprops.h.
4230 (TIME_T_MIN, TIME_T_MAX): New macros.
4231 (time_overflow): Move earlier, to before first use.
4232 (hi_time, lo_time): New functions, for an accurate test for
4233 out-of-range times.
4234 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4235 (Fget_internal_run_time): Don't assume time_t fits in int.
4236 (make_time): Use list2 instead of Fcons twice.
4237 (Fdecode_time): More accurate test for out-of-range times.
4238 (check_tm_member): New function.
4239 (Fencode_time): Use it, to test for out-of-range times.
4240 (lisp_time_argument): Don't rely on undefined left-shift and
4241 right-shift behavior when checking for time stamp overflow.
4242
4243 * editfns.c (time_overflow): New function, refactoring common code.
4244 (Fformat_time_string, Fdecode_time, Fencode_time):
4245 (Fcurrent_time_string): Use it.
4246
4247 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4248 * dired.c (make_time): Move to ...
4249 * editfns.c (make_time): ... here.
4250 * systime.h: Note the move.
4251
4252 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4253
4254 * fringe.c (update_window_fringes): Remove unused variables.
4255
4256 * unexmacosx.c (copy_data_segment): Also copy __got section.
4257 (Bug#8223)
4258
4259 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4260
4261 * termcap.c [MSDOS]: Include "msdos.h".
4262 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4263 Constify `char *' arguments and their references according to
4264 prototypes in tparam.h.
4265
4266 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4267
4268 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4269 Adapt all references accordingly.
4270
4271 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4272
4273 2011-03-11 Tom Tromey <tromey@redhat.com>
4274
4275 * buffer.c (syms_of_buffer): Remove obsolete comment.
4276
4277 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4278
4279 * termhooks.h (encode_terminal_code): Declare prototype.
4280
4281 * msdos.c (encode_terminal_code): Don't declare prototype.
4282
4283 * term.c (encode_terminal_code): Now external again, used by
4284 w32console.c and msdos.c.
4285
4286 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4287 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4288
4289 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4290
4291 Fix some minor problems found by GCC 4.5.2's static checks.
4292
4293 * fringe.c (update_window_fringes): Mark locals as initialized
4294 (Bug#8227).
4295 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4296
4297 * alloc.c (mark_fringe_data): Move decl from here ...
4298 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4299 to check its interface.
4300 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4301
4302 * fontset.c (free_realized_fontset): Now static.
4303 (Fset_fontset_font): Rename local to avoid shadowing.
4304 (fontset_font): Mark local as initialized.
4305 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4306
4307 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4308
4309 * xselect.c (x_disown_buffer_selections): Remove; not used.
4310 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4311 (x_own_selection, Fx_disown_selection_internal): Rename locals
4312 to avoid shadowing.
4313 (x_handle_dnd_message): Remove local to avoid shadowing.
4314
4315 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4316 so that the caller can use some name other than gcpro1.
4317 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4318 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4319 (Fx_backspace_delete_keys_p):
4320 Use them to avoid shadowing, and rename vars to avoid shadowing.
4321 (x_decode_color, x_set_name, x_window): Now static.
4322 (Fx_create_frame): Add braces to silence GCC warning.
4323 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4324 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4325 Remove unused locals.
4326 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4327 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4328 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4329 macros.
4330
4331 * xterm.h (x_mouse_leave): New decl.
4332
4333 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4334 Remove unused functions.
4335 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4336 (x_calc_absolute_position): Now static.
4337 (XTread_socket): Don't define label "out" unless it's used.
4338 Don't declare local "event" unless it's used.
4339 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4340 unless they are used.
4341 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4342 (x_fatal_error_signal): Remove; not used.
4343 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4344 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4345 (x_error_catcher, x_connection_closed, x_error_handler):
4346 (x_error_quitter, xembed_send_message, x_iconify_frame):
4347 (my_log_handler): Rename locals to avoid shadowing.
4348 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4349 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4350
4351 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4352 Rename or move locals to avoid shadowing.
4353 (tty_defined_color, merge_face_heights): Now static.
4354 (free_realized_faces_for_fontset): Remove; not used.
4355 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4356 does not deduce is never used uninitialized.
4357 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4358 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4359
4360 * terminal.c (store_terminal_param): Now static.
4361
4362 * xmenu.c (menu_highlight_callback): Now static.
4363 (set_frame_menubar): Remove unused local.
4364 (xmenu_show): Rename parameter to avoid shadowing.
4365 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4366 since they might point to immutable storage.
4367 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4368 since it's unused otherwise.
4369
4370 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4371 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4372 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4373 avoids a gcc -Wuninitialized diagnostic.
4374 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4375 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4376 does not deduce are never used uninitialized.
4377
4378 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4379
4380 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4381 * window.c (window_loop, size_window):
4382 (run_window_configuration_change_hook, enlarge_window): Likewise.
4383
4384 * window.c (display_buffer): Now static.
4385 (size_window): Mark variables that gcc -Wuninitialized
4386 does not deduce are never used uninitialized.
4387 * window.h (check_all_windows): New decl, to forestall
4388 gcc -Wmissing-prototypes diagnostic.
4389 * dispextern.h (bidi_dump_cached_states): Likewise.
4390
4391 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4392 shadowing.
4393 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4394 Include <limits.h>.
4395 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4396 and to avoid gcc -Wuninitialized warning.
4397 (load_charset_map): Mark variables that gcc -Wuninitialized
4398 does not deduce are never used uninitialized.
4399 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4400
4401 * coding.c (coding_set_source, coding_set_destination):
4402 Use "else { /* comment */ }" rather than "else /* comment */;"
4403 for clarity, and to avoid gcc -Wempty-body warning.
4404 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4405 a block, when the outer 'i' will do.
4406 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4407 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4408 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4409 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4410 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4411 Rename locals to avoid shadowing.
4412 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4413 * coding.c (emacs_mule_char, encode_invocation_designation):
4414 Now static, since they're not used elsewhere.
4415 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4416 (decode_coding_object, encode_coding_object, detect_coding_system):
4417 (decode_coding_emacs_mule): Mark variables that gcc
4418 -Wuninitialized does not deduce are never used uninitialized.
4419 (detect_coding_iso_2022): Initialize a local variable that might
4420 be used uninitialized. Leave a FIXME because it's not clear that
4421 this initialization is needed. (Bug#8211)
4422 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4423 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4424 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4425 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4426 Remove unused macros.
4427
4428 * category.c (hash_get_category_set): Remove unused local var.
4429 (copy_category_table): Now static, since it's not used elsewhere.
4430 * character.c (string_count_byte8): Likewise.
4431
4432 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4433 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4434
4435 * chartab.c (copy_sub_char_table): Now static, since it's not used
4436 elsewhere.
4437 (sub_char_table_ref_and_range, char_table_ref_and_range):
4438 Rename locals to avoid shadowing.
4439 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4440
4441 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4442 (BIDI_BOB): Remove unused macro.
4443
4444 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4445 deduce are never used uninitialized.
4446 * term.c (encode_terminal_code): Likewise.
4447
4448 * term.c (encode_terminal_code): Now static. Remove unused local.
4449
4450 * tparam.h: New file.
4451 * term.c, tparam.h: Include it.
4452 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4453 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4454 Move these decls to tparam.h, and make them agree with what
4455 is actually in tparam.c. The previous trick of using incompatible
4456 decls in different modules does not conform to the C standard.
4457 All callers of tparam changed to use tparam's actual API.
4458 * tparam.c (tparam1, tparam, tgoto):
4459 Use const pointers where appropriate.
4460
4461 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4462 * cm.h (struct cm): Likewise.
4463 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4464 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4465 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4466 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4467 (turn_on_face, init_tty): Likewise.
4468 * termchar.h (struct tty_display_info): Likewise.
4469
4470 * term.c (term_mouse_position): Rename local to avoid shadowing.
4471
4472 * alloc.c (mark_ttys): Move decl from here ...
4473 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4474
4475 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4476
4477 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4478
4479 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4480
4481 * search.c (compile_pattern_1): Remove argument regp, unused since
4482 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4483 (compile_pattern): Don't pass it.
4484
4485 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4486
4487 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4488 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4489 for ! HAVE_GTK3.
4490 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4491
4492 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4493
4494 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4495 gdk_window_get_screen, gdk_window_get_geometry,
4496 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4497 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4498 (xg_get_pixbuf_from_pixmap): New function.
4499 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4500 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4501 Call xg_get_pixbuf_from_pixmap instead of
4502 gdk_pixbuf_get_from_drawable.
4503 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4504 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4505 (xg_check_special_colors): Use GtkStyleContext and its functions
4506 for HAVE_GTK3.
4507 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4508 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4509 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4510 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4511 Call gtk_widget_get_preferred_size.
4512 (xg_frame_resized): gdk_window_get_geometry only takes 5
4513 parameters.
4514 (xg_win_to_widget, xg_event_is_for_menubar):
4515 Call gdk_x11_window_lookup_for_display.
4516 (xg_set_widget_bg): New function.
4517 (delete_cb): New function.
4518 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4519 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4520 (xg_set_background_color): Call xg_set_widget_bg.
4521 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4522 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4523 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4524 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4525 if ! HAVE_GTK3.
4526 (update_frame_tool_bar): Call gtk_widget_hide.
4527 (xg_initialize): Use GDK_KEY_g.
4528
4529 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4530 if ! HAVE_GTK3
4531 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4532
4533 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4534 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4535 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4536
4537 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4538
4539 * w32xfns.c (select_palette): Check success of RealizePalette against
4540 GDI_ERROR, not zero.
4541
4542 See ChangeLog.11 for earlier changes.
4543
4544 ;; Local Variables:
4545 ;; coding: utf-8
4546 ;; End:
4547
4548 Copyright (C) 2011 Free Software Foundation, Inc.
4549
4550 This file is part of GNU Emacs.
4551
4552 GNU Emacs is free software: you can redistribute it and/or modify
4553 it under the terms of the GNU General Public License as published by
4554 the Free Software Foundation, either version 3 of the License, or
4555 (at your option) any later version.
4556
4557 GNU Emacs is distributed in the hope that it will be useful,
4558 but WITHOUT ANY WARRANTY; without even the implied warranty of
4559 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4560 GNU General Public License for more details.
4561
4562 You should have received a copy of the GNU General Public License
4563 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.