1 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3 * unexaix.c: Port to more-recent AIX compilers.
4 (report_error, report_error_1, make_hdr, copy_sym)
5 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
6 Make arguments const char *, not char *, to avoid violations of C
7 standard and to fix some AIX warnings reported by Gilles Pion.
9 2012-05-14 Eli Zaretskii <eliz@gnu.org>
11 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
12 already have overlays loaded.
13 (handle_single_display_spec): Before returning without displaying
14 fringe bitmap, synchronize the bidi iterator with the main display
15 iterator, by calling iterate_out_of_display_property.
16 (iterate_out_of_display_property): Detect buffer iteration by
17 testing that it->string is a Lisp string.
18 (get_next_display_element): When the current object is exhausted,
19 and there's something on it->stack, call set_iterator_to_next to
20 proceed with what's on the stack, instead of returning zero.
21 (set_iterator_to_next): If called at the end of a Lisp string,
22 proceed to consider_string_end without incrementing string
23 position. Don't increment display vector index past the end of
24 the display vector. (Bug#11417)
25 (pos_visible_p): Don't report a position visible when move_it_to
26 stopped at the last line of window, which happens to be scanned
27 backwards by the bidi iteration. (Bug#11464)
29 2012-05-14 Eli Zaretskii <eliz@gnu.org>
31 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
32 and right-margin display specs even if the spec is invalid or we
33 are on a TTY, and thus unable to display on the fringes. That's
34 because the text with the property will not be displayed anyway,
35 so we need to signal to the caller that this is a "replacing"
36 display spec. This fixes display when the spec is invalid or we
39 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
41 * unexaix.c (make_hdr): Fix typo in prototype.
42 This bug broke the build on AIX. Problem reported by Gilles Pion.
44 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
46 * keyboard.c (kbd_buffer_get_event): Read special events also in
47 batch mode. (Bug#11415)
49 2012-05-12 Glenn Morris <rgm@gnu.org>
51 * ns.mk: Update for ns_appbindir no longer having trailing "/".
53 2012-05-12 Eli Zaretskii <eliz@gnu.org>
55 * lisp.mk (lisp): Add newcomment.elc.
57 2012-05-12 Glenn Morris <rgm@gnu.org>
59 * Makefile.in (MKDIR_P): New, set by configure.
60 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
62 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
64 Remove unused function hourglass_started.
65 * dispextern.h (hourglass_started):
66 * w32fns.c (hourglass_started):
67 * xdisp.c (hourglass_started): Remove.
69 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
71 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
74 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
76 * xgselect.c (xg_select): Put maxfds+1 into a var.
77 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
79 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
81 2012-05-10 Dave Abrahams <dave@boostpro.com>
83 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
84 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
86 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
88 * dbusbind.c (xd_registered_buses): New internal Lisp object.
89 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
90 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
91 Initialize xd_registered_buses.
93 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
95 Untag more efficiently if USE_LSB_TAG.
96 This is based on a proposal by YAMAMOTO Mitsuharu in
97 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
98 For an admittedly artificial (nth 8000 longlist) benchmark on
99 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
100 Emacs's overall text size by 1%.
101 * lisp.h (XUNTAG): New macro.
102 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
103 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
104 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
105 * eval.c (Fautoload):
106 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
107 * frame.h (XFRAME): Use XUNTAG.
109 Port recent dbusbind.c changes to 32-bit --with-wide-int.
110 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
111 Remove unportable assumptions about print widths of types like
113 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
114 intptr_t when converting between pointer and integer, to avoid GCC
115 warnings about wrong width.
117 2012-05-09 Eli Zaretskii <eliz@gnu.org>
119 * w32proc.c (new_child): Force Windows to reserve only 64KB of
120 stack for each reader_thread, instead of defaulting to 8MB
121 determined by the linker. This avoids failures in creating
122 subprocesses on Windows 7, see the discussion in this thread:
123 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
125 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
127 Fix up display of the *Minibuf-0* buffer in the mini window.
128 * keyboard.c (read_char): Don't clear the echo area if there's no
130 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
131 contents of *Minibuf-0*) if there's no message displayed in its stead.
133 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
135 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
138 2012-05-06 Chong Yidong <cyd@gnu.org>
140 * lisp.mk (lisp): Update.
142 2012-05-05 Jim Meyering <meyering@redhat.com>
144 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
146 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
148 * data.c (PUT_ERROR): New macro.
149 (syms_of_data): Use it. Add new error type `user-error'.
150 * undo.c (user_error): New function.
151 (Fprimitive_undo): Use it.
152 * print.c (print_error_message): Adjust print style for `user-error'.
153 * keyboard.c (user_error): New function.
154 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
156 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
158 Do not limit current-time-string to years 1000..9999.
159 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
160 (Fcurrent_time_string): Support any year that is supported by the
161 underlying localtime representation. Don't use asctime, as it
162 has undefined behavior for years outside the range -999..9999.
164 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
166 Fix race conditions involving setenv, gmtime, localtime, asctime.
167 Without this fix, interrupts could mess up code that uses these
168 nonreentrant functions, since setting TZ invalidates existing
169 tm_zone or tzname values, and since most of these functions return
170 pointers to static storage.
171 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
172 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
173 Grow the critical sections to include not just invoking
174 localtime/gmtime, but also accessing these functions' results
175 including their tm_zone values if any, and any related TZ setting.
176 (format_time_string): Last arg is now struct tm *, not struct tm **,
177 so that the struct tm is saved in the critical section.
178 All callers changed. Simplify allocation of initial buffer, partly
179 motivated by the fact that memory allocation needs to be outside
180 the critical section.
182 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
184 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
187 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
188 Remove duplicated buffer name initialization.
190 2012-05-02 Jim Meyering <jim@meyering.net>
192 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
194 * xfns.c (x_window): Use xstrdup (Bug#11375).
196 2012-05-02 Eli Zaretskii <eliz@gnu.org>
198 * xdisp.c (pos_visible_p): If already at a newline from the
199 display string before the 'while' loop, don't walk back the glyphs
200 from it3.glyph_row. Solves assertion violation when the display
201 string begins with a newline (egg.el). (Bug#11367)
203 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
205 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
208 2012-05-01 Glenn Morris <rgm@gnu.org>
210 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
211 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
212 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
213 All were removed before 23.1.
215 * dispnew.c: Remove HAVE_LIBNCURSES test;
216 it is always true on relevant platforms.
218 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
219 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
221 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
223 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
225 * .gdbinit (xpr): Remove checks for no longer existing misc types.
226 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
229 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
231 Do not avoid creating empty evaporating overlays (Bug#9642).
232 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
233 That is, do not delete an evaporating overlay if it becomes
234 empty after its bounds are adjusted to fit within its buffer.
235 This fix caused other problems, and I'm reverting it until we get
236 to the bottom of them.
238 2012-04-27 Chong Yidong <cyd@gnu.org>
240 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
242 2012-04-27 Eli Zaretskii <eliz@gnu.org>
244 * xdisp.c (pos_visible_p): If the window start position is beyond
245 ZV, start the display from buffer beginning. Prevents assertion
246 violation in init_iterator when the minibuffer window is scrolled
249 * window.c (window_scroll_pixel_based): Likewise.
251 2012-04-27 Chong Yidong <cyd@gnu.org>
253 * keymap.c (where_is_internal): Doc fix (Bug#10872).
255 2012-04-27 Glenn Morris <rgm@gnu.org>
257 * fileio.c (Fcopy_file, Fset_file_selinux_context):
258 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
260 2012-04-27 Eli Zaretskii <eliz@gnu.org>
262 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
263 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
265 2012-04-26 Eli Zaretskii <eliz@gnu.org>
267 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
268 display element, check also the underlying string or buffer
269 character. (Bug#11341)
271 * w32menu.c: Include w32heap.h.
272 (add_menu_item): If the call to AppendMenuW (via
273 unicode_append_menu) fails, disable Unicode menus only if we are
274 running on Windows 9X/Me.
276 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
278 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
279 (xgetint): Add missing shift for LSB tags.
281 2012-04-24 Martin Rudalics <rudalics@gmx.at>
283 * keyboard.c (read_char): Don't wipe echo area for select window
284 events: These might get delayed via `mouse-autoselect-window'
287 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
289 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
290 manipulation of :loaded-from data.
292 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
294 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
295 now a cons (bug#11311).
297 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
299 Do not create empty overlays with the evaporate property (Bug#9642).
300 * buffer.c (Fmove_overlay): Delete an evaporating overlay
301 if it becomes empty after its bounds are adjusted to fit within
302 its buffer. Without this fix, in a nonempty buffer (let ((o
303 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
304 yields an empty overlay that has the evaporate property, which is
305 not supposed to happen.
307 Fix minor GTK3 problems found by static checking.
308 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
309 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
310 (struct _EmacsFixedClass, emacs_fixed_get_type):
311 Move decls here from emacsgtkfixed.h, since they needn't be public.
312 (emacs_fixed_get_type): Now static.
313 (emacs_fixed_class_init): Omit unused local.
314 (emacs_fixed_child_type): Remove; unused.
315 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
316 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
317 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
318 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
319 (EMACS_FIXED_GET_CLASS): Remove; unused.
320 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
322 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
323 Problem reported by Juanma Barranquero for Windows -Wunused-function.
325 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
327 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
328 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
329 (__malloc_size_t, __malloc_ptrdiff_t):
330 Remove. All uses removed, replaced by the definiens if needed,
331 since we can assume C89 or better now.
332 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
333 (protect_malloc_state, align, get_contiguous_space)
334 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
335 (malloc_atfork_handler_child, malloc_enable_thread)
336 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
337 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
338 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
339 (special_realloc, _realloc_internal_nolock, _realloc_internal)
340 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
341 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
342 Define using prototypes, not old style.
343 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
344 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
345 (align): Don't assume that signed integer overflow wraps around.
346 Omit unused local var.
347 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
348 (_free_internal_nolock, memalign, mallochook, reallochook):
349 Omit no-longer-needed casts.
350 (valloc): Use getpagesize, not __getpagesize.
351 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
352 (struct hdr): The 'magic' member is now size_t, not unsigned long.
354 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
356 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
358 Move functions from C to Lisp. Make non-blocking method calls
359 the default. Implement further D-Bus standard interfaces.
361 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
362 (QCdbus_request_name_allow_replacement)
363 (QCdbus_request_name_replace_existing)
364 (QCdbus_request_name_do_not_queue)
365 (QCdbus_request_name_reply_primary_owner)
366 (QCdbus_request_name_reply_in_queue)
367 (QCdbus_request_name_reply_exists)
368 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
369 (QCdbus_registered_serial, QCdbus_registered_method)
370 (QCdbus_registered_signal): New Lisp objects.
371 (XD_DEBUG_MESSAGE): Use sizeof.
372 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
373 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
374 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
375 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
376 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
377 (xd_signature, xd_append_arg): Allow float for integer types.
378 (xd_get_connection_references): New function.
379 (xd_get_connection_address): Rename from xd_initialize.
380 Return cached address.
381 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
382 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
384 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
385 Return number of refcounts.
386 (Fdbus_get_unique_name): Make stronger parameter check.
387 (Fdbus_message_internal): New defun.
388 (Fdbus_call_method, Fdbus_call_method_asynchronously)
389 (Fdbus_method_return_internal, Fdbus_method_error_internal)
390 (Fdbus_send_signal, Fdbus_register_service)
391 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
392 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
393 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
394 (Vdbus_compiled_version, Vdbus_runtime_version)
395 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
396 (Vdbus_message_type_method_return, Vdbus_message_type_error)
397 (Vdbus_message_type_signal): New defvars.
398 (Vdbus_registered_buses, Vdbus_registered_objects_table):
401 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
403 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
404 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
405 Do not assume ptrdiff_t is the same width as 'int'.
407 * alloc.c: Handle unusual debugging option combinations.
408 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
409 since the two debugging options are incompatible.
410 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
412 (mem_init, mem_insert, mem_insert_fixup):
413 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
414 (NEED_MEM_INSERT): Remove; no longer needed.
416 2012-04-22 Leo Liu <sdl.web@gmail.com>
418 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
420 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
422 * sysdep.c [__FreeBSD__]: Minor cleanups.
423 (list_system_processes, system_process_attributes) [__FreeBSD__]:
424 Use Emacs indenting style more consistently. Avoid some casts.
425 Use 'double' consistently rather than mixing 'float' and 'double'.
427 2012-04-21 Eduard Wiebe <usenet@pusto.de>
429 * sysdep.c (list_system_processes, system_process_attributes):
430 Add implementation for FreeBSD (Bug#5243).
432 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
434 * lisp.mk (lisp): Update.
436 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
438 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
439 It is never used otherwise.
441 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
443 * print.c (print_preprocess): Only check print_depth if print-circle
445 (print_object): Check for cycles even when print-circle is nil and
446 print-gensym is t, but only check print_depth if print-circle is nil.
448 2012-04-20 Chong Yidong <cyd@gnu.org>
450 * process.c (wait_reading_process_output): If EIO occurs on a pty,
451 set the status to "failed" and ensure that sentinel is run.
453 2012-04-20 Glenn Morris <rgm@gnu.org>
455 * process.c (Fset_process_inherit_coding_system_flag)
456 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
457 (Fmake_network_process, Fmake_serial_process): Doc fix.
459 2012-04-20 Eli Zaretskii <eliz@gnu.org>
461 * xdisp.c (string_buffer_position_lim): Limit starting position to
463 (set_cursor_from_row): If called for a mode-line or header-line
464 row, return zero immediately.
465 (try_cursor_movement): If inside continuation line, don't back up
466 farther than the first row after the header line, if any.
467 Don't consider the header-line row as "partially visible", even if
468 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
470 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
472 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
475 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
476 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
478 configure: new option --enable-gcc-warnings (Bug#11207)
479 * Makefile.in (C_WARNINGS_SWITCH): Remove.
480 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
481 (ALL_CFLAGS): Use new macros rather than old.
482 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
483 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
484 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
485 -Wunused-result, -Wunused-variable. This should go away once
486 the Emacs and Gnulib regex code is merged.
487 (xmalloc, xrealloc): Now static.
489 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
491 * dired.c (Fsystem_groups): Remove unused local.
493 2012-04-17 Glenn Morris <rgm@gnu.org>
495 * dired.c (Fsystem_users): Doc fix.
497 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
499 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
500 (syms_of_dired): Add them.
502 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
504 Fix minor alloc.c problems found by static checking.
505 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
506 New extern decls, to avoid calling undeclared functions.
507 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
508 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
509 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
510 (NEED_MEM_INSERT): New macro.
511 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
512 Remove one incorrect comment and fix another.
514 Fix minor ralloc.c problems found by static checking.
515 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
516 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
517 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
518 (r_alloc_sbrk): Now static.
520 Improve ralloc.c interface checking.
521 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
522 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
523 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
524 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
525 [REL_ALLOC]: ... to here, to check interface.
526 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
527 Remove decls. This fixes an "It stinks!".
529 * alloc.c (which_symbols): Fix alignment issue / type clash.
531 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
533 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
534 (struct Lisp_Misc_Any): Likewise.
535 (struct Lisp_Free): Likewise.
536 * alloc.c (union aligned_Lisp_Symbol): Define.
537 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
538 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
539 (union aligned_Lisp_Misc): Define.
540 (MARKER_BLOCK_SIZE, struct marker_block): Use union
541 aligned_Lisp_Misc instead of union Lisp_Misc.
542 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
544 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
546 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
547 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
548 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
549 * s/netbsd.h, s/sol2-6.h:
550 Remove definition of GC_MARK_STACK, since the default now works.
551 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
552 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
553 no longer the default.
554 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
556 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
558 * lread.c (lisp_file_lexically_bound_p):
559 Fix hang at ";-*-\n" (bug#11238).
561 2012-04-14 Eli Zaretskii <eliz@gnu.org>
563 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
564 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
566 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
568 * nsterm.m (constrainFrameRect): Always constrain when there is only
569 one screen (Bug#10962).
571 2012-04-13 Ken Brown <kbrown@cornell.edu>
573 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
575 2012-04-13 Reuben Thomas <rrt@sc3d.org>
577 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
579 2012-04-11 Daniel Colascione <dancol@dancol.org>
581 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
582 against is gone. It's better to use vfork now so that when Cygwin
583 gains a new, working vfork, we use it automatically (bug#10398).
585 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
587 * window.c (save_window_save): Obey window-point-insertion-type.
589 2012-04-11 Glenn Morris <rgm@gnu.org>
591 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
593 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
595 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
597 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
599 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
600 (force_quit_count): New var.
601 (handle_interrupt): Use it.
603 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
605 * w32.c (w32_delayed_load): Record the full path of the library
606 being loaded (bug#10424).
608 2012-04-09 Glenn Morris <rgm@gnu.org>
610 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
611 not just in the obarray, before snarfing them. (Bug#11036)
613 * Makefile.in ($(leimdir)/leim-list.el):
614 Pass EMACS rather than BUILT_EMACS.
616 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
618 * process.c (make_process):
619 * process.h: Add integer `gnutls_handshakes_tried' member to
622 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
623 Add convenience `GNUTLS_LOG2i' macro.
625 * gnutls.c (gnutls_log_function2i): Convenience log function.
626 (emacs_gnutls_read): Use new log functions,
627 `gnutls_handshakes_tried' process member, and
628 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
629 attempts per process (connection).
631 2012-04-09 Chong Yidong <cyd@gnu.org>
633 * eval.c (Fuser_variable_p, user_variable_p_eh)
634 (lisp_indirect_variable): Functions deleted.
635 (Fdefvar): Caller changed.
637 * callint.c (Finteractive, Fcall_interactively):
638 * minibuf.c (Fread_variable): Callers changed.
640 2012-04-09 Eli Zaretskii <eliz@gnu.org>
642 * xdisp.c (set_cursor_from_row): If the display string appears in
643 the buffer at position that is closer to point than the position
644 after the display string, display the cursor on the first glyph of
645 the display string. Fixes cursor display when a 'display' text
646 property immediately follows invisible text. (Bug#11094)
648 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
650 composite.c: use 'double' consistently
651 * composite.c (get_composition_id): Use 'double' consistently
652 instead of converting 'float' to 'double' and vice versa; this is
653 easier to understand and avoids a GCC warning.
655 2012-04-09 Glenn Morris <rgm@gnu.org>
657 * Makefile.in: Generate leim-list with bootstrap-emacs, in
658 preparation for dumping it with emacs. (Bug#4789)
659 (leimdir): New variable.
660 ($(leimdir)/leim-list.el): New rule.
661 (emacs$(EXEEXT)): Depend on leim-list.el.
663 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
664 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
665 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
667 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
669 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
672 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
674 * xml.c (init_libxml2_functions) [WINDOWSNT]:
675 Remove unused local variable.
677 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
679 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
680 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
681 (mark_memory): Mark Lisp_Objects only if pointers might hide in
682 objects, as mark_maybe_pointer will catch them otherwise.
683 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
684 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
686 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
688 Fix typo that broke non-Windows builds.
689 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
691 2012-04-07 Eli Zaretskii <eliz@gnu.org>
693 Support building on MS-Windows with libxml2.
695 * makefile.w32-in (OBJ2): Add xml.$(O).
696 (GLOBAL_SOURCES): Add xml.c.
697 ($(BLD)/xml.$(O)): New dependency list.
699 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
700 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
701 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
702 [!WINDOWSNT]: New macros.
703 (init_libxml2_functions, libxml2_loaded_p): New functions.
704 (parse_region): Call fn_xmlCheckVersion instead of using the macro
705 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
706 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
707 Calls xmlCleanupParser only if libxml2 was loaded (or statically
709 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
710 Call init_libxml2_functions before calling libxml2 functions.
711 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
713 * emacs.c: Don't include libxml/parser.h.
714 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
715 xmlCleanupParser directly.
717 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
719 2012-04-07 Eli Zaretskii <eliz@gnu.org>
721 * indent.c (Fvertical_motion): If there is a display string at
722 point, use it.vpos to compute how many lines to backtrack after
723 move_it_to point. (Bug#11133)
725 2012-04-06 Eli Zaretskii <eliz@gnu.org>
727 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
728 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
729 about subtle differences between FETCH_CHAR* and STRING_CHAR*
730 macros related to unification of CJK characters. For the details,
731 see the discussion following the message here:
732 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
734 2012-04-04 Chong Yidong <cyd@gnu.org>
736 * keyboard.c (Vdelayed_warnings_list): Doc fix.
738 2012-04-01 Eli Zaretskii <eliz@gnu.org>
740 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
741 instead of alloca. (Bug#11138)
743 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
745 * w32menu.c (is_simple_dialog): Properly check lisp types.
748 2012-03-31 Eli Zaretskii <eliz@gnu.org>
750 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
751 position we get to after a call to move_it_to fails the
752 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
753 only if we wind up in a string from display property. (Bug#11063)
755 * window.c (Fdelete_other_windows_internal): Invalidate the row
756 and column information about mouse highlight, so that redisplay
757 restores it after reallocating the glyph matrices. (Bug#7464)
759 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
760 string comes from a `display' text property, use the buffer
761 position of that property as if we actually saw that position in
763 (move_it_by_lines): Remove the assertion that
764 "it->current_x == 0 && it->hpos == 0" which can be legitimately
765 violated when there's a before-string at the beginning of a line.
768 2012-03-30 Eli Zaretskii <eliz@gnu.org>
770 * xdisp.c (append_space_for_newline): If the default face was
771 remapped, use the remapped face for the appended newline.
772 (extend_face_to_end_of_line): Use the remapped default face for
773 extending the face to the end of the line.
774 (display_line): Call extend_face_to_end_of_line when the default
775 face was remapped. (Bug#11068)
777 2012-03-29 Eli Zaretskii <eliz@gnu.org>
779 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
781 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
783 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
785 2012-03-27 Glenn Morris <rgm@gnu.org>
787 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
790 2012-03-26 Kenichi Handa <handa@m17n.org>
792 * dispextern.h (struct glyph): Fix previous change. Change the
793 bit length of glyphless.ch to 25 (Bug#11082).
795 2012-03-26 Chong Yidong <cyd@gnu.org>
797 * keyboard.c (Vselection_inhibit_update_commands): New variable.
798 (command_loop_1): Use it; inhibit selection update for
799 handle-select-window too (Bug#8996).
801 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
803 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
805 2012-03-25 Kenichi Handa <handa@m17n.org>
807 * dispextern.h (struct glyph): Change the bit length of
808 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
810 2012-03-24 Eli Zaretskii <eliz@gnu.org>
812 * s/ms-w32.h (tzname): Include time.h before redirecting to
813 _tzname. Fixes the MSVC build. (Bug#9960)
815 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
817 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
820 * xterm.c (XTread_socket): Only modify handling_signal if
821 !SYNC_INPUT. (Bug#11080)
823 2012-03-23 Eli Zaretskii <eliz@gnu.org>
825 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
826 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
827 when fetching a multibyte character consumes more bytes than
828 CHAR_BYTES returns, due to unification of CJK characters in
829 string_char. (Bug#11073)
831 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
833 * process.c (wait_reading_process_output): Handle pty disconnect
834 by refraining from sending oneself a SIGCHLD (bug#10933).
836 2012-03-22 Chong Yidong <cyd@gnu.org>
838 * dispextern.h (struct it): New member string_from_prefix_prop_p.
840 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
841 Mark string as coming from a prefix property.
842 (handle_face_prop): Use default face for prefix strings (Bug#4281).
843 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
845 2012-03-21 Chong Yidong <cyd@gnu.org>
847 * xfaces.c (Vface_remapping_alist): Doc fix.
849 2012-03-20 Eli Zaretskii <eliz@gnu.org>
851 * w32proc.c (Fw32_set_console_codepage)
852 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
855 2012-03-20 Chong Yidong <cyd@gnu.org>
857 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
858 to reflect default non-nil value of redisplay-dont-pause.
860 2012-03-19 Kenichi Handa <handa@m17n.org>
862 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
863 it fit in a valid range (Bug#11003).
865 2012-03-18 Eli Zaretskii <eliz@gnu.org>
867 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
868 that is not from display property, accept the row as a "cursor
869 row" if one of the string's character has a non-nil `cursor'
870 property. Fixes cursor positioning when there are newlines in
871 overlay strings, e.g. in icomplete.el. (Bug#11035)
873 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
875 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
877 2012-03-12 Chong Yidong <cyd@gnu.org>
879 * eval.c (inhibit_lisp_code): Rename from
880 inhibit_window_configuration_change_hook; move from window.c.
882 * xfns.c (unwind_create_frame_1, Fx_create_frame):
883 * window.c (run_window_configuration_change_hook)
884 (syms_of_window): Callers changed.
886 2012-03-11 Chong Yidong <cyd@gnu.org>
888 * keymap.c (Fkey_description): Doc fix (Bug#9700).
890 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
892 2012-03-10 Chong Yidong <cyd@gnu.org>
894 * frame.c (other_visible_frames): Don't assume the selected frame
895 is visible (Bug#10955).
897 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
899 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
901 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
903 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
904 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
907 2012-03-03 Glenn Morris <rgm@gnu.org>
909 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
911 2012-03-02 Eli Zaretskii <eliz@gnu.org>
913 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
914 position past the first glyph_row that ends at ZV. (Bug#10902)
915 (redisplay_window, next_element_from_string): Fix typos in
917 (redisplay_window): Pass to move_it_vertically the margin in
918 pixels, not in screen lines.
920 2012-03-02 Glenn Morris <rgm@gnu.org>
922 * buffer.c (buffer-list-update-hook): Doc fix.
924 2012-02-29 Eli Zaretskii <eliz@gnu.org>
926 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
927 push_it before setting up the iterator for the first overlay
928 string, even if we have an empty string loaded.
929 (next_overlay_string): If there's an empty string on the iterator
930 stack, pop the stack. (Bug#10903)
932 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
934 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
935 Suggested by Stefan Monnier in
936 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
937 * alloc.c (widen_to_Lisp_Object): New static function.
938 (mark_memory): Also mark Lisp_Objects by fetching pointer words
939 and widening them to Lisp_Objects. This would work even if
940 USE_LSB_TAG is defined and wide integers are used, which might
941 happen in a future version of Emacs.
943 2012-02-25 Chong Yidong <cyd@gnu.org>
945 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
948 * xselect.c (Fx_selection_exists_p): Doc fix.
949 (x_clipboard_manager_save_all): Print an informative message
950 before saving to clipboard manager.
952 2012-02-24 Chong Yidong <cyd@gnu.org>
954 * keyboard.c (process_special_events): Handle all X selection
955 requests in kbd_buffer, not just the next one (Bug#8869).
957 2012-02-23 Chong Yidong <cyd@gnu.org>
959 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
960 call when setting menu-bar-lines and tool-bar-lines parameters.
961 (unwind_create_frame_1): New helper function.
963 * window.c (inhibit_window_configuration_change_hook): New var.
964 (run_window_configuration_change_hook): Obey it.
965 (syms_of_window): Initialize it.
967 2012-02-22 Chong Yidong <cyd@gnu.org>
969 * xterm.c (x_draw_image_relief): Add missing type check for
970 Vtool_bar_button_margin (Bug#10743).
972 2012-02-21 Chong Yidong <cyd@gnu.org>
974 * fileio.c (Vfile_name_handler_alist): Doc fix.
976 * buffer.c (Fget_file_buffer): Protect against invalid file
977 handler return value.
979 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
981 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
982 when computing $valmask.
984 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
985 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
986 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
987 It's useless in that case, and it can cause problems on hosts
988 that allocate halves of EMACS_INT values separately.
989 Reported by Dan Horák. Diagnosed by Andreas Schwab in
990 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
991 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
992 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
993 it avoids undefined behavior on hosts where shifting right by more
994 than the word width has undefined behavior.
996 2012-02-19 Chong Yidong <cyd@gnu.org>
998 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
999 (Funhandled_file_name_directory, Ffile_name_as_directory)
1000 (Fdirectory_file_name, Fexpand_file_name)
1001 (Fsubstitute_in_file_name): Protect against invalid file handler
1002 return values (Bug#10845).
1004 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1006 * .gdbinit (pitx): Fix incorrect references to fields of the
1009 2012-02-17 Chong Yidong <cyd@gnu.org>
1011 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1013 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1015 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1016 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1018 2012-02-15 Chong Yidong <cyd@gnu.org>
1020 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1021 marked as special. Also, starting docstrings with * is obsolete.
1023 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1025 * gnutls.c (emacs_gnutls_write): Fix last change.
1027 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1029 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1032 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1034 * keymap.c (Fsingle_key_description): Handle char ranges.
1036 2012-02-12 Chong Yidong <cyd@gnu.org>
1038 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1039 as that creates a dangerous corner case.
1041 * window.c (Fdelete_window_internal): Invalidate the mouse
1042 highlight (Bug#9904).
1044 2012-02-12 Glenn Morris <rgm@gnu.org>
1046 * xselect.c (Fx_own_selection_internal)
1047 (Fx_get_selection_internal, Fx_disown_selection_internal)
1048 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1049 * nsselect.m (Fx_own_selection_internal)
1050 (Fx_disown_selection_internal, Fx_selection_exists_p)
1051 (Fx_selection_owner_p, Fx_get_selection_internal):
1052 Sync docs and argument specs with the xselect.c versions.
1054 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1056 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1058 2012-02-11 Eli Zaretskii <eliz@gnu.org>
1060 * w32select.c (Fx_selection_exists_p): Sync doc string and
1061 argument list with xselect.c. (Bug#10783)
1063 * w16select.c (Fx_selection_exists_p): Sync doc string and
1064 argument list with xselect.c. (Bug#10783)
1066 2012-02-10 Glenn Morris <rgm@gnu.org>
1068 * fns.c (Fsecure_hash): Doc fix.
1070 2012-02-09 Kenichi Handa <handa@m17n.org>
1072 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1074 2012-02-07 Chong Yidong <cyd@gnu.org>
1076 * buffer.c (Fbuffer_local_variables)
1077 (buffer_lisp_local_variables): Handle unbound vars correctly;
1078 don't let Qunbound leak into Lisp.
1080 2012-02-07 Glenn Morris <rgm@gnu.org>
1082 * image.c (Fimagemagick_types): Doc fix.
1084 * image.c (imagemagick-render-type): Change it from a lisp object
1085 to an integer. Move the doc here from the lisp manual.
1086 Treat all values not equal to 0 the same.
1088 2012-02-06 Chong Yidong <cyd@gnu.org>
1090 * doc.c (store_function_docstring): Avoid applying docstring of
1091 alias to base function (Bug#2603).
1093 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1095 * .gdbinit (pp1, pv1): Remove redundant defines.
1098 2012-02-04 Chong Yidong <cyd@gnu.org>
1100 * nsterm.m: Declare a global (Bug#10694).
1102 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1104 * w32.c (get_emacs_configuration_options):
1105 Include --enable-checking, if specified, in the return value.
1107 2012-02-04 Martin Rudalics <rudalics@gmx.at>
1109 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1110 after rounding frame sizes. (Bug#9723)
1112 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1114 * keyboard.c (adjust_point_for_property): Don't position point
1115 before BEGV. (Bug#10696)
1117 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1119 Handle overflow when computing char display width (Bug#9496).
1120 * character.c (char_width): Return EMACS_INT, not int.
1121 (char_width, c_string_width): Check for overflow when
1122 computing the width; this is possible now that individual
1123 characters can have unbounded width. Problem introduced
1124 by merge from Emacs 23 on 2012-01-19.
1126 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1128 * dbusbind.c (Fdbus_register_method): Mention the return value
1129 :ignore in the docstring.
1131 2012-02-02 Glenn Morris <rgm@gnu.org>
1133 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1135 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1136 Unconditionally set to t. (Bug#10673)
1137 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1138 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1139 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1141 2012-02-02 Kenichi Handa <handa@m17n.org>
1143 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1144 0, do not call append_composite_glyph.
1146 2012-02-02 Kenichi Handa <handa@m17n.org>
1148 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1150 (x_produce_glyphs): If the component of a composition is a null
1151 string, set it->pixel_width to 1 to avoid zero-width glyph.
1153 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1155 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1156 first 2 arguments are identical. This makes inserting large
1157 output from a subprocess an order of magnitude faster on
1158 MS-Windows, where all sbrk'ed memory is always contiguous.
1160 2012-01-31 Glenn Morris <rgm@gnu.org>
1162 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1163 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1164 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1166 2012-01-29 Glenn Morris <rgm@gnu.org>
1168 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1170 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1172 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1174 2012-01-28 Chong Yidong <cyd@gnu.org>
1176 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1178 2012-01-26 Chong Yidong <cyd@gnu.org>
1180 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1182 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1183 repeat counts (Bug#10507).
1185 2012-01-26 Glenn Morris <rgm@gnu.org>
1187 * lread.c (syms_of_lread): Doc fix.
1189 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1191 * coding.c (encode_designation_at_bol): Change return value to
1194 2012-01-25 Chong Yidong <cyd@gnu.org>
1196 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1198 2012-01-21 Chong Yidong <cyd@gnu.org>
1200 * floatfns.c (Fcopysign): Make the second argument non-optional,
1201 since nil is not allowed anyway.
1203 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1205 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1206 (send_process): Likewise.
1208 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1210 * window.c (save_window_save, Fcurrent_window_configuration)
1211 (Vwindow_persistent_parameters): Do not use Qstate.
1212 Rewrite doc-strings.
1214 2012-01-19 Kenichi Handa <handa@m17n.org>
1216 * character.c (char_width): New function.
1217 (Fchar_width, c_string_width, lisp_string_width):
1218 Use char_width (Bug#9496).
1220 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1222 * window.c (Vwindow_persistent_parameters): New variable.
1223 (Fset_window_configuration, save_window_save): Handle persistent
1226 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1228 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1229 thrashing the stack of the thread. (Bug#9087)
1231 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1233 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1235 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1237 * xdisp.c (rows_from_pos_range): Handle the case where the
1238 highlight ends on a newline. (Bug#10464)
1239 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1240 he end column for display of highlight that ends on a newline
1243 2012-01-11 Glenn Morris <rgm@gnu.org>
1245 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1246 from load-path also when installation-directory is nil. (Bug#10208)
1248 2012-01-10 Glenn Morris <rgm@gnu.org>
1250 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1252 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1253 Update template values to be closer to their typical values these days.
1255 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1257 * xdisp.c (rows_from_pos_range): Accept additional argument
1258 DISP_STRING, and accept any glyph in a row whose object is that
1259 string as eligible for mouse highlight. Fixes mouse highlight of
1260 display strings from overlays. (Bug#10464)
1262 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1264 emacs: fix an auto-save permissions race condition (Bug#10400)
1265 * fileio.c (auto_saving_dir_umask): New static var.
1266 (Fmake_directory_internal): Use it.
1267 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1268 creating the directory. The old code temporarily assigns
1269 too-generous permissions to the directory.
1270 (do_auto_save_eh): Clear it.
1271 (Fdo_auto_save): Catch all errors, not just file errors, so
1272 that the var is always cleared.
1274 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1276 * search.c (scan_buffer): Pass character positions to
1277 know_region_cache, not byte positions. (Bug#6540)
1279 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1281 * w32.c (sys_rename): Report EXDEV when rename of a directory
1282 fails because the target is on another logical disk. (Bug#10284)
1284 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1286 * xterm.c (x_embed_request_focus): New function.
1288 * xterm.h: Add prototype.
1290 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1292 2012-01-05 Glenn Morris <rgm@gnu.org>
1294 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1296 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1298 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1299 Load gnutls_transport_set_lowat only if GnuTLS version is below
1301 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1302 GnuTLS versions below 2.11.1.
1304 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1306 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1307 to the doc string advising against its use for altering the way
1308 windows are scrolled.
1310 2011-12-28 Kenichi Handa <handa@m17n.org>
1312 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1313 coding-system ASCII compatible only when it does not produce BOM
1314 on encoding (Bug#10383).
1316 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1318 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1320 (create_and_show_popup_menu): Always use menu_position_func for
1323 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1325 * callint.c (Fcall_interactively): Don't truncate prompt string.
1327 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1329 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1330 property that ends at ZV, so that the bidi iteration could be
1331 resumed from there (after widening). (Bug#10360)
1333 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1335 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1337 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1339 * nsterm.m (x_free_frame_resources):
1340 Release f->output_data.ns->miniimage.
1341 (ns_index_color): Fix indentation. Do not retain
1342 color_table->colors[i].
1344 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1347 * nsfns.m (x_set_background_color): Assign return value from
1348 ns_index_color to face-background instead of NSColor*.
1349 (ns_implicitly_set_icon_type): Fix indentation.
1350 Change assignment in for loop to comparison.
1352 * emacs.c (ns_pool): New variable.
1353 (main): Assign ns_pool.
1354 (Fkill_emacs): Call ns_release_autorelease_pool.
1356 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1357 autorelease fdesc, release fdAttrs and tdict.
1358 (ns_get_covering_families): Release charset.
1359 (ns_findfonts): Release NSFontDescriptor created with new.
1360 (ns_uni_to_glyphs): Fix indentation.
1361 (setString): Release attrStr before assigning new value.
1363 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1365 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1367 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1368 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1370 2011-12-18 David Reitter <reitter@cmu.edu>
1372 * nsterm.m (ns_term_init): Subscribe for notifications
1373 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1374 to method trackingNotification in EmacsMenu.
1376 * nsmenu.m (trackingMenu): New variable.
1377 (trackingNotification): New method (from Aquamacs).
1378 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1379 from Aquamacs (Bug#7030).
1381 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1383 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1384 (symbol_to_nsstring): Fix indentation.
1385 (ns_symbol_to_pb): New function.
1386 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1387 (Fns_rotate_cut_buffers_internal): Remove.
1388 (Fns_store_selection_internal): Rename from
1389 Fns_store_cut_buffer_internal.
1390 (ns_get_foreign_selection, Fx_own_selection_internal)
1391 (Fx_disown_selection_internal, Fx_selection_exists_p)
1392 (Fns_get_selection_internal, Fns_store_selection_internal):
1393 Use ns_symbol_to_pb and check if return value is nil.
1394 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1395 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1396 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1397 renamed to Sns_store_selection_internal.
1398 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1399 and remove this function.
1400 (ns_handle_selection_clear): Remove, never used.
1401 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1404 2011-12-17 Ken Brown <kbrown@cornell.edu>
1406 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1407 GID is unknown (Bug#10257).
1409 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1411 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1412 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1413 which caused a build failure on GNU/Linux IA-64. This problem was
1414 introduced by my 2011-10-07 patch.
1416 2011-12-15 Juri Linkov <juri@jurta.org>
1418 * image.c (imagemagick_error): New function. (Bug#10112)
1419 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1420 Use `imagemagick_error' where ImageMagick functions return
1422 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1425 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1427 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1428 fill background (Bug#8992).
1430 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1432 * window.c (Vwindow_combination_resize)
1433 (Vwindow_combination_limit): Use t instead of non-nil in
1435 (Vrecenter_redisplay): Add first sentence of doc-string on
1437 (Frecenter): Fix doc-string typo.
1439 2011-12-11 Kenichi Handa <handa@m17n.org>
1441 * coding.c (Funencodable_char_position): Pay attention to the
1442 buffer text relocation (Bug#9389).
1444 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1446 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1447 gtk_init (Bug#10100).
1449 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1451 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1452 IT->string is nil. (Bug#10263)
1454 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1456 * nsterm.h (x_free_frame_resources): Declare.
1458 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1459 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1461 * nsterm.h (ns_get_defaults_value): Declare.
1463 * nsterm.m (ns_default): Call ns_get_defaults_value.
1465 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1467 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1470 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1472 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1473 that where the value of an _OBJC_* symbol points to is in the .bss
1474 section (Bug#10240).
1476 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1478 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1479 after the loop to call ccl_driver at least once (Bug#8619).
1481 2011-12-08 Kenichi Handa <handa@m17n.org>
1483 * ftfont.c (get_adstyle_property): Fix previous change
1486 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1488 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1489 dirs from the default value of EMACSLOADPATH (bug#10208).
1491 2011-12-07 Glenn Morris <rgm@gnu.org>
1493 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1494 installation and source directories as well. (Bug#10208)
1496 2011-12-06 Chong Yidong <cyd@gnu.org>
1498 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1500 2011-12-06 Glenn Morris <rgm@gnu.org>
1502 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1503 as an error, not just -1. (Bug#10217)
1505 2011-12-05 Chong Yidong <cyd@gnu.org>
1507 * keyboard.c (process_special_events): New function.
1508 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1510 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1512 * coding.c (encode_designation_at_bol): Don't use uninitialized
1513 local variable (Bug#9318).
1515 2011-12-05 Kenichi Handa <handa@m17n.org>
1517 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1518 return Qnil (Bug#8046, Bug#10193).
1520 2011-12-05 Kenichi Handa <handa@m17n.org>
1522 * coding.c (encode_designation_at_bol): New args charbuf_end and
1523 dst. Return the number of produced bytes. Callers changed.
1524 (coding_set_source): Return how many bytes coding->source was
1526 (coding_set_destination): Return how many bytes
1527 coding->destination was relocated.
1528 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1529 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1531 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1533 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1534 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1537 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1539 The following changes are to fix Bug#9318.
1541 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1542 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1543 (encode_coding_iso_2022, encode_coding_sjis)
1544 (encode_coding_big5, encode_coding_charset): Use the above macros.
1546 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1548 * lisp.h (process_quit_flag): Fix external declaration.
1550 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1552 Don't macro-inline non-performance-critical code.
1553 * eval.c (process_quit_flag): New function.
1554 * lisp.h (QUIT): Use it.
1556 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1558 * nsfns.m (get_geometry_from_preferences): New function.
1559 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1561 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1563 * emacs.c (Qkill_emacs): Define.
1564 (syms_of_emacs): Initialize it.
1565 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1566 Qquit_flag to `kill-emacs' instead.
1567 (quit_throw_to_read_char): Add parameter `from_signal'.
1568 All callers changed. Call Fkill_emacs if requested and safe.
1569 * lisp.h (QUIT): Call Fkill_emacs if requested.
1571 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1573 * widget.c (update_wm_hints): Return if wmshell is null.
1574 (widget_update_wm_size_hints): New function.
1576 * widget.h (widget_update_wm_size_hints): Declare.
1578 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1579 widget_update_wm_size_hints (Bug#10104).
1581 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1583 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1584 before a newline, prepare the bidi iterator for consuming the
1585 newline, and keep the current paragraph direction. (Bug#10183)
1586 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1588 2011-12-02 Juri Linkov <juri@jurta.org>
1590 * search.c (Fword_search_regexp): New Lisp function created from
1591 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1592 (Fword_search_backward, Fword_search_forward)
1593 (Fword_search_backward_lax, Fword_search_forward_lax):
1594 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1595 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1597 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1599 * fileio.c (Finsert_file_contents): Move after-change-function call
1600 to before the "handled:" label, since all "goto handled" appear in
1601 cases where the *-change-functions have already been properly called
1604 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1606 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1607 waiting for input. (Bug#10169)
1609 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1611 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1612 verifies glyph row's hash code--we have just reallocated the
1613 glyphs, so their contents can be complete garbage. (Bug#10164)
1615 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1617 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1619 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1621 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1622 attributes are tested _before_ calling verify_row_hash, to protect
1623 against GCC re-ordering of the tests. (Bug#10164)
1625 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1627 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1629 * xterm.c (handle_one_xevent): Only set async_visible and friends
1630 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1631 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1632 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1634 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1636 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1637 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1638 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1639 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1640 All uses changed to use GCPRO1 etc.
1641 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1642 Revert to old implementation (i.e., before 2011-03-11).
1644 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1646 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1647 of scroll runs so as to avoid assigning disabled bogus rows and
1648 unnecessary graphics copy operations.
1650 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1652 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1653 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1654 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1655 (malloc, free, realloc, calloc): Redirect to e_* only when
1658 * lisp.h (GCTYPEBITS): Move before first use.
1659 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1660 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1661 this macro definition.
1663 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1666 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1668 * gtkutil.c (xg_create_frame_widgets):
1669 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1670 present with Gtk+ 2.0.
1672 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1674 * fileio.c (Finsert_file_contents): Undo previous change; see
1675 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1677 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1679 Rename locals to avoid shadowing.
1680 * fileio.c (Finsert_file_contents):
1681 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1682 * process.c (wait_reading_process_output):
1683 Rename inner 'proc' to 'p' to avoid shadowing.
1684 Indent for consistency with usual Emacs style.
1686 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1688 * xdisp.c (redisplay_window): If cursor row is not fully visible
1689 after recentering, and scroll-conservatively is set to a large
1690 number, scroll window by a few more lines to make the cursor fully
1691 visible and out of scroll-margin. (Bug#10105)
1692 (start_display): Don't move to the next line if the display should
1693 start at a newline that is part of a display vector or an overlay
1696 2011-11-24 Juri Linkov <juri@jurta.org>
1698 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1699 after the `MagickPingImage' call. (Bug#10112)
1701 2011-11-23 Chong Yidong <cyd@gnu.org>
1703 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1705 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1707 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1708 making another buffer current. (Bug#10114)
1710 2011-11-23 Glenn Morris <rgm@gnu.org>
1712 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1714 2011-11-23 Chong Yidong <cyd@gnu.org>
1716 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1717 using it (Bug#5984).
1719 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1721 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1722 and header-lines, as they don't have one computed for them.
1725 * .gdbinit (prow): Make displayed values more self-explaining.
1726 Add row's hash code.
1728 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1730 * process.c (wait_reading_process_output): Fix asynchrounous
1731 GnuTLS socket handling on some versions of the GnuTLS library.
1732 (wait_reading_process_output): Add comment and URL.
1734 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1736 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1738 2011-11-21 Chong Yidong <cyd@gnu.org>
1740 * window.c (Fnext_window, Fprevious_window): Doc fix.
1742 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1744 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1746 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1748 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1750 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1752 * window.c (Fset_window_combination_limit): Rename argument
1754 (Vwindow_combination_limit): Remove "status" from doc-string.
1756 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1758 * m/ibms390.h: Remove.
1759 * m/ibms390x.h: Don't include "ibms390.h".
1761 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1763 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1764 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1766 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1768 * casetab.c (Fset_case_table):
1769 * charset.c (Fcharset_after): Fix typos.
1771 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1773 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1774 Otherwise, valgrind does not work on some platforms.
1775 Problem reported by Andreas Schwab in
1776 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1777 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1778 is set, removing the need for VIRT_ADDRESS_VARIES.
1779 (PURE_P): Use a more-efficient implementation that needs just one
1780 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1781 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1782 to 4 (xorl, subq, cmpq, setbe).
1783 * alloc.c (pure): Always extern now, since that's the
1784 VIRT_ADDR_VARIES behavior.
1785 (PURE_POINTER_P): Use a single comparison, not two, for
1786 consistency with the new puresize.h.
1787 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1788 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1789 Remove VIRT_ADDR_VARIES no longer needed.
1791 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1793 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1794 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1795 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1796 behave as if the cursor position were at the window margin.
1798 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1799 and the cursor position is out of bounds, behave as if the cursor
1800 position were at the window margin. (Bug#10075)
1802 2011-11-18 Chong Yidong <cyd@gnu.org>
1804 * window.c (Fwindow_combination_limit): Make first argument
1805 non-optional, since it is meaningless for live windows like the
1808 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1810 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1812 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1814 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1815 (graft_intervals_into_buffer): Simplify.
1817 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1819 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1820 hash values of the two rows.
1821 (copy_row_except_pointers): Preserve the used[] arrays and the
1822 hash values of the two rows. (Bug#10035)
1823 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1825 * xdisp.c (row_hash): New function, body extracted from
1826 compute_line_metrics.
1827 (compute_line_metrics): Call row_hash, instead of computing the
1830 * dispnew.c (verify_row_hash): Call row_hash for computing the
1831 hash code of a row, instead of duplicating code from xdisp.c.
1833 * dispextern.h (row_hash): Add prototype.
1835 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1837 * frame.c (delete_frame): Don't delete the terminal when the last
1838 X frame is closed if emacs is built with GTK toolkit.
1840 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1842 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1844 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1846 * window.c (Vwindow_splits): Rename to
1847 Vwindow_combination_resize. Suggested by Juri Linkov.
1848 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1851 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1853 * nsfns.m (Fns_font_name):
1854 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1856 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1858 * window.h (window): Rename slot "nest" to "combination_limit".
1859 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1860 (Fset_window_nest): Rename to Fset_window_combination_limit.
1861 (Vwindow_nest): Rename to Vwindow_combination_limit.
1862 (recombine_windows, make_parent_window, make_window)
1863 (Fsplit_window_internal, saved_window)
1864 (Fset_window_configuration, save_window_save): Rename all
1865 occurrences of window_nest to window_combination_limit.
1867 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1869 * image.c (imagemagick_load_image): Fix typo.
1871 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1873 * xdisp.c (display_line): Move the call to
1874 highlight_trailing_whitespace before the call to
1875 compute_line_metrics, since the latter needs to see the final
1876 faces of all the glyphs to compute ROW's hash value.
1877 Fixes assertion violations in row_equal_p. (Bug#10035)
1879 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1881 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1882 just return (bug#10044).
1884 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1886 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1887 with user-defined heap size. Bump the default size of the temacs
1888 heap to 27MB, to avoid memory warning when running temacs.
1889 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1891 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1892 current_matrix and desired_matrix. (Bug#9990)
1893 (verify_row_hash) [XASSERTS]: New function.
1894 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1895 that the hash value of glyph rows is correct.
1897 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1899 * window.h (window): Remove splits slot.
1900 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1901 (Fdelete_other_windows_internal, make_parent_window)
1902 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1903 (Fset_window_configuration, save_window_save): Don't deal with
1904 split status of windows.
1905 (saved_window): Remove splits slot.
1906 (Vwindow_splits): Rewrite doc-string.
1908 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1910 * xfns.c (unwind_create_frame):
1911 * nsfns.m (unwind_create_frame):
1912 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1913 Vframe_list (Bug#9999).
1915 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1917 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1919 2011-11-11 Kenichi Handa <handa@m17n.org>
1921 * callproc.c (Fcall_process): Set the member dst_multibyte of
1924 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1926 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1927 avoid a crash (bug#9496).
1929 2011-11-09 Chong Yidong <cyd@gnu.org>
1931 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1932 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1934 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1936 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1938 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1940 Avoid some portability problems by eschewing 'extern inline' functions.
1941 The trivial performance wins aren't worth the portability hassles; see
1942 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1944 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1945 (window_box_width, window_box_left, window_box_left_offset)
1946 (window_box_right, window_box_right_offset): Undo previous change,
1947 by removing the "extern"s.
1948 * intervals.c (adjust_intervals_for_insertion)
1949 (adjust_intervals_for_deletion): Undo previous change,
1950 making these static again.
1951 (offset_intervals, temp_set_point_both, temp_set_point)
1952 (copy_intervals_to_string): No longer inline.
1953 * xdisp.c (window_text_bottom_y, window_box_width)
1954 (window_box_height, window_box_left_offset)
1955 (window_box_right_offset, window_box_left, window_box_right)
1956 (window_box): No longer inline.
1958 2011-11-08 Chong Yidong <cyd@gnu.org>
1960 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1961 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1962 Signal an error if not a live window.
1963 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1964 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1966 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1968 * lisp.h (syms_of_abbrev): Remove declaration.
1969 Reported by CHENG Gao <chenggao@royau.me>.
1971 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1973 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1974 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1975 of temacs in GUI mode.
1977 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1979 * window.h: Declare delete_all_child_windows instead of
1980 delete_all_subwindows.
1981 * window.c (Fwindow_nest, Fset_window_nest)
1982 (Fset_window_new_total, Fset_window_new_normal)
1983 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1984 (delete_all_subwindows): Rename to delete_all_child_windows.
1985 (Fdelete_other_windows_internal, Fset_window_configuration):
1986 Call delete_all_child_windows instead of delete_all_subwindows.
1987 * frame.c (delete_frame): Call delete_all_child_windows instead
1988 of delete_all_subwindows.
1990 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1992 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1993 This is also needed for porting to any host where GC_MARK_STACK is
1994 not GC_MAKE_GCPROS_NOOPS.
1995 (which_symbols): Use it.
1997 2011-11-07 Kenichi Handa <handa@m17n.org>
1999 * coding.c (coding_set_destination): Check coding->src_pos only
2000 when coding->src_object is a buffer (bug#9910).
2002 * process.c (send_process): Set the member src_multibyte of coding
2003 to 0 (bug#9911) when sending a unibyte text.
2005 * callproc.c (Fcall_process): Set the member src_multibyte of
2006 process_coding to 0 (bug#9912).
2008 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2010 * xmenu.c (cleanup_widget_value_tree): New function.
2011 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2012 calling free_menubar_widget_value_tree directly (Bug#9830).
2014 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2016 Fix some portability problems with 'inline'.
2017 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2018 (window_box_width, window_box_left, window_box_left_offset)
2019 (window_box_right, window_box_right_offset): Declare extern.
2020 Otherwise, these inline functions do not conform to C99 and
2021 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2022 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2023 * intervals.c (adjust_intervals_for_insertion)
2024 (adjust_intervals_for_deletion): Now extern, because otherwise the
2025 extern inline functions 'offset_intervals' couldn't refer to it.
2026 (static_offset_intervals): Remove.
2027 (offset_intervals): Rewrite using the old contents of
2028 static_offset_intervals. The old version didn't conform to C99
2029 because an extern inline function contained a reference to an
2030 identifier with static linkage.
2032 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2034 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2037 2011-11-06 Eli Zaretskii <eliz@gnu.org>
2039 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2040 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2041 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2042 return Qleft_to_right.
2044 2011-11-06 Chong Yidong <cyd@gnu.org>
2046 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2047 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2048 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2049 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2050 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2051 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2052 (Fwindow_vscroll): Doc fix.
2053 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2054 argument, since it makes no sense to pass a live window and for
2055 consistency with window-child.
2057 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2059 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2062 2011-11-05 Jason Rumney <jasonr@gnu.org>
2064 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2065 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2067 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2068 bitwise arithmetic preventing use of unicode-sip and non-truetype
2071 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2073 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2076 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2077 initialization code to keep similarity to xfns.c after changes
2080 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2082 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2083 (unwind_create_frame): New function (Bug#9943).
2084 (Fx_create_frame): Restructure code to be more similar to the one in
2085 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2086 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2087 Move terminal->reference_count++ just before making the frame official
2090 * nsterm.m (x_free_frame_resources): New function.
2091 (x_destroy_window): Move code to x_free_frame_resources.
2093 * xfns.c (unwind_create_frame): Fix comment.
2094 (Fx_create_frame, x_create_tip_frame):
2095 Move terminal->reference_count++ just before making the frame
2096 official. Move initialization of image_cache_refcount and
2097 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2099 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2101 Support MSVC build with newer versions of Visual Studio.
2102 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2103 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2106 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2107 which are not supported by MSVC.
2108 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2109 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2111 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2113 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2115 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2117 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2119 Support MSVC build with newer versions of Visual Studio.
2120 * w32.c: Don't include w32api.h for MSVC.
2121 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2123 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2124 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2125 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2126 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2128 (alloca) [_MSC_VER]: Define to _alloca.
2130 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2132 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2134 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2136 * xdisp.c (note_mouse_highlight): If either of
2137 previous/next-single-property-change returns nil, treat that as
2138 the beginning or the end of the buffer. (Bug#9955)
2140 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2142 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2143 label is not null (Bug#9951).
2144 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2147 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2149 * window.c (Fwindow_body_size): Mention in the doc string that the
2150 return value is in frame's canonical units. (Bug#9949)
2152 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2154 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2156 * w32fns.c (unwind_create_frame): If needed, free the glyph
2157 matrices of the partially constructed frame. (Bug#9943)
2158 * xfns.c (unwind_create_frame): Likewise.
2160 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2162 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2163 Don't stop backward scan on the continuation glyph, even though
2164 its CHARPOS is positive.
2165 (mouse_face_from_buffer_pos, note_mouse_highlight):
2166 Rename cover_string to disp_string.
2168 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2170 * window.c (temp_output_buffer_show): Don't use
2171 Vtemp_buffer_show_specifiers.
2172 (Vtemp_buffer_show_specifiers): Remove unused variable.
2174 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2176 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2177 past the beginning of the current glyph matrix.
2179 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2181 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2182 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2183 HAVE_GTK3 (Bug#9869).
2185 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2186 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2188 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2190 * xterm.c: Declare x_handle_net_wm_state to return int.
2191 (handle_one_xevent): Check if we are iconified but don't have
2192 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2193 (get_current_wm_state): Return non-zero if not hidden,
2194 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2195 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2196 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2197 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2199 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2201 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2202 so that this new function doesn't get optimized away by a
2203 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2205 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2207 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2209 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2211 Fix the `xbytecode' command.
2212 * .gdbinit (xprintbytestr): New command.
2213 (xwhichsymbols): Rename from `which'; all callers changed.
2214 (xbytecode): Print the byte-code string as well.
2216 2011-10-29 Kim Storm <storm@cua.dk>
2218 * alloc.c (which_symbols): New function.
2220 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2222 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2225 2011-10-29 Glenn Morris <rgm@gnu.org>
2227 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2228 Not clear what it was for, and it causes various bugs. (Bug#9839)
2230 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2232 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2233 possible random value that matches one of those tested as
2234 condition to clear the mouse face.
2236 2011-10-28 Chong Yidong <cyd@gnu.org>
2238 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2240 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2242 * window.c (make_window): Initialize phys_cursor_on_p.
2244 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2246 * lisp.h (struct Lisp_Symbol): Update comments.
2248 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2250 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2252 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2254 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2255 <oslsachem@gmail.com> for helping to debug this.
2257 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2258 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2259 (g_b_init_get_glyph_outline_w): New static variables.
2260 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2261 (GetGlyphOutlineW_Proc): New typedefs.
2262 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2263 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2265 (w32font_open_internal, compute_metrics):
2266 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2267 instead of calling the "wide" APIs directly.
2269 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2271 * w32.h (syms_of_w32font): Add prototype.
2273 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2275 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2276 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2277 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2278 (Fmove_to_window_line): Doc fix.
2280 2011-10-27 Chong Yidong <cyd@gnu.org>
2282 * process.c (make_process): Set gnutls_state to NULL.
2284 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2285 non-NULL, regardless of GNUTLS_INITSTAGE.
2286 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2287 an error. Set process slots as soon as we allocate them.
2289 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2291 2011-10-27 Chong Yidong <cyd@gnu.org>
2293 * gnutls.c (emacs_gnutls_deinit): New function.
2294 Deallocate credentials structures as well as calling gnutls_deinit.
2295 (Fgnutls_deinit, Fgnutls_boot): Use it.
2297 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2298 (deactivate_process): Call emacs_gnutls_deinit.
2300 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2302 * image.c (x_create_x_image_and_pixmap):
2303 * w32.c (sys_rename, w32_delayed_load):
2304 * w32font.c (fill_in_logfont):
2305 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2307 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2309 * w32fns.c (w32_default_color_map): New function,
2310 extracted from Fw32_default_color_map.
2311 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2313 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2315 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2317 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2319 * keyboard.c (test_undefined): New function (bug#9751).
2320 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2322 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2324 * sysdep.c (init_sys_modes): Fix the check for the controlling
2325 terminal (Bug#6649).
2327 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2329 * dispextern.h (struct bidi_it): New member next_en_type.
2331 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2332 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2333 current character, check also for next_en_type being WEAK_EN.
2334 (bidi_resolve_weak): Don't enter the expensive loop if the current
2335 position is before next_en_pos. Record the bidi type of the first
2336 non-ET, non-BN character we find, in addition to its position.
2337 (bidi_level_of_next_char): Invalidate next_en_type when
2338 next_en_pos is over-stepped.
2340 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2342 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2343 * editfns.c: Rewrite current-time-zone so that it invokes
2344 the equivalent of (format-time-string "%Z") to get the time zone name.
2345 This fixes a bug when the time zone name contains characters that
2346 need converting from the system time locale to Emacs internal format.
2347 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2348 that patch fixed format-time-string to do the conversion, but
2349 I forgot to fix current-time-zone.
2350 (format_time_string): New function, containing most of
2351 what Fformat_time_string used to contain.
2352 (Fformat_time_string): Rewrite in terms of format_time_string.
2353 This doesn't change this function's behavior.
2354 (current-time-zone): Rewrite to use format_time_string.
2355 This fixes the bug reported by Michael Schierl in
2356 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2357 Jason Rumney's 2007-06-07 change worked around this bug, but
2359 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2361 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2363 * xdisp.c (start_display): If the character at POS is displayed
2364 via a display vector, reset IT->current.dpvec_index to zero.
2365 (try_window_reusing_current_matrix): If a line ends in a display
2366 vector or the next line starts in a display vector, continue
2367 redrawing the window even though the character position of
2368 start_row was reached.
2371 2011-10-18 Chong Yidong <cyd@gnu.org>
2373 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2374 with nobreak-char-display too.
2376 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2378 Fix part 3 of bug#9771.
2379 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2380 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2381 non-neutral characters if the current character is a paragraph
2382 separator (a.k.a. Newline). This avoids running the same
2383 expensive loop twice, once when we consume the preceding newline
2384 and the other time when the line actually needs to be displayed.
2385 Avoid the loop when we see neutrals on the base embedding level
2386 following a character whose directionality is the same as the
2387 paragraph's. This avoids running the expensive loop when a line
2388 ends in a long sequence of neutrals, like control characters.
2389 Add assertion against STRONG_AL type. Slightly rearrange code
2390 that determines the type of a neutral given the first non-neutral
2392 (bidi_level_of_next_char): Set next_en_pos to zero when
2393 invalidating its info.
2395 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2397 * xdisp.c (push_display_prop): Determine whether to record string
2398 or buffer position by IT->string, not by IT->method. Allow
2399 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2400 (move_it_vertically_backward): Don't look for character position
2401 immediately after the newline when in a continuation line.
2404 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2406 * window.c (coordinates_in_window): Rewrite and delabelize
2407 vertical border check. (Bug#5357) (Bug#9618)
2409 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2411 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2412 errors in XSetWindowBorder (bug#9310).
2414 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2416 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2417 avoid crash when xmalloc overrun checking is enabled.
2419 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2421 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2422 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2423 cursor motion with <left> and <right> arrow keys.
2425 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2426 some callers set that themselves.
2428 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2430 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2431 display string and the previous row comes from the same string and
2432 is empty. (Bug#9739) (Bug#9738)
2434 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2436 * doc.c (get_doc_string): Encode file name (bug#9735).
2438 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2440 * bidi.c (bidi_level_of_next_char):
2441 * xdisp.c (get_visually_first_element): Remove old incorrect
2442 comments regarding the Unicode Line Separator character.
2444 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2446 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2448 * alloc.c (Fgc_status): Do not access beyond zombies array
2449 boundary if nzombies > MAX_ZOMBIES.
2450 * alloc.c (dump_zombies): Add missing format specifier.
2452 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2454 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2455 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2457 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2458 Some packages use them to denote characters with modifiers.
2460 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2462 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2463 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2464 matching a pp-number. Rename parameter var to var1.
2466 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2468 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2470 2011-10-08 Glenn Morris <rgm@gnu.org>
2472 * callint.c (Fcall_interactively): Give a more explicit error for the
2473 'c' case with a non-character input. (Bug#8479)
2475 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2477 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2479 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2480 lines that are hscrolled on the left.
2482 * dispnew.c (buffer_posn_from_coords): Account for a possible
2483 presence of header-line. (Bug#4426)
2485 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2487 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2488 Don't advertise functionality which we discourage or doesn't work.
2490 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2492 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2493 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2494 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2495 this makes Emacs dump core during garbage collection on rare
2496 occasions. sizeof is obviously inferior to offsetof here, so
2497 stick with offsetof.
2498 (GC_POINTER_ALIGNMENT): New macro.
2499 (mark_memory): Omit 3rd (offset) arg; caller changed.
2500 Don't assume EMACS_INT alignment is the same as pointer alignment.
2502 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2504 * keyboard.c (read_key_sequence_remapped): New var.
2505 (read_key_sequence): Compute remapping in the right buffer.
2506 (command_loop_1): Use read_key_sequence's remapping directly.
2508 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2510 * dired.c (file_name_completion): Don't expand file name.
2511 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2512 before checking file name handler.
2514 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2515 they've been requested explicitly (bug#9591).
2517 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2519 * keymap.c (Fsingle_key_description): Use make_specified_string
2520 instead of build_string to build string from push_key_description.
2523 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2525 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2526 This fixes a Y2038 bug on 64-bit hosts.
2527 * buffer.c (reset_buffer):
2528 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2529 (Fclear_buffer_auto_save_failure):
2530 Use 0, not -1, to represent an unset failure time, since time_t
2531 might not be signed.
2533 Remove dependency on glibc malloc internals.
2534 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2535 Move back here from lisp.h, but with their new implementations.
2536 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2537 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2538 * charset.c (charset_table_init): New static var.
2539 (syms_of_charset): Use it instead of xmalloc. This removes a
2540 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2541 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2542 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2543 Move back to alloc.c.
2544 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2545 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2547 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2549 * nsterm.m (windowDidResize): Call x_set_window_size only when
2550 ns_in_resize is true. Otherwise set pixelwidth/height and
2551 call change_frame_size (Bug#9628).
2553 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2555 Port --enable-checking=all to Fedora 14 x86-64.
2556 * charset.c (syms_of_charset): Also account for glibc malloc's
2557 internal overhead when calculating the initial malloc maximum.
2559 Port --enable-checking=all to Fedora 14 x86.
2560 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2562 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2563 (overrun_check_realloc, overrun_check_free):
2564 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2565 That way, xmalloc returns a properly-aligned pointer even if
2566 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2567 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2568 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2569 into account when calculating the initial malloc maximum.
2570 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2571 Move here from alloc.c, so that charset.c can use it too.
2572 Properly align; the old code wasn't right for common 32-bit hosts
2573 when configured with --enable-checking=all.
2574 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2575 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2577 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2579 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2582 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2584 * xdisp.c (compute_display_string_end): If there's no display
2585 string at CHARPOS, return -1.
2587 * bidi.c (bidi_fetch_char): When compute_display_string_end
2588 returns a negative value, treat the character as a normal
2589 character not covered by a display string. (Bug#9624)
2591 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2593 * lread.c (Fread_from_string): Fix typo in docstring.
2595 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2597 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2598 newline, reseat the iterator instead of bidi-iterating there one
2599 character at a time. (Bug#9610)
2600 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2601 TO_CHARPOS if the bidi iterator is at base embedding level.
2603 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2605 * lread.c (readevalloop): Use correct code for NBSP.
2606 (read1): Likewise. (Bug#9608)
2608 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2610 * dbusbind.c (Fdbus_register_signal): When service is not
2611 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2613 2011-09-25 Glenn Morris <rgm@gnu.org>
2615 * buffer.c (truncate-lines): Doc fix.
2617 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2619 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2620 (Fset_window_next_buffers): Doc fix.
2622 2011-09-24 Glenn Morris <rgm@gnu.org>
2624 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2626 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2628 Fix minor problems found by static checking.
2629 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2630 * indent.c (Fvertical_motion): Fix == vs = typo.
2632 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2634 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2635 Default value is now t. Doc fix.
2637 * indent.c (Fvertical_motion): Compute and apply the overshoot
2638 logic when moving up, not only when moving down. Fix the
2639 confusing name and values of the it_overshoot_expected variable;
2640 logic changes accordingly. (Bug#9254) (Bug#9549)
2642 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2643 CHARPOS is covered by a display string which includes newlines.
2644 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2645 is covered by a display string with embedded newlines.
2647 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2649 * dbusbind.c (Fdbus_register_signal): Add match rule to
2650 Vdbus_registered_objects_table. (Bug#9581)
2651 (Fdbus_register_method, Vdbus_registered_objects_table):
2654 2011-09-24 Jim Meyering <meyering@redhat.com>
2656 do not ignore write error for any output size
2657 The previous change was incomplete.
2658 While it makes emacs --batch detect the vast majority of stdout
2659 write failures, errors were still ignored whenever the output size is
2660 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2661 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2662 && echo FAIL: ignored write error
2663 FAIL: ignored write error
2664 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2665 && echo FAIL: ignored write error
2666 FAIL: ignored write error
2667 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2669 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2671 * emacs.c (Fkill_emacs): In noninteractive mode exit
2672 non-successfully if a write error occurred on stdout. (Bug#9574)
2674 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2676 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2679 * dispextern.h (struct it): Update the comment documenting what
2682 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2684 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2685 a display string, extend search for cursor position to end of row.
2686 (find_row_edges): If the row ends in a newline from a display
2687 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2688 Handle the case of a display string with multiple newlines.
2689 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2690 non-empty line. Fixes confusing cursor motion with arrow keys at
2691 the beginning of a line that starts with whitespace.
2693 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2695 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2698 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2700 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2703 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2705 * xdisp.c (display_line): Record maximum and minimum buffer
2706 positions even if no glyphs were produced (e.g., by a zero-width
2707 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2708 buffer positions that will be removed from the glyph row because
2710 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2711 column is beyond frame width: don't subtract 1 "pixel" when
2712 computing width of the stretch.
2713 (reseat_at_next_visible_line_start): Undo the change made on
2714 2011-09-17 that saved paragraph information and restored it after
2715 the call to `reseat'. (Bug#9545)
2717 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2719 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2720 and turn window cursor on if cleared (Bug#9415).
2722 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2724 * search.c (boyer_moore): Take unibyte characters from pattern
2725 literally. (Bug#9458)
2727 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2729 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2731 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2733 Fix minor problem found by static checking.
2734 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2735 initialized, to pacify gcc -Wuninitialized.
2737 * fileio.c: Report proper errno when syscall falls.
2738 (Finsert_file_contents): Save and restore errno,
2739 so that report_file_error outputs the correct diagnostic.
2740 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2742 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2744 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2746 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2748 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2749 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2751 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2753 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2754 about the current paragraph and restore it after the call to reseat.
2756 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2757 (bidi_find_paragraph_start): Search back for paragraph beginning
2758 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2759 (bidi_move_to_visually_next): Only trigger paragraph-related
2760 computations when the last character is a newline or at EOB, not
2761 just any NEUTRAL_B. (Bug#9470)
2763 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2764 truncated lines if point is covered by a display string. (Bug#9524)
2766 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2768 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2769 (cons_to_x_long): New function.
2770 (lisp_data_to_selection_data): Use it. Correct the test for
2771 short-versus-long data; it was negated. Break out of vector
2772 loop, for efficiency, when a long datum is discovered.
2774 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2776 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2778 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2780 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2781 GCC PR/17406) by declaring this function with external scope.
2783 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2785 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2786 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2788 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2790 * editfns.c (Fformat): Correctly handle text properties on "%%".
2792 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2794 * xterm.c (x_draw_composite_glyph_string_foreground):
2795 * w32term.c (x_draw_composite_glyph_string_foreground):
2796 * term.c (encode_terminal_code):
2797 * composite.c (composition_update_it, get_composition_id):
2798 * xdisp.c (get_next_display_element)
2799 (fill_composite_glyph_string): Add comments about special meaning
2800 of TAB characters in a composition.
2802 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2804 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2805 This occurs when processing a multibyte format.
2806 Problem reported by Wolfgang Jenker.
2808 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2810 * xdisp.c (try_cursor_movement): Only check for exact match if
2811 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2813 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2815 Remove unused external symbols.
2816 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2817 * xdisp.c (calc_pixel_width_or_height): Now static.
2818 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2819 * indent.c (check_display_width):
2820 * w32term.c: Fix comment to match code.
2821 * xterm.c, xterm.h (x_catching_errors): Remove.
2823 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2825 * xselect.c: Use signed conversions more consistently (Bug#9498).
2826 (selection_data_to_lisp_data): Assume incoming selection data are
2827 signed integers, not unsigned. This is to be consistent with
2828 outgoing selection data, which was modified to use signed integers
2829 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2830 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2831 expects long, not unsigned long.
2833 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2835 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2836 computation of loop end. Reported by Johan Bockgård
2839 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2841 * frame.c (Fother_visible_frames_p): Function deleted.
2843 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2845 * indent.c (compute_motion): Process display vector front to back
2846 rather than the other way around. (Bug#2496)
2848 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2850 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2852 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2854 * minibuf.c (Fread_from_minibuffer): Doc fix.
2856 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2858 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2859 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2861 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2863 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2864 value for non-existent files.
2866 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2868 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2869 set its "size" to -1. This will set the modtime_size field of
2870 the corresponding buffer to -1, which is what
2871 verify-visited-file-modtime expects for files that do not exist.
2874 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2876 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2878 * lisp.h: ... from here. push_key_description is no longer
2879 defined in keyboard.c, so its declaration should not be in
2880 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2881 logically belongs with push_key_description.
2883 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2885 * buffer.h: Include <sys/types.h> instead of <time.h>.
2886 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2887 Problem reported by Herbert J. Skuhra.
2889 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2891 * xml.c (parse_region): Make the parsing work for
2892 non-comment-starting XML files again (bug#9144).
2894 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2896 * image.c (gif_load): Fix calculation of bottom and right corner.
2899 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2901 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2902 redisplay in small windows.
2904 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2906 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2908 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2910 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2911 Operate on live windows only.
2913 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2915 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2917 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2919 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2920 only under bidi iteration.
2922 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2924 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2926 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2928 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2929 Without this fix, the command to link temacs failed due to an
2930 undefined symbol __builtin_isnan. This is because
2931 /usr/include/iso/math_c99.h #defines isnan(x) to
2932 __builtin_isnan(x), but the bundled gcc, which identifies itself
2933 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2935 * floatfns.c (isnan): #undef, and then #define to a clone of
2937 (Fisnan): Always define, since it's always available now.
2938 (syms_of_floatfns): Always define isnan at the Lisp level.
2940 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2942 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2944 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2946 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2947 The previous code assumed that file offsets (off_t values) fit in
2948 EMACS_INT variables, which is not true on typical 32-bit hosts.
2949 The code messed up by falsely reporting buffer overflow in cases
2950 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2951 when "big" contains more than 2**29 bytes, even though this
2952 inserts just one byte and does not overflow the buffer.
2953 (Finsert_file_contents): Store file offsets as off_t
2954 values, not as EMACS_INT values. Check for overflow when
2955 converting between EMACS_INT and off_t. When checking for
2956 buffer overflow or for overlap, take the offsets into account.
2957 Don't use EMACS_INT for small values where int suffices.
2958 When checking for overlap, fix a typo: ZV was used where
2959 ZV_BYTE was intended.
2960 (Fwrite_region): Don't assume off_t fits into 'long'.
2961 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2963 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2965 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2967 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2969 sprintf-related integer and memory overflow issues (Bug#9412).
2971 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2972 (esprintf, exprintf, evxprintf): New functions.
2973 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2974 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2975 (modify_event_symbol): Do not assume that the length of
2976 name_alist_or_stem is safe to alloca and fits in int.
2977 (Fexecute_extended_command): Likewise for function name and binding.
2978 (Frecursion_depth): Wrap around reliably on integer overflow.
2979 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2980 since some callers pass EMACS_INT values.
2981 (Fsingle_key_description): Don't crash if symbol name contains more
2982 than MAX_ALLOCA bytes.
2983 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2984 (get_minibuffer): Arg is now EMACS_INT, not int.
2985 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2986 (esprintf, exprintf, evxprintf): New decls.
2987 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2989 * dbusbind.c (signature_cat): New function.
2990 (xd_signature, Fdbus_register_signal):
2991 Do not overrun buffer; instead, report string overflow.
2993 * dispnew.c (add_window_display_history): Don't overrun buffer.
2994 Truncate instead; this is OK since it's just a log.
2996 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2997 even if the time zone offset is outlandishly large.
2998 Don't mishandle offset == INT_MIN.
3000 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3001 when creating daemon; the previous buffer-overflow check was incorrect.
3003 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3004 which has the guts of the old verror function.
3006 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3007 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3009 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3010 (font_unparse_xlfd): Don't blindly alloca long strings.
3011 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3012 fits in int, when using sprintf. Use single snprintf to count
3013 length of string rather than counting it via multiple sprintfs;
3014 that's simpler and more reliable.
3015 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3016 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3017 sprintf, in case result does not fit in int.
3019 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3020 (fontset_from_font): Print it.
3022 * frame.c (tty_frame_count): Now printmax_t, not int.
3023 (make_terminal_frame, set_term_frame_name): Print it.
3024 (x_report_frame_params): In X, window IDs are unsigned long,
3025 not signed long, so print them as unsigned.
3026 (validate_x_resource_name): Check for implausibly long names,
3027 and don't assume name length fits in 'int'.
3028 (x_get_resource_string): Don't blindly alloca invocation name;
3029 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3032 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3033 (xg_check_special_colors, xg_set_geometry):
3034 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3036 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3037 Use esprintf, not sprintf, in case result does not fit in int.
3039 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3040 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3041 it as a large positive number.
3042 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3043 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3045 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3046 in case result does not fit in int.
3048 * print.c (float_to_string): Detect width overflow more reliably.
3049 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3050 buffer overrun. Don't assume list length fits in 'int'. Treat
3051 print length of 0 as 0, not as infinity; to be consistent with other
3052 uses of print length in this function. Don't overflow print length
3053 index. Don't assume hash table size fits in 'long', or that
3054 vectorlike size fits in 'unsigned long'.
3056 * process.c (make_process): Use printmax_t, not int, to format
3057 process-name gensyms.
3059 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3061 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3062 to avoid potential buffer overrun.
3064 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3065 if X resource line is longer than 512 bytes.
3067 * xfns.c (x_window): Make sprintf buffer a bit bigger
3068 to avoid potential buffer overrun.
3070 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3072 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3074 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3076 Integer overflow fixes for scrolling, etc.
3077 Without these, Emacs silently mishandles large integers sometimes.
3078 For example, "C-u 4294967297 M-x recenter" was treated as if
3079 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3081 * xdisp.c (try_window_id): Check Emacs fixnum range before
3082 converting to 'int'.
3084 * window.c (window_scroll_line_based, Frecenter):
3085 Check that an Emacs fixnum is in range before assigning it to 'int'.
3086 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3087 values converted from Emacs fixnums.
3088 (Frecenter): Don't wrap around a line count if it is out of 'int'
3089 range; instead, treat it as an extreme value.
3090 (Fset_window_configuration, compare_window_configurations):
3091 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3093 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3094 that can exceed INT_MAX. Check that EMACS_INT value is in range
3095 before assigning it to the (possibly-narrower) index.
3096 (match_limit): Don't assume that a fixnum can fit in 'int'.
3098 * print.c (print_object): Use ptrdiff_t, not int, for index that can
3101 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3102 (Fvertical_motion): Don't wrap around LINES values that don't fit
3103 in 'int'. Instead, treat them as extreme values. This is good
3104 enough for windows, which can't have more than INT_MAX lines anyway.
3106 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3108 * Require libxml/parser.h to avoid compilation warning.
3110 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3112 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3113 since this reportedly can destroy thread storage.
3115 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
3117 * syntax.c (find_defun_start): Update all cache variables if
3118 exiting early (Bug#9401).
3120 2011-08-30 Eli Zaretskii <eliz@gnu.org>
3122 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3124 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3125 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3126 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3128 * term.c (tty_append_glyph): New function.
3129 (produce_stretch_glyph): Static function and its prototype deleted.
3131 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3134 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3136 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3137 when checking :margin (Bug#9390).
3138 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3139 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3140 so that the name doesn't mislead. All uses changed.
3142 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3144 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3147 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3149 * xdisp.c (move_it_to): Don't bail out early when reaching
3150 position beyond to_charpos, if we are scanning backwards.
3151 (move_it_vertically_backward): When DY == 0, make sure we get to
3152 the first character in the line after the newline.
3154 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3156 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3157 (ccl_driver): Do not generate an out-of-range pointer.
3158 (Fccl_execute_on_string): Remove unnecessary check for
3159 integer overflow, noted by Stefan Monnier in
3160 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3161 Remove a FIXME that didn't need fixing.
3162 Simplify the newly-introduced buffer reallocation code.
3164 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3166 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3168 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3170 Integer and memory overflow issues (Bug#9196).
3172 * doc.c (get_doc_string): Rework so that
3173 get_doc_string_buffer_size is the actual buffer size, rather than
3174 being 1 less than the actual buffer size; this makes xpalloc more
3177 * image.c (x_allocate_bitmap_record, cache_image):
3178 * xselect.c (Fx_register_dnd_atom):
3179 Simplify previous changes by using xpalloc.
3181 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3182 since either will do and ptrdiff_t is convenient with xpalloc.
3184 * charset.c (charset_table_size)
3185 (struct charset_sort_data.priority): Now ptrdiff_t.
3186 (charset_compare): Don't overflow if priorities differ greatly.
3187 (Fsort_charsets): Don't assume list length fits in int.
3188 Check for size-calculation overflow when allocating sort data.
3189 (syms_of_charset): Allocate an initial charset table that is
3190 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3192 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3194 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3195 The actual value is always <= INT_MAX, and leaving it unsigned made
3196 overflow checking harder.
3198 * dispextern.h (struct glyph_matrix.rows_allocated)
3199 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3200 with xpalloc. The values are still always <= INT_MAX.
3202 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3204 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3205 (SAFE_NALLOCA): New macro.
3207 * region-cache.c (struct boundary.pos, find_cache_boundary)
3208 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3209 (set_cache_region, invalidate_region_cache)
3210 (revalidate_region_cache, know_region_cache, region_cache_forward)
3211 (region_cache_backward, pp_cache):
3212 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3213 so that ptrdiff_t * can be passed to xpalloc.
3214 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3215 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3216 (pp_cache): Don't assume cache_len fits in int.
3217 * region-cache.h: Adjust extern decls to match.
3219 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3220 EMACS_INT, since either will do, for xpalloc.
3222 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3223 (xnmalloc, xnrealloc, xpalloc): New functions.
3225 * bidi.c (bidi_shelve_header_size): New constant.
3226 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3227 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3229 * bidi.c (bidi_cache_shrink):
3230 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3232 Don't update size of array until after memory allocation succeeds,
3233 because xmalloc/xrealloc may not return.
3234 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3235 now that we have proper integer overflow checking.
3236 (record_overlay_string, overlay_strings): Catch overflows when
3237 calculating size of overlay_str_buf.
3239 * callproc.c (Fcall_process): Check for size overflow when
3240 calculating size of args2.
3241 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3242 Normally we prefer signed values, but sticking with ptrdiff_t would
3243 require adding more-complicated checks.
3245 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3246 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3247 Redo buffer-overflow calculations to avoid integer overflow.
3248 Add a FIXME comment where memory seems to be over-allocated.
3250 * character.c (Fstring): Check for size-calculation overflow.
3252 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3253 unnecessary integer overflow. Check for size overflow.
3254 (encode_coding_object): Don't update size until xmalloc succeeds.
3256 * composite.c (get_composition_id): Check for overflow in glyph
3257 length calculations.
3259 Integer and memory overflow fixes for display code.
3260 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3261 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3262 (scrolling_window): Check for overflow in size calculations.
3263 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3264 Don't assume glyph table len fits in int.
3265 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3266 (row_table_size): Now ptrdiff_t, not int.
3267 (scrolling_window): Avoid overflow in size calculations.
3268 Don't update size until allocation succeeds.
3269 * fns.c (concat): Check for overflow in size calculations.
3270 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3271 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3272 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3274 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3275 (get_doc_string): Check for size calculation overflow.
3276 Don't update size until allocation succeeds.
3277 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3278 EMACS_INT, where ptrdiff_t will do.
3279 (Fsubstitute_command_keys): Check for string overflow.
3281 * editfns.c (set_time_zone_rule): Don't assume environment length
3283 (message_length): Now ptrdiff_t, not int.
3284 (Fmessage_box): Don't update size until allocation succeeds.
3285 Don't assume message length fits in int.
3286 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3288 * emacs.c (main): Do not reallocate argv, since there is a null at
3289 the end that can be overwritten, and this way there's no need to
3290 worry about size-calculation overflow.
3291 (sort_args): Check for size-calculation overflow.
3293 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3295 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3297 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3298 (x_set_scroll_bar_width, x_figure_window_size):
3299 Check for integer overflow.
3300 (x_set_alpha): Do not assume XINT fits in int.
3302 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3303 This is for the members text_lines, text_cols, total_lines, total_cols,
3304 where the system imposes an 'int' limit.
3306 * fringe.c (Fdefine_fringe_bitmap):
3307 Don't update size until alloc works.
3309 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3310 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3312 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3313 Check for size-calculation overflow.
3314 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3315 do, as we prefer signed integers.
3316 (id_to_widget.max_size, id_to_widget.used)
3317 (xg_store_widget_in_map, xg_remove_widget_from_map)
3318 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3319 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3320 Use and return ptrdiff_t, not int.
3321 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3322 * gtkutil.h: Change prototypes to match the above.
3324 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3325 are duplicate now that they've been promoted to lisp.h.
3326 (x_allocate_bitmap_record, x_alloc_image_color)
3327 (make_image_cache, cache_image, xpm_load):
3328 Don't update size until alloc is done.
3329 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3331 Check for size calculation overflow.
3332 (ct_colors_allocated_max): New constant.
3333 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3336 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3337 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3338 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3339 Use ptrdiff_t, not int, to count maps.
3340 (read_char_minibuf_menu_prompt): Check for overflow in size
3341 calculations. Don't update size until allocation succeeds.
3342 Redo calculations to avoid overflow.
3343 * keyboard.h: Change prototypes to match the above.
3345 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3347 (current_minor_maps): Check for size calculation overflow.
3348 * keymap.h: Change prototypes to match the above.
3350 * lread.c (read1, init_obarray): Don't update size until alloc done.
3352 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3353 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3355 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3356 Now ptrdiff_t, not int.
3357 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3358 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3360 * process.c (Fnetwork_interface_list): Check for overflow
3361 in size calculation.
3363 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3365 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3366 overflow. Don't bother calling xmalloc when xrealloc will do.
3368 * search.c (Freplace_match): Check for size calculation overflow.
3369 (Fset_match_data): Don't assume list lengths fit in 'int'.
3371 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3372 for command line length. Do not attempt to address one before the
3373 beginning of an array, as that's not portable.
3375 * term.c (max_frame_lines): Remove; unused.
3376 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3378 (encode_terminal_code, calculate_costs): Check for size
3379 calculation overflow.
3380 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3381 table lengths and related sizes. Don't update size until alloc
3382 done. Redo calculations to avoid overflow.
3383 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3385 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3386 subtracting pointers.
3387 (gobble_line): Check for overflow more carefully. Don't update size
3390 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3391 Don't update size until alloc done.
3392 Redo size calculations to avoid overflow.
3393 Check for size calculation overflow.
3394 (main) [DEBUG]: Fix typo in invoking tparam1.
3396 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3397 Use ptrdiff_t, not int, for sizes.
3398 (store_mode_line_noprop_char): Don't update size until alloc done.
3400 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3401 Use ptrdiff_t, not int, for sizes.
3402 (Finternal_make_lisp_face, cache_face):
3403 Check for size calculation overflow.
3404 (cache_face): Treat size calculation overflows as if they were
3405 memory exhaustion (the usual treatment), rather than aborting.
3407 * xfns.c (x_encode_text, x_set_name_internal)
3408 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3409 sizes, since they can exceed INT_MAX in size. Check for size
3410 calculation overflow.
3412 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3413 (xg_select): Check for size calculation overflow.
3414 Don't update size until alloc done.
3416 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3417 as sprintf is limited to int lengths.
3419 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3420 (X_LONG_MIN): New macros.
3421 Use them to make the following changes clearer.
3422 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3423 This change doesn't affect the value now, but it may help remind
3424 future maintainers not to raise the value too much later.
3425 (SELECTION_QUANTUM): Remove, replacing with ...
3426 (selection_quantum): ... new function, which avoids overflow.
3428 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3429 assumption that selection length fits in 'int'.
3430 (x_reply_selection_request, x_handle_selection_request)
3431 (x_get_window_property, receive_incremental_selection)
3432 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3433 (lisp_data_to_selection_data, clean_local_selection_data):
3434 Use ptrdiff_t, not int, to record length of selection.
3435 (x_reply_selection_request, x_get_window_property)
3436 (receive_incremental_selection, x_property_data_to_lisp):
3437 Redo calculations to avoid overflow.
3438 (x_reply_selection_request): When sending hint, ceiling it at
3439 X_LONG_MAX rather than relying on wraparound overflow to send
3441 (x_get_window_property, receive_incremental_selection)
3442 (lisp_data_to_selection_data, x_property_data_to_lisp):
3443 Check for size-calculation overflow.
3444 (x_get_window_property, receive_incremental_selection)
3445 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3446 Don't store size until memory allocation succeeds.
3447 (x_get_window_property): Plug memory leak on memory exhaustion.
3448 Don't double-block input; malloc is safe here. Don't assume 2**34
3449 - 4 fits in unsigned long. Add an xassert to check
3450 XGetWindowProperty overflow. Be more careful about overflow
3451 calculations, and distinguish size from memory overflow better.
3452 (receive_incremental_selection): When tracing, don't assume
3453 unsigned int is less than INT_MAX.
3454 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3455 harmful) conversions of unsigned short to int.
3456 (lisp_data_to_selection_data): Don't assume that integers
3457 in the range -65535 through -1 fit in an X unsigned short.
3458 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3459 result parameters unless successful. Rely on cons_to_unsigned
3460 to report problems with elements; the old code wasn't right anyway.
3461 (x_check_property_data): Check for int overflow; we cannot use
3462 a wider type due to X limits.
3463 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3465 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3467 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3468 (x_term_init): Check for size calculation overflow.
3469 (x_color_cells): Don't store size until memory allocation succeeds.
3470 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3471 Don't assume alloca size is less than MAX_ALLOCA.
3472 (x_term_init): Don't assume length fits in int (sprintf is limited
3475 Use ptrdiff_t for composition IDs.
3476 * character.c (lisp_string_width):
3477 * composite.c (composition_table_size, n_compositions)
3478 (get_composition_id, composition_gstring_from_id):
3479 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3480 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3481 * window.c (Frecenter):
3482 Use ptrdiff_t, not int, for composition IDs.
3483 * composite.c (get_composition_id): Check for integer overflow.
3484 * composite.h: Adjust prototypes to match the above changes.
3486 Use ptrdiff_t for hash table indexes.
3487 * category.c (hash_get_category_set):
3488 * ccl.c (ccl_driver):
3489 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3490 * coding.c (coding_system_charset_list, detect_coding_system):
3491 * coding.h (struct coding_system.id):
3492 * composite.c (get_composition_id, gstring_lookup_cache):
3493 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3494 * image.c (xpm_get_color_table_h):
3495 * lisp.h (hash_lookup, hash_put):
3496 * minibuf.c (Ftest_completion):
3497 Use ptrdiff_t for hash table indexes, not int (which is too
3498 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3499 32-bit --with-wide-int hosts).
3501 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3502 Add a FIXME comment about memory leaks.
3503 (syms_of_charset): Don't assume xmalloc returns.
3505 Don't assume that stated character widths fit in int.
3506 * character.c (Fchar_width, c_string_width, lisp_string_width):
3507 * character.h (CHAR_WIDTH):
3508 * indent.c (MULTIBYTE_BYTES_WIDTH):
3509 Use sanitize_char_width to avoid undefined and/or bad behavior
3510 with outlandish widths.
3511 * character.h (sanitize_tab_width): Rename from sanitize_width,
3512 now that we have two such functions. All uses changed.
3513 (sanitize_char_width): New inline function.
3515 Don't assume that tab-width fits in int.
3516 * character.h (sanitize_width): New inline function.
3517 (SANE_TAB_WIDTH): New macro.
3518 (ASCII_CHAR_WIDTH): Use it.
3519 * indent.c (sane_tab_width): Remove. All uses replaced by
3520 SANE_TAB_WIDTH (current_buffer).
3521 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3523 * fileio.c: Integer overflow issues with file modes.
3524 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3526 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3527 Remove unreachable code.
3528 (read_hex, load_charset_map_from_file): Check for integer overflow.
3530 * xterm.c: Don't go over XClientMessageEvent limit.
3531 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3532 (x_send_scroll_bar_event): Likewise. Check that the size does not
3533 exceed limits imposed by XClientMessageEvent, as well as the usual
3534 ptrdiff_t and size_t limits.
3536 * keyboard.c: Overflow, signedness and related fixes.
3537 (make_lispy_movement): Use same integer type in forward decl
3538 that is used in the definition.
3539 (read_key_sequence, keyremap_step):
3540 Change bufsize argument back to int, undoing my 2011-03-30 change.
3541 We prefer signed types, and int is wide enough here.
3542 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3543 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3544 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3545 length, not size_t. Use ptrdiff_t for index, not int.
3546 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3547 possibility of integer overflow.
3549 Overflow, signedness and related fixes for images.
3551 * dispextern.h (struct it.stack[0].u.image.image_id)
3552 (struct_it.image_id, struct image.id, struct image_cache.size)
3553 (struct image_cache.used, struct image_cache.ref_count):
3554 * gtkutil.c (update_frame_tool_bar):
3555 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3556 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3557 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3558 * nsmenu.m (update_frame_tool_bar):
3559 * xdisp.c (calc_pixel_width_or_height):
3560 * xfns.c (image_cache_refcount):
3561 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3562 on typical 64-bit hosts.
3564 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3565 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3566 Omit unnecessary casts to int.
3567 (parse_image_spec): Check that integers fall into 'int' range
3568 when the callers expect that.
3569 (image_ascent): Redo ascent calculation to avoid int overflow.
3570 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3571 (lookup_image): Remove unnecessary tests.
3572 (xbm_image_p): Locals are now of int, not EMACS_INT,
3573 since parse_image_check makes sure they fit into int.
3574 (png_load, gif_load, svg_load_image):
3575 Prefer int to unsigned where either will do.
3576 (tiff_handler): New function, combining the cores of the
3577 old tiff_error_handler and tiff_warning_handler.
3578 This function is rewritten to use vsnprintf and thereby avoid
3579 stack buffer overflows. It uses only the features of vsnprintf
3580 that are common to both POSIX and native Microsoft.
3581 (tiff_error_handler, tiff_warning_handler): Use it.
3582 (tiff_load, gif_load, imagemagick_load_image):
3583 Don't assume :index value fits in 'int'.
3584 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3585 (imagemagick_load_image): Check that crop parameters fit into
3586 the integer types that MagickCropImage accepts. Don't assume
3587 Vimagemagick_render_type has a nonnegative value. Don't assume
3588 size_t fits in 'long'.
3589 (gs_load): Use printmax_t to print the widest integers possible.
3590 Check for integer overflow when computing image height and width.
3592 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3594 * xdisp.c (redisplay_window): Don't force window start if point
3595 will be invisible in the resulting window. (Bug#9324)
3597 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3599 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3600 the display spec is of the form `(space ...)'.
3601 (handle_display_spec): Return the value returned by
3602 handle_single_display_spec, not just 1 or zero.
3603 (handle_single_display_spec): If the display spec is of the form
3604 `(space ...)', and specifies display in the text area, return 2
3606 (try_cursor_movement): Check for the need to scroll more
3607 accurately, and prefer exact match for point under bidi.
3608 Don't advance `row' beyond the last row of the window.
3610 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3611 into disp_prop; all users changed.
3613 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3614 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3615 for the text covered by the display property.
3617 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3619 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3620 Change return value to nil.
3621 (Frecord_buffer): Delete unused function.
3623 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3625 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3626 buffers, return left-to-right.
3627 (set_cursor_from_row): Consider candidate row a win if its glyph
3628 represents a newline and point is on that newline. Fixes cursor
3629 positioning on the newline at EOL of R2L text within L2R
3630 paragraph, and vice versa.
3631 (try_cursor_movement): Check continued rows, in addition to
3632 continuation rows. Fixes unwarranted scroll when point enters a
3633 continued line of R2L text within an L2R paragraph, or vice versa.
3634 (cursor_row_p): Consider the case of point being equal to
3635 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3636 from the end of a short line to the beginning of a continued line
3637 of R2L text within L2R paragraph.
3638 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3639 composed characters.
3641 * bidi.c (bidi_check_type): Use xassert.
3642 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3645 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3647 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3650 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3652 * nsfont.m (ns_otf_to_script): Fix typo.
3654 2011-08-22 Kenichi Handa <handa@m17n.org>
3656 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3657 extra slot even if the purpose is char-code-property-table.
3659 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3661 * xdisp.c (redisplay_window): When computing centering_position,
3662 account for the height of the header line. (Bug#8874)
3664 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3665 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3666 candidate is selected by the mouse, and that candidate has a
3667 composed character under the mouse.
3669 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3670 coordinates reported by pos-visible-in-window-p for a composed
3671 character in column zero.
3673 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3675 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3677 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3679 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3680 consider it a hit if to_charpos is anywhere in the range of the
3681 composed buffer positions.
3683 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3685 * image.c (gif_load): Don't assume that each subimage has the same
3686 dimensions as the base image. Handle disposal method that is
3687 "undefined" by the gif spec (Bug#9335).
3689 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3691 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3692 (Fcondition_case): Document `debug' symbol in error handler.
3694 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3696 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3697 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3698 from an Org mode buffer to a Speedbar frame.
3700 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3701 a composition, take its buffer position from IT->cmp_it.charpos.
3702 Fixes cursor positioning at the beginning of a line that begins
3703 with a composed character.
3705 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3707 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3708 character bidirectional type, use STRONG_L instead. Fixes crashes
3709 in a buffer produced by `describe-categories'.
3711 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3712 members before the level stack, so they would be saved and
3713 restored when copying iterator state. Fixes incorrect reordering
3714 around TABs covered by display properties.
3716 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3718 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3720 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3722 * eval.c (internal_condition_case, internal_condition_case_1)
3723 (internal_condition_case_2, internal_condition_case_n):
3724 Remove unnecessary aborts (Bug#9081).
3726 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3728 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3729 has no `load' handler, try opening the file locally. (Bug#9311)
3731 2011-08-16 Ken Brown <kbrown@cornell.edu>
3733 * gmalloc.c: Expand comment.
3735 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3737 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3738 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3740 2011-08-16 Ken Brown <kbrown@cornell.edu>
3742 Fix memory allocation problems in Cygwin build (Bug#9273).
3744 * unexcw.c ( __malloc_initialized): Declare external variable.
3745 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3747 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3749 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3751 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3753 [CYGWIN] (special_realloc): New function.
3754 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3755 requests to realloc storage in the static heap.
3757 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3759 * bidi.c (bidi_initialize): Remove unused local.
3761 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3764 * biditype.h: Remove file.
3765 * makefile.w32-in ($(BLD)/bidi.$(O)):
3766 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3768 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3770 * chartab.c: Improve commentary for the uniprop_table API.
3772 * bidi.c (bidi_paragraph_init): Support zero value of
3773 bidi_ignore_explicit_marks_for_paragraph_level.
3774 (bidi_initialize): Use uniprop_table instead of including
3775 biditype.h and bidimirror.h.
3777 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3778 coordinates of the iterator when restoring from ppos_it.
3781 2011-08-14 Kenichi Handa <handa@m17n.org>
3783 * process.c (create_process): Call setup_process_coding_systems
3784 after the pid of the process is set to -1 (Bug#8162).
3786 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3788 * xdisp.c (move_it_in_display_line_to): Don't invoke
3789 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3790 ppos_it. Fixes vertical cursor motion when line beginning is
3791 covered by an image. (Bug#9296)
3793 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3795 * nsterm.h (ns_run_ascript): Declare.
3796 (NSAPP_DATA2_RUNASSCRIPT): Define.
3798 * nsfns.m (as_script, as_result, as_status): New static variables.
3799 (ns_run_ascript): New function.
3800 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3801 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3802 the event loop. Get status from as_status (Bug#7276).
3804 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3805 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3806 the event loop (Bug#7276).
3808 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3810 * gnutls.c (QCgnutls_bootprop_priority)
3811 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3812 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3813 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3814 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3815 (QCgnutls_bootprop_verify_hostname_error)
3816 (QCgnutls_bootprop_callbacks_verify): Rename from
3817 Qgnutls_bootprop_..., all uses changed.
3819 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3822 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3824 * xfaces.c (Qframe_set_background_mode): Now static.
3825 * dispextern.h (Qframe_set_background_mode): Remove decl.
3827 * process.c (Fnetwork_interface_info): Declare local only if needed.
3829 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3831 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3832 (Fnetwork_interface_list): Allocate in increments of bytes instead
3833 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3834 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3836 (struct ifflag_def): notrailers is smart on OSX.
3837 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3838 Get hardware address with getifaddrs if available.
3840 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3842 * xdisp.c (iterate_out_of_display_property): xassert that
3843 IT->position is set to within IT->object's boundaries. Break from
3844 the loop as soon as EOB is reached; avoids infloops in redisplay
3845 when IT->position is set up wrongly due to some bug.
3846 Set IT->current to match the bidi iterator unconditionally.
3847 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3848 entry. Force push_it to save on the stack the current
3849 buffer/string position, to be restored by pop_it. Fix flags in
3850 the iterator structure wrt the object coming from a display
3851 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3852 properties. (Bug#9284)
3854 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3856 * fontset.c (fontset_get_font_group): Add proper type checks.
3859 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3861 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3862 and LC_VERSION_MIN_MACOSX.
3863 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3864 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3866 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3868 * xdisp.c (forward_to_next_line_start): Allow to use the
3869 no-display-properties-and-no-overlays under bidi display.
3870 Set disp_pos in the bidi iterator to avoid searches for display
3871 properties and overlays.
3873 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3875 * editfns.c (Fset_time_zone_rule): Document relationship with the
3878 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3879 the font entity extracted from the cache (Bug#8109).
3881 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3883 * composite.c (autocmp_chars): Don't reset point. That is done by
3884 restore_point_unwind (Bug#5984).
3886 2011-08-07 Juri Linkov <juri@jurta.org>
3888 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3889 to show the arg `TIME' instead of `TIMEVAL'.
3891 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3893 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3894 display property strides EOL and includes a newline, as in
3895 longlines-mode. (Bug#9254)
3896 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3897 word-wrap under bidirectional display. (Bug#9224)
3899 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3900 is non-zero, even if the data buffer is NULL. Fixes a crash in
3901 vertical-motion with longlines-mode. (Bug#9254)
3903 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3905 * bidi.c <bidi_cache_total_alloc>: Now static.
3906 (bidi_initialize): Initialize bidi_cache_total_alloc.
3908 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3911 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3912 amount allocated this far in `bidi_cache_total_alloc'.
3913 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3914 non-zero, only free the data buffer without restoring the cache
3915 contents. All callers changed.
3917 * dispextern.h (bidi_unshelve_cache): Update prototype.
3919 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3920 (move_it_in_display_line, move_it_to)
3921 (move_it_vertically_backward, move_it_by_lines): Replace the call
3922 to xfree to an equivalent call to bidi_unshelve_cache.
3923 (move_it_in_display_line_to): Fix logic of returning
3924 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3926 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3928 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3929 came from a string character with a `cursor' property. (Bug#9229)
3931 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3933 * Makefile.in (LIB_PTHREAD): New variable.
3934 (LIBES): Add LIB_PTHREAD (Bug#9216).
3936 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3937 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3939 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3941 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3943 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3945 * xterm.c (x_find_topmost_parent): New function.
3946 (x_set_frame_alpha): Find topmost parent window with
3947 x_find_topmost_parent and set the property there also (bug#9181).
3948 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3950 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3952 * callproc.c (Fcall_process): Avoid vfork clobbering
3953 the local vars buffer, coding_systems, current_dir.
3955 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3957 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3959 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3961 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3962 so that it is not optimized away.
3964 * xdisp.c (compute_display_string_pos): Remove unused local.
3966 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3968 Fix slow cursor motion and scrolling in large buffers with
3969 selective display, like Org Mode buffers. (Bug#9218)
3971 * dispextern.h (struct bidi_it): New member disp_prop_p.
3973 * xdisp.c: Remove one-slot cache of display string positions.
3974 (compute_display_string_pos): Accept an additional argument
3975 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3976 for a display string or property. If found, set DISP_PROP_P
3979 * bidi.c (bidi_fetch_char): Accept an additional argument
3980 DISP_PROP_P, and pass it to compute_display_string_pos.
3981 Only handle text covered by a display string if DISP_PROP_P is returned
3982 non-zero. All callers of bidi_fetch_char changed.
3984 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3986 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3988 2010-12-03 Don March <don@ohspite.net>
3990 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3991 last character M-[char] is translated to ESC [char] (bug#7541).
3993 2011-08-02 Kenichi Handa <handa@m17n.org>
3995 * lisp.h (uniprop_table): Extern it.
3997 * chartab.c (uniprop_table): Make it non-static.
3999 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4001 * xdisp.c (forward_to_next_line_start): Accept additional argument
4002 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4004 (reseat_at_next_visible_line_start): Use the bidi iterator state
4005 returned by forward_to_next_line_start to restore the state of
4006 it->bidi_it after backing up to previous newline. (Bug#9212)
4008 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4010 * regex.c (re_comp): Protoize.
4011 (re_exec): Fix return type.
4012 (regexec): Fix type of `ret'. (Bug#9203)
4014 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4016 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4017 This is needed if max-image-size is a floating-point number.
4019 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4021 * print.c (print_object): Print empty symbol as ##.
4023 * lread.c (read1): Read ## as empty symbol.
4025 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4027 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4028 setting frame foreground color (Bug#9175).
4029 (x_set_background_color): Likewise.
4031 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4032 contents (Bug#9176).
4033 (EmacsTooltip -init): Remove bezels and add shadows to
4036 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4037 or scroll bar (Bug#8470).
4039 * nsfont.m (nsfont_open): Remove assignment to voffset and
4040 unnecessary vars hshink, expand, hd, full_height, min_height.
4041 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4043 * nsterm.h (nsfont_info): Remove voffset field.
4045 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4047 Implement strike-through and overline on NextStep (Bug#8863).
4049 * nsfont.m (nsfont_open): Use underline position provided by font,
4050 instead of hard-coded value of 2.
4051 (nsfont_draw): Call ns_draw_text_decoration instead.
4053 * nsterm.h: Add declaration for ns_draw_text_decoration.
4055 * nsterm.m (ns_draw_text_decoration): New function for drawing
4056 underline, overline, and strike-through.
4057 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4058 ns_draw_text_decoration. Change treatment of cursor drawing to
4059 accommodate underlining, etc.
4061 2011-07-28 Eli Zaretskii <eliz@gnu.org>
4063 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4066 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4068 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4069 Without this fix, if a signal arrives just after memory fills up,
4070 'malloc' might be invoked reentrantly.
4072 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4073 In other words, assume that every image size is allowed, on non-X
4074 hosts. This assumption is probably wrong, but it lets Emacs compile.
4076 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4078 * regex.c (re_iswctype): Convert return values to boolean.
4080 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4082 * xdisp.c (compute_display_string_pos): Don't use cached display
4083 string position if the buffer had its restriction changed.
4086 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4088 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4090 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4092 Integer signedness and overflow and related fixes. (Bug#9079)
4094 * bidi.c: Integer size and overflow fixes.
4095 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4096 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4097 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4098 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4099 (bidi_find_other_level_edge):
4100 Use ptrdiff_t instead of EMACS_INT where either will do.
4101 This works better on 32-bit hosts configured --with-wide-int.
4102 (bidi_cache_ensure_space): Check for size-calculation overflow.
4103 Use % rather than repeated addition, for better worst-case speed.
4104 Don't set bidi_cache_size until after xrealloc returns, because it
4106 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4107 (bidi_cache_ensure_space): Also check that the bidi cache size
4108 does not exceed that of the largest Lisp string or buffer. See Eli
4109 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4111 * alloc.c (__malloc_size_t): Remove.
4112 All uses replaced by size_t. See Andreas Schwab's note
4113 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4115 * image.c: Improve checking for integer overflow.
4116 (check_image_size): Assume that f is nonnull, since
4117 it is always nonnull in practice. This is one less thing to
4118 worry about when checking for integer overflow later.
4119 (x_check_image_size): New function, which checks for integer
4120 overflow issues inside X.
4121 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4122 This removes the need for a memory_full check.
4123 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4124 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4125 (xbm_read_bitmap_data): Change locals back to 'int', since
4126 their values must fit in 'int'.
4127 (xpm_load_image, png_load, tiff_load):
4128 Invoke x_create_x_image_and_pixmap earlier,
4129 to avoid much needless work if the image is too large.
4130 (tiff_load): Treat overly large images as if
4131 x_create_x_image_and_pixmap failed, not as malloc failures.
4132 (gs_load): Use x_check_image_size.
4134 * gtkutil.c: Omit integer casts.
4135 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4136 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4138 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4140 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4141 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4142 would wrongly return t on a 64-bit host.
4144 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4145 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4146 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4147 and therefore cause GCC to emit a bogus diagnostic in some cases.
4149 * image.c: Integer signedness and overflow and related fixes.
4150 This is not an exhaustive set of fixes, but it's time to
4151 record what I've got.
4152 (lookup_pixel_color, check_image_size): Remove redundant decls.
4153 (check_image_size): Don't assume that arbitrary EMACS_INT values
4154 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4155 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4156 (tiff_load, imagemagick_load_image):
4157 Check for overflow in size calculations.
4158 (x_create_x_image_and_pixmap): Remove unnecessary test for
4159 xmalloc returning NULL; that can't happen.
4160 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4161 (xpm_color_bucket): Use better integer hashing function.
4162 (xpm_cache_color): Don't possibly over-allocate memory.
4163 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4164 (gif_memory_source):
4165 Use ptrdiff_t, not int or size_t, to record sizes.
4166 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4167 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4168 either works, as we prefer signed integers.
4169 (tiff_read_from_memory, tiff_write_from_memory):
4170 Return tsize_t, not size_t, since that's what the TIFF API wants.
4171 (tiff_read_from_memory): Don't fail simply because the read would
4172 go past EOF; instead, return a short read.
4173 (tiff_load): Omit no-longer-needed casts.
4174 (Fimagemagick_types): Don't assume size fits into 'int'.
4176 Improve hashing quality when configured --with-wide-int.
4177 * fns.c (hash_string): New function, taken from sxhash_string.
4178 Do not discard information about ASCII character case; this
4179 discarding is no longer needed.
4180 (sxhash-string): Use it. Change sig to match it. Caller changed.
4181 * lisp.h: Declare it.
4182 * lread.c (hash_string): Remove, since we now use fns.c's version.
4183 The fns.c version returns a wider integer if --with-wide-int is
4184 specified, so this should help the quality of the hashing a bit.
4186 * emacs.c: Integer overflow minor fix.
4187 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4188 Define only if GNU_LINUX.
4189 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4191 * dispnew.c: Integer signedness and overflow fixes.
4192 Remove unnecessary forward decls, that were a maintenance hassle.
4193 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4195 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4196 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4197 (prepare_desired_row, line_draw_cost):
4198 Use int, not unsigned, where either works.
4199 (save_current_matrix, restore_current_matrix):
4200 Use ptrdiff_t, not size_t, where either works.
4201 (init_display): Check for overflow more accurately, and without
4202 relying on undefined behavior.
4204 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4205 Remove, replacing with the new symbols in lisp.h. All uses changed.
4206 * fileio.c (make_temp_name):
4207 * filelock.c (lock_file_1, lock_file):
4208 * xdisp.c (message_dolog):
4209 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4210 Use pMd etc. instead.
4211 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4212 replacing the pWIDE etc. symbols removed from editfns.c.
4214 * keyboard.h (num_input_events): Now uintmax_t.
4215 This is (very slightly) less likely to mess up due to wraparound.
4218 * buffer.c: Integer signedness fixes.
4219 (alloc_buffer_text, enlarge_buffer_text):
4220 Use ptrdiff_t rather than size_t when either will do, as we prefer
4223 * alloc.c: Integer signedness and overflow fixes.
4224 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4225 (__malloc_size_t): Default to size_t, not to int.
4226 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4227 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4228 Prefer ptrdiff_t to size_t when either would do, as we prefer
4230 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4231 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4232 Now const. Initialize with values that are in range even if char
4234 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4235 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4236 These functions do the right thing with sizes > 2**32.
4237 (check_depth): Now ptrdiff_t, not int.
4238 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4239 Adjust to new way of storing sizes. Check for size overflow bugs
4241 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4242 slightly wrong anyway, as it missed one instance of
4243 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4244 (refill_memory_reserve): Omit needless cast to size_t.
4245 (mark_object_loop_halt): Mark as externally visible.
4247 * xselect.c: Integer signedness and overflow fixes.
4248 (Fx_register_dnd_atom, x_handle_dnd_message):
4249 Use ptrdiff_t, not size_t, since we prefer signed.
4250 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4251 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4252 x_dnd_atoms_size and x_dnd_atoms_length.
4254 * doprnt.c: Prefer signed to unsigned when either works.
4256 * doprnt.c (doprnt):
4258 * xdisp.c (vmessage):
4259 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4260 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4261 prefer signed arithmetic to avoid comparison confusion.
4262 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4263 but is a bit tricky.
4265 Assume freestanding C89 headers, string.h, stdlib.h.
4266 * data.c, doprnt.c, floatfns.c, print.c:
4267 Include float.h unconditionally.
4268 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4269 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4270 * regex.c: Likewise for stddef.h, string.h.
4271 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4272 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4273 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4274 (STDC_HEADERS): Remove obsolete defines.
4275 * sysdep.c: Include limits.h unconditionally.
4277 Assume support for memcmp, memcpy, memmove, memset.
4278 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4279 * regex.c (memcmp, memcpy):
4280 Remove; we assume C89 now.
4282 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4283 (__malloc_safe_bcopy): Remove; no longer needed.
4285 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4286 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4287 well either way, and we prefer signed to unsigned.
4289 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4291 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4292 closes the connection while we're reading (bug#9182).
4294 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4296 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4297 are specified (Bug#9168).
4299 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4301 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4302 Found by GCC static checking and --with-wide-int on a 32-bit host.
4304 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4306 * xdisp.c (compute_display_string_pos): Fix logic of caching
4307 previous display string position. Initialize cached_prev_pos to
4308 -1. Fixes slow-down at the beginning of a buffer.
4310 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4312 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4313 for attrs[LFACE_FONTSET_INDEX].
4315 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4317 * xml.c (parse_region): Remove unused local
4318 that was recently introduced.
4320 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4322 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4323 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4325 * xdisp.c (move_it_in_display_line_to): Record the best matching
4326 position for TO_CHARPOS while scanning the line, and restore it on
4327 exit if none of the characters scanned was an exact match.
4328 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4329 when exact match is impossible due to invisible text, and the
4330 lines are truncated.
4332 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4334 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4337 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4339 Fix a significant slow-down of cursor motion with C-n, C-p,
4340 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4341 auto-repeat under bidi redisplay in fontified buffers.
4342 * xdisp.c (compute_stop_pos_backwards): New function.
4343 (next_element_from_buffer): Call compute_stop_pos_backwards to
4344 find a suitable prev_stop when we find ourselves before
4346 (reseat): Don't look for prev_stop, as that could mean a very long
4348 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4349 <cached_disp_overlay_modiff>: Cache for last found display string
4351 (compute_display_string_pos): Return the cached position if asked
4352 about the same buffer in the same area of character positions, and
4353 the buffer wasn't changed since the time the display string
4354 position was cached.
4356 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4358 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4359 is an integer, which is important for empty lines. (Bug#9149)
4361 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4363 * frame.c (Fmodify_frame_parameters): In tty case, update the
4364 default face if necessary (Bug#4238).
4366 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4368 * editfns.c (Fstring_to_char): No need to explain what a character
4369 is in the docstring (Bug#6576).
4371 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4373 * xml.c (parse_region): Make sure we always return a tree.
4375 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4377 * xml.c (parse_region): If a document contains only comments,
4380 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4382 * xml.c (make_dom): Return comments, too.
4384 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4387 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4388 and the surrounding thread.
4389 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4390 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4391 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4393 * s/openbsd.h (BROKEN_SIGIO): Define.
4394 * unexelf.c (unexec) [__OpenBSD__]:
4395 Don't update the .mdebug section of the Alpha COFF symbol table.
4397 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4399 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4402 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4404 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4405 This fixes some race conditions on the permissions of any newly
4408 * alloc.c (valid_pointer_p): Use pipe, not open.
4409 This fixes some permissions issues when debugging.
4411 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4412 If fchown fails to set both uid and gid, try to set just gid,
4413 as that is sometimes allowed. Adjust the file's mode to eliminate
4414 setuid or setgid bits that are inappropriate if fchown fails.
4416 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4418 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4419 to compare Lisp_Objects.
4420 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4421 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4422 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4424 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4426 * lread.c (read_integer): Unread even EOF character.
4427 (read1): Likewise. Properly record start position of symbol.
4429 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4430 symbol character follows.
4432 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4434 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4435 This works around a problem with the previous change to Fcopy_file.
4436 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4437 and without this change, GCC might complain about discarding
4438 fchown's return value.
4440 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4442 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4444 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4446 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4448 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4450 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4451 it's used from the C level.
4453 * process.c: Use the same condition for POLL_FOR_INPUT in both
4454 keyboard.c and process.c (bug#1858).
4456 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4458 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4459 (Fgnutls_boot): Use it.
4461 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4463 * doc.c (Fsubstitute_command_keys): Revert last change.
4465 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4467 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4468 quotes the next character, and doesn't affect other longer
4469 sequences (bug#8935).
4471 * lread.c (syms_of_lread): Clarify that is isn't only
4472 `eval-buffer' and `eval-defun' that's affected by
4473 `lexical-binding' (bug#8460).
4475 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4477 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4478 bidi redisplay when a line includes both an image and is truncated.
4480 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4482 Fix minor problems found by static checking.
4483 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4484 (elsz): Now a signed constant, not a size_t var. We prefer signed
4485 types to unsigned, to avoid integer comparison confusion. Without
4486 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4487 "cannot optimize loop, the loop counter may overflow", a symptom
4489 * indent.c (Fvertical_motion): Mark locals as initialized.
4490 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4492 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4494 * search.c (Fre_search_backward): Mention `case-fold-search' in
4495 all the re_search_* functions (bug#8138).
4497 * keyboard.c (Fopen_dribble_file): Document when the file is
4500 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4502 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4505 Support bidi reordering of display and overlay strings.
4506 * xdisp.c (compute_display_string_pos)
4507 (compute_display_string_end): Accept additional argument STRING.
4508 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4509 (reseat_to_string): Initialize bidi_it->string.s and
4510 bidi_it->string.schars.
4511 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4512 NULL (avoids a crash in bidi_paragraph_init).
4513 Initialize itb.string.lstring.
4514 (init_iterator): Call bidi_init_it only of a valid
4515 buffer position was specified. Initialize paragraph_embedding to
4517 (reseat_to_string): Initialize the bidi iterator.
4518 (display_string): If we need to ignore text properties of
4519 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4520 original value of -1 will not work with bidi.)
4521 (compute_display_string_pos): First arg is now struct
4522 `text_pos *'; all callers changed. Support display properties on
4524 (compute_display_string_end): Support display properties on Lisp
4526 (init_iterator, reseat_1, reseat_to_string): Initialize the
4527 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4528 when iterating on a string not from display properties).
4529 (compute_display_string_pos, compute_display_string_end):
4530 Fix calculation of the object to scan. Fixes an error when using
4532 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4533 base_level_stop; instead, set base_level_stop to BEGV.
4534 Fixes crashes in vertical-motion.
4535 (next_element_from_buffer): Improve commentary for when
4536 the iterator is before prev_stop.
4537 (init_iterator): Initialize bidi_p from the default value of
4538 bidi-display-reordering, not from buffer-local value. Use the
4539 buffer-local value only if initializing for buffer iteration.
4540 (handle_invisible_prop): Support invisible properties on strings
4541 that are being bidi-reordered.
4542 (set_iterator_to_next): Support bidi reordering of C strings and
4544 (next_element_from_string): Support bidi reordering of Lisp
4546 (handle_stop_backwards): Support Lisp strings as well.
4547 (display_string): Support display of R2L glyph rows.
4548 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4549 (init_iterator): Don't initialize it->bidi_p for strings
4551 (reseat_to_string): Initialize it->bidi_p for strings here.
4552 (next_element_from_string, next_element_from_c_string)
4553 (next_element_from_buffer): Add xassert's for correspondence
4554 between IT's object being iterated and it->bidi_it.string
4556 (face_before_or_after_it_pos): Support bidi iteration.
4557 (next_element_from_c_string): Handle the case of the first string
4558 character that is not the first one in the visual order.
4559 (get_visually_first_element): New function, refactored from common
4560 parts of next_element_from_buffer, next_element_from_string, and
4561 next_element_from_c_string.
4562 (tool_bar_lines_needed, redisplay_tool_bar)
4563 (display_menu_bar): Force left-to-right direction. Add a FIXME
4564 comment for making that be controlled by a user option.
4565 (push_it, pop_it): Save and restore the state of the
4566 bidi iterator. Save and restore the bidi_p flag.
4567 (pop_it): Iterate out of display property for string iteration as
4569 (iterate_out_of_display_property): Support iteration over strings.
4570 (handle_single_display_spec): Set up it->bidi_it for iteration
4571 over a display string, and call bidi_init_it.
4572 (handle_single_display_spec, next_overlay_string)
4573 (get_overlay_strings_1, push_display_prop): Set up the bidi
4574 iterator for displaying display or overlay strings.
4575 (forward_to_next_line_start): Don't use the shortcut if
4577 (back_to_previous_visible_line_start): If handle_display_prop
4578 pushed the iterator stack, restore the internal state of the bidi
4579 iterator by calling bidi_pop_it same number of times.
4580 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4581 and we are bidi-iterating, don't decrement the iterator position;
4582 instead, set the first_elt flag in the bidi iterator, to produce
4584 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4585 (push_display_prop): xassert that we are iterating a buffer.
4586 (push_it, pop_it): Save and restore paragraph_embedding member.
4587 (handle_single_display_spec, next_overlay_string)
4588 (get_overlay_strings_1, reseat_1, reseat_to_string)
4589 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4590 correctly. Don't assume unibyte strings are not bidi-reordered.
4591 (compute_display_string_pos)
4592 (compute_display_string_end): Fix handling the case of C string.
4593 (push_it, pop_it): Save and restore from_disp_prop_p.
4594 (handle_single_display_spec, push_display_prop): Set the
4595 from_disp_prop_p flag.
4596 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4597 (pop_it): Call iterate_out_of_display_property only if we are
4598 popping after iteration over a string that came from a display
4599 property. Fix a typo in popping stretch info. Add an assertion
4600 for verifying that the iterator position is in sync with the bidi
4602 (handle_single_display_spec, get_overlay_strings_1)
4603 (push_display_prop): Fix initialization of paragraph direction for
4604 string when that of the parent object is not yet determined.
4605 (reseat_1): Call bidi_init_it to resync the bidi
4606 iterator with IT's position. (Bug#7616)
4607 (find_row_edges): If ROW->start.pos gives position
4608 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4609 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4610 Reset the from_disp_prop_p flag.
4611 (SAVE_IT, RESTORE_IT): New macros.
4612 (pos_visible_p, face_before_or_after_it_pos)
4613 (back_to_previous_visible_line_start)
4614 (move_it_in_display_line_to, move_it_in_display_line)
4615 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4616 (try_scrolling, redisplay_window, display_line): Use them when
4617 saving a temporary copy of the iterator and restoring it back.
4618 (back_to_previous_visible_line_start, reseat_1)
4619 (init_iterator): Empty the bidi cache "stack".
4620 (move_it_in_display_line_to): If iterator ended up at
4621 EOL, but we never saw any buffer positions smaller than
4622 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4623 motion in bidi-reordered lines.
4624 (move_it_in_display_line_to): Record prev_method and prev_pos
4625 immediately before the call to set_iterator_to_next. Fixes cursor
4626 motion in bidi-reordered lines with stretch glyphs and strings
4627 displayed in margins. (Bug#8133) (Bug#8867)
4628 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4630 (pos_visible_p): Support positions in bidi-reordered lines.
4631 Save and restore bidi cache.
4633 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4634 (bidi_paragraph_info): Delete unused struct.
4635 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4636 (bidi_cache_start): New variable.
4637 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4639 (bidi_cache_fetch_state, bidi_cache_search)
4640 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4641 (bidi_cache_find, bidi_peek_at_next_level)
4642 (bidi_level_of_next_char, bidi_find_other_level_edge)
4643 (bidi_move_to_visually_next): Compare cache index with
4644 bidi_cache_start rather than with zero.
4645 (bidi_fetch_char): Accept new argument STRING; all callers
4646 changed. Support iteration over a string. Support strings with
4647 display properties. Support unibyte strings. Fix the type of
4648 `len' according to what STRING_CHAR_AND_LENGTH expects.
4649 (bidi_paragraph_init, bidi_resolve_explicit_1)
4650 (bidi_resolve_explicit, bidi_resolve_weak)
4651 (bidi_level_of_next_char, bidi_move_to_visually_next):
4652 Support iteration over a string.
4653 (bidi_set_sor_type, bidi_resolve_explicit_1)
4654 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4655 can now be zero (for strings); special values 0 and -1 were
4656 changed to -1 and -2, respectively.
4657 (bidi_char_at_pos): New function.
4658 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4659 Call it instead of FETCH_MULTIBYTE_CHAR.
4660 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4661 initialized to valid values.
4662 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4664 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4665 the test for valid cached positions. Fix the logic for looking up
4666 the sentinel state in the cache. GCPRO the Lisp string we are
4668 (bidi_push_it, bidi_pop_it): New functions.
4669 (bidi_initialize): Initialize the bidi cache start stack pointer.
4670 (bidi_cache_ensure_space): New function, refactored from part of
4671 bidi_cache_iterator_state. Don't assume the required size is just
4672 one BIDI_CACHE_CHUNK away.
4673 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4674 (bidi_count_bytes, bidi_char_at_pos): New functions.
4675 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4676 always valid if bidi_cache_idx is valid.
4677 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4678 is valid if it's going to be used.
4679 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4680 (bidi_cache_fetch_state, bidi_cache_search)
4681 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4682 (bidi_cache_iterator_state, bidi_cache_find)
4683 (bidi_find_other_level_edge, bidi_cache_start_stack):
4684 All variables related to cache indices are now EMACS_INT.
4686 * dispextern.h (struct bidi_string_data): New structure.
4687 (struct bidi_it): New member `string'. Make flag members be 1-bit
4688 fields, and put them last in the struct.
4689 (compute_display_string_pos, compute_display_string_end):
4691 (bidi_push_it, bidi_pop_it): Add prototypes.
4692 (struct iterator_stack_entry): New members bidi_p,
4693 paragraph_embedding, and from_disp_prop_p.
4694 (struct it): Member bidi_p is now a bit field 1 bit wide.
4695 (bidi_shelve_cache, bidi_unshelve_cache):
4698 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4699 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4700 and vector-like objects.
4702 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4703 cache around display iteration.
4705 * window.c (Fwindow_end, window_scroll_pixel_based)
4706 (displayed_window_lines, Frecenter): Save and restore the bidi
4707 cache around display iteration.
4709 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4711 * editfns.c (Fdelete_region): Clarify the use of the named
4712 parameters (bug#6788).
4714 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4716 * indent.c (Fvertical_motion): Set and restore w->pointm when
4717 saving and restoring the window's buffer (Bug#9006).
4719 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4721 * editfns.c (Fstring_to_char): Clarify just what is returned
4722 (bug#6576). Text by Eli Zaretskii.
4724 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4726 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4728 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4730 * buffer.c (mmap_find): Fix a typo.
4732 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4734 Fix execution of x selection hooks.
4735 * xselect.c (Qx_lost_selection_functions)
4736 (Qx_sent_selection_functions): New vars.
4737 (syms_of_xselect): DEFSYM them.
4738 (x_handle_selection_request): Pass Qx_sent_selection_functions
4739 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4740 (x_handle_selection_clear,x_clear_frame_selections):
4741 Pass Qx_lost_selection_functions rather than
4742 Vx_lost_selection_functions to Frun_hook_with_args.
4744 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4746 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4747 The old code sometimes used this field without initializing it.
4749 * alloc.c (gc_sweep): Don't read past end of array.
4750 In theory, the old code could also have corrupted Emacs internals,
4751 though it'd be very unlikely.
4753 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4755 * character.c (Fcharacterp): Don't advertise optional ignored
4756 argument. (Bug#4026)
4758 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4760 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4763 * window.c (Fset_window_start): Doc fix (bug#4199).
4764 (Fset_window_hscroll): Ditto.
4766 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4768 Fix minor new problems caught by GCC 4.6.1.
4769 * term.c (init_tty): Remove unused local.
4770 * xsettings.c (store_monospaced_changed): Define this function only
4771 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4774 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4776 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4778 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4780 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4781 are the mini-buffer and the echo area (bug#3320).
4783 * term.c (init_tty): Remove support for supdup, c10 and perq
4784 terminals, which are no longer supported (bug#1482).
4786 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4788 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4790 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4792 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4793 for non-popups (Bug#3642).
4795 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4797 * alloc.c (reset_malloc_hooks): Protoize.
4798 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4799 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4800 * cm.c (losecursor): Likewise.
4801 * data.c (fmod): Likewise.
4802 * dispnew.c (swap_glyphs_in_rows): Likewise.
4803 * emacs.c (memory_warning_signal): Likewise.
4804 * floatfns.c (float_error): Likewise.
4805 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4806 (otf_open, font_otf_capability, generate_otf_features)
4807 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4809 * image.c (pbm_read_file): Likewise.
4810 * indent.c (string_display_width): Likewise.
4811 * intervals.c (check_for_interval, search_for_interval)
4812 (inc_interval_count, count_intervals, root_interval)
4813 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4814 * lread.c (defalias): Likewise.
4815 * ralloc.c (r_alloc_check): Likewise.
4816 * regex.c (set_image_of_range_1, set_image_of_range)
4817 (regex_grow_registers): Likewise.
4818 * sysdep.c (strerror): Likewise.
4819 * termcap.c (valid_filename_p, tprint, main): Likewise.
4820 * tparam.c (main): Likewise.
4821 * unexhp9k800.c (run_time_remap, save_data_space)
4822 (update_file_ptrs, read_header, write_header, calculate_checksum)
4823 (copy_file, copy_rest, display_header): Likewise.
4824 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4826 * xdisp.c (check_it): Likewise.
4827 * xfaces.c (register_color, unregister_color, unregister_colors):
4829 * xfns.c (print_fontset_result): Likewise.
4830 * xrdb.c (member, fatal, main): Likewise.
4832 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4834 Fix minor problems found by static checking (Bug#9031).
4835 * chartab.c (char_table_set_range, map_sub_char_table):
4836 Remove unused locals.
4837 (uniprop_table): Now static.
4838 * composite.c (_work_char): Remove unused static var.
4840 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4842 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4844 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4846 * gtkutil.c (qttip_cb): Remove code without function.
4848 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4850 * w32.c (pthread_sigmask): New stub.
4852 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4854 Use pthread_sigmask, not sigprocmask (Bug#9010).
4855 sigprocmask is portable only for single-threaded applications, and
4856 Emacs can be multi-threaded when it uses GTK.
4857 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4859 * callproc.c (Fcall_process):
4860 * process.c (create_process):
4861 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4862 Use pthread_sigmask, not sigprocmask.
4864 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4866 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4867 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4870 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4872 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4873 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4874 (xg_hide_tooltip): Fix comment.
4876 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4877 in registerServicesMenuSendTypes.
4878 (validRequestorForSendType): Don't check ns_return_types.
4880 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4883 2011-07-08 Jason Rumney <jasonr@gnu.org>
4885 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4886 SH_SHOW for hidden windows (Bug#5482).
4888 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4889 frame struct members of non-existent frames (Bug#6284).
4891 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4893 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4894 variable firstTime not needed on OSX >= 10.6.
4895 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4896 >= 10.5. Use setKnobProportion, setDoubleValue.
4898 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4899 (MAC_OS_X_VERSION_10_5): Define if not defined.
4900 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4901 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4902 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4904 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4905 cString and lossyCString on OSX >= 10.4
4907 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4908 sizeToFit on OSX >= 10.2.
4910 * nsimage.m (allocInitFromFile): Don't use deprecated method
4911 bestRepresentationForDevice on OSX >= 10.6.
4913 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4916 * emacs.c: Declare unexec_init_emacs_zone.
4918 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4920 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4922 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4923 on svcsMenu (Bug#8842).
4925 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4927 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4929 * nsterm.m (QUTF8_STRING): Declare.
4930 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4931 (validRequestorForSendType): Return type is (id).
4932 Change indexOfObjectIdenticalTo to indexOfObject.
4933 Check if we have local selection before returning self (Bug#8842).
4934 (writeSelectionToPasteboard): Put local selection into paste board
4935 if we have a local selection (Bug#8842).
4936 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4938 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4939 (ns_get_local_selection): Declare.
4941 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4943 * keymap.c (describe_map_tree): Don't insert a double newline at
4944 the end of the buffer (bug#1169) and return whether we inserted
4947 * callint.c (Fcall_interactively): Change "reading args" to
4948 "providing args" to try to clarify what it does (bug#1010).
4950 2011-07-07 Kenichi Handa <handa@m17n.org>
4952 * composite.c (composition_compute_stop_pos): Ignore a static
4953 composition starting before CHARPOS (Bug#8915).
4955 * xdisp.c (handle_composition_prop): Likewise.
4957 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4959 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4962 2011-07-07 Kenichi Handa <handa@m17n.org>
4964 * character.h (unicode_category_t): New enum type.
4966 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4967 (Qchar_code_property_table): New variable.
4968 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4969 (UNIPROP_COMPRESSED_FORM_P): New macros.
4970 (char_table_ascii): Uncompress the compressed values.
4971 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4972 Uncompress the compressed values.
4973 (sub_char_table_ref_and_range): Likewise.
4974 (char_table_ref_and_range): Uncompress the compressed values.
4975 (sub_char_table_set): New arg is_uniprop. Callers changed.
4976 Uncompress the compressed values.
4977 (sub_char_table_set_range): Args changed. Callers changed.
4978 (char_table_set_range): Adjuted for the above change.
4979 (map_sub_char_table): Delete args default_val and parent. Add arg
4980 top. Give decoded values to a Lisp function.
4981 (map_char_table): Adjust for the above change. Give decoded
4982 values to a Lisp function. Gcpro more variables.
4983 (uniprop_table_uncompress)
4984 (uniprop_decode_value_run_length): New functions.
4985 (uniprop_decoder, uniprop_decoder_count): New variables.
4986 (uniprop_get_decoder, uniprop_encode_value_character)
4987 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4989 (uniprop_encoder, uniprop_encoder_count): New variables.
4990 (uniprop_get_encoder, uniprop_table)
4991 (Funicode_property_table_internal, Fget_unicode_property_internal)
4992 (Fput_unicode_property_internal): New functions.
4993 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4994 Sunicode_property_table_internal, Sget_unicode_property_internal,
4995 and Sput_unicode_property_internal. Defvar_lisp
4996 char-code-property-alist.
4998 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4999 Vunicode_category_table.
5001 * font.c (font_range): Adjust for the change of
5002 Vunicode_category_table.
5004 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5006 * m/iris4d.h: Remove file, move contents ...
5007 * s/irix6-5.h: ... here.
5009 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5011 Remove unportable assumption about struct layout (Bug#8884).
5012 * alloc.c (mark_buffer):
5013 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5014 (clone_per_buffer_values): Don't assume that
5015 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5016 This isn't true in general, and it's particularly not true
5017 if Emacs is configured with --with-wide-int.
5018 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5019 New macros, used in the buffer.c change.
5021 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5023 * xsettings.c: Use both GConf and GSettings if both are available.
5024 (store_config_changed_event): Add comment.
5025 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5026 (store_tool_bar_style_changed): New functions.
5027 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5028 (struct xsettings): Move font inside HAVE_XFT.
5029 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5030 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5031 Move inside HAVE_XFT.
5032 (something_changed_gsettingsCB): Rename from something_changedCB.
5033 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5035 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5036 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
5037 (something_changed_gconfCB): Rename from something_changedCB.
5038 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5039 (parse_settings): Move check for font inside HAVE_XFT.
5040 (read_settings, apply_xft_settings): Add comment.
5041 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5042 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5043 call store_font_name_changed.
5044 (xft_settings_event): Add comment.
5045 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5046 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5047 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5048 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5049 (xsettings_initialize): Call init_gsettings last.
5050 (xsettings_get_system_font, xsettings_get_system_normal_font):
5053 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5055 Random fixes. E.g., (random) never returned negative values.
5056 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5057 subseconds part to the entropy, as that's a bit more random.
5058 Prefer signed to unsigned, since the signedness doesn't matter and
5059 in general we prefer signed. When given a limit, use a
5060 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5061 latter isn't right if USE_2_TAGS_FOR_INTS.
5062 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5063 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5065 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5067 * textprop.c (text_property_stickiness):
5068 Obey Vtext_property_default_nonsticky.
5069 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5070 * w32fns.c (syms_of_w32fns):
5071 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5073 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5075 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5076 This is more efficient than Ffile_directory_p and avoids a minor race.
5078 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5080 * buffer.c (Foverlay_put): Say what the return value is
5083 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5084 is a directory before asking whether to use the file name
5086 (barf_or_query_if_file_exists): Make the "File is a directory"
5087 error be more correct.
5089 * fns.c (Frequire): Remove the mention of the .gz files, since
5090 that's installation-specific, but keep the mention of
5091 `get-load-suffixes'.
5093 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5095 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5096 Report string overflow if the output is too long.
5098 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
5100 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5101 (syms_of_gnutls): Remove duplicate DEFSYM for
5102 Qgnutls_bootprop_verify_hostname_error, an error for
5103 Qgnutls_bootprop_verify_error (which is no longer used).
5105 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5106 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5107 Also (re)move comments that are misplaced or no longer relevant.
5109 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5111 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5113 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
5115 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5116 and background color parameters if they have been changed.
5118 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5120 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5122 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5124 * xsettings.c (SYSTEM_FONT): Define only when used.
5125 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5127 * keymap.c (access_keymap_1): Now static.
5129 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5131 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5132 leave any prefix arg for the up event (Bug#1586).
5134 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5136 * lread.c (syms_of_lread): Mention single symbols defined by
5137 `defvar' or `defconst' (bug#7154).
5139 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5140 (Frequire): Mention get-load-suffixes.
5142 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5144 * window.h (window): Remove clone_number slot.
5145 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5147 (make_parent_window, make_window, saved_window)
5148 (Fset_window_configuration, save_window_save): Don't deal with
5150 * buffer.c (Qclone_number): Remove declaration.
5151 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5153 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5155 Add multiple inheritance to keymaps.
5156 * keymap.c (Fmake_composed_keymap): New function.
5157 (Fset_keymap_parent): Simplify.
5158 (fix_submap_inheritance): Remove.
5159 (access_keymap_1): New function extracted from access_keymap to handle
5160 embedded parents and handle lists of maps.
5161 (access_keymap): Use it.
5162 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5163 (Fcopy_keymap): Handle embedded parents.
5164 (Fcommand_remapping, define_as_prefix): Simplify.
5165 (Fkey_binding): Simplify.
5166 (syms_of_keymap): Move minibuffer-local-completion-map,
5167 minibuffer-local-filename-completion-map,
5168 minibuffer-local-must-match-map, and
5169 minibuffer-local-filename-must-match-map to Elisp.
5170 (syms_of_keymap): Defsubr make-composed-keymap.
5171 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5172 (parse_menu_item): Trivial simplification.
5174 2011-07-01 Glenn Morris <rgm@gnu.org>
5176 * Makefile.in (SETTINGS_LIBS): Fix typo.
5178 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5180 * coding.c (Fencode_coding_string): Record the last coding system
5181 used, as the function doc string says (bug#8738).
5183 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5185 * xsettings.c (store_monospaced_changed): Take new font as arg and
5186 check for change against current_mono_font.
5187 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5188 (emacs_settings_constructor, emacs_settings_get_property)
5189 (emacs_settings_set_property, emacs_settings_class_init)
5190 (emacs_settings_init, gsettings_obj): Remove.
5191 (something_changedCB): New function for HAVE_GSETTINGS.
5192 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5193 with value as argument.
5194 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5195 g_settings_new (Bug#8967). Do not create gsettings_obj.
5196 Remove calls to g_settings_bind. Connect something_changedCB to
5199 * xgselect.c: Add defined (HAVE_GSETTINGS).
5200 (xgselect_initialize): Ditto.
5202 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5203 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5206 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5208 * eval.c (struct backtrace): Simplify and port the data structure.
5209 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5210 signed bit field, as this assumption is not portable and it makes
5211 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5212 "char debug_on_exit : 1" as this is not portable either; instead,
5213 use the portable "unsigned int debug_on_exit : 1". Remove unused
5214 member evalargs. Remove obsolete comments about cc bombing out.
5216 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5218 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5219 Let HAVE_GSETTINGS override HAVE_GCONF.
5220 (store_monospaced_changed): New function.
5221 (EMACS_SETTINGS): A new type derived from GObject to handle
5222 GSettings notifications.
5223 (emacs_settings_constructor, emacs_settings_get_property)
5224 (emacs_settings_set_property, emacs_settings_class_init):
5226 (gsettings_client, gsettings_obj): New variables.
5227 (GSETTINGS_SCHEMA): New define.
5228 (something_changedCB): Call store_monospaced_changed.
5229 (init_gsettings): New function.
5230 (xsettings_initialize): Call init_gsettings.
5231 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5234 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5237 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5239 * window.c (resize_root_window, grow_mini_window)
5240 (shrink_mini_window): Rename Qresize_root_window to
5241 Qwindow_resize_root_window and Qresize_root_window_vertically to
5242 Qwindow_resize_root_window_vertically.
5244 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5246 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5248 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5250 * makefile.w32-in: Redesign dependencies so they reflect more
5251 clearly which files are directly included by each source file,
5252 and not through other includes.
5254 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5256 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5257 (sort_overlays, overlay_strings): When an overlay's clone number
5258 matches the window's clone number process the overlay even if
5259 the overlay's window property doesn't match the current window.
5261 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5262 (Fwindow_hchild): Rename to Fwindow_left_child.
5263 (Fwindow_next): Rename to Fwindow_next_sibling.
5264 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5265 (resize_window_check): Rename to window_resize_check.
5266 (resize_window_apply): Rename to window_resize_apply.
5267 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5268 (Fdelete_other_windows_internal, resize_frame_windows)
5269 (Fsplit_window_internal, Fdelete_window_internal)
5270 (grow_mini_window, shrink_mini_window)
5271 (Fresize_mini_window_internal): Fix callers accordingly.
5273 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5275 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5276 (emacs_fixed_set_min_size): Remove.
5277 (emacs_fixed_new): Take frame as argument.
5279 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5280 (_EmacsFixedPrivate): Remove minwidth/height.
5281 Add struct frame *f.
5282 (emacs_fixed_init): Initialize priv->f.
5283 (get_parent_class, emacs_fixed_set_min_size): Remove.
5284 (emacs_fixed_new): Set priv->f to argument.
5285 (emacs_fixed_get_preferred_width)
5286 (emacs_fixed_get_preferred_height): Use min_width/height from
5287 frames size_hint to set minimum and natural (Bug#8919).
5288 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5289 and use min_width/height from frames size_hint to set
5290 min_width/height (Bug#8919).
5292 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5293 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5296 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5298 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5299 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5302 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5304 * process.c (wait_reading_process_output): Bypass select if
5305 waiting for a cell while ignoring keyboard input, and input is
5306 pending. Suggested by Jan Djärv (Bug#8869).
5308 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5310 Use gnulib's dup2 module instead of rolling our own.
5311 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5313 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5315 * dispnew.c (scrolling_window): Before scrolling, turn off a
5316 mouse-highlight in the window being scrolled.
5318 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5320 Move DEFSYM to lisp.h and use everywhere.
5322 * character.h (DEFSYM): Move declaration...
5323 * lisp.h (DEFSYM): ...here.
5329 * w32select.c: Don't include character.h.
5331 * alloc.c (syms_of_alloc):
5332 * buffer.c (syms_of_buffer):
5333 * bytecode.c (syms_of_bytecode):
5334 * callint.c (syms_of_callint):
5335 * casefiddle.c (syms_of_casefiddle):
5336 * casetab.c (init_casetab_once):
5337 * category.c (init_category_once, syms_of_category):
5338 * ccl.c (syms_of_ccl):
5339 * cmds.c (syms_of_cmds):
5340 * composite.c (syms_of_composite):
5341 * dbusbind.c (syms_of_dbusbind):
5342 * dired.c (syms_of_dired):
5343 * dispnew.c (syms_of_display):
5344 * doc.c (syms_of_doc):
5345 * editfns.c (syms_of_editfns):
5346 * emacs.c (syms_of_emacs):
5347 * eval.c (syms_of_eval):
5348 * fileio.c (syms_of_fileio):
5349 * fns.c (syms_of_fns):
5350 * frame.c (syms_of_frame):
5351 * fringe.c (syms_of_fringe):
5352 * insdel.c (syms_of_insdel):
5353 * keymap.c (syms_of_keymap):
5354 * lread.c (init_obarray, syms_of_lread):
5355 * macros.c (syms_of_macros):
5356 * msdos.c (syms_of_msdos):
5357 * print.c (syms_of_print):
5358 * process.c (syms_of_process):
5359 * search.c (syms_of_search):
5360 * sound.c (syms_of_sound):
5361 * syntax.c (init_syntax_once, syms_of_syntax):
5362 * terminal.c (syms_of_terminal):
5363 * textprop.c (syms_of_textprop):
5364 * undo.c (syms_of_undo):
5365 * w32.c (globals_of_w32):
5366 * window.c (syms_of_window):
5367 * xdisp.c (syms_of_xdisp):
5368 * xfaces.c (syms_of_xfaces):
5369 * xfns.c (syms_of_xfns):
5370 * xmenu.c (syms_of_xmenu):
5371 * xsettings.c (syms_of_xsettings):
5372 * xterm.c (syms_of_xterm): Use DEFSYM.
5374 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5376 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5378 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5380 Integer and buffer overflow fixes (Bug#8873).
5382 * print.c (printchar, strout): Check for string overflow.
5383 (PRINTPREPARE, printchar, strout):
5384 Don't set size unless allocation succeeds.
5386 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5387 for sizes. Check for string overflow more accurately.
5388 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5390 * macros.c: Integer and buffer overflow fixes.
5391 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5392 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5393 Use ptrdiff_t, not int, for sizes.
5394 Don't increment bufsize until after realloc succeeds.
5395 Check for size-calculation overflow.
5396 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5398 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5400 * lread.c: Integer overflow fixes.
5401 (read_integer): Radix is now EMACS_INT, not int,
5402 to improve quality of diagnostics for out-of-range radices.
5403 Calculate buffer size correctly for out-of-range radices.
5404 (read1): Check for integer overflow in radices, and in
5405 read-circle numbers.
5406 (read_escape): Avoid int overflow.
5407 (Fload, openp, read_buffer_size, read1)
5408 (substitute_object_recurse, read_vector, read_list, map_obarray):
5409 Use ptrdiff_t, not int, for sizes.
5410 (read1): Use EMACS_INT, not int, for sizes.
5411 Check for size overflow.
5413 * image.c (cache_image): Check for size arithmetic overflow.
5415 * lread.c: Integer overflow issues.
5416 (saved_doc_string_size, saved_doc_string_length)
5417 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5418 Now ptrdiff_t, not int.
5419 (read1): Don't assume doc string length fits in int. Check for
5420 out-of-range doc string lengths.
5421 (read_list): Don't assume file position fits in int.
5422 (read_escape): Check for hex character overflow.
5424 2011-06-22 Leo Liu <sdl.web@gmail.com>
5426 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5427 Move to minibuffer.el.
5429 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5431 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5432 The following patches are for when GLYPH_DEBUG && !XASSERT.
5433 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5434 * dispnew.c (flush_stdout):
5435 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5436 Mark as externally visible.
5437 * dispnew.c (check_window_matrix_pointers): Now static.
5438 * dispnew.c (window_to_frame_vpos):
5439 * xfns.c (unwind_create_frame):
5440 * xterm.c (x_check_font): Remove unused local.
5441 * scroll.c (CHECK_BOUNDS):
5442 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5443 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5444 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5445 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5446 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5448 (debug_method_add): Use va_list and vsprintf rather than relying
5449 on undefined behavior with wrong number of arguments.
5450 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5451 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5452 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5453 since we're not interested in debugging glyphs with old libraries.
5454 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5455 GCC 4.6.0's static checking.
5457 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5459 Integer overflow and signedness fixes (Bug#8873).
5460 A few related buffer overrun fixes, too.
5462 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5464 * dispextern.h (struct face.stipple):
5465 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5466 (x_bitmap_mask, x_allocate_bitmap_record)
5467 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5468 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5469 (x_create_bitmap_from_xpm_data):
5470 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5471 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5473 * xfaces.c (load_pixmap):
5474 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5475 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5476 (.bitmaps_last, struct x_output.icon_bitmap):
5477 Use ptrdiff_t, not int, for bitmap indexes.
5478 (x_allocate_bitmap_record): Check for size overflow.
5479 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5481 Use ptrdiff_t, not int, for overlay counts.
5482 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5483 * editfns.c (overlays_around, get_pos_property):
5484 * textprop.c (get_char_property_and_overlay):
5485 * xdisp.c (next_overlay_change, note_mouse_highlight):
5486 * xfaces.c (face_at_buffer_position):
5487 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5488 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5489 (Fnext_overlay_change, Fprevious_overlay_change)
5490 (mouse_face_overlay_overlaps, Foverlays_in):
5491 Use ptrdiff_t, not int, for sizes.
5492 (overlays_at, overlays_in): Check for size-calculation overflow.
5494 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5496 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5497 (x_session_initialize): Do not assume string length fits in int.
5499 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5500 This is unlikely, but can occur if DPI is outlandish.
5502 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5503 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5505 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5506 * xrdb.c (magic_file_p, search_magic_path):
5507 Omit last arg SUFFIX; it was always 0. All callers changed.
5508 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5510 * xfont.c (xfont_match): Avoid need for strlen.
5512 * xfns.c: Don't assume strlen fits in int.
5513 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5515 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5516 not unsigned long, as we prefer signed integers. All callers changed.
5517 Detect integer overflow in repeat count.
5518 (message_dolog): Don't assume print length fits in 39 bytes.
5519 (display_mode_element): Don't assume strlen fits in int.
5521 * termcap.c: Don't assume sizes fit in int and never overflow.
5522 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5523 (gobble_line): Check for size-calculation overflow.
5525 * minibuf.c (Fread_buffer):
5526 * lread.c (intern, intern_c_string):
5527 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5528 Don't assume string length fits in int.
5530 * keyboard.c (parse_tool_bar_item):
5531 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5533 * font.c: Don't assume string length fits in int.
5534 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5535 Use ptrdiff_t, not int.
5536 (font_intern_prop): Don't assume string length fits in int.
5537 Don't assume integer property fits in fixnum.
5538 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5540 * filelock.c: Fix some buffer overrun and integer overflow issues.
5541 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5542 Reformulate so as not to need the command string.
5543 Invoke gzip -cd rather than gunzip, as it's more portable.
5544 (lock_info_type, lock_file_1, lock_file):
5545 Don't assume pid_t and time_t fit in unsigned long.
5546 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5547 (current_lock_owner): Prefer signed type for sizes.
5548 Use memcpy, not strncpy, where memcpy is what is really wanted.
5549 Don't assume (via atoi) that time_t and pid_t fit in int.
5550 Check for time_t and/or pid_t out of range, e.g., via a network share.
5551 Don't alloca where an auto var works fine.
5553 * fileio.c: Fix some integer overflow issues.
5554 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5555 Don't assume string length fits in int.
5556 (directory_file_name): Don't assume string length fits in long.
5557 (make_temp_name): Don't assume pid fits in int, or that its print
5558 length is less than 20.
5560 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5562 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5564 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5566 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5567 We prefer signed integers, even for size calculations.
5569 * emacs.c: Don't assume string length fits in 'int'.
5570 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5571 (main): Don't invoke strlen when not needed.
5573 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5574 (XD_DEBUG_MESSAGE): Don't waste a byte.
5576 * callproc.c (getenv_internal_1, getenv_internal)
5578 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5580 * lread.c (invalid_syntax): Omit length argument.
5581 All uses changed. This doesn't fix a bug, but it simplifies the
5582 code away from its former Hollerith-constant appearance, and it's
5583 one less 'int' to worry about when looking at integer-overflow issues.
5584 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5586 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5587 This didn't break anything, but it didn't help either.
5588 It's confusing to put a bogus integer in a place where the actual
5589 value does not matter.
5590 (LIST_END_P): Remove unused macro and its bogus comment.
5591 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5593 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5594 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5596 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5597 We prefer signed types, and the value cannot exceed the EMACS_INT
5598 range anyway (because otherwise the length would not be representable).
5599 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5600 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5601 This avoids a GCC warning when WIDE_EMACS_INT.
5603 * indent.c (sane_tab_width): New function.
5604 (current_column, scan_for_column, Findent_to, position_indentation)
5605 (compute_motion): Use it. This is just for clarity.
5606 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5608 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5610 * lisp.h (lint_assume): New macro.
5611 * composite.c (composition_gstring_put_cache):
5612 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5614 * editfns.c, insdel.c:
5615 Omit unnecessary forward decls, to simplify future changes.
5617 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5619 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5621 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5622 Use much-faster test for byte-length change.
5623 Don't assume string byte-length fits in 'int'.
5624 Check that character arg fits in 'int'.
5625 (mapcar1): Declare byte as byte, for clarity.
5627 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5629 * fns.c (concat): Catch string overflow earlier.
5630 Do not rely on integer wraparound.
5632 * dispextern.h (struct it.overlay_strings_charpos)
5633 (struct it.selective): Now EMACS_INT, not int.
5634 * xdisp.c (forward_to_next_line_start)
5635 (back_to_previous_visible_line_start)
5636 (reseat_at_next_visible_line_start, next_element_from_buffer):
5637 Don't arbitrarily truncate the value of 'selective' to int.
5639 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5641 * composite.c: Don't truncate sizes to 'int'.
5642 (composition_gstring_p, composition_reseat_it)
5643 (composition_adjust_point): Use EMACS_INT, not int.
5644 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5645 not EMACS_UINT, for indexes.
5647 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5649 * buffer.c: Include <verify.h>.
5650 (struct sortvec.priority, struct sortstr.priority):
5651 Now EMACS_INT, not int.
5652 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5653 (struct sortstr.size, record_overlay_string)
5654 (struct sortstrlist.size, struct sortlist.used):
5655 Don't truncate size to int.
5656 (record_overlay_string): Check for size-calculation overflow.
5657 (init_buffer_once): Check at compile-time, not run-time.
5659 2011-06-22 Jim Meyering <meyering@redhat.com>
5661 Don't leak an XBM-image-sized buffer
5662 * image.c (xbm_load): Free the image buffer after using it.
5664 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5667 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5668 that Sun C diagnosed.
5669 * fns.c (secure_hash): Fix pointer signedness issue.
5670 * intervals.c (static_offset_intervals): New function.
5671 (offset_intervals): Use it.
5673 2011-06-21 Leo Liu <sdl.web@gmail.com>
5676 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5679 * fns.c (secure_hash): Rename from crypto_hash_function and change
5680 the first arg to accept symbols.
5681 (Fsecure_hash): New primitive.
5682 (syms_of_fns): New symbols.
5684 2011-06-20 Deniz Dogan <deniz@dogan.se>
5686 * process.c (Fset_process_buffer): Clarify return value in
5689 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5691 * dispnew.c (add_window_display_history): Use BVAR.
5693 * xdisp.c (debug_method_add): Use BVAR.
5694 (check_window_end, dump_glyph_matrix, dump_glyph)
5695 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5697 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5700 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5701 check till after the cache is created in init_frame_faces.
5703 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5705 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5707 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5709 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5710 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5711 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5713 Improve buffer-overflow checking (Bug#8873).
5714 * fileio.c (Finsert_file_contents):
5715 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5716 Remove the old (too-loose) buffer overflow checks.
5717 They weren't needed, since make_gap checks for buffer overflow.
5718 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5719 The old code merely checked for Emacs fixnum overflow, and relied
5720 on undefined (wraparound) behavior. The new code avoids undefined
5721 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5723 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5724 Tune. Don't use wider integers than needed. Don't use alloca.
5725 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5727 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5729 * insdel.c, lisp.h (buffer_overflow): New function.
5730 (insert_from_buffer_1, replace_range, replace_range_2):
5731 * insdel.c (make_gap_larger):
5732 * editfns.c (Finsert_char):
5733 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5735 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5737 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5739 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5741 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5742 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5744 * fileio.c: Don't assume EMACS_INT fits in off_t.
5745 (emacs_lseek): New static function.
5746 (Finsert_file_contents, Fwrite_region): Use it.
5747 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5749 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5751 * fns.c: Don't overflow int when computing a list length.
5752 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5753 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5754 truncation on 64-bit hosts. Check for QUIT every
5755 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5756 faster and is responsive enough.
5757 (Flength): Report an error instead of overflowing an integer.
5758 (Fsafe_length): Return a float if the value is not representable
5759 as a fixnum. This shouldn't happen except in contrived situations.
5760 (Fnthcdr, Fsort): Don't assume list length fits in int.
5761 (Fcopy_sequence): Don't assume vector length fits in int.
5763 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5764 (header_size, word_size): New constants.
5765 (allocate_vectorlike): Don't check size overflow here.
5766 (allocate_vector): Check it here instead, since this is the only
5767 caller of allocate_vectorlike that could cause overflow.
5768 Check that the new vector's length is representable as a fixnum.
5770 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5771 The previous code was bogus. For example, next_almost_prime (32)
5772 returned 39, which is undesirable as it is a multiple of 3; and
5773 next_almost_prime (24) returned 25, which is a multiple of 5 so
5774 why was the code bothering to check for multiples of 7?
5776 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5778 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5780 Variadic C functions now count arguments with ptrdiff_t.
5781 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5782 Back then I didn't know that the Emacs coding style prefers signed int.
5783 Also, in the meantime I found a few more instances where arguments
5784 were being counted with int, which may truncate counts on 64-bit
5785 machines, or EMACS_INT, which may be unnecessarily wide.
5786 * lisp.h (struct Lisp_Subr.function.aMANY)
5787 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5788 Arg counts are now ptrdiff_t, not size_t.
5789 All variadic functions and their callers changed accordingly.
5790 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5791 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5792 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5793 * callint.c (Fcall_interactively): Check arg count for overflow,
5794 to avoid potential buffer overrun. Use signed char, not 'int',
5795 for 'varies' array, so that we needn't bother to check its size
5796 calculation for overflow.
5797 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5798 * eval.c (apply_lambda):
5799 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5800 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5801 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5803 * callint.c (Fcall_interactively): Don't use index var as event count.
5805 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5806 * mem-limits.h (SIZE): Remove; no longer used.
5808 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5810 Remove unnecessary casts.
5811 * xterm.c (x_term_init):
5812 * xfns.c (x_set_border_pixel):
5813 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5814 These aren't needed now that we assume ANSI C.
5816 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5817 It's more likely to cause problems (due to unsigned overflow)
5820 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5822 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5824 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5826 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5828 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5830 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5832 GLYPH_CODE_FACE returns EMACS_INT, not int.
5833 * dispextern.h (merge_faces):
5834 * xfaces.c (merge_faces):
5835 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5836 Don't assume EMACS_INT fits in int.
5838 * character.h (CHAR_VALID_P): Remove unused parameter.
5839 * fontset.c, lisp.h, xdisp.c: All uses changed.
5841 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5843 * fns.c (concat): Minor tuning based on overflow analysis.
5844 This doesn't fix any bugs. Use int to hold character, instead
5845 of constantly refetching from Emacs object. Use XFASTINT, not
5846 XINT, for value known to be a character. Don't bother comparing
5847 a single byte to 0400, as it's always less.
5849 * floatfns.c (Fexpt):
5850 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5852 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5855 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5857 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5858 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5859 incorrectly succeed when S was a string, because 4294967386 was
5860 truncated before it was used.
5862 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5863 Otherwise, an out-of-range integer could cause undefined behavior
5866 * composite.c: Use int, not EMACS_INT, for characters.
5867 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5868 EMACS_INT, for values that are known to be in character range.
5869 This doesn't fix any bugs but is the usual style inside Emacs and
5870 may generate better code on 32-bit machines.
5872 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5873 This is for reasons similar to the recent CHAR_STRING fix.
5874 * charset.c (Fencode_char): Check that character arg is actually
5875 a character. Pass an int to ENCODE_CHAR.
5876 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5877 wider than 'int', as a compile-time check to prevent future regressions
5880 * character.c (char_string): Remove unnecessary casts.
5882 Make sure a 64-bit char is never passed to CHAR_STRING.
5883 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5884 by silently ignoring the top 32 bits, allowing some values
5885 that were far too large to be valid characters.
5886 * character.h: Include <verify.h>.
5887 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5888 arguments are no wider than unsigned, as a compile-time check
5889 to prevent future regressions in this area.
5891 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5892 (Fsubst_char_in_region):
5894 * xdisp.c (decode_mode_spec_coding):
5895 Adjust to CHAR_STRING's new requirement.
5896 * editfns.c (Finsert_char, Fsubst_char_in_region):
5897 * fns.c (concat): Check that character args are actually
5898 characters. Without this test, these functions did the wrong
5899 thing with wildly out-of-range values on 64-bit hosts.
5901 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5902 These casts should not be needed on 32-bit hosts, either.
5903 * keyboard.c (read_char):
5904 * lread.c (Fload): Remove casts to unsigned.
5906 * lisp.h (UNSIGNED_CMP): New macro.
5907 This fixes comparison bugs on 64-bit hosts.
5908 (ASCII_CHAR_P): Use it.
5909 * casefiddle.c (casify_object):
5910 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5911 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5912 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5913 * dispextern.h (FACE_FROM_ID):
5914 * keyboard.c (read_char): Use UNSIGNED_CMP.
5916 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5917 not to EMACS_INT, to avoid GCC warning.
5919 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5921 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5922 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5923 isn't needed on 32-bit machines.
5925 * buffer.c (Fgenerate_new_buffer_name):
5926 Use EMACS_INT for count, not int.
5927 (advance_to_char_boundary): Return EMACS_INT, not int.
5929 * data.c (Qcompiled_function): Now static.
5931 * window.c (window_body_lines): Now static.
5933 * image.c (gif_load): Rename local to avoid shadowing.
5935 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5936 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5937 * alloc.c (make_save_value): Integer argument is now of type
5939 (mark_object): Use ptrdiff_t, not int.
5940 * lisp.h (pD): New macro.
5941 * print.c (print_object): Use it.
5943 * alloc.c: Use EMACS_INT, not int, to count objects.
5944 (total_conses, total_markers, total_symbols, total_vector_size)
5945 (total_free_conses, total_free_markers, total_free_symbols)
5946 (total_free_floats, total_floats, total_free_intervals)
5947 (total_intervals, total_strings, total_free_strings):
5948 Now EMACS_INT, not int. All uses changed.
5949 (Fgarbage_collect): Compute overall total using a double, so that
5950 integer overflow is less likely to be a problem. Check for overflow
5951 when converting back to an integer.
5952 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5953 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5954 These were 'int' variables that could overflow on 64-bit hosts;
5955 they were never used, so remove them instead of repairing them.
5956 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5957 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5958 Previously, this ceilinged at INT_MAX, but that doesn't work on
5960 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5962 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5963 (allocate_vectorlike): Check for ptrdiff_t overflow.
5964 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5965 when a (possibly-narrower) signed value would do just as well.
5966 We prefer using signed arithmetic, to avoid comparison confusion.
5968 * alloc.c: Catch some string size overflows that we were missing.
5969 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5970 for convenience in STRING_BYTES_MAX.
5971 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5972 The definition here is exact; the one in lisp.h was approximate.
5973 (allocate_string_data): Check for string overflow. This catches
5974 some instances we weren't catching before. Also, it catches
5975 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5976 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5977 and ptrdiff_t and EMACS_INT are both 64 bits.
5979 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5980 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5981 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5983 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5985 * alloc.c (Fmake_string): Check for out-of-range init.
5987 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5989 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5991 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5993 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5994 xg_get_default_scrollbar_width.
5996 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5997 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5998 (style_changed_cb): Call update_theme_scrollbar_width and call
5999 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6000 all frames (Bug#8505).
6001 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6002 Call gtk_window_set_resizable if HAVE_GTK3.
6003 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6004 and height if HAVE_GTK3 (Bug#8505).
6005 (scroll_bar_width_for_theme): New variable.
6006 (update_theme_scrollbar_width): New function.
6007 (xg_get_default_scrollbar_width): Move code to
6008 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6009 (xg_initialize): Call update_theme_scrollbar_width.
6011 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6013 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6015 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6017 * frame.c (make_frame): Call other_buffer_safely instead of
6020 * window.c (temp_output_buffer_show): Call display_buffer with
6021 second argument Vtemp_buffer_show_specifiers and reset latter
6022 immediately after the call.
6023 (Vtemp_buffer_show_specifiers): New variable.
6024 (auto_window_vscroll_p, next_screen_context_lines)
6025 (Vscroll_preserve_screen_position): Remove leading asterisks from
6028 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6030 Fix minor problems found by GCC 4.6.0 static checking.
6031 * buffer.c (Qclone_number): Remove for now, as it's unused.
6032 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6033 (record_buffer): Remove unused local.
6034 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6035 (set_frame_buffer_list): Remove; unused.
6036 * frame.h (other_visible_frames): Remove decl.
6037 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6038 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6039 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6041 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6042 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6043 Define only if HAVE_GPM.
6044 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6045 (update_hints_inhibit): Remove; never set. All uses removed.
6046 * widgetprv.h (emacsFrameClassRec): Remove decl.
6047 * window.c (delete_deletable_window): Now returns void, since it
6048 wasn't returning anything.
6049 (compare_window_configurations): Remove unused locals.
6050 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6051 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
6052 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6053 the same widths as pointers. This follows up on the 2011-05-06 patch.
6054 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6055 * xterm.h: Likewise.
6056 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6058 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
6060 * makefile.w32-in: Update dependencies.
6061 (LISP_H): Add lib/intprops.h.
6063 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6065 * image.c (gif_load): Add animation frame delay to the metadata.
6066 (syms_of_image): Use DEFSYM. New symbol `delay'.
6068 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6070 * window.c (delete_deletable_window): Re-add.
6071 (Fset_window_configuration): Rewrite to handle dead buffers and
6072 consequently deletable windows.
6073 (window_tree, Fwindow_tree): Remove. Supply functionality in
6075 (compare_window_configurations): Simplify code.
6077 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6079 * image.c (imagemagick_load_image): Fix type mismatch.
6080 (Fimagemagick_types): Likewise.
6082 * window.h (replace_buffer_in_windows): Declare.
6084 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6086 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6087 Qclone_number. Remove external declaration of Qdelete_window.
6088 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6090 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6091 Run Qbuffer_list_update_hook if allowed.
6092 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6093 buffer list implementation.
6094 (other_buffer_safely): New function.
6095 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6096 calls to replace_buffer_in_windows and
6097 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6099 (record_buffer): Inhibit quitting and rewrite using quittable
6100 functions. Run Qbuffer_list_update_hook if allowed.
6101 (Frecord_buffer, Funrecord_buffer): New functions.
6102 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6103 Move switch-to-buffer to window.el.
6104 (bury-buffer): Move to window.el.
6105 (Vbuffer_list_update_hook): New variable.
6107 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6110 * window.h (resize_frame_windows): Move up in code.
6111 (Fwindow_frame): Remove EXFUN.
6112 (replace_buffer_in_all_windows): Remove prototype.
6113 (replace_buffer_in_windows_safely): Add prototype.
6115 * window.c: Declare Qdelete_window static again. Move down
6116 declaration of select_count.
6117 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6118 (Fother_window): Move to window.el.
6119 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6120 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6121 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6123 (replace_buffer_in_windows): Implement by calling
6124 Qreplace_buffer_in_windows.
6125 (replace_buffer_in_all_windows): Remove with some functionality
6126 moved into replace_buffer_in_windows_safely.
6127 (replace_buffer_in_windows_safely): New function.
6128 (select_window_norecord, select_frame_norecord): Move in front
6129 of run_window_configuration_change_hook. Remove now obsolete
6131 (Fset_window_buffer): Rewrite doc-string.
6132 Call Qrecord_window_buffer.
6133 (keys_of_window): Move binding for other-window to window.el.
6135 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6137 * dispextern.h (struct image): Replace data member, whose int_val
6138 and ptr_val fields were not used by anything, with a single
6141 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6142 (gif_clear_image, gif_load, imagemagick_load_image)
6143 (gs_clear_image, gs_load): Callers changed.
6145 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6147 * buffer.h: Include <time.h>, for time_t.
6148 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6150 Fix minor problems found by static checking.
6152 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6154 Make identifiers static if they are not used in other modules.
6155 * data.c (Qcompiled_function, Qframe, Qvector):
6156 * image.c (QimageMagick, Qsvg):
6157 * minibuf.c (Qmetadata):
6158 * window.c (resize_window_check, resize_root_window): Now static.
6159 * window.h (resize_window_check, resize_root_window): Remove decls.
6161 * window.c (window_deletion_count, delete_deletable_window):
6163 (window_body_lines): Now static.
6164 (Fdelete_other_windows_internal): Mark vars as initialized.
6165 Make sure 'resize_failed' is initialized.
6166 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6167 (resize_window_apply): Remove unused local.
6168 * window.h (delete_deletable_window): Remove decl.
6170 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6171 (imagemagick_load_image): Fix pointer signedness problem by changing
6172 last arg from unsigned char * to char *. All uses changed.
6173 Also, fix a local for similar reasons.
6174 Remove unused locals. Remove locals to avoid shadowing.
6175 (fn_rsvg_handle_free): Remove; unused.
6176 (svg_load, svg_load_image): Fix pointer signedness problem.
6177 (imagemagick_load_image): Don't use garbage pointer image_wand.
6179 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6181 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6183 * image.c (gif_load): Fix omitted cast error introduced by
6186 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6188 * window.h (resize_proportionally, orig_total_lines)
6189 (orig_top_line): Remove from window structure.
6190 (set_window_height, set_window_width, change_window_heights)
6191 (Fdelete_window): Remove prototypes.
6192 (resize_frame_windows): Remove duplicate declaration.
6194 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6196 * window.h (resize_frame_windows, resize_window_check)
6197 (delete_deletable_window, resize_root_window)
6198 (resize_frame_windows): Declare prototypes.
6200 * window.c (resize_window_apply): Make definition be "static" to
6201 match the prototype.
6203 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6205 * window.c: Remove declarations of Qwindow_size_fixed,
6206 window_min_size_1, window_min_size_2, window_min_size,
6207 size_window, window_fixed_size_p, enlarge_window, delete_window.
6208 Remove static from declaration of Qdelete_window, it's
6209 temporarily needed by Fbury_buffer.
6210 (replace_window): Don't assign orig_top_line and
6212 (Fdelete_window, delete_window): Remove. Window deletion is
6213 handled by window.el.
6214 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6215 Replace Fdelete_window calls with calls to Qdelete_window.
6216 (Fdelete_other_windows): Remove. Deleting other windows is
6217 handled by window.el.
6218 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6219 handled in window.el.
6220 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6221 Window minimum sizes are handled in window.el.
6222 (shrink_windows, size_window, set_window_height)
6223 (set_window_width, change_window_heights, window_height)
6224 (window_width, CURBEG, CURSIZE, enlarge_window)
6225 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6226 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6227 handled in window.el.
6228 (make_dummy_parent): Rename to make_parent_window and give it a
6229 second argument horflag.
6230 (make_window): Don't set resize_proportionally any more.
6231 (Fsplit_window): Remove. Windows are split in window.el.
6232 (save_restore_action, save_restore_orig_size)
6233 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6234 Resize mini windows in window.el.
6235 (grow_mini_window, shrink_mini_window): Implement by calling
6236 Qresize_root_window_vertically, resize_window_check and
6237 resize_window_apply.
6238 (saved_window, Fset_window_configuration, save_window_save):
6239 Do not handle orig_top_line, orig_total_lines, and
6240 resize_proportionally.
6241 (window_min_height, window_min_width): Move to window.el.
6242 (keys_of_window): Move bindings for delete-other-windows,
6243 split-window, delete-window and enlarge-window to window.el.
6245 * buffer.c: Temporarily extern Qdelete_window.
6246 (Fbury_buffer): Temporarily call Qdelete_window instead of
6247 Fdelete_window (Fbury_buffer will move to window.el soon).
6249 * frame.c (set_menu_bar_lines_1): Remove code handling
6250 orig_top_line and orig_total_lines.
6252 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6253 set_window_height but set heights directly.
6254 (change_frame_size_1): Use resize_frame_windows.
6256 * xdisp.c (init_xdisp): Don't use set_window_height but set
6259 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6260 Use resize_frame_windows instead of change_window_heights and run
6261 run_window_configuration_change_hook.
6263 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6264 instead of change_window_heights and run
6265 run_window_configuration_change_hook.
6267 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6269 * window.c (replace_window): Rename second argument REPLACEMENT to
6270 NEW. New third argument SETFLAG. Rewrite.
6271 (delete_window, make_dummy_parent): Call replace_window with
6273 (window_list_1): Move down in code.
6274 (run_window_configuration_change_hook): Move set_buffer part
6275 before select_frame_norecord part in order to unwind correctly.
6276 Rename count1 to count.
6277 (recombine_windows, delete_deletable_window, resize_root_window)
6278 (Fdelete_other_windows_internal)
6279 (Frun_window_configuration_change_hook, make_parent_window)
6280 (resize_window_check, resize_window_apply, Fresize_window_apply)
6281 (resize_frame_windows, Fsplit_window_internal)
6282 (Fdelete_window_internal, Fresize_mini_window_internal):
6284 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6286 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6288 * window.h (window): Add some new members to window structure -
6289 normal_lines, normal_cols, new_total, new_normal, clone_number,
6290 splits, nest, prev_buffers, next_buffers.
6291 (WINDOW_TOTAL_SIZE): Move here from window.c.
6292 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6294 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6296 (make_dummy_parent): Set new members of windows structure.
6297 (make_window): Move down in code. Handle new members of window
6299 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6300 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6301 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6302 (Fset_window_prev_buffers, Fwindow_next_buffers)
6303 (Fset_window_next_buffers, Fset_window_clone_number):
6305 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6306 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6308 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6309 Argument WINDOW can be now internal window too.
6310 (Fwindow_use_time): Move up in code.
6311 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6313 (Fset_window_configuration, saved_window)
6314 (Fcurrent_window_configuration, save_window_save): Handle new
6315 members of window structure.
6316 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6317 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6318 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6319 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6320 Qget_mru_window, Qresize_root_window,
6321 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6322 Qauto_buffer_name; staticpro them.
6324 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6326 * window.c (Fwindow_total_size, Fwindow_left_column)
6327 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6328 (Fwindow_list_1): New functions.
6329 (window_box_text_cols): Replace with window_body_cols.
6330 (Fwindow_width, Fscroll_left, Fscroll_right):
6331 Use window_body_cols instead of window_box_text_cols.
6332 (delete_window, Fset_window_configuration):
6333 Call delete_all_subwindows with window as argument.
6334 (delete_all_subwindows): Take a window as argument and not a
6336 (window_loop): Remove handling of GET_LRU_WINDOW and
6338 (Fget_lru_window, Fget_largest_window): Move to window.el.
6340 * window.h: Extern window_body_cols instead of
6341 window_box_text_cols. delete_all_subwindows now takes a
6342 Lisp_Object as argument.
6344 * indent.c (compute_motion, Fcompute_motion):
6345 Use window_body_cols instead of window_box_text_cols.
6347 * frame.c (delete_frame): Call delete_all_subwindows with root
6350 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6352 * fns.c (Fputhash): Document return value.
6354 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6356 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6358 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6360 Cons<->int and similar integer overflow fixes (Bug#8794).
6362 Check for overflow when converting integer to cons and back.
6363 * charset.c (Fdefine_charset_internal, Fdecode_char):
6364 Use cons_to_unsigned to catch overflow.
6365 (Fencode_char): Use INTEGER_TO_CONS.
6366 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6367 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6368 * data.c (long_to_cons, cons_to_long): Remove.
6369 (cons_to_unsigned, cons_to_signed): New functions.
6370 These signal an error for invalid or out-of-range values.
6371 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6372 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6373 * font.c (Ffont_variation_glyphs):
6374 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6375 * lisp.h: Include <intprops.h>.
6376 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6377 (cons_to_signed, cons_to_unsigned): New decls.
6378 (long_to_cons, cons_to_long): Remove decls.
6379 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6380 (Fprimitive_undo): Use CONS_TO_INTEGER.
6381 * xfns.c (Fx_window_property): Likewise.
6382 * xselect.c: Include <limits.h>.
6383 (x_own_selection, selection_data_to_lisp_data):
6384 Use INTEGER_TO_CONS.
6385 (x_handle_selection_request, x_handle_selection_clear)
6386 (x_get_foreign_selection, Fx_disown_selection_internal)
6387 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6388 (lisp_data_to_selection_data): Use cons_to_unsigned.
6389 (x_fill_property_data): Use cons_to_signed.
6390 Report values out of range.
6392 Check for buffer and string overflow more precisely.
6393 * buffer.h (BUF_BYTES_MAX): New macro.
6394 * lisp.h (STRING_BYTES_MAX): New macro.
6395 * alloc.c (Fmake_string):
6396 * character.c (string_escape_byte8):
6397 * coding.c (coding_alloc_by_realloc):
6398 * doprnt.c (doprnt):
6399 * editfns.c (Fformat):
6401 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6402 since they may not be the same number.
6403 * editfns.c (Finsert_char):
6404 * fileio.c (Finsert_file_contents):
6405 Likewise for BUF_BYTES_MAX.
6407 * image.c: Use ptrdiff_t, not int, for sizes.
6408 (slurp_file): Switch from int to ptrdiff_t.
6410 (slurp_file): Check that file size fits in both size_t (for
6411 malloc) and ptrdiff_t (for sanity and safety).
6413 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6414 if b->modtime has its maximal value.
6416 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6418 Don't assume time_t can fit into int.
6419 * buffer.h (struct buffer.modtime): Now time_t, not int.
6420 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6421 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6423 Minor fixes for signed vs unsigned integers.
6424 * character.h (MAYBE_UNIFY_CHAR):
6425 * charset.c (maybe_unify_char):
6426 * keyboard.c (read_char, reorder_modifiers):
6427 XINT -> XFASTINT, since the integer must be nonnegative.
6428 * ftfont.c (ftfont_spec_pattern):
6429 * keymap.c (access_keymap, silly_event_symbol_error):
6430 XUINT -> XFASTINT, since the integer must be nonnegative.
6431 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6432 since it makes no difference and we prefer signed.
6433 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6434 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6437 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6439 * window.h (Fwindow_frame): Declare.
6441 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6443 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6444 (SPARE_MEMORY): Always define.
6445 (LARGE_REQUEST): Remove.
6446 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6448 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6450 * lisp.h: Move EXFUNS for Fframe_root_window,
6451 Fframe_first_window and Fset_frame_selected_window to window.h.
6453 * window.h: Move EXFUNS for Fframe_root_window,
6454 Fframe_first_window and Fset_frame_selected_window here from
6457 * frame.c (Fwindow_frame, Fframe_first_window)
6458 (Fframe_root_window, Fframe_selected_window)
6459 (Fset_frame_selected_window): Move to window.c.
6460 (Factive_minibuffer_window): Move to minibuf.c.
6461 (Fother_visible_frames_p): New function.
6463 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6465 * window.c (decode_window, decode_any_window): Move up in code.
6466 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6467 (inhibit_frame_unsplittable): Remove unused variable.
6468 (Fwindow_buffer): Move up and rewrite doc-string.
6469 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6470 (Fwindow_prev): New functions.
6471 (Fwindow_frame): Move here from frame.c. Accept any window as
6473 (Fframe_root_window, Fframe_first_window)
6474 (Fframe_selected_window): Move here from frame.c. Accept frame
6475 or arbitrary window as argument. Update doc-strings.
6476 (Fminibuffer_window): Move up in code.
6477 (Fwindow_minibuffer_p): Move up in code and simplify.
6478 (Fset_frame_selected_window): Move here from frame.c.
6480 (Fselected_window, select_window, Fselect_window): Move up in
6481 code. Minor doc-string fixes.
6483 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6485 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6486 Do not assume that spare memory exists; that assumption is valid
6487 only if SYSTEM_MALLOC.
6488 (LARGE_REQUEST): New macro, so that the issue of large requests
6489 is separated from the issue of spare memory.
6491 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6493 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6496 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6498 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6501 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6503 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6505 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6507 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6508 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6510 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6512 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6514 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6516 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6517 (x_clipboard_manager_save): Add return value.
6518 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6520 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6521 Obey Vx_select_enable_clipboard_manager. Catch errors in
6522 x_clipboard_manager_save (Bug#8779).
6523 (Vx_select_enable_clipboard_manager): New variable.
6524 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6526 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6528 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6530 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6532 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6533 in the current matrix if keep_current_p is non-zero.
6535 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6537 * bidi.c (bidi_level_of_next_char): Fix last change.
6539 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6541 Support bidi reordering of text covered by display properties.
6543 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6544 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6545 (bidi_cache_search, bidi_cache_iterator_state)
6546 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6547 (bidi_level_of_next_char, bidi_move_to_visually_next):
6548 Support character positions inside a run of characters covered by a
6550 (bidi_paragraph_init, bidi_resolve_explicit_1)
6551 (bidi_level_of_next_char): Call bidi_fetch_char and
6552 bidi_fetch_char_advance instead of FETCH_CHAR and
6554 (bidi_init_it): Initialize new members.
6555 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6557 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6558 instead of using explicit *_CHAR codes.
6559 (bidi_resolve_explicit, bidi_resolve_weak):
6560 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6561 bidirectional text is supported only in multibyte buffers.
6562 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6563 it to initialize the frame_window_p member of struct bidi_it.
6564 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6565 (bidi_resolve_explicit, bidi_resolve_weak)
6566 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6567 bidi_it->nchars is non-positive.
6568 (bidi_level_of_next_char): Don't try to lookup the cache for the
6569 next/previous character if nothing is cached there yet, or if we
6570 were just reseat()'ed to a new position.
6572 * xdisp.c (set_cursor_from_row): Set start and stop points
6573 according to the row's direction when priming the loop that looks
6574 for the glyph on which to display cursor.
6575 (single_display_spec_intangible_p): Function deleted.
6576 (display_prop_intangible_p): Reimplement to call
6577 handle_display_spec instead of single_display_spec_intangible_p.
6578 Accept 3 additional arguments needed by handle_display_spec.
6579 This fixes incorrect cursor motion across display property with complex
6580 values: lists, `(when COND...)' forms, etc.
6581 (single_display_spec_string_p): Support property values that are
6582 lists with the argument STRING its top-level element.
6583 (display_prop_string_p): Fix the condition for processing a
6584 property that is a list to be consistent with handle_display_spec.
6585 (handle_display_spec): New function, refactored from the
6586 last portion of handle_display_prop.
6587 (compute_display_string_pos): Accept additional argument
6588 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6589 value of a `display' property is a "replacing spec".
6590 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6591 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6592 the display property, but just return a value indicating whether
6593 the display property will replace the characters it covers.
6594 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6595 frame_window_p members of struct bidi_it.
6596 (compute_display_string_pos, compute_display_string_end):
6598 (push_it): Accept second argument POSITION, where pop_it should
6599 jump to continue iteration.
6600 (reseat_1): Initialize bidi_it.disp_pos.
6602 * keyboard.c (adjust_point_for_property): Adjust the call to
6603 display_prop_intangible_p to its new signature.
6605 * dispextern.h (struct bidi_it): New member frame_window_p.
6606 (bidi_init_it): Update prototypes.
6607 (display_prop_intangible_p): Update prototype.
6608 (compute_display_string_pos, compute_display_string_end):
6610 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6613 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6615 Malloc failure behavior now depends on size of allocation.
6616 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6617 * lisp.h: Change signatures accordingly.
6618 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6619 All callers changed. (Bug#8762)
6621 * gnutls.c: Use Emacs's memory allocators.
6622 Without this change, the gnutls library would invoke malloc etc.
6623 directly, which causes problems on non-SYNC_INPUT hosts, and which
6624 runs afoul of improving memory_full behavior. (Bug#8761)
6625 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6626 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6627 xfree instead of the default malloc, realloc, free.
6628 (Fgnutls_boot): No need to check for memory allocation failure,
6629 since xmalloc does that for us.
6631 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6632 * category.c (hash_get_category_set):
6633 * ccl.c (ccl_driver):
6634 * charset.c (Fdefine_charset_internal):
6635 * charset.h (struct charset.hash_index):
6636 * composite.c (get_composition_id, gstring_lookup_cache)
6637 (composition_gstring_put_cache):
6638 * composite.h (struct composition.hash_index):
6639 * dispextern.h (struct image.hash):
6640 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6641 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6642 (hashfn_equal, hashfn_user_defined, make_hash_table)
6643 (maybe_resize_hash_table, hash_lookup, hash_put)
6644 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6645 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6646 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6647 * image.c (make_image, search_image_cache, lookup_image)
6648 (xpm_put_color_table_h):
6649 * lisp.h (struct Lisp_Hash_Table):
6650 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6651 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6652 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6653 * alloc.c (allocate_vectorlike):
6654 Check for overflow in vector size calculations.
6655 * ccl.c (ccl_driver):
6656 Check for overflow when converting EMACS_INT to int.
6657 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6658 need to be updated by these changes.
6659 * fns.c (make_hash_table, maybe_resize_hash_table):
6660 Check for integer overflow with large hash tables.
6661 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6662 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6663 (SXHASH_REDUCE): New macro.
6664 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6665 Use it instead of discarding useful hash info with large hash values.
6666 (sxhash_float): New function.
6667 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6668 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6669 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6670 Rewrite to use FIXNUM_BITS, as this simplifies things.
6671 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6672 Adjust signatures to match updated version of code.
6673 (consing_since_gc): Now EMACS_INT, since a single hash table can
6674 use more than INT_MAX bytes.
6676 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6678 Make it possible to build with GCC-4.6+ -O2 -flto.
6680 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6682 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6684 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6685 Call minibuffer-inactive-mode.
6687 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6689 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6690 Update dependencies.
6692 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6694 * data.c (init_data): Remove code for UTS, this system is not
6697 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6699 Don't force ./temacs to start in terminal mode.
6701 * frame.c (make_initial_frame): Initialize faces in all cases, not
6702 only when CANNOT_DUMP is defined.
6703 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6705 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6707 * dispnew.c (add_window_display_history): Use const for the string
6708 pointer. Remove declaration, not needed.
6710 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6712 Use 'inline', not 'INLINE'.
6713 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6714 * alloc.c, fontset.c (INLINE): Remove.
6715 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6716 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6717 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6718 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6719 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6721 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6723 Make it possible to run ./temacs.
6725 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6726 syms_of_callproc does the same thing. Remove test for
6727 "initialized", do it in the caller.
6728 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6730 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6732 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6733 (read_minibuf): Use get_minibuffer.
6734 (syms_of_minibuf): Use DEFSYM.
6735 (Qmetadata): New var.
6736 * data.c (Qbuffer): Don't make it static.
6737 (syms_of_data): Use DEFSYM.
6739 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6741 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6742 (CCL_CODE_MIN): New macro.
6744 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6746 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6748 * eval.c (Qdebug): Now static.
6749 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6750 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6751 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6753 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6755 * image.c: Various fixes to ImageMagick code comments.
6756 (Fimagemagick_types): Doc fix.
6758 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6760 Minor fixes prompted by GCC 4.6.0 warnings.
6762 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6764 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6765 (x_clipboard_manager_save_all): Move extern decl to ...
6766 * xterm.h: ... here, so that it can be checked for consistency.
6768 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6770 * xselect.c (x_clipboard_manager_save_frame)
6771 (x_clipboard_manager_save_all): New functions.
6772 (Fx_clipboard_manager_save): Lisp function deleted.
6774 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6775 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6777 * xterm.h: Update prototype.
6779 2011-05-28 William Xu <william.xwl@gmail.com>
6781 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6784 2011-05-28 Jim Meyering <meyering@redhat.com>
6786 Avoid a sign-extension bug in crypto_hash_function.
6787 * fns.c (to_uchar): Define.
6788 (crypto_hash_function): Use it to convert some newly-signed
6789 variables to unsigned, to avoid sign-extension bugs. For example,
6790 without this change, (md5 "truc") would evaluate to
6791 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6792 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6793 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6795 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6797 Integer overflow fixes.
6799 * dbusbind.c: Serial number integer overflow fixes.
6800 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6801 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6802 to hold a serial number that is too large for a fixnum.
6803 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6804 Check for serial numbers out of range. Decode any serial number
6805 that was so large that it became a float. (Bug#8722)
6807 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6808 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6809 Use XFASTINT rather than XUINT when numbers are nonnegative.
6810 (xd_append_arg, Fdbus_method_return_internal):
6811 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6812 arguments, check that Lisp number is nonnegative, rather than
6813 silently wrapping negative numbers around. (Bug#8722)
6814 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6817 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6819 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6821 ccl: Add integer overflow checks.
6822 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6823 (IN_INT_RANGE): New macros.
6824 (ccl_driver): Use them to check for integer overflow when
6825 decoding a CCL program. Many of the new checks are whether XINT (x)
6826 fits in int; it doesn't always, on 64-bit hosts. The new version
6827 doesn't catch all possible integer overflows, but it's an
6828 improvement. (Bug#8719)
6830 * alloc.c (make_event_array): Use XINT, not XUINT.
6831 There's no need for unsigned here.
6833 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6834 This follows up to the 2011-05-06 change that substituted uintptr_t
6835 for EMACS_INT. This case wasn't caught back then.
6837 Rework Fformat to avoid integer overflow issues.
6838 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6839 now (part of C89). Include <verify.h>.
6840 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6841 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6842 (Fformat): Avoid the prepass trying to compute sizes; it was only
6843 approximate and thus did not catch overflow reliably. Instead, walk
6844 through the format just once, formatting and computing sizes as we go,
6845 checking for integer overflow at every step, and allocating a larger
6846 buffer as needed. Keep track separately whether the format is
6847 multibyte. Keep only the most-recently calculated precision, rather
6848 than them all. Record whether each argument has been converted to
6849 string. Use EMACS_INT, not int, for byte and char and arg counts.
6850 Support field widths and precisions larger than INT_MAX. Avoid
6851 sprintf's undefined behavior with conversion specifications such as %#d
6852 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6853 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6854 formatting out-of-range floating point numbers with int
6857 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6859 * data.c: Avoid integer truncation in expressions involving floats.
6860 * data.c: Include <intprops.h>.
6861 (arith_driver): When there's an integer overflow in an expression
6862 involving floating point, convert the integers to floating point
6863 so that the resulting value does not suffer from catastrophic
6864 integer truncation. For example, on a 64-bit host (* 4
6865 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6866 Do not rely on undefined behavior after integer overflow.
6868 merge count_size_as_multibyte, parse_str_to_multibyte
6869 * character.c, character.h (count_size_as_multibyte):
6870 Rename from parse_str_to_multibyte; all uses changed.
6871 Check for integer overflow.
6872 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6873 since it's now a duplicate of the other. This is more of
6874 a character than a buffer op, so better that it's in character.c.
6875 * fns.c, print.c: Adjust to above changes.
6877 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6879 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6881 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6883 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6884 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6885 (x_clipboard_manager_save): Now static.
6886 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6888 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6889 (crypto_hash_function): Now static.
6890 Fix pointer signedness problems. Avoid unnecessary initializations.
6892 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6894 * termhooks.h (Vselection_alist): Make it terminal-local.
6896 * terminal.c (create_terminal): Initialize it.
6898 * xselect.c: Support for clipboard managers.
6899 (Vselection_alist): Move to termhooks.h as terminal-local var.
6900 (LOCAL_SELECTION): New macro.
6901 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6902 (symbol_to_x_atom): Remove gratuitous arg.
6903 (x_handle_selection_request, lisp_data_to_selection_data)
6904 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6905 (x_own_selection, x_get_local_selection, x_convert_selection):
6906 New arg, specifying work frame. Use terminal-local Vselection_alist.
6907 (some_frame_on_display): Delete unused function.
6908 (Fx_own_selection_internal, Fx_get_selection_internal)
6909 (Fx_disown_selection_internal, Fx_selection_owner_p)
6910 (Fx_selection_exists_p): New optional frame arg.
6911 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6912 (x_handle_selection_clear): Don't treat other terminals with the
6913 same keyboard specially. Use the terminal-local Vselection_alist.
6914 (x_clear_frame_selections): Use Frun_hook_with_args.
6916 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6918 * xterm.h: Add support for those atoms.
6920 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6922 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6923 (converted_selections, conversion_fail_tag): New global variables.
6924 (x_selection_request_lisp_error): Free the above.
6925 (x_get_local_selection): Remove unnecessary code.
6926 (x_reply_selection_request): Args changed; handle arbitrary array
6927 of converted selections stored in converted_selections.
6928 Separate the XChangeProperty and SelectionNotify steps.
6929 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6930 (x_convert_selection): New function.
6931 (x_handle_selection_event): Simplify.
6932 (x_get_foreign_selection): Don't ignore incoming requests while
6933 waiting for an answer; this will fail when we implement
6934 SAVE_TARGETS, and seems unnecessary anyway.
6935 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6936 (Vx_sent_selection_functions): Doc fix.
6938 2011-05-26 Leo Liu <sdl.web@gmail.com>
6940 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6942 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6944 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6946 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6947 for fringe update if it has periodic bitmap.
6948 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6949 and fringe_bitmap_periodic_p.
6951 * fringe.c (get_fringe_bitmap_data): New function.
6952 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6953 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6954 row. Mark glyph row for fringe update if periodicity changed.
6956 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6957 for fringe update unless it has periodic bitmap.
6959 2011-05-25 Kenichi Handa <handa@m17n.org>
6961 * xdisp.c (get_next_display_element): Set correct it->face_id for
6962 a static composition.
6964 2011-05-24 Leo Liu <sdl.web@gmail.com>
6967 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6969 * fns.c (crypto_hash_function, Fsha1): New function.
6970 (Fmd5): Use crypto_hash_function.
6971 (syms_of_fns): Add Ssha1.
6973 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6975 * gnutls.c: Remove unused macros.
6976 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6977 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6978 Remove macros that are defined and never used.
6979 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6981 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6983 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6984 (Fx_get_selection_internal): Minor cleanup.
6985 (Fx_own_selection_internal): Rename arguments for consistency with
6988 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6990 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6992 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6994 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6996 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6998 * dispnew.c (scrolling_window): Don't exclude the case that the
6999 last enabled row in the desired matrix touches the bottom boundary.
7001 2011-05-21 Glenn Morris <rgm@gnu.org>
7003 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7004 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7005 and add some more files.
7007 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7009 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7010 report_file_error introduced by the change from 2011-05-07.
7012 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7014 * systime.h (Time): Define only if emacs is defined.
7015 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7016 where the include path doesn't have X11/X.h by default. See
7017 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7019 2011-05-20 Kenichi Handa <handa@m17n.org>
7021 * composite.c (find_automatic_composition): Fix previous change.
7023 2011-05-20 Glenn Morris <rgm@gnu.org>
7025 * lisp.mk: New file, split from Makefile.in.
7026 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7027 (shortlisp): Remove.
7028 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7030 2011-05-19 Glenn Morris <rgm@gnu.org>
7032 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7033 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7034 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7035 (lisp): Set the order to that of loadup.el.
7036 (shortlisp): Make it a copy of $lisp.
7037 (SOME_MACHINE_LISP): Remove.
7038 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7039 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7041 2011-05-18 Kenichi Handa <handa@m17n.org>
7043 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7044 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7045 (find_automatic_composition): Mostly rewrite for efficiency.
7047 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
7049 * makefile.w32-in: Update dependencies.
7051 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7053 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7054 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7056 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7058 Fix some integer overflow issues, such as string length overflow.
7060 * insdel.c (count_size_as_multibyte): Check for string overflow.
7062 * character.c (lisp_string_width): Check for string overflow.
7063 Use EMACS_INT, not int, for string indexes and lengths; in
7064 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7065 the resulting string length overflows an EMACS_INT; instead,
7066 report a string overflow if no precision given. When checking for
7067 precision exhaustion, use a check that cannot possibly have
7068 integer overflow. (Bug#8675)
7069 * character.h (lisp_string_width): Adjust to new signature.
7071 * alloc.c (string_overflow): New function.
7072 (Fmake_string): Use it. This doesn't change behavior, but saves
7073 a few bytes and will simplify future changes.
7074 * character.c (string_escape_byte8): Likewise.
7075 * lisp.h (string_overflow): New decl.
7077 Fixups, following up to the user-interface timestamp change.
7078 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7079 for UI timestamps, instead of unsigned long.
7080 * msdos.c (mouse_get_pos): Likewise.
7081 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
7082 * w32gui.h (Time): Define by including "systime.h" rather than by
7083 declaring it ourselves. (Bug#8664)
7085 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7086 * image.c (clear_image_cache): Likewise.
7088 * term.c (term_mouse_position): Don't assume time_t wraparound.
7090 Be more systematic about user-interface timestamps.
7091 Before, the code sometimes used 'Time', sometimes 'unsigned long',
7092 and sometimes 'EMACS_UINT', to represent these timestamps.
7093 This change causes it to use 'Time' uniformly, as that's what X uses.
7094 This makes the code easier to follow, and makes it easier to catch
7095 integer overflow bugs such as Bug#8664.
7096 * frame.c (Fmouse_position, Fmouse_pixel_position):
7097 Use Time, not unsigned long, for user-interface timestamps.
7098 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7099 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7100 * keyboard.h (last_event_timestamp): Likewise.
7101 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7102 * menu.h (xmenu_show): Likewise.
7103 * term.c (term_mouse_position): Likewise.
7104 * termhooks.h (struct input_event.timestamp): Likewise.
7105 (struct terminal.mouse_position_hook): Likewise.
7106 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7107 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7108 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7109 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7111 * menu.h, termhooks.h: Include "systime.h", for Time.
7113 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7114 Don't assume that the difference between two unsigned long values
7115 can fit into an integer. At this point, we know button_down_time
7116 <= event->timestamp, so the difference must be nonnegative, so
7117 there's no need to cast the result if double-click-time is
7118 nonnegative, as it should be; check that it's nonnegative, just in
7119 case. This bug is triggered when events are more than 2**31 ms
7120 apart (about 25 days). (Bug#8664)
7122 * xselect.c (last_event_timestamp): Remove duplicate decl.
7123 (x_own_selection): Remove needless cast to unsigned long.
7125 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7126 that always fit in int. Use a sentinel instead of a counter, to
7127 avoid a temp and to allay GCC's concerns about possible int overflow.
7128 * frame.h (struct frame): Use int for menu_bar_items_used
7129 instead of EMACS_INT, since it always fits in int.
7131 * menu.c (grow_menu_items): Check for int overflow.
7133 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7135 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7136 Before, the code was not consistent. These values cannot exceed
7137 2**31 - 1 so there's no need to make them unsigned.
7138 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7139 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7140 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7142 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7144 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7145 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7146 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7147 presumably because the widths might not match.
7149 * window.c (size_window): Avoid needless test at loop start.
7151 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7153 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7155 2011-05-12 Drew Adams <drew.adams@oracle.com>
7157 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7159 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7161 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7162 `width' to `bar_area_x' and `bar_area_width', respectively.
7163 (x_scroll_run): Take account of fringe background extension.
7165 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7166 Rename local vars `left' and `width' to `bar_area_x' and
7167 `bar_area_width', respectively.
7168 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7169 background extension.
7171 2011-05-10 Jim Meyering <meyering@redhat.com>
7173 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7175 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7177 * image.c (Finit_image_library): Return t for built-in image types,
7178 like pbm and xbm. (Bug#8640)
7180 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7182 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7184 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7186 * w32console.c (Fset_screen_color): Doc fix.
7187 (Fget_screen_color): New function.
7188 (syms_of_ntterm): Defsubr it.
7190 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7191 unlink the temporary file if Fcall_process didn't create it in the
7193 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7194 child process will be redirected to a file specified with `:file'.
7195 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7196 cue to call_process_cleanup not to close that handle.
7198 2011-05-07 Ben Key <bkey76@gmail.com>
7200 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7201 one of two shell specific rules, either bootstrap-temacs-CMD or
7202 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7203 to the previous implementation of the bootstrap-temacs rule.
7204 The bootstrap-temacs-CMD rule is similar to the previous
7205 implementation of the bootstrap-temacs rule except that it
7206 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7209 These changes, along with some changes to nt/configure.bat,
7210 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7211 earlier fix to add support for --cflags and --ldflags options
7212 that include quotes so that it works whether make uses cmd or
7215 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7217 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7218 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7220 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7221 a string. Handle both cases.
7222 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7223 (Fdbus_register_method): Use Qinvalid_function.
7225 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7227 * makefile.w32-in: Update dependencies.
7228 (LISP_H): Add inttypes.h and stdin.h.
7229 (PROCESS_H): Add unistd.h.
7231 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7233 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7234 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7236 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7238 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7240 * term.c (vfatal): Remove stray call to va_end.
7241 It's not needed and the C Standard doesn't allow it here anyway.
7243 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7244 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7246 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7249 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7251 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7253 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7255 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7257 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7259 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7260 * charset.c (Fdefine_charset_internal): Don't initialize
7261 charset.code_space[15]. The value was garbage, on hosts with
7262 32-bit int (Bug#8600).
7264 * lread.c (read_integer): Be more consistent with string-to-number.
7265 Use string_to_number to do the actual conversion; this avoids
7266 rounding errors and fixes some other screwups. Without this fix,
7267 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7268 (digit_to_number): Move earlier, for benefit of read_integer.
7269 Return -1 if the digit is out of range for the base, -2 if it is
7270 not a digit in any supported base. (Bug#8602)
7272 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7274 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7275 to match comment at start of function. This also removes a
7276 GCC warning about overflow in a 32+64-bit port.
7278 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7280 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7281 Reported by Stefan Monnier in
7282 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7283 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7284 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7286 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7287 (EMACS_UINTPTR): Likewise, with uintptr_t.
7289 * lisp.h: Prefer 64-bit EMACS_INT if available.
7290 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7291 on 32-bit hosts that have 64-bit int, so that they can access
7293 However, temporarily disable this change unless the temporary
7294 symbol WIDE_EMACS_INT is defined.
7296 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7298 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7299 This removes an assumption that EMACS_INT and long are the same
7300 width as pointers. The assumption is true for Emacs porting targets
7301 now, but we want to make other targets possible.
7302 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7303 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7304 In the rest of the code, change types of integers that hold casted
7305 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7306 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7307 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7308 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7309 No need to cast type when ORing.
7310 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7311 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7312 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7313 assume EMACS_INT is the same width as char *.
7314 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7315 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7316 Remove no-longer-needed casts.
7317 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7318 (xg_tool_bar_help_callback, xg_make_tool_item):
7319 Use EMACS_INTPTR to hold an integer
7320 that will be cast to void *; this can avoid a GCC warning
7321 if EMACS_INT is not the same width as void *.
7322 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7323 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7324 (current_message_1, set_message_1):
7325 Use a local to convert to proper width without a cast.
7326 * xmenu.c (dialog_selection_callback): Likewise.
7328 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7329 Also, don't assume VALBITS / RAND_BITS is less than 5,
7330 and don't rely on undefined behavior when shifting a 1 left into
7332 * lisp.h (get_random): Change signature to match.
7334 * lread.c (hash_string): Use size_t, not int, for hash computation.
7335 Normally we prefer signed values; but hashing is special, because
7336 it's better to use unsigned division on hash table sizes so that
7337 the remainder is nonnegative. Also, size_t is the natural width
7338 for hashing into memory. The previous code used 'int', which doesn't
7339 retain enough info to hash well into very large tables.
7340 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7342 * dbusbind.c: Don't possibly lose pointer info when converting.
7343 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7344 Use XPNTR rather than XHASH, so that the high-order bits of
7345 the pointer aren't lost when converting through void *.
7347 * eval.c (Fautoload): Don't double-shift a pointer.
7349 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7351 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7353 * gnutls.c (DEF_GNUTLS_FN):
7354 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7356 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7358 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7361 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7363 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7364 New version that can reserve upto 2GB of heap space.
7366 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7368 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7370 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7372 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7373 `gnutls_certificate_set_x509_key_file'.
7375 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7377 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7378 Update dependencies.
7380 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7382 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7383 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7384 Remove unused parameter `fildes'.
7385 * process.c (read_process_output, send_process): Don't pass it.
7387 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7389 Fix previous change: the library cache is defined in w32.c.
7390 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7391 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7393 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7395 Implement dynamic loading of GnuTLS on Windows.
7397 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7398 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7399 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7402 * gnutls.c (Qgnutls_dll): Define.
7403 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7404 (gnutls_*): Declare function pointers.
7405 (init_gnutls_functions): New function to initialize function pointers.
7406 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7407 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7408 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7409 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7410 (emacs_gnutls_write, emacs_gnutls_read)
7411 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7412 (Fgnutls_available_p): New function.
7413 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7414 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7415 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7417 * image.c: Include w32.h.
7418 (Vimage_type_cache): Delete.
7419 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7420 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7421 (w32_delayed_load): Move to w32.c.
7423 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7425 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7426 (w32_delayed_load): Move from image.c. When loading a library, record
7427 its filename in the :loaded-from property of the library id.
7428 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7429 Initialize and staticpro them.
7430 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7432 * process.c: Include lisp.h before w32.h, not after.
7433 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7434 instead of gnutls_record_check_pending.
7436 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7438 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7440 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7441 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7444 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7446 * xterm.c (x_set_frame_alpha): Do not set property on anything
7447 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7449 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7451 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7453 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7455 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7456 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7457 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7458 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7459 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7460 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7461 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7462 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7463 (Qgnutls_bootprop_callbacks_verify): Make static.
7465 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7467 * callproc.c: Indentation fixup.
7469 * sysdep.c (wait_for_termination_1): Make static.
7470 (wait_for_termination, interruptible_wait_for_termination):
7471 Move after wait_for_termination_1.
7473 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7475 * sysdep.c (interruptible_wait_for_termination): New function
7476 which is like wait_for_termination, but allows keyboard
7479 * callproc.c (Fcall_process): Add (:file "file") as an option for
7481 (Fcall_process_region): Ditto.
7483 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7485 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7486 rather than `XVECTOR (FOO)->size'.
7488 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7489 inttypes.h, as a gnulib replacement is used if it not available in
7492 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7494 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7495 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7496 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7498 * coding.c (coding_alloc_by_realloc): Error out if destination
7499 will grow beyond MOST_POSITIVE_FIXNUM.
7500 (decode_coding_emacs_mule): Abort if there isn't enough place in
7501 charbuf for the composition carryover bytes. Reserve an extra
7502 space for up to 2 characters produced in a loop.
7503 (decode_coding_iso_2022): Abort if there isn't enough place in
7504 charbuf for the composition carryover bytes.
7506 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7508 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7509 aborting when %lld or %lll format is passed.
7510 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7511 %llo or %llx format is passed. (Bug#8545)
7513 * window.c (window_scroll_line_based): Use a marker instead of
7514 simple variables to record original value of point. (Bug#7952)
7516 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7517 produced by %s or %c overflows available buffer space. (Bug#8545)
7519 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7521 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7522 (SIZE_MAX): Move defn after all includes, as they might #define it.
7524 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7526 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7528 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7530 * keyboard.c (Qdelayed_warnings_hook): Define.
7531 (command_loop_1): Run `delayed-warnings-hook'
7532 if Vdelayed_warnings_list is non-nil.
7533 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7534 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7536 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7538 * doprnt.c (doprnt): Don't return value smaller than the buffer
7539 size if the message was truncated. (Bug#8545).
7541 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7543 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7544 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7546 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7548 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7550 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7552 * makefile.w32-in: Update dependencies.
7554 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7556 Improve `doprnt' and its usage. (Bug#8545)
7557 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7558 `format_end'. Remove support for %l as a conversion specifier.
7559 Don't use xrealloc. Improve diagnostics when the %l size modifier
7560 is used. Update the commentary.
7562 * eval.c (verror): Simplify calculation of size_t.
7564 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7567 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7569 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7572 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7574 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7575 This makes this file independent of the recent pseudovector change.
7577 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7579 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7581 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7582 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7583 Remove unused local.
7584 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7586 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7587 GCC 4.6.0 optimizes based on type-based alias analysis.
7588 For example, if b is of type struct buffer * and v of type struct
7589 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7590 != &v->size, and therefore "v->size = 1; b->size = 2; return
7591 v->size;" must therefore return 1. This assumption is incorrect
7592 for Emacs, since it type-puns struct Lisp_Vector * with many other
7593 types. To fix this problem, this patch adds a new type struct
7594 vectorlike_header that documents the constraints on layout of vectors
7595 and pseudovectors, and helps optimizing compilers not get fooled
7596 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7597 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7598 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7600 (XSETPVECTYPE): Rewrite in terms of new macro.
7601 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7602 This is a bit clearer, and further avoids the possibility of
7603 undesirable aliasing.
7604 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7605 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7606 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7607 since Lisp_Subr is a special case (no "next" field).
7608 (ASIZE): Now uses header.size rather than size.
7609 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7610 to avoid the hassle of writing XVECTOR (foo)->header.size.
7611 (struct vectorlike_header): New type.
7612 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7613 object, to help avoid aliasing.
7614 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7615 (SUBRP): Likewise, since Lisp_Subr is a special case.
7616 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7617 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7618 (struct Lisp_Hash_Table): Combine first two members into a single
7619 struct vectorlike_header member. All uses of "size" and "next" members
7620 changed to be "header.size" and "header.next".
7621 * buffer.h (struct buffer): Likewise.
7622 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7623 * frame.h (struct frame): Likewise.
7624 * process.h (struct Lisp_Process): Likewise.
7625 * termhooks.h (struct terminal): Likewise.
7626 * window.c (struct save_window_data, struct saved_window): Likewise.
7627 * window.h (struct window): Likewise.
7628 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7629 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7630 * buffer.c (init_buffer_once): Likewise.
7631 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7633 * process.c (Fformat_network_address): Use local var for size,
7636 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7638 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7639 * data.c (atof): Remove decl; no longer used or needed.
7640 (digit_to_number): Move to lread.c.
7641 (Fstring_to_number): Use new string_to_number function, to be
7642 consistent with how the Lisp reader treats infinities and NaNs.
7643 Do not assume that floating-point numbers represent EMACS_INT
7644 without losing information; this is not true on most 64-bit hosts.
7645 Avoid double-rounding errors, by insisting on integers when
7646 parsing non-base-10 numbers, as the documentation specifies.
7647 * lisp.h (string_to_number): New decl, replacing ...
7648 (isfloat_string): Remove.
7649 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7650 (read1): Do not accept +. and -. as integers; this
7651 appears to have been a coding error. Similarly, do not accept
7652 strings like +-1e0 as floating point numbers. Do not report
7653 overflow for integer overflows unless the base is not 10 which
7654 means we have no simple and reliable way to continue.
7655 Break out the floating-point parsing into a new
7656 function string_to_number, so that Fstring_to_number parses
7657 floating point numbers consistently with the Lisp reader.
7658 (digit_to_number): Move here from data.c. Make it static inline.
7659 (E_CHAR, EXP_INT): Remove, replacing with ...
7660 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7661 (string_to_number): New function, replacing isfloat_string.
7662 This function checks for valid syntax and produces the resulting
7663 Lisp float number too. Rework it so that string-to-number
7664 no longer mishandles examples like "1.0e+". Use strtoumax,
7665 so that overflow for non-base-10 numbers is reported only when
7666 there's no portable and simple way to convert to floating point.
7668 * textprop.c (set_text_properties_1): Rewrite for clarity,
7669 and to avoid GCC warning about integer overflow.
7671 * intervals.h (struct interval): Use EMACS_INT for members
7672 where EMACS_UINT might cause problems. See
7673 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7674 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7675 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7677 (offset_intervals): Tell GCC not to worry about length overflow
7678 when negating a negative length.
7680 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7681 (overrun_check_free): Likewise.
7683 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7684 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7687 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7688 (gnutls_make_error): Rename local to avoid shadowing.
7689 (gnutls_emacs_global_deinit): ifdef out; not used.
7690 (Fgnutls_boot): Use const for pointer to readonly storage.
7691 Comment out unused local. Fix pointer signedness problems.
7693 * lread.c (openp): Don't stuff size_t into an 'int'.
7694 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7695 about possible signed overflow.
7697 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7698 (GDK_KEY_g): Don't define if already defined.
7699 (xg_prepare_tooltip): Avoid pointer signedness problem.
7700 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7702 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7703 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7705 * xfns.c (Fx_window_property): Simplify a bit,
7706 to make a bit faster and to avoid GCC 4.6.0 warning.
7707 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7709 * fns.c (internal_equal): Don't assume size_t fits in int.
7711 * alloc.c (compact_small_strings): Tighten assertion a little.
7713 Replace pEd with more-general pI, and fix some printf arg casts.
7714 * lisp.h (pI): New macro, generalizing old pEd macro to other
7715 conversion specifiers. For example, use "...%"pI"d..." rather
7716 than "...%"pEd"...".
7717 (pEd): Remove. All uses replaced with similar uses of pI.
7718 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7719 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7720 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7721 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7722 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7723 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7724 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7726 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7727 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7728 * print.c (safe_debug_print, print_object): Likewise.
7729 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7731 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7732 avoiding the 0 flag, which is not portable.
7733 * process.c (Fmake_network_process): Use pI to avoid cast.
7734 * region-cache.c (pp_cache): Likewise.
7735 * xdisp.c (decode_mode_spec): Likewise.
7736 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7737 behavior on 64-bit hosts with printf arg.
7738 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7739 (x_stop_queuing_selection_requests): Likewise.
7740 (x_get_window_property): Don't truncate byte count to an 'int'
7743 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7744 here, since it parses constructs like leading '-' and spaces,
7745 which are not wanted; and it overflows with large numbers.
7746 Instead, simply match F[0-9]+, which is what is wanted anyway.
7748 * alloc.c: Remove unportable assumptions about struct layout.
7749 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7750 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7751 (allocate_vectorlike, make_pure_vector): Use the new macros,
7752 plus offsetof, to remove unportable assumptions about struct layout.
7753 These assumptions hold on all porting targets that I know of, but
7754 they are not guaranteed, they're easy to remove, and removing them
7755 makes further changes easier.
7757 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7758 This doesn't fix a bug but makes the code clearer.
7759 (string_overrun_cookie): Now const. Use initializers that
7760 don't formally overflow signed char, to avoid warnings.
7761 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7762 can cause Emacs to crash when string overrun checking is enabled.
7763 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7764 multiple of sizeof (EMACS_INT); it need not be, if
7765 alignof(EMACS_INT) < sizeof (EMACS_INT).
7766 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7768 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7770 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7772 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7774 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7775 supposed to be handshaking. (Bug#8556)
7776 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7778 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7780 * lisp.h (Qdebug): List symbol.
7781 * eval.c (Qdebug): Restore global linkage.
7782 * keyboard.c (debug-on-event): New variable.
7783 (handle_user_signal): Break into debugger when debug-on-event
7784 matches the current signal symbol.
7786 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7788 * alloc.c (check_sblock, check_string_bytes)
7789 (check_string_free_list): Convert to standard C.
7791 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7793 * w32.c (emacs_gnutls_push): Fix typo.
7795 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7797 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7798 "cast to pointer from integer of different size".
7800 Improve doprnt and its use in verror. (Bug#8545)
7801 * doprnt.c (doprnt): Document the set of format control sequences
7802 supported by the function. Use SAFE_ALLOCA instead of always
7805 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7806 is one byte too soon. Don't use xrealloc; instead xfree and
7809 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7811 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7814 * gnutls.c: Renamed global_initialized to
7815 gnutls_global_initialized. Added internals for the
7816 :verify-hostname-error, :verify-error, and :verify-flags
7817 parameters of `gnutls-boot' and documented those parameters in the
7818 docstring. Start callback support.
7819 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7820 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7821 on error. Return error code.
7822 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7823 (emacs_gnutls_read): Likewise.
7824 (Fgnutls_boot): Return handshake error code.
7825 (emacs_gnutls_handle_error): New function.
7826 (wsaerror_to_errno): Likewise.
7828 * w32.h (emacs_gnutls_pull): Add prototype.
7829 (emacs_gnutls_push): Likewise.
7831 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7832 (emacs_gnutls_push): Likewise.
7834 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7836 * process.c (wait_reading_process_output): Check if GnuTLS
7837 buffered some data internally if no FDs are set for TLS
7840 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7841 (LIBS): Link to USER_LIBS.
7842 ($(BLD)/gnutls.$(0)): New target.
7844 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7846 * xdisp.c (handle_single_display_spec): Rename the
7847 display_replaced_before_p argument into display_replaced_p, to
7848 make it consistent with the commentary. Fix typos in the
7851 * textprop.c (syms_of_textprop): Remove dead code.
7852 (copy_text_properties): Delete obsolete commentary about an
7853 interface that was deleted long ago. Fix typos in the description
7856 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7857 to changes in oldXMenu/XMenu.h from 2011-04-16.
7858 <menu_help_message, prev_menu_help_message>: Constify.
7859 (IT_menu_make_room): menu->help_text is now `const char **';
7862 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7863 to changes in oldXMenu/XMenu.h from 2011-04-16.
7864 (struct XMenu): Declare `help_text' `const char **'.
7866 * xfaces.c <Qunspecified>: Make extern again.
7868 * syntax.c: Include sys/types.h before including regex.h, as
7871 * doc.c (get_doc_string): Improve the format passed to `error'.
7873 * doprnt.c (doprnt): Improve commentary.
7875 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7877 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7880 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7881 changes in globals.h immediately force recompilation.
7882 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7883 $(CURDIR)/s/ms-w32.h.
7884 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7886 * character.c (Fchar_direction): Function deleted.
7887 (syms_of_character): Don't defsubr it.
7888 <char-direction-table>: Deleted.
7890 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7892 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7893 * doprnt.c: Include limits.h.
7894 (SIZE_MAX): New macro.
7895 (doprnt): Return a size_t value. 2nd arg is now size_t.
7896 Many local variables are now size_t instead of int or unsigned.
7897 Improve overflow protection. Support `l' modifier for integer
7898 conversions. Support %l conversion. Don't assume an EMACS_INT
7899 argument for integer conversions and for %c.
7901 * lisp.h (doprnt): Restore prototype.
7903 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7906 * Makefile.in (base_obj): Add back doprnt.o.
7908 * deps.mk (doprnt.o): Add back prerequisites.
7909 (callint.o): Depend on character.h.
7911 * eval.c (internal_lisp_condition_case): Include the handler
7912 representation in the error message.
7913 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7914 when breaking from the loop.
7916 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7918 * callint.c (Fcall_interactively): When displaying error message
7919 about invalid control letter, pass the character's codepoint, not
7920 a pointer to its multibyte form. Improve display of the character
7921 in octal and display also its hex code.
7923 * character.c (char_string): Use %x to display the (unsigned)
7924 codepoint of an invalid character, to avoid displaying a bogus
7927 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7928 `error', not SYMBOL_NAME itself.
7930 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7931 character arguments to `error'.
7933 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7934 to `error' in error message about FINAL_CHAR argument. Make sure
7935 FINAL_CHAR is a character, and use %c when it is passed as
7936 argument to `error'.
7938 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7940 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7942 * w32.c: Include <time.h>.
7943 (sys_localtime): New function.
7945 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7947 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7949 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7951 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7953 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7956 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7958 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7959 gl_state.e_property when gl_state.object is Qt.
7961 * insdel.c (make_gap_larger): Remove limitation of buffer size
7964 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7966 * xdisp.c (lookup_glyphless_char_display)
7967 (produce_glyphless_glyph): Handle cons cell entry in
7968 glyphless-char-display.
7969 (Vglyphless_char_display): Document it.
7971 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7972 glyphless-char-display.
7974 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7976 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7978 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7980 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7981 definition for no-X builds.
7983 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7985 Static checks with GCC 4.6.0 and non-default toolkits.
7987 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7989 * process.c (keyboard_bit_set): Define only if SIGIO.
7990 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7991 (send_process): Repair possible setjmp clobbering.
7993 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7995 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7997 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7999 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8000 Define only if needed.
8002 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8003 by pacifying GCC about it. Maybe it's time to retire it?
8004 * xfaces.c (USG, __TIMEVAL__): Likewise.
8006 * dispextern.h (struct redisplay_interface): Rename param
8008 * termhooks.h (struct terminal): Likewise.
8009 * xterm.c (xembed_send_message): Likewise.
8011 * insdel.c (make_gap_smaller): Define only if
8012 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8014 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8017 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8018 so that we aren't warned about unused symbols.
8020 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8022 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8024 * xfns.c (x_real_positions): Mark locals as initialized.
8026 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8028 * xterm.c: Fix problems found by static analysis with other toolkits.
8029 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8030 (x_dispatch_event): Declare static if USE_GTK, and
8031 define if USE_GTK || USE_X_TOOLKIT.
8032 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8033 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8034 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8035 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
8037 * xmenu.c (menu_help_callback): Pointer type fixes.
8038 Use const pointers when pointing at readonly data. Avoid pointer
8040 (FALSE): Remove unused macro.
8041 (update_frame_menubar): Remove unused decl.
8043 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8045 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8046 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8047 (single_menu_item): Rename local to avoid shadowing.
8049 * keyboard.c (make_lispy_event): Remove unused local var.
8051 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8052 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8054 * bitmaps: Change bitmaps from unsigned char back to the X11
8055 compatible char. Avoid the old compiler warnings about
8056 out-of-range initializers by using, for example, '\xab' rather
8059 * xgselect.c (xgselect_initialize): Check vs interface
8060 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8062 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8064 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8065 to read-only memory.
8067 * fns.c (vector): Remove; this old hack is no longer needed.
8069 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
8071 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
8073 * xrdb.c (x_load_resources): Omit unused local.
8075 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8076 (x_window): Rename locals to avoid shadowing.
8077 (USG): Use the kludged USG macro, to pacify gcc.
8079 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
8080 (x_term_init): Remove local to avoid shadowing.
8082 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
8084 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8085 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8087 2011-04-16 Eli Zaretskii <eliz@gnu.org>
8089 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8091 Fix regex.c, syntax.c and friends for buffers > 2GB.
8092 * syntax.h (struct gl_state_s): Declare character position members
8095 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8097 * textprop.c (verify_interval_modification, interval_of):
8098 Declare arguments EMACS_INT.
8100 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8103 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8105 * indent.c (Fvertical_motion): Local variable it_start is now
8108 * regex.c (re_match, re_match_2, re_match_2_internal)
8109 (bcmp_translate, regcomp, regexec, print_double_string)
8110 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8111 (re_compile_pattern, re_exec): Declare arguments and local
8112 variables `size_t' and `ssize_t' and return values `regoff_t', as
8114 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8115 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8116 <compile_stack_type>: `size' and `avail' are now `size_t'.
8118 * regex.h <regoff_t>: Use ssize_t, not int.
8119 (re_search, re_search_2, re_match, re_match_2): Arguments that
8120 specify buffer/string position and length are now ssize_t and
8121 size_t. Return type is regoff_t.
8123 2011-04-16 Ben Key <bkey76@gmail.com>
8125 * nsfont.m: Fixed bugs in ns_get_family and
8126 ns_descriptor_to_entity that were caused by using free to
8127 deallocate memory blocks that were allocated by xmalloc (via
8128 xstrdup). This caused Emacs to crash when compiled with
8129 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8130 --enable-checking=xmallocoverrun). xfree is now used to
8131 deallocate these memory blocks.
8133 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8135 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8137 emacs_write: Accept and return EMACS_INT for sizes.
8138 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8140 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8141 Accept and return EMACS_INT.
8142 (emacs_gnutls_write): Return the number of bytes written on
8144 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8145 (emacs_read, emacs_write): Remove check for negative size, as the
8146 Emacs source code has been audited now.
8147 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8148 (emacs_read, emacs_write): Use it.
8149 * process.c (send_process): Adjust to the new signatures of
8150 emacs_write and emacs_gnutls_write. Do not attempt to store
8151 a byte offset into an 'int'; it might overflow.
8152 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8154 * sound.c: Don't assume sizes fit in 'int'.
8155 (struct sound_device.period_size, alsa_period_size):
8156 Return EMACS_INT, not int.
8157 (struct sound_device.write, vox_write, alsa_write):
8158 Accept EMACS_INT, not int.
8159 (wav_play, au_play): Use EMACS_INT to store sizes and to
8160 record read return values.
8162 2011-04-15 Ben Key <bkey76@gmail.com>
8164 * keyboard.c (Qundefined): Don't declare static since it is used
8166 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8167 static since they are used in nsfont.m.
8169 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8171 * process.c (Qprocessp): Don't declare static.
8172 * lisp.h (Qprocessp): Declare again.
8174 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8176 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8178 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8180 Improve C-level modularity by making more things 'static'.
8182 Don't publish debugger-only interfaces to other modules.
8183 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8184 (verify_bytepos, count_markers): Move decls to the only modules
8186 * region-cache.h (pp_cache): Likewise.
8187 * window.h (check_all_windows): Likewise.
8188 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8190 * sysdep.c (croak): Now static, if
8191 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8192 * syssignal.h (croak): Declare only if not static.
8194 * alloc.c (refill_memory_reserve): Now static if
8195 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8196 * lisp.h (refill_memory_reserve): Declare only if not static.
8198 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8199 Define only if USE_LUCID.
8201 * xrdb.c (x_customization_string, x_rm_string): Now static.
8203 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8204 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8206 * xdisp.c (draw_row_with_mouse_face): Now static.
8207 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8209 * window.h (check_all_windows): Mark externally visible.
8211 * window.c (window_deletion_count): Now static.
8213 * undo.c: Make symbols static if they're not exported.
8214 (last_undo_buffer, last_boundary_position, pending_boundary):
8217 * textprop.c (interval_insert_behind_hooks): Now static.
8218 (interval_insert_in_front_hooks): Likewise.
8220 * term.c: Make symbols static if they're not exported.
8221 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8222 (max_frame_lines, tty_set_terminal_modes):
8223 (tty_reset_terminal_modes, tty_turn_off_highlight):
8224 (get_tty_terminal): Now static.
8225 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8226 * termhooks.h (term_mouse_moveto): Do not declare if
8228 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8229 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8231 * sysdep.c: Make symbols static if they're not exported.
8232 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8234 (sigprocmask_set, full_mask): Remove; unused.
8235 (wait_debugging): Mark as visible.
8236 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8237 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8239 * syntax.c (syntax_temp): Define only if !__GNUC__.
8241 * sound.c (current_sound_device, current_sound): Now static.
8243 * search.c (searchbufs, searchbuf_head): Now static.
8245 * scroll.c (scroll_cost): Remove; unused.
8246 * dispextern.h (scroll_cost): Remove decl.
8248 * region-cache.h (pp_cache): Mark as externally visible.
8250 * process.c: Make symbols static if they're not exported.
8251 (process_tick, update_tick, create_process, chan_process):
8252 (Vprocess_alist, proc_buffered_char, datagram_access):
8253 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8254 (deactivate_process): Mark defn as static, as well as decl.
8255 * lisp.h (create_process): Remove decl.
8256 * process.h (chan_process, Vprocess_alist): Remove decls.
8258 * print.c: Make symbols static if they're not exported.
8259 (print_depth, new_backquote_output, being_printed, print_buffer):
8260 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8261 (print_interval, print_number_index, initial_stderr_stream):
8263 * lisp.h (Fprinc): Remove decl.
8264 (debug_output_compilation_hack): Mark as externally visible.
8266 * sysdep.c (croak): Move decl from here to syssignal.h.
8267 * syssignal.h (croak): Put it here, so the API can be checked when
8268 'croak' is called from dissociate_if_controlling_tty.
8270 * minibuf.c: Make symbols static if they're not exported.
8271 (minibuf_save_list, choose_minibuf_frame): Now static.
8272 * lisp.h (choose_minibuf_frame): Remove decl.
8274 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8276 * lread.c: Make symbols static if they're not exported.
8277 (read_objects, initial_obarray, oblookup_last_bucket_number):
8279 (make_symbol): Remove; unused.
8280 * lisp.h (initial_obarray, make_symbol): Remove decls.
8282 * keyboard.c: Make symbols static if they're not exported.
8283 (single_kboard, recent_keys_index, total_keys, recent_keys):
8284 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8285 (this_single_command_key_start, echoing, last_auto_save):
8286 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8287 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8288 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8289 (Vlispy_mouse_stem, double_click_count):
8291 (force_auto_save_soon): Define only if SIGDANGER.
8292 (ignore_mouse_drag_p): Now static if
8293 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8294 (print_help): Remove; unused.
8295 (stop_character, last_timer_event): Mark as externally visible.
8296 * keyboard.h (ignore_mouse_drag_p): Declare only if
8297 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8298 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8299 * lisp.h (echoing): Remove decl.
8300 (force_auto_save_soon): Declare only if SIGDANGER.
8301 * xdisp.c (redisplay_window): Simplify code, to make it more
8302 obvious that ignore_mouse_drag_p is not accessed if !defined
8303 USE_GTK && !defined HAVE_NS.
8305 * intervals.c: Make symbols static if they're not exported.
8306 (merge_properties_sticky, merge_interval_right, delete_interval):
8308 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8310 * insdel.c: Make symbols static if they're not exported.
8311 However, leave prepare_to_modify_buffer alone. It's never
8312 called from outside this function, but that appears to be a bug.
8313 (combine_after_change_list, combine_after_change_buffer):
8314 (adjust_after_replace, signal_before_change): Now static.
8315 (adjust_after_replace_noundo): Remove; unused.
8316 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8317 (signal_before_change): Remove decls.
8319 * indent.c (val_compute_motion, val_vmotion): Now static.
8321 * image.c: Make symbols static if they're not exported.
8322 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8324 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8325 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8327 * fringe.c (standard_bitmaps): Now static.
8328 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8330 * frame.c: Make symbols static if they're not exported.
8331 (x_report_frame_params, make_terminal_frame): Now static.
8332 (get_frame_param): Now static, unless HAVE_NS.
8333 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8334 (x_get_resource_string): Remove; not used.
8335 * frame.h (make_terminal_frame, x_report_frame_params):
8336 (x_get_resource_string); Remove decls.
8337 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8338 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8340 * font.c, fontset.c: Make symbols static if they're not exported.
8341 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8342 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8343 * font.c (font_close_object): Now static.
8344 * font.h (font_close_object): Remove.
8345 * fontset.c (FONTSET_OBJLIST): Remove.
8346 (free_realized_fontset) #if-0 the body, which does nothing.
8347 (face_suitable_for_char_p): #if-0, as it's never called.
8348 * fontset.h (face_suitable_for_char_p): Remove decl.
8349 * xfaces.c (face_at_string_position):
8350 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8351 since 0 is always ASCII.
8353 * fns.c (weak_hash_tables): Now static.
8355 * fileio.c: Make symbols static if they're not exported.
8356 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8357 (Vwrite_region_annotation_buffers): Now static.
8359 * eval.c: Make symbols static if they're not exported.
8360 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8361 * lisp.h (backtrace_list): Remove decl.
8363 * emacs.c: Make symbols static if they're not exported.
8364 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8365 (fatal_error_code, fatal_error_signal_hook, standard_args):
8367 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8368 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8369 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8370 * lisp.h (fatal_error_signal_hook): Remove decl.
8371 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8373 * editfns.c: Move a (normally-unused) function to its only use.
8374 * editfns.c, lisp.h (get_operating_system_release): Remove.
8375 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8376 worth the hassle of breaking this out.
8378 * xterm.c: Make symbols static if they're not exported.
8379 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8380 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8381 (x_destroy_window, x_delete_display):
8383 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8384 (x_mouse_leave): Remove; unused.
8385 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8386 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8387 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8389 (x_mouse_leave): Declare only if WINDOWSNT.
8390 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8391 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8394 * ftxfont.c: Make symbols static if they're not exported.
8395 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8397 * font.h (ftxfont_driver): Likewise.
8399 * xfns.c: Make symbols static if they're not exported.
8400 (x_last_font_name, x_display_info_for_name):
8401 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8402 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8403 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8404 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8405 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8406 (last_show_tip_args): Now static.
8407 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8408 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8409 (x_screen_planes): Remove; unused.
8410 * dispextern.h (x_screen_planes): Remove decl.
8412 * dispnew.c: Make symbols static if they're not exported.
8413 * dispextern.h (redraw_garbaged_frames, scrolling):
8414 (increment_row_positions): Remove.
8415 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8416 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8418 (redraw_garbaged_frames): Remove; unused.
8420 * xfaces.c: Make symbols static if they're not exported.
8421 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8423 * xterm.h (defined_color): Remove decls.
8424 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8425 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8426 (menu_face_changed_default, defined_color, free_realized_face):
8427 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8428 (ascii_face_of_lisp_face): Remove; unused.
8430 * xdisp.c: Make symbols static if they're not exported.
8431 * dispextern.h (scratch_glyph_row, window_box_edges):
8432 (glyph_to_pixel_coords, set_cursor_from_row):
8433 (get_next_display_element, set_iterator_to_next):
8434 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8435 (show_mouse_face): Remove decls
8436 * frame.h (message_buf_print): Likewise.
8437 * lisp.h (pop_message, set_message, check_point_in_composition):
8439 * xterm.h (set_vertical_scroll_bar): Likewise.
8440 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8441 (message_buf_print, scratch_glyph_row, displayed_buffer):
8442 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8443 (get_next_display_element, show_mouse_face, window_box_edges):
8444 (frame_to_window_pixel_xy, check_point_in_composition):
8445 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8446 (glyph_to_pixel_coords): Remove; unused.
8448 * dired.c (file_name_completion): Now static.
8450 * dbusbind.c (xd_in_read_queued_messages): Now static.
8452 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8453 * data.c (circular_list_error): Remove.
8455 * commands.h (last_point_position, last_point_position_buffer):
8456 (last_point_position_window): Remove decls.
8457 * keyboard.c: Make these variables static.
8459 * coding.h (coding, code_convert_region, encode_coding_gap):
8461 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8462 (iso_code_class, detect_coding, code_convert_region): Now static.
8463 (encode_coding_gap): Remove; unused.
8465 * chartab.c (chartab_chars, chartab_bits): Now static.
8467 * charset.h (charset_iso_8859_1): Remove decl.
8468 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8471 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8472 * ccl.c (Vccl_program_table): Now static.
8473 (check_ccl_update): Remove; unused.
8475 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8476 * category.h: ... from here.
8477 * category.c (check_category_table, set_category_set): Now static.
8479 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8480 * lisp.h: Remove these decls.
8482 * buffer.c (buffer_count): Remove unused var.
8484 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8485 so that it's not optimized away.
8486 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8487 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8488 exported only to the debugger.
8490 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8491 * atimer.h (run_all_atimers): Remove; not exported.
8493 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8494 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8495 was inaccessible from Lisp.
8496 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8497 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8499 alloc.c: Import and export fewer symbols, and remove unused items.
8500 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8502 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8503 it's not optimized away by whole-program optimization.
8504 (message_enable_multibyte, free_misc): Remove.
8505 (catchlist, handlerlist, mark_backtrace):
8506 Declare only if BYTE_MARK_STACK.
8507 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8508 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8509 (message_enable_multibyte): Remove decl.
8510 (free_misc, interval_free_list, float_block, float_block_index):
8511 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8512 (cons_free_list, last_marked_index):
8514 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8515 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8516 (mark_backtrace): Define only if BYTE_MARK_STACK.
8517 * xdisp.c (message_enable_multibyte): Now static.
8519 Declare Lisp_Object Q* variables to be 'static' if not exported.
8520 This makes it easier for human readers (and static analyzers)
8521 to see whether these variables are used from other modules.
8522 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8523 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8524 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8525 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8526 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8527 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8528 * xmenu.c, xselect.c:
8529 Declare Q* vars static if they are not used in other modules.
8530 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8531 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8532 Remove decls of unexported vars.
8533 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8535 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8537 Make Emacs functions such as Fatom 'static' by default.
8538 This makes it easier for human readers (and static analyzers)
8539 to see whether these functions can be called from other modules.
8540 DEFUN now defines a static function. To make the function external
8541 so that it can be used in other C modules, use the new macro DEFUE.
8542 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8543 (Finit_image_library):
8544 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8545 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8546 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8547 Remove decls, since these functions are now static.
8548 (Funintern, Fget_internal_run_time): New decls, since these functions
8549 were already external.
8551 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8552 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8553 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8554 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8555 * keyboard.c, keymap.c, lread.c:
8556 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8557 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8558 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8559 Mark functions with DEFUE instead of DEFUN,
8560 if they are used in other modules.
8561 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8562 decls for now-static functions.
8563 * buffer.h (Fdelete_overlay): Remove decl.
8564 * callproc.c (Fgetenv_internal): Mark as internal.
8565 * composite.c (Fremove_list_of_text_properties): Remove decl.
8566 (Fcomposition_get_gstring): New forward static decl.
8567 * composite.h (Fcomposite_get_gstring): Remove decl.
8568 * dired.c (Ffile_attributes): New forward static decl.
8569 * doc.c (Fdocumntation_property): New forward static decl.
8570 * eval.c (Ffetch_bytecode): New forward static decl.
8571 (Funintern): Remove extern decl; now in .h file where it belongs.
8572 * fileio.c (Fmake_symbolic_link): New forward static decl.
8573 * image.c (Finit_image_library): New forward static decl.
8574 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8575 * intervals.h (Fprevious_property_change):
8576 (Fremove_list_of_text_properties): Remove decls.
8577 * keyboard.c (Fthis_command_keys): Remove decl.
8578 (Fcommand_execute): New forward static decl.
8579 * keymap.c (Flookup_key): New forward static decl.
8580 (Fcopy_keymap): Now static.
8581 * keymap.h (Flookup_key): Remove decl.
8582 * process.c (Fget_process): New forward static decl.
8583 (Fprocess_datagram_address): Mark as internal.
8584 * syntax.c (Fsyntax_table_p): New forward static decl.
8585 (skip_chars): Remove duplicate decl.
8586 * textprop.c (Fprevious_property_change): New forward static decl.
8587 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8589 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8590 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8592 * editfns.c (Fformat): Remove unreachable code.
8594 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8596 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8599 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8601 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8602 when at ZV. (Bug#8487)
8604 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8606 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8608 * keyboard.c (parse_tool_bar_item): Likewise.
8609 * sound.c (sound_cleanup, alsa_close): Likewise.
8610 * termcap.c (tgetent): Likewise.
8611 * xfns.c (x_default_font_parameter): Likewise.
8612 * xsettings.c (read_and_apply_settings): Likewise.
8614 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8615 (overrun_check_free): Protoize.
8617 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8619 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8620 since callers should never pass a negative size.
8621 Change the signature to match that of plain 'read' and 'write'; see
8622 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8623 * lisp.h: Update prototypes of emacs_write and emacs_read.
8625 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8627 * xdisp.c (redisplay_window): Don't try to determine the character
8628 position of the scroll margin if the window start point w->startp
8629 is outside the buffer's accessible region. (Bug#8468)
8631 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8633 Fix write-region and its subroutines for buffers > 2GB.
8634 * fileio.c (a_write, e_write): Modify declaration of arguments and
8635 local variables to support buffers larger than 2GB.
8636 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8638 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8639 argument, local variables, and return value.
8641 * lisp.h: Update prototypes of emacs_write and emacs_read.
8643 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8645 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8647 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8649 Fix more problems found by GCC 4.6.0's static checks.
8651 * xdisp.c (vmessage): Use a better test for character truncation.
8653 * charset.c (load_charset_map): <, not <=, for optimization,
8654 and to avoid potential problems with integer overflow.
8655 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8656 * casetab.c (set_identity, shuffle): Likewise.
8657 * editfns.c (Fformat): Likewise.
8658 * syntax.c (skip_chars): Likewise.
8660 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8661 This also lets GCC 4.6.0 generate slightly better loop code.
8663 * callint.c (Fcall_interactively): <, not <=, for optimization.
8664 (Fcall_interactively): Count the number of arguments produced,
8665 not the number of arguments given. This is simpler and lets GCC
8666 4.6.0 generate slightly better code.
8668 * ftfont.c: Distingish more carefully between FcChar8 and char.
8669 The previous code passed unsigned char * to a functions like
8670 strlen and xstrcasecmp that expect char *, which does not
8671 conform to the C standard.
8672 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8673 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8674 char * when the C standard requires it.
8676 * keyboard.c (read_char): Remove unused var.
8678 * eval.c: Port to Windows vsnprintf (Bug#8435).
8680 (SIZE_MAX): Define if the headers do not.
8681 (verror): Do not give up if vsnprintf returns a negative count.
8682 Instead, grow the buffer. This ports to Windows vsnprintf, which
8683 does not conform to C99. Problem reported by Eli Zaretskii.
8684 Also, simplify the allocation scheme, by avoiding the need for
8685 calling realloc, and removing the ALLOCATED variable.
8687 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8689 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8690 But keep the doprint source code for now, as we might revamp it
8691 and use it again (Bug#8435).
8692 * lisp.h (doprnt): Remove.
8693 * Makefile.in (base_obj): Remove doprnt.o.
8694 * deps.mk (doprnt.o): Remove.
8696 error: Print 32- and 64-bit integers portably (Bug#8435).
8697 Without this change, on typical 64-bit hosts error ("...%d...", N)
8698 was used to print both 32- and 64-bit integers N, which relied on
8700 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8701 * lisp.h (error, verror): Mark as printf-like functions.
8702 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8703 Report overflow in size calculations when allocating printf buffer.
8704 Do not truncate output string at its first null byte.
8705 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8706 Truncate the output at a character boundary, since vsnprintf does not
8708 * charset.c (check_iso_charset_parameter): Convert internal
8709 character to string before calling 'error', since %c now has the
8711 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8712 overflow when computing char to be passed to 'error'. Do not
8713 pass Lisp_Object to 'error'; pass the integer instead.
8714 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8715 formatted with plain %d.
8717 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8719 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8721 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8723 * xterm.c (x_catch_errors): Remove duplicate declaration.
8725 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8727 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8729 2011-04-10 Jim Meyering <meyering@redhat.com>
8731 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8732 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8733 return ssize_t not "int", and use size_t as the buffer length.
8734 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8735 * gnutls.h: Update declarations.
8736 * process.c (read_process_output): Use ssize_t, to match.
8737 (send_process): Likewise.
8739 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8741 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8743 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8745 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8746 Use unsigned char, to match FcChar8 type definition.
8748 * xterm.c (handle_one_xevent):
8749 * xmenu.c (create_and_show_popup_menu):
8750 * xselect.c (x_decline_selection_request)
8751 (x_reply_selection_request): Avoid type-punned deref of X events.
8753 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8755 Fix some uses of `int' instead of EMACS_INT.
8756 * search.c (string_match_1, fast_string_match)
8757 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8758 (scan_buffer, find_next_newline_no_quit)
8759 (find_before_next_newline, search_command, Freplace_match)
8760 (Fmatch_data): Make some `int' variables be EMACS_INT.
8762 * xdisp.c (display_count_lines): 3rd argument and return value now
8763 EMACS_INT. All callers changed.
8764 (pint2hrstr): Last argument is now EMACS_INT.
8766 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8767 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8768 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8769 (decode_coding_utf_16, decode_coding_emacs_mule)
8770 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8771 (decode_coding_ccl, decode_coding_charset)
8772 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8773 (decode_coding_iso_2022, decode_coding_emacs_mule)
8774 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8775 <char_offset, last_offset>: Declare EMACS_INT.
8776 (encode_coding_utf_8, encode_coding_utf_16)
8777 (encode_coding_emacs_mule, encode_invocation_designation)
8778 (encode_designation_at_bol, encode_coding_iso_2022)
8779 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8780 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8782 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8783 (encode_invocation_designation): Last argument P_NCHARS is now
8785 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8786 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8788 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8791 * ccl.c (Fccl_execute_on_string): Declare some variables
8794 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8796 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8798 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8800 * process.c (Fformat_network_address): Doc fix.
8802 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8804 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8806 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8808 * keyboard.c (read_char): Call Lisp function help-form-show,
8809 instead of using internal_with_output_to_temp_buffer.
8810 (Qhelp_form_show): New var.
8811 (syms_of_keyboard): Use DEFSYM macro.
8813 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8815 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8817 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8819 * process.c (Flist_processes): Remove to Lisp.
8820 (list_processes_1): Delete.
8822 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8824 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8826 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8828 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8830 Fix more problems found by GCC 4.6.0's static checks.
8832 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8834 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8836 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8838 * xdisp.c (vmessage): Mark as a printf-like function.
8840 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8842 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8844 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8845 printf-like functions.
8846 (tiff_load): Add casts to remove these marks before passing them
8847 to system-supplied API.
8849 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8851 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8852 This avoids several warnings with gcc -Wstrict-overflow.
8853 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8854 directly, rather than having caller test rule sign. This avoids
8855 some unnecessary tests.
8856 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8857 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8858 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8860 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8861 (xfont_open): Avoid unnecessary tests.
8863 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8865 * composite.h, composite.c (composition_gstring_put_cache):
8866 Use EMACS_INT, not int, for length.
8868 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8869 breaking out part of COMPOSITION_DECODE_RULE.
8870 (COMPOSITION_DECODE_RULE): Use it.
8871 * composite.c (get_composition_id): Remove unused local vars,
8872 by using the new macro.
8874 * textprop.c (set_text_properties_1): Change while to do-while,
8875 since the condition is always true at first.
8877 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8878 (interval_deletion_adjustment): Return unsigned value.
8881 * process.c (list_processes_1, create_pty, read_process_output):
8882 (exec_sentinel): Remove vars that were set but not used.
8883 (create_pty): Remove unnecessary "volatile"s.
8884 (Fnetwork_interface_info): Avoid possibility of int overflow.
8885 (read_process_output): Do adaptive read buffering even if carryover.
8886 (read_process_output): Simplify nbytes computation if buffered.
8888 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8890 * syntax.c (scan_words): Remove var that was set but not used.
8891 (update_syntax_table): Use unsigned instead of int.
8893 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8894 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8895 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8897 * print.c (print_error_message): Avoid int overflow.
8899 * font.c (font_list_entities): Redo for clarity,
8900 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8902 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8903 (font_score): Avoid potential overflow in diff calculation.
8905 * fns.c (substring_both): Remove var that is set but not used.
8906 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8908 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8910 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8911 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8912 can always succeed if overflow has undefined behavior.
8914 * search.c (boyer_moore, wordify): Remove vars set but not used.
8915 (wordify): Omit three unnecessary tests.
8917 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8918 All callers changed. This avoids the need for an unused var.
8920 * casefiddle.c (casify_region): Remove var that is set but not used.
8922 * dired.c (file_name_completion): Remove var that is set but not used.
8924 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8926 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8927 (Finsert_file_contents): Remove unnecessary code checking fd.
8929 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8930 Check for integer overflow on size calculations.
8932 * buffer.c (Fprevious_overlay_change): Remove var that is set
8935 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8936 Remove vars that are set but not used.
8937 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8938 (timer_check_2): Mark vars as initialized.
8940 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8942 * image.c (lookup_image): Remove var that is set but not used.
8943 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8945 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8946 that are set but not used.
8948 * xfns.c (make_invisible_cursor): Don't return garbage
8949 if XCreateBitmapFromData fails (Bug#8410).
8951 * xselect.c (x_get_local_selection, x_handle_property_notify):
8952 Remove vars that are set but not used.
8954 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8955 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8957 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8958 Remove var that is set but not used.
8959 (scroll_bar_windows_size): Now size_t, not int.
8960 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8963 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8964 (map_tty_color) [!defined MSDOS]: Likewise.
8966 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8968 * coding.c: Remove vars that are set but not used.
8969 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8970 All callers changed.
8971 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8972 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8973 (decode_coding_charset): Remove vars that are set but not used.
8975 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8976 that is set but not used.
8978 * print.c (print_object): Remove var that is set but not used.
8980 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8981 The gnulib version avoids calling malloc in the usual case,
8982 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8983 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8984 * filelock.c (current_lock_owner): Likewise.
8985 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8986 * sysdep.c: Include allocator.h, careadlinkat.h.
8987 (emacs_no_realloc_allocator): New static constant.
8988 (emacs_readlink): New function.
8989 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8990 ../lib/careadlinkat.h.
8992 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8994 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8995 first non-nil return value).
8997 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8999 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9000 if not defined (Bug#8403).
9002 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9004 * xdisp.c (display_count_lines): Remove parameter `start',
9005 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9006 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9007 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9008 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9009 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9010 and thereabouts. All callers changed.
9011 (get_per_char_metric): Remove parameter `f', unused since
9012 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9014 2011-04-02 Jim Meyering <meyering@redhat.com>
9016 do not dereference NULL upon failed strdup
9017 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9018 (ns_get_family): Likewise.
9020 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9022 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9024 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9026 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9029 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9031 Add lexical binding.
9033 * window.c (Ftemp_output_buffer_show): New fun.
9034 (Fsave_window_excursion):
9035 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9037 * lread.c (lisp_file_lexically_bound_p): New function.
9038 (Fload): Bind Qlexical_binding.
9039 (readevalloop): Remove `evalfun' arg.
9040 Bind Qinternal_interpreter_environment.
9041 (Feval_buffer): Bind Qlexical_binding.
9042 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9044 (syms_of_lread): Declare `lexical-binding'.
9046 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9048 * keyboard.c (eval_dyn): New fun.
9049 (menu_item_eval_property): Use it.
9051 * image.c (parse_image_spec): Use Ffunctionp.
9053 * fns.c (concat, mapcar1): Accept byte-code-functions.
9055 * eval.c (Fsetq): Handle lexical vars.
9056 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9057 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9058 (FletX, Flet): Obey lexical binding.
9059 (Fcommandp): Handle closures.
9060 (Feval): New `lexical' arg.
9061 (eval_sub): New function extracted from Feval. Use it almost
9062 everywhere where Feval was used. Look up vars in lexical env.
9064 (Ffunctionp): Move from subr.el.
9065 (Ffuncall): Handle closures.
9066 (apply_lambda): Remove `eval_flags'.
9067 (funcall_lambda): Handle closures and new byte-code-functions.
9068 (Fspecial_variable_p): New function.
9069 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9070 but without exporting it to Lisp.
9072 * doc.c (Fdocumentation, store_function_docstring):
9073 * data.c (Finteractive_form): Handle closures.
9075 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9078 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9080 (exec_byte_code): New function extracted from Fbyte_code to handle new
9081 calling convention for byte-code-functions. Add new byte-codes.
9083 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
9085 * alloc.c (Fmake_symbol): Init new `declared_special' field.
9087 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9089 * xdisp.c (redisplay_internal): Fix prototype.
9091 2011-03-31 Eli Zaretskii <eliz@gnu.org>
9093 * xdisp.c (SCROLL_LIMIT): New macro.
9094 (try_scrolling): Use it when setting scroll_limit.
9095 Limit scrolling to 100 screen lines.
9096 (redisplay_window): Even when falling back on "recentering",
9097 position point in the window according to scroll-conservatively,
9098 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9100 (try_scrolling): When point is above the window, allow searching
9101 as far as scroll_max, or one screenful, to compute vertical
9102 distance from PT to the scroll margin position. This prevents
9103 try_scrolling from unnecessarily failing when
9104 scroll-conservatively is set to a value slightly larger than the
9105 window height. Clean up the case of PT below the margin at bottom
9106 of window: scroll_max can no longer be INT_MAX. When aggressive
9107 scrolling is in use, don't let point enter the opposite scroll
9108 margin as result of the scroll.
9109 (syms_of_xdisp) <scroll-conservatively>: Document the
9110 threshold of 100 lines for never-recentering scrolling.
9112 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9114 * dispextern.h (move_it_by_lines):
9115 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9116 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9117 (message_log_check_duplicate): Remove parameters `prev_bol' and
9118 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9119 (redisplay_internal): Remove parameter `preserve_echo_area',
9120 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9122 * indent.c (Fvertical_motion):
9123 * window.c (window_scroll_pixel_based, Frecenter):
9124 Don't pass `need_y_p' to `move_it_by_lines'.
9126 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9128 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9129 steal a few bits to be more compact.
9130 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9131 Remove unneeded casts.
9133 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9135 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9137 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9138 binding" message (bug#7967).
9140 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9142 Fix more problems found by GCC 4.6.0's static checks.
9144 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9145 Remove unused local var.
9147 * editfns.c (Fmessage_box): Remove unused local var.
9149 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9150 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9151 Omit unused local vars.
9152 * window.c (shrink_windows): Omit unused local var.
9153 * menu.c (digest_single_submenu): Omit unused local var.
9154 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9155 Omit unused local var.
9157 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9158 Don't assume string length fits in int.
9159 (keyremap_step, read_key_sequence): Use size_t for sizes.
9160 (read_key_sequence): Don't check last_real_key_start redundantly.
9162 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9163 instead of alloca (Bug#8344).
9165 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9166 (Fbacktrace_frame): Don't assume nframes fits in int.
9168 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9170 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9173 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9175 * cm.c (calccost): Turn while-do into do-while, for clarity.
9177 * keyboard.c (syms_of_keyboard): Use the same style as later
9178 in this function when indexing through an array. This also
9179 works around GCC bug 48267.
9181 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9183 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9185 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9186 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9188 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9189 This avoids undefined behavior on integer overflow, and is a bit
9190 more convenient anyway since it is compared to a size_t variable.
9192 Variadic C functions now count arguments with size_t, not int.
9193 This avoids an unnecessary limitation on 64-bit machines, which
9194 caused (substring ...) to crash on large vectors (Bug#8344).
9195 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9196 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9197 All variadic functions and their callers changed accordingly.
9198 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9199 * data.c (arith_driver, float_arith_driver): Likewise.
9200 * editfns.c (general_insert_function): Likewise.
9201 * eval.c (struct backtrace.nargs, interactive_p)
9202 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9203 (funcall_lambda, mark_backtrace): Likewise.
9204 * fns.c (concat): Likewise.
9205 * frame.c (x_set_frame_parameters): Likewise.
9206 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9207 0 if not found, not -1. All callers changed.
9209 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9210 (stack_copy_size): Now size_t, not int.
9211 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9213 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9215 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9216 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9217 All callers changed.
9219 * lisp.h (multibyte_char_to_unibyte):
9220 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9221 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9222 * character.h (CHAR_TO_BYTE8):
9223 * cmds.c (internal_self_insert):
9224 * editfns.c (general_insert_function):
9225 * keymap.c (push_key_description):
9226 * search.c (Freplace_match):
9227 * xdisp.c (message_dolog, set_message_1): All callers changed.
9229 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9231 * keyboard.c (safe_run_hook_funcall): New function.
9232 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9233 don't set the hook to nil, but remove the offending function instead.
9234 (Qcommand_hook_internal): Remove, unused.
9235 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9236 Vcommand_hook_internal.
9238 * eval.c (enum run_hooks_condition): Remove.
9239 (funcall_nil, funcall_not): New functions.
9240 (run_hook_with_args): Call each function through a `funcall' argument.
9241 Remove `cond' argument, now redundant.
9242 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9243 (Frun_hook_with_args_until_failure): Adjust accordingly.
9244 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9246 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9248 * dispextern.h (string_buffer_position): Remove declaration.
9250 * print.c (strout): Remove parameter `multibyte', unused since
9251 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9253 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9254 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9255 All callers changed.
9257 * w32.c (_wsa_errlist): Use braces for struct initializers.
9259 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9260 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9261 All callers changed.
9262 (string_buffer_position): Likewise. Also, make static (it's never
9263 used outside xdisp.c).
9264 (cursor_row_p): Remove parameter `w', unused since
9265 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9266 (decode_mode_spec): Remove parameter `precision', introduced during
9267 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9268 All callers changed.
9270 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9272 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9274 2011-03-27 Anders Lindgren <andlind@gmail.com>
9276 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9277 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9278 (ns_update_auto_hide_menu_bar): New functions.
9279 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9280 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9281 ns_constrain_all_frames.
9282 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9283 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9285 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9287 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9289 2011-03-27 Glenn Morris <rgm@gnu.org>
9291 * syssignal.h: Replace RETSIGTYPE with void.
9292 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9293 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9294 Replace SIGTYPE with void everywhere.
9295 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9296 * s/template.h (SIGTYPE): Remove commented out definition.
9298 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9300 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9301 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9303 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9305 * w32.c (read_unc_volume): Use parameter `henum', instead of
9306 global variable `wget_enum_handle'.
9308 * keymap.c (describe_vector): Remove parameters `indices' and
9309 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9310 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9312 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9314 * keyboard.c (timer_check): Remove parameter `do_it_now',
9315 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9316 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9317 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9319 * keyboard.c (read_char):
9320 * w32menu.c (w32_menu_display_help):
9321 * xmenu.c (show_help_event, menu_help_callback):
9322 Adjust calls to `show_help_echo'.
9324 * gtkutil.c (xg_maybe_add_timer):
9325 * keyboard.c (readable_events):
9326 * process.c (wait_reading_process_output):
9327 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9329 * insdel.c (adjust_markers_gap_motion):
9330 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9331 (gap_left, gap_right): Don't call it.
9333 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9335 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9336 incurred during fontification.
9338 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9340 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9341 (DEFVAR_PER_BUFFER): Don't pass it.
9343 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9344 (scrolling_window): Don't pass it.
9346 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9348 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9350 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9352 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9353 of variables specific to SELinux and computation of `encoded_absname'.
9355 * image.c (XPutPixel): Remove unused variable `height'.
9357 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9359 * unexw32.c (get_section_info): Remove unused variable `section'.
9361 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9362 (system_process_attributes): Remove unused variable `sess'.
9363 (sys_read): Remove unused variable `err'.
9365 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9366 (w32_wnd_proc): Remove unused variable `isdead'.
9367 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9368 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9369 (x_create_tip_frame): Remove unused variable `tem'.
9371 * w32inevt.c (w32_console_read_socket):
9372 Remove unused variable `no_events'.
9374 * w32term.c (x_draw_composite_glyph_string_foreground):
9375 Remove unused variable `width'.
9377 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9379 * w32term.c (x_set_glyph_string_clipping):
9380 Don't pass uninitialized region to CombineRgn.
9382 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9384 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9385 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9386 (Fx_close_connection): Remove unused variable `i'.
9388 * w32font.c (w32font_draw): Return number of glyphs.
9389 (w32font_open_internal): Remove unused variable `i'.
9390 (w32font_driver): Add missing initializer.
9392 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9393 (fill_in_menu): Remove unused variable `items_added'.
9395 * w32term.c (last_mouse_press_frame): Remove static global variable.
9396 (w32_clip_to_row): Remove unused variable `f'.
9397 (x_delete_terminal): Remove unused variable `i'.
9399 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9400 (NOTHING): Remove unused static global variable.
9401 (uniscribe_check_otf): Remove unused variable `table'.
9402 (uniscribe_font_driver): Add missing initializers.
9404 2011-03-23 Julien Danjou <julien@danjou.info>
9406 * term.c (Fsuspend_tty, Fresume_tty):
9407 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9408 * window.c (temp_output_buffer_show):
9409 * insdel.c (signal_before_change):
9410 * frame.c (Fhandle_switch_frame):
9411 * fileio.c (Fdo_auto_save):
9412 * emacs.c (Fkill_emacs):
9413 * editfns.c (save_excursion_restore):
9414 * cmds.c (internal_self_insert):
9415 * callint.c (Fcall_interactively):
9416 * buffer.c (Fkill_all_local_variables):
9417 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9419 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9420 unconditionally since it does the check itself.
9422 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9424 Fix more problems found by GCC 4.5.2's static checks.
9426 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9427 the first time through the loop, since we know p0 < p1 then.
9428 This also avoids a gcc -Wstrict-overflow warning.
9430 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9431 leading to a memory leak, possible in functions like
9432 load_charset_map_from_file that can allocate an unbounded number
9433 of objects (Bug#8318).
9435 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9436 that could (at least in theory) be that large.
9438 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9439 This is less likely to overflow, and avoids undefined behavior if
9440 overflow does occur. All callers changed. Use strtoul to scan
9441 for the unsigned long integer.
9442 (pint2hrstr): Simplify and tune code slightly.
9443 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9445 * scroll.c (do_scrolling): Work around GCC bug 48228.
9446 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9448 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9449 This also avoids a warning with gcc -Wstrict-overflow.
9450 (validate_x_resource_name): Simplify count usage.
9451 This also avoids a warning with gcc -Wstrict-overflow.
9453 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9456 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9458 * process.c (Fmake_network_process): Use socklen_t, not int,
9459 where POSIX says socklen_t is required in portable programs.
9460 This fixes a porting bug on hosts like 64-bit HP-UX, where
9461 socklen_t is wider than int (Bug#8277).
9462 (Fmake_network_process, server_accept_connection):
9463 (wait_reading_process_output, read_process_output):
9466 * process.c: Rename or move locals to avoid shadowing.
9467 (list_processes_1, Fmake_network_process):
9468 (read_process_output_error_handler, exec_sentinel_error_handler):
9469 Rename or move locals.
9470 (Fmake_network_process): Define label "retry_connect" only if needed.
9471 (Fnetwork_interface_info): Fix pointer signedness.
9472 (process_send_signal): Add cast to avoid pointer signedness problem.
9473 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9474 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9476 Make tparam.h and terminfo.c consistent.
9477 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9478 Include tparam.h instead, since it declares them.
9479 * cm.h (PC): Remove extern decl; tparam.h now does this.
9480 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9481 * terminfo.c: Include tparam.h, to check interfaces.
9482 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9483 (tparam): Adjust signature to match interface in tparam.h;
9484 this removes some undefined behavior. Check that outstring and len
9485 are zero, which they always are with Emacs.
9486 * tparam.h (PC, BC, UP): New extern decls.
9488 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9489 (xftfont_open): Rename locals to avoid shadowing.
9491 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9492 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9493 (OTF_TAG_SYM): Omit macro if not needed.
9494 (ftfont_list): Remove unused local.
9495 (get_adstyle_property, ftfont_pattern_entity):
9496 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9497 Rename locals to avoid shadowing.
9499 * xfont.c (xfont_list_family): Mark var as initialized.
9501 * xml.c (make_dom): Now static.
9503 * composite.c (composition_compute_stop_pos): Rename local to
9505 (composition_reseat_it): Remove unused locals.
9506 (find_automatic_composition, composition_adjust_point): Likewise.
9507 (composition_update_it): Mark var as initialized.
9508 (find_automatic_composition): Mark vars as initialized,
9509 with a FIXME (Bug#8290).
9511 character.h: Rename locals to avoid shadowing.
9512 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9513 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9514 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9515 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9518 * textprop.c (property_change_between_p): Remove; unused.
9520 * intervals.c (interval_start_pos): Now static.
9522 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9524 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9525 Rename locals to avoid shadowing.
9527 * sound.c (wav_play, au_play, Fplay_sound_internal):
9528 Fix pointer signedness.
9529 (alsa_choose_format): Remove unused local var.
9530 (wav_play): Initialize a variable to 0, to prevent undefined
9531 behavior (Bug#8278).
9533 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9535 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9537 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9538 clobbering (Bug#8298).
9539 * sysdep.c (sys_subshell): Likewise.
9540 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9542 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9543 This should get cleaned up, so that child_setup has the
9544 same signature on all platforms.
9546 * callproc.c (call_process_cleanup): Now static.
9547 (relocate_fd): Rename locals to avoid shadowing.
9549 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9551 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9552 not to be necessary, and produces flickering.
9554 2011-03-20 Glenn Morris <rgm@gnu.org>
9556 * config.in: Remove file.
9558 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9560 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9561 are now in src/globals.h.
9562 (syms_of_minibuf): Remove spurious & from previous change.
9564 2011-03-20 Leo Liu <sdl.web@gmail.com>
9566 * minibuf.c (completing-read-function): New variable.
9567 (completing-read-default): Rename from completing-read.
9568 (completing-read): Call completing-read-function.
9570 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9572 * xfaces.c (Fx_load_color_file):
9573 Read color file from absolute filename (bug#8250).
9575 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9577 * makefile.w32-in: Update dependencies.
9579 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9581 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9583 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9585 Fix more problems found by GCC 4.5.2's static checks.
9587 * process.c (make_serial_process_unwind, send_process_trap):
9588 (sigchld_handler): Now static.
9590 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9591 That way, the code declares only the vars that it needs.
9592 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9593 * s/cygwin.h (PTY_ITERATION): Likewise.
9594 * s/darwin.h (PTY_ITERATION): Likewise.
9595 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9597 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9598 * process.c (allocate_pty): Don't declare stb unless it's needed.
9600 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9601 (CONSTANTLIM): Remove; unused.
9602 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9603 Define only if needed.
9605 * unexelf.c (unexec): Name an expression,
9606 to avoid gcc -Wbad-function-cast warning.
9607 Use a different way to cause a compilation error if anyone uses
9608 n rather than nn, a way that does not involve shadowing.
9609 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9611 * deps.mk (unexalpha.o): Remove; unused.
9613 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9614 * unexec.h: New file.
9615 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9616 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9618 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9619 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9620 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9621 Change as necessary to match prototype in unexec.h.
9623 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9625 (back_comment, skip_chars): Mark vars as initialized.
9627 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9628 Rename locals to avoid shadowing.
9630 * lread.c (read1): Rewrite so as not to use empty "else".
9631 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9633 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9635 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9636 warning when compiling print.c.
9638 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9639 instead of using an uninitialized var.
9640 (font_sort_entities): Mark var as initialized.
9642 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9644 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9645 pointers to constants.
9646 (font_parse_fcname): Remove unused vars.
9647 (font_delete_unmatched): Now static.
9648 (font_get_spec): Remove; unused.
9649 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9650 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9651 Rename or move locals to avoid shadowing.
9653 * fns.c (require_nesting_list, require_unwind): Now static.
9654 (Ffillarray): Rename locals to avoid shadowing.
9656 * floatfns.c (domain_error2): Define only if needed.
9657 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9659 * alloc.c (mark_backtrace): Move decl from here ...
9660 * lisp.h: ... to here, so that it can be checked.
9662 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9663 (Fdefvar): Rewrite so as not to use empty "else".
9664 (lisp_indirect_variable): Name an expression,
9665 to avoid gcc -Wbad-function-cast warning.
9666 (Fdefvar): Rename locals to avoid shadowing.
9668 * callint.c (quotify_arg, quotify_args): Now static.
9669 (Fcall_interactively): Rename locals to avoid shadowing.
9670 Use const pointer when appropriate.
9672 * lisp.h (get_system_name, get_operating_system_release):
9673 Move decls here, to check interfaces.
9674 * process.c (get_operating_system_release): Move decl to lisp.h.
9675 * xrdb.c (get_system_name): Likewise.
9676 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9677 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9678 some of which prompt warnings from gcc -Wbad-function-cast.
9679 (Fformat_time_string, Fencode_time, Finsert_char):
9680 (Ftranslate_region_internal, Fformat):
9681 Rename or remove local vars to avoid shadowing.
9682 (Ftranslate_region_internal): Mark var as initialized.
9684 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9687 * lisp.h (eassert): Check that the argument compiles, even if
9688 ENABLE_CHECKING is not defined.
9690 * data.c (Findirect_variable): Name an expression, to avoid
9691 gcc -Wbad-function-cast warning.
9692 (default_value, arithcompare, arith_driver, arith_error): Now static.
9693 (store_symval_forwarding): Rename local to avoid shadowing.
9694 (Fmake_variable_buffer_local, Fmake_local_variable):
9695 Mark variables as initialized.
9696 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9698 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9699 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9700 Rename locals to avoid shadowing.
9701 (mark_stack): Move local variables into the #ifdef region where
9703 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9704 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9706 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9707 (GC_STRING_CHARS): Remove; not used.
9708 (Fmemory_limit): Cast sbrk's returned value to char *.
9710 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9711 avoids undefined behavior in theory.
9713 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9715 Use functions, not macros, for up- and down-casing (Bug#8254).
9716 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9717 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9718 to use the following functions instead of these macros.
9719 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9720 EMACS_INT, since callers assume the returned value fits in int.
9721 (upcase1): Likewise, for UPCASE_TABLE.
9722 (uppercasep, lowercasep, upcase): New static inline functions.
9723 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9724 the race-condition problem in the old DOWNCASE.
9726 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9727 Rename locals to avoid shadowing.
9728 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9729 (regex_compile, re_search_2, re_match_2_internal):
9730 Remove unused local vars.
9731 (FREE_VAR): Rewrite so as not to use empty "else",
9732 which gcc can warn about.
9733 (regex_compile, re_match_2_internal): Mark locals as initialized.
9734 (RETALLOC_IF): Define only if needed.
9735 (WORDCHAR_P): Likewise. This one is never needed, but is used
9736 only in a comment talking about a compiler bug, so put inside
9737 the #if 0 of that comment.
9738 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9739 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9742 * search.c (boyer_moore): Rename locals to avoid shadowing.
9743 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9744 (PREV_CHAR_BOUNDARY): Likewise.
9746 * search.c (simple_search): Remove unused var.
9748 * dired.c (compile_pattern): Move decl from here ...
9749 * lisp.h: ... to here, so that it can be checked.
9750 (struct re_registers): New forward decl.
9752 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9754 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9756 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9757 Rename locals to avoid shadowing.
9758 (Fvertical_motion): Mark locals as initialized.
9760 * casefiddle.c (casify_object, casify_region): Now static.
9761 (casify_region): Mark local as initialized.
9763 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9765 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9766 New macros, so that the caller can use some names other than
9767 gcpro1, gcpro2, etc.
9768 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9770 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9771 argument, for consistency with GCPRO2_VAR, etc: it is now the
9772 prefix of the variable, not the variable itself. All uses
9774 * dired.c (directory_files_internal, file_name_completion):
9775 Rename locals to avoid shadowing.
9777 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9778 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9779 dired.c's scmp function, had undefined behavior.
9780 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9781 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9782 * buffer.h: ... to here, because these macros use current_buffer,
9783 and the new implementation with inline functions needs to have
9784 current_buffer in scope now, rather than later when the macros
9786 (downcase, upcase1): New static inline functions.
9787 (DOWNCASE, UPCASE1): Reimplement using these functions.
9788 This avoids undefined behavior in expressions like
9789 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9790 from race conditions in accessing the global variables
9791 case_temp1 and case_temp2.
9792 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9793 * lisp.h (case_temp1, case_temp2): Remove their decls.
9794 * character.h (ASCII_CHAR_P): Move from here ...
9795 * lisp.h: ... to here, so that the inline functions mentioned
9798 * dired.c (directory_files_internal_unwind): Now static.
9800 * fileio.c (file_name_as_directory, directory_file_name):
9801 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9803 (file_name_as_directory): Use const pointers when appropriate.
9804 (Fexpand_file_name): Likewise. In particular, newdir might
9805 point at constant storage, so make it a const pointer.
9806 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9807 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9809 (Fset_file_times, Finsert_file_contents, auto_save_error):
9810 Rename locals to avoid shadowing.
9812 * minibuf.c (choose_minibuf_frame_1): Now static.
9813 (Ftry_completion, Fall_completions): Rename or remove locals
9816 * marker.c (bytepos_to_charpos): Remove; unused.
9818 * lisp.h (verify_bytepos, count_markers): New decls,
9819 so that gcc does not warn that these functions aren't declared.
9821 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9822 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9823 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9824 (copy_text): Remove unused local var.
9826 * filelock.c (within_one_second): Now static.
9827 (lock_file_1): Rename local to avoid shadowing.
9829 * buffer.c (fix_overlays_before): Mark locals as initialized.
9830 (fix_start_end_in_overlays): Likewise. This function should be
9831 simplified by using pointers-to-pointers, but that's a different
9833 (switch_to_buffer_1): Now static.
9834 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9835 (report_overlay_modification): Rename locals to avoid shadowing.
9837 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9838 Fix pointer signedness issue.
9839 (sys_subshell): Mark local as volatile if checking for lint,
9840 to suppress a gcc -Wclobbered warning that does not seem to be right.
9841 (MAXPATHLEN): Define only if needed.
9843 * process.c (serial_open, serial_configure): Move decls from here ...
9844 * systty.h: ... to here, so that they can be checked.
9846 * fns.c (get_random, seed_random): Move extern decls from here ...
9847 * lisp.h: ... to here, so that they can be checked.
9849 * sysdep.c (reset_io): Now static.
9850 (wait_for_termination_signal): Remove; unused.
9852 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9853 (copy_keymap_item, append_key, push_text_char_description):
9855 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9856 (DENSE_TABLE_SIZE): Remove; unused.
9857 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9858 (describe_map_tree):
9859 Rename locals to avoid shadowing.
9861 * keyboard.c: Declare functions static if they are not used elsewhere.
9862 (echo_char, echo_dash, cmd_error, top_level_2):
9863 (poll_for_input, handle_async_input): Now static.
9864 (read_char, kbd_buffer_get_event, make_lispy_position):
9865 (make_lispy_event, make_lispy_movement, apply_modifiers):
9866 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9867 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9868 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9869 (read_key_sequence, read_char): Mark locals as initialized.
9870 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9872 * keyboard.h (make_ctrl_char): New decl.
9873 (mark_kboards): Move decl here ...
9874 * alloc.c (mark_kboards): ... from here.
9876 * lisp.h (force_auto_save_soon): New decl.
9878 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9879 (DEFINE_DUMMY_FUNCTION): New macro.
9880 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9882 (main): Add casts to avoid warnings
9883 if GCC considers string literals to be constants.
9885 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9887 * dbusbind.c: Pointer signedness fixes.
9888 (xd_signature, xd_append_arg, xd_initialize):
9889 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9890 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9891 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9892 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9894 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9895 if GCC considers string literals to be constants.
9896 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9898 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9900 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9901 (print_preprocess, print_object): New macro to fix last change.
9903 * print.c (print_preprocess): Don't forget font objects.
9905 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9907 * emacs.c (USAGE3): Doc fixes.
9909 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9911 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9914 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9916 * lisp.h (VWindow_system, Qfile_name_history):
9917 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9918 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9919 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9921 * w32select.c: Don't #include "keyboard.h".
9922 (run_protected): Add extern declaration for waiting_for_input.
9924 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9925 * w32console.c (detect_input_pending, read_input_pending)
9926 (encode_terminal_code):
9927 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9928 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9929 (w32_system_caret_y, Qfile_name_history):
9930 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9931 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9932 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9933 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9934 * w32proc.c (Qlocal, report_file_error):
9935 * w32term.c (Vwindow_system, updating_frame):
9936 * w32uniscribe.c (initialized, uniscribe_font_driver):
9937 Remove unneeded extern declarations.
9939 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9941 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9943 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9945 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9946 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9947 These macros can no longer be used for assignment.
9949 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9950 Assign struct members directly, instead of using BUF_BEGV etc.
9951 (record_buffer_markers, fetch_buffer_markers): New functions for
9952 recording and fetching special buffer markers.
9953 (set_buffer_internal_1, set_buffer_temp): Use them.
9955 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9957 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9959 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9960 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9962 * xdisp.c (hscroll_window_tree):
9963 (reconsider_clip_changes): Use PT instead of BUF_PT.
9965 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9967 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9968 $(EMACS_ROOT)/lib/intprops.h.
9970 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9972 Fix more problems found by GCC 4.5.2's static checks.
9974 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9975 to unsigned char * to avoid compiler diagnostic.
9976 (xg_free_frame_widgets): Make it clear that a local variable is
9977 needed only if USE_GTK_TOOLTIP.
9978 (gdk_window_get_screen): Make it clear that this macro is needed
9979 only if USE_GTK_TOOLTIP.
9980 (int_gtk_range_get_value): New function, which avoids a diagnostic
9981 from gcc -Wbad-function-cast.
9982 (xg_set_toolkit_scroll_bar_thumb): Use it.
9983 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9984 diagnostic from gcc -Wbad-function-cast.
9985 (get_utf8_string, xg_get_file_with_chooser):
9986 Rename locals to avoid shadowing.
9987 (create_dialog): Move locals to avoid shadowing.
9989 * xgselect.c (xg_select): Remove unused var.
9991 * image.c (four_corners_best): Mark locals as initialized.
9992 (gif_load): Initialize transparent_p to zero (Bug#8238).
9993 Mark another local as initialized.
9994 (my_png_error, my_error_exit): Mark with NO_RETURN.
9996 * image.c (clear_image_cache): Now static.
9997 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9998 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9999 (x_edge_detection): Remove unnecessary cast that
10000 gcc -Wbad-function-cast diagnoses.
10001 (gif_load): Fix pointer signedness.
10002 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10003 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10005 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10007 Improve quality of tests for time stamp overflow.
10008 For example, without this patch (encode-time 0 0 0 1 1
10009 1152921504606846976) returns the obviously-bogus value (-948597
10010 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10011 reports time overflow. See
10012 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10013 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10014 * editfns.c: Include limits.h and intprops.h.
10015 (TIME_T_MIN, TIME_T_MAX): New macros.
10016 (time_overflow): Move earlier, to before first use.
10017 (hi_time, lo_time): New functions, for an accurate test for
10018 out-of-range times.
10019 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10020 (Fget_internal_run_time): Don't assume time_t fits in int.
10021 (make_time): Use list2 instead of Fcons twice.
10022 (Fdecode_time): More accurate test for out-of-range times.
10023 (check_tm_member): New function.
10024 (Fencode_time): Use it, to test for out-of-range times.
10025 (lisp_time_argument): Don't rely on undefined left-shift and
10026 right-shift behavior when checking for time stamp overflow.
10028 * editfns.c (time_overflow): New function, refactoring common code.
10029 (Fformat_time_string, Fdecode_time, Fencode_time):
10030 (Fcurrent_time_string): Use it.
10032 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10033 * dired.c (make_time): Move to ...
10034 * editfns.c (make_time): ... here.
10035 * systime.h: Note the move.
10037 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10039 * fringe.c (update_window_fringes): Remove unused variables.
10041 * unexmacosx.c (copy_data_segment): Also copy __got section.
10044 2011-03-12 Eli Zaretskii <eliz@gnu.org>
10046 * termcap.c [MSDOS]: Include "msdos.h".
10047 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10048 Constify `char *' arguments and their references according to
10049 prototypes in tparam.h.
10051 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
10053 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10054 Adapt all references accordingly.
10056 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10058 2011-03-11 Tom Tromey <tromey@redhat.com>
10060 * buffer.c (syms_of_buffer): Remove obsolete comment.
10062 2011-03-11 Eli Zaretskii <eliz@gnu.org>
10064 * termhooks.h (encode_terminal_code): Declare prototype.
10066 * msdos.c (encode_terminal_code): Don't declare prototype.
10068 * term.c (encode_terminal_code): Now external again, used by
10069 w32console.c and msdos.c.
10071 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10072 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
10074 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
10076 Fix some minor problems found by GCC 4.5.2's static checks.
10078 * fringe.c (update_window_fringes): Mark locals as initialized
10080 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
10082 * alloc.c (mark_fringe_data): Move decl from here ...
10083 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10084 to check its interface.
10085 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10087 * fontset.c (free_realized_fontset): Now static.
10088 (Fset_fontset_font): Rename local to avoid shadowing.
10089 (fontset_font): Mark local as initialized.
10090 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
10092 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10094 * xselect.c (x_disown_buffer_selections): Remove; not used.
10095 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
10096 (x_own_selection, Fx_disown_selection_internal): Rename locals
10097 to avoid shadowing.
10098 (x_handle_dnd_message): Remove local to avoid shadowing.
10100 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10101 so that the caller can use some name other than gcpro1.
10102 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
10103 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10104 (Fx_backspace_delete_keys_p):
10105 Use them to avoid shadowing, and rename vars to avoid shadowing.
10106 (x_decode_color, x_set_name, x_window): Now static.
10107 (Fx_create_frame): Add braces to silence GCC warning.
10108 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10109 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10110 Remove unused locals.
10111 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10112 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10113 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10116 * xterm.h (x_mouse_leave): New decl.
10118 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10119 Remove unused functions.
10120 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10121 (x_calc_absolute_position): Now static.
10122 (XTread_socket): Don't define label "out" unless it's used.
10123 Don't declare local "event" unless it's used.
10124 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10125 unless they are used.
10126 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10127 (x_fatal_error_signal): Remove; not used.
10128 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10129 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10130 (x_error_catcher, x_connection_closed, x_error_handler):
10131 (x_error_quitter, xembed_send_message, x_iconify_frame):
10132 (my_log_handler): Rename locals to avoid shadowing.
10133 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10134 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10136 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10137 Rename or move locals to avoid shadowing.
10138 (tty_defined_color, merge_face_heights): Now static.
10139 (free_realized_faces_for_fontset): Remove; not used.
10140 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10141 does not deduce is never used uninitialized.
10142 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10143 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10145 * terminal.c (store_terminal_param): Now static.
10147 * xmenu.c (menu_highlight_callback): Now static.
10148 (set_frame_menubar): Remove unused local.
10149 (xmenu_show): Rename parameter to avoid shadowing.
10150 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10151 since they might point to immutable storage.
10152 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10153 since it's unused otherwise.
10155 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10156 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10157 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10158 avoids a gcc -Wuninitialized diagnostic.
10159 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10160 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10161 does not deduce are never used uninitialized.
10163 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10165 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10166 * window.c (window_loop, size_window):
10167 (run_window_configuration_change_hook, enlarge_window): Likewise.
10169 * window.c (display_buffer): Now static.
10170 (size_window): Mark variables that gcc -Wuninitialized
10171 does not deduce are never used uninitialized.
10172 * window.h (check_all_windows): New decl, to forestall
10173 gcc -Wmissing-prototypes diagnostic.
10174 * dispextern.h (bidi_dump_cached_states): Likewise.
10176 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10178 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10179 Include <limits.h>.
10180 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10181 and to avoid gcc -Wuninitialized warning.
10182 (load_charset_map): Mark variables that gcc -Wuninitialized
10183 does not deduce are never used uninitialized.
10184 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10186 * coding.c (coding_set_source, coding_set_destination):
10187 Use "else { /* comment */ }" rather than "else /* comment */;"
10188 for clarity, and to avoid gcc -Wempty-body warning.
10189 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10190 a block, when the outer 'i' will do.
10191 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10192 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10193 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10194 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10195 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10196 Rename locals to avoid shadowing.
10197 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10198 * coding.c (emacs_mule_char, encode_invocation_designation):
10199 Now static, since they're not used elsewhere.
10200 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10201 (decode_coding_object, encode_coding_object, detect_coding_system):
10202 (decode_coding_emacs_mule): Mark variables that gcc
10203 -Wuninitialized does not deduce are never used uninitialized.
10204 (detect_coding_iso_2022): Initialize a local variable that might
10205 be used uninitialized. Leave a FIXME because it's not clear that
10206 this initialization is needed. (Bug#8211)
10207 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10208 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10209 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10210 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10211 Remove unused macros.
10213 * category.c (hash_get_category_set): Remove unused local var.
10214 (copy_category_table): Now static, since it's not used elsewhere.
10215 * character.c (string_count_byte8): Likewise.
10217 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10218 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10220 * chartab.c (copy_sub_char_table): Now static, since it's not used
10222 (sub_char_table_ref_and_range, char_table_ref_and_range):
10223 Rename locals to avoid shadowing.
10224 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10226 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10227 (BIDI_BOB): Remove unused macro.
10229 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10230 deduce are never used uninitialized.
10231 * term.c (encode_terminal_code): Likewise.
10233 * term.c (encode_terminal_code): Now static. Remove unused local.
10235 * tparam.h: New file.
10236 * term.c, tparam.h: Include it.
10237 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10238 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10239 Move these decls to tparam.h, and make them agree with what
10240 is actually in tparam.c. The previous trick of using incompatible
10241 decls in different modules does not conform to the C standard.
10242 All callers of tparam changed to use tparam's actual API.
10243 * tparam.c (tparam1, tparam, tgoto):
10244 Use const pointers where appropriate.
10246 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10247 * cm.h (struct cm): Likewise.
10248 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10249 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10250 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10251 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10252 (turn_on_face, init_tty): Likewise.
10253 * termchar.h (struct tty_display_info): Likewise.
10255 * term.c (term_mouse_position): Rename local to avoid shadowing.
10257 * alloc.c (mark_ttys): Move decl from here ...
10258 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10260 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10262 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10264 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10266 * search.c (compile_pattern_1): Remove argument regp, unused since
10267 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10268 (compile_pattern): Don't pass it.
10270 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10272 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10273 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10275 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10277 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10279 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10280 gdk_window_get_screen, gdk_window_get_geometry,
10281 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10282 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10283 (xg_get_pixbuf_from_pixmap): New function.
10284 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10285 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10286 Call xg_get_pixbuf_from_pixmap instead of
10287 gdk_pixbuf_get_from_drawable.
10288 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10289 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10290 (xg_check_special_colors): Use GtkStyleContext and its functions
10292 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10293 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10294 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10295 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10296 Call gtk_widget_get_preferred_size.
10297 (xg_frame_resized): gdk_window_get_geometry only takes 5
10299 (xg_win_to_widget, xg_event_is_for_menubar):
10300 Call gdk_x11_window_lookup_for_display.
10301 (xg_set_widget_bg): New function.
10302 (delete_cb): New function.
10303 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10304 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10305 (xg_set_background_color): Call xg_set_widget_bg.
10306 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10307 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10308 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10309 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10311 (update_frame_tool_bar): Call gtk_widget_hide.
10312 (xg_initialize): Use GDK_KEY_g.
10314 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10316 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10318 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10319 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10320 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10322 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10324 * w32xfns.c (select_palette): Check success of RealizePalette against
10325 GDI_ERROR, not zero.
10327 See ChangeLog.11 for earlier changes.
10329 ;; Local Variables:
10333 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10335 This file is part of GNU Emacs.
10337 GNU Emacs is free software: you can redistribute it and/or modify
10338 it under the terms of the GNU General Public License as published by
10339 the Free Software Foundation, either version 3 of the License, or
10340 (at your option) any later version.
10342 GNU Emacs is distributed in the hope that it will be useful,
10343 but WITHOUT ANY WARRANTY; without even the implied warranty of
10344 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10345 GNU General Public License for more details.
10347 You should have received a copy of the GNU General Public License
10348 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.