* keymap.c: Integer overflow fixes.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * keymap.c: Integer overflow fixes.
4 (cmm_size, current_minor_maps): Use ptrdiff_t, not int, to count maps.
5 (current_minor_maps): Check for size calculation overflow.
6 * keymap.h: Change prototypes to match the above.
7
8 * keyboard.c: Integer and memory overflow fixes.
9 (read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
10 (read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
11 (follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
12 (read_char_minibuf_menu_prompt): Check for overflow in size
13 calculations. Don't update size until allocation succeeds. Redo
14 calculations to avoid overflow.
15 * keyboard.h: Change prototypes to match the above.
16
17 * image.c: Integer and memory overflow fixes.
18 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
19 now that they've been promoted to lisp.h.
20 (x_allocate_bitmap_record, x_alloc_image_color)
21 (make_image_cache, cache_image, xpm_load):
22 Don't update size until alloc is done.
23 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
24 (x_detect_edges):
25 Check for size calculation overflow.
26 (ct_colors_allocated_max): New constant.
27 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
28 overflow.
29
30 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
31
32 * gtkutil.c: Integer overflow fixes.
33 (get_utf8_string, xg_store_widget_in_map):
34 Check for size-calculation overflow.
35 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
36 do, as we prefer signed integers.
37 (id_to_widget.max_size, id_to_widget.used)
38 (xg_store_widget_in_map, xg_remove_widget_from_map)
39 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
40 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
41 Use and return ptrdiff_t, not int.
42 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
43 * gtkutil.h: Change prototypes to match the above.
44
45 * ftfont.c: Check for size overflow.
46 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
47 Check for integer overflow in size calculations.
48
49 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
50
51 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
52 This is for the members text_lines, text_cols, total_lines, total_cols,
53 where the system imposes an 'int' limit.
54
55 * frame.c: Integer overflow fixes.
56 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
57 (x_figure_window_size): Check for integer overflow.
58 (x_set_alpha): Do not assume XINT fits in int.
59
60 * eval.c: Integer and memory overflow fixes.
61 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
62 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
63
64 * emacs.c (main, sort_args): Check for size-calculation overflow.
65
66 * editfns.c: Integer and memory overflow fixes.
67 (set_time_zone_rule): Don't assume environment length fits in int.
68 (message_length): Now ptrdiff_t, not int.
69 (Fmessage_box): Don't update size until allocation succeeds.
70 Don't assume message length fits in int.
71 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
72
73 * doc.c: Integer and memory overflow fixes.
74 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
75 (get_doc_string): Check for size calculation overflow.
76 Don't update size until allocation succeeds.
77 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
78 EMACS_INT, where ptrdiff_t will do.
79 (Fsubstitute_command_keys): Check for string overflow.
80
81 Integer and memory overflow fixes for display code.
82 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
83 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
84 Check for overflow in size calculations.
85 (line_draw_cost, realloc_glyph_pool, add_row_entry):
86 Don't assume glyph table len fits in int.
87 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
88 (row_table_size): Now ptrdiff_t, not int.
89 (scrolling_window): Avoid overflow in size calculations.
90 Don't update size until allocation succeeds.
91 * fns.c (concat): Check for overflow in size calculations.
92 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
93 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
94 (NEXT_ALMOST_PRIME_LIMIT): New constant.
95
96 * composite.c: Integer overflow fixes.
97 (get_composition_id): Check for overflow in glyph length calculations.
98
99 * coding.c: Integer and memory overflow fixes.
100 (produce_chars): Redo buffer-overflow calculations to avoid
101 unnecessary integer overflow. Check for size overflow.
102 (encode_coding_object): Don't update size until xmalloc succeeds.
103
104 * character.c (Fstring): Check for size-calculation overflow.
105
106 * ccl.c: Integer and memory overflow fixes.
107 (Fccl_execute_on_string): Check for memory overflow.
108 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
109 Redo buffer-overflow calculations to avoid integer overflow.
110
111 * callproc.c (child_setup): Don't assume strlen fits in int.
112
113 * buffer.c: Memory overflow fixes.
114 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
115 Don't update size of array until after memory allocation succeeds,
116 because xmalloc/xrealloc may not return.
117
118 * bidi.c: Integer overflow fix.
119 (bidi_shelve_header_size): New constant.
120 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
121 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
122
123 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
124
125 Use ptrdiff_t for composition IDs.
126 * character.c (lisp_string_width):
127 * composite.c (composition_table_size, n_compositions)
128 (get_composition_id, composition_gstring_from_id):
129 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
130 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
131 * window.c (Frecenter):
132 Use ptrdiff_t, not int, for composition IDs.
133 * composite.c (get_composition_id): Check for integer overflow.
134 * composite.h: Adjust prototypes to match the above changes.
135
136 Use ptrdiff_t for hash table indexes.
137 * category.c (hash_get_category_set):
138 * ccl.c (ccl_driver):
139 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
140 * coding.c (coding_system_charset_list, detect_coding_system):
141 * coding.h (struct coding_system.id):
142 * composite.c (get_composition_id, gstring_lookup_cache):
143 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
144 * image.c (xpm_get_color_table_h):
145 * lisp.h (hash_lookup, hash_put):
146 * minibuf.c (Ftest_completion):
147 Use ptrdiff_t for hash table indexes, not int (which is too
148 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
149 32-bit --with-wide-int hosts).
150
151 * charset.c (Fdefine_charset_internal): Check for integer overflow.
152 Add a FIXME comment about memory leaks.
153 (syms_of_charset): Don't assume xmalloc returns.
154
155 Don't assume that stated character widths fit in int.
156 * character.c (Fchar_width, c_string_width, lisp_string_width):
157 * character.h (CHAR_WIDTH):
158 * indent.c (MULTIBYTE_BYTES_WIDTH):
159 Use sanitize_char_width to avoid undefined and/or bad behavior
160 with outlandish widths.
161 * character.h (sanitize_tab_width): Renamed from sanitize_width,
162 now that we have two such functions. All uses changed.
163 (sanitize_char_width): New inline function.
164
165 Don't assume that tab-width fits in int.
166 * character.h (sanitize_width): New inline function.
167 (SANE_TAB_WIDTH): New macro.
168 (ASCII_CHAR_WIDTH): Use it.
169 * indent.c (sane_tab_width): Remove. All uses replaced by
170 SANE_TAB_WIDTH (current_buffer).
171 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
172
173 * fileio.c: Integer overflow issues with file modes.
174 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
175
176 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
177 Remove unreachable code.
178 (read_hex, load_charset_map_from_file): Check for integer overflow.
179
180 * xterm.c: don't go over XClientMessageEvent limit
181 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
182 (x_send_scroll_bar_event): Likewise. Check that the size does not
183 exceed limits imposed by XClientMessageEvent, as well as the usual
184 ptrdiff_t and size_t limits.
185
186 * keyboard.c: Overflow, signedness and related fixes.
187 (make_lispy_movement): Use same integer type in forward decl
188 that is used in the definition.
189 (read_key_sequence, keyremap_step):
190 Change bufsize argument back to int, undoing my 2011-03-30 change.
191 We prefer signed types, and int is wide enough here.
192 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
193 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
194 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
195 length, not size_t. Use ptrdiff_t for index, not int.
196 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
197 possibility of integer overflow.
198
199 Overflow, signedness and related fixes for images.
200
201 * dispextern.h (struct it.stack[0].u.image.image_id)
202 (struct_it.image_id, struct image.id, struct image_cache.size)
203 (struct image_cache.used, struct image_cache.ref_count):
204 * gtkutil.c (update_frame_tool_bar):
205 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
206 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
207 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
208 * nsmenu.m (update_frame_tool_bar):
209 * xdisp.c (calc_pixel_width_or_height):
210 * xfns.c (image_cache_refcount):
211 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
212 on typical 64-bit hosts.
213
214 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
215 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
216 Omit unnecessary casts to int.
217 (parse_image_spec): Check that integers fall into 'int' range
218 when the callers expect that.
219 (image_ascent): Redo ascent calculation to avoid int overflow.
220 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
221 (lookup_image): Remove unnecessary tests.
222 (xbm_image_p): Locals are now of int, not EMACS_INT,
223 since parse_image_check makes sure they fit into int.
224 (png_load, gif_load, svg_load_image):
225 Prefer int to unsigned where either will do.
226 (tiff_handler): New function, combining the cores of the
227 old tiff_error_handler and tiff_warning_handler. This
228 function is rewritten to use vsnprintf and thereby avoid
229 stack buffer overflows. It uses only the features of vsnprintf
230 that are common to both POSIX and native Microsoft.
231 (tiff_error_handler, tiff_warning_handler): Use it.
232 (tiff_load, gif_load, imagemagick_load_image):
233 Don't assume :index value fits in 'int'.
234 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
235 (imagemagick_load_image): Check that crop parameters fit into
236 the integer types that MagickCropImage accepts. Don't assume
237 Vimagemagick_render_type has a nonnegative value. Don't assume
238 size_t fits in 'long'.
239 (gs_load): Use printmax_t to print the widest integers possible.
240 Check for integer overflow when computing image height and width.
241
242 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
243
244 Integer signedness and overflow and related fixes. (Bug#9079)
245
246 * bidi.c: Integer size and overflow fixes.
247 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
248 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
249 (bidi_cache_find_level_change, bidi_cache_ensure_space)
250 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
251 (bidi_find_other_level_edge):
252 Use ptrdiff_t instead of EMACS_INT where either will do.
253 This works better on 32-bit hosts configured --with-wide-int.
254 (bidi_cache_ensure_space): Check for size-calculation overflow.
255 Use % rather than repeated addition, for better worst-case speed.
256 Don't set bidi_cache_size until after xrealloc returns, because it
257 might not return.
258 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
259 (bidi_cache_ensure_space): Also check that the bidi cache size
260 does not exceed that of the largest Lisp string or buffer. See Eli
261 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
262
263 * alloc.c (__malloc_size_t): Remove.
264 All uses replaced by size_t. See Andreas Schwab's note
265 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
266
267 * image.c: Improve checking for integer overflow.
268 (check_image_size): Assume that f is nonnull, since
269 it is always nonnull in practice. This is one less thing to
270 worry about when checking for integer overflow later.
271 (x_check_image_size): New function, which checks for integer
272 overflow issues inside X.
273 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
274 This removes the need for a memory_full check.
275 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
276 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
277 (xbm_read_bitmap_data): Change locals back to 'int', since
278 their values must fit in 'int'.
279 (xpm_load_image, png_load, tiff_load):
280 Invoke x_create_x_image_and_pixmap earlier,
281 to avoid much needless work if the image is too large.
282 (tiff_load): Treat overly large images as if
283 x_create_x_image_and_pixmap failed, not as malloc failures.
284 (gs_load): Use x_check_image_size.
285
286 * gtkutil.c: Omit integer casts.
287 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
288 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
289
290 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
291
292 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
293 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
294 would wrongly return t on a 64-bit host.
295
296 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
297 The plain *_OVERFLOW macros run afoul of GCC bug 49705
298 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
299 and therefore cause GCC to emit a bogus diagnostic in some cases.
300
301 * image.c: Integer signedness and overflow and related fixes.
302 This is not an exhaustive set of fixes, but it's time to
303 record what I've got.
304 (lookup_pixel_color, check_image_size): Remove redundant decls.
305 (check_image_size): Don't assume that arbitrary EMACS_INT values
306 fit in 'int', or that arbitrary 'double' values fit in 'int'.
307 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
308 (tiff_load, imagemagick_load_image):
309 Check for overflow in size calculations.
310 (x_create_x_image_and_pixmap): Remove unnecessary test for
311 xmalloc returning NULL; that can't happen.
312 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
313 (xpm_color_bucket): Use better integer hashing function.
314 (xpm_cache_color): Don't possibly over-allocate memory.
315 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
316 (gif_memory_source):
317 Use ptrdiff_t, not int or size_t, to record sizes.
318 (png_load): Don't assume values greater than 2**31 fit in 'int'.
319 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
320 either works, as we prefer signed integers.
321 (tiff_read_from_memory, tiff_write_from_memory):
322 Return tsize_t, not size_t, since that's what the TIFF API wants.
323 (tiff_read_from_memory): Don't fail simply because the read would
324 go past EOF; instead, return a short read.
325 (tiff_load): Omit no-longer-needed casts.
326 (Fimagemagick_types): Don't assume size fits into 'int'.
327
328 Improve hashing quality when configured --with-wide-int.
329 * fns.c (hash_string): New function, taken from sxhash_string.
330 Do not discard information about ASCII character case; this
331 discarding is no longer needed.
332 (sxhash-string): Use it. Change sig to match it. Caller changed.
333 * lisp.h: Declare it.
334 * lread.c (hash_string): Remove, since we now use fns.c's version.
335 The fns.c version returns a wider integer if --with-wide-int is
336 specified, so this should help the quality of the hashing a bit.
337
338 * emacs.c: Integer overflow minor fix.
339 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
340 Define only if GNU_LINUX.
341 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
342
343 * dispnew.c: Integer signedness and overflow fixes.
344 Remove unnecessary forward decls, that were a maintenance hassle.
345 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
346 All uses changed.
347 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
348 (scrolling_window): Use ptrdiff_t, not int, for byte count.
349 (prepare_desired_row, line_draw_cost):
350 Use int, not unsigned, where either works.
351 (save_current_matrix, restore_current_matrix):
352 Use ptrdiff_t, not size_t, where either works.
353 (init_display): Check for overflow more accurately, and without
354 relying on undefined behavior.
355
356 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
357 Remove, replacing with the new symbols in lisp.h. All uses changed.
358 * fileio.c (make_temp_name):
359 * filelock.c (lock_file_1, lock_file):
360 * xdisp.c (message_dolog):
361 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
362 Use pMd etc. instead.
363 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
364 replacing the pWIDE etc. symbols removed from editfns.c.
365
366 * keyboard.h (num_input_events): Now uintmax_t.
367 This is (very slightly) less likely to mess up due to wraparound.
368 All uses changed.
369
370 * buffer.c: Integer signedness fixes.
371 (alloc_buffer_text, enlarge_buffer_text):
372 Use ptrdiff_t rather than size_t when either will do, as we prefer
373 signed integers.
374
375 * alloc.c: Integer signedness and overflow fixes.
376 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
377 (__malloc_size_t): Default to size_t, not to int.
378 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
379 (Fgarbage_collect, mark_object_loop_halt, mark_object):
380 Prefer ptrdiff_t to size_t when either would do, as we prefer
381 signed integers.
382 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
383 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
384 Now const. Initialize with values that are in range even if char
385 is signed.
386 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
387 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
388 These functions do the right thing with sizes > 2**32.
389 (check_depth): Now ptrdiff_t, not int.
390 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
391 Adjust to new way of storing sizes. Check for size overflow bugs
392 in rest of code.
393 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
394 slightly wrong anyway, as it missed one instance of
395 XMALLOC_OVERRUN_CHECK_OVERHEAD.
396 (refill_memory_reserve): Omit needless cast to size_t.
397 (mark_object_loop_halt): Mark as externally visible.
398
399 * xselect.c: Integer signedness and overflow fixes.
400 (Fx_register_dnd_atom, x_handle_dnd_message):
401 Use ptrdiff_t, not size_t, since we prefer signed.
402 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
403 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
404 x_dnd_atoms_size and x_dnd_atoms_length.
405
406 * doprnt.c: Prefer signed to unsigned when either works.
407 * eval.c (verror):
408 * doprnt.c (doprnt):
409 * lisp.h (doprnt):
410 * xdisp.c (vmessage):
411 Use ptrdiff_t, not size_t, when using or implementing doprnt,
412 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
413 prefer signed arithmetic to avoid comparison confusion.
414 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
415 but is a bit tricky.
416
417 Assume freestanding C89 headers, string.h, stdlib.h.
418 * data.c, doprnt.c, floatfns.c, print.c:
419 Include float.h unconditionally.
420 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
421 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
422 * regex.c: Likewise for stddef.h, string.h.
423 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
424 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
425 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
426 (STDC_HEADERS): Remove obsolete defines.
427 * sysdep.c: Include limits.h unconditionally.
428
429 Assume support for memcmp, memcpy, memmove, memset.
430 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
431 * regex.c (memcmp, memcpy):
432 Remove; we assume C89 now.
433
434 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
435 (__malloc_safe_bcopy): Remove; no longer needed.
436
437 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
438 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
439 well either way, and we prefer signed to unsigned.
440
441 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
442
443 Port to OpenBSD.
444 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
445 and the surrounding thread.
446 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
447 rather than fgets, and retry after EINTR. Otherwise, 'emacs
448 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
449 timer goes off.
450 * s/openbsd.h (BROKEN_SIGIO): Define.
451 * unexelf.c (unexec) [__OpenBSD__]:
452 Don't update the .mdebug section of the Alpha COFF symbol table.
453
454 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
455
456 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
457 (bug#8460).
458
459 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
460
461 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
462 This fixes some race conditions on the permissions of any newly
463 created file.
464
465 * alloc.c (valid_pointer_p): Use pipe, not open.
466 This fixes some permissions issues when debugging.
467
468 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
469 If fchown fails to set both uid and gid, try to set just gid,
470 as that is sometimes allowed. Adjust the file's mode to eliminate
471 setuid or setgid bits that are inappropriate if fchown fails.
472
473 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
474
475 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
476 to compare Lisp_Objects.
477 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
478 global_gnutls_log_level, don't mistake it for a Lisp_Object.
479 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
480
481 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
482
483 * lread.c (read_integer): Unread even EOF character.
484 (read1): Likewise. Properly record start position of symbol.
485
486 * lread.c (read1): Read `#:' as empty uninterned symbol if no
487 symbol character follows.
488
489 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
490
491 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
492 This works around a problem with the previous change to Fcopy_file.
493 Recent glibc declares fchown with __attribute__((warn_unused_result)),
494 and without this change, GCC might complain about discarding
495 fchown's return value.
496
497 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
498
499 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
500
501 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
502
503 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
504
505 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
506
507 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
508 it's used from the C level.
509
510 * process.c: Use the same condition for POLL_FOR_INPUT in both
511 keyboard.c and process.c (bug#1858).
512
513 2011-07-09 Lawrence Mitchell <wence@gmx.li>
514
515 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
516 (Fgnutls_boot): Use it.
517
518 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
519
520 * doc.c (Fsubstitute_command_keys): Revert last change.
521
522 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
523
524 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
525 quotes the next character, and doesn't affect other longer
526 sequences (bug#8935).
527
528 * lread.c (syms_of_lread): Clarify that is isn't only
529 `eval-buffer' and `eval-defun' that's affected by
530 `lexical-binding' (bug#8460).
531
532 2011-07-15 Eli Zaretskii <eliz@gnu.org>
533
534 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
535 bidi redisplay when a line includes both an image and is
536 truncated.
537
538 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
539
540 Fix minor problems found by static checking.
541 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
542 (elsz): Now a signed constant, not a size_t var. We prefer signed
543 types to unsigned, to avoid integer comparison confusion. Without
544 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
545 "cannot optimize loop, the loop counter may overflow", a symptom
546 of the confusion.
547 * indent.c (Fvertical_motion): Mark locals as initialized.
548 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
549
550 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
551
552 * search.c (Fre_search_backward): Mention `case-fold-search' in
553 all the re_search_* functions (bug#8138).
554
555 * keyboard.c (Fopen_dribble_file): Document when the file is
556 closed (bug#8056).
557
558 2011-07-14 Eli Zaretskii <eliz@gnu.org>
559
560 * bidi.c (bidi_dump_cached_states): Fix format of displaying
561 bidi_cache_idx.
562
563 Support bidi reordering of display and overlay strings.
564 * xdisp.c (compute_display_string_pos)
565 (compute_display_string_end): Accept additional argument STRING.
566 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
567 (reseat_to_string): Initialize bidi_it->string.s and
568 bidi_it->string.schars.
569 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
570 NULL (avoids a crash in bidi_paragraph_init). Initialize
571 itb.string.lstring.
572 (init_iterator): Call bidi_init_it only of a valid
573 buffer position was specified. Initialize paragraph_embedding to
574 L2R.
575 (reseat_to_string): Initialize the bidi iterator.
576 (display_string): If we need to ignore text properties of
577 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
578 original value of -1 will not work with bidi.)
579 (compute_display_string_pos): First arg is now struct
580 `text_pos *'; all callers changed. Support display properties on
581 Lisp strings.
582 (compute_display_string_end): Support display properties on Lisp
583 strings.
584 (init_iterator, reseat_1, reseat_to_string): Initialize the
585 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
586 when iterating on a string not from display properties).
587 (compute_display_string_pos, compute_display_string_end): Fix
588 calculation of the object to scan. Fixes an error when using
589 arrow keys.
590 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
591 base_level_stop; instead, set base_level_stop to BEGV. Fixes
592 crashes in vertical-motion.
593 (next_element_from_buffer): Improve commentary for when
594 the iterator is before prev_stop.
595 (init_iterator): Initialize bidi_p from the default value of
596 bidi-display-reordering, not from buffer-local value. Use the
597 buffer-local value only if initializing for buffer iteration.
598 (handle_invisible_prop): Support invisible properties on strings
599 that are being bidi-reordered.
600 (set_iterator_to_next): Support bidi reordering of C strings and
601 Lisp strings.
602 (next_element_from_string): Support bidi reordering of Lisp
603 strings.
604 (handle_stop_backwards): Support Lisp strings as well.
605 (display_string): Support display of R2L glyph rows. Use
606 IT_STRING_CHARPOS when displaying from a Lisp string.
607 (init_iterator): Don't initialize it->bidi_p for strings
608 here.
609 (reseat_to_string): Initialize it->bidi_p for strings here.
610 (next_element_from_string, next_element_from_c_string)
611 (next_element_from_buffer): Add xassert's for correspondence
612 between IT's object being iterated and it->bidi_it.string
613 structure.
614 (face_before_or_after_it_pos): Support bidi iteration.
615 (next_element_from_c_string): Handle the case of the first string
616 character that is not the first one in the visual order.
617 (get_visually_first_element): New function, refactored from common
618 parts of next_element_from_buffer, next_element_from_string, and
619 next_element_from_c_string.
620 (tool_bar_lines_needed, redisplay_tool_bar)
621 (display_menu_bar): Force left-to-right direction. Add a FIXME
622 comment for making that be controlled by a user option.
623 (push_it, pop_it): Save and restore the state of the
624 bidi iterator. Save and restore the bidi_p flag.
625 (pop_it): Iterate out of display property for string iteration as
626 well.
627 (iterate_out_of_display_property): Support iteration over strings.
628 (handle_single_display_spec): Set up it->bidi_it for iteration
629 over a display string, and call bidi_init_it.
630 (handle_single_display_spec, next_overlay_string)
631 (get_overlay_strings_1, push_display_prop): Set up the bidi
632 iterator for displaying display or overlay strings.
633 (forward_to_next_line_start): Don't use the shortcut if
634 bidi-iterating.
635 (back_to_previous_visible_line_start): If handle_display_prop
636 pushed the iterator stack, restore the internal state of the bidi
637 iterator by calling bidi_pop_it same number of times.
638 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
639 and we are bidi-iterating, don't decrement the iterator position;
640 instead, set the first_elt flag in the bidi iterator, to produce
641 the same effect.
642 (reseat_1): Remove redundant setting of string_from_display_prop_p.
643 (push_display_prop): xassert that we are iterating a buffer.
644 (push_it, pop_it): Save and restore paragraph_embedding member.
645 (handle_single_display_spec, next_overlay_string)
646 (get_overlay_strings_1, reseat_1, reseat_to_string)
647 (push_display_prop): Set up the `unibyte' member of bidi_it.string
648 correctly. Don't assume unibyte strings are not bidi-reordered.
649 (compute_display_string_pos)
650 (compute_display_string_end): Fix handling the case of C string.
651 (push_it, pop_it): Save and restore from_disp_prop_p.
652 (handle_single_display_spec, push_display_prop): Set the
653 from_disp_prop_p flag.
654 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
655 (pop_it): Call iterate_out_of_display_property only if we are
656 popping after iteration over a string that came from a display
657 property. Fix a typo in popping stretch info. Add an assertion
658 for verifying that the iterator position is in sync with the bidi
659 iterator.
660 (handle_single_display_spec, get_overlay_strings_1)
661 (push_display_prop): Fix initialization of paragraph direction for
662 string when that of the parent object is not yet determined.
663 (reseat_1): Call bidi_init_it to resync the bidi
664 iterator with IT's position. (Bug#7616)
665 (find_row_edges): If ROW->start.pos gives position
666 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
667 (handle_stop, back_to_previous_visible_line_start, reseat_1):
668 Reset the from_disp_prop_p flag.
669 (SAVE_IT, RESTORE_IT): New macros.
670 (pos_visible_p, face_before_or_after_it_pos)
671 (back_to_previous_visible_line_start)
672 (move_it_in_display_line_to, move_it_in_display_line)
673 (move_it_to, move_it_vertically_backward, move_it_by_lines)
674 (try_scrolling, redisplay_window, display_line): Use them when
675 saving a temporary copy of the iterator and restoring it back.
676 (back_to_previous_visible_line_start, reseat_1)
677 (init_iterator): Empty the bidi cache "stack".
678 (move_it_in_display_line_to): If iterator ended up at
679 EOL, but we never saw any buffer positions smaller than
680 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
681 motion in bidi-reordered lines.
682 (move_it_in_display_line_to): Record prev_method and prev_pos
683 immediately before the call to set_iterator_to_next. Fixes cursor
684 motion in bidi-reordered lines with stretch glyphs and strings
685 displayed in margins. (Bug#8133) (Bug#8867)
686 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
687 TO_CHARPOS.
688 (pos_visible_p): Support positions in bidi-reordered lines. Save
689 and restore bidi cache.
690
691 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
692 (bidi_paragraph_info): Delete unused struct.
693 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
694 (bidi_cache_start): New variable.
695 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
696 to zero.
697 (bidi_cache_fetch_state, bidi_cache_search)
698 (bidi_cache_find_level_change, bidi_cache_iterator_state)
699 (bidi_cache_find, bidi_peek_at_next_level)
700 (bidi_level_of_next_char, bidi_find_other_level_edge)
701 (bidi_move_to_visually_next): Compare cache index with
702 bidi_cache_start rather than with zero.
703 (bidi_fetch_char): Accept new argument STRING; all callers
704 changed. Support iteration over a string. Support strings with
705 display properties. Support unibyte strings. Fix the type of
706 `len' according to what STRING_CHAR_AND_LENGTH expects.
707 (bidi_paragraph_init, bidi_resolve_explicit_1)
708 (bidi_resolve_explicit, bidi_resolve_weak)
709 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
710 iteration over a string.
711 (bidi_set_sor_type, bidi_resolve_explicit_1)
712 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
713 can now be zero (for strings); special values 0 and -1 were
714 changed to -1 and -2, respectively.
715 (bidi_char_at_pos): New function.
716 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
717 Call it instead of FETCH_MULTIBYTE_CHAR.
718 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
719 initialized to valid values.
720 (bidi_init_it): Don't initialize charpos and bytepos with invalid
721 values.
722 (bidi_level_of_next_char): Allow the sentinel "position" to pass
723 the test for valid cached positions. Fix the logic for looking up
724 the sentinel state in the cache. GCPRO the Lisp string we are
725 iterating.
726 (bidi_push_it, bidi_pop_it): New functions.
727 (bidi_initialize): Initialize the bidi cache start stack pointer.
728 (bidi_cache_ensure_space): New function, refactored from part of
729 bidi_cache_iterator_state. Don't assume the required size is just
730 one BIDI_CACHE_CHUNK away.
731 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
732 (bidi_count_bytes, bidi_char_at_pos): New functions.
733 (bidi_cache_search): Don't assume bidi_cache_last_idx is
734 always valid if bidi_cache_idx is valid.
735 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
736 is valid if it's going to be used.
737 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
738 (bidi_cache_fetch_state, bidi_cache_search)
739 (bidi_cache_find_level_change, bidi_cache_ensure_space)
740 (bidi_cache_iterator_state, bidi_cache_find)
741 (bidi_find_other_level_edge, bidi_cache_start_stack): All
742 variables related to cache indices are now EMACS_INT.
743
744 * dispextern.h (struct bidi_string_data): New structure.
745 (struct bidi_it): New member `string'. Make flag members be 1-bit
746 fields, and put them last in the struct.
747 (compute_display_string_pos, compute_display_string_end): Update
748 prototypes.
749 (bidi_push_it, bidi_pop_it): Add prototypes.
750 (struct iterator_stack_entry): New members bidi_p,
751 paragraph_embedding, and from_disp_prop_p.
752 (struct it): Member bidi_p is now a bit field 1 bit wide.
753 (bidi_shelve_cache, bidi_unshelve_cache): Declare
754 prototypes.
755
756 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
757 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
758 and vector-like objects.
759
760 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
761 cache around display iteration.
762
763 * window.c (Fwindow_end, window_scroll_pixel_based)
764 (displayed_window_lines, Frecenter): Save and restore the bidi
765 cache around display iteration.
766
767 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
768
769 * editfns.c (Fdelete_region): Clarify the use of the named
770 parameters (bug#6788).
771
772 2011-07-14 Martin Rudalics <rudalics@gmx.at>
773
774 * indent.c (Fvertical_motion): Set and restore w->pointm when
775 saving and restoring the window's buffer (Bug#9006).
776
777 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
778
779 * editfns.c (Fstring_to_char): Clarify just what is returned
780 (bug#6576). Text by Eli Zaretskii.
781
782 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
783
784 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
785
786 2011-07-13 Eli Zaretskii <eliz@gnu.org>
787
788 * buffer.c (mmap_find): Fix a typo.
789
790 2011-07-13 Johan Bockgård <bojohan@gnu.org>
791
792 Fix execution of x selection hooks.
793 * xselect.c (Qx_lost_selection_functions)
794 (Qx_sent_selection_functions): New vars.
795 (syms_of_xselect): DEFSYM them.
796 (x_handle_selection_request): Pass Qx_sent_selection_functions
797 rather than Vx_sent_selection_functions to Frun_hook_with_args.
798 (x_handle_selection_clear,x_clear_frame_selections):
799 Pass Qx_lost_selection_functions rather than
800 Vx_lost_selection_functions to Frun_hook_with_args.
801
802 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
803
804 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
805 The old code sometimes used this field without initializing it.
806
807 * alloc.c (gc_sweep): Don't read past end of array.
808 In theory, the old code could also have corrupted Emacs internals,
809 though it'd be very unlikely.
810
811 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
812
813 * character.c (Fcharacterp): Don't advertise optional ignored
814 argument. (Bug#4026)
815
816 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
817
818 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
819 key" (bug#4257).
820
821 * window.c (Fset_window_start): Doc fix (bug#4199).
822 (Fset_window_hscroll): Ditto.
823
824 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
825
826 Fix minor new problems caught by GCC 4.6.1.
827 * term.c (init_tty): Remove unused local.
828 * xsettings.c (store_monospaced_changed): Define this function only
829 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
830 not used otherwise.
831
832 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
833
834 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
835
836 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
837
838 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
839 are the mini-buffer and the echo area (bug#3320).
840
841 * term.c (init_tty): Remove support for supdup, c10 and perq
842 terminals, which are no longer supported (bug#1482).
843
844 2011-07-10 Johan Bockgård <bojohan@gnu.org>
845
846 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
847
848 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
849
850 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
851 for non-popups (Bug#3642).
852
853 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
854
855 * alloc.c (reset_malloc_hooks): Protoize.
856 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
857 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
858 * cm.c (losecursor): Likewise.
859 * data.c (fmod): Likewise.
860 * dispnew.c (swap_glyphs_in_rows): Likewise.
861 * emacs.c (memory_warning_signal): Likewise.
862 * floatfns.c (float_error): Likewise.
863 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
864 (otf_open, font_otf_capability, generate_otf_features)
865 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
866 Likewise.
867 * image.c (pbm_read_file): Likewise.
868 * indent.c (string_display_width): Likewise.
869 * intervals.c (check_for_interval, search_for_interval)
870 (inc_interval_count, count_intervals, root_interval)
871 (adjust_intervals_for_insertion, make_new_interval): Likewise.
872 * lread.c (defalias): Likewise.
873 * ralloc.c (r_alloc_check): Likewise.
874 * regex.c (set_image_of_range_1, set_image_of_range)
875 (regex_grow_registers): Likewise.
876 * sysdep.c (strerror): Likewise.
877 * termcap.c (valid_filename_p, tprint, main): Likewise.
878 * tparam.c (main): Likewise.
879 * unexhp9k800.c (run_time_remap, save_data_space)
880 (update_file_ptrs, read_header, write_header, calculate_checksum)
881 (copy_file, copy_rest, display_header): Likewise.
882 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
883 Likewise.
884 * xdisp.c (check_it): Likewise.
885 * xfaces.c (register_color, unregister_color, unregister_colors):
886 Likewise.
887 * xfns.c (print_fontset_result): Likewise.
888 * xrdb.c (member, fatal, main): Likewise.
889
890 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
891
892 Fix minor problems found by static checking (Bug#9031).
893 * chartab.c (char_table_set_range, map_sub_char_table):
894 Remove unused locals.
895 (uniprop_table): Now static.
896 * composite.c (_work_char): Remove unused static var.
897
898 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
899
900 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
901
902 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
903
904 * gtkutil.c (qttip_cb): Remove code without function.
905
906 2011-07-09 Eli Zaretskii <eliz@gnu.org>
907
908 * w32.c (pthread_sigmask): New stub.
909
910 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
911
912 Use pthread_sigmask, not sigprocmask (Bug#9010).
913 sigprocmask is portable only for single-threaded applications, and
914 Emacs can be multi-threaded when it uses GTK.
915 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
916 (LIBES): Use it.
917 * callproc.c (Fcall_process):
918 * process.c (create_process):
919 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
920 Use pthread_sigmask, not sigprocmask.
921
922 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
923
924 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
925 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
926 wrong (Bug#8591).
927
928 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
929
930 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
931 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
932 (xg_hide_tooltip): Fix comment.
933
934 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
935 in registerServicesMenuSendTypes.
936 (validRequestorForSendType): Don't check ns_return_types.
937
938 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
939 ns_return_type.
940
941 2011-07-08 Jason Rumney <jasonr@gnu.org>
942
943 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
944 frame struct members of non-existent frames (Bug#6284).
945
946 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
947
948 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
949 variable firstTime not needed on OSX >= 10.6.
950 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
951 >= 10.5. Use setKnobProportion, setDoubleValue.
952
953 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
954 (MAC_OS_X_VERSION_10_5): Define if not defined.
955 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
956 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
957 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
958
959 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
960 cString and lossyCString on OSX >= 10.4
961
962 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
963 sizeToFit on OSX >= 10.2.
964
965 * nsimage.m (allocInitFromFile): Don't use deprecated method
966 bestRepresentationForDevice on OSX >= 10.6.
967
968 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
969 to avoid warning.
970
971 * emacs.c: Declare unexec_init_emacs_zone.
972
973 * nsgui.h: Fix compiler warning about gnulib redefining verify.
974
975 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
976
977 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
978 on svcsMenu (Bug#8842).
979
980 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
981 ns_return_types.
982 (Fns_list_services): Just return Qnil on 10.6, code not working there.
983
984 * nsterm.m (QUTF8_STRING): Declare.
985 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
986 (validRequestorForSendType): Return type is (id).
987 Change indexOfObjectIdenticalTo to indexOfObject.
988 Check if we have local selection before returning self (Bug#8842).
989 (writeSelectionToPasteboard): Put local selection into paste board
990 if we have a local selection (Bug#8842).
991 (syms_of_nsterm): DEFSYM QUTF8_STRING.
992
993 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
994 (ns_get_local_selection): Declare.
995
996 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
997
998 * keymap.c (describe_map_tree): Don't insert a double newline at
999 the end of the buffer (bug#1169) and return whether we inserted
1000 something.
1001
1002 * callint.c (Fcall_interactively): Change "reading args" to
1003 "providing args" to try to clarify what it does (bug#1010).
1004
1005 2011-07-07 Kenichi Handa <handa@m17n.org>
1006
1007 * composite.c (composition_compute_stop_pos): Ignore a static
1008 composition starting before CHARPOS (Bug#8915).
1009
1010 * xdisp.c (handle_composition_prop): Likewise.
1011
1012 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1013
1014 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1015 (Bug#9015)
1016
1017 2011-07-07 Kenichi Handa <handa@m17n.org>
1018
1019 * character.h (unicode_category_t): New enum type.
1020
1021 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1022 (Qchar_code_property_table): New variable.
1023 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1024 (UNIPROP_COMPRESSED_FORM_P): New macros.
1025 (char_table_ascii): Uncompress the compressed values.
1026 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1027 Uncompress the compressed values.
1028 (sub_char_table_ref_and_range): Likewise.
1029 (char_table_ref_and_range): Uncompress the compressed values.
1030 (sub_char_table_set): New arg is_uniprop. Callers changed.
1031 Uncompress the compressed values.
1032 (sub_char_table_set_range): Args changed. Callers changed.
1033 (char_table_set_range): Adjuted for the above change.
1034 (map_sub_char_table): Delete args default_val and parent. Add arg
1035 top. Give decoded values to a Lisp function.
1036 (map_char_table): Adjusted for the above change. Give decoded
1037 values to a Lisp function. Gcpro more variables.
1038 (uniprop_table_uncompress)
1039 (uniprop_decode_value_run_length): New functions.
1040 (uniprop_decoder, uniprop_decoder_count): New variables.
1041 (uniprop_get_decoder, uniprop_encode_value_character)
1042 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1043 New functions.
1044 (uniprop_encoder, uniprop_encoder_count): New variables.
1045 (uniprop_get_encoder, uniprop_table)
1046 (Funicode_property_table_internal, Fget_unicode_property_internal)
1047 (Fput_unicode_property_internal): New functions.
1048 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1049 Sunicode_property_table_internal, Sget_unicode_property_internal,
1050 and Sput_unicode_property_internal. Defvar_lisp
1051 char-code-property-alist.
1052
1053 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1054 Vunicode_category_table.
1055
1056 * font.c (font_range): Adjusted for the change of
1057 Vunicode_category_table.
1058
1059 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1060
1061 * m/iris4d.h: Remove file, move contents ...
1062 * s/irix6-5.h: ... here.
1063
1064 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1065
1066 Remove unportable assumption about struct layout (Bug#8884).
1067 * alloc.c (mark_buffer):
1068 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1069 (clone_per_buffer_values): Don't assume that
1070 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1071 This isn't true in general, and it's particularly not true
1072 if Emacs is configured with --with-wide-int.
1073 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1074 New macros, used in the buffer.c change.
1075
1076 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1077
1078 * xsettings.c: Use both GConf and GSettings if both are available.
1079 (store_config_changed_event): Add comment.
1080 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1081 (store_tool_bar_style_changed): New functions.
1082 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1083 (struct xsettings): Move font inside HAVE_XFT.
1084 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1085 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1086 Move inside HAVE_XFT.
1087 (something_changed_gsettingsCB): Renamed from something_changedCB.
1088 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1089 also.
1090 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1091 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1092 (something_changed_gconfCB): Renamed from something_changedCB.
1093 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1094 (parse_settings): Move check for font inside HAVE_XFT.
1095 (read_settings, apply_xft_settings): Add comment.
1096 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1097 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1098 call store_font_name_changed.
1099 (xft_settings_event): Add comment.
1100 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1101 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1102 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1103 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1104 (xsettings_initialize): Call init_gsettings last.
1105 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1106 comment.
1107
1108 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 Random fixes. E.g., (random) never returned negative values.
1111 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1112 subseconds part to the entropy, as that's a bit more random.
1113 Prefer signed to unsigned, since the signedness doesn't matter and
1114 in general we prefer signed. When given a limit, use a
1115 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1116 latter isn't right if USE_2_TAGS_FOR_INTS.
1117 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1118 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1119
1120 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1121
1122 * textprop.c (text_property_stickiness):
1123 Obey Vtext_property_default_nonsticky.
1124 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1125 * w32fns.c (syms_of_w32fns):
1126 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1127
1128 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1129
1130 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1131 This is more efficient than Ffile_directory_p and avoids a minor race.
1132
1133 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1134
1135 * buffer.c (Foverlay_put): Say what the return value is
1136 (bug#7835).
1137
1138 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1139 is a directory before asking whether to use the file name
1140 (bug#7564).
1141 (barf_or_query_if_file_exists): Make the "File is a directory"
1142 error be more correct.
1143
1144 * fns.c (Frequire): Remove the mention of the .gz files, since
1145 that's installation-specific, but keep the mention of
1146 `get-load-suffixes'.
1147
1148 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1149
1150 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1151 Report string overflow if the output is too long.
1152
1153 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1154
1155 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1156 (syms_of_gnutls): Remove duplicate DEFSYM for
1157 Qgnutls_bootprop_verify_hostname_error, an error for
1158 Qgnutls_bootprop_verify_error (which is no longer used).
1159
1160 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1161 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1162 Also (re)move comments that are misplaced or no longer relevant.
1163
1164 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1165
1166 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1167
1168 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1169
1170 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1171 and background color parameters if they have been changed.
1172
1173 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1174
1175 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1176
1177 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1178
1179 * xsettings.c (SYSTEM_FONT): Define only when used.
1180 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1181
1182 * keymap.c (access_keymap_1): Now static.
1183
1184 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1185
1186 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1187 leave any prefix arg for the up event (Bug#1586).
1188
1189 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1190
1191 * lread.c (syms_of_lread): Mention single symbols defined by
1192 `defvar' or `defconst' (bug#7154).
1193
1194 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1195 (Frequire): Mention get-load-suffixes.
1196
1197 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1198
1199 * window.h (window): Remove clone_number slot.
1200 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1201 Remove.
1202 (make_parent_window, make_window, saved_window)
1203 (Fset_window_configuration, save_window_save): Don't deal with
1204 clone numbers.
1205 * buffer.c (Qclone_number): Remove declaration.
1206 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1207
1208 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1209
1210 Add multiple inheritance to keymaps.
1211 * keymap.c (Fmake_composed_keymap): New function.
1212 (Fset_keymap_parent): Simplify.
1213 (fix_submap_inheritance): Remove.
1214 (access_keymap_1): New function extracted from access_keymap to handle
1215 embedded parents and handle lists of maps.
1216 (access_keymap): Use it.
1217 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1218 (Fcopy_keymap): Handle embedded parents.
1219 (Fcommand_remapping, define_as_prefix): Simplify.
1220 (Fkey_binding): Simplify.
1221 (syms_of_keymap): Move minibuffer-local-completion-map,
1222 minibuffer-local-filename-completion-map,
1223 minibuffer-local-must-match-map, and
1224 minibuffer-local-filename-must-match-map to Elisp.
1225 (syms_of_keymap): Defsubr make-composed-keymap.
1226 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1227 (parse_menu_item): Trivial simplification.
1228
1229 2011-07-01 Glenn Morris <rgm@gnu.org>
1230
1231 * Makefile.in (SETTINGS_LIBS): Fix typo.
1232
1233 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1234
1235 * coding.c (Fencode_coding_string): Record the last coding system
1236 used, as the function doc string says (bug#8738).
1237
1238 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1239
1240 * xsettings.c (store_monospaced_changed): Take new font as arg and
1241 check for change against current_mono_font.
1242 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1243 (emacs_settings_constructor, emacs_settings_get_property)
1244 (emacs_settings_set_property, emacs_settings_class_init)
1245 (emacs_settings_init, gsettings_obj): Remove.
1246 (something_changedCB): New function for HAVE_GSETTINGS.
1247 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1248 with value as argument.
1249 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1250 g_settings_new (Bug#8967). Do not create gsettings_obj.
1251 Remove calls to g_settings_bind. Connect something_changedCB to
1252 "changed".
1253
1254 * xgselect.c: Add defined (HAVE_GSETTINGS).
1255 (xgselect_initialize): Ditto.
1256
1257 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1258 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1259 xg_select.
1260
1261 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1262
1263 * eval.c (struct backtrace): Simplify and port the data structure.
1264 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1265 signed bit field, as this assumption is not portable and it makes
1266 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1267 "char debug_on_exit : 1" as this is not portable either; instead,
1268 use the portable "unsigned int debug_on_exit : 1". Remove unused
1269 member evalargs. Remove obsolete comments about cc bombing out.
1270
1271 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1272
1273 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1274 Let HAVE_GSETTINGS override HAVE_GCONF.
1275 (store_monospaced_changed): New function.
1276 (EMACS_SETTINGS): A new type derived from GObject to handle
1277 GSettings notifications.
1278 (emacs_settings_constructor, emacs_settings_get_property)
1279 (emacs_settings_set_property, emacs_settings_class_init):
1280 New functions.
1281 (gsettings_client, gsettings_obj): New variables.
1282 (GSETTINGS_SCHEMA): New define.
1283 (something_changedCB): Call store_monospaced_changed.
1284 (init_gsettings): New function.
1285 (xsettings_initialize): Call init_gsettings.
1286 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1287 to NULL.
1288
1289 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1290 GCONF_CFLAGS/LIBS.
1291
1292 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1293
1294 * window.c (resize_root_window, grow_mini_window)
1295 (shrink_mini_window): Rename Qresize_root_window to
1296 Qwindow_resize_root_window and Qresize_root_window_vertically to
1297 Qwindow_resize_root_window_vertically.
1298
1299 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1300
1301 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1302
1303 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1304
1305 * makefile.w32-in: Redesign dependencies so they reflect more
1306 clearly which files are directly included by each source file,
1307 and not through other includes.
1308
1309 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1310
1311 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1312 (sort_overlays, overlay_strings): When an overlay's clone number
1313 matches the window's clone number process the overlay even if
1314 the overlay's window property doesn't match the current window.
1315
1316 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1317 (Fwindow_hchild): Rename to Fwindow_left_child.
1318 (Fwindow_next): Rename to Fwindow_next_sibling.
1319 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1320 (resize_window_check): Rename to window_resize_check.
1321 (resize_window_apply): Rename to window_resize_apply.
1322 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1323 (Fdelete_other_windows_internal, resize_frame_windows)
1324 (Fsplit_window_internal, Fdelete_window_internal)
1325 (grow_mini_window, shrink_mini_window)
1326 (Fresize_mini_window_internal): Fix callers accordingly.
1327
1328 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1329
1330 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1331 (emacs_fixed_set_min_size): Remove.
1332 (emacs_fixed_new): Take frame as argument.
1333
1334 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1335 (_EmacsFixedPrivate): Remove minwidth/height.
1336 Add struct frame *f.
1337 (emacs_fixed_init): Initialize priv->f.
1338 (get_parent_class, emacs_fixed_set_min_size): Remove.
1339 (emacs_fixed_new): Set priv->f to argument.
1340 (emacs_fixed_get_preferred_width)
1341 (emacs_fixed_get_preferred_height): Use min_width/height from
1342 frames size_hint to set minimum and natural (Bug#8919).
1343 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1344 and use min_width/height from frames size_hint to set
1345 min_width/height (Bug#8919).
1346
1347 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1348 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1349 Fix indentation.
1350
1351 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1352
1353 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1354 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1355 called at ZV.
1356
1357 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1358
1359 * process.c (wait_reading_process_output): Bypass select if
1360 waiting for a cell while ignoring keyboard input, and input is
1361 pending. Suggested by Jan Djärv (Bug#8869).
1362
1363 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1364
1365 Use gnulib's dup2 module instead of rolling our own.
1366 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1367
1368 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1369
1370 * dispnew.c (scrolling_window): Before scrolling, turn off a
1371 mouse-highlight in the window being scrolled.
1372
1373 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1374
1375 Move DEFSYM to lisp.h and use everywhere.
1376
1377 * character.h (DEFSYM): Move declaration...
1378 * lisp.h (DEFSYM): ...here.
1379
1380 * gnutls.c:
1381 * minibuf.c:
1382 * w32menu.c:
1383 * w32proc.c:
1384 * w32select.c: Don't include character.h.
1385
1386 * alloc.c (syms_of_alloc):
1387 * buffer.c (syms_of_buffer):
1388 * bytecode.c (syms_of_bytecode):
1389 * callint.c (syms_of_callint):
1390 * casefiddle.c (syms_of_casefiddle):
1391 * casetab.c (init_casetab_once):
1392 * category.c (init_category_once, syms_of_category):
1393 * ccl.c (syms_of_ccl):
1394 * cmds.c (syms_of_cmds):
1395 * composite.c (syms_of_composite):
1396 * dbusbind.c (syms_of_dbusbind):
1397 * dired.c (syms_of_dired):
1398 * dispnew.c (syms_of_display):
1399 * doc.c (syms_of_doc):
1400 * editfns.c (syms_of_editfns):
1401 * emacs.c (syms_of_emacs):
1402 * eval.c (syms_of_eval):
1403 * fileio.c (syms_of_fileio):
1404 * fns.c (syms_of_fns):
1405 * frame.c (syms_of_frame):
1406 * fringe.c (syms_of_fringe):
1407 * insdel.c (syms_of_insdel):
1408 * keymap.c (syms_of_keymap):
1409 * lread.c (init_obarray, syms_of_lread):
1410 * macros.c (syms_of_macros):
1411 * msdos.c (syms_of_msdos):
1412 * print.c (syms_of_print):
1413 * process.c (syms_of_process):
1414 * search.c (syms_of_search):
1415 * sound.c (syms_of_sound):
1416 * syntax.c (init_syntax_once, syms_of_syntax):
1417 * terminal.c (syms_of_terminal):
1418 * textprop.c (syms_of_textprop):
1419 * undo.c (syms_of_undo):
1420 * w32.c (globals_of_w32):
1421 * window.c (syms_of_window):
1422 * xdisp.c (syms_of_xdisp):
1423 * xfaces.c (syms_of_xfaces):
1424 * xfns.c (syms_of_xfns):
1425 * xmenu.c (syms_of_xmenu):
1426 * xsettings.c (syms_of_xsettings):
1427 * xterm.c (syms_of_xterm): Use DEFSYM.
1428
1429 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1430
1431 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1432
1433 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1434
1435 Integer and buffer overflow fixes (Bug#8873).
1436
1437 * print.c (printchar, strout): Check for string overflow.
1438 (PRINTPREPARE, printchar, strout):
1439 Don't set size unless allocation succeeds.
1440
1441 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1442 for sizes. Check for string overflow more accurately.
1443 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1444
1445 * macros.c: Integer and buffer overflow fixes.
1446 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1447 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1448 Use ptrdiff_t, not int, for sizes.
1449 Don't increment bufsize until after realloc succeeds.
1450 Check for size-calculation overflow.
1451 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1452
1453 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1454
1455 * lread.c: Integer overflow fixes.
1456 (read_integer): Radix is now EMACS_INT, not int,
1457 to improve quality of diagnostics for out-of-range radices.
1458 Calculate buffer size correctly for out-of-range radices.
1459 (read1): Check for integer overflow in radices, and in
1460 read-circle numbers.
1461 (read_escape): Avoid int overflow.
1462 (Fload, openp, read_buffer_size, read1)
1463 (substitute_object_recurse, read_vector, read_list, map_obarray):
1464 Use ptrdiff_t, not int, for sizes.
1465 (read1): Use EMACS_INT, not int, for sizes.
1466 Check for size overflow.
1467
1468 * image.c (cache_image): Check for size arithmetic overflow.
1469
1470 * lread.c: Integer overflow issues.
1471 (saved_doc_string_size, saved_doc_string_length)
1472 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1473 Now ptrdiff_t, not int.
1474 (read1): Don't assume doc string length fits in int. Check for
1475 out-of-range doc string lengths.
1476 (read_list): Don't assume file position fits in int.
1477 (read_escape): Check for hex character overflow.
1478
1479 2011-06-22 Leo Liu <sdl.web@gmail.com>
1480
1481 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1482 Move to minibuffer.el.
1483
1484 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1485
1486 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1487 The following patches are for when GLYPH_DEBUG && !XASSERT.
1488 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1489 * dispnew.c (flush_stdout):
1490 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1491 Mark as externally visible.
1492 * dispnew.c (check_window_matrix_pointers): Now static.
1493 * dispnew.c (window_to_frame_vpos):
1494 * xfns.c (unwind_create_frame):
1495 * xterm.c (x_check_font): Remove unused local.
1496 * scroll.c (CHECK_BOUNDS):
1497 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1498 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1499 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1500 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1501 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1502 Now static.
1503 (debug_method_add): Use va_list and vsprintf rather than relying
1504 on undefined behavior with wrong number of arguments.
1505 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1506 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1507 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1508 since we're not interested in debugging glyphs with old libraries.
1509 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1510 GCC 4.6.0's static checking.
1511
1512 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1513
1514 Integer overflow and signedness fixes (Bug#8873).
1515 A few related buffer overrun fixes, too.
1516
1517 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1518
1519 * dispextern.h (struct face.stipple):
1520 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1521 (x_bitmap_mask, x_allocate_bitmap_record)
1522 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1523 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1524 (x_create_bitmap_from_xpm_data):
1525 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1526 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1527 (.bitmaps_last):
1528 * xfaces.c (load_pixmap):
1529 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1530 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1531 (.bitmaps_last, struct x_output.icon_bitmap):
1532 Use ptrdiff_t, not int, for bitmap indexes.
1533 (x_allocate_bitmap_record): Check for size overflow.
1534 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1535
1536 Use ptrdiff_t, not int, for overlay counts.
1537 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1538 * editfns.c (overlays_around, get_pos_property):
1539 * textprop.c (get_char_property_and_overlay):
1540 * xdisp.c (next_overlay_change, note_mouse_highlight):
1541 * xfaces.c (face_at_buffer_position):
1542 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1543 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1544 (Fnext_overlay_change, Fprevious_overlay_change)
1545 (mouse_face_overlay_overlaps, Foverlays_in):
1546 Use ptrdiff_t, not int, for sizes.
1547 (overlays_at, overlays_in): Check for size-calculation overflow.
1548
1549 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1550
1551 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1552 (x_session_initialize): Do not assume string length fits in int.
1553
1554 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1555 This is unlikely, but can occur if DPI is outlandish.
1556
1557 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1558 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1559
1560 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1561 * xrdb.c (magic_file_p, search_magic_path):
1562 Omit last arg SUFFIX; it was always 0. All callers changed.
1563 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1564
1565 * xfont.c (xfont_match): Avoid need for strlen.
1566
1567 * xfns.c: Don't assume strlen fits in int.
1568 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1569
1570 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1571 not unsigned long, as we prefer signed integers. All callers changed.
1572 Detect integer overflow in repeat count.
1573 (message_dolog): Don't assume print length fits in 39 bytes.
1574 (display_mode_element): Don't assume strlen fits in int.
1575
1576 * termcap.c: Don't assume sizes fit in int and never overflow.
1577 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1578 (gobble_line): Check for size-calculation overflow.
1579
1580 * minibuf.c (Fread_buffer):
1581 * lread.c (intern, intern_c_string):
1582 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1583 Don't assume string length fits in int.
1584
1585 * keyboard.c (parse_tool_bar_item):
1586 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1587
1588 * font.c: Don't assume string length fits in int.
1589 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1590 Use ptrdiff_t, not int.
1591 (font_intern_prop): Don't assume string length fits in int.
1592 Don't assume integer property fits in fixnum.
1593 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1594
1595 * filelock.c: Fix some buffer overrun and integer overflow issues.
1596 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1597 Reformulate so as not to need the command string.
1598 Invoke gzip -cd rather than gunzip, as it's more portable.
1599 (lock_info_type, lock_file_1, lock_file):
1600 Don't assume pid_t and time_t fit in unsigned long.
1601 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1602 (current_lock_owner): Prefer signed type for sizes.
1603 Use memcpy, not strncpy, where memcpy is what is really wanted.
1604 Don't assume (via atoi) that time_t and pid_t fit in int.
1605 Check for time_t and/or pid_t out of range, e.g., via a network share.
1606 Don't alloca where an auto var works fine.
1607
1608 * fileio.c: Fix some integer overflow issues.
1609 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1610 Don't assume string length fits in int.
1611 (directory_file_name): Don't assume string length fits in long.
1612 (make_temp_name): Don't assume pid fits in int, or that its print
1613 length is less than 20.
1614
1615 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1616
1617 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1618
1619 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1620
1621 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1622 We prefer signed integers, even for size calculations.
1623
1624 * emacs.c: Don't assume string length fits in 'int'.
1625 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1626 (main): Don't invoke strlen when not needed.
1627
1628 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1629 (XD_DEBUG_MESSAGE): Don't waste a byte.
1630
1631 * callproc.c (getenv_internal_1, getenv_internal)
1632 (Fgetenv_internal):
1633 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1634
1635 * lread.c (invalid_syntax): Omit length argument.
1636 All uses changed. This doesn't fix a bug, but it simplifies the
1637 code away from its former Hollerith-constant appearance, and it's
1638 one less 'int' to worry about when looking at integer-overflow issues.
1639 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1640
1641 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1642 This didn't break anything, but it didn't help either.
1643 It's confusing to put a bogus integer in a place where the actual
1644 value does not matter.
1645 (LIST_END_P): Remove unused macro and its bogus comment.
1646 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1647
1648 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1649 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1650 implementation.
1651 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1652 We prefer signed types, and the value cannot exceed the EMACS_INT
1653 range anyway (because otherwise the length would not be representable).
1654 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1655 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1656 This avoids a GCC warning when WIDE_EMACS_INT.
1657
1658 * indent.c (sane_tab_width): New function.
1659 (current_column, scan_for_column, Findent_to, position_indentation)
1660 (compute_motion): Use it. This is just for clarity.
1661 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1662
1663 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1664
1665 * lisp.h (lint_assume): New macro.
1666 * composite.c (composition_gstring_put_cache):
1667 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1668
1669 * editfns.c, insdel.c:
1670 Omit unnecessary forward decls, to simplify future changes.
1671
1672 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1673
1674 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1675
1676 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1677 Use much-faster test for byte-length change.
1678 Don't assume string byte-length fits in 'int'.
1679 Check that character arg fits in 'int'.
1680 (mapcar1): Declare byte as byte, for clarity.
1681
1682 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1683
1684 * fns.c (concat): Catch string overflow earlier.
1685 Do not rely on integer wraparound.
1686
1687 * dispextern.h (struct it.overlay_strings_charpos)
1688 (struct it.selective): Now EMACS_INT, not int.
1689 * xdisp.c (forward_to_next_line_start)
1690 (back_to_previous_visible_line_start)
1691 (reseat_at_next_visible_line_start, next_element_from_buffer):
1692 Don't arbitrarily truncate the value of 'selective' to int.
1693
1694 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1695
1696 * composite.c: Don't truncate sizes to 'int'.
1697 (composition_gstring_p, composition_reseat_it)
1698 (composition_adjust_point): Use EMACS_INT, not int.
1699 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1700 not EMACS_UINT, for indexes.
1701
1702 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1703
1704 * buffer.c: Include <verify.h>.
1705 (struct sortvec.priority, struct sortstr.priority):
1706 Now EMACS_INT, not int.
1707 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1708 (struct sortstr.size, record_overlay_string)
1709 (struct sortstrlist.size, struct sortlist.used):
1710 Don't truncate size to int.
1711 (record_overlay_string): Check for size-calculation overflow.
1712 (init_buffer_once): Check at compile-time, not run-time.
1713
1714 2011-06-22 Jim Meyering <meyering@redhat.com>
1715
1716 Don't leak an XBM-image-sized buffer
1717 * image.c (xbm_load): Free the image buffer after using it.
1718
1719 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1720
1721 Port to Sun C.
1722 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1723 that Sun C diagnosed.
1724 * fns.c (secure_hash): Fix pointer signedness issue.
1725 * intervals.c (static_offset_intervals): New function.
1726 (offset_intervals): Use it.
1727
1728 2011-06-21 Leo Liu <sdl.web@gmail.com>
1729
1730 * deps.mk (fns.o):
1731 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1732 sha512.h.
1733
1734 * fns.c (secure_hash): Rename from crypto_hash_function and change
1735 the first arg to accept symbols.
1736 (Fsecure_hash): New primitive.
1737 (syms_of_fns): New symbols.
1738
1739 2011-06-20 Deniz Dogan <deniz@dogan.se>
1740
1741 * process.c (Fset_process_buffer): Clarify return value in
1742 docstring.
1743
1744 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1745
1746 * dispnew.c (add_window_display_history): Use BVAR.
1747
1748 * xdisp.c (debug_method_add): Use BVAR.
1749 (check_window_end, dump_glyph_matrix, dump_glyph)
1750 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1751
1752 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1753 Likewise.
1754
1755 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1756 check till after the cache is created in init_frame_faces.
1757
1758 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1759
1760 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1761
1762 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1763
1764 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1765 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1766 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1767
1768 Improve buffer-overflow checking (Bug#8873).
1769 * fileio.c (Finsert_file_contents):
1770 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1771 Remove the old (too-loose) buffer overflow checks.
1772 They weren't needed, since make_gap checks for buffer overflow.
1773 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1774 The old code merely checked for Emacs fixnum overflow, and relied
1775 on undefined (wraparound) behavior. The new code avoids undefined
1776 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1777
1778 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1779 Tune. Don't use wider integers than needed. Don't use alloca.
1780 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1781
1782 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1783
1784 * insdel.c, lisp.h (buffer_overflow): New function.
1785 (insert_from_buffer_1, replace_range, replace_range_2):
1786 * insdel.c (make_gap_larger):
1787 * editfns.c (Finsert_char):
1788 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1789
1790 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1791
1792 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 Integer overflow and signedness fixes (Bug#8873).
1795
1796 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1797 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1798
1799 * fileio.c: Don't assume EMACS_INT fits in off_t.
1800 (emacs_lseek): New static function.
1801 (Finsert_file_contents, Fwrite_region): Use it.
1802 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1803
1804 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1805
1806 * fns.c: Don't overflow int when computing a list length.
1807 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1808 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1809 truncation on 64-bit hosts. Check for QUIT every
1810 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1811 faster and is responsive enough.
1812 (Flength): Report an error instead of overflowing an integer.
1813 (Fsafe_length): Return a float if the value is not representable
1814 as a fixnum. This shouldn't happen except in contrived situations.
1815 (Fnthcdr, Fsort): Don't assume list length fits in int.
1816 (Fcopy_sequence): Don't assume vector length fits in int.
1817
1818 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1819 (header_size, word_size): New constants.
1820 (allocate_vectorlike): Don't check size overflow here.
1821 (allocate_vector): Check it here instead, since this is the only
1822 caller of allocate_vectorlike that could cause overflow.
1823 Check that the new vector's length is representable as a fixnum.
1824
1825 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1826 The previous code was bogus. For example, next_almost_prime (32)
1827 returned 39, which is undesirable as it is a multiple of 3; and
1828 next_almost_prime (24) returned 25, which is a multiple of 5 so
1829 why was the code bothering to check for multiples of 7?
1830
1831 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1832
1833 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1834
1835 Variadic C functions now count arguments with ptrdiff_t.
1836 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1837 Back then I didn't know that the Emacs coding style prefers signed int.
1838 Also, in the meantime I found a few more instances where arguments
1839 were being counted with int, which may truncate counts on 64-bit
1840 machines, or EMACS_INT, which may be unnecessarily wide.
1841 * lisp.h (struct Lisp_Subr.function.aMANY)
1842 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1843 Arg counts are now ptrdiff_t, not size_t.
1844 All variadic functions and their callers changed accordingly.
1845 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1846 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1847 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1848 * callint.c (Fcall_interactively): Check arg count for overflow,
1849 to avoid potential buffer overrun. Use signed char, not 'int',
1850 for 'varies' array, so that we needn't bother to check its size
1851 calculation for overflow.
1852 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1853 * eval.c (apply_lambda):
1854 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1855 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1856 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1857
1858 * callint.c (Fcall_interactively): Don't use index var as event count.
1859
1860 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1861 * mem-limits.h (SIZE): Remove; no longer used.
1862
1863 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1864
1865 Remove unnecessary casts.
1866 * xterm.c (x_term_init):
1867 * xfns.c (x_set_border_pixel):
1868 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1869 These aren't needed now that we assume ANSI C.
1870
1871 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1872 It's more likely to cause problems (due to unsigned overflow)
1873 than to cure them.
1874
1875 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1876
1877 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1878
1879 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1880
1881 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1882
1883 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1884
1885 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1886
1887 GLYPH_CODE_FACE returns EMACS_INT, not int.
1888 * dispextern.h (merge_faces):
1889 * xfaces.c (merge_faces):
1890 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1891 Don't assume EMACS_INT fits in int.
1892
1893 * character.h (CHAR_VALID_P): Remove unused parameter.
1894 * fontset.c, lisp.h, xdisp.c: All uses changed.
1895
1896 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1897
1898 * fns.c (concat): Minor tuning based on overflow analysis.
1899 This doesn't fix any bugs. Use int to hold character, instead
1900 of constantly refetching from Emacs object. Use XFASTINT, not
1901 XINT, for value known to be a character. Don't bother comparing
1902 a single byte to 0400, as it's always less.
1903
1904 * floatfns.c (Fexpt):
1905 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1906
1907 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1908 for characters.
1909
1910 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1911
1912 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1913 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1914 incorrectly succeed when S was a string, because 4294967386 was
1915 truncated before it was used.
1916
1917 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1918 Otherwise, an out-of-range integer could cause undefined behavior
1919 on a 64-bit host.
1920
1921 * composite.c: Use int, not EMACS_INT, for characters.
1922 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1923 EMACS_INT, for values that are known to be in character range.
1924 This doesn't fix any bugs but is the usual style inside Emacs and
1925 may generate better code on 32-bit machines.
1926
1927 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1928 This is for reasons similar to the recent CHAR_STRING fix.
1929 * charset.c (Fencode_char): Check that character arg is actually
1930 a character. Pass an int to ENCODE_CHAR.
1931 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1932 wider than 'int', as a compile-time check to prevent future regressions
1933 in this area.
1934
1935 * character.c (char_string): Remove unnecessary casts.
1936
1937 Make sure a 64-bit char is never passed to CHAR_STRING.
1938 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1939 by silently ignoring the top 32 bits, allowing some values
1940 that were far too large to be valid characters.
1941 * character.h: Include <verify.h>.
1942 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1943 arguments are no wider than unsigned, as a compile-time check
1944 to prevent future regressions in this area.
1945 * data.c (Faset):
1946 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1947 (Fsubst_char_in_region):
1948 * fns.c (concat):
1949 * xdisp.c (decode_mode_spec_coding):
1950 Adjust to CHAR_STRING's new requirement.
1951 * editfns.c (Finsert_char, Fsubst_char_in_region):
1952 * fns.c (concat): Check that character args are actually
1953 characters. Without this test, these functions did the wrong
1954 thing with wildly out-of-range values on 64-bit hosts.
1955
1956 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1957 These casts should not be needed on 32-bit hosts, either.
1958 * keyboard.c (read_char):
1959 * lread.c (Fload): Remove casts to unsigned.
1960
1961 * lisp.h (UNSIGNED_CMP): New macro.
1962 This fixes comparison bugs on 64-bit hosts.
1963 (ASCII_CHAR_P): Use it.
1964 * casefiddle.c (casify_object):
1965 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1966 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1967 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1968 * dispextern.h (FACE_FROM_ID):
1969 * keyboard.c (read_char): Use UNSIGNED_CMP.
1970
1971 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1972 not to EMACS_INT, to avoid GCC warning.
1973
1974 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1975
1976 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1977 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1978 isn't needed on 32-bit machines.
1979
1980 * buffer.c (Fgenerate_new_buffer_name):
1981 Use EMACS_INT for count, not int.
1982 (advance_to_char_boundary): Return EMACS_INT, not int.
1983
1984 * data.c (Qcompiled_function): Now static.
1985
1986 * window.c (window_body_lines): Now static.
1987
1988 * image.c (gif_load): Rename local to avoid shadowing.
1989
1990 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1991 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1992 * alloc.c (make_save_value): Integer argument is now of type
1993 ptrdiff_t, not int.
1994 (mark_object): Use ptrdiff_t, not int.
1995 * lisp.h (pD): New macro.
1996 * print.c (print_object): Use it.
1997
1998 * alloc.c: Use EMACS_INT, not int, to count objects.
1999 (total_conses, total_markers, total_symbols, total_vector_size)
2000 (total_free_conses, total_free_markers, total_free_symbols)
2001 (total_free_floats, total_floats, total_free_intervals)
2002 (total_intervals, total_strings, total_free_strings):
2003 Now EMACS_INT, not int. All uses changed.
2004 (Fgarbage_collect): Compute overall total using a double, so that
2005 integer overflow is less likely to be a problem. Check for overflow
2006 when converting back to an integer.
2007 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2008 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2009 These were 'int' variables that could overflow on 64-bit hosts;
2010 they were never used, so remove them instead of repairing them.
2011 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2012 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2013 Previously, this ceilinged at INT_MAX, but that doesn't work on
2014 64-bit machines.
2015 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2016
2017 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2018 (allocate_vectorlike): Check for ptrdiff_t overflow.
2019 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2020 when a (possibly-narrower) signed value would do just as well.
2021 We prefer using signed arithmetic, to avoid comparison confusion.
2022
2023 * alloc.c: Catch some string size overflows that we were missing.
2024 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2025 for convenience in STRING_BYTES_MAX.
2026 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2027 The definition here is exact; the one in lisp.h was approximate.
2028 (allocate_string_data): Check for string overflow. This catches
2029 some instances we weren't catching before. Also, it catches
2030 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2031 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2032 and ptrdiff_t and EMACS_INT are both 64 bits.
2033
2034 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2035 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2036 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2037
2038 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2039
2040 * alloc.c (Fmake_string): Check for out-of-range init.
2041
2042 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2043
2044 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2045
2046 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2047
2048 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2049 xg_get_default_scrollbar_width.
2050
2051 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2052 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2053 (style_changed_cb): Call update_theme_scrollbar_width and call
2054 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2055 all frames (Bug#8505).
2056 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2057 Call gtk_window_set_resizable if HAVE_GTK3.
2058 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2059 and height if HAVE_GTK3 (Bug#8505).
2060 (scroll_bar_width_for_theme): New variable.
2061 (update_theme_scrollbar_width): New function.
2062 (xg_get_default_scrollbar_width): Move code to
2063 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2064 (xg_initialize): Call update_theme_scrollbar_width.
2065
2066 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2067
2068 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2069
2070 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2071
2072 * frame.c (make_frame): Call other_buffer_safely instead of
2073 other_buffer.
2074
2075 * window.c (temp_output_buffer_show): Call display_buffer with
2076 second argument Vtemp_buffer_show_specifiers and reset latter
2077 immediately after the call.
2078 (Vtemp_buffer_show_specifiers): New variable.
2079 (auto_window_vscroll_p, next_screen_context_lines)
2080 (Vscroll_preserve_screen_position): Remove leading asterisks from
2081 doc-strings.
2082
2083 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2084
2085 Fix minor problems found by GCC 4.6.0 static checking.
2086 * buffer.c (Qclone_number): Remove for now, as it's unused.
2087 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2088 (record_buffer): Remove unused local.
2089 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2090 (set_frame_buffer_list): Remove; unused.
2091 * frame.h (other_visible_frames): Remove decl.
2092 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2093 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2094 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2095 if HAVE_GPM.
2096 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2097 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2098 Define only if HAVE_GPM.
2099 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2100 (update_hints_inhibit): Remove; never set. All uses removed.
2101 * widgetprv.h (emacsFrameClassRec): Remove decl.
2102 * window.c (delete_deletable_window): Now returns void, since it
2103 wasn't returning anything.
2104 (compare_window_configurations): Remove unused locals.
2105 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2106 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2107 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2108 the same widths as pointers. This follows up on the 2011-05-06 patch.
2109 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2110 * xterm.h: Likewise.
2111 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2112
2113 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2114
2115 * makefile.w32-in: Update dependencies.
2116 (LISP_H): Add lib/intprops.h.
2117
2118 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2119
2120 * image.c (gif_load): Add animation frame delay to the metadata.
2121 (syms_of_image): Use DEFSYM. New symbol `delay'.
2122
2123 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2124
2125 * window.c (delete_deletable_window): Re-add.
2126 (Fset_window_configuration): Rewrite to handle dead buffers and
2127 consequently deletable windows.
2128 (window_tree, Fwindow_tree): Remove. Supply functionality in
2129 window.el.
2130 (compare_window_configurations): Simplify code.
2131
2132 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2133
2134 * image.c (imagemagick_load_image): Fix type mismatch.
2135 (Fimagemagick_types): Likewise.
2136
2137 * window.h (replace_buffer_in_windows): Declare.
2138
2139 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2140
2141 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2142 Qclone_number. Remove external declaration of Qdelete_window.
2143 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2144 code.
2145 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2146 Qbuffer_list_update_hook if allowed.
2147 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2148 buffer list implementation.
2149 (other_buffer_safely): New function.
2150 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2151 calls to replace_buffer_in_windows and
2152 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2153 if allowed.
2154 (record_buffer): Inhibit quitting and rewrite using quittable
2155 functions. Run Qbuffer_list_update_hook if allowed.
2156 (Frecord_buffer, Funrecord_buffer): New functions.
2157 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2158 switch-to-buffer to window.el.
2159 (bury-buffer): Move to window.el.
2160 (Vbuffer_list_update_hook): New variable.
2161
2162 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2163 section.
2164
2165 * window.h (resize_frame_windows): Move up in code.
2166 (Fwindow_frame): Remove EXFUN.
2167 (replace_buffer_in_all_windows): Remove prototype.
2168 (replace_buffer_in_windows_safely): Add prototype.
2169
2170 * window.c: Declare Qdelete_window static again. Move down
2171 declaration of select_count.
2172 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2173 (Fother_window): Move to window.el.
2174 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2175 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2176 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2177 window.el.
2178 (replace_buffer_in_windows): Implement by calling
2179 Qreplace_buffer_in_windows.
2180 (replace_buffer_in_all_windows): Remove with some functionality
2181 moved into replace_buffer_in_windows_safely.
2182 (replace_buffer_in_windows_safely): New function.
2183 (select_window_norecord, select_frame_norecord): Move in front
2184 of run_window_configuration_change_hook. Remove now obsolete
2185 declarations.
2186 (Fset_window_buffer): Rewrite doc-string. Call
2187 Qrecord_window_buffer.
2188 (keys_of_window): Move binding for other-window to window.el.
2189
2190 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2191
2192 * dispextern.h (struct image): Replace data member, whose int_val
2193 and ptr_val fields were not used by anything, with a single
2194 lisp_val object.
2195
2196 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2197 (gif_clear_image, gif_load, imagemagick_load_image)
2198 (gs_clear_image, gs_load): Callers changed.
2199
2200 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2201
2202 * buffer.h: Include <time.h>, for time_t.
2203 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2204
2205 Fix minor problems found by static checking.
2206
2207 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2208
2209 Make identifiers static if they are not used in other modules.
2210 * data.c (Qcompiled_function, Qframe, Qvector):
2211 * image.c (QimageMagick, Qsvg):
2212 * minibuf.c (Qmetadata):
2213 * window.c (resize_window_check, resize_root_window): Now static.
2214 * window.h (resize_window_check, resize_root_window): Remove decls.
2215
2216 * window.c (window_deletion_count, delete_deletable_window):
2217 Remove; unused.
2218 (window_body_lines): Now static.
2219 (Fdelete_other_windows_internal): Mark vars as initialized.
2220 Make sure 'resize_failed' is initialized.
2221 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2222 (resize_window_apply): Remove unused local.
2223 * window.h (delete_deletable_window): Remove decl.
2224
2225 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2226 (imagemagick_load_image): Fix pointer signedness problem by changing
2227 last arg from unsigned char * to char *. All uses changed.
2228 Also, fix a local for similar reasons.
2229 Remove unused locals. Remove locals to avoid shadowing.
2230 (fn_rsvg_handle_free): Remove; unused.
2231 (svg_load, svg_load_image): Fix pointer signedness problem.
2232 (imagemagick_load_image): Don't use garbage pointer image_wand.
2233
2234 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2235
2236 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2237
2238 * image.c (gif_load): Fix omitted cast error introduced by
2239 2011-06-06 change.
2240
2241 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2242
2243 * window.h (resize_proportionally, orig_total_lines)
2244 (orig_top_line): Remove from window structure.
2245 (set_window_height, set_window_width, change_window_heights)
2246 (Fdelete_window): Remove prototypes.
2247 (resize_frame_windows): Remove duplicate declaration.
2248
2249 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2250
2251 * window.h (resize_frame_windows, resize_window_check)
2252 (delete_deletable_window, resize_root_window)
2253 (resize_frame_windows): Declare prototypes.
2254
2255 * window.c (resize_window_apply): Make definition be "static" to
2256 match the prototype.
2257
2258 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2259
2260 * window.c: Remove declarations of Qwindow_size_fixed,
2261 window_min_size_1, window_min_size_2, window_min_size,
2262 size_window, window_fixed_size_p, enlarge_window, delete_window.
2263 Remove static from declaration of Qdelete_window, it's
2264 temporarily needed by Fbury_buffer.
2265 (replace_window): Don't assign orig_top_line and
2266 orig_total_lines.
2267 (Fdelete_window, delete_window): Remove. Window deletion is
2268 handled by window.el.
2269 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2270 Fdelete_window calls with calls to Qdelete_window.
2271 (Fdelete_other_windows): Remove. Deleting other windows is
2272 handled by window.el.
2273 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2274 handled in window.el.
2275 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2276 Window minimum sizes are handled in window.el.
2277 (shrink_windows, size_window, set_window_height)
2278 (set_window_width, change_window_heights, window_height)
2279 (window_width, CURBEG, CURSIZE, enlarge_window)
2280 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2281 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2282 handled in window.el.
2283 (make_dummy_parent): Rename to make_parent_window and give it a
2284 second argument horflag.
2285 (make_window): Don't set resize_proportionally any more.
2286 (Fsplit_window): Remove. Windows are split in window.el.
2287 (save_restore_action, save_restore_orig_size)
2288 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2289 Resize mini windows in window.el.
2290 (grow_mini_window, shrink_mini_window): Implement by calling
2291 Qresize_root_window_vertically, resize_window_check and
2292 resize_window_apply.
2293 (saved_window, Fset_window_configuration, save_window_save): Do
2294 not handle orig_top_line, orig_total_lines, and
2295 resize_proportionally.
2296 (window_min_height, window_min_width): Move to window.el.
2297 (keys_of_window): Move bindings for delete-other-windows,
2298 split-window, delete-window and enlarge-window to window.el.
2299
2300 * buffer.c: Temporarily extern Qdelete_window.
2301 (Fbury_buffer): Temporarily call Qdelete_window instead of
2302 Fdelete_window (Fbury_buffer will move to window.el soon).
2303
2304 * frame.c (set_menu_bar_lines_1): Remove code handling
2305 orig_top_line and orig_total_lines.
2306
2307 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2308 set_window_height but set heights directly.
2309 (change_frame_size_1): Use resize_frame_windows.
2310
2311 * xdisp.c (init_xdisp): Don't use set_window_height but set
2312 heights directly.
2313
2314 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2315 resize_frame_windows instead of change_window_heights and run
2316 run_window_configuration_change_hook.
2317
2318 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2319 instead of change_window_heights and run
2320 run_window_configuration_change_hook.
2321
2322 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2323
2324 * window.c (replace_window): Rename second argument REPLACEMENT to
2325 NEW. New third argument SETFLAG. Rewrite.
2326 (delete_window, make_dummy_parent): Call replace_window with
2327 third argument 1.
2328 (window_list_1): Move down in code.
2329 (run_window_configuration_change_hook): Move set_buffer part
2330 before select_frame_norecord part in order to unwind correctly.
2331 Rename count1 to count.
2332 (recombine_windows, delete_deletable_window, resize_root_window)
2333 (Fdelete_other_windows_internal)
2334 (Frun_window_configuration_change_hook, make_parent_window)
2335 (resize_window_check, resize_window_apply, Fresize_window_apply)
2336 (resize_frame_windows, Fsplit_window_internal)
2337 (Fdelete_window_internal, Fresize_mini_window_internal): New
2338 functions.
2339 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2340
2341 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2342
2343 * window.h (window): Add some new members to window structure -
2344 normal_lines, normal_cols, new_total, new_normal, clone_number,
2345 splits, nest, prev_buffers, next_buffers.
2346 (WINDOW_TOTAL_SIZE): Move here from window.c.
2347 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2348
2349 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2350 Remove.
2351 (make_dummy_parent): Set new members of windows structure.
2352 (make_window): Move down in code. Handle new members of window
2353 structure.
2354 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2355 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2356 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2357 (Fset_window_prev_buffers, Fwindow_next_buffers)
2358 (Fset_window_next_buffers, Fset_window_clone_number): New
2359 functions.
2360 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2361 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2362 Doc-string fixes.
2363 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2364 Argument WINDOW can be now internal window too.
2365 (Fwindow_use_time): Move up in code.
2366 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2367 Rewrite doc-string.
2368 (Fset_window_configuration, saved_window)
2369 (Fcurrent_window_configuration, save_window_save): Handle new
2370 members of window structure.
2371 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2372 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2373 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2374 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2375 Qget_mru_window, Qresize_root_window,
2376 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2377 Qauto_buffer_name; staticpro them.
2378
2379 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2380
2381 * window.c (Fwindow_total_size, Fwindow_left_column)
2382 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2383 (Fwindow_list_1): New functions.
2384 (window_box_text_cols): Replace with window_body_cols.
2385 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2386 window_body_cols instead of window_box_text_cols.
2387 (delete_window, Fset_window_configuration): Call
2388 delete_all_subwindows with window as argument.
2389 (delete_all_subwindows): Take a window as argument and not a
2390 structure. Rewrite.
2391 (window_loop): Remove handling of GET_LRU_WINDOW and
2392 GET_LARGEST_WINDOW.
2393 (Fget_lru_window, Fget_largest_window): Move to window.el.
2394
2395 * window.h: Extern window_body_cols instead of
2396 window_box_text_cols. delete_all_subwindows now takes a
2397 Lisp_Object as argument.
2398
2399 * indent.c (compute_motion, Fcompute_motion): Use
2400 window_body_cols instead of window_box_text_cols.
2401
2402 * frame.c (delete_frame): Call delete_all_subwindows with root
2403 window as argument.
2404
2405 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2406
2407 * fns.c (Fputhash): Document return value.
2408
2409 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2410
2411 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2412
2413 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2414
2415 Cons<->int and similar integer overflow fixes (Bug#8794).
2416
2417 Check for overflow when converting integer to cons and back.
2418 * charset.c (Fdefine_charset_internal, Fdecode_char):
2419 Use cons_to_unsigned to catch overflow.
2420 (Fencode_char): Use INTEGER_TO_CONS.
2421 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2422 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2423 * data.c (long_to_cons, cons_to_long): Remove.
2424 (cons_to_unsigned, cons_to_signed): New functions.
2425 These signal an error for invalid or out-of-range values.
2426 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2427 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2428 * font.c (Ffont_variation_glyphs):
2429 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2430 * lisp.h: Include <intprops.h>.
2431 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2432 (cons_to_signed, cons_to_unsigned): New decls.
2433 (long_to_cons, cons_to_long): Remove decls.
2434 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2435 (Fprimitive_undo): Use CONS_TO_INTEGER.
2436 * xfns.c (Fx_window_property): Likewise.
2437 * xselect.c: Include <limits.h>.
2438 (x_own_selection, selection_data_to_lisp_data):
2439 Use INTEGER_TO_CONS.
2440 (x_handle_selection_request, x_handle_selection_clear)
2441 (x_get_foreign_selection, Fx_disown_selection_internal)
2442 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2443 (lisp_data_to_selection_data): Use cons_to_unsigned.
2444 (x_fill_property_data): Use cons_to_signed.
2445 Report values out of range.
2446
2447 Check for buffer and string overflow more precisely.
2448 * buffer.h (BUF_BYTES_MAX): New macro.
2449 * lisp.h (STRING_BYTES_MAX): New macro.
2450 * alloc.c (Fmake_string):
2451 * character.c (string_escape_byte8):
2452 * coding.c (coding_alloc_by_realloc):
2453 * doprnt.c (doprnt):
2454 * editfns.c (Fformat):
2455 * eval.c (verror):
2456 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2457 since they may not be the same number.
2458 * editfns.c (Finsert_char):
2459 * fileio.c (Finsert_file_contents):
2460 Likewise for BUF_BYTES_MAX.
2461
2462 * image.c: Use ptrdiff_t, not int, for sizes.
2463 (slurp_file): Switch from int to ptrdiff_t.
2464 All uses changed.
2465 (slurp_file): Check that file size fits in both size_t (for
2466 malloc) and ptrdiff_t (for sanity and safety).
2467
2468 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2469 if b->modtime has its maximal value.
2470
2471 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2472
2473 Don't assume time_t can fit into int.
2474 * buffer.h (struct buffer.modtime): Now time_t, not int.
2475 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2476 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2477
2478 Minor fixes for signed vs unsigned integers.
2479 * character.h (MAYBE_UNIFY_CHAR):
2480 * charset.c (maybe_unify_char):
2481 * keyboard.c (read_char, reorder_modifiers):
2482 XINT -> XFASTINT, since the integer must be nonnegative.
2483 * ftfont.c (ftfont_spec_pattern):
2484 * keymap.c (access_keymap, silly_event_symbol_error):
2485 XUINT -> XFASTINT, since the integer must be nonnegative.
2486 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2487 since it makes no difference and we prefer signed.
2488 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2489 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2490 nonnegative.
2491
2492 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2493
2494 * window.h (Fwindow_frame): Declare.
2495
2496 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2497
2498 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2499 (SPARE_MEMORY): Always define.
2500 (LARGE_REQUEST): Remove.
2501 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2502
2503 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2504
2505 * lisp.h: Move EXFUNS for Fframe_root_window,
2506 Fframe_first_window and Fset_frame_selected_window to window.h.
2507
2508 * window.h: Move EXFUNS for Fframe_root_window,
2509 Fframe_first_window and Fset_frame_selected_window here from
2510 lisp.h.
2511
2512 * frame.c (Fwindow_frame, Fframe_first_window)
2513 (Fframe_root_window, Fframe_selected_window)
2514 (Fset_frame_selected_window): Move to window.c.
2515 (Factive_minibuffer_window): Move to minibuf.c.
2516 (Fother_visible_frames_p): New function.
2517
2518 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2519
2520 * window.c (decode_window, decode_any_window): Move up in code.
2521 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2522 (inhibit_frame_unsplittable): Remove unused variable.
2523 (Fwindow_buffer): Move up and rewrite doc-string.
2524 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2525 (Fwindow_prev): New functions.
2526 (Fwindow_frame): Move here from frame.c. Accept any window as
2527 argument.
2528 (Fframe_root_window, Fframe_first_window)
2529 (Fframe_selected_window): Move here from frame.c. Accept frame
2530 or arbitrary window as argument. Update doc-strings.
2531 (Fminibuffer_window): Move up in code.
2532 (Fwindow_minibuffer_p): Move up in code and simplify.
2533 (Fset_frame_selected_window): Move here from frame.c.
2534 Marginal rewrite.
2535 (Fselected_window, select_window, Fselect_window): Move up in
2536 code. Minor doc-string fixes.
2537
2538 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2539
2540 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2541 Do not assume that spare memory exists; that assumption is valid
2542 only if SYSTEM_MALLOC.
2543 (LARGE_REQUEST): New macro, so that the issue of large requests
2544 is separated from the issue of spare memory.
2545
2546 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2547
2548 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2549 format. (Bug#8806)
2550
2551 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2552
2553 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2554 before statements.
2555
2556 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2557
2558 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2559
2560 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2561
2562 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2563 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2564
2565 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2566
2567 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2568
2569 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2570
2571 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2572 (x_clipboard_manager_save): Add return value.
2573 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2574 New error handlers.
2575 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2576 Obey Vx_select_enable_clipboard_manager. Catch errors in
2577 x_clipboard_manager_save (Bug#8779).
2578 (Vx_select_enable_clipboard_manager): New variable.
2579 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2580
2581 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2582
2583 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2584
2585 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2586
2587 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2588 in the current matrix if keep_current_p is non-zero.
2589
2590 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2591
2592 * bidi.c (bidi_level_of_next_char): Fix last change.
2593
2594 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2595
2596 Support bidi reordering of text covered by display properties.
2597
2598 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2599 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2600 (bidi_cache_search, bidi_cache_iterator_state)
2601 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2602 (bidi_level_of_next_char, bidi_move_to_visually_next):
2603 Support character positions inside a run of characters covered by a
2604 display string.
2605 (bidi_paragraph_init, bidi_resolve_explicit_1)
2606 (bidi_level_of_next_char): Call bidi_fetch_char and
2607 bidi_fetch_char_advance instead of FETCH_CHAR and
2608 FETCH_CHAR_ADVANCE.
2609 (bidi_init_it): Initialize new members.
2610 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2611 definitions.
2612 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2613 instead of using explicit *_CHAR codes.
2614 (bidi_resolve_explicit, bidi_resolve_weak):
2615 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2616 bidirectional text is supported only in multibyte buffers.
2617 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2618 it to initialize the frame_window_p member of struct bidi_it.
2619 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2620 (bidi_resolve_explicit, bidi_resolve_weak)
2621 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2622 bidi_it->nchars is non-positive.
2623 (bidi_level_of_next_char): Don't try to lookup the cache for the
2624 next/previous character if nothing is cached there yet, or if we
2625 were just reseat()'ed to a new position.
2626
2627 * xdisp.c (set_cursor_from_row): Set start and stop points
2628 according to the row's direction when priming the loop that looks
2629 for the glyph on which to display cursor.
2630 (single_display_spec_intangible_p): Function deleted.
2631 (display_prop_intangible_p): Reimplement to call
2632 handle_display_spec instead of single_display_spec_intangible_p.
2633 Accept 3 additional arguments needed by handle_display_spec.
2634 This fixes incorrect cursor motion across display property with complex
2635 values: lists, `(when COND...)' forms, etc.
2636 (single_display_spec_string_p): Support property values that are
2637 lists with the argument STRING its top-level element.
2638 (display_prop_string_p): Fix the condition for processing a
2639 property that is a list to be consistent with handle_display_spec.
2640 (handle_display_spec): New function, refactored from the
2641 last portion of handle_display_prop.
2642 (compute_display_string_pos): Accept additional argument
2643 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2644 value of a `display' property is a "replacing spec".
2645 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2646 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2647 the display property, but just return a value indicating whether
2648 the display property will replace the characters it covers.
2649 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2650 frame_window_p members of struct bidi_it.
2651 (compute_display_string_pos, compute_display_string_end):
2652 New functions.
2653 (push_it): Accept second argument POSITION, where pop_it should
2654 jump to continue iteration.
2655 (reseat_1): Initialize bidi_it.disp_pos.
2656
2657 * keyboard.c (adjust_point_for_property): Adjust the call to
2658 display_prop_intangible_p to its new signature.
2659
2660 * dispextern.h (struct bidi_it): New member frame_window_p.
2661 (bidi_init_it): Update prototypes.
2662 (display_prop_intangible_p): Update prototype.
2663 (compute_display_string_pos, compute_display_string_end):
2664 Declare prototypes.
2665 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2666 EMACS_INT.
2667
2668 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2669
2670 Malloc failure behavior now depends on size of allocation.
2671 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2672 * lisp.h: Change signatures accordingly.
2673 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2674 All callers changed. (Bug#8762)
2675
2676 * gnutls.c: Use Emacs's memory allocators.
2677 Without this change, the gnutls library would invoke malloc etc.
2678 directly, which causes problems on non-SYNC_INPUT hosts, and which
2679 runs afoul of improving memory_full behavior. (Bug#8761)
2680 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2681 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2682 xfree instead of the default malloc, realloc, free.
2683 (Fgnutls_boot): No need to check for memory allocation failure,
2684 since xmalloc does that for us.
2685
2686 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2687 * category.c (hash_get_category_set):
2688 * ccl.c (ccl_driver):
2689 * charset.c (Fdefine_charset_internal):
2690 * charset.h (struct charset.hash_index):
2691 * composite.c (get_composition_id, gstring_lookup_cache)
2692 (composition_gstring_put_cache):
2693 * composite.h (struct composition.hash_index):
2694 * dispextern.h (struct image.hash):
2695 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2696 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2697 (hashfn_equal, hashfn_user_defined, make_hash_table)
2698 (maybe_resize_hash_table, hash_lookup, hash_put)
2699 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2700 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2701 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2702 * image.c (make_image, search_image_cache, lookup_image)
2703 (xpm_put_color_table_h):
2704 * lisp.h (struct Lisp_Hash_Table):
2705 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2706 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2707 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2708 * alloc.c (allocate_vectorlike):
2709 Check for overflow in vector size calculations.
2710 * ccl.c (ccl_driver):
2711 Check for overflow when converting EMACS_INT to int.
2712 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2713 need to be updated by these changes.
2714 * fns.c (make_hash_table, maybe_resize_hash_table):
2715 Check for integer overflow with large hash tables.
2716 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2717 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2718 (SXHASH_REDUCE): New macro.
2719 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2720 Use it instead of discarding useful hash info with large hash values.
2721 (sxhash_float): New function.
2722 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2723 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2724 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2725 Rewrite to use FIXNUM_BITS, as this simplifies things.
2726 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2727 Adjust signatures to match updated version of code.
2728 (consing_since_gc): Now EMACS_INT, since a single hash table can
2729 use more than INT_MAX bytes.
2730
2731 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2732
2733 Make it possible to build with GCC-4.6+ -O2 -flto.
2734
2735 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2736
2737 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2738
2739 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2740 Call minibuffer-inactive-mode.
2741
2742 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2743
2744 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2745 Update dependencies.
2746
2747 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2748
2749 * data.c (init_data): Remove code for UTS, this system is not
2750 supported anymore.
2751
2752 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2753
2754 Don't force ./temacs to start in terminal mode.
2755
2756 * frame.c (make_initial_frame): Initialize faces in all cases, not
2757 only when CANNOT_DUMP is defined.
2758 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2759
2760 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2761
2762 * dispnew.c (add_window_display_history): Use const for the string
2763 pointer. Remove declaration, not needed.
2764
2765 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2766
2767 Use 'inline', not 'INLINE'.
2768 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2769 * alloc.c, fontset.c (INLINE): Remove.
2770 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2771 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2772 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2773 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2774 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2775
2776 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2777
2778 Make it possible to run ./temacs.
2779
2780 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2781 syms_of_callproc does the same thing. Remove test for
2782 "initialized", do it in the caller.
2783 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2784
2785 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2786
2787 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2788 (read_minibuf): Use get_minibuffer.
2789 (syms_of_minibuf): Use DEFSYM.
2790 (Qmetadata): New var.
2791 * data.c (Qbuffer): Don't make it static.
2792 (syms_of_data): Use DEFSYM.
2793
2794 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2795
2796 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2797 (CCL_CODE_MIN): New macro.
2798
2799 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2800
2801 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2802
2803 * eval.c (Qdebug): Now static.
2804 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2805 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2806 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2807
2808 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2809
2810 * image.c: Various fixes to ImageMagick code comments.
2811 (Fimagemagick_types): Doc fix.
2812
2813 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2814
2815 Minor fixes prompted by GCC 4.6.0 warnings.
2816
2817 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2818
2819 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2820 (x_clipboard_manager_save_all): Move extern decl to ...
2821 * xterm.h: ... here, so that it can be checked for consistency.
2822
2823 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2824
2825 * xselect.c (x_clipboard_manager_save_frame)
2826 (x_clipboard_manager_save_all): New functions.
2827 (Fx_clipboard_manager_save): Lisp function deleted.
2828
2829 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2830 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2831
2832 * xterm.h: Update prototype.
2833
2834 2011-05-28 William Xu <william.xwl@gmail.com>
2835
2836 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2837 exiting (Bug#8239).
2838
2839 2011-05-28 Jim Meyering <meyering@redhat.com>
2840
2841 Avoid a sign-extension bug in crypto_hash_function.
2842 * fns.c (to_uchar): Define.
2843 (crypto_hash_function): Use it to convert some newly-signed
2844 variables to unsigned, to avoid sign-extension bugs. For example,
2845 without this change, (md5 "truc") would evaluate to
2846 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2847 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2848 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2849
2850 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2851
2852 Integer overflow fixes.
2853
2854 * dbusbind.c: Serial number integer overflow fixes.
2855 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2856 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2857 to hold a serial number that is too large for a fixnum.
2858 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2859 Check for serial numbers out of range. Decode any serial number
2860 that was so large that it became a float. (Bug#8722)
2861
2862 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2863 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2864 Use XFASTINT rather than XUINT when numbers are nonnegative.
2865 (xd_append_arg, Fdbus_method_return_internal):
2866 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2867 arguments, check that Lisp number is nonnegative, rather than
2868 silently wrapping negative numbers around. (Bug#8722)
2869 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2870 (Bug#8722)
2871
2872 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2873
2874 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2875
2876 ccl: add integer overflow checks
2877 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2878 (IN_INT_RANGE): New macros.
2879 (ccl_driver): Use them to check for integer overflow when
2880 decoding a CCL program. Many of the new checks are whether XINT (x)
2881 fits in int; it doesn't always, on 64-bit hosts. The new version
2882 doesn't catch all possible integer overflows, but it's an
2883 improvement. (Bug#8719)
2884
2885 * alloc.c (make_event_array): Use XINT, not XUINT.
2886 There's no need for unsigned here.
2887
2888 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2889 This follows up to the 2011-05-06 change that substituted uintptr_t
2890 for EMACS_INT. This case wasn't caught back then.
2891
2892 Rework Fformat to avoid integer overflow issues.
2893 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2894 now (part of C89). Include <verify.h>.
2895 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2896 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2897 (Fformat): Avoid the prepass trying to compute sizes; it was only
2898 approximate and thus did not catch overflow reliably. Instead, walk
2899 through the format just once, formatting and computing sizes as we go,
2900 checking for integer overflow at every step, and allocating a larger
2901 buffer as needed. Keep track separately whether the format is
2902 multibyte. Keep only the most-recently calculated precision, rather
2903 than them all. Record whether each argument has been converted to
2904 string. Use EMACS_INT, not int, for byte and char and arg counts.
2905 Support field widths and precisions larger than INT_MAX. Avoid
2906 sprintf's undefined behavior with conversion specifications such as %#d
2907 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2908 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2909 formatting out-of-range floating point numbers with int
2910 formats. (Bug#8668)
2911
2912 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2913
2914 * data.c: Avoid integer truncation in expressions involving floats.
2915 * data.c: Include <intprops.h>.
2916 (arith_driver): When there's an integer overflow in an expression
2917 involving floating point, convert the integers to floating point
2918 so that the resulting value does not suffer from catastrophic
2919 integer truncation. For example, on a 64-bit host (* 4
2920 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2921 Do not rely on undefined behavior after integer overflow.
2922
2923 merge count_size_as_multibyte, parse_str_to_multibyte
2924 * character.c, character.h (count_size_as_multibyte):
2925 Rename from parse_str_to_multibyte; all uses changed.
2926 Check for integer overflow.
2927 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2928 since it's now a duplicate of the other. This is more of
2929 a character than a buffer op, so better that it's in character.c.
2930 * fns.c, print.c: Adjust to above changes.
2931
2932 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2933
2934 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2935
2936 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2939 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2940 (x_clipboard_manager_save): Now static.
2941 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2942
2943 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2944 (crypto_hash_function): Now static.
2945 Fix pointer signedness problems. Avoid unnecessary initializations.
2946
2947 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2948
2949 * termhooks.h (Vselection_alist): Make it terminal-local.
2950
2951 * terminal.c (create_terminal): Initialize it.
2952
2953 * xselect.c: Support for clipboard managers.
2954 (Vselection_alist): Move to termhooks.h as terminal-local var.
2955 (LOCAL_SELECTION): New macro.
2956 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2957 (symbol_to_x_atom): Remove gratuitous arg.
2958 (x_handle_selection_request, lisp_data_to_selection_data)
2959 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2960 (x_own_selection, x_get_local_selection, x_convert_selection):
2961 New arg, specifying work frame. Use terminal-local Vselection_alist.
2962 (some_frame_on_display): Delete unused function.
2963 (Fx_own_selection_internal, Fx_get_selection_internal)
2964 (Fx_disown_selection_internal, Fx_selection_owner_p)
2965 (Fx_selection_exists_p): New optional frame arg.
2966 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2967 (x_handle_selection_clear): Don't treat other terminals with the
2968 same keyboard specially. Use the terminal-local Vselection_alist.
2969 (x_clear_frame_selections): Use Frun_hook_with_args.
2970
2971 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2972
2973 * xterm.h: Add support for those atoms.
2974
2975 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2976
2977 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2978 (converted_selections, conversion_fail_tag): New global variables.
2979 (x_selection_request_lisp_error): Free the above.
2980 (x_get_local_selection): Remove unnecessary code.
2981 (x_reply_selection_request): Args changed; handle arbitrary array
2982 of converted selections stored in converted_selections.
2983 Separate the XChangeProperty and SelectionNotify steps.
2984 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2985 (x_convert_selection): New function.
2986 (x_handle_selection_event): Simplify.
2987 (x_get_foreign_selection): Don't ignore incoming requests while
2988 waiting for an answer; this will fail when we implement
2989 SAVE_TARGETS, and seems unnecessary anyway.
2990 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2991 (Vx_sent_selection_functions): Doc fix.
2992
2993 2011-05-26 Leo Liu <sdl.web@gmail.com>
2994
2995 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2996
2997 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2998
2999 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3000
3001 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3002 for fringe update if it has periodic bitmap.
3003 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3004 and fringe_bitmap_periodic_p.
3005
3006 * fringe.c (get_fringe_bitmap_data): New function.
3007 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3008 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3009 row. Mark glyph row for fringe update if periodicity changed.
3010
3011 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3012 for fringe update unless it has periodic bitmap.
3013
3014 2011-05-25 Kenichi Handa <handa@m17n.org>
3015
3016 * xdisp.c (get_next_display_element): Set correct it->face_id for
3017 a static composition.
3018
3019 2011-05-24 Leo Liu <sdl.web@gmail.com>
3020
3021 * deps.mk (fns.o):
3022 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3023
3024 * fns.c (crypto_hash_function, Fsha1): New function.
3025 (Fmd5): Use crypto_hash_function.
3026 (syms_of_fns): Add Ssha1.
3027
3028 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3029
3030 * gnutls.c: Remove unused macros.
3031 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3032 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3033 Remove macros that are defined and never used.
3034 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3035
3036 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3037
3038 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3039 (Fx_get_selection_internal): Minor cleanup.
3040 (Fx_own_selection_internal): Rename arguments for consistency with
3041 select.el.
3042
3043 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3046
3047 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3048
3049 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3050
3051 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3052
3053 * dispnew.c (scrolling_window): Don't exclude the case that the
3054 last enabled row in the desired matrix touches the bottom boundary.
3055
3056 2011-05-21 Glenn Morris <rgm@gnu.org>
3057
3058 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3059 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3060 and add some more files.
3061
3062 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3063
3064 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3065 report_file_error introduced by the change from 2011-05-07.
3066
3067 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3068
3069 * systime.h (Time): Define only if emacs is defined.
3070 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3071 where the include path doesn't have X11/X.h by default. See
3072 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3073
3074 2011-05-20 Kenichi Handa <handa@m17n.org>
3075
3076 * composite.c (find_automatic_composition): Fix previous change.
3077
3078 2011-05-20 Glenn Morris <rgm@gnu.org>
3079
3080 * lisp.mk: New file, split from Makefile.in.
3081 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3082 (shortlisp): Remove.
3083 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3084
3085 2011-05-19 Glenn Morris <rgm@gnu.org>
3086
3087 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3088 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3089 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3090 (lisp): Set the order to that of loadup.el.
3091 (shortlisp): Make it a copy of $lisp.
3092 (SOME_MACHINE_LISP): Remove.
3093 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3094 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3095
3096 2011-05-18 Kenichi Handa <handa@m17n.org>
3097
3098 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3099 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3100 (find_automatic_composition): Mostly rewrite for efficiency.
3101
3102 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3103
3104 * makefile.w32-in: Update dependencies.
3105
3106 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3107
3108 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3109 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3110
3111 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3112
3113 Fix some integer overflow issues, such as string length overflow.
3114
3115 * insdel.c (count_size_as_multibyte): Check for string overflow.
3116
3117 * character.c (lisp_string_width): Check for string overflow.
3118 Use EMACS_INT, not int, for string indexes and lengths; in
3119 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3120 the resulting string length overflows an EMACS_INT; instead,
3121 report a string overflow if no precision given. When checking for
3122 precision exhaustion, use a check that cannot possibly have
3123 integer overflow. (Bug#8675)
3124 * character.h (lisp_string_width): Adjust to new signature.
3125
3126 * alloc.c (string_overflow): New function.
3127 (Fmake_string): Use it. This doesn't change behavior, but saves
3128 a few bytes and will simplify future changes.
3129 * character.c (string_escape_byte8): Likewise.
3130 * lisp.h (string_overflow): New decl.
3131
3132 Fixups, following up to the user-interface timestamp change.
3133 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3134 for UI timestamps, instead of unsigned long.
3135 * msdos.c (mouse_get_pos): Likewise.
3136 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3137 * w32gui.h (Time): Define by including "systime.h" rather than by
3138 declaring it ourselves. (Bug#8664)
3139
3140 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3141 * image.c (clear_image_cache): Likewise.
3142
3143 * term.c (term_mouse_position): Don't assume time_t wraparound.
3144
3145 Be more systematic about user-interface timestamps.
3146 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3147 and sometimes 'EMACS_UINT', to represent these timestamps.
3148 This change causes it to use 'Time' uniformly, as that's what X uses.
3149 This makes the code easier to follow, and makes it easier to catch
3150 integer overflow bugs such as Bug#8664.
3151 * frame.c (Fmouse_position, Fmouse_pixel_position):
3152 Use Time, not unsigned long, for user-interface timestamps.
3153 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3154 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3155 * keyboard.h (last_event_timestamp): Likewise.
3156 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3157 * menu.h (xmenu_show): Likewise.
3158 * term.c (term_mouse_position): Likewise.
3159 * termhooks.h (struct input_event.timestamp): Likewise.
3160 (struct terminal.mouse_position_hook): Likewise.
3161 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3162 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3163 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3164 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3165 what it was before.
3166 * menu.h, termhooks.h: Include "systime.h", for Time.
3167
3168 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3169 Don't assume that the difference between two unsigned long values
3170 can fit into an integer. At this point, we know button_down_time
3171 <= event->timestamp, so the difference must be nonnegative, so
3172 there's no need to cast the result if double-click-time is
3173 nonnegative, as it should be; check that it's nonnegative, just in
3174 case. This bug is triggered when events are more than 2**31 ms
3175 apart (about 25 days). (Bug#8664)
3176
3177 * xselect.c (last_event_timestamp): Remove duplicate decl.
3178 (x_own_selection): Remove needless cast to unsigned long.
3179
3180 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3181 that always fit in int. Use a sentinel instead of a counter, to
3182 avoid a temp and to allay GCC's concerns about possible int overflow.
3183 * frame.h (struct frame): Use int for menu_bar_items_used
3184 instead of EMACS_INT, since it always fits in int.
3185
3186 * menu.c (grow_menu_items): Check for int overflow.
3187
3188 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3189
3190 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3191 Before, the code was not consistent. These values cannot exceed
3192 2**31 - 1 so there's no need to make them unsigned.
3193 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3194 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3195 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3196 as modifiers.
3197 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3198
3199 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3200 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3201 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3202 presumably because the widths might not match.
3203
3204 * window.c (size_window): Avoid needless test at loop start.
3205
3206 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3207
3208 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3209
3210 2011-05-12 Drew Adams <drew.adams@oracle.com>
3211
3212 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3213
3214 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3215
3216 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3217 `width' to `bar_area_x' and `bar_area_width', respectively.
3218 (x_scroll_run): Take account of fringe background extension.
3219
3220 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3221 Rename local vars `left' and `width' to `bar_area_x' and
3222 `bar_area_width', respectively.
3223 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3224 background extension.
3225
3226 2011-05-10 Jim Meyering <meyering@redhat.com>
3227
3228 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3229
3230 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3231
3232 * image.c (Finit_image_library): Return t for built-in image types,
3233 like pbm and xbm. (Bug#8640)
3234
3235 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3236
3237 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3238
3239 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3240
3241 * w32console.c (Fset_screen_color): Doc fix.
3242 (Fget_screen_color): New function.
3243 (syms_of_ntterm): Defsubr it.
3244
3245 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3246 unlink the temporary file if Fcall_process didn't create it in the
3247 first place.
3248 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3249 child process will be redirected to a file specified with `:file'.
3250 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3251 cue to call_process_cleanup not to close that handle.
3252
3253 2011-05-07 Ben Key <bkey76@gmail.com>
3254
3255 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3256 one of two shell specific rules, either bootstrap-temacs-CMD or
3257 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3258 to the previous implementation of the bootstrap-temacs rule.
3259 The bootstrap-temacs-CMD rule is similar to the previous
3260 implementation of the bootstrap-temacs rule except that it
3261 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3262 variable.
3263
3264 These changes, along with some changes to nt/configure.bat,
3265 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3266 earlier fix to add support for --cflags and --ldflags options
3267 that include quotes so that it works whether make uses cmd or
3268 sh as the shell.
3269
3270 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3271
3272 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3273 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3274 is a constant.
3275 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3276 a string. Handle both cases.
3277 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3278 (Fdbus_register_method): Use Qinvalid_function.
3279
3280 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3281
3282 * makefile.w32-in: Update dependencies.
3283 (LISP_H): Add inttypes.h and stdin.h.
3284 (PROCESS_H): Add unistd.h.
3285
3286 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3287
3288 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3289 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3290
3291 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3292
3293 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3294
3295 * term.c (vfatal): Remove stray call to va_end.
3296 It's not needed and the C Standard doesn't allow it here anyway.
3297
3298 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3299 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3300
3301 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3302 bytes.
3303
3304 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3305
3306 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3307
3308 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3309
3310 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3311
3312 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3313
3314 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3315 * charset.c (Fdefine_charset_internal): Don't initialize
3316 charset.code_space[15]. The value was garbage, on hosts with
3317 32-bit int (Bug#8600).
3318
3319 * lread.c (read_integer): Be more consistent with string-to-number.
3320 Use string_to_number to do the actual conversion; this avoids
3321 rounding errors and fixes some other screwups. Without this fix,
3322 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3323 (digit_to_number): Move earlier, for benefit of read_integer.
3324 Return -1 if the digit is out of range for the base, -2 if it is
3325 not a digit in any supported base. (Bug#8602)
3326
3327 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3328
3329 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3330 to match comment at start of function. This also removes a
3331 GCC warning about overflow in a 32+64-bit port.
3332
3333 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3334
3335 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3336 Reported by Stefan Monnier in
3337 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3338 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3339 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3340
3341 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3342 (EMACS_UINTPTR): Likewise, with uintptr_t.
3343
3344 * lisp.h: Prefer 64-bit EMACS_INT if available.
3345 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3346 on 32-bit hosts that have 64-bit int, so that they can access
3347 large files.
3348 However, temporarily disable this change unless the temporary
3349 symbol WIDE_EMACS_INT is defined.
3350
3351 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3352
3353 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3354 This removes an assumption that EMACS_INT and long are the same
3355 width as pointers. The assumption is true for Emacs porting targets
3356 now, but we want to make other targets possible.
3357 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3358 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3359 In the rest of the code, change types of integers that hold casted
3360 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3361 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3362 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3363 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3364 No need to cast type when ORing.
3365 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3366 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3367 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3368 assume EMACS_INT is the same width as char *.
3369 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3370 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3371 Remove no-longer-needed casts.
3372 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3373 (xg_tool_bar_help_callback, xg_make_tool_item):
3374 Use EMACS_INTPTR to hold an integer
3375 that will be cast to void *; this can avoid a GCC warning
3376 if EMACS_INT is not the same width as void *.
3377 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3378 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3379 (current_message_1, set_message_1):
3380 Use a local to convert to proper width without a cast.
3381 * xmenu.c (dialog_selection_callback): Likewise.
3382
3383 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3384 Also, don't assume VALBITS / RAND_BITS is less than 5,
3385 and don't rely on undefined behavior when shifting a 1 left into
3386 the sign bit.
3387 * lisp.h (get_random): Change signature to match.
3388
3389 * lread.c (hash_string): Use size_t, not int, for hash computation.
3390 Normally we prefer signed values; but hashing is special, because
3391 it's better to use unsigned division on hash table sizes so that
3392 the remainder is nonnegative. Also, size_t is the natural width
3393 for hashing into memory. The previous code used 'int', which doesn't
3394 retain enough info to hash well into very large tables.
3395 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3396
3397 * dbusbind.c: Don't possibly lose pointer info when converting.
3398 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3399 Use XPNTR rather than XHASH, so that the high-order bits of
3400 the pointer aren't lost when converting through void *.
3401
3402 * eval.c (Fautoload): Don't double-shift a pointer.
3403
3404 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3405
3406 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3407
3408 * gnutls.c (DEF_GNUTLS_FN):
3409 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3410
3411 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3412
3413 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3414 marker. (Bug#8610)
3415
3416 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3417
3418 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3419 New version that can reserve upto 2GB of heap space.
3420
3421 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3422
3423 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3424
3425 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3426
3427 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3428 `gnutls_certificate_set_x509_key_file'.
3429
3430 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3431
3432 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3433 Update dependencies.
3434
3435 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3436
3437 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3438 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3439 Remove unused parameter `fildes'.
3440 * process.c (read_process_output, send_process): Don't pass it.
3441
3442 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3443
3444 Fix previous change: the library cache is defined in w32.c.
3445 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3446 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3447
3448 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3449
3450 Implement dynamic loading of GnuTLS on Windows.
3451
3452 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3453 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3454 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3455 Declare.
3456
3457 * gnutls.c (Qgnutls_dll): Define.
3458 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3459 (gnutls_*): Declare function pointers.
3460 (init_gnutls_functions): New function to initialize function pointers.
3461 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3462 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3463 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3464 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3465 (emacs_gnutls_write, emacs_gnutls_read)
3466 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3467 (Fgnutls_available_p): New function.
3468 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3469 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3470 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3471
3472 * image.c: Include w32.h.
3473 (Vimage_type_cache): Delete.
3474 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3475 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3476 (w32_delayed_load): Move to w32.c.
3477
3478 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3479
3480 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3481 (w32_delayed_load): Move from image.c. When loading a library, record
3482 its filename in the :loaded-from property of the library id.
3483 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3484 Initialize and staticpro them.
3485 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3486
3487 * process.c: Include lisp.h before w32.h, not after.
3488 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3489 instead of gnutls_record_check_pending.
3490
3491 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3492
3493 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3494
3495 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3496 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3497 as passed in.
3498
3499 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3500
3501 * xterm.c (x_set_frame_alpha): Do not set property on anything
3502 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3503
3504 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3505
3506 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3507
3508 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3509
3510 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3511 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3512 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3513 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3514 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3515 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3516 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3517 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3518 (Qgnutls_bootprop_callbacks_verify): Make static.
3519
3520 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3521
3522 * callproc.c: Indentation fixup.
3523
3524 * sysdep.c (wait_for_termination_1): Make static.
3525 (wait_for_termination, interruptible_wait_for_termination):
3526 Move after wait_for_termination_1.
3527
3528 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3529
3530 * sysdep.c (interruptible_wait_for_termination): New function
3531 which is like wait_for_termination, but allows keyboard
3532 interruptions.
3533
3534 * callproc.c (Fcall_process): Add (:file "file") as an option for
3535 the STDOUT buffer.
3536 (Fcall_process_region): Ditto.
3537
3538 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3539
3540 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3541 rather than `XVECTOR (FOO)->size'.
3542
3543 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3544 inttypes.h, as a gnulib replacement is used if it not available in
3545 system headers.
3546
3547 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3548
3549 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3550 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3551 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3552
3553 * coding.c (coding_alloc_by_realloc): Error out if destination
3554 will grow beyond MOST_POSITIVE_FIXNUM.
3555 (decode_coding_emacs_mule): Abort if there isn't enough place in
3556 charbuf for the composition carryover bytes. Reserve an extra
3557 space for up to 2 characters produced in a loop.
3558 (decode_coding_iso_2022): Abort if there isn't enough place in
3559 charbuf for the composition carryover bytes.
3560
3561 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3562
3563 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3564 aborting when %lld or %lll format is passed.
3565 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3566 %llo or %llx format is passed. (Bug#8545)
3567
3568 * window.c (window_scroll_line_based): Use a marker instead of
3569 simple variables to record original value of point. (Bug#7952)
3570
3571 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3572 produced by %s or %c overflows available buffer space. (Bug#8545)
3573
3574 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3575
3576 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3577 (SIZE_MAX): Move defn after all includes, as they might #define it.
3578
3579 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3580
3581 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3582
3583 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3584
3585 * keyboard.c (Qdelayed_warnings_hook): Define.
3586 (command_loop_1): Run `delayed-warnings-hook'
3587 if Vdelayed_warnings_list is non-nil.
3588 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3589 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3590
3591 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3592
3593 * doprnt.c (doprnt): Don't return value smaller than the buffer
3594 size if the message was truncated. (Bug#8545).
3595
3596 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3597
3598 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3599 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3600
3601 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3602
3603 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3604
3605 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3606
3607 * makefile.w32-in: Update dependencies.
3608
3609 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3610
3611 Improve `doprnt' and its usage. (Bug#8545)
3612 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3613 `format_end'. Remove support for %l as a conversion specifier.
3614 Don't use xrealloc. Improve diagnostics when the %l size modifier
3615 is used. Update the commentary.
3616
3617 * eval.c (verror): Simplify calculation of size_t.
3618
3619 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3620 messages.
3621
3622 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3623
3624 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3625 change.
3626
3627 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3628
3629 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3630 This makes this file independent of the recent pseudovector change.
3631
3632 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3633
3634 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3635
3636 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3637 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3638 Remove unused local.
3639 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3640
3641 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3642 GCC 4.6.0 optimizes based on type-based alias analysis.
3643 For example, if b is of type struct buffer * and v of type struct
3644 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3645 != &v->size, and therefore "v->size = 1; b->size = 2; return
3646 v->size;" must therefore return 1. This assumption is incorrect
3647 for Emacs, since it type-puns struct Lisp_Vector * with many other
3648 types. To fix this problem, this patch adds a new type struct
3649 vectorlike_header that documents the constraints on layout of vectors
3650 and pseudovectors, and helps optimizing compilers not get fooled
3651 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3652 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3653 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3654 the size member.
3655 (XSETPVECTYPE): Rewrite in terms of new macro.
3656 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3657 This is a bit clearer, and further avoids the possibility of
3658 undesirable aliasing.
3659 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3660 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3661 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3662 since Lisp_Subr is a special case (no "next" field).
3663 (ASIZE): Now uses header.size rather than size.
3664 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3665 to avoid the hassle of writing XVECTOR (foo)->header.size.
3666 (struct vectorlike_header): New type.
3667 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3668 object, to help avoid aliasing.
3669 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3670 (SUBRP): Likewise, since Lisp_Subr is a special case.
3671 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3672 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3673 (struct Lisp_Hash_Table): Combine first two members into a single
3674 struct vectorlike_header member. All uses of "size" and "next" members
3675 changed to be "header.size" and "header.next".
3676 * buffer.h (struct buffer): Likewise.
3677 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3678 * frame.h (struct frame): Likewise.
3679 * process.h (struct Lisp_Process): Likewise.
3680 * termhooks.h (struct terminal): Likewise.
3681 * window.c (struct save_window_data, struct saved_window): Likewise.
3682 * window.h (struct window): Likewise.
3683 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3684 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3685 * buffer.c (init_buffer_once): Likewise.
3686 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3687 special case.
3688 * process.c (Fformat_network_address): Use local var for size,
3689 for brevity.
3690
3691 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3692
3693 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3694 * data.c (atof): Remove decl; no longer used or needed.
3695 (digit_to_number): Move to lread.c.
3696 (Fstring_to_number): Use new string_to_number function, to be
3697 consistent with how the Lisp reader treats infinities and NaNs.
3698 Do not assume that floating-point numbers represent EMACS_INT
3699 without losing information; this is not true on most 64-bit hosts.
3700 Avoid double-rounding errors, by insisting on integers when
3701 parsing non-base-10 numbers, as the documentation specifies.
3702 * lisp.h (string_to_number): New decl, replacing ...
3703 (isfloat_string): Remove.
3704 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3705 (read1): Do not accept +. and -. as integers; this
3706 appears to have been a coding error. Similarly, do not accept
3707 strings like +-1e0 as floating point numbers. Do not report
3708 overflow for integer overflows unless the base is not 10 which
3709 means we have no simple and reliable way to continue.
3710 Break out the floating-point parsing into a new
3711 function string_to_number, so that Fstring_to_number parses
3712 floating point numbers consistently with the Lisp reader.
3713 (digit_to_number): Move here from data.c. Make it static inline.
3714 (E_CHAR, EXP_INT): Remove, replacing with ...
3715 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3716 (string_to_number): New function, replacing isfloat_string.
3717 This function checks for valid syntax and produces the resulting
3718 Lisp float number too. Rework it so that string-to-number
3719 no longer mishandles examples like "1.0e+". Use strtoumax,
3720 so that overflow for non-base-10 numbers is reported only when
3721 there's no portable and simple way to convert to floating point.
3722
3723 * textprop.c (set_text_properties_1): Rewrite for clarity,
3724 and to avoid GCC warning about integer overflow.
3725
3726 * intervals.h (struct interval): Use EMACS_INT for members
3727 where EMACS_UINT might cause problems. See
3728 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3729 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3730 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3731 All uses changed.
3732 (offset_intervals): Tell GCC not to worry about length overflow
3733 when negating a negative length.
3734
3735 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3736 (overrun_check_free): Likewise.
3737
3738 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3739 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3740 word size.
3741
3742 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3743 (gnutls_make_error): Rename local to avoid shadowing.
3744 (gnutls_emacs_global_deinit): ifdef out; not used.
3745 (Fgnutls_boot): Use const for pointer to readonly storage.
3746 Comment out unused local. Fix pointer signedness problems.
3747
3748 * lread.c (openp): Don't stuff size_t into an 'int'.
3749 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3750 about possible signed overflow.
3751
3752 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3753 (GDK_KEY_g): Don't define if already defined.
3754 (xg_prepare_tooltip): Avoid pointer signedness problem.
3755 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3756
3757 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3758 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3759
3760 * xfns.c (Fx_window_property): Simplify a bit,
3761 to make a bit faster and to avoid GCC 4.6.0 warning.
3762 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3763
3764 * fns.c (internal_equal): Don't assume size_t fits in int.
3765
3766 * alloc.c (compact_small_strings): Tighten assertion a little.
3767
3768 Replace pEd with more-general pI, and fix some printf arg casts.
3769 * lisp.h (pI): New macro, generalizing old pEd macro to other
3770 conversion specifiers. For example, use "...%"pI"d..." rather
3771 than "...%"pEd"...".
3772 (pEd): Remove. All uses replaced with similar uses of pI.
3773 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3774 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3775 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3776 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3777 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3778 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3779 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3780 64-bit hosts.
3781 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3782 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3783 * print.c (safe_debug_print, print_object): Likewise.
3784 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3785 to int.
3786 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3787 avoiding the 0 flag, which is not portable.
3788 * process.c (Fmake_network_process): Use pI to avoid cast.
3789 * region-cache.c (pp_cache): Likewise.
3790 * xdisp.c (decode_mode_spec): Likewise.
3791 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3792 behavior on 64-bit hosts with printf arg.
3793 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3794 (x_stop_queuing_selection_requests): Likewise.
3795 (x_get_window_property): Don't truncate byte count to an 'int'
3796 when tracing.
3797
3798 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3799 here, since it parses constructs like leading '-' and spaces,
3800 which are not wanted; and it overflows with large numbers.
3801 Instead, simply match F[0-9]+, which is what is wanted anyway.
3802
3803 * alloc.c: Remove unportable assumptions about struct layout.
3804 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3805 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3806 (allocate_vectorlike, make_pure_vector): Use the new macros,
3807 plus offsetof, to remove unportable assumptions about struct layout.
3808 These assumptions hold on all porting targets that I know of, but
3809 they are not guaranteed, they're easy to remove, and removing them
3810 makes further changes easier.
3811
3812 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3813 This doesn't fix a bug but makes the code clearer.
3814 (string_overrun_cookie): Now const. Use initializers that
3815 don't formally overflow signed char, to avoid warnings.
3816 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3817 can cause Emacs to crash when string overrun checking is enabled.
3818 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3819 multiple of sizeof (EMACS_INT); it need not be, if
3820 alignof(EMACS_INT) < sizeof (EMACS_INT).
3821 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3822
3823 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3824
3825 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3826
3827 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3828
3829 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3830 supposed to be handshaking. (Bug#8556)
3831 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3832
3833 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3834
3835 * lisp.h (Qdebug): List symbol.
3836 * eval.c (Qdebug): Restore global linkage.
3837 * keyboard.c (debug-on-event): New variable.
3838 (handle_user_signal): Break into debugger when debug-on-event
3839 matches the current signal symbol.
3840
3841 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3842
3843 * alloc.c (check_sblock, check_string_bytes)
3844 (check_string_free_list): Convert to standard C.
3845
3846 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3847
3848 * w32.c (emacs_gnutls_push): Fix typo.
3849
3850 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3851
3852 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3853 "cast to pointer from integer of different size".
3854
3855 Improve doprnt and its use in verror. (Bug#8545)
3856 * doprnt.c (doprnt): Document the set of format control sequences
3857 supported by the function. Use SAFE_ALLOCA instead of always
3858 using `alloca'.
3859
3860 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3861 is one byte too soon. Don't use xrealloc; instead xfree and
3862 xmalloc anew.
3863
3864 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3865
3866 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3867 callbacks stage.
3868
3869 * gnutls.c: Renamed global_initialized to
3870 gnutls_global_initialized. Added internals for the
3871 :verify-hostname-error, :verify-error, and :verify-flags
3872 parameters of `gnutls-boot' and documented those parameters in the
3873 docstring. Start callback support.
3874 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3875 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3876 on error. Return error code.
3877 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3878 (emacs_gnutls_read): Likewise.
3879 (Fgnutls_boot): Return handshake error code.
3880 (emacs_gnutls_handle_error): New function.
3881 (wsaerror_to_errno): Likewise.
3882
3883 * w32.h (emacs_gnutls_pull): Add prototype.
3884 (emacs_gnutls_push): Likewise.
3885
3886 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3887 (emacs_gnutls_push): Likewise.
3888
3889 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3890
3891 * process.c (wait_reading_process_output): Check if GnuTLS
3892 buffered some data internally if no FDs are set for TLS
3893 connections.
3894
3895 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3896 (LIBS): Link to USER_LIBS.
3897 ($(BLD)/gnutls.$(0)): New target.
3898
3899 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3900
3901 * xdisp.c (handle_single_display_spec): Rename the
3902 display_replaced_before_p argument into display_replaced_p, to
3903 make it consistent with the commentary. Fix typos in the
3904 commentary.
3905
3906 * textprop.c (syms_of_textprop): Remove dead code.
3907 (copy_text_properties): Delete obsolete commentary about an
3908 interface that was deleted long ago. Fix typos in the description
3909 of arguments.
3910
3911 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3912 to changes in oldXMenu/XMenu.h from 2011-04-16.
3913 <menu_help_message, prev_menu_help_message>: Constify.
3914 (IT_menu_make_room): menu->help_text is now `const char **';
3915 adjust.
3916
3917 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3918 to changes in oldXMenu/XMenu.h from 2011-04-16.
3919 (struct XMenu): Declare `help_text' `const char **'.
3920
3921 * xfaces.c <Qunspecified>: Make extern again.
3922
3923 * syntax.c: Include sys/types.h before including regex.h, as
3924 required by Posix.
3925
3926 * doc.c (get_doc_string): Improve the format passed to `error'.
3927
3928 * doprnt.c (doprnt): Improve commentary.
3929
3930 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3931
3932 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3933 them with etags.
3934
3935 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3936 changes in globals.h immediately force recompilation.
3937 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3938 $(CURDIR)/s/ms-w32.h.
3939 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3940
3941 * character.c (Fchar_direction): Function deleted.
3942 (syms_of_character): Don't defsubr it.
3943 <char-direction-table>: Deleted.
3944
3945 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3946
3947 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3948 * doprnt.c: Include limits.h.
3949 (SIZE_MAX): New macro.
3950 (doprnt): Return a size_t value. 2nd arg is now size_t.
3951 Many local variables are now size_t instead of int or unsigned.
3952 Improve overflow protection. Support `l' modifier for integer
3953 conversions. Support %l conversion. Don't assume an EMACS_INT
3954 argument for integer conversions and for %c.
3955
3956 * lisp.h (doprnt): Restore prototype.
3957
3958 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3959 $(SRC)/character.h.
3960
3961 * Makefile.in (base_obj): Add back doprnt.o.
3962
3963 * deps.mk (doprnt.o): Add back prerequisites.
3964 (callint.o): Depend on character.h.
3965
3966 * eval.c (internal_lisp_condition_case): Include the handler
3967 representation in the error message.
3968 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3969 when breaking from the loop.
3970
3971 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3972
3973 * callint.c (Fcall_interactively): When displaying error message
3974 about invalid control letter, pass the character's codepoint, not
3975 a pointer to its multibyte form. Improve display of the character
3976 in octal and display also its hex code.
3977
3978 * character.c (char_string): Use %x to display the (unsigned)
3979 codepoint of an invalid character, to avoid displaying a bogus
3980 negative value.
3981
3982 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3983 `error', not SYMBOL_NAME itself.
3984
3985 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3986 character arguments to `error'.
3987
3988 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3989 to `error' in error message about FINAL_CHAR argument. Make sure
3990 FINAL_CHAR is a character, and use %c when it is passed as
3991 argument to `error'.
3992
3993 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3994
3995 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3996
3997 * w32.c: Include <time.h>.
3998 (sys_localtime): New function.
3999
4000 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4001
4002 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4003
4004 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4005
4006 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4007
4008 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4009 zombies (Bug#8467).
4010
4011 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4012
4013 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4014 gl_state.e_property when gl_state.object is Qt.
4015
4016 * insdel.c (make_gap_larger): Remove limitation of buffer size
4017 to <= INT_MAX.
4018
4019 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4020
4021 * xdisp.c (lookup_glyphless_char_display)
4022 (produce_glyphless_glyph): Handle cons cell entry in
4023 glyphless-char-display.
4024 (Vglyphless_char_display): Document it.
4025
4026 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4027 glyphless-char-display.
4028
4029 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4030
4031 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4032
4033 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4034
4035 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4036 definition for no-X builds.
4037
4038 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4039
4040 Static checks with GCC 4.6.0 and non-default toolkits.
4041
4042 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4043
4044 * process.c (keyboard_bit_set): Define only if SIGIO.
4045 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4046 (send_process): Repair possible setjmp clobbering.
4047
4048 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4049
4050 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4051
4052 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4053
4054 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4055 Define only if needed.
4056
4057 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4058 by pacifying GCC about it. Maybe it's time to retire it?
4059 * xfaces.c (USG, __TIMEVAL__): Likewise.
4060
4061 * dispextern.h (struct redisplay_interface): Rename param
4062 to avoid shadowing.
4063 * termhooks.h (struct terminal): Likewise.
4064 * xterm.c (xembed_send_message): Likewise.
4065
4066 * insdel.c (make_gap_smaller): Define only if
4067 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4068
4069 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4070 it.
4071
4072 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4073 so that we aren't warned about unused symbols.
4074
4075 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4076
4077 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4078
4079 * xfns.c (x_real_positions): Mark locals as initialized.
4080
4081 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4082
4083 * xterm.c: Fix problems found by static analysis with other toolkits.
4084 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4085 (x_dispatch_event): Declare static if USE_GTK, and
4086 define if USE_GTK || USE_X_TOOLKIT.
4087 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4088 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4089 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4090 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4091
4092 * xmenu.c (menu_help_callback): Pointer type fixes.
4093 Use const pointers when pointing at readonly data. Avoid pointer
4094 signedness clashes.
4095 (FALSE): Remove unused macro.
4096 (update_frame_menubar): Remove unused decl.
4097
4098 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4099
4100 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4101 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4102 (single_menu_item): Rename local to avoid shadowing.
4103
4104 * keyboard.c (make_lispy_event): Remove unused local var.
4105
4106 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4107 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4108
4109 * bitmaps: Change bitmaps from unsigned char back to the X11
4110 compatible char. Avoid the old compiler warnings about
4111 out-of-range initializers by using, for example, '\xab' rather
4112 than 0xab.
4113
4114 * xgselect.c (xgselect_initialize): Check vs interface
4115 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4116
4117 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4118
4119 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4120 to read-only memory.
4121
4122 * fns.c (vector): Remove; this old hack is no longer needed.
4123
4124 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4125 Remove unused var.
4126 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4127
4128 * xrdb.c (x_load_resources): Omit unused local.
4129
4130 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4131 (x_window): Rename locals to avoid shadowing.
4132 (USG): Use the kludged USG macro, to pacify gcc.
4133
4134 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4135 (x_term_init): Remove local to avoid shadowing.
4136
4137 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4138
4139 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4140 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4141
4142 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4143
4144 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4145
4146 Fix regex.c, syntax.c and friends for buffers > 2GB.
4147 * syntax.h (struct gl_state_s): Declare character position members
4148 EMACS_INT.
4149
4150 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4151
4152 * textprop.c (verify_interval_modification, interval_of):
4153 Declare arguments EMACS_INT.
4154
4155 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4156 EMACS_INT.
4157
4158 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4159
4160 * indent.c (Fvertical_motion): Local variable it_start is now
4161 EMACS_INT.
4162
4163 * regex.c (re_match, re_match_2, re_match_2_internal)
4164 (bcmp_translate, regcomp, regexec, print_double_string)
4165 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4166 (re_compile_pattern, re_exec): Declare arguments and local
4167 variables `size_t' and `ssize_t' and return values `regoff_t', as
4168 appropriate.
4169 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4170 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4171 <compile_stack_type>: `size' and `avail' are now `size_t'.
4172
4173 * regex.h <regoff_t>: Use ssize_t, not int.
4174 (re_search, re_search_2, re_match, re_match_2): Arguments that
4175 specify buffer/string position and length are now ssize_t and
4176 size_t. Return type is regoff_t.
4177
4178 2011-04-16 Ben Key <bkey76@gmail.com>
4179
4180 * nsfont.m: Fixed bugs in ns_get_family and
4181 ns_descriptor_to_entity that were caused by using free to
4182 deallocate memory blocks that were allocated by xmalloc (via
4183 xstrdup). This caused Emacs to crash when compiled with
4184 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4185 --enable-checking=xmallocoverrun). xfree is now used to
4186 deallocate these memory blocks.
4187
4188 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4189
4190 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4191
4192 emacs_write: Accept and return EMACS_INT for sizes.
4193 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4194 et seq.
4195 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4196 Accept and return EMACS_INT.
4197 (emacs_gnutls_write): Return the number of bytes written on
4198 partial writes.
4199 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4200 (emacs_read, emacs_write): Remove check for negative size, as the
4201 Emacs source code has been audited now.
4202 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4203 (emacs_read, emacs_write): Use it.
4204 * process.c (send_process): Adjust to the new signatures of
4205 emacs_write and emacs_gnutls_write. Do not attempt to store
4206 a byte offset into an 'int'; it might overflow.
4207 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4208
4209 * sound.c: Don't assume sizes fit in 'int'.
4210 (struct sound_device.period_size, alsa_period_size):
4211 Return EMACS_INT, not int.
4212 (struct sound_device.write, vox_write, alsa_write):
4213 Accept EMACS_INT, not int.
4214 (wav_play, au_play): Use EMACS_INT to store sizes and to
4215 record read return values.
4216
4217 2011-04-15 Ben Key <bkey76@gmail.com>
4218
4219 * keyboard.c (Qundefined): Don't declare static since it is used
4220 in nsfns.m.
4221 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4222 static since they are used in nsfont.m.
4223
4224 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4225
4226 * process.c (Qprocessp): Don't declare static.
4227 * lisp.h (Qprocessp): Declare again.
4228
4229 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4230
4231 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4232
4233 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4234
4235 Improve C-level modularity by making more things 'static'.
4236
4237 Don't publish debugger-only interfaces to other modules.
4238 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4239 (verify_bytepos, count_markers): Move decls to the only modules
4240 that need them.
4241 * region-cache.h (pp_cache): Likewise.
4242 * window.h (check_all_windows): Likewise.
4243 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4244
4245 * sysdep.c (croak): Now static, if
4246 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4247 * syssignal.h (croak): Declare only if not static.
4248
4249 * alloc.c (refill_memory_reserve): Now static if
4250 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4251 * lisp.h (refill_memory_reserve): Declare only if not static.
4252
4253 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4254 Define only if USE_LUCID.
4255
4256 * xrdb.c (x_customization_string, x_rm_string): Now static.
4257
4258 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4259 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4260
4261 * xdisp.c (draw_row_with_mouse_face): Now static.
4262 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4263
4264 * window.h (check_all_windows): Mark externally visible.
4265
4266 * window.c (window_deletion_count): Now static.
4267
4268 * undo.c: Make symbols static if they're not exported.
4269 (last_undo_buffer, last_boundary_position, pending_boundary):
4270 Now static.
4271
4272 * textprop.c (interval_insert_behind_hooks): Now static.
4273 (interval_insert_in_front_hooks): Likewise.
4274
4275 * term.c: Make symbols static if they're not exported.
4276 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4277 (max_frame_lines, tty_set_terminal_modes):
4278 (tty_reset_terminal_modes, tty_turn_off_highlight):
4279 (get_tty_terminal): Now static.
4280 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4281 * termhooks.h (term_mouse_moveto): Do not declare if
4282 HAVE_WINDOW_SYSTEM.
4283 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4284 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4285
4286 * sysdep.c: Make symbols static if they're not exported.
4287 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4288 Now static.
4289 (sigprocmask_set, full_mask): Remove; unused.
4290 (wait_debugging): Mark as visible.
4291 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4292 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4293
4294 * syntax.c (syntax_temp): Define only if !__GNUC__.
4295
4296 * sound.c (current_sound_device, current_sound): Now static.
4297
4298 * search.c (searchbufs, searchbuf_head): Now static.
4299
4300 * scroll.c (scroll_cost): Remove; unused.
4301 * dispextern.h (scroll_cost): Remove decl.
4302
4303 * region-cache.h (pp_cache): Mark as externally visible.
4304
4305 * process.c: Make symbols static if they're not exported.
4306 (process_tick, update_tick, create_process, chan_process):
4307 (Vprocess_alist, proc_buffered_char, datagram_access):
4308 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4309 (deactivate_process): Mark defn as static, as well as decl.
4310 * lisp.h (create_process): Remove decl.
4311 * process.h (chan_process, Vprocess_alist): Remove decls.
4312
4313 * print.c: Make symbols static if they're not exported.
4314 (print_depth, new_backquote_output, being_printed, print_buffer):
4315 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4316 (print_interval, print_number_index, initial_stderr_stream):
4317 Now static.
4318 * lisp.h (Fprinc): Remove decl.
4319 (debug_output_compilation_hack): Mark as externally visible.
4320
4321 * sysdep.c (croak): Move decl from here to syssignal.h.
4322 * syssignal.h (croak): Put it here, so the API can be checked when
4323 'croak' is called from dissociate_if_controlling_tty.
4324
4325 * minibuf.c: Make symbols static if they're not exported.
4326 (minibuf_save_list, choose_minibuf_frame): Now static.
4327 * lisp.h (choose_minibuf_frame): Remove decl.
4328
4329 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4330
4331 * lread.c: Make symbols static if they're not exported.
4332 (read_objects, initial_obarray, oblookup_last_bucket_number):
4333 Now static.
4334 (make_symbol): Remove; unused.
4335 * lisp.h (initial_obarray, make_symbol): Remove decls.
4336
4337 * keyboard.c: Make symbols static if they're not exported.
4338 (single_kboard, recent_keys_index, total_keys, recent_keys):
4339 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4340 (this_single_command_key_start, echoing, last_auto_save):
4341 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4342 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4343 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4344 (Vlispy_mouse_stem, double_click_count):
4345 Now static.
4346 (force_auto_save_soon): Define only if SIGDANGER.
4347 (ignore_mouse_drag_p): Now static if
4348 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4349 (print_help): Remove; unused.
4350 (stop_character, last_timer_event): Mark as externally visible.
4351 * keyboard.h (ignore_mouse_drag_p): Declare only if
4352 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4353 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4354 * lisp.h (echoing): Remove decl.
4355 (force_auto_save_soon): Declare only if SIGDANGER.
4356 * xdisp.c (redisplay_window): Simplify code, to make it more
4357 obvious that ignore_mouse_drag_p is not accessed if !defined
4358 USE_GTK && !defined HAVE_NS.
4359
4360 * intervals.c: Make symbols static if they're not exported.
4361 (merge_properties_sticky, merge_interval_right, delete_interval):
4362 Now static.
4363 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4364
4365 * insdel.c: Make symbols static if they're not exported.
4366 However, leave prepare_to_modify_buffer alone. It's never
4367 called from outside this function, but that appears to be a bug.
4368 (combine_after_change_list, combine_after_change_buffer):
4369 (adjust_after_replace, signal_before_change): Now static.
4370 (adjust_after_replace_noundo): Remove; unused.
4371 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4372 (signal_before_change): Remove decls.
4373
4374 * indent.c (val_compute_motion, val_vmotion): Now static.
4375
4376 * image.c: Make symbols static if they're not exported.
4377 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4378 if USE_GTK.
4379 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4380 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4381
4382 * fringe.c (standard_bitmaps): Now static.
4383 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4384
4385 * frame.c: Make symbols static if they're not exported.
4386 (x_report_frame_params, make_terminal_frame): Now static.
4387 (get_frame_param): Now static, unless HAVE_NS.
4388 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4389 (x_get_resource_string): Remove; not used.
4390 * frame.h (make_terminal_frame, x_report_frame_params):
4391 (x_get_resource_string); Remove decls.
4392 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4393 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4394
4395 * font.c, fontset.c: Make symbols static if they're not exported.
4396 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4397 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4398 * font.c (font_close_object): Now static.
4399 * font.h (font_close_object): Remove.
4400 * fontset.c (FONTSET_OBJLIST): Remove.
4401 (free_realized_fontset) #if-0 the body, which does nothing.
4402 (face_suitable_for_char_p): #if-0, as it's never called.
4403 * fontset.h (face_suitable_for_char_p): Remove decl.
4404 * xfaces.c (face_at_string_position):
4405 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4406 since 0 is always ASCII.
4407
4408 * fns.c (weak_hash_tables): Now static.
4409
4410 * fileio.c: Make symbols static if they're not exported.
4411 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4412 (Vwrite_region_annotation_buffers): Now static.
4413
4414 * eval.c: Make symbols static if they're not exported.
4415 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4416 * lisp.h (backtrace_list): Remove decl.
4417
4418 * emacs.c: Make symbols static if they're not exported.
4419 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4420 (fatal_error_code, fatal_error_signal_hook, standard_args):
4421 Now static.
4422 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4423 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4424 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4425 * lisp.h (fatal_error_signal_hook): Remove decl.
4426 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4427
4428 * editfns.c: Move a (normally-unused) function to its only use.
4429 * editfns.c, lisp.h (get_operating_system_release): Remove.
4430 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4431 worth the hassle of breaking this out.
4432
4433 * xterm.c: Make symbols static if they're not exported.
4434 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4435 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4436 (x_destroy_window, x_delete_display):
4437 Now static.
4438 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4439 (x_mouse_leave): Remove; unused.
4440 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4441 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4442 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4443 Remove decls.
4444 (x_mouse_leave): Declare only if WINDOWSNT.
4445 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4446 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4447 USE_X_TOOLKIT.
4448
4449 * ftxfont.c: Make symbols static if they're not exported.
4450 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4451 HAVE_FREETYPE.
4452 * font.h (ftxfont_driver): Likewise.
4453
4454 * xfns.c: Make symbols static if they're not exported.
4455 (x_last_font_name, x_display_info_for_name):
4456 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4457 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4458 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4459 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4460 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4461 (last_show_tip_args): Now static.
4462 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4463 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4464 (x_screen_planes): Remove; unused.
4465 * dispextern.h (x_screen_planes): Remove decl.
4466
4467 * dispnew.c: Make symbols static if they're not exported.
4468 * dispextern.h (redraw_garbaged_frames, scrolling):
4469 (increment_row_positions): Remove.
4470 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4471 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4472 Now static.
4473 (redraw_garbaged_frames): Remove; unused.
4474
4475 * xfaces.c: Make symbols static if they're not exported.
4476 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4477 Remove decls.
4478 * xterm.h (defined_color): Remove decls.
4479 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4480 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4481 (menu_face_changed_default, defined_color, free_realized_face):
4482 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4483 (ascii_face_of_lisp_face): Remove; unused.
4484
4485 * xdisp.c: Make symbols static if they're not exported.
4486 * dispextern.h (scratch_glyph_row, window_box_edges):
4487 (glyph_to_pixel_coords, set_cursor_from_row):
4488 (get_next_display_element, set_iterator_to_next):
4489 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4490 (show_mouse_face): Remove decls
4491 * frame.h (message_buf_print): Likewise.
4492 * lisp.h (pop_message, set_message, check_point_in_composition):
4493 Likewise.
4494 * xterm.h (set_vertical_scroll_bar): Likewise.
4495 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4496 (message_buf_print, scratch_glyph_row, displayed_buffer):
4497 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4498 (get_next_display_element, show_mouse_face, window_box_edges):
4499 (frame_to_window_pixel_xy, check_point_in_composition):
4500 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4501 (glyph_to_pixel_coords): Remove; unused.
4502
4503 * dired.c (file_name_completion): Now static.
4504
4505 * dbusbind.c (xd_in_read_queued_messages): Now static.
4506
4507 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4508 * data.c (circular_list_error): Remove.
4509
4510 * commands.h (last_point_position, last_point_position_buffer):
4511 (last_point_position_window): Remove decls.
4512 * keyboard.c: Make these variables static.
4513
4514 * coding.h (coding, code_convert_region, encode_coding_gap):
4515 Remove decls.
4516 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4517 (iso_code_class, detect_coding, code_convert_region): Now static.
4518 (encode_coding_gap): Remove; unused.
4519
4520 * chartab.c (chartab_chars, chartab_bits): Now static.
4521
4522 * charset.h (charset_iso_8859_1): Remove decl.
4523 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4524 Now static.
4525
4526 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4527 * ccl.c (Vccl_program_table): Now static.
4528 (check_ccl_update): Remove; unused.
4529
4530 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4531 * category.h: ... from here.
4532 * category.c (check_category_table, set_category_set): Now static.
4533
4534 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4535 * lisp.h: Remove these decls.
4536
4537 * buffer.c (buffer_count): Remove unused var.
4538
4539 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4540 so that it's not optimized away.
4541 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4542 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4543 exported only to the debugger.
4544
4545 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4546 * atimer.h (run_all_atimers): Remove; not exported.
4547
4548 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4549 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4550 was inaccessible from Lisp.
4551 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4552 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4553
4554 alloc.c: Import and export fewer symbols, and remove unused items.
4555 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4556 is defined.
4557 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4558 it's not optimized away by whole-program optimization.
4559 (message_enable_multibyte, free_misc): Remove.
4560 (catchlist, handlerlist, mark_backtrace):
4561 Declare only if BYTE_MARK_STACK.
4562 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4563 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4564 (message_enable_multibyte): Remove decl.
4565 (free_misc, interval_free_list, float_block, float_block_index):
4566 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4567 (cons_free_list, last_marked_index):
4568 Now static.
4569 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4570 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4571 (mark_backtrace): Define only if BYTE_MARK_STACK.
4572 * xdisp.c (message_enable_multibyte): Now static.
4573
4574 Declare Lisp_Object Q* variables to be 'static' if not exported.
4575 This makes it easier for human readers (and static analyzers)
4576 to see whether these variables are used from other modules.
4577 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4578 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4579 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4580 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4581 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4582 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4583 * xmenu.c, xselect.c:
4584 Declare Q* vars static if they are not used in other modules.
4585 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4586 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4587 Remove decls of unexported vars.
4588 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4589
4590 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4591
4592 Make Emacs functions such as Fatom 'static' by default.
4593 This makes it easier for human readers (and static analyzers)
4594 to see whether these functions can be called from other modules.
4595 DEFUN now defines a static function. To make the function external
4596 so that it can be used in other C modules, use the new macro DEFUE.
4597 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4598 (Finit_image_library):
4599 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4600 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4601 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4602 Remove decls, since these functions are now static.
4603 (Funintern, Fget_internal_run_time): New decls, since these functions
4604 were already external.
4605
4606 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4607 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4608 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4609 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4610 * keyboard.c, keymap.c, lread.c:
4611 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4612 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4613 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4614 Mark functions with DEFUE instead of DEFUN,
4615 if they are used in other modules.
4616 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4617 decls for now-static functions.
4618 * buffer.h (Fdelete_overlay): Remove decl.
4619 * callproc.c (Fgetenv_internal): Mark as internal.
4620 * composite.c (Fremove_list_of_text_properties): Remove decl.
4621 (Fcomposition_get_gstring): New forward static decl.
4622 * composite.h (Fcomposite_get_gstring): Remove decl.
4623 * dired.c (Ffile_attributes): New forward static decl.
4624 * doc.c (Fdocumntation_property): New forward static decl.
4625 * eval.c (Ffetch_bytecode): New forward static decl.
4626 (Funintern): Remove extern decl; now in .h file where it belongs.
4627 * fileio.c (Fmake_symbolic_link): New forward static decl.
4628 * image.c (Finit_image_library): New forward static decl.
4629 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4630 * intervals.h (Fprevious_property_change):
4631 (Fremove_list_of_text_properties): Remove decls.
4632 * keyboard.c (Fthis_command_keys): Remove decl.
4633 (Fcommand_execute): New forward static decl.
4634 * keymap.c (Flookup_key): New forward static decl.
4635 (Fcopy_keymap): Now static.
4636 * keymap.h (Flookup_key): Remove decl.
4637 * process.c (Fget_process): New forward static decl.
4638 (Fprocess_datagram_address): Mark as internal.
4639 * syntax.c (Fsyntax_table_p): New forward static decl.
4640 (skip_chars): Remove duplicate decl.
4641 * textprop.c (Fprevious_property_change): New forward static decl.
4642 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4643 Now internal.
4644 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4645 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4646
4647 * editfns.c (Fformat): Remove unreachable code.
4648
4649 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4650
4651 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4652 change. (Bug#8496)
4653
4654 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4655
4656 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4657 when at ZV. (Bug#8487)
4658
4659 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4660
4661 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4662 (Bug#8437)
4663 * keyboard.c (parse_tool_bar_item): Likewise.
4664 * sound.c (sound_cleanup, alsa_close): Likewise.
4665 * termcap.c (tgetent): Likewise.
4666 * xfns.c (x_default_font_parameter): Likewise.
4667 * xsettings.c (read_and_apply_settings): Likewise.
4668
4669 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4670 (overrun_check_free): Protoize.
4671
4672 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4673
4674 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4675 since callers should never pass a negative size.
4676 Change the signature to match that of plain 'read' and 'write'; see
4677 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4678 * lisp.h: Update prototypes of emacs_write and emacs_read.
4679
4680 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4681
4682 * xdisp.c (redisplay_window): Don't try to determine the character
4683 position of the scroll margin if the window start point w->startp
4684 is outside the buffer's accessible region. (Bug#8468)
4685
4686 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4687
4688 Fix write-region and its subroutines for buffers > 2GB.
4689 * fileio.c (a_write, e_write): Modify declaration of arguments and
4690 local variables to support buffers larger than 2GB.
4691 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4692
4693 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4694 argument, local variables, and return value.
4695
4696 * lisp.h: Update prototypes of emacs_write and emacs_read.
4697
4698 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4699
4700 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4701
4702 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4703
4704 Fix more problems found by GCC 4.6.0's static checks.
4705
4706 * xdisp.c (vmessage): Use a better test for character truncation.
4707
4708 * charset.c (load_charset_map): <, not <=, for optimization,
4709 and to avoid potential problems with integer overflow.
4710 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4711 * casetab.c (set_identity, shuffle): Likewise.
4712 * editfns.c (Fformat): Likewise.
4713 * syntax.c (skip_chars): Likewise.
4714
4715 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4716 This also lets GCC 4.6.0 generate slightly better loop code.
4717
4718 * callint.c (Fcall_interactively): <, not <=, for optimization.
4719 (Fcall_interactively): Count the number of arguments produced,
4720 not the number of arguments given. This is simpler and lets GCC
4721 4.6.0 generate slightly better code.
4722
4723 * ftfont.c: Distingish more carefully between FcChar8 and char.
4724 The previous code passed unsigned char * to a functions like
4725 strlen and xstrcasecmp that expect char *, which does not
4726 conform to the C standard.
4727 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4728 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4729 char * when the C standard requires it.
4730
4731 * keyboard.c (read_char): Remove unused var.
4732
4733 * eval.c: Port to Windows vsnprintf (Bug#8435).
4734 Include <limits.h>.
4735 (SIZE_MAX): Define if the headers do not.
4736 (verror): Do not give up if vsnprintf returns a negative count.
4737 Instead, grow the buffer. This ports to Windows vsnprintf, which
4738 does not conform to C99. Problem reported by Eli Zaretskii.
4739 Also, simplify the allocation scheme, by avoiding the need for
4740 calling realloc, and removing the ALLOCATED variable.
4741
4742 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4743
4744 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4745 But keep the doprint source code for now, as we might revamp it
4746 and use it again (Bug#8435).
4747 * lisp.h (doprnt): Remove.
4748 * Makefile.in (base_obj): Remove doprnt.o.
4749 * deps.mk (doprnt.o): Remove.
4750
4751 error: Print 32- and 64-bit integers portably (Bug#8435).
4752 Without this change, on typical 64-bit hosts error ("...%d...", N)
4753 was used to print both 32- and 64-bit integers N, which relied on
4754 undefined behavior.
4755 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4756 New macro.
4757 * lisp.h (error, verror): Mark as printf-like functions.
4758 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4759 Report overflow in size calculations when allocating printf buffer.
4760 Do not truncate output string at its first null byte.
4761 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4762 Truncate the output at a character boundary, since vsnprintf does not
4763 do that.
4764 * charset.c (check_iso_charset_parameter): Convert internal
4765 character to string before calling 'error', since %c now has the
4766 printf meaning.
4767 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4768 overflow when computing char to be passed to 'error'. Do not
4769 pass Lisp_Object to 'error'; pass the integer instead.
4770 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4771 formatted with plain %d.
4772
4773 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4774
4775 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4776
4777 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4778
4779 * xterm.c (x_catch_errors): Remove duplicate declaration.
4780
4781 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4782
4783 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4784
4785 2011-04-10 Jim Meyering <meyering@redhat.com>
4786
4787 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4788 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4789 return ssize_t not "int", and use size_t as the buffer length.
4790 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4791 * gnutls.h: Update declarations.
4792 * process.c (read_process_output): Use ssize_t, to match.
4793 (send_process): Likewise.
4794
4795 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4796
4797 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4798
4799 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4800
4801 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4802 Use unsigned char, to match FcChar8 type definition.
4803
4804 * xterm.c (handle_one_xevent):
4805 * xmenu.c (create_and_show_popup_menu):
4806 * xselect.c (x_decline_selection_request)
4807 (x_reply_selection_request): Avoid type-punned deref of X events.
4808
4809 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4810
4811 Fix some uses of `int' instead of EMACS_INT.
4812 * search.c (string_match_1, fast_string_match)
4813 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4814 (scan_buffer, find_next_newline_no_quit)
4815 (find_before_next_newline, search_command, Freplace_match)
4816 (Fmatch_data): Make some `int' variables be EMACS_INT.
4817
4818 * xdisp.c (display_count_lines): 3rd argument and return value now
4819 EMACS_INT. All callers changed.
4820 (pint2hrstr): Last argument is now EMACS_INT.
4821
4822 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4823 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4824 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4825 (decode_coding_utf_16, decode_coding_emacs_mule)
4826 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4827 (decode_coding_ccl, decode_coding_charset)
4828 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4829 (decode_coding_iso_2022, decode_coding_emacs_mule)
4830 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4831 <char_offset, last_offset>: Declare EMACS_INT.
4832 (encode_coding_utf_8, encode_coding_utf_16)
4833 (encode_coding_emacs_mule, encode_invocation_designation)
4834 (encode_designation_at_bol, encode_coding_iso_2022)
4835 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4836 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4837 Declare EMACS_INT.
4838 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4839 (encode_invocation_designation): Last argument P_NCHARS is now
4840 EMACS_INT.
4841 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4842 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4843
4844 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4845 All users changed.
4846
4847 * ccl.c (Fccl_execute_on_string): Declare some variables
4848 EMACS_INT.
4849
4850 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4851
4852 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4853
4854 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4855
4856 * process.c (Fformat_network_address): Doc fix.
4857
4858 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4859
4860 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4861
4862 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4863
4864 * keyboard.c (read_char): Call Lisp function help-form-show,
4865 instead of using internal_with_output_to_temp_buffer.
4866 (Qhelp_form_show): New var.
4867 (syms_of_keyboard): Use DEFSYM macro.
4868
4869 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4870
4871 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4872
4873 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4874
4875 * process.c (Flist_processes): Remove to Lisp.
4876 (list_processes_1): Delete.
4877
4878 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4879
4880 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4881
4882 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4883
4884 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4885
4886 Fix more problems found by GCC 4.6.0's static checks.
4887
4888 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4889
4890 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4891
4892 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4893
4894 * xdisp.c (vmessage): Mark as a printf-like function.
4895
4896 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4897
4898 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4899
4900 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4901 printf-like functions.
4902 (tiff_load): Add casts to remove these marks before passing them
4903 to system-supplied API.
4904
4905 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4906
4907 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4908 This avoids several warnings with gcc -Wstrict-overflow.
4909 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4910 directly, rather than having caller test rule sign. This avoids
4911 some unnecessary tests.
4912 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4913 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4914 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4915
4916 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4917 (xfont_open): Avoid unnecessary tests.
4918
4919 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4920
4921 * composite.h, composite.c (composition_gstring_put_cache):
4922 Use EMACS_INT, not int, for length.
4923
4924 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4925 breaking out part of COMPOSITION_DECODE_RULE.
4926 (COMPOSITION_DECODE_RULE): Use it.
4927 * composite.c (get_composition_id): Remove unused local vars,
4928 by using the new macro.
4929
4930 * textprop.c (set_text_properties_1): Change while to do-while,
4931 since the condition is always true at first.
4932
4933 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4934 (interval_deletion_adjustment): Return unsigned value.
4935 All uses changed.
4936
4937 * process.c (list_processes_1, create_pty, read_process_output):
4938 (exec_sentinel): Remove vars that were set but not used.
4939 (create_pty): Remove unnecessary "volatile"s.
4940 (Fnetwork_interface_info): Avoid possibility of int overflow.
4941 (read_process_output): Do adaptive read buffering even if carryover.
4942 (read_process_output): Simplify nbytes computation if buffered.
4943
4944 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4945
4946 * syntax.c (scan_words): Remove var that was set but not used.
4947 (update_syntax_table): Use unsigned instead of int.
4948
4949 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4950 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4951 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4952
4953 * print.c (print_error_message): Avoid int overflow.
4954
4955 * font.c (font_list_entities): Redo for clarity,
4956 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4957
4958 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4959 (font_score): Avoid potential overflow in diff calculation.
4960
4961 * fns.c (substring_both): Remove var that is set but not used.
4962 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4963
4964 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4965
4966 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4967 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4968 can always succeed if overflow has undefined behavior.
4969
4970 * search.c (boyer_moore, wordify): Remove vars set but not used.
4971 (wordify): Omit three unnecessary tests.
4972
4973 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4974 All callers changed. This avoids the need for an unused var.
4975
4976 * casefiddle.c (casify_region): Remove var that is set but not used.
4977
4978 * dired.c (file_name_completion): Remove var that is set but not used.
4979
4980 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4981
4982 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4983 (Finsert_file_contents): Remove unnecessary code checking fd.
4984
4985 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4986 Check for integer overflow on size calculations.
4987
4988 * buffer.c (Fprevious_overlay_change): Remove var that is set
4989 but not used.
4990
4991 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4992 Remove vars that are set but not used.
4993 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4994 (timer_check_2): Mark vars as initialized.
4995
4996 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4997
4998 * image.c (lookup_image): Remove var that is set but not used.
4999 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5000
5001 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5002 that are set but not used.
5003
5004 * xfns.c (make_invisible_cursor): Don't return garbage
5005 if XCreateBitmapFromData fails (Bug#8410).
5006
5007 * xselect.c (x_get_local_selection, x_handle_property_notify):
5008 Remove vars that are set but not used.
5009
5010 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5011 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5012
5013 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5014 Remove var that is set but not used.
5015 (scroll_bar_windows_size): Now size_t, not int.
5016 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5017 Check for overflow.
5018
5019 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5020 (map_tty_color) [!defined MSDOS]: Likewise.
5021
5022 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5023
5024 * coding.c: Remove vars that are set but not used.
5025 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5026 All callers changed.
5027 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5028 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5029 (decode_coding_charset): Remove vars that are set but not used.
5030
5031 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5032 that is set but not used.
5033
5034 * print.c (print_object): Remove var that is set but not used.
5035
5036 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5037 The gnulib version avoids calling malloc in the usual case,
5038 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5039 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5040 * filelock.c (current_lock_owner): Likewise.
5041 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5042 * sysdep.c: Include allocator.h, careadlinkat.h.
5043 (emacs_no_realloc_allocator): New static constant.
5044 (emacs_readlink): New function.
5045 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5046 ../lib/careadlinkat.h.
5047
5048 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5049
5050 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5051 first non-nil return value).
5052
5053 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5054
5055 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5056 if not defined (Bug#8403).
5057
5058 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5059
5060 * xdisp.c (display_count_lines): Remove parameter `start',
5061 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5062 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5063 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5064 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5065 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5066 and thereabouts. All callers changed.
5067 (get_per_char_metric): Remove parameter `f', unused since
5068 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5069
5070 2011-04-02 Jim Meyering <meyering@redhat.com>
5071
5072 do not dereference NULL upon failed strdup
5073 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5074 (ns_get_family): Likewise.
5075
5076 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5077
5078 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5079
5080 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5081
5082 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5083 later (Bug#8403).
5084
5085 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5086
5087 Add lexical binding.
5088
5089 * window.c (Ftemp_output_buffer_show): New fun.
5090 (Fsave_window_excursion):
5091 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5092
5093 * lread.c (lisp_file_lexically_bound_p): New function.
5094 (Fload): Bind Qlexical_binding.
5095 (readevalloop): Remove `evalfun' arg.
5096 Bind Qinternal_interpreter_environment.
5097 (Feval_buffer): Bind Qlexical_binding.
5098 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5099 Mark as dynamic.
5100 (syms_of_lread): Declare `lexical-binding'.
5101
5102 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5103
5104 * keyboard.c (eval_dyn): New fun.
5105 (menu_item_eval_property): Use it.
5106
5107 * image.c (parse_image_spec): Use Ffunctionp.
5108
5109 * fns.c (concat, mapcar1): Accept byte-code-functions.
5110
5111 * eval.c (Fsetq): Handle lexical vars.
5112 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5113 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5114 (FletX, Flet): Obey lexical binding.
5115 (Fcommandp): Handle closures.
5116 (Feval): New `lexical' arg.
5117 (eval_sub): New function extracted from Feval. Use it almost
5118 everywhere where Feval was used. Look up vars in lexical env.
5119 Handle closures.
5120 (Ffunctionp): Move from subr.el.
5121 (Ffuncall): Handle closures.
5122 (apply_lambda): Remove `eval_flags'.
5123 (funcall_lambda): Handle closures and new byte-code-functions.
5124 (Fspecial_variable_p): New function.
5125 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5126 but without exporting it to Lisp.
5127
5128 * doc.c (Fdocumentation, store_function_docstring):
5129 * data.c (Finteractive_form): Handle closures.
5130
5131 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5132 interactive spec.
5133
5134 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5135 New byte-codes.
5136 (exec_byte_code): New function extracted from Fbyte_code to handle new
5137 calling convention for byte-code-functions. Add new byte-codes.
5138
5139 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5140
5141 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5142
5143 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5144
5145 * xdisp.c (redisplay_internal): Fix prototype.
5146
5147 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5148
5149 * xdisp.c (SCROLL_LIMIT): New macro.
5150 (try_scrolling): Use it when setting scroll_limit.
5151 Limit scrolling to 100 screen lines.
5152 (redisplay_window): Even when falling back on "recentering",
5153 position point in the window according to scroll-conservatively,
5154 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5155
5156 (try_scrolling): When point is above the window, allow searching
5157 as far as scroll_max, or one screenful, to compute vertical
5158 distance from PT to the scroll margin position. This prevents
5159 try_scrolling from unnecessarily failing when
5160 scroll-conservatively is set to a value slightly larger than the
5161 window height. Clean up the case of PT below the margin at bottom
5162 of window: scroll_max can no longer be INT_MAX. When aggressive
5163 scrolling is in use, don't let point enter the opposite scroll
5164 margin as result of the scroll.
5165 (syms_of_xdisp) <scroll-conservatively>: Document the
5166 threshold of 100 lines for never-recentering scrolling.
5167
5168 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * dispextern.h (move_it_by_lines):
5171 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5172 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5173 (message_log_check_duplicate): Remove parameters `prev_bol' and
5174 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5175 (redisplay_internal): Remove parameter `preserve_echo_area',
5176 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5177
5178 * indent.c (Fvertical_motion):
5179 * window.c (window_scroll_pixel_based, Frecenter):
5180 Don't pass `need_y_p' to `move_it_by_lines'.
5181
5182 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5183
5184 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5185 steal a few bits to be more compact.
5186 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5187 Remove unneeded casts.
5188
5189 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5190
5191 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5192
5193 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5194 binding" message (bug#7967).
5195
5196 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5197
5198 Fix more problems found by GCC 4.6.0's static checks.
5199
5200 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5201 Remove unused local var.
5202
5203 * editfns.c (Fmessage_box): Remove unused local var.
5204
5205 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5206 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5207 Omit unused local vars.
5208 * window.c (shrink_windows): Omit unused local var.
5209 * menu.c (digest_single_submenu): Omit unused local var.
5210 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5211 Omit unused local var.
5212
5213 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5214 Don't assume string length fits in int.
5215 (keyremap_step, read_key_sequence): Use size_t for sizes.
5216 (read_key_sequence): Don't check last_real_key_start redundantly.
5217
5218 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5219 instead of alloca (Bug#8344).
5220
5221 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5222 (Fbacktrace_frame): Don't assume nframes fits in int.
5223
5224 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5225
5226 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5227 concerns.
5228
5229 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5230
5231 * cm.c (calccost): Turn while-do into do-while, for clarity.
5232
5233 * keyboard.c (syms_of_keyboard): Use the same style as later
5234 in this function when indexing through an array. This also
5235 works around GCC bug 48267.
5236
5237 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5238
5239 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5240
5241 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5242 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5243
5244 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5245 This avoids undefined behavior on integer overflow, and is a bit
5246 more convenient anyway since it is compared to a size_t variable.
5247
5248 Variadic C functions now count arguments with size_t, not int.
5249 This avoids an unnecessary limitation on 64-bit machines, which
5250 caused (substring ...) to crash on large vectors (Bug#8344).
5251 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5252 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5253 All variadic functions and their callers changed accordingly.
5254 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5255 * data.c (arith_driver, float_arith_driver): Likewise.
5256 * editfns.c (general_insert_function): Likewise.
5257 * eval.c (struct backtrace.nargs, interactive_p)
5258 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5259 (funcall_lambda, mark_backtrace): Likewise.
5260 * fns.c (concat): Likewise.
5261 * frame.c (x_set_frame_parameters): Likewise.
5262 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5263 0 if not found, not -1. All callers changed.
5264
5265 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5266 (stack_copy_size): Now size_t, not int.
5267 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5268
5269 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5270
5271 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5272 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5273 All callers changed.
5274
5275 * lisp.h (multibyte_char_to_unibyte):
5276 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5277 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5278 * character.h (CHAR_TO_BYTE8):
5279 * cmds.c (internal_self_insert):
5280 * editfns.c (general_insert_function):
5281 * keymap.c (push_key_description):
5282 * search.c (Freplace_match):
5283 * xdisp.c (message_dolog, set_message_1): All callers changed.
5284
5285 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5286
5287 * keyboard.c (safe_run_hook_funcall): New function.
5288 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5289 don't set the hook to nil, but remove the offending function instead.
5290 (Qcommand_hook_internal): Remove, unused.
5291 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5292 Vcommand_hook_internal.
5293
5294 * eval.c (enum run_hooks_condition): Remove.
5295 (funcall_nil, funcall_not): New functions.
5296 (run_hook_with_args): Call each function through a `funcall' argument.
5297 Remove `cond' argument, now redundant.
5298 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5299 (Frun_hook_with_args_until_failure): Adjust accordingly.
5300 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5301
5302 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5303
5304 * dispextern.h (string_buffer_position): Remove declaration.
5305
5306 * print.c (strout): Remove parameter `multibyte', unused since
5307 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5308
5309 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5310 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5311 All callers changed.
5312
5313 * w32.c (_wsa_errlist): Use braces for struct initializers.
5314
5315 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5316 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5317 All callers changed.
5318 (string_buffer_position): Likewise. Also, make static (it's never
5319 used outside xdisp.c).
5320 (cursor_row_p): Remove parameter `w', unused since
5321 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5322 (decode_mode_spec): Remove parameter `precision', introduced during
5323 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5324 All callers changed.
5325
5326 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5327
5328 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5329
5330 2011-03-27 Anders Lindgren <andlind@gmail.com>
5331
5332 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5333 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5334 (ns_update_auto_hide_menu_bar): New functions.
5335 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5336 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5337 ns_constrain_all_frames.
5338 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5339 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5340
5341 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5342
5343 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5344
5345 2011-03-27 Glenn Morris <rgm@gnu.org>
5346
5347 * syssignal.h: Replace RETSIGTYPE with void.
5348 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5349 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5350 Replace SIGTYPE with void everywhere.
5351 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5352 * s/template.h (SIGTYPE): Remove commented out definition.
5353
5354 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5355
5356 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5357 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5358
5359 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5360
5361 * w32.c (read_unc_volume): Use parameter `henum', instead of
5362 global variable `wget_enum_handle'.
5363
5364 * keymap.c (describe_vector): Remove parameters `indices' and
5365 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5366 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5367
5368 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5369
5370 * keyboard.c (timer_check): Remove parameter `do_it_now',
5371 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5372 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5373 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5374
5375 * keyboard.c (read_char):
5376 * w32menu.c (w32_menu_display_help):
5377 * xmenu.c (show_help_event, menu_help_callback):
5378 Adjust calls to `show_help_echo'.
5379
5380 * gtkutil.c (xg_maybe_add_timer):
5381 * keyboard.c (readable_events):
5382 * process.c (wait_reading_process_output):
5383 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5384
5385 * insdel.c (adjust_markers_gap_motion):
5386 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5387 (gap_left, gap_right): Don't call it.
5388
5389 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5390
5391 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5392 incurred during fontification.
5393
5394 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5395
5396 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5397 (DEFVAR_PER_BUFFER): Don't pass it.
5398
5399 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5400 (scrolling_window): Don't pass it.
5401
5402 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5403
5404 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5405
5406 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5407 and `suffix'.
5408 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5409 of variables specific to SELinux and computation of `encoded_absname'.
5410
5411 * image.c (XPutPixel): Remove unused variable `height'.
5412
5413 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5414
5415 * unexw32.c (get_section_info): Remove unused variable `section'.
5416
5417 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5418 (system_process_attributes): Remove unused variable `sess'.
5419 (sys_read): Remove unused variable `err'.
5420
5421 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5422 (w32_wnd_proc): Remove unused variable `isdead'.
5423 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5424 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5425 (x_create_tip_frame): Remove unused variable `tem'.
5426
5427 * w32inevt.c (w32_console_read_socket):
5428 Remove unused variable `no_events'.
5429
5430 * w32term.c (x_draw_composite_glyph_string_foreground):
5431 Remove unused variable `width'.
5432
5433 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5434
5435 * w32term.c (x_set_glyph_string_clipping):
5436 Don't pass uninitialized region to CombineRgn.
5437
5438 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5439
5440 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5441 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5442 (Fx_close_connection): Remove unused variable `i'.
5443
5444 * w32font.c (w32font_draw): Return number of glyphs.
5445 (w32font_open_internal): Remove unused variable `i'.
5446 (w32font_driver): Add missing initializer.
5447
5448 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5449 (fill_in_menu): Remove unused variable `items_added'.
5450
5451 * w32term.c (last_mouse_press_frame): Remove static global variable.
5452 (w32_clip_to_row): Remove unused variable `f'.
5453 (x_delete_terminal): Remove unused variable `i'.
5454
5455 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5456 (NOTHING): Remove unused static global variable.
5457 (uniscribe_check_otf): Remove unused variable `table'.
5458 (uniscribe_font_driver): Add missing initializers.
5459
5460 2011-03-23 Julien Danjou <julien@danjou.info>
5461
5462 * term.c (Fsuspend_tty, Fresume_tty):
5463 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5464 * window.c (temp_output_buffer_show):
5465 * insdel.c (signal_before_change):
5466 * frame.c (Fhandle_switch_frame):
5467 * fileio.c (Fdo_auto_save):
5468 * emacs.c (Fkill_emacs):
5469 * editfns.c (save_excursion_restore):
5470 * cmds.c (internal_self_insert):
5471 * callint.c (Fcall_interactively):
5472 * buffer.c (Fkill_all_local_variables):
5473 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5474 Use Frun_hooks.
5475 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5476 unconditionnaly since it does the check itself.
5477
5478 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5479
5480 Fix more problems found by GCC 4.5.2's static checks.
5481
5482 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5483 the first time through the loop, since we know p0 < p1 then.
5484 This also avoids a gcc -Wstrict-overflow warning.
5485
5486 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5487 leading to a memory leak, possible in functions like
5488 load_charset_map_from_file that can allocate an unbounded number
5489 of objects (Bug#8318).
5490
5491 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5492 that could (at least in theory) be that large.
5493
5494 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5495 This is less likely to overflow, and avoids undefined behavior if
5496 overflow does occur. All callers changed. Use strtoul to scan
5497 for the unsigned long integer.
5498 (pint2hrstr): Simplify and tune code slightly.
5499 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5500
5501 * scroll.c (do_scrolling): Work around GCC bug 48228.
5502 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5503
5504 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5505 This also avoids a warning with gcc -Wstrict-overflow.
5506 (validate_x_resource_name): Simplify count usage.
5507 This also avoids a warning with gcc -Wstrict-overflow.
5508
5509 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5510 fail (Bug#8306).
5511
5512 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5513
5514 * process.c (Fmake_network_process): Use socklen_t, not int,
5515 where POSIX says socklen_t is required in portable programs.
5516 This fixes a porting bug on hosts like 64-bit HP-UX, where
5517 socklen_t is wider than int (Bug#8277).
5518 (Fmake_network_process, server_accept_connection):
5519 (wait_reading_process_output, read_process_output):
5520 Likewise.
5521
5522 * process.c: Rename or move locals to avoid shadowing.
5523 (list_processes_1, Fmake_network_process):
5524 (read_process_output_error_handler, exec_sentinel_error_handler):
5525 Rename or move locals.
5526 (Fmake_network_process): Define label "retry_connect" only if needed.
5527 (Fnetwork_interface_info): Fix pointer signedness.
5528 (process_send_signal): Add cast to avoid pointer signedness problem.
5529 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5530 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5531
5532 Make tparam.h and terminfo.c consistent.
5533 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5534 Include tparam.h instead, since it declares them.
5535 * cm.h (PC): Remove extern decl; tparam.h now does this.
5536 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5537 * terminfo.c: Include tparam.h, to check interfaces.
5538 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5539 (tparam): Adjust signature to match interface in tparam.h;
5540 this removes some undefined behavior. Check that outstring and len
5541 are zero, which they always are with Emacs.
5542 * tparam.h (PC, BC, UP): New extern decls.
5543
5544 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5545 (xftfont_open): Rename locals to avoid shadowing.
5546
5547 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5548 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5549 (OTF_TAG_SYM): Omit macro if not needed.
5550 (ftfont_list): Remove unused local.
5551 (get_adstyle_property, ftfont_pattern_entity):
5552 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5553 Rename locals to avoid shadowing.
5554
5555 * xfont.c (xfont_list_family): Mark var as initialized.
5556
5557 * xml.c (make_dom): Now static.
5558
5559 * composite.c (composition_compute_stop_pos): Rename local to
5560 avoid shadowing.
5561 (composition_reseat_it): Remove unused locals.
5562 (find_automatic_composition, composition_adjust_point): Likewise.
5563 (composition_update_it): Mark var as initialized.
5564 (find_automatic_composition): Mark vars as initialized,
5565 with a FIXME (Bug#8290).
5566
5567 character.h: Rename locals to avoid shadowing.
5568 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5569 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5570 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5571 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5572 to avoid shadowing.
5573
5574 * textprop.c (property_change_between_p): Remove; unused.
5575
5576 * intervals.c (interval_start_pos): Now static.
5577
5578 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5579
5580 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5581 Rename locals to avoid shadowing.
5582
5583 * sound.c (wav_play, au_play, Fplay_sound_internal):
5584 Fix pointer signedness.
5585 (alsa_choose_format): Remove unused local var.
5586 (wav_play): Initialize a variable to 0, to prevent undefined
5587 behavior (Bug#8278).
5588
5589 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5590
5591 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5592
5593 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5594 clobbering (Bug#8298).
5595 * sysdep.c (sys_subshell): Likewise.
5596 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5597
5598 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5599 This should get cleaned up, so that child_setup has the
5600 same signature on all platforms.
5601
5602 * callproc.c (call_process_cleanup): Now static.
5603 (relocate_fd): Rename locals to avoid shadowing.
5604
5605 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5606
5607 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5608 not to be necessary, and produces flickering.
5609
5610 2011-03-20 Glenn Morris <rgm@gnu.org>
5611
5612 * config.in: Remove file.
5613
5614 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5615
5616 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5617 are now in src/globals.h.
5618 (syms_of_minibuf): Remove spurious & from previous change.
5619
5620 2011-03-20 Leo <sdl.web@gmail.com>
5621
5622 * minibuf.c (completing-read-function): New variable.
5623 (completing-read-default): Rename from completing-read.
5624 (completing-read): Call completing-read-function.
5625
5626 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5627
5628 * xfaces.c (Fx_load_color_file):
5629 Read color file from absolute filename (bug#8250).
5630
5631 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5632
5633 * makefile.w32-in: Update dependencies.
5634
5635 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5636
5637 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5638
5639 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5640
5641 Fix more problems found by GCC 4.5.2's static checks.
5642
5643 * process.c (make_serial_process_unwind, send_process_trap):
5644 (sigchld_handler): Now static.
5645
5646 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5647 That way, the code declares only the vars that it needs.
5648 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5649 * s/cygwin.h (PTY_ITERATION): Likewise.
5650 * s/darwin.h (PTY_ITERATION): Likewise.
5651 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5652
5653 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5654 * process.c (allocate_pty): Don't declare stb unless it's needed.
5655
5656 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5657 (CONSTANTLIM): Remove; unused.
5658 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5659 Define only if needed.
5660
5661 * unexelf.c (unexec): Name an expression,
5662 to avoid gcc -Wbad-function-cast warning.
5663 Use a different way to cause a compilation error if anyone uses
5664 n rather than nn, a way that does not involve shadowing.
5665 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5666
5667 * deps.mk (unexalpha.o): Remove; unused.
5668
5669 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5670 * unexec.h: New file.
5671 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5672 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5673 Depend on unexec.h.
5674 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5675 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5676 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5677 Change as necessary to match prototype in unexec.h.
5678
5679 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5680 shadowing.
5681 (back_comment, skip_chars): Mark vars as initialized.
5682
5683 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5684 Rename locals to avoid shadowing.
5685
5686 * lread.c (read1): Rewrite so as not to use empty "else".
5687 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5688
5689 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5690
5691 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5692 warning when compiling print.c.
5693
5694 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5695 instead of using an uninitialized var.
5696 (font_sort_entities): Mark var as initialized.
5697
5698 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5699
5700 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5701 pointers to constants.
5702 (font_parse_fcname): Remove unused vars.
5703 (font_delete_unmatched): Now static.
5704 (font_get_spec): Remove; unused.
5705 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5706 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5707 Rename or move locals to avoid shadowing.
5708
5709 * fns.c (require_nesting_list, require_unwind): Now static.
5710 (Ffillarray): Rename locals to avoid shadowing.
5711
5712 * floatfns.c (domain_error2): Define only if needed.
5713 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5714
5715 * alloc.c (mark_backtrace): Move decl from here ...
5716 * lisp.h: ... to here, so that it can be checked.
5717
5718 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5719 (Fdefvar): Rewrite so as not to use empty "else".
5720 (lisp_indirect_variable): Name an expression,
5721 to avoid gcc -Wbad-function-cast warning.
5722 (Fdefvar): Rename locals to avoid shadowing.
5723
5724 * callint.c (quotify_arg, quotify_args): Now static.
5725 (Fcall_interactively): Rename locals to avoid shadowing.
5726 Use const pointer when appropriate.
5727
5728 * lisp.h (get_system_name, get_operating_system_release):
5729 Move decls here, to check interfaces.
5730 * process.c (get_operating_system_release): Move decl to lisp.h.
5731 * xrdb.c (get_system_name): Likewise.
5732 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5733 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5734 some of which prompt warnings from gcc -Wbad-function-cast.
5735 (Fformat_time_string, Fencode_time, Finsert_char):
5736 (Ftranslate_region_internal, Fformat):
5737 Rename or remove local vars to avoid shadowing.
5738 (Ftranslate_region_internal): Mark var as initialized.
5739
5740 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5741 avoid shadowing.
5742
5743 * lisp.h (eassert): Check that the argument compiles, even if
5744 ENABLE_CHECKING is not defined.
5745
5746 * data.c (Findirect_variable): Name an expression, to avoid
5747 gcc -Wbad-function-cast warning.
5748 (default_value, arithcompare, arith_driver, arith_error): Now static.
5749 (store_symval_forwarding): Rename local to avoid shadowing.
5750 (Fmake_variable_buffer_local, Fmake_local_variable):
5751 Mark variables as initialized.
5752 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5753
5754 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5755 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5756 Rename locals to avoid shadowing.
5757 (mark_stack): Move local variables into the #ifdef region where
5758 they're used.
5759 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5760 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5761 needed otherwise.
5762 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5763 (GC_STRING_CHARS): Remove; not used.
5764 (Fmemory_limit): Cast sbrk's returned value to char *.
5765
5766 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5767 avoids undefined behavior in theory.
5768
5769 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5770
5771 Use functions, not macros, for up- and down-casing (Bug#8254).
5772 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5773 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5774 to use the following functions instead of these macros.
5775 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5776 EMACS_INT, since callers assume the returned value fits in int.
5777 (upcase1): Likewise, for UPCASE_TABLE.
5778 (uppercasep, lowercasep, upcase): New static inline functions.
5779 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5780 the race-condition problem in the old DOWNCASE.
5781
5782 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5783 Rename locals to avoid shadowing.
5784 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5785 (regex_compile, re_search_2, re_match_2_internal):
5786 Remove unused local vars.
5787 (FREE_VAR): Rewrite so as not to use empty "else",
5788 which gcc can warn about.
5789 (regex_compile, re_match_2_internal): Mark locals as initialized.
5790 (RETALLOC_IF): Define only if needed.
5791 (WORDCHAR_P): Likewise. This one is never needed, but is used
5792 only in a comment talking about a compiler bug, so put inside
5793 the #if 0 of that comment.
5794 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5795 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5796 Remove; unused.
5797
5798 * search.c (boyer_moore): Rename locals to avoid shadowing.
5799 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5800 (PREV_CHAR_BOUNDARY): Likewise.
5801
5802 * search.c (simple_search): Remove unused var.
5803
5804 * dired.c (compile_pattern): Move decl from here ...
5805 * lisp.h: ... to here, so that it can be checked.
5806 (struct re_registers): New forward decl.
5807
5808 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5809
5810 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5811 All uses changed.
5812 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5813 Rename locals to avoid shadowing.
5814 (Fvertical_motion): Mark locals as initialized.
5815
5816 * casefiddle.c (casify_object, casify_region): Now static.
5817 (casify_region): Mark local as initialized.
5818
5819 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5820
5821 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5822 New macros, so that the caller can use some names other than
5823 gcpro1, gcpro2, etc.
5824 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5825 of the new macros.
5826 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5827 argument, for consistency with GCPRO2_VAR, etc: it is now the
5828 prefix of the variable, not the variable itself. All uses
5829 changed.
5830 * dired.c (directory_files_internal, file_name_completion):
5831 Rename locals to avoid shadowing.
5832
5833 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5834 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5835 dired.c's scmp function, had undefined behavior.
5836 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5837 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5838 * buffer.h: ... to here, because these macros use current_buffer,
5839 and the new implementation with inline functions needs to have
5840 current_buffer in scope now, rather than later when the macros
5841 are used.
5842 (downcase, upcase1): New static inline functions.
5843 (DOWNCASE, UPCASE1): Reimplement using these functions.
5844 This avoids undefined behavior in expressions like
5845 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5846 from race conditions in accessing the global variables
5847 case_temp1 and case_temp2.
5848 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5849 * lisp.h (case_temp1, case_temp2): Remove their decls.
5850 * character.h (ASCII_CHAR_P): Move from here ...
5851 * lisp.h: ... to here, so that the inline functions mentioned
5852 above can use them.
5853
5854 * dired.c (directory_files_internal_unwind): Now static.
5855
5856 * fileio.c (file_name_as_directory, directory_file_name):
5857 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5858 Now static.
5859 (file_name_as_directory): Use const pointers when appropriate.
5860 (Fexpand_file_name): Likewise. In particular, newdir might
5861 point at constant storage, so make it a const pointer.
5862 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5863 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5864 signedness issues.
5865 (Fset_file_times, Finsert_file_contents, auto_save_error):
5866 Rename locals to avoid shadowing.
5867
5868 * minibuf.c (choose_minibuf_frame_1): Now static.
5869 (Ftry_completion, Fall_completions): Rename or remove locals
5870 to avoid shadowing.
5871
5872 * marker.c (bytepos_to_charpos): Remove; unused.
5873
5874 * lisp.h (verify_bytepos, count_markers): New decls,
5875 so that gcc does not warn that these functions aren't declared.
5876
5877 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5878 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5879 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5880 (copy_text): Remove unused local var.
5881
5882 * filelock.c (within_one_second): Now static.
5883 (lock_file_1): Rename local to avoid shadowing.
5884
5885 * buffer.c (fix_overlays_before): Mark locals as initialized.
5886 (fix_start_end_in_overlays): Likewise. This function should be
5887 simplified by using pointers-to-pointers, but that's a different
5888 matter.
5889 (switch_to_buffer_1): Now static.
5890 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5891 (report_overlay_modification): Rename locals to avoid shadowing.
5892
5893 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5894 Fix pointer signedness issue.
5895 (sys_subshell): Mark local as volatile if checking for lint,
5896 to suppress a gcc -Wclobbered warning that does not seem to be right.
5897 (MAXPATHLEN): Define only if needed.
5898
5899 * process.c (serial_open, serial_configure): Move decls from here ...
5900 * systty.h: ... to here, so that they can be checked.
5901
5902 * fns.c (get_random, seed_random): Move extern decls from here ...
5903 * lisp.h: ... to here, so that they can be checked.
5904
5905 * sysdep.c (reset_io): Now static.
5906 (wait_for_termination_signal): Remove; unused.
5907
5908 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5909 (copy_keymap_item, append_key, push_text_char_description):
5910 Now static.
5911 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5912 (DENSE_TABLE_SIZE): Remove; unused.
5913 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5914 (describe_map_tree):
5915 Rename locals to avoid shadowing.
5916
5917 * keyboard.c: Declare functions static if they are not used elsewhere.
5918 (echo_char, echo_dash, cmd_error, top_level_2):
5919 (poll_for_input, handle_async_input): Now static.
5920 (read_char, kbd_buffer_get_event, make_lispy_position):
5921 (make_lispy_event, make_lispy_movement, apply_modifiers):
5922 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5923 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5924 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5925 (read_key_sequence, read_char): Mark locals as initialized.
5926 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5927
5928 * keyboard.h (make_ctrl_char): New decl.
5929 (mark_kboards): Move decl here ...
5930 * alloc.c (mark_kboards): ... from here.
5931
5932 * lisp.h (force_auto_save_soon): New decl.
5933
5934 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5935 (DEFINE_DUMMY_FUNCTION): New macro.
5936 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5937 Use it.
5938 (main): Add casts to avoid warnings
5939 if GCC considers string literals to be constants.
5940
5941 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5942
5943 * dbusbind.c: Pointer signedness fixes.
5944 (xd_signature, xd_append_arg, xd_initialize):
5945 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5946 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5947 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5948 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5949
5950 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5951 if GCC considers string literals to be constants.
5952 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5953
5954 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5955
5956 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5957 (print_preprocess, print_object): New macro to fix last change.
5958
5959 * print.c (print_preprocess): Don't forget font objects.
5960
5961 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5962
5963 * emacs.c (USAGE3): Doc fixes.
5964
5965 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5966
5967 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5968 structure.
5969
5970 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5971
5972 * lisp.h (VWindow_system, Qfile_name_history):
5973 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5974 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5975 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5976
5977 * w32select.c: Don't #include "keyboard.h".
5978 (run_protected): Add extern declaration for waiting_for_input.
5979
5980 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5981 * w32console.c (detect_input_pending, read_input_pending)
5982 (encode_terminal_code):
5983 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5984 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5985 (w32_system_caret_y, Qfile_name_history):
5986 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5987 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5988 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5989 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5990 * w32proc.c (Qlocal, report_file_error):
5991 * w32term.c (Vwindow_system, updating_frame):
5992 * w32uniscribe.c (initialized, uniscribe_font_driver):
5993 Remove unneeded extern declarations.
5994
5995 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5996
5997 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5998
5999 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6000
6001 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6002 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6003 These macros can no longer be used for assignment.
6004
6005 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6006 Assign struct members directly, instead of using BUF_BEGV etc.
6007 (record_buffer_markers, fetch_buffer_markers): New functions for
6008 recording and fetching special buffer markers.
6009 (set_buffer_internal_1, set_buffer_temp): Use them.
6010
6011 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6012
6013 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6014
6015 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6016 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6017
6018 * xdisp.c (hscroll_window_tree):
6019 (reconsider_clip_changes): Use PT instead of BUF_PT.
6020
6021 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6022
6023 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6024 $(EMACS_ROOT)/lib/intprops.h.
6025
6026 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6027
6028 Fix more problems found by GCC 4.5.2's static checks.
6029
6030 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6031 to unsigned char * to avoid compiler diagnostic.
6032 (xg_free_frame_widgets): Make it clear that a local variable is
6033 needed only if USE_GTK_TOOLTIP.
6034 (gdk_window_get_screen): Make it clear that this macro is needed
6035 only if USE_GTK_TOOLTIP.
6036 (int_gtk_range_get_value): New function, which avoids a diagnostic
6037 from gcc -Wbad-function-cast.
6038 (xg_set_toolkit_scroll_bar_thumb): Use it.
6039 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6040 diagnostic from gcc -Wbad-function-cast.
6041 (get_utf8_string, xg_get_file_with_chooser):
6042 Rename locals to avoid shadowing.
6043 (create_dialog): Move locals to avoid shadowing.
6044
6045 * xgselect.c (xg_select): Remove unused var.
6046
6047 * image.c (four_corners_best): Mark locals as initialized.
6048 (gif_load): Initialize transparent_p to zero (Bug#8238).
6049 Mark another local as initialized.
6050 (my_png_error, my_error_exit): Mark with NO_RETURN.
6051
6052 * image.c (clear_image_cache): Now static.
6053 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6054 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6055 (x_edge_detection): Remove unnecessary cast that
6056 gcc -Wbad-function-cast diagnoses.
6057 (gif_load): Fix pointer signedness.
6058 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6059 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6060
6061 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6062
6063 Improve quality of tests for time stamp overflow.
6064 For example, without this patch (encode-time 0 0 0 1 1
6065 1152921504606846976) returns the obviously-bogus value (-948597
6066 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6067 reports time overflow. See
6068 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6069 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6070 * editfns.c: Include limits.h and intprops.h.
6071 (TIME_T_MIN, TIME_T_MAX): New macros.
6072 (time_overflow): Move earlier, to before first use.
6073 (hi_time, lo_time): New functions, for an accurate test for
6074 out-of-range times.
6075 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6076 (Fget_internal_run_time): Don't assume time_t fits in int.
6077 (make_time): Use list2 instead of Fcons twice.
6078 (Fdecode_time): More accurate test for out-of-range times.
6079 (check_tm_member): New function.
6080 (Fencode_time): Use it, to test for out-of-range times.
6081 (lisp_time_argument): Don't rely on undefined left-shift and
6082 right-shift behavior when checking for time stamp overflow.
6083
6084 * editfns.c (time_overflow): New function, refactoring common code.
6085 (Fformat_time_string, Fdecode_time, Fencode_time):
6086 (Fcurrent_time_string): Use it.
6087
6088 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6089 * dired.c (make_time): Move to ...
6090 * editfns.c (make_time): ... here.
6091 * systime.h: Note the move.
6092
6093 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6094
6095 * fringe.c (update_window_fringes): Remove unused variables.
6096
6097 * unexmacosx.c (copy_data_segment): Also copy __got section.
6098 (Bug#8223)
6099
6100 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6101
6102 * termcap.c [MSDOS]: Include "msdos.h".
6103 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6104 Constify `char *' arguments and their references according to
6105 prototypes in tparam.h.
6106
6107 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6108
6109 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6110 Adapt all references accordingly.
6111
6112 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6113
6114 2011-03-11 Tom Tromey <tromey@redhat.com>
6115
6116 * buffer.c (syms_of_buffer): Remove obsolete comment.
6117
6118 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6119
6120 * termhooks.h (encode_terminal_code): Declare prototype.
6121
6122 * msdos.c (encode_terminal_code): Don't declare prototype.
6123
6124 * term.c (encode_terminal_code): Now external again, used by
6125 w32console.c and msdos.c.
6126
6127 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6128 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6129
6130 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6131
6132 Fix some minor problems found by GCC 4.5.2's static checks.
6133
6134 * fringe.c (update_window_fringes): Mark locals as initialized
6135 (Bug#8227).
6136 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6137
6138 * alloc.c (mark_fringe_data): Move decl from here ...
6139 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6140 to check its interface.
6141 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6142
6143 * fontset.c (free_realized_fontset): Now static.
6144 (Fset_fontset_font): Rename local to avoid shadowing.
6145 (fontset_font): Mark local as initialized.
6146 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6147
6148 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6149
6150 * xselect.c (x_disown_buffer_selections): Remove; not used.
6151 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6152 (x_own_selection, Fx_disown_selection_internal): Rename locals
6153 to avoid shadowing.
6154 (x_handle_dnd_message): Remove local to avoid shadowing.
6155
6156 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6157 so that the caller can use some name other than gcpro1.
6158 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6159 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6160 (Fx_backspace_delete_keys_p):
6161 Use them to avoid shadowing, and rename vars to avoid shadowing.
6162 (x_decode_color, x_set_name, x_window): Now static.
6163 (Fx_create_frame): Add braces to silence GCC warning.
6164 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6165 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6166 Remove unused locals.
6167 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6168 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6169 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6170 macros.
6171
6172 * xterm.h (x_mouse_leave): New decl.
6173
6174 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6175 Remove unused functions.
6176 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6177 (x_calc_absolute_position): Now static.
6178 (XTread_socket): Don't define label "out" unless it's used.
6179 Don't declare local "event" unless it's used.
6180 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6181 unless they are used.
6182 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6183 (x_fatal_error_signal): Remove; not used.
6184 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6185 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6186 (x_error_catcher, x_connection_closed, x_error_handler):
6187 (x_error_quitter, xembed_send_message, x_iconify_frame):
6188 (my_log_handler): Rename locals to avoid shadowing.
6189 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6190 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6191
6192 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6193 Rename or move locals to avoid shadowing.
6194 (tty_defined_color, merge_face_heights): Now static.
6195 (free_realized_faces_for_fontset): Remove; not used.
6196 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6197 does not deduce is never used uninitialized.
6198 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6199 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6200
6201 * terminal.c (store_terminal_param): Now static.
6202
6203 * xmenu.c (menu_highlight_callback): Now static.
6204 (set_frame_menubar): Remove unused local.
6205 (xmenu_show): Rename parameter to avoid shadowing.
6206 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6207 since they might point to immutable storage.
6208 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6209 since it's unused otherwise.
6210
6211 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6212 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6213 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6214 avoids a gcc -Wuninitialized diagnostic.
6215 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6216 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6217 does not deduce are never used uninitialized.
6218
6219 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6220
6221 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6222 * window.c (window_loop, size_window):
6223 (run_window_configuration_change_hook, enlarge_window): Likewise.
6224
6225 * window.c (display_buffer): Now static.
6226 (size_window): Mark variables that gcc -Wuninitialized
6227 does not deduce are never used uninitialized.
6228 * window.h (check_all_windows): New decl, to forestall
6229 gcc -Wmissing-prototypes diagnostic.
6230 * dispextern.h (bidi_dump_cached_states): Likewise.
6231
6232 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6233 shadowing.
6234 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6235 Include <limits.h>.
6236 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6237 and to avoid gcc -Wuninitialized warning.
6238 (load_charset_map): Mark variables that gcc -Wuninitialized
6239 does not deduce are never used uninitialized.
6240 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6241
6242 * coding.c (coding_set_source, coding_set_destination):
6243 Use "else { /* comment */ }" rather than "else /* comment */;"
6244 for clarity, and to avoid gcc -Wempty-body warning.
6245 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6246 a block, when the outer 'i' will do.
6247 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6248 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6249 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6250 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6251 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6252 Rename locals to avoid shadowing.
6253 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6254 * coding.c (emacs_mule_char, encode_invocation_designation):
6255 Now static, since they're not used elsewhere.
6256 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6257 (decode_coding_object, encode_coding_object, detect_coding_system):
6258 (decode_coding_emacs_mule): Mark variables that gcc
6259 -Wuninitialized does not deduce are never used uninitialized.
6260 (detect_coding_iso_2022): Initialize a local variable that might
6261 be used uninitialized. Leave a FIXME because it's not clear that
6262 this initialization is needed. (Bug#8211)
6263 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6264 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6265 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6266 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6267 Remove unused macros.
6268
6269 * category.c (hash_get_category_set): Remove unused local var.
6270 (copy_category_table): Now static, since it's not used elsewhere.
6271 * character.c (string_count_byte8): Likewise.
6272
6273 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6274 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6275
6276 * chartab.c (copy_sub_char_table): Now static, since it's not used
6277 elsewhere.
6278 (sub_char_table_ref_and_range, char_table_ref_and_range):
6279 Rename locals to avoid shadowing.
6280 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6281
6282 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6283 (BIDI_BOB): Remove unused macro.
6284
6285 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6286 deduce are never used uninitialized.
6287 * term.c (encode_terminal_code): Likewise.
6288
6289 * term.c (encode_terminal_code): Now static. Remove unused local.
6290
6291 * tparam.h: New file.
6292 * term.c, tparam.h: Include it.
6293 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6294 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6295 Move these decls to tparam.h, and make them agree with what
6296 is actually in tparam.c. The previous trick of using incompatible
6297 decls in different modules does not conform to the C standard.
6298 All callers of tparam changed to use tparam's actual API.
6299 * tparam.c (tparam1, tparam, tgoto):
6300 Use const pointers where appropriate.
6301
6302 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6303 * cm.h (struct cm): Likewise.
6304 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6305 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6306 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6307 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6308 (turn_on_face, init_tty): Likewise.
6309 * termchar.h (struct tty_display_info): Likewise.
6310
6311 * term.c (term_mouse_position): Rename local to avoid shadowing.
6312
6313 * alloc.c (mark_ttys): Move decl from here ...
6314 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6315
6316 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6317
6318 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6319
6320 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6321
6322 * search.c (compile_pattern_1): Remove argument regp, unused since
6323 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6324 (compile_pattern): Don't pass it.
6325
6326 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6327
6328 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6329 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6330 for ! HAVE_GTK3.
6331 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6332
6333 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6334
6335 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6336 gdk_window_get_screen, gdk_window_get_geometry,
6337 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6338 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6339 (xg_get_pixbuf_from_pixmap): New function.
6340 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6341 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6342 Call xg_get_pixbuf_from_pixmap instead of
6343 gdk_pixbuf_get_from_drawable.
6344 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6345 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6346 (xg_check_special_colors): Use GtkStyleContext and its functions
6347 for HAVE_GTK3.
6348 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6349 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6350 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6351 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6352 Call gtk_widget_get_preferred_size.
6353 (xg_frame_resized): gdk_window_get_geometry only takes 5
6354 parameters.
6355 (xg_win_to_widget, xg_event_is_for_menubar):
6356 Call gdk_x11_window_lookup_for_display.
6357 (xg_set_widget_bg): New function.
6358 (delete_cb): New function.
6359 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6360 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6361 (xg_set_background_color): Call xg_set_widget_bg.
6362 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6363 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6364 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6365 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6366 if ! HAVE_GTK3.
6367 (update_frame_tool_bar): Call gtk_widget_hide.
6368 (xg_initialize): Use GDK_KEY_g.
6369
6370 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6371 if ! HAVE_GTK3
6372 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6373
6374 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6375 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6376 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6377
6378 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6379
6380 * w32xfns.c (select_palette): Check success of RealizePalette against
6381 GDI_ERROR, not zero.
6382
6383 See ChangeLog.11 for earlier changes.
6384
6385 ;; Local Variables:
6386 ;; coding: utf-8
6387 ;; End:
6388
6389 Copyright (C) 2011 Free Software Foundation, Inc.
6390
6391 This file is part of GNU Emacs.
6392
6393 GNU Emacs is free software: you can redistribute it and/or modify
6394 it under the terms of the GNU General Public License as published by
6395 the Free Software Foundation, either version 3 of the License, or
6396 (at your option) any later version.
6397
6398 GNU Emacs is distributed in the hope that it will be useful,
6399 but WITHOUT ANY WARRANTY; without even the implied warranty of
6400 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6401 GNU General Public License for more details.
6402
6403 You should have received a copy of the GNU General Public License
6404 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.