src/gnutls.c, src/image.c: Make function pointers static.
[bpt/emacs.git] / src / ChangeLog
1 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2
3 * gnutls.c (DEF_GNUTLS_FN):
4 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5
6 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7
8 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9 marker. (Bug#8610)
10
11 2011-05-05 Eli Zaretskii <eliz@gnu.org>
12
13 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
14 New version that can reserve upto 2GB of heap space.
15
16 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
17
18 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
19
20 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
21
22 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
23 `gnutls_certificate_set_x509_key_file'.
24
25 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
26
27 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
28 Update dependencies.
29
30 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
31
32 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
33 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
34 Remove unused parameter `fildes'.
35 * process.c (read_process_output, send_process): Don't pass it.
36
37 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
38
39 Fix previous change: the library cache is defined in w32.c.
40 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
41 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
42
43 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
44
45 Implement dynamic loading of GnuTLS on Windows.
46
47 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
48 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
49 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
50 Declare.
51
52 * gnutls.c (Qgnutls_dll): Define.
53 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
54 (gnutls_*): Declare function pointers.
55 (init_gnutls_functions): New function to initialize function pointers.
56 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
57 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
58 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
59 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
60 (emacs_gnutls_write, emacs_gnutls_read)
61 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
62 (Fgnutls_available_p): New function.
63 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
64 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
65 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
66
67 * image.c: Include w32.h.
68 (Vimage_type_cache): Delete.
69 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
70 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
71 (w32_delayed_load): Move to w32.c.
72
73 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
74
75 * w32.c (QCloaded_from, Vlibrary_cache): Define.
76 (w32_delayed_load): Move from image.c. When loading a library, record
77 its filename in the :loaded-from property of the library id.
78 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
79 Initialize and staticpro them.
80 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
81
82 * process.c: Include lisp.h before w32.h, not after.
83 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
84 instead of gnutls_record_check_pending.
85
86 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
87
88 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
89
90 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
91 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
92 as passed in.
93
94 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
95
96 * xterm.c (x_set_frame_alpha): Do not set property on anything
97 else than FRAME_X_OUTER_WINDOW (Bug#8608).
98
99 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
100
101 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
102
103 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
104
105 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
106 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
107 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
108 (gnutls_global_initialized, Qgnutls_bootprop_priority)
109 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
110 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
111 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
112 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
113 (Qgnutls_bootprop_callbacks_verify): Make static.
114
115 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
116
117 * callproc.c: Indentation fixup.
118
119 * sysdep.c (wait_for_termination_1): Make static.
120 (wait_for_termination, interruptible_wait_for_termination): Move
121 after wait_for_termination_1.
122
123 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
124
125 * sysdep.c (interruptible_wait_for_termination): New function
126 which is like wait_for_termination, but allows keyboard
127 interruptions.
128
129 * callproc.c (Fcall_process): Add (:file "file") as an option for
130 the STDOUT buffer.
131 (Fcall_process_region): Ditto.
132
133 2011-04-30 Eli Zaretskii <eliz@gnu.org>
134
135 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
136 rather than `XVECTOR (FOO)->size'.
137
138 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
139 inttypes.h, as a gnulib replacement is used if it not available in
140 system headers.
141
142 2011-04-21 Eli Zaretskii <eliz@gnu.org>
143
144 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
145 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
146 of MOST_POSITIVE_FIXNUM. (Bug#8528)
147
148 * coding.c (coding_alloc_by_realloc): Error out if destination
149 will grow beyond MOST_POSITIVE_FIXNUM.
150 (decode_coding_emacs_mule): Abort if there isn't enough place in
151 charbuf for the composition carryover bytes. Reserve an extra
152 space for up to 2 characters produced in a loop.
153 (decode_coding_iso_2022): Abort if there isn't enough place in
154 charbuf for the composition carryover bytes.
155
156 2011-04-21 Eli Zaretskii <eliz@gnu.org>
157
158 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
159 aborting when %lld or %lll format is passed.
160 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
161 %llo or %llx format is passed. (Bug#8545)
162
163 * window.c (window_scroll_line_based): Use a marker instead of
164 simple variables to record original value of point. (Bug#7952)
165
166 * doprnt.c (doprnt): Fix the case where a multibyte sequence
167 produced by %s or %c overflows available buffer space. (Bug#8545)
168
169 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
170
171 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
172 (SIZE_MAX): Move defn after all includes, as they might #define it.
173
174 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
175
176 * w32.c (init_environment): Warn about defaulting HOME to C:\.
177
178 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
179
180 * keyboard.c (Qdelayed_warnings_hook): Define.
181 (command_loop_1): Run `delayed-warnings-hook'
182 if Vdelayed_warnings_list is non-nil.
183 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
184 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
185
186 2011-04-28 Eli Zaretskii <eliz@gnu.org>
187
188 * doprnt.c (doprnt): Don't return value smaller than the buffer
189 size if the message was truncated. (Bug#8545).
190
191 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
192
193 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
194 (Fx_window_property): #if-0 the whole functions, not just the bodies.
195
196 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
197
198 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
199
200 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
201
202 * makefile.w32-in: Update dependencies.
203
204 2011-04-27 Eli Zaretskii <eliz@gnu.org>
205
206 Improve `doprnt' and its usage. (Bug#8545)
207 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
208 `format_end'. Remove support for %l as a conversion specifier.
209 Don't use xrealloc. Improve diagnostics when the %l size modifier
210 is used. Update the commentary.
211
212 * eval.c (verror): Simplify calculation of size_t.
213
214 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
215 messages.
216
217 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
218
219 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
220 change.
221
222 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
223
224 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
225 This makes this file independent of the recent pseudovector change.
226
227 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
228
229 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
230
231 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
232 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
233 Remove unused local.
234 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
235
236 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
237 GCC 4.6.0 optimizes based on type-based alias analysis. For
238 example, if b is of type struct buffer * and v of type struct
239 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
240 != &v->size, and therefore "v->size = 1; b->size = 2; return
241 v->size;" must therefore return 1. This assumption is incorrect
242 for Emacs, since it type-puns struct Lisp_Vector * with many other
243 types. To fix this problem, this patch adds a new type struct
244 vectorlike_header that documents the constraints on layout of vectors
245 and pseudovectors, and helps optimizing compilers not get fooled
246 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
247 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
248 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
249 the size member.
250 (XSETPVECTYPE): Rewrite in terms of new macro.
251 (XSETPVECTYPESIZE): New macro, specifying both type and size.
252 This is a bit clearer, and further avoids the possibility of
253 undesirable aliasing.
254 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
255 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
256 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
257 since Lisp_Subr is a special case (no "next" field).
258 (ASIZE): Now uses header.size rather than size. All
259 previous uses of XVECTOR (foo)->size replaced to use this macro,
260 to avoid the hassle of writing XVECTOR (foo)->header.size.
261 (struct vectorlike_header): New type.
262 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
263 object, to help avoid aliasing.
264 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
265 (SUBRP): Likewise, since Lisp_Subr is a special case.
266 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
267 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
268 (struct Lisp_Hash_Table): Combine first two members into a single
269 struct vectorlike_header member. All uses of "size" and "next" members
270 changed to be "header.size" and "header.next".
271 * buffer.h (struct buffer): Likewise.
272 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
273 * frame.h (struct frame): Likewise.
274 * process.h (struct Lisp_Process): Likewise.
275 * termhooks.h (struct terminal): Likewise.
276 * window.c (struct save_window_data, struct saved_window): Likewise.
277 * window.h (struct window): Likewise.
278 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
279 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
280 * buffer.c (init_buffer_once): Likewise.
281 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
282 special case.
283 * process.c (Fformat_network_address): Use local var for size,
284 for brevity.
285
286 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
287
288 Make the Lisp reader and string-to-float more consistent (Bug#8525)
289 * data.c (atof): Remove decl; no longer used or needed.
290 (digit_to_number): Move to lread.c.
291 (Fstring_to_number): Use new string_to_number function, to be
292 consistent with how the Lisp reader treats infinities and NaNs.
293 Do not assume that floating-point numbers represent EMACS_INT
294 without losing information; this is not true on most 64-bit hosts.
295 Avoid double-rounding errors, by insisting on integers when
296 parsing non-base-10 numbers, as the documentation specifies.
297 * lisp.h (string_to_number): New decl, replacing ...
298 (isfloat_string): Remove.
299 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
300 (read1): Do not accept +. and -. as integers; this
301 appears to have been a coding error. Similarly, do not accept
302 strings like +-1e0 as floating point numbers. Do not report
303 overflow for integer overflows unless the base is not 10 which
304 means we have no simple and reliable way to continue.
305 Break out the floating-point parsing into a new
306 function string_to_number, so that Fstring_to_number parses
307 floating point numbers consistently with the Lisp reader.
308 (digit_to_number): Moved here from data.c. Make it static inline.
309 (E_CHAR, EXP_INT): Remove, replacing with ...
310 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
311 (string_to_number): New function, replacing isfloat_string.
312 This function checks for valid syntax and produces the resulting
313 Lisp float number too. Rework it so that string-to-number
314 no longer mishandles examples like "1.0e+". Use strtoumax,
315 so that overflow for non-base-10 numbers is reported only when
316 there's no portable and simple way to convert to floating point.
317
318 * textprop.c (set_text_properties_1): Rewrite for clarity,
319 and to avoid GCC warning about integer overflow.
320
321 * intervals.h (struct interval): Use EMACS_INT for members
322 where EMACS_UINT might cause problems. See
323 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
324 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
325 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
326 All uses changed.
327 (offset_intervals): Tell GCC not to worry about length overflow
328 when negating a negative length.
329
330 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
331 (overrun_check_free): Likewise.
332
333 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
334 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
335 word size.
336
337 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
338 (gnutls_make_error): Rename local to avoid shadowing.
339 (gnutls_emacs_global_deinit): ifdef out; not used.
340 (Fgnutls_boot): Use const for pointer to readonly storage.
341 Comment out unused local. Fix pointer signedness problems.
342
343 * lread.c (openp): Don't stuff size_t into an 'int'.
344 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
345 about possible signed overflow.
346
347 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
348 (GDK_KEY_g): Don't define if already defined.
349 (xg_prepare_tooltip): Avoid pointer signedness problem.
350 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
351
352 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
353 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
354
355 * xfns.c (Fx_window_property): Simplify a bit,
356 to make a bit faster and to avoid GCC 4.6.0 warning.
357 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
358
359 * fns.c (internal_equal): Don't assume size_t fits in int.
360
361 * alloc.c (compact_small_strings): Tighten assertion a little.
362
363 Replace pEd with more-general pI, and fix some printf arg casts.
364 * lisp.h (pI): New macro, generalizing old pEd macro to other
365 conversion specifiers. For example, use "...%"pI"d..." rather
366 than "...%"pEd"...".
367 (pEd): Remove. All uses replaced with similar uses of pI.
368 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
369 * alloc.c (check_pure_size): Don't overflow by converting size to int.
370 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
371 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
372 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
373 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
374 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
375 64-bit hosts.
376 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
377 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
378 * print.c (safe_debug_print, print_object): Likewise.
379 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
380 to int.
381 Use pI instead of if-then-else-abort. Use %p to avoid casts,
382 avoiding the 0 flag, which is not portable.
383 * process.c (Fmake_network_process): Use pI to avoid cast.
384 * region-cache.c (pp_cache): Likewise.
385 * xdisp.c (decode_mode_spec): Likewise.
386 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
387 behavior on 64-bit hosts with printf arg.
388 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
389 (x_stop_queuing_selection_requests): Likewise.
390 (x_get_window_property): Don't truncate byte count to an 'int'
391 when tracing.
392
393 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
394 here, since it parses constructs like leading '-' and spaces,
395 which are not wanted; and it overflows with large numbers.
396 Instead, simply match F[0-9]+, which is what is wanted anyway.
397
398 * alloc.c: Remove unportable assumptions about struct layout.
399 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
400 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
401 (allocate_vectorlike, make_pure_vector): Use the new macros,
402 plus offsetof, to remove unportable assumptions about struct layout.
403 These assumptions hold on all porting targets that I know of, but
404 they are not guaranteed, they're easy to remove, and removing them
405 makes further changes easier.
406
407 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
408 This doesn't fix a bug but makes the code clearer.
409 (string_overrun_cookie): Now const. Use initializers that
410 don't formally overflow signed char, to avoid warnings.
411 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
412 can cause Emacs to crash when string overrun checking is enabled.
413 (allocate_buffer): Don't assume sizeof (struct buffer) is a
414 multiple of sizeof (EMACS_INT); it need not be, if
415 alignof(EMACS_INT) < sizeof (EMACS_INT).
416 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
417
418 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
419
420 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
421
422 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
423
424 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
425 supposed to be handshaking. (Bug#8556)
426 Reported by Paul Eggert <eggert@cs.ucla.edu>.
427
428 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
429
430 * lisp.h (Qdebug): List symbol.
431 * eval.c (Qdebug): Restore global linkage.
432 * keyboard.c (debug-on-event): New variable.
433 (handle_user_signal): Break into debugger when debug-on-event
434 matches the current signal symbol.
435
436 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
437
438 * alloc.c (check_sblock, check_string_bytes)
439 (check_string_free_list): Convert to standard C.
440
441 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
442
443 * w32.c (emacs_gnutls_push): Fix typo.
444
445 2011-04-25 Eli Zaretskii <eliz@gnu.org>
446
447 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
448 "cast to pointer from integer of different size".
449
450 Improve doprnt and its use in verror. (Bug#8545)
451 * doprnt.c (doprnt): Document the set of format control sequences
452 supported by the function. Use SAFE_ALLOCA instead of always
453 using `alloca'.
454
455 * eval.c (verror): Don't limit the buffer size at size_max-1, that
456 is one byte too soon. Don't use xrealloc; instead xfree and
457 xmalloc anew.
458
459 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
460
461 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
462 callbacks stage.
463
464 * gnutls.c: Renamed global_initialized to
465 gnutls_global_initialized. Added internals for the
466 :verify-hostname-error, :verify-error, and :verify-flags
467 parameters of `gnutls-boot' and documented those parameters in the
468 docstring. Start callback support.
469 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
470 unless a fatal error occured. Call gnutls_alert_send_appropriate
471 on error. Return error code.
472 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
473 (emacs_gnutls_read): Likewise.
474 (Fgnutls_boot): Return handshake error code.
475 (emacs_gnutls_handle_error): New function.
476 (wsaerror_to_errno): Likewise.
477
478 * w32.h (emacs_gnutls_pull): Add prototype.
479 (emacs_gnutls_push): Likewise.
480
481 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
482 (emacs_gnutls_push): Likewise.
483
484 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
485
486 * process.c (wait_reading_process_output): Check if GnuTLS
487 buffered some data internally if no FDs are set for TLS
488 connections.
489
490 * makefile.w32-in (OBJ2): Add gnutls.$(O).
491 (LIBS): Link to USER_LIBS.
492 ($(BLD)/gnutls.$(0)): New target.
493
494 2011-04-24 Eli Zaretskii <eliz@gnu.org>
495
496 * xdisp.c (handle_single_display_spec): Rename the
497 display_replaced_before_p argument into display_replaced_p, to
498 make it consistent with the commentary. Fix typos in the
499 commentary.
500
501 * textprop.c (syms_of_textprop): Remove dead code.
502 (copy_text_properties): Delete obsolete commentary about an
503 interface that was deleted long ago. Fix typos in the description
504 of arguments.
505
506 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
507 to changes in oldXMenu/XMenu.h from 2011-04-16.
508 <menu_help_message, prev_menu_help_message>: Constify.
509 (IT_menu_make_room): menu->help_text is now `const char **';
510 adjust.
511
512 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
513 to changes in oldXMenu/XMenu.h from 2011-04-16.
514 (struct XMenu): Declare `help_text' `const char **'.
515
516 * xfaces.c <Qunspecified>: Make extern again.
517
518 * syntax.c: Include sys/types.h before including regex.h, as
519 required by Posix.
520
521 * doc.c (get_doc_string): Improve the format passed to `error'.
522
523 * doprnt.c (doprnt): Improve commentary.
524
525 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
526
527 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
528 them with etags.
529
530 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
531 changes in globals.h immediately force recompilation.
532 (TAGS): Depend on $(CURDIR)/m/intel386.h and
533 $(CURDIR)/s/ms-w32.h.
534 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
535
536 * character.c (Fchar_direction): Function deleted.
537 (syms_of_character): Don't defsubr it.
538 <char-direction-table>: Deleted.
539
540 2011-04-23 Eli Zaretskii <eliz@gnu.org>
541
542 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
543 * doprnt.c: Include limits.h.
544 (SIZE_MAX): New macro.
545 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
546 local variables are now size_t instead of int or unsigned.
547 Improve overflow protection. Support `l' modifier for integer
548 conversions. Support %l conversion. Don't assume an EMACS_INT
549 argument for integer conversions and for %c.
550
551 * lisp.h (doprnt): Restore prototype.
552
553 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
554 $(SRC)/character.h.
555
556 * Makefile.in (base_obj): Add back doprnt.o.
557
558 * deps.mk (doprnt.o): Add back prerequisites.
559 (callint.o): Depend on character.h.
560
561 * eval.c (internal_lisp_condition_case): Include the handler
562 representation in the error message.
563 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
564 when breaking from the loop.
565
566 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
567
568 * callint.c (Fcall_interactively): When displaying error message
569 about invalid control letter, pass the character's codepoint, not
570 a pointer to its multibyte form. Improve display of the character
571 in octal and display also its hex code.
572
573 * character.c (char_string): Use %x to display the (unsigned)
574 codepoint of an invalid character, to avoid displaying a bogus
575 negative value.
576
577 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
578 `error', not SYMBOL_NAME itself.
579
580 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
581 character arguments to `error'.
582
583 * charset.c (check_iso_charset_parameter): Fix incorrect argument
584 to `error' in error message about FINAL_CHAR argument. Make sure
585 FINAL_CHAR is a character, and use %c when it is passed as
586 argument to `error'.
587
588 2011-04-23 Eli Zaretskii <eliz@gnu.org>
589
590 * s/ms-w32.h (localtime): Redirect to sys_localtime.
591
592 * w32.c: Include <time.h>.
593 (sys_localtime): New function.
594
595 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
596
597 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
598
599 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
600
601 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
602
603 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
604 zombies (Bug#8467).
605
606 2011-04-19 Eli Zaretskii <eliz@gnu.org>
607
608 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
609 gl_state.e_property when gl_state.object is Qt.
610
611 * insdel.c (make_gap_larger): Remove limitation of buffer size
612 to <= INT_MAX.
613
614 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
615
616 * xdisp.c (lookup_glyphless_char_display)
617 (produce_glyphless_glyph): Handle cons cell entry in
618 glyphless-char-display.
619 (Vglyphless_char_display): Document it.
620
621 * term.c (produce_glyphless_glyph): Handle cons cell entry in
622 glyphless-char-display.
623
624 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
625
626 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
627
628 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
629
630 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
631 definition for no-X builds.
632
633 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
634
635 Static checks with GCC 4.6.0 and non-default toolkits.
636
637 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
638
639 * process.c (keyboard_bit_set): Define only if SIGIO.
640 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
641 (send_process): Repair possible setjmp clobbering.
642
643 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
644
645 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
646
647 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
648
649 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
650 Define only if needed.
651
652 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
653 by pacifying GCC about it. Maybe it's time to retire it?
654 * xfaces.c (USG, __TIMEVAL__): Likewise.
655
656 * dispextern.h (struct redisplay_interface): Rename param
657 to avoid shadowing.
658 * termhooks.h (struct terminal): Likewise.
659 * xterm.c (xembed_send_message): Likewise.
660
661 * insdel.c (make_gap_smaller): Define only if
662 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
663
664 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
665 it.
666
667 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
668 so that we aren't warned about unused symbols.
669
670 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
671
672 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
673
674 * xfns.c (x_real_positions): Mark locals as initialized.
675
676 * xmenu.c (xmenu_show): Don't use uninitialized vars.
677
678 * xterm.c: Fix problems found by static analysis with other toolkits.
679 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
680 (x_dispatch_event): Declare static if USE_GTK, and
681 define if USE_GTK || USE_X_TOOLKIT.
682 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
683 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
684 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
685 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
686
687 * xmenu.c (menu_help_callback): Pointer type fixes.
688 Use const pointers when pointing at readonly data. Avoid pointer
689 signedness clashes.
690 (FALSE): Remove unused macro.
691 (update_frame_menubar): Remove unused decl.
692
693 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
694
695 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
696 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
697 (single_menu_item): Rename local to avoid shadowing.
698
699 * keyboard.c (make_lispy_event): Remove unused local var.
700
701 * frame.c, frame.h (x_get_resource_string): Bring this back, but
702 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
703
704 * bitmaps: Change bitmaps from unsigned char back to the X11
705 compatible char. Avoid the old compiler warnings about
706 out-of-range initializers by using, for example, '\xab' rather
707 than 0xab.
708
709 * xgselect.c (xgselect_initialize): Check vs interface
710 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
711
712 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
713
714 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
715 to read-only memory.
716
717 * fns.c (vector): Remove; this old hack is no longer needed.
718
719 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
720 Remove unused var.
721 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
722
723 * xrdb.c (x_load_resources): Omit unused local.
724
725 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
726 (x_window): Rename locals to avoid shadowing.
727 (USG): Use the kludged USG macro, to pacify gcc.
728
729 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
730 (x_term_init): Remove local to avoid shadowing.
731
732 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
733
734 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
735 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
736
737 2011-04-16 Eli Zaretskii <eliz@gnu.org>
738
739 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
740
741 Fix regex.c, syntax.c and friends for buffers > 2GB.
742 * syntax.h (struct gl_state_s): Declare character position members
743 EMACS_INT.
744
745 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
746
747 * textprop.c (verify_interval_modification, interval_of): Declare
748 arguments EMACS_INT.
749
750 * intervals.c (adjust_intervals_for_insertion): Declare arguments
751 EMACS_INT.
752
753 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
754
755 * indent.c (Fvertical_motion): Local variable it_start is now
756 EMACS_INT.
757
758 * regex.c (re_match, re_match_2, re_match_2_internal)
759 (bcmp_translate, regcomp, regexec, print_double_string)
760 (group_in_compile_stack, re_search, re_search_2, regex_compile)
761 (re_compile_pattern, re_exec): Declare arguments and local
762 variables `size_t' and `ssize_t' and return values `regoff_t', as
763 appropriate.
764 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
765 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
766 <compile_stack_type>: `size' and `avail' are now `size_t'.
767
768 * regex.h <regoff_t>: Use ssize_t, not int.
769 (re_search, re_search_2, re_match, re_match_2): Arguments that
770 specify buffer/string position and length are now ssize_t and
771 size_t. Return type is regoff_t.
772
773 2011-04-16 Ben Key <bkey76@gmail.com>
774
775 * nsfont.m: Fixed bugs in ns_get_family and
776 ns_descriptor_to_entity that were caused by using free to
777 deallocate memory blocks that were allocated by xmalloc (via
778 xstrdup). This caused Emacs to crash when compiled with
779 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
780 --enable-checking=xmallocoverrun). xfree is now used to
781 deallocate these memory blocks.
782
783 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
784
785 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
786
787 emacs_write: Accept and return EMACS_INT for sizes.
788 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
789 et seq.
790 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
791 Accept and return EMACS_INT.
792 (emacs_gnutls_write): Return the number of bytes written on
793 partial writes.
794 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
795 (emacs_read, emacs_write): Remove check for negative size, as the
796 Emacs source code has been audited now.
797 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
798 (emacs_read, emacs_write): Use it.
799 * process.c (send_process): Adjust to the new signatures of
800 emacs_write and emacs_gnutls_write. Do not attempt to store
801 a byte offset into an 'int'; it might overflow.
802 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
803
804 * sound.c: Don't assume sizes fit in 'int'.
805 (struct sound_device.period_size, alsa_period_size):
806 Return EMACS_INT, not int.
807 (struct sound_device.write, vox_write, alsa_write):
808 Accept EMACS_INT, not int.
809 (wav_play, au_play): Use EMACS_INT to store sizes and to
810 record read return values.
811
812 2011-04-15 Ben Key <bkey76@gmail.com>
813
814 * keyboard.c (Qundefined): Don't declare static since it is used
815 in nsfns.m.
816 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
817 static since they are used in nsfont.m.
818
819 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
820
821 * process.c (Qprocessp): Don't declare static.
822 * lisp.h (Qprocessp): Declare again.
823
824 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
825
826 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
827
828 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
829
830 Improve C-level modularity by making more things 'static'.
831
832 Don't publish debugger-only interfaces to other modules.
833 * lisp.h (safe_debug_print, debug_output_compilation_hack):
834 (verify_bytepos, count_markers): Move decls to the only modules
835 that need them.
836 * region-cache.h (pp_cache): Likewise.
837 * window.h (check_all_windows): Likewise.
838 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
839
840 * sysdep.c (croak): Now static, if
841 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
842 * syssignal.h (croak): Declare only if not static.
843
844 * alloc.c (refill_memory_reserve): Now static if
845 !defined REL_ALLOC || defined SYSTEM_MALLOC.
846 * lisp.h (refill_memory_reserve): Declare only if not static.
847
848 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
849 Define only if USE_LUCID.
850
851 * xrdb.c (x_customization_string, x_rm_string): Now static.
852
853 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
854 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
855
856 * xdisp.c (draw_row_with_mouse_face): Now static.
857 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
858
859 * window.h (check_all_windows): Mark externally visible.
860
861 * window.c (window_deletion_count): Now static.
862
863 * undo.c: Make symbols static if they're not exported.
864 (last_undo_buffer, last_boundary_position, pending_boundary):
865 Now static.
866
867 * textprop.c (interval_insert_behind_hooks): Now static.
868 (interval_insert_in_front_hooks): Likewise.
869
870 * term.c: Make symbols static if they're not exported.
871 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
872 (max_frame_lines, tty_set_terminal_modes):
873 (tty_reset_terminal_modes, tty_turn_off_highlight):
874 (get_tty_terminal): Now static.
875 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
876 * termhooks.h (term_mouse_moveto): Do not declare if
877 HAVE_WINDOW_SYSTEM.
878 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
879 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
880
881 * sysdep.c: Make symbols static if they're not exported.
882 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
883 Now static.
884 (sigprocmask_set, full_mask): Remove; unused.
885 (wait_debugging): Mark as visible.
886 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
887 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
888
889 * syntax.c (syntax_temp): Define only if !__GNUC__.
890
891 * sound.c (current_sound_device, current_sound): Now static.
892
893 * search.c (searchbufs, searchbuf_head): Now static.
894
895 * scroll.c (scroll_cost): Remove; unused.
896 * dispextern.h (scroll_cost): Remove decl.
897
898 * region-cache.h (pp_cache): Mark as externally visible.
899
900 * process.c: Make symbols static if they're not exported.
901 (process_tick, update_tick, create_process, chan_process):
902 (Vprocess_alist, proc_buffered_char, datagram_access):
903 (fd_callback_data, send_process_frame, process_sent_to): Now static.
904 (deactivate_process): Mark defn as static, as well as decl.
905 * lisp.h (create_process): Remove decl.
906 * process.h (chan_process, Vprocess_alist): Remove decls.
907
908 * print.c: Make symbols static if they're not exported.
909 (print_depth, new_backquote_output, being_printed, print_buffer):
910 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
911 (print_interval, print_number_index, initial_stderr_stream):
912 Now static.
913 * lisp.h (Fprinc): Remove decl.
914 (debug_output_compilation_hack): Mark as externally visible.
915
916 * sysdep.c (croak): Move decl from here to syssignal.h.
917 * syssignal.h (croak): Put it here, so the API can be checked when
918 'croak' is called from dissociate_if_controlling_tty.
919
920 * minibuf.c: Make symbols static if they're not exported.
921 (minibuf_save_list, choose_minibuf_frame): Now static.
922 * lisp.h (choose_minibuf_frame): Remove decl.
923
924 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
925
926 * lread.c: Make symbols static if they're not exported.
927 (read_objects, initial_obarray, oblookup_last_bucket_number):
928 Now static.
929 (make_symbol): Remove; unused.
930 * lisp.h (initial_obarray, make_symbol): Remove decls.
931
932 * keyboard.c: Make symbols static if they're not exported.
933 (single_kboard, recent_keys_index, total_keys, recent_keys):
934 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
935 (this_single_command_key_start, echoing, last_auto_save):
936 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
937 (command_loop, echo_now, keyboard_init_hook, help_char_p):
938 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
939 (Vlispy_mouse_stem, double_click_count):
940 Now static.
941 (force_auto_save_soon): Define only if SIGDANGER.
942 (ignore_mouse_drag_p): Now static if
943 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
944 (print_help): Remove; unused.
945 (stop_character, last_timer_event): Mark as externally visible.
946 * keyboard.h (ignore_mouse_drag_p): Declare only if
947 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
948 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
949 * lisp.h (echoing): Remove decl.
950 (force_auto_save_soon): Declare only if SIGDANGER.
951 * xdisp.c (redisplay_window): Simplify code, to make it more
952 obvious that ignore_mouse_drag_p is not accessed if !defined
953 USE_GTK && !defined HAVE_NS.
954
955 * intervals.c: Make symbols static if they're not exported.
956 (merge_properties_sticky, merge_interval_right, delete_interval):
957 Now static.
958 * intervals.h (merge_interval_right, delete_interval): Remove decls.
959
960 * insdel.c: Make symbols static if they're not exported.
961 However, leave prepare_to_modify_buffer alone. It's never
962 called from outside this function, but that appears to be a bug.
963 (combine_after_change_list, combine_after_change_buffer):
964 (adjust_after_replace, signal_before_change): Now static.
965 (adjust_after_replace_noundo): Remove; unused.
966 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
967 (signal_before_change): Remove decls.
968
969 * indent.c (val_compute_motion, val_vmotion): Now static.
970
971 * image.c: Make symbols static if they're not exported.
972 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
973 if USE_GTK.
974 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
975 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
976
977 * fringe.c (standard_bitmaps): Now static.
978 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
979
980 * frame.c: Make symbols static if they're not exported.
981 (x_report_frame_params, make_terminal_frame): Now static.
982 (get_frame_param): Now static, unless HAVE_NS.
983 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
984 (x_get_resource_string): Remove; not used.
985 * frame.h (make_terminal_frame, x_report_frame_params):
986 (x_get_resource_string); Remove decls.
987 (x_fullscreen_adjust): Declare only if WINDOWSNT.
988 * lisp.h (get_frame_param): Declare only if HAVE_NS.
989
990 * font.c, fontset.c: Make symbols static if they're not exported.
991 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
992 (FACE_SUITABLE_FOR_CHAR_P): Use it.
993 * font.c (font_close_object): Now static.
994 * font.h (font_close_object): Remove.
995 * fontset.c (FONTSET_OBJLIST): Remove.
996 (free_realized_fontset) #if-0 the body, which does nothing.
997 (face_suitable_for_char_p): #if-0, as it's never called.
998 * fontset.h (face_suitable_for_char_p): Remove decl.
999 * xfaces.c (face_at_string_position): Use
1000 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1001 since 0 is always ASCII.
1002
1003 * fns.c (weak_hash_tables): Now static.
1004
1005 * fileio.c: Make symbols static if they're not exported.
1006 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1007 (Vwrite_region_annotation_buffers): Now static.
1008
1009 * eval.c: Make symbols static if they're not exported.
1010 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1011 * lisp.h (backtrace_list): Remove decl.
1012
1013 * emacs.c: Make symbols static if they're not exported.
1014 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1015 (fatal_error_code, fatal_error_signal_hook, standard_args):
1016 Now static.
1017 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1018 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1019 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1020 * lisp.h (fatal_error_signal_hook): Remove decl.
1021 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1022
1023 * editfns.c: Move a (normally-unused) function to its only use.
1024 * editfns.c, lisp.h (get_operating_system_release): Remove.
1025 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1026 worth the hassle of breaking this out.
1027
1028 * xterm.c: Make symbols static if they're not exported.
1029 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1030 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1031 (x_destroy_window, x_delete_display):
1032 Now static.
1033 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1034 (x_mouse_leave): Remove; unused.
1035 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1036 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1037 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1038 Remove decls.
1039 (x_mouse_leave): Declare only if WINDOWSNT.
1040 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1041 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1042 USE_X_TOOLKIT.
1043
1044 * ftxfont.c: Make symbols static if they're not exported.
1045 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1046 HAVE_FREETYPE.
1047 * font.h (ftxfont_driver): Likewise.
1048
1049 * xfns.c: Make symbols static if they're not exported.
1050 (x_last_font_name, x_display_info_for_name):
1051 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1052 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1053 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1054 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1055 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1056 (last_show_tip_args): Now static.
1057 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1058 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1059 (x_screen_planes): Remove; unused.
1060 * dispextern.h (x_screen_planes): Remove decl.
1061
1062 * dispnew.c: Make symbols static if they're not exported.
1063 * dispextern.h (redraw_garbaged_frames, scrolling):
1064 (increment_row_positions): Remove.
1065 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1066 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1067 Now static.
1068 (redraw_garbaged_frames): Remove; unused.
1069
1070 * xfaces.c: Make symbols static if they're not exported.
1071 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1072 Remove decls.
1073 * xterm.h (defined_color): Remove decls.
1074 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1075 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1076 (menu_face_changed_default, defined_color, free_realized_face):
1077 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1078 (ascii_face_of_lisp_face): Remove; unused.
1079
1080 * xdisp.c: Make symbols static if they're not exported.
1081 * dispextern.h (scratch_glyph_row, window_box_edges):
1082 (glyph_to_pixel_coords, set_cursor_from_row):
1083 (get_next_display_element, set_iterator_to_next):
1084 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1085 (show_mouse_face): Remove decls
1086 * frame.h (message_buf_print): Likewise.
1087 * lisp.h (pop_message, set_message, check_point_in_composition):
1088 Likewise.
1089 * xterm.h (set_vertical_scroll_bar): Likewise.
1090 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1091 (message_buf_print, scratch_glyph_row, displayed_buffer):
1092 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1093 (get_next_display_element, show_mouse_face, window_box_edges):
1094 (frame_to_window_pixel_xy, check_point_in_composition):
1095 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1096 (glyph_to_pixel_coords): Remove; unused.
1097
1098 * dired.c (file_name_completion): Now static.
1099
1100 * dbusbind.c (xd_in_read_queued_messages): Now static.
1101
1102 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1103 * data.c (circular_list_error): Remove.
1104
1105 * commands.h (last_point_position, last_point_position_buffer):
1106 (last_point_position_window): Remove decls.
1107 * keyboard.c: Make these variables static.
1108
1109 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1110 decls.
1111 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1112 (iso_code_class, detect_coding, code_convert_region): Now static.
1113 (encode_coding_gap): Remove; unused.
1114
1115 * chartab.c (chartab_chars, chartab_bits): Now static.
1116
1117 * charset.h (charset_iso_8859_1): Remove decl.
1118 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1119 Now static.
1120
1121 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1122 * ccl.c (Vccl_program_table): Now static.
1123 (check_ccl_update): Remove; unused.
1124
1125 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1126 * category.h: ... from here.
1127 * category.c (check_category_table, set_category_set): Now static.
1128
1129 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1130 * lisp.h: Remove these decls.
1131
1132 * buffer.c (buffer_count): Remove unused var.
1133
1134 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1135 so that it's not optimized away.
1136 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1137 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1138 exported only to the debugger.
1139
1140 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1141 * atimer.h (run_all_atimers): Removed; not exported.
1142
1143 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1144 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1145 was inaccessible from Lisp.
1146 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1147 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1148
1149 alloc.c: Import and export fewer symbols, and remove unused items.
1150 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1151 is defined.
1152 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1153 it's not optimized away by whole-program optimization.
1154 (message_enable_multibyte, free_misc): Remove.
1155 (catchlist, handlerlist, mark_backtrace):
1156 Declare only if BYTE_MARK_STACK.
1157 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1158 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1159 (message_enable_multibyte): Remove decl.
1160 (free_misc, interval_free_list, float_block, float_block_index):
1161 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1162 (cons_free_list, last_marked_index):
1163 Now static.
1164 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1165 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1166 (mark_backtrace): Define only if BYTE_MARK_STACK.
1167 * xdisp.c (message_enable_multibyte): Now static.
1168
1169 Declare Lisp_Object Q* variables to be 'static' if not exported.
1170 This makes it easier for human readers (and static analyzers)
1171 to see whether these variables are used from other modules.
1172 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1173 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1174 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1175 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1176 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1177 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1178 * xmenu.c, xselect.c:
1179 Declare Q* vars static if they are not used in other modules.
1180 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1181 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1182 Remove decls of unexported vars.
1183 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1184
1185 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1186
1187 Make Emacs functions such as Fatom 'static' by default.
1188 This makes it easier for human readers (and static analyzers)
1189 to see whether these functions can be called from other modules.
1190 DEFUN now defines a static function. To make the function external
1191 so that it can be used in other C modules, use the new macro DEFUE.
1192 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1193 (Finit_image_library):
1194 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1195 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1196 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1197 Remove decls, since these functions are now static.
1198 (Funintern, Fget_internal_run_time): New decls, since these functions
1199 were already external.
1200
1201 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1202 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1203 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1204 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1205 * keyboard.c, keymap.c, lread.c:
1206 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1207 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1208 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1209 Mark functions with DEFUE instead of DEFUN,
1210 if they are used in other modules.
1211 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1212 decls for now-static functions.
1213 * buffer.h (Fdelete_overlay): Remove decl.
1214 * callproc.c (Fgetenv_internal): Mark as internal.
1215 * composite.c (Fremove_list_of_text_properties): Remove decl.
1216 (Fcomposition_get_gstring): New forward static decl.
1217 * composite.h (Fcomposite_get_gstring): Remove decl.
1218 * dired.c (Ffile_attributes): New forward static decl.
1219 * doc.c (Fdocumntation_property): New forward static decl.
1220 * eval.c (Ffetch_bytecode): New forward static decl.
1221 (Funintern): Remove extern decl; now in .h file where it belongs.
1222 * fileio.c (Fmake_symbolic_link): New forward static decl.
1223 * image.c (Finit_image_library): New forward static decl.
1224 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1225 * intervals.h (Fprevious_property_change):
1226 (Fremove_list_of_text_properties): Remove decls.
1227 * keyboard.c (Fthis_command_keys): Remove decl.
1228 (Fcommand_execute): New forward static decl.
1229 * keymap.c (Flookup_key): New forward static decl.
1230 (Fcopy_keymap): Now static.
1231 * keymap.h (Flookup_key): Remove decl.
1232 * process.c (Fget_process): New forward static decl.
1233 (Fprocess_datagram_address): Mark as internal.
1234 * syntax.c (Fsyntax_table_p): New forward static decl.
1235 (skip_chars): Remove duplicate decl.
1236 * textprop.c (Fprevious_property_change): New forward static decl.
1237 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1238 Now internal.
1239 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1240 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1241
1242 * editfns.c (Fformat): Remove unreachable code.
1243
1244 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1245
1246 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1247 change. (Bug#8496)
1248
1249 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1250
1251 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1252 when at ZV. (Bug#8487)
1253
1254 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1255
1256 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1257 (Bug#8437)
1258 * keyboard.c (parse_tool_bar_item): Likewise.
1259 * sound.c (sound_cleanup, alsa_close): Likewise.
1260 * termcap.c (tgetent): Likewise.
1261 * xfns.c (x_default_font_parameter): Likewise.
1262 * xsettings.c (read_and_apply_settings): Likewise.
1263
1264 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1265 (overrun_check_free): Protoize.
1266
1267 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1270 since callers should never pass a negative size.
1271 Change the signature to match that of plain 'read' and 'write'; see
1272 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1273 * lisp.h: Update prototypes of emacs_write and emacs_read.
1274
1275 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1276
1277 * xdisp.c (redisplay_window): Don't try to determine the character
1278 position of the scroll margin if the window start point w->startp
1279 is outside the buffer's accessible region. (Bug#8468)
1280
1281 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1282
1283 Fix write-region and its subroutines for buffers > 2GB.
1284 * fileio.c (a_write, e_write): Modify declaration of arguments and
1285 local variables to support buffers larger than 2GB.
1286 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1287
1288 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1289 argument, local variables, and return value.
1290
1291 * lisp.h: Update prototypes of emacs_write and emacs_read.
1292
1293 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1294
1295 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1296
1297 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1298
1299 Fix more problems found by GCC 4.6.0's static checks.
1300
1301 * xdisp.c (vmessage): Use a better test for character truncation.
1302
1303 * charset.c (load_charset_map): <, not <=, for optimization,
1304 and to avoid potential problems with integer overflow.
1305 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1306 * casetab.c (set_identity, shuffle): Likewise.
1307 * editfns.c (Fformat): Likewise.
1308 * syntax.c (skip_chars): Likewise.
1309
1310 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1311 This also lets GCC 4.6.0 generate slightly better loop code.
1312
1313 * callint.c (Fcall_interactively): <, not <=, for optimization.
1314 (Fcall_interactively): Count the number of arguments produced,
1315 not the number of arguments given. This is simpler and lets GCC
1316 4.6.0 generate slightly better code.
1317
1318 * ftfont.c: Distingish more carefully between FcChar8 and char.
1319 The previous code passed unsigned char * to a functions like
1320 strlen and xstrcasecmp that expect char *, which does not
1321 conform to the C standard.
1322 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1323 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1324 char * when the C standard requires it.
1325
1326 * keyboard.c (read_char): Remove unused var.
1327
1328 * eval.c: Port to Windows vsnprintf (Bug#8435).
1329 Include <limits.h>.
1330 (SIZE_MAX): Define if the headers do not.
1331 (verror): Do not give up if vsnprintf returns a negative count.
1332 Instead, grow the buffer. This ports to Windows vsnprintf, which
1333 does not conform to C99. Problem reported by Eli Zaretskii.
1334 Also, simplify the allocation scheme, by avoiding the need for
1335 calling realloc, and removing the ALLOCATED variable.
1336
1337 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1338
1339 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1340 But keep the doprint source code for now, as we might revamp it
1341 and use it again (Bug#8435).
1342 * lisp.h (doprnt): Remove.
1343 * Makefile.in (base_obj): Remove doprnt.o.
1344 * deps.mk (doprnt.o): Remove.
1345
1346 error: Print 32- and 64-bit integers portably (Bug#8435).
1347 Without this change, on typical 64-bit hosts error ("...%d...", N)
1348 was used to print both 32- and 64-bit integers N, which relied on
1349 undefined behavior.
1350 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1351 New macro.
1352 * lisp.h (error, verror): Mark as printf-like functions.
1353 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1354 Report overflow in size calculations when allocating printf buffer.
1355 Do not truncate output string at its first null byte.
1356 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1357 Truncate the output at a character boundary, since vsnprintf does not
1358 do that.
1359 * charset.c (check_iso_charset_parameter): Convert internal
1360 character to string before calling 'error', since %c now has the
1361 printf meaning.
1362 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1363 overflow when computing char to be passed to 'error'. Do not
1364 pass Lisp_Object to 'error'; pass the integer instead.
1365 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1366 formatted with plain %d.
1367
1368 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1369
1370 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1371
1372 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1373
1374 * xterm.c (x_catch_errors): Remove duplicate declaration.
1375
1376 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1377
1378 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1379
1380 2011-04-10 Jim Meyering <meyering@redhat.com>
1381
1382 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1383 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1384 return ssize_t not "int", and use size_t as the buffer length.
1385 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1386 * gnutls.h: Update declarations.
1387 * process.c (read_process_output): Use ssize_t, to match.
1388 (send_process): Likewise.
1389
1390 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1391
1392 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1393
1394 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1395
1396 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1397 unsigned char, to match FcChar8 type definition.
1398
1399 * xterm.c (handle_one_xevent):
1400 * xmenu.c (create_and_show_popup_menu):
1401 * xselect.c (x_decline_selection_request)
1402 (x_reply_selection_request): Avoid type-punned deref of X events.
1403
1404 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1405
1406 Fix some uses of `int' instead of EMACS_INT.
1407 * search.c (string_match_1, fast_string_match)
1408 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1409 (scan_buffer, find_next_newline_no_quit)
1410 (find_before_next_newline, search_command, Freplace_match)
1411 (Fmatch_data): Make some `int' variables be EMACS_INT.
1412
1413 * xdisp.c (display_count_lines): 3rd argument and return value now
1414 EMACS_INT. All callers changed.
1415 (pint2hrstr): Last argument is now EMACS_INT.
1416
1417 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1418 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1419 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1420 (decode_coding_utf_16, decode_coding_emacs_mule)
1421 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1422 (decode_coding_ccl, decode_coding_charset)
1423 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1424 (decode_coding_iso_2022, decode_coding_emacs_mule)
1425 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1426 <char_offset, last_offset>: Declare EMACS_INT.
1427 (encode_coding_utf_8, encode_coding_utf_16)
1428 (encode_coding_emacs_mule, encode_invocation_designation)
1429 (encode_designation_at_bol, encode_coding_iso_2022)
1430 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1431 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1432 Declare EMACS_INT.
1433 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1434 (encode_invocation_designation): Last argument P_NCHARS is now
1435 EMACS_INT.
1436 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1437 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1438
1439 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1440 All users changed.
1441
1442 * ccl.c (Fccl_execute_on_string): Declare some variables
1443 EMACS_INT.
1444
1445 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1446
1447 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1448
1449 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1450
1451 * process.c (Fformat_network_address): Doc fix.
1452
1453 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1454
1455 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1456
1457 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1458
1459 * keyboard.c (read_char): Call Lisp function help-form-show,
1460 instead of using internal_with_output_to_temp_buffer.
1461 (Qhelp_form_show): New var.
1462 (syms_of_keyboard): Use DEFSYM macro.
1463
1464 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1465
1466 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1467
1468 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1469
1470 * process.c (Flist_processes): Removed to Lisp.
1471 (list_processes_1): Deleted.
1472
1473 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1474
1475 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1476
1477 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1478
1479 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1480
1481 Fix more problems found by GCC 4.6.0's static checks.
1482
1483 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1484
1485 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1486
1487 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1488
1489 * xdisp.c (vmessage): Mark as a printf-like function.
1490
1491 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1492
1493 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1494
1495 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1496 printf-like functions.
1497 (tiff_load): Add casts to remove these marks before passing them
1498 to system-supplied API.
1499
1500 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1501
1502 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1503 This avoids several warnings with gcc -Wstrict-overflow.
1504 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1505 directly, rather than having caller test rule sign. This avoids
1506 some unnecessary tests.
1507 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1508 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1509 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1510
1511 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1512 (xfont_open): Avoid unnecessary tests.
1513
1514 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1515
1516 * composite.h, composite.c (composition_gstring_put_cache):
1517 Use EMACS_INT, not int, for length.
1518
1519 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1520 breaking out part of COMPOSITION_DECODE_RULE.
1521 (COMPOSITION_DECODE_RULE): Use it.
1522 * composite.c (get_composition_id): Remove unused local vars,
1523 by using the new macro.
1524
1525 * textprop.c (set_text_properties_1): Change while to do-while,
1526 since the condition is always true at first.
1527
1528 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1529 (interval_deletion_adjustment): Return unsigned value.
1530 All uses changed.
1531
1532 * process.c (list_processes_1, create_pty, read_process_output):
1533 (exec_sentinel): Remove vars that were set but not used.
1534 (create_pty): Remove unnecessary "volatile"s.
1535 (Fnetwork_interface_info): Avoid possibility of int overflow.
1536 (read_process_output): Do adaptive read buffering even if carryover.
1537 (read_process_output): Simplify nbytes computation if buffered.
1538
1539 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1540
1541 * syntax.c (scan_words): Remove var that was set but not used.
1542 (update_syntax_table): Use unsigned instead of int.
1543
1544 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1545 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1546 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1547
1548 * print.c (print_error_message): Avoid int overflow.
1549
1550 * font.c (font_list_entities): Redo for clarity,
1551 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1552
1553 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1554 (font_score): Avoid potential overflow in diff calculation.
1555
1556 * fns.c (substring_both): Remove var that is set but not used.
1557 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1558
1559 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1560
1561 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1562 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1563 can always succeed if overflow has undefined behavior.
1564
1565 * search.c (boyer_moore, wordify): Remove vars set but not used.
1566 (wordify): Omit three unnecessary tests.
1567
1568 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1569 All callers changed. This avoids the need for an unused var.
1570
1571 * casefiddle.c (casify_region): Remove var that is set but not used.
1572
1573 * dired.c (file_name_completion): Remove var that is set but not used.
1574
1575 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1576
1577 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1578 (Finsert_file_contents): Remove unnecessary code checking fd.
1579
1580 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1581 Check for integer overflow on size calculations.
1582
1583 * buffer.c (Fprevious_overlay_change): Remove var that is set
1584 but not used.
1585
1586 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1587 Remove vars that are set but not used.
1588 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1589 (timer_check_2): Mark vars as initialized.
1590
1591 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1592
1593 * image.c (lookup_image): Remove var that is set but not used.
1594 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1595
1596 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1597 that are set but not used.
1598
1599 * xfns.c (make_invisible_cursor): Don't return garbage
1600 if XCreateBitmapFromData fails (Bug#8410).
1601
1602 * xselect.c (x_get_local_selection, x_handle_property_notify):
1603 Remove vars that are set but not used.
1604
1605 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1606 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1607
1608 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1609 Remove var that is set but not used.
1610 (scroll_bar_windows_size): Now size_t, not int.
1611 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1612 Check for overflow.
1613
1614 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1615 (map_tty_color) [!defined MSDOS]: Likewise.
1616
1617 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1618
1619 * coding.c: Remove vars that are set but not used.
1620 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1621 All callers changed.
1622 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1623 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1624 (decode_coding_charset): Remove vars that are set but not used.
1625
1626 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1627 that is set but not used.
1628
1629 * print.c (print_object): Remove var that is set but not used.
1630
1631 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1632 The gnulib version avoids calling malloc in the usual case,
1633 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1634 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1635 * filelock.c (current_lock_owner): Likewise.
1636 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1637 * sysdep.c: Include allocator.h, careadlinkat.h.
1638 (emacs_no_realloc_allocator): New static constant.
1639 (emacs_readlink): New function.
1640 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1641 ../lib/careadlinkat.h.
1642
1643 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1644
1645 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1646 first non-nil return value).
1647
1648 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1649
1650 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1651 if not defined (Bug#8403).
1652
1653 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1654
1655 * xdisp.c (display_count_lines): Remove parameter `start',
1656 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1657 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1658 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1659 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1660 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1661 and thereabouts. All callers changed.
1662 (get_per_char_metric): Remove parameter `f', unused since
1663 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1664
1665 2011-04-02 Jim Meyering <meyering@redhat.com>
1666
1667 do not dereference NULL upon failed strdup
1668 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1669 (ns_get_family): Likewise.
1670
1671 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1672
1673 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1674
1675 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1676
1677 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1678 later (Bug#8403).
1679
1680 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1681
1682 Add lexical binding.
1683
1684 * window.c (Ftemp_output_buffer_show): New fun.
1685 (Fsave_window_excursion):
1686 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1687
1688 * lread.c (lisp_file_lexically_bound_p): New function.
1689 (Fload): Bind Qlexical_binding.
1690 (readevalloop): Remove `evalfun' arg.
1691 Bind Qinternal_interpreter_environment.
1692 (Feval_buffer): Bind Qlexical_binding.
1693 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1694 Mark as dynamic.
1695 (syms_of_lread): Declare `lexical-binding'.
1696
1697 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1698
1699 * keyboard.c (eval_dyn): New fun.
1700 (menu_item_eval_property): Use it.
1701
1702 * image.c (parse_image_spec): Use Ffunctionp.
1703
1704 * fns.c (concat, mapcar1): Accept byte-code-functions.
1705
1706 * eval.c (Fsetq): Handle lexical vars.
1707 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1708 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1709 (FletX, Flet): Obey lexical binding.
1710 (Fcommandp): Handle closures.
1711 (Feval): New `lexical' arg.
1712 (eval_sub): New function extracted from Feval. Use it almost
1713 everywhere where Feval was used. Look up vars in lexical env.
1714 Handle closures.
1715 (Ffunctionp): Move from subr.el.
1716 (Ffuncall): Handle closures.
1717 (apply_lambda): Remove `eval_flags'.
1718 (funcall_lambda): Handle closures and new byte-code-functions.
1719 (Fspecial_variable_p): New function.
1720 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1721 but without exporting it to Lisp.
1722
1723 * doc.c (Fdocumentation, store_function_docstring):
1724 * data.c (Finteractive_form): Handle closures.
1725
1726 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1727 interactive spec.
1728
1729 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1730 byte-codes.
1731 (exec_byte_code): New function extracted from Fbyte_code to handle new
1732 calling convention for byte-code-functions. Add new byte-codes.
1733
1734 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1735
1736 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1737
1738 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1739
1740 * xdisp.c (redisplay_internal): Fix prototype.
1741
1742 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1743
1744 * xdisp.c (SCROLL_LIMIT): New macro.
1745 (try_scrolling): Use it when setting scroll_limit. Limit
1746 scrolling to 100 screen lines.
1747 (redisplay_window): Even when falling back on "recentering",
1748 position point in the window according to scroll-conservatively,
1749 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1750
1751 (try_scrolling): When point is above the window, allow searching
1752 as far as scroll_max, or one screenful, to compute vertical
1753 distance from PT to the scroll margin position. This prevents
1754 try_scrolling from unnecessarily failing when
1755 scroll-conservatively is set to a value slightly larger than the
1756 window height. Clean up the case of PT below the margin at bottom
1757 of window: scroll_max can no longer be INT_MAX. When aggressive
1758 scrolling is in use, don't let point enter the opposite scroll
1759 margin as result of the scroll.
1760 (syms_of_xdisp) <scroll-conservatively>: Document the
1761 threshold of 100 lines for never-recentering scrolling.
1762
1763 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1764
1765 * dispextern.h (move_it_by_lines):
1766 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1767 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1768 (message_log_check_duplicate): Remove parameters `prev_bol' and
1769 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1770 (redisplay_internal): Remove parameter `preserve_echo_area',
1771 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1772
1773 * indent.c (Fvertical_motion):
1774 * window.c (window_scroll_pixel_based, Frecenter):
1775 Don't pass `need_y_p' to `move_it_by_lines'.
1776
1777 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1778
1779 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1780 steal a few bits to be more compact.
1781 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1782 Remove unneeded casts.
1783
1784 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1785
1786 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1787
1788 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1789 binding" message (bug#7967).
1790
1791 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1792
1793 Fix more problems found by GCC 4.6.0's static checks.
1794
1795 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1796 Remove unused local var.
1797
1798 * editfns.c (Fmessage_box): Remove unused local var.
1799
1800 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1801 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1802 Omit unused local vars.
1803 * window.c (shrink_windows): Omit unused local var.
1804 * menu.c (digest_single_submenu): Omit unused local var.
1805 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1806 Omit unused local var.
1807
1808 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1809 Don't assume string length fits in int.
1810 (keyremap_step, read_key_sequence): Use size_t for sizes.
1811 (read_key_sequence): Don't check last_real_key_start redundantly.
1812
1813 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1814 instead of alloca (Bug#8344).
1815
1816 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1817 (Fbacktrace_frame): Don't assume nframes fits in int.
1818
1819 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1820
1821 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1822 concerns.
1823
1824 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1825
1826 * cm.c (calccost): Turn while-do into do-while, for clarity.
1827
1828 * keyboard.c (syms_of_keyboard): Use the same style as later
1829 in this function when indexing through an array. This also
1830 works around GCC bug 48267.
1831
1832 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1833
1834 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1835
1836 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1837 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1838
1839 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1840 This avoids undefined behavior on integer overflow, and is a bit
1841 more convenient anyway since it is compared to a size_t variable.
1842
1843 Variadic C functions now count arguments with size_t, not int.
1844 This avoids an unnecessary limitation on 64-bit machines, which
1845 caused (substring ...) to crash on large vectors (Bug#8344).
1846 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1847 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1848 All variadic functions and their callers changed accordingly.
1849 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1850 * data.c (arith_driver, float_arith_driver): Likewise.
1851 * editfns.c (general_insert_function): Likewise.
1852 * eval.c (struct backtrace.nargs, interactive_p)
1853 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1854 (funcall_lambda, mark_backtrace): Likewise.
1855 * fns.c (concat): Likewise.
1856 * frame.c (x_set_frame_parameters): Likewise.
1857 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1858 0 if not found, not -1. All callers changed.
1859
1860 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1861 (stack_copy_size): Now size_t, not int.
1862 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1863
1864 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1865
1866 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1867 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1868 All callers changed.
1869
1870 * lisp.h (multibyte_char_to_unibyte):
1871 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1872 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1873 * character.h (CHAR_TO_BYTE8):
1874 * cmds.c (internal_self_insert):
1875 * editfns.c (general_insert_function):
1876 * keymap.c (push_key_description):
1877 * search.c (Freplace_match):
1878 * xdisp.c (message_dolog, set_message_1): All callers changed.
1879
1880 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1881
1882 * keyboard.c (safe_run_hook_funcall): New function.
1883 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1884 don't set the hook to nil, but remove the offending function instead.
1885 (Qcommand_hook_internal): Remove, unused.
1886 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1887 Vcommand_hook_internal.
1888
1889 * eval.c (enum run_hooks_condition): Remove.
1890 (funcall_nil, funcall_not): New functions.
1891 (run_hook_with_args): Call each function through a `funcall' argument.
1892 Remove `cond' argument, now redundant.
1893 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1894 (Frun_hook_with_args_until_failure): Adjust accordingly.
1895 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1896
1897 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1898
1899 * dispextern.h (string_buffer_position): Remove declaration.
1900
1901 * print.c (strout): Remove parameter `multibyte', unused since
1902 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1903
1904 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1905 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1906 All callers changed.
1907
1908 * w32.c (_wsa_errlist): Use braces for struct initializers.
1909
1910 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1911 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1912 All callers changed.
1913 (string_buffer_position): Likewise. Also, make static (it's never
1914 used outside xdisp.c).
1915 (cursor_row_p): Remove parameter `w', unused since
1916 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1917 (decode_mode_spec): Remove parameter `precision', introduced during
1918 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1919 All callers changed.
1920
1921 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1922
1923 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1924
1925 2011-03-27 Anders Lindgren <andlind@gmail.com>
1926
1927 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1928 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1929 (ns_update_auto_hide_menu_bar): New functions.
1930 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1931 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1932 ns_constrain_all_frames.
1933 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1934 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1935
1936 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1937
1938 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1939
1940 2011-03-27 Glenn Morris <rgm@gnu.org>
1941
1942 * syssignal.h: Replace RETSIGTYPE with void.
1943 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1944 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1945 Replace SIGTYPE with void everywhere.
1946 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1947 * s/template.h (SIGTYPE): Remove commented out definition.
1948
1949 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1950
1951 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1952 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1953
1954 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1955
1956 * w32.c (read_unc_volume): Use parameter `henum', instead of
1957 global variable `wget_enum_handle'.
1958
1959 * keymap.c (describe_vector): Remove parameters `indices' and
1960 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1961 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1962
1963 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1964
1965 * keyboard.c (timer_check): Remove parameter `do_it_now',
1966 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1967 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1968 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1969
1970 * keyboard.c (read_char):
1971 * w32menu.c (w32_menu_display_help):
1972 * xmenu.c (show_help_event, menu_help_callback):
1973 Adjust calls to `show_help_echo'.
1974
1975 * gtkutil.c (xg_maybe_add_timer):
1976 * keyboard.c (readable_events):
1977 * process.c (wait_reading_process_output):
1978 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1979
1980 * insdel.c (adjust_markers_gap_motion):
1981 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1982 (gap_left, gap_right): Don't call it.
1983
1984 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1985
1986 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1987 incurred during fontification.
1988
1989 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1990
1991 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1992 (DEFVAR_PER_BUFFER): Don't pass it.
1993
1994 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1995 (scrolling_window): Don't pass it.
1996
1997 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1998
1999 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2000
2001 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2002 and `suffix'.
2003 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2004 of variables specific to SELinux and computation of `encoded_absname'.
2005
2006 * image.c (XPutPixel): Remove unused variable `height'.
2007
2008 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2009
2010 * unexw32.c (get_section_info): Remove unused variable `section'.
2011
2012 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2013 (system_process_attributes): Remove unused variable `sess'.
2014 (sys_read): Remove unused variable `err'.
2015
2016 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2017 (w32_wnd_proc): Remove unused variable `isdead'.
2018 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2019 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2020 (x_create_tip_frame): Remove unused variable `tem'.
2021
2022 * w32inevt.c (w32_console_read_socket):
2023 Remove unused variable `no_events'.
2024
2025 * w32term.c (x_draw_composite_glyph_string_foreground):
2026 Remove unused variable `width'.
2027
2028 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2029
2030 * w32term.c (x_set_glyph_string_clipping):
2031 Don't pass uninitialized region to CombineRgn.
2032
2033 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2034
2035 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2036 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2037 (Fx_close_connection): Remove unused variable `i'.
2038
2039 * w32font.c (w32font_draw): Return number of glyphs.
2040 (w32font_open_internal): Remove unused variable `i'.
2041 (w32font_driver): Add missing initializer.
2042
2043 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2044 (fill_in_menu): Remove unused variable `items_added'.
2045
2046 * w32term.c (last_mouse_press_frame): Remove static global variable.
2047 (w32_clip_to_row): Remove unused variable `f'.
2048 (x_delete_terminal): Remove unused variable `i'.
2049
2050 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2051 (NOTHING): Remove unused static global variable.
2052 (uniscribe_check_otf): Remove unused variable `table'.
2053 (uniscribe_font_driver): Add missing initializers.
2054
2055 2011-03-23 Julien Danjou <julien@danjou.info>
2056
2057 * term.c (Fsuspend_tty, Fresume_tty):
2058 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2059 * window.c (temp_output_buffer_show):
2060 * insdel.c (signal_before_change):
2061 * frame.c (Fhandle_switch_frame):
2062 * fileio.c (Fdo_auto_save):
2063 * emacs.c (Fkill_emacs):
2064 * editfns.c (save_excursion_restore):
2065 * cmds.c (internal_self_insert):
2066 * callint.c (Fcall_interactively):
2067 * buffer.c (Fkill_all_local_variables):
2068 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2069 Use Frun_hooks.
2070 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2071 unconditionnaly since it does the check itself.
2072
2073 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2074
2075 Fix more problems found by GCC 4.5.2's static checks.
2076
2077 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2078 the first time through the loop, since we know p0 < p1 then.
2079 This also avoids a gcc -Wstrict-overflow warning.
2080
2081 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2082 leading to a memory leak, possible in functions like
2083 load_charset_map_from_file that can allocate an unbounded number
2084 of objects (Bug#8318).
2085
2086 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2087 that could (at least in theory) be that large.
2088
2089 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2090 This is less likely to overflow, and avoids undefined behavior if
2091 overflow does occur. All callers changed. Use strtoul to scan
2092 for the unsigned long integer.
2093 (pint2hrstr): Simplify and tune code slightly.
2094 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2095
2096 * scroll.c (do_scrolling): Work around GCC bug 48228.
2097 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2098
2099 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2100 This also avoids a warning with gcc -Wstrict-overflow.
2101 (validate_x_resource_name): Simplify count usage.
2102 This also avoids a warning with gcc -Wstrict-overflow.
2103
2104 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2105 fail (Bug#8306).
2106
2107 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2108
2109 * process.c (Fmake_network_process): Use socklen_t, not int,
2110 where POSIX says socklen_t is required in portable programs.
2111 This fixes a porting bug on hosts like 64-bit HP-UX, where
2112 socklen_t is wider than int (Bug#8277).
2113 (Fmake_network_process, server_accept_connection):
2114 (wait_reading_process_output, read_process_output):
2115 Likewise.
2116
2117 * process.c: Rename or move locals to avoid shadowing.
2118 (list_processes_1, Fmake_network_process):
2119 (read_process_output_error_handler, exec_sentinel_error_handler):
2120 Rename or move locals.
2121 (Fmake_network_process): Define label "retry_connect" only if needed.
2122 (Fnetwork_interface_info): Fix pointer signedness.
2123 (process_send_signal): Add cast to avoid pointer signedness problem.
2124 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2125 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2126
2127 Make tparam.h and terminfo.c consistent.
2128 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2129 Include tparam.h instead, since it declares them.
2130 * cm.h (PC): Remove extern decl; tparam.h now does this.
2131 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2132 * terminfo.c: Include tparam.h, to check interfaces.
2133 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2134 (tparam): Adjust signature to match interface in tparam.h;
2135 this removes some undefined behavior. Check that outstring and len
2136 are zero, which they always are with Emacs.
2137 * tparam.h (PC, BC, UP): New extern decls.
2138
2139 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2140 (xftfont_open): Rename locals to avoid shadowing.
2141
2142 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2143 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2144 (OTF_TAG_SYM): Omit macro if not needed.
2145 (ftfont_list): Remove unused local.
2146 (get_adstyle_property, ftfont_pattern_entity):
2147 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2148 Rename locals to avoid shadowing.
2149
2150 * xfont.c (xfont_list_family): Mark var as initialized.
2151
2152 * xml.c (make_dom): Now static.
2153
2154 * composite.c (composition_compute_stop_pos): Rename local to
2155 avoid shadowing.
2156 (composition_reseat_it): Remove unused locals.
2157 (find_automatic_composition, composition_adjust_point): Likewise.
2158 (composition_update_it): Mark var as initialized.
2159 (find_automatic_composition): Mark vars as initialized,
2160 with a FIXME (Bug#8290).
2161
2162 character.h: Rename locals to avoid shadowing.
2163 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2164 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2165 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2166 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2167 to avoid shadowing.
2168
2169 * textprop.c (property_change_between_p): Remove; unused.
2170
2171 * intervals.c (interval_start_pos): Now static.
2172
2173 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2174
2175 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2176 Rename locals to avoid shadowing.
2177
2178 * sound.c (wav_play, au_play, Fplay_sound_internal):
2179 Fix pointer signedness.
2180 (alsa_choose_format): Remove unused local var.
2181 (wav_play): Initialize a variable to 0, to prevent undefined
2182 behavior (Bug#8278).
2183
2184 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2185
2186 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2187
2188 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2189 clobbering (Bug#8298).
2190 * sysdep.c (sys_subshell): Likewise.
2191 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2192
2193 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2194 This should get cleaned up, so that child_setup has the
2195 same signature on all platforms.
2196
2197 * callproc.c (call_process_cleanup): Now static.
2198 (relocate_fd): Rename locals to avoid shadowing.
2199
2200 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2201
2202 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2203 not to be necessary, and produces flickering.
2204
2205 2011-03-20 Glenn Morris <rgm@gnu.org>
2206
2207 * config.in: Remove file.
2208
2209 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2210
2211 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2212 are now in src/globals.h.
2213 (syms_of_minibuf): Remove spurious & from previous change.
2214
2215 2011-03-20 Leo <sdl.web@gmail.com>
2216
2217 * minibuf.c (completing-read-function): New variable.
2218 (completing-read-default): Rename from completing-read.
2219 (completing-read): Call completing-read-function.
2220
2221 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2222
2223 * xfaces.c (Fx_load_color_file):
2224 Read color file from absolute filename (bug#8250).
2225
2226 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2227
2228 * makefile.w32-in: Update dependencies.
2229
2230 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2231
2232 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2233
2234 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2235
2236 Fix more problems found by GCC 4.5.2's static checks.
2237
2238 * process.c (make_serial_process_unwind, send_process_trap):
2239 (sigchld_handler): Now static.
2240
2241 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2242 That way, the code declares only the vars that it needs.
2243 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2244 * s/cygwin.h (PTY_ITERATION): Likewise.
2245 * s/darwin.h (PTY_ITERATION): Likewise.
2246 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2247
2248 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2249 * process.c (allocate_pty): Don't declare stb unless it's needed.
2250
2251 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2252 (CONSTANTLIM): Remove; unused.
2253 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2254 Define only if needed.
2255
2256 * unexelf.c (unexec): Name an expression,
2257 to avoid gcc -Wbad-function-cast warning.
2258 Use a different way to cause a compilation error if anyone uses
2259 n rather than nn, a way that does not involve shadowing.
2260 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2261
2262 * deps.mk (unexalpha.o): Remove; unused.
2263
2264 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2265 * unexec.h: New file.
2266 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2267 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2268 Depend on unexec.h.
2269 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2270 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2271 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2272 Change as necessary to match prototype in unexec.h.
2273
2274 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2275 shadowing.
2276 (back_comment, skip_chars): Mark vars as initialized.
2277
2278 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2279 Rename locals to avoid shadowing.
2280
2281 * lread.c (read1): Rewrite so as not to use empty "else".
2282 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2283
2284 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2285
2286 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2287 warning when compiling print.c.
2288
2289 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2290 instead of using an uninitialized var.
2291 (font_sort_entities): Mark var as initialized.
2292
2293 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2294
2295 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2296 pointers to constants.
2297 (font_parse_fcname): Remove unused vars.
2298 (font_delete_unmatched): Now static.
2299 (font_get_spec): Remove; unused.
2300 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2301 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2302 Rename or move locals to avoid shadowing.
2303
2304 * fns.c (require_nesting_list, require_unwind): Now static.
2305 (Ffillarray): Rename locals to avoid shadowing.
2306
2307 * floatfns.c (domain_error2): Define only if needed.
2308 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2309
2310 * alloc.c (mark_backtrace): Move decl from here ...
2311 * lisp.h: ... to here, so that it can be checked.
2312
2313 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2314 (Fdefvar): Rewrite so as not to use empty "else".
2315 (lisp_indirect_variable): Name an expression,
2316 to avoid gcc -Wbad-function-cast warning.
2317 (Fdefvar): Rename locals to avoid shadowing.
2318
2319 * callint.c (quotify_arg, quotify_args): Now static.
2320 (Fcall_interactively): Rename locals to avoid shadowing.
2321 Use const pointer when appropriate.
2322
2323 * lisp.h (get_system_name, get_operating_system_release):
2324 Move decls here, to check interfaces.
2325 * process.c (get_operating_system_release): Move decl to lisp.h.
2326 * xrdb.c (get_system_name): Likewise.
2327 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2328 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2329 some of which prompt warnings from gcc -Wbad-function-cast.
2330 (Fformat_time_string, Fencode_time, Finsert_char):
2331 (Ftranslate_region_internal, Fformat):
2332 Rename or remove local vars to avoid shadowing.
2333 (Ftranslate_region_internal): Mark var as initialized.
2334
2335 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2336 avoid shadowing.
2337
2338 * lisp.h (eassert): Check that the argument compiles, even if
2339 ENABLE_CHECKING is not defined.
2340
2341 * data.c (Findirect_variable): Name an expression, to avoid
2342 gcc -Wbad-function-cast warning.
2343 (default_value, arithcompare, arith_driver, arith_error): Now static.
2344 (store_symval_forwarding): Rename local to avoid shadowing.
2345 (Fmake_variable_buffer_local, Fmake_local_variable):
2346 Mark variables as initialized.
2347 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2348
2349 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2350 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2351 Rename locals to avoid shadowing.
2352 (mark_stack): Move local variables into the #ifdef region where
2353 they're used.
2354 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2355 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2356 needed otherwise.
2357 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2358 (GC_STRING_CHARS): Remove; not used.
2359 (Fmemory_limit): Cast sbrk's returned value to char *.
2360
2361 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2362 avoids undefined behavior in theory.
2363
2364 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2365
2366 Use functions, not macros, for up- and down-casing (Bug#8254).
2367 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2368 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2369 to use the following functions instead of these macros.
2370 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2371 EMACS_INT, since callers assume the returned value fits in int.
2372 (upcase1): Likewise, for UPCASE_TABLE.
2373 (uppercasep, lowercasep, upcase): New static inline functions.
2374 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2375 the race-condition problem in the old DOWNCASE.
2376
2377 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2378 Rename locals to avoid shadowing.
2379 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2380 (regex_compile, re_search_2, re_match_2_internal):
2381 Remove unused local vars.
2382 (FREE_VAR): Rewrite so as not to use empty "else",
2383 which gcc can warn about.
2384 (regex_compile, re_match_2_internal): Mark locals as initialized.
2385 (RETALLOC_IF): Define only if needed.
2386 (WORDCHAR_P): Likewise. This one is never needed, but is used
2387 only in a comment talking about a compiler bug, so put inside
2388 the #if 0 of that comment.
2389 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2390 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2391 Remove; unused.
2392
2393 * search.c (boyer_moore): Rename locals to avoid shadowing.
2394 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2395 (PREV_CHAR_BOUNDARY): Likewise.
2396
2397 * search.c (simple_search): Remove unused var.
2398
2399 * dired.c (compile_pattern): Move decl from here ...
2400 * lisp.h: ... to here, so that it can be checked.
2401 (struct re_registers): New forward decl.
2402
2403 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2404
2405 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2406 All uses changed.
2407 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2408 Rename locals to avoid shadowing.
2409 (Fvertical_motion): Mark locals as initialized.
2410
2411 * casefiddle.c (casify_object, casify_region): Now static.
2412 (casify_region): Mark local as initialized.
2413
2414 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2415
2416 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2417 New macros, so that the caller can use some names other than
2418 gcpro1, gcpro2, etc.
2419 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2420 of the new macros.
2421 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2422 argument, for consistency with GCPRO2_VAR, etc: it is now the
2423 prefix of the variable, not the variable itself. All uses
2424 changed.
2425 * dired.c (directory_files_internal, file_name_completion):
2426 Rename locals to avoid shadowing.
2427
2428 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2429 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2430 dired.c's scmp function, had undefined behavior.
2431 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2432 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2433 * buffer.h: ... to here, because these macros use current_buffer,
2434 and the new implementation with inline functions needs to have
2435 current_buffer in scope now, rather than later when the macros
2436 are used.
2437 (downcase, upcase1): New static inline functions.
2438 (DOWNCASE, UPCASE1): Reimplement using these functions.
2439 This avoids undefined behavior in expressions like
2440 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2441 from race conditions in accessing the global variables
2442 case_temp1 and case_temp2.
2443 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2444 * lisp.h (case_temp1, case_temp2): Remove their decls.
2445 * character.h (ASCII_CHAR_P): Move from here ...
2446 * lisp.h: ... to here, so that the inline functions mentioned
2447 above can use them.
2448
2449 * dired.c (directory_files_internal_unwind): Now static.
2450
2451 * fileio.c (file_name_as_directory, directory_file_name):
2452 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2453 Now static.
2454 (file_name_as_directory): Use const pointers when appropriate.
2455 (Fexpand_file_name): Likewise. In particular, newdir might
2456 point at constant storage, so make it a const pointer.
2457 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2458 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2459 signedness issues.
2460 (Fset_file_times, Finsert_file_contents, auto_save_error):
2461 Rename locals to avoid shadowing.
2462
2463 * minibuf.c (choose_minibuf_frame_1): Now static.
2464 (Ftry_completion, Fall_completions): Rename or remove locals
2465 to avoid shadowing.
2466
2467 * marker.c (bytepos_to_charpos): Remove; unused.
2468
2469 * lisp.h (verify_bytepos, count_markers): New decls,
2470 so that gcc does not warn that these functions aren't declared.
2471
2472 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2473 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2474 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2475 (copy_text): Remove unused local var.
2476
2477 * filelock.c (within_one_second): Now static.
2478 (lock_file_1): Rename local to avoid shadowing.
2479
2480 * buffer.c (fix_overlays_before): Mark locals as initialized.
2481 (fix_start_end_in_overlays): Likewise. This function should be
2482 simplified by using pointers-to-pointers, but that's a different
2483 matter.
2484 (switch_to_buffer_1): Now static.
2485 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2486 (report_overlay_modification): Rename locals to avoid shadowing.
2487
2488 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2489 Fix pointer signedness issue.
2490 (sys_subshell): Mark local as volatile if checking for lint,
2491 to suppress a gcc -Wclobbered warning that does not seem to be right.
2492 (MAXPATHLEN): Define only if needed.
2493
2494 * process.c (serial_open, serial_configure): Move decls from here ...
2495 * systty.h: ... to here, so that they can be checked.
2496
2497 * fns.c (get_random, seed_random): Move extern decls from here ...
2498 * lisp.h: ... to here, so that they can be checked.
2499
2500 * sysdep.c (reset_io): Now static.
2501 (wait_for_termination_signal): Remove; unused.
2502
2503 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2504 (copy_keymap_item, append_key, push_text_char_description):
2505 Now static.
2506 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2507 (DENSE_TABLE_SIZE): Remove; unused.
2508 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2509 (describe_map_tree):
2510 Rename locals to avoid shadowing.
2511
2512 * keyboard.c: Declare functions static if they are not used elsewhere.
2513 (echo_char, echo_dash, cmd_error, top_level_2):
2514 (poll_for_input, handle_async_input): Now static.
2515 (read_char, kbd_buffer_get_event, make_lispy_position):
2516 (make_lispy_event, make_lispy_movement, apply_modifiers):
2517 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2518 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2519 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2520 (read_key_sequence, read_char): Mark locals as initialized.
2521 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2522
2523 * keyboard.h (make_ctrl_char): New decl.
2524 (mark_kboards): Move decl here ...
2525 * alloc.c (mark_kboards): ... from here.
2526
2527 * lisp.h (force_auto_save_soon): New decl.
2528
2529 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2530 (DEFINE_DUMMY_FUNCTION): New macro.
2531 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2532 Use it.
2533 (main): Add casts to avoid warnings
2534 if GCC considers string literals to be constants.
2535
2536 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2537
2538 * dbusbind.c: Pointer signedness fixes.
2539 (xd_signature, xd_append_arg, xd_initialize):
2540 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2541 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2542 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2543 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2544
2545 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2546 if GCC considers string literals to be constants.
2547 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2548
2549 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2550
2551 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2552 (print_preprocess, print_object): New macro to fix last change.
2553
2554 * print.c (print_preprocess): Don't forget font objects.
2555
2556 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2557
2558 * emacs.c (USAGE3): Doc fixes.
2559
2560 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2561
2562 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2563 structure.
2564
2565 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2566
2567 * lisp.h (VWindow_system, Qfile_name_history):
2568 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2569 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2570 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2571
2572 * w32select.c: Don't #include "keyboard.h".
2573 (run_protected): Add extern declaration for waiting_for_input.
2574
2575 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2576 * w32console.c (detect_input_pending, read_input_pending)
2577 (encode_terminal_code):
2578 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2579 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2580 (w32_system_caret_y, Qfile_name_history):
2581 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2582 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2583 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2584 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2585 * w32proc.c (Qlocal, report_file_error):
2586 * w32term.c (Vwindow_system, updating_frame):
2587 * w32uniscribe.c (initialized, uniscribe_font_driver):
2588 Remove unneeded extern declarations.
2589
2590 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2591
2592 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2593
2594 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2595
2596 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2597 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2598 These macros can no longer be used for assignment.
2599
2600 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2601 Assign struct members directly, instead of using BUF_BEGV etc.
2602 (record_buffer_markers, fetch_buffer_markers): New functions for
2603 recording and fetching special buffer markers.
2604 (set_buffer_internal_1, set_buffer_temp): Use them.
2605
2606 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2607
2608 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2609
2610 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2611 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2612
2613 * xdisp.c (hscroll_window_tree):
2614 (reconsider_clip_changes): Use PT instead of BUF_PT.
2615
2616 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2617
2618 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2619 $(EMACS_ROOT)/lib/intprops.h.
2620
2621 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2622
2623 Fix more problems found by GCC 4.5.2's static checks.
2624
2625 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2626 to unsigned char * to avoid compiler diagnostic.
2627 (xg_free_frame_widgets): Make it clear that a local variable is
2628 needed only if USE_GTK_TOOLTIP.
2629 (gdk_window_get_screen): Make it clear that this macro is needed
2630 only if USE_GTK_TOOLTIP.
2631 (int_gtk_range_get_value): New function, which avoids a diagnostic
2632 from gcc -Wbad-function-cast.
2633 (xg_set_toolkit_scroll_bar_thumb): Use it.
2634 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2635 diagnostic from gcc -Wbad-function-cast.
2636 (get_utf8_string, xg_get_file_with_chooser):
2637 Rename locals to avoid shadowing.
2638 (create_dialog): Move locals to avoid shadowing.
2639
2640 * xgselect.c (xg_select): Remove unused var.
2641
2642 * image.c (four_corners_best): Mark locals as initialized.
2643 (gif_load): Initialize transparent_p to zero (Bug#8238).
2644 Mark another local as initialized.
2645 (my_png_error, my_error_exit): Mark with NO_RETURN.
2646
2647 * image.c (clear_image_cache): Now static.
2648 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2649 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2650 (x_edge_detection): Remove unnecessary cast that
2651 gcc -Wbad-function-cast diagnoses.
2652 (gif_load): Fix pointer signedness.
2653 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2654 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2655
2656 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 Improve quality of tests for time stamp overflow.
2659 For example, without this patch (encode-time 0 0 0 1 1
2660 1152921504606846976) returns the obviously-bogus value (-948597
2661 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2662 reports time overflow. See
2663 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2664 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2665 * editfns.c: Include limits.h and intprops.h.
2666 (TIME_T_MIN, TIME_T_MAX): New macros.
2667 (time_overflow): Move earlier, to before first use.
2668 (hi_time, lo_time): New functions, for an accurate test for
2669 out-of-range times.
2670 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2671 (Fget_internal_run_time): Don't assume time_t fits in int.
2672 (make_time): Use list2 instead of Fcons twice.
2673 (Fdecode_time): More accurate test for out-of-range times.
2674 (check_tm_member): New function.
2675 (Fencode_time): Use it, to test for out-of-range times.
2676 (lisp_time_argument): Don't rely on undefined left-shift and
2677 right-shift behavior when checking for time stamp overflow.
2678
2679 * editfns.c (time_overflow): New function, refactoring common code.
2680 (Fformat_time_string, Fdecode_time, Fencode_time):
2681 (Fcurrent_time_string): Use it.
2682
2683 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2684 * dired.c (make_time): Move to ...
2685 * editfns.c (make_time): ... here.
2686 * systime.h: Note the move.
2687
2688 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2689
2690 * fringe.c (update_window_fringes): Remove unused variables.
2691
2692 * unexmacosx.c (copy_data_segment): Also copy __got section.
2693 (Bug#8223)
2694
2695 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2696
2697 * termcap.c [MSDOS]: Include "msdos.h".
2698 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2699 Constify `char *' arguments and their references according to
2700 prototypes in tparam.h.
2701
2702 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2703
2704 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2705 Adapt all references accordingly.
2706
2707 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2708
2709 2011-03-11 Tom Tromey <tromey@redhat.com>
2710
2711 * buffer.c (syms_of_buffer): Remove obsolete comment.
2712
2713 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2714
2715 * termhooks.h (encode_terminal_code): Declare prototype.
2716
2717 * msdos.c (encode_terminal_code): Don't declare prototype.
2718
2719 * term.c (encode_terminal_code): Now external again, used by
2720 w32console.c and msdos.c.
2721
2722 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2723 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2724
2725 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2726
2727 Fix some minor problems found by GCC 4.5.2's static checks.
2728
2729 * fringe.c (update_window_fringes): Mark locals as initialized
2730 (Bug#8227).
2731 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2732
2733 * alloc.c (mark_fringe_data): Move decl from here ...
2734 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2735 to check its interface.
2736 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2737
2738 * fontset.c (free_realized_fontset): Now static.
2739 (Fset_fontset_font): Rename local to avoid shadowing.
2740 (fontset_font): Mark local as initialized.
2741 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2742
2743 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2744
2745 * xselect.c (x_disown_buffer_selections): Remove; not used.
2746 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2747 (x_own_selection, Fx_disown_selection_internal): Rename locals
2748 to avoid shadowing.
2749 (x_handle_dnd_message): Remove local to avoid shadowing.
2750
2751 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2752 so that the caller can use some name other than gcpro1.
2753 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2754 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2755 (Fx_backspace_delete_keys_p):
2756 Use them to avoid shadowing, and rename vars to avoid shadowing.
2757 (x_decode_color, x_set_name, x_window): Now static.
2758 (Fx_create_frame): Add braces to silence GCC warning.
2759 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2760 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2761 Remove unused locals.
2762 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2763 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2764 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2765 macros.
2766
2767 * xterm.h (x_mouse_leave): New decl.
2768
2769 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2770 Remove unused functions.
2771 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2772 (x_calc_absolute_position): Now static.
2773 (XTread_socket): Don't define label "out" unless it's used.
2774 Don't declare local "event" unless it's used.
2775 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2776 unless they are used.
2777 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2778 (x_fatal_error_signal): Remove; not used.
2779 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2780 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2781 (x_error_catcher, x_connection_closed, x_error_handler):
2782 (x_error_quitter, xembed_send_message, x_iconify_frame):
2783 (my_log_handler): Rename locals to avoid shadowing.
2784 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2785 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2786
2787 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2788 Rename or move locals to avoid shadowing.
2789 (tty_defined_color, merge_face_heights): Now static.
2790 (free_realized_faces_for_fontset): Remove; not used.
2791 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2792 does not deduce is never used uninitialized.
2793 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2794 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2795
2796 * terminal.c (store_terminal_param): Now static.
2797
2798 * xmenu.c (menu_highlight_callback): Now static.
2799 (set_frame_menubar): Remove unused local.
2800 (xmenu_show): Rename parameter to avoid shadowing.
2801 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2802 since they might point to immutable storage.
2803 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2804 since it's unused otherwise.
2805
2806 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2807 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2808 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2809 avoids a gcc -Wuninitialized diagnostic.
2810 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2811 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2812 does not deduce are never used uninitialized.
2813
2814 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2815
2816 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2817 * window.c (window_loop, size_window):
2818 (run_window_configuration_change_hook, enlarge_window): Likewise.
2819
2820 * window.c (display_buffer): Now static.
2821 (size_window): Mark variables that gcc -Wuninitialized
2822 does not deduce are never used uninitialized.
2823 * window.h (check_all_windows): New decl, to forestall
2824 gcc -Wmissing-prototypes diagnostic.
2825 * dispextern.h (bidi_dump_cached_states): Likewise.
2826
2827 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2828 shadowing.
2829 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2830 Include <limits.h>.
2831 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2832 and to avoid gcc -Wuninitialized warning.
2833 (load_charset_map): Mark variables that gcc -Wuninitialized
2834 does not deduce are never used uninitialized.
2835 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2836
2837 * coding.c (coding_set_source, coding_set_destination):
2838 Use "else { /* comment */ }" rather than "else /* comment */;"
2839 for clarity, and to avoid gcc -Wempty-body warning.
2840 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2841 a block, when the outer 'i' will do.
2842 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2843 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2844 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2845 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2846 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2847 Rename locals to avoid shadowing.
2848 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2849 * coding.c (emacs_mule_char, encode_invocation_designation):
2850 Now static, since they're not used elsewhere.
2851 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2852 (decode_coding_object, encode_coding_object, detect_coding_system):
2853 (decode_coding_emacs_mule): Mark variables that gcc
2854 -Wuninitialized does not deduce are never used uninitialized.
2855 (detect_coding_iso_2022): Initialize a local variable that might
2856 be used uninitialized. Leave a FIXME because it's not clear that
2857 this initialization is needed. (Bug#8211)
2858 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2859 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2860 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2861 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2862 Remove unused macros.
2863
2864 * category.c (hash_get_category_set): Remove unused local var.
2865 (copy_category_table): Now static, since it's not used elsewhere.
2866 * character.c (string_count_byte8): Likewise.
2867
2868 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2869 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2870
2871 * chartab.c (copy_sub_char_table): Now static, since it's not used
2872 elsewhere.
2873 (sub_char_table_ref_and_range, char_table_ref_and_range):
2874 Rename locals to avoid shadowing.
2875 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2876
2877 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2878 (BIDI_BOB): Remove unused macro.
2879
2880 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2881 deduce are never used uninitialized.
2882 * term.c (encode_terminal_code): Likewise.
2883
2884 * term.c (encode_terminal_code): Now static. Remove unused local.
2885
2886 * tparam.h: New file.
2887 * term.c, tparam.h: Include it.
2888 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2889 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2890 Move these decls to tparam.h, and make them agree with what
2891 is actually in tparam.c. The previous trick of using incompatible
2892 decls in different modules does not conform to the C standard.
2893 All callers of tparam changed to use tparam's actual API.
2894 * tparam.c (tparam1, tparam, tgoto):
2895 Use const pointers where appropriate.
2896
2897 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2898 * cm.h (struct cm): Likewise.
2899 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2900 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2901 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2902 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2903 (turn_on_face, init_tty): Likewise.
2904 * termchar.h (struct tty_display_info): Likewise.
2905
2906 * term.c (term_mouse_position): Rename local to avoid shadowing.
2907
2908 * alloc.c (mark_ttys): Move decl from here ...
2909 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2910
2911 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2912
2913 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2914
2915 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2916
2917 * search.c (compile_pattern_1): Remove argument regp, unused since
2918 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2919 (compile_pattern): Don't pass it.
2920
2921 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2922
2923 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2924 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2925 for ! HAVE_GTK3.
2926 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2927
2928 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2929
2930 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2931 gdk_window_get_screen, gdk_window_get_geometry,
2932 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2933 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2934 (xg_get_pixbuf_from_pixmap): New function.
2935 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2936 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2937 Call xg_get_pixbuf_from_pixmap instead of
2938 gdk_pixbuf_get_from_drawable.
2939 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2940 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2941 (xg_check_special_colors): Use GtkStyleContext and its functions
2942 for HAVE_GTK3.
2943 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2944 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2945 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2946 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2947 Call gtk_widget_get_preferred_size.
2948 (xg_frame_resized): gdk_window_get_geometry only takes 5
2949 parameters.
2950 (xg_win_to_widget, xg_event_is_for_menubar):
2951 Call gdk_x11_window_lookup_for_display.
2952 (xg_set_widget_bg): New function.
2953 (delete_cb): New function.
2954 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2955 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2956 (xg_set_background_color): Call xg_set_widget_bg.
2957 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2958 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2959 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2960 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2961 if ! HAVE_GTK3.
2962 (update_frame_tool_bar): Call gtk_widget_hide.
2963 (xg_initialize): Use GDK_KEY_g.
2964
2965 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2966 if ! HAVE_GTK3
2967 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2968
2969 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2970 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2971 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2972
2973 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2974
2975 * w32xfns.c (select_palette): Check success of RealizePalette against
2976 GDI_ERROR, not zero.
2977
2978 See ChangeLog.11 for earlier changes.
2979
2980 ;; Local Variables:
2981 ;; coding: utf-8
2982 ;; End:
2983
2984 Copyright (C) 2011 Free Software Foundation, Inc.
2985
2986 This file is part of GNU Emacs.
2987
2988 GNU Emacs is free software: you can redistribute it and/or modify
2989 it under the terms of the GNU General Public License as published by
2990 the Free Software Foundation, either version 3 of the License, or
2991 (at your option) any later version.
2992
2993 GNU Emacs is distributed in the hope that it will be useful,
2994 but WITHOUT ANY WARRANTY; without even the implied warranty of
2995 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2996 GNU General Public License for more details.
2997
2998 You should have received a copy of the GNU General Public License
2999 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.