1 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3 Cleanup statistics calculation in Fgarbage_collect.
4 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
5 zombies percentage calculation. Simplify elapsed time calculation.
7 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
9 Generalize marker debugging code under MARKER_DEBUG and use eassert.
10 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
11 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
12 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
13 (replace_range, replace_range_2, del_range_2): Change to eassert.
14 * marker.c (byte_char_debug_check): Adjust style.
16 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
18 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
19 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
20 long-ago-commented-out code that talks about "WIN32".
21 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
24 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
26 Use Gnulib stdalign module (Bug#9772, Bug#9960).
27 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
28 Simplify by using alignof.
29 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
30 * lisp.h: Include <stdalign.h>.
31 (GCALIGNMENT): New macro and constant.
32 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
33 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
34 (stdalign): New macro, if not already defined.
36 2012-07-28 Eli Zaretskii <eliz@gnu.org>
38 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
39 * w32inevt.c: Include w32inevt.h.
40 (w32_read_console_input): New inline function, calls either
41 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
42 w32_console_unicode_input.
43 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
44 (w32_kbd_patch_key, key_event): Use the codepage returned by
45 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
46 (key_event): use uChar.UnicodeChar only if
47 w32_console_unicode_input is non-zero.
49 * w32console.c: Include w32heap.h.
50 <w32_console_unicode_input>: New global variable.
51 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
52 family of Windows, zero otherwise.
54 * w32inevt.h: Declare w32_console_unicode_input.
56 * xdisp.c (init_iterator): Don't reference tip_frame in a build
57 --without-x. (Bug#11742)
59 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
61 Adjust GDB to reflect pvec_type changes (Bug#12036).
62 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
63 2012-07-04 changes to pseudovector representation. Problem
64 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
66 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
68 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
70 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
72 2012-07-27 Eli Zaretskii <eliz@gnu.org>
74 * alloc.c (listn): Fix the order the arguments are consed onto the
77 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
78 enumeration constants, as PURE and HEAP are too general, and clash
79 with other headers and sources, such as gmalloc.c and the
80 MS-Windows system headers. All users changed.
82 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
84 Revert last save_excursion_save and save_excursion_restore changes.
85 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
86 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
88 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
90 Fix recently-introduced typos in Windows port.
91 Reported by Martin Rudalics <rudalics@gmx.at>.
92 * w32.c (init_environment): Replace comma with semicolon.
93 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
95 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
97 Improve GDB symbol export (Bug#12036).
98 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
99 arms of an 'if', not using conditional expressions; otherwise GDB
100 complains about the types in the unevaluated arm when the argument
101 is an integer literal.
102 (xgetint): Simplify expression.
103 * alloc.c (gdb_make_enums_visible): New constant. This ports to
104 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
105 Zaretskii in <http://bugs.gnu.org/12036#13>.
106 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
107 needed now that we have gdb_make_enums_visible.
108 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
109 (enum enum_USE_LSB_TAG):
110 New enum types, packaging up enums that need to be exported to GDB.
112 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
114 Utility function to make a list from specified amount of objects.
115 * lisp.h (enum constype): New datatype.
116 (listn): New prototype.
117 * alloc.c (listn): New function.
118 (Fmemory_use_count, syms_of_alloc): Use it.
119 * buffer.c (syms_of_buffer): Likewise.
120 * callint.c (syms_of_callint): Likewise.
121 * charset.c (define_charset_internal): Likewise.
122 * coding.c (syms_of_coding): Likewise.
123 * keymap.c (syms_of_keymap): Likewise.
124 * search.c (syms_of_search): Likewise.
125 * syntax.c (syms_of_syntax): Likewise.
126 * w32.c (init_environment): Likewise.
127 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
128 * xdisp.c (syms_of_xdisp): Likewise.
129 * xfns.c (syms_of_xfns): Likewise.
131 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
133 Fast save_excursion_save and save_excursion_restore.
134 * lisp.h (struct Lisp_Excursion): New data type.
135 (PVEC_EXCURSION): New pseudovector type.
136 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
137 to deal with it. Adjust comments.
138 (init_marker, attach_marker): New prototype.
139 (unchain_marker): Adjust prototype.
140 * marker.c (attach_marker): Change to global.
141 (init_marker): New function.
142 * alloc.c (Fmake_marker, build_marker): Use it.
143 (build_marker): More easserts.
144 (mark_object): Handle struct Lisp_Excursion.
145 * editfns.c (save_excursion_save, save_excursion_restore):
146 Reimplement to use struct Lisp_Excursion. Add comments.
148 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
150 Fix export of symbols to GDB (Bug#12036).
151 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
152 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
153 emacs.c, as this is a more-suitable home. Had this been done earlier
154 the fix for 12036 would have avoided some of the problems noted in
155 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
156 would have been more obvious.
157 * emacs.c: Do not include <verify.h>; no longer needed.
158 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
159 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
160 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
161 Remove; now done in lisp.h.
162 * lisp.h (PUBLISH_TO_GDB): New macro.
163 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
164 (DATA_SEG_BITS): Use it.
165 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
166 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
167 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
168 not be usable in #if. This simplifies things.
170 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
172 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
174 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
176 Simplify export of symbols to GDB (Bug#12036).
177 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
178 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
179 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
180 Adjust to changes in lisp.h and emacs.c, by using
181 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
182 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
183 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
184 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
185 instead of gdb_valbits.
186 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
187 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
188 instead of gdb_array_mark_flag.
189 (xboolvector): Get size from $->size, not $->header.size.
190 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
191 (xreload, hook-run, hookpost-run): Remove.
192 * emacs.c: Include <verify.h>.
193 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
194 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
196 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
197 (gdb_USE_LSB_TAG): New enum constants.
198 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
199 Also define these as enum constants, so they're visible to GDB.
200 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
201 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
202 as constants, so they're visible to GDB.
203 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
204 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
205 Now enum constants, not macros, so they're visible to GDB.
206 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
207 more convenient now. All uses changed.
208 (VALMASK) [USE_LSB_TAG]: Also define in this case.
209 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
211 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
213 Explicitly free restriction data that are not needed anymore.
214 * editfns.c (save_restriction_restore): Free restriction data.
216 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
218 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
219 add argument, tune behavior, and adjust all callers.
221 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
223 Use typedef for EMACS_INT, EMACS_UINT.
224 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
225 than macros. This simplifies debugging in the usual case, since
226 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
227 and it allows expressions involving EMACS_INT casts.
228 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
230 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
232 * nsterm.m (ns_read_socket): Return early if there is a modal
235 2012-07-25 Martin Rudalics <rudalics@gmx.at>
237 * frame.c (Fredirect_frame_focus): In doc-string don't mention
238 that FOCUS-FRAME can be omitted.
240 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
242 Adjust buffer text indirection counters at the end of Fkill_buffer.
243 * buffer.c (Fkill_buffer): Adjust indirection counters when the
244 buffer is definitely dead. This should really fix an issue reported
245 by Christoph Scholtes again. (Bug#12007).
246 (init_buffer_once): Initialize indirection counters of
247 buffer_defaults and buffer_local_symbols (for sanity and safety).
249 2012-07-24 Eli Zaretskii <eliz@gnu.org>
251 * xdisp.c (init_iterator): Don't compute dimensions of truncation
252 and continuation glyphs on tooltip frames, leave them at zero.
253 Avoids continued lines in tooltips. (Bug#11832)
255 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
257 Simplify copy_overlay.
258 * buffer.c (copy_overlay): Simplify. Use build_marker.
259 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
261 2012-07-23 Eli Zaretskii <eliz@gnu.org>
263 * print.c (print_object): Don't crash when a frame's name is nil
264 or invalid. (Bug#12025)
266 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
267 it signals an error when a tooltip frame is being created.
269 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
271 Cleanup miscellaneous objects allocation and initialization.
272 * alloc.c (allocate_misc): Change to static. Add argument to
273 specify the subtype. Adjust comment and users.
274 (build_overlay): New function.
275 * buffer.c (copy_overlays, Fmake_overlay): Use it.
276 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
277 (allocate_misc): Remove prototype.
278 (build_overlay): Add prototype.
280 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
282 Swap buffer text indirection counters in Fbuffer_swap_text.
283 * buffer.c (Fbuffer_swap_text): Swap indirections too.
284 This avoids crash reported by Christoph Scholtes at
285 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
287 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
289 * nsmenu.m (Popdown_data): New struct.
290 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
292 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
293 (initWithContentRect): Make imgView and contentView non-static
294 and autorelease them. Also autorelease img and matrix (Bug#12005).
295 (dealloc): Remove (Bug#12005).
297 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
299 Adjust consing_since_gc when objects are explicitly freed.
300 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
301 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
302 (free_cons, free_misc): Subtract object size from consing_since_gc.
304 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
306 Simplify and cleanup markers positioning code.
307 * marker.c (attach_marker): More useful eassert.
308 (live_buffer, set_marker_internal): New function.
309 (Fset_marker, set_marker_restricted): Use set_marker_internal.
310 (set_marker_both, set_marker_restricted_both): Use live_buffer.
312 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
314 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
315 as it's limited by the amount of memory, not by INT_MAX.
317 2012-07-21 Eli Zaretskii <eliz@gnu.org>
319 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
320 in special-event-map. See the discussion at
321 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
324 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
325 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
326 Fabrice Popineau <fabrice.popineau@supelec.fr>.
328 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
330 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
331 (conversationIdentifier): Return value is NSInteger.
332 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
334 2012-07-21 Chong Yidong <cyd@gnu.org>
336 * window.c (decode_any_window): Signal an error if the window is
337 on a dead frame (Bug#11984).
339 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
341 Add indirection counting to speed up Fkill_buffer.
342 * buffer.h (struct buffer): New member.
343 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
344 (Fmake_indirect_buffer): Set indirection counter to -1, increment
345 base buffer indirection counter.
346 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
347 (Fkill_buffer): Adjust indirection counters as needed, don't walk
348 through buffer list if indirection counter is 0.
350 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
352 Extend the value returned by Fgarbage_collect with heap statistics.
353 * alloc.c (Qheap): New symbol.
354 (syms_of_alloc): DEFSYM it.
355 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
356 (Fmemory_free): Remove.
357 (syms_of_alloc): Don't defsubr it.
358 * buffer.c (Fcompact_buffer): Remove.
359 (syms_of_buffer): Don't defsubr it.
361 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
363 Make maybe_gc inline.
364 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
365 * lisp.h (consing_since_gc, gc_relative_threshold)
366 (memory_full_cons_threshold): Revert declaration.
367 (maybe_gc): Remove prototype, define as inline.
368 * alloc.c: Remove old commented-out code.
369 (consing_since_gc, gc_relative_threshold)
370 (memory_full_cons_threshold): Revert to global.
373 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
375 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
376 * lisp.h (build_unibyte_string): New function.
377 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
378 * sysdep.c, w32fns.c, xfns.c: Use it.
379 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
380 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
381 Adjust users accordingly.
382 * font.h (font_open_by_name): Adjust prototype.
384 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
386 Cleanup calls to Fgarbage_collect.
387 * lisp.h (maybe_gc): New prototype.
388 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
390 * alloc.c (maybe_gc): New function.
391 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
393 * bytecode.c (MAYBE_GC): Use maybe_gc.
394 * eval.c (eval_sub, Ffuncall): Likewise.
395 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
396 to avoid dependency from auto-save feature.
398 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
400 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
401 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
402 'for_each_per_buffer_object_at'.
403 All uses changed. It's better to use upper-case for macros that
404 cannot be implemented as functions, to give the reader a clue
405 that they're special.
407 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
409 * alloc.c (Fgarbage_collect): Tweak docstring.
411 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
413 Tweak the value returned from Fgarbage_collect again.
414 * alloc.c (Fgarbage_collect): New return value, as confirmed in
415 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
416 Adjust documentation.
417 (total_vector_bytes): Rename to total_vector_slots, adjust
419 (total_free_vector_bytes): Rename to total_free_vector_slots,
421 (Qstring_bytes, Qvector_slots): New symbols.
422 (syms_of_alloc): DEFSYM them.
424 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
426 Buffer compaction primitive which may be used from Lisp.
427 * buffer.c (compact_buffer, Fcompact_buffer): New function.
428 (syms_of_buffer): Register Fcompact_buffer.
429 * alloc.c (Fgarbage_collect): Use compact_buffer.
430 * buffer.h (compact_buffer): New prototype.
431 (struct buffer_text): New member.
433 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
435 New macro to iterate over all buffers, miscellaneous cleanups.
436 * lisp.h (all_buffers): Remove declaration.
437 * buffer.h (all_buffers): Add declaration, with comment.
438 (for_each_buffer): New macro.
439 * alloc.c (Fgarbage_collect, mark_object): Use it.
440 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
441 (init_buffer): Likewise.
442 * data.c (Fset_default): Likewise.
443 * coding.c (code_conversion_restore): Remove redundant check
445 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
447 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
449 Fix bug that created negative-length intervals.
450 * intervals.c (merge_interval_right, merge_interval_left):
451 Do not zero out this interval if it is absorbed by its children,
452 as this interval's total length doesn't change in that case. See
453 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
455 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
457 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
458 when invoking (make-bool-vector N t) and N is a positive
459 multiple of 8 -- the last 8 bits were mistakenly cleared.
461 Remove some struct layout assumptions in bool vectors.
462 * alloc.c (bool_header_size): New constant.
463 (header_size, word_size): Move earlier, as they're now used earlier.
464 Use 'word_size' in a few more places, where it's appropriate.
465 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
466 padding before the data member of a bool vector.
467 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
468 than doing the check by hand with an abort ().
470 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
472 * eval.c (Fdefvar): Don't check constants since we only set the var if
473 it's not yet defined anyway (bug#11904).
475 * lisp.h (last_undo_boundary): Declare new var.
476 * keyboard.c (command_loop_1): Set it.
477 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
478 were auto-added by the command loop (bug#11774).
480 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
482 * w32font.c (Qsymbol): Remove local definition.
483 (syms_of_w32font): Don't DEFSYM it.
485 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
487 Fix sweep_vectors to handle large bool vectors correctly.
488 * alloc.c (sweep_vectors): Account total_vector_bytes for
489 bool vectors larger than VBLOCK_BYTES_MAX.
491 2012-07-18 Chong Yidong <cyd@gnu.org>
493 * frame.c (x_set_frame_parameters): Revert bogus change introduced
494 in 2012-05-25 commit by Paul Eggert (Bug#11738).
496 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
498 Return more descriptive data from Fgarbage_collect.
499 Suggested by Stefan Monnier in
500 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
501 * alloc.c (bounded_number): New function.
502 (total_buffers, total_vectors): New variable.
503 (total_string_size): Rename to total_string_bytes, adjust users.
504 (total_vector_size): Rename to total_vector_bytes, adjust users.
505 (sweep_vectors): Account total_vectors and total_vector_bytes.
506 (Fgarbage_collect): New return value. Adjust documentation.
507 (gc_sweep): Account total_buffers.
508 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
509 (VECTOR_SIZE): Remove.
510 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
511 (Qinterval, Qmisc): New symbols.
512 (syms_of_data): Initialize them.
513 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
514 (Qcons, Qbuffer): New declarations.
516 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
518 * alloc.c (Fmemory_free): Account for memory-free's own storage.
519 Round up, not down. Improve doc.
521 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
523 Restore old code in allocate_string_data to avoid Faset breakage.
524 Reported by Julien Danjou <julien@danjou.info> in
525 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
526 * alloc.c (allocate_string_data): Restore old code with minor
527 adjustments, fix comment to explain this subtle issue.
529 2012-07-17 Eli Zaretskii <eliz@gnu.org>
531 Remove FILE_SYSTEM_CASE.
532 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
534 * fileio.c (FILE_SYSTEM_CASE): Don't define.
535 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
536 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
537 call-process-region passes it through expand-file-name.
539 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
541 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
543 Fix crash when creating indirect buffer (Bug#11917)
544 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
545 Don't handle unbound variables specially if non-zero.
546 (Fbuffer_local_variables): Pass zero.
547 (clone_per_buffer_values): Pass non-zero.
549 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
551 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
552 to make the loop interruptible.
554 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
556 * gnutls.c (emacs_gnutls_handshake): Only retry if
557 GNUTLS_E_INTERRUPTED.
559 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
561 Cleanup and convert miscellaneous checks to eassert.
562 * alloc.c (mark_interval): Fix comment, partially rephrase
563 old comment from intervals.h (see below).
564 * intervals.c (find_interval, adjust_intervals_for_insertion)
565 (delete_interval, adjust_intervals_for_deletion)
566 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
568 (adjust_intervals_for_insertion, make_new_interval):
569 Remove obsolete and unused code.
570 * intervals.h (struct interval): Remove obsolete comment.
571 * textprotp.c (erase_properties): Remove unused code.
572 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
573 (Fremove_list_of_text_properties): Convert to eassert.
575 2012-07-17 Chong Yidong <cyd@gnu.org>
577 * editfns.c (Finsert_char): Doc fix.
579 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
581 Fix previous change to make Fmemory_free always accurate.
582 * alloc.c (make_interval): Update total_free_intervals.
583 (make_float): Likewise for total_free_floats.
584 (free_cons, Fcons): Likewise for total_free_conses.
585 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
586 Likewise for total_free_vector_bytes.
587 (Fmake_symbol): Likewise for total_free_symbols.
588 (bytes_free): Remove.
590 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
592 Simple free memory accounting feature.
593 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
594 (sweep_vectors): Accumulate size of free vectors.
595 (Fgarbage_collect): Setup bytes_free.
596 (Fmemory_free): New function.
597 (syms_of_alloc): Register it.
599 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
601 Cleanup overlays checking.
602 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
603 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
604 eassert and OVERLAYP.
605 (sort_overlays): Change to use OVERLAYP.
607 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
609 * editfns.c (Finsert_char): Make it interactive, and make the
610 second arg optional. Copy interactive spec and docstring from
613 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
615 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
616 Unlike the other wrapped functions, fabs has an unspecified
619 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
621 * nsterm.m (keyDown): Interpret flags without left/right bits
622 as the left key (Bug#11670).
624 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
626 Remove empty and useless init functions.
627 * lisp.h (init_character_once, init_fns, init_image)
628 (init_filelock, init_sound): Remove prototype.
629 * character.c (init_character_once): Remove.
630 * filelock.c (init_filelock): Likewise.
631 * fns.c (init_fns): Likewise.
632 * image.c (init_image): Likewise.
633 * sound.c (init_sound): Likewise.
634 * emacs.c (main): Adjust accordingly.
636 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
638 * gtkutil.h: Tiny cleanups.
639 (use_old_gtk_file_dialog): Remove useless declaration.
640 (xg_uses_old_file_dialog): Add suggested const attribute.
642 2012-07-15 Eli Zaretskii <eliz@gnu.org>
644 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
645 (bidi_paragraph_init): Use it to limit search forward for a strong
646 directional character in abnormally large paragraphs full of
647 neutral or weak characters. (Bug#11943)
649 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
651 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
652 the toolbar (Bug#9451).
653 (xg_make_tool_item): Give the widget event box a transparent
656 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
658 Cleanup basic allocation variables and functions.
659 * alloc.c (ignore_warnings, init_intervals, init_float)
660 (init_cons, init_symbol, init_marker): Remove.
661 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
662 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
663 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
664 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
665 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
666 (staticidx, init_alloc_once, init_strings, free_ablock):
667 Remove redundant initialization.
668 * fns.c (init_weak_hash_tables): Remove.
669 * lisp.h (init_weak_hash_tables): Remove prototype.
671 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
673 Use zero_vector where appropriate.
674 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
676 * lisp.h (zero_vector): New declaration.
677 * font.c (null_vector): Remove.
678 (syms_of_font): Remove initialization and staticpro.
679 (font_list_entities, font_find_for_lface): Change to use zero_vector.
680 * keymap.c (Faccessible_keymaps): Likewise.
682 2012-07-15 Leo Liu <sdl.web@gmail.com>
684 * fringe.c: Fix typo in comments.
686 2012-07-14 Leo Liu <sdl.web@gmail.com>
688 * fringe.c: Add a new bitmap exclamation-mark.
690 2012-07-14 Eli Zaretskii <eliz@gnu.org>
692 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
694 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
695 (HAVE_MENUS): Don't define, defined by editing config.in with
697 (GMALLOC_INHIBIT_VALLOC): Don't define.
698 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
700 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
702 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
704 2012-07-14 Glenn Morris <rgm@gnu.org>
706 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
707 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
708 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
710 2012-07-13 Glenn Morris <rgm@gnu.org>
712 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
714 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
715 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
717 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
719 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
720 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
721 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
722 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
724 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
725 as boolean expression.
726 (x_set_window_size): Remove unused variable toolbar.
727 (ns_get_color_default, ns_mod_to_lisp): Remove.
728 (ns_mouse_position): Remove unused variables xchar and ychar.
729 (ns_compute_glyph_string_overhangs): Remove unused variable face.
730 (ns_set_vertical_scroll_bar): Remove unused variable count.
731 (ns_delete_terminal): Remove unused variable i.
732 (ns_term_init): Remove unused variables r, g and b.
733 (mouseDown): Remove unused variable window.
734 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
735 (initFrameFromEmacs): Remove unused variable vbextra.
736 (mouseEntered): Remove unused variables p and dpyinfo.
737 (mouseExited): Remove unused variables p and r.
738 (ns_define_frame_cursor, ns_clear_frame_area)
739 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
740 (menuDown): Assign [sender tag] to variable and cast the variable.
742 * nsterm.h (menuDown): Add id as type to argument sender.
743 (ns_display_info_for_name): Add Lisp_Object argument.
744 (ns_term_init): Add Lisp_Object argument.
745 (ns_map_event_to_object): Add void argument.
746 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
747 prototype with arguments and only declare if __OBJC__.
748 (nxatoms_of_nsselect): Add void argument.
749 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
750 (ns_alloc_autorelease_pool): Add void argument.
751 (ns_release_autorelease_pool): Add void* argument.
752 (ns_get_defaults_value): Add const char* argument.
754 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
755 (initFromContents): Use SSDATA where appropriate.
756 (ns_update_menubar): Add braces to ambigous if-else.
757 (initWithTitle): Put () around assignment in if statement.
758 (ns_menu_show): Remove unused variables window and keymap.
759 (update_frame_tool_bar): Remove unused variable selected_p.
760 (initWithContentRect): Remove unused variable this_cmd_name.
762 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
764 (setXBMColor): Remove unused variable len.
765 (setPixmapData): Put () around assignment in loop statement.
767 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
768 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
770 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
771 around assignment in loop statement.
772 (nsfont_open): Remove unused variable i.
773 (nsfont_open): Remove unused variable len.
774 (nsfont_draw): Remove unused variable cs.
776 * nsfns.m (x_set_icon_name, ns_set_name_internal)
777 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
778 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
779 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
780 (Fns_font_name, Fns_perform_service)
781 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
782 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
783 (ns_set_name): Remove unused variable view.
784 (x_set_menu_bar_lines): Remove unused variable olines.
785 (x_set_tool_bar_lines): Remove unused variable root_window.
786 (Fns_list_colors): Put () around assignment in while statement.
787 (Fns_perform_service): Remove unused variable len.
788 (Fns_display_usable_bounds): Remove unused variable top.
789 (syms_of_nsfns): Remove unused variable i.
791 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
794 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
796 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
797 and free it with DestroyExceptionInfo (Bug#11558).
799 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
801 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
802 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
803 Set here, not in nt/config.nt.
805 2012-07-13 Eli Zaretskii <eliz@gnu.org>
807 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
808 cursor overflow into the last glyph on display line when the right
809 fringe is off. (Bug#11832)
811 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
813 * xdisp.c (produce_special_glyphs): Now static.
814 * dispextern.h (produce_special_glyphs): Remove decl.
816 2012-07-13 Glenn Morris <rgm@gnu.org>
818 * s/bsd-common, s/cygwin.h: Remove empty files.
819 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
821 * s/usg5-4-common.h (USG, USG5):
822 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
823 * s/sol2-6.h (SOLARIS2):
824 * s/irix6-5.h (IRIX6_5):
825 * s/hpux10-20.h (USG, USG5, HPUX):
826 * s/gnu-linux.h (USG, GNU_LINUX):
827 * s/freebsd.h (BSD_SYSTEM):
828 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
829 * s/cygwin.h (CYGWIN):
830 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
831 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
833 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
835 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
837 2012-07-13 Glenn Morris <rgm@gnu.org>
839 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
841 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
843 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
844 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
846 2012-07-12 Glenn Morris <rgm@gnu.org>
848 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
850 * process.c (init_process_emacs): Rename from init_process.
851 The old name is also the name of a Mach system call.
852 * lisp.h, emacs.c: Update for this name change.
853 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
856 2012-07-12 Eli Zaretskii <eliz@gnu.org>
858 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
859 memmove call that removes glyphs covered by the left truncation
860 glyph. Improve commentary.
861 (display_line): Fix display of continuation glyphs on GUI frames
862 when the right fringe is turned off and variable-size fonts are
863 used in the window. Move the code that appends a stretch glyph to
864 produce_special_glyphs, so that it could be used for truncation
865 and continuation glyphs alike.
866 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
867 glyph of a suitably computed width, to align the special glyphs at
868 the window margin. Code moved from display_line. (Bug#11832)
870 2012-07-12 Glenn Morris <rgm@gnu.org>
872 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
874 * s/gnu-linux.h, s/hpux10-20.h:
875 Do not unconditionally define HAVE_XRMSETDATABASE.
877 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
879 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
881 Fix typos that broke OS X build.
882 Reported by Randal L. Schwartz in
883 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
884 * nsterm.m (ns_timeout): Add missing local decl.
885 (ns_get_color): snprintf -> sprintf, to fix typo.
887 2012-07-12 Glenn Morris <rgm@gnu.org>
889 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
890 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
891 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
892 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
894 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
895 Move PTY_OPEN to configure.
897 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
898 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
899 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
901 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
903 Use empty_unibyte_string where applicable.
904 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
905 * lread.c (read1): Likewise.
906 * xsettings.c (syms_of_xsettings): Likewise.
908 2012-07-12 Glenn Morris <rgm@gnu.org>
910 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
911 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
912 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
913 * s/hpux10-20.h (RUN_TIME_REMAP):
914 * s/bsd-common.h (TABDLY): Move to configure.
916 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
918 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
920 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
921 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
923 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
925 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
926 * s/template.h: Move NARROWPROTO to configure.
928 2012-07-11 Glenn Morris <rgm@gnu.org>
930 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
931 unused since 2011-01-17 change to systty.h.
933 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
934 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
935 Move HAVE_PTYS and HAVE_SOCKETS to configure.
937 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
939 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
941 2012-07-11 Glenn Morris <rgm@gnu.org>
943 * s/darwin.h, s/gnu-linux.h, s/template.h:
944 Move INTERRUPT_INPUT to configure.
946 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
948 Minor adjustments to interning code.
949 * lisp.h (intern, intern_c_string): Redefine as static inline
950 wrappers for intern_1 and intern_c_string_1, respectively.
951 (intern_1, intern_c_string_1): Rename prototypes.
952 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
954 * font.c (font_intern_prop): Likewise. Adjust comment.
955 * w32font.c (intern_font_name): Likewise.
957 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
959 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
961 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
962 of Fcar/Fcdr if possible.
963 * font.c (check_otf_features): Likewise.
964 * fontset.c (Fnew_fontset): Likewise.
965 * gnutls.c (Fgnutls_boot): Likewise.
966 * minibuf.c (read_minibuf): Likewise.
967 * msdos.c (IT_set_frame_parameters): Likewise.
968 * xmenu.c (Fx_popup_dialog): Likewise.
969 * w32menu.c (Fx_popup_dialog): Likewise.
971 2012-07-11 Glenn Morris <rgm@gnu.org>
973 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
974 since nothing has defined it on these platforms.
976 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
977 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
979 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
980 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
981 Move CLASH_DETECTION to configure.
983 * s/gnu.h: Remove file, which is now empty.
985 * s/gnu.h, s/gnu-linux.h:
986 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
988 2012-07-11 John Wiegley <johnw@newartisans.com>
990 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
991 function attribute, so we only use it if it exists in the
994 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
996 Avoid call to strlen in fast_c_string_match_ignore_case.
997 * search.c (fast_c_string_match_ignore_case): Change to use
998 length argument. Adjust users accordingly.
999 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1001 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1003 Assume mkdir, rmdir.
1004 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1005 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1008 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1011 * s/hpux10-20.h (HAVE_PERROR): Remove.
1012 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1013 Remove dummy definition, as this problem was obsolete long ago.
1016 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1018 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1020 Avoid calls to strlen in font processing functions.
1021 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1022 (font_open_by_name): Change to use length argument. Adjust
1024 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1026 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1027 Change to return ptrdiff_t.
1028 (xfont_list_pattern, xfont_match): Use length returned by
1029 xfont_decode_coding_xlfd.
1030 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1032 2012-07-11 Glenn Morris <rgm@gnu.org>
1034 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1035 Move DONT_REOPEN_PTY to configure.
1037 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1038 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1040 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1042 Remove "#define unix" that is no longer needed (Bug#11905).
1043 * s/aix4-2.h (unix): Remove; no longer needed.
1045 EMACS_TIME simplification (Bug#11875).
1046 This replaces macros (which typically do not work in GDB)
1047 with functions, typedefs and enums, making the code easier to debug.
1048 The functional style also makes code easier to read and maintain.
1049 * systime.h: Include <sys/time.h> on all hosts, not just if
1050 WINDOWSNT, since 'struct timeval' is needed in general.
1051 (EMACS_TIME): Now a typedef, not a macro.
1052 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1054 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1055 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1056 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1057 (EMACS_TIME_LE): Now functions, not macros.
1058 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1059 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1060 which are not functions. All uses rewritten to use:
1061 (make_emacs_time): New function.
1062 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1063 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1064 not functions. All uses rewritten to use the following, respectively:
1065 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1066 (add_emacs_time, sub_emacs_time): New functions.
1067 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1068 * fileio.c (Fcopy_file):
1069 * xterm.c (XTflash): Get the current time closer to when it's used.
1070 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1072 * bytecode.c (targets): Suppress -Woverride-init warnings.
1074 Simplify by avoiding confusing use of strncpy etc.
1075 * doc.c (Fsnarf_documentation):
1076 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1077 * frame.c (Fmake_terminal_frame):
1078 * gtkutil.c (get_utf8_string):
1080 * nsmenu.m (ns_update_menubar):
1081 * regex.c (regerror):
1082 Prefer memcpy to strncpy and strncat when either will do.
1083 * fileio.c (Fsubstitute_in_file_name):
1084 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1085 (menu_separator_name_p):
1086 * nsmenu.m (ns_update_menubar):
1087 Prefer memcmp to strncmp when either will do.
1088 * nsterm.m: Include <ftoastr.h>.
1090 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1091 Prefer snprintf to strncpy.
1092 * nsterm.m (ns_term_init):
1093 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1094 * nsterm.m (ns_term_init):
1095 Avoid the need for strncpy, by using build_string or
1096 make_unibyte_string directly. Use dtoastr, not snprintf.
1097 * process.c (Fmake_network_process): Diagnose service names that
1098 are too long, rather than silently truncating them or creating
1099 non-null-terminated names.
1100 (Fnetwork_interface_info): Likewise, for interface names.
1101 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1102 Prefer sprintf to strncat.
1103 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1104 Prefer vsnprintf to vsprintf + strncpy.
1106 2012-07-10 Glenn Morris <rgm@gnu.org>
1108 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1109 Clarify fallback case.
1111 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1113 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1114 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1115 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1116 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1117 where argument type is known to be a Lisp_Cons.
1119 2012-07-10 Tom Tromey <tromey@redhat.com>
1121 * bytecode.c (BYTE_CODE_THREADED): New macro.
1122 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1123 (enum byte_code_op): New type.
1124 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1125 (exec_byte_code): Use them. Use token threading when applicable.
1127 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1129 Optimize pure C strings initialization.
1130 * lisp.h (make_pure_string): Fix prototype.
1131 (build_pure_c_string): New function, defined as static inline. This
1132 provides a better opportunity to optimize away calls to strlen when
1133 the function is called with compile-time constant argument.
1134 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1135 argument, adjust users accordingly. Use build_pure_c_string where
1137 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1138 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1139 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1141 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1143 Avoid calls to strlen in miscellaneous functions.
1144 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1145 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1146 * lread.c (openp): Likewise.
1148 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1150 Avoid calls to strlen in path processing functions.
1151 * fileio.c (file_name_as_directory): Add comment. Change to add
1152 srclen argument and return the length of result. Adjust users
1154 (directory_file_name): Fix comment. Change to add srclen argument,
1155 swap 1st and 2nd arguments to obey the common convention. Adjust
1157 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1159 2012-07-10 Glenn Morris <rgm@gnu.org>
1161 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1162 Move PENDING_OUTPUT_COUNT definition to configure.
1164 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1165 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1166 * s/gnu.h (DATA_START): Move definitions to configure.
1168 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1169 We include usg5-4-common.h, which defines them both.
1171 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1172 O_RDONLY already includes it).
1174 Stop ns builds setting the EMACSLOADPATH environment variable.
1175 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1176 Now it does not set EMACSLOADPATH, just returns the load-path string.
1177 * nsterm.h: Update accordingly.
1178 * lread.c [HAVE_NS]: Include nsterm.h.
1179 (init_lread) [HAVE_NS]: Use ns_load_path.
1180 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1182 2012-07-09 Glenn Morris <rgm@gnu.org>
1184 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1185 since the included bsd-common.h does so.
1187 Stop ns builds setting the EMACSPATH environment variable.
1188 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1189 (ns_init_paths): Do not set EMACSPATH.
1190 * nsterm.h (ns_exec_path): Add it.
1191 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1194 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1196 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1198 * process.c (wait_reading_process_output): 'waitchannels' was unset
1199 when read_kbd || !NILP (wait_for_cell); fix this.
1201 Add GCC-style 'const' attribute to functions that can use it.
1202 * character.h (char_resolve_modifier_mask):
1203 * keyboard.h (make_ctrl_char):
1204 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1205 (init_character_once, next_almost_prime, init_fns, init_image)
1206 (flush_pending_output, init_sound):
1207 * mem-limits.h (start_of_data):
1208 * menu.h (finish_menu_items):
1209 Add ATTRIBUTE_CONST.
1210 * emacs.c (DEFINE_DUMMY_FUNCTION):
1211 Declare the dummy function with ATTRIBUTE_CONST.
1212 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1213 Add decls with ATTRIBUTE_CONST.
1215 Minor improvements to make_formatted_string.
1216 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1217 where int is good enough, as vsprintf returns an int.
1218 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1220 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1222 Use make_formatted_string to avoid double length calculation.
1223 * lisp.h (make_formatted_string): New prototype.
1224 * alloc.c (make_formatted_string): New function.
1225 * buffer.c (Fgenerate_new_buffer_name): Use it.
1226 * dbus.c (syms_of_dbusbind): Likewise.
1227 * editfns.c (Fcurrent_time_zone): Likewise.
1228 * filelock.c (get_boot_time): Likewise.
1229 * frame.c (make_terminal_frame, set_term_frame_name)
1230 (x_report_frame_params): Likewise.
1231 * image.c (gs_load): Likewise.
1232 * minibuf.c (get_minibuffer): Likewise.
1233 * msdos.c (dos_set_window_size): Likewise.
1234 * process.c (make_process): Likewise.
1235 * xdisp.c (ensure_echo_area_buffers): Likewise.
1236 * xsettings.c (apply_xft_settings): Likewise.
1238 2012-07-09 Glenn Morris <rgm@gnu.org>
1240 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1241 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1242 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1243 * nsterm.h (ns_etc_directory): Add it.
1244 * callproc.c [HAVE_NS]: Include nsterm.h.
1245 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1247 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1249 Move marker debugging code under MARKER_DEBUG.
1250 * marker.c (MARKER_DEBUG): Move marker debugging code under
1251 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1252 for bootstrap with --enable-checking (~3x slowdown reported
1253 by Juanma Barranquero <lekktu@gmail.com>).
1254 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1256 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1258 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1259 See <http://bugs.gnu.org/11825#29>.
1261 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1263 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1264 has no font, use the frame's font. (Bug#11813)
1265 (display_line): Add commentary about displaying truncation glyphs
1267 (produce_special_glyphs): Move here from term.c.
1269 * term.c (produce_special_glyphs): Move to xdisp.c.
1271 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1274 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1276 * xdisp.c (display_line): Avoid warning about implicit declaration
1279 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1281 * lisp.h: Remove empty conditional.
1283 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1285 * lread.c (load_path_check): Now static.
1287 Fix some minor --with-ns problems found by static checking.
1288 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1289 (x_set_font) [!HAVE_X_WINDOWS]:
1290 * image.c (xpm_load_image) [HAVE_NS]:
1291 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1292 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1293 Remove unused local.
1294 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1295 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1296 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1297 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1298 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1299 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1300 Fix pointer signedness problem.
1301 * xfaces.c (FRAME_X_FONT_TABLE):
1302 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1304 2012-07-07 Glenn Morris <rgm@gnu.org>
1306 * lread.c (load_path_check): New function, split from init_lread.
1307 (init_lread): Reorganize. Motivation:
1308 If EMACSLOADPATH is set, check/warn about that rather than the
1309 defaults, which we are not going to use. Hence we can remove
1310 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1311 Don't warn if site-lisp directories are missing.
1312 If not installed, start from a blank load-path, since
1313 PATH_LOADSEARCH refers to the eventual installation directories.
1315 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1317 Support truncation and continuation glyphs on GUI frames, when
1318 fringes are disabled. (Bug#11832)
1319 * xdisp.c (init_iterator): Get dimensions of truncation and
1320 continuation glyphs even if on GUI frames. Adjust
1321 it->last_visible_x on GUI frames when the left or right fringes,
1322 or both, are absent.
1323 (start_display, move_it_in_display_line_to): Handle the case of a
1324 GUI frame without a fringe to display continuation or truncation
1326 (insert_left_trunc_glyphs): Support GUI frames: make sure
1327 truncation glyphs overwrite enough glyphs from the current line to
1328 have sufficient space in pixels.
1329 (display_line): Support truncation and continuation glyphs on GUI
1330 frames. If some spare pixels are left on the line after inserting
1331 the truncation glyphs, fill that space with a stretch glyph of a
1332 suitably computed width.
1334 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1335 produce_glyphs, to support GUI sessions.
1337 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1339 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1341 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1343 Do not require float-time's arg to fit in time_t (Bug#11825).
1344 This works better on hosts where time_t is unsigned, and where
1345 float-time is applied to the (negative) difference between two times.
1346 * editfns.c (decode_time_components): Last arg is now double *,
1347 not int *, and means to store all the result as a double, without
1348 worrying about whether the seconds part fits in time_t.
1349 All callers changed.
1350 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1351 All callers changed.
1352 (Ffloat_time): Do not fail merely because the specified time falls
1353 outside of time_t range.
1355 2012-07-07 Glenn Morris <rgm@gnu.org>
1357 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1358 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1359 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1361 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1363 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1364 Update dependencies.
1366 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1368 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1370 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1371 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1372 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1373 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1374 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1375 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1377 * xfont.c (compare_font_names): Redo to omit the need for casts.
1379 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1381 * xfns.c (Fx_change_window_property): Doc fix.
1382 * w32fns.c (Fx_change_window_property): Doc fix.
1384 * w32fns.c (Fx_window_property): Accept the same arguments as the
1385 X Windows version. Doc fix.
1386 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1388 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1389 Eli Zaretskii <eliz@gnu.org>
1391 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1392 Windows-specific code from nt/config.nt moved here.
1393 Obsolete settings removed.
1395 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1397 * process.c: Avoid unnecessary calls to gettime.
1398 (wait_reading_process_output): Don't get the time of day
1399 when gobbling data immediately and not waiting, as there's no need
1400 for it in that case. This removes a FIXME.
1402 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1404 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1405 is defined (Bug#11768).
1407 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1409 Fix marker debugging code.
1410 * marker.c (byte_char_debug_check): Do not perform the check
1411 if buffer is not multibyte.
1412 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1413 Call byte_char_debug_check with correct arguments.
1415 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1417 Compile marker debugging code only if ENABLE_CHECKING is defined.
1418 * marker.c (byte_char_debug_check, count_markers):
1419 Use only if ENABLE_CHECKING is defined.
1420 (byte_debug_flag): Remove.
1421 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1422 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1424 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1426 Avoid code repetition in marker-related functions.
1427 * marker.c (attach_marker): New function.
1428 (Fset_marker, set_marker_restricted, set_marker_both)
1429 (set_marker_restricted_both): Use it.
1430 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1431 Consistently rename charno to charpos.
1432 (marker_position): Add eassert.
1433 (marker_byte_position): Convert to eassert.
1435 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1437 Simplify list operations in unchain_overlay and unchain_marker.
1438 * buffer.c (unchain_overlay): Simplify. Add comment.
1439 * marker.c (unchain_marker): Simplify. Fix comments.
1441 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1443 Introduce fast path for the widely used marker operation.
1444 * alloc.c (build_marker): New function.
1445 * lisp.h (build_marker): New prototype.
1446 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1447 * composite.c (autocmp_chars): Likewise.
1448 * editfns.c (buildmark): Remove.
1449 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1450 (save_restriction_save): Use build_marker.
1451 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1452 * window.c (save_window_save): Likewise.
1454 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1456 Do not use Fdelete_overlay in delete_all_overlays
1457 to avoid redundant calls to unchain_overlay.
1458 * buffer.c (drop_overlay): New function.
1459 (delete_all_overlays, Fdelete_overlay): Use it.
1460 * minibuf.c (get_minibuffer): Fix comment.
1462 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1464 Port to OpenBSD 5.1 amd64.
1465 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1466 This is needed for OpenBSD, and should be harmless on all BSD systems.
1467 Also, include <sys/sysctl.h>, as it should be available on all
1468 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1469 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1470 use p_pid member, not kp_proc.pid.
1472 2012-07-06 Glenn Morris <rgm@gnu.org>
1474 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1476 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1478 More xmalloc and related cleanup.
1479 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1480 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1481 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1482 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1483 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1484 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1485 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1486 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1487 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1489 Omit needless casts involving void * pointers and allocation.
1490 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1491 as the former is more robust if P's type is changed.
1492 Prefer xzalloc to xmalloc + memset 0.
1493 Simplify malloc-or-realloc to realloc.
1494 Don't worry about xmalloc returning a null pointer.
1495 Prefer xstrdup to xmalloc + strcpy.
1496 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1498 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1499 alloca of a constant.
1501 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1503 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1504 hscroll is larger than the line width. Fixes long and futile
1505 looping inside extend_face_to_end_of_line (on a TTY) producing
1506 glyphs that are not needed and thrown away.
1508 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1510 * marker.c (set_marker_restricted_both): Simplify by using
1513 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1515 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1517 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1519 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1520 not defined (Bug#11768).
1521 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1522 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1523 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1524 followed by gtk_box_set_homogeneous (Bug#11768).
1525 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1526 (update_theme_scrollbar_width, xg_create_scroll_bar):
1527 Use gtk_scrollbar_new (Bug#11768).
1528 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1529 (is_box_type): New function (Bug#11768).
1530 (xg_tool_item_stale_p): Call is_box_type.
1531 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1532 with default display (Bug#11768).
1534 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1536 * xdisp.c (window_hscroll_limited): New function.
1537 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1538 coordinates when window's hscroll is set to insanely large
1541 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1543 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1544 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1546 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1549 * lisp.h (xzalloc): New prototype. Omit needless casts.
1550 * alloc.c (xzalloc): New function. Omit needless casts.
1551 * charset.c: Omit needless casts. Convert all calls to
1552 xmalloc with following memset to xzalloc.
1553 * dispnew.c: Likewise.
1554 * fringe.c: Likewise.
1555 * image.c: Likewise.
1556 * sound.c: Likewise.
1558 * w32fns.c: Likewise.
1559 * w32font.c: Likewise.
1560 * w32term.c: Likewise.
1561 * xfaces.c: Likewise.
1563 * xterm.c: Likewise.
1564 * atimer.c: Omit needless casts.
1565 * buffer.c: Likewise.
1566 * callproc.c: Likewise.
1568 * coding.c: Likewise.
1569 * composite.c: Likewise.
1571 * doprnt.c: Likewise.
1572 * editfns.c: Likewise.
1573 * emacs.c: Likewise.
1575 * filelock.c: Likewise.
1577 * gtkutil.c: Likewise.
1578 * keyboard.c: Likewise.
1580 * lread.c: Likewise.
1581 * minibuf.c: Likewise.
1582 * msdos.c: Likewise.
1583 * print.c: Likewise.
1584 * process.c: Likewise.
1585 * region-cache.c: Likewise.
1586 * search.c: Likewise.
1587 * sysdep.c: Likewise.
1588 * termcap.c: Likewise.
1589 * terminal.c: Likewise.
1590 * tparam.c: Likewise.
1591 * w16select.c: Likewise.
1593 * w32reg.c: Likewise.
1594 * w32select.c: Likewise.
1595 * w32uniscribe.c: Likewise.
1596 * widget.c: Likewise.
1597 * xdisp.c: Likewise.
1598 * xmenu.c: Likewise.
1600 * xselect.c: Likewise.
1602 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1604 * fileio.c (time_error_value): Check the right error number.
1605 Problem reported by Troels Nielsen in
1606 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1608 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1610 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1611 This should be fixed in a better way; see Eli Zaretskii in
1612 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1613 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1615 * fileio.c (time_error_value): Rename from special_mtime.
1616 The old name's problems were noted by Eli Zaretskii in
1617 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1619 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1620 This variable's comment says Emacs needs at least one GDB-visible
1621 symbol of type enum pvec_type, to work around GDB problems.
1622 The symbol's value doesn't matter.
1624 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1625 that causes compilation to fail on pre-C99 compilers.
1627 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1629 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1630 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1632 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1634 * buffer.c (init_buffer_once): Fix initialization of
1635 headers for buffer_defaults and buffer_local_symbols.
1636 Reported by Juanma Barranquero <lekktu@gmail.com>.
1638 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1640 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1641 * lisp.h (enum pvec_type): Use fewer bits.
1642 (PSEUDOVECTOR_SIZE_BITS): New constant.
1643 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1644 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1645 change in pvec_type.
1646 (PSEUDOVECTOR_TYPEP): New macro.
1647 (TYPED_PSEUDOVECTORP): Use it.
1648 * fns.c (internal_equal): Adapt code to extract pvectype.
1649 * emacs.c (gdb_pvec_type): Update type.
1650 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1651 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1652 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1653 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1654 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1655 abusing vector->header.next.nbytes.
1656 (live_vector_p): Use PVEC_TYPE.
1657 (mark_object): Adapt code to extract pvectype. Use switch.
1659 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1661 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1662 Tighten new eassert a bit.
1664 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1666 Fix compilation with --enable-gcc-warnings and -O1
1668 * doprnt.c (doprnt): Change type of tem to int, initialize
1669 to avoid compiler warning. Add eassert.
1670 * search.c (simple_search): Initialize match_byte to avoid
1671 compiler warning. Add eassert.
1673 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1675 Avoid weird behavior with large horizontal scrolls.
1676 Without this change, for example, large hscroll values would
1677 mess up Emacs's display on Fedora 15 x86, presumably due to
1678 overflows in int calculations in the display code.
1679 Also, if buffers had long lines, Emacs would freeze.
1680 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1681 (set_window_hscroll): New function, containing the old guts of
1682 Fset_window_hscroll. Return the clipped value.
1683 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1684 This avoids the need to check against PTRDIFF_MAX.
1686 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1688 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1690 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1692 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1694 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1695 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1696 since GCC 4.4.6 issues a bogus warning for them.
1698 Fix bugs in file timestamp newness comparisons.
1699 * fileio.c (Ffile_newer_than_file_p):
1700 * lread.c (Fload): Use full timestamp resolution of files,
1701 not just the 1-second resolution, so that files that are only
1702 slightly newer still count as newer.
1703 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1704 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1706 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1708 * fileio.c: Improve handling of file time marker. (Bug#11852)
1709 (special_mtime): New function.
1710 (Finsert_file_contents, Fverify_visited_file_modtime):
1711 Use it to set special mtime values consistently.
1713 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1715 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1716 marker for non-existing file. (Bug#11852)
1718 2012-07-03 Glenn Morris <rgm@gnu.org>
1720 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1721 and did not make it into globals.h).
1723 2012-07-03 Tom Tromey <tromey@redhat.com>
1725 * window.c (Fset_window_margins, Fset_window_fringes)
1726 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1727 * textprop.c (Fprevious_property_change): No longer static.
1728 * syntax.c (Fsyntax_table_p): No longer static.
1729 * process.c (Fget_process, Fprocess_datagram_address): No longer
1731 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1732 * keyboard.c (Fcommand_execute): No longer static.
1734 * insdel.c (Fcombine_after_change_execute): No longer static.
1735 * image.c (Finit_image_library): No longer static.
1736 * fileio.c (Fmake_symbolic_link): No longer static.
1737 * eval.c (Ffetch_bytecode): No longer static.
1738 * editfns.c (Fuser_full_name): No longer static.
1739 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1741 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1743 * dired.c (Ffile_attributes): No longer static.
1744 * composite.c (Fcomposition_get_gstring): No longer static.
1745 * callproc.c (Fgetenv_internal): No longer static.
1747 * ccl.h: Remove EXFUNs.
1748 * buffer.h: Remove EXFUNs.
1749 * dispextern.h: Remove EXFUNs.
1750 * intervals.h: Remove EXFUNs.
1751 * fontset.h: Remove EXFUN.
1752 * font.h: Remove EXFUNs.
1753 * dosfns.c (system_process_attributes): Remove EXFUN.
1754 * keymap.h: Remove EXFUNs.
1755 * lisp.h: Remove EXFUNs.
1756 * w32term.h: Remove EXFUNs.
1757 * window.h: Remove EXFUNs.
1758 * xsettings.h: Remove EXFUN.
1759 * xterm.h: Remove EXFUN.
1761 2012-07-03 Glenn Morris <rgm@gnu.org>
1763 * lisp.h (Frandom): Make it visible to C.
1764 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1765 buffer for invisible buffers. (Bug#1229)
1767 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1769 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1770 values which aren't power of 2.
1771 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1772 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1775 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1777 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1779 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1781 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1783 * alloc.c (allocate_vector_block): Remove redundant
1784 calls to mallopt if DOUG_LEA_MALLOC is defined.
1785 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1786 avoid calls to mallopt if zero_vector is returned.
1788 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1790 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1791 is enabled, avoid dereferencing NULL current_sblock if
1794 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1796 Cleanup basic buffer management.
1797 * buffer.h (struct buffer): Change layout to use generic vector
1798 marking code. Fix some comments. Change type of 'clip_changed'
1799 to bitfield. Remove unused #ifndef old.
1800 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1801 (GET_OVERLAYS_AT): Fix indentation.
1802 (for_each_per_buffer_object_at): New macro.
1803 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1804 (Fbuffer_local_variables): Use it.
1805 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1806 * alloc.c (allocate_buffer): Adjust to match new layout of
1807 struct buffer. Fix comment.
1808 (mark_overlay): New function.
1809 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1810 Lisp area of struct buffer.
1811 (mark_object): Use it. Adjust marking of misc objects
1812 and related comments.
1814 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1816 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1817 wrapper that is not needed because the wrapped code is a no-op (zero
1818 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1819 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1821 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1823 * alloc.c (mark_buffer): Simplify. Remove prototype.
1824 (mark_object): Add comment. Reorganize marking of vector-like
1825 objects. Use CHECK_LIVE for all vector-like objects except buffers
1826 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1827 redundant calls to mark_vectorlike for bool vectors.
1829 2012-06-30 Glenn Morris <rgm@gnu.org>
1831 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1833 * epaths.in (PATH_SITELOADSEARCH): New.
1834 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1835 This is rather than relying on --enable-locallisppath elements
1836 having "site-lisp" in their names. (Bug#10208#25, 11658)
1838 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1840 * w32proc.c (sys_select): Accept and ignore one more argument.
1842 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1844 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1845 (pselect) [!MS_DOS]: Redirect to sys_select.
1847 * sysdep.c: Don't include dos.h and dosfns.h.
1849 * process.c (sys_select):
1850 * msdos.c (sys_select): Accept one more argument and ignore it.
1852 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1853 adapt data types and code to that.
1856 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1857 which clashes with the gnulib function of the same name.
1859 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1861 * font.c (font_style_to_value, font_style_symbolic)
1862 (font_prop_validate_style): Add type checks for values in
1865 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1867 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1870 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1872 * xdisp.c (try_window_id): Undo last change.
1874 * w32.c (getwd): Adjust commentary about startup_dir.
1875 (init_environment): Always call sys_access, even in non-MSVC
1876 builds. Don't chdir to the directory of the Emacs executable.
1877 This undoes code from 1997 which was justified by the need to
1878 "avoid conflicts when removing and renaming directories". But its
1879 downside was that every relative file name was being interpreted
1880 relative to the directory of the Emacs executable, which can never
1881 be TRT. In particular, it broke sys_access when called with
1882 relative file names.
1883 (sys_access): Map GetLastError to errno.
1885 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1887 * window.h (struct window): Change type of 'fringes_outside_margins'
1888 to bitfield. Fix comment. Adjust users accordingly.
1889 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1891 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1894 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1896 * gnutls.c (emacs_gnutls_handshake):
1897 Add QUIT to make the loop interruptible.
1899 2012-06-29 Glenn Morris <rgm@gnu.org>
1901 * charset.c (init_charset): Make lack of etc/charsets fatal.
1903 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1905 * editfns.c (region_limit): Fix type mismatch.
1907 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1909 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1910 undefined. Convert from xassert to eassert.
1911 * nsmenu.m: Convert from xassert to eassert.
1912 * nsterm.m: Likewise.
1914 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1916 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1918 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1920 Avoid integer overflow on scroll-left and scroll-right.
1921 * window.c (HSCROLL_MAX): New macro.
1922 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1923 overflow when requested scroll falls outside ptrdiff_t range.
1925 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1927 * window.h (struct window): Change type of 'hscroll',
1928 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1929 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1930 Adjust users accordingly.
1931 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1932 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1933 from EMACS_INT to ptrdiff_t.
1934 (make_window): Omit redundant initialization.
1936 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1938 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1940 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1942 * window.h (struct window): Change type of 'use_time' and
1943 'sequence_number' from Lisp_Object to int.
1944 * frame.c (make_frame): Adjust users accordingly.
1945 * print.c (print_object): Likewise.
1946 * window.c (select_window, Fwindow_use_time, make_parent_window)
1947 (make_window): Likewise.
1949 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1951 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1952 enabled with --enable-checking=[all,glyphs] configure option.
1953 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1954 adjust comments accordingly.
1955 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1956 undefined, adjust comments accordingly.
1957 * image.c: Likewise.
1958 * scroll.c: Likewise.
1959 * w32fns.c: Likewise.
1960 * w32term.c: Likewise.
1961 * xdisp.c: Likewise.
1962 * xfaces.c: Likewise.
1964 * xterm.c: Likewise.
1966 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1968 Generalize run-time debugging checks.
1969 * dispextern.h (XASSERTS): Remove.
1970 * fontset.c (xassert): Remove.
1971 Convert from xassert to eassert.
1972 * alloc.c: Convert from xassert to eassert.
1974 * dispnew.c: Likewise.
1976 * fringe.c: Likewise.
1977 * ftfont.c: Likewise.
1978 * gtkutil.c: Likewise.
1979 * image.c: Likewise.
1980 * keyboard.c: Likewise.
1982 * process.c: Likewise.
1983 * scroll.c: Likewise.
1984 * sound.c: Likewise.
1986 * w32console.c: Likewise.
1987 * w32fns.c: Likewise.
1988 * w32term.c: Likewise.
1989 * window.c: Likewise.
1990 * xdisp.c: Likewise.
1991 * xfaces.c: Likewise.
1993 * xselect.c: Likewise.
1994 * xterm.c: Likewise.
1996 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1998 * fns.c (maybe_resize_hash_table): Output message when growing the
2001 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2003 * alloc.c (allocate_string_data): Remove dead code.
2004 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2005 avoid GCC warning about unused macro.
2007 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2009 * alloc.c (allocate_string): Omit intervals initialization.
2010 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2011 as in make_pure_string and make_pure_c_string.
2013 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2015 * alloc.c (allocate_string): Fix last change.
2017 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2019 * alloc.c (allocate_string): Remove two redundant calls
2020 to memset, add explicit initialization where appropriate.
2022 2012-06-27 Glenn Morris <rgm@gnu.org>
2024 * lisp.mk (lisp): Remove paths.elc.
2026 2012-06-27 Chong Yidong <cyd@gnu.org>
2028 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2030 2012-06-26 John Wiegley <johnw@newartisans.com>
2032 * unexmacosx.c (copy_data_segment): Add two section names used
2033 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2035 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2036 when building with Clang.
2038 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2040 * eval.c (Fapply): Allow calling it with a single argument.
2042 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2044 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2045 _stricmp and _strnicmp.
2046 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2048 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2050 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2052 (allocate_process): Likewise for new process.
2053 (allocate_terminal): Change to use offsetof.
2054 (allocate_frame): Likewise.
2055 * frame.c (make_frame): Omit redundant initialization.
2056 * window.c (make_parent_window): Use memset.
2057 (make_window): Omit redundant initialization.
2058 * process.c (make_process): Omit redundant initialization.
2059 * terminal.c (create_terminal): Likewise.
2061 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2063 * term.c (delete_tty): Remove redundant call to memset.
2065 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2067 * alloc.c: Remove build_string.
2068 * lisp.h: Define build_string as static inline. This provides
2069 a better opportunity to optimize away calls to strlen when the
2070 function is called with compile-time constant argument.
2071 * image.c (imagemagick_error): Convert to build_string.
2072 * w32proc.c (sys_spawnve): Likewise.
2073 * xterm.c (x_term_init): Likewise.
2075 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2077 Use sprintf return value instead of invoking strlen on result.
2078 In the old days this wasn't portable, since some sprintf
2079 implementations returned char *. But they died out years ago and
2080 Emacs already assumes sprintf returns int.
2081 Similarly for float_to_string.
2082 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2083 * ccl.c (ccl_driver):
2084 * character.c (string_escape_byte8):
2085 * data.c (Fnumber_to_string):
2086 * doprnt.c (doprnt):
2087 * print.c (print_object):
2088 * xdisp.c (message_dolog):
2089 * xfns.c (syms_of_xfns):
2090 Use sprintf or float_to_string result to avoid need to call strlen.
2091 * data.c (Fnumber_to_string):
2092 Use make_unibyte_string, since the string must be ASCII.
2093 * lisp.h, print.c (float_to_string): Now returns int length.
2094 * term.c (produce_glyphless_glyph):
2095 Use sprintf result rather than recomputing it.
2097 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2098 * Makefile.in (ALL_CFLAGS):
2099 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2100 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2102 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2104 * dispextern.h (xstrcasecmp): Define to library function
2105 strcasecmp if available.
2106 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2108 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2110 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2111 Avoid comma operator.
2112 * menu.c (push_submenu_start, push_submenu_end)
2113 (push_left_right_boundary, push_menu_pane): Likewise.
2114 * msdos.c (dos_rawgetc): Likewise.
2116 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2118 * xfns.c (xic_create_fontsetname): Remove redundant calls
2121 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2123 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2124 sprintf already null-terminates its output.
2126 * xfns.c (x_window): Remove redundant cast.
2128 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2130 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2131 `const char *' to `char *' to avoid compiler warning.
2133 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2135 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2136 instead of truncating it to 63 (admittedly a generous limit).
2138 * process.c: Fix spelling and caps in comments.
2140 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2142 * emacs.c (setpgrp): Remove definition, unused.
2143 * sysdep.c (setpgrp): Remove definition, not used in this file.
2145 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2147 * makefile.w32-in: Update dependencies.
2149 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2151 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2152 (SYSTIME_H): Add nt/inc/sys/time.h.
2154 * systime.h [WINDOWSNT]: Include sys/time.h.
2156 * s/ms-w32.h (struct timespec): Definition moved from
2157 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2159 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2161 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2162 * buffer.h (buffer_slot_type_mismatch):
2163 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2164 * eval.c (unwind_to_catch):
2165 * image.c (my_png_error, my_error_exit):
2166 * keyboard.c (quit_throw_to_read_char, user_error)
2167 (Fexit_recursive_edit, Fabort_recursive_edit):
2168 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2169 (wrong_type_argument, buffer_overflow, __executable_start)
2170 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2171 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2172 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2174 (child_setup) [!DOS_NT]:
2175 * lread.c (end_of_file_error, invalid_syntax):
2176 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2177 * puresize.h (pure_write_error):
2178 * search.c (matcher_overflow):
2179 * sound.c (sound_perror, alsa_sound_perror):
2180 * sysdep.c, syssignal.h (croak):
2181 * term.c (maybe_fatal, vfatal):
2182 * textprop.c (text_read_only):
2183 * undo.c (user_error):
2184 * unexmacosx.c (unexec_error):
2185 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2186 Use _Noreturn rather than NO_RETURN.
2187 No need for separate decl merely because of _Noreturn.
2188 * sound.c (sound_warning, parse_sound):
2189 Remove unnecessary forward decls.
2191 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2193 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2194 * lisp.h (WAIT_READING_MAX): New macro.
2195 * dispnew.c (Fsleep_for, sit_for):
2196 * keyboard.c (kbd_buffer_get_event):
2197 * process.c (Faccept_process_output):
2198 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2199 This improves on the previous patch, which introduced a bug
2200 when time_t is unsigned and as wide as intmax_t.
2201 See <http://bugs.gnu.org/9000#51>.
2203 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2205 * dispnew.c (sit_for, Fsleep_for):
2206 * keyboard.c (kbd_buffer_get_event):
2207 * process.c (Faccept_process_output): Avoid compiler warnings when
2208 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2210 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2212 * makefile.w32-in: Update dependencies.
2214 * w32.c (ltime): Add return type and declare static.
2215 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2217 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2219 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2220 Privately reported by Herbert J. Skuhra.
2221 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2223 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2224 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2226 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2228 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2229 last argument of make_unibyte_string.
2231 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2232 language ID in the event parameters.
2234 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2235 event.code, not the obscure "character set ID".
2237 2012-06-23 Chong Yidong <cyd@gnu.org>
2239 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2241 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2243 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2244 * w32.c (fdutimens): New function.
2246 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2248 * s/ms-w32.h (pselect): Redirect to sys_select.
2250 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2252 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2253 in the logic of incrementing and decrementing the value of
2254 use_relocatable_buffers.
2256 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2258 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2259 Privately reported by Herbert J. Skuhra.
2260 [__FreeBSD__]: Remove "*/" typo after "#include".
2261 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2262 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2263 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2264 Don't assume EMACS_TIME and struct timeval are the same type.
2266 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2268 Support higher-resolution time stamps (Bug#9000).
2269 The time stamps are only nanosecond-resolution at the C level,
2270 since that's the best that any real-world system supports now.
2271 But they are picosecond-resolution at the Lisp level, as that's
2272 easy, and leaves room for future OS improvements.
2274 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2277 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2278 Don't get current time unless it's needed.
2280 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2281 now provides it if it's absent.
2282 (start_atimer): Port to higher-res time stamps.
2283 Check for time stamp overflow. Don't get current time more
2284 often than is needed.
2286 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2287 Include systime.h, not time.h.
2288 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2290 * dired.c: Include stat-time.h.
2291 (Ffile-attributes): File times now have higher resolution.
2293 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2294 (struct image): Timestamp now has higher resolution.
2296 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2297 has at least microseconds now. All uses removed.
2298 (update_frame, update_single_window, update_window, update_frame_1)
2299 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2301 * editfns.c (time_overflow): Now extern.
2302 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2303 (float-time, Fformat_time_string, Fcurrent_time_string)
2304 (Fcurrent_time_zone): Accept and generate higher-resolution
2306 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2307 (decode_time_components, lisp_seconds_argument): New functions.
2308 (make_time): Now static.
2309 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2310 Report an error if the time is invalid, rather than having the caller
2313 * fileio.c: Include <stat-time.h>
2314 (Fcopy_file): Copy higher-resolution time stamps.
2315 Prefer to set the time stamp via a file descriptor if that works.
2316 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2317 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2318 (Fvisited_file_modtime, Fset_visited_file_modtime):
2319 Support higher-resolution time stamps.
2321 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2323 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2325 * image.c (prepare_image_for_display, clear_image_cache)
2326 (lookup_image): Port to higer-resolution time stamps.
2328 * keyboard.c (start_polling, bind_polling_period):
2329 Check for time stamp overflow.
2330 (read_char, kbd_buffer_get_event, timer_start_idle)
2331 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2332 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2333 Port to higher-resolution time stamps. Do not assume time_t is signed.
2334 (decode_timer): New function. Timers are now vectors of length 9,
2335 not 8, to accommodate the picosecond component.
2336 (timer_check_2): Use it.
2338 * nsterm.m (select_timeout, timeval_subtract): Remove.
2339 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2340 as they're a bit more accurate and handle overflow better.
2341 (ns_select): Change prototype to be compatible with pselect.
2342 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2343 * nsterm.h (ns_select): Adjust prototype.
2345 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2346 us-resolution time stamps.
2347 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2349 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2351 * lisp.h (time_overflow): New decl.
2352 (wait_reading_process_output): First arg is now intmax_t, not int,
2353 to accommodate larger waits.
2355 * process.h (struct Lisp_Process.read_output_delay):
2356 Now counts nanoseconds, not microseconds.
2357 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2359 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2360 (wait_reading_process_output):
2361 Port to ns-resolution time stamps.
2362 (Faccept_process_output, wait_reading_process_output):
2363 Check for time stamp overflow. Do not assume time_t is signed.
2364 (select_wrapper): Remove; we now use pselect.
2365 (Fprocess_attributes): Now generates ns-resolution time stamps.
2367 * sysdep.c: Include utimens.h. Don't include utime.h
2368 or worry about struct utimbuf; gnulib does that for us now.
2369 (gettimeofday): Remove; gnulib provides a substitute.
2370 (make_timeval): New function.
2371 (set_file_times): Now sets ns-resolution time stamps.
2372 New arg FD; all uses changed.
2373 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2374 (system_process_attributes):
2375 Now returns ns-resolution time stamp. All uses changed.
2376 Check for time stamp overflow.
2378 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2379 provides a substitute now.
2381 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2382 since it guarantees struct timespec.
2383 (EMACS_TIME): Now struct timespec, so that we can support
2384 ns-resolution time stamps.
2385 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2386 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2387 (EMACS_USECS): Remove.
2388 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2389 so multiply the arg by 1000 before storing it.
2390 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2392 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2393 Port to ns-resolution time stamps.
2394 (EMACS_TIME_NEG_P): Remove; replaced by....
2395 (EMACS_TIME_SIGN): New macro.
2396 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2397 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2398 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2399 (make_timeval, make_lisp_time, decode_time_components): New decls.
2400 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2401 that it mishandled time_t overflow. You can't compare by subtracting!
2402 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2403 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2405 * term.c: Include <sys/time.h>.
2406 (timeval_to_Time): New function, for proper overflow wraparound.
2407 (term_mouse_position, term_mouse_click): Use it.
2409 * undo.c (record_first_change): Support higher-resolution time stamps
2411 (Fprimitive_undo): Use them when restoring time stamps.
2413 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2414 (w32_get_internal_run_time):
2415 Port to higher-resolution Emacs time stamps.
2416 (ltime): Now accepts single 64-bit integer, as that's more convenient
2419 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2421 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2422 for compatibility with pselect. Support ns-resolution time stamps.
2424 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2426 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2427 Check for time stamp overflow, and support ns-resolution time stamps.
2429 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2430 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2431 (timeval_subtract): Remove; no longer needed.
2432 (XTflash, XTring_bell, x_wait_for_event):
2433 Port to ns-resolution time stamps. Don't assume time_t is signed.
2435 2012-06-22 Chong Yidong <cyd@gnu.org>
2437 * xdisp.c (x_consider_frame_title): Revert last change.
2439 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2441 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2442 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2443 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2444 staticidx goes up to 1597 out of 1600 = 0x640.)
2446 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2448 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2449 Otherwise, the umask might be mistakenly 0 while handling input signals.
2451 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2453 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2455 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2457 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2458 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2459 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2460 access to `contents' member of Lisp_Vector objects with AREF and ASET
2463 2012-06-19 Chong Yidong <cyd@gnu.org>
2465 * frame.c (delete_frame): When selecting a frame on a different
2466 text terminal, do not alter the terminal's top-frame.
2468 * xdisp.c (format_mode_line_unwind_data): Record the target
2469 frame's selected window and its terminal's top-frame.
2470 (unwind_format_mode_line): Restore them.
2471 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2473 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2474 since tty frames can be explicitly named.
2475 (prepare_menu_bars): Likewise.
2477 * term.c (Ftty_top_frame): New function.
2479 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2481 Port byte-code-meter to modern targets.
2482 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2483 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2484 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2485 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2486 (METER_1, METER_2): Simplify.
2488 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2490 * data.c (Fdefalias): Return `symbol' (bug#11686).
2492 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2494 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2495 gets killed during executing of this function (Bug#11665).
2496 Try to always return Qt when the buffer has been actually killed.
2497 (Vkill_buffer_query_functions): In doc-string say that functions
2498 run by this hook should not change the current buffer.
2500 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2502 Fix recently-introduced process.c problems found by static checking.
2503 * process.c (write_queue_push, write_queue_pop, send_process):
2504 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2505 (write_queue_pop): Fix pointer signedness problem.
2506 (send_process): Remove unused local.
2508 2012-06-17 Chong Yidong <cyd@gnu.org>
2510 * xdisp.c (redisplay_internal): No need to redisplay terminal
2511 frames that are not on top.
2513 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2515 * process.c (make_process): Initialize write_queue.
2516 (write_queue_push, write_queue_pop): New functions.
2517 (send_process): Use them to maintain correct ordering of process
2520 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2522 * lisp.h (eassert): Assume C89 or later.
2523 This removes the need for CHECK.
2524 (CHECK): Remove. Its comments about always evaluating its
2525 argument were confusing, as 'eassert' typically does not evaluate
2528 * coding.c (produce_chars): Use ptrdiff_t, not int.
2530 * xterm.c (x_draw_underwave): Check for integer overflow.
2531 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2533 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2535 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2536 referenced (Bug#11583).
2538 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2540 Implement wave-style variant of underlining.
2541 * dispextern.h (face_underline_type): New enum.
2542 (face): Add field for underline type.
2543 * nsterm.m (ns_draw_underwave): New function.
2544 (ns_draw_text_decoration): Use it.
2545 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2547 (x_draw_glyph_string): Use them.
2548 * xfaces.c (Qline, Qwave): New Lisp objects.
2549 (check_lface_attrs, merge_face_ref)
2550 (Finternal_set_lisp_face_attribute, realize_x_face):
2551 Handle wave-style underline face attributes.
2552 * xterm.c (x_draw_underwave): New function.
2553 (x_draw_glyph_string): Use it.
2555 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2557 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2558 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2559 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2560 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2561 ($(BLD)/w32select.$(O)): Update dependencies.
2563 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2565 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2566 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2567 * character.c (_fetch_multibyte_char_p): Remove.
2568 * alloc.c: Include "character.h" before "buffer.h".
2570 * buffer.c: Likewise.
2571 * bytecode.c: Likewise.
2572 * callint.c: Likewise.
2573 * callproc.c: Likewise.
2574 * casefiddle.c: Likewise.
2575 * casetab.c: Likewise.
2576 * category.c: Likewise.
2578 * coding.c: Likewise.
2579 * composite.c: Likewise.
2580 * dired.c: Likewise.
2581 * dispnew.c: Likewise.
2583 * dosfns.c: Likewise.
2584 * editfns.c: Likewise.
2585 * emacs.c: Likewise.
2586 * fileio.c: Likewise.
2587 * filelock.c: Likewise.
2589 * fontset.c: Likewise.
2590 * fringe.c: Likewise.
2591 * indent.c: Likewise.
2592 * insdel.c: Likewise.
2593 * intervals.c: Likewise.
2594 * keyboard.c: Likewise.
2595 * keymap.c: Likewise.
2596 * lread.c: Likewise.
2597 * macros.c: Likewise.
2598 * marker.c: Likewise.
2599 * minibuf.c: Likewise.
2600 * nsfns.m: Likewise.
2601 * nsmenu.m: Likewise.
2602 * print.c: Likewise.
2603 * process.c: Likewise.
2604 * regex.c: Likewise.
2605 * region-cache.c: Likewise.
2606 * search.c: Likewise.
2607 * syntax.c: Likewise.
2609 * textprop.c: Likewise.
2611 * unexsol.c: Likewise.
2612 * w16select.c: Likewise.
2613 * w32fns.c: Likewise.
2614 * w32menu.c: Likewise.
2615 * window.c: Likewise.
2616 * xdisp.c: Likewise.
2618 * xmenu.c: Likewise.
2620 * xselect.c: Likewise.
2622 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2624 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2625 If all the glyphs of the glyph row came from strings, and we have no
2626 cursor positioning clues, put the cursor on the first glyph of the
2628 (handle_face_prop): Use chunk-relative overlay string index when
2629 indexing into it->string_overlays array. (Bug#11653)
2630 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2631 the rightmost. (Bug#11720)
2633 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2635 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2636 (CATEGORY_MEMBER): Enforce 1/0 value.
2637 * category.c (_temp_category_set): Remove.
2639 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2641 * window.c (Fdelete_other_windows_internal)
2642 (Fdelete_window_internal): Don't access frame's mouse highlight
2643 info of the initial frame. (Bug#11677)
2645 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2647 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2648 Assume USE_2_TAGS_FOR_INTS.
2649 (xreload): Adjust $tagmask width to match recent lisp.h change.
2651 Simplify lisp.h in minor ways that should not affect code.
2652 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2653 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2654 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2655 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2656 (INTTYPEBITS): New macro, for clarity.
2657 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2658 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2659 Simplify now that USE_LSB_TAG is always defined.
2660 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2661 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2663 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2665 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2667 2012-06-13 Glenn Morris <rgm@gnu.org>
2669 * s/bsd-common.h (BSD4_3):
2670 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2672 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2674 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2677 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2679 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2680 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2681 * alloc.c (widen_to_Lisp_Object): Remove.
2682 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2683 * frame.c (delete_frame): Remove outdated comment.
2684 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2685 USE_LISP_UNION_TYPE.
2686 (Fw32_unregister_hot_key): Likewise.
2687 (Fw32_toggle_lock_key): Likewise.
2688 * w32menu.c (add_menu_item): Likewise.
2689 (w32_menu_display_help): Use XIL instead of checking
2690 USE_LISP_UNION_TYPE.
2691 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2692 (init_heap): Likewise.
2693 * w32term.c (w32_read_socket): Update comment.
2695 2012-06-13 Glenn Morris <rgm@gnu.org>
2697 * s/usg5-4-common.h, src/s/unixware.h:
2698 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2700 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2702 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2704 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2705 * alloc.c (make_number) [!defined make_number]:
2706 Remove, as lisp.h always defines this now.
2707 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2708 (roundup_size): Verify that it is a power of 2.
2709 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2710 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2711 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2712 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2713 USE_LSB_TAG now is always defined to be either 0 or 1.
2715 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2716 code works fine either way, and efficiency is not a concern here,
2717 as the union type is for debugging, not for production.
2718 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2719 Use an inline function on all platforms when using the union type,
2720 since this is simpler and 'static inline' can be used portably
2722 (LISP_INITIALLY_ZERO): New macro.
2723 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2724 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2726 2012-06-12 Glenn Morris <rgm@gnu.org>
2728 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2730 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2732 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2733 Move BROKEN_SIGIO to configure.
2735 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2736 Move NO_TERMIO to configure.
2738 2012-06-12 Chong Yidong <cyd@gnu.org>
2740 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2741 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2742 MagickExportImagePixels is undefined.
2744 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2746 * image.c (imagemagick_load_image): Remove unused label.
2748 2012-06-11 Glenn Morris <rgm@gnu.org>
2750 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2751 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2752 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2753 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2755 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2757 * alloc.c (make_byte_code): New function.
2758 (Fmake_byte_code): Use it. Don't purify here.
2759 * lread.c (read1): Use it as well to avoid extra allocation.
2761 2012-06-11 Chong Yidong <cyd@gnu.org>
2763 * image.c (imagemagick_load_image): Implement transparency.
2765 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2767 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2768 account for preceding backslashes. (Bug#11663)
2770 2012-06-09 Chong Yidong <cyd@gnu.org>
2772 * term.c: Support italics in capable terminals (Bug#9652).
2773 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2774 (turn_on_face): Output using TS_enter_italic_mode if available.
2775 Don't handle unused blinking and alt-charset cases.
2776 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2777 and tty_alt_charset_p cases.
2778 (tty_capable_p, init_tty): Support italics.
2780 * termchar.h (struct tty_display_info): Add field for italics.
2781 Remove unused blink field.
2783 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2786 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2787 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2788 tty_alt_charset_p. Add tty_italic_p.
2790 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2792 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2793 dbus_type_is_basic if available.
2794 (xd_extract_signed, xd_extract_unsigned): Rename from
2795 extract_signed and extract_unsigned, respectively. Adapt callers.
2797 2012-06-09 Chong Yidong <cyd@gnu.org>
2799 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2801 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2804 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2806 * xdisp.c (vmessage): Treat frame message as multibyte.
2807 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2808 would generate the diagnostic "Making \302\247 buffer-local while
2811 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2813 * dispnew.c (showing_window_margins_p): Undo last change, which
2814 was done due to an inadvertent commit.
2815 (adjust_frame_glyphs_for_frame_redisplay): Do call
2816 showing_window_margins_p.
2818 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2820 * eval.c (Fmake_var_non_special): New primitive.
2821 (syms_of_eval): Defsubr it.
2822 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2824 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2826 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2827 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2829 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2831 * alloc.c (allocate_vectorlike): Fix last change.
2833 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2835 Block-based vector allocation of small vectors.
2836 * lisp.h (struct vectorlike_header): New field `nbytes',
2837 adjust comment accordingly.
2838 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2839 to denote vector blocks. Adjust users (live_vector_p,
2840 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2841 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2842 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2843 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2844 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2845 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2846 (roundup_size): New constant.
2847 (struct vector_block): New data type.
2848 (vector_blocks, vector_free_lists, zero_vector): New variables.
2849 (all_vectors): Rename to `large_vectors'.
2850 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2851 (sweep_vectors): New functions.
2852 (allocate_vectorlike): Return `zero_vector' as the only vector of
2853 0 items. Allocate new vector from block if vector size is less than
2854 or equal to VBLOCK_BYTES_MAX.
2855 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2856 (init_alloc_once): Add call to init_vectors.
2858 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2860 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2862 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2864 * doprnt.c (doprnt): Truncate multibyte char correctly.
2865 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2866 would mishandle a string argument "Xc" if X was a multibyte
2867 character of length 2: it would truncate after X's first byte
2868 rather than including all of X.
2870 2012-06-06 Chong Yidong <cyd@gnu.org>
2872 * buffer.c (word_wrap): Doc fix.
2874 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2876 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2878 2012-06-03 Glenn Morris <rgm@gnu.org>
2880 * xdisp.c (tool-bar-style): Doc fix.
2882 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2884 * Makefile.in (PAXCTL): Define.
2885 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2886 binary via PaX flags if the paxctl utility is available.
2887 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2888 Restore PaX flags to their default. (Bug#11398)
2890 2012-06-03 Chong Yidong <cyd@gnu.org>
2892 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2895 2012-06-03 Chong Yidong <cyd@gnu.org>
2897 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2898 (note_mode_line_or_margin_highlight): If there is no help echo,
2899 use mode-line-default-help-echo. Handle the case where the mouse
2900 position is past the end of the mode line string.
2902 * buffer.c (buffer_local_value_1): New function, split from
2903 Fbuffer_local_value; can return Qunbound.
2904 (Fbuffer_local_value): Use it.
2905 (Vmode_line_format): Docstring tweaks.
2907 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2909 * sysdep.c (system_process_attributes): Improve comment.
2911 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2913 * keyboard.c: Export real-this-command to Elisp.
2914 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2915 and DEFVAR it. Update all users.
2917 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2919 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2921 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2922 Convert pctcpu and pctmem to Lisp float properly.
2923 Let the compiler fold better, as 100.0/0x8000 is exact.
2925 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2927 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2930 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2932 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2934 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2936 For a 'struct window', replace some Lisp_Object fields to
2937 bitfields where appropriate, remove unused fields.
2938 * window.h (struct window): Remove unused 'last_mark_x' and
2939 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2940 change it's type from Lisp_Object to bitfield.
2941 Change type of 'force_start', 'optional_new_start',
2942 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2943 fields from Lisp_Object to bitfield. Adjust users accordingly.
2945 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2947 Pacify gcc -Wdouble-precision when using Xaw.
2948 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2949 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2950 Use 'float' consistently, rather than 'float' in most places
2951 and 'double' in a couple of places.
2953 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2955 * xdisp.c (handle_stop): Detect whether we have overlay strings
2956 loaded by testing it->current.overlay_string_index to be
2957 non-negative, instead of checking whether n_overlay_strings is
2958 positive. (Bug#11587)
2960 2012-05-31 Chong Yidong <cyd@gnu.org>
2962 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2964 * doc.c (Fsubstitute_command_keys): Doc fix.
2966 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2968 * search.c (search_buffer): Remove calls to
2969 r_alloc_inhibit_buffer_relocation, as it is now called by
2970 maybe_unify_char, which was the cause of relocation of buffer text
2973 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2975 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2976 for the duration of call to load_charset, to avoid problems with
2977 callers of maybe_unify_char that access buffer text through C
2980 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2981 decrement the inhibition flag, instead of just setting or
2984 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2986 Remove obsolete '#define static' cruft.
2987 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2988 This #undef was "temporary" in 2000; it is no longer needed
2989 now that '#define static' has gone away.
2990 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2991 (gray_bitmap_bits): Remove; no longer needed.
2992 All uses replaced with definiens.
2993 * xterm.c: Include "bitmaps/gray.xbm".
2995 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2997 Clean up __executable_start, monstartup when --enable-profiling.
2998 The following changes affect the code only when profiling.
2999 * dispnew.c (__executable_start): Rename from safe_bcopy.
3000 Define only on platforms that need it.
3001 * emacs.c: Include <sys/gmon.h> when profiling.
3002 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3003 (__executable_start): Remove decl, since lisp.h does it now.
3004 (safe_bcopy): Remove decl; no longer has that name.
3005 (main): Coalesce #if into single bit of code, for simplicity.
3006 Cast pointers to uintptr_t, since standard libraries want integers
3008 * lisp.h (__executable_start): New decl.
3010 2012-05-31 Glenn Morris <rgm@gnu.org>
3012 * image.c (Fimagemagick_types): Doc fix.
3014 2012-05-30 Jim Meyering <meyering@redhat.com>
3016 * callproc.c (Fcall_process_region): Include directory component
3017 in mkstemp error message (Bug#11586).
3019 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3021 * alloc.c, lisp.h (make_pure_vector): Now static.
3023 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3025 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3026 Move to byte-run.el.
3027 (Fautoload): Do the hash-doc more carefully.
3028 * data.c (Fdefalias): Purify definition, except for keymaps.
3029 (Qdefun): Move from eval.c.
3030 * lisp.h (Qdefun): Remove.
3031 * lread.c (read1): Tiny simplification.
3033 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3035 Do not create empty overlays with the evaporate property (Bug#9642).
3036 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3037 Bug#9642, but explicitly check that the buffer the overlay would
3038 be moved to is live and rearrange lines to make sure that errors
3039 will not put the overlay in an inconsistent state.
3040 (Fdelete_overlay): Cosmetics.
3042 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3044 * w32term.c (my_bring_window_to_top): New function.
3045 (x_raise_frame): Use handle returned by DeferWindowPos, which
3046 could be different from the original one.
3047 Call my_bring_window_to_top instead of my_set_foreground_window.
3050 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3051 by calling BringWindowToTop.
3053 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3054 (WM_EMACS_END): Increase by one.
3056 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3058 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3059 This avoids undefined behavior that might cause the eassert
3060 to not catch an out-of-range value.
3062 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3064 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3065 Update dependencies.
3067 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3069 * bidi.c (bidi_mirror_char): Fix last change.
3071 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3073 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3074 when referring to sectname field in printf format.
3076 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3078 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3079 Only r_alloc_inhibit_buffer_relocation needed to be added;
3080 the others were already declared.
3082 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3083 before checking whether it's out of range. Put the check inside
3085 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3087 2012-05-27 Ken Brown <kbrown@cornell.edu>
3089 * callproc.c (Fcall_process): Restore a line that was accidentally
3090 commented out in the 2011-02-13 change (bug#11547).
3092 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3094 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3095 defined on ralloc.c.
3097 * buffer.c [REL_ALLOC]: Remove prototypes of
3098 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3099 they are now on lisp.h.
3101 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3103 * search.c (search_buffer): Use it to inhibit relocation of buffer
3104 text while re_search_2 is doing its job, because re_search_2 is
3105 passed C pointers to buffer text. (Bug#11519)
3107 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3110 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3111 state after an additional call to move_it_in_display_line_to, keep
3112 the values of it->max_ascent and it->max_descent found for the
3114 (pos_visible_p): Revert the comparison against bottom_y to what it
3115 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3118 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3120 Fix coding-related core dumps with gcc -ftrapv.
3121 The code was computing A - B, where A and B are pointers, and B is
3122 random garbage. This can lead to core dumps on platforms that
3123 have special pointer registers, and it also leads to core dumps on
3124 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3125 A - B only when B is initialized properly.
3126 * coding.c (coding_set_source, coding_set_destination): Return void.
3127 (coding_change_source, coding_change_destinations): New functions,
3128 with the old behaviors of coding_set_source and coding_set_destination.
3129 All callers that need an offset changed to use these new functions.
3131 2012-05-26 Glenn Morris <rgm@gnu.org>
3133 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3135 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3137 Extend mouse support on W32 text-mode console.
3138 * xdisp.c (draw_row_with_mouse_face):
3139 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3141 * w32console.c: Include window.h.
3142 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3144 (initialize_w32_display): Initialize mouse-highlight data.
3146 * w32inevt.c: Include termchar.h and window.h.
3147 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3148 moves, call note_mouse_highlight. If help_echo changed, call
3149 gen_help_event to produce help-echo message in the echo area.
3150 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3153 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3155 * lread.c (read1): Simplify slightly to avoid an overflow warning
3156 with GCC 4.7.0 on x86-64.
3158 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3160 * bidi.c (bidi_mirror_char): Revert last change: an int is
3161 definitely wide enough here.
3163 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3165 Fix integer width and related bugs (Bug#9874).
3166 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3167 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3168 (string_bytes, check_sblock, allocate_string_data):
3169 (compact_small_strings, Fmake_bool_vector, make_string)
3170 (make_unibyte_string, make_multibyte_string)
3171 (make_string_from_bytes, make_specified_string)
3172 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3173 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3176 (allocate_pseudovector):
3177 Use int, not EMACS_INT, where int is wide enough.
3178 (inhibit_garbage_collection, Fgarbage_collect):
3179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3180 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3181 int might not be wide enough.
3182 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3183 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3184 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3185 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3186 (bidi_level_of_next_char, bidi_move_to_visually_next):
3187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3188 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3189 (Fkill_buffer, Fset_buffer_major_mode)
3190 (advance_to_char_boundary, Fbuffer_swap_text)
3191 (Fset_buffer_multibyte, overlays_at, overlays_in)
3192 (overlay_touches_p, struct sortvec, record_overlay_string)
3193 (overlay_strings, recenter_overlay_lists)
3194 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3195 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3196 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3197 (Foverlay_recenter, last_overlay_modification_hooks_used)
3198 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3200 (validate_region): Omit unnecessary test for b <= e,
3201 since that's guaranteed by the previous test.
3202 (adjust_overlays_for_delete): Avoid pos + length overflow.
3203 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3204 (report_overlay_modification):
3205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3206 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3207 Omit pointer cast, which isn't needed anyway, and doesn't work
3208 after the EMACS_INT -> ptrdiff_t change.
3209 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3210 * buffer.h: Adjust decls to match defn changes elsewhere.
3211 (struct buffer_text, struct buffer):
3212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3213 Use EMACS_INT, not int, where int might not be wide enough.
3214 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3215 not int, to avoid needless 32-bit limit on 64-bit hosts.
3216 (exec_byte_code): Use tighter memory-full test, one that checks
3217 for alloca overflow. Don't compute the address of the object just
3218 before an array, as that's not portable. Use EMACS_INT, not
3219 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3220 * callint.c (Fcall_interactively):
3221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3222 * callproc.c (call_process_kill, Fcall_process):
3223 Don't assume pid_t fits into an Emacs fixnum.
3224 (call_process_cleanup, Fcall_process, child_setup):
3225 Don't assume pid_t fits into int.
3226 (call_process_cleanup, Fcall_process, delete_temp_file)
3227 (Fcall_process_region):
3228 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3229 (Fcall_process): Simplify handling of volatile integers.
3230 Use int, not EMACS_INT, where int will do.
3231 * casefiddle.c (casify_object, casify_region, operate_on_word)
3232 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3234 (casify_object): Avoid integer overflow when overallocating buffer.
3235 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3236 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3237 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3238 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3239 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3240 integers are now checked earlier. All uses replaced with XINT.
3242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3243 For CCL_MapSingle, check that content and value are in int range.
3244 (ccl_driver, Fregister_code_conversion_map):
3245 Check that Vcode_version_map_vector is a vector.
3246 (resolve_symbol_ccl_program): Check that vector header is in range.
3247 Always copy the vector, so that we can check its contents reliably
3248 now rather than having to recheck each instruction as it's being
3249 executed. Check that vector words fit in 'int'.
3250 (ccl_get_compiled_code, Fregister_ccl_program)
3251 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3252 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3253 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3254 contents are in range.
3255 (Fccl_execute_on_string): Check that status is in range.
3256 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3257 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3258 Accept and return EMACS_INT, not int, because callers can pass values
3260 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3261 (multibyte_chars_in_text, parse_str_as_multibyte)
3262 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3263 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3264 (string_escape_byte8, Fget_byte):
3265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3266 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3267 avoid mishandling large integers.
3268 * character.h: Adjust decls to match defn changes elsewhere.
3269 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3270 (Ffind_charset_region):
3271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3272 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3273 (load_charset_map_from_vector, Fdefine_charset_internal):
3274 Don't assume fixnum fits in int.
3275 (load_charset_map_from_vector, Fmap_charset_chars):
3276 Remove now-unnecessary CHECK_NATNUMs.
3277 (Fdefine_charset_internal): Check ranges here, more carefully.
3278 Don't rely on undefined behavior with signed left shift overflow.
3279 Don't assume unsigned int fits into fixnum, or that fixnum fits
3280 into unsigned int. Don't require max_code to be a valid fixnum;
3281 that's not true for gb10830 4-byte on a 32-bit host. Allow
3282 invalid_code to be a cons, for the same reason. Require code_offset
3283 to be a character. Avoid int overflow if max_char is close
3285 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3286 this is intended anyway and avoids some undefined behavior.
3287 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3288 INDEX_TO_CODE_POINT, as that's what it expects.
3289 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3290 * charset.h (DECODE_CHAR): Return int, not unsigned;
3291 this is what was intended anyway, and it avoids undefined behavior.
3292 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3293 integer-overflow issues.
3294 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3295 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3296 where the argument is EMACS_INT, and this behavior is not intended.
3297 * chartab.c (Fmake_char_table, Fset_char_table_range)
3298 (uniprop_get_decoder, uniprop_get_encoder):
3299 Don't assume fixnum fits in int.
3300 * cmds.c (move_point): New function, that does the gist of
3301 Fforward_char and Fbackward_char, but does so while checking
3302 for integer overflow more accurately.
3303 (Fforward_char, Fbackward_char): Use it.
3304 (Fforward_line, Fend_of_line, internal_self_insert)
3305 (internal_self_insert):
3306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3307 Fix a FIXME, by checking for integer overflow when calculating
3308 target_clm and actual_clm.
3309 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3310 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3311 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3312 (coding_alloc_by_making_gap, alloc_destination)
3313 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3314 (encode_coding_utf_16, detect_coding_emacs_mule)
3315 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3316 (detect_coding_iso_2022, decode_coding_iso_2022)
3317 (encode_invocation_designation, encode_designation_at_bol)
3318 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3319 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3320 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3321 (encode_coding_ccl, encode_coding_raw_text)
3322 (detect_coding_charset, decode_coding_charset)
3323 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3324 (produce_composition, produce_charset, produce_annotation)
3325 (decode_coding, handle_composition_annotation)
3326 (handle_charset_annotation, consume_chars, decode_coding_gap)
3327 (decode_coding_object, encode_coding_object, detect_coding_system)
3328 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3329 (code_convert_region, code_convert_string)
3330 (Fdefine_coding_system_internal)
3331 (coding_set_source, coding_set_destination):
3332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3333 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3334 (Fdefine_coding_system_internal):
3335 Don't assume fixnums fit in int.
3336 (decode_coding_gap, decode_coding_object, encode_coding_object)
3337 (Fread_coding_system, Fdetect_coding_region)
3338 (Funencodable_char_position, Fcheck_coding_systems_region)
3339 (get_translation, handle_composition_annotation, consume_chars):
3340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3341 (consume_chars): Rewrite to not calculate an address outside buffer.
3342 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3343 Don't access memory outside of the args array.
3344 (Fdefine_coding_system_internal): Check for charset-id overflow.
3345 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3346 result of ENCODE_CHAR.
3347 * coding.h: Adjust decls to match defn changes elsewhere.
3348 (struct coding_system):
3349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3350 * composite.c (get_composition_id, find_composition)
3351 (run_composition_function, update_compositions)
3352 (compose_text, composition_gstring_put_cache)
3353 (composition_gstring_p, composition_gstring_width)
3354 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3355 (composition_compute_stop_pos, composition_reseat_it)
3356 (composition_update_it, struct position_record)
3357 (find_automatic_composition, composition_adjust_point)
3358 (Fcomposition_get_gstring, Ffind_composition_internal):
3359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3360 (update_compositions):
3361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3362 * composite.h: Adjust decls to match defn changes elsewhere.
3363 (struct composition):
3364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3365 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3366 Do not attempt to compute the address of the object just before a
3367 buffer; this is not portable.
3369 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3370 (Faset): Use int, not EMACS_INT, where int is wide enough.
3371 (Fstring_to_number): Don't assume fixnums fit in int.
3372 (Frem): Don't assume arg is nonnegative.
3373 * dbusbind.c (xd_append_arg): Check for integers out of range.
3374 (Fdbus_call_method): Don't overflow the timeout int.
3375 (extract_signed, extract_unsigned): New functions.
3376 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3377 (xd_get_connection_references): Return ptrdiff_t, not int.
3379 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3380 (xd_read_message_1):
3381 Use int, not unsigned, where the dbus API uses int.
3382 (Fdbus_message_internal): Don't overflow mtype.
3383 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3384 * dired.c (directory_files_internal, file_name_completion, scmp)
3385 (file_name_completion_stat):
3386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3387 (file_name_completion): Don't overflow matchcount.
3388 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3389 * dispextern.h: Adjust decls to match defn changes elsewhere.
3390 (struct text_pos, struct glyph, struct bidi_saved_info)
3391 (struct bidi_string_data, struct bidi_it, struct composition_it)
3393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3394 (struct display_pos, struct composition_it, struct it):
3395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3396 * dispnew.c (increment_matrix_positions)
3397 (increment_row_positions, mode_line_string)
3398 (marginal_area_string):
3399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3400 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3402 (duration_to_sec_usec): New function, to check for overflow better.
3403 (Fsleep_for, sit_for): Use it.
3404 * doc.c (get_doc_string, store_function_docstring):
3405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3406 (get_doc_string, Fsnarf_documentation):
3407 Use int, not EMACS_INT, where int is wide enough.
3409 Use SAFE_ALLOCA, not alloca.
3410 Check for overflow when converting EMACS_INT to off_t.
3411 * doprnt.c (doprnt):
3412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3413 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3414 Don't assume uid_t fits into fixnum.
3415 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3416 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3417 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3418 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3419 (general_insert_function)
3420 (Finsert_char, make_buffer_string, make_buffer_string_both)
3421 (update_buffer_properties, Fbuffer_substring)
3422 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3423 (Fsubst_char_in_region, check_translation)
3424 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3425 (transpose_markers, Ftranspose_regions):
3426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3427 (clip_to_bounds): Move to lisp.h as an inline function).
3428 (Fconstrain_to_field): Don't assume integers are nonnegative.
3429 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3430 (Fsubst_char_in_region, Fsave_restriction):
3431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3432 (Femacs_pid): Don't assume pid_t fits into fixnum.
3433 (lo_time): Use int, not EMACS_INT, when int suffices.
3434 (lisp_time_argument): Check for usec out of range.
3435 (Fencode_time): Don't assume fixnum fits in int.
3436 (Fuser_login_name, Fuser_full_name): Signal an error
3437 if a uid argument is out of range, rather than relying on
3439 (Fformat_time_string): Remove now-unnecessary check.
3440 lisp_time_argument checks for out-of-range usec now.
3441 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3442 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3443 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3444 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3445 (init_cmdargs, Fdump_emacs):
3446 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3447 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3448 the bottom (typically) 32 bits of the fixnum.
3449 * eval.c (specpdl_size, call_debugger):
3450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3451 (when_entered_debugger, Fbacktrace_debug):
3452 Don't assume fixnum can fit in int.
3453 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3454 the object just before a buffer; this is not portable.
3455 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3456 (grow_specpdl, unbind_to):
3457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3458 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3459 (grow_specpdl): Simplify allocation by using xpalloc.
3460 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3461 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3462 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3464 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3467 (Fcopy_file, non_regular_nbytes, read_non_regular)
3468 (Finsert_file_contents):
3469 Use int, not EMACS_INT, where int is wide enough.
3470 (READ_BUF_SIZE): Verify that it fits in int.
3471 (Finsert_file_contents): Check that counts are in proper range,
3472 rather than assuming fixnums fit into ptrdiff_t etc.
3473 Don't assume fixnums fit into int.
3474 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3475 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3476 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3477 (string_char_to_byte, string_byte_to_char)
3478 (string_make_multibyte, string_to_multibyte)
3479 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3480 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3481 (substring_both, Fdelete, internal_equal, Ffillarray)
3482 (Fclear_string, mapcar1)
3483 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3484 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3485 (larger_vector, make_hash_table, maybe_resize_hash_table)
3486 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3487 (Fmaphash, secure_hash):
3488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3489 (concat): Check for string index and length overflow.
3490 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3493 (larger_vector): New API (vec, incr_min, size_max) replaces old
3494 one (vec, new_size, init). This catches size overflow.
3495 INIT was removed because it was always Qnil.
3496 All callers changed.
3497 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3498 the upper bound on a hash table index size.
3499 (make_hash_table, maybe_resize_hash_table): Use it.
3500 (secure_hash): Computer start_byte and end_byte only after
3501 they're known to be in ptrdiff_t range.
3502 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3503 (Ffont_get_glyphs, Ffont_at):
3504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3505 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3506 (Flist_fonts, Fopen_font):
3507 Don't assume fixnum can fit in int.
3508 (check_gstring): Don't assume index can fit in int.
3509 (font_match_p): Check that fixnum is a character, not a nonnegative
3510 fixnum, since the later code needs to stuff it into an int.
3511 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3512 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3513 conversion overflow issues.
3514 (Fopen_font): Check for integer out of range.
3515 (Ffont_get_glyphs): Don't assume index can fit in int.
3516 * font.h: Adjust decls to match defn changes elsewhere.
3517 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3519 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3520 printmax_t, where ptrdiff_t is wide enough.
3521 (Finternal_char_font):
3522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3523 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3524 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3525 (Fset_frame_position, x_set_frame_parameters)
3526 (x_set_line_spacing, x_set_border_width)
3527 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3528 Check that fixnums are in proper range for system types.
3529 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3531 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3532 Use SAFE_ALLOCA_LISP, not alloca.
3533 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3534 intptr_t is wide enough.
3535 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3536 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3537 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3538 Check for fixnum out of range.
3539 * ftfont.c (ftfont_list): Don't assume index fits in int.
3540 Check that fixnums are in proper range for system types.
3541 (ftfont_shape_by_flt):
3542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3543 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3545 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3546 Check that fixnums are in proper range for system types.
3547 * gnutls.h: Adjust decls to match defn changes elsewhere.
3548 * gtkutil.c (xg_dialog_run):
3549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3550 (update_frame_tool_bar):
3551 Check that fixnums are in proper range for system types.
3552 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3553 (lookup_image): Check that fixnums are in range for system types.
3554 * indent.c (last_known_column, last_known_column_point):
3555 (current_column_bol_cache):
3556 (skip_invisible, current_column, check_display_width):
3557 (check_display_width, scan_for_column, current_column_1)
3558 (Findent_to, Fcurrent_indentation, position_indentation)
3559 (indented_beyond_p, Fmove_to_column, compute_motion):
3560 (Fcompute_motion, Fvertical_motion):
3561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3562 (last_known_column_modified): Use EMACS_INT, not int.
3563 (check_display_width):
3565 Check that fixnums and floats are in proper range for system types.
3566 (compute_motion): Don't assume index or fixnum fits in int.
3567 (compute_motion, Fcompute_motion):
3568 Use int, not EMACS_INT, when it is wide enough.
3569 (vmotion): Omit local var start_hpos that is always 0; that way
3570 we don't need to worry about overflow in expressions involving it.
3571 * indent.h: Adjust decls to match defn changes elsewhere.
3573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3574 Use int, not EMACS_INT, where int is wide enough.
3575 Remove unused members ovstring_chars_done and tab_offset;
3577 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3578 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3579 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3580 (make_gap, copy_text, insert, insert_and_inherit)
3581 (insert_before_markers, insert_before_markers_and_inherit)
3582 (insert_1, count_combining_before, count_combining_after)
3583 (insert_1_both, insert_from_string)
3584 (insert_from_string_before_markers, insert_from_string_1)
3585 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3586 (adjust_after_replace, adjust_after_insert, replace_range)
3587 (replace_range_2, del_range, del_range_1, del_range_byte)
3588 (del_range_both, del_range_2, modify_region)
3589 (prepare_to_modify_buffer, signal_before_change)
3590 (signal_after_change, Fcombine_after_change_execute):
3591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3592 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3593 (balance_an_interval, split_interval_right, split_interval_left)
3594 (find_interval, next_interval, update_interval)
3595 (adjust_intervals_for_insertion, delete_node, delete_interval)
3596 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3597 (static_offset_intervals, offset_intervals)
3598 (merge_interval_right, merge_interval_left, make_new_interval)
3599 (graft_intervals_into_buffer, temp_set_point_both)
3600 (temp_set_point, set_point, adjust_for_invis_intang)
3601 (set_point_both, move_if_not_intangible, get_property_and_range)
3602 (get_local_map, copy_intervals, copy_intervals_to_string)
3603 (compare_string_intervals, set_intervals_multibyte_1):
3604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3605 * intervals.h: Adjust decls to match defn changes elsewhere.
3607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3608 * keyboard.c (this_command_key_count, this_single_command_key_start)
3609 (before_command_key_count, before_command_echo_length, echo_now)
3610 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3611 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3612 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3613 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3615 (last_non_minibuf_size, last_point_position, echo_truncate)
3616 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3617 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3618 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3619 (stuff_buffered_input):
3620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3621 (last_auto_save, command_loop_1, read_char):
3622 Use EMACS_INT, not int, to avoid integer overflow.
3623 (record_char): Avoid overflow in total_keys computation.
3624 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3625 * keyboard.h: Adjust decls to match defn changes elsewhere.
3626 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3627 (Fkey_description, Fdescribe_vector, Flookup_key):
3628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3629 (click_position): New function, to check that positions are in range.
3630 (Fcurrent_active_maps):
3632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3633 (Faccessible_keymaps, Fkey_description):
3634 (preferred_sequence_p):
3635 Don't assume fixnum can fit into int.
3636 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3637 Check for integer overflow in size calculations.
3638 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3639 avoid mishandling large integers.
3640 * lisp.h: Adjust decls to match defn changes elsewhere.
3641 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3642 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3643 (struct Lisp_Marker):
3644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3645 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3646 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3647 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3648 All callers changed.
3649 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3650 Assume the arg has valid form, since it always does.
3651 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3652 unsigned integer system type.
3653 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3654 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3656 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3657 (duration_to_sec_usec): New decl.
3658 * lread.c (read_from_string_index, read_from_string_index_byte)
3659 (read_from_string_limit, readchar, unreadchar, openp)
3660 (read_internal_start, read1, oblookup):
3661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3662 (Fload, readevalloop, Feval_buffer, Feval_region):
3663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3664 (openp): Check for out-of-range argument to 'access'.
3665 (read1): Use int, not EMACS_INT, where int is wide enough.
3666 Don't assume fixnum fits into int.
3667 Fix off-by-one error that can read outside a buffer.
3668 (read_filtered_event): Use duration_to_sec_usec
3669 to do proper overflow checking on durations.
3670 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3671 in size calculation.
3672 (Fexecute_kbd_macro):
3673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3674 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3675 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3676 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3677 (set_marker_both, set_marker_restricted_both, marker_position)
3678 (marker_byte_position, Fbuffer_has_markers_at):
3679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3680 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3681 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3682 It now merely ensures that the menu is large enough, without
3683 necessarily growing it, as this avoids some integer overflow issues.
3684 All callers changed.
3685 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3686 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3687 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3688 Use SAFE_ALLOCA_LISP, not alloca.
3689 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3690 to EMACS_INT. Check that fixnums are in proper range for system types.
3691 * minibuf.c (minibuf_prompt_width, string_to_object)
3692 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3693 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3695 (get_minibuffer, read_minibuf_unwind):
3696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3697 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3698 this simplifies overflow checking. All callers changed.
3699 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3702 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3703 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3704 Check that fixnums are in proper range for system types.
3705 (Fx_create_frame, Fx_show_tip):
3706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3707 * nsfont.m (ns_findfonts, nsfont_list_family):
3708 Don't assume fixnum fits in long.
3709 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3711 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3713 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3715 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3716 (PRINTDECLARE, PRINTPREPARE):
3717 (strout, print_string):
3718 (print, print_preprocess, print_check_string_charset_prop)
3720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3722 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3724 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3725 (printchar, strout): Use xpalloc to catch size calculation overflow.
3726 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3727 (print_error_message): Use SAFE_ALLOCA, not alloca.
3728 (print_object): Use int, not EMACS_INT, where int is wide enough.
3729 (print_depth, new_backquote_output, print_number_index):
3730 Use ptrdiff_t, not int, where int might not be wide enough.
3731 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3732 (Fset_process_window_size, Fformat_network_address)
3733 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3735 Check that fixnums are in proper range for system types.
3736 (Fsignal_process): Simplify by avoiding a goto.
3737 Check for process-ids out of pid_t range rather than relying on
3739 (process_tick, update_tick): Use EMACS_INT, not int.
3740 (Fformat_network_address, read_process_output, send_process)
3741 (Fprocess_send_region, status_notify):
3742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3743 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3744 (wait_reading_process_output, read_process_output, exec_sentinel):
3745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3746 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3747 (Faccept_process_output): Use duration_to_sec_usec to do proper
3748 overflow checking on durations.
3749 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3750 Don't assume pid_t fits in int.
3751 * process.h (struct Lisp_Process): Members tick and update_tick
3752 are now of type EMACS_INT, not int.
3753 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3754 configured --with-wide-int.
3755 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3756 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3757 * search.c (looking_at_1, string_match_1):
3758 (fast_string_match, fast_c_string_match_ignore_case)
3759 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3760 (scan_newline, find_before_next_newline, search_command)
3761 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3762 (set_search_regs, wordify):
3765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3766 (string_match_1, search_buffer, set_search_regs):
3768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3769 (wordify): Check for overflow in size calculation.
3770 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3771 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3772 Check that fixnums are in proper range for system types.
3773 * sound.c (struct sound_device)
3774 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3776 (Fplay_sound_internal):
3777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3778 * syntax.c (struct lisp_parse_state, find_start_modiff)
3779 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3780 (Fparse_partial_sexp):
3781 Don't assume fixnums can fit in int.
3782 (struct lisp_parse_state, find_start_pos, find_start_value)
3783 (find_start_value_byte, find_start_begv)
3784 (update_syntax_table, char_quoted, dec_bytepos)
3785 (find_defun_start, prev_char_comend_first, back_comment):
3786 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3787 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3789 (Finternal_describe_syntax_value): Check that match_lisp is a
3790 character, not an integer, since the code stuffs it into int.
3791 (scan_words, scan_sexps_forward):
3792 Check that fixnums are in proper range for system types.
3794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3795 (scan_sexps_forward):
3796 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3797 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3798 * syntax.h: Adjust decls to match defn changes elsewhere.
3799 (struct gl_state_s):
3800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3801 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3802 MOST_POSITIVE_FIXNUM.
3803 * sysdep.c (wait_for_termination_1, wait_for_termination)
3804 (interruptible_wait_for_termination, mkdir):
3805 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3806 (emacs_read, emacs_write):
3807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3808 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3809 and double all fit in int.
3810 * term.c (set_tty_color_mode):
3811 Check that fixnums are in proper range for system types.
3812 * termhooks.h (struct input_event):
3813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3814 * textprop.c (validate_interval_range, interval_of)
3815 (Fadd_text_properties, set_text_properties_1)
3816 (Fremove_text_properties, Fremove_list_of_text_properties)
3817 (Ftext_property_any, Ftext_property_not_all)
3818 (copy_text_properties, text_property_list, extend_property_ranges)
3819 (verify_interval_modification):
3820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3821 (Fnext_single_char_property_change)
3822 (Fprevious_single_char_property_change):
3823 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3824 (copy_text_properties):
3825 Check for integer overflow in index calculation.
3826 * undo.c (last_boundary_position, record_point, record_insert)
3827 (record_delete, record_marker_adjustment, record_change)
3828 (record_property_change):
3829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3830 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3832 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3833 (Fx_hide_tip, Fx_file_dialog):
3834 * w32menu.c (set_frame_menubar):
3835 Use ptrdiff_t, not int, for consistency with rest of code.
3836 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3837 (select_window, Fdelete_other_windows_internal)
3838 (window_scroll_pixel_based, window_scroll_line_based)
3839 (Frecenter, Fset_window_configuration):
3840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3841 (Fset_window_hscroll, run_window_configuration_change_hook)
3842 (set_window_buffer, temp_output_buffer_show, scroll_command)
3843 (Fscroll_other_window, Frecenter):
3844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3845 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3846 Don't assume fixnum fits in int.
3847 (Fset_window_scroll_bars):
3848 Check that fixnums are in proper range for system types.
3849 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3850 (string_pos, c_string_pos, number_of_chars, init_iterator)
3851 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3852 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3853 (compute_display_string_end, handle_face_prop)
3854 (face_before_or_after_it_pos, handle_invisible_prop)
3855 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3856 (display_prop_intangible_p, string_buffer_position_lim)
3857 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3858 (get_overlay_strings_1, get_overlay_strings)
3859 (iterate_out_of_display_property, forward_to_next_line_start)
3860 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3861 (get_next_display_element, set_iterator_to_next)
3862 (get_visually_first_element, compute_stop_pos_backwards)
3863 (handle_stop_backwards, next_element_from_buffer)
3864 (move_it_in_display_line_to, move_it_in_display_line)
3865 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3866 (add_to_log, message_dolog, message_log_check_duplicate)
3867 (message2, message2_nolog, message3, message3_nolog
3868 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3869 (current_message_1, truncate_echo_area, truncate_message_1)
3870 (set_message, set_message_1, store_mode_line_noprop)
3871 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3872 (text_outside_line_unchanged_p, check_point_in_composition)
3873 (reconsider_clip_changes)
3874 (redisplay_internal, set_cursor_from_row, try_scrolling)
3875 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3876 (redisplay_window, find_last_unchanged_at_beg_row)
3877 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3878 (trailing_whitespace_p, find_row_edges, display_line)
3879 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3880 (display_mode_element, store_mode_line_string)
3881 (pint2str, pint2hrstr, decode_mode_spec)
3882 (display_count_lines, display_string, draw_glyphs)
3883 (x_produce_glyphs, x_insert_glyphs)
3884 (rows_from_pos_range, mouse_face_from_buffer_pos)
3885 (fast_find_string_pos, mouse_face_from_string_pos)
3886 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3888 (safe_call, init_from_display_pos, handle_fontified_prop)
3889 (handle_single_display_spec, load_overlay_strings)
3890 (with_echo_area_buffer, setup_echo_area_for_printing)
3891 (display_echo_area, echo_area_display)
3892 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3893 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3894 (redisplay_window, dump_glyph_row, display_mode_line)
3895 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3896 (handle_display_spec, display_prop_string_p):
3897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3898 (handle_single_display_spec, build_desired_tool_bar_string)
3899 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3900 (get_specified_cursor_type):
3901 Check that fixnums are in proper range for system types.
3902 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3903 (Flookup_image_map):
3904 Don't assume fixnums fit in int.
3905 (compare_overlay_entries):
3906 Avoid mishandling comparisons due to subtraction overflow.
3907 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3908 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3909 (handle_tool_bar_click):
3910 Use int, not unsigned, since we prefer signed and the signedness
3911 doesn't matter here.
3912 (get_next_display_element, next_element_from_display_vector):
3913 Use int, not EMACS_INT, when int is wide enough.
3914 (start_hourglass): Use duration_to_sec_usec to do proper
3915 overflow checking on durations.
3916 * xfaces.c (Fbitmap_spec_p):
3917 Check that fixnums are in proper range for system types.
3918 (compare_fonts_by_sort_order):
3919 Avoid mishandling comparisons due to subtraction overflow.
3920 (Fx_family_fonts, realize_basic_faces):
3921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3923 Don't assume fixnum fits in int.
3924 Use SAFE_ALLOCA_LISP, not alloca.
3925 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3926 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3927 (face_at_buffer_position, face_for_overlay_string)
3928 (face_at_string_position):
3929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3930 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3931 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3933 Check that fixnums are in proper range for system types.
3934 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3935 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3937 (Fx_change_window_property): Don't assume fixnums fit in int.
3938 * xfont.c (xfont_chars_supported):
3939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3940 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3941 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3943 * xml.c (parse_region):
3944 * xrdb.c (magic_file_p):
3945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3946 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3947 (x_get_local_selection, x_reply_selection_request)
3948 (x_handle_selection_request, wait_for_property_change):
3949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3950 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3951 short is wide enough.
3952 (x_send_client_event): Don't assume fixnum fits in int.
3953 * xterm.c (x_x_to_emacs_modifiers):
3954 Don't assume EMACS_INT overflows nicely into int.
3955 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3957 (handle_one_xevent): NATNUMP can eval its arg twice.
3958 (x_connection_closed):
3959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3960 * xterm.h: Adjust decls to match defn changes elsewhere.
3961 (struct scroll_bar): Use struct vectorlike_header
3962 rather than rolling our own approximation.
3963 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3965 2012-05-25 Glenn Morris <rgm@gnu.org>
3967 * lisp.mk (lisp): Update for more files being compiled now.
3969 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3971 * lread.c: Remove `read_pure' which makes no difference.
3972 (read_pure): Remove var.
3973 (unreadpure): Remove function.
3974 (readevalloop): Don't call read_list with -1 flag.
3975 (read1, read_vector): Don't test read_pure any more.
3976 (read_list): Simplify.
3978 * fileio.c, character.h: Minor style tweaks.
3980 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3982 * window.h (clip_changed): Remove useless declaration.
3984 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3986 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3987 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3989 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3992 This directory predates autoconf and is no longer needed nowadays.
3993 Move its few remaining bits of functionality to where they're needed.
3994 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3995 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3996 * m/template.h: Remove.
3997 * Makefile.in (M_FILE): Remove. All uses removed.
3998 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3999 * lisp.h (USE_LSB_TAG):
4000 * mem-limits.h (EXCEEDS_LISP_PTR):
4001 Use VAL_MAX, not VALBITS, in #if.
4002 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4003 (EMACS_UINT): Define unconditionally now.
4004 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4005 (BITS_PER_EMACS_INT): New constants, replacing
4006 what used to be in config.h, but not useful in #if.
4007 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4008 define them any more.
4009 (VAL_MAX): New macro.
4011 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4012 BITS_PER_EMACS_INT, in #if.
4013 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4014 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4015 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4016 * s/ms-w32.h (DATA_START):
4017 Move here from removed file m/intel386.h.
4018 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4019 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4021 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4023 Assume C89 or later.
4024 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4025 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4027 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4028 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4029 * textprop.c, tparam.c (NULL): Remove.
4030 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4031 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4032 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4033 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4034 * xterm.c (input_signal_count): Assume volatile works.
4036 2012-05-21 Ken Brown <kbrown@cornell.edu>
4038 * xgselect.c (xg_select): Fix first argument in call to 'select'
4041 2012-05-20 Ken Brown <kbrown@cornell.edu>
4043 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4044 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4046 2012-05-19 Ken Brown <kbrown@cornell.edu>
4048 * xfns.c (x_in_use): Remove `static' qualifier.
4049 * xterm.h (x_in_use): Declare.
4050 * xgselect.c: Include xterm.h.
4051 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4052 and `display_arg' (bug#9754).
4054 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4056 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4058 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4059 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4061 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4063 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4065 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4066 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4068 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4069 reference to image_cache->refcount.
4070 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4072 2012-05-17 Juri Linkov <juri@jurta.org>
4074 * search.c (Fword_search_regexp, Fword_search_backward)
4075 (Fword_search_forward, Fword_search_backward_lax)
4076 (Fword_search_forward_lax): Move functions to isearch.el
4077 (bug#10145, bug#11381).
4079 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4081 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4083 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4085 * lread.c (init_obarray): Declare Qt and Qnil as special.
4087 2012-05-14 Glenn Morris <rgm@gnu.org>
4089 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4090 Put "libexec" before "bin", for the sake of init_callproc_1.
4092 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4094 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4096 * unexaix.c: Port to more-recent AIX compilers.
4097 (report_error, report_error_1, make_hdr, copy_sym)
4098 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4099 Make arguments const char *, not char *, to avoid violations of C
4100 standard and to fix some AIX warnings reported by Gilles Pion.
4102 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4104 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4105 already have overlays loaded.
4106 (handle_single_display_spec): Before returning without displaying
4107 fringe bitmap, synchronize the bidi iterator with the main display
4108 iterator, by calling iterate_out_of_display_property.
4109 (iterate_out_of_display_property): Detect buffer iteration by
4110 testing that it->string is a Lisp string.
4111 (get_next_display_element): When the current object is exhausted,
4112 and there's something on it->stack, call set_iterator_to_next to
4113 proceed with what's on the stack, instead of returning zero.
4114 (set_iterator_to_next): If called at the end of a Lisp string,
4115 proceed to consider_string_end without incrementing string
4116 position. Don't increment display vector index past the end of
4117 the display vector. (Bug#11417)
4118 (pos_visible_p): Don't report a position visible when move_it_to
4119 stopped at the last line of window, which happens to be scanned
4120 backwards by the bidi iteration. (Bug#11464)
4122 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4124 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4125 and right-margin display specs even if the spec is invalid or we
4126 are on a TTY, and thus unable to display on the fringes.
4127 That's because the text with the property will not be displayed anyway,
4128 so we need to signal to the caller that this is a "replacing"
4129 display spec. This fixes display when the spec is invalid or we
4132 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4134 * unexaix.c (make_hdr): Fix typo in prototype.
4135 This bug broke the build on AIX. Problem reported by Gilles Pion.
4137 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4139 * keyboard.c (kbd_buffer_get_event): Read special events also in
4140 batch mode. (Bug#11415)
4142 2012-05-12 Glenn Morris <rgm@gnu.org>
4144 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4146 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4148 * lisp.mk (lisp): Add newcomment.elc.
4150 2012-05-12 Glenn Morris <rgm@gnu.org>
4152 * Makefile.in (MKDIR_P): New, set by configure.
4153 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4155 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4157 Remove unused function hourglass_started.
4158 * dispextern.h (hourglass_started):
4159 * w32fns.c (hourglass_started):
4160 * xdisp.c (hourglass_started): Remove.
4162 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4164 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4165 Update dependencies.
4167 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4169 * xgselect.c (xg_select): Put maxfds+1 into a var.
4170 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4172 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4174 2012-05-10 Dave Abrahams <dave@boostpro.com>
4176 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4177 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4179 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4181 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4182 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4183 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4184 Initialize xd_registered_buses.
4186 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4188 Untag more efficiently if USE_LSB_TAG.
4189 This is based on a proposal by YAMAMOTO Mitsuharu in
4190 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4191 For an admittedly artificial (nth 8000 longlist) benchmark on
4192 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4193 Emacs's overall text size by 1%.
4194 * lisp.h (XUNTAG): New macro.
4195 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4196 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4197 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4198 * eval.c (Fautoload):
4199 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4200 * frame.h (XFRAME): Use XUNTAG.
4202 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4203 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4204 Remove unportable assumptions about print widths of types like
4206 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4207 intptr_t when converting between pointer and integer, to avoid GCC
4208 warnings about wrong width.
4210 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4212 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4213 stack for each reader_thread, instead of defaulting to 8MB
4214 determined by the linker. This avoids failures in creating
4215 subprocesses on Windows 7, see the discussion in this thread:
4216 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4218 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4220 Fix up display of the *Minibuf-0* buffer in the mini window.
4221 * keyboard.c (read_char): Don't clear the echo area if there's no
4223 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4224 contents of *Minibuf-0*) if there's no message displayed in its stead.
4226 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4228 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4231 2012-05-06 Chong Yidong <cyd@gnu.org>
4233 * lisp.mk (lisp): Update.
4235 2012-05-05 Jim Meyering <meyering@redhat.com>
4237 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4239 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4241 * data.c (PUT_ERROR): New macro.
4242 (syms_of_data): Use it. Add new error type `user-error'.
4243 * undo.c (user_error): New function.
4244 (Fprimitive_undo): Use it.
4245 * print.c (print_error_message): Adjust print style for `user-error'.
4246 * keyboard.c (user_error): New function.
4247 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4249 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4251 Do not limit current-time-string to years 1000..9999.
4252 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4253 (Fcurrent_time_string): Support any year that is supported by the
4254 underlying localtime representation. Don't use asctime, as it
4255 has undefined behavior for years outside the range -999..9999.
4257 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4259 Fix race conditions involving setenv, gmtime, localtime, asctime.
4260 Without this fix, interrupts could mess up code that uses these
4261 nonreentrant functions, since setting TZ invalidates existing
4262 tm_zone or tzname values, and since most of these functions return
4263 pointers to static storage.
4264 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4265 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4266 Grow the critical sections to include not just invoking
4267 localtime/gmtime, but also accessing these functions' results
4268 including their tm_zone values if any, and any related TZ setting.
4269 (format_time_string): Last arg is now struct tm *, not struct tm **,
4270 so that the struct tm is saved in the critical section.
4271 All callers changed. Simplify allocation of initial buffer, partly
4272 motivated by the fact that memory allocation needs to be outside
4273 the critical section.
4275 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4277 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4278 with RESET_INTERVAL.
4280 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4281 Remove duplicated buffer name initialization.
4283 2012-05-02 Jim Meyering <jim@meyering.net>
4285 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4287 * xfns.c (x_window): Use xstrdup (Bug#11375).
4289 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4291 * xdisp.c (pos_visible_p): If already at a newline from the
4292 display string before the 'while' loop, don't walk back the glyphs
4293 from it3.glyph_row. Solves assertion violation when the display
4294 string begins with a newline (egg.el). (Bug#11367)
4296 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4298 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4301 2012-05-01 Glenn Morris <rgm@gnu.org>
4303 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4304 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4305 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4306 All were removed before 23.1.
4308 * dispnew.c: Remove HAVE_LIBNCURSES test;
4309 it is always true on relevant platforms.
4311 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4312 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4314 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4316 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4318 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4319 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4322 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4324 Do not avoid creating empty evaporating overlays (Bug#9642).
4325 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4326 That is, do not delete an evaporating overlay if it becomes
4327 empty after its bounds are adjusted to fit within its buffer.
4328 This fix caused other problems, and I'm reverting it until we get
4329 to the bottom of them.
4331 2012-04-27 Chong Yidong <cyd@gnu.org>
4333 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4335 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4337 * xdisp.c (pos_visible_p): If the window start position is beyond
4338 ZV, start the display from buffer beginning. Prevents assertion
4339 violation in init_iterator when the minibuffer window is scrolled
4342 * window.c (window_scroll_pixel_based): Likewise.
4344 2012-04-27 Chong Yidong <cyd@gnu.org>
4346 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4348 2012-04-27 Glenn Morris <rgm@gnu.org>
4350 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4351 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4353 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4355 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4356 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4358 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4360 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4361 display element, check also the underlying string or buffer
4362 character. (Bug#11341)
4364 * w32menu.c: Include w32heap.h.
4365 (add_menu_item): If the call to AppendMenuW (via
4366 unicode_append_menu) fails, disable Unicode menus only if we are
4367 running on Windows 9X/Me.
4369 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4371 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4372 (xgetint): Add missing shift for LSB tags.
4374 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4376 * keyboard.c (read_char): Don't wipe echo area for select window
4377 events: These might get delayed via `mouse-autoselect-window'
4380 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4382 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4383 manipulation of :loaded-from data.
4385 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4387 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4388 now a cons (bug#11311).
4390 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4392 Do not create empty overlays with the evaporate property (Bug#9642).
4393 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4394 if it becomes empty after its bounds are adjusted to fit within
4395 its buffer. Without this fix, in a nonempty buffer (let ((o
4396 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4397 yields an empty overlay that has the evaporate property, which is
4398 not supposed to happen.
4400 Fix minor GTK3 problems found by static checking.
4401 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4402 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4403 (struct _EmacsFixedClass, emacs_fixed_get_type):
4404 Move decls here from emacsgtkfixed.h, since they needn't be public.
4405 (emacs_fixed_get_type): Now static.
4406 (emacs_fixed_class_init): Omit unused local.
4407 (emacs_fixed_child_type): Remove; unused.
4408 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4409 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4410 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4411 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4412 (EMACS_FIXED_GET_CLASS): Remove; unused.
4413 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4415 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4416 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4418 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4420 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4421 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4422 (__malloc_size_t, __malloc_ptrdiff_t):
4423 Remove. All uses removed, replaced by the definiens if needed,
4424 since we can assume C89 or better now.
4425 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4426 (protect_malloc_state, align, get_contiguous_space)
4427 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4428 (malloc_atfork_handler_child, malloc_enable_thread)
4429 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4430 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4431 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4432 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4433 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4434 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4435 Define using prototypes, not old style.
4436 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4437 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4438 (align): Don't assume that signed integer overflow wraps around.
4439 Omit unused local var.
4440 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4441 (_free_internal_nolock, memalign, mallochook, reallochook):
4442 Omit no-longer-needed casts.
4443 (valloc): Use getpagesize, not __getpagesize.
4444 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4445 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4447 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4449 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4451 Move functions from C to Lisp. Make non-blocking method calls
4452 the default. Implement further D-Bus standard interfaces.
4454 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4455 (QCdbus_request_name_allow_replacement)
4456 (QCdbus_request_name_replace_existing)
4457 (QCdbus_request_name_do_not_queue)
4458 (QCdbus_request_name_reply_primary_owner)
4459 (QCdbus_request_name_reply_in_queue)
4460 (QCdbus_request_name_reply_exists)
4461 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4462 (QCdbus_registered_serial, QCdbus_registered_method)
4463 (QCdbus_registered_signal): New Lisp objects.
4464 (XD_DEBUG_MESSAGE): Use sizeof.
4465 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4466 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4467 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4468 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4469 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4470 (xd_signature, xd_append_arg): Allow float for integer types.
4471 (xd_get_connection_references): New function.
4472 (xd_get_connection_address): Rename from xd_initialize.
4473 Return cached address.
4474 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4475 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4477 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4478 Return number of refcounts.
4479 (Fdbus_get_unique_name): Make stronger parameter check.
4480 (Fdbus_message_internal): New defun.
4481 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4482 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4483 (Fdbus_send_signal, Fdbus_register_service)
4484 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4485 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4486 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4487 (Vdbus_compiled_version, Vdbus_runtime_version)
4488 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4489 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4490 (Vdbus_message_type_signal): New defvars.
4491 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4494 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4496 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4497 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4498 Do not assume ptrdiff_t is the same width as 'int'.
4500 * alloc.c: Handle unusual debugging option combinations.
4501 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4502 since the two debugging options are incompatible.
4503 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4505 (mem_init, mem_insert, mem_insert_fixup):
4506 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4507 (NEED_MEM_INSERT): Remove; no longer needed.
4509 2012-04-22 Leo Liu <sdl.web@gmail.com>
4511 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4513 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4515 * sysdep.c [__FreeBSD__]: Minor cleanups.
4516 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4517 Use Emacs indenting style more consistently. Avoid some casts.
4518 Use 'double' consistently rather than mixing 'float' and 'double'.
4520 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4522 * sysdep.c (list_system_processes, system_process_attributes):
4523 Add implementation for FreeBSD (Bug#5243).
4525 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4527 * lisp.mk (lisp): Update.
4529 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4531 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4532 It is never used otherwise.
4534 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4536 * print.c (print_preprocess): Only check print_depth if print-circle
4538 (print_object): Check for cycles even when print-circle is nil and
4539 print-gensym is t, but only check print_depth if print-circle is nil.
4541 2012-04-20 Chong Yidong <cyd@gnu.org>
4543 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4544 set the status to "failed" and ensure that sentinel is run.
4546 2012-04-20 Glenn Morris <rgm@gnu.org>
4548 * process.c (Fset_process_inherit_coding_system_flag)
4549 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4550 (Fmake_network_process, Fmake_serial_process): Doc fix.
4552 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4554 * xdisp.c (string_buffer_position_lim): Limit starting position to
4556 (set_cursor_from_row): If called for a mode-line or header-line
4557 row, return zero immediately.
4558 (try_cursor_movement): If inside continuation line, don't back up
4559 farther than the first row after the header line, if any.
4560 Don't consider the header-line row as "partially visible", even if
4561 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4563 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4565 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4568 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4569 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4571 configure: new option --enable-gcc-warnings (Bug#11207)
4572 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4573 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4574 (ALL_CFLAGS): Use new macros rather than old.
4575 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4576 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4577 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4578 -Wunused-result, -Wunused-variable. This should go away once
4579 the Emacs and Gnulib regex code is merged.
4580 (xmalloc, xrealloc): Now static.
4582 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4584 * dired.c (Fsystem_groups): Remove unused local.
4586 2012-04-17 Glenn Morris <rgm@gnu.org>
4588 * dired.c (Fsystem_users): Doc fix.
4590 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4592 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4593 (syms_of_dired): Add them.
4595 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4597 Fix minor alloc.c problems found by static checking.
4598 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4599 New extern decls, to avoid calling undeclared functions.
4600 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4601 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4602 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4603 (NEED_MEM_INSERT): New macro.
4604 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4605 Remove one incorrect comment and fix another.
4607 Fix minor ralloc.c problems found by static checking.
4608 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4609 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4610 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4611 (r_alloc_sbrk): Now static.
4613 Improve ralloc.c interface checking.
4614 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4615 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4616 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4617 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4618 [REL_ALLOC]: ... to here, to check interface.
4619 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4620 Remove decls. This fixes an "It stinks!".
4622 * alloc.c (which_symbols): Fix alignment issue / type clash.
4624 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4626 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4627 (struct Lisp_Misc_Any): Likewise.
4628 (struct Lisp_Free): Likewise.
4629 * alloc.c (union aligned_Lisp_Symbol): Define.
4630 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4631 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4632 (union aligned_Lisp_Misc): Define.
4633 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4634 aligned_Lisp_Misc instead of union Lisp_Misc.
4635 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4637 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4639 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4640 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4641 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4642 * s/netbsd.h, s/sol2-6.h:
4643 Remove definition of GC_MARK_STACK, since the default now works.
4644 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4645 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4646 no longer the default.
4647 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4649 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4651 * lread.c (lisp_file_lexically_bound_p):
4652 Fix hang at ";-*-\n" (bug#11238).
4654 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4656 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4657 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4659 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4661 * nsterm.m (constrainFrameRect): Always constrain when there is only
4662 one screen (Bug#10962).
4664 2012-04-13 Ken Brown <kbrown@cornell.edu>
4666 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4668 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4670 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4672 2012-04-11 Daniel Colascione <dancol@dancol.org>
4674 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4675 against is gone. It's better to use vfork now so that when Cygwin
4676 gains a new, working vfork, we use it automatically (bug#10398).
4678 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4680 * window.c (save_window_save): Obey window-point-insertion-type.
4682 2012-04-11 Glenn Morris <rgm@gnu.org>
4684 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4686 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4688 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4690 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4692 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4693 (force_quit_count): New var.
4694 (handle_interrupt): Use it.
4696 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4698 * w32.c (w32_delayed_load): Record the full path of the library
4699 being loaded (bug#10424).
4701 2012-04-09 Glenn Morris <rgm@gnu.org>
4703 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4704 not just in the obarray, before snarfing them. (Bug#11036)
4706 * Makefile.in ($(leimdir)/leim-list.el):
4707 Pass EMACS rather than BUILT_EMACS.
4709 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4711 * process.c (make_process):
4712 * process.h: Add integer `gnutls_handshakes_tried' member to
4715 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4716 Add convenience `GNUTLS_LOG2i' macro.
4718 * gnutls.c (gnutls_log_function2i): Convenience log function.
4719 (emacs_gnutls_read): Use new log functions,
4720 `gnutls_handshakes_tried' process member, and
4721 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4722 attempts per process (connection).
4724 2012-04-09 Chong Yidong <cyd@gnu.org>
4726 * eval.c (Fuser_variable_p, user_variable_p_eh)
4727 (lisp_indirect_variable): Functions deleted.
4728 (Fdefvar): Caller changed.
4730 * callint.c (Finteractive, Fcall_interactively):
4731 * minibuf.c (Fread_variable): Callers changed.
4733 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4735 * xdisp.c (set_cursor_from_row): If the display string appears in
4736 the buffer at position that is closer to point than the position
4737 after the display string, display the cursor on the first glyph of
4738 the display string. Fixes cursor display when a 'display' text
4739 property immediately follows invisible text. (Bug#11094)
4741 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4743 composite.c: use 'double' consistently
4744 * composite.c (get_composition_id): Use 'double' consistently
4745 instead of converting 'float' to 'double' and vice versa; this is
4746 easier to understand and avoids a GCC warning.
4748 2012-04-09 Glenn Morris <rgm@gnu.org>
4750 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4751 preparation for dumping it with emacs. (Bug#4789)
4752 (leimdir): New variable.
4753 ($(leimdir)/leim-list.el): New rule.
4754 (emacs$(EXEEXT)): Depend on leim-list.el.
4756 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4757 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4758 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4760 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4762 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4765 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4767 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4768 Remove unused local variable.
4770 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4772 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4773 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4774 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4775 objects, as mark_maybe_pointer will catch them otherwise.
4776 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4777 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4779 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4781 Fix typo that broke non-Windows builds.
4782 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4784 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4786 Support building on MS-Windows with libxml2.
4788 * makefile.w32-in (OBJ2): Add xml.$(O).
4789 (GLOBAL_SOURCES): Add xml.c.
4790 ($(BLD)/xml.$(O)): New dependency list.
4792 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4793 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4794 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4795 [!WINDOWSNT]: New macros.
4796 (init_libxml2_functions, libxml2_loaded_p): New functions.
4797 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4798 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4799 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4800 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4802 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4803 Call init_libxml2_functions before calling libxml2 functions.
4804 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4806 * emacs.c: Don't include libxml/parser.h.
4807 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4808 xmlCleanupParser directly.
4810 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4812 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4814 * indent.c (Fvertical_motion): If there is a display string at
4815 point, use it.vpos to compute how many lines to backtrack after
4816 move_it_to point. (Bug#11133)
4818 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4820 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4821 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4822 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4823 macros related to unification of CJK characters. For the details,
4824 see the discussion following the message here:
4825 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4827 2012-04-04 Chong Yidong <cyd@gnu.org>
4829 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4831 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4833 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4834 instead of alloca. (Bug#11138)
4836 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4838 * w32menu.c (is_simple_dialog): Properly check lisp types.
4841 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4843 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4844 position we get to after a call to move_it_to fails the
4845 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4846 only if we wind up in a string from display property. (Bug#11063)
4848 * window.c (Fdelete_other_windows_internal): Invalidate the row
4849 and column information about mouse highlight, so that redisplay
4850 restores it after reallocating the glyph matrices. (Bug#7464)
4852 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4853 string comes from a `display' text property, use the buffer
4854 position of that property as if we actually saw that position in
4856 (move_it_by_lines): Remove the assertion that
4857 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4858 violated when there's a before-string at the beginning of a line.
4861 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4863 * xdisp.c (append_space_for_newline): If the default face was
4864 remapped, use the remapped face for the appended newline.
4865 (extend_face_to_end_of_line): Use the remapped default face for
4866 extending the face to the end of the line.
4867 (display_line): Call extend_face_to_end_of_line when the default
4868 face was remapped. (Bug#11068)
4870 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4872 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4874 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4876 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4878 2012-03-27 Glenn Morris <rgm@gnu.org>
4880 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4883 2012-03-26 Kenichi Handa <handa@m17n.org>
4885 * dispextern.h (struct glyph): Fix previous change. Change the
4886 bit length of glyphless.ch to 25 (Bug#11082).
4888 2012-03-26 Chong Yidong <cyd@gnu.org>
4890 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4891 (command_loop_1): Use it; inhibit selection update for
4892 handle-select-window too (Bug#8996).
4894 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4896 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4898 2012-03-25 Kenichi Handa <handa@m17n.org>
4900 * dispextern.h (struct glyph): Change the bit length of
4901 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4903 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4905 * s/ms-w32.h (tzname): Include time.h before redirecting to
4906 _tzname. Fixes the MSVC build. (Bug#9960)
4908 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4910 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4913 * xterm.c (XTread_socket): Only modify handling_signal if
4914 !SYNC_INPUT. (Bug#11080)
4916 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4918 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4919 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4920 when fetching a multibyte character consumes more bytes than
4921 CHAR_BYTES returns, due to unification of CJK characters in
4922 string_char. (Bug#11073)
4924 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4926 * process.c (wait_reading_process_output): Handle pty disconnect
4927 by refraining from sending oneself a SIGCHLD (bug#10933).
4929 2012-03-22 Chong Yidong <cyd@gnu.org>
4931 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4933 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4934 Mark string as coming from a prefix property.
4935 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4936 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4938 2012-03-21 Chong Yidong <cyd@gnu.org>
4940 * xfaces.c (Vface_remapping_alist): Doc fix.
4942 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4944 * w32proc.c (Fw32_set_console_codepage)
4945 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4948 2012-03-20 Chong Yidong <cyd@gnu.org>
4950 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4951 to reflect default non-nil value of redisplay-dont-pause.
4953 2012-03-19 Kenichi Handa <handa@m17n.org>
4955 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4956 it fit in a valid range (Bug#11003).
4958 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4960 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4961 that is not from display property, accept the row as a "cursor
4962 row" if one of the string's character has a non-nil `cursor'
4963 property. Fixes cursor positioning when there are newlines in
4964 overlay strings, e.g. in icomplete.el. (Bug#11035)
4966 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4968 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4970 2012-03-12 Chong Yidong <cyd@gnu.org>
4972 * eval.c (inhibit_lisp_code): Rename from
4973 inhibit_window_configuration_change_hook; move from window.c.
4975 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4976 * window.c (run_window_configuration_change_hook)
4977 (syms_of_window): Callers changed.
4979 2012-03-11 Chong Yidong <cyd@gnu.org>
4981 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4983 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4985 2012-03-10 Chong Yidong <cyd@gnu.org>
4987 * frame.c (other_visible_frames): Don't assume the selected frame
4988 is visible (Bug#10955).
4990 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4992 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4994 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4996 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4997 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5000 2012-03-03 Glenn Morris <rgm@gnu.org>
5002 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5004 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5006 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5007 position past the first glyph_row that ends at ZV. (Bug#10902)
5008 (redisplay_window, next_element_from_string): Fix typos in
5010 (redisplay_window): Pass to move_it_vertically the margin in
5011 pixels, not in screen lines.
5013 2012-03-02 Glenn Morris <rgm@gnu.org>
5015 * buffer.c (buffer-list-update-hook): Doc fix.
5017 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5019 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5020 push_it before setting up the iterator for the first overlay
5021 string, even if we have an empty string loaded.
5022 (next_overlay_string): If there's an empty string on the iterator
5023 stack, pop the stack. (Bug#10903)
5025 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5027 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5028 Suggested by Stefan Monnier in
5029 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5030 * alloc.c (widen_to_Lisp_Object): New static function.
5031 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5032 and widening them to Lisp_Objects. This would work even if
5033 USE_LSB_TAG is defined and wide integers are used, which might
5034 happen in a future version of Emacs.
5036 2012-02-25 Chong Yidong <cyd@gnu.org>
5038 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5041 * xselect.c (Fx_selection_exists_p): Doc fix.
5042 (x_clipboard_manager_save_all): Print an informative message
5043 before saving to clipboard manager.
5045 2012-02-24 Chong Yidong <cyd@gnu.org>
5047 * keyboard.c (process_special_events): Handle all X selection
5048 requests in kbd_buffer, not just the next one (Bug#8869).
5050 2012-02-23 Chong Yidong <cyd@gnu.org>
5052 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5053 call when setting menu-bar-lines and tool-bar-lines parameters.
5054 (unwind_create_frame_1): New helper function.
5056 * window.c (inhibit_window_configuration_change_hook): New var.
5057 (run_window_configuration_change_hook): Obey it.
5058 (syms_of_window): Initialize it.
5060 2012-02-22 Chong Yidong <cyd@gnu.org>
5062 * xterm.c (x_draw_image_relief): Add missing type check for
5063 Vtool_bar_button_margin (Bug#10743).
5065 2012-02-21 Chong Yidong <cyd@gnu.org>
5067 * fileio.c (Vfile_name_handler_alist): Doc fix.
5069 * buffer.c (Fget_file_buffer): Protect against invalid file
5070 handler return value.
5072 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5074 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5075 when computing $valmask.
5077 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5078 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5079 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5080 It's useless in that case, and it can cause problems on hosts
5081 that allocate halves of EMACS_INT values separately.
5082 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5083 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5084 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5085 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5086 it avoids undefined behavior on hosts where shifting right by more
5087 than the word width has undefined behavior.
5089 2012-02-19 Chong Yidong <cyd@gnu.org>
5091 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5092 (Funhandled_file_name_directory, Ffile_name_as_directory)
5093 (Fdirectory_file_name, Fexpand_file_name)
5094 (Fsubstitute_in_file_name): Protect against invalid file handler
5095 return values (Bug#10845).
5097 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5099 * .gdbinit (pitx): Fix incorrect references to fields of the
5102 2012-02-17 Chong Yidong <cyd@gnu.org>
5104 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5106 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5108 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5109 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5111 2012-02-15 Chong Yidong <cyd@gnu.org>
5113 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5114 marked as special. Also, starting docstrings with * is obsolete.
5116 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5118 * gnutls.c (emacs_gnutls_write): Fix last change.
5120 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5122 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5125 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5127 * keymap.c (Fsingle_key_description): Handle char ranges.
5129 2012-02-12 Chong Yidong <cyd@gnu.org>
5131 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5132 as that creates a dangerous corner case.
5134 * window.c (Fdelete_window_internal): Invalidate the mouse
5135 highlight (Bug#9904).
5137 2012-02-12 Glenn Morris <rgm@gnu.org>
5139 * xselect.c (Fx_own_selection_internal)
5140 (Fx_get_selection_internal, Fx_disown_selection_internal)
5141 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5142 * nsselect.m (Fx_own_selection_internal)
5143 (Fx_disown_selection_internal, Fx_selection_exists_p)
5144 (Fx_selection_owner_p, Fx_get_selection_internal):
5145 Sync docs and argument specs with the xselect.c versions.
5147 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5149 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5151 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5153 * w32select.c (Fx_selection_exists_p): Sync doc string and
5154 argument list with xselect.c. (Bug#10783)
5156 * w16select.c (Fx_selection_exists_p): Sync doc string and
5157 argument list with xselect.c. (Bug#10783)
5159 2012-02-10 Glenn Morris <rgm@gnu.org>
5161 * fns.c (Fsecure_hash): Doc fix.
5163 2012-02-09 Kenichi Handa <handa@m17n.org>
5165 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5167 2012-02-07 Chong Yidong <cyd@gnu.org>
5169 * buffer.c (Fbuffer_local_variables)
5170 (buffer_lisp_local_variables): Handle unbound vars correctly;
5171 don't let Qunbound leak into Lisp.
5173 2012-02-07 Glenn Morris <rgm@gnu.org>
5175 * image.c (Fimagemagick_types): Doc fix.
5177 * image.c (imagemagick-render-type): Change it from a lisp object
5178 to an integer. Move the doc here from the lisp manual.
5179 Treat all values not equal to 0 the same.
5181 2012-02-06 Chong Yidong <cyd@gnu.org>
5183 * doc.c (store_function_docstring): Avoid applying docstring of
5184 alias to base function (Bug#2603).
5186 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5188 * .gdbinit (pp1, pv1): Remove redundant defines.
5191 2012-02-04 Chong Yidong <cyd@gnu.org>
5193 * nsterm.m: Declare a global (Bug#10694).
5195 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5197 * w32.c (get_emacs_configuration_options):
5198 Include --enable-checking, if specified, in the return value.
5200 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5202 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5203 after rounding frame sizes. (Bug#9723)
5205 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5207 * keyboard.c (adjust_point_for_property): Don't position point
5208 before BEGV. (Bug#10696)
5210 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5212 Handle overflow when computing char display width (Bug#9496).
5213 * character.c (char_width): Return EMACS_INT, not int.
5214 (char_width, c_string_width): Check for overflow when
5215 computing the width; this is possible now that individual
5216 characters can have unbounded width. Problem introduced
5217 by merge from Emacs 23 on 2012-01-19.
5219 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5221 * dbusbind.c (Fdbus_register_method): Mention the return value
5222 :ignore in the docstring.
5224 2012-02-02 Glenn Morris <rgm@gnu.org>
5226 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5228 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5229 Unconditionally set to t. (Bug#10673)
5230 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5231 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5232 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5234 2012-02-02 Kenichi Handa <handa@m17n.org>
5236 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5237 0, do not call append_composite_glyph.
5239 2012-02-02 Kenichi Handa <handa@m17n.org>
5241 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5243 (x_produce_glyphs): If the component of a composition is a null
5244 string, set it->pixel_width to 1 to avoid zero-width glyph.
5246 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5248 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5249 first 2 arguments are identical. This makes inserting large
5250 output from a subprocess an order of magnitude faster on
5251 MS-Windows, where all sbrk'ed memory is always contiguous.
5253 2012-01-31 Glenn Morris <rgm@gnu.org>
5255 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5256 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5257 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5259 2012-01-29 Glenn Morris <rgm@gnu.org>
5261 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5263 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5265 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5267 2012-01-28 Chong Yidong <cyd@gnu.org>
5269 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5271 2012-01-26 Chong Yidong <cyd@gnu.org>
5273 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5275 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5276 repeat counts (Bug#10507).
5278 2012-01-26 Glenn Morris <rgm@gnu.org>
5280 * lread.c (syms_of_lread): Doc fix.
5282 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5284 * coding.c (encode_designation_at_bol): Change return value to
5287 2012-01-25 Chong Yidong <cyd@gnu.org>
5289 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5291 2012-01-21 Chong Yidong <cyd@gnu.org>
5293 * floatfns.c (Fcopysign): Make the second argument non-optional,
5294 since nil is not allowed anyway.
5296 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5298 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5299 (send_process): Likewise.
5301 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5303 * window.c (save_window_save, Fcurrent_window_configuration)
5304 (Vwindow_persistent_parameters): Do not use Qstate.
5305 Rewrite doc-strings.
5307 2012-01-19 Kenichi Handa <handa@m17n.org>
5309 * character.c (char_width): New function.
5310 (Fchar_width, c_string_width, lisp_string_width):
5311 Use char_width (Bug#9496).
5313 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5315 * window.c (Vwindow_persistent_parameters): New variable.
5316 (Fset_window_configuration, save_window_save): Handle persistent
5319 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5321 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5322 thrashing the stack of the thread. (Bug#9087)
5324 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5326 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5328 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5330 * xdisp.c (rows_from_pos_range): Handle the case where the
5331 highlight ends on a newline. (Bug#10464)
5332 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5333 he end column for display of highlight that ends on a newline
5336 2012-01-11 Glenn Morris <rgm@gnu.org>
5338 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5339 from load-path also when installation-directory is nil. (Bug#10208)
5341 2012-01-10 Glenn Morris <rgm@gnu.org>
5343 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5345 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5346 Update template values to be closer to their typical values these days.
5348 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5350 * xdisp.c (rows_from_pos_range): Accept additional argument
5351 DISP_STRING, and accept any glyph in a row whose object is that
5352 string as eligible for mouse highlight. Fixes mouse highlight of
5353 display strings from overlays. (Bug#10464)
5355 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5357 emacs: fix an auto-save permissions race condition (Bug#10400)
5358 * fileio.c (auto_saving_dir_umask): New static var.
5359 (Fmake_directory_internal): Use it.
5360 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5361 creating the directory. The old code temporarily assigns
5362 too-generous permissions to the directory.
5363 (do_auto_save_eh): Clear it.
5364 (Fdo_auto_save): Catch all errors, not just file errors, so
5365 that the var is always cleared.
5367 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5369 * search.c (scan_buffer): Pass character positions to
5370 know_region_cache, not byte positions. (Bug#6540)
5372 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5374 * w32.c (sys_rename): Report EXDEV when rename of a directory
5375 fails because the target is on another logical disk. (Bug#10284)
5377 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5379 * xterm.c (x_embed_request_focus): New function.
5381 * xterm.h: Add prototype.
5383 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5385 2012-01-05 Glenn Morris <rgm@gnu.org>
5387 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5389 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5391 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5392 Load gnutls_transport_set_lowat only if GnuTLS version is below
5394 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5395 GnuTLS versions below 2.11.1.
5397 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5399 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5400 to the doc string advising against its use for altering the way
5401 windows are scrolled.
5403 2011-12-28 Kenichi Handa <handa@m17n.org>
5405 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5406 coding-system ASCII compatible only when it does not produce BOM
5407 on encoding (Bug#10383).
5409 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5411 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5413 (create_and_show_popup_menu): Always use menu_position_func for
5416 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5418 * callint.c (Fcall_interactively): Don't truncate prompt string.
5420 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5422 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5423 property that ends at ZV, so that the bidi iteration could be
5424 resumed from there (after widening). (Bug#10360)
5426 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5428 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5430 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5432 * nsterm.m (x_free_frame_resources):
5433 Release f->output_data.ns->miniimage.
5434 (ns_index_color): Fix indentation. Do not retain
5435 color_table->colors[i].
5437 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5440 * nsfns.m (x_set_background_color): Assign return value from
5441 ns_index_color to face-background instead of NSColor*.
5442 (ns_implicitly_set_icon_type): Fix indentation.
5443 Change assignment in for loop to comparison.
5445 * emacs.c (ns_pool): New variable.
5446 (main): Assign ns_pool.
5447 (Fkill_emacs): Call ns_release_autorelease_pool.
5449 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5450 autorelease fdesc, release fdAttrs and tdict.
5451 (ns_get_covering_families): Release charset.
5452 (ns_findfonts): Release NSFontDescriptor created with new.
5453 (ns_uni_to_glyphs): Fix indentation.
5454 (setString): Release attrStr before assigning new value.
5456 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5458 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5460 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5461 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5463 2011-12-18 David Reitter <reitter@cmu.edu>
5465 * nsterm.m (ns_term_init): Subscribe for notifications
5466 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5467 to method trackingNotification in EmacsMenu.
5469 * nsmenu.m (trackingMenu): New variable.
5470 (trackingNotification): New method (from Aquamacs).
5471 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5472 from Aquamacs (Bug#7030).
5474 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5476 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5477 (symbol_to_nsstring): Fix indentation.
5478 (ns_symbol_to_pb): New function.
5479 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5480 (Fns_rotate_cut_buffers_internal): Remove.
5481 (Fns_store_selection_internal): Rename from
5482 Fns_store_cut_buffer_internal.
5483 (ns_get_foreign_selection, Fx_own_selection_internal)
5484 (Fx_disown_selection_internal, Fx_selection_exists_p)
5485 (Fns_get_selection_internal, Fns_store_selection_internal):
5486 Use ns_symbol_to_pb and check if return value is nil.
5487 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5488 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5489 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5490 renamed to Sns_store_selection_internal.
5491 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5492 and remove this function.
5493 (ns_handle_selection_clear): Remove, never used.
5494 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5497 2011-12-17 Ken Brown <kbrown@cornell.edu>
5499 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5500 GID is unknown (Bug#10257).
5502 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5504 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5505 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5506 which caused a build failure on GNU/Linux IA-64. This problem was
5507 introduced by my 2011-10-07 patch.
5509 2011-12-15 Juri Linkov <juri@jurta.org>
5511 * image.c (imagemagick_error): New function. (Bug#10112)
5512 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5513 Use `imagemagick_error' where ImageMagick functions return
5515 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5518 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5520 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5521 fill background (Bug#8992).
5523 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5525 * window.c (Vwindow_combination_resize)
5526 (Vwindow_combination_limit): Use t instead of non-nil in
5528 (Vrecenter_redisplay): Add first sentence of doc-string on
5530 (Frecenter): Fix doc-string typo.
5532 2011-12-11 Kenichi Handa <handa@m17n.org>
5534 * coding.c (Funencodable_char_position): Pay attention to the
5535 buffer text relocation (Bug#9389).
5537 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5539 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5540 gtk_init (Bug#10100).
5542 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5544 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5545 IT->string is nil. (Bug#10263)
5547 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5549 * nsterm.h (x_free_frame_resources): Declare.
5551 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5552 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5554 * nsterm.h (ns_get_defaults_value): Declare.
5556 * nsterm.m (ns_default): Call ns_get_defaults_value.
5558 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5560 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5563 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5565 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5566 that where the value of an _OBJC_* symbol points to is in the .bss
5567 section (Bug#10240).
5569 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5571 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5572 after the loop to call ccl_driver at least once (Bug#8619).
5574 2011-12-08 Kenichi Handa <handa@m17n.org>
5576 * ftfont.c (get_adstyle_property): Fix previous change
5579 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5581 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5582 dirs from the default value of EMACSLOADPATH (bug#10208).
5584 2011-12-07 Glenn Morris <rgm@gnu.org>
5586 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5587 installation and source directories as well. (Bug#10208)
5589 2011-12-06 Chong Yidong <cyd@gnu.org>
5591 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5593 2011-12-06 Glenn Morris <rgm@gnu.org>
5595 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5596 as an error, not just -1. (Bug#10217)
5598 2011-12-05 Chong Yidong <cyd@gnu.org>
5600 * keyboard.c (process_special_events): New function.
5601 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5603 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5605 * coding.c (encode_designation_at_bol): Don't use uninitialized
5606 local variable (Bug#9318).
5608 2011-12-05 Kenichi Handa <handa@m17n.org>
5610 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5611 return Qnil (Bug#8046, Bug#10193).
5613 2011-12-05 Kenichi Handa <handa@m17n.org>
5615 * coding.c (encode_designation_at_bol): New args charbuf_end and
5616 dst. Return the number of produced bytes. Callers changed.
5617 (coding_set_source): Return how many bytes coding->source was
5619 (coding_set_destination): Return how many bytes
5620 coding->destination was relocated.
5621 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5622 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5624 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5626 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5627 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5630 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5632 The following changes are to fix Bug#9318.
5634 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5635 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5636 (encode_coding_iso_2022, encode_coding_sjis)
5637 (encode_coding_big5, encode_coding_charset): Use the above macros.
5639 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5641 * lisp.h (process_quit_flag): Fix external declaration.
5643 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5645 Don't macro-inline non-performance-critical code.
5646 * eval.c (process_quit_flag): New function.
5647 * lisp.h (QUIT): Use it.
5649 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5651 * nsfns.m (get_geometry_from_preferences): New function.
5652 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5654 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5656 * emacs.c (Qkill_emacs): Define.
5657 (syms_of_emacs): Initialize it.
5658 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5659 Qquit_flag to `kill-emacs' instead.
5660 (quit_throw_to_read_char): Add parameter `from_signal'.
5661 All callers changed. Call Fkill_emacs if requested and safe.
5662 * lisp.h (QUIT): Call Fkill_emacs if requested.
5664 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5666 * widget.c (update_wm_hints): Return if wmshell is null.
5667 (widget_update_wm_size_hints): New function.
5669 * widget.h (widget_update_wm_size_hints): Declare.
5671 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5672 widget_update_wm_size_hints (Bug#10104).
5674 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5676 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5677 before a newline, prepare the bidi iterator for consuming the
5678 newline, and keep the current paragraph direction. (Bug#10183)
5679 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5681 2011-12-02 Juri Linkov <juri@jurta.org>
5683 * search.c (Fword_search_regexp): New Lisp function created from
5684 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5685 (Fword_search_backward, Fword_search_forward)
5686 (Fword_search_backward_lax, Fword_search_forward_lax):
5687 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5688 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5690 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5692 * fileio.c (Finsert_file_contents): Move after-change-function call
5693 to before the "handled:" label, since all "goto handled" appear in
5694 cases where the *-change-functions have already been properly called
5697 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5699 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5700 waiting for input. (Bug#10169)
5702 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5704 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5705 verifies glyph row's hash code--we have just reallocated the
5706 glyphs, so their contents can be complete garbage. (Bug#10164)
5708 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5710 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5712 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5714 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5715 attributes are tested _before_ calling verify_row_hash, to protect
5716 against GCC re-ordering of the tests. (Bug#10164)
5718 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5720 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5722 * xterm.c (handle_one_xevent): Only set async_visible and friends
5723 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5724 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5725 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5727 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5729 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5730 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5731 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5732 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5733 All uses changed to use GCPRO1 etc.
5734 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5735 Revert to old implementation (i.e., before 2011-03-11).
5737 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5739 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5740 of scroll runs so as to avoid assigning disabled bogus rows and
5741 unnecessary graphics copy operations.
5743 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5745 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5746 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5747 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5748 (malloc, free, realloc, calloc): Redirect to e_* only when
5751 * lisp.h (GCTYPEBITS): Move before first use.
5752 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5753 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5754 this macro definition.
5756 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5759 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5761 * gtkutil.c (xg_create_frame_widgets):
5762 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5763 present with Gtk+ 2.0.
5765 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5767 * fileio.c (Finsert_file_contents): Undo previous change; see
5768 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5770 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5772 Rename locals to avoid shadowing.
5773 * fileio.c (Finsert_file_contents):
5774 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5775 * process.c (wait_reading_process_output):
5776 Rename inner 'proc' to 'p' to avoid shadowing.
5777 Indent for consistency with usual Emacs style.
5779 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5781 * xdisp.c (redisplay_window): If cursor row is not fully visible
5782 after recentering, and scroll-conservatively is set to a large
5783 number, scroll window by a few more lines to make the cursor fully
5784 visible and out of scroll-margin. (Bug#10105)
5785 (start_display): Don't move to the next line if the display should
5786 start at a newline that is part of a display vector or an overlay
5789 2011-11-24 Juri Linkov <juri@jurta.org>
5791 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5792 after the `MagickPingImage' call. (Bug#10112)
5794 2011-11-23 Chong Yidong <cyd@gnu.org>
5796 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5798 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5800 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5801 making another buffer current. (Bug#10114)
5803 2011-11-23 Glenn Morris <rgm@gnu.org>
5805 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5807 2011-11-23 Chong Yidong <cyd@gnu.org>
5809 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5810 using it (Bug#5984).
5812 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5814 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5815 and header-lines, as they don't have one computed for them.
5818 * .gdbinit (prow): Make displayed values more self-explaining.
5819 Add row's hash code.
5821 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5823 * process.c (wait_reading_process_output): Fix asynchrounous
5824 GnuTLS socket handling on some versions of the GnuTLS library.
5825 (wait_reading_process_output): Add comment and URL.
5827 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5829 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5831 2011-11-21 Chong Yidong <cyd@gnu.org>
5833 * window.c (Fnext_window, Fprevious_window): Doc fix.
5835 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5837 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5839 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5841 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5843 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5845 * window.c (Fset_window_combination_limit): Rename argument
5847 (Vwindow_combination_limit): Remove "status" from doc-string.
5849 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5851 * m/ibms390.h: Remove.
5852 * m/ibms390x.h: Don't include "ibms390.h".
5854 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5856 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5857 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5859 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5861 * casetab.c (Fset_case_table):
5862 * charset.c (Fcharset_after): Fix typos.
5864 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5866 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5867 Otherwise, valgrind does not work on some platforms.
5868 Problem reported by Andreas Schwab in
5869 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5870 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5871 is set, removing the need for VIRT_ADDRESS_VARIES.
5872 (PURE_P): Use a more-efficient implementation that needs just one
5873 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5874 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5875 to 4 (xorl, subq, cmpq, setbe).
5876 * alloc.c (pure): Always extern now, since that's the
5877 VIRT_ADDR_VARIES behavior.
5878 (PURE_POINTER_P): Use a single comparison, not two, for
5879 consistency with the new puresize.h.
5880 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5881 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5882 Remove VIRT_ADDR_VARIES no longer needed.
5884 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5886 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5887 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5888 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5889 behave as if the cursor position were at the window margin.
5891 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5892 and the cursor position is out of bounds, behave as if the cursor
5893 position were at the window margin. (Bug#10075)
5895 2011-11-18 Chong Yidong <cyd@gnu.org>
5897 * window.c (Fwindow_combination_limit): Make first argument
5898 non-optional, since it is meaningless for live windows like the
5901 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5903 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5905 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5907 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5908 (graft_intervals_into_buffer): Simplify.
5910 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5912 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5913 hash values of the two rows.
5914 (copy_row_except_pointers): Preserve the used[] arrays and the
5915 hash values of the two rows. (Bug#10035)
5916 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5918 * xdisp.c (row_hash): New function, body extracted from
5919 compute_line_metrics.
5920 (compute_line_metrics): Call row_hash, instead of computing the
5923 * dispnew.c (verify_row_hash): Call row_hash for computing the
5924 hash code of a row, instead of duplicating code from xdisp.c.
5926 * dispextern.h (row_hash): Add prototype.
5928 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5930 * frame.c (delete_frame): Don't delete the terminal when the last
5931 X frame is closed if emacs is built with GTK toolkit.
5933 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5935 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5937 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5939 * window.c (Vwindow_splits): Rename to
5940 Vwindow_combination_resize. Suggested by Juri Linkov.
5941 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5944 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5946 * nsfns.m (Fns_font_name):
5947 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5949 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5951 * window.h (window): Rename slot "nest" to "combination_limit".
5952 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5953 (Fset_window_nest): Rename to Fset_window_combination_limit.
5954 (Vwindow_nest): Rename to Vwindow_combination_limit.
5955 (recombine_windows, make_parent_window, make_window)
5956 (Fsplit_window_internal, saved_window)
5957 (Fset_window_configuration, save_window_save): Rename all
5958 occurrences of window_nest to window_combination_limit.
5960 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5962 * image.c (imagemagick_load_image): Fix typo.
5964 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5966 * xdisp.c (display_line): Move the call to
5967 highlight_trailing_whitespace before the call to
5968 compute_line_metrics, since the latter needs to see the final
5969 faces of all the glyphs to compute ROW's hash value.
5970 Fixes assertion violations in row_equal_p. (Bug#10035)
5972 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5974 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5975 just return (bug#10044).
5977 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5979 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5980 with user-defined heap size. Bump the default size of the temacs
5981 heap to 27MB, to avoid memory warning when running temacs.
5982 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5984 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5985 current_matrix and desired_matrix. (Bug#9990)
5986 (verify_row_hash) [XASSERTS]: New function.
5987 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5988 that the hash value of glyph rows is correct.
5990 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5992 * window.h (window): Remove splits slot.
5993 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5994 (Fdelete_other_windows_internal, make_parent_window)
5995 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5996 (Fset_window_configuration, save_window_save): Don't deal with
5997 split status of windows.
5998 (saved_window): Remove splits slot.
5999 (Vwindow_splits): Rewrite doc-string.
6001 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6003 * xfns.c (unwind_create_frame):
6004 * nsfns.m (unwind_create_frame):
6005 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6006 Vframe_list (Bug#9999).
6008 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6010 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6012 2011-11-11 Kenichi Handa <handa@m17n.org>
6014 * callproc.c (Fcall_process): Set the member dst_multibyte of
6017 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6019 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6020 avoid a crash (bug#9496).
6022 2011-11-09 Chong Yidong <cyd@gnu.org>
6024 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6025 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6027 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6029 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6031 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6033 Avoid some portability problems by eschewing 'extern inline' functions.
6034 The trivial performance wins aren't worth the portability hassles; see
6035 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6037 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6038 (window_box_width, window_box_left, window_box_left_offset)
6039 (window_box_right, window_box_right_offset): Undo previous change,
6040 by removing the "extern"s.
6041 * intervals.c (adjust_intervals_for_insertion)
6042 (adjust_intervals_for_deletion): Undo previous change,
6043 making these static again.
6044 (offset_intervals, temp_set_point_both, temp_set_point)
6045 (copy_intervals_to_string): No longer inline.
6046 * xdisp.c (window_text_bottom_y, window_box_width)
6047 (window_box_height, window_box_left_offset)
6048 (window_box_right_offset, window_box_left, window_box_right)
6049 (window_box): No longer inline.
6051 2011-11-08 Chong Yidong <cyd@gnu.org>
6053 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6054 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6055 Signal an error if not a live window.
6056 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6057 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6059 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6061 * lisp.h (syms_of_abbrev): Remove declaration.
6062 Reported by CHENG Gao <chenggao@royau.me>.
6064 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6066 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6067 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6068 of temacs in GUI mode.
6070 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6072 * window.h: Declare delete_all_child_windows instead of
6073 delete_all_subwindows.
6074 * window.c (Fwindow_nest, Fset_window_nest)
6075 (Fset_window_new_total, Fset_window_new_normal)
6076 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6077 (delete_all_subwindows): Rename to delete_all_child_windows.
6078 (Fdelete_other_windows_internal, Fset_window_configuration):
6079 Call delete_all_child_windows instead of delete_all_subwindows.
6080 * frame.c (delete_frame): Call delete_all_child_windows instead
6081 of delete_all_subwindows.
6083 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6085 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6086 This is also needed for porting to any host where GC_MARK_STACK is
6087 not GC_MAKE_GCPROS_NOOPS.
6088 (which_symbols): Use it.
6090 2011-11-07 Kenichi Handa <handa@m17n.org>
6092 * coding.c (coding_set_destination): Check coding->src_pos only
6093 when coding->src_object is a buffer (bug#9910).
6095 * process.c (send_process): Set the member src_multibyte of coding
6096 to 0 (bug#9911) when sending a unibyte text.
6098 * callproc.c (Fcall_process): Set the member src_multibyte of
6099 process_coding to 0 (bug#9912).
6101 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6103 * xmenu.c (cleanup_widget_value_tree): New function.
6104 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6105 calling free_menubar_widget_value_tree directly (Bug#9830).
6107 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6109 Fix some portability problems with 'inline'.
6110 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6111 (window_box_width, window_box_left, window_box_left_offset)
6112 (window_box_right, window_box_right_offset): Declare extern.
6113 Otherwise, these inline functions do not conform to C99 and
6114 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6115 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6116 * intervals.c (adjust_intervals_for_insertion)
6117 (adjust_intervals_for_deletion): Now extern, because otherwise the
6118 extern inline functions 'offset_intervals' couldn't refer to it.
6119 (static_offset_intervals): Remove.
6120 (offset_intervals): Rewrite using the old contents of
6121 static_offset_intervals. The old version didn't conform to C99
6122 because an extern inline function contained a reference to an
6123 identifier with static linkage.
6125 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6127 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6130 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6132 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6133 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6134 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6135 return Qleft_to_right.
6137 2011-11-06 Chong Yidong <cyd@gnu.org>
6139 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6140 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6141 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6142 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6143 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6144 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6145 (Fwindow_vscroll): Doc fix.
6146 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6147 argument, since it makes no sense to pass a live window and for
6148 consistency with window-child.
6150 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6152 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6155 2011-11-05 Jason Rumney <jasonr@gnu.org>
6157 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6158 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6160 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6161 bitwise arithmetic preventing use of unicode-sip and non-truetype
6164 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6166 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6169 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6170 initialization code to keep similarity to xfns.c after changes
6173 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6175 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6176 (unwind_create_frame): New function (Bug#9943).
6177 (Fx_create_frame): Restructure code to be more similar to the one in
6178 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6179 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6180 Move terminal->reference_count++ just before making the frame official
6183 * nsterm.m (x_free_frame_resources): New function.
6184 (x_destroy_window): Move code to x_free_frame_resources.
6186 * xfns.c (unwind_create_frame): Fix comment.
6187 (Fx_create_frame, x_create_tip_frame):
6188 Move terminal->reference_count++ just before making the frame
6189 official. Move initialization of image_cache_refcount and
6190 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6192 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6194 Support MSVC build with newer versions of Visual Studio.
6195 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6196 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6199 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6200 which are not supported by MSVC.
6201 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6202 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6204 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6206 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6208 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6210 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6212 Support MSVC build with newer versions of Visual Studio.
6213 * w32.c: Don't include w32api.h for MSVC.
6214 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6216 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6217 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6218 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6219 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6221 (alloca) [_MSC_VER]: Define to _alloca.
6223 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6225 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6227 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6229 * xdisp.c (note_mouse_highlight): If either of
6230 previous/next-single-property-change returns nil, treat that as
6231 the beginning or the end of the buffer. (Bug#9955)
6233 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6235 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6236 label is not null (Bug#9951).
6237 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6240 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6242 * window.c (Fwindow_body_size): Mention in the doc string that the
6243 return value is in frame's canonical units. (Bug#9949)
6245 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6247 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6249 * w32fns.c (unwind_create_frame): If needed, free the glyph
6250 matrices of the partially constructed frame. (Bug#9943)
6251 * xfns.c (unwind_create_frame): Likewise.
6253 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6255 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6256 Don't stop backward scan on the continuation glyph, even though
6257 its CHARPOS is positive.
6258 (mouse_face_from_buffer_pos, note_mouse_highlight):
6259 Rename cover_string to disp_string.
6261 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6263 * window.c (temp_output_buffer_show): Don't use
6264 Vtemp_buffer_show_specifiers.
6265 (Vtemp_buffer_show_specifiers): Remove unused variable.
6267 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6269 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6270 past the beginning of the current glyph matrix.
6272 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6274 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6275 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6276 HAVE_GTK3 (Bug#9869).
6278 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6279 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6281 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6283 * xterm.c: Declare x_handle_net_wm_state to return int.
6284 (handle_one_xevent): Check if we are iconified but don't have
6285 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6286 (get_current_wm_state): Return non-zero if not hidden,
6287 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6288 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6289 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6290 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6292 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6294 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6295 so that this new function doesn't get optimized away by a
6296 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6298 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6300 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6302 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6304 Fix the `xbytecode' command.
6305 * .gdbinit (xprintbytestr): New command.
6306 (xwhichsymbols): Rename from `which'; all callers changed.
6307 (xbytecode): Print the byte-code string as well.
6309 2011-10-29 Kim Storm <storm@cua.dk>
6311 * alloc.c (which_symbols): New function.
6313 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6315 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6318 2011-10-29 Glenn Morris <rgm@gnu.org>
6320 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6321 Not clear what it was for, and it causes various bugs. (Bug#9839)
6323 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6325 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6326 possible random value that matches one of those tested as
6327 condition to clear the mouse face.
6329 2011-10-28 Chong Yidong <cyd@gnu.org>
6331 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6333 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6335 * window.c (make_window): Initialize phys_cursor_on_p.
6337 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6339 * lisp.h (struct Lisp_Symbol): Update comments.
6341 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6343 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6345 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6347 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6348 <oslsachem@gmail.com> for helping to debug this.
6350 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6351 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6352 (g_b_init_get_glyph_outline_w): New static variables.
6353 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6354 (GetGlyphOutlineW_Proc): New typedefs.
6355 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6356 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6358 (w32font_open_internal, compute_metrics):
6359 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6360 instead of calling the "wide" APIs directly.
6362 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6364 * w32.h (syms_of_w32font): Add prototype.
6366 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6368 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6369 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6370 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6371 (Fmove_to_window_line): Doc fix.
6373 2011-10-27 Chong Yidong <cyd@gnu.org>
6375 * process.c (make_process): Set gnutls_state to NULL.
6377 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6378 non-NULL, regardless of GNUTLS_INITSTAGE.
6379 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6380 an error. Set process slots as soon as we allocate them.
6382 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6384 2011-10-27 Chong Yidong <cyd@gnu.org>
6386 * gnutls.c (emacs_gnutls_deinit): New function.
6387 Deallocate credentials structures as well as calling gnutls_deinit.
6388 (Fgnutls_deinit, Fgnutls_boot): Use it.
6390 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6391 (deactivate_process): Call emacs_gnutls_deinit.
6393 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6395 * image.c (x_create_x_image_and_pixmap):
6396 * w32.c (sys_rename, w32_delayed_load):
6397 * w32font.c (fill_in_logfont):
6398 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6400 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6402 * w32fns.c (w32_default_color_map): New function,
6403 extracted from Fw32_default_color_map.
6404 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6406 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6408 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6410 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6412 * keyboard.c (test_undefined): New function (bug#9751).
6413 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6415 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6417 * sysdep.c (init_sys_modes): Fix the check for the controlling
6418 terminal (Bug#6649).
6420 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6422 * dispextern.h (struct bidi_it): New member next_en_type.
6424 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6425 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6426 current character, check also for next_en_type being WEAK_EN.
6427 (bidi_resolve_weak): Don't enter the expensive loop if the current
6428 position is before next_en_pos. Record the bidi type of the first
6429 non-ET, non-BN character we find, in addition to its position.
6430 (bidi_level_of_next_char): Invalidate next_en_type when
6431 next_en_pos is over-stepped.
6433 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6435 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6436 * editfns.c: Rewrite current-time-zone so that it invokes
6437 the equivalent of (format-time-string "%Z") to get the time zone name.
6438 This fixes a bug when the time zone name contains characters that
6439 need converting from the system time locale to Emacs internal format.
6440 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6441 that patch fixed format-time-string to do the conversion, but
6442 I forgot to fix current-time-zone.
6443 (format_time_string): New function, containing most of
6444 what Fformat_time_string used to contain.
6445 (Fformat_time_string): Rewrite in terms of format_time_string.
6446 This doesn't change this function's behavior.
6447 (current-time-zone): Rewrite to use format_time_string.
6448 This fixes the bug reported by Michael Schierl in
6449 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6450 Jason Rumney's 2007-06-07 change worked around this bug, but
6452 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6454 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6456 * xdisp.c (start_display): If the character at POS is displayed
6457 via a display vector, reset IT->current.dpvec_index to zero.
6458 (try_window_reusing_current_matrix): If a line ends in a display
6459 vector or the next line starts in a display vector, continue
6460 redrawing the window even though the character position of
6461 start_row was reached.
6464 2011-10-18 Chong Yidong <cyd@gnu.org>
6466 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6467 with nobreak-char-display too.
6469 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6471 Fix part 3 of bug#9771.
6472 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6473 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6474 non-neutral characters if the current character is a paragraph
6475 separator (a.k.a. Newline). This avoids running the same
6476 expensive loop twice, once when we consume the preceding newline
6477 and the other time when the line actually needs to be displayed.
6478 Avoid the loop when we see neutrals on the base embedding level
6479 following a character whose directionality is the same as the
6480 paragraph's. This avoids running the expensive loop when a line
6481 ends in a long sequence of neutrals, like control characters.
6482 Add assertion against STRONG_AL type. Slightly rearrange code
6483 that determines the type of a neutral given the first non-neutral
6485 (bidi_level_of_next_char): Set next_en_pos to zero when
6486 invalidating its info.
6488 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6490 * xdisp.c (push_display_prop): Determine whether to record string
6491 or buffer position by IT->string, not by IT->method. Allow
6492 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6493 (move_it_vertically_backward): Don't look for character position
6494 immediately after the newline when in a continuation line.
6497 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6499 * window.c (coordinates_in_window): Rewrite and delabelize
6500 vertical border check. (Bug#5357) (Bug#9618)
6502 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6504 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6505 errors in XSetWindowBorder (bug#9310).
6507 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6509 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6510 avoid crash when xmalloc overrun checking is enabled.
6512 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6514 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6515 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6516 cursor motion with <left> and <right> arrow keys.
6518 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6519 some callers set that themselves.
6521 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6523 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6524 display string and the previous row comes from the same string and
6525 is empty. (Bug#9739) (Bug#9738)
6527 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6529 * doc.c (get_doc_string): Encode file name (bug#9735).
6531 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6533 * bidi.c (bidi_level_of_next_char):
6534 * xdisp.c (get_visually_first_element): Remove old incorrect
6535 comments regarding the Unicode Line Separator character.
6537 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6539 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6541 * alloc.c (Fgc_status): Do not access beyond zombies array
6542 boundary if nzombies > MAX_ZOMBIES.
6543 * alloc.c (dump_zombies): Add missing format specifier.
6545 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6547 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6548 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6550 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6551 Some packages use them to denote characters with modifiers.
6553 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6555 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6556 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6557 matching a pp-number. Rename parameter var to var1.
6559 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6561 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6563 2011-10-08 Glenn Morris <rgm@gnu.org>
6565 * callint.c (Fcall_interactively): Give a more explicit error for the
6566 'c' case with a non-character input. (Bug#8479)
6568 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6570 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6572 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6573 lines that are hscrolled on the left.
6575 * dispnew.c (buffer_posn_from_coords): Account for a possible
6576 presence of header-line. (Bug#4426)
6578 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6580 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6581 Don't advertise functionality which we discourage or doesn't work.
6583 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6585 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6586 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6587 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6588 this makes Emacs dump core during garbage collection on rare
6589 occasions. sizeof is obviously inferior to offsetof here, so
6590 stick with offsetof.
6591 (GC_POINTER_ALIGNMENT): New macro.
6592 (mark_memory): Omit 3rd (offset) arg; caller changed.
6593 Don't assume EMACS_INT alignment is the same as pointer alignment.
6595 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6597 * keyboard.c (read_key_sequence_remapped): New var.
6598 (read_key_sequence): Compute remapping in the right buffer.
6599 (command_loop_1): Use read_key_sequence's remapping directly.
6601 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6603 * dired.c (file_name_completion): Don't expand file name.
6604 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6605 before checking file name handler.
6607 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6608 they've been requested explicitly (bug#9591).
6610 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6612 * keymap.c (Fsingle_key_description): Use make_specified_string
6613 instead of build_string to build string from push_key_description.
6616 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6618 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6619 This fixes a Y2038 bug on 64-bit hosts.
6620 * buffer.c (reset_buffer):
6621 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6622 (Fclear_buffer_auto_save_failure):
6623 Use 0, not -1, to represent an unset failure time, since time_t
6624 might not be signed.
6626 Remove dependency on glibc malloc internals.
6627 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6628 Move back here from lisp.h, but with their new implementations.
6629 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6630 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6631 * charset.c (charset_table_init): New static var.
6632 (syms_of_charset): Use it instead of xmalloc. This removes a
6633 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6634 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6635 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6636 Move back to alloc.c.
6637 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6638 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6640 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6642 * nsterm.m (windowDidResize): Call x_set_window_size only when
6643 ns_in_resize is true. Otherwise set pixelwidth/height and
6644 call change_frame_size (Bug#9628).
6646 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6648 Port --enable-checking=all to Fedora 14 x86-64.
6649 * charset.c (syms_of_charset): Also account for glibc malloc's
6650 internal overhead when calculating the initial malloc maximum.
6652 Port --enable-checking=all to Fedora 14 x86.
6653 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6655 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6656 (overrun_check_realloc, overrun_check_free):
6657 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6658 That way, xmalloc returns a properly-aligned pointer even if
6659 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6660 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6661 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6662 into account when calculating the initial malloc maximum.
6663 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6664 Move here from alloc.c, so that charset.c can use it too.
6665 Properly align; the old code wasn't right for common 32-bit hosts
6666 when configured with --enable-checking=all.
6667 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6668 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6670 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6672 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6675 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6677 * xdisp.c (compute_display_string_end): If there's no display
6678 string at CHARPOS, return -1.
6680 * bidi.c (bidi_fetch_char): When compute_display_string_end
6681 returns a negative value, treat the character as a normal
6682 character not covered by a display string. (Bug#9624)
6684 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6686 * lread.c (Fread_from_string): Fix typo in docstring.
6688 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6690 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6691 newline, reseat the iterator instead of bidi-iterating there one
6692 character at a time. (Bug#9610)
6693 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6694 TO_CHARPOS if the bidi iterator is at base embedding level.
6696 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6698 * lread.c (readevalloop): Use correct code for NBSP.
6699 (read1): Likewise. (Bug#9608)
6701 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6703 * dbusbind.c (Fdbus_register_signal): When service is not
6704 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6706 2011-09-25 Glenn Morris <rgm@gnu.org>
6708 * buffer.c (truncate-lines): Doc fix.
6710 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6712 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6713 (Fset_window_next_buffers): Doc fix.
6715 2011-09-24 Glenn Morris <rgm@gnu.org>
6717 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6719 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6721 Fix minor problems found by static checking.
6722 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6723 * indent.c (Fvertical_motion): Fix == vs = typo.
6725 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6727 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6728 Default value is now t. Doc fix.
6730 * indent.c (Fvertical_motion): Compute and apply the overshoot
6731 logic when moving up, not only when moving down. Fix the
6732 confusing name and values of the it_overshoot_expected variable;
6733 logic changes accordingly. (Bug#9254) (Bug#9549)
6735 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6736 CHARPOS is covered by a display string which includes newlines.
6737 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6738 is covered by a display string with embedded newlines.
6740 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6742 * dbusbind.c (Fdbus_register_signal): Add match rule to
6743 Vdbus_registered_objects_table. (Bug#9581)
6744 (Fdbus_register_method, Vdbus_registered_objects_table):
6747 2011-09-24 Jim Meyering <meyering@redhat.com>
6749 do not ignore write error for any output size
6750 The previous change was incomplete.
6751 While it makes emacs --batch detect the vast majority of stdout
6752 write failures, errors were still ignored whenever the output size is
6753 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6754 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6755 && echo FAIL: ignored write error
6756 FAIL: ignored write error
6757 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6758 && echo FAIL: ignored write error
6759 FAIL: ignored write error
6760 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6762 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6764 * emacs.c (Fkill_emacs): In noninteractive mode exit
6765 non-successfully if a write error occurred on stdout. (Bug#9574)
6767 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6769 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6772 * dispextern.h (struct it): Update the comment documenting what
6775 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6777 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6778 a display string, extend search for cursor position to end of row.
6779 (find_row_edges): If the row ends in a newline from a display
6780 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6781 Handle the case of a display string with multiple newlines.
6782 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6783 non-empty line. Fixes confusing cursor motion with arrow keys at
6784 the beginning of a line that starts with whitespace.
6786 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6788 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6791 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6793 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6796 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6798 * xdisp.c (display_line): Record maximum and minimum buffer
6799 positions even if no glyphs were produced (e.g., by a zero-width
6800 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6801 buffer positions that will be removed from the glyph row because
6803 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6804 column is beyond frame width: don't subtract 1 "pixel" when
6805 computing width of the stretch.
6806 (reseat_at_next_visible_line_start): Undo the change made on
6807 2011-09-17 that saved paragraph information and restored it after
6808 the call to `reseat'. (Bug#9545)
6810 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6812 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6813 and turn window cursor on if cleared (Bug#9415).
6815 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6817 * search.c (boyer_moore): Take unibyte characters from pattern
6818 literally. (Bug#9458)
6820 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6822 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6824 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6826 Fix minor problem found by static checking.
6827 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6828 initialized, to pacify gcc -Wuninitialized.
6830 * fileio.c: Report proper errno when syscall falls.
6831 (Finsert_file_contents): Save and restore errno,
6832 so that report_file_error outputs the correct diagnostic.
6833 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6835 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6837 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6839 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6841 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6842 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6844 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6846 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6847 about the current paragraph and restore it after the call to reseat.
6849 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6850 (bidi_find_paragraph_start): Search back for paragraph beginning
6851 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6852 (bidi_move_to_visually_next): Only trigger paragraph-related
6853 computations when the last character is a newline or at EOB, not
6854 just any NEUTRAL_B. (Bug#9470)
6856 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6857 truncated lines if point is covered by a display string. (Bug#9524)
6859 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6861 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6862 (cons_to_x_long): New function.
6863 (lisp_data_to_selection_data): Use it. Correct the test for
6864 short-versus-long data; it was negated. Break out of vector
6865 loop, for efficiency, when a long datum is discovered.
6867 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6869 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6871 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6873 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6874 GCC PR/17406) by declaring this function with external scope.
6876 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6878 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6879 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6881 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6883 * editfns.c (Fformat): Correctly handle text properties on "%%".
6885 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6887 * xterm.c (x_draw_composite_glyph_string_foreground):
6888 * w32term.c (x_draw_composite_glyph_string_foreground):
6889 * term.c (encode_terminal_code):
6890 * composite.c (composition_update_it, get_composition_id):
6891 * xdisp.c (get_next_display_element)
6892 (fill_composite_glyph_string): Add comments about special meaning
6893 of TAB characters in a composition.
6895 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6897 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6898 This occurs when processing a multibyte format.
6899 Problem reported by Wolfgang Jenker.
6901 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6903 * xdisp.c (try_cursor_movement): Only check for exact match if
6904 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6906 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6908 Remove unused external symbols.
6909 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6910 * xdisp.c (calc_pixel_width_or_height): Now static.
6911 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6912 * indent.c (check_display_width):
6913 * w32term.c: Fix comment to match code.
6914 * xterm.c, xterm.h (x_catching_errors): Remove.
6916 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6918 * xselect.c: Use signed conversions more consistently (Bug#9498).
6919 (selection_data_to_lisp_data): Assume incoming selection data are
6920 signed integers, not unsigned. This is to be consistent with
6921 outgoing selection data, which was modified to use signed integers
6922 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6923 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6924 expects long, not unsigned long.
6926 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6928 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6929 computation of loop end. Reported by Johan Bockgård
6932 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6934 * frame.c (Fother_visible_frames_p): Function deleted.
6936 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6938 * indent.c (compute_motion): Process display vector front to back
6939 rather than the other way around. (Bug#2496)
6941 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6943 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6945 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6947 * minibuf.c (Fread_from_minibuffer): Doc fix.
6949 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6951 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6952 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6954 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6956 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6957 value for non-existent files.
6959 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6961 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6962 set its "size" to -1. This will set the modtime_size field of
6963 the corresponding buffer to -1, which is what
6964 verify-visited-file-modtime expects for files that do not exist.
6967 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6969 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6971 * lisp.h: ... from here. push_key_description is no longer
6972 defined in keyboard.c, so its declaration should not be in
6973 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6974 logically belongs with push_key_description.
6976 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6978 * buffer.h: Include <sys/types.h> instead of <time.h>.
6979 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6980 Problem reported by Herbert J. Skuhra.
6982 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6984 * xml.c (parse_region): Make the parsing work for
6985 non-comment-starting XML files again (bug#9144).
6987 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6989 * image.c (gif_load): Fix calculation of bottom and right corner.
6992 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6994 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6995 redisplay in small windows.
6997 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6999 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7001 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7003 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7004 Operate on live windows only.
7006 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7008 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7010 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7012 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7013 only under bidi iteration.
7015 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7017 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7019 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7021 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7022 Without this fix, the command to link temacs failed due to an
7023 undefined symbol __builtin_isnan. This is because
7024 /usr/include/iso/math_c99.h #defines isnan(x) to
7025 __builtin_isnan(x), but the bundled gcc, which identifies itself
7026 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7028 * floatfns.c (isnan): #undef, and then #define to a clone of
7030 (Fisnan): Always define, since it's always available now.
7031 (syms_of_floatfns): Always define isnan at the Lisp level.
7033 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7035 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7037 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7039 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7040 The previous code assumed that file offsets (off_t values) fit in
7041 EMACS_INT variables, which is not true on typical 32-bit hosts.
7042 The code messed up by falsely reporting buffer overflow in cases
7043 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7044 when "big" contains more than 2**29 bytes, even though this
7045 inserts just one byte and does not overflow the buffer.
7046 (Finsert_file_contents): Store file offsets as off_t
7047 values, not as EMACS_INT values. Check for overflow when
7048 converting between EMACS_INT and off_t. When checking for
7049 buffer overflow or for overlap, take the offsets into account.
7050 Don't use EMACS_INT for small values where int suffices.
7051 When checking for overlap, fix a typo: ZV was used where
7052 ZV_BYTE was intended.
7053 (Fwrite_region): Don't assume off_t fits into 'long'.
7054 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7056 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7058 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7060 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7062 sprintf-related integer and memory overflow issues (Bug#9412).
7064 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7065 (esprintf, exprintf, evxprintf): New functions.
7066 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7067 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7068 (modify_event_symbol): Do not assume that the length of
7069 name_alist_or_stem is safe to alloca and fits in int.
7070 (Fexecute_extended_command): Likewise for function name and binding.
7071 (Frecursion_depth): Wrap around reliably on integer overflow.
7072 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7073 since some callers pass EMACS_INT values.
7074 (Fsingle_key_description): Don't crash if symbol name contains more
7075 than MAX_ALLOCA bytes.
7076 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7077 (get_minibuffer): Arg is now EMACS_INT, not int.
7078 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7079 (esprintf, exprintf, evxprintf): New decls.
7080 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7082 * dbusbind.c (signature_cat): New function.
7083 (xd_signature, Fdbus_register_signal):
7084 Do not overrun buffer; instead, report string overflow.
7086 * dispnew.c (add_window_display_history): Don't overrun buffer.
7087 Truncate instead; this is OK since it's just a log.
7089 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7090 even if the time zone offset is outlandishly large.
7091 Don't mishandle offset == INT_MIN.
7093 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7094 when creating daemon; the previous buffer-overflow check was incorrect.
7096 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7097 which has the guts of the old verror function.
7099 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7100 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7102 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7103 (font_unparse_xlfd): Don't blindly alloca long strings.
7104 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7105 fits in int, when using sprintf. Use single snprintf to count
7106 length of string rather than counting it via multiple sprintfs;
7107 that's simpler and more reliable.
7108 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7109 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7110 sprintf, in case result does not fit in int.
7112 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7113 (fontset_from_font): Print it.
7115 * frame.c (tty_frame_count): Now printmax_t, not int.
7116 (make_terminal_frame, set_term_frame_name): Print it.
7117 (x_report_frame_params): In X, window IDs are unsigned long,
7118 not signed long, so print them as unsigned.
7119 (validate_x_resource_name): Check for implausibly long names,
7120 and don't assume name length fits in 'int'.
7121 (x_get_resource_string): Don't blindly alloca invocation name;
7122 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7125 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7126 (xg_check_special_colors, xg_set_geometry):
7127 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7129 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7130 Use esprintf, not sprintf, in case result does not fit in int.
7132 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7133 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7134 it as a large positive number.
7135 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7136 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7138 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7139 in case result does not fit in int.
7141 * print.c (float_to_string): Detect width overflow more reliably.
7142 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7143 buffer overrun. Don't assume list length fits in 'int'. Treat
7144 print length of 0 as 0, not as infinity; to be consistent with other
7145 uses of print length in this function. Don't overflow print length
7146 index. Don't assume hash table size fits in 'long', or that
7147 vectorlike size fits in 'unsigned long'.
7149 * process.c (make_process): Use printmax_t, not int, to format
7150 process-name gensyms.
7152 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7154 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7155 to avoid potential buffer overrun.
7157 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7158 if X resource line is longer than 512 bytes.
7160 * xfns.c (x_window): Make sprintf buffer a bit bigger
7161 to avoid potential buffer overrun.
7163 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7165 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7167 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7169 Integer overflow fixes for scrolling, etc.
7170 Without these, Emacs silently mishandles large integers sometimes.
7171 For example, "C-u 4294967297 M-x recenter" was treated as if
7172 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7174 * xdisp.c (try_window_id): Check Emacs fixnum range before
7175 converting to 'int'.
7177 * window.c (window_scroll_line_based, Frecenter):
7178 Check that an Emacs fixnum is in range before assigning it to 'int'.
7179 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7180 values converted from Emacs fixnums.
7181 (Frecenter): Don't wrap around a line count if it is out of 'int'
7182 range; instead, treat it as an extreme value.
7183 (Fset_window_configuration, compare_window_configurations):
7184 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7186 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7187 that can exceed INT_MAX. Check that EMACS_INT value is in range
7188 before assigning it to the (possibly-narrower) index.
7189 (match_limit): Don't assume that a fixnum can fit in 'int'.
7191 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7194 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7195 (Fvertical_motion): Don't wrap around LINES values that don't fit
7196 in 'int'. Instead, treat them as extreme values. This is good
7197 enough for windows, which can't have more than INT_MAX lines anyway.
7199 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7201 * Require libxml/parser.h to avoid compilation warning.
7203 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7205 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7206 since this reportedly can destroy thread storage.
7208 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7210 * syntax.c (find_defun_start): Update all cache variables if
7211 exiting early (Bug#9401).
7213 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7215 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7217 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7218 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7219 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7221 * term.c (tty_append_glyph): New function.
7222 (produce_stretch_glyph): Static function and its prototype deleted.
7224 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7227 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7229 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7230 when checking :margin (Bug#9390).
7231 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7232 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7233 so that the name doesn't mislead. All uses changed.
7235 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7237 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7240 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7242 * xdisp.c (move_it_to): Don't bail out early when reaching
7243 position beyond to_charpos, if we are scanning backwards.
7244 (move_it_vertically_backward): When DY == 0, make sure we get to
7245 the first character in the line after the newline.
7247 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7249 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7250 (ccl_driver): Do not generate an out-of-range pointer.
7251 (Fccl_execute_on_string): Remove unnecessary check for
7252 integer overflow, noted by Stefan Monnier in
7253 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7254 Remove a FIXME that didn't need fixing.
7255 Simplify the newly-introduced buffer reallocation code.
7257 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7259 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7261 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7263 Integer and memory overflow issues (Bug#9196).
7265 * doc.c (get_doc_string): Rework so that
7266 get_doc_string_buffer_size is the actual buffer size, rather than
7267 being 1 less than the actual buffer size; this makes xpalloc more
7270 * image.c (x_allocate_bitmap_record, cache_image):
7271 * xselect.c (Fx_register_dnd_atom):
7272 Simplify previous changes by using xpalloc.
7274 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7275 since either will do and ptrdiff_t is convenient with xpalloc.
7277 * charset.c (charset_table_size)
7278 (struct charset_sort_data.priority): Now ptrdiff_t.
7279 (charset_compare): Don't overflow if priorities differ greatly.
7280 (Fsort_charsets): Don't assume list length fits in int.
7281 Check for size-calculation overflow when allocating sort data.
7282 (syms_of_charset): Allocate an initial charset table that is
7283 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7285 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7287 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7288 The actual value is always <= INT_MAX, and leaving it unsigned made
7289 overflow checking harder.
7291 * dispextern.h (struct glyph_matrix.rows_allocated)
7292 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7293 with xpalloc. The values are still always <= INT_MAX.
7295 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7297 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7298 (SAFE_NALLOCA): New macro.
7300 * region-cache.c (struct boundary.pos, find_cache_boundary)
7301 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7302 (set_cache_region, invalidate_region_cache)
7303 (revalidate_region_cache, know_region_cache, region_cache_forward)
7304 (region_cache_backward, pp_cache):
7305 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7306 so that ptrdiff_t * can be passed to xpalloc.
7307 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7308 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7309 (pp_cache): Don't assume cache_len fits in int.
7310 * region-cache.h: Adjust extern decls to match.
7312 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7313 EMACS_INT, since either will do, for xpalloc.
7315 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7316 (xnmalloc, xnrealloc, xpalloc): New functions.
7318 * bidi.c (bidi_shelve_header_size): New constant.
7319 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7320 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7322 * bidi.c (bidi_cache_shrink):
7323 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7325 Don't update size of array until after memory allocation succeeds,
7326 because xmalloc/xrealloc may not return.
7327 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7328 now that we have proper integer overflow checking.
7329 (record_overlay_string, overlay_strings): Catch overflows when
7330 calculating size of overlay_str_buf.
7332 * callproc.c (Fcall_process): Check for size overflow when
7333 calculating size of args2.
7334 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7335 Normally we prefer signed values, but sticking with ptrdiff_t would
7336 require adding more-complicated checks.
7338 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7339 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7340 Redo buffer-overflow calculations to avoid integer overflow.
7341 Add a FIXME comment where memory seems to be over-allocated.
7343 * character.c (Fstring): Check for size-calculation overflow.
7345 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7346 unnecessary integer overflow. Check for size overflow.
7347 (encode_coding_object): Don't update size until xmalloc succeeds.
7349 * composite.c (get_composition_id): Check for overflow in glyph
7350 length calculations.
7352 Integer and memory overflow fixes for display code.
7353 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7354 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7355 (scrolling_window): Check for overflow in size calculations.
7356 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7357 Don't assume glyph table len fits in int.
7358 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7359 (row_table_size): Now ptrdiff_t, not int.
7360 (scrolling_window): Avoid overflow in size calculations.
7361 Don't update size until allocation succeeds.
7362 * fns.c (concat): Check for overflow in size calculations.
7363 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7364 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7365 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7367 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7368 (get_doc_string): Check for size calculation overflow.
7369 Don't update size until allocation succeeds.
7370 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7371 EMACS_INT, where ptrdiff_t will do.
7372 (Fsubstitute_command_keys): Check for string overflow.
7374 * editfns.c (set_time_zone_rule): Don't assume environment length
7376 (message_length): Now ptrdiff_t, not int.
7377 (Fmessage_box): Don't update size until allocation succeeds.
7378 Don't assume message length fits in int.
7379 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7381 * emacs.c (main): Do not reallocate argv, since there is a null at
7382 the end that can be overwritten, and this way there's no need to
7383 worry about size-calculation overflow.
7384 (sort_args): Check for size-calculation overflow.
7386 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7388 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7390 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7391 (x_set_scroll_bar_width, x_figure_window_size):
7392 Check for integer overflow.
7393 (x_set_alpha): Do not assume XINT fits in int.
7395 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7396 This is for the members text_lines, text_cols, total_lines, total_cols,
7397 where the system imposes an 'int' limit.
7399 * fringe.c (Fdefine_fringe_bitmap):
7400 Don't update size until alloc works.
7402 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7403 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7405 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7406 Check for size-calculation overflow.
7407 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7408 do, as we prefer signed integers.
7409 (id_to_widget.max_size, id_to_widget.used)
7410 (xg_store_widget_in_map, xg_remove_widget_from_map)
7411 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7412 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7413 Use and return ptrdiff_t, not int.
7414 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7415 * gtkutil.h: Change prototypes to match the above.
7417 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7418 are duplicate now that they've been promoted to lisp.h.
7419 (x_allocate_bitmap_record, x_alloc_image_color)
7420 (make_image_cache, cache_image, xpm_load):
7421 Don't update size until alloc is done.
7422 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7424 Check for size calculation overflow.
7425 (ct_colors_allocated_max): New constant.
7426 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7429 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7430 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7431 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7432 Use ptrdiff_t, not int, to count maps.
7433 (read_char_minibuf_menu_prompt): Check for overflow in size
7434 calculations. Don't update size until allocation succeeds.
7435 Redo calculations to avoid overflow.
7436 * keyboard.h: Change prototypes to match the above.
7438 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7440 (current_minor_maps): Check for size calculation overflow.
7441 * keymap.h: Change prototypes to match the above.
7443 * lread.c (read1, init_obarray): Don't update size until alloc done.
7445 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7446 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7448 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7449 Now ptrdiff_t, not int.
7450 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7451 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7453 * process.c (Fnetwork_interface_list): Check for overflow
7454 in size calculation.
7456 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7458 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7459 overflow. Don't bother calling xmalloc when xrealloc will do.
7461 * search.c (Freplace_match): Check for size calculation overflow.
7462 (Fset_match_data): Don't assume list lengths fit in 'int'.
7464 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7465 for command line length. Do not attempt to address one before the
7466 beginning of an array, as that's not portable.
7468 * term.c (max_frame_lines): Remove; unused.
7469 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7471 (encode_terminal_code, calculate_costs): Check for size
7472 calculation overflow.
7473 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7474 table lengths and related sizes. Don't update size until alloc
7475 done. Redo calculations to avoid overflow.
7476 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7478 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7479 subtracting pointers.
7480 (gobble_line): Check for overflow more carefully. Don't update size
7483 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7484 Don't update size until alloc done.
7485 Redo size calculations to avoid overflow.
7486 Check for size calculation overflow.
7487 (main) [DEBUG]: Fix typo in invoking tparam1.
7489 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7490 Use ptrdiff_t, not int, for sizes.
7491 (store_mode_line_noprop_char): Don't update size until alloc done.
7493 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7494 Use ptrdiff_t, not int, for sizes.
7495 (Finternal_make_lisp_face, cache_face):
7496 Check for size calculation overflow.
7497 (cache_face): Treat size calculation overflows as if they were
7498 memory exhaustion (the usual treatment), rather than aborting.
7500 * xfns.c (x_encode_text, x_set_name_internal)
7501 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7502 sizes, since they can exceed INT_MAX in size. Check for size
7503 calculation overflow.
7505 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7506 (xg_select): Check for size calculation overflow.
7507 Don't update size until alloc done.
7509 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7510 as sprintf is limited to int lengths.
7512 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7513 (X_LONG_MIN): New macros.
7514 Use them to make the following changes clearer.
7515 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7516 This change doesn't affect the value now, but it may help remind
7517 future maintainers not to raise the value too much later.
7518 (SELECTION_QUANTUM): Remove, replacing with ...
7519 (selection_quantum): ... new function, which avoids overflow.
7521 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7522 assumption that selection length fits in 'int'.
7523 (x_reply_selection_request, x_handle_selection_request)
7524 (x_get_window_property, receive_incremental_selection)
7525 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7526 (lisp_data_to_selection_data, clean_local_selection_data):
7527 Use ptrdiff_t, not int, to record length of selection.
7528 (x_reply_selection_request, x_get_window_property)
7529 (receive_incremental_selection, x_property_data_to_lisp):
7530 Redo calculations to avoid overflow.
7531 (x_reply_selection_request): When sending hint, ceiling it at
7532 X_LONG_MAX rather than relying on wraparound overflow to send
7534 (x_get_window_property, receive_incremental_selection)
7535 (lisp_data_to_selection_data, x_property_data_to_lisp):
7536 Check for size-calculation overflow.
7537 (x_get_window_property, receive_incremental_selection)
7538 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7539 Don't store size until memory allocation succeeds.
7540 (x_get_window_property): Plug memory leak on memory exhaustion.
7541 Don't double-block input; malloc is safe here. Don't assume 2**34
7542 - 4 fits in unsigned long. Add an xassert to check
7543 XGetWindowProperty overflow. Be more careful about overflow
7544 calculations, and distinguish size from memory overflow better.
7545 (receive_incremental_selection): When tracing, don't assume
7546 unsigned int is less than INT_MAX.
7547 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7548 harmful) conversions of unsigned short to int.
7549 (lisp_data_to_selection_data): Don't assume that integers
7550 in the range -65535 through -1 fit in an X unsigned short.
7551 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7552 result parameters unless successful. Rely on cons_to_unsigned
7553 to report problems with elements; the old code wasn't right anyway.
7554 (x_check_property_data): Check for int overflow; we cannot use
7555 a wider type due to X limits.
7556 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7558 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7560 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7561 (x_term_init): Check for size calculation overflow.
7562 (x_color_cells): Don't store size until memory allocation succeeds.
7563 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7564 Don't assume alloca size is less than MAX_ALLOCA.
7565 (x_term_init): Don't assume length fits in int (sprintf is limited
7568 Use ptrdiff_t for composition IDs.
7569 * character.c (lisp_string_width):
7570 * composite.c (composition_table_size, n_compositions)
7571 (get_composition_id, composition_gstring_from_id):
7572 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7573 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7574 * window.c (Frecenter):
7575 Use ptrdiff_t, not int, for composition IDs.
7576 * composite.c (get_composition_id): Check for integer overflow.
7577 * composite.h: Adjust prototypes to match the above changes.
7579 Use ptrdiff_t for hash table indexes.
7580 * category.c (hash_get_category_set):
7581 * ccl.c (ccl_driver):
7582 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7583 * coding.c (coding_system_charset_list, detect_coding_system):
7584 * coding.h (struct coding_system.id):
7585 * composite.c (get_composition_id, gstring_lookup_cache):
7586 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7587 * image.c (xpm_get_color_table_h):
7588 * lisp.h (hash_lookup, hash_put):
7589 * minibuf.c (Ftest_completion):
7590 Use ptrdiff_t for hash table indexes, not int (which is too
7591 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7592 32-bit --with-wide-int hosts).
7594 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7595 Add a FIXME comment about memory leaks.
7596 (syms_of_charset): Don't assume xmalloc returns.
7598 Don't assume that stated character widths fit in int.
7599 * character.c (Fchar_width, c_string_width, lisp_string_width):
7600 * character.h (CHAR_WIDTH):
7601 * indent.c (MULTIBYTE_BYTES_WIDTH):
7602 Use sanitize_char_width to avoid undefined and/or bad behavior
7603 with outlandish widths.
7604 * character.h (sanitize_tab_width): Rename from sanitize_width,
7605 now that we have two such functions. All uses changed.
7606 (sanitize_char_width): New inline function.
7608 Don't assume that tab-width fits in int.
7609 * character.h (sanitize_width): New inline function.
7610 (SANE_TAB_WIDTH): New macro.
7611 (ASCII_CHAR_WIDTH): Use it.
7612 * indent.c (sane_tab_width): Remove. All uses replaced by
7613 SANE_TAB_WIDTH (current_buffer).
7614 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7616 * fileio.c: Integer overflow issues with file modes.
7617 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7619 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7620 Remove unreachable code.
7621 (read_hex, load_charset_map_from_file): Check for integer overflow.
7623 * xterm.c: Don't go over XClientMessageEvent limit.
7624 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7625 (x_send_scroll_bar_event): Likewise. Check that the size does not
7626 exceed limits imposed by XClientMessageEvent, as well as the usual
7627 ptrdiff_t and size_t limits.
7629 * keyboard.c: Overflow, signedness and related fixes.
7630 (make_lispy_movement): Use same integer type in forward decl
7631 that is used in the definition.
7632 (read_key_sequence, keyremap_step):
7633 Change bufsize argument back to int, undoing my 2011-03-30 change.
7634 We prefer signed types, and int is wide enough here.
7635 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7636 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7637 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7638 length, not size_t. Use ptrdiff_t for index, not int.
7639 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7640 possibility of integer overflow.
7642 Overflow, signedness and related fixes for images.
7644 * dispextern.h (struct it.stack[0].u.image.image_id)
7645 (struct_it.image_id, struct image.id, struct image_cache.size)
7646 (struct image_cache.used, struct image_cache.ref_count):
7647 * gtkutil.c (update_frame_tool_bar):
7648 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7649 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7650 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7651 * nsmenu.m (update_frame_tool_bar):
7652 * xdisp.c (calc_pixel_width_or_height):
7653 * xfns.c (image_cache_refcount):
7654 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7655 on typical 64-bit hosts.
7657 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7658 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7659 Omit unnecessary casts to int.
7660 (parse_image_spec): Check that integers fall into 'int' range
7661 when the callers expect that.
7662 (image_ascent): Redo ascent calculation to avoid int overflow.
7663 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7664 (lookup_image): Remove unnecessary tests.
7665 (xbm_image_p): Locals are now of int, not EMACS_INT,
7666 since parse_image_check makes sure they fit into int.
7667 (png_load, gif_load, svg_load_image):
7668 Prefer int to unsigned where either will do.
7669 (tiff_handler): New function, combining the cores of the
7670 old tiff_error_handler and tiff_warning_handler.
7671 This function is rewritten to use vsnprintf and thereby avoid
7672 stack buffer overflows. It uses only the features of vsnprintf
7673 that are common to both POSIX and native Microsoft.
7674 (tiff_error_handler, tiff_warning_handler): Use it.
7675 (tiff_load, gif_load, imagemagick_load_image):
7676 Don't assume :index value fits in 'int'.
7677 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7678 (imagemagick_load_image): Check that crop parameters fit into
7679 the integer types that MagickCropImage accepts. Don't assume
7680 Vimagemagick_render_type has a nonnegative value. Don't assume
7681 size_t fits in 'long'.
7682 (gs_load): Use printmax_t to print the widest integers possible.
7683 Check for integer overflow when computing image height and width.
7685 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7687 * xdisp.c (redisplay_window): Don't force window start if point
7688 will be invisible in the resulting window. (Bug#9324)
7690 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7692 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7693 the display spec is of the form `(space ...)'.
7694 (handle_display_spec): Return the value returned by
7695 handle_single_display_spec, not just 1 or zero.
7696 (handle_single_display_spec): If the display spec is of the form
7697 `(space ...)', and specifies display in the text area, return 2
7699 (try_cursor_movement): Check for the need to scroll more
7700 accurately, and prefer exact match for point under bidi.
7701 Don't advance `row' beyond the last row of the window.
7703 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7704 into disp_prop; all users changed.
7706 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7707 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7708 for the text covered by the display property.
7710 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7712 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7713 Change return value to nil.
7714 (Frecord_buffer): Delete unused function.
7716 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7718 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7719 buffers, return left-to-right.
7720 (set_cursor_from_row): Consider candidate row a win if its glyph
7721 represents a newline and point is on that newline. Fixes cursor
7722 positioning on the newline at EOL of R2L text within L2R
7723 paragraph, and vice versa.
7724 (try_cursor_movement): Check continued rows, in addition to
7725 continuation rows. Fixes unwarranted scroll when point enters a
7726 continued line of R2L text within an L2R paragraph, or vice versa.
7727 (cursor_row_p): Consider the case of point being equal to
7728 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7729 from the end of a short line to the beginning of a continued line
7730 of R2L text within L2R paragraph.
7731 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7732 composed characters.
7734 * bidi.c (bidi_check_type): Use xassert.
7735 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7738 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7740 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7743 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7745 * nsfont.m (ns_otf_to_script): Fix typo.
7747 2011-08-22 Kenichi Handa <handa@m17n.org>
7749 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7750 extra slot even if the purpose is char-code-property-table.
7752 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7754 * xdisp.c (redisplay_window): When computing centering_position,
7755 account for the height of the header line. (Bug#8874)
7757 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7758 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7759 candidate is selected by the mouse, and that candidate has a
7760 composed character under the mouse.
7762 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7763 coordinates reported by pos-visible-in-window-p for a composed
7764 character in column zero.
7766 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7768 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7770 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7772 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7773 consider it a hit if to_charpos is anywhere in the range of the
7774 composed buffer positions.
7776 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7778 * image.c (gif_load): Don't assume that each subimage has the same
7779 dimensions as the base image. Handle disposal method that is
7780 "undefined" by the gif spec (Bug#9335).
7782 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7784 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7785 (Fcondition_case): Document `debug' symbol in error handler.
7787 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7789 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7790 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7791 from an Org mode buffer to a Speedbar frame.
7793 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7794 a composition, take its buffer position from IT->cmp_it.charpos.
7795 Fixes cursor positioning at the beginning of a line that begins
7796 with a composed character.
7798 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7800 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7801 character bidirectional type, use STRONG_L instead. Fixes crashes
7802 in a buffer produced by `describe-categories'.
7804 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7805 members before the level stack, so they would be saved and
7806 restored when copying iterator state. Fixes incorrect reordering
7807 around TABs covered by display properties.
7809 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7811 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7813 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7815 * eval.c (internal_condition_case, internal_condition_case_1)
7816 (internal_condition_case_2, internal_condition_case_n):
7817 Remove unnecessary aborts (Bug#9081).
7819 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7821 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7822 has no `load' handler, try opening the file locally. (Bug#9311)
7824 2011-08-16 Ken Brown <kbrown@cornell.edu>
7826 * gmalloc.c: Expand comment.
7828 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7830 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7831 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7833 2011-08-16 Ken Brown <kbrown@cornell.edu>
7835 Fix memory allocation problems in Cygwin build (Bug#9273).
7837 * unexcw.c ( __malloc_initialized): Declare external variable.
7838 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7840 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7842 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7844 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7846 [CYGWIN] (special_realloc): New function.
7847 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7848 requests to realloc storage in the static heap.
7850 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7852 * bidi.c (bidi_initialize): Remove unused local.
7854 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7857 * biditype.h: Remove file.
7858 * makefile.w32-in ($(BLD)/bidi.$(O)):
7859 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7861 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7863 * chartab.c: Improve commentary for the uniprop_table API.
7865 * bidi.c (bidi_paragraph_init): Support zero value of
7866 bidi_ignore_explicit_marks_for_paragraph_level.
7867 (bidi_initialize): Use uniprop_table instead of including
7868 biditype.h and bidimirror.h.
7870 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7871 coordinates of the iterator when restoring from ppos_it.
7874 2011-08-14 Kenichi Handa <handa@m17n.org>
7876 * process.c (create_process): Call setup_process_coding_systems
7877 after the pid of the process is set to -1 (Bug#8162).
7879 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7881 * xdisp.c (move_it_in_display_line_to): Don't invoke
7882 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7883 ppos_it. Fixes vertical cursor motion when line beginning is
7884 covered by an image. (Bug#9296)
7886 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7888 * nsterm.h (ns_run_ascript): Declare.
7889 (NSAPP_DATA2_RUNASSCRIPT): Define.
7891 * nsfns.m (as_script, as_result, as_status): New static variables.
7892 (ns_run_ascript): New function.
7893 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7894 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7895 the event loop. Get status from as_status (Bug#7276).
7897 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7898 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7899 the event loop (Bug#7276).
7901 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7903 * gnutls.c (QCgnutls_bootprop_priority)
7904 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7905 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7906 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7907 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7908 (QCgnutls_bootprop_verify_hostname_error)
7909 (QCgnutls_bootprop_callbacks_verify): Rename from
7910 Qgnutls_bootprop_..., all uses changed.
7912 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7915 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7917 * xfaces.c (Qframe_set_background_mode): Now static.
7918 * dispextern.h (Qframe_set_background_mode): Remove decl.
7920 * process.c (Fnetwork_interface_info): Declare local only if needed.
7922 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7924 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7925 (Fnetwork_interface_list): Allocate in increments of bytes instead
7926 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7927 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7929 (struct ifflag_def): notrailers is smart on OSX.
7930 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7931 Get hardware address with getifaddrs if available.
7933 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7935 * xdisp.c (iterate_out_of_display_property): xassert that
7936 IT->position is set to within IT->object's boundaries. Break from
7937 the loop as soon as EOB is reached; avoids infloops in redisplay
7938 when IT->position is set up wrongly due to some bug.
7939 Set IT->current to match the bidi iterator unconditionally.
7940 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7941 entry. Force push_it to save on the stack the current
7942 buffer/string position, to be restored by pop_it. Fix flags in
7943 the iterator structure wrt the object coming from a display
7944 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7945 properties. (Bug#9284)
7947 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7949 * fontset.c (fontset_get_font_group): Add proper type checks.
7952 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7954 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7955 and LC_VERSION_MIN_MACOSX.
7956 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7957 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7959 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7961 * xdisp.c (forward_to_next_line_start): Allow to use the
7962 no-display-properties-and-no-overlays under bidi display.
7963 Set disp_pos in the bidi iterator to avoid searches for display
7964 properties and overlays.
7966 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7968 * editfns.c (Fset_time_zone_rule): Document relationship with the
7971 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7972 the font entity extracted from the cache (Bug#8109).
7974 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7976 * composite.c (autocmp_chars): Don't reset point. That is done by
7977 restore_point_unwind (Bug#5984).
7979 2011-08-07 Juri Linkov <juri@jurta.org>
7981 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7982 to show the arg `TIME' instead of `TIMEVAL'.
7984 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7986 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7987 display property strides EOL and includes a newline, as in
7988 longlines-mode. (Bug#9254)
7989 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7990 word-wrap under bidirectional display. (Bug#9224)
7992 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7993 is non-zero, even if the data buffer is NULL. Fixes a crash in
7994 vertical-motion with longlines-mode. (Bug#9254)
7996 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7998 * bidi.c <bidi_cache_total_alloc>: Now static.
7999 (bidi_initialize): Initialize bidi_cache_total_alloc.
8001 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8004 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8005 amount allocated this far in `bidi_cache_total_alloc'.
8006 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8007 non-zero, only free the data buffer without restoring the cache
8008 contents. All callers changed.
8010 * dispextern.h (bidi_unshelve_cache): Update prototype.
8012 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8013 (move_it_in_display_line, move_it_to)
8014 (move_it_vertically_backward, move_it_by_lines): Replace the call
8015 to xfree to an equivalent call to bidi_unshelve_cache.
8016 (move_it_in_display_line_to): Fix logic of returning
8017 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8019 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8021 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8022 came from a string character with a `cursor' property. (Bug#9229)
8024 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8026 * Makefile.in (LIB_PTHREAD): New variable.
8027 (LIBES): Add LIB_PTHREAD (Bug#9216).
8029 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8030 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8032 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8034 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8036 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8038 * xterm.c (x_find_topmost_parent): New function.
8039 (x_set_frame_alpha): Find topmost parent window with
8040 x_find_topmost_parent and set the property there also (bug#9181).
8041 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8043 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8045 * callproc.c (Fcall_process): Avoid vfork clobbering
8046 the local vars buffer, coding_systems, current_dir.
8048 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8050 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8052 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8054 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8055 so that it is not optimized away.
8057 * xdisp.c (compute_display_string_pos): Remove unused local.
8059 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8061 Fix slow cursor motion and scrolling in large buffers with
8062 selective display, like Org Mode buffers. (Bug#9218)
8064 * dispextern.h (struct bidi_it): New member disp_prop_p.
8066 * xdisp.c: Remove one-slot cache of display string positions.
8067 (compute_display_string_pos): Accept an additional argument
8068 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8069 for a display string or property. If found, set DISP_PROP_P
8072 * bidi.c (bidi_fetch_char): Accept an additional argument
8073 DISP_PROP_P, and pass it to compute_display_string_pos.
8074 Only handle text covered by a display string if DISP_PROP_P is returned
8075 non-zero. All callers of bidi_fetch_char changed.
8077 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8079 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8081 2010-12-03 Don March <don@ohspite.net>
8083 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8084 last character M-[char] is translated to ESC [char] (bug#7541).
8086 2011-08-02 Kenichi Handa <handa@m17n.org>
8088 * lisp.h (uniprop_table): Extern it.
8090 * chartab.c (uniprop_table): Make it non-static.
8092 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8094 * xdisp.c (forward_to_next_line_start): Accept additional argument
8095 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8097 (reseat_at_next_visible_line_start): Use the bidi iterator state
8098 returned by forward_to_next_line_start to restore the state of
8099 it->bidi_it after backing up to previous newline. (Bug#9212)
8101 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8103 * regex.c (re_comp): Protoize.
8104 (re_exec): Fix return type.
8105 (regexec): Fix type of `ret'. (Bug#9203)
8107 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8109 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8110 This is needed if max-image-size is a floating-point number.
8112 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8114 * print.c (print_object): Print empty symbol as ##.
8116 * lread.c (read1): Read ## as empty symbol.
8118 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8120 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8121 setting frame foreground color (Bug#9175).
8122 (x_set_background_color): Likewise.
8124 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8125 contents (Bug#9176).
8126 (EmacsTooltip -init): Remove bezels and add shadows to
8129 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8130 or scroll bar (Bug#8470).
8132 * nsfont.m (nsfont_open): Remove assignment to voffset and
8133 unnecessary vars hshink, expand, hd, full_height, min_height.
8134 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8136 * nsterm.h (nsfont_info): Remove voffset field.
8138 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8140 Implement strike-through and overline on NextStep (Bug#8863).
8142 * nsfont.m (nsfont_open): Use underline position provided by font,
8143 instead of hard-coded value of 2.
8144 (nsfont_draw): Call ns_draw_text_decoration instead.
8146 * nsterm.h: Add declaration for ns_draw_text_decoration.
8148 * nsterm.m (ns_draw_text_decoration): New function for drawing
8149 underline, overline, and strike-through.
8150 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8151 ns_draw_text_decoration. Change treatment of cursor drawing to
8152 accommodate underlining, etc.
8154 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8156 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8159 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8161 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8162 Without this fix, if a signal arrives just after memory fills up,
8163 'malloc' might be invoked reentrantly.
8165 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8166 In other words, assume that every image size is allowed, on non-X
8167 hosts. This assumption is probably wrong, but it lets Emacs compile.
8169 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8171 * regex.c (re_iswctype): Convert return values to boolean.
8173 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8175 * xdisp.c (compute_display_string_pos): Don't use cached display
8176 string position if the buffer had its restriction changed.
8179 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8181 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8183 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8185 Integer signedness and overflow and related fixes. (Bug#9079)
8187 * bidi.c: Integer size and overflow fixes.
8188 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8189 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8190 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8191 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8192 (bidi_find_other_level_edge):
8193 Use ptrdiff_t instead of EMACS_INT where either will do.
8194 This works better on 32-bit hosts configured --with-wide-int.
8195 (bidi_cache_ensure_space): Check for size-calculation overflow.
8196 Use % rather than repeated addition, for better worst-case speed.
8197 Don't set bidi_cache_size until after xrealloc returns, because it
8199 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8200 (bidi_cache_ensure_space): Also check that the bidi cache size
8201 does not exceed that of the largest Lisp string or buffer. See Eli
8202 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8204 * alloc.c (__malloc_size_t): Remove.
8205 All uses replaced by size_t. See Andreas Schwab's note
8206 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8208 * image.c: Improve checking for integer overflow.
8209 (check_image_size): Assume that f is nonnull, since
8210 it is always nonnull in practice. This is one less thing to
8211 worry about when checking for integer overflow later.
8212 (x_check_image_size): New function, which checks for integer
8213 overflow issues inside X.
8214 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8215 This removes the need for a memory_full check.
8216 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8217 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8218 (xbm_read_bitmap_data): Change locals back to 'int', since
8219 their values must fit in 'int'.
8220 (xpm_load_image, png_load, tiff_load):
8221 Invoke x_create_x_image_and_pixmap earlier,
8222 to avoid much needless work if the image is too large.
8223 (tiff_load): Treat overly large images as if
8224 x_create_x_image_and_pixmap failed, not as malloc failures.
8225 (gs_load): Use x_check_image_size.
8227 * gtkutil.c: Omit integer casts.
8228 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8229 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8231 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8233 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8234 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8235 would wrongly return t on a 64-bit host.
8237 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8238 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8239 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8240 and therefore cause GCC to emit a bogus diagnostic in some cases.
8242 * image.c: Integer signedness and overflow and related fixes.
8243 This is not an exhaustive set of fixes, but it's time to
8244 record what I've got.
8245 (lookup_pixel_color, check_image_size): Remove redundant decls.
8246 (check_image_size): Don't assume that arbitrary EMACS_INT values
8247 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8248 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8249 (tiff_load, imagemagick_load_image):
8250 Check for overflow in size calculations.
8251 (x_create_x_image_and_pixmap): Remove unnecessary test for
8252 xmalloc returning NULL; that can't happen.
8253 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8254 (xpm_color_bucket): Use better integer hashing function.
8255 (xpm_cache_color): Don't possibly over-allocate memory.
8256 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8257 (gif_memory_source):
8258 Use ptrdiff_t, not int or size_t, to record sizes.
8259 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8260 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8261 either works, as we prefer signed integers.
8262 (tiff_read_from_memory, tiff_write_from_memory):
8263 Return tsize_t, not size_t, since that's what the TIFF API wants.
8264 (tiff_read_from_memory): Don't fail simply because the read would
8265 go past EOF; instead, return a short read.
8266 (tiff_load): Omit no-longer-needed casts.
8267 (Fimagemagick_types): Don't assume size fits into 'int'.
8269 Improve hashing quality when configured --with-wide-int.
8270 * fns.c (hash_string): New function, taken from sxhash_string.
8271 Do not discard information about ASCII character case; this
8272 discarding is no longer needed.
8273 (sxhash-string): Use it. Change sig to match it. Caller changed.
8274 * lisp.h: Declare it.
8275 * lread.c (hash_string): Remove, since we now use fns.c's version.
8276 The fns.c version returns a wider integer if --with-wide-int is
8277 specified, so this should help the quality of the hashing a bit.
8279 * emacs.c: Integer overflow minor fix.
8280 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8281 Define only if GNU_LINUX.
8282 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8284 * dispnew.c: Integer signedness and overflow fixes.
8285 Remove unnecessary forward decls, that were a maintenance hassle.
8286 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8288 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8289 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8290 (prepare_desired_row, line_draw_cost):
8291 Use int, not unsigned, where either works.
8292 (save_current_matrix, restore_current_matrix):
8293 Use ptrdiff_t, not size_t, where either works.
8294 (init_display): Check for overflow more accurately, and without
8295 relying on undefined behavior.
8297 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8298 Remove, replacing with the new symbols in lisp.h. All uses changed.
8299 * fileio.c (make_temp_name):
8300 * filelock.c (lock_file_1, lock_file):
8301 * xdisp.c (message_dolog):
8302 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8303 Use pMd etc. instead.
8304 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8305 replacing the pWIDE etc. symbols removed from editfns.c.
8307 * keyboard.h (num_input_events): Now uintmax_t.
8308 This is (very slightly) less likely to mess up due to wraparound.
8311 * buffer.c: Integer signedness fixes.
8312 (alloc_buffer_text, enlarge_buffer_text):
8313 Use ptrdiff_t rather than size_t when either will do, as we prefer
8316 * alloc.c: Integer signedness and overflow fixes.
8317 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8318 (__malloc_size_t): Default to size_t, not to int.
8319 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8320 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8321 Prefer ptrdiff_t to size_t when either would do, as we prefer
8323 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8324 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8325 Now const. Initialize with values that are in range even if char
8327 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8328 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8329 These functions do the right thing with sizes > 2**32.
8330 (check_depth): Now ptrdiff_t, not int.
8331 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8332 Adjust to new way of storing sizes. Check for size overflow bugs
8334 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8335 slightly wrong anyway, as it missed one instance of
8336 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8337 (refill_memory_reserve): Omit needless cast to size_t.
8338 (mark_object_loop_halt): Mark as externally visible.
8340 * xselect.c: Integer signedness and overflow fixes.
8341 (Fx_register_dnd_atom, x_handle_dnd_message):
8342 Use ptrdiff_t, not size_t, since we prefer signed.
8343 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8344 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8345 x_dnd_atoms_size and x_dnd_atoms_length.
8347 * doprnt.c: Prefer signed to unsigned when either works.
8349 * doprnt.c (doprnt):
8351 * xdisp.c (vmessage):
8352 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8353 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8354 prefer signed arithmetic to avoid comparison confusion.
8355 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8356 but is a bit tricky.
8358 Assume freestanding C89 headers, string.h, stdlib.h.
8359 * data.c, doprnt.c, floatfns.c, print.c:
8360 Include float.h unconditionally.
8361 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8362 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8363 * regex.c: Likewise for stddef.h, string.h.
8364 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8365 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8366 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8367 (STDC_HEADERS): Remove obsolete defines.
8368 * sysdep.c: Include limits.h unconditionally.
8370 Assume support for memcmp, memcpy, memmove, memset.
8371 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8372 * regex.c (memcmp, memcpy):
8373 Remove; we assume C89 now.
8375 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8376 (__malloc_safe_bcopy): Remove; no longer needed.
8378 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8379 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8380 well either way, and we prefer signed to unsigned.
8382 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8384 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8385 closes the connection while we're reading (bug#9182).
8387 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8389 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8390 are specified (Bug#9168).
8392 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8394 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8395 Found by GCC static checking and --with-wide-int on a 32-bit host.
8397 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8399 * xdisp.c (compute_display_string_pos): Fix logic of caching
8400 previous display string position. Initialize cached_prev_pos to
8401 -1. Fixes slow-down at the beginning of a buffer.
8403 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8405 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8406 for attrs[LFACE_FONTSET_INDEX].
8408 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8410 * xml.c (parse_region): Remove unused local
8411 that was recently introduced.
8413 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8415 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8416 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8418 * xdisp.c (move_it_in_display_line_to): Record the best matching
8419 position for TO_CHARPOS while scanning the line, and restore it on
8420 exit if none of the characters scanned was an exact match.
8421 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8422 when exact match is impossible due to invisible text, and the
8423 lines are truncated.
8425 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8427 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8430 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8432 Fix a significant slow-down of cursor motion with C-n, C-p,
8433 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8434 auto-repeat under bidi redisplay in fontified buffers.
8435 * xdisp.c (compute_stop_pos_backwards): New function.
8436 (next_element_from_buffer): Call compute_stop_pos_backwards to
8437 find a suitable prev_stop when we find ourselves before
8439 (reseat): Don't look for prev_stop, as that could mean a very long
8441 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8442 <cached_disp_overlay_modiff>: Cache for last found display string
8444 (compute_display_string_pos): Return the cached position if asked
8445 about the same buffer in the same area of character positions, and
8446 the buffer wasn't changed since the time the display string
8447 position was cached.
8449 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8451 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8452 is an integer, which is important for empty lines. (Bug#9149)
8454 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8456 * frame.c (Fmodify_frame_parameters): In tty case, update the
8457 default face if necessary (Bug#4238).
8459 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8461 * editfns.c (Fstring_to_char): No need to explain what a character
8462 is in the docstring (Bug#6576).
8464 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8466 * xml.c (parse_region): Make sure we always return a tree.
8468 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8470 * xml.c (parse_region): If a document contains only comments,
8473 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8475 * xml.c (make_dom): Return comments, too.
8477 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8480 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8481 and the surrounding thread.
8482 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8483 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8484 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8486 * s/openbsd.h (BROKEN_SIGIO): Define.
8487 * unexelf.c (unexec) [__OpenBSD__]:
8488 Don't update the .mdebug section of the Alpha COFF symbol table.
8490 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8492 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8495 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8497 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8498 This fixes some race conditions on the permissions of any newly
8501 * alloc.c (valid_pointer_p): Use pipe, not open.
8502 This fixes some permissions issues when debugging.
8504 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8505 If fchown fails to set both uid and gid, try to set just gid,
8506 as that is sometimes allowed. Adjust the file's mode to eliminate
8507 setuid or setgid bits that are inappropriate if fchown fails.
8509 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8511 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8512 to compare Lisp_Objects.
8513 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8514 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8515 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8517 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8519 * lread.c (read_integer): Unread even EOF character.
8520 (read1): Likewise. Properly record start position of symbol.
8522 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8523 symbol character follows.
8525 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8527 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8528 This works around a problem with the previous change to Fcopy_file.
8529 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8530 and without this change, GCC might complain about discarding
8531 fchown's return value.
8533 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8535 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8537 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8539 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8541 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8543 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8544 it's used from the C level.
8546 * process.c: Use the same condition for POLL_FOR_INPUT in both
8547 keyboard.c and process.c (bug#1858).
8549 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8551 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8552 (Fgnutls_boot): Use it.
8554 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8556 * doc.c (Fsubstitute_command_keys): Revert last change.
8558 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8560 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8561 quotes the next character, and doesn't affect other longer
8562 sequences (bug#8935).
8564 * lread.c (syms_of_lread): Clarify that is isn't only
8565 `eval-buffer' and `eval-defun' that's affected by
8566 `lexical-binding' (bug#8460).
8568 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8570 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8571 bidi redisplay when a line includes both an image and is truncated.
8573 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8575 Fix minor problems found by static checking.
8576 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8577 (elsz): Now a signed constant, not a size_t var. We prefer signed
8578 types to unsigned, to avoid integer comparison confusion. Without
8579 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8580 "cannot optimize loop, the loop counter may overflow", a symptom
8582 * indent.c (Fvertical_motion): Mark locals as initialized.
8583 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8585 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8587 * search.c (Fre_search_backward): Mention `case-fold-search' in
8588 all the re_search_* functions (bug#8138).
8590 * keyboard.c (Fopen_dribble_file): Document when the file is
8593 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8595 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8598 Support bidi reordering of display and overlay strings.
8599 * xdisp.c (compute_display_string_pos)
8600 (compute_display_string_end): Accept additional argument STRING.
8601 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8602 (reseat_to_string): Initialize bidi_it->string.s and
8603 bidi_it->string.schars.
8604 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8605 NULL (avoids a crash in bidi_paragraph_init).
8606 Initialize itb.string.lstring.
8607 (init_iterator): Call bidi_init_it only of a valid
8608 buffer position was specified. Initialize paragraph_embedding to
8610 (reseat_to_string): Initialize the bidi iterator.
8611 (display_string): If we need to ignore text properties of
8612 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8613 original value of -1 will not work with bidi.)
8614 (compute_display_string_pos): First arg is now struct
8615 `text_pos *'; all callers changed. Support display properties on
8617 (compute_display_string_end): Support display properties on Lisp
8619 (init_iterator, reseat_1, reseat_to_string): Initialize the
8620 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8621 when iterating on a string not from display properties).
8622 (compute_display_string_pos, compute_display_string_end):
8623 Fix calculation of the object to scan. Fixes an error when using
8625 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8626 base_level_stop; instead, set base_level_stop to BEGV.
8627 Fixes crashes in vertical-motion.
8628 (next_element_from_buffer): Improve commentary for when
8629 the iterator is before prev_stop.
8630 (init_iterator): Initialize bidi_p from the default value of
8631 bidi-display-reordering, not from buffer-local value. Use the
8632 buffer-local value only if initializing for buffer iteration.
8633 (handle_invisible_prop): Support invisible properties on strings
8634 that are being bidi-reordered.
8635 (set_iterator_to_next): Support bidi reordering of C strings and
8637 (next_element_from_string): Support bidi reordering of Lisp
8639 (handle_stop_backwards): Support Lisp strings as well.
8640 (display_string): Support display of R2L glyph rows.
8641 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8642 (init_iterator): Don't initialize it->bidi_p for strings
8644 (reseat_to_string): Initialize it->bidi_p for strings here.
8645 (next_element_from_string, next_element_from_c_string)
8646 (next_element_from_buffer): Add xassert's for correspondence
8647 between IT's object being iterated and it->bidi_it.string
8649 (face_before_or_after_it_pos): Support bidi iteration.
8650 (next_element_from_c_string): Handle the case of the first string
8651 character that is not the first one in the visual order.
8652 (get_visually_first_element): New function, refactored from common
8653 parts of next_element_from_buffer, next_element_from_string, and
8654 next_element_from_c_string.
8655 (tool_bar_lines_needed, redisplay_tool_bar)
8656 (display_menu_bar): Force left-to-right direction. Add a FIXME
8657 comment for making that be controlled by a user option.
8658 (push_it, pop_it): Save and restore the state of the
8659 bidi iterator. Save and restore the bidi_p flag.
8660 (pop_it): Iterate out of display property for string iteration as
8662 (iterate_out_of_display_property): Support iteration over strings.
8663 (handle_single_display_spec): Set up it->bidi_it for iteration
8664 over a display string, and call bidi_init_it.
8665 (handle_single_display_spec, next_overlay_string)
8666 (get_overlay_strings_1, push_display_prop): Set up the bidi
8667 iterator for displaying display or overlay strings.
8668 (forward_to_next_line_start): Don't use the shortcut if
8670 (back_to_previous_visible_line_start): If handle_display_prop
8671 pushed the iterator stack, restore the internal state of the bidi
8672 iterator by calling bidi_pop_it same number of times.
8673 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8674 and we are bidi-iterating, don't decrement the iterator position;
8675 instead, set the first_elt flag in the bidi iterator, to produce
8677 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8678 (push_display_prop): xassert that we are iterating a buffer.
8679 (push_it, pop_it): Save and restore paragraph_embedding member.
8680 (handle_single_display_spec, next_overlay_string)
8681 (get_overlay_strings_1, reseat_1, reseat_to_string)
8682 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8683 correctly. Don't assume unibyte strings are not bidi-reordered.
8684 (compute_display_string_pos)
8685 (compute_display_string_end): Fix handling the case of C string.
8686 (push_it, pop_it): Save and restore from_disp_prop_p.
8687 (handle_single_display_spec, push_display_prop): Set the
8688 from_disp_prop_p flag.
8689 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8690 (pop_it): Call iterate_out_of_display_property only if we are
8691 popping after iteration over a string that came from a display
8692 property. Fix a typo in popping stretch info. Add an assertion
8693 for verifying that the iterator position is in sync with the bidi
8695 (handle_single_display_spec, get_overlay_strings_1)
8696 (push_display_prop): Fix initialization of paragraph direction for
8697 string when that of the parent object is not yet determined.
8698 (reseat_1): Call bidi_init_it to resync the bidi
8699 iterator with IT's position. (Bug#7616)
8700 (find_row_edges): If ROW->start.pos gives position
8701 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8702 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8703 Reset the from_disp_prop_p flag.
8704 (SAVE_IT, RESTORE_IT): New macros.
8705 (pos_visible_p, face_before_or_after_it_pos)
8706 (back_to_previous_visible_line_start)
8707 (move_it_in_display_line_to, move_it_in_display_line)
8708 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8709 (try_scrolling, redisplay_window, display_line): Use them when
8710 saving a temporary copy of the iterator and restoring it back.
8711 (back_to_previous_visible_line_start, reseat_1)
8712 (init_iterator): Empty the bidi cache "stack".
8713 (move_it_in_display_line_to): If iterator ended up at
8714 EOL, but we never saw any buffer positions smaller than
8715 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8716 motion in bidi-reordered lines.
8717 (move_it_in_display_line_to): Record prev_method and prev_pos
8718 immediately before the call to set_iterator_to_next. Fixes cursor
8719 motion in bidi-reordered lines with stretch glyphs and strings
8720 displayed in margins. (Bug#8133) (Bug#8867)
8721 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8723 (pos_visible_p): Support positions in bidi-reordered lines.
8724 Save and restore bidi cache.
8726 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8727 (bidi_paragraph_info): Delete unused struct.
8728 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8729 (bidi_cache_start): New variable.
8730 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8732 (bidi_cache_fetch_state, bidi_cache_search)
8733 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8734 (bidi_cache_find, bidi_peek_at_next_level)
8735 (bidi_level_of_next_char, bidi_find_other_level_edge)
8736 (bidi_move_to_visually_next): Compare cache index with
8737 bidi_cache_start rather than with zero.
8738 (bidi_fetch_char): Accept new argument STRING; all callers
8739 changed. Support iteration over a string. Support strings with
8740 display properties. Support unibyte strings. Fix the type of
8741 `len' according to what STRING_CHAR_AND_LENGTH expects.
8742 (bidi_paragraph_init, bidi_resolve_explicit_1)
8743 (bidi_resolve_explicit, bidi_resolve_weak)
8744 (bidi_level_of_next_char, bidi_move_to_visually_next):
8745 Support iteration over a string.
8746 (bidi_set_sor_type, bidi_resolve_explicit_1)
8747 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8748 can now be zero (for strings); special values 0 and -1 were
8749 changed to -1 and -2, respectively.
8750 (bidi_char_at_pos): New function.
8751 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8752 Call it instead of FETCH_MULTIBYTE_CHAR.
8753 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8754 initialized to valid values.
8755 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8757 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8758 the test for valid cached positions. Fix the logic for looking up
8759 the sentinel state in the cache. GCPRO the Lisp string we are
8761 (bidi_push_it, bidi_pop_it): New functions.
8762 (bidi_initialize): Initialize the bidi cache start stack pointer.
8763 (bidi_cache_ensure_space): New function, refactored from part of
8764 bidi_cache_iterator_state. Don't assume the required size is just
8765 one BIDI_CACHE_CHUNK away.
8766 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8767 (bidi_count_bytes, bidi_char_at_pos): New functions.
8768 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8769 always valid if bidi_cache_idx is valid.
8770 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8771 is valid if it's going to be used.
8772 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8773 (bidi_cache_fetch_state, bidi_cache_search)
8774 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8775 (bidi_cache_iterator_state, bidi_cache_find)
8776 (bidi_find_other_level_edge, bidi_cache_start_stack):
8777 All variables related to cache indices are now EMACS_INT.
8779 * dispextern.h (struct bidi_string_data): New structure.
8780 (struct bidi_it): New member `string'. Make flag members be 1-bit
8781 fields, and put them last in the struct.
8782 (compute_display_string_pos, compute_display_string_end):
8784 (bidi_push_it, bidi_pop_it): Add prototypes.
8785 (struct iterator_stack_entry): New members bidi_p,
8786 paragraph_embedding, and from_disp_prop_p.
8787 (struct it): Member bidi_p is now a bit field 1 bit wide.
8788 (bidi_shelve_cache, bidi_unshelve_cache):
8791 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8792 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8793 and vector-like objects.
8795 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8796 cache around display iteration.
8798 * window.c (Fwindow_end, window_scroll_pixel_based)
8799 (displayed_window_lines, Frecenter): Save and restore the bidi
8800 cache around display iteration.
8802 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8804 * editfns.c (Fdelete_region): Clarify the use of the named
8805 parameters (bug#6788).
8807 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8809 * indent.c (Fvertical_motion): Set and restore w->pointm when
8810 saving and restoring the window's buffer (Bug#9006).
8812 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8814 * editfns.c (Fstring_to_char): Clarify just what is returned
8815 (bug#6576). Text by Eli Zaretskii.
8817 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8819 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8821 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8823 * buffer.c (mmap_find): Fix a typo.
8825 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8827 Fix execution of x selection hooks.
8828 * xselect.c (Qx_lost_selection_functions)
8829 (Qx_sent_selection_functions): New vars.
8830 (syms_of_xselect): DEFSYM them.
8831 (x_handle_selection_request): Pass Qx_sent_selection_functions
8832 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8833 (x_handle_selection_clear,x_clear_frame_selections):
8834 Pass Qx_lost_selection_functions rather than
8835 Vx_lost_selection_functions to Frun_hook_with_args.
8837 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8839 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8840 The old code sometimes used this field without initializing it.
8842 * alloc.c (gc_sweep): Don't read past end of array.
8843 In theory, the old code could also have corrupted Emacs internals,
8844 though it'd be very unlikely.
8846 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8848 * character.c (Fcharacterp): Don't advertise optional ignored
8849 argument. (Bug#4026)
8851 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8853 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8856 * window.c (Fset_window_start): Doc fix (bug#4199).
8857 (Fset_window_hscroll): Ditto.
8859 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8861 Fix minor new problems caught by GCC 4.6.1.
8862 * term.c (init_tty): Remove unused local.
8863 * xsettings.c (store_monospaced_changed): Define this function only
8864 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8867 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8869 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8871 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8873 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8874 are the mini-buffer and the echo area (bug#3320).
8876 * term.c (init_tty): Remove support for supdup, c10 and perq
8877 terminals, which are no longer supported (bug#1482).
8879 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8881 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8883 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8885 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8886 for non-popups (Bug#3642).
8888 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8890 * alloc.c (reset_malloc_hooks): Protoize.
8891 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8892 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8893 * cm.c (losecursor): Likewise.
8894 * data.c (fmod): Likewise.
8895 * dispnew.c (swap_glyphs_in_rows): Likewise.
8896 * emacs.c (memory_warning_signal): Likewise.
8897 * floatfns.c (float_error): Likewise.
8898 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8899 (otf_open, font_otf_capability, generate_otf_features)
8900 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8902 * image.c (pbm_read_file): Likewise.
8903 * indent.c (string_display_width): Likewise.
8904 * intervals.c (check_for_interval, search_for_interval)
8905 (inc_interval_count, count_intervals, root_interval)
8906 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8907 * lread.c (defalias): Likewise.
8908 * ralloc.c (r_alloc_check): Likewise.
8909 * regex.c (set_image_of_range_1, set_image_of_range)
8910 (regex_grow_registers): Likewise.
8911 * sysdep.c (strerror): Likewise.
8912 * termcap.c (valid_filename_p, tprint, main): Likewise.
8913 * tparam.c (main): Likewise.
8914 * unexhp9k800.c (run_time_remap, save_data_space)
8915 (update_file_ptrs, read_header, write_header, calculate_checksum)
8916 (copy_file, copy_rest, display_header): Likewise.
8917 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8919 * xdisp.c (check_it): Likewise.
8920 * xfaces.c (register_color, unregister_color, unregister_colors):
8922 * xfns.c (print_fontset_result): Likewise.
8923 * xrdb.c (member, fatal, main): Likewise.
8925 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8927 Fix minor problems found by static checking (Bug#9031).
8928 * chartab.c (char_table_set_range, map_sub_char_table):
8929 Remove unused locals.
8930 (uniprop_table): Now static.
8931 * composite.c (_work_char): Remove unused static var.
8933 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8935 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8937 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8939 * gtkutil.c (qttip_cb): Remove code without function.
8941 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8943 * w32.c (pthread_sigmask): New stub.
8945 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8947 Use pthread_sigmask, not sigprocmask (Bug#9010).
8948 sigprocmask is portable only for single-threaded applications, and
8949 Emacs can be multi-threaded when it uses GTK.
8950 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8952 * callproc.c (Fcall_process):
8953 * process.c (create_process):
8954 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8955 Use pthread_sigmask, not sigprocmask.
8957 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8959 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8960 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8963 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8965 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8966 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8967 (xg_hide_tooltip): Fix comment.
8969 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8970 in registerServicesMenuSendTypes.
8971 (validRequestorForSendType): Don't check ns_return_types.
8973 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8976 2011-07-08 Jason Rumney <jasonr@gnu.org>
8978 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8979 SH_SHOW for hidden windows (Bug#5482).
8981 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8982 frame struct members of non-existent frames (Bug#6284).
8984 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8986 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8987 variable firstTime not needed on OSX >= 10.6.
8988 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8989 >= 10.5. Use setKnobProportion, setDoubleValue.
8991 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8992 (MAC_OS_X_VERSION_10_5): Define if not defined.
8993 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8994 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8995 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8997 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8998 cString and lossyCString on OSX >= 10.4.
9000 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9001 sizeToFit on OSX >= 10.2.
9003 * nsimage.m (allocInitFromFile): Don't use deprecated method
9004 bestRepresentationForDevice on OSX >= 10.6.
9006 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9009 * emacs.c: Declare unexec_init_emacs_zone.
9011 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9013 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9015 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9016 on svcsMenu (Bug#8842).
9018 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9020 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9022 * nsterm.m (QUTF8_STRING): Declare.
9023 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9024 (validRequestorForSendType): Return type is (id).
9025 Change indexOfObjectIdenticalTo to indexOfObject.
9026 Check if we have local selection before returning self (Bug#8842).
9027 (writeSelectionToPasteboard): Put local selection into paste board
9028 if we have a local selection (Bug#8842).
9029 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9031 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9032 (ns_get_local_selection): Declare.
9034 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9036 * keymap.c (describe_map_tree): Don't insert a double newline at
9037 the end of the buffer (bug#1169) and return whether we inserted
9040 * callint.c (Fcall_interactively): Change "reading args" to
9041 "providing args" to try to clarify what it does (bug#1010).
9043 2011-07-07 Kenichi Handa <handa@m17n.org>
9045 * composite.c (composition_compute_stop_pos): Ignore a static
9046 composition starting before CHARPOS (Bug#8915).
9048 * xdisp.c (handle_composition_prop): Likewise.
9050 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9052 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9055 2011-07-07 Kenichi Handa <handa@m17n.org>
9057 * character.h (unicode_category_t): New enum type.
9059 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9060 (Qchar_code_property_table): New variable.
9061 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9062 (UNIPROP_COMPRESSED_FORM_P): New macros.
9063 (char_table_ascii): Uncompress the compressed values.
9064 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9065 Uncompress the compressed values.
9066 (sub_char_table_ref_and_range): Likewise.
9067 (char_table_ref_and_range): Uncompress the compressed values.
9068 (sub_char_table_set): New arg is_uniprop. Callers changed.
9069 Uncompress the compressed values.
9070 (sub_char_table_set_range): Args changed. Callers changed.
9071 (char_table_set_range): Adjuted for the above change.
9072 (map_sub_char_table): Delete args default_val and parent. Add arg
9073 top. Give decoded values to a Lisp function.
9074 (map_char_table): Adjust for the above change. Give decoded
9075 values to a Lisp function. Gcpro more variables.
9076 (uniprop_table_uncompress)
9077 (uniprop_decode_value_run_length): New functions.
9078 (uniprop_decoder, uniprop_decoder_count): New variables.
9079 (uniprop_get_decoder, uniprop_encode_value_character)
9080 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9082 (uniprop_encoder, uniprop_encoder_count): New variables.
9083 (uniprop_get_encoder, uniprop_table)
9084 (Funicode_property_table_internal, Fget_unicode_property_internal)
9085 (Fput_unicode_property_internal): New functions.
9086 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9087 Sunicode_property_table_internal, Sget_unicode_property_internal,
9088 and Sput_unicode_property_internal. Defvar_lisp
9089 char-code-property-alist.
9091 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9092 Vunicode_category_table.
9094 * font.c (font_range): Adjust for the change of
9095 Vunicode_category_table.
9097 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9099 * m/iris4d.h: Remove file, move contents ...
9100 * s/irix6-5.h: ... here.
9102 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9104 Remove unportable assumption about struct layout (Bug#8884).
9105 * alloc.c (mark_buffer):
9106 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9107 (clone_per_buffer_values): Don't assume that
9108 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9109 This isn't true in general, and it's particularly not true
9110 if Emacs is configured with --with-wide-int.
9111 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9112 New macros, used in the buffer.c change.
9114 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9116 * xsettings.c: Use both GConf and GSettings if both are available.
9117 (store_config_changed_event): Add comment.
9118 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9119 (store_tool_bar_style_changed): New functions.
9120 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9121 (struct xsettings): Move font inside HAVE_XFT.
9122 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9123 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9124 Move inside HAVE_XFT.
9125 (something_changed_gsettingsCB): Rename from something_changedCB.
9126 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9128 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9129 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9130 (something_changed_gconfCB): Rename from something_changedCB.
9131 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9132 (parse_settings): Move check for font inside HAVE_XFT.
9133 (read_settings, apply_xft_settings): Add comment.
9134 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9135 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9136 call store_font_name_changed.
9137 (xft_settings_event): Add comment.
9138 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9139 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9140 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9141 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9142 (xsettings_initialize): Call init_gsettings last.
9143 (xsettings_get_system_font, xsettings_get_system_normal_font):
9146 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9148 Random fixes. E.g., (random) never returned negative values.
9149 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9150 subseconds part to the entropy, as that's a bit more random.
9151 Prefer signed to unsigned, since the signedness doesn't matter and
9152 in general we prefer signed. When given a limit, use a
9153 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9154 latter isn't right if USE_2_TAGS_FOR_INTS.
9155 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9156 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9158 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9160 * textprop.c (text_property_stickiness):
9161 Obey Vtext_property_default_nonsticky.
9162 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9163 * w32fns.c (syms_of_w32fns):
9164 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9166 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9168 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9169 This is more efficient than Ffile_directory_p and avoids a minor race.
9171 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9173 * buffer.c (Foverlay_put): Say what the return value is
9176 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9177 is a directory before asking whether to use the file name
9179 (barf_or_query_if_file_exists): Make the "File is a directory"
9180 error be more correct.
9182 * fns.c (Frequire): Remove the mention of the .gz files, since
9183 that's installation-specific, but keep the mention of
9184 `get-load-suffixes'.
9186 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9188 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9189 Report string overflow if the output is too long.
9191 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9193 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9194 (syms_of_gnutls): Remove duplicate DEFSYM for
9195 Qgnutls_bootprop_verify_hostname_error, an error for
9196 Qgnutls_bootprop_verify_error (which is no longer used).
9198 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9199 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9200 Also (re)move comments that are misplaced or no longer relevant.
9202 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9204 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9206 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9208 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9209 and background color parameters if they have been changed.
9211 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9213 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9215 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9217 * xsettings.c (SYSTEM_FONT): Define only when used.
9218 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9220 * keymap.c (access_keymap_1): Now static.
9222 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9224 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9225 leave any prefix arg for the up event (Bug#1586).
9227 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9229 * lread.c (syms_of_lread): Mention single symbols defined by
9230 `defvar' or `defconst' (bug#7154).
9232 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9233 (Frequire): Mention get-load-suffixes.
9235 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9237 * window.h (window): Remove clone_number slot.
9238 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9240 (make_parent_window, make_window, saved_window)
9241 (Fset_window_configuration, save_window_save): Don't deal with
9243 * buffer.c (Qclone_number): Remove declaration.
9244 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9246 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9248 Add multiple inheritance to keymaps.
9249 * keymap.c (Fmake_composed_keymap): New function.
9250 (Fset_keymap_parent): Simplify.
9251 (fix_submap_inheritance): Remove.
9252 (access_keymap_1): New function extracted from access_keymap to handle
9253 embedded parents and handle lists of maps.
9254 (access_keymap): Use it.
9255 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9256 (Fcopy_keymap): Handle embedded parents.
9257 (Fcommand_remapping, define_as_prefix): Simplify.
9258 (Fkey_binding): Simplify.
9259 (syms_of_keymap): Move minibuffer-local-completion-map,
9260 minibuffer-local-filename-completion-map,
9261 minibuffer-local-must-match-map, and
9262 minibuffer-local-filename-must-match-map to Elisp.
9263 (syms_of_keymap): Defsubr make-composed-keymap.
9264 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9265 (parse_menu_item): Trivial simplification.
9267 2011-07-01 Glenn Morris <rgm@gnu.org>
9269 * Makefile.in (SETTINGS_LIBS): Fix typo.
9271 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9273 * coding.c (Fencode_coding_string): Record the last coding system
9274 used, as the function doc string says (bug#8738).
9276 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9278 * xsettings.c (store_monospaced_changed): Take new font as arg and
9279 check for change against current_mono_font.
9280 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9281 (emacs_settings_constructor, emacs_settings_get_property)
9282 (emacs_settings_set_property, emacs_settings_class_init)
9283 (emacs_settings_init, gsettings_obj): Remove.
9284 (something_changedCB): New function for HAVE_GSETTINGS.
9285 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9286 with value as argument.
9287 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9288 g_settings_new (Bug#8967). Do not create gsettings_obj.
9289 Remove calls to g_settings_bind. Connect something_changedCB to
9292 * xgselect.c: Add defined (HAVE_GSETTINGS).
9293 (xgselect_initialize): Ditto.
9295 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9296 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9299 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9301 * eval.c (struct backtrace): Simplify and port the data structure.
9302 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9303 signed bit field, as this assumption is not portable and it makes
9304 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9305 "char debug_on_exit : 1" as this is not portable either; instead,
9306 use the portable "unsigned int debug_on_exit : 1". Remove unused
9307 member evalargs. Remove obsolete comments about cc bombing out.
9309 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9311 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9312 Let HAVE_GSETTINGS override HAVE_GCONF.
9313 (store_monospaced_changed): New function.
9314 (EMACS_SETTINGS): A new type derived from GObject to handle
9315 GSettings notifications.
9316 (emacs_settings_constructor, emacs_settings_get_property)
9317 (emacs_settings_set_property, emacs_settings_class_init):
9319 (gsettings_client, gsettings_obj): New variables.
9320 (GSETTINGS_SCHEMA): New define.
9321 (something_changedCB): Call store_monospaced_changed.
9322 (init_gsettings): New function.
9323 (xsettings_initialize): Call init_gsettings.
9324 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9327 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9330 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9332 * window.c (resize_root_window, grow_mini_window)
9333 (shrink_mini_window): Rename Qresize_root_window to
9334 Qwindow_resize_root_window and Qresize_root_window_vertically to
9335 Qwindow_resize_root_window_vertically.
9337 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9339 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9341 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9343 * makefile.w32-in: Redesign dependencies so they reflect more
9344 clearly which files are directly included by each source file,
9345 and not through other includes.
9347 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9349 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9350 (sort_overlays, overlay_strings): When an overlay's clone number
9351 matches the window's clone number process the overlay even if
9352 the overlay's window property doesn't match the current window.
9354 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9355 (Fwindow_hchild): Rename to Fwindow_left_child.
9356 (Fwindow_next): Rename to Fwindow_next_sibling.
9357 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9358 (resize_window_check): Rename to window_resize_check.
9359 (resize_window_apply): Rename to window_resize_apply.
9360 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9361 (Fdelete_other_windows_internal, resize_frame_windows)
9362 (Fsplit_window_internal, Fdelete_window_internal)
9363 (grow_mini_window, shrink_mini_window)
9364 (Fresize_mini_window_internal): Fix callers accordingly.
9366 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9368 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9369 (emacs_fixed_set_min_size): Remove.
9370 (emacs_fixed_new): Take frame as argument.
9372 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9373 (_EmacsFixedPrivate): Remove minwidth/height.
9374 Add struct frame *f.
9375 (emacs_fixed_init): Initialize priv->f.
9376 (get_parent_class, emacs_fixed_set_min_size): Remove.
9377 (emacs_fixed_new): Set priv->f to argument.
9378 (emacs_fixed_get_preferred_width)
9379 (emacs_fixed_get_preferred_height): Use min_width/height from
9380 frames size_hint to set minimum and natural (Bug#8919).
9381 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9382 and use min_width/height from frames size_hint to set
9383 min_width/height (Bug#8919).
9385 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9386 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9389 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9391 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9392 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9395 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9397 * process.c (wait_reading_process_output): Bypass select if
9398 waiting for a cell while ignoring keyboard input, and input is
9399 pending. Suggested by Jan Djärv (Bug#8869).
9401 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9403 Use gnulib's dup2 module instead of rolling our own.
9404 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9406 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9408 * dispnew.c (scrolling_window): Before scrolling, turn off a
9409 mouse-highlight in the window being scrolled.
9411 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9413 Move DEFSYM to lisp.h and use everywhere.
9415 * character.h (DEFSYM): Move declaration...
9416 * lisp.h (DEFSYM): ...here.
9422 * w32select.c: Don't include character.h.
9424 * alloc.c (syms_of_alloc):
9425 * buffer.c (syms_of_buffer):
9426 * bytecode.c (syms_of_bytecode):
9427 * callint.c (syms_of_callint):
9428 * casefiddle.c (syms_of_casefiddle):
9429 * casetab.c (init_casetab_once):
9430 * category.c (init_category_once, syms_of_category):
9431 * ccl.c (syms_of_ccl):
9432 * cmds.c (syms_of_cmds):
9433 * composite.c (syms_of_composite):
9434 * dbusbind.c (syms_of_dbusbind):
9435 * dired.c (syms_of_dired):
9436 * dispnew.c (syms_of_display):
9437 * doc.c (syms_of_doc):
9438 * editfns.c (syms_of_editfns):
9439 * emacs.c (syms_of_emacs):
9440 * eval.c (syms_of_eval):
9441 * fileio.c (syms_of_fileio):
9442 * fns.c (syms_of_fns):
9443 * frame.c (syms_of_frame):
9444 * fringe.c (syms_of_fringe):
9445 * insdel.c (syms_of_insdel):
9446 * keymap.c (syms_of_keymap):
9447 * lread.c (init_obarray, syms_of_lread):
9448 * macros.c (syms_of_macros):
9449 * msdos.c (syms_of_msdos):
9450 * print.c (syms_of_print):
9451 * process.c (syms_of_process):
9452 * search.c (syms_of_search):
9453 * sound.c (syms_of_sound):
9454 * syntax.c (init_syntax_once, syms_of_syntax):
9455 * terminal.c (syms_of_terminal):
9456 * textprop.c (syms_of_textprop):
9457 * undo.c (syms_of_undo):
9458 * w32.c (globals_of_w32):
9459 * window.c (syms_of_window):
9460 * xdisp.c (syms_of_xdisp):
9461 * xfaces.c (syms_of_xfaces):
9462 * xfns.c (syms_of_xfns):
9463 * xmenu.c (syms_of_xmenu):
9464 * xsettings.c (syms_of_xsettings):
9465 * xterm.c (syms_of_xterm): Use DEFSYM.
9467 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9469 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9471 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9473 Integer and buffer overflow fixes (Bug#8873).
9475 * print.c (printchar, strout): Check for string overflow.
9476 (PRINTPREPARE, printchar, strout):
9477 Don't set size unless allocation succeeds.
9479 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9480 for sizes. Check for string overflow more accurately.
9481 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9483 * macros.c: Integer and buffer overflow fixes.
9484 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9485 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9486 Use ptrdiff_t, not int, for sizes.
9487 Don't increment bufsize until after realloc succeeds.
9488 Check for size-calculation overflow.
9489 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9491 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9493 * lread.c: Integer overflow fixes.
9494 (read_integer): Radix is now EMACS_INT, not int,
9495 to improve quality of diagnostics for out-of-range radices.
9496 Calculate buffer size correctly for out-of-range radices.
9497 (read1): Check for integer overflow in radices, and in
9498 read-circle numbers.
9499 (read_escape): Avoid int overflow.
9500 (Fload, openp, read_buffer_size, read1)
9501 (substitute_object_recurse, read_vector, read_list, map_obarray):
9502 Use ptrdiff_t, not int, for sizes.
9503 (read1): Use EMACS_INT, not int, for sizes.
9504 Check for size overflow.
9506 * image.c (cache_image): Check for size arithmetic overflow.
9508 * lread.c: Integer overflow issues.
9509 (saved_doc_string_size, saved_doc_string_length)
9510 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9511 Now ptrdiff_t, not int.
9512 (read1): Don't assume doc string length fits in int. Check for
9513 out-of-range doc string lengths.
9514 (read_list): Don't assume file position fits in int.
9515 (read_escape): Check for hex character overflow.
9517 2011-06-22 Leo Liu <sdl.web@gmail.com>
9519 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9520 Move to minibuffer.el.
9522 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9524 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9525 The following patches are for when GLYPH_DEBUG && !XASSERT.
9526 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9527 * dispnew.c (flush_stdout):
9528 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9529 Mark as externally visible.
9530 * dispnew.c (check_window_matrix_pointers): Now static.
9531 * dispnew.c (window_to_frame_vpos):
9532 * xfns.c (unwind_create_frame):
9533 * xterm.c (x_check_font): Remove unused local.
9534 * scroll.c (CHECK_BOUNDS):
9535 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9536 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9537 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9538 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9539 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9541 (debug_method_add): Use va_list and vsprintf rather than relying
9542 on undefined behavior with wrong number of arguments.
9543 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9544 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9545 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9546 since we're not interested in debugging glyphs with old libraries.
9547 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9548 GCC 4.6.0's static checking.
9550 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9552 Integer overflow and signedness fixes (Bug#8873).
9553 A few related buffer overrun fixes, too.
9555 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9557 * dispextern.h (struct face.stipple):
9558 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9559 (x_bitmap_mask, x_allocate_bitmap_record)
9560 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9561 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9562 (x_create_bitmap_from_xpm_data):
9563 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9564 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9566 * xfaces.c (load_pixmap):
9567 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9568 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9569 (.bitmaps_last, struct x_output.icon_bitmap):
9570 Use ptrdiff_t, not int, for bitmap indexes.
9571 (x_allocate_bitmap_record): Check for size overflow.
9572 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9574 Use ptrdiff_t, not int, for overlay counts.
9575 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9576 * editfns.c (overlays_around, get_pos_property):
9577 * textprop.c (get_char_property_and_overlay):
9578 * xdisp.c (next_overlay_change, note_mouse_highlight):
9579 * xfaces.c (face_at_buffer_position):
9580 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9581 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9582 (Fnext_overlay_change, Fprevious_overlay_change)
9583 (mouse_face_overlay_overlaps, Foverlays_in):
9584 Use ptrdiff_t, not int, for sizes.
9585 (overlays_at, overlays_in): Check for size-calculation overflow.
9587 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9589 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9590 (x_session_initialize): Do not assume string length fits in int.
9592 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9593 This is unlikely, but can occur if DPI is outlandish.
9595 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9596 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9598 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9599 * xrdb.c (magic_file_p, search_magic_path):
9600 Omit last arg SUFFIX; it was always 0. All callers changed.
9601 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9603 * xfont.c (xfont_match): Avoid need for strlen.
9605 * xfns.c: Don't assume strlen fits in int.
9606 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9608 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9609 not unsigned long, as we prefer signed integers. All callers changed.
9610 Detect integer overflow in repeat count.
9611 (message_dolog): Don't assume print length fits in 39 bytes.
9612 (display_mode_element): Don't assume strlen fits in int.
9614 * termcap.c: Don't assume sizes fit in int and never overflow.
9615 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9616 (gobble_line): Check for size-calculation overflow.
9618 * minibuf.c (Fread_buffer):
9619 * lread.c (intern, intern_c_string):
9620 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9621 Don't assume string length fits in int.
9623 * keyboard.c (parse_tool_bar_item):
9624 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9626 * font.c: Don't assume string length fits in int.
9627 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9628 Use ptrdiff_t, not int.
9629 (font_intern_prop): Don't assume string length fits in int.
9630 Don't assume integer property fits in fixnum.
9631 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9633 * filelock.c: Fix some buffer overrun and integer overflow issues.
9634 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9635 Reformulate so as not to need the command string.
9636 Invoke gzip -cd rather than gunzip, as it's more portable.
9637 (lock_info_type, lock_file_1, lock_file):
9638 Don't assume pid_t and time_t fit in unsigned long.
9639 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9640 (current_lock_owner): Prefer signed type for sizes.
9641 Use memcpy, not strncpy, where memcpy is what is really wanted.
9642 Don't assume (via atoi) that time_t and pid_t fit in int.
9643 Check for time_t and/or pid_t out of range, e.g., via a network share.
9644 Don't alloca where an auto var works fine.
9646 * fileio.c: Fix some integer overflow issues.
9647 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9648 Don't assume string length fits in int.
9649 (directory_file_name): Don't assume string length fits in long.
9650 (make_temp_name): Don't assume pid fits in int, or that its print
9651 length is less than 20.
9653 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9655 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9657 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9659 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9660 We prefer signed integers, even for size calculations.
9662 * emacs.c: Don't assume string length fits in 'int'.
9663 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9664 (main): Don't invoke strlen when not needed.
9666 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9667 (XD_DEBUG_MESSAGE): Don't waste a byte.
9669 * callproc.c (getenv_internal_1, getenv_internal)
9671 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9673 * lread.c (invalid_syntax): Omit length argument.
9674 All uses changed. This doesn't fix a bug, but it simplifies the
9675 code away from its former Hollerith-constant appearance, and it's
9676 one less 'int' to worry about when looking at integer-overflow issues.
9677 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9679 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9680 This didn't break anything, but it didn't help either.
9681 It's confusing to put a bogus integer in a place where the actual
9682 value does not matter.
9683 (LIST_END_P): Remove unused macro and its bogus comment.
9684 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9686 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9687 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9689 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9690 We prefer signed types, and the value cannot exceed the EMACS_INT
9691 range anyway (because otherwise the length would not be representable).
9692 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9693 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9694 This avoids a GCC warning when WIDE_EMACS_INT.
9696 * indent.c (sane_tab_width): New function.
9697 (current_column, scan_for_column, Findent_to, position_indentation)
9698 (compute_motion): Use it. This is just for clarity.
9699 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9701 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9703 * lisp.h (lint_assume): New macro.
9704 * composite.c (composition_gstring_put_cache):
9705 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9707 * editfns.c, insdel.c:
9708 Omit unnecessary forward decls, to simplify future changes.
9710 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9712 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9714 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9715 Use much-faster test for byte-length change.
9716 Don't assume string byte-length fits in 'int'.
9717 Check that character arg fits in 'int'.
9718 (mapcar1): Declare byte as byte, for clarity.
9720 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9722 * fns.c (concat): Catch string overflow earlier.
9723 Do not rely on integer wraparound.
9725 * dispextern.h (struct it.overlay_strings_charpos)
9726 (struct it.selective): Now EMACS_INT, not int.
9727 * xdisp.c (forward_to_next_line_start)
9728 (back_to_previous_visible_line_start)
9729 (reseat_at_next_visible_line_start, next_element_from_buffer):
9730 Don't arbitrarily truncate the value of 'selective' to int.
9732 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9734 * composite.c: Don't truncate sizes to 'int'.
9735 (composition_gstring_p, composition_reseat_it)
9736 (composition_adjust_point): Use EMACS_INT, not int.
9737 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9738 not EMACS_UINT, for indexes.
9740 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9742 * buffer.c: Include <verify.h>.
9743 (struct sortvec.priority, struct sortstr.priority):
9744 Now EMACS_INT, not int.
9745 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9746 (struct sortstr.size, record_overlay_string)
9747 (struct sortstrlist.size, struct sortlist.used):
9748 Don't truncate size to int.
9749 (record_overlay_string): Check for size-calculation overflow.
9750 (init_buffer_once): Check at compile-time, not run-time.
9752 2011-06-22 Jim Meyering <meyering@redhat.com>
9754 Don't leak an XBM-image-sized buffer
9755 * image.c (xbm_load): Free the image buffer after using it.
9757 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9760 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9761 that Sun C diagnosed.
9762 * fns.c (secure_hash): Fix pointer signedness issue.
9763 * intervals.c (static_offset_intervals): New function.
9764 (offset_intervals): Use it.
9766 2011-06-21 Leo Liu <sdl.web@gmail.com>
9769 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9772 * fns.c (secure_hash): Rename from crypto_hash_function and change
9773 the first arg to accept symbols.
9774 (Fsecure_hash): New primitive.
9775 (syms_of_fns): New symbols.
9777 2011-06-20 Deniz Dogan <deniz@dogan.se>
9779 * process.c (Fset_process_buffer): Clarify return value in
9782 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9784 * dispnew.c (add_window_display_history): Use BVAR.
9786 * xdisp.c (debug_method_add): Use BVAR.
9787 (check_window_end, dump_glyph_matrix, dump_glyph)
9788 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9790 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9793 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9794 check till after the cache is created in init_frame_faces.
9796 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9798 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9800 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9802 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9803 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9804 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9806 Improve buffer-overflow checking (Bug#8873).
9807 * fileio.c (Finsert_file_contents):
9808 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9809 Remove the old (too-loose) buffer overflow checks.
9810 They weren't needed, since make_gap checks for buffer overflow.
9811 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9812 The old code merely checked for Emacs fixnum overflow, and relied
9813 on undefined (wraparound) behavior. The new code avoids undefined
9814 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9816 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9817 Tune. Don't use wider integers than needed. Don't use alloca.
9818 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9820 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9822 * insdel.c, lisp.h (buffer_overflow): New function.
9823 (insert_from_buffer_1, replace_range, replace_range_2):
9824 * insdel.c (make_gap_larger):
9825 * editfns.c (Finsert_char):
9826 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9828 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9830 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9832 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9834 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9835 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9837 * fileio.c: Don't assume EMACS_INT fits in off_t.
9838 (emacs_lseek): New static function.
9839 (Finsert_file_contents, Fwrite_region): Use it.
9840 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9842 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9844 * fns.c: Don't overflow int when computing a list length.
9845 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9846 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9847 truncation on 64-bit hosts. Check for QUIT every
9848 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9849 faster and is responsive enough.
9850 (Flength): Report an error instead of overflowing an integer.
9851 (Fsafe_length): Return a float if the value is not representable
9852 as a fixnum. This shouldn't happen except in contrived situations.
9853 (Fnthcdr, Fsort): Don't assume list length fits in int.
9854 (Fcopy_sequence): Don't assume vector length fits in int.
9856 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9857 (header_size, word_size): New constants.
9858 (allocate_vectorlike): Don't check size overflow here.
9859 (allocate_vector): Check it here instead, since this is the only
9860 caller of allocate_vectorlike that could cause overflow.
9861 Check that the new vector's length is representable as a fixnum.
9863 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9864 The previous code was bogus. For example, next_almost_prime (32)
9865 returned 39, which is undesirable as it is a multiple of 3; and
9866 next_almost_prime (24) returned 25, which is a multiple of 5 so
9867 why was the code bothering to check for multiples of 7?
9869 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9871 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9873 Variadic C functions now count arguments with ptrdiff_t.
9874 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9875 Back then I didn't know that the Emacs coding style prefers signed int.
9876 Also, in the meantime I found a few more instances where arguments
9877 were being counted with int, which may truncate counts on 64-bit
9878 machines, or EMACS_INT, which may be unnecessarily wide.
9879 * lisp.h (struct Lisp_Subr.function.aMANY)
9880 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9881 Arg counts are now ptrdiff_t, not size_t.
9882 All variadic functions and their callers changed accordingly.
9883 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9884 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9885 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9886 * callint.c (Fcall_interactively): Check arg count for overflow,
9887 to avoid potential buffer overrun. Use signed char, not 'int',
9888 for 'varies' array, so that we needn't bother to check its size
9889 calculation for overflow.
9890 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9891 * eval.c (apply_lambda):
9892 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9893 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9894 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9896 * callint.c (Fcall_interactively): Don't use index var as event count.
9898 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9899 * mem-limits.h (SIZE): Remove; no longer used.
9901 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9903 Remove unnecessary casts.
9904 * xterm.c (x_term_init):
9905 * xfns.c (x_set_border_pixel):
9906 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9907 These aren't needed now that we assume ANSI C.
9909 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9910 It's more likely to cause problems (due to unsigned overflow)
9913 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9915 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9917 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9919 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9921 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9923 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9925 GLYPH_CODE_FACE returns EMACS_INT, not int.
9926 * dispextern.h (merge_faces):
9927 * xfaces.c (merge_faces):
9928 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9929 Don't assume EMACS_INT fits in int.
9931 * character.h (CHAR_VALID_P): Remove unused parameter.
9932 * fontset.c, lisp.h, xdisp.c: All uses changed.
9934 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9936 * fns.c (concat): Minor tuning based on overflow analysis.
9937 This doesn't fix any bugs. Use int to hold character, instead
9938 of constantly refetching from Emacs object. Use XFASTINT, not
9939 XINT, for value known to be a character. Don't bother comparing
9940 a single byte to 0400, as it's always less.
9942 * floatfns.c (Fexpt):
9943 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9945 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9948 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9950 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9951 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9952 incorrectly succeed when S was a string, because 4294967386 was
9953 truncated before it was used.
9955 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9956 Otherwise, an out-of-range integer could cause undefined behavior
9959 * composite.c: Use int, not EMACS_INT, for characters.
9960 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9961 EMACS_INT, for values that are known to be in character range.
9962 This doesn't fix any bugs but is the usual style inside Emacs and
9963 may generate better code on 32-bit machines.
9965 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9966 This is for reasons similar to the recent CHAR_STRING fix.
9967 * charset.c (Fencode_char): Check that character arg is actually
9968 a character. Pass an int to ENCODE_CHAR.
9969 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9970 wider than 'int', as a compile-time check to prevent future regressions
9973 * character.c (char_string): Remove unnecessary casts.
9975 Make sure a 64-bit char is never passed to CHAR_STRING.
9976 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9977 by silently ignoring the top 32 bits, allowing some values
9978 that were far too large to be valid characters.
9979 * character.h: Include <verify.h>.
9980 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9981 arguments are no wider than unsigned, as a compile-time check
9982 to prevent future regressions in this area.
9984 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9985 (Fsubst_char_in_region):
9987 * xdisp.c (decode_mode_spec_coding):
9988 Adjust to CHAR_STRING's new requirement.
9989 * editfns.c (Finsert_char, Fsubst_char_in_region):
9990 * fns.c (concat): Check that character args are actually
9991 characters. Without this test, these functions did the wrong
9992 thing with wildly out-of-range values on 64-bit hosts.
9994 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9995 These casts should not be needed on 32-bit hosts, either.
9996 * keyboard.c (read_char):
9997 * lread.c (Fload): Remove casts to unsigned.
9999 * lisp.h (UNSIGNED_CMP): New macro.
10000 This fixes comparison bugs on 64-bit hosts.
10001 (ASCII_CHAR_P): Use it.
10002 * casefiddle.c (casify_object):
10003 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10004 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10005 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10006 * dispextern.h (FACE_FROM_ID):
10007 * keyboard.c (read_char): Use UNSIGNED_CMP.
10009 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10010 not to EMACS_INT, to avoid GCC warning.
10012 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10014 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10015 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10016 isn't needed on 32-bit machines.
10018 * buffer.c (Fgenerate_new_buffer_name):
10019 Use EMACS_INT for count, not int.
10020 (advance_to_char_boundary): Return EMACS_INT, not int.
10022 * data.c (Qcompiled_function): Now static.
10024 * window.c (window_body_lines): Now static.
10026 * image.c (gif_load): Rename local to avoid shadowing.
10028 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10029 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10030 * alloc.c (make_save_value): Integer argument is now of type
10031 ptrdiff_t, not int.
10032 (mark_object): Use ptrdiff_t, not int.
10033 * lisp.h (pD): New macro.
10034 * print.c (print_object): Use it.
10036 * alloc.c: Use EMACS_INT, not int, to count objects.
10037 (total_conses, total_markers, total_symbols, total_vector_size)
10038 (total_free_conses, total_free_markers, total_free_symbols)
10039 (total_free_floats, total_floats, total_free_intervals)
10040 (total_intervals, total_strings, total_free_strings):
10041 Now EMACS_INT, not int. All uses changed.
10042 (Fgarbage_collect): Compute overall total using a double, so that
10043 integer overflow is less likely to be a problem. Check for overflow
10044 when converting back to an integer.
10045 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10046 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10047 These were 'int' variables that could overflow on 64-bit hosts;
10048 they were never used, so remove them instead of repairing them.
10049 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10050 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10051 Previously, this ceilinged at INT_MAX, but that doesn't work on
10053 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10055 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10056 (allocate_vectorlike): Check for ptrdiff_t overflow.
10057 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10058 when a (possibly-narrower) signed value would do just as well.
10059 We prefer using signed arithmetic, to avoid comparison confusion.
10061 * alloc.c: Catch some string size overflows that we were missing.
10062 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10063 for convenience in STRING_BYTES_MAX.
10064 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10065 The definition here is exact; the one in lisp.h was approximate.
10066 (allocate_string_data): Check for string overflow. This catches
10067 some instances we weren't catching before. Also, it catches
10068 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10069 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10070 and ptrdiff_t and EMACS_INT are both 64 bits.
10072 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10073 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10074 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10076 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10078 * alloc.c (Fmake_string): Check for out-of-range init.
10080 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10082 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10084 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10086 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10087 xg_get_default_scrollbar_width.
10089 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10090 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10091 (style_changed_cb): Call update_theme_scrollbar_width and call
10092 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10093 all frames (Bug#8505).
10094 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10095 Call gtk_window_set_resizable if HAVE_GTK3.
10096 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10097 and height if HAVE_GTK3 (Bug#8505).
10098 (scroll_bar_width_for_theme): New variable.
10099 (update_theme_scrollbar_width): New function.
10100 (xg_get_default_scrollbar_width): Move code to
10101 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10102 (xg_initialize): Call update_theme_scrollbar_width.
10104 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10106 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10108 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10110 * frame.c (make_frame): Call other_buffer_safely instead of
10113 * window.c (temp_output_buffer_show): Call display_buffer with
10114 second argument Vtemp_buffer_show_specifiers and reset latter
10115 immediately after the call.
10116 (Vtemp_buffer_show_specifiers): New variable.
10117 (auto_window_vscroll_p, next_screen_context_lines)
10118 (Vscroll_preserve_screen_position): Remove leading asterisks from
10121 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10123 Fix minor problems found by GCC 4.6.0 static checking.
10124 * buffer.c (Qclone_number): Remove for now, as it's unused.
10125 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10126 (record_buffer): Remove unused local.
10127 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10128 (set_frame_buffer_list): Remove; unused.
10129 * frame.h (other_visible_frames): Remove decl.
10130 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10131 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10132 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10134 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10135 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10136 Define only if HAVE_GPM.
10137 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10138 (update_hints_inhibit): Remove; never set. All uses removed.
10139 * widgetprv.h (emacsFrameClassRec): Remove decl.
10140 * window.c (delete_deletable_window): Now returns void, since it
10141 wasn't returning anything.
10142 (compare_window_configurations): Remove unused locals.
10143 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10144 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10145 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10146 the same widths as pointers. This follows up on the 2011-05-06 patch.
10147 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10148 * xterm.h: Likewise.
10149 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10151 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10153 * makefile.w32-in: Update dependencies.
10154 (LISP_H): Add lib/intprops.h.
10156 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10158 * image.c (gif_load): Add animation frame delay to the metadata.
10159 (syms_of_image): Use DEFSYM. New symbol `delay'.
10161 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10163 * window.c (delete_deletable_window): Re-add.
10164 (Fset_window_configuration): Rewrite to handle dead buffers and
10165 consequently deletable windows.
10166 (window_tree, Fwindow_tree): Remove. Supply functionality in
10168 (compare_window_configurations): Simplify code.
10170 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10172 * image.c (imagemagick_load_image): Fix type mismatch.
10173 (Fimagemagick_types): Likewise.
10175 * window.h (replace_buffer_in_windows): Declare.
10177 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10179 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10180 Qclone_number. Remove external declaration of Qdelete_window.
10181 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10183 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10184 Run Qbuffer_list_update_hook if allowed.
10185 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10186 buffer list implementation.
10187 (other_buffer_safely): New function.
10188 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10189 calls to replace_buffer_in_windows and
10190 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10192 (record_buffer): Inhibit quitting and rewrite using quittable
10193 functions. Run Qbuffer_list_update_hook if allowed.
10194 (Frecord_buffer, Funrecord_buffer): New functions.
10195 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10196 Move switch-to-buffer to window.el.
10197 (bury-buffer): Move to window.el.
10198 (Vbuffer_list_update_hook): New variable.
10200 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10203 * window.h (resize_frame_windows): Move up in code.
10204 (Fwindow_frame): Remove EXFUN.
10205 (replace_buffer_in_all_windows): Remove prototype.
10206 (replace_buffer_in_windows_safely): Add prototype.
10208 * window.c: Declare Qdelete_window static again. Move down
10209 declaration of select_count.
10210 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10211 (Fother_window): Move to window.el.
10212 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10213 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10214 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10216 (replace_buffer_in_windows): Implement by calling
10217 Qreplace_buffer_in_windows.
10218 (replace_buffer_in_all_windows): Remove with some functionality
10219 moved into replace_buffer_in_windows_safely.
10220 (replace_buffer_in_windows_safely): New function.
10221 (select_window_norecord, select_frame_norecord): Move in front
10222 of run_window_configuration_change_hook. Remove now obsolete
10224 (Fset_window_buffer): Rewrite doc-string.
10225 Call Qrecord_window_buffer.
10226 (keys_of_window): Move binding for other-window to window.el.
10228 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10230 * dispextern.h (struct image): Replace data member, whose int_val
10231 and ptr_val fields were not used by anything, with a single
10234 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10235 (gif_clear_image, gif_load, imagemagick_load_image)
10236 (gs_clear_image, gs_load): Callers changed.
10238 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10240 * buffer.h: Include <time.h>, for time_t.
10241 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10243 Fix minor problems found by static checking.
10245 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10247 Make identifiers static if they are not used in other modules.
10248 * data.c (Qcompiled_function, Qframe, Qvector):
10249 * image.c (QimageMagick, Qsvg):
10250 * minibuf.c (Qmetadata):
10251 * window.c (resize_window_check, resize_root_window): Now static.
10252 * window.h (resize_window_check, resize_root_window): Remove decls.
10254 * window.c (window_deletion_count, delete_deletable_window):
10256 (window_body_lines): Now static.
10257 (Fdelete_other_windows_internal): Mark vars as initialized.
10258 Make sure 'resize_failed' is initialized.
10259 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10260 (resize_window_apply): Remove unused local.
10261 * window.h (delete_deletable_window): Remove decl.
10263 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10264 (imagemagick_load_image): Fix pointer signedness problem by changing
10265 last arg from unsigned char * to char *. All uses changed.
10266 Also, fix a local for similar reasons.
10267 Remove unused locals. Remove locals to avoid shadowing.
10268 (fn_rsvg_handle_free): Remove; unused.
10269 (svg_load, svg_load_image): Fix pointer signedness problem.
10270 (imagemagick_load_image): Don't use garbage pointer image_wand.
10272 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10274 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10276 * image.c (gif_load): Fix omitted cast error introduced by
10279 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10281 * window.h (resize_proportionally, orig_total_lines)
10282 (orig_top_line): Remove from window structure.
10283 (set_window_height, set_window_width, change_window_heights)
10284 (Fdelete_window): Remove prototypes.
10285 (resize_frame_windows): Remove duplicate declaration.
10287 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10289 * window.h (resize_frame_windows, resize_window_check)
10290 (delete_deletable_window, resize_root_window)
10291 (resize_frame_windows): Declare prototypes.
10293 * window.c (resize_window_apply): Make definition be "static" to
10294 match the prototype.
10296 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10298 * window.c: Remove declarations of Qwindow_size_fixed,
10299 window_min_size_1, window_min_size_2, window_min_size,
10300 size_window, window_fixed_size_p, enlarge_window, delete_window.
10301 Remove static from declaration of Qdelete_window, it's
10302 temporarily needed by Fbury_buffer.
10303 (replace_window): Don't assign orig_top_line and
10305 (Fdelete_window, delete_window): Remove. Window deletion is
10306 handled by window.el.
10307 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10308 Replace Fdelete_window calls with calls to Qdelete_window.
10309 (Fdelete_other_windows): Remove. Deleting other windows is
10310 handled by window.el.
10311 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10312 handled in window.el.
10313 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10314 Window minimum sizes are handled in window.el.
10315 (shrink_windows, size_window, set_window_height)
10316 (set_window_width, change_window_heights, window_height)
10317 (window_width, CURBEG, CURSIZE, enlarge_window)
10318 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10319 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10320 handled in window.el.
10321 (make_dummy_parent): Rename to make_parent_window and give it a
10322 second argument horflag.
10323 (make_window): Don't set resize_proportionally any more.
10324 (Fsplit_window): Remove. Windows are split in window.el.
10325 (save_restore_action, save_restore_orig_size)
10326 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10327 Resize mini windows in window.el.
10328 (grow_mini_window, shrink_mini_window): Implement by calling
10329 Qresize_root_window_vertically, resize_window_check and
10330 resize_window_apply.
10331 (saved_window, Fset_window_configuration, save_window_save):
10332 Do not handle orig_top_line, orig_total_lines, and
10333 resize_proportionally.
10334 (window_min_height, window_min_width): Move to window.el.
10335 (keys_of_window): Move bindings for delete-other-windows,
10336 split-window, delete-window and enlarge-window to window.el.
10338 * buffer.c: Temporarily extern Qdelete_window.
10339 (Fbury_buffer): Temporarily call Qdelete_window instead of
10340 Fdelete_window (Fbury_buffer will move to window.el soon).
10342 * frame.c (set_menu_bar_lines_1): Remove code handling
10343 orig_top_line and orig_total_lines.
10345 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10346 set_window_height but set heights directly.
10347 (change_frame_size_1): Use resize_frame_windows.
10349 * xdisp.c (init_xdisp): Don't use set_window_height but set
10352 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10353 Use resize_frame_windows instead of change_window_heights and run
10354 run_window_configuration_change_hook.
10356 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10357 instead of change_window_heights and run
10358 run_window_configuration_change_hook.
10360 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10362 * window.c (replace_window): Rename second argument REPLACEMENT to
10363 NEW. New third argument SETFLAG. Rewrite.
10364 (delete_window, make_dummy_parent): Call replace_window with
10366 (window_list_1): Move down in code.
10367 (run_window_configuration_change_hook): Move set_buffer part
10368 before select_frame_norecord part in order to unwind correctly.
10369 Rename count1 to count.
10370 (recombine_windows, delete_deletable_window, resize_root_window)
10371 (Fdelete_other_windows_internal)
10372 (Frun_window_configuration_change_hook, make_parent_window)
10373 (resize_window_check, resize_window_apply, Fresize_window_apply)
10374 (resize_frame_windows, Fsplit_window_internal)
10375 (Fdelete_window_internal, Fresize_mini_window_internal):
10377 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10379 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10381 * window.h (window): Add some new members to window structure -
10382 normal_lines, normal_cols, new_total, new_normal, clone_number,
10383 splits, nest, prev_buffers, next_buffers.
10384 (WINDOW_TOTAL_SIZE): Move here from window.c.
10385 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10387 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10389 (make_dummy_parent): Set new members of windows structure.
10390 (make_window): Move down in code. Handle new members of window
10392 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10393 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10394 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10395 (Fset_window_prev_buffers, Fwindow_next_buffers)
10396 (Fset_window_next_buffers, Fset_window_clone_number):
10398 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10399 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10401 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10402 Argument WINDOW can be now internal window too.
10403 (Fwindow_use_time): Move up in code.
10404 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10405 Rewrite doc-string.
10406 (Fset_window_configuration, saved_window)
10407 (Fcurrent_window_configuration, save_window_save): Handle new
10408 members of window structure.
10409 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10410 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10411 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10412 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10413 Qget_mru_window, Qresize_root_window,
10414 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10415 Qauto_buffer_name; staticpro them.
10417 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10419 * window.c (Fwindow_total_size, Fwindow_left_column)
10420 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10421 (Fwindow_list_1): New functions.
10422 (window_box_text_cols): Replace with window_body_cols.
10423 (Fwindow_width, Fscroll_left, Fscroll_right):
10424 Use window_body_cols instead of window_box_text_cols.
10425 (delete_window, Fset_window_configuration):
10426 Call delete_all_subwindows with window as argument.
10427 (delete_all_subwindows): Take a window as argument and not a
10428 structure. Rewrite.
10429 (window_loop): Remove handling of GET_LRU_WINDOW and
10430 GET_LARGEST_WINDOW.
10431 (Fget_lru_window, Fget_largest_window): Move to window.el.
10433 * window.h: Extern window_body_cols instead of
10434 window_box_text_cols. delete_all_subwindows now takes a
10435 Lisp_Object as argument.
10437 * indent.c (compute_motion, Fcompute_motion):
10438 Use window_body_cols instead of window_box_text_cols.
10440 * frame.c (delete_frame): Call delete_all_subwindows with root
10441 window as argument.
10443 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10445 * fns.c (Fputhash): Document return value.
10447 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10449 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10451 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10453 Cons<->int and similar integer overflow fixes (Bug#8794).
10455 Check for overflow when converting integer to cons and back.
10456 * charset.c (Fdefine_charset_internal, Fdecode_char):
10457 Use cons_to_unsigned to catch overflow.
10458 (Fencode_char): Use INTEGER_TO_CONS.
10459 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10460 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10461 * data.c (long_to_cons, cons_to_long): Remove.
10462 (cons_to_unsigned, cons_to_signed): New functions.
10463 These signal an error for invalid or out-of-range values.
10464 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10465 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10466 * font.c (Ffont_variation_glyphs):
10467 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10468 * lisp.h: Include <intprops.h>.
10469 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10470 (cons_to_signed, cons_to_unsigned): New decls.
10471 (long_to_cons, cons_to_long): Remove decls.
10472 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10473 (Fprimitive_undo): Use CONS_TO_INTEGER.
10474 * xfns.c (Fx_window_property): Likewise.
10475 * xselect.c: Include <limits.h>.
10476 (x_own_selection, selection_data_to_lisp_data):
10477 Use INTEGER_TO_CONS.
10478 (x_handle_selection_request, x_handle_selection_clear)
10479 (x_get_foreign_selection, Fx_disown_selection_internal)
10480 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10481 (lisp_data_to_selection_data): Use cons_to_unsigned.
10482 (x_fill_property_data): Use cons_to_signed.
10483 Report values out of range.
10485 Check for buffer and string overflow more precisely.
10486 * buffer.h (BUF_BYTES_MAX): New macro.
10487 * lisp.h (STRING_BYTES_MAX): New macro.
10488 * alloc.c (Fmake_string):
10489 * character.c (string_escape_byte8):
10490 * coding.c (coding_alloc_by_realloc):
10491 * doprnt.c (doprnt):
10492 * editfns.c (Fformat):
10494 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10495 since they may not be the same number.
10496 * editfns.c (Finsert_char):
10497 * fileio.c (Finsert_file_contents):
10498 Likewise for BUF_BYTES_MAX.
10500 * image.c: Use ptrdiff_t, not int, for sizes.
10501 (slurp_file): Switch from int to ptrdiff_t.
10503 (slurp_file): Check that file size fits in both size_t (for
10504 malloc) and ptrdiff_t (for sanity and safety).
10506 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10507 if b->modtime has its maximal value.
10509 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10511 Don't assume time_t can fit into int.
10512 * buffer.h (struct buffer.modtime): Now time_t, not int.
10513 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10514 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10516 Minor fixes for signed vs unsigned integers.
10517 * character.h (MAYBE_UNIFY_CHAR):
10518 * charset.c (maybe_unify_char):
10519 * keyboard.c (read_char, reorder_modifiers):
10520 XINT -> XFASTINT, since the integer must be nonnegative.
10521 * ftfont.c (ftfont_spec_pattern):
10522 * keymap.c (access_keymap, silly_event_symbol_error):
10523 XUINT -> XFASTINT, since the integer must be nonnegative.
10524 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10525 since it makes no difference and we prefer signed.
10526 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10527 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10530 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10532 * window.h (Fwindow_frame): Declare.
10534 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10536 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10537 (SPARE_MEMORY): Always define.
10538 (LARGE_REQUEST): Remove.
10539 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10541 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10543 * lisp.h: Move EXFUNS for Fframe_root_window,
10544 Fframe_first_window and Fset_frame_selected_window to window.h.
10546 * window.h: Move EXFUNS for Fframe_root_window,
10547 Fframe_first_window and Fset_frame_selected_window here from
10550 * frame.c (Fwindow_frame, Fframe_first_window)
10551 (Fframe_root_window, Fframe_selected_window)
10552 (Fset_frame_selected_window): Move to window.c.
10553 (Factive_minibuffer_window): Move to minibuf.c.
10554 (Fother_visible_frames_p): New function.
10556 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10558 * window.c (decode_window, decode_any_window): Move up in code.
10559 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10560 (inhibit_frame_unsplittable): Remove unused variable.
10561 (Fwindow_buffer): Move up and rewrite doc-string.
10562 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10563 (Fwindow_prev): New functions.
10564 (Fwindow_frame): Move here from frame.c. Accept any window as
10566 (Fframe_root_window, Fframe_first_window)
10567 (Fframe_selected_window): Move here from frame.c. Accept frame
10568 or arbitrary window as argument. Update doc-strings.
10569 (Fminibuffer_window): Move up in code.
10570 (Fwindow_minibuffer_p): Move up in code and simplify.
10571 (Fset_frame_selected_window): Move here from frame.c.
10573 (Fselected_window, select_window, Fselect_window): Move up in
10574 code. Minor doc-string fixes.
10576 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10578 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10579 Do not assume that spare memory exists; that assumption is valid
10580 only if SYSTEM_MALLOC.
10581 (LARGE_REQUEST): New macro, so that the issue of large requests
10582 is separated from the issue of spare memory.
10584 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10586 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10589 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10591 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10594 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10596 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10598 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10600 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10601 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10603 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10605 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10607 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10609 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10610 (x_clipboard_manager_save): Add return value.
10611 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10612 New error handlers.
10613 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10614 Obey Vx_select_enable_clipboard_manager. Catch errors in
10615 x_clipboard_manager_save (Bug#8779).
10616 (Vx_select_enable_clipboard_manager): New variable.
10617 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10619 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10621 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10623 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10625 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10626 in the current matrix if keep_current_p is non-zero.
10628 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10630 * bidi.c (bidi_level_of_next_char): Fix last change.
10632 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10634 Support bidi reordering of text covered by display properties.
10636 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10637 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10638 (bidi_cache_search, bidi_cache_iterator_state)
10639 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10640 (bidi_level_of_next_char, bidi_move_to_visually_next):
10641 Support character positions inside a run of characters covered by a
10643 (bidi_paragraph_init, bidi_resolve_explicit_1)
10644 (bidi_level_of_next_char): Call bidi_fetch_char and
10645 bidi_fetch_char_advance instead of FETCH_CHAR and
10646 FETCH_CHAR_ADVANCE.
10647 (bidi_init_it): Initialize new members.
10648 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10650 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10651 instead of using explicit *_CHAR codes.
10652 (bidi_resolve_explicit, bidi_resolve_weak):
10653 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10654 bidirectional text is supported only in multibyte buffers.
10655 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10656 it to initialize the frame_window_p member of struct bidi_it.
10657 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10658 (bidi_resolve_explicit, bidi_resolve_weak)
10659 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10660 bidi_it->nchars is non-positive.
10661 (bidi_level_of_next_char): Don't try to lookup the cache for the
10662 next/previous character if nothing is cached there yet, or if we
10663 were just reseat()'ed to a new position.
10665 * xdisp.c (set_cursor_from_row): Set start and stop points
10666 according to the row's direction when priming the loop that looks
10667 for the glyph on which to display cursor.
10668 (single_display_spec_intangible_p): Function deleted.
10669 (display_prop_intangible_p): Reimplement to call
10670 handle_display_spec instead of single_display_spec_intangible_p.
10671 Accept 3 additional arguments needed by handle_display_spec.
10672 This fixes incorrect cursor motion across display property with complex
10673 values: lists, `(when COND...)' forms, etc.
10674 (single_display_spec_string_p): Support property values that are
10675 lists with the argument STRING its top-level element.
10676 (display_prop_string_p): Fix the condition for processing a
10677 property that is a list to be consistent with handle_display_spec.
10678 (handle_display_spec): New function, refactored from the
10679 last portion of handle_display_prop.
10680 (compute_display_string_pos): Accept additional argument
10681 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10682 value of a `display' property is a "replacing spec".
10683 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10684 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10685 the display property, but just return a value indicating whether
10686 the display property will replace the characters it covers.
10687 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10688 frame_window_p members of struct bidi_it.
10689 (compute_display_string_pos, compute_display_string_end):
10691 (push_it): Accept second argument POSITION, where pop_it should
10692 jump to continue iteration.
10693 (reseat_1): Initialize bidi_it.disp_pos.
10695 * keyboard.c (adjust_point_for_property): Adjust the call to
10696 display_prop_intangible_p to its new signature.
10698 * dispextern.h (struct bidi_it): New member frame_window_p.
10699 (bidi_init_it): Update prototypes.
10700 (display_prop_intangible_p): Update prototype.
10701 (compute_display_string_pos, compute_display_string_end):
10702 Declare prototypes.
10703 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10706 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10708 Malloc failure behavior now depends on size of allocation.
10709 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10710 * lisp.h: Change signatures accordingly.
10711 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10712 All callers changed. (Bug#8762)
10714 * gnutls.c: Use Emacs's memory allocators.
10715 Without this change, the gnutls library would invoke malloc etc.
10716 directly, which causes problems on non-SYNC_INPUT hosts, and which
10717 runs afoul of improving memory_full behavior. (Bug#8761)
10718 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10719 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10720 xfree instead of the default malloc, realloc, free.
10721 (Fgnutls_boot): No need to check for memory allocation failure,
10722 since xmalloc does that for us.
10724 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10725 * category.c (hash_get_category_set):
10726 * ccl.c (ccl_driver):
10727 * charset.c (Fdefine_charset_internal):
10728 * charset.h (struct charset.hash_index):
10729 * composite.c (get_composition_id, gstring_lookup_cache)
10730 (composition_gstring_put_cache):
10731 * composite.h (struct composition.hash_index):
10732 * dispextern.h (struct image.hash):
10733 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10734 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10735 (hashfn_equal, hashfn_user_defined, make_hash_table)
10736 (maybe_resize_hash_table, hash_lookup, hash_put)
10737 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10738 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10739 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10740 * image.c (make_image, search_image_cache, lookup_image)
10741 (xpm_put_color_table_h):
10742 * lisp.h (struct Lisp_Hash_Table):
10743 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10744 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10745 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10746 * alloc.c (allocate_vectorlike):
10747 Check for overflow in vector size calculations.
10748 * ccl.c (ccl_driver):
10749 Check for overflow when converting EMACS_INT to int.
10750 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10751 need to be updated by these changes.
10752 * fns.c (make_hash_table, maybe_resize_hash_table):
10753 Check for integer overflow with large hash tables.
10754 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10755 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10756 (SXHASH_REDUCE): New macro.
10757 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10758 Use it instead of discarding useful hash info with large hash values.
10759 (sxhash_float): New function.
10760 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10761 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10762 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10763 Rewrite to use FIXNUM_BITS, as this simplifies things.
10764 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10765 Adjust signatures to match updated version of code.
10766 (consing_since_gc): Now EMACS_INT, since a single hash table can
10767 use more than INT_MAX bytes.
10769 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10771 Make it possible to build with GCC-4.6+ -O2 -flto.
10773 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10775 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10777 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10778 Call minibuffer-inactive-mode.
10780 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10782 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10783 Update dependencies.
10785 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10787 * data.c (init_data): Remove code for UTS, this system is not
10790 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10792 Don't force ./temacs to start in terminal mode.
10794 * frame.c (make_initial_frame): Initialize faces in all cases, not
10795 only when CANNOT_DUMP is defined.
10796 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10798 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10800 * dispnew.c (add_window_display_history): Use const for the string
10801 pointer. Remove declaration, not needed.
10803 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10805 Use 'inline', not 'INLINE'.
10806 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10807 * alloc.c, fontset.c (INLINE): Remove.
10808 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10809 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10810 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10811 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10812 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10814 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10816 Make it possible to run ./temacs.
10818 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10819 syms_of_callproc does the same thing. Remove test for
10820 "initialized", do it in the caller.
10821 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10823 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10825 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10826 (read_minibuf): Use get_minibuffer.
10827 (syms_of_minibuf): Use DEFSYM.
10828 (Qmetadata): New var.
10829 * data.c (Qbuffer): Don't make it static.
10830 (syms_of_data): Use DEFSYM.
10832 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10834 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10835 (CCL_CODE_MIN): New macro.
10837 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10839 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10841 * eval.c (Qdebug): Now static.
10842 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10843 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10844 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10846 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10848 * image.c: Various fixes to ImageMagick code comments.
10849 (Fimagemagick_types): Doc fix.
10851 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10853 Minor fixes prompted by GCC 4.6.0 warnings.
10855 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10857 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10858 (x_clipboard_manager_save_all): Move extern decl to ...
10859 * xterm.h: ... here, so that it can be checked for consistency.
10861 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10863 * xselect.c (x_clipboard_manager_save_frame)
10864 (x_clipboard_manager_save_all): New functions.
10865 (Fx_clipboard_manager_save): Lisp function deleted.
10867 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10868 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10870 * xterm.h: Update prototype.
10872 2011-05-28 William Xu <william.xwl@gmail.com>
10874 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10875 exiting (Bug#8239).
10877 2011-05-28 Jim Meyering <meyering@redhat.com>
10879 Avoid a sign-extension bug in crypto_hash_function.
10880 * fns.c (to_uchar): Define.
10881 (crypto_hash_function): Use it to convert some newly-signed
10882 variables to unsigned, to avoid sign-extension bugs. For example,
10883 without this change, (md5 "truc") would evaluate to
10884 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10885 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10886 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10888 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10890 Integer overflow fixes.
10892 * dbusbind.c: Serial number integer overflow fixes.
10893 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10894 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10895 to hold a serial number that is too large for a fixnum.
10896 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10897 Check for serial numbers out of range. Decode any serial number
10898 that was so large that it became a float. (Bug#8722)
10900 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10901 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10902 Use XFASTINT rather than XUINT when numbers are nonnegative.
10903 (xd_append_arg, Fdbus_method_return_internal):
10904 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10905 arguments, check that Lisp number is nonnegative, rather than
10906 silently wrapping negative numbers around. (Bug#8722)
10907 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10910 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10912 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10914 ccl: Add integer overflow checks.
10915 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10916 (IN_INT_RANGE): New macros.
10917 (ccl_driver): Use them to check for integer overflow when
10918 decoding a CCL program. Many of the new checks are whether XINT (x)
10919 fits in int; it doesn't always, on 64-bit hosts. The new version
10920 doesn't catch all possible integer overflows, but it's an
10921 improvement. (Bug#8719)
10923 * alloc.c (make_event_array): Use XINT, not XUINT.
10924 There's no need for unsigned here.
10926 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10927 This follows up to the 2011-05-06 change that substituted uintptr_t
10928 for EMACS_INT. This case wasn't caught back then.
10930 Rework Fformat to avoid integer overflow issues.
10931 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10932 now (part of C89). Include <verify.h>.
10933 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10934 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10935 (Fformat): Avoid the prepass trying to compute sizes; it was only
10936 approximate and thus did not catch overflow reliably. Instead, walk
10937 through the format just once, formatting and computing sizes as we go,
10938 checking for integer overflow at every step, and allocating a larger
10939 buffer as needed. Keep track separately whether the format is
10940 multibyte. Keep only the most-recently calculated precision, rather
10941 than them all. Record whether each argument has been converted to
10942 string. Use EMACS_INT, not int, for byte and char and arg counts.
10943 Support field widths and precisions larger than INT_MAX. Avoid
10944 sprintf's undefined behavior with conversion specifications such as %#d
10945 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10946 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10947 formatting out-of-range floating point numbers with int
10948 formats. (Bug#8668)
10950 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10952 * data.c: Avoid integer truncation in expressions involving floats.
10953 * data.c: Include <intprops.h>.
10954 (arith_driver): When there's an integer overflow in an expression
10955 involving floating point, convert the integers to floating point
10956 so that the resulting value does not suffer from catastrophic
10957 integer truncation. For example, on a 64-bit host (* 4
10958 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10959 Do not rely on undefined behavior after integer overflow.
10961 merge count_size_as_multibyte, parse_str_to_multibyte
10962 * character.c, character.h (count_size_as_multibyte):
10963 Rename from parse_str_to_multibyte; all uses changed.
10964 Check for integer overflow.
10965 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10966 since it's now a duplicate of the other. This is more of
10967 a character than a buffer op, so better that it's in character.c.
10968 * fns.c, print.c: Adjust to above changes.
10970 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10972 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10974 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10976 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10977 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10978 (x_clipboard_manager_save): Now static.
10979 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10981 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10982 (crypto_hash_function): Now static.
10983 Fix pointer signedness problems. Avoid unnecessary initializations.
10985 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10987 * termhooks.h (Vselection_alist): Make it terminal-local.
10989 * terminal.c (create_terminal): Initialize it.
10991 * xselect.c: Support for clipboard managers.
10992 (Vselection_alist): Move to termhooks.h as terminal-local var.
10993 (LOCAL_SELECTION): New macro.
10994 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10995 (symbol_to_x_atom): Remove gratuitous arg.
10996 (x_handle_selection_request, lisp_data_to_selection_data)
10997 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10998 (x_own_selection, x_get_local_selection, x_convert_selection):
10999 New arg, specifying work frame. Use terminal-local Vselection_alist.
11000 (some_frame_on_display): Delete unused function.
11001 (Fx_own_selection_internal, Fx_get_selection_internal)
11002 (Fx_disown_selection_internal, Fx_selection_owner_p)
11003 (Fx_selection_exists_p): New optional frame arg.
11004 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11005 (x_handle_selection_clear): Don't treat other terminals with the
11006 same keyboard specially. Use the terminal-local Vselection_alist.
11007 (x_clear_frame_selections): Use Frun_hook_with_args.
11009 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11011 * xterm.h: Add support for those atoms.
11013 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11015 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11016 (converted_selections, conversion_fail_tag): New global variables.
11017 (x_selection_request_lisp_error): Free the above.
11018 (x_get_local_selection): Remove unnecessary code.
11019 (x_reply_selection_request): Args changed; handle arbitrary array
11020 of converted selections stored in converted_selections.
11021 Separate the XChangeProperty and SelectionNotify steps.
11022 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11023 (x_convert_selection): New function.
11024 (x_handle_selection_event): Simplify.
11025 (x_get_foreign_selection): Don't ignore incoming requests while
11026 waiting for an answer; this will fail when we implement
11027 SAVE_TARGETS, and seems unnecessary anyway.
11028 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11029 (Vx_sent_selection_functions): Doc fix.
11031 2011-05-26 Leo Liu <sdl.web@gmail.com>
11033 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11035 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11037 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11039 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11040 for fringe update if it has periodic bitmap.
11041 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11042 and fringe_bitmap_periodic_p.
11044 * fringe.c (get_fringe_bitmap_data): New function.
11045 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11046 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11047 row. Mark glyph row for fringe update if periodicity changed.
11049 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11050 for fringe update unless it has periodic bitmap.
11052 2011-05-25 Kenichi Handa <handa@m17n.org>
11054 * xdisp.c (get_next_display_element): Set correct it->face_id for
11055 a static composition.
11057 2011-05-24 Leo Liu <sdl.web@gmail.com>
11060 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11062 * fns.c (crypto_hash_function, Fsha1): New function.
11063 (Fmd5): Use crypto_hash_function.
11064 (syms_of_fns): Add Ssha1.
11066 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11068 * gnutls.c: Remove unused macros.
11069 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11070 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11071 Remove macros that are defined and never used.
11072 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11074 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11076 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11077 (Fx_get_selection_internal): Minor cleanup.
11078 (Fx_own_selection_internal): Rename arguments for consistency with
11081 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11083 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11085 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11087 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11089 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11091 * dispnew.c (scrolling_window): Don't exclude the case that the
11092 last enabled row in the desired matrix touches the bottom boundary.
11094 2011-05-21 Glenn Morris <rgm@gnu.org>
11096 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11097 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11098 and add some more files.
11100 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11102 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11103 report_file_error introduced by the change from 2011-05-07.
11105 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11107 * systime.h (Time): Define only if emacs is defined.
11108 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11109 where the include path doesn't have X11/X.h by default. See
11110 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11112 2011-05-20 Kenichi Handa <handa@m17n.org>
11114 * composite.c (find_automatic_composition): Fix previous change.
11116 2011-05-20 Glenn Morris <rgm@gnu.org>
11118 * lisp.mk: New file, split from Makefile.in.
11119 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11120 (shortlisp): Remove.
11121 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11123 2011-05-19 Glenn Morris <rgm@gnu.org>
11125 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11126 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11127 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11128 (lisp): Set the order to that of loadup.el.
11129 (shortlisp): Make it a copy of $lisp.
11130 (SOME_MACHINE_LISP): Remove.
11131 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11132 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11134 2011-05-18 Kenichi Handa <handa@m17n.org>
11136 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11137 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11138 (find_automatic_composition): Mostly rewrite for efficiency.
11140 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11142 * makefile.w32-in: Update dependencies.
11144 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11146 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11147 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11149 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11151 Fix some integer overflow issues, such as string length overflow.
11153 * insdel.c (count_size_as_multibyte): Check for string overflow.
11155 * character.c (lisp_string_width): Check for string overflow.
11156 Use EMACS_INT, not int, for string indexes and lengths; in
11157 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11158 the resulting string length overflows an EMACS_INT; instead,
11159 report a string overflow if no precision given. When checking for
11160 precision exhaustion, use a check that cannot possibly have
11161 integer overflow. (Bug#8675)
11162 * character.h (lisp_string_width): Adjust to new signature.
11164 * alloc.c (string_overflow): New function.
11165 (Fmake_string): Use it. This doesn't change behavior, but saves
11166 a few bytes and will simplify future changes.
11167 * character.c (string_escape_byte8): Likewise.
11168 * lisp.h (string_overflow): New decl.
11170 Fixups, following up to the user-interface timestamp change.
11171 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11172 for UI timestamps, instead of unsigned long.
11173 * msdos.c (mouse_get_pos): Likewise.
11174 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11175 * w32gui.h (Time): Define by including "systime.h" rather than by
11176 declaring it ourselves. (Bug#8664)
11178 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11179 * image.c (clear_image_cache): Likewise.
11181 * term.c (term_mouse_position): Don't assume time_t wraparound.
11183 Be more systematic about user-interface timestamps.
11184 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11185 and sometimes 'EMACS_UINT', to represent these timestamps.
11186 This change causes it to use 'Time' uniformly, as that's what X uses.
11187 This makes the code easier to follow, and makes it easier to catch
11188 integer overflow bugs such as Bug#8664.
11189 * frame.c (Fmouse_position, Fmouse_pixel_position):
11190 Use Time, not unsigned long, for user-interface timestamps.
11191 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11192 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11193 * keyboard.h (last_event_timestamp): Likewise.
11194 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11195 * menu.h (xmenu_show): Likewise.
11196 * term.c (term_mouse_position): Likewise.
11197 * termhooks.h (struct input_event.timestamp): Likewise.
11198 (struct terminal.mouse_position_hook): Likewise.
11199 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11200 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11201 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11202 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11203 what it was before.
11204 * menu.h, termhooks.h: Include "systime.h", for Time.
11206 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11207 Don't assume that the difference between two unsigned long values
11208 can fit into an integer. At this point, we know button_down_time
11209 <= event->timestamp, so the difference must be nonnegative, so
11210 there's no need to cast the result if double-click-time is
11211 nonnegative, as it should be; check that it's nonnegative, just in
11212 case. This bug is triggered when events are more than 2**31 ms
11213 apart (about 25 days). (Bug#8664)
11215 * xselect.c (last_event_timestamp): Remove duplicate decl.
11216 (x_own_selection): Remove needless cast to unsigned long.
11218 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11219 that always fit in int. Use a sentinel instead of a counter, to
11220 avoid a temp and to allay GCC's concerns about possible int overflow.
11221 * frame.h (struct frame): Use int for menu_bar_items_used
11222 instead of EMACS_INT, since it always fits in int.
11224 * menu.c (grow_menu_items): Check for int overflow.
11226 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11228 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11229 Before, the code was not consistent. These values cannot exceed
11230 2**31 - 1 so there's no need to make them unsigned.
11231 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11232 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11233 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11235 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11237 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11238 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11239 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11240 presumably because the widths might not match.
11242 * window.c (size_window): Avoid needless test at loop start.
11244 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11246 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11248 2011-05-12 Drew Adams <drew.adams@oracle.com>
11250 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11252 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11254 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11255 `width' to `bar_area_x' and `bar_area_width', respectively.
11256 (x_scroll_run): Take account of fringe background extension.
11258 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11259 Rename local vars `left' and `width' to `bar_area_x' and
11260 `bar_area_width', respectively.
11261 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11262 background extension.
11264 2011-05-10 Jim Meyering <meyering@redhat.com>
11266 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11268 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11270 * image.c (Finit_image_library): Return t for built-in image types,
11271 like pbm and xbm. (Bug#8640)
11273 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11275 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11277 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11279 * w32console.c (Fset_screen_color): Doc fix.
11280 (Fget_screen_color): New function.
11281 (syms_of_ntterm): Defsubr it.
11283 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11284 unlink the temporary file if Fcall_process didn't create it in the
11286 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11287 child process will be redirected to a file specified with `:file'.
11288 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11289 cue to call_process_cleanup not to close that handle.
11291 2011-05-07 Ben Key <bkey76@gmail.com>
11293 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11294 one of two shell specific rules, either bootstrap-temacs-CMD or
11295 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11296 to the previous implementation of the bootstrap-temacs rule.
11297 The bootstrap-temacs-CMD rule is similar to the previous
11298 implementation of the bootstrap-temacs rule except that it
11299 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11302 These changes, along with some changes to nt/configure.bat,
11303 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11304 earlier fix to add support for --cflags and --ldflags options
11305 that include quotes so that it works whether make uses cmd or
11308 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11310 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11311 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11313 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11314 a string. Handle both cases.
11315 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11316 (Fdbus_register_method): Use Qinvalid_function.
11318 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11320 * makefile.w32-in: Update dependencies.
11321 (LISP_H): Add inttypes.h and stdin.h.
11322 (PROCESS_H): Add unistd.h.
11324 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11326 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11327 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11329 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11331 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11333 * term.c (vfatal): Remove stray call to va_end.
11334 It's not needed and the C Standard doesn't allow it here anyway.
11336 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11337 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11339 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11342 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11344 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11346 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11348 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11350 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11352 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11353 * charset.c (Fdefine_charset_internal): Don't initialize
11354 charset.code_space[15]. The value was garbage, on hosts with
11355 32-bit int (Bug#8600).
11357 * lread.c (read_integer): Be more consistent with string-to-number.
11358 Use string_to_number to do the actual conversion; this avoids
11359 rounding errors and fixes some other screwups. Without this fix,
11360 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11361 (digit_to_number): Move earlier, for benefit of read_integer.
11362 Return -1 if the digit is out of range for the base, -2 if it is
11363 not a digit in any supported base. (Bug#8602)
11365 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11367 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11368 to match comment at start of function. This also removes a
11369 GCC warning about overflow in a 32+64-bit port.
11371 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11373 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11374 Reported by Stefan Monnier in
11375 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11376 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11377 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11379 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11380 (EMACS_UINTPTR): Likewise, with uintptr_t.
11382 * lisp.h: Prefer 64-bit EMACS_INT if available.
11383 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11384 on 32-bit hosts that have 64-bit int, so that they can access
11386 However, temporarily disable this change unless the temporary
11387 symbol WIDE_EMACS_INT is defined.
11389 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11391 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11392 This removes an assumption that EMACS_INT and long are the same
11393 width as pointers. The assumption is true for Emacs porting targets
11394 now, but we want to make other targets possible.
11395 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11396 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11397 In the rest of the code, change types of integers that hold casted
11398 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11399 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11400 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11401 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11402 No need to cast type when ORing.
11403 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11404 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11405 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11406 assume EMACS_INT is the same width as char *.
11407 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11408 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11409 Remove no-longer-needed casts.
11410 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11411 (xg_tool_bar_help_callback, xg_make_tool_item):
11412 Use EMACS_INTPTR to hold an integer
11413 that will be cast to void *; this can avoid a GCC warning
11414 if EMACS_INT is not the same width as void *.
11415 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11416 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11417 (current_message_1, set_message_1):
11418 Use a local to convert to proper width without a cast.
11419 * xmenu.c (dialog_selection_callback): Likewise.
11421 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11422 Also, don't assume VALBITS / RAND_BITS is less than 5,
11423 and don't rely on undefined behavior when shifting a 1 left into
11425 * lisp.h (get_random): Change signature to match.
11427 * lread.c (hash_string): Use size_t, not int, for hash computation.
11428 Normally we prefer signed values; but hashing is special, because
11429 it's better to use unsigned division on hash table sizes so that
11430 the remainder is nonnegative. Also, size_t is the natural width
11431 for hashing into memory. The previous code used 'int', which doesn't
11432 retain enough info to hash well into very large tables.
11433 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11435 * dbusbind.c: Don't possibly lose pointer info when converting.
11436 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11437 Use XPNTR rather than XHASH, so that the high-order bits of
11438 the pointer aren't lost when converting through void *.
11440 * eval.c (Fautoload): Don't double-shift a pointer.
11442 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11444 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11446 * gnutls.c (DEF_GNUTLS_FN):
11447 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11449 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11451 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11454 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11456 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11457 New version that can reserve upto 2GB of heap space.
11459 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11461 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11463 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11465 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11466 `gnutls_certificate_set_x509_key_file'.
11468 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11470 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11471 Update dependencies.
11473 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11475 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11476 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11477 Remove unused parameter `fildes'.
11478 * process.c (read_process_output, send_process): Don't pass it.
11480 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11482 Fix previous change: the library cache is defined in w32.c.
11483 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11484 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11486 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11488 Implement dynamic loading of GnuTLS on Windows.
11490 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11491 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11492 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11495 * gnutls.c (Qgnutls_dll): Define.
11496 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11497 (gnutls_*): Declare function pointers.
11498 (init_gnutls_functions): New function to initialize function pointers.
11499 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11500 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11501 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11502 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11503 (emacs_gnutls_write, emacs_gnutls_read)
11504 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11505 (Fgnutls_available_p): New function.
11506 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11507 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11508 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11510 * image.c: Include w32.h.
11511 (Vimage_type_cache): Delete.
11512 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11513 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11514 (w32_delayed_load): Move to w32.c.
11516 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11518 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11519 (w32_delayed_load): Move from image.c. When loading a library, record
11520 its filename in the :loaded-from property of the library id.
11521 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11522 Initialize and staticpro them.
11523 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11525 * process.c: Include lisp.h before w32.h, not after.
11526 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11527 instead of gnutls_record_check_pending.
11529 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11531 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11533 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11534 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11537 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11539 * xterm.c (x_set_frame_alpha): Do not set property on anything
11540 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11542 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11544 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11546 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11548 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11549 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11550 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11551 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11552 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11553 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11554 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11555 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11556 (Qgnutls_bootprop_callbacks_verify): Make static.
11558 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11560 * callproc.c: Indentation fixup.
11562 * sysdep.c (wait_for_termination_1): Make static.
11563 (wait_for_termination, interruptible_wait_for_termination):
11564 Move after wait_for_termination_1.
11566 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11568 * sysdep.c (interruptible_wait_for_termination): New function
11569 which is like wait_for_termination, but allows keyboard
11572 * callproc.c (Fcall_process): Add (:file "file") as an option for
11574 (Fcall_process_region): Ditto.
11576 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11578 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11579 rather than `XVECTOR (FOO)->size'.
11581 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11582 inttypes.h, as a gnulib replacement is used if it not available in
11585 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11587 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11588 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11589 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11591 * coding.c (coding_alloc_by_realloc): Error out if destination
11592 will grow beyond MOST_POSITIVE_FIXNUM.
11593 (decode_coding_emacs_mule): Abort if there isn't enough place in
11594 charbuf for the composition carryover bytes. Reserve an extra
11595 space for up to 2 characters produced in a loop.
11596 (decode_coding_iso_2022): Abort if there isn't enough place in
11597 charbuf for the composition carryover bytes.
11599 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11601 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11602 aborting when %lld or %lll format is passed.
11603 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11604 %llo or %llx format is passed. (Bug#8545)
11606 * window.c (window_scroll_line_based): Use a marker instead of
11607 simple variables to record original value of point. (Bug#7952)
11609 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11610 produced by %s or %c overflows available buffer space. (Bug#8545)
11612 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11614 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11615 (SIZE_MAX): Move defn after all includes, as they might #define it.
11617 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11619 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11621 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11623 * keyboard.c (Qdelayed_warnings_hook): Define.
11624 (command_loop_1): Run `delayed-warnings-hook'
11625 if Vdelayed_warnings_list is non-nil.
11626 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11627 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11629 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11631 * doprnt.c (doprnt): Don't return value smaller than the buffer
11632 size if the message was truncated. (Bug#8545).
11634 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11636 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11637 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11639 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11641 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11643 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11645 * makefile.w32-in: Update dependencies.
11647 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11649 Improve `doprnt' and its usage. (Bug#8545)
11650 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11651 `format_end'. Remove support for %l as a conversion specifier.
11652 Don't use xrealloc. Improve diagnostics when the %l size modifier
11653 is used. Update the commentary.
11655 * eval.c (verror): Simplify calculation of size_t.
11657 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11660 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11662 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11665 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11667 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11668 This makes this file independent of the recent pseudovector change.
11670 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11672 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11674 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11675 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11676 Remove unused local.
11677 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11679 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11680 GCC 4.6.0 optimizes based on type-based alias analysis.
11681 For example, if b is of type struct buffer * and v of type struct
11682 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11683 != &v->size, and therefore "v->size = 1; b->size = 2; return
11684 v->size;" must therefore return 1. This assumption is incorrect
11685 for Emacs, since it type-puns struct Lisp_Vector * with many other
11686 types. To fix this problem, this patch adds a new type struct
11687 vectorlike_header that documents the constraints on layout of vectors
11688 and pseudovectors, and helps optimizing compilers not get fooled
11689 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11690 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11691 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11693 (XSETPVECTYPE): Rewrite in terms of new macro.
11694 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11695 This is a bit clearer, and further avoids the possibility of
11696 undesirable aliasing.
11697 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11698 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11699 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11700 since Lisp_Subr is a special case (no "next" field).
11701 (ASIZE): Now uses header.size rather than size.
11702 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11703 to avoid the hassle of writing XVECTOR (foo)->header.size.
11704 (struct vectorlike_header): New type.
11705 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11706 object, to help avoid aliasing.
11707 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11708 (SUBRP): Likewise, since Lisp_Subr is a special case.
11709 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11710 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11711 (struct Lisp_Hash_Table): Combine first two members into a single
11712 struct vectorlike_header member. All uses of "size" and "next" members
11713 changed to be "header.size" and "header.next".
11714 * buffer.h (struct buffer): Likewise.
11715 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11716 * frame.h (struct frame): Likewise.
11717 * process.h (struct Lisp_Process): Likewise.
11718 * termhooks.h (struct terminal): Likewise.
11719 * window.c (struct save_window_data, struct saved_window): Likewise.
11720 * window.h (struct window): Likewise.
11721 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11722 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11723 * buffer.c (init_buffer_once): Likewise.
11724 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11726 * process.c (Fformat_network_address): Use local var for size,
11729 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11731 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11732 * data.c (atof): Remove decl; no longer used or needed.
11733 (digit_to_number): Move to lread.c.
11734 (Fstring_to_number): Use new string_to_number function, to be
11735 consistent with how the Lisp reader treats infinities and NaNs.
11736 Do not assume that floating-point numbers represent EMACS_INT
11737 without losing information; this is not true on most 64-bit hosts.
11738 Avoid double-rounding errors, by insisting on integers when
11739 parsing non-base-10 numbers, as the documentation specifies.
11740 * lisp.h (string_to_number): New decl, replacing ...
11741 (isfloat_string): Remove.
11742 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11743 (read1): Do not accept +. and -. as integers; this
11744 appears to have been a coding error. Similarly, do not accept
11745 strings like +-1e0 as floating point numbers. Do not report
11746 overflow for integer overflows unless the base is not 10 which
11747 means we have no simple and reliable way to continue.
11748 Break out the floating-point parsing into a new
11749 function string_to_number, so that Fstring_to_number parses
11750 floating point numbers consistently with the Lisp reader.
11751 (digit_to_number): Move here from data.c. Make it static inline.
11752 (E_CHAR, EXP_INT): Remove, replacing with ...
11753 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11754 (string_to_number): New function, replacing isfloat_string.
11755 This function checks for valid syntax and produces the resulting
11756 Lisp float number too. Rework it so that string-to-number
11757 no longer mishandles examples like "1.0e+". Use strtoumax,
11758 so that overflow for non-base-10 numbers is reported only when
11759 there's no portable and simple way to convert to floating point.
11761 * textprop.c (set_text_properties_1): Rewrite for clarity,
11762 and to avoid GCC warning about integer overflow.
11764 * intervals.h (struct interval): Use EMACS_INT for members
11765 where EMACS_UINT might cause problems. See
11766 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11767 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11768 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11770 (offset_intervals): Tell GCC not to worry about length overflow
11771 when negating a negative length.
11773 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11774 (overrun_check_free): Likewise.
11776 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11777 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11780 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11781 (gnutls_make_error): Rename local to avoid shadowing.
11782 (gnutls_emacs_global_deinit): ifdef out; not used.
11783 (Fgnutls_boot): Use const for pointer to readonly storage.
11784 Comment out unused local. Fix pointer signedness problems.
11786 * lread.c (openp): Don't stuff size_t into an 'int'.
11787 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11788 about possible signed overflow.
11790 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11791 (GDK_KEY_g): Don't define if already defined.
11792 (xg_prepare_tooltip): Avoid pointer signedness problem.
11793 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11795 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11796 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11798 * xfns.c (Fx_window_property): Simplify a bit,
11799 to make a bit faster and to avoid GCC 4.6.0 warning.
11800 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11802 * fns.c (internal_equal): Don't assume size_t fits in int.
11804 * alloc.c (compact_small_strings): Tighten assertion a little.
11806 Replace pEd with more-general pI, and fix some printf arg casts.
11807 * lisp.h (pI): New macro, generalizing old pEd macro to other
11808 conversion specifiers. For example, use "...%"pI"d..." rather
11809 than "...%"pEd"...".
11810 (pEd): Remove. All uses replaced with similar uses of pI.
11811 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11812 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11813 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11814 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11815 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11816 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11817 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11819 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11820 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11821 * print.c (safe_debug_print, print_object): Likewise.
11822 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11824 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11825 avoiding the 0 flag, which is not portable.
11826 * process.c (Fmake_network_process): Use pI to avoid cast.
11827 * region-cache.c (pp_cache): Likewise.
11828 * xdisp.c (decode_mode_spec): Likewise.
11829 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11830 behavior on 64-bit hosts with printf arg.
11831 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11832 (x_stop_queuing_selection_requests): Likewise.
11833 (x_get_window_property): Don't truncate byte count to an 'int'
11836 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11837 here, since it parses constructs like leading '-' and spaces,
11838 which are not wanted; and it overflows with large numbers.
11839 Instead, simply match F[0-9]+, which is what is wanted anyway.
11841 * alloc.c: Remove unportable assumptions about struct layout.
11842 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11843 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11844 (allocate_vectorlike, make_pure_vector): Use the new macros,
11845 plus offsetof, to remove unportable assumptions about struct layout.
11846 These assumptions hold on all porting targets that I know of, but
11847 they are not guaranteed, they're easy to remove, and removing them
11848 makes further changes easier.
11850 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11851 This doesn't fix a bug but makes the code clearer.
11852 (string_overrun_cookie): Now const. Use initializers that
11853 don't formally overflow signed char, to avoid warnings.
11854 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11855 can cause Emacs to crash when string overrun checking is enabled.
11856 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11857 multiple of sizeof (EMACS_INT); it need not be, if
11858 alignof(EMACS_INT) < sizeof (EMACS_INT).
11859 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11861 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11863 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11865 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11867 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11868 supposed to be handshaking. (Bug#8556)
11869 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11871 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11873 * lisp.h (Qdebug): List symbol.
11874 * eval.c (Qdebug): Restore global linkage.
11875 * keyboard.c (debug-on-event): New variable.
11876 (handle_user_signal): Break into debugger when debug-on-event
11877 matches the current signal symbol.
11879 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11881 * alloc.c (check_sblock, check_string_bytes)
11882 (check_string_free_list): Convert to standard C.
11884 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11886 * w32.c (emacs_gnutls_push): Fix typo.
11888 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11890 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11891 "cast to pointer from integer of different size".
11893 Improve doprnt and its use in verror. (Bug#8545)
11894 * doprnt.c (doprnt): Document the set of format control sequences
11895 supported by the function. Use SAFE_ALLOCA instead of always
11898 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11899 is one byte too soon. Don't use xrealloc; instead xfree and
11902 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11904 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11907 * gnutls.c: Renamed global_initialized to
11908 gnutls_global_initialized. Added internals for the
11909 :verify-hostname-error, :verify-error, and :verify-flags
11910 parameters of `gnutls-boot' and documented those parameters in the
11911 docstring. Start callback support.
11912 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11913 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11914 on error. Return error code.
11915 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11916 (emacs_gnutls_read): Likewise.
11917 (Fgnutls_boot): Return handshake error code.
11918 (emacs_gnutls_handle_error): New function.
11919 (wsaerror_to_errno): Likewise.
11921 * w32.h (emacs_gnutls_pull): Add prototype.
11922 (emacs_gnutls_push): Likewise.
11924 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11925 (emacs_gnutls_push): Likewise.
11927 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11929 * process.c (wait_reading_process_output): Check if GnuTLS
11930 buffered some data internally if no FDs are set for TLS
11933 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11934 (LIBS): Link to USER_LIBS.
11935 ($(BLD)/gnutls.$(0)): New target.
11937 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11939 * xdisp.c (handle_single_display_spec): Rename the
11940 display_replaced_before_p argument into display_replaced_p, to
11941 make it consistent with the commentary. Fix typos in the
11944 * textprop.c (syms_of_textprop): Remove dead code.
11945 (copy_text_properties): Delete obsolete commentary about an
11946 interface that was deleted long ago. Fix typos in the description
11949 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11950 to changes in oldXMenu/XMenu.h from 2011-04-16.
11951 <menu_help_message, prev_menu_help_message>: Constify.
11952 (IT_menu_make_room): menu->help_text is now `const char **';
11955 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11956 to changes in oldXMenu/XMenu.h from 2011-04-16.
11957 (struct XMenu): Declare `help_text' `const char **'.
11959 * xfaces.c <Qunspecified>: Make extern again.
11961 * syntax.c: Include sys/types.h before including regex.h, as
11964 * doc.c (get_doc_string): Improve the format passed to `error'.
11966 * doprnt.c (doprnt): Improve commentary.
11968 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11970 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11973 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11974 changes in globals.h immediately force recompilation.
11975 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11976 $(CURDIR)/s/ms-w32.h.
11977 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11979 * character.c (Fchar_direction): Function deleted.
11980 (syms_of_character): Don't defsubr it.
11981 <char-direction-table>: Deleted.
11983 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11985 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11986 * doprnt.c: Include limits.h.
11987 (SIZE_MAX): New macro.
11988 (doprnt): Return a size_t value. 2nd arg is now size_t.
11989 Many local variables are now size_t instead of int or unsigned.
11990 Improve overflow protection. Support `l' modifier for integer
11991 conversions. Support %l conversion. Don't assume an EMACS_INT
11992 argument for integer conversions and for %c.
11994 * lisp.h (doprnt): Restore prototype.
11996 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11997 $(SRC)/character.h.
11999 * Makefile.in (base_obj): Add back doprnt.o.
12001 * deps.mk (doprnt.o): Add back prerequisites.
12002 (callint.o): Depend on character.h.
12004 * eval.c (internal_lisp_condition_case): Include the handler
12005 representation in the error message.
12006 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12007 when breaking from the loop.
12009 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12011 * callint.c (Fcall_interactively): When displaying error message
12012 about invalid control letter, pass the character's codepoint, not
12013 a pointer to its multibyte form. Improve display of the character
12014 in octal and display also its hex code.
12016 * character.c (char_string): Use %x to display the (unsigned)
12017 codepoint of an invalid character, to avoid displaying a bogus
12020 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12021 `error', not SYMBOL_NAME itself.
12023 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12024 character arguments to `error'.
12026 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12027 to `error' in error message about FINAL_CHAR argument. Make sure
12028 FINAL_CHAR is a character, and use %c when it is passed as
12029 argument to `error'.
12031 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12033 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12035 * w32.c: Include <time.h>.
12036 (sys_localtime): New function.
12038 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12040 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12042 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12044 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12046 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12047 zombies (Bug#8467).
12049 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12051 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12052 gl_state.e_property when gl_state.object is Qt.
12054 * insdel.c (make_gap_larger): Remove limitation of buffer size
12057 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12059 * xdisp.c (lookup_glyphless_char_display)
12060 (produce_glyphless_glyph): Handle cons cell entry in
12061 glyphless-char-display.
12062 (Vglyphless_char_display): Document it.
12064 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12065 glyphless-char-display.
12067 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12069 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12071 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12073 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12074 definition for no-X builds.
12076 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12078 Static checks with GCC 4.6.0 and non-default toolkits.
12080 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12082 * process.c (keyboard_bit_set): Define only if SIGIO.
12083 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12084 (send_process): Repair possible setjmp clobbering.
12086 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12088 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12090 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12092 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12093 Define only if needed.
12095 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12096 by pacifying GCC about it. Maybe it's time to retire it?
12097 * xfaces.c (USG, __TIMEVAL__): Likewise.
12099 * dispextern.h (struct redisplay_interface): Rename param
12100 to avoid shadowing.
12101 * termhooks.h (struct terminal): Likewise.
12102 * xterm.c (xembed_send_message): Likewise.
12104 * insdel.c (make_gap_smaller): Define only if
12105 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12107 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12110 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12111 so that we aren't warned about unused symbols.
12113 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12115 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12117 * xfns.c (x_real_positions): Mark locals as initialized.
12119 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12121 * xterm.c: Fix problems found by static analysis with other toolkits.
12122 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12123 (x_dispatch_event): Declare static if USE_GTK, and
12124 define if USE_GTK || USE_X_TOOLKIT.
12125 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12126 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12127 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12128 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12130 * xmenu.c (menu_help_callback): Pointer type fixes.
12131 Use const pointers when pointing at readonly data. Avoid pointer
12132 signedness clashes.
12133 (FALSE): Remove unused macro.
12134 (update_frame_menubar): Remove unused decl.
12136 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12138 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12139 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12140 (single_menu_item): Rename local to avoid shadowing.
12142 * keyboard.c (make_lispy_event): Remove unused local var.
12144 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12145 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12147 * bitmaps: Change bitmaps from unsigned char back to the X11
12148 compatible char. Avoid the old compiler warnings about
12149 out-of-range initializers by using, for example, '\xab' rather
12152 * xgselect.c (xgselect_initialize): Check vs interface
12153 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12155 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12157 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12158 to read-only memory.
12160 * fns.c (vector): Remove; this old hack is no longer needed.
12162 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12164 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12166 * xrdb.c (x_load_resources): Omit unused local.
12168 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12169 (x_window): Rename locals to avoid shadowing.
12170 (USG): Use the kludged USG macro, to pacify gcc.
12172 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12173 (x_term_init): Remove local to avoid shadowing.
12175 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12177 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12178 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12180 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12182 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12184 Fix regex.c, syntax.c and friends for buffers > 2GB.
12185 * syntax.h (struct gl_state_s): Declare character position members
12188 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12190 * textprop.c (verify_interval_modification, interval_of):
12191 Declare arguments EMACS_INT.
12193 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12196 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12198 * indent.c (Fvertical_motion): Local variable it_start is now
12201 * regex.c (re_match, re_match_2, re_match_2_internal)
12202 (bcmp_translate, regcomp, regexec, print_double_string)
12203 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12204 (re_compile_pattern, re_exec): Declare arguments and local
12205 variables `size_t' and `ssize_t' and return values `regoff_t', as
12207 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12208 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12209 <compile_stack_type>: `size' and `avail' are now `size_t'.
12211 * regex.h <regoff_t>: Use ssize_t, not int.
12212 (re_search, re_search_2, re_match, re_match_2): Arguments that
12213 specify buffer/string position and length are now ssize_t and
12214 size_t. Return type is regoff_t.
12216 2011-04-16 Ben Key <bkey76@gmail.com>
12218 * nsfont.m: Fixed bugs in ns_get_family and
12219 ns_descriptor_to_entity that were caused by using free to
12220 deallocate memory blocks that were allocated by xmalloc (via
12221 xstrdup). This caused Emacs to crash when compiled with
12222 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12223 --enable-checking=xmallocoverrun). xfree is now used to
12224 deallocate these memory blocks.
12226 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12228 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12230 emacs_write: Accept and return EMACS_INT for sizes.
12231 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12233 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12234 Accept and return EMACS_INT.
12235 (emacs_gnutls_write): Return the number of bytes written on
12237 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12238 (emacs_read, emacs_write): Remove check for negative size, as the
12239 Emacs source code has been audited now.
12240 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12241 (emacs_read, emacs_write): Use it.
12242 * process.c (send_process): Adjust to the new signatures of
12243 emacs_write and emacs_gnutls_write. Do not attempt to store
12244 a byte offset into an 'int'; it might overflow.
12245 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12247 * sound.c: Don't assume sizes fit in 'int'.
12248 (struct sound_device.period_size, alsa_period_size):
12249 Return EMACS_INT, not int.
12250 (struct sound_device.write, vox_write, alsa_write):
12251 Accept EMACS_INT, not int.
12252 (wav_play, au_play): Use EMACS_INT to store sizes and to
12253 record read return values.
12255 2011-04-15 Ben Key <bkey76@gmail.com>
12257 * keyboard.c (Qundefined): Don't declare static since it is used
12259 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12260 static since they are used in nsfont.m.
12262 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12264 * process.c (Qprocessp): Don't declare static.
12265 * lisp.h (Qprocessp): Declare again.
12267 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12269 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12271 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12273 Improve C-level modularity by making more things 'static'.
12275 Don't publish debugger-only interfaces to other modules.
12276 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12277 (verify_bytepos, count_markers): Move decls to the only modules
12279 * region-cache.h (pp_cache): Likewise.
12280 * window.h (check_all_windows): Likewise.
12281 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12283 * sysdep.c (croak): Now static, if
12284 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12285 * syssignal.h (croak): Declare only if not static.
12287 * alloc.c (refill_memory_reserve): Now static if
12288 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12289 * lisp.h (refill_memory_reserve): Declare only if not static.
12291 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12292 Define only if USE_LUCID.
12294 * xrdb.c (x_customization_string, x_rm_string): Now static.
12296 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12297 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12299 * xdisp.c (draw_row_with_mouse_face): Now static.
12300 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12302 * window.h (check_all_windows): Mark externally visible.
12304 * window.c (window_deletion_count): Now static.
12306 * undo.c: Make symbols static if they're not exported.
12307 (last_undo_buffer, last_boundary_position, pending_boundary):
12310 * textprop.c (interval_insert_behind_hooks): Now static.
12311 (interval_insert_in_front_hooks): Likewise.
12313 * term.c: Make symbols static if they're not exported.
12314 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12315 (max_frame_lines, tty_set_terminal_modes):
12316 (tty_reset_terminal_modes, tty_turn_off_highlight):
12317 (get_tty_terminal): Now static.
12318 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12319 * termhooks.h (term_mouse_moveto): Do not declare if
12320 HAVE_WINDOW_SYSTEM.
12321 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12322 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12324 * sysdep.c: Make symbols static if they're not exported.
12325 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12327 (sigprocmask_set, full_mask): Remove; unused.
12328 (wait_debugging): Mark as visible.
12329 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12330 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12332 * syntax.c (syntax_temp): Define only if !__GNUC__.
12334 * sound.c (current_sound_device, current_sound): Now static.
12336 * search.c (searchbufs, searchbuf_head): Now static.
12338 * scroll.c (scroll_cost): Remove; unused.
12339 * dispextern.h (scroll_cost): Remove decl.
12341 * region-cache.h (pp_cache): Mark as externally visible.
12343 * process.c: Make symbols static if they're not exported.
12344 (process_tick, update_tick, create_process, chan_process):
12345 (Vprocess_alist, proc_buffered_char, datagram_access):
12346 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12347 (deactivate_process): Mark defn as static, as well as decl.
12348 * lisp.h (create_process): Remove decl.
12349 * process.h (chan_process, Vprocess_alist): Remove decls.
12351 * print.c: Make symbols static if they're not exported.
12352 (print_depth, new_backquote_output, being_printed, print_buffer):
12353 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12354 (print_interval, print_number_index, initial_stderr_stream):
12356 * lisp.h (Fprinc): Remove decl.
12357 (debug_output_compilation_hack): Mark as externally visible.
12359 * sysdep.c (croak): Move decl from here to syssignal.h.
12360 * syssignal.h (croak): Put it here, so the API can be checked when
12361 'croak' is called from dissociate_if_controlling_tty.
12363 * minibuf.c: Make symbols static if they're not exported.
12364 (minibuf_save_list, choose_minibuf_frame): Now static.
12365 * lisp.h (choose_minibuf_frame): Remove decl.
12367 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12369 * lread.c: Make symbols static if they're not exported.
12370 (read_objects, initial_obarray, oblookup_last_bucket_number):
12372 (make_symbol): Remove; unused.
12373 * lisp.h (initial_obarray, make_symbol): Remove decls.
12375 * keyboard.c: Make symbols static if they're not exported.
12376 (single_kboard, recent_keys_index, total_keys, recent_keys):
12377 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12378 (this_single_command_key_start, echoing, last_auto_save):
12379 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12380 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12381 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12382 (Vlispy_mouse_stem, double_click_count):
12384 (force_auto_save_soon): Define only if SIGDANGER.
12385 (ignore_mouse_drag_p): Now static if
12386 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12387 (print_help): Remove; unused.
12388 (stop_character, last_timer_event): Mark as externally visible.
12389 * keyboard.h (ignore_mouse_drag_p): Declare only if
12390 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12391 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12392 * lisp.h (echoing): Remove decl.
12393 (force_auto_save_soon): Declare only if SIGDANGER.
12394 * xdisp.c (redisplay_window): Simplify code, to make it more
12395 obvious that ignore_mouse_drag_p is not accessed if !defined
12396 USE_GTK && !defined HAVE_NS.
12398 * intervals.c: Make symbols static if they're not exported.
12399 (merge_properties_sticky, merge_interval_right, delete_interval):
12401 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12403 * insdel.c: Make symbols static if they're not exported.
12404 However, leave prepare_to_modify_buffer alone. It's never
12405 called from outside this function, but that appears to be a bug.
12406 (combine_after_change_list, combine_after_change_buffer):
12407 (adjust_after_replace, signal_before_change): Now static.
12408 (adjust_after_replace_noundo): Remove; unused.
12409 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12410 (signal_before_change): Remove decls.
12412 * indent.c (val_compute_motion, val_vmotion): Now static.
12414 * image.c: Make symbols static if they're not exported.
12415 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12417 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12418 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12420 * fringe.c (standard_bitmaps): Now static.
12421 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12423 * frame.c: Make symbols static if they're not exported.
12424 (x_report_frame_params, make_terminal_frame): Now static.
12425 (get_frame_param): Now static, unless HAVE_NS.
12426 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12427 (x_get_resource_string): Remove; not used.
12428 * frame.h (make_terminal_frame, x_report_frame_params):
12429 (x_get_resource_string); Remove decls.
12430 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12431 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12433 * font.c, fontset.c: Make symbols static if they're not exported.
12434 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12435 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12436 * font.c (font_close_object): Now static.
12437 * font.h (font_close_object): Remove.
12438 * fontset.c (FONTSET_OBJLIST): Remove.
12439 (free_realized_fontset) #if-0 the body, which does nothing.
12440 (face_suitable_for_char_p): #if-0, as it's never called.
12441 * fontset.h (face_suitable_for_char_p): Remove decl.
12442 * xfaces.c (face_at_string_position):
12443 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12444 since 0 is always ASCII.
12446 * fns.c (weak_hash_tables): Now static.
12448 * fileio.c: Make symbols static if they're not exported.
12449 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12450 (Vwrite_region_annotation_buffers): Now static.
12452 * eval.c: Make symbols static if they're not exported.
12453 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12454 * lisp.h (backtrace_list): Remove decl.
12456 * emacs.c: Make symbols static if they're not exported.
12457 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12458 (fatal_error_code, fatal_error_signal_hook, standard_args):
12460 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12461 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12462 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12463 * lisp.h (fatal_error_signal_hook): Remove decl.
12464 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12466 * editfns.c: Move a (normally-unused) function to its only use.
12467 * editfns.c, lisp.h (get_operating_system_release): Remove.
12468 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12469 worth the hassle of breaking this out.
12471 * xterm.c: Make symbols static if they're not exported.
12472 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12473 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12474 (x_destroy_window, x_delete_display):
12476 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12477 (x_mouse_leave): Remove; unused.
12478 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12479 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12480 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12482 (x_mouse_leave): Declare only if WINDOWSNT.
12483 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12484 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12487 * ftxfont.c: Make symbols static if they're not exported.
12488 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12490 * font.h (ftxfont_driver): Likewise.
12492 * xfns.c: Make symbols static if they're not exported.
12493 (x_last_font_name, x_display_info_for_name):
12494 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12495 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12496 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12497 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12498 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12499 (last_show_tip_args): Now static.
12500 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12501 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12502 (x_screen_planes): Remove; unused.
12503 * dispextern.h (x_screen_planes): Remove decl.
12505 * dispnew.c: Make symbols static if they're not exported.
12506 * dispextern.h (redraw_garbaged_frames, scrolling):
12507 (increment_row_positions): Remove.
12508 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12509 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12511 (redraw_garbaged_frames): Remove; unused.
12513 * xfaces.c: Make symbols static if they're not exported.
12514 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12516 * xterm.h (defined_color): Remove decls.
12517 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12518 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12519 (menu_face_changed_default, defined_color, free_realized_face):
12520 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12521 (ascii_face_of_lisp_face): Remove; unused.
12523 * xdisp.c: Make symbols static if they're not exported.
12524 * dispextern.h (scratch_glyph_row, window_box_edges):
12525 (glyph_to_pixel_coords, set_cursor_from_row):
12526 (get_next_display_element, set_iterator_to_next):
12527 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12528 (show_mouse_face): Remove decls
12529 * frame.h (message_buf_print): Likewise.
12530 * lisp.h (pop_message, set_message, check_point_in_composition):
12532 * xterm.h (set_vertical_scroll_bar): Likewise.
12533 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12534 (message_buf_print, scratch_glyph_row, displayed_buffer):
12535 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12536 (get_next_display_element, show_mouse_face, window_box_edges):
12537 (frame_to_window_pixel_xy, check_point_in_composition):
12538 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12539 (glyph_to_pixel_coords): Remove; unused.
12541 * dired.c (file_name_completion): Now static.
12543 * dbusbind.c (xd_in_read_queued_messages): Now static.
12545 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12546 * data.c (circular_list_error): Remove.
12548 * commands.h (last_point_position, last_point_position_buffer):
12549 (last_point_position_window): Remove decls.
12550 * keyboard.c: Make these variables static.
12552 * coding.h (coding, code_convert_region, encode_coding_gap):
12554 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12555 (iso_code_class, detect_coding, code_convert_region): Now static.
12556 (encode_coding_gap): Remove; unused.
12558 * chartab.c (chartab_chars, chartab_bits): Now static.
12560 * charset.h (charset_iso_8859_1): Remove decl.
12561 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12564 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12565 * ccl.c (Vccl_program_table): Now static.
12566 (check_ccl_update): Remove; unused.
12568 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12569 * category.h: ... from here.
12570 * category.c (check_category_table, set_category_set): Now static.
12572 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12573 * lisp.h: Remove these decls.
12575 * buffer.c (buffer_count): Remove unused var.
12577 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12578 so that it's not optimized away.
12579 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12580 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12581 exported only to the debugger.
12583 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12584 * atimer.h (run_all_atimers): Remove; not exported.
12586 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12587 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12588 was inaccessible from Lisp.
12589 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12590 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12592 alloc.c: Import and export fewer symbols, and remove unused items.
12593 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12595 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12596 it's not optimized away by whole-program optimization.
12597 (message_enable_multibyte, free_misc): Remove.
12598 (catchlist, handlerlist, mark_backtrace):
12599 Declare only if BYTE_MARK_STACK.
12600 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12601 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12602 (message_enable_multibyte): Remove decl.
12603 (free_misc, interval_free_list, float_block, float_block_index):
12604 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12605 (cons_free_list, last_marked_index):
12607 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12608 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12609 (mark_backtrace): Define only if BYTE_MARK_STACK.
12610 * xdisp.c (message_enable_multibyte): Now static.
12612 Declare Lisp_Object Q* variables to be 'static' if not exported.
12613 This makes it easier for human readers (and static analyzers)
12614 to see whether these variables are used from other modules.
12615 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12616 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12617 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12618 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12619 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12620 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12621 * xmenu.c, xselect.c:
12622 Declare Q* vars static if they are not used in other modules.
12623 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12624 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12625 Remove decls of unexported vars.
12626 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12628 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12630 Make Emacs functions such as Fatom 'static' by default.
12631 This makes it easier for human readers (and static analyzers)
12632 to see whether these functions can be called from other modules.
12633 DEFUN now defines a static function. To make the function external
12634 so that it can be used in other C modules, use the new macro DEFUE.
12635 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12636 (Finit_image_library):
12637 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12638 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12639 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12640 Remove decls, since these functions are now static.
12641 (Funintern, Fget_internal_run_time): New decls, since these functions
12642 were already external.
12644 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12645 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12646 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12647 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12648 * keyboard.c, keymap.c, lread.c:
12649 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12650 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12651 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12652 Mark functions with DEFUE instead of DEFUN,
12653 if they are used in other modules.
12654 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12655 decls for now-static functions.
12656 * buffer.h (Fdelete_overlay): Remove decl.
12657 * callproc.c (Fgetenv_internal): Mark as internal.
12658 * composite.c (Fremove_list_of_text_properties): Remove decl.
12659 (Fcomposition_get_gstring): New forward static decl.
12660 * composite.h (Fcomposite_get_gstring): Remove decl.
12661 * dired.c (Ffile_attributes): New forward static decl.
12662 * doc.c (Fdocumntation_property): New forward static decl.
12663 * eval.c (Ffetch_bytecode): New forward static decl.
12664 (Funintern): Remove extern decl; now in .h file where it belongs.
12665 * fileio.c (Fmake_symbolic_link): New forward static decl.
12666 * image.c (Finit_image_library): New forward static decl.
12667 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12668 * intervals.h (Fprevious_property_change):
12669 (Fremove_list_of_text_properties): Remove decls.
12670 * keyboard.c (Fthis_command_keys): Remove decl.
12671 (Fcommand_execute): New forward static decl.
12672 * keymap.c (Flookup_key): New forward static decl.
12673 (Fcopy_keymap): Now static.
12674 * keymap.h (Flookup_key): Remove decl.
12675 * process.c (Fget_process): New forward static decl.
12676 (Fprocess_datagram_address): Mark as internal.
12677 * syntax.c (Fsyntax_table_p): New forward static decl.
12678 (skip_chars): Remove duplicate decl.
12679 * textprop.c (Fprevious_property_change): New forward static decl.
12680 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12682 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12683 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12685 * editfns.c (Fformat): Remove unreachable code.
12687 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12689 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12692 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12694 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12695 when at ZV. (Bug#8487)
12697 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12699 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12701 * keyboard.c (parse_tool_bar_item): Likewise.
12702 * sound.c (sound_cleanup, alsa_close): Likewise.
12703 * termcap.c (tgetent): Likewise.
12704 * xfns.c (x_default_font_parameter): Likewise.
12705 * xsettings.c (read_and_apply_settings): Likewise.
12707 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12708 (overrun_check_free): Protoize.
12710 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12712 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12713 since callers should never pass a negative size.
12714 Change the signature to match that of plain 'read' and 'write'; see
12715 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12716 * lisp.h: Update prototypes of emacs_write and emacs_read.
12718 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12720 * xdisp.c (redisplay_window): Don't try to determine the character
12721 position of the scroll margin if the window start point w->startp
12722 is outside the buffer's accessible region. (Bug#8468)
12724 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12726 Fix write-region and its subroutines for buffers > 2GB.
12727 * fileio.c (a_write, e_write): Modify declaration of arguments and
12728 local variables to support buffers larger than 2GB.
12729 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12731 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12732 argument, local variables, and return value.
12734 * lisp.h: Update prototypes of emacs_write and emacs_read.
12736 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12738 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12740 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12742 Fix more problems found by GCC 4.6.0's static checks.
12744 * xdisp.c (vmessage): Use a better test for character truncation.
12746 * charset.c (load_charset_map): <, not <=, for optimization,
12747 and to avoid potential problems with integer overflow.
12748 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12749 * casetab.c (set_identity, shuffle): Likewise.
12750 * editfns.c (Fformat): Likewise.
12751 * syntax.c (skip_chars): Likewise.
12753 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12754 This also lets GCC 4.6.0 generate slightly better loop code.
12756 * callint.c (Fcall_interactively): <, not <=, for optimization.
12757 (Fcall_interactively): Count the number of arguments produced,
12758 not the number of arguments given. This is simpler and lets GCC
12759 4.6.0 generate slightly better code.
12761 * ftfont.c: Distingish more carefully between FcChar8 and char.
12762 The previous code passed unsigned char * to a functions like
12763 strlen and xstrcasecmp that expect char *, which does not
12764 conform to the C standard.
12765 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12766 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12767 char * when the C standard requires it.
12769 * keyboard.c (read_char): Remove unused var.
12771 * eval.c: Port to Windows vsnprintf (Bug#8435).
12772 Include <limits.h>.
12773 (SIZE_MAX): Define if the headers do not.
12774 (verror): Do not give up if vsnprintf returns a negative count.
12775 Instead, grow the buffer. This ports to Windows vsnprintf, which
12776 does not conform to C99. Problem reported by Eli Zaretskii.
12777 Also, simplify the allocation scheme, by avoiding the need for
12778 calling realloc, and removing the ALLOCATED variable.
12780 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12782 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12783 But keep the doprint source code for now, as we might revamp it
12784 and use it again (Bug#8435).
12785 * lisp.h (doprnt): Remove.
12786 * Makefile.in (base_obj): Remove doprnt.o.
12787 * deps.mk (doprnt.o): Remove.
12789 error: Print 32- and 64-bit integers portably (Bug#8435).
12790 Without this change, on typical 64-bit hosts error ("...%d...", N)
12791 was used to print both 32- and 64-bit integers N, which relied on
12792 undefined behavior.
12793 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12794 * lisp.h (error, verror): Mark as printf-like functions.
12795 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12796 Report overflow in size calculations when allocating printf buffer.
12797 Do not truncate output string at its first null byte.
12798 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12799 Truncate the output at a character boundary, since vsnprintf does not
12801 * charset.c (check_iso_charset_parameter): Convert internal
12802 character to string before calling 'error', since %c now has the
12804 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12805 overflow when computing char to be passed to 'error'. Do not
12806 pass Lisp_Object to 'error'; pass the integer instead.
12807 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12808 formatted with plain %d.
12810 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12812 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12814 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12816 * xterm.c (x_catch_errors): Remove duplicate declaration.
12818 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12820 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12822 2011-04-10 Jim Meyering <meyering@redhat.com>
12824 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12825 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12826 return ssize_t not "int", and use size_t as the buffer length.
12827 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12828 * gnutls.h: Update declarations.
12829 * process.c (read_process_output): Use ssize_t, to match.
12830 (send_process): Likewise.
12832 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12834 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12836 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12838 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12839 Use unsigned char, to match FcChar8 type definition.
12841 * xterm.c (handle_one_xevent):
12842 * xmenu.c (create_and_show_popup_menu):
12843 * xselect.c (x_decline_selection_request)
12844 (x_reply_selection_request): Avoid type-punned deref of X events.
12846 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12848 Fix some uses of `int' instead of EMACS_INT.
12849 * search.c (string_match_1, fast_string_match)
12850 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12851 (scan_buffer, find_next_newline_no_quit)
12852 (find_before_next_newline, search_command, Freplace_match)
12853 (Fmatch_data): Make some `int' variables be EMACS_INT.
12855 * xdisp.c (display_count_lines): 3rd argument and return value now
12856 EMACS_INT. All callers changed.
12857 (pint2hrstr): Last argument is now EMACS_INT.
12859 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12860 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12861 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12862 (decode_coding_utf_16, decode_coding_emacs_mule)
12863 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12864 (decode_coding_ccl, decode_coding_charset)
12865 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12866 (decode_coding_iso_2022, decode_coding_emacs_mule)
12867 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12868 <char_offset, last_offset>: Declare EMACS_INT.
12869 (encode_coding_utf_8, encode_coding_utf_16)
12870 (encode_coding_emacs_mule, encode_invocation_designation)
12871 (encode_designation_at_bol, encode_coding_iso_2022)
12872 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12873 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12875 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12876 (encode_invocation_designation): Last argument P_NCHARS is now
12878 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12879 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12881 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12884 * ccl.c (Fccl_execute_on_string): Declare some variables
12887 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12889 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12891 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12893 * process.c (Fformat_network_address): Doc fix.
12895 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12897 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12899 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12901 * keyboard.c (read_char): Call Lisp function help-form-show,
12902 instead of using internal_with_output_to_temp_buffer.
12903 (Qhelp_form_show): New var.
12904 (syms_of_keyboard): Use DEFSYM macro.
12906 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12908 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12910 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12912 * process.c (Flist_processes): Remove to Lisp.
12913 (list_processes_1): Delete.
12915 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12917 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12919 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12921 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12923 Fix more problems found by GCC 4.6.0's static checks.
12925 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12927 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12929 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12931 * xdisp.c (vmessage): Mark as a printf-like function.
12933 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12935 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12937 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12938 printf-like functions.
12939 (tiff_load): Add casts to remove these marks before passing them
12940 to system-supplied API.
12942 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12944 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12945 This avoids several warnings with gcc -Wstrict-overflow.
12946 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12947 directly, rather than having caller test rule sign. This avoids
12948 some unnecessary tests.
12949 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12950 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12951 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12953 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12954 (xfont_open): Avoid unnecessary tests.
12956 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12958 * composite.h, composite.c (composition_gstring_put_cache):
12959 Use EMACS_INT, not int, for length.
12961 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12962 breaking out part of COMPOSITION_DECODE_RULE.
12963 (COMPOSITION_DECODE_RULE): Use it.
12964 * composite.c (get_composition_id): Remove unused local vars,
12965 by using the new macro.
12967 * textprop.c (set_text_properties_1): Change while to do-while,
12968 since the condition is always true at first.
12970 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12971 (interval_deletion_adjustment): Return unsigned value.
12974 * process.c (list_processes_1, create_pty, read_process_output):
12975 (exec_sentinel): Remove vars that were set but not used.
12976 (create_pty): Remove unnecessary "volatile"s.
12977 (Fnetwork_interface_info): Avoid possibility of int overflow.
12978 (read_process_output): Do adaptive read buffering even if carryover.
12979 (read_process_output): Simplify nbytes computation if buffered.
12981 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12983 * syntax.c (scan_words): Remove var that was set but not used.
12984 (update_syntax_table): Use unsigned instead of int.
12986 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12987 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12988 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12990 * print.c (print_error_message): Avoid int overflow.
12992 * font.c (font_list_entities): Redo for clarity,
12993 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12995 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12996 (font_score): Avoid potential overflow in diff calculation.
12998 * fns.c (substring_both): Remove var that is set but not used.
12999 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13001 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13003 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13004 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13005 can always succeed if overflow has undefined behavior.
13007 * search.c (boyer_moore, wordify): Remove vars set but not used.
13008 (wordify): Omit three unnecessary tests.
13010 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13011 All callers changed. This avoids the need for an unused var.
13013 * casefiddle.c (casify_region): Remove var that is set but not used.
13015 * dired.c (file_name_completion): Remove var that is set but not used.
13017 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13019 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13020 (Finsert_file_contents): Remove unnecessary code checking fd.
13022 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13023 Check for integer overflow on size calculations.
13025 * buffer.c (Fprevious_overlay_change): Remove var that is set
13028 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13029 Remove vars that are set but not used.
13030 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13031 (timer_check_2): Mark vars as initialized.
13033 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13035 * image.c (lookup_image): Remove var that is set but not used.
13036 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13038 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13039 that are set but not used.
13041 * xfns.c (make_invisible_cursor): Don't return garbage
13042 if XCreateBitmapFromData fails (Bug#8410).
13044 * xselect.c (x_get_local_selection, x_handle_property_notify):
13045 Remove vars that are set but not used.
13047 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13048 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13050 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13051 Remove var that is set but not used.
13052 (scroll_bar_windows_size): Now size_t, not int.
13053 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13054 Check for overflow.
13056 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13057 (map_tty_color) [!defined MSDOS]: Likewise.
13059 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13061 * coding.c: Remove vars that are set but not used.
13062 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13063 All callers changed.
13064 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13065 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13066 (decode_coding_charset): Remove vars that are set but not used.
13068 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13069 that is set but not used.
13071 * print.c (print_object): Remove var that is set but not used.
13073 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13074 The gnulib version avoids calling malloc in the usual case,
13075 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13076 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13077 * filelock.c (current_lock_owner): Likewise.
13078 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13079 * sysdep.c: Include allocator.h, careadlinkat.h.
13080 (emacs_no_realloc_allocator): New static constant.
13081 (emacs_readlink): New function.
13082 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13083 ../lib/careadlinkat.h.
13085 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13087 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13088 first non-nil return value).
13090 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13092 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13093 if not defined (Bug#8403).
13095 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13097 * xdisp.c (display_count_lines): Remove parameter `start',
13098 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13099 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13100 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13101 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13102 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13103 and thereabouts. All callers changed.
13104 (get_per_char_metric): Remove parameter `f', unused since
13105 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13107 2011-04-02 Jim Meyering <meyering@redhat.com>
13109 do not dereference NULL upon failed strdup
13110 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13111 (ns_get_family): Likewise.
13113 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13115 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13117 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13119 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13122 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13124 Add lexical binding.
13126 * window.c (Ftemp_output_buffer_show): New fun.
13127 (Fsave_window_excursion):
13128 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13130 * lread.c (lisp_file_lexically_bound_p): New function.
13131 (Fload): Bind Qlexical_binding.
13132 (readevalloop): Remove `evalfun' arg.
13133 Bind Qinternal_interpreter_environment.
13134 (Feval_buffer): Bind Qlexical_binding.
13135 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13137 (syms_of_lread): Declare `lexical-binding'.
13139 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13141 * keyboard.c (eval_dyn): New fun.
13142 (menu_item_eval_property): Use it.
13144 * image.c (parse_image_spec): Use Ffunctionp.
13146 * fns.c (concat, mapcar1): Accept byte-code-functions.
13148 * eval.c (Fsetq): Handle lexical vars.
13149 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13150 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13151 (FletX, Flet): Obey lexical binding.
13152 (Fcommandp): Handle closures.
13153 (Feval): New `lexical' arg.
13154 (eval_sub): New function extracted from Feval. Use it almost
13155 everywhere where Feval was used. Look up vars in lexical env.
13157 (Ffunctionp): Move from subr.el.
13158 (Ffuncall): Handle closures.
13159 (apply_lambda): Remove `eval_flags'.
13160 (funcall_lambda): Handle closures and new byte-code-functions.
13161 (Fspecial_variable_p): New function.
13162 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13163 but without exporting it to Lisp.
13165 * doc.c (Fdocumentation, store_function_docstring):
13166 * data.c (Finteractive_form): Handle closures.
13168 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13171 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13173 (exec_byte_code): New function extracted from Fbyte_code to handle new
13174 calling convention for byte-code-functions. Add new byte-codes.
13176 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13178 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13180 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13182 * xdisp.c (redisplay_internal): Fix prototype.
13184 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13186 * xdisp.c (SCROLL_LIMIT): New macro.
13187 (try_scrolling): Use it when setting scroll_limit.
13188 Limit scrolling to 100 screen lines.
13189 (redisplay_window): Even when falling back on "recentering",
13190 position point in the window according to scroll-conservatively,
13191 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13193 (try_scrolling): When point is above the window, allow searching
13194 as far as scroll_max, or one screenful, to compute vertical
13195 distance from PT to the scroll margin position. This prevents
13196 try_scrolling from unnecessarily failing when
13197 scroll-conservatively is set to a value slightly larger than the
13198 window height. Clean up the case of PT below the margin at bottom
13199 of window: scroll_max can no longer be INT_MAX. When aggressive
13200 scrolling is in use, don't let point enter the opposite scroll
13201 margin as result of the scroll.
13202 (syms_of_xdisp) <scroll-conservatively>: Document the
13203 threshold of 100 lines for never-recentering scrolling.
13205 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13207 * dispextern.h (move_it_by_lines):
13208 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13209 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13210 (message_log_check_duplicate): Remove parameters `prev_bol' and
13211 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13212 (redisplay_internal): Remove parameter `preserve_echo_area',
13213 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13215 * indent.c (Fvertical_motion):
13216 * window.c (window_scroll_pixel_based, Frecenter):
13217 Don't pass `need_y_p' to `move_it_by_lines'.
13219 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13221 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13222 steal a few bits to be more compact.
13223 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13224 Remove unneeded casts.
13226 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13228 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13230 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13231 binding" message (bug#7967).
13233 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13235 Fix more problems found by GCC 4.6.0's static checks.
13237 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13238 Remove unused local var.
13240 * editfns.c (Fmessage_box): Remove unused local var.
13242 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13243 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13244 Omit unused local vars.
13245 * window.c (shrink_windows): Omit unused local var.
13246 * menu.c (digest_single_submenu): Omit unused local var.
13247 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13248 Omit unused local var.
13250 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13251 Don't assume string length fits in int.
13252 (keyremap_step, read_key_sequence): Use size_t for sizes.
13253 (read_key_sequence): Don't check last_real_key_start redundantly.
13255 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13256 instead of alloca (Bug#8344).
13258 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13259 (Fbacktrace_frame): Don't assume nframes fits in int.
13261 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13263 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13266 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13268 * cm.c (calccost): Turn while-do into do-while, for clarity.
13270 * keyboard.c (syms_of_keyboard): Use the same style as later
13271 in this function when indexing through an array. This also
13272 works around GCC bug 48267.
13274 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13276 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13278 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13279 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13281 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13282 This avoids undefined behavior on integer overflow, and is a bit
13283 more convenient anyway since it is compared to a size_t variable.
13285 Variadic C functions now count arguments with size_t, not int.
13286 This avoids an unnecessary limitation on 64-bit machines, which
13287 caused (substring ...) to crash on large vectors (Bug#8344).
13288 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13289 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13290 All variadic functions and their callers changed accordingly.
13291 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13292 * data.c (arith_driver, float_arith_driver): Likewise.
13293 * editfns.c (general_insert_function): Likewise.
13294 * eval.c (struct backtrace.nargs, interactive_p)
13295 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13296 (funcall_lambda, mark_backtrace): Likewise.
13297 * fns.c (concat): Likewise.
13298 * frame.c (x_set_frame_parameters): Likewise.
13299 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13300 0 if not found, not -1. All callers changed.
13302 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13303 (stack_copy_size): Now size_t, not int.
13304 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13306 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13308 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13309 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13310 All callers changed.
13312 * lisp.h (multibyte_char_to_unibyte):
13313 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13314 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13315 * character.h (CHAR_TO_BYTE8):
13316 * cmds.c (internal_self_insert):
13317 * editfns.c (general_insert_function):
13318 * keymap.c (push_key_description):
13319 * search.c (Freplace_match):
13320 * xdisp.c (message_dolog, set_message_1): All callers changed.
13322 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13324 * keyboard.c (safe_run_hook_funcall): New function.
13325 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13326 don't set the hook to nil, but remove the offending function instead.
13327 (Qcommand_hook_internal): Remove, unused.
13328 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13329 Vcommand_hook_internal.
13331 * eval.c (enum run_hooks_condition): Remove.
13332 (funcall_nil, funcall_not): New functions.
13333 (run_hook_with_args): Call each function through a `funcall' argument.
13334 Remove `cond' argument, now redundant.
13335 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13336 (Frun_hook_with_args_until_failure): Adjust accordingly.
13337 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13339 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13341 * dispextern.h (string_buffer_position): Remove declaration.
13343 * print.c (strout): Remove parameter `multibyte', unused since
13344 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13346 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13347 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13348 All callers changed.
13350 * w32.c (_wsa_errlist): Use braces for struct initializers.
13352 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13353 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13354 All callers changed.
13355 (string_buffer_position): Likewise. Also, make static (it's never
13356 used outside xdisp.c).
13357 (cursor_row_p): Remove parameter `w', unused since
13358 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13359 (decode_mode_spec): Remove parameter `precision', introduced during
13360 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13361 All callers changed.
13363 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13365 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13367 2011-03-27 Anders Lindgren <andlind@gmail.com>
13369 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13370 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13371 (ns_update_auto_hide_menu_bar): New functions.
13372 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13373 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13374 ns_constrain_all_frames.
13375 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13376 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13378 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13380 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13382 2011-03-27 Glenn Morris <rgm@gnu.org>
13384 * syssignal.h: Replace RETSIGTYPE with void.
13385 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13386 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13387 Replace SIGTYPE with void everywhere.
13388 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13389 * s/template.h (SIGTYPE): Remove commented out definition.
13391 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13393 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13394 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13396 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13398 * w32.c (read_unc_volume): Use parameter `henum', instead of
13399 global variable `wget_enum_handle'.
13401 * keymap.c (describe_vector): Remove parameters `indices' and
13402 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13403 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13405 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13407 * keyboard.c (timer_check): Remove parameter `do_it_now',
13408 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13409 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13410 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13412 * keyboard.c (read_char):
13413 * w32menu.c (w32_menu_display_help):
13414 * xmenu.c (show_help_event, menu_help_callback):
13415 Adjust calls to `show_help_echo'.
13417 * gtkutil.c (xg_maybe_add_timer):
13418 * keyboard.c (readable_events):
13419 * process.c (wait_reading_process_output):
13420 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13422 * insdel.c (adjust_markers_gap_motion):
13423 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13424 (gap_left, gap_right): Don't call it.
13426 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13428 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13429 incurred during fontification.
13431 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13433 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13434 (DEFVAR_PER_BUFFER): Don't pass it.
13436 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13437 (scrolling_window): Don't pass it.
13439 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13441 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13443 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13445 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13446 of variables specific to SELinux and computation of `encoded_absname'.
13448 * image.c (XPutPixel): Remove unused variable `height'.
13450 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13452 * unexw32.c (get_section_info): Remove unused variable `section'.
13454 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13455 (system_process_attributes): Remove unused variable `sess'.
13456 (sys_read): Remove unused variable `err'.
13458 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13459 (w32_wnd_proc): Remove unused variable `isdead'.
13460 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13461 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13462 (x_create_tip_frame): Remove unused variable `tem'.
13464 * w32inevt.c (w32_console_read_socket):
13465 Remove unused variable `no_events'.
13467 * w32term.c (x_draw_composite_glyph_string_foreground):
13468 Remove unused variable `width'.
13470 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13472 * w32term.c (x_set_glyph_string_clipping):
13473 Don't pass uninitialized region to CombineRgn.
13475 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13477 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13478 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13479 (Fx_close_connection): Remove unused variable `i'.
13481 * w32font.c (w32font_draw): Return number of glyphs.
13482 (w32font_open_internal): Remove unused variable `i'.
13483 (w32font_driver): Add missing initializer.
13485 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13486 (fill_in_menu): Remove unused variable `items_added'.
13488 * w32term.c (last_mouse_press_frame): Remove static global variable.
13489 (w32_clip_to_row): Remove unused variable `f'.
13490 (x_delete_terminal): Remove unused variable `i'.
13492 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13493 (NOTHING): Remove unused static global variable.
13494 (uniscribe_check_otf): Remove unused variable `table'.
13495 (uniscribe_font_driver): Add missing initializers.
13497 2011-03-23 Julien Danjou <julien@danjou.info>
13499 * term.c (Fsuspend_tty, Fresume_tty):
13500 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13501 * window.c (temp_output_buffer_show):
13502 * insdel.c (signal_before_change):
13503 * frame.c (Fhandle_switch_frame):
13504 * fileio.c (Fdo_auto_save):
13505 * emacs.c (Fkill_emacs):
13506 * editfns.c (save_excursion_restore):
13507 * cmds.c (internal_self_insert):
13508 * callint.c (Fcall_interactively):
13509 * buffer.c (Fkill_all_local_variables):
13510 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13512 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13513 unconditionally since it does the check itself.
13515 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13517 Fix more problems found by GCC 4.5.2's static checks.
13519 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13520 the first time through the loop, since we know p0 < p1 then.
13521 This also avoids a gcc -Wstrict-overflow warning.
13523 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13524 leading to a memory leak, possible in functions like
13525 load_charset_map_from_file that can allocate an unbounded number
13526 of objects (Bug#8318).
13528 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13529 that could (at least in theory) be that large.
13531 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13532 This is less likely to overflow, and avoids undefined behavior if
13533 overflow does occur. All callers changed. Use strtoul to scan
13534 for the unsigned long integer.
13535 (pint2hrstr): Simplify and tune code slightly.
13536 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13538 * scroll.c (do_scrolling): Work around GCC bug 48228.
13539 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13541 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13542 This also avoids a warning with gcc -Wstrict-overflow.
13543 (validate_x_resource_name): Simplify count usage.
13544 This also avoids a warning with gcc -Wstrict-overflow.
13546 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13549 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13551 * process.c (Fmake_network_process): Use socklen_t, not int,
13552 where POSIX says socklen_t is required in portable programs.
13553 This fixes a porting bug on hosts like 64-bit HP-UX, where
13554 socklen_t is wider than int (Bug#8277).
13555 (Fmake_network_process, server_accept_connection):
13556 (wait_reading_process_output, read_process_output):
13559 * process.c: Rename or move locals to avoid shadowing.
13560 (list_processes_1, Fmake_network_process):
13561 (read_process_output_error_handler, exec_sentinel_error_handler):
13562 Rename or move locals.
13563 (Fmake_network_process): Define label "retry_connect" only if needed.
13564 (Fnetwork_interface_info): Fix pointer signedness.
13565 (process_send_signal): Add cast to avoid pointer signedness problem.
13566 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13567 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13569 Make tparam.h and terminfo.c consistent.
13570 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13571 Include tparam.h instead, since it declares them.
13572 * cm.h (PC): Remove extern decl; tparam.h now does this.
13573 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13574 * terminfo.c: Include tparam.h, to check interfaces.
13575 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13576 (tparam): Adjust signature to match interface in tparam.h;
13577 this removes some undefined behavior. Check that outstring and len
13578 are zero, which they always are with Emacs.
13579 * tparam.h (PC, BC, UP): New extern decls.
13581 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13582 (xftfont_open): Rename locals to avoid shadowing.
13584 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13585 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13586 (OTF_TAG_SYM): Omit macro if not needed.
13587 (ftfont_list): Remove unused local.
13588 (get_adstyle_property, ftfont_pattern_entity):
13589 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13590 Rename locals to avoid shadowing.
13592 * xfont.c (xfont_list_family): Mark var as initialized.
13594 * xml.c (make_dom): Now static.
13596 * composite.c (composition_compute_stop_pos): Rename local to
13598 (composition_reseat_it): Remove unused locals.
13599 (find_automatic_composition, composition_adjust_point): Likewise.
13600 (composition_update_it): Mark var as initialized.
13601 (find_automatic_composition): Mark vars as initialized,
13602 with a FIXME (Bug#8290).
13604 character.h: Rename locals to avoid shadowing.
13605 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13606 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13607 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13608 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13609 to avoid shadowing.
13611 * textprop.c (property_change_between_p): Remove; unused.
13613 * intervals.c (interval_start_pos): Now static.
13615 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13617 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13618 Rename locals to avoid shadowing.
13620 * sound.c (wav_play, au_play, Fplay_sound_internal):
13621 Fix pointer signedness.
13622 (alsa_choose_format): Remove unused local var.
13623 (wav_play): Initialize a variable to 0, to prevent undefined
13624 behavior (Bug#8278).
13626 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13628 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13630 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13631 clobbering (Bug#8298).
13632 * sysdep.c (sys_subshell): Likewise.
13633 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13635 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13636 This should get cleaned up, so that child_setup has the
13637 same signature on all platforms.
13639 * callproc.c (call_process_cleanup): Now static.
13640 (relocate_fd): Rename locals to avoid shadowing.
13642 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13644 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13645 not to be necessary, and produces flickering.
13647 2011-03-20 Glenn Morris <rgm@gnu.org>
13649 * config.in: Remove file.
13651 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13653 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13654 are now in src/globals.h.
13655 (syms_of_minibuf): Remove spurious & from previous change.
13657 2011-03-20 Leo Liu <sdl.web@gmail.com>
13659 * minibuf.c (completing-read-function): New variable.
13660 (completing-read-default): Rename from completing-read.
13661 (completing-read): Call completing-read-function.
13663 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13665 * xfaces.c (Fx_load_color_file):
13666 Read color file from absolute filename (bug#8250).
13668 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13670 * makefile.w32-in: Update dependencies.
13672 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13674 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13676 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13678 Fix more problems found by GCC 4.5.2's static checks.
13680 * process.c (make_serial_process_unwind, send_process_trap):
13681 (sigchld_handler): Now static.
13683 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13684 That way, the code declares only the vars that it needs.
13685 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13686 * s/cygwin.h (PTY_ITERATION): Likewise.
13687 * s/darwin.h (PTY_ITERATION): Likewise.
13688 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13690 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13691 * process.c (allocate_pty): Don't declare stb unless it's needed.
13693 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13694 (CONSTANTLIM): Remove; unused.
13695 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13696 Define only if needed.
13698 * unexelf.c (unexec): Name an expression,
13699 to avoid gcc -Wbad-function-cast warning.
13700 Use a different way to cause a compilation error if anyone uses
13701 n rather than nn, a way that does not involve shadowing.
13702 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13704 * deps.mk (unexalpha.o): Remove; unused.
13706 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13707 * unexec.h: New file.
13708 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13709 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13710 Depend on unexec.h.
13711 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13712 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13713 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13714 Change as necessary to match prototype in unexec.h.
13716 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13718 (back_comment, skip_chars): Mark vars as initialized.
13720 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13721 Rename locals to avoid shadowing.
13723 * lread.c (read1): Rewrite so as not to use empty "else".
13724 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13726 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13728 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13729 warning when compiling print.c.
13731 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13732 instead of using an uninitialized var.
13733 (font_sort_entities): Mark var as initialized.
13735 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13737 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13738 pointers to constants.
13739 (font_parse_fcname): Remove unused vars.
13740 (font_delete_unmatched): Now static.
13741 (font_get_spec): Remove; unused.
13742 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13743 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13744 Rename or move locals to avoid shadowing.
13746 * fns.c (require_nesting_list, require_unwind): Now static.
13747 (Ffillarray): Rename locals to avoid shadowing.
13749 * floatfns.c (domain_error2): Define only if needed.
13750 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13752 * alloc.c (mark_backtrace): Move decl from here ...
13753 * lisp.h: ... to here, so that it can be checked.
13755 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13756 (Fdefvar): Rewrite so as not to use empty "else".
13757 (lisp_indirect_variable): Name an expression,
13758 to avoid gcc -Wbad-function-cast warning.
13759 (Fdefvar): Rename locals to avoid shadowing.
13761 * callint.c (quotify_arg, quotify_args): Now static.
13762 (Fcall_interactively): Rename locals to avoid shadowing.
13763 Use const pointer when appropriate.
13765 * lisp.h (get_system_name, get_operating_system_release):
13766 Move decls here, to check interfaces.
13767 * process.c (get_operating_system_release): Move decl to lisp.h.
13768 * xrdb.c (get_system_name): Likewise.
13769 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13770 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13771 some of which prompt warnings from gcc -Wbad-function-cast.
13772 (Fformat_time_string, Fencode_time, Finsert_char):
13773 (Ftranslate_region_internal, Fformat):
13774 Rename or remove local vars to avoid shadowing.
13775 (Ftranslate_region_internal): Mark var as initialized.
13777 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13780 * lisp.h (eassert): Check that the argument compiles, even if
13781 ENABLE_CHECKING is not defined.
13783 * data.c (Findirect_variable): Name an expression, to avoid
13784 gcc -Wbad-function-cast warning.
13785 (default_value, arithcompare, arith_driver, arith_error): Now static.
13786 (store_symval_forwarding): Rename local to avoid shadowing.
13787 (Fmake_variable_buffer_local, Fmake_local_variable):
13788 Mark variables as initialized.
13789 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13791 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13792 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13793 Rename locals to avoid shadowing.
13794 (mark_stack): Move local variables into the #ifdef region where
13796 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13797 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13799 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13800 (GC_STRING_CHARS): Remove; not used.
13801 (Fmemory_limit): Cast sbrk's returned value to char *.
13803 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13804 avoids undefined behavior in theory.
13806 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13808 Use functions, not macros, for up- and down-casing (Bug#8254).
13809 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13810 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13811 to use the following functions instead of these macros.
13812 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13813 EMACS_INT, since callers assume the returned value fits in int.
13814 (upcase1): Likewise, for UPCASE_TABLE.
13815 (uppercasep, lowercasep, upcase): New static inline functions.
13816 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13817 the race-condition problem in the old DOWNCASE.
13819 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13820 Rename locals to avoid shadowing.
13821 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13822 (regex_compile, re_search_2, re_match_2_internal):
13823 Remove unused local vars.
13824 (FREE_VAR): Rewrite so as not to use empty "else",
13825 which gcc can warn about.
13826 (regex_compile, re_match_2_internal): Mark locals as initialized.
13827 (RETALLOC_IF): Define only if needed.
13828 (WORDCHAR_P): Likewise. This one is never needed, but is used
13829 only in a comment talking about a compiler bug, so put inside
13830 the #if 0 of that comment.
13831 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13832 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13835 * search.c (boyer_moore): Rename locals to avoid shadowing.
13836 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13837 (PREV_CHAR_BOUNDARY): Likewise.
13839 * search.c (simple_search): Remove unused var.
13841 * dired.c (compile_pattern): Move decl from here ...
13842 * lisp.h: ... to here, so that it can be checked.
13843 (struct re_registers): New forward decl.
13845 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13847 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13849 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13850 Rename locals to avoid shadowing.
13851 (Fvertical_motion): Mark locals as initialized.
13853 * casefiddle.c (casify_object, casify_region): Now static.
13854 (casify_region): Mark local as initialized.
13856 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13858 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13859 New macros, so that the caller can use some names other than
13860 gcpro1, gcpro2, etc.
13861 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13863 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13864 argument, for consistency with GCPRO2_VAR, etc: it is now the
13865 prefix of the variable, not the variable itself. All uses
13867 * dired.c (directory_files_internal, file_name_completion):
13868 Rename locals to avoid shadowing.
13870 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13871 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13872 dired.c's scmp function, had undefined behavior.
13873 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13874 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13875 * buffer.h: ... to here, because these macros use current_buffer,
13876 and the new implementation with inline functions needs to have
13877 current_buffer in scope now, rather than later when the macros
13879 (downcase, upcase1): New static inline functions.
13880 (DOWNCASE, UPCASE1): Reimplement using these functions.
13881 This avoids undefined behavior in expressions like
13882 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13883 from race conditions in accessing the global variables
13884 case_temp1 and case_temp2.
13885 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13886 * lisp.h (case_temp1, case_temp2): Remove their decls.
13887 * character.h (ASCII_CHAR_P): Move from here ...
13888 * lisp.h: ... to here, so that the inline functions mentioned
13889 above can use them.
13891 * dired.c (directory_files_internal_unwind): Now static.
13893 * fileio.c (file_name_as_directory, directory_file_name):
13894 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13896 (file_name_as_directory): Use const pointers when appropriate.
13897 (Fexpand_file_name): Likewise. In particular, newdir might
13898 point at constant storage, so make it a const pointer.
13899 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13900 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13902 (Fset_file_times, Finsert_file_contents, auto_save_error):
13903 Rename locals to avoid shadowing.
13905 * minibuf.c (choose_minibuf_frame_1): Now static.
13906 (Ftry_completion, Fall_completions): Rename or remove locals
13907 to avoid shadowing.
13909 * marker.c (bytepos_to_charpos): Remove; unused.
13911 * lisp.h (verify_bytepos, count_markers): New decls,
13912 so that gcc does not warn that these functions aren't declared.
13914 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13915 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13916 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13917 (copy_text): Remove unused local var.
13919 * filelock.c (within_one_second): Now static.
13920 (lock_file_1): Rename local to avoid shadowing.
13922 * buffer.c (fix_overlays_before): Mark locals as initialized.
13923 (fix_start_end_in_overlays): Likewise. This function should be
13924 simplified by using pointers-to-pointers, but that's a different
13926 (switch_to_buffer_1): Now static.
13927 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13928 (report_overlay_modification): Rename locals to avoid shadowing.
13930 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13931 Fix pointer signedness issue.
13932 (sys_subshell): Mark local as volatile if checking for lint,
13933 to suppress a gcc -Wclobbered warning that does not seem to be right.
13934 (MAXPATHLEN): Define only if needed.
13936 * process.c (serial_open, serial_configure): Move decls from here ...
13937 * systty.h: ... to here, so that they can be checked.
13939 * fns.c (get_random, seed_random): Move extern decls from here ...
13940 * lisp.h: ... to here, so that they can be checked.
13942 * sysdep.c (reset_io): Now static.
13943 (wait_for_termination_signal): Remove; unused.
13945 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13946 (copy_keymap_item, append_key, push_text_char_description):
13948 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13949 (DENSE_TABLE_SIZE): Remove; unused.
13950 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13951 (describe_map_tree):
13952 Rename locals to avoid shadowing.
13954 * keyboard.c: Declare functions static if they are not used elsewhere.
13955 (echo_char, echo_dash, cmd_error, top_level_2):
13956 (poll_for_input, handle_async_input): Now static.
13957 (read_char, kbd_buffer_get_event, make_lispy_position):
13958 (make_lispy_event, make_lispy_movement, apply_modifiers):
13959 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13960 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13961 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13962 (read_key_sequence, read_char): Mark locals as initialized.
13963 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13965 * keyboard.h (make_ctrl_char): New decl.
13966 (mark_kboards): Move decl here ...
13967 * alloc.c (mark_kboards): ... from here.
13969 * lisp.h (force_auto_save_soon): New decl.
13971 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13972 (DEFINE_DUMMY_FUNCTION): New macro.
13973 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13975 (main): Add casts to avoid warnings
13976 if GCC considers string literals to be constants.
13978 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13980 * dbusbind.c: Pointer signedness fixes.
13981 (xd_signature, xd_append_arg, xd_initialize):
13982 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13983 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13984 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13985 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13987 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13988 if GCC considers string literals to be constants.
13989 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13991 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13993 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13994 (print_preprocess, print_object): New macro to fix last change.
13996 * print.c (print_preprocess): Don't forget font objects.
13998 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14000 * emacs.c (USAGE3): Doc fixes.
14002 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14004 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14007 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14009 * lisp.h (VWindow_system, Qfile_name_history):
14010 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14011 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14012 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14014 * w32select.c: Don't #include "keyboard.h".
14015 (run_protected): Add extern declaration for waiting_for_input.
14017 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14018 * w32console.c (detect_input_pending, read_input_pending)
14019 (encode_terminal_code):
14020 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14021 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14022 (w32_system_caret_y, Qfile_name_history):
14023 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14024 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14025 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14026 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14027 * w32proc.c (Qlocal, report_file_error):
14028 * w32term.c (Vwindow_system, updating_frame):
14029 * w32uniscribe.c (initialized, uniscribe_font_driver):
14030 Remove unneeded extern declarations.
14032 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14034 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14036 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14038 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14039 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14040 These macros can no longer be used for assignment.
14042 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14043 Assign struct members directly, instead of using BUF_BEGV etc.
14044 (record_buffer_markers, fetch_buffer_markers): New functions for
14045 recording and fetching special buffer markers.
14046 (set_buffer_internal_1, set_buffer_temp): Use them.
14048 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14050 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14052 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14053 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14055 * xdisp.c (hscroll_window_tree):
14056 (reconsider_clip_changes): Use PT instead of BUF_PT.
14058 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14060 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14061 $(EMACS_ROOT)/lib/intprops.h.
14063 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14065 Fix more problems found by GCC 4.5.2's static checks.
14067 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14068 to unsigned char * to avoid compiler diagnostic.
14069 (xg_free_frame_widgets): Make it clear that a local variable is
14070 needed only if USE_GTK_TOOLTIP.
14071 (gdk_window_get_screen): Make it clear that this macro is needed
14072 only if USE_GTK_TOOLTIP.
14073 (int_gtk_range_get_value): New function, which avoids a diagnostic
14074 from gcc -Wbad-function-cast.
14075 (xg_set_toolkit_scroll_bar_thumb): Use it.
14076 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14077 diagnostic from gcc -Wbad-function-cast.
14078 (get_utf8_string, xg_get_file_with_chooser):
14079 Rename locals to avoid shadowing.
14080 (create_dialog): Move locals to avoid shadowing.
14082 * xgselect.c (xg_select): Remove unused var.
14084 * image.c (four_corners_best): Mark locals as initialized.
14085 (gif_load): Initialize transparent_p to zero (Bug#8238).
14086 Mark another local as initialized.
14087 (my_png_error, my_error_exit): Mark with NO_RETURN.
14089 * image.c (clear_image_cache): Now static.
14090 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14091 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14092 (x_edge_detection): Remove unnecessary cast that
14093 gcc -Wbad-function-cast diagnoses.
14094 (gif_load): Fix pointer signedness.
14095 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14096 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14098 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14100 Improve quality of tests for time stamp overflow.
14101 For example, without this patch (encode-time 0 0 0 1 1
14102 1152921504606846976) returns the obviously-bogus value (-948597
14103 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14104 reports time overflow. See
14105 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14106 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14107 * editfns.c: Include limits.h and intprops.h.
14108 (TIME_T_MIN, TIME_T_MAX): New macros.
14109 (time_overflow): Move earlier, to before first use.
14110 (hi_time, lo_time): New functions, for an accurate test for
14111 out-of-range times.
14112 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14113 (Fget_internal_run_time): Don't assume time_t fits in int.
14114 (make_time): Use list2 instead of Fcons twice.
14115 (Fdecode_time): More accurate test for out-of-range times.
14116 (check_tm_member): New function.
14117 (Fencode_time): Use it, to test for out-of-range times.
14118 (lisp_time_argument): Don't rely on undefined left-shift and
14119 right-shift behavior when checking for time stamp overflow.
14121 * editfns.c (time_overflow): New function, refactoring common code.
14122 (Fformat_time_string, Fdecode_time, Fencode_time):
14123 (Fcurrent_time_string): Use it.
14125 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14126 * dired.c (make_time): Move to ...
14127 * editfns.c (make_time): ... here.
14128 * systime.h: Note the move.
14130 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14132 * fringe.c (update_window_fringes): Remove unused variables.
14134 * unexmacosx.c (copy_data_segment): Also copy __got section.
14137 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14139 * termcap.c [MSDOS]: Include "msdos.h".
14140 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14141 Constify `char *' arguments and their references according to
14142 prototypes in tparam.h.
14144 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14146 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14147 Adapt all references accordingly.
14149 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14151 2011-03-11 Tom Tromey <tromey@redhat.com>
14153 * buffer.c (syms_of_buffer): Remove obsolete comment.
14155 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14157 * termhooks.h (encode_terminal_code): Declare prototype.
14159 * msdos.c (encode_terminal_code): Don't declare prototype.
14161 * term.c (encode_terminal_code): Now external again, used by
14162 w32console.c and msdos.c.
14164 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14165 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14167 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14169 Fix some minor problems found by GCC 4.5.2's static checks.
14171 * fringe.c (update_window_fringes): Mark locals as initialized
14173 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14175 * alloc.c (mark_fringe_data): Move decl from here ...
14176 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14177 to check its interface.
14178 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14180 * fontset.c (free_realized_fontset): Now static.
14181 (Fset_fontset_font): Rename local to avoid shadowing.
14182 (fontset_font): Mark local as initialized.
14183 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14185 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14187 * xselect.c (x_disown_buffer_selections): Remove; not used.
14188 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14189 (x_own_selection, Fx_disown_selection_internal): Rename locals
14190 to avoid shadowing.
14191 (x_handle_dnd_message): Remove local to avoid shadowing.
14193 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14194 so that the caller can use some name other than gcpro1.
14195 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14196 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14197 (Fx_backspace_delete_keys_p):
14198 Use them to avoid shadowing, and rename vars to avoid shadowing.
14199 (x_decode_color, x_set_name, x_window): Now static.
14200 (Fx_create_frame): Add braces to silence GCC warning.
14201 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14202 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14203 Remove unused locals.
14204 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14205 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14206 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14209 * xterm.h (x_mouse_leave): New decl.
14211 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14212 Remove unused functions.
14213 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14214 (x_calc_absolute_position): Now static.
14215 (XTread_socket): Don't define label "out" unless it's used.
14216 Don't declare local "event" unless it's used.
14217 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14218 unless they are used.
14219 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14220 (x_fatal_error_signal): Remove; not used.
14221 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14222 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14223 (x_error_catcher, x_connection_closed, x_error_handler):
14224 (x_error_quitter, xembed_send_message, x_iconify_frame):
14225 (my_log_handler): Rename locals to avoid shadowing.
14226 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14227 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14229 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14230 Rename or move locals to avoid shadowing.
14231 (tty_defined_color, merge_face_heights): Now static.
14232 (free_realized_faces_for_fontset): Remove; not used.
14233 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14234 does not deduce is never used uninitialized.
14235 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14236 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14238 * terminal.c (store_terminal_param): Now static.
14240 * xmenu.c (menu_highlight_callback): Now static.
14241 (set_frame_menubar): Remove unused local.
14242 (xmenu_show): Rename parameter to avoid shadowing.
14243 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14244 since they might point to immutable storage.
14245 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14246 since it's unused otherwise.
14248 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14249 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14250 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14251 avoids a gcc -Wuninitialized diagnostic.
14252 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14253 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14254 does not deduce are never used uninitialized.
14256 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14258 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14259 * window.c (window_loop, size_window):
14260 (run_window_configuration_change_hook, enlarge_window): Likewise.
14262 * window.c (display_buffer): Now static.
14263 (size_window): Mark variables that gcc -Wuninitialized
14264 does not deduce are never used uninitialized.
14265 * window.h (check_all_windows): New decl, to forestall
14266 gcc -Wmissing-prototypes diagnostic.
14267 * dispextern.h (bidi_dump_cached_states): Likewise.
14269 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14271 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14272 Include <limits.h>.
14273 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14274 and to avoid gcc -Wuninitialized warning.
14275 (load_charset_map): Mark variables that gcc -Wuninitialized
14276 does not deduce are never used uninitialized.
14277 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14279 * coding.c (coding_set_source, coding_set_destination):
14280 Use "else { /* comment */ }" rather than "else /* comment */;"
14281 for clarity, and to avoid gcc -Wempty-body warning.
14282 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14283 a block, when the outer 'i' will do.
14284 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14285 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14286 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14287 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14288 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14289 Rename locals to avoid shadowing.
14290 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14291 * coding.c (emacs_mule_char, encode_invocation_designation):
14292 Now static, since they're not used elsewhere.
14293 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14294 (decode_coding_object, encode_coding_object, detect_coding_system):
14295 (decode_coding_emacs_mule): Mark variables that gcc
14296 -Wuninitialized does not deduce are never used uninitialized.
14297 (detect_coding_iso_2022): Initialize a local variable that might
14298 be used uninitialized. Leave a FIXME because it's not clear that
14299 this initialization is needed. (Bug#8211)
14300 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14301 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14302 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14303 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14304 Remove unused macros.
14306 * category.c (hash_get_category_set): Remove unused local var.
14307 (copy_category_table): Now static, since it's not used elsewhere.
14308 * character.c (string_count_byte8): Likewise.
14310 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14311 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14313 * chartab.c (copy_sub_char_table): Now static, since it's not used
14315 (sub_char_table_ref_and_range, char_table_ref_and_range):
14316 Rename locals to avoid shadowing.
14317 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14319 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14320 (BIDI_BOB): Remove unused macro.
14322 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14323 deduce are never used uninitialized.
14324 * term.c (encode_terminal_code): Likewise.
14326 * term.c (encode_terminal_code): Now static. Remove unused local.
14328 * tparam.h: New file.
14329 * term.c, tparam.h: Include it.
14330 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14331 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14332 Move these decls to tparam.h, and make them agree with what
14333 is actually in tparam.c. The previous trick of using incompatible
14334 decls in different modules does not conform to the C standard.
14335 All callers of tparam changed to use tparam's actual API.
14336 * tparam.c (tparam1, tparam, tgoto):
14337 Use const pointers where appropriate.
14339 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14340 * cm.h (struct cm): Likewise.
14341 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14342 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14343 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14344 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14345 (turn_on_face, init_tty): Likewise.
14346 * termchar.h (struct tty_display_info): Likewise.
14348 * term.c (term_mouse_position): Rename local to avoid shadowing.
14350 * alloc.c (mark_ttys): Move decl from here ...
14351 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14353 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14355 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14357 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14359 * search.c (compile_pattern_1): Remove argument regp, unused since
14360 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14361 (compile_pattern): Don't pass it.
14363 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14365 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14366 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14368 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14370 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14372 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14373 gdk_window_get_screen, gdk_window_get_geometry,
14374 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14375 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14376 (xg_get_pixbuf_from_pixmap): New function.
14377 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14378 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14379 Call xg_get_pixbuf_from_pixmap instead of
14380 gdk_pixbuf_get_from_drawable.
14381 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14382 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14383 (xg_check_special_colors): Use GtkStyleContext and its functions
14385 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14386 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14387 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14388 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14389 Call gtk_widget_get_preferred_size.
14390 (xg_frame_resized): gdk_window_get_geometry only takes 5
14392 (xg_win_to_widget, xg_event_is_for_menubar):
14393 Call gdk_x11_window_lookup_for_display.
14394 (xg_set_widget_bg): New function.
14395 (delete_cb): New function.
14396 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14397 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14398 (xg_set_background_color): Call xg_set_widget_bg.
14399 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14400 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14401 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14402 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14404 (update_frame_tool_bar): Call gtk_widget_hide.
14405 (xg_initialize): Use GDK_KEY_g.
14407 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14409 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14411 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14412 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14413 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14415 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14417 * w32xfns.c (select_palette): Check success of RealizePalette against
14418 GDI_ERROR, not zero.
14420 See ChangeLog.11 for earlier changes.
14422 ;; Local Variables:
14426 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14428 This file is part of GNU Emacs.
14430 GNU Emacs is free software: you can redistribute it and/or modify
14431 it under the terms of the GNU General Public License as published by
14432 the Free Software Foundation, either version 3 of the License, or
14433 (at your option) any later version.
14435 GNU Emacs is distributed in the hope that it will be useful,
14436 but WITHOUT ANY WARRANTY; without even the implied warranty of
14437 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14438 GNU General Public License for more details.
14440 You should have received a copy of the GNU General Public License
14441 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.