* editfns.c (Fformat_time_string): Don't assume strlen fits in int.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2
3 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4 Report string overflow if the output is too long.
5
6 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7
8 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9 (syms_of_gnutls): Remove duplicate DEFSYM for
10 Qgnutls_bootprop_verify_hostname_error, an error for
11 Qgnutls_bootprop_verify_error (which is no longer used).
12
13 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
14 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
15 Also (re)move comments that are misplaced or no longer relevant.
16
17 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
18
19 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
20
21 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
22
23 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
24 and background color parameters if they have been changed.
25
26 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
27
28 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
29
30 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
31
32 * xsettings.c (SYSTEM_FONT): Define only when used.
33 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
34
35 * keymap.c (access_keymap_1): Now static.
36
37 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
38
39 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
40 leave any prefix arg for the up event (Bug#1586).
41
42 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
43
44 * lread.c (syms_of_lread): Mention single symbols defined by
45 `defvar' or `defconst' (bug#7154).
46
47 * fns.c (Frequire): Mention .el.gz files (bug#7314).
48 (Frequire): Mention get-load-suffixes.
49
50 2011-07-02 Martin Rudalics <rudalics@gmx.at>
51
52 * window.h (window): Remove clone_number slot.
53 * window.c (Fwindow_clone_number, Fset_window_clone_number):
54 Remove.
55 (make_parent_window, make_window, saved_window)
56 (Fset_window_configuration, save_window_save): Don't deal with
57 clone numbers.
58 * buffer.c (Qclone_number): Remove declaration.
59 (sort_overlays, overlay_strings): Don't deal with clone numbers.
60
61 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
62
63 Add multiple inheritance to keymaps.
64 * keymap.c (Fmake_composed_keymap): New function.
65 (Fset_keymap_parent): Simplify.
66 (fix_submap_inheritance): Remove.
67 (access_keymap_1): New function extracted from access_keymap to handle
68 embedded parents and handle lists of maps.
69 (access_keymap): Use it.
70 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
71 (Fcopy_keymap): Handle embedded parents.
72 (Fcommand_remapping, define_as_prefix): Simplify.
73 (Fkey_binding): Simplify.
74 (syms_of_keymap): Move minibuffer-local-completion-map,
75 minibuffer-local-filename-completion-map,
76 minibuffer-local-must-match-map, and
77 minibuffer-local-filename-must-match-map to Elisp.
78 (syms_of_keymap): Defsubr make-composed-keymap.
79 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
80 (parse_menu_item): Trivial simplification.
81
82 2011-07-01 Glenn Morris <rgm@gnu.org>
83
84 * Makefile.in (SETTINGS_LIBS): Fix typo.
85
86 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
87
88 * coding.c (Fencode_coding_string): Record the last coding system
89 used, as the function doc string says (bug#8738).
90
91 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
92
93 * xsettings.c (store_monospaced_changed): Take new font as arg and
94 check for change against current_mono_font.
95 (EMACS_TYPE_SETTINGS): Remove this and related defines.
96 (emacs_settings_constructor, emacs_settings_get_property)
97 (emacs_settings_set_property, emacs_settings_class_init)
98 (emacs_settings_init, gsettings_obj): Remove.
99 (something_changedCB): New function for HAVE_GSETTINGS.
100 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
101 with value as argument.
102 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
103 g_settings_new (Bug#8967). Do not create gsettings_obj.
104 Remove calls to g_settings_bind. Connect something_changedCB to
105 "changed".
106
107 * xgselect.c: Add defined (HAVE_GSETTINGS).
108 (xgselect_initialize): Ditto.
109
110 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
111 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
112 xg_select.
113
114 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
115
116 * eval.c (struct backtrace): Simplify and port the data structure.
117 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
118 signed bit field, as this assumption is not portable and it makes
119 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
120 "char debug_on_exit : 1" as this is not portable either; instead,
121 use the portable "unsigned int debug_on_exit : 1". Remove unused
122 member evalargs. Remove obsolete comments about cc bombing out.
123
124 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
125
126 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
127 Let HAVE_GSETTINGS override HAVE_GCONF.
128 (store_monospaced_changed): New function.
129 (EMACS_SETTINGS): A new type derived from GObject to handle
130 GSettings notifications.
131 (emacs_settings_constructor, emacs_settings_get_property)
132 (emacs_settings_set_property, emacs_settings_class_init):
133 New functions.
134 (gsettings_client, gsettings_obj): New variables.
135 (GSETTINGS_SCHEMA): New define.
136 (something_changedCB): Call store_monospaced_changed.
137 (init_gsettings): New function.
138 (xsettings_initialize): Call init_gsettings.
139 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
140 to NULL.
141
142 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
143 GCONF_CFLAGS/LIBS.
144
145 2011-06-29 Martin Rudalics <rudalics@gmx.at>
146
147 * window.c (resize_root_window, grow_mini_window)
148 (shrink_mini_window): Rename Qresize_root_window to
149 Qwindow_resize_root_window and Qresize_root_window_vertically to
150 Qwindow_resize_root_window_vertically.
151
152 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
153
154 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
155
156 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
157
158 * makefile.w32-in: Redesign dependencies so they reflect more
159 clearly which files are directly included by each source file,
160 and not through other includes.
161
162 2011-06-27 Martin Rudalics <rudalics@gmx.at>
163
164 * buffer.c (Qclone_number): Declare static and DEFSYM it.
165 (sort_overlays, overlay_strings): When an overlay's clone number
166 matches the window's clone number process the overlay even if
167 the overlay's window property doesn't match the current window.
168
169 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
170 (Fwindow_hchild): Rename to Fwindow_left_child.
171 (Fwindow_next): Rename to Fwindow_next_sibling.
172 (Fwindow_prev): Rename to Fwindow_prev_sibling.
173 (resize_window_check): Rename to window_resize_check.
174 (resize_window_apply): Rename to window_resize_apply.
175 (Fresize_window_apply): Rename to Fwindow_resize_apply.
176 (Fdelete_other_windows_internal, resize_frame_windows)
177 (Fsplit_window_internal, Fdelete_window_internal)
178 (grow_mini_window, shrink_mini_window)
179 (Fresize_mini_window_internal): Fix callers accordingly.
180
181 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
182
183 * emacsgtkfixed.h: State that this is only used with Gtk+3.
184 (emacs_fixed_set_min_size): Remove.
185 (emacs_fixed_new): Take frame as argument.
186
187 * emacsgtkfixed.c: State that this is only used with Gtk+3.
188 (_EmacsFixedPrivate): Remove minwidth/height.
189 Add struct frame *f.
190 (emacs_fixed_init): Initialize priv->f.
191 (get_parent_class, emacs_fixed_set_min_size): Remove.
192 (emacs_fixed_new): Set priv->f to argument.
193 (emacs_fixed_get_preferred_width)
194 (emacs_fixed_get_preferred_height): Use min_width/height from
195 frames size_hint to set minimum and natural (Bug#8919).
196 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
197 and use min_width/height from frames size_hint to set
198 min_width/height (Bug#8919).
199
200 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
201 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
202 indentation.
203
204 2011-06-26 Eli Zaretskii <eliz@gnu.org>
205
206 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
207 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
208 called at ZV.
209
210 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
211
212 * process.c (wait_reading_process_output): Bypass select if
213 waiting for a cell while ignoring keyboard input, and input is
214 pending. Suggested by Jan Djärv (Bug#8869).
215
216 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
217
218 Use gnulib's dup2 module instead of rolling our own.
219 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
220
221 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
222
223 * dispnew.c (scrolling_window): Before scrolling, turn off a
224 mouse-highlight in the window being scrolled.
225
226 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
227
228 Move DEFSYM to lisp.h and use everywhere.
229
230 * character.h (DEFSYM): Move declaration...
231 * lisp.h (DEFSYM): ...here.
232
233 * gnutls.c:
234 * minibuf.c:
235 * w32menu.c:
236 * w32proc.c:
237 * w32select.c: Don't include character.h.
238
239 * alloc.c (syms_of_alloc):
240 * buffer.c (syms_of_buffer):
241 * bytecode.c (syms_of_bytecode):
242 * callint.c (syms_of_callint):
243 * casefiddle.c (syms_of_casefiddle):
244 * casetab.c (init_casetab_once):
245 * category.c (init_category_once, syms_of_category):
246 * ccl.c (syms_of_ccl):
247 * cmds.c (syms_of_cmds):
248 * composite.c (syms_of_composite):
249 * dbusbind.c (syms_of_dbusbind):
250 * dired.c (syms_of_dired):
251 * dispnew.c (syms_of_display):
252 * doc.c (syms_of_doc):
253 * editfns.c (syms_of_editfns):
254 * emacs.c (syms_of_emacs):
255 * eval.c (syms_of_eval):
256 * fileio.c (syms_of_fileio):
257 * fns.c (syms_of_fns):
258 * frame.c (syms_of_frame):
259 * fringe.c (syms_of_fringe):
260 * insdel.c (syms_of_insdel):
261 * keymap.c (syms_of_keymap):
262 * lread.c (init_obarray, syms_of_lread):
263 * macros.c (syms_of_macros):
264 * msdos.c (syms_of_msdos):
265 * print.c (syms_of_print):
266 * process.c (syms_of_process):
267 * search.c (syms_of_search):
268 * sound.c (syms_of_sound):
269 * syntax.c (init_syntax_once, syms_of_syntax):
270 * terminal.c (syms_of_terminal):
271 * textprop.c (syms_of_textprop):
272 * undo.c (syms_of_undo):
273 * w32.c (globals_of_w32):
274 * window.c (syms_of_window):
275 * xdisp.c (syms_of_xdisp):
276 * xfaces.c (syms_of_xfaces):
277 * xfns.c (syms_of_xfns):
278 * xmenu.c (syms_of_xmenu):
279 * xsettings.c (syms_of_xsettings):
280 * xterm.c (syms_of_xterm): Use DEFSYM.
281
282 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
283
284 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
285
286 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
287
288 Integer and buffer overflow fixes (Bug#8873).
289
290 * print.c (printchar, strout): Check for string overflow.
291 (PRINTPREPARE, printchar, strout):
292 Don't set size unless allocation succeeds.
293
294 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
295 for sizes. Check for string overflow more accurately.
296 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
297
298 * macros.c: Integer and buffer overflow fixes.
299 * keyboard.h (struct keyboard.kbd_macro_bufsize):
300 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
301 Use ptrdiff_t, not int, for sizes.
302 Don't increment bufsize until after realloc succeeds.
303 Check for size-calculation overflow.
304 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
305
306 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
307
308 * lread.c: Integer overflow fixes.
309 (read_integer): Radix is now EMACS_INT, not int,
310 to improve quality of diagnostics for out-of-range radices.
311 Calculate buffer size correctly for out-of-range radices.
312 (read1): Check for integer overflow in radices, and in
313 read-circle numbers.
314 (read_escape): Avoid int overflow.
315 (Fload, openp, read_buffer_size, read1)
316 (substitute_object_recurse, read_vector, read_list, map_obarray):
317 Use ptrdiff_t, not int, for sizes.
318 (read1): Use EMACS_INT, not int, for sizes.
319 Check for size overflow.
320
321 * image.c (cache_image): Check for size arithmetic overflow.
322
323 * lread.c: Integer overflow issues.
324 (saved_doc_string_size, saved_doc_string_length)
325 (prev_saved_doc_string_size, prev_saved_doc_string_length):
326 Now ptrdiff_t, not int.
327 (read1): Don't assume doc string length fits in int. Check for
328 out-of-range doc string lengths.
329 (read_list): Don't assume file position fits in int.
330 (read_escape): Check for hex character overflow.
331
332 2011-06-22 Leo Liu <sdl.web@gmail.com>
333
334 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
335 Move to minibuffer.el.
336
337 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
338
339 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
340 The following patches are for when GLYPH_DEBUG && !XASSERT.
341 * dispextern.h (trace_redisplay_p, dump_glyph_string):
342 * dispnew.c (flush_stdout):
343 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
344 Mark as externally visible.
345 * dispnew.c (check_window_matrix_pointers): Now static.
346 * dispnew.c (window_to_frame_vpos):
347 * xfns.c (unwind_create_frame):
348 * xterm.c (x_check_font): Remove unused local.
349 * scroll.c (CHECK_BOUNDS):
350 * xfaces.c (cache_fache): Rename local to avoid shadowing.
351 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
352 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
353 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
354 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
355 Now static.
356 (debug_method_add): Use va_list and vsprintf rather than relying
357 on undefined behavior with wrong number of arguments.
358 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
359 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
360 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
361 since we're not interested in debugging glyphs with old libraries.
362 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
363 GCC 4.6.0's static checking.
364
365 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
366
367 Integer overflow and signedness fixes (Bug#8873).
368 A few related buffer overrun fixes, too.
369
370 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
371
372 * dispextern.h (struct face.stipple):
373 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
374 (x_bitmap_mask, x_allocate_bitmap_record)
375 (x_create_bitmap_from_data, x_create_bitmap_from_file)
376 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
377 (x_create_bitmap_from_xpm_data):
378 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
379 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
380 (.bitmaps_last):
381 * xfaces.c (load_pixmap):
382 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
383 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
384 (.bitmaps_last, struct x_output.icon_bitmap):
385 Use ptrdiff_t, not int, for bitmap indexes.
386 (x_allocate_bitmap_record): Check for size overflow.
387 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
388
389 Use ptrdiff_t, not int, for overlay counts.
390 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
391 * editfns.c (overlays_around, get_pos_property):
392 * textprop.c (get_char_property_and_overlay):
393 * xdisp.c (next_overlay_change, note_mouse_highlight):
394 * xfaces.c (face_at_buffer_position):
395 * buffer.c (OVERLAY_COUNT_MAX): New macro.
396 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
397 (Fnext_overlay_change, Fprevious_overlay_change)
398 (mouse_face_overlay_overlaps, Foverlays_in):
399 Use ptrdiff_t, not int, for sizes.
400 (overlays_at, overlays_in): Check for size-calculation overflow.
401
402 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
403
404 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
405 (x_session_initialize): Do not assume string length fits in int.
406
407 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
408 This is unlikely, but can occur if DPI is outlandish.
409
410 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
411 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
412
413 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
414 * xrdb.c (magic_file_p, search_magic_path):
415 Omit last arg SUFFIX; it was always 0. All callers changed.
416 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
417
418 * xfont.c (xfont_match): Avoid need for strlen.
419
420 * xfns.c: Don't assume strlen fits in int.
421 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
422
423 * xdisp.c (message_log_check_duplicate): Return intmax_t,
424 not unsigned long, as we prefer signed integers. All callers changed.
425 Detect integer overflow in repeat count.
426 (message_dolog): Don't assume print length fits in 39 bytes.
427 (display_mode_element): Don't assume strlen fits in int.
428
429 * termcap.c: Don't assume sizes fit in int and never overflow.
430 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
431 (gobble_line): Check for size-calculation overflow.
432
433 * minibuf.c (Fread_buffer):
434 * lread.c (intern, intern_c_string):
435 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
436 Don't assume string length fits in int.
437
438 * keyboard.c (parse_tool_bar_item):
439 * gtkutil.c (style_changed_cb): Avoid need for strlen.
440
441 * font.c: Don't assume string length fits in int.
442 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
443 Use ptrdiff_t, not int.
444 (font_intern_prop): Don't assume string length fits in int.
445 Don't assume integer property fits in fixnum.
446 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
447
448 * filelock.c: Fix some buffer overrun and integer overflow issues.
449 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
450 Reformulate so as not to need the command string.
451 Invoke gzip -cd rather than gunzip, as it's more portable.
452 (lock_info_type, lock_file_1, lock_file):
453 Don't assume pid_t and time_t fit in unsigned long.
454 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
455 (current_lock_owner): Prefer signed type for sizes.
456 Use memcpy, not strncpy, where memcpy is what is really wanted.
457 Don't assume (via atoi) that time_t and pid_t fit in int.
458 Check for time_t and/or pid_t out of range, e.g., via a network share.
459 Don't alloca where an auto var works fine.
460
461 * fileio.c: Fix some integer overflow issues.
462 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
463 Don't assume string length fits in int.
464 (directory_file_name): Don't assume string length fits in long.
465 (make_temp_name): Don't assume pid fits in int, or that its print
466 length is less than 20.
467
468 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
469
470 * coding.c (make_subsidiaries): Don't assume string length fits in int.
471
472 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
473
474 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
475 We prefer signed integers, even for size calculations.
476
477 * emacs.c: Don't assume string length fits in 'int'.
478 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
479 (main): Don't invoke strlen when not needed.
480
481 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
482 (XD_DEBUG_MESSAGE): Don't waste a byte.
483
484 * callproc.c (getenv_internal_1, getenv_internal)
485 (Fgetenv_internal):
486 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
487
488 * lread.c (invalid_syntax): Omit length argument.
489 All uses changed. This doesn't fix a bug, but it simplifies the
490 code away from its former Hollerith-constant appearance, and it's
491 one less 'int' to worry about when looking at integer-overflow issues.
492 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
493
494 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
495 This didn't break anything, but it didn't help either.
496 It's confusing to put a bogus integer in a place where the actual
497 value does not matter.
498 (LIST_END_P): Remove unused macro and its bogus comment.
499 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
500
501 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
502 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
503 implementation.
504 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
505 We prefer signed types, and the value cannot exceed the EMACS_INT
506 range anyway (because otherwise the length would not be representable).
507 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
508 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
509 This avoids a GCC warning when WIDE_EMACS_INT.
510
511 * indent.c (sane_tab_width): New function.
512 (current_column, scan_for_column, Findent_to, position_indentation)
513 (compute_motion): Use it. This is just for clarity.
514 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
515
516 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
517
518 * lisp.h (lint_assume): New macro.
519 * composite.c (composition_gstring_put_cache):
520 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
521
522 * editfns.c, insdel.c:
523 Omit unnecessary forward decls, to simplify future changes.
524
525 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
526
527 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
528
529 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
530 Use much-faster test for byte-length change.
531 Don't assume string byte-length fits in 'int'.
532 Check that character arg fits in 'int'.
533 (mapcar1): Declare byte as byte, for clarity.
534
535 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
536
537 * fns.c (concat): Catch string overflow earlier.
538 Do not rely on integer wraparound.
539
540 * dispextern.h (struct it.overlay_strings_charpos)
541 (struct it.selective): Now EMACS_INT, not int.
542 * xdisp.c (forward_to_next_line_start)
543 (back_to_previous_visible_line_start)
544 (reseat_at_next_visible_line_start, next_element_from_buffer):
545 Don't arbitrarily truncate the value of 'selective' to int.
546
547 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
548
549 * composite.c: Don't truncate sizes to 'int'.
550 (composition_gstring_p, composition_reseat_it)
551 (composition_adjust_point): Use EMACS_INT, not int.
552 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
553 not EMACS_UINT, for indexes.
554
555 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
556
557 * buffer.c: Include <verify.h>.
558 (struct sortvec.priority, struct sortstr.priority):
559 Now EMACS_INT, not int.
560 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
561 (struct sortstr.size, record_overlay_string)
562 (struct sortstrlist.size, struct sortlist.used):
563 Don't truncate size to int.
564 (record_overlay_string): Check for size-calculation overflow.
565 (init_buffer_once): Check at compile-time, not run-time.
566
567 2011-06-22 Jim Meyering <meyering@redhat.com>
568
569 Don't leak an XBM-image-sized buffer
570 * image.c (xbm_load): Free the image buffer after using it.
571
572 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
573
574 Port to Sun C.
575 * composite.c (find_automatic_composition): Omit needless 'return 0;'
576 that Sun C diagnosed.
577 * fns.c (secure_hash): Fix pointer signedness issue.
578 * intervals.c (static_offset_intervals): New function.
579 (offset_intervals): Use it.
580
581 2011-06-21 Leo Liu <sdl.web@gmail.com>
582
583 * deps.mk (fns.o):
584 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
585 sha512.h.
586
587 * fns.c (secure_hash): Rename from crypto_hash_function and change
588 the first arg to accept symbols.
589 (Fsecure_hash): New primitive.
590 (syms_of_fns): New symbols.
591
592 2011-06-20 Deniz Dogan <deniz@dogan.se>
593
594 * process.c (Fset_process_buffer): Clarify return value in
595 docstring.
596
597 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
598
599 * dispnew.c (add_window_display_history): Use BVAR.
600
601 * xdisp.c (debug_method_add): Use BVAR.
602 (check_window_end, dump_glyph_matrix, dump_glyph)
603 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
604
605 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
606 Likewise.
607
608 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
609 check till after the cache is created in init_frame_faces.
610
611 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
612
613 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
614
615 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
616
617 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
618 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
619 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
620
621 Improve buffer-overflow checking (Bug#8873).
622 * fileio.c (Finsert_file_contents):
623 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
624 Remove the old (too-loose) buffer overflow checks.
625 They weren't needed, since make_gap checks for buffer overflow.
626 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
627 The old code merely checked for Emacs fixnum overflow, and relied
628 on undefined (wraparound) behavior. The new code avoids undefined
629 behavior, and also checks for ptrdiff_t and/or size_t overflow.
630
631 * editfns.c (Finsert_char): Don't dump core with very negative counts.
632 Tune. Don't use wider integers than needed. Don't use alloca.
633 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
634
635 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
636
637 * insdel.c, lisp.h (buffer_overflow): New function.
638 (insert_from_buffer_1, replace_range, replace_range_2):
639 * insdel.c (make_gap_larger):
640 * editfns.c (Finsert_char):
641 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
642
643 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
644
645 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
646
647 Integer overflow and signedness fixes (Bug#8873).
648
649 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
650 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
651
652 * fileio.c: Don't assume EMACS_INT fits in off_t.
653 (emacs_lseek): New static function.
654 (Finsert_file_contents, Fwrite_region): Use it.
655 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
656
657 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
658
659 * fns.c: Don't overflow int when computing a list length.
660 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
661 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
662 truncation on 64-bit hosts. Check for QUIT every
663 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
664 faster and is responsive enough.
665 (Flength): Report an error instead of overflowing an integer.
666 (Fsafe_length): Return a float if the value is not representable
667 as a fixnum. This shouldn't happen except in contrived situations.
668 (Fnthcdr, Fsort): Don't assume list length fits in int.
669 (Fcopy_sequence): Don't assume vector length fits in int.
670
671 * alloc.c: Check that resized vectors' lengths fit in fixnums.
672 (header_size, word_size): New constants.
673 (allocate_vectorlike): Don't check size overflow here.
674 (allocate_vector): Check it here instead, since this is the only
675 caller of allocate_vectorlike that could cause overflow.
676 Check that the new vector's length is representable as a fixnum.
677
678 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
679 The previous code was bogus. For example, next_almost_prime (32)
680 returned 39, which is undesirable as it is a multiple of 3; and
681 next_almost_prime (24) returned 25, which is a multiple of 5 so
682 why was the code bothering to check for multiples of 7?
683
684 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
685
686 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
687
688 Variadic C functions now count arguments with ptrdiff_t.
689 This partly undoes my 2011-03-30 change, which replaced int with size_t.
690 Back then I didn't know that the Emacs coding style prefers signed int.
691 Also, in the meantime I found a few more instances where arguments
692 were being counted with int, which may truncate counts on 64-bit
693 machines, or EMACS_INT, which may be unnecessarily wide.
694 * lisp.h (struct Lisp_Subr.function.aMANY)
695 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
696 Arg counts are now ptrdiff_t, not size_t.
697 All variadic functions and their callers changed accordingly.
698 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
699 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
700 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
701 * callint.c (Fcall_interactively): Check arg count for overflow,
702 to avoid potential buffer overrun. Use signed char, not 'int',
703 for 'varies' array, so that we needn't bother to check its size
704 calculation for overflow.
705 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
706 * eval.c (apply_lambda):
707 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
708 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
709 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
710
711 * callint.c (Fcall_interactively): Don't use index var as event count.
712
713 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
714 * mem-limits.h (SIZE): Remove; no longer used.
715
716 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
717
718 Remove unnecessary casts.
719 * xterm.c (x_term_init):
720 * xfns.c (x_set_border_pixel):
721 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
722 These aren't needed now that we assume ANSI C.
723
724 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
725 It's more likely to cause problems (due to unsigned overflow)
726 than to cure them.
727
728 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
729
730 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
731
732 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
733
734 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
735
736 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
737
738 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
739
740 GLYPH_CODE_FACE returns EMACS_INT, not int.
741 * dispextern.h (merge_faces):
742 * xfaces.c (merge_faces):
743 * xdisp.c (get_next_display_element, next_element_from_display_vector):
744 Don't assume EMACS_INT fits in int.
745
746 * character.h (CHAR_VALID_P): Remove unused parameter.
747 * fontset.c, lisp.h, xdisp.c: All uses changed.
748
749 * editfns.c (Ftranslate_region_internal): Omit redundant test.
750
751 * fns.c (concat): Minor tuning based on overflow analysis.
752 This doesn't fix any bugs. Use int to hold character, instead
753 of constantly refetching from Emacs object. Use XFASTINT, not
754 XINT, for value known to be a character. Don't bother comparing
755 a single byte to 0400, as it's always less.
756
757 * floatfns.c (Fexpt):
758 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
759
760 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
761 for characters.
762
763 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
764
765 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
766 Without this fix, on a 64-bit host (aset S 0 4294967386) would
767 incorrectly succeed when S was a string, because 4294967386 was
768 truncated before it was used.
769
770 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
771 Otherwise, an out-of-range integer could cause undefined behavior
772 on a 64-bit host.
773
774 * composite.c: Use int, not EMACS_INT, for characters.
775 (fill_gstring_body, composition_compute_stop_pos): Use int, not
776 EMACS_INT, for values that are known to be in character range.
777 This doesn't fix any bugs but is the usual style inside Emacs and
778 may generate better code on 32-bit machines.
779
780 Make sure a 64-bit char is never passed to ENCODE_CHAR.
781 This is for reasons similar to the recent CHAR_STRING fix.
782 * charset.c (Fencode_char): Check that character arg is actually
783 a character. Pass an int to ENCODE_CHAR.
784 * charset.h (ENCODE_CHAR): Verify that the character argument is no
785 wider than 'int', as a compile-time check to prevent future regressions
786 in this area.
787
788 * character.c (char_string): Remove unnecessary casts.
789
790 Make sure a 64-bit char is never passed to CHAR_STRING.
791 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
792 by silently ignoring the top 32 bits, allowing some values
793 that were far too large to be valid characters.
794 * character.h: Include <verify.h>.
795 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
796 arguments are no wider than unsigned, as a compile-time check
797 to prevent future regressions in this area.
798 * data.c (Faset):
799 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
800 (Fsubst_char_in_region):
801 * fns.c (concat):
802 * xdisp.c (decode_mode_spec_coding):
803 Adjust to CHAR_STRING's new requirement.
804 * editfns.c (Finsert_char, Fsubst_char_in_region):
805 * fns.c (concat): Check that character args are actually
806 characters. Without this test, these functions did the wrong
807 thing with wildly out-of-range values on 64-bit hosts.
808
809 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
810 These casts should not be needed on 32-bit hosts, either.
811 * keyboard.c (read_char):
812 * lread.c (Fload): Remove casts to unsigned.
813
814 * lisp.h (UNSIGNED_CMP): New macro.
815 This fixes comparison bugs on 64-bit hosts.
816 (ASCII_CHAR_P): Use it.
817 * casefiddle.c (casify_object):
818 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
819 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
820 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
821 * dispextern.h (FACE_FROM_ID):
822 * keyboard.c (read_char): Use UNSIGNED_CMP.
823
824 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
825 not to EMACS_INT, to avoid GCC warning.
826
827 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
828
829 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
830 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
831 isn't needed on 32-bit machines.
832
833 * buffer.c (Fgenerate_new_buffer_name):
834 Use EMACS_INT for count, not int.
835 (advance_to_char_boundary): Return EMACS_INT, not int.
836
837 * data.c (Qcompiled_function): Now static.
838
839 * window.c (window_body_lines): Now static.
840
841 * image.c (gif_load): Rename local to avoid shadowing.
842
843 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
844 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
845 * alloc.c (make_save_value): Integer argument is now of type
846 ptrdiff_t, not int.
847 (mark_object): Use ptrdiff_t, not int.
848 * lisp.h (pD): New macro.
849 * print.c (print_object): Use it.
850
851 * alloc.c: Use EMACS_INT, not int, to count objects.
852 (total_conses, total_markers, total_symbols, total_vector_size)
853 (total_free_conses, total_free_markers, total_free_symbols)
854 (total_free_floats, total_floats, total_free_intervals)
855 (total_intervals, total_strings, total_free_strings):
856 Now EMACS_INT, not int. All uses changed.
857 (Fgarbage_collect): Compute overall total using a double, so that
858 integer overflow is less likely to be a problem. Check for overflow
859 when converting back to an integer.
860 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
861 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
862 These were 'int' variables that could overflow on 64-bit hosts;
863 they were never used, so remove them instead of repairing them.
864 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
865 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
866 Previously, this ceilinged at INT_MAX, but that doesn't work on
867 64-bit machines.
868 (allocate_pseudovector): Don't use EMACS_INT when int would do.
869
870 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
871 (allocate_vectorlike): Check for ptrdiff_t overflow.
872 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
873 when a (possibly-narrower) signed value would do just as well.
874 We prefer using signed arithmetic, to avoid comparison confusion.
875
876 * alloc.c: Catch some string size overflows that we were missing.
877 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
878 for convenience in STRING_BYTES_MAX.
879 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
880 The definition here is exact; the one in lisp.h was approximate.
881 (allocate_string_data): Check for string overflow. This catches
882 some instances we weren't catching before. Also, it catches
883 size_t overflow on (unusual) hosts where SIZE_MAX <= min
884 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
885 and ptrdiff_t and EMACS_INT are both 64 bits.
886
887 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
888 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
889 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
890
891 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
892
893 * alloc.c (Fmake_string): Check for out-of-range init.
894
895 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
896
897 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
898
899 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
900
901 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
902 xg_get_default_scrollbar_width.
903
904 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
905 (int_gtk_range_get_value): Move to the scroll bar part of the file.
906 (style_changed_cb): Call update_theme_scrollbar_width and call
907 x_set_scroll_bar_default_width and xg_frame_set_char_size for
908 all frames (Bug#8505).
909 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
910 Call gtk_window_set_resizable if HAVE_GTK3.
911 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
912 and height if HAVE_GTK3 (Bug#8505).
913 (scroll_bar_width_for_theme): New variable.
914 (update_theme_scrollbar_width): New function.
915 (xg_get_default_scrollbar_width): Move code to
916 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
917 (xg_initialize): Call update_theme_scrollbar_width.
918
919 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
920
921 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
922
923 2011-06-12 Martin Rudalics <rudalics@gmx.at>
924
925 * frame.c (make_frame): Call other_buffer_safely instead of
926 other_buffer.
927
928 * window.c (temp_output_buffer_show): Call display_buffer with
929 second argument Vtemp_buffer_show_specifiers and reset latter
930 immediately after the call.
931 (Vtemp_buffer_show_specifiers): New variable.
932 (auto_window_vscroll_p, next_screen_context_lines)
933 (Vscroll_preserve_screen_position): Remove leading asterisks from
934 doc-strings.
935
936 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
937
938 Fix minor problems found by GCC 4.6.0 static checking.
939 * buffer.c (Qclone_number): Remove for now, as it's unused.
940 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
941 (record_buffer): Remove unused local.
942 * frame.c (other_visible_frames, frame_buffer_list): Now static.
943 (set_frame_buffer_list): Remove; unused.
944 * frame.h (other_visible_frames): Remove decl.
945 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
946 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
947 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
948 if HAVE_GPM.
949 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
950 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
951 Define only if HAVE_GPM.
952 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
953 (update_hints_inhibit): Remove; never set. All uses removed.
954 * widgetprv.h (emacsFrameClassRec): Remove decl.
955 * window.c (delete_deletable_window): Now returns void, since it
956 wasn't returning anything.
957 (compare_window_configurations): Remove unused locals.
958 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
959 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
960 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
961 the same widths as pointers. This follows up on the 2011-05-06 patch.
962 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
963 * xterm.h: Likewise.
964 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
965
966 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
967
968 * makefile.w32-in: Update dependencies.
969 (LISP_H): Add lib/intprops.h.
970
971 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
972
973 * image.c (gif_load): Add animation frame delay to the metadata.
974 (syms_of_image): Use DEFSYM. New symbol `delay'.
975
976 2011-06-11 Martin Rudalics <rudalics@gmx.at>
977
978 * window.c (delete_deletable_window): Re-add.
979 (Fset_window_configuration): Rewrite to handle dead buffers and
980 consequently deletable windows.
981 (window_tree, Fwindow_tree): Remove. Supply functionality in
982 window.el.
983 (compare_window_configurations): Simplify code.
984
985 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
986
987 * image.c (imagemagick_load_image): Fix type mismatch.
988 (Fimagemagick_types): Likewise.
989
990 * window.h (replace_buffer_in_windows): Declare.
991
992 2011-06-11 Martin Rudalics <rudalics@gmx.at>
993
994 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
995 Qclone_number. Remove external declaration of Qdelete_window.
996 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
997 code.
998 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
999 Qbuffer_list_update_hook if allowed.
1000 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1001 buffer list implementation.
1002 (other_buffer_safely): New function.
1003 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1004 calls to replace_buffer_in_windows and
1005 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1006 if allowed.
1007 (record_buffer): Inhibit quitting and rewrite using quittable
1008 functions. Run Qbuffer_list_update_hook if allowed.
1009 (Frecord_buffer, Funrecord_buffer): New functions.
1010 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1011 switch-to-buffer to window.el.
1012 (bury-buffer): Move to window.el.
1013 (Vbuffer_list_update_hook): New variable.
1014
1015 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1016 section.
1017
1018 * window.h (resize_frame_windows): Move up in code.
1019 (Fwindow_frame): Remove EXFUN.
1020 (replace_buffer_in_all_windows): Remove prototype.
1021 (replace_buffer_in_windows_safely): Add prototype.
1022
1023 * window.c: Declare Qdelete_window static again. Move down
1024 declaration of select_count.
1025 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1026 (Fother_window): Move to window.el.
1027 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1028 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1029 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1030 window.el.
1031 (replace_buffer_in_windows): Implement by calling
1032 Qreplace_buffer_in_windows.
1033 (replace_buffer_in_all_windows): Remove with some functionality
1034 moved into replace_buffer_in_windows_safely.
1035 (replace_buffer_in_windows_safely): New function.
1036 (select_window_norecord, select_frame_norecord): Move in front
1037 of run_window_configuration_change_hook. Remove now obsolete
1038 declarations.
1039 (Fset_window_buffer): Rewrite doc-string. Call
1040 Qrecord_window_buffer.
1041 (keys_of_window): Move binding for other-window to window.el.
1042
1043 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1044
1045 * dispextern.h (struct image): Replace data member, whose int_val
1046 and ptr_val fields were not used by anything, with a single
1047 lisp_val object.
1048
1049 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1050 (gif_clear_image, gif_load, imagemagick_load_image)
1051 (gs_clear_image, gs_load): Callers changed.
1052
1053 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 * buffer.h: Include <time.h>, for time_t.
1056 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1057
1058 Fix minor problems found by static checking.
1059
1060 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1061
1062 Make identifiers static if they are not used in other modules.
1063 * data.c (Qcompiled_function, Qframe, Qvector):
1064 * image.c (QimageMagick, Qsvg):
1065 * minibuf.c (Qmetadata):
1066 * window.c (resize_window_check, resize_root_window): Now static.
1067 * window.h (resize_window_check, resize_root_window): Remove decls.
1068
1069 * window.c (window_deletion_count, delete_deletable_window):
1070 Remove; unused.
1071 (window_body_lines): Now static.
1072 (Fdelete_other_windows_internal): Mark vars as initialized.
1073 Make sure 'resize_failed' is initialized.
1074 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1075 (resize_window_apply): Remove unused local.
1076 * window.h (delete_deletable_window): Remove decl.
1077
1078 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1079 (imagemagick_load_image): Fix pointer signedness problem by changing
1080 last arg from unsigned char * to char *. All uses changed.
1081 Also, fix a local for similar reasons.
1082 Remove unused locals. Remove locals to avoid shadowing.
1083 (fn_rsvg_handle_free): Remove; unused.
1084 (svg_load, svg_load_image): Fix pointer signedness problem.
1085 (imagemagick_load_image): Don't use garbage pointer image_wand.
1086
1087 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1088
1089 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1090
1091 * image.c (gif_load): Fix omitted cast error introduced by
1092 2011-06-06 change.
1093
1094 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1095
1096 * window.h (resize_proportionally, orig_total_lines)
1097 (orig_top_line): Remove from window structure.
1098 (set_window_height, set_window_width, change_window_heights)
1099 (Fdelete_window): Remove prototypes.
1100 (resize_frame_windows): Remove duplicate declaration.
1101
1102 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1103
1104 * window.h (resize_frame_windows, resize_window_check)
1105 (delete_deletable_window, resize_root_window)
1106 (resize_frame_windows): Declare prototypes.
1107
1108 * window.c (resize_window_apply): Make definition be "static" to
1109 match the prototype.
1110
1111 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1112
1113 * window.c: Remove declarations of Qwindow_size_fixed,
1114 window_min_size_1, window_min_size_2, window_min_size,
1115 size_window, window_fixed_size_p, enlarge_window, delete_window.
1116 Remove static from declaration of Qdelete_window, it's
1117 temporarily needed by Fbury_buffer.
1118 (replace_window): Don't assign orig_top_line and
1119 orig_total_lines.
1120 (Fdelete_window, delete_window): Remove. Window deletion is
1121 handled by window.el.
1122 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1123 Fdelete_window calls with calls to Qdelete_window.
1124 (Fdelete_other_windows): Remove. Deleting other windows is
1125 handled by window.el.
1126 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1127 handled in window.el.
1128 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1129 Window minimum sizes are handled in window.el.
1130 (shrink_windows, size_window, set_window_height)
1131 (set_window_width, change_window_heights, window_height)
1132 (window_width, CURBEG, CURSIZE, enlarge_window)
1133 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1134 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1135 handled in window.el.
1136 (make_dummy_parent): Rename to make_parent_window and give it a
1137 second argument horflag.
1138 (make_window): Don't set resize_proportionally any more.
1139 (Fsplit_window): Remove. Windows are split in window.el.
1140 (save_restore_action, save_restore_orig_size)
1141 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1142 Resize mini windows in window.el.
1143 (grow_mini_window, shrink_mini_window): Implement by calling
1144 Qresize_root_window_vertically, resize_window_check and
1145 resize_window_apply.
1146 (saved_window, Fset_window_configuration, save_window_save): Do
1147 not handle orig_top_line, orig_total_lines, and
1148 resize_proportionally.
1149 (window_min_height, window_min_width): Move to window.el.
1150 (keys_of_window): Move bindings for delete-other-windows,
1151 split-window, delete-window and enlarge-window to window.el.
1152
1153 * buffer.c: Temporarily extern Qdelete_window.
1154 (Fbury_buffer): Temporarily call Qdelete_window instead of
1155 Fdelete_window (Fbury_buffer will move to window.el soon).
1156
1157 * frame.c (set_menu_bar_lines_1): Remove code handling
1158 orig_top_line and orig_total_lines.
1159
1160 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1161 set_window_height but set heights directly.
1162 (change_frame_size_1): Use resize_frame_windows.
1163
1164 * xdisp.c (init_xdisp): Don't use set_window_height but set
1165 heights directly.
1166
1167 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1168 resize_frame_windows instead of change_window_heights and run
1169 run_window_configuration_change_hook.
1170
1171 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1172 instead of change_window_heights and run
1173 run_window_configuration_change_hook.
1174
1175 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1176
1177 * window.c (replace_window): Rename second argument REPLACEMENT to
1178 NEW. New third argument SETFLAG. Rewrite.
1179 (delete_window, make_dummy_parent): Call replace_window with
1180 third argument 1.
1181 (window_list_1): Move down in code.
1182 (run_window_configuration_change_hook): Move set_buffer part
1183 before select_frame_norecord part in order to unwind correctly.
1184 Rename count1 to count.
1185 (recombine_windows, delete_deletable_window, resize_root_window)
1186 (Fdelete_other_windows_internal)
1187 (Frun_window_configuration_change_hook, make_parent_window)
1188 (resize_window_check, resize_window_apply, Fresize_window_apply)
1189 (resize_frame_windows, Fsplit_window_internal)
1190 (Fdelete_window_internal, Fresize_mini_window_internal): New
1191 functions.
1192 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1193
1194 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1195
1196 * window.h (window): Add some new members to window structure -
1197 normal_lines, normal_cols, new_total, new_normal, clone_number,
1198 splits, nest, prev_buffers, next_buffers.
1199 (WINDOW_TOTAL_SIZE): Move here from window.c.
1200 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1201
1202 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1203 Remove.
1204 (make_dummy_parent): Set new members of windows structure.
1205 (make_window): Move down in code. Handle new members of window
1206 structure.
1207 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1208 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1209 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1210 (Fset_window_prev_buffers, Fwindow_next_buffers)
1211 (Fset_window_next_buffers, Fset_window_clone_number): New
1212 functions.
1213 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1214 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1215 Doc-string fixes.
1216 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1217 Argument WINDOW can be now internal window too.
1218 (Fwindow_use_time): Move up in code.
1219 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1220 Rewrite doc-string.
1221 (Fset_window_configuration, saved_window)
1222 (Fcurrent_window_configuration, save_window_save): Handle new
1223 members of window structure.
1224 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1225 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1226 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1227 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1228 Qget_mru_window, Qresize_root_window,
1229 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1230 Qauto_buffer_name; staticpro them.
1231
1232 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1233
1234 * window.c (Fwindow_total_size, Fwindow_left_column)
1235 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1236 (Fwindow_list_1): New functions.
1237 (window_box_text_cols): Replace with window_body_cols.
1238 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1239 window_body_cols instead of window_box_text_cols.
1240 (delete_window, Fset_window_configuration): Call
1241 delete_all_subwindows with window as argument.
1242 (delete_all_subwindows): Take a window as argument and not a
1243 structure. Rewrite.
1244 (window_loop): Remove handling of GET_LRU_WINDOW and
1245 GET_LARGEST_WINDOW.
1246 (Fget_lru_window, Fget_largest_window): Move to window.el.
1247
1248 * window.h: Extern window_body_cols instead of
1249 window_box_text_cols. delete_all_subwindows now takes a
1250 Lisp_Object as argument.
1251
1252 * indent.c (compute_motion, Fcompute_motion): Use
1253 window_body_cols instead of window_box_text_cols.
1254
1255 * frame.c (delete_frame): Call delete_all_subwindows with root
1256 window as argument.
1257
1258 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1259
1260 * fns.c (Fputhash): Document return value.
1261
1262 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1263
1264 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1265
1266 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1267
1268 Cons<->int and similar integer overflow fixes (Bug#8794).
1269
1270 Check for overflow when converting integer to cons and back.
1271 * charset.c (Fdefine_charset_internal, Fdecode_char):
1272 Use cons_to_unsigned to catch overflow.
1273 (Fencode_char): Use INTEGER_TO_CONS.
1274 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1275 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1276 * data.c (long_to_cons, cons_to_long): Remove.
1277 (cons_to_unsigned, cons_to_signed): New functions.
1278 These signal an error for invalid or out-of-range values.
1279 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1280 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1281 * font.c (Ffont_variation_glyphs):
1282 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1283 * lisp.h: Include <intprops.h>.
1284 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1285 (cons_to_signed, cons_to_unsigned): New decls.
1286 (long_to_cons, cons_to_long): Remove decls.
1287 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1288 (Fprimitive_undo): Use CONS_TO_INTEGER.
1289 * xfns.c (Fx_window_property): Likewise.
1290 * xselect.c: Include <limits.h>.
1291 (x_own_selection, selection_data_to_lisp_data):
1292 Use INTEGER_TO_CONS.
1293 (x_handle_selection_request, x_handle_selection_clear)
1294 (x_get_foreign_selection, Fx_disown_selection_internal)
1295 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1296 (lisp_data_to_selection_data): Use cons_to_unsigned.
1297 (x_fill_property_data): Use cons_to_signed.
1298 Report values out of range.
1299
1300 Check for buffer and string overflow more precisely.
1301 * buffer.h (BUF_BYTES_MAX): New macro.
1302 * lisp.h (STRING_BYTES_MAX): New macro.
1303 * alloc.c (Fmake_string):
1304 * character.c (string_escape_byte8):
1305 * coding.c (coding_alloc_by_realloc):
1306 * doprnt.c (doprnt):
1307 * editfns.c (Fformat):
1308 * eval.c (verror):
1309 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1310 since they may not be the same number.
1311 * editfns.c (Finsert_char):
1312 * fileio.c (Finsert_file_contents):
1313 Likewise for BUF_BYTES_MAX.
1314
1315 * image.c: Use ptrdiff_t, not int, for sizes.
1316 (slurp_file): Switch from int to ptrdiff_t.
1317 All uses changed.
1318 (slurp_file): Check that file size fits in both size_t (for
1319 malloc) and ptrdiff_t (for sanity and safety).
1320
1321 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1322 if b->modtime has its maximal value.
1323
1324 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1325
1326 Don't assume time_t can fit into int.
1327 * buffer.h (struct buffer.modtime): Now time_t, not int.
1328 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1329 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1330
1331 Minor fixes for signed vs unsigned integers.
1332 * character.h (MAYBE_UNIFY_CHAR):
1333 * charset.c (maybe_unify_char):
1334 * keyboard.c (read_char, reorder_modifiers):
1335 XINT -> XFASTINT, since the integer must be nonnegative.
1336 * ftfont.c (ftfont_spec_pattern):
1337 * keymap.c (access_keymap, silly_event_symbol_error):
1338 XUINT -> XFASTINT, since the integer must be nonnegative.
1339 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1340 since it makes no difference and we prefer signed.
1341 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1342 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1343 nonnegative.
1344
1345 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1346
1347 * window.h (Fwindow_frame): Declare.
1348
1349 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1350
1351 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1352 (SPARE_MEMORY): Always define.
1353 (LARGE_REQUEST): Remove.
1354 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1355
1356 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1357
1358 * lisp.h: Move EXFUNS for Fframe_root_window,
1359 Fframe_first_window and Fset_frame_selected_window to window.h.
1360
1361 * window.h: Move EXFUNS for Fframe_root_window,
1362 Fframe_first_window and Fset_frame_selected_window here from
1363 lisp.h.
1364
1365 * frame.c (Fwindow_frame, Fframe_first_window)
1366 (Fframe_root_window, Fframe_selected_window)
1367 (Fset_frame_selected_window): Move to window.c.
1368 (Factive_minibuffer_window): Move to minibuf.c.
1369 (Fother_visible_frames_p): New function.
1370
1371 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1372
1373 * window.c (decode_window, decode_any_window): Move up in code.
1374 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1375 (inhibit_frame_unsplittable): Remove unused variable.
1376 (Fwindow_buffer): Move up and rewrite doc-string.
1377 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1378 (Fwindow_prev): New functions.
1379 (Fwindow_frame): Move here from frame.c. Accept any window as
1380 argument.
1381 (Fframe_root_window, Fframe_first_window)
1382 (Fframe_selected_window): Move here from frame.c. Accept frame
1383 or arbitrary window as argument. Update doc-strings.
1384 (Fminibuffer_window): Move up in code.
1385 (Fwindow_minibuffer_p): Move up in code and simplify.
1386 (Fset_frame_selected_window): Move here from frame.c.
1387 Marginal rewrite.
1388 (Fselected_window, select_window, Fselect_window): Move up in
1389 code. Minor doc-string fixes.
1390
1391 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1394 Do not assume that spare memory exists; that assumption is valid
1395 only if SYSTEM_MALLOC.
1396 (LARGE_REQUEST): New macro, so that the issue of large requests
1397 is separated from the issue of spare memory.
1398
1399 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1400
1401 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1402 format. (Bug#8806)
1403
1404 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1405
1406 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1407 before statements.
1408
1409 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1410
1411 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1412
1413 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1414
1415 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1416 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1417
1418 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1419
1420 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1421
1422 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1423
1424 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1425 (x_clipboard_manager_save): Add return value.
1426 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1427 New error handlers.
1428 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1429 Obey Vx_select_enable_clipboard_manager. Catch errors in
1430 x_clipboard_manager_save (Bug#8779).
1431 (Vx_select_enable_clipboard_manager): New variable.
1432 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1433
1434 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1435
1436 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1437
1438 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1439
1440 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1441 in the current matrix if keep_current_p is non-zero.
1442
1443 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1444
1445 * bidi.c (bidi_level_of_next_char): Fix last change.
1446
1447 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1448
1449 Support bidi reordering of text covered by display properties.
1450
1451 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1452 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1453 (bidi_cache_search, bidi_cache_iterator_state)
1454 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1455 (bidi_level_of_next_char, bidi_move_to_visually_next):
1456 Support character positions inside a run of characters covered by a
1457 display string.
1458 (bidi_paragraph_init, bidi_resolve_explicit_1)
1459 (bidi_level_of_next_char): Call bidi_fetch_char and
1460 bidi_fetch_char_advance instead of FETCH_CHAR and
1461 FETCH_CHAR_ADVANCE.
1462 (bidi_init_it): Initialize new members.
1463 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1464 definitions.
1465 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1466 instead of using explicit *_CHAR codes.
1467 (bidi_resolve_explicit, bidi_resolve_weak):
1468 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1469 bidirectional text is supported only in multibyte buffers.
1470 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1471 it to initialize the frame_window_p member of struct bidi_it.
1472 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1473 (bidi_resolve_explicit, bidi_resolve_weak)
1474 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1475 bidi_it->nchars is non-positive.
1476 (bidi_level_of_next_char): Don't try to lookup the cache for the
1477 next/previous character if nothing is cached there yet, or if we
1478 were just reseat()'ed to a new position.
1479
1480 * xdisp.c (set_cursor_from_row): Set start and stop points
1481 according to the row's direction when priming the loop that looks
1482 for the glyph on which to display cursor.
1483 (single_display_spec_intangible_p): Function deleted.
1484 (display_prop_intangible_p): Reimplement to call
1485 handle_display_spec instead of single_display_spec_intangible_p.
1486 Accept 3 additional arguments needed by handle_display_spec.
1487 This fixes incorrect cursor motion across display property with complex
1488 values: lists, `(when COND...)' forms, etc.
1489 (single_display_spec_string_p): Support property values that are
1490 lists with the argument STRING its top-level element.
1491 (display_prop_string_p): Fix the condition for processing a
1492 property that is a list to be consistent with handle_display_spec.
1493 (handle_display_spec): New function, refactored from the
1494 last portion of handle_display_prop.
1495 (compute_display_string_pos): Accept additional argument
1496 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1497 value of a `display' property is a "replacing spec".
1498 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1499 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1500 the display property, but just return a value indicating whether
1501 the display property will replace the characters it covers.
1502 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1503 frame_window_p members of struct bidi_it.
1504 (compute_display_string_pos, compute_display_string_end):
1505 New functions.
1506 (push_it): Accept second argument POSITION, where pop_it should
1507 jump to continue iteration.
1508 (reseat_1): Initialize bidi_it.disp_pos.
1509
1510 * keyboard.c (adjust_point_for_property): Adjust the call to
1511 display_prop_intangible_p to its new signature.
1512
1513 * dispextern.h (struct bidi_it): New member frame_window_p.
1514 (bidi_init_it): Update prototypes.
1515 (display_prop_intangible_p): Update prototype.
1516 (compute_display_string_pos, compute_display_string_end):
1517 Declare prototypes.
1518 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1519 EMACS_INT.
1520
1521 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1522
1523 Malloc failure behavior now depends on size of allocation.
1524 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1525 * lisp.h: Change signatures accordingly.
1526 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1527 All callers changed. (Bug#8762)
1528
1529 * gnutls.c: Use Emacs's memory allocators.
1530 Without this change, the gnutls library would invoke malloc etc.
1531 directly, which causes problems on non-SYNC_INPUT hosts, and which
1532 runs afoul of improving memory_full behavior. (Bug#8761)
1533 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1534 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1535 xfree instead of the default malloc, realloc, free.
1536 (Fgnutls_boot): No need to check for memory allocation failure,
1537 since xmalloc does that for us.
1538
1539 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1540 * category.c (hash_get_category_set):
1541 * ccl.c (ccl_driver):
1542 * charset.c (Fdefine_charset_internal):
1543 * charset.h (struct charset.hash_index):
1544 * composite.c (get_composition_id, gstring_lookup_cache)
1545 (composition_gstring_put_cache):
1546 * composite.h (struct composition.hash_index):
1547 * dispextern.h (struct image.hash):
1548 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1549 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1550 (hashfn_equal, hashfn_user_defined, make_hash_table)
1551 (maybe_resize_hash_table, hash_lookup, hash_put)
1552 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1553 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1554 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1555 * image.c (make_image, search_image_cache, lookup_image)
1556 (xpm_put_color_table_h):
1557 * lisp.h (struct Lisp_Hash_Table):
1558 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1559 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1560 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1561 * alloc.c (allocate_vectorlike):
1562 Check for overflow in vector size calculations.
1563 * ccl.c (ccl_driver):
1564 Check for overflow when converting EMACS_INT to int.
1565 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1566 need to be updated by these changes.
1567 * fns.c (make_hash_table, maybe_resize_hash_table):
1568 Check for integer overflow with large hash tables.
1569 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1570 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1571 (SXHASH_REDUCE): New macro.
1572 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1573 Use it instead of discarding useful hash info with large hash values.
1574 (sxhash_float): New function.
1575 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1576 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1577 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1578 Rewrite to use FIXNUM_BITS, as this simplifies things.
1579 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1580 Adjust signatures to match updated version of code.
1581 (consing_since_gc): Now EMACS_INT, since a single hash table can
1582 use more than INT_MAX bytes.
1583
1584 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1585
1586 Make it possible to build with GCC-4.6+ -O2 -flto.
1587
1588 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1589
1590 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1591
1592 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1593 Call minibuffer-inactive-mode.
1594
1595 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1596
1597 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1598 Update dependencies.
1599
1600 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1601
1602 * data.c (init_data): Remove code for UTS, this system is not
1603 supported anymore.
1604
1605 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1606
1607 Don't force ./temacs to start in terminal mode.
1608
1609 * frame.c (make_initial_frame): Initialize faces in all cases, not
1610 only when CANNOT_DUMP is defined.
1611 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1612
1613 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1614
1615 * dispnew.c (add_window_display_history): Use const for the string
1616 pointer. Remove declaration, not needed.
1617
1618 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 Use 'inline', not 'INLINE'.
1621 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1622 * alloc.c, fontset.c (INLINE): Remove.
1623 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1624 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1625 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1626 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1627 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1628
1629 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1630
1631 Make it possible to run ./temacs.
1632
1633 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1634 syms_of_callproc does the same thing. Remove test for
1635 "initialized", do it in the caller.
1636 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1637
1638 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1639
1640 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1641 (read_minibuf): Use get_minibuffer.
1642 (syms_of_minibuf): Use DEFSYM.
1643 (Qmetadata): New var.
1644 * data.c (Qbuffer): Don't make it static.
1645 (syms_of_data): Use DEFSYM.
1646
1647 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1648
1649 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1650 (CCL_CODE_MIN): New macro.
1651
1652 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1653
1654 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1655
1656 * eval.c (Qdebug): Now static.
1657 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1658 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1659 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1660
1661 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1662
1663 * image.c: Various fixes to ImageMagick code comments.
1664 (Fimagemagick_types): Doc fix.
1665
1666 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1667
1668 Minor fixes prompted by GCC 4.6.0 warnings.
1669
1670 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1671
1672 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1673 (x_clipboard_manager_save_all): Move extern decl to ...
1674 * xterm.h: ... here, so that it can be checked for consistency.
1675
1676 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1677
1678 * xselect.c (x_clipboard_manager_save_frame)
1679 (x_clipboard_manager_save_all): New functions.
1680 (Fx_clipboard_manager_save): Lisp function deleted.
1681
1682 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1683 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1684
1685 * xterm.h: Update prototype.
1686
1687 2011-05-28 William Xu <william.xwl@gmail.com>
1688
1689 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1690 exiting (Bug#8239).
1691
1692 2011-05-28 Jim Meyering <meyering@redhat.com>
1693
1694 Avoid a sign-extension bug in crypto_hash_function.
1695 * fns.c (to_uchar): Define.
1696 (crypto_hash_function): Use it to convert some newly-signed
1697 variables to unsigned, to avoid sign-extension bugs. For example,
1698 without this change, (md5 "truc") would evaluate to
1699 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1700 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1701 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1702
1703 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1704
1705 Integer overflow fixes.
1706
1707 * dbusbind.c: Serial number integer overflow fixes.
1708 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1709 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1710 to hold a serial number that is too large for a fixnum.
1711 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1712 Check for serial numbers out of range. Decode any serial number
1713 that was so large that it became a float. (Bug#8722)
1714
1715 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1716 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1717 Use XFASTINT rather than XUINT when numbers are nonnegative.
1718 (xd_append_arg, Fdbus_method_return_internal):
1719 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1720 arguments, check that Lisp number is nonnegative, rather than
1721 silently wrapping negative numbers around. (Bug#8722)
1722 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1723 (Bug#8722)
1724
1725 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1726
1727 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1728
1729 ccl: add integer overflow checks
1730 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1731 (IN_INT_RANGE): New macros.
1732 (ccl_driver): Use them to check for integer overflow when
1733 decoding a CCL program. Many of the new checks are whether XINT (x)
1734 fits in int; it doesn't always, on 64-bit hosts. The new version
1735 doesn't catch all possible integer overflows, but it's an
1736 improvement. (Bug#8719)
1737
1738 * alloc.c (make_event_array): Use XINT, not XUINT.
1739 There's no need for unsigned here.
1740
1741 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1742 This follows up to the 2011-05-06 change that substituted uintptr_t
1743 for EMACS_INT. This case wasn't caught back then.
1744
1745 Rework Fformat to avoid integer overflow issues.
1746 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1747 now (part of C89). Include <verify.h>.
1748 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1749 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1750 (Fformat): Avoid the prepass trying to compute sizes; it was only
1751 approximate and thus did not catch overflow reliably. Instead, walk
1752 through the format just once, formatting and computing sizes as we go,
1753 checking for integer overflow at every step, and allocating a larger
1754 buffer as needed. Keep track separately whether the format is
1755 multibyte. Keep only the most-recently calculated precision, rather
1756 than them all. Record whether each argument has been converted to
1757 string. Use EMACS_INT, not int, for byte and char and arg counts.
1758 Support field widths and precisions larger than INT_MAX. Avoid
1759 sprintf's undefined behavior with conversion specifications such as %#d
1760 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1761 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1762 formatting out-of-range floating point numbers with int
1763 formats. (Bug#8668)
1764
1765 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1766
1767 * data.c: Avoid integer truncation in expressions involving floats.
1768 * data.c: Include <intprops.h>.
1769 (arith_driver): When there's an integer overflow in an expression
1770 involving floating point, convert the integers to floating point
1771 so that the resulting value does not suffer from catastrophic
1772 integer truncation. For example, on a 64-bit host (* 4
1773 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1774 Do not rely on undefined behavior after integer overflow.
1775
1776 merge count_size_as_multibyte, parse_str_to_multibyte
1777 * character.c, character.h (count_size_as_multibyte):
1778 Rename from parse_str_to_multibyte; all uses changed.
1779 Check for integer overflow.
1780 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1781 since it's now a duplicate of the other. This is more of
1782 a character than a buffer op, so better that it's in character.c.
1783 * fns.c, print.c: Adjust to above changes.
1784
1785 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1786
1787 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1788
1789 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1792 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1793 (x_clipboard_manager_save): Now static.
1794 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1795
1796 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1797 (crypto_hash_function): Now static.
1798 Fix pointer signedness problems. Avoid unnecessary initializations.
1799
1800 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1801
1802 * termhooks.h (Vselection_alist): Make it terminal-local.
1803
1804 * terminal.c (create_terminal): Initialize it.
1805
1806 * xselect.c: Support for clipboard managers.
1807 (Vselection_alist): Move to termhooks.h as terminal-local var.
1808 (LOCAL_SELECTION): New macro.
1809 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1810 (symbol_to_x_atom): Remove gratuitous arg.
1811 (x_handle_selection_request, lisp_data_to_selection_data)
1812 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1813 (x_own_selection, x_get_local_selection, x_convert_selection):
1814 New arg, specifying work frame. Use terminal-local Vselection_alist.
1815 (some_frame_on_display): Delete unused function.
1816 (Fx_own_selection_internal, Fx_get_selection_internal)
1817 (Fx_disown_selection_internal, Fx_selection_owner_p)
1818 (Fx_selection_exists_p): New optional frame arg.
1819 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1820 (x_handle_selection_clear): Don't treat other terminals with the
1821 same keyboard specially. Use the terminal-local Vselection_alist.
1822 (x_clear_frame_selections): Use Frun_hook_with_args.
1823
1824 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1825
1826 * xterm.h: Add support for those atoms.
1827
1828 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1829
1830 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1831 (converted_selections, conversion_fail_tag): New global variables.
1832 (x_selection_request_lisp_error): Free the above.
1833 (x_get_local_selection): Remove unnecessary code.
1834 (x_reply_selection_request): Args changed; handle arbitrary array
1835 of converted selections stored in converted_selections.
1836 Separate the XChangeProperty and SelectionNotify steps.
1837 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1838 (x_convert_selection): New function.
1839 (x_handle_selection_event): Simplify.
1840 (x_get_foreign_selection): Don't ignore incoming requests while
1841 waiting for an answer; this will fail when we implement
1842 SAVE_TARGETS, and seems unnecessary anyway.
1843 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1844 (Vx_sent_selection_functions): Doc fix.
1845
1846 2011-05-26 Leo Liu <sdl.web@gmail.com>
1847
1848 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1849
1850 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1851
1852 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1853
1854 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1855 for fringe update if it has periodic bitmap.
1856 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1857 and fringe_bitmap_periodic_p.
1858
1859 * fringe.c (get_fringe_bitmap_data): New function.
1860 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1861 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1862 row. Mark glyph row for fringe update if periodicity changed.
1863
1864 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1865 for fringe update unless it has periodic bitmap.
1866
1867 2011-05-25 Kenichi Handa <handa@m17n.org>
1868
1869 * xdisp.c (get_next_display_element): Set correct it->face_id for
1870 a static composition.
1871
1872 2011-05-24 Leo Liu <sdl.web@gmail.com>
1873
1874 * deps.mk (fns.o):
1875 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1876
1877 * fns.c (crypto_hash_function, Fsha1): New function.
1878 (Fmd5): Use crypto_hash_function.
1879 (syms_of_fns): Add Ssha1.
1880
1881 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1882
1883 * gnutls.c: Remove unused macros.
1884 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1885 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1886 Remove macros that are defined and never used.
1887 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1888
1889 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1890
1891 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1892 (Fx_get_selection_internal): Minor cleanup.
1893 (Fx_own_selection_internal): Rename arguments for consistency with
1894 select.el.
1895
1896 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1897
1898 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1899
1900 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1901
1902 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1903
1904 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1905
1906 * dispnew.c (scrolling_window): Don't exclude the case that the
1907 last enabled row in the desired matrix touches the bottom boundary.
1908
1909 2011-05-21 Glenn Morris <rgm@gnu.org>
1910
1911 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1912 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1913 and add some more files.
1914
1915 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1916
1917 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1918 report_file_error introduced by the change from 2011-05-07.
1919
1920 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1921
1922 * systime.h (Time): Define only if emacs is defined.
1923 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1924 where the include path doesn't have X11/X.h by default. See
1925 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1926
1927 2011-05-20 Kenichi Handa <handa@m17n.org>
1928
1929 * composite.c (find_automatic_composition): Fix previous change.
1930
1931 2011-05-20 Glenn Morris <rgm@gnu.org>
1932
1933 * lisp.mk: New file, split from Makefile.in.
1934 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1935 (shortlisp): Remove.
1936 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1937
1938 2011-05-19 Glenn Morris <rgm@gnu.org>
1939
1940 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1941 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1942 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1943 (lisp): Set the order to that of loadup.el.
1944 (shortlisp): Make it a copy of $lisp.
1945 (SOME_MACHINE_LISP): Remove.
1946 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1947 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1948
1949 2011-05-18 Kenichi Handa <handa@m17n.org>
1950
1951 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1952 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1953 (find_automatic_composition): Mostly rewrite for efficiency.
1954
1955 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1956
1957 * makefile.w32-in: Update dependencies.
1958
1959 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1960
1961 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1962 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1963
1964 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 Fix some integer overflow issues, such as string length overflow.
1967
1968 * insdel.c (count_size_as_multibyte): Check for string overflow.
1969
1970 * character.c (lisp_string_width): Check for string overflow.
1971 Use EMACS_INT, not int, for string indexes and lengths; in
1972 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1973 the resulting string length overflows an EMACS_INT; instead,
1974 report a string overflow if no precision given. When checking for
1975 precision exhaustion, use a check that cannot possibly have
1976 integer overflow. (Bug#8675)
1977 * character.h (lisp_string_width): Adjust to new signature.
1978
1979 * alloc.c (string_overflow): New function.
1980 (Fmake_string): Use it. This doesn't change behavior, but saves
1981 a few bytes and will simplify future changes.
1982 * character.c (string_escape_byte8): Likewise.
1983 * lisp.h (string_overflow): New decl.
1984
1985 Fixups, following up to the user-interface timestamp change.
1986 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1987 for UI timestamps, instead of unsigned long.
1988 * msdos.c (mouse_get_pos): Likewise.
1989 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1990 * w32gui.h (Time): Define by including "systime.h" rather than by
1991 declaring it ourselves. (Bug#8664)
1992
1993 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1994 * image.c (clear_image_cache): Likewise.
1995
1996 * term.c (term_mouse_position): Don't assume time_t wraparound.
1997
1998 Be more systematic about user-interface timestamps.
1999 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2000 and sometimes 'EMACS_UINT', to represent these timestamps.
2001 This change causes it to use 'Time' uniformly, as that's what X uses.
2002 This makes the code easier to follow, and makes it easier to catch
2003 integer overflow bugs such as Bug#8664.
2004 * frame.c (Fmouse_position, Fmouse_pixel_position):
2005 Use Time, not unsigned long, for user-interface timestamps.
2006 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2007 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2008 * keyboard.h (last_event_timestamp): Likewise.
2009 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2010 * menu.h (xmenu_show): Likewise.
2011 * term.c (term_mouse_position): Likewise.
2012 * termhooks.h (struct input_event.timestamp): Likewise.
2013 (struct terminal.mouse_position_hook): Likewise.
2014 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2015 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2016 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2017 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2018 what it was before.
2019 * menu.h, termhooks.h: Include "systime.h", for Time.
2020
2021 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2022 Don't assume that the difference between two unsigned long values
2023 can fit into an integer. At this point, we know button_down_time
2024 <= event->timestamp, so the difference must be nonnegative, so
2025 there's no need to cast the result if double-click-time is
2026 nonnegative, as it should be; check that it's nonnegative, just in
2027 case. This bug is triggered when events are more than 2**31 ms
2028 apart (about 25 days). (Bug#8664)
2029
2030 * xselect.c (last_event_timestamp): Remove duplicate decl.
2031 (x_own_selection): Remove needless cast to unsigned long.
2032
2033 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2034 that always fit in int. Use a sentinel instead of a counter, to
2035 avoid a temp and to allay GCC's concerns about possible int overflow.
2036 * frame.h (struct frame): Use int for menu_bar_items_used
2037 instead of EMACS_INT, since it always fits in int.
2038
2039 * menu.c (grow_menu_items): Check for int overflow.
2040
2041 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2042
2043 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2044 Before, the code was not consistent. These values cannot exceed
2045 2**31 - 1 so there's no need to make them unsigned.
2046 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2047 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2048 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2049 as modifiers.
2050 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2051
2052 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2053 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2054 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2055 presumably because the widths might not match.
2056
2057 * window.c (size_window): Avoid needless test at loop start.
2058
2059 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2060
2061 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2062
2063 2011-05-12 Drew Adams <drew.adams@oracle.com>
2064
2065 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2066
2067 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2068
2069 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2070 `width' to `bar_area_x' and `bar_area_width', respectively.
2071 (x_scroll_run): Take account of fringe background extension.
2072
2073 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2074 Rename local vars `left' and `width' to `bar_area_x' and
2075 `bar_area_width', respectively.
2076 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2077 background extension.
2078
2079 2011-05-10 Jim Meyering <meyering@redhat.com>
2080
2081 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2082
2083 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2084
2085 * image.c (Finit_image_library): Return t for built-in image types,
2086 like pbm and xbm. (Bug#8640)
2087
2088 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2089
2090 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2091
2092 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2093
2094 * w32console.c (Fset_screen_color): Doc fix.
2095 (Fget_screen_color): New function.
2096 (syms_of_ntterm): Defsubr it.
2097
2098 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2099 unlink the temporary file if Fcall_process didn't create it in the
2100 first place.
2101 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2102 child process will be redirected to a file specified with `:file'.
2103 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2104 cue to call_process_cleanup not to close that handle.
2105
2106 2011-05-07 Ben Key <bkey76@gmail.com>
2107
2108 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2109 one of two shell specific rules, either bootstrap-temacs-CMD or
2110 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2111 to the previous implementation of the bootstrap-temacs rule.
2112 The bootstrap-temacs-CMD rule is similar to the previous
2113 implementation of the bootstrap-temacs rule except that it
2114 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2115 variable.
2116
2117 These changes, along with some changes to nt/configure.bat,
2118 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2119 earlier fix to add support for --cflags and --ldflags options
2120 that include quotes so that it works whether make uses cmd or
2121 sh as the shell.
2122
2123 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2124
2125 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2126 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2127 is a constant.
2128 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2129 a string. Handle both cases.
2130 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2131 (Fdbus_register_method): Use Qinvalid_function.
2132
2133 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2134
2135 * makefile.w32-in: Update dependencies.
2136 (LISP_H): Add inttypes.h and stdin.h.
2137 (PROCESS_H): Add unistd.h.
2138
2139 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2140
2141 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2142 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2143
2144 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2145
2146 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2147
2148 * term.c (vfatal): Remove stray call to va_end.
2149 It's not needed and the C Standard doesn't allow it here anyway.
2150
2151 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2152 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2153
2154 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2155 bytes.
2156
2157 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2158
2159 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2160
2161 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2162
2163 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2164
2165 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2166
2167 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2168 * charset.c (Fdefine_charset_internal): Don't initialize
2169 charset.code_space[15]. The value was garbage, on hosts with
2170 32-bit int (Bug#8600).
2171
2172 * lread.c (read_integer): Be more consistent with string-to-number.
2173 Use string_to_number to do the actual conversion; this avoids
2174 rounding errors and fixes some other screwups. Without this fix,
2175 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2176 (digit_to_number): Move earlier, for benefit of read_integer.
2177 Return -1 if the digit is out of range for the base, -2 if it is
2178 not a digit in any supported base. (Bug#8602)
2179
2180 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2181
2182 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2183 to match comment at start of function. This also removes a
2184 GCC warning about overflow in a 32+64-bit port.
2185
2186 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2187
2188 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2189 Reported by Stefan Monnier in
2190 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2191 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2192 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2193
2194 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2195 (EMACS_UINTPTR): Likewise, with uintptr_t.
2196
2197 * lisp.h: Prefer 64-bit EMACS_INT if available.
2198 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2199 on 32-bit hosts that have 64-bit int, so that they can access
2200 large files.
2201 However, temporarily disable this change unless the temporary
2202 symbol WIDE_EMACS_INT is defined.
2203
2204 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2205
2206 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2207 This removes an assumption that EMACS_INT and long are the same
2208 width as pointers. The assumption is true for Emacs porting targets
2209 now, but we want to make other targets possible.
2210 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2211 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2212 In the rest of the code, change types of integers that hold casted
2213 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2214 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2215 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2216 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2217 No need to cast type when ORing.
2218 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2219 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2220 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2221 assume EMACS_INT is the same width as char *.
2222 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2223 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2224 Remove no-longer-needed casts.
2225 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2226 (xg_tool_bar_help_callback, xg_make_tool_item):
2227 Use EMACS_INTPTR to hold an integer
2228 that will be cast to void *; this can avoid a GCC warning
2229 if EMACS_INT is not the same width as void *.
2230 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2231 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2232 (current_message_1, set_message_1):
2233 Use a local to convert to proper width without a cast.
2234 * xmenu.c (dialog_selection_callback): Likewise.
2235
2236 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2237 Also, don't assume VALBITS / RAND_BITS is less than 5,
2238 and don't rely on undefined behavior when shifting a 1 left into
2239 the sign bit.
2240 * lisp.h (get_random): Change signature to match.
2241
2242 * lread.c (hash_string): Use size_t, not int, for hash computation.
2243 Normally we prefer signed values; but hashing is special, because
2244 it's better to use unsigned division on hash table sizes so that
2245 the remainder is nonnegative. Also, size_t is the natural width
2246 for hashing into memory. The previous code used 'int', which doesn't
2247 retain enough info to hash well into very large tables.
2248 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2249
2250 * dbusbind.c: Don't possibly lose pointer info when converting.
2251 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2252 Use XPNTR rather than XHASH, so that the high-order bits of
2253 the pointer aren't lost when converting through void *.
2254
2255 * eval.c (Fautoload): Don't double-shift a pointer.
2256
2257 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2258
2259 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2260
2261 * gnutls.c (DEF_GNUTLS_FN):
2262 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2263
2264 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2265
2266 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2267 marker. (Bug#8610)
2268
2269 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2270
2271 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2272 New version that can reserve upto 2GB of heap space.
2273
2274 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2275
2276 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2277
2278 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2279
2280 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2281 `gnutls_certificate_set_x509_key_file'.
2282
2283 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2284
2285 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2286 Update dependencies.
2287
2288 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2289
2290 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2291 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2292 Remove unused parameter `fildes'.
2293 * process.c (read_process_output, send_process): Don't pass it.
2294
2295 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2296
2297 Fix previous change: the library cache is defined in w32.c.
2298 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2299 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2300
2301 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2302
2303 Implement dynamic loading of GnuTLS on Windows.
2304
2305 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2306 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2307 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2308 Declare.
2309
2310 * gnutls.c (Qgnutls_dll): Define.
2311 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2312 (gnutls_*): Declare function pointers.
2313 (init_gnutls_functions): New function to initialize function pointers.
2314 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2315 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2316 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2317 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2318 (emacs_gnutls_write, emacs_gnutls_read)
2319 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2320 (Fgnutls_available_p): New function.
2321 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2322 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2323 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2324
2325 * image.c: Include w32.h.
2326 (Vimage_type_cache): Delete.
2327 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2328 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2329 (w32_delayed_load): Move to w32.c.
2330
2331 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2332
2333 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2334 (w32_delayed_load): Move from image.c. When loading a library, record
2335 its filename in the :loaded-from property of the library id.
2336 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2337 Initialize and staticpro them.
2338 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2339
2340 * process.c: Include lisp.h before w32.h, not after.
2341 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2342 instead of gnutls_record_check_pending.
2343
2344 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2345
2346 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2347
2348 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2349 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2350 as passed in.
2351
2352 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2353
2354 * xterm.c (x_set_frame_alpha): Do not set property on anything
2355 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2356
2357 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2358
2359 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2360
2361 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2362
2363 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2364 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2365 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2366 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2367 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2368 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2369 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2370 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2371 (Qgnutls_bootprop_callbacks_verify): Make static.
2372
2373 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2374
2375 * callproc.c: Indentation fixup.
2376
2377 * sysdep.c (wait_for_termination_1): Make static.
2378 (wait_for_termination, interruptible_wait_for_termination):
2379 Move after wait_for_termination_1.
2380
2381 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2382
2383 * sysdep.c (interruptible_wait_for_termination): New function
2384 which is like wait_for_termination, but allows keyboard
2385 interruptions.
2386
2387 * callproc.c (Fcall_process): Add (:file "file") as an option for
2388 the STDOUT buffer.
2389 (Fcall_process_region): Ditto.
2390
2391 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2392
2393 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2394 rather than `XVECTOR (FOO)->size'.
2395
2396 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2397 inttypes.h, as a gnulib replacement is used if it not available in
2398 system headers.
2399
2400 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2401
2402 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2403 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2404 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2405
2406 * coding.c (coding_alloc_by_realloc): Error out if destination
2407 will grow beyond MOST_POSITIVE_FIXNUM.
2408 (decode_coding_emacs_mule): Abort if there isn't enough place in
2409 charbuf for the composition carryover bytes. Reserve an extra
2410 space for up to 2 characters produced in a loop.
2411 (decode_coding_iso_2022): Abort if there isn't enough place in
2412 charbuf for the composition carryover bytes.
2413
2414 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2415
2416 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2417 aborting when %lld or %lll format is passed.
2418 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2419 %llo or %llx format is passed. (Bug#8545)
2420
2421 * window.c (window_scroll_line_based): Use a marker instead of
2422 simple variables to record original value of point. (Bug#7952)
2423
2424 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2425 produced by %s or %c overflows available buffer space. (Bug#8545)
2426
2427 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2428
2429 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2430 (SIZE_MAX): Move defn after all includes, as they might #define it.
2431
2432 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2433
2434 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2435
2436 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2437
2438 * keyboard.c (Qdelayed_warnings_hook): Define.
2439 (command_loop_1): Run `delayed-warnings-hook'
2440 if Vdelayed_warnings_list is non-nil.
2441 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2442 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2443
2444 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2445
2446 * doprnt.c (doprnt): Don't return value smaller than the buffer
2447 size if the message was truncated. (Bug#8545).
2448
2449 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2450
2451 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2452 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2453
2454 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2455
2456 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2457
2458 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2459
2460 * makefile.w32-in: Update dependencies.
2461
2462 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2463
2464 Improve `doprnt' and its usage. (Bug#8545)
2465 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2466 `format_end'. Remove support for %l as a conversion specifier.
2467 Don't use xrealloc. Improve diagnostics when the %l size modifier
2468 is used. Update the commentary.
2469
2470 * eval.c (verror): Simplify calculation of size_t.
2471
2472 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2473 messages.
2474
2475 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2476
2477 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2478 change.
2479
2480 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2481
2482 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2483 This makes this file independent of the recent pseudovector change.
2484
2485 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2486
2487 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2488
2489 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2490 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2491 Remove unused local.
2492 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2493
2494 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2495 GCC 4.6.0 optimizes based on type-based alias analysis.
2496 For example, if b is of type struct buffer * and v of type struct
2497 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2498 != &v->size, and therefore "v->size = 1; b->size = 2; return
2499 v->size;" must therefore return 1. This assumption is incorrect
2500 for Emacs, since it type-puns struct Lisp_Vector * with many other
2501 types. To fix this problem, this patch adds a new type struct
2502 vectorlike_header that documents the constraints on layout of vectors
2503 and pseudovectors, and helps optimizing compilers not get fooled
2504 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2505 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2506 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2507 the size member.
2508 (XSETPVECTYPE): Rewrite in terms of new macro.
2509 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2510 This is a bit clearer, and further avoids the possibility of
2511 undesirable aliasing.
2512 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2513 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2514 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2515 since Lisp_Subr is a special case (no "next" field).
2516 (ASIZE): Now uses header.size rather than size.
2517 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2518 to avoid the hassle of writing XVECTOR (foo)->header.size.
2519 (struct vectorlike_header): New type.
2520 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2521 object, to help avoid aliasing.
2522 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2523 (SUBRP): Likewise, since Lisp_Subr is a special case.
2524 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2525 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2526 (struct Lisp_Hash_Table): Combine first two members into a single
2527 struct vectorlike_header member. All uses of "size" and "next" members
2528 changed to be "header.size" and "header.next".
2529 * buffer.h (struct buffer): Likewise.
2530 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2531 * frame.h (struct frame): Likewise.
2532 * process.h (struct Lisp_Process): Likewise.
2533 * termhooks.h (struct terminal): Likewise.
2534 * window.c (struct save_window_data, struct saved_window): Likewise.
2535 * window.h (struct window): Likewise.
2536 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2537 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2538 * buffer.c (init_buffer_once): Likewise.
2539 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2540 special case.
2541 * process.c (Fformat_network_address): Use local var for size,
2542 for brevity.
2543
2544 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2545
2546 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2547 * data.c (atof): Remove decl; no longer used or needed.
2548 (digit_to_number): Move to lread.c.
2549 (Fstring_to_number): Use new string_to_number function, to be
2550 consistent with how the Lisp reader treats infinities and NaNs.
2551 Do not assume that floating-point numbers represent EMACS_INT
2552 without losing information; this is not true on most 64-bit hosts.
2553 Avoid double-rounding errors, by insisting on integers when
2554 parsing non-base-10 numbers, as the documentation specifies.
2555 * lisp.h (string_to_number): New decl, replacing ...
2556 (isfloat_string): Remove.
2557 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2558 (read1): Do not accept +. and -. as integers; this
2559 appears to have been a coding error. Similarly, do not accept
2560 strings like +-1e0 as floating point numbers. Do not report
2561 overflow for integer overflows unless the base is not 10 which
2562 means we have no simple and reliable way to continue.
2563 Break out the floating-point parsing into a new
2564 function string_to_number, so that Fstring_to_number parses
2565 floating point numbers consistently with the Lisp reader.
2566 (digit_to_number): Move here from data.c. Make it static inline.
2567 (E_CHAR, EXP_INT): Remove, replacing with ...
2568 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2569 (string_to_number): New function, replacing isfloat_string.
2570 This function checks for valid syntax and produces the resulting
2571 Lisp float number too. Rework it so that string-to-number
2572 no longer mishandles examples like "1.0e+". Use strtoumax,
2573 so that overflow for non-base-10 numbers is reported only when
2574 there's no portable and simple way to convert to floating point.
2575
2576 * textprop.c (set_text_properties_1): Rewrite for clarity,
2577 and to avoid GCC warning about integer overflow.
2578
2579 * intervals.h (struct interval): Use EMACS_INT for members
2580 where EMACS_UINT might cause problems. See
2581 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2582 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2583 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2584 All uses changed.
2585 (offset_intervals): Tell GCC not to worry about length overflow
2586 when negating a negative length.
2587
2588 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2589 (overrun_check_free): Likewise.
2590
2591 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2592 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2593 word size.
2594
2595 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2596 (gnutls_make_error): Rename local to avoid shadowing.
2597 (gnutls_emacs_global_deinit): ifdef out; not used.
2598 (Fgnutls_boot): Use const for pointer to readonly storage.
2599 Comment out unused local. Fix pointer signedness problems.
2600
2601 * lread.c (openp): Don't stuff size_t into an 'int'.
2602 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2603 about possible signed overflow.
2604
2605 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2606 (GDK_KEY_g): Don't define if already defined.
2607 (xg_prepare_tooltip): Avoid pointer signedness problem.
2608 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2609
2610 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2611 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2612
2613 * xfns.c (Fx_window_property): Simplify a bit,
2614 to make a bit faster and to avoid GCC 4.6.0 warning.
2615 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2616
2617 * fns.c (internal_equal): Don't assume size_t fits in int.
2618
2619 * alloc.c (compact_small_strings): Tighten assertion a little.
2620
2621 Replace pEd with more-general pI, and fix some printf arg casts.
2622 * lisp.h (pI): New macro, generalizing old pEd macro to other
2623 conversion specifiers. For example, use "...%"pI"d..." rather
2624 than "...%"pEd"...".
2625 (pEd): Remove. All uses replaced with similar uses of pI.
2626 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2627 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2628 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2629 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2630 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2631 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2632 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2633 64-bit hosts.
2634 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2635 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2636 * print.c (safe_debug_print, print_object): Likewise.
2637 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2638 to int.
2639 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2640 avoiding the 0 flag, which is not portable.
2641 * process.c (Fmake_network_process): Use pI to avoid cast.
2642 * region-cache.c (pp_cache): Likewise.
2643 * xdisp.c (decode_mode_spec): Likewise.
2644 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2645 behavior on 64-bit hosts with printf arg.
2646 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2647 (x_stop_queuing_selection_requests): Likewise.
2648 (x_get_window_property): Don't truncate byte count to an 'int'
2649 when tracing.
2650
2651 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2652 here, since it parses constructs like leading '-' and spaces,
2653 which are not wanted; and it overflows with large numbers.
2654 Instead, simply match F[0-9]+, which is what is wanted anyway.
2655
2656 * alloc.c: Remove unportable assumptions about struct layout.
2657 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2658 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2659 (allocate_vectorlike, make_pure_vector): Use the new macros,
2660 plus offsetof, to remove unportable assumptions about struct layout.
2661 These assumptions hold on all porting targets that I know of, but
2662 they are not guaranteed, they're easy to remove, and removing them
2663 makes further changes easier.
2664
2665 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2666 This doesn't fix a bug but makes the code clearer.
2667 (string_overrun_cookie): Now const. Use initializers that
2668 don't formally overflow signed char, to avoid warnings.
2669 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2670 can cause Emacs to crash when string overrun checking is enabled.
2671 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2672 multiple of sizeof (EMACS_INT); it need not be, if
2673 alignof(EMACS_INT) < sizeof (EMACS_INT).
2674 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2675
2676 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2677
2678 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2679
2680 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2681
2682 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2683 supposed to be handshaking. (Bug#8556)
2684 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2685
2686 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2687
2688 * lisp.h (Qdebug): List symbol.
2689 * eval.c (Qdebug): Restore global linkage.
2690 * keyboard.c (debug-on-event): New variable.
2691 (handle_user_signal): Break into debugger when debug-on-event
2692 matches the current signal symbol.
2693
2694 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2695
2696 * alloc.c (check_sblock, check_string_bytes)
2697 (check_string_free_list): Convert to standard C.
2698
2699 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2700
2701 * w32.c (emacs_gnutls_push): Fix typo.
2702
2703 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2704
2705 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2706 "cast to pointer from integer of different size".
2707
2708 Improve doprnt and its use in verror. (Bug#8545)
2709 * doprnt.c (doprnt): Document the set of format control sequences
2710 supported by the function. Use SAFE_ALLOCA instead of always
2711 using `alloca'.
2712
2713 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2714 is one byte too soon. Don't use xrealloc; instead xfree and
2715 xmalloc anew.
2716
2717 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2718
2719 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2720 callbacks stage.
2721
2722 * gnutls.c: Renamed global_initialized to
2723 gnutls_global_initialized. Added internals for the
2724 :verify-hostname-error, :verify-error, and :verify-flags
2725 parameters of `gnutls-boot' and documented those parameters in the
2726 docstring. Start callback support.
2727 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2728 unless a fatal error occured. Call gnutls_alert_send_appropriate
2729 on error. Return error code.
2730 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2731 (emacs_gnutls_read): Likewise.
2732 (Fgnutls_boot): Return handshake error code.
2733 (emacs_gnutls_handle_error): New function.
2734 (wsaerror_to_errno): Likewise.
2735
2736 * w32.h (emacs_gnutls_pull): Add prototype.
2737 (emacs_gnutls_push): Likewise.
2738
2739 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2740 (emacs_gnutls_push): Likewise.
2741
2742 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2743
2744 * process.c (wait_reading_process_output): Check if GnuTLS
2745 buffered some data internally if no FDs are set for TLS
2746 connections.
2747
2748 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2749 (LIBS): Link to USER_LIBS.
2750 ($(BLD)/gnutls.$(0)): New target.
2751
2752 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2753
2754 * xdisp.c (handle_single_display_spec): Rename the
2755 display_replaced_before_p argument into display_replaced_p, to
2756 make it consistent with the commentary. Fix typos in the
2757 commentary.
2758
2759 * textprop.c (syms_of_textprop): Remove dead code.
2760 (copy_text_properties): Delete obsolete commentary about an
2761 interface that was deleted long ago. Fix typos in the description
2762 of arguments.
2763
2764 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2765 to changes in oldXMenu/XMenu.h from 2011-04-16.
2766 <menu_help_message, prev_menu_help_message>: Constify.
2767 (IT_menu_make_room): menu->help_text is now `const char **';
2768 adjust.
2769
2770 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2771 to changes in oldXMenu/XMenu.h from 2011-04-16.
2772 (struct XMenu): Declare `help_text' `const char **'.
2773
2774 * xfaces.c <Qunspecified>: Make extern again.
2775
2776 * syntax.c: Include sys/types.h before including regex.h, as
2777 required by Posix.
2778
2779 * doc.c (get_doc_string): Improve the format passed to `error'.
2780
2781 * doprnt.c (doprnt): Improve commentary.
2782
2783 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2784
2785 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2786 them with etags.
2787
2788 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2789 changes in globals.h immediately force recompilation.
2790 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2791 $(CURDIR)/s/ms-w32.h.
2792 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2793
2794 * character.c (Fchar_direction): Function deleted.
2795 (syms_of_character): Don't defsubr it.
2796 <char-direction-table>: Deleted.
2797
2798 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2799
2800 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2801 * doprnt.c: Include limits.h.
2802 (SIZE_MAX): New macro.
2803 (doprnt): Return a size_t value. 2nd arg is now size_t.
2804 Many local variables are now size_t instead of int or unsigned.
2805 Improve overflow protection. Support `l' modifier for integer
2806 conversions. Support %l conversion. Don't assume an EMACS_INT
2807 argument for integer conversions and for %c.
2808
2809 * lisp.h (doprnt): Restore prototype.
2810
2811 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2812 $(SRC)/character.h.
2813
2814 * Makefile.in (base_obj): Add back doprnt.o.
2815
2816 * deps.mk (doprnt.o): Add back prerequisites.
2817 (callint.o): Depend on character.h.
2818
2819 * eval.c (internal_lisp_condition_case): Include the handler
2820 representation in the error message.
2821 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2822 when breaking from the loop.
2823
2824 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2825
2826 * callint.c (Fcall_interactively): When displaying error message
2827 about invalid control letter, pass the character's codepoint, not
2828 a pointer to its multibyte form. Improve display of the character
2829 in octal and display also its hex code.
2830
2831 * character.c (char_string): Use %x to display the (unsigned)
2832 codepoint of an invalid character, to avoid displaying a bogus
2833 negative value.
2834
2835 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2836 `error', not SYMBOL_NAME itself.
2837
2838 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2839 character arguments to `error'.
2840
2841 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2842 to `error' in error message about FINAL_CHAR argument. Make sure
2843 FINAL_CHAR is a character, and use %c when it is passed as
2844 argument to `error'.
2845
2846 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2847
2848 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2849
2850 * w32.c: Include <time.h>.
2851 (sys_localtime): New function.
2852
2853 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2854
2855 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2856
2857 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2858
2859 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2860
2861 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2862 zombies (Bug#8467).
2863
2864 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2865
2866 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2867 gl_state.e_property when gl_state.object is Qt.
2868
2869 * insdel.c (make_gap_larger): Remove limitation of buffer size
2870 to <= INT_MAX.
2871
2872 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2873
2874 * xdisp.c (lookup_glyphless_char_display)
2875 (produce_glyphless_glyph): Handle cons cell entry in
2876 glyphless-char-display.
2877 (Vglyphless_char_display): Document it.
2878
2879 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2880 glyphless-char-display.
2881
2882 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2883
2884 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2885
2886 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2887
2888 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2889 definition for no-X builds.
2890
2891 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2892
2893 Static checks with GCC 4.6.0 and non-default toolkits.
2894
2895 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2896
2897 * process.c (keyboard_bit_set): Define only if SIGIO.
2898 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2899 (send_process): Repair possible setjmp clobbering.
2900
2901 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2902
2903 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2904
2905 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2906
2907 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2908 Define only if needed.
2909
2910 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2911 by pacifying GCC about it. Maybe it's time to retire it?
2912 * xfaces.c (USG, __TIMEVAL__): Likewise.
2913
2914 * dispextern.h (struct redisplay_interface): Rename param
2915 to avoid shadowing.
2916 * termhooks.h (struct terminal): Likewise.
2917 * xterm.c (xembed_send_message): Likewise.
2918
2919 * insdel.c (make_gap_smaller): Define only if
2920 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2921
2922 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2923 it.
2924
2925 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2926 so that we aren't warned about unused symbols.
2927
2928 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2929
2930 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2931
2932 * xfns.c (x_real_positions): Mark locals as initialized.
2933
2934 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2935
2936 * xterm.c: Fix problems found by static analysis with other toolkits.
2937 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2938 (x_dispatch_event): Declare static if USE_GTK, and
2939 define if USE_GTK || USE_X_TOOLKIT.
2940 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2941 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2942 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2943 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2944
2945 * xmenu.c (menu_help_callback): Pointer type fixes.
2946 Use const pointers when pointing at readonly data. Avoid pointer
2947 signedness clashes.
2948 (FALSE): Remove unused macro.
2949 (update_frame_menubar): Remove unused decl.
2950
2951 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2952
2953 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2954 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2955 (single_menu_item): Rename local to avoid shadowing.
2956
2957 * keyboard.c (make_lispy_event): Remove unused local var.
2958
2959 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2960 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2961
2962 * bitmaps: Change bitmaps from unsigned char back to the X11
2963 compatible char. Avoid the old compiler warnings about
2964 out-of-range initializers by using, for example, '\xab' rather
2965 than 0xab.
2966
2967 * xgselect.c (xgselect_initialize): Check vs interface
2968 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2969
2970 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2971
2972 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2973 to read-only memory.
2974
2975 * fns.c (vector): Remove; this old hack is no longer needed.
2976
2977 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2978 Remove unused var.
2979 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2980
2981 * xrdb.c (x_load_resources): Omit unused local.
2982
2983 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2984 (x_window): Rename locals to avoid shadowing.
2985 (USG): Use the kludged USG macro, to pacify gcc.
2986
2987 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2988 (x_term_init): Remove local to avoid shadowing.
2989
2990 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2991
2992 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2993 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2994
2995 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2996
2997 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2998
2999 Fix regex.c, syntax.c and friends for buffers > 2GB.
3000 * syntax.h (struct gl_state_s): Declare character position members
3001 EMACS_INT.
3002
3003 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3004
3005 * textprop.c (verify_interval_modification, interval_of):
3006 Declare arguments EMACS_INT.
3007
3008 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3009 EMACS_INT.
3010
3011 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3012
3013 * indent.c (Fvertical_motion): Local variable it_start is now
3014 EMACS_INT.
3015
3016 * regex.c (re_match, re_match_2, re_match_2_internal)
3017 (bcmp_translate, regcomp, regexec, print_double_string)
3018 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3019 (re_compile_pattern, re_exec): Declare arguments and local
3020 variables `size_t' and `ssize_t' and return values `regoff_t', as
3021 appropriate.
3022 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3023 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3024 <compile_stack_type>: `size' and `avail' are now `size_t'.
3025
3026 * regex.h <regoff_t>: Use ssize_t, not int.
3027 (re_search, re_search_2, re_match, re_match_2): Arguments that
3028 specify buffer/string position and length are now ssize_t and
3029 size_t. Return type is regoff_t.
3030
3031 2011-04-16 Ben Key <bkey76@gmail.com>
3032
3033 * nsfont.m: Fixed bugs in ns_get_family and
3034 ns_descriptor_to_entity that were caused by using free to
3035 deallocate memory blocks that were allocated by xmalloc (via
3036 xstrdup). This caused Emacs to crash when compiled with
3037 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3038 --enable-checking=xmallocoverrun). xfree is now used to
3039 deallocate these memory blocks.
3040
3041 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3042
3043 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3044
3045 emacs_write: Accept and return EMACS_INT for sizes.
3046 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3047 et seq.
3048 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3049 Accept and return EMACS_INT.
3050 (emacs_gnutls_write): Return the number of bytes written on
3051 partial writes.
3052 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3053 (emacs_read, emacs_write): Remove check for negative size, as the
3054 Emacs source code has been audited now.
3055 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3056 (emacs_read, emacs_write): Use it.
3057 * process.c (send_process): Adjust to the new signatures of
3058 emacs_write and emacs_gnutls_write. Do not attempt to store
3059 a byte offset into an 'int'; it might overflow.
3060 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3061
3062 * sound.c: Don't assume sizes fit in 'int'.
3063 (struct sound_device.period_size, alsa_period_size):
3064 Return EMACS_INT, not int.
3065 (struct sound_device.write, vox_write, alsa_write):
3066 Accept EMACS_INT, not int.
3067 (wav_play, au_play): Use EMACS_INT to store sizes and to
3068 record read return values.
3069
3070 2011-04-15 Ben Key <bkey76@gmail.com>
3071
3072 * keyboard.c (Qundefined): Don't declare static since it is used
3073 in nsfns.m.
3074 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3075 static since they are used in nsfont.m.
3076
3077 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3078
3079 * process.c (Qprocessp): Don't declare static.
3080 * lisp.h (Qprocessp): Declare again.
3081
3082 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3083
3084 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3085
3086 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3087
3088 Improve C-level modularity by making more things 'static'.
3089
3090 Don't publish debugger-only interfaces to other modules.
3091 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3092 (verify_bytepos, count_markers): Move decls to the only modules
3093 that need them.
3094 * region-cache.h (pp_cache): Likewise.
3095 * window.h (check_all_windows): Likewise.
3096 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3097
3098 * sysdep.c (croak): Now static, if
3099 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3100 * syssignal.h (croak): Declare only if not static.
3101
3102 * alloc.c (refill_memory_reserve): Now static if
3103 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3104 * lisp.h (refill_memory_reserve): Declare only if not static.
3105
3106 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3107 Define only if USE_LUCID.
3108
3109 * xrdb.c (x_customization_string, x_rm_string): Now static.
3110
3111 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3112 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3113
3114 * xdisp.c (draw_row_with_mouse_face): Now static.
3115 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3116
3117 * window.h (check_all_windows): Mark externally visible.
3118
3119 * window.c (window_deletion_count): Now static.
3120
3121 * undo.c: Make symbols static if they're not exported.
3122 (last_undo_buffer, last_boundary_position, pending_boundary):
3123 Now static.
3124
3125 * textprop.c (interval_insert_behind_hooks): Now static.
3126 (interval_insert_in_front_hooks): Likewise.
3127
3128 * term.c: Make symbols static if they're not exported.
3129 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3130 (max_frame_lines, tty_set_terminal_modes):
3131 (tty_reset_terminal_modes, tty_turn_off_highlight):
3132 (get_tty_terminal): Now static.
3133 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3134 * termhooks.h (term_mouse_moveto): Do not declare if
3135 HAVE_WINDOW_SYSTEM.
3136 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3137 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3138
3139 * sysdep.c: Make symbols static if they're not exported.
3140 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3141 Now static.
3142 (sigprocmask_set, full_mask): Remove; unused.
3143 (wait_debugging): Mark as visible.
3144 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3145 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3146
3147 * syntax.c (syntax_temp): Define only if !__GNUC__.
3148
3149 * sound.c (current_sound_device, current_sound): Now static.
3150
3151 * search.c (searchbufs, searchbuf_head): Now static.
3152
3153 * scroll.c (scroll_cost): Remove; unused.
3154 * dispextern.h (scroll_cost): Remove decl.
3155
3156 * region-cache.h (pp_cache): Mark as externally visible.
3157
3158 * process.c: Make symbols static if they're not exported.
3159 (process_tick, update_tick, create_process, chan_process):
3160 (Vprocess_alist, proc_buffered_char, datagram_access):
3161 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3162 (deactivate_process): Mark defn as static, as well as decl.
3163 * lisp.h (create_process): Remove decl.
3164 * process.h (chan_process, Vprocess_alist): Remove decls.
3165
3166 * print.c: Make symbols static if they're not exported.
3167 (print_depth, new_backquote_output, being_printed, print_buffer):
3168 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3169 (print_interval, print_number_index, initial_stderr_stream):
3170 Now static.
3171 * lisp.h (Fprinc): Remove decl.
3172 (debug_output_compilation_hack): Mark as externally visible.
3173
3174 * sysdep.c (croak): Move decl from here to syssignal.h.
3175 * syssignal.h (croak): Put it here, so the API can be checked when
3176 'croak' is called from dissociate_if_controlling_tty.
3177
3178 * minibuf.c: Make symbols static if they're not exported.
3179 (minibuf_save_list, choose_minibuf_frame): Now static.
3180 * lisp.h (choose_minibuf_frame): Remove decl.
3181
3182 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3183
3184 * lread.c: Make symbols static if they're not exported.
3185 (read_objects, initial_obarray, oblookup_last_bucket_number):
3186 Now static.
3187 (make_symbol): Remove; unused.
3188 * lisp.h (initial_obarray, make_symbol): Remove decls.
3189
3190 * keyboard.c: Make symbols static if they're not exported.
3191 (single_kboard, recent_keys_index, total_keys, recent_keys):
3192 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3193 (this_single_command_key_start, echoing, last_auto_save):
3194 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3195 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3196 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3197 (Vlispy_mouse_stem, double_click_count):
3198 Now static.
3199 (force_auto_save_soon): Define only if SIGDANGER.
3200 (ignore_mouse_drag_p): Now static if
3201 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3202 (print_help): Remove; unused.
3203 (stop_character, last_timer_event): Mark as externally visible.
3204 * keyboard.h (ignore_mouse_drag_p): Declare only if
3205 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3206 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3207 * lisp.h (echoing): Remove decl.
3208 (force_auto_save_soon): Declare only if SIGDANGER.
3209 * xdisp.c (redisplay_window): Simplify code, to make it more
3210 obvious that ignore_mouse_drag_p is not accessed if !defined
3211 USE_GTK && !defined HAVE_NS.
3212
3213 * intervals.c: Make symbols static if they're not exported.
3214 (merge_properties_sticky, merge_interval_right, delete_interval):
3215 Now static.
3216 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3217
3218 * insdel.c: Make symbols static if they're not exported.
3219 However, leave prepare_to_modify_buffer alone. It's never
3220 called from outside this function, but that appears to be a bug.
3221 (combine_after_change_list, combine_after_change_buffer):
3222 (adjust_after_replace, signal_before_change): Now static.
3223 (adjust_after_replace_noundo): Remove; unused.
3224 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3225 (signal_before_change): Remove decls.
3226
3227 * indent.c (val_compute_motion, val_vmotion): Now static.
3228
3229 * image.c: Make symbols static if they're not exported.
3230 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3231 if USE_GTK.
3232 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3233 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3234
3235 * fringe.c (standard_bitmaps): Now static.
3236 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3237
3238 * frame.c: Make symbols static if they're not exported.
3239 (x_report_frame_params, make_terminal_frame): Now static.
3240 (get_frame_param): Now static, unless HAVE_NS.
3241 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3242 (x_get_resource_string): Remove; not used.
3243 * frame.h (make_terminal_frame, x_report_frame_params):
3244 (x_get_resource_string); Remove decls.
3245 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3246 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3247
3248 * font.c, fontset.c: Make symbols static if they're not exported.
3249 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3250 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3251 * font.c (font_close_object): Now static.
3252 * font.h (font_close_object): Remove.
3253 * fontset.c (FONTSET_OBJLIST): Remove.
3254 (free_realized_fontset) #if-0 the body, which does nothing.
3255 (face_suitable_for_char_p): #if-0, as it's never called.
3256 * fontset.h (face_suitable_for_char_p): Remove decl.
3257 * xfaces.c (face_at_string_position):
3258 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3259 since 0 is always ASCII.
3260
3261 * fns.c (weak_hash_tables): Now static.
3262
3263 * fileio.c: Make symbols static if they're not exported.
3264 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3265 (Vwrite_region_annotation_buffers): Now static.
3266
3267 * eval.c: Make symbols static if they're not exported.
3268 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3269 * lisp.h (backtrace_list): Remove decl.
3270
3271 * emacs.c: Make symbols static if they're not exported.
3272 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3273 (fatal_error_code, fatal_error_signal_hook, standard_args):
3274 Now static.
3275 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3276 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3277 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3278 * lisp.h (fatal_error_signal_hook): Remove decl.
3279 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3280
3281 * editfns.c: Move a (normally-unused) function to its only use.
3282 * editfns.c, lisp.h (get_operating_system_release): Remove.
3283 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3284 worth the hassle of breaking this out.
3285
3286 * xterm.c: Make symbols static if they're not exported.
3287 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3288 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3289 (x_destroy_window, x_delete_display):
3290 Now static.
3291 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3292 (x_mouse_leave): Remove; unused.
3293 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3294 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3295 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3296 Remove decls.
3297 (x_mouse_leave): Declare only if WINDOWSNT.
3298 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3299 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3300 USE_X_TOOLKIT.
3301
3302 * ftxfont.c: Make symbols static if they're not exported.
3303 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3304 HAVE_FREETYPE.
3305 * font.h (ftxfont_driver): Likewise.
3306
3307 * xfns.c: Make symbols static if they're not exported.
3308 (x_last_font_name, x_display_info_for_name):
3309 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3310 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3311 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3312 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3313 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3314 (last_show_tip_args): Now static.
3315 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3316 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3317 (x_screen_planes): Remove; unused.
3318 * dispextern.h (x_screen_planes): Remove decl.
3319
3320 * dispnew.c: Make symbols static if they're not exported.
3321 * dispextern.h (redraw_garbaged_frames, scrolling):
3322 (increment_row_positions): Remove.
3323 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3324 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3325 Now static.
3326 (redraw_garbaged_frames): Remove; unused.
3327
3328 * xfaces.c: Make symbols static if they're not exported.
3329 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3330 Remove decls.
3331 * xterm.h (defined_color): Remove decls.
3332 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3333 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3334 (menu_face_changed_default, defined_color, free_realized_face):
3335 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3336 (ascii_face_of_lisp_face): Remove; unused.
3337
3338 * xdisp.c: Make symbols static if they're not exported.
3339 * dispextern.h (scratch_glyph_row, window_box_edges):
3340 (glyph_to_pixel_coords, set_cursor_from_row):
3341 (get_next_display_element, set_iterator_to_next):
3342 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3343 (show_mouse_face): Remove decls
3344 * frame.h (message_buf_print): Likewise.
3345 * lisp.h (pop_message, set_message, check_point_in_composition):
3346 Likewise.
3347 * xterm.h (set_vertical_scroll_bar): Likewise.
3348 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3349 (message_buf_print, scratch_glyph_row, displayed_buffer):
3350 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3351 (get_next_display_element, show_mouse_face, window_box_edges):
3352 (frame_to_window_pixel_xy, check_point_in_composition):
3353 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3354 (glyph_to_pixel_coords): Remove; unused.
3355
3356 * dired.c (file_name_completion): Now static.
3357
3358 * dbusbind.c (xd_in_read_queued_messages): Now static.
3359
3360 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3361 * data.c (circular_list_error): Remove.
3362
3363 * commands.h (last_point_position, last_point_position_buffer):
3364 (last_point_position_window): Remove decls.
3365 * keyboard.c: Make these variables static.
3366
3367 * coding.h (coding, code_convert_region, encode_coding_gap):
3368 Remove decls.
3369 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3370 (iso_code_class, detect_coding, code_convert_region): Now static.
3371 (encode_coding_gap): Remove; unused.
3372
3373 * chartab.c (chartab_chars, chartab_bits): Now static.
3374
3375 * charset.h (charset_iso_8859_1): Remove decl.
3376 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3377 Now static.
3378
3379 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3380 * ccl.c (Vccl_program_table): Now static.
3381 (check_ccl_update): Remove; unused.
3382
3383 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3384 * category.h: ... from here.
3385 * category.c (check_category_table, set_category_set): Now static.
3386
3387 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3388 * lisp.h: Remove these decls.
3389
3390 * buffer.c (buffer_count): Remove unused var.
3391
3392 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3393 so that it's not optimized away.
3394 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3395 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3396 exported only to the debugger.
3397
3398 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3399 * atimer.h (run_all_atimers): Remove; not exported.
3400
3401 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3402 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3403 was inaccessible from Lisp.
3404 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3405 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3406
3407 alloc.c: Import and export fewer symbols, and remove unused items.
3408 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3409 is defined.
3410 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3411 it's not optimized away by whole-program optimization.
3412 (message_enable_multibyte, free_misc): Remove.
3413 (catchlist, handlerlist, mark_backtrace):
3414 Declare only if BYTE_MARK_STACK.
3415 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3416 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3417 (message_enable_multibyte): Remove decl.
3418 (free_misc, interval_free_list, float_block, float_block_index):
3419 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3420 (cons_free_list, last_marked_index):
3421 Now static.
3422 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3423 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3424 (mark_backtrace): Define only if BYTE_MARK_STACK.
3425 * xdisp.c (message_enable_multibyte): Now static.
3426
3427 Declare Lisp_Object Q* variables to be 'static' if not exported.
3428 This makes it easier for human readers (and static analyzers)
3429 to see whether these variables are used from other modules.
3430 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3431 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3432 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3433 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3434 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3435 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3436 * xmenu.c, xselect.c:
3437 Declare Q* vars static if they are not used in other modules.
3438 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3439 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3440 Remove decls of unexported vars.
3441 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3442
3443 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3444
3445 Make Emacs functions such as Fatom 'static' by default.
3446 This makes it easier for human readers (and static analyzers)
3447 to see whether these functions can be called from other modules.
3448 DEFUN now defines a static function. To make the function external
3449 so that it can be used in other C modules, use the new macro DEFUE.
3450 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3451 (Finit_image_library):
3452 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3453 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3454 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3455 Remove decls, since these functions are now static.
3456 (Funintern, Fget_internal_run_time): New decls, since these functions
3457 were already external.
3458
3459 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3460 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3461 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3462 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3463 * keyboard.c, keymap.c, lread.c:
3464 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3465 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3466 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3467 Mark functions with DEFUE instead of DEFUN,
3468 if they are used in other modules.
3469 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3470 decls for now-static functions.
3471 * buffer.h (Fdelete_overlay): Remove decl.
3472 * callproc.c (Fgetenv_internal): Mark as internal.
3473 * composite.c (Fremove_list_of_text_properties): Remove decl.
3474 (Fcomposition_get_gstring): New forward static decl.
3475 * composite.h (Fcomposite_get_gstring): Remove decl.
3476 * dired.c (Ffile_attributes): New forward static decl.
3477 * doc.c (Fdocumntation_property): New forward static decl.
3478 * eval.c (Ffetch_bytecode): New forward static decl.
3479 (Funintern): Remove extern decl; now in .h file where it belongs.
3480 * fileio.c (Fmake_symbolic_link): New forward static decl.
3481 * image.c (Finit_image_library): New forward static decl.
3482 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3483 * intervals.h (Fprevious_property_change):
3484 (Fremove_list_of_text_properties): Remove decls.
3485 * keyboard.c (Fthis_command_keys): Remove decl.
3486 (Fcommand_execute): New forward static decl.
3487 * keymap.c (Flookup_key): New forward static decl.
3488 (Fcopy_keymap): Now static.
3489 * keymap.h (Flookup_key): Remove decl.
3490 * process.c (Fget_process): New forward static decl.
3491 (Fprocess_datagram_address): Mark as internal.
3492 * syntax.c (Fsyntax_table_p): New forward static decl.
3493 (skip_chars): Remove duplicate decl.
3494 * textprop.c (Fprevious_property_change): New forward static decl.
3495 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3496 Now internal.
3497 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3498 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3499
3500 * editfns.c (Fformat): Remove unreachable code.
3501
3502 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3503
3504 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3505 change. (Bug#8496)
3506
3507 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3508
3509 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3510 when at ZV. (Bug#8487)
3511
3512 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3513
3514 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3515 (Bug#8437)
3516 * keyboard.c (parse_tool_bar_item): Likewise.
3517 * sound.c (sound_cleanup, alsa_close): Likewise.
3518 * termcap.c (tgetent): Likewise.
3519 * xfns.c (x_default_font_parameter): Likewise.
3520 * xsettings.c (read_and_apply_settings): Likewise.
3521
3522 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3523 (overrun_check_free): Protoize.
3524
3525 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3526
3527 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3528 since callers should never pass a negative size.
3529 Change the signature to match that of plain 'read' and 'write'; see
3530 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3531 * lisp.h: Update prototypes of emacs_write and emacs_read.
3532
3533 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3534
3535 * xdisp.c (redisplay_window): Don't try to determine the character
3536 position of the scroll margin if the window start point w->startp
3537 is outside the buffer's accessible region. (Bug#8468)
3538
3539 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3540
3541 Fix write-region and its subroutines for buffers > 2GB.
3542 * fileio.c (a_write, e_write): Modify declaration of arguments and
3543 local variables to support buffers larger than 2GB.
3544 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3545
3546 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3547 argument, local variables, and return value.
3548
3549 * lisp.h: Update prototypes of emacs_write and emacs_read.
3550
3551 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3552
3553 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3556
3557 Fix more problems found by GCC 4.6.0's static checks.
3558
3559 * xdisp.c (vmessage): Use a better test for character truncation.
3560
3561 * charset.c (load_charset_map): <, not <=, for optimization,
3562 and to avoid potential problems with integer overflow.
3563 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3564 * casetab.c (set_identity, shuffle): Likewise.
3565 * editfns.c (Fformat): Likewise.
3566 * syntax.c (skip_chars): Likewise.
3567
3568 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3569 This also lets GCC 4.6.0 generate slightly better loop code.
3570
3571 * callint.c (Fcall_interactively): <, not <=, for optimization.
3572 (Fcall_interactively): Count the number of arguments produced,
3573 not the number of arguments given. This is simpler and lets GCC
3574 4.6.0 generate slightly better code.
3575
3576 * ftfont.c: Distingish more carefully between FcChar8 and char.
3577 The previous code passed unsigned char * to a functions like
3578 strlen and xstrcasecmp that expect char *, which does not
3579 conform to the C standard.
3580 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3581 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3582 char * when the C standard requires it.
3583
3584 * keyboard.c (read_char): Remove unused var.
3585
3586 * eval.c: Port to Windows vsnprintf (Bug#8435).
3587 Include <limits.h>.
3588 (SIZE_MAX): Define if the headers do not.
3589 (verror): Do not give up if vsnprintf returns a negative count.
3590 Instead, grow the buffer. This ports to Windows vsnprintf, which
3591 does not conform to C99. Problem reported by Eli Zaretskii.
3592 Also, simplify the allocation scheme, by avoiding the need for
3593 calling realloc, and removing the ALLOCATED variable.
3594
3595 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3596
3597 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3598 But keep the doprint source code for now, as we might revamp it
3599 and use it again (Bug#8435).
3600 * lisp.h (doprnt): Remove.
3601 * Makefile.in (base_obj): Remove doprnt.o.
3602 * deps.mk (doprnt.o): Remove.
3603
3604 error: Print 32- and 64-bit integers portably (Bug#8435).
3605 Without this change, on typical 64-bit hosts error ("...%d...", N)
3606 was used to print both 32- and 64-bit integers N, which relied on
3607 undefined behavior.
3608 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3609 New macro.
3610 * lisp.h (error, verror): Mark as printf-like functions.
3611 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3612 Report overflow in size calculations when allocating printf buffer.
3613 Do not truncate output string at its first null byte.
3614 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3615 Truncate the output at a character boundary, since vsnprintf does not
3616 do that.
3617 * charset.c (check_iso_charset_parameter): Convert internal
3618 character to string before calling 'error', since %c now has the
3619 printf meaning.
3620 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3621 overflow when computing char to be passed to 'error'. Do not
3622 pass Lisp_Object to 'error'; pass the integer instead.
3623 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3624 formatted with plain %d.
3625
3626 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3627
3628 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3629
3630 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3631
3632 * xterm.c (x_catch_errors): Remove duplicate declaration.
3633
3634 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3635
3636 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3637
3638 2011-04-10 Jim Meyering <meyering@redhat.com>
3639
3640 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3641 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3642 return ssize_t not "int", and use size_t as the buffer length.
3643 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3644 * gnutls.h: Update declarations.
3645 * process.c (read_process_output): Use ssize_t, to match.
3646 (send_process): Likewise.
3647
3648 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3649
3650 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3651
3652 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3653
3654 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3655 Use unsigned char, to match FcChar8 type definition.
3656
3657 * xterm.c (handle_one_xevent):
3658 * xmenu.c (create_and_show_popup_menu):
3659 * xselect.c (x_decline_selection_request)
3660 (x_reply_selection_request): Avoid type-punned deref of X events.
3661
3662 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3663
3664 Fix some uses of `int' instead of EMACS_INT.
3665 * search.c (string_match_1, fast_string_match)
3666 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3667 (scan_buffer, find_next_newline_no_quit)
3668 (find_before_next_newline, search_command, Freplace_match)
3669 (Fmatch_data): Make some `int' variables be EMACS_INT.
3670
3671 * xdisp.c (display_count_lines): 3rd argument and return value now
3672 EMACS_INT. All callers changed.
3673 (pint2hrstr): Last argument is now EMACS_INT.
3674
3675 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3676 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3677 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3678 (decode_coding_utf_16, decode_coding_emacs_mule)
3679 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3680 (decode_coding_ccl, decode_coding_charset)
3681 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3682 (decode_coding_iso_2022, decode_coding_emacs_mule)
3683 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3684 <char_offset, last_offset>: Declare EMACS_INT.
3685 (encode_coding_utf_8, encode_coding_utf_16)
3686 (encode_coding_emacs_mule, encode_invocation_designation)
3687 (encode_designation_at_bol, encode_coding_iso_2022)
3688 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3689 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3690 Declare EMACS_INT.
3691 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3692 (encode_invocation_designation): Last argument P_NCHARS is now
3693 EMACS_INT.
3694 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3695 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3696
3697 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3698 All users changed.
3699
3700 * ccl.c (Fccl_execute_on_string): Declare some variables
3701 EMACS_INT.
3702
3703 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3704
3705 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3706
3707 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3708
3709 * process.c (Fformat_network_address): Doc fix.
3710
3711 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3712
3713 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3714
3715 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3716
3717 * keyboard.c (read_char): Call Lisp function help-form-show,
3718 instead of using internal_with_output_to_temp_buffer.
3719 (Qhelp_form_show): New var.
3720 (syms_of_keyboard): Use DEFSYM macro.
3721
3722 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3723
3724 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3725
3726 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3727
3728 * process.c (Flist_processes): Remove to Lisp.
3729 (list_processes_1): Delete.
3730
3731 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3732
3733 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3734
3735 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3736
3737 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3738
3739 Fix more problems found by GCC 4.6.0's static checks.
3740
3741 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3742
3743 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3744
3745 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3746
3747 * xdisp.c (vmessage): Mark as a printf-like function.
3748
3749 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3750
3751 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3752
3753 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3754 printf-like functions.
3755 (tiff_load): Add casts to remove these marks before passing them
3756 to system-supplied API.
3757
3758 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3759
3760 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3761 This avoids several warnings with gcc -Wstrict-overflow.
3762 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3763 directly, rather than having caller test rule sign. This avoids
3764 some unnecessary tests.
3765 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3766 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3767 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3768
3769 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3770 (xfont_open): Avoid unnecessary tests.
3771
3772 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3773
3774 * composite.h, composite.c (composition_gstring_put_cache):
3775 Use EMACS_INT, not int, for length.
3776
3777 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3778 breaking out part of COMPOSITION_DECODE_RULE.
3779 (COMPOSITION_DECODE_RULE): Use it.
3780 * composite.c (get_composition_id): Remove unused local vars,
3781 by using the new macro.
3782
3783 * textprop.c (set_text_properties_1): Change while to do-while,
3784 since the condition is always true at first.
3785
3786 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3787 (interval_deletion_adjustment): Return unsigned value.
3788 All uses changed.
3789
3790 * process.c (list_processes_1, create_pty, read_process_output):
3791 (exec_sentinel): Remove vars that were set but not used.
3792 (create_pty): Remove unnecessary "volatile"s.
3793 (Fnetwork_interface_info): Avoid possibility of int overflow.
3794 (read_process_output): Do adaptive read buffering even if carryover.
3795 (read_process_output): Simplify nbytes computation if buffered.
3796
3797 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3798
3799 * syntax.c (scan_words): Remove var that was set but not used.
3800 (update_syntax_table): Use unsigned instead of int.
3801
3802 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3803 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3804 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3805
3806 * print.c (print_error_message): Avoid int overflow.
3807
3808 * font.c (font_list_entities): Redo for clarity,
3809 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3810
3811 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3812 (font_score): Avoid potential overflow in diff calculation.
3813
3814 * fns.c (substring_both): Remove var that is set but not used.
3815 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3816
3817 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3818
3819 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3820 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3821 can always succeed if overflow has undefined behavior.
3822
3823 * search.c (boyer_moore, wordify): Remove vars set but not used.
3824 (wordify): Omit three unnecessary tests.
3825
3826 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3827 All callers changed. This avoids the need for an unused var.
3828
3829 * casefiddle.c (casify_region): Remove var that is set but not used.
3830
3831 * dired.c (file_name_completion): Remove var that is set but not used.
3832
3833 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3834
3835 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3836 (Finsert_file_contents): Remove unnecessary code checking fd.
3837
3838 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3839 Check for integer overflow on size calculations.
3840
3841 * buffer.c (Fprevious_overlay_change): Remove var that is set
3842 but not used.
3843
3844 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3845 Remove vars that are set but not used.
3846 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3847 (timer_check_2): Mark vars as initialized.
3848
3849 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3850
3851 * image.c (lookup_image): Remove var that is set but not used.
3852 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3853
3854 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3855 that are set but not used.
3856
3857 * xfns.c (make_invisible_cursor): Don't return garbage
3858 if XCreateBitmapFromData fails (Bug#8410).
3859
3860 * xselect.c (x_get_local_selection, x_handle_property_notify):
3861 Remove vars that are set but not used.
3862
3863 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3864 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3865
3866 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3867 Remove var that is set but not used.
3868 (scroll_bar_windows_size): Now size_t, not int.
3869 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3870 Check for overflow.
3871
3872 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3873 (map_tty_color) [!defined MSDOS]: Likewise.
3874
3875 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3876
3877 * coding.c: Remove vars that are set but not used.
3878 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3879 All callers changed.
3880 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3881 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3882 (decode_coding_charset): Remove vars that are set but not used.
3883
3884 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3885 that is set but not used.
3886
3887 * print.c (print_object): Remove var that is set but not used.
3888
3889 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3890 The gnulib version avoids calling malloc in the usual case,
3891 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3892 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3893 * filelock.c (current_lock_owner): Likewise.
3894 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3895 * sysdep.c: Include allocator.h, careadlinkat.h.
3896 (emacs_no_realloc_allocator): New static constant.
3897 (emacs_readlink): New function.
3898 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3899 ../lib/careadlinkat.h.
3900
3901 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3902
3903 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3904 first non-nil return value).
3905
3906 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3907
3908 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3909 if not defined (Bug#8403).
3910
3911 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3912
3913 * xdisp.c (display_count_lines): Remove parameter `start',
3914 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3915 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3916 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3917 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3918 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3919 and thereabouts. All callers changed.
3920 (get_per_char_metric): Remove parameter `f', unused since
3921 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3922
3923 2011-04-02 Jim Meyering <meyering@redhat.com>
3924
3925 do not dereference NULL upon failed strdup
3926 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3927 (ns_get_family): Likewise.
3928
3929 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3930
3931 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3932
3933 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3934
3935 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3936 later (Bug#8403).
3937
3938 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3939
3940 Add lexical binding.
3941
3942 * window.c (Ftemp_output_buffer_show): New fun.
3943 (Fsave_window_excursion):
3944 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3945
3946 * lread.c (lisp_file_lexically_bound_p): New function.
3947 (Fload): Bind Qlexical_binding.
3948 (readevalloop): Remove `evalfun' arg.
3949 Bind Qinternal_interpreter_environment.
3950 (Feval_buffer): Bind Qlexical_binding.
3951 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3952 Mark as dynamic.
3953 (syms_of_lread): Declare `lexical-binding'.
3954
3955 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3956
3957 * keyboard.c (eval_dyn): New fun.
3958 (menu_item_eval_property): Use it.
3959
3960 * image.c (parse_image_spec): Use Ffunctionp.
3961
3962 * fns.c (concat, mapcar1): Accept byte-code-functions.
3963
3964 * eval.c (Fsetq): Handle lexical vars.
3965 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3966 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3967 (FletX, Flet): Obey lexical binding.
3968 (Fcommandp): Handle closures.
3969 (Feval): New `lexical' arg.
3970 (eval_sub): New function extracted from Feval. Use it almost
3971 everywhere where Feval was used. Look up vars in lexical env.
3972 Handle closures.
3973 (Ffunctionp): Move from subr.el.
3974 (Ffuncall): Handle closures.
3975 (apply_lambda): Remove `eval_flags'.
3976 (funcall_lambda): Handle closures and new byte-code-functions.
3977 (Fspecial_variable_p): New function.
3978 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3979 but without exporting it to Lisp.
3980
3981 * doc.c (Fdocumentation, store_function_docstring):
3982 * data.c (Finteractive_form): Handle closures.
3983
3984 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3985 interactive spec.
3986
3987 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3988 New byte-codes.
3989 (exec_byte_code): New function extracted from Fbyte_code to handle new
3990 calling convention for byte-code-functions. Add new byte-codes.
3991
3992 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3993
3994 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3995
3996 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3997
3998 * xdisp.c (redisplay_internal): Fix prototype.
3999
4000 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4001
4002 * xdisp.c (SCROLL_LIMIT): New macro.
4003 (try_scrolling): Use it when setting scroll_limit.
4004 Limit scrolling to 100 screen lines.
4005 (redisplay_window): Even when falling back on "recentering",
4006 position point in the window according to scroll-conservatively,
4007 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4008
4009 (try_scrolling): When point is above the window, allow searching
4010 as far as scroll_max, or one screenful, to compute vertical
4011 distance from PT to the scroll margin position. This prevents
4012 try_scrolling from unnecessarily failing when
4013 scroll-conservatively is set to a value slightly larger than the
4014 window height. Clean up the case of PT below the margin at bottom
4015 of window: scroll_max can no longer be INT_MAX. When aggressive
4016 scrolling is in use, don't let point enter the opposite scroll
4017 margin as result of the scroll.
4018 (syms_of_xdisp) <scroll-conservatively>: Document the
4019 threshold of 100 lines for never-recentering scrolling.
4020
4021 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4022
4023 * dispextern.h (move_it_by_lines):
4024 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4025 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4026 (message_log_check_duplicate): Remove parameters `prev_bol' and
4027 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4028 (redisplay_internal): Remove parameter `preserve_echo_area',
4029 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4030
4031 * indent.c (Fvertical_motion):
4032 * window.c (window_scroll_pixel_based, Frecenter):
4033 Don't pass `need_y_p' to `move_it_by_lines'.
4034
4035 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4036
4037 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4038 steal a few bits to be more compact.
4039 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4040 Remove unneeded casts.
4041
4042 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4043
4044 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4045
4046 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4047 binding" message (bug#7967).
4048
4049 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4050
4051 Fix more problems found by GCC 4.6.0's static checks.
4052
4053 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4054 Remove unused local var.
4055
4056 * editfns.c (Fmessage_box): Remove unused local var.
4057
4058 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4059 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4060 Omit unused local vars.
4061 * window.c (shrink_windows): Omit unused local var.
4062 * menu.c (digest_single_submenu): Omit unused local var.
4063 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4064 Omit unused local var.
4065
4066 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4067 Don't assume string length fits in int.
4068 (keyremap_step, read_key_sequence): Use size_t for sizes.
4069 (read_key_sequence): Don't check last_real_key_start redundantly.
4070
4071 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4072 instead of alloca (Bug#8344).
4073
4074 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4075 (Fbacktrace_frame): Don't assume nframes fits in int.
4076
4077 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4078
4079 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4080 concerns.
4081
4082 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4083
4084 * cm.c (calccost): Turn while-do into do-while, for clarity.
4085
4086 * keyboard.c (syms_of_keyboard): Use the same style as later
4087 in this function when indexing through an array. This also
4088 works around GCC bug 48267.
4089
4090 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4091
4092 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4093
4094 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4095 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4096
4097 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4098 This avoids undefined behavior on integer overflow, and is a bit
4099 more convenient anyway since it is compared to a size_t variable.
4100
4101 Variadic C functions now count arguments with size_t, not int.
4102 This avoids an unnecessary limitation on 64-bit machines, which
4103 caused (substring ...) to crash on large vectors (Bug#8344).
4104 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4105 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4106 All variadic functions and their callers changed accordingly.
4107 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4108 * data.c (arith_driver, float_arith_driver): Likewise.
4109 * editfns.c (general_insert_function): Likewise.
4110 * eval.c (struct backtrace.nargs, interactive_p)
4111 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4112 (funcall_lambda, mark_backtrace): Likewise.
4113 * fns.c (concat): Likewise.
4114 * frame.c (x_set_frame_parameters): Likewise.
4115 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4116 0 if not found, not -1. All callers changed.
4117
4118 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4119 (stack_copy_size): Now size_t, not int.
4120 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4121
4122 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4123
4124 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4125 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4126 All callers changed.
4127
4128 * lisp.h (multibyte_char_to_unibyte):
4129 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4130 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4131 * character.h (CHAR_TO_BYTE8):
4132 * cmds.c (internal_self_insert):
4133 * editfns.c (general_insert_function):
4134 * keymap.c (push_key_description):
4135 * search.c (Freplace_match):
4136 * xdisp.c (message_dolog, set_message_1): All callers changed.
4137
4138 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4139
4140 * keyboard.c (safe_run_hook_funcall): New function.
4141 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4142 don't set the hook to nil, but remove the offending function instead.
4143 (Qcommand_hook_internal): Remove, unused.
4144 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4145 Vcommand_hook_internal.
4146
4147 * eval.c (enum run_hooks_condition): Remove.
4148 (funcall_nil, funcall_not): New functions.
4149 (run_hook_with_args): Call each function through a `funcall' argument.
4150 Remove `cond' argument, now redundant.
4151 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4152 (Frun_hook_with_args_until_failure): Adjust accordingly.
4153 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4154
4155 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4156
4157 * dispextern.h (string_buffer_position): Remove declaration.
4158
4159 * print.c (strout): Remove parameter `multibyte', unused since
4160 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4161
4162 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4163 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4164 All callers changed.
4165
4166 * w32.c (_wsa_errlist): Use braces for struct initializers.
4167
4168 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4169 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4170 All callers changed.
4171 (string_buffer_position): Likewise. Also, make static (it's never
4172 used outside xdisp.c).
4173 (cursor_row_p): Remove parameter `w', unused since
4174 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4175 (decode_mode_spec): Remove parameter `precision', introduced during
4176 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4177 All callers changed.
4178
4179 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4180
4181 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4182
4183 2011-03-27 Anders Lindgren <andlind@gmail.com>
4184
4185 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4186 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4187 (ns_update_auto_hide_menu_bar): New functions.
4188 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4189 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4190 ns_constrain_all_frames.
4191 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4192 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4193
4194 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4195
4196 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4197
4198 2011-03-27 Glenn Morris <rgm@gnu.org>
4199
4200 * syssignal.h: Replace RETSIGTYPE with void.
4201 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4202 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4203 Replace SIGTYPE with void everywhere.
4204 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4205 * s/template.h (SIGTYPE): Remove commented out definition.
4206
4207 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4208
4209 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4210 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4211
4212 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4213
4214 * w32.c (read_unc_volume): Use parameter `henum', instead of
4215 global variable `wget_enum_handle'.
4216
4217 * keymap.c (describe_vector): Remove parameters `indices' and
4218 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4219 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4220
4221 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4222
4223 * keyboard.c (timer_check): Remove parameter `do_it_now',
4224 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4225 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4226 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4227
4228 * keyboard.c (read_char):
4229 * w32menu.c (w32_menu_display_help):
4230 * xmenu.c (show_help_event, menu_help_callback):
4231 Adjust calls to `show_help_echo'.
4232
4233 * gtkutil.c (xg_maybe_add_timer):
4234 * keyboard.c (readable_events):
4235 * process.c (wait_reading_process_output):
4236 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4237
4238 * insdel.c (adjust_markers_gap_motion):
4239 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4240 (gap_left, gap_right): Don't call it.
4241
4242 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4243
4244 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4245 incurred during fontification.
4246
4247 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4248
4249 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4250 (DEFVAR_PER_BUFFER): Don't pass it.
4251
4252 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4253 (scrolling_window): Don't pass it.
4254
4255 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4256
4257 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4258
4259 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4260 and `suffix'.
4261 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4262 of variables specific to SELinux and computation of `encoded_absname'.
4263
4264 * image.c (XPutPixel): Remove unused variable `height'.
4265
4266 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4267
4268 * unexw32.c (get_section_info): Remove unused variable `section'.
4269
4270 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4271 (system_process_attributes): Remove unused variable `sess'.
4272 (sys_read): Remove unused variable `err'.
4273
4274 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4275 (w32_wnd_proc): Remove unused variable `isdead'.
4276 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4277 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4278 (x_create_tip_frame): Remove unused variable `tem'.
4279
4280 * w32inevt.c (w32_console_read_socket):
4281 Remove unused variable `no_events'.
4282
4283 * w32term.c (x_draw_composite_glyph_string_foreground):
4284 Remove unused variable `width'.
4285
4286 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4287
4288 * w32term.c (x_set_glyph_string_clipping):
4289 Don't pass uninitialized region to CombineRgn.
4290
4291 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4292
4293 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4294 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4295 (Fx_close_connection): Remove unused variable `i'.
4296
4297 * w32font.c (w32font_draw): Return number of glyphs.
4298 (w32font_open_internal): Remove unused variable `i'.
4299 (w32font_driver): Add missing initializer.
4300
4301 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4302 (fill_in_menu): Remove unused variable `items_added'.
4303
4304 * w32term.c (last_mouse_press_frame): Remove static global variable.
4305 (w32_clip_to_row): Remove unused variable `f'.
4306 (x_delete_terminal): Remove unused variable `i'.
4307
4308 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4309 (NOTHING): Remove unused static global variable.
4310 (uniscribe_check_otf): Remove unused variable `table'.
4311 (uniscribe_font_driver): Add missing initializers.
4312
4313 2011-03-23 Julien Danjou <julien@danjou.info>
4314
4315 * term.c (Fsuspend_tty, Fresume_tty):
4316 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4317 * window.c (temp_output_buffer_show):
4318 * insdel.c (signal_before_change):
4319 * frame.c (Fhandle_switch_frame):
4320 * fileio.c (Fdo_auto_save):
4321 * emacs.c (Fkill_emacs):
4322 * editfns.c (save_excursion_restore):
4323 * cmds.c (internal_self_insert):
4324 * callint.c (Fcall_interactively):
4325 * buffer.c (Fkill_all_local_variables):
4326 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4327 Use Frun_hooks.
4328 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4329 unconditionnaly since it does the check itself.
4330
4331 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4332
4333 Fix more problems found by GCC 4.5.2's static checks.
4334
4335 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4336 the first time through the loop, since we know p0 < p1 then.
4337 This also avoids a gcc -Wstrict-overflow warning.
4338
4339 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4340 leading to a memory leak, possible in functions like
4341 load_charset_map_from_file that can allocate an unbounded number
4342 of objects (Bug#8318).
4343
4344 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4345 that could (at least in theory) be that large.
4346
4347 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4348 This is less likely to overflow, and avoids undefined behavior if
4349 overflow does occur. All callers changed. Use strtoul to scan
4350 for the unsigned long integer.
4351 (pint2hrstr): Simplify and tune code slightly.
4352 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4353
4354 * scroll.c (do_scrolling): Work around GCC bug 48228.
4355 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4356
4357 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4358 This also avoids a warning with gcc -Wstrict-overflow.
4359 (validate_x_resource_name): Simplify count usage.
4360 This also avoids a warning with gcc -Wstrict-overflow.
4361
4362 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4363 fail (Bug#8306).
4364
4365 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4366
4367 * process.c (Fmake_network_process): Use socklen_t, not int,
4368 where POSIX says socklen_t is required in portable programs.
4369 This fixes a porting bug on hosts like 64-bit HP-UX, where
4370 socklen_t is wider than int (Bug#8277).
4371 (Fmake_network_process, server_accept_connection):
4372 (wait_reading_process_output, read_process_output):
4373 Likewise.
4374
4375 * process.c: Rename or move locals to avoid shadowing.
4376 (list_processes_1, Fmake_network_process):
4377 (read_process_output_error_handler, exec_sentinel_error_handler):
4378 Rename or move locals.
4379 (Fmake_network_process): Define label "retry_connect" only if needed.
4380 (Fnetwork_interface_info): Fix pointer signedness.
4381 (process_send_signal): Add cast to avoid pointer signedness problem.
4382 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4383 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4384
4385 Make tparam.h and terminfo.c consistent.
4386 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4387 Include tparam.h instead, since it declares them.
4388 * cm.h (PC): Remove extern decl; tparam.h now does this.
4389 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4390 * terminfo.c: Include tparam.h, to check interfaces.
4391 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4392 (tparam): Adjust signature to match interface in tparam.h;
4393 this removes some undefined behavior. Check that outstring and len
4394 are zero, which they always are with Emacs.
4395 * tparam.h (PC, BC, UP): New extern decls.
4396
4397 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4398 (xftfont_open): Rename locals to avoid shadowing.
4399
4400 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4401 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4402 (OTF_TAG_SYM): Omit macro if not needed.
4403 (ftfont_list): Remove unused local.
4404 (get_adstyle_property, ftfont_pattern_entity):
4405 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4406 Rename locals to avoid shadowing.
4407
4408 * xfont.c (xfont_list_family): Mark var as initialized.
4409
4410 * xml.c (make_dom): Now static.
4411
4412 * composite.c (composition_compute_stop_pos): Rename local to
4413 avoid shadowing.
4414 (composition_reseat_it): Remove unused locals.
4415 (find_automatic_composition, composition_adjust_point): Likewise.
4416 (composition_update_it): Mark var as initialized.
4417 (find_automatic_composition): Mark vars as initialized,
4418 with a FIXME (Bug#8290).
4419
4420 character.h: Rename locals to avoid shadowing.
4421 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4422 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4423 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4424 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4425 to avoid shadowing.
4426
4427 * textprop.c (property_change_between_p): Remove; unused.
4428
4429 * intervals.c (interval_start_pos): Now static.
4430
4431 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4432
4433 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4434 Rename locals to avoid shadowing.
4435
4436 * sound.c (wav_play, au_play, Fplay_sound_internal):
4437 Fix pointer signedness.
4438 (alsa_choose_format): Remove unused local var.
4439 (wav_play): Initialize a variable to 0, to prevent undefined
4440 behavior (Bug#8278).
4441
4442 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4443
4444 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4445
4446 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4447 clobbering (Bug#8298).
4448 * sysdep.c (sys_subshell): Likewise.
4449 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4450
4451 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4452 This should get cleaned up, so that child_setup has the
4453 same signature on all platforms.
4454
4455 * callproc.c (call_process_cleanup): Now static.
4456 (relocate_fd): Rename locals to avoid shadowing.
4457
4458 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4459
4460 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4461 not to be necessary, and produces flickering.
4462
4463 2011-03-20 Glenn Morris <rgm@gnu.org>
4464
4465 * config.in: Remove file.
4466
4467 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4468
4469 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4470 are now in src/globals.h.
4471 (syms_of_minibuf): Remove spurious & from previous change.
4472
4473 2011-03-20 Leo <sdl.web@gmail.com>
4474
4475 * minibuf.c (completing-read-function): New variable.
4476 (completing-read-default): Rename from completing-read.
4477 (completing-read): Call completing-read-function.
4478
4479 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4480
4481 * xfaces.c (Fx_load_color_file):
4482 Read color file from absolute filename (bug#8250).
4483
4484 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4485
4486 * makefile.w32-in: Update dependencies.
4487
4488 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4489
4490 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4491
4492 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4493
4494 Fix more problems found by GCC 4.5.2's static checks.
4495
4496 * process.c (make_serial_process_unwind, send_process_trap):
4497 (sigchld_handler): Now static.
4498
4499 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4500 That way, the code declares only the vars that it needs.
4501 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4502 * s/cygwin.h (PTY_ITERATION): Likewise.
4503 * s/darwin.h (PTY_ITERATION): Likewise.
4504 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4505
4506 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4507 * process.c (allocate_pty): Don't declare stb unless it's needed.
4508
4509 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4510 (CONSTANTLIM): Remove; unused.
4511 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4512 Define only if needed.
4513
4514 * unexelf.c (unexec): Name an expression,
4515 to avoid gcc -Wbad-function-cast warning.
4516 Use a different way to cause a compilation error if anyone uses
4517 n rather than nn, a way that does not involve shadowing.
4518 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4519
4520 * deps.mk (unexalpha.o): Remove; unused.
4521
4522 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4523 * unexec.h: New file.
4524 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4525 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4526 Depend on unexec.h.
4527 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4528 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4529 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4530 Change as necessary to match prototype in unexec.h.
4531
4532 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4533 shadowing.
4534 (back_comment, skip_chars): Mark vars as initialized.
4535
4536 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4537 Rename locals to avoid shadowing.
4538
4539 * lread.c (read1): Rewrite so as not to use empty "else".
4540 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4541
4542 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4543
4544 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4545 warning when compiling print.c.
4546
4547 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4548 instead of using an uninitialized var.
4549 (font_sort_entities): Mark var as initialized.
4550
4551 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4552
4553 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4554 pointers to constants.
4555 (font_parse_fcname): Remove unused vars.
4556 (font_delete_unmatched): Now static.
4557 (font_get_spec): Remove; unused.
4558 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4559 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4560 Rename or move locals to avoid shadowing.
4561
4562 * fns.c (require_nesting_list, require_unwind): Now static.
4563 (Ffillarray): Rename locals to avoid shadowing.
4564
4565 * floatfns.c (domain_error2): Define only if needed.
4566 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4567
4568 * alloc.c (mark_backtrace): Move decl from here ...
4569 * lisp.h: ... to here, so that it can be checked.
4570
4571 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4572 (Fdefvar): Rewrite so as not to use empty "else".
4573 (lisp_indirect_variable): Name an expression,
4574 to avoid gcc -Wbad-function-cast warning.
4575 (Fdefvar): Rename locals to avoid shadowing.
4576
4577 * callint.c (quotify_arg, quotify_args): Now static.
4578 (Fcall_interactively): Rename locals to avoid shadowing.
4579 Use const pointer when appropriate.
4580
4581 * lisp.h (get_system_name, get_operating_system_release):
4582 Move decls here, to check interfaces.
4583 * process.c (get_operating_system_release): Move decl to lisp.h.
4584 * xrdb.c (get_system_name): Likewise.
4585 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4586 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4587 some of which prompt warnings from gcc -Wbad-function-cast.
4588 (Fformat_time_string, Fencode_time, Finsert_char):
4589 (Ftranslate_region_internal, Fformat):
4590 Rename or remove local vars to avoid shadowing.
4591 (Ftranslate_region_internal): Mark var as initialized.
4592
4593 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4594 avoid shadowing.
4595
4596 * lisp.h (eassert): Check that the argument compiles, even if
4597 ENABLE_CHECKING is not defined.
4598
4599 * data.c (Findirect_variable): Name an expression, to avoid
4600 gcc -Wbad-function-cast warning.
4601 (default_value, arithcompare, arith_driver, arith_error): Now static.
4602 (store_symval_forwarding): Rename local to avoid shadowing.
4603 (Fmake_variable_buffer_local, Fmake_local_variable):
4604 Mark variables as initialized.
4605 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4606
4607 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4608 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4609 Rename locals to avoid shadowing.
4610 (mark_stack): Move local variables into the #ifdef region where
4611 they're used.
4612 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4613 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4614 needed otherwise.
4615 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4616 (GC_STRING_CHARS): Remove; not used.
4617 (Fmemory_limit): Cast sbrk's returned value to char *.
4618
4619 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4620 avoids undefined behavior in theory.
4621
4622 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4623
4624 Use functions, not macros, for up- and down-casing (Bug#8254).
4625 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4626 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4627 to use the following functions instead of these macros.
4628 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4629 EMACS_INT, since callers assume the returned value fits in int.
4630 (upcase1): Likewise, for UPCASE_TABLE.
4631 (uppercasep, lowercasep, upcase): New static inline functions.
4632 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4633 the race-condition problem in the old DOWNCASE.
4634
4635 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4636 Rename locals to avoid shadowing.
4637 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4638 (regex_compile, re_search_2, re_match_2_internal):
4639 Remove unused local vars.
4640 (FREE_VAR): Rewrite so as not to use empty "else",
4641 which gcc can warn about.
4642 (regex_compile, re_match_2_internal): Mark locals as initialized.
4643 (RETALLOC_IF): Define only if needed.
4644 (WORDCHAR_P): Likewise. This one is never needed, but is used
4645 only in a comment talking about a compiler bug, so put inside
4646 the #if 0 of that comment.
4647 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4648 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4649 Remove; unused.
4650
4651 * search.c (boyer_moore): Rename locals to avoid shadowing.
4652 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4653 (PREV_CHAR_BOUNDARY): Likewise.
4654
4655 * search.c (simple_search): Remove unused var.
4656
4657 * dired.c (compile_pattern): Move decl from here ...
4658 * lisp.h: ... to here, so that it can be checked.
4659 (struct re_registers): New forward decl.
4660
4661 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4662
4663 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4664 All uses changed.
4665 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4666 Rename locals to avoid shadowing.
4667 (Fvertical_motion): Mark locals as initialized.
4668
4669 * casefiddle.c (casify_object, casify_region): Now static.
4670 (casify_region): Mark local as initialized.
4671
4672 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4673
4674 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4675 New macros, so that the caller can use some names other than
4676 gcpro1, gcpro2, etc.
4677 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4678 of the new macros.
4679 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4680 argument, for consistency with GCPRO2_VAR, etc: it is now the
4681 prefix of the variable, not the variable itself. All uses
4682 changed.
4683 * dired.c (directory_files_internal, file_name_completion):
4684 Rename locals to avoid shadowing.
4685
4686 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4687 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4688 dired.c's scmp function, had undefined behavior.
4689 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4690 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4691 * buffer.h: ... to here, because these macros use current_buffer,
4692 and the new implementation with inline functions needs to have
4693 current_buffer in scope now, rather than later when the macros
4694 are used.
4695 (downcase, upcase1): New static inline functions.
4696 (DOWNCASE, UPCASE1): Reimplement using these functions.
4697 This avoids undefined behavior in expressions like
4698 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4699 from race conditions in accessing the global variables
4700 case_temp1 and case_temp2.
4701 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4702 * lisp.h (case_temp1, case_temp2): Remove their decls.
4703 * character.h (ASCII_CHAR_P): Move from here ...
4704 * lisp.h: ... to here, so that the inline functions mentioned
4705 above can use them.
4706
4707 * dired.c (directory_files_internal_unwind): Now static.
4708
4709 * fileio.c (file_name_as_directory, directory_file_name):
4710 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4711 Now static.
4712 (file_name_as_directory): Use const pointers when appropriate.
4713 (Fexpand_file_name): Likewise. In particular, newdir might
4714 point at constant storage, so make it a const pointer.
4715 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4716 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4717 signedness issues.
4718 (Fset_file_times, Finsert_file_contents, auto_save_error):
4719 Rename locals to avoid shadowing.
4720
4721 * minibuf.c (choose_minibuf_frame_1): Now static.
4722 (Ftry_completion, Fall_completions): Rename or remove locals
4723 to avoid shadowing.
4724
4725 * marker.c (bytepos_to_charpos): Remove; unused.
4726
4727 * lisp.h (verify_bytepos, count_markers): New decls,
4728 so that gcc does not warn that these functions aren't declared.
4729
4730 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4731 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4732 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4733 (copy_text): Remove unused local var.
4734
4735 * filelock.c (within_one_second): Now static.
4736 (lock_file_1): Rename local to avoid shadowing.
4737
4738 * buffer.c (fix_overlays_before): Mark locals as initialized.
4739 (fix_start_end_in_overlays): Likewise. This function should be
4740 simplified by using pointers-to-pointers, but that's a different
4741 matter.
4742 (switch_to_buffer_1): Now static.
4743 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4744 (report_overlay_modification): Rename locals to avoid shadowing.
4745
4746 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4747 Fix pointer signedness issue.
4748 (sys_subshell): Mark local as volatile if checking for lint,
4749 to suppress a gcc -Wclobbered warning that does not seem to be right.
4750 (MAXPATHLEN): Define only if needed.
4751
4752 * process.c (serial_open, serial_configure): Move decls from here ...
4753 * systty.h: ... to here, so that they can be checked.
4754
4755 * fns.c (get_random, seed_random): Move extern decls from here ...
4756 * lisp.h: ... to here, so that they can be checked.
4757
4758 * sysdep.c (reset_io): Now static.
4759 (wait_for_termination_signal): Remove; unused.
4760
4761 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4762 (copy_keymap_item, append_key, push_text_char_description):
4763 Now static.
4764 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4765 (DENSE_TABLE_SIZE): Remove; unused.
4766 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4767 (describe_map_tree):
4768 Rename locals to avoid shadowing.
4769
4770 * keyboard.c: Declare functions static if they are not used elsewhere.
4771 (echo_char, echo_dash, cmd_error, top_level_2):
4772 (poll_for_input, handle_async_input): Now static.
4773 (read_char, kbd_buffer_get_event, make_lispy_position):
4774 (make_lispy_event, make_lispy_movement, apply_modifiers):
4775 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4776 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4777 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4778 (read_key_sequence, read_char): Mark locals as initialized.
4779 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4780
4781 * keyboard.h (make_ctrl_char): New decl.
4782 (mark_kboards): Move decl here ...
4783 * alloc.c (mark_kboards): ... from here.
4784
4785 * lisp.h (force_auto_save_soon): New decl.
4786
4787 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4788 (DEFINE_DUMMY_FUNCTION): New macro.
4789 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4790 Use it.
4791 (main): Add casts to avoid warnings
4792 if GCC considers string literals to be constants.
4793
4794 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4795
4796 * dbusbind.c: Pointer signedness fixes.
4797 (xd_signature, xd_append_arg, xd_initialize):
4798 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4799 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4800 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4801 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4802
4803 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4804 if GCC considers string literals to be constants.
4805 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4806
4807 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4808
4809 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4810 (print_preprocess, print_object): New macro to fix last change.
4811
4812 * print.c (print_preprocess): Don't forget font objects.
4813
4814 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4815
4816 * emacs.c (USAGE3): Doc fixes.
4817
4818 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4819
4820 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4821 structure.
4822
4823 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4824
4825 * lisp.h (VWindow_system, Qfile_name_history):
4826 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4827 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4828 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4829
4830 * w32select.c: Don't #include "keyboard.h".
4831 (run_protected): Add extern declaration for waiting_for_input.
4832
4833 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4834 * w32console.c (detect_input_pending, read_input_pending)
4835 (encode_terminal_code):
4836 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4837 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4838 (w32_system_caret_y, Qfile_name_history):
4839 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4840 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4841 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4842 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4843 * w32proc.c (Qlocal, report_file_error):
4844 * w32term.c (Vwindow_system, updating_frame):
4845 * w32uniscribe.c (initialized, uniscribe_font_driver):
4846 Remove unneeded extern declarations.
4847
4848 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4849
4850 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4851
4852 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4853
4854 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4855 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4856 These macros can no longer be used for assignment.
4857
4858 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4859 Assign struct members directly, instead of using BUF_BEGV etc.
4860 (record_buffer_markers, fetch_buffer_markers): New functions for
4861 recording and fetching special buffer markers.
4862 (set_buffer_internal_1, set_buffer_temp): Use them.
4863
4864 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4865
4866 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4867
4868 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4869 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4870
4871 * xdisp.c (hscroll_window_tree):
4872 (reconsider_clip_changes): Use PT instead of BUF_PT.
4873
4874 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4875
4876 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4877 $(EMACS_ROOT)/lib/intprops.h.
4878
4879 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4880
4881 Fix more problems found by GCC 4.5.2's static checks.
4882
4883 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4884 to unsigned char * to avoid compiler diagnostic.
4885 (xg_free_frame_widgets): Make it clear that a local variable is
4886 needed only if USE_GTK_TOOLTIP.
4887 (gdk_window_get_screen): Make it clear that this macro is needed
4888 only if USE_GTK_TOOLTIP.
4889 (int_gtk_range_get_value): New function, which avoids a diagnostic
4890 from gcc -Wbad-function-cast.
4891 (xg_set_toolkit_scroll_bar_thumb): Use it.
4892 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4893 diagnostic from gcc -Wbad-function-cast.
4894 (get_utf8_string, xg_get_file_with_chooser):
4895 Rename locals to avoid shadowing.
4896 (create_dialog): Move locals to avoid shadowing.
4897
4898 * xgselect.c (xg_select): Remove unused var.
4899
4900 * image.c (four_corners_best): Mark locals as initialized.
4901 (gif_load): Initialize transparent_p to zero (Bug#8238).
4902 Mark another local as initialized.
4903 (my_png_error, my_error_exit): Mark with NO_RETURN.
4904
4905 * image.c (clear_image_cache): Now static.
4906 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4907 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4908 (x_edge_detection): Remove unnecessary cast that
4909 gcc -Wbad-function-cast diagnoses.
4910 (gif_load): Fix pointer signedness.
4911 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4912 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4913
4914 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4915
4916 Improve quality of tests for time stamp overflow.
4917 For example, without this patch (encode-time 0 0 0 1 1
4918 1152921504606846976) returns the obviously-bogus value (-948597
4919 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4920 reports time overflow. See
4921 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4922 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4923 * editfns.c: Include limits.h and intprops.h.
4924 (TIME_T_MIN, TIME_T_MAX): New macros.
4925 (time_overflow): Move earlier, to before first use.
4926 (hi_time, lo_time): New functions, for an accurate test for
4927 out-of-range times.
4928 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4929 (Fget_internal_run_time): Don't assume time_t fits in int.
4930 (make_time): Use list2 instead of Fcons twice.
4931 (Fdecode_time): More accurate test for out-of-range times.
4932 (check_tm_member): New function.
4933 (Fencode_time): Use it, to test for out-of-range times.
4934 (lisp_time_argument): Don't rely on undefined left-shift and
4935 right-shift behavior when checking for time stamp overflow.
4936
4937 * editfns.c (time_overflow): New function, refactoring common code.
4938 (Fformat_time_string, Fdecode_time, Fencode_time):
4939 (Fcurrent_time_string): Use it.
4940
4941 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4942 * dired.c (make_time): Move to ...
4943 * editfns.c (make_time): ... here.
4944 * systime.h: Note the move.
4945
4946 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4947
4948 * fringe.c (update_window_fringes): Remove unused variables.
4949
4950 * unexmacosx.c (copy_data_segment): Also copy __got section.
4951 (Bug#8223)
4952
4953 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4954
4955 * termcap.c [MSDOS]: Include "msdos.h".
4956 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4957 Constify `char *' arguments and their references according to
4958 prototypes in tparam.h.
4959
4960 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4961
4962 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4963 Adapt all references accordingly.
4964
4965 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4966
4967 2011-03-11 Tom Tromey <tromey@redhat.com>
4968
4969 * buffer.c (syms_of_buffer): Remove obsolete comment.
4970
4971 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4972
4973 * termhooks.h (encode_terminal_code): Declare prototype.
4974
4975 * msdos.c (encode_terminal_code): Don't declare prototype.
4976
4977 * term.c (encode_terminal_code): Now external again, used by
4978 w32console.c and msdos.c.
4979
4980 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4981 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4982
4983 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4984
4985 Fix some minor problems found by GCC 4.5.2's static checks.
4986
4987 * fringe.c (update_window_fringes): Mark locals as initialized
4988 (Bug#8227).
4989 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4990
4991 * alloc.c (mark_fringe_data): Move decl from here ...
4992 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4993 to check its interface.
4994 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4995
4996 * fontset.c (free_realized_fontset): Now static.
4997 (Fset_fontset_font): Rename local to avoid shadowing.
4998 (fontset_font): Mark local as initialized.
4999 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5000
5001 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5002
5003 * xselect.c (x_disown_buffer_selections): Remove; not used.
5004 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5005 (x_own_selection, Fx_disown_selection_internal): Rename locals
5006 to avoid shadowing.
5007 (x_handle_dnd_message): Remove local to avoid shadowing.
5008
5009 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5010 so that the caller can use some name other than gcpro1.
5011 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5012 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5013 (Fx_backspace_delete_keys_p):
5014 Use them to avoid shadowing, and rename vars to avoid shadowing.
5015 (x_decode_color, x_set_name, x_window): Now static.
5016 (Fx_create_frame): Add braces to silence GCC warning.
5017 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5018 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5019 Remove unused locals.
5020 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5021 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5022 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5023 macros.
5024
5025 * xterm.h (x_mouse_leave): New decl.
5026
5027 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5028 Remove unused functions.
5029 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5030 (x_calc_absolute_position): Now static.
5031 (XTread_socket): Don't define label "out" unless it's used.
5032 Don't declare local "event" unless it's used.
5033 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5034 unless they are used.
5035 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5036 (x_fatal_error_signal): Remove; not used.
5037 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5038 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5039 (x_error_catcher, x_connection_closed, x_error_handler):
5040 (x_error_quitter, xembed_send_message, x_iconify_frame):
5041 (my_log_handler): Rename locals to avoid shadowing.
5042 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5043 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5044
5045 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5046 Rename or move locals to avoid shadowing.
5047 (tty_defined_color, merge_face_heights): Now static.
5048 (free_realized_faces_for_fontset): Remove; not used.
5049 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5050 does not deduce is never used uninitialized.
5051 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5052 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5053
5054 * terminal.c (store_terminal_param): Now static.
5055
5056 * xmenu.c (menu_highlight_callback): Now static.
5057 (set_frame_menubar): Remove unused local.
5058 (xmenu_show): Rename parameter to avoid shadowing.
5059 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5060 since they might point to immutable storage.
5061 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5062 since it's unused otherwise.
5063
5064 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5065 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5066 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5067 avoids a gcc -Wuninitialized diagnostic.
5068 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5069 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5070 does not deduce are never used uninitialized.
5071
5072 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5073
5074 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5075 * window.c (window_loop, size_window):
5076 (run_window_configuration_change_hook, enlarge_window): Likewise.
5077
5078 * window.c (display_buffer): Now static.
5079 (size_window): Mark variables that gcc -Wuninitialized
5080 does not deduce are never used uninitialized.
5081 * window.h (check_all_windows): New decl, to forestall
5082 gcc -Wmissing-prototypes diagnostic.
5083 * dispextern.h (bidi_dump_cached_states): Likewise.
5084
5085 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5086 shadowing.
5087 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5088 Include <limits.h>.
5089 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5090 and to avoid gcc -Wuninitialized warning.
5091 (load_charset_map): Mark variables that gcc -Wuninitialized
5092 does not deduce are never used uninitialized.
5093 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5094
5095 * coding.c (coding_set_source, coding_set_destination):
5096 Use "else { /* comment */ }" rather than "else /* comment */;"
5097 for clarity, and to avoid gcc -Wempty-body warning.
5098 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5099 a block, when the outer 'i' will do.
5100 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5101 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5102 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5103 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5104 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5105 Rename locals to avoid shadowing.
5106 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5107 * coding.c (emacs_mule_char, encode_invocation_designation):
5108 Now static, since they're not used elsewhere.
5109 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5110 (decode_coding_object, encode_coding_object, detect_coding_system):
5111 (decode_coding_emacs_mule): Mark variables that gcc
5112 -Wuninitialized does not deduce are never used uninitialized.
5113 (detect_coding_iso_2022): Initialize a local variable that might
5114 be used uninitialized. Leave a FIXME because it's not clear that
5115 this initialization is needed. (Bug#8211)
5116 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5117 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5118 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5119 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5120 Remove unused macros.
5121
5122 * category.c (hash_get_category_set): Remove unused local var.
5123 (copy_category_table): Now static, since it's not used elsewhere.
5124 * character.c (string_count_byte8): Likewise.
5125
5126 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5127 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5128
5129 * chartab.c (copy_sub_char_table): Now static, since it's not used
5130 elsewhere.
5131 (sub_char_table_ref_and_range, char_table_ref_and_range):
5132 Rename locals to avoid shadowing.
5133 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5134
5135 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5136 (BIDI_BOB): Remove unused macro.
5137
5138 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5139 deduce are never used uninitialized.
5140 * term.c (encode_terminal_code): Likewise.
5141
5142 * term.c (encode_terminal_code): Now static. Remove unused local.
5143
5144 * tparam.h: New file.
5145 * term.c, tparam.h: Include it.
5146 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5147 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5148 Move these decls to tparam.h, and make them agree with what
5149 is actually in tparam.c. The previous trick of using incompatible
5150 decls in different modules does not conform to the C standard.
5151 All callers of tparam changed to use tparam's actual API.
5152 * tparam.c (tparam1, tparam, tgoto):
5153 Use const pointers where appropriate.
5154
5155 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5156 * cm.h (struct cm): Likewise.
5157 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5158 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5159 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5160 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5161 (turn_on_face, init_tty): Likewise.
5162 * termchar.h (struct tty_display_info): Likewise.
5163
5164 * term.c (term_mouse_position): Rename local to avoid shadowing.
5165
5166 * alloc.c (mark_ttys): Move decl from here ...
5167 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5168
5169 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5170
5171 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5172
5173 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5174
5175 * search.c (compile_pattern_1): Remove argument regp, unused since
5176 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5177 (compile_pattern): Don't pass it.
5178
5179 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5180
5181 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5182 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5183 for ! HAVE_GTK3.
5184 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5185
5186 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5187
5188 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5189 gdk_window_get_screen, gdk_window_get_geometry,
5190 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5191 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5192 (xg_get_pixbuf_from_pixmap): New function.
5193 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5194 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5195 Call xg_get_pixbuf_from_pixmap instead of
5196 gdk_pixbuf_get_from_drawable.
5197 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5198 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5199 (xg_check_special_colors): Use GtkStyleContext and its functions
5200 for HAVE_GTK3.
5201 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5202 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5203 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5204 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5205 Call gtk_widget_get_preferred_size.
5206 (xg_frame_resized): gdk_window_get_geometry only takes 5
5207 parameters.
5208 (xg_win_to_widget, xg_event_is_for_menubar):
5209 Call gdk_x11_window_lookup_for_display.
5210 (xg_set_widget_bg): New function.
5211 (delete_cb): New function.
5212 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5213 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5214 (xg_set_background_color): Call xg_set_widget_bg.
5215 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5216 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5217 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5218 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5219 if ! HAVE_GTK3.
5220 (update_frame_tool_bar): Call gtk_widget_hide.
5221 (xg_initialize): Use GDK_KEY_g.
5222
5223 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5224 if ! HAVE_GTK3
5225 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5226
5227 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5228 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5229 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5230
5231 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5232
5233 * w32xfns.c (select_palette): Check success of RealizePalette against
5234 GDI_ERROR, not zero.
5235
5236 See ChangeLog.11 for earlier changes.
5237
5238 ;; Local Variables:
5239 ;; coding: utf-8
5240 ;; End:
5241
5242 Copyright (C) 2011 Free Software Foundation, Inc.
5243
5244 This file is part of GNU Emacs.
5245
5246 GNU Emacs is free software: you can redistribute it and/or modify
5247 it under the terms of the GNU General Public License as published by
5248 the Free Software Foundation, either version 3 of the License, or
5249 (at your option) any later version.
5250
5251 GNU Emacs is distributed in the hope that it will be useful,
5252 but WITHOUT ANY WARRANTY; without even the implied warranty of
5253 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5254 GNU General Public License for more details.
5255
5256 You should have received a copy of the GNU General Public License
5257 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.