* vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-14 Paul Eggert <eggert@cs.ucla.edu>
2
3 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4 * mem-limits.h (SIZE): Remove; no longer used.
5
6 2011-06-13 Paul Eggert <eggert@cs.ucla.edu>
7
8 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9
10 Remove unnecessary casts.
11 * xterm.c (x_term_init):
12 * xfns.c (x_set_border_pixel):
13 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
14 These aren't needed now that we assume ANSI C.
15
16 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
17 It's more likely to cause problems (due to unsigned overflow)
18 than to cure them.
19
20 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
21
22 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
23
24 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
25
26 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
27
28 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
29
30 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
31
32 GLYPH_CODE_FACE returns EMACS_INT, not int.
33 * dispextern.h (merge_faces):
34 * xfaces.c (merge_faces):
35 * xdisp.c (get_next_display_element, next_element_from_display_vector):
36 Don't assume EMACS_INT fits in int.
37
38 * character.h (CHAR_VALID_P): Remove unused parameter.
39 * fontset.c, lisp.h, xdisp.c: All uses changed.
40
41 * editfns.c (Ftranslate_region_internal): Omit redundant test.
42
43 * fns.c (concat): Minor tuning based on overflow analysis.
44 This doesn't fix any bugs. Use int to hold character, instead
45 of constantly refetching from Emacs object. Use XFASTINT, not
46 XINT, for value known to be a character. Don't bother comparing
47 a single byte to 0400, as it's always less.
48
49 * floatfns.c (Fexpt):
50 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
51
52 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
53 for characters.
54
55 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
56
57 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
58 Without this fix, on a 64-bit host (aset S 0 4294967386) would
59 incorrectly succeed when S was a string, because 4294967386 was
60 truncated before it was used.
61
62 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
63 Otherwise, an out-of-range integer could cause undefined behavior
64 on a 64-bit host.
65
66 * composite.c: Use int, not EMACS_INT, for characters.
67 (fill_gstring_body, composition_compute_stop_pos): Use int, not
68 EMACS_INT, for values that are known to be in character range.
69 This doesn't fix any bugs but is the usual style inside Emacs and
70 may generate better code on 32-bit machines.
71
72 Make sure a 64-bit char is never passed to ENCODE_CHAR.
73 This is for reasons similar to the recent CHAR_STRING fix.
74 * charset.c (Fencode_char): Check that character arg is actually
75 a character. Pass an int to ENCODE_CHAR.
76 * charset.h (ENCODE_CHAR): Verify that the character argument is no
77 wider than 'int', as a compile-time check to prevent future regressions
78 in this area.
79
80 * character.c (char_string): Remove unnecessary casts.
81
82 Make sure a 64-bit char is never passed to CHAR_STRING.
83 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
84 by silently ignoring the top 32 bits, allowing some values
85 that were far too large to be valid characters.
86 * character.h: Include <verify.h>.
87 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
88 arguments are no wider than unsigned, as a compile-time check
89 to prevent future regressions in this area.
90 * data.c (Faset):
91 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
92 (Fsubst_char_in_region):
93 * fns.c (concat):
94 * xdisp.c (decode_mode_spec_coding):
95 Adjust to CHAR_STRING's new requirement.
96 * editfns.c (Finsert_char, Fsubst_char_in_region):
97 * fns.c (concat): Check that character args are actually
98 characters. Without this test, these functions did the wrong
99 thing with wildly out-of-range values on 64-bit hosts.
100
101 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
102 These casts should not be needed on 32-bit hosts, either.
103 * keyboard.c (read_char):
104 * lread.c (Fload): Remove casts to unsigned.
105
106 * lisp.h (UNSIGNED_CMP): New macro.
107 This fixes comparison bugs on 64-bit hosts.
108 (ASCII_CHAR_P): Use it.
109 * casefiddle.c (casify_object):
110 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
111 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
112 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
113 * dispextern.h (FACE_FROM_ID):
114 * keyboard.c (read_char): Use UNSIGNED_CMP.
115
116 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
117 not to EMACS_INT, to avoid GCC warning.
118
119 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
120
121 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
122 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
123 isn't needed on 32-bit machines.
124
125 * buffer.c (Fgenerate_new_buffer_name):
126 Use EMACS_INT for count, not int.
127 (advance_to_char_boundary): Return EMACS_INT, not int.
128
129 * data.c (Qcompiled_function): Now static.
130
131 * window.c (window_body_lines): Now static.
132
133 * image.c (gif_load): Rename local to avoid shadowing.
134
135 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
136 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
137 * alloc.c (make_save_value): Integer argument is now of type
138 ptrdiff_t, not int.
139 (mark_object): Use ptrdiff_t, not int.
140 * lisp.h (pD): New macro.
141 * print.c (print_object): Use it.
142
143 * alloc.c: Use EMACS_INT, not int, to count objects.
144 (total_conses, total_markers, total_symbols, total_vector_size)
145 (total_free_conses, total_free_markers, total_free_symbols)
146 (total_free_floats, total_floats, total_free_intervals)
147 (total_intervals, total_strings, total_free_strings):
148 Now EMACS_INT, not int. All uses changed.
149 (Fgarbage_collect): Compute overall total using a double, so that
150 integer overflow is less likely to be a problem. Check for overflow
151 when converting back to an integer.
152 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
153 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
154 These were 'int' variables that could overflow on 64-bit hosts;
155 they were never used, so remove them instead of repairing them.
156 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
157 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
158 Previously, this ceilinged at INT_MAX, but that doesn't work on
159 64-bit machines.
160 (allocate_pseudovector): Don't use EMACS_INT when int would do.
161
162 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
163 (allocate_vectorlike): Check for ptrdiff_t overflow.
164 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
165 when a (possibly-narrower) signed value would do just as well.
166 We prefer using signed arithmetic, to avoid comparison confusion.
167
168 * alloc.c: Catch some string size overflows that we were missing.
169 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
170 for convenience in STRING_BYTES_MAX.
171 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
172 The definition here is exact; the one in lisp.h was approximate.
173 (allocate_string_data): Check for string overflow. This catches
174 some instances we weren't catching before. Also, it catches
175 size_t overflow on (unusual) hosts where SIZE_MAX <= min
176 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
177 and ptrdiff_t and EMACS_INT are both 64 bits.
178
179 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
180 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
181 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
182
183 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
184
185 * alloc.c (Fmake_string): Check for out-of-range init.
186
187 2011-06-12 Martin Rudalics <rudalics@gmx.at>
188
189 * frame.c (make_frame): Call other_buffer_safely instead of
190 other_buffer.
191
192 * window.c (temp_output_buffer_show): Call display_buffer with
193 second argument Vtemp_buffer_show_specifiers and reset latter
194 immediately after the call.
195 (Vtemp_buffer_show_specifiers): New variable.
196 (auto_window_vscroll_p, next_screen_context_lines)
197 (Vscroll_preserve_screen_position): Remove leading asterisks from
198 doc-strings.
199
200 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
201
202 Fix minor problems found by GCC 4.6.0 static checking.
203 * buffer.c (Qclone_number): Remove for now, as it's unused.
204 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
205 (record_buffer): Remove unused local.
206 * frame.c (other_visible_frames, frame_buffer_list): Now static.
207 (set_frame_buffer_list): Remove; unused.
208 * frame.h (other_visible_frames): Remove decl.
209 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
210 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
211 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
212 if HAVE_GPM.
213 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
214 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
215 Define only if HAVE_GPM.
216 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
217 (update_hints_inhibit): Remove; never set. All uses removed.
218 * widgetprv.h (emacsFrameClassRec): Remove decl.
219 * window.c (delete_deletable_window): Now returns void, since it
220 wasn't returning anything.
221 (compare_window_configurations): Remove unused locals.
222 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
223 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
224 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
225 the same widths as pointers. This follows up on the 2011-05-06 patch.
226 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
227 * xterm.h: Likewise.
228 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
229
230 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
231
232 * makefile.w32-in: Update dependencies.
233 (LISP_H): Add lib/intprops.h.
234
235 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
236
237 * image.c (gif_load): Add animation frame delay to the metadata.
238 (syms_of_image): Use DEFSYM. New symbol `delay'.
239
240 2011-06-11 Martin Rudalics <rudalics@gmx.at>
241
242 * window.c (delete_deletable_window): Re-add.
243 (Fset_window_configuration): Rewrite to handle dead buffers and
244 consequently deletable windows.
245 (window_tree, Fwindow_tree): Remove. Supply functionality in
246 window.el.
247 (compare_window_configurations): Simplify code.
248
249 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
250
251 * image.c (imagemagick_load_image): Fix type mismatch.
252 (Fimagemagick_types): Likewise.
253
254 * window.h (replace_buffer_in_windows): Declare.
255
256 2011-06-11 Martin Rudalics <rudalics@gmx.at>
257
258 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
259 Qclone_number. Remove external declaration of Qdelete_window.
260 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
261 code.
262 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
263 Qbuffer_list_update_hook if allowed.
264 (Fother_buffer): Rewrite doc-string. Major rewrite for new
265 buffer list implementation.
266 (other_buffer_safely): New function.
267 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
268 calls to replace_buffer_in_windows and
269 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
270 if allowed.
271 (record_buffer): Inhibit quitting and rewrite using quittable
272 functions. Run Qbuffer_list_update_hook if allowed.
273 (Frecord_buffer, Funrecord_buffer): New functions.
274 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
275 switch-to-buffer to window.el.
276 (bury-buffer): Move to window.el.
277 (Vbuffer_list_update_hook): New variable.
278
279 * lisp.h (other_buffer_safely): Add prototype in buffer.c
280 section.
281
282 * window.h (resize_frame_windows): Move up in code.
283 (Fwindow_frame): Remove EXFUN.
284 (replace_buffer_in_all_windows): Remove prototype.
285 (replace_buffer_in_windows_safely): Add prototype.
286
287 * window.c: Declare Qdelete_window static again. Move down
288 declaration of select_count.
289 (Fnext_window, Fprevious_window): Rewrite doc-strings.
290 (Fother_window): Move to window.el.
291 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
292 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
293 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
294 window.el.
295 (replace_buffer_in_windows): Implement by calling
296 Qreplace_buffer_in_windows.
297 (replace_buffer_in_all_windows): Remove with some functionality
298 moved into replace_buffer_in_windows_safely.
299 (replace_buffer_in_windows_safely): New function.
300 (select_window_norecord, select_frame_norecord): Move in front
301 of run_window_configuration_change_hook. Remove now obsolete
302 declarations.
303 (Fset_window_buffer): Rewrite doc-string. Call
304 Qrecord_window_buffer.
305 (keys_of_window): Move binding for other-window to window.el.
306
307 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
308
309 * dispextern.h (struct image): Replace data member, whose int_val
310 and ptr_val fields were not used by anything, with a single
311 lisp_val object.
312
313 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
314 (gif_clear_image, gif_load, imagemagick_load_image)
315 (gs_clear_image, gs_load): Callers changed.
316
317 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
318
319 * buffer.h: Include <time.h>, for time_t.
320 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
321
322 Fix minor problems found by static checking.
323
324 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
325
326 Make identifiers static if they are not used in other modules.
327 * data.c (Qcompiled_function, Qframe, Qvector):
328 * image.c (QimageMagick, Qsvg):
329 * minibuf.c (Qmetadata):
330 * window.c (resize_window_check, resize_root_window): Now static.
331 * window.h (resize_window_check, resize_root_window): Remove decls.
332
333 * window.c (window_deletion_count, delete_deletable_window):
334 Remove; unused.
335 (window_body_lines): Now static.
336 (Fdelete_other_windows_internal): Mark vars as initialized.
337 Make sure 'resize_failed' is initialized.
338 (run_window_configuration_change_hook): Rename local to avoid shadowing.
339 (resize_window_apply): Remove unused local.
340 * window.h (delete_deletable_window): Remove decl.
341
342 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
343 (imagemagick_load_image): Fix pointer signedness problem by changing
344 last arg from unsigned char * to char *. All uses changed.
345 Also, fix a local for similar reasons.
346 Remove unused locals. Remove locals to avoid shadowing.
347 (fn_rsvg_handle_free): Remove; unused.
348 (svg_load, svg_load_image): Fix pointer signedness problem.
349 (imagemagick_load_image): Don't use garbage pointer image_wand.
350
351 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
352
353 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
354
355 * image.c (gif_load): Fix omitted cast error introduced by
356 2011-06-06 change.
357
358 2011-06-10 Martin Rudalics <rudalics@gmx.at>
359
360 * window.h (resize_proportionally, orig_total_lines)
361 (orig_top_line): Remove from window structure.
362 (set_window_height, set_window_width, change_window_heights)
363 (Fdelete_window): Remove prototypes.
364 (resize_frame_windows): Remove duplicate declaration.
365
366 2011-06-10 Eli Zaretskii <eliz@gnu.org>
367
368 * window.h (resize_frame_windows, resize_window_check)
369 (delete_deletable_window, resize_root_window)
370 (resize_frame_windows): Declare prototypes.
371
372 * window.c (resize_window_apply): Make definition be "static" to
373 match the prototype.
374
375 2011-06-10 Martin Rudalics <rudalics@gmx.at>
376
377 * window.c: Remove declarations of Qwindow_size_fixed,
378 window_min_size_1, window_min_size_2, window_min_size,
379 size_window, window_fixed_size_p, enlarge_window, delete_window.
380 Remove static from declaration of Qdelete_window, it's
381 temporarily needed by Fbury_buffer.
382 (replace_window): Don't assign orig_top_line and
383 orig_total_lines.
384 (Fdelete_window, delete_window): Remove. Window deletion is
385 handled by window.el.
386 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
387 Fdelete_window calls with calls to Qdelete_window.
388 (Fdelete_other_windows): Remove. Deleting other windows is
389 handled by window.el.
390 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
391 handled in window.el.
392 (window_min_size_2, window_min_size_1, window_min_size): Remove.
393 Window minimum sizes are handled in window.el.
394 (shrink_windows, size_window, set_window_height)
395 (set_window_width, change_window_heights, window_height)
396 (window_width, CURBEG, CURSIZE, enlarge_window)
397 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
398 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
399 handled in window.el.
400 (make_dummy_parent): Rename to make_parent_window and give it a
401 second argument horflag.
402 (make_window): Don't set resize_proportionally any more.
403 (Fsplit_window): Remove. Windows are split in window.el.
404 (save_restore_action, save_restore_orig_size)
405 (shrink_window_lowest_first, save_restore_orig_size): Remove.
406 Resize mini windows in window.el.
407 (grow_mini_window, shrink_mini_window): Implement by calling
408 Qresize_root_window_vertically, resize_window_check and
409 resize_window_apply.
410 (saved_window, Fset_window_configuration, save_window_save): Do
411 not handle orig_top_line, orig_total_lines, and
412 resize_proportionally.
413 (window_min_height, window_min_width): Move to window.el.
414 (keys_of_window): Move bindings for delete-other-windows,
415 split-window, delete-window and enlarge-window to window.el.
416
417 * buffer.c: Temporarily extern Qdelete_window.
418 (Fbury_buffer): Temporarily call Qdelete_window instead of
419 Fdelete_window (Fbury_buffer will move to window.el soon).
420
421 * frame.c (set_menu_bar_lines_1): Remove code handling
422 orig_top_line and orig_total_lines.
423
424 * dispnew.c (adjust_frame_glyphs_initially): Don't use
425 set_window_height but set heights directly.
426 (change_frame_size_1): Use resize_frame_windows.
427
428 * xdisp.c (init_xdisp): Don't use set_window_height but set
429 heights directly.
430
431 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
432 resize_frame_windows instead of change_window_heights and run
433 run_window_configuration_change_hook.
434
435 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
436 instead of change_window_heights and run
437 run_window_configuration_change_hook.
438
439 2011-06-09 Martin Rudalics <rudalics@gmx.at>
440
441 * window.c (replace_window): Rename second argument REPLACEMENT to
442 NEW. New third argument SETFLAG. Rewrite.
443 (delete_window, make_dummy_parent): Call replace_window with
444 third argument 1.
445 (window_list_1): Move down in code.
446 (run_window_configuration_change_hook): Move set_buffer part
447 before select_frame_norecord part in order to unwind correctly.
448 Rename count1 to count.
449 (recombine_windows, delete_deletable_window, resize_root_window)
450 (Fdelete_other_windows_internal)
451 (Frun_window_configuration_change_hook, make_parent_window)
452 (resize_window_check, resize_window_apply, Fresize_window_apply)
453 (resize_frame_windows, Fsplit_window_internal)
454 (Fdelete_window_internal, Fresize_mini_window_internal): New
455 functions.
456 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
457
458 2011-06-08 Martin Rudalics <rudalics@gmx.at>
459
460 * window.h (window): Add some new members to window structure -
461 normal_lines, normal_cols, new_total, new_normal, clone_number,
462 splits, nest, prev_buffers, next_buffers.
463 (WINDOW_TOTAL_SIZE): Move here from window.c.
464 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
465
466 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
467 Remove.
468 (make_dummy_parent): Set new members of windows structure.
469 (make_window): Move down in code. Handle new members of window
470 structure.
471 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
472 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
473 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
474 (Fset_window_prev_buffers, Fwindow_next_buffers)
475 (Fset_window_next_buffers, Fset_window_clone_number): New
476 functions.
477 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
478 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
479 Doc-string fixes.
480 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
481 Argument WINDOW can be now internal window too.
482 (Fwindow_use_time): Move up in code.
483 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
484 Rewrite doc-string.
485 (Fset_window_configuration, saved_window)
486 (Fcurrent_window_configuration, save_window_save): Handle new
487 members of window structure.
488 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
489 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
490 (syms_of_window): New Lisp objects Qrecord_window_buffer,
491 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
492 Qget_mru_window, Qresize_root_window,
493 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
494 Qauto_buffer_name; staticpro them.
495
496 2011-06-07 Martin Rudalics <rudalics@gmx.at>
497
498 * window.c (Fwindow_total_size, Fwindow_left_column)
499 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
500 (Fwindow_list_1): New functions.
501 (window_box_text_cols): Replace with window_body_cols.
502 (Fwindow_width, Fscroll_left, Fscroll_right): Use
503 window_body_cols instead of window_box_text_cols.
504 (delete_window, Fset_window_configuration): Call
505 delete_all_subwindows with window as argument.
506 (delete_all_subwindows): Take a window as argument and not a
507 structure. Rewrite.
508 (window_loop): Remove handling of GET_LRU_WINDOW and
509 GET_LARGEST_WINDOW.
510 (Fget_lru_window, Fget_largest_window): Move to window.el.
511
512 * window.h: Extern window_body_cols instead of
513 window_box_text_cols. delete_all_subwindows now takes a
514 Lisp_Object as argument.
515
516 * indent.c (compute_motion, Fcompute_motion): Use
517 window_body_cols instead of window_box_text_cols.
518
519 * frame.c (delete_frame): Call delete_all_subwindows with root
520 window as argument.
521
522 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
523
524 * fns.c (Fputhash): Document return value.
525
526 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
527
528 * image.c (gif_load): Implement gif89a spec "no disposal" method.
529
530 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
531
532 Cons<->int and similar integer overflow fixes (Bug#8794).
533
534 Check for overflow when converting integer to cons and back.
535 * charset.c (Fdefine_charset_internal, Fdecode_char):
536 Use cons_to_unsigned to catch overflow.
537 (Fencode_char): Use INTEGER_TO_CONS.
538 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
539 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
540 * data.c (long_to_cons, cons_to_long): Remove.
541 (cons_to_unsigned, cons_to_signed): New functions.
542 These signal an error for invalid or out-of-range values.
543 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
544 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
545 * font.c (Ffont_variation_glyphs):
546 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
547 * lisp.h: Include <intprops.h>.
548 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
549 (cons_to_signed, cons_to_unsigned): New decls.
550 (long_to_cons, cons_to_long): Remove decls.
551 * undo.c (record_first_change): Use INTEGER_TO_CONS.
552 (Fprimitive_undo): Use CONS_TO_INTEGER.
553 * xfns.c (Fx_window_property): Likewise.
554 * xselect.c: Include <limits.h>.
555 (x_own_selection, selection_data_to_lisp_data):
556 Use INTEGER_TO_CONS.
557 (x_handle_selection_request, x_handle_selection_clear)
558 (x_get_foreign_selection, Fx_disown_selection_internal)
559 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
560 (lisp_data_to_selection_data): Use cons_to_unsigned.
561 (x_fill_property_data): Use cons_to_signed.
562 Report values out of range.
563
564 Check for buffer and string overflow more precisely.
565 * buffer.h (BUF_BYTES_MAX): New macro.
566 * lisp.h (STRING_BYTES_MAX): New macro.
567 * alloc.c (Fmake_string):
568 * character.c (string_escape_byte8):
569 * coding.c (coding_alloc_by_realloc):
570 * doprnt.c (doprnt):
571 * editfns.c (Fformat):
572 * eval.c (verror):
573 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
574 since they may not be the same number.
575 * editfns.c (Finsert_char):
576 * fileio.c (Finsert_file_contents):
577 Likewise for BUF_BYTES_MAX.
578
579 * image.c: Use ptrdiff_t, not int, for sizes.
580 (slurp_file): Switch from int to ptrdiff_t.
581 All uses changed.
582 (slurp_file): Check that file size fits in both size_t (for
583 malloc) and ptrdiff_t (for sanity and safety).
584
585 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
586 if b->modtime has its maximal value.
587
588 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
589
590 Don't assume time_t can fit into int.
591 * buffer.h (struct buffer.modtime): Now time_t, not int.
592 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
593 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
594
595 Minor fixes for signed vs unsigned integers.
596 * character.h (MAYBE_UNIFY_CHAR):
597 * charset.c (maybe_unify_char):
598 * keyboard.c (read_char, reorder_modifiers):
599 XINT -> XFASTINT, since the integer must be nonnegative.
600 * ftfont.c (ftfont_spec_pattern):
601 * keymap.c (access_keymap, silly_event_symbol_error):
602 XUINT -> XFASTINT, since the integer must be nonnegative.
603 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
604 since it makes no difference and we prefer signed.
605 * keyboard.c (record_char): Use XUINT when all the neighbors do.
606 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
607 nonnegative.
608
609 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
610
611 * window.h (Fwindow_frame): Declare.
612
613 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
614
615 * alloc.c: Simplify handling of large-request failures (Bug#8800).
616 (SPARE_MEMORY): Always define.
617 (LARGE_REQUEST): Remove.
618 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
619
620 2011-06-06 Martin Rudalics <rudalics@gmx.at>
621
622 * lisp.h: Move EXFUNS for Fframe_root_window,
623 Fframe_first_window and Fset_frame_selected_window to window.h.
624
625 * window.h: Move EXFUNS for Fframe_root_window,
626 Fframe_first_window and Fset_frame_selected_window here from
627 lisp.h.
628
629 * frame.c (Fwindow_frame, Fframe_first_window)
630 (Fframe_root_window, Fframe_selected_window)
631 (Fset_frame_selected_window): Move to window.c.
632 (Factive_minibuffer_window): Move to minibuf.c.
633 (Fother_visible_frames_p): New function.
634
635 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
636
637 * window.c (decode_window, decode_any_window): Move up in code.
638 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
639 (inhibit_frame_unsplittable): Remove unused variable.
640 (Fwindow_buffer): Move up and rewrite doc-string.
641 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
642 (Fwindow_prev): New functions.
643 (Fwindow_frame): Move here from frame.c. Accept any window as
644 argument.
645 (Fframe_root_window, Fframe_first_window)
646 (Fframe_selected_window): Move here from frame.c. Accept frame
647 or arbitrary window as argument. Update doc-strings.
648 (Fminibuffer_window): Move up in code.
649 (Fwindow_minibuffer_p): Move up in code and simplify.
650 (Fset_frame_selected_window): Move here from frame.c.
651 Marginal rewrite.
652 (Fselected_window, select_window, Fselect_window): Move up in
653 code. Minor doc-string fixes.
654
655 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
656
657 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
658 Do not assume that spare memory exists; that assumption is valid
659 only if SYSTEM_MALLOC.
660 (LARGE_REQUEST): New macro, so that the issue of large requests
661 is separated from the issue of spare memory.
662
663 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
664
665 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
666 format. (Bug#8806)
667
668 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
669
670 * xfns.c (x_set_scroll_bar_default_width): Move declarations
671 before statements.
672
673 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
674
675 * gtkutil.c (xg_get_default_scrollbar_width): New function.
676
677 * gtkutil.h: Declare xg_get_default_scrollbar_width.
678
679 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
680 min width by calling x_set_scroll_bar_default_width (Bug#8505).
681
682 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
683
684 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
685
686 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
687
688 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
689 (x_clipboard_manager_save): Add return value.
690 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
691 New error handlers.
692 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
693 Obey Vx_select_enable_clipboard_manager. Catch errors in
694 x_clipboard_manager_save (Bug#8779).
695 (Vx_select_enable_clipboard_manager): New variable.
696 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
697
698 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
699
700 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
701
702 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
703
704 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
705 in the current matrix if keep_current_p is non-zero.
706
707 2011-06-04 Eli Zaretskii <eliz@gnu.org>
708
709 * bidi.c (bidi_level_of_next_char): Fix last change.
710
711 2011-06-03 Eli Zaretskii <eliz@gnu.org>
712
713 Support bidi reordering of text covered by display properties.
714
715 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
716 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
717 (bidi_cache_search, bidi_cache_iterator_state)
718 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
719 (bidi_level_of_next_char, bidi_move_to_visually_next):
720 Support character positions inside a run of characters covered by a
721 display string.
722 (bidi_paragraph_init, bidi_resolve_explicit_1)
723 (bidi_level_of_next_char): Call bidi_fetch_char and
724 bidi_fetch_char_advance instead of FETCH_CHAR and
725 FETCH_CHAR_ADVANCE.
726 (bidi_init_it): Initialize new members.
727 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
728 definitions.
729 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
730 instead of using explicit *_CHAR codes.
731 (bidi_resolve_explicit, bidi_resolve_weak):
732 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
733 bidirectional text is supported only in multibyte buffers.
734 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
735 it to initialize the frame_window_p member of struct bidi_it.
736 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
737 (bidi_resolve_explicit, bidi_resolve_weak)
738 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
739 bidi_it->nchars is non-positive.
740 (bidi_level_of_next_char): Don't try to lookup the cache for the
741 next/previous character if nothing is cached there yet, or if we
742 were just reseat()'ed to a new position.
743
744 * xdisp.c (set_cursor_from_row): Set start and stop points
745 according to the row's direction when priming the loop that looks
746 for the glyph on which to display cursor.
747 (single_display_spec_intangible_p): Function deleted.
748 (display_prop_intangible_p): Reimplement to call
749 handle_display_spec instead of single_display_spec_intangible_p.
750 Accept 3 additional arguments needed by handle_display_spec.
751 This fixes incorrect cursor motion across display property with complex
752 values: lists, `(when COND...)' forms, etc.
753 (single_display_spec_string_p): Support property values that are
754 lists with the argument STRING its top-level element.
755 (display_prop_string_p): Fix the condition for processing a
756 property that is a list to be consistent with handle_display_spec.
757 (handle_display_spec): New function, refactored from the
758 last portion of handle_display_prop.
759 (compute_display_string_pos): Accept additional argument
760 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
761 value of a `display' property is a "replacing spec".
762 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
763 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
764 the display property, but just return a value indicating whether
765 the display property will replace the characters it covers.
766 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
767 frame_window_p members of struct bidi_it.
768 (compute_display_string_pos, compute_display_string_end):
769 New functions.
770 (push_it): Accept second argument POSITION, where pop_it should
771 jump to continue iteration.
772 (reseat_1): Initialize bidi_it.disp_pos.
773
774 * keyboard.c (adjust_point_for_property): Adjust the call to
775 display_prop_intangible_p to its new signature.
776
777 * dispextern.h (struct bidi_it): New member frame_window_p.
778 (bidi_init_it): Update prototypes.
779 (display_prop_intangible_p): Update prototype.
780 (compute_display_string_pos, compute_display_string_end):
781 Declare prototypes.
782 (struct bidi_it): New members nchars and disp_pos. ch_len is now
783 EMACS_INT.
784
785 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
786
787 Malloc failure behavior now depends on size of allocation.
788 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
789 * lisp.h: Change signatures accordingly.
790 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
791 All callers changed. (Bug#8762)
792
793 * gnutls.c: Use Emacs's memory allocators.
794 Without this change, the gnutls library would invoke malloc etc.
795 directly, which causes problems on non-SYNC_INPUT hosts, and which
796 runs afoul of improving memory_full behavior. (Bug#8761)
797 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
798 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
799 xfree instead of the default malloc, realloc, free.
800 (Fgnutls_boot): No need to check for memory allocation failure,
801 since xmalloc does that for us.
802
803 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
804 * category.c (hash_get_category_set):
805 * ccl.c (ccl_driver):
806 * charset.c (Fdefine_charset_internal):
807 * charset.h (struct charset.hash_index):
808 * composite.c (get_composition_id, gstring_lookup_cache)
809 (composition_gstring_put_cache):
810 * composite.h (struct composition.hash_index):
811 * dispextern.h (struct image.hash):
812 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
813 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
814 (hashfn_equal, hashfn_user_defined, make_hash_table)
815 (maybe_resize_hash_table, hash_lookup, hash_put)
816 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
817 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
818 (Fsxhash, Fgethash, Fputhash, Fmaphash):
819 * image.c (make_image, search_image_cache, lookup_image)
820 (xpm_put_color_table_h):
821 * lisp.h (struct Lisp_Hash_Table):
822 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
823 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
824 for hashes and hash indexes, instead of 'unsigned' and 'int'.
825 * alloc.c (allocate_vectorlike):
826 Check for overflow in vector size calculations.
827 * ccl.c (ccl_driver):
828 Check for overflow when converting EMACS_INT to int.
829 * fns.c, image.c: Remove unnecessary static decls that would otherwise
830 need to be updated by these changes.
831 * fns.c (make_hash_table, maybe_resize_hash_table):
832 Check for integer overflow with large hash tables.
833 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
834 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
835 (SXHASH_REDUCE): New macro.
836 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
837 Use it instead of discarding useful hash info with large hash values.
838 (sxhash_float): New function.
839 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
840 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
841 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
842 Rewrite to use FIXNUM_BITS, as this simplifies things.
843 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
844 Adjust signatures to match updated version of code.
845 (consing_since_gc): Now EMACS_INT, since a single hash table can
846 use more than INT_MAX bytes.
847
848 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
849
850 Make it possible to build with GCC-4.6+ -O2 -flto.
851
852 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
853
854 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
855
856 * minibuf.c (get_minibuffer, read_minibuf_unwind):
857 Call minibuffer-inactive-mode.
858
859 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
860
861 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
862 Update dependencies.
863
864 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
865
866 * data.c (init_data): Remove code for UTS, this system is not
867 supported anymore.
868
869 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
870
871 Don't force ./temacs to start in terminal mode.
872
873 * frame.c (make_initial_frame): Initialize faces in all cases, not
874 only when CANNOT_DUMP is defined.
875 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
876
877 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
878
879 * dispnew.c (add_window_display_history): Use const for the string
880 pointer. Remove declaration, not needed.
881
882 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
883
884 Use 'inline', not 'INLINE'.
885 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
886 * alloc.c, fontset.c (INLINE): Remove.
887 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
888 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
889 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
890 * gmalloc.c (register_heapinfo): Use inline unconditionally.
891 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
892
893 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
894
895 Make it possible to run ./temacs.
896
897 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
898 syms_of_callproc does the same thing. Remove test for
899 "initialized", do it in the caller.
900 * emacs.c (main): Avoid calling set_initial_environment when dumping.
901
902 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
903
904 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
905 (read_minibuf): Use get_minibuffer.
906 (syms_of_minibuf): Use DEFSYM.
907 (Qmetadata): New var.
908 * data.c (Qbuffer): Don't make it static.
909 (syms_of_data): Use DEFSYM.
910
911 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
912
913 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
914 (CCL_CODE_MIN): New macro.
915
916 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
917
918 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
919
920 * eval.c (Qdebug): Now static.
921 * lisp.h (Qdebug): Remove decl. This reverts a part of the
922 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
923 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
924
925 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
926
927 * image.c: Various fixes to ImageMagick code comments.
928 (Fimagemagick_types): Doc fix.
929
930 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
931
932 Minor fixes prompted by GCC 4.6.0 warnings.
933
934 * xselect.c (converted_selections, conversion_fail_tag): Now static.
935
936 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
937 (x_clipboard_manager_save_all): Move extern decl to ...
938 * xterm.h: ... here, so that it can be checked for consistency.
939
940 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
941
942 * xselect.c (x_clipboard_manager_save_frame)
943 (x_clipboard_manager_save_all): New functions.
944 (Fx_clipboard_manager_save): Lisp function deleted.
945
946 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
947 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
948
949 * xterm.h: Update prototype.
950
951 2011-05-28 William Xu <william.xwl@gmail.com>
952
953 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
954 exiting (Bug#8239).
955
956 2011-05-28 Jim Meyering <meyering@redhat.com>
957
958 Avoid a sign-extension bug in crypto_hash_function.
959 * fns.c (to_uchar): Define.
960 (crypto_hash_function): Use it to convert some newly-signed
961 variables to unsigned, to avoid sign-extension bugs. For example,
962 without this change, (md5 "truc") would evaluate to
963 45723a2aff78ff4fff7fff1114760e62 rather than the expected
964 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
965 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
966
967 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
968
969 Integer overflow fixes.
970
971 * dbusbind.c: Serial number integer overflow fixes.
972 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
973 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
974 to hold a serial number that is too large for a fixnum.
975 (Fdbus_method_return_internal, Fdbus_method_error_internal):
976 Check for serial numbers out of range. Decode any serial number
977 that was so large that it became a float. (Bug#8722)
978
979 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
980 (Fdbus_call_method, Fdbus_call_method_asynchronously):
981 Use XFASTINT rather than XUINT when numbers are nonnegative.
982 (xd_append_arg, Fdbus_method_return_internal):
983 (Fdbus_method_error_internal): Likewise. Also, for unsigned
984 arguments, check that Lisp number is nonnegative, rather than
985 silently wrapping negative numbers around. (Bug#8722)
986 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
987 (Bug#8722)
988
989 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
990
991 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
992
993 ccl: add integer overflow checks
994 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
995 (IN_INT_RANGE): New macros.
996 (ccl_driver): Use them to check for integer overflow when
997 decoding a CCL program. Many of the new checks are whether XINT (x)
998 fits in int; it doesn't always, on 64-bit hosts. The new version
999 doesn't catch all possible integer overflows, but it's an
1000 improvement. (Bug#8719)
1001
1002 * alloc.c (make_event_array): Use XINT, not XUINT.
1003 There's no need for unsigned here.
1004
1005 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1006 This follows up to the 2011-05-06 change that substituted uintptr_t
1007 for EMACS_INT. This case wasn't caught back then.
1008
1009 Rework Fformat to avoid integer overflow issues.
1010 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1011 now (part of C89). Include <verify.h>.
1012 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1013 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1014 (Fformat): Avoid the prepass trying to compute sizes; it was only
1015 approximate and thus did not catch overflow reliably. Instead, walk
1016 through the format just once, formatting and computing sizes as we go,
1017 checking for integer overflow at every step, and allocating a larger
1018 buffer as needed. Keep track separately whether the format is
1019 multibyte. Keep only the most-recently calculated precision, rather
1020 than them all. Record whether each argument has been converted to
1021 string. Use EMACS_INT, not int, for byte and char and arg counts.
1022 Support field widths and precisions larger than INT_MAX. Avoid
1023 sprintf's undefined behavior with conversion specifications such as %#d
1024 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1025 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1026 formatting out-of-range floating point numbers with int
1027 formats. (Bug#8668)
1028
1029 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1030
1031 * data.c: Avoid integer truncation in expressions involving floats.
1032 * data.c: Include <intprops.h>.
1033 (arith_driver): When there's an integer overflow in an expression
1034 involving floating point, convert the integers to floating point
1035 so that the resulting value does not suffer from catastrophic
1036 integer truncation. For example, on a 64-bit host (* 4
1037 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1038 Do not rely on undefined behavior after integer overflow.
1039
1040 merge count_size_as_multibyte, parse_str_to_multibyte
1041 * character.c, character.h (count_size_as_multibyte):
1042 Rename from parse_str_to_multibyte; all uses changed.
1043 Check for integer overflow.
1044 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1045 since it's now a duplicate of the other. This is more of
1046 a character than a buffer op, so better that it's in character.c.
1047 * fns.c, print.c: Adjust to above changes.
1048
1049 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1050
1051 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1052
1053 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1056 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1057 (x_clipboard_manager_save): Now static.
1058 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1059
1060 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1061 (crypto_hash_function): Now static.
1062 Fix pointer signedness problems. Avoid unnecessary initializations.
1063
1064 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1065
1066 * termhooks.h (Vselection_alist): Make it terminal-local.
1067
1068 * terminal.c (create_terminal): Initialize it.
1069
1070 * xselect.c: Support for clipboard managers.
1071 (Vselection_alist): Move to termhooks.h as terminal-local var.
1072 (LOCAL_SELECTION): New macro.
1073 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1074 (symbol_to_x_atom): Remove gratuitous arg.
1075 (x_handle_selection_request, lisp_data_to_selection_data)
1076 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1077 (x_own_selection, x_get_local_selection, x_convert_selection):
1078 New arg, specifying work frame. Use terminal-local Vselection_alist.
1079 (some_frame_on_display): Delete unused function.
1080 (Fx_own_selection_internal, Fx_get_selection_internal)
1081 (Fx_disown_selection_internal, Fx_selection_owner_p)
1082 (Fx_selection_exists_p): New optional frame arg.
1083 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1084 (x_handle_selection_clear): Don't treat other terminals with the
1085 same keyboard specially. Use the terminal-local Vselection_alist.
1086 (x_clear_frame_selections): Use Frun_hook_with_args.
1087
1088 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1089
1090 * xterm.h: Add support for those atoms.
1091
1092 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1093
1094 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1095 (converted_selections, conversion_fail_tag): New global variables.
1096 (x_selection_request_lisp_error): Free the above.
1097 (x_get_local_selection): Remove unnecessary code.
1098 (x_reply_selection_request): Args changed; handle arbitrary array
1099 of converted selections stored in converted_selections.
1100 Separate the XChangeProperty and SelectionNotify steps.
1101 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1102 (x_convert_selection): New function.
1103 (x_handle_selection_event): Simplify.
1104 (x_get_foreign_selection): Don't ignore incoming requests while
1105 waiting for an answer; this will fail when we implement
1106 SAVE_TARGETS, and seems unnecessary anyway.
1107 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1108 (Vx_sent_selection_functions): Doc fix.
1109
1110 2011-05-26 Leo Liu <sdl.web@gmail.com>
1111
1112 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1113
1114 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1115
1116 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1117
1118 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1119 for fringe update if it has periodic bitmap.
1120 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1121 and fringe_bitmap_periodic_p.
1122
1123 * fringe.c (get_fringe_bitmap_data): New function.
1124 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1125 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1126 row. Mark glyph row for fringe update if periodicity changed.
1127
1128 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1129 for fringe update unless it has periodic bitmap.
1130
1131 2011-05-25 Kenichi Handa <handa@m17n.org>
1132
1133 * xdisp.c (get_next_display_element): Set correct it->face_id for
1134 a static composition.
1135
1136 2011-05-24 Leo Liu <sdl.web@gmail.com>
1137
1138 * deps.mk (fns.o):
1139 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1140
1141 * fns.c (crypto_hash_function, Fsha1): New function.
1142 (Fmd5): Use crypto_hash_function.
1143 (syms_of_fns): Add Ssha1.
1144
1145 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1146
1147 * gnutls.c: Remove unused macros.
1148 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1149 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1150 Remove macros that are defined and never used.
1151 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1152
1153 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1154
1155 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1156 (Fx_get_selection_internal): Minor cleanup.
1157 (Fx_own_selection_internal): Rename arguments for consistency with
1158 select.el.
1159
1160 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1161
1162 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1163
1164 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1165
1166 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1167
1168 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1169
1170 * dispnew.c (scrolling_window): Don't exclude the case that the
1171 last enabled row in the desired matrix touches the bottom boundary.
1172
1173 2011-05-21 Glenn Morris <rgm@gnu.org>
1174
1175 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1176 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1177 and add some more files.
1178
1179 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1180
1181 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1182 report_file_error introduced by the change from 2011-05-07.
1183
1184 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1185
1186 * systime.h (Time): Define only if emacs is defined.
1187 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1188 where the include path doesn't have X11/X.h by default. See
1189 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1190
1191 2011-05-20 Kenichi Handa <handa@m17n.org>
1192
1193 * composite.c (find_automatic_composition): Fix previous change.
1194
1195 2011-05-20 Glenn Morris <rgm@gnu.org>
1196
1197 * lisp.mk: New file, split from Makefile.in.
1198 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1199 (shortlisp): Remove.
1200 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1201
1202 2011-05-19 Glenn Morris <rgm@gnu.org>
1203
1204 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1205 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1206 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1207 (lisp): Set the order to that of loadup.el.
1208 (shortlisp): Make it a copy of $lisp.
1209 (SOME_MACHINE_LISP): Remove.
1210 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1211 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1212
1213 2011-05-18 Kenichi Handa <handa@m17n.org>
1214
1215 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1216 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1217 (find_automatic_composition): Mostly rewrite for efficiency.
1218
1219 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1220
1221 * makefile.w32-in: Update dependencies.
1222
1223 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1224
1225 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1226 revision 104625).
1227
1228 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 Fix some integer overflow issues, such as string length overflow.
1231
1232 * insdel.c (count_size_as_multibyte): Check for string overflow.
1233
1234 * character.c (lisp_string_width): Check for string overflow.
1235 Use EMACS_INT, not int, for string indexes and lengths; in
1236 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1237 the resulting string length overflows an EMACS_INT; instead,
1238 report a string overflow if no precision given. When checking for
1239 precision exhaustion, use a check that cannot possibly have
1240 integer overflow. (Bug#8675)
1241 * character.h (lisp_string_width): Adjust to new signature.
1242
1243 * alloc.c (string_overflow): New function.
1244 (Fmake_string): Use it. This doesn't change behavior, but saves
1245 a few bytes and will simplify future changes.
1246 * character.c (string_escape_byte8): Likewise.
1247 * lisp.h (string_overflow): New decl.
1248
1249 Fixups, following up to the user-interface timestamp change.
1250 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1251 for UI timestamps, instead of unsigned long.
1252 * msdos.c (mouse_get_pos): Likewise.
1253 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1254 * w32gui.h (Time): Define by including "systime.h" rather than by
1255 declaring it ourselves. (Bug#8664)
1256
1257 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1258 * image.c (clear_image_cache): Likewise.
1259
1260 * term.c (term_mouse_position): Don't assume time_t wraparound.
1261
1262 Be more systematic about user-interface timestamps.
1263 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1264 and sometimes 'EMACS_UINT', to represent these timestamps.
1265 This change causes it to use 'Time' uniformly, as that's what X uses.
1266 This makes the code easier to follow, and makes it easier to catch
1267 integer overflow bugs such as Bug#8664.
1268 * frame.c (Fmouse_position, Fmouse_pixel_position):
1269 Use Time, not unsigned long, for user-interface timestamps.
1270 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1271 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1272 * keyboard.h (last_event_timestamp): Likewise.
1273 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1274 * menu.h (xmenu_show): Likewise.
1275 * term.c (term_mouse_position): Likewise.
1276 * termhooks.h (struct input_event.timestamp): Likewise.
1277 (struct terminal.mouse_position_hook): Likewise.
1278 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1279 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1280 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1281 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1282 what it was before.
1283 * menu.h, termhooks.h: Include "systime.h", for Time.
1284
1285 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1286 Don't assume that the difference between two unsigned long values
1287 can fit into an integer. At this point, we know button_down_time
1288 <= event->timestamp, so the difference must be nonnegative, so
1289 there's no need to cast the result if double-click-time is
1290 nonnegative, as it should be; check that it's nonnegative, just in
1291 case. This bug is triggered when events are more than 2**31 ms
1292 apart (about 25 days). (Bug#8664)
1293
1294 * xselect.c (last_event_timestamp): Remove duplicate decl.
1295 (x_own_selection): Remove needless cast to unsigned long.
1296
1297 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1298 that always fit in int. Use a sentinel instead of a counter, to
1299 avoid a temp and to allay GCC's concerns about possible int overflow.
1300 * frame.h (struct frame): Use int for menu_bar_items_used
1301 instead of EMACS_INT, since it always fits in int.
1302
1303 * menu.c (grow_menu_items): Check for int overflow.
1304
1305 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1306
1307 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1308 Before, the code was not consistent. These values cannot exceed
1309 2**31 - 1 so there's no need to make them unsigned.
1310 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1311 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1312 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1313 as modifiers.
1314 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1315
1316 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1317 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1318 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1319 presumably because the widths might not match.
1320
1321 * window.c (size_window): Avoid needless test at loop start.
1322
1323 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1324
1325 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1326
1327 2011-05-12 Drew Adams <drew.adams@oracle.com>
1328
1329 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1330
1331 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1332
1333 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1334 `width' to `bar_area_x' and `bar_area_width', respectively.
1335 (x_scroll_run): Take account of fringe background extension.
1336
1337 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1338 Rename local vars `left' and `width' to `bar_area_x' and
1339 `bar_area_width', respectively.
1340 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1341 background extension.
1342
1343 2011-05-10 Jim Meyering <meyering@redhat.com>
1344
1345 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1346
1347 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1348
1349 * image.c (Finit_image_library): Return t for built-in image types,
1350 like pbm and xbm. (Bug#8640)
1351
1352 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1353
1354 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1355
1356 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1357
1358 * w32console.c (Fset_screen_color): Doc fix.
1359 (Fget_screen_color): New function.
1360 (syms_of_ntterm): Defsubr it.
1361
1362 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1363 unlink the temporary file if Fcall_process didn't create it in the
1364 first place.
1365 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1366 child process will be redirected to a file specified with `:file'.
1367 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1368 cue to call_process_cleanup not to close that handle.
1369
1370 2011-05-07 Ben Key <bkey76@gmail.com>
1371
1372 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1373 one of two shell specific rules, either bootstrap-temacs-CMD or
1374 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1375 to the previous implementation of the bootstrap-temacs rule.
1376 The bootstrap-temacs-CMD rule is similar to the previous
1377 implementation of the bootstrap-temacs rule except that it
1378 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1379 variable.
1380
1381 These changes, along with some changes to nt/configure.bat,
1382 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1383 earlier fix to add support for --cflags and --ldflags options
1384 that include quotes so that it works whether make uses cmd or
1385 sh as the shell.
1386
1387 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1388
1389 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1390 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1391 is a constant.
1392 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1393 a string. Handle both cases.
1394 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1395 (Fdbus_register_method): Use Qinvalid_function.
1396
1397 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1398
1399 * makefile.w32-in: Update dependencies.
1400 (LISP_H): Add inttypes.h and stdin.h.
1401 (PROCESS_H): Add unistd.h.
1402
1403 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1404
1405 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1406 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1407
1408 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1411
1412 * term.c (vfatal): Remove stray call to va_end.
1413 It's not needed and the C Standard doesn't allow it here anyway.
1414
1415 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1416 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1417
1418 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1419 bytes.
1420
1421 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1422
1423 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1424
1425 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1426
1427 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1428
1429 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1430
1431 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1432 * charset.c (Fdefine_charset_internal): Don't initialize
1433 charset.code_space[15]. The value was garbage, on hosts with
1434 32-bit int (Bug#8600).
1435
1436 * lread.c (read_integer): Be more consistent with string-to-number.
1437 Use string_to_number to do the actual conversion; this avoids
1438 rounding errors and fixes some other screwups. Without this fix,
1439 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1440 (digit_to_number): Move earlier, for benefit of read_integer.
1441 Return -1 if the digit is out of range for the base, -2 if it is
1442 not a digit in any supported base. (Bug#8602)
1443
1444 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1445
1446 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1447 to match comment at start of function. This also removes a
1448 GCC warning about overflow in a 32+64-bit port.
1449
1450 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1451
1452 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1453 Reported by Stefan Monnier in
1454 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1455 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1456 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1457
1458 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1459 (EMACS_UINTPTR): Likewise, with uintptr_t.
1460
1461 * lisp.h: Prefer 64-bit EMACS_INT if available.
1462 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1463 on 32-bit hosts that have 64-bit int, so that they can access
1464 large files.
1465 However, temporarily disable this change unless the temporary
1466 symbol WIDE_EMACS_INT is defined.
1467
1468 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1469
1470 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1471 This removes an assumption that EMACS_INT and long are the same
1472 width as pointers. The assumption is true for Emacs porting targets
1473 now, but we want to make other targets possible.
1474 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1475 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1476 In the rest of the code, change types of integers that hold casted
1477 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1478 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1479 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1480 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1481 No need to cast type when ORing.
1482 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1483 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1484 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1485 assume EMACS_INT is the same width as char *.
1486 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1487 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1488 Remove no-longer-needed casts.
1489 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1490 (xg_tool_bar_help_callback, xg_make_tool_item):
1491 Use EMACS_INTPTR to hold an integer
1492 that will be cast to void *; this can avoid a GCC warning
1493 if EMACS_INT is not the same width as void *.
1494 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1495 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1496 (current_message_1, set_message_1):
1497 Use a local to convert to proper width without a cast.
1498 * xmenu.c (dialog_selection_callback): Likewise.
1499
1500 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1501 Also, don't assume VALBITS / RAND_BITS is less than 5,
1502 and don't rely on undefined behavior when shifting a 1 left into
1503 the sign bit.
1504 * lisp.h (get_random): Change signature to match.
1505
1506 * lread.c (hash_string): Use size_t, not int, for hash computation.
1507 Normally we prefer signed values; but hashing is special, because
1508 it's better to use unsigned division on hash table sizes so that
1509 the remainder is nonnegative. Also, size_t is the natural width
1510 for hashing into memory. The previous code used 'int', which doesn't
1511 retain enough info to hash well into very large tables.
1512 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1513
1514 * dbusbind.c: Don't possibly lose pointer info when converting.
1515 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1516 Use XPNTR rather than XHASH, so that the high-order bits of
1517 the pointer aren't lost when converting through void *.
1518
1519 * eval.c (Fautoload): Don't double-shift a pointer.
1520
1521 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1522
1523 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1524
1525 * gnutls.c (DEF_GNUTLS_FN):
1526 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1527
1528 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1529
1530 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1531 marker. (Bug#8610)
1532
1533 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1534
1535 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1536 New version that can reserve upto 2GB of heap space.
1537
1538 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1539
1540 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1541
1542 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1543
1544 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1545 `gnutls_certificate_set_x509_key_file'.
1546
1547 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1548
1549 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1550 Update dependencies.
1551
1552 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1553
1554 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1555 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1556 Remove unused parameter `fildes'.
1557 * process.c (read_process_output, send_process): Don't pass it.
1558
1559 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1560
1561 Fix previous change: the library cache is defined in w32.c.
1562 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1563 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1564
1565 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1566
1567 Implement dynamic loading of GnuTLS on Windows.
1568
1569 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1570 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1571 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1572 Declare.
1573
1574 * gnutls.c (Qgnutls_dll): Define.
1575 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1576 (gnutls_*): Declare function pointers.
1577 (init_gnutls_functions): New function to initialize function pointers.
1578 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1579 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1580 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1581 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1582 (emacs_gnutls_write, emacs_gnutls_read)
1583 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1584 (Fgnutls_available_p): New function.
1585 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1586 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1587 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1588
1589 * image.c: Include w32.h.
1590 (Vimage_type_cache): Delete.
1591 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1592 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1593 (w32_delayed_load): Move to w32.c.
1594
1595 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1596
1597 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1598 (w32_delayed_load): Move from image.c. When loading a library, record
1599 its filename in the :loaded-from property of the library id.
1600 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1601 Initialize and staticpro them.
1602 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1603
1604 * process.c: Include lisp.h before w32.h, not after.
1605 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1606 instead of gnutls_record_check_pending.
1607
1608 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1609
1610 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1611
1612 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1613 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1614 as passed in.
1615
1616 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1617
1618 * xterm.c (x_set_frame_alpha): Do not set property on anything
1619 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1620
1621 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1622
1623 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1624
1625 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1626
1627 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1628 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1629 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1630 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1631 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1632 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1633 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1634 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1635 (Qgnutls_bootprop_callbacks_verify): Make static.
1636
1637 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1638
1639 * callproc.c: Indentation fixup.
1640
1641 * sysdep.c (wait_for_termination_1): Make static.
1642 (wait_for_termination, interruptible_wait_for_termination):
1643 Move after wait_for_termination_1.
1644
1645 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1646
1647 * sysdep.c (interruptible_wait_for_termination): New function
1648 which is like wait_for_termination, but allows keyboard
1649 interruptions.
1650
1651 * callproc.c (Fcall_process): Add (:file "file") as an option for
1652 the STDOUT buffer.
1653 (Fcall_process_region): Ditto.
1654
1655 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1656
1657 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1658 rather than `XVECTOR (FOO)->size'.
1659
1660 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1661 inttypes.h, as a gnulib replacement is used if it not available in
1662 system headers.
1663
1664 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1665
1666 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1667 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1668 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1669
1670 * coding.c (coding_alloc_by_realloc): Error out if destination
1671 will grow beyond MOST_POSITIVE_FIXNUM.
1672 (decode_coding_emacs_mule): Abort if there isn't enough place in
1673 charbuf for the composition carryover bytes. Reserve an extra
1674 space for up to 2 characters produced in a loop.
1675 (decode_coding_iso_2022): Abort if there isn't enough place in
1676 charbuf for the composition carryover bytes.
1677
1678 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1679
1680 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1681 aborting when %lld or %lll format is passed.
1682 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1683 %llo or %llx format is passed. (Bug#8545)
1684
1685 * window.c (window_scroll_line_based): Use a marker instead of
1686 simple variables to record original value of point. (Bug#7952)
1687
1688 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1689 produced by %s or %c overflows available buffer space. (Bug#8545)
1690
1691 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1692
1693 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1694 (SIZE_MAX): Move defn after all includes, as they might #define it.
1695
1696 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1697
1698 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1699
1700 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1701
1702 * keyboard.c (Qdelayed_warnings_hook): Define.
1703 (command_loop_1): Run `delayed-warnings-hook'
1704 if Vdelayed_warnings_list is non-nil.
1705 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1706 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1707
1708 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1709
1710 * doprnt.c (doprnt): Don't return value smaller than the buffer
1711 size if the message was truncated. (Bug#8545).
1712
1713 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1714
1715 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1716 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1717
1718 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1719
1720 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1721
1722 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1723
1724 * makefile.w32-in: Update dependencies.
1725
1726 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1727
1728 Improve `doprnt' and its usage. (Bug#8545)
1729 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1730 `format_end'. Remove support for %l as a conversion specifier.
1731 Don't use xrealloc. Improve diagnostics when the %l size modifier
1732 is used. Update the commentary.
1733
1734 * eval.c (verror): Simplify calculation of size_t.
1735
1736 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1737 messages.
1738
1739 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1740
1741 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1742 change.
1743
1744 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1747 This makes this file independent of the recent pseudovector change.
1748
1749 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1752
1753 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1754 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1755 Remove unused local.
1756 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1757
1758 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1759 GCC 4.6.0 optimizes based on type-based alias analysis.
1760 For example, if b is of type struct buffer * and v of type struct
1761 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1762 != &v->size, and therefore "v->size = 1; b->size = 2; return
1763 v->size;" must therefore return 1. This assumption is incorrect
1764 for Emacs, since it type-puns struct Lisp_Vector * with many other
1765 types. To fix this problem, this patch adds a new type struct
1766 vectorlike_header that documents the constraints on layout of vectors
1767 and pseudovectors, and helps optimizing compilers not get fooled
1768 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1769 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1770 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1771 the size member.
1772 (XSETPVECTYPE): Rewrite in terms of new macro.
1773 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1774 This is a bit clearer, and further avoids the possibility of
1775 undesirable aliasing.
1776 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1777 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1778 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1779 since Lisp_Subr is a special case (no "next" field).
1780 (ASIZE): Now uses header.size rather than size.
1781 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1782 to avoid the hassle of writing XVECTOR (foo)->header.size.
1783 (struct vectorlike_header): New type.
1784 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1785 object, to help avoid aliasing.
1786 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1787 (SUBRP): Likewise, since Lisp_Subr is a special case.
1788 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1789 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1790 (struct Lisp_Hash_Table): Combine first two members into a single
1791 struct vectorlike_header member. All uses of "size" and "next" members
1792 changed to be "header.size" and "header.next".
1793 * buffer.h (struct buffer): Likewise.
1794 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1795 * frame.h (struct frame): Likewise.
1796 * process.h (struct Lisp_Process): Likewise.
1797 * termhooks.h (struct terminal): Likewise.
1798 * window.c (struct save_window_data, struct saved_window): Likewise.
1799 * window.h (struct window): Likewise.
1800 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1801 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1802 * buffer.c (init_buffer_once): Likewise.
1803 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1804 special case.
1805 * process.c (Fformat_network_address): Use local var for size,
1806 for brevity.
1807
1808 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1809
1810 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1811 * data.c (atof): Remove decl; no longer used or needed.
1812 (digit_to_number): Move to lread.c.
1813 (Fstring_to_number): Use new string_to_number function, to be
1814 consistent with how the Lisp reader treats infinities and NaNs.
1815 Do not assume that floating-point numbers represent EMACS_INT
1816 without losing information; this is not true on most 64-bit hosts.
1817 Avoid double-rounding errors, by insisting on integers when
1818 parsing non-base-10 numbers, as the documentation specifies.
1819 * lisp.h (string_to_number): New decl, replacing ...
1820 (isfloat_string): Remove.
1821 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1822 (read1): Do not accept +. and -. as integers; this
1823 appears to have been a coding error. Similarly, do not accept
1824 strings like +-1e0 as floating point numbers. Do not report
1825 overflow for integer overflows unless the base is not 10 which
1826 means we have no simple and reliable way to continue.
1827 Break out the floating-point parsing into a new
1828 function string_to_number, so that Fstring_to_number parses
1829 floating point numbers consistently with the Lisp reader.
1830 (digit_to_number): Move here from data.c. Make it static inline.
1831 (E_CHAR, EXP_INT): Remove, replacing with ...
1832 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1833 (string_to_number): New function, replacing isfloat_string.
1834 This function checks for valid syntax and produces the resulting
1835 Lisp float number too. Rework it so that string-to-number
1836 no longer mishandles examples like "1.0e+". Use strtoumax,
1837 so that overflow for non-base-10 numbers is reported only when
1838 there's no portable and simple way to convert to floating point.
1839
1840 * textprop.c (set_text_properties_1): Rewrite for clarity,
1841 and to avoid GCC warning about integer overflow.
1842
1843 * intervals.h (struct interval): Use EMACS_INT for members
1844 where EMACS_UINT might cause problems. See
1845 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1846 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1847 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1848 All uses changed.
1849 (offset_intervals): Tell GCC not to worry about length overflow
1850 when negating a negative length.
1851
1852 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1853 (overrun_check_free): Likewise.
1854
1855 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1856 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1857 word size.
1858
1859 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1860 (gnutls_make_error): Rename local to avoid shadowing.
1861 (gnutls_emacs_global_deinit): ifdef out; not used.
1862 (Fgnutls_boot): Use const for pointer to readonly storage.
1863 Comment out unused local. Fix pointer signedness problems.
1864
1865 * lread.c (openp): Don't stuff size_t into an 'int'.
1866 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1867 about possible signed overflow.
1868
1869 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1870 (GDK_KEY_g): Don't define if already defined.
1871 (xg_prepare_tooltip): Avoid pointer signedness problem.
1872 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1873
1874 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1875 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1876
1877 * xfns.c (Fx_window_property): Simplify a bit,
1878 to make a bit faster and to avoid GCC 4.6.0 warning.
1879 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1880
1881 * fns.c (internal_equal): Don't assume size_t fits in int.
1882
1883 * alloc.c (compact_small_strings): Tighten assertion a little.
1884
1885 Replace pEd with more-general pI, and fix some printf arg casts.
1886 * lisp.h (pI): New macro, generalizing old pEd macro to other
1887 conversion specifiers. For example, use "...%"pI"d..." rather
1888 than "...%"pEd"...".
1889 (pEd): Remove. All uses replaced with similar uses of pI.
1890 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1891 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1892 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1893 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1894 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1895 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1896 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1897 64-bit hosts.
1898 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1899 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1900 * print.c (safe_debug_print, print_object): Likewise.
1901 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1902 to int.
1903 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1904 avoiding the 0 flag, which is not portable.
1905 * process.c (Fmake_network_process): Use pI to avoid cast.
1906 * region-cache.c (pp_cache): Likewise.
1907 * xdisp.c (decode_mode_spec): Likewise.
1908 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1909 behavior on 64-bit hosts with printf arg.
1910 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1911 (x_stop_queuing_selection_requests): Likewise.
1912 (x_get_window_property): Don't truncate byte count to an 'int'
1913 when tracing.
1914
1915 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1916 here, since it parses constructs like leading '-' and spaces,
1917 which are not wanted; and it overflows with large numbers.
1918 Instead, simply match F[0-9]+, which is what is wanted anyway.
1919
1920 * alloc.c: Remove unportable assumptions about struct layout.
1921 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1922 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1923 (allocate_vectorlike, make_pure_vector): Use the new macros,
1924 plus offsetof, to remove unportable assumptions about struct layout.
1925 These assumptions hold on all porting targets that I know of, but
1926 they are not guaranteed, they're easy to remove, and removing them
1927 makes further changes easier.
1928
1929 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1930 This doesn't fix a bug but makes the code clearer.
1931 (string_overrun_cookie): Now const. Use initializers that
1932 don't formally overflow signed char, to avoid warnings.
1933 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1934 can cause Emacs to crash when string overrun checking is enabled.
1935 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1936 multiple of sizeof (EMACS_INT); it need not be, if
1937 alignof(EMACS_INT) < sizeof (EMACS_INT).
1938 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1939
1940 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1941
1942 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1943
1944 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1945
1946 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1947 supposed to be handshaking. (Bug#8556)
1948 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1949
1950 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1951
1952 * lisp.h (Qdebug): List symbol.
1953 * eval.c (Qdebug): Restore global linkage.
1954 * keyboard.c (debug-on-event): New variable.
1955 (handle_user_signal): Break into debugger when debug-on-event
1956 matches the current signal symbol.
1957
1958 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1959
1960 * alloc.c (check_sblock, check_string_bytes)
1961 (check_string_free_list): Convert to standard C.
1962
1963 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1964
1965 * w32.c (emacs_gnutls_push): Fix typo.
1966
1967 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1968
1969 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1970 "cast to pointer from integer of different size".
1971
1972 Improve doprnt and its use in verror. (Bug#8545)
1973 * doprnt.c (doprnt): Document the set of format control sequences
1974 supported by the function. Use SAFE_ALLOCA instead of always
1975 using `alloca'.
1976
1977 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1978 is one byte too soon. Don't use xrealloc; instead xfree and
1979 xmalloc anew.
1980
1981 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1982
1983 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1984 callbacks stage.
1985
1986 * gnutls.c: Renamed global_initialized to
1987 gnutls_global_initialized. Added internals for the
1988 :verify-hostname-error, :verify-error, and :verify-flags
1989 parameters of `gnutls-boot' and documented those parameters in the
1990 docstring. Start callback support.
1991 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1992 unless a fatal error occured. Call gnutls_alert_send_appropriate
1993 on error. Return error code.
1994 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1995 (emacs_gnutls_read): Likewise.
1996 (Fgnutls_boot): Return handshake error code.
1997 (emacs_gnutls_handle_error): New function.
1998 (wsaerror_to_errno): Likewise.
1999
2000 * w32.h (emacs_gnutls_pull): Add prototype.
2001 (emacs_gnutls_push): Likewise.
2002
2003 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2004 (emacs_gnutls_push): Likewise.
2005
2006 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2007
2008 * process.c (wait_reading_process_output): Check if GnuTLS
2009 buffered some data internally if no FDs are set for TLS
2010 connections.
2011
2012 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2013 (LIBS): Link to USER_LIBS.
2014 ($(BLD)/gnutls.$(0)): New target.
2015
2016 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2017
2018 * xdisp.c (handle_single_display_spec): Rename the
2019 display_replaced_before_p argument into display_replaced_p, to
2020 make it consistent with the commentary. Fix typos in the
2021 commentary.
2022
2023 * textprop.c (syms_of_textprop): Remove dead code.
2024 (copy_text_properties): Delete obsolete commentary about an
2025 interface that was deleted long ago. Fix typos in the description
2026 of arguments.
2027
2028 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2029 to changes in oldXMenu/XMenu.h from 2011-04-16.
2030 <menu_help_message, prev_menu_help_message>: Constify.
2031 (IT_menu_make_room): menu->help_text is now `const char **';
2032 adjust.
2033
2034 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2035 to changes in oldXMenu/XMenu.h from 2011-04-16.
2036 (struct XMenu): Declare `help_text' `const char **'.
2037
2038 * xfaces.c <Qunspecified>: Make extern again.
2039
2040 * syntax.c: Include sys/types.h before including regex.h, as
2041 required by Posix.
2042
2043 * doc.c (get_doc_string): Improve the format passed to `error'.
2044
2045 * doprnt.c (doprnt): Improve commentary.
2046
2047 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2048
2049 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2050 them with etags.
2051
2052 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2053 changes in globals.h immediately force recompilation.
2054 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2055 $(CURDIR)/s/ms-w32.h.
2056 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2057
2058 * character.c (Fchar_direction): Function deleted.
2059 (syms_of_character): Don't defsubr it.
2060 <char-direction-table>: Deleted.
2061
2062 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2063
2064 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2065 * doprnt.c: Include limits.h.
2066 (SIZE_MAX): New macro.
2067 (doprnt): Return a size_t value. 2nd arg is now size_t.
2068 Many local variables are now size_t instead of int or unsigned.
2069 Improve overflow protection. Support `l' modifier for integer
2070 conversions. Support %l conversion. Don't assume an EMACS_INT
2071 argument for integer conversions and for %c.
2072
2073 * lisp.h (doprnt): Restore prototype.
2074
2075 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2076 $(SRC)/character.h.
2077
2078 * Makefile.in (base_obj): Add back doprnt.o.
2079
2080 * deps.mk (doprnt.o): Add back prerequisites.
2081 (callint.o): Depend on character.h.
2082
2083 * eval.c (internal_lisp_condition_case): Include the handler
2084 representation in the error message.
2085 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2086 when breaking from the loop.
2087
2088 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2089
2090 * callint.c (Fcall_interactively): When displaying error message
2091 about invalid control letter, pass the character's codepoint, not
2092 a pointer to its multibyte form. Improve display of the character
2093 in octal and display also its hex code.
2094
2095 * character.c (char_string): Use %x to display the (unsigned)
2096 codepoint of an invalid character, to avoid displaying a bogus
2097 negative value.
2098
2099 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2100 `error', not SYMBOL_NAME itself.
2101
2102 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2103 character arguments to `error'.
2104
2105 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2106 to `error' in error message about FINAL_CHAR argument. Make sure
2107 FINAL_CHAR is a character, and use %c when it is passed as
2108 argument to `error'.
2109
2110 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2111
2112 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2113
2114 * w32.c: Include <time.h>.
2115 (sys_localtime): New function.
2116
2117 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2118
2119 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2120
2121 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2122
2123 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2124
2125 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2126 zombies (Bug#8467).
2127
2128 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2129
2130 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2131 gl_state.e_property when gl_state.object is Qt.
2132
2133 * insdel.c (make_gap_larger): Remove limitation of buffer size
2134 to <= INT_MAX.
2135
2136 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2137
2138 * xdisp.c (lookup_glyphless_char_display)
2139 (produce_glyphless_glyph): Handle cons cell entry in
2140 glyphless-char-display.
2141 (Vglyphless_char_display): Document it.
2142
2143 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2144 glyphless-char-display.
2145
2146 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2147
2148 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2149
2150 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2151
2152 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2153 definition for no-X builds.
2154
2155 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2156
2157 Static checks with GCC 4.6.0 and non-default toolkits.
2158
2159 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2160
2161 * process.c (keyboard_bit_set): Define only if SIGIO.
2162 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2163 (send_process): Repair possible setjmp clobbering.
2164
2165 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2166
2167 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2168
2169 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2170
2171 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2172 Define only if needed.
2173
2174 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2175 by pacifying GCC about it. Maybe it's time to retire it?
2176 * xfaces.c (USG, __TIMEVAL__): Likewise.
2177
2178 * dispextern.h (struct redisplay_interface): Rename param
2179 to avoid shadowing.
2180 * termhooks.h (struct terminal): Likewise.
2181 * xterm.c (xembed_send_message): Likewise.
2182
2183 * insdel.c (make_gap_smaller): Define only if
2184 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2185
2186 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2187 it.
2188
2189 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2190 so that we aren't warned about unused symbols.
2191
2192 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2193
2194 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2195
2196 * xfns.c (x_real_positions): Mark locals as initialized.
2197
2198 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2199
2200 * xterm.c: Fix problems found by static analysis with other toolkits.
2201 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2202 (x_dispatch_event): Declare static if USE_GTK, and
2203 define if USE_GTK || USE_X_TOOLKIT.
2204 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2205 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2206 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2207 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2208
2209 * xmenu.c (menu_help_callback): Pointer type fixes.
2210 Use const pointers when pointing at readonly data. Avoid pointer
2211 signedness clashes.
2212 (FALSE): Remove unused macro.
2213 (update_frame_menubar): Remove unused decl.
2214
2215 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2216
2217 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2218 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2219 (single_menu_item): Rename local to avoid shadowing.
2220
2221 * keyboard.c (make_lispy_event): Remove unused local var.
2222
2223 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2224 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2225
2226 * bitmaps: Change bitmaps from unsigned char back to the X11
2227 compatible char. Avoid the old compiler warnings about
2228 out-of-range initializers by using, for example, '\xab' rather
2229 than 0xab.
2230
2231 * xgselect.c (xgselect_initialize): Check vs interface
2232 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2233
2234 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2235
2236 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2237 to read-only memory.
2238
2239 * fns.c (vector): Remove; this old hack is no longer needed.
2240
2241 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2242 Remove unused var.
2243 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2244
2245 * xrdb.c (x_load_resources): Omit unused local.
2246
2247 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2248 (x_window): Rename locals to avoid shadowing.
2249 (USG): Use the kludged USG macro, to pacify gcc.
2250
2251 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2252 (x_term_init): Remove local to avoid shadowing.
2253
2254 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2255
2256 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2257 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2258
2259 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2260
2261 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2262
2263 Fix regex.c, syntax.c and friends for buffers > 2GB.
2264 * syntax.h (struct gl_state_s): Declare character position members
2265 EMACS_INT.
2266
2267 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2268
2269 * textprop.c (verify_interval_modification, interval_of):
2270 Declare arguments EMACS_INT.
2271
2272 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2273 EMACS_INT.
2274
2275 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2276
2277 * indent.c (Fvertical_motion): Local variable it_start is now
2278 EMACS_INT.
2279
2280 * regex.c (re_match, re_match_2, re_match_2_internal)
2281 (bcmp_translate, regcomp, regexec, print_double_string)
2282 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2283 (re_compile_pattern, re_exec): Declare arguments and local
2284 variables `size_t' and `ssize_t' and return values `regoff_t', as
2285 appropriate.
2286 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2287 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2288 <compile_stack_type>: `size' and `avail' are now `size_t'.
2289
2290 * regex.h <regoff_t>: Use ssize_t, not int.
2291 (re_search, re_search_2, re_match, re_match_2): Arguments that
2292 specify buffer/string position and length are now ssize_t and
2293 size_t. Return type is regoff_t.
2294
2295 2011-04-16 Ben Key <bkey76@gmail.com>
2296
2297 * nsfont.m: Fixed bugs in ns_get_family and
2298 ns_descriptor_to_entity that were caused by using free to
2299 deallocate memory blocks that were allocated by xmalloc (via
2300 xstrdup). This caused Emacs to crash when compiled with
2301 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2302 --enable-checking=xmallocoverrun). xfree is now used to
2303 deallocate these memory blocks.
2304
2305 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2306
2307 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2308
2309 emacs_write: Accept and return EMACS_INT for sizes.
2310 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2311 et seq.
2312 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2313 Accept and return EMACS_INT.
2314 (emacs_gnutls_write): Return the number of bytes written on
2315 partial writes.
2316 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2317 (emacs_read, emacs_write): Remove check for negative size, as the
2318 Emacs source code has been audited now.
2319 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2320 (emacs_read, emacs_write): Use it.
2321 * process.c (send_process): Adjust to the new signatures of
2322 emacs_write and emacs_gnutls_write. Do not attempt to store
2323 a byte offset into an 'int'; it might overflow.
2324 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2325
2326 * sound.c: Don't assume sizes fit in 'int'.
2327 (struct sound_device.period_size, alsa_period_size):
2328 Return EMACS_INT, not int.
2329 (struct sound_device.write, vox_write, alsa_write):
2330 Accept EMACS_INT, not int.
2331 (wav_play, au_play): Use EMACS_INT to store sizes and to
2332 record read return values.
2333
2334 2011-04-15 Ben Key <bkey76@gmail.com>
2335
2336 * keyboard.c (Qundefined): Don't declare static since it is used
2337 in nsfns.m.
2338 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2339 static since they are used in nsfont.m.
2340
2341 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2342
2343 * process.c (Qprocessp): Don't declare static.
2344 * lisp.h (Qprocessp): Declare again.
2345
2346 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2347
2348 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2349
2350 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2351
2352 Improve C-level modularity by making more things 'static'.
2353
2354 Don't publish debugger-only interfaces to other modules.
2355 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2356 (verify_bytepos, count_markers): Move decls to the only modules
2357 that need them.
2358 * region-cache.h (pp_cache): Likewise.
2359 * window.h (check_all_windows): Likewise.
2360 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2361
2362 * sysdep.c (croak): Now static, if
2363 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2364 * syssignal.h (croak): Declare only if not static.
2365
2366 * alloc.c (refill_memory_reserve): Now static if
2367 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2368 * lisp.h (refill_memory_reserve): Declare only if not static.
2369
2370 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2371 Define only if USE_LUCID.
2372
2373 * xrdb.c (x_customization_string, x_rm_string): Now static.
2374
2375 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2376 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2377
2378 * xdisp.c (draw_row_with_mouse_face): Now static.
2379 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2380
2381 * window.h (check_all_windows): Mark externally visible.
2382
2383 * window.c (window_deletion_count): Now static.
2384
2385 * undo.c: Make symbols static if they're not exported.
2386 (last_undo_buffer, last_boundary_position, pending_boundary):
2387 Now static.
2388
2389 * textprop.c (interval_insert_behind_hooks): Now static.
2390 (interval_insert_in_front_hooks): Likewise.
2391
2392 * term.c: Make symbols static if they're not exported.
2393 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2394 (max_frame_lines, tty_set_terminal_modes):
2395 (tty_reset_terminal_modes, tty_turn_off_highlight):
2396 (get_tty_terminal): Now static.
2397 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2398 * termhooks.h (term_mouse_moveto): Do not declare if
2399 HAVE_WINDOW_SYSTEM.
2400 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2401 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2402
2403 * sysdep.c: Make symbols static if they're not exported.
2404 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2405 Now static.
2406 (sigprocmask_set, full_mask): Remove; unused.
2407 (wait_debugging): Mark as visible.
2408 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2409 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2410
2411 * syntax.c (syntax_temp): Define only if !__GNUC__.
2412
2413 * sound.c (current_sound_device, current_sound): Now static.
2414
2415 * search.c (searchbufs, searchbuf_head): Now static.
2416
2417 * scroll.c (scroll_cost): Remove; unused.
2418 * dispextern.h (scroll_cost): Remove decl.
2419
2420 * region-cache.h (pp_cache): Mark as externally visible.
2421
2422 * process.c: Make symbols static if they're not exported.
2423 (process_tick, update_tick, create_process, chan_process):
2424 (Vprocess_alist, proc_buffered_char, datagram_access):
2425 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2426 (deactivate_process): Mark defn as static, as well as decl.
2427 * lisp.h (create_process): Remove decl.
2428 * process.h (chan_process, Vprocess_alist): Remove decls.
2429
2430 * print.c: Make symbols static if they're not exported.
2431 (print_depth, new_backquote_output, being_printed, print_buffer):
2432 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2433 (print_interval, print_number_index, initial_stderr_stream):
2434 Now static.
2435 * lisp.h (Fprinc): Remove decl.
2436 (debug_output_compilation_hack): Mark as externally visible.
2437
2438 * sysdep.c (croak): Move decl from here to syssignal.h.
2439 * syssignal.h (croak): Put it here, so the API can be checked when
2440 'croak' is called from dissociate_if_controlling_tty.
2441
2442 * minibuf.c: Make symbols static if they're not exported.
2443 (minibuf_save_list, choose_minibuf_frame): Now static.
2444 * lisp.h (choose_minibuf_frame): Remove decl.
2445
2446 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2447
2448 * lread.c: Make symbols static if they're not exported.
2449 (read_objects, initial_obarray, oblookup_last_bucket_number):
2450 Now static.
2451 (make_symbol): Remove; unused.
2452 * lisp.h (initial_obarray, make_symbol): Remove decls.
2453
2454 * keyboard.c: Make symbols static if they're not exported.
2455 (single_kboard, recent_keys_index, total_keys, recent_keys):
2456 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2457 (this_single_command_key_start, echoing, last_auto_save):
2458 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2459 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2460 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2461 (Vlispy_mouse_stem, double_click_count):
2462 Now static.
2463 (force_auto_save_soon): Define only if SIGDANGER.
2464 (ignore_mouse_drag_p): Now static if
2465 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2466 (print_help): Remove; unused.
2467 (stop_character, last_timer_event): Mark as externally visible.
2468 * keyboard.h (ignore_mouse_drag_p): Declare only if
2469 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2470 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2471 * lisp.h (echoing): Remove decl.
2472 (force_auto_save_soon): Declare only if SIGDANGER.
2473 * xdisp.c (redisplay_window): Simplify code, to make it more
2474 obvious that ignore_mouse_drag_p is not accessed if !defined
2475 USE_GTK && !defined HAVE_NS.
2476
2477 * intervals.c: Make symbols static if they're not exported.
2478 (merge_properties_sticky, merge_interval_right, delete_interval):
2479 Now static.
2480 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2481
2482 * insdel.c: Make symbols static if they're not exported.
2483 However, leave prepare_to_modify_buffer alone. It's never
2484 called from outside this function, but that appears to be a bug.
2485 (combine_after_change_list, combine_after_change_buffer):
2486 (adjust_after_replace, signal_before_change): Now static.
2487 (adjust_after_replace_noundo): Remove; unused.
2488 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2489 (signal_before_change): Remove decls.
2490
2491 * indent.c (val_compute_motion, val_vmotion): Now static.
2492
2493 * image.c: Make symbols static if they're not exported.
2494 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2495 if USE_GTK.
2496 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2497 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2498
2499 * fringe.c (standard_bitmaps): Now static.
2500 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2501
2502 * frame.c: Make symbols static if they're not exported.
2503 (x_report_frame_params, make_terminal_frame): Now static.
2504 (get_frame_param): Now static, unless HAVE_NS.
2505 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2506 (x_get_resource_string): Remove; not used.
2507 * frame.h (make_terminal_frame, x_report_frame_params):
2508 (x_get_resource_string); Remove decls.
2509 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2510 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2511
2512 * font.c, fontset.c: Make symbols static if they're not exported.
2513 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2514 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2515 * font.c (font_close_object): Now static.
2516 * font.h (font_close_object): Remove.
2517 * fontset.c (FONTSET_OBJLIST): Remove.
2518 (free_realized_fontset) #if-0 the body, which does nothing.
2519 (face_suitable_for_char_p): #if-0, as it's never called.
2520 * fontset.h (face_suitable_for_char_p): Remove decl.
2521 * xfaces.c (face_at_string_position):
2522 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2523 since 0 is always ASCII.
2524
2525 * fns.c (weak_hash_tables): Now static.
2526
2527 * fileio.c: Make symbols static if they're not exported.
2528 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2529 (Vwrite_region_annotation_buffers): Now static.
2530
2531 * eval.c: Make symbols static if they're not exported.
2532 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2533 * lisp.h (backtrace_list): Remove decl.
2534
2535 * emacs.c: Make symbols static if they're not exported.
2536 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2537 (fatal_error_code, fatal_error_signal_hook, standard_args):
2538 Now static.
2539 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2540 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2541 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2542 * lisp.h (fatal_error_signal_hook): Remove decl.
2543 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2544
2545 * editfns.c: Move a (normally-unused) function to its only use.
2546 * editfns.c, lisp.h (get_operating_system_release): Remove.
2547 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2548 worth the hassle of breaking this out.
2549
2550 * xterm.c: Make symbols static if they're not exported.
2551 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2552 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2553 (x_destroy_window, x_delete_display):
2554 Now static.
2555 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2556 (x_mouse_leave): Remove; unused.
2557 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2558 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2559 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2560 Remove decls.
2561 (x_mouse_leave): Declare only if WINDOWSNT.
2562 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2563 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2564 USE_X_TOOLKIT.
2565
2566 * ftxfont.c: Make symbols static if they're not exported.
2567 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2568 HAVE_FREETYPE.
2569 * font.h (ftxfont_driver): Likewise.
2570
2571 * xfns.c: Make symbols static if they're not exported.
2572 (x_last_font_name, x_display_info_for_name):
2573 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2574 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2575 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2576 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2577 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2578 (last_show_tip_args): Now static.
2579 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2580 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2581 (x_screen_planes): Remove; unused.
2582 * dispextern.h (x_screen_planes): Remove decl.
2583
2584 * dispnew.c: Make symbols static if they're not exported.
2585 * dispextern.h (redraw_garbaged_frames, scrolling):
2586 (increment_row_positions): Remove.
2587 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2588 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2589 Now static.
2590 (redraw_garbaged_frames): Remove; unused.
2591
2592 * xfaces.c: Make symbols static if they're not exported.
2593 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2594 Remove decls.
2595 * xterm.h (defined_color): Remove decls.
2596 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2597 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2598 (menu_face_changed_default, defined_color, free_realized_face):
2599 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2600 (ascii_face_of_lisp_face): Remove; unused.
2601
2602 * xdisp.c: Make symbols static if they're not exported.
2603 * dispextern.h (scratch_glyph_row, window_box_edges):
2604 (glyph_to_pixel_coords, set_cursor_from_row):
2605 (get_next_display_element, set_iterator_to_next):
2606 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2607 (show_mouse_face): Remove decls
2608 * frame.h (message_buf_print): Likewise.
2609 * lisp.h (pop_message, set_message, check_point_in_composition):
2610 Likewise.
2611 * xterm.h (set_vertical_scroll_bar): Likewise.
2612 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2613 (message_buf_print, scratch_glyph_row, displayed_buffer):
2614 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2615 (get_next_display_element, show_mouse_face, window_box_edges):
2616 (frame_to_window_pixel_xy, check_point_in_composition):
2617 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2618 (glyph_to_pixel_coords): Remove; unused.
2619
2620 * dired.c (file_name_completion): Now static.
2621
2622 * dbusbind.c (xd_in_read_queued_messages): Now static.
2623
2624 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2625 * data.c (circular_list_error): Remove.
2626
2627 * commands.h (last_point_position, last_point_position_buffer):
2628 (last_point_position_window): Remove decls.
2629 * keyboard.c: Make these variables static.
2630
2631 * coding.h (coding, code_convert_region, encode_coding_gap):
2632 Remove decls.
2633 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2634 (iso_code_class, detect_coding, code_convert_region): Now static.
2635 (encode_coding_gap): Remove; unused.
2636
2637 * chartab.c (chartab_chars, chartab_bits): Now static.
2638
2639 * charset.h (charset_iso_8859_1): Remove decl.
2640 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2641 Now static.
2642
2643 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2644 * ccl.c (Vccl_program_table): Now static.
2645 (check_ccl_update): Remove; unused.
2646
2647 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2648 * category.h: ... from here.
2649 * category.c (check_category_table, set_category_set): Now static.
2650
2651 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2652 * lisp.h: Remove these decls.
2653
2654 * buffer.c (buffer_count): Remove unused var.
2655
2656 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2657 so that it's not optimized away.
2658 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2659 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2660 exported only to the debugger.
2661
2662 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2663 * atimer.h (run_all_atimers): Remove; not exported.
2664
2665 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2666 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2667 was inaccessible from Lisp.
2668 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2669 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2670
2671 alloc.c: Import and export fewer symbols, and remove unused items.
2672 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2673 is defined.
2674 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2675 it's not optimized away by whole-program optimization.
2676 (message_enable_multibyte, free_misc): Remove.
2677 (catchlist, handlerlist, mark_backtrace):
2678 Declare only if BYTE_MARK_STACK.
2679 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2680 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2681 (message_enable_multibyte): Remove decl.
2682 (free_misc, interval_free_list, float_block, float_block_index):
2683 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2684 (cons_free_list, last_marked_index):
2685 Now static.
2686 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2687 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2688 (mark_backtrace): Define only if BYTE_MARK_STACK.
2689 * xdisp.c (message_enable_multibyte): Now static.
2690
2691 Declare Lisp_Object Q* variables to be 'static' if not exported.
2692 This makes it easier for human readers (and static analyzers)
2693 to see whether these variables are used from other modules.
2694 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2695 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2696 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2697 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2698 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2699 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2700 * xmenu.c, xselect.c:
2701 Declare Q* vars static if they are not used in other modules.
2702 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2703 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2704 Remove decls of unexported vars.
2705 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2706
2707 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2708
2709 Make Emacs functions such as Fatom 'static' by default.
2710 This makes it easier for human readers (and static analyzers)
2711 to see whether these functions can be called from other modules.
2712 DEFUN now defines a static function. To make the function external
2713 so that it can be used in other C modules, use the new macro DEFUE.
2714 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2715 (Finit_image_library):
2716 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2717 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2718 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2719 Remove decls, since these functions are now static.
2720 (Funintern, Fget_internal_run_time): New decls, since these functions
2721 were already external.
2722
2723 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2724 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2725 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2726 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2727 * keyboard.c, keymap.c, lread.c:
2728 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2729 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2730 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2731 Mark functions with DEFUE instead of DEFUN,
2732 if they are used in other modules.
2733 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2734 decls for now-static functions.
2735 * buffer.h (Fdelete_overlay): Remove decl.
2736 * callproc.c (Fgetenv_internal): Mark as internal.
2737 * composite.c (Fremove_list_of_text_properties): Remove decl.
2738 (Fcomposition_get_gstring): New forward static decl.
2739 * composite.h (Fcomposite_get_gstring): Remove decl.
2740 * dired.c (Ffile_attributes): New forward static decl.
2741 * doc.c (Fdocumntation_property): New forward static decl.
2742 * eval.c (Ffetch_bytecode): New forward static decl.
2743 (Funintern): Remove extern decl; now in .h file where it belongs.
2744 * fileio.c (Fmake_symbolic_link): New forward static decl.
2745 * image.c (Finit_image_library): New forward static decl.
2746 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2747 * intervals.h (Fprevious_property_change):
2748 (Fremove_list_of_text_properties): Remove decls.
2749 * keyboard.c (Fthis_command_keys): Remove decl.
2750 (Fcommand_execute): New forward static decl.
2751 * keymap.c (Flookup_key): New forward static decl.
2752 (Fcopy_keymap): Now static.
2753 * keymap.h (Flookup_key): Remove decl.
2754 * process.c (Fget_process): New forward static decl.
2755 (Fprocess_datagram_address): Mark as internal.
2756 * syntax.c (Fsyntax_table_p): New forward static decl.
2757 (skip_chars): Remove duplicate decl.
2758 * textprop.c (Fprevious_property_change): New forward static decl.
2759 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2760 Now internal.
2761 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2762 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2763
2764 * editfns.c (Fformat): Remove unreachable code.
2765
2766 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2767
2768 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2769 change. (Bug#8496)
2770
2771 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2772
2773 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2774 when at ZV. (Bug#8487)
2775
2776 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2777
2778 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2779 (Bug#8437)
2780 * keyboard.c (parse_tool_bar_item): Likewise.
2781 * sound.c (sound_cleanup, alsa_close): Likewise.
2782 * termcap.c (tgetent): Likewise.
2783 * xfns.c (x_default_font_parameter): Likewise.
2784 * xsettings.c (read_and_apply_settings): Likewise.
2785
2786 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2787 (overrun_check_free): Protoize.
2788
2789 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2790
2791 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2792 since callers should never pass a negative size.
2793 Change the signature to match that of plain 'read' and 'write'; see
2794 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2795 * lisp.h: Update prototypes of emacs_write and emacs_read.
2796
2797 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2798
2799 * xdisp.c (redisplay_window): Don't try to determine the character
2800 position of the scroll margin if the window start point w->startp
2801 is outside the buffer's accessible region. (Bug#8468)
2802
2803 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2804
2805 Fix write-region and its subroutines for buffers > 2GB.
2806 * fileio.c (a_write, e_write): Modify declaration of arguments and
2807 local variables to support buffers larger than 2GB.
2808 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2809
2810 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2811 argument, local variables, and return value.
2812
2813 * lisp.h: Update prototypes of emacs_write and emacs_read.
2814
2815 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2816
2817 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2818
2819 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2820
2821 Fix more problems found by GCC 4.6.0's static checks.
2822
2823 * xdisp.c (vmessage): Use a better test for character truncation.
2824
2825 * charset.c (load_charset_map): <, not <=, for optimization,
2826 and to avoid potential problems with integer overflow.
2827 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2828 * casetab.c (set_identity, shuffle): Likewise.
2829 * editfns.c (Fformat): Likewise.
2830 * syntax.c (skip_chars): Likewise.
2831
2832 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2833 This also lets GCC 4.6.0 generate slightly better loop code.
2834
2835 * callint.c (Fcall_interactively): <, not <=, for optimization.
2836 (Fcall_interactively): Count the number of arguments produced,
2837 not the number of arguments given. This is simpler and lets GCC
2838 4.6.0 generate slightly better code.
2839
2840 * ftfont.c: Distingish more carefully between FcChar8 and char.
2841 The previous code passed unsigned char * to a functions like
2842 strlen and xstrcasecmp that expect char *, which does not
2843 conform to the C standard.
2844 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2845 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2846 char * when the C standard requires it.
2847
2848 * keyboard.c (read_char): Remove unused var.
2849
2850 * eval.c: Port to Windows vsnprintf (Bug#8435).
2851 Include <limits.h>.
2852 (SIZE_MAX): Define if the headers do not.
2853 (verror): Do not give up if vsnprintf returns a negative count.
2854 Instead, grow the buffer. This ports to Windows vsnprintf, which
2855 does not conform to C99. Problem reported by Eli Zaretskii.
2856 Also, simplify the allocation scheme, by avoiding the need for
2857 calling realloc, and removing the ALLOCATED variable.
2858
2859 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2860
2861 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2862 But keep the doprint source code for now, as we might revamp it
2863 and use it again (Bug#8435).
2864 * lisp.h (doprnt): Remove.
2865 * Makefile.in (base_obj): Remove doprnt.o.
2866 * deps.mk (doprnt.o): Remove.
2867
2868 error: Print 32- and 64-bit integers portably (Bug#8435).
2869 Without this change, on typical 64-bit hosts error ("...%d...", N)
2870 was used to print both 32- and 64-bit integers N, which relied on
2871 undefined behavior.
2872 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2873 New macro.
2874 * lisp.h (error, verror): Mark as printf-like functions.
2875 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2876 Report overflow in size calculations when allocating printf buffer.
2877 Do not truncate output string at its first null byte.
2878 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2879 Truncate the output at a character boundary, since vsnprintf does not
2880 do that.
2881 * charset.c (check_iso_charset_parameter): Convert internal
2882 character to string before calling 'error', since %c now has the
2883 printf meaning.
2884 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2885 overflow when computing char to be passed to 'error'. Do not
2886 pass Lisp_Object to 'error'; pass the integer instead.
2887 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2888 formatted with plain %d.
2889
2890 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2891
2892 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2893
2894 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2895
2896 * xterm.c (x_catch_errors): Remove duplicate declaration.
2897
2898 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2899
2900 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2901
2902 2011-04-10 Jim Meyering <meyering@redhat.com>
2903
2904 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2905 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2906 return ssize_t not "int", and use size_t as the buffer length.
2907 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2908 * gnutls.h: Update declarations.
2909 * process.c (read_process_output): Use ssize_t, to match.
2910 (send_process): Likewise.
2911
2912 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2913
2914 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2915
2916 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2917
2918 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2919 Use unsigned char, to match FcChar8 type definition.
2920
2921 * xterm.c (handle_one_xevent):
2922 * xmenu.c (create_and_show_popup_menu):
2923 * xselect.c (x_decline_selection_request)
2924 (x_reply_selection_request): Avoid type-punned deref of X events.
2925
2926 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2927
2928 Fix some uses of `int' instead of EMACS_INT.
2929 * search.c (string_match_1, fast_string_match)
2930 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2931 (scan_buffer, find_next_newline_no_quit)
2932 (find_before_next_newline, search_command, Freplace_match)
2933 (Fmatch_data): Make some `int' variables be EMACS_INT.
2934
2935 * xdisp.c (display_count_lines): 3rd argument and return value now
2936 EMACS_INT. All callers changed.
2937 (pint2hrstr): Last argument is now EMACS_INT.
2938
2939 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2940 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2941 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2942 (decode_coding_utf_16, decode_coding_emacs_mule)
2943 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2944 (decode_coding_ccl, decode_coding_charset)
2945 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2946 (decode_coding_iso_2022, decode_coding_emacs_mule)
2947 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2948 <char_offset, last_offset>: Declare EMACS_INT.
2949 (encode_coding_utf_8, encode_coding_utf_16)
2950 (encode_coding_emacs_mule, encode_invocation_designation)
2951 (encode_designation_at_bol, encode_coding_iso_2022)
2952 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2953 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2954 Declare EMACS_INT.
2955 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2956 (encode_invocation_designation): Last argument P_NCHARS is now
2957 EMACS_INT.
2958 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2959 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2960
2961 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2962 All users changed.
2963
2964 * ccl.c (Fccl_execute_on_string): Declare some variables
2965 EMACS_INT.
2966
2967 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2968
2969 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2970
2971 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2972
2973 * process.c (Fformat_network_address): Doc fix.
2974
2975 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2976
2977 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2978
2979 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2980
2981 * keyboard.c (read_char): Call Lisp function help-form-show,
2982 instead of using internal_with_output_to_temp_buffer.
2983 (Qhelp_form_show): New var.
2984 (syms_of_keyboard): Use DEFSYM macro.
2985
2986 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2987
2988 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2989
2990 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2991
2992 * process.c (Flist_processes): Remove to Lisp.
2993 (list_processes_1): Delete.
2994
2995 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2996
2997 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2998
2999 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3000
3001 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 Fix more problems found by GCC 4.6.0's static checks.
3004
3005 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3006
3007 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3008
3009 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3010
3011 * xdisp.c (vmessage): Mark as a printf-like function.
3012
3013 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3014
3015 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3016
3017 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3018 printf-like functions.
3019 (tiff_load): Add casts to remove these marks before passing them
3020 to system-supplied API.
3021
3022 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3023
3024 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3025 This avoids several warnings with gcc -Wstrict-overflow.
3026 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3027 directly, rather than having caller test rule sign. This avoids
3028 some unnecessary tests.
3029 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3030 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3031 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3032
3033 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3034 (xfont_open): Avoid unnecessary tests.
3035
3036 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3037
3038 * composite.h, composite.c (composition_gstring_put_cache):
3039 Use EMACS_INT, not int, for length.
3040
3041 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3042 breaking out part of COMPOSITION_DECODE_RULE.
3043 (COMPOSITION_DECODE_RULE): Use it.
3044 * composite.c (get_composition_id): Remove unused local vars,
3045 by using the new macro.
3046
3047 * textprop.c (set_text_properties_1): Change while to do-while,
3048 since the condition is always true at first.
3049
3050 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3051 (interval_deletion_adjustment): Return unsigned value.
3052 All uses changed.
3053
3054 * process.c (list_processes_1, create_pty, read_process_output):
3055 (exec_sentinel): Remove vars that were set but not used.
3056 (create_pty): Remove unnecessary "volatile"s.
3057 (Fnetwork_interface_info): Avoid possibility of int overflow.
3058 (read_process_output): Do adaptive read buffering even if carryover.
3059 (read_process_output): Simplify nbytes computation if buffered.
3060
3061 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3062
3063 * syntax.c (scan_words): Remove var that was set but not used.
3064 (update_syntax_table): Use unsigned instead of int.
3065
3066 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3067 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3068 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3069
3070 * print.c (print_error_message): Avoid int overflow.
3071
3072 * font.c (font_list_entities): Redo for clarity,
3073 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3074
3075 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3076 (font_score): Avoid potential overflow in diff calculation.
3077
3078 * fns.c (substring_both): Remove var that is set but not used.
3079 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3080
3081 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3082
3083 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3084 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3085 can always succeed if overflow has undefined behavior.
3086
3087 * search.c (boyer_moore, wordify): Remove vars set but not used.
3088 (wordify): Omit three unnecessary tests.
3089
3090 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3091 All callers changed. This avoids the need for an unused var.
3092
3093 * casefiddle.c (casify_region): Remove var that is set but not used.
3094
3095 * dired.c (file_name_completion): Remove var that is set but not used.
3096
3097 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3098
3099 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3100 (Finsert_file_contents): Remove unnecessary code checking fd.
3101
3102 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3103 Check for integer overflow on size calculations.
3104
3105 * buffer.c (Fprevious_overlay_change): Remove var that is set
3106 but not used.
3107
3108 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3109 Remove vars that are set but not used.
3110 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3111 (timer_check_2): Mark vars as initialized.
3112
3113 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3114
3115 * image.c (lookup_image): Remove var that is set but not used.
3116 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3117
3118 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3119 that are set but not used.
3120
3121 * xfns.c (make_invisible_cursor): Don't return garbage
3122 if XCreateBitmapFromData fails (Bug#8410).
3123
3124 * xselect.c (x_get_local_selection, x_handle_property_notify):
3125 Remove vars that are set but not used.
3126
3127 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3128 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3129
3130 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3131 Remove var that is set but not used.
3132 (scroll_bar_windows_size): Now size_t, not int.
3133 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3134 Check for overflow.
3135
3136 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3137 (map_tty_color) [!defined MSDOS]: Likewise.
3138
3139 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3140
3141 * coding.c: Remove vars that are set but not used.
3142 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3143 All callers changed.
3144 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3145 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3146 (decode_coding_charset): Remove vars that are set but not used.
3147
3148 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3149 that is set but not used.
3150
3151 * print.c (print_object): Remove var that is set but not used.
3152
3153 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3154 The gnulib version avoids calling malloc in the usual case,
3155 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3156 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3157 * filelock.c (current_lock_owner): Likewise.
3158 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3159 * sysdep.c: Include allocator.h, careadlinkat.h.
3160 (emacs_no_realloc_allocator): New static constant.
3161 (emacs_readlink): New function.
3162 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3163 ../lib/careadlinkat.h.
3164
3165 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3166
3167 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3168 first non-nil return value).
3169
3170 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3171
3172 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3173 if not defined (Bug#8403).
3174
3175 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3176
3177 * xdisp.c (display_count_lines): Remove parameter `start',
3178 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3179 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3180 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3181 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3182 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3183 and thereabouts. All callers changed.
3184 (get_per_char_metric): Remove parameter `f', unused since
3185 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3186
3187 2011-04-02 Jim Meyering <meyering@redhat.com>
3188
3189 do not dereference NULL upon failed strdup
3190 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3191 (ns_get_family): Likewise.
3192
3193 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3194
3195 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3196
3197 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3198
3199 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3200 later (Bug#8403).
3201
3202 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3203
3204 Add lexical binding.
3205
3206 * window.c (Ftemp_output_buffer_show): New fun.
3207 (Fsave_window_excursion):
3208 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3209
3210 * lread.c (lisp_file_lexically_bound_p): New function.
3211 (Fload): Bind Qlexical_binding.
3212 (readevalloop): Remove `evalfun' arg.
3213 Bind Qinternal_interpreter_environment.
3214 (Feval_buffer): Bind Qlexical_binding.
3215 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3216 Mark as dynamic.
3217 (syms_of_lread): Declare `lexical-binding'.
3218
3219 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3220
3221 * keyboard.c (eval_dyn): New fun.
3222 (menu_item_eval_property): Use it.
3223
3224 * image.c (parse_image_spec): Use Ffunctionp.
3225
3226 * fns.c (concat, mapcar1): Accept byte-code-functions.
3227
3228 * eval.c (Fsetq): Handle lexical vars.
3229 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3230 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3231 (FletX, Flet): Obey lexical binding.
3232 (Fcommandp): Handle closures.
3233 (Feval): New `lexical' arg.
3234 (eval_sub): New function extracted from Feval. Use it almost
3235 everywhere where Feval was used. Look up vars in lexical env.
3236 Handle closures.
3237 (Ffunctionp): Move from subr.el.
3238 (Ffuncall): Handle closures.
3239 (apply_lambda): Remove `eval_flags'.
3240 (funcall_lambda): Handle closures and new byte-code-functions.
3241 (Fspecial_variable_p): New function.
3242 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3243 but without exporting it to Lisp.
3244
3245 * doc.c (Fdocumentation, store_function_docstring):
3246 * data.c (Finteractive_form): Handle closures.
3247
3248 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3249 interactive spec.
3250
3251 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3252 New byte-codes.
3253 (exec_byte_code): New function extracted from Fbyte_code to handle new
3254 calling convention for byte-code-functions. Add new byte-codes.
3255
3256 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3257
3258 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3259
3260 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3261
3262 * xdisp.c (redisplay_internal): Fix prototype.
3263
3264 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3265
3266 * xdisp.c (SCROLL_LIMIT): New macro.
3267 (try_scrolling): Use it when setting scroll_limit.
3268 Limit scrolling to 100 screen lines.
3269 (redisplay_window): Even when falling back on "recentering",
3270 position point in the window according to scroll-conservatively,
3271 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3272
3273 (try_scrolling): When point is above the window, allow searching
3274 as far as scroll_max, or one screenful, to compute vertical
3275 distance from PT to the scroll margin position. This prevents
3276 try_scrolling from unnecessarily failing when
3277 scroll-conservatively is set to a value slightly larger than the
3278 window height. Clean up the case of PT below the margin at bottom
3279 of window: scroll_max can no longer be INT_MAX. When aggressive
3280 scrolling is in use, don't let point enter the opposite scroll
3281 margin as result of the scroll.
3282 (syms_of_xdisp) <scroll-conservatively>: Document the
3283 threshold of 100 lines for never-recentering scrolling.
3284
3285 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3286
3287 * dispextern.h (move_it_by_lines):
3288 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3289 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3290 (message_log_check_duplicate): Remove parameters `prev_bol' and
3291 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3292 (redisplay_internal): Remove parameter `preserve_echo_area',
3293 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3294
3295 * indent.c (Fvertical_motion):
3296 * window.c (window_scroll_pixel_based, Frecenter):
3297 Don't pass `need_y_p' to `move_it_by_lines'.
3298
3299 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3300
3301 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3302 steal a few bits to be more compact.
3303 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3304 Remove unneeded casts.
3305
3306 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3307
3308 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3309
3310 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3311 binding" message (bug#7967).
3312
3313 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3314
3315 Fix more problems found by GCC 4.6.0's static checks.
3316
3317 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3318 Remove unused local var.
3319
3320 * editfns.c (Fmessage_box): Remove unused local var.
3321
3322 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3323 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3324 Omit unused local vars.
3325 * window.c (shrink_windows): Omit unused local var.
3326 * menu.c (digest_single_submenu): Omit unused local var.
3327 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3328 Omit unused local var.
3329
3330 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3331 Don't assume string length fits in int.
3332 (keyremap_step, read_key_sequence): Use size_t for sizes.
3333 (read_key_sequence): Don't check last_real_key_start redundantly.
3334
3335 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3336 instead of alloca (Bug#8344).
3337
3338 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3339 (Fbacktrace_frame): Don't assume nframes fits in int.
3340
3341 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3342
3343 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3344 concerns.
3345
3346 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3347
3348 * cm.c (calccost): Turn while-do into do-while, for clarity.
3349
3350 * keyboard.c (syms_of_keyboard): Use the same style as later
3351 in this function when indexing through an array. This also
3352 works around GCC bug 48267.
3353
3354 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3355
3356 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3357
3358 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3359 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3360
3361 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3362 This avoids undefined behavior on integer overflow, and is a bit
3363 more convenient anyway since it is compared to a size_t variable.
3364
3365 Variadic C functions now count arguments with size_t, not int.
3366 This avoids an unnecessary limitation on 64-bit machines, which
3367 caused (substring ...) to crash on large vectors (Bug#8344).
3368 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3369 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3370 All variadic functions and their callers changed accordingly.
3371 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3372 * data.c (arith_driver, float_arith_driver): Likewise.
3373 * editfns.c (general_insert_function): Likewise.
3374 * eval.c (struct backtrace.nargs, interactive_p)
3375 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3376 (funcall_lambda, mark_backtrace): Likewise.
3377 * fns.c (concat): Likewise.
3378 * frame.c (x_set_frame_parameters): Likewise.
3379 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3380 0 if not found, not -1. All callers changed.
3381
3382 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3383 (stack_copy_size): Now size_t, not int.
3384 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3385
3386 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3387
3388 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3389 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3390 All callers changed.
3391
3392 * lisp.h (multibyte_char_to_unibyte):
3393 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3394 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3395 * character.h (CHAR_TO_BYTE8):
3396 * cmds.c (internal_self_insert):
3397 * editfns.c (general_insert_function):
3398 * keymap.c (push_key_description):
3399 * search.c (Freplace_match):
3400 * xdisp.c (message_dolog, set_message_1): All callers changed.
3401
3402 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3403
3404 * keyboard.c (safe_run_hook_funcall): New function.
3405 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3406 don't set the hook to nil, but remove the offending function instead.
3407 (Qcommand_hook_internal): Remove, unused.
3408 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3409 Vcommand_hook_internal.
3410
3411 * eval.c (enum run_hooks_condition): Remove.
3412 (funcall_nil, funcall_not): New functions.
3413 (run_hook_with_args): Call each function through a `funcall' argument.
3414 Remove `cond' argument, now redundant.
3415 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3416 (Frun_hook_with_args_until_failure): Adjust accordingly.
3417 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3418
3419 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3420
3421 * dispextern.h (string_buffer_position): Remove declaration.
3422
3423 * print.c (strout): Remove parameter `multibyte', unused since
3424 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3425
3426 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3427 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3428 All callers changed.
3429
3430 * w32.c (_wsa_errlist): Use braces for struct initializers.
3431
3432 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3433 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3434 All callers changed.
3435 (string_buffer_position): Likewise. Also, make static (it's never
3436 used outside xdisp.c).
3437 (cursor_row_p): Remove parameter `w', unused since
3438 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3439 (decode_mode_spec): Remove parameter `precision', introduced during
3440 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3441 All callers changed.
3442
3443 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3444
3445 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3446
3447 2011-03-27 Anders Lindgren <andlind@gmail.com>
3448
3449 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3450 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3451 (ns_update_auto_hide_menu_bar): New functions.
3452 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3453 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3454 ns_constrain_all_frames.
3455 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3456 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3457
3458 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3459
3460 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3461
3462 2011-03-27 Glenn Morris <rgm@gnu.org>
3463
3464 * syssignal.h: Replace RETSIGTYPE with void.
3465 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3466 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3467 Replace SIGTYPE with void everywhere.
3468 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3469 * s/template.h (SIGTYPE): Remove commented out definition.
3470
3471 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3472
3473 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3474 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3475
3476 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3477
3478 * w32.c (read_unc_volume): Use parameter `henum', instead of
3479 global variable `wget_enum_handle'.
3480
3481 * keymap.c (describe_vector): Remove parameters `indices' and
3482 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3483 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3484
3485 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3486
3487 * keyboard.c (timer_check): Remove parameter `do_it_now',
3488 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3489 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3490 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3491
3492 * keyboard.c (read_char):
3493 * w32menu.c (w32_menu_display_help):
3494 * xmenu.c (show_help_event, menu_help_callback):
3495 Adjust calls to `show_help_echo'.
3496
3497 * gtkutil.c (xg_maybe_add_timer):
3498 * keyboard.c (readable_events):
3499 * process.c (wait_reading_process_output):
3500 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3501
3502 * insdel.c (adjust_markers_gap_motion):
3503 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3504 (gap_left, gap_right): Don't call it.
3505
3506 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3507
3508 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3509 incurred during fontification.
3510
3511 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3512
3513 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3514 (DEFVAR_PER_BUFFER): Don't pass it.
3515
3516 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3517 (scrolling_window): Don't pass it.
3518
3519 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3520
3521 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3522
3523 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3524 and `suffix'.
3525 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3526 of variables specific to SELinux and computation of `encoded_absname'.
3527
3528 * image.c (XPutPixel): Remove unused variable `height'.
3529
3530 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3531
3532 * unexw32.c (get_section_info): Remove unused variable `section'.
3533
3534 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3535 (system_process_attributes): Remove unused variable `sess'.
3536 (sys_read): Remove unused variable `err'.
3537
3538 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3539 (w32_wnd_proc): Remove unused variable `isdead'.
3540 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3541 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3542 (x_create_tip_frame): Remove unused variable `tem'.
3543
3544 * w32inevt.c (w32_console_read_socket):
3545 Remove unused variable `no_events'.
3546
3547 * w32term.c (x_draw_composite_glyph_string_foreground):
3548 Remove unused variable `width'.
3549
3550 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3551
3552 * w32term.c (x_set_glyph_string_clipping):
3553 Don't pass uninitialized region to CombineRgn.
3554
3555 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3556
3557 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3558 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3559 (Fx_close_connection): Remove unused variable `i'.
3560
3561 * w32font.c (w32font_draw): Return number of glyphs.
3562 (w32font_open_internal): Remove unused variable `i'.
3563 (w32font_driver): Add missing initializer.
3564
3565 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3566 (fill_in_menu): Remove unused variable `items_added'.
3567
3568 * w32term.c (last_mouse_press_frame): Remove static global variable.
3569 (w32_clip_to_row): Remove unused variable `f'.
3570 (x_delete_terminal): Remove unused variable `i'.
3571
3572 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3573 (NOTHING): Remove unused static global variable.
3574 (uniscribe_check_otf): Remove unused variable `table'.
3575 (uniscribe_font_driver): Add missing initializers.
3576
3577 2011-03-23 Julien Danjou <julien@danjou.info>
3578
3579 * term.c (Fsuspend_tty, Fresume_tty):
3580 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3581 * window.c (temp_output_buffer_show):
3582 * insdel.c (signal_before_change):
3583 * frame.c (Fhandle_switch_frame):
3584 * fileio.c (Fdo_auto_save):
3585 * emacs.c (Fkill_emacs):
3586 * editfns.c (save_excursion_restore):
3587 * cmds.c (internal_self_insert):
3588 * callint.c (Fcall_interactively):
3589 * buffer.c (Fkill_all_local_variables):
3590 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3591 Use Frun_hooks.
3592 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3593 unconditionnaly since it does the check itself.
3594
3595 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 Fix more problems found by GCC 4.5.2's static checks.
3598
3599 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3600 the first time through the loop, since we know p0 < p1 then.
3601 This also avoids a gcc -Wstrict-overflow warning.
3602
3603 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3604 leading to a memory leak, possible in functions like
3605 load_charset_map_from_file that can allocate an unbounded number
3606 of objects (Bug#8318).
3607
3608 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3609 that could (at least in theory) be that large.
3610
3611 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3612 This is less likely to overflow, and avoids undefined behavior if
3613 overflow does occur. All callers changed. Use strtoul to scan
3614 for the unsigned long integer.
3615 (pint2hrstr): Simplify and tune code slightly.
3616 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3617
3618 * scroll.c (do_scrolling): Work around GCC bug 48228.
3619 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3620
3621 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3622 This also avoids a warning with gcc -Wstrict-overflow.
3623 (validate_x_resource_name): Simplify count usage.
3624 This also avoids a warning with gcc -Wstrict-overflow.
3625
3626 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3627 fail (Bug#8306).
3628
3629 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3630
3631 * process.c (Fmake_network_process): Use socklen_t, not int,
3632 where POSIX says socklen_t is required in portable programs.
3633 This fixes a porting bug on hosts like 64-bit HP-UX, where
3634 socklen_t is wider than int (Bug#8277).
3635 (Fmake_network_process, server_accept_connection):
3636 (wait_reading_process_output, read_process_output):
3637 Likewise.
3638
3639 * process.c: Rename or move locals to avoid shadowing.
3640 (list_processes_1, Fmake_network_process):
3641 (read_process_output_error_handler, exec_sentinel_error_handler):
3642 Rename or move locals.
3643 (Fmake_network_process): Define label "retry_connect" only if needed.
3644 (Fnetwork_interface_info): Fix pointer signedness.
3645 (process_send_signal): Add cast to avoid pointer signedness problem.
3646 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3647 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3648
3649 Make tparam.h and terminfo.c consistent.
3650 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3651 Include tparam.h instead, since it declares them.
3652 * cm.h (PC): Remove extern decl; tparam.h now does this.
3653 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3654 * terminfo.c: Include tparam.h, to check interfaces.
3655 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3656 (tparam): Adjust signature to match interface in tparam.h;
3657 this removes some undefined behavior. Check that outstring and len
3658 are zero, which they always are with Emacs.
3659 * tparam.h (PC, BC, UP): New extern decls.
3660
3661 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3662 (xftfont_open): Rename locals to avoid shadowing.
3663
3664 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3665 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3666 (OTF_TAG_SYM): Omit macro if not needed.
3667 (ftfont_list): Remove unused local.
3668 (get_adstyle_property, ftfont_pattern_entity):
3669 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3670 Rename locals to avoid shadowing.
3671
3672 * xfont.c (xfont_list_family): Mark var as initialized.
3673
3674 * xml.c (make_dom): Now static.
3675
3676 * composite.c (composition_compute_stop_pos): Rename local to
3677 avoid shadowing.
3678 (composition_reseat_it): Remove unused locals.
3679 (find_automatic_composition, composition_adjust_point): Likewise.
3680 (composition_update_it): Mark var as initialized.
3681 (find_automatic_composition): Mark vars as initialized,
3682 with a FIXME (Bug#8290).
3683
3684 character.h: Rename locals to avoid shadowing.
3685 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3686 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3687 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3688 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3689 to avoid shadowing.
3690
3691 * textprop.c (property_change_between_p): Remove; unused.
3692
3693 * intervals.c (interval_start_pos): Now static.
3694
3695 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3696
3697 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3698 Rename locals to avoid shadowing.
3699
3700 * sound.c (wav_play, au_play, Fplay_sound_internal):
3701 Fix pointer signedness.
3702 (alsa_choose_format): Remove unused local var.
3703 (wav_play): Initialize a variable to 0, to prevent undefined
3704 behavior (Bug#8278).
3705
3706 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3707
3708 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3709
3710 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3711 clobbering (Bug#8298).
3712 * sysdep.c (sys_subshell): Likewise.
3713 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3714
3715 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3716 This should get cleaned up, so that child_setup has the
3717 same signature on all platforms.
3718
3719 * callproc.c (call_process_cleanup): Now static.
3720 (relocate_fd): Rename locals to avoid shadowing.
3721
3722 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3723
3724 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3725 not to be necessary, and produces flickering.
3726
3727 2011-03-20 Glenn Morris <rgm@gnu.org>
3728
3729 * config.in: Remove file.
3730
3731 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3732
3733 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3734 are now in src/globals.h.
3735 (syms_of_minibuf): Remove spurious & from previous change.
3736
3737 2011-03-20 Leo <sdl.web@gmail.com>
3738
3739 * minibuf.c (completing-read-function): New variable.
3740 (completing-read-default): Rename from completing-read.
3741 (completing-read): Call completing-read-function.
3742
3743 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3744
3745 * xfaces.c (Fx_load_color_file):
3746 Read color file from absolute filename (bug#8250).
3747
3748 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3749
3750 * makefile.w32-in: Update dependencies.
3751
3752 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3753
3754 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3755
3756 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3757
3758 Fix more problems found by GCC 4.5.2's static checks.
3759
3760 * process.c (make_serial_process_unwind, send_process_trap):
3761 (sigchld_handler): Now static.
3762
3763 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3764 That way, the code declares only the vars that it needs.
3765 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3766 * s/cygwin.h (PTY_ITERATION): Likewise.
3767 * s/darwin.h (PTY_ITERATION): Likewise.
3768 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3769
3770 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3771 * process.c (allocate_pty): Don't declare stb unless it's needed.
3772
3773 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3774 (CONSTANTLIM): Remove; unused.
3775 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3776 Define only if needed.
3777
3778 * unexelf.c (unexec): Name an expression,
3779 to avoid gcc -Wbad-function-cast warning.
3780 Use a different way to cause a compilation error if anyone uses
3781 n rather than nn, a way that does not involve shadowing.
3782 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3783
3784 * deps.mk (unexalpha.o): Remove; unused.
3785
3786 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3787 * unexec.h: New file.
3788 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3789 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3790 Depend on unexec.h.
3791 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3792 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3793 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3794 Change as necessary to match prototype in unexec.h.
3795
3796 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3797 shadowing.
3798 (back_comment, skip_chars): Mark vars as initialized.
3799
3800 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3801 Rename locals to avoid shadowing.
3802
3803 * lread.c (read1): Rewrite so as not to use empty "else".
3804 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3805
3806 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3807
3808 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3809 warning when compiling print.c.
3810
3811 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3812 instead of using an uninitialized var.
3813 (font_sort_entities): Mark var as initialized.
3814
3815 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3816
3817 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3818 pointers to constants.
3819 (font_parse_fcname): Remove unused vars.
3820 (font_delete_unmatched): Now static.
3821 (font_get_spec): Remove; unused.
3822 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3823 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3824 Rename or move locals to avoid shadowing.
3825
3826 * fns.c (require_nesting_list, require_unwind): Now static.
3827 (Ffillarray): Rename locals to avoid shadowing.
3828
3829 * floatfns.c (domain_error2): Define only if needed.
3830 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3831
3832 * alloc.c (mark_backtrace): Move decl from here ...
3833 * lisp.h: ... to here, so that it can be checked.
3834
3835 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3836 (Fdefvar): Rewrite so as not to use empty "else".
3837 (lisp_indirect_variable): Name an expression,
3838 to avoid gcc -Wbad-function-cast warning.
3839 (Fdefvar): Rename locals to avoid shadowing.
3840
3841 * callint.c (quotify_arg, quotify_args): Now static.
3842 (Fcall_interactively): Rename locals to avoid shadowing.
3843 Use const pointer when appropriate.
3844
3845 * lisp.h (get_system_name, get_operating_system_release):
3846 Move decls here, to check interfaces.
3847 * process.c (get_operating_system_release): Move decl to lisp.h.
3848 * xrdb.c (get_system_name): Likewise.
3849 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3850 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3851 some of which prompt warnings from gcc -Wbad-function-cast.
3852 (Fformat_time_string, Fencode_time, Finsert_char):
3853 (Ftranslate_region_internal, Fformat):
3854 Rename or remove local vars to avoid shadowing.
3855 (Ftranslate_region_internal): Mark var as initialized.
3856
3857 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3858 avoid shadowing.
3859
3860 * lisp.h (eassert): Check that the argument compiles, even if
3861 ENABLE_CHECKING is not defined.
3862
3863 * data.c (Findirect_variable): Name an expression, to avoid
3864 gcc -Wbad-function-cast warning.
3865 (default_value, arithcompare, arith_driver, arith_error): Now static.
3866 (store_symval_forwarding): Rename local to avoid shadowing.
3867 (Fmake_variable_buffer_local, Fmake_local_variable):
3868 Mark variables as initialized.
3869 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3870
3871 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3872 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3873 Rename locals to avoid shadowing.
3874 (mark_stack): Move local variables into the #ifdef region where
3875 they're used.
3876 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3877 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3878 needed otherwise.
3879 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3880 (GC_STRING_CHARS): Remove; not used.
3881 (Fmemory_limit): Cast sbrk's returned value to char *.
3882
3883 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3884 avoids undefined behavior in theory.
3885
3886 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3887
3888 Use functions, not macros, for up- and down-casing (Bug#8254).
3889 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3890 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3891 to use the following functions instead of these macros.
3892 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3893 EMACS_INT, since callers assume the returned value fits in int.
3894 (upcase1): Likewise, for UPCASE_TABLE.
3895 (uppercasep, lowercasep, upcase): New static inline functions.
3896 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3897 the race-condition problem in the old DOWNCASE.
3898
3899 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3900 Rename locals to avoid shadowing.
3901 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3902 (regex_compile, re_search_2, re_match_2_internal):
3903 Remove unused local vars.
3904 (FREE_VAR): Rewrite so as not to use empty "else",
3905 which gcc can warn about.
3906 (regex_compile, re_match_2_internal): Mark locals as initialized.
3907 (RETALLOC_IF): Define only if needed.
3908 (WORDCHAR_P): Likewise. This one is never needed, but is used
3909 only in a comment talking about a compiler bug, so put inside
3910 the #if 0 of that comment.
3911 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3912 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3913 Remove; unused.
3914
3915 * search.c (boyer_moore): Rename locals to avoid shadowing.
3916 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3917 (PREV_CHAR_BOUNDARY): Likewise.
3918
3919 * search.c (simple_search): Remove unused var.
3920
3921 * dired.c (compile_pattern): Move decl from here ...
3922 * lisp.h: ... to here, so that it can be checked.
3923 (struct re_registers): New forward decl.
3924
3925 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3926
3927 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3928 All uses changed.
3929 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3930 Rename locals to avoid shadowing.
3931 (Fvertical_motion): Mark locals as initialized.
3932
3933 * casefiddle.c (casify_object, casify_region): Now static.
3934 (casify_region): Mark local as initialized.
3935
3936 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3937
3938 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3939 New macros, so that the caller can use some names other than
3940 gcpro1, gcpro2, etc.
3941 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3942 of the new macros.
3943 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3944 argument, for consistency with GCPRO2_VAR, etc: it is now the
3945 prefix of the variable, not the variable itself. All uses
3946 changed.
3947 * dired.c (directory_files_internal, file_name_completion):
3948 Rename locals to avoid shadowing.
3949
3950 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3951 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3952 dired.c's scmp function, had undefined behavior.
3953 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3954 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3955 * buffer.h: ... to here, because these macros use current_buffer,
3956 and the new implementation with inline functions needs to have
3957 current_buffer in scope now, rather than later when the macros
3958 are used.
3959 (downcase, upcase1): New static inline functions.
3960 (DOWNCASE, UPCASE1): Reimplement using these functions.
3961 This avoids undefined behavior in expressions like
3962 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3963 from race conditions in accessing the global variables
3964 case_temp1 and case_temp2.
3965 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3966 * lisp.h (case_temp1, case_temp2): Remove their decls.
3967 * character.h (ASCII_CHAR_P): Move from here ...
3968 * lisp.h: ... to here, so that the inline functions mentioned
3969 above can use them.
3970
3971 * dired.c (directory_files_internal_unwind): Now static.
3972
3973 * fileio.c (file_name_as_directory, directory_file_name):
3974 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3975 Now static.
3976 (file_name_as_directory): Use const pointers when appropriate.
3977 (Fexpand_file_name): Likewise. In particular, newdir might
3978 point at constant storage, so make it a const pointer.
3979 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3980 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3981 signedness issues.
3982 (Fset_file_times, Finsert_file_contents, auto_save_error):
3983 Rename locals to avoid shadowing.
3984
3985 * minibuf.c (choose_minibuf_frame_1): Now static.
3986 (Ftry_completion, Fall_completions): Rename or remove locals
3987 to avoid shadowing.
3988
3989 * marker.c (bytepos_to_charpos): Remove; unused.
3990
3991 * lisp.h (verify_bytepos, count_markers): New decls,
3992 so that gcc does not warn that these functions aren't declared.
3993
3994 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3995 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3996 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3997 (copy_text): Remove unused local var.
3998
3999 * filelock.c (within_one_second): Now static.
4000 (lock_file_1): Rename local to avoid shadowing.
4001
4002 * buffer.c (fix_overlays_before): Mark locals as initialized.
4003 (fix_start_end_in_overlays): Likewise. This function should be
4004 simplified by using pointers-to-pointers, but that's a different
4005 matter.
4006 (switch_to_buffer_1): Now static.
4007 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4008 (report_overlay_modification): Rename locals to avoid shadowing.
4009
4010 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4011 Fix pointer signedness issue.
4012 (sys_subshell): Mark local as volatile if checking for lint,
4013 to suppress a gcc -Wclobbered warning that does not seem to be right.
4014 (MAXPATHLEN): Define only if needed.
4015
4016 * process.c (serial_open, serial_configure): Move decls from here ...
4017 * systty.h: ... to here, so that they can be checked.
4018
4019 * fns.c (get_random, seed_random): Move extern decls from here ...
4020 * lisp.h: ... to here, so that they can be checked.
4021
4022 * sysdep.c (reset_io): Now static.
4023 (wait_for_termination_signal): Remove; unused.
4024
4025 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4026 (copy_keymap_item, append_key, push_text_char_description):
4027 Now static.
4028 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4029 (DENSE_TABLE_SIZE): Remove; unused.
4030 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4031 (describe_map_tree):
4032 Rename locals to avoid shadowing.
4033
4034 * keyboard.c: Declare functions static if they are not used elsewhere.
4035 (echo_char, echo_dash, cmd_error, top_level_2):
4036 (poll_for_input, handle_async_input): Now static.
4037 (read_char, kbd_buffer_get_event, make_lispy_position):
4038 (make_lispy_event, make_lispy_movement, apply_modifiers):
4039 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4040 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4041 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4042 (read_key_sequence, read_char): Mark locals as initialized.
4043 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4044
4045 * keyboard.h (make_ctrl_char): New decl.
4046 (mark_kboards): Move decl here ...
4047 * alloc.c (mark_kboards): ... from here.
4048
4049 * lisp.h (force_auto_save_soon): New decl.
4050
4051 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4052 (DEFINE_DUMMY_FUNCTION): New macro.
4053 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4054 Use it.
4055 (main): Add casts to avoid warnings
4056 if GCC considers string literals to be constants.
4057
4058 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4059
4060 * dbusbind.c: Pointer signedness fixes.
4061 (xd_signature, xd_append_arg, xd_initialize):
4062 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4063 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4064 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4065 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4066
4067 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4068 if GCC considers string literals to be constants.
4069 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4070
4071 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4072
4073 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4074 (print_preprocess, print_object): New macro to fix last change.
4075
4076 * print.c (print_preprocess): Don't forget font objects.
4077
4078 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4079
4080 * emacs.c (USAGE3): Doc fixes.
4081
4082 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4083
4084 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4085 structure.
4086
4087 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4088
4089 * lisp.h (VWindow_system, Qfile_name_history):
4090 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4091 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4092 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4093
4094 * w32select.c: Don't #include "keyboard.h".
4095 (run_protected): Add extern declaration for waiting_for_input.
4096
4097 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4098 * w32console.c (detect_input_pending, read_input_pending)
4099 (encode_terminal_code):
4100 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4101 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4102 (w32_system_caret_y, Qfile_name_history):
4103 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4104 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4105 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4106 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4107 * w32proc.c (Qlocal, report_file_error):
4108 * w32term.c (Vwindow_system, updating_frame):
4109 * w32uniscribe.c (initialized, uniscribe_font_driver):
4110 Remove unneeded extern declarations.
4111
4112 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4113
4114 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4115
4116 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4117
4118 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4119 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4120 These macros can no longer be used for assignment.
4121
4122 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4123 Assign struct members directly, instead of using BUF_BEGV etc.
4124 (record_buffer_markers, fetch_buffer_markers): New functions for
4125 recording and fetching special buffer markers.
4126 (set_buffer_internal_1, set_buffer_temp): Use them.
4127
4128 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4129
4130 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4131
4132 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4133 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4134
4135 * xdisp.c (hscroll_window_tree):
4136 (reconsider_clip_changes): Use PT instead of BUF_PT.
4137
4138 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4139
4140 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4141 $(EMACS_ROOT)/lib/intprops.h.
4142
4143 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4144
4145 Fix more problems found by GCC 4.5.2's static checks.
4146
4147 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4148 to unsigned char * to avoid compiler diagnostic.
4149 (xg_free_frame_widgets): Make it clear that a local variable is
4150 needed only if USE_GTK_TOOLTIP.
4151 (gdk_window_get_screen): Make it clear that this macro is needed
4152 only if USE_GTK_TOOLTIP.
4153 (int_gtk_range_get_value): New function, which avoids a diagnostic
4154 from gcc -Wbad-function-cast.
4155 (xg_set_toolkit_scroll_bar_thumb): Use it.
4156 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4157 diagnostic from gcc -Wbad-function-cast.
4158 (get_utf8_string, xg_get_file_with_chooser):
4159 Rename locals to avoid shadowing.
4160 (create_dialog): Move locals to avoid shadowing.
4161
4162 * xgselect.c (xg_select): Remove unused var.
4163
4164 * image.c (four_corners_best): Mark locals as initialized.
4165 (gif_load): Initialize transparent_p to zero (Bug#8238).
4166 Mark another local as initialized.
4167 (my_png_error, my_error_exit): Mark with NO_RETURN.
4168
4169 * image.c (clear_image_cache): Now static.
4170 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4171 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4172 (x_edge_detection): Remove unnecessary cast that
4173 gcc -Wbad-function-cast diagnoses.
4174 (gif_load): Fix pointer signedness.
4175 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4176 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4177
4178 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4179
4180 Improve quality of tests for time stamp overflow.
4181 For example, without this patch (encode-time 0 0 0 1 1
4182 1152921504606846976) returns the obviously-bogus value (-948597
4183 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4184 reports time overflow. See
4185 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4186 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4187 * editfns.c: Include limits.h and intprops.h.
4188 (TIME_T_MIN, TIME_T_MAX): New macros.
4189 (time_overflow): Move earlier, to before first use.
4190 (hi_time, lo_time): New functions, for an accurate test for
4191 out-of-range times.
4192 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4193 (Fget_internal_run_time): Don't assume time_t fits in int.
4194 (make_time): Use list2 instead of Fcons twice.
4195 (Fdecode_time): More accurate test for out-of-range times.
4196 (check_tm_member): New function.
4197 (Fencode_time): Use it, to test for out-of-range times.
4198 (lisp_time_argument): Don't rely on undefined left-shift and
4199 right-shift behavior when checking for time stamp overflow.
4200
4201 * editfns.c (time_overflow): New function, refactoring common code.
4202 (Fformat_time_string, Fdecode_time, Fencode_time):
4203 (Fcurrent_time_string): Use it.
4204
4205 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4206 * dired.c (make_time): Move to ...
4207 * editfns.c (make_time): ... here.
4208 * systime.h: Note the move.
4209
4210 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4211
4212 * fringe.c (update_window_fringes): Remove unused variables.
4213
4214 * unexmacosx.c (copy_data_segment): Also copy __got section.
4215 (Bug#8223)
4216
4217 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4218
4219 * termcap.c [MSDOS]: Include "msdos.h".
4220 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4221 Constify `char *' arguments and their references according to
4222 prototypes in tparam.h.
4223
4224 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4225
4226 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4227 Adapt all references accordingly.
4228
4229 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4230
4231 2011-03-11 Tom Tromey <tromey@redhat.com>
4232
4233 * buffer.c (syms_of_buffer): Remove obsolete comment.
4234
4235 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4236
4237 * termhooks.h (encode_terminal_code): Declare prototype.
4238
4239 * msdos.c (encode_terminal_code): Don't declare prototype.
4240
4241 * term.c (encode_terminal_code): Now external again, used by
4242 w32console.c and msdos.c.
4243
4244 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4245 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4246
4247 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4248
4249 Fix some minor problems found by GCC 4.5.2's static checks.
4250
4251 * fringe.c (update_window_fringes): Mark locals as initialized
4252 (Bug#8227).
4253 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4254
4255 * alloc.c (mark_fringe_data): Move decl from here ...
4256 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4257 to check its interface.
4258 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4259
4260 * fontset.c (free_realized_fontset): Now static.
4261 (Fset_fontset_font): Rename local to avoid shadowing.
4262 (fontset_font): Mark local as initialized.
4263 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4264
4265 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4266
4267 * xselect.c (x_disown_buffer_selections): Remove; not used.
4268 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4269 (x_own_selection, Fx_disown_selection_internal): Rename locals
4270 to avoid shadowing.
4271 (x_handle_dnd_message): Remove local to avoid shadowing.
4272
4273 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4274 so that the caller can use some name other than gcpro1.
4275 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4276 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4277 (Fx_backspace_delete_keys_p):
4278 Use them to avoid shadowing, and rename vars to avoid shadowing.
4279 (x_decode_color, x_set_name, x_window): Now static.
4280 (Fx_create_frame): Add braces to silence GCC warning.
4281 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4282 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4283 Remove unused locals.
4284 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4285 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4286 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4287 macros.
4288
4289 * xterm.h (x_mouse_leave): New decl.
4290
4291 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4292 Remove unused functions.
4293 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4294 (x_calc_absolute_position): Now static.
4295 (XTread_socket): Don't define label "out" unless it's used.
4296 Don't declare local "event" unless it's used.
4297 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4298 unless they are used.
4299 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4300 (x_fatal_error_signal): Remove; not used.
4301 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4302 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4303 (x_error_catcher, x_connection_closed, x_error_handler):
4304 (x_error_quitter, xembed_send_message, x_iconify_frame):
4305 (my_log_handler): Rename locals to avoid shadowing.
4306 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4307 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4308
4309 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4310 Rename or move locals to avoid shadowing.
4311 (tty_defined_color, merge_face_heights): Now static.
4312 (free_realized_faces_for_fontset): Remove; not used.
4313 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4314 does not deduce is never used uninitialized.
4315 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4316 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4317
4318 * terminal.c (store_terminal_param): Now static.
4319
4320 * xmenu.c (menu_highlight_callback): Now static.
4321 (set_frame_menubar): Remove unused local.
4322 (xmenu_show): Rename parameter to avoid shadowing.
4323 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4324 since they might point to immutable storage.
4325 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4326 since it's unused otherwise.
4327
4328 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4329 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4330 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4331 avoids a gcc -Wuninitialized diagnostic.
4332 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4333 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4334 does not deduce are never used uninitialized.
4335
4336 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4337
4338 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4339 * window.c (window_loop, size_window):
4340 (run_window_configuration_change_hook, enlarge_window): Likewise.
4341
4342 * window.c (display_buffer): Now static.
4343 (size_window): Mark variables that gcc -Wuninitialized
4344 does not deduce are never used uninitialized.
4345 * window.h (check_all_windows): New decl, to forestall
4346 gcc -Wmissing-prototypes diagnostic.
4347 * dispextern.h (bidi_dump_cached_states): Likewise.
4348
4349 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4350 shadowing.
4351 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4352 Include <limits.h>.
4353 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4354 and to avoid gcc -Wuninitialized warning.
4355 (load_charset_map): Mark variables that gcc -Wuninitialized
4356 does not deduce are never used uninitialized.
4357 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4358
4359 * coding.c (coding_set_source, coding_set_destination):
4360 Use "else { /* comment */ }" rather than "else /* comment */;"
4361 for clarity, and to avoid gcc -Wempty-body warning.
4362 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4363 a block, when the outer 'i' will do.
4364 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4365 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4366 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4367 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4368 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4369 Rename locals to avoid shadowing.
4370 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4371 * coding.c (emacs_mule_char, encode_invocation_designation):
4372 Now static, since they're not used elsewhere.
4373 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4374 (decode_coding_object, encode_coding_object, detect_coding_system):
4375 (decode_coding_emacs_mule): Mark variables that gcc
4376 -Wuninitialized does not deduce are never used uninitialized.
4377 (detect_coding_iso_2022): Initialize a local variable that might
4378 be used uninitialized. Leave a FIXME because it's not clear that
4379 this initialization is needed. (Bug#8211)
4380 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4381 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4382 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4383 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4384 Remove unused macros.
4385
4386 * category.c (hash_get_category_set): Remove unused local var.
4387 (copy_category_table): Now static, since it's not used elsewhere.
4388 * character.c (string_count_byte8): Likewise.
4389
4390 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4391 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4392
4393 * chartab.c (copy_sub_char_table): Now static, since it's not used
4394 elsewhere.
4395 (sub_char_table_ref_and_range, char_table_ref_and_range):
4396 Rename locals to avoid shadowing.
4397 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4398
4399 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4400 (BIDI_BOB): Remove unused macro.
4401
4402 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4403 deduce are never used uninitialized.
4404 * term.c (encode_terminal_code): Likewise.
4405
4406 * term.c (encode_terminal_code): Now static. Remove unused local.
4407
4408 * tparam.h: New file.
4409 * term.c, tparam.h: Include it.
4410 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4411 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4412 Move these decls to tparam.h, and make them agree with what
4413 is actually in tparam.c. The previous trick of using incompatible
4414 decls in different modules does not conform to the C standard.
4415 All callers of tparam changed to use tparam's actual API.
4416 * tparam.c (tparam1, tparam, tgoto):
4417 Use const pointers where appropriate.
4418
4419 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4420 * cm.h (struct cm): Likewise.
4421 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4422 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4423 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4424 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4425 (turn_on_face, init_tty): Likewise.
4426 * termchar.h (struct tty_display_info): Likewise.
4427
4428 * term.c (term_mouse_position): Rename local to avoid shadowing.
4429
4430 * alloc.c (mark_ttys): Move decl from here ...
4431 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4432
4433 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4434
4435 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4436
4437 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4438
4439 * search.c (compile_pattern_1): Remove argument regp, unused since
4440 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4441 (compile_pattern): Don't pass it.
4442
4443 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4444
4445 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4446 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4447 for ! HAVE_GTK3.
4448 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4449
4450 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4451
4452 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4453 gdk_window_get_screen, gdk_window_get_geometry,
4454 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4455 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4456 (xg_get_pixbuf_from_pixmap): New function.
4457 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4458 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4459 Call xg_get_pixbuf_from_pixmap instead of
4460 gdk_pixbuf_get_from_drawable.
4461 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4462 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4463 (xg_check_special_colors): Use GtkStyleContext and its functions
4464 for HAVE_GTK3.
4465 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4466 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4467 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4468 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4469 Call gtk_widget_get_preferred_size.
4470 (xg_frame_resized): gdk_window_get_geometry only takes 5
4471 parameters.
4472 (xg_win_to_widget, xg_event_is_for_menubar):
4473 Call gdk_x11_window_lookup_for_display.
4474 (xg_set_widget_bg): New function.
4475 (delete_cb): New function.
4476 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4477 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4478 (xg_set_background_color): Call xg_set_widget_bg.
4479 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4480 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4481 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4482 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4483 if ! HAVE_GTK3.
4484 (update_frame_tool_bar): Call gtk_widget_hide.
4485 (xg_initialize): Use GDK_KEY_g.
4486
4487 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4488 if ! HAVE_GTK3
4489 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4490
4491 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4492 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4493 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4494
4495 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4496
4497 * w32xfns.c (select_palette): Check success of RealizePalette against
4498 GDI_ERROR, not zero.
4499
4500 See ChangeLog.11 for earlier changes.
4501
4502 ;; Local Variables:
4503 ;; coding: utf-8
4504 ;; End:
4505
4506 Copyright (C) 2011 Free Software Foundation, Inc.
4507
4508 This file is part of GNU Emacs.
4509
4510 GNU Emacs is free software: you can redistribute it and/or modify
4511 it under the terms of the GNU General Public License as published by
4512 the Free Software Foundation, either version 3 of the License, or
4513 (at your option) any later version.
4514
4515 GNU Emacs is distributed in the hope that it will be useful,
4516 but WITHOUT ANY WARRANTY; without even the implied warranty of
4517 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4518 GNU General Public License for more details.
4519
4520 You should have received a copy of the GNU General Public License
4521 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.