Fix image fg and bg colors on NS (Bug#9175).
[bpt/emacs.git] / src / ChangeLog
1 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2
3 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4 setting frame foreground color (Bug#9175).
5 (x_set_background_color): Likewise.
6
7 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8
9 Implement strike-through and overline on NextStep (Bug#8863).
10
11 * nsfont.m (nsfont_open): Use underline position provided by font,
12 instead of hard-coded value of 2.
13 (nsfont_draw): Call ns_draw_text_decoration instead.
14
15 * nsterm.h: Add declaration for ns_draw_text_decoration.
16
17 * nsterm.m (ns_draw_text_decoration): New function for drawing
18 underline, overline, and strike-through.
19 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
20 ns_draw_text_decoration. Change treatment of cursor drawing to
21 accomodate underlining, etc.
22
23 2011-07-28 Eli Zaretskii <eliz@gnu.org>
24
25 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
26 default.
27
28 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
29
30 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
31 Without this fix, if a signal arrives just after memory fills up,
32 'malloc' might be invoked reentrantly.
33
34 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
35 In other words, assume that every image size is allowed, on non-X
36 hosts. This assumption is probably wrong, but it lets Emacs compile.
37
38 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
39
40 * regex.c (re_iswctype): Convert return values to boolean.
41
42 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
43
44 * xdisp.c (compute_display_string_pos): Don't use cached display
45 string position if the buffer had its restriction changed.
46 (Bug#9184)
47
48 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
49
50 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
51
52 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
53
54 Integer signedness and overflow and related fixes. (Bug#9079)
55
56 * bidi.c: Integer size and overflow fixes.
57 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
58 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
59 (bidi_cache_find_level_change, bidi_cache_ensure_space)
60 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
61 (bidi_find_other_level_edge):
62 Use ptrdiff_t instead of EMACS_INT where either will do.
63 This works better on 32-bit hosts configured --with-wide-int.
64 (bidi_cache_ensure_space): Check for size-calculation overflow.
65 Use % rather than repeated addition, for better worst-case speed.
66 Don't set bidi_cache_size until after xrealloc returns, because it
67 might not return.
68 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
69 (bidi_cache_ensure_space): Also check that the bidi cache size
70 does not exceed that of the largest Lisp string or buffer. See Eli
71 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
72
73 * alloc.c (__malloc_size_t): Remove.
74 All uses replaced by size_t. See Andreas Schwab's note
75 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
76
77 * image.c: Improve checking for integer overflow.
78 (check_image_size): Assume that f is nonnull, since
79 it is always nonnull in practice. This is one less thing to
80 worry about when checking for integer overflow later.
81 (x_check_image_size): New function, which checks for integer
82 overflow issues inside X.
83 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
84 This removes the need for a memory_full check.
85 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
86 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
87 (xbm_read_bitmap_data): Change locals back to 'int', since
88 their values must fit in 'int'.
89 (xpm_load_image, png_load, tiff_load):
90 Invoke x_create_x_image_and_pixmap earlier,
91 to avoid much needless work if the image is too large.
92 (tiff_load): Treat overly large images as if
93 x_create_x_image_and_pixmap failed, not as malloc failures.
94 (gs_load): Use x_check_image_size.
95
96 * gtkutil.c: Omit integer casts.
97 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
98 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
99
100 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
101
102 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
103 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
104 would wrongly return t on a 64-bit host.
105
106 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
107 The plain *_OVERFLOW macros run afoul of GCC bug 49705
108 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
109 and therefore cause GCC to emit a bogus diagnostic in some cases.
110
111 * image.c: Integer signedness and overflow and related fixes.
112 This is not an exhaustive set of fixes, but it's time to
113 record what I've got.
114 (lookup_pixel_color, check_image_size): Remove redundant decls.
115 (check_image_size): Don't assume that arbitrary EMACS_INT values
116 fit in 'int', or that arbitrary 'double' values fit in 'int'.
117 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
118 (tiff_load, imagemagick_load_image):
119 Check for overflow in size calculations.
120 (x_create_x_image_and_pixmap): Remove unnecessary test for
121 xmalloc returning NULL; that can't happen.
122 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
123 (xpm_color_bucket): Use better integer hashing function.
124 (xpm_cache_color): Don't possibly over-allocate memory.
125 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
126 (gif_memory_source):
127 Use ptrdiff_t, not int or size_t, to record sizes.
128 (png_load): Don't assume values greater than 2**31 fit in 'int'.
129 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
130 either works, as we prefer signed integers.
131 (tiff_read_from_memory, tiff_write_from_memory):
132 Return tsize_t, not size_t, since that's what the TIFF API wants.
133 (tiff_read_from_memory): Don't fail simply because the read would
134 go past EOF; instead, return a short read.
135 (tiff_load): Omit no-longer-needed casts.
136 (Fimagemagick_types): Don't assume size fits into 'int'.
137
138 Improve hashing quality when configured --with-wide-int.
139 * fns.c (hash_string): New function, taken from sxhash_string.
140 Do not discard information about ASCII character case; this
141 discarding is no longer needed.
142 (sxhash-string): Use it. Change sig to match it. Caller changed.
143 * lisp.h: Declare it.
144 * lread.c (hash_string): Remove, since we now use fns.c's version.
145 The fns.c version returns a wider integer if --with-wide-int is
146 specified, so this should help the quality of the hashing a bit.
147
148 * emacs.c: Integer overflow minor fix.
149 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
150 Define only if GNU_LINUX.
151 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
152
153 * dispnew.c: Integer signedness and overflow fixes.
154 Remove unnecessary forward decls, that were a maintenance hassle.
155 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
156 All uses changed.
157 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
158 (scrolling_window): Use ptrdiff_t, not int, for byte count.
159 (prepare_desired_row, line_draw_cost):
160 Use int, not unsigned, where either works.
161 (save_current_matrix, restore_current_matrix):
162 Use ptrdiff_t, not size_t, where either works.
163 (init_display): Check for overflow more accurately, and without
164 relying on undefined behavior.
165
166 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
167 Remove, replacing with the new symbols in lisp.h. All uses changed.
168 * fileio.c (make_temp_name):
169 * filelock.c (lock_file_1, lock_file):
170 * xdisp.c (message_dolog):
171 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
172 Use pMd etc. instead.
173 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
174 replacing the pWIDE etc. symbols removed from editfns.c.
175
176 * keyboard.h (num_input_events): Now uintmax_t.
177 This is (very slightly) less likely to mess up due to wraparound.
178 All uses changed.
179
180 * buffer.c: Integer signedness fixes.
181 (alloc_buffer_text, enlarge_buffer_text):
182 Use ptrdiff_t rather than size_t when either will do, as we prefer
183 signed integers.
184
185 * alloc.c: Integer signedness and overflow fixes.
186 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
187 (__malloc_size_t): Default to size_t, not to int.
188 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
189 (Fgarbage_collect, mark_object_loop_halt, mark_object):
190 Prefer ptrdiff_t to size_t when either would do, as we prefer
191 signed integers.
192 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
193 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
194 Now const. Initialize with values that are in range even if char
195 is signed.
196 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
197 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
198 These functions do the right thing with sizes > 2**32.
199 (check_depth): Now ptrdiff_t, not int.
200 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
201 Adjust to new way of storing sizes. Check for size overflow bugs
202 in rest of code.
203 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
204 slightly wrong anyway, as it missed one instance of
205 XMALLOC_OVERRUN_CHECK_OVERHEAD.
206 (refill_memory_reserve): Omit needless cast to size_t.
207 (mark_object_loop_halt): Mark as externally visible.
208
209 * xselect.c: Integer signedness and overflow fixes.
210 (Fx_register_dnd_atom, x_handle_dnd_message):
211 Use ptrdiff_t, not size_t, since we prefer signed.
212 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
213 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
214 x_dnd_atoms_size and x_dnd_atoms_length.
215
216 * doprnt.c: Prefer signed to unsigned when either works.
217 * eval.c (verror):
218 * doprnt.c (doprnt):
219 * lisp.h (doprnt):
220 * xdisp.c (vmessage):
221 Use ptrdiff_t, not size_t, when using or implementing doprnt,
222 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
223 prefer signed arithmetic to avoid comparison confusion.
224 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
225 but is a bit tricky.
226
227 Assume freestanding C89 headers, string.h, stdlib.h.
228 * data.c, doprnt.c, floatfns.c, print.c:
229 Include float.h unconditionally.
230 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
231 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
232 * regex.c: Likewise for stddef.h, string.h.
233 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
234 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
235 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
236 (STDC_HEADERS): Remove obsolete defines.
237 * sysdep.c: Include limits.h unconditionally.
238
239 Assume support for memcmp, memcpy, memmove, memset.
240 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
241 * regex.c (memcmp, memcpy):
242 Remove; we assume C89 now.
243
244 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
245 (__malloc_safe_bcopy): Remove; no longer needed.
246
247 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
248 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
249 well either way, and we prefer signed to unsigned.
250
251 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
252
253 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
254 closes the connection while we're reading (bug#9182).
255
256 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
257
258 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
259 are specified (Bug#9168).
260
261 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
262
263 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
264 Found by GCC static checking and --with-wide-int on a 32-bit host.
265
266 2011-07-25 Eli Zaretskii <eliz@gnu.org>
267
268 * xdisp.c (compute_display_string_pos): Fix logic of caching
269 previous display string position. Initialize cached_prev_pos to
270 -1. Fixes slow-down at the beginning of a buffer.
271
272 2011-07-24 Eli Zaretskii <eliz@gnu.org>
273
274 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
275 for attrs[LFACE_FONTSET_INDEX].
276
277 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
278
279 * xml.c (parse_region): Remove unused local
280 that was recently introduced.
281
282 2011-07-23 Eli Zaretskii <eliz@gnu.org>
283
284 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
285 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
286
287 * xdisp.c (move_it_in_display_line_to): Record the best matching
288 position for TO_CHARPOS while scanning the line, and restore it on
289 exit if none of the characters scanned was an exact match. Fixes
290 vertical-motion and pos-visible-in-window-p under bidi redisplay
291 when exact match is impossible due to invisible text, and the
292 lines are truncated.
293
294 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
295
296 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
297 for OSX >= 10.7.
298
299 2011-07-22 Eli Zaretskii <eliz@gnu.org>
300
301 Fix a significant slow-down of cursor motion with C-n, C-p,
302 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
303 auto-repeat under bidi redisplay in fontified buffers.
304 * xdisp.c (compute_stop_pos_backwards): New function.
305 (next_element_from_buffer): Call compute_stop_pos_backwards to
306 find a suitable prev_stop when we find ourselves before
307 base_level_stop.
308 (reseat): Don't look for prev_stop, as that could mean a very long
309 run.
310 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
311 <cached_disp_overlay_modiff>: Cache for last found display string
312 position.
313 (compute_display_string_pos): Return the cached position if asked
314 about the same buffer in the same area of character positions, and
315 the buffer wasn't changed since the time the display string
316 position was cached.
317
318 2011-07-22 Eli Zaretskii <eliz@gnu.org>
319
320 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
321 is an integer, which is important for empty lines. (Bug#9149)
322
323 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
324
325 * frame.c (Fmodify_frame_parameters): In tty case, update the
326 default face if necessary (Bug#4238).
327
328 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
329
330 * editfns.c (Fstring_to_char): No need to explain what a character
331 is in the docstring (Bug#6576).
332
333 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
334
335 * xml.c (parse_region): Make sure we always return a tree.
336
337 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
338
339 * xml.c (parse_region): If a document contains only comments,
340 return that, too.
341
342 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
343
344 * xml.c (make_dom): Return comments, too.
345
346 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
347
348 Port to OpenBSD.
349 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
350 and the surrounding thread.
351 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
352 rather than fgets, and retry after EINTR. Otherwise, 'emacs
353 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
354 timer goes off.
355 * s/openbsd.h (BROKEN_SIGIO): Define.
356 * unexelf.c (unexec) [__OpenBSD__]:
357 Don't update the .mdebug section of the Alpha COFF symbol table.
358
359 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
360
361 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
362 (bug#8460).
363
364 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
365
366 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
367 This fixes some race conditions on the permissions of any newly
368 created file.
369
370 * alloc.c (valid_pointer_p): Use pipe, not open.
371 This fixes some permissions issues when debugging.
372
373 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
374 If fchown fails to set both uid and gid, try to set just gid,
375 as that is sometimes allowed. Adjust the file's mode to eliminate
376 setuid or setgid bits that are inappropriate if fchown fails.
377
378 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
379
380 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
381 to compare Lisp_Objects.
382 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
383 global_gnutls_log_level, don't mistake it for a Lisp_Object.
384 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
385
386 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
387
388 * lread.c (read_integer): Unread even EOF character.
389 (read1): Likewise. Properly record start position of symbol.
390
391 * lread.c (read1): Read `#:' as empty uninterned symbol if no
392 symbol character follows.
393
394 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
395
396 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
397 This works around a problem with the previous change to Fcopy_file.
398 Recent glibc declares fchown with __attribute__((warn_unused_result)),
399 and without this change, GCC might complain about discarding
400 fchown's return value.
401
402 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
403
404 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
405
406 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
407
408 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
409
410 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
411
412 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
413 it's used from the C level.
414
415 * process.c: Use the same condition for POLL_FOR_INPUT in both
416 keyboard.c and process.c (bug#1858).
417
418 2011-07-09 Lawrence Mitchell <wence@gmx.li>
419
420 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
421 (Fgnutls_boot): Use it.
422
423 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
424
425 * doc.c (Fsubstitute_command_keys): Revert last change.
426
427 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
428
429 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
430 quotes the next character, and doesn't affect other longer
431 sequences (bug#8935).
432
433 * lread.c (syms_of_lread): Clarify that is isn't only
434 `eval-buffer' and `eval-defun' that's affected by
435 `lexical-binding' (bug#8460).
436
437 2011-07-15 Eli Zaretskii <eliz@gnu.org>
438
439 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
440 bidi redisplay when a line includes both an image and is
441 truncated.
442
443 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
444
445 Fix minor problems found by static checking.
446 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
447 (elsz): Now a signed constant, not a size_t var. We prefer signed
448 types to unsigned, to avoid integer comparison confusion. Without
449 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
450 "cannot optimize loop, the loop counter may overflow", a symptom
451 of the confusion.
452 * indent.c (Fvertical_motion): Mark locals as initialized.
453 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
454
455 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
456
457 * search.c (Fre_search_backward): Mention `case-fold-search' in
458 all the re_search_* functions (bug#8138).
459
460 * keyboard.c (Fopen_dribble_file): Document when the file is
461 closed (bug#8056).
462
463 2011-07-14 Eli Zaretskii <eliz@gnu.org>
464
465 * bidi.c (bidi_dump_cached_states): Fix format of displaying
466 bidi_cache_idx.
467
468 Support bidi reordering of display and overlay strings.
469 * xdisp.c (compute_display_string_pos)
470 (compute_display_string_end): Accept additional argument STRING.
471 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
472 (reseat_to_string): Initialize bidi_it->string.s and
473 bidi_it->string.schars.
474 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
475 NULL (avoids a crash in bidi_paragraph_init). Initialize
476 itb.string.lstring.
477 (init_iterator): Call bidi_init_it only of a valid
478 buffer position was specified. Initialize paragraph_embedding to
479 L2R.
480 (reseat_to_string): Initialize the bidi iterator.
481 (display_string): If we need to ignore text properties of
482 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
483 original value of -1 will not work with bidi.)
484 (compute_display_string_pos): First arg is now struct
485 `text_pos *'; all callers changed. Support display properties on
486 Lisp strings.
487 (compute_display_string_end): Support display properties on Lisp
488 strings.
489 (init_iterator, reseat_1, reseat_to_string): Initialize the
490 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
491 when iterating on a string not from display properties).
492 (compute_display_string_pos, compute_display_string_end): Fix
493 calculation of the object to scan. Fixes an error when using
494 arrow keys.
495 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
496 base_level_stop; instead, set base_level_stop to BEGV. Fixes
497 crashes in vertical-motion.
498 (next_element_from_buffer): Improve commentary for when
499 the iterator is before prev_stop.
500 (init_iterator): Initialize bidi_p from the default value of
501 bidi-display-reordering, not from buffer-local value. Use the
502 buffer-local value only if initializing for buffer iteration.
503 (handle_invisible_prop): Support invisible properties on strings
504 that are being bidi-reordered.
505 (set_iterator_to_next): Support bidi reordering of C strings and
506 Lisp strings.
507 (next_element_from_string): Support bidi reordering of Lisp
508 strings.
509 (handle_stop_backwards): Support Lisp strings as well.
510 (display_string): Support display of R2L glyph rows. Use
511 IT_STRING_CHARPOS when displaying from a Lisp string.
512 (init_iterator): Don't initialize it->bidi_p for strings
513 here.
514 (reseat_to_string): Initialize it->bidi_p for strings here.
515 (next_element_from_string, next_element_from_c_string)
516 (next_element_from_buffer): Add xassert's for correspondence
517 between IT's object being iterated and it->bidi_it.string
518 structure.
519 (face_before_or_after_it_pos): Support bidi iteration.
520 (next_element_from_c_string): Handle the case of the first string
521 character that is not the first one in the visual order.
522 (get_visually_first_element): New function, refactored from common
523 parts of next_element_from_buffer, next_element_from_string, and
524 next_element_from_c_string.
525 (tool_bar_lines_needed, redisplay_tool_bar)
526 (display_menu_bar): Force left-to-right direction. Add a FIXME
527 comment for making that be controlled by a user option.
528 (push_it, pop_it): Save and restore the state of the
529 bidi iterator. Save and restore the bidi_p flag.
530 (pop_it): Iterate out of display property for string iteration as
531 well.
532 (iterate_out_of_display_property): Support iteration over strings.
533 (handle_single_display_spec): Set up it->bidi_it for iteration
534 over a display string, and call bidi_init_it.
535 (handle_single_display_spec, next_overlay_string)
536 (get_overlay_strings_1, push_display_prop): Set up the bidi
537 iterator for displaying display or overlay strings.
538 (forward_to_next_line_start): Don't use the shortcut if
539 bidi-iterating.
540 (back_to_previous_visible_line_start): If handle_display_prop
541 pushed the iterator stack, restore the internal state of the bidi
542 iterator by calling bidi_pop_it same number of times.
543 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
544 and we are bidi-iterating, don't decrement the iterator position;
545 instead, set the first_elt flag in the bidi iterator, to produce
546 the same effect.
547 (reseat_1): Remove redundant setting of string_from_display_prop_p.
548 (push_display_prop): xassert that we are iterating a buffer.
549 (push_it, pop_it): Save and restore paragraph_embedding member.
550 (handle_single_display_spec, next_overlay_string)
551 (get_overlay_strings_1, reseat_1, reseat_to_string)
552 (push_display_prop): Set up the `unibyte' member of bidi_it.string
553 correctly. Don't assume unibyte strings are not bidi-reordered.
554 (compute_display_string_pos)
555 (compute_display_string_end): Fix handling the case of C string.
556 (push_it, pop_it): Save and restore from_disp_prop_p.
557 (handle_single_display_spec, push_display_prop): Set the
558 from_disp_prop_p flag.
559 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
560 (pop_it): Call iterate_out_of_display_property only if we are
561 popping after iteration over a string that came from a display
562 property. Fix a typo in popping stretch info. Add an assertion
563 for verifying that the iterator position is in sync with the bidi
564 iterator.
565 (handle_single_display_spec, get_overlay_strings_1)
566 (push_display_prop): Fix initialization of paragraph direction for
567 string when that of the parent object is not yet determined.
568 (reseat_1): Call bidi_init_it to resync the bidi
569 iterator with IT's position. (Bug#7616)
570 (find_row_edges): If ROW->start.pos gives position
571 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
572 (handle_stop, back_to_previous_visible_line_start, reseat_1):
573 Reset the from_disp_prop_p flag.
574 (SAVE_IT, RESTORE_IT): New macros.
575 (pos_visible_p, face_before_or_after_it_pos)
576 (back_to_previous_visible_line_start)
577 (move_it_in_display_line_to, move_it_in_display_line)
578 (move_it_to, move_it_vertically_backward, move_it_by_lines)
579 (try_scrolling, redisplay_window, display_line): Use them when
580 saving a temporary copy of the iterator and restoring it back.
581 (back_to_previous_visible_line_start, reseat_1)
582 (init_iterator): Empty the bidi cache "stack".
583 (move_it_in_display_line_to): If iterator ended up at
584 EOL, but we never saw any buffer positions smaller than
585 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
586 motion in bidi-reordered lines.
587 (move_it_in_display_line_to): Record prev_method and prev_pos
588 immediately before the call to set_iterator_to_next. Fixes cursor
589 motion in bidi-reordered lines with stretch glyphs and strings
590 displayed in margins. (Bug#8133) (Bug#8867)
591 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
592 TO_CHARPOS.
593 (pos_visible_p): Support positions in bidi-reordered lines. Save
594 and restore bidi cache.
595
596 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
597 (bidi_paragraph_info): Delete unused struct.
598 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
599 (bidi_cache_start): New variable.
600 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
601 to zero.
602 (bidi_cache_fetch_state, bidi_cache_search)
603 (bidi_cache_find_level_change, bidi_cache_iterator_state)
604 (bidi_cache_find, bidi_peek_at_next_level)
605 (bidi_level_of_next_char, bidi_find_other_level_edge)
606 (bidi_move_to_visually_next): Compare cache index with
607 bidi_cache_start rather than with zero.
608 (bidi_fetch_char): Accept new argument STRING; all callers
609 changed. Support iteration over a string. Support strings with
610 display properties. Support unibyte strings. Fix the type of
611 `len' according to what STRING_CHAR_AND_LENGTH expects.
612 (bidi_paragraph_init, bidi_resolve_explicit_1)
613 (bidi_resolve_explicit, bidi_resolve_weak)
614 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
615 iteration over a string.
616 (bidi_set_sor_type, bidi_resolve_explicit_1)
617 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
618 can now be zero (for strings); special values 0 and -1 were
619 changed to -1 and -2, respectively.
620 (bidi_char_at_pos): New function.
621 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
622 Call it instead of FETCH_MULTIBYTE_CHAR.
623 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
624 initialized to valid values.
625 (bidi_init_it): Don't initialize charpos and bytepos with invalid
626 values.
627 (bidi_level_of_next_char): Allow the sentinel "position" to pass
628 the test for valid cached positions. Fix the logic for looking up
629 the sentinel state in the cache. GCPRO the Lisp string we are
630 iterating.
631 (bidi_push_it, bidi_pop_it): New functions.
632 (bidi_initialize): Initialize the bidi cache start stack pointer.
633 (bidi_cache_ensure_space): New function, refactored from part of
634 bidi_cache_iterator_state. Don't assume the required size is just
635 one BIDI_CACHE_CHUNK away.
636 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
637 (bidi_count_bytes, bidi_char_at_pos): New functions.
638 (bidi_cache_search): Don't assume bidi_cache_last_idx is
639 always valid if bidi_cache_idx is valid.
640 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
641 is valid if it's going to be used.
642 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
643 (bidi_cache_fetch_state, bidi_cache_search)
644 (bidi_cache_find_level_change, bidi_cache_ensure_space)
645 (bidi_cache_iterator_state, bidi_cache_find)
646 (bidi_find_other_level_edge, bidi_cache_start_stack): All
647 variables related to cache indices are now EMACS_INT.
648
649 * dispextern.h (struct bidi_string_data): New structure.
650 (struct bidi_it): New member `string'. Make flag members be 1-bit
651 fields, and put them last in the struct.
652 (compute_display_string_pos, compute_display_string_end): Update
653 prototypes.
654 (bidi_push_it, bidi_pop_it): Add prototypes.
655 (struct iterator_stack_entry): New members bidi_p,
656 paragraph_embedding, and from_disp_prop_p.
657 (struct it): Member bidi_p is now a bit field 1 bit wide.
658 (bidi_shelve_cache, bidi_unshelve_cache): Declare
659 prototypes.
660
661 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
662 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
663 and vector-like objects.
664
665 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
666 cache around display iteration.
667
668 * window.c (Fwindow_end, window_scroll_pixel_based)
669 (displayed_window_lines, Frecenter): Save and restore the bidi
670 cache around display iteration.
671
672 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
673
674 * editfns.c (Fdelete_region): Clarify the use of the named
675 parameters (bug#6788).
676
677 2011-07-14 Martin Rudalics <rudalics@gmx.at>
678
679 * indent.c (Fvertical_motion): Set and restore w->pointm when
680 saving and restoring the window's buffer (Bug#9006).
681
682 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
683
684 * editfns.c (Fstring_to_char): Clarify just what is returned
685 (bug#6576). Text by Eli Zaretskii.
686
687 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
688
689 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
690
691 2011-07-13 Eli Zaretskii <eliz@gnu.org>
692
693 * buffer.c (mmap_find): Fix a typo.
694
695 2011-07-13 Johan Bockgård <bojohan@gnu.org>
696
697 Fix execution of x selection hooks.
698 * xselect.c (Qx_lost_selection_functions)
699 (Qx_sent_selection_functions): New vars.
700 (syms_of_xselect): DEFSYM them.
701 (x_handle_selection_request): Pass Qx_sent_selection_functions
702 rather than Vx_sent_selection_functions to Frun_hook_with_args.
703 (x_handle_selection_clear,x_clear_frame_selections):
704 Pass Qx_lost_selection_functions rather than
705 Vx_lost_selection_functions to Frun_hook_with_args.
706
707 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
708
709 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
710 The old code sometimes used this field without initializing it.
711
712 * alloc.c (gc_sweep): Don't read past end of array.
713 In theory, the old code could also have corrupted Emacs internals,
714 though it'd be very unlikely.
715
716 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
717
718 * character.c (Fcharacterp): Don't advertise optional ignored
719 argument. (Bug#4026)
720
721 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
722
723 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
724 key" (bug#4257).
725
726 * window.c (Fset_window_start): Doc fix (bug#4199).
727 (Fset_window_hscroll): Ditto.
728
729 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
730
731 Fix minor new problems caught by GCC 4.6.1.
732 * term.c (init_tty): Remove unused local.
733 * xsettings.c (store_monospaced_changed): Define this function only
734 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
735 not used otherwise.
736
737 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
738
739 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
740
741 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
742
743 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
744 are the mini-buffer and the echo area (bug#3320).
745
746 * term.c (init_tty): Remove support for supdup, c10 and perq
747 terminals, which are no longer supported (bug#1482).
748
749 2011-07-10 Johan Bockgård <bojohan@gnu.org>
750
751 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
752
753 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
754
755 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
756 for non-popups (Bug#3642).
757
758 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
759
760 * alloc.c (reset_malloc_hooks): Protoize.
761 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
762 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
763 * cm.c (losecursor): Likewise.
764 * data.c (fmod): Likewise.
765 * dispnew.c (swap_glyphs_in_rows): Likewise.
766 * emacs.c (memory_warning_signal): Likewise.
767 * floatfns.c (float_error): Likewise.
768 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
769 (otf_open, font_otf_capability, generate_otf_features)
770 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
771 Likewise.
772 * image.c (pbm_read_file): Likewise.
773 * indent.c (string_display_width): Likewise.
774 * intervals.c (check_for_interval, search_for_interval)
775 (inc_interval_count, count_intervals, root_interval)
776 (adjust_intervals_for_insertion, make_new_interval): Likewise.
777 * lread.c (defalias): Likewise.
778 * ralloc.c (r_alloc_check): Likewise.
779 * regex.c (set_image_of_range_1, set_image_of_range)
780 (regex_grow_registers): Likewise.
781 * sysdep.c (strerror): Likewise.
782 * termcap.c (valid_filename_p, tprint, main): Likewise.
783 * tparam.c (main): Likewise.
784 * unexhp9k800.c (run_time_remap, save_data_space)
785 (update_file_ptrs, read_header, write_header, calculate_checksum)
786 (copy_file, copy_rest, display_header): Likewise.
787 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
788 Likewise.
789 * xdisp.c (check_it): Likewise.
790 * xfaces.c (register_color, unregister_color, unregister_colors):
791 Likewise.
792 * xfns.c (print_fontset_result): Likewise.
793 * xrdb.c (member, fatal, main): Likewise.
794
795 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
796
797 Fix minor problems found by static checking (Bug#9031).
798 * chartab.c (char_table_set_range, map_sub_char_table):
799 Remove unused locals.
800 (uniprop_table): Now static.
801 * composite.c (_work_char): Remove unused static var.
802
803 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
804
805 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
806
807 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
808
809 * gtkutil.c (qttip_cb): Remove code without function.
810
811 2011-07-09 Eli Zaretskii <eliz@gnu.org>
812
813 * w32.c (pthread_sigmask): New stub.
814
815 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
816
817 Use pthread_sigmask, not sigprocmask (Bug#9010).
818 sigprocmask is portable only for single-threaded applications, and
819 Emacs can be multi-threaded when it uses GTK.
820 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
821 (LIBES): Use it.
822 * callproc.c (Fcall_process):
823 * process.c (create_process):
824 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
825 Use pthread_sigmask, not sigprocmask.
826
827 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
828
829 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
830 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
831 wrong (Bug#8591).
832
833 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
834
835 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
836 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
837 (xg_hide_tooltip): Fix comment.
838
839 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
840 in registerServicesMenuSendTypes.
841 (validRequestorForSendType): Don't check ns_return_types.
842
843 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
844 ns_return_type.
845
846 2011-07-08 Jason Rumney <jasonr@gnu.org>
847
848 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
849 frame struct members of non-existent frames (Bug#6284).
850
851 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
852
853 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
854 variable firstTime not needed on OSX >= 10.6.
855 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
856 >= 10.5. Use setKnobProportion, setDoubleValue.
857
858 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
859 (MAC_OS_X_VERSION_10_5): Define if not defined.
860 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
861 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
862 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
863
864 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
865 cString and lossyCString on OSX >= 10.4
866
867 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
868 sizeToFit on OSX >= 10.2.
869
870 * nsimage.m (allocInitFromFile): Don't use deprecated method
871 bestRepresentationForDevice on OSX >= 10.6.
872
873 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
874 to avoid warning.
875
876 * emacs.c: Declare unexec_init_emacs_zone.
877
878 * nsgui.h: Fix compiler warning about gnulib redefining verify.
879
880 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
881
882 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
883 on svcsMenu (Bug#8842).
884
885 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
886 ns_return_types.
887 (Fns_list_services): Just return Qnil on 10.6, code not working there.
888
889 * nsterm.m (QUTF8_STRING): Declare.
890 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
891 (validRequestorForSendType): Return type is (id).
892 Change indexOfObjectIdenticalTo to indexOfObject.
893 Check if we have local selection before returning self (Bug#8842).
894 (writeSelectionToPasteboard): Put local selection into paste board
895 if we have a local selection (Bug#8842).
896 (syms_of_nsterm): DEFSYM QUTF8_STRING.
897
898 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
899 (ns_get_local_selection): Declare.
900
901 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
902
903 * keymap.c (describe_map_tree): Don't insert a double newline at
904 the end of the buffer (bug#1169) and return whether we inserted
905 something.
906
907 * callint.c (Fcall_interactively): Change "reading args" to
908 "providing args" to try to clarify what it does (bug#1010).
909
910 2011-07-07 Kenichi Handa <handa@m17n.org>
911
912 * composite.c (composition_compute_stop_pos): Ignore a static
913 composition starting before CHARPOS (Bug#8915).
914
915 * xdisp.c (handle_composition_prop): Likewise.
916
917 2011-07-07 Eli Zaretskii <eliz@gnu.org>
918
919 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
920 (Bug#9015)
921
922 2011-07-07 Kenichi Handa <handa@m17n.org>
923
924 * character.h (unicode_category_t): New enum type.
925
926 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
927 (Qchar_code_property_table): New variable.
928 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
929 (UNIPROP_COMPRESSED_FORM_P): New macros.
930 (char_table_ascii): Uncompress the compressed values.
931 (sub_char_table_ref): New arg is_uniprop. Callers changed.
932 Uncompress the compressed values.
933 (sub_char_table_ref_and_range): Likewise.
934 (char_table_ref_and_range): Uncompress the compressed values.
935 (sub_char_table_set): New arg is_uniprop. Callers changed.
936 Uncompress the compressed values.
937 (sub_char_table_set_range): Args changed. Callers changed.
938 (char_table_set_range): Adjuted for the above change.
939 (map_sub_char_table): Delete args default_val and parent. Add arg
940 top. Give decoded values to a Lisp function.
941 (map_char_table): Adjusted for the above change. Give decoded
942 values to a Lisp function. Gcpro more variables.
943 (uniprop_table_uncompress)
944 (uniprop_decode_value_run_length): New functions.
945 (uniprop_decoder, uniprop_decoder_count): New variables.
946 (uniprop_get_decoder, uniprop_encode_value_character)
947 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
948 New functions.
949 (uniprop_encoder, uniprop_encoder_count): New variables.
950 (uniprop_get_encoder, uniprop_table)
951 (Funicode_property_table_internal, Fget_unicode_property_internal)
952 (Fput_unicode_property_internal): New functions.
953 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
954 Sunicode_property_table_internal, Sget_unicode_property_internal,
955 and Sput_unicode_property_internal. Defvar_lisp
956 char-code-property-alist.
957
958 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
959 Vunicode_category_table.
960
961 * font.c (font_range): Adjusted for the change of
962 Vunicode_category_table.
963
964 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
965
966 * m/iris4d.h: Remove file, move contents ...
967 * s/irix6-5.h: ... here.
968
969 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
970
971 Remove unportable assumption about struct layout (Bug#8884).
972 * alloc.c (mark_buffer):
973 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
974 (clone_per_buffer_values): Don't assume that
975 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
976 This isn't true in general, and it's particularly not true
977 if Emacs is configured with --with-wide-int.
978 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
979 New macros, used in the buffer.c change.
980
981 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
982
983 * xsettings.c: Use both GConf and GSettings if both are available.
984 (store_config_changed_event): Add comment.
985 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
986 (store_tool_bar_style_changed): New functions.
987 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
988 (struct xsettings): Move font inside HAVE_XFT.
989 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
990 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
991 Move inside HAVE_XFT.
992 (something_changed_gsettingsCB): Renamed from something_changedCB.
993 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
994 also.
995 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
996 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
997 (something_changed_gconfCB): Renamed from something_changedCB.
998 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
999 (parse_settings): Move check for font inside HAVE_XFT.
1000 (read_settings, apply_xft_settings): Add comment.
1001 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1002 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1003 call store_font_name_changed.
1004 (xft_settings_event): Add comment.
1005 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1006 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1007 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1008 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1009 (xsettings_initialize): Call init_gsettings last.
1010 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1011 comment.
1012
1013 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 Random fixes. E.g., (random) never returned negative values.
1016 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1017 subseconds part to the entropy, as that's a bit more random.
1018 Prefer signed to unsigned, since the signedness doesn't matter and
1019 in general we prefer signed. When given a limit, use a
1020 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1021 latter isn't right if USE_2_TAGS_FOR_INTS.
1022 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1023 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1024
1025 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1026
1027 * textprop.c (text_property_stickiness):
1028 Obey Vtext_property_default_nonsticky.
1029 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1030 * w32fns.c (syms_of_w32fns):
1031 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1032
1033 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1036 This is more efficient than Ffile_directory_p and avoids a minor race.
1037
1038 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1039
1040 * buffer.c (Foverlay_put): Say what the return value is
1041 (bug#7835).
1042
1043 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1044 is a directory before asking whether to use the file name
1045 (bug#7564).
1046 (barf_or_query_if_file_exists): Make the "File is a directory"
1047 error be more correct.
1048
1049 * fns.c (Frequire): Remove the mention of the .gz files, since
1050 that's installation-specific, but keep the mention of
1051 `get-load-suffixes'.
1052
1053 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1056 Report string overflow if the output is too long.
1057
1058 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1059
1060 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1061 (syms_of_gnutls): Remove duplicate DEFSYM for
1062 Qgnutls_bootprop_verify_hostname_error, an error for
1063 Qgnutls_bootprop_verify_error (which is no longer used).
1064
1065 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1066 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1067 Also (re)move comments that are misplaced or no longer relevant.
1068
1069 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1070
1071 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1072
1073 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1074
1075 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1076 and background color parameters if they have been changed.
1077
1078 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1079
1080 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1081
1082 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 * xsettings.c (SYSTEM_FONT): Define only when used.
1085 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1086
1087 * keymap.c (access_keymap_1): Now static.
1088
1089 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1090
1091 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1092 leave any prefix arg for the up event (Bug#1586).
1093
1094 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1095
1096 * lread.c (syms_of_lread): Mention single symbols defined by
1097 `defvar' or `defconst' (bug#7154).
1098
1099 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1100 (Frequire): Mention get-load-suffixes.
1101
1102 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1103
1104 * window.h (window): Remove clone_number slot.
1105 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1106 Remove.
1107 (make_parent_window, make_window, saved_window)
1108 (Fset_window_configuration, save_window_save): Don't deal with
1109 clone numbers.
1110 * buffer.c (Qclone_number): Remove declaration.
1111 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1112
1113 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1114
1115 Add multiple inheritance to keymaps.
1116 * keymap.c (Fmake_composed_keymap): New function.
1117 (Fset_keymap_parent): Simplify.
1118 (fix_submap_inheritance): Remove.
1119 (access_keymap_1): New function extracted from access_keymap to handle
1120 embedded parents and handle lists of maps.
1121 (access_keymap): Use it.
1122 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1123 (Fcopy_keymap): Handle embedded parents.
1124 (Fcommand_remapping, define_as_prefix): Simplify.
1125 (Fkey_binding): Simplify.
1126 (syms_of_keymap): Move minibuffer-local-completion-map,
1127 minibuffer-local-filename-completion-map,
1128 minibuffer-local-must-match-map, and
1129 minibuffer-local-filename-must-match-map to Elisp.
1130 (syms_of_keymap): Defsubr make-composed-keymap.
1131 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1132 (parse_menu_item): Trivial simplification.
1133
1134 2011-07-01 Glenn Morris <rgm@gnu.org>
1135
1136 * Makefile.in (SETTINGS_LIBS): Fix typo.
1137
1138 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1139
1140 * coding.c (Fencode_coding_string): Record the last coding system
1141 used, as the function doc string says (bug#8738).
1142
1143 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1144
1145 * xsettings.c (store_monospaced_changed): Take new font as arg and
1146 check for change against current_mono_font.
1147 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1148 (emacs_settings_constructor, emacs_settings_get_property)
1149 (emacs_settings_set_property, emacs_settings_class_init)
1150 (emacs_settings_init, gsettings_obj): Remove.
1151 (something_changedCB): New function for HAVE_GSETTINGS.
1152 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1153 with value as argument.
1154 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1155 g_settings_new (Bug#8967). Do not create gsettings_obj.
1156 Remove calls to g_settings_bind. Connect something_changedCB to
1157 "changed".
1158
1159 * xgselect.c: Add defined (HAVE_GSETTINGS).
1160 (xgselect_initialize): Ditto.
1161
1162 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1163 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1164 xg_select.
1165
1166 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1167
1168 * eval.c (struct backtrace): Simplify and port the data structure.
1169 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1170 signed bit field, as this assumption is not portable and it makes
1171 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1172 "char debug_on_exit : 1" as this is not portable either; instead,
1173 use the portable "unsigned int debug_on_exit : 1". Remove unused
1174 member evalargs. Remove obsolete comments about cc bombing out.
1175
1176 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1177
1178 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1179 Let HAVE_GSETTINGS override HAVE_GCONF.
1180 (store_monospaced_changed): New function.
1181 (EMACS_SETTINGS): A new type derived from GObject to handle
1182 GSettings notifications.
1183 (emacs_settings_constructor, emacs_settings_get_property)
1184 (emacs_settings_set_property, emacs_settings_class_init):
1185 New functions.
1186 (gsettings_client, gsettings_obj): New variables.
1187 (GSETTINGS_SCHEMA): New define.
1188 (something_changedCB): Call store_monospaced_changed.
1189 (init_gsettings): New function.
1190 (xsettings_initialize): Call init_gsettings.
1191 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1192 to NULL.
1193
1194 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1195 GCONF_CFLAGS/LIBS.
1196
1197 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1198
1199 * window.c (resize_root_window, grow_mini_window)
1200 (shrink_mini_window): Rename Qresize_root_window to
1201 Qwindow_resize_root_window and Qresize_root_window_vertically to
1202 Qwindow_resize_root_window_vertically.
1203
1204 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1205
1206 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1207
1208 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1209
1210 * makefile.w32-in: Redesign dependencies so they reflect more
1211 clearly which files are directly included by each source file,
1212 and not through other includes.
1213
1214 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1215
1216 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1217 (sort_overlays, overlay_strings): When an overlay's clone number
1218 matches the window's clone number process the overlay even if
1219 the overlay's window property doesn't match the current window.
1220
1221 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1222 (Fwindow_hchild): Rename to Fwindow_left_child.
1223 (Fwindow_next): Rename to Fwindow_next_sibling.
1224 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1225 (resize_window_check): Rename to window_resize_check.
1226 (resize_window_apply): Rename to window_resize_apply.
1227 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1228 (Fdelete_other_windows_internal, resize_frame_windows)
1229 (Fsplit_window_internal, Fdelete_window_internal)
1230 (grow_mini_window, shrink_mini_window)
1231 (Fresize_mini_window_internal): Fix callers accordingly.
1232
1233 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1234
1235 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1236 (emacs_fixed_set_min_size): Remove.
1237 (emacs_fixed_new): Take frame as argument.
1238
1239 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1240 (_EmacsFixedPrivate): Remove minwidth/height.
1241 Add struct frame *f.
1242 (emacs_fixed_init): Initialize priv->f.
1243 (get_parent_class, emacs_fixed_set_min_size): Remove.
1244 (emacs_fixed_new): Set priv->f to argument.
1245 (emacs_fixed_get_preferred_width)
1246 (emacs_fixed_get_preferred_height): Use min_width/height from
1247 frames size_hint to set minimum and natural (Bug#8919).
1248 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1249 and use min_width/height from frames size_hint to set
1250 min_width/height (Bug#8919).
1251
1252 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1253 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1254 Fix indentation.
1255
1256 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1257
1258 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1259 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1260 called at ZV.
1261
1262 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1263
1264 * process.c (wait_reading_process_output): Bypass select if
1265 waiting for a cell while ignoring keyboard input, and input is
1266 pending. Suggested by Jan Djärv (Bug#8869).
1267
1268 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1269
1270 Use gnulib's dup2 module instead of rolling our own.
1271 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1272
1273 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1274
1275 * dispnew.c (scrolling_window): Before scrolling, turn off a
1276 mouse-highlight in the window being scrolled.
1277
1278 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1279
1280 Move DEFSYM to lisp.h and use everywhere.
1281
1282 * character.h (DEFSYM): Move declaration...
1283 * lisp.h (DEFSYM): ...here.
1284
1285 * gnutls.c:
1286 * minibuf.c:
1287 * w32menu.c:
1288 * w32proc.c:
1289 * w32select.c: Don't include character.h.
1290
1291 * alloc.c (syms_of_alloc):
1292 * buffer.c (syms_of_buffer):
1293 * bytecode.c (syms_of_bytecode):
1294 * callint.c (syms_of_callint):
1295 * casefiddle.c (syms_of_casefiddle):
1296 * casetab.c (init_casetab_once):
1297 * category.c (init_category_once, syms_of_category):
1298 * ccl.c (syms_of_ccl):
1299 * cmds.c (syms_of_cmds):
1300 * composite.c (syms_of_composite):
1301 * dbusbind.c (syms_of_dbusbind):
1302 * dired.c (syms_of_dired):
1303 * dispnew.c (syms_of_display):
1304 * doc.c (syms_of_doc):
1305 * editfns.c (syms_of_editfns):
1306 * emacs.c (syms_of_emacs):
1307 * eval.c (syms_of_eval):
1308 * fileio.c (syms_of_fileio):
1309 * fns.c (syms_of_fns):
1310 * frame.c (syms_of_frame):
1311 * fringe.c (syms_of_fringe):
1312 * insdel.c (syms_of_insdel):
1313 * keymap.c (syms_of_keymap):
1314 * lread.c (init_obarray, syms_of_lread):
1315 * macros.c (syms_of_macros):
1316 * msdos.c (syms_of_msdos):
1317 * print.c (syms_of_print):
1318 * process.c (syms_of_process):
1319 * search.c (syms_of_search):
1320 * sound.c (syms_of_sound):
1321 * syntax.c (init_syntax_once, syms_of_syntax):
1322 * terminal.c (syms_of_terminal):
1323 * textprop.c (syms_of_textprop):
1324 * undo.c (syms_of_undo):
1325 * w32.c (globals_of_w32):
1326 * window.c (syms_of_window):
1327 * xdisp.c (syms_of_xdisp):
1328 * xfaces.c (syms_of_xfaces):
1329 * xfns.c (syms_of_xfns):
1330 * xmenu.c (syms_of_xmenu):
1331 * xsettings.c (syms_of_xsettings):
1332 * xterm.c (syms_of_xterm): Use DEFSYM.
1333
1334 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1335
1336 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1337
1338 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 Integer and buffer overflow fixes (Bug#8873).
1341
1342 * print.c (printchar, strout): Check for string overflow.
1343 (PRINTPREPARE, printchar, strout):
1344 Don't set size unless allocation succeeds.
1345
1346 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1347 for sizes. Check for string overflow more accurately.
1348 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1349
1350 * macros.c: Integer and buffer overflow fixes.
1351 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1352 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1353 Use ptrdiff_t, not int, for sizes.
1354 Don't increment bufsize until after realloc succeeds.
1355 Check for size-calculation overflow.
1356 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1357
1358 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1359
1360 * lread.c: Integer overflow fixes.
1361 (read_integer): Radix is now EMACS_INT, not int,
1362 to improve quality of diagnostics for out-of-range radices.
1363 Calculate buffer size correctly for out-of-range radices.
1364 (read1): Check for integer overflow in radices, and in
1365 read-circle numbers.
1366 (read_escape): Avoid int overflow.
1367 (Fload, openp, read_buffer_size, read1)
1368 (substitute_object_recurse, read_vector, read_list, map_obarray):
1369 Use ptrdiff_t, not int, for sizes.
1370 (read1): Use EMACS_INT, not int, for sizes.
1371 Check for size overflow.
1372
1373 * image.c (cache_image): Check for size arithmetic overflow.
1374
1375 * lread.c: Integer overflow issues.
1376 (saved_doc_string_size, saved_doc_string_length)
1377 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1378 Now ptrdiff_t, not int.
1379 (read1): Don't assume doc string length fits in int. Check for
1380 out-of-range doc string lengths.
1381 (read_list): Don't assume file position fits in int.
1382 (read_escape): Check for hex character overflow.
1383
1384 2011-06-22 Leo Liu <sdl.web@gmail.com>
1385
1386 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1387 Move to minibuffer.el.
1388
1389 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1390
1391 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1392 The following patches are for when GLYPH_DEBUG && !XASSERT.
1393 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1394 * dispnew.c (flush_stdout):
1395 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1396 Mark as externally visible.
1397 * dispnew.c (check_window_matrix_pointers): Now static.
1398 * dispnew.c (window_to_frame_vpos):
1399 * xfns.c (unwind_create_frame):
1400 * xterm.c (x_check_font): Remove unused local.
1401 * scroll.c (CHECK_BOUNDS):
1402 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1403 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1404 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1405 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1406 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1407 Now static.
1408 (debug_method_add): Use va_list and vsprintf rather than relying
1409 on undefined behavior with wrong number of arguments.
1410 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1411 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1412 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1413 since we're not interested in debugging glyphs with old libraries.
1414 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1415 GCC 4.6.0's static checking.
1416
1417 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1418
1419 Integer overflow and signedness fixes (Bug#8873).
1420 A few related buffer overrun fixes, too.
1421
1422 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1423
1424 * dispextern.h (struct face.stipple):
1425 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1426 (x_bitmap_mask, x_allocate_bitmap_record)
1427 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1428 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1429 (x_create_bitmap_from_xpm_data):
1430 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1431 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1432 (.bitmaps_last):
1433 * xfaces.c (load_pixmap):
1434 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1435 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1436 (.bitmaps_last, struct x_output.icon_bitmap):
1437 Use ptrdiff_t, not int, for bitmap indexes.
1438 (x_allocate_bitmap_record): Check for size overflow.
1439 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1440
1441 Use ptrdiff_t, not int, for overlay counts.
1442 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1443 * editfns.c (overlays_around, get_pos_property):
1444 * textprop.c (get_char_property_and_overlay):
1445 * xdisp.c (next_overlay_change, note_mouse_highlight):
1446 * xfaces.c (face_at_buffer_position):
1447 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1448 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1449 (Fnext_overlay_change, Fprevious_overlay_change)
1450 (mouse_face_overlay_overlaps, Foverlays_in):
1451 Use ptrdiff_t, not int, for sizes.
1452 (overlays_at, overlays_in): Check for size-calculation overflow.
1453
1454 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1455
1456 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1457 (x_session_initialize): Do not assume string length fits in int.
1458
1459 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1460 This is unlikely, but can occur if DPI is outlandish.
1461
1462 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1463 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1464
1465 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1466 * xrdb.c (magic_file_p, search_magic_path):
1467 Omit last arg SUFFIX; it was always 0. All callers changed.
1468 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1469
1470 * xfont.c (xfont_match): Avoid need for strlen.
1471
1472 * xfns.c: Don't assume strlen fits in int.
1473 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1474
1475 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1476 not unsigned long, as we prefer signed integers. All callers changed.
1477 Detect integer overflow in repeat count.
1478 (message_dolog): Don't assume print length fits in 39 bytes.
1479 (display_mode_element): Don't assume strlen fits in int.
1480
1481 * termcap.c: Don't assume sizes fit in int and never overflow.
1482 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1483 (gobble_line): Check for size-calculation overflow.
1484
1485 * minibuf.c (Fread_buffer):
1486 * lread.c (intern, intern_c_string):
1487 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1488 Don't assume string length fits in int.
1489
1490 * keyboard.c (parse_tool_bar_item):
1491 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1492
1493 * font.c: Don't assume string length fits in int.
1494 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1495 Use ptrdiff_t, not int.
1496 (font_intern_prop): Don't assume string length fits in int.
1497 Don't assume integer property fits in fixnum.
1498 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1499
1500 * filelock.c: Fix some buffer overrun and integer overflow issues.
1501 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1502 Reformulate so as not to need the command string.
1503 Invoke gzip -cd rather than gunzip, as it's more portable.
1504 (lock_info_type, lock_file_1, lock_file):
1505 Don't assume pid_t and time_t fit in unsigned long.
1506 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1507 (current_lock_owner): Prefer signed type for sizes.
1508 Use memcpy, not strncpy, where memcpy is what is really wanted.
1509 Don't assume (via atoi) that time_t and pid_t fit in int.
1510 Check for time_t and/or pid_t out of range, e.g., via a network share.
1511 Don't alloca where an auto var works fine.
1512
1513 * fileio.c: Fix some integer overflow issues.
1514 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1515 Don't assume string length fits in int.
1516 (directory_file_name): Don't assume string length fits in long.
1517 (make_temp_name): Don't assume pid fits in int, or that its print
1518 length is less than 20.
1519
1520 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1521
1522 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1523
1524 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1525
1526 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1527 We prefer signed integers, even for size calculations.
1528
1529 * emacs.c: Don't assume string length fits in 'int'.
1530 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1531 (main): Don't invoke strlen when not needed.
1532
1533 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1534 (XD_DEBUG_MESSAGE): Don't waste a byte.
1535
1536 * callproc.c (getenv_internal_1, getenv_internal)
1537 (Fgetenv_internal):
1538 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1539
1540 * lread.c (invalid_syntax): Omit length argument.
1541 All uses changed. This doesn't fix a bug, but it simplifies the
1542 code away from its former Hollerith-constant appearance, and it's
1543 one less 'int' to worry about when looking at integer-overflow issues.
1544 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1545
1546 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1547 This didn't break anything, but it didn't help either.
1548 It's confusing to put a bogus integer in a place where the actual
1549 value does not matter.
1550 (LIST_END_P): Remove unused macro and its bogus comment.
1551 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1552
1553 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1554 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1555 implementation.
1556 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1557 We prefer signed types, and the value cannot exceed the EMACS_INT
1558 range anyway (because otherwise the length would not be representable).
1559 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1560 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1561 This avoids a GCC warning when WIDE_EMACS_INT.
1562
1563 * indent.c (sane_tab_width): New function.
1564 (current_column, scan_for_column, Findent_to, position_indentation)
1565 (compute_motion): Use it. This is just for clarity.
1566 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1567
1568 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1569
1570 * lisp.h (lint_assume): New macro.
1571 * composite.c (composition_gstring_put_cache):
1572 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1573
1574 * editfns.c, insdel.c:
1575 Omit unnecessary forward decls, to simplify future changes.
1576
1577 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1578
1579 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1580
1581 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1582 Use much-faster test for byte-length change.
1583 Don't assume string byte-length fits in 'int'.
1584 Check that character arg fits in 'int'.
1585 (mapcar1): Declare byte as byte, for clarity.
1586
1587 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1588
1589 * fns.c (concat): Catch string overflow earlier.
1590 Do not rely on integer wraparound.
1591
1592 * dispextern.h (struct it.overlay_strings_charpos)
1593 (struct it.selective): Now EMACS_INT, not int.
1594 * xdisp.c (forward_to_next_line_start)
1595 (back_to_previous_visible_line_start)
1596 (reseat_at_next_visible_line_start, next_element_from_buffer):
1597 Don't arbitrarily truncate the value of 'selective' to int.
1598
1599 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1600
1601 * composite.c: Don't truncate sizes to 'int'.
1602 (composition_gstring_p, composition_reseat_it)
1603 (composition_adjust_point): Use EMACS_INT, not int.
1604 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1605 not EMACS_UINT, for indexes.
1606
1607 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1608
1609 * buffer.c: Include <verify.h>.
1610 (struct sortvec.priority, struct sortstr.priority):
1611 Now EMACS_INT, not int.
1612 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1613 (struct sortstr.size, record_overlay_string)
1614 (struct sortstrlist.size, struct sortlist.used):
1615 Don't truncate size to int.
1616 (record_overlay_string): Check for size-calculation overflow.
1617 (init_buffer_once): Check at compile-time, not run-time.
1618
1619 2011-06-22 Jim Meyering <meyering@redhat.com>
1620
1621 Don't leak an XBM-image-sized buffer
1622 * image.c (xbm_load): Free the image buffer after using it.
1623
1624 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1625
1626 Port to Sun C.
1627 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1628 that Sun C diagnosed.
1629 * fns.c (secure_hash): Fix pointer signedness issue.
1630 * intervals.c (static_offset_intervals): New function.
1631 (offset_intervals): Use it.
1632
1633 2011-06-21 Leo Liu <sdl.web@gmail.com>
1634
1635 * deps.mk (fns.o):
1636 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1637 sha512.h.
1638
1639 * fns.c (secure_hash): Rename from crypto_hash_function and change
1640 the first arg to accept symbols.
1641 (Fsecure_hash): New primitive.
1642 (syms_of_fns): New symbols.
1643
1644 2011-06-20 Deniz Dogan <deniz@dogan.se>
1645
1646 * process.c (Fset_process_buffer): Clarify return value in
1647 docstring.
1648
1649 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1650
1651 * dispnew.c (add_window_display_history): Use BVAR.
1652
1653 * xdisp.c (debug_method_add): Use BVAR.
1654 (check_window_end, dump_glyph_matrix, dump_glyph)
1655 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1656
1657 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1658 Likewise.
1659
1660 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1661 check till after the cache is created in init_frame_faces.
1662
1663 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1664
1665 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1666
1667 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1668
1669 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1670 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1671 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1672
1673 Improve buffer-overflow checking (Bug#8873).
1674 * fileio.c (Finsert_file_contents):
1675 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1676 Remove the old (too-loose) buffer overflow checks.
1677 They weren't needed, since make_gap checks for buffer overflow.
1678 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1679 The old code merely checked for Emacs fixnum overflow, and relied
1680 on undefined (wraparound) behavior. The new code avoids undefined
1681 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1682
1683 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1684 Tune. Don't use wider integers than needed. Don't use alloca.
1685 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1686
1687 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1688
1689 * insdel.c, lisp.h (buffer_overflow): New function.
1690 (insert_from_buffer_1, replace_range, replace_range_2):
1691 * insdel.c (make_gap_larger):
1692 * editfns.c (Finsert_char):
1693 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1694
1695 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1696
1697 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1698
1699 Integer overflow and signedness fixes (Bug#8873).
1700
1701 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1702 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1703
1704 * fileio.c: Don't assume EMACS_INT fits in off_t.
1705 (emacs_lseek): New static function.
1706 (Finsert_file_contents, Fwrite_region): Use it.
1707 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1708
1709 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1710
1711 * fns.c: Don't overflow int when computing a list length.
1712 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1713 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1714 truncation on 64-bit hosts. Check for QUIT every
1715 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1716 faster and is responsive enough.
1717 (Flength): Report an error instead of overflowing an integer.
1718 (Fsafe_length): Return a float if the value is not representable
1719 as a fixnum. This shouldn't happen except in contrived situations.
1720 (Fnthcdr, Fsort): Don't assume list length fits in int.
1721 (Fcopy_sequence): Don't assume vector length fits in int.
1722
1723 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1724 (header_size, word_size): New constants.
1725 (allocate_vectorlike): Don't check size overflow here.
1726 (allocate_vector): Check it here instead, since this is the only
1727 caller of allocate_vectorlike that could cause overflow.
1728 Check that the new vector's length is representable as a fixnum.
1729
1730 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1731 The previous code was bogus. For example, next_almost_prime (32)
1732 returned 39, which is undesirable as it is a multiple of 3; and
1733 next_almost_prime (24) returned 25, which is a multiple of 5 so
1734 why was the code bothering to check for multiples of 7?
1735
1736 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1737
1738 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1739
1740 Variadic C functions now count arguments with ptrdiff_t.
1741 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1742 Back then I didn't know that the Emacs coding style prefers signed int.
1743 Also, in the meantime I found a few more instances where arguments
1744 were being counted with int, which may truncate counts on 64-bit
1745 machines, or EMACS_INT, which may be unnecessarily wide.
1746 * lisp.h (struct Lisp_Subr.function.aMANY)
1747 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1748 Arg counts are now ptrdiff_t, not size_t.
1749 All variadic functions and their callers changed accordingly.
1750 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1751 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1752 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1753 * callint.c (Fcall_interactively): Check arg count for overflow,
1754 to avoid potential buffer overrun. Use signed char, not 'int',
1755 for 'varies' array, so that we needn't bother to check its size
1756 calculation for overflow.
1757 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1758 * eval.c (apply_lambda):
1759 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1760 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1761 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1762
1763 * callint.c (Fcall_interactively): Don't use index var as event count.
1764
1765 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1766 * mem-limits.h (SIZE): Remove; no longer used.
1767
1768 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1769
1770 Remove unnecessary casts.
1771 * xterm.c (x_term_init):
1772 * xfns.c (x_set_border_pixel):
1773 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1774 These aren't needed now that we assume ANSI C.
1775
1776 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1777 It's more likely to cause problems (due to unsigned overflow)
1778 than to cure them.
1779
1780 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1781
1782 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1783
1784 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1785
1786 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1787
1788 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1789
1790 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1791
1792 GLYPH_CODE_FACE returns EMACS_INT, not int.
1793 * dispextern.h (merge_faces):
1794 * xfaces.c (merge_faces):
1795 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1796 Don't assume EMACS_INT fits in int.
1797
1798 * character.h (CHAR_VALID_P): Remove unused parameter.
1799 * fontset.c, lisp.h, xdisp.c: All uses changed.
1800
1801 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1802
1803 * fns.c (concat): Minor tuning based on overflow analysis.
1804 This doesn't fix any bugs. Use int to hold character, instead
1805 of constantly refetching from Emacs object. Use XFASTINT, not
1806 XINT, for value known to be a character. Don't bother comparing
1807 a single byte to 0400, as it's always less.
1808
1809 * floatfns.c (Fexpt):
1810 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1811
1812 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1813 for characters.
1814
1815 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1816
1817 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1818 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1819 incorrectly succeed when S was a string, because 4294967386 was
1820 truncated before it was used.
1821
1822 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1823 Otherwise, an out-of-range integer could cause undefined behavior
1824 on a 64-bit host.
1825
1826 * composite.c: Use int, not EMACS_INT, for characters.
1827 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1828 EMACS_INT, for values that are known to be in character range.
1829 This doesn't fix any bugs but is the usual style inside Emacs and
1830 may generate better code on 32-bit machines.
1831
1832 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1833 This is for reasons similar to the recent CHAR_STRING fix.
1834 * charset.c (Fencode_char): Check that character arg is actually
1835 a character. Pass an int to ENCODE_CHAR.
1836 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1837 wider than 'int', as a compile-time check to prevent future regressions
1838 in this area.
1839
1840 * character.c (char_string): Remove unnecessary casts.
1841
1842 Make sure a 64-bit char is never passed to CHAR_STRING.
1843 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1844 by silently ignoring the top 32 bits, allowing some values
1845 that were far too large to be valid characters.
1846 * character.h: Include <verify.h>.
1847 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1848 arguments are no wider than unsigned, as a compile-time check
1849 to prevent future regressions in this area.
1850 * data.c (Faset):
1851 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1852 (Fsubst_char_in_region):
1853 * fns.c (concat):
1854 * xdisp.c (decode_mode_spec_coding):
1855 Adjust to CHAR_STRING's new requirement.
1856 * editfns.c (Finsert_char, Fsubst_char_in_region):
1857 * fns.c (concat): Check that character args are actually
1858 characters. Without this test, these functions did the wrong
1859 thing with wildly out-of-range values on 64-bit hosts.
1860
1861 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1862 These casts should not be needed on 32-bit hosts, either.
1863 * keyboard.c (read_char):
1864 * lread.c (Fload): Remove casts to unsigned.
1865
1866 * lisp.h (UNSIGNED_CMP): New macro.
1867 This fixes comparison bugs on 64-bit hosts.
1868 (ASCII_CHAR_P): Use it.
1869 * casefiddle.c (casify_object):
1870 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1871 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1872 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1873 * dispextern.h (FACE_FROM_ID):
1874 * keyboard.c (read_char): Use UNSIGNED_CMP.
1875
1876 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1877 not to EMACS_INT, to avoid GCC warning.
1878
1879 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1880
1881 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1882 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1883 isn't needed on 32-bit machines.
1884
1885 * buffer.c (Fgenerate_new_buffer_name):
1886 Use EMACS_INT for count, not int.
1887 (advance_to_char_boundary): Return EMACS_INT, not int.
1888
1889 * data.c (Qcompiled_function): Now static.
1890
1891 * window.c (window_body_lines): Now static.
1892
1893 * image.c (gif_load): Rename local to avoid shadowing.
1894
1895 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1896 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1897 * alloc.c (make_save_value): Integer argument is now of type
1898 ptrdiff_t, not int.
1899 (mark_object): Use ptrdiff_t, not int.
1900 * lisp.h (pD): New macro.
1901 * print.c (print_object): Use it.
1902
1903 * alloc.c: Use EMACS_INT, not int, to count objects.
1904 (total_conses, total_markers, total_symbols, total_vector_size)
1905 (total_free_conses, total_free_markers, total_free_symbols)
1906 (total_free_floats, total_floats, total_free_intervals)
1907 (total_intervals, total_strings, total_free_strings):
1908 Now EMACS_INT, not int. All uses changed.
1909 (Fgarbage_collect): Compute overall total using a double, so that
1910 integer overflow is less likely to be a problem. Check for overflow
1911 when converting back to an integer.
1912 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1913 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1914 These were 'int' variables that could overflow on 64-bit hosts;
1915 they were never used, so remove them instead of repairing them.
1916 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1917 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1918 Previously, this ceilinged at INT_MAX, but that doesn't work on
1919 64-bit machines.
1920 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1921
1922 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1923 (allocate_vectorlike): Check for ptrdiff_t overflow.
1924 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1925 when a (possibly-narrower) signed value would do just as well.
1926 We prefer using signed arithmetic, to avoid comparison confusion.
1927
1928 * alloc.c: Catch some string size overflows that we were missing.
1929 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1930 for convenience in STRING_BYTES_MAX.
1931 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1932 The definition here is exact; the one in lisp.h was approximate.
1933 (allocate_string_data): Check for string overflow. This catches
1934 some instances we weren't catching before. Also, it catches
1935 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1936 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1937 and ptrdiff_t and EMACS_INT are both 64 bits.
1938
1939 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1940 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1941 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1942
1943 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1944
1945 * alloc.c (Fmake_string): Check for out-of-range init.
1946
1947 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1948
1949 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1950
1951 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1952
1953 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1954 xg_get_default_scrollbar_width.
1955
1956 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1957 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1958 (style_changed_cb): Call update_theme_scrollbar_width and call
1959 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1960 all frames (Bug#8505).
1961 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1962 Call gtk_window_set_resizable if HAVE_GTK3.
1963 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1964 and height if HAVE_GTK3 (Bug#8505).
1965 (scroll_bar_width_for_theme): New variable.
1966 (update_theme_scrollbar_width): New function.
1967 (xg_get_default_scrollbar_width): Move code to
1968 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1969 (xg_initialize): Call update_theme_scrollbar_width.
1970
1971 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1972
1973 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1974
1975 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1976
1977 * frame.c (make_frame): Call other_buffer_safely instead of
1978 other_buffer.
1979
1980 * window.c (temp_output_buffer_show): Call display_buffer with
1981 second argument Vtemp_buffer_show_specifiers and reset latter
1982 immediately after the call.
1983 (Vtemp_buffer_show_specifiers): New variable.
1984 (auto_window_vscroll_p, next_screen_context_lines)
1985 (Vscroll_preserve_screen_position): Remove leading asterisks from
1986 doc-strings.
1987
1988 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1989
1990 Fix minor problems found by GCC 4.6.0 static checking.
1991 * buffer.c (Qclone_number): Remove for now, as it's unused.
1992 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1993 (record_buffer): Remove unused local.
1994 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1995 (set_frame_buffer_list): Remove; unused.
1996 * frame.h (other_visible_frames): Remove decl.
1997 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1998 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1999 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2000 if HAVE_GPM.
2001 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2002 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2003 Define only if HAVE_GPM.
2004 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2005 (update_hints_inhibit): Remove; never set. All uses removed.
2006 * widgetprv.h (emacsFrameClassRec): Remove decl.
2007 * window.c (delete_deletable_window): Now returns void, since it
2008 wasn't returning anything.
2009 (compare_window_configurations): Remove unused locals.
2010 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2011 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2012 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2013 the same widths as pointers. This follows up on the 2011-05-06 patch.
2014 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2015 * xterm.h: Likewise.
2016 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2017
2018 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2019
2020 * makefile.w32-in: Update dependencies.
2021 (LISP_H): Add lib/intprops.h.
2022
2023 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2024
2025 * image.c (gif_load): Add animation frame delay to the metadata.
2026 (syms_of_image): Use DEFSYM. New symbol `delay'.
2027
2028 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2029
2030 * window.c (delete_deletable_window): Re-add.
2031 (Fset_window_configuration): Rewrite to handle dead buffers and
2032 consequently deletable windows.
2033 (window_tree, Fwindow_tree): Remove. Supply functionality in
2034 window.el.
2035 (compare_window_configurations): Simplify code.
2036
2037 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2038
2039 * image.c (imagemagick_load_image): Fix type mismatch.
2040 (Fimagemagick_types): Likewise.
2041
2042 * window.h (replace_buffer_in_windows): Declare.
2043
2044 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2045
2046 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2047 Qclone_number. Remove external declaration of Qdelete_window.
2048 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2049 code.
2050 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2051 Qbuffer_list_update_hook if allowed.
2052 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2053 buffer list implementation.
2054 (other_buffer_safely): New function.
2055 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2056 calls to replace_buffer_in_windows and
2057 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2058 if allowed.
2059 (record_buffer): Inhibit quitting and rewrite using quittable
2060 functions. Run Qbuffer_list_update_hook if allowed.
2061 (Frecord_buffer, Funrecord_buffer): New functions.
2062 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2063 switch-to-buffer to window.el.
2064 (bury-buffer): Move to window.el.
2065 (Vbuffer_list_update_hook): New variable.
2066
2067 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2068 section.
2069
2070 * window.h (resize_frame_windows): Move up in code.
2071 (Fwindow_frame): Remove EXFUN.
2072 (replace_buffer_in_all_windows): Remove prototype.
2073 (replace_buffer_in_windows_safely): Add prototype.
2074
2075 * window.c: Declare Qdelete_window static again. Move down
2076 declaration of select_count.
2077 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2078 (Fother_window): Move to window.el.
2079 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2080 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2081 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2082 window.el.
2083 (replace_buffer_in_windows): Implement by calling
2084 Qreplace_buffer_in_windows.
2085 (replace_buffer_in_all_windows): Remove with some functionality
2086 moved into replace_buffer_in_windows_safely.
2087 (replace_buffer_in_windows_safely): New function.
2088 (select_window_norecord, select_frame_norecord): Move in front
2089 of run_window_configuration_change_hook. Remove now obsolete
2090 declarations.
2091 (Fset_window_buffer): Rewrite doc-string. Call
2092 Qrecord_window_buffer.
2093 (keys_of_window): Move binding for other-window to window.el.
2094
2095 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2096
2097 * dispextern.h (struct image): Replace data member, whose int_val
2098 and ptr_val fields were not used by anything, with a single
2099 lisp_val object.
2100
2101 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2102 (gif_clear_image, gif_load, imagemagick_load_image)
2103 (gs_clear_image, gs_load): Callers changed.
2104
2105 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2106
2107 * buffer.h: Include <time.h>, for time_t.
2108 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2109
2110 Fix minor problems found by static checking.
2111
2112 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2113
2114 Make identifiers static if they are not used in other modules.
2115 * data.c (Qcompiled_function, Qframe, Qvector):
2116 * image.c (QimageMagick, Qsvg):
2117 * minibuf.c (Qmetadata):
2118 * window.c (resize_window_check, resize_root_window): Now static.
2119 * window.h (resize_window_check, resize_root_window): Remove decls.
2120
2121 * window.c (window_deletion_count, delete_deletable_window):
2122 Remove; unused.
2123 (window_body_lines): Now static.
2124 (Fdelete_other_windows_internal): Mark vars as initialized.
2125 Make sure 'resize_failed' is initialized.
2126 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2127 (resize_window_apply): Remove unused local.
2128 * window.h (delete_deletable_window): Remove decl.
2129
2130 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2131 (imagemagick_load_image): Fix pointer signedness problem by changing
2132 last arg from unsigned char * to char *. All uses changed.
2133 Also, fix a local for similar reasons.
2134 Remove unused locals. Remove locals to avoid shadowing.
2135 (fn_rsvg_handle_free): Remove; unused.
2136 (svg_load, svg_load_image): Fix pointer signedness problem.
2137 (imagemagick_load_image): Don't use garbage pointer image_wand.
2138
2139 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2140
2141 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2142
2143 * image.c (gif_load): Fix omitted cast error introduced by
2144 2011-06-06 change.
2145
2146 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2147
2148 * window.h (resize_proportionally, orig_total_lines)
2149 (orig_top_line): Remove from window structure.
2150 (set_window_height, set_window_width, change_window_heights)
2151 (Fdelete_window): Remove prototypes.
2152 (resize_frame_windows): Remove duplicate declaration.
2153
2154 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2155
2156 * window.h (resize_frame_windows, resize_window_check)
2157 (delete_deletable_window, resize_root_window)
2158 (resize_frame_windows): Declare prototypes.
2159
2160 * window.c (resize_window_apply): Make definition be "static" to
2161 match the prototype.
2162
2163 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2164
2165 * window.c: Remove declarations of Qwindow_size_fixed,
2166 window_min_size_1, window_min_size_2, window_min_size,
2167 size_window, window_fixed_size_p, enlarge_window, delete_window.
2168 Remove static from declaration of Qdelete_window, it's
2169 temporarily needed by Fbury_buffer.
2170 (replace_window): Don't assign orig_top_line and
2171 orig_total_lines.
2172 (Fdelete_window, delete_window): Remove. Window deletion is
2173 handled by window.el.
2174 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2175 Fdelete_window calls with calls to Qdelete_window.
2176 (Fdelete_other_windows): Remove. Deleting other windows is
2177 handled by window.el.
2178 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2179 handled in window.el.
2180 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2181 Window minimum sizes are handled in window.el.
2182 (shrink_windows, size_window, set_window_height)
2183 (set_window_width, change_window_heights, window_height)
2184 (window_width, CURBEG, CURSIZE, enlarge_window)
2185 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2186 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2187 handled in window.el.
2188 (make_dummy_parent): Rename to make_parent_window and give it a
2189 second argument horflag.
2190 (make_window): Don't set resize_proportionally any more.
2191 (Fsplit_window): Remove. Windows are split in window.el.
2192 (save_restore_action, save_restore_orig_size)
2193 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2194 Resize mini windows in window.el.
2195 (grow_mini_window, shrink_mini_window): Implement by calling
2196 Qresize_root_window_vertically, resize_window_check and
2197 resize_window_apply.
2198 (saved_window, Fset_window_configuration, save_window_save): Do
2199 not handle orig_top_line, orig_total_lines, and
2200 resize_proportionally.
2201 (window_min_height, window_min_width): Move to window.el.
2202 (keys_of_window): Move bindings for delete-other-windows,
2203 split-window, delete-window and enlarge-window to window.el.
2204
2205 * buffer.c: Temporarily extern Qdelete_window.
2206 (Fbury_buffer): Temporarily call Qdelete_window instead of
2207 Fdelete_window (Fbury_buffer will move to window.el soon).
2208
2209 * frame.c (set_menu_bar_lines_1): Remove code handling
2210 orig_top_line and orig_total_lines.
2211
2212 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2213 set_window_height but set heights directly.
2214 (change_frame_size_1): Use resize_frame_windows.
2215
2216 * xdisp.c (init_xdisp): Don't use set_window_height but set
2217 heights directly.
2218
2219 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2220 resize_frame_windows instead of change_window_heights and run
2221 run_window_configuration_change_hook.
2222
2223 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2224 instead of change_window_heights and run
2225 run_window_configuration_change_hook.
2226
2227 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2228
2229 * window.c (replace_window): Rename second argument REPLACEMENT to
2230 NEW. New third argument SETFLAG. Rewrite.
2231 (delete_window, make_dummy_parent): Call replace_window with
2232 third argument 1.
2233 (window_list_1): Move down in code.
2234 (run_window_configuration_change_hook): Move set_buffer part
2235 before select_frame_norecord part in order to unwind correctly.
2236 Rename count1 to count.
2237 (recombine_windows, delete_deletable_window, resize_root_window)
2238 (Fdelete_other_windows_internal)
2239 (Frun_window_configuration_change_hook, make_parent_window)
2240 (resize_window_check, resize_window_apply, Fresize_window_apply)
2241 (resize_frame_windows, Fsplit_window_internal)
2242 (Fdelete_window_internal, Fresize_mini_window_internal): New
2243 functions.
2244 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2245
2246 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2247
2248 * window.h (window): Add some new members to window structure -
2249 normal_lines, normal_cols, new_total, new_normal, clone_number,
2250 splits, nest, prev_buffers, next_buffers.
2251 (WINDOW_TOTAL_SIZE): Move here from window.c.
2252 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2253
2254 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2255 Remove.
2256 (make_dummy_parent): Set new members of windows structure.
2257 (make_window): Move down in code. Handle new members of window
2258 structure.
2259 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2260 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2261 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2262 (Fset_window_prev_buffers, Fwindow_next_buffers)
2263 (Fset_window_next_buffers, Fset_window_clone_number): New
2264 functions.
2265 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2266 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2267 Doc-string fixes.
2268 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2269 Argument WINDOW can be now internal window too.
2270 (Fwindow_use_time): Move up in code.
2271 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2272 Rewrite doc-string.
2273 (Fset_window_configuration, saved_window)
2274 (Fcurrent_window_configuration, save_window_save): Handle new
2275 members of window structure.
2276 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2277 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2278 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2279 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2280 Qget_mru_window, Qresize_root_window,
2281 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2282 Qauto_buffer_name; staticpro them.
2283
2284 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2285
2286 * window.c (Fwindow_total_size, Fwindow_left_column)
2287 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2288 (Fwindow_list_1): New functions.
2289 (window_box_text_cols): Replace with window_body_cols.
2290 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2291 window_body_cols instead of window_box_text_cols.
2292 (delete_window, Fset_window_configuration): Call
2293 delete_all_subwindows with window as argument.
2294 (delete_all_subwindows): Take a window as argument and not a
2295 structure. Rewrite.
2296 (window_loop): Remove handling of GET_LRU_WINDOW and
2297 GET_LARGEST_WINDOW.
2298 (Fget_lru_window, Fget_largest_window): Move to window.el.
2299
2300 * window.h: Extern window_body_cols instead of
2301 window_box_text_cols. delete_all_subwindows now takes a
2302 Lisp_Object as argument.
2303
2304 * indent.c (compute_motion, Fcompute_motion): Use
2305 window_body_cols instead of window_box_text_cols.
2306
2307 * frame.c (delete_frame): Call delete_all_subwindows with root
2308 window as argument.
2309
2310 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2311
2312 * fns.c (Fputhash): Document return value.
2313
2314 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2315
2316 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2317
2318 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2319
2320 Cons<->int and similar integer overflow fixes (Bug#8794).
2321
2322 Check for overflow when converting integer to cons and back.
2323 * charset.c (Fdefine_charset_internal, Fdecode_char):
2324 Use cons_to_unsigned to catch overflow.
2325 (Fencode_char): Use INTEGER_TO_CONS.
2326 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2327 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2328 * data.c (long_to_cons, cons_to_long): Remove.
2329 (cons_to_unsigned, cons_to_signed): New functions.
2330 These signal an error for invalid or out-of-range values.
2331 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2332 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2333 * font.c (Ffont_variation_glyphs):
2334 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2335 * lisp.h: Include <intprops.h>.
2336 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2337 (cons_to_signed, cons_to_unsigned): New decls.
2338 (long_to_cons, cons_to_long): Remove decls.
2339 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2340 (Fprimitive_undo): Use CONS_TO_INTEGER.
2341 * xfns.c (Fx_window_property): Likewise.
2342 * xselect.c: Include <limits.h>.
2343 (x_own_selection, selection_data_to_lisp_data):
2344 Use INTEGER_TO_CONS.
2345 (x_handle_selection_request, x_handle_selection_clear)
2346 (x_get_foreign_selection, Fx_disown_selection_internal)
2347 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2348 (lisp_data_to_selection_data): Use cons_to_unsigned.
2349 (x_fill_property_data): Use cons_to_signed.
2350 Report values out of range.
2351
2352 Check for buffer and string overflow more precisely.
2353 * buffer.h (BUF_BYTES_MAX): New macro.
2354 * lisp.h (STRING_BYTES_MAX): New macro.
2355 * alloc.c (Fmake_string):
2356 * character.c (string_escape_byte8):
2357 * coding.c (coding_alloc_by_realloc):
2358 * doprnt.c (doprnt):
2359 * editfns.c (Fformat):
2360 * eval.c (verror):
2361 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2362 since they may not be the same number.
2363 * editfns.c (Finsert_char):
2364 * fileio.c (Finsert_file_contents):
2365 Likewise for BUF_BYTES_MAX.
2366
2367 * image.c: Use ptrdiff_t, not int, for sizes.
2368 (slurp_file): Switch from int to ptrdiff_t.
2369 All uses changed.
2370 (slurp_file): Check that file size fits in both size_t (for
2371 malloc) and ptrdiff_t (for sanity and safety).
2372
2373 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2374 if b->modtime has its maximal value.
2375
2376 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2377
2378 Don't assume time_t can fit into int.
2379 * buffer.h (struct buffer.modtime): Now time_t, not int.
2380 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2381 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2382
2383 Minor fixes for signed vs unsigned integers.
2384 * character.h (MAYBE_UNIFY_CHAR):
2385 * charset.c (maybe_unify_char):
2386 * keyboard.c (read_char, reorder_modifiers):
2387 XINT -> XFASTINT, since the integer must be nonnegative.
2388 * ftfont.c (ftfont_spec_pattern):
2389 * keymap.c (access_keymap, silly_event_symbol_error):
2390 XUINT -> XFASTINT, since the integer must be nonnegative.
2391 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2392 since it makes no difference and we prefer signed.
2393 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2394 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2395 nonnegative.
2396
2397 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2398
2399 * window.h (Fwindow_frame): Declare.
2400
2401 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2402
2403 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2404 (SPARE_MEMORY): Always define.
2405 (LARGE_REQUEST): Remove.
2406 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2407
2408 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2409
2410 * lisp.h: Move EXFUNS for Fframe_root_window,
2411 Fframe_first_window and Fset_frame_selected_window to window.h.
2412
2413 * window.h: Move EXFUNS for Fframe_root_window,
2414 Fframe_first_window and Fset_frame_selected_window here from
2415 lisp.h.
2416
2417 * frame.c (Fwindow_frame, Fframe_first_window)
2418 (Fframe_root_window, Fframe_selected_window)
2419 (Fset_frame_selected_window): Move to window.c.
2420 (Factive_minibuffer_window): Move to minibuf.c.
2421 (Fother_visible_frames_p): New function.
2422
2423 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2424
2425 * window.c (decode_window, decode_any_window): Move up in code.
2426 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2427 (inhibit_frame_unsplittable): Remove unused variable.
2428 (Fwindow_buffer): Move up and rewrite doc-string.
2429 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2430 (Fwindow_prev): New functions.
2431 (Fwindow_frame): Move here from frame.c. Accept any window as
2432 argument.
2433 (Fframe_root_window, Fframe_first_window)
2434 (Fframe_selected_window): Move here from frame.c. Accept frame
2435 or arbitrary window as argument. Update doc-strings.
2436 (Fminibuffer_window): Move up in code.
2437 (Fwindow_minibuffer_p): Move up in code and simplify.
2438 (Fset_frame_selected_window): Move here from frame.c.
2439 Marginal rewrite.
2440 (Fselected_window, select_window, Fselect_window): Move up in
2441 code. Minor doc-string fixes.
2442
2443 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2446 Do not assume that spare memory exists; that assumption is valid
2447 only if SYSTEM_MALLOC.
2448 (LARGE_REQUEST): New macro, so that the issue of large requests
2449 is separated from the issue of spare memory.
2450
2451 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2452
2453 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2454 format. (Bug#8806)
2455
2456 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2457
2458 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2459 before statements.
2460
2461 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2462
2463 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2464
2465 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2466
2467 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2468 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2469
2470 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2471
2472 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2473
2474 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2475
2476 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2477 (x_clipboard_manager_save): Add return value.
2478 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2479 New error handlers.
2480 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2481 Obey Vx_select_enable_clipboard_manager. Catch errors in
2482 x_clipboard_manager_save (Bug#8779).
2483 (Vx_select_enable_clipboard_manager): New variable.
2484 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2485
2486 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2487
2488 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2489
2490 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2491
2492 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2493 in the current matrix if keep_current_p is non-zero.
2494
2495 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2496
2497 * bidi.c (bidi_level_of_next_char): Fix last change.
2498
2499 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2500
2501 Support bidi reordering of text covered by display properties.
2502
2503 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2504 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2505 (bidi_cache_search, bidi_cache_iterator_state)
2506 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2507 (bidi_level_of_next_char, bidi_move_to_visually_next):
2508 Support character positions inside a run of characters covered by a
2509 display string.
2510 (bidi_paragraph_init, bidi_resolve_explicit_1)
2511 (bidi_level_of_next_char): Call bidi_fetch_char and
2512 bidi_fetch_char_advance instead of FETCH_CHAR and
2513 FETCH_CHAR_ADVANCE.
2514 (bidi_init_it): Initialize new members.
2515 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2516 definitions.
2517 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2518 instead of using explicit *_CHAR codes.
2519 (bidi_resolve_explicit, bidi_resolve_weak):
2520 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2521 bidirectional text is supported only in multibyte buffers.
2522 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2523 it to initialize the frame_window_p member of struct bidi_it.
2524 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2525 (bidi_resolve_explicit, bidi_resolve_weak)
2526 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2527 bidi_it->nchars is non-positive.
2528 (bidi_level_of_next_char): Don't try to lookup the cache for the
2529 next/previous character if nothing is cached there yet, or if we
2530 were just reseat()'ed to a new position.
2531
2532 * xdisp.c (set_cursor_from_row): Set start and stop points
2533 according to the row's direction when priming the loop that looks
2534 for the glyph on which to display cursor.
2535 (single_display_spec_intangible_p): Function deleted.
2536 (display_prop_intangible_p): Reimplement to call
2537 handle_display_spec instead of single_display_spec_intangible_p.
2538 Accept 3 additional arguments needed by handle_display_spec.
2539 This fixes incorrect cursor motion across display property with complex
2540 values: lists, `(when COND...)' forms, etc.
2541 (single_display_spec_string_p): Support property values that are
2542 lists with the argument STRING its top-level element.
2543 (display_prop_string_p): Fix the condition for processing a
2544 property that is a list to be consistent with handle_display_spec.
2545 (handle_display_spec): New function, refactored from the
2546 last portion of handle_display_prop.
2547 (compute_display_string_pos): Accept additional argument
2548 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2549 value of a `display' property is a "replacing spec".
2550 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2551 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2552 the display property, but just return a value indicating whether
2553 the display property will replace the characters it covers.
2554 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2555 frame_window_p members of struct bidi_it.
2556 (compute_display_string_pos, compute_display_string_end):
2557 New functions.
2558 (push_it): Accept second argument POSITION, where pop_it should
2559 jump to continue iteration.
2560 (reseat_1): Initialize bidi_it.disp_pos.
2561
2562 * keyboard.c (adjust_point_for_property): Adjust the call to
2563 display_prop_intangible_p to its new signature.
2564
2565 * dispextern.h (struct bidi_it): New member frame_window_p.
2566 (bidi_init_it): Update prototypes.
2567 (display_prop_intangible_p): Update prototype.
2568 (compute_display_string_pos, compute_display_string_end):
2569 Declare prototypes.
2570 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2571 EMACS_INT.
2572
2573 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2574
2575 Malloc failure behavior now depends on size of allocation.
2576 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2577 * lisp.h: Change signatures accordingly.
2578 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2579 All callers changed. (Bug#8762)
2580
2581 * gnutls.c: Use Emacs's memory allocators.
2582 Without this change, the gnutls library would invoke malloc etc.
2583 directly, which causes problems on non-SYNC_INPUT hosts, and which
2584 runs afoul of improving memory_full behavior. (Bug#8761)
2585 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2586 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2587 xfree instead of the default malloc, realloc, free.
2588 (Fgnutls_boot): No need to check for memory allocation failure,
2589 since xmalloc does that for us.
2590
2591 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2592 * category.c (hash_get_category_set):
2593 * ccl.c (ccl_driver):
2594 * charset.c (Fdefine_charset_internal):
2595 * charset.h (struct charset.hash_index):
2596 * composite.c (get_composition_id, gstring_lookup_cache)
2597 (composition_gstring_put_cache):
2598 * composite.h (struct composition.hash_index):
2599 * dispextern.h (struct image.hash):
2600 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2601 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2602 (hashfn_equal, hashfn_user_defined, make_hash_table)
2603 (maybe_resize_hash_table, hash_lookup, hash_put)
2604 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2605 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2606 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2607 * image.c (make_image, search_image_cache, lookup_image)
2608 (xpm_put_color_table_h):
2609 * lisp.h (struct Lisp_Hash_Table):
2610 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2611 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2612 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2613 * alloc.c (allocate_vectorlike):
2614 Check for overflow in vector size calculations.
2615 * ccl.c (ccl_driver):
2616 Check for overflow when converting EMACS_INT to int.
2617 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2618 need to be updated by these changes.
2619 * fns.c (make_hash_table, maybe_resize_hash_table):
2620 Check for integer overflow with large hash tables.
2621 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2622 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2623 (SXHASH_REDUCE): New macro.
2624 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2625 Use it instead of discarding useful hash info with large hash values.
2626 (sxhash_float): New function.
2627 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2628 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2629 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2630 Rewrite to use FIXNUM_BITS, as this simplifies things.
2631 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2632 Adjust signatures to match updated version of code.
2633 (consing_since_gc): Now EMACS_INT, since a single hash table can
2634 use more than INT_MAX bytes.
2635
2636 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2637
2638 Make it possible to build with GCC-4.6+ -O2 -flto.
2639
2640 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2641
2642 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2643
2644 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2645 Call minibuffer-inactive-mode.
2646
2647 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2648
2649 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2650 Update dependencies.
2651
2652 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2653
2654 * data.c (init_data): Remove code for UTS, this system is not
2655 supported anymore.
2656
2657 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2658
2659 Don't force ./temacs to start in terminal mode.
2660
2661 * frame.c (make_initial_frame): Initialize faces in all cases, not
2662 only when CANNOT_DUMP is defined.
2663 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2664
2665 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2666
2667 * dispnew.c (add_window_display_history): Use const for the string
2668 pointer. Remove declaration, not needed.
2669
2670 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2671
2672 Use 'inline', not 'INLINE'.
2673 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2674 * alloc.c, fontset.c (INLINE): Remove.
2675 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2676 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2677 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2678 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2679 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2680
2681 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2682
2683 Make it possible to run ./temacs.
2684
2685 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2686 syms_of_callproc does the same thing. Remove test for
2687 "initialized", do it in the caller.
2688 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2689
2690 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2691
2692 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2693 (read_minibuf): Use get_minibuffer.
2694 (syms_of_minibuf): Use DEFSYM.
2695 (Qmetadata): New var.
2696 * data.c (Qbuffer): Don't make it static.
2697 (syms_of_data): Use DEFSYM.
2698
2699 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2700
2701 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2702 (CCL_CODE_MIN): New macro.
2703
2704 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2705
2706 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2707
2708 * eval.c (Qdebug): Now static.
2709 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2710 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2711 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2712
2713 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2714
2715 * image.c: Various fixes to ImageMagick code comments.
2716 (Fimagemagick_types): Doc fix.
2717
2718 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2719
2720 Minor fixes prompted by GCC 4.6.0 warnings.
2721
2722 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2723
2724 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2725 (x_clipboard_manager_save_all): Move extern decl to ...
2726 * xterm.h: ... here, so that it can be checked for consistency.
2727
2728 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2729
2730 * xselect.c (x_clipboard_manager_save_frame)
2731 (x_clipboard_manager_save_all): New functions.
2732 (Fx_clipboard_manager_save): Lisp function deleted.
2733
2734 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2735 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2736
2737 * xterm.h: Update prototype.
2738
2739 2011-05-28 William Xu <william.xwl@gmail.com>
2740
2741 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2742 exiting (Bug#8239).
2743
2744 2011-05-28 Jim Meyering <meyering@redhat.com>
2745
2746 Avoid a sign-extension bug in crypto_hash_function.
2747 * fns.c (to_uchar): Define.
2748 (crypto_hash_function): Use it to convert some newly-signed
2749 variables to unsigned, to avoid sign-extension bugs. For example,
2750 without this change, (md5 "truc") would evaluate to
2751 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2752 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2753 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2754
2755 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2756
2757 Integer overflow fixes.
2758
2759 * dbusbind.c: Serial number integer overflow fixes.
2760 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2761 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2762 to hold a serial number that is too large for a fixnum.
2763 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2764 Check for serial numbers out of range. Decode any serial number
2765 that was so large that it became a float. (Bug#8722)
2766
2767 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2768 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2769 Use XFASTINT rather than XUINT when numbers are nonnegative.
2770 (xd_append_arg, Fdbus_method_return_internal):
2771 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2772 arguments, check that Lisp number is nonnegative, rather than
2773 silently wrapping negative numbers around. (Bug#8722)
2774 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2775 (Bug#8722)
2776
2777 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2778
2779 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2780
2781 ccl: add integer overflow checks
2782 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2783 (IN_INT_RANGE): New macros.
2784 (ccl_driver): Use them to check for integer overflow when
2785 decoding a CCL program. Many of the new checks are whether XINT (x)
2786 fits in int; it doesn't always, on 64-bit hosts. The new version
2787 doesn't catch all possible integer overflows, but it's an
2788 improvement. (Bug#8719)
2789
2790 * alloc.c (make_event_array): Use XINT, not XUINT.
2791 There's no need for unsigned here.
2792
2793 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2794 This follows up to the 2011-05-06 change that substituted uintptr_t
2795 for EMACS_INT. This case wasn't caught back then.
2796
2797 Rework Fformat to avoid integer overflow issues.
2798 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2799 now (part of C89). Include <verify.h>.
2800 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2801 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2802 (Fformat): Avoid the prepass trying to compute sizes; it was only
2803 approximate and thus did not catch overflow reliably. Instead, walk
2804 through the format just once, formatting and computing sizes as we go,
2805 checking for integer overflow at every step, and allocating a larger
2806 buffer as needed. Keep track separately whether the format is
2807 multibyte. Keep only the most-recently calculated precision, rather
2808 than them all. Record whether each argument has been converted to
2809 string. Use EMACS_INT, not int, for byte and char and arg counts.
2810 Support field widths and precisions larger than INT_MAX. Avoid
2811 sprintf's undefined behavior with conversion specifications such as %#d
2812 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2813 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2814 formatting out-of-range floating point numbers with int
2815 formats. (Bug#8668)
2816
2817 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2818
2819 * data.c: Avoid integer truncation in expressions involving floats.
2820 * data.c: Include <intprops.h>.
2821 (arith_driver): When there's an integer overflow in an expression
2822 involving floating point, convert the integers to floating point
2823 so that the resulting value does not suffer from catastrophic
2824 integer truncation. For example, on a 64-bit host (* 4
2825 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2826 Do not rely on undefined behavior after integer overflow.
2827
2828 merge count_size_as_multibyte, parse_str_to_multibyte
2829 * character.c, character.h (count_size_as_multibyte):
2830 Rename from parse_str_to_multibyte; all uses changed.
2831 Check for integer overflow.
2832 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2833 since it's now a duplicate of the other. This is more of
2834 a character than a buffer op, so better that it's in character.c.
2835 * fns.c, print.c: Adjust to above changes.
2836
2837 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2838
2839 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2840
2841 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2842
2843 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2844 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2845 (x_clipboard_manager_save): Now static.
2846 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2847
2848 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2849 (crypto_hash_function): Now static.
2850 Fix pointer signedness problems. Avoid unnecessary initializations.
2851
2852 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2853
2854 * termhooks.h (Vselection_alist): Make it terminal-local.
2855
2856 * terminal.c (create_terminal): Initialize it.
2857
2858 * xselect.c: Support for clipboard managers.
2859 (Vselection_alist): Move to termhooks.h as terminal-local var.
2860 (LOCAL_SELECTION): New macro.
2861 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2862 (symbol_to_x_atom): Remove gratuitous arg.
2863 (x_handle_selection_request, lisp_data_to_selection_data)
2864 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2865 (x_own_selection, x_get_local_selection, x_convert_selection):
2866 New arg, specifying work frame. Use terminal-local Vselection_alist.
2867 (some_frame_on_display): Delete unused function.
2868 (Fx_own_selection_internal, Fx_get_selection_internal)
2869 (Fx_disown_selection_internal, Fx_selection_owner_p)
2870 (Fx_selection_exists_p): New optional frame arg.
2871 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2872 (x_handle_selection_clear): Don't treat other terminals with the
2873 same keyboard specially. Use the terminal-local Vselection_alist.
2874 (x_clear_frame_selections): Use Frun_hook_with_args.
2875
2876 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2877
2878 * xterm.h: Add support for those atoms.
2879
2880 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2881
2882 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2883 (converted_selections, conversion_fail_tag): New global variables.
2884 (x_selection_request_lisp_error): Free the above.
2885 (x_get_local_selection): Remove unnecessary code.
2886 (x_reply_selection_request): Args changed; handle arbitrary array
2887 of converted selections stored in converted_selections.
2888 Separate the XChangeProperty and SelectionNotify steps.
2889 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2890 (x_convert_selection): New function.
2891 (x_handle_selection_event): Simplify.
2892 (x_get_foreign_selection): Don't ignore incoming requests while
2893 waiting for an answer; this will fail when we implement
2894 SAVE_TARGETS, and seems unnecessary anyway.
2895 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2896 (Vx_sent_selection_functions): Doc fix.
2897
2898 2011-05-26 Leo Liu <sdl.web@gmail.com>
2899
2900 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2901
2902 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2903
2904 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2905
2906 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2907 for fringe update if it has periodic bitmap.
2908 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2909 and fringe_bitmap_periodic_p.
2910
2911 * fringe.c (get_fringe_bitmap_data): New function.
2912 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2913 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2914 row. Mark glyph row for fringe update if periodicity changed.
2915
2916 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2917 for fringe update unless it has periodic bitmap.
2918
2919 2011-05-25 Kenichi Handa <handa@m17n.org>
2920
2921 * xdisp.c (get_next_display_element): Set correct it->face_id for
2922 a static composition.
2923
2924 2011-05-24 Leo Liu <sdl.web@gmail.com>
2925
2926 * deps.mk (fns.o):
2927 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2928
2929 * fns.c (crypto_hash_function, Fsha1): New function.
2930 (Fmd5): Use crypto_hash_function.
2931 (syms_of_fns): Add Ssha1.
2932
2933 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2934
2935 * gnutls.c: Remove unused macros.
2936 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2937 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2938 Remove macros that are defined and never used.
2939 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2940
2941 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2942
2943 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2944 (Fx_get_selection_internal): Minor cleanup.
2945 (Fx_own_selection_internal): Rename arguments for consistency with
2946 select.el.
2947
2948 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2949
2950 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2951
2952 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2953
2954 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2955
2956 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2957
2958 * dispnew.c (scrolling_window): Don't exclude the case that the
2959 last enabled row in the desired matrix touches the bottom boundary.
2960
2961 2011-05-21 Glenn Morris <rgm@gnu.org>
2962
2963 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2964 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2965 and add some more files.
2966
2967 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2968
2969 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2970 report_file_error introduced by the change from 2011-05-07.
2971
2972 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2973
2974 * systime.h (Time): Define only if emacs is defined.
2975 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2976 where the include path doesn't have X11/X.h by default. See
2977 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2978
2979 2011-05-20 Kenichi Handa <handa@m17n.org>
2980
2981 * composite.c (find_automatic_composition): Fix previous change.
2982
2983 2011-05-20 Glenn Morris <rgm@gnu.org>
2984
2985 * lisp.mk: New file, split from Makefile.in.
2986 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2987 (shortlisp): Remove.
2988 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2989
2990 2011-05-19 Glenn Morris <rgm@gnu.org>
2991
2992 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2993 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2994 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2995 (lisp): Set the order to that of loadup.el.
2996 (shortlisp): Make it a copy of $lisp.
2997 (SOME_MACHINE_LISP): Remove.
2998 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2999 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3000
3001 2011-05-18 Kenichi Handa <handa@m17n.org>
3002
3003 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3004 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3005 (find_automatic_composition): Mostly rewrite for efficiency.
3006
3007 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3008
3009 * makefile.w32-in: Update dependencies.
3010
3011 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3012
3013 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3014 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3015
3016 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3017
3018 Fix some integer overflow issues, such as string length overflow.
3019
3020 * insdel.c (count_size_as_multibyte): Check for string overflow.
3021
3022 * character.c (lisp_string_width): Check for string overflow.
3023 Use EMACS_INT, not int, for string indexes and lengths; in
3024 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3025 the resulting string length overflows an EMACS_INT; instead,
3026 report a string overflow if no precision given. When checking for
3027 precision exhaustion, use a check that cannot possibly have
3028 integer overflow. (Bug#8675)
3029 * character.h (lisp_string_width): Adjust to new signature.
3030
3031 * alloc.c (string_overflow): New function.
3032 (Fmake_string): Use it. This doesn't change behavior, but saves
3033 a few bytes and will simplify future changes.
3034 * character.c (string_escape_byte8): Likewise.
3035 * lisp.h (string_overflow): New decl.
3036
3037 Fixups, following up to the user-interface timestamp change.
3038 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3039 for UI timestamps, instead of unsigned long.
3040 * msdos.c (mouse_get_pos): Likewise.
3041 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3042 * w32gui.h (Time): Define by including "systime.h" rather than by
3043 declaring it ourselves. (Bug#8664)
3044
3045 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3046 * image.c (clear_image_cache): Likewise.
3047
3048 * term.c (term_mouse_position): Don't assume time_t wraparound.
3049
3050 Be more systematic about user-interface timestamps.
3051 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3052 and sometimes 'EMACS_UINT', to represent these timestamps.
3053 This change causes it to use 'Time' uniformly, as that's what X uses.
3054 This makes the code easier to follow, and makes it easier to catch
3055 integer overflow bugs such as Bug#8664.
3056 * frame.c (Fmouse_position, Fmouse_pixel_position):
3057 Use Time, not unsigned long, for user-interface timestamps.
3058 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3059 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3060 * keyboard.h (last_event_timestamp): Likewise.
3061 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3062 * menu.h (xmenu_show): Likewise.
3063 * term.c (term_mouse_position): Likewise.
3064 * termhooks.h (struct input_event.timestamp): Likewise.
3065 (struct terminal.mouse_position_hook): Likewise.
3066 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3067 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3068 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3069 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3070 what it was before.
3071 * menu.h, termhooks.h: Include "systime.h", for Time.
3072
3073 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3074 Don't assume that the difference between two unsigned long values
3075 can fit into an integer. At this point, we know button_down_time
3076 <= event->timestamp, so the difference must be nonnegative, so
3077 there's no need to cast the result if double-click-time is
3078 nonnegative, as it should be; check that it's nonnegative, just in
3079 case. This bug is triggered when events are more than 2**31 ms
3080 apart (about 25 days). (Bug#8664)
3081
3082 * xselect.c (last_event_timestamp): Remove duplicate decl.
3083 (x_own_selection): Remove needless cast to unsigned long.
3084
3085 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3086 that always fit in int. Use a sentinel instead of a counter, to
3087 avoid a temp and to allay GCC's concerns about possible int overflow.
3088 * frame.h (struct frame): Use int for menu_bar_items_used
3089 instead of EMACS_INT, since it always fits in int.
3090
3091 * menu.c (grow_menu_items): Check for int overflow.
3092
3093 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3094
3095 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3096 Before, the code was not consistent. These values cannot exceed
3097 2**31 - 1 so there's no need to make them unsigned.
3098 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3099 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3100 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3101 as modifiers.
3102 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3103
3104 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3105 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3106 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3107 presumably because the widths might not match.
3108
3109 * window.c (size_window): Avoid needless test at loop start.
3110
3111 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3112
3113 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3114
3115 2011-05-12 Drew Adams <drew.adams@oracle.com>
3116
3117 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3118
3119 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3120
3121 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3122 `width' to `bar_area_x' and `bar_area_width', respectively.
3123 (x_scroll_run): Take account of fringe background extension.
3124
3125 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3126 Rename local vars `left' and `width' to `bar_area_x' and
3127 `bar_area_width', respectively.
3128 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3129 background extension.
3130
3131 2011-05-10 Jim Meyering <meyering@redhat.com>
3132
3133 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3134
3135 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3136
3137 * image.c (Finit_image_library): Return t for built-in image types,
3138 like pbm and xbm. (Bug#8640)
3139
3140 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3141
3142 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3143
3144 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3145
3146 * w32console.c (Fset_screen_color): Doc fix.
3147 (Fget_screen_color): New function.
3148 (syms_of_ntterm): Defsubr it.
3149
3150 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3151 unlink the temporary file if Fcall_process didn't create it in the
3152 first place.
3153 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3154 child process will be redirected to a file specified with `:file'.
3155 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3156 cue to call_process_cleanup not to close that handle.
3157
3158 2011-05-07 Ben Key <bkey76@gmail.com>
3159
3160 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3161 one of two shell specific rules, either bootstrap-temacs-CMD or
3162 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3163 to the previous implementation of the bootstrap-temacs rule.
3164 The bootstrap-temacs-CMD rule is similar to the previous
3165 implementation of the bootstrap-temacs rule except that it
3166 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3167 variable.
3168
3169 These changes, along with some changes to nt/configure.bat,
3170 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3171 earlier fix to add support for --cflags and --ldflags options
3172 that include quotes so that it works whether make uses cmd or
3173 sh as the shell.
3174
3175 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3176
3177 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3178 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3179 is a constant.
3180 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3181 a string. Handle both cases.
3182 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3183 (Fdbus_register_method): Use Qinvalid_function.
3184
3185 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3186
3187 * makefile.w32-in: Update dependencies.
3188 (LISP_H): Add inttypes.h and stdin.h.
3189 (PROCESS_H): Add unistd.h.
3190
3191 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3192
3193 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3194 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3195
3196 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3197
3198 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3199
3200 * term.c (vfatal): Remove stray call to va_end.
3201 It's not needed and the C Standard doesn't allow it here anyway.
3202
3203 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3204 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3205
3206 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3207 bytes.
3208
3209 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3210
3211 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3212
3213 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3214
3215 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3216
3217 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3218
3219 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3220 * charset.c (Fdefine_charset_internal): Don't initialize
3221 charset.code_space[15]. The value was garbage, on hosts with
3222 32-bit int (Bug#8600).
3223
3224 * lread.c (read_integer): Be more consistent with string-to-number.
3225 Use string_to_number to do the actual conversion; this avoids
3226 rounding errors and fixes some other screwups. Without this fix,
3227 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3228 (digit_to_number): Move earlier, for benefit of read_integer.
3229 Return -1 if the digit is out of range for the base, -2 if it is
3230 not a digit in any supported base. (Bug#8602)
3231
3232 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3233
3234 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3235 to match comment at start of function. This also removes a
3236 GCC warning about overflow in a 32+64-bit port.
3237
3238 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3239
3240 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3241 Reported by Stefan Monnier in
3242 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3243 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3244 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3245
3246 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3247 (EMACS_UINTPTR): Likewise, with uintptr_t.
3248
3249 * lisp.h: Prefer 64-bit EMACS_INT if available.
3250 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3251 on 32-bit hosts that have 64-bit int, so that they can access
3252 large files.
3253 However, temporarily disable this change unless the temporary
3254 symbol WIDE_EMACS_INT is defined.
3255
3256 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3257
3258 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3259 This removes an assumption that EMACS_INT and long are the same
3260 width as pointers. The assumption is true for Emacs porting targets
3261 now, but we want to make other targets possible.
3262 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3263 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3264 In the rest of the code, change types of integers that hold casted
3265 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3266 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3267 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3268 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3269 No need to cast type when ORing.
3270 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3271 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3272 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3273 assume EMACS_INT is the same width as char *.
3274 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3275 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3276 Remove no-longer-needed casts.
3277 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3278 (xg_tool_bar_help_callback, xg_make_tool_item):
3279 Use EMACS_INTPTR to hold an integer
3280 that will be cast to void *; this can avoid a GCC warning
3281 if EMACS_INT is not the same width as void *.
3282 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3283 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3284 (current_message_1, set_message_1):
3285 Use a local to convert to proper width without a cast.
3286 * xmenu.c (dialog_selection_callback): Likewise.
3287
3288 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3289 Also, don't assume VALBITS / RAND_BITS is less than 5,
3290 and don't rely on undefined behavior when shifting a 1 left into
3291 the sign bit.
3292 * lisp.h (get_random): Change signature to match.
3293
3294 * lread.c (hash_string): Use size_t, not int, for hash computation.
3295 Normally we prefer signed values; but hashing is special, because
3296 it's better to use unsigned division on hash table sizes so that
3297 the remainder is nonnegative. Also, size_t is the natural width
3298 for hashing into memory. The previous code used 'int', which doesn't
3299 retain enough info to hash well into very large tables.
3300 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3301
3302 * dbusbind.c: Don't possibly lose pointer info when converting.
3303 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3304 Use XPNTR rather than XHASH, so that the high-order bits of
3305 the pointer aren't lost when converting through void *.
3306
3307 * eval.c (Fautoload): Don't double-shift a pointer.
3308
3309 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3310
3311 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3312
3313 * gnutls.c (DEF_GNUTLS_FN):
3314 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3315
3316 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3317
3318 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3319 marker. (Bug#8610)
3320
3321 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3322
3323 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3324 New version that can reserve upto 2GB of heap space.
3325
3326 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3327
3328 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3329
3330 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3331
3332 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3333 `gnutls_certificate_set_x509_key_file'.
3334
3335 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3336
3337 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3338 Update dependencies.
3339
3340 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3341
3342 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3343 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3344 Remove unused parameter `fildes'.
3345 * process.c (read_process_output, send_process): Don't pass it.
3346
3347 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3348
3349 Fix previous change: the library cache is defined in w32.c.
3350 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3351 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3352
3353 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3354
3355 Implement dynamic loading of GnuTLS on Windows.
3356
3357 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3358 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3359 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3360 Declare.
3361
3362 * gnutls.c (Qgnutls_dll): Define.
3363 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3364 (gnutls_*): Declare function pointers.
3365 (init_gnutls_functions): New function to initialize function pointers.
3366 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3367 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3368 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3369 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3370 (emacs_gnutls_write, emacs_gnutls_read)
3371 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3372 (Fgnutls_available_p): New function.
3373 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3374 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3375 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3376
3377 * image.c: Include w32.h.
3378 (Vimage_type_cache): Delete.
3379 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3380 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3381 (w32_delayed_load): Move to w32.c.
3382
3383 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3384
3385 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3386 (w32_delayed_load): Move from image.c. When loading a library, record
3387 its filename in the :loaded-from property of the library id.
3388 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3389 Initialize and staticpro them.
3390 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3391
3392 * process.c: Include lisp.h before w32.h, not after.
3393 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3394 instead of gnutls_record_check_pending.
3395
3396 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3397
3398 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3399
3400 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3401 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3402 as passed in.
3403
3404 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3405
3406 * xterm.c (x_set_frame_alpha): Do not set property on anything
3407 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3408
3409 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3410
3411 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3412
3413 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3414
3415 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3416 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3417 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3418 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3419 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3420 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3421 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3422 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3423 (Qgnutls_bootprop_callbacks_verify): Make static.
3424
3425 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3426
3427 * callproc.c: Indentation fixup.
3428
3429 * sysdep.c (wait_for_termination_1): Make static.
3430 (wait_for_termination, interruptible_wait_for_termination):
3431 Move after wait_for_termination_1.
3432
3433 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3434
3435 * sysdep.c (interruptible_wait_for_termination): New function
3436 which is like wait_for_termination, but allows keyboard
3437 interruptions.
3438
3439 * callproc.c (Fcall_process): Add (:file "file") as an option for
3440 the STDOUT buffer.
3441 (Fcall_process_region): Ditto.
3442
3443 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3444
3445 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3446 rather than `XVECTOR (FOO)->size'.
3447
3448 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3449 inttypes.h, as a gnulib replacement is used if it not available in
3450 system headers.
3451
3452 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3453
3454 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3455 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3456 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3457
3458 * coding.c (coding_alloc_by_realloc): Error out if destination
3459 will grow beyond MOST_POSITIVE_FIXNUM.
3460 (decode_coding_emacs_mule): Abort if there isn't enough place in
3461 charbuf for the composition carryover bytes. Reserve an extra
3462 space for up to 2 characters produced in a loop.
3463 (decode_coding_iso_2022): Abort if there isn't enough place in
3464 charbuf for the composition carryover bytes.
3465
3466 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3467
3468 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3469 aborting when %lld or %lll format is passed.
3470 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3471 %llo or %llx format is passed. (Bug#8545)
3472
3473 * window.c (window_scroll_line_based): Use a marker instead of
3474 simple variables to record original value of point. (Bug#7952)
3475
3476 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3477 produced by %s or %c overflows available buffer space. (Bug#8545)
3478
3479 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3480
3481 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3482 (SIZE_MAX): Move defn after all includes, as they might #define it.
3483
3484 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3485
3486 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3487
3488 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3489
3490 * keyboard.c (Qdelayed_warnings_hook): Define.
3491 (command_loop_1): Run `delayed-warnings-hook'
3492 if Vdelayed_warnings_list is non-nil.
3493 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3494 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3495
3496 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3497
3498 * doprnt.c (doprnt): Don't return value smaller than the buffer
3499 size if the message was truncated. (Bug#8545).
3500
3501 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3502
3503 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3504 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3505
3506 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3507
3508 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3509
3510 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3511
3512 * makefile.w32-in: Update dependencies.
3513
3514 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3515
3516 Improve `doprnt' and its usage. (Bug#8545)
3517 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3518 `format_end'. Remove support for %l as a conversion specifier.
3519 Don't use xrealloc. Improve diagnostics when the %l size modifier
3520 is used. Update the commentary.
3521
3522 * eval.c (verror): Simplify calculation of size_t.
3523
3524 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3525 messages.
3526
3527 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3528
3529 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3530 change.
3531
3532 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3533
3534 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3535 This makes this file independent of the recent pseudovector change.
3536
3537 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3538
3539 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3540
3541 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3542 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3543 Remove unused local.
3544 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3545
3546 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3547 GCC 4.6.0 optimizes based on type-based alias analysis.
3548 For example, if b is of type struct buffer * and v of type struct
3549 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3550 != &v->size, and therefore "v->size = 1; b->size = 2; return
3551 v->size;" must therefore return 1. This assumption is incorrect
3552 for Emacs, since it type-puns struct Lisp_Vector * with many other
3553 types. To fix this problem, this patch adds a new type struct
3554 vectorlike_header that documents the constraints on layout of vectors
3555 and pseudovectors, and helps optimizing compilers not get fooled
3556 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3557 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3558 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3559 the size member.
3560 (XSETPVECTYPE): Rewrite in terms of new macro.
3561 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3562 This is a bit clearer, and further avoids the possibility of
3563 undesirable aliasing.
3564 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3565 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3566 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3567 since Lisp_Subr is a special case (no "next" field).
3568 (ASIZE): Now uses header.size rather than size.
3569 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3570 to avoid the hassle of writing XVECTOR (foo)->header.size.
3571 (struct vectorlike_header): New type.
3572 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3573 object, to help avoid aliasing.
3574 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3575 (SUBRP): Likewise, since Lisp_Subr is a special case.
3576 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3577 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3578 (struct Lisp_Hash_Table): Combine first two members into a single
3579 struct vectorlike_header member. All uses of "size" and "next" members
3580 changed to be "header.size" and "header.next".
3581 * buffer.h (struct buffer): Likewise.
3582 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3583 * frame.h (struct frame): Likewise.
3584 * process.h (struct Lisp_Process): Likewise.
3585 * termhooks.h (struct terminal): Likewise.
3586 * window.c (struct save_window_data, struct saved_window): Likewise.
3587 * window.h (struct window): Likewise.
3588 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3589 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3590 * buffer.c (init_buffer_once): Likewise.
3591 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3592 special case.
3593 * process.c (Fformat_network_address): Use local var for size,
3594 for brevity.
3595
3596 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3597
3598 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3599 * data.c (atof): Remove decl; no longer used or needed.
3600 (digit_to_number): Move to lread.c.
3601 (Fstring_to_number): Use new string_to_number function, to be
3602 consistent with how the Lisp reader treats infinities and NaNs.
3603 Do not assume that floating-point numbers represent EMACS_INT
3604 without losing information; this is not true on most 64-bit hosts.
3605 Avoid double-rounding errors, by insisting on integers when
3606 parsing non-base-10 numbers, as the documentation specifies.
3607 * lisp.h (string_to_number): New decl, replacing ...
3608 (isfloat_string): Remove.
3609 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3610 (read1): Do not accept +. and -. as integers; this
3611 appears to have been a coding error. Similarly, do not accept
3612 strings like +-1e0 as floating point numbers. Do not report
3613 overflow for integer overflows unless the base is not 10 which
3614 means we have no simple and reliable way to continue.
3615 Break out the floating-point parsing into a new
3616 function string_to_number, so that Fstring_to_number parses
3617 floating point numbers consistently with the Lisp reader.
3618 (digit_to_number): Move here from data.c. Make it static inline.
3619 (E_CHAR, EXP_INT): Remove, replacing with ...
3620 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3621 (string_to_number): New function, replacing isfloat_string.
3622 This function checks for valid syntax and produces the resulting
3623 Lisp float number too. Rework it so that string-to-number
3624 no longer mishandles examples like "1.0e+". Use strtoumax,
3625 so that overflow for non-base-10 numbers is reported only when
3626 there's no portable and simple way to convert to floating point.
3627
3628 * textprop.c (set_text_properties_1): Rewrite for clarity,
3629 and to avoid GCC warning about integer overflow.
3630
3631 * intervals.h (struct interval): Use EMACS_INT for members
3632 where EMACS_UINT might cause problems. See
3633 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3634 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3635 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3636 All uses changed.
3637 (offset_intervals): Tell GCC not to worry about length overflow
3638 when negating a negative length.
3639
3640 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3641 (overrun_check_free): Likewise.
3642
3643 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3644 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3645 word size.
3646
3647 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3648 (gnutls_make_error): Rename local to avoid shadowing.
3649 (gnutls_emacs_global_deinit): ifdef out; not used.
3650 (Fgnutls_boot): Use const for pointer to readonly storage.
3651 Comment out unused local. Fix pointer signedness problems.
3652
3653 * lread.c (openp): Don't stuff size_t into an 'int'.
3654 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3655 about possible signed overflow.
3656
3657 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3658 (GDK_KEY_g): Don't define if already defined.
3659 (xg_prepare_tooltip): Avoid pointer signedness problem.
3660 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3661
3662 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3663 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3664
3665 * xfns.c (Fx_window_property): Simplify a bit,
3666 to make a bit faster and to avoid GCC 4.6.0 warning.
3667 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3668
3669 * fns.c (internal_equal): Don't assume size_t fits in int.
3670
3671 * alloc.c (compact_small_strings): Tighten assertion a little.
3672
3673 Replace pEd with more-general pI, and fix some printf arg casts.
3674 * lisp.h (pI): New macro, generalizing old pEd macro to other
3675 conversion specifiers. For example, use "...%"pI"d..." rather
3676 than "...%"pEd"...".
3677 (pEd): Remove. All uses replaced with similar uses of pI.
3678 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3679 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3680 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3681 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3682 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3683 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3684 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3685 64-bit hosts.
3686 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3687 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3688 * print.c (safe_debug_print, print_object): Likewise.
3689 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3690 to int.
3691 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3692 avoiding the 0 flag, which is not portable.
3693 * process.c (Fmake_network_process): Use pI to avoid cast.
3694 * region-cache.c (pp_cache): Likewise.
3695 * xdisp.c (decode_mode_spec): Likewise.
3696 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3697 behavior on 64-bit hosts with printf arg.
3698 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3699 (x_stop_queuing_selection_requests): Likewise.
3700 (x_get_window_property): Don't truncate byte count to an 'int'
3701 when tracing.
3702
3703 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3704 here, since it parses constructs like leading '-' and spaces,
3705 which are not wanted; and it overflows with large numbers.
3706 Instead, simply match F[0-9]+, which is what is wanted anyway.
3707
3708 * alloc.c: Remove unportable assumptions about struct layout.
3709 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3710 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3711 (allocate_vectorlike, make_pure_vector): Use the new macros,
3712 plus offsetof, to remove unportable assumptions about struct layout.
3713 These assumptions hold on all porting targets that I know of, but
3714 they are not guaranteed, they're easy to remove, and removing them
3715 makes further changes easier.
3716
3717 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3718 This doesn't fix a bug but makes the code clearer.
3719 (string_overrun_cookie): Now const. Use initializers that
3720 don't formally overflow signed char, to avoid warnings.
3721 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3722 can cause Emacs to crash when string overrun checking is enabled.
3723 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3724 multiple of sizeof (EMACS_INT); it need not be, if
3725 alignof(EMACS_INT) < sizeof (EMACS_INT).
3726 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3727
3728 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3729
3730 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3731
3732 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3733
3734 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3735 supposed to be handshaking. (Bug#8556)
3736 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3737
3738 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3739
3740 * lisp.h (Qdebug): List symbol.
3741 * eval.c (Qdebug): Restore global linkage.
3742 * keyboard.c (debug-on-event): New variable.
3743 (handle_user_signal): Break into debugger when debug-on-event
3744 matches the current signal symbol.
3745
3746 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3747
3748 * alloc.c (check_sblock, check_string_bytes)
3749 (check_string_free_list): Convert to standard C.
3750
3751 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3752
3753 * w32.c (emacs_gnutls_push): Fix typo.
3754
3755 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3756
3757 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3758 "cast to pointer from integer of different size".
3759
3760 Improve doprnt and its use in verror. (Bug#8545)
3761 * doprnt.c (doprnt): Document the set of format control sequences
3762 supported by the function. Use SAFE_ALLOCA instead of always
3763 using `alloca'.
3764
3765 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3766 is one byte too soon. Don't use xrealloc; instead xfree and
3767 xmalloc anew.
3768
3769 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3770
3771 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3772 callbacks stage.
3773
3774 * gnutls.c: Renamed global_initialized to
3775 gnutls_global_initialized. Added internals for the
3776 :verify-hostname-error, :verify-error, and :verify-flags
3777 parameters of `gnutls-boot' and documented those parameters in the
3778 docstring. Start callback support.
3779 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3780 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3781 on error. Return error code.
3782 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3783 (emacs_gnutls_read): Likewise.
3784 (Fgnutls_boot): Return handshake error code.
3785 (emacs_gnutls_handle_error): New function.
3786 (wsaerror_to_errno): Likewise.
3787
3788 * w32.h (emacs_gnutls_pull): Add prototype.
3789 (emacs_gnutls_push): Likewise.
3790
3791 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3792 (emacs_gnutls_push): Likewise.
3793
3794 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3795
3796 * process.c (wait_reading_process_output): Check if GnuTLS
3797 buffered some data internally if no FDs are set for TLS
3798 connections.
3799
3800 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3801 (LIBS): Link to USER_LIBS.
3802 ($(BLD)/gnutls.$(0)): New target.
3803
3804 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3805
3806 * xdisp.c (handle_single_display_spec): Rename the
3807 display_replaced_before_p argument into display_replaced_p, to
3808 make it consistent with the commentary. Fix typos in the
3809 commentary.
3810
3811 * textprop.c (syms_of_textprop): Remove dead code.
3812 (copy_text_properties): Delete obsolete commentary about an
3813 interface that was deleted long ago. Fix typos in the description
3814 of arguments.
3815
3816 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3817 to changes in oldXMenu/XMenu.h from 2011-04-16.
3818 <menu_help_message, prev_menu_help_message>: Constify.
3819 (IT_menu_make_room): menu->help_text is now `const char **';
3820 adjust.
3821
3822 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3823 to changes in oldXMenu/XMenu.h from 2011-04-16.
3824 (struct XMenu): Declare `help_text' `const char **'.
3825
3826 * xfaces.c <Qunspecified>: Make extern again.
3827
3828 * syntax.c: Include sys/types.h before including regex.h, as
3829 required by Posix.
3830
3831 * doc.c (get_doc_string): Improve the format passed to `error'.
3832
3833 * doprnt.c (doprnt): Improve commentary.
3834
3835 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3836
3837 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3838 them with etags.
3839
3840 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3841 changes in globals.h immediately force recompilation.
3842 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3843 $(CURDIR)/s/ms-w32.h.
3844 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3845
3846 * character.c (Fchar_direction): Function deleted.
3847 (syms_of_character): Don't defsubr it.
3848 <char-direction-table>: Deleted.
3849
3850 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3851
3852 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3853 * doprnt.c: Include limits.h.
3854 (SIZE_MAX): New macro.
3855 (doprnt): Return a size_t value. 2nd arg is now size_t.
3856 Many local variables are now size_t instead of int or unsigned.
3857 Improve overflow protection. Support `l' modifier for integer
3858 conversions. Support %l conversion. Don't assume an EMACS_INT
3859 argument for integer conversions and for %c.
3860
3861 * lisp.h (doprnt): Restore prototype.
3862
3863 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3864 $(SRC)/character.h.
3865
3866 * Makefile.in (base_obj): Add back doprnt.o.
3867
3868 * deps.mk (doprnt.o): Add back prerequisites.
3869 (callint.o): Depend on character.h.
3870
3871 * eval.c (internal_lisp_condition_case): Include the handler
3872 representation in the error message.
3873 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3874 when breaking from the loop.
3875
3876 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3877
3878 * callint.c (Fcall_interactively): When displaying error message
3879 about invalid control letter, pass the character's codepoint, not
3880 a pointer to its multibyte form. Improve display of the character
3881 in octal and display also its hex code.
3882
3883 * character.c (char_string): Use %x to display the (unsigned)
3884 codepoint of an invalid character, to avoid displaying a bogus
3885 negative value.
3886
3887 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3888 `error', not SYMBOL_NAME itself.
3889
3890 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3891 character arguments to `error'.
3892
3893 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3894 to `error' in error message about FINAL_CHAR argument. Make sure
3895 FINAL_CHAR is a character, and use %c when it is passed as
3896 argument to `error'.
3897
3898 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3899
3900 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3901
3902 * w32.c: Include <time.h>.
3903 (sys_localtime): New function.
3904
3905 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3906
3907 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3908
3909 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3910
3911 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3912
3913 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3914 zombies (Bug#8467).
3915
3916 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3917
3918 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3919 gl_state.e_property when gl_state.object is Qt.
3920
3921 * insdel.c (make_gap_larger): Remove limitation of buffer size
3922 to <= INT_MAX.
3923
3924 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3925
3926 * xdisp.c (lookup_glyphless_char_display)
3927 (produce_glyphless_glyph): Handle cons cell entry in
3928 glyphless-char-display.
3929 (Vglyphless_char_display): Document it.
3930
3931 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3932 glyphless-char-display.
3933
3934 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3935
3936 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3937
3938 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3939
3940 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3941 definition for no-X builds.
3942
3943 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3944
3945 Static checks with GCC 4.6.0 and non-default toolkits.
3946
3947 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3948
3949 * process.c (keyboard_bit_set): Define only if SIGIO.
3950 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3951 (send_process): Repair possible setjmp clobbering.
3952
3953 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3954
3955 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3956
3957 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3958
3959 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3960 Define only if needed.
3961
3962 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3963 by pacifying GCC about it. Maybe it's time to retire it?
3964 * xfaces.c (USG, __TIMEVAL__): Likewise.
3965
3966 * dispextern.h (struct redisplay_interface): Rename param
3967 to avoid shadowing.
3968 * termhooks.h (struct terminal): Likewise.
3969 * xterm.c (xembed_send_message): Likewise.
3970
3971 * insdel.c (make_gap_smaller): Define only if
3972 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3973
3974 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3975 it.
3976
3977 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3978 so that we aren't warned about unused symbols.
3979
3980 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3981
3982 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3983
3984 * xfns.c (x_real_positions): Mark locals as initialized.
3985
3986 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3987
3988 * xterm.c: Fix problems found by static analysis with other toolkits.
3989 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3990 (x_dispatch_event): Declare static if USE_GTK, and
3991 define if USE_GTK || USE_X_TOOLKIT.
3992 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3993 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3994 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3995 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3996
3997 * xmenu.c (menu_help_callback): Pointer type fixes.
3998 Use const pointers when pointing at readonly data. Avoid pointer
3999 signedness clashes.
4000 (FALSE): Remove unused macro.
4001 (update_frame_menubar): Remove unused decl.
4002
4003 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4004
4005 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4006 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4007 (single_menu_item): Rename local to avoid shadowing.
4008
4009 * keyboard.c (make_lispy_event): Remove unused local var.
4010
4011 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4012 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4013
4014 * bitmaps: Change bitmaps from unsigned char back to the X11
4015 compatible char. Avoid the old compiler warnings about
4016 out-of-range initializers by using, for example, '\xab' rather
4017 than 0xab.
4018
4019 * xgselect.c (xgselect_initialize): Check vs interface
4020 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4021
4022 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4023
4024 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4025 to read-only memory.
4026
4027 * fns.c (vector): Remove; this old hack is no longer needed.
4028
4029 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4030 Remove unused var.
4031 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4032
4033 * xrdb.c (x_load_resources): Omit unused local.
4034
4035 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4036 (x_window): Rename locals to avoid shadowing.
4037 (USG): Use the kludged USG macro, to pacify gcc.
4038
4039 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4040 (x_term_init): Remove local to avoid shadowing.
4041
4042 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4043
4044 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4045 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4046
4047 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4048
4049 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4050
4051 Fix regex.c, syntax.c and friends for buffers > 2GB.
4052 * syntax.h (struct gl_state_s): Declare character position members
4053 EMACS_INT.
4054
4055 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4056
4057 * textprop.c (verify_interval_modification, interval_of):
4058 Declare arguments EMACS_INT.
4059
4060 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4061 EMACS_INT.
4062
4063 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4064
4065 * indent.c (Fvertical_motion): Local variable it_start is now
4066 EMACS_INT.
4067
4068 * regex.c (re_match, re_match_2, re_match_2_internal)
4069 (bcmp_translate, regcomp, regexec, print_double_string)
4070 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4071 (re_compile_pattern, re_exec): Declare arguments and local
4072 variables `size_t' and `ssize_t' and return values `regoff_t', as
4073 appropriate.
4074 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4075 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4076 <compile_stack_type>: `size' and `avail' are now `size_t'.
4077
4078 * regex.h <regoff_t>: Use ssize_t, not int.
4079 (re_search, re_search_2, re_match, re_match_2): Arguments that
4080 specify buffer/string position and length are now ssize_t and
4081 size_t. Return type is regoff_t.
4082
4083 2011-04-16 Ben Key <bkey76@gmail.com>
4084
4085 * nsfont.m: Fixed bugs in ns_get_family and
4086 ns_descriptor_to_entity that were caused by using free to
4087 deallocate memory blocks that were allocated by xmalloc (via
4088 xstrdup). This caused Emacs to crash when compiled with
4089 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4090 --enable-checking=xmallocoverrun). xfree is now used to
4091 deallocate these memory blocks.
4092
4093 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4094
4095 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4096
4097 emacs_write: Accept and return EMACS_INT for sizes.
4098 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4099 et seq.
4100 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4101 Accept and return EMACS_INT.
4102 (emacs_gnutls_write): Return the number of bytes written on
4103 partial writes.
4104 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4105 (emacs_read, emacs_write): Remove check for negative size, as the
4106 Emacs source code has been audited now.
4107 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4108 (emacs_read, emacs_write): Use it.
4109 * process.c (send_process): Adjust to the new signatures of
4110 emacs_write and emacs_gnutls_write. Do not attempt to store
4111 a byte offset into an 'int'; it might overflow.
4112 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4113
4114 * sound.c: Don't assume sizes fit in 'int'.
4115 (struct sound_device.period_size, alsa_period_size):
4116 Return EMACS_INT, not int.
4117 (struct sound_device.write, vox_write, alsa_write):
4118 Accept EMACS_INT, not int.
4119 (wav_play, au_play): Use EMACS_INT to store sizes and to
4120 record read return values.
4121
4122 2011-04-15 Ben Key <bkey76@gmail.com>
4123
4124 * keyboard.c (Qundefined): Don't declare static since it is used
4125 in nsfns.m.
4126 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4127 static since they are used in nsfont.m.
4128
4129 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4130
4131 * process.c (Qprocessp): Don't declare static.
4132 * lisp.h (Qprocessp): Declare again.
4133
4134 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4135
4136 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4137
4138 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4139
4140 Improve C-level modularity by making more things 'static'.
4141
4142 Don't publish debugger-only interfaces to other modules.
4143 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4144 (verify_bytepos, count_markers): Move decls to the only modules
4145 that need them.
4146 * region-cache.h (pp_cache): Likewise.
4147 * window.h (check_all_windows): Likewise.
4148 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4149
4150 * sysdep.c (croak): Now static, if
4151 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4152 * syssignal.h (croak): Declare only if not static.
4153
4154 * alloc.c (refill_memory_reserve): Now static if
4155 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4156 * lisp.h (refill_memory_reserve): Declare only if not static.
4157
4158 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4159 Define only if USE_LUCID.
4160
4161 * xrdb.c (x_customization_string, x_rm_string): Now static.
4162
4163 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4164 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4165
4166 * xdisp.c (draw_row_with_mouse_face): Now static.
4167 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4168
4169 * window.h (check_all_windows): Mark externally visible.
4170
4171 * window.c (window_deletion_count): Now static.
4172
4173 * undo.c: Make symbols static if they're not exported.
4174 (last_undo_buffer, last_boundary_position, pending_boundary):
4175 Now static.
4176
4177 * textprop.c (interval_insert_behind_hooks): Now static.
4178 (interval_insert_in_front_hooks): Likewise.
4179
4180 * term.c: Make symbols static if they're not exported.
4181 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4182 (max_frame_lines, tty_set_terminal_modes):
4183 (tty_reset_terminal_modes, tty_turn_off_highlight):
4184 (get_tty_terminal): Now static.
4185 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4186 * termhooks.h (term_mouse_moveto): Do not declare if
4187 HAVE_WINDOW_SYSTEM.
4188 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4189 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4190
4191 * sysdep.c: Make symbols static if they're not exported.
4192 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4193 Now static.
4194 (sigprocmask_set, full_mask): Remove; unused.
4195 (wait_debugging): Mark as visible.
4196 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4197 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4198
4199 * syntax.c (syntax_temp): Define only if !__GNUC__.
4200
4201 * sound.c (current_sound_device, current_sound): Now static.
4202
4203 * search.c (searchbufs, searchbuf_head): Now static.
4204
4205 * scroll.c (scroll_cost): Remove; unused.
4206 * dispextern.h (scroll_cost): Remove decl.
4207
4208 * region-cache.h (pp_cache): Mark as externally visible.
4209
4210 * process.c: Make symbols static if they're not exported.
4211 (process_tick, update_tick, create_process, chan_process):
4212 (Vprocess_alist, proc_buffered_char, datagram_access):
4213 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4214 (deactivate_process): Mark defn as static, as well as decl.
4215 * lisp.h (create_process): Remove decl.
4216 * process.h (chan_process, Vprocess_alist): Remove decls.
4217
4218 * print.c: Make symbols static if they're not exported.
4219 (print_depth, new_backquote_output, being_printed, print_buffer):
4220 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4221 (print_interval, print_number_index, initial_stderr_stream):
4222 Now static.
4223 * lisp.h (Fprinc): Remove decl.
4224 (debug_output_compilation_hack): Mark as externally visible.
4225
4226 * sysdep.c (croak): Move decl from here to syssignal.h.
4227 * syssignal.h (croak): Put it here, so the API can be checked when
4228 'croak' is called from dissociate_if_controlling_tty.
4229
4230 * minibuf.c: Make symbols static if they're not exported.
4231 (minibuf_save_list, choose_minibuf_frame): Now static.
4232 * lisp.h (choose_minibuf_frame): Remove decl.
4233
4234 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4235
4236 * lread.c: Make symbols static if they're not exported.
4237 (read_objects, initial_obarray, oblookup_last_bucket_number):
4238 Now static.
4239 (make_symbol): Remove; unused.
4240 * lisp.h (initial_obarray, make_symbol): Remove decls.
4241
4242 * keyboard.c: Make symbols static if they're not exported.
4243 (single_kboard, recent_keys_index, total_keys, recent_keys):
4244 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4245 (this_single_command_key_start, echoing, last_auto_save):
4246 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4247 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4248 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4249 (Vlispy_mouse_stem, double_click_count):
4250 Now static.
4251 (force_auto_save_soon): Define only if SIGDANGER.
4252 (ignore_mouse_drag_p): Now static if
4253 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4254 (print_help): Remove; unused.
4255 (stop_character, last_timer_event): Mark as externally visible.
4256 * keyboard.h (ignore_mouse_drag_p): Declare only if
4257 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4258 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4259 * lisp.h (echoing): Remove decl.
4260 (force_auto_save_soon): Declare only if SIGDANGER.
4261 * xdisp.c (redisplay_window): Simplify code, to make it more
4262 obvious that ignore_mouse_drag_p is not accessed if !defined
4263 USE_GTK && !defined HAVE_NS.
4264
4265 * intervals.c: Make symbols static if they're not exported.
4266 (merge_properties_sticky, merge_interval_right, delete_interval):
4267 Now static.
4268 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4269
4270 * insdel.c: Make symbols static if they're not exported.
4271 However, leave prepare_to_modify_buffer alone. It's never
4272 called from outside this function, but that appears to be a bug.
4273 (combine_after_change_list, combine_after_change_buffer):
4274 (adjust_after_replace, signal_before_change): Now static.
4275 (adjust_after_replace_noundo): Remove; unused.
4276 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4277 (signal_before_change): Remove decls.
4278
4279 * indent.c (val_compute_motion, val_vmotion): Now static.
4280
4281 * image.c: Make symbols static if they're not exported.
4282 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4283 if USE_GTK.
4284 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4285 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4286
4287 * fringe.c (standard_bitmaps): Now static.
4288 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4289
4290 * frame.c: Make symbols static if they're not exported.
4291 (x_report_frame_params, make_terminal_frame): Now static.
4292 (get_frame_param): Now static, unless HAVE_NS.
4293 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4294 (x_get_resource_string): Remove; not used.
4295 * frame.h (make_terminal_frame, x_report_frame_params):
4296 (x_get_resource_string); Remove decls.
4297 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4298 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4299
4300 * font.c, fontset.c: Make symbols static if they're not exported.
4301 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4302 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4303 * font.c (font_close_object): Now static.
4304 * font.h (font_close_object): Remove.
4305 * fontset.c (FONTSET_OBJLIST): Remove.
4306 (free_realized_fontset) #if-0 the body, which does nothing.
4307 (face_suitable_for_char_p): #if-0, as it's never called.
4308 * fontset.h (face_suitable_for_char_p): Remove decl.
4309 * xfaces.c (face_at_string_position):
4310 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4311 since 0 is always ASCII.
4312
4313 * fns.c (weak_hash_tables): Now static.
4314
4315 * fileio.c: Make symbols static if they're not exported.
4316 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4317 (Vwrite_region_annotation_buffers): Now static.
4318
4319 * eval.c: Make symbols static if they're not exported.
4320 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4321 * lisp.h (backtrace_list): Remove decl.
4322
4323 * emacs.c: Make symbols static if they're not exported.
4324 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4325 (fatal_error_code, fatal_error_signal_hook, standard_args):
4326 Now static.
4327 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4328 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4329 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4330 * lisp.h (fatal_error_signal_hook): Remove decl.
4331 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4332
4333 * editfns.c: Move a (normally-unused) function to its only use.
4334 * editfns.c, lisp.h (get_operating_system_release): Remove.
4335 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4336 worth the hassle of breaking this out.
4337
4338 * xterm.c: Make symbols static if they're not exported.
4339 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4340 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4341 (x_destroy_window, x_delete_display):
4342 Now static.
4343 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4344 (x_mouse_leave): Remove; unused.
4345 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4346 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4347 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4348 Remove decls.
4349 (x_mouse_leave): Declare only if WINDOWSNT.
4350 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4351 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4352 USE_X_TOOLKIT.
4353
4354 * ftxfont.c: Make symbols static if they're not exported.
4355 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4356 HAVE_FREETYPE.
4357 * font.h (ftxfont_driver): Likewise.
4358
4359 * xfns.c: Make symbols static if they're not exported.
4360 (x_last_font_name, x_display_info_for_name):
4361 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4362 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4363 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4364 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4365 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4366 (last_show_tip_args): Now static.
4367 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4368 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4369 (x_screen_planes): Remove; unused.
4370 * dispextern.h (x_screen_planes): Remove decl.
4371
4372 * dispnew.c: Make symbols static if they're not exported.
4373 * dispextern.h (redraw_garbaged_frames, scrolling):
4374 (increment_row_positions): Remove.
4375 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4376 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4377 Now static.
4378 (redraw_garbaged_frames): Remove; unused.
4379
4380 * xfaces.c: Make symbols static if they're not exported.
4381 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4382 Remove decls.
4383 * xterm.h (defined_color): Remove decls.
4384 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4385 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4386 (menu_face_changed_default, defined_color, free_realized_face):
4387 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4388 (ascii_face_of_lisp_face): Remove; unused.
4389
4390 * xdisp.c: Make symbols static if they're not exported.
4391 * dispextern.h (scratch_glyph_row, window_box_edges):
4392 (glyph_to_pixel_coords, set_cursor_from_row):
4393 (get_next_display_element, set_iterator_to_next):
4394 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4395 (show_mouse_face): Remove decls
4396 * frame.h (message_buf_print): Likewise.
4397 * lisp.h (pop_message, set_message, check_point_in_composition):
4398 Likewise.
4399 * xterm.h (set_vertical_scroll_bar): Likewise.
4400 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4401 (message_buf_print, scratch_glyph_row, displayed_buffer):
4402 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4403 (get_next_display_element, show_mouse_face, window_box_edges):
4404 (frame_to_window_pixel_xy, check_point_in_composition):
4405 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4406 (glyph_to_pixel_coords): Remove; unused.
4407
4408 * dired.c (file_name_completion): Now static.
4409
4410 * dbusbind.c (xd_in_read_queued_messages): Now static.
4411
4412 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4413 * data.c (circular_list_error): Remove.
4414
4415 * commands.h (last_point_position, last_point_position_buffer):
4416 (last_point_position_window): Remove decls.
4417 * keyboard.c: Make these variables static.
4418
4419 * coding.h (coding, code_convert_region, encode_coding_gap):
4420 Remove decls.
4421 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4422 (iso_code_class, detect_coding, code_convert_region): Now static.
4423 (encode_coding_gap): Remove; unused.
4424
4425 * chartab.c (chartab_chars, chartab_bits): Now static.
4426
4427 * charset.h (charset_iso_8859_1): Remove decl.
4428 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4429 Now static.
4430
4431 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4432 * ccl.c (Vccl_program_table): Now static.
4433 (check_ccl_update): Remove; unused.
4434
4435 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4436 * category.h: ... from here.
4437 * category.c (check_category_table, set_category_set): Now static.
4438
4439 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4440 * lisp.h: Remove these decls.
4441
4442 * buffer.c (buffer_count): Remove unused var.
4443
4444 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4445 so that it's not optimized away.
4446 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4447 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4448 exported only to the debugger.
4449
4450 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4451 * atimer.h (run_all_atimers): Remove; not exported.
4452
4453 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4454 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4455 was inaccessible from Lisp.
4456 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4457 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4458
4459 alloc.c: Import and export fewer symbols, and remove unused items.
4460 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4461 is defined.
4462 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4463 it's not optimized away by whole-program optimization.
4464 (message_enable_multibyte, free_misc): Remove.
4465 (catchlist, handlerlist, mark_backtrace):
4466 Declare only if BYTE_MARK_STACK.
4467 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4468 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4469 (message_enable_multibyte): Remove decl.
4470 (free_misc, interval_free_list, float_block, float_block_index):
4471 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4472 (cons_free_list, last_marked_index):
4473 Now static.
4474 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4475 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4476 (mark_backtrace): Define only if BYTE_MARK_STACK.
4477 * xdisp.c (message_enable_multibyte): Now static.
4478
4479 Declare Lisp_Object Q* variables to be 'static' if not exported.
4480 This makes it easier for human readers (and static analyzers)
4481 to see whether these variables are used from other modules.
4482 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4483 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4484 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4485 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4486 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4487 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4488 * xmenu.c, xselect.c:
4489 Declare Q* vars static if they are not used in other modules.
4490 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4491 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4492 Remove decls of unexported vars.
4493 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4494
4495 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4496
4497 Make Emacs functions such as Fatom 'static' by default.
4498 This makes it easier for human readers (and static analyzers)
4499 to see whether these functions can be called from other modules.
4500 DEFUN now defines a static function. To make the function external
4501 so that it can be used in other C modules, use the new macro DEFUE.
4502 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4503 (Finit_image_library):
4504 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4505 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4506 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4507 Remove decls, since these functions are now static.
4508 (Funintern, Fget_internal_run_time): New decls, since these functions
4509 were already external.
4510
4511 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4512 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4513 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4514 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4515 * keyboard.c, keymap.c, lread.c:
4516 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4517 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4518 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4519 Mark functions with DEFUE instead of DEFUN,
4520 if they are used in other modules.
4521 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4522 decls for now-static functions.
4523 * buffer.h (Fdelete_overlay): Remove decl.
4524 * callproc.c (Fgetenv_internal): Mark as internal.
4525 * composite.c (Fremove_list_of_text_properties): Remove decl.
4526 (Fcomposition_get_gstring): New forward static decl.
4527 * composite.h (Fcomposite_get_gstring): Remove decl.
4528 * dired.c (Ffile_attributes): New forward static decl.
4529 * doc.c (Fdocumntation_property): New forward static decl.
4530 * eval.c (Ffetch_bytecode): New forward static decl.
4531 (Funintern): Remove extern decl; now in .h file where it belongs.
4532 * fileio.c (Fmake_symbolic_link): New forward static decl.
4533 * image.c (Finit_image_library): New forward static decl.
4534 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4535 * intervals.h (Fprevious_property_change):
4536 (Fremove_list_of_text_properties): Remove decls.
4537 * keyboard.c (Fthis_command_keys): Remove decl.
4538 (Fcommand_execute): New forward static decl.
4539 * keymap.c (Flookup_key): New forward static decl.
4540 (Fcopy_keymap): Now static.
4541 * keymap.h (Flookup_key): Remove decl.
4542 * process.c (Fget_process): New forward static decl.
4543 (Fprocess_datagram_address): Mark as internal.
4544 * syntax.c (Fsyntax_table_p): New forward static decl.
4545 (skip_chars): Remove duplicate decl.
4546 * textprop.c (Fprevious_property_change): New forward static decl.
4547 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4548 Now internal.
4549 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4550 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4551
4552 * editfns.c (Fformat): Remove unreachable code.
4553
4554 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4555
4556 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4557 change. (Bug#8496)
4558
4559 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4560
4561 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4562 when at ZV. (Bug#8487)
4563
4564 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4565
4566 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4567 (Bug#8437)
4568 * keyboard.c (parse_tool_bar_item): Likewise.
4569 * sound.c (sound_cleanup, alsa_close): Likewise.
4570 * termcap.c (tgetent): Likewise.
4571 * xfns.c (x_default_font_parameter): Likewise.
4572 * xsettings.c (read_and_apply_settings): Likewise.
4573
4574 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4575 (overrun_check_free): Protoize.
4576
4577 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4578
4579 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4580 since callers should never pass a negative size.
4581 Change the signature to match that of plain 'read' and 'write'; see
4582 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4583 * lisp.h: Update prototypes of emacs_write and emacs_read.
4584
4585 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4586
4587 * xdisp.c (redisplay_window): Don't try to determine the character
4588 position of the scroll margin if the window start point w->startp
4589 is outside the buffer's accessible region. (Bug#8468)
4590
4591 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4592
4593 Fix write-region and its subroutines for buffers > 2GB.
4594 * fileio.c (a_write, e_write): Modify declaration of arguments and
4595 local variables to support buffers larger than 2GB.
4596 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4597
4598 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4599 argument, local variables, and return value.
4600
4601 * lisp.h: Update prototypes of emacs_write and emacs_read.
4602
4603 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4604
4605 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4606
4607 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4608
4609 Fix more problems found by GCC 4.6.0's static checks.
4610
4611 * xdisp.c (vmessage): Use a better test for character truncation.
4612
4613 * charset.c (load_charset_map): <, not <=, for optimization,
4614 and to avoid potential problems with integer overflow.
4615 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4616 * casetab.c (set_identity, shuffle): Likewise.
4617 * editfns.c (Fformat): Likewise.
4618 * syntax.c (skip_chars): Likewise.
4619
4620 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4621 This also lets GCC 4.6.0 generate slightly better loop code.
4622
4623 * callint.c (Fcall_interactively): <, not <=, for optimization.
4624 (Fcall_interactively): Count the number of arguments produced,
4625 not the number of arguments given. This is simpler and lets GCC
4626 4.6.0 generate slightly better code.
4627
4628 * ftfont.c: Distingish more carefully between FcChar8 and char.
4629 The previous code passed unsigned char * to a functions like
4630 strlen and xstrcasecmp that expect char *, which does not
4631 conform to the C standard.
4632 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4633 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4634 char * when the C standard requires it.
4635
4636 * keyboard.c (read_char): Remove unused var.
4637
4638 * eval.c: Port to Windows vsnprintf (Bug#8435).
4639 Include <limits.h>.
4640 (SIZE_MAX): Define if the headers do not.
4641 (verror): Do not give up if vsnprintf returns a negative count.
4642 Instead, grow the buffer. This ports to Windows vsnprintf, which
4643 does not conform to C99. Problem reported by Eli Zaretskii.
4644 Also, simplify the allocation scheme, by avoiding the need for
4645 calling realloc, and removing the ALLOCATED variable.
4646
4647 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4648
4649 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4650 But keep the doprint source code for now, as we might revamp it
4651 and use it again (Bug#8435).
4652 * lisp.h (doprnt): Remove.
4653 * Makefile.in (base_obj): Remove doprnt.o.
4654 * deps.mk (doprnt.o): Remove.
4655
4656 error: Print 32- and 64-bit integers portably (Bug#8435).
4657 Without this change, on typical 64-bit hosts error ("...%d...", N)
4658 was used to print both 32- and 64-bit integers N, which relied on
4659 undefined behavior.
4660 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4661 New macro.
4662 * lisp.h (error, verror): Mark as printf-like functions.
4663 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4664 Report overflow in size calculations when allocating printf buffer.
4665 Do not truncate output string at its first null byte.
4666 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4667 Truncate the output at a character boundary, since vsnprintf does not
4668 do that.
4669 * charset.c (check_iso_charset_parameter): Convert internal
4670 character to string before calling 'error', since %c now has the
4671 printf meaning.
4672 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4673 overflow when computing char to be passed to 'error'. Do not
4674 pass Lisp_Object to 'error'; pass the integer instead.
4675 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4676 formatted with plain %d.
4677
4678 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4679
4680 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4681
4682 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4683
4684 * xterm.c (x_catch_errors): Remove duplicate declaration.
4685
4686 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4687
4688 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4689
4690 2011-04-10 Jim Meyering <meyering@redhat.com>
4691
4692 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4693 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4694 return ssize_t not "int", and use size_t as the buffer length.
4695 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4696 * gnutls.h: Update declarations.
4697 * process.c (read_process_output): Use ssize_t, to match.
4698 (send_process): Likewise.
4699
4700 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4701
4702 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4703
4704 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4705
4706 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4707 Use unsigned char, to match FcChar8 type definition.
4708
4709 * xterm.c (handle_one_xevent):
4710 * xmenu.c (create_and_show_popup_menu):
4711 * xselect.c (x_decline_selection_request)
4712 (x_reply_selection_request): Avoid type-punned deref of X events.
4713
4714 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4715
4716 Fix some uses of `int' instead of EMACS_INT.
4717 * search.c (string_match_1, fast_string_match)
4718 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4719 (scan_buffer, find_next_newline_no_quit)
4720 (find_before_next_newline, search_command, Freplace_match)
4721 (Fmatch_data): Make some `int' variables be EMACS_INT.
4722
4723 * xdisp.c (display_count_lines): 3rd argument and return value now
4724 EMACS_INT. All callers changed.
4725 (pint2hrstr): Last argument is now EMACS_INT.
4726
4727 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4728 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4729 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4730 (decode_coding_utf_16, decode_coding_emacs_mule)
4731 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4732 (decode_coding_ccl, decode_coding_charset)
4733 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4734 (decode_coding_iso_2022, decode_coding_emacs_mule)
4735 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4736 <char_offset, last_offset>: Declare EMACS_INT.
4737 (encode_coding_utf_8, encode_coding_utf_16)
4738 (encode_coding_emacs_mule, encode_invocation_designation)
4739 (encode_designation_at_bol, encode_coding_iso_2022)
4740 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4741 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4742 Declare EMACS_INT.
4743 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4744 (encode_invocation_designation): Last argument P_NCHARS is now
4745 EMACS_INT.
4746 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4747 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4748
4749 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4750 All users changed.
4751
4752 * ccl.c (Fccl_execute_on_string): Declare some variables
4753 EMACS_INT.
4754
4755 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4756
4757 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4758
4759 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4760
4761 * process.c (Fformat_network_address): Doc fix.
4762
4763 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4764
4765 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4766
4767 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4768
4769 * keyboard.c (read_char): Call Lisp function help-form-show,
4770 instead of using internal_with_output_to_temp_buffer.
4771 (Qhelp_form_show): New var.
4772 (syms_of_keyboard): Use DEFSYM macro.
4773
4774 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4775
4776 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4777
4778 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4779
4780 * process.c (Flist_processes): Remove to Lisp.
4781 (list_processes_1): Delete.
4782
4783 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4784
4785 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4786
4787 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4788
4789 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4790
4791 Fix more problems found by GCC 4.6.0's static checks.
4792
4793 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4794
4795 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4796
4797 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4798
4799 * xdisp.c (vmessage): Mark as a printf-like function.
4800
4801 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4802
4803 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4804
4805 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4806 printf-like functions.
4807 (tiff_load): Add casts to remove these marks before passing them
4808 to system-supplied API.
4809
4810 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4811
4812 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4813 This avoids several warnings with gcc -Wstrict-overflow.
4814 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4815 directly, rather than having caller test rule sign. This avoids
4816 some unnecessary tests.
4817 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4818 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4819 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4820
4821 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4822 (xfont_open): Avoid unnecessary tests.
4823
4824 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4825
4826 * composite.h, composite.c (composition_gstring_put_cache):
4827 Use EMACS_INT, not int, for length.
4828
4829 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4830 breaking out part of COMPOSITION_DECODE_RULE.
4831 (COMPOSITION_DECODE_RULE): Use it.
4832 * composite.c (get_composition_id): Remove unused local vars,
4833 by using the new macro.
4834
4835 * textprop.c (set_text_properties_1): Change while to do-while,
4836 since the condition is always true at first.
4837
4838 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4839 (interval_deletion_adjustment): Return unsigned value.
4840 All uses changed.
4841
4842 * process.c (list_processes_1, create_pty, read_process_output):
4843 (exec_sentinel): Remove vars that were set but not used.
4844 (create_pty): Remove unnecessary "volatile"s.
4845 (Fnetwork_interface_info): Avoid possibility of int overflow.
4846 (read_process_output): Do adaptive read buffering even if carryover.
4847 (read_process_output): Simplify nbytes computation if buffered.
4848
4849 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4850
4851 * syntax.c (scan_words): Remove var that was set but not used.
4852 (update_syntax_table): Use unsigned instead of int.
4853
4854 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4855 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4856 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4857
4858 * print.c (print_error_message): Avoid int overflow.
4859
4860 * font.c (font_list_entities): Redo for clarity,
4861 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4862
4863 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4864 (font_score): Avoid potential overflow in diff calculation.
4865
4866 * fns.c (substring_both): Remove var that is set but not used.
4867 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4868
4869 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4870
4871 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4872 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4873 can always succeed if overflow has undefined behavior.
4874
4875 * search.c (boyer_moore, wordify): Remove vars set but not used.
4876 (wordify): Omit three unnecessary tests.
4877
4878 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4879 All callers changed. This avoids the need for an unused var.
4880
4881 * casefiddle.c (casify_region): Remove var that is set but not used.
4882
4883 * dired.c (file_name_completion): Remove var that is set but not used.
4884
4885 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4886
4887 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4888 (Finsert_file_contents): Remove unnecessary code checking fd.
4889
4890 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4891 Check for integer overflow on size calculations.
4892
4893 * buffer.c (Fprevious_overlay_change): Remove var that is set
4894 but not used.
4895
4896 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4897 Remove vars that are set but not used.
4898 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4899 (timer_check_2): Mark vars as initialized.
4900
4901 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4902
4903 * image.c (lookup_image): Remove var that is set but not used.
4904 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4905
4906 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4907 that are set but not used.
4908
4909 * xfns.c (make_invisible_cursor): Don't return garbage
4910 if XCreateBitmapFromData fails (Bug#8410).
4911
4912 * xselect.c (x_get_local_selection, x_handle_property_notify):
4913 Remove vars that are set but not used.
4914
4915 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4916 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4917
4918 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4919 Remove var that is set but not used.
4920 (scroll_bar_windows_size): Now size_t, not int.
4921 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4922 Check for overflow.
4923
4924 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4925 (map_tty_color) [!defined MSDOS]: Likewise.
4926
4927 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4928
4929 * coding.c: Remove vars that are set but not used.
4930 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4931 All callers changed.
4932 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4933 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4934 (decode_coding_charset): Remove vars that are set but not used.
4935
4936 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4937 that is set but not used.
4938
4939 * print.c (print_object): Remove var that is set but not used.
4940
4941 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4942 The gnulib version avoids calling malloc in the usual case,
4943 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4944 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4945 * filelock.c (current_lock_owner): Likewise.
4946 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4947 * sysdep.c: Include allocator.h, careadlinkat.h.
4948 (emacs_no_realloc_allocator): New static constant.
4949 (emacs_readlink): New function.
4950 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4951 ../lib/careadlinkat.h.
4952
4953 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4954
4955 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4956 first non-nil return value).
4957
4958 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4959
4960 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4961 if not defined (Bug#8403).
4962
4963 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4964
4965 * xdisp.c (display_count_lines): Remove parameter `start',
4966 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4967 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4968 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4969 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4970 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4971 and thereabouts. All callers changed.
4972 (get_per_char_metric): Remove parameter `f', unused since
4973 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4974
4975 2011-04-02 Jim Meyering <meyering@redhat.com>
4976
4977 do not dereference NULL upon failed strdup
4978 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4979 (ns_get_family): Likewise.
4980
4981 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4982
4983 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4984
4985 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4986
4987 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4988 later (Bug#8403).
4989
4990 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4991
4992 Add lexical binding.
4993
4994 * window.c (Ftemp_output_buffer_show): New fun.
4995 (Fsave_window_excursion):
4996 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4997
4998 * lread.c (lisp_file_lexically_bound_p): New function.
4999 (Fload): Bind Qlexical_binding.
5000 (readevalloop): Remove `evalfun' arg.
5001 Bind Qinternal_interpreter_environment.
5002 (Feval_buffer): Bind Qlexical_binding.
5003 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5004 Mark as dynamic.
5005 (syms_of_lread): Declare `lexical-binding'.
5006
5007 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5008
5009 * keyboard.c (eval_dyn): New fun.
5010 (menu_item_eval_property): Use it.
5011
5012 * image.c (parse_image_spec): Use Ffunctionp.
5013
5014 * fns.c (concat, mapcar1): Accept byte-code-functions.
5015
5016 * eval.c (Fsetq): Handle lexical vars.
5017 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5018 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5019 (FletX, Flet): Obey lexical binding.
5020 (Fcommandp): Handle closures.
5021 (Feval): New `lexical' arg.
5022 (eval_sub): New function extracted from Feval. Use it almost
5023 everywhere where Feval was used. Look up vars in lexical env.
5024 Handle closures.
5025 (Ffunctionp): Move from subr.el.
5026 (Ffuncall): Handle closures.
5027 (apply_lambda): Remove `eval_flags'.
5028 (funcall_lambda): Handle closures and new byte-code-functions.
5029 (Fspecial_variable_p): New function.
5030 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5031 but without exporting it to Lisp.
5032
5033 * doc.c (Fdocumentation, store_function_docstring):
5034 * data.c (Finteractive_form): Handle closures.
5035
5036 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5037 interactive spec.
5038
5039 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5040 New byte-codes.
5041 (exec_byte_code): New function extracted from Fbyte_code to handle new
5042 calling convention for byte-code-functions. Add new byte-codes.
5043
5044 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5045
5046 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5047
5048 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5049
5050 * xdisp.c (redisplay_internal): Fix prototype.
5051
5052 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5053
5054 * xdisp.c (SCROLL_LIMIT): New macro.
5055 (try_scrolling): Use it when setting scroll_limit.
5056 Limit scrolling to 100 screen lines.
5057 (redisplay_window): Even when falling back on "recentering",
5058 position point in the window according to scroll-conservatively,
5059 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5060
5061 (try_scrolling): When point is above the window, allow searching
5062 as far as scroll_max, or one screenful, to compute vertical
5063 distance from PT to the scroll margin position. This prevents
5064 try_scrolling from unnecessarily failing when
5065 scroll-conservatively is set to a value slightly larger than the
5066 window height. Clean up the case of PT below the margin at bottom
5067 of window: scroll_max can no longer be INT_MAX. When aggressive
5068 scrolling is in use, don't let point enter the opposite scroll
5069 margin as result of the scroll.
5070 (syms_of_xdisp) <scroll-conservatively>: Document the
5071 threshold of 100 lines for never-recentering scrolling.
5072
5073 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5074
5075 * dispextern.h (move_it_by_lines):
5076 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5077 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5078 (message_log_check_duplicate): Remove parameters `prev_bol' and
5079 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5080 (redisplay_internal): Remove parameter `preserve_echo_area',
5081 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5082
5083 * indent.c (Fvertical_motion):
5084 * window.c (window_scroll_pixel_based, Frecenter):
5085 Don't pass `need_y_p' to `move_it_by_lines'.
5086
5087 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5088
5089 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5090 steal a few bits to be more compact.
5091 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5092 Remove unneeded casts.
5093
5094 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5095
5096 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5097
5098 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5099 binding" message (bug#7967).
5100
5101 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5102
5103 Fix more problems found by GCC 4.6.0's static checks.
5104
5105 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5106 Remove unused local var.
5107
5108 * editfns.c (Fmessage_box): Remove unused local var.
5109
5110 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5111 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5112 Omit unused local vars.
5113 * window.c (shrink_windows): Omit unused local var.
5114 * menu.c (digest_single_submenu): Omit unused local var.
5115 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5116 Omit unused local var.
5117
5118 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5119 Don't assume string length fits in int.
5120 (keyremap_step, read_key_sequence): Use size_t for sizes.
5121 (read_key_sequence): Don't check last_real_key_start redundantly.
5122
5123 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5124 instead of alloca (Bug#8344).
5125
5126 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5127 (Fbacktrace_frame): Don't assume nframes fits in int.
5128
5129 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5130
5131 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5132 concerns.
5133
5134 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5135
5136 * cm.c (calccost): Turn while-do into do-while, for clarity.
5137
5138 * keyboard.c (syms_of_keyboard): Use the same style as later
5139 in this function when indexing through an array. This also
5140 works around GCC bug 48267.
5141
5142 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5143
5144 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5145
5146 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5147 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5148
5149 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5150 This avoids undefined behavior on integer overflow, and is a bit
5151 more convenient anyway since it is compared to a size_t variable.
5152
5153 Variadic C functions now count arguments with size_t, not int.
5154 This avoids an unnecessary limitation on 64-bit machines, which
5155 caused (substring ...) to crash on large vectors (Bug#8344).
5156 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5157 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5158 All variadic functions and their callers changed accordingly.
5159 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5160 * data.c (arith_driver, float_arith_driver): Likewise.
5161 * editfns.c (general_insert_function): Likewise.
5162 * eval.c (struct backtrace.nargs, interactive_p)
5163 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5164 (funcall_lambda, mark_backtrace): Likewise.
5165 * fns.c (concat): Likewise.
5166 * frame.c (x_set_frame_parameters): Likewise.
5167 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5168 0 if not found, not -1. All callers changed.
5169
5170 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5171 (stack_copy_size): Now size_t, not int.
5172 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5173
5174 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5175
5176 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5177 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5178 All callers changed.
5179
5180 * lisp.h (multibyte_char_to_unibyte):
5181 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5182 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5183 * character.h (CHAR_TO_BYTE8):
5184 * cmds.c (internal_self_insert):
5185 * editfns.c (general_insert_function):
5186 * keymap.c (push_key_description):
5187 * search.c (Freplace_match):
5188 * xdisp.c (message_dolog, set_message_1): All callers changed.
5189
5190 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5191
5192 * keyboard.c (safe_run_hook_funcall): New function.
5193 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5194 don't set the hook to nil, but remove the offending function instead.
5195 (Qcommand_hook_internal): Remove, unused.
5196 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5197 Vcommand_hook_internal.
5198
5199 * eval.c (enum run_hooks_condition): Remove.
5200 (funcall_nil, funcall_not): New functions.
5201 (run_hook_with_args): Call each function through a `funcall' argument.
5202 Remove `cond' argument, now redundant.
5203 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5204 (Frun_hook_with_args_until_failure): Adjust accordingly.
5205 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5206
5207 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5208
5209 * dispextern.h (string_buffer_position): Remove declaration.
5210
5211 * print.c (strout): Remove parameter `multibyte', unused since
5212 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5213
5214 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5215 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5216 All callers changed.
5217
5218 * w32.c (_wsa_errlist): Use braces for struct initializers.
5219
5220 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5221 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5222 All callers changed.
5223 (string_buffer_position): Likewise. Also, make static (it's never
5224 used outside xdisp.c).
5225 (cursor_row_p): Remove parameter `w', unused since
5226 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5227 (decode_mode_spec): Remove parameter `precision', introduced during
5228 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5229 All callers changed.
5230
5231 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5232
5233 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5234
5235 2011-03-27 Anders Lindgren <andlind@gmail.com>
5236
5237 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5238 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5239 (ns_update_auto_hide_menu_bar): New functions.
5240 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5241 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5242 ns_constrain_all_frames.
5243 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5244 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5245
5246 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5247
5248 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5249
5250 2011-03-27 Glenn Morris <rgm@gnu.org>
5251
5252 * syssignal.h: Replace RETSIGTYPE with void.
5253 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5254 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5255 Replace SIGTYPE with void everywhere.
5256 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5257 * s/template.h (SIGTYPE): Remove commented out definition.
5258
5259 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5260
5261 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5262 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5263
5264 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5265
5266 * w32.c (read_unc_volume): Use parameter `henum', instead of
5267 global variable `wget_enum_handle'.
5268
5269 * keymap.c (describe_vector): Remove parameters `indices' and
5270 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5271 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5272
5273 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5274
5275 * keyboard.c (timer_check): Remove parameter `do_it_now',
5276 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5277 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5278 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5279
5280 * keyboard.c (read_char):
5281 * w32menu.c (w32_menu_display_help):
5282 * xmenu.c (show_help_event, menu_help_callback):
5283 Adjust calls to `show_help_echo'.
5284
5285 * gtkutil.c (xg_maybe_add_timer):
5286 * keyboard.c (readable_events):
5287 * process.c (wait_reading_process_output):
5288 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5289
5290 * insdel.c (adjust_markers_gap_motion):
5291 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5292 (gap_left, gap_right): Don't call it.
5293
5294 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5295
5296 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5297 incurred during fontification.
5298
5299 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5300
5301 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5302 (DEFVAR_PER_BUFFER): Don't pass it.
5303
5304 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5305 (scrolling_window): Don't pass it.
5306
5307 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5308
5309 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5310
5311 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5312 and `suffix'.
5313 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5314 of variables specific to SELinux and computation of `encoded_absname'.
5315
5316 * image.c (XPutPixel): Remove unused variable `height'.
5317
5318 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5319
5320 * unexw32.c (get_section_info): Remove unused variable `section'.
5321
5322 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5323 (system_process_attributes): Remove unused variable `sess'.
5324 (sys_read): Remove unused variable `err'.
5325
5326 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5327 (w32_wnd_proc): Remove unused variable `isdead'.
5328 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5329 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5330 (x_create_tip_frame): Remove unused variable `tem'.
5331
5332 * w32inevt.c (w32_console_read_socket):
5333 Remove unused variable `no_events'.
5334
5335 * w32term.c (x_draw_composite_glyph_string_foreground):
5336 Remove unused variable `width'.
5337
5338 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5339
5340 * w32term.c (x_set_glyph_string_clipping):
5341 Don't pass uninitialized region to CombineRgn.
5342
5343 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5344
5345 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5346 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5347 (Fx_close_connection): Remove unused variable `i'.
5348
5349 * w32font.c (w32font_draw): Return number of glyphs.
5350 (w32font_open_internal): Remove unused variable `i'.
5351 (w32font_driver): Add missing initializer.
5352
5353 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5354 (fill_in_menu): Remove unused variable `items_added'.
5355
5356 * w32term.c (last_mouse_press_frame): Remove static global variable.
5357 (w32_clip_to_row): Remove unused variable `f'.
5358 (x_delete_terminal): Remove unused variable `i'.
5359
5360 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5361 (NOTHING): Remove unused static global variable.
5362 (uniscribe_check_otf): Remove unused variable `table'.
5363 (uniscribe_font_driver): Add missing initializers.
5364
5365 2011-03-23 Julien Danjou <julien@danjou.info>
5366
5367 * term.c (Fsuspend_tty, Fresume_tty):
5368 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5369 * window.c (temp_output_buffer_show):
5370 * insdel.c (signal_before_change):
5371 * frame.c (Fhandle_switch_frame):
5372 * fileio.c (Fdo_auto_save):
5373 * emacs.c (Fkill_emacs):
5374 * editfns.c (save_excursion_restore):
5375 * cmds.c (internal_self_insert):
5376 * callint.c (Fcall_interactively):
5377 * buffer.c (Fkill_all_local_variables):
5378 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5379 Use Frun_hooks.
5380 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5381 unconditionnaly since it does the check itself.
5382
5383 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5384
5385 Fix more problems found by GCC 4.5.2's static checks.
5386
5387 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5388 the first time through the loop, since we know p0 < p1 then.
5389 This also avoids a gcc -Wstrict-overflow warning.
5390
5391 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5392 leading to a memory leak, possible in functions like
5393 load_charset_map_from_file that can allocate an unbounded number
5394 of objects (Bug#8318).
5395
5396 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5397 that could (at least in theory) be that large.
5398
5399 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5400 This is less likely to overflow, and avoids undefined behavior if
5401 overflow does occur. All callers changed. Use strtoul to scan
5402 for the unsigned long integer.
5403 (pint2hrstr): Simplify and tune code slightly.
5404 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5405
5406 * scroll.c (do_scrolling): Work around GCC bug 48228.
5407 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5408
5409 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5410 This also avoids a warning with gcc -Wstrict-overflow.
5411 (validate_x_resource_name): Simplify count usage.
5412 This also avoids a warning with gcc -Wstrict-overflow.
5413
5414 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5415 fail (Bug#8306).
5416
5417 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5418
5419 * process.c (Fmake_network_process): Use socklen_t, not int,
5420 where POSIX says socklen_t is required in portable programs.
5421 This fixes a porting bug on hosts like 64-bit HP-UX, where
5422 socklen_t is wider than int (Bug#8277).
5423 (Fmake_network_process, server_accept_connection):
5424 (wait_reading_process_output, read_process_output):
5425 Likewise.
5426
5427 * process.c: Rename or move locals to avoid shadowing.
5428 (list_processes_1, Fmake_network_process):
5429 (read_process_output_error_handler, exec_sentinel_error_handler):
5430 Rename or move locals.
5431 (Fmake_network_process): Define label "retry_connect" only if needed.
5432 (Fnetwork_interface_info): Fix pointer signedness.
5433 (process_send_signal): Add cast to avoid pointer signedness problem.
5434 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5435 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5436
5437 Make tparam.h and terminfo.c consistent.
5438 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5439 Include tparam.h instead, since it declares them.
5440 * cm.h (PC): Remove extern decl; tparam.h now does this.
5441 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5442 * terminfo.c: Include tparam.h, to check interfaces.
5443 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5444 (tparam): Adjust signature to match interface in tparam.h;
5445 this removes some undefined behavior. Check that outstring and len
5446 are zero, which they always are with Emacs.
5447 * tparam.h (PC, BC, UP): New extern decls.
5448
5449 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5450 (xftfont_open): Rename locals to avoid shadowing.
5451
5452 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5453 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5454 (OTF_TAG_SYM): Omit macro if not needed.
5455 (ftfont_list): Remove unused local.
5456 (get_adstyle_property, ftfont_pattern_entity):
5457 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5458 Rename locals to avoid shadowing.
5459
5460 * xfont.c (xfont_list_family): Mark var as initialized.
5461
5462 * xml.c (make_dom): Now static.
5463
5464 * composite.c (composition_compute_stop_pos): Rename local to
5465 avoid shadowing.
5466 (composition_reseat_it): Remove unused locals.
5467 (find_automatic_composition, composition_adjust_point): Likewise.
5468 (composition_update_it): Mark var as initialized.
5469 (find_automatic_composition): Mark vars as initialized,
5470 with a FIXME (Bug#8290).
5471
5472 character.h: Rename locals to avoid shadowing.
5473 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5474 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5475 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5476 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5477 to avoid shadowing.
5478
5479 * textprop.c (property_change_between_p): Remove; unused.
5480
5481 * intervals.c (interval_start_pos): Now static.
5482
5483 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5484
5485 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5486 Rename locals to avoid shadowing.
5487
5488 * sound.c (wav_play, au_play, Fplay_sound_internal):
5489 Fix pointer signedness.
5490 (alsa_choose_format): Remove unused local var.
5491 (wav_play): Initialize a variable to 0, to prevent undefined
5492 behavior (Bug#8278).
5493
5494 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5495
5496 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5497
5498 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5499 clobbering (Bug#8298).
5500 * sysdep.c (sys_subshell): Likewise.
5501 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5502
5503 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5504 This should get cleaned up, so that child_setup has the
5505 same signature on all platforms.
5506
5507 * callproc.c (call_process_cleanup): Now static.
5508 (relocate_fd): Rename locals to avoid shadowing.
5509
5510 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5511
5512 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5513 not to be necessary, and produces flickering.
5514
5515 2011-03-20 Glenn Morris <rgm@gnu.org>
5516
5517 * config.in: Remove file.
5518
5519 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5520
5521 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5522 are now in src/globals.h.
5523 (syms_of_minibuf): Remove spurious & from previous change.
5524
5525 2011-03-20 Leo <sdl.web@gmail.com>
5526
5527 * minibuf.c (completing-read-function): New variable.
5528 (completing-read-default): Rename from completing-read.
5529 (completing-read): Call completing-read-function.
5530
5531 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5532
5533 * xfaces.c (Fx_load_color_file):
5534 Read color file from absolute filename (bug#8250).
5535
5536 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5537
5538 * makefile.w32-in: Update dependencies.
5539
5540 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5541
5542 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5543
5544 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5545
5546 Fix more problems found by GCC 4.5.2's static checks.
5547
5548 * process.c (make_serial_process_unwind, send_process_trap):
5549 (sigchld_handler): Now static.
5550
5551 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5552 That way, the code declares only the vars that it needs.
5553 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5554 * s/cygwin.h (PTY_ITERATION): Likewise.
5555 * s/darwin.h (PTY_ITERATION): Likewise.
5556 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5557
5558 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5559 * process.c (allocate_pty): Don't declare stb unless it's needed.
5560
5561 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5562 (CONSTANTLIM): Remove; unused.
5563 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5564 Define only if needed.
5565
5566 * unexelf.c (unexec): Name an expression,
5567 to avoid gcc -Wbad-function-cast warning.
5568 Use a different way to cause a compilation error if anyone uses
5569 n rather than nn, a way that does not involve shadowing.
5570 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5571
5572 * deps.mk (unexalpha.o): Remove; unused.
5573
5574 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5575 * unexec.h: New file.
5576 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5577 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5578 Depend on unexec.h.
5579 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5580 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5581 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5582 Change as necessary to match prototype in unexec.h.
5583
5584 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5585 shadowing.
5586 (back_comment, skip_chars): Mark vars as initialized.
5587
5588 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5589 Rename locals to avoid shadowing.
5590
5591 * lread.c (read1): Rewrite so as not to use empty "else".
5592 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5593
5594 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5595
5596 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5597 warning when compiling print.c.
5598
5599 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5600 instead of using an uninitialized var.
5601 (font_sort_entities): Mark var as initialized.
5602
5603 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5604
5605 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5606 pointers to constants.
5607 (font_parse_fcname): Remove unused vars.
5608 (font_delete_unmatched): Now static.
5609 (font_get_spec): Remove; unused.
5610 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5611 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5612 Rename or move locals to avoid shadowing.
5613
5614 * fns.c (require_nesting_list, require_unwind): Now static.
5615 (Ffillarray): Rename locals to avoid shadowing.
5616
5617 * floatfns.c (domain_error2): Define only if needed.
5618 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5619
5620 * alloc.c (mark_backtrace): Move decl from here ...
5621 * lisp.h: ... to here, so that it can be checked.
5622
5623 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5624 (Fdefvar): Rewrite so as not to use empty "else".
5625 (lisp_indirect_variable): Name an expression,
5626 to avoid gcc -Wbad-function-cast warning.
5627 (Fdefvar): Rename locals to avoid shadowing.
5628
5629 * callint.c (quotify_arg, quotify_args): Now static.
5630 (Fcall_interactively): Rename locals to avoid shadowing.
5631 Use const pointer when appropriate.
5632
5633 * lisp.h (get_system_name, get_operating_system_release):
5634 Move decls here, to check interfaces.
5635 * process.c (get_operating_system_release): Move decl to lisp.h.
5636 * xrdb.c (get_system_name): Likewise.
5637 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5638 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5639 some of which prompt warnings from gcc -Wbad-function-cast.
5640 (Fformat_time_string, Fencode_time, Finsert_char):
5641 (Ftranslate_region_internal, Fformat):
5642 Rename or remove local vars to avoid shadowing.
5643 (Ftranslate_region_internal): Mark var as initialized.
5644
5645 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5646 avoid shadowing.
5647
5648 * lisp.h (eassert): Check that the argument compiles, even if
5649 ENABLE_CHECKING is not defined.
5650
5651 * data.c (Findirect_variable): Name an expression, to avoid
5652 gcc -Wbad-function-cast warning.
5653 (default_value, arithcompare, arith_driver, arith_error): Now static.
5654 (store_symval_forwarding): Rename local to avoid shadowing.
5655 (Fmake_variable_buffer_local, Fmake_local_variable):
5656 Mark variables as initialized.
5657 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5658
5659 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5660 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5661 Rename locals to avoid shadowing.
5662 (mark_stack): Move local variables into the #ifdef region where
5663 they're used.
5664 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5665 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5666 needed otherwise.
5667 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5668 (GC_STRING_CHARS): Remove; not used.
5669 (Fmemory_limit): Cast sbrk's returned value to char *.
5670
5671 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5672 avoids undefined behavior in theory.
5673
5674 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5675
5676 Use functions, not macros, for up- and down-casing (Bug#8254).
5677 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5678 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5679 to use the following functions instead of these macros.
5680 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5681 EMACS_INT, since callers assume the returned value fits in int.
5682 (upcase1): Likewise, for UPCASE_TABLE.
5683 (uppercasep, lowercasep, upcase): New static inline functions.
5684 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5685 the race-condition problem in the old DOWNCASE.
5686
5687 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5688 Rename locals to avoid shadowing.
5689 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5690 (regex_compile, re_search_2, re_match_2_internal):
5691 Remove unused local vars.
5692 (FREE_VAR): Rewrite so as not to use empty "else",
5693 which gcc can warn about.
5694 (regex_compile, re_match_2_internal): Mark locals as initialized.
5695 (RETALLOC_IF): Define only if needed.
5696 (WORDCHAR_P): Likewise. This one is never needed, but is used
5697 only in a comment talking about a compiler bug, so put inside
5698 the #if 0 of that comment.
5699 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5700 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5701 Remove; unused.
5702
5703 * search.c (boyer_moore): Rename locals to avoid shadowing.
5704 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5705 (PREV_CHAR_BOUNDARY): Likewise.
5706
5707 * search.c (simple_search): Remove unused var.
5708
5709 * dired.c (compile_pattern): Move decl from here ...
5710 * lisp.h: ... to here, so that it can be checked.
5711 (struct re_registers): New forward decl.
5712
5713 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5714
5715 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5716 All uses changed.
5717 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5718 Rename locals to avoid shadowing.
5719 (Fvertical_motion): Mark locals as initialized.
5720
5721 * casefiddle.c (casify_object, casify_region): Now static.
5722 (casify_region): Mark local as initialized.
5723
5724 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5725
5726 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5727 New macros, so that the caller can use some names other than
5728 gcpro1, gcpro2, etc.
5729 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5730 of the new macros.
5731 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5732 argument, for consistency with GCPRO2_VAR, etc: it is now the
5733 prefix of the variable, not the variable itself. All uses
5734 changed.
5735 * dired.c (directory_files_internal, file_name_completion):
5736 Rename locals to avoid shadowing.
5737
5738 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5739 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5740 dired.c's scmp function, had undefined behavior.
5741 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5742 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5743 * buffer.h: ... to here, because these macros use current_buffer,
5744 and the new implementation with inline functions needs to have
5745 current_buffer in scope now, rather than later when the macros
5746 are used.
5747 (downcase, upcase1): New static inline functions.
5748 (DOWNCASE, UPCASE1): Reimplement using these functions.
5749 This avoids undefined behavior in expressions like
5750 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5751 from race conditions in accessing the global variables
5752 case_temp1 and case_temp2.
5753 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5754 * lisp.h (case_temp1, case_temp2): Remove their decls.
5755 * character.h (ASCII_CHAR_P): Move from here ...
5756 * lisp.h: ... to here, so that the inline functions mentioned
5757 above can use them.
5758
5759 * dired.c (directory_files_internal_unwind): Now static.
5760
5761 * fileio.c (file_name_as_directory, directory_file_name):
5762 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5763 Now static.
5764 (file_name_as_directory): Use const pointers when appropriate.
5765 (Fexpand_file_name): Likewise. In particular, newdir might
5766 point at constant storage, so make it a const pointer.
5767 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5768 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5769 signedness issues.
5770 (Fset_file_times, Finsert_file_contents, auto_save_error):
5771 Rename locals to avoid shadowing.
5772
5773 * minibuf.c (choose_minibuf_frame_1): Now static.
5774 (Ftry_completion, Fall_completions): Rename or remove locals
5775 to avoid shadowing.
5776
5777 * marker.c (bytepos_to_charpos): Remove; unused.
5778
5779 * lisp.h (verify_bytepos, count_markers): New decls,
5780 so that gcc does not warn that these functions aren't declared.
5781
5782 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5783 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5784 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5785 (copy_text): Remove unused local var.
5786
5787 * filelock.c (within_one_second): Now static.
5788 (lock_file_1): Rename local to avoid shadowing.
5789
5790 * buffer.c (fix_overlays_before): Mark locals as initialized.
5791 (fix_start_end_in_overlays): Likewise. This function should be
5792 simplified by using pointers-to-pointers, but that's a different
5793 matter.
5794 (switch_to_buffer_1): Now static.
5795 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5796 (report_overlay_modification): Rename locals to avoid shadowing.
5797
5798 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5799 Fix pointer signedness issue.
5800 (sys_subshell): Mark local as volatile if checking for lint,
5801 to suppress a gcc -Wclobbered warning that does not seem to be right.
5802 (MAXPATHLEN): Define only if needed.
5803
5804 * process.c (serial_open, serial_configure): Move decls from here ...
5805 * systty.h: ... to here, so that they can be checked.
5806
5807 * fns.c (get_random, seed_random): Move extern decls from here ...
5808 * lisp.h: ... to here, so that they can be checked.
5809
5810 * sysdep.c (reset_io): Now static.
5811 (wait_for_termination_signal): Remove; unused.
5812
5813 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5814 (copy_keymap_item, append_key, push_text_char_description):
5815 Now static.
5816 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5817 (DENSE_TABLE_SIZE): Remove; unused.
5818 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5819 (describe_map_tree):
5820 Rename locals to avoid shadowing.
5821
5822 * keyboard.c: Declare functions static if they are not used elsewhere.
5823 (echo_char, echo_dash, cmd_error, top_level_2):
5824 (poll_for_input, handle_async_input): Now static.
5825 (read_char, kbd_buffer_get_event, make_lispy_position):
5826 (make_lispy_event, make_lispy_movement, apply_modifiers):
5827 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5828 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5829 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5830 (read_key_sequence, read_char): Mark locals as initialized.
5831 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5832
5833 * keyboard.h (make_ctrl_char): New decl.
5834 (mark_kboards): Move decl here ...
5835 * alloc.c (mark_kboards): ... from here.
5836
5837 * lisp.h (force_auto_save_soon): New decl.
5838
5839 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5840 (DEFINE_DUMMY_FUNCTION): New macro.
5841 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5842 Use it.
5843 (main): Add casts to avoid warnings
5844 if GCC considers string literals to be constants.
5845
5846 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5847
5848 * dbusbind.c: Pointer signedness fixes.
5849 (xd_signature, xd_append_arg, xd_initialize):
5850 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5851 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5852 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5853 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5854
5855 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5856 if GCC considers string literals to be constants.
5857 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5858
5859 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5860
5861 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5862 (print_preprocess, print_object): New macro to fix last change.
5863
5864 * print.c (print_preprocess): Don't forget font objects.
5865
5866 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5867
5868 * emacs.c (USAGE3): Doc fixes.
5869
5870 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5871
5872 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5873 structure.
5874
5875 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5876
5877 * lisp.h (VWindow_system, Qfile_name_history):
5878 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5879 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5880 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5881
5882 * w32select.c: Don't #include "keyboard.h".
5883 (run_protected): Add extern declaration for waiting_for_input.
5884
5885 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5886 * w32console.c (detect_input_pending, read_input_pending)
5887 (encode_terminal_code):
5888 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5889 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5890 (w32_system_caret_y, Qfile_name_history):
5891 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5892 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5893 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5894 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5895 * w32proc.c (Qlocal, report_file_error):
5896 * w32term.c (Vwindow_system, updating_frame):
5897 * w32uniscribe.c (initialized, uniscribe_font_driver):
5898 Remove unneeded extern declarations.
5899
5900 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5901
5902 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5903
5904 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5905
5906 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5907 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5908 These macros can no longer be used for assignment.
5909
5910 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5911 Assign struct members directly, instead of using BUF_BEGV etc.
5912 (record_buffer_markers, fetch_buffer_markers): New functions for
5913 recording and fetching special buffer markers.
5914 (set_buffer_internal_1, set_buffer_temp): Use them.
5915
5916 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5917
5918 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5919
5920 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5921 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5922
5923 * xdisp.c (hscroll_window_tree):
5924 (reconsider_clip_changes): Use PT instead of BUF_PT.
5925
5926 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5927
5928 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5929 $(EMACS_ROOT)/lib/intprops.h.
5930
5931 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5932
5933 Fix more problems found by GCC 4.5.2's static checks.
5934
5935 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5936 to unsigned char * to avoid compiler diagnostic.
5937 (xg_free_frame_widgets): Make it clear that a local variable is
5938 needed only if USE_GTK_TOOLTIP.
5939 (gdk_window_get_screen): Make it clear that this macro is needed
5940 only if USE_GTK_TOOLTIP.
5941 (int_gtk_range_get_value): New function, which avoids a diagnostic
5942 from gcc -Wbad-function-cast.
5943 (xg_set_toolkit_scroll_bar_thumb): Use it.
5944 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5945 diagnostic from gcc -Wbad-function-cast.
5946 (get_utf8_string, xg_get_file_with_chooser):
5947 Rename locals to avoid shadowing.
5948 (create_dialog): Move locals to avoid shadowing.
5949
5950 * xgselect.c (xg_select): Remove unused var.
5951
5952 * image.c (four_corners_best): Mark locals as initialized.
5953 (gif_load): Initialize transparent_p to zero (Bug#8238).
5954 Mark another local as initialized.
5955 (my_png_error, my_error_exit): Mark with NO_RETURN.
5956
5957 * image.c (clear_image_cache): Now static.
5958 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5959 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5960 (x_edge_detection): Remove unnecessary cast that
5961 gcc -Wbad-function-cast diagnoses.
5962 (gif_load): Fix pointer signedness.
5963 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5964 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5965
5966 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5967
5968 Improve quality of tests for time stamp overflow.
5969 For example, without this patch (encode-time 0 0 0 1 1
5970 1152921504606846976) returns the obviously-bogus value (-948597
5971 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5972 reports time overflow. See
5973 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5974 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5975 * editfns.c: Include limits.h and intprops.h.
5976 (TIME_T_MIN, TIME_T_MAX): New macros.
5977 (time_overflow): Move earlier, to before first use.
5978 (hi_time, lo_time): New functions, for an accurate test for
5979 out-of-range times.
5980 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5981 (Fget_internal_run_time): Don't assume time_t fits in int.
5982 (make_time): Use list2 instead of Fcons twice.
5983 (Fdecode_time): More accurate test for out-of-range times.
5984 (check_tm_member): New function.
5985 (Fencode_time): Use it, to test for out-of-range times.
5986 (lisp_time_argument): Don't rely on undefined left-shift and
5987 right-shift behavior when checking for time stamp overflow.
5988
5989 * editfns.c (time_overflow): New function, refactoring common code.
5990 (Fformat_time_string, Fdecode_time, Fencode_time):
5991 (Fcurrent_time_string): Use it.
5992
5993 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5994 * dired.c (make_time): Move to ...
5995 * editfns.c (make_time): ... here.
5996 * systime.h: Note the move.
5997
5998 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5999
6000 * fringe.c (update_window_fringes): Remove unused variables.
6001
6002 * unexmacosx.c (copy_data_segment): Also copy __got section.
6003 (Bug#8223)
6004
6005 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6006
6007 * termcap.c [MSDOS]: Include "msdos.h".
6008 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6009 Constify `char *' arguments and their references according to
6010 prototypes in tparam.h.
6011
6012 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6013
6014 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6015 Adapt all references accordingly.
6016
6017 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6018
6019 2011-03-11 Tom Tromey <tromey@redhat.com>
6020
6021 * buffer.c (syms_of_buffer): Remove obsolete comment.
6022
6023 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6024
6025 * termhooks.h (encode_terminal_code): Declare prototype.
6026
6027 * msdos.c (encode_terminal_code): Don't declare prototype.
6028
6029 * term.c (encode_terminal_code): Now external again, used by
6030 w32console.c and msdos.c.
6031
6032 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6033 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6034
6035 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6036
6037 Fix some minor problems found by GCC 4.5.2's static checks.
6038
6039 * fringe.c (update_window_fringes): Mark locals as initialized
6040 (Bug#8227).
6041 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6042
6043 * alloc.c (mark_fringe_data): Move decl from here ...
6044 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6045 to check its interface.
6046 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6047
6048 * fontset.c (free_realized_fontset): Now static.
6049 (Fset_fontset_font): Rename local to avoid shadowing.
6050 (fontset_font): Mark local as initialized.
6051 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6052
6053 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6054
6055 * xselect.c (x_disown_buffer_selections): Remove; not used.
6056 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6057 (x_own_selection, Fx_disown_selection_internal): Rename locals
6058 to avoid shadowing.
6059 (x_handle_dnd_message): Remove local to avoid shadowing.
6060
6061 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6062 so that the caller can use some name other than gcpro1.
6063 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6064 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6065 (Fx_backspace_delete_keys_p):
6066 Use them to avoid shadowing, and rename vars to avoid shadowing.
6067 (x_decode_color, x_set_name, x_window): Now static.
6068 (Fx_create_frame): Add braces to silence GCC warning.
6069 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6070 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6071 Remove unused locals.
6072 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6073 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6074 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6075 macros.
6076
6077 * xterm.h (x_mouse_leave): New decl.
6078
6079 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6080 Remove unused functions.
6081 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6082 (x_calc_absolute_position): Now static.
6083 (XTread_socket): Don't define label "out" unless it's used.
6084 Don't declare local "event" unless it's used.
6085 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6086 unless they are used.
6087 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6088 (x_fatal_error_signal): Remove; not used.
6089 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6090 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6091 (x_error_catcher, x_connection_closed, x_error_handler):
6092 (x_error_quitter, xembed_send_message, x_iconify_frame):
6093 (my_log_handler): Rename locals to avoid shadowing.
6094 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6095 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6096
6097 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6098 Rename or move locals to avoid shadowing.
6099 (tty_defined_color, merge_face_heights): Now static.
6100 (free_realized_faces_for_fontset): Remove; not used.
6101 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6102 does not deduce is never used uninitialized.
6103 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6104 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6105
6106 * terminal.c (store_terminal_param): Now static.
6107
6108 * xmenu.c (menu_highlight_callback): Now static.
6109 (set_frame_menubar): Remove unused local.
6110 (xmenu_show): Rename parameter to avoid shadowing.
6111 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6112 since they might point to immutable storage.
6113 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6114 since it's unused otherwise.
6115
6116 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6117 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6118 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6119 avoids a gcc -Wuninitialized diagnostic.
6120 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6121 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6122 does not deduce are never used uninitialized.
6123
6124 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6125
6126 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6127 * window.c (window_loop, size_window):
6128 (run_window_configuration_change_hook, enlarge_window): Likewise.
6129
6130 * window.c (display_buffer): Now static.
6131 (size_window): Mark variables that gcc -Wuninitialized
6132 does not deduce are never used uninitialized.
6133 * window.h (check_all_windows): New decl, to forestall
6134 gcc -Wmissing-prototypes diagnostic.
6135 * dispextern.h (bidi_dump_cached_states): Likewise.
6136
6137 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6138 shadowing.
6139 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6140 Include <limits.h>.
6141 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6142 and to avoid gcc -Wuninitialized warning.
6143 (load_charset_map): Mark variables that gcc -Wuninitialized
6144 does not deduce are never used uninitialized.
6145 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6146
6147 * coding.c (coding_set_source, coding_set_destination):
6148 Use "else { /* comment */ }" rather than "else /* comment */;"
6149 for clarity, and to avoid gcc -Wempty-body warning.
6150 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6151 a block, when the outer 'i' will do.
6152 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6153 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6154 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6155 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6156 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6157 Rename locals to avoid shadowing.
6158 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6159 * coding.c (emacs_mule_char, encode_invocation_designation):
6160 Now static, since they're not used elsewhere.
6161 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6162 (decode_coding_object, encode_coding_object, detect_coding_system):
6163 (decode_coding_emacs_mule): Mark variables that gcc
6164 -Wuninitialized does not deduce are never used uninitialized.
6165 (detect_coding_iso_2022): Initialize a local variable that might
6166 be used uninitialized. Leave a FIXME because it's not clear that
6167 this initialization is needed. (Bug#8211)
6168 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6169 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6170 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6171 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6172 Remove unused macros.
6173
6174 * category.c (hash_get_category_set): Remove unused local var.
6175 (copy_category_table): Now static, since it's not used elsewhere.
6176 * character.c (string_count_byte8): Likewise.
6177
6178 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6179 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6180
6181 * chartab.c (copy_sub_char_table): Now static, since it's not used
6182 elsewhere.
6183 (sub_char_table_ref_and_range, char_table_ref_and_range):
6184 Rename locals to avoid shadowing.
6185 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6186
6187 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6188 (BIDI_BOB): Remove unused macro.
6189
6190 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6191 deduce are never used uninitialized.
6192 * term.c (encode_terminal_code): Likewise.
6193
6194 * term.c (encode_terminal_code): Now static. Remove unused local.
6195
6196 * tparam.h: New file.
6197 * term.c, tparam.h: Include it.
6198 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6199 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6200 Move these decls to tparam.h, and make them agree with what
6201 is actually in tparam.c. The previous trick of using incompatible
6202 decls in different modules does not conform to the C standard.
6203 All callers of tparam changed to use tparam's actual API.
6204 * tparam.c (tparam1, tparam, tgoto):
6205 Use const pointers where appropriate.
6206
6207 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6208 * cm.h (struct cm): Likewise.
6209 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6210 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6211 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6212 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6213 (turn_on_face, init_tty): Likewise.
6214 * termchar.h (struct tty_display_info): Likewise.
6215
6216 * term.c (term_mouse_position): Rename local to avoid shadowing.
6217
6218 * alloc.c (mark_ttys): Move decl from here ...
6219 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6220
6221 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6222
6223 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6224
6225 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6226
6227 * search.c (compile_pattern_1): Remove argument regp, unused since
6228 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6229 (compile_pattern): Don't pass it.
6230
6231 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6232
6233 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6234 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6235 for ! HAVE_GTK3.
6236 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6237
6238 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6239
6240 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6241 gdk_window_get_screen, gdk_window_get_geometry,
6242 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6243 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6244 (xg_get_pixbuf_from_pixmap): New function.
6245 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6246 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6247 Call xg_get_pixbuf_from_pixmap instead of
6248 gdk_pixbuf_get_from_drawable.
6249 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6250 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6251 (xg_check_special_colors): Use GtkStyleContext and its functions
6252 for HAVE_GTK3.
6253 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6254 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6255 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6256 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6257 Call gtk_widget_get_preferred_size.
6258 (xg_frame_resized): gdk_window_get_geometry only takes 5
6259 parameters.
6260 (xg_win_to_widget, xg_event_is_for_menubar):
6261 Call gdk_x11_window_lookup_for_display.
6262 (xg_set_widget_bg): New function.
6263 (delete_cb): New function.
6264 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6265 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6266 (xg_set_background_color): Call xg_set_widget_bg.
6267 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6268 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6269 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6270 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6271 if ! HAVE_GTK3.
6272 (update_frame_tool_bar): Call gtk_widget_hide.
6273 (xg_initialize): Use GDK_KEY_g.
6274
6275 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6276 if ! HAVE_GTK3
6277 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6278
6279 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6280 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6281 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6282
6283 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6284
6285 * w32xfns.c (select_palette): Check success of RealizePalette against
6286 GDI_ERROR, not zero.
6287
6288 See ChangeLog.11 for earlier changes.
6289
6290 ;; Local Variables:
6291 ;; coding: utf-8
6292 ;; End:
6293
6294 Copyright (C) 2011 Free Software Foundation, Inc.
6295
6296 This file is part of GNU Emacs.
6297
6298 GNU Emacs is free software: you can redistribute it and/or modify
6299 it under the terms of the GNU General Public License as published by
6300 the Free Software Foundation, either version 3 of the License, or
6301 (at your option) any later version.
6302
6303 GNU Emacs is distributed in the hope that it will be useful,
6304 but WITHOUT ANY WARRANTY; without even the implied warranty of
6305 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6306 GNU General Public License for more details.
6307
6308 You should have received a copy of the GNU General Public License
6309 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.