1 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
4 * lisp.h (build_unibyte_string): New function.
5 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
6 * sysdep.c, w32fns.c, xfns.c: Use it.
7 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
8 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
9 Adjust users accordingly.
10 * font.h (font_open_by_name): Adjust prototype.
12 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
14 Cleanup calls to Fgarbage_collect.
15 * lisp.h (maybe_gc): New prototype.
16 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
18 * alloc.c (maybe_gc): New function.
19 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
21 * bytecode.c (MAYBE_GC): Use maybe_gc.
22 * eval.c (eval_sub, Ffuncall): Likewise.
23 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
24 to avoid dependency from auto-save feature.
26 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
28 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
29 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
30 'for_each_per_buffer_object_at'.
31 All uses changed. It's better to use upper-case for macros that
32 cannot be implemented as functions, to give the reader a clue
35 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
37 * alloc.c (Fgarbage_collect): Tweak docstring.
39 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
41 Tweak the value returned from Fgarbage_collect again.
42 * alloc.c (Fgarbage_collect): New return value, as confirmed in
43 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
45 (total_vector_bytes): Rename to total_vector_slots, adjust
47 (total_free_vector_bytes): Rename to total_free_vector_slots,
49 (Qstring_bytes, Qvector_slots): New symbols.
50 (syms_of_alloc): DEFSYM them.
52 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
54 Buffer compaction primitive which may be used from Lisp.
55 * buffer.c (compact_buffer, Fcompact_buffer): New function.
56 (syms_of_buffer): Register Fcompact_buffer.
57 * alloc.c (Fgarbage_collect): Use compact_buffer.
58 * buffer.h (compact_buffer): New prototype.
59 (struct buffer_text): New member.
61 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
63 New macro to iterate over all buffers, miscellaneous cleanups.
64 * lisp.h (all_buffers): Remove declaration.
65 * buffer.h (all_buffers): Add declaration, with comment.
66 (for_each_buffer): New macro.
67 * alloc.c (Fgarbage_collect, mark_object): Use it.
68 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
69 (init_buffer): Likewise.
70 * data.c (Fset_default): Likewise.
71 * coding.c (code_conversion_restore): Remove redundant check
73 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
75 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
77 Fix bug that created negative-length intervals.
78 * intervals.c (merge_interval_right, merge_interval_left):
79 Do not zero out this interval if it is absorbed by its children,
80 as this interval's total length doesn't change in that case. See
81 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
83 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
85 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
86 when invoking (make-bool-vector N t) and N is a positive
87 multiple of 8 -- the last 8 bits were mistakenly cleared.
89 Remove some struct layout assumptions in bool vectors.
90 * alloc.c (bool_header_size): New constant.
91 (header_size, word_size): Move earlier, as they're now used earlier.
92 Use 'word_size' in a few more places, where it's appropriate.
93 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
94 padding before the data member of a bool vector.
95 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
96 than doing the check by hand with an abort ().
98 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
100 * eval.c (Fdefvar): Don't check constants since we only set the var if
101 it's not yet defined anyway (bug#11904).
103 * lisp.h (last_undo_boundary): Declare new var.
104 * keyboard.c (command_loop_1): Set it.
105 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
106 were auto-added by the command loop (bug#11774).
108 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
110 * w32font.c (Qsymbol): Remove local definition.
111 (syms_of_w32font): Don't DEFSYM it.
113 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
115 Fix sweep_vectors to handle large bool vectors correctly.
116 * alloc.c (sweep_vectors): Account total_vector_bytes for
117 bool vectors larger than VBLOCK_BYTES_MAX.
119 2012-07-18 Chong Yidong <cyd@gnu.org>
121 * frame.c (x_set_frame_parameters): Revert bogus change introduced
122 in 2012-05-25 commit by Paul Eggert (Bug#11738).
124 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
126 Return more descriptive data from Fgarbage_collect.
127 Suggested by Stefan Monnier in
128 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
129 * alloc.c (bounded_number): New function.
130 (total_buffers, total_vectors): New variable.
131 (total_string_size): Rename to total_string_bytes, adjust users.
132 (total_vector_size): Rename to total_vector_bytes, adjust users.
133 (sweep_vectors): Account total_vectors and total_vector_bytes.
134 (Fgarbage_collect): New return value. Adjust documentation.
135 (gc_sweep): Account total_buffers.
136 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
137 (VECTOR_SIZE): Remove.
138 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
139 (Qinterval, Qmisc): New symbols.
140 (syms_of_data): Initialize them.
141 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
142 (Qcons, Qbuffer): New declarations.
144 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
146 * alloc.c (Fmemory_free): Account for memory-free's own storage.
147 Round up, not down. Improve doc.
149 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
151 Restore old code in allocate_string_data to avoid Faset breakage.
152 Reported by Julien Danjou <julien@danjou.info> in
153 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
154 * alloc.c (allocate_string_data): Restore old code with minor
155 adjustments, fix comment to explain this subtle issue.
157 2012-07-17 Eli Zaretskii <eliz@gnu.org>
159 Remove FILE_SYSTEM_CASE.
160 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
162 * fileio.c (FILE_SYSTEM_CASE): Don't define.
163 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
164 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
165 call-process-region passes it through expand-file-name.
167 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
169 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
171 Fix crash when creating indirect buffer (Bug#11917)
172 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
173 Don't handle unbound variables specially if non-zero.
174 (Fbuffer_local_variables): Pass zero.
175 (clone_per_buffer_values): Pass non-zero.
177 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
179 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
180 to make the loop interruptible.
182 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
184 * gnutls.c (emacs_gnutls_handshake): Only retry if
185 GNUTLS_E_INTERRUPTED.
187 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
189 Cleanup and convert miscellaneous checks to eassert.
190 * alloc.c (mark_interval): Fix comment, partially rephrase
191 old comment from intervals.h (see below).
192 * intervals.c (find_interval, adjust_intervals_for_insertion)
193 (delete_interval, adjust_intervals_for_deletion)
194 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
196 (adjust_intervals_for_insertion, make_new_interval):
197 Remove obsolete and unused code.
198 * intervals.h (struct interval): Remove obsolete comment.
199 * textprotp.c (erase_properties): Remove unused code.
200 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
201 (Fremove_list_of_text_properties): Convert to eassert.
203 2012-07-17 Chong Yidong <cyd@gnu.org>
205 * editfns.c (Finsert_char): Doc fix.
207 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
209 Fix previous change to make Fmemory_free always accurate.
210 * alloc.c (make_interval): Update total_free_intervals.
211 (make_float): Likewise for total_free_floats.
212 (free_cons, Fcons): Likewise for total_free_conses.
213 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
214 Likewise for total_free_vector_bytes.
215 (Fmake_symbol): Likewise for total_free_symbols.
216 (bytes_free): Remove.
218 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
220 Simple free memory accounting feature.
221 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
222 (sweep_vectors): Accumulate size of free vectors.
223 (Fgarbage_collect): Setup bytes_free.
224 (Fmemory_free): New function.
225 (syms_of_alloc): Register it.
227 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
229 Cleanup overlays checking.
230 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
231 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
232 eassert and OVERLAYP.
233 (sort_overlays): Change to use OVERLAYP.
235 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
237 * editfns.c (Finsert_char): Make it interactive, and make the
238 second arg optional. Copy interactive spec and docstring from
241 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
243 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
244 Unlike the other wrapped functions, fabs has an unspecified
247 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
249 * nsterm.m (keyDown): Interpret flags without left/right bits
250 as the left key (Bug#11670).
252 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
254 Remove empty and useless init functions.
255 * lisp.h (init_character_once, init_fns, init_image)
256 (init_filelock, init_sound): Remove prototype.
257 * character.c (init_character_once): Remove.
258 * filelock.c (init_filelock): Likewise.
259 * fns.c (init_fns): Likewise.
260 * image.c (init_image): Likewise.
261 * sound.c (init_sound): Likewise.
262 * emacs.c (main): Adjust accordingly.
264 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
266 * gtkutil.h: Tiny cleanups.
267 (use_old_gtk_file_dialog): Remove useless declaration.
268 (xg_uses_old_file_dialog): Add suggested const attribute.
270 2012-07-15 Eli Zaretskii <eliz@gnu.org>
272 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
273 (bidi_paragraph_init): Use it to limit search forward for a strong
274 directional character in abnormally large paragraphs full of
275 neutral or weak characters. (Bug#11943)
277 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
279 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
280 the toolbar (Bug#9451).
281 (xg_make_tool_item): Give the widget event box a transparent
284 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
286 Cleanup basic allocation variables and functions.
287 * alloc.c (ignore_warnings, init_intervals, init_float)
288 (init_cons, init_symbol, init_marker): Remove.
289 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
290 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
291 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
292 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
293 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
294 (staticidx, init_alloc_once, init_strings, free_ablock):
295 Remove redundant initialization.
296 * fns.c (init_weak_hash_tables): Remove.
297 * lisp.h (init_weak_hash_tables): Remove prototype.
299 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
301 Use zero_vector where appropriate.
302 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
304 * lisp.h (zero_vector): New declaration.
305 * font.c (null_vector): Remove.
306 (syms_of_font): Remove initialization and staticpro.
307 (font_list_entities, font_find_for_lface): Change to use zero_vector.
308 * keymap.c (Faccessible_keymaps): Likewise.
310 2012-07-15 Leo Liu <sdl.web@gmail.com>
312 * fringe.c: Fix typo in comments.
314 2012-07-14 Leo Liu <sdl.web@gmail.com>
316 * fringe.c: Add a new bitmap exclamation-mark.
318 2012-07-14 Eli Zaretskii <eliz@gnu.org>
320 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
322 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
323 (HAVE_MENUS): Don't define, defined by editing config.in with
325 (GMALLOC_INHIBIT_VALLOC): Don't define.
326 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
328 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
330 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
332 2012-07-14 Glenn Morris <rgm@gnu.org>
334 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
335 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
336 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
338 2012-07-13 Glenn Morris <rgm@gnu.org>
340 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
342 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
343 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
345 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
347 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
348 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
349 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
350 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
352 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
353 as boolean expression.
354 (x_set_window_size): Remove unused variable toolbar.
355 (ns_get_color_default, ns_mod_to_lisp): Remove.
356 (ns_mouse_position): Remove unused variables xchar and ychar.
357 (ns_compute_glyph_string_overhangs): Remove unused variable face.
358 (ns_set_vertical_scroll_bar): Remove unused variable count.
359 (ns_delete_terminal): Remove unused variable i.
360 (ns_term_init): Remove unused variables r, g and b.
361 (mouseDown): Remove unused variable window.
362 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
363 (initFrameFromEmacs): Remove unused variable vbextra.
364 (mouseEntered): Remove unused variables p and dpyinfo.
365 (mouseExited): Remove unused variables p and r.
366 (ns_define_frame_cursor, ns_clear_frame_area)
367 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
368 (menuDown): Assign [sender tag] to variable and cast the variable.
370 * nsterm.h (menuDown): Add id as type to argument sender.
371 (ns_display_info_for_name): Add Lisp_Object argument.
372 (ns_term_init): Add Lisp_Object argument.
373 (ns_map_event_to_object): Add void argument.
374 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
375 prototype with arguments and only declare if __OBJC__.
376 (nxatoms_of_nsselect): Add void argument.
377 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
378 (ns_alloc_autorelease_pool): Add void argument.
379 (ns_release_autorelease_pool): Add void* argument.
380 (ns_get_defaults_value): Add const char* argument.
382 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
383 (initFromContents): Use SSDATA where appropriate.
384 (ns_update_menubar): Add braces to ambigous if-else.
385 (initWithTitle): Put () around assignment in if statement.
386 (ns_menu_show): Remove unused variables window and keymap.
387 (update_frame_tool_bar): Remove unused variable selected_p.
388 (initWithContentRect): Remove unused variable this_cmd_name.
390 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
392 (setXBMColor): Remove unused variable len.
393 (setPixmapData): Put () around assignment in loop statement.
395 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
396 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
398 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
399 around assignment in loop statement.
400 (nsfont_open): Remove unused variable i.
401 (nsfont_open): Remove unused variable len.
402 (nsfont_draw): Remove unused variable cs.
404 * nsfns.m (x_set_icon_name, ns_set_name_internal)
405 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
406 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
407 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
408 (Fns_font_name, Fns_perform_service)
409 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
410 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
411 (ns_set_name): Remove unused variable view.
412 (x_set_menu_bar_lines): Remove unused variable olines.
413 (x_set_tool_bar_lines): Remove unused variable root_window.
414 (Fns_list_colors): Put () around assignment in while statement.
415 (Fns_perform_service): Remove unused variable len.
416 (Fns_display_usable_bounds): Remove unused variable top.
417 (syms_of_nsfns): Remove unused variable i.
419 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
422 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
424 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
425 and free it with DestroyExceptionInfo (Bug#11558).
427 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
429 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
430 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
431 Set here, not in nt/config.nt.
433 2012-07-13 Eli Zaretskii <eliz@gnu.org>
435 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
436 cursor overflow into the last glyph on display line when the right
437 fringe is off. (Bug#11832)
439 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
441 * xdisp.c (produce_special_glyphs): Now static.
442 * dispextern.h (produce_special_glyphs): Remove decl.
444 2012-07-13 Glenn Morris <rgm@gnu.org>
446 * s/bsd-common, s/cygwin.h: Remove empty files.
447 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
449 * s/usg5-4-common.h (USG, USG5):
450 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
451 * s/sol2-6.h (SOLARIS2):
452 * s/irix6-5.h (IRIX6_5):
453 * s/hpux10-20.h (USG, USG5, HPUX):
454 * s/gnu-linux.h (USG, GNU_LINUX):
455 * s/freebsd.h (BSD_SYSTEM):
456 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
457 * s/cygwin.h (CYGWIN):
458 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
459 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
461 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
463 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
465 2012-07-13 Glenn Morris <rgm@gnu.org>
467 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
469 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
471 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
472 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
474 2012-07-12 Glenn Morris <rgm@gnu.org>
476 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
478 * process.c (init_process_emacs): Rename from init_process.
479 The old name is also the name of a Mach system call.
480 * lisp.h, emacs.c: Update for this name change.
481 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
484 2012-07-12 Eli Zaretskii <eliz@gnu.org>
486 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
487 memmove call that removes glyphs covered by the left truncation
488 glyph. Improve commentary.
489 (display_line): Fix display of continuation glyphs on GUI frames
490 when the right fringe is turned off and variable-size fonts are
491 used in the window. Move the code that appends a stretch glyph to
492 produce_special_glyphs, so that it could be used for truncation
493 and continuation glyphs alike.
494 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
495 glyph of a suitably computed width, to align the special glyphs at
496 the window margin. Code moved from display_line. (Bug#11832)
498 2012-07-12 Glenn Morris <rgm@gnu.org>
500 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
502 * s/gnu-linux.h, s/hpux10-20.h:
503 Do not unconditionally define HAVE_XRMSETDATABASE.
505 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
507 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
509 Fix typos that broke OS X build.
510 Reported by Randal L. Schwartz in
511 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
512 * nsterm.m (ns_timeout): Add missing local decl.
513 (ns_get_color): snprintf -> sprintf, to fix typo.
515 2012-07-12 Glenn Morris <rgm@gnu.org>
517 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
518 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
519 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
520 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
522 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
523 Move PTY_OPEN to configure.
525 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
526 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
527 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
529 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
531 Use empty_unibyte_string where applicable.
532 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
533 * lread.c (read1): Likewise.
534 * xsettings.c (syms_of_xsettings): Likewise.
536 2012-07-12 Glenn Morris <rgm@gnu.org>
538 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
539 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
540 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
541 * s/hpux10-20.h (RUN_TIME_REMAP):
542 * s/bsd-common.h (TABDLY): Move to configure.
544 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
546 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
548 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
549 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
551 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
553 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
554 * s/template.h: Move NARROWPROTO to configure.
556 2012-07-11 Glenn Morris <rgm@gnu.org>
558 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
559 unused since 2011-01-17 change to systty.h.
561 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
562 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
563 Move HAVE_PTYS and HAVE_SOCKETS to configure.
565 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
567 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
569 2012-07-11 Glenn Morris <rgm@gnu.org>
571 * s/darwin.h, s/gnu-linux.h, s/template.h:
572 Move INTERRUPT_INPUT to configure.
574 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
576 Minor adjustments to interning code.
577 * lisp.h (intern, intern_c_string): Redefine as static inline
578 wrappers for intern_1 and intern_c_string_1, respectively.
579 (intern_1, intern_c_string_1): Rename prototypes.
580 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
582 * font.c (font_intern_prop): Likewise. Adjust comment.
583 * w32font.c (intern_font_name): Likewise.
585 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
587 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
589 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
590 of Fcar/Fcdr if possible.
591 * font.c (check_otf_features): Likewise.
592 * fontset.c (Fnew_fontset): Likewise.
593 * gnutls.c (Fgnutls_boot): Likewise.
594 * minibuf.c (read_minibuf): Likewise.
595 * msdos.c (IT_set_frame_parameters): Likewise.
596 * xmenu.c (Fx_popup_dialog): Likewise.
597 * w32menu.c (Fx_popup_dialog): Likewise.
599 2012-07-11 Glenn Morris <rgm@gnu.org>
601 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
602 since nothing has defined it on these platforms.
604 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
605 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
607 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
608 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
609 Move CLASH_DETECTION to configure.
611 * s/gnu.h: Remove file, which is now empty.
613 * s/gnu.h, s/gnu-linux.h:
614 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
616 2012-07-11 John Wiegley <johnw@newartisans.com>
618 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
619 function attribute, so we only use it if it exists in the
622 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
624 Avoid call to strlen in fast_c_string_match_ignore_case.
625 * search.c (fast_c_string_match_ignore_case): Change to use
626 length argument. Adjust users accordingly.
627 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
629 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
632 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
633 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
636 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
639 * s/hpux10-20.h (HAVE_PERROR): Remove.
640 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
641 Remove dummy definition, as this problem was obsolete long ago.
644 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
646 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
648 Avoid calls to strlen in font processing functions.
649 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
650 (font_open_by_name): Change to use length argument. Adjust
652 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
654 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
655 Change to return ptrdiff_t.
656 (xfont_list_pattern, xfont_match): Use length returned by
657 xfont_decode_coding_xlfd.
658 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
660 2012-07-11 Glenn Morris <rgm@gnu.org>
662 * s/darwin.h, s/freebsd.h, s/netbsd.h:
663 Move DONT_REOPEN_PTY to configure.
665 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
666 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
668 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
670 Remove "#define unix" that is no longer needed (Bug#11905).
671 * s/aix4-2.h (unix): Remove; no longer needed.
673 EMACS_TIME simplification (Bug#11875).
674 This replaces macros (which typically do not work in GDB)
675 with functions, typedefs and enums, making the code easier to debug.
676 The functional style also makes code easier to read and maintain.
677 * systime.h: Include <sys/time.h> on all hosts, not just if
678 WINDOWSNT, since 'struct timeval' is needed in general.
679 (EMACS_TIME): Now a typedef, not a macro.
680 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
682 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
683 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
684 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
685 (EMACS_TIME_LE): Now functions, not macros.
686 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
687 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
688 which are not functions. All uses rewritten to use:
689 (make_emacs_time): New function.
690 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
691 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
692 not functions. All uses rewritten to use the following, respectively:
693 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
694 (add_emacs_time, sub_emacs_time): New functions.
695 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
696 * fileio.c (Fcopy_file):
697 * xterm.c (XTflash): Get the current time closer to when it's used.
698 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
700 * bytecode.c (targets): Suppress -Woverride-init warnings.
702 Simplify by avoiding confusing use of strncpy etc.
703 * doc.c (Fsnarf_documentation):
704 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
705 * frame.c (Fmake_terminal_frame):
706 * gtkutil.c (get_utf8_string):
708 * nsmenu.m (ns_update_menubar):
709 * regex.c (regerror):
710 Prefer memcpy to strncpy and strncat when either will do.
711 * fileio.c (Fsubstitute_in_file_name):
712 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
713 (menu_separator_name_p):
714 * nsmenu.m (ns_update_menubar):
715 Prefer memcmp to strncmp when either will do.
716 * nsterm.m: Include <ftoastr.h>.
718 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
719 Prefer snprintf to strncpy.
720 * nsterm.m (ns_term_init):
721 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
722 * nsterm.m (ns_term_init):
723 Avoid the need for strncpy, by using build_string or
724 make_unibyte_string directly. Use dtoastr, not snprintf.
725 * process.c (Fmake_network_process): Diagnose service names that
726 are too long, rather than silently truncating them or creating
727 non-null-terminated names.
728 (Fnetwork_interface_info): Likewise, for interface names.
729 * sysdep.c (system_process_attributes) [GNU_LINUX]:
730 Prefer sprintf to strncat.
731 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
732 Prefer vsnprintf to vsprintf + strncpy.
734 2012-07-10 Glenn Morris <rgm@gnu.org>
736 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
737 Clarify fallback case.
739 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
741 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
742 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
743 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
744 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
745 where argument type is known to be a Lisp_Cons.
747 2012-07-10 Tom Tromey <tromey@redhat.com>
749 * bytecode.c (BYTE_CODE_THREADED): New macro.
750 (BYTE_CODES): New macro. Replaces all old byte-code defines.
751 (enum byte_code_op): New type.
752 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
753 (exec_byte_code): Use them. Use token threading when applicable.
755 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
757 Optimize pure C strings initialization.
758 * lisp.h (make_pure_string): Fix prototype.
759 (build_pure_c_string): New function, defined as static inline. This
760 provides a better opportunity to optimize away calls to strlen when
761 the function is called with compile-time constant argument.
762 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
763 argument, adjust users accordingly. Use build_pure_c_string where
765 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
766 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
767 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
769 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
771 Avoid calls to strlen in miscellaneous functions.
772 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
773 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
774 * lread.c (openp): Likewise.
776 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
778 Avoid calls to strlen in path processing functions.
779 * fileio.c (file_name_as_directory): Add comment. Change to add
780 srclen argument and return the length of result. Adjust users
782 (directory_file_name): Fix comment. Change to add srclen argument,
783 swap 1st and 2nd arguments to obey the common convention. Adjust
785 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
787 2012-07-10 Glenn Morris <rgm@gnu.org>
789 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
790 Move PENDING_OUTPUT_COUNT definition to configure.
792 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
793 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
794 * s/gnu.h (DATA_START): Move definitions to configure.
796 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
797 We include usg5-4-common.h, which defines them both.
799 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
800 O_RDONLY already includes it).
802 Stop ns builds setting the EMACSLOADPATH environment variable.
803 * nsterm.m (ns_load_path): Rename from ns_init_paths.
804 Now it does not set EMACSLOADPATH, just returns the load-path string.
805 * nsterm.h: Update accordingly.
806 * lread.c [HAVE_NS]: Include nsterm.h.
807 (init_lread) [HAVE_NS]: Use ns_load_path.
808 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
810 2012-07-09 Glenn Morris <rgm@gnu.org>
812 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
813 since the included bsd-common.h does so.
815 Stop ns builds setting the EMACSPATH environment variable.
816 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
817 (ns_init_paths): Do not set EMACSPATH.
818 * nsterm.h (ns_exec_path): Add it.
819 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
822 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
824 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
826 * process.c (wait_reading_process_output): 'waitchannels' was unset
827 when read_kbd || !NILP (wait_for_cell); fix this.
829 Add GCC-style 'const' attribute to functions that can use it.
830 * character.h (char_resolve_modifier_mask):
831 * keyboard.h (make_ctrl_char):
832 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
833 (init_character_once, next_almost_prime, init_fns, init_image)
834 (flush_pending_output, init_sound):
835 * mem-limits.h (start_of_data):
836 * menu.h (finish_menu_items):
838 * emacs.c (DEFINE_DUMMY_FUNCTION):
839 Declare the dummy function with ATTRIBUTE_CONST.
840 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
841 Add decls with ATTRIBUTE_CONST.
843 Minor improvements to make_formatted_string.
844 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
845 where int is good enough, as vsprintf returns an int.
846 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
848 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
850 Use make_formatted_string to avoid double length calculation.
851 * lisp.h (make_formatted_string): New prototype.
852 * alloc.c (make_formatted_string): New function.
853 * buffer.c (Fgenerate_new_buffer_name): Use it.
854 * dbus.c (syms_of_dbusbind): Likewise.
855 * editfns.c (Fcurrent_time_zone): Likewise.
856 * filelock.c (get_boot_time): Likewise.
857 * frame.c (make_terminal_frame, set_term_frame_name)
858 (x_report_frame_params): Likewise.
859 * image.c (gs_load): Likewise.
860 * minibuf.c (get_minibuffer): Likewise.
861 * msdos.c (dos_set_window_size): Likewise.
862 * process.c (make_process): Likewise.
863 * xdisp.c (ensure_echo_area_buffers): Likewise.
864 * xsettings.c (apply_xft_settings): Likewise.
866 2012-07-09 Glenn Morris <rgm@gnu.org>
868 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
869 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
870 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
871 * nsterm.h (ns_etc_directory): Add it.
872 * callproc.c [HAVE_NS]: Include nsterm.h.
873 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
875 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
877 Move marker debugging code under MARKER_DEBUG.
878 * marker.c (MARKER_DEBUG): Move marker debugging code under
879 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
880 for bootstrap with --enable-checking (~3x slowdown reported
881 by Juanma Barranquero <lekktu@gmail.com>).
882 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
884 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
886 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
887 See <http://bugs.gnu.org/11825#29>.
889 2012-07-08 Eli Zaretskii <eliz@gnu.org>
891 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
892 has no font, use the frame's font. (Bug#11813)
893 (display_line): Add commentary about displaying truncation glyphs
895 (produce_special_glyphs): Move here from term.c.
897 * term.c (produce_special_glyphs): Move to xdisp.c.
899 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
902 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
904 * xdisp.c (display_line): Avoid warning about implicit declaration
907 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
909 * lisp.h: Remove empty conditional.
911 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
913 * lread.c (load_path_check): Now static.
915 Fix some minor --with-ns problems found by static checking.
916 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
917 (x_set_font) [!HAVE_X_WINDOWS]:
918 * image.c (xpm_load_image) [HAVE_NS]:
919 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
920 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
922 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
923 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
924 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
925 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
926 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
927 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
928 Fix pointer signedness problem.
929 * xfaces.c (FRAME_X_FONT_TABLE):
930 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
932 2012-07-07 Glenn Morris <rgm@gnu.org>
934 * lread.c (load_path_check): New function, split from init_lread.
935 (init_lread): Reorganize. Motivation:
936 If EMACSLOADPATH is set, check/warn about that rather than the
937 defaults, which we are not going to use. Hence we can remove
938 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
939 Don't warn if site-lisp directories are missing.
940 If not installed, start from a blank load-path, since
941 PATH_LOADSEARCH refers to the eventual installation directories.
943 2012-07-07 Eli Zaretskii <eliz@gnu.org>
945 Support truncation and continuation glyphs on GUI frames, when
946 fringes are disabled. (Bug#11832)
947 * xdisp.c (init_iterator): Get dimensions of truncation and
948 continuation glyphs even if on GUI frames. Adjust
949 it->last_visible_x on GUI frames when the left or right fringes,
951 (start_display, move_it_in_display_line_to): Handle the case of a
952 GUI frame without a fringe to display continuation or truncation
954 (insert_left_trunc_glyphs): Support GUI frames: make sure
955 truncation glyphs overwrite enough glyphs from the current line to
956 have sufficient space in pixels.
957 (display_line): Support truncation and continuation glyphs on GUI
958 frames. If some spare pixels are left on the line after inserting
959 the truncation glyphs, fill that space with a stretch glyph of a
960 suitably computed width.
962 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
963 produce_glyphs, to support GUI sessions.
965 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
967 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
969 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
971 Do not require float-time's arg to fit in time_t (Bug#11825).
972 This works better on hosts where time_t is unsigned, and where
973 float-time is applied to the (negative) difference between two times.
974 * editfns.c (decode_time_components): Last arg is now double *,
975 not int *, and means to store all the result as a double, without
976 worrying about whether the seconds part fits in time_t.
978 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
980 (Ffloat_time): Do not fail merely because the specified time falls
981 outside of time_t range.
983 2012-07-07 Glenn Morris <rgm@gnu.org>
985 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
986 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
987 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
989 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
991 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
994 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
996 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
998 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
999 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1000 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1001 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1002 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1003 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1005 * xfont.c (compare_font_names): Redo to omit the need for casts.
1007 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1009 * xfns.c (Fx_change_window_property): Doc fix.
1010 * w32fns.c (Fx_change_window_property): Doc fix.
1012 * w32fns.c (Fx_window_property): Accept the same arguments as the
1013 X Windows version. Doc fix.
1014 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1016 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1017 Eli Zaretskii <eliz@gnu.org>
1019 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1020 Windows-specific code from nt/config.nt moved here.
1021 Obsolete settings removed.
1023 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1025 * process.c: Avoid unnecessary calls to gettime.
1026 (wait_reading_process_output): Don't get the time of day
1027 when gobbling data immediately and not waiting, as there's no need
1028 for it in that case. This removes a FIXME.
1030 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1032 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1033 is defined (Bug#11768).
1035 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1037 Fix marker debugging code.
1038 * marker.c (byte_char_debug_check): Do not perform the check
1039 if buffer is not multibyte.
1040 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1041 Call byte_char_debug_check with correct arguments.
1043 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1045 Compile marker debugging code only if ENABLE_CHECKING is defined.
1046 * marker.c (byte_char_debug_check, count_markers):
1047 Use only if ENABLE_CHECKING is defined.
1048 (byte_debug_flag): Remove.
1049 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1050 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1052 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1054 Avoid code repetition in marker-related functions.
1055 * marker.c (attach_marker): New function.
1056 (Fset_marker, set_marker_restricted, set_marker_both)
1057 (set_marker_restricted_both): Use it.
1058 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1059 Consistently rename charno to charpos.
1060 (marker_position): Add eassert.
1061 (marker_byte_position): Convert to eassert.
1063 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1065 Simplify list operations in unchain_overlay and unchain_marker.
1066 * buffer.c (unchain_overlay): Simplify. Add comment.
1067 * marker.c (unchain_marker): Simplify. Fix comments.
1069 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1071 Introduce fast path for the widely used marker operation.
1072 * alloc.c (build_marker): New function.
1073 * lisp.h (build_marker): New prototype.
1074 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1075 * composite.c (autocmp_chars): Likewise.
1076 * editfns.c (buildmark): Remove.
1077 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1078 (save_restriction_save): Use build_marker.
1079 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1080 * window.c (save_window_save): Likewise.
1082 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1084 Do not use Fdelete_overlay in delete_all_overlays
1085 to avoid redundant calls to unchain_overlay.
1086 * buffer.c (drop_overlay): New function.
1087 (delete_all_overlays, Fdelete_overlay): Use it.
1088 * minibuf.c (get_minibuffer): Fix comment.
1090 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1092 Port to OpenBSD 5.1 amd64.
1093 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1094 This is needed for OpenBSD, and should be harmless on all BSD systems.
1095 Also, include <sys/sysctl.h>, as it should be available on all
1096 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1097 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1098 use p_pid member, not kp_proc.pid.
1100 2012-07-06 Glenn Morris <rgm@gnu.org>
1102 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1104 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1106 More xmalloc and related cleanup.
1107 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1108 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1109 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1110 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1111 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1112 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1113 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1114 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1115 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1117 Omit needless casts involving void * pointers and allocation.
1118 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1119 as the former is more robust if P's type is changed.
1120 Prefer xzalloc to xmalloc + memset 0.
1121 Simplify malloc-or-realloc to realloc.
1122 Don't worry about xmalloc returning a null pointer.
1123 Prefer xstrdup to xmalloc + strcpy.
1124 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1126 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1127 alloca of a constant.
1129 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1131 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1132 hscroll is larger than the line width. Fixes long and futile
1133 looping inside extend_face_to_end_of_line (on a TTY) producing
1134 glyphs that are not needed and thrown away.
1136 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1138 * marker.c (set_marker_restricted_both): Simplify by using
1141 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1143 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1145 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1147 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1148 not defined (Bug#11768).
1149 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1150 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1151 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1152 followed by gtk_box_set_homogeneous (Bug#11768).
1153 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1154 (update_theme_scrollbar_width, xg_create_scroll_bar):
1155 Use gtk_scrollbar_new (Bug#11768).
1156 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1157 (is_box_type): New function (Bug#11768).
1158 (xg_tool_item_stale_p): Call is_box_type.
1159 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1160 with default display (Bug#11768).
1162 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1164 * xdisp.c (window_hscroll_limited): New function.
1165 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1166 coordinates when window's hscroll is set to insanely large
1169 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1171 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1172 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1174 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1177 * lisp.h (xzalloc): New prototype. Omit needless casts.
1178 * alloc.c (xzalloc): New function. Omit needless casts.
1179 * charset.c: Omit needless casts. Convert all calls to
1180 xmalloc with following memset to xzalloc.
1181 * dispnew.c: Likewise.
1182 * fringe.c: Likewise.
1183 * image.c: Likewise.
1184 * sound.c: Likewise.
1186 * w32fns.c: Likewise.
1187 * w32font.c: Likewise.
1188 * w32term.c: Likewise.
1189 * xfaces.c: Likewise.
1191 * xterm.c: Likewise.
1192 * atimer.c: Omit needless casts.
1193 * buffer.c: Likewise.
1194 * callproc.c: Likewise.
1196 * coding.c: Likewise.
1197 * composite.c: Likewise.
1199 * doprnt.c: Likewise.
1200 * editfns.c: Likewise.
1201 * emacs.c: Likewise.
1203 * filelock.c: Likewise.
1205 * gtkutil.c: Likewise.
1206 * keyboard.c: Likewise.
1208 * lread.c: Likewise.
1209 * minibuf.c: Likewise.
1210 * msdos.c: Likewise.
1211 * print.c: Likewise.
1212 * process.c: Likewise.
1213 * region-cache.c: Likewise.
1214 * search.c: Likewise.
1215 * sysdep.c: Likewise.
1216 * termcap.c: Likewise.
1217 * terminal.c: Likewise.
1218 * tparam.c: Likewise.
1219 * w16select.c: Likewise.
1221 * w32reg.c: Likewise.
1222 * w32select.c: Likewise.
1223 * w32uniscribe.c: Likewise.
1224 * widget.c: Likewise.
1225 * xdisp.c: Likewise.
1226 * xmenu.c: Likewise.
1228 * xselect.c: Likewise.
1230 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1232 * fileio.c (time_error_value): Check the right error number.
1233 Problem reported by Troels Nielsen in
1234 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1236 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1238 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1239 This should be fixed in a better way; see Eli Zaretskii in
1240 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1241 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1243 * fileio.c (time_error_value): Rename from special_mtime.
1244 The old name's problems were noted by Eli Zaretskii in
1245 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1247 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1248 This variable's comment says Emacs needs at least one GDB-visible
1249 symbol of type enum pvec_type, to work around GDB problems.
1250 The symbol's value doesn't matter.
1252 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1253 that causes compilation to fail on pre-C99 compilers.
1255 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1257 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1258 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1260 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1262 * buffer.c (init_buffer_once): Fix initialization of
1263 headers for buffer_defaults and buffer_local_symbols.
1264 Reported by Juanma Barranquero <lekktu@gmail.com>.
1266 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1268 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1269 * lisp.h (enum pvec_type): Use fewer bits.
1270 (PSEUDOVECTOR_SIZE_BITS): New constant.
1271 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1272 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1273 change in pvec_type.
1274 (PSEUDOVECTOR_TYPEP): New macro.
1275 (TYPED_PSEUDOVECTORP): Use it.
1276 * fns.c (internal_equal): Adapt code to extract pvectype.
1277 * emacs.c (gdb_pvec_type): Update type.
1278 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1279 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1280 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1281 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1282 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1283 abusing vector->header.next.nbytes.
1284 (live_vector_p): Use PVEC_TYPE.
1285 (mark_object): Adapt code to extract pvectype. Use switch.
1287 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1289 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1290 Tighten new eassert a bit.
1292 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1294 Fix compilation with --enable-gcc-warnings and -O1
1296 * doprnt.c (doprnt): Change type of tem to int, initialize
1297 to avoid compiler warning. Add eassert.
1298 * search.c (simple_search): Initialize match_byte to avoid
1299 compiler warning. Add eassert.
1301 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1303 Avoid weird behavior with large horizontal scrolls.
1304 Without this change, for example, large hscroll values would
1305 mess up Emacs's display on Fedora 15 x86, presumably due to
1306 overflows in int calculations in the display code.
1307 Also, if buffers had long lines, Emacs would freeze.
1308 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1309 (set_window_hscroll): New function, containing the old guts of
1310 Fset_window_hscroll. Return the clipped value.
1311 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1312 This avoids the need to check against PTRDIFF_MAX.
1314 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1316 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1318 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1320 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1322 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1323 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1324 since GCC 4.4.6 issues a bogus warning for them.
1326 Fix bugs in file timestamp newness comparisons.
1327 * fileio.c (Ffile_newer_than_file_p):
1328 * lread.c (Fload): Use full timestamp resolution of files,
1329 not just the 1-second resolution, so that files that are only
1330 slightly newer still count as newer.
1331 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1332 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1334 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1336 * fileio.c: Improve handling of file time marker. (Bug#11852)
1337 (special_mtime): New function.
1338 (Finsert_file_contents, Fverify_visited_file_modtime):
1339 Use it to set special mtime values consistently.
1341 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1343 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1344 marker for non-existing file. (Bug#11852)
1346 2012-07-03 Glenn Morris <rgm@gnu.org>
1348 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1349 and did not make it into globals.h).
1351 2012-07-03 Tom Tromey <tromey@redhat.com>
1353 * window.c (Fset_window_margins, Fset_window_fringes)
1354 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1355 * textprop.c (Fprevious_property_change): No longer static.
1356 * syntax.c (Fsyntax_table_p): No longer static.
1357 * process.c (Fget_process, Fprocess_datagram_address): No longer
1359 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1360 * keyboard.c (Fcommand_execute): No longer static.
1362 * insdel.c (Fcombine_after_change_execute): No longer static.
1363 * image.c (Finit_image_library): No longer static.
1364 * fileio.c (Fmake_symbolic_link): No longer static.
1365 * eval.c (Ffetch_bytecode): No longer static.
1366 * editfns.c (Fuser_full_name): No longer static.
1367 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1369 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1371 * dired.c (Ffile_attributes): No longer static.
1372 * composite.c (Fcomposition_get_gstring): No longer static.
1373 * callproc.c (Fgetenv_internal): No longer static.
1375 * ccl.h: Remove EXFUNs.
1376 * buffer.h: Remove EXFUNs.
1377 * dispextern.h: Remove EXFUNs.
1378 * intervals.h: Remove EXFUNs.
1379 * fontset.h: Remove EXFUN.
1380 * font.h: Remove EXFUNs.
1381 * dosfns.c (system_process_attributes): Remove EXFUN.
1382 * keymap.h: Remove EXFUNs.
1383 * lisp.h: Remove EXFUNs.
1384 * w32term.h: Remove EXFUNs.
1385 * window.h: Remove EXFUNs.
1386 * xsettings.h: Remove EXFUN.
1387 * xterm.h: Remove EXFUN.
1389 2012-07-03 Glenn Morris <rgm@gnu.org>
1391 * lisp.h (Frandom): Make it visible to C.
1392 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1393 buffer for invisible buffers. (Bug#1229)
1395 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1397 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1398 values which aren't power of 2.
1399 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1400 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1403 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1405 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1407 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1409 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1411 * alloc.c (allocate_vector_block): Remove redundant
1412 calls to mallopt if DOUG_LEA_MALLOC is defined.
1413 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1414 avoid calls to mallopt if zero_vector is returned.
1416 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1418 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1419 is enabled, avoid dereferencing NULL current_sblock if
1422 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1424 Cleanup basic buffer management.
1425 * buffer.h (struct buffer): Change layout to use generic vector
1426 marking code. Fix some comments. Change type of 'clip_changed'
1427 to bitfield. Remove unused #ifndef old.
1428 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1429 (GET_OVERLAYS_AT): Fix indentation.
1430 (for_each_per_buffer_object_at): New macro.
1431 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1432 (Fbuffer_local_variables): Use it.
1433 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1434 * alloc.c (allocate_buffer): Adjust to match new layout of
1435 struct buffer. Fix comment.
1436 (mark_overlay): New function.
1437 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1438 Lisp area of struct buffer.
1439 (mark_object): Use it. Adjust marking of misc objects
1440 and related comments.
1442 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1444 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1445 wrapper that is not needed because the wrapped code is a no-op (zero
1446 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1447 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1449 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1451 * alloc.c (mark_buffer): Simplify. Remove prototype.
1452 (mark_object): Add comment. Reorganize marking of vector-like
1453 objects. Use CHECK_LIVE for all vector-like objects except buffers
1454 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1455 redundant calls to mark_vectorlike for bool vectors.
1457 2012-06-30 Glenn Morris <rgm@gnu.org>
1459 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1461 * epaths.in (PATH_SITELOADSEARCH): New.
1462 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1463 This is rather than relying on --enable-locallisppath elements
1464 having "site-lisp" in their names. (Bug#10208#25, 11658)
1466 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1468 * w32proc.c (sys_select): Accept and ignore one more argument.
1470 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1472 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1473 (pselect) [!MS_DOS]: Redirect to sys_select.
1475 * sysdep.c: Don't include dos.h and dosfns.h.
1477 * process.c (sys_select):
1478 * msdos.c (sys_select): Accept one more argument and ignore it.
1480 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1481 adapt data types and code to that.
1484 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1485 which clashes with the gnulib function of the same name.
1487 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1489 * font.c (font_style_to_value, font_style_symbolic)
1490 (font_prop_validate_style): Add type checks for values in
1493 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1495 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1498 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1500 * xdisp.c (try_window_id): Undo last change.
1502 * w32.c (getwd): Adjust commentary about startup_dir.
1503 (init_environment): Always call sys_access, even in non-MSVC
1504 builds. Don't chdir to the directory of the Emacs executable.
1505 This undoes code from 1997 which was justified by the need to
1506 "avoid conflicts when removing and renaming directories". But its
1507 downside was that every relative file name was being interpreted
1508 relative to the directory of the Emacs executable, which can never
1509 be TRT. In particular, it broke sys_access when called with
1510 relative file names.
1511 (sys_access): Map GetLastError to errno.
1513 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1515 * window.h (struct window): Change type of 'fringes_outside_margins'
1516 to bitfield. Fix comment. Adjust users accordingly.
1517 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1519 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1522 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1524 * gnutls.c (emacs_gnutls_handshake):
1525 Add QUIT to make the loop interruptible.
1527 2012-06-29 Glenn Morris <rgm@gnu.org>
1529 * charset.c (init_charset): Make lack of etc/charsets fatal.
1531 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1533 * editfns.c (region_limit): Fix type mismatch.
1535 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1537 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1538 undefined. Convert from xassert to eassert.
1539 * nsmenu.m: Convert from xassert to eassert.
1540 * nsterm.m: Likewise.
1542 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1544 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1546 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1548 Avoid integer overflow on scroll-left and scroll-right.
1549 * window.c (HSCROLL_MAX): New macro.
1550 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1551 overflow when requested scroll falls outside ptrdiff_t range.
1553 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1555 * window.h (struct window): Change type of 'hscroll',
1556 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1557 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1558 Adjust users accordingly.
1559 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1560 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1561 from EMACS_INT to ptrdiff_t.
1562 (make_window): Omit redundant initialization.
1564 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1566 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1568 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1570 * window.h (struct window): Change type of 'use_time' and
1571 'sequence_number' from Lisp_Object to int.
1572 * frame.c (make_frame): Adjust users accordingly.
1573 * print.c (print_object): Likewise.
1574 * window.c (select_window, Fwindow_use_time, make_parent_window)
1575 (make_window): Likewise.
1577 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1579 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1580 enabled with --enable-checking=[all,glyphs] configure option.
1581 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1582 adjust comments accordingly.
1583 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1584 undefined, adjust comments accordingly.
1585 * image.c: Likewise.
1586 * scroll.c: Likewise.
1587 * w32fns.c: Likewise.
1588 * w32term.c: Likewise.
1589 * xdisp.c: Likewise.
1590 * xfaces.c: Likewise.
1592 * xterm.c: Likewise.
1594 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1596 Generalize run-time debugging checks.
1597 * dispextern.h (XASSERTS): Remove.
1598 * fontset.c (xassert): Remove.
1599 Convert from xassert to eassert.
1600 * alloc.c: Convert from xassert to eassert.
1602 * dispnew.c: Likewise.
1604 * fringe.c: Likewise.
1605 * ftfont.c: Likewise.
1606 * gtkutil.c: Likewise.
1607 * image.c: Likewise.
1608 * keyboard.c: Likewise.
1610 * process.c: Likewise.
1611 * scroll.c: Likewise.
1612 * sound.c: Likewise.
1614 * w32console.c: Likewise.
1615 * w32fns.c: Likewise.
1616 * w32term.c: Likewise.
1617 * window.c: Likewise.
1618 * xdisp.c: Likewise.
1619 * xfaces.c: Likewise.
1621 * xselect.c: Likewise.
1622 * xterm.c: Likewise.
1624 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1626 * fns.c (maybe_resize_hash_table): Output message when growing the
1629 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1631 * alloc.c (allocate_string_data): Remove dead code.
1632 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1633 avoid GCC warning about unused macro.
1635 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1637 * alloc.c (allocate_string): Omit intervals initialization.
1638 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1639 as in make_pure_string and make_pure_c_string.
1641 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1643 * alloc.c (allocate_string): Fix last change.
1645 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1647 * alloc.c (allocate_string): Remove two redundant calls
1648 to memset, add explicit initialization where appropriate.
1650 2012-06-27 Glenn Morris <rgm@gnu.org>
1652 * lisp.mk (lisp): Remove paths.elc.
1654 2012-06-27 Chong Yidong <cyd@gnu.org>
1656 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1658 2012-06-26 John Wiegley <johnw@newartisans.com>
1660 * unexmacosx.c (copy_data_segment): Add two section names used
1661 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1663 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1664 when building with Clang.
1666 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1668 * eval.c (Fapply): Allow calling it with a single argument.
1670 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1672 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1673 _stricmp and _strnicmp.
1674 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1676 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1678 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1680 (allocate_process): Likewise for new process.
1681 (allocate_terminal): Change to use offsetof.
1682 (allocate_frame): Likewise.
1683 * frame.c (make_frame): Omit redundant initialization.
1684 * window.c (make_parent_window): Use memset.
1685 (make_window): Omit redundant initialization.
1686 * process.c (make_process): Omit redundant initialization.
1687 * terminal.c (create_terminal): Likewise.
1689 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1691 * term.c (delete_tty): Remove redundant call to memset.
1693 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1695 * alloc.c: Remove build_string.
1696 * lisp.h: Define build_string as static inline. This provides
1697 a better opportunity to optimize away calls to strlen when the
1698 function is called with compile-time constant argument.
1699 * image.c (imagemagick_error): Convert to build_string.
1700 * w32proc.c (sys_spawnve): Likewise.
1701 * xterm.c (x_term_init): Likewise.
1703 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1705 Use sprintf return value instead of invoking strlen on result.
1706 In the old days this wasn't portable, since some sprintf
1707 implementations returned char *. But they died out years ago and
1708 Emacs already assumes sprintf returns int.
1709 Similarly for float_to_string.
1710 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1711 * ccl.c (ccl_driver):
1712 * character.c (string_escape_byte8):
1713 * data.c (Fnumber_to_string):
1714 * doprnt.c (doprnt):
1715 * print.c (print_object):
1716 * xdisp.c (message_dolog):
1717 * xfns.c (syms_of_xfns):
1718 Use sprintf or float_to_string result to avoid need to call strlen.
1719 * data.c (Fnumber_to_string):
1720 Use make_unibyte_string, since the string must be ASCII.
1721 * lisp.h, print.c (float_to_string): Now returns int length.
1722 * term.c (produce_glyphless_glyph):
1723 Use sprintf result rather than recomputing it.
1725 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1726 * Makefile.in (ALL_CFLAGS):
1727 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1728 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1730 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1732 * dispextern.h (xstrcasecmp): Define to library function
1733 strcasecmp if available.
1734 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1736 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1738 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1739 Avoid comma operator.
1740 * menu.c (push_submenu_start, push_submenu_end)
1741 (push_left_right_boundary, push_menu_pane): Likewise.
1742 * msdos.c (dos_rawgetc): Likewise.
1744 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1746 * xfns.c (xic_create_fontsetname): Remove redundant calls
1749 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1751 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1752 sprintf already null-terminates its output.
1754 * xfns.c (x_window): Remove redundant cast.
1756 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1758 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1759 `const char *' to `char *' to avoid compiler warning.
1761 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1763 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1764 instead of truncating it to 63 (admittedly a generous limit).
1766 * process.c: Fix spelling and caps in comments.
1768 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1770 * emacs.c (setpgrp): Remove definition, unused.
1771 * sysdep.c (setpgrp): Remove definition, not used in this file.
1773 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1775 * makefile.w32-in: Update dependencies.
1777 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1779 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1780 (SYSTIME_H): Add nt/inc/sys/time.h.
1782 * systime.h [WINDOWSNT]: Include sys/time.h.
1784 * s/ms-w32.h (struct timespec): Definition moved from
1785 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1787 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1789 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1790 * buffer.h (buffer_slot_type_mismatch):
1791 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1792 * eval.c (unwind_to_catch):
1793 * image.c (my_png_error, my_error_exit):
1794 * keyboard.c (quit_throw_to_read_char, user_error)
1795 (Fexit_recursive_edit, Fabort_recursive_edit):
1796 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1797 (wrong_type_argument, buffer_overflow, __executable_start)
1798 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1799 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1800 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1802 (child_setup) [!DOS_NT]:
1803 * lread.c (end_of_file_error, invalid_syntax):
1804 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1805 * puresize.h (pure_write_error):
1806 * search.c (matcher_overflow):
1807 * sound.c (sound_perror, alsa_sound_perror):
1808 * sysdep.c, syssignal.h (croak):
1809 * term.c (maybe_fatal, vfatal):
1810 * textprop.c (text_read_only):
1811 * undo.c (user_error):
1812 * unexmacosx.c (unexec_error):
1813 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1814 Use _Noreturn rather than NO_RETURN.
1815 No need for separate decl merely because of _Noreturn.
1816 * sound.c (sound_warning, parse_sound):
1817 Remove unnecessary forward decls.
1819 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1821 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1822 * lisp.h (WAIT_READING_MAX): New macro.
1823 * dispnew.c (Fsleep_for, sit_for):
1824 * keyboard.c (kbd_buffer_get_event):
1825 * process.c (Faccept_process_output):
1826 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1827 This improves on the previous patch, which introduced a bug
1828 when time_t is unsigned and as wide as intmax_t.
1829 See <http://bugs.gnu.org/9000#51>.
1831 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1833 * dispnew.c (sit_for, Fsleep_for):
1834 * keyboard.c (kbd_buffer_get_event):
1835 * process.c (Faccept_process_output): Avoid compiler warnings when
1836 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1838 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1840 * makefile.w32-in: Update dependencies.
1842 * w32.c (ltime): Add return type and declare static.
1843 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1845 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1847 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1848 Privately reported by Herbert J. Skuhra.
1849 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1851 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1852 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1854 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1856 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1857 last argument of make_unibyte_string.
1859 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1860 language ID in the event parameters.
1862 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1863 event.code, not the obscure "character set ID".
1865 2012-06-23 Chong Yidong <cyd@gnu.org>
1867 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1869 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1871 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1872 * w32.c (fdutimens): New function.
1874 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1876 * s/ms-w32.h (pselect): Redirect to sys_select.
1878 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1880 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1881 in the logic of incrementing and decrementing the value of
1882 use_relocatable_buffers.
1884 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1886 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1887 Privately reported by Herbert J. Skuhra.
1888 [__FreeBSD__]: Remove "*/" typo after "#include".
1889 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1890 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1891 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1892 Don't assume EMACS_TIME and struct timeval are the same type.
1894 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1896 Support higher-resolution time stamps (Bug#9000).
1897 The time stamps are only nanosecond-resolution at the C level,
1898 since that's the best that any real-world system supports now.
1899 But they are picosecond-resolution at the Lisp level, as that's
1900 easy, and leaves room for future OS improvements.
1902 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1905 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1906 Don't get current time unless it's needed.
1908 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1909 now provides it if it's absent.
1910 (start_atimer): Port to higher-res time stamps.
1911 Check for time stamp overflow. Don't get current time more
1912 often than is needed.
1914 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1915 Include systime.h, not time.h.
1916 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1918 * dired.c: Include stat-time.h.
1919 (Ffile-attributes): File times now have higher resolution.
1921 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1922 (struct image): Timestamp now has higher resolution.
1924 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1925 has at least microseconds now. All uses removed.
1926 (update_frame, update_single_window, update_window, update_frame_1)
1927 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1929 * editfns.c (time_overflow): Now extern.
1930 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1931 (float-time, Fformat_time_string, Fcurrent_time_string)
1932 (Fcurrent_time_zone): Accept and generate higher-resolution
1934 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1935 (decode_time_components, lisp_seconds_argument): New functions.
1936 (make_time): Now static.
1937 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1938 Report an error if the time is invalid, rather than having the caller
1941 * fileio.c: Include <stat-time.h>
1942 (Fcopy_file): Copy higher-resolution time stamps.
1943 Prefer to set the time stamp via a file descriptor if that works.
1944 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1945 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1946 (Fvisited_file_modtime, Fset_visited_file_modtime):
1947 Support higher-resolution time stamps.
1949 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1951 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1953 * image.c (prepare_image_for_display, clear_image_cache)
1954 (lookup_image): Port to higer-resolution time stamps.
1956 * keyboard.c (start_polling, bind_polling_period):
1957 Check for time stamp overflow.
1958 (read_char, kbd_buffer_get_event, timer_start_idle)
1959 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1960 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1961 Port to higher-resolution time stamps. Do not assume time_t is signed.
1962 (decode_timer): New function. Timers are now vectors of length 9,
1963 not 8, to accommodate the picosecond component.
1964 (timer_check_2): Use it.
1966 * nsterm.m (select_timeout, timeval_subtract): Remove.
1967 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1968 as they're a bit more accurate and handle overflow better.
1969 (ns_select): Change prototype to be compatible with pselect.
1970 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1971 * nsterm.h (ns_select): Adjust prototype.
1973 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1974 us-resolution time stamps.
1975 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1977 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1979 * lisp.h (time_overflow): New decl.
1980 (wait_reading_process_output): First arg is now intmax_t, not int,
1981 to accommodate larger waits.
1983 * process.h (struct Lisp_Process.read_output_delay):
1984 Now counts nanoseconds, not microseconds.
1985 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1987 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1988 (wait_reading_process_output):
1989 Port to ns-resolution time stamps.
1990 (Faccept_process_output, wait_reading_process_output):
1991 Check for time stamp overflow. Do not assume time_t is signed.
1992 (select_wrapper): Remove; we now use pselect.
1993 (Fprocess_attributes): Now generates ns-resolution time stamps.
1995 * sysdep.c: Include utimens.h. Don't include utime.h
1996 or worry about struct utimbuf; gnulib does that for us now.
1997 (gettimeofday): Remove; gnulib provides a substitute.
1998 (make_timeval): New function.
1999 (set_file_times): Now sets ns-resolution time stamps.
2000 New arg FD; all uses changed.
2001 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2002 (system_process_attributes):
2003 Now returns ns-resolution time stamp. All uses changed.
2004 Check for time stamp overflow.
2006 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2007 provides a substitute now.
2009 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2010 since it guarantees struct timespec.
2011 (EMACS_TIME): Now struct timespec, so that we can support
2012 ns-resolution time stamps.
2013 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2014 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2015 (EMACS_USECS): Remove.
2016 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2017 so multiply the arg by 1000 before storing it.
2018 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2020 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2021 Port to ns-resolution time stamps.
2022 (EMACS_TIME_NEG_P): Remove; replaced by....
2023 (EMACS_TIME_SIGN): New macro.
2024 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2025 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2026 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2027 (make_timeval, make_lisp_time, decode_time_components): New decls.
2028 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2029 that it mishandled time_t overflow. You can't compare by subtracting!
2030 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2031 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2033 * term.c: Include <sys/time.h>.
2034 (timeval_to_Time): New function, for proper overflow wraparound.
2035 (term_mouse_position, term_mouse_click): Use it.
2037 * undo.c (record_first_change): Support higher-resolution time stamps
2039 (Fprimitive_undo): Use them when restoring time stamps.
2041 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2042 (w32_get_internal_run_time):
2043 Port to higher-resolution Emacs time stamps.
2044 (ltime): Now accepts single 64-bit integer, as that's more convenient
2047 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2049 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2050 for compatibility with pselect. Support ns-resolution time stamps.
2052 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2054 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2055 Check for time stamp overflow, and support ns-resolution time stamps.
2057 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2058 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2059 (timeval_subtract): Remove; no longer needed.
2060 (XTflash, XTring_bell, x_wait_for_event):
2061 Port to ns-resolution time stamps. Don't assume time_t is signed.
2063 2012-06-22 Chong Yidong <cyd@gnu.org>
2065 * xdisp.c (x_consider_frame_title): Revert last change.
2067 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2069 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2070 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2071 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2072 staticidx goes up to 1597 out of 1600 = 0x640.)
2074 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2076 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2077 Otherwise, the umask might be mistakenly 0 while handling input signals.
2079 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2081 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2083 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2085 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2086 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2087 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2088 access to `contents' member of Lisp_Vector objects with AREF and ASET
2091 2012-06-19 Chong Yidong <cyd@gnu.org>
2093 * frame.c (delete_frame): When selecting a frame on a different
2094 text terminal, do not alter the terminal's top-frame.
2096 * xdisp.c (format_mode_line_unwind_data): Record the target
2097 frame's selected window and its terminal's top-frame.
2098 (unwind_format_mode_line): Restore them.
2099 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2101 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2102 since tty frames can be explicitly named.
2103 (prepare_menu_bars): Likewise.
2105 * term.c (Ftty_top_frame): New function.
2107 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2109 Port byte-code-meter to modern targets.
2110 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2111 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2112 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2113 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2114 (METER_1, METER_2): Simplify.
2116 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2118 * data.c (Fdefalias): Return `symbol' (bug#11686).
2120 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2122 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2123 gets killed during executing of this function (Bug#11665).
2124 Try to always return Qt when the buffer has been actually killed.
2125 (Vkill_buffer_query_functions): In doc-string say that functions
2126 run by this hook should not change the current buffer.
2128 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2130 Fix recently-introduced process.c problems found by static checking.
2131 * process.c (write_queue_push, write_queue_pop, send_process):
2132 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2133 (write_queue_pop): Fix pointer signedness problem.
2134 (send_process): Remove unused local.
2136 2012-06-17 Chong Yidong <cyd@gnu.org>
2138 * xdisp.c (redisplay_internal): No need to redisplay terminal
2139 frames that are not on top.
2141 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2143 * process.c (make_process): Initialize write_queue.
2144 (write_queue_push, write_queue_pop): New functions.
2145 (send_process): Use them to maintain correct ordering of process
2148 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2150 * lisp.h (eassert): Assume C89 or later.
2151 This removes the need for CHECK.
2152 (CHECK): Remove. Its comments about always evaluating its
2153 argument were confusing, as 'eassert' typically does not evaluate
2156 * coding.c (produce_chars): Use ptrdiff_t, not int.
2158 * xterm.c (x_draw_underwave): Check for integer overflow.
2159 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2161 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2163 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2164 referenced (Bug#11583).
2166 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2168 Implement wave-style variant of underlining.
2169 * dispextern.h (face_underline_type): New enum.
2170 (face): Add field for underline type.
2171 * nsterm.m (ns_draw_underwave): New function.
2172 (ns_draw_text_decoration): Use it.
2173 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2175 (x_draw_glyph_string): Use them.
2176 * xfaces.c (Qline, Qwave): New Lisp objects.
2177 (check_lface_attrs, merge_face_ref)
2178 (Finternal_set_lisp_face_attribute, realize_x_face):
2179 Handle wave-style underline face attributes.
2180 * xterm.c (x_draw_underwave): New function.
2181 (x_draw_glyph_string): Use it.
2183 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2185 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2186 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2187 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2188 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2189 ($(BLD)/w32select.$(O)): Update dependencies.
2191 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2193 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2194 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2195 * character.c (_fetch_multibyte_char_p): Remove.
2196 * alloc.c: Include "character.h" before "buffer.h".
2198 * buffer.c: Likewise.
2199 * bytecode.c: Likewise.
2200 * callint.c: Likewise.
2201 * callproc.c: Likewise.
2202 * casefiddle.c: Likewise.
2203 * casetab.c: Likewise.
2204 * category.c: Likewise.
2206 * coding.c: Likewise.
2207 * composite.c: Likewise.
2208 * dired.c: Likewise.
2209 * dispnew.c: Likewise.
2211 * dosfns.c: Likewise.
2212 * editfns.c: Likewise.
2213 * emacs.c: Likewise.
2214 * fileio.c: Likewise.
2215 * filelock.c: Likewise.
2217 * fontset.c: Likewise.
2218 * fringe.c: Likewise.
2219 * indent.c: Likewise.
2220 * insdel.c: Likewise.
2221 * intervals.c: Likewise.
2222 * keyboard.c: Likewise.
2223 * keymap.c: Likewise.
2224 * lread.c: Likewise.
2225 * macros.c: Likewise.
2226 * marker.c: Likewise.
2227 * minibuf.c: Likewise.
2228 * nsfns.m: Likewise.
2229 * nsmenu.m: Likewise.
2230 * print.c: Likewise.
2231 * process.c: Likewise.
2232 * regex.c: Likewise.
2233 * region-cache.c: Likewise.
2234 * search.c: Likewise.
2235 * syntax.c: Likewise.
2237 * textprop.c: Likewise.
2239 * unexsol.c: Likewise.
2240 * w16select.c: Likewise.
2241 * w32fns.c: Likewise.
2242 * w32menu.c: Likewise.
2243 * window.c: Likewise.
2244 * xdisp.c: Likewise.
2246 * xmenu.c: Likewise.
2248 * xselect.c: Likewise.
2250 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2252 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2253 If all the glyphs of the glyph row came from strings, and we have no
2254 cursor positioning clues, put the cursor on the first glyph of the
2256 (handle_face_prop): Use chunk-relative overlay string index when
2257 indexing into it->string_overlays array. (Bug#11653)
2258 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2259 the rightmost. (Bug#11720)
2261 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2263 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2264 (CATEGORY_MEMBER): Enforce 1/0 value.
2265 * category.c (_temp_category_set): Remove.
2267 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2269 * window.c (Fdelete_other_windows_internal)
2270 (Fdelete_window_internal): Don't access frame's mouse highlight
2271 info of the initial frame. (Bug#11677)
2273 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2275 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2276 Assume USE_2_TAGS_FOR_INTS.
2277 (xreload): Adjust $tagmask width to match recent lisp.h change.
2279 Simplify lisp.h in minor ways that should not affect code.
2280 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2281 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2282 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2283 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2284 (INTTYPEBITS): New macro, for clarity.
2285 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2286 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2287 Simplify now that USE_LSB_TAG is always defined.
2288 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2289 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2291 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2293 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2295 2012-06-13 Glenn Morris <rgm@gnu.org>
2297 * s/bsd-common.h (BSD4_3):
2298 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2300 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2302 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2305 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2307 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2308 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2309 * alloc.c (widen_to_Lisp_Object): Remove.
2310 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2311 * frame.c (delete_frame): Remove outdated comment.
2312 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2313 USE_LISP_UNION_TYPE.
2314 (Fw32_unregister_hot_key): Likewise.
2315 (Fw32_toggle_lock_key): Likewise.
2316 * w32menu.c (add_menu_item): Likewise.
2317 (w32_menu_display_help): Use XIL instead of checking
2318 USE_LISP_UNION_TYPE.
2319 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2320 (init_heap): Likewise.
2321 * w32term.c (w32_read_socket): Update comment.
2323 2012-06-13 Glenn Morris <rgm@gnu.org>
2325 * s/usg5-4-common.h, src/s/unixware.h:
2326 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2328 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2330 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2332 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2333 * alloc.c (make_number) [!defined make_number]:
2334 Remove, as lisp.h always defines this now.
2335 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2336 (roundup_size): Verify that it is a power of 2.
2337 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2338 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2339 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2340 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2341 USE_LSB_TAG now is always defined to be either 0 or 1.
2343 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2344 code works fine either way, and efficiency is not a concern here,
2345 as the union type is for debugging, not for production.
2346 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2347 Use an inline function on all platforms when using the union type,
2348 since this is simpler and 'static inline' can be used portably
2350 (LISP_INITIALLY_ZERO): New macro.
2351 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2352 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2354 2012-06-12 Glenn Morris <rgm@gnu.org>
2356 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2358 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2360 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2361 Move BROKEN_SIGIO to configure.
2363 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2364 Move NO_TERMIO to configure.
2366 2012-06-12 Chong Yidong <cyd@gnu.org>
2368 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2369 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2370 MagickExportImagePixels is undefined.
2372 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2374 * image.c (imagemagick_load_image): Remove unused label.
2376 2012-06-11 Glenn Morris <rgm@gnu.org>
2378 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2379 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2380 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2381 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2383 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2385 * alloc.c (make_byte_code): New function.
2386 (Fmake_byte_code): Use it. Don't purify here.
2387 * lread.c (read1): Use it as well to avoid extra allocation.
2389 2012-06-11 Chong Yidong <cyd@gnu.org>
2391 * image.c (imagemagick_load_image): Implement transparency.
2393 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2395 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2396 account for preceding backslashes. (Bug#11663)
2398 2012-06-09 Chong Yidong <cyd@gnu.org>
2400 * term.c: Support italics in capable terminals (Bug#9652).
2401 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2402 (turn_on_face): Output using TS_enter_italic_mode if available.
2403 Don't handle unused blinking and alt-charset cases.
2404 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2405 and tty_alt_charset_p cases.
2406 (tty_capable_p, init_tty): Support italics.
2408 * termchar.h (struct tty_display_info): Add field for italics.
2409 Remove unused blink field.
2411 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2414 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2415 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2416 tty_alt_charset_p. Add tty_italic_p.
2418 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2420 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2421 dbus_type_is_basic if available.
2422 (xd_extract_signed, xd_extract_unsigned): Rename from
2423 extract_signed and extract_unsigned, respectively. Adapt callers.
2425 2012-06-09 Chong Yidong <cyd@gnu.org>
2427 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2429 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2432 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2434 * xdisp.c (vmessage): Treat frame message as multibyte.
2435 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2436 would generate the diagnostic "Making \302\247 buffer-local while
2439 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2441 * dispnew.c (showing_window_margins_p): Undo last change, which
2442 was done due to an inadvertent commit.
2443 (adjust_frame_glyphs_for_frame_redisplay): Do call
2444 showing_window_margins_p.
2446 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2448 * eval.c (Fmake_var_non_special): New primitive.
2449 (syms_of_eval): Defsubr it.
2450 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2452 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2454 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2455 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2457 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2459 * alloc.c (allocate_vectorlike): Fix last change.
2461 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2463 Block-based vector allocation of small vectors.
2464 * lisp.h (struct vectorlike_header): New field `nbytes',
2465 adjust comment accordingly.
2466 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2467 to denote vector blocks. Adjust users (live_vector_p,
2468 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2469 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2470 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2471 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2472 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2473 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2474 (roundup_size): New constant.
2475 (struct vector_block): New data type.
2476 (vector_blocks, vector_free_lists, zero_vector): New variables.
2477 (all_vectors): Rename to `large_vectors'.
2478 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2479 (sweep_vectors): New functions.
2480 (allocate_vectorlike): Return `zero_vector' as the only vector of
2481 0 items. Allocate new vector from block if vector size is less than
2482 or equal to VBLOCK_BYTES_MAX.
2483 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2484 (init_alloc_once): Add call to init_vectors.
2486 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2488 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2490 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2492 * doprnt.c (doprnt): Truncate multibyte char correctly.
2493 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2494 would mishandle a string argument "Xc" if X was a multibyte
2495 character of length 2: it would truncate after X's first byte
2496 rather than including all of X.
2498 2012-06-06 Chong Yidong <cyd@gnu.org>
2500 * buffer.c (word_wrap): Doc fix.
2502 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2504 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2506 2012-06-03 Glenn Morris <rgm@gnu.org>
2508 * xdisp.c (tool-bar-style): Doc fix.
2510 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2512 * Makefile.in (PAXCTL): Define.
2513 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2514 binary via PaX flags if the paxctl utility is available.
2515 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2516 Restore PaX flags to their default. (Bug#11398)
2518 2012-06-03 Chong Yidong <cyd@gnu.org>
2520 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2523 2012-06-03 Chong Yidong <cyd@gnu.org>
2525 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2526 (note_mode_line_or_margin_highlight): If there is no help echo,
2527 use mode-line-default-help-echo. Handle the case where the mouse
2528 position is past the end of the mode line string.
2530 * buffer.c (buffer_local_value_1): New function, split from
2531 Fbuffer_local_value; can return Qunbound.
2532 (Fbuffer_local_value): Use it.
2533 (Vmode_line_format): Docstring tweaks.
2535 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2537 * sysdep.c (system_process_attributes): Improve comment.
2539 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2541 * keyboard.c: Export real-this-command to Elisp.
2542 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2543 and DEFVAR it. Update all users.
2545 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2547 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2549 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2550 Convert pctcpu and pctmem to Lisp float properly.
2551 Let the compiler fold better, as 100.0/0x8000 is exact.
2553 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2555 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2558 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2560 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2562 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2564 For a 'struct window', replace some Lisp_Object fields to
2565 bitfields where appropriate, remove unused fields.
2566 * window.h (struct window): Remove unused 'last_mark_x' and
2567 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2568 change it's type from Lisp_Object to bitfield.
2569 Change type of 'force_start', 'optional_new_start',
2570 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2571 fields from Lisp_Object to bitfield. Adjust users accordingly.
2573 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2575 Pacify gcc -Wdouble-precision when using Xaw.
2576 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2577 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2578 Use 'float' consistently, rather than 'float' in most places
2579 and 'double' in a couple of places.
2581 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2583 * xdisp.c (handle_stop): Detect whether we have overlay strings
2584 loaded by testing it->current.overlay_string_index to be
2585 non-negative, instead of checking whether n_overlay_strings is
2586 positive. (Bug#11587)
2588 2012-05-31 Chong Yidong <cyd@gnu.org>
2590 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2592 * doc.c (Fsubstitute_command_keys): Doc fix.
2594 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2596 * search.c (search_buffer): Remove calls to
2597 r_alloc_inhibit_buffer_relocation, as it is now called by
2598 maybe_unify_char, which was the cause of relocation of buffer text
2601 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2603 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2604 for the duration of call to load_charset, to avoid problems with
2605 callers of maybe_unify_char that access buffer text through C
2608 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2609 decrement the inhibition flag, instead of just setting or
2612 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2614 Remove obsolete '#define static' cruft.
2615 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2616 This #undef was "temporary" in 2000; it is no longer needed
2617 now that '#define static' has gone away.
2618 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2619 (gray_bitmap_bits): Remove; no longer needed.
2620 All uses replaced with definiens.
2621 * xterm.c: Include "bitmaps/gray.xbm".
2623 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2625 Clean up __executable_start, monstartup when --enable-profiling.
2626 The following changes affect the code only when profiling.
2627 * dispnew.c (__executable_start): Rename from safe_bcopy.
2628 Define only on platforms that need it.
2629 * emacs.c: Include <sys/gmon.h> when profiling.
2630 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2631 (__executable_start): Remove decl, since lisp.h does it now.
2632 (safe_bcopy): Remove decl; no longer has that name.
2633 (main): Coalesce #if into single bit of code, for simplicity.
2634 Cast pointers to uintptr_t, since standard libraries want integers
2636 * lisp.h (__executable_start): New decl.
2638 2012-05-31 Glenn Morris <rgm@gnu.org>
2640 * image.c (Fimagemagick_types): Doc fix.
2642 2012-05-30 Jim Meyering <meyering@redhat.com>
2644 * callproc.c (Fcall_process_region): Include directory component
2645 in mkstemp error message (Bug#11586).
2647 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2649 * alloc.c, lisp.h (make_pure_vector): Now static.
2651 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2653 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2654 Move to byte-run.el.
2655 (Fautoload): Do the hash-doc more carefully.
2656 * data.c (Fdefalias): Purify definition, except for keymaps.
2657 (Qdefun): Move from eval.c.
2658 * lisp.h (Qdefun): Remove.
2659 * lread.c (read1): Tiny simplification.
2661 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2663 Do not create empty overlays with the evaporate property (Bug#9642).
2664 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2665 Bug#9642, but explicitly check that the buffer the overlay would
2666 be moved to is live and rearrange lines to make sure that errors
2667 will not put the overlay in an inconsistent state.
2668 (Fdelete_overlay): Cosmetics.
2670 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2672 * w32term.c (my_bring_window_to_top): New function.
2673 (x_raise_frame): Use handle returned by DeferWindowPos, which
2674 could be different from the original one.
2675 Call my_bring_window_to_top instead of my_set_foreground_window.
2678 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2679 by calling BringWindowToTop.
2681 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2682 (WM_EMACS_END): Increase by one.
2684 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2686 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2687 This avoids undefined behavior that might cause the eassert
2688 to not catch an out-of-range value.
2690 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2692 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2693 Update dependencies.
2695 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2697 * bidi.c (bidi_mirror_char): Fix last change.
2699 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2701 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2702 when referring to sectname field in printf format.
2704 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2706 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2707 Only r_alloc_inhibit_buffer_relocation needed to be added;
2708 the others were already declared.
2710 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2711 before checking whether it's out of range. Put the check inside
2713 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2715 2012-05-27 Ken Brown <kbrown@cornell.edu>
2717 * callproc.c (Fcall_process): Restore a line that was accidentally
2718 commented out in the 2011-02-13 change (bug#11547).
2720 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2722 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2723 defined on ralloc.c.
2725 * buffer.c [REL_ALLOC]: Remove prototypes of
2726 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2727 they are now on lisp.h.
2729 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2731 * search.c (search_buffer): Use it to inhibit relocation of buffer
2732 text while re_search_2 is doing its job, because re_search_2 is
2733 passed C pointers to buffer text. (Bug#11519)
2735 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2738 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2739 state after an additional call to move_it_in_display_line_to, keep
2740 the values of it->max_ascent and it->max_descent found for the
2742 (pos_visible_p): Revert the comparison against bottom_y to what it
2743 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2746 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2748 Fix coding-related core dumps with gcc -ftrapv.
2749 The code was computing A - B, where A and B are pointers, and B is
2750 random garbage. This can lead to core dumps on platforms that
2751 have special pointer registers, and it also leads to core dumps on
2752 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2753 A - B only when B is initialized properly.
2754 * coding.c (coding_set_source, coding_set_destination): Return void.
2755 (coding_change_source, coding_change_destinations): New functions,
2756 with the old behaviors of coding_set_source and coding_set_destination.
2757 All callers that need an offset changed to use these new functions.
2759 2012-05-26 Glenn Morris <rgm@gnu.org>
2761 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2763 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2765 Extend mouse support on W32 text-mode console.
2766 * xdisp.c (draw_row_with_mouse_face):
2767 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2769 * w32console.c: Include window.h.
2770 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2772 (initialize_w32_display): Initialize mouse-highlight data.
2774 * w32inevt.c: Include termchar.h and window.h.
2775 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2776 moves, call note_mouse_highlight. If help_echo changed, call
2777 gen_help_event to produce help-echo message in the echo area.
2778 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2781 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2783 * lread.c (read1): Simplify slightly to avoid an overflow warning
2784 with GCC 4.7.0 on x86-64.
2786 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2788 * bidi.c (bidi_mirror_char): Revert last change: an int is
2789 definitely wide enough here.
2791 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2793 Fix integer width and related bugs (Bug#9874).
2794 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2795 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2796 (string_bytes, check_sblock, allocate_string_data):
2797 (compact_small_strings, Fmake_bool_vector, make_string)
2798 (make_unibyte_string, make_multibyte_string)
2799 (make_string_from_bytes, make_specified_string)
2800 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2801 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2804 (allocate_pseudovector):
2805 Use int, not EMACS_INT, where int is wide enough.
2806 (inhibit_garbage_collection, Fgarbage_collect):
2807 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2808 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2809 int might not be wide enough.
2810 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2811 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2812 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2813 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2814 (bidi_level_of_next_char, bidi_move_to_visually_next):
2815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2816 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2817 (Fkill_buffer, Fset_buffer_major_mode)
2818 (advance_to_char_boundary, Fbuffer_swap_text)
2819 (Fset_buffer_multibyte, overlays_at, overlays_in)
2820 (overlay_touches_p, struct sortvec, record_overlay_string)
2821 (overlay_strings, recenter_overlay_lists)
2822 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2823 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2824 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2825 (Foverlay_recenter, last_overlay_modification_hooks_used)
2826 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2828 (validate_region): Omit unnecessary test for b <= e,
2829 since that's guaranteed by the previous test.
2830 (adjust_overlays_for_delete): Avoid pos + length overflow.
2831 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2832 (report_overlay_modification):
2833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2834 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2835 Omit pointer cast, which isn't needed anyway, and doesn't work
2836 after the EMACS_INT -> ptrdiff_t change.
2837 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2838 * buffer.h: Adjust decls to match defn changes elsewhere.
2839 (struct buffer_text, struct buffer):
2840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2841 Use EMACS_INT, not int, where int might not be wide enough.
2842 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2843 not int, to avoid needless 32-bit limit on 64-bit hosts.
2844 (exec_byte_code): Use tighter memory-full test, one that checks
2845 for alloca overflow. Don't compute the address of the object just
2846 before an array, as that's not portable. Use EMACS_INT, not
2847 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2848 * callint.c (Fcall_interactively):
2849 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2850 * callproc.c (call_process_kill, Fcall_process):
2851 Don't assume pid_t fits into an Emacs fixnum.
2852 (call_process_cleanup, Fcall_process, child_setup):
2853 Don't assume pid_t fits into int.
2854 (call_process_cleanup, Fcall_process, delete_temp_file)
2855 (Fcall_process_region):
2856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2857 (Fcall_process): Simplify handling of volatile integers.
2858 Use int, not EMACS_INT, where int will do.
2859 * casefiddle.c (casify_object, casify_region, operate_on_word)
2860 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2862 (casify_object): Avoid integer overflow when overallocating buffer.
2863 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2864 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2865 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2866 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2867 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2868 integers are now checked earlier. All uses replaced with XINT.
2870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2871 For CCL_MapSingle, check that content and value are in int range.
2872 (ccl_driver, Fregister_code_conversion_map):
2873 Check that Vcode_version_map_vector is a vector.
2874 (resolve_symbol_ccl_program): Check that vector header is in range.
2875 Always copy the vector, so that we can check its contents reliably
2876 now rather than having to recheck each instruction as it's being
2877 executed. Check that vector words fit in 'int'.
2878 (ccl_get_compiled_code, Fregister_ccl_program)
2879 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2880 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2881 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2882 contents are in range.
2883 (Fccl_execute_on_string): Check that status is in range.
2884 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2885 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2886 Accept and return EMACS_INT, not int, because callers can pass values
2888 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2889 (multibyte_chars_in_text, parse_str_as_multibyte)
2890 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2891 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2892 (string_escape_byte8, Fget_byte):
2893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2894 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2895 avoid mishandling large integers.
2896 * character.h: Adjust decls to match defn changes elsewhere.
2897 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2898 (Ffind_charset_region):
2899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2900 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2901 (load_charset_map_from_vector, Fdefine_charset_internal):
2902 Don't assume fixnum fits in int.
2903 (load_charset_map_from_vector, Fmap_charset_chars):
2904 Remove now-unnecessary CHECK_NATNUMs.
2905 (Fdefine_charset_internal): Check ranges here, more carefully.
2906 Don't rely on undefined behavior with signed left shift overflow.
2907 Don't assume unsigned int fits into fixnum, or that fixnum fits
2908 into unsigned int. Don't require max_code to be a valid fixnum;
2909 that's not true for gb10830 4-byte on a 32-bit host. Allow
2910 invalid_code to be a cons, for the same reason. Require code_offset
2911 to be a character. Avoid int overflow if max_char is close
2913 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2914 this is intended anyway and avoids some undefined behavior.
2915 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2916 INDEX_TO_CODE_POINT, as that's what it expects.
2917 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2918 * charset.h (DECODE_CHAR): Return int, not unsigned;
2919 this is what was intended anyway, and it avoids undefined behavior.
2920 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2921 integer-overflow issues.
2922 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2923 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2924 where the argument is EMACS_INT, and this behavior is not intended.
2925 * chartab.c (Fmake_char_table, Fset_char_table_range)
2926 (uniprop_get_decoder, uniprop_get_encoder):
2927 Don't assume fixnum fits in int.
2928 * cmds.c (move_point): New function, that does the gist of
2929 Fforward_char and Fbackward_char, but does so while checking
2930 for integer overflow more accurately.
2931 (Fforward_char, Fbackward_char): Use it.
2932 (Fforward_line, Fend_of_line, internal_self_insert)
2933 (internal_self_insert):
2934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2935 Fix a FIXME, by checking for integer overflow when calculating
2936 target_clm and actual_clm.
2937 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2938 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2939 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2940 (coding_alloc_by_making_gap, alloc_destination)
2941 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2942 (encode_coding_utf_16, detect_coding_emacs_mule)
2943 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2944 (detect_coding_iso_2022, decode_coding_iso_2022)
2945 (encode_invocation_designation, encode_designation_at_bol)
2946 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2947 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2948 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2949 (encode_coding_ccl, encode_coding_raw_text)
2950 (detect_coding_charset, decode_coding_charset)
2951 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2952 (produce_composition, produce_charset, produce_annotation)
2953 (decode_coding, handle_composition_annotation)
2954 (handle_charset_annotation, consume_chars, decode_coding_gap)
2955 (decode_coding_object, encode_coding_object, detect_coding_system)
2956 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2957 (code_convert_region, code_convert_string)
2958 (Fdefine_coding_system_internal)
2959 (coding_set_source, coding_set_destination):
2960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2961 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2962 (Fdefine_coding_system_internal):
2963 Don't assume fixnums fit in int.
2964 (decode_coding_gap, decode_coding_object, encode_coding_object)
2965 (Fread_coding_system, Fdetect_coding_region)
2966 (Funencodable_char_position, Fcheck_coding_systems_region)
2967 (get_translation, handle_composition_annotation, consume_chars):
2968 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2969 (consume_chars): Rewrite to not calculate an address outside buffer.
2970 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2971 Don't access memory outside of the args array.
2972 (Fdefine_coding_system_internal): Check for charset-id overflow.
2973 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2974 result of ENCODE_CHAR.
2975 * coding.h: Adjust decls to match defn changes elsewhere.
2976 (struct coding_system):
2977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2978 * composite.c (get_composition_id, find_composition)
2979 (run_composition_function, update_compositions)
2980 (compose_text, composition_gstring_put_cache)
2981 (composition_gstring_p, composition_gstring_width)
2982 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2983 (composition_compute_stop_pos, composition_reseat_it)
2984 (composition_update_it, struct position_record)
2985 (find_automatic_composition, composition_adjust_point)
2986 (Fcomposition_get_gstring, Ffind_composition_internal):
2987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2988 (update_compositions):
2989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2990 * composite.h: Adjust decls to match defn changes elsewhere.
2991 (struct composition):
2992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2993 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2994 Do not attempt to compute the address of the object just before a
2995 buffer; this is not portable.
2997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2998 (Faset): Use int, not EMACS_INT, where int is wide enough.
2999 (Fstring_to_number): Don't assume fixnums fit in int.
3000 (Frem): Don't assume arg is nonnegative.
3001 * dbusbind.c (xd_append_arg): Check for integers out of range.
3002 (Fdbus_call_method): Don't overflow the timeout int.
3003 (extract_signed, extract_unsigned): New functions.
3004 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3005 (xd_get_connection_references): Return ptrdiff_t, not int.
3007 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3008 (xd_read_message_1):
3009 Use int, not unsigned, where the dbus API uses int.
3010 (Fdbus_message_internal): Don't overflow mtype.
3011 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3012 * dired.c (directory_files_internal, file_name_completion, scmp)
3013 (file_name_completion_stat):
3014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3015 (file_name_completion): Don't overflow matchcount.
3016 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3017 * dispextern.h: Adjust decls to match defn changes elsewhere.
3018 (struct text_pos, struct glyph, struct bidi_saved_info)
3019 (struct bidi_string_data, struct bidi_it, struct composition_it)
3021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3022 (struct display_pos, struct composition_it, struct it):
3023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3024 * dispnew.c (increment_matrix_positions)
3025 (increment_row_positions, mode_line_string)
3026 (marginal_area_string):
3027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3028 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3030 (duration_to_sec_usec): New function, to check for overflow better.
3031 (Fsleep_for, sit_for): Use it.
3032 * doc.c (get_doc_string, store_function_docstring):
3033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3034 (get_doc_string, Fsnarf_documentation):
3035 Use int, not EMACS_INT, where int is wide enough.
3037 Use SAFE_ALLOCA, not alloca.
3038 Check for overflow when converting EMACS_INT to off_t.
3039 * doprnt.c (doprnt):
3040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3041 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3042 Don't assume uid_t fits into fixnum.
3043 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3044 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3045 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3046 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3047 (general_insert_function)
3048 (Finsert_char, make_buffer_string, make_buffer_string_both)
3049 (update_buffer_properties, Fbuffer_substring)
3050 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3051 (Fsubst_char_in_region, check_translation)
3052 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3053 (transpose_markers, Ftranspose_regions):
3054 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3055 (clip_to_bounds): Move to lisp.h as an inline function).
3056 (Fconstrain_to_field): Don't assume integers are nonnegative.
3057 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3058 (Fsubst_char_in_region, Fsave_restriction):
3059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3060 (Femacs_pid): Don't assume pid_t fits into fixnum.
3061 (lo_time): Use int, not EMACS_INT, when int suffices.
3062 (lisp_time_argument): Check for usec out of range.
3063 (Fencode_time): Don't assume fixnum fits in int.
3064 (Fuser_login_name, Fuser_full_name): Signal an error
3065 if a uid argument is out of range, rather than relying on
3067 (Fformat_time_string): Remove now-unnecessary check.
3068 lisp_time_argument checks for out-of-range usec now.
3069 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3070 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3071 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3072 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3073 (init_cmdargs, Fdump_emacs):
3074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3075 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3076 the bottom (typically) 32 bits of the fixnum.
3077 * eval.c (specpdl_size, call_debugger):
3078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3079 (when_entered_debugger, Fbacktrace_debug):
3080 Don't assume fixnum can fit in int.
3081 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3082 the object just before a buffer; this is not portable.
3083 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3084 (grow_specpdl, unbind_to):
3085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3086 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3087 (grow_specpdl): Simplify allocation by using xpalloc.
3088 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3089 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3090 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3092 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3095 (Fcopy_file, non_regular_nbytes, read_non_regular)
3096 (Finsert_file_contents):
3097 Use int, not EMACS_INT, where int is wide enough.
3098 (READ_BUF_SIZE): Verify that it fits in int.
3099 (Finsert_file_contents): Check that counts are in proper range,
3100 rather than assuming fixnums fit into ptrdiff_t etc.
3101 Don't assume fixnums fit into int.
3102 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3103 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3104 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3105 (string_char_to_byte, string_byte_to_char)
3106 (string_make_multibyte, string_to_multibyte)
3107 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3108 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3109 (substring_both, Fdelete, internal_equal, Ffillarray)
3110 (Fclear_string, mapcar1)
3111 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3112 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3113 (larger_vector, make_hash_table, maybe_resize_hash_table)
3114 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3115 (Fmaphash, secure_hash):
3116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3117 (concat): Check for string index and length overflow.
3118 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3121 (larger_vector): New API (vec, incr_min, size_max) replaces old
3122 one (vec, new_size, init). This catches size overflow.
3123 INIT was removed because it was always Qnil.
3124 All callers changed.
3125 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3126 the upper bound on a hash table index size.
3127 (make_hash_table, maybe_resize_hash_table): Use it.
3128 (secure_hash): Computer start_byte and end_byte only after
3129 they're known to be in ptrdiff_t range.
3130 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3131 (Ffont_get_glyphs, Ffont_at):
3132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3133 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3134 (Flist_fonts, Fopen_font):
3135 Don't assume fixnum can fit in int.
3136 (check_gstring): Don't assume index can fit in int.
3137 (font_match_p): Check that fixnum is a character, not a nonnegative
3138 fixnum, since the later code needs to stuff it into an int.
3139 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3140 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3141 conversion overflow issues.
3142 (Fopen_font): Check for integer out of range.
3143 (Ffont_get_glyphs): Don't assume index can fit in int.
3144 * font.h: Adjust decls to match defn changes elsewhere.
3145 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3147 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3148 printmax_t, where ptrdiff_t is wide enough.
3149 (Finternal_char_font):
3150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3151 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3152 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3153 (Fset_frame_position, x_set_frame_parameters)
3154 (x_set_line_spacing, x_set_border_width)
3155 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3156 Check that fixnums are in proper range for system types.
3157 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3159 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3160 Use SAFE_ALLOCA_LISP, not alloca.
3161 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3162 intptr_t is wide enough.
3163 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3164 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3165 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3166 Check for fixnum out of range.
3167 * ftfont.c (ftfont_list): Don't assume index fits in int.
3168 Check that fixnums are in proper range for system types.
3169 (ftfont_shape_by_flt):
3170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3171 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3173 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3174 Check that fixnums are in proper range for system types.
3175 * gnutls.h: Adjust decls to match defn changes elsewhere.
3176 * gtkutil.c (xg_dialog_run):
3177 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3178 (update_frame_tool_bar):
3179 Check that fixnums are in proper range for system types.
3180 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3181 (lookup_image): Check that fixnums are in range for system types.
3182 * indent.c (last_known_column, last_known_column_point):
3183 (current_column_bol_cache):
3184 (skip_invisible, current_column, check_display_width):
3185 (check_display_width, scan_for_column, current_column_1)
3186 (Findent_to, Fcurrent_indentation, position_indentation)
3187 (indented_beyond_p, Fmove_to_column, compute_motion):
3188 (Fcompute_motion, Fvertical_motion):
3189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3190 (last_known_column_modified): Use EMACS_INT, not int.
3191 (check_display_width):
3193 Check that fixnums and floats are in proper range for system types.
3194 (compute_motion): Don't assume index or fixnum fits in int.
3195 (compute_motion, Fcompute_motion):
3196 Use int, not EMACS_INT, when it is wide enough.
3197 (vmotion): Omit local var start_hpos that is always 0; that way
3198 we don't need to worry about overflow in expressions involving it.
3199 * indent.h: Adjust decls to match defn changes elsewhere.
3201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3202 Use int, not EMACS_INT, where int is wide enough.
3203 Remove unused members ovstring_chars_done and tab_offset;
3205 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3206 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3207 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3208 (make_gap, copy_text, insert, insert_and_inherit)
3209 (insert_before_markers, insert_before_markers_and_inherit)
3210 (insert_1, count_combining_before, count_combining_after)
3211 (insert_1_both, insert_from_string)
3212 (insert_from_string_before_markers, insert_from_string_1)
3213 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3214 (adjust_after_replace, adjust_after_insert, replace_range)
3215 (replace_range_2, del_range, del_range_1, del_range_byte)
3216 (del_range_both, del_range_2, modify_region)
3217 (prepare_to_modify_buffer, signal_before_change)
3218 (signal_after_change, Fcombine_after_change_execute):
3219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3220 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3221 (balance_an_interval, split_interval_right, split_interval_left)
3222 (find_interval, next_interval, update_interval)
3223 (adjust_intervals_for_insertion, delete_node, delete_interval)
3224 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3225 (static_offset_intervals, offset_intervals)
3226 (merge_interval_right, merge_interval_left, make_new_interval)
3227 (graft_intervals_into_buffer, temp_set_point_both)
3228 (temp_set_point, set_point, adjust_for_invis_intang)
3229 (set_point_both, move_if_not_intangible, get_property_and_range)
3230 (get_local_map, copy_intervals, copy_intervals_to_string)
3231 (compare_string_intervals, set_intervals_multibyte_1):
3232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3233 * intervals.h: Adjust decls to match defn changes elsewhere.
3235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3236 * keyboard.c (this_command_key_count, this_single_command_key_start)
3237 (before_command_key_count, before_command_echo_length, echo_now)
3238 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3239 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3240 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3241 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3243 (last_non_minibuf_size, last_point_position, echo_truncate)
3244 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3245 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3246 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3247 (stuff_buffered_input):
3248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3249 (last_auto_save, command_loop_1, read_char):
3250 Use EMACS_INT, not int, to avoid integer overflow.
3251 (record_char): Avoid overflow in total_keys computation.
3252 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3253 * keyboard.h: Adjust decls to match defn changes elsewhere.
3254 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3255 (Fkey_description, Fdescribe_vector, Flookup_key):
3256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3257 (click_position): New function, to check that positions are in range.
3258 (Fcurrent_active_maps):
3260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3261 (Faccessible_keymaps, Fkey_description):
3262 (preferred_sequence_p):
3263 Don't assume fixnum can fit into int.
3264 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3265 Check for integer overflow in size calculations.
3266 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3267 avoid mishandling large integers.
3268 * lisp.h: Adjust decls to match defn changes elsewhere.
3269 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3270 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3271 (struct Lisp_Marker):
3272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3273 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3274 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3275 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3276 All callers changed.
3277 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3278 Assume the arg has valid form, since it always does.
3279 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3280 unsigned integer system type.
3281 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3282 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3283 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3284 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3285 (duration_to_sec_usec): New decl.
3286 * lread.c (read_from_string_index, read_from_string_index_byte)
3287 (read_from_string_limit, readchar, unreadchar, openp)
3288 (read_internal_start, read1, oblookup):
3289 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3290 (Fload, readevalloop, Feval_buffer, Feval_region):
3291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3292 (openp): Check for out-of-range argument to 'access'.
3293 (read1): Use int, not EMACS_INT, where int is wide enough.
3294 Don't assume fixnum fits into int.
3295 Fix off-by-one error that can read outside a buffer.
3296 (read_filtered_event): Use duration_to_sec_usec
3297 to do proper overflow checking on durations.
3298 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3299 in size calculation.
3300 (Fexecute_kbd_macro):
3301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3302 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3303 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3304 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3305 (set_marker_both, set_marker_restricted_both, marker_position)
3306 (marker_byte_position, Fbuffer_has_markers_at):
3307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3308 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3309 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3310 It now merely ensures that the menu is large enough, without
3311 necessarily growing it, as this avoids some integer overflow issues.
3312 All callers changed.
3313 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3315 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3316 Use SAFE_ALLOCA_LISP, not alloca.
3317 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3318 to EMACS_INT. Check that fixnums are in proper range for system types.
3319 * minibuf.c (minibuf_prompt_width, string_to_object)
3320 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3321 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3323 (get_minibuffer, read_minibuf_unwind):
3324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3325 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3326 this simplifies overflow checking. All callers changed.
3327 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3330 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3331 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3332 Check that fixnums are in proper range for system types.
3333 (Fx_create_frame, Fx_show_tip):
3334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3335 * nsfont.m (ns_findfonts, nsfont_list_family):
3336 Don't assume fixnum fits in long.
3337 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3338 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3339 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3341 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3343 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3344 (PRINTDECLARE, PRINTPREPARE):
3345 (strout, print_string):
3346 (print, print_preprocess, print_check_string_charset_prop)
3348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3350 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3351 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3352 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3353 (printchar, strout): Use xpalloc to catch size calculation overflow.
3354 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3355 (print_error_message): Use SAFE_ALLOCA, not alloca.
3356 (print_object): Use int, not EMACS_INT, where int is wide enough.
3357 (print_depth, new_backquote_output, print_number_index):
3358 Use ptrdiff_t, not int, where int might not be wide enough.
3359 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3360 (Fset_process_window_size, Fformat_network_address)
3361 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3363 Check that fixnums are in proper range for system types.
3364 (Fsignal_process): Simplify by avoiding a goto.
3365 Check for process-ids out of pid_t range rather than relying on
3367 (process_tick, update_tick): Use EMACS_INT, not int.
3368 (Fformat_network_address, read_process_output, send_process)
3369 (Fprocess_send_region, status_notify):
3370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3371 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3372 (wait_reading_process_output, read_process_output, exec_sentinel):
3373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3374 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3375 (Faccept_process_output): Use duration_to_sec_usec to do proper
3376 overflow checking on durations.
3377 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3378 Don't assume pid_t fits in int.
3379 * process.h (struct Lisp_Process): Members tick and update_tick
3380 are now of type EMACS_INT, not int.
3381 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3382 configured --with-wide-int.
3383 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3384 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3385 * search.c (looking_at_1, string_match_1):
3386 (fast_string_match, fast_c_string_match_ignore_case)
3387 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3388 (scan_newline, find_before_next_newline, search_command)
3389 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3390 (set_search_regs, wordify):
3393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3394 (string_match_1, search_buffer, set_search_regs):
3396 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3397 (wordify): Check for overflow in size calculation.
3398 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3399 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3400 Check that fixnums are in proper range for system types.
3401 * sound.c (struct sound_device)
3402 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3404 (Fplay_sound_internal):
3405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3406 * syntax.c (struct lisp_parse_state, find_start_modiff)
3407 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3408 (Fparse_partial_sexp):
3409 Don't assume fixnums can fit in int.
3410 (struct lisp_parse_state, find_start_pos, find_start_value)
3411 (find_start_value_byte, find_start_begv)
3412 (update_syntax_table, char_quoted, dec_bytepos)
3413 (find_defun_start, prev_char_comend_first, back_comment):
3414 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3415 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3417 (Finternal_describe_syntax_value): Check that match_lisp is a
3418 character, not an integer, since the code stuffs it into int.
3419 (scan_words, scan_sexps_forward):
3420 Check that fixnums are in proper range for system types.
3422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3423 (scan_sexps_forward):
3424 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3425 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3426 * syntax.h: Adjust decls to match defn changes elsewhere.
3427 (struct gl_state_s):
3428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3429 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3430 MOST_POSITIVE_FIXNUM.
3431 * sysdep.c (wait_for_termination_1, wait_for_termination)
3432 (interruptible_wait_for_termination, mkdir):
3433 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3434 (emacs_read, emacs_write):
3435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3436 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3437 and double all fit in int.
3438 * term.c (set_tty_color_mode):
3439 Check that fixnums are in proper range for system types.
3440 * termhooks.h (struct input_event):
3441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3442 * textprop.c (validate_interval_range, interval_of)
3443 (Fadd_text_properties, set_text_properties_1)
3444 (Fremove_text_properties, Fremove_list_of_text_properties)
3445 (Ftext_property_any, Ftext_property_not_all)
3446 (copy_text_properties, text_property_list, extend_property_ranges)
3447 (verify_interval_modification):
3448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3449 (Fnext_single_char_property_change)
3450 (Fprevious_single_char_property_change):
3451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3452 (copy_text_properties):
3453 Check for integer overflow in index calculation.
3454 * undo.c (last_boundary_position, record_point, record_insert)
3455 (record_delete, record_marker_adjustment, record_change)
3456 (record_property_change):
3457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3458 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3460 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3461 (Fx_hide_tip, Fx_file_dialog):
3462 * w32menu.c (set_frame_menubar):
3463 Use ptrdiff_t, not int, for consistency with rest of code.
3464 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3465 (select_window, Fdelete_other_windows_internal)
3466 (window_scroll_pixel_based, window_scroll_line_based)
3467 (Frecenter, Fset_window_configuration):
3468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3469 (Fset_window_hscroll, run_window_configuration_change_hook)
3470 (set_window_buffer, temp_output_buffer_show, scroll_command)
3471 (Fscroll_other_window, Frecenter):
3472 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3473 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3474 Don't assume fixnum fits in int.
3475 (Fset_window_scroll_bars):
3476 Check that fixnums are in proper range for system types.
3477 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3478 (string_pos, c_string_pos, number_of_chars, init_iterator)
3479 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3480 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3481 (compute_display_string_end, handle_face_prop)
3482 (face_before_or_after_it_pos, handle_invisible_prop)
3483 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3484 (display_prop_intangible_p, string_buffer_position_lim)
3485 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3486 (get_overlay_strings_1, get_overlay_strings)
3487 (iterate_out_of_display_property, forward_to_next_line_start)
3488 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3489 (get_next_display_element, set_iterator_to_next)
3490 (get_visually_first_element, compute_stop_pos_backwards)
3491 (handle_stop_backwards, next_element_from_buffer)
3492 (move_it_in_display_line_to, move_it_in_display_line)
3493 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3494 (add_to_log, message_dolog, message_log_check_duplicate)
3495 (message2, message2_nolog, message3, message3_nolog
3496 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3497 (current_message_1, truncate_echo_area, truncate_message_1)
3498 (set_message, set_message_1, store_mode_line_noprop)
3499 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3500 (text_outside_line_unchanged_p, check_point_in_composition)
3501 (reconsider_clip_changes)
3502 (redisplay_internal, set_cursor_from_row, try_scrolling)
3503 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3504 (redisplay_window, find_last_unchanged_at_beg_row)
3505 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3506 (trailing_whitespace_p, find_row_edges, display_line)
3507 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3508 (display_mode_element, store_mode_line_string)
3509 (pint2str, pint2hrstr, decode_mode_spec)
3510 (display_count_lines, display_string, draw_glyphs)
3511 (x_produce_glyphs, x_insert_glyphs)
3512 (rows_from_pos_range, mouse_face_from_buffer_pos)
3513 (fast_find_string_pos, mouse_face_from_string_pos)
3514 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3516 (safe_call, init_from_display_pos, handle_fontified_prop)
3517 (handle_single_display_spec, load_overlay_strings)
3518 (with_echo_area_buffer, setup_echo_area_for_printing)
3519 (display_echo_area, echo_area_display)
3520 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3521 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3522 (redisplay_window, dump_glyph_row, display_mode_line)
3523 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3524 (handle_display_spec, display_prop_string_p):
3525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3526 (handle_single_display_spec, build_desired_tool_bar_string)
3527 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3528 (get_specified_cursor_type):
3529 Check that fixnums are in proper range for system types.
3530 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3531 (Flookup_image_map):
3532 Don't assume fixnums fit in int.
3533 (compare_overlay_entries):
3534 Avoid mishandling comparisons due to subtraction overflow.
3535 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3536 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3537 (handle_tool_bar_click):
3538 Use int, not unsigned, since we prefer signed and the signedness
3539 doesn't matter here.
3540 (get_next_display_element, next_element_from_display_vector):
3541 Use int, not EMACS_INT, when int is wide enough.
3542 (start_hourglass): Use duration_to_sec_usec to do proper
3543 overflow checking on durations.
3544 * xfaces.c (Fbitmap_spec_p):
3545 Check that fixnums are in proper range for system types.
3546 (compare_fonts_by_sort_order):
3547 Avoid mishandling comparisons due to subtraction overflow.
3548 (Fx_family_fonts, realize_basic_faces):
3549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3551 Don't assume fixnum fits in int.
3552 Use SAFE_ALLOCA_LISP, not alloca.
3553 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3554 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3555 (face_at_buffer_position, face_for_overlay_string)
3556 (face_at_string_position):
3557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3558 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3559 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3561 Check that fixnums are in proper range for system types.
3562 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3563 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3565 (Fx_change_window_property): Don't assume fixnums fit in int.
3566 * xfont.c (xfont_chars_supported):
3567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3568 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3569 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3571 * xml.c (parse_region):
3572 * xrdb.c (magic_file_p):
3573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3574 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3575 (x_get_local_selection, x_reply_selection_request)
3576 (x_handle_selection_request, wait_for_property_change):
3577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3578 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3579 short is wide enough.
3580 (x_send_client_event): Don't assume fixnum fits in int.
3581 * xterm.c (x_x_to_emacs_modifiers):
3582 Don't assume EMACS_INT overflows nicely into int.
3583 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3585 (handle_one_xevent): NATNUMP can eval its arg twice.
3586 (x_connection_closed):
3587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3588 * xterm.h: Adjust decls to match defn changes elsewhere.
3589 (struct scroll_bar): Use struct vectorlike_header
3590 rather than rolling our own approximation.
3591 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3593 2012-05-25 Glenn Morris <rgm@gnu.org>
3595 * lisp.mk (lisp): Update for more files being compiled now.
3597 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3599 * lread.c: Remove `read_pure' which makes no difference.
3600 (read_pure): Remove var.
3601 (unreadpure): Remove function.
3602 (readevalloop): Don't call read_list with -1 flag.
3603 (read1, read_vector): Don't test read_pure any more.
3604 (read_list): Simplify.
3606 * fileio.c, character.h: Minor style tweaks.
3608 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3610 * window.h (clip_changed): Remove useless declaration.
3612 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3614 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3615 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3617 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3620 This directory predates autoconf and is no longer needed nowadays.
3621 Move its few remaining bits of functionality to where they're needed.
3622 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3623 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3624 * m/template.h: Remove.
3625 * Makefile.in (M_FILE): Remove. All uses removed.
3626 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3627 * lisp.h (USE_LSB_TAG):
3628 * mem-limits.h (EXCEEDS_LISP_PTR):
3629 Use VAL_MAX, not VALBITS, in #if.
3630 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3631 (EMACS_UINT): Define unconditionally now.
3632 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3633 (BITS_PER_EMACS_INT): New constants, replacing
3634 what used to be in config.h, but not useful in #if.
3635 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3636 define them any more.
3637 (VAL_MAX): New macro.
3639 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3640 BITS_PER_EMACS_INT, in #if.
3641 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3642 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3643 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3644 * s/ms-w32.h (DATA_START):
3645 Move here from removed file m/intel386.h.
3646 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3647 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3649 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3651 Assume C89 or later.
3652 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3653 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3655 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3656 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3657 * textprop.c, tparam.c (NULL): Remove.
3658 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3659 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3660 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3661 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3662 * xterm.c (input_signal_count): Assume volatile works.
3664 2012-05-21 Ken Brown <kbrown@cornell.edu>
3666 * xgselect.c (xg_select): Fix first argument in call to 'select'
3669 2012-05-20 Ken Brown <kbrown@cornell.edu>
3671 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3672 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3674 2012-05-19 Ken Brown <kbrown@cornell.edu>
3676 * xfns.c (x_in_use): Remove `static' qualifier.
3677 * xterm.h (x_in_use): Declare.
3678 * xgselect.c: Include xterm.h.
3679 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3680 and `display_arg' (bug#9754).
3682 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3684 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3686 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3687 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3689 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3691 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3693 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3694 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3696 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3697 reference to image_cache->refcount.
3698 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3700 2012-05-17 Juri Linkov <juri@jurta.org>
3702 * search.c (Fword_search_regexp, Fword_search_backward)
3703 (Fword_search_forward, Fword_search_backward_lax)
3704 (Fword_search_forward_lax): Move functions to isearch.el
3705 (bug#10145, bug#11381).
3707 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3709 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3711 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3713 * lread.c (init_obarray): Declare Qt and Qnil as special.
3715 2012-05-14 Glenn Morris <rgm@gnu.org>
3717 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3718 Put "libexec" before "bin", for the sake of init_callproc_1.
3720 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3722 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3724 * unexaix.c: Port to more-recent AIX compilers.
3725 (report_error, report_error_1, make_hdr, copy_sym)
3726 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3727 Make arguments const char *, not char *, to avoid violations of C
3728 standard and to fix some AIX warnings reported by Gilles Pion.
3730 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3732 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3733 already have overlays loaded.
3734 (handle_single_display_spec): Before returning without displaying
3735 fringe bitmap, synchronize the bidi iterator with the main display
3736 iterator, by calling iterate_out_of_display_property.
3737 (iterate_out_of_display_property): Detect buffer iteration by
3738 testing that it->string is a Lisp string.
3739 (get_next_display_element): When the current object is exhausted,
3740 and there's something on it->stack, call set_iterator_to_next to
3741 proceed with what's on the stack, instead of returning zero.
3742 (set_iterator_to_next): If called at the end of a Lisp string,
3743 proceed to consider_string_end without incrementing string
3744 position. Don't increment display vector index past the end of
3745 the display vector. (Bug#11417)
3746 (pos_visible_p): Don't report a position visible when move_it_to
3747 stopped at the last line of window, which happens to be scanned
3748 backwards by the bidi iteration. (Bug#11464)
3750 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3752 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3753 and right-margin display specs even if the spec is invalid or we
3754 are on a TTY, and thus unable to display on the fringes.
3755 That's because the text with the property will not be displayed anyway,
3756 so we need to signal to the caller that this is a "replacing"
3757 display spec. This fixes display when the spec is invalid or we
3760 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3762 * unexaix.c (make_hdr): Fix typo in prototype.
3763 This bug broke the build on AIX. Problem reported by Gilles Pion.
3765 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3767 * keyboard.c (kbd_buffer_get_event): Read special events also in
3768 batch mode. (Bug#11415)
3770 2012-05-12 Glenn Morris <rgm@gnu.org>
3772 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3774 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3776 * lisp.mk (lisp): Add newcomment.elc.
3778 2012-05-12 Glenn Morris <rgm@gnu.org>
3780 * Makefile.in (MKDIR_P): New, set by configure.
3781 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3783 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3785 Remove unused function hourglass_started.
3786 * dispextern.h (hourglass_started):
3787 * w32fns.c (hourglass_started):
3788 * xdisp.c (hourglass_started): Remove.
3790 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3792 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3793 Update dependencies.
3795 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3797 * xgselect.c (xg_select): Put maxfds+1 into a var.
3798 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3800 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3802 2012-05-10 Dave Abrahams <dave@boostpro.com>
3804 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3805 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3807 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3809 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3810 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3811 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3812 Initialize xd_registered_buses.
3814 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3816 Untag more efficiently if USE_LSB_TAG.
3817 This is based on a proposal by YAMAMOTO Mitsuharu in
3818 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3819 For an admittedly artificial (nth 8000 longlist) benchmark on
3820 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3821 Emacs's overall text size by 1%.
3822 * lisp.h (XUNTAG): New macro.
3823 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3824 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3825 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3826 * eval.c (Fautoload):
3827 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3828 * frame.h (XFRAME): Use XUNTAG.
3830 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3831 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3832 Remove unportable assumptions about print widths of types like
3834 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3835 intptr_t when converting between pointer and integer, to avoid GCC
3836 warnings about wrong width.
3838 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3840 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3841 stack for each reader_thread, instead of defaulting to 8MB
3842 determined by the linker. This avoids failures in creating
3843 subprocesses on Windows 7, see the discussion in this thread:
3844 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3846 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3848 Fix up display of the *Minibuf-0* buffer in the mini window.
3849 * keyboard.c (read_char): Don't clear the echo area if there's no
3851 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3852 contents of *Minibuf-0*) if there's no message displayed in its stead.
3854 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3856 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3859 2012-05-06 Chong Yidong <cyd@gnu.org>
3861 * lisp.mk (lisp): Update.
3863 2012-05-05 Jim Meyering <meyering@redhat.com>
3865 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3867 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3869 * data.c (PUT_ERROR): New macro.
3870 (syms_of_data): Use it. Add new error type `user-error'.
3871 * undo.c (user_error): New function.
3872 (Fprimitive_undo): Use it.
3873 * print.c (print_error_message): Adjust print style for `user-error'.
3874 * keyboard.c (user_error): New function.
3875 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3877 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3879 Do not limit current-time-string to years 1000..9999.
3880 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3881 (Fcurrent_time_string): Support any year that is supported by the
3882 underlying localtime representation. Don't use asctime, as it
3883 has undefined behavior for years outside the range -999..9999.
3885 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3887 Fix race conditions involving setenv, gmtime, localtime, asctime.
3888 Without this fix, interrupts could mess up code that uses these
3889 nonreentrant functions, since setting TZ invalidates existing
3890 tm_zone or tzname values, and since most of these functions return
3891 pointers to static storage.
3892 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3893 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3894 Grow the critical sections to include not just invoking
3895 localtime/gmtime, but also accessing these functions' results
3896 including their tm_zone values if any, and any related TZ setting.
3897 (format_time_string): Last arg is now struct tm *, not struct tm **,
3898 so that the struct tm is saved in the critical section.
3899 All callers changed. Simplify allocation of initial buffer, partly
3900 motivated by the fact that memory allocation needs to be outside
3901 the critical section.
3903 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3905 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3906 with RESET_INTERVAL.
3908 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3909 Remove duplicated buffer name initialization.
3911 2012-05-02 Jim Meyering <jim@meyering.net>
3913 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3915 * xfns.c (x_window): Use xstrdup (Bug#11375).
3917 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3919 * xdisp.c (pos_visible_p): If already at a newline from the
3920 display string before the 'while' loop, don't walk back the glyphs
3921 from it3.glyph_row. Solves assertion violation when the display
3922 string begins with a newline (egg.el). (Bug#11367)
3924 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3926 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3929 2012-05-01 Glenn Morris <rgm@gnu.org>
3931 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3932 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3933 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3934 All were removed before 23.1.
3936 * dispnew.c: Remove HAVE_LIBNCURSES test;
3937 it is always true on relevant platforms.
3939 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3940 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3942 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3944 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3946 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3947 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3950 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3952 Do not avoid creating empty evaporating overlays (Bug#9642).
3953 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3954 That is, do not delete an evaporating overlay if it becomes
3955 empty after its bounds are adjusted to fit within its buffer.
3956 This fix caused other problems, and I'm reverting it until we get
3957 to the bottom of them.
3959 2012-04-27 Chong Yidong <cyd@gnu.org>
3961 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3963 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3965 * xdisp.c (pos_visible_p): If the window start position is beyond
3966 ZV, start the display from buffer beginning. Prevents assertion
3967 violation in init_iterator when the minibuffer window is scrolled
3970 * window.c (window_scroll_pixel_based): Likewise.
3972 2012-04-27 Chong Yidong <cyd@gnu.org>
3974 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3976 2012-04-27 Glenn Morris <rgm@gnu.org>
3978 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3979 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3981 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3983 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3984 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3986 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3988 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3989 display element, check also the underlying string or buffer
3990 character. (Bug#11341)
3992 * w32menu.c: Include w32heap.h.
3993 (add_menu_item): If the call to AppendMenuW (via
3994 unicode_append_menu) fails, disable Unicode menus only if we are
3995 running on Windows 9X/Me.
3997 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3999 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4000 (xgetint): Add missing shift for LSB tags.
4002 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4004 * keyboard.c (read_char): Don't wipe echo area for select window
4005 events: These might get delayed via `mouse-autoselect-window'
4008 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4010 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4011 manipulation of :loaded-from data.
4013 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4015 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4016 now a cons (bug#11311).
4018 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4020 Do not create empty overlays with the evaporate property (Bug#9642).
4021 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4022 if it becomes empty after its bounds are adjusted to fit within
4023 its buffer. Without this fix, in a nonempty buffer (let ((o
4024 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4025 yields an empty overlay that has the evaporate property, which is
4026 not supposed to happen.
4028 Fix minor GTK3 problems found by static checking.
4029 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4030 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4031 (struct _EmacsFixedClass, emacs_fixed_get_type):
4032 Move decls here from emacsgtkfixed.h, since they needn't be public.
4033 (emacs_fixed_get_type): Now static.
4034 (emacs_fixed_class_init): Omit unused local.
4035 (emacs_fixed_child_type): Remove; unused.
4036 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4037 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4038 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4039 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4040 (EMACS_FIXED_GET_CLASS): Remove; unused.
4041 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4043 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4044 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4046 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4048 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4049 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4050 (__malloc_size_t, __malloc_ptrdiff_t):
4051 Remove. All uses removed, replaced by the definiens if needed,
4052 since we can assume C89 or better now.
4053 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4054 (protect_malloc_state, align, get_contiguous_space)
4055 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4056 (malloc_atfork_handler_child, malloc_enable_thread)
4057 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4058 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4059 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4060 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4061 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4062 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4063 Define using prototypes, not old style.
4064 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4065 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4066 (align): Don't assume that signed integer overflow wraps around.
4067 Omit unused local var.
4068 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4069 (_free_internal_nolock, memalign, mallochook, reallochook):
4070 Omit no-longer-needed casts.
4071 (valloc): Use getpagesize, not __getpagesize.
4072 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4073 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4075 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4077 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4079 Move functions from C to Lisp. Make non-blocking method calls
4080 the default. Implement further D-Bus standard interfaces.
4082 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4083 (QCdbus_request_name_allow_replacement)
4084 (QCdbus_request_name_replace_existing)
4085 (QCdbus_request_name_do_not_queue)
4086 (QCdbus_request_name_reply_primary_owner)
4087 (QCdbus_request_name_reply_in_queue)
4088 (QCdbus_request_name_reply_exists)
4089 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4090 (QCdbus_registered_serial, QCdbus_registered_method)
4091 (QCdbus_registered_signal): New Lisp objects.
4092 (XD_DEBUG_MESSAGE): Use sizeof.
4093 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4094 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4095 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4096 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4097 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4098 (xd_signature, xd_append_arg): Allow float for integer types.
4099 (xd_get_connection_references): New function.
4100 (xd_get_connection_address): Rename from xd_initialize.
4101 Return cached address.
4102 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4103 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4105 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4106 Return number of refcounts.
4107 (Fdbus_get_unique_name): Make stronger parameter check.
4108 (Fdbus_message_internal): New defun.
4109 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4110 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4111 (Fdbus_send_signal, Fdbus_register_service)
4112 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4113 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4114 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4115 (Vdbus_compiled_version, Vdbus_runtime_version)
4116 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4117 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4118 (Vdbus_message_type_signal): New defvars.
4119 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4122 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4124 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4125 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4126 Do not assume ptrdiff_t is the same width as 'int'.
4128 * alloc.c: Handle unusual debugging option combinations.
4129 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4130 since the two debugging options are incompatible.
4131 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4133 (mem_init, mem_insert, mem_insert_fixup):
4134 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4135 (NEED_MEM_INSERT): Remove; no longer needed.
4137 2012-04-22 Leo Liu <sdl.web@gmail.com>
4139 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4141 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4143 * sysdep.c [__FreeBSD__]: Minor cleanups.
4144 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4145 Use Emacs indenting style more consistently. Avoid some casts.
4146 Use 'double' consistently rather than mixing 'float' and 'double'.
4148 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4150 * sysdep.c (list_system_processes, system_process_attributes):
4151 Add implementation for FreeBSD (Bug#5243).
4153 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4155 * lisp.mk (lisp): Update.
4157 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4159 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4160 It is never used otherwise.
4162 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4164 * print.c (print_preprocess): Only check print_depth if print-circle
4166 (print_object): Check for cycles even when print-circle is nil and
4167 print-gensym is t, but only check print_depth if print-circle is nil.
4169 2012-04-20 Chong Yidong <cyd@gnu.org>
4171 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4172 set the status to "failed" and ensure that sentinel is run.
4174 2012-04-20 Glenn Morris <rgm@gnu.org>
4176 * process.c (Fset_process_inherit_coding_system_flag)
4177 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4178 (Fmake_network_process, Fmake_serial_process): Doc fix.
4180 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4182 * xdisp.c (string_buffer_position_lim): Limit starting position to
4184 (set_cursor_from_row): If called for a mode-line or header-line
4185 row, return zero immediately.
4186 (try_cursor_movement): If inside continuation line, don't back up
4187 farther than the first row after the header line, if any.
4188 Don't consider the header-line row as "partially visible", even if
4189 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4191 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4193 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4196 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4197 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4199 configure: new option --enable-gcc-warnings (Bug#11207)
4200 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4201 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4202 (ALL_CFLAGS): Use new macros rather than old.
4203 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4204 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4205 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4206 -Wunused-result, -Wunused-variable. This should go away once
4207 the Emacs and Gnulib regex code is merged.
4208 (xmalloc, xrealloc): Now static.
4210 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4212 * dired.c (Fsystem_groups): Remove unused local.
4214 2012-04-17 Glenn Morris <rgm@gnu.org>
4216 * dired.c (Fsystem_users): Doc fix.
4218 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4220 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4221 (syms_of_dired): Add them.
4223 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4225 Fix minor alloc.c problems found by static checking.
4226 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4227 New extern decls, to avoid calling undeclared functions.
4228 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4229 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4230 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4231 (NEED_MEM_INSERT): New macro.
4232 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4233 Remove one incorrect comment and fix another.
4235 Fix minor ralloc.c problems found by static checking.
4236 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4237 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4238 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4239 (r_alloc_sbrk): Now static.
4241 Improve ralloc.c interface checking.
4242 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4243 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4244 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4245 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4246 [REL_ALLOC]: ... to here, to check interface.
4247 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4248 Remove decls. This fixes an "It stinks!".
4250 * alloc.c (which_symbols): Fix alignment issue / type clash.
4252 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4254 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4255 (struct Lisp_Misc_Any): Likewise.
4256 (struct Lisp_Free): Likewise.
4257 * alloc.c (union aligned_Lisp_Symbol): Define.
4258 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4259 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4260 (union aligned_Lisp_Misc): Define.
4261 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4262 aligned_Lisp_Misc instead of union Lisp_Misc.
4263 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4265 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4267 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4268 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4269 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4270 * s/netbsd.h, s/sol2-6.h:
4271 Remove definition of GC_MARK_STACK, since the default now works.
4272 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4273 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4274 no longer the default.
4275 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4277 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4279 * lread.c (lisp_file_lexically_bound_p):
4280 Fix hang at ";-*-\n" (bug#11238).
4282 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4284 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4285 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4287 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4289 * nsterm.m (constrainFrameRect): Always constrain when there is only
4290 one screen (Bug#10962).
4292 2012-04-13 Ken Brown <kbrown@cornell.edu>
4294 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4296 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4298 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4300 2012-04-11 Daniel Colascione <dancol@dancol.org>
4302 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4303 against is gone. It's better to use vfork now so that when Cygwin
4304 gains a new, working vfork, we use it automatically (bug#10398).
4306 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4308 * window.c (save_window_save): Obey window-point-insertion-type.
4310 2012-04-11 Glenn Morris <rgm@gnu.org>
4312 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4314 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4316 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4318 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4320 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4321 (force_quit_count): New var.
4322 (handle_interrupt): Use it.
4324 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4326 * w32.c (w32_delayed_load): Record the full path of the library
4327 being loaded (bug#10424).
4329 2012-04-09 Glenn Morris <rgm@gnu.org>
4331 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4332 not just in the obarray, before snarfing them. (Bug#11036)
4334 * Makefile.in ($(leimdir)/leim-list.el):
4335 Pass EMACS rather than BUILT_EMACS.
4337 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4339 * process.c (make_process):
4340 * process.h: Add integer `gnutls_handshakes_tried' member to
4343 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4344 Add convenience `GNUTLS_LOG2i' macro.
4346 * gnutls.c (gnutls_log_function2i): Convenience log function.
4347 (emacs_gnutls_read): Use new log functions,
4348 `gnutls_handshakes_tried' process member, and
4349 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4350 attempts per process (connection).
4352 2012-04-09 Chong Yidong <cyd@gnu.org>
4354 * eval.c (Fuser_variable_p, user_variable_p_eh)
4355 (lisp_indirect_variable): Functions deleted.
4356 (Fdefvar): Caller changed.
4358 * callint.c (Finteractive, Fcall_interactively):
4359 * minibuf.c (Fread_variable): Callers changed.
4361 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4363 * xdisp.c (set_cursor_from_row): If the display string appears in
4364 the buffer at position that is closer to point than the position
4365 after the display string, display the cursor on the first glyph of
4366 the display string. Fixes cursor display when a 'display' text
4367 property immediately follows invisible text. (Bug#11094)
4369 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4371 composite.c: use 'double' consistently
4372 * composite.c (get_composition_id): Use 'double' consistently
4373 instead of converting 'float' to 'double' and vice versa; this is
4374 easier to understand and avoids a GCC warning.
4376 2012-04-09 Glenn Morris <rgm@gnu.org>
4378 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4379 preparation for dumping it with emacs. (Bug#4789)
4380 (leimdir): New variable.
4381 ($(leimdir)/leim-list.el): New rule.
4382 (emacs$(EXEEXT)): Depend on leim-list.el.
4384 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4385 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4386 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4388 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4390 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4393 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4395 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4396 Remove unused local variable.
4398 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4400 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4401 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4402 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4403 objects, as mark_maybe_pointer will catch them otherwise.
4404 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4405 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4407 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4409 Fix typo that broke non-Windows builds.
4410 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4412 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4414 Support building on MS-Windows with libxml2.
4416 * makefile.w32-in (OBJ2): Add xml.$(O).
4417 (GLOBAL_SOURCES): Add xml.c.
4418 ($(BLD)/xml.$(O)): New dependency list.
4420 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4421 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4422 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4423 [!WINDOWSNT]: New macros.
4424 (init_libxml2_functions, libxml2_loaded_p): New functions.
4425 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4426 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4427 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4428 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4430 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4431 Call init_libxml2_functions before calling libxml2 functions.
4432 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4434 * emacs.c: Don't include libxml/parser.h.
4435 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4436 xmlCleanupParser directly.
4438 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4440 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4442 * indent.c (Fvertical_motion): If there is a display string at
4443 point, use it.vpos to compute how many lines to backtrack after
4444 move_it_to point. (Bug#11133)
4446 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4448 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4449 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4450 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4451 macros related to unification of CJK characters. For the details,
4452 see the discussion following the message here:
4453 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4455 2012-04-04 Chong Yidong <cyd@gnu.org>
4457 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4459 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4461 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4462 instead of alloca. (Bug#11138)
4464 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4466 * w32menu.c (is_simple_dialog): Properly check lisp types.
4469 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4471 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4472 position we get to after a call to move_it_to fails the
4473 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4474 only if we wind up in a string from display property. (Bug#11063)
4476 * window.c (Fdelete_other_windows_internal): Invalidate the row
4477 and column information about mouse highlight, so that redisplay
4478 restores it after reallocating the glyph matrices. (Bug#7464)
4480 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4481 string comes from a `display' text property, use the buffer
4482 position of that property as if we actually saw that position in
4484 (move_it_by_lines): Remove the assertion that
4485 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4486 violated when there's a before-string at the beginning of a line.
4489 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4491 * xdisp.c (append_space_for_newline): If the default face was
4492 remapped, use the remapped face for the appended newline.
4493 (extend_face_to_end_of_line): Use the remapped default face for
4494 extending the face to the end of the line.
4495 (display_line): Call extend_face_to_end_of_line when the default
4496 face was remapped. (Bug#11068)
4498 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4500 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4502 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4504 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4506 2012-03-27 Glenn Morris <rgm@gnu.org>
4508 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4511 2012-03-26 Kenichi Handa <handa@m17n.org>
4513 * dispextern.h (struct glyph): Fix previous change. Change the
4514 bit length of glyphless.ch to 25 (Bug#11082).
4516 2012-03-26 Chong Yidong <cyd@gnu.org>
4518 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4519 (command_loop_1): Use it; inhibit selection update for
4520 handle-select-window too (Bug#8996).
4522 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4524 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4526 2012-03-25 Kenichi Handa <handa@m17n.org>
4528 * dispextern.h (struct glyph): Change the bit length of
4529 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4531 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4533 * s/ms-w32.h (tzname): Include time.h before redirecting to
4534 _tzname. Fixes the MSVC build. (Bug#9960)
4536 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4538 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4541 * xterm.c (XTread_socket): Only modify handling_signal if
4542 !SYNC_INPUT. (Bug#11080)
4544 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4546 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4547 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4548 when fetching a multibyte character consumes more bytes than
4549 CHAR_BYTES returns, due to unification of CJK characters in
4550 string_char. (Bug#11073)
4552 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4554 * process.c (wait_reading_process_output): Handle pty disconnect
4555 by refraining from sending oneself a SIGCHLD (bug#10933).
4557 2012-03-22 Chong Yidong <cyd@gnu.org>
4559 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4561 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4562 Mark string as coming from a prefix property.
4563 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4564 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4566 2012-03-21 Chong Yidong <cyd@gnu.org>
4568 * xfaces.c (Vface_remapping_alist): Doc fix.
4570 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4572 * w32proc.c (Fw32_set_console_codepage)
4573 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4576 2012-03-20 Chong Yidong <cyd@gnu.org>
4578 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4579 to reflect default non-nil value of redisplay-dont-pause.
4581 2012-03-19 Kenichi Handa <handa@m17n.org>
4583 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4584 it fit in a valid range (Bug#11003).
4586 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4588 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4589 that is not from display property, accept the row as a "cursor
4590 row" if one of the string's character has a non-nil `cursor'
4591 property. Fixes cursor positioning when there are newlines in
4592 overlay strings, e.g. in icomplete.el. (Bug#11035)
4594 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4596 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4598 2012-03-12 Chong Yidong <cyd@gnu.org>
4600 * eval.c (inhibit_lisp_code): Rename from
4601 inhibit_window_configuration_change_hook; move from window.c.
4603 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4604 * window.c (run_window_configuration_change_hook)
4605 (syms_of_window): Callers changed.
4607 2012-03-11 Chong Yidong <cyd@gnu.org>
4609 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4611 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4613 2012-03-10 Chong Yidong <cyd@gnu.org>
4615 * frame.c (other_visible_frames): Don't assume the selected frame
4616 is visible (Bug#10955).
4618 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4620 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4622 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4624 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4625 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4628 2012-03-03 Glenn Morris <rgm@gnu.org>
4630 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4632 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4634 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4635 position past the first glyph_row that ends at ZV. (Bug#10902)
4636 (redisplay_window, next_element_from_string): Fix typos in
4638 (redisplay_window): Pass to move_it_vertically the margin in
4639 pixels, not in screen lines.
4641 2012-03-02 Glenn Morris <rgm@gnu.org>
4643 * buffer.c (buffer-list-update-hook): Doc fix.
4645 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4647 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4648 push_it before setting up the iterator for the first overlay
4649 string, even if we have an empty string loaded.
4650 (next_overlay_string): If there's an empty string on the iterator
4651 stack, pop the stack. (Bug#10903)
4653 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4655 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4656 Suggested by Stefan Monnier in
4657 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4658 * alloc.c (widen_to_Lisp_Object): New static function.
4659 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4660 and widening them to Lisp_Objects. This would work even if
4661 USE_LSB_TAG is defined and wide integers are used, which might
4662 happen in a future version of Emacs.
4664 2012-02-25 Chong Yidong <cyd@gnu.org>
4666 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4669 * xselect.c (Fx_selection_exists_p): Doc fix.
4670 (x_clipboard_manager_save_all): Print an informative message
4671 before saving to clipboard manager.
4673 2012-02-24 Chong Yidong <cyd@gnu.org>
4675 * keyboard.c (process_special_events): Handle all X selection
4676 requests in kbd_buffer, not just the next one (Bug#8869).
4678 2012-02-23 Chong Yidong <cyd@gnu.org>
4680 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4681 call when setting menu-bar-lines and tool-bar-lines parameters.
4682 (unwind_create_frame_1): New helper function.
4684 * window.c (inhibit_window_configuration_change_hook): New var.
4685 (run_window_configuration_change_hook): Obey it.
4686 (syms_of_window): Initialize it.
4688 2012-02-22 Chong Yidong <cyd@gnu.org>
4690 * xterm.c (x_draw_image_relief): Add missing type check for
4691 Vtool_bar_button_margin (Bug#10743).
4693 2012-02-21 Chong Yidong <cyd@gnu.org>
4695 * fileio.c (Vfile_name_handler_alist): Doc fix.
4697 * buffer.c (Fget_file_buffer): Protect against invalid file
4698 handler return value.
4700 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4702 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4703 when computing $valmask.
4705 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4706 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4707 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4708 It's useless in that case, and it can cause problems on hosts
4709 that allocate halves of EMACS_INT values separately.
4710 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4711 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4712 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4713 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4714 it avoids undefined behavior on hosts where shifting right by more
4715 than the word width has undefined behavior.
4717 2012-02-19 Chong Yidong <cyd@gnu.org>
4719 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4720 (Funhandled_file_name_directory, Ffile_name_as_directory)
4721 (Fdirectory_file_name, Fexpand_file_name)
4722 (Fsubstitute_in_file_name): Protect against invalid file handler
4723 return values (Bug#10845).
4725 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4727 * .gdbinit (pitx): Fix incorrect references to fields of the
4730 2012-02-17 Chong Yidong <cyd@gnu.org>
4732 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4734 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4736 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4737 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4739 2012-02-15 Chong Yidong <cyd@gnu.org>
4741 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4742 marked as special. Also, starting docstrings with * is obsolete.
4744 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4746 * gnutls.c (emacs_gnutls_write): Fix last change.
4748 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4750 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4753 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4755 * keymap.c (Fsingle_key_description): Handle char ranges.
4757 2012-02-12 Chong Yidong <cyd@gnu.org>
4759 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4760 as that creates a dangerous corner case.
4762 * window.c (Fdelete_window_internal): Invalidate the mouse
4763 highlight (Bug#9904).
4765 2012-02-12 Glenn Morris <rgm@gnu.org>
4767 * xselect.c (Fx_own_selection_internal)
4768 (Fx_get_selection_internal, Fx_disown_selection_internal)
4769 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4770 * nsselect.m (Fx_own_selection_internal)
4771 (Fx_disown_selection_internal, Fx_selection_exists_p)
4772 (Fx_selection_owner_p, Fx_get_selection_internal):
4773 Sync docs and argument specs with the xselect.c versions.
4775 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4777 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4779 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4781 * w32select.c (Fx_selection_exists_p): Sync doc string and
4782 argument list with xselect.c. (Bug#10783)
4784 * w16select.c (Fx_selection_exists_p): Sync doc string and
4785 argument list with xselect.c. (Bug#10783)
4787 2012-02-10 Glenn Morris <rgm@gnu.org>
4789 * fns.c (Fsecure_hash): Doc fix.
4791 2012-02-09 Kenichi Handa <handa@m17n.org>
4793 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4795 2012-02-07 Chong Yidong <cyd@gnu.org>
4797 * buffer.c (Fbuffer_local_variables)
4798 (buffer_lisp_local_variables): Handle unbound vars correctly;
4799 don't let Qunbound leak into Lisp.
4801 2012-02-07 Glenn Morris <rgm@gnu.org>
4803 * image.c (Fimagemagick_types): Doc fix.
4805 * image.c (imagemagick-render-type): Change it from a lisp object
4806 to an integer. Move the doc here from the lisp manual.
4807 Treat all values not equal to 0 the same.
4809 2012-02-06 Chong Yidong <cyd@gnu.org>
4811 * doc.c (store_function_docstring): Avoid applying docstring of
4812 alias to base function (Bug#2603).
4814 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4816 * .gdbinit (pp1, pv1): Remove redundant defines.
4819 2012-02-04 Chong Yidong <cyd@gnu.org>
4821 * nsterm.m: Declare a global (Bug#10694).
4823 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4825 * w32.c (get_emacs_configuration_options):
4826 Include --enable-checking, if specified, in the return value.
4828 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4830 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4831 after rounding frame sizes. (Bug#9723)
4833 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4835 * keyboard.c (adjust_point_for_property): Don't position point
4836 before BEGV. (Bug#10696)
4838 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4840 Handle overflow when computing char display width (Bug#9496).
4841 * character.c (char_width): Return EMACS_INT, not int.
4842 (char_width, c_string_width): Check for overflow when
4843 computing the width; this is possible now that individual
4844 characters can have unbounded width. Problem introduced
4845 by merge from Emacs 23 on 2012-01-19.
4847 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4849 * dbusbind.c (Fdbus_register_method): Mention the return value
4850 :ignore in the docstring.
4852 2012-02-02 Glenn Morris <rgm@gnu.org>
4854 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4856 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4857 Unconditionally set to t. (Bug#10673)
4858 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4859 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4860 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4862 2012-02-02 Kenichi Handa <handa@m17n.org>
4864 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4865 0, do not call append_composite_glyph.
4867 2012-02-02 Kenichi Handa <handa@m17n.org>
4869 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4871 (x_produce_glyphs): If the component of a composition is a null
4872 string, set it->pixel_width to 1 to avoid zero-width glyph.
4874 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4876 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4877 first 2 arguments are identical. This makes inserting large
4878 output from a subprocess an order of magnitude faster on
4879 MS-Windows, where all sbrk'ed memory is always contiguous.
4881 2012-01-31 Glenn Morris <rgm@gnu.org>
4883 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4884 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4885 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4887 2012-01-29 Glenn Morris <rgm@gnu.org>
4889 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4891 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4893 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4895 2012-01-28 Chong Yidong <cyd@gnu.org>
4897 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4899 2012-01-26 Chong Yidong <cyd@gnu.org>
4901 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4903 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4904 repeat counts (Bug#10507).
4906 2012-01-26 Glenn Morris <rgm@gnu.org>
4908 * lread.c (syms_of_lread): Doc fix.
4910 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4912 * coding.c (encode_designation_at_bol): Change return value to
4915 2012-01-25 Chong Yidong <cyd@gnu.org>
4917 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4919 2012-01-21 Chong Yidong <cyd@gnu.org>
4921 * floatfns.c (Fcopysign): Make the second argument non-optional,
4922 since nil is not allowed anyway.
4924 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4926 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4927 (send_process): Likewise.
4929 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4931 * window.c (save_window_save, Fcurrent_window_configuration)
4932 (Vwindow_persistent_parameters): Do not use Qstate.
4933 Rewrite doc-strings.
4935 2012-01-19 Kenichi Handa <handa@m17n.org>
4937 * character.c (char_width): New function.
4938 (Fchar_width, c_string_width, lisp_string_width):
4939 Use char_width (Bug#9496).
4941 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4943 * window.c (Vwindow_persistent_parameters): New variable.
4944 (Fset_window_configuration, save_window_save): Handle persistent
4947 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4949 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4950 thrashing the stack of the thread. (Bug#9087)
4952 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4954 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4956 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4958 * xdisp.c (rows_from_pos_range): Handle the case where the
4959 highlight ends on a newline. (Bug#10464)
4960 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4961 he end column for display of highlight that ends on a newline
4964 2012-01-11 Glenn Morris <rgm@gnu.org>
4966 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4967 from load-path also when installation-directory is nil. (Bug#10208)
4969 2012-01-10 Glenn Morris <rgm@gnu.org>
4971 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4973 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4974 Update template values to be closer to their typical values these days.
4976 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4978 * xdisp.c (rows_from_pos_range): Accept additional argument
4979 DISP_STRING, and accept any glyph in a row whose object is that
4980 string as eligible for mouse highlight. Fixes mouse highlight of
4981 display strings from overlays. (Bug#10464)
4983 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4985 emacs: fix an auto-save permissions race condition (Bug#10400)
4986 * fileio.c (auto_saving_dir_umask): New static var.
4987 (Fmake_directory_internal): Use it.
4988 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4989 creating the directory. The old code temporarily assigns
4990 too-generous permissions to the directory.
4991 (do_auto_save_eh): Clear it.
4992 (Fdo_auto_save): Catch all errors, not just file errors, so
4993 that the var is always cleared.
4995 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4997 * search.c (scan_buffer): Pass character positions to
4998 know_region_cache, not byte positions. (Bug#6540)
5000 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5002 * w32.c (sys_rename): Report EXDEV when rename of a directory
5003 fails because the target is on another logical disk. (Bug#10284)
5005 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5007 * xterm.c (x_embed_request_focus): New function.
5009 * xterm.h: Add prototype.
5011 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5013 2012-01-05 Glenn Morris <rgm@gnu.org>
5015 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5017 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5019 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5020 Load gnutls_transport_set_lowat only if GnuTLS version is below
5022 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5023 GnuTLS versions below 2.11.1.
5025 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5027 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5028 to the doc string advising against its use for altering the way
5029 windows are scrolled.
5031 2011-12-28 Kenichi Handa <handa@m17n.org>
5033 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5034 coding-system ASCII compatible only when it does not produce BOM
5035 on encoding (Bug#10383).
5037 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5039 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5041 (create_and_show_popup_menu): Always use menu_position_func for
5044 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5046 * callint.c (Fcall_interactively): Don't truncate prompt string.
5048 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5050 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5051 property that ends at ZV, so that the bidi iteration could be
5052 resumed from there (after widening). (Bug#10360)
5054 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5056 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5058 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5060 * nsterm.m (x_free_frame_resources):
5061 Release f->output_data.ns->miniimage.
5062 (ns_index_color): Fix indentation. Do not retain
5063 color_table->colors[i].
5065 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5068 * nsfns.m (x_set_background_color): Assign return value from
5069 ns_index_color to face-background instead of NSColor*.
5070 (ns_implicitly_set_icon_type): Fix indentation.
5071 Change assignment in for loop to comparison.
5073 * emacs.c (ns_pool): New variable.
5074 (main): Assign ns_pool.
5075 (Fkill_emacs): Call ns_release_autorelease_pool.
5077 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5078 autorelease fdesc, release fdAttrs and tdict.
5079 (ns_get_covering_families): Release charset.
5080 (ns_findfonts): Release NSFontDescriptor created with new.
5081 (ns_uni_to_glyphs): Fix indentation.
5082 (setString): Release attrStr before assigning new value.
5084 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5086 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5088 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5089 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5091 2011-12-18 David Reitter <reitter@cmu.edu>
5093 * nsterm.m (ns_term_init): Subscribe for notifications
5094 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5095 to method trackingNotification in EmacsMenu.
5097 * nsmenu.m (trackingMenu): New variable.
5098 (trackingNotification): New method (from Aquamacs).
5099 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5100 from Aquamacs (Bug#7030).
5102 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5104 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5105 (symbol_to_nsstring): Fix indentation.
5106 (ns_symbol_to_pb): New function.
5107 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5108 (Fns_rotate_cut_buffers_internal): Remove.
5109 (Fns_store_selection_internal): Rename from
5110 Fns_store_cut_buffer_internal.
5111 (ns_get_foreign_selection, Fx_own_selection_internal)
5112 (Fx_disown_selection_internal, Fx_selection_exists_p)
5113 (Fns_get_selection_internal, Fns_store_selection_internal):
5114 Use ns_symbol_to_pb and check if return value is nil.
5115 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5116 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5117 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5118 renamed to Sns_store_selection_internal.
5119 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5120 and remove this function.
5121 (ns_handle_selection_clear): Remove, never used.
5122 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5125 2011-12-17 Ken Brown <kbrown@cornell.edu>
5127 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5128 GID is unknown (Bug#10257).
5130 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5132 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5133 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5134 which caused a build failure on GNU/Linux IA-64. This problem was
5135 introduced by my 2011-10-07 patch.
5137 2011-12-15 Juri Linkov <juri@jurta.org>
5139 * image.c (imagemagick_error): New function. (Bug#10112)
5140 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5141 Use `imagemagick_error' where ImageMagick functions return
5143 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5146 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5148 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5149 fill background (Bug#8992).
5151 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5153 * window.c (Vwindow_combination_resize)
5154 (Vwindow_combination_limit): Use t instead of non-nil in
5156 (Vrecenter_redisplay): Add first sentence of doc-string on
5158 (Frecenter): Fix doc-string typo.
5160 2011-12-11 Kenichi Handa <handa@m17n.org>
5162 * coding.c (Funencodable_char_position): Pay attention to the
5163 buffer text relocation (Bug#9389).
5165 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5167 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5168 gtk_init (Bug#10100).
5170 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5172 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5173 IT->string is nil. (Bug#10263)
5175 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5177 * nsterm.h (x_free_frame_resources): Declare.
5179 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5180 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5182 * nsterm.h (ns_get_defaults_value): Declare.
5184 * nsterm.m (ns_default): Call ns_get_defaults_value.
5186 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5188 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5191 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5193 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5194 that where the value of an _OBJC_* symbol points to is in the .bss
5195 section (Bug#10240).
5197 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5199 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5200 after the loop to call ccl_driver at least once (Bug#8619).
5202 2011-12-08 Kenichi Handa <handa@m17n.org>
5204 * ftfont.c (get_adstyle_property): Fix previous change
5207 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5209 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5210 dirs from the default value of EMACSLOADPATH (bug#10208).
5212 2011-12-07 Glenn Morris <rgm@gnu.org>
5214 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5215 installation and source directories as well. (Bug#10208)
5217 2011-12-06 Chong Yidong <cyd@gnu.org>
5219 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5221 2011-12-06 Glenn Morris <rgm@gnu.org>
5223 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5224 as an error, not just -1. (Bug#10217)
5226 2011-12-05 Chong Yidong <cyd@gnu.org>
5228 * keyboard.c (process_special_events): New function.
5229 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5231 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5233 * coding.c (encode_designation_at_bol): Don't use uninitialized
5234 local variable (Bug#9318).
5236 2011-12-05 Kenichi Handa <handa@m17n.org>
5238 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5239 return Qnil (Bug#8046, Bug#10193).
5241 2011-12-05 Kenichi Handa <handa@m17n.org>
5243 * coding.c (encode_designation_at_bol): New args charbuf_end and
5244 dst. Return the number of produced bytes. Callers changed.
5245 (coding_set_source): Return how many bytes coding->source was
5247 (coding_set_destination): Return how many bytes
5248 coding->destination was relocated.
5249 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5250 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5252 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5254 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5255 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5258 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5260 The following changes are to fix Bug#9318.
5262 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5263 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5264 (encode_coding_iso_2022, encode_coding_sjis)
5265 (encode_coding_big5, encode_coding_charset): Use the above macros.
5267 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5269 * lisp.h (process_quit_flag): Fix external declaration.
5271 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5273 Don't macro-inline non-performance-critical code.
5274 * eval.c (process_quit_flag): New function.
5275 * lisp.h (QUIT): Use it.
5277 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5279 * nsfns.m (get_geometry_from_preferences): New function.
5280 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5282 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5284 * emacs.c (Qkill_emacs): Define.
5285 (syms_of_emacs): Initialize it.
5286 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5287 Qquit_flag to `kill-emacs' instead.
5288 (quit_throw_to_read_char): Add parameter `from_signal'.
5289 All callers changed. Call Fkill_emacs if requested and safe.
5290 * lisp.h (QUIT): Call Fkill_emacs if requested.
5292 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5294 * widget.c (update_wm_hints): Return if wmshell is null.
5295 (widget_update_wm_size_hints): New function.
5297 * widget.h (widget_update_wm_size_hints): Declare.
5299 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5300 widget_update_wm_size_hints (Bug#10104).
5302 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5304 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5305 before a newline, prepare the bidi iterator for consuming the
5306 newline, and keep the current paragraph direction. (Bug#10183)
5307 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5309 2011-12-02 Juri Linkov <juri@jurta.org>
5311 * search.c (Fword_search_regexp): New Lisp function created from
5312 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5313 (Fword_search_backward, Fword_search_forward)
5314 (Fword_search_backward_lax, Fword_search_forward_lax):
5315 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5316 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5318 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5320 * fileio.c (Finsert_file_contents): Move after-change-function call
5321 to before the "handled:" label, since all "goto handled" appear in
5322 cases where the *-change-functions have already been properly called
5325 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5327 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5328 waiting for input. (Bug#10169)
5330 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5332 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5333 verifies glyph row's hash code--we have just reallocated the
5334 glyphs, so their contents can be complete garbage. (Bug#10164)
5336 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5338 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5340 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5342 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5343 attributes are tested _before_ calling verify_row_hash, to protect
5344 against GCC re-ordering of the tests. (Bug#10164)
5346 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5348 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5350 * xterm.c (handle_one_xevent): Only set async_visible and friends
5351 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5352 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5353 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5355 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5357 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5358 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5359 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5360 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5361 All uses changed to use GCPRO1 etc.
5362 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5363 Revert to old implementation (i.e., before 2011-03-11).
5365 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5367 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5368 of scroll runs so as to avoid assigning disabled bogus rows and
5369 unnecessary graphics copy operations.
5371 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5373 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5374 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5375 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5376 (malloc, free, realloc, calloc): Redirect to e_* only when
5379 * lisp.h (GCTYPEBITS): Move before first use.
5380 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5381 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5382 this macro definition.
5384 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5387 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5389 * gtkutil.c (xg_create_frame_widgets):
5390 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5391 present with Gtk+ 2.0.
5393 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5395 * fileio.c (Finsert_file_contents): Undo previous change; see
5396 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5398 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5400 Rename locals to avoid shadowing.
5401 * fileio.c (Finsert_file_contents):
5402 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5403 * process.c (wait_reading_process_output):
5404 Rename inner 'proc' to 'p' to avoid shadowing.
5405 Indent for consistency with usual Emacs style.
5407 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5409 * xdisp.c (redisplay_window): If cursor row is not fully visible
5410 after recentering, and scroll-conservatively is set to a large
5411 number, scroll window by a few more lines to make the cursor fully
5412 visible and out of scroll-margin. (Bug#10105)
5413 (start_display): Don't move to the next line if the display should
5414 start at a newline that is part of a display vector or an overlay
5417 2011-11-24 Juri Linkov <juri@jurta.org>
5419 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5420 after the `MagickPingImage' call. (Bug#10112)
5422 2011-11-23 Chong Yidong <cyd@gnu.org>
5424 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5426 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5428 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5429 making another buffer current. (Bug#10114)
5431 2011-11-23 Glenn Morris <rgm@gnu.org>
5433 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5435 2011-11-23 Chong Yidong <cyd@gnu.org>
5437 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5438 using it (Bug#5984).
5440 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5442 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5443 and header-lines, as they don't have one computed for them.
5446 * .gdbinit (prow): Make displayed values more self-explaining.
5447 Add row's hash code.
5449 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5451 * process.c (wait_reading_process_output): Fix asynchrounous
5452 GnuTLS socket handling on some versions of the GnuTLS library.
5453 (wait_reading_process_output): Add comment and URL.
5455 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5457 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5459 2011-11-21 Chong Yidong <cyd@gnu.org>
5461 * window.c (Fnext_window, Fprevious_window): Doc fix.
5463 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5465 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5467 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5469 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5471 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5473 * window.c (Fset_window_combination_limit): Rename argument
5475 (Vwindow_combination_limit): Remove "status" from doc-string.
5477 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5479 * m/ibms390.h: Remove.
5480 * m/ibms390x.h: Don't include "ibms390.h".
5482 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5484 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5485 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5487 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5489 * casetab.c (Fset_case_table):
5490 * charset.c (Fcharset_after): Fix typos.
5492 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5494 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5495 Otherwise, valgrind does not work on some platforms.
5496 Problem reported by Andreas Schwab in
5497 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5498 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5499 is set, removing the need for VIRT_ADDRESS_VARIES.
5500 (PURE_P): Use a more-efficient implementation that needs just one
5501 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5502 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5503 to 4 (xorl, subq, cmpq, setbe).
5504 * alloc.c (pure): Always extern now, since that's the
5505 VIRT_ADDR_VARIES behavior.
5506 (PURE_POINTER_P): Use a single comparison, not two, for
5507 consistency with the new puresize.h.
5508 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5509 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5510 Remove VIRT_ADDR_VARIES no longer needed.
5512 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5514 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5515 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5516 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5517 behave as if the cursor position were at the window margin.
5519 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5520 and the cursor position is out of bounds, behave as if the cursor
5521 position were at the window margin. (Bug#10075)
5523 2011-11-18 Chong Yidong <cyd@gnu.org>
5525 * window.c (Fwindow_combination_limit): Make first argument
5526 non-optional, since it is meaningless for live windows like the
5529 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5531 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5533 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5535 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5536 (graft_intervals_into_buffer): Simplify.
5538 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5540 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5541 hash values of the two rows.
5542 (copy_row_except_pointers): Preserve the used[] arrays and the
5543 hash values of the two rows. (Bug#10035)
5544 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5546 * xdisp.c (row_hash): New function, body extracted from
5547 compute_line_metrics.
5548 (compute_line_metrics): Call row_hash, instead of computing the
5551 * dispnew.c (verify_row_hash): Call row_hash for computing the
5552 hash code of a row, instead of duplicating code from xdisp.c.
5554 * dispextern.h (row_hash): Add prototype.
5556 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5558 * frame.c (delete_frame): Don't delete the terminal when the last
5559 X frame is closed if emacs is built with GTK toolkit.
5561 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5563 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5565 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5567 * window.c (Vwindow_splits): Rename to
5568 Vwindow_combination_resize. Suggested by Juri Linkov.
5569 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5572 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5574 * nsfns.m (Fns_font_name):
5575 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5577 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5579 * window.h (window): Rename slot "nest" to "combination_limit".
5580 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5581 (Fset_window_nest): Rename to Fset_window_combination_limit.
5582 (Vwindow_nest): Rename to Vwindow_combination_limit.
5583 (recombine_windows, make_parent_window, make_window)
5584 (Fsplit_window_internal, saved_window)
5585 (Fset_window_configuration, save_window_save): Rename all
5586 occurrences of window_nest to window_combination_limit.
5588 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5590 * image.c (imagemagick_load_image): Fix typo.
5592 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5594 * xdisp.c (display_line): Move the call to
5595 highlight_trailing_whitespace before the call to
5596 compute_line_metrics, since the latter needs to see the final
5597 faces of all the glyphs to compute ROW's hash value.
5598 Fixes assertion violations in row_equal_p. (Bug#10035)
5600 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5602 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5603 just return (bug#10044).
5605 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5607 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5608 with user-defined heap size. Bump the default size of the temacs
5609 heap to 27MB, to avoid memory warning when running temacs.
5610 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5612 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5613 current_matrix and desired_matrix. (Bug#9990)
5614 (verify_row_hash) [XASSERTS]: New function.
5615 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5616 that the hash value of glyph rows is correct.
5618 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5620 * window.h (window): Remove splits slot.
5621 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5622 (Fdelete_other_windows_internal, make_parent_window)
5623 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5624 (Fset_window_configuration, save_window_save): Don't deal with
5625 split status of windows.
5626 (saved_window): Remove splits slot.
5627 (Vwindow_splits): Rewrite doc-string.
5629 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5631 * xfns.c (unwind_create_frame):
5632 * nsfns.m (unwind_create_frame):
5633 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5634 Vframe_list (Bug#9999).
5636 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5638 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5640 2011-11-11 Kenichi Handa <handa@m17n.org>
5642 * callproc.c (Fcall_process): Set the member dst_multibyte of
5645 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5647 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5648 avoid a crash (bug#9496).
5650 2011-11-09 Chong Yidong <cyd@gnu.org>
5652 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5653 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5655 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5657 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5659 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5661 Avoid some portability problems by eschewing 'extern inline' functions.
5662 The trivial performance wins aren't worth the portability hassles; see
5663 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5665 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5666 (window_box_width, window_box_left, window_box_left_offset)
5667 (window_box_right, window_box_right_offset): Undo previous change,
5668 by removing the "extern"s.
5669 * intervals.c (adjust_intervals_for_insertion)
5670 (adjust_intervals_for_deletion): Undo previous change,
5671 making these static again.
5672 (offset_intervals, temp_set_point_both, temp_set_point)
5673 (copy_intervals_to_string): No longer inline.
5674 * xdisp.c (window_text_bottom_y, window_box_width)
5675 (window_box_height, window_box_left_offset)
5676 (window_box_right_offset, window_box_left, window_box_right)
5677 (window_box): No longer inline.
5679 2011-11-08 Chong Yidong <cyd@gnu.org>
5681 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5682 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5683 Signal an error if not a live window.
5684 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5685 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5687 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5689 * lisp.h (syms_of_abbrev): Remove declaration.
5690 Reported by CHENG Gao <chenggao@royau.me>.
5692 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5694 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5695 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5696 of temacs in GUI mode.
5698 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5700 * window.h: Declare delete_all_child_windows instead of
5701 delete_all_subwindows.
5702 * window.c (Fwindow_nest, Fset_window_nest)
5703 (Fset_window_new_total, Fset_window_new_normal)
5704 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5705 (delete_all_subwindows): Rename to delete_all_child_windows.
5706 (Fdelete_other_windows_internal, Fset_window_configuration):
5707 Call delete_all_child_windows instead of delete_all_subwindows.
5708 * frame.c (delete_frame): Call delete_all_child_windows instead
5709 of delete_all_subwindows.
5711 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5713 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5714 This is also needed for porting to any host where GC_MARK_STACK is
5715 not GC_MAKE_GCPROS_NOOPS.
5716 (which_symbols): Use it.
5718 2011-11-07 Kenichi Handa <handa@m17n.org>
5720 * coding.c (coding_set_destination): Check coding->src_pos only
5721 when coding->src_object is a buffer (bug#9910).
5723 * process.c (send_process): Set the member src_multibyte of coding
5724 to 0 (bug#9911) when sending a unibyte text.
5726 * callproc.c (Fcall_process): Set the member src_multibyte of
5727 process_coding to 0 (bug#9912).
5729 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5731 * xmenu.c (cleanup_widget_value_tree): New function.
5732 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5733 calling free_menubar_widget_value_tree directly (Bug#9830).
5735 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5737 Fix some portability problems with 'inline'.
5738 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5739 (window_box_width, window_box_left, window_box_left_offset)
5740 (window_box_right, window_box_right_offset): Declare extern.
5741 Otherwise, these inline functions do not conform to C99 and
5742 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5743 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5744 * intervals.c (adjust_intervals_for_insertion)
5745 (adjust_intervals_for_deletion): Now extern, because otherwise the
5746 extern inline functions 'offset_intervals' couldn't refer to it.
5747 (static_offset_intervals): Remove.
5748 (offset_intervals): Rewrite using the old contents of
5749 static_offset_intervals. The old version didn't conform to C99
5750 because an extern inline function contained a reference to an
5751 identifier with static linkage.
5753 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5755 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5758 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5760 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5761 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5762 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5763 return Qleft_to_right.
5765 2011-11-06 Chong Yidong <cyd@gnu.org>
5767 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5768 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5769 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5770 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5771 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5772 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5773 (Fwindow_vscroll): Doc fix.
5774 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5775 argument, since it makes no sense to pass a live window and for
5776 consistency with window-child.
5778 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5780 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5783 2011-11-05 Jason Rumney <jasonr@gnu.org>
5785 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5786 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5788 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5789 bitwise arithmetic preventing use of unicode-sip and non-truetype
5792 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5794 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5797 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5798 initialization code to keep similarity to xfns.c after changes
5801 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5803 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5804 (unwind_create_frame): New function (Bug#9943).
5805 (Fx_create_frame): Restructure code to be more similar to the one in
5806 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5807 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5808 Move terminal->reference_count++ just before making the frame official
5811 * nsterm.m (x_free_frame_resources): New function.
5812 (x_destroy_window): Move code to x_free_frame_resources.
5814 * xfns.c (unwind_create_frame): Fix comment.
5815 (Fx_create_frame, x_create_tip_frame):
5816 Move terminal->reference_count++ just before making the frame
5817 official. Move initialization of image_cache_refcount and
5818 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5820 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5822 Support MSVC build with newer versions of Visual Studio.
5823 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5824 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5827 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5828 which are not supported by MSVC.
5829 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5830 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5832 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5834 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5836 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5838 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5840 Support MSVC build with newer versions of Visual Studio.
5841 * w32.c: Don't include w32api.h for MSVC.
5842 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5844 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5845 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5846 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5847 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5849 (alloca) [_MSC_VER]: Define to _alloca.
5851 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5853 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5855 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5857 * xdisp.c (note_mouse_highlight): If either of
5858 previous/next-single-property-change returns nil, treat that as
5859 the beginning or the end of the buffer. (Bug#9955)
5861 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5863 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5864 label is not null (Bug#9951).
5865 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5868 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5870 * window.c (Fwindow_body_size): Mention in the doc string that the
5871 return value is in frame's canonical units. (Bug#9949)
5873 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5875 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5877 * w32fns.c (unwind_create_frame): If needed, free the glyph
5878 matrices of the partially constructed frame. (Bug#9943)
5879 * xfns.c (unwind_create_frame): Likewise.
5881 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5883 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5884 Don't stop backward scan on the continuation glyph, even though
5885 its CHARPOS is positive.
5886 (mouse_face_from_buffer_pos, note_mouse_highlight):
5887 Rename cover_string to disp_string.
5889 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5891 * window.c (temp_output_buffer_show): Don't use
5892 Vtemp_buffer_show_specifiers.
5893 (Vtemp_buffer_show_specifiers): Remove unused variable.
5895 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5897 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5898 past the beginning of the current glyph matrix.
5900 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5902 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5903 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5904 HAVE_GTK3 (Bug#9869).
5906 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5907 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5909 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5911 * xterm.c: Declare x_handle_net_wm_state to return int.
5912 (handle_one_xevent): Check if we are iconified but don't have
5913 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5914 (get_current_wm_state): Return non-zero if not hidden,
5915 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5916 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5917 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5918 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5920 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5922 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5923 so that this new function doesn't get optimized away by a
5924 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5926 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5928 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5930 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5932 Fix the `xbytecode' command.
5933 * .gdbinit (xprintbytestr): New command.
5934 (xwhichsymbols): Rename from `which'; all callers changed.
5935 (xbytecode): Print the byte-code string as well.
5937 2011-10-29 Kim Storm <storm@cua.dk>
5939 * alloc.c (which_symbols): New function.
5941 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5943 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5946 2011-10-29 Glenn Morris <rgm@gnu.org>
5948 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5949 Not clear what it was for, and it causes various bugs. (Bug#9839)
5951 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5953 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5954 possible random value that matches one of those tested as
5955 condition to clear the mouse face.
5957 2011-10-28 Chong Yidong <cyd@gnu.org>
5959 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5961 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5963 * window.c (make_window): Initialize phys_cursor_on_p.
5965 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5967 * lisp.h (struct Lisp_Symbol): Update comments.
5969 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5971 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5973 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5975 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5976 <oslsachem@gmail.com> for helping to debug this.
5978 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5979 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5980 (g_b_init_get_glyph_outline_w): New static variables.
5981 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5982 (GetGlyphOutlineW_Proc): New typedefs.
5983 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5984 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5986 (w32font_open_internal, compute_metrics):
5987 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5988 instead of calling the "wide" APIs directly.
5990 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5992 * w32.h (syms_of_w32font): Add prototype.
5994 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5996 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5997 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5998 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5999 (Fmove_to_window_line): Doc fix.
6001 2011-10-27 Chong Yidong <cyd@gnu.org>
6003 * process.c (make_process): Set gnutls_state to NULL.
6005 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6006 non-NULL, regardless of GNUTLS_INITSTAGE.
6007 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6008 an error. Set process slots as soon as we allocate them.
6010 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6012 2011-10-27 Chong Yidong <cyd@gnu.org>
6014 * gnutls.c (emacs_gnutls_deinit): New function.
6015 Deallocate credentials structures as well as calling gnutls_deinit.
6016 (Fgnutls_deinit, Fgnutls_boot): Use it.
6018 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6019 (deactivate_process): Call emacs_gnutls_deinit.
6021 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6023 * image.c (x_create_x_image_and_pixmap):
6024 * w32.c (sys_rename, w32_delayed_load):
6025 * w32font.c (fill_in_logfont):
6026 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6028 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6030 * w32fns.c (w32_default_color_map): New function,
6031 extracted from Fw32_default_color_map.
6032 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6034 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6036 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6038 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6040 * keyboard.c (test_undefined): New function (bug#9751).
6041 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6043 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6045 * sysdep.c (init_sys_modes): Fix the check for the controlling
6046 terminal (Bug#6649).
6048 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6050 * dispextern.h (struct bidi_it): New member next_en_type.
6052 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6053 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6054 current character, check also for next_en_type being WEAK_EN.
6055 (bidi_resolve_weak): Don't enter the expensive loop if the current
6056 position is before next_en_pos. Record the bidi type of the first
6057 non-ET, non-BN character we find, in addition to its position.
6058 (bidi_level_of_next_char): Invalidate next_en_type when
6059 next_en_pos is over-stepped.
6061 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6063 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6064 * editfns.c: Rewrite current-time-zone so that it invokes
6065 the equivalent of (format-time-string "%Z") to get the time zone name.
6066 This fixes a bug when the time zone name contains characters that
6067 need converting from the system time locale to Emacs internal format.
6068 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6069 that patch fixed format-time-string to do the conversion, but
6070 I forgot to fix current-time-zone.
6071 (format_time_string): New function, containing most of
6072 what Fformat_time_string used to contain.
6073 (Fformat_time_string): Rewrite in terms of format_time_string.
6074 This doesn't change this function's behavior.
6075 (current-time-zone): Rewrite to use format_time_string.
6076 This fixes the bug reported by Michael Schierl in
6077 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6078 Jason Rumney's 2007-06-07 change worked around this bug, but
6080 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6082 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6084 * xdisp.c (start_display): If the character at POS is displayed
6085 via a display vector, reset IT->current.dpvec_index to zero.
6086 (try_window_reusing_current_matrix): If a line ends in a display
6087 vector or the next line starts in a display vector, continue
6088 redrawing the window even though the character position of
6089 start_row was reached.
6092 2011-10-18 Chong Yidong <cyd@gnu.org>
6094 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6095 with nobreak-char-display too.
6097 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6099 Fix part 3 of bug#9771.
6100 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6101 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6102 non-neutral characters if the current character is a paragraph
6103 separator (a.k.a. Newline). This avoids running the same
6104 expensive loop twice, once when we consume the preceding newline
6105 and the other time when the line actually needs to be displayed.
6106 Avoid the loop when we see neutrals on the base embedding level
6107 following a character whose directionality is the same as the
6108 paragraph's. This avoids running the expensive loop when a line
6109 ends in a long sequence of neutrals, like control characters.
6110 Add assertion against STRONG_AL type. Slightly rearrange code
6111 that determines the type of a neutral given the first non-neutral
6113 (bidi_level_of_next_char): Set next_en_pos to zero when
6114 invalidating its info.
6116 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6118 * xdisp.c (push_display_prop): Determine whether to record string
6119 or buffer position by IT->string, not by IT->method. Allow
6120 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6121 (move_it_vertically_backward): Don't look for character position
6122 immediately after the newline when in a continuation line.
6125 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6127 * window.c (coordinates_in_window): Rewrite and delabelize
6128 vertical border check. (Bug#5357) (Bug#9618)
6130 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6132 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6133 errors in XSetWindowBorder (bug#9310).
6135 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6137 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6138 avoid crash when xmalloc overrun checking is enabled.
6140 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6142 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6143 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6144 cursor motion with <left> and <right> arrow keys.
6146 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6147 some callers set that themselves.
6149 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6151 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6152 display string and the previous row comes from the same string and
6153 is empty. (Bug#9739) (Bug#9738)
6155 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6157 * doc.c (get_doc_string): Encode file name (bug#9735).
6159 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6161 * bidi.c (bidi_level_of_next_char):
6162 * xdisp.c (get_visually_first_element): Remove old incorrect
6163 comments regarding the Unicode Line Separator character.
6165 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6167 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6169 * alloc.c (Fgc_status): Do not access beyond zombies array
6170 boundary if nzombies > MAX_ZOMBIES.
6171 * alloc.c (dump_zombies): Add missing format specifier.
6173 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6175 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6176 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6178 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6179 Some packages use them to denote characters with modifiers.
6181 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6183 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6184 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6185 matching a pp-number. Rename parameter var to var1.
6187 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6189 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6191 2011-10-08 Glenn Morris <rgm@gnu.org>
6193 * callint.c (Fcall_interactively): Give a more explicit error for the
6194 'c' case with a non-character input. (Bug#8479)
6196 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6198 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6200 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6201 lines that are hscrolled on the left.
6203 * dispnew.c (buffer_posn_from_coords): Account for a possible
6204 presence of header-line. (Bug#4426)
6206 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6208 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6209 Don't advertise functionality which we discourage or doesn't work.
6211 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6213 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6214 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6215 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6216 this makes Emacs dump core during garbage collection on rare
6217 occasions. sizeof is obviously inferior to offsetof here, so
6218 stick with offsetof.
6219 (GC_POINTER_ALIGNMENT): New macro.
6220 (mark_memory): Omit 3rd (offset) arg; caller changed.
6221 Don't assume EMACS_INT alignment is the same as pointer alignment.
6223 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6225 * keyboard.c (read_key_sequence_remapped): New var.
6226 (read_key_sequence): Compute remapping in the right buffer.
6227 (command_loop_1): Use read_key_sequence's remapping directly.
6229 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6231 * dired.c (file_name_completion): Don't expand file name.
6232 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6233 before checking file name handler.
6235 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6236 they've been requested explicitly (bug#9591).
6238 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6240 * keymap.c (Fsingle_key_description): Use make_specified_string
6241 instead of build_string to build string from push_key_description.
6244 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6246 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6247 This fixes a Y2038 bug on 64-bit hosts.
6248 * buffer.c (reset_buffer):
6249 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6250 (Fclear_buffer_auto_save_failure):
6251 Use 0, not -1, to represent an unset failure time, since time_t
6252 might not be signed.
6254 Remove dependency on glibc malloc internals.
6255 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6256 Move back here from lisp.h, but with their new implementations.
6257 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6258 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6259 * charset.c (charset_table_init): New static var.
6260 (syms_of_charset): Use it instead of xmalloc. This removes a
6261 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6262 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6263 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6264 Move back to alloc.c.
6265 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6266 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6268 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6270 * nsterm.m (windowDidResize): Call x_set_window_size only when
6271 ns_in_resize is true. Otherwise set pixelwidth/height and
6272 call change_frame_size (Bug#9628).
6274 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6276 Port --enable-checking=all to Fedora 14 x86-64.
6277 * charset.c (syms_of_charset): Also account for glibc malloc's
6278 internal overhead when calculating the initial malloc maximum.
6280 Port --enable-checking=all to Fedora 14 x86.
6281 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6283 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6284 (overrun_check_realloc, overrun_check_free):
6285 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6286 That way, xmalloc returns a properly-aligned pointer even if
6287 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6288 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6289 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6290 into account when calculating the initial malloc maximum.
6291 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6292 Move here from alloc.c, so that charset.c can use it too.
6293 Properly align; the old code wasn't right for common 32-bit hosts
6294 when configured with --enable-checking=all.
6295 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6296 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6298 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6300 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6303 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6305 * xdisp.c (compute_display_string_end): If there's no display
6306 string at CHARPOS, return -1.
6308 * bidi.c (bidi_fetch_char): When compute_display_string_end
6309 returns a negative value, treat the character as a normal
6310 character not covered by a display string. (Bug#9624)
6312 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6314 * lread.c (Fread_from_string): Fix typo in docstring.
6316 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6318 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6319 newline, reseat the iterator instead of bidi-iterating there one
6320 character at a time. (Bug#9610)
6321 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6322 TO_CHARPOS if the bidi iterator is at base embedding level.
6324 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6326 * lread.c (readevalloop): Use correct code for NBSP.
6327 (read1): Likewise. (Bug#9608)
6329 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6331 * dbusbind.c (Fdbus_register_signal): When service is not
6332 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6334 2011-09-25 Glenn Morris <rgm@gnu.org>
6336 * buffer.c (truncate-lines): Doc fix.
6338 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6340 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6341 (Fset_window_next_buffers): Doc fix.
6343 2011-09-24 Glenn Morris <rgm@gnu.org>
6345 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6347 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6349 Fix minor problems found by static checking.
6350 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6351 * indent.c (Fvertical_motion): Fix == vs = typo.
6353 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6355 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6356 Default value is now t. Doc fix.
6358 * indent.c (Fvertical_motion): Compute and apply the overshoot
6359 logic when moving up, not only when moving down. Fix the
6360 confusing name and values of the it_overshoot_expected variable;
6361 logic changes accordingly. (Bug#9254) (Bug#9549)
6363 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6364 CHARPOS is covered by a display string which includes newlines.
6365 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6366 is covered by a display string with embedded newlines.
6368 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6370 * dbusbind.c (Fdbus_register_signal): Add match rule to
6371 Vdbus_registered_objects_table. (Bug#9581)
6372 (Fdbus_register_method, Vdbus_registered_objects_table):
6375 2011-09-24 Jim Meyering <meyering@redhat.com>
6377 do not ignore write error for any output size
6378 The previous change was incomplete.
6379 While it makes emacs --batch detect the vast majority of stdout
6380 write failures, errors were still ignored whenever the output size is
6381 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6382 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6383 && echo FAIL: ignored write error
6384 FAIL: ignored write error
6385 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6386 && echo FAIL: ignored write error
6387 FAIL: ignored write error
6388 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6390 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6392 * emacs.c (Fkill_emacs): In noninteractive mode exit
6393 non-successfully if a write error occurred on stdout. (Bug#9574)
6395 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6397 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6400 * dispextern.h (struct it): Update the comment documenting what
6403 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6405 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6406 a display string, extend search for cursor position to end of row.
6407 (find_row_edges): If the row ends in a newline from a display
6408 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6409 Handle the case of a display string with multiple newlines.
6410 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6411 non-empty line. Fixes confusing cursor motion with arrow keys at
6412 the beginning of a line that starts with whitespace.
6414 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6416 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6419 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6421 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6424 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6426 * xdisp.c (display_line): Record maximum and minimum buffer
6427 positions even if no glyphs were produced (e.g., by a zero-width
6428 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6429 buffer positions that will be removed from the glyph row because
6431 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6432 column is beyond frame width: don't subtract 1 "pixel" when
6433 computing width of the stretch.
6434 (reseat_at_next_visible_line_start): Undo the change made on
6435 2011-09-17 that saved paragraph information and restored it after
6436 the call to `reseat'. (Bug#9545)
6438 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6440 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6441 and turn window cursor on if cleared (Bug#9415).
6443 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6445 * search.c (boyer_moore): Take unibyte characters from pattern
6446 literally. (Bug#9458)
6448 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6450 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6452 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6454 Fix minor problem found by static checking.
6455 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6456 initialized, to pacify gcc -Wuninitialized.
6458 * fileio.c: Report proper errno when syscall falls.
6459 (Finsert_file_contents): Save and restore errno,
6460 so that report_file_error outputs the correct diagnostic.
6461 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6463 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6465 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6467 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6469 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6470 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6472 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6474 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6475 about the current paragraph and restore it after the call to reseat.
6477 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6478 (bidi_find_paragraph_start): Search back for paragraph beginning
6479 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6480 (bidi_move_to_visually_next): Only trigger paragraph-related
6481 computations when the last character is a newline or at EOB, not
6482 just any NEUTRAL_B. (Bug#9470)
6484 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6485 truncated lines if point is covered by a display string. (Bug#9524)
6487 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6489 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6490 (cons_to_x_long): New function.
6491 (lisp_data_to_selection_data): Use it. Correct the test for
6492 short-versus-long data; it was negated. Break out of vector
6493 loop, for efficiency, when a long datum is discovered.
6495 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6497 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6499 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6501 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6502 GCC PR/17406) by declaring this function with external scope.
6504 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6506 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6507 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6509 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6511 * editfns.c (Fformat): Correctly handle text properties on "%%".
6513 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6515 * xterm.c (x_draw_composite_glyph_string_foreground):
6516 * w32term.c (x_draw_composite_glyph_string_foreground):
6517 * term.c (encode_terminal_code):
6518 * composite.c (composition_update_it, get_composition_id):
6519 * xdisp.c (get_next_display_element)
6520 (fill_composite_glyph_string): Add comments about special meaning
6521 of TAB characters in a composition.
6523 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6525 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6526 This occurs when processing a multibyte format.
6527 Problem reported by Wolfgang Jenker.
6529 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6531 * xdisp.c (try_cursor_movement): Only check for exact match if
6532 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6534 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6536 Remove unused external symbols.
6537 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6538 * xdisp.c (calc_pixel_width_or_height): Now static.
6539 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6540 * indent.c (check_display_width):
6541 * w32term.c: Fix comment to match code.
6542 * xterm.c, xterm.h (x_catching_errors): Remove.
6544 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6546 * xselect.c: Use signed conversions more consistently (Bug#9498).
6547 (selection_data_to_lisp_data): Assume incoming selection data are
6548 signed integers, not unsigned. This is to be consistent with
6549 outgoing selection data, which was modified to use signed integers
6550 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6551 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6552 expects long, not unsigned long.
6554 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6556 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6557 computation of loop end. Reported by Johan Bockgård
6560 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6562 * frame.c (Fother_visible_frames_p): Function deleted.
6564 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6566 * indent.c (compute_motion): Process display vector front to back
6567 rather than the other way around. (Bug#2496)
6569 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6571 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6573 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6575 * minibuf.c (Fread_from_minibuffer): Doc fix.
6577 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6579 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6580 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6582 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6584 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6585 value for non-existent files.
6587 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6589 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6590 set its "size" to -1. This will set the modtime_size field of
6591 the corresponding buffer to -1, which is what
6592 verify-visited-file-modtime expects for files that do not exist.
6595 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6597 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6599 * lisp.h: ... from here. push_key_description is no longer
6600 defined in keyboard.c, so its declaration should not be in
6601 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6602 logically belongs with push_key_description.
6604 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6606 * buffer.h: Include <sys/types.h> instead of <time.h>.
6607 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6608 Problem reported by Herbert J. Skuhra.
6610 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6612 * xml.c (parse_region): Make the parsing work for
6613 non-comment-starting XML files again (bug#9144).
6615 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6617 * image.c (gif_load): Fix calculation of bottom and right corner.
6620 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6622 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6623 redisplay in small windows.
6625 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6627 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6629 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6631 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6632 Operate on live windows only.
6634 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6636 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6638 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6640 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6641 only under bidi iteration.
6643 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6645 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6647 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6649 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6650 Without this fix, the command to link temacs failed due to an
6651 undefined symbol __builtin_isnan. This is because
6652 /usr/include/iso/math_c99.h #defines isnan(x) to
6653 __builtin_isnan(x), but the bundled gcc, which identifies itself
6654 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6656 * floatfns.c (isnan): #undef, and then #define to a clone of
6658 (Fisnan): Always define, since it's always available now.
6659 (syms_of_floatfns): Always define isnan at the Lisp level.
6661 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6663 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6665 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6667 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6668 The previous code assumed that file offsets (off_t values) fit in
6669 EMACS_INT variables, which is not true on typical 32-bit hosts.
6670 The code messed up by falsely reporting buffer overflow in cases
6671 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6672 when "big" contains more than 2**29 bytes, even though this
6673 inserts just one byte and does not overflow the buffer.
6674 (Finsert_file_contents): Store file offsets as off_t
6675 values, not as EMACS_INT values. Check for overflow when
6676 converting between EMACS_INT and off_t. When checking for
6677 buffer overflow or for overlap, take the offsets into account.
6678 Don't use EMACS_INT for small values where int suffices.
6679 When checking for overlap, fix a typo: ZV was used where
6680 ZV_BYTE was intended.
6681 (Fwrite_region): Don't assume off_t fits into 'long'.
6682 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6684 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6686 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6688 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6690 sprintf-related integer and memory overflow issues (Bug#9412).
6692 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6693 (esprintf, exprintf, evxprintf): New functions.
6694 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6695 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6696 (modify_event_symbol): Do not assume that the length of
6697 name_alist_or_stem is safe to alloca and fits in int.
6698 (Fexecute_extended_command): Likewise for function name and binding.
6699 (Frecursion_depth): Wrap around reliably on integer overflow.
6700 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6701 since some callers pass EMACS_INT values.
6702 (Fsingle_key_description): Don't crash if symbol name contains more
6703 than MAX_ALLOCA bytes.
6704 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6705 (get_minibuffer): Arg is now EMACS_INT, not int.
6706 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6707 (esprintf, exprintf, evxprintf): New decls.
6708 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6710 * dbusbind.c (signature_cat): New function.
6711 (xd_signature, Fdbus_register_signal):
6712 Do not overrun buffer; instead, report string overflow.
6714 * dispnew.c (add_window_display_history): Don't overrun buffer.
6715 Truncate instead; this is OK since it's just a log.
6717 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6718 even if the time zone offset is outlandishly large.
6719 Don't mishandle offset == INT_MIN.
6721 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6722 when creating daemon; the previous buffer-overflow check was incorrect.
6724 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6725 which has the guts of the old verror function.
6727 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6728 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6730 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6731 (font_unparse_xlfd): Don't blindly alloca long strings.
6732 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6733 fits in int, when using sprintf. Use single snprintf to count
6734 length of string rather than counting it via multiple sprintfs;
6735 that's simpler and more reliable.
6736 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6737 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6738 sprintf, in case result does not fit in int.
6740 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6741 (fontset_from_font): Print it.
6743 * frame.c (tty_frame_count): Now printmax_t, not int.
6744 (make_terminal_frame, set_term_frame_name): Print it.
6745 (x_report_frame_params): In X, window IDs are unsigned long,
6746 not signed long, so print them as unsigned.
6747 (validate_x_resource_name): Check for implausibly long names,
6748 and don't assume name length fits in 'int'.
6749 (x_get_resource_string): Don't blindly alloca invocation name;
6750 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6753 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6754 (xg_check_special_colors, xg_set_geometry):
6755 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6757 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6758 Use esprintf, not sprintf, in case result does not fit in int.
6760 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6761 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6762 it as a large positive number.
6763 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6764 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6766 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6767 in case result does not fit in int.
6769 * print.c (float_to_string): Detect width overflow more reliably.
6770 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6771 buffer overrun. Don't assume list length fits in 'int'. Treat
6772 print length of 0 as 0, not as infinity; to be consistent with other
6773 uses of print length in this function. Don't overflow print length
6774 index. Don't assume hash table size fits in 'long', or that
6775 vectorlike size fits in 'unsigned long'.
6777 * process.c (make_process): Use printmax_t, not int, to format
6778 process-name gensyms.
6780 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6782 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6783 to avoid potential buffer overrun.
6785 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6786 if X resource line is longer than 512 bytes.
6788 * xfns.c (x_window): Make sprintf buffer a bit bigger
6789 to avoid potential buffer overrun.
6791 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6793 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6795 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6797 Integer overflow fixes for scrolling, etc.
6798 Without these, Emacs silently mishandles large integers sometimes.
6799 For example, "C-u 4294967297 M-x recenter" was treated as if
6800 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6802 * xdisp.c (try_window_id): Check Emacs fixnum range before
6803 converting to 'int'.
6805 * window.c (window_scroll_line_based, Frecenter):
6806 Check that an Emacs fixnum is in range before assigning it to 'int'.
6807 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6808 values converted from Emacs fixnums.
6809 (Frecenter): Don't wrap around a line count if it is out of 'int'
6810 range; instead, treat it as an extreme value.
6811 (Fset_window_configuration, compare_window_configurations):
6812 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6814 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6815 that can exceed INT_MAX. Check that EMACS_INT value is in range
6816 before assigning it to the (possibly-narrower) index.
6817 (match_limit): Don't assume that a fixnum can fit in 'int'.
6819 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6822 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6823 (Fvertical_motion): Don't wrap around LINES values that don't fit
6824 in 'int'. Instead, treat them as extreme values. This is good
6825 enough for windows, which can't have more than INT_MAX lines anyway.
6827 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6829 * Require libxml/parser.h to avoid compilation warning.
6831 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6833 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6834 since this reportedly can destroy thread storage.
6836 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6838 * syntax.c (find_defun_start): Update all cache variables if
6839 exiting early (Bug#9401).
6841 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6843 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6845 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6846 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6847 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6849 * term.c (tty_append_glyph): New function.
6850 (produce_stretch_glyph): Static function and its prototype deleted.
6852 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6855 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6857 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6858 when checking :margin (Bug#9390).
6859 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6860 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6861 so that the name doesn't mislead. All uses changed.
6863 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6865 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6868 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6870 * xdisp.c (move_it_to): Don't bail out early when reaching
6871 position beyond to_charpos, if we are scanning backwards.
6872 (move_it_vertically_backward): When DY == 0, make sure we get to
6873 the first character in the line after the newline.
6875 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6877 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6878 (ccl_driver): Do not generate an out-of-range pointer.
6879 (Fccl_execute_on_string): Remove unnecessary check for
6880 integer overflow, noted by Stefan Monnier in
6881 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6882 Remove a FIXME that didn't need fixing.
6883 Simplify the newly-introduced buffer reallocation code.
6885 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6887 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6889 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6891 Integer and memory overflow issues (Bug#9196).
6893 * doc.c (get_doc_string): Rework so that
6894 get_doc_string_buffer_size is the actual buffer size, rather than
6895 being 1 less than the actual buffer size; this makes xpalloc more
6898 * image.c (x_allocate_bitmap_record, cache_image):
6899 * xselect.c (Fx_register_dnd_atom):
6900 Simplify previous changes by using xpalloc.
6902 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6903 since either will do and ptrdiff_t is convenient with xpalloc.
6905 * charset.c (charset_table_size)
6906 (struct charset_sort_data.priority): Now ptrdiff_t.
6907 (charset_compare): Don't overflow if priorities differ greatly.
6908 (Fsort_charsets): Don't assume list length fits in int.
6909 Check for size-calculation overflow when allocating sort data.
6910 (syms_of_charset): Allocate an initial charset table that is
6911 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6913 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6915 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6916 The actual value is always <= INT_MAX, and leaving it unsigned made
6917 overflow checking harder.
6919 * dispextern.h (struct glyph_matrix.rows_allocated)
6920 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6921 with xpalloc. The values are still always <= INT_MAX.
6923 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6925 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6926 (SAFE_NALLOCA): New macro.
6928 * region-cache.c (struct boundary.pos, find_cache_boundary)
6929 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6930 (set_cache_region, invalidate_region_cache)
6931 (revalidate_region_cache, know_region_cache, region_cache_forward)
6932 (region_cache_backward, pp_cache):
6933 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6934 so that ptrdiff_t * can be passed to xpalloc.
6935 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6936 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6937 (pp_cache): Don't assume cache_len fits in int.
6938 * region-cache.h: Adjust extern decls to match.
6940 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6941 EMACS_INT, since either will do, for xpalloc.
6943 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6944 (xnmalloc, xnrealloc, xpalloc): New functions.
6946 * bidi.c (bidi_shelve_header_size): New constant.
6947 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6948 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6950 * bidi.c (bidi_cache_shrink):
6951 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6953 Don't update size of array until after memory allocation succeeds,
6954 because xmalloc/xrealloc may not return.
6955 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6956 now that we have proper integer overflow checking.
6957 (record_overlay_string, overlay_strings): Catch overflows when
6958 calculating size of overlay_str_buf.
6960 * callproc.c (Fcall_process): Check for size overflow when
6961 calculating size of args2.
6962 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6963 Normally we prefer signed values, but sticking with ptrdiff_t would
6964 require adding more-complicated checks.
6966 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6967 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6968 Redo buffer-overflow calculations to avoid integer overflow.
6969 Add a FIXME comment where memory seems to be over-allocated.
6971 * character.c (Fstring): Check for size-calculation overflow.
6973 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6974 unnecessary integer overflow. Check for size overflow.
6975 (encode_coding_object): Don't update size until xmalloc succeeds.
6977 * composite.c (get_composition_id): Check for overflow in glyph
6978 length calculations.
6980 Integer and memory overflow fixes for display code.
6981 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6982 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6983 (scrolling_window): Check for overflow in size calculations.
6984 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6985 Don't assume glyph table len fits in int.
6986 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6987 (row_table_size): Now ptrdiff_t, not int.
6988 (scrolling_window): Avoid overflow in size calculations.
6989 Don't update size until allocation succeeds.
6990 * fns.c (concat): Check for overflow in size calculations.
6991 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6992 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6993 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6995 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6996 (get_doc_string): Check for size calculation overflow.
6997 Don't update size until allocation succeeds.
6998 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6999 EMACS_INT, where ptrdiff_t will do.
7000 (Fsubstitute_command_keys): Check for string overflow.
7002 * editfns.c (set_time_zone_rule): Don't assume environment length
7004 (message_length): Now ptrdiff_t, not int.
7005 (Fmessage_box): Don't update size until allocation succeeds.
7006 Don't assume message length fits in int.
7007 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7009 * emacs.c (main): Do not reallocate argv, since there is a null at
7010 the end that can be overwritten, and this way there's no need to
7011 worry about size-calculation overflow.
7012 (sort_args): Check for size-calculation overflow.
7014 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7016 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7018 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7019 (x_set_scroll_bar_width, x_figure_window_size):
7020 Check for integer overflow.
7021 (x_set_alpha): Do not assume XINT fits in int.
7023 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7024 This is for the members text_lines, text_cols, total_lines, total_cols,
7025 where the system imposes an 'int' limit.
7027 * fringe.c (Fdefine_fringe_bitmap):
7028 Don't update size until alloc works.
7030 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7031 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7033 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7034 Check for size-calculation overflow.
7035 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7036 do, as we prefer signed integers.
7037 (id_to_widget.max_size, id_to_widget.used)
7038 (xg_store_widget_in_map, xg_remove_widget_from_map)
7039 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7040 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7041 Use and return ptrdiff_t, not int.
7042 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7043 * gtkutil.h: Change prototypes to match the above.
7045 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7046 are duplicate now that they've been promoted to lisp.h.
7047 (x_allocate_bitmap_record, x_alloc_image_color)
7048 (make_image_cache, cache_image, xpm_load):
7049 Don't update size until alloc is done.
7050 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7052 Check for size calculation overflow.
7053 (ct_colors_allocated_max): New constant.
7054 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7057 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7058 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7059 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7060 Use ptrdiff_t, not int, to count maps.
7061 (read_char_minibuf_menu_prompt): Check for overflow in size
7062 calculations. Don't update size until allocation succeeds.
7063 Redo calculations to avoid overflow.
7064 * keyboard.h: Change prototypes to match the above.
7066 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7068 (current_minor_maps): Check for size calculation overflow.
7069 * keymap.h: Change prototypes to match the above.
7071 * lread.c (read1, init_obarray): Don't update size until alloc done.
7073 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7074 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7076 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7077 Now ptrdiff_t, not int.
7078 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7079 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7081 * process.c (Fnetwork_interface_list): Check for overflow
7082 in size calculation.
7084 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7086 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7087 overflow. Don't bother calling xmalloc when xrealloc will do.
7089 * search.c (Freplace_match): Check for size calculation overflow.
7090 (Fset_match_data): Don't assume list lengths fit in 'int'.
7092 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7093 for command line length. Do not attempt to address one before the
7094 beginning of an array, as that's not portable.
7096 * term.c (max_frame_lines): Remove; unused.
7097 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7099 (encode_terminal_code, calculate_costs): Check for size
7100 calculation overflow.
7101 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7102 table lengths and related sizes. Don't update size until alloc
7103 done. Redo calculations to avoid overflow.
7104 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7106 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7107 subtracting pointers.
7108 (gobble_line): Check for overflow more carefully. Don't update size
7111 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7112 Don't update size until alloc done.
7113 Redo size calculations to avoid overflow.
7114 Check for size calculation overflow.
7115 (main) [DEBUG]: Fix typo in invoking tparam1.
7117 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7118 Use ptrdiff_t, not int, for sizes.
7119 (store_mode_line_noprop_char): Don't update size until alloc done.
7121 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7122 Use ptrdiff_t, not int, for sizes.
7123 (Finternal_make_lisp_face, cache_face):
7124 Check for size calculation overflow.
7125 (cache_face): Treat size calculation overflows as if they were
7126 memory exhaustion (the usual treatment), rather than aborting.
7128 * xfns.c (x_encode_text, x_set_name_internal)
7129 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7130 sizes, since they can exceed INT_MAX in size. Check for size
7131 calculation overflow.
7133 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7134 (xg_select): Check for size calculation overflow.
7135 Don't update size until alloc done.
7137 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7138 as sprintf is limited to int lengths.
7140 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7141 (X_LONG_MIN): New macros.
7142 Use them to make the following changes clearer.
7143 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7144 This change doesn't affect the value now, but it may help remind
7145 future maintainers not to raise the value too much later.
7146 (SELECTION_QUANTUM): Remove, replacing with ...
7147 (selection_quantum): ... new function, which avoids overflow.
7149 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7150 assumption that selection length fits in 'int'.
7151 (x_reply_selection_request, x_handle_selection_request)
7152 (x_get_window_property, receive_incremental_selection)
7153 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7154 (lisp_data_to_selection_data, clean_local_selection_data):
7155 Use ptrdiff_t, not int, to record length of selection.
7156 (x_reply_selection_request, x_get_window_property)
7157 (receive_incremental_selection, x_property_data_to_lisp):
7158 Redo calculations to avoid overflow.
7159 (x_reply_selection_request): When sending hint, ceiling it at
7160 X_LONG_MAX rather than relying on wraparound overflow to send
7162 (x_get_window_property, receive_incremental_selection)
7163 (lisp_data_to_selection_data, x_property_data_to_lisp):
7164 Check for size-calculation overflow.
7165 (x_get_window_property, receive_incremental_selection)
7166 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7167 Don't store size until memory allocation succeeds.
7168 (x_get_window_property): Plug memory leak on memory exhaustion.
7169 Don't double-block input; malloc is safe here. Don't assume 2**34
7170 - 4 fits in unsigned long. Add an xassert to check
7171 XGetWindowProperty overflow. Be more careful about overflow
7172 calculations, and distinguish size from memory overflow better.
7173 (receive_incremental_selection): When tracing, don't assume
7174 unsigned int is less than INT_MAX.
7175 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7176 harmful) conversions of unsigned short to int.
7177 (lisp_data_to_selection_data): Don't assume that integers
7178 in the range -65535 through -1 fit in an X unsigned short.
7179 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7180 result parameters unless successful. Rely on cons_to_unsigned
7181 to report problems with elements; the old code wasn't right anyway.
7182 (x_check_property_data): Check for int overflow; we cannot use
7183 a wider type due to X limits.
7184 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7186 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7188 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7189 (x_term_init): Check for size calculation overflow.
7190 (x_color_cells): Don't store size until memory allocation succeeds.
7191 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7192 Don't assume alloca size is less than MAX_ALLOCA.
7193 (x_term_init): Don't assume length fits in int (sprintf is limited
7196 Use ptrdiff_t for composition IDs.
7197 * character.c (lisp_string_width):
7198 * composite.c (composition_table_size, n_compositions)
7199 (get_composition_id, composition_gstring_from_id):
7200 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7201 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7202 * window.c (Frecenter):
7203 Use ptrdiff_t, not int, for composition IDs.
7204 * composite.c (get_composition_id): Check for integer overflow.
7205 * composite.h: Adjust prototypes to match the above changes.
7207 Use ptrdiff_t for hash table indexes.
7208 * category.c (hash_get_category_set):
7209 * ccl.c (ccl_driver):
7210 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7211 * coding.c (coding_system_charset_list, detect_coding_system):
7212 * coding.h (struct coding_system.id):
7213 * composite.c (get_composition_id, gstring_lookup_cache):
7214 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7215 * image.c (xpm_get_color_table_h):
7216 * lisp.h (hash_lookup, hash_put):
7217 * minibuf.c (Ftest_completion):
7218 Use ptrdiff_t for hash table indexes, not int (which is too
7219 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7220 32-bit --with-wide-int hosts).
7222 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7223 Add a FIXME comment about memory leaks.
7224 (syms_of_charset): Don't assume xmalloc returns.
7226 Don't assume that stated character widths fit in int.
7227 * character.c (Fchar_width, c_string_width, lisp_string_width):
7228 * character.h (CHAR_WIDTH):
7229 * indent.c (MULTIBYTE_BYTES_WIDTH):
7230 Use sanitize_char_width to avoid undefined and/or bad behavior
7231 with outlandish widths.
7232 * character.h (sanitize_tab_width): Rename from sanitize_width,
7233 now that we have two such functions. All uses changed.
7234 (sanitize_char_width): New inline function.
7236 Don't assume that tab-width fits in int.
7237 * character.h (sanitize_width): New inline function.
7238 (SANE_TAB_WIDTH): New macro.
7239 (ASCII_CHAR_WIDTH): Use it.
7240 * indent.c (sane_tab_width): Remove. All uses replaced by
7241 SANE_TAB_WIDTH (current_buffer).
7242 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7244 * fileio.c: Integer overflow issues with file modes.
7245 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7247 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7248 Remove unreachable code.
7249 (read_hex, load_charset_map_from_file): Check for integer overflow.
7251 * xterm.c: Don't go over XClientMessageEvent limit.
7252 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7253 (x_send_scroll_bar_event): Likewise. Check that the size does not
7254 exceed limits imposed by XClientMessageEvent, as well as the usual
7255 ptrdiff_t and size_t limits.
7257 * keyboard.c: Overflow, signedness and related fixes.
7258 (make_lispy_movement): Use same integer type in forward decl
7259 that is used in the definition.
7260 (read_key_sequence, keyremap_step):
7261 Change bufsize argument back to int, undoing my 2011-03-30 change.
7262 We prefer signed types, and int is wide enough here.
7263 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7264 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7265 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7266 length, not size_t. Use ptrdiff_t for index, not int.
7267 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7268 possibility of integer overflow.
7270 Overflow, signedness and related fixes for images.
7272 * dispextern.h (struct it.stack[0].u.image.image_id)
7273 (struct_it.image_id, struct image.id, struct image_cache.size)
7274 (struct image_cache.used, struct image_cache.ref_count):
7275 * gtkutil.c (update_frame_tool_bar):
7276 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7277 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7278 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7279 * nsmenu.m (update_frame_tool_bar):
7280 * xdisp.c (calc_pixel_width_or_height):
7281 * xfns.c (image_cache_refcount):
7282 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7283 on typical 64-bit hosts.
7285 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7286 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7287 Omit unnecessary casts to int.
7288 (parse_image_spec): Check that integers fall into 'int' range
7289 when the callers expect that.
7290 (image_ascent): Redo ascent calculation to avoid int overflow.
7291 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7292 (lookup_image): Remove unnecessary tests.
7293 (xbm_image_p): Locals are now of int, not EMACS_INT,
7294 since parse_image_check makes sure they fit into int.
7295 (png_load, gif_load, svg_load_image):
7296 Prefer int to unsigned where either will do.
7297 (tiff_handler): New function, combining the cores of the
7298 old tiff_error_handler and tiff_warning_handler.
7299 This function is rewritten to use vsnprintf and thereby avoid
7300 stack buffer overflows. It uses only the features of vsnprintf
7301 that are common to both POSIX and native Microsoft.
7302 (tiff_error_handler, tiff_warning_handler): Use it.
7303 (tiff_load, gif_load, imagemagick_load_image):
7304 Don't assume :index value fits in 'int'.
7305 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7306 (imagemagick_load_image): Check that crop parameters fit into
7307 the integer types that MagickCropImage accepts. Don't assume
7308 Vimagemagick_render_type has a nonnegative value. Don't assume
7309 size_t fits in 'long'.
7310 (gs_load): Use printmax_t to print the widest integers possible.
7311 Check for integer overflow when computing image height and width.
7313 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7315 * xdisp.c (redisplay_window): Don't force window start if point
7316 will be invisible in the resulting window. (Bug#9324)
7318 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7320 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7321 the display spec is of the form `(space ...)'.
7322 (handle_display_spec): Return the value returned by
7323 handle_single_display_spec, not just 1 or zero.
7324 (handle_single_display_spec): If the display spec is of the form
7325 `(space ...)', and specifies display in the text area, return 2
7327 (try_cursor_movement): Check for the need to scroll more
7328 accurately, and prefer exact match for point under bidi.
7329 Don't advance `row' beyond the last row of the window.
7331 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7332 into disp_prop; all users changed.
7334 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7335 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7336 for the text covered by the display property.
7338 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7340 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7341 Change return value to nil.
7342 (Frecord_buffer): Delete unused function.
7344 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7346 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7347 buffers, return left-to-right.
7348 (set_cursor_from_row): Consider candidate row a win if its glyph
7349 represents a newline and point is on that newline. Fixes cursor
7350 positioning on the newline at EOL of R2L text within L2R
7351 paragraph, and vice versa.
7352 (try_cursor_movement): Check continued rows, in addition to
7353 continuation rows. Fixes unwarranted scroll when point enters a
7354 continued line of R2L text within an L2R paragraph, or vice versa.
7355 (cursor_row_p): Consider the case of point being equal to
7356 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7357 from the end of a short line to the beginning of a continued line
7358 of R2L text within L2R paragraph.
7359 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7360 composed characters.
7362 * bidi.c (bidi_check_type): Use xassert.
7363 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7366 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7368 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7371 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7373 * nsfont.m (ns_otf_to_script): Fix typo.
7375 2011-08-22 Kenichi Handa <handa@m17n.org>
7377 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7378 extra slot even if the purpose is char-code-property-table.
7380 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7382 * xdisp.c (redisplay_window): When computing centering_position,
7383 account for the height of the header line. (Bug#8874)
7385 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7386 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7387 candidate is selected by the mouse, and that candidate has a
7388 composed character under the mouse.
7390 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7391 coordinates reported by pos-visible-in-window-p for a composed
7392 character in column zero.
7394 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7396 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7398 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7400 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7401 consider it a hit if to_charpos is anywhere in the range of the
7402 composed buffer positions.
7404 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7406 * image.c (gif_load): Don't assume that each subimage has the same
7407 dimensions as the base image. Handle disposal method that is
7408 "undefined" by the gif spec (Bug#9335).
7410 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7412 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7413 (Fcondition_case): Document `debug' symbol in error handler.
7415 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7417 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7418 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7419 from an Org mode buffer to a Speedbar frame.
7421 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7422 a composition, take its buffer position from IT->cmp_it.charpos.
7423 Fixes cursor positioning at the beginning of a line that begins
7424 with a composed character.
7426 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7428 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7429 character bidirectional type, use STRONG_L instead. Fixes crashes
7430 in a buffer produced by `describe-categories'.
7432 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7433 members before the level stack, so they would be saved and
7434 restored when copying iterator state. Fixes incorrect reordering
7435 around TABs covered by display properties.
7437 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7439 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7441 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7443 * eval.c (internal_condition_case, internal_condition_case_1)
7444 (internal_condition_case_2, internal_condition_case_n):
7445 Remove unnecessary aborts (Bug#9081).
7447 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7449 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7450 has no `load' handler, try opening the file locally. (Bug#9311)
7452 2011-08-16 Ken Brown <kbrown@cornell.edu>
7454 * gmalloc.c: Expand comment.
7456 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7458 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7459 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7461 2011-08-16 Ken Brown <kbrown@cornell.edu>
7463 Fix memory allocation problems in Cygwin build (Bug#9273).
7465 * unexcw.c ( __malloc_initialized): Declare external variable.
7466 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7468 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7470 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7472 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7474 [CYGWIN] (special_realloc): New function.
7475 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7476 requests to realloc storage in the static heap.
7478 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7480 * bidi.c (bidi_initialize): Remove unused local.
7482 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7485 * biditype.h: Remove file.
7486 * makefile.w32-in ($(BLD)/bidi.$(O)):
7487 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7489 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7491 * chartab.c: Improve commentary for the uniprop_table API.
7493 * bidi.c (bidi_paragraph_init): Support zero value of
7494 bidi_ignore_explicit_marks_for_paragraph_level.
7495 (bidi_initialize): Use uniprop_table instead of including
7496 biditype.h and bidimirror.h.
7498 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7499 coordinates of the iterator when restoring from ppos_it.
7502 2011-08-14 Kenichi Handa <handa@m17n.org>
7504 * process.c (create_process): Call setup_process_coding_systems
7505 after the pid of the process is set to -1 (Bug#8162).
7507 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7509 * xdisp.c (move_it_in_display_line_to): Don't invoke
7510 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7511 ppos_it. Fixes vertical cursor motion when line beginning is
7512 covered by an image. (Bug#9296)
7514 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7516 * nsterm.h (ns_run_ascript): Declare.
7517 (NSAPP_DATA2_RUNASSCRIPT): Define.
7519 * nsfns.m (as_script, as_result, as_status): New static variables.
7520 (ns_run_ascript): New function.
7521 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7522 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7523 the event loop. Get status from as_status (Bug#7276).
7525 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7526 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7527 the event loop (Bug#7276).
7529 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7531 * gnutls.c (QCgnutls_bootprop_priority)
7532 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7533 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7534 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7535 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7536 (QCgnutls_bootprop_verify_hostname_error)
7537 (QCgnutls_bootprop_callbacks_verify): Rename from
7538 Qgnutls_bootprop_..., all uses changed.
7540 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7543 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7545 * xfaces.c (Qframe_set_background_mode): Now static.
7546 * dispextern.h (Qframe_set_background_mode): Remove decl.
7548 * process.c (Fnetwork_interface_info): Declare local only if needed.
7550 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7552 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7553 (Fnetwork_interface_list): Allocate in increments of bytes instead
7554 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7555 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7557 (struct ifflag_def): notrailers is smart on OSX.
7558 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7559 Get hardware address with getifaddrs if available.
7561 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7563 * xdisp.c (iterate_out_of_display_property): xassert that
7564 IT->position is set to within IT->object's boundaries. Break from
7565 the loop as soon as EOB is reached; avoids infloops in redisplay
7566 when IT->position is set up wrongly due to some bug.
7567 Set IT->current to match the bidi iterator unconditionally.
7568 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7569 entry. Force push_it to save on the stack the current
7570 buffer/string position, to be restored by pop_it. Fix flags in
7571 the iterator structure wrt the object coming from a display
7572 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7573 properties. (Bug#9284)
7575 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7577 * fontset.c (fontset_get_font_group): Add proper type checks.
7580 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7582 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7583 and LC_VERSION_MIN_MACOSX.
7584 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7585 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7587 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7589 * xdisp.c (forward_to_next_line_start): Allow to use the
7590 no-display-properties-and-no-overlays under bidi display.
7591 Set disp_pos in the bidi iterator to avoid searches for display
7592 properties and overlays.
7594 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7596 * editfns.c (Fset_time_zone_rule): Document relationship with the
7599 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7600 the font entity extracted from the cache (Bug#8109).
7602 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7604 * composite.c (autocmp_chars): Don't reset point. That is done by
7605 restore_point_unwind (Bug#5984).
7607 2011-08-07 Juri Linkov <juri@jurta.org>
7609 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7610 to show the arg `TIME' instead of `TIMEVAL'.
7612 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7614 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7615 display property strides EOL and includes a newline, as in
7616 longlines-mode. (Bug#9254)
7617 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7618 word-wrap under bidirectional display. (Bug#9224)
7620 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7621 is non-zero, even if the data buffer is NULL. Fixes a crash in
7622 vertical-motion with longlines-mode. (Bug#9254)
7624 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7626 * bidi.c <bidi_cache_total_alloc>: Now static.
7627 (bidi_initialize): Initialize bidi_cache_total_alloc.
7629 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7632 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7633 amount allocated this far in `bidi_cache_total_alloc'.
7634 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7635 non-zero, only free the data buffer without restoring the cache
7636 contents. All callers changed.
7638 * dispextern.h (bidi_unshelve_cache): Update prototype.
7640 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7641 (move_it_in_display_line, move_it_to)
7642 (move_it_vertically_backward, move_it_by_lines): Replace the call
7643 to xfree to an equivalent call to bidi_unshelve_cache.
7644 (move_it_in_display_line_to): Fix logic of returning
7645 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7647 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7649 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7650 came from a string character with a `cursor' property. (Bug#9229)
7652 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7654 * Makefile.in (LIB_PTHREAD): New variable.
7655 (LIBES): Add LIB_PTHREAD (Bug#9216).
7657 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7658 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7660 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7662 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7664 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7666 * xterm.c (x_find_topmost_parent): New function.
7667 (x_set_frame_alpha): Find topmost parent window with
7668 x_find_topmost_parent and set the property there also (bug#9181).
7669 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7671 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7673 * callproc.c (Fcall_process): Avoid vfork clobbering
7674 the local vars buffer, coding_systems, current_dir.
7676 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7678 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7680 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7682 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7683 so that it is not optimized away.
7685 * xdisp.c (compute_display_string_pos): Remove unused local.
7687 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7689 Fix slow cursor motion and scrolling in large buffers with
7690 selective display, like Org Mode buffers. (Bug#9218)
7692 * dispextern.h (struct bidi_it): New member disp_prop_p.
7694 * xdisp.c: Remove one-slot cache of display string positions.
7695 (compute_display_string_pos): Accept an additional argument
7696 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7697 for a display string or property. If found, set DISP_PROP_P
7700 * bidi.c (bidi_fetch_char): Accept an additional argument
7701 DISP_PROP_P, and pass it to compute_display_string_pos.
7702 Only handle text covered by a display string if DISP_PROP_P is returned
7703 non-zero. All callers of bidi_fetch_char changed.
7705 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7707 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7709 2010-12-03 Don March <don@ohspite.net>
7711 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7712 last character M-[char] is translated to ESC [char] (bug#7541).
7714 2011-08-02 Kenichi Handa <handa@m17n.org>
7716 * lisp.h (uniprop_table): Extern it.
7718 * chartab.c (uniprop_table): Make it non-static.
7720 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7722 * xdisp.c (forward_to_next_line_start): Accept additional argument
7723 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7725 (reseat_at_next_visible_line_start): Use the bidi iterator state
7726 returned by forward_to_next_line_start to restore the state of
7727 it->bidi_it after backing up to previous newline. (Bug#9212)
7729 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7731 * regex.c (re_comp): Protoize.
7732 (re_exec): Fix return type.
7733 (regexec): Fix type of `ret'. (Bug#9203)
7735 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7737 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7738 This is needed if max-image-size is a floating-point number.
7740 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7742 * print.c (print_object): Print empty symbol as ##.
7744 * lread.c (read1): Read ## as empty symbol.
7746 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7748 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7749 setting frame foreground color (Bug#9175).
7750 (x_set_background_color): Likewise.
7752 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7753 contents (Bug#9176).
7754 (EmacsTooltip -init): Remove bezels and add shadows to
7757 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7758 or scroll bar (Bug#8470).
7760 * nsfont.m (nsfont_open): Remove assignment to voffset and
7761 unnecessary vars hshink, expand, hd, full_height, min_height.
7762 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7764 * nsterm.h (nsfont_info): Remove voffset field.
7766 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7768 Implement strike-through and overline on NextStep (Bug#8863).
7770 * nsfont.m (nsfont_open): Use underline position provided by font,
7771 instead of hard-coded value of 2.
7772 (nsfont_draw): Call ns_draw_text_decoration instead.
7774 * nsterm.h: Add declaration for ns_draw_text_decoration.
7776 * nsterm.m (ns_draw_text_decoration): New function for drawing
7777 underline, overline, and strike-through.
7778 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7779 ns_draw_text_decoration. Change treatment of cursor drawing to
7780 accommodate underlining, etc.
7782 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7784 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7787 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7789 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7790 Without this fix, if a signal arrives just after memory fills up,
7791 'malloc' might be invoked reentrantly.
7793 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7794 In other words, assume that every image size is allowed, on non-X
7795 hosts. This assumption is probably wrong, but it lets Emacs compile.
7797 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7799 * regex.c (re_iswctype): Convert return values to boolean.
7801 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7803 * xdisp.c (compute_display_string_pos): Don't use cached display
7804 string position if the buffer had its restriction changed.
7807 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7809 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7811 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7813 Integer signedness and overflow and related fixes. (Bug#9079)
7815 * bidi.c: Integer size and overflow fixes.
7816 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7817 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7818 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7819 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7820 (bidi_find_other_level_edge):
7821 Use ptrdiff_t instead of EMACS_INT where either will do.
7822 This works better on 32-bit hosts configured --with-wide-int.
7823 (bidi_cache_ensure_space): Check for size-calculation overflow.
7824 Use % rather than repeated addition, for better worst-case speed.
7825 Don't set bidi_cache_size until after xrealloc returns, because it
7827 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7828 (bidi_cache_ensure_space): Also check that the bidi cache size
7829 does not exceed that of the largest Lisp string or buffer. See Eli
7830 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7832 * alloc.c (__malloc_size_t): Remove.
7833 All uses replaced by size_t. See Andreas Schwab's note
7834 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7836 * image.c: Improve checking for integer overflow.
7837 (check_image_size): Assume that f is nonnull, since
7838 it is always nonnull in practice. This is one less thing to
7839 worry about when checking for integer overflow later.
7840 (x_check_image_size): New function, which checks for integer
7841 overflow issues inside X.
7842 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7843 This removes the need for a memory_full check.
7844 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7845 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7846 (xbm_read_bitmap_data): Change locals back to 'int', since
7847 their values must fit in 'int'.
7848 (xpm_load_image, png_load, tiff_load):
7849 Invoke x_create_x_image_and_pixmap earlier,
7850 to avoid much needless work if the image is too large.
7851 (tiff_load): Treat overly large images as if
7852 x_create_x_image_and_pixmap failed, not as malloc failures.
7853 (gs_load): Use x_check_image_size.
7855 * gtkutil.c: Omit integer casts.
7856 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7857 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7859 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7861 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7862 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7863 would wrongly return t on a 64-bit host.
7865 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7866 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7867 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7868 and therefore cause GCC to emit a bogus diagnostic in some cases.
7870 * image.c: Integer signedness and overflow and related fixes.
7871 This is not an exhaustive set of fixes, but it's time to
7872 record what I've got.
7873 (lookup_pixel_color, check_image_size): Remove redundant decls.
7874 (check_image_size): Don't assume that arbitrary EMACS_INT values
7875 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7876 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7877 (tiff_load, imagemagick_load_image):
7878 Check for overflow in size calculations.
7879 (x_create_x_image_and_pixmap): Remove unnecessary test for
7880 xmalloc returning NULL; that can't happen.
7881 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7882 (xpm_color_bucket): Use better integer hashing function.
7883 (xpm_cache_color): Don't possibly over-allocate memory.
7884 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7885 (gif_memory_source):
7886 Use ptrdiff_t, not int or size_t, to record sizes.
7887 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7888 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7889 either works, as we prefer signed integers.
7890 (tiff_read_from_memory, tiff_write_from_memory):
7891 Return tsize_t, not size_t, since that's what the TIFF API wants.
7892 (tiff_read_from_memory): Don't fail simply because the read would
7893 go past EOF; instead, return a short read.
7894 (tiff_load): Omit no-longer-needed casts.
7895 (Fimagemagick_types): Don't assume size fits into 'int'.
7897 Improve hashing quality when configured --with-wide-int.
7898 * fns.c (hash_string): New function, taken from sxhash_string.
7899 Do not discard information about ASCII character case; this
7900 discarding is no longer needed.
7901 (sxhash-string): Use it. Change sig to match it. Caller changed.
7902 * lisp.h: Declare it.
7903 * lread.c (hash_string): Remove, since we now use fns.c's version.
7904 The fns.c version returns a wider integer if --with-wide-int is
7905 specified, so this should help the quality of the hashing a bit.
7907 * emacs.c: Integer overflow minor fix.
7908 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7909 Define only if GNU_LINUX.
7910 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7912 * dispnew.c: Integer signedness and overflow fixes.
7913 Remove unnecessary forward decls, that were a maintenance hassle.
7914 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7916 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7917 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7918 (prepare_desired_row, line_draw_cost):
7919 Use int, not unsigned, where either works.
7920 (save_current_matrix, restore_current_matrix):
7921 Use ptrdiff_t, not size_t, where either works.
7922 (init_display): Check for overflow more accurately, and without
7923 relying on undefined behavior.
7925 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7926 Remove, replacing with the new symbols in lisp.h. All uses changed.
7927 * fileio.c (make_temp_name):
7928 * filelock.c (lock_file_1, lock_file):
7929 * xdisp.c (message_dolog):
7930 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7931 Use pMd etc. instead.
7932 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7933 replacing the pWIDE etc. symbols removed from editfns.c.
7935 * keyboard.h (num_input_events): Now uintmax_t.
7936 This is (very slightly) less likely to mess up due to wraparound.
7939 * buffer.c: Integer signedness fixes.
7940 (alloc_buffer_text, enlarge_buffer_text):
7941 Use ptrdiff_t rather than size_t when either will do, as we prefer
7944 * alloc.c: Integer signedness and overflow fixes.
7945 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7946 (__malloc_size_t): Default to size_t, not to int.
7947 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7948 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7949 Prefer ptrdiff_t to size_t when either would do, as we prefer
7951 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7952 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7953 Now const. Initialize with values that are in range even if char
7955 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7956 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7957 These functions do the right thing with sizes > 2**32.
7958 (check_depth): Now ptrdiff_t, not int.
7959 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7960 Adjust to new way of storing sizes. Check for size overflow bugs
7962 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7963 slightly wrong anyway, as it missed one instance of
7964 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7965 (refill_memory_reserve): Omit needless cast to size_t.
7966 (mark_object_loop_halt): Mark as externally visible.
7968 * xselect.c: Integer signedness and overflow fixes.
7969 (Fx_register_dnd_atom, x_handle_dnd_message):
7970 Use ptrdiff_t, not size_t, since we prefer signed.
7971 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7972 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7973 x_dnd_atoms_size and x_dnd_atoms_length.
7975 * doprnt.c: Prefer signed to unsigned when either works.
7977 * doprnt.c (doprnt):
7979 * xdisp.c (vmessage):
7980 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7981 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7982 prefer signed arithmetic to avoid comparison confusion.
7983 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7984 but is a bit tricky.
7986 Assume freestanding C89 headers, string.h, stdlib.h.
7987 * data.c, doprnt.c, floatfns.c, print.c:
7988 Include float.h unconditionally.
7989 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7990 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7991 * regex.c: Likewise for stddef.h, string.h.
7992 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7993 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7994 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7995 (STDC_HEADERS): Remove obsolete defines.
7996 * sysdep.c: Include limits.h unconditionally.
7998 Assume support for memcmp, memcpy, memmove, memset.
7999 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8000 * regex.c (memcmp, memcpy):
8001 Remove; we assume C89 now.
8003 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8004 (__malloc_safe_bcopy): Remove; no longer needed.
8006 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8007 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8008 well either way, and we prefer signed to unsigned.
8010 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8012 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8013 closes the connection while we're reading (bug#9182).
8015 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8017 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8018 are specified (Bug#9168).
8020 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8022 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8023 Found by GCC static checking and --with-wide-int on a 32-bit host.
8025 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8027 * xdisp.c (compute_display_string_pos): Fix logic of caching
8028 previous display string position. Initialize cached_prev_pos to
8029 -1. Fixes slow-down at the beginning of a buffer.
8031 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8033 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8034 for attrs[LFACE_FONTSET_INDEX].
8036 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8038 * xml.c (parse_region): Remove unused local
8039 that was recently introduced.
8041 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8043 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8044 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8046 * xdisp.c (move_it_in_display_line_to): Record the best matching
8047 position for TO_CHARPOS while scanning the line, and restore it on
8048 exit if none of the characters scanned was an exact match.
8049 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8050 when exact match is impossible due to invisible text, and the
8051 lines are truncated.
8053 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8055 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8058 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8060 Fix a significant slow-down of cursor motion with C-n, C-p,
8061 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8062 auto-repeat under bidi redisplay in fontified buffers.
8063 * xdisp.c (compute_stop_pos_backwards): New function.
8064 (next_element_from_buffer): Call compute_stop_pos_backwards to
8065 find a suitable prev_stop when we find ourselves before
8067 (reseat): Don't look for prev_stop, as that could mean a very long
8069 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8070 <cached_disp_overlay_modiff>: Cache for last found display string
8072 (compute_display_string_pos): Return the cached position if asked
8073 about the same buffer in the same area of character positions, and
8074 the buffer wasn't changed since the time the display string
8075 position was cached.
8077 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8079 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8080 is an integer, which is important for empty lines. (Bug#9149)
8082 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8084 * frame.c (Fmodify_frame_parameters): In tty case, update the
8085 default face if necessary (Bug#4238).
8087 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8089 * editfns.c (Fstring_to_char): No need to explain what a character
8090 is in the docstring (Bug#6576).
8092 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8094 * xml.c (parse_region): Make sure we always return a tree.
8096 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8098 * xml.c (parse_region): If a document contains only comments,
8101 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8103 * xml.c (make_dom): Return comments, too.
8105 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8108 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8109 and the surrounding thread.
8110 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8111 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8112 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8114 * s/openbsd.h (BROKEN_SIGIO): Define.
8115 * unexelf.c (unexec) [__OpenBSD__]:
8116 Don't update the .mdebug section of the Alpha COFF symbol table.
8118 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8120 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8123 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8125 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8126 This fixes some race conditions on the permissions of any newly
8129 * alloc.c (valid_pointer_p): Use pipe, not open.
8130 This fixes some permissions issues when debugging.
8132 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8133 If fchown fails to set both uid and gid, try to set just gid,
8134 as that is sometimes allowed. Adjust the file's mode to eliminate
8135 setuid or setgid bits that are inappropriate if fchown fails.
8137 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8139 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8140 to compare Lisp_Objects.
8141 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8142 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8143 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8145 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8147 * lread.c (read_integer): Unread even EOF character.
8148 (read1): Likewise. Properly record start position of symbol.
8150 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8151 symbol character follows.
8153 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8155 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8156 This works around a problem with the previous change to Fcopy_file.
8157 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8158 and without this change, GCC might complain about discarding
8159 fchown's return value.
8161 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8163 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8165 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8167 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8169 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8171 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8172 it's used from the C level.
8174 * process.c: Use the same condition for POLL_FOR_INPUT in both
8175 keyboard.c and process.c (bug#1858).
8177 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8179 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8180 (Fgnutls_boot): Use it.
8182 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8184 * doc.c (Fsubstitute_command_keys): Revert last change.
8186 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8188 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8189 quotes the next character, and doesn't affect other longer
8190 sequences (bug#8935).
8192 * lread.c (syms_of_lread): Clarify that is isn't only
8193 `eval-buffer' and `eval-defun' that's affected by
8194 `lexical-binding' (bug#8460).
8196 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8198 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8199 bidi redisplay when a line includes both an image and is truncated.
8201 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8203 Fix minor problems found by static checking.
8204 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8205 (elsz): Now a signed constant, not a size_t var. We prefer signed
8206 types to unsigned, to avoid integer comparison confusion. Without
8207 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8208 "cannot optimize loop, the loop counter may overflow", a symptom
8210 * indent.c (Fvertical_motion): Mark locals as initialized.
8211 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8213 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8215 * search.c (Fre_search_backward): Mention `case-fold-search' in
8216 all the re_search_* functions (bug#8138).
8218 * keyboard.c (Fopen_dribble_file): Document when the file is
8221 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8223 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8226 Support bidi reordering of display and overlay strings.
8227 * xdisp.c (compute_display_string_pos)
8228 (compute_display_string_end): Accept additional argument STRING.
8229 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8230 (reseat_to_string): Initialize bidi_it->string.s and
8231 bidi_it->string.schars.
8232 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8233 NULL (avoids a crash in bidi_paragraph_init).
8234 Initialize itb.string.lstring.
8235 (init_iterator): Call bidi_init_it only of a valid
8236 buffer position was specified. Initialize paragraph_embedding to
8238 (reseat_to_string): Initialize the bidi iterator.
8239 (display_string): If we need to ignore text properties of
8240 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8241 original value of -1 will not work with bidi.)
8242 (compute_display_string_pos): First arg is now struct
8243 `text_pos *'; all callers changed. Support display properties on
8245 (compute_display_string_end): Support display properties on Lisp
8247 (init_iterator, reseat_1, reseat_to_string): Initialize the
8248 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8249 when iterating on a string not from display properties).
8250 (compute_display_string_pos, compute_display_string_end):
8251 Fix calculation of the object to scan. Fixes an error when using
8253 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8254 base_level_stop; instead, set base_level_stop to BEGV.
8255 Fixes crashes in vertical-motion.
8256 (next_element_from_buffer): Improve commentary for when
8257 the iterator is before prev_stop.
8258 (init_iterator): Initialize bidi_p from the default value of
8259 bidi-display-reordering, not from buffer-local value. Use the
8260 buffer-local value only if initializing for buffer iteration.
8261 (handle_invisible_prop): Support invisible properties on strings
8262 that are being bidi-reordered.
8263 (set_iterator_to_next): Support bidi reordering of C strings and
8265 (next_element_from_string): Support bidi reordering of Lisp
8267 (handle_stop_backwards): Support Lisp strings as well.
8268 (display_string): Support display of R2L glyph rows.
8269 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8270 (init_iterator): Don't initialize it->bidi_p for strings
8272 (reseat_to_string): Initialize it->bidi_p for strings here.
8273 (next_element_from_string, next_element_from_c_string)
8274 (next_element_from_buffer): Add xassert's for correspondence
8275 between IT's object being iterated and it->bidi_it.string
8277 (face_before_or_after_it_pos): Support bidi iteration.
8278 (next_element_from_c_string): Handle the case of the first string
8279 character that is not the first one in the visual order.
8280 (get_visually_first_element): New function, refactored from common
8281 parts of next_element_from_buffer, next_element_from_string, and
8282 next_element_from_c_string.
8283 (tool_bar_lines_needed, redisplay_tool_bar)
8284 (display_menu_bar): Force left-to-right direction. Add a FIXME
8285 comment for making that be controlled by a user option.
8286 (push_it, pop_it): Save and restore the state of the
8287 bidi iterator. Save and restore the bidi_p flag.
8288 (pop_it): Iterate out of display property for string iteration as
8290 (iterate_out_of_display_property): Support iteration over strings.
8291 (handle_single_display_spec): Set up it->bidi_it for iteration
8292 over a display string, and call bidi_init_it.
8293 (handle_single_display_spec, next_overlay_string)
8294 (get_overlay_strings_1, push_display_prop): Set up the bidi
8295 iterator for displaying display or overlay strings.
8296 (forward_to_next_line_start): Don't use the shortcut if
8298 (back_to_previous_visible_line_start): If handle_display_prop
8299 pushed the iterator stack, restore the internal state of the bidi
8300 iterator by calling bidi_pop_it same number of times.
8301 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8302 and we are bidi-iterating, don't decrement the iterator position;
8303 instead, set the first_elt flag in the bidi iterator, to produce
8305 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8306 (push_display_prop): xassert that we are iterating a buffer.
8307 (push_it, pop_it): Save and restore paragraph_embedding member.
8308 (handle_single_display_spec, next_overlay_string)
8309 (get_overlay_strings_1, reseat_1, reseat_to_string)
8310 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8311 correctly. Don't assume unibyte strings are not bidi-reordered.
8312 (compute_display_string_pos)
8313 (compute_display_string_end): Fix handling the case of C string.
8314 (push_it, pop_it): Save and restore from_disp_prop_p.
8315 (handle_single_display_spec, push_display_prop): Set the
8316 from_disp_prop_p flag.
8317 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8318 (pop_it): Call iterate_out_of_display_property only if we are
8319 popping after iteration over a string that came from a display
8320 property. Fix a typo in popping stretch info. Add an assertion
8321 for verifying that the iterator position is in sync with the bidi
8323 (handle_single_display_spec, get_overlay_strings_1)
8324 (push_display_prop): Fix initialization of paragraph direction for
8325 string when that of the parent object is not yet determined.
8326 (reseat_1): Call bidi_init_it to resync the bidi
8327 iterator with IT's position. (Bug#7616)
8328 (find_row_edges): If ROW->start.pos gives position
8329 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8330 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8331 Reset the from_disp_prop_p flag.
8332 (SAVE_IT, RESTORE_IT): New macros.
8333 (pos_visible_p, face_before_or_after_it_pos)
8334 (back_to_previous_visible_line_start)
8335 (move_it_in_display_line_to, move_it_in_display_line)
8336 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8337 (try_scrolling, redisplay_window, display_line): Use them when
8338 saving a temporary copy of the iterator and restoring it back.
8339 (back_to_previous_visible_line_start, reseat_1)
8340 (init_iterator): Empty the bidi cache "stack".
8341 (move_it_in_display_line_to): If iterator ended up at
8342 EOL, but we never saw any buffer positions smaller than
8343 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8344 motion in bidi-reordered lines.
8345 (move_it_in_display_line_to): Record prev_method and prev_pos
8346 immediately before the call to set_iterator_to_next. Fixes cursor
8347 motion in bidi-reordered lines with stretch glyphs and strings
8348 displayed in margins. (Bug#8133) (Bug#8867)
8349 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8351 (pos_visible_p): Support positions in bidi-reordered lines.
8352 Save and restore bidi cache.
8354 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8355 (bidi_paragraph_info): Delete unused struct.
8356 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8357 (bidi_cache_start): New variable.
8358 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8360 (bidi_cache_fetch_state, bidi_cache_search)
8361 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8362 (bidi_cache_find, bidi_peek_at_next_level)
8363 (bidi_level_of_next_char, bidi_find_other_level_edge)
8364 (bidi_move_to_visually_next): Compare cache index with
8365 bidi_cache_start rather than with zero.
8366 (bidi_fetch_char): Accept new argument STRING; all callers
8367 changed. Support iteration over a string. Support strings with
8368 display properties. Support unibyte strings. Fix the type of
8369 `len' according to what STRING_CHAR_AND_LENGTH expects.
8370 (bidi_paragraph_init, bidi_resolve_explicit_1)
8371 (bidi_resolve_explicit, bidi_resolve_weak)
8372 (bidi_level_of_next_char, bidi_move_to_visually_next):
8373 Support iteration over a string.
8374 (bidi_set_sor_type, bidi_resolve_explicit_1)
8375 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8376 can now be zero (for strings); special values 0 and -1 were
8377 changed to -1 and -2, respectively.
8378 (bidi_char_at_pos): New function.
8379 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8380 Call it instead of FETCH_MULTIBYTE_CHAR.
8381 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8382 initialized to valid values.
8383 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8385 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8386 the test for valid cached positions. Fix the logic for looking up
8387 the sentinel state in the cache. GCPRO the Lisp string we are
8389 (bidi_push_it, bidi_pop_it): New functions.
8390 (bidi_initialize): Initialize the bidi cache start stack pointer.
8391 (bidi_cache_ensure_space): New function, refactored from part of
8392 bidi_cache_iterator_state. Don't assume the required size is just
8393 one BIDI_CACHE_CHUNK away.
8394 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8395 (bidi_count_bytes, bidi_char_at_pos): New functions.
8396 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8397 always valid if bidi_cache_idx is valid.
8398 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8399 is valid if it's going to be used.
8400 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8401 (bidi_cache_fetch_state, bidi_cache_search)
8402 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8403 (bidi_cache_iterator_state, bidi_cache_find)
8404 (bidi_find_other_level_edge, bidi_cache_start_stack):
8405 All variables related to cache indices are now EMACS_INT.
8407 * dispextern.h (struct bidi_string_data): New structure.
8408 (struct bidi_it): New member `string'. Make flag members be 1-bit
8409 fields, and put them last in the struct.
8410 (compute_display_string_pos, compute_display_string_end):
8412 (bidi_push_it, bidi_pop_it): Add prototypes.
8413 (struct iterator_stack_entry): New members bidi_p,
8414 paragraph_embedding, and from_disp_prop_p.
8415 (struct it): Member bidi_p is now a bit field 1 bit wide.
8416 (bidi_shelve_cache, bidi_unshelve_cache):
8419 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8420 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8421 and vector-like objects.
8423 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8424 cache around display iteration.
8426 * window.c (Fwindow_end, window_scroll_pixel_based)
8427 (displayed_window_lines, Frecenter): Save and restore the bidi
8428 cache around display iteration.
8430 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8432 * editfns.c (Fdelete_region): Clarify the use of the named
8433 parameters (bug#6788).
8435 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8437 * indent.c (Fvertical_motion): Set and restore w->pointm when
8438 saving and restoring the window's buffer (Bug#9006).
8440 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8442 * editfns.c (Fstring_to_char): Clarify just what is returned
8443 (bug#6576). Text by Eli Zaretskii.
8445 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8447 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8449 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8451 * buffer.c (mmap_find): Fix a typo.
8453 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8455 Fix execution of x selection hooks.
8456 * xselect.c (Qx_lost_selection_functions)
8457 (Qx_sent_selection_functions): New vars.
8458 (syms_of_xselect): DEFSYM them.
8459 (x_handle_selection_request): Pass Qx_sent_selection_functions
8460 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8461 (x_handle_selection_clear,x_clear_frame_selections):
8462 Pass Qx_lost_selection_functions rather than
8463 Vx_lost_selection_functions to Frun_hook_with_args.
8465 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8467 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8468 The old code sometimes used this field without initializing it.
8470 * alloc.c (gc_sweep): Don't read past end of array.
8471 In theory, the old code could also have corrupted Emacs internals,
8472 though it'd be very unlikely.
8474 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8476 * character.c (Fcharacterp): Don't advertise optional ignored
8477 argument. (Bug#4026)
8479 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8481 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8484 * window.c (Fset_window_start): Doc fix (bug#4199).
8485 (Fset_window_hscroll): Ditto.
8487 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8489 Fix minor new problems caught by GCC 4.6.1.
8490 * term.c (init_tty): Remove unused local.
8491 * xsettings.c (store_monospaced_changed): Define this function only
8492 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8495 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8497 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8499 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8501 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8502 are the mini-buffer and the echo area (bug#3320).
8504 * term.c (init_tty): Remove support for supdup, c10 and perq
8505 terminals, which are no longer supported (bug#1482).
8507 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8509 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8511 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8513 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8514 for non-popups (Bug#3642).
8516 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8518 * alloc.c (reset_malloc_hooks): Protoize.
8519 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8520 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8521 * cm.c (losecursor): Likewise.
8522 * data.c (fmod): Likewise.
8523 * dispnew.c (swap_glyphs_in_rows): Likewise.
8524 * emacs.c (memory_warning_signal): Likewise.
8525 * floatfns.c (float_error): Likewise.
8526 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8527 (otf_open, font_otf_capability, generate_otf_features)
8528 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8530 * image.c (pbm_read_file): Likewise.
8531 * indent.c (string_display_width): Likewise.
8532 * intervals.c (check_for_interval, search_for_interval)
8533 (inc_interval_count, count_intervals, root_interval)
8534 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8535 * lread.c (defalias): Likewise.
8536 * ralloc.c (r_alloc_check): Likewise.
8537 * regex.c (set_image_of_range_1, set_image_of_range)
8538 (regex_grow_registers): Likewise.
8539 * sysdep.c (strerror): Likewise.
8540 * termcap.c (valid_filename_p, tprint, main): Likewise.
8541 * tparam.c (main): Likewise.
8542 * unexhp9k800.c (run_time_remap, save_data_space)
8543 (update_file_ptrs, read_header, write_header, calculate_checksum)
8544 (copy_file, copy_rest, display_header): Likewise.
8545 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8547 * xdisp.c (check_it): Likewise.
8548 * xfaces.c (register_color, unregister_color, unregister_colors):
8550 * xfns.c (print_fontset_result): Likewise.
8551 * xrdb.c (member, fatal, main): Likewise.
8553 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8555 Fix minor problems found by static checking (Bug#9031).
8556 * chartab.c (char_table_set_range, map_sub_char_table):
8557 Remove unused locals.
8558 (uniprop_table): Now static.
8559 * composite.c (_work_char): Remove unused static var.
8561 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8563 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8565 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8567 * gtkutil.c (qttip_cb): Remove code without function.
8569 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8571 * w32.c (pthread_sigmask): New stub.
8573 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8575 Use pthread_sigmask, not sigprocmask (Bug#9010).
8576 sigprocmask is portable only for single-threaded applications, and
8577 Emacs can be multi-threaded when it uses GTK.
8578 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8580 * callproc.c (Fcall_process):
8581 * process.c (create_process):
8582 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8583 Use pthread_sigmask, not sigprocmask.
8585 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8587 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8588 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8591 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8593 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8594 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8595 (xg_hide_tooltip): Fix comment.
8597 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8598 in registerServicesMenuSendTypes.
8599 (validRequestorForSendType): Don't check ns_return_types.
8601 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8604 2011-07-08 Jason Rumney <jasonr@gnu.org>
8606 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8607 SH_SHOW for hidden windows (Bug#5482).
8609 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8610 frame struct members of non-existent frames (Bug#6284).
8612 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8614 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8615 variable firstTime not needed on OSX >= 10.6.
8616 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8617 >= 10.5. Use setKnobProportion, setDoubleValue.
8619 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8620 (MAC_OS_X_VERSION_10_5): Define if not defined.
8621 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8622 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8623 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8625 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8626 cString and lossyCString on OSX >= 10.4.
8628 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8629 sizeToFit on OSX >= 10.2.
8631 * nsimage.m (allocInitFromFile): Don't use deprecated method
8632 bestRepresentationForDevice on OSX >= 10.6.
8634 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8637 * emacs.c: Declare unexec_init_emacs_zone.
8639 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8641 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8643 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8644 on svcsMenu (Bug#8842).
8646 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8648 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8650 * nsterm.m (QUTF8_STRING): Declare.
8651 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8652 (validRequestorForSendType): Return type is (id).
8653 Change indexOfObjectIdenticalTo to indexOfObject.
8654 Check if we have local selection before returning self (Bug#8842).
8655 (writeSelectionToPasteboard): Put local selection into paste board
8656 if we have a local selection (Bug#8842).
8657 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8659 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8660 (ns_get_local_selection): Declare.
8662 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8664 * keymap.c (describe_map_tree): Don't insert a double newline at
8665 the end of the buffer (bug#1169) and return whether we inserted
8668 * callint.c (Fcall_interactively): Change "reading args" to
8669 "providing args" to try to clarify what it does (bug#1010).
8671 2011-07-07 Kenichi Handa <handa@m17n.org>
8673 * composite.c (composition_compute_stop_pos): Ignore a static
8674 composition starting before CHARPOS (Bug#8915).
8676 * xdisp.c (handle_composition_prop): Likewise.
8678 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8680 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8683 2011-07-07 Kenichi Handa <handa@m17n.org>
8685 * character.h (unicode_category_t): New enum type.
8687 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8688 (Qchar_code_property_table): New variable.
8689 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8690 (UNIPROP_COMPRESSED_FORM_P): New macros.
8691 (char_table_ascii): Uncompress the compressed values.
8692 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8693 Uncompress the compressed values.
8694 (sub_char_table_ref_and_range): Likewise.
8695 (char_table_ref_and_range): Uncompress the compressed values.
8696 (sub_char_table_set): New arg is_uniprop. Callers changed.
8697 Uncompress the compressed values.
8698 (sub_char_table_set_range): Args changed. Callers changed.
8699 (char_table_set_range): Adjuted for the above change.
8700 (map_sub_char_table): Delete args default_val and parent. Add arg
8701 top. Give decoded values to a Lisp function.
8702 (map_char_table): Adjust for the above change. Give decoded
8703 values to a Lisp function. Gcpro more variables.
8704 (uniprop_table_uncompress)
8705 (uniprop_decode_value_run_length): New functions.
8706 (uniprop_decoder, uniprop_decoder_count): New variables.
8707 (uniprop_get_decoder, uniprop_encode_value_character)
8708 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8710 (uniprop_encoder, uniprop_encoder_count): New variables.
8711 (uniprop_get_encoder, uniprop_table)
8712 (Funicode_property_table_internal, Fget_unicode_property_internal)
8713 (Fput_unicode_property_internal): New functions.
8714 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8715 Sunicode_property_table_internal, Sget_unicode_property_internal,
8716 and Sput_unicode_property_internal. Defvar_lisp
8717 char-code-property-alist.
8719 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8720 Vunicode_category_table.
8722 * font.c (font_range): Adjust for the change of
8723 Vunicode_category_table.
8725 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8727 * m/iris4d.h: Remove file, move contents ...
8728 * s/irix6-5.h: ... here.
8730 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8732 Remove unportable assumption about struct layout (Bug#8884).
8733 * alloc.c (mark_buffer):
8734 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8735 (clone_per_buffer_values): Don't assume that
8736 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8737 This isn't true in general, and it's particularly not true
8738 if Emacs is configured with --with-wide-int.
8739 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8740 New macros, used in the buffer.c change.
8742 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8744 * xsettings.c: Use both GConf and GSettings if both are available.
8745 (store_config_changed_event): Add comment.
8746 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8747 (store_tool_bar_style_changed): New functions.
8748 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8749 (struct xsettings): Move font inside HAVE_XFT.
8750 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8751 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8752 Move inside HAVE_XFT.
8753 (something_changed_gsettingsCB): Rename from something_changedCB.
8754 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8756 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8757 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8758 (something_changed_gconfCB): Rename from something_changedCB.
8759 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8760 (parse_settings): Move check for font inside HAVE_XFT.
8761 (read_settings, apply_xft_settings): Add comment.
8762 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8763 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8764 call store_font_name_changed.
8765 (xft_settings_event): Add comment.
8766 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8767 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8768 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8769 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8770 (xsettings_initialize): Call init_gsettings last.
8771 (xsettings_get_system_font, xsettings_get_system_normal_font):
8774 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8776 Random fixes. E.g., (random) never returned negative values.
8777 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8778 subseconds part to the entropy, as that's a bit more random.
8779 Prefer signed to unsigned, since the signedness doesn't matter and
8780 in general we prefer signed. When given a limit, use a
8781 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8782 latter isn't right if USE_2_TAGS_FOR_INTS.
8783 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8784 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8786 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8788 * textprop.c (text_property_stickiness):
8789 Obey Vtext_property_default_nonsticky.
8790 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8791 * w32fns.c (syms_of_w32fns):
8792 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8794 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8796 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8797 This is more efficient than Ffile_directory_p and avoids a minor race.
8799 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8801 * buffer.c (Foverlay_put): Say what the return value is
8804 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8805 is a directory before asking whether to use the file name
8807 (barf_or_query_if_file_exists): Make the "File is a directory"
8808 error be more correct.
8810 * fns.c (Frequire): Remove the mention of the .gz files, since
8811 that's installation-specific, but keep the mention of
8812 `get-load-suffixes'.
8814 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8816 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8817 Report string overflow if the output is too long.
8819 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8821 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8822 (syms_of_gnutls): Remove duplicate DEFSYM for
8823 Qgnutls_bootprop_verify_hostname_error, an error for
8824 Qgnutls_bootprop_verify_error (which is no longer used).
8826 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8827 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8828 Also (re)move comments that are misplaced or no longer relevant.
8830 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8832 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8834 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8836 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8837 and background color parameters if they have been changed.
8839 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8841 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8843 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8845 * xsettings.c (SYSTEM_FONT): Define only when used.
8846 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8848 * keymap.c (access_keymap_1): Now static.
8850 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8852 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8853 leave any prefix arg for the up event (Bug#1586).
8855 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8857 * lread.c (syms_of_lread): Mention single symbols defined by
8858 `defvar' or `defconst' (bug#7154).
8860 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8861 (Frequire): Mention get-load-suffixes.
8863 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8865 * window.h (window): Remove clone_number slot.
8866 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8868 (make_parent_window, make_window, saved_window)
8869 (Fset_window_configuration, save_window_save): Don't deal with
8871 * buffer.c (Qclone_number): Remove declaration.
8872 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8874 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8876 Add multiple inheritance to keymaps.
8877 * keymap.c (Fmake_composed_keymap): New function.
8878 (Fset_keymap_parent): Simplify.
8879 (fix_submap_inheritance): Remove.
8880 (access_keymap_1): New function extracted from access_keymap to handle
8881 embedded parents and handle lists of maps.
8882 (access_keymap): Use it.
8883 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8884 (Fcopy_keymap): Handle embedded parents.
8885 (Fcommand_remapping, define_as_prefix): Simplify.
8886 (Fkey_binding): Simplify.
8887 (syms_of_keymap): Move minibuffer-local-completion-map,
8888 minibuffer-local-filename-completion-map,
8889 minibuffer-local-must-match-map, and
8890 minibuffer-local-filename-must-match-map to Elisp.
8891 (syms_of_keymap): Defsubr make-composed-keymap.
8892 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8893 (parse_menu_item): Trivial simplification.
8895 2011-07-01 Glenn Morris <rgm@gnu.org>
8897 * Makefile.in (SETTINGS_LIBS): Fix typo.
8899 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8901 * coding.c (Fencode_coding_string): Record the last coding system
8902 used, as the function doc string says (bug#8738).
8904 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8906 * xsettings.c (store_monospaced_changed): Take new font as arg and
8907 check for change against current_mono_font.
8908 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8909 (emacs_settings_constructor, emacs_settings_get_property)
8910 (emacs_settings_set_property, emacs_settings_class_init)
8911 (emacs_settings_init, gsettings_obj): Remove.
8912 (something_changedCB): New function for HAVE_GSETTINGS.
8913 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8914 with value as argument.
8915 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8916 g_settings_new (Bug#8967). Do not create gsettings_obj.
8917 Remove calls to g_settings_bind. Connect something_changedCB to
8920 * xgselect.c: Add defined (HAVE_GSETTINGS).
8921 (xgselect_initialize): Ditto.
8923 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8924 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8927 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8929 * eval.c (struct backtrace): Simplify and port the data structure.
8930 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8931 signed bit field, as this assumption is not portable and it makes
8932 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8933 "char debug_on_exit : 1" as this is not portable either; instead,
8934 use the portable "unsigned int debug_on_exit : 1". Remove unused
8935 member evalargs. Remove obsolete comments about cc bombing out.
8937 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8939 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8940 Let HAVE_GSETTINGS override HAVE_GCONF.
8941 (store_monospaced_changed): New function.
8942 (EMACS_SETTINGS): A new type derived from GObject to handle
8943 GSettings notifications.
8944 (emacs_settings_constructor, emacs_settings_get_property)
8945 (emacs_settings_set_property, emacs_settings_class_init):
8947 (gsettings_client, gsettings_obj): New variables.
8948 (GSETTINGS_SCHEMA): New define.
8949 (something_changedCB): Call store_monospaced_changed.
8950 (init_gsettings): New function.
8951 (xsettings_initialize): Call init_gsettings.
8952 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8955 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8958 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8960 * window.c (resize_root_window, grow_mini_window)
8961 (shrink_mini_window): Rename Qresize_root_window to
8962 Qwindow_resize_root_window and Qresize_root_window_vertically to
8963 Qwindow_resize_root_window_vertically.
8965 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8967 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8969 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8971 * makefile.w32-in: Redesign dependencies so they reflect more
8972 clearly which files are directly included by each source file,
8973 and not through other includes.
8975 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8977 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8978 (sort_overlays, overlay_strings): When an overlay's clone number
8979 matches the window's clone number process the overlay even if
8980 the overlay's window property doesn't match the current window.
8982 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8983 (Fwindow_hchild): Rename to Fwindow_left_child.
8984 (Fwindow_next): Rename to Fwindow_next_sibling.
8985 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8986 (resize_window_check): Rename to window_resize_check.
8987 (resize_window_apply): Rename to window_resize_apply.
8988 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8989 (Fdelete_other_windows_internal, resize_frame_windows)
8990 (Fsplit_window_internal, Fdelete_window_internal)
8991 (grow_mini_window, shrink_mini_window)
8992 (Fresize_mini_window_internal): Fix callers accordingly.
8994 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8996 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8997 (emacs_fixed_set_min_size): Remove.
8998 (emacs_fixed_new): Take frame as argument.
9000 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9001 (_EmacsFixedPrivate): Remove minwidth/height.
9002 Add struct frame *f.
9003 (emacs_fixed_init): Initialize priv->f.
9004 (get_parent_class, emacs_fixed_set_min_size): Remove.
9005 (emacs_fixed_new): Set priv->f to argument.
9006 (emacs_fixed_get_preferred_width)
9007 (emacs_fixed_get_preferred_height): Use min_width/height from
9008 frames size_hint to set minimum and natural (Bug#8919).
9009 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9010 and use min_width/height from frames size_hint to set
9011 min_width/height (Bug#8919).
9013 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9014 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9017 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9019 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9020 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9023 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9025 * process.c (wait_reading_process_output): Bypass select if
9026 waiting for a cell while ignoring keyboard input, and input is
9027 pending. Suggested by Jan Djärv (Bug#8869).
9029 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9031 Use gnulib's dup2 module instead of rolling our own.
9032 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9034 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9036 * dispnew.c (scrolling_window): Before scrolling, turn off a
9037 mouse-highlight in the window being scrolled.
9039 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9041 Move DEFSYM to lisp.h and use everywhere.
9043 * character.h (DEFSYM): Move declaration...
9044 * lisp.h (DEFSYM): ...here.
9050 * w32select.c: Don't include character.h.
9052 * alloc.c (syms_of_alloc):
9053 * buffer.c (syms_of_buffer):
9054 * bytecode.c (syms_of_bytecode):
9055 * callint.c (syms_of_callint):
9056 * casefiddle.c (syms_of_casefiddle):
9057 * casetab.c (init_casetab_once):
9058 * category.c (init_category_once, syms_of_category):
9059 * ccl.c (syms_of_ccl):
9060 * cmds.c (syms_of_cmds):
9061 * composite.c (syms_of_composite):
9062 * dbusbind.c (syms_of_dbusbind):
9063 * dired.c (syms_of_dired):
9064 * dispnew.c (syms_of_display):
9065 * doc.c (syms_of_doc):
9066 * editfns.c (syms_of_editfns):
9067 * emacs.c (syms_of_emacs):
9068 * eval.c (syms_of_eval):
9069 * fileio.c (syms_of_fileio):
9070 * fns.c (syms_of_fns):
9071 * frame.c (syms_of_frame):
9072 * fringe.c (syms_of_fringe):
9073 * insdel.c (syms_of_insdel):
9074 * keymap.c (syms_of_keymap):
9075 * lread.c (init_obarray, syms_of_lread):
9076 * macros.c (syms_of_macros):
9077 * msdos.c (syms_of_msdos):
9078 * print.c (syms_of_print):
9079 * process.c (syms_of_process):
9080 * search.c (syms_of_search):
9081 * sound.c (syms_of_sound):
9082 * syntax.c (init_syntax_once, syms_of_syntax):
9083 * terminal.c (syms_of_terminal):
9084 * textprop.c (syms_of_textprop):
9085 * undo.c (syms_of_undo):
9086 * w32.c (globals_of_w32):
9087 * window.c (syms_of_window):
9088 * xdisp.c (syms_of_xdisp):
9089 * xfaces.c (syms_of_xfaces):
9090 * xfns.c (syms_of_xfns):
9091 * xmenu.c (syms_of_xmenu):
9092 * xsettings.c (syms_of_xsettings):
9093 * xterm.c (syms_of_xterm): Use DEFSYM.
9095 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9097 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9099 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9101 Integer and buffer overflow fixes (Bug#8873).
9103 * print.c (printchar, strout): Check for string overflow.
9104 (PRINTPREPARE, printchar, strout):
9105 Don't set size unless allocation succeeds.
9107 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9108 for sizes. Check for string overflow more accurately.
9109 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9111 * macros.c: Integer and buffer overflow fixes.
9112 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9113 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9114 Use ptrdiff_t, not int, for sizes.
9115 Don't increment bufsize until after realloc succeeds.
9116 Check for size-calculation overflow.
9117 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9119 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9121 * lread.c: Integer overflow fixes.
9122 (read_integer): Radix is now EMACS_INT, not int,
9123 to improve quality of diagnostics for out-of-range radices.
9124 Calculate buffer size correctly for out-of-range radices.
9125 (read1): Check for integer overflow in radices, and in
9126 read-circle numbers.
9127 (read_escape): Avoid int overflow.
9128 (Fload, openp, read_buffer_size, read1)
9129 (substitute_object_recurse, read_vector, read_list, map_obarray):
9130 Use ptrdiff_t, not int, for sizes.
9131 (read1): Use EMACS_INT, not int, for sizes.
9132 Check for size overflow.
9134 * image.c (cache_image): Check for size arithmetic overflow.
9136 * lread.c: Integer overflow issues.
9137 (saved_doc_string_size, saved_doc_string_length)
9138 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9139 Now ptrdiff_t, not int.
9140 (read1): Don't assume doc string length fits in int. Check for
9141 out-of-range doc string lengths.
9142 (read_list): Don't assume file position fits in int.
9143 (read_escape): Check for hex character overflow.
9145 2011-06-22 Leo Liu <sdl.web@gmail.com>
9147 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9148 Move to minibuffer.el.
9150 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9152 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9153 The following patches are for when GLYPH_DEBUG && !XASSERT.
9154 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9155 * dispnew.c (flush_stdout):
9156 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9157 Mark as externally visible.
9158 * dispnew.c (check_window_matrix_pointers): Now static.
9159 * dispnew.c (window_to_frame_vpos):
9160 * xfns.c (unwind_create_frame):
9161 * xterm.c (x_check_font): Remove unused local.
9162 * scroll.c (CHECK_BOUNDS):
9163 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9164 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9165 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9166 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9167 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9169 (debug_method_add): Use va_list and vsprintf rather than relying
9170 on undefined behavior with wrong number of arguments.
9171 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9172 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9173 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9174 since we're not interested in debugging glyphs with old libraries.
9175 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9176 GCC 4.6.0's static checking.
9178 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9180 Integer overflow and signedness fixes (Bug#8873).
9181 A few related buffer overrun fixes, too.
9183 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9185 * dispextern.h (struct face.stipple):
9186 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9187 (x_bitmap_mask, x_allocate_bitmap_record)
9188 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9189 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9190 (x_create_bitmap_from_xpm_data):
9191 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9192 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9194 * xfaces.c (load_pixmap):
9195 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9196 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9197 (.bitmaps_last, struct x_output.icon_bitmap):
9198 Use ptrdiff_t, not int, for bitmap indexes.
9199 (x_allocate_bitmap_record): Check for size overflow.
9200 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9202 Use ptrdiff_t, not int, for overlay counts.
9203 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9204 * editfns.c (overlays_around, get_pos_property):
9205 * textprop.c (get_char_property_and_overlay):
9206 * xdisp.c (next_overlay_change, note_mouse_highlight):
9207 * xfaces.c (face_at_buffer_position):
9208 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9209 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9210 (Fnext_overlay_change, Fprevious_overlay_change)
9211 (mouse_face_overlay_overlaps, Foverlays_in):
9212 Use ptrdiff_t, not int, for sizes.
9213 (overlays_at, overlays_in): Check for size-calculation overflow.
9215 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9217 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9218 (x_session_initialize): Do not assume string length fits in int.
9220 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9221 This is unlikely, but can occur if DPI is outlandish.
9223 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9224 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9226 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9227 * xrdb.c (magic_file_p, search_magic_path):
9228 Omit last arg SUFFIX; it was always 0. All callers changed.
9229 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9231 * xfont.c (xfont_match): Avoid need for strlen.
9233 * xfns.c: Don't assume strlen fits in int.
9234 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9236 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9237 not unsigned long, as we prefer signed integers. All callers changed.
9238 Detect integer overflow in repeat count.
9239 (message_dolog): Don't assume print length fits in 39 bytes.
9240 (display_mode_element): Don't assume strlen fits in int.
9242 * termcap.c: Don't assume sizes fit in int and never overflow.
9243 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9244 (gobble_line): Check for size-calculation overflow.
9246 * minibuf.c (Fread_buffer):
9247 * lread.c (intern, intern_c_string):
9248 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9249 Don't assume string length fits in int.
9251 * keyboard.c (parse_tool_bar_item):
9252 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9254 * font.c: Don't assume string length fits in int.
9255 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9256 Use ptrdiff_t, not int.
9257 (font_intern_prop): Don't assume string length fits in int.
9258 Don't assume integer property fits in fixnum.
9259 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9261 * filelock.c: Fix some buffer overrun and integer overflow issues.
9262 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9263 Reformulate so as not to need the command string.
9264 Invoke gzip -cd rather than gunzip, as it's more portable.
9265 (lock_info_type, lock_file_1, lock_file):
9266 Don't assume pid_t and time_t fit in unsigned long.
9267 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9268 (current_lock_owner): Prefer signed type for sizes.
9269 Use memcpy, not strncpy, where memcpy is what is really wanted.
9270 Don't assume (via atoi) that time_t and pid_t fit in int.
9271 Check for time_t and/or pid_t out of range, e.g., via a network share.
9272 Don't alloca where an auto var works fine.
9274 * fileio.c: Fix some integer overflow issues.
9275 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9276 Don't assume string length fits in int.
9277 (directory_file_name): Don't assume string length fits in long.
9278 (make_temp_name): Don't assume pid fits in int, or that its print
9279 length is less than 20.
9281 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9283 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9285 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9287 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9288 We prefer signed integers, even for size calculations.
9290 * emacs.c: Don't assume string length fits in 'int'.
9291 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9292 (main): Don't invoke strlen when not needed.
9294 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9295 (XD_DEBUG_MESSAGE): Don't waste a byte.
9297 * callproc.c (getenv_internal_1, getenv_internal)
9299 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9301 * lread.c (invalid_syntax): Omit length argument.
9302 All uses changed. This doesn't fix a bug, but it simplifies the
9303 code away from its former Hollerith-constant appearance, and it's
9304 one less 'int' to worry about when looking at integer-overflow issues.
9305 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9307 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9308 This didn't break anything, but it didn't help either.
9309 It's confusing to put a bogus integer in a place where the actual
9310 value does not matter.
9311 (LIST_END_P): Remove unused macro and its bogus comment.
9312 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9314 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9315 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9317 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9318 We prefer signed types, and the value cannot exceed the EMACS_INT
9319 range anyway (because otherwise the length would not be representable).
9320 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9321 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9322 This avoids a GCC warning when WIDE_EMACS_INT.
9324 * indent.c (sane_tab_width): New function.
9325 (current_column, scan_for_column, Findent_to, position_indentation)
9326 (compute_motion): Use it. This is just for clarity.
9327 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9329 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9331 * lisp.h (lint_assume): New macro.
9332 * composite.c (composition_gstring_put_cache):
9333 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9335 * editfns.c, insdel.c:
9336 Omit unnecessary forward decls, to simplify future changes.
9338 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9340 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9342 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9343 Use much-faster test for byte-length change.
9344 Don't assume string byte-length fits in 'int'.
9345 Check that character arg fits in 'int'.
9346 (mapcar1): Declare byte as byte, for clarity.
9348 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9350 * fns.c (concat): Catch string overflow earlier.
9351 Do not rely on integer wraparound.
9353 * dispextern.h (struct it.overlay_strings_charpos)
9354 (struct it.selective): Now EMACS_INT, not int.
9355 * xdisp.c (forward_to_next_line_start)
9356 (back_to_previous_visible_line_start)
9357 (reseat_at_next_visible_line_start, next_element_from_buffer):
9358 Don't arbitrarily truncate the value of 'selective' to int.
9360 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9362 * composite.c: Don't truncate sizes to 'int'.
9363 (composition_gstring_p, composition_reseat_it)
9364 (composition_adjust_point): Use EMACS_INT, not int.
9365 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9366 not EMACS_UINT, for indexes.
9368 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9370 * buffer.c: Include <verify.h>.
9371 (struct sortvec.priority, struct sortstr.priority):
9372 Now EMACS_INT, not int.
9373 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9374 (struct sortstr.size, record_overlay_string)
9375 (struct sortstrlist.size, struct sortlist.used):
9376 Don't truncate size to int.
9377 (record_overlay_string): Check for size-calculation overflow.
9378 (init_buffer_once): Check at compile-time, not run-time.
9380 2011-06-22 Jim Meyering <meyering@redhat.com>
9382 Don't leak an XBM-image-sized buffer
9383 * image.c (xbm_load): Free the image buffer after using it.
9385 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9388 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9389 that Sun C diagnosed.
9390 * fns.c (secure_hash): Fix pointer signedness issue.
9391 * intervals.c (static_offset_intervals): New function.
9392 (offset_intervals): Use it.
9394 2011-06-21 Leo Liu <sdl.web@gmail.com>
9397 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9400 * fns.c (secure_hash): Rename from crypto_hash_function and change
9401 the first arg to accept symbols.
9402 (Fsecure_hash): New primitive.
9403 (syms_of_fns): New symbols.
9405 2011-06-20 Deniz Dogan <deniz@dogan.se>
9407 * process.c (Fset_process_buffer): Clarify return value in
9410 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9412 * dispnew.c (add_window_display_history): Use BVAR.
9414 * xdisp.c (debug_method_add): Use BVAR.
9415 (check_window_end, dump_glyph_matrix, dump_glyph)
9416 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9418 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9421 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9422 check till after the cache is created in init_frame_faces.
9424 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9426 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9428 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9430 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9431 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9432 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9434 Improve buffer-overflow checking (Bug#8873).
9435 * fileio.c (Finsert_file_contents):
9436 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9437 Remove the old (too-loose) buffer overflow checks.
9438 They weren't needed, since make_gap checks for buffer overflow.
9439 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9440 The old code merely checked for Emacs fixnum overflow, and relied
9441 on undefined (wraparound) behavior. The new code avoids undefined
9442 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9444 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9445 Tune. Don't use wider integers than needed. Don't use alloca.
9446 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9448 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9450 * insdel.c, lisp.h (buffer_overflow): New function.
9451 (insert_from_buffer_1, replace_range, replace_range_2):
9452 * insdel.c (make_gap_larger):
9453 * editfns.c (Finsert_char):
9454 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9456 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9458 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9460 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9462 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9463 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9465 * fileio.c: Don't assume EMACS_INT fits in off_t.
9466 (emacs_lseek): New static function.
9467 (Finsert_file_contents, Fwrite_region): Use it.
9468 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9470 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9472 * fns.c: Don't overflow int when computing a list length.
9473 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9474 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9475 truncation on 64-bit hosts. Check for QUIT every
9476 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9477 faster and is responsive enough.
9478 (Flength): Report an error instead of overflowing an integer.
9479 (Fsafe_length): Return a float if the value is not representable
9480 as a fixnum. This shouldn't happen except in contrived situations.
9481 (Fnthcdr, Fsort): Don't assume list length fits in int.
9482 (Fcopy_sequence): Don't assume vector length fits in int.
9484 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9485 (header_size, word_size): New constants.
9486 (allocate_vectorlike): Don't check size overflow here.
9487 (allocate_vector): Check it here instead, since this is the only
9488 caller of allocate_vectorlike that could cause overflow.
9489 Check that the new vector's length is representable as a fixnum.
9491 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9492 The previous code was bogus. For example, next_almost_prime (32)
9493 returned 39, which is undesirable as it is a multiple of 3; and
9494 next_almost_prime (24) returned 25, which is a multiple of 5 so
9495 why was the code bothering to check for multiples of 7?
9497 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9499 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9501 Variadic C functions now count arguments with ptrdiff_t.
9502 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9503 Back then I didn't know that the Emacs coding style prefers signed int.
9504 Also, in the meantime I found a few more instances where arguments
9505 were being counted with int, which may truncate counts on 64-bit
9506 machines, or EMACS_INT, which may be unnecessarily wide.
9507 * lisp.h (struct Lisp_Subr.function.aMANY)
9508 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9509 Arg counts are now ptrdiff_t, not size_t.
9510 All variadic functions and their callers changed accordingly.
9511 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9512 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9513 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9514 * callint.c (Fcall_interactively): Check arg count for overflow,
9515 to avoid potential buffer overrun. Use signed char, not 'int',
9516 for 'varies' array, so that we needn't bother to check its size
9517 calculation for overflow.
9518 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9519 * eval.c (apply_lambda):
9520 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9521 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9522 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9524 * callint.c (Fcall_interactively): Don't use index var as event count.
9526 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9527 * mem-limits.h (SIZE): Remove; no longer used.
9529 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9531 Remove unnecessary casts.
9532 * xterm.c (x_term_init):
9533 * xfns.c (x_set_border_pixel):
9534 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9535 These aren't needed now that we assume ANSI C.
9537 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9538 It's more likely to cause problems (due to unsigned overflow)
9541 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9543 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9545 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9547 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9549 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9551 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9553 GLYPH_CODE_FACE returns EMACS_INT, not int.
9554 * dispextern.h (merge_faces):
9555 * xfaces.c (merge_faces):
9556 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9557 Don't assume EMACS_INT fits in int.
9559 * character.h (CHAR_VALID_P): Remove unused parameter.
9560 * fontset.c, lisp.h, xdisp.c: All uses changed.
9562 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9564 * fns.c (concat): Minor tuning based on overflow analysis.
9565 This doesn't fix any bugs. Use int to hold character, instead
9566 of constantly refetching from Emacs object. Use XFASTINT, not
9567 XINT, for value known to be a character. Don't bother comparing
9568 a single byte to 0400, as it's always less.
9570 * floatfns.c (Fexpt):
9571 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9573 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9576 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9578 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9579 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9580 incorrectly succeed when S was a string, because 4294967386 was
9581 truncated before it was used.
9583 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9584 Otherwise, an out-of-range integer could cause undefined behavior
9587 * composite.c: Use int, not EMACS_INT, for characters.
9588 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9589 EMACS_INT, for values that are known to be in character range.
9590 This doesn't fix any bugs but is the usual style inside Emacs and
9591 may generate better code on 32-bit machines.
9593 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9594 This is for reasons similar to the recent CHAR_STRING fix.
9595 * charset.c (Fencode_char): Check that character arg is actually
9596 a character. Pass an int to ENCODE_CHAR.
9597 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9598 wider than 'int', as a compile-time check to prevent future regressions
9601 * character.c (char_string): Remove unnecessary casts.
9603 Make sure a 64-bit char is never passed to CHAR_STRING.
9604 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9605 by silently ignoring the top 32 bits, allowing some values
9606 that were far too large to be valid characters.
9607 * character.h: Include <verify.h>.
9608 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9609 arguments are no wider than unsigned, as a compile-time check
9610 to prevent future regressions in this area.
9612 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9613 (Fsubst_char_in_region):
9615 * xdisp.c (decode_mode_spec_coding):
9616 Adjust to CHAR_STRING's new requirement.
9617 * editfns.c (Finsert_char, Fsubst_char_in_region):
9618 * fns.c (concat): Check that character args are actually
9619 characters. Without this test, these functions did the wrong
9620 thing with wildly out-of-range values on 64-bit hosts.
9622 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9623 These casts should not be needed on 32-bit hosts, either.
9624 * keyboard.c (read_char):
9625 * lread.c (Fload): Remove casts to unsigned.
9627 * lisp.h (UNSIGNED_CMP): New macro.
9628 This fixes comparison bugs on 64-bit hosts.
9629 (ASCII_CHAR_P): Use it.
9630 * casefiddle.c (casify_object):
9631 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9632 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9633 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9634 * dispextern.h (FACE_FROM_ID):
9635 * keyboard.c (read_char): Use UNSIGNED_CMP.
9637 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9638 not to EMACS_INT, to avoid GCC warning.
9640 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9642 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9643 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9644 isn't needed on 32-bit machines.
9646 * buffer.c (Fgenerate_new_buffer_name):
9647 Use EMACS_INT for count, not int.
9648 (advance_to_char_boundary): Return EMACS_INT, not int.
9650 * data.c (Qcompiled_function): Now static.
9652 * window.c (window_body_lines): Now static.
9654 * image.c (gif_load): Rename local to avoid shadowing.
9656 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9657 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9658 * alloc.c (make_save_value): Integer argument is now of type
9660 (mark_object): Use ptrdiff_t, not int.
9661 * lisp.h (pD): New macro.
9662 * print.c (print_object): Use it.
9664 * alloc.c: Use EMACS_INT, not int, to count objects.
9665 (total_conses, total_markers, total_symbols, total_vector_size)
9666 (total_free_conses, total_free_markers, total_free_symbols)
9667 (total_free_floats, total_floats, total_free_intervals)
9668 (total_intervals, total_strings, total_free_strings):
9669 Now EMACS_INT, not int. All uses changed.
9670 (Fgarbage_collect): Compute overall total using a double, so that
9671 integer overflow is less likely to be a problem. Check for overflow
9672 when converting back to an integer.
9673 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9674 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9675 These were 'int' variables that could overflow on 64-bit hosts;
9676 they were never used, so remove them instead of repairing them.
9677 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9678 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9679 Previously, this ceilinged at INT_MAX, but that doesn't work on
9681 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9683 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9684 (allocate_vectorlike): Check for ptrdiff_t overflow.
9685 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9686 when a (possibly-narrower) signed value would do just as well.
9687 We prefer using signed arithmetic, to avoid comparison confusion.
9689 * alloc.c: Catch some string size overflows that we were missing.
9690 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9691 for convenience in STRING_BYTES_MAX.
9692 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9693 The definition here is exact; the one in lisp.h was approximate.
9694 (allocate_string_data): Check for string overflow. This catches
9695 some instances we weren't catching before. Also, it catches
9696 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9697 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9698 and ptrdiff_t and EMACS_INT are both 64 bits.
9700 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9701 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9702 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9704 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9706 * alloc.c (Fmake_string): Check for out-of-range init.
9708 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9710 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9712 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9714 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9715 xg_get_default_scrollbar_width.
9717 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9718 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9719 (style_changed_cb): Call update_theme_scrollbar_width and call
9720 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9721 all frames (Bug#8505).
9722 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9723 Call gtk_window_set_resizable if HAVE_GTK3.
9724 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9725 and height if HAVE_GTK3 (Bug#8505).
9726 (scroll_bar_width_for_theme): New variable.
9727 (update_theme_scrollbar_width): New function.
9728 (xg_get_default_scrollbar_width): Move code to
9729 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9730 (xg_initialize): Call update_theme_scrollbar_width.
9732 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9734 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9736 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9738 * frame.c (make_frame): Call other_buffer_safely instead of
9741 * window.c (temp_output_buffer_show): Call display_buffer with
9742 second argument Vtemp_buffer_show_specifiers and reset latter
9743 immediately after the call.
9744 (Vtemp_buffer_show_specifiers): New variable.
9745 (auto_window_vscroll_p, next_screen_context_lines)
9746 (Vscroll_preserve_screen_position): Remove leading asterisks from
9749 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9751 Fix minor problems found by GCC 4.6.0 static checking.
9752 * buffer.c (Qclone_number): Remove for now, as it's unused.
9753 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9754 (record_buffer): Remove unused local.
9755 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9756 (set_frame_buffer_list): Remove; unused.
9757 * frame.h (other_visible_frames): Remove decl.
9758 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9759 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9760 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9762 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9763 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9764 Define only if HAVE_GPM.
9765 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9766 (update_hints_inhibit): Remove; never set. All uses removed.
9767 * widgetprv.h (emacsFrameClassRec): Remove decl.
9768 * window.c (delete_deletable_window): Now returns void, since it
9769 wasn't returning anything.
9770 (compare_window_configurations): Remove unused locals.
9771 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9772 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9773 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9774 the same widths as pointers. This follows up on the 2011-05-06 patch.
9775 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9776 * xterm.h: Likewise.
9777 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9779 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9781 * makefile.w32-in: Update dependencies.
9782 (LISP_H): Add lib/intprops.h.
9784 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9786 * image.c (gif_load): Add animation frame delay to the metadata.
9787 (syms_of_image): Use DEFSYM. New symbol `delay'.
9789 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9791 * window.c (delete_deletable_window): Re-add.
9792 (Fset_window_configuration): Rewrite to handle dead buffers and
9793 consequently deletable windows.
9794 (window_tree, Fwindow_tree): Remove. Supply functionality in
9796 (compare_window_configurations): Simplify code.
9798 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9800 * image.c (imagemagick_load_image): Fix type mismatch.
9801 (Fimagemagick_types): Likewise.
9803 * window.h (replace_buffer_in_windows): Declare.
9805 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9807 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9808 Qclone_number. Remove external declaration of Qdelete_window.
9809 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9811 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9812 Run Qbuffer_list_update_hook if allowed.
9813 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9814 buffer list implementation.
9815 (other_buffer_safely): New function.
9816 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9817 calls to replace_buffer_in_windows and
9818 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9820 (record_buffer): Inhibit quitting and rewrite using quittable
9821 functions. Run Qbuffer_list_update_hook if allowed.
9822 (Frecord_buffer, Funrecord_buffer): New functions.
9823 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9824 Move switch-to-buffer to window.el.
9825 (bury-buffer): Move to window.el.
9826 (Vbuffer_list_update_hook): New variable.
9828 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9831 * window.h (resize_frame_windows): Move up in code.
9832 (Fwindow_frame): Remove EXFUN.
9833 (replace_buffer_in_all_windows): Remove prototype.
9834 (replace_buffer_in_windows_safely): Add prototype.
9836 * window.c: Declare Qdelete_window static again. Move down
9837 declaration of select_count.
9838 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9839 (Fother_window): Move to window.el.
9840 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9841 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9842 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9844 (replace_buffer_in_windows): Implement by calling
9845 Qreplace_buffer_in_windows.
9846 (replace_buffer_in_all_windows): Remove with some functionality
9847 moved into replace_buffer_in_windows_safely.
9848 (replace_buffer_in_windows_safely): New function.
9849 (select_window_norecord, select_frame_norecord): Move in front
9850 of run_window_configuration_change_hook. Remove now obsolete
9852 (Fset_window_buffer): Rewrite doc-string.
9853 Call Qrecord_window_buffer.
9854 (keys_of_window): Move binding for other-window to window.el.
9856 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9858 * dispextern.h (struct image): Replace data member, whose int_val
9859 and ptr_val fields were not used by anything, with a single
9862 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9863 (gif_clear_image, gif_load, imagemagick_load_image)
9864 (gs_clear_image, gs_load): Callers changed.
9866 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9868 * buffer.h: Include <time.h>, for time_t.
9869 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9871 Fix minor problems found by static checking.
9873 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9875 Make identifiers static if they are not used in other modules.
9876 * data.c (Qcompiled_function, Qframe, Qvector):
9877 * image.c (QimageMagick, Qsvg):
9878 * minibuf.c (Qmetadata):
9879 * window.c (resize_window_check, resize_root_window): Now static.
9880 * window.h (resize_window_check, resize_root_window): Remove decls.
9882 * window.c (window_deletion_count, delete_deletable_window):
9884 (window_body_lines): Now static.
9885 (Fdelete_other_windows_internal): Mark vars as initialized.
9886 Make sure 'resize_failed' is initialized.
9887 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9888 (resize_window_apply): Remove unused local.
9889 * window.h (delete_deletable_window): Remove decl.
9891 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9892 (imagemagick_load_image): Fix pointer signedness problem by changing
9893 last arg from unsigned char * to char *. All uses changed.
9894 Also, fix a local for similar reasons.
9895 Remove unused locals. Remove locals to avoid shadowing.
9896 (fn_rsvg_handle_free): Remove; unused.
9897 (svg_load, svg_load_image): Fix pointer signedness problem.
9898 (imagemagick_load_image): Don't use garbage pointer image_wand.
9900 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9902 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9904 * image.c (gif_load): Fix omitted cast error introduced by
9907 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9909 * window.h (resize_proportionally, orig_total_lines)
9910 (orig_top_line): Remove from window structure.
9911 (set_window_height, set_window_width, change_window_heights)
9912 (Fdelete_window): Remove prototypes.
9913 (resize_frame_windows): Remove duplicate declaration.
9915 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9917 * window.h (resize_frame_windows, resize_window_check)
9918 (delete_deletable_window, resize_root_window)
9919 (resize_frame_windows): Declare prototypes.
9921 * window.c (resize_window_apply): Make definition be "static" to
9922 match the prototype.
9924 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9926 * window.c: Remove declarations of Qwindow_size_fixed,
9927 window_min_size_1, window_min_size_2, window_min_size,
9928 size_window, window_fixed_size_p, enlarge_window, delete_window.
9929 Remove static from declaration of Qdelete_window, it's
9930 temporarily needed by Fbury_buffer.
9931 (replace_window): Don't assign orig_top_line and
9933 (Fdelete_window, delete_window): Remove. Window deletion is
9934 handled by window.el.
9935 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9936 Replace Fdelete_window calls with calls to Qdelete_window.
9937 (Fdelete_other_windows): Remove. Deleting other windows is
9938 handled by window.el.
9939 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9940 handled in window.el.
9941 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9942 Window minimum sizes are handled in window.el.
9943 (shrink_windows, size_window, set_window_height)
9944 (set_window_width, change_window_heights, window_height)
9945 (window_width, CURBEG, CURSIZE, enlarge_window)
9946 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9947 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9948 handled in window.el.
9949 (make_dummy_parent): Rename to make_parent_window and give it a
9950 second argument horflag.
9951 (make_window): Don't set resize_proportionally any more.
9952 (Fsplit_window): Remove. Windows are split in window.el.
9953 (save_restore_action, save_restore_orig_size)
9954 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9955 Resize mini windows in window.el.
9956 (grow_mini_window, shrink_mini_window): Implement by calling
9957 Qresize_root_window_vertically, resize_window_check and
9958 resize_window_apply.
9959 (saved_window, Fset_window_configuration, save_window_save):
9960 Do not handle orig_top_line, orig_total_lines, and
9961 resize_proportionally.
9962 (window_min_height, window_min_width): Move to window.el.
9963 (keys_of_window): Move bindings for delete-other-windows,
9964 split-window, delete-window and enlarge-window to window.el.
9966 * buffer.c: Temporarily extern Qdelete_window.
9967 (Fbury_buffer): Temporarily call Qdelete_window instead of
9968 Fdelete_window (Fbury_buffer will move to window.el soon).
9970 * frame.c (set_menu_bar_lines_1): Remove code handling
9971 orig_top_line and orig_total_lines.
9973 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9974 set_window_height but set heights directly.
9975 (change_frame_size_1): Use resize_frame_windows.
9977 * xdisp.c (init_xdisp): Don't use set_window_height but set
9980 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9981 Use resize_frame_windows instead of change_window_heights and run
9982 run_window_configuration_change_hook.
9984 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9985 instead of change_window_heights and run
9986 run_window_configuration_change_hook.
9988 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9990 * window.c (replace_window): Rename second argument REPLACEMENT to
9991 NEW. New third argument SETFLAG. Rewrite.
9992 (delete_window, make_dummy_parent): Call replace_window with
9994 (window_list_1): Move down in code.
9995 (run_window_configuration_change_hook): Move set_buffer part
9996 before select_frame_norecord part in order to unwind correctly.
9997 Rename count1 to count.
9998 (recombine_windows, delete_deletable_window, resize_root_window)
9999 (Fdelete_other_windows_internal)
10000 (Frun_window_configuration_change_hook, make_parent_window)
10001 (resize_window_check, resize_window_apply, Fresize_window_apply)
10002 (resize_frame_windows, Fsplit_window_internal)
10003 (Fdelete_window_internal, Fresize_mini_window_internal):
10005 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10007 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10009 * window.h (window): Add some new members to window structure -
10010 normal_lines, normal_cols, new_total, new_normal, clone_number,
10011 splits, nest, prev_buffers, next_buffers.
10012 (WINDOW_TOTAL_SIZE): Move here from window.c.
10013 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10015 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10017 (make_dummy_parent): Set new members of windows structure.
10018 (make_window): Move down in code. Handle new members of window
10020 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10021 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10022 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10023 (Fset_window_prev_buffers, Fwindow_next_buffers)
10024 (Fset_window_next_buffers, Fset_window_clone_number):
10026 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10027 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10029 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10030 Argument WINDOW can be now internal window too.
10031 (Fwindow_use_time): Move up in code.
10032 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10033 Rewrite doc-string.
10034 (Fset_window_configuration, saved_window)
10035 (Fcurrent_window_configuration, save_window_save): Handle new
10036 members of window structure.
10037 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10038 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10039 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10040 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10041 Qget_mru_window, Qresize_root_window,
10042 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10043 Qauto_buffer_name; staticpro them.
10045 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10047 * window.c (Fwindow_total_size, Fwindow_left_column)
10048 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10049 (Fwindow_list_1): New functions.
10050 (window_box_text_cols): Replace with window_body_cols.
10051 (Fwindow_width, Fscroll_left, Fscroll_right):
10052 Use window_body_cols instead of window_box_text_cols.
10053 (delete_window, Fset_window_configuration):
10054 Call delete_all_subwindows with window as argument.
10055 (delete_all_subwindows): Take a window as argument and not a
10056 structure. Rewrite.
10057 (window_loop): Remove handling of GET_LRU_WINDOW and
10058 GET_LARGEST_WINDOW.
10059 (Fget_lru_window, Fget_largest_window): Move to window.el.
10061 * window.h: Extern window_body_cols instead of
10062 window_box_text_cols. delete_all_subwindows now takes a
10063 Lisp_Object as argument.
10065 * indent.c (compute_motion, Fcompute_motion):
10066 Use window_body_cols instead of window_box_text_cols.
10068 * frame.c (delete_frame): Call delete_all_subwindows with root
10069 window as argument.
10071 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10073 * fns.c (Fputhash): Document return value.
10075 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10077 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10079 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10081 Cons<->int and similar integer overflow fixes (Bug#8794).
10083 Check for overflow when converting integer to cons and back.
10084 * charset.c (Fdefine_charset_internal, Fdecode_char):
10085 Use cons_to_unsigned to catch overflow.
10086 (Fencode_char): Use INTEGER_TO_CONS.
10087 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10088 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10089 * data.c (long_to_cons, cons_to_long): Remove.
10090 (cons_to_unsigned, cons_to_signed): New functions.
10091 These signal an error for invalid or out-of-range values.
10092 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10093 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10094 * font.c (Ffont_variation_glyphs):
10095 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10096 * lisp.h: Include <intprops.h>.
10097 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10098 (cons_to_signed, cons_to_unsigned): New decls.
10099 (long_to_cons, cons_to_long): Remove decls.
10100 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10101 (Fprimitive_undo): Use CONS_TO_INTEGER.
10102 * xfns.c (Fx_window_property): Likewise.
10103 * xselect.c: Include <limits.h>.
10104 (x_own_selection, selection_data_to_lisp_data):
10105 Use INTEGER_TO_CONS.
10106 (x_handle_selection_request, x_handle_selection_clear)
10107 (x_get_foreign_selection, Fx_disown_selection_internal)
10108 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10109 (lisp_data_to_selection_data): Use cons_to_unsigned.
10110 (x_fill_property_data): Use cons_to_signed.
10111 Report values out of range.
10113 Check for buffer and string overflow more precisely.
10114 * buffer.h (BUF_BYTES_MAX): New macro.
10115 * lisp.h (STRING_BYTES_MAX): New macro.
10116 * alloc.c (Fmake_string):
10117 * character.c (string_escape_byte8):
10118 * coding.c (coding_alloc_by_realloc):
10119 * doprnt.c (doprnt):
10120 * editfns.c (Fformat):
10122 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10123 since they may not be the same number.
10124 * editfns.c (Finsert_char):
10125 * fileio.c (Finsert_file_contents):
10126 Likewise for BUF_BYTES_MAX.
10128 * image.c: Use ptrdiff_t, not int, for sizes.
10129 (slurp_file): Switch from int to ptrdiff_t.
10131 (slurp_file): Check that file size fits in both size_t (for
10132 malloc) and ptrdiff_t (for sanity and safety).
10134 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10135 if b->modtime has its maximal value.
10137 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10139 Don't assume time_t can fit into int.
10140 * buffer.h (struct buffer.modtime): Now time_t, not int.
10141 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10142 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10144 Minor fixes for signed vs unsigned integers.
10145 * character.h (MAYBE_UNIFY_CHAR):
10146 * charset.c (maybe_unify_char):
10147 * keyboard.c (read_char, reorder_modifiers):
10148 XINT -> XFASTINT, since the integer must be nonnegative.
10149 * ftfont.c (ftfont_spec_pattern):
10150 * keymap.c (access_keymap, silly_event_symbol_error):
10151 XUINT -> XFASTINT, since the integer must be nonnegative.
10152 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10153 since it makes no difference and we prefer signed.
10154 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10155 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10158 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10160 * window.h (Fwindow_frame): Declare.
10162 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10164 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10165 (SPARE_MEMORY): Always define.
10166 (LARGE_REQUEST): Remove.
10167 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10169 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10171 * lisp.h: Move EXFUNS for Fframe_root_window,
10172 Fframe_first_window and Fset_frame_selected_window to window.h.
10174 * window.h: Move EXFUNS for Fframe_root_window,
10175 Fframe_first_window and Fset_frame_selected_window here from
10178 * frame.c (Fwindow_frame, Fframe_first_window)
10179 (Fframe_root_window, Fframe_selected_window)
10180 (Fset_frame_selected_window): Move to window.c.
10181 (Factive_minibuffer_window): Move to minibuf.c.
10182 (Fother_visible_frames_p): New function.
10184 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10186 * window.c (decode_window, decode_any_window): Move up in code.
10187 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10188 (inhibit_frame_unsplittable): Remove unused variable.
10189 (Fwindow_buffer): Move up and rewrite doc-string.
10190 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10191 (Fwindow_prev): New functions.
10192 (Fwindow_frame): Move here from frame.c. Accept any window as
10194 (Fframe_root_window, Fframe_first_window)
10195 (Fframe_selected_window): Move here from frame.c. Accept frame
10196 or arbitrary window as argument. Update doc-strings.
10197 (Fminibuffer_window): Move up in code.
10198 (Fwindow_minibuffer_p): Move up in code and simplify.
10199 (Fset_frame_selected_window): Move here from frame.c.
10201 (Fselected_window, select_window, Fselect_window): Move up in
10202 code. Minor doc-string fixes.
10204 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10206 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10207 Do not assume that spare memory exists; that assumption is valid
10208 only if SYSTEM_MALLOC.
10209 (LARGE_REQUEST): New macro, so that the issue of large requests
10210 is separated from the issue of spare memory.
10212 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10214 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10217 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10219 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10222 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10224 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10226 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10228 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10229 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10231 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10233 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10235 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10237 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10238 (x_clipboard_manager_save): Add return value.
10239 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10240 New error handlers.
10241 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10242 Obey Vx_select_enable_clipboard_manager. Catch errors in
10243 x_clipboard_manager_save (Bug#8779).
10244 (Vx_select_enable_clipboard_manager): New variable.
10245 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10247 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10249 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10251 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10253 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10254 in the current matrix if keep_current_p is non-zero.
10256 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10258 * bidi.c (bidi_level_of_next_char): Fix last change.
10260 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10262 Support bidi reordering of text covered by display properties.
10264 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10265 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10266 (bidi_cache_search, bidi_cache_iterator_state)
10267 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10268 (bidi_level_of_next_char, bidi_move_to_visually_next):
10269 Support character positions inside a run of characters covered by a
10271 (bidi_paragraph_init, bidi_resolve_explicit_1)
10272 (bidi_level_of_next_char): Call bidi_fetch_char and
10273 bidi_fetch_char_advance instead of FETCH_CHAR and
10274 FETCH_CHAR_ADVANCE.
10275 (bidi_init_it): Initialize new members.
10276 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10278 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10279 instead of using explicit *_CHAR codes.
10280 (bidi_resolve_explicit, bidi_resolve_weak):
10281 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10282 bidirectional text is supported only in multibyte buffers.
10283 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10284 it to initialize the frame_window_p member of struct bidi_it.
10285 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10286 (bidi_resolve_explicit, bidi_resolve_weak)
10287 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10288 bidi_it->nchars is non-positive.
10289 (bidi_level_of_next_char): Don't try to lookup the cache for the
10290 next/previous character if nothing is cached there yet, or if we
10291 were just reseat()'ed to a new position.
10293 * xdisp.c (set_cursor_from_row): Set start and stop points
10294 according to the row's direction when priming the loop that looks
10295 for the glyph on which to display cursor.
10296 (single_display_spec_intangible_p): Function deleted.
10297 (display_prop_intangible_p): Reimplement to call
10298 handle_display_spec instead of single_display_spec_intangible_p.
10299 Accept 3 additional arguments needed by handle_display_spec.
10300 This fixes incorrect cursor motion across display property with complex
10301 values: lists, `(when COND...)' forms, etc.
10302 (single_display_spec_string_p): Support property values that are
10303 lists with the argument STRING its top-level element.
10304 (display_prop_string_p): Fix the condition for processing a
10305 property that is a list to be consistent with handle_display_spec.
10306 (handle_display_spec): New function, refactored from the
10307 last portion of handle_display_prop.
10308 (compute_display_string_pos): Accept additional argument
10309 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10310 value of a `display' property is a "replacing spec".
10311 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10312 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10313 the display property, but just return a value indicating whether
10314 the display property will replace the characters it covers.
10315 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10316 frame_window_p members of struct bidi_it.
10317 (compute_display_string_pos, compute_display_string_end):
10319 (push_it): Accept second argument POSITION, where pop_it should
10320 jump to continue iteration.
10321 (reseat_1): Initialize bidi_it.disp_pos.
10323 * keyboard.c (adjust_point_for_property): Adjust the call to
10324 display_prop_intangible_p to its new signature.
10326 * dispextern.h (struct bidi_it): New member frame_window_p.
10327 (bidi_init_it): Update prototypes.
10328 (display_prop_intangible_p): Update prototype.
10329 (compute_display_string_pos, compute_display_string_end):
10330 Declare prototypes.
10331 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10334 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10336 Malloc failure behavior now depends on size of allocation.
10337 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10338 * lisp.h: Change signatures accordingly.
10339 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10340 All callers changed. (Bug#8762)
10342 * gnutls.c: Use Emacs's memory allocators.
10343 Without this change, the gnutls library would invoke malloc etc.
10344 directly, which causes problems on non-SYNC_INPUT hosts, and which
10345 runs afoul of improving memory_full behavior. (Bug#8761)
10346 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10347 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10348 xfree instead of the default malloc, realloc, free.
10349 (Fgnutls_boot): No need to check for memory allocation failure,
10350 since xmalloc does that for us.
10352 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10353 * category.c (hash_get_category_set):
10354 * ccl.c (ccl_driver):
10355 * charset.c (Fdefine_charset_internal):
10356 * charset.h (struct charset.hash_index):
10357 * composite.c (get_composition_id, gstring_lookup_cache)
10358 (composition_gstring_put_cache):
10359 * composite.h (struct composition.hash_index):
10360 * dispextern.h (struct image.hash):
10361 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10362 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10363 (hashfn_equal, hashfn_user_defined, make_hash_table)
10364 (maybe_resize_hash_table, hash_lookup, hash_put)
10365 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10366 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10367 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10368 * image.c (make_image, search_image_cache, lookup_image)
10369 (xpm_put_color_table_h):
10370 * lisp.h (struct Lisp_Hash_Table):
10371 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10372 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10373 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10374 * alloc.c (allocate_vectorlike):
10375 Check for overflow in vector size calculations.
10376 * ccl.c (ccl_driver):
10377 Check for overflow when converting EMACS_INT to int.
10378 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10379 need to be updated by these changes.
10380 * fns.c (make_hash_table, maybe_resize_hash_table):
10381 Check for integer overflow with large hash tables.
10382 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10383 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10384 (SXHASH_REDUCE): New macro.
10385 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10386 Use it instead of discarding useful hash info with large hash values.
10387 (sxhash_float): New function.
10388 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10389 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10390 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10391 Rewrite to use FIXNUM_BITS, as this simplifies things.
10392 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10393 Adjust signatures to match updated version of code.
10394 (consing_since_gc): Now EMACS_INT, since a single hash table can
10395 use more than INT_MAX bytes.
10397 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10399 Make it possible to build with GCC-4.6+ -O2 -flto.
10401 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10403 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10405 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10406 Call minibuffer-inactive-mode.
10408 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10410 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10411 Update dependencies.
10413 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10415 * data.c (init_data): Remove code for UTS, this system is not
10418 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10420 Don't force ./temacs to start in terminal mode.
10422 * frame.c (make_initial_frame): Initialize faces in all cases, not
10423 only when CANNOT_DUMP is defined.
10424 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10426 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10428 * dispnew.c (add_window_display_history): Use const for the string
10429 pointer. Remove declaration, not needed.
10431 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10433 Use 'inline', not 'INLINE'.
10434 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10435 * alloc.c, fontset.c (INLINE): Remove.
10436 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10437 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10438 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10439 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10440 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10442 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10444 Make it possible to run ./temacs.
10446 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10447 syms_of_callproc does the same thing. Remove test for
10448 "initialized", do it in the caller.
10449 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10451 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10453 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10454 (read_minibuf): Use get_minibuffer.
10455 (syms_of_minibuf): Use DEFSYM.
10456 (Qmetadata): New var.
10457 * data.c (Qbuffer): Don't make it static.
10458 (syms_of_data): Use DEFSYM.
10460 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10462 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10463 (CCL_CODE_MIN): New macro.
10465 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10467 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10469 * eval.c (Qdebug): Now static.
10470 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10471 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10472 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10474 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10476 * image.c: Various fixes to ImageMagick code comments.
10477 (Fimagemagick_types): Doc fix.
10479 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10481 Minor fixes prompted by GCC 4.6.0 warnings.
10483 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10485 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10486 (x_clipboard_manager_save_all): Move extern decl to ...
10487 * xterm.h: ... here, so that it can be checked for consistency.
10489 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10491 * xselect.c (x_clipboard_manager_save_frame)
10492 (x_clipboard_manager_save_all): New functions.
10493 (Fx_clipboard_manager_save): Lisp function deleted.
10495 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10496 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10498 * xterm.h: Update prototype.
10500 2011-05-28 William Xu <william.xwl@gmail.com>
10502 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10503 exiting (Bug#8239).
10505 2011-05-28 Jim Meyering <meyering@redhat.com>
10507 Avoid a sign-extension bug in crypto_hash_function.
10508 * fns.c (to_uchar): Define.
10509 (crypto_hash_function): Use it to convert some newly-signed
10510 variables to unsigned, to avoid sign-extension bugs. For example,
10511 without this change, (md5 "truc") would evaluate to
10512 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10513 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10514 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10516 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10518 Integer overflow fixes.
10520 * dbusbind.c: Serial number integer overflow fixes.
10521 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10522 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10523 to hold a serial number that is too large for a fixnum.
10524 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10525 Check for serial numbers out of range. Decode any serial number
10526 that was so large that it became a float. (Bug#8722)
10528 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10529 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10530 Use XFASTINT rather than XUINT when numbers are nonnegative.
10531 (xd_append_arg, Fdbus_method_return_internal):
10532 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10533 arguments, check that Lisp number is nonnegative, rather than
10534 silently wrapping negative numbers around. (Bug#8722)
10535 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10538 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10540 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10542 ccl: Add integer overflow checks.
10543 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10544 (IN_INT_RANGE): New macros.
10545 (ccl_driver): Use them to check for integer overflow when
10546 decoding a CCL program. Many of the new checks are whether XINT (x)
10547 fits in int; it doesn't always, on 64-bit hosts. The new version
10548 doesn't catch all possible integer overflows, but it's an
10549 improvement. (Bug#8719)
10551 * alloc.c (make_event_array): Use XINT, not XUINT.
10552 There's no need for unsigned here.
10554 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10555 This follows up to the 2011-05-06 change that substituted uintptr_t
10556 for EMACS_INT. This case wasn't caught back then.
10558 Rework Fformat to avoid integer overflow issues.
10559 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10560 now (part of C89). Include <verify.h>.
10561 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10562 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10563 (Fformat): Avoid the prepass trying to compute sizes; it was only
10564 approximate and thus did not catch overflow reliably. Instead, walk
10565 through the format just once, formatting and computing sizes as we go,
10566 checking for integer overflow at every step, and allocating a larger
10567 buffer as needed. Keep track separately whether the format is
10568 multibyte. Keep only the most-recently calculated precision, rather
10569 than them all. Record whether each argument has been converted to
10570 string. Use EMACS_INT, not int, for byte and char and arg counts.
10571 Support field widths and precisions larger than INT_MAX. Avoid
10572 sprintf's undefined behavior with conversion specifications such as %#d
10573 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10574 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10575 formatting out-of-range floating point numbers with int
10576 formats. (Bug#8668)
10578 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10580 * data.c: Avoid integer truncation in expressions involving floats.
10581 * data.c: Include <intprops.h>.
10582 (arith_driver): When there's an integer overflow in an expression
10583 involving floating point, convert the integers to floating point
10584 so that the resulting value does not suffer from catastrophic
10585 integer truncation. For example, on a 64-bit host (* 4
10586 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10587 Do not rely on undefined behavior after integer overflow.
10589 merge count_size_as_multibyte, parse_str_to_multibyte
10590 * character.c, character.h (count_size_as_multibyte):
10591 Rename from parse_str_to_multibyte; all uses changed.
10592 Check for integer overflow.
10593 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10594 since it's now a duplicate of the other. This is more of
10595 a character than a buffer op, so better that it's in character.c.
10596 * fns.c, print.c: Adjust to above changes.
10598 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10600 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10602 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10604 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10605 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10606 (x_clipboard_manager_save): Now static.
10607 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10609 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10610 (crypto_hash_function): Now static.
10611 Fix pointer signedness problems. Avoid unnecessary initializations.
10613 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10615 * termhooks.h (Vselection_alist): Make it terminal-local.
10617 * terminal.c (create_terminal): Initialize it.
10619 * xselect.c: Support for clipboard managers.
10620 (Vselection_alist): Move to termhooks.h as terminal-local var.
10621 (LOCAL_SELECTION): New macro.
10622 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10623 (symbol_to_x_atom): Remove gratuitous arg.
10624 (x_handle_selection_request, lisp_data_to_selection_data)
10625 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10626 (x_own_selection, x_get_local_selection, x_convert_selection):
10627 New arg, specifying work frame. Use terminal-local Vselection_alist.
10628 (some_frame_on_display): Delete unused function.
10629 (Fx_own_selection_internal, Fx_get_selection_internal)
10630 (Fx_disown_selection_internal, Fx_selection_owner_p)
10631 (Fx_selection_exists_p): New optional frame arg.
10632 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10633 (x_handle_selection_clear): Don't treat other terminals with the
10634 same keyboard specially. Use the terminal-local Vselection_alist.
10635 (x_clear_frame_selections): Use Frun_hook_with_args.
10637 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10639 * xterm.h: Add support for those atoms.
10641 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10643 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10644 (converted_selections, conversion_fail_tag): New global variables.
10645 (x_selection_request_lisp_error): Free the above.
10646 (x_get_local_selection): Remove unnecessary code.
10647 (x_reply_selection_request): Args changed; handle arbitrary array
10648 of converted selections stored in converted_selections.
10649 Separate the XChangeProperty and SelectionNotify steps.
10650 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10651 (x_convert_selection): New function.
10652 (x_handle_selection_event): Simplify.
10653 (x_get_foreign_selection): Don't ignore incoming requests while
10654 waiting for an answer; this will fail when we implement
10655 SAVE_TARGETS, and seems unnecessary anyway.
10656 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10657 (Vx_sent_selection_functions): Doc fix.
10659 2011-05-26 Leo Liu <sdl.web@gmail.com>
10661 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10663 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10665 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10667 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10668 for fringe update if it has periodic bitmap.
10669 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10670 and fringe_bitmap_periodic_p.
10672 * fringe.c (get_fringe_bitmap_data): New function.
10673 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10674 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10675 row. Mark glyph row for fringe update if periodicity changed.
10677 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10678 for fringe update unless it has periodic bitmap.
10680 2011-05-25 Kenichi Handa <handa@m17n.org>
10682 * xdisp.c (get_next_display_element): Set correct it->face_id for
10683 a static composition.
10685 2011-05-24 Leo Liu <sdl.web@gmail.com>
10688 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10690 * fns.c (crypto_hash_function, Fsha1): New function.
10691 (Fmd5): Use crypto_hash_function.
10692 (syms_of_fns): Add Ssha1.
10694 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10696 * gnutls.c: Remove unused macros.
10697 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10698 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10699 Remove macros that are defined and never used.
10700 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10702 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10704 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10705 (Fx_get_selection_internal): Minor cleanup.
10706 (Fx_own_selection_internal): Rename arguments for consistency with
10709 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10711 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10713 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10715 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10717 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10719 * dispnew.c (scrolling_window): Don't exclude the case that the
10720 last enabled row in the desired matrix touches the bottom boundary.
10722 2011-05-21 Glenn Morris <rgm@gnu.org>
10724 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10725 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10726 and add some more files.
10728 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10730 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10731 report_file_error introduced by the change from 2011-05-07.
10733 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10735 * systime.h (Time): Define only if emacs is defined.
10736 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10737 where the include path doesn't have X11/X.h by default. See
10738 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10740 2011-05-20 Kenichi Handa <handa@m17n.org>
10742 * composite.c (find_automatic_composition): Fix previous change.
10744 2011-05-20 Glenn Morris <rgm@gnu.org>
10746 * lisp.mk: New file, split from Makefile.in.
10747 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10748 (shortlisp): Remove.
10749 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10751 2011-05-19 Glenn Morris <rgm@gnu.org>
10753 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10754 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10755 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10756 (lisp): Set the order to that of loadup.el.
10757 (shortlisp): Make it a copy of $lisp.
10758 (SOME_MACHINE_LISP): Remove.
10759 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10760 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10762 2011-05-18 Kenichi Handa <handa@m17n.org>
10764 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10765 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10766 (find_automatic_composition): Mostly rewrite for efficiency.
10768 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10770 * makefile.w32-in: Update dependencies.
10772 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10774 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10775 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10777 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10779 Fix some integer overflow issues, such as string length overflow.
10781 * insdel.c (count_size_as_multibyte): Check for string overflow.
10783 * character.c (lisp_string_width): Check for string overflow.
10784 Use EMACS_INT, not int, for string indexes and lengths; in
10785 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10786 the resulting string length overflows an EMACS_INT; instead,
10787 report a string overflow if no precision given. When checking for
10788 precision exhaustion, use a check that cannot possibly have
10789 integer overflow. (Bug#8675)
10790 * character.h (lisp_string_width): Adjust to new signature.
10792 * alloc.c (string_overflow): New function.
10793 (Fmake_string): Use it. This doesn't change behavior, but saves
10794 a few bytes and will simplify future changes.
10795 * character.c (string_escape_byte8): Likewise.
10796 * lisp.h (string_overflow): New decl.
10798 Fixups, following up to the user-interface timestamp change.
10799 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10800 for UI timestamps, instead of unsigned long.
10801 * msdos.c (mouse_get_pos): Likewise.
10802 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10803 * w32gui.h (Time): Define by including "systime.h" rather than by
10804 declaring it ourselves. (Bug#8664)
10806 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10807 * image.c (clear_image_cache): Likewise.
10809 * term.c (term_mouse_position): Don't assume time_t wraparound.
10811 Be more systematic about user-interface timestamps.
10812 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10813 and sometimes 'EMACS_UINT', to represent these timestamps.
10814 This change causes it to use 'Time' uniformly, as that's what X uses.
10815 This makes the code easier to follow, and makes it easier to catch
10816 integer overflow bugs such as Bug#8664.
10817 * frame.c (Fmouse_position, Fmouse_pixel_position):
10818 Use Time, not unsigned long, for user-interface timestamps.
10819 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10820 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10821 * keyboard.h (last_event_timestamp): Likewise.
10822 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10823 * menu.h (xmenu_show): Likewise.
10824 * term.c (term_mouse_position): Likewise.
10825 * termhooks.h (struct input_event.timestamp): Likewise.
10826 (struct terminal.mouse_position_hook): Likewise.
10827 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10828 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10829 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10830 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10831 what it was before.
10832 * menu.h, termhooks.h: Include "systime.h", for Time.
10834 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10835 Don't assume that the difference between two unsigned long values
10836 can fit into an integer. At this point, we know button_down_time
10837 <= event->timestamp, so the difference must be nonnegative, so
10838 there's no need to cast the result if double-click-time is
10839 nonnegative, as it should be; check that it's nonnegative, just in
10840 case. This bug is triggered when events are more than 2**31 ms
10841 apart (about 25 days). (Bug#8664)
10843 * xselect.c (last_event_timestamp): Remove duplicate decl.
10844 (x_own_selection): Remove needless cast to unsigned long.
10846 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10847 that always fit in int. Use a sentinel instead of a counter, to
10848 avoid a temp and to allay GCC's concerns about possible int overflow.
10849 * frame.h (struct frame): Use int for menu_bar_items_used
10850 instead of EMACS_INT, since it always fits in int.
10852 * menu.c (grow_menu_items): Check for int overflow.
10854 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10856 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10857 Before, the code was not consistent. These values cannot exceed
10858 2**31 - 1 so there's no need to make them unsigned.
10859 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10860 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10861 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10863 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10865 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10866 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10867 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10868 presumably because the widths might not match.
10870 * window.c (size_window): Avoid needless test at loop start.
10872 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10874 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10876 2011-05-12 Drew Adams <drew.adams@oracle.com>
10878 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10880 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10882 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10883 `width' to `bar_area_x' and `bar_area_width', respectively.
10884 (x_scroll_run): Take account of fringe background extension.
10886 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10887 Rename local vars `left' and `width' to `bar_area_x' and
10888 `bar_area_width', respectively.
10889 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10890 background extension.
10892 2011-05-10 Jim Meyering <meyering@redhat.com>
10894 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10896 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10898 * image.c (Finit_image_library): Return t for built-in image types,
10899 like pbm and xbm. (Bug#8640)
10901 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10903 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10905 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10907 * w32console.c (Fset_screen_color): Doc fix.
10908 (Fget_screen_color): New function.
10909 (syms_of_ntterm): Defsubr it.
10911 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10912 unlink the temporary file if Fcall_process didn't create it in the
10914 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10915 child process will be redirected to a file specified with `:file'.
10916 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10917 cue to call_process_cleanup not to close that handle.
10919 2011-05-07 Ben Key <bkey76@gmail.com>
10921 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10922 one of two shell specific rules, either bootstrap-temacs-CMD or
10923 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10924 to the previous implementation of the bootstrap-temacs rule.
10925 The bootstrap-temacs-CMD rule is similar to the previous
10926 implementation of the bootstrap-temacs rule except that it
10927 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10930 These changes, along with some changes to nt/configure.bat,
10931 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10932 earlier fix to add support for --cflags and --ldflags options
10933 that include quotes so that it works whether make uses cmd or
10936 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10938 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10939 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10941 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10942 a string. Handle both cases.
10943 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10944 (Fdbus_register_method): Use Qinvalid_function.
10946 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10948 * makefile.w32-in: Update dependencies.
10949 (LISP_H): Add inttypes.h and stdin.h.
10950 (PROCESS_H): Add unistd.h.
10952 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10954 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10955 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10957 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10959 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10961 * term.c (vfatal): Remove stray call to va_end.
10962 It's not needed and the C Standard doesn't allow it here anyway.
10964 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10965 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10967 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10970 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10972 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10974 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10976 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10978 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10980 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10981 * charset.c (Fdefine_charset_internal): Don't initialize
10982 charset.code_space[15]. The value was garbage, on hosts with
10983 32-bit int (Bug#8600).
10985 * lread.c (read_integer): Be more consistent with string-to-number.
10986 Use string_to_number to do the actual conversion; this avoids
10987 rounding errors and fixes some other screwups. Without this fix,
10988 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10989 (digit_to_number): Move earlier, for benefit of read_integer.
10990 Return -1 if the digit is out of range for the base, -2 if it is
10991 not a digit in any supported base. (Bug#8602)
10993 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10995 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10996 to match comment at start of function. This also removes a
10997 GCC warning about overflow in a 32+64-bit port.
10999 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11001 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11002 Reported by Stefan Monnier in
11003 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11004 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11005 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11007 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11008 (EMACS_UINTPTR): Likewise, with uintptr_t.
11010 * lisp.h: Prefer 64-bit EMACS_INT if available.
11011 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11012 on 32-bit hosts that have 64-bit int, so that they can access
11014 However, temporarily disable this change unless the temporary
11015 symbol WIDE_EMACS_INT is defined.
11017 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11019 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11020 This removes an assumption that EMACS_INT and long are the same
11021 width as pointers. The assumption is true for Emacs porting targets
11022 now, but we want to make other targets possible.
11023 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11024 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11025 In the rest of the code, change types of integers that hold casted
11026 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11027 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11028 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11029 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11030 No need to cast type when ORing.
11031 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11032 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11033 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11034 assume EMACS_INT is the same width as char *.
11035 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11036 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11037 Remove no-longer-needed casts.
11038 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11039 (xg_tool_bar_help_callback, xg_make_tool_item):
11040 Use EMACS_INTPTR to hold an integer
11041 that will be cast to void *; this can avoid a GCC warning
11042 if EMACS_INT is not the same width as void *.
11043 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11044 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11045 (current_message_1, set_message_1):
11046 Use a local to convert to proper width without a cast.
11047 * xmenu.c (dialog_selection_callback): Likewise.
11049 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11050 Also, don't assume VALBITS / RAND_BITS is less than 5,
11051 and don't rely on undefined behavior when shifting a 1 left into
11053 * lisp.h (get_random): Change signature to match.
11055 * lread.c (hash_string): Use size_t, not int, for hash computation.
11056 Normally we prefer signed values; but hashing is special, because
11057 it's better to use unsigned division on hash table sizes so that
11058 the remainder is nonnegative. Also, size_t is the natural width
11059 for hashing into memory. The previous code used 'int', which doesn't
11060 retain enough info to hash well into very large tables.
11061 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11063 * dbusbind.c: Don't possibly lose pointer info when converting.
11064 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11065 Use XPNTR rather than XHASH, so that the high-order bits of
11066 the pointer aren't lost when converting through void *.
11068 * eval.c (Fautoload): Don't double-shift a pointer.
11070 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11072 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11074 * gnutls.c (DEF_GNUTLS_FN):
11075 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11077 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11079 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11082 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11084 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11085 New version that can reserve upto 2GB of heap space.
11087 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11089 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11091 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11093 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11094 `gnutls_certificate_set_x509_key_file'.
11096 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11098 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11099 Update dependencies.
11101 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11103 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11104 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11105 Remove unused parameter `fildes'.
11106 * process.c (read_process_output, send_process): Don't pass it.
11108 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11110 Fix previous change: the library cache is defined in w32.c.
11111 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11112 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11114 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11116 Implement dynamic loading of GnuTLS on Windows.
11118 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11119 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11120 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11123 * gnutls.c (Qgnutls_dll): Define.
11124 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11125 (gnutls_*): Declare function pointers.
11126 (init_gnutls_functions): New function to initialize function pointers.
11127 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11128 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11129 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11130 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11131 (emacs_gnutls_write, emacs_gnutls_read)
11132 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11133 (Fgnutls_available_p): New function.
11134 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11135 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11136 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11138 * image.c: Include w32.h.
11139 (Vimage_type_cache): Delete.
11140 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11141 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11142 (w32_delayed_load): Move to w32.c.
11144 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11146 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11147 (w32_delayed_load): Move from image.c. When loading a library, record
11148 its filename in the :loaded-from property of the library id.
11149 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11150 Initialize and staticpro them.
11151 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11153 * process.c: Include lisp.h before w32.h, not after.
11154 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11155 instead of gnutls_record_check_pending.
11157 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11159 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11161 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11162 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11165 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11167 * xterm.c (x_set_frame_alpha): Do not set property on anything
11168 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11170 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11172 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11174 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11176 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11177 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11178 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11179 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11180 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11181 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11182 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11183 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11184 (Qgnutls_bootprop_callbacks_verify): Make static.
11186 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11188 * callproc.c: Indentation fixup.
11190 * sysdep.c (wait_for_termination_1): Make static.
11191 (wait_for_termination, interruptible_wait_for_termination):
11192 Move after wait_for_termination_1.
11194 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11196 * sysdep.c (interruptible_wait_for_termination): New function
11197 which is like wait_for_termination, but allows keyboard
11200 * callproc.c (Fcall_process): Add (:file "file") as an option for
11202 (Fcall_process_region): Ditto.
11204 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11206 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11207 rather than `XVECTOR (FOO)->size'.
11209 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11210 inttypes.h, as a gnulib replacement is used if it not available in
11213 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11215 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11216 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11217 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11219 * coding.c (coding_alloc_by_realloc): Error out if destination
11220 will grow beyond MOST_POSITIVE_FIXNUM.
11221 (decode_coding_emacs_mule): Abort if there isn't enough place in
11222 charbuf for the composition carryover bytes. Reserve an extra
11223 space for up to 2 characters produced in a loop.
11224 (decode_coding_iso_2022): Abort if there isn't enough place in
11225 charbuf for the composition carryover bytes.
11227 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11229 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11230 aborting when %lld or %lll format is passed.
11231 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11232 %llo or %llx format is passed. (Bug#8545)
11234 * window.c (window_scroll_line_based): Use a marker instead of
11235 simple variables to record original value of point. (Bug#7952)
11237 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11238 produced by %s or %c overflows available buffer space. (Bug#8545)
11240 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11242 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11243 (SIZE_MAX): Move defn after all includes, as they might #define it.
11245 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11247 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11249 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11251 * keyboard.c (Qdelayed_warnings_hook): Define.
11252 (command_loop_1): Run `delayed-warnings-hook'
11253 if Vdelayed_warnings_list is non-nil.
11254 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11255 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11257 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11259 * doprnt.c (doprnt): Don't return value smaller than the buffer
11260 size if the message was truncated. (Bug#8545).
11262 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11264 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11265 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11267 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11269 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11271 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11273 * makefile.w32-in: Update dependencies.
11275 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11277 Improve `doprnt' and its usage. (Bug#8545)
11278 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11279 `format_end'. Remove support for %l as a conversion specifier.
11280 Don't use xrealloc. Improve diagnostics when the %l size modifier
11281 is used. Update the commentary.
11283 * eval.c (verror): Simplify calculation of size_t.
11285 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11288 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11290 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11293 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11295 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11296 This makes this file independent of the recent pseudovector change.
11298 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11300 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11302 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11303 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11304 Remove unused local.
11305 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11307 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11308 GCC 4.6.0 optimizes based on type-based alias analysis.
11309 For example, if b is of type struct buffer * and v of type struct
11310 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11311 != &v->size, and therefore "v->size = 1; b->size = 2; return
11312 v->size;" must therefore return 1. This assumption is incorrect
11313 for Emacs, since it type-puns struct Lisp_Vector * with many other
11314 types. To fix this problem, this patch adds a new type struct
11315 vectorlike_header that documents the constraints on layout of vectors
11316 and pseudovectors, and helps optimizing compilers not get fooled
11317 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11318 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11319 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11321 (XSETPVECTYPE): Rewrite in terms of new macro.
11322 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11323 This is a bit clearer, and further avoids the possibility of
11324 undesirable aliasing.
11325 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11326 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11327 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11328 since Lisp_Subr is a special case (no "next" field).
11329 (ASIZE): Now uses header.size rather than size.
11330 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11331 to avoid the hassle of writing XVECTOR (foo)->header.size.
11332 (struct vectorlike_header): New type.
11333 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11334 object, to help avoid aliasing.
11335 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11336 (SUBRP): Likewise, since Lisp_Subr is a special case.
11337 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11338 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11339 (struct Lisp_Hash_Table): Combine first two members into a single
11340 struct vectorlike_header member. All uses of "size" and "next" members
11341 changed to be "header.size" and "header.next".
11342 * buffer.h (struct buffer): Likewise.
11343 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11344 * frame.h (struct frame): Likewise.
11345 * process.h (struct Lisp_Process): Likewise.
11346 * termhooks.h (struct terminal): Likewise.
11347 * window.c (struct save_window_data, struct saved_window): Likewise.
11348 * window.h (struct window): Likewise.
11349 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11350 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11351 * buffer.c (init_buffer_once): Likewise.
11352 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11354 * process.c (Fformat_network_address): Use local var for size,
11357 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11359 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11360 * data.c (atof): Remove decl; no longer used or needed.
11361 (digit_to_number): Move to lread.c.
11362 (Fstring_to_number): Use new string_to_number function, to be
11363 consistent with how the Lisp reader treats infinities and NaNs.
11364 Do not assume that floating-point numbers represent EMACS_INT
11365 without losing information; this is not true on most 64-bit hosts.
11366 Avoid double-rounding errors, by insisting on integers when
11367 parsing non-base-10 numbers, as the documentation specifies.
11368 * lisp.h (string_to_number): New decl, replacing ...
11369 (isfloat_string): Remove.
11370 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11371 (read1): Do not accept +. and -. as integers; this
11372 appears to have been a coding error. Similarly, do not accept
11373 strings like +-1e0 as floating point numbers. Do not report
11374 overflow for integer overflows unless the base is not 10 which
11375 means we have no simple and reliable way to continue.
11376 Break out the floating-point parsing into a new
11377 function string_to_number, so that Fstring_to_number parses
11378 floating point numbers consistently with the Lisp reader.
11379 (digit_to_number): Move here from data.c. Make it static inline.
11380 (E_CHAR, EXP_INT): Remove, replacing with ...
11381 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11382 (string_to_number): New function, replacing isfloat_string.
11383 This function checks for valid syntax and produces the resulting
11384 Lisp float number too. Rework it so that string-to-number
11385 no longer mishandles examples like "1.0e+". Use strtoumax,
11386 so that overflow for non-base-10 numbers is reported only when
11387 there's no portable and simple way to convert to floating point.
11389 * textprop.c (set_text_properties_1): Rewrite for clarity,
11390 and to avoid GCC warning about integer overflow.
11392 * intervals.h (struct interval): Use EMACS_INT for members
11393 where EMACS_UINT might cause problems. See
11394 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11395 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11396 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11398 (offset_intervals): Tell GCC not to worry about length overflow
11399 when negating a negative length.
11401 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11402 (overrun_check_free): Likewise.
11404 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11405 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11408 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11409 (gnutls_make_error): Rename local to avoid shadowing.
11410 (gnutls_emacs_global_deinit): ifdef out; not used.
11411 (Fgnutls_boot): Use const for pointer to readonly storage.
11412 Comment out unused local. Fix pointer signedness problems.
11414 * lread.c (openp): Don't stuff size_t into an 'int'.
11415 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11416 about possible signed overflow.
11418 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11419 (GDK_KEY_g): Don't define if already defined.
11420 (xg_prepare_tooltip): Avoid pointer signedness problem.
11421 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11423 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11424 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11426 * xfns.c (Fx_window_property): Simplify a bit,
11427 to make a bit faster and to avoid GCC 4.6.0 warning.
11428 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11430 * fns.c (internal_equal): Don't assume size_t fits in int.
11432 * alloc.c (compact_small_strings): Tighten assertion a little.
11434 Replace pEd with more-general pI, and fix some printf arg casts.
11435 * lisp.h (pI): New macro, generalizing old pEd macro to other
11436 conversion specifiers. For example, use "...%"pI"d..." rather
11437 than "...%"pEd"...".
11438 (pEd): Remove. All uses replaced with similar uses of pI.
11439 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11440 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11441 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11442 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11443 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11444 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11445 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11447 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11448 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11449 * print.c (safe_debug_print, print_object): Likewise.
11450 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11452 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11453 avoiding the 0 flag, which is not portable.
11454 * process.c (Fmake_network_process): Use pI to avoid cast.
11455 * region-cache.c (pp_cache): Likewise.
11456 * xdisp.c (decode_mode_spec): Likewise.
11457 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11458 behavior on 64-bit hosts with printf arg.
11459 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11460 (x_stop_queuing_selection_requests): Likewise.
11461 (x_get_window_property): Don't truncate byte count to an 'int'
11464 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11465 here, since it parses constructs like leading '-' and spaces,
11466 which are not wanted; and it overflows with large numbers.
11467 Instead, simply match F[0-9]+, which is what is wanted anyway.
11469 * alloc.c: Remove unportable assumptions about struct layout.
11470 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11471 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11472 (allocate_vectorlike, make_pure_vector): Use the new macros,
11473 plus offsetof, to remove unportable assumptions about struct layout.
11474 These assumptions hold on all porting targets that I know of, but
11475 they are not guaranteed, they're easy to remove, and removing them
11476 makes further changes easier.
11478 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11479 This doesn't fix a bug but makes the code clearer.
11480 (string_overrun_cookie): Now const. Use initializers that
11481 don't formally overflow signed char, to avoid warnings.
11482 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11483 can cause Emacs to crash when string overrun checking is enabled.
11484 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11485 multiple of sizeof (EMACS_INT); it need not be, if
11486 alignof(EMACS_INT) < sizeof (EMACS_INT).
11487 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11489 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11491 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11493 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11495 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11496 supposed to be handshaking. (Bug#8556)
11497 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11499 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11501 * lisp.h (Qdebug): List symbol.
11502 * eval.c (Qdebug): Restore global linkage.
11503 * keyboard.c (debug-on-event): New variable.
11504 (handle_user_signal): Break into debugger when debug-on-event
11505 matches the current signal symbol.
11507 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11509 * alloc.c (check_sblock, check_string_bytes)
11510 (check_string_free_list): Convert to standard C.
11512 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11514 * w32.c (emacs_gnutls_push): Fix typo.
11516 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11518 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11519 "cast to pointer from integer of different size".
11521 Improve doprnt and its use in verror. (Bug#8545)
11522 * doprnt.c (doprnt): Document the set of format control sequences
11523 supported by the function. Use SAFE_ALLOCA instead of always
11526 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11527 is one byte too soon. Don't use xrealloc; instead xfree and
11530 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11532 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11535 * gnutls.c: Renamed global_initialized to
11536 gnutls_global_initialized. Added internals for the
11537 :verify-hostname-error, :verify-error, and :verify-flags
11538 parameters of `gnutls-boot' and documented those parameters in the
11539 docstring. Start callback support.
11540 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11541 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11542 on error. Return error code.
11543 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11544 (emacs_gnutls_read): Likewise.
11545 (Fgnutls_boot): Return handshake error code.
11546 (emacs_gnutls_handle_error): New function.
11547 (wsaerror_to_errno): Likewise.
11549 * w32.h (emacs_gnutls_pull): Add prototype.
11550 (emacs_gnutls_push): Likewise.
11552 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11553 (emacs_gnutls_push): Likewise.
11555 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11557 * process.c (wait_reading_process_output): Check if GnuTLS
11558 buffered some data internally if no FDs are set for TLS
11561 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11562 (LIBS): Link to USER_LIBS.
11563 ($(BLD)/gnutls.$(0)): New target.
11565 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11567 * xdisp.c (handle_single_display_spec): Rename the
11568 display_replaced_before_p argument into display_replaced_p, to
11569 make it consistent with the commentary. Fix typos in the
11572 * textprop.c (syms_of_textprop): Remove dead code.
11573 (copy_text_properties): Delete obsolete commentary about an
11574 interface that was deleted long ago. Fix typos in the description
11577 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11578 to changes in oldXMenu/XMenu.h from 2011-04-16.
11579 <menu_help_message, prev_menu_help_message>: Constify.
11580 (IT_menu_make_room): menu->help_text is now `const char **';
11583 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11584 to changes in oldXMenu/XMenu.h from 2011-04-16.
11585 (struct XMenu): Declare `help_text' `const char **'.
11587 * xfaces.c <Qunspecified>: Make extern again.
11589 * syntax.c: Include sys/types.h before including regex.h, as
11592 * doc.c (get_doc_string): Improve the format passed to `error'.
11594 * doprnt.c (doprnt): Improve commentary.
11596 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11598 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11601 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11602 changes in globals.h immediately force recompilation.
11603 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11604 $(CURDIR)/s/ms-w32.h.
11605 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11607 * character.c (Fchar_direction): Function deleted.
11608 (syms_of_character): Don't defsubr it.
11609 <char-direction-table>: Deleted.
11611 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11613 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11614 * doprnt.c: Include limits.h.
11615 (SIZE_MAX): New macro.
11616 (doprnt): Return a size_t value. 2nd arg is now size_t.
11617 Many local variables are now size_t instead of int or unsigned.
11618 Improve overflow protection. Support `l' modifier for integer
11619 conversions. Support %l conversion. Don't assume an EMACS_INT
11620 argument for integer conversions and for %c.
11622 * lisp.h (doprnt): Restore prototype.
11624 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11625 $(SRC)/character.h.
11627 * Makefile.in (base_obj): Add back doprnt.o.
11629 * deps.mk (doprnt.o): Add back prerequisites.
11630 (callint.o): Depend on character.h.
11632 * eval.c (internal_lisp_condition_case): Include the handler
11633 representation in the error message.
11634 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11635 when breaking from the loop.
11637 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11639 * callint.c (Fcall_interactively): When displaying error message
11640 about invalid control letter, pass the character's codepoint, not
11641 a pointer to its multibyte form. Improve display of the character
11642 in octal and display also its hex code.
11644 * character.c (char_string): Use %x to display the (unsigned)
11645 codepoint of an invalid character, to avoid displaying a bogus
11648 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11649 `error', not SYMBOL_NAME itself.
11651 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11652 character arguments to `error'.
11654 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11655 to `error' in error message about FINAL_CHAR argument. Make sure
11656 FINAL_CHAR is a character, and use %c when it is passed as
11657 argument to `error'.
11659 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11661 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11663 * w32.c: Include <time.h>.
11664 (sys_localtime): New function.
11666 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11668 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11670 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11672 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11674 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11675 zombies (Bug#8467).
11677 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11679 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11680 gl_state.e_property when gl_state.object is Qt.
11682 * insdel.c (make_gap_larger): Remove limitation of buffer size
11685 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11687 * xdisp.c (lookup_glyphless_char_display)
11688 (produce_glyphless_glyph): Handle cons cell entry in
11689 glyphless-char-display.
11690 (Vglyphless_char_display): Document it.
11692 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11693 glyphless-char-display.
11695 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11697 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11699 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11701 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11702 definition for no-X builds.
11704 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11706 Static checks with GCC 4.6.0 and non-default toolkits.
11708 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11710 * process.c (keyboard_bit_set): Define only if SIGIO.
11711 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11712 (send_process): Repair possible setjmp clobbering.
11714 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11716 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11718 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11720 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11721 Define only if needed.
11723 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11724 by pacifying GCC about it. Maybe it's time to retire it?
11725 * xfaces.c (USG, __TIMEVAL__): Likewise.
11727 * dispextern.h (struct redisplay_interface): Rename param
11728 to avoid shadowing.
11729 * termhooks.h (struct terminal): Likewise.
11730 * xterm.c (xembed_send_message): Likewise.
11732 * insdel.c (make_gap_smaller): Define only if
11733 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11735 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11738 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11739 so that we aren't warned about unused symbols.
11741 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11743 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11745 * xfns.c (x_real_positions): Mark locals as initialized.
11747 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11749 * xterm.c: Fix problems found by static analysis with other toolkits.
11750 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11751 (x_dispatch_event): Declare static if USE_GTK, and
11752 define if USE_GTK || USE_X_TOOLKIT.
11753 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11754 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11755 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11756 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11758 * xmenu.c (menu_help_callback): Pointer type fixes.
11759 Use const pointers when pointing at readonly data. Avoid pointer
11760 signedness clashes.
11761 (FALSE): Remove unused macro.
11762 (update_frame_menubar): Remove unused decl.
11764 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11766 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11767 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11768 (single_menu_item): Rename local to avoid shadowing.
11770 * keyboard.c (make_lispy_event): Remove unused local var.
11772 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11773 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11775 * bitmaps: Change bitmaps from unsigned char back to the X11
11776 compatible char. Avoid the old compiler warnings about
11777 out-of-range initializers by using, for example, '\xab' rather
11780 * xgselect.c (xgselect_initialize): Check vs interface
11781 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11783 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11785 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11786 to read-only memory.
11788 * fns.c (vector): Remove; this old hack is no longer needed.
11790 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11792 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11794 * xrdb.c (x_load_resources): Omit unused local.
11796 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11797 (x_window): Rename locals to avoid shadowing.
11798 (USG): Use the kludged USG macro, to pacify gcc.
11800 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11801 (x_term_init): Remove local to avoid shadowing.
11803 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11805 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11806 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11808 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11810 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11812 Fix regex.c, syntax.c and friends for buffers > 2GB.
11813 * syntax.h (struct gl_state_s): Declare character position members
11816 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11818 * textprop.c (verify_interval_modification, interval_of):
11819 Declare arguments EMACS_INT.
11821 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11824 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11826 * indent.c (Fvertical_motion): Local variable it_start is now
11829 * regex.c (re_match, re_match_2, re_match_2_internal)
11830 (bcmp_translate, regcomp, regexec, print_double_string)
11831 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11832 (re_compile_pattern, re_exec): Declare arguments and local
11833 variables `size_t' and `ssize_t' and return values `regoff_t', as
11835 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11836 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11837 <compile_stack_type>: `size' and `avail' are now `size_t'.
11839 * regex.h <regoff_t>: Use ssize_t, not int.
11840 (re_search, re_search_2, re_match, re_match_2): Arguments that
11841 specify buffer/string position and length are now ssize_t and
11842 size_t. Return type is regoff_t.
11844 2011-04-16 Ben Key <bkey76@gmail.com>
11846 * nsfont.m: Fixed bugs in ns_get_family and
11847 ns_descriptor_to_entity that were caused by using free to
11848 deallocate memory blocks that were allocated by xmalloc (via
11849 xstrdup). This caused Emacs to crash when compiled with
11850 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11851 --enable-checking=xmallocoverrun). xfree is now used to
11852 deallocate these memory blocks.
11854 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11856 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11858 emacs_write: Accept and return EMACS_INT for sizes.
11859 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11861 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11862 Accept and return EMACS_INT.
11863 (emacs_gnutls_write): Return the number of bytes written on
11865 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11866 (emacs_read, emacs_write): Remove check for negative size, as the
11867 Emacs source code has been audited now.
11868 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11869 (emacs_read, emacs_write): Use it.
11870 * process.c (send_process): Adjust to the new signatures of
11871 emacs_write and emacs_gnutls_write. Do not attempt to store
11872 a byte offset into an 'int'; it might overflow.
11873 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11875 * sound.c: Don't assume sizes fit in 'int'.
11876 (struct sound_device.period_size, alsa_period_size):
11877 Return EMACS_INT, not int.
11878 (struct sound_device.write, vox_write, alsa_write):
11879 Accept EMACS_INT, not int.
11880 (wav_play, au_play): Use EMACS_INT to store sizes and to
11881 record read return values.
11883 2011-04-15 Ben Key <bkey76@gmail.com>
11885 * keyboard.c (Qundefined): Don't declare static since it is used
11887 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11888 static since they are used in nsfont.m.
11890 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11892 * process.c (Qprocessp): Don't declare static.
11893 * lisp.h (Qprocessp): Declare again.
11895 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11897 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11899 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11901 Improve C-level modularity by making more things 'static'.
11903 Don't publish debugger-only interfaces to other modules.
11904 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11905 (verify_bytepos, count_markers): Move decls to the only modules
11907 * region-cache.h (pp_cache): Likewise.
11908 * window.h (check_all_windows): Likewise.
11909 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11911 * sysdep.c (croak): Now static, if
11912 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11913 * syssignal.h (croak): Declare only if not static.
11915 * alloc.c (refill_memory_reserve): Now static if
11916 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11917 * lisp.h (refill_memory_reserve): Declare only if not static.
11919 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11920 Define only if USE_LUCID.
11922 * xrdb.c (x_customization_string, x_rm_string): Now static.
11924 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11925 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11927 * xdisp.c (draw_row_with_mouse_face): Now static.
11928 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11930 * window.h (check_all_windows): Mark externally visible.
11932 * window.c (window_deletion_count): Now static.
11934 * undo.c: Make symbols static if they're not exported.
11935 (last_undo_buffer, last_boundary_position, pending_boundary):
11938 * textprop.c (interval_insert_behind_hooks): Now static.
11939 (interval_insert_in_front_hooks): Likewise.
11941 * term.c: Make symbols static if they're not exported.
11942 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11943 (max_frame_lines, tty_set_terminal_modes):
11944 (tty_reset_terminal_modes, tty_turn_off_highlight):
11945 (get_tty_terminal): Now static.
11946 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11947 * termhooks.h (term_mouse_moveto): Do not declare if
11948 HAVE_WINDOW_SYSTEM.
11949 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11950 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11952 * sysdep.c: Make symbols static if they're not exported.
11953 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11955 (sigprocmask_set, full_mask): Remove; unused.
11956 (wait_debugging): Mark as visible.
11957 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11958 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11960 * syntax.c (syntax_temp): Define only if !__GNUC__.
11962 * sound.c (current_sound_device, current_sound): Now static.
11964 * search.c (searchbufs, searchbuf_head): Now static.
11966 * scroll.c (scroll_cost): Remove; unused.
11967 * dispextern.h (scroll_cost): Remove decl.
11969 * region-cache.h (pp_cache): Mark as externally visible.
11971 * process.c: Make symbols static if they're not exported.
11972 (process_tick, update_tick, create_process, chan_process):
11973 (Vprocess_alist, proc_buffered_char, datagram_access):
11974 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11975 (deactivate_process): Mark defn as static, as well as decl.
11976 * lisp.h (create_process): Remove decl.
11977 * process.h (chan_process, Vprocess_alist): Remove decls.
11979 * print.c: Make symbols static if they're not exported.
11980 (print_depth, new_backquote_output, being_printed, print_buffer):
11981 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11982 (print_interval, print_number_index, initial_stderr_stream):
11984 * lisp.h (Fprinc): Remove decl.
11985 (debug_output_compilation_hack): Mark as externally visible.
11987 * sysdep.c (croak): Move decl from here to syssignal.h.
11988 * syssignal.h (croak): Put it here, so the API can be checked when
11989 'croak' is called from dissociate_if_controlling_tty.
11991 * minibuf.c: Make symbols static if they're not exported.
11992 (minibuf_save_list, choose_minibuf_frame): Now static.
11993 * lisp.h (choose_minibuf_frame): Remove decl.
11995 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11997 * lread.c: Make symbols static if they're not exported.
11998 (read_objects, initial_obarray, oblookup_last_bucket_number):
12000 (make_symbol): Remove; unused.
12001 * lisp.h (initial_obarray, make_symbol): Remove decls.
12003 * keyboard.c: Make symbols static if they're not exported.
12004 (single_kboard, recent_keys_index, total_keys, recent_keys):
12005 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12006 (this_single_command_key_start, echoing, last_auto_save):
12007 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12008 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12009 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12010 (Vlispy_mouse_stem, double_click_count):
12012 (force_auto_save_soon): Define only if SIGDANGER.
12013 (ignore_mouse_drag_p): Now static if
12014 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12015 (print_help): Remove; unused.
12016 (stop_character, last_timer_event): Mark as externally visible.
12017 * keyboard.h (ignore_mouse_drag_p): Declare only if
12018 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12019 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12020 * lisp.h (echoing): Remove decl.
12021 (force_auto_save_soon): Declare only if SIGDANGER.
12022 * xdisp.c (redisplay_window): Simplify code, to make it more
12023 obvious that ignore_mouse_drag_p is not accessed if !defined
12024 USE_GTK && !defined HAVE_NS.
12026 * intervals.c: Make symbols static if they're not exported.
12027 (merge_properties_sticky, merge_interval_right, delete_interval):
12029 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12031 * insdel.c: Make symbols static if they're not exported.
12032 However, leave prepare_to_modify_buffer alone. It's never
12033 called from outside this function, but that appears to be a bug.
12034 (combine_after_change_list, combine_after_change_buffer):
12035 (adjust_after_replace, signal_before_change): Now static.
12036 (adjust_after_replace_noundo): Remove; unused.
12037 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12038 (signal_before_change): Remove decls.
12040 * indent.c (val_compute_motion, val_vmotion): Now static.
12042 * image.c: Make symbols static if they're not exported.
12043 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12045 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12046 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12048 * fringe.c (standard_bitmaps): Now static.
12049 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12051 * frame.c: Make symbols static if they're not exported.
12052 (x_report_frame_params, make_terminal_frame): Now static.
12053 (get_frame_param): Now static, unless HAVE_NS.
12054 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12055 (x_get_resource_string): Remove; not used.
12056 * frame.h (make_terminal_frame, x_report_frame_params):
12057 (x_get_resource_string); Remove decls.
12058 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12059 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12061 * font.c, fontset.c: Make symbols static if they're not exported.
12062 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12063 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12064 * font.c (font_close_object): Now static.
12065 * font.h (font_close_object): Remove.
12066 * fontset.c (FONTSET_OBJLIST): Remove.
12067 (free_realized_fontset) #if-0 the body, which does nothing.
12068 (face_suitable_for_char_p): #if-0, as it's never called.
12069 * fontset.h (face_suitable_for_char_p): Remove decl.
12070 * xfaces.c (face_at_string_position):
12071 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12072 since 0 is always ASCII.
12074 * fns.c (weak_hash_tables): Now static.
12076 * fileio.c: Make symbols static if they're not exported.
12077 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12078 (Vwrite_region_annotation_buffers): Now static.
12080 * eval.c: Make symbols static if they're not exported.
12081 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12082 * lisp.h (backtrace_list): Remove decl.
12084 * emacs.c: Make symbols static if they're not exported.
12085 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12086 (fatal_error_code, fatal_error_signal_hook, standard_args):
12088 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12089 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12090 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12091 * lisp.h (fatal_error_signal_hook): Remove decl.
12092 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12094 * editfns.c: Move a (normally-unused) function to its only use.
12095 * editfns.c, lisp.h (get_operating_system_release): Remove.
12096 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12097 worth the hassle of breaking this out.
12099 * xterm.c: Make symbols static if they're not exported.
12100 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12101 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12102 (x_destroy_window, x_delete_display):
12104 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12105 (x_mouse_leave): Remove; unused.
12106 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12107 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12108 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12110 (x_mouse_leave): Declare only if WINDOWSNT.
12111 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12112 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12115 * ftxfont.c: Make symbols static if they're not exported.
12116 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12118 * font.h (ftxfont_driver): Likewise.
12120 * xfns.c: Make symbols static if they're not exported.
12121 (x_last_font_name, x_display_info_for_name):
12122 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12123 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12124 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12125 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12126 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12127 (last_show_tip_args): Now static.
12128 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12129 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12130 (x_screen_planes): Remove; unused.
12131 * dispextern.h (x_screen_planes): Remove decl.
12133 * dispnew.c: Make symbols static if they're not exported.
12134 * dispextern.h (redraw_garbaged_frames, scrolling):
12135 (increment_row_positions): Remove.
12136 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12137 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12139 (redraw_garbaged_frames): Remove; unused.
12141 * xfaces.c: Make symbols static if they're not exported.
12142 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12144 * xterm.h (defined_color): Remove decls.
12145 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12146 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12147 (menu_face_changed_default, defined_color, free_realized_face):
12148 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12149 (ascii_face_of_lisp_face): Remove; unused.
12151 * xdisp.c: Make symbols static if they're not exported.
12152 * dispextern.h (scratch_glyph_row, window_box_edges):
12153 (glyph_to_pixel_coords, set_cursor_from_row):
12154 (get_next_display_element, set_iterator_to_next):
12155 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12156 (show_mouse_face): Remove decls
12157 * frame.h (message_buf_print): Likewise.
12158 * lisp.h (pop_message, set_message, check_point_in_composition):
12160 * xterm.h (set_vertical_scroll_bar): Likewise.
12161 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12162 (message_buf_print, scratch_glyph_row, displayed_buffer):
12163 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12164 (get_next_display_element, show_mouse_face, window_box_edges):
12165 (frame_to_window_pixel_xy, check_point_in_composition):
12166 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12167 (glyph_to_pixel_coords): Remove; unused.
12169 * dired.c (file_name_completion): Now static.
12171 * dbusbind.c (xd_in_read_queued_messages): Now static.
12173 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12174 * data.c (circular_list_error): Remove.
12176 * commands.h (last_point_position, last_point_position_buffer):
12177 (last_point_position_window): Remove decls.
12178 * keyboard.c: Make these variables static.
12180 * coding.h (coding, code_convert_region, encode_coding_gap):
12182 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12183 (iso_code_class, detect_coding, code_convert_region): Now static.
12184 (encode_coding_gap): Remove; unused.
12186 * chartab.c (chartab_chars, chartab_bits): Now static.
12188 * charset.h (charset_iso_8859_1): Remove decl.
12189 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12192 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12193 * ccl.c (Vccl_program_table): Now static.
12194 (check_ccl_update): Remove; unused.
12196 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12197 * category.h: ... from here.
12198 * category.c (check_category_table, set_category_set): Now static.
12200 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12201 * lisp.h: Remove these decls.
12203 * buffer.c (buffer_count): Remove unused var.
12205 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12206 so that it's not optimized away.
12207 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12208 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12209 exported only to the debugger.
12211 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12212 * atimer.h (run_all_atimers): Remove; not exported.
12214 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12215 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12216 was inaccessible from Lisp.
12217 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12218 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12220 alloc.c: Import and export fewer symbols, and remove unused items.
12221 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12223 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12224 it's not optimized away by whole-program optimization.
12225 (message_enable_multibyte, free_misc): Remove.
12226 (catchlist, handlerlist, mark_backtrace):
12227 Declare only if BYTE_MARK_STACK.
12228 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12229 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12230 (message_enable_multibyte): Remove decl.
12231 (free_misc, interval_free_list, float_block, float_block_index):
12232 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12233 (cons_free_list, last_marked_index):
12235 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12236 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12237 (mark_backtrace): Define only if BYTE_MARK_STACK.
12238 * xdisp.c (message_enable_multibyte): Now static.
12240 Declare Lisp_Object Q* variables to be 'static' if not exported.
12241 This makes it easier for human readers (and static analyzers)
12242 to see whether these variables are used from other modules.
12243 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12244 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12245 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12246 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12247 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12248 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12249 * xmenu.c, xselect.c:
12250 Declare Q* vars static if they are not used in other modules.
12251 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12252 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12253 Remove decls of unexported vars.
12254 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12256 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12258 Make Emacs functions such as Fatom 'static' by default.
12259 This makes it easier for human readers (and static analyzers)
12260 to see whether these functions can be called from other modules.
12261 DEFUN now defines a static function. To make the function external
12262 so that it can be used in other C modules, use the new macro DEFUE.
12263 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12264 (Finit_image_library):
12265 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12266 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12267 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12268 Remove decls, since these functions are now static.
12269 (Funintern, Fget_internal_run_time): New decls, since these functions
12270 were already external.
12272 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12273 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12274 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12275 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12276 * keyboard.c, keymap.c, lread.c:
12277 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12278 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12279 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12280 Mark functions with DEFUE instead of DEFUN,
12281 if they are used in other modules.
12282 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12283 decls for now-static functions.
12284 * buffer.h (Fdelete_overlay): Remove decl.
12285 * callproc.c (Fgetenv_internal): Mark as internal.
12286 * composite.c (Fremove_list_of_text_properties): Remove decl.
12287 (Fcomposition_get_gstring): New forward static decl.
12288 * composite.h (Fcomposite_get_gstring): Remove decl.
12289 * dired.c (Ffile_attributes): New forward static decl.
12290 * doc.c (Fdocumntation_property): New forward static decl.
12291 * eval.c (Ffetch_bytecode): New forward static decl.
12292 (Funintern): Remove extern decl; now in .h file where it belongs.
12293 * fileio.c (Fmake_symbolic_link): New forward static decl.
12294 * image.c (Finit_image_library): New forward static decl.
12295 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12296 * intervals.h (Fprevious_property_change):
12297 (Fremove_list_of_text_properties): Remove decls.
12298 * keyboard.c (Fthis_command_keys): Remove decl.
12299 (Fcommand_execute): New forward static decl.
12300 * keymap.c (Flookup_key): New forward static decl.
12301 (Fcopy_keymap): Now static.
12302 * keymap.h (Flookup_key): Remove decl.
12303 * process.c (Fget_process): New forward static decl.
12304 (Fprocess_datagram_address): Mark as internal.
12305 * syntax.c (Fsyntax_table_p): New forward static decl.
12306 (skip_chars): Remove duplicate decl.
12307 * textprop.c (Fprevious_property_change): New forward static decl.
12308 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12310 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12311 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12313 * editfns.c (Fformat): Remove unreachable code.
12315 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12317 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12320 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12322 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12323 when at ZV. (Bug#8487)
12325 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12327 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12329 * keyboard.c (parse_tool_bar_item): Likewise.
12330 * sound.c (sound_cleanup, alsa_close): Likewise.
12331 * termcap.c (tgetent): Likewise.
12332 * xfns.c (x_default_font_parameter): Likewise.
12333 * xsettings.c (read_and_apply_settings): Likewise.
12335 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12336 (overrun_check_free): Protoize.
12338 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12340 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12341 since callers should never pass a negative size.
12342 Change the signature to match that of plain 'read' and 'write'; see
12343 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12344 * lisp.h: Update prototypes of emacs_write and emacs_read.
12346 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12348 * xdisp.c (redisplay_window): Don't try to determine the character
12349 position of the scroll margin if the window start point w->startp
12350 is outside the buffer's accessible region. (Bug#8468)
12352 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12354 Fix write-region and its subroutines for buffers > 2GB.
12355 * fileio.c (a_write, e_write): Modify declaration of arguments and
12356 local variables to support buffers larger than 2GB.
12357 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12359 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12360 argument, local variables, and return value.
12362 * lisp.h: Update prototypes of emacs_write and emacs_read.
12364 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12366 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12368 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12370 Fix more problems found by GCC 4.6.0's static checks.
12372 * xdisp.c (vmessage): Use a better test for character truncation.
12374 * charset.c (load_charset_map): <, not <=, for optimization,
12375 and to avoid potential problems with integer overflow.
12376 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12377 * casetab.c (set_identity, shuffle): Likewise.
12378 * editfns.c (Fformat): Likewise.
12379 * syntax.c (skip_chars): Likewise.
12381 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12382 This also lets GCC 4.6.0 generate slightly better loop code.
12384 * callint.c (Fcall_interactively): <, not <=, for optimization.
12385 (Fcall_interactively): Count the number of arguments produced,
12386 not the number of arguments given. This is simpler and lets GCC
12387 4.6.0 generate slightly better code.
12389 * ftfont.c: Distingish more carefully between FcChar8 and char.
12390 The previous code passed unsigned char * to a functions like
12391 strlen and xstrcasecmp that expect char *, which does not
12392 conform to the C standard.
12393 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12394 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12395 char * when the C standard requires it.
12397 * keyboard.c (read_char): Remove unused var.
12399 * eval.c: Port to Windows vsnprintf (Bug#8435).
12400 Include <limits.h>.
12401 (SIZE_MAX): Define if the headers do not.
12402 (verror): Do not give up if vsnprintf returns a negative count.
12403 Instead, grow the buffer. This ports to Windows vsnprintf, which
12404 does not conform to C99. Problem reported by Eli Zaretskii.
12405 Also, simplify the allocation scheme, by avoiding the need for
12406 calling realloc, and removing the ALLOCATED variable.
12408 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12410 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12411 But keep the doprint source code for now, as we might revamp it
12412 and use it again (Bug#8435).
12413 * lisp.h (doprnt): Remove.
12414 * Makefile.in (base_obj): Remove doprnt.o.
12415 * deps.mk (doprnt.o): Remove.
12417 error: Print 32- and 64-bit integers portably (Bug#8435).
12418 Without this change, on typical 64-bit hosts error ("...%d...", N)
12419 was used to print both 32- and 64-bit integers N, which relied on
12420 undefined behavior.
12421 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12422 * lisp.h (error, verror): Mark as printf-like functions.
12423 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12424 Report overflow in size calculations when allocating printf buffer.
12425 Do not truncate output string at its first null byte.
12426 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12427 Truncate the output at a character boundary, since vsnprintf does not
12429 * charset.c (check_iso_charset_parameter): Convert internal
12430 character to string before calling 'error', since %c now has the
12432 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12433 overflow when computing char to be passed to 'error'. Do not
12434 pass Lisp_Object to 'error'; pass the integer instead.
12435 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12436 formatted with plain %d.
12438 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12440 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12442 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12444 * xterm.c (x_catch_errors): Remove duplicate declaration.
12446 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12448 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12450 2011-04-10 Jim Meyering <meyering@redhat.com>
12452 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12453 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12454 return ssize_t not "int", and use size_t as the buffer length.
12455 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12456 * gnutls.h: Update declarations.
12457 * process.c (read_process_output): Use ssize_t, to match.
12458 (send_process): Likewise.
12460 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12462 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12464 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12466 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12467 Use unsigned char, to match FcChar8 type definition.
12469 * xterm.c (handle_one_xevent):
12470 * xmenu.c (create_and_show_popup_menu):
12471 * xselect.c (x_decline_selection_request)
12472 (x_reply_selection_request): Avoid type-punned deref of X events.
12474 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12476 Fix some uses of `int' instead of EMACS_INT.
12477 * search.c (string_match_1, fast_string_match)
12478 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12479 (scan_buffer, find_next_newline_no_quit)
12480 (find_before_next_newline, search_command, Freplace_match)
12481 (Fmatch_data): Make some `int' variables be EMACS_INT.
12483 * xdisp.c (display_count_lines): 3rd argument and return value now
12484 EMACS_INT. All callers changed.
12485 (pint2hrstr): Last argument is now EMACS_INT.
12487 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12488 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12489 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12490 (decode_coding_utf_16, decode_coding_emacs_mule)
12491 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12492 (decode_coding_ccl, decode_coding_charset)
12493 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12494 (decode_coding_iso_2022, decode_coding_emacs_mule)
12495 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12496 <char_offset, last_offset>: Declare EMACS_INT.
12497 (encode_coding_utf_8, encode_coding_utf_16)
12498 (encode_coding_emacs_mule, encode_invocation_designation)
12499 (encode_designation_at_bol, encode_coding_iso_2022)
12500 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12501 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12503 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12504 (encode_invocation_designation): Last argument P_NCHARS is now
12506 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12507 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12509 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12512 * ccl.c (Fccl_execute_on_string): Declare some variables
12515 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12517 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12519 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12521 * process.c (Fformat_network_address): Doc fix.
12523 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12525 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12527 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12529 * keyboard.c (read_char): Call Lisp function help-form-show,
12530 instead of using internal_with_output_to_temp_buffer.
12531 (Qhelp_form_show): New var.
12532 (syms_of_keyboard): Use DEFSYM macro.
12534 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12536 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12538 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12540 * process.c (Flist_processes): Remove to Lisp.
12541 (list_processes_1): Delete.
12543 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12545 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12547 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12549 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12551 Fix more problems found by GCC 4.6.0's static checks.
12553 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12555 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12557 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12559 * xdisp.c (vmessage): Mark as a printf-like function.
12561 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12563 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12565 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12566 printf-like functions.
12567 (tiff_load): Add casts to remove these marks before passing them
12568 to system-supplied API.
12570 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12572 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12573 This avoids several warnings with gcc -Wstrict-overflow.
12574 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12575 directly, rather than having caller test rule sign. This avoids
12576 some unnecessary tests.
12577 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12578 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12579 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12581 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12582 (xfont_open): Avoid unnecessary tests.
12584 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12586 * composite.h, composite.c (composition_gstring_put_cache):
12587 Use EMACS_INT, not int, for length.
12589 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12590 breaking out part of COMPOSITION_DECODE_RULE.
12591 (COMPOSITION_DECODE_RULE): Use it.
12592 * composite.c (get_composition_id): Remove unused local vars,
12593 by using the new macro.
12595 * textprop.c (set_text_properties_1): Change while to do-while,
12596 since the condition is always true at first.
12598 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12599 (interval_deletion_adjustment): Return unsigned value.
12602 * process.c (list_processes_1, create_pty, read_process_output):
12603 (exec_sentinel): Remove vars that were set but not used.
12604 (create_pty): Remove unnecessary "volatile"s.
12605 (Fnetwork_interface_info): Avoid possibility of int overflow.
12606 (read_process_output): Do adaptive read buffering even if carryover.
12607 (read_process_output): Simplify nbytes computation if buffered.
12609 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12611 * syntax.c (scan_words): Remove var that was set but not used.
12612 (update_syntax_table): Use unsigned instead of int.
12614 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12615 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12616 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12618 * print.c (print_error_message): Avoid int overflow.
12620 * font.c (font_list_entities): Redo for clarity,
12621 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12623 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12624 (font_score): Avoid potential overflow in diff calculation.
12626 * fns.c (substring_both): Remove var that is set but not used.
12627 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12629 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12631 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12632 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12633 can always succeed if overflow has undefined behavior.
12635 * search.c (boyer_moore, wordify): Remove vars set but not used.
12636 (wordify): Omit three unnecessary tests.
12638 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12639 All callers changed. This avoids the need for an unused var.
12641 * casefiddle.c (casify_region): Remove var that is set but not used.
12643 * dired.c (file_name_completion): Remove var that is set but not used.
12645 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12647 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12648 (Finsert_file_contents): Remove unnecessary code checking fd.
12650 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12651 Check for integer overflow on size calculations.
12653 * buffer.c (Fprevious_overlay_change): Remove var that is set
12656 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12657 Remove vars that are set but not used.
12658 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12659 (timer_check_2): Mark vars as initialized.
12661 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12663 * image.c (lookup_image): Remove var that is set but not used.
12664 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12666 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12667 that are set but not used.
12669 * xfns.c (make_invisible_cursor): Don't return garbage
12670 if XCreateBitmapFromData fails (Bug#8410).
12672 * xselect.c (x_get_local_selection, x_handle_property_notify):
12673 Remove vars that are set but not used.
12675 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12676 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12678 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12679 Remove var that is set but not used.
12680 (scroll_bar_windows_size): Now size_t, not int.
12681 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12682 Check for overflow.
12684 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12685 (map_tty_color) [!defined MSDOS]: Likewise.
12687 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12689 * coding.c: Remove vars that are set but not used.
12690 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12691 All callers changed.
12692 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12693 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12694 (decode_coding_charset): Remove vars that are set but not used.
12696 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12697 that is set but not used.
12699 * print.c (print_object): Remove var that is set but not used.
12701 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12702 The gnulib version avoids calling malloc in the usual case,
12703 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12704 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12705 * filelock.c (current_lock_owner): Likewise.
12706 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12707 * sysdep.c: Include allocator.h, careadlinkat.h.
12708 (emacs_no_realloc_allocator): New static constant.
12709 (emacs_readlink): New function.
12710 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12711 ../lib/careadlinkat.h.
12713 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12715 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12716 first non-nil return value).
12718 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12720 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12721 if not defined (Bug#8403).
12723 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12725 * xdisp.c (display_count_lines): Remove parameter `start',
12726 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12727 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12728 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12729 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12730 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12731 and thereabouts. All callers changed.
12732 (get_per_char_metric): Remove parameter `f', unused since
12733 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12735 2011-04-02 Jim Meyering <meyering@redhat.com>
12737 do not dereference NULL upon failed strdup
12738 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12739 (ns_get_family): Likewise.
12741 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12743 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12745 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12747 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12750 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12752 Add lexical binding.
12754 * window.c (Ftemp_output_buffer_show): New fun.
12755 (Fsave_window_excursion):
12756 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12758 * lread.c (lisp_file_lexically_bound_p): New function.
12759 (Fload): Bind Qlexical_binding.
12760 (readevalloop): Remove `evalfun' arg.
12761 Bind Qinternal_interpreter_environment.
12762 (Feval_buffer): Bind Qlexical_binding.
12763 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12765 (syms_of_lread): Declare `lexical-binding'.
12767 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12769 * keyboard.c (eval_dyn): New fun.
12770 (menu_item_eval_property): Use it.
12772 * image.c (parse_image_spec): Use Ffunctionp.
12774 * fns.c (concat, mapcar1): Accept byte-code-functions.
12776 * eval.c (Fsetq): Handle lexical vars.
12777 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12778 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12779 (FletX, Flet): Obey lexical binding.
12780 (Fcommandp): Handle closures.
12781 (Feval): New `lexical' arg.
12782 (eval_sub): New function extracted from Feval. Use it almost
12783 everywhere where Feval was used. Look up vars in lexical env.
12785 (Ffunctionp): Move from subr.el.
12786 (Ffuncall): Handle closures.
12787 (apply_lambda): Remove `eval_flags'.
12788 (funcall_lambda): Handle closures and new byte-code-functions.
12789 (Fspecial_variable_p): New function.
12790 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12791 but without exporting it to Lisp.
12793 * doc.c (Fdocumentation, store_function_docstring):
12794 * data.c (Finteractive_form): Handle closures.
12796 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12799 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12801 (exec_byte_code): New function extracted from Fbyte_code to handle new
12802 calling convention for byte-code-functions. Add new byte-codes.
12804 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12806 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12808 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12810 * xdisp.c (redisplay_internal): Fix prototype.
12812 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12814 * xdisp.c (SCROLL_LIMIT): New macro.
12815 (try_scrolling): Use it when setting scroll_limit.
12816 Limit scrolling to 100 screen lines.
12817 (redisplay_window): Even when falling back on "recentering",
12818 position point in the window according to scroll-conservatively,
12819 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12821 (try_scrolling): When point is above the window, allow searching
12822 as far as scroll_max, or one screenful, to compute vertical
12823 distance from PT to the scroll margin position. This prevents
12824 try_scrolling from unnecessarily failing when
12825 scroll-conservatively is set to a value slightly larger than the
12826 window height. Clean up the case of PT below the margin at bottom
12827 of window: scroll_max can no longer be INT_MAX. When aggressive
12828 scrolling is in use, don't let point enter the opposite scroll
12829 margin as result of the scroll.
12830 (syms_of_xdisp) <scroll-conservatively>: Document the
12831 threshold of 100 lines for never-recentering scrolling.
12833 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12835 * dispextern.h (move_it_by_lines):
12836 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12837 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12838 (message_log_check_duplicate): Remove parameters `prev_bol' and
12839 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12840 (redisplay_internal): Remove parameter `preserve_echo_area',
12841 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12843 * indent.c (Fvertical_motion):
12844 * window.c (window_scroll_pixel_based, Frecenter):
12845 Don't pass `need_y_p' to `move_it_by_lines'.
12847 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12849 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12850 steal a few bits to be more compact.
12851 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12852 Remove unneeded casts.
12854 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12856 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12858 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12859 binding" message (bug#7967).
12861 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12863 Fix more problems found by GCC 4.6.0's static checks.
12865 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12866 Remove unused local var.
12868 * editfns.c (Fmessage_box): Remove unused local var.
12870 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12871 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12872 Omit unused local vars.
12873 * window.c (shrink_windows): Omit unused local var.
12874 * menu.c (digest_single_submenu): Omit unused local var.
12875 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12876 Omit unused local var.
12878 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12879 Don't assume string length fits in int.
12880 (keyremap_step, read_key_sequence): Use size_t for sizes.
12881 (read_key_sequence): Don't check last_real_key_start redundantly.
12883 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12884 instead of alloca (Bug#8344).
12886 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12887 (Fbacktrace_frame): Don't assume nframes fits in int.
12889 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12891 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12894 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12896 * cm.c (calccost): Turn while-do into do-while, for clarity.
12898 * keyboard.c (syms_of_keyboard): Use the same style as later
12899 in this function when indexing through an array. This also
12900 works around GCC bug 48267.
12902 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12904 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12906 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12907 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12909 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12910 This avoids undefined behavior on integer overflow, and is a bit
12911 more convenient anyway since it is compared to a size_t variable.
12913 Variadic C functions now count arguments with size_t, not int.
12914 This avoids an unnecessary limitation on 64-bit machines, which
12915 caused (substring ...) to crash on large vectors (Bug#8344).
12916 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12917 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12918 All variadic functions and their callers changed accordingly.
12919 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12920 * data.c (arith_driver, float_arith_driver): Likewise.
12921 * editfns.c (general_insert_function): Likewise.
12922 * eval.c (struct backtrace.nargs, interactive_p)
12923 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12924 (funcall_lambda, mark_backtrace): Likewise.
12925 * fns.c (concat): Likewise.
12926 * frame.c (x_set_frame_parameters): Likewise.
12927 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12928 0 if not found, not -1. All callers changed.
12930 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12931 (stack_copy_size): Now size_t, not int.
12932 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12934 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12936 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12937 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12938 All callers changed.
12940 * lisp.h (multibyte_char_to_unibyte):
12941 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12942 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12943 * character.h (CHAR_TO_BYTE8):
12944 * cmds.c (internal_self_insert):
12945 * editfns.c (general_insert_function):
12946 * keymap.c (push_key_description):
12947 * search.c (Freplace_match):
12948 * xdisp.c (message_dolog, set_message_1): All callers changed.
12950 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12952 * keyboard.c (safe_run_hook_funcall): New function.
12953 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12954 don't set the hook to nil, but remove the offending function instead.
12955 (Qcommand_hook_internal): Remove, unused.
12956 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12957 Vcommand_hook_internal.
12959 * eval.c (enum run_hooks_condition): Remove.
12960 (funcall_nil, funcall_not): New functions.
12961 (run_hook_with_args): Call each function through a `funcall' argument.
12962 Remove `cond' argument, now redundant.
12963 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12964 (Frun_hook_with_args_until_failure): Adjust accordingly.
12965 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12967 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12969 * dispextern.h (string_buffer_position): Remove declaration.
12971 * print.c (strout): Remove parameter `multibyte', unused since
12972 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12974 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12975 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12976 All callers changed.
12978 * w32.c (_wsa_errlist): Use braces for struct initializers.
12980 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12981 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12982 All callers changed.
12983 (string_buffer_position): Likewise. Also, make static (it's never
12984 used outside xdisp.c).
12985 (cursor_row_p): Remove parameter `w', unused since
12986 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12987 (decode_mode_spec): Remove parameter `precision', introduced during
12988 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12989 All callers changed.
12991 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12993 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12995 2011-03-27 Anders Lindgren <andlind@gmail.com>
12997 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12998 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12999 (ns_update_auto_hide_menu_bar): New functions.
13000 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13001 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13002 ns_constrain_all_frames.
13003 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13004 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13006 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13008 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13010 2011-03-27 Glenn Morris <rgm@gnu.org>
13012 * syssignal.h: Replace RETSIGTYPE with void.
13013 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13014 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13015 Replace SIGTYPE with void everywhere.
13016 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13017 * s/template.h (SIGTYPE): Remove commented out definition.
13019 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13021 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13022 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13024 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13026 * w32.c (read_unc_volume): Use parameter `henum', instead of
13027 global variable `wget_enum_handle'.
13029 * keymap.c (describe_vector): Remove parameters `indices' and
13030 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13031 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13033 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13035 * keyboard.c (timer_check): Remove parameter `do_it_now',
13036 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13037 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13038 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13040 * keyboard.c (read_char):
13041 * w32menu.c (w32_menu_display_help):
13042 * xmenu.c (show_help_event, menu_help_callback):
13043 Adjust calls to `show_help_echo'.
13045 * gtkutil.c (xg_maybe_add_timer):
13046 * keyboard.c (readable_events):
13047 * process.c (wait_reading_process_output):
13048 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13050 * insdel.c (adjust_markers_gap_motion):
13051 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13052 (gap_left, gap_right): Don't call it.
13054 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13056 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13057 incurred during fontification.
13059 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13061 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13062 (DEFVAR_PER_BUFFER): Don't pass it.
13064 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13065 (scrolling_window): Don't pass it.
13067 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13069 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13071 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13073 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13074 of variables specific to SELinux and computation of `encoded_absname'.
13076 * image.c (XPutPixel): Remove unused variable `height'.
13078 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13080 * unexw32.c (get_section_info): Remove unused variable `section'.
13082 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13083 (system_process_attributes): Remove unused variable `sess'.
13084 (sys_read): Remove unused variable `err'.
13086 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13087 (w32_wnd_proc): Remove unused variable `isdead'.
13088 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13089 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13090 (x_create_tip_frame): Remove unused variable `tem'.
13092 * w32inevt.c (w32_console_read_socket):
13093 Remove unused variable `no_events'.
13095 * w32term.c (x_draw_composite_glyph_string_foreground):
13096 Remove unused variable `width'.
13098 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13100 * w32term.c (x_set_glyph_string_clipping):
13101 Don't pass uninitialized region to CombineRgn.
13103 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13105 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13106 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13107 (Fx_close_connection): Remove unused variable `i'.
13109 * w32font.c (w32font_draw): Return number of glyphs.
13110 (w32font_open_internal): Remove unused variable `i'.
13111 (w32font_driver): Add missing initializer.
13113 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13114 (fill_in_menu): Remove unused variable `items_added'.
13116 * w32term.c (last_mouse_press_frame): Remove static global variable.
13117 (w32_clip_to_row): Remove unused variable `f'.
13118 (x_delete_terminal): Remove unused variable `i'.
13120 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13121 (NOTHING): Remove unused static global variable.
13122 (uniscribe_check_otf): Remove unused variable `table'.
13123 (uniscribe_font_driver): Add missing initializers.
13125 2011-03-23 Julien Danjou <julien@danjou.info>
13127 * term.c (Fsuspend_tty, Fresume_tty):
13128 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13129 * window.c (temp_output_buffer_show):
13130 * insdel.c (signal_before_change):
13131 * frame.c (Fhandle_switch_frame):
13132 * fileio.c (Fdo_auto_save):
13133 * emacs.c (Fkill_emacs):
13134 * editfns.c (save_excursion_restore):
13135 * cmds.c (internal_self_insert):
13136 * callint.c (Fcall_interactively):
13137 * buffer.c (Fkill_all_local_variables):
13138 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13140 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13141 unconditionally since it does the check itself.
13143 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13145 Fix more problems found by GCC 4.5.2's static checks.
13147 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13148 the first time through the loop, since we know p0 < p1 then.
13149 This also avoids a gcc -Wstrict-overflow warning.
13151 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13152 leading to a memory leak, possible in functions like
13153 load_charset_map_from_file that can allocate an unbounded number
13154 of objects (Bug#8318).
13156 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13157 that could (at least in theory) be that large.
13159 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13160 This is less likely to overflow, and avoids undefined behavior if
13161 overflow does occur. All callers changed. Use strtoul to scan
13162 for the unsigned long integer.
13163 (pint2hrstr): Simplify and tune code slightly.
13164 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13166 * scroll.c (do_scrolling): Work around GCC bug 48228.
13167 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13169 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13170 This also avoids a warning with gcc -Wstrict-overflow.
13171 (validate_x_resource_name): Simplify count usage.
13172 This also avoids a warning with gcc -Wstrict-overflow.
13174 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13177 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13179 * process.c (Fmake_network_process): Use socklen_t, not int,
13180 where POSIX says socklen_t is required in portable programs.
13181 This fixes a porting bug on hosts like 64-bit HP-UX, where
13182 socklen_t is wider than int (Bug#8277).
13183 (Fmake_network_process, server_accept_connection):
13184 (wait_reading_process_output, read_process_output):
13187 * process.c: Rename or move locals to avoid shadowing.
13188 (list_processes_1, Fmake_network_process):
13189 (read_process_output_error_handler, exec_sentinel_error_handler):
13190 Rename or move locals.
13191 (Fmake_network_process): Define label "retry_connect" only if needed.
13192 (Fnetwork_interface_info): Fix pointer signedness.
13193 (process_send_signal): Add cast to avoid pointer signedness problem.
13194 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13195 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13197 Make tparam.h and terminfo.c consistent.
13198 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13199 Include tparam.h instead, since it declares them.
13200 * cm.h (PC): Remove extern decl; tparam.h now does this.
13201 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13202 * terminfo.c: Include tparam.h, to check interfaces.
13203 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13204 (tparam): Adjust signature to match interface in tparam.h;
13205 this removes some undefined behavior. Check that outstring and len
13206 are zero, which they always are with Emacs.
13207 * tparam.h (PC, BC, UP): New extern decls.
13209 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13210 (xftfont_open): Rename locals to avoid shadowing.
13212 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13213 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13214 (OTF_TAG_SYM): Omit macro if not needed.
13215 (ftfont_list): Remove unused local.
13216 (get_adstyle_property, ftfont_pattern_entity):
13217 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13218 Rename locals to avoid shadowing.
13220 * xfont.c (xfont_list_family): Mark var as initialized.
13222 * xml.c (make_dom): Now static.
13224 * composite.c (composition_compute_stop_pos): Rename local to
13226 (composition_reseat_it): Remove unused locals.
13227 (find_automatic_composition, composition_adjust_point): Likewise.
13228 (composition_update_it): Mark var as initialized.
13229 (find_automatic_composition): Mark vars as initialized,
13230 with a FIXME (Bug#8290).
13232 character.h: Rename locals to avoid shadowing.
13233 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13234 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13235 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13236 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13237 to avoid shadowing.
13239 * textprop.c (property_change_between_p): Remove; unused.
13241 * intervals.c (interval_start_pos): Now static.
13243 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13245 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13246 Rename locals to avoid shadowing.
13248 * sound.c (wav_play, au_play, Fplay_sound_internal):
13249 Fix pointer signedness.
13250 (alsa_choose_format): Remove unused local var.
13251 (wav_play): Initialize a variable to 0, to prevent undefined
13252 behavior (Bug#8278).
13254 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13256 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13258 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13259 clobbering (Bug#8298).
13260 * sysdep.c (sys_subshell): Likewise.
13261 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13263 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13264 This should get cleaned up, so that child_setup has the
13265 same signature on all platforms.
13267 * callproc.c (call_process_cleanup): Now static.
13268 (relocate_fd): Rename locals to avoid shadowing.
13270 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13272 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13273 not to be necessary, and produces flickering.
13275 2011-03-20 Glenn Morris <rgm@gnu.org>
13277 * config.in: Remove file.
13279 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13281 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13282 are now in src/globals.h.
13283 (syms_of_minibuf): Remove spurious & from previous change.
13285 2011-03-20 Leo Liu <sdl.web@gmail.com>
13287 * minibuf.c (completing-read-function): New variable.
13288 (completing-read-default): Rename from completing-read.
13289 (completing-read): Call completing-read-function.
13291 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13293 * xfaces.c (Fx_load_color_file):
13294 Read color file from absolute filename (bug#8250).
13296 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13298 * makefile.w32-in: Update dependencies.
13300 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13302 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13304 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13306 Fix more problems found by GCC 4.5.2's static checks.
13308 * process.c (make_serial_process_unwind, send_process_trap):
13309 (sigchld_handler): Now static.
13311 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13312 That way, the code declares only the vars that it needs.
13313 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13314 * s/cygwin.h (PTY_ITERATION): Likewise.
13315 * s/darwin.h (PTY_ITERATION): Likewise.
13316 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13318 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13319 * process.c (allocate_pty): Don't declare stb unless it's needed.
13321 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13322 (CONSTANTLIM): Remove; unused.
13323 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13324 Define only if needed.
13326 * unexelf.c (unexec): Name an expression,
13327 to avoid gcc -Wbad-function-cast warning.
13328 Use a different way to cause a compilation error if anyone uses
13329 n rather than nn, a way that does not involve shadowing.
13330 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13332 * deps.mk (unexalpha.o): Remove; unused.
13334 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13335 * unexec.h: New file.
13336 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13337 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13338 Depend on unexec.h.
13339 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13340 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13341 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13342 Change as necessary to match prototype in unexec.h.
13344 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13346 (back_comment, skip_chars): Mark vars as initialized.
13348 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13349 Rename locals to avoid shadowing.
13351 * lread.c (read1): Rewrite so as not to use empty "else".
13352 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13354 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13356 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13357 warning when compiling print.c.
13359 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13360 instead of using an uninitialized var.
13361 (font_sort_entities): Mark var as initialized.
13363 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13365 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13366 pointers to constants.
13367 (font_parse_fcname): Remove unused vars.
13368 (font_delete_unmatched): Now static.
13369 (font_get_spec): Remove; unused.
13370 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13371 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13372 Rename or move locals to avoid shadowing.
13374 * fns.c (require_nesting_list, require_unwind): Now static.
13375 (Ffillarray): Rename locals to avoid shadowing.
13377 * floatfns.c (domain_error2): Define only if needed.
13378 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13380 * alloc.c (mark_backtrace): Move decl from here ...
13381 * lisp.h: ... to here, so that it can be checked.
13383 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13384 (Fdefvar): Rewrite so as not to use empty "else".
13385 (lisp_indirect_variable): Name an expression,
13386 to avoid gcc -Wbad-function-cast warning.
13387 (Fdefvar): Rename locals to avoid shadowing.
13389 * callint.c (quotify_arg, quotify_args): Now static.
13390 (Fcall_interactively): Rename locals to avoid shadowing.
13391 Use const pointer when appropriate.
13393 * lisp.h (get_system_name, get_operating_system_release):
13394 Move decls here, to check interfaces.
13395 * process.c (get_operating_system_release): Move decl to lisp.h.
13396 * xrdb.c (get_system_name): Likewise.
13397 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13398 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13399 some of which prompt warnings from gcc -Wbad-function-cast.
13400 (Fformat_time_string, Fencode_time, Finsert_char):
13401 (Ftranslate_region_internal, Fformat):
13402 Rename or remove local vars to avoid shadowing.
13403 (Ftranslate_region_internal): Mark var as initialized.
13405 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13408 * lisp.h (eassert): Check that the argument compiles, even if
13409 ENABLE_CHECKING is not defined.
13411 * data.c (Findirect_variable): Name an expression, to avoid
13412 gcc -Wbad-function-cast warning.
13413 (default_value, arithcompare, arith_driver, arith_error): Now static.
13414 (store_symval_forwarding): Rename local to avoid shadowing.
13415 (Fmake_variable_buffer_local, Fmake_local_variable):
13416 Mark variables as initialized.
13417 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13419 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13420 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13421 Rename locals to avoid shadowing.
13422 (mark_stack): Move local variables into the #ifdef region where
13424 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13425 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13427 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13428 (GC_STRING_CHARS): Remove; not used.
13429 (Fmemory_limit): Cast sbrk's returned value to char *.
13431 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13432 avoids undefined behavior in theory.
13434 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13436 Use functions, not macros, for up- and down-casing (Bug#8254).
13437 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13438 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13439 to use the following functions instead of these macros.
13440 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13441 EMACS_INT, since callers assume the returned value fits in int.
13442 (upcase1): Likewise, for UPCASE_TABLE.
13443 (uppercasep, lowercasep, upcase): New static inline functions.
13444 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13445 the race-condition problem in the old DOWNCASE.
13447 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13448 Rename locals to avoid shadowing.
13449 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13450 (regex_compile, re_search_2, re_match_2_internal):
13451 Remove unused local vars.
13452 (FREE_VAR): Rewrite so as not to use empty "else",
13453 which gcc can warn about.
13454 (regex_compile, re_match_2_internal): Mark locals as initialized.
13455 (RETALLOC_IF): Define only if needed.
13456 (WORDCHAR_P): Likewise. This one is never needed, but is used
13457 only in a comment talking about a compiler bug, so put inside
13458 the #if 0 of that comment.
13459 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13460 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13463 * search.c (boyer_moore): Rename locals to avoid shadowing.
13464 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13465 (PREV_CHAR_BOUNDARY): Likewise.
13467 * search.c (simple_search): Remove unused var.
13469 * dired.c (compile_pattern): Move decl from here ...
13470 * lisp.h: ... to here, so that it can be checked.
13471 (struct re_registers): New forward decl.
13473 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13475 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13477 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13478 Rename locals to avoid shadowing.
13479 (Fvertical_motion): Mark locals as initialized.
13481 * casefiddle.c (casify_object, casify_region): Now static.
13482 (casify_region): Mark local as initialized.
13484 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13486 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13487 New macros, so that the caller can use some names other than
13488 gcpro1, gcpro2, etc.
13489 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13491 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13492 argument, for consistency with GCPRO2_VAR, etc: it is now the
13493 prefix of the variable, not the variable itself. All uses
13495 * dired.c (directory_files_internal, file_name_completion):
13496 Rename locals to avoid shadowing.
13498 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13499 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13500 dired.c's scmp function, had undefined behavior.
13501 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13502 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13503 * buffer.h: ... to here, because these macros use current_buffer,
13504 and the new implementation with inline functions needs to have
13505 current_buffer in scope now, rather than later when the macros
13507 (downcase, upcase1): New static inline functions.
13508 (DOWNCASE, UPCASE1): Reimplement using these functions.
13509 This avoids undefined behavior in expressions like
13510 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13511 from race conditions in accessing the global variables
13512 case_temp1 and case_temp2.
13513 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13514 * lisp.h (case_temp1, case_temp2): Remove their decls.
13515 * character.h (ASCII_CHAR_P): Move from here ...
13516 * lisp.h: ... to here, so that the inline functions mentioned
13517 above can use them.
13519 * dired.c (directory_files_internal_unwind): Now static.
13521 * fileio.c (file_name_as_directory, directory_file_name):
13522 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13524 (file_name_as_directory): Use const pointers when appropriate.
13525 (Fexpand_file_name): Likewise. In particular, newdir might
13526 point at constant storage, so make it a const pointer.
13527 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13528 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13530 (Fset_file_times, Finsert_file_contents, auto_save_error):
13531 Rename locals to avoid shadowing.
13533 * minibuf.c (choose_minibuf_frame_1): Now static.
13534 (Ftry_completion, Fall_completions): Rename or remove locals
13535 to avoid shadowing.
13537 * marker.c (bytepos_to_charpos): Remove; unused.
13539 * lisp.h (verify_bytepos, count_markers): New decls,
13540 so that gcc does not warn that these functions aren't declared.
13542 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13543 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13544 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13545 (copy_text): Remove unused local var.
13547 * filelock.c (within_one_second): Now static.
13548 (lock_file_1): Rename local to avoid shadowing.
13550 * buffer.c (fix_overlays_before): Mark locals as initialized.
13551 (fix_start_end_in_overlays): Likewise. This function should be
13552 simplified by using pointers-to-pointers, but that's a different
13554 (switch_to_buffer_1): Now static.
13555 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13556 (report_overlay_modification): Rename locals to avoid shadowing.
13558 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13559 Fix pointer signedness issue.
13560 (sys_subshell): Mark local as volatile if checking for lint,
13561 to suppress a gcc -Wclobbered warning that does not seem to be right.
13562 (MAXPATHLEN): Define only if needed.
13564 * process.c (serial_open, serial_configure): Move decls from here ...
13565 * systty.h: ... to here, so that they can be checked.
13567 * fns.c (get_random, seed_random): Move extern decls from here ...
13568 * lisp.h: ... to here, so that they can be checked.
13570 * sysdep.c (reset_io): Now static.
13571 (wait_for_termination_signal): Remove; unused.
13573 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13574 (copy_keymap_item, append_key, push_text_char_description):
13576 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13577 (DENSE_TABLE_SIZE): Remove; unused.
13578 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13579 (describe_map_tree):
13580 Rename locals to avoid shadowing.
13582 * keyboard.c: Declare functions static if they are not used elsewhere.
13583 (echo_char, echo_dash, cmd_error, top_level_2):
13584 (poll_for_input, handle_async_input): Now static.
13585 (read_char, kbd_buffer_get_event, make_lispy_position):
13586 (make_lispy_event, make_lispy_movement, apply_modifiers):
13587 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13588 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13589 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13590 (read_key_sequence, read_char): Mark locals as initialized.
13591 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13593 * keyboard.h (make_ctrl_char): New decl.
13594 (mark_kboards): Move decl here ...
13595 * alloc.c (mark_kboards): ... from here.
13597 * lisp.h (force_auto_save_soon): New decl.
13599 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13600 (DEFINE_DUMMY_FUNCTION): New macro.
13601 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13603 (main): Add casts to avoid warnings
13604 if GCC considers string literals to be constants.
13606 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13608 * dbusbind.c: Pointer signedness fixes.
13609 (xd_signature, xd_append_arg, xd_initialize):
13610 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13611 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13612 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13613 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13615 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13616 if GCC considers string literals to be constants.
13617 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13619 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13621 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13622 (print_preprocess, print_object): New macro to fix last change.
13624 * print.c (print_preprocess): Don't forget font objects.
13626 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13628 * emacs.c (USAGE3): Doc fixes.
13630 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13632 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13635 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13637 * lisp.h (VWindow_system, Qfile_name_history):
13638 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13639 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13640 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13642 * w32select.c: Don't #include "keyboard.h".
13643 (run_protected): Add extern declaration for waiting_for_input.
13645 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13646 * w32console.c (detect_input_pending, read_input_pending)
13647 (encode_terminal_code):
13648 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13649 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13650 (w32_system_caret_y, Qfile_name_history):
13651 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13652 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13653 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13654 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13655 * w32proc.c (Qlocal, report_file_error):
13656 * w32term.c (Vwindow_system, updating_frame):
13657 * w32uniscribe.c (initialized, uniscribe_font_driver):
13658 Remove unneeded extern declarations.
13660 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13662 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13664 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13666 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13667 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13668 These macros can no longer be used for assignment.
13670 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13671 Assign struct members directly, instead of using BUF_BEGV etc.
13672 (record_buffer_markers, fetch_buffer_markers): New functions for
13673 recording and fetching special buffer markers.
13674 (set_buffer_internal_1, set_buffer_temp): Use them.
13676 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13678 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13680 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13681 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13683 * xdisp.c (hscroll_window_tree):
13684 (reconsider_clip_changes): Use PT instead of BUF_PT.
13686 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13688 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13689 $(EMACS_ROOT)/lib/intprops.h.
13691 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13693 Fix more problems found by GCC 4.5.2's static checks.
13695 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13696 to unsigned char * to avoid compiler diagnostic.
13697 (xg_free_frame_widgets): Make it clear that a local variable is
13698 needed only if USE_GTK_TOOLTIP.
13699 (gdk_window_get_screen): Make it clear that this macro is needed
13700 only if USE_GTK_TOOLTIP.
13701 (int_gtk_range_get_value): New function, which avoids a diagnostic
13702 from gcc -Wbad-function-cast.
13703 (xg_set_toolkit_scroll_bar_thumb): Use it.
13704 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13705 diagnostic from gcc -Wbad-function-cast.
13706 (get_utf8_string, xg_get_file_with_chooser):
13707 Rename locals to avoid shadowing.
13708 (create_dialog): Move locals to avoid shadowing.
13710 * xgselect.c (xg_select): Remove unused var.
13712 * image.c (four_corners_best): Mark locals as initialized.
13713 (gif_load): Initialize transparent_p to zero (Bug#8238).
13714 Mark another local as initialized.
13715 (my_png_error, my_error_exit): Mark with NO_RETURN.
13717 * image.c (clear_image_cache): Now static.
13718 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13719 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13720 (x_edge_detection): Remove unnecessary cast that
13721 gcc -Wbad-function-cast diagnoses.
13722 (gif_load): Fix pointer signedness.
13723 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13724 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13726 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13728 Improve quality of tests for time stamp overflow.
13729 For example, without this patch (encode-time 0 0 0 1 1
13730 1152921504606846976) returns the obviously-bogus value (-948597
13731 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13732 reports time overflow. See
13733 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13734 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13735 * editfns.c: Include limits.h and intprops.h.
13736 (TIME_T_MIN, TIME_T_MAX): New macros.
13737 (time_overflow): Move earlier, to before first use.
13738 (hi_time, lo_time): New functions, for an accurate test for
13739 out-of-range times.
13740 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13741 (Fget_internal_run_time): Don't assume time_t fits in int.
13742 (make_time): Use list2 instead of Fcons twice.
13743 (Fdecode_time): More accurate test for out-of-range times.
13744 (check_tm_member): New function.
13745 (Fencode_time): Use it, to test for out-of-range times.
13746 (lisp_time_argument): Don't rely on undefined left-shift and
13747 right-shift behavior when checking for time stamp overflow.
13749 * editfns.c (time_overflow): New function, refactoring common code.
13750 (Fformat_time_string, Fdecode_time, Fencode_time):
13751 (Fcurrent_time_string): Use it.
13753 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13754 * dired.c (make_time): Move to ...
13755 * editfns.c (make_time): ... here.
13756 * systime.h: Note the move.
13758 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13760 * fringe.c (update_window_fringes): Remove unused variables.
13762 * unexmacosx.c (copy_data_segment): Also copy __got section.
13765 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13767 * termcap.c [MSDOS]: Include "msdos.h".
13768 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13769 Constify `char *' arguments and their references according to
13770 prototypes in tparam.h.
13772 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13774 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13775 Adapt all references accordingly.
13777 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13779 2011-03-11 Tom Tromey <tromey@redhat.com>
13781 * buffer.c (syms_of_buffer): Remove obsolete comment.
13783 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13785 * termhooks.h (encode_terminal_code): Declare prototype.
13787 * msdos.c (encode_terminal_code): Don't declare prototype.
13789 * term.c (encode_terminal_code): Now external again, used by
13790 w32console.c and msdos.c.
13792 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13793 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13795 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13797 Fix some minor problems found by GCC 4.5.2's static checks.
13799 * fringe.c (update_window_fringes): Mark locals as initialized
13801 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13803 * alloc.c (mark_fringe_data): Move decl from here ...
13804 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13805 to check its interface.
13806 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13808 * fontset.c (free_realized_fontset): Now static.
13809 (Fset_fontset_font): Rename local to avoid shadowing.
13810 (fontset_font): Mark local as initialized.
13811 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13813 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13815 * xselect.c (x_disown_buffer_selections): Remove; not used.
13816 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13817 (x_own_selection, Fx_disown_selection_internal): Rename locals
13818 to avoid shadowing.
13819 (x_handle_dnd_message): Remove local to avoid shadowing.
13821 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13822 so that the caller can use some name other than gcpro1.
13823 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13824 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13825 (Fx_backspace_delete_keys_p):
13826 Use them to avoid shadowing, and rename vars to avoid shadowing.
13827 (x_decode_color, x_set_name, x_window): Now static.
13828 (Fx_create_frame): Add braces to silence GCC warning.
13829 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13830 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13831 Remove unused locals.
13832 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13833 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13834 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13837 * xterm.h (x_mouse_leave): New decl.
13839 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13840 Remove unused functions.
13841 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13842 (x_calc_absolute_position): Now static.
13843 (XTread_socket): Don't define label "out" unless it's used.
13844 Don't declare local "event" unless it's used.
13845 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13846 unless they are used.
13847 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13848 (x_fatal_error_signal): Remove; not used.
13849 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13850 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13851 (x_error_catcher, x_connection_closed, x_error_handler):
13852 (x_error_quitter, xembed_send_message, x_iconify_frame):
13853 (my_log_handler): Rename locals to avoid shadowing.
13854 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13855 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13857 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13858 Rename or move locals to avoid shadowing.
13859 (tty_defined_color, merge_face_heights): Now static.
13860 (free_realized_faces_for_fontset): Remove; not used.
13861 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13862 does not deduce is never used uninitialized.
13863 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13864 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13866 * terminal.c (store_terminal_param): Now static.
13868 * xmenu.c (menu_highlight_callback): Now static.
13869 (set_frame_menubar): Remove unused local.
13870 (xmenu_show): Rename parameter to avoid shadowing.
13871 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13872 since they might point to immutable storage.
13873 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13874 since it's unused otherwise.
13876 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13877 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13878 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13879 avoids a gcc -Wuninitialized diagnostic.
13880 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13881 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13882 does not deduce are never used uninitialized.
13884 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13886 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13887 * window.c (window_loop, size_window):
13888 (run_window_configuration_change_hook, enlarge_window): Likewise.
13890 * window.c (display_buffer): Now static.
13891 (size_window): Mark variables that gcc -Wuninitialized
13892 does not deduce are never used uninitialized.
13893 * window.h (check_all_windows): New decl, to forestall
13894 gcc -Wmissing-prototypes diagnostic.
13895 * dispextern.h (bidi_dump_cached_states): Likewise.
13897 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13899 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13900 Include <limits.h>.
13901 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13902 and to avoid gcc -Wuninitialized warning.
13903 (load_charset_map): Mark variables that gcc -Wuninitialized
13904 does not deduce are never used uninitialized.
13905 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13907 * coding.c (coding_set_source, coding_set_destination):
13908 Use "else { /* comment */ }" rather than "else /* comment */;"
13909 for clarity, and to avoid gcc -Wempty-body warning.
13910 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13911 a block, when the outer 'i' will do.
13912 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13913 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13914 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13915 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13916 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13917 Rename locals to avoid shadowing.
13918 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13919 * coding.c (emacs_mule_char, encode_invocation_designation):
13920 Now static, since they're not used elsewhere.
13921 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13922 (decode_coding_object, encode_coding_object, detect_coding_system):
13923 (decode_coding_emacs_mule): Mark variables that gcc
13924 -Wuninitialized does not deduce are never used uninitialized.
13925 (detect_coding_iso_2022): Initialize a local variable that might
13926 be used uninitialized. Leave a FIXME because it's not clear that
13927 this initialization is needed. (Bug#8211)
13928 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13929 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13930 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13931 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13932 Remove unused macros.
13934 * category.c (hash_get_category_set): Remove unused local var.
13935 (copy_category_table): Now static, since it's not used elsewhere.
13936 * character.c (string_count_byte8): Likewise.
13938 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13939 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13941 * chartab.c (copy_sub_char_table): Now static, since it's not used
13943 (sub_char_table_ref_and_range, char_table_ref_and_range):
13944 Rename locals to avoid shadowing.
13945 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13947 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13948 (BIDI_BOB): Remove unused macro.
13950 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13951 deduce are never used uninitialized.
13952 * term.c (encode_terminal_code): Likewise.
13954 * term.c (encode_terminal_code): Now static. Remove unused local.
13956 * tparam.h: New file.
13957 * term.c, tparam.h: Include it.
13958 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13959 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13960 Move these decls to tparam.h, and make them agree with what
13961 is actually in tparam.c. The previous trick of using incompatible
13962 decls in different modules does not conform to the C standard.
13963 All callers of tparam changed to use tparam's actual API.
13964 * tparam.c (tparam1, tparam, tgoto):
13965 Use const pointers where appropriate.
13967 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13968 * cm.h (struct cm): Likewise.
13969 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13970 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13971 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13972 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13973 (turn_on_face, init_tty): Likewise.
13974 * termchar.h (struct tty_display_info): Likewise.
13976 * term.c (term_mouse_position): Rename local to avoid shadowing.
13978 * alloc.c (mark_ttys): Move decl from here ...
13979 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13981 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13983 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13985 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13987 * search.c (compile_pattern_1): Remove argument regp, unused since
13988 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13989 (compile_pattern): Don't pass it.
13991 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13993 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13994 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13996 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13998 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14000 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14001 gdk_window_get_screen, gdk_window_get_geometry,
14002 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14003 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14004 (xg_get_pixbuf_from_pixmap): New function.
14005 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14006 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14007 Call xg_get_pixbuf_from_pixmap instead of
14008 gdk_pixbuf_get_from_drawable.
14009 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14010 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14011 (xg_check_special_colors): Use GtkStyleContext and its functions
14013 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14014 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14015 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14016 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14017 Call gtk_widget_get_preferred_size.
14018 (xg_frame_resized): gdk_window_get_geometry only takes 5
14020 (xg_win_to_widget, xg_event_is_for_menubar):
14021 Call gdk_x11_window_lookup_for_display.
14022 (xg_set_widget_bg): New function.
14023 (delete_cb): New function.
14024 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14025 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14026 (xg_set_background_color): Call xg_set_widget_bg.
14027 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14028 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14029 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14030 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14032 (update_frame_tool_bar): Call gtk_widget_hide.
14033 (xg_initialize): Use GDK_KEY_g.
14035 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14037 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14039 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14040 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14041 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14043 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14045 * w32xfns.c (select_palette): Check success of RealizePalette against
14046 GDI_ERROR, not zero.
14048 See ChangeLog.11 for earlier changes.
14050 ;; Local Variables:
14054 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14056 This file is part of GNU Emacs.
14058 GNU Emacs is free software: you can redistribute it and/or modify
14059 it under the terms of the GNU General Public License as published by
14060 the Free Software Foundation, either version 3 of the License, or
14061 (at your option) any later version.
14063 GNU Emacs is distributed in the hope that it will be useful,
14064 but WITHOUT ANY WARRANTY; without even the implied warranty of
14065 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14066 GNU General Public License for more details.
14068 You should have received a copy of the GNU General Public License
14069 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.