1 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
3 * buffer.c: Include <verify.h>.
4 (struct sortvec.priority, struct sortstr.priority):
5 Now EMACS_INT, not int.
6 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7 (struct sortstr.size, record_overlay_string)
8 (struct sortstrlist.size, struct sortlist.used):
9 Don't truncate size to int.
10 (record_overlay_string): Check for size-calculation overflow.
11 (init_buffer_once): Check at compile-time, not run-time.
13 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
15 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
16 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
17 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
19 Improve buffer-overflow checking (Bug#8873).
20 * fileio.c (Finsert_file_contents):
21 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
22 Remove the old (too-loose) buffer overflow checks.
23 They weren't needed, since make_gap checks for buffer overflow.
24 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
25 The old code merely checked for Emacs fixnum overflow, and relied
26 on undefined (wraparound) behavior. The new code avoids undefined
27 behavior, and also checks for ptrdiff_t and/or size_t overflow.
29 * editfns.c (Finsert_char): Don't dump core with very negative counts.
30 Tune. Don't use wider integers than needed. Don't use alloca.
31 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
33 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
35 * insdel.c, lisp.h (buffer_overflow): New function.
36 (insert_from_buffer_1, replace_range, replace_range_2):
37 * insdel.c (make_gap_larger):
38 * editfns.c (Finsert_char):
39 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
41 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
43 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
45 Integer overflow and signedness fixes (Bug#8873).
47 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
48 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
50 * fileio.c: Don't assume EMACS_INT fits in off_t.
51 (emacs_lseek): New static function.
52 (Finsert_file_contents, Fwrite_region): Use it.
53 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
55 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
57 * fns.c: Don't overflow int when computing a list length.
58 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
59 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
60 truncation on 64-bit hosts. Check for QUIT every
61 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
62 faster and is responsive enough.
63 (Flength): Report an error instead of overflowing an integer.
64 (Fsafe_length): Return a float if the value is not representable
65 as a fixnum. This shouldn't happen except in contrived situations.
66 (Fnthcdr, Fsort): Don't assume list length fits in int.
67 (Fcopy_sequence): Don't assume vector length fits in int.
69 * alloc.c: Check that resized vectors' lengths fit in fixnums.
70 (header_size, word_size): New constants.
71 (allocate_vectorlike): Don't check size overflow here.
72 (allocate_vector): Check it here instead, since this is the only
73 caller of allocate_vectorlike that could cause overflow.
74 Check that the new vector's length is representable as a fixnum.
76 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
77 The previous code was bogus. For example, next_almost_prime (32)
78 returned 39, which is undesirable as it is a multiple of 3; and
79 next_almost_prime (24) returned 25, which is a multiple of 5 so
80 why was the code bothering to check for multiples of 7?
82 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
84 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
86 Variadic C functions now count arguments with ptrdiff_t.
87 This partly undoes my 2011-03-30 change, which replaced int with size_t.
88 Back then I didn't know that the Emacs coding style prefers signed int.
89 Also, in the meantime I found a few more instances where arguments
90 were being counted with int, which may truncate counts on 64-bit
91 machines, or EMACS_INT, which may be unnecessarily wide.
92 * lisp.h (struct Lisp_Subr.function.aMANY)
93 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
94 Arg counts are now ptrdiff_t, not size_t.
95 All variadic functions and their callers changed accordingly.
96 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
97 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
98 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
99 * callint.c (Fcall_interactively): Check arg count for overflow,
100 to avoid potential buffer overrun. Use signed char, not 'int',
101 for 'varies' array, so that we needn't bother to check its size
102 calculation for overflow.
103 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
104 * eval.c (apply_lambda):
105 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
106 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
107 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
109 * callint.c (Fcall_interactively): Don't use index var as event count.
111 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
112 * mem-limits.h (SIZE): Remove; no longer used.
114 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
116 Remove unnecessary casts.
117 * xterm.c (x_term_init):
118 * xfns.c (x_set_border_pixel):
119 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
120 These aren't needed now that we assume ANSI C.
122 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
123 It's more likely to cause problems (due to unsigned overflow)
126 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
128 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
130 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
132 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
134 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
136 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
138 GLYPH_CODE_FACE returns EMACS_INT, not int.
139 * dispextern.h (merge_faces):
140 * xfaces.c (merge_faces):
141 * xdisp.c (get_next_display_element, next_element_from_display_vector):
142 Don't assume EMACS_INT fits in int.
144 * character.h (CHAR_VALID_P): Remove unused parameter.
145 * fontset.c, lisp.h, xdisp.c: All uses changed.
147 * editfns.c (Ftranslate_region_internal): Omit redundant test.
149 * fns.c (concat): Minor tuning based on overflow analysis.
150 This doesn't fix any bugs. Use int to hold character, instead
151 of constantly refetching from Emacs object. Use XFASTINT, not
152 XINT, for value known to be a character. Don't bother comparing
153 a single byte to 0400, as it's always less.
155 * floatfns.c (Fexpt):
156 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
158 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
161 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
163 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
164 Without this fix, on a 64-bit host (aset S 0 4294967386) would
165 incorrectly succeed when S was a string, because 4294967386 was
166 truncated before it was used.
168 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
169 Otherwise, an out-of-range integer could cause undefined behavior
172 * composite.c: Use int, not EMACS_INT, for characters.
173 (fill_gstring_body, composition_compute_stop_pos): Use int, not
174 EMACS_INT, for values that are known to be in character range.
175 This doesn't fix any bugs but is the usual style inside Emacs and
176 may generate better code on 32-bit machines.
178 Make sure a 64-bit char is never passed to ENCODE_CHAR.
179 This is for reasons similar to the recent CHAR_STRING fix.
180 * charset.c (Fencode_char): Check that character arg is actually
181 a character. Pass an int to ENCODE_CHAR.
182 * charset.h (ENCODE_CHAR): Verify that the character argument is no
183 wider than 'int', as a compile-time check to prevent future regressions
186 * character.c (char_string): Remove unnecessary casts.
188 Make sure a 64-bit char is never passed to CHAR_STRING.
189 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
190 by silently ignoring the top 32 bits, allowing some values
191 that were far too large to be valid characters.
192 * character.h: Include <verify.h>.
193 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
194 arguments are no wider than unsigned, as a compile-time check
195 to prevent future regressions in this area.
197 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
198 (Fsubst_char_in_region):
200 * xdisp.c (decode_mode_spec_coding):
201 Adjust to CHAR_STRING's new requirement.
202 * editfns.c (Finsert_char, Fsubst_char_in_region):
203 * fns.c (concat): Check that character args are actually
204 characters. Without this test, these functions did the wrong
205 thing with wildly out-of-range values on 64-bit hosts.
207 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
208 These casts should not be needed on 32-bit hosts, either.
209 * keyboard.c (read_char):
210 * lread.c (Fload): Remove casts to unsigned.
212 * lisp.h (UNSIGNED_CMP): New macro.
213 This fixes comparison bugs on 64-bit hosts.
214 (ASCII_CHAR_P): Use it.
215 * casefiddle.c (casify_object):
216 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
217 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
218 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
219 * dispextern.h (FACE_FROM_ID):
220 * keyboard.c (read_char): Use UNSIGNED_CMP.
222 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
223 not to EMACS_INT, to avoid GCC warning.
225 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
227 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
228 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
229 isn't needed on 32-bit machines.
231 * buffer.c (Fgenerate_new_buffer_name):
232 Use EMACS_INT for count, not int.
233 (advance_to_char_boundary): Return EMACS_INT, not int.
235 * data.c (Qcompiled_function): Now static.
237 * window.c (window_body_lines): Now static.
239 * image.c (gif_load): Rename local to avoid shadowing.
241 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
242 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
243 * alloc.c (make_save_value): Integer argument is now of type
245 (mark_object): Use ptrdiff_t, not int.
246 * lisp.h (pD): New macro.
247 * print.c (print_object): Use it.
249 * alloc.c: Use EMACS_INT, not int, to count objects.
250 (total_conses, total_markers, total_symbols, total_vector_size)
251 (total_free_conses, total_free_markers, total_free_symbols)
252 (total_free_floats, total_floats, total_free_intervals)
253 (total_intervals, total_strings, total_free_strings):
254 Now EMACS_INT, not int. All uses changed.
255 (Fgarbage_collect): Compute overall total using a double, so that
256 integer overflow is less likely to be a problem. Check for overflow
257 when converting back to an integer.
258 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
259 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
260 These were 'int' variables that could overflow on 64-bit hosts;
261 they were never used, so remove them instead of repairing them.
262 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
263 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
264 Previously, this ceilinged at INT_MAX, but that doesn't work on
266 (allocate_pseudovector): Don't use EMACS_INT when int would do.
268 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
269 (allocate_vectorlike): Check for ptrdiff_t overflow.
270 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
271 when a (possibly-narrower) signed value would do just as well.
272 We prefer using signed arithmetic, to avoid comparison confusion.
274 * alloc.c: Catch some string size overflows that we were missing.
275 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
276 for convenience in STRING_BYTES_MAX.
277 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
278 The definition here is exact; the one in lisp.h was approximate.
279 (allocate_string_data): Check for string overflow. This catches
280 some instances we weren't catching before. Also, it catches
281 size_t overflow on (unusual) hosts where SIZE_MAX <= min
282 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
283 and ptrdiff_t and EMACS_INT are both 64 bits.
285 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
286 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
287 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
289 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
291 * alloc.c (Fmake_string): Check for out-of-range init.
293 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
295 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
297 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
299 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
300 xg_get_default_scrollbar_width.
302 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
303 (int_gtk_range_get_value): Move to the scroll bar part of the file.
304 (style_changed_cb): Call update_theme_scrollbar_width and call
305 x_set_scroll_bar_default_width and xg_frame_set_char_size for
306 all frames (Bug#8505).
307 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
308 Call gtk_window_set_resizable if HAVE_GTK3.
309 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
310 and height if HAVE_GTK3 (Bug#8505).
311 (scroll_bar_width_for_theme): New variable.
312 (update_theme_scrollbar_width): New function.
313 (xg_get_default_scrollbar_width): Move code to
314 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
315 (xg_initialize): Call update_theme_scrollbar_width.
317 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
319 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
321 2011-06-12 Martin Rudalics <rudalics@gmx.at>
323 * frame.c (make_frame): Call other_buffer_safely instead of
326 * window.c (temp_output_buffer_show): Call display_buffer with
327 second argument Vtemp_buffer_show_specifiers and reset latter
328 immediately after the call.
329 (Vtemp_buffer_show_specifiers): New variable.
330 (auto_window_vscroll_p, next_screen_context_lines)
331 (Vscroll_preserve_screen_position): Remove leading asterisks from
334 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
336 Fix minor problems found by GCC 4.6.0 static checking.
337 * buffer.c (Qclone_number): Remove for now, as it's unused.
338 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
339 (record_buffer): Remove unused local.
340 * frame.c (other_visible_frames, frame_buffer_list): Now static.
341 (set_frame_buffer_list): Remove; unused.
342 * frame.h (other_visible_frames): Remove decl.
343 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
344 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
345 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
347 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
348 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
349 Define only if HAVE_GPM.
350 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
351 (update_hints_inhibit): Remove; never set. All uses removed.
352 * widgetprv.h (emacsFrameClassRec): Remove decl.
353 * window.c (delete_deletable_window): Now returns void, since it
354 wasn't returning anything.
355 (compare_window_configurations): Remove unused locals.
356 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
357 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
358 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
359 the same widths as pointers. This follows up on the 2011-05-06 patch.
360 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
362 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
364 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
366 * makefile.w32-in: Update dependencies.
367 (LISP_H): Add lib/intprops.h.
369 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
371 * image.c (gif_load): Add animation frame delay to the metadata.
372 (syms_of_image): Use DEFSYM. New symbol `delay'.
374 2011-06-11 Martin Rudalics <rudalics@gmx.at>
376 * window.c (delete_deletable_window): Re-add.
377 (Fset_window_configuration): Rewrite to handle dead buffers and
378 consequently deletable windows.
379 (window_tree, Fwindow_tree): Remove. Supply functionality in
381 (compare_window_configurations): Simplify code.
383 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
385 * image.c (imagemagick_load_image): Fix type mismatch.
386 (Fimagemagick_types): Likewise.
388 * window.h (replace_buffer_in_windows): Declare.
390 2011-06-11 Martin Rudalics <rudalics@gmx.at>
392 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
393 Qclone_number. Remove external declaration of Qdelete_window.
394 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
396 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
397 Qbuffer_list_update_hook if allowed.
398 (Fother_buffer): Rewrite doc-string. Major rewrite for new
399 buffer list implementation.
400 (other_buffer_safely): New function.
401 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
402 calls to replace_buffer_in_windows and
403 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
405 (record_buffer): Inhibit quitting and rewrite using quittable
406 functions. Run Qbuffer_list_update_hook if allowed.
407 (Frecord_buffer, Funrecord_buffer): New functions.
408 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
409 switch-to-buffer to window.el.
410 (bury-buffer): Move to window.el.
411 (Vbuffer_list_update_hook): New variable.
413 * lisp.h (other_buffer_safely): Add prototype in buffer.c
416 * window.h (resize_frame_windows): Move up in code.
417 (Fwindow_frame): Remove EXFUN.
418 (replace_buffer_in_all_windows): Remove prototype.
419 (replace_buffer_in_windows_safely): Add prototype.
421 * window.c: Declare Qdelete_window static again. Move down
422 declaration of select_count.
423 (Fnext_window, Fprevious_window): Rewrite doc-strings.
424 (Fother_window): Move to window.el.
425 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
426 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
427 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
429 (replace_buffer_in_windows): Implement by calling
430 Qreplace_buffer_in_windows.
431 (replace_buffer_in_all_windows): Remove with some functionality
432 moved into replace_buffer_in_windows_safely.
433 (replace_buffer_in_windows_safely): New function.
434 (select_window_norecord, select_frame_norecord): Move in front
435 of run_window_configuration_change_hook. Remove now obsolete
437 (Fset_window_buffer): Rewrite doc-string. Call
438 Qrecord_window_buffer.
439 (keys_of_window): Move binding for other-window to window.el.
441 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
443 * dispextern.h (struct image): Replace data member, whose int_val
444 and ptr_val fields were not used by anything, with a single
447 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
448 (gif_clear_image, gif_load, imagemagick_load_image)
449 (gs_clear_image, gs_load): Callers changed.
451 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
453 * buffer.h: Include <time.h>, for time_t.
454 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
456 Fix minor problems found by static checking.
458 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
460 Make identifiers static if they are not used in other modules.
461 * data.c (Qcompiled_function, Qframe, Qvector):
462 * image.c (QimageMagick, Qsvg):
463 * minibuf.c (Qmetadata):
464 * window.c (resize_window_check, resize_root_window): Now static.
465 * window.h (resize_window_check, resize_root_window): Remove decls.
467 * window.c (window_deletion_count, delete_deletable_window):
469 (window_body_lines): Now static.
470 (Fdelete_other_windows_internal): Mark vars as initialized.
471 Make sure 'resize_failed' is initialized.
472 (run_window_configuration_change_hook): Rename local to avoid shadowing.
473 (resize_window_apply): Remove unused local.
474 * window.h (delete_deletable_window): Remove decl.
476 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
477 (imagemagick_load_image): Fix pointer signedness problem by changing
478 last arg from unsigned char * to char *. All uses changed.
479 Also, fix a local for similar reasons.
480 Remove unused locals. Remove locals to avoid shadowing.
481 (fn_rsvg_handle_free): Remove; unused.
482 (svg_load, svg_load_image): Fix pointer signedness problem.
483 (imagemagick_load_image): Don't use garbage pointer image_wand.
485 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
487 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
489 * image.c (gif_load): Fix omitted cast error introduced by
492 2011-06-10 Martin Rudalics <rudalics@gmx.at>
494 * window.h (resize_proportionally, orig_total_lines)
495 (orig_top_line): Remove from window structure.
496 (set_window_height, set_window_width, change_window_heights)
497 (Fdelete_window): Remove prototypes.
498 (resize_frame_windows): Remove duplicate declaration.
500 2011-06-10 Eli Zaretskii <eliz@gnu.org>
502 * window.h (resize_frame_windows, resize_window_check)
503 (delete_deletable_window, resize_root_window)
504 (resize_frame_windows): Declare prototypes.
506 * window.c (resize_window_apply): Make definition be "static" to
509 2011-06-10 Martin Rudalics <rudalics@gmx.at>
511 * window.c: Remove declarations of Qwindow_size_fixed,
512 window_min_size_1, window_min_size_2, window_min_size,
513 size_window, window_fixed_size_p, enlarge_window, delete_window.
514 Remove static from declaration of Qdelete_window, it's
515 temporarily needed by Fbury_buffer.
516 (replace_window): Don't assign orig_top_line and
518 (Fdelete_window, delete_window): Remove. Window deletion is
519 handled by window.el.
520 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
521 Fdelete_window calls with calls to Qdelete_window.
522 (Fdelete_other_windows): Remove. Deleting other windows is
523 handled by window.el.
524 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
525 handled in window.el.
526 (window_min_size_2, window_min_size_1, window_min_size): Remove.
527 Window minimum sizes are handled in window.el.
528 (shrink_windows, size_window, set_window_height)
529 (set_window_width, change_window_heights, window_height)
530 (window_width, CURBEG, CURSIZE, enlarge_window)
531 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
532 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
533 handled in window.el.
534 (make_dummy_parent): Rename to make_parent_window and give it a
535 second argument horflag.
536 (make_window): Don't set resize_proportionally any more.
537 (Fsplit_window): Remove. Windows are split in window.el.
538 (save_restore_action, save_restore_orig_size)
539 (shrink_window_lowest_first, save_restore_orig_size): Remove.
540 Resize mini windows in window.el.
541 (grow_mini_window, shrink_mini_window): Implement by calling
542 Qresize_root_window_vertically, resize_window_check and
544 (saved_window, Fset_window_configuration, save_window_save): Do
545 not handle orig_top_line, orig_total_lines, and
546 resize_proportionally.
547 (window_min_height, window_min_width): Move to window.el.
548 (keys_of_window): Move bindings for delete-other-windows,
549 split-window, delete-window and enlarge-window to window.el.
551 * buffer.c: Temporarily extern Qdelete_window.
552 (Fbury_buffer): Temporarily call Qdelete_window instead of
553 Fdelete_window (Fbury_buffer will move to window.el soon).
555 * frame.c (set_menu_bar_lines_1): Remove code handling
556 orig_top_line and orig_total_lines.
558 * dispnew.c (adjust_frame_glyphs_initially): Don't use
559 set_window_height but set heights directly.
560 (change_frame_size_1): Use resize_frame_windows.
562 * xdisp.c (init_xdisp): Don't use set_window_height but set
565 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
566 resize_frame_windows instead of change_window_heights and run
567 run_window_configuration_change_hook.
569 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
570 instead of change_window_heights and run
571 run_window_configuration_change_hook.
573 2011-06-09 Martin Rudalics <rudalics@gmx.at>
575 * window.c (replace_window): Rename second argument REPLACEMENT to
576 NEW. New third argument SETFLAG. Rewrite.
577 (delete_window, make_dummy_parent): Call replace_window with
579 (window_list_1): Move down in code.
580 (run_window_configuration_change_hook): Move set_buffer part
581 before select_frame_norecord part in order to unwind correctly.
582 Rename count1 to count.
583 (recombine_windows, delete_deletable_window, resize_root_window)
584 (Fdelete_other_windows_internal)
585 (Frun_window_configuration_change_hook, make_parent_window)
586 (resize_window_check, resize_window_apply, Fresize_window_apply)
587 (resize_frame_windows, Fsplit_window_internal)
588 (Fdelete_window_internal, Fresize_mini_window_internal): New
590 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
592 2011-06-08 Martin Rudalics <rudalics@gmx.at>
594 * window.h (window): Add some new members to window structure -
595 normal_lines, normal_cols, new_total, new_normal, clone_number,
596 splits, nest, prev_buffers, next_buffers.
597 (WINDOW_TOTAL_SIZE): Move here from window.c.
598 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
600 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
602 (make_dummy_parent): Set new members of windows structure.
603 (make_window): Move down in code. Handle new members of window
605 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
606 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
607 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
608 (Fset_window_prev_buffers, Fwindow_next_buffers)
609 (Fset_window_next_buffers, Fset_window_clone_number): New
611 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
612 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
614 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
615 Argument WINDOW can be now internal window too.
616 (Fwindow_use_time): Move up in code.
617 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
619 (Fset_window_configuration, saved_window)
620 (Fcurrent_window_configuration, save_window_save): Handle new
621 members of window structure.
622 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
623 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
624 (syms_of_window): New Lisp objects Qrecord_window_buffer,
625 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
626 Qget_mru_window, Qresize_root_window,
627 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
628 Qauto_buffer_name; staticpro them.
630 2011-06-07 Martin Rudalics <rudalics@gmx.at>
632 * window.c (Fwindow_total_size, Fwindow_left_column)
633 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
634 (Fwindow_list_1): New functions.
635 (window_box_text_cols): Replace with window_body_cols.
636 (Fwindow_width, Fscroll_left, Fscroll_right): Use
637 window_body_cols instead of window_box_text_cols.
638 (delete_window, Fset_window_configuration): Call
639 delete_all_subwindows with window as argument.
640 (delete_all_subwindows): Take a window as argument and not a
642 (window_loop): Remove handling of GET_LRU_WINDOW and
644 (Fget_lru_window, Fget_largest_window): Move to window.el.
646 * window.h: Extern window_body_cols instead of
647 window_box_text_cols. delete_all_subwindows now takes a
648 Lisp_Object as argument.
650 * indent.c (compute_motion, Fcompute_motion): Use
651 window_body_cols instead of window_box_text_cols.
653 * frame.c (delete_frame): Call delete_all_subwindows with root
656 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
658 * fns.c (Fputhash): Document return value.
660 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
662 * image.c (gif_load): Implement gif89a spec "no disposal" method.
664 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
666 Cons<->int and similar integer overflow fixes (Bug#8794).
668 Check for overflow when converting integer to cons and back.
669 * charset.c (Fdefine_charset_internal, Fdecode_char):
670 Use cons_to_unsigned to catch overflow.
671 (Fencode_char): Use INTEGER_TO_CONS.
672 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
673 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
674 * data.c (long_to_cons, cons_to_long): Remove.
675 (cons_to_unsigned, cons_to_signed): New functions.
676 These signal an error for invalid or out-of-range values.
677 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
678 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
679 * font.c (Ffont_variation_glyphs):
680 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
681 * lisp.h: Include <intprops.h>.
682 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
683 (cons_to_signed, cons_to_unsigned): New decls.
684 (long_to_cons, cons_to_long): Remove decls.
685 * undo.c (record_first_change): Use INTEGER_TO_CONS.
686 (Fprimitive_undo): Use CONS_TO_INTEGER.
687 * xfns.c (Fx_window_property): Likewise.
688 * xselect.c: Include <limits.h>.
689 (x_own_selection, selection_data_to_lisp_data):
691 (x_handle_selection_request, x_handle_selection_clear)
692 (x_get_foreign_selection, Fx_disown_selection_internal)
693 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
694 (lisp_data_to_selection_data): Use cons_to_unsigned.
695 (x_fill_property_data): Use cons_to_signed.
696 Report values out of range.
698 Check for buffer and string overflow more precisely.
699 * buffer.h (BUF_BYTES_MAX): New macro.
700 * lisp.h (STRING_BYTES_MAX): New macro.
701 * alloc.c (Fmake_string):
702 * character.c (string_escape_byte8):
703 * coding.c (coding_alloc_by_realloc):
705 * editfns.c (Fformat):
707 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
708 since they may not be the same number.
709 * editfns.c (Finsert_char):
710 * fileio.c (Finsert_file_contents):
711 Likewise for BUF_BYTES_MAX.
713 * image.c: Use ptrdiff_t, not int, for sizes.
714 (slurp_file): Switch from int to ptrdiff_t.
716 (slurp_file): Check that file size fits in both size_t (for
717 malloc) and ptrdiff_t (for sanity and safety).
719 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
720 if b->modtime has its maximal value.
722 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
724 Don't assume time_t can fit into int.
725 * buffer.h (struct buffer.modtime): Now time_t, not int.
726 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
727 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
729 Minor fixes for signed vs unsigned integers.
730 * character.h (MAYBE_UNIFY_CHAR):
731 * charset.c (maybe_unify_char):
732 * keyboard.c (read_char, reorder_modifiers):
733 XINT -> XFASTINT, since the integer must be nonnegative.
734 * ftfont.c (ftfont_spec_pattern):
735 * keymap.c (access_keymap, silly_event_symbol_error):
736 XUINT -> XFASTINT, since the integer must be nonnegative.
737 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
738 since it makes no difference and we prefer signed.
739 * keyboard.c (record_char): Use XUINT when all the neighbors do.
740 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
743 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
745 * window.h (Fwindow_frame): Declare.
747 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
749 * alloc.c: Simplify handling of large-request failures (Bug#8800).
750 (SPARE_MEMORY): Always define.
751 (LARGE_REQUEST): Remove.
752 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
754 2011-06-06 Martin Rudalics <rudalics@gmx.at>
756 * lisp.h: Move EXFUNS for Fframe_root_window,
757 Fframe_first_window and Fset_frame_selected_window to window.h.
759 * window.h: Move EXFUNS for Fframe_root_window,
760 Fframe_first_window and Fset_frame_selected_window here from
763 * frame.c (Fwindow_frame, Fframe_first_window)
764 (Fframe_root_window, Fframe_selected_window)
765 (Fset_frame_selected_window): Move to window.c.
766 (Factive_minibuffer_window): Move to minibuf.c.
767 (Fother_visible_frames_p): New function.
769 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
771 * window.c (decode_window, decode_any_window): Move up in code.
772 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
773 (inhibit_frame_unsplittable): Remove unused variable.
774 (Fwindow_buffer): Move up and rewrite doc-string.
775 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
776 (Fwindow_prev): New functions.
777 (Fwindow_frame): Move here from frame.c. Accept any window as
779 (Fframe_root_window, Fframe_first_window)
780 (Fframe_selected_window): Move here from frame.c. Accept frame
781 or arbitrary window as argument. Update doc-strings.
782 (Fminibuffer_window): Move up in code.
783 (Fwindow_minibuffer_p): Move up in code and simplify.
784 (Fset_frame_selected_window): Move here from frame.c.
786 (Fselected_window, select_window, Fselect_window): Move up in
787 code. Minor doc-string fixes.
789 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
791 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
792 Do not assume that spare memory exists; that assumption is valid
793 only if SYSTEM_MALLOC.
794 (LARGE_REQUEST): New macro, so that the issue of large requests
795 is separated from the issue of spare memory.
797 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
799 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
802 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
804 * xfns.c (x_set_scroll_bar_default_width): Move declarations
807 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
809 * gtkutil.c (xg_get_default_scrollbar_width): New function.
811 * gtkutil.h: Declare xg_get_default_scrollbar_width.
813 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
814 min width by calling x_set_scroll_bar_default_width (Bug#8505).
816 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
818 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
820 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
822 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
823 (x_clipboard_manager_save): Add return value.
824 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
826 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
827 Obey Vx_select_enable_clipboard_manager. Catch errors in
828 x_clipboard_manager_save (Bug#8779).
829 (Vx_select_enable_clipboard_manager): New variable.
830 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
832 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
834 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
836 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
838 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
839 in the current matrix if keep_current_p is non-zero.
841 2011-06-04 Eli Zaretskii <eliz@gnu.org>
843 * bidi.c (bidi_level_of_next_char): Fix last change.
845 2011-06-03 Eli Zaretskii <eliz@gnu.org>
847 Support bidi reordering of text covered by display properties.
849 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
850 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
851 (bidi_cache_search, bidi_cache_iterator_state)
852 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
853 (bidi_level_of_next_char, bidi_move_to_visually_next):
854 Support character positions inside a run of characters covered by a
856 (bidi_paragraph_init, bidi_resolve_explicit_1)
857 (bidi_level_of_next_char): Call bidi_fetch_char and
858 bidi_fetch_char_advance instead of FETCH_CHAR and
860 (bidi_init_it): Initialize new members.
861 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
863 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
864 instead of using explicit *_CHAR codes.
865 (bidi_resolve_explicit, bidi_resolve_weak):
866 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
867 bidirectional text is supported only in multibyte buffers.
868 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
869 it to initialize the frame_window_p member of struct bidi_it.
870 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
871 (bidi_resolve_explicit, bidi_resolve_weak)
872 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
873 bidi_it->nchars is non-positive.
874 (bidi_level_of_next_char): Don't try to lookup the cache for the
875 next/previous character if nothing is cached there yet, or if we
876 were just reseat()'ed to a new position.
878 * xdisp.c (set_cursor_from_row): Set start and stop points
879 according to the row's direction when priming the loop that looks
880 for the glyph on which to display cursor.
881 (single_display_spec_intangible_p): Function deleted.
882 (display_prop_intangible_p): Reimplement to call
883 handle_display_spec instead of single_display_spec_intangible_p.
884 Accept 3 additional arguments needed by handle_display_spec.
885 This fixes incorrect cursor motion across display property with complex
886 values: lists, `(when COND...)' forms, etc.
887 (single_display_spec_string_p): Support property values that are
888 lists with the argument STRING its top-level element.
889 (display_prop_string_p): Fix the condition for processing a
890 property that is a list to be consistent with handle_display_spec.
891 (handle_display_spec): New function, refactored from the
892 last portion of handle_display_prop.
893 (compute_display_string_pos): Accept additional argument
894 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
895 value of a `display' property is a "replacing spec".
896 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
897 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
898 the display property, but just return a value indicating whether
899 the display property will replace the characters it covers.
900 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
901 frame_window_p members of struct bidi_it.
902 (compute_display_string_pos, compute_display_string_end):
904 (push_it): Accept second argument POSITION, where pop_it should
905 jump to continue iteration.
906 (reseat_1): Initialize bidi_it.disp_pos.
908 * keyboard.c (adjust_point_for_property): Adjust the call to
909 display_prop_intangible_p to its new signature.
911 * dispextern.h (struct bidi_it): New member frame_window_p.
912 (bidi_init_it): Update prototypes.
913 (display_prop_intangible_p): Update prototype.
914 (compute_display_string_pos, compute_display_string_end):
916 (struct bidi_it): New members nchars and disp_pos. ch_len is now
919 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
921 Malloc failure behavior now depends on size of allocation.
922 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
923 * lisp.h: Change signatures accordingly.
924 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
925 All callers changed. (Bug#8762)
927 * gnutls.c: Use Emacs's memory allocators.
928 Without this change, the gnutls library would invoke malloc etc.
929 directly, which causes problems on non-SYNC_INPUT hosts, and which
930 runs afoul of improving memory_full behavior. (Bug#8761)
931 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
932 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
933 xfree instead of the default malloc, realloc, free.
934 (Fgnutls_boot): No need to check for memory allocation failure,
935 since xmalloc does that for us.
937 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
938 * category.c (hash_get_category_set):
939 * ccl.c (ccl_driver):
940 * charset.c (Fdefine_charset_internal):
941 * charset.h (struct charset.hash_index):
942 * composite.c (get_composition_id, gstring_lookup_cache)
943 (composition_gstring_put_cache):
944 * composite.h (struct composition.hash_index):
945 * dispextern.h (struct image.hash):
946 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
947 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
948 (hashfn_equal, hashfn_user_defined, make_hash_table)
949 (maybe_resize_hash_table, hash_lookup, hash_put)
950 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
951 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
952 (Fsxhash, Fgethash, Fputhash, Fmaphash):
953 * image.c (make_image, search_image_cache, lookup_image)
954 (xpm_put_color_table_h):
955 * lisp.h (struct Lisp_Hash_Table):
956 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
957 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
958 for hashes and hash indexes, instead of 'unsigned' and 'int'.
959 * alloc.c (allocate_vectorlike):
960 Check for overflow in vector size calculations.
961 * ccl.c (ccl_driver):
962 Check for overflow when converting EMACS_INT to int.
963 * fns.c, image.c: Remove unnecessary static decls that would otherwise
964 need to be updated by these changes.
965 * fns.c (make_hash_table, maybe_resize_hash_table):
966 Check for integer overflow with large hash tables.
967 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
968 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
969 (SXHASH_REDUCE): New macro.
970 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
971 Use it instead of discarding useful hash info with large hash values.
972 (sxhash_float): New function.
973 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
974 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
975 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
976 Rewrite to use FIXNUM_BITS, as this simplifies things.
977 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
978 Adjust signatures to match updated version of code.
979 (consing_since_gc): Now EMACS_INT, since a single hash table can
980 use more than INT_MAX bytes.
982 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
984 Make it possible to build with GCC-4.6+ -O2 -flto.
986 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
988 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
990 * minibuf.c (get_minibuffer, read_minibuf_unwind):
991 Call minibuffer-inactive-mode.
993 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
995 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
998 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1000 * data.c (init_data): Remove code for UTS, this system is not
1003 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1005 Don't force ./temacs to start in terminal mode.
1007 * frame.c (make_initial_frame): Initialize faces in all cases, not
1008 only when CANNOT_DUMP is defined.
1009 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1011 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1013 * dispnew.c (add_window_display_history): Use const for the string
1014 pointer. Remove declaration, not needed.
1016 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1018 Use 'inline', not 'INLINE'.
1019 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1020 * alloc.c, fontset.c (INLINE): Remove.
1021 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1022 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1023 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1024 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1025 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1027 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1029 Make it possible to run ./temacs.
1031 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1032 syms_of_callproc does the same thing. Remove test for
1033 "initialized", do it in the caller.
1034 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1036 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1038 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1039 (read_minibuf): Use get_minibuffer.
1040 (syms_of_minibuf): Use DEFSYM.
1041 (Qmetadata): New var.
1042 * data.c (Qbuffer): Don't make it static.
1043 (syms_of_data): Use DEFSYM.
1045 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1047 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1048 (CCL_CODE_MIN): New macro.
1050 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1052 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1054 * eval.c (Qdebug): Now static.
1055 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1056 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1057 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1059 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1061 * image.c: Various fixes to ImageMagick code comments.
1062 (Fimagemagick_types): Doc fix.
1064 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1066 Minor fixes prompted by GCC 4.6.0 warnings.
1068 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1070 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1071 (x_clipboard_manager_save_all): Move extern decl to ...
1072 * xterm.h: ... here, so that it can be checked for consistency.
1074 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1076 * xselect.c (x_clipboard_manager_save_frame)
1077 (x_clipboard_manager_save_all): New functions.
1078 (Fx_clipboard_manager_save): Lisp function deleted.
1080 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1081 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1083 * xterm.h: Update prototype.
1085 2011-05-28 William Xu <william.xwl@gmail.com>
1087 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1090 2011-05-28 Jim Meyering <meyering@redhat.com>
1092 Avoid a sign-extension bug in crypto_hash_function.
1093 * fns.c (to_uchar): Define.
1094 (crypto_hash_function): Use it to convert some newly-signed
1095 variables to unsigned, to avoid sign-extension bugs. For example,
1096 without this change, (md5 "truc") would evaluate to
1097 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1098 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1099 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1101 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1103 Integer overflow fixes.
1105 * dbusbind.c: Serial number integer overflow fixes.
1106 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1107 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1108 to hold a serial number that is too large for a fixnum.
1109 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1110 Check for serial numbers out of range. Decode any serial number
1111 that was so large that it became a float. (Bug#8722)
1113 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1114 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1115 Use XFASTINT rather than XUINT when numbers are nonnegative.
1116 (xd_append_arg, Fdbus_method_return_internal):
1117 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1118 arguments, check that Lisp number is nonnegative, rather than
1119 silently wrapping negative numbers around. (Bug#8722)
1120 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1123 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1125 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1127 ccl: add integer overflow checks
1128 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1129 (IN_INT_RANGE): New macros.
1130 (ccl_driver): Use them to check for integer overflow when
1131 decoding a CCL program. Many of the new checks are whether XINT (x)
1132 fits in int; it doesn't always, on 64-bit hosts. The new version
1133 doesn't catch all possible integer overflows, but it's an
1134 improvement. (Bug#8719)
1136 * alloc.c (make_event_array): Use XINT, not XUINT.
1137 There's no need for unsigned here.
1139 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1140 This follows up to the 2011-05-06 change that substituted uintptr_t
1141 for EMACS_INT. This case wasn't caught back then.
1143 Rework Fformat to avoid integer overflow issues.
1144 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1145 now (part of C89). Include <verify.h>.
1146 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1147 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1148 (Fformat): Avoid the prepass trying to compute sizes; it was only
1149 approximate and thus did not catch overflow reliably. Instead, walk
1150 through the format just once, formatting and computing sizes as we go,
1151 checking for integer overflow at every step, and allocating a larger
1152 buffer as needed. Keep track separately whether the format is
1153 multibyte. Keep only the most-recently calculated precision, rather
1154 than them all. Record whether each argument has been converted to
1155 string. Use EMACS_INT, not int, for byte and char and arg counts.
1156 Support field widths and precisions larger than INT_MAX. Avoid
1157 sprintf's undefined behavior with conversion specifications such as %#d
1158 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1159 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1160 formatting out-of-range floating point numbers with int
1163 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1165 * data.c: Avoid integer truncation in expressions involving floats.
1166 * data.c: Include <intprops.h>.
1167 (arith_driver): When there's an integer overflow in an expression
1168 involving floating point, convert the integers to floating point
1169 so that the resulting value does not suffer from catastrophic
1170 integer truncation. For example, on a 64-bit host (* 4
1171 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1172 Do not rely on undefined behavior after integer overflow.
1174 merge count_size_as_multibyte, parse_str_to_multibyte
1175 * character.c, character.h (count_size_as_multibyte):
1176 Rename from parse_str_to_multibyte; all uses changed.
1177 Check for integer overflow.
1178 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1179 since it's now a duplicate of the other. This is more of
1180 a character than a buffer op, so better that it's in character.c.
1181 * fns.c, print.c: Adjust to above changes.
1183 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1185 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1187 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1189 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1190 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1191 (x_clipboard_manager_save): Now static.
1192 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1194 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1195 (crypto_hash_function): Now static.
1196 Fix pointer signedness problems. Avoid unnecessary initializations.
1198 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1200 * termhooks.h (Vselection_alist): Make it terminal-local.
1202 * terminal.c (create_terminal): Initialize it.
1204 * xselect.c: Support for clipboard managers.
1205 (Vselection_alist): Move to termhooks.h as terminal-local var.
1206 (LOCAL_SELECTION): New macro.
1207 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1208 (symbol_to_x_atom): Remove gratuitous arg.
1209 (x_handle_selection_request, lisp_data_to_selection_data)
1210 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1211 (x_own_selection, x_get_local_selection, x_convert_selection):
1212 New arg, specifying work frame. Use terminal-local Vselection_alist.
1213 (some_frame_on_display): Delete unused function.
1214 (Fx_own_selection_internal, Fx_get_selection_internal)
1215 (Fx_disown_selection_internal, Fx_selection_owner_p)
1216 (Fx_selection_exists_p): New optional frame arg.
1217 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1218 (x_handle_selection_clear): Don't treat other terminals with the
1219 same keyboard specially. Use the terminal-local Vselection_alist.
1220 (x_clear_frame_selections): Use Frun_hook_with_args.
1222 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1224 * xterm.h: Add support for those atoms.
1226 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1228 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1229 (converted_selections, conversion_fail_tag): New global variables.
1230 (x_selection_request_lisp_error): Free the above.
1231 (x_get_local_selection): Remove unnecessary code.
1232 (x_reply_selection_request): Args changed; handle arbitrary array
1233 of converted selections stored in converted_selections.
1234 Separate the XChangeProperty and SelectionNotify steps.
1235 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1236 (x_convert_selection): New function.
1237 (x_handle_selection_event): Simplify.
1238 (x_get_foreign_selection): Don't ignore incoming requests while
1239 waiting for an answer; this will fail when we implement
1240 SAVE_TARGETS, and seems unnecessary anyway.
1241 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1242 (Vx_sent_selection_functions): Doc fix.
1244 2011-05-26 Leo Liu <sdl.web@gmail.com>
1246 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1248 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1250 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1252 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1253 for fringe update if it has periodic bitmap.
1254 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1255 and fringe_bitmap_periodic_p.
1257 * fringe.c (get_fringe_bitmap_data): New function.
1258 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1259 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1260 row. Mark glyph row for fringe update if periodicity changed.
1262 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1263 for fringe update unless it has periodic bitmap.
1265 2011-05-25 Kenichi Handa <handa@m17n.org>
1267 * xdisp.c (get_next_display_element): Set correct it->face_id for
1268 a static composition.
1270 2011-05-24 Leo Liu <sdl.web@gmail.com>
1273 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1275 * fns.c (crypto_hash_function, Fsha1): New function.
1276 (Fmd5): Use crypto_hash_function.
1277 (syms_of_fns): Add Ssha1.
1279 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1281 * gnutls.c: Remove unused macros.
1282 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1283 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1284 Remove macros that are defined and never used.
1285 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1287 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1289 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1290 (Fx_get_selection_internal): Minor cleanup.
1291 (Fx_own_selection_internal): Rename arguments for consistency with
1294 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1296 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1298 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1300 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1302 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1304 * dispnew.c (scrolling_window): Don't exclude the case that the
1305 last enabled row in the desired matrix touches the bottom boundary.
1307 2011-05-21 Glenn Morris <rgm@gnu.org>
1309 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1310 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1311 and add some more files.
1313 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1315 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1316 report_file_error introduced by the change from 2011-05-07.
1318 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1320 * systime.h (Time): Define only if emacs is defined.
1321 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1322 where the include path doesn't have X11/X.h by default. See
1323 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1325 2011-05-20 Kenichi Handa <handa@m17n.org>
1327 * composite.c (find_automatic_composition): Fix previous change.
1329 2011-05-20 Glenn Morris <rgm@gnu.org>
1331 * lisp.mk: New file, split from Makefile.in.
1332 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1333 (shortlisp): Remove.
1334 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1336 2011-05-19 Glenn Morris <rgm@gnu.org>
1338 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1339 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1340 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1341 (lisp): Set the order to that of loadup.el.
1342 (shortlisp): Make it a copy of $lisp.
1343 (SOME_MACHINE_LISP): Remove.
1344 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1345 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1347 2011-05-18 Kenichi Handa <handa@m17n.org>
1349 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1350 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1351 (find_automatic_composition): Mostly rewrite for efficiency.
1353 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1355 * makefile.w32-in: Update dependencies.
1357 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1359 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1360 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1362 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1364 Fix some integer overflow issues, such as string length overflow.
1366 * insdel.c (count_size_as_multibyte): Check for string overflow.
1368 * character.c (lisp_string_width): Check for string overflow.
1369 Use EMACS_INT, not int, for string indexes and lengths; in
1370 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1371 the resulting string length overflows an EMACS_INT; instead,
1372 report a string overflow if no precision given. When checking for
1373 precision exhaustion, use a check that cannot possibly have
1374 integer overflow. (Bug#8675)
1375 * character.h (lisp_string_width): Adjust to new signature.
1377 * alloc.c (string_overflow): New function.
1378 (Fmake_string): Use it. This doesn't change behavior, but saves
1379 a few bytes and will simplify future changes.
1380 * character.c (string_escape_byte8): Likewise.
1381 * lisp.h (string_overflow): New decl.
1383 Fixups, following up to the user-interface timestamp change.
1384 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1385 for UI timestamps, instead of unsigned long.
1386 * msdos.c (mouse_get_pos): Likewise.
1387 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1388 * w32gui.h (Time): Define by including "systime.h" rather than by
1389 declaring it ourselves. (Bug#8664)
1391 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1392 * image.c (clear_image_cache): Likewise.
1394 * term.c (term_mouse_position): Don't assume time_t wraparound.
1396 Be more systematic about user-interface timestamps.
1397 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1398 and sometimes 'EMACS_UINT', to represent these timestamps.
1399 This change causes it to use 'Time' uniformly, as that's what X uses.
1400 This makes the code easier to follow, and makes it easier to catch
1401 integer overflow bugs such as Bug#8664.
1402 * frame.c (Fmouse_position, Fmouse_pixel_position):
1403 Use Time, not unsigned long, for user-interface timestamps.
1404 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1405 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1406 * keyboard.h (last_event_timestamp): Likewise.
1407 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1408 * menu.h (xmenu_show): Likewise.
1409 * term.c (term_mouse_position): Likewise.
1410 * termhooks.h (struct input_event.timestamp): Likewise.
1411 (struct terminal.mouse_position_hook): Likewise.
1412 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1413 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1414 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1415 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1417 * menu.h, termhooks.h: Include "systime.h", for Time.
1419 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1420 Don't assume that the difference between two unsigned long values
1421 can fit into an integer. At this point, we know button_down_time
1422 <= event->timestamp, so the difference must be nonnegative, so
1423 there's no need to cast the result if double-click-time is
1424 nonnegative, as it should be; check that it's nonnegative, just in
1425 case. This bug is triggered when events are more than 2**31 ms
1426 apart (about 25 days). (Bug#8664)
1428 * xselect.c (last_event_timestamp): Remove duplicate decl.
1429 (x_own_selection): Remove needless cast to unsigned long.
1431 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1432 that always fit in int. Use a sentinel instead of a counter, to
1433 avoid a temp and to allay GCC's concerns about possible int overflow.
1434 * frame.h (struct frame): Use int for menu_bar_items_used
1435 instead of EMACS_INT, since it always fits in int.
1437 * menu.c (grow_menu_items): Check for int overflow.
1439 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1441 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1442 Before, the code was not consistent. These values cannot exceed
1443 2**31 - 1 so there's no need to make them unsigned.
1444 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1445 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1446 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1448 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1450 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1451 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1452 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1453 presumably because the widths might not match.
1455 * window.c (size_window): Avoid needless test at loop start.
1457 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1459 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1461 2011-05-12 Drew Adams <drew.adams@oracle.com>
1463 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1465 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1467 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1468 `width' to `bar_area_x' and `bar_area_width', respectively.
1469 (x_scroll_run): Take account of fringe background extension.
1471 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1472 Rename local vars `left' and `width' to `bar_area_x' and
1473 `bar_area_width', respectively.
1474 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1475 background extension.
1477 2011-05-10 Jim Meyering <meyering@redhat.com>
1479 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1481 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1483 * image.c (Finit_image_library): Return t for built-in image types,
1484 like pbm and xbm. (Bug#8640)
1486 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1488 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1490 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1492 * w32console.c (Fset_screen_color): Doc fix.
1493 (Fget_screen_color): New function.
1494 (syms_of_ntterm): Defsubr it.
1496 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1497 unlink the temporary file if Fcall_process didn't create it in the
1499 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1500 child process will be redirected to a file specified with `:file'.
1501 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1502 cue to call_process_cleanup not to close that handle.
1504 2011-05-07 Ben Key <bkey76@gmail.com>
1506 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1507 one of two shell specific rules, either bootstrap-temacs-CMD or
1508 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1509 to the previous implementation of the bootstrap-temacs rule.
1510 The bootstrap-temacs-CMD rule is similar to the previous
1511 implementation of the bootstrap-temacs rule except that it
1512 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1515 These changes, along with some changes to nt/configure.bat,
1516 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1517 earlier fix to add support for --cflags and --ldflags options
1518 that include quotes so that it works whether make uses cmd or
1521 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1523 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1524 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1526 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1527 a string. Handle both cases.
1528 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1529 (Fdbus_register_method): Use Qinvalid_function.
1531 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1533 * makefile.w32-in: Update dependencies.
1534 (LISP_H): Add inttypes.h and stdin.h.
1535 (PROCESS_H): Add unistd.h.
1537 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1539 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1540 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1542 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1544 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1546 * term.c (vfatal): Remove stray call to va_end.
1547 It's not needed and the C Standard doesn't allow it here anyway.
1549 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1550 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1552 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1555 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1557 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1559 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1561 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1563 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1565 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1566 * charset.c (Fdefine_charset_internal): Don't initialize
1567 charset.code_space[15]. The value was garbage, on hosts with
1568 32-bit int (Bug#8600).
1570 * lread.c (read_integer): Be more consistent with string-to-number.
1571 Use string_to_number to do the actual conversion; this avoids
1572 rounding errors and fixes some other screwups. Without this fix,
1573 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1574 (digit_to_number): Move earlier, for benefit of read_integer.
1575 Return -1 if the digit is out of range for the base, -2 if it is
1576 not a digit in any supported base. (Bug#8602)
1578 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1580 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1581 to match comment at start of function. This also removes a
1582 GCC warning about overflow in a 32+64-bit port.
1584 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1586 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1587 Reported by Stefan Monnier in
1588 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1589 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1590 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1592 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1593 (EMACS_UINTPTR): Likewise, with uintptr_t.
1595 * lisp.h: Prefer 64-bit EMACS_INT if available.
1596 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1597 on 32-bit hosts that have 64-bit int, so that they can access
1599 However, temporarily disable this change unless the temporary
1600 symbol WIDE_EMACS_INT is defined.
1602 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1604 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1605 This removes an assumption that EMACS_INT and long are the same
1606 width as pointers. The assumption is true for Emacs porting targets
1607 now, but we want to make other targets possible.
1608 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1609 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1610 In the rest of the code, change types of integers that hold casted
1611 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1612 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1613 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1614 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1615 No need to cast type when ORing.
1616 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1617 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1618 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1619 assume EMACS_INT is the same width as char *.
1620 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1621 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1622 Remove no-longer-needed casts.
1623 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1624 (xg_tool_bar_help_callback, xg_make_tool_item):
1625 Use EMACS_INTPTR to hold an integer
1626 that will be cast to void *; this can avoid a GCC warning
1627 if EMACS_INT is not the same width as void *.
1628 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1629 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1630 (current_message_1, set_message_1):
1631 Use a local to convert to proper width without a cast.
1632 * xmenu.c (dialog_selection_callback): Likewise.
1634 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1635 Also, don't assume VALBITS / RAND_BITS is less than 5,
1636 and don't rely on undefined behavior when shifting a 1 left into
1638 * lisp.h (get_random): Change signature to match.
1640 * lread.c (hash_string): Use size_t, not int, for hash computation.
1641 Normally we prefer signed values; but hashing is special, because
1642 it's better to use unsigned division on hash table sizes so that
1643 the remainder is nonnegative. Also, size_t is the natural width
1644 for hashing into memory. The previous code used 'int', which doesn't
1645 retain enough info to hash well into very large tables.
1646 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1648 * dbusbind.c: Don't possibly lose pointer info when converting.
1649 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1650 Use XPNTR rather than XHASH, so that the high-order bits of
1651 the pointer aren't lost when converting through void *.
1653 * eval.c (Fautoload): Don't double-shift a pointer.
1655 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1657 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1659 * gnutls.c (DEF_GNUTLS_FN):
1660 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1662 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1664 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1667 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1669 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1670 New version that can reserve upto 2GB of heap space.
1672 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1674 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1676 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1678 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1679 `gnutls_certificate_set_x509_key_file'.
1681 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1683 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1684 Update dependencies.
1686 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1688 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1689 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1690 Remove unused parameter `fildes'.
1691 * process.c (read_process_output, send_process): Don't pass it.
1693 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1695 Fix previous change: the library cache is defined in w32.c.
1696 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1697 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1699 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1701 Implement dynamic loading of GnuTLS on Windows.
1703 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1704 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1705 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1708 * gnutls.c (Qgnutls_dll): Define.
1709 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1710 (gnutls_*): Declare function pointers.
1711 (init_gnutls_functions): New function to initialize function pointers.
1712 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1713 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1714 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1715 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1716 (emacs_gnutls_write, emacs_gnutls_read)
1717 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1718 (Fgnutls_available_p): New function.
1719 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1720 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1721 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1723 * image.c: Include w32.h.
1724 (Vimage_type_cache): Delete.
1725 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1726 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1727 (w32_delayed_load): Move to w32.c.
1729 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1731 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1732 (w32_delayed_load): Move from image.c. When loading a library, record
1733 its filename in the :loaded-from property of the library id.
1734 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1735 Initialize and staticpro them.
1736 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1738 * process.c: Include lisp.h before w32.h, not after.
1739 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1740 instead of gnutls_record_check_pending.
1742 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1744 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1746 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1747 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1750 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1752 * xterm.c (x_set_frame_alpha): Do not set property on anything
1753 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1755 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1757 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1759 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1761 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1762 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1763 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1764 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1765 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1766 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1767 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1768 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1769 (Qgnutls_bootprop_callbacks_verify): Make static.
1771 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1773 * callproc.c: Indentation fixup.
1775 * sysdep.c (wait_for_termination_1): Make static.
1776 (wait_for_termination, interruptible_wait_for_termination):
1777 Move after wait_for_termination_1.
1779 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1781 * sysdep.c (interruptible_wait_for_termination): New function
1782 which is like wait_for_termination, but allows keyboard
1785 * callproc.c (Fcall_process): Add (:file "file") as an option for
1787 (Fcall_process_region): Ditto.
1789 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1791 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1792 rather than `XVECTOR (FOO)->size'.
1794 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1795 inttypes.h, as a gnulib replacement is used if it not available in
1798 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1800 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1801 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1802 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1804 * coding.c (coding_alloc_by_realloc): Error out if destination
1805 will grow beyond MOST_POSITIVE_FIXNUM.
1806 (decode_coding_emacs_mule): Abort if there isn't enough place in
1807 charbuf for the composition carryover bytes. Reserve an extra
1808 space for up to 2 characters produced in a loop.
1809 (decode_coding_iso_2022): Abort if there isn't enough place in
1810 charbuf for the composition carryover bytes.
1812 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1814 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1815 aborting when %lld or %lll format is passed.
1816 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1817 %llo or %llx format is passed. (Bug#8545)
1819 * window.c (window_scroll_line_based): Use a marker instead of
1820 simple variables to record original value of point. (Bug#7952)
1822 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1823 produced by %s or %c overflows available buffer space. (Bug#8545)
1825 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1827 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1828 (SIZE_MAX): Move defn after all includes, as they might #define it.
1830 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1832 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1834 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1836 * keyboard.c (Qdelayed_warnings_hook): Define.
1837 (command_loop_1): Run `delayed-warnings-hook'
1838 if Vdelayed_warnings_list is non-nil.
1839 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1840 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1842 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1844 * doprnt.c (doprnt): Don't return value smaller than the buffer
1845 size if the message was truncated. (Bug#8545).
1847 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1849 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1850 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1852 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1854 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1856 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1858 * makefile.w32-in: Update dependencies.
1860 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1862 Improve `doprnt' and its usage. (Bug#8545)
1863 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1864 `format_end'. Remove support for %l as a conversion specifier.
1865 Don't use xrealloc. Improve diagnostics when the %l size modifier
1866 is used. Update the commentary.
1868 * eval.c (verror): Simplify calculation of size_t.
1870 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1873 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1875 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1878 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1880 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1881 This makes this file independent of the recent pseudovector change.
1883 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1885 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1887 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1888 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1889 Remove unused local.
1890 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1892 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1893 GCC 4.6.0 optimizes based on type-based alias analysis.
1894 For example, if b is of type struct buffer * and v of type struct
1895 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1896 != &v->size, and therefore "v->size = 1; b->size = 2; return
1897 v->size;" must therefore return 1. This assumption is incorrect
1898 for Emacs, since it type-puns struct Lisp_Vector * with many other
1899 types. To fix this problem, this patch adds a new type struct
1900 vectorlike_header that documents the constraints on layout of vectors
1901 and pseudovectors, and helps optimizing compilers not get fooled
1902 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1903 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1904 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1906 (XSETPVECTYPE): Rewrite in terms of new macro.
1907 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1908 This is a bit clearer, and further avoids the possibility of
1909 undesirable aliasing.
1910 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1911 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1912 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1913 since Lisp_Subr is a special case (no "next" field).
1914 (ASIZE): Now uses header.size rather than size.
1915 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1916 to avoid the hassle of writing XVECTOR (foo)->header.size.
1917 (struct vectorlike_header): New type.
1918 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1919 object, to help avoid aliasing.
1920 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1921 (SUBRP): Likewise, since Lisp_Subr is a special case.
1922 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1923 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1924 (struct Lisp_Hash_Table): Combine first two members into a single
1925 struct vectorlike_header member. All uses of "size" and "next" members
1926 changed to be "header.size" and "header.next".
1927 * buffer.h (struct buffer): Likewise.
1928 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1929 * frame.h (struct frame): Likewise.
1930 * process.h (struct Lisp_Process): Likewise.
1931 * termhooks.h (struct terminal): Likewise.
1932 * window.c (struct save_window_data, struct saved_window): Likewise.
1933 * window.h (struct window): Likewise.
1934 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1935 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1936 * buffer.c (init_buffer_once): Likewise.
1937 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1939 * process.c (Fformat_network_address): Use local var for size,
1942 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1944 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1945 * data.c (atof): Remove decl; no longer used or needed.
1946 (digit_to_number): Move to lread.c.
1947 (Fstring_to_number): Use new string_to_number function, to be
1948 consistent with how the Lisp reader treats infinities and NaNs.
1949 Do not assume that floating-point numbers represent EMACS_INT
1950 without losing information; this is not true on most 64-bit hosts.
1951 Avoid double-rounding errors, by insisting on integers when
1952 parsing non-base-10 numbers, as the documentation specifies.
1953 * lisp.h (string_to_number): New decl, replacing ...
1954 (isfloat_string): Remove.
1955 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1956 (read1): Do not accept +. and -. as integers; this
1957 appears to have been a coding error. Similarly, do not accept
1958 strings like +-1e0 as floating point numbers. Do not report
1959 overflow for integer overflows unless the base is not 10 which
1960 means we have no simple and reliable way to continue.
1961 Break out the floating-point parsing into a new
1962 function string_to_number, so that Fstring_to_number parses
1963 floating point numbers consistently with the Lisp reader.
1964 (digit_to_number): Move here from data.c. Make it static inline.
1965 (E_CHAR, EXP_INT): Remove, replacing with ...
1966 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1967 (string_to_number): New function, replacing isfloat_string.
1968 This function checks for valid syntax and produces the resulting
1969 Lisp float number too. Rework it so that string-to-number
1970 no longer mishandles examples like "1.0e+". Use strtoumax,
1971 so that overflow for non-base-10 numbers is reported only when
1972 there's no portable and simple way to convert to floating point.
1974 * textprop.c (set_text_properties_1): Rewrite for clarity,
1975 and to avoid GCC warning about integer overflow.
1977 * intervals.h (struct interval): Use EMACS_INT for members
1978 where EMACS_UINT might cause problems. See
1979 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1980 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1981 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1983 (offset_intervals): Tell GCC not to worry about length overflow
1984 when negating a negative length.
1986 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1987 (overrun_check_free): Likewise.
1989 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1990 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1993 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1994 (gnutls_make_error): Rename local to avoid shadowing.
1995 (gnutls_emacs_global_deinit): ifdef out; not used.
1996 (Fgnutls_boot): Use const for pointer to readonly storage.
1997 Comment out unused local. Fix pointer signedness problems.
1999 * lread.c (openp): Don't stuff size_t into an 'int'.
2000 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2001 about possible signed overflow.
2003 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2004 (GDK_KEY_g): Don't define if already defined.
2005 (xg_prepare_tooltip): Avoid pointer signedness problem.
2006 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2008 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2009 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2011 * xfns.c (Fx_window_property): Simplify a bit,
2012 to make a bit faster and to avoid GCC 4.6.0 warning.
2013 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2015 * fns.c (internal_equal): Don't assume size_t fits in int.
2017 * alloc.c (compact_small_strings): Tighten assertion a little.
2019 Replace pEd with more-general pI, and fix some printf arg casts.
2020 * lisp.h (pI): New macro, generalizing old pEd macro to other
2021 conversion specifiers. For example, use "...%"pI"d..." rather
2022 than "...%"pEd"...".
2023 (pEd): Remove. All uses replaced with similar uses of pI.
2024 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2025 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2026 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2027 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2028 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2029 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2030 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2032 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2033 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2034 * print.c (safe_debug_print, print_object): Likewise.
2035 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2037 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2038 avoiding the 0 flag, which is not portable.
2039 * process.c (Fmake_network_process): Use pI to avoid cast.
2040 * region-cache.c (pp_cache): Likewise.
2041 * xdisp.c (decode_mode_spec): Likewise.
2042 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2043 behavior on 64-bit hosts with printf arg.
2044 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2045 (x_stop_queuing_selection_requests): Likewise.
2046 (x_get_window_property): Don't truncate byte count to an 'int'
2049 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2050 here, since it parses constructs like leading '-' and spaces,
2051 which are not wanted; and it overflows with large numbers.
2052 Instead, simply match F[0-9]+, which is what is wanted anyway.
2054 * alloc.c: Remove unportable assumptions about struct layout.
2055 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2056 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2057 (allocate_vectorlike, make_pure_vector): Use the new macros,
2058 plus offsetof, to remove unportable assumptions about struct layout.
2059 These assumptions hold on all porting targets that I know of, but
2060 they are not guaranteed, they're easy to remove, and removing them
2061 makes further changes easier.
2063 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2064 This doesn't fix a bug but makes the code clearer.
2065 (string_overrun_cookie): Now const. Use initializers that
2066 don't formally overflow signed char, to avoid warnings.
2067 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2068 can cause Emacs to crash when string overrun checking is enabled.
2069 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2070 multiple of sizeof (EMACS_INT); it need not be, if
2071 alignof(EMACS_INT) < sizeof (EMACS_INT).
2072 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2074 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2076 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2078 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2080 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2081 supposed to be handshaking. (Bug#8556)
2082 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2084 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2086 * lisp.h (Qdebug): List symbol.
2087 * eval.c (Qdebug): Restore global linkage.
2088 * keyboard.c (debug-on-event): New variable.
2089 (handle_user_signal): Break into debugger when debug-on-event
2090 matches the current signal symbol.
2092 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2094 * alloc.c (check_sblock, check_string_bytes)
2095 (check_string_free_list): Convert to standard C.
2097 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2099 * w32.c (emacs_gnutls_push): Fix typo.
2101 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2103 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2104 "cast to pointer from integer of different size".
2106 Improve doprnt and its use in verror. (Bug#8545)
2107 * doprnt.c (doprnt): Document the set of format control sequences
2108 supported by the function. Use SAFE_ALLOCA instead of always
2111 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2112 is one byte too soon. Don't use xrealloc; instead xfree and
2115 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2117 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2120 * gnutls.c: Renamed global_initialized to
2121 gnutls_global_initialized. Added internals for the
2122 :verify-hostname-error, :verify-error, and :verify-flags
2123 parameters of `gnutls-boot' and documented those parameters in the
2124 docstring. Start callback support.
2125 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2126 unless a fatal error occured. Call gnutls_alert_send_appropriate
2127 on error. Return error code.
2128 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2129 (emacs_gnutls_read): Likewise.
2130 (Fgnutls_boot): Return handshake error code.
2131 (emacs_gnutls_handle_error): New function.
2132 (wsaerror_to_errno): Likewise.
2134 * w32.h (emacs_gnutls_pull): Add prototype.
2135 (emacs_gnutls_push): Likewise.
2137 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2138 (emacs_gnutls_push): Likewise.
2140 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2142 * process.c (wait_reading_process_output): Check if GnuTLS
2143 buffered some data internally if no FDs are set for TLS
2146 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2147 (LIBS): Link to USER_LIBS.
2148 ($(BLD)/gnutls.$(0)): New target.
2150 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2152 * xdisp.c (handle_single_display_spec): Rename the
2153 display_replaced_before_p argument into display_replaced_p, to
2154 make it consistent with the commentary. Fix typos in the
2157 * textprop.c (syms_of_textprop): Remove dead code.
2158 (copy_text_properties): Delete obsolete commentary about an
2159 interface that was deleted long ago. Fix typos in the description
2162 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2163 to changes in oldXMenu/XMenu.h from 2011-04-16.
2164 <menu_help_message, prev_menu_help_message>: Constify.
2165 (IT_menu_make_room): menu->help_text is now `const char **';
2168 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2169 to changes in oldXMenu/XMenu.h from 2011-04-16.
2170 (struct XMenu): Declare `help_text' `const char **'.
2172 * xfaces.c <Qunspecified>: Make extern again.
2174 * syntax.c: Include sys/types.h before including regex.h, as
2177 * doc.c (get_doc_string): Improve the format passed to `error'.
2179 * doprnt.c (doprnt): Improve commentary.
2181 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2183 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2186 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2187 changes in globals.h immediately force recompilation.
2188 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2189 $(CURDIR)/s/ms-w32.h.
2190 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2192 * character.c (Fchar_direction): Function deleted.
2193 (syms_of_character): Don't defsubr it.
2194 <char-direction-table>: Deleted.
2196 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2198 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2199 * doprnt.c: Include limits.h.
2200 (SIZE_MAX): New macro.
2201 (doprnt): Return a size_t value. 2nd arg is now size_t.
2202 Many local variables are now size_t instead of int or unsigned.
2203 Improve overflow protection. Support `l' modifier for integer
2204 conversions. Support %l conversion. Don't assume an EMACS_INT
2205 argument for integer conversions and for %c.
2207 * lisp.h (doprnt): Restore prototype.
2209 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2212 * Makefile.in (base_obj): Add back doprnt.o.
2214 * deps.mk (doprnt.o): Add back prerequisites.
2215 (callint.o): Depend on character.h.
2217 * eval.c (internal_lisp_condition_case): Include the handler
2218 representation in the error message.
2219 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2220 when breaking from the loop.
2222 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2224 * callint.c (Fcall_interactively): When displaying error message
2225 about invalid control letter, pass the character's codepoint, not
2226 a pointer to its multibyte form. Improve display of the character
2227 in octal and display also its hex code.
2229 * character.c (char_string): Use %x to display the (unsigned)
2230 codepoint of an invalid character, to avoid displaying a bogus
2233 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2234 `error', not SYMBOL_NAME itself.
2236 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2237 character arguments to `error'.
2239 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2240 to `error' in error message about FINAL_CHAR argument. Make sure
2241 FINAL_CHAR is a character, and use %c when it is passed as
2242 argument to `error'.
2244 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2246 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2248 * w32.c: Include <time.h>.
2249 (sys_localtime): New function.
2251 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2253 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2255 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2257 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2259 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2262 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2264 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2265 gl_state.e_property when gl_state.object is Qt.
2267 * insdel.c (make_gap_larger): Remove limitation of buffer size
2270 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2272 * xdisp.c (lookup_glyphless_char_display)
2273 (produce_glyphless_glyph): Handle cons cell entry in
2274 glyphless-char-display.
2275 (Vglyphless_char_display): Document it.
2277 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2278 glyphless-char-display.
2280 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2282 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2284 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2286 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2287 definition for no-X builds.
2289 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2291 Static checks with GCC 4.6.0 and non-default toolkits.
2293 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2295 * process.c (keyboard_bit_set): Define only if SIGIO.
2296 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2297 (send_process): Repair possible setjmp clobbering.
2299 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2301 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2303 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2305 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2306 Define only if needed.
2308 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2309 by pacifying GCC about it. Maybe it's time to retire it?
2310 * xfaces.c (USG, __TIMEVAL__): Likewise.
2312 * dispextern.h (struct redisplay_interface): Rename param
2314 * termhooks.h (struct terminal): Likewise.
2315 * xterm.c (xembed_send_message): Likewise.
2317 * insdel.c (make_gap_smaller): Define only if
2318 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2320 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2323 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2324 so that we aren't warned about unused symbols.
2326 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2328 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2330 * xfns.c (x_real_positions): Mark locals as initialized.
2332 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2334 * xterm.c: Fix problems found by static analysis with other toolkits.
2335 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2336 (x_dispatch_event): Declare static if USE_GTK, and
2337 define if USE_GTK || USE_X_TOOLKIT.
2338 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2339 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2340 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2341 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2343 * xmenu.c (menu_help_callback): Pointer type fixes.
2344 Use const pointers when pointing at readonly data. Avoid pointer
2346 (FALSE): Remove unused macro.
2347 (update_frame_menubar): Remove unused decl.
2349 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2351 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2352 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2353 (single_menu_item): Rename local to avoid shadowing.
2355 * keyboard.c (make_lispy_event): Remove unused local var.
2357 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2358 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2360 * bitmaps: Change bitmaps from unsigned char back to the X11
2361 compatible char. Avoid the old compiler warnings about
2362 out-of-range initializers by using, for example, '\xab' rather
2365 * xgselect.c (xgselect_initialize): Check vs interface
2366 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2368 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2370 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2371 to read-only memory.
2373 * fns.c (vector): Remove; this old hack is no longer needed.
2375 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2377 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2379 * xrdb.c (x_load_resources): Omit unused local.
2381 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2382 (x_window): Rename locals to avoid shadowing.
2383 (USG): Use the kludged USG macro, to pacify gcc.
2385 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2386 (x_term_init): Remove local to avoid shadowing.
2388 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2390 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2391 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2393 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2395 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2397 Fix regex.c, syntax.c and friends for buffers > 2GB.
2398 * syntax.h (struct gl_state_s): Declare character position members
2401 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2403 * textprop.c (verify_interval_modification, interval_of):
2404 Declare arguments EMACS_INT.
2406 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2409 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2411 * indent.c (Fvertical_motion): Local variable it_start is now
2414 * regex.c (re_match, re_match_2, re_match_2_internal)
2415 (bcmp_translate, regcomp, regexec, print_double_string)
2416 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2417 (re_compile_pattern, re_exec): Declare arguments and local
2418 variables `size_t' and `ssize_t' and return values `regoff_t', as
2420 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2421 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2422 <compile_stack_type>: `size' and `avail' are now `size_t'.
2424 * regex.h <regoff_t>: Use ssize_t, not int.
2425 (re_search, re_search_2, re_match, re_match_2): Arguments that
2426 specify buffer/string position and length are now ssize_t and
2427 size_t. Return type is regoff_t.
2429 2011-04-16 Ben Key <bkey76@gmail.com>
2431 * nsfont.m: Fixed bugs in ns_get_family and
2432 ns_descriptor_to_entity that were caused by using free to
2433 deallocate memory blocks that were allocated by xmalloc (via
2434 xstrdup). This caused Emacs to crash when compiled with
2435 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2436 --enable-checking=xmallocoverrun). xfree is now used to
2437 deallocate these memory blocks.
2439 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2441 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2443 emacs_write: Accept and return EMACS_INT for sizes.
2444 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2446 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2447 Accept and return EMACS_INT.
2448 (emacs_gnutls_write): Return the number of bytes written on
2450 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2451 (emacs_read, emacs_write): Remove check for negative size, as the
2452 Emacs source code has been audited now.
2453 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2454 (emacs_read, emacs_write): Use it.
2455 * process.c (send_process): Adjust to the new signatures of
2456 emacs_write and emacs_gnutls_write. Do not attempt to store
2457 a byte offset into an 'int'; it might overflow.
2458 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2460 * sound.c: Don't assume sizes fit in 'int'.
2461 (struct sound_device.period_size, alsa_period_size):
2462 Return EMACS_INT, not int.
2463 (struct sound_device.write, vox_write, alsa_write):
2464 Accept EMACS_INT, not int.
2465 (wav_play, au_play): Use EMACS_INT to store sizes and to
2466 record read return values.
2468 2011-04-15 Ben Key <bkey76@gmail.com>
2470 * keyboard.c (Qundefined): Don't declare static since it is used
2472 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2473 static since they are used in nsfont.m.
2475 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2477 * process.c (Qprocessp): Don't declare static.
2478 * lisp.h (Qprocessp): Declare again.
2480 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2482 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2484 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2486 Improve C-level modularity by making more things 'static'.
2488 Don't publish debugger-only interfaces to other modules.
2489 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2490 (verify_bytepos, count_markers): Move decls to the only modules
2492 * region-cache.h (pp_cache): Likewise.
2493 * window.h (check_all_windows): Likewise.
2494 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2496 * sysdep.c (croak): Now static, if
2497 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2498 * syssignal.h (croak): Declare only if not static.
2500 * alloc.c (refill_memory_reserve): Now static if
2501 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2502 * lisp.h (refill_memory_reserve): Declare only if not static.
2504 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2505 Define only if USE_LUCID.
2507 * xrdb.c (x_customization_string, x_rm_string): Now static.
2509 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2510 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2512 * xdisp.c (draw_row_with_mouse_face): Now static.
2513 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2515 * window.h (check_all_windows): Mark externally visible.
2517 * window.c (window_deletion_count): Now static.
2519 * undo.c: Make symbols static if they're not exported.
2520 (last_undo_buffer, last_boundary_position, pending_boundary):
2523 * textprop.c (interval_insert_behind_hooks): Now static.
2524 (interval_insert_in_front_hooks): Likewise.
2526 * term.c: Make symbols static if they're not exported.
2527 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2528 (max_frame_lines, tty_set_terminal_modes):
2529 (tty_reset_terminal_modes, tty_turn_off_highlight):
2530 (get_tty_terminal): Now static.
2531 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2532 * termhooks.h (term_mouse_moveto): Do not declare if
2534 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2535 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2537 * sysdep.c: Make symbols static if they're not exported.
2538 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2540 (sigprocmask_set, full_mask): Remove; unused.
2541 (wait_debugging): Mark as visible.
2542 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2543 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2545 * syntax.c (syntax_temp): Define only if !__GNUC__.
2547 * sound.c (current_sound_device, current_sound): Now static.
2549 * search.c (searchbufs, searchbuf_head): Now static.
2551 * scroll.c (scroll_cost): Remove; unused.
2552 * dispextern.h (scroll_cost): Remove decl.
2554 * region-cache.h (pp_cache): Mark as externally visible.
2556 * process.c: Make symbols static if they're not exported.
2557 (process_tick, update_tick, create_process, chan_process):
2558 (Vprocess_alist, proc_buffered_char, datagram_access):
2559 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2560 (deactivate_process): Mark defn as static, as well as decl.
2561 * lisp.h (create_process): Remove decl.
2562 * process.h (chan_process, Vprocess_alist): Remove decls.
2564 * print.c: Make symbols static if they're not exported.
2565 (print_depth, new_backquote_output, being_printed, print_buffer):
2566 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2567 (print_interval, print_number_index, initial_stderr_stream):
2569 * lisp.h (Fprinc): Remove decl.
2570 (debug_output_compilation_hack): Mark as externally visible.
2572 * sysdep.c (croak): Move decl from here to syssignal.h.
2573 * syssignal.h (croak): Put it here, so the API can be checked when
2574 'croak' is called from dissociate_if_controlling_tty.
2576 * minibuf.c: Make symbols static if they're not exported.
2577 (minibuf_save_list, choose_minibuf_frame): Now static.
2578 * lisp.h (choose_minibuf_frame): Remove decl.
2580 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2582 * lread.c: Make symbols static if they're not exported.
2583 (read_objects, initial_obarray, oblookup_last_bucket_number):
2585 (make_symbol): Remove; unused.
2586 * lisp.h (initial_obarray, make_symbol): Remove decls.
2588 * keyboard.c: Make symbols static if they're not exported.
2589 (single_kboard, recent_keys_index, total_keys, recent_keys):
2590 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2591 (this_single_command_key_start, echoing, last_auto_save):
2592 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2593 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2594 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2595 (Vlispy_mouse_stem, double_click_count):
2597 (force_auto_save_soon): Define only if SIGDANGER.
2598 (ignore_mouse_drag_p): Now static if
2599 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2600 (print_help): Remove; unused.
2601 (stop_character, last_timer_event): Mark as externally visible.
2602 * keyboard.h (ignore_mouse_drag_p): Declare only if
2603 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2604 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2605 * lisp.h (echoing): Remove decl.
2606 (force_auto_save_soon): Declare only if SIGDANGER.
2607 * xdisp.c (redisplay_window): Simplify code, to make it more
2608 obvious that ignore_mouse_drag_p is not accessed if !defined
2609 USE_GTK && !defined HAVE_NS.
2611 * intervals.c: Make symbols static if they're not exported.
2612 (merge_properties_sticky, merge_interval_right, delete_interval):
2614 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2616 * insdel.c: Make symbols static if they're not exported.
2617 However, leave prepare_to_modify_buffer alone. It's never
2618 called from outside this function, but that appears to be a bug.
2619 (combine_after_change_list, combine_after_change_buffer):
2620 (adjust_after_replace, signal_before_change): Now static.
2621 (adjust_after_replace_noundo): Remove; unused.
2622 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2623 (signal_before_change): Remove decls.
2625 * indent.c (val_compute_motion, val_vmotion): Now static.
2627 * image.c: Make symbols static if they're not exported.
2628 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2630 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2631 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2633 * fringe.c (standard_bitmaps): Now static.
2634 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2636 * frame.c: Make symbols static if they're not exported.
2637 (x_report_frame_params, make_terminal_frame): Now static.
2638 (get_frame_param): Now static, unless HAVE_NS.
2639 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2640 (x_get_resource_string): Remove; not used.
2641 * frame.h (make_terminal_frame, x_report_frame_params):
2642 (x_get_resource_string); Remove decls.
2643 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2644 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2646 * font.c, fontset.c: Make symbols static if they're not exported.
2647 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2648 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2649 * font.c (font_close_object): Now static.
2650 * font.h (font_close_object): Remove.
2651 * fontset.c (FONTSET_OBJLIST): Remove.
2652 (free_realized_fontset) #if-0 the body, which does nothing.
2653 (face_suitable_for_char_p): #if-0, as it's never called.
2654 * fontset.h (face_suitable_for_char_p): Remove decl.
2655 * xfaces.c (face_at_string_position):
2656 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2657 since 0 is always ASCII.
2659 * fns.c (weak_hash_tables): Now static.
2661 * fileio.c: Make symbols static if they're not exported.
2662 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2663 (Vwrite_region_annotation_buffers): Now static.
2665 * eval.c: Make symbols static if they're not exported.
2666 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2667 * lisp.h (backtrace_list): Remove decl.
2669 * emacs.c: Make symbols static if they're not exported.
2670 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2671 (fatal_error_code, fatal_error_signal_hook, standard_args):
2673 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2674 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2675 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2676 * lisp.h (fatal_error_signal_hook): Remove decl.
2677 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2679 * editfns.c: Move a (normally-unused) function to its only use.
2680 * editfns.c, lisp.h (get_operating_system_release): Remove.
2681 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2682 worth the hassle of breaking this out.
2684 * xterm.c: Make symbols static if they're not exported.
2685 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2686 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2687 (x_destroy_window, x_delete_display):
2689 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2690 (x_mouse_leave): Remove; unused.
2691 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2692 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2693 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2695 (x_mouse_leave): Declare only if WINDOWSNT.
2696 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2697 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2700 * ftxfont.c: Make symbols static if they're not exported.
2701 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2703 * font.h (ftxfont_driver): Likewise.
2705 * xfns.c: Make symbols static if they're not exported.
2706 (x_last_font_name, x_display_info_for_name):
2707 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2708 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2709 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2710 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2711 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2712 (last_show_tip_args): Now static.
2713 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2714 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2715 (x_screen_planes): Remove; unused.
2716 * dispextern.h (x_screen_planes): Remove decl.
2718 * dispnew.c: Make symbols static if they're not exported.
2719 * dispextern.h (redraw_garbaged_frames, scrolling):
2720 (increment_row_positions): Remove.
2721 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2722 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2724 (redraw_garbaged_frames): Remove; unused.
2726 * xfaces.c: Make symbols static if they're not exported.
2727 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2729 * xterm.h (defined_color): Remove decls.
2730 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2731 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2732 (menu_face_changed_default, defined_color, free_realized_face):
2733 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2734 (ascii_face_of_lisp_face): Remove; unused.
2736 * xdisp.c: Make symbols static if they're not exported.
2737 * dispextern.h (scratch_glyph_row, window_box_edges):
2738 (glyph_to_pixel_coords, set_cursor_from_row):
2739 (get_next_display_element, set_iterator_to_next):
2740 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2741 (show_mouse_face): Remove decls
2742 * frame.h (message_buf_print): Likewise.
2743 * lisp.h (pop_message, set_message, check_point_in_composition):
2745 * xterm.h (set_vertical_scroll_bar): Likewise.
2746 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2747 (message_buf_print, scratch_glyph_row, displayed_buffer):
2748 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2749 (get_next_display_element, show_mouse_face, window_box_edges):
2750 (frame_to_window_pixel_xy, check_point_in_composition):
2751 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2752 (glyph_to_pixel_coords): Remove; unused.
2754 * dired.c (file_name_completion): Now static.
2756 * dbusbind.c (xd_in_read_queued_messages): Now static.
2758 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2759 * data.c (circular_list_error): Remove.
2761 * commands.h (last_point_position, last_point_position_buffer):
2762 (last_point_position_window): Remove decls.
2763 * keyboard.c: Make these variables static.
2765 * coding.h (coding, code_convert_region, encode_coding_gap):
2767 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2768 (iso_code_class, detect_coding, code_convert_region): Now static.
2769 (encode_coding_gap): Remove; unused.
2771 * chartab.c (chartab_chars, chartab_bits): Now static.
2773 * charset.h (charset_iso_8859_1): Remove decl.
2774 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2777 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2778 * ccl.c (Vccl_program_table): Now static.
2779 (check_ccl_update): Remove; unused.
2781 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2782 * category.h: ... from here.
2783 * category.c (check_category_table, set_category_set): Now static.
2785 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2786 * lisp.h: Remove these decls.
2788 * buffer.c (buffer_count): Remove unused var.
2790 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2791 so that it's not optimized away.
2792 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2793 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2794 exported only to the debugger.
2796 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2797 * atimer.h (run_all_atimers): Remove; not exported.
2799 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2800 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2801 was inaccessible from Lisp.
2802 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2803 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2805 alloc.c: Import and export fewer symbols, and remove unused items.
2806 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2808 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2809 it's not optimized away by whole-program optimization.
2810 (message_enable_multibyte, free_misc): Remove.
2811 (catchlist, handlerlist, mark_backtrace):
2812 Declare only if BYTE_MARK_STACK.
2813 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2814 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2815 (message_enable_multibyte): Remove decl.
2816 (free_misc, interval_free_list, float_block, float_block_index):
2817 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2818 (cons_free_list, last_marked_index):
2820 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2821 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2822 (mark_backtrace): Define only if BYTE_MARK_STACK.
2823 * xdisp.c (message_enable_multibyte): Now static.
2825 Declare Lisp_Object Q* variables to be 'static' if not exported.
2826 This makes it easier for human readers (and static analyzers)
2827 to see whether these variables are used from other modules.
2828 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2829 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2830 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2831 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2832 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2833 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2834 * xmenu.c, xselect.c:
2835 Declare Q* vars static if they are not used in other modules.
2836 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2837 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2838 Remove decls of unexported vars.
2839 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2841 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2843 Make Emacs functions such as Fatom 'static' by default.
2844 This makes it easier for human readers (and static analyzers)
2845 to see whether these functions can be called from other modules.
2846 DEFUN now defines a static function. To make the function external
2847 so that it can be used in other C modules, use the new macro DEFUE.
2848 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2849 (Finit_image_library):
2850 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2851 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2852 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2853 Remove decls, since these functions are now static.
2854 (Funintern, Fget_internal_run_time): New decls, since these functions
2855 were already external.
2857 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2858 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2859 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2860 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2861 * keyboard.c, keymap.c, lread.c:
2862 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2863 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2864 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2865 Mark functions with DEFUE instead of DEFUN,
2866 if they are used in other modules.
2867 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2868 decls for now-static functions.
2869 * buffer.h (Fdelete_overlay): Remove decl.
2870 * callproc.c (Fgetenv_internal): Mark as internal.
2871 * composite.c (Fremove_list_of_text_properties): Remove decl.
2872 (Fcomposition_get_gstring): New forward static decl.
2873 * composite.h (Fcomposite_get_gstring): Remove decl.
2874 * dired.c (Ffile_attributes): New forward static decl.
2875 * doc.c (Fdocumntation_property): New forward static decl.
2876 * eval.c (Ffetch_bytecode): New forward static decl.
2877 (Funintern): Remove extern decl; now in .h file where it belongs.
2878 * fileio.c (Fmake_symbolic_link): New forward static decl.
2879 * image.c (Finit_image_library): New forward static decl.
2880 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2881 * intervals.h (Fprevious_property_change):
2882 (Fremove_list_of_text_properties): Remove decls.
2883 * keyboard.c (Fthis_command_keys): Remove decl.
2884 (Fcommand_execute): New forward static decl.
2885 * keymap.c (Flookup_key): New forward static decl.
2886 (Fcopy_keymap): Now static.
2887 * keymap.h (Flookup_key): Remove decl.
2888 * process.c (Fget_process): New forward static decl.
2889 (Fprocess_datagram_address): Mark as internal.
2890 * syntax.c (Fsyntax_table_p): New forward static decl.
2891 (skip_chars): Remove duplicate decl.
2892 * textprop.c (Fprevious_property_change): New forward static decl.
2893 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2895 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2896 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2898 * editfns.c (Fformat): Remove unreachable code.
2900 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2902 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2905 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2907 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2908 when at ZV. (Bug#8487)
2910 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2912 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2914 * keyboard.c (parse_tool_bar_item): Likewise.
2915 * sound.c (sound_cleanup, alsa_close): Likewise.
2916 * termcap.c (tgetent): Likewise.
2917 * xfns.c (x_default_font_parameter): Likewise.
2918 * xsettings.c (read_and_apply_settings): Likewise.
2920 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2921 (overrun_check_free): Protoize.
2923 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2925 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2926 since callers should never pass a negative size.
2927 Change the signature to match that of plain 'read' and 'write'; see
2928 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2929 * lisp.h: Update prototypes of emacs_write and emacs_read.
2931 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2933 * xdisp.c (redisplay_window): Don't try to determine the character
2934 position of the scroll margin if the window start point w->startp
2935 is outside the buffer's accessible region. (Bug#8468)
2937 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2939 Fix write-region and its subroutines for buffers > 2GB.
2940 * fileio.c (a_write, e_write): Modify declaration of arguments and
2941 local variables to support buffers larger than 2GB.
2942 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2944 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2945 argument, local variables, and return value.
2947 * lisp.h: Update prototypes of emacs_write and emacs_read.
2949 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2951 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2953 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2955 Fix more problems found by GCC 4.6.0's static checks.
2957 * xdisp.c (vmessage): Use a better test for character truncation.
2959 * charset.c (load_charset_map): <, not <=, for optimization,
2960 and to avoid potential problems with integer overflow.
2961 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2962 * casetab.c (set_identity, shuffle): Likewise.
2963 * editfns.c (Fformat): Likewise.
2964 * syntax.c (skip_chars): Likewise.
2966 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2967 This also lets GCC 4.6.0 generate slightly better loop code.
2969 * callint.c (Fcall_interactively): <, not <=, for optimization.
2970 (Fcall_interactively): Count the number of arguments produced,
2971 not the number of arguments given. This is simpler and lets GCC
2972 4.6.0 generate slightly better code.
2974 * ftfont.c: Distingish more carefully between FcChar8 and char.
2975 The previous code passed unsigned char * to a functions like
2976 strlen and xstrcasecmp that expect char *, which does not
2977 conform to the C standard.
2978 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2979 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2980 char * when the C standard requires it.
2982 * keyboard.c (read_char): Remove unused var.
2984 * eval.c: Port to Windows vsnprintf (Bug#8435).
2986 (SIZE_MAX): Define if the headers do not.
2987 (verror): Do not give up if vsnprintf returns a negative count.
2988 Instead, grow the buffer. This ports to Windows vsnprintf, which
2989 does not conform to C99. Problem reported by Eli Zaretskii.
2990 Also, simplify the allocation scheme, by avoiding the need for
2991 calling realloc, and removing the ALLOCATED variable.
2993 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2995 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2996 But keep the doprint source code for now, as we might revamp it
2997 and use it again (Bug#8435).
2998 * lisp.h (doprnt): Remove.
2999 * Makefile.in (base_obj): Remove doprnt.o.
3000 * deps.mk (doprnt.o): Remove.
3002 error: Print 32- and 64-bit integers portably (Bug#8435).
3003 Without this change, on typical 64-bit hosts error ("...%d...", N)
3004 was used to print both 32- and 64-bit integers N, which relied on
3006 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3008 * lisp.h (error, verror): Mark as printf-like functions.
3009 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3010 Report overflow in size calculations when allocating printf buffer.
3011 Do not truncate output string at its first null byte.
3012 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3013 Truncate the output at a character boundary, since vsnprintf does not
3015 * charset.c (check_iso_charset_parameter): Convert internal
3016 character to string before calling 'error', since %c now has the
3018 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3019 overflow when computing char to be passed to 'error'. Do not
3020 pass Lisp_Object to 'error'; pass the integer instead.
3021 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3022 formatted with plain %d.
3024 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3026 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3028 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3030 * xterm.c (x_catch_errors): Remove duplicate declaration.
3032 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3034 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3036 2011-04-10 Jim Meyering <meyering@redhat.com>
3038 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3039 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3040 return ssize_t not "int", and use size_t as the buffer length.
3041 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3042 * gnutls.h: Update declarations.
3043 * process.c (read_process_output): Use ssize_t, to match.
3044 (send_process): Likewise.
3046 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3048 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3050 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3052 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3053 Use unsigned char, to match FcChar8 type definition.
3055 * xterm.c (handle_one_xevent):
3056 * xmenu.c (create_and_show_popup_menu):
3057 * xselect.c (x_decline_selection_request)
3058 (x_reply_selection_request): Avoid type-punned deref of X events.
3060 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3062 Fix some uses of `int' instead of EMACS_INT.
3063 * search.c (string_match_1, fast_string_match)
3064 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3065 (scan_buffer, find_next_newline_no_quit)
3066 (find_before_next_newline, search_command, Freplace_match)
3067 (Fmatch_data): Make some `int' variables be EMACS_INT.
3069 * xdisp.c (display_count_lines): 3rd argument and return value now
3070 EMACS_INT. All callers changed.
3071 (pint2hrstr): Last argument is now EMACS_INT.
3073 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3074 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3075 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3076 (decode_coding_utf_16, decode_coding_emacs_mule)
3077 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3078 (decode_coding_ccl, decode_coding_charset)
3079 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3080 (decode_coding_iso_2022, decode_coding_emacs_mule)
3081 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3082 <char_offset, last_offset>: Declare EMACS_INT.
3083 (encode_coding_utf_8, encode_coding_utf_16)
3084 (encode_coding_emacs_mule, encode_invocation_designation)
3085 (encode_designation_at_bol, encode_coding_iso_2022)
3086 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3087 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3089 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3090 (encode_invocation_designation): Last argument P_NCHARS is now
3092 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3093 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3095 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3098 * ccl.c (Fccl_execute_on_string): Declare some variables
3101 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3103 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3105 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3107 * process.c (Fformat_network_address): Doc fix.
3109 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3111 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3113 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3115 * keyboard.c (read_char): Call Lisp function help-form-show,
3116 instead of using internal_with_output_to_temp_buffer.
3117 (Qhelp_form_show): New var.
3118 (syms_of_keyboard): Use DEFSYM macro.
3120 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3122 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3124 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3126 * process.c (Flist_processes): Remove to Lisp.
3127 (list_processes_1): Delete.
3129 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3131 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3133 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3135 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3137 Fix more problems found by GCC 4.6.0's static checks.
3139 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3141 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3143 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3145 * xdisp.c (vmessage): Mark as a printf-like function.
3147 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3149 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3151 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3152 printf-like functions.
3153 (tiff_load): Add casts to remove these marks before passing them
3154 to system-supplied API.
3156 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3158 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3159 This avoids several warnings with gcc -Wstrict-overflow.
3160 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3161 directly, rather than having caller test rule sign. This avoids
3162 some unnecessary tests.
3163 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3164 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3165 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3167 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3168 (xfont_open): Avoid unnecessary tests.
3170 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3172 * composite.h, composite.c (composition_gstring_put_cache):
3173 Use EMACS_INT, not int, for length.
3175 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3176 breaking out part of COMPOSITION_DECODE_RULE.
3177 (COMPOSITION_DECODE_RULE): Use it.
3178 * composite.c (get_composition_id): Remove unused local vars,
3179 by using the new macro.
3181 * textprop.c (set_text_properties_1): Change while to do-while,
3182 since the condition is always true at first.
3184 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3185 (interval_deletion_adjustment): Return unsigned value.
3188 * process.c (list_processes_1, create_pty, read_process_output):
3189 (exec_sentinel): Remove vars that were set but not used.
3190 (create_pty): Remove unnecessary "volatile"s.
3191 (Fnetwork_interface_info): Avoid possibility of int overflow.
3192 (read_process_output): Do adaptive read buffering even if carryover.
3193 (read_process_output): Simplify nbytes computation if buffered.
3195 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3197 * syntax.c (scan_words): Remove var that was set but not used.
3198 (update_syntax_table): Use unsigned instead of int.
3200 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3201 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3202 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3204 * print.c (print_error_message): Avoid int overflow.
3206 * font.c (font_list_entities): Redo for clarity,
3207 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3209 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3210 (font_score): Avoid potential overflow in diff calculation.
3212 * fns.c (substring_both): Remove var that is set but not used.
3213 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3215 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3217 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3218 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3219 can always succeed if overflow has undefined behavior.
3221 * search.c (boyer_moore, wordify): Remove vars set but not used.
3222 (wordify): Omit three unnecessary tests.
3224 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3225 All callers changed. This avoids the need for an unused var.
3227 * casefiddle.c (casify_region): Remove var that is set but not used.
3229 * dired.c (file_name_completion): Remove var that is set but not used.
3231 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3233 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3234 (Finsert_file_contents): Remove unnecessary code checking fd.
3236 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3237 Check for integer overflow on size calculations.
3239 * buffer.c (Fprevious_overlay_change): Remove var that is set
3242 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3243 Remove vars that are set but not used.
3244 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3245 (timer_check_2): Mark vars as initialized.
3247 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3249 * image.c (lookup_image): Remove var that is set but not used.
3250 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3252 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3253 that are set but not used.
3255 * xfns.c (make_invisible_cursor): Don't return garbage
3256 if XCreateBitmapFromData fails (Bug#8410).
3258 * xselect.c (x_get_local_selection, x_handle_property_notify):
3259 Remove vars that are set but not used.
3261 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3262 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3264 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3265 Remove var that is set but not used.
3266 (scroll_bar_windows_size): Now size_t, not int.
3267 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3270 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3271 (map_tty_color) [!defined MSDOS]: Likewise.
3273 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3275 * coding.c: Remove vars that are set but not used.
3276 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3277 All callers changed.
3278 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3279 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3280 (decode_coding_charset): Remove vars that are set but not used.
3282 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3283 that is set but not used.
3285 * print.c (print_object): Remove var that is set but not used.
3287 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3288 The gnulib version avoids calling malloc in the usual case,
3289 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3290 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3291 * filelock.c (current_lock_owner): Likewise.
3292 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3293 * sysdep.c: Include allocator.h, careadlinkat.h.
3294 (emacs_no_realloc_allocator): New static constant.
3295 (emacs_readlink): New function.
3296 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3297 ../lib/careadlinkat.h.
3299 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3301 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3302 first non-nil return value).
3304 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3306 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3307 if not defined (Bug#8403).
3309 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3311 * xdisp.c (display_count_lines): Remove parameter `start',
3312 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3313 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3314 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3315 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3316 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3317 and thereabouts. All callers changed.
3318 (get_per_char_metric): Remove parameter `f', unused since
3319 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3321 2011-04-02 Jim Meyering <meyering@redhat.com>
3323 do not dereference NULL upon failed strdup
3324 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3325 (ns_get_family): Likewise.
3327 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3329 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3331 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3333 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3336 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3338 Add lexical binding.
3340 * window.c (Ftemp_output_buffer_show): New fun.
3341 (Fsave_window_excursion):
3342 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3344 * lread.c (lisp_file_lexically_bound_p): New function.
3345 (Fload): Bind Qlexical_binding.
3346 (readevalloop): Remove `evalfun' arg.
3347 Bind Qinternal_interpreter_environment.
3348 (Feval_buffer): Bind Qlexical_binding.
3349 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3351 (syms_of_lread): Declare `lexical-binding'.
3353 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3355 * keyboard.c (eval_dyn): New fun.
3356 (menu_item_eval_property): Use it.
3358 * image.c (parse_image_spec): Use Ffunctionp.
3360 * fns.c (concat, mapcar1): Accept byte-code-functions.
3362 * eval.c (Fsetq): Handle lexical vars.
3363 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3364 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3365 (FletX, Flet): Obey lexical binding.
3366 (Fcommandp): Handle closures.
3367 (Feval): New `lexical' arg.
3368 (eval_sub): New function extracted from Feval. Use it almost
3369 everywhere where Feval was used. Look up vars in lexical env.
3371 (Ffunctionp): Move from subr.el.
3372 (Ffuncall): Handle closures.
3373 (apply_lambda): Remove `eval_flags'.
3374 (funcall_lambda): Handle closures and new byte-code-functions.
3375 (Fspecial_variable_p): New function.
3376 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3377 but without exporting it to Lisp.
3379 * doc.c (Fdocumentation, store_function_docstring):
3380 * data.c (Finteractive_form): Handle closures.
3382 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3385 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3387 (exec_byte_code): New function extracted from Fbyte_code to handle new
3388 calling convention for byte-code-functions. Add new byte-codes.
3390 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3392 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3394 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3396 * xdisp.c (redisplay_internal): Fix prototype.
3398 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3400 * xdisp.c (SCROLL_LIMIT): New macro.
3401 (try_scrolling): Use it when setting scroll_limit.
3402 Limit scrolling to 100 screen lines.
3403 (redisplay_window): Even when falling back on "recentering",
3404 position point in the window according to scroll-conservatively,
3405 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3407 (try_scrolling): When point is above the window, allow searching
3408 as far as scroll_max, or one screenful, to compute vertical
3409 distance from PT to the scroll margin position. This prevents
3410 try_scrolling from unnecessarily failing when
3411 scroll-conservatively is set to a value slightly larger than the
3412 window height. Clean up the case of PT below the margin at bottom
3413 of window: scroll_max can no longer be INT_MAX. When aggressive
3414 scrolling is in use, don't let point enter the opposite scroll
3415 margin as result of the scroll.
3416 (syms_of_xdisp) <scroll-conservatively>: Document the
3417 threshold of 100 lines for never-recentering scrolling.
3419 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3421 * dispextern.h (move_it_by_lines):
3422 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3423 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3424 (message_log_check_duplicate): Remove parameters `prev_bol' and
3425 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3426 (redisplay_internal): Remove parameter `preserve_echo_area',
3427 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3429 * indent.c (Fvertical_motion):
3430 * window.c (window_scroll_pixel_based, Frecenter):
3431 Don't pass `need_y_p' to `move_it_by_lines'.
3433 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3435 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3436 steal a few bits to be more compact.
3437 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3438 Remove unneeded casts.
3440 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3442 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3444 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3445 binding" message (bug#7967).
3447 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3449 Fix more problems found by GCC 4.6.0's static checks.
3451 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3452 Remove unused local var.
3454 * editfns.c (Fmessage_box): Remove unused local var.
3456 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3457 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3458 Omit unused local vars.
3459 * window.c (shrink_windows): Omit unused local var.
3460 * menu.c (digest_single_submenu): Omit unused local var.
3461 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3462 Omit unused local var.
3464 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3465 Don't assume string length fits in int.
3466 (keyremap_step, read_key_sequence): Use size_t for sizes.
3467 (read_key_sequence): Don't check last_real_key_start redundantly.
3469 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3470 instead of alloca (Bug#8344).
3472 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3473 (Fbacktrace_frame): Don't assume nframes fits in int.
3475 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3477 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3480 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3482 * cm.c (calccost): Turn while-do into do-while, for clarity.
3484 * keyboard.c (syms_of_keyboard): Use the same style as later
3485 in this function when indexing through an array. This also
3486 works around GCC bug 48267.
3488 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3490 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3492 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3493 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3495 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3496 This avoids undefined behavior on integer overflow, and is a bit
3497 more convenient anyway since it is compared to a size_t variable.
3499 Variadic C functions now count arguments with size_t, not int.
3500 This avoids an unnecessary limitation on 64-bit machines, which
3501 caused (substring ...) to crash on large vectors (Bug#8344).
3502 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3503 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3504 All variadic functions and their callers changed accordingly.
3505 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3506 * data.c (arith_driver, float_arith_driver): Likewise.
3507 * editfns.c (general_insert_function): Likewise.
3508 * eval.c (struct backtrace.nargs, interactive_p)
3509 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3510 (funcall_lambda, mark_backtrace): Likewise.
3511 * fns.c (concat): Likewise.
3512 * frame.c (x_set_frame_parameters): Likewise.
3513 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3514 0 if not found, not -1. All callers changed.
3516 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3517 (stack_copy_size): Now size_t, not int.
3518 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3520 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3522 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3523 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3524 All callers changed.
3526 * lisp.h (multibyte_char_to_unibyte):
3527 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3528 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3529 * character.h (CHAR_TO_BYTE8):
3530 * cmds.c (internal_self_insert):
3531 * editfns.c (general_insert_function):
3532 * keymap.c (push_key_description):
3533 * search.c (Freplace_match):
3534 * xdisp.c (message_dolog, set_message_1): All callers changed.
3536 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3538 * keyboard.c (safe_run_hook_funcall): New function.
3539 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3540 don't set the hook to nil, but remove the offending function instead.
3541 (Qcommand_hook_internal): Remove, unused.
3542 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3543 Vcommand_hook_internal.
3545 * eval.c (enum run_hooks_condition): Remove.
3546 (funcall_nil, funcall_not): New functions.
3547 (run_hook_with_args): Call each function through a `funcall' argument.
3548 Remove `cond' argument, now redundant.
3549 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3550 (Frun_hook_with_args_until_failure): Adjust accordingly.
3551 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3553 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3555 * dispextern.h (string_buffer_position): Remove declaration.
3557 * print.c (strout): Remove parameter `multibyte', unused since
3558 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3560 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3561 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3562 All callers changed.
3564 * w32.c (_wsa_errlist): Use braces for struct initializers.
3566 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3567 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3568 All callers changed.
3569 (string_buffer_position): Likewise. Also, make static (it's never
3570 used outside xdisp.c).
3571 (cursor_row_p): Remove parameter `w', unused since
3572 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3573 (decode_mode_spec): Remove parameter `precision', introduced during
3574 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3575 All callers changed.
3577 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3579 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3581 2011-03-27 Anders Lindgren <andlind@gmail.com>
3583 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3584 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3585 (ns_update_auto_hide_menu_bar): New functions.
3586 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3587 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3588 ns_constrain_all_frames.
3589 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3590 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3592 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3594 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3596 2011-03-27 Glenn Morris <rgm@gnu.org>
3598 * syssignal.h: Replace RETSIGTYPE with void.
3599 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3600 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3601 Replace SIGTYPE with void everywhere.
3602 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3603 * s/template.h (SIGTYPE): Remove commented out definition.
3605 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3607 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3608 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3610 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3612 * w32.c (read_unc_volume): Use parameter `henum', instead of
3613 global variable `wget_enum_handle'.
3615 * keymap.c (describe_vector): Remove parameters `indices' and
3616 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3617 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3619 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3621 * keyboard.c (timer_check): Remove parameter `do_it_now',
3622 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3623 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3624 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3626 * keyboard.c (read_char):
3627 * w32menu.c (w32_menu_display_help):
3628 * xmenu.c (show_help_event, menu_help_callback):
3629 Adjust calls to `show_help_echo'.
3631 * gtkutil.c (xg_maybe_add_timer):
3632 * keyboard.c (readable_events):
3633 * process.c (wait_reading_process_output):
3634 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3636 * insdel.c (adjust_markers_gap_motion):
3637 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3638 (gap_left, gap_right): Don't call it.
3640 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3642 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3643 incurred during fontification.
3645 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3647 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3648 (DEFVAR_PER_BUFFER): Don't pass it.
3650 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3651 (scrolling_window): Don't pass it.
3653 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3655 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3657 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3659 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3660 of variables specific to SELinux and computation of `encoded_absname'.
3662 * image.c (XPutPixel): Remove unused variable `height'.
3664 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3666 * unexw32.c (get_section_info): Remove unused variable `section'.
3668 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3669 (system_process_attributes): Remove unused variable `sess'.
3670 (sys_read): Remove unused variable `err'.
3672 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3673 (w32_wnd_proc): Remove unused variable `isdead'.
3674 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3675 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3676 (x_create_tip_frame): Remove unused variable `tem'.
3678 * w32inevt.c (w32_console_read_socket):
3679 Remove unused variable `no_events'.
3681 * w32term.c (x_draw_composite_glyph_string_foreground):
3682 Remove unused variable `width'.
3684 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3686 * w32term.c (x_set_glyph_string_clipping):
3687 Don't pass uninitialized region to CombineRgn.
3689 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3691 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3692 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3693 (Fx_close_connection): Remove unused variable `i'.
3695 * w32font.c (w32font_draw): Return number of glyphs.
3696 (w32font_open_internal): Remove unused variable `i'.
3697 (w32font_driver): Add missing initializer.
3699 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3700 (fill_in_menu): Remove unused variable `items_added'.
3702 * w32term.c (last_mouse_press_frame): Remove static global variable.
3703 (w32_clip_to_row): Remove unused variable `f'.
3704 (x_delete_terminal): Remove unused variable `i'.
3706 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3707 (NOTHING): Remove unused static global variable.
3708 (uniscribe_check_otf): Remove unused variable `table'.
3709 (uniscribe_font_driver): Add missing initializers.
3711 2011-03-23 Julien Danjou <julien@danjou.info>
3713 * term.c (Fsuspend_tty, Fresume_tty):
3714 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3715 * window.c (temp_output_buffer_show):
3716 * insdel.c (signal_before_change):
3717 * frame.c (Fhandle_switch_frame):
3718 * fileio.c (Fdo_auto_save):
3719 * emacs.c (Fkill_emacs):
3720 * editfns.c (save_excursion_restore):
3721 * cmds.c (internal_self_insert):
3722 * callint.c (Fcall_interactively):
3723 * buffer.c (Fkill_all_local_variables):
3724 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3726 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3727 unconditionnaly since it does the check itself.
3729 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3731 Fix more problems found by GCC 4.5.2's static checks.
3733 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3734 the first time through the loop, since we know p0 < p1 then.
3735 This also avoids a gcc -Wstrict-overflow warning.
3737 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3738 leading to a memory leak, possible in functions like
3739 load_charset_map_from_file that can allocate an unbounded number
3740 of objects (Bug#8318).
3742 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3743 that could (at least in theory) be that large.
3745 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3746 This is less likely to overflow, and avoids undefined behavior if
3747 overflow does occur. All callers changed. Use strtoul to scan
3748 for the unsigned long integer.
3749 (pint2hrstr): Simplify and tune code slightly.
3750 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3752 * scroll.c (do_scrolling): Work around GCC bug 48228.
3753 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3755 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3756 This also avoids a warning with gcc -Wstrict-overflow.
3757 (validate_x_resource_name): Simplify count usage.
3758 This also avoids a warning with gcc -Wstrict-overflow.
3760 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3763 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3765 * process.c (Fmake_network_process): Use socklen_t, not int,
3766 where POSIX says socklen_t is required in portable programs.
3767 This fixes a porting bug on hosts like 64-bit HP-UX, where
3768 socklen_t is wider than int (Bug#8277).
3769 (Fmake_network_process, server_accept_connection):
3770 (wait_reading_process_output, read_process_output):
3773 * process.c: Rename or move locals to avoid shadowing.
3774 (list_processes_1, Fmake_network_process):
3775 (read_process_output_error_handler, exec_sentinel_error_handler):
3776 Rename or move locals.
3777 (Fmake_network_process): Define label "retry_connect" only if needed.
3778 (Fnetwork_interface_info): Fix pointer signedness.
3779 (process_send_signal): Add cast to avoid pointer signedness problem.
3780 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3781 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3783 Make tparam.h and terminfo.c consistent.
3784 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3785 Include tparam.h instead, since it declares them.
3786 * cm.h (PC): Remove extern decl; tparam.h now does this.
3787 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3788 * terminfo.c: Include tparam.h, to check interfaces.
3789 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3790 (tparam): Adjust signature to match interface in tparam.h;
3791 this removes some undefined behavior. Check that outstring and len
3792 are zero, which they always are with Emacs.
3793 * tparam.h (PC, BC, UP): New extern decls.
3795 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3796 (xftfont_open): Rename locals to avoid shadowing.
3798 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3799 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3800 (OTF_TAG_SYM): Omit macro if not needed.
3801 (ftfont_list): Remove unused local.
3802 (get_adstyle_property, ftfont_pattern_entity):
3803 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3804 Rename locals to avoid shadowing.
3806 * xfont.c (xfont_list_family): Mark var as initialized.
3808 * xml.c (make_dom): Now static.
3810 * composite.c (composition_compute_stop_pos): Rename local to
3812 (composition_reseat_it): Remove unused locals.
3813 (find_automatic_composition, composition_adjust_point): Likewise.
3814 (composition_update_it): Mark var as initialized.
3815 (find_automatic_composition): Mark vars as initialized,
3816 with a FIXME (Bug#8290).
3818 character.h: Rename locals to avoid shadowing.
3819 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3820 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3821 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3822 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3825 * textprop.c (property_change_between_p): Remove; unused.
3827 * intervals.c (interval_start_pos): Now static.
3829 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3831 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3832 Rename locals to avoid shadowing.
3834 * sound.c (wav_play, au_play, Fplay_sound_internal):
3835 Fix pointer signedness.
3836 (alsa_choose_format): Remove unused local var.
3837 (wav_play): Initialize a variable to 0, to prevent undefined
3838 behavior (Bug#8278).
3840 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3842 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3844 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3845 clobbering (Bug#8298).
3846 * sysdep.c (sys_subshell): Likewise.
3847 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3849 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3850 This should get cleaned up, so that child_setup has the
3851 same signature on all platforms.
3853 * callproc.c (call_process_cleanup): Now static.
3854 (relocate_fd): Rename locals to avoid shadowing.
3856 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3858 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3859 not to be necessary, and produces flickering.
3861 2011-03-20 Glenn Morris <rgm@gnu.org>
3863 * config.in: Remove file.
3865 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3867 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3868 are now in src/globals.h.
3869 (syms_of_minibuf): Remove spurious & from previous change.
3871 2011-03-20 Leo <sdl.web@gmail.com>
3873 * minibuf.c (completing-read-function): New variable.
3874 (completing-read-default): Rename from completing-read.
3875 (completing-read): Call completing-read-function.
3877 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3879 * xfaces.c (Fx_load_color_file):
3880 Read color file from absolute filename (bug#8250).
3882 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3884 * makefile.w32-in: Update dependencies.
3886 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3888 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3890 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3892 Fix more problems found by GCC 4.5.2's static checks.
3894 * process.c (make_serial_process_unwind, send_process_trap):
3895 (sigchld_handler): Now static.
3897 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3898 That way, the code declares only the vars that it needs.
3899 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3900 * s/cygwin.h (PTY_ITERATION): Likewise.
3901 * s/darwin.h (PTY_ITERATION): Likewise.
3902 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3904 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3905 * process.c (allocate_pty): Don't declare stb unless it's needed.
3907 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3908 (CONSTANTLIM): Remove; unused.
3909 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3910 Define only if needed.
3912 * unexelf.c (unexec): Name an expression,
3913 to avoid gcc -Wbad-function-cast warning.
3914 Use a different way to cause a compilation error if anyone uses
3915 n rather than nn, a way that does not involve shadowing.
3916 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3918 * deps.mk (unexalpha.o): Remove; unused.
3920 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3921 * unexec.h: New file.
3922 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3923 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3925 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3926 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3927 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3928 Change as necessary to match prototype in unexec.h.
3930 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3932 (back_comment, skip_chars): Mark vars as initialized.
3934 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3935 Rename locals to avoid shadowing.
3937 * lread.c (read1): Rewrite so as not to use empty "else".
3938 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3940 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3942 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3943 warning when compiling print.c.
3945 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3946 instead of using an uninitialized var.
3947 (font_sort_entities): Mark var as initialized.
3949 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3951 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3952 pointers to constants.
3953 (font_parse_fcname): Remove unused vars.
3954 (font_delete_unmatched): Now static.
3955 (font_get_spec): Remove; unused.
3956 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3957 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3958 Rename or move locals to avoid shadowing.
3960 * fns.c (require_nesting_list, require_unwind): Now static.
3961 (Ffillarray): Rename locals to avoid shadowing.
3963 * floatfns.c (domain_error2): Define only if needed.
3964 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3966 * alloc.c (mark_backtrace): Move decl from here ...
3967 * lisp.h: ... to here, so that it can be checked.
3969 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3970 (Fdefvar): Rewrite so as not to use empty "else".
3971 (lisp_indirect_variable): Name an expression,
3972 to avoid gcc -Wbad-function-cast warning.
3973 (Fdefvar): Rename locals to avoid shadowing.
3975 * callint.c (quotify_arg, quotify_args): Now static.
3976 (Fcall_interactively): Rename locals to avoid shadowing.
3977 Use const pointer when appropriate.
3979 * lisp.h (get_system_name, get_operating_system_release):
3980 Move decls here, to check interfaces.
3981 * process.c (get_operating_system_release): Move decl to lisp.h.
3982 * xrdb.c (get_system_name): Likewise.
3983 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3984 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3985 some of which prompt warnings from gcc -Wbad-function-cast.
3986 (Fformat_time_string, Fencode_time, Finsert_char):
3987 (Ftranslate_region_internal, Fformat):
3988 Rename or remove local vars to avoid shadowing.
3989 (Ftranslate_region_internal): Mark var as initialized.
3991 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3994 * lisp.h (eassert): Check that the argument compiles, even if
3995 ENABLE_CHECKING is not defined.
3997 * data.c (Findirect_variable): Name an expression, to avoid
3998 gcc -Wbad-function-cast warning.
3999 (default_value, arithcompare, arith_driver, arith_error): Now static.
4000 (store_symval_forwarding): Rename local to avoid shadowing.
4001 (Fmake_variable_buffer_local, Fmake_local_variable):
4002 Mark variables as initialized.
4003 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4005 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4006 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4007 Rename locals to avoid shadowing.
4008 (mark_stack): Move local variables into the #ifdef region where
4010 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4011 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4013 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4014 (GC_STRING_CHARS): Remove; not used.
4015 (Fmemory_limit): Cast sbrk's returned value to char *.
4017 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4018 avoids undefined behavior in theory.
4020 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4022 Use functions, not macros, for up- and down-casing (Bug#8254).
4023 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4024 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4025 to use the following functions instead of these macros.
4026 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4027 EMACS_INT, since callers assume the returned value fits in int.
4028 (upcase1): Likewise, for UPCASE_TABLE.
4029 (uppercasep, lowercasep, upcase): New static inline functions.
4030 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4031 the race-condition problem in the old DOWNCASE.
4033 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4034 Rename locals to avoid shadowing.
4035 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4036 (regex_compile, re_search_2, re_match_2_internal):
4037 Remove unused local vars.
4038 (FREE_VAR): Rewrite so as not to use empty "else",
4039 which gcc can warn about.
4040 (regex_compile, re_match_2_internal): Mark locals as initialized.
4041 (RETALLOC_IF): Define only if needed.
4042 (WORDCHAR_P): Likewise. This one is never needed, but is used
4043 only in a comment talking about a compiler bug, so put inside
4044 the #if 0 of that comment.
4045 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4046 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4049 * search.c (boyer_moore): Rename locals to avoid shadowing.
4050 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4051 (PREV_CHAR_BOUNDARY): Likewise.
4053 * search.c (simple_search): Remove unused var.
4055 * dired.c (compile_pattern): Move decl from here ...
4056 * lisp.h: ... to here, so that it can be checked.
4057 (struct re_registers): New forward decl.
4059 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4061 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4063 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4064 Rename locals to avoid shadowing.
4065 (Fvertical_motion): Mark locals as initialized.
4067 * casefiddle.c (casify_object, casify_region): Now static.
4068 (casify_region): Mark local as initialized.
4070 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4072 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4073 New macros, so that the caller can use some names other than
4074 gcpro1, gcpro2, etc.
4075 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4077 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4078 argument, for consistency with GCPRO2_VAR, etc: it is now the
4079 prefix of the variable, not the variable itself. All uses
4081 * dired.c (directory_files_internal, file_name_completion):
4082 Rename locals to avoid shadowing.
4084 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4085 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4086 dired.c's scmp function, had undefined behavior.
4087 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4088 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4089 * buffer.h: ... to here, because these macros use current_buffer,
4090 and the new implementation with inline functions needs to have
4091 current_buffer in scope now, rather than later when the macros
4093 (downcase, upcase1): New static inline functions.
4094 (DOWNCASE, UPCASE1): Reimplement using these functions.
4095 This avoids undefined behavior in expressions like
4096 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4097 from race conditions in accessing the global variables
4098 case_temp1 and case_temp2.
4099 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4100 * lisp.h (case_temp1, case_temp2): Remove their decls.
4101 * character.h (ASCII_CHAR_P): Move from here ...
4102 * lisp.h: ... to here, so that the inline functions mentioned
4105 * dired.c (directory_files_internal_unwind): Now static.
4107 * fileio.c (file_name_as_directory, directory_file_name):
4108 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4110 (file_name_as_directory): Use const pointers when appropriate.
4111 (Fexpand_file_name): Likewise. In particular, newdir might
4112 point at constant storage, so make it a const pointer.
4113 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4114 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4116 (Fset_file_times, Finsert_file_contents, auto_save_error):
4117 Rename locals to avoid shadowing.
4119 * minibuf.c (choose_minibuf_frame_1): Now static.
4120 (Ftry_completion, Fall_completions): Rename or remove locals
4123 * marker.c (bytepos_to_charpos): Remove; unused.
4125 * lisp.h (verify_bytepos, count_markers): New decls,
4126 so that gcc does not warn that these functions aren't declared.
4128 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4129 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4130 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4131 (copy_text): Remove unused local var.
4133 * filelock.c (within_one_second): Now static.
4134 (lock_file_1): Rename local to avoid shadowing.
4136 * buffer.c (fix_overlays_before): Mark locals as initialized.
4137 (fix_start_end_in_overlays): Likewise. This function should be
4138 simplified by using pointers-to-pointers, but that's a different
4140 (switch_to_buffer_1): Now static.
4141 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4142 (report_overlay_modification): Rename locals to avoid shadowing.
4144 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4145 Fix pointer signedness issue.
4146 (sys_subshell): Mark local as volatile if checking for lint,
4147 to suppress a gcc -Wclobbered warning that does not seem to be right.
4148 (MAXPATHLEN): Define only if needed.
4150 * process.c (serial_open, serial_configure): Move decls from here ...
4151 * systty.h: ... to here, so that they can be checked.
4153 * fns.c (get_random, seed_random): Move extern decls from here ...
4154 * lisp.h: ... to here, so that they can be checked.
4156 * sysdep.c (reset_io): Now static.
4157 (wait_for_termination_signal): Remove; unused.
4159 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4160 (copy_keymap_item, append_key, push_text_char_description):
4162 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4163 (DENSE_TABLE_SIZE): Remove; unused.
4164 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4165 (describe_map_tree):
4166 Rename locals to avoid shadowing.
4168 * keyboard.c: Declare functions static if they are not used elsewhere.
4169 (echo_char, echo_dash, cmd_error, top_level_2):
4170 (poll_for_input, handle_async_input): Now static.
4171 (read_char, kbd_buffer_get_event, make_lispy_position):
4172 (make_lispy_event, make_lispy_movement, apply_modifiers):
4173 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4174 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4175 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4176 (read_key_sequence, read_char): Mark locals as initialized.
4177 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4179 * keyboard.h (make_ctrl_char): New decl.
4180 (mark_kboards): Move decl here ...
4181 * alloc.c (mark_kboards): ... from here.
4183 * lisp.h (force_auto_save_soon): New decl.
4185 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4186 (DEFINE_DUMMY_FUNCTION): New macro.
4187 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4189 (main): Add casts to avoid warnings
4190 if GCC considers string literals to be constants.
4192 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4194 * dbusbind.c: Pointer signedness fixes.
4195 (xd_signature, xd_append_arg, xd_initialize):
4196 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4197 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4198 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4199 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4201 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4202 if GCC considers string literals to be constants.
4203 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4205 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4207 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4208 (print_preprocess, print_object): New macro to fix last change.
4210 * print.c (print_preprocess): Don't forget font objects.
4212 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4214 * emacs.c (USAGE3): Doc fixes.
4216 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4218 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4221 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4223 * lisp.h (VWindow_system, Qfile_name_history):
4224 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4225 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4226 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4228 * w32select.c: Don't #include "keyboard.h".
4229 (run_protected): Add extern declaration for waiting_for_input.
4231 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4232 * w32console.c (detect_input_pending, read_input_pending)
4233 (encode_terminal_code):
4234 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4235 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4236 (w32_system_caret_y, Qfile_name_history):
4237 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4238 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4239 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4240 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4241 * w32proc.c (Qlocal, report_file_error):
4242 * w32term.c (Vwindow_system, updating_frame):
4243 * w32uniscribe.c (initialized, uniscribe_font_driver):
4244 Remove unneeded extern declarations.
4246 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4248 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4250 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4252 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4253 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4254 These macros can no longer be used for assignment.
4256 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4257 Assign struct members directly, instead of using BUF_BEGV etc.
4258 (record_buffer_markers, fetch_buffer_markers): New functions for
4259 recording and fetching special buffer markers.
4260 (set_buffer_internal_1, set_buffer_temp): Use them.
4262 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4264 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4266 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4267 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4269 * xdisp.c (hscroll_window_tree):
4270 (reconsider_clip_changes): Use PT instead of BUF_PT.
4272 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4274 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4275 $(EMACS_ROOT)/lib/intprops.h.
4277 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4279 Fix more problems found by GCC 4.5.2's static checks.
4281 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4282 to unsigned char * to avoid compiler diagnostic.
4283 (xg_free_frame_widgets): Make it clear that a local variable is
4284 needed only if USE_GTK_TOOLTIP.
4285 (gdk_window_get_screen): Make it clear that this macro is needed
4286 only if USE_GTK_TOOLTIP.
4287 (int_gtk_range_get_value): New function, which avoids a diagnostic
4288 from gcc -Wbad-function-cast.
4289 (xg_set_toolkit_scroll_bar_thumb): Use it.
4290 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4291 diagnostic from gcc -Wbad-function-cast.
4292 (get_utf8_string, xg_get_file_with_chooser):
4293 Rename locals to avoid shadowing.
4294 (create_dialog): Move locals to avoid shadowing.
4296 * xgselect.c (xg_select): Remove unused var.
4298 * image.c (four_corners_best): Mark locals as initialized.
4299 (gif_load): Initialize transparent_p to zero (Bug#8238).
4300 Mark another local as initialized.
4301 (my_png_error, my_error_exit): Mark with NO_RETURN.
4303 * image.c (clear_image_cache): Now static.
4304 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4305 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4306 (x_edge_detection): Remove unnecessary cast that
4307 gcc -Wbad-function-cast diagnoses.
4308 (gif_load): Fix pointer signedness.
4309 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4310 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4312 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4314 Improve quality of tests for time stamp overflow.
4315 For example, without this patch (encode-time 0 0 0 1 1
4316 1152921504606846976) returns the obviously-bogus value (-948597
4317 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4318 reports time overflow. See
4319 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4320 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4321 * editfns.c: Include limits.h and intprops.h.
4322 (TIME_T_MIN, TIME_T_MAX): New macros.
4323 (time_overflow): Move earlier, to before first use.
4324 (hi_time, lo_time): New functions, for an accurate test for
4326 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4327 (Fget_internal_run_time): Don't assume time_t fits in int.
4328 (make_time): Use list2 instead of Fcons twice.
4329 (Fdecode_time): More accurate test for out-of-range times.
4330 (check_tm_member): New function.
4331 (Fencode_time): Use it, to test for out-of-range times.
4332 (lisp_time_argument): Don't rely on undefined left-shift and
4333 right-shift behavior when checking for time stamp overflow.
4335 * editfns.c (time_overflow): New function, refactoring common code.
4336 (Fformat_time_string, Fdecode_time, Fencode_time):
4337 (Fcurrent_time_string): Use it.
4339 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4340 * dired.c (make_time): Move to ...
4341 * editfns.c (make_time): ... here.
4342 * systime.h: Note the move.
4344 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4346 * fringe.c (update_window_fringes): Remove unused variables.
4348 * unexmacosx.c (copy_data_segment): Also copy __got section.
4351 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4353 * termcap.c [MSDOS]: Include "msdos.h".
4354 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4355 Constify `char *' arguments and their references according to
4356 prototypes in tparam.h.
4358 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4360 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4361 Adapt all references accordingly.
4363 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4365 2011-03-11 Tom Tromey <tromey@redhat.com>
4367 * buffer.c (syms_of_buffer): Remove obsolete comment.
4369 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4371 * termhooks.h (encode_terminal_code): Declare prototype.
4373 * msdos.c (encode_terminal_code): Don't declare prototype.
4375 * term.c (encode_terminal_code): Now external again, used by
4376 w32console.c and msdos.c.
4378 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4379 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4381 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4383 Fix some minor problems found by GCC 4.5.2's static checks.
4385 * fringe.c (update_window_fringes): Mark locals as initialized
4387 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4389 * alloc.c (mark_fringe_data): Move decl from here ...
4390 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4391 to check its interface.
4392 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4394 * fontset.c (free_realized_fontset): Now static.
4395 (Fset_fontset_font): Rename local to avoid shadowing.
4396 (fontset_font): Mark local as initialized.
4397 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4399 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4401 * xselect.c (x_disown_buffer_selections): Remove; not used.
4402 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4403 (x_own_selection, Fx_disown_selection_internal): Rename locals
4405 (x_handle_dnd_message): Remove local to avoid shadowing.
4407 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4408 so that the caller can use some name other than gcpro1.
4409 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4410 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4411 (Fx_backspace_delete_keys_p):
4412 Use them to avoid shadowing, and rename vars to avoid shadowing.
4413 (x_decode_color, x_set_name, x_window): Now static.
4414 (Fx_create_frame): Add braces to silence GCC warning.
4415 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4416 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4417 Remove unused locals.
4418 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4419 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4420 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4423 * xterm.h (x_mouse_leave): New decl.
4425 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4426 Remove unused functions.
4427 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4428 (x_calc_absolute_position): Now static.
4429 (XTread_socket): Don't define label "out" unless it's used.
4430 Don't declare local "event" unless it's used.
4431 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4432 unless they are used.
4433 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4434 (x_fatal_error_signal): Remove; not used.
4435 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4436 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4437 (x_error_catcher, x_connection_closed, x_error_handler):
4438 (x_error_quitter, xembed_send_message, x_iconify_frame):
4439 (my_log_handler): Rename locals to avoid shadowing.
4440 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4441 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4443 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4444 Rename or move locals to avoid shadowing.
4445 (tty_defined_color, merge_face_heights): Now static.
4446 (free_realized_faces_for_fontset): Remove; not used.
4447 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4448 does not deduce is never used uninitialized.
4449 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4450 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4452 * terminal.c (store_terminal_param): Now static.
4454 * xmenu.c (menu_highlight_callback): Now static.
4455 (set_frame_menubar): Remove unused local.
4456 (xmenu_show): Rename parameter to avoid shadowing.
4457 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4458 since they might point to immutable storage.
4459 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4460 since it's unused otherwise.
4462 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4463 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4464 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4465 avoids a gcc -Wuninitialized diagnostic.
4466 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4467 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4468 does not deduce are never used uninitialized.
4470 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4472 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4473 * window.c (window_loop, size_window):
4474 (run_window_configuration_change_hook, enlarge_window): Likewise.
4476 * window.c (display_buffer): Now static.
4477 (size_window): Mark variables that gcc -Wuninitialized
4478 does not deduce are never used uninitialized.
4479 * window.h (check_all_windows): New decl, to forestall
4480 gcc -Wmissing-prototypes diagnostic.
4481 * dispextern.h (bidi_dump_cached_states): Likewise.
4483 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4485 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4487 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4488 and to avoid gcc -Wuninitialized warning.
4489 (load_charset_map): Mark variables that gcc -Wuninitialized
4490 does not deduce are never used uninitialized.
4491 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4493 * coding.c (coding_set_source, coding_set_destination):
4494 Use "else { /* comment */ }" rather than "else /* comment */;"
4495 for clarity, and to avoid gcc -Wempty-body warning.
4496 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4497 a block, when the outer 'i' will do.
4498 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4499 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4500 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4501 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4502 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4503 Rename locals to avoid shadowing.
4504 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4505 * coding.c (emacs_mule_char, encode_invocation_designation):
4506 Now static, since they're not used elsewhere.
4507 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4508 (decode_coding_object, encode_coding_object, detect_coding_system):
4509 (decode_coding_emacs_mule): Mark variables that gcc
4510 -Wuninitialized does not deduce are never used uninitialized.
4511 (detect_coding_iso_2022): Initialize a local variable that might
4512 be used uninitialized. Leave a FIXME because it's not clear that
4513 this initialization is needed. (Bug#8211)
4514 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4515 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4516 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4517 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4518 Remove unused macros.
4520 * category.c (hash_get_category_set): Remove unused local var.
4521 (copy_category_table): Now static, since it's not used elsewhere.
4522 * character.c (string_count_byte8): Likewise.
4524 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4525 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4527 * chartab.c (copy_sub_char_table): Now static, since it's not used
4529 (sub_char_table_ref_and_range, char_table_ref_and_range):
4530 Rename locals to avoid shadowing.
4531 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4533 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4534 (BIDI_BOB): Remove unused macro.
4536 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4537 deduce are never used uninitialized.
4538 * term.c (encode_terminal_code): Likewise.
4540 * term.c (encode_terminal_code): Now static. Remove unused local.
4542 * tparam.h: New file.
4543 * term.c, tparam.h: Include it.
4544 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4545 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4546 Move these decls to tparam.h, and make them agree with what
4547 is actually in tparam.c. The previous trick of using incompatible
4548 decls in different modules does not conform to the C standard.
4549 All callers of tparam changed to use tparam's actual API.
4550 * tparam.c (tparam1, tparam, tgoto):
4551 Use const pointers where appropriate.
4553 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4554 * cm.h (struct cm): Likewise.
4555 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4556 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4557 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4558 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4559 (turn_on_face, init_tty): Likewise.
4560 * termchar.h (struct tty_display_info): Likewise.
4562 * term.c (term_mouse_position): Rename local to avoid shadowing.
4564 * alloc.c (mark_ttys): Move decl from here ...
4565 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4567 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4569 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4571 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4573 * search.c (compile_pattern_1): Remove argument regp, unused since
4574 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4575 (compile_pattern): Don't pass it.
4577 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4579 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4580 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4582 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4584 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4586 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4587 gdk_window_get_screen, gdk_window_get_geometry,
4588 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4589 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4590 (xg_get_pixbuf_from_pixmap): New function.
4591 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4592 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4593 Call xg_get_pixbuf_from_pixmap instead of
4594 gdk_pixbuf_get_from_drawable.
4595 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4596 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4597 (xg_check_special_colors): Use GtkStyleContext and its functions
4599 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4600 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4601 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4602 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4603 Call gtk_widget_get_preferred_size.
4604 (xg_frame_resized): gdk_window_get_geometry only takes 5
4606 (xg_win_to_widget, xg_event_is_for_menubar):
4607 Call gdk_x11_window_lookup_for_display.
4608 (xg_set_widget_bg): New function.
4609 (delete_cb): New function.
4610 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4611 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4612 (xg_set_background_color): Call xg_set_widget_bg.
4613 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4614 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4615 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4616 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4618 (update_frame_tool_bar): Call gtk_widget_hide.
4619 (xg_initialize): Use GDK_KEY_g.
4621 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4623 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4625 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4626 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4627 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4629 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4631 * w32xfns.c (select_palette): Check success of RealizePalette against
4632 GDI_ERROR, not zero.
4634 See ChangeLog.11 for earlier changes.
4640 Copyright (C) 2011 Free Software Foundation, Inc.
4642 This file is part of GNU Emacs.
4644 GNU Emacs is free software: you can redistribute it and/or modify
4645 it under the terms of the GNU General Public License as published by
4646 the Free Software Foundation, either version 3 of the License, or
4647 (at your option) any later version.
4649 GNU Emacs is distributed in the hope that it will be useful,
4650 but WITHOUT ANY WARRANTY; without even the implied warranty of
4651 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4652 GNU General Public License for more details.
4654 You should have received a copy of the GNU General Public License
4655 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.