Fix bug #11587 with a crash in an Info buffer under linum-mode.
[bpt/emacs.git] / src / ChangeLog
1 2012-05-30 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (handle_stop): Detect whether we have overlay strings
4 loaded by testing it->current.overlay_string_index to be
5 non-negative, instead of checking whether n_overlay_strings is
6 positive. (Bug#11587)
7
8 2012-05-30 Chong Yidong <cyd@gnu.org>
9
10 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
11
12 * doc.c (Fsubstitute_command_keys): Doc fix.
13
14 2012-05-29 Eli Zaretskii <eliz@gnu.org>
15
16 * search.c (search_buffer): Remove calls to
17 r_alloc_inhibit_buffer_relocation, as it is now called by
18 maybe_unify_char, which was the cause of relocation of buffer text
19 in bug#11519.
20
21 2012-05-23 Eli Zaretskii <eliz@gnu.org>
22
23 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
24 for the duration of call to load_charset, to avoid problems with
25 callers of maybe_unify_char that access buffer text through C
26 pointers.
27
28 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
29 decrement the inhibition flag, instead of just setting or
30 resetting it.
31
32 2012-05-24 Ken Brown <kbrown@cornell.edu>
33
34 * callproc.c (Fcall_process): Restore a line that was accidentally
35 commented out in the 2011-02-13 change (bug#11547).
36
37 2012-05-23 Eli Zaretskii <eliz@gnu.org>
38
39 * lisp.h [REL_ALLOC]: Add prototypes for external functions
40 defined on ralloc.c.
41
42 * buffer.c [REL_ALLOC]: Remove prototypes of
43 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
44 they are now on lisp.h.
45
46 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
47
48 * search.c (search_buffer): Use it to inhibit relocation of buffer
49 text while re_search_2 is doing its job, because re_search_2 is
50 passed C pointers to buffer text. (Bug#11519)
51
52 2012-05-21 Eli Zaretskii <eliz@gnu.org>
53
54 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
55 Update value to 24.
56
57 2012-05-19 Eli Zaretskii <eliz@gnu.org>
58
59 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
60 state after an additional call to move_it_in_display_line_to, keep
61 the values of it->max_ascent and it->max_descent found for the
62 entire line.
63 (pos_visible_p): Revert the comparison against bottom_y to what it
64 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
65 (Bug#11464)
66
67 2012-05-15 Eli Zaretskii <eliz@gnu.org>
68
69 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
70
71 2012-05-13 Eli Zaretskii <eliz@gnu.org>
72
73 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
74 already have overlays loaded.
75 (handle_single_display_spec): Before returning without displaying
76 fringe bitmap, synchronize the bidi iterator with the main display
77 iterator, by calling iterate_out_of_display_property.
78 (iterate_out_of_display_property): Detect buffer iteration by
79 testing that it->string is a Lisp string.
80 (get_next_display_element): When the current object is exhausted,
81 and there's something on it->stack, call set_iterator_to_next to
82 proceed with what's on the stack, instead of returning zero.
83 (set_iterator_to_next): If called at the end of a Lisp string,
84 proceed to consider_string_end without incrementing string
85 position. Don't increment display vector index past the end of
86 the display vector. (Bug#11417)
87 (pos_visible_p): Don't report a position visible when move_it_to
88 stopped at the last line of window, which happens to be scanned
89 backwards by the bidi iteration. (Bug#11464)
90
91 2012-05-11 Eli Zaretskii <eliz@gnu.org>
92
93 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
94 and right-margin display specs even if the spec is invalid or we
95 are on a TTY, and thus unable to display on the fringes. That's
96 because the text with the property will not be displayed anyway,
97 so we need to signal to the caller that this is a "replacing"
98 display spec. This fixes display when the spec is invalid or we
99 are on a TTY.
100
101 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
102
103 * unexaix.c (make_hdr): Fix typo in prototype.
104 This bug broke the build on AIX. Problem reported by Gilles Pion.
105
106 2012-05-05 Eli Zaretskii <eliz@gnu.org>
107
108 * w32proc.c (new_child): Force Windows to reserve only 64KB of
109 stack for each reader_thread, instead of defaulting to 8MB
110 determined by the linker. This avoids failures in creating
111 subprocesses on Windows 7, see the discussion in this thread:
112 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
113
114 2012-05-02 Jim Meyering <meyering@redhat.com>
115
116 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
117
118 2012-04-29 Eli Zaretskii <eliz@gnu.org>
119
120 * xdisp.c (pos_visible_p): If already at a newline from the
121 display string before the 'while' loop, don't walk back the glyphs
122 from it3.glyph_row. Solves assertion violation when the display
123 string begins with a newline (egg.el). (Bug#11367)
124
125 2012-04-24 Chong Yidong <cyd@gnu.org>
126
127 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
128
129 2012-04-23 Eli Zaretskii <eliz@gnu.org>
130
131 * xdisp.c (pos_visible_p): If the window start position is beyond
132 ZV, start the display from buffer beginning. Prevents assertion
133 violation in init_iterator when the minibuffer window is scrolled
134 via the scroll bar.
135
136 * window.c (window_scroll_pixel_based): Likewise.
137
138 2012-04-23 Chong Yidong <cyd@gnu.org>
139
140 * keymap.c (where_is_internal): Doc fix (Bug#10872).
141
142 2012-04-20 Glenn Morris <rgm@gnu.org>
143
144 * fileio.c (Fcopy_file, Fset_file_selinux_context):
145 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
146
147 2012-04-20 Eli Zaretskii <eliz@gnu.org>
148
149 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
150 overrun array limits of glyph row's used[] array. (Bug#11288)
151
152 2012-04-20 Chong Yidong <cyd@gnu.org>
153
154 * process.c (wait_reading_process_output): If EIO occurs on a pty,
155 set the status to "failed" and ensure that sentinel is run.
156
157 2012-04-18 Glenn Morris <rgm@gnu.org>
158
159 * process.c (Fset_process_inherit_coding_system_flag)
160 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
161 (Fmake_network_process, Fmake_serial_process): Doc fix.
162
163 2012-04-17 Eli Zaretskii <eliz@gnu.org>
164
165 * xdisp.c (string_buffer_position_lim): Limit starting position to
166 BEGV.
167 (set_cursor_from_row): If called for a mode-line or header-line
168 row, return zero immediately.
169 (try_cursor_movement): If inside continuation line, don't back up
170 farther than the first row after the header line, if any. Don't
171 consider the header-line row as "partially visible", even if
172 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
173
174 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
175
176 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
177
178 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
179
180 * process.c (make_process):
181 * process.h: Add integer `gnutls_handshakes_tried' member to
182 process struct.
183
184 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
185 Add convenience `GNUTLS_LOG2i' macro.
186
187 * gnutls.c (gnutls_log_function2i): Convenience log function.
188 (emacs_gnutls_read): Use new log functions,
189 `gnutls_handshakes_tried' process member, and
190 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
191 attempts per process (connection).
192
193 2012-04-09 Eli Zaretskii <eliz@gnu.org>
194
195 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
196 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
197
198 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
199
200 * nsterm.m (constrainFrameRect): Always constrain when there is only
201 one screen (Bug#10962).
202
203 2012-04-06 Eli Zaretskii <eliz@gnu.org>
204
205 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
206 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
207 about subtle differences between FETCH_CHAR* and STRING_CHAR*
208 macros related to unification of CJK characters. For the details,
209 see the discussion following the message here:
210 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
211
212 2012-04-04 Chong Yidong <cyd@gnu.org>
213
214 * keyboard.c (Vdelayed_warnings_list): Doc fix.
215
216 2012-04-01 Eli Zaretskii <eliz@gnu.org>
217
218 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
219 instead of alloca. (Bug#11138)
220
221 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
222
223 * w32menu.c (is_simple_dialog): Properly check lisp types.
224 (Bug#11141)
225
226 2012-03-31 Eli Zaretskii <eliz@gnu.org>
227
228 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
229 position we get to after a call to move_it_to fails the
230 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
231 only if we wind up in a string from display property. (Bug#11063)
232
233 * window.c (Fdelete_other_windows_internal): Invalidate the row
234 and column information about mouse highlight, so that redisplay
235 restores it after reallocating the glyph matrices. (Bug#7464)
236
237 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
238 string comes from a `display' text property, use the buffer
239 position of that property as if we actually saw that position in
240 the row's glyphs.
241 (move_it_by_lines): Remove the assertion that
242 "it->current_x == 0 && it->hpos == 0" which can be legitimately
243 violated when there's a before-string at the beginning of a line.
244 (Bug#11063)
245
246 2012-03-30 Eli Zaretskii <eliz@gnu.org>
247
248 * xdisp.c (append_space_for_newline): If the default face was
249 remapped, use the remapped face for the appended newline.
250 (extend_face_to_end_of_line): Use the remapped default face for
251 extending the face to the end of the line.
252 (display_line): Call extend_face_to_end_of_line when the default
253 face was remapped. (Bug#11068)
254
255 2012-03-29 Eli Zaretskii <eliz@gnu.org>
256
257 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
258
259 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
260
261 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
262
263 2012-03-27 Glenn Morris <rgm@gnu.org>
264
265 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
266 Doc fixes.
267
268 2012-03-26 Kenichi Handa <handa@m17n.org>
269
270 * dispextern.h (struct glyph): Fix previous change. Change the
271 bit length of glyphless.ch to 25 (Bug#11082).
272
273 2012-03-26 Chong Yidong <cyd@gnu.org>
274
275 * keyboard.c (Vselection_inhibit_update_commands): New variable.
276 (command_loop_1): Use it; inhibit selection update for
277 handle-select-window too (Bug#8996).
278
279 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
280
281 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
282
283 2012-03-25 Kenichi Handa <handa@m17n.org>
284
285 * dispextern.h (struct glyph): Change the bit length of
286 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
287
288 2012-03-24 Eli Zaretskii <eliz@gnu.org>
289
290 * s/ms-w32.h (tzname): Include time.h before redirecting to
291 _tzname. Fixes the MSVC build. (Bug#9960)
292
293 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
294
295 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
296 characters.
297
298 * xterm.c (XTread_socket): Only modify handling_signal if
299 !SYNC_INPUT. (Bug#11080)
300
301 2012-03-23 Eli Zaretskii <eliz@gnu.org>
302
303 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
304 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
305 when fetching a multibyte character consumes more bytes than
306 CHAR_BYTES returns, due to unification of CJK characters in
307 string_char. (Bug#11073)
308
309 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
310
311 * process.c (wait_reading_process_output): Handle pty disconnect
312 by refraining from sending oneself a SIGCHLD (bug#10933).
313
314 2012-03-22 Chong Yidong <cyd@gnu.org>
315
316 * dispextern.h (struct it): New member string_from_prefix_prop_p.
317
318 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
319 Mark string as coming from a prefix property.
320 (handle_face_prop): Use default face for prefix strings (Bug#4281).
321 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
322
323 2012-03-21 Chong Yidong <cyd@gnu.org>
324
325 * xfaces.c (Vface_remapping_alist): Doc fix.
326
327 2012-03-20 Eli Zaretskii <eliz@gnu.org>
328
329 * w32proc.c (Fw32_set_console_codepage)
330 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
331 Doc fixes.
332
333 2012-03-20 Chong Yidong <cyd@gnu.org>
334
335 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
336 to reflect default non-nil value of redisplay-dont-pause.
337
338 2012-03-19 Kenichi Handa <handa@m17n.org>
339
340 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
341 it fit in a valid range (Bug#11003).
342
343 2012-03-18 Eli Zaretskii <eliz@gnu.org>
344
345 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
346 that is not from display property, accept the row as a "cursor
347 row" if one of the string's character has a non-nil `cursor'
348 property. Fixes cursor positioning when there are newlines in
349 overlay strings, e.g. in icomplete.el. (Bug#11035)
350
351 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
352
353 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
354
355 2012-03-12 Chong Yidong <cyd@gnu.org>
356
357 * eval.c (inhibit_lisp_code): Rename from
358 inhibit_window_configuration_change_hook; move from window.c.
359
360 * xfns.c (unwind_create_frame_1, Fx_create_frame):
361 * window.c (run_window_configuration_change_hook)
362 (syms_of_window): Callers changed.
363
364 2012-03-11 Chong Yidong <cyd@gnu.org>
365
366 * keymap.c (Fkey_description): Doc fix (Bug#9700).
367
368 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
369
370 2012-03-10 Chong Yidong <cyd@gnu.org>
371
372 * frame.c (other_visible_frames): Don't assume the selected frame
373 is visible (Bug#10955).
374
375 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
376
377 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
378
379 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
380
381 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
382 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
383 zero (Bug#10954).
384
385 2012-03-03 Glenn Morris <rgm@gnu.org>
386
387 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
388
389 2012-03-02 Eli Zaretskii <eliz@gnu.org>
390
391 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
392 position past the first glyph_row that ends at ZV. (Bug#10902)
393 (redisplay_window, next_element_from_string): Fix typos in
394 comments.
395 (redisplay_window): Pass to move_it_vertically the margin in
396 pixels, not in screen lines.
397
398 2012-03-02 Glenn Morris <rgm@gnu.org>
399
400 * buffer.c (buffer-list-update-hook): Doc fix.
401
402 2012-02-29 Eli Zaretskii <eliz@gnu.org>
403
404 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
405 push_it before setting up the iterator for the first overlay
406 string, even if we have an empty string loaded.
407 (next_overlay_string): If there's an empty string on the iterator
408 stack, pop the stack. (Bug#10903)
409
410 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
411
412 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
413 Suggested by Stefan Monnier in
414 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
415 * alloc.c (widen_to_Lisp_Object): New static function.
416 (mark_memory): Also mark Lisp_Objects by fetching pointer words
417 and widening them to Lisp_Objects. This would work even if
418 USE_LSB_TAG is defined and wide integers are used, which might
419 happen in a future version of Emacs.
420
421 2012-02-25 Chong Yidong <cyd@gnu.org>
422
423 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
424 Doc fix.
425
426 * xselect.c (Fx_selection_exists_p): Doc fix.
427 (x_clipboard_manager_save_all): Print an informative message
428 before saving to clipboard manager.
429
430 2012-02-24 Chong Yidong <cyd@gnu.org>
431
432 * keyboard.c (process_special_events): Handle all X selection
433 requests in kbd_buffer, not just the next one (Bug#8869).
434
435 2012-02-23 Chong Yidong <cyd@gnu.org>
436
437 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
438 call when setting menu-bar-lines and tool-bar-lines parameters.
439 (unwind_create_frame_1): New helper function.
440
441 * window.c (inhibit_window_configuration_change_hook): New var.
442 (run_window_configuration_change_hook): Obey it.
443 (syms_of_window): Initialize it.
444
445 2012-02-22 Chong Yidong <cyd@gnu.org>
446
447 * xterm.c (x_draw_image_relief): Add missing type check for
448 Vtool_bar_button_margin (Bug#10743).
449
450 2012-02-21 Chong Yidong <cyd@gnu.org>
451
452 * fileio.c (Vfile_name_handler_alist): Doc fix.
453
454 * buffer.c (Fget_file_buffer): Protect against invalid file
455 handler return value.
456
457 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
458
459 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
460 when computing $valmask.
461
462 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
463 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
464 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
465 It's useless in that case, and it can cause problems on hosts
466 that allocate halves of EMACS_INT values separately.
467 Reported by Dan Horák. Diagnosed by Andreas Schwab in
468 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
469 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
470 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
471 it avoids undefined behavior on hosts where shifting right by more
472 than the word width has undefined behavior.
473
474 2012-02-19 Chong Yidong <cyd@gnu.org>
475
476 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
477 (Funhandled_file_name_directory, Ffile_name_as_directory)
478 (Fdirectory_file_name, Fexpand_file_name)
479 (Fsubstitute_in_file_name): Protect against invalid file handler
480 return values (Bug#10845).
481
482 2012-02-18 Eli Zaretskii <eliz@gnu.org>
483
484 * .gdbinit (pitx): Fix incorrect references to fields of the
485 iterator stack.
486
487 2012-02-17 Chong Yidong <cyd@gnu.org>
488
489 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
490
491 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
492
493 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
494 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
495
496 2012-02-15 Chong Yidong <cyd@gnu.org>
497
498 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
499 marked as special. Also, starting docstrings with * is obsolete.
500
501 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
502
503 * gnutls.c (emacs_gnutls_write): Fix last change.
504
505 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
506
507 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
508 send_process.
509
510 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
511
512 * keymap.c (Fsingle_key_description): Handle char ranges.
513
514 2012-02-12 Chong Yidong <cyd@gnu.org>
515
516 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
517 as that creates a dangerous corner case.
518
519 * window.c (Fdelete_window_internal): Invalidate the mouse
520 highlight (Bug#9904).
521
522 2012-02-12 Glenn Morris <rgm@gnu.org>
523
524 * xselect.c (Fx_own_selection_internal)
525 (Fx_get_selection_internal, Fx_disown_selection_internal)
526 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
527 * nsselect.m (Fx_own_selection_internal)
528 (Fx_disown_selection_internal, Fx_selection_exists_p)
529 (Fx_selection_owner_p, Fx_get_selection_internal):
530 Sync docs and argument specs with the xselect.c versions.
531
532 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
533
534 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
535
536 2012-02-11 Eli Zaretskii <eliz@gnu.org>
537
538 * w32select.c (Fx_selection_exists_p): Sync doc string and
539 argument list with xselect.c. (Bug#10783)
540
541 * w16select.c (Fx_selection_exists_p): Sync doc string and
542 argument list with xselect.c. (Bug#10783)
543
544 2012-02-10 Glenn Morris <rgm@gnu.org>
545
546 * fns.c (Fsecure_hash): Doc fix.
547
548 2012-02-09 Kenichi Handa <handa@m17n.org>
549
550 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
551
552 2012-02-07 Chong Yidong <cyd@gnu.org>
553
554 * buffer.c (Fbuffer_local_variables)
555 (buffer_lisp_local_variables): Handle unbound vars correctly;
556 don't let Qunbound leak into Lisp.
557
558 2012-02-07 Glenn Morris <rgm@gnu.org>
559
560 * image.c (Fimagemagick_types): Doc fix.
561
562 * image.c (imagemagick-render-type): Change it from a lisp object
563 to an integer. Move the doc here from the lisp manual.
564 Treat all values not equal to 0 the same.
565
566 2012-02-06 Chong Yidong <cyd@gnu.org>
567
568 * doc.c (store_function_docstring): Avoid applying docstring of
569 alias to base function (Bug#2603).
570
571 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
572
573 * .gdbinit (pp1, pv1): Remove redundant defines.
574 (pr): Use pp.
575
576 2012-02-04 Chong Yidong <cyd@gnu.org>
577
578 * nsterm.m: Declare a global (Bug#10694).
579
580 2012-02-04 Eli Zaretskii <eliz@gnu.org>
581
582 * w32.c (get_emacs_configuration_options):
583 Include --enable-checking, if specified, in the return value.
584
585 2012-02-04 Martin Rudalics <rudalics@gmx.at>
586
587 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
588 after rounding frame sizes. (Bug#9723)
589
590 2012-02-04 Eli Zaretskii <eliz@gnu.org>
591
592 * keyboard.c (adjust_point_for_property): Don't position point
593 before BEGV. (Bug#10696)
594
595 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
596
597 Handle overflow when computing char display width (Bug#9496).
598 * character.c (char_width): Return EMACS_INT, not int.
599 (char_width, c_string_width): Check for overflow when
600 computing the width; this is possible now that individual
601 characters can have unbounded width. Problem introduced
602 by merge from Emacs 23 on 2012-01-19.
603
604 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
605
606 * dbusbind.c (Fdbus_register_method): Mention the return value
607 :ignore in the docstring.
608
609 2012-02-02 Glenn Morris <rgm@gnu.org>
610
611 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
612
613 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
614 Unconditionally set to t. (Bug#10673)
615 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
616 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
617 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
618
619 2012-02-02 Kenichi Handa <handa@m17n.org>
620
621 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
622 0, do not call append_composite_glyph.
623
624 2012-02-02 Kenichi Handa <handa@m17n.org>
625
626 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
627 NULL (Bug#6988).
628 (x_produce_glyphs): If the component of a composition is a null
629 string, set it->pixel_width to 1 to avoid zero-width glyph.
630
631 2012-02-01 Eli Zaretskii <eliz@gnu.org>
632
633 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
634 first 2 arguments are identical. This makes inserting large
635 output from a subprocess an order of magnitude faster on
636 MS-Windows, where all sbrk'ed memory is always contiguous.
637
638 2012-01-31 Glenn Morris <rgm@gnu.org>
639
640 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
641 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
642 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
643
644 2012-01-29 Glenn Morris <rgm@gnu.org>
645
646 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
647
648 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
649
650 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
651
652 2012-01-28 Chong Yidong <cyd@gnu.org>
653
654 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
655
656 2012-01-26 Chong Yidong <cyd@gnu.org>
657
658 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
659
660 * search.c (Fsearch_forward, Fsearch_backward): Document negative
661 repeat counts (Bug#10507).
662
663 2012-01-26 Glenn Morris <rgm@gnu.org>
664
665 * lread.c (syms_of_lread): Doc fix.
666
667 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
668
669 * coding.c (encode_designation_at_bol): Change return value to
670 EMACS_INT.
671
672 2012-01-25 Chong Yidong <cyd@gnu.org>
673
674 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
675
676 2012-01-21 Chong Yidong <cyd@gnu.org>
677
678 * floatfns.c (Fcopysign): Make the second argument non-optional,
679 since nil is not allowed anyway.
680
681 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
682
683 * process.c (read_process_output): Use p instead of XPROCESS (proc).
684 (send_process): Likewise.
685
686 2012-01-19 Martin Rudalics <rudalics@gmx.at>
687
688 * window.c (save_window_save, Fcurrent_window_configuration)
689 (Vwindow_persistent_parameters): Do not use Qstate.
690 Rewrite doc-strings.
691
692 2012-01-19 Kenichi Handa <handa@m17n.org>
693
694 * character.c (char_width): New function.
695 (Fchar_width, c_string_width, lisp_string_width):
696 Use char_width (Bug#9496).
697
698 2012-01-16 Martin Rudalics <rudalics@gmx.at>
699
700 * window.c (Vwindow_persistent_parameters): New variable.
701 (Fset_window_configuration, save_window_save): Handle persistent
702 window parameters.
703
704 2012-01-14 Eli Zaretskii <eliz@gnu.org>
705
706 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
707 thrashing the stack of the thread. (Bug#9087)
708
709 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
710
711 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
712
713 2012-01-11 Eli Zaretskii <eliz@gnu.org>
714
715 * xdisp.c (rows_from_pos_range): Handle the case where the
716 highlight ends on a newline. (Bug#10464)
717 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
718 he end column for display of highlight that ends on a newline
719 before a R2L line.
720
721 2012-01-11 Glenn Morris <rgm@gnu.org>
722
723 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
724 from load-path also when installation-directory is nil. (Bug#10208)
725
726 2012-01-10 Glenn Morris <rgm@gnu.org>
727
728 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
729
730 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
731 Update template values to be closer to their typical values these days.
732
733 2012-01-09 Eli Zaretskii <eliz@gnu.org>
734
735 * xdisp.c (rows_from_pos_range): Accept additional argument
736 DISP_STRING, and accept any glyph in a row whose object is that
737 string as eligible for mouse highlight. Fixes mouse highlight of
738 display strings from overlays. (Bug#10464)
739
740 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
741
742 emacs: fix an auto-save permissions race condition (Bug#10400)
743 * fileio.c (auto_saving_dir_umask): New static var.
744 (Fmake_directory_internal): Use it.
745 (do_auto_save_make_dir): Set it, instead of invoking chmod after
746 creating the directory. The old code temporarily assigns
747 too-generous permissions to the directory.
748 (do_auto_save_eh): Clear it.
749 (Fdo_auto_save): Catch all errors, not just file errors, so
750 that the var is always cleared.
751
752 2012-01-07 Eli Zaretskii <eliz@gnu.org>
753
754 * search.c (scan_buffer): Pass character positions to
755 know_region_cache, not byte positions. (Bug#6540)
756
757 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
758
759 * w32.c (sys_rename): Report EXDEV when rename of a directory
760 fails because the target is on another logical disk. (Bug#10284)
761
762 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
763
764 * xterm.c (x_embed_request_focus): New function.
765
766 * xterm.h: Add prototype.
767
768 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
769
770 2012-01-05 Glenn Morris <rgm@gnu.org>
771
772 * emacs.c (emacs_copyright): Update short copyright year to 2012.
773
774 2012-01-01 Eli Zaretskii <eliz@gnu.org>
775
776 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
777 Load gnutls_transport_set_lowat only if GnuTLS version is below
778 2.11.1.
779 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
780 GnuTLS versions below 2.11.1.
781
782 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
783
784 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
785 to the doc string advising against its use for altering the way
786 windows are scrolled.
787
788 2011-12-28 Kenichi Handa <handa@m17n.org>
789
790 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
791 coding-system ASCII compatible only when it does not produce BOM
792 on encoding (Bug#10383).
793
794 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
795
796 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
797 can scroll.
798 (create_and_show_popup_menu): Always use menu_position_func for
799 Gtk3 (Bug#10361).
800
801 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
802
803 * callint.c (Fcall_interactively): Don't truncate prompt string.
804
805 2011-12-23 Eli Zaretskii <eliz@gnu.org>
806
807 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
808 property that ends at ZV, so that the bidi iteration could be
809 resumed from there (after widening). (Bug#10360)
810
811 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
812
813 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
814
815 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
816
817 * nsterm.m (x_free_frame_resources):
818 Release f->output_data.ns->miniimage.
819 (ns_index_color): Fix indentation. Do not retain
820 color_table->colors[i].
821
822 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
823 before returning.
824
825 * nsfns.m (x_set_background_color): Assign return value from
826 ns_index_color to face-background instead of NSColor*.
827 (ns_implicitly_set_icon_type): Fix indentation.
828 Change assignment in for loop to comparison.
829
830 * emacs.c (ns_pool): New variable.
831 (main): Assign ns_pool.
832 (Fkill_emacs): Call ns_release_autorelease_pool.
833
834 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
835 autorelease fdesc, release fdAttrs and tdict.
836 (ns_get_covering_families): Release charset.
837 (ns_findfonts): Release NSFontDescriptor created with new.
838 (ns_uni_to_glyphs): Fix indentation.
839 (setString): Release attrStr before assigning new value.
840
841 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
842
843 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
844 and NS_IMPL_COCOA.
845 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
846 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
847
848 2011-12-18 David Reitter <reitter@cmu.edu>
849
850 * nsterm.m (ns_term_init): Subscribe for notifications
851 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
852 to method trackingNotification in EmacsMenu.
853
854 * nsmenu.m (trackingMenu): New variable.
855 (trackingNotification): New method (from Aquamacs).
856 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
857 from Aquamacs (Bug#7030).
858
859 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
860
861 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
862 (symbol_to_nsstring): Fix indentation.
863 (ns_symbol_to_pb): New function.
864 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
865 (Fns_rotate_cut_buffers_internal): Remove.
866 (Fns_store_selection_internal): Rename from
867 Fns_store_cut_buffer_internal.
868 (ns_get_foreign_selection, Fx_own_selection_internal)
869 (Fx_disown_selection_internal, Fx_selection_exists_p)
870 (Fns_get_selection_internal, Fns_store_selection_internal):
871 Use ns_symbol_to_pb and check if return value is nil.
872 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
873 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
874 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
875 renamed to Sns_store_selection_internal.
876 (ns_handle_selection_request): Move code to Fx_own_selection_internal
877 and remove this function.
878 (ns_handle_selection_clear): Remove, never used.
879 (Fx_own_selection_internal): Move code from ns_handle_selection_request
880 here.
881
882 2011-12-17 Ken Brown <kbrown@cornell.edu>
883
884 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
885 GID is unknown (Bug#10257).
886
887 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
888
889 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
890 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
891 which caused a build failure on GNU/Linux IA-64. This problem was
892 introduced by my 2011-10-07 patch.
893
894 2011-12-15 Juri Linkov <juri@jurta.org>
895
896 * image.c (imagemagick_error): New function. (Bug#10112)
897 (imagemagick_load_image): Comment out `MagickSetResolution' call.
898 Use `imagemagick_error' where ImageMagick functions return
899 `MagickFalse'.
900 (Fimagemagick_types): Add `Fnreverse' to return the list in the
901 proper order.
902
903 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
904
905 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
906 fill background (Bug#8992).
907
908 2011-12-13 Martin Rudalics <rudalics@gmx.at>
909
910 * window.c (Vwindow_combination_resize)
911 (Vwindow_combination_limit): Use t instead of non-nil in
912 doc-strings.
913 (Vrecenter_redisplay): Add first sentence of doc-string on
914 separate line.
915 (Frecenter): Fix doc-string typo.
916
917 2011-12-11 Kenichi Handa <handa@m17n.org>
918
919 * coding.c (Funencodable_char_position): Pay attention to the
920 buffer text relocation (Bug#9389).
921
922 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
923
924 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
925 gtk_init (Bug#10100).
926
927 2011-12-10 Eli Zaretskii <eliz@gnu.org>
928
929 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
930 IT->string is nil. (Bug#10263)
931
932 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
933
934 * nsterm.h (x_free_frame_resources): Declare.
935
936 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
937 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
938
939 * nsterm.h (ns_get_defaults_value): Declare.
940
941 * nsterm.m (ns_default): Call ns_get_defaults_value.
942
943 2011-12-09 Eli Zaretskii <eliz@gnu.org>
944
945 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
946 (Bug#10170)
947
948 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
949
950 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
951 that where the value of an _OBJC_* symbol points to is in the .bss
952 section (Bug#10240).
953
954 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
955
956 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
957 after the loop to call ccl_driver at least once (Bug#8619).
958
959 2011-12-08 Kenichi Handa <handa@m17n.org>
960
961 * ftfont.c (get_adstyle_property): Fix previous change
962 (Bug#10233).
963
964 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
965
966 * w32.c (init_environment): If no_site_lisp, remove site-lisp
967 dirs from the default value of EMACSLOADPATH (bug#10208).
968
969 2011-12-07 Glenn Morris <rgm@gnu.org>
970
971 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
972 installation and source directories as well. (Bug#10208)
973
974 2011-12-06 Chong Yidong <cyd@gnu.org>
975
976 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
977
978 2011-12-06 Glenn Morris <rgm@gnu.org>
979
980 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
981 as an error, not just -1. (Bug#10217)
982
983 2011-12-05 Chong Yidong <cyd@gnu.org>
984
985 * keyboard.c (process_special_events): New function.
986 (swallow_events, Finput_pending_p): Use it (Bug#10195).
987
988 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
989
990 * coding.c (encode_designation_at_bol): Don't use uninitialized
991 local variable (Bug#9318).
992
993 2011-12-05 Kenichi Handa <handa@m17n.org>
994
995 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
996 return Qnil (Bug#8046, Bug#10193).
997
998 2011-12-05 Kenichi Handa <handa@m17n.org>
999
1000 * coding.c (encode_designation_at_bol): New args charbuf_end and
1001 dst. Return the number of produced bytes. Callers changed.
1002 (coding_set_source): Return how many bytes coding->source was
1003 relocated.
1004 (coding_set_destination): Return how many bytes
1005 coding->destination was relocated.
1006 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1007 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1008
1009 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1010
1011 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1012 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1013 macro (Bug#9318).
1014
1015 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1016
1017 The following changes are to fix Bug#9318.
1018
1019 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1020 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1021 (encode_coding_iso_2022, encode_coding_sjis)
1022 (encode_coding_big5, encode_coding_charset): Use the above macros.
1023
1024 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1025
1026 * lisp.h (process_quit_flag): Fix external declaration.
1027
1028 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1029
1030 Don't macro-inline non-performance-critical code.
1031 * eval.c (process_quit_flag): New function.
1032 * lisp.h (QUIT): Use it.
1033
1034 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1035
1036 * nsfns.m (get_geometry_from_preferences): New function.
1037 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1038
1039 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1040
1041 * emacs.c (Qkill_emacs): Define.
1042 (syms_of_emacs): Initialize it.
1043 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1044 Qquit_flag to `kill-emacs' instead.
1045 (quit_throw_to_read_char): Add parameter `from_signal'.
1046 All callers changed. Call Fkill_emacs if requested and safe.
1047 * lisp.h (QUIT): Call Fkill_emacs if requested.
1048
1049 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1050
1051 * widget.c (update_wm_hints): Return if wmshell is null.
1052 (widget_update_wm_size_hints): New function.
1053
1054 * widget.h (widget_update_wm_size_hints): Declare.
1055
1056 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1057 widget_update_wm_size_hints (Bug#10104).
1058
1059 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1060
1061 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1062 before a newline, prepare the bidi iterator for consuming the
1063 newline, and keep the current paragraph direction. (Bug#10183)
1064 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1065
1066 2011-12-02 Juri Linkov <juri@jurta.org>
1067
1068 * search.c (Fword_search_regexp): New Lisp function created from
1069 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1070 (Fword_search_backward, Fword_search_forward)
1071 (Fword_search_backward_lax, Fword_search_forward_lax):
1072 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1073 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1074
1075 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1076
1077 * fileio.c (Finsert_file_contents): Move after-change-function call
1078 to before the "handled:" label, since all "goto handled" appear in
1079 cases where the *-change-functions have already been properly called
1080 (bug#10117).
1081
1082 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1083
1084 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1085 waiting for input. (Bug#10169)
1086
1087 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1088
1089 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1090 verifies glyph row's hash code--we have just reallocated the
1091 glyphs, so their contents can be complete garbage. (Bug#10164)
1092
1093 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1094
1095 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1096
1097 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1098
1099 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1100 attributes are tested _before_ calling verify_row_hash, to protect
1101 against GCC re-ordering of the tests. (Bug#10164)
1102
1103 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1104
1105 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1106
1107 * xterm.c (handle_one_xevent): Only set async_visible and friends
1108 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1109 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1110 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1111
1112 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1113
1114 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1115 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1116 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1117 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1118 All uses changed to use GCPRO1 etc.
1119 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1120 Revert to old implementation (i.e., before 2011-03-11).
1121
1122 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1123
1124 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1125 of scroll runs so as to avoid assigning disabled bogus rows and
1126 unnecessary graphics copy operations.
1127
1128 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1129
1130 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1131 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1132 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1133 (malloc, free, realloc, calloc): Redirect to e_* only when
1134 compiling Emacs.
1135
1136 * lisp.h (GCTYPEBITS): Move before first use.
1137 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1138 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1139 this macro definition.
1140
1141 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1142 _MSC_VER.
1143
1144 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1145
1146 * gtkutil.c (xg_create_frame_widgets):
1147 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1148 present with Gtk+ 2.0.
1149
1150 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 * fileio.c (Finsert_file_contents): Undo previous change; see
1153 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1154
1155 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 Rename locals to avoid shadowing.
1158 * fileio.c (Finsert_file_contents):
1159 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1160 * process.c (wait_reading_process_output):
1161 Rename inner 'proc' to 'p' to avoid shadowing.
1162 Indent for consistency with usual Emacs style.
1163
1164 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1165
1166 * xdisp.c (redisplay_window): If cursor row is not fully visible
1167 after recentering, and scroll-conservatively is set to a large
1168 number, scroll window by a few more lines to make the cursor fully
1169 visible and out of scroll-margin. (Bug#10105)
1170 (start_display): Don't move to the next line if the display should
1171 start at a newline that is part of a display vector or an overlay
1172 string. (Bug#10119)
1173
1174 2011-11-24 Juri Linkov <juri@jurta.org>
1175
1176 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1177 after the `MagickPingImage' call. (Bug#10112)
1178
1179 2011-11-23 Chong Yidong <cyd@gnu.org>
1180
1181 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1182
1183 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1184
1185 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1186 making another buffer current. (Bug#10114)
1187
1188 2011-11-23 Glenn Morris <rgm@gnu.org>
1189
1190 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1191
1192 2011-11-23 Chong Yidong <cyd@gnu.org>
1193
1194 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1195 using it (Bug#5984).
1196
1197 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1198
1199 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1200 and header-lines, as they don't have one computed for them.
1201 (Bug#10098)
1202
1203 * .gdbinit (prow): Make displayed values more self-explaining.
1204 Add row's hash code.
1205
1206 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1207
1208 * process.c (wait_reading_process_output): Fix asynchrounous
1209 GnuTLS socket handling on some versions of the GnuTLS library.
1210 (wait_reading_process_output): Add comment and URL.
1211
1212 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1213
1214 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1215
1216 2011-11-21 Chong Yidong <cyd@gnu.org>
1217
1218 * window.c (Fnext_window, Fprevious_window): Doc fix.
1219
1220 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1221
1222 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1223
1224 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1225
1226 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1227
1228 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1229
1230 * window.c (Fset_window_combination_limit): Rename argument
1231 STATUS to LIMIT.
1232 (Vwindow_combination_limit): Remove "status" from doc-string.
1233
1234 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1235
1236 * m/ibms390.h: Remove.
1237 * m/ibms390x.h: Don't include "ibms390.h".
1238
1239 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1240
1241 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1242 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1243
1244 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1245
1246 * casetab.c (Fset_case_table):
1247 * charset.c (Fcharset_after): Fix typos.
1248
1249 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1250
1251 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1252 Otherwise, valgrind does not work on some platforms.
1253 Problem reported by Andreas Schwab in
1254 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1255 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1256 is set, removing the need for VIRT_ADDRESS_VARIES.
1257 (PURE_P): Use a more-efficient implementation that needs just one
1258 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1259 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1260 to 4 (xorl, subq, cmpq, setbe).
1261 * alloc.c (pure): Always extern now, since that's the
1262 VIRT_ADDR_VARIES behavior.
1263 (PURE_POINTER_P): Use a single comparison, not two, for
1264 consistency with the new puresize.h.
1265 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1266 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1267 Remove VIRT_ADDR_VARIES no longer needed.
1268
1269 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1270
1271 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1272 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1273 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1274 behave as if the cursor position were at the window margin.
1275
1276 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1277 and the cursor position is out of bounds, behave as if the cursor
1278 position were at the window margin. (Bug#10075)
1279
1280 2011-11-18 Chong Yidong <cyd@gnu.org>
1281
1282 * window.c (Fwindow_combination_limit): Make first argument
1283 non-optional, since it is meaningless for live windows like the
1284 selected window.
1285
1286 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1287
1288 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1289
1290 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1291
1292 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1293 (graft_intervals_into_buffer): Simplify.
1294
1295 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1296
1297 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1298 hash values of the two rows.
1299 (copy_row_except_pointers): Preserve the used[] arrays and the
1300 hash values of the two rows. (Bug#10035)
1301 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1302
1303 * xdisp.c (row_hash): New function, body extracted from
1304 compute_line_metrics.
1305 (compute_line_metrics): Call row_hash, instead of computing the
1306 hash code inline.
1307
1308 * dispnew.c (verify_row_hash): Call row_hash for computing the
1309 hash code of a row, instead of duplicating code from xdisp.c.
1310
1311 * dispextern.h (row_hash): Add prototype.
1312
1313 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1314
1315 * frame.c (delete_frame): Don't delete the terminal when the last
1316 X frame is closed if emacs is built with GTK toolkit.
1317
1318 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1319
1320 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1321
1322 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1323
1324 * window.c (Vwindow_splits): Rename to
1325 Vwindow_combination_resize. Suggested by Juri Linkov.
1326 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1327 of Vwindow_splits.
1328
1329 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1330
1331 * nsfns.m (Fns_font_name):
1332 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1333
1334 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1335
1336 * window.h (window): Rename slot "nest" to "combination_limit".
1337 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1338 (Fset_window_nest): Rename to Fset_window_combination_limit.
1339 (Vwindow_nest): Rename to Vwindow_combination_limit.
1340 (recombine_windows, make_parent_window, make_window)
1341 (Fsplit_window_internal, saved_window)
1342 (Fset_window_configuration, save_window_save): Rename all
1343 occurrences of window_nest to window_combination_limit.
1344
1345 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1346
1347 * image.c (imagemagick_load_image): Fix typo.
1348
1349 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1350
1351 * xdisp.c (display_line): Move the call to
1352 highlight_trailing_whitespace before the call to
1353 compute_line_metrics, since the latter needs to see the final
1354 faces of all the glyphs to compute ROW's hash value.
1355 Fixes assertion violations in row_equal_p. (Bug#10035)
1356
1357 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1358
1359 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1360 just return (bug#10044).
1361
1362 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1363
1364 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1365 with user-defined heap size. Bump the default size of the temacs
1366 heap to 27MB, to avoid memory warning when running temacs.
1367 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1368
1369 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1370 current_matrix and desired_matrix. (Bug#9990)
1371 (verify_row_hash) [XASSERTS]: New function.
1372 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1373 that the hash value of glyph rows is correct.
1374
1375 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1376
1377 * window.h (window): Remove splits slot.
1378 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1379 (Fdelete_other_windows_internal, make_parent_window)
1380 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1381 (Fset_window_configuration, save_window_save): Don't deal with
1382 split status of windows.
1383 (saved_window): Remove splits slot.
1384 (Vwindow_splits): Rewrite doc-string.
1385
1386 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1387
1388 * xfns.c (unwind_create_frame):
1389 * nsfns.m (unwind_create_frame):
1390 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1391 Vframe_list (Bug#9999).
1392
1393 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1394
1395 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1396
1397 2011-11-11 Kenichi Handa <handa@m17n.org>
1398
1399 * callproc.c (Fcall_process): Set the member dst_multibyte of
1400 process_coding.
1401
1402 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1403
1404 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1405 avoid a crash (bug#9496).
1406
1407 2011-11-09 Chong Yidong <cyd@gnu.org>
1408
1409 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1410 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1411
1412 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1415
1416 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1417
1418 Avoid some portability problems by eschewing 'extern inline' functions.
1419 The trivial performance wins aren't worth the portability hassles; see
1420 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1421 et seq.
1422 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1423 (window_box_width, window_box_left, window_box_left_offset)
1424 (window_box_right, window_box_right_offset): Undo previous change,
1425 by removing the "extern"s.
1426 * intervals.c (adjust_intervals_for_insertion)
1427 (adjust_intervals_for_deletion): Undo previous change,
1428 making these static again.
1429 (offset_intervals, temp_set_point_both, temp_set_point)
1430 (copy_intervals_to_string): No longer inline.
1431 * xdisp.c (window_text_bottom_y, window_box_width)
1432 (window_box_height, window_box_left_offset)
1433 (window_box_right_offset, window_box_left, window_box_right)
1434 (window_box): No longer inline.
1435
1436 2011-11-08 Chong Yidong <cyd@gnu.org>
1437
1438 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1439 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1440 Signal an error if not a live window.
1441 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1442 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1443
1444 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1445
1446 * lisp.h (syms_of_abbrev): Remove declaration.
1447 Reported by CHENG Gao <chenggao@royau.me>.
1448
1449 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1450
1451 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1452 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1453 of temacs in GUI mode.
1454
1455 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1456
1457 * window.h: Declare delete_all_child_windows instead of
1458 delete_all_subwindows.
1459 * window.c (Fwindow_nest, Fset_window_nest)
1460 (Fset_window_new_total, Fset_window_new_normal)
1461 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1462 (delete_all_subwindows): Rename to delete_all_child_windows.
1463 (Fdelete_other_windows_internal, Fset_window_configuration):
1464 Call delete_all_child_windows instead of delete_all_subwindows.
1465 * frame.c (delete_frame): Call delete_all_child_windows instead
1466 of delete_all_subwindows.
1467
1468 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1469
1470 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1471 This is also needed for porting to any host where GC_MARK_STACK is
1472 not GC_MAKE_GCPROS_NOOPS.
1473 (which_symbols): Use it.
1474
1475 2011-11-07 Kenichi Handa <handa@m17n.org>
1476
1477 * coding.c (coding_set_destination): Check coding->src_pos only
1478 when coding->src_object is a buffer (bug#9910).
1479
1480 * process.c (send_process): Set the member src_multibyte of coding
1481 to 0 (bug#9911) when sending a unibyte text.
1482
1483 * callproc.c (Fcall_process): Set the member src_multibyte of
1484 process_coding to 0 (bug#9912).
1485
1486 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1487
1488 * xmenu.c (cleanup_widget_value_tree): New function.
1489 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1490 calling free_menubar_widget_value_tree directly (Bug#9830).
1491
1492 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 Fix some portability problems with 'inline'.
1495 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1496 (window_box_width, window_box_left, window_box_left_offset)
1497 (window_box_right, window_box_right_offset): Declare extern.
1498 Otherwise, these inline functions do not conform to C99 and
1499 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1500 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1501 * intervals.c (adjust_intervals_for_insertion)
1502 (adjust_intervals_for_deletion): Now extern, because otherwise the
1503 extern inline functions 'offset_intervals' couldn't refer to it.
1504 (static_offset_intervals): Remove.
1505 (offset_intervals): Rewrite using the old contents of
1506 static_offset_intervals. The old version didn't conform to C99
1507 because an extern inline function contained a reference to an
1508 identifier with static linkage.
1509
1510 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1511
1512 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1513 GC.
1514
1515 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1516
1517 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1518 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1519 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1520 return Qleft_to_right.
1521
1522 2011-11-06 Chong Yidong <cyd@gnu.org>
1523
1524 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1525 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1526 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1527 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1528 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1529 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1530 (Fwindow_vscroll): Doc fix.
1531 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1532 argument, since it makes no sense to pass a live window and for
1533 consistency with window-child.
1534
1535 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1536
1537 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1538 support MSVC.
1539
1540 2011-11-05 Jason Rumney <jasonr@gnu.org>
1541
1542 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1543 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1544 fonts (Bug#6029).
1545 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1546 bitwise arithmetic preventing use of unicode-sip and non-truetype
1547 opentype fonts.
1548
1549 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1550
1551 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1552 "emacs"-only part.
1553
1554 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1555 initialization code to keep similarity to xfns.c after changes
1556 from 2011-11-05.
1557
1558 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1559
1560 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1561 (unwind_create_frame): New function (Bug#9943).
1562 (Fx_create_frame): Restructure code to be more similar to the one in
1563 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1564 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1565 Move terminal->reference_count++ just before making the frame official
1566 (Bug#9943).
1567
1568 * nsterm.m (x_free_frame_resources): New function.
1569 (x_destroy_window): Move code to x_free_frame_resources.
1570
1571 * xfns.c (unwind_create_frame): Fix comment.
1572 (Fx_create_frame, x_create_tip_frame):
1573 Move terminal->reference_count++ just before making the frame
1574 official. Move initialization of image_cache_refcount and
1575 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1576
1577 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1578
1579 Support MSVC build with newer versions of Visual Studio.
1580 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1581 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1582 nt/gmake.defs.
1583
1584 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1585 which are not supported by MSVC.
1586 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1587 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1588 bitfields.
1589 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1590 types in bitfields.
1591 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1592
1593 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1594
1595 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1596
1597 Support MSVC build with newer versions of Visual Studio.
1598 * w32.c: Don't include w32api.h for MSVC.
1599 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1600
1601 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1602 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1603 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1604 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1605 e_* cousins.
1606 (alloca) [_MSC_VER]: Define to _alloca.
1607
1608 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1609
1610 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1611
1612 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1613
1614 * xdisp.c (note_mouse_highlight): If either of
1615 previous/next-single-property-change returns nil, treat that as
1616 the beginning or the end of the buffer. (Bug#9955)
1617
1618 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1619
1620 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1621 label is not null (Bug#9951).
1622 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1623 may be NULL.
1624
1625 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1626
1627 * window.c (Fwindow_body_size): Mention in the doc string that the
1628 return value is in frame's canonical units. (Bug#9949)
1629
1630 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1631
1632 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1633
1634 * w32fns.c (unwind_create_frame): If needed, free the glyph
1635 matrices of the partially constructed frame. (Bug#9943)
1636 * xfns.c (unwind_create_frame): Likewise.
1637
1638 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1639
1640 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1641 Don't stop backward scan on the continuation glyph, even though
1642 its CHARPOS is positive.
1643 (mouse_face_from_buffer_pos, note_mouse_highlight):
1644 Rename cover_string to disp_string.
1645
1646 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1647
1648 * window.c (temp_output_buffer_show): Don't use
1649 Vtemp_buffer_show_specifiers.
1650 (Vtemp_buffer_show_specifiers): Remove unused variable.
1651
1652 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1653
1654 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1655 past the beginning of the current glyph matrix.
1656
1657 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1658
1659 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1660 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1661 HAVE_GTK3 (Bug#9869).
1662
1663 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1664 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1665
1666 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1667
1668 * xterm.c: Declare x_handle_net_wm_state to return int.
1669 (handle_one_xevent): Check if we are iconified but don't have
1670 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1671 (get_current_wm_state): Return non-zero if not hidden,
1672 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1673 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1674 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1675 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1676
1677 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1678
1679 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1680 so that this new function doesn't get optimized away by a
1681 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1682
1683 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1684
1685 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1686
1687 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1688
1689 Fix the `xbytecode' command.
1690 * .gdbinit (xprintbytestr): New command.
1691 (xwhichsymbols): Rename from `which'; all callers changed.
1692 (xbytecode): Print the byte-code string as well.
1693
1694 2011-10-29 Kim Storm <storm@cua.dk>
1695
1696 * alloc.c (which_symbols): New function.
1697
1698 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1699
1700 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1701 line. (Bug#9903)
1702
1703 2011-10-29 Glenn Morris <rgm@gnu.org>
1704
1705 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1706 Not clear what it was for, and it causes various bugs. (Bug#9839)
1707
1708 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1709
1710 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1711 possible random value that matches one of those tested as
1712 condition to clear the mouse face.
1713
1714 2011-10-28 Chong Yidong <cyd@gnu.org>
1715
1716 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1717
1718 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1719
1720 * window.c (make_window): Initialize phys_cursor_on_p.
1721
1722 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1723
1724 * lisp.h (struct Lisp_Symbol): Update comments.
1725
1726 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1727
1728 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1729
1730 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1731
1732 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1733 <oslsachem@gmail.com> for helping to debug this.
1734
1735 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1736 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1737 (g_b_init_get_glyph_outline_w): New static variables.
1738 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1739 (GetGlyphOutlineW_Proc): New typedefs.
1740 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1741 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1742 New functions.
1743 (w32font_open_internal, compute_metrics):
1744 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1745 instead of calling the "wide" APIs directly.
1746
1747 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1748
1749 * w32.h (syms_of_w32font): Add prototype.
1750
1751 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1752
1753 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1754 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1755 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1756 (Fmove_to_window_line): Doc fix.
1757
1758 2011-10-27 Chong Yidong <cyd@gnu.org>
1759
1760 * process.c (make_process): Set gnutls_state to NULL.
1761
1762 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1763 non-NULL, regardless of GNUTLS_INITSTAGE.
1764 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1765 an error. Set process slots as soon as we allocate them.
1766
1767 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1768
1769 2011-10-27 Chong Yidong <cyd@gnu.org>
1770
1771 * gnutls.c (emacs_gnutls_deinit): New function.
1772 Deallocate credentials structures as well as calling gnutls_deinit.
1773 (Fgnutls_deinit, Fgnutls_boot): Use it.
1774
1775 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1776 (deactivate_process): Call emacs_gnutls_deinit.
1777
1778 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1779
1780 * image.c (x_create_x_image_and_pixmap):
1781 * w32.c (sys_rename, w32_delayed_load):
1782 * w32font.c (fill_in_logfont):
1783 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1784
1785 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1786
1787 * w32fns.c (w32_default_color_map): New function,
1788 extracted from Fw32_default_color_map.
1789 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1790
1791 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1792
1793 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1794
1795 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1796
1797 * keyboard.c (test_undefined): New function (bug#9751).
1798 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1799
1800 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1801
1802 * sysdep.c (init_sys_modes): Fix the check for the controlling
1803 terminal (Bug#6649).
1804
1805 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1806
1807 * dispextern.h (struct bidi_it): New member next_en_type.
1808
1809 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1810 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1811 current character, check also for next_en_type being WEAK_EN.
1812 (bidi_resolve_weak): Don't enter the expensive loop if the current
1813 position is before next_en_pos. Record the bidi type of the first
1814 non-ET, non-BN character we find, in addition to its position.
1815 (bidi_level_of_next_char): Invalidate next_en_type when
1816 next_en_pos is over-stepped.
1817
1818 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1819
1820 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1821 * editfns.c: Rewrite current-time-zone so that it invokes
1822 the equivalent of (format-time-string "%Z") to get the time zone name.
1823 This fixes a bug when the time zone name contains characters that
1824 need converting from the system time locale to Emacs internal format.
1825 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1826 that patch fixed format-time-string to do the conversion, but
1827 I forgot to fix current-time-zone.
1828 (format_time_string): New function, containing most of
1829 what Fformat_time_string used to contain.
1830 (Fformat_time_string): Rewrite in terms of format_time_string.
1831 This doesn't change this function's behavior.
1832 (current-time-zone): Rewrite to use format_time_string.
1833 This fixes the bug reported by Michael Schierl in
1834 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1835 Jason Rumney's 2007-06-07 change worked around this bug, but
1836 didn't fix it.
1837 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1838
1839 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1840
1841 * xdisp.c (start_display): If the character at POS is displayed
1842 via a display vector, reset IT->current.dpvec_index to zero.
1843 (try_window_reusing_current_matrix): If a line ends in a display
1844 vector or the next line starts in a display vector, continue
1845 redrawing the window even though the character position of
1846 start_row was reached.
1847 (Bug#9771, part 2)
1848
1849 2011-10-18 Chong Yidong <cyd@gnu.org>
1850
1851 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1852 with nobreak-char-display too.
1853
1854 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1855
1856 Fix part 3 of bug#9771.
1857 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1858 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1859 non-neutral characters if the current character is a paragraph
1860 separator (a.k.a. Newline). This avoids running the same
1861 expensive loop twice, once when we consume the preceding newline
1862 and the other time when the line actually needs to be displayed.
1863 Avoid the loop when we see neutrals on the base embedding level
1864 following a character whose directionality is the same as the
1865 paragraph's. This avoids running the expensive loop when a line
1866 ends in a long sequence of neutrals, like control characters.
1867 Add assertion against STRONG_AL type. Slightly rearrange code
1868 that determines the type of a neutral given the first non-neutral
1869 that follows it.
1870 (bidi_level_of_next_char): Set next_en_pos to zero when
1871 invalidating its info.
1872
1873 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1874
1875 * xdisp.c (push_display_prop): Determine whether to record string
1876 or buffer position by IT->string, not by IT->method. Allow
1877 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1878 (move_it_vertically_backward): Don't look for character position
1879 immediately after the newline when in a continuation line.
1880 (Bug#9771, part 1)
1881
1882 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1883
1884 * window.c (coordinates_in_window): Rewrite and delabelize
1885 vertical border check. (Bug#5357) (Bug#9618)
1886
1887 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1888
1889 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1890 errors in XSetWindowBorder (bug#9310).
1891
1892 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1893
1894 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1895 avoid crash when xmalloc overrun checking is enabled.
1896
1897 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1898
1899 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1900 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1901 cursor motion with <left> and <right> arrow keys.
1902
1903 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1904 some callers set that themselves.
1905
1906 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1907
1908 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1909 display string and the previous row comes from the same string and
1910 is empty. (Bug#9739) (Bug#9738)
1911
1912 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1913
1914 * doc.c (get_doc_string): Encode file name (bug#9735).
1915
1916 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1917
1918 * bidi.c (bidi_level_of_next_char):
1919 * xdisp.c (get_visually_first_element): Remove old incorrect
1920 comments regarding the Unicode Line Separator character.
1921
1922 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1923
1924 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1925
1926 * alloc.c (Fgc_status): Do not access beyond zombies array
1927 boundary if nzombies > MAX_ZOMBIES.
1928 * alloc.c (dump_zombies): Add missing format specifier.
1929
1930 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1931
1932 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1933 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1934
1935 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1936 Some packages use them to denote characters with modifiers.
1937
1938 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1939
1940 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1941 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1942 matching a pp-number. Rename parameter var to var1.
1943
1944 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1945
1946 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1947
1948 2011-10-08 Glenn Morris <rgm@gnu.org>
1949
1950 * callint.c (Fcall_interactively): Give a more explicit error for the
1951 'c' case with a non-character input. (Bug#8479)
1952
1953 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1954
1955 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1956 lines.
1957 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1958 lines that are hscrolled on the left.
1959
1960 * dispnew.c (buffer_posn_from_coords): Account for a possible
1961 presence of header-line. (Bug#4426)
1962
1963 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1964
1965 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1966 Don't advertise functionality which we discourage or doesn't work.
1967
1968 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1969
1970 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1971 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1972 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1973 this makes Emacs dump core during garbage collection on rare
1974 occasions. sizeof is obviously inferior to offsetof here, so
1975 stick with offsetof.
1976 (GC_POINTER_ALIGNMENT): New macro.
1977 (mark_memory): Omit 3rd (offset) arg; caller changed.
1978 Don't assume EMACS_INT alignment is the same as pointer alignment.
1979
1980 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1981
1982 * keyboard.c (read_key_sequence_remapped): New var.
1983 (read_key_sequence): Compute remapping in the right buffer.
1984 (command_loop_1): Use read_key_sequence's remapping directly.
1985
1986 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1987
1988 * dired.c (file_name_completion): Don't expand file name.
1989 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1990 before checking file name handler.
1991
1992 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1993 they've been requested explicitly (bug#9591).
1994
1995 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1996
1997 * keymap.c (Fsingle_key_description): Use make_specified_string
1998 instead of build_string to build string from push_key_description.
1999 (Bug#5193)
2000
2001 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2004 This fixes a Y2038 bug on 64-bit hosts.
2005 * buffer.c (reset_buffer):
2006 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2007 (Fclear_buffer_auto_save_failure):
2008 Use 0, not -1, to represent an unset failure time, since time_t
2009 might not be signed.
2010
2011 Remove dependency on glibc malloc internals.
2012 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2013 Move back here from lisp.h, but with their new implementations.
2014 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2015 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2016 * charset.c (charset_table_init): New static var.
2017 (syms_of_charset): Use it instead of xmalloc. This removes a
2018 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2019 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2020 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2021 Move back to alloc.c.
2022 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2023 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2024
2025 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2026
2027 * nsterm.m (windowDidResize): Call x_set_window_size only when
2028 ns_in_resize is true. Otherwise set pixelwidth/height and
2029 call change_frame_size (Bug#9628).
2030
2031 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2032
2033 Port --enable-checking=all to Fedora 14 x86-64.
2034 * charset.c (syms_of_charset): Also account for glibc malloc's
2035 internal overhead when calculating the initial malloc maximum.
2036
2037 Port --enable-checking=all to Fedora 14 x86.
2038 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2039 Move to lisp.h.
2040 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2041 (overrun_check_realloc, overrun_check_free):
2042 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2043 That way, xmalloc returns a properly-aligned pointer even if
2044 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2045 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2046 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2047 into account when calculating the initial malloc maximum.
2048 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2049 Move here from alloc.c, so that charset.c can use it too.
2050 Properly align; the old code wasn't right for common 32-bit hosts
2051 when configured with --enable-checking=all.
2052 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2053 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2054
2055 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2056
2057 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2058 use EDOM.
2059
2060 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2061
2062 * xdisp.c (compute_display_string_end): If there's no display
2063 string at CHARPOS, return -1.
2064
2065 * bidi.c (bidi_fetch_char): When compute_display_string_end
2066 returns a negative value, treat the character as a normal
2067 character not covered by a display string. (Bug#9624)
2068
2069 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2070
2071 * lread.c (Fread_from_string): Fix typo in docstring.
2072
2073 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2074
2075 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2076 newline, reseat the iterator instead of bidi-iterating there one
2077 character at a time. (Bug#9610)
2078 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2079 TO_CHARPOS if the bidi iterator is at base embedding level.
2080
2081 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2082
2083 * lread.c (readevalloop): Use correct code for NBSP.
2084 (read1): Likewise. (Bug#9608)
2085
2086 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2087
2088 * dbusbind.c (Fdbus_register_signal): When service is not
2089 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2090
2091 2011-09-25 Glenn Morris <rgm@gnu.org>
2092
2093 * buffer.c (truncate-lines): Doc fix.
2094
2095 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2096
2097 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2098 (Fset_window_next_buffers): Doc fix.
2099
2100 2011-09-24 Glenn Morris <rgm@gnu.org>
2101
2102 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2103
2104 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2105
2106 Fix minor problems found by static checking.
2107 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2108 * indent.c (Fvertical_motion): Fix == vs = typo.
2109
2110 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2111
2112 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2113 Default value is now t. Doc fix.
2114
2115 * indent.c (Fvertical_motion): Compute and apply the overshoot
2116 logic when moving up, not only when moving down. Fix the
2117 confusing name and values of the it_overshoot_expected variable;
2118 logic changes accordingly. (Bug#9254) (Bug#9549)
2119
2120 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2121 CHARPOS is covered by a display string which includes newlines.
2122 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2123 is covered by a display string with embedded newlines.
2124
2125 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2126
2127 * dbusbind.c (Fdbus_register_signal): Add match rule to
2128 Vdbus_registered_objects_table. (Bug#9581)
2129 (Fdbus_register_method, Vdbus_registered_objects_table):
2130 Fix docstring.
2131
2132 2011-09-24 Jim Meyering <meyering@redhat.com>
2133
2134 do not ignore write error for any output size
2135 The previous change was incomplete.
2136 While it makes emacs --batch detect the vast majority of stdout
2137 write failures, errors were still ignored whenever the output size is
2138 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2139 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2140 && echo FAIL: ignored write error
2141 FAIL: ignored write error
2142 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2143 && echo FAIL: ignored write error
2144 FAIL: ignored write error
2145 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2146
2147 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2148
2149 * emacs.c (Fkill_emacs): In noninteractive mode exit
2150 non-successfully if a write error occurred on stdout. (Bug#9574)
2151
2152 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2153
2154 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2155 the xassert test.
2156
2157 * dispextern.h (struct it): Update the comment documenting what
2158 can it->OBJECT be.
2159
2160 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2161
2162 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2163 a display string, extend search for cursor position to end of row.
2164 (find_row_edges): If the row ends in a newline from a display
2165 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2166 Handle the case of a display string with multiple newlines.
2167 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2168 non-empty line. Fixes confusing cursor motion with arrow keys at
2169 the beginning of a line that starts with whitespace.
2170
2171 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2172
2173 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2174 (bug#9493).
2175
2176 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2177
2178 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2179 boolean (Bug#9154).
2180
2181 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2182
2183 * xdisp.c (display_line): Record maximum and minimum buffer
2184 positions even if no glyphs were produced (e.g., by a zero-width
2185 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2186 buffer positions that will be removed from the glyph row because
2187 they don't fit.
2188 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2189 column is beyond frame width: don't subtract 1 "pixel" when
2190 computing width of the stretch.
2191 (reseat_at_next_visible_line_start): Undo the change made on
2192 2011-09-17 that saved paragraph information and restored it after
2193 the call to `reseat'. (Bug#9545)
2194
2195 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2196
2197 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2198 and turn window cursor on if cleared (Bug#9415).
2199
2200 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2201
2202 * search.c (boyer_moore): Take unibyte characters from pattern
2203 literally. (Bug#9458)
2204
2205 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2206
2207 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2208
2209 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2210
2211 Fix minor problem found by static checking.
2212 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2213 initialized, to pacify gcc -Wuninitialized.
2214
2215 * fileio.c: Report proper errno when syscall falls.
2216 (Finsert_file_contents): Save and restore errno,
2217 so that report_file_error outputs the correct diagnostic.
2218 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2219
2220 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2221
2222 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2223
2224 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2225
2226 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2227 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2228
2229 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2230
2231 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2232 about the current paragraph and restore it after the call to reseat.
2233
2234 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2235 (bidi_find_paragraph_start): Search back for paragraph beginning
2236 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2237 (bidi_move_to_visually_next): Only trigger paragraph-related
2238 computations when the last character is a newline or at EOB, not
2239 just any NEUTRAL_B. (Bug#9470)
2240
2241 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2242 truncated lines if point is covered by a display string. (Bug#9524)
2243
2244 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2245
2246 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2247 (cons_to_x_long): New function.
2248 (lisp_data_to_selection_data): Use it. Correct the test for
2249 short-versus-long data; it was negated. Break out of vector
2250 loop, for efficiency, when a long datum is discovered.
2251
2252 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2253
2254 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2255
2256 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2257
2258 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2259 GCC PR/17406) by declaring this function with external scope.
2260
2261 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2262
2263 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2264 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2265
2266 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2267
2268 * editfns.c (Fformat): Correctly handle text properties on "%%".
2269
2270 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2271
2272 * xterm.c (x_draw_composite_glyph_string_foreground):
2273 * w32term.c (x_draw_composite_glyph_string_foreground):
2274 * term.c (encode_terminal_code):
2275 * composite.c (composition_update_it, get_composition_id):
2276 * xdisp.c (get_next_display_element)
2277 (fill_composite_glyph_string): Add comments about special meaning
2278 of TAB characters in a composition.
2279
2280 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2281
2282 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2283 This occurs when processing a multibyte format.
2284 Problem reported by Wolfgang Jenker.
2285
2286 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2287
2288 * xdisp.c (try_cursor_movement): Only check for exact match if
2289 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2290
2291 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2292
2293 Remove unused external symbols.
2294 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2295 * xdisp.c (calc_pixel_width_or_height): Now static.
2296 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2297 * indent.c (check_display_width):
2298 * w32term.c: Fix comment to match code.
2299 * xterm.c, xterm.h (x_catching_errors): Remove.
2300
2301 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2302
2303 * xselect.c: Use signed conversions more consistently (Bug#9498).
2304 (selection_data_to_lisp_data): Assume incoming selection data are
2305 signed integers, not unsigned. This is to be consistent with
2306 outgoing selection data, which was modified to use signed integers
2307 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2308 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2309 expects long, not unsigned long.
2310
2311 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2312
2313 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2314 computation of loop end. Reported by Johan Bockgård
2315 <bojohan@gnu.org>.
2316
2317 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2318
2319 * frame.c (Fother_visible_frames_p): Function deleted.
2320
2321 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2322
2323 * indent.c (compute_motion): Process display vector front to back
2324 rather than the other way around. (Bug#2496)
2325
2326 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2327
2328 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2329
2330 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2331
2332 * minibuf.c (Fread_from_minibuffer): Doc fix.
2333
2334 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2335
2336 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2337 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2338
2339 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2340
2341 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2342 value for non-existent files.
2343
2344 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2345
2346 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2347 set its "size" to -1. This will set the modtime_size field of
2348 the corresponding buffer to -1, which is what
2349 verify-visited-file-modtime expects for files that do not exist.
2350 (Bug#9139)
2351
2352 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2353
2354 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2355 here ...
2356 * lisp.h: ... from here. push_key_description is no longer
2357 defined in keyboard.c, so its declaration should not be in
2358 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2359 logically belongs with push_key_description.
2360
2361 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2362
2363 * buffer.h: Include <sys/types.h> instead of <time.h>.
2364 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2365 Problem reported by Herbert J. Skuhra.
2366
2367 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2368
2369 * xml.c (parse_region): Make the parsing work for
2370 non-comment-starting XML files again (bug#9144).
2371
2372 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2373
2374 * image.c (gif_load): Fix calculation of bottom and right corner.
2375 (Bug#9468)
2376
2377 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2378
2379 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2380 redisplay in small windows.
2381
2382 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2383
2384 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2385
2386 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2387
2388 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2389 Operate on live windows only.
2390
2391 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2392
2393 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2394
2395 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2396
2397 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2398 only under bidi iteration.
2399
2400 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2401
2402 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2403
2404 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2405
2406 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2407 Without this fix, the command to link temacs failed due to an
2408 undefined symbol __builtin_isnan. This is because
2409 /usr/include/iso/math_c99.h #defines isnan(x) to
2410 __builtin_isnan(x), but the bundled gcc, which identifies itself
2411 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2412 a __builtin_isnan.
2413 * floatfns.c (isnan): #undef, and then #define to a clone of
2414 what's in data.c.
2415 (Fisnan): Always define, since it's always available now.
2416 (syms_of_floatfns): Always define isnan at the Lisp level.
2417
2418 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2419
2420 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2421
2422 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2423
2424 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2425 The previous code assumed that file offsets (off_t values) fit in
2426 EMACS_INT variables, which is not true on typical 32-bit hosts.
2427 The code messed up by falsely reporting buffer overflow in cases
2428 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2429 when "big" contains more than 2**29 bytes, even though this
2430 inserts just one byte and does not overflow the buffer.
2431 (Finsert_file_contents): Store file offsets as off_t
2432 values, not as EMACS_INT values. Check for overflow when
2433 converting between EMACS_INT and off_t. When checking for
2434 buffer overflow or for overlap, take the offsets into account.
2435 Don't use EMACS_INT for small values where int suffices.
2436 When checking for overlap, fix a typo: ZV was used where
2437 ZV_BYTE was intended.
2438 (Fwrite_region): Don't assume off_t fits into 'long'.
2439 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2440
2441 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2442
2443 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2444
2445 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2446
2447 sprintf-related integer and memory overflow issues (Bug#9412).
2448
2449 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2450 (esprintf, exprintf, evxprintf): New functions.
2451 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2452 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2453 (modify_event_symbol): Do not assume that the length of
2454 name_alist_or_stem is safe to alloca and fits in int.
2455 (Fexecute_extended_command): Likewise for function name and binding.
2456 (Frecursion_depth): Wrap around reliably on integer overflow.
2457 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2458 since some callers pass EMACS_INT values.
2459 (Fsingle_key_description): Don't crash if symbol name contains more
2460 than MAX_ALLOCA bytes.
2461 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2462 (get_minibuffer): Arg is now EMACS_INT, not int.
2463 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2464 (esprintf, exprintf, evxprintf): New decls.
2465 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2466
2467 * dbusbind.c (signature_cat): New function.
2468 (xd_signature, Fdbus_register_signal):
2469 Do not overrun buffer; instead, report string overflow.
2470
2471 * dispnew.c (add_window_display_history): Don't overrun buffer.
2472 Truncate instead; this is OK since it's just a log.
2473
2474 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2475 even if the time zone offset is outlandishly large.
2476 Don't mishandle offset == INT_MIN.
2477
2478 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2479 when creating daemon; the previous buffer-overflow check was incorrect.
2480
2481 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2482 which has the guts of the old verror function.
2483
2484 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2485 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2486
2487 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2488 (font_unparse_xlfd): Don't blindly alloca long strings.
2489 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2490 fits in int, when using sprintf. Use single snprintf to count
2491 length of string rather than counting it via multiple sprintfs;
2492 that's simpler and more reliable.
2493 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2494 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2495 sprintf, in case result does not fit in int.
2496
2497 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2498 (fontset_from_font): Print it.
2499
2500 * frame.c (tty_frame_count): Now printmax_t, not int.
2501 (make_terminal_frame, set_term_frame_name): Print it.
2502 (x_report_frame_params): In X, window IDs are unsigned long,
2503 not signed long, so print them as unsigned.
2504 (validate_x_resource_name): Check for implausibly long names,
2505 and don't assume name length fits in 'int'.
2506 (x_get_resource_string): Don't blindly alloca invocation name;
2507 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2508 not fit in int.
2509
2510 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2511 (xg_check_special_colors, xg_set_geometry):
2512 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2513
2514 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2515 Use esprintf, not sprintf, in case result does not fit in int.
2516
2517 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2518 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2519 it as a large positive number.
2520 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2521 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2522
2523 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2524 in case result does not fit in int.
2525
2526 * print.c (float_to_string): Detect width overflow more reliably.
2527 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2528 buffer overrun. Don't assume list length fits in 'int'. Treat
2529 print length of 0 as 0, not as infinity; to be consistent with other
2530 uses of print length in this function. Don't overflow print length
2531 index. Don't assume hash table size fits in 'long', or that
2532 vectorlike size fits in 'unsigned long'.
2533
2534 * process.c (make_process): Use printmax_t, not int, to format
2535 process-name gensyms.
2536
2537 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2538
2539 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2540 to avoid potential buffer overrun.
2541
2542 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2543 if X resource line is longer than 512 bytes.
2544
2545 * xfns.c (x_window): Make sprintf buffer a bit bigger
2546 to avoid potential buffer overrun.
2547
2548 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2549
2550 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2551
2552 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2553
2554 Integer overflow fixes for scrolling, etc.
2555 Without these, Emacs silently mishandles large integers sometimes.
2556 For example, "C-u 4294967297 M-x recenter" was treated as if
2557 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2558
2559 * xdisp.c (try_window_id): Check Emacs fixnum range before
2560 converting to 'int'.
2561
2562 * window.c (window_scroll_line_based, Frecenter):
2563 Check that an Emacs fixnum is in range before assigning it to 'int'.
2564 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2565 values converted from Emacs fixnums.
2566 (Frecenter): Don't wrap around a line count if it is out of 'int'
2567 range; instead, treat it as an extreme value.
2568 (Fset_window_configuration, compare_window_configurations):
2569 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2570
2571 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2572 that can exceed INT_MAX. Check that EMACS_INT value is in range
2573 before assigning it to the (possibly-narrower) index.
2574 (match_limit): Don't assume that a fixnum can fit in 'int'.
2575
2576 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2577 exceed INT_MAX.
2578
2579 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2580 (Fvertical_motion): Don't wrap around LINES values that don't fit
2581 in 'int'. Instead, treat them as extreme values. This is good
2582 enough for windows, which can't have more than INT_MAX lines anyway.
2583
2584 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2585
2586 * Require libxml/parser.h to avoid compilation warning.
2587
2588 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2589
2590 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2591 since this reportedly can destroy thread storage.
2592
2593 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2594
2595 * syntax.c (find_defun_start): Update all cache variables if
2596 exiting early (Bug#9401).
2597
2598 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2599
2600 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2601
2602 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2603 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2604 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2605
2606 * term.c (tty_append_glyph): New function.
2607 (produce_stretch_glyph): Static function and its prototype deleted.
2608
2609 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2610 Add prototypes.
2611
2612 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2613
2614 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2615 when checking :margin (Bug#9390).
2616 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2617 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2618 so that the name doesn't mislead. All uses changed.
2619
2620 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2621
2622 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2623 set_tty_hooks.
2624
2625 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2626
2627 * xdisp.c (move_it_to): Don't bail out early when reaching
2628 position beyond to_charpos, if we are scanning backwards.
2629 (move_it_vertically_backward): When DY == 0, make sure we get to
2630 the first character in the line after the newline.
2631
2632 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2633
2634 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2635 (ccl_driver): Do not generate an out-of-range pointer.
2636 (Fccl_execute_on_string): Remove unnecessary check for
2637 integer overflow, noted by Stefan Monnier in
2638 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2639 Remove a FIXME that didn't need fixing.
2640 Simplify the newly-introduced buffer reallocation code.
2641
2642 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2643
2644 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2645
2646 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2647
2648 Integer and memory overflow issues (Bug#9196).
2649
2650 * doc.c (get_doc_string): Rework so that
2651 get_doc_string_buffer_size is the actual buffer size, rather than
2652 being 1 less than the actual buffer size; this makes xpalloc more
2653 convenient.
2654
2655 * image.c (x_allocate_bitmap_record, cache_image):
2656 * xselect.c (Fx_register_dnd_atom):
2657 Simplify previous changes by using xpalloc.
2658
2659 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2660 since either will do and ptrdiff_t is convenient with xpalloc.
2661
2662 * charset.c (charset_table_size)
2663 (struct charset_sort_data.priority): Now ptrdiff_t.
2664 (charset_compare): Don't overflow if priorities differ greatly.
2665 (Fsort_charsets): Don't assume list length fits in int.
2666 Check for size-calculation overflow when allocating sort data.
2667 (syms_of_charset): Allocate an initial charset table that is
2668 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2669
2670 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2671
2672 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2673 The actual value is always <= INT_MAX, and leaving it unsigned made
2674 overflow checking harder.
2675
2676 * dispextern.h (struct glyph_matrix.rows_allocated)
2677 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2678 with xpalloc. The values are still always <= INT_MAX.
2679
2680 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2681
2682 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2683 (SAFE_NALLOCA): New macro.
2684
2685 * region-cache.c (struct boundary.pos, find_cache_boundary)
2686 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2687 (set_cache_region, invalidate_region_cache)
2688 (revalidate_region_cache, know_region_cache, region_cache_forward)
2689 (region_cache_backward, pp_cache):
2690 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2691 so that ptrdiff_t * can be passed to xpalloc.
2692 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2693 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2694 (pp_cache): Don't assume cache_len fits in int.
2695 * region-cache.h: Adjust extern decls to match.
2696
2697 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2698 EMACS_INT, since either will do, for xpalloc.
2699
2700 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2701 (xnmalloc, xnrealloc, xpalloc): New functions.
2702
2703 * bidi.c (bidi_shelve_header_size): New constant.
2704 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2705 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2706
2707 * bidi.c (bidi_cache_shrink):
2708 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2709 (overlay_strings):
2710 Don't update size of array until after memory allocation succeeds,
2711 because xmalloc/xrealloc may not return.
2712 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2713 now that we have proper integer overflow checking.
2714 (record_overlay_string, overlay_strings): Catch overflows when
2715 calculating size of overlay_str_buf.
2716
2717 * callproc.c (Fcall_process): Check for size overflow when
2718 calculating size of args2.
2719 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2720 Normally we prefer signed values, but sticking with ptrdiff_t would
2721 require adding more-complicated checks.
2722
2723 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2724 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2725 Redo buffer-overflow calculations to avoid integer overflow.
2726 Add a FIXME comment where memory seems to be over-allocated.
2727
2728 * character.c (Fstring): Check for size-calculation overflow.
2729
2730 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2731 unnecessary integer overflow. Check for size overflow.
2732 (encode_coding_object): Don't update size until xmalloc succeeds.
2733
2734 * composite.c (get_composition_id): Check for overflow in glyph
2735 length calculations.
2736
2737 Integer and memory overflow fixes for display code.
2738 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2739 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2740 (scrolling_window): Check for overflow in size calculations.
2741 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2742 Don't assume glyph table len fits in int.
2743 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2744 (row_table_size): Now ptrdiff_t, not int.
2745 (scrolling_window): Avoid overflow in size calculations.
2746 Don't update size until allocation succeeds.
2747 * fns.c (concat): Check for overflow in size calculations.
2748 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2749 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2750 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2751
2752 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2753 (get_doc_string): Check for size calculation overflow.
2754 Don't update size until allocation succeeds.
2755 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2756 EMACS_INT, where ptrdiff_t will do.
2757 (Fsubstitute_command_keys): Check for string overflow.
2758
2759 * editfns.c (set_time_zone_rule): Don't assume environment length
2760 fits in int.
2761 (message_length): Now ptrdiff_t, not int.
2762 (Fmessage_box): Don't update size until allocation succeeds.
2763 Don't assume message length fits in int.
2764 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2765
2766 * emacs.c (main): Do not reallocate argv, since there is a null at
2767 the end that can be overwritten, and this way there's no need to
2768 worry about size-calculation overflow.
2769 (sort_args): Check for size-calculation overflow.
2770
2771 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2772 alloc succeeds.
2773 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2774
2775 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2776 (x_set_scroll_bar_width, x_figure_window_size):
2777 Check for integer overflow.
2778 (x_set_alpha): Do not assume XINT fits in int.
2779
2780 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2781 This is for the members text_lines, text_cols, total_lines, total_cols,
2782 where the system imposes an 'int' limit.
2783
2784 * fringe.c (Fdefine_fringe_bitmap):
2785 Don't update size until alloc works.
2786
2787 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2788 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2789
2790 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2791 Check for size-calculation overflow.
2792 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2793 do, as we prefer signed integers.
2794 (id_to_widget.max_size, id_to_widget.used)
2795 (xg_store_widget_in_map, xg_remove_widget_from_map)
2796 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2797 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2798 Use and return ptrdiff_t, not int.
2799 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2800 * gtkutil.h: Change prototypes to match the above.
2801
2802 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2803 are duplicate now that they've been promoted to lisp.h.
2804 (x_allocate_bitmap_record, x_alloc_image_color)
2805 (make_image_cache, cache_image, xpm_load):
2806 Don't update size until alloc is done.
2807 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2808 (x_detect_edges):
2809 Check for size calculation overflow.
2810 (ct_colors_allocated_max): New constant.
2811 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2812 overflow.
2813
2814 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2815 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2816 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2817 Use ptrdiff_t, not int, to count maps.
2818 (read_char_minibuf_menu_prompt): Check for overflow in size
2819 calculations. Don't update size until allocation succeeds.
2820 Redo calculations to avoid overflow.
2821 * keyboard.h: Change prototypes to match the above.
2822
2823 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2824 to count maps.
2825 (current_minor_maps): Check for size calculation overflow.
2826 * keymap.h: Change prototypes to match the above.
2827
2828 * lread.c (read1, init_obarray): Don't update size until alloc done.
2829
2830 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2831 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2832
2833 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2834 Now ptrdiff_t, not int.
2835 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2836 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2837
2838 * process.c (Fnetwork_interface_list): Check for overflow
2839 in size calculation.
2840
2841 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2842
2843 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2844 overflow. Don't bother calling xmalloc when xrealloc will do.
2845
2846 * search.c (Freplace_match): Check for size calculation overflow.
2847 (Fset_match_data): Don't assume list lengths fit in 'int'.
2848
2849 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2850 for command line length. Do not attempt to address one before the
2851 beginning of an array, as that's not portable.
2852
2853 * term.c (max_frame_lines): Remove; unused.
2854 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2855 not int.
2856 (encode_terminal_code, calculate_costs): Check for size
2857 calculation overflow.
2858 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2859 table lengths and related sizes. Don't update size until alloc
2860 done. Redo calculations to avoid overflow.
2861 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2862
2863 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2864 subtracting pointers.
2865 (gobble_line): Check for overflow more carefully. Don't update size
2866 until alloc done.
2867
2868 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2869 Don't update size until alloc done.
2870 Redo size calculations to avoid overflow.
2871 Check for size calculation overflow.
2872 (main) [DEBUG]: Fix typo in invoking tparam1.
2873
2874 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2875 Use ptrdiff_t, not int, for sizes.
2876 (store_mode_line_noprop_char): Don't update size until alloc done.
2877
2878 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2879 Use ptrdiff_t, not int, for sizes.
2880 (Finternal_make_lisp_face, cache_face):
2881 Check for size calculation overflow.
2882 (cache_face): Treat size calculation overflows as if they were
2883 memory exhaustion (the usual treatment), rather than aborting.
2884
2885 * xfns.c (x_encode_text, x_set_name_internal)
2886 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2887 sizes, since they can exceed INT_MAX in size. Check for size
2888 calculation overflow.
2889
2890 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2891 (xg_select): Check for size calculation overflow.
2892 Don't update size until alloc done.
2893
2894 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2895 as sprintf is limited to int lengths.
2896
2897 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2898 (X_LONG_MIN): New macros.
2899 Use them to make the following changes clearer.
2900 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2901 This change doesn't affect the value now, but it may help remind
2902 future maintainers not to raise the value too much later.
2903 (SELECTION_QUANTUM): Remove, replacing with ...
2904 (selection_quantum): ... new function, which avoids overflow.
2905 All uses changed.
2906 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2907 assumption that selection length fits in 'int'.
2908 (x_reply_selection_request, x_handle_selection_request)
2909 (x_get_window_property, receive_incremental_selection)
2910 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2911 (lisp_data_to_selection_data, clean_local_selection_data):
2912 Use ptrdiff_t, not int, to record length of selection.
2913 (x_reply_selection_request, x_get_window_property)
2914 (receive_incremental_selection, x_property_data_to_lisp):
2915 Redo calculations to avoid overflow.
2916 (x_reply_selection_request): When sending hint, ceiling it at
2917 X_LONG_MAX rather than relying on wraparound overflow to send
2918 something.
2919 (x_get_window_property, receive_incremental_selection)
2920 (lisp_data_to_selection_data, x_property_data_to_lisp):
2921 Check for size-calculation overflow.
2922 (x_get_window_property, receive_incremental_selection)
2923 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2924 Don't store size until memory allocation succeeds.
2925 (x_get_window_property): Plug memory leak on memory exhaustion.
2926 Don't double-block input; malloc is safe here. Don't assume 2**34
2927 - 4 fits in unsigned long. Add an xassert to check
2928 XGetWindowProperty overflow. Be more careful about overflow
2929 calculations, and distinguish size from memory overflow better.
2930 (receive_incremental_selection): When tracing, don't assume
2931 unsigned int is less than INT_MAX.
2932 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2933 harmful) conversions of unsigned short to int.
2934 (lisp_data_to_selection_data): Don't assume that integers
2935 in the range -65535 through -1 fit in an X unsigned short.
2936 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2937 result parameters unless successful. Rely on cons_to_unsigned
2938 to report problems with elements; the old code wasn't right anyway.
2939 (x_check_property_data): Check for int overflow; we cannot use
2940 a wider type due to X limits.
2941 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2942
2943 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2944
2945 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2946 (x_term_init): Check for size calculation overflow.
2947 (x_color_cells): Don't store size until memory allocation succeeds.
2948 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2949 Don't assume alloca size is less than MAX_ALLOCA.
2950 (x_term_init): Don't assume length fits in int (sprintf is limited
2951 to int size).
2952
2953 Use ptrdiff_t for composition IDs.
2954 * character.c (lisp_string_width):
2955 * composite.c (composition_table_size, n_compositions)
2956 (get_composition_id, composition_gstring_from_id):
2957 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2958 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2959 * window.c (Frecenter):
2960 Use ptrdiff_t, not int, for composition IDs.
2961 * composite.c (get_composition_id): Check for integer overflow.
2962 * composite.h: Adjust prototypes to match the above changes.
2963
2964 Use ptrdiff_t for hash table indexes.
2965 * category.c (hash_get_category_set):
2966 * ccl.c (ccl_driver):
2967 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2968 * coding.c (coding_system_charset_list, detect_coding_system):
2969 * coding.h (struct coding_system.id):
2970 * composite.c (get_composition_id, gstring_lookup_cache):
2971 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2972 * image.c (xpm_get_color_table_h):
2973 * lisp.h (hash_lookup, hash_put):
2974 * minibuf.c (Ftest_completion):
2975 Use ptrdiff_t for hash table indexes, not int (which is too
2976 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2977 32-bit --with-wide-int hosts).
2978
2979 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2980 Add a FIXME comment about memory leaks.
2981 (syms_of_charset): Don't assume xmalloc returns.
2982
2983 Don't assume that stated character widths fit in int.
2984 * character.c (Fchar_width, c_string_width, lisp_string_width):
2985 * character.h (CHAR_WIDTH):
2986 * indent.c (MULTIBYTE_BYTES_WIDTH):
2987 Use sanitize_char_width to avoid undefined and/or bad behavior
2988 with outlandish widths.
2989 * character.h (sanitize_tab_width): Rename from sanitize_width,
2990 now that we have two such functions. All uses changed.
2991 (sanitize_char_width): New inline function.
2992
2993 Don't assume that tab-width fits in int.
2994 * character.h (sanitize_width): New inline function.
2995 (SANE_TAB_WIDTH): New macro.
2996 (ASCII_CHAR_WIDTH): Use it.
2997 * indent.c (sane_tab_width): Remove. All uses replaced by
2998 SANE_TAB_WIDTH (current_buffer).
2999 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3000
3001 * fileio.c: Integer overflow issues with file modes.
3002 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3003
3004 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3005 Remove unreachable code.
3006 (read_hex, load_charset_map_from_file): Check for integer overflow.
3007
3008 * xterm.c: Don't go over XClientMessageEvent limit.
3009 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3010 (x_send_scroll_bar_event): Likewise. Check that the size does not
3011 exceed limits imposed by XClientMessageEvent, as well as the usual
3012 ptrdiff_t and size_t limits.
3013
3014 * keyboard.c: Overflow, signedness and related fixes.
3015 (make_lispy_movement): Use same integer type in forward decl
3016 that is used in the definition.
3017 (read_key_sequence, keyremap_step):
3018 Change bufsize argument back to int, undoing my 2011-03-30 change.
3019 We prefer signed types, and int is wide enough here.
3020 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3021 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3022 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3023 length, not size_t. Use ptrdiff_t for index, not int.
3024 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3025 possibility of integer overflow.
3026
3027 Overflow, signedness and related fixes for images.
3028
3029 * dispextern.h (struct it.stack[0].u.image.image_id)
3030 (struct_it.image_id, struct image.id, struct image_cache.size)
3031 (struct image_cache.used, struct image_cache.ref_count):
3032 * gtkutil.c (update_frame_tool_bar):
3033 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3034 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3035 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3036 * nsmenu.m (update_frame_tool_bar):
3037 * xdisp.c (calc_pixel_width_or_height):
3038 * xfns.c (image_cache_refcount):
3039 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3040 on typical 64-bit hosts.
3041
3042 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3043 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3044 Omit unnecessary casts to int.
3045 (parse_image_spec): Check that integers fall into 'int' range
3046 when the callers expect that.
3047 (image_ascent): Redo ascent calculation to avoid int overflow.
3048 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3049 (lookup_image): Remove unnecessary tests.
3050 (xbm_image_p): Locals are now of int, not EMACS_INT,
3051 since parse_image_check makes sure they fit into int.
3052 (png_load, gif_load, svg_load_image):
3053 Prefer int to unsigned where either will do.
3054 (tiff_handler): New function, combining the cores of the
3055 old tiff_error_handler and tiff_warning_handler.
3056 This function is rewritten to use vsnprintf and thereby avoid
3057 stack buffer overflows. It uses only the features of vsnprintf
3058 that are common to both POSIX and native Microsoft.
3059 (tiff_error_handler, tiff_warning_handler): Use it.
3060 (tiff_load, gif_load, imagemagick_load_image):
3061 Don't assume :index value fits in 'int'.
3062 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3063 (imagemagick_load_image): Check that crop parameters fit into
3064 the integer types that MagickCropImage accepts. Don't assume
3065 Vimagemagick_render_type has a nonnegative value. Don't assume
3066 size_t fits in 'long'.
3067 (gs_load): Use printmax_t to print the widest integers possible.
3068 Check for integer overflow when computing image height and width.
3069
3070 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3071
3072 * xdisp.c (redisplay_window): Don't force window start if point
3073 will be invisible in the resulting window. (Bug#9324)
3074
3075 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3076
3077 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3078 the display spec is of the form `(space ...)'.
3079 (handle_display_spec): Return the value returned by
3080 handle_single_display_spec, not just 1 or zero.
3081 (handle_single_display_spec): If the display spec is of the form
3082 `(space ...)', and specifies display in the text area, return 2
3083 rather than 1.
3084 (try_cursor_movement): Check for the need to scroll more
3085 accurately, and prefer exact match for point under bidi.
3086 Don't advance `row' beyond the last row of the window.
3087
3088 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3089 into disp_prop; all users changed.
3090
3091 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3092 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3093 for the text covered by the display property.
3094
3095 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3096
3097 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3098 Change return value to nil.
3099 (Frecord_buffer): Delete unused function.
3100
3101 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3102
3103 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3104 buffers, return left-to-right.
3105 (set_cursor_from_row): Consider candidate row a win if its glyph
3106 represents a newline and point is on that newline. Fixes cursor
3107 positioning on the newline at EOL of R2L text within L2R
3108 paragraph, and vice versa.
3109 (try_cursor_movement): Check continued rows, in addition to
3110 continuation rows. Fixes unwarranted scroll when point enters a
3111 continued line of R2L text within an L2R paragraph, or vice versa.
3112 (cursor_row_p): Consider the case of point being equal to
3113 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3114 from the end of a short line to the beginning of a continued line
3115 of R2L text within L2R paragraph.
3116 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3117 composed characters.
3118
3119 * bidi.c (bidi_check_type): Use xassert.
3120 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3121 members.
3122
3123 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3124
3125 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3126 a character.
3127
3128 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3129
3130 * nsfont.m (ns_otf_to_script): Fix typo.
3131
3132 2011-08-22 Kenichi Handa <handa@m17n.org>
3133
3134 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3135 extra slot even if the purpose is char-code-property-table.
3136
3137 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3138
3139 * xdisp.c (redisplay_window): When computing centering_position,
3140 account for the height of the header line. (Bug#8874)
3141
3142 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3143 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3144 candidate is selected by the mouse, and that candidate has a
3145 composed character under the mouse.
3146
3147 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3148 coordinates reported by pos-visible-in-window-p for a composed
3149 character in column zero.
3150
3151 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3152
3153 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3154
3155 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3156
3157 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3158 consider it a hit if to_charpos is anywhere in the range of the
3159 composed buffer positions.
3160
3161 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3162
3163 * image.c (gif_load): Don't assume that each subimage has the same
3164 dimensions as the base image. Handle disposal method that is
3165 "undefined" by the gif spec (Bug#9335).
3166
3167 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3168
3169 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3170 (Fcondition_case): Document `debug' symbol in error handler.
3171
3172 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3173
3174 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3175 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3176 from an Org mode buffer to a Speedbar frame.
3177
3178 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3179 a composition, take its buffer position from IT->cmp_it.charpos.
3180 Fixes cursor positioning at the beginning of a line that begins
3181 with a composed character.
3182
3183 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3184
3185 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3186 character bidirectional type, use STRONG_L instead. Fixes crashes
3187 in a buffer produced by `describe-categories'.
3188
3189 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3190 members before the level stack, so they would be saved and
3191 restored when copying iterator state. Fixes incorrect reordering
3192 around TABs covered by display properties.
3193
3194 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3195
3196 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3197
3198 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3199
3200 * eval.c (internal_condition_case, internal_condition_case_1)
3201 (internal_condition_case_2, internal_condition_case_n):
3202 Remove unnecessary aborts (Bug#9081).
3203
3204 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3205
3206 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3207 has no `load' handler, try opening the file locally. (Bug#9311)
3208
3209 2011-08-16 Ken Brown <kbrown@cornell.edu>
3210
3211 * gmalloc.c: Expand comment.
3212
3213 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3214
3215 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3216 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3217
3218 2011-08-16 Ken Brown <kbrown@cornell.edu>
3219
3220 Fix memory allocation problems in Cygwin build (Bug#9273).
3221
3222 * unexcw.c ( __malloc_initialized): Declare external variable.
3223 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3224
3225 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3226 New variables.
3227 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3228 dumped emacs.
3229 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3230 in the static heap.
3231 [CYGWIN] (special_realloc): New function.
3232 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3233 requests to realloc storage in the static heap.
3234
3235 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3236
3237 * bidi.c (bidi_initialize): Remove unused local.
3238
3239 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3240
3241 * bidimirror.h:
3242 * biditype.h: Remove file.
3243 * makefile.w32-in ($(BLD)/bidi.$(O)):
3244 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3245
3246 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3247
3248 * chartab.c: Improve commentary for the uniprop_table API.
3249
3250 * bidi.c (bidi_paragraph_init): Support zero value of
3251 bidi_ignore_explicit_marks_for_paragraph_level.
3252 (bidi_initialize): Use uniprop_table instead of including
3253 biditype.h and bidimirror.h.
3254
3255 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3256 coordinates of the iterator when restoring from ppos_it.
3257 (Bug#9296)
3258
3259 2011-08-14 Kenichi Handa <handa@m17n.org>
3260
3261 * process.c (create_process): Call setup_process_coding_systems
3262 after the pid of the process is set to -1 (Bug#8162).
3263
3264 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3265
3266 * xdisp.c (move_it_in_display_line_to): Don't invoke
3267 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3268 ppos_it. Fixes vertical cursor motion when line beginning is
3269 covered by an image. (Bug#9296)
3270
3271 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3272
3273 * nsterm.h (ns_run_ascript): Declare.
3274 (NSAPP_DATA2_RUNASSCRIPT): Define.
3275
3276 * nsfns.m (as_script, as_result, as_status): New static variables.
3277 (ns_run_ascript): New function.
3278 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3279 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3280 the event loop. Get status from as_status (Bug#7276).
3281
3282 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3283 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3284 the event loop (Bug#7276).
3285
3286 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3287
3288 * gnutls.c (QCgnutls_bootprop_priority)
3289 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3290 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3291 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3292 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3293 (QCgnutls_bootprop_verify_hostname_error)
3294 (QCgnutls_bootprop_callbacks_verify): Rename from
3295 Qgnutls_bootprop_..., all uses changed.
3296
3297 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3298 uses changed.
3299
3300 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3301
3302 * xfaces.c (Qframe_set_background_mode): Now static.
3303 * dispextern.h (Qframe_set_background_mode): Remove decl.
3304
3305 * process.c (Fnetwork_interface_info): Declare local only if needed.
3306
3307 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3308
3309 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3310 (Fnetwork_interface_list): Allocate in increments of bytes instead
3311 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3312 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3313 sockaddr.
3314 (struct ifflag_def): notrailers is smart on OSX.
3315 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3316 Get hardware address with getifaddrs if available.
3317
3318 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3319
3320 * xdisp.c (iterate_out_of_display_property): xassert that
3321 IT->position is set to within IT->object's boundaries. Break from
3322 the loop as soon as EOB is reached; avoids infloops in redisplay
3323 when IT->position is set up wrongly due to some bug.
3324 Set IT->current to match the bidi iterator unconditionally.
3325 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3326 entry. Force push_it to save on the stack the current
3327 buffer/string position, to be restored by pop_it. Fix flags in
3328 the iterator structure wrt the object coming from a display
3329 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3330 properties. (Bug#9284)
3331
3332 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3333
3334 * fontset.c (fontset_get_font_group): Add proper type checks.
3335 (Bug#9172)
3336
3337 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3338
3339 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3340 and LC_VERSION_MIN_MACOSX.
3341 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3342 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3343
3344 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3345
3346 * xdisp.c (forward_to_next_line_start): Allow to use the
3347 no-display-properties-and-no-overlays under bidi display.
3348 Set disp_pos in the bidi iterator to avoid searches for display
3349 properties and overlays.
3350
3351 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3352
3353 * editfns.c (Fset_time_zone_rule): Document relationship with the
3354 setenv function.
3355
3356 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3357 the font entity extracted from the cache (Bug#8109).
3358
3359 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3360
3361 * composite.c (autocmp_chars): Don't reset point. That is done by
3362 restore_point_unwind (Bug#5984).
3363
3364 2011-08-07 Juri Linkov <juri@jurta.org>
3365
3366 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3367 to show the arg `TIME' instead of `TIMEVAL'.
3368
3369 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3370
3371 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3372 display property strides EOL and includes a newline, as in
3373 longlines-mode. (Bug#9254)
3374 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3375 word-wrap under bidirectional display. (Bug#9224)
3376
3377 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3378 is non-zero, even if the data buffer is NULL. Fixes a crash in
3379 vertical-motion with longlines-mode. (Bug#9254)
3380
3381 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3382
3383 * bidi.c <bidi_cache_total_alloc>: Now static.
3384 (bidi_initialize): Initialize bidi_cache_total_alloc.
3385
3386 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3387 cache. (Bug#9221)
3388
3389 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3390 amount allocated this far in `bidi_cache_total_alloc'.
3391 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3392 non-zero, only free the data buffer without restoring the cache
3393 contents. All callers changed.
3394
3395 * dispextern.h (bidi_unshelve_cache): Update prototype.
3396
3397 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3398 (move_it_in_display_line, move_it_to)
3399 (move_it_vertically_backward, move_it_by_lines): Replace the call
3400 to xfree to an equivalent call to bidi_unshelve_cache.
3401 (move_it_in_display_line_to): Fix logic of returning
3402 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3403
3404 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3405
3406 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3407 came from a string character with a `cursor' property. (Bug#9229)
3408
3409 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3410
3411 * Makefile.in (LIB_PTHREAD): New variable.
3412 (LIBES): Add LIB_PTHREAD (Bug#9216).
3413
3414 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3415 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3416
3417 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3418
3419 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3420
3421 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3422
3423 * xterm.c (x_find_topmost_parent): New function.
3424 (x_set_frame_alpha): Find topmost parent window with
3425 x_find_topmost_parent and set the property there also (bug#9181).
3426 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3427
3428 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3429
3430 * callproc.c (Fcall_process): Avoid vfork clobbering
3431 the local vars buffer, coding_systems, current_dir.
3432
3433 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3434
3435 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3436
3437 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3438
3439 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3440 so that it is not optimized away.
3441
3442 * xdisp.c (compute_display_string_pos): Remove unused local.
3443
3444 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3445
3446 Fix slow cursor motion and scrolling in large buffers with
3447 selective display, like Org Mode buffers. (Bug#9218)
3448
3449 * dispextern.h (struct bidi_it): New member disp_prop_p.
3450
3451 * xdisp.c: Remove one-slot cache of display string positions.
3452 (compute_display_string_pos): Accept an additional argument
3453 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3454 for a display string or property. If found, set DISP_PROP_P
3455 non-zero.
3456
3457 * bidi.c (bidi_fetch_char): Accept an additional argument
3458 DISP_PROP_P, and pass it to compute_display_string_pos.
3459 Only handle text covered by a display string if DISP_PROP_P is returned
3460 non-zero. All callers of bidi_fetch_char changed.
3461
3462 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3463
3464 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3465
3466 2010-12-03 Don March <don@ohspite.net>
3467
3468 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3469 last character M-[char] is translated to ESC [char] (bug#7541).
3470
3471 2011-08-02 Kenichi Handa <handa@m17n.org>
3472
3473 * lisp.h (uniprop_table): Extern it.
3474
3475 * chartab.c (uniprop_table): Make it non-static.
3476
3477 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3478
3479 * xdisp.c (forward_to_next_line_start): Accept additional argument
3480 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3481 on the newline.
3482 (reseat_at_next_visible_line_start): Use the bidi iterator state
3483 returned by forward_to_next_line_start to restore the state of
3484 it->bidi_it after backing up to previous newline. (Bug#9212)
3485
3486 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3487
3488 * regex.c (re_comp): Protoize.
3489 (re_exec): Fix return type.
3490 (regexec): Fix type of `ret'. (Bug#9203)
3491
3492 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3493
3494 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3495 This is needed if max-image-size is a floating-point number.
3496
3497 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3498
3499 * print.c (print_object): Print empty symbol as ##.
3500
3501 * lread.c (read1): Read ## as empty symbol.
3502
3503 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3504
3505 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3506 setting frame foreground color (Bug#9175).
3507 (x_set_background_color): Likewise.
3508
3509 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3510 contents (Bug#9176).
3511 (EmacsTooltip -init): Remove bezels and add shadows to
3512 tooltip windows.
3513
3514 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3515 or scroll bar (Bug#8470).
3516
3517 * nsfont.m (nsfont_open): Remove assignment to voffset and
3518 unnecessary vars hshink, expand, hd, full_height, min_height.
3519 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3520
3521 * nsterm.h (nsfont_info): Remove voffset field.
3522
3523 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3524
3525 Implement strike-through and overline on NextStep (Bug#8863).
3526
3527 * nsfont.m (nsfont_open): Use underline position provided by font,
3528 instead of hard-coded value of 2.
3529 (nsfont_draw): Call ns_draw_text_decoration instead.
3530
3531 * nsterm.h: Add declaration for ns_draw_text_decoration.
3532
3533 * nsterm.m (ns_draw_text_decoration): New function for drawing
3534 underline, overline, and strike-through.
3535 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3536 ns_draw_text_decoration. Change treatment of cursor drawing to
3537 accommodate underlining, etc.
3538
3539 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3540
3541 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3542 default.
3543
3544 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3545
3546 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3547 Without this fix, if a signal arrives just after memory fills up,
3548 'malloc' might be invoked reentrantly.
3549
3550 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3551 In other words, assume that every image size is allowed, on non-X
3552 hosts. This assumption is probably wrong, but it lets Emacs compile.
3553
3554 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3555
3556 * regex.c (re_iswctype): Convert return values to boolean.
3557
3558 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3559
3560 * xdisp.c (compute_display_string_pos): Don't use cached display
3561 string position if the buffer had its restriction changed.
3562 (Bug#9184)
3563
3564 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3565
3566 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3567
3568 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3569
3570 Integer signedness and overflow and related fixes. (Bug#9079)
3571
3572 * bidi.c: Integer size and overflow fixes.
3573 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3574 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3575 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3576 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3577 (bidi_find_other_level_edge):
3578 Use ptrdiff_t instead of EMACS_INT where either will do.
3579 This works better on 32-bit hosts configured --with-wide-int.
3580 (bidi_cache_ensure_space): Check for size-calculation overflow.
3581 Use % rather than repeated addition, for better worst-case speed.
3582 Don't set bidi_cache_size until after xrealloc returns, because it
3583 might not return.
3584 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3585 (bidi_cache_ensure_space): Also check that the bidi cache size
3586 does not exceed that of the largest Lisp string or buffer. See Eli
3587 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3588
3589 * alloc.c (__malloc_size_t): Remove.
3590 All uses replaced by size_t. See Andreas Schwab's note
3591 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3592
3593 * image.c: Improve checking for integer overflow.
3594 (check_image_size): Assume that f is nonnull, since
3595 it is always nonnull in practice. This is one less thing to
3596 worry about when checking for integer overflow later.
3597 (x_check_image_size): New function, which checks for integer
3598 overflow issues inside X.
3599 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3600 This removes the need for a memory_full check.
3601 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3602 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3603 (xbm_read_bitmap_data): Change locals back to 'int', since
3604 their values must fit in 'int'.
3605 (xpm_load_image, png_load, tiff_load):
3606 Invoke x_create_x_image_and_pixmap earlier,
3607 to avoid much needless work if the image is too large.
3608 (tiff_load): Treat overly large images as if
3609 x_create_x_image_and_pixmap failed, not as malloc failures.
3610 (gs_load): Use x_check_image_size.
3611
3612 * gtkutil.c: Omit integer casts.
3613 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3614 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3615
3616 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3617
3618 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3619 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3620 would wrongly return t on a 64-bit host.
3621
3622 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3623 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3624 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3625 and therefore cause GCC to emit a bogus diagnostic in some cases.
3626
3627 * image.c: Integer signedness and overflow and related fixes.
3628 This is not an exhaustive set of fixes, but it's time to
3629 record what I've got.
3630 (lookup_pixel_color, check_image_size): Remove redundant decls.
3631 (check_image_size): Don't assume that arbitrary EMACS_INT values
3632 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3633 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3634 (tiff_load, imagemagick_load_image):
3635 Check for overflow in size calculations.
3636 (x_create_x_image_and_pixmap): Remove unnecessary test for
3637 xmalloc returning NULL; that can't happen.
3638 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3639 (xpm_color_bucket): Use better integer hashing function.
3640 (xpm_cache_color): Don't possibly over-allocate memory.
3641 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3642 (gif_memory_source):
3643 Use ptrdiff_t, not int or size_t, to record sizes.
3644 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3645 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3646 either works, as we prefer signed integers.
3647 (tiff_read_from_memory, tiff_write_from_memory):
3648 Return tsize_t, not size_t, since that's what the TIFF API wants.
3649 (tiff_read_from_memory): Don't fail simply because the read would
3650 go past EOF; instead, return a short read.
3651 (tiff_load): Omit no-longer-needed casts.
3652 (Fimagemagick_types): Don't assume size fits into 'int'.
3653
3654 Improve hashing quality when configured --with-wide-int.
3655 * fns.c (hash_string): New function, taken from sxhash_string.
3656 Do not discard information about ASCII character case; this
3657 discarding is no longer needed.
3658 (sxhash-string): Use it. Change sig to match it. Caller changed.
3659 * lisp.h: Declare it.
3660 * lread.c (hash_string): Remove, since we now use fns.c's version.
3661 The fns.c version returns a wider integer if --with-wide-int is
3662 specified, so this should help the quality of the hashing a bit.
3663
3664 * emacs.c: Integer overflow minor fix.
3665 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3666 Define only if GNU_LINUX.
3667 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3668
3669 * dispnew.c: Integer signedness and overflow fixes.
3670 Remove unnecessary forward decls, that were a maintenance hassle.
3671 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3672 All uses changed.
3673 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3674 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3675 (prepare_desired_row, line_draw_cost):
3676 Use int, not unsigned, where either works.
3677 (save_current_matrix, restore_current_matrix):
3678 Use ptrdiff_t, not size_t, where either works.
3679 (init_display): Check for overflow more accurately, and without
3680 relying on undefined behavior.
3681
3682 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3683 Remove, replacing with the new symbols in lisp.h. All uses changed.
3684 * fileio.c (make_temp_name):
3685 * filelock.c (lock_file_1, lock_file):
3686 * xdisp.c (message_dolog):
3687 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3688 Use pMd etc. instead.
3689 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3690 replacing the pWIDE etc. symbols removed from editfns.c.
3691
3692 * keyboard.h (num_input_events): Now uintmax_t.
3693 This is (very slightly) less likely to mess up due to wraparound.
3694 All uses changed.
3695
3696 * buffer.c: Integer signedness fixes.
3697 (alloc_buffer_text, enlarge_buffer_text):
3698 Use ptrdiff_t rather than size_t when either will do, as we prefer
3699 signed integers.
3700
3701 * alloc.c: Integer signedness and overflow fixes.
3702 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3703 (__malloc_size_t): Default to size_t, not to int.
3704 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3705 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3706 Prefer ptrdiff_t to size_t when either would do, as we prefer
3707 signed integers.
3708 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3709 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3710 Now const. Initialize with values that are in range even if char
3711 is signed.
3712 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3713 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3714 These functions do the right thing with sizes > 2**32.
3715 (check_depth): Now ptrdiff_t, not int.
3716 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3717 Adjust to new way of storing sizes. Check for size overflow bugs
3718 in rest of code.
3719 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3720 slightly wrong anyway, as it missed one instance of
3721 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3722 (refill_memory_reserve): Omit needless cast to size_t.
3723 (mark_object_loop_halt): Mark as externally visible.
3724
3725 * xselect.c: Integer signedness and overflow fixes.
3726 (Fx_register_dnd_atom, x_handle_dnd_message):
3727 Use ptrdiff_t, not size_t, since we prefer signed.
3728 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3729 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3730 x_dnd_atoms_size and x_dnd_atoms_length.
3731
3732 * doprnt.c: Prefer signed to unsigned when either works.
3733 * eval.c (verror):
3734 * doprnt.c (doprnt):
3735 * lisp.h (doprnt):
3736 * xdisp.c (vmessage):
3737 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3738 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3739 prefer signed arithmetic to avoid comparison confusion.
3740 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3741 but is a bit tricky.
3742
3743 Assume freestanding C89 headers, string.h, stdlib.h.
3744 * data.c, doprnt.c, floatfns.c, print.c:
3745 Include float.h unconditionally.
3746 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3747 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3748 * regex.c: Likewise for stddef.h, string.h.
3749 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3750 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3751 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3752 (STDC_HEADERS): Remove obsolete defines.
3753 * sysdep.c: Include limits.h unconditionally.
3754
3755 Assume support for memcmp, memcpy, memmove, memset.
3756 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3757 * regex.c (memcmp, memcpy):
3758 Remove; we assume C89 now.
3759
3760 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3761 (__malloc_safe_bcopy): Remove; no longer needed.
3762
3763 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3764 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3765 well either way, and we prefer signed to unsigned.
3766
3767 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3768
3769 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3770 closes the connection while we're reading (bug#9182).
3771
3772 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3773
3774 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3775 are specified (Bug#9168).
3776
3777 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3778
3779 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3780 Found by GCC static checking and --with-wide-int on a 32-bit host.
3781
3782 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3783
3784 * xdisp.c (compute_display_string_pos): Fix logic of caching
3785 previous display string position. Initialize cached_prev_pos to
3786 -1. Fixes slow-down at the beginning of a buffer.
3787
3788 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3789
3790 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3791 for attrs[LFACE_FONTSET_INDEX].
3792
3793 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3794
3795 * xml.c (parse_region): Remove unused local
3796 that was recently introduced.
3797
3798 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3799
3800 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3801 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3802
3803 * xdisp.c (move_it_in_display_line_to): Record the best matching
3804 position for TO_CHARPOS while scanning the line, and restore it on
3805 exit if none of the characters scanned was an exact match.
3806 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3807 when exact match is impossible due to invisible text, and the
3808 lines are truncated.
3809
3810 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3811
3812 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3813 for OSX >= 10.7.
3814
3815 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3816
3817 Fix a significant slow-down of cursor motion with C-n, C-p,
3818 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3819 auto-repeat under bidi redisplay in fontified buffers.
3820 * xdisp.c (compute_stop_pos_backwards): New function.
3821 (next_element_from_buffer): Call compute_stop_pos_backwards to
3822 find a suitable prev_stop when we find ourselves before
3823 base_level_stop.
3824 (reseat): Don't look for prev_stop, as that could mean a very long
3825 run.
3826 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3827 <cached_disp_overlay_modiff>: Cache for last found display string
3828 position.
3829 (compute_display_string_pos): Return the cached position if asked
3830 about the same buffer in the same area of character positions, and
3831 the buffer wasn't changed since the time the display string
3832 position was cached.
3833
3834 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3835
3836 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3837 is an integer, which is important for empty lines. (Bug#9149)
3838
3839 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3840
3841 * frame.c (Fmodify_frame_parameters): In tty case, update the
3842 default face if necessary (Bug#4238).
3843
3844 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3845
3846 * editfns.c (Fstring_to_char): No need to explain what a character
3847 is in the docstring (Bug#6576).
3848
3849 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3850
3851 * xml.c (parse_region): Make sure we always return a tree.
3852
3853 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3854
3855 * xml.c (parse_region): If a document contains only comments,
3856 return that, too.
3857
3858 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3859
3860 * xml.c (make_dom): Return comments, too.
3861
3862 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3863
3864 Port to OpenBSD.
3865 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3866 and the surrounding thread.
3867 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3868 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3869 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3870 timer goes off.
3871 * s/openbsd.h (BROKEN_SIGIO): Define.
3872 * unexelf.c (unexec) [__OpenBSD__]:
3873 Don't update the .mdebug section of the Alpha COFF symbol table.
3874
3875 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3876
3877 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3878 (bug#8460).
3879
3880 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3881
3882 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3883 This fixes some race conditions on the permissions of any newly
3884 created file.
3885
3886 * alloc.c (valid_pointer_p): Use pipe, not open.
3887 This fixes some permissions issues when debugging.
3888
3889 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3890 If fchown fails to set both uid and gid, try to set just gid,
3891 as that is sometimes allowed. Adjust the file's mode to eliminate
3892 setuid or setgid bits that are inappropriate if fchown fails.
3893
3894 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3895
3896 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3897 to compare Lisp_Objects.
3898 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3899 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3900 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3901
3902 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3903
3904 * lread.c (read_integer): Unread even EOF character.
3905 (read1): Likewise. Properly record start position of symbol.
3906
3907 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3908 symbol character follows.
3909
3910 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3911
3912 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3913 This works around a problem with the previous change to Fcopy_file.
3914 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3915 and without this change, GCC might complain about discarding
3916 fchown's return value.
3917
3918 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3919
3920 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3921
3922 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3923
3924 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3925
3926 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3927
3928 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3929 it's used from the C level.
3930
3931 * process.c: Use the same condition for POLL_FOR_INPUT in both
3932 keyboard.c and process.c (bug#1858).
3933
3934 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3935
3936 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3937 (Fgnutls_boot): Use it.
3938
3939 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3940
3941 * doc.c (Fsubstitute_command_keys): Revert last change.
3942
3943 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3944
3945 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3946 quotes the next character, and doesn't affect other longer
3947 sequences (bug#8935).
3948
3949 * lread.c (syms_of_lread): Clarify that is isn't only
3950 `eval-buffer' and `eval-defun' that's affected by
3951 `lexical-binding' (bug#8460).
3952
3953 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3954
3955 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3956 bidi redisplay when a line includes both an image and is truncated.
3957
3958 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3959
3960 Fix minor problems found by static checking.
3961 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3962 (elsz): Now a signed constant, not a size_t var. We prefer signed
3963 types to unsigned, to avoid integer comparison confusion. Without
3964 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3965 "cannot optimize loop, the loop counter may overflow", a symptom
3966 of the confusion.
3967 * indent.c (Fvertical_motion): Mark locals as initialized.
3968 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3969
3970 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3971
3972 * search.c (Fre_search_backward): Mention `case-fold-search' in
3973 all the re_search_* functions (bug#8138).
3974
3975 * keyboard.c (Fopen_dribble_file): Document when the file is
3976 closed (bug#8056).
3977
3978 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3979
3980 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3981 bidi_cache_idx.
3982
3983 Support bidi reordering of display and overlay strings.
3984 * xdisp.c (compute_display_string_pos)
3985 (compute_display_string_end): Accept additional argument STRING.
3986 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3987 (reseat_to_string): Initialize bidi_it->string.s and
3988 bidi_it->string.schars.
3989 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3990 NULL (avoids a crash in bidi_paragraph_init).
3991 Initialize itb.string.lstring.
3992 (init_iterator): Call bidi_init_it only of a valid
3993 buffer position was specified. Initialize paragraph_embedding to
3994 L2R.
3995 (reseat_to_string): Initialize the bidi iterator.
3996 (display_string): If we need to ignore text properties of
3997 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3998 original value of -1 will not work with bidi.)
3999 (compute_display_string_pos): First arg is now struct
4000 `text_pos *'; all callers changed. Support display properties on
4001 Lisp strings.
4002 (compute_display_string_end): Support display properties on Lisp
4003 strings.
4004 (init_iterator, reseat_1, reseat_to_string): Initialize the
4005 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4006 when iterating on a string not from display properties).
4007 (compute_display_string_pos, compute_display_string_end):
4008 Fix calculation of the object to scan. Fixes an error when using
4009 arrow keys.
4010 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4011 base_level_stop; instead, set base_level_stop to BEGV.
4012 Fixes crashes in vertical-motion.
4013 (next_element_from_buffer): Improve commentary for when
4014 the iterator is before prev_stop.
4015 (init_iterator): Initialize bidi_p from the default value of
4016 bidi-display-reordering, not from buffer-local value. Use the
4017 buffer-local value only if initializing for buffer iteration.
4018 (handle_invisible_prop): Support invisible properties on strings
4019 that are being bidi-reordered.
4020 (set_iterator_to_next): Support bidi reordering of C strings and
4021 Lisp strings.
4022 (next_element_from_string): Support bidi reordering of Lisp
4023 strings.
4024 (handle_stop_backwards): Support Lisp strings as well.
4025 (display_string): Support display of R2L glyph rows.
4026 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4027 (init_iterator): Don't initialize it->bidi_p for strings
4028 here.
4029 (reseat_to_string): Initialize it->bidi_p for strings here.
4030 (next_element_from_string, next_element_from_c_string)
4031 (next_element_from_buffer): Add xassert's for correspondence
4032 between IT's object being iterated and it->bidi_it.string
4033 structure.
4034 (face_before_or_after_it_pos): Support bidi iteration.
4035 (next_element_from_c_string): Handle the case of the first string
4036 character that is not the first one in the visual order.
4037 (get_visually_first_element): New function, refactored from common
4038 parts of next_element_from_buffer, next_element_from_string, and
4039 next_element_from_c_string.
4040 (tool_bar_lines_needed, redisplay_tool_bar)
4041 (display_menu_bar): Force left-to-right direction. Add a FIXME
4042 comment for making that be controlled by a user option.
4043 (push_it, pop_it): Save and restore the state of the
4044 bidi iterator. Save and restore the bidi_p flag.
4045 (pop_it): Iterate out of display property for string iteration as
4046 well.
4047 (iterate_out_of_display_property): Support iteration over strings.
4048 (handle_single_display_spec): Set up it->bidi_it for iteration
4049 over a display string, and call bidi_init_it.
4050 (handle_single_display_spec, next_overlay_string)
4051 (get_overlay_strings_1, push_display_prop): Set up the bidi
4052 iterator for displaying display or overlay strings.
4053 (forward_to_next_line_start): Don't use the shortcut if
4054 bidi-iterating.
4055 (back_to_previous_visible_line_start): If handle_display_prop
4056 pushed the iterator stack, restore the internal state of the bidi
4057 iterator by calling bidi_pop_it same number of times.
4058 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4059 and we are bidi-iterating, don't decrement the iterator position;
4060 instead, set the first_elt flag in the bidi iterator, to produce
4061 the same effect.
4062 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4063 (push_display_prop): xassert that we are iterating a buffer.
4064 (push_it, pop_it): Save and restore paragraph_embedding member.
4065 (handle_single_display_spec, next_overlay_string)
4066 (get_overlay_strings_1, reseat_1, reseat_to_string)
4067 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4068 correctly. Don't assume unibyte strings are not bidi-reordered.
4069 (compute_display_string_pos)
4070 (compute_display_string_end): Fix handling the case of C string.
4071 (push_it, pop_it): Save and restore from_disp_prop_p.
4072 (handle_single_display_spec, push_display_prop): Set the
4073 from_disp_prop_p flag.
4074 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4075 (pop_it): Call iterate_out_of_display_property only if we are
4076 popping after iteration over a string that came from a display
4077 property. Fix a typo in popping stretch info. Add an assertion
4078 for verifying that the iterator position is in sync with the bidi
4079 iterator.
4080 (handle_single_display_spec, get_overlay_strings_1)
4081 (push_display_prop): Fix initialization of paragraph direction for
4082 string when that of the parent object is not yet determined.
4083 (reseat_1): Call bidi_init_it to resync the bidi
4084 iterator with IT's position. (Bug#7616)
4085 (find_row_edges): If ROW->start.pos gives position
4086 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4087 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4088 Reset the from_disp_prop_p flag.
4089 (SAVE_IT, RESTORE_IT): New macros.
4090 (pos_visible_p, face_before_or_after_it_pos)
4091 (back_to_previous_visible_line_start)
4092 (move_it_in_display_line_to, move_it_in_display_line)
4093 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4094 (try_scrolling, redisplay_window, display_line): Use them when
4095 saving a temporary copy of the iterator and restoring it back.
4096 (back_to_previous_visible_line_start, reseat_1)
4097 (init_iterator): Empty the bidi cache "stack".
4098 (move_it_in_display_line_to): If iterator ended up at
4099 EOL, but we never saw any buffer positions smaller than
4100 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4101 motion in bidi-reordered lines.
4102 (move_it_in_display_line_to): Record prev_method and prev_pos
4103 immediately before the call to set_iterator_to_next. Fixes cursor
4104 motion in bidi-reordered lines with stretch glyphs and strings
4105 displayed in margins. (Bug#8133) (Bug#8867)
4106 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4107 TO_CHARPOS.
4108 (pos_visible_p): Support positions in bidi-reordered lines.
4109 Save and restore bidi cache.
4110
4111 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4112 (bidi_paragraph_info): Delete unused struct.
4113 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4114 (bidi_cache_start): New variable.
4115 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4116 to zero.
4117 (bidi_cache_fetch_state, bidi_cache_search)
4118 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4119 (bidi_cache_find, bidi_peek_at_next_level)
4120 (bidi_level_of_next_char, bidi_find_other_level_edge)
4121 (bidi_move_to_visually_next): Compare cache index with
4122 bidi_cache_start rather than with zero.
4123 (bidi_fetch_char): Accept new argument STRING; all callers
4124 changed. Support iteration over a string. Support strings with
4125 display properties. Support unibyte strings. Fix the type of
4126 `len' according to what STRING_CHAR_AND_LENGTH expects.
4127 (bidi_paragraph_init, bidi_resolve_explicit_1)
4128 (bidi_resolve_explicit, bidi_resolve_weak)
4129 (bidi_level_of_next_char, bidi_move_to_visually_next):
4130 Support iteration over a string.
4131 (bidi_set_sor_type, bidi_resolve_explicit_1)
4132 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4133 can now be zero (for strings); special values 0 and -1 were
4134 changed to -1 and -2, respectively.
4135 (bidi_char_at_pos): New function.
4136 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4137 Call it instead of FETCH_MULTIBYTE_CHAR.
4138 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4139 initialized to valid values.
4140 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4141 values.
4142 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4143 the test for valid cached positions. Fix the logic for looking up
4144 the sentinel state in the cache. GCPRO the Lisp string we are
4145 iterating.
4146 (bidi_push_it, bidi_pop_it): New functions.
4147 (bidi_initialize): Initialize the bidi cache start stack pointer.
4148 (bidi_cache_ensure_space): New function, refactored from part of
4149 bidi_cache_iterator_state. Don't assume the required size is just
4150 one BIDI_CACHE_CHUNK away.
4151 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4152 (bidi_count_bytes, bidi_char_at_pos): New functions.
4153 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4154 always valid if bidi_cache_idx is valid.
4155 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4156 is valid if it's going to be used.
4157 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4158 (bidi_cache_fetch_state, bidi_cache_search)
4159 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4160 (bidi_cache_iterator_state, bidi_cache_find)
4161 (bidi_find_other_level_edge, bidi_cache_start_stack):
4162 All variables related to cache indices are now EMACS_INT.
4163
4164 * dispextern.h (struct bidi_string_data): New structure.
4165 (struct bidi_it): New member `string'. Make flag members be 1-bit
4166 fields, and put them last in the struct.
4167 (compute_display_string_pos, compute_display_string_end):
4168 Update prototypes.
4169 (bidi_push_it, bidi_pop_it): Add prototypes.
4170 (struct iterator_stack_entry): New members bidi_p,
4171 paragraph_embedding, and from_disp_prop_p.
4172 (struct it): Member bidi_p is now a bit field 1 bit wide.
4173 (bidi_shelve_cache, bidi_unshelve_cache):
4174 Declare prototypes.
4175
4176 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4177 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4178 and vector-like objects.
4179
4180 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4181 cache around display iteration.
4182
4183 * window.c (Fwindow_end, window_scroll_pixel_based)
4184 (displayed_window_lines, Frecenter): Save and restore the bidi
4185 cache around display iteration.
4186
4187 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4188
4189 * editfns.c (Fdelete_region): Clarify the use of the named
4190 parameters (bug#6788).
4191
4192 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4193
4194 * indent.c (Fvertical_motion): Set and restore w->pointm when
4195 saving and restoring the window's buffer (Bug#9006).
4196
4197 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4198
4199 * editfns.c (Fstring_to_char): Clarify just what is returned
4200 (bug#6576). Text by Eli Zaretskii.
4201
4202 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4203
4204 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4205
4206 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4207
4208 * buffer.c (mmap_find): Fix a typo.
4209
4210 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4211
4212 Fix execution of x selection hooks.
4213 * xselect.c (Qx_lost_selection_functions)
4214 (Qx_sent_selection_functions): New vars.
4215 (syms_of_xselect): DEFSYM them.
4216 (x_handle_selection_request): Pass Qx_sent_selection_functions
4217 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4218 (x_handle_selection_clear,x_clear_frame_selections):
4219 Pass Qx_lost_selection_functions rather than
4220 Vx_lost_selection_functions to Frun_hook_with_args.
4221
4222 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4223
4224 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4225 The old code sometimes used this field without initializing it.
4226
4227 * alloc.c (gc_sweep): Don't read past end of array.
4228 In theory, the old code could also have corrupted Emacs internals,
4229 though it'd be very unlikely.
4230
4231 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4232
4233 * character.c (Fcharacterp): Don't advertise optional ignored
4234 argument. (Bug#4026)
4235
4236 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4237
4238 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4239 key" (bug#4257).
4240
4241 * window.c (Fset_window_start): Doc fix (bug#4199).
4242 (Fset_window_hscroll): Ditto.
4243
4244 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4245
4246 Fix minor new problems caught by GCC 4.6.1.
4247 * term.c (init_tty): Remove unused local.
4248 * xsettings.c (store_monospaced_changed): Define this function only
4249 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4250 not used otherwise.
4251
4252 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4253
4254 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4255
4256 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4257
4258 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4259 are the mini-buffer and the echo area (bug#3320).
4260
4261 * term.c (init_tty): Remove support for supdup, c10 and perq
4262 terminals, which are no longer supported (bug#1482).
4263
4264 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4265
4266 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4267
4268 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4269
4270 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4271 for non-popups (Bug#3642).
4272
4273 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4274
4275 * alloc.c (reset_malloc_hooks): Protoize.
4276 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4277 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4278 * cm.c (losecursor): Likewise.
4279 * data.c (fmod): Likewise.
4280 * dispnew.c (swap_glyphs_in_rows): Likewise.
4281 * emacs.c (memory_warning_signal): Likewise.
4282 * floatfns.c (float_error): Likewise.
4283 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4284 (otf_open, font_otf_capability, generate_otf_features)
4285 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4286 Likewise.
4287 * image.c (pbm_read_file): Likewise.
4288 * indent.c (string_display_width): Likewise.
4289 * intervals.c (check_for_interval, search_for_interval)
4290 (inc_interval_count, count_intervals, root_interval)
4291 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4292 * lread.c (defalias): Likewise.
4293 * ralloc.c (r_alloc_check): Likewise.
4294 * regex.c (set_image_of_range_1, set_image_of_range)
4295 (regex_grow_registers): Likewise.
4296 * sysdep.c (strerror): Likewise.
4297 * termcap.c (valid_filename_p, tprint, main): Likewise.
4298 * tparam.c (main): Likewise.
4299 * unexhp9k800.c (run_time_remap, save_data_space)
4300 (update_file_ptrs, read_header, write_header, calculate_checksum)
4301 (copy_file, copy_rest, display_header): Likewise.
4302 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4303 Likewise.
4304 * xdisp.c (check_it): Likewise.
4305 * xfaces.c (register_color, unregister_color, unregister_colors):
4306 Likewise.
4307 * xfns.c (print_fontset_result): Likewise.
4308 * xrdb.c (member, fatal, main): Likewise.
4309
4310 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4311
4312 Fix minor problems found by static checking (Bug#9031).
4313 * chartab.c (char_table_set_range, map_sub_char_table):
4314 Remove unused locals.
4315 (uniprop_table): Now static.
4316 * composite.c (_work_char): Remove unused static var.
4317
4318 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4319
4320 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4321
4322 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4323
4324 * gtkutil.c (qttip_cb): Remove code without function.
4325
4326 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4327
4328 * w32.c (pthread_sigmask): New stub.
4329
4330 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4331
4332 Use pthread_sigmask, not sigprocmask (Bug#9010).
4333 sigprocmask is portable only for single-threaded applications, and
4334 Emacs can be multi-threaded when it uses GTK.
4335 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4336 (LIBES): Use it.
4337 * callproc.c (Fcall_process):
4338 * process.c (create_process):
4339 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4340 Use pthread_sigmask, not sigprocmask.
4341
4342 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4343
4344 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4345 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4346 wrong (Bug#8591).
4347
4348 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4349
4350 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4351 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4352 (xg_hide_tooltip): Fix comment.
4353
4354 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4355 in registerServicesMenuSendTypes.
4356 (validRequestorForSendType): Don't check ns_return_types.
4357
4358 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4359 ns_return_type.
4360
4361 2011-07-08 Jason Rumney <jasonr@gnu.org>
4362
4363 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4364 SH_SHOW for hidden windows (Bug#5482).
4365
4366 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4367 frame struct members of non-existent frames (Bug#6284).
4368
4369 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4370
4371 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4372 variable firstTime not needed on OSX >= 10.6.
4373 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4374 >= 10.5. Use setKnobProportion, setDoubleValue.
4375
4376 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4377 (MAC_OS_X_VERSION_10_5): Define if not defined.
4378 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4379 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4380 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4381
4382 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4383 cString and lossyCString on OSX >= 10.4
4384
4385 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4386 sizeToFit on OSX >= 10.2.
4387
4388 * nsimage.m (allocInitFromFile): Don't use deprecated method
4389 bestRepresentationForDevice on OSX >= 10.6.
4390
4391 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4392 to avoid warning.
4393
4394 * emacs.c: Declare unexec_init_emacs_zone.
4395
4396 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4397
4398 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4399
4400 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4401 on svcsMenu (Bug#8842).
4402
4403 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4404 ns_return_types.
4405 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4406
4407 * nsterm.m (QUTF8_STRING): Declare.
4408 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4409 (validRequestorForSendType): Return type is (id).
4410 Change indexOfObjectIdenticalTo to indexOfObject.
4411 Check if we have local selection before returning self (Bug#8842).
4412 (writeSelectionToPasteboard): Put local selection into paste board
4413 if we have a local selection (Bug#8842).
4414 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4415
4416 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4417 (ns_get_local_selection): Declare.
4418
4419 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4420
4421 * keymap.c (describe_map_tree): Don't insert a double newline at
4422 the end of the buffer (bug#1169) and return whether we inserted
4423 something.
4424
4425 * callint.c (Fcall_interactively): Change "reading args" to
4426 "providing args" to try to clarify what it does (bug#1010).
4427
4428 2011-07-07 Kenichi Handa <handa@m17n.org>
4429
4430 * composite.c (composition_compute_stop_pos): Ignore a static
4431 composition starting before CHARPOS (Bug#8915).
4432
4433 * xdisp.c (handle_composition_prop): Likewise.
4434
4435 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4436
4437 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4438 (Bug#9015)
4439
4440 2011-07-07 Kenichi Handa <handa@m17n.org>
4441
4442 * character.h (unicode_category_t): New enum type.
4443
4444 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4445 (Qchar_code_property_table): New variable.
4446 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4447 (UNIPROP_COMPRESSED_FORM_P): New macros.
4448 (char_table_ascii): Uncompress the compressed values.
4449 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4450 Uncompress the compressed values.
4451 (sub_char_table_ref_and_range): Likewise.
4452 (char_table_ref_and_range): Uncompress the compressed values.
4453 (sub_char_table_set): New arg is_uniprop. Callers changed.
4454 Uncompress the compressed values.
4455 (sub_char_table_set_range): Args changed. Callers changed.
4456 (char_table_set_range): Adjuted for the above change.
4457 (map_sub_char_table): Delete args default_val and parent. Add arg
4458 top. Give decoded values to a Lisp function.
4459 (map_char_table): Adjust for the above change. Give decoded
4460 values to a Lisp function. Gcpro more variables.
4461 (uniprop_table_uncompress)
4462 (uniprop_decode_value_run_length): New functions.
4463 (uniprop_decoder, uniprop_decoder_count): New variables.
4464 (uniprop_get_decoder, uniprop_encode_value_character)
4465 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4466 New functions.
4467 (uniprop_encoder, uniprop_encoder_count): New variables.
4468 (uniprop_get_encoder, uniprop_table)
4469 (Funicode_property_table_internal, Fget_unicode_property_internal)
4470 (Fput_unicode_property_internal): New functions.
4471 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4472 Sunicode_property_table_internal, Sget_unicode_property_internal,
4473 and Sput_unicode_property_internal. Defvar_lisp
4474 char-code-property-alist.
4475
4476 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4477 Vunicode_category_table.
4478
4479 * font.c (font_range): Adjust for the change of
4480 Vunicode_category_table.
4481
4482 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4483
4484 * m/iris4d.h: Remove file, move contents ...
4485 * s/irix6-5.h: ... here.
4486
4487 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4488
4489 Remove unportable assumption about struct layout (Bug#8884).
4490 * alloc.c (mark_buffer):
4491 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4492 (clone_per_buffer_values): Don't assume that
4493 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4494 This isn't true in general, and it's particularly not true
4495 if Emacs is configured with --with-wide-int.
4496 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4497 New macros, used in the buffer.c change.
4498
4499 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4500
4501 * xsettings.c: Use both GConf and GSettings if both are available.
4502 (store_config_changed_event): Add comment.
4503 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4504 (store_tool_bar_style_changed): New functions.
4505 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4506 (struct xsettings): Move font inside HAVE_XFT.
4507 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4508 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4509 Move inside HAVE_XFT.
4510 (something_changed_gsettingsCB): Rename from something_changedCB.
4511 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4512 also.
4513 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4514 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4515 (something_changed_gconfCB): Rename from something_changedCB.
4516 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4517 (parse_settings): Move check for font inside HAVE_XFT.
4518 (read_settings, apply_xft_settings): Add comment.
4519 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4520 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4521 call store_font_name_changed.
4522 (xft_settings_event): Add comment.
4523 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4524 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4525 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4526 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4527 (xsettings_initialize): Call init_gsettings last.
4528 (xsettings_get_system_font, xsettings_get_system_normal_font):
4529 Add comment.
4530
4531 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4532
4533 Random fixes. E.g., (random) never returned negative values.
4534 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4535 subseconds part to the entropy, as that's a bit more random.
4536 Prefer signed to unsigned, since the signedness doesn't matter and
4537 in general we prefer signed. When given a limit, use a
4538 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4539 latter isn't right if USE_2_TAGS_FOR_INTS.
4540 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4541 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4542
4543 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4544
4545 * textprop.c (text_property_stickiness):
4546 Obey Vtext_property_default_nonsticky.
4547 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4548 * w32fns.c (syms_of_w32fns):
4549 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4550
4551 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4552
4553 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4554 This is more efficient than Ffile_directory_p and avoids a minor race.
4555
4556 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4557
4558 * buffer.c (Foverlay_put): Say what the return value is
4559 (bug#7835).
4560
4561 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4562 is a directory before asking whether to use the file name
4563 (bug#7564).
4564 (barf_or_query_if_file_exists): Make the "File is a directory"
4565 error be more correct.
4566
4567 * fns.c (Frequire): Remove the mention of the .gz files, since
4568 that's installation-specific, but keep the mention of
4569 `get-load-suffixes'.
4570
4571 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4572
4573 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4574 Report string overflow if the output is too long.
4575
4576 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4577
4578 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4579 (syms_of_gnutls): Remove duplicate DEFSYM for
4580 Qgnutls_bootprop_verify_hostname_error, an error for
4581 Qgnutls_bootprop_verify_error (which is no longer used).
4582
4583 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4584 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4585 Also (re)move comments that are misplaced or no longer relevant.
4586
4587 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4588
4589 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4590
4591 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4592
4593 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4594 and background color parameters if they have been changed.
4595
4596 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4597
4598 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4599
4600 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4601
4602 * xsettings.c (SYSTEM_FONT): Define only when used.
4603 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4604
4605 * keymap.c (access_keymap_1): Now static.
4606
4607 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4608
4609 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4610 leave any prefix arg for the up event (Bug#1586).
4611
4612 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4613
4614 * lread.c (syms_of_lread): Mention single symbols defined by
4615 `defvar' or `defconst' (bug#7154).
4616
4617 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4618 (Frequire): Mention get-load-suffixes.
4619
4620 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4621
4622 * window.h (window): Remove clone_number slot.
4623 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4624 Remove.
4625 (make_parent_window, make_window, saved_window)
4626 (Fset_window_configuration, save_window_save): Don't deal with
4627 clone numbers.
4628 * buffer.c (Qclone_number): Remove declaration.
4629 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4630
4631 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4632
4633 Add multiple inheritance to keymaps.
4634 * keymap.c (Fmake_composed_keymap): New function.
4635 (Fset_keymap_parent): Simplify.
4636 (fix_submap_inheritance): Remove.
4637 (access_keymap_1): New function extracted from access_keymap to handle
4638 embedded parents and handle lists of maps.
4639 (access_keymap): Use it.
4640 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4641 (Fcopy_keymap): Handle embedded parents.
4642 (Fcommand_remapping, define_as_prefix): Simplify.
4643 (Fkey_binding): Simplify.
4644 (syms_of_keymap): Move minibuffer-local-completion-map,
4645 minibuffer-local-filename-completion-map,
4646 minibuffer-local-must-match-map, and
4647 minibuffer-local-filename-must-match-map to Elisp.
4648 (syms_of_keymap): Defsubr make-composed-keymap.
4649 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4650 (parse_menu_item): Trivial simplification.
4651
4652 2011-07-01 Glenn Morris <rgm@gnu.org>
4653
4654 * Makefile.in (SETTINGS_LIBS): Fix typo.
4655
4656 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4657
4658 * coding.c (Fencode_coding_string): Record the last coding system
4659 used, as the function doc string says (bug#8738).
4660
4661 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4662
4663 * xsettings.c (store_monospaced_changed): Take new font as arg and
4664 check for change against current_mono_font.
4665 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4666 (emacs_settings_constructor, emacs_settings_get_property)
4667 (emacs_settings_set_property, emacs_settings_class_init)
4668 (emacs_settings_init, gsettings_obj): Remove.
4669 (something_changedCB): New function for HAVE_GSETTINGS.
4670 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4671 with value as argument.
4672 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4673 g_settings_new (Bug#8967). Do not create gsettings_obj.
4674 Remove calls to g_settings_bind. Connect something_changedCB to
4675 "changed".
4676
4677 * xgselect.c: Add defined (HAVE_GSETTINGS).
4678 (xgselect_initialize): Ditto.
4679
4680 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4681 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4682 xg_select.
4683
4684 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4685
4686 * eval.c (struct backtrace): Simplify and port the data structure.
4687 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4688 signed bit field, as this assumption is not portable and it makes
4689 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4690 "char debug_on_exit : 1" as this is not portable either; instead,
4691 use the portable "unsigned int debug_on_exit : 1". Remove unused
4692 member evalargs. Remove obsolete comments about cc bombing out.
4693
4694 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4695
4696 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4697 Let HAVE_GSETTINGS override HAVE_GCONF.
4698 (store_monospaced_changed): New function.
4699 (EMACS_SETTINGS): A new type derived from GObject to handle
4700 GSettings notifications.
4701 (emacs_settings_constructor, emacs_settings_get_property)
4702 (emacs_settings_set_property, emacs_settings_class_init):
4703 New functions.
4704 (gsettings_client, gsettings_obj): New variables.
4705 (GSETTINGS_SCHEMA): New define.
4706 (something_changedCB): Call store_monospaced_changed.
4707 (init_gsettings): New function.
4708 (xsettings_initialize): Call init_gsettings.
4709 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4710 to NULL.
4711
4712 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4713 GCONF_CFLAGS/LIBS.
4714
4715 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4716
4717 * window.c (resize_root_window, grow_mini_window)
4718 (shrink_mini_window): Rename Qresize_root_window to
4719 Qwindow_resize_root_window and Qresize_root_window_vertically to
4720 Qwindow_resize_root_window_vertically.
4721
4722 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4723
4724 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4725
4726 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4727
4728 * makefile.w32-in: Redesign dependencies so they reflect more
4729 clearly which files are directly included by each source file,
4730 and not through other includes.
4731
4732 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4733
4734 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4735 (sort_overlays, overlay_strings): When an overlay's clone number
4736 matches the window's clone number process the overlay even if
4737 the overlay's window property doesn't match the current window.
4738
4739 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4740 (Fwindow_hchild): Rename to Fwindow_left_child.
4741 (Fwindow_next): Rename to Fwindow_next_sibling.
4742 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4743 (resize_window_check): Rename to window_resize_check.
4744 (resize_window_apply): Rename to window_resize_apply.
4745 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4746 (Fdelete_other_windows_internal, resize_frame_windows)
4747 (Fsplit_window_internal, Fdelete_window_internal)
4748 (grow_mini_window, shrink_mini_window)
4749 (Fresize_mini_window_internal): Fix callers accordingly.
4750
4751 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4752
4753 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4754 (emacs_fixed_set_min_size): Remove.
4755 (emacs_fixed_new): Take frame as argument.
4756
4757 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4758 (_EmacsFixedPrivate): Remove minwidth/height.
4759 Add struct frame *f.
4760 (emacs_fixed_init): Initialize priv->f.
4761 (get_parent_class, emacs_fixed_set_min_size): Remove.
4762 (emacs_fixed_new): Set priv->f to argument.
4763 (emacs_fixed_get_preferred_width)
4764 (emacs_fixed_get_preferred_height): Use min_width/height from
4765 frames size_hint to set minimum and natural (Bug#8919).
4766 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4767 and use min_width/height from frames size_hint to set
4768 min_width/height (Bug#8919).
4769
4770 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4771 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4772 Fix indentation.
4773
4774 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4775
4776 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4777 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4778 called at ZV.
4779
4780 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4781
4782 * process.c (wait_reading_process_output): Bypass select if
4783 waiting for a cell while ignoring keyboard input, and input is
4784 pending. Suggested by Jan Djärv (Bug#8869).
4785
4786 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4787
4788 Use gnulib's dup2 module instead of rolling our own.
4789 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4790
4791 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4792
4793 * dispnew.c (scrolling_window): Before scrolling, turn off a
4794 mouse-highlight in the window being scrolled.
4795
4796 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4797
4798 Move DEFSYM to lisp.h and use everywhere.
4799
4800 * character.h (DEFSYM): Move declaration...
4801 * lisp.h (DEFSYM): ...here.
4802
4803 * gnutls.c:
4804 * minibuf.c:
4805 * w32menu.c:
4806 * w32proc.c:
4807 * w32select.c: Don't include character.h.
4808
4809 * alloc.c (syms_of_alloc):
4810 * buffer.c (syms_of_buffer):
4811 * bytecode.c (syms_of_bytecode):
4812 * callint.c (syms_of_callint):
4813 * casefiddle.c (syms_of_casefiddle):
4814 * casetab.c (init_casetab_once):
4815 * category.c (init_category_once, syms_of_category):
4816 * ccl.c (syms_of_ccl):
4817 * cmds.c (syms_of_cmds):
4818 * composite.c (syms_of_composite):
4819 * dbusbind.c (syms_of_dbusbind):
4820 * dired.c (syms_of_dired):
4821 * dispnew.c (syms_of_display):
4822 * doc.c (syms_of_doc):
4823 * editfns.c (syms_of_editfns):
4824 * emacs.c (syms_of_emacs):
4825 * eval.c (syms_of_eval):
4826 * fileio.c (syms_of_fileio):
4827 * fns.c (syms_of_fns):
4828 * frame.c (syms_of_frame):
4829 * fringe.c (syms_of_fringe):
4830 * insdel.c (syms_of_insdel):
4831 * keymap.c (syms_of_keymap):
4832 * lread.c (init_obarray, syms_of_lread):
4833 * macros.c (syms_of_macros):
4834 * msdos.c (syms_of_msdos):
4835 * print.c (syms_of_print):
4836 * process.c (syms_of_process):
4837 * search.c (syms_of_search):
4838 * sound.c (syms_of_sound):
4839 * syntax.c (init_syntax_once, syms_of_syntax):
4840 * terminal.c (syms_of_terminal):
4841 * textprop.c (syms_of_textprop):
4842 * undo.c (syms_of_undo):
4843 * w32.c (globals_of_w32):
4844 * window.c (syms_of_window):
4845 * xdisp.c (syms_of_xdisp):
4846 * xfaces.c (syms_of_xfaces):
4847 * xfns.c (syms_of_xfns):
4848 * xmenu.c (syms_of_xmenu):
4849 * xsettings.c (syms_of_xsettings):
4850 * xterm.c (syms_of_xterm): Use DEFSYM.
4851
4852 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4853
4854 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4855
4856 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4857
4858 Integer and buffer overflow fixes (Bug#8873).
4859
4860 * print.c (printchar, strout): Check for string overflow.
4861 (PRINTPREPARE, printchar, strout):
4862 Don't set size unless allocation succeeds.
4863
4864 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4865 for sizes. Check for string overflow more accurately.
4866 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4867
4868 * macros.c: Integer and buffer overflow fixes.
4869 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4870 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4871 Use ptrdiff_t, not int, for sizes.
4872 Don't increment bufsize until after realloc succeeds.
4873 Check for size-calculation overflow.
4874 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4875
4876 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4877
4878 * lread.c: Integer overflow fixes.
4879 (read_integer): Radix is now EMACS_INT, not int,
4880 to improve quality of diagnostics for out-of-range radices.
4881 Calculate buffer size correctly for out-of-range radices.
4882 (read1): Check for integer overflow in radices, and in
4883 read-circle numbers.
4884 (read_escape): Avoid int overflow.
4885 (Fload, openp, read_buffer_size, read1)
4886 (substitute_object_recurse, read_vector, read_list, map_obarray):
4887 Use ptrdiff_t, not int, for sizes.
4888 (read1): Use EMACS_INT, not int, for sizes.
4889 Check for size overflow.
4890
4891 * image.c (cache_image): Check for size arithmetic overflow.
4892
4893 * lread.c: Integer overflow issues.
4894 (saved_doc_string_size, saved_doc_string_length)
4895 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4896 Now ptrdiff_t, not int.
4897 (read1): Don't assume doc string length fits in int. Check for
4898 out-of-range doc string lengths.
4899 (read_list): Don't assume file position fits in int.
4900 (read_escape): Check for hex character overflow.
4901
4902 2011-06-22 Leo Liu <sdl.web@gmail.com>
4903
4904 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4905 Move to minibuffer.el.
4906
4907 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4908
4909 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4910 The following patches are for when GLYPH_DEBUG && !XASSERT.
4911 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4912 * dispnew.c (flush_stdout):
4913 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4914 Mark as externally visible.
4915 * dispnew.c (check_window_matrix_pointers): Now static.
4916 * dispnew.c (window_to_frame_vpos):
4917 * xfns.c (unwind_create_frame):
4918 * xterm.c (x_check_font): Remove unused local.
4919 * scroll.c (CHECK_BOUNDS):
4920 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4921 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4922 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4923 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4924 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4925 Now static.
4926 (debug_method_add): Use va_list and vsprintf rather than relying
4927 on undefined behavior with wrong number of arguments.
4928 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4929 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4930 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4931 since we're not interested in debugging glyphs with old libraries.
4932 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4933 GCC 4.6.0's static checking.
4934
4935 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4936
4937 Integer overflow and signedness fixes (Bug#8873).
4938 A few related buffer overrun fixes, too.
4939
4940 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4941
4942 * dispextern.h (struct face.stipple):
4943 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4944 (x_bitmap_mask, x_allocate_bitmap_record)
4945 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4946 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4947 (x_create_bitmap_from_xpm_data):
4948 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4949 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4950 (.bitmaps_last):
4951 * xfaces.c (load_pixmap):
4952 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4953 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4954 (.bitmaps_last, struct x_output.icon_bitmap):
4955 Use ptrdiff_t, not int, for bitmap indexes.
4956 (x_allocate_bitmap_record): Check for size overflow.
4957 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4958
4959 Use ptrdiff_t, not int, for overlay counts.
4960 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4961 * editfns.c (overlays_around, get_pos_property):
4962 * textprop.c (get_char_property_and_overlay):
4963 * xdisp.c (next_overlay_change, note_mouse_highlight):
4964 * xfaces.c (face_at_buffer_position):
4965 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4966 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4967 (Fnext_overlay_change, Fprevious_overlay_change)
4968 (mouse_face_overlay_overlaps, Foverlays_in):
4969 Use ptrdiff_t, not int, for sizes.
4970 (overlays_at, overlays_in): Check for size-calculation overflow.
4971
4972 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4973
4974 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4975 (x_session_initialize): Do not assume string length fits in int.
4976
4977 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4978 This is unlikely, but can occur if DPI is outlandish.
4979
4980 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4981 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4982
4983 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4984 * xrdb.c (magic_file_p, search_magic_path):
4985 Omit last arg SUFFIX; it was always 0. All callers changed.
4986 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4987
4988 * xfont.c (xfont_match): Avoid need for strlen.
4989
4990 * xfns.c: Don't assume strlen fits in int.
4991 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4992
4993 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4994 not unsigned long, as we prefer signed integers. All callers changed.
4995 Detect integer overflow in repeat count.
4996 (message_dolog): Don't assume print length fits in 39 bytes.
4997 (display_mode_element): Don't assume strlen fits in int.
4998
4999 * termcap.c: Don't assume sizes fit in int and never overflow.
5000 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5001 (gobble_line): Check for size-calculation overflow.
5002
5003 * minibuf.c (Fread_buffer):
5004 * lread.c (intern, intern_c_string):
5005 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5006 Don't assume string length fits in int.
5007
5008 * keyboard.c (parse_tool_bar_item):
5009 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5010
5011 * font.c: Don't assume string length fits in int.
5012 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5013 Use ptrdiff_t, not int.
5014 (font_intern_prop): Don't assume string length fits in int.
5015 Don't assume integer property fits in fixnum.
5016 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5017
5018 * filelock.c: Fix some buffer overrun and integer overflow issues.
5019 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5020 Reformulate so as not to need the command string.
5021 Invoke gzip -cd rather than gunzip, as it's more portable.
5022 (lock_info_type, lock_file_1, lock_file):
5023 Don't assume pid_t and time_t fit in unsigned long.
5024 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5025 (current_lock_owner): Prefer signed type for sizes.
5026 Use memcpy, not strncpy, where memcpy is what is really wanted.
5027 Don't assume (via atoi) that time_t and pid_t fit in int.
5028 Check for time_t and/or pid_t out of range, e.g., via a network share.
5029 Don't alloca where an auto var works fine.
5030
5031 * fileio.c: Fix some integer overflow issues.
5032 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5033 Don't assume string length fits in int.
5034 (directory_file_name): Don't assume string length fits in long.
5035 (make_temp_name): Don't assume pid fits in int, or that its print
5036 length is less than 20.
5037
5038 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5039
5040 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5041
5042 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5043
5044 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5045 We prefer signed integers, even for size calculations.
5046
5047 * emacs.c: Don't assume string length fits in 'int'.
5048 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5049 (main): Don't invoke strlen when not needed.
5050
5051 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5052 (XD_DEBUG_MESSAGE): Don't waste a byte.
5053
5054 * callproc.c (getenv_internal_1, getenv_internal)
5055 (Fgetenv_internal):
5056 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5057
5058 * lread.c (invalid_syntax): Omit length argument.
5059 All uses changed. This doesn't fix a bug, but it simplifies the
5060 code away from its former Hollerith-constant appearance, and it's
5061 one less 'int' to worry about when looking at integer-overflow issues.
5062 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5063
5064 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5065 This didn't break anything, but it didn't help either.
5066 It's confusing to put a bogus integer in a place where the actual
5067 value does not matter.
5068 (LIST_END_P): Remove unused macro and its bogus comment.
5069 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5070
5071 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5072 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5073 implementation.
5074 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5075 We prefer signed types, and the value cannot exceed the EMACS_INT
5076 range anyway (because otherwise the length would not be representable).
5077 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5078 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5079 This avoids a GCC warning when WIDE_EMACS_INT.
5080
5081 * indent.c (sane_tab_width): New function.
5082 (current_column, scan_for_column, Findent_to, position_indentation)
5083 (compute_motion): Use it. This is just for clarity.
5084 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5085
5086 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5087
5088 * lisp.h (lint_assume): New macro.
5089 * composite.c (composition_gstring_put_cache):
5090 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5091
5092 * editfns.c, insdel.c:
5093 Omit unnecessary forward decls, to simplify future changes.
5094
5095 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5096
5097 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5098
5099 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5100 Use much-faster test for byte-length change.
5101 Don't assume string byte-length fits in 'int'.
5102 Check that character arg fits in 'int'.
5103 (mapcar1): Declare byte as byte, for clarity.
5104
5105 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5106
5107 * fns.c (concat): Catch string overflow earlier.
5108 Do not rely on integer wraparound.
5109
5110 * dispextern.h (struct it.overlay_strings_charpos)
5111 (struct it.selective): Now EMACS_INT, not int.
5112 * xdisp.c (forward_to_next_line_start)
5113 (back_to_previous_visible_line_start)
5114 (reseat_at_next_visible_line_start, next_element_from_buffer):
5115 Don't arbitrarily truncate the value of 'selective' to int.
5116
5117 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5118
5119 * composite.c: Don't truncate sizes to 'int'.
5120 (composition_gstring_p, composition_reseat_it)
5121 (composition_adjust_point): Use EMACS_INT, not int.
5122 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5123 not EMACS_UINT, for indexes.
5124
5125 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5126
5127 * buffer.c: Include <verify.h>.
5128 (struct sortvec.priority, struct sortstr.priority):
5129 Now EMACS_INT, not int.
5130 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5131 (struct sortstr.size, record_overlay_string)
5132 (struct sortstrlist.size, struct sortlist.used):
5133 Don't truncate size to int.
5134 (record_overlay_string): Check for size-calculation overflow.
5135 (init_buffer_once): Check at compile-time, not run-time.
5136
5137 2011-06-22 Jim Meyering <meyering@redhat.com>
5138
5139 Don't leak an XBM-image-sized buffer
5140 * image.c (xbm_load): Free the image buffer after using it.
5141
5142 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5143
5144 Port to Sun C.
5145 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5146 that Sun C diagnosed.
5147 * fns.c (secure_hash): Fix pointer signedness issue.
5148 * intervals.c (static_offset_intervals): New function.
5149 (offset_intervals): Use it.
5150
5151 2011-06-21 Leo Liu <sdl.web@gmail.com>
5152
5153 * deps.mk (fns.o):
5154 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5155 sha512.h.
5156
5157 * fns.c (secure_hash): Rename from crypto_hash_function and change
5158 the first arg to accept symbols.
5159 (Fsecure_hash): New primitive.
5160 (syms_of_fns): New symbols.
5161
5162 2011-06-20 Deniz Dogan <deniz@dogan.se>
5163
5164 * process.c (Fset_process_buffer): Clarify return value in
5165 docstring.
5166
5167 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5168
5169 * dispnew.c (add_window_display_history): Use BVAR.
5170
5171 * xdisp.c (debug_method_add): Use BVAR.
5172 (check_window_end, dump_glyph_matrix, dump_glyph)
5173 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5174
5175 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5176 Likewise.
5177
5178 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5179 check till after the cache is created in init_frame_faces.
5180
5181 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5182
5183 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5184
5185 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5186
5187 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5188 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5189 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5190
5191 Improve buffer-overflow checking (Bug#8873).
5192 * fileio.c (Finsert_file_contents):
5193 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5194 Remove the old (too-loose) buffer overflow checks.
5195 They weren't needed, since make_gap checks for buffer overflow.
5196 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5197 The old code merely checked for Emacs fixnum overflow, and relied
5198 on undefined (wraparound) behavior. The new code avoids undefined
5199 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5200
5201 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5202 Tune. Don't use wider integers than needed. Don't use alloca.
5203 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5204
5205 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5206
5207 * insdel.c, lisp.h (buffer_overflow): New function.
5208 (insert_from_buffer_1, replace_range, replace_range_2):
5209 * insdel.c (make_gap_larger):
5210 * editfns.c (Finsert_char):
5211 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5212
5213 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5214
5215 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5216
5217 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5218
5219 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5220 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5221
5222 * fileio.c: Don't assume EMACS_INT fits in off_t.
5223 (emacs_lseek): New static function.
5224 (Finsert_file_contents, Fwrite_region): Use it.
5225 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5226
5227 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5228
5229 * fns.c: Don't overflow int when computing a list length.
5230 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5231 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5232 truncation on 64-bit hosts. Check for QUIT every
5233 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5234 faster and is responsive enough.
5235 (Flength): Report an error instead of overflowing an integer.
5236 (Fsafe_length): Return a float if the value is not representable
5237 as a fixnum. This shouldn't happen except in contrived situations.
5238 (Fnthcdr, Fsort): Don't assume list length fits in int.
5239 (Fcopy_sequence): Don't assume vector length fits in int.
5240
5241 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5242 (header_size, word_size): New constants.
5243 (allocate_vectorlike): Don't check size overflow here.
5244 (allocate_vector): Check it here instead, since this is the only
5245 caller of allocate_vectorlike that could cause overflow.
5246 Check that the new vector's length is representable as a fixnum.
5247
5248 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5249 The previous code was bogus. For example, next_almost_prime (32)
5250 returned 39, which is undesirable as it is a multiple of 3; and
5251 next_almost_prime (24) returned 25, which is a multiple of 5 so
5252 why was the code bothering to check for multiples of 7?
5253
5254 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5255
5256 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5257
5258 Variadic C functions now count arguments with ptrdiff_t.
5259 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5260 Back then I didn't know that the Emacs coding style prefers signed int.
5261 Also, in the meantime I found a few more instances where arguments
5262 were being counted with int, which may truncate counts on 64-bit
5263 machines, or EMACS_INT, which may be unnecessarily wide.
5264 * lisp.h (struct Lisp_Subr.function.aMANY)
5265 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5266 Arg counts are now ptrdiff_t, not size_t.
5267 All variadic functions and their callers changed accordingly.
5268 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5269 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5270 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5271 * callint.c (Fcall_interactively): Check arg count for overflow,
5272 to avoid potential buffer overrun. Use signed char, not 'int',
5273 for 'varies' array, so that we needn't bother to check its size
5274 calculation for overflow.
5275 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5276 * eval.c (apply_lambda):
5277 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5278 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5279 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5280
5281 * callint.c (Fcall_interactively): Don't use index var as event count.
5282
5283 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5284 * mem-limits.h (SIZE): Remove; no longer used.
5285
5286 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5287
5288 Remove unnecessary casts.
5289 * xterm.c (x_term_init):
5290 * xfns.c (x_set_border_pixel):
5291 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5292 These aren't needed now that we assume ANSI C.
5293
5294 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5295 It's more likely to cause problems (due to unsigned overflow)
5296 than to cure them.
5297
5298 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5299
5300 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5301
5302 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5303
5304 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5305
5306 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5307
5308 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5309
5310 GLYPH_CODE_FACE returns EMACS_INT, not int.
5311 * dispextern.h (merge_faces):
5312 * xfaces.c (merge_faces):
5313 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5314 Don't assume EMACS_INT fits in int.
5315
5316 * character.h (CHAR_VALID_P): Remove unused parameter.
5317 * fontset.c, lisp.h, xdisp.c: All uses changed.
5318
5319 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5320
5321 * fns.c (concat): Minor tuning based on overflow analysis.
5322 This doesn't fix any bugs. Use int to hold character, instead
5323 of constantly refetching from Emacs object. Use XFASTINT, not
5324 XINT, for value known to be a character. Don't bother comparing
5325 a single byte to 0400, as it's always less.
5326
5327 * floatfns.c (Fexpt):
5328 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5329
5330 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5331 for characters.
5332
5333 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5334
5335 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5336 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5337 incorrectly succeed when S was a string, because 4294967386 was
5338 truncated before it was used.
5339
5340 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5341 Otherwise, an out-of-range integer could cause undefined behavior
5342 on a 64-bit host.
5343
5344 * composite.c: Use int, not EMACS_INT, for characters.
5345 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5346 EMACS_INT, for values that are known to be in character range.
5347 This doesn't fix any bugs but is the usual style inside Emacs and
5348 may generate better code on 32-bit machines.
5349
5350 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5351 This is for reasons similar to the recent CHAR_STRING fix.
5352 * charset.c (Fencode_char): Check that character arg is actually
5353 a character. Pass an int to ENCODE_CHAR.
5354 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5355 wider than 'int', as a compile-time check to prevent future regressions
5356 in this area.
5357
5358 * character.c (char_string): Remove unnecessary casts.
5359
5360 Make sure a 64-bit char is never passed to CHAR_STRING.
5361 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5362 by silently ignoring the top 32 bits, allowing some values
5363 that were far too large to be valid characters.
5364 * character.h: Include <verify.h>.
5365 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5366 arguments are no wider than unsigned, as a compile-time check
5367 to prevent future regressions in this area.
5368 * data.c (Faset):
5369 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5370 (Fsubst_char_in_region):
5371 * fns.c (concat):
5372 * xdisp.c (decode_mode_spec_coding):
5373 Adjust to CHAR_STRING's new requirement.
5374 * editfns.c (Finsert_char, Fsubst_char_in_region):
5375 * fns.c (concat): Check that character args are actually
5376 characters. Without this test, these functions did the wrong
5377 thing with wildly out-of-range values on 64-bit hosts.
5378
5379 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5380 These casts should not be needed on 32-bit hosts, either.
5381 * keyboard.c (read_char):
5382 * lread.c (Fload): Remove casts to unsigned.
5383
5384 * lisp.h (UNSIGNED_CMP): New macro.
5385 This fixes comparison bugs on 64-bit hosts.
5386 (ASCII_CHAR_P): Use it.
5387 * casefiddle.c (casify_object):
5388 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5389 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5390 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5391 * dispextern.h (FACE_FROM_ID):
5392 * keyboard.c (read_char): Use UNSIGNED_CMP.
5393
5394 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5395 not to EMACS_INT, to avoid GCC warning.
5396
5397 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5398
5399 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5400 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5401 isn't needed on 32-bit machines.
5402
5403 * buffer.c (Fgenerate_new_buffer_name):
5404 Use EMACS_INT for count, not int.
5405 (advance_to_char_boundary): Return EMACS_INT, not int.
5406
5407 * data.c (Qcompiled_function): Now static.
5408
5409 * window.c (window_body_lines): Now static.
5410
5411 * image.c (gif_load): Rename local to avoid shadowing.
5412
5413 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5414 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5415 * alloc.c (make_save_value): Integer argument is now of type
5416 ptrdiff_t, not int.
5417 (mark_object): Use ptrdiff_t, not int.
5418 * lisp.h (pD): New macro.
5419 * print.c (print_object): Use it.
5420
5421 * alloc.c: Use EMACS_INT, not int, to count objects.
5422 (total_conses, total_markers, total_symbols, total_vector_size)
5423 (total_free_conses, total_free_markers, total_free_symbols)
5424 (total_free_floats, total_floats, total_free_intervals)
5425 (total_intervals, total_strings, total_free_strings):
5426 Now EMACS_INT, not int. All uses changed.
5427 (Fgarbage_collect): Compute overall total using a double, so that
5428 integer overflow is less likely to be a problem. Check for overflow
5429 when converting back to an integer.
5430 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5431 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5432 These were 'int' variables that could overflow on 64-bit hosts;
5433 they were never used, so remove them instead of repairing them.
5434 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5435 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5436 Previously, this ceilinged at INT_MAX, but that doesn't work on
5437 64-bit machines.
5438 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5439
5440 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5441 (allocate_vectorlike): Check for ptrdiff_t overflow.
5442 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5443 when a (possibly-narrower) signed value would do just as well.
5444 We prefer using signed arithmetic, to avoid comparison confusion.
5445
5446 * alloc.c: Catch some string size overflows that we were missing.
5447 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5448 for convenience in STRING_BYTES_MAX.
5449 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5450 The definition here is exact; the one in lisp.h was approximate.
5451 (allocate_string_data): Check for string overflow. This catches
5452 some instances we weren't catching before. Also, it catches
5453 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5454 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5455 and ptrdiff_t and EMACS_INT are both 64 bits.
5456
5457 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5458 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5459 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5460
5461 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5462
5463 * alloc.c (Fmake_string): Check for out-of-range init.
5464
5465 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5466
5467 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5468
5469 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5470
5471 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5472 xg_get_default_scrollbar_width.
5473
5474 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5475 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5476 (style_changed_cb): Call update_theme_scrollbar_width and call
5477 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5478 all frames (Bug#8505).
5479 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5480 Call gtk_window_set_resizable if HAVE_GTK3.
5481 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5482 and height if HAVE_GTK3 (Bug#8505).
5483 (scroll_bar_width_for_theme): New variable.
5484 (update_theme_scrollbar_width): New function.
5485 (xg_get_default_scrollbar_width): Move code to
5486 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5487 (xg_initialize): Call update_theme_scrollbar_width.
5488
5489 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5490
5491 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5492
5493 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5494
5495 * frame.c (make_frame): Call other_buffer_safely instead of
5496 other_buffer.
5497
5498 * window.c (temp_output_buffer_show): Call display_buffer with
5499 second argument Vtemp_buffer_show_specifiers and reset latter
5500 immediately after the call.
5501 (Vtemp_buffer_show_specifiers): New variable.
5502 (auto_window_vscroll_p, next_screen_context_lines)
5503 (Vscroll_preserve_screen_position): Remove leading asterisks from
5504 doc-strings.
5505
5506 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5507
5508 Fix minor problems found by GCC 4.6.0 static checking.
5509 * buffer.c (Qclone_number): Remove for now, as it's unused.
5510 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5511 (record_buffer): Remove unused local.
5512 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5513 (set_frame_buffer_list): Remove; unused.
5514 * frame.h (other_visible_frames): Remove decl.
5515 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5516 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5517 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5518 if HAVE_GPM.
5519 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5520 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5521 Define only if HAVE_GPM.
5522 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5523 (update_hints_inhibit): Remove; never set. All uses removed.
5524 * widgetprv.h (emacsFrameClassRec): Remove decl.
5525 * window.c (delete_deletable_window): Now returns void, since it
5526 wasn't returning anything.
5527 (compare_window_configurations): Remove unused locals.
5528 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5529 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5530 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5531 the same widths as pointers. This follows up on the 2011-05-06 patch.
5532 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5533 * xterm.h: Likewise.
5534 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5535
5536 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5537
5538 * makefile.w32-in: Update dependencies.
5539 (LISP_H): Add lib/intprops.h.
5540
5541 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5542
5543 * image.c (gif_load): Add animation frame delay to the metadata.
5544 (syms_of_image): Use DEFSYM. New symbol `delay'.
5545
5546 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5547
5548 * window.c (delete_deletable_window): Re-add.
5549 (Fset_window_configuration): Rewrite to handle dead buffers and
5550 consequently deletable windows.
5551 (window_tree, Fwindow_tree): Remove. Supply functionality in
5552 window.el.
5553 (compare_window_configurations): Simplify code.
5554
5555 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5556
5557 * image.c (imagemagick_load_image): Fix type mismatch.
5558 (Fimagemagick_types): Likewise.
5559
5560 * window.h (replace_buffer_in_windows): Declare.
5561
5562 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5563
5564 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5565 Qclone_number. Remove external declaration of Qdelete_window.
5566 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5567 code.
5568 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5569 Run Qbuffer_list_update_hook if allowed.
5570 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5571 buffer list implementation.
5572 (other_buffer_safely): New function.
5573 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5574 calls to replace_buffer_in_windows and
5575 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5576 if allowed.
5577 (record_buffer): Inhibit quitting and rewrite using quittable
5578 functions. Run Qbuffer_list_update_hook if allowed.
5579 (Frecord_buffer, Funrecord_buffer): New functions.
5580 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5581 Move switch-to-buffer to window.el.
5582 (bury-buffer): Move to window.el.
5583 (Vbuffer_list_update_hook): New variable.
5584
5585 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5586 section.
5587
5588 * window.h (resize_frame_windows): Move up in code.
5589 (Fwindow_frame): Remove EXFUN.
5590 (replace_buffer_in_all_windows): Remove prototype.
5591 (replace_buffer_in_windows_safely): Add prototype.
5592
5593 * window.c: Declare Qdelete_window static again. Move down
5594 declaration of select_count.
5595 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5596 (Fother_window): Move to window.el.
5597 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5598 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5599 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5600 window.el.
5601 (replace_buffer_in_windows): Implement by calling
5602 Qreplace_buffer_in_windows.
5603 (replace_buffer_in_all_windows): Remove with some functionality
5604 moved into replace_buffer_in_windows_safely.
5605 (replace_buffer_in_windows_safely): New function.
5606 (select_window_norecord, select_frame_norecord): Move in front
5607 of run_window_configuration_change_hook. Remove now obsolete
5608 declarations.
5609 (Fset_window_buffer): Rewrite doc-string.
5610 Call Qrecord_window_buffer.
5611 (keys_of_window): Move binding for other-window to window.el.
5612
5613 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5614
5615 * dispextern.h (struct image): Replace data member, whose int_val
5616 and ptr_val fields were not used by anything, with a single
5617 lisp_val object.
5618
5619 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5620 (gif_clear_image, gif_load, imagemagick_load_image)
5621 (gs_clear_image, gs_load): Callers changed.
5622
5623 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5624
5625 * buffer.h: Include <time.h>, for time_t.
5626 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5627
5628 Fix minor problems found by static checking.
5629
5630 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5631
5632 Make identifiers static if they are not used in other modules.
5633 * data.c (Qcompiled_function, Qframe, Qvector):
5634 * image.c (QimageMagick, Qsvg):
5635 * minibuf.c (Qmetadata):
5636 * window.c (resize_window_check, resize_root_window): Now static.
5637 * window.h (resize_window_check, resize_root_window): Remove decls.
5638
5639 * window.c (window_deletion_count, delete_deletable_window):
5640 Remove; unused.
5641 (window_body_lines): Now static.
5642 (Fdelete_other_windows_internal): Mark vars as initialized.
5643 Make sure 'resize_failed' is initialized.
5644 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5645 (resize_window_apply): Remove unused local.
5646 * window.h (delete_deletable_window): Remove decl.
5647
5648 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5649 (imagemagick_load_image): Fix pointer signedness problem by changing
5650 last arg from unsigned char * to char *. All uses changed.
5651 Also, fix a local for similar reasons.
5652 Remove unused locals. Remove locals to avoid shadowing.
5653 (fn_rsvg_handle_free): Remove; unused.
5654 (svg_load, svg_load_image): Fix pointer signedness problem.
5655 (imagemagick_load_image): Don't use garbage pointer image_wand.
5656
5657 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5658
5659 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5660
5661 * image.c (gif_load): Fix omitted cast error introduced by
5662 2011-06-06 change.
5663
5664 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5665
5666 * window.h (resize_proportionally, orig_total_lines)
5667 (orig_top_line): Remove from window structure.
5668 (set_window_height, set_window_width, change_window_heights)
5669 (Fdelete_window): Remove prototypes.
5670 (resize_frame_windows): Remove duplicate declaration.
5671
5672 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5673
5674 * window.h (resize_frame_windows, resize_window_check)
5675 (delete_deletable_window, resize_root_window)
5676 (resize_frame_windows): Declare prototypes.
5677
5678 * window.c (resize_window_apply): Make definition be "static" to
5679 match the prototype.
5680
5681 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5682
5683 * window.c: Remove declarations of Qwindow_size_fixed,
5684 window_min_size_1, window_min_size_2, window_min_size,
5685 size_window, window_fixed_size_p, enlarge_window, delete_window.
5686 Remove static from declaration of Qdelete_window, it's
5687 temporarily needed by Fbury_buffer.
5688 (replace_window): Don't assign orig_top_line and
5689 orig_total_lines.
5690 (Fdelete_window, delete_window): Remove. Window deletion is
5691 handled by window.el.
5692 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5693 Replace Fdelete_window calls with calls to Qdelete_window.
5694 (Fdelete_other_windows): Remove. Deleting other windows is
5695 handled by window.el.
5696 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5697 handled in window.el.
5698 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5699 Window minimum sizes are handled in window.el.
5700 (shrink_windows, size_window, set_window_height)
5701 (set_window_width, change_window_heights, window_height)
5702 (window_width, CURBEG, CURSIZE, enlarge_window)
5703 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5704 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5705 handled in window.el.
5706 (make_dummy_parent): Rename to make_parent_window and give it a
5707 second argument horflag.
5708 (make_window): Don't set resize_proportionally any more.
5709 (Fsplit_window): Remove. Windows are split in window.el.
5710 (save_restore_action, save_restore_orig_size)
5711 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5712 Resize mini windows in window.el.
5713 (grow_mini_window, shrink_mini_window): Implement by calling
5714 Qresize_root_window_vertically, resize_window_check and
5715 resize_window_apply.
5716 (saved_window, Fset_window_configuration, save_window_save):
5717 Do not handle orig_top_line, orig_total_lines, and
5718 resize_proportionally.
5719 (window_min_height, window_min_width): Move to window.el.
5720 (keys_of_window): Move bindings for delete-other-windows,
5721 split-window, delete-window and enlarge-window to window.el.
5722
5723 * buffer.c: Temporarily extern Qdelete_window.
5724 (Fbury_buffer): Temporarily call Qdelete_window instead of
5725 Fdelete_window (Fbury_buffer will move to window.el soon).
5726
5727 * frame.c (set_menu_bar_lines_1): Remove code handling
5728 orig_top_line and orig_total_lines.
5729
5730 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5731 set_window_height but set heights directly.
5732 (change_frame_size_1): Use resize_frame_windows.
5733
5734 * xdisp.c (init_xdisp): Don't use set_window_height but set
5735 heights directly.
5736
5737 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5738 Use resize_frame_windows instead of change_window_heights and run
5739 run_window_configuration_change_hook.
5740
5741 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5742 instead of change_window_heights and run
5743 run_window_configuration_change_hook.
5744
5745 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5746
5747 * window.c (replace_window): Rename second argument REPLACEMENT to
5748 NEW. New third argument SETFLAG. Rewrite.
5749 (delete_window, make_dummy_parent): Call replace_window with
5750 third argument 1.
5751 (window_list_1): Move down in code.
5752 (run_window_configuration_change_hook): Move set_buffer part
5753 before select_frame_norecord part in order to unwind correctly.
5754 Rename count1 to count.
5755 (recombine_windows, delete_deletable_window, resize_root_window)
5756 (Fdelete_other_windows_internal)
5757 (Frun_window_configuration_change_hook, make_parent_window)
5758 (resize_window_check, resize_window_apply, Fresize_window_apply)
5759 (resize_frame_windows, Fsplit_window_internal)
5760 (Fdelete_window_internal, Fresize_mini_window_internal):
5761 New functions.
5762 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5763
5764 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5765
5766 * window.h (window): Add some new members to window structure -
5767 normal_lines, normal_cols, new_total, new_normal, clone_number,
5768 splits, nest, prev_buffers, next_buffers.
5769 (WINDOW_TOTAL_SIZE): Move here from window.c.
5770 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5771
5772 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5773 Remove.
5774 (make_dummy_parent): Set new members of windows structure.
5775 (make_window): Move down in code. Handle new members of window
5776 structure.
5777 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5778 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5779 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5780 (Fset_window_prev_buffers, Fwindow_next_buffers)
5781 (Fset_window_next_buffers, Fset_window_clone_number):
5782 New functions.
5783 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5784 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5785 Doc-string fixes.
5786 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5787 Argument WINDOW can be now internal window too.
5788 (Fwindow_use_time): Move up in code.
5789 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5790 Rewrite doc-string.
5791 (Fset_window_configuration, saved_window)
5792 (Fcurrent_window_configuration, save_window_save): Handle new
5793 members of window structure.
5794 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5795 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5796 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5797 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5798 Qget_mru_window, Qresize_root_window,
5799 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5800 Qauto_buffer_name; staticpro them.
5801
5802 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5803
5804 * window.c (Fwindow_total_size, Fwindow_left_column)
5805 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5806 (Fwindow_list_1): New functions.
5807 (window_box_text_cols): Replace with window_body_cols.
5808 (Fwindow_width, Fscroll_left, Fscroll_right):
5809 Use window_body_cols instead of window_box_text_cols.
5810 (delete_window, Fset_window_configuration):
5811 Call delete_all_subwindows with window as argument.
5812 (delete_all_subwindows): Take a window as argument and not a
5813 structure. Rewrite.
5814 (window_loop): Remove handling of GET_LRU_WINDOW and
5815 GET_LARGEST_WINDOW.
5816 (Fget_lru_window, Fget_largest_window): Move to window.el.
5817
5818 * window.h: Extern window_body_cols instead of
5819 window_box_text_cols. delete_all_subwindows now takes a
5820 Lisp_Object as argument.
5821
5822 * indent.c (compute_motion, Fcompute_motion):
5823 Use window_body_cols instead of window_box_text_cols.
5824
5825 * frame.c (delete_frame): Call delete_all_subwindows with root
5826 window as argument.
5827
5828 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5829
5830 * fns.c (Fputhash): Document return value.
5831
5832 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5833
5834 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5835
5836 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5837
5838 Cons<->int and similar integer overflow fixes (Bug#8794).
5839
5840 Check for overflow when converting integer to cons and back.
5841 * charset.c (Fdefine_charset_internal, Fdecode_char):
5842 Use cons_to_unsigned to catch overflow.
5843 (Fencode_char): Use INTEGER_TO_CONS.
5844 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5845 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5846 * data.c (long_to_cons, cons_to_long): Remove.
5847 (cons_to_unsigned, cons_to_signed): New functions.
5848 These signal an error for invalid or out-of-range values.
5849 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5850 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5851 * font.c (Ffont_variation_glyphs):
5852 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5853 * lisp.h: Include <intprops.h>.
5854 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5855 (cons_to_signed, cons_to_unsigned): New decls.
5856 (long_to_cons, cons_to_long): Remove decls.
5857 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5858 (Fprimitive_undo): Use CONS_TO_INTEGER.
5859 * xfns.c (Fx_window_property): Likewise.
5860 * xselect.c: Include <limits.h>.
5861 (x_own_selection, selection_data_to_lisp_data):
5862 Use INTEGER_TO_CONS.
5863 (x_handle_selection_request, x_handle_selection_clear)
5864 (x_get_foreign_selection, Fx_disown_selection_internal)
5865 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5866 (lisp_data_to_selection_data): Use cons_to_unsigned.
5867 (x_fill_property_data): Use cons_to_signed.
5868 Report values out of range.
5869
5870 Check for buffer and string overflow more precisely.
5871 * buffer.h (BUF_BYTES_MAX): New macro.
5872 * lisp.h (STRING_BYTES_MAX): New macro.
5873 * alloc.c (Fmake_string):
5874 * character.c (string_escape_byte8):
5875 * coding.c (coding_alloc_by_realloc):
5876 * doprnt.c (doprnt):
5877 * editfns.c (Fformat):
5878 * eval.c (verror):
5879 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5880 since they may not be the same number.
5881 * editfns.c (Finsert_char):
5882 * fileio.c (Finsert_file_contents):
5883 Likewise for BUF_BYTES_MAX.
5884
5885 * image.c: Use ptrdiff_t, not int, for sizes.
5886 (slurp_file): Switch from int to ptrdiff_t.
5887 All uses changed.
5888 (slurp_file): Check that file size fits in both size_t (for
5889 malloc) and ptrdiff_t (for sanity and safety).
5890
5891 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5892 if b->modtime has its maximal value.
5893
5894 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5895
5896 Don't assume time_t can fit into int.
5897 * buffer.h (struct buffer.modtime): Now time_t, not int.
5898 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5899 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5900
5901 Minor fixes for signed vs unsigned integers.
5902 * character.h (MAYBE_UNIFY_CHAR):
5903 * charset.c (maybe_unify_char):
5904 * keyboard.c (read_char, reorder_modifiers):
5905 XINT -> XFASTINT, since the integer must be nonnegative.
5906 * ftfont.c (ftfont_spec_pattern):
5907 * keymap.c (access_keymap, silly_event_symbol_error):
5908 XUINT -> XFASTINT, since the integer must be nonnegative.
5909 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5910 since it makes no difference and we prefer signed.
5911 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5912 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5913 nonnegative.
5914
5915 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5916
5917 * window.h (Fwindow_frame): Declare.
5918
5919 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5920
5921 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5922 (SPARE_MEMORY): Always define.
5923 (LARGE_REQUEST): Remove.
5924 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5925
5926 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5927
5928 * lisp.h: Move EXFUNS for Fframe_root_window,
5929 Fframe_first_window and Fset_frame_selected_window to window.h.
5930
5931 * window.h: Move EXFUNS for Fframe_root_window,
5932 Fframe_first_window and Fset_frame_selected_window here from
5933 lisp.h.
5934
5935 * frame.c (Fwindow_frame, Fframe_first_window)
5936 (Fframe_root_window, Fframe_selected_window)
5937 (Fset_frame_selected_window): Move to window.c.
5938 (Factive_minibuffer_window): Move to minibuf.c.
5939 (Fother_visible_frames_p): New function.
5940
5941 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5942
5943 * window.c (decode_window, decode_any_window): Move up in code.
5944 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5945 (inhibit_frame_unsplittable): Remove unused variable.
5946 (Fwindow_buffer): Move up and rewrite doc-string.
5947 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5948 (Fwindow_prev): New functions.
5949 (Fwindow_frame): Move here from frame.c. Accept any window as
5950 argument.
5951 (Fframe_root_window, Fframe_first_window)
5952 (Fframe_selected_window): Move here from frame.c. Accept frame
5953 or arbitrary window as argument. Update doc-strings.
5954 (Fminibuffer_window): Move up in code.
5955 (Fwindow_minibuffer_p): Move up in code and simplify.
5956 (Fset_frame_selected_window): Move here from frame.c.
5957 Marginal rewrite.
5958 (Fselected_window, select_window, Fselect_window): Move up in
5959 code. Minor doc-string fixes.
5960
5961 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5962
5963 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5964 Do not assume that spare memory exists; that assumption is valid
5965 only if SYSTEM_MALLOC.
5966 (LARGE_REQUEST): New macro, so that the issue of large requests
5967 is separated from the issue of spare memory.
5968
5969 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5970
5971 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5972 format. (Bug#8806)
5973
5974 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5975
5976 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5977 before statements.
5978
5979 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5980
5981 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5982
5983 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5984
5985 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5986 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5987
5988 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5989
5990 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5991
5992 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5993
5994 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5995 (x_clipboard_manager_save): Add return value.
5996 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5997 New error handlers.
5998 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5999 Obey Vx_select_enable_clipboard_manager. Catch errors in
6000 x_clipboard_manager_save (Bug#8779).
6001 (Vx_select_enable_clipboard_manager): New variable.
6002 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6003
6004 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6005
6006 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6007
6008 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6009
6010 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6011 in the current matrix if keep_current_p is non-zero.
6012
6013 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6014
6015 * bidi.c (bidi_level_of_next_char): Fix last change.
6016
6017 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6018
6019 Support bidi reordering of text covered by display properties.
6020
6021 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6022 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6023 (bidi_cache_search, bidi_cache_iterator_state)
6024 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6025 (bidi_level_of_next_char, bidi_move_to_visually_next):
6026 Support character positions inside a run of characters covered by a
6027 display string.
6028 (bidi_paragraph_init, bidi_resolve_explicit_1)
6029 (bidi_level_of_next_char): Call bidi_fetch_char and
6030 bidi_fetch_char_advance instead of FETCH_CHAR and
6031 FETCH_CHAR_ADVANCE.
6032 (bidi_init_it): Initialize new members.
6033 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6034 definitions.
6035 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6036 instead of using explicit *_CHAR codes.
6037 (bidi_resolve_explicit, bidi_resolve_weak):
6038 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6039 bidirectional text is supported only in multibyte buffers.
6040 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6041 it to initialize the frame_window_p member of struct bidi_it.
6042 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6043 (bidi_resolve_explicit, bidi_resolve_weak)
6044 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6045 bidi_it->nchars is non-positive.
6046 (bidi_level_of_next_char): Don't try to lookup the cache for the
6047 next/previous character if nothing is cached there yet, or if we
6048 were just reseat()'ed to a new position.
6049
6050 * xdisp.c (set_cursor_from_row): Set start and stop points
6051 according to the row's direction when priming the loop that looks
6052 for the glyph on which to display cursor.
6053 (single_display_spec_intangible_p): Function deleted.
6054 (display_prop_intangible_p): Reimplement to call
6055 handle_display_spec instead of single_display_spec_intangible_p.
6056 Accept 3 additional arguments needed by handle_display_spec.
6057 This fixes incorrect cursor motion across display property with complex
6058 values: lists, `(when COND...)' forms, etc.
6059 (single_display_spec_string_p): Support property values that are
6060 lists with the argument STRING its top-level element.
6061 (display_prop_string_p): Fix the condition for processing a
6062 property that is a list to be consistent with handle_display_spec.
6063 (handle_display_spec): New function, refactored from the
6064 last portion of handle_display_prop.
6065 (compute_display_string_pos): Accept additional argument
6066 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6067 value of a `display' property is a "replacing spec".
6068 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6069 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6070 the display property, but just return a value indicating whether
6071 the display property will replace the characters it covers.
6072 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6073 frame_window_p members of struct bidi_it.
6074 (compute_display_string_pos, compute_display_string_end):
6075 New functions.
6076 (push_it): Accept second argument POSITION, where pop_it should
6077 jump to continue iteration.
6078 (reseat_1): Initialize bidi_it.disp_pos.
6079
6080 * keyboard.c (adjust_point_for_property): Adjust the call to
6081 display_prop_intangible_p to its new signature.
6082
6083 * dispextern.h (struct bidi_it): New member frame_window_p.
6084 (bidi_init_it): Update prototypes.
6085 (display_prop_intangible_p): Update prototype.
6086 (compute_display_string_pos, compute_display_string_end):
6087 Declare prototypes.
6088 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6089 EMACS_INT.
6090
6091 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6092
6093 Malloc failure behavior now depends on size of allocation.
6094 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6095 * lisp.h: Change signatures accordingly.
6096 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6097 All callers changed. (Bug#8762)
6098
6099 * gnutls.c: Use Emacs's memory allocators.
6100 Without this change, the gnutls library would invoke malloc etc.
6101 directly, which causes problems on non-SYNC_INPUT hosts, and which
6102 runs afoul of improving memory_full behavior. (Bug#8761)
6103 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6104 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6105 xfree instead of the default malloc, realloc, free.
6106 (Fgnutls_boot): No need to check for memory allocation failure,
6107 since xmalloc does that for us.
6108
6109 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6110 * category.c (hash_get_category_set):
6111 * ccl.c (ccl_driver):
6112 * charset.c (Fdefine_charset_internal):
6113 * charset.h (struct charset.hash_index):
6114 * composite.c (get_composition_id, gstring_lookup_cache)
6115 (composition_gstring_put_cache):
6116 * composite.h (struct composition.hash_index):
6117 * dispextern.h (struct image.hash):
6118 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6119 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6120 (hashfn_equal, hashfn_user_defined, make_hash_table)
6121 (maybe_resize_hash_table, hash_lookup, hash_put)
6122 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6123 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6124 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6125 * image.c (make_image, search_image_cache, lookup_image)
6126 (xpm_put_color_table_h):
6127 * lisp.h (struct Lisp_Hash_Table):
6128 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6129 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6130 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6131 * alloc.c (allocate_vectorlike):
6132 Check for overflow in vector size calculations.
6133 * ccl.c (ccl_driver):
6134 Check for overflow when converting EMACS_INT to int.
6135 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6136 need to be updated by these changes.
6137 * fns.c (make_hash_table, maybe_resize_hash_table):
6138 Check for integer overflow with large hash tables.
6139 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6140 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6141 (SXHASH_REDUCE): New macro.
6142 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6143 Use it instead of discarding useful hash info with large hash values.
6144 (sxhash_float): New function.
6145 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6146 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6147 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6148 Rewrite to use FIXNUM_BITS, as this simplifies things.
6149 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6150 Adjust signatures to match updated version of code.
6151 (consing_since_gc): Now EMACS_INT, since a single hash table can
6152 use more than INT_MAX bytes.
6153
6154 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6155
6156 Make it possible to build with GCC-4.6+ -O2 -flto.
6157
6158 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6159
6160 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6161
6162 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6163 Call minibuffer-inactive-mode.
6164
6165 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6166
6167 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6168 Update dependencies.
6169
6170 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6171
6172 * data.c (init_data): Remove code for UTS, this system is not
6173 supported anymore.
6174
6175 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6176
6177 Don't force ./temacs to start in terminal mode.
6178
6179 * frame.c (make_initial_frame): Initialize faces in all cases, not
6180 only when CANNOT_DUMP is defined.
6181 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6182
6183 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6184
6185 * dispnew.c (add_window_display_history): Use const for the string
6186 pointer. Remove declaration, not needed.
6187
6188 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6189
6190 Use 'inline', not 'INLINE'.
6191 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6192 * alloc.c, fontset.c (INLINE): Remove.
6193 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6194 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6195 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6196 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6197 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6198
6199 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6200
6201 Make it possible to run ./temacs.
6202
6203 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6204 syms_of_callproc does the same thing. Remove test for
6205 "initialized", do it in the caller.
6206 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6207
6208 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6209
6210 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6211 (read_minibuf): Use get_minibuffer.
6212 (syms_of_minibuf): Use DEFSYM.
6213 (Qmetadata): New var.
6214 * data.c (Qbuffer): Don't make it static.
6215 (syms_of_data): Use DEFSYM.
6216
6217 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6218
6219 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6220 (CCL_CODE_MIN): New macro.
6221
6222 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6223
6224 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6225
6226 * eval.c (Qdebug): Now static.
6227 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6228 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6229 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6230
6231 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6232
6233 * image.c: Various fixes to ImageMagick code comments.
6234 (Fimagemagick_types): Doc fix.
6235
6236 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6237
6238 Minor fixes prompted by GCC 4.6.0 warnings.
6239
6240 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6241
6242 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6243 (x_clipboard_manager_save_all): Move extern decl to ...
6244 * xterm.h: ... here, so that it can be checked for consistency.
6245
6246 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6247
6248 * xselect.c (x_clipboard_manager_save_frame)
6249 (x_clipboard_manager_save_all): New functions.
6250 (Fx_clipboard_manager_save): Lisp function deleted.
6251
6252 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6253 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6254
6255 * xterm.h: Update prototype.
6256
6257 2011-05-28 William Xu <william.xwl@gmail.com>
6258
6259 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6260 exiting (Bug#8239).
6261
6262 2011-05-28 Jim Meyering <meyering@redhat.com>
6263
6264 Avoid a sign-extension bug in crypto_hash_function.
6265 * fns.c (to_uchar): Define.
6266 (crypto_hash_function): Use it to convert some newly-signed
6267 variables to unsigned, to avoid sign-extension bugs. For example,
6268 without this change, (md5 "truc") would evaluate to
6269 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6270 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6271 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6272
6273 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6274
6275 Integer overflow fixes.
6276
6277 * dbusbind.c: Serial number integer overflow fixes.
6278 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6279 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6280 to hold a serial number that is too large for a fixnum.
6281 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6282 Check for serial numbers out of range. Decode any serial number
6283 that was so large that it became a float. (Bug#8722)
6284
6285 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6286 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6287 Use XFASTINT rather than XUINT when numbers are nonnegative.
6288 (xd_append_arg, Fdbus_method_return_internal):
6289 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6290 arguments, check that Lisp number is nonnegative, rather than
6291 silently wrapping negative numbers around. (Bug#8722)
6292 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6293 (Bug#8722)
6294
6295 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6296
6297 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6298
6299 ccl: Add integer overflow checks.
6300 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6301 (IN_INT_RANGE): New macros.
6302 (ccl_driver): Use them to check for integer overflow when
6303 decoding a CCL program. Many of the new checks are whether XINT (x)
6304 fits in int; it doesn't always, on 64-bit hosts. The new version
6305 doesn't catch all possible integer overflows, but it's an
6306 improvement. (Bug#8719)
6307
6308 * alloc.c (make_event_array): Use XINT, not XUINT.
6309 There's no need for unsigned here.
6310
6311 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6312 This follows up to the 2011-05-06 change that substituted uintptr_t
6313 for EMACS_INT. This case wasn't caught back then.
6314
6315 Rework Fformat to avoid integer overflow issues.
6316 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6317 now (part of C89). Include <verify.h>.
6318 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6319 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6320 (Fformat): Avoid the prepass trying to compute sizes; it was only
6321 approximate and thus did not catch overflow reliably. Instead, walk
6322 through the format just once, formatting and computing sizes as we go,
6323 checking for integer overflow at every step, and allocating a larger
6324 buffer as needed. Keep track separately whether the format is
6325 multibyte. Keep only the most-recently calculated precision, rather
6326 than them all. Record whether each argument has been converted to
6327 string. Use EMACS_INT, not int, for byte and char and arg counts.
6328 Support field widths and precisions larger than INT_MAX. Avoid
6329 sprintf's undefined behavior with conversion specifications such as %#d
6330 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6331 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6332 formatting out-of-range floating point numbers with int
6333 formats. (Bug#8668)
6334
6335 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6336
6337 * data.c: Avoid integer truncation in expressions involving floats.
6338 * data.c: Include <intprops.h>.
6339 (arith_driver): When there's an integer overflow in an expression
6340 involving floating point, convert the integers to floating point
6341 so that the resulting value does not suffer from catastrophic
6342 integer truncation. For example, on a 64-bit host (* 4
6343 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6344 Do not rely on undefined behavior after integer overflow.
6345
6346 merge count_size_as_multibyte, parse_str_to_multibyte
6347 * character.c, character.h (count_size_as_multibyte):
6348 Rename from parse_str_to_multibyte; all uses changed.
6349 Check for integer overflow.
6350 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6351 since it's now a duplicate of the other. This is more of
6352 a character than a buffer op, so better that it's in character.c.
6353 * fns.c, print.c: Adjust to above changes.
6354
6355 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6356
6357 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6358
6359 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6360
6361 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6362 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6363 (x_clipboard_manager_save): Now static.
6364 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6365
6366 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6367 (crypto_hash_function): Now static.
6368 Fix pointer signedness problems. Avoid unnecessary initializations.
6369
6370 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6371
6372 * termhooks.h (Vselection_alist): Make it terminal-local.
6373
6374 * terminal.c (create_terminal): Initialize it.
6375
6376 * xselect.c: Support for clipboard managers.
6377 (Vselection_alist): Move to termhooks.h as terminal-local var.
6378 (LOCAL_SELECTION): New macro.
6379 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6380 (symbol_to_x_atom): Remove gratuitous arg.
6381 (x_handle_selection_request, lisp_data_to_selection_data)
6382 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6383 (x_own_selection, x_get_local_selection, x_convert_selection):
6384 New arg, specifying work frame. Use terminal-local Vselection_alist.
6385 (some_frame_on_display): Delete unused function.
6386 (Fx_own_selection_internal, Fx_get_selection_internal)
6387 (Fx_disown_selection_internal, Fx_selection_owner_p)
6388 (Fx_selection_exists_p): New optional frame arg.
6389 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6390 (x_handle_selection_clear): Don't treat other terminals with the
6391 same keyboard specially. Use the terminal-local Vselection_alist.
6392 (x_clear_frame_selections): Use Frun_hook_with_args.
6393
6394 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6395
6396 * xterm.h: Add support for those atoms.
6397
6398 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6399
6400 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6401 (converted_selections, conversion_fail_tag): New global variables.
6402 (x_selection_request_lisp_error): Free the above.
6403 (x_get_local_selection): Remove unnecessary code.
6404 (x_reply_selection_request): Args changed; handle arbitrary array
6405 of converted selections stored in converted_selections.
6406 Separate the XChangeProperty and SelectionNotify steps.
6407 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6408 (x_convert_selection): New function.
6409 (x_handle_selection_event): Simplify.
6410 (x_get_foreign_selection): Don't ignore incoming requests while
6411 waiting for an answer; this will fail when we implement
6412 SAVE_TARGETS, and seems unnecessary anyway.
6413 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6414 (Vx_sent_selection_functions): Doc fix.
6415
6416 2011-05-26 Leo Liu <sdl.web@gmail.com>
6417
6418 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6419
6420 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6421
6422 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6423
6424 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6425 for fringe update if it has periodic bitmap.
6426 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6427 and fringe_bitmap_periodic_p.
6428
6429 * fringe.c (get_fringe_bitmap_data): New function.
6430 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6431 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6432 row. Mark glyph row for fringe update if periodicity changed.
6433
6434 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6435 for fringe update unless it has periodic bitmap.
6436
6437 2011-05-25 Kenichi Handa <handa@m17n.org>
6438
6439 * xdisp.c (get_next_display_element): Set correct it->face_id for
6440 a static composition.
6441
6442 2011-05-24 Leo Liu <sdl.web@gmail.com>
6443
6444 * deps.mk (fns.o):
6445 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6446
6447 * fns.c (crypto_hash_function, Fsha1): New function.
6448 (Fmd5): Use crypto_hash_function.
6449 (syms_of_fns): Add Ssha1.
6450
6451 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6452
6453 * gnutls.c: Remove unused macros.
6454 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6455 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6456 Remove macros that are defined and never used.
6457 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6458
6459 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6460
6461 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6462 (Fx_get_selection_internal): Minor cleanup.
6463 (Fx_own_selection_internal): Rename arguments for consistency with
6464 select.el.
6465
6466 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6467
6468 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6469
6470 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6471
6472 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6473
6474 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6475
6476 * dispnew.c (scrolling_window): Don't exclude the case that the
6477 last enabled row in the desired matrix touches the bottom boundary.
6478
6479 2011-05-21 Glenn Morris <rgm@gnu.org>
6480
6481 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6482 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6483 and add some more files.
6484
6485 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6486
6487 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6488 report_file_error introduced by the change from 2011-05-07.
6489
6490 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6491
6492 * systime.h (Time): Define only if emacs is defined.
6493 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6494 where the include path doesn't have X11/X.h by default. See
6495 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6496
6497 2011-05-20 Kenichi Handa <handa@m17n.org>
6498
6499 * composite.c (find_automatic_composition): Fix previous change.
6500
6501 2011-05-20 Glenn Morris <rgm@gnu.org>
6502
6503 * lisp.mk: New file, split from Makefile.in.
6504 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6505 (shortlisp): Remove.
6506 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6507
6508 2011-05-19 Glenn Morris <rgm@gnu.org>
6509
6510 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6511 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6512 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6513 (lisp): Set the order to that of loadup.el.
6514 (shortlisp): Make it a copy of $lisp.
6515 (SOME_MACHINE_LISP): Remove.
6516 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6517 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6518
6519 2011-05-18 Kenichi Handa <handa@m17n.org>
6520
6521 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6522 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6523 (find_automatic_composition): Mostly rewrite for efficiency.
6524
6525 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6526
6527 * makefile.w32-in: Update dependencies.
6528
6529 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6530
6531 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6532 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6533
6534 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6535
6536 Fix some integer overflow issues, such as string length overflow.
6537
6538 * insdel.c (count_size_as_multibyte): Check for string overflow.
6539
6540 * character.c (lisp_string_width): Check for string overflow.
6541 Use EMACS_INT, not int, for string indexes and lengths; in
6542 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6543 the resulting string length overflows an EMACS_INT; instead,
6544 report a string overflow if no precision given. When checking for
6545 precision exhaustion, use a check that cannot possibly have
6546 integer overflow. (Bug#8675)
6547 * character.h (lisp_string_width): Adjust to new signature.
6548
6549 * alloc.c (string_overflow): New function.
6550 (Fmake_string): Use it. This doesn't change behavior, but saves
6551 a few bytes and will simplify future changes.
6552 * character.c (string_escape_byte8): Likewise.
6553 * lisp.h (string_overflow): New decl.
6554
6555 Fixups, following up to the user-interface timestamp change.
6556 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6557 for UI timestamps, instead of unsigned long.
6558 * msdos.c (mouse_get_pos): Likewise.
6559 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6560 * w32gui.h (Time): Define by including "systime.h" rather than by
6561 declaring it ourselves. (Bug#8664)
6562
6563 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6564 * image.c (clear_image_cache): Likewise.
6565
6566 * term.c (term_mouse_position): Don't assume time_t wraparound.
6567
6568 Be more systematic about user-interface timestamps.
6569 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6570 and sometimes 'EMACS_UINT', to represent these timestamps.
6571 This change causes it to use 'Time' uniformly, as that's what X uses.
6572 This makes the code easier to follow, and makes it easier to catch
6573 integer overflow bugs such as Bug#8664.
6574 * frame.c (Fmouse_position, Fmouse_pixel_position):
6575 Use Time, not unsigned long, for user-interface timestamps.
6576 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6577 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6578 * keyboard.h (last_event_timestamp): Likewise.
6579 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6580 * menu.h (xmenu_show): Likewise.
6581 * term.c (term_mouse_position): Likewise.
6582 * termhooks.h (struct input_event.timestamp): Likewise.
6583 (struct terminal.mouse_position_hook): Likewise.
6584 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6585 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6586 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6587 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6588 what it was before.
6589 * menu.h, termhooks.h: Include "systime.h", for Time.
6590
6591 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6592 Don't assume that the difference between two unsigned long values
6593 can fit into an integer. At this point, we know button_down_time
6594 <= event->timestamp, so the difference must be nonnegative, so
6595 there's no need to cast the result if double-click-time is
6596 nonnegative, as it should be; check that it's nonnegative, just in
6597 case. This bug is triggered when events are more than 2**31 ms
6598 apart (about 25 days). (Bug#8664)
6599
6600 * xselect.c (last_event_timestamp): Remove duplicate decl.
6601 (x_own_selection): Remove needless cast to unsigned long.
6602
6603 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6604 that always fit in int. Use a sentinel instead of a counter, to
6605 avoid a temp and to allay GCC's concerns about possible int overflow.
6606 * frame.h (struct frame): Use int for menu_bar_items_used
6607 instead of EMACS_INT, since it always fits in int.
6608
6609 * menu.c (grow_menu_items): Check for int overflow.
6610
6611 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6612
6613 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6614 Before, the code was not consistent. These values cannot exceed
6615 2**31 - 1 so there's no need to make them unsigned.
6616 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6617 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6618 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6619 as modifiers.
6620 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6621
6622 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6623 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6624 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6625 presumably because the widths might not match.
6626
6627 * window.c (size_window): Avoid needless test at loop start.
6628
6629 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6630
6631 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6632
6633 2011-05-12 Drew Adams <drew.adams@oracle.com>
6634
6635 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6636
6637 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6638
6639 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6640 `width' to `bar_area_x' and `bar_area_width', respectively.
6641 (x_scroll_run): Take account of fringe background extension.
6642
6643 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6644 Rename local vars `left' and `width' to `bar_area_x' and
6645 `bar_area_width', respectively.
6646 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6647 background extension.
6648
6649 2011-05-10 Jim Meyering <meyering@redhat.com>
6650
6651 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6652
6653 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6654
6655 * image.c (Finit_image_library): Return t for built-in image types,
6656 like pbm and xbm. (Bug#8640)
6657
6658 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6659
6660 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6661
6662 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6663
6664 * w32console.c (Fset_screen_color): Doc fix.
6665 (Fget_screen_color): New function.
6666 (syms_of_ntterm): Defsubr it.
6667
6668 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6669 unlink the temporary file if Fcall_process didn't create it in the
6670 first place.
6671 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6672 child process will be redirected to a file specified with `:file'.
6673 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6674 cue to call_process_cleanup not to close that handle.
6675
6676 2011-05-07 Ben Key <bkey76@gmail.com>
6677
6678 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6679 one of two shell specific rules, either bootstrap-temacs-CMD or
6680 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6681 to the previous implementation of the bootstrap-temacs rule.
6682 The bootstrap-temacs-CMD rule is similar to the previous
6683 implementation of the bootstrap-temacs rule except that it
6684 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6685 variable.
6686
6687 These changes, along with some changes to nt/configure.bat,
6688 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6689 earlier fix to add support for --cflags and --ldflags options
6690 that include quotes so that it works whether make uses cmd or
6691 sh as the shell.
6692
6693 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6694
6695 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6696 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6697 is a constant.
6698 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6699 a string. Handle both cases.
6700 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6701 (Fdbus_register_method): Use Qinvalid_function.
6702
6703 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6704
6705 * makefile.w32-in: Update dependencies.
6706 (LISP_H): Add inttypes.h and stdin.h.
6707 (PROCESS_H): Add unistd.h.
6708
6709 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6710
6711 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6712 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6713
6714 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6715
6716 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6717
6718 * term.c (vfatal): Remove stray call to va_end.
6719 It's not needed and the C Standard doesn't allow it here anyway.
6720
6721 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6722 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6723
6724 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6725 bytes.
6726
6727 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6728
6729 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6730
6731 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6732
6733 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6734
6735 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6736
6737 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6738 * charset.c (Fdefine_charset_internal): Don't initialize
6739 charset.code_space[15]. The value was garbage, on hosts with
6740 32-bit int (Bug#8600).
6741
6742 * lread.c (read_integer): Be more consistent with string-to-number.
6743 Use string_to_number to do the actual conversion; this avoids
6744 rounding errors and fixes some other screwups. Without this fix,
6745 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6746 (digit_to_number): Move earlier, for benefit of read_integer.
6747 Return -1 if the digit is out of range for the base, -2 if it is
6748 not a digit in any supported base. (Bug#8602)
6749
6750 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6751
6752 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6753 to match comment at start of function. This also removes a
6754 GCC warning about overflow in a 32+64-bit port.
6755
6756 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6757
6758 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6759 Reported by Stefan Monnier in
6760 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6761 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6762 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6763
6764 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6765 (EMACS_UINTPTR): Likewise, with uintptr_t.
6766
6767 * lisp.h: Prefer 64-bit EMACS_INT if available.
6768 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6769 on 32-bit hosts that have 64-bit int, so that they can access
6770 large files.
6771 However, temporarily disable this change unless the temporary
6772 symbol WIDE_EMACS_INT is defined.
6773
6774 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6775
6776 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6777 This removes an assumption that EMACS_INT and long are the same
6778 width as pointers. The assumption is true for Emacs porting targets
6779 now, but we want to make other targets possible.
6780 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6781 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6782 In the rest of the code, change types of integers that hold casted
6783 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6784 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6785 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6786 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6787 No need to cast type when ORing.
6788 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6789 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6790 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6791 assume EMACS_INT is the same width as char *.
6792 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6793 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6794 Remove no-longer-needed casts.
6795 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6796 (xg_tool_bar_help_callback, xg_make_tool_item):
6797 Use EMACS_INTPTR to hold an integer
6798 that will be cast to void *; this can avoid a GCC warning
6799 if EMACS_INT is not the same width as void *.
6800 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6801 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6802 (current_message_1, set_message_1):
6803 Use a local to convert to proper width without a cast.
6804 * xmenu.c (dialog_selection_callback): Likewise.
6805
6806 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6807 Also, don't assume VALBITS / RAND_BITS is less than 5,
6808 and don't rely on undefined behavior when shifting a 1 left into
6809 the sign bit.
6810 * lisp.h (get_random): Change signature to match.
6811
6812 * lread.c (hash_string): Use size_t, not int, for hash computation.
6813 Normally we prefer signed values; but hashing is special, because
6814 it's better to use unsigned division on hash table sizes so that
6815 the remainder is nonnegative. Also, size_t is the natural width
6816 for hashing into memory. The previous code used 'int', which doesn't
6817 retain enough info to hash well into very large tables.
6818 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6819
6820 * dbusbind.c: Don't possibly lose pointer info when converting.
6821 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6822 Use XPNTR rather than XHASH, so that the high-order bits of
6823 the pointer aren't lost when converting through void *.
6824
6825 * eval.c (Fautoload): Don't double-shift a pointer.
6826
6827 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6828
6829 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6830
6831 * gnutls.c (DEF_GNUTLS_FN):
6832 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6833
6834 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6835
6836 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6837 marker. (Bug#8610)
6838
6839 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6840
6841 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6842 New version that can reserve upto 2GB of heap space.
6843
6844 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6845
6846 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6847
6848 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6849
6850 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6851 `gnutls_certificate_set_x509_key_file'.
6852
6853 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6854
6855 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6856 Update dependencies.
6857
6858 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6859
6860 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6861 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6862 Remove unused parameter `fildes'.
6863 * process.c (read_process_output, send_process): Don't pass it.
6864
6865 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6866
6867 Fix previous change: the library cache is defined in w32.c.
6868 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6869 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6870
6871 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6872
6873 Implement dynamic loading of GnuTLS on Windows.
6874
6875 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6876 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6877 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6878 Declare.
6879
6880 * gnutls.c (Qgnutls_dll): Define.
6881 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6882 (gnutls_*): Declare function pointers.
6883 (init_gnutls_functions): New function to initialize function pointers.
6884 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6885 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6886 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6887 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6888 (emacs_gnutls_write, emacs_gnutls_read)
6889 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6890 (Fgnutls_available_p): New function.
6891 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6892 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6893 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6894
6895 * image.c: Include w32.h.
6896 (Vimage_type_cache): Delete.
6897 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6898 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6899 (w32_delayed_load): Move to w32.c.
6900
6901 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6902
6903 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6904 (w32_delayed_load): Move from image.c. When loading a library, record
6905 its filename in the :loaded-from property of the library id.
6906 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6907 Initialize and staticpro them.
6908 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6909
6910 * process.c: Include lisp.h before w32.h, not after.
6911 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6912 instead of gnutls_record_check_pending.
6913
6914 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6915
6916 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6917
6918 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6919 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6920 as passed in.
6921
6922 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6923
6924 * xterm.c (x_set_frame_alpha): Do not set property on anything
6925 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6926
6927 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6928
6929 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6930
6931 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6932
6933 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6934 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6935 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6936 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6937 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6938 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6939 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6940 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6941 (Qgnutls_bootprop_callbacks_verify): Make static.
6942
6943 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6944
6945 * callproc.c: Indentation fixup.
6946
6947 * sysdep.c (wait_for_termination_1): Make static.
6948 (wait_for_termination, interruptible_wait_for_termination):
6949 Move after wait_for_termination_1.
6950
6951 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6952
6953 * sysdep.c (interruptible_wait_for_termination): New function
6954 which is like wait_for_termination, but allows keyboard
6955 interruptions.
6956
6957 * callproc.c (Fcall_process): Add (:file "file") as an option for
6958 the STDOUT buffer.
6959 (Fcall_process_region): Ditto.
6960
6961 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6962
6963 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6964 rather than `XVECTOR (FOO)->size'.
6965
6966 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6967 inttypes.h, as a gnulib replacement is used if it not available in
6968 system headers.
6969
6970 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6971
6972 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6973 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6974 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6975
6976 * coding.c (coding_alloc_by_realloc): Error out if destination
6977 will grow beyond MOST_POSITIVE_FIXNUM.
6978 (decode_coding_emacs_mule): Abort if there isn't enough place in
6979 charbuf for the composition carryover bytes. Reserve an extra
6980 space for up to 2 characters produced in a loop.
6981 (decode_coding_iso_2022): Abort if there isn't enough place in
6982 charbuf for the composition carryover bytes.
6983
6984 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6985
6986 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6987 aborting when %lld or %lll format is passed.
6988 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6989 %llo or %llx format is passed. (Bug#8545)
6990
6991 * window.c (window_scroll_line_based): Use a marker instead of
6992 simple variables to record original value of point. (Bug#7952)
6993
6994 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6995 produced by %s or %c overflows available buffer space. (Bug#8545)
6996
6997 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6998
6999 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7000 (SIZE_MAX): Move defn after all includes, as they might #define it.
7001
7002 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7003
7004 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7005
7006 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7007
7008 * keyboard.c (Qdelayed_warnings_hook): Define.
7009 (command_loop_1): Run `delayed-warnings-hook'
7010 if Vdelayed_warnings_list is non-nil.
7011 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7012 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7013
7014 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7015
7016 * doprnt.c (doprnt): Don't return value smaller than the buffer
7017 size if the message was truncated. (Bug#8545).
7018
7019 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7020
7021 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7022 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7023
7024 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7025
7026 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7027
7028 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7029
7030 * makefile.w32-in: Update dependencies.
7031
7032 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7033
7034 Improve `doprnt' and its usage. (Bug#8545)
7035 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7036 `format_end'. Remove support for %l as a conversion specifier.
7037 Don't use xrealloc. Improve diagnostics when the %l size modifier
7038 is used. Update the commentary.
7039
7040 * eval.c (verror): Simplify calculation of size_t.
7041
7042 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7043 messages.
7044
7045 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7046
7047 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7048 change.
7049
7050 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7051
7052 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7053 This makes this file independent of the recent pseudovector change.
7054
7055 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7056
7057 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7058
7059 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7060 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7061 Remove unused local.
7062 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7063
7064 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7065 GCC 4.6.0 optimizes based on type-based alias analysis.
7066 For example, if b is of type struct buffer * and v of type struct
7067 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7068 != &v->size, and therefore "v->size = 1; b->size = 2; return
7069 v->size;" must therefore return 1. This assumption is incorrect
7070 for Emacs, since it type-puns struct Lisp_Vector * with many other
7071 types. To fix this problem, this patch adds a new type struct
7072 vectorlike_header that documents the constraints on layout of vectors
7073 and pseudovectors, and helps optimizing compilers not get fooled
7074 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7075 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7076 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7077 the size member.
7078 (XSETPVECTYPE): Rewrite in terms of new macro.
7079 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7080 This is a bit clearer, and further avoids the possibility of
7081 undesirable aliasing.
7082 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7083 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7084 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7085 since Lisp_Subr is a special case (no "next" field).
7086 (ASIZE): Now uses header.size rather than size.
7087 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7088 to avoid the hassle of writing XVECTOR (foo)->header.size.
7089 (struct vectorlike_header): New type.
7090 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7091 object, to help avoid aliasing.
7092 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7093 (SUBRP): Likewise, since Lisp_Subr is a special case.
7094 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7095 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7096 (struct Lisp_Hash_Table): Combine first two members into a single
7097 struct vectorlike_header member. All uses of "size" and "next" members
7098 changed to be "header.size" and "header.next".
7099 * buffer.h (struct buffer): Likewise.
7100 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7101 * frame.h (struct frame): Likewise.
7102 * process.h (struct Lisp_Process): Likewise.
7103 * termhooks.h (struct terminal): Likewise.
7104 * window.c (struct save_window_data, struct saved_window): Likewise.
7105 * window.h (struct window): Likewise.
7106 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7107 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7108 * buffer.c (init_buffer_once): Likewise.
7109 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7110 special case.
7111 * process.c (Fformat_network_address): Use local var for size,
7112 for brevity.
7113
7114 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7115
7116 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7117 * data.c (atof): Remove decl; no longer used or needed.
7118 (digit_to_number): Move to lread.c.
7119 (Fstring_to_number): Use new string_to_number function, to be
7120 consistent with how the Lisp reader treats infinities and NaNs.
7121 Do not assume that floating-point numbers represent EMACS_INT
7122 without losing information; this is not true on most 64-bit hosts.
7123 Avoid double-rounding errors, by insisting on integers when
7124 parsing non-base-10 numbers, as the documentation specifies.
7125 * lisp.h (string_to_number): New decl, replacing ...
7126 (isfloat_string): Remove.
7127 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7128 (read1): Do not accept +. and -. as integers; this
7129 appears to have been a coding error. Similarly, do not accept
7130 strings like +-1e0 as floating point numbers. Do not report
7131 overflow for integer overflows unless the base is not 10 which
7132 means we have no simple and reliable way to continue.
7133 Break out the floating-point parsing into a new
7134 function string_to_number, so that Fstring_to_number parses
7135 floating point numbers consistently with the Lisp reader.
7136 (digit_to_number): Move here from data.c. Make it static inline.
7137 (E_CHAR, EXP_INT): Remove, replacing with ...
7138 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7139 (string_to_number): New function, replacing isfloat_string.
7140 This function checks for valid syntax and produces the resulting
7141 Lisp float number too. Rework it so that string-to-number
7142 no longer mishandles examples like "1.0e+". Use strtoumax,
7143 so that overflow for non-base-10 numbers is reported only when
7144 there's no portable and simple way to convert to floating point.
7145
7146 * textprop.c (set_text_properties_1): Rewrite for clarity,
7147 and to avoid GCC warning about integer overflow.
7148
7149 * intervals.h (struct interval): Use EMACS_INT for members
7150 where EMACS_UINT might cause problems. See
7151 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7152 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7153 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7154 All uses changed.
7155 (offset_intervals): Tell GCC not to worry about length overflow
7156 when negating a negative length.
7157
7158 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7159 (overrun_check_free): Likewise.
7160
7161 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7162 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7163 word size.
7164
7165 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7166 (gnutls_make_error): Rename local to avoid shadowing.
7167 (gnutls_emacs_global_deinit): ifdef out; not used.
7168 (Fgnutls_boot): Use const for pointer to readonly storage.
7169 Comment out unused local. Fix pointer signedness problems.
7170
7171 * lread.c (openp): Don't stuff size_t into an 'int'.
7172 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7173 about possible signed overflow.
7174
7175 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7176 (GDK_KEY_g): Don't define if already defined.
7177 (xg_prepare_tooltip): Avoid pointer signedness problem.
7178 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7179
7180 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7181 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7182
7183 * xfns.c (Fx_window_property): Simplify a bit,
7184 to make a bit faster and to avoid GCC 4.6.0 warning.
7185 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7186
7187 * fns.c (internal_equal): Don't assume size_t fits in int.
7188
7189 * alloc.c (compact_small_strings): Tighten assertion a little.
7190
7191 Replace pEd with more-general pI, and fix some printf arg casts.
7192 * lisp.h (pI): New macro, generalizing old pEd macro to other
7193 conversion specifiers. For example, use "...%"pI"d..." rather
7194 than "...%"pEd"...".
7195 (pEd): Remove. All uses replaced with similar uses of pI.
7196 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7197 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7198 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7199 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7200 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7201 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7202 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7203 64-bit hosts.
7204 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7205 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7206 * print.c (safe_debug_print, print_object): Likewise.
7207 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7208 to int.
7209 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7210 avoiding the 0 flag, which is not portable.
7211 * process.c (Fmake_network_process): Use pI to avoid cast.
7212 * region-cache.c (pp_cache): Likewise.
7213 * xdisp.c (decode_mode_spec): Likewise.
7214 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7215 behavior on 64-bit hosts with printf arg.
7216 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7217 (x_stop_queuing_selection_requests): Likewise.
7218 (x_get_window_property): Don't truncate byte count to an 'int'
7219 when tracing.
7220
7221 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7222 here, since it parses constructs like leading '-' and spaces,
7223 which are not wanted; and it overflows with large numbers.
7224 Instead, simply match F[0-9]+, which is what is wanted anyway.
7225
7226 * alloc.c: Remove unportable assumptions about struct layout.
7227 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7228 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7229 (allocate_vectorlike, make_pure_vector): Use the new macros,
7230 plus offsetof, to remove unportable assumptions about struct layout.
7231 These assumptions hold on all porting targets that I know of, but
7232 they are not guaranteed, they're easy to remove, and removing them
7233 makes further changes easier.
7234
7235 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7236 This doesn't fix a bug but makes the code clearer.
7237 (string_overrun_cookie): Now const. Use initializers that
7238 don't formally overflow signed char, to avoid warnings.
7239 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7240 can cause Emacs to crash when string overrun checking is enabled.
7241 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7242 multiple of sizeof (EMACS_INT); it need not be, if
7243 alignof(EMACS_INT) < sizeof (EMACS_INT).
7244 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7245
7246 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7247
7248 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7249
7250 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7251
7252 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7253 supposed to be handshaking. (Bug#8556)
7254 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7255
7256 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7257
7258 * lisp.h (Qdebug): List symbol.
7259 * eval.c (Qdebug): Restore global linkage.
7260 * keyboard.c (debug-on-event): New variable.
7261 (handle_user_signal): Break into debugger when debug-on-event
7262 matches the current signal symbol.
7263
7264 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7265
7266 * alloc.c (check_sblock, check_string_bytes)
7267 (check_string_free_list): Convert to standard C.
7268
7269 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7270
7271 * w32.c (emacs_gnutls_push): Fix typo.
7272
7273 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7274
7275 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7276 "cast to pointer from integer of different size".
7277
7278 Improve doprnt and its use in verror. (Bug#8545)
7279 * doprnt.c (doprnt): Document the set of format control sequences
7280 supported by the function. Use SAFE_ALLOCA instead of always
7281 using `alloca'.
7282
7283 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7284 is one byte too soon. Don't use xrealloc; instead xfree and
7285 xmalloc anew.
7286
7287 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7288
7289 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7290 callbacks stage.
7291
7292 * gnutls.c: Renamed global_initialized to
7293 gnutls_global_initialized. Added internals for the
7294 :verify-hostname-error, :verify-error, and :verify-flags
7295 parameters of `gnutls-boot' and documented those parameters in the
7296 docstring. Start callback support.
7297 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7298 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7299 on error. Return error code.
7300 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7301 (emacs_gnutls_read): Likewise.
7302 (Fgnutls_boot): Return handshake error code.
7303 (emacs_gnutls_handle_error): New function.
7304 (wsaerror_to_errno): Likewise.
7305
7306 * w32.h (emacs_gnutls_pull): Add prototype.
7307 (emacs_gnutls_push): Likewise.
7308
7309 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7310 (emacs_gnutls_push): Likewise.
7311
7312 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7313
7314 * process.c (wait_reading_process_output): Check if GnuTLS
7315 buffered some data internally if no FDs are set for TLS
7316 connections.
7317
7318 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7319 (LIBS): Link to USER_LIBS.
7320 ($(BLD)/gnutls.$(0)): New target.
7321
7322 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7323
7324 * xdisp.c (handle_single_display_spec): Rename the
7325 display_replaced_before_p argument into display_replaced_p, to
7326 make it consistent with the commentary. Fix typos in the
7327 commentary.
7328
7329 * textprop.c (syms_of_textprop): Remove dead code.
7330 (copy_text_properties): Delete obsolete commentary about an
7331 interface that was deleted long ago. Fix typos in the description
7332 of arguments.
7333
7334 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7335 to changes in oldXMenu/XMenu.h from 2011-04-16.
7336 <menu_help_message, prev_menu_help_message>: Constify.
7337 (IT_menu_make_room): menu->help_text is now `const char **';
7338 adjust.
7339
7340 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7341 to changes in oldXMenu/XMenu.h from 2011-04-16.
7342 (struct XMenu): Declare `help_text' `const char **'.
7343
7344 * xfaces.c <Qunspecified>: Make extern again.
7345
7346 * syntax.c: Include sys/types.h before including regex.h, as
7347 required by Posix.
7348
7349 * doc.c (get_doc_string): Improve the format passed to `error'.
7350
7351 * doprnt.c (doprnt): Improve commentary.
7352
7353 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7354
7355 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7356 them with etags.
7357
7358 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7359 changes in globals.h immediately force recompilation.
7360 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7361 $(CURDIR)/s/ms-w32.h.
7362 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7363
7364 * character.c (Fchar_direction): Function deleted.
7365 (syms_of_character): Don't defsubr it.
7366 <char-direction-table>: Deleted.
7367
7368 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7369
7370 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7371 * doprnt.c: Include limits.h.
7372 (SIZE_MAX): New macro.
7373 (doprnt): Return a size_t value. 2nd arg is now size_t.
7374 Many local variables are now size_t instead of int or unsigned.
7375 Improve overflow protection. Support `l' modifier for integer
7376 conversions. Support %l conversion. Don't assume an EMACS_INT
7377 argument for integer conversions and for %c.
7378
7379 * lisp.h (doprnt): Restore prototype.
7380
7381 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7382 $(SRC)/character.h.
7383
7384 * Makefile.in (base_obj): Add back doprnt.o.
7385
7386 * deps.mk (doprnt.o): Add back prerequisites.
7387 (callint.o): Depend on character.h.
7388
7389 * eval.c (internal_lisp_condition_case): Include the handler
7390 representation in the error message.
7391 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7392 when breaking from the loop.
7393
7394 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7395
7396 * callint.c (Fcall_interactively): When displaying error message
7397 about invalid control letter, pass the character's codepoint, not
7398 a pointer to its multibyte form. Improve display of the character
7399 in octal and display also its hex code.
7400
7401 * character.c (char_string): Use %x to display the (unsigned)
7402 codepoint of an invalid character, to avoid displaying a bogus
7403 negative value.
7404
7405 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7406 `error', not SYMBOL_NAME itself.
7407
7408 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7409 character arguments to `error'.
7410
7411 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7412 to `error' in error message about FINAL_CHAR argument. Make sure
7413 FINAL_CHAR is a character, and use %c when it is passed as
7414 argument to `error'.
7415
7416 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7417
7418 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7419
7420 * w32.c: Include <time.h>.
7421 (sys_localtime): New function.
7422
7423 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7424
7425 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7426
7427 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7428
7429 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7430
7431 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7432 zombies (Bug#8467).
7433
7434 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7435
7436 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7437 gl_state.e_property when gl_state.object is Qt.
7438
7439 * insdel.c (make_gap_larger): Remove limitation of buffer size
7440 to <= INT_MAX.
7441
7442 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7443
7444 * xdisp.c (lookup_glyphless_char_display)
7445 (produce_glyphless_glyph): Handle cons cell entry in
7446 glyphless-char-display.
7447 (Vglyphless_char_display): Document it.
7448
7449 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7450 glyphless-char-display.
7451
7452 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7453
7454 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7455
7456 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7457
7458 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7459 definition for no-X builds.
7460
7461 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7462
7463 Static checks with GCC 4.6.0 and non-default toolkits.
7464
7465 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7466
7467 * process.c (keyboard_bit_set): Define only if SIGIO.
7468 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7469 (send_process): Repair possible setjmp clobbering.
7470
7471 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7472
7473 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7474
7475 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7476
7477 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7478 Define only if needed.
7479
7480 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7481 by pacifying GCC about it. Maybe it's time to retire it?
7482 * xfaces.c (USG, __TIMEVAL__): Likewise.
7483
7484 * dispextern.h (struct redisplay_interface): Rename param
7485 to avoid shadowing.
7486 * termhooks.h (struct terminal): Likewise.
7487 * xterm.c (xembed_send_message): Likewise.
7488
7489 * insdel.c (make_gap_smaller): Define only if
7490 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7491
7492 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7493 it.
7494
7495 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7496 so that we aren't warned about unused symbols.
7497
7498 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7499
7500 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7501
7502 * xfns.c (x_real_positions): Mark locals as initialized.
7503
7504 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7505
7506 * xterm.c: Fix problems found by static analysis with other toolkits.
7507 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7508 (x_dispatch_event): Declare static if USE_GTK, and
7509 define if USE_GTK || USE_X_TOOLKIT.
7510 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7511 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7512 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7513 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7514
7515 * xmenu.c (menu_help_callback): Pointer type fixes.
7516 Use const pointers when pointing at readonly data. Avoid pointer
7517 signedness clashes.
7518 (FALSE): Remove unused macro.
7519 (update_frame_menubar): Remove unused decl.
7520
7521 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7522
7523 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7524 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7525 (single_menu_item): Rename local to avoid shadowing.
7526
7527 * keyboard.c (make_lispy_event): Remove unused local var.
7528
7529 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7530 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7531
7532 * bitmaps: Change bitmaps from unsigned char back to the X11
7533 compatible char. Avoid the old compiler warnings about
7534 out-of-range initializers by using, for example, '\xab' rather
7535 than 0xab.
7536
7537 * xgselect.c (xgselect_initialize): Check vs interface
7538 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7539
7540 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7541
7542 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7543 to read-only memory.
7544
7545 * fns.c (vector): Remove; this old hack is no longer needed.
7546
7547 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7548 Remove unused var.
7549 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7550
7551 * xrdb.c (x_load_resources): Omit unused local.
7552
7553 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7554 (x_window): Rename locals to avoid shadowing.
7555 (USG): Use the kludged USG macro, to pacify gcc.
7556
7557 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7558 (x_term_init): Remove local to avoid shadowing.
7559
7560 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7561
7562 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7563 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7564
7565 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7566
7567 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7568
7569 Fix regex.c, syntax.c and friends for buffers > 2GB.
7570 * syntax.h (struct gl_state_s): Declare character position members
7571 EMACS_INT.
7572
7573 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7574
7575 * textprop.c (verify_interval_modification, interval_of):
7576 Declare arguments EMACS_INT.
7577
7578 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7579 EMACS_INT.
7580
7581 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7582
7583 * indent.c (Fvertical_motion): Local variable it_start is now
7584 EMACS_INT.
7585
7586 * regex.c (re_match, re_match_2, re_match_2_internal)
7587 (bcmp_translate, regcomp, regexec, print_double_string)
7588 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7589 (re_compile_pattern, re_exec): Declare arguments and local
7590 variables `size_t' and `ssize_t' and return values `regoff_t', as
7591 appropriate.
7592 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7593 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7594 <compile_stack_type>: `size' and `avail' are now `size_t'.
7595
7596 * regex.h <regoff_t>: Use ssize_t, not int.
7597 (re_search, re_search_2, re_match, re_match_2): Arguments that
7598 specify buffer/string position and length are now ssize_t and
7599 size_t. Return type is regoff_t.
7600
7601 2011-04-16 Ben Key <bkey76@gmail.com>
7602
7603 * nsfont.m: Fixed bugs in ns_get_family and
7604 ns_descriptor_to_entity that were caused by using free to
7605 deallocate memory blocks that were allocated by xmalloc (via
7606 xstrdup). This caused Emacs to crash when compiled with
7607 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7608 --enable-checking=xmallocoverrun). xfree is now used to
7609 deallocate these memory blocks.
7610
7611 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7612
7613 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7614
7615 emacs_write: Accept and return EMACS_INT for sizes.
7616 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7617 et seq.
7618 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7619 Accept and return EMACS_INT.
7620 (emacs_gnutls_write): Return the number of bytes written on
7621 partial writes.
7622 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7623 (emacs_read, emacs_write): Remove check for negative size, as the
7624 Emacs source code has been audited now.
7625 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7626 (emacs_read, emacs_write): Use it.
7627 * process.c (send_process): Adjust to the new signatures of
7628 emacs_write and emacs_gnutls_write. Do not attempt to store
7629 a byte offset into an 'int'; it might overflow.
7630 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7631
7632 * sound.c: Don't assume sizes fit in 'int'.
7633 (struct sound_device.period_size, alsa_period_size):
7634 Return EMACS_INT, not int.
7635 (struct sound_device.write, vox_write, alsa_write):
7636 Accept EMACS_INT, not int.
7637 (wav_play, au_play): Use EMACS_INT to store sizes and to
7638 record read return values.
7639
7640 2011-04-15 Ben Key <bkey76@gmail.com>
7641
7642 * keyboard.c (Qundefined): Don't declare static since it is used
7643 in nsfns.m.
7644 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7645 static since they are used in nsfont.m.
7646
7647 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7648
7649 * process.c (Qprocessp): Don't declare static.
7650 * lisp.h (Qprocessp): Declare again.
7651
7652 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7653
7654 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7655
7656 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7657
7658 Improve C-level modularity by making more things 'static'.
7659
7660 Don't publish debugger-only interfaces to other modules.
7661 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7662 (verify_bytepos, count_markers): Move decls to the only modules
7663 that need them.
7664 * region-cache.h (pp_cache): Likewise.
7665 * window.h (check_all_windows): Likewise.
7666 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7667
7668 * sysdep.c (croak): Now static, if
7669 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7670 * syssignal.h (croak): Declare only if not static.
7671
7672 * alloc.c (refill_memory_reserve): Now static if
7673 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7674 * lisp.h (refill_memory_reserve): Declare only if not static.
7675
7676 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7677 Define only if USE_LUCID.
7678
7679 * xrdb.c (x_customization_string, x_rm_string): Now static.
7680
7681 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7682 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7683
7684 * xdisp.c (draw_row_with_mouse_face): Now static.
7685 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7686
7687 * window.h (check_all_windows): Mark externally visible.
7688
7689 * window.c (window_deletion_count): Now static.
7690
7691 * undo.c: Make symbols static if they're not exported.
7692 (last_undo_buffer, last_boundary_position, pending_boundary):
7693 Now static.
7694
7695 * textprop.c (interval_insert_behind_hooks): Now static.
7696 (interval_insert_in_front_hooks): Likewise.
7697
7698 * term.c: Make symbols static if they're not exported.
7699 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7700 (max_frame_lines, tty_set_terminal_modes):
7701 (tty_reset_terminal_modes, tty_turn_off_highlight):
7702 (get_tty_terminal): Now static.
7703 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7704 * termhooks.h (term_mouse_moveto): Do not declare if
7705 HAVE_WINDOW_SYSTEM.
7706 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7707 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7708
7709 * sysdep.c: Make symbols static if they're not exported.
7710 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7711 Now static.
7712 (sigprocmask_set, full_mask): Remove; unused.
7713 (wait_debugging): Mark as visible.
7714 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7715 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7716
7717 * syntax.c (syntax_temp): Define only if !__GNUC__.
7718
7719 * sound.c (current_sound_device, current_sound): Now static.
7720
7721 * search.c (searchbufs, searchbuf_head): Now static.
7722
7723 * scroll.c (scroll_cost): Remove; unused.
7724 * dispextern.h (scroll_cost): Remove decl.
7725
7726 * region-cache.h (pp_cache): Mark as externally visible.
7727
7728 * process.c: Make symbols static if they're not exported.
7729 (process_tick, update_tick, create_process, chan_process):
7730 (Vprocess_alist, proc_buffered_char, datagram_access):
7731 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7732 (deactivate_process): Mark defn as static, as well as decl.
7733 * lisp.h (create_process): Remove decl.
7734 * process.h (chan_process, Vprocess_alist): Remove decls.
7735
7736 * print.c: Make symbols static if they're not exported.
7737 (print_depth, new_backquote_output, being_printed, print_buffer):
7738 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7739 (print_interval, print_number_index, initial_stderr_stream):
7740 Now static.
7741 * lisp.h (Fprinc): Remove decl.
7742 (debug_output_compilation_hack): Mark as externally visible.
7743
7744 * sysdep.c (croak): Move decl from here to syssignal.h.
7745 * syssignal.h (croak): Put it here, so the API can be checked when
7746 'croak' is called from dissociate_if_controlling_tty.
7747
7748 * minibuf.c: Make symbols static if they're not exported.
7749 (minibuf_save_list, choose_minibuf_frame): Now static.
7750 * lisp.h (choose_minibuf_frame): Remove decl.
7751
7752 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7753
7754 * lread.c: Make symbols static if they're not exported.
7755 (read_objects, initial_obarray, oblookup_last_bucket_number):
7756 Now static.
7757 (make_symbol): Remove; unused.
7758 * lisp.h (initial_obarray, make_symbol): Remove decls.
7759
7760 * keyboard.c: Make symbols static if they're not exported.
7761 (single_kboard, recent_keys_index, total_keys, recent_keys):
7762 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7763 (this_single_command_key_start, echoing, last_auto_save):
7764 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7765 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7766 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7767 (Vlispy_mouse_stem, double_click_count):
7768 Now static.
7769 (force_auto_save_soon): Define only if SIGDANGER.
7770 (ignore_mouse_drag_p): Now static if
7771 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7772 (print_help): Remove; unused.
7773 (stop_character, last_timer_event): Mark as externally visible.
7774 * keyboard.h (ignore_mouse_drag_p): Declare only if
7775 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7776 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7777 * lisp.h (echoing): Remove decl.
7778 (force_auto_save_soon): Declare only if SIGDANGER.
7779 * xdisp.c (redisplay_window): Simplify code, to make it more
7780 obvious that ignore_mouse_drag_p is not accessed if !defined
7781 USE_GTK && !defined HAVE_NS.
7782
7783 * intervals.c: Make symbols static if they're not exported.
7784 (merge_properties_sticky, merge_interval_right, delete_interval):
7785 Now static.
7786 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7787
7788 * insdel.c: Make symbols static if they're not exported.
7789 However, leave prepare_to_modify_buffer alone. It's never
7790 called from outside this function, but that appears to be a bug.
7791 (combine_after_change_list, combine_after_change_buffer):
7792 (adjust_after_replace, signal_before_change): Now static.
7793 (adjust_after_replace_noundo): Remove; unused.
7794 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7795 (signal_before_change): Remove decls.
7796
7797 * indent.c (val_compute_motion, val_vmotion): Now static.
7798
7799 * image.c: Make symbols static if they're not exported.
7800 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7801 if USE_GTK.
7802 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7803 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7804
7805 * fringe.c (standard_bitmaps): Now static.
7806 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7807
7808 * frame.c: Make symbols static if they're not exported.
7809 (x_report_frame_params, make_terminal_frame): Now static.
7810 (get_frame_param): Now static, unless HAVE_NS.
7811 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7812 (x_get_resource_string): Remove; not used.
7813 * frame.h (make_terminal_frame, x_report_frame_params):
7814 (x_get_resource_string); Remove decls.
7815 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7816 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7817
7818 * font.c, fontset.c: Make symbols static if they're not exported.
7819 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7820 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7821 * font.c (font_close_object): Now static.
7822 * font.h (font_close_object): Remove.
7823 * fontset.c (FONTSET_OBJLIST): Remove.
7824 (free_realized_fontset) #if-0 the body, which does nothing.
7825 (face_suitable_for_char_p): #if-0, as it's never called.
7826 * fontset.h (face_suitable_for_char_p): Remove decl.
7827 * xfaces.c (face_at_string_position):
7828 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7829 since 0 is always ASCII.
7830
7831 * fns.c (weak_hash_tables): Now static.
7832
7833 * fileio.c: Make symbols static if they're not exported.
7834 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7835 (Vwrite_region_annotation_buffers): Now static.
7836
7837 * eval.c: Make symbols static if they're not exported.
7838 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7839 * lisp.h (backtrace_list): Remove decl.
7840
7841 * emacs.c: Make symbols static if they're not exported.
7842 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7843 (fatal_error_code, fatal_error_signal_hook, standard_args):
7844 Now static.
7845 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7846 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7847 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7848 * lisp.h (fatal_error_signal_hook): Remove decl.
7849 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7850
7851 * editfns.c: Move a (normally-unused) function to its only use.
7852 * editfns.c, lisp.h (get_operating_system_release): Remove.
7853 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7854 worth the hassle of breaking this out.
7855
7856 * xterm.c: Make symbols static if they're not exported.
7857 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7858 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7859 (x_destroy_window, x_delete_display):
7860 Now static.
7861 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7862 (x_mouse_leave): Remove; unused.
7863 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7864 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7865 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7866 Remove decls.
7867 (x_mouse_leave): Declare only if WINDOWSNT.
7868 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7869 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7870 USE_X_TOOLKIT.
7871
7872 * ftxfont.c: Make symbols static if they're not exported.
7873 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7874 HAVE_FREETYPE.
7875 * font.h (ftxfont_driver): Likewise.
7876
7877 * xfns.c: Make symbols static if they're not exported.
7878 (x_last_font_name, x_display_info_for_name):
7879 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7880 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7881 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7882 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7883 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7884 (last_show_tip_args): Now static.
7885 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7886 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7887 (x_screen_planes): Remove; unused.
7888 * dispextern.h (x_screen_planes): Remove decl.
7889
7890 * dispnew.c: Make symbols static if they're not exported.
7891 * dispextern.h (redraw_garbaged_frames, scrolling):
7892 (increment_row_positions): Remove.
7893 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7894 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7895 Now static.
7896 (redraw_garbaged_frames): Remove; unused.
7897
7898 * xfaces.c: Make symbols static if they're not exported.
7899 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7900 Remove decls.
7901 * xterm.h (defined_color): Remove decls.
7902 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7903 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7904 (menu_face_changed_default, defined_color, free_realized_face):
7905 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7906 (ascii_face_of_lisp_face): Remove; unused.
7907
7908 * xdisp.c: Make symbols static if they're not exported.
7909 * dispextern.h (scratch_glyph_row, window_box_edges):
7910 (glyph_to_pixel_coords, set_cursor_from_row):
7911 (get_next_display_element, set_iterator_to_next):
7912 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7913 (show_mouse_face): Remove decls
7914 * frame.h (message_buf_print): Likewise.
7915 * lisp.h (pop_message, set_message, check_point_in_composition):
7916 Likewise.
7917 * xterm.h (set_vertical_scroll_bar): Likewise.
7918 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7919 (message_buf_print, scratch_glyph_row, displayed_buffer):
7920 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7921 (get_next_display_element, show_mouse_face, window_box_edges):
7922 (frame_to_window_pixel_xy, check_point_in_composition):
7923 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7924 (glyph_to_pixel_coords): Remove; unused.
7925
7926 * dired.c (file_name_completion): Now static.
7927
7928 * dbusbind.c (xd_in_read_queued_messages): Now static.
7929
7930 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7931 * data.c (circular_list_error): Remove.
7932
7933 * commands.h (last_point_position, last_point_position_buffer):
7934 (last_point_position_window): Remove decls.
7935 * keyboard.c: Make these variables static.
7936
7937 * coding.h (coding, code_convert_region, encode_coding_gap):
7938 Remove decls.
7939 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7940 (iso_code_class, detect_coding, code_convert_region): Now static.
7941 (encode_coding_gap): Remove; unused.
7942
7943 * chartab.c (chartab_chars, chartab_bits): Now static.
7944
7945 * charset.h (charset_iso_8859_1): Remove decl.
7946 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7947 Now static.
7948
7949 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7950 * ccl.c (Vccl_program_table): Now static.
7951 (check_ccl_update): Remove; unused.
7952
7953 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7954 * category.h: ... from here.
7955 * category.c (check_category_table, set_category_set): Now static.
7956
7957 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7958 * lisp.h: Remove these decls.
7959
7960 * buffer.c (buffer_count): Remove unused var.
7961
7962 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7963 so that it's not optimized away.
7964 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7965 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7966 exported only to the debugger.
7967
7968 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7969 * atimer.h (run_all_atimers): Remove; not exported.
7970
7971 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7972 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7973 was inaccessible from Lisp.
7974 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7975 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7976
7977 alloc.c: Import and export fewer symbols, and remove unused items.
7978 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7979 is defined.
7980 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7981 it's not optimized away by whole-program optimization.
7982 (message_enable_multibyte, free_misc): Remove.
7983 (catchlist, handlerlist, mark_backtrace):
7984 Declare only if BYTE_MARK_STACK.
7985 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7986 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7987 (message_enable_multibyte): Remove decl.
7988 (free_misc, interval_free_list, float_block, float_block_index):
7989 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7990 (cons_free_list, last_marked_index):
7991 Now static.
7992 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7993 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7994 (mark_backtrace): Define only if BYTE_MARK_STACK.
7995 * xdisp.c (message_enable_multibyte): Now static.
7996
7997 Declare Lisp_Object Q* variables to be 'static' if not exported.
7998 This makes it easier for human readers (and static analyzers)
7999 to see whether these variables are used from other modules.
8000 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8001 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8002 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8003 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8004 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8005 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8006 * xmenu.c, xselect.c:
8007 Declare Q* vars static if they are not used in other modules.
8008 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8009 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8010 Remove decls of unexported vars.
8011 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8012
8013 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8014
8015 Make Emacs functions such as Fatom 'static' by default.
8016 This makes it easier for human readers (and static analyzers)
8017 to see whether these functions can be called from other modules.
8018 DEFUN now defines a static function. To make the function external
8019 so that it can be used in other C modules, use the new macro DEFUE.
8020 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8021 (Finit_image_library):
8022 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8023 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8024 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8025 Remove decls, since these functions are now static.
8026 (Funintern, Fget_internal_run_time): New decls, since these functions
8027 were already external.
8028
8029 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8030 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8031 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8032 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8033 * keyboard.c, keymap.c, lread.c:
8034 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8035 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8036 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8037 Mark functions with DEFUE instead of DEFUN,
8038 if they are used in other modules.
8039 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8040 decls for now-static functions.
8041 * buffer.h (Fdelete_overlay): Remove decl.
8042 * callproc.c (Fgetenv_internal): Mark as internal.
8043 * composite.c (Fremove_list_of_text_properties): Remove decl.
8044 (Fcomposition_get_gstring): New forward static decl.
8045 * composite.h (Fcomposite_get_gstring): Remove decl.
8046 * dired.c (Ffile_attributes): New forward static decl.
8047 * doc.c (Fdocumntation_property): New forward static decl.
8048 * eval.c (Ffetch_bytecode): New forward static decl.
8049 (Funintern): Remove extern decl; now in .h file where it belongs.
8050 * fileio.c (Fmake_symbolic_link): New forward static decl.
8051 * image.c (Finit_image_library): New forward static decl.
8052 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8053 * intervals.h (Fprevious_property_change):
8054 (Fremove_list_of_text_properties): Remove decls.
8055 * keyboard.c (Fthis_command_keys): Remove decl.
8056 (Fcommand_execute): New forward static decl.
8057 * keymap.c (Flookup_key): New forward static decl.
8058 (Fcopy_keymap): Now static.
8059 * keymap.h (Flookup_key): Remove decl.
8060 * process.c (Fget_process): New forward static decl.
8061 (Fprocess_datagram_address): Mark as internal.
8062 * syntax.c (Fsyntax_table_p): New forward static decl.
8063 (skip_chars): Remove duplicate decl.
8064 * textprop.c (Fprevious_property_change): New forward static decl.
8065 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8066 Now internal.
8067 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8068 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8069
8070 * editfns.c (Fformat): Remove unreachable code.
8071
8072 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8073
8074 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8075 change. (Bug#8496)
8076
8077 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8078
8079 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8080 when at ZV. (Bug#8487)
8081
8082 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8083
8084 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8085 (Bug#8437)
8086 * keyboard.c (parse_tool_bar_item): Likewise.
8087 * sound.c (sound_cleanup, alsa_close): Likewise.
8088 * termcap.c (tgetent): Likewise.
8089 * xfns.c (x_default_font_parameter): Likewise.
8090 * xsettings.c (read_and_apply_settings): Likewise.
8091
8092 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8093 (overrun_check_free): Protoize.
8094
8095 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8096
8097 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8098 since callers should never pass a negative size.
8099 Change the signature to match that of plain 'read' and 'write'; see
8100 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8101 * lisp.h: Update prototypes of emacs_write and emacs_read.
8102
8103 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8104
8105 * xdisp.c (redisplay_window): Don't try to determine the character
8106 position of the scroll margin if the window start point w->startp
8107 is outside the buffer's accessible region. (Bug#8468)
8108
8109 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8110
8111 Fix write-region and its subroutines for buffers > 2GB.
8112 * fileio.c (a_write, e_write): Modify declaration of arguments and
8113 local variables to support buffers larger than 2GB.
8114 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8115
8116 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8117 argument, local variables, and return value.
8118
8119 * lisp.h: Update prototypes of emacs_write and emacs_read.
8120
8121 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8122
8123 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8124
8125 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8126
8127 Fix more problems found by GCC 4.6.0's static checks.
8128
8129 * xdisp.c (vmessage): Use a better test for character truncation.
8130
8131 * charset.c (load_charset_map): <, not <=, for optimization,
8132 and to avoid potential problems with integer overflow.
8133 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8134 * casetab.c (set_identity, shuffle): Likewise.
8135 * editfns.c (Fformat): Likewise.
8136 * syntax.c (skip_chars): Likewise.
8137
8138 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8139 This also lets GCC 4.6.0 generate slightly better loop code.
8140
8141 * callint.c (Fcall_interactively): <, not <=, for optimization.
8142 (Fcall_interactively): Count the number of arguments produced,
8143 not the number of arguments given. This is simpler and lets GCC
8144 4.6.0 generate slightly better code.
8145
8146 * ftfont.c: Distingish more carefully between FcChar8 and char.
8147 The previous code passed unsigned char * to a functions like
8148 strlen and xstrcasecmp that expect char *, which does not
8149 conform to the C standard.
8150 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8151 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8152 char * when the C standard requires it.
8153
8154 * keyboard.c (read_char): Remove unused var.
8155
8156 * eval.c: Port to Windows vsnprintf (Bug#8435).
8157 Include <limits.h>.
8158 (SIZE_MAX): Define if the headers do not.
8159 (verror): Do not give up if vsnprintf returns a negative count.
8160 Instead, grow the buffer. This ports to Windows vsnprintf, which
8161 does not conform to C99. Problem reported by Eli Zaretskii.
8162 Also, simplify the allocation scheme, by avoiding the need for
8163 calling realloc, and removing the ALLOCATED variable.
8164
8165 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8166
8167 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8168 But keep the doprint source code for now, as we might revamp it
8169 and use it again (Bug#8435).
8170 * lisp.h (doprnt): Remove.
8171 * Makefile.in (base_obj): Remove doprnt.o.
8172 * deps.mk (doprnt.o): Remove.
8173
8174 error: Print 32- and 64-bit integers portably (Bug#8435).
8175 Without this change, on typical 64-bit hosts error ("...%d...", N)
8176 was used to print both 32- and 64-bit integers N, which relied on
8177 undefined behavior.
8178 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8179 * lisp.h (error, verror): Mark as printf-like functions.
8180 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8181 Report overflow in size calculations when allocating printf buffer.
8182 Do not truncate output string at its first null byte.
8183 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8184 Truncate the output at a character boundary, since vsnprintf does not
8185 do that.
8186 * charset.c (check_iso_charset_parameter): Convert internal
8187 character to string before calling 'error', since %c now has the
8188 printf meaning.
8189 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8190 overflow when computing char to be passed to 'error'. Do not
8191 pass Lisp_Object to 'error'; pass the integer instead.
8192 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8193 formatted with plain %d.
8194
8195 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8196
8197 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8198
8199 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8200
8201 * xterm.c (x_catch_errors): Remove duplicate declaration.
8202
8203 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8204
8205 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8206
8207 2011-04-10 Jim Meyering <meyering@redhat.com>
8208
8209 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8210 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8211 return ssize_t not "int", and use size_t as the buffer length.
8212 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8213 * gnutls.h: Update declarations.
8214 * process.c (read_process_output): Use ssize_t, to match.
8215 (send_process): Likewise.
8216
8217 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8218
8219 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8220
8221 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8222
8223 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8224 Use unsigned char, to match FcChar8 type definition.
8225
8226 * xterm.c (handle_one_xevent):
8227 * xmenu.c (create_and_show_popup_menu):
8228 * xselect.c (x_decline_selection_request)
8229 (x_reply_selection_request): Avoid type-punned deref of X events.
8230
8231 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8232
8233 Fix some uses of `int' instead of EMACS_INT.
8234 * search.c (string_match_1, fast_string_match)
8235 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8236 (scan_buffer, find_next_newline_no_quit)
8237 (find_before_next_newline, search_command, Freplace_match)
8238 (Fmatch_data): Make some `int' variables be EMACS_INT.
8239
8240 * xdisp.c (display_count_lines): 3rd argument and return value now
8241 EMACS_INT. All callers changed.
8242 (pint2hrstr): Last argument is now EMACS_INT.
8243
8244 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8245 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8246 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8247 (decode_coding_utf_16, decode_coding_emacs_mule)
8248 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8249 (decode_coding_ccl, decode_coding_charset)
8250 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8251 (decode_coding_iso_2022, decode_coding_emacs_mule)
8252 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8253 <char_offset, last_offset>: Declare EMACS_INT.
8254 (encode_coding_utf_8, encode_coding_utf_16)
8255 (encode_coding_emacs_mule, encode_invocation_designation)
8256 (encode_designation_at_bol, encode_coding_iso_2022)
8257 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8258 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8259 Declare EMACS_INT.
8260 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8261 (encode_invocation_designation): Last argument P_NCHARS is now
8262 EMACS_INT.
8263 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8264 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8265
8266 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8267 All users changed.
8268
8269 * ccl.c (Fccl_execute_on_string): Declare some variables
8270 EMACS_INT.
8271
8272 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8273
8274 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8275
8276 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8277
8278 * process.c (Fformat_network_address): Doc fix.
8279
8280 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8281
8282 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8283
8284 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8285
8286 * keyboard.c (read_char): Call Lisp function help-form-show,
8287 instead of using internal_with_output_to_temp_buffer.
8288 (Qhelp_form_show): New var.
8289 (syms_of_keyboard): Use DEFSYM macro.
8290
8291 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8292
8293 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8294
8295 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8296
8297 * process.c (Flist_processes): Remove to Lisp.
8298 (list_processes_1): Delete.
8299
8300 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8301
8302 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8303
8304 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8305
8306 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8307
8308 Fix more problems found by GCC 4.6.0's static checks.
8309
8310 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8311
8312 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8313
8314 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8315
8316 * xdisp.c (vmessage): Mark as a printf-like function.
8317
8318 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8319
8320 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8321
8322 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8323 printf-like functions.
8324 (tiff_load): Add casts to remove these marks before passing them
8325 to system-supplied API.
8326
8327 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8328
8329 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8330 This avoids several warnings with gcc -Wstrict-overflow.
8331 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8332 directly, rather than having caller test rule sign. This avoids
8333 some unnecessary tests.
8334 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8335 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8336 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8337
8338 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8339 (xfont_open): Avoid unnecessary tests.
8340
8341 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8342
8343 * composite.h, composite.c (composition_gstring_put_cache):
8344 Use EMACS_INT, not int, for length.
8345
8346 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8347 breaking out part of COMPOSITION_DECODE_RULE.
8348 (COMPOSITION_DECODE_RULE): Use it.
8349 * composite.c (get_composition_id): Remove unused local vars,
8350 by using the new macro.
8351
8352 * textprop.c (set_text_properties_1): Change while to do-while,
8353 since the condition is always true at first.
8354
8355 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8356 (interval_deletion_adjustment): Return unsigned value.
8357 All uses changed.
8358
8359 * process.c (list_processes_1, create_pty, read_process_output):
8360 (exec_sentinel): Remove vars that were set but not used.
8361 (create_pty): Remove unnecessary "volatile"s.
8362 (Fnetwork_interface_info): Avoid possibility of int overflow.
8363 (read_process_output): Do adaptive read buffering even if carryover.
8364 (read_process_output): Simplify nbytes computation if buffered.
8365
8366 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8367
8368 * syntax.c (scan_words): Remove var that was set but not used.
8369 (update_syntax_table): Use unsigned instead of int.
8370
8371 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8372 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8373 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8374
8375 * print.c (print_error_message): Avoid int overflow.
8376
8377 * font.c (font_list_entities): Redo for clarity,
8378 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8379
8380 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8381 (font_score): Avoid potential overflow in diff calculation.
8382
8383 * fns.c (substring_both): Remove var that is set but not used.
8384 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8385
8386 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8387
8388 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8389 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8390 can always succeed if overflow has undefined behavior.
8391
8392 * search.c (boyer_moore, wordify): Remove vars set but not used.
8393 (wordify): Omit three unnecessary tests.
8394
8395 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8396 All callers changed. This avoids the need for an unused var.
8397
8398 * casefiddle.c (casify_region): Remove var that is set but not used.
8399
8400 * dired.c (file_name_completion): Remove var that is set but not used.
8401
8402 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8403
8404 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8405 (Finsert_file_contents): Remove unnecessary code checking fd.
8406
8407 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8408 Check for integer overflow on size calculations.
8409
8410 * buffer.c (Fprevious_overlay_change): Remove var that is set
8411 but not used.
8412
8413 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8414 Remove vars that are set but not used.
8415 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8416 (timer_check_2): Mark vars as initialized.
8417
8418 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8419
8420 * image.c (lookup_image): Remove var that is set but not used.
8421 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8422
8423 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8424 that are set but not used.
8425
8426 * xfns.c (make_invisible_cursor): Don't return garbage
8427 if XCreateBitmapFromData fails (Bug#8410).
8428
8429 * xselect.c (x_get_local_selection, x_handle_property_notify):
8430 Remove vars that are set but not used.
8431
8432 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8433 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8434
8435 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8436 Remove var that is set but not used.
8437 (scroll_bar_windows_size): Now size_t, not int.
8438 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8439 Check for overflow.
8440
8441 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8442 (map_tty_color) [!defined MSDOS]: Likewise.
8443
8444 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8445
8446 * coding.c: Remove vars that are set but not used.
8447 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8448 All callers changed.
8449 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8450 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8451 (decode_coding_charset): Remove vars that are set but not used.
8452
8453 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8454 that is set but not used.
8455
8456 * print.c (print_object): Remove var that is set but not used.
8457
8458 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8459 The gnulib version avoids calling malloc in the usual case,
8460 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8461 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8462 * filelock.c (current_lock_owner): Likewise.
8463 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8464 * sysdep.c: Include allocator.h, careadlinkat.h.
8465 (emacs_no_realloc_allocator): New static constant.
8466 (emacs_readlink): New function.
8467 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8468 ../lib/careadlinkat.h.
8469
8470 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8471
8472 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8473 first non-nil return value).
8474
8475 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8476
8477 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8478 if not defined (Bug#8403).
8479
8480 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8481
8482 * xdisp.c (display_count_lines): Remove parameter `start',
8483 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8484 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8485 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8486 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8487 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8488 and thereabouts. All callers changed.
8489 (get_per_char_metric): Remove parameter `f', unused since
8490 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8491
8492 2011-04-02 Jim Meyering <meyering@redhat.com>
8493
8494 do not dereference NULL upon failed strdup
8495 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8496 (ns_get_family): Likewise.
8497
8498 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8499
8500 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8501
8502 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8503
8504 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8505 later (Bug#8403).
8506
8507 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8508
8509 Add lexical binding.
8510
8511 * window.c (Ftemp_output_buffer_show): New fun.
8512 (Fsave_window_excursion):
8513 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8514
8515 * lread.c (lisp_file_lexically_bound_p): New function.
8516 (Fload): Bind Qlexical_binding.
8517 (readevalloop): Remove `evalfun' arg.
8518 Bind Qinternal_interpreter_environment.
8519 (Feval_buffer): Bind Qlexical_binding.
8520 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8521 Mark as dynamic.
8522 (syms_of_lread): Declare `lexical-binding'.
8523
8524 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8525
8526 * keyboard.c (eval_dyn): New fun.
8527 (menu_item_eval_property): Use it.
8528
8529 * image.c (parse_image_spec): Use Ffunctionp.
8530
8531 * fns.c (concat, mapcar1): Accept byte-code-functions.
8532
8533 * eval.c (Fsetq): Handle lexical vars.
8534 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8535 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8536 (FletX, Flet): Obey lexical binding.
8537 (Fcommandp): Handle closures.
8538 (Feval): New `lexical' arg.
8539 (eval_sub): New function extracted from Feval. Use it almost
8540 everywhere where Feval was used. Look up vars in lexical env.
8541 Handle closures.
8542 (Ffunctionp): Move from subr.el.
8543 (Ffuncall): Handle closures.
8544 (apply_lambda): Remove `eval_flags'.
8545 (funcall_lambda): Handle closures and new byte-code-functions.
8546 (Fspecial_variable_p): New function.
8547 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8548 but without exporting it to Lisp.
8549
8550 * doc.c (Fdocumentation, store_function_docstring):
8551 * data.c (Finteractive_form): Handle closures.
8552
8553 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8554 interactive spec.
8555
8556 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8557 New byte-codes.
8558 (exec_byte_code): New function extracted from Fbyte_code to handle new
8559 calling convention for byte-code-functions. Add new byte-codes.
8560
8561 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8562
8563 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8564
8565 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8566
8567 * xdisp.c (redisplay_internal): Fix prototype.
8568
8569 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8570
8571 * xdisp.c (SCROLL_LIMIT): New macro.
8572 (try_scrolling): Use it when setting scroll_limit.
8573 Limit scrolling to 100 screen lines.
8574 (redisplay_window): Even when falling back on "recentering",
8575 position point in the window according to scroll-conservatively,
8576 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8577
8578 (try_scrolling): When point is above the window, allow searching
8579 as far as scroll_max, or one screenful, to compute vertical
8580 distance from PT to the scroll margin position. This prevents
8581 try_scrolling from unnecessarily failing when
8582 scroll-conservatively is set to a value slightly larger than the
8583 window height. Clean up the case of PT below the margin at bottom
8584 of window: scroll_max can no longer be INT_MAX. When aggressive
8585 scrolling is in use, don't let point enter the opposite scroll
8586 margin as result of the scroll.
8587 (syms_of_xdisp) <scroll-conservatively>: Document the
8588 threshold of 100 lines for never-recentering scrolling.
8589
8590 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8591
8592 * dispextern.h (move_it_by_lines):
8593 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8594 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8595 (message_log_check_duplicate): Remove parameters `prev_bol' and
8596 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8597 (redisplay_internal): Remove parameter `preserve_echo_area',
8598 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8599
8600 * indent.c (Fvertical_motion):
8601 * window.c (window_scroll_pixel_based, Frecenter):
8602 Don't pass `need_y_p' to `move_it_by_lines'.
8603
8604 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8605
8606 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8607 steal a few bits to be more compact.
8608 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8609 Remove unneeded casts.
8610
8611 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8612
8613 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8614
8615 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8616 binding" message (bug#7967).
8617
8618 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8619
8620 Fix more problems found by GCC 4.6.0's static checks.
8621
8622 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8623 Remove unused local var.
8624
8625 * editfns.c (Fmessage_box): Remove unused local var.
8626
8627 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8628 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8629 Omit unused local vars.
8630 * window.c (shrink_windows): Omit unused local var.
8631 * menu.c (digest_single_submenu): Omit unused local var.
8632 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8633 Omit unused local var.
8634
8635 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8636 Don't assume string length fits in int.
8637 (keyremap_step, read_key_sequence): Use size_t for sizes.
8638 (read_key_sequence): Don't check last_real_key_start redundantly.
8639
8640 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8641 instead of alloca (Bug#8344).
8642
8643 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8644 (Fbacktrace_frame): Don't assume nframes fits in int.
8645
8646 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8647
8648 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8649 concerns.
8650
8651 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8652
8653 * cm.c (calccost): Turn while-do into do-while, for clarity.
8654
8655 * keyboard.c (syms_of_keyboard): Use the same style as later
8656 in this function when indexing through an array. This also
8657 works around GCC bug 48267.
8658
8659 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8660
8661 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8662
8663 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8664 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8665
8666 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8667 This avoids undefined behavior on integer overflow, and is a bit
8668 more convenient anyway since it is compared to a size_t variable.
8669
8670 Variadic C functions now count arguments with size_t, not int.
8671 This avoids an unnecessary limitation on 64-bit machines, which
8672 caused (substring ...) to crash on large vectors (Bug#8344).
8673 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8674 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8675 All variadic functions and their callers changed accordingly.
8676 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8677 * data.c (arith_driver, float_arith_driver): Likewise.
8678 * editfns.c (general_insert_function): Likewise.
8679 * eval.c (struct backtrace.nargs, interactive_p)
8680 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8681 (funcall_lambda, mark_backtrace): Likewise.
8682 * fns.c (concat): Likewise.
8683 * frame.c (x_set_frame_parameters): Likewise.
8684 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8685 0 if not found, not -1. All callers changed.
8686
8687 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8688 (stack_copy_size): Now size_t, not int.
8689 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8690
8691 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8692
8693 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8694 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8695 All callers changed.
8696
8697 * lisp.h (multibyte_char_to_unibyte):
8698 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8699 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8700 * character.h (CHAR_TO_BYTE8):
8701 * cmds.c (internal_self_insert):
8702 * editfns.c (general_insert_function):
8703 * keymap.c (push_key_description):
8704 * search.c (Freplace_match):
8705 * xdisp.c (message_dolog, set_message_1): All callers changed.
8706
8707 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8708
8709 * keyboard.c (safe_run_hook_funcall): New function.
8710 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8711 don't set the hook to nil, but remove the offending function instead.
8712 (Qcommand_hook_internal): Remove, unused.
8713 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8714 Vcommand_hook_internal.
8715
8716 * eval.c (enum run_hooks_condition): Remove.
8717 (funcall_nil, funcall_not): New functions.
8718 (run_hook_with_args): Call each function through a `funcall' argument.
8719 Remove `cond' argument, now redundant.
8720 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8721 (Frun_hook_with_args_until_failure): Adjust accordingly.
8722 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8723
8724 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8725
8726 * dispextern.h (string_buffer_position): Remove declaration.
8727
8728 * print.c (strout): Remove parameter `multibyte', unused since
8729 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8730
8731 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8732 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8733 All callers changed.
8734
8735 * w32.c (_wsa_errlist): Use braces for struct initializers.
8736
8737 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8738 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8739 All callers changed.
8740 (string_buffer_position): Likewise. Also, make static (it's never
8741 used outside xdisp.c).
8742 (cursor_row_p): Remove parameter `w', unused since
8743 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8744 (decode_mode_spec): Remove parameter `precision', introduced during
8745 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8746 All callers changed.
8747
8748 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8749
8750 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8751
8752 2011-03-27 Anders Lindgren <andlind@gmail.com>
8753
8754 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8755 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8756 (ns_update_auto_hide_menu_bar): New functions.
8757 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8758 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8759 ns_constrain_all_frames.
8760 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8761 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8762
8763 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8764
8765 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8766
8767 2011-03-27 Glenn Morris <rgm@gnu.org>
8768
8769 * syssignal.h: Replace RETSIGTYPE with void.
8770 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8771 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8772 Replace SIGTYPE with void everywhere.
8773 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8774 * s/template.h (SIGTYPE): Remove commented out definition.
8775
8776 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8777
8778 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8779 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8780
8781 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8782
8783 * w32.c (read_unc_volume): Use parameter `henum', instead of
8784 global variable `wget_enum_handle'.
8785
8786 * keymap.c (describe_vector): Remove parameters `indices' and
8787 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8788 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8789
8790 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8791
8792 * keyboard.c (timer_check): Remove parameter `do_it_now',
8793 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8794 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8795 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8796
8797 * keyboard.c (read_char):
8798 * w32menu.c (w32_menu_display_help):
8799 * xmenu.c (show_help_event, menu_help_callback):
8800 Adjust calls to `show_help_echo'.
8801
8802 * gtkutil.c (xg_maybe_add_timer):
8803 * keyboard.c (readable_events):
8804 * process.c (wait_reading_process_output):
8805 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8806
8807 * insdel.c (adjust_markers_gap_motion):
8808 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8809 (gap_left, gap_right): Don't call it.
8810
8811 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8812
8813 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8814 incurred during fontification.
8815
8816 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8817
8818 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8819 (DEFVAR_PER_BUFFER): Don't pass it.
8820
8821 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8822 (scrolling_window): Don't pass it.
8823
8824 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8825
8826 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8827
8828 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8829 and `suffix'.
8830 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8831 of variables specific to SELinux and computation of `encoded_absname'.
8832
8833 * image.c (XPutPixel): Remove unused variable `height'.
8834
8835 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8836
8837 * unexw32.c (get_section_info): Remove unused variable `section'.
8838
8839 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8840 (system_process_attributes): Remove unused variable `sess'.
8841 (sys_read): Remove unused variable `err'.
8842
8843 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8844 (w32_wnd_proc): Remove unused variable `isdead'.
8845 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8846 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8847 (x_create_tip_frame): Remove unused variable `tem'.
8848
8849 * w32inevt.c (w32_console_read_socket):
8850 Remove unused variable `no_events'.
8851
8852 * w32term.c (x_draw_composite_glyph_string_foreground):
8853 Remove unused variable `width'.
8854
8855 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8856
8857 * w32term.c (x_set_glyph_string_clipping):
8858 Don't pass uninitialized region to CombineRgn.
8859
8860 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8861
8862 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8863 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8864 (Fx_close_connection): Remove unused variable `i'.
8865
8866 * w32font.c (w32font_draw): Return number of glyphs.
8867 (w32font_open_internal): Remove unused variable `i'.
8868 (w32font_driver): Add missing initializer.
8869
8870 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8871 (fill_in_menu): Remove unused variable `items_added'.
8872
8873 * w32term.c (last_mouse_press_frame): Remove static global variable.
8874 (w32_clip_to_row): Remove unused variable `f'.
8875 (x_delete_terminal): Remove unused variable `i'.
8876
8877 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8878 (NOTHING): Remove unused static global variable.
8879 (uniscribe_check_otf): Remove unused variable `table'.
8880 (uniscribe_font_driver): Add missing initializers.
8881
8882 2011-03-23 Julien Danjou <julien@danjou.info>
8883
8884 * term.c (Fsuspend_tty, Fresume_tty):
8885 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8886 * window.c (temp_output_buffer_show):
8887 * insdel.c (signal_before_change):
8888 * frame.c (Fhandle_switch_frame):
8889 * fileio.c (Fdo_auto_save):
8890 * emacs.c (Fkill_emacs):
8891 * editfns.c (save_excursion_restore):
8892 * cmds.c (internal_self_insert):
8893 * callint.c (Fcall_interactively):
8894 * buffer.c (Fkill_all_local_variables):
8895 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8896 Use Frun_hooks.
8897 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8898 unconditionally since it does the check itself.
8899
8900 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8901
8902 Fix more problems found by GCC 4.5.2's static checks.
8903
8904 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8905 the first time through the loop, since we know p0 < p1 then.
8906 This also avoids a gcc -Wstrict-overflow warning.
8907
8908 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8909 leading to a memory leak, possible in functions like
8910 load_charset_map_from_file that can allocate an unbounded number
8911 of objects (Bug#8318).
8912
8913 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8914 that could (at least in theory) be that large.
8915
8916 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8917 This is less likely to overflow, and avoids undefined behavior if
8918 overflow does occur. All callers changed. Use strtoul to scan
8919 for the unsigned long integer.
8920 (pint2hrstr): Simplify and tune code slightly.
8921 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8922
8923 * scroll.c (do_scrolling): Work around GCC bug 48228.
8924 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8925
8926 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8927 This also avoids a warning with gcc -Wstrict-overflow.
8928 (validate_x_resource_name): Simplify count usage.
8929 This also avoids a warning with gcc -Wstrict-overflow.
8930
8931 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8932 fail (Bug#8306).
8933
8934 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8935
8936 * process.c (Fmake_network_process): Use socklen_t, not int,
8937 where POSIX says socklen_t is required in portable programs.
8938 This fixes a porting bug on hosts like 64-bit HP-UX, where
8939 socklen_t is wider than int (Bug#8277).
8940 (Fmake_network_process, server_accept_connection):
8941 (wait_reading_process_output, read_process_output):
8942 Likewise.
8943
8944 * process.c: Rename or move locals to avoid shadowing.
8945 (list_processes_1, Fmake_network_process):
8946 (read_process_output_error_handler, exec_sentinel_error_handler):
8947 Rename or move locals.
8948 (Fmake_network_process): Define label "retry_connect" only if needed.
8949 (Fnetwork_interface_info): Fix pointer signedness.
8950 (process_send_signal): Add cast to avoid pointer signedness problem.
8951 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8952 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8953
8954 Make tparam.h and terminfo.c consistent.
8955 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8956 Include tparam.h instead, since it declares them.
8957 * cm.h (PC): Remove extern decl; tparam.h now does this.
8958 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8959 * terminfo.c: Include tparam.h, to check interfaces.
8960 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8961 (tparam): Adjust signature to match interface in tparam.h;
8962 this removes some undefined behavior. Check that outstring and len
8963 are zero, which they always are with Emacs.
8964 * tparam.h (PC, BC, UP): New extern decls.
8965
8966 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8967 (xftfont_open): Rename locals to avoid shadowing.
8968
8969 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8970 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8971 (OTF_TAG_SYM): Omit macro if not needed.
8972 (ftfont_list): Remove unused local.
8973 (get_adstyle_property, ftfont_pattern_entity):
8974 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8975 Rename locals to avoid shadowing.
8976
8977 * xfont.c (xfont_list_family): Mark var as initialized.
8978
8979 * xml.c (make_dom): Now static.
8980
8981 * composite.c (composition_compute_stop_pos): Rename local to
8982 avoid shadowing.
8983 (composition_reseat_it): Remove unused locals.
8984 (find_automatic_composition, composition_adjust_point): Likewise.
8985 (composition_update_it): Mark var as initialized.
8986 (find_automatic_composition): Mark vars as initialized,
8987 with a FIXME (Bug#8290).
8988
8989 character.h: Rename locals to avoid shadowing.
8990 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8991 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8992 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8993 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8994 to avoid shadowing.
8995
8996 * textprop.c (property_change_between_p): Remove; unused.
8997
8998 * intervals.c (interval_start_pos): Now static.
8999
9000 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9001
9002 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9003 Rename locals to avoid shadowing.
9004
9005 * sound.c (wav_play, au_play, Fplay_sound_internal):
9006 Fix pointer signedness.
9007 (alsa_choose_format): Remove unused local var.
9008 (wav_play): Initialize a variable to 0, to prevent undefined
9009 behavior (Bug#8278).
9010
9011 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9012
9013 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9014
9015 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9016 clobbering (Bug#8298).
9017 * sysdep.c (sys_subshell): Likewise.
9018 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9019
9020 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9021 This should get cleaned up, so that child_setup has the
9022 same signature on all platforms.
9023
9024 * callproc.c (call_process_cleanup): Now static.
9025 (relocate_fd): Rename locals to avoid shadowing.
9026
9027 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9028
9029 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9030 not to be necessary, and produces flickering.
9031
9032 2011-03-20 Glenn Morris <rgm@gnu.org>
9033
9034 * config.in: Remove file.
9035
9036 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9037
9038 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9039 are now in src/globals.h.
9040 (syms_of_minibuf): Remove spurious & from previous change.
9041
9042 2011-03-20 Leo Liu <sdl.web@gmail.com>
9043
9044 * minibuf.c (completing-read-function): New variable.
9045 (completing-read-default): Rename from completing-read.
9046 (completing-read): Call completing-read-function.
9047
9048 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9049
9050 * xfaces.c (Fx_load_color_file):
9051 Read color file from absolute filename (bug#8250).
9052
9053 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9054
9055 * makefile.w32-in: Update dependencies.
9056
9057 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9058
9059 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9060
9061 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9062
9063 Fix more problems found by GCC 4.5.2's static checks.
9064
9065 * process.c (make_serial_process_unwind, send_process_trap):
9066 (sigchld_handler): Now static.
9067
9068 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9069 That way, the code declares only the vars that it needs.
9070 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9071 * s/cygwin.h (PTY_ITERATION): Likewise.
9072 * s/darwin.h (PTY_ITERATION): Likewise.
9073 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9074
9075 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9076 * process.c (allocate_pty): Don't declare stb unless it's needed.
9077
9078 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9079 (CONSTANTLIM): Remove; unused.
9080 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9081 Define only if needed.
9082
9083 * unexelf.c (unexec): Name an expression,
9084 to avoid gcc -Wbad-function-cast warning.
9085 Use a different way to cause a compilation error if anyone uses
9086 n rather than nn, a way that does not involve shadowing.
9087 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9088
9089 * deps.mk (unexalpha.o): Remove; unused.
9090
9091 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9092 * unexec.h: New file.
9093 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9094 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9095 Depend on unexec.h.
9096 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9097 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9098 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9099 Change as necessary to match prototype in unexec.h.
9100
9101 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9102 shadowing.
9103 (back_comment, skip_chars): Mark vars as initialized.
9104
9105 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9106 Rename locals to avoid shadowing.
9107
9108 * lread.c (read1): Rewrite so as not to use empty "else".
9109 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9110
9111 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9112
9113 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9114 warning when compiling print.c.
9115
9116 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9117 instead of using an uninitialized var.
9118 (font_sort_entities): Mark var as initialized.
9119
9120 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9121
9122 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9123 pointers to constants.
9124 (font_parse_fcname): Remove unused vars.
9125 (font_delete_unmatched): Now static.
9126 (font_get_spec): Remove; unused.
9127 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9128 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9129 Rename or move locals to avoid shadowing.
9130
9131 * fns.c (require_nesting_list, require_unwind): Now static.
9132 (Ffillarray): Rename locals to avoid shadowing.
9133
9134 * floatfns.c (domain_error2): Define only if needed.
9135 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9136
9137 * alloc.c (mark_backtrace): Move decl from here ...
9138 * lisp.h: ... to here, so that it can be checked.
9139
9140 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9141 (Fdefvar): Rewrite so as not to use empty "else".
9142 (lisp_indirect_variable): Name an expression,
9143 to avoid gcc -Wbad-function-cast warning.
9144 (Fdefvar): Rename locals to avoid shadowing.
9145
9146 * callint.c (quotify_arg, quotify_args): Now static.
9147 (Fcall_interactively): Rename locals to avoid shadowing.
9148 Use const pointer when appropriate.
9149
9150 * lisp.h (get_system_name, get_operating_system_release):
9151 Move decls here, to check interfaces.
9152 * process.c (get_operating_system_release): Move decl to lisp.h.
9153 * xrdb.c (get_system_name): Likewise.
9154 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9155 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9156 some of which prompt warnings from gcc -Wbad-function-cast.
9157 (Fformat_time_string, Fencode_time, Finsert_char):
9158 (Ftranslate_region_internal, Fformat):
9159 Rename or remove local vars to avoid shadowing.
9160 (Ftranslate_region_internal): Mark var as initialized.
9161
9162 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9163 avoid shadowing.
9164
9165 * lisp.h (eassert): Check that the argument compiles, even if
9166 ENABLE_CHECKING is not defined.
9167
9168 * data.c (Findirect_variable): Name an expression, to avoid
9169 gcc -Wbad-function-cast warning.
9170 (default_value, arithcompare, arith_driver, arith_error): Now static.
9171 (store_symval_forwarding): Rename local to avoid shadowing.
9172 (Fmake_variable_buffer_local, Fmake_local_variable):
9173 Mark variables as initialized.
9174 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9175
9176 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9177 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9178 Rename locals to avoid shadowing.
9179 (mark_stack): Move local variables into the #ifdef region where
9180 they're used.
9181 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9182 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9183 needed otherwise.
9184 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9185 (GC_STRING_CHARS): Remove; not used.
9186 (Fmemory_limit): Cast sbrk's returned value to char *.
9187
9188 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9189 avoids undefined behavior in theory.
9190
9191 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9192
9193 Use functions, not macros, for up- and down-casing (Bug#8254).
9194 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9195 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9196 to use the following functions instead of these macros.
9197 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9198 EMACS_INT, since callers assume the returned value fits in int.
9199 (upcase1): Likewise, for UPCASE_TABLE.
9200 (uppercasep, lowercasep, upcase): New static inline functions.
9201 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9202 the race-condition problem in the old DOWNCASE.
9203
9204 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9205 Rename locals to avoid shadowing.
9206 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9207 (regex_compile, re_search_2, re_match_2_internal):
9208 Remove unused local vars.
9209 (FREE_VAR): Rewrite so as not to use empty "else",
9210 which gcc can warn about.
9211 (regex_compile, re_match_2_internal): Mark locals as initialized.
9212 (RETALLOC_IF): Define only if needed.
9213 (WORDCHAR_P): Likewise. This one is never needed, but is used
9214 only in a comment talking about a compiler bug, so put inside
9215 the #if 0 of that comment.
9216 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9217 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9218 Remove; unused.
9219
9220 * search.c (boyer_moore): Rename locals to avoid shadowing.
9221 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9222 (PREV_CHAR_BOUNDARY): Likewise.
9223
9224 * search.c (simple_search): Remove unused var.
9225
9226 * dired.c (compile_pattern): Move decl from here ...
9227 * lisp.h: ... to here, so that it can be checked.
9228 (struct re_registers): New forward decl.
9229
9230 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9231
9232 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9233 All uses changed.
9234 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9235 Rename locals to avoid shadowing.
9236 (Fvertical_motion): Mark locals as initialized.
9237
9238 * casefiddle.c (casify_object, casify_region): Now static.
9239 (casify_region): Mark local as initialized.
9240
9241 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9242
9243 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9244 New macros, so that the caller can use some names other than
9245 gcpro1, gcpro2, etc.
9246 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9247 of the new macros.
9248 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9249 argument, for consistency with GCPRO2_VAR, etc: it is now the
9250 prefix of the variable, not the variable itself. All uses
9251 changed.
9252 * dired.c (directory_files_internal, file_name_completion):
9253 Rename locals to avoid shadowing.
9254
9255 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9256 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9257 dired.c's scmp function, had undefined behavior.
9258 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9259 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9260 * buffer.h: ... to here, because these macros use current_buffer,
9261 and the new implementation with inline functions needs to have
9262 current_buffer in scope now, rather than later when the macros
9263 are used.
9264 (downcase, upcase1): New static inline functions.
9265 (DOWNCASE, UPCASE1): Reimplement using these functions.
9266 This avoids undefined behavior in expressions like
9267 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9268 from race conditions in accessing the global variables
9269 case_temp1 and case_temp2.
9270 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9271 * lisp.h (case_temp1, case_temp2): Remove their decls.
9272 * character.h (ASCII_CHAR_P): Move from here ...
9273 * lisp.h: ... to here, so that the inline functions mentioned
9274 above can use them.
9275
9276 * dired.c (directory_files_internal_unwind): Now static.
9277
9278 * fileio.c (file_name_as_directory, directory_file_name):
9279 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9280 Now static.
9281 (file_name_as_directory): Use const pointers when appropriate.
9282 (Fexpand_file_name): Likewise. In particular, newdir might
9283 point at constant storage, so make it a const pointer.
9284 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9285 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9286 signedness issues.
9287 (Fset_file_times, Finsert_file_contents, auto_save_error):
9288 Rename locals to avoid shadowing.
9289
9290 * minibuf.c (choose_minibuf_frame_1): Now static.
9291 (Ftry_completion, Fall_completions): Rename or remove locals
9292 to avoid shadowing.
9293
9294 * marker.c (bytepos_to_charpos): Remove; unused.
9295
9296 * lisp.h (verify_bytepos, count_markers): New decls,
9297 so that gcc does not warn that these functions aren't declared.
9298
9299 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9300 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9301 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9302 (copy_text): Remove unused local var.
9303
9304 * filelock.c (within_one_second): Now static.
9305 (lock_file_1): Rename local to avoid shadowing.
9306
9307 * buffer.c (fix_overlays_before): Mark locals as initialized.
9308 (fix_start_end_in_overlays): Likewise. This function should be
9309 simplified by using pointers-to-pointers, but that's a different
9310 matter.
9311 (switch_to_buffer_1): Now static.
9312 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9313 (report_overlay_modification): Rename locals to avoid shadowing.
9314
9315 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9316 Fix pointer signedness issue.
9317 (sys_subshell): Mark local as volatile if checking for lint,
9318 to suppress a gcc -Wclobbered warning that does not seem to be right.
9319 (MAXPATHLEN): Define only if needed.
9320
9321 * process.c (serial_open, serial_configure): Move decls from here ...
9322 * systty.h: ... to here, so that they can be checked.
9323
9324 * fns.c (get_random, seed_random): Move extern decls from here ...
9325 * lisp.h: ... to here, so that they can be checked.
9326
9327 * sysdep.c (reset_io): Now static.
9328 (wait_for_termination_signal): Remove; unused.
9329
9330 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9331 (copy_keymap_item, append_key, push_text_char_description):
9332 Now static.
9333 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9334 (DENSE_TABLE_SIZE): Remove; unused.
9335 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9336 (describe_map_tree):
9337 Rename locals to avoid shadowing.
9338
9339 * keyboard.c: Declare functions static if they are not used elsewhere.
9340 (echo_char, echo_dash, cmd_error, top_level_2):
9341 (poll_for_input, handle_async_input): Now static.
9342 (read_char, kbd_buffer_get_event, make_lispy_position):
9343 (make_lispy_event, make_lispy_movement, apply_modifiers):
9344 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9345 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9346 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9347 (read_key_sequence, read_char): Mark locals as initialized.
9348 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9349
9350 * keyboard.h (make_ctrl_char): New decl.
9351 (mark_kboards): Move decl here ...
9352 * alloc.c (mark_kboards): ... from here.
9353
9354 * lisp.h (force_auto_save_soon): New decl.
9355
9356 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9357 (DEFINE_DUMMY_FUNCTION): New macro.
9358 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9359 Use it.
9360 (main): Add casts to avoid warnings
9361 if GCC considers string literals to be constants.
9362
9363 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9364
9365 * dbusbind.c: Pointer signedness fixes.
9366 (xd_signature, xd_append_arg, xd_initialize):
9367 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9368 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9369 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9370 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9371
9372 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9373 if GCC considers string literals to be constants.
9374 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9375
9376 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9377
9378 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9379 (print_preprocess, print_object): New macro to fix last change.
9380
9381 * print.c (print_preprocess): Don't forget font objects.
9382
9383 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9384
9385 * emacs.c (USAGE3): Doc fixes.
9386
9387 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9388
9389 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9390 structure.
9391
9392 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9393
9394 * lisp.h (VWindow_system, Qfile_name_history):
9395 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9396 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9397 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9398
9399 * w32select.c: Don't #include "keyboard.h".
9400 (run_protected): Add extern declaration for waiting_for_input.
9401
9402 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9403 * w32console.c (detect_input_pending, read_input_pending)
9404 (encode_terminal_code):
9405 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9406 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9407 (w32_system_caret_y, Qfile_name_history):
9408 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9409 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9410 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9411 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9412 * w32proc.c (Qlocal, report_file_error):
9413 * w32term.c (Vwindow_system, updating_frame):
9414 * w32uniscribe.c (initialized, uniscribe_font_driver):
9415 Remove unneeded extern declarations.
9416
9417 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9418
9419 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9420
9421 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9422
9423 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9424 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9425 These macros can no longer be used for assignment.
9426
9427 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9428 Assign struct members directly, instead of using BUF_BEGV etc.
9429 (record_buffer_markers, fetch_buffer_markers): New functions for
9430 recording and fetching special buffer markers.
9431 (set_buffer_internal_1, set_buffer_temp): Use them.
9432
9433 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9434
9435 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9436
9437 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9438 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9439
9440 * xdisp.c (hscroll_window_tree):
9441 (reconsider_clip_changes): Use PT instead of BUF_PT.
9442
9443 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9444
9445 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9446 $(EMACS_ROOT)/lib/intprops.h.
9447
9448 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9449
9450 Fix more problems found by GCC 4.5.2's static checks.
9451
9452 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9453 to unsigned char * to avoid compiler diagnostic.
9454 (xg_free_frame_widgets): Make it clear that a local variable is
9455 needed only if USE_GTK_TOOLTIP.
9456 (gdk_window_get_screen): Make it clear that this macro is needed
9457 only if USE_GTK_TOOLTIP.
9458 (int_gtk_range_get_value): New function, which avoids a diagnostic
9459 from gcc -Wbad-function-cast.
9460 (xg_set_toolkit_scroll_bar_thumb): Use it.
9461 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9462 diagnostic from gcc -Wbad-function-cast.
9463 (get_utf8_string, xg_get_file_with_chooser):
9464 Rename locals to avoid shadowing.
9465 (create_dialog): Move locals to avoid shadowing.
9466
9467 * xgselect.c (xg_select): Remove unused var.
9468
9469 * image.c (four_corners_best): Mark locals as initialized.
9470 (gif_load): Initialize transparent_p to zero (Bug#8238).
9471 Mark another local as initialized.
9472 (my_png_error, my_error_exit): Mark with NO_RETURN.
9473
9474 * image.c (clear_image_cache): Now static.
9475 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9476 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9477 (x_edge_detection): Remove unnecessary cast that
9478 gcc -Wbad-function-cast diagnoses.
9479 (gif_load): Fix pointer signedness.
9480 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9481 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9482
9483 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9484
9485 Improve quality of tests for time stamp overflow.
9486 For example, without this patch (encode-time 0 0 0 1 1
9487 1152921504606846976) returns the obviously-bogus value (-948597
9488 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9489 reports time overflow. See
9490 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9491 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9492 * editfns.c: Include limits.h and intprops.h.
9493 (TIME_T_MIN, TIME_T_MAX): New macros.
9494 (time_overflow): Move earlier, to before first use.
9495 (hi_time, lo_time): New functions, for an accurate test for
9496 out-of-range times.
9497 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9498 (Fget_internal_run_time): Don't assume time_t fits in int.
9499 (make_time): Use list2 instead of Fcons twice.
9500 (Fdecode_time): More accurate test for out-of-range times.
9501 (check_tm_member): New function.
9502 (Fencode_time): Use it, to test for out-of-range times.
9503 (lisp_time_argument): Don't rely on undefined left-shift and
9504 right-shift behavior when checking for time stamp overflow.
9505
9506 * editfns.c (time_overflow): New function, refactoring common code.
9507 (Fformat_time_string, Fdecode_time, Fencode_time):
9508 (Fcurrent_time_string): Use it.
9509
9510 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9511 * dired.c (make_time): Move to ...
9512 * editfns.c (make_time): ... here.
9513 * systime.h: Note the move.
9514
9515 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9516
9517 * fringe.c (update_window_fringes): Remove unused variables.
9518
9519 * unexmacosx.c (copy_data_segment): Also copy __got section.
9520 (Bug#8223)
9521
9522 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9523
9524 * termcap.c [MSDOS]: Include "msdos.h".
9525 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9526 Constify `char *' arguments and their references according to
9527 prototypes in tparam.h.
9528
9529 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9530
9531 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9532 Adapt all references accordingly.
9533
9534 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9535
9536 2011-03-11 Tom Tromey <tromey@redhat.com>
9537
9538 * buffer.c (syms_of_buffer): Remove obsolete comment.
9539
9540 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9541
9542 * termhooks.h (encode_terminal_code): Declare prototype.
9543
9544 * msdos.c (encode_terminal_code): Don't declare prototype.
9545
9546 * term.c (encode_terminal_code): Now external again, used by
9547 w32console.c and msdos.c.
9548
9549 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9550 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9551
9552 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9553
9554 Fix some minor problems found by GCC 4.5.2's static checks.
9555
9556 * fringe.c (update_window_fringes): Mark locals as initialized
9557 (Bug#8227).
9558 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9559
9560 * alloc.c (mark_fringe_data): Move decl from here ...
9561 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9562 to check its interface.
9563 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9564
9565 * fontset.c (free_realized_fontset): Now static.
9566 (Fset_fontset_font): Rename local to avoid shadowing.
9567 (fontset_font): Mark local as initialized.
9568 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9569
9570 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9571
9572 * xselect.c (x_disown_buffer_selections): Remove; not used.
9573 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9574 (x_own_selection, Fx_disown_selection_internal): Rename locals
9575 to avoid shadowing.
9576 (x_handle_dnd_message): Remove local to avoid shadowing.
9577
9578 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9579 so that the caller can use some name other than gcpro1.
9580 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9581 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9582 (Fx_backspace_delete_keys_p):
9583 Use them to avoid shadowing, and rename vars to avoid shadowing.
9584 (x_decode_color, x_set_name, x_window): Now static.
9585 (Fx_create_frame): Add braces to silence GCC warning.
9586 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9587 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9588 Remove unused locals.
9589 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9590 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9591 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9592 macros.
9593
9594 * xterm.h (x_mouse_leave): New decl.
9595
9596 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9597 Remove unused functions.
9598 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9599 (x_calc_absolute_position): Now static.
9600 (XTread_socket): Don't define label "out" unless it's used.
9601 Don't declare local "event" unless it's used.
9602 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9603 unless they are used.
9604 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9605 (x_fatal_error_signal): Remove; not used.
9606 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9607 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9608 (x_error_catcher, x_connection_closed, x_error_handler):
9609 (x_error_quitter, xembed_send_message, x_iconify_frame):
9610 (my_log_handler): Rename locals to avoid shadowing.
9611 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9612 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9613
9614 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9615 Rename or move locals to avoid shadowing.
9616 (tty_defined_color, merge_face_heights): Now static.
9617 (free_realized_faces_for_fontset): Remove; not used.
9618 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9619 does not deduce is never used uninitialized.
9620 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9621 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9622
9623 * terminal.c (store_terminal_param): Now static.
9624
9625 * xmenu.c (menu_highlight_callback): Now static.
9626 (set_frame_menubar): Remove unused local.
9627 (xmenu_show): Rename parameter to avoid shadowing.
9628 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9629 since they might point to immutable storage.
9630 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9631 since it's unused otherwise.
9632
9633 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9634 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9635 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9636 avoids a gcc -Wuninitialized diagnostic.
9637 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9638 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9639 does not deduce are never used uninitialized.
9640
9641 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9642
9643 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9644 * window.c (window_loop, size_window):
9645 (run_window_configuration_change_hook, enlarge_window): Likewise.
9646
9647 * window.c (display_buffer): Now static.
9648 (size_window): Mark variables that gcc -Wuninitialized
9649 does not deduce are never used uninitialized.
9650 * window.h (check_all_windows): New decl, to forestall
9651 gcc -Wmissing-prototypes diagnostic.
9652 * dispextern.h (bidi_dump_cached_states): Likewise.
9653
9654 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9655 shadowing.
9656 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9657 Include <limits.h>.
9658 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9659 and to avoid gcc -Wuninitialized warning.
9660 (load_charset_map): Mark variables that gcc -Wuninitialized
9661 does not deduce are never used uninitialized.
9662 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9663
9664 * coding.c (coding_set_source, coding_set_destination):
9665 Use "else { /* comment */ }" rather than "else /* comment */;"
9666 for clarity, and to avoid gcc -Wempty-body warning.
9667 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9668 a block, when the outer 'i' will do.
9669 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9670 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9671 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9672 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9673 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9674 Rename locals to avoid shadowing.
9675 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9676 * coding.c (emacs_mule_char, encode_invocation_designation):
9677 Now static, since they're not used elsewhere.
9678 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9679 (decode_coding_object, encode_coding_object, detect_coding_system):
9680 (decode_coding_emacs_mule): Mark variables that gcc
9681 -Wuninitialized does not deduce are never used uninitialized.
9682 (detect_coding_iso_2022): Initialize a local variable that might
9683 be used uninitialized. Leave a FIXME because it's not clear that
9684 this initialization is needed. (Bug#8211)
9685 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9686 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9687 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9688 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9689 Remove unused macros.
9690
9691 * category.c (hash_get_category_set): Remove unused local var.
9692 (copy_category_table): Now static, since it's not used elsewhere.
9693 * character.c (string_count_byte8): Likewise.
9694
9695 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9696 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9697
9698 * chartab.c (copy_sub_char_table): Now static, since it's not used
9699 elsewhere.
9700 (sub_char_table_ref_and_range, char_table_ref_and_range):
9701 Rename locals to avoid shadowing.
9702 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9703
9704 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9705 (BIDI_BOB): Remove unused macro.
9706
9707 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9708 deduce are never used uninitialized.
9709 * term.c (encode_terminal_code): Likewise.
9710
9711 * term.c (encode_terminal_code): Now static. Remove unused local.
9712
9713 * tparam.h: New file.
9714 * term.c, tparam.h: Include it.
9715 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9716 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9717 Move these decls to tparam.h, and make them agree with what
9718 is actually in tparam.c. The previous trick of using incompatible
9719 decls in different modules does not conform to the C standard.
9720 All callers of tparam changed to use tparam's actual API.
9721 * tparam.c (tparam1, tparam, tgoto):
9722 Use const pointers where appropriate.
9723
9724 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9725 * cm.h (struct cm): Likewise.
9726 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9727 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9728 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9729 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9730 (turn_on_face, init_tty): Likewise.
9731 * termchar.h (struct tty_display_info): Likewise.
9732
9733 * term.c (term_mouse_position): Rename local to avoid shadowing.
9734
9735 * alloc.c (mark_ttys): Move decl from here ...
9736 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9737
9738 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9739
9740 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9741
9742 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9743
9744 * search.c (compile_pattern_1): Remove argument regp, unused since
9745 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9746 (compile_pattern): Don't pass it.
9747
9748 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9749
9750 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9751 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9752 for ! HAVE_GTK3.
9753 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9754
9755 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9756
9757 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9758 gdk_window_get_screen, gdk_window_get_geometry,
9759 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9760 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9761 (xg_get_pixbuf_from_pixmap): New function.
9762 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9763 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9764 Call xg_get_pixbuf_from_pixmap instead of
9765 gdk_pixbuf_get_from_drawable.
9766 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9767 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9768 (xg_check_special_colors): Use GtkStyleContext and its functions
9769 for HAVE_GTK3.
9770 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9771 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9772 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9773 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9774 Call gtk_widget_get_preferred_size.
9775 (xg_frame_resized): gdk_window_get_geometry only takes 5
9776 parameters.
9777 (xg_win_to_widget, xg_event_is_for_menubar):
9778 Call gdk_x11_window_lookup_for_display.
9779 (xg_set_widget_bg): New function.
9780 (delete_cb): New function.
9781 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9782 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9783 (xg_set_background_color): Call xg_set_widget_bg.
9784 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9785 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9786 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9787 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9788 if ! HAVE_GTK3.
9789 (update_frame_tool_bar): Call gtk_widget_hide.
9790 (xg_initialize): Use GDK_KEY_g.
9791
9792 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9793 if ! HAVE_GTK3
9794 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9795
9796 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9797 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9798 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9799
9800 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9801
9802 * w32xfns.c (select_palette): Check success of RealizePalette against
9803 GDI_ERROR, not zero.
9804
9805 See ChangeLog.11 for earlier changes.
9806
9807 ;; Local Variables:
9808 ;; coding: utf-8
9809 ;; End:
9810
9811 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9812
9813 This file is part of GNU Emacs.
9814
9815 GNU Emacs is free software: you can redistribute it and/or modify
9816 it under the terms of the GNU General Public License as published by
9817 the Free Software Foundation, either version 3 of the License, or
9818 (at your option) any later version.
9819
9820 GNU Emacs is distributed in the hope that it will be useful,
9821 but WITHOUT ANY WARRANTY; without even the implied warranty of
9822 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9823 GNU General Public License for more details.
9824
9825 You should have received a copy of the GNU General Public License
9826 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.