Fix for raise display property on NS (Bug#8913).
[bpt/emacs.git] / src / ChangeLog
1 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2
3 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4 setting frame foreground color (Bug#9175).
5 (x_set_background_color): Likewise.
6
7 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8 contents (Bug#9176).
9 (EmacsTooltip -init): Remove bezels and add shadows to
10 tooltip windows.
11
12 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
13 or scroll bar (Bug#8470).
14
15 * nsfont.m (nsfont_open): Remove assignment to voffset and
16 unnecessary vars hshink, expand, hd, full_height, min_height.
17 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
18
19 * nsterm.h (nsfont_info): Remove voffset field.
20
21 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
22
23 Implement strike-through and overline on NextStep (Bug#8863).
24
25 * nsfont.m (nsfont_open): Use underline position provided by font,
26 instead of hard-coded value of 2.
27 (nsfont_draw): Call ns_draw_text_decoration instead.
28
29 * nsterm.h: Add declaration for ns_draw_text_decoration.
30
31 * nsterm.m (ns_draw_text_decoration): New function for drawing
32 underline, overline, and strike-through.
33 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
34 ns_draw_text_decoration. Change treatment of cursor drawing to
35 accomodate underlining, etc.
36
37 2011-07-28 Eli Zaretskii <eliz@gnu.org>
38
39 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
40 default.
41
42 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
43
44 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
45 Without this fix, if a signal arrives just after memory fills up,
46 'malloc' might be invoked reentrantly.
47
48 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
49 In other words, assume that every image size is allowed, on non-X
50 hosts. This assumption is probably wrong, but it lets Emacs compile.
51
52 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
53
54 * regex.c (re_iswctype): Convert return values to boolean.
55
56 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
57
58 * xdisp.c (compute_display_string_pos): Don't use cached display
59 string position if the buffer had its restriction changed.
60 (Bug#9184)
61
62 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
63
64 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
65
66 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
67
68 Integer signedness and overflow and related fixes. (Bug#9079)
69
70 * bidi.c: Integer size and overflow fixes.
71 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
72 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
73 (bidi_cache_find_level_change, bidi_cache_ensure_space)
74 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
75 (bidi_find_other_level_edge):
76 Use ptrdiff_t instead of EMACS_INT where either will do.
77 This works better on 32-bit hosts configured --with-wide-int.
78 (bidi_cache_ensure_space): Check for size-calculation overflow.
79 Use % rather than repeated addition, for better worst-case speed.
80 Don't set bidi_cache_size until after xrealloc returns, because it
81 might not return.
82 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
83 (bidi_cache_ensure_space): Also check that the bidi cache size
84 does not exceed that of the largest Lisp string or buffer. See Eli
85 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
86
87 * alloc.c (__malloc_size_t): Remove.
88 All uses replaced by size_t. See Andreas Schwab's note
89 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
90
91 * image.c: Improve checking for integer overflow.
92 (check_image_size): Assume that f is nonnull, since
93 it is always nonnull in practice. This is one less thing to
94 worry about when checking for integer overflow later.
95 (x_check_image_size): New function, which checks for integer
96 overflow issues inside X.
97 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
98 This removes the need for a memory_full check.
99 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
100 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
101 (xbm_read_bitmap_data): Change locals back to 'int', since
102 their values must fit in 'int'.
103 (xpm_load_image, png_load, tiff_load):
104 Invoke x_create_x_image_and_pixmap earlier,
105 to avoid much needless work if the image is too large.
106 (tiff_load): Treat overly large images as if
107 x_create_x_image_and_pixmap failed, not as malloc failures.
108 (gs_load): Use x_check_image_size.
109
110 * gtkutil.c: Omit integer casts.
111 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
112 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
113
114 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
115
116 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
117 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
118 would wrongly return t on a 64-bit host.
119
120 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
121 The plain *_OVERFLOW macros run afoul of GCC bug 49705
122 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
123 and therefore cause GCC to emit a bogus diagnostic in some cases.
124
125 * image.c: Integer signedness and overflow and related fixes.
126 This is not an exhaustive set of fixes, but it's time to
127 record what I've got.
128 (lookup_pixel_color, check_image_size): Remove redundant decls.
129 (check_image_size): Don't assume that arbitrary EMACS_INT values
130 fit in 'int', or that arbitrary 'double' values fit in 'int'.
131 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
132 (tiff_load, imagemagick_load_image):
133 Check for overflow in size calculations.
134 (x_create_x_image_and_pixmap): Remove unnecessary test for
135 xmalloc returning NULL; that can't happen.
136 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
137 (xpm_color_bucket): Use better integer hashing function.
138 (xpm_cache_color): Don't possibly over-allocate memory.
139 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
140 (gif_memory_source):
141 Use ptrdiff_t, not int or size_t, to record sizes.
142 (png_load): Don't assume values greater than 2**31 fit in 'int'.
143 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
144 either works, as we prefer signed integers.
145 (tiff_read_from_memory, tiff_write_from_memory):
146 Return tsize_t, not size_t, since that's what the TIFF API wants.
147 (tiff_read_from_memory): Don't fail simply because the read would
148 go past EOF; instead, return a short read.
149 (tiff_load): Omit no-longer-needed casts.
150 (Fimagemagick_types): Don't assume size fits into 'int'.
151
152 Improve hashing quality when configured --with-wide-int.
153 * fns.c (hash_string): New function, taken from sxhash_string.
154 Do not discard information about ASCII character case; this
155 discarding is no longer needed.
156 (sxhash-string): Use it. Change sig to match it. Caller changed.
157 * lisp.h: Declare it.
158 * lread.c (hash_string): Remove, since we now use fns.c's version.
159 The fns.c version returns a wider integer if --with-wide-int is
160 specified, so this should help the quality of the hashing a bit.
161
162 * emacs.c: Integer overflow minor fix.
163 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
164 Define only if GNU_LINUX.
165 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
166
167 * dispnew.c: Integer signedness and overflow fixes.
168 Remove unnecessary forward decls, that were a maintenance hassle.
169 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
170 All uses changed.
171 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
172 (scrolling_window): Use ptrdiff_t, not int, for byte count.
173 (prepare_desired_row, line_draw_cost):
174 Use int, not unsigned, where either works.
175 (save_current_matrix, restore_current_matrix):
176 Use ptrdiff_t, not size_t, where either works.
177 (init_display): Check for overflow more accurately, and without
178 relying on undefined behavior.
179
180 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
181 Remove, replacing with the new symbols in lisp.h. All uses changed.
182 * fileio.c (make_temp_name):
183 * filelock.c (lock_file_1, lock_file):
184 * xdisp.c (message_dolog):
185 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
186 Use pMd etc. instead.
187 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
188 replacing the pWIDE etc. symbols removed from editfns.c.
189
190 * keyboard.h (num_input_events): Now uintmax_t.
191 This is (very slightly) less likely to mess up due to wraparound.
192 All uses changed.
193
194 * buffer.c: Integer signedness fixes.
195 (alloc_buffer_text, enlarge_buffer_text):
196 Use ptrdiff_t rather than size_t when either will do, as we prefer
197 signed integers.
198
199 * alloc.c: Integer signedness and overflow fixes.
200 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
201 (__malloc_size_t): Default to size_t, not to int.
202 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
203 (Fgarbage_collect, mark_object_loop_halt, mark_object):
204 Prefer ptrdiff_t to size_t when either would do, as we prefer
205 signed integers.
206 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
207 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
208 Now const. Initialize with values that are in range even if char
209 is signed.
210 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
211 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
212 These functions do the right thing with sizes > 2**32.
213 (check_depth): Now ptrdiff_t, not int.
214 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
215 Adjust to new way of storing sizes. Check for size overflow bugs
216 in rest of code.
217 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
218 slightly wrong anyway, as it missed one instance of
219 XMALLOC_OVERRUN_CHECK_OVERHEAD.
220 (refill_memory_reserve): Omit needless cast to size_t.
221 (mark_object_loop_halt): Mark as externally visible.
222
223 * xselect.c: Integer signedness and overflow fixes.
224 (Fx_register_dnd_atom, x_handle_dnd_message):
225 Use ptrdiff_t, not size_t, since we prefer signed.
226 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
227 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
228 x_dnd_atoms_size and x_dnd_atoms_length.
229
230 * doprnt.c: Prefer signed to unsigned when either works.
231 * eval.c (verror):
232 * doprnt.c (doprnt):
233 * lisp.h (doprnt):
234 * xdisp.c (vmessage):
235 Use ptrdiff_t, not size_t, when using or implementing doprnt,
236 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
237 prefer signed arithmetic to avoid comparison confusion.
238 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
239 but is a bit tricky.
240
241 Assume freestanding C89 headers, string.h, stdlib.h.
242 * data.c, doprnt.c, floatfns.c, print.c:
243 Include float.h unconditionally.
244 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
245 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
246 * regex.c: Likewise for stddef.h, string.h.
247 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
248 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
249 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
250 (STDC_HEADERS): Remove obsolete defines.
251 * sysdep.c: Include limits.h unconditionally.
252
253 Assume support for memcmp, memcpy, memmove, memset.
254 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
255 * regex.c (memcmp, memcpy):
256 Remove; we assume C89 now.
257
258 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
259 (__malloc_safe_bcopy): Remove; no longer needed.
260
261 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
262 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
263 well either way, and we prefer signed to unsigned.
264
265 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
266
267 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
268 closes the connection while we're reading (bug#9182).
269
270 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
271
272 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
273 are specified (Bug#9168).
274
275 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
276
277 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
278 Found by GCC static checking and --with-wide-int on a 32-bit host.
279
280 2011-07-25 Eli Zaretskii <eliz@gnu.org>
281
282 * xdisp.c (compute_display_string_pos): Fix logic of caching
283 previous display string position. Initialize cached_prev_pos to
284 -1. Fixes slow-down at the beginning of a buffer.
285
286 2011-07-24 Eli Zaretskii <eliz@gnu.org>
287
288 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
289 for attrs[LFACE_FONTSET_INDEX].
290
291 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
292
293 * xml.c (parse_region): Remove unused local
294 that was recently introduced.
295
296 2011-07-23 Eli Zaretskii <eliz@gnu.org>
297
298 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
299 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
300
301 * xdisp.c (move_it_in_display_line_to): Record the best matching
302 position for TO_CHARPOS while scanning the line, and restore it on
303 exit if none of the characters scanned was an exact match. Fixes
304 vertical-motion and pos-visible-in-window-p under bidi redisplay
305 when exact match is impossible due to invisible text, and the
306 lines are truncated.
307
308 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
309
310 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
311 for OSX >= 10.7.
312
313 2011-07-22 Eli Zaretskii <eliz@gnu.org>
314
315 Fix a significant slow-down of cursor motion with C-n, C-p,
316 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
317 auto-repeat under bidi redisplay in fontified buffers.
318 * xdisp.c (compute_stop_pos_backwards): New function.
319 (next_element_from_buffer): Call compute_stop_pos_backwards to
320 find a suitable prev_stop when we find ourselves before
321 base_level_stop.
322 (reseat): Don't look for prev_stop, as that could mean a very long
323 run.
324 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
325 <cached_disp_overlay_modiff>: Cache for last found display string
326 position.
327 (compute_display_string_pos): Return the cached position if asked
328 about the same buffer in the same area of character positions, and
329 the buffer wasn't changed since the time the display string
330 position was cached.
331
332 2011-07-22 Eli Zaretskii <eliz@gnu.org>
333
334 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
335 is an integer, which is important for empty lines. (Bug#9149)
336
337 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
338
339 * frame.c (Fmodify_frame_parameters): In tty case, update the
340 default face if necessary (Bug#4238).
341
342 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
343
344 * editfns.c (Fstring_to_char): No need to explain what a character
345 is in the docstring (Bug#6576).
346
347 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
348
349 * xml.c (parse_region): Make sure we always return a tree.
350
351 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
352
353 * xml.c (parse_region): If a document contains only comments,
354 return that, too.
355
356 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
357
358 * xml.c (make_dom): Return comments, too.
359
360 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
361
362 Port to OpenBSD.
363 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
364 and the surrounding thread.
365 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
366 rather than fgets, and retry after EINTR. Otherwise, 'emacs
367 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
368 timer goes off.
369 * s/openbsd.h (BROKEN_SIGIO): Define.
370 * unexelf.c (unexec) [__OpenBSD__]:
371 Don't update the .mdebug section of the Alpha COFF symbol table.
372
373 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
374
375 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
376 (bug#8460).
377
378 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
379
380 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
381 This fixes some race conditions on the permissions of any newly
382 created file.
383
384 * alloc.c (valid_pointer_p): Use pipe, not open.
385 This fixes some permissions issues when debugging.
386
387 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
388 If fchown fails to set both uid and gid, try to set just gid,
389 as that is sometimes allowed. Adjust the file's mode to eliminate
390 setuid or setgid bits that are inappropriate if fchown fails.
391
392 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
393
394 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
395 to compare Lisp_Objects.
396 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
397 global_gnutls_log_level, don't mistake it for a Lisp_Object.
398 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
399
400 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
401
402 * lread.c (read_integer): Unread even EOF character.
403 (read1): Likewise. Properly record start position of symbol.
404
405 * lread.c (read1): Read `#:' as empty uninterned symbol if no
406 symbol character follows.
407
408 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
409
410 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
411 This works around a problem with the previous change to Fcopy_file.
412 Recent glibc declares fchown with __attribute__((warn_unused_result)),
413 and without this change, GCC might complain about discarding
414 fchown's return value.
415
416 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
417
418 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
419
420 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
421
422 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
423
424 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
425
426 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
427 it's used from the C level.
428
429 * process.c: Use the same condition for POLL_FOR_INPUT in both
430 keyboard.c and process.c (bug#1858).
431
432 2011-07-09 Lawrence Mitchell <wence@gmx.li>
433
434 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
435 (Fgnutls_boot): Use it.
436
437 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
438
439 * doc.c (Fsubstitute_command_keys): Revert last change.
440
441 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
442
443 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
444 quotes the next character, and doesn't affect other longer
445 sequences (bug#8935).
446
447 * lread.c (syms_of_lread): Clarify that is isn't only
448 `eval-buffer' and `eval-defun' that's affected by
449 `lexical-binding' (bug#8460).
450
451 2011-07-15 Eli Zaretskii <eliz@gnu.org>
452
453 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
454 bidi redisplay when a line includes both an image and is
455 truncated.
456
457 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
458
459 Fix minor problems found by static checking.
460 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
461 (elsz): Now a signed constant, not a size_t var. We prefer signed
462 types to unsigned, to avoid integer comparison confusion. Without
463 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
464 "cannot optimize loop, the loop counter may overflow", a symptom
465 of the confusion.
466 * indent.c (Fvertical_motion): Mark locals as initialized.
467 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
468
469 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
470
471 * search.c (Fre_search_backward): Mention `case-fold-search' in
472 all the re_search_* functions (bug#8138).
473
474 * keyboard.c (Fopen_dribble_file): Document when the file is
475 closed (bug#8056).
476
477 2011-07-14 Eli Zaretskii <eliz@gnu.org>
478
479 * bidi.c (bidi_dump_cached_states): Fix format of displaying
480 bidi_cache_idx.
481
482 Support bidi reordering of display and overlay strings.
483 * xdisp.c (compute_display_string_pos)
484 (compute_display_string_end): Accept additional argument STRING.
485 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
486 (reseat_to_string): Initialize bidi_it->string.s and
487 bidi_it->string.schars.
488 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
489 NULL (avoids a crash in bidi_paragraph_init). Initialize
490 itb.string.lstring.
491 (init_iterator): Call bidi_init_it only of a valid
492 buffer position was specified. Initialize paragraph_embedding to
493 L2R.
494 (reseat_to_string): Initialize the bidi iterator.
495 (display_string): If we need to ignore text properties of
496 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
497 original value of -1 will not work with bidi.)
498 (compute_display_string_pos): First arg is now struct
499 `text_pos *'; all callers changed. Support display properties on
500 Lisp strings.
501 (compute_display_string_end): Support display properties on Lisp
502 strings.
503 (init_iterator, reseat_1, reseat_to_string): Initialize the
504 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
505 when iterating on a string not from display properties).
506 (compute_display_string_pos, compute_display_string_end): Fix
507 calculation of the object to scan. Fixes an error when using
508 arrow keys.
509 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
510 base_level_stop; instead, set base_level_stop to BEGV. Fixes
511 crashes in vertical-motion.
512 (next_element_from_buffer): Improve commentary for when
513 the iterator is before prev_stop.
514 (init_iterator): Initialize bidi_p from the default value of
515 bidi-display-reordering, not from buffer-local value. Use the
516 buffer-local value only if initializing for buffer iteration.
517 (handle_invisible_prop): Support invisible properties on strings
518 that are being bidi-reordered.
519 (set_iterator_to_next): Support bidi reordering of C strings and
520 Lisp strings.
521 (next_element_from_string): Support bidi reordering of Lisp
522 strings.
523 (handle_stop_backwards): Support Lisp strings as well.
524 (display_string): Support display of R2L glyph rows. Use
525 IT_STRING_CHARPOS when displaying from a Lisp string.
526 (init_iterator): Don't initialize it->bidi_p for strings
527 here.
528 (reseat_to_string): Initialize it->bidi_p for strings here.
529 (next_element_from_string, next_element_from_c_string)
530 (next_element_from_buffer): Add xassert's for correspondence
531 between IT's object being iterated and it->bidi_it.string
532 structure.
533 (face_before_or_after_it_pos): Support bidi iteration.
534 (next_element_from_c_string): Handle the case of the first string
535 character that is not the first one in the visual order.
536 (get_visually_first_element): New function, refactored from common
537 parts of next_element_from_buffer, next_element_from_string, and
538 next_element_from_c_string.
539 (tool_bar_lines_needed, redisplay_tool_bar)
540 (display_menu_bar): Force left-to-right direction. Add a FIXME
541 comment for making that be controlled by a user option.
542 (push_it, pop_it): Save and restore the state of the
543 bidi iterator. Save and restore the bidi_p flag.
544 (pop_it): Iterate out of display property for string iteration as
545 well.
546 (iterate_out_of_display_property): Support iteration over strings.
547 (handle_single_display_spec): Set up it->bidi_it for iteration
548 over a display string, and call bidi_init_it.
549 (handle_single_display_spec, next_overlay_string)
550 (get_overlay_strings_1, push_display_prop): Set up the bidi
551 iterator for displaying display or overlay strings.
552 (forward_to_next_line_start): Don't use the shortcut if
553 bidi-iterating.
554 (back_to_previous_visible_line_start): If handle_display_prop
555 pushed the iterator stack, restore the internal state of the bidi
556 iterator by calling bidi_pop_it same number of times.
557 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
558 and we are bidi-iterating, don't decrement the iterator position;
559 instead, set the first_elt flag in the bidi iterator, to produce
560 the same effect.
561 (reseat_1): Remove redundant setting of string_from_display_prop_p.
562 (push_display_prop): xassert that we are iterating a buffer.
563 (push_it, pop_it): Save and restore paragraph_embedding member.
564 (handle_single_display_spec, next_overlay_string)
565 (get_overlay_strings_1, reseat_1, reseat_to_string)
566 (push_display_prop): Set up the `unibyte' member of bidi_it.string
567 correctly. Don't assume unibyte strings are not bidi-reordered.
568 (compute_display_string_pos)
569 (compute_display_string_end): Fix handling the case of C string.
570 (push_it, pop_it): Save and restore from_disp_prop_p.
571 (handle_single_display_spec, push_display_prop): Set the
572 from_disp_prop_p flag.
573 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
574 (pop_it): Call iterate_out_of_display_property only if we are
575 popping after iteration over a string that came from a display
576 property. Fix a typo in popping stretch info. Add an assertion
577 for verifying that the iterator position is in sync with the bidi
578 iterator.
579 (handle_single_display_spec, get_overlay_strings_1)
580 (push_display_prop): Fix initialization of paragraph direction for
581 string when that of the parent object is not yet determined.
582 (reseat_1): Call bidi_init_it to resync the bidi
583 iterator with IT's position. (Bug#7616)
584 (find_row_edges): If ROW->start.pos gives position
585 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
586 (handle_stop, back_to_previous_visible_line_start, reseat_1):
587 Reset the from_disp_prop_p flag.
588 (SAVE_IT, RESTORE_IT): New macros.
589 (pos_visible_p, face_before_or_after_it_pos)
590 (back_to_previous_visible_line_start)
591 (move_it_in_display_line_to, move_it_in_display_line)
592 (move_it_to, move_it_vertically_backward, move_it_by_lines)
593 (try_scrolling, redisplay_window, display_line): Use them when
594 saving a temporary copy of the iterator and restoring it back.
595 (back_to_previous_visible_line_start, reseat_1)
596 (init_iterator): Empty the bidi cache "stack".
597 (move_it_in_display_line_to): If iterator ended up at
598 EOL, but we never saw any buffer positions smaller than
599 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
600 motion in bidi-reordered lines.
601 (move_it_in_display_line_to): Record prev_method and prev_pos
602 immediately before the call to set_iterator_to_next. Fixes cursor
603 motion in bidi-reordered lines with stretch glyphs and strings
604 displayed in margins. (Bug#8133) (Bug#8867)
605 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
606 TO_CHARPOS.
607 (pos_visible_p): Support positions in bidi-reordered lines. Save
608 and restore bidi cache.
609
610 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
611 (bidi_paragraph_info): Delete unused struct.
612 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
613 (bidi_cache_start): New variable.
614 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
615 to zero.
616 (bidi_cache_fetch_state, bidi_cache_search)
617 (bidi_cache_find_level_change, bidi_cache_iterator_state)
618 (bidi_cache_find, bidi_peek_at_next_level)
619 (bidi_level_of_next_char, bidi_find_other_level_edge)
620 (bidi_move_to_visually_next): Compare cache index with
621 bidi_cache_start rather than with zero.
622 (bidi_fetch_char): Accept new argument STRING; all callers
623 changed. Support iteration over a string. Support strings with
624 display properties. Support unibyte strings. Fix the type of
625 `len' according to what STRING_CHAR_AND_LENGTH expects.
626 (bidi_paragraph_init, bidi_resolve_explicit_1)
627 (bidi_resolve_explicit, bidi_resolve_weak)
628 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
629 iteration over a string.
630 (bidi_set_sor_type, bidi_resolve_explicit_1)
631 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
632 can now be zero (for strings); special values 0 and -1 were
633 changed to -1 and -2, respectively.
634 (bidi_char_at_pos): New function.
635 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
636 Call it instead of FETCH_MULTIBYTE_CHAR.
637 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
638 initialized to valid values.
639 (bidi_init_it): Don't initialize charpos and bytepos with invalid
640 values.
641 (bidi_level_of_next_char): Allow the sentinel "position" to pass
642 the test for valid cached positions. Fix the logic for looking up
643 the sentinel state in the cache. GCPRO the Lisp string we are
644 iterating.
645 (bidi_push_it, bidi_pop_it): New functions.
646 (bidi_initialize): Initialize the bidi cache start stack pointer.
647 (bidi_cache_ensure_space): New function, refactored from part of
648 bidi_cache_iterator_state. Don't assume the required size is just
649 one BIDI_CACHE_CHUNK away.
650 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
651 (bidi_count_bytes, bidi_char_at_pos): New functions.
652 (bidi_cache_search): Don't assume bidi_cache_last_idx is
653 always valid if bidi_cache_idx is valid.
654 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
655 is valid if it's going to be used.
656 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
657 (bidi_cache_fetch_state, bidi_cache_search)
658 (bidi_cache_find_level_change, bidi_cache_ensure_space)
659 (bidi_cache_iterator_state, bidi_cache_find)
660 (bidi_find_other_level_edge, bidi_cache_start_stack): All
661 variables related to cache indices are now EMACS_INT.
662
663 * dispextern.h (struct bidi_string_data): New structure.
664 (struct bidi_it): New member `string'. Make flag members be 1-bit
665 fields, and put them last in the struct.
666 (compute_display_string_pos, compute_display_string_end): Update
667 prototypes.
668 (bidi_push_it, bidi_pop_it): Add prototypes.
669 (struct iterator_stack_entry): New members bidi_p,
670 paragraph_embedding, and from_disp_prop_p.
671 (struct it): Member bidi_p is now a bit field 1 bit wide.
672 (bidi_shelve_cache, bidi_unshelve_cache): Declare
673 prototypes.
674
675 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
676 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
677 and vector-like objects.
678
679 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
680 cache around display iteration.
681
682 * window.c (Fwindow_end, window_scroll_pixel_based)
683 (displayed_window_lines, Frecenter): Save and restore the bidi
684 cache around display iteration.
685
686 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
687
688 * editfns.c (Fdelete_region): Clarify the use of the named
689 parameters (bug#6788).
690
691 2011-07-14 Martin Rudalics <rudalics@gmx.at>
692
693 * indent.c (Fvertical_motion): Set and restore w->pointm when
694 saving and restoring the window's buffer (Bug#9006).
695
696 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
697
698 * editfns.c (Fstring_to_char): Clarify just what is returned
699 (bug#6576). Text by Eli Zaretskii.
700
701 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
702
703 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
704
705 2011-07-13 Eli Zaretskii <eliz@gnu.org>
706
707 * buffer.c (mmap_find): Fix a typo.
708
709 2011-07-13 Johan Bockgård <bojohan@gnu.org>
710
711 Fix execution of x selection hooks.
712 * xselect.c (Qx_lost_selection_functions)
713 (Qx_sent_selection_functions): New vars.
714 (syms_of_xselect): DEFSYM them.
715 (x_handle_selection_request): Pass Qx_sent_selection_functions
716 rather than Vx_sent_selection_functions to Frun_hook_with_args.
717 (x_handle_selection_clear,x_clear_frame_selections):
718 Pass Qx_lost_selection_functions rather than
719 Vx_lost_selection_functions to Frun_hook_with_args.
720
721 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
722
723 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
724 The old code sometimes used this field without initializing it.
725
726 * alloc.c (gc_sweep): Don't read past end of array.
727 In theory, the old code could also have corrupted Emacs internals,
728 though it'd be very unlikely.
729
730 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
731
732 * character.c (Fcharacterp): Don't advertise optional ignored
733 argument. (Bug#4026)
734
735 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
736
737 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
738 key" (bug#4257).
739
740 * window.c (Fset_window_start): Doc fix (bug#4199).
741 (Fset_window_hscroll): Ditto.
742
743 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
744
745 Fix minor new problems caught by GCC 4.6.1.
746 * term.c (init_tty): Remove unused local.
747 * xsettings.c (store_monospaced_changed): Define this function only
748 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
749 not used otherwise.
750
751 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
752
753 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
754
755 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
756
757 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
758 are the mini-buffer and the echo area (bug#3320).
759
760 * term.c (init_tty): Remove support for supdup, c10 and perq
761 terminals, which are no longer supported (bug#1482).
762
763 2011-07-10 Johan Bockgård <bojohan@gnu.org>
764
765 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
766
767 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
768
769 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
770 for non-popups (Bug#3642).
771
772 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
773
774 * alloc.c (reset_malloc_hooks): Protoize.
775 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
776 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
777 * cm.c (losecursor): Likewise.
778 * data.c (fmod): Likewise.
779 * dispnew.c (swap_glyphs_in_rows): Likewise.
780 * emacs.c (memory_warning_signal): Likewise.
781 * floatfns.c (float_error): Likewise.
782 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
783 (otf_open, font_otf_capability, generate_otf_features)
784 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
785 Likewise.
786 * image.c (pbm_read_file): Likewise.
787 * indent.c (string_display_width): Likewise.
788 * intervals.c (check_for_interval, search_for_interval)
789 (inc_interval_count, count_intervals, root_interval)
790 (adjust_intervals_for_insertion, make_new_interval): Likewise.
791 * lread.c (defalias): Likewise.
792 * ralloc.c (r_alloc_check): Likewise.
793 * regex.c (set_image_of_range_1, set_image_of_range)
794 (regex_grow_registers): Likewise.
795 * sysdep.c (strerror): Likewise.
796 * termcap.c (valid_filename_p, tprint, main): Likewise.
797 * tparam.c (main): Likewise.
798 * unexhp9k800.c (run_time_remap, save_data_space)
799 (update_file_ptrs, read_header, write_header, calculate_checksum)
800 (copy_file, copy_rest, display_header): Likewise.
801 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
802 Likewise.
803 * xdisp.c (check_it): Likewise.
804 * xfaces.c (register_color, unregister_color, unregister_colors):
805 Likewise.
806 * xfns.c (print_fontset_result): Likewise.
807 * xrdb.c (member, fatal, main): Likewise.
808
809 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
810
811 Fix minor problems found by static checking (Bug#9031).
812 * chartab.c (char_table_set_range, map_sub_char_table):
813 Remove unused locals.
814 (uniprop_table): Now static.
815 * composite.c (_work_char): Remove unused static var.
816
817 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
818
819 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
820
821 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
822
823 * gtkutil.c (qttip_cb): Remove code without function.
824
825 2011-07-09 Eli Zaretskii <eliz@gnu.org>
826
827 * w32.c (pthread_sigmask): New stub.
828
829 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
830
831 Use pthread_sigmask, not sigprocmask (Bug#9010).
832 sigprocmask is portable only for single-threaded applications, and
833 Emacs can be multi-threaded when it uses GTK.
834 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
835 (LIBES): Use it.
836 * callproc.c (Fcall_process):
837 * process.c (create_process):
838 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
839 Use pthread_sigmask, not sigprocmask.
840
841 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
842
843 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
844 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
845 wrong (Bug#8591).
846
847 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
848
849 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
850 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
851 (xg_hide_tooltip): Fix comment.
852
853 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
854 in registerServicesMenuSendTypes.
855 (validRequestorForSendType): Don't check ns_return_types.
856
857 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
858 ns_return_type.
859
860 2011-07-08 Jason Rumney <jasonr@gnu.org>
861
862 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
863 frame struct members of non-existent frames (Bug#6284).
864
865 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
866
867 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
868 variable firstTime not needed on OSX >= 10.6.
869 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
870 >= 10.5. Use setKnobProportion, setDoubleValue.
871
872 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
873 (MAC_OS_X_VERSION_10_5): Define if not defined.
874 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
875 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
876 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
877
878 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
879 cString and lossyCString on OSX >= 10.4
880
881 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
882 sizeToFit on OSX >= 10.2.
883
884 * nsimage.m (allocInitFromFile): Don't use deprecated method
885 bestRepresentationForDevice on OSX >= 10.6.
886
887 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
888 to avoid warning.
889
890 * emacs.c: Declare unexec_init_emacs_zone.
891
892 * nsgui.h: Fix compiler warning about gnulib redefining verify.
893
894 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
895
896 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
897 on svcsMenu (Bug#8842).
898
899 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
900 ns_return_types.
901 (Fns_list_services): Just return Qnil on 10.6, code not working there.
902
903 * nsterm.m (QUTF8_STRING): Declare.
904 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
905 (validRequestorForSendType): Return type is (id).
906 Change indexOfObjectIdenticalTo to indexOfObject.
907 Check if we have local selection before returning self (Bug#8842).
908 (writeSelectionToPasteboard): Put local selection into paste board
909 if we have a local selection (Bug#8842).
910 (syms_of_nsterm): DEFSYM QUTF8_STRING.
911
912 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
913 (ns_get_local_selection): Declare.
914
915 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
916
917 * keymap.c (describe_map_tree): Don't insert a double newline at
918 the end of the buffer (bug#1169) and return whether we inserted
919 something.
920
921 * callint.c (Fcall_interactively): Change "reading args" to
922 "providing args" to try to clarify what it does (bug#1010).
923
924 2011-07-07 Kenichi Handa <handa@m17n.org>
925
926 * composite.c (composition_compute_stop_pos): Ignore a static
927 composition starting before CHARPOS (Bug#8915).
928
929 * xdisp.c (handle_composition_prop): Likewise.
930
931 2011-07-07 Eli Zaretskii <eliz@gnu.org>
932
933 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
934 (Bug#9015)
935
936 2011-07-07 Kenichi Handa <handa@m17n.org>
937
938 * character.h (unicode_category_t): New enum type.
939
940 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
941 (Qchar_code_property_table): New variable.
942 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
943 (UNIPROP_COMPRESSED_FORM_P): New macros.
944 (char_table_ascii): Uncompress the compressed values.
945 (sub_char_table_ref): New arg is_uniprop. Callers changed.
946 Uncompress the compressed values.
947 (sub_char_table_ref_and_range): Likewise.
948 (char_table_ref_and_range): Uncompress the compressed values.
949 (sub_char_table_set): New arg is_uniprop. Callers changed.
950 Uncompress the compressed values.
951 (sub_char_table_set_range): Args changed. Callers changed.
952 (char_table_set_range): Adjuted for the above change.
953 (map_sub_char_table): Delete args default_val and parent. Add arg
954 top. Give decoded values to a Lisp function.
955 (map_char_table): Adjusted for the above change. Give decoded
956 values to a Lisp function. Gcpro more variables.
957 (uniprop_table_uncompress)
958 (uniprop_decode_value_run_length): New functions.
959 (uniprop_decoder, uniprop_decoder_count): New variables.
960 (uniprop_get_decoder, uniprop_encode_value_character)
961 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
962 New functions.
963 (uniprop_encoder, uniprop_encoder_count): New variables.
964 (uniprop_get_encoder, uniprop_table)
965 (Funicode_property_table_internal, Fget_unicode_property_internal)
966 (Fput_unicode_property_internal): New functions.
967 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
968 Sunicode_property_table_internal, Sget_unicode_property_internal,
969 and Sput_unicode_property_internal. Defvar_lisp
970 char-code-property-alist.
971
972 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
973 Vunicode_category_table.
974
975 * font.c (font_range): Adjusted for the change of
976 Vunicode_category_table.
977
978 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
979
980 * m/iris4d.h: Remove file, move contents ...
981 * s/irix6-5.h: ... here.
982
983 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
984
985 Remove unportable assumption about struct layout (Bug#8884).
986 * alloc.c (mark_buffer):
987 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
988 (clone_per_buffer_values): Don't assume that
989 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
990 This isn't true in general, and it's particularly not true
991 if Emacs is configured with --with-wide-int.
992 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
993 New macros, used in the buffer.c change.
994
995 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
996
997 * xsettings.c: Use both GConf and GSettings if both are available.
998 (store_config_changed_event): Add comment.
999 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1000 (store_tool_bar_style_changed): New functions.
1001 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1002 (struct xsettings): Move font inside HAVE_XFT.
1003 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1004 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1005 Move inside HAVE_XFT.
1006 (something_changed_gsettingsCB): Renamed from something_changedCB.
1007 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1008 also.
1009 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1010 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1011 (something_changed_gconfCB): Renamed from something_changedCB.
1012 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1013 (parse_settings): Move check for font inside HAVE_XFT.
1014 (read_settings, apply_xft_settings): Add comment.
1015 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1016 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1017 call store_font_name_changed.
1018 (xft_settings_event): Add comment.
1019 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1020 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1021 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1022 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1023 (xsettings_initialize): Call init_gsettings last.
1024 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1025 comment.
1026
1027 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1028
1029 Random fixes. E.g., (random) never returned negative values.
1030 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1031 subseconds part to the entropy, as that's a bit more random.
1032 Prefer signed to unsigned, since the signedness doesn't matter and
1033 in general we prefer signed. When given a limit, use a
1034 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1035 latter isn't right if USE_2_TAGS_FOR_INTS.
1036 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1037 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1038
1039 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1040
1041 * textprop.c (text_property_stickiness):
1042 Obey Vtext_property_default_nonsticky.
1043 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1044 * w32fns.c (syms_of_w32fns):
1045 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1046
1047 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1050 This is more efficient than Ffile_directory_p and avoids a minor race.
1051
1052 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1053
1054 * buffer.c (Foverlay_put): Say what the return value is
1055 (bug#7835).
1056
1057 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1058 is a directory before asking whether to use the file name
1059 (bug#7564).
1060 (barf_or_query_if_file_exists): Make the "File is a directory"
1061 error be more correct.
1062
1063 * fns.c (Frequire): Remove the mention of the .gz files, since
1064 that's installation-specific, but keep the mention of
1065 `get-load-suffixes'.
1066
1067 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1068
1069 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1070 Report string overflow if the output is too long.
1071
1072 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1073
1074 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1075 (syms_of_gnutls): Remove duplicate DEFSYM for
1076 Qgnutls_bootprop_verify_hostname_error, an error for
1077 Qgnutls_bootprop_verify_error (which is no longer used).
1078
1079 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1080 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1081 Also (re)move comments that are misplaced or no longer relevant.
1082
1083 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1084
1085 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1086
1087 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1088
1089 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1090 and background color parameters if they have been changed.
1091
1092 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1093
1094 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1095
1096 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1097
1098 * xsettings.c (SYSTEM_FONT): Define only when used.
1099 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1100
1101 * keymap.c (access_keymap_1): Now static.
1102
1103 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1104
1105 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1106 leave any prefix arg for the up event (Bug#1586).
1107
1108 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1109
1110 * lread.c (syms_of_lread): Mention single symbols defined by
1111 `defvar' or `defconst' (bug#7154).
1112
1113 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1114 (Frequire): Mention get-load-suffixes.
1115
1116 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1117
1118 * window.h (window): Remove clone_number slot.
1119 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1120 Remove.
1121 (make_parent_window, make_window, saved_window)
1122 (Fset_window_configuration, save_window_save): Don't deal with
1123 clone numbers.
1124 * buffer.c (Qclone_number): Remove declaration.
1125 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1126
1127 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1128
1129 Add multiple inheritance to keymaps.
1130 * keymap.c (Fmake_composed_keymap): New function.
1131 (Fset_keymap_parent): Simplify.
1132 (fix_submap_inheritance): Remove.
1133 (access_keymap_1): New function extracted from access_keymap to handle
1134 embedded parents and handle lists of maps.
1135 (access_keymap): Use it.
1136 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1137 (Fcopy_keymap): Handle embedded parents.
1138 (Fcommand_remapping, define_as_prefix): Simplify.
1139 (Fkey_binding): Simplify.
1140 (syms_of_keymap): Move minibuffer-local-completion-map,
1141 minibuffer-local-filename-completion-map,
1142 minibuffer-local-must-match-map, and
1143 minibuffer-local-filename-must-match-map to Elisp.
1144 (syms_of_keymap): Defsubr make-composed-keymap.
1145 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1146 (parse_menu_item): Trivial simplification.
1147
1148 2011-07-01 Glenn Morris <rgm@gnu.org>
1149
1150 * Makefile.in (SETTINGS_LIBS): Fix typo.
1151
1152 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1153
1154 * coding.c (Fencode_coding_string): Record the last coding system
1155 used, as the function doc string says (bug#8738).
1156
1157 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1158
1159 * xsettings.c (store_monospaced_changed): Take new font as arg and
1160 check for change against current_mono_font.
1161 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1162 (emacs_settings_constructor, emacs_settings_get_property)
1163 (emacs_settings_set_property, emacs_settings_class_init)
1164 (emacs_settings_init, gsettings_obj): Remove.
1165 (something_changedCB): New function for HAVE_GSETTINGS.
1166 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1167 with value as argument.
1168 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1169 g_settings_new (Bug#8967). Do not create gsettings_obj.
1170 Remove calls to g_settings_bind. Connect something_changedCB to
1171 "changed".
1172
1173 * xgselect.c: Add defined (HAVE_GSETTINGS).
1174 (xgselect_initialize): Ditto.
1175
1176 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1177 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1178 xg_select.
1179
1180 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 * eval.c (struct backtrace): Simplify and port the data structure.
1183 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1184 signed bit field, as this assumption is not portable and it makes
1185 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1186 "char debug_on_exit : 1" as this is not portable either; instead,
1187 use the portable "unsigned int debug_on_exit : 1". Remove unused
1188 member evalargs. Remove obsolete comments about cc bombing out.
1189
1190 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1191
1192 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1193 Let HAVE_GSETTINGS override HAVE_GCONF.
1194 (store_monospaced_changed): New function.
1195 (EMACS_SETTINGS): A new type derived from GObject to handle
1196 GSettings notifications.
1197 (emacs_settings_constructor, emacs_settings_get_property)
1198 (emacs_settings_set_property, emacs_settings_class_init):
1199 New functions.
1200 (gsettings_client, gsettings_obj): New variables.
1201 (GSETTINGS_SCHEMA): New define.
1202 (something_changedCB): Call store_monospaced_changed.
1203 (init_gsettings): New function.
1204 (xsettings_initialize): Call init_gsettings.
1205 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1206 to NULL.
1207
1208 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1209 GCONF_CFLAGS/LIBS.
1210
1211 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1212
1213 * window.c (resize_root_window, grow_mini_window)
1214 (shrink_mini_window): Rename Qresize_root_window to
1215 Qwindow_resize_root_window and Qresize_root_window_vertically to
1216 Qwindow_resize_root_window_vertically.
1217
1218 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1219
1220 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1221
1222 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1223
1224 * makefile.w32-in: Redesign dependencies so they reflect more
1225 clearly which files are directly included by each source file,
1226 and not through other includes.
1227
1228 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1229
1230 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1231 (sort_overlays, overlay_strings): When an overlay's clone number
1232 matches the window's clone number process the overlay even if
1233 the overlay's window property doesn't match the current window.
1234
1235 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1236 (Fwindow_hchild): Rename to Fwindow_left_child.
1237 (Fwindow_next): Rename to Fwindow_next_sibling.
1238 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1239 (resize_window_check): Rename to window_resize_check.
1240 (resize_window_apply): Rename to window_resize_apply.
1241 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1242 (Fdelete_other_windows_internal, resize_frame_windows)
1243 (Fsplit_window_internal, Fdelete_window_internal)
1244 (grow_mini_window, shrink_mini_window)
1245 (Fresize_mini_window_internal): Fix callers accordingly.
1246
1247 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1248
1249 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1250 (emacs_fixed_set_min_size): Remove.
1251 (emacs_fixed_new): Take frame as argument.
1252
1253 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1254 (_EmacsFixedPrivate): Remove minwidth/height.
1255 Add struct frame *f.
1256 (emacs_fixed_init): Initialize priv->f.
1257 (get_parent_class, emacs_fixed_set_min_size): Remove.
1258 (emacs_fixed_new): Set priv->f to argument.
1259 (emacs_fixed_get_preferred_width)
1260 (emacs_fixed_get_preferred_height): Use min_width/height from
1261 frames size_hint to set minimum and natural (Bug#8919).
1262 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1263 and use min_width/height from frames size_hint to set
1264 min_width/height (Bug#8919).
1265
1266 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1267 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1268 Fix indentation.
1269
1270 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1271
1272 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1273 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1274 called at ZV.
1275
1276 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1277
1278 * process.c (wait_reading_process_output): Bypass select if
1279 waiting for a cell while ignoring keyboard input, and input is
1280 pending. Suggested by Jan Djärv (Bug#8869).
1281
1282 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 Use gnulib's dup2 module instead of rolling our own.
1285 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1286
1287 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1288
1289 * dispnew.c (scrolling_window): Before scrolling, turn off a
1290 mouse-highlight in the window being scrolled.
1291
1292 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1293
1294 Move DEFSYM to lisp.h and use everywhere.
1295
1296 * character.h (DEFSYM): Move declaration...
1297 * lisp.h (DEFSYM): ...here.
1298
1299 * gnutls.c:
1300 * minibuf.c:
1301 * w32menu.c:
1302 * w32proc.c:
1303 * w32select.c: Don't include character.h.
1304
1305 * alloc.c (syms_of_alloc):
1306 * buffer.c (syms_of_buffer):
1307 * bytecode.c (syms_of_bytecode):
1308 * callint.c (syms_of_callint):
1309 * casefiddle.c (syms_of_casefiddle):
1310 * casetab.c (init_casetab_once):
1311 * category.c (init_category_once, syms_of_category):
1312 * ccl.c (syms_of_ccl):
1313 * cmds.c (syms_of_cmds):
1314 * composite.c (syms_of_composite):
1315 * dbusbind.c (syms_of_dbusbind):
1316 * dired.c (syms_of_dired):
1317 * dispnew.c (syms_of_display):
1318 * doc.c (syms_of_doc):
1319 * editfns.c (syms_of_editfns):
1320 * emacs.c (syms_of_emacs):
1321 * eval.c (syms_of_eval):
1322 * fileio.c (syms_of_fileio):
1323 * fns.c (syms_of_fns):
1324 * frame.c (syms_of_frame):
1325 * fringe.c (syms_of_fringe):
1326 * insdel.c (syms_of_insdel):
1327 * keymap.c (syms_of_keymap):
1328 * lread.c (init_obarray, syms_of_lread):
1329 * macros.c (syms_of_macros):
1330 * msdos.c (syms_of_msdos):
1331 * print.c (syms_of_print):
1332 * process.c (syms_of_process):
1333 * search.c (syms_of_search):
1334 * sound.c (syms_of_sound):
1335 * syntax.c (init_syntax_once, syms_of_syntax):
1336 * terminal.c (syms_of_terminal):
1337 * textprop.c (syms_of_textprop):
1338 * undo.c (syms_of_undo):
1339 * w32.c (globals_of_w32):
1340 * window.c (syms_of_window):
1341 * xdisp.c (syms_of_xdisp):
1342 * xfaces.c (syms_of_xfaces):
1343 * xfns.c (syms_of_xfns):
1344 * xmenu.c (syms_of_xmenu):
1345 * xsettings.c (syms_of_xsettings):
1346 * xterm.c (syms_of_xterm): Use DEFSYM.
1347
1348 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1349
1350 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1351
1352 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1353
1354 Integer and buffer overflow fixes (Bug#8873).
1355
1356 * print.c (printchar, strout): Check for string overflow.
1357 (PRINTPREPARE, printchar, strout):
1358 Don't set size unless allocation succeeds.
1359
1360 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1361 for sizes. Check for string overflow more accurately.
1362 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1363
1364 * macros.c: Integer and buffer overflow fixes.
1365 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1366 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1367 Use ptrdiff_t, not int, for sizes.
1368 Don't increment bufsize until after realloc succeeds.
1369 Check for size-calculation overflow.
1370 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1371
1372 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1373
1374 * lread.c: Integer overflow fixes.
1375 (read_integer): Radix is now EMACS_INT, not int,
1376 to improve quality of diagnostics for out-of-range radices.
1377 Calculate buffer size correctly for out-of-range radices.
1378 (read1): Check for integer overflow in radices, and in
1379 read-circle numbers.
1380 (read_escape): Avoid int overflow.
1381 (Fload, openp, read_buffer_size, read1)
1382 (substitute_object_recurse, read_vector, read_list, map_obarray):
1383 Use ptrdiff_t, not int, for sizes.
1384 (read1): Use EMACS_INT, not int, for sizes.
1385 Check for size overflow.
1386
1387 * image.c (cache_image): Check for size arithmetic overflow.
1388
1389 * lread.c: Integer overflow issues.
1390 (saved_doc_string_size, saved_doc_string_length)
1391 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1392 Now ptrdiff_t, not int.
1393 (read1): Don't assume doc string length fits in int. Check for
1394 out-of-range doc string lengths.
1395 (read_list): Don't assume file position fits in int.
1396 (read_escape): Check for hex character overflow.
1397
1398 2011-06-22 Leo Liu <sdl.web@gmail.com>
1399
1400 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1401 Move to minibuffer.el.
1402
1403 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1404
1405 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1406 The following patches are for when GLYPH_DEBUG && !XASSERT.
1407 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1408 * dispnew.c (flush_stdout):
1409 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1410 Mark as externally visible.
1411 * dispnew.c (check_window_matrix_pointers): Now static.
1412 * dispnew.c (window_to_frame_vpos):
1413 * xfns.c (unwind_create_frame):
1414 * xterm.c (x_check_font): Remove unused local.
1415 * scroll.c (CHECK_BOUNDS):
1416 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1417 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1418 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1419 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1420 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1421 Now static.
1422 (debug_method_add): Use va_list and vsprintf rather than relying
1423 on undefined behavior with wrong number of arguments.
1424 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1425 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1426 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1427 since we're not interested in debugging glyphs with old libraries.
1428 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1429 GCC 4.6.0's static checking.
1430
1431 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1432
1433 Integer overflow and signedness fixes (Bug#8873).
1434 A few related buffer overrun fixes, too.
1435
1436 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1437
1438 * dispextern.h (struct face.stipple):
1439 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1440 (x_bitmap_mask, x_allocate_bitmap_record)
1441 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1442 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1443 (x_create_bitmap_from_xpm_data):
1444 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1445 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1446 (.bitmaps_last):
1447 * xfaces.c (load_pixmap):
1448 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1449 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1450 (.bitmaps_last, struct x_output.icon_bitmap):
1451 Use ptrdiff_t, not int, for bitmap indexes.
1452 (x_allocate_bitmap_record): Check for size overflow.
1453 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1454
1455 Use ptrdiff_t, not int, for overlay counts.
1456 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1457 * editfns.c (overlays_around, get_pos_property):
1458 * textprop.c (get_char_property_and_overlay):
1459 * xdisp.c (next_overlay_change, note_mouse_highlight):
1460 * xfaces.c (face_at_buffer_position):
1461 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1462 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1463 (Fnext_overlay_change, Fprevious_overlay_change)
1464 (mouse_face_overlay_overlaps, Foverlays_in):
1465 Use ptrdiff_t, not int, for sizes.
1466 (overlays_at, overlays_in): Check for size-calculation overflow.
1467
1468 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1469
1470 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1471 (x_session_initialize): Do not assume string length fits in int.
1472
1473 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1474 This is unlikely, but can occur if DPI is outlandish.
1475
1476 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1477 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1478
1479 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1480 * xrdb.c (magic_file_p, search_magic_path):
1481 Omit last arg SUFFIX; it was always 0. All callers changed.
1482 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1483
1484 * xfont.c (xfont_match): Avoid need for strlen.
1485
1486 * xfns.c: Don't assume strlen fits in int.
1487 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1488
1489 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1490 not unsigned long, as we prefer signed integers. All callers changed.
1491 Detect integer overflow in repeat count.
1492 (message_dolog): Don't assume print length fits in 39 bytes.
1493 (display_mode_element): Don't assume strlen fits in int.
1494
1495 * termcap.c: Don't assume sizes fit in int and never overflow.
1496 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1497 (gobble_line): Check for size-calculation overflow.
1498
1499 * minibuf.c (Fread_buffer):
1500 * lread.c (intern, intern_c_string):
1501 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1502 Don't assume string length fits in int.
1503
1504 * keyboard.c (parse_tool_bar_item):
1505 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1506
1507 * font.c: Don't assume string length fits in int.
1508 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1509 Use ptrdiff_t, not int.
1510 (font_intern_prop): Don't assume string length fits in int.
1511 Don't assume integer property fits in fixnum.
1512 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1513
1514 * filelock.c: Fix some buffer overrun and integer overflow issues.
1515 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1516 Reformulate so as not to need the command string.
1517 Invoke gzip -cd rather than gunzip, as it's more portable.
1518 (lock_info_type, lock_file_1, lock_file):
1519 Don't assume pid_t and time_t fit in unsigned long.
1520 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1521 (current_lock_owner): Prefer signed type for sizes.
1522 Use memcpy, not strncpy, where memcpy is what is really wanted.
1523 Don't assume (via atoi) that time_t and pid_t fit in int.
1524 Check for time_t and/or pid_t out of range, e.g., via a network share.
1525 Don't alloca where an auto var works fine.
1526
1527 * fileio.c: Fix some integer overflow issues.
1528 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1529 Don't assume string length fits in int.
1530 (directory_file_name): Don't assume string length fits in long.
1531 (make_temp_name): Don't assume pid fits in int, or that its print
1532 length is less than 20.
1533
1534 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1535
1536 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1537
1538 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1539
1540 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1541 We prefer signed integers, even for size calculations.
1542
1543 * emacs.c: Don't assume string length fits in 'int'.
1544 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1545 (main): Don't invoke strlen when not needed.
1546
1547 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1548 (XD_DEBUG_MESSAGE): Don't waste a byte.
1549
1550 * callproc.c (getenv_internal_1, getenv_internal)
1551 (Fgetenv_internal):
1552 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1553
1554 * lread.c (invalid_syntax): Omit length argument.
1555 All uses changed. This doesn't fix a bug, but it simplifies the
1556 code away from its former Hollerith-constant appearance, and it's
1557 one less 'int' to worry about when looking at integer-overflow issues.
1558 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1559
1560 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1561 This didn't break anything, but it didn't help either.
1562 It's confusing to put a bogus integer in a place where the actual
1563 value does not matter.
1564 (LIST_END_P): Remove unused macro and its bogus comment.
1565 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1566
1567 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1568 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1569 implementation.
1570 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1571 We prefer signed types, and the value cannot exceed the EMACS_INT
1572 range anyway (because otherwise the length would not be representable).
1573 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1574 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1575 This avoids a GCC warning when WIDE_EMACS_INT.
1576
1577 * indent.c (sane_tab_width): New function.
1578 (current_column, scan_for_column, Findent_to, position_indentation)
1579 (compute_motion): Use it. This is just for clarity.
1580 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1581
1582 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1583
1584 * lisp.h (lint_assume): New macro.
1585 * composite.c (composition_gstring_put_cache):
1586 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1587
1588 * editfns.c, insdel.c:
1589 Omit unnecessary forward decls, to simplify future changes.
1590
1591 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1592
1593 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1594
1595 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1596 Use much-faster test for byte-length change.
1597 Don't assume string byte-length fits in 'int'.
1598 Check that character arg fits in 'int'.
1599 (mapcar1): Declare byte as byte, for clarity.
1600
1601 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1602
1603 * fns.c (concat): Catch string overflow earlier.
1604 Do not rely on integer wraparound.
1605
1606 * dispextern.h (struct it.overlay_strings_charpos)
1607 (struct it.selective): Now EMACS_INT, not int.
1608 * xdisp.c (forward_to_next_line_start)
1609 (back_to_previous_visible_line_start)
1610 (reseat_at_next_visible_line_start, next_element_from_buffer):
1611 Don't arbitrarily truncate the value of 'selective' to int.
1612
1613 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1614
1615 * composite.c: Don't truncate sizes to 'int'.
1616 (composition_gstring_p, composition_reseat_it)
1617 (composition_adjust_point): Use EMACS_INT, not int.
1618 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1619 not EMACS_UINT, for indexes.
1620
1621 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1622
1623 * buffer.c: Include <verify.h>.
1624 (struct sortvec.priority, struct sortstr.priority):
1625 Now EMACS_INT, not int.
1626 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1627 (struct sortstr.size, record_overlay_string)
1628 (struct sortstrlist.size, struct sortlist.used):
1629 Don't truncate size to int.
1630 (record_overlay_string): Check for size-calculation overflow.
1631 (init_buffer_once): Check at compile-time, not run-time.
1632
1633 2011-06-22 Jim Meyering <meyering@redhat.com>
1634
1635 Don't leak an XBM-image-sized buffer
1636 * image.c (xbm_load): Free the image buffer after using it.
1637
1638 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1639
1640 Port to Sun C.
1641 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1642 that Sun C diagnosed.
1643 * fns.c (secure_hash): Fix pointer signedness issue.
1644 * intervals.c (static_offset_intervals): New function.
1645 (offset_intervals): Use it.
1646
1647 2011-06-21 Leo Liu <sdl.web@gmail.com>
1648
1649 * deps.mk (fns.o):
1650 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1651 sha512.h.
1652
1653 * fns.c (secure_hash): Rename from crypto_hash_function and change
1654 the first arg to accept symbols.
1655 (Fsecure_hash): New primitive.
1656 (syms_of_fns): New symbols.
1657
1658 2011-06-20 Deniz Dogan <deniz@dogan.se>
1659
1660 * process.c (Fset_process_buffer): Clarify return value in
1661 docstring.
1662
1663 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1664
1665 * dispnew.c (add_window_display_history): Use BVAR.
1666
1667 * xdisp.c (debug_method_add): Use BVAR.
1668 (check_window_end, dump_glyph_matrix, dump_glyph)
1669 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1670
1671 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1672 Likewise.
1673
1674 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1675 check till after the cache is created in init_frame_faces.
1676
1677 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1678
1679 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1680
1681 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1682
1683 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1684 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1685 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1686
1687 Improve buffer-overflow checking (Bug#8873).
1688 * fileio.c (Finsert_file_contents):
1689 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1690 Remove the old (too-loose) buffer overflow checks.
1691 They weren't needed, since make_gap checks for buffer overflow.
1692 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1693 The old code merely checked for Emacs fixnum overflow, and relied
1694 on undefined (wraparound) behavior. The new code avoids undefined
1695 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1696
1697 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1698 Tune. Don't use wider integers than needed. Don't use alloca.
1699 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1700
1701 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1702
1703 * insdel.c, lisp.h (buffer_overflow): New function.
1704 (insert_from_buffer_1, replace_range, replace_range_2):
1705 * insdel.c (make_gap_larger):
1706 * editfns.c (Finsert_char):
1707 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1708
1709 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1710
1711 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1712
1713 Integer overflow and signedness fixes (Bug#8873).
1714
1715 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1716 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1717
1718 * fileio.c: Don't assume EMACS_INT fits in off_t.
1719 (emacs_lseek): New static function.
1720 (Finsert_file_contents, Fwrite_region): Use it.
1721 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1722
1723 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1724
1725 * fns.c: Don't overflow int when computing a list length.
1726 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1727 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1728 truncation on 64-bit hosts. Check for QUIT every
1729 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1730 faster and is responsive enough.
1731 (Flength): Report an error instead of overflowing an integer.
1732 (Fsafe_length): Return a float if the value is not representable
1733 as a fixnum. This shouldn't happen except in contrived situations.
1734 (Fnthcdr, Fsort): Don't assume list length fits in int.
1735 (Fcopy_sequence): Don't assume vector length fits in int.
1736
1737 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1738 (header_size, word_size): New constants.
1739 (allocate_vectorlike): Don't check size overflow here.
1740 (allocate_vector): Check it here instead, since this is the only
1741 caller of allocate_vectorlike that could cause overflow.
1742 Check that the new vector's length is representable as a fixnum.
1743
1744 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1745 The previous code was bogus. For example, next_almost_prime (32)
1746 returned 39, which is undesirable as it is a multiple of 3; and
1747 next_almost_prime (24) returned 25, which is a multiple of 5 so
1748 why was the code bothering to check for multiples of 7?
1749
1750 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1751
1752 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1753
1754 Variadic C functions now count arguments with ptrdiff_t.
1755 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1756 Back then I didn't know that the Emacs coding style prefers signed int.
1757 Also, in the meantime I found a few more instances where arguments
1758 were being counted with int, which may truncate counts on 64-bit
1759 machines, or EMACS_INT, which may be unnecessarily wide.
1760 * lisp.h (struct Lisp_Subr.function.aMANY)
1761 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1762 Arg counts are now ptrdiff_t, not size_t.
1763 All variadic functions and their callers changed accordingly.
1764 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1765 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1766 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1767 * callint.c (Fcall_interactively): Check arg count for overflow,
1768 to avoid potential buffer overrun. Use signed char, not 'int',
1769 for 'varies' array, so that we needn't bother to check its size
1770 calculation for overflow.
1771 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1772 * eval.c (apply_lambda):
1773 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1774 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1775 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1776
1777 * callint.c (Fcall_interactively): Don't use index var as event count.
1778
1779 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1780 * mem-limits.h (SIZE): Remove; no longer used.
1781
1782 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1783
1784 Remove unnecessary casts.
1785 * xterm.c (x_term_init):
1786 * xfns.c (x_set_border_pixel):
1787 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1788 These aren't needed now that we assume ANSI C.
1789
1790 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1791 It's more likely to cause problems (due to unsigned overflow)
1792 than to cure them.
1793
1794 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1795
1796 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1797
1798 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1799
1800 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1801
1802 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1803
1804 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1805
1806 GLYPH_CODE_FACE returns EMACS_INT, not int.
1807 * dispextern.h (merge_faces):
1808 * xfaces.c (merge_faces):
1809 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1810 Don't assume EMACS_INT fits in int.
1811
1812 * character.h (CHAR_VALID_P): Remove unused parameter.
1813 * fontset.c, lisp.h, xdisp.c: All uses changed.
1814
1815 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1816
1817 * fns.c (concat): Minor tuning based on overflow analysis.
1818 This doesn't fix any bugs. Use int to hold character, instead
1819 of constantly refetching from Emacs object. Use XFASTINT, not
1820 XINT, for value known to be a character. Don't bother comparing
1821 a single byte to 0400, as it's always less.
1822
1823 * floatfns.c (Fexpt):
1824 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1825
1826 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1827 for characters.
1828
1829 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1830
1831 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1832 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1833 incorrectly succeed when S was a string, because 4294967386 was
1834 truncated before it was used.
1835
1836 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1837 Otherwise, an out-of-range integer could cause undefined behavior
1838 on a 64-bit host.
1839
1840 * composite.c: Use int, not EMACS_INT, for characters.
1841 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1842 EMACS_INT, for values that are known to be in character range.
1843 This doesn't fix any bugs but is the usual style inside Emacs and
1844 may generate better code on 32-bit machines.
1845
1846 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1847 This is for reasons similar to the recent CHAR_STRING fix.
1848 * charset.c (Fencode_char): Check that character arg is actually
1849 a character. Pass an int to ENCODE_CHAR.
1850 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1851 wider than 'int', as a compile-time check to prevent future regressions
1852 in this area.
1853
1854 * character.c (char_string): Remove unnecessary casts.
1855
1856 Make sure a 64-bit char is never passed to CHAR_STRING.
1857 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1858 by silently ignoring the top 32 bits, allowing some values
1859 that were far too large to be valid characters.
1860 * character.h: Include <verify.h>.
1861 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1862 arguments are no wider than unsigned, as a compile-time check
1863 to prevent future regressions in this area.
1864 * data.c (Faset):
1865 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1866 (Fsubst_char_in_region):
1867 * fns.c (concat):
1868 * xdisp.c (decode_mode_spec_coding):
1869 Adjust to CHAR_STRING's new requirement.
1870 * editfns.c (Finsert_char, Fsubst_char_in_region):
1871 * fns.c (concat): Check that character args are actually
1872 characters. Without this test, these functions did the wrong
1873 thing with wildly out-of-range values on 64-bit hosts.
1874
1875 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1876 These casts should not be needed on 32-bit hosts, either.
1877 * keyboard.c (read_char):
1878 * lread.c (Fload): Remove casts to unsigned.
1879
1880 * lisp.h (UNSIGNED_CMP): New macro.
1881 This fixes comparison bugs on 64-bit hosts.
1882 (ASCII_CHAR_P): Use it.
1883 * casefiddle.c (casify_object):
1884 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1885 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1886 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1887 * dispextern.h (FACE_FROM_ID):
1888 * keyboard.c (read_char): Use UNSIGNED_CMP.
1889
1890 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1891 not to EMACS_INT, to avoid GCC warning.
1892
1893 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1894
1895 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1896 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1897 isn't needed on 32-bit machines.
1898
1899 * buffer.c (Fgenerate_new_buffer_name):
1900 Use EMACS_INT for count, not int.
1901 (advance_to_char_boundary): Return EMACS_INT, not int.
1902
1903 * data.c (Qcompiled_function): Now static.
1904
1905 * window.c (window_body_lines): Now static.
1906
1907 * image.c (gif_load): Rename local to avoid shadowing.
1908
1909 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1910 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1911 * alloc.c (make_save_value): Integer argument is now of type
1912 ptrdiff_t, not int.
1913 (mark_object): Use ptrdiff_t, not int.
1914 * lisp.h (pD): New macro.
1915 * print.c (print_object): Use it.
1916
1917 * alloc.c: Use EMACS_INT, not int, to count objects.
1918 (total_conses, total_markers, total_symbols, total_vector_size)
1919 (total_free_conses, total_free_markers, total_free_symbols)
1920 (total_free_floats, total_floats, total_free_intervals)
1921 (total_intervals, total_strings, total_free_strings):
1922 Now EMACS_INT, not int. All uses changed.
1923 (Fgarbage_collect): Compute overall total using a double, so that
1924 integer overflow is less likely to be a problem. Check for overflow
1925 when converting back to an integer.
1926 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1927 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1928 These were 'int' variables that could overflow on 64-bit hosts;
1929 they were never used, so remove them instead of repairing them.
1930 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1931 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1932 Previously, this ceilinged at INT_MAX, but that doesn't work on
1933 64-bit machines.
1934 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1935
1936 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1937 (allocate_vectorlike): Check for ptrdiff_t overflow.
1938 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1939 when a (possibly-narrower) signed value would do just as well.
1940 We prefer using signed arithmetic, to avoid comparison confusion.
1941
1942 * alloc.c: Catch some string size overflows that we were missing.
1943 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1944 for convenience in STRING_BYTES_MAX.
1945 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1946 The definition here is exact; the one in lisp.h was approximate.
1947 (allocate_string_data): Check for string overflow. This catches
1948 some instances we weren't catching before. Also, it catches
1949 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1950 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1951 and ptrdiff_t and EMACS_INT are both 64 bits.
1952
1953 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1954 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1955 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1956
1957 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1958
1959 * alloc.c (Fmake_string): Check for out-of-range init.
1960
1961 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1962
1963 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1964
1965 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1966
1967 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1968 xg_get_default_scrollbar_width.
1969
1970 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1971 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1972 (style_changed_cb): Call update_theme_scrollbar_width and call
1973 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1974 all frames (Bug#8505).
1975 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1976 Call gtk_window_set_resizable if HAVE_GTK3.
1977 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1978 and height if HAVE_GTK3 (Bug#8505).
1979 (scroll_bar_width_for_theme): New variable.
1980 (update_theme_scrollbar_width): New function.
1981 (xg_get_default_scrollbar_width): Move code to
1982 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1983 (xg_initialize): Call update_theme_scrollbar_width.
1984
1985 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1986
1987 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1988
1989 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1990
1991 * frame.c (make_frame): Call other_buffer_safely instead of
1992 other_buffer.
1993
1994 * window.c (temp_output_buffer_show): Call display_buffer with
1995 second argument Vtemp_buffer_show_specifiers and reset latter
1996 immediately after the call.
1997 (Vtemp_buffer_show_specifiers): New variable.
1998 (auto_window_vscroll_p, next_screen_context_lines)
1999 (Vscroll_preserve_screen_position): Remove leading asterisks from
2000 doc-strings.
2001
2002 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2003
2004 Fix minor problems found by GCC 4.6.0 static checking.
2005 * buffer.c (Qclone_number): Remove for now, as it's unused.
2006 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2007 (record_buffer): Remove unused local.
2008 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2009 (set_frame_buffer_list): Remove; unused.
2010 * frame.h (other_visible_frames): Remove decl.
2011 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2012 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2013 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2014 if HAVE_GPM.
2015 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2016 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2017 Define only if HAVE_GPM.
2018 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2019 (update_hints_inhibit): Remove; never set. All uses removed.
2020 * widgetprv.h (emacsFrameClassRec): Remove decl.
2021 * window.c (delete_deletable_window): Now returns void, since it
2022 wasn't returning anything.
2023 (compare_window_configurations): Remove unused locals.
2024 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2025 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2026 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2027 the same widths as pointers. This follows up on the 2011-05-06 patch.
2028 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2029 * xterm.h: Likewise.
2030 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2031
2032 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2033
2034 * makefile.w32-in: Update dependencies.
2035 (LISP_H): Add lib/intprops.h.
2036
2037 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2038
2039 * image.c (gif_load): Add animation frame delay to the metadata.
2040 (syms_of_image): Use DEFSYM. New symbol `delay'.
2041
2042 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2043
2044 * window.c (delete_deletable_window): Re-add.
2045 (Fset_window_configuration): Rewrite to handle dead buffers and
2046 consequently deletable windows.
2047 (window_tree, Fwindow_tree): Remove. Supply functionality in
2048 window.el.
2049 (compare_window_configurations): Simplify code.
2050
2051 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2052
2053 * image.c (imagemagick_load_image): Fix type mismatch.
2054 (Fimagemagick_types): Likewise.
2055
2056 * window.h (replace_buffer_in_windows): Declare.
2057
2058 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2059
2060 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2061 Qclone_number. Remove external declaration of Qdelete_window.
2062 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2063 code.
2064 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2065 Qbuffer_list_update_hook if allowed.
2066 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2067 buffer list implementation.
2068 (other_buffer_safely): New function.
2069 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2070 calls to replace_buffer_in_windows and
2071 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2072 if allowed.
2073 (record_buffer): Inhibit quitting and rewrite using quittable
2074 functions. Run Qbuffer_list_update_hook if allowed.
2075 (Frecord_buffer, Funrecord_buffer): New functions.
2076 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2077 switch-to-buffer to window.el.
2078 (bury-buffer): Move to window.el.
2079 (Vbuffer_list_update_hook): New variable.
2080
2081 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2082 section.
2083
2084 * window.h (resize_frame_windows): Move up in code.
2085 (Fwindow_frame): Remove EXFUN.
2086 (replace_buffer_in_all_windows): Remove prototype.
2087 (replace_buffer_in_windows_safely): Add prototype.
2088
2089 * window.c: Declare Qdelete_window static again. Move down
2090 declaration of select_count.
2091 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2092 (Fother_window): Move to window.el.
2093 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2094 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2095 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2096 window.el.
2097 (replace_buffer_in_windows): Implement by calling
2098 Qreplace_buffer_in_windows.
2099 (replace_buffer_in_all_windows): Remove with some functionality
2100 moved into replace_buffer_in_windows_safely.
2101 (replace_buffer_in_windows_safely): New function.
2102 (select_window_norecord, select_frame_norecord): Move in front
2103 of run_window_configuration_change_hook. Remove now obsolete
2104 declarations.
2105 (Fset_window_buffer): Rewrite doc-string. Call
2106 Qrecord_window_buffer.
2107 (keys_of_window): Move binding for other-window to window.el.
2108
2109 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2110
2111 * dispextern.h (struct image): Replace data member, whose int_val
2112 and ptr_val fields were not used by anything, with a single
2113 lisp_val object.
2114
2115 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2116 (gif_clear_image, gif_load, imagemagick_load_image)
2117 (gs_clear_image, gs_load): Callers changed.
2118
2119 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2120
2121 * buffer.h: Include <time.h>, for time_t.
2122 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2123
2124 Fix minor problems found by static checking.
2125
2126 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2127
2128 Make identifiers static if they are not used in other modules.
2129 * data.c (Qcompiled_function, Qframe, Qvector):
2130 * image.c (QimageMagick, Qsvg):
2131 * minibuf.c (Qmetadata):
2132 * window.c (resize_window_check, resize_root_window): Now static.
2133 * window.h (resize_window_check, resize_root_window): Remove decls.
2134
2135 * window.c (window_deletion_count, delete_deletable_window):
2136 Remove; unused.
2137 (window_body_lines): Now static.
2138 (Fdelete_other_windows_internal): Mark vars as initialized.
2139 Make sure 'resize_failed' is initialized.
2140 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2141 (resize_window_apply): Remove unused local.
2142 * window.h (delete_deletable_window): Remove decl.
2143
2144 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2145 (imagemagick_load_image): Fix pointer signedness problem by changing
2146 last arg from unsigned char * to char *. All uses changed.
2147 Also, fix a local for similar reasons.
2148 Remove unused locals. Remove locals to avoid shadowing.
2149 (fn_rsvg_handle_free): Remove; unused.
2150 (svg_load, svg_load_image): Fix pointer signedness problem.
2151 (imagemagick_load_image): Don't use garbage pointer image_wand.
2152
2153 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2154
2155 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2156
2157 * image.c (gif_load): Fix omitted cast error introduced by
2158 2011-06-06 change.
2159
2160 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2161
2162 * window.h (resize_proportionally, orig_total_lines)
2163 (orig_top_line): Remove from window structure.
2164 (set_window_height, set_window_width, change_window_heights)
2165 (Fdelete_window): Remove prototypes.
2166 (resize_frame_windows): Remove duplicate declaration.
2167
2168 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2169
2170 * window.h (resize_frame_windows, resize_window_check)
2171 (delete_deletable_window, resize_root_window)
2172 (resize_frame_windows): Declare prototypes.
2173
2174 * window.c (resize_window_apply): Make definition be "static" to
2175 match the prototype.
2176
2177 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2178
2179 * window.c: Remove declarations of Qwindow_size_fixed,
2180 window_min_size_1, window_min_size_2, window_min_size,
2181 size_window, window_fixed_size_p, enlarge_window, delete_window.
2182 Remove static from declaration of Qdelete_window, it's
2183 temporarily needed by Fbury_buffer.
2184 (replace_window): Don't assign orig_top_line and
2185 orig_total_lines.
2186 (Fdelete_window, delete_window): Remove. Window deletion is
2187 handled by window.el.
2188 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2189 Fdelete_window calls with calls to Qdelete_window.
2190 (Fdelete_other_windows): Remove. Deleting other windows is
2191 handled by window.el.
2192 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2193 handled in window.el.
2194 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2195 Window minimum sizes are handled in window.el.
2196 (shrink_windows, size_window, set_window_height)
2197 (set_window_width, change_window_heights, window_height)
2198 (window_width, CURBEG, CURSIZE, enlarge_window)
2199 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2200 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2201 handled in window.el.
2202 (make_dummy_parent): Rename to make_parent_window and give it a
2203 second argument horflag.
2204 (make_window): Don't set resize_proportionally any more.
2205 (Fsplit_window): Remove. Windows are split in window.el.
2206 (save_restore_action, save_restore_orig_size)
2207 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2208 Resize mini windows in window.el.
2209 (grow_mini_window, shrink_mini_window): Implement by calling
2210 Qresize_root_window_vertically, resize_window_check and
2211 resize_window_apply.
2212 (saved_window, Fset_window_configuration, save_window_save): Do
2213 not handle orig_top_line, orig_total_lines, and
2214 resize_proportionally.
2215 (window_min_height, window_min_width): Move to window.el.
2216 (keys_of_window): Move bindings for delete-other-windows,
2217 split-window, delete-window and enlarge-window to window.el.
2218
2219 * buffer.c: Temporarily extern Qdelete_window.
2220 (Fbury_buffer): Temporarily call Qdelete_window instead of
2221 Fdelete_window (Fbury_buffer will move to window.el soon).
2222
2223 * frame.c (set_menu_bar_lines_1): Remove code handling
2224 orig_top_line and orig_total_lines.
2225
2226 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2227 set_window_height but set heights directly.
2228 (change_frame_size_1): Use resize_frame_windows.
2229
2230 * xdisp.c (init_xdisp): Don't use set_window_height but set
2231 heights directly.
2232
2233 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2234 resize_frame_windows instead of change_window_heights and run
2235 run_window_configuration_change_hook.
2236
2237 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2238 instead of change_window_heights and run
2239 run_window_configuration_change_hook.
2240
2241 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2242
2243 * window.c (replace_window): Rename second argument REPLACEMENT to
2244 NEW. New third argument SETFLAG. Rewrite.
2245 (delete_window, make_dummy_parent): Call replace_window with
2246 third argument 1.
2247 (window_list_1): Move down in code.
2248 (run_window_configuration_change_hook): Move set_buffer part
2249 before select_frame_norecord part in order to unwind correctly.
2250 Rename count1 to count.
2251 (recombine_windows, delete_deletable_window, resize_root_window)
2252 (Fdelete_other_windows_internal)
2253 (Frun_window_configuration_change_hook, make_parent_window)
2254 (resize_window_check, resize_window_apply, Fresize_window_apply)
2255 (resize_frame_windows, Fsplit_window_internal)
2256 (Fdelete_window_internal, Fresize_mini_window_internal): New
2257 functions.
2258 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2259
2260 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2261
2262 * window.h (window): Add some new members to window structure -
2263 normal_lines, normal_cols, new_total, new_normal, clone_number,
2264 splits, nest, prev_buffers, next_buffers.
2265 (WINDOW_TOTAL_SIZE): Move here from window.c.
2266 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2267
2268 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2269 Remove.
2270 (make_dummy_parent): Set new members of windows structure.
2271 (make_window): Move down in code. Handle new members of window
2272 structure.
2273 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2274 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2275 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2276 (Fset_window_prev_buffers, Fwindow_next_buffers)
2277 (Fset_window_next_buffers, Fset_window_clone_number): New
2278 functions.
2279 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2280 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2281 Doc-string fixes.
2282 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2283 Argument WINDOW can be now internal window too.
2284 (Fwindow_use_time): Move up in code.
2285 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2286 Rewrite doc-string.
2287 (Fset_window_configuration, saved_window)
2288 (Fcurrent_window_configuration, save_window_save): Handle new
2289 members of window structure.
2290 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2291 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2292 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2293 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2294 Qget_mru_window, Qresize_root_window,
2295 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2296 Qauto_buffer_name; staticpro them.
2297
2298 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2299
2300 * window.c (Fwindow_total_size, Fwindow_left_column)
2301 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2302 (Fwindow_list_1): New functions.
2303 (window_box_text_cols): Replace with window_body_cols.
2304 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2305 window_body_cols instead of window_box_text_cols.
2306 (delete_window, Fset_window_configuration): Call
2307 delete_all_subwindows with window as argument.
2308 (delete_all_subwindows): Take a window as argument and not a
2309 structure. Rewrite.
2310 (window_loop): Remove handling of GET_LRU_WINDOW and
2311 GET_LARGEST_WINDOW.
2312 (Fget_lru_window, Fget_largest_window): Move to window.el.
2313
2314 * window.h: Extern window_body_cols instead of
2315 window_box_text_cols. delete_all_subwindows now takes a
2316 Lisp_Object as argument.
2317
2318 * indent.c (compute_motion, Fcompute_motion): Use
2319 window_body_cols instead of window_box_text_cols.
2320
2321 * frame.c (delete_frame): Call delete_all_subwindows with root
2322 window as argument.
2323
2324 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2325
2326 * fns.c (Fputhash): Document return value.
2327
2328 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2329
2330 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2331
2332 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2333
2334 Cons<->int and similar integer overflow fixes (Bug#8794).
2335
2336 Check for overflow when converting integer to cons and back.
2337 * charset.c (Fdefine_charset_internal, Fdecode_char):
2338 Use cons_to_unsigned to catch overflow.
2339 (Fencode_char): Use INTEGER_TO_CONS.
2340 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2341 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2342 * data.c (long_to_cons, cons_to_long): Remove.
2343 (cons_to_unsigned, cons_to_signed): New functions.
2344 These signal an error for invalid or out-of-range values.
2345 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2346 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2347 * font.c (Ffont_variation_glyphs):
2348 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2349 * lisp.h: Include <intprops.h>.
2350 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2351 (cons_to_signed, cons_to_unsigned): New decls.
2352 (long_to_cons, cons_to_long): Remove decls.
2353 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2354 (Fprimitive_undo): Use CONS_TO_INTEGER.
2355 * xfns.c (Fx_window_property): Likewise.
2356 * xselect.c: Include <limits.h>.
2357 (x_own_selection, selection_data_to_lisp_data):
2358 Use INTEGER_TO_CONS.
2359 (x_handle_selection_request, x_handle_selection_clear)
2360 (x_get_foreign_selection, Fx_disown_selection_internal)
2361 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2362 (lisp_data_to_selection_data): Use cons_to_unsigned.
2363 (x_fill_property_data): Use cons_to_signed.
2364 Report values out of range.
2365
2366 Check for buffer and string overflow more precisely.
2367 * buffer.h (BUF_BYTES_MAX): New macro.
2368 * lisp.h (STRING_BYTES_MAX): New macro.
2369 * alloc.c (Fmake_string):
2370 * character.c (string_escape_byte8):
2371 * coding.c (coding_alloc_by_realloc):
2372 * doprnt.c (doprnt):
2373 * editfns.c (Fformat):
2374 * eval.c (verror):
2375 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2376 since they may not be the same number.
2377 * editfns.c (Finsert_char):
2378 * fileio.c (Finsert_file_contents):
2379 Likewise for BUF_BYTES_MAX.
2380
2381 * image.c: Use ptrdiff_t, not int, for sizes.
2382 (slurp_file): Switch from int to ptrdiff_t.
2383 All uses changed.
2384 (slurp_file): Check that file size fits in both size_t (for
2385 malloc) and ptrdiff_t (for sanity and safety).
2386
2387 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2388 if b->modtime has its maximal value.
2389
2390 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2391
2392 Don't assume time_t can fit into int.
2393 * buffer.h (struct buffer.modtime): Now time_t, not int.
2394 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2395 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2396
2397 Minor fixes for signed vs unsigned integers.
2398 * character.h (MAYBE_UNIFY_CHAR):
2399 * charset.c (maybe_unify_char):
2400 * keyboard.c (read_char, reorder_modifiers):
2401 XINT -> XFASTINT, since the integer must be nonnegative.
2402 * ftfont.c (ftfont_spec_pattern):
2403 * keymap.c (access_keymap, silly_event_symbol_error):
2404 XUINT -> XFASTINT, since the integer must be nonnegative.
2405 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2406 since it makes no difference and we prefer signed.
2407 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2408 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2409 nonnegative.
2410
2411 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2412
2413 * window.h (Fwindow_frame): Declare.
2414
2415 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2418 (SPARE_MEMORY): Always define.
2419 (LARGE_REQUEST): Remove.
2420 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2421
2422 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2423
2424 * lisp.h: Move EXFUNS for Fframe_root_window,
2425 Fframe_first_window and Fset_frame_selected_window to window.h.
2426
2427 * window.h: Move EXFUNS for Fframe_root_window,
2428 Fframe_first_window and Fset_frame_selected_window here from
2429 lisp.h.
2430
2431 * frame.c (Fwindow_frame, Fframe_first_window)
2432 (Fframe_root_window, Fframe_selected_window)
2433 (Fset_frame_selected_window): Move to window.c.
2434 (Factive_minibuffer_window): Move to minibuf.c.
2435 (Fother_visible_frames_p): New function.
2436
2437 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2438
2439 * window.c (decode_window, decode_any_window): Move up in code.
2440 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2441 (inhibit_frame_unsplittable): Remove unused variable.
2442 (Fwindow_buffer): Move up and rewrite doc-string.
2443 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2444 (Fwindow_prev): New functions.
2445 (Fwindow_frame): Move here from frame.c. Accept any window as
2446 argument.
2447 (Fframe_root_window, Fframe_first_window)
2448 (Fframe_selected_window): Move here from frame.c. Accept frame
2449 or arbitrary window as argument. Update doc-strings.
2450 (Fminibuffer_window): Move up in code.
2451 (Fwindow_minibuffer_p): Move up in code and simplify.
2452 (Fset_frame_selected_window): Move here from frame.c.
2453 Marginal rewrite.
2454 (Fselected_window, select_window, Fselect_window): Move up in
2455 code. Minor doc-string fixes.
2456
2457 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2458
2459 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2460 Do not assume that spare memory exists; that assumption is valid
2461 only if SYSTEM_MALLOC.
2462 (LARGE_REQUEST): New macro, so that the issue of large requests
2463 is separated from the issue of spare memory.
2464
2465 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2466
2467 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2468 format. (Bug#8806)
2469
2470 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2471
2472 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2473 before statements.
2474
2475 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2476
2477 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2478
2479 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2480
2481 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2482 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2483
2484 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2485
2486 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2487
2488 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2489
2490 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2491 (x_clipboard_manager_save): Add return value.
2492 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2493 New error handlers.
2494 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2495 Obey Vx_select_enable_clipboard_manager. Catch errors in
2496 x_clipboard_manager_save (Bug#8779).
2497 (Vx_select_enable_clipboard_manager): New variable.
2498 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2499
2500 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2501
2502 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2503
2504 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2505
2506 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2507 in the current matrix if keep_current_p is non-zero.
2508
2509 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2510
2511 * bidi.c (bidi_level_of_next_char): Fix last change.
2512
2513 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2514
2515 Support bidi reordering of text covered by display properties.
2516
2517 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2518 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2519 (bidi_cache_search, bidi_cache_iterator_state)
2520 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2521 (bidi_level_of_next_char, bidi_move_to_visually_next):
2522 Support character positions inside a run of characters covered by a
2523 display string.
2524 (bidi_paragraph_init, bidi_resolve_explicit_1)
2525 (bidi_level_of_next_char): Call bidi_fetch_char and
2526 bidi_fetch_char_advance instead of FETCH_CHAR and
2527 FETCH_CHAR_ADVANCE.
2528 (bidi_init_it): Initialize new members.
2529 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2530 definitions.
2531 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2532 instead of using explicit *_CHAR codes.
2533 (bidi_resolve_explicit, bidi_resolve_weak):
2534 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2535 bidirectional text is supported only in multibyte buffers.
2536 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2537 it to initialize the frame_window_p member of struct bidi_it.
2538 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2539 (bidi_resolve_explicit, bidi_resolve_weak)
2540 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2541 bidi_it->nchars is non-positive.
2542 (bidi_level_of_next_char): Don't try to lookup the cache for the
2543 next/previous character if nothing is cached there yet, or if we
2544 were just reseat()'ed to a new position.
2545
2546 * xdisp.c (set_cursor_from_row): Set start and stop points
2547 according to the row's direction when priming the loop that looks
2548 for the glyph on which to display cursor.
2549 (single_display_spec_intangible_p): Function deleted.
2550 (display_prop_intangible_p): Reimplement to call
2551 handle_display_spec instead of single_display_spec_intangible_p.
2552 Accept 3 additional arguments needed by handle_display_spec.
2553 This fixes incorrect cursor motion across display property with complex
2554 values: lists, `(when COND...)' forms, etc.
2555 (single_display_spec_string_p): Support property values that are
2556 lists with the argument STRING its top-level element.
2557 (display_prop_string_p): Fix the condition for processing a
2558 property that is a list to be consistent with handle_display_spec.
2559 (handle_display_spec): New function, refactored from the
2560 last portion of handle_display_prop.
2561 (compute_display_string_pos): Accept additional argument
2562 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2563 value of a `display' property is a "replacing spec".
2564 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2565 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2566 the display property, but just return a value indicating whether
2567 the display property will replace the characters it covers.
2568 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2569 frame_window_p members of struct bidi_it.
2570 (compute_display_string_pos, compute_display_string_end):
2571 New functions.
2572 (push_it): Accept second argument POSITION, where pop_it should
2573 jump to continue iteration.
2574 (reseat_1): Initialize bidi_it.disp_pos.
2575
2576 * keyboard.c (adjust_point_for_property): Adjust the call to
2577 display_prop_intangible_p to its new signature.
2578
2579 * dispextern.h (struct bidi_it): New member frame_window_p.
2580 (bidi_init_it): Update prototypes.
2581 (display_prop_intangible_p): Update prototype.
2582 (compute_display_string_pos, compute_display_string_end):
2583 Declare prototypes.
2584 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2585 EMACS_INT.
2586
2587 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2588
2589 Malloc failure behavior now depends on size of allocation.
2590 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2591 * lisp.h: Change signatures accordingly.
2592 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2593 All callers changed. (Bug#8762)
2594
2595 * gnutls.c: Use Emacs's memory allocators.
2596 Without this change, the gnutls library would invoke malloc etc.
2597 directly, which causes problems on non-SYNC_INPUT hosts, and which
2598 runs afoul of improving memory_full behavior. (Bug#8761)
2599 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2600 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2601 xfree instead of the default malloc, realloc, free.
2602 (Fgnutls_boot): No need to check for memory allocation failure,
2603 since xmalloc does that for us.
2604
2605 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2606 * category.c (hash_get_category_set):
2607 * ccl.c (ccl_driver):
2608 * charset.c (Fdefine_charset_internal):
2609 * charset.h (struct charset.hash_index):
2610 * composite.c (get_composition_id, gstring_lookup_cache)
2611 (composition_gstring_put_cache):
2612 * composite.h (struct composition.hash_index):
2613 * dispextern.h (struct image.hash):
2614 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2615 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2616 (hashfn_equal, hashfn_user_defined, make_hash_table)
2617 (maybe_resize_hash_table, hash_lookup, hash_put)
2618 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2619 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2620 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2621 * image.c (make_image, search_image_cache, lookup_image)
2622 (xpm_put_color_table_h):
2623 * lisp.h (struct Lisp_Hash_Table):
2624 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2625 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2626 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2627 * alloc.c (allocate_vectorlike):
2628 Check for overflow in vector size calculations.
2629 * ccl.c (ccl_driver):
2630 Check for overflow when converting EMACS_INT to int.
2631 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2632 need to be updated by these changes.
2633 * fns.c (make_hash_table, maybe_resize_hash_table):
2634 Check for integer overflow with large hash tables.
2635 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2636 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2637 (SXHASH_REDUCE): New macro.
2638 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2639 Use it instead of discarding useful hash info with large hash values.
2640 (sxhash_float): New function.
2641 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2642 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2643 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2644 Rewrite to use FIXNUM_BITS, as this simplifies things.
2645 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2646 Adjust signatures to match updated version of code.
2647 (consing_since_gc): Now EMACS_INT, since a single hash table can
2648 use more than INT_MAX bytes.
2649
2650 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2651
2652 Make it possible to build with GCC-4.6+ -O2 -flto.
2653
2654 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2655
2656 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2657
2658 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2659 Call minibuffer-inactive-mode.
2660
2661 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2662
2663 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2664 Update dependencies.
2665
2666 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2667
2668 * data.c (init_data): Remove code for UTS, this system is not
2669 supported anymore.
2670
2671 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2672
2673 Don't force ./temacs to start in terminal mode.
2674
2675 * frame.c (make_initial_frame): Initialize faces in all cases, not
2676 only when CANNOT_DUMP is defined.
2677 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2678
2679 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2680
2681 * dispnew.c (add_window_display_history): Use const for the string
2682 pointer. Remove declaration, not needed.
2683
2684 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2685
2686 Use 'inline', not 'INLINE'.
2687 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2688 * alloc.c, fontset.c (INLINE): Remove.
2689 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2690 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2691 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2692 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2693 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2694
2695 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2696
2697 Make it possible to run ./temacs.
2698
2699 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2700 syms_of_callproc does the same thing. Remove test for
2701 "initialized", do it in the caller.
2702 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2703
2704 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2705
2706 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2707 (read_minibuf): Use get_minibuffer.
2708 (syms_of_minibuf): Use DEFSYM.
2709 (Qmetadata): New var.
2710 * data.c (Qbuffer): Don't make it static.
2711 (syms_of_data): Use DEFSYM.
2712
2713 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2714
2715 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2716 (CCL_CODE_MIN): New macro.
2717
2718 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2719
2720 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2721
2722 * eval.c (Qdebug): Now static.
2723 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2724 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2725 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2726
2727 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2728
2729 * image.c: Various fixes to ImageMagick code comments.
2730 (Fimagemagick_types): Doc fix.
2731
2732 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2733
2734 Minor fixes prompted by GCC 4.6.0 warnings.
2735
2736 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2737
2738 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2739 (x_clipboard_manager_save_all): Move extern decl to ...
2740 * xterm.h: ... here, so that it can be checked for consistency.
2741
2742 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2743
2744 * xselect.c (x_clipboard_manager_save_frame)
2745 (x_clipboard_manager_save_all): New functions.
2746 (Fx_clipboard_manager_save): Lisp function deleted.
2747
2748 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2749 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2750
2751 * xterm.h: Update prototype.
2752
2753 2011-05-28 William Xu <william.xwl@gmail.com>
2754
2755 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2756 exiting (Bug#8239).
2757
2758 2011-05-28 Jim Meyering <meyering@redhat.com>
2759
2760 Avoid a sign-extension bug in crypto_hash_function.
2761 * fns.c (to_uchar): Define.
2762 (crypto_hash_function): Use it to convert some newly-signed
2763 variables to unsigned, to avoid sign-extension bugs. For example,
2764 without this change, (md5 "truc") would evaluate to
2765 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2766 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2767 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2768
2769 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2770
2771 Integer overflow fixes.
2772
2773 * dbusbind.c: Serial number integer overflow fixes.
2774 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2775 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2776 to hold a serial number that is too large for a fixnum.
2777 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2778 Check for serial numbers out of range. Decode any serial number
2779 that was so large that it became a float. (Bug#8722)
2780
2781 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2782 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2783 Use XFASTINT rather than XUINT when numbers are nonnegative.
2784 (xd_append_arg, Fdbus_method_return_internal):
2785 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2786 arguments, check that Lisp number is nonnegative, rather than
2787 silently wrapping negative numbers around. (Bug#8722)
2788 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2789 (Bug#8722)
2790
2791 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2792
2793 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2794
2795 ccl: add integer overflow checks
2796 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2797 (IN_INT_RANGE): New macros.
2798 (ccl_driver): Use them to check for integer overflow when
2799 decoding a CCL program. Many of the new checks are whether XINT (x)
2800 fits in int; it doesn't always, on 64-bit hosts. The new version
2801 doesn't catch all possible integer overflows, but it's an
2802 improvement. (Bug#8719)
2803
2804 * alloc.c (make_event_array): Use XINT, not XUINT.
2805 There's no need for unsigned here.
2806
2807 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2808 This follows up to the 2011-05-06 change that substituted uintptr_t
2809 for EMACS_INT. This case wasn't caught back then.
2810
2811 Rework Fformat to avoid integer overflow issues.
2812 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2813 now (part of C89). Include <verify.h>.
2814 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2815 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2816 (Fformat): Avoid the prepass trying to compute sizes; it was only
2817 approximate and thus did not catch overflow reliably. Instead, walk
2818 through the format just once, formatting and computing sizes as we go,
2819 checking for integer overflow at every step, and allocating a larger
2820 buffer as needed. Keep track separately whether the format is
2821 multibyte. Keep only the most-recently calculated precision, rather
2822 than them all. Record whether each argument has been converted to
2823 string. Use EMACS_INT, not int, for byte and char and arg counts.
2824 Support field widths and precisions larger than INT_MAX. Avoid
2825 sprintf's undefined behavior with conversion specifications such as %#d
2826 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2827 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2828 formatting out-of-range floating point numbers with int
2829 formats. (Bug#8668)
2830
2831 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2832
2833 * data.c: Avoid integer truncation in expressions involving floats.
2834 * data.c: Include <intprops.h>.
2835 (arith_driver): When there's an integer overflow in an expression
2836 involving floating point, convert the integers to floating point
2837 so that the resulting value does not suffer from catastrophic
2838 integer truncation. For example, on a 64-bit host (* 4
2839 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2840 Do not rely on undefined behavior after integer overflow.
2841
2842 merge count_size_as_multibyte, parse_str_to_multibyte
2843 * character.c, character.h (count_size_as_multibyte):
2844 Rename from parse_str_to_multibyte; all uses changed.
2845 Check for integer overflow.
2846 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2847 since it's now a duplicate of the other. This is more of
2848 a character than a buffer op, so better that it's in character.c.
2849 * fns.c, print.c: Adjust to above changes.
2850
2851 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2852
2853 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2854
2855 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2856
2857 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2858 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2859 (x_clipboard_manager_save): Now static.
2860 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2861
2862 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2863 (crypto_hash_function): Now static.
2864 Fix pointer signedness problems. Avoid unnecessary initializations.
2865
2866 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2867
2868 * termhooks.h (Vselection_alist): Make it terminal-local.
2869
2870 * terminal.c (create_terminal): Initialize it.
2871
2872 * xselect.c: Support for clipboard managers.
2873 (Vselection_alist): Move to termhooks.h as terminal-local var.
2874 (LOCAL_SELECTION): New macro.
2875 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2876 (symbol_to_x_atom): Remove gratuitous arg.
2877 (x_handle_selection_request, lisp_data_to_selection_data)
2878 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2879 (x_own_selection, x_get_local_selection, x_convert_selection):
2880 New arg, specifying work frame. Use terminal-local Vselection_alist.
2881 (some_frame_on_display): Delete unused function.
2882 (Fx_own_selection_internal, Fx_get_selection_internal)
2883 (Fx_disown_selection_internal, Fx_selection_owner_p)
2884 (Fx_selection_exists_p): New optional frame arg.
2885 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2886 (x_handle_selection_clear): Don't treat other terminals with the
2887 same keyboard specially. Use the terminal-local Vselection_alist.
2888 (x_clear_frame_selections): Use Frun_hook_with_args.
2889
2890 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2891
2892 * xterm.h: Add support for those atoms.
2893
2894 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2895
2896 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2897 (converted_selections, conversion_fail_tag): New global variables.
2898 (x_selection_request_lisp_error): Free the above.
2899 (x_get_local_selection): Remove unnecessary code.
2900 (x_reply_selection_request): Args changed; handle arbitrary array
2901 of converted selections stored in converted_selections.
2902 Separate the XChangeProperty and SelectionNotify steps.
2903 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2904 (x_convert_selection): New function.
2905 (x_handle_selection_event): Simplify.
2906 (x_get_foreign_selection): Don't ignore incoming requests while
2907 waiting for an answer; this will fail when we implement
2908 SAVE_TARGETS, and seems unnecessary anyway.
2909 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2910 (Vx_sent_selection_functions): Doc fix.
2911
2912 2011-05-26 Leo Liu <sdl.web@gmail.com>
2913
2914 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2915
2916 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2917
2918 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2919
2920 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2921 for fringe update if it has periodic bitmap.
2922 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2923 and fringe_bitmap_periodic_p.
2924
2925 * fringe.c (get_fringe_bitmap_data): New function.
2926 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2927 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2928 row. Mark glyph row for fringe update if periodicity changed.
2929
2930 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2931 for fringe update unless it has periodic bitmap.
2932
2933 2011-05-25 Kenichi Handa <handa@m17n.org>
2934
2935 * xdisp.c (get_next_display_element): Set correct it->face_id for
2936 a static composition.
2937
2938 2011-05-24 Leo Liu <sdl.web@gmail.com>
2939
2940 * deps.mk (fns.o):
2941 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2942
2943 * fns.c (crypto_hash_function, Fsha1): New function.
2944 (Fmd5): Use crypto_hash_function.
2945 (syms_of_fns): Add Ssha1.
2946
2947 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2948
2949 * gnutls.c: Remove unused macros.
2950 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2951 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2952 Remove macros that are defined and never used.
2953 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2954
2955 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2956
2957 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2958 (Fx_get_selection_internal): Minor cleanup.
2959 (Fx_own_selection_internal): Rename arguments for consistency with
2960 select.el.
2961
2962 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2963
2964 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2965
2966 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2967
2968 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2969
2970 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2971
2972 * dispnew.c (scrolling_window): Don't exclude the case that the
2973 last enabled row in the desired matrix touches the bottom boundary.
2974
2975 2011-05-21 Glenn Morris <rgm@gnu.org>
2976
2977 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2978 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2979 and add some more files.
2980
2981 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2982
2983 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2984 report_file_error introduced by the change from 2011-05-07.
2985
2986 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2987
2988 * systime.h (Time): Define only if emacs is defined.
2989 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2990 where the include path doesn't have X11/X.h by default. See
2991 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2992
2993 2011-05-20 Kenichi Handa <handa@m17n.org>
2994
2995 * composite.c (find_automatic_composition): Fix previous change.
2996
2997 2011-05-20 Glenn Morris <rgm@gnu.org>
2998
2999 * lisp.mk: New file, split from Makefile.in.
3000 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3001 (shortlisp): Remove.
3002 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3003
3004 2011-05-19 Glenn Morris <rgm@gnu.org>
3005
3006 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3007 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3008 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3009 (lisp): Set the order to that of loadup.el.
3010 (shortlisp): Make it a copy of $lisp.
3011 (SOME_MACHINE_LISP): Remove.
3012 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3013 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3014
3015 2011-05-18 Kenichi Handa <handa@m17n.org>
3016
3017 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3018 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3019 (find_automatic_composition): Mostly rewrite for efficiency.
3020
3021 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3022
3023 * makefile.w32-in: Update dependencies.
3024
3025 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3026
3027 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3028 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3029
3030 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 Fix some integer overflow issues, such as string length overflow.
3033
3034 * insdel.c (count_size_as_multibyte): Check for string overflow.
3035
3036 * character.c (lisp_string_width): Check for string overflow.
3037 Use EMACS_INT, not int, for string indexes and lengths; in
3038 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3039 the resulting string length overflows an EMACS_INT; instead,
3040 report a string overflow if no precision given. When checking for
3041 precision exhaustion, use a check that cannot possibly have
3042 integer overflow. (Bug#8675)
3043 * character.h (lisp_string_width): Adjust to new signature.
3044
3045 * alloc.c (string_overflow): New function.
3046 (Fmake_string): Use it. This doesn't change behavior, but saves
3047 a few bytes and will simplify future changes.
3048 * character.c (string_escape_byte8): Likewise.
3049 * lisp.h (string_overflow): New decl.
3050
3051 Fixups, following up to the user-interface timestamp change.
3052 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3053 for UI timestamps, instead of unsigned long.
3054 * msdos.c (mouse_get_pos): Likewise.
3055 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3056 * w32gui.h (Time): Define by including "systime.h" rather than by
3057 declaring it ourselves. (Bug#8664)
3058
3059 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3060 * image.c (clear_image_cache): Likewise.
3061
3062 * term.c (term_mouse_position): Don't assume time_t wraparound.
3063
3064 Be more systematic about user-interface timestamps.
3065 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3066 and sometimes 'EMACS_UINT', to represent these timestamps.
3067 This change causes it to use 'Time' uniformly, as that's what X uses.
3068 This makes the code easier to follow, and makes it easier to catch
3069 integer overflow bugs such as Bug#8664.
3070 * frame.c (Fmouse_position, Fmouse_pixel_position):
3071 Use Time, not unsigned long, for user-interface timestamps.
3072 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3073 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3074 * keyboard.h (last_event_timestamp): Likewise.
3075 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3076 * menu.h (xmenu_show): Likewise.
3077 * term.c (term_mouse_position): Likewise.
3078 * termhooks.h (struct input_event.timestamp): Likewise.
3079 (struct terminal.mouse_position_hook): Likewise.
3080 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3081 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3082 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3083 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3084 what it was before.
3085 * menu.h, termhooks.h: Include "systime.h", for Time.
3086
3087 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3088 Don't assume that the difference between two unsigned long values
3089 can fit into an integer. At this point, we know button_down_time
3090 <= event->timestamp, so the difference must be nonnegative, so
3091 there's no need to cast the result if double-click-time is
3092 nonnegative, as it should be; check that it's nonnegative, just in
3093 case. This bug is triggered when events are more than 2**31 ms
3094 apart (about 25 days). (Bug#8664)
3095
3096 * xselect.c (last_event_timestamp): Remove duplicate decl.
3097 (x_own_selection): Remove needless cast to unsigned long.
3098
3099 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3100 that always fit in int. Use a sentinel instead of a counter, to
3101 avoid a temp and to allay GCC's concerns about possible int overflow.
3102 * frame.h (struct frame): Use int for menu_bar_items_used
3103 instead of EMACS_INT, since it always fits in int.
3104
3105 * menu.c (grow_menu_items): Check for int overflow.
3106
3107 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3108
3109 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3110 Before, the code was not consistent. These values cannot exceed
3111 2**31 - 1 so there's no need to make them unsigned.
3112 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3113 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3114 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3115 as modifiers.
3116 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3117
3118 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3119 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3120 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3121 presumably because the widths might not match.
3122
3123 * window.c (size_window): Avoid needless test at loop start.
3124
3125 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3126
3127 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3128
3129 2011-05-12 Drew Adams <drew.adams@oracle.com>
3130
3131 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3132
3133 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3134
3135 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3136 `width' to `bar_area_x' and `bar_area_width', respectively.
3137 (x_scroll_run): Take account of fringe background extension.
3138
3139 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3140 Rename local vars `left' and `width' to `bar_area_x' and
3141 `bar_area_width', respectively.
3142 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3143 background extension.
3144
3145 2011-05-10 Jim Meyering <meyering@redhat.com>
3146
3147 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3148
3149 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3150
3151 * image.c (Finit_image_library): Return t for built-in image types,
3152 like pbm and xbm. (Bug#8640)
3153
3154 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3155
3156 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3157
3158 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3159
3160 * w32console.c (Fset_screen_color): Doc fix.
3161 (Fget_screen_color): New function.
3162 (syms_of_ntterm): Defsubr it.
3163
3164 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3165 unlink the temporary file if Fcall_process didn't create it in the
3166 first place.
3167 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3168 child process will be redirected to a file specified with `:file'.
3169 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3170 cue to call_process_cleanup not to close that handle.
3171
3172 2011-05-07 Ben Key <bkey76@gmail.com>
3173
3174 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3175 one of two shell specific rules, either bootstrap-temacs-CMD or
3176 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3177 to the previous implementation of the bootstrap-temacs rule.
3178 The bootstrap-temacs-CMD rule is similar to the previous
3179 implementation of the bootstrap-temacs rule except that it
3180 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3181 variable.
3182
3183 These changes, along with some changes to nt/configure.bat,
3184 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3185 earlier fix to add support for --cflags and --ldflags options
3186 that include quotes so that it works whether make uses cmd or
3187 sh as the shell.
3188
3189 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3190
3191 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3192 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3193 is a constant.
3194 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3195 a string. Handle both cases.
3196 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3197 (Fdbus_register_method): Use Qinvalid_function.
3198
3199 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3200
3201 * makefile.w32-in: Update dependencies.
3202 (LISP_H): Add inttypes.h and stdin.h.
3203 (PROCESS_H): Add unistd.h.
3204
3205 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3206
3207 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3208 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3209
3210 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3213
3214 * term.c (vfatal): Remove stray call to va_end.
3215 It's not needed and the C Standard doesn't allow it here anyway.
3216
3217 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3218 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3219
3220 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3221 bytes.
3222
3223 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3224
3225 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3226
3227 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3228
3229 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3230
3231 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3232
3233 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3234 * charset.c (Fdefine_charset_internal): Don't initialize
3235 charset.code_space[15]. The value was garbage, on hosts with
3236 32-bit int (Bug#8600).
3237
3238 * lread.c (read_integer): Be more consistent with string-to-number.
3239 Use string_to_number to do the actual conversion; this avoids
3240 rounding errors and fixes some other screwups. Without this fix,
3241 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3242 (digit_to_number): Move earlier, for benefit of read_integer.
3243 Return -1 if the digit is out of range for the base, -2 if it is
3244 not a digit in any supported base. (Bug#8602)
3245
3246 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3247
3248 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3249 to match comment at start of function. This also removes a
3250 GCC warning about overflow in a 32+64-bit port.
3251
3252 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3253
3254 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3255 Reported by Stefan Monnier in
3256 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3257 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3258 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3259
3260 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3261 (EMACS_UINTPTR): Likewise, with uintptr_t.
3262
3263 * lisp.h: Prefer 64-bit EMACS_INT if available.
3264 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3265 on 32-bit hosts that have 64-bit int, so that they can access
3266 large files.
3267 However, temporarily disable this change unless the temporary
3268 symbol WIDE_EMACS_INT is defined.
3269
3270 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3271
3272 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3273 This removes an assumption that EMACS_INT and long are the same
3274 width as pointers. The assumption is true for Emacs porting targets
3275 now, but we want to make other targets possible.
3276 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3277 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3278 In the rest of the code, change types of integers that hold casted
3279 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3280 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3281 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3282 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3283 No need to cast type when ORing.
3284 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3285 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3286 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3287 assume EMACS_INT is the same width as char *.
3288 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3289 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3290 Remove no-longer-needed casts.
3291 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3292 (xg_tool_bar_help_callback, xg_make_tool_item):
3293 Use EMACS_INTPTR to hold an integer
3294 that will be cast to void *; this can avoid a GCC warning
3295 if EMACS_INT is not the same width as void *.
3296 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3297 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3298 (current_message_1, set_message_1):
3299 Use a local to convert to proper width without a cast.
3300 * xmenu.c (dialog_selection_callback): Likewise.
3301
3302 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3303 Also, don't assume VALBITS / RAND_BITS is less than 5,
3304 and don't rely on undefined behavior when shifting a 1 left into
3305 the sign bit.
3306 * lisp.h (get_random): Change signature to match.
3307
3308 * lread.c (hash_string): Use size_t, not int, for hash computation.
3309 Normally we prefer signed values; but hashing is special, because
3310 it's better to use unsigned division on hash table sizes so that
3311 the remainder is nonnegative. Also, size_t is the natural width
3312 for hashing into memory. The previous code used 'int', which doesn't
3313 retain enough info to hash well into very large tables.
3314 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3315
3316 * dbusbind.c: Don't possibly lose pointer info when converting.
3317 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3318 Use XPNTR rather than XHASH, so that the high-order bits of
3319 the pointer aren't lost when converting through void *.
3320
3321 * eval.c (Fautoload): Don't double-shift a pointer.
3322
3323 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3324
3325 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3326
3327 * gnutls.c (DEF_GNUTLS_FN):
3328 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3329
3330 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3331
3332 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3333 marker. (Bug#8610)
3334
3335 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3336
3337 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3338 New version that can reserve upto 2GB of heap space.
3339
3340 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3341
3342 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3343
3344 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3345
3346 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3347 `gnutls_certificate_set_x509_key_file'.
3348
3349 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3350
3351 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3352 Update dependencies.
3353
3354 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3355
3356 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3357 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3358 Remove unused parameter `fildes'.
3359 * process.c (read_process_output, send_process): Don't pass it.
3360
3361 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3362
3363 Fix previous change: the library cache is defined in w32.c.
3364 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3365 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3366
3367 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3368
3369 Implement dynamic loading of GnuTLS on Windows.
3370
3371 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3372 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3373 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3374 Declare.
3375
3376 * gnutls.c (Qgnutls_dll): Define.
3377 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3378 (gnutls_*): Declare function pointers.
3379 (init_gnutls_functions): New function to initialize function pointers.
3380 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3381 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3382 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3383 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3384 (emacs_gnutls_write, emacs_gnutls_read)
3385 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3386 (Fgnutls_available_p): New function.
3387 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3388 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3389 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3390
3391 * image.c: Include w32.h.
3392 (Vimage_type_cache): Delete.
3393 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3394 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3395 (w32_delayed_load): Move to w32.c.
3396
3397 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3398
3399 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3400 (w32_delayed_load): Move from image.c. When loading a library, record
3401 its filename in the :loaded-from property of the library id.
3402 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3403 Initialize and staticpro them.
3404 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3405
3406 * process.c: Include lisp.h before w32.h, not after.
3407 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3408 instead of gnutls_record_check_pending.
3409
3410 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3411
3412 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3413
3414 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3415 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3416 as passed in.
3417
3418 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3419
3420 * xterm.c (x_set_frame_alpha): Do not set property on anything
3421 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3422
3423 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3424
3425 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3426
3427 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3428
3429 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3430 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3431 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3432 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3433 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3434 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3435 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3436 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3437 (Qgnutls_bootprop_callbacks_verify): Make static.
3438
3439 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3440
3441 * callproc.c: Indentation fixup.
3442
3443 * sysdep.c (wait_for_termination_1): Make static.
3444 (wait_for_termination, interruptible_wait_for_termination):
3445 Move after wait_for_termination_1.
3446
3447 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3448
3449 * sysdep.c (interruptible_wait_for_termination): New function
3450 which is like wait_for_termination, but allows keyboard
3451 interruptions.
3452
3453 * callproc.c (Fcall_process): Add (:file "file") as an option for
3454 the STDOUT buffer.
3455 (Fcall_process_region): Ditto.
3456
3457 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3458
3459 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3460 rather than `XVECTOR (FOO)->size'.
3461
3462 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3463 inttypes.h, as a gnulib replacement is used if it not available in
3464 system headers.
3465
3466 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3467
3468 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3469 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3470 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3471
3472 * coding.c (coding_alloc_by_realloc): Error out if destination
3473 will grow beyond MOST_POSITIVE_FIXNUM.
3474 (decode_coding_emacs_mule): Abort if there isn't enough place in
3475 charbuf for the composition carryover bytes. Reserve an extra
3476 space for up to 2 characters produced in a loop.
3477 (decode_coding_iso_2022): Abort if there isn't enough place in
3478 charbuf for the composition carryover bytes.
3479
3480 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3481
3482 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3483 aborting when %lld or %lll format is passed.
3484 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3485 %llo or %llx format is passed. (Bug#8545)
3486
3487 * window.c (window_scroll_line_based): Use a marker instead of
3488 simple variables to record original value of point. (Bug#7952)
3489
3490 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3491 produced by %s or %c overflows available buffer space. (Bug#8545)
3492
3493 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3494
3495 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3496 (SIZE_MAX): Move defn after all includes, as they might #define it.
3497
3498 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3499
3500 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3501
3502 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3503
3504 * keyboard.c (Qdelayed_warnings_hook): Define.
3505 (command_loop_1): Run `delayed-warnings-hook'
3506 if Vdelayed_warnings_list is non-nil.
3507 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3508 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3509
3510 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3511
3512 * doprnt.c (doprnt): Don't return value smaller than the buffer
3513 size if the message was truncated. (Bug#8545).
3514
3515 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3516
3517 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3518 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3519
3520 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3523
3524 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3525
3526 * makefile.w32-in: Update dependencies.
3527
3528 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3529
3530 Improve `doprnt' and its usage. (Bug#8545)
3531 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3532 `format_end'. Remove support for %l as a conversion specifier.
3533 Don't use xrealloc. Improve diagnostics when the %l size modifier
3534 is used. Update the commentary.
3535
3536 * eval.c (verror): Simplify calculation of size_t.
3537
3538 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3539 messages.
3540
3541 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3542
3543 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3544 change.
3545
3546 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3547
3548 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3549 This makes this file independent of the recent pseudovector change.
3550
3551 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3552
3553 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3554
3555 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3556 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3557 Remove unused local.
3558 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3559
3560 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3561 GCC 4.6.0 optimizes based on type-based alias analysis.
3562 For example, if b is of type struct buffer * and v of type struct
3563 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3564 != &v->size, and therefore "v->size = 1; b->size = 2; return
3565 v->size;" must therefore return 1. This assumption is incorrect
3566 for Emacs, since it type-puns struct Lisp_Vector * with many other
3567 types. To fix this problem, this patch adds a new type struct
3568 vectorlike_header that documents the constraints on layout of vectors
3569 and pseudovectors, and helps optimizing compilers not get fooled
3570 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3571 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3572 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3573 the size member.
3574 (XSETPVECTYPE): Rewrite in terms of new macro.
3575 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3576 This is a bit clearer, and further avoids the possibility of
3577 undesirable aliasing.
3578 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3579 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3580 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3581 since Lisp_Subr is a special case (no "next" field).
3582 (ASIZE): Now uses header.size rather than size.
3583 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3584 to avoid the hassle of writing XVECTOR (foo)->header.size.
3585 (struct vectorlike_header): New type.
3586 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3587 object, to help avoid aliasing.
3588 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3589 (SUBRP): Likewise, since Lisp_Subr is a special case.
3590 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3591 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3592 (struct Lisp_Hash_Table): Combine first two members into a single
3593 struct vectorlike_header member. All uses of "size" and "next" members
3594 changed to be "header.size" and "header.next".
3595 * buffer.h (struct buffer): Likewise.
3596 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3597 * frame.h (struct frame): Likewise.
3598 * process.h (struct Lisp_Process): Likewise.
3599 * termhooks.h (struct terminal): Likewise.
3600 * window.c (struct save_window_data, struct saved_window): Likewise.
3601 * window.h (struct window): Likewise.
3602 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3603 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3604 * buffer.c (init_buffer_once): Likewise.
3605 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3606 special case.
3607 * process.c (Fformat_network_address): Use local var for size,
3608 for brevity.
3609
3610 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3611
3612 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3613 * data.c (atof): Remove decl; no longer used or needed.
3614 (digit_to_number): Move to lread.c.
3615 (Fstring_to_number): Use new string_to_number function, to be
3616 consistent with how the Lisp reader treats infinities and NaNs.
3617 Do not assume that floating-point numbers represent EMACS_INT
3618 without losing information; this is not true on most 64-bit hosts.
3619 Avoid double-rounding errors, by insisting on integers when
3620 parsing non-base-10 numbers, as the documentation specifies.
3621 * lisp.h (string_to_number): New decl, replacing ...
3622 (isfloat_string): Remove.
3623 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3624 (read1): Do not accept +. and -. as integers; this
3625 appears to have been a coding error. Similarly, do not accept
3626 strings like +-1e0 as floating point numbers. Do not report
3627 overflow for integer overflows unless the base is not 10 which
3628 means we have no simple and reliable way to continue.
3629 Break out the floating-point parsing into a new
3630 function string_to_number, so that Fstring_to_number parses
3631 floating point numbers consistently with the Lisp reader.
3632 (digit_to_number): Move here from data.c. Make it static inline.
3633 (E_CHAR, EXP_INT): Remove, replacing with ...
3634 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3635 (string_to_number): New function, replacing isfloat_string.
3636 This function checks for valid syntax and produces the resulting
3637 Lisp float number too. Rework it so that string-to-number
3638 no longer mishandles examples like "1.0e+". Use strtoumax,
3639 so that overflow for non-base-10 numbers is reported only when
3640 there's no portable and simple way to convert to floating point.
3641
3642 * textprop.c (set_text_properties_1): Rewrite for clarity,
3643 and to avoid GCC warning about integer overflow.
3644
3645 * intervals.h (struct interval): Use EMACS_INT for members
3646 where EMACS_UINT might cause problems. See
3647 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3648 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3649 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3650 All uses changed.
3651 (offset_intervals): Tell GCC not to worry about length overflow
3652 when negating a negative length.
3653
3654 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3655 (overrun_check_free): Likewise.
3656
3657 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3658 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3659 word size.
3660
3661 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3662 (gnutls_make_error): Rename local to avoid shadowing.
3663 (gnutls_emacs_global_deinit): ifdef out; not used.
3664 (Fgnutls_boot): Use const for pointer to readonly storage.
3665 Comment out unused local. Fix pointer signedness problems.
3666
3667 * lread.c (openp): Don't stuff size_t into an 'int'.
3668 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3669 about possible signed overflow.
3670
3671 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3672 (GDK_KEY_g): Don't define if already defined.
3673 (xg_prepare_tooltip): Avoid pointer signedness problem.
3674 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3675
3676 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3677 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3678
3679 * xfns.c (Fx_window_property): Simplify a bit,
3680 to make a bit faster and to avoid GCC 4.6.0 warning.
3681 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3682
3683 * fns.c (internal_equal): Don't assume size_t fits in int.
3684
3685 * alloc.c (compact_small_strings): Tighten assertion a little.
3686
3687 Replace pEd with more-general pI, and fix some printf arg casts.
3688 * lisp.h (pI): New macro, generalizing old pEd macro to other
3689 conversion specifiers. For example, use "...%"pI"d..." rather
3690 than "...%"pEd"...".
3691 (pEd): Remove. All uses replaced with similar uses of pI.
3692 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3693 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3694 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3695 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3696 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3697 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3698 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3699 64-bit hosts.
3700 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3701 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3702 * print.c (safe_debug_print, print_object): Likewise.
3703 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3704 to int.
3705 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3706 avoiding the 0 flag, which is not portable.
3707 * process.c (Fmake_network_process): Use pI to avoid cast.
3708 * region-cache.c (pp_cache): Likewise.
3709 * xdisp.c (decode_mode_spec): Likewise.
3710 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3711 behavior on 64-bit hosts with printf arg.
3712 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3713 (x_stop_queuing_selection_requests): Likewise.
3714 (x_get_window_property): Don't truncate byte count to an 'int'
3715 when tracing.
3716
3717 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3718 here, since it parses constructs like leading '-' and spaces,
3719 which are not wanted; and it overflows with large numbers.
3720 Instead, simply match F[0-9]+, which is what is wanted anyway.
3721
3722 * alloc.c: Remove unportable assumptions about struct layout.
3723 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3724 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3725 (allocate_vectorlike, make_pure_vector): Use the new macros,
3726 plus offsetof, to remove unportable assumptions about struct layout.
3727 These assumptions hold on all porting targets that I know of, but
3728 they are not guaranteed, they're easy to remove, and removing them
3729 makes further changes easier.
3730
3731 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3732 This doesn't fix a bug but makes the code clearer.
3733 (string_overrun_cookie): Now const. Use initializers that
3734 don't formally overflow signed char, to avoid warnings.
3735 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3736 can cause Emacs to crash when string overrun checking is enabled.
3737 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3738 multiple of sizeof (EMACS_INT); it need not be, if
3739 alignof(EMACS_INT) < sizeof (EMACS_INT).
3740 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3741
3742 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3743
3744 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3745
3746 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3747
3748 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3749 supposed to be handshaking. (Bug#8556)
3750 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3751
3752 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3753
3754 * lisp.h (Qdebug): List symbol.
3755 * eval.c (Qdebug): Restore global linkage.
3756 * keyboard.c (debug-on-event): New variable.
3757 (handle_user_signal): Break into debugger when debug-on-event
3758 matches the current signal symbol.
3759
3760 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3761
3762 * alloc.c (check_sblock, check_string_bytes)
3763 (check_string_free_list): Convert to standard C.
3764
3765 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3766
3767 * w32.c (emacs_gnutls_push): Fix typo.
3768
3769 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3770
3771 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3772 "cast to pointer from integer of different size".
3773
3774 Improve doprnt and its use in verror. (Bug#8545)
3775 * doprnt.c (doprnt): Document the set of format control sequences
3776 supported by the function. Use SAFE_ALLOCA instead of always
3777 using `alloca'.
3778
3779 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3780 is one byte too soon. Don't use xrealloc; instead xfree and
3781 xmalloc anew.
3782
3783 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3784
3785 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3786 callbacks stage.
3787
3788 * gnutls.c: Renamed global_initialized to
3789 gnutls_global_initialized. Added internals for the
3790 :verify-hostname-error, :verify-error, and :verify-flags
3791 parameters of `gnutls-boot' and documented those parameters in the
3792 docstring. Start callback support.
3793 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3794 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3795 on error. Return error code.
3796 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3797 (emacs_gnutls_read): Likewise.
3798 (Fgnutls_boot): Return handshake error code.
3799 (emacs_gnutls_handle_error): New function.
3800 (wsaerror_to_errno): Likewise.
3801
3802 * w32.h (emacs_gnutls_pull): Add prototype.
3803 (emacs_gnutls_push): Likewise.
3804
3805 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3806 (emacs_gnutls_push): Likewise.
3807
3808 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3809
3810 * process.c (wait_reading_process_output): Check if GnuTLS
3811 buffered some data internally if no FDs are set for TLS
3812 connections.
3813
3814 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3815 (LIBS): Link to USER_LIBS.
3816 ($(BLD)/gnutls.$(0)): New target.
3817
3818 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3819
3820 * xdisp.c (handle_single_display_spec): Rename the
3821 display_replaced_before_p argument into display_replaced_p, to
3822 make it consistent with the commentary. Fix typos in the
3823 commentary.
3824
3825 * textprop.c (syms_of_textprop): Remove dead code.
3826 (copy_text_properties): Delete obsolete commentary about an
3827 interface that was deleted long ago. Fix typos in the description
3828 of arguments.
3829
3830 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3831 to changes in oldXMenu/XMenu.h from 2011-04-16.
3832 <menu_help_message, prev_menu_help_message>: Constify.
3833 (IT_menu_make_room): menu->help_text is now `const char **';
3834 adjust.
3835
3836 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3837 to changes in oldXMenu/XMenu.h from 2011-04-16.
3838 (struct XMenu): Declare `help_text' `const char **'.
3839
3840 * xfaces.c <Qunspecified>: Make extern again.
3841
3842 * syntax.c: Include sys/types.h before including regex.h, as
3843 required by Posix.
3844
3845 * doc.c (get_doc_string): Improve the format passed to `error'.
3846
3847 * doprnt.c (doprnt): Improve commentary.
3848
3849 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3850
3851 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3852 them with etags.
3853
3854 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3855 changes in globals.h immediately force recompilation.
3856 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3857 $(CURDIR)/s/ms-w32.h.
3858 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3859
3860 * character.c (Fchar_direction): Function deleted.
3861 (syms_of_character): Don't defsubr it.
3862 <char-direction-table>: Deleted.
3863
3864 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3865
3866 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3867 * doprnt.c: Include limits.h.
3868 (SIZE_MAX): New macro.
3869 (doprnt): Return a size_t value. 2nd arg is now size_t.
3870 Many local variables are now size_t instead of int or unsigned.
3871 Improve overflow protection. Support `l' modifier for integer
3872 conversions. Support %l conversion. Don't assume an EMACS_INT
3873 argument for integer conversions and for %c.
3874
3875 * lisp.h (doprnt): Restore prototype.
3876
3877 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3878 $(SRC)/character.h.
3879
3880 * Makefile.in (base_obj): Add back doprnt.o.
3881
3882 * deps.mk (doprnt.o): Add back prerequisites.
3883 (callint.o): Depend on character.h.
3884
3885 * eval.c (internal_lisp_condition_case): Include the handler
3886 representation in the error message.
3887 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3888 when breaking from the loop.
3889
3890 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3891
3892 * callint.c (Fcall_interactively): When displaying error message
3893 about invalid control letter, pass the character's codepoint, not
3894 a pointer to its multibyte form. Improve display of the character
3895 in octal and display also its hex code.
3896
3897 * character.c (char_string): Use %x to display the (unsigned)
3898 codepoint of an invalid character, to avoid displaying a bogus
3899 negative value.
3900
3901 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3902 `error', not SYMBOL_NAME itself.
3903
3904 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3905 character arguments to `error'.
3906
3907 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3908 to `error' in error message about FINAL_CHAR argument. Make sure
3909 FINAL_CHAR is a character, and use %c when it is passed as
3910 argument to `error'.
3911
3912 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3913
3914 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3915
3916 * w32.c: Include <time.h>.
3917 (sys_localtime): New function.
3918
3919 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3920
3921 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3922
3923 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3924
3925 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3926
3927 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3928 zombies (Bug#8467).
3929
3930 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3931
3932 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3933 gl_state.e_property when gl_state.object is Qt.
3934
3935 * insdel.c (make_gap_larger): Remove limitation of buffer size
3936 to <= INT_MAX.
3937
3938 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3939
3940 * xdisp.c (lookup_glyphless_char_display)
3941 (produce_glyphless_glyph): Handle cons cell entry in
3942 glyphless-char-display.
3943 (Vglyphless_char_display): Document it.
3944
3945 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3946 glyphless-char-display.
3947
3948 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3949
3950 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3951
3952 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3953
3954 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3955 definition for no-X builds.
3956
3957 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3958
3959 Static checks with GCC 4.6.0 and non-default toolkits.
3960
3961 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3962
3963 * process.c (keyboard_bit_set): Define only if SIGIO.
3964 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3965 (send_process): Repair possible setjmp clobbering.
3966
3967 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3968
3969 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3970
3971 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3972
3973 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3974 Define only if needed.
3975
3976 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3977 by pacifying GCC about it. Maybe it's time to retire it?
3978 * xfaces.c (USG, __TIMEVAL__): Likewise.
3979
3980 * dispextern.h (struct redisplay_interface): Rename param
3981 to avoid shadowing.
3982 * termhooks.h (struct terminal): Likewise.
3983 * xterm.c (xembed_send_message): Likewise.
3984
3985 * insdel.c (make_gap_smaller): Define only if
3986 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3987
3988 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3989 it.
3990
3991 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3992 so that we aren't warned about unused symbols.
3993
3994 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3995
3996 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3997
3998 * xfns.c (x_real_positions): Mark locals as initialized.
3999
4000 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4001
4002 * xterm.c: Fix problems found by static analysis with other toolkits.
4003 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4004 (x_dispatch_event): Declare static if USE_GTK, and
4005 define if USE_GTK || USE_X_TOOLKIT.
4006 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4007 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4008 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4009 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4010
4011 * xmenu.c (menu_help_callback): Pointer type fixes.
4012 Use const pointers when pointing at readonly data. Avoid pointer
4013 signedness clashes.
4014 (FALSE): Remove unused macro.
4015 (update_frame_menubar): Remove unused decl.
4016
4017 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4018
4019 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4020 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4021 (single_menu_item): Rename local to avoid shadowing.
4022
4023 * keyboard.c (make_lispy_event): Remove unused local var.
4024
4025 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4026 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4027
4028 * bitmaps: Change bitmaps from unsigned char back to the X11
4029 compatible char. Avoid the old compiler warnings about
4030 out-of-range initializers by using, for example, '\xab' rather
4031 than 0xab.
4032
4033 * xgselect.c (xgselect_initialize): Check vs interface
4034 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4035
4036 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4037
4038 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4039 to read-only memory.
4040
4041 * fns.c (vector): Remove; this old hack is no longer needed.
4042
4043 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4044 Remove unused var.
4045 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4046
4047 * xrdb.c (x_load_resources): Omit unused local.
4048
4049 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4050 (x_window): Rename locals to avoid shadowing.
4051 (USG): Use the kludged USG macro, to pacify gcc.
4052
4053 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4054 (x_term_init): Remove local to avoid shadowing.
4055
4056 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4057
4058 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4059 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4060
4061 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4062
4063 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4064
4065 Fix regex.c, syntax.c and friends for buffers > 2GB.
4066 * syntax.h (struct gl_state_s): Declare character position members
4067 EMACS_INT.
4068
4069 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4070
4071 * textprop.c (verify_interval_modification, interval_of):
4072 Declare arguments EMACS_INT.
4073
4074 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4075 EMACS_INT.
4076
4077 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4078
4079 * indent.c (Fvertical_motion): Local variable it_start is now
4080 EMACS_INT.
4081
4082 * regex.c (re_match, re_match_2, re_match_2_internal)
4083 (bcmp_translate, regcomp, regexec, print_double_string)
4084 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4085 (re_compile_pattern, re_exec): Declare arguments and local
4086 variables `size_t' and `ssize_t' and return values `regoff_t', as
4087 appropriate.
4088 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4089 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4090 <compile_stack_type>: `size' and `avail' are now `size_t'.
4091
4092 * regex.h <regoff_t>: Use ssize_t, not int.
4093 (re_search, re_search_2, re_match, re_match_2): Arguments that
4094 specify buffer/string position and length are now ssize_t and
4095 size_t. Return type is regoff_t.
4096
4097 2011-04-16 Ben Key <bkey76@gmail.com>
4098
4099 * nsfont.m: Fixed bugs in ns_get_family and
4100 ns_descriptor_to_entity that were caused by using free to
4101 deallocate memory blocks that were allocated by xmalloc (via
4102 xstrdup). This caused Emacs to crash when compiled with
4103 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4104 --enable-checking=xmallocoverrun). xfree is now used to
4105 deallocate these memory blocks.
4106
4107 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4108
4109 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4110
4111 emacs_write: Accept and return EMACS_INT for sizes.
4112 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4113 et seq.
4114 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4115 Accept and return EMACS_INT.
4116 (emacs_gnutls_write): Return the number of bytes written on
4117 partial writes.
4118 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4119 (emacs_read, emacs_write): Remove check for negative size, as the
4120 Emacs source code has been audited now.
4121 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4122 (emacs_read, emacs_write): Use it.
4123 * process.c (send_process): Adjust to the new signatures of
4124 emacs_write and emacs_gnutls_write. Do not attempt to store
4125 a byte offset into an 'int'; it might overflow.
4126 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4127
4128 * sound.c: Don't assume sizes fit in 'int'.
4129 (struct sound_device.period_size, alsa_period_size):
4130 Return EMACS_INT, not int.
4131 (struct sound_device.write, vox_write, alsa_write):
4132 Accept EMACS_INT, not int.
4133 (wav_play, au_play): Use EMACS_INT to store sizes and to
4134 record read return values.
4135
4136 2011-04-15 Ben Key <bkey76@gmail.com>
4137
4138 * keyboard.c (Qundefined): Don't declare static since it is used
4139 in nsfns.m.
4140 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4141 static since they are used in nsfont.m.
4142
4143 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4144
4145 * process.c (Qprocessp): Don't declare static.
4146 * lisp.h (Qprocessp): Declare again.
4147
4148 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4149
4150 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4151
4152 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4153
4154 Improve C-level modularity by making more things 'static'.
4155
4156 Don't publish debugger-only interfaces to other modules.
4157 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4158 (verify_bytepos, count_markers): Move decls to the only modules
4159 that need them.
4160 * region-cache.h (pp_cache): Likewise.
4161 * window.h (check_all_windows): Likewise.
4162 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4163
4164 * sysdep.c (croak): Now static, if
4165 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4166 * syssignal.h (croak): Declare only if not static.
4167
4168 * alloc.c (refill_memory_reserve): Now static if
4169 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4170 * lisp.h (refill_memory_reserve): Declare only if not static.
4171
4172 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4173 Define only if USE_LUCID.
4174
4175 * xrdb.c (x_customization_string, x_rm_string): Now static.
4176
4177 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4178 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4179
4180 * xdisp.c (draw_row_with_mouse_face): Now static.
4181 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4182
4183 * window.h (check_all_windows): Mark externally visible.
4184
4185 * window.c (window_deletion_count): Now static.
4186
4187 * undo.c: Make symbols static if they're not exported.
4188 (last_undo_buffer, last_boundary_position, pending_boundary):
4189 Now static.
4190
4191 * textprop.c (interval_insert_behind_hooks): Now static.
4192 (interval_insert_in_front_hooks): Likewise.
4193
4194 * term.c: Make symbols static if they're not exported.
4195 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4196 (max_frame_lines, tty_set_terminal_modes):
4197 (tty_reset_terminal_modes, tty_turn_off_highlight):
4198 (get_tty_terminal): Now static.
4199 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4200 * termhooks.h (term_mouse_moveto): Do not declare if
4201 HAVE_WINDOW_SYSTEM.
4202 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4203 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4204
4205 * sysdep.c: Make symbols static if they're not exported.
4206 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4207 Now static.
4208 (sigprocmask_set, full_mask): Remove; unused.
4209 (wait_debugging): Mark as visible.
4210 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4211 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4212
4213 * syntax.c (syntax_temp): Define only if !__GNUC__.
4214
4215 * sound.c (current_sound_device, current_sound): Now static.
4216
4217 * search.c (searchbufs, searchbuf_head): Now static.
4218
4219 * scroll.c (scroll_cost): Remove; unused.
4220 * dispextern.h (scroll_cost): Remove decl.
4221
4222 * region-cache.h (pp_cache): Mark as externally visible.
4223
4224 * process.c: Make symbols static if they're not exported.
4225 (process_tick, update_tick, create_process, chan_process):
4226 (Vprocess_alist, proc_buffered_char, datagram_access):
4227 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4228 (deactivate_process): Mark defn as static, as well as decl.
4229 * lisp.h (create_process): Remove decl.
4230 * process.h (chan_process, Vprocess_alist): Remove decls.
4231
4232 * print.c: Make symbols static if they're not exported.
4233 (print_depth, new_backquote_output, being_printed, print_buffer):
4234 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4235 (print_interval, print_number_index, initial_stderr_stream):
4236 Now static.
4237 * lisp.h (Fprinc): Remove decl.
4238 (debug_output_compilation_hack): Mark as externally visible.
4239
4240 * sysdep.c (croak): Move decl from here to syssignal.h.
4241 * syssignal.h (croak): Put it here, so the API can be checked when
4242 'croak' is called from dissociate_if_controlling_tty.
4243
4244 * minibuf.c: Make symbols static if they're not exported.
4245 (minibuf_save_list, choose_minibuf_frame): Now static.
4246 * lisp.h (choose_minibuf_frame): Remove decl.
4247
4248 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4249
4250 * lread.c: Make symbols static if they're not exported.
4251 (read_objects, initial_obarray, oblookup_last_bucket_number):
4252 Now static.
4253 (make_symbol): Remove; unused.
4254 * lisp.h (initial_obarray, make_symbol): Remove decls.
4255
4256 * keyboard.c: Make symbols static if they're not exported.
4257 (single_kboard, recent_keys_index, total_keys, recent_keys):
4258 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4259 (this_single_command_key_start, echoing, last_auto_save):
4260 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4261 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4262 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4263 (Vlispy_mouse_stem, double_click_count):
4264 Now static.
4265 (force_auto_save_soon): Define only if SIGDANGER.
4266 (ignore_mouse_drag_p): Now static if
4267 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4268 (print_help): Remove; unused.
4269 (stop_character, last_timer_event): Mark as externally visible.
4270 * keyboard.h (ignore_mouse_drag_p): Declare only if
4271 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4272 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4273 * lisp.h (echoing): Remove decl.
4274 (force_auto_save_soon): Declare only if SIGDANGER.
4275 * xdisp.c (redisplay_window): Simplify code, to make it more
4276 obvious that ignore_mouse_drag_p is not accessed if !defined
4277 USE_GTK && !defined HAVE_NS.
4278
4279 * intervals.c: Make symbols static if they're not exported.
4280 (merge_properties_sticky, merge_interval_right, delete_interval):
4281 Now static.
4282 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4283
4284 * insdel.c: Make symbols static if they're not exported.
4285 However, leave prepare_to_modify_buffer alone. It's never
4286 called from outside this function, but that appears to be a bug.
4287 (combine_after_change_list, combine_after_change_buffer):
4288 (adjust_after_replace, signal_before_change): Now static.
4289 (adjust_after_replace_noundo): Remove; unused.
4290 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4291 (signal_before_change): Remove decls.
4292
4293 * indent.c (val_compute_motion, val_vmotion): Now static.
4294
4295 * image.c: Make symbols static if they're not exported.
4296 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4297 if USE_GTK.
4298 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4299 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4300
4301 * fringe.c (standard_bitmaps): Now static.
4302 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4303
4304 * frame.c: Make symbols static if they're not exported.
4305 (x_report_frame_params, make_terminal_frame): Now static.
4306 (get_frame_param): Now static, unless HAVE_NS.
4307 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4308 (x_get_resource_string): Remove; not used.
4309 * frame.h (make_terminal_frame, x_report_frame_params):
4310 (x_get_resource_string); Remove decls.
4311 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4312 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4313
4314 * font.c, fontset.c: Make symbols static if they're not exported.
4315 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4316 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4317 * font.c (font_close_object): Now static.
4318 * font.h (font_close_object): Remove.
4319 * fontset.c (FONTSET_OBJLIST): Remove.
4320 (free_realized_fontset) #if-0 the body, which does nothing.
4321 (face_suitable_for_char_p): #if-0, as it's never called.
4322 * fontset.h (face_suitable_for_char_p): Remove decl.
4323 * xfaces.c (face_at_string_position):
4324 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4325 since 0 is always ASCII.
4326
4327 * fns.c (weak_hash_tables): Now static.
4328
4329 * fileio.c: Make symbols static if they're not exported.
4330 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4331 (Vwrite_region_annotation_buffers): Now static.
4332
4333 * eval.c: Make symbols static if they're not exported.
4334 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4335 * lisp.h (backtrace_list): Remove decl.
4336
4337 * emacs.c: Make symbols static if they're not exported.
4338 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4339 (fatal_error_code, fatal_error_signal_hook, standard_args):
4340 Now static.
4341 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4342 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4343 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4344 * lisp.h (fatal_error_signal_hook): Remove decl.
4345 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4346
4347 * editfns.c: Move a (normally-unused) function to its only use.
4348 * editfns.c, lisp.h (get_operating_system_release): Remove.
4349 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4350 worth the hassle of breaking this out.
4351
4352 * xterm.c: Make symbols static if they're not exported.
4353 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4354 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4355 (x_destroy_window, x_delete_display):
4356 Now static.
4357 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4358 (x_mouse_leave): Remove; unused.
4359 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4360 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4361 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4362 Remove decls.
4363 (x_mouse_leave): Declare only if WINDOWSNT.
4364 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4365 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4366 USE_X_TOOLKIT.
4367
4368 * ftxfont.c: Make symbols static if they're not exported.
4369 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4370 HAVE_FREETYPE.
4371 * font.h (ftxfont_driver): Likewise.
4372
4373 * xfns.c: Make symbols static if they're not exported.
4374 (x_last_font_name, x_display_info_for_name):
4375 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4376 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4377 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4378 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4379 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4380 (last_show_tip_args): Now static.
4381 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4382 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4383 (x_screen_planes): Remove; unused.
4384 * dispextern.h (x_screen_planes): Remove decl.
4385
4386 * dispnew.c: Make symbols static if they're not exported.
4387 * dispextern.h (redraw_garbaged_frames, scrolling):
4388 (increment_row_positions): Remove.
4389 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4390 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4391 Now static.
4392 (redraw_garbaged_frames): Remove; unused.
4393
4394 * xfaces.c: Make symbols static if they're not exported.
4395 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4396 Remove decls.
4397 * xterm.h (defined_color): Remove decls.
4398 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4399 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4400 (menu_face_changed_default, defined_color, free_realized_face):
4401 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4402 (ascii_face_of_lisp_face): Remove; unused.
4403
4404 * xdisp.c: Make symbols static if they're not exported.
4405 * dispextern.h (scratch_glyph_row, window_box_edges):
4406 (glyph_to_pixel_coords, set_cursor_from_row):
4407 (get_next_display_element, set_iterator_to_next):
4408 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4409 (show_mouse_face): Remove decls
4410 * frame.h (message_buf_print): Likewise.
4411 * lisp.h (pop_message, set_message, check_point_in_composition):
4412 Likewise.
4413 * xterm.h (set_vertical_scroll_bar): Likewise.
4414 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4415 (message_buf_print, scratch_glyph_row, displayed_buffer):
4416 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4417 (get_next_display_element, show_mouse_face, window_box_edges):
4418 (frame_to_window_pixel_xy, check_point_in_composition):
4419 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4420 (glyph_to_pixel_coords): Remove; unused.
4421
4422 * dired.c (file_name_completion): Now static.
4423
4424 * dbusbind.c (xd_in_read_queued_messages): Now static.
4425
4426 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4427 * data.c (circular_list_error): Remove.
4428
4429 * commands.h (last_point_position, last_point_position_buffer):
4430 (last_point_position_window): Remove decls.
4431 * keyboard.c: Make these variables static.
4432
4433 * coding.h (coding, code_convert_region, encode_coding_gap):
4434 Remove decls.
4435 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4436 (iso_code_class, detect_coding, code_convert_region): Now static.
4437 (encode_coding_gap): Remove; unused.
4438
4439 * chartab.c (chartab_chars, chartab_bits): Now static.
4440
4441 * charset.h (charset_iso_8859_1): Remove decl.
4442 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4443 Now static.
4444
4445 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4446 * ccl.c (Vccl_program_table): Now static.
4447 (check_ccl_update): Remove; unused.
4448
4449 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4450 * category.h: ... from here.
4451 * category.c (check_category_table, set_category_set): Now static.
4452
4453 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4454 * lisp.h: Remove these decls.
4455
4456 * buffer.c (buffer_count): Remove unused var.
4457
4458 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4459 so that it's not optimized away.
4460 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4461 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4462 exported only to the debugger.
4463
4464 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4465 * atimer.h (run_all_atimers): Remove; not exported.
4466
4467 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4468 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4469 was inaccessible from Lisp.
4470 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4471 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4472
4473 alloc.c: Import and export fewer symbols, and remove unused items.
4474 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4475 is defined.
4476 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4477 it's not optimized away by whole-program optimization.
4478 (message_enable_multibyte, free_misc): Remove.
4479 (catchlist, handlerlist, mark_backtrace):
4480 Declare only if BYTE_MARK_STACK.
4481 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4482 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4483 (message_enable_multibyte): Remove decl.
4484 (free_misc, interval_free_list, float_block, float_block_index):
4485 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4486 (cons_free_list, last_marked_index):
4487 Now static.
4488 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4489 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4490 (mark_backtrace): Define only if BYTE_MARK_STACK.
4491 * xdisp.c (message_enable_multibyte): Now static.
4492
4493 Declare Lisp_Object Q* variables to be 'static' if not exported.
4494 This makes it easier for human readers (and static analyzers)
4495 to see whether these variables are used from other modules.
4496 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4497 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4498 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4499 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4500 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4501 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4502 * xmenu.c, xselect.c:
4503 Declare Q* vars static if they are not used in other modules.
4504 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4505 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4506 Remove decls of unexported vars.
4507 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4508
4509 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4510
4511 Make Emacs functions such as Fatom 'static' by default.
4512 This makes it easier for human readers (and static analyzers)
4513 to see whether these functions can be called from other modules.
4514 DEFUN now defines a static function. To make the function external
4515 so that it can be used in other C modules, use the new macro DEFUE.
4516 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4517 (Finit_image_library):
4518 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4519 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4520 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4521 Remove decls, since these functions are now static.
4522 (Funintern, Fget_internal_run_time): New decls, since these functions
4523 were already external.
4524
4525 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4526 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4527 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4528 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4529 * keyboard.c, keymap.c, lread.c:
4530 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4531 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4532 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4533 Mark functions with DEFUE instead of DEFUN,
4534 if they are used in other modules.
4535 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4536 decls for now-static functions.
4537 * buffer.h (Fdelete_overlay): Remove decl.
4538 * callproc.c (Fgetenv_internal): Mark as internal.
4539 * composite.c (Fremove_list_of_text_properties): Remove decl.
4540 (Fcomposition_get_gstring): New forward static decl.
4541 * composite.h (Fcomposite_get_gstring): Remove decl.
4542 * dired.c (Ffile_attributes): New forward static decl.
4543 * doc.c (Fdocumntation_property): New forward static decl.
4544 * eval.c (Ffetch_bytecode): New forward static decl.
4545 (Funintern): Remove extern decl; now in .h file where it belongs.
4546 * fileio.c (Fmake_symbolic_link): New forward static decl.
4547 * image.c (Finit_image_library): New forward static decl.
4548 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4549 * intervals.h (Fprevious_property_change):
4550 (Fremove_list_of_text_properties): Remove decls.
4551 * keyboard.c (Fthis_command_keys): Remove decl.
4552 (Fcommand_execute): New forward static decl.
4553 * keymap.c (Flookup_key): New forward static decl.
4554 (Fcopy_keymap): Now static.
4555 * keymap.h (Flookup_key): Remove decl.
4556 * process.c (Fget_process): New forward static decl.
4557 (Fprocess_datagram_address): Mark as internal.
4558 * syntax.c (Fsyntax_table_p): New forward static decl.
4559 (skip_chars): Remove duplicate decl.
4560 * textprop.c (Fprevious_property_change): New forward static decl.
4561 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4562 Now internal.
4563 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4564 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4565
4566 * editfns.c (Fformat): Remove unreachable code.
4567
4568 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4569
4570 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4571 change. (Bug#8496)
4572
4573 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4574
4575 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4576 when at ZV. (Bug#8487)
4577
4578 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4579
4580 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4581 (Bug#8437)
4582 * keyboard.c (parse_tool_bar_item): Likewise.
4583 * sound.c (sound_cleanup, alsa_close): Likewise.
4584 * termcap.c (tgetent): Likewise.
4585 * xfns.c (x_default_font_parameter): Likewise.
4586 * xsettings.c (read_and_apply_settings): Likewise.
4587
4588 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4589 (overrun_check_free): Protoize.
4590
4591 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4592
4593 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4594 since callers should never pass a negative size.
4595 Change the signature to match that of plain 'read' and 'write'; see
4596 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4597 * lisp.h: Update prototypes of emacs_write and emacs_read.
4598
4599 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4600
4601 * xdisp.c (redisplay_window): Don't try to determine the character
4602 position of the scroll margin if the window start point w->startp
4603 is outside the buffer's accessible region. (Bug#8468)
4604
4605 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4606
4607 Fix write-region and its subroutines for buffers > 2GB.
4608 * fileio.c (a_write, e_write): Modify declaration of arguments and
4609 local variables to support buffers larger than 2GB.
4610 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4611
4612 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4613 argument, local variables, and return value.
4614
4615 * lisp.h: Update prototypes of emacs_write and emacs_read.
4616
4617 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4618
4619 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4620
4621 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4622
4623 Fix more problems found by GCC 4.6.0's static checks.
4624
4625 * xdisp.c (vmessage): Use a better test for character truncation.
4626
4627 * charset.c (load_charset_map): <, not <=, for optimization,
4628 and to avoid potential problems with integer overflow.
4629 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4630 * casetab.c (set_identity, shuffle): Likewise.
4631 * editfns.c (Fformat): Likewise.
4632 * syntax.c (skip_chars): Likewise.
4633
4634 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4635 This also lets GCC 4.6.0 generate slightly better loop code.
4636
4637 * callint.c (Fcall_interactively): <, not <=, for optimization.
4638 (Fcall_interactively): Count the number of arguments produced,
4639 not the number of arguments given. This is simpler and lets GCC
4640 4.6.0 generate slightly better code.
4641
4642 * ftfont.c: Distingish more carefully between FcChar8 and char.
4643 The previous code passed unsigned char * to a functions like
4644 strlen and xstrcasecmp that expect char *, which does not
4645 conform to the C standard.
4646 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4647 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4648 char * when the C standard requires it.
4649
4650 * keyboard.c (read_char): Remove unused var.
4651
4652 * eval.c: Port to Windows vsnprintf (Bug#8435).
4653 Include <limits.h>.
4654 (SIZE_MAX): Define if the headers do not.
4655 (verror): Do not give up if vsnprintf returns a negative count.
4656 Instead, grow the buffer. This ports to Windows vsnprintf, which
4657 does not conform to C99. Problem reported by Eli Zaretskii.
4658 Also, simplify the allocation scheme, by avoiding the need for
4659 calling realloc, and removing the ALLOCATED variable.
4660
4661 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4662
4663 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4664 But keep the doprint source code for now, as we might revamp it
4665 and use it again (Bug#8435).
4666 * lisp.h (doprnt): Remove.
4667 * Makefile.in (base_obj): Remove doprnt.o.
4668 * deps.mk (doprnt.o): Remove.
4669
4670 error: Print 32- and 64-bit integers portably (Bug#8435).
4671 Without this change, on typical 64-bit hosts error ("...%d...", N)
4672 was used to print both 32- and 64-bit integers N, which relied on
4673 undefined behavior.
4674 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4675 New macro.
4676 * lisp.h (error, verror): Mark as printf-like functions.
4677 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4678 Report overflow in size calculations when allocating printf buffer.
4679 Do not truncate output string at its first null byte.
4680 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4681 Truncate the output at a character boundary, since vsnprintf does not
4682 do that.
4683 * charset.c (check_iso_charset_parameter): Convert internal
4684 character to string before calling 'error', since %c now has the
4685 printf meaning.
4686 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4687 overflow when computing char to be passed to 'error'. Do not
4688 pass Lisp_Object to 'error'; pass the integer instead.
4689 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4690 formatted with plain %d.
4691
4692 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4693
4694 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4695
4696 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4697
4698 * xterm.c (x_catch_errors): Remove duplicate declaration.
4699
4700 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4701
4702 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4703
4704 2011-04-10 Jim Meyering <meyering@redhat.com>
4705
4706 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4707 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4708 return ssize_t not "int", and use size_t as the buffer length.
4709 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4710 * gnutls.h: Update declarations.
4711 * process.c (read_process_output): Use ssize_t, to match.
4712 (send_process): Likewise.
4713
4714 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4715
4716 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4717
4718 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4719
4720 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4721 Use unsigned char, to match FcChar8 type definition.
4722
4723 * xterm.c (handle_one_xevent):
4724 * xmenu.c (create_and_show_popup_menu):
4725 * xselect.c (x_decline_selection_request)
4726 (x_reply_selection_request): Avoid type-punned deref of X events.
4727
4728 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4729
4730 Fix some uses of `int' instead of EMACS_INT.
4731 * search.c (string_match_1, fast_string_match)
4732 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4733 (scan_buffer, find_next_newline_no_quit)
4734 (find_before_next_newline, search_command, Freplace_match)
4735 (Fmatch_data): Make some `int' variables be EMACS_INT.
4736
4737 * xdisp.c (display_count_lines): 3rd argument and return value now
4738 EMACS_INT. All callers changed.
4739 (pint2hrstr): Last argument is now EMACS_INT.
4740
4741 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4742 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4743 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4744 (decode_coding_utf_16, decode_coding_emacs_mule)
4745 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4746 (decode_coding_ccl, decode_coding_charset)
4747 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4748 (decode_coding_iso_2022, decode_coding_emacs_mule)
4749 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4750 <char_offset, last_offset>: Declare EMACS_INT.
4751 (encode_coding_utf_8, encode_coding_utf_16)
4752 (encode_coding_emacs_mule, encode_invocation_designation)
4753 (encode_designation_at_bol, encode_coding_iso_2022)
4754 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4755 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4756 Declare EMACS_INT.
4757 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4758 (encode_invocation_designation): Last argument P_NCHARS is now
4759 EMACS_INT.
4760 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4761 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4762
4763 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4764 All users changed.
4765
4766 * ccl.c (Fccl_execute_on_string): Declare some variables
4767 EMACS_INT.
4768
4769 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4770
4771 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4772
4773 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4774
4775 * process.c (Fformat_network_address): Doc fix.
4776
4777 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4778
4779 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4780
4781 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4782
4783 * keyboard.c (read_char): Call Lisp function help-form-show,
4784 instead of using internal_with_output_to_temp_buffer.
4785 (Qhelp_form_show): New var.
4786 (syms_of_keyboard): Use DEFSYM macro.
4787
4788 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4789
4790 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4791
4792 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4793
4794 * process.c (Flist_processes): Remove to Lisp.
4795 (list_processes_1): Delete.
4796
4797 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4798
4799 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4800
4801 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4802
4803 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4804
4805 Fix more problems found by GCC 4.6.0's static checks.
4806
4807 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4808
4809 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4810
4811 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4812
4813 * xdisp.c (vmessage): Mark as a printf-like function.
4814
4815 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4816
4817 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4818
4819 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4820 printf-like functions.
4821 (tiff_load): Add casts to remove these marks before passing them
4822 to system-supplied API.
4823
4824 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4825
4826 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4827 This avoids several warnings with gcc -Wstrict-overflow.
4828 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4829 directly, rather than having caller test rule sign. This avoids
4830 some unnecessary tests.
4831 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4832 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4833 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4834
4835 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4836 (xfont_open): Avoid unnecessary tests.
4837
4838 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4839
4840 * composite.h, composite.c (composition_gstring_put_cache):
4841 Use EMACS_INT, not int, for length.
4842
4843 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4844 breaking out part of COMPOSITION_DECODE_RULE.
4845 (COMPOSITION_DECODE_RULE): Use it.
4846 * composite.c (get_composition_id): Remove unused local vars,
4847 by using the new macro.
4848
4849 * textprop.c (set_text_properties_1): Change while to do-while,
4850 since the condition is always true at first.
4851
4852 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4853 (interval_deletion_adjustment): Return unsigned value.
4854 All uses changed.
4855
4856 * process.c (list_processes_1, create_pty, read_process_output):
4857 (exec_sentinel): Remove vars that were set but not used.
4858 (create_pty): Remove unnecessary "volatile"s.
4859 (Fnetwork_interface_info): Avoid possibility of int overflow.
4860 (read_process_output): Do adaptive read buffering even if carryover.
4861 (read_process_output): Simplify nbytes computation if buffered.
4862
4863 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4864
4865 * syntax.c (scan_words): Remove var that was set but not used.
4866 (update_syntax_table): Use unsigned instead of int.
4867
4868 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4869 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4870 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4871
4872 * print.c (print_error_message): Avoid int overflow.
4873
4874 * font.c (font_list_entities): Redo for clarity,
4875 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4876
4877 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4878 (font_score): Avoid potential overflow in diff calculation.
4879
4880 * fns.c (substring_both): Remove var that is set but not used.
4881 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4882
4883 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4884
4885 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4886 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4887 can always succeed if overflow has undefined behavior.
4888
4889 * search.c (boyer_moore, wordify): Remove vars set but not used.
4890 (wordify): Omit three unnecessary tests.
4891
4892 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4893 All callers changed. This avoids the need for an unused var.
4894
4895 * casefiddle.c (casify_region): Remove var that is set but not used.
4896
4897 * dired.c (file_name_completion): Remove var that is set but not used.
4898
4899 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4900
4901 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4902 (Finsert_file_contents): Remove unnecessary code checking fd.
4903
4904 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4905 Check for integer overflow on size calculations.
4906
4907 * buffer.c (Fprevious_overlay_change): Remove var that is set
4908 but not used.
4909
4910 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4911 Remove vars that are set but not used.
4912 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4913 (timer_check_2): Mark vars as initialized.
4914
4915 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4916
4917 * image.c (lookup_image): Remove var that is set but not used.
4918 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4919
4920 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4921 that are set but not used.
4922
4923 * xfns.c (make_invisible_cursor): Don't return garbage
4924 if XCreateBitmapFromData fails (Bug#8410).
4925
4926 * xselect.c (x_get_local_selection, x_handle_property_notify):
4927 Remove vars that are set but not used.
4928
4929 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4930 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4931
4932 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4933 Remove var that is set but not used.
4934 (scroll_bar_windows_size): Now size_t, not int.
4935 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4936 Check for overflow.
4937
4938 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4939 (map_tty_color) [!defined MSDOS]: Likewise.
4940
4941 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4942
4943 * coding.c: Remove vars that are set but not used.
4944 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4945 All callers changed.
4946 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4947 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4948 (decode_coding_charset): Remove vars that are set but not used.
4949
4950 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4951 that is set but not used.
4952
4953 * print.c (print_object): Remove var that is set but not used.
4954
4955 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4956 The gnulib version avoids calling malloc in the usual case,
4957 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4958 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4959 * filelock.c (current_lock_owner): Likewise.
4960 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4961 * sysdep.c: Include allocator.h, careadlinkat.h.
4962 (emacs_no_realloc_allocator): New static constant.
4963 (emacs_readlink): New function.
4964 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4965 ../lib/careadlinkat.h.
4966
4967 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4968
4969 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4970 first non-nil return value).
4971
4972 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4973
4974 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4975 if not defined (Bug#8403).
4976
4977 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4978
4979 * xdisp.c (display_count_lines): Remove parameter `start',
4980 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4981 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4982 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4983 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4984 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4985 and thereabouts. All callers changed.
4986 (get_per_char_metric): Remove parameter `f', unused since
4987 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4988
4989 2011-04-02 Jim Meyering <meyering@redhat.com>
4990
4991 do not dereference NULL upon failed strdup
4992 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4993 (ns_get_family): Likewise.
4994
4995 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4996
4997 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4998
4999 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5000
5001 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5002 later (Bug#8403).
5003
5004 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5005
5006 Add lexical binding.
5007
5008 * window.c (Ftemp_output_buffer_show): New fun.
5009 (Fsave_window_excursion):
5010 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5011
5012 * lread.c (lisp_file_lexically_bound_p): New function.
5013 (Fload): Bind Qlexical_binding.
5014 (readevalloop): Remove `evalfun' arg.
5015 Bind Qinternal_interpreter_environment.
5016 (Feval_buffer): Bind Qlexical_binding.
5017 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5018 Mark as dynamic.
5019 (syms_of_lread): Declare `lexical-binding'.
5020
5021 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5022
5023 * keyboard.c (eval_dyn): New fun.
5024 (menu_item_eval_property): Use it.
5025
5026 * image.c (parse_image_spec): Use Ffunctionp.
5027
5028 * fns.c (concat, mapcar1): Accept byte-code-functions.
5029
5030 * eval.c (Fsetq): Handle lexical vars.
5031 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5032 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5033 (FletX, Flet): Obey lexical binding.
5034 (Fcommandp): Handle closures.
5035 (Feval): New `lexical' arg.
5036 (eval_sub): New function extracted from Feval. Use it almost
5037 everywhere where Feval was used. Look up vars in lexical env.
5038 Handle closures.
5039 (Ffunctionp): Move from subr.el.
5040 (Ffuncall): Handle closures.
5041 (apply_lambda): Remove `eval_flags'.
5042 (funcall_lambda): Handle closures and new byte-code-functions.
5043 (Fspecial_variable_p): New function.
5044 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5045 but without exporting it to Lisp.
5046
5047 * doc.c (Fdocumentation, store_function_docstring):
5048 * data.c (Finteractive_form): Handle closures.
5049
5050 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5051 interactive spec.
5052
5053 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5054 New byte-codes.
5055 (exec_byte_code): New function extracted from Fbyte_code to handle new
5056 calling convention for byte-code-functions. Add new byte-codes.
5057
5058 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5059
5060 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5061
5062 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5063
5064 * xdisp.c (redisplay_internal): Fix prototype.
5065
5066 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5067
5068 * xdisp.c (SCROLL_LIMIT): New macro.
5069 (try_scrolling): Use it when setting scroll_limit.
5070 Limit scrolling to 100 screen lines.
5071 (redisplay_window): Even when falling back on "recentering",
5072 position point in the window according to scroll-conservatively,
5073 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5074
5075 (try_scrolling): When point is above the window, allow searching
5076 as far as scroll_max, or one screenful, to compute vertical
5077 distance from PT to the scroll margin position. This prevents
5078 try_scrolling from unnecessarily failing when
5079 scroll-conservatively is set to a value slightly larger than the
5080 window height. Clean up the case of PT below the margin at bottom
5081 of window: scroll_max can no longer be INT_MAX. When aggressive
5082 scrolling is in use, don't let point enter the opposite scroll
5083 margin as result of the scroll.
5084 (syms_of_xdisp) <scroll-conservatively>: Document the
5085 threshold of 100 lines for never-recentering scrolling.
5086
5087 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5088
5089 * dispextern.h (move_it_by_lines):
5090 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5091 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5092 (message_log_check_duplicate): Remove parameters `prev_bol' and
5093 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5094 (redisplay_internal): Remove parameter `preserve_echo_area',
5095 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5096
5097 * indent.c (Fvertical_motion):
5098 * window.c (window_scroll_pixel_based, Frecenter):
5099 Don't pass `need_y_p' to `move_it_by_lines'.
5100
5101 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5102
5103 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5104 steal a few bits to be more compact.
5105 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5106 Remove unneeded casts.
5107
5108 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5109
5110 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5111
5112 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5113 binding" message (bug#7967).
5114
5115 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5116
5117 Fix more problems found by GCC 4.6.0's static checks.
5118
5119 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5120 Remove unused local var.
5121
5122 * editfns.c (Fmessage_box): Remove unused local var.
5123
5124 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5125 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5126 Omit unused local vars.
5127 * window.c (shrink_windows): Omit unused local var.
5128 * menu.c (digest_single_submenu): Omit unused local var.
5129 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5130 Omit unused local var.
5131
5132 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5133 Don't assume string length fits in int.
5134 (keyremap_step, read_key_sequence): Use size_t for sizes.
5135 (read_key_sequence): Don't check last_real_key_start redundantly.
5136
5137 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5138 instead of alloca (Bug#8344).
5139
5140 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5141 (Fbacktrace_frame): Don't assume nframes fits in int.
5142
5143 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5144
5145 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5146 concerns.
5147
5148 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5149
5150 * cm.c (calccost): Turn while-do into do-while, for clarity.
5151
5152 * keyboard.c (syms_of_keyboard): Use the same style as later
5153 in this function when indexing through an array. This also
5154 works around GCC bug 48267.
5155
5156 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5157
5158 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5159
5160 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5161 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5162
5163 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5164 This avoids undefined behavior on integer overflow, and is a bit
5165 more convenient anyway since it is compared to a size_t variable.
5166
5167 Variadic C functions now count arguments with size_t, not int.
5168 This avoids an unnecessary limitation on 64-bit machines, which
5169 caused (substring ...) to crash on large vectors (Bug#8344).
5170 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5171 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5172 All variadic functions and their callers changed accordingly.
5173 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5174 * data.c (arith_driver, float_arith_driver): Likewise.
5175 * editfns.c (general_insert_function): Likewise.
5176 * eval.c (struct backtrace.nargs, interactive_p)
5177 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5178 (funcall_lambda, mark_backtrace): Likewise.
5179 * fns.c (concat): Likewise.
5180 * frame.c (x_set_frame_parameters): Likewise.
5181 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5182 0 if not found, not -1. All callers changed.
5183
5184 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5185 (stack_copy_size): Now size_t, not int.
5186 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5187
5188 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5189
5190 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5191 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5192 All callers changed.
5193
5194 * lisp.h (multibyte_char_to_unibyte):
5195 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5196 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5197 * character.h (CHAR_TO_BYTE8):
5198 * cmds.c (internal_self_insert):
5199 * editfns.c (general_insert_function):
5200 * keymap.c (push_key_description):
5201 * search.c (Freplace_match):
5202 * xdisp.c (message_dolog, set_message_1): All callers changed.
5203
5204 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5205
5206 * keyboard.c (safe_run_hook_funcall): New function.
5207 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5208 don't set the hook to nil, but remove the offending function instead.
5209 (Qcommand_hook_internal): Remove, unused.
5210 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5211 Vcommand_hook_internal.
5212
5213 * eval.c (enum run_hooks_condition): Remove.
5214 (funcall_nil, funcall_not): New functions.
5215 (run_hook_with_args): Call each function through a `funcall' argument.
5216 Remove `cond' argument, now redundant.
5217 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5218 (Frun_hook_with_args_until_failure): Adjust accordingly.
5219 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5220
5221 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5222
5223 * dispextern.h (string_buffer_position): Remove declaration.
5224
5225 * print.c (strout): Remove parameter `multibyte', unused since
5226 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5227
5228 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5229 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5230 All callers changed.
5231
5232 * w32.c (_wsa_errlist): Use braces for struct initializers.
5233
5234 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5235 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5236 All callers changed.
5237 (string_buffer_position): Likewise. Also, make static (it's never
5238 used outside xdisp.c).
5239 (cursor_row_p): Remove parameter `w', unused since
5240 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5241 (decode_mode_spec): Remove parameter `precision', introduced during
5242 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5243 All callers changed.
5244
5245 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5246
5247 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5248
5249 2011-03-27 Anders Lindgren <andlind@gmail.com>
5250
5251 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5252 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5253 (ns_update_auto_hide_menu_bar): New functions.
5254 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5255 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5256 ns_constrain_all_frames.
5257 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5258 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5259
5260 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5261
5262 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5263
5264 2011-03-27 Glenn Morris <rgm@gnu.org>
5265
5266 * syssignal.h: Replace RETSIGTYPE with void.
5267 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5268 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5269 Replace SIGTYPE with void everywhere.
5270 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5271 * s/template.h (SIGTYPE): Remove commented out definition.
5272
5273 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5274
5275 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5276 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5277
5278 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5279
5280 * w32.c (read_unc_volume): Use parameter `henum', instead of
5281 global variable `wget_enum_handle'.
5282
5283 * keymap.c (describe_vector): Remove parameters `indices' and
5284 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5285 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5286
5287 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5288
5289 * keyboard.c (timer_check): Remove parameter `do_it_now',
5290 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5291 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5292 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5293
5294 * keyboard.c (read_char):
5295 * w32menu.c (w32_menu_display_help):
5296 * xmenu.c (show_help_event, menu_help_callback):
5297 Adjust calls to `show_help_echo'.
5298
5299 * gtkutil.c (xg_maybe_add_timer):
5300 * keyboard.c (readable_events):
5301 * process.c (wait_reading_process_output):
5302 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5303
5304 * insdel.c (adjust_markers_gap_motion):
5305 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5306 (gap_left, gap_right): Don't call it.
5307
5308 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5309
5310 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5311 incurred during fontification.
5312
5313 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5314
5315 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5316 (DEFVAR_PER_BUFFER): Don't pass it.
5317
5318 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5319 (scrolling_window): Don't pass it.
5320
5321 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5322
5323 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5324
5325 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5326 and `suffix'.
5327 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5328 of variables specific to SELinux and computation of `encoded_absname'.
5329
5330 * image.c (XPutPixel): Remove unused variable `height'.
5331
5332 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5333
5334 * unexw32.c (get_section_info): Remove unused variable `section'.
5335
5336 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5337 (system_process_attributes): Remove unused variable `sess'.
5338 (sys_read): Remove unused variable `err'.
5339
5340 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5341 (w32_wnd_proc): Remove unused variable `isdead'.
5342 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5343 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5344 (x_create_tip_frame): Remove unused variable `tem'.
5345
5346 * w32inevt.c (w32_console_read_socket):
5347 Remove unused variable `no_events'.
5348
5349 * w32term.c (x_draw_composite_glyph_string_foreground):
5350 Remove unused variable `width'.
5351
5352 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5353
5354 * w32term.c (x_set_glyph_string_clipping):
5355 Don't pass uninitialized region to CombineRgn.
5356
5357 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5358
5359 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5360 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5361 (Fx_close_connection): Remove unused variable `i'.
5362
5363 * w32font.c (w32font_draw): Return number of glyphs.
5364 (w32font_open_internal): Remove unused variable `i'.
5365 (w32font_driver): Add missing initializer.
5366
5367 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5368 (fill_in_menu): Remove unused variable `items_added'.
5369
5370 * w32term.c (last_mouse_press_frame): Remove static global variable.
5371 (w32_clip_to_row): Remove unused variable `f'.
5372 (x_delete_terminal): Remove unused variable `i'.
5373
5374 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5375 (NOTHING): Remove unused static global variable.
5376 (uniscribe_check_otf): Remove unused variable `table'.
5377 (uniscribe_font_driver): Add missing initializers.
5378
5379 2011-03-23 Julien Danjou <julien@danjou.info>
5380
5381 * term.c (Fsuspend_tty, Fresume_tty):
5382 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5383 * window.c (temp_output_buffer_show):
5384 * insdel.c (signal_before_change):
5385 * frame.c (Fhandle_switch_frame):
5386 * fileio.c (Fdo_auto_save):
5387 * emacs.c (Fkill_emacs):
5388 * editfns.c (save_excursion_restore):
5389 * cmds.c (internal_self_insert):
5390 * callint.c (Fcall_interactively):
5391 * buffer.c (Fkill_all_local_variables):
5392 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5393 Use Frun_hooks.
5394 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5395 unconditionnaly since it does the check itself.
5396
5397 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5398
5399 Fix more problems found by GCC 4.5.2's static checks.
5400
5401 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5402 the first time through the loop, since we know p0 < p1 then.
5403 This also avoids a gcc -Wstrict-overflow warning.
5404
5405 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5406 leading to a memory leak, possible in functions like
5407 load_charset_map_from_file that can allocate an unbounded number
5408 of objects (Bug#8318).
5409
5410 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5411 that could (at least in theory) be that large.
5412
5413 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5414 This is less likely to overflow, and avoids undefined behavior if
5415 overflow does occur. All callers changed. Use strtoul to scan
5416 for the unsigned long integer.
5417 (pint2hrstr): Simplify and tune code slightly.
5418 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5419
5420 * scroll.c (do_scrolling): Work around GCC bug 48228.
5421 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5422
5423 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5424 This also avoids a warning with gcc -Wstrict-overflow.
5425 (validate_x_resource_name): Simplify count usage.
5426 This also avoids a warning with gcc -Wstrict-overflow.
5427
5428 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5429 fail (Bug#8306).
5430
5431 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5432
5433 * process.c (Fmake_network_process): Use socklen_t, not int,
5434 where POSIX says socklen_t is required in portable programs.
5435 This fixes a porting bug on hosts like 64-bit HP-UX, where
5436 socklen_t is wider than int (Bug#8277).
5437 (Fmake_network_process, server_accept_connection):
5438 (wait_reading_process_output, read_process_output):
5439 Likewise.
5440
5441 * process.c: Rename or move locals to avoid shadowing.
5442 (list_processes_1, Fmake_network_process):
5443 (read_process_output_error_handler, exec_sentinel_error_handler):
5444 Rename or move locals.
5445 (Fmake_network_process): Define label "retry_connect" only if needed.
5446 (Fnetwork_interface_info): Fix pointer signedness.
5447 (process_send_signal): Add cast to avoid pointer signedness problem.
5448 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5449 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5450
5451 Make tparam.h and terminfo.c consistent.
5452 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5453 Include tparam.h instead, since it declares them.
5454 * cm.h (PC): Remove extern decl; tparam.h now does this.
5455 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5456 * terminfo.c: Include tparam.h, to check interfaces.
5457 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5458 (tparam): Adjust signature to match interface in tparam.h;
5459 this removes some undefined behavior. Check that outstring and len
5460 are zero, which they always are with Emacs.
5461 * tparam.h (PC, BC, UP): New extern decls.
5462
5463 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5464 (xftfont_open): Rename locals to avoid shadowing.
5465
5466 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5467 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5468 (OTF_TAG_SYM): Omit macro if not needed.
5469 (ftfont_list): Remove unused local.
5470 (get_adstyle_property, ftfont_pattern_entity):
5471 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5472 Rename locals to avoid shadowing.
5473
5474 * xfont.c (xfont_list_family): Mark var as initialized.
5475
5476 * xml.c (make_dom): Now static.
5477
5478 * composite.c (composition_compute_stop_pos): Rename local to
5479 avoid shadowing.
5480 (composition_reseat_it): Remove unused locals.
5481 (find_automatic_composition, composition_adjust_point): Likewise.
5482 (composition_update_it): Mark var as initialized.
5483 (find_automatic_composition): Mark vars as initialized,
5484 with a FIXME (Bug#8290).
5485
5486 character.h: Rename locals to avoid shadowing.
5487 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5488 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5489 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5490 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5491 to avoid shadowing.
5492
5493 * textprop.c (property_change_between_p): Remove; unused.
5494
5495 * intervals.c (interval_start_pos): Now static.
5496
5497 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5498
5499 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5500 Rename locals to avoid shadowing.
5501
5502 * sound.c (wav_play, au_play, Fplay_sound_internal):
5503 Fix pointer signedness.
5504 (alsa_choose_format): Remove unused local var.
5505 (wav_play): Initialize a variable to 0, to prevent undefined
5506 behavior (Bug#8278).
5507
5508 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5509
5510 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5511
5512 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5513 clobbering (Bug#8298).
5514 * sysdep.c (sys_subshell): Likewise.
5515 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5516
5517 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5518 This should get cleaned up, so that child_setup has the
5519 same signature on all platforms.
5520
5521 * callproc.c (call_process_cleanup): Now static.
5522 (relocate_fd): Rename locals to avoid shadowing.
5523
5524 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5525
5526 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5527 not to be necessary, and produces flickering.
5528
5529 2011-03-20 Glenn Morris <rgm@gnu.org>
5530
5531 * config.in: Remove file.
5532
5533 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5534
5535 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5536 are now in src/globals.h.
5537 (syms_of_minibuf): Remove spurious & from previous change.
5538
5539 2011-03-20 Leo <sdl.web@gmail.com>
5540
5541 * minibuf.c (completing-read-function): New variable.
5542 (completing-read-default): Rename from completing-read.
5543 (completing-read): Call completing-read-function.
5544
5545 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5546
5547 * xfaces.c (Fx_load_color_file):
5548 Read color file from absolute filename (bug#8250).
5549
5550 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5551
5552 * makefile.w32-in: Update dependencies.
5553
5554 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5555
5556 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5557
5558 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5559
5560 Fix more problems found by GCC 4.5.2's static checks.
5561
5562 * process.c (make_serial_process_unwind, send_process_trap):
5563 (sigchld_handler): Now static.
5564
5565 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5566 That way, the code declares only the vars that it needs.
5567 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5568 * s/cygwin.h (PTY_ITERATION): Likewise.
5569 * s/darwin.h (PTY_ITERATION): Likewise.
5570 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5571
5572 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5573 * process.c (allocate_pty): Don't declare stb unless it's needed.
5574
5575 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5576 (CONSTANTLIM): Remove; unused.
5577 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5578 Define only if needed.
5579
5580 * unexelf.c (unexec): Name an expression,
5581 to avoid gcc -Wbad-function-cast warning.
5582 Use a different way to cause a compilation error if anyone uses
5583 n rather than nn, a way that does not involve shadowing.
5584 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5585
5586 * deps.mk (unexalpha.o): Remove; unused.
5587
5588 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5589 * unexec.h: New file.
5590 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5591 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5592 Depend on unexec.h.
5593 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5594 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5595 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5596 Change as necessary to match prototype in unexec.h.
5597
5598 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5599 shadowing.
5600 (back_comment, skip_chars): Mark vars as initialized.
5601
5602 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5603 Rename locals to avoid shadowing.
5604
5605 * lread.c (read1): Rewrite so as not to use empty "else".
5606 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5607
5608 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5609
5610 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5611 warning when compiling print.c.
5612
5613 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5614 instead of using an uninitialized var.
5615 (font_sort_entities): Mark var as initialized.
5616
5617 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5618
5619 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5620 pointers to constants.
5621 (font_parse_fcname): Remove unused vars.
5622 (font_delete_unmatched): Now static.
5623 (font_get_spec): Remove; unused.
5624 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5625 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5626 Rename or move locals to avoid shadowing.
5627
5628 * fns.c (require_nesting_list, require_unwind): Now static.
5629 (Ffillarray): Rename locals to avoid shadowing.
5630
5631 * floatfns.c (domain_error2): Define only if needed.
5632 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5633
5634 * alloc.c (mark_backtrace): Move decl from here ...
5635 * lisp.h: ... to here, so that it can be checked.
5636
5637 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5638 (Fdefvar): Rewrite so as not to use empty "else".
5639 (lisp_indirect_variable): Name an expression,
5640 to avoid gcc -Wbad-function-cast warning.
5641 (Fdefvar): Rename locals to avoid shadowing.
5642
5643 * callint.c (quotify_arg, quotify_args): Now static.
5644 (Fcall_interactively): Rename locals to avoid shadowing.
5645 Use const pointer when appropriate.
5646
5647 * lisp.h (get_system_name, get_operating_system_release):
5648 Move decls here, to check interfaces.
5649 * process.c (get_operating_system_release): Move decl to lisp.h.
5650 * xrdb.c (get_system_name): Likewise.
5651 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5652 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5653 some of which prompt warnings from gcc -Wbad-function-cast.
5654 (Fformat_time_string, Fencode_time, Finsert_char):
5655 (Ftranslate_region_internal, Fformat):
5656 Rename or remove local vars to avoid shadowing.
5657 (Ftranslate_region_internal): Mark var as initialized.
5658
5659 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5660 avoid shadowing.
5661
5662 * lisp.h (eassert): Check that the argument compiles, even if
5663 ENABLE_CHECKING is not defined.
5664
5665 * data.c (Findirect_variable): Name an expression, to avoid
5666 gcc -Wbad-function-cast warning.
5667 (default_value, arithcompare, arith_driver, arith_error): Now static.
5668 (store_symval_forwarding): Rename local to avoid shadowing.
5669 (Fmake_variable_buffer_local, Fmake_local_variable):
5670 Mark variables as initialized.
5671 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5672
5673 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5674 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5675 Rename locals to avoid shadowing.
5676 (mark_stack): Move local variables into the #ifdef region where
5677 they're used.
5678 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5679 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5680 needed otherwise.
5681 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5682 (GC_STRING_CHARS): Remove; not used.
5683 (Fmemory_limit): Cast sbrk's returned value to char *.
5684
5685 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5686 avoids undefined behavior in theory.
5687
5688 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5689
5690 Use functions, not macros, for up- and down-casing (Bug#8254).
5691 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5692 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5693 to use the following functions instead of these macros.
5694 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5695 EMACS_INT, since callers assume the returned value fits in int.
5696 (upcase1): Likewise, for UPCASE_TABLE.
5697 (uppercasep, lowercasep, upcase): New static inline functions.
5698 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5699 the race-condition problem in the old DOWNCASE.
5700
5701 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5702 Rename locals to avoid shadowing.
5703 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5704 (regex_compile, re_search_2, re_match_2_internal):
5705 Remove unused local vars.
5706 (FREE_VAR): Rewrite so as not to use empty "else",
5707 which gcc can warn about.
5708 (regex_compile, re_match_2_internal): Mark locals as initialized.
5709 (RETALLOC_IF): Define only if needed.
5710 (WORDCHAR_P): Likewise. This one is never needed, but is used
5711 only in a comment talking about a compiler bug, so put inside
5712 the #if 0 of that comment.
5713 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5714 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5715 Remove; unused.
5716
5717 * search.c (boyer_moore): Rename locals to avoid shadowing.
5718 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5719 (PREV_CHAR_BOUNDARY): Likewise.
5720
5721 * search.c (simple_search): Remove unused var.
5722
5723 * dired.c (compile_pattern): Move decl from here ...
5724 * lisp.h: ... to here, so that it can be checked.
5725 (struct re_registers): New forward decl.
5726
5727 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5728
5729 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5730 All uses changed.
5731 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5732 Rename locals to avoid shadowing.
5733 (Fvertical_motion): Mark locals as initialized.
5734
5735 * casefiddle.c (casify_object, casify_region): Now static.
5736 (casify_region): Mark local as initialized.
5737
5738 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5739
5740 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5741 New macros, so that the caller can use some names other than
5742 gcpro1, gcpro2, etc.
5743 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5744 of the new macros.
5745 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5746 argument, for consistency with GCPRO2_VAR, etc: it is now the
5747 prefix of the variable, not the variable itself. All uses
5748 changed.
5749 * dired.c (directory_files_internal, file_name_completion):
5750 Rename locals to avoid shadowing.
5751
5752 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5753 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5754 dired.c's scmp function, had undefined behavior.
5755 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5756 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5757 * buffer.h: ... to here, because these macros use current_buffer,
5758 and the new implementation with inline functions needs to have
5759 current_buffer in scope now, rather than later when the macros
5760 are used.
5761 (downcase, upcase1): New static inline functions.
5762 (DOWNCASE, UPCASE1): Reimplement using these functions.
5763 This avoids undefined behavior in expressions like
5764 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5765 from race conditions in accessing the global variables
5766 case_temp1 and case_temp2.
5767 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5768 * lisp.h (case_temp1, case_temp2): Remove their decls.
5769 * character.h (ASCII_CHAR_P): Move from here ...
5770 * lisp.h: ... to here, so that the inline functions mentioned
5771 above can use them.
5772
5773 * dired.c (directory_files_internal_unwind): Now static.
5774
5775 * fileio.c (file_name_as_directory, directory_file_name):
5776 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5777 Now static.
5778 (file_name_as_directory): Use const pointers when appropriate.
5779 (Fexpand_file_name): Likewise. In particular, newdir might
5780 point at constant storage, so make it a const pointer.
5781 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5782 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5783 signedness issues.
5784 (Fset_file_times, Finsert_file_contents, auto_save_error):
5785 Rename locals to avoid shadowing.
5786
5787 * minibuf.c (choose_minibuf_frame_1): Now static.
5788 (Ftry_completion, Fall_completions): Rename or remove locals
5789 to avoid shadowing.
5790
5791 * marker.c (bytepos_to_charpos): Remove; unused.
5792
5793 * lisp.h (verify_bytepos, count_markers): New decls,
5794 so that gcc does not warn that these functions aren't declared.
5795
5796 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5797 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5798 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5799 (copy_text): Remove unused local var.
5800
5801 * filelock.c (within_one_second): Now static.
5802 (lock_file_1): Rename local to avoid shadowing.
5803
5804 * buffer.c (fix_overlays_before): Mark locals as initialized.
5805 (fix_start_end_in_overlays): Likewise. This function should be
5806 simplified by using pointers-to-pointers, but that's a different
5807 matter.
5808 (switch_to_buffer_1): Now static.
5809 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5810 (report_overlay_modification): Rename locals to avoid shadowing.
5811
5812 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5813 Fix pointer signedness issue.
5814 (sys_subshell): Mark local as volatile if checking for lint,
5815 to suppress a gcc -Wclobbered warning that does not seem to be right.
5816 (MAXPATHLEN): Define only if needed.
5817
5818 * process.c (serial_open, serial_configure): Move decls from here ...
5819 * systty.h: ... to here, so that they can be checked.
5820
5821 * fns.c (get_random, seed_random): Move extern decls from here ...
5822 * lisp.h: ... to here, so that they can be checked.
5823
5824 * sysdep.c (reset_io): Now static.
5825 (wait_for_termination_signal): Remove; unused.
5826
5827 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5828 (copy_keymap_item, append_key, push_text_char_description):
5829 Now static.
5830 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5831 (DENSE_TABLE_SIZE): Remove; unused.
5832 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5833 (describe_map_tree):
5834 Rename locals to avoid shadowing.
5835
5836 * keyboard.c: Declare functions static if they are not used elsewhere.
5837 (echo_char, echo_dash, cmd_error, top_level_2):
5838 (poll_for_input, handle_async_input): Now static.
5839 (read_char, kbd_buffer_get_event, make_lispy_position):
5840 (make_lispy_event, make_lispy_movement, apply_modifiers):
5841 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5842 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5843 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5844 (read_key_sequence, read_char): Mark locals as initialized.
5845 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5846
5847 * keyboard.h (make_ctrl_char): New decl.
5848 (mark_kboards): Move decl here ...
5849 * alloc.c (mark_kboards): ... from here.
5850
5851 * lisp.h (force_auto_save_soon): New decl.
5852
5853 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5854 (DEFINE_DUMMY_FUNCTION): New macro.
5855 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5856 Use it.
5857 (main): Add casts to avoid warnings
5858 if GCC considers string literals to be constants.
5859
5860 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5861
5862 * dbusbind.c: Pointer signedness fixes.
5863 (xd_signature, xd_append_arg, xd_initialize):
5864 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5865 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5866 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5867 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5868
5869 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5870 if GCC considers string literals to be constants.
5871 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5872
5873 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5874
5875 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5876 (print_preprocess, print_object): New macro to fix last change.
5877
5878 * print.c (print_preprocess): Don't forget font objects.
5879
5880 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5881
5882 * emacs.c (USAGE3): Doc fixes.
5883
5884 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5885
5886 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5887 structure.
5888
5889 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5890
5891 * lisp.h (VWindow_system, Qfile_name_history):
5892 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5893 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5894 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5895
5896 * w32select.c: Don't #include "keyboard.h".
5897 (run_protected): Add extern declaration for waiting_for_input.
5898
5899 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5900 * w32console.c (detect_input_pending, read_input_pending)
5901 (encode_terminal_code):
5902 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5903 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5904 (w32_system_caret_y, Qfile_name_history):
5905 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5906 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5907 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5908 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5909 * w32proc.c (Qlocal, report_file_error):
5910 * w32term.c (Vwindow_system, updating_frame):
5911 * w32uniscribe.c (initialized, uniscribe_font_driver):
5912 Remove unneeded extern declarations.
5913
5914 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5915
5916 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5917
5918 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5919
5920 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5921 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5922 These macros can no longer be used for assignment.
5923
5924 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5925 Assign struct members directly, instead of using BUF_BEGV etc.
5926 (record_buffer_markers, fetch_buffer_markers): New functions for
5927 recording and fetching special buffer markers.
5928 (set_buffer_internal_1, set_buffer_temp): Use them.
5929
5930 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5931
5932 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5933
5934 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5935 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5936
5937 * xdisp.c (hscroll_window_tree):
5938 (reconsider_clip_changes): Use PT instead of BUF_PT.
5939
5940 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5941
5942 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5943 $(EMACS_ROOT)/lib/intprops.h.
5944
5945 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5946
5947 Fix more problems found by GCC 4.5.2's static checks.
5948
5949 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5950 to unsigned char * to avoid compiler diagnostic.
5951 (xg_free_frame_widgets): Make it clear that a local variable is
5952 needed only if USE_GTK_TOOLTIP.
5953 (gdk_window_get_screen): Make it clear that this macro is needed
5954 only if USE_GTK_TOOLTIP.
5955 (int_gtk_range_get_value): New function, which avoids a diagnostic
5956 from gcc -Wbad-function-cast.
5957 (xg_set_toolkit_scroll_bar_thumb): Use it.
5958 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5959 diagnostic from gcc -Wbad-function-cast.
5960 (get_utf8_string, xg_get_file_with_chooser):
5961 Rename locals to avoid shadowing.
5962 (create_dialog): Move locals to avoid shadowing.
5963
5964 * xgselect.c (xg_select): Remove unused var.
5965
5966 * image.c (four_corners_best): Mark locals as initialized.
5967 (gif_load): Initialize transparent_p to zero (Bug#8238).
5968 Mark another local as initialized.
5969 (my_png_error, my_error_exit): Mark with NO_RETURN.
5970
5971 * image.c (clear_image_cache): Now static.
5972 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5973 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5974 (x_edge_detection): Remove unnecessary cast that
5975 gcc -Wbad-function-cast diagnoses.
5976 (gif_load): Fix pointer signedness.
5977 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5978 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5979
5980 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5981
5982 Improve quality of tests for time stamp overflow.
5983 For example, without this patch (encode-time 0 0 0 1 1
5984 1152921504606846976) returns the obviously-bogus value (-948597
5985 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5986 reports time overflow. See
5987 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5988 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5989 * editfns.c: Include limits.h and intprops.h.
5990 (TIME_T_MIN, TIME_T_MAX): New macros.
5991 (time_overflow): Move earlier, to before first use.
5992 (hi_time, lo_time): New functions, for an accurate test for
5993 out-of-range times.
5994 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5995 (Fget_internal_run_time): Don't assume time_t fits in int.
5996 (make_time): Use list2 instead of Fcons twice.
5997 (Fdecode_time): More accurate test for out-of-range times.
5998 (check_tm_member): New function.
5999 (Fencode_time): Use it, to test for out-of-range times.
6000 (lisp_time_argument): Don't rely on undefined left-shift and
6001 right-shift behavior when checking for time stamp overflow.
6002
6003 * editfns.c (time_overflow): New function, refactoring common code.
6004 (Fformat_time_string, Fdecode_time, Fencode_time):
6005 (Fcurrent_time_string): Use it.
6006
6007 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6008 * dired.c (make_time): Move to ...
6009 * editfns.c (make_time): ... here.
6010 * systime.h: Note the move.
6011
6012 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6013
6014 * fringe.c (update_window_fringes): Remove unused variables.
6015
6016 * unexmacosx.c (copy_data_segment): Also copy __got section.
6017 (Bug#8223)
6018
6019 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6020
6021 * termcap.c [MSDOS]: Include "msdos.h".
6022 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6023 Constify `char *' arguments and their references according to
6024 prototypes in tparam.h.
6025
6026 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6027
6028 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6029 Adapt all references accordingly.
6030
6031 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6032
6033 2011-03-11 Tom Tromey <tromey@redhat.com>
6034
6035 * buffer.c (syms_of_buffer): Remove obsolete comment.
6036
6037 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6038
6039 * termhooks.h (encode_terminal_code): Declare prototype.
6040
6041 * msdos.c (encode_terminal_code): Don't declare prototype.
6042
6043 * term.c (encode_terminal_code): Now external again, used by
6044 w32console.c and msdos.c.
6045
6046 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6047 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6048
6049 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6050
6051 Fix some minor problems found by GCC 4.5.2's static checks.
6052
6053 * fringe.c (update_window_fringes): Mark locals as initialized
6054 (Bug#8227).
6055 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6056
6057 * alloc.c (mark_fringe_data): Move decl from here ...
6058 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6059 to check its interface.
6060 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6061
6062 * fontset.c (free_realized_fontset): Now static.
6063 (Fset_fontset_font): Rename local to avoid shadowing.
6064 (fontset_font): Mark local as initialized.
6065 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6066
6067 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6068
6069 * xselect.c (x_disown_buffer_selections): Remove; not used.
6070 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6071 (x_own_selection, Fx_disown_selection_internal): Rename locals
6072 to avoid shadowing.
6073 (x_handle_dnd_message): Remove local to avoid shadowing.
6074
6075 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6076 so that the caller can use some name other than gcpro1.
6077 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6078 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6079 (Fx_backspace_delete_keys_p):
6080 Use them to avoid shadowing, and rename vars to avoid shadowing.
6081 (x_decode_color, x_set_name, x_window): Now static.
6082 (Fx_create_frame): Add braces to silence GCC warning.
6083 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6084 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6085 Remove unused locals.
6086 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6087 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6088 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6089 macros.
6090
6091 * xterm.h (x_mouse_leave): New decl.
6092
6093 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6094 Remove unused functions.
6095 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6096 (x_calc_absolute_position): Now static.
6097 (XTread_socket): Don't define label "out" unless it's used.
6098 Don't declare local "event" unless it's used.
6099 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6100 unless they are used.
6101 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6102 (x_fatal_error_signal): Remove; not used.
6103 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6104 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6105 (x_error_catcher, x_connection_closed, x_error_handler):
6106 (x_error_quitter, xembed_send_message, x_iconify_frame):
6107 (my_log_handler): Rename locals to avoid shadowing.
6108 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6109 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6110
6111 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6112 Rename or move locals to avoid shadowing.
6113 (tty_defined_color, merge_face_heights): Now static.
6114 (free_realized_faces_for_fontset): Remove; not used.
6115 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6116 does not deduce is never used uninitialized.
6117 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6118 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6119
6120 * terminal.c (store_terminal_param): Now static.
6121
6122 * xmenu.c (menu_highlight_callback): Now static.
6123 (set_frame_menubar): Remove unused local.
6124 (xmenu_show): Rename parameter to avoid shadowing.
6125 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6126 since they might point to immutable storage.
6127 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6128 since it's unused otherwise.
6129
6130 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6131 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6132 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6133 avoids a gcc -Wuninitialized diagnostic.
6134 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6135 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6136 does not deduce are never used uninitialized.
6137
6138 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6139
6140 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6141 * window.c (window_loop, size_window):
6142 (run_window_configuration_change_hook, enlarge_window): Likewise.
6143
6144 * window.c (display_buffer): Now static.
6145 (size_window): Mark variables that gcc -Wuninitialized
6146 does not deduce are never used uninitialized.
6147 * window.h (check_all_windows): New decl, to forestall
6148 gcc -Wmissing-prototypes diagnostic.
6149 * dispextern.h (bidi_dump_cached_states): Likewise.
6150
6151 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6152 shadowing.
6153 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6154 Include <limits.h>.
6155 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6156 and to avoid gcc -Wuninitialized warning.
6157 (load_charset_map): Mark variables that gcc -Wuninitialized
6158 does not deduce are never used uninitialized.
6159 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6160
6161 * coding.c (coding_set_source, coding_set_destination):
6162 Use "else { /* comment */ }" rather than "else /* comment */;"
6163 for clarity, and to avoid gcc -Wempty-body warning.
6164 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6165 a block, when the outer 'i' will do.
6166 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6167 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6168 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6169 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6170 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6171 Rename locals to avoid shadowing.
6172 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6173 * coding.c (emacs_mule_char, encode_invocation_designation):
6174 Now static, since they're not used elsewhere.
6175 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6176 (decode_coding_object, encode_coding_object, detect_coding_system):
6177 (decode_coding_emacs_mule): Mark variables that gcc
6178 -Wuninitialized does not deduce are never used uninitialized.
6179 (detect_coding_iso_2022): Initialize a local variable that might
6180 be used uninitialized. Leave a FIXME because it's not clear that
6181 this initialization is needed. (Bug#8211)
6182 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6183 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6184 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6185 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6186 Remove unused macros.
6187
6188 * category.c (hash_get_category_set): Remove unused local var.
6189 (copy_category_table): Now static, since it's not used elsewhere.
6190 * character.c (string_count_byte8): Likewise.
6191
6192 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6193 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6194
6195 * chartab.c (copy_sub_char_table): Now static, since it's not used
6196 elsewhere.
6197 (sub_char_table_ref_and_range, char_table_ref_and_range):
6198 Rename locals to avoid shadowing.
6199 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6200
6201 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6202 (BIDI_BOB): Remove unused macro.
6203
6204 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6205 deduce are never used uninitialized.
6206 * term.c (encode_terminal_code): Likewise.
6207
6208 * term.c (encode_terminal_code): Now static. Remove unused local.
6209
6210 * tparam.h: New file.
6211 * term.c, tparam.h: Include it.
6212 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6213 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6214 Move these decls to tparam.h, and make them agree with what
6215 is actually in tparam.c. The previous trick of using incompatible
6216 decls in different modules does not conform to the C standard.
6217 All callers of tparam changed to use tparam's actual API.
6218 * tparam.c (tparam1, tparam, tgoto):
6219 Use const pointers where appropriate.
6220
6221 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6222 * cm.h (struct cm): Likewise.
6223 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6224 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6225 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6226 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6227 (turn_on_face, init_tty): Likewise.
6228 * termchar.h (struct tty_display_info): Likewise.
6229
6230 * term.c (term_mouse_position): Rename local to avoid shadowing.
6231
6232 * alloc.c (mark_ttys): Move decl from here ...
6233 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6234
6235 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6236
6237 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6238
6239 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6240
6241 * search.c (compile_pattern_1): Remove argument regp, unused since
6242 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6243 (compile_pattern): Don't pass it.
6244
6245 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6246
6247 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6248 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6249 for ! HAVE_GTK3.
6250 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6251
6252 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6253
6254 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6255 gdk_window_get_screen, gdk_window_get_geometry,
6256 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6257 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6258 (xg_get_pixbuf_from_pixmap): New function.
6259 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6260 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6261 Call xg_get_pixbuf_from_pixmap instead of
6262 gdk_pixbuf_get_from_drawable.
6263 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6264 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6265 (xg_check_special_colors): Use GtkStyleContext and its functions
6266 for HAVE_GTK3.
6267 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6268 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6269 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6270 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6271 Call gtk_widget_get_preferred_size.
6272 (xg_frame_resized): gdk_window_get_geometry only takes 5
6273 parameters.
6274 (xg_win_to_widget, xg_event_is_for_menubar):
6275 Call gdk_x11_window_lookup_for_display.
6276 (xg_set_widget_bg): New function.
6277 (delete_cb): New function.
6278 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6279 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6280 (xg_set_background_color): Call xg_set_widget_bg.
6281 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6282 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6283 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6284 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6285 if ! HAVE_GTK3.
6286 (update_frame_tool_bar): Call gtk_widget_hide.
6287 (xg_initialize): Use GDK_KEY_g.
6288
6289 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6290 if ! HAVE_GTK3
6291 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6292
6293 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6294 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6295 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6296
6297 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6298
6299 * w32xfns.c (select_palette): Check success of RealizePalette against
6300 GDI_ERROR, not zero.
6301
6302 See ChangeLog.11 for earlier changes.
6303
6304 ;; Local Variables:
6305 ;; coding: utf-8
6306 ;; End:
6307
6308 Copyright (C) 2011 Free Software Foundation, Inc.
6309
6310 This file is part of GNU Emacs.
6311
6312 GNU Emacs is free software: you can redistribute it and/or modify
6313 it under the terms of the GNU General Public License as published by
6314 the Free Software Foundation, either version 3 of the License, or
6315 (at your option) any later version.
6316
6317 GNU Emacs is distributed in the hope that it will be useful,
6318 but WITHOUT ANY WARRANTY; without even the implied warranty of
6319 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6320 GNU General Public License for more details.
6321
6322 You should have received a copy of the GNU General Public License
6323 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.