1 2012-09-24 Glenn Morris <rgm@gnu.org>
3 * eval.c (Frun_hook_with_args, Frun_hook_with_args_until_success)
4 (Frun_hook_with_args_until_failure): Doc fixes.
6 2012-09-21 Chong Yidong <cyd@gnu.org>
8 * image.c (define_image_type): Avoid adding duplicate types to
9 image_types (Bug#12463). Suggested by Jörg Walter.
11 2012-09-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
14 (print_load_command_name): Add case LC_DATA_IN_CODE.
15 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
17 2012-09-18 Glenn Morris <rgm@gnu.org>
19 * eval.c (Frun_hook_with_args_until_success)
20 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
22 2012-09-14 Andreas Schwab <schwab@linux-m68k.org>
24 * fileio.c (Ffile_selinux_context): Only call freecon when
25 lgetfilecon succeeded.
26 (Fset_file_selinux_context): Likewise. (Bug#12444)
28 2012-09-12 Eli Zaretskii <eliz@gnu.org>
30 * xdisp.c (try_window_reusing_current_matrix): Under bidi
31 reordering, locate the cursor by calling set_cursor_from_row; if
32 that fails, clear the desired glyph matrix before returning a
33 failure indication to the caller. Fixes leaving garbled display
34 when fast scrolling with a down-key. (Bug#12403)
35 (compute_stop_pos_backwards): Fix a typo that caused crashes while
36 scrolling through multibyte text.
38 2012-09-12 Jan Djärv <jan.h.d@swipnet.se>
40 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
41 does not become zero (Bug#12234). Backport from trunk.
43 2012-08-24 Chong Yidong <cyd@gnu.org>
45 * Version 24.2 released.
47 2012-08-24 Eli Zaretskii <eliz@gnu.org>
49 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
50 is not one of the heaps we manage. (Bug#12242)
52 2012-08-14 Glenn Morris <rgm@gnu.org>
54 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
56 2012-08-14 Ulrich Mueller <ulm@gentoo.org>
58 * systime.h (EMACS_TIME_CMP): Don't cast time_t values to long
61 2012-08-13 Eli Zaretskii <eliz@gnu.org>
63 * w32menu.c: Include w32heap.h.
64 (add_menu_item): If the call to AppendMenuW (via
65 unicode_append_menu) fails, disable Unicode menus only if we are
66 running on Windows 9X/Me.
68 * makefile.w32-in ($(BLD)/w32menu.$(O)): Depend on w32heap.h.
70 * window.c (Fdelete_other_windows_internal)
71 (Fdelete_window_internal): Don't access frame's mouse highlight
72 info of the initial frame. (Bug#11677)
74 2012-08-12 Jan Djärv <jan.h.d@swipnet.se>
76 * nsterm.m (ns_read_socket): Return early if there is a modal
79 * nsmenu.m (Popdown_data): New struct.
80 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
82 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
83 (initWithContentRect): Make imgView and contentView non-static
84 and autorelease them. Also autorelease img and matrix (Bug#12005).
85 (dealloc): Remove (Bug#12005).
87 * nsterm.m (keyDown:): Interpret flags without left/right bits
88 as the left key (Bug#11670).
90 * nsmenu.m (ns_update_menubar): Add braces to ambigous if-else.
92 2012-08-08 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
94 * unexmacosx.c (copy_data_segment): Copy initialized data in
95 statically linked libraries from input file rather than memory.
97 2012-08-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
99 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
100 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
101 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
103 2012-07-19 Chong Yidong <cyd@gnu.org>
105 * window.c (Fwindow_absolute_pixel_edges)
106 (Fdelete_other_windows_internal): Signal an error if the window is
107 on a dead frame (Bug#11984).
109 2012-07-14 Eli Zaretskii <eliz@gnu.org>
111 Remove FILE_SYSTEM_CASE.
112 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
114 * fileio.c (FILE_SYSTEM_CASE): Don't define.
115 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
116 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
117 call-process-region passes it through expand-file-name.
119 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
121 2012-07-12 Andreas Schwab <schwab@linux-m68k.org>
123 Fix crash when creating indirect buffer (Bug#11917)
124 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
125 Don't handle unbound variables specially if non-zero.
126 (Fbuffer_local_variables): Pass zero.
127 (clone_per_buffer_values): Pass non-zero.
129 2012-06-28 Andreas Schwab <schwab@linux-m68k.org>
131 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
132 to make the loop interruptible.
134 2012-06-26 Andreas Schwab <schwab@linux-m68k.org>
136 * gnutls.c (emacs_gnutls_handshake): Only retry if
137 GNUTLS_E_INTERRUPTED.
139 2012-06-23 Eli Zaretskii <eliz@gnu.org>
141 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
142 in the logic of incrementing and decrementing the value of
143 use_relocatable_buffers.
145 2012-06-21 Glenn Morris <rgm@gnu.org>
147 * charset.c (init_charset): Make lack of etc/charsets fatal.
149 2012-06-11 Jan Djärv <jan.h.d@swipnet.se>
151 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
152 referenced (Bug#11583).
154 2012-06-01 Chong Yidong <cyd@gnu.org>
156 * Version 24.1 released.
158 2012-05-30 Eli Zaretskii <eliz@gnu.org>
160 * xdisp.c (handle_stop): Detect whether we have overlay strings
161 loaded by testing it->current.overlay_string_index to be
162 non-negative, instead of checking whether n_overlay_strings is
163 positive. (Bug#11587)
165 2012-05-30 Chong Yidong <cyd@gnu.org>
167 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
169 * doc.c (Fsubstitute_command_keys): Doc fix.
171 2012-05-29 Eli Zaretskii <eliz@gnu.org>
173 * search.c (search_buffer): Remove calls to
174 r_alloc_inhibit_buffer_relocation, as it is now called by
175 maybe_unify_char, which was the cause of relocation of buffer text
178 2012-05-23 Eli Zaretskii <eliz@gnu.org>
180 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
181 for the duration of call to load_charset, to avoid problems with
182 callers of maybe_unify_char that access buffer text through C
185 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
186 decrement the inhibition flag, instead of just setting or
189 2012-05-24 Ken Brown <kbrown@cornell.edu>
191 * callproc.c (Fcall_process): Restore a line that was accidentally
192 commented out in the 2011-02-13 change (bug#11547).
194 2012-05-23 Eli Zaretskii <eliz@gnu.org>
196 * lisp.h [REL_ALLOC]: Add prototypes for external functions
199 * buffer.c [REL_ALLOC]: Remove prototypes of
200 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
201 they are now on lisp.h.
203 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
205 * search.c (search_buffer): Use it to inhibit relocation of buffer
206 text while re_search_2 is doing its job, because re_search_2 is
207 passed C pointers to buffer text. (Bug#11519)
209 2012-05-21 Eli Zaretskii <eliz@gnu.org>
211 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
214 2012-05-19 Eli Zaretskii <eliz@gnu.org>
216 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
217 state after an additional call to move_it_in_display_line_to, keep
218 the values of it->max_ascent and it->max_descent found for the
220 (pos_visible_p): Revert the comparison against bottom_y to what it
221 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
224 2012-05-15 Eli Zaretskii <eliz@gnu.org>
226 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
228 2012-05-13 Eli Zaretskii <eliz@gnu.org>
230 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
231 already have overlays loaded.
232 (handle_single_display_spec): Before returning without displaying
233 fringe bitmap, synchronize the bidi iterator with the main display
234 iterator, by calling iterate_out_of_display_property.
235 (iterate_out_of_display_property): Detect buffer iteration by
236 testing that it->string is a Lisp string.
237 (get_next_display_element): When the current object is exhausted,
238 and there's something on it->stack, call set_iterator_to_next to
239 proceed with what's on the stack, instead of returning zero.
240 (set_iterator_to_next): If called at the end of a Lisp string,
241 proceed to consider_string_end without incrementing string
242 position. Don't increment display vector index past the end of
243 the display vector. (Bug#11417)
244 (pos_visible_p): Don't report a position visible when move_it_to
245 stopped at the last line of window, which happens to be scanned
246 backwards by the bidi iteration. (Bug#11464)
248 2012-05-11 Eli Zaretskii <eliz@gnu.org>
250 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
251 and right-margin display specs even if the spec is invalid or we
252 are on a TTY, and thus unable to display on the fringes. That's
253 because the text with the property will not be displayed anyway,
254 so we need to signal to the caller that this is a "replacing"
255 display spec. This fixes display when the spec is invalid or we
258 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
260 * unexaix.c (make_hdr): Fix typo in prototype.
261 This bug broke the build on AIX. Problem reported by Gilles Pion.
263 2012-05-05 Eli Zaretskii <eliz@gnu.org>
265 * w32proc.c (new_child): Force Windows to reserve only 64KB of
266 stack for each reader_thread, instead of defaulting to 8MB
267 determined by the linker. This avoids failures in creating
268 subprocesses on Windows 7, see the discussion in this thread:
269 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
271 2012-05-02 Jim Meyering <meyering@redhat.com>
273 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
275 2012-04-29 Eli Zaretskii <eliz@gnu.org>
277 * xdisp.c (pos_visible_p): If already at a newline from the
278 display string before the 'while' loop, don't walk back the glyphs
279 from it3.glyph_row. Solves assertion violation when the display
280 string begins with a newline (egg.el). (Bug#11367)
282 2012-04-24 Chong Yidong <cyd@gnu.org>
284 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
286 2012-04-23 Eli Zaretskii <eliz@gnu.org>
288 * xdisp.c (pos_visible_p): If the window start position is beyond
289 ZV, start the display from buffer beginning. Prevents assertion
290 violation in init_iterator when the minibuffer window is scrolled
293 * window.c (window_scroll_pixel_based): Likewise.
295 2012-04-23 Chong Yidong <cyd@gnu.org>
297 * keymap.c (where_is_internal): Doc fix (Bug#10872).
299 2012-04-20 Glenn Morris <rgm@gnu.org>
301 * fileio.c (Fcopy_file, Fset_file_selinux_context):
302 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
304 2012-04-20 Eli Zaretskii <eliz@gnu.org>
306 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
307 overrun array limits of glyph row's used[] array. (Bug#11288)
309 2012-04-20 Chong Yidong <cyd@gnu.org>
311 * process.c (wait_reading_process_output): If EIO occurs on a pty,
312 set the status to "failed" and ensure that sentinel is run.
314 2012-04-18 Glenn Morris <rgm@gnu.org>
316 * process.c (Fset_process_inherit_coding_system_flag)
317 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
318 (Fmake_network_process, Fmake_serial_process): Doc fix.
320 2012-04-17 Eli Zaretskii <eliz@gnu.org>
322 * xdisp.c (string_buffer_position_lim): Limit starting position to
324 (set_cursor_from_row): If called for a mode-line or header-line
325 row, return zero immediately.
326 (try_cursor_movement): If inside continuation line, don't back up
327 farther than the first row after the header line, if any. Don't
328 consider the header-line row as "partially visible", even if
329 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
331 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
333 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
335 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
337 * process.c (make_process):
338 * process.h: Add integer `gnutls_handshakes_tried' member to
341 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
342 Add convenience `GNUTLS_LOG2i' macro.
344 * gnutls.c (gnutls_log_function2i): Convenience log function.
345 (emacs_gnutls_read): Use new log functions,
346 `gnutls_handshakes_tried' process member, and
347 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
348 attempts per process (connection).
350 2012-04-09 Eli Zaretskii <eliz@gnu.org>
352 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
353 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
355 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
357 * nsterm.m (constrainFrameRect): Always constrain when there is only
358 one screen (Bug#10962).
360 2012-04-06 Eli Zaretskii <eliz@gnu.org>
362 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
363 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
364 about subtle differences between FETCH_CHAR* and STRING_CHAR*
365 macros related to unification of CJK characters. For the details,
366 see the discussion following the message here:
367 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
369 2012-04-04 Chong Yidong <cyd@gnu.org>
371 * keyboard.c (Vdelayed_warnings_list): Doc fix.
373 2012-04-01 Eli Zaretskii <eliz@gnu.org>
375 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
376 instead of alloca. (Bug#11138)
378 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
380 * w32menu.c (is_simple_dialog): Properly check lisp types.
383 2012-03-31 Eli Zaretskii <eliz@gnu.org>
385 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
386 position we get to after a call to move_it_to fails the
387 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
388 only if we wind up in a string from display property. (Bug#11063)
390 * window.c (Fdelete_other_windows_internal): Invalidate the row
391 and column information about mouse highlight, so that redisplay
392 restores it after reallocating the glyph matrices. (Bug#7464)
394 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
395 string comes from a `display' text property, use the buffer
396 position of that property as if we actually saw that position in
398 (move_it_by_lines): Remove the assertion that
399 "it->current_x == 0 && it->hpos == 0" which can be legitimately
400 violated when there's a before-string at the beginning of a line.
403 2012-03-30 Eli Zaretskii <eliz@gnu.org>
405 * xdisp.c (append_space_for_newline): If the default face was
406 remapped, use the remapped face for the appended newline.
407 (extend_face_to_end_of_line): Use the remapped default face for
408 extending the face to the end of the line.
409 (display_line): Call extend_face_to_end_of_line when the default
410 face was remapped. (Bug#11068)
412 2012-03-29 Eli Zaretskii <eliz@gnu.org>
414 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
416 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
418 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
420 2012-03-27 Glenn Morris <rgm@gnu.org>
422 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
425 2012-03-26 Kenichi Handa <handa@m17n.org>
427 * dispextern.h (struct glyph): Fix previous change. Change the
428 bit length of glyphless.ch to 25 (Bug#11082).
430 2012-03-26 Chong Yidong <cyd@gnu.org>
432 * keyboard.c (Vselection_inhibit_update_commands): New variable.
433 (command_loop_1): Use it; inhibit selection update for
434 handle-select-window too (Bug#8996).
436 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
438 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
440 2012-03-25 Kenichi Handa <handa@m17n.org>
442 * dispextern.h (struct glyph): Change the bit length of
443 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
445 2012-03-24 Eli Zaretskii <eliz@gnu.org>
447 * s/ms-w32.h (tzname): Include time.h before redirecting to
448 _tzname. Fixes the MSVC build. (Bug#9960)
450 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
452 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
455 * xterm.c (XTread_socket): Only modify handling_signal if
456 !SYNC_INPUT. (Bug#11080)
458 2012-03-23 Eli Zaretskii <eliz@gnu.org>
460 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
461 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
462 when fetching a multibyte character consumes more bytes than
463 CHAR_BYTES returns, due to unification of CJK characters in
464 string_char. (Bug#11073)
466 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
468 * process.c (wait_reading_process_output): Handle pty disconnect
469 by refraining from sending oneself a SIGCHLD (bug#10933).
471 2012-03-22 Chong Yidong <cyd@gnu.org>
473 * dispextern.h (struct it): New member string_from_prefix_prop_p.
475 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
476 Mark string as coming from a prefix property.
477 (handle_face_prop): Use default face for prefix strings (Bug#4281).
478 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
480 2012-03-21 Chong Yidong <cyd@gnu.org>
482 * xfaces.c (Vface_remapping_alist): Doc fix.
484 2012-03-20 Eli Zaretskii <eliz@gnu.org>
486 * w32proc.c (Fw32_set_console_codepage)
487 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
490 2012-03-20 Chong Yidong <cyd@gnu.org>
492 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
493 to reflect default non-nil value of redisplay-dont-pause.
495 2012-03-19 Kenichi Handa <handa@m17n.org>
497 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
498 it fit in a valid range (Bug#11003).
500 2012-03-18 Eli Zaretskii <eliz@gnu.org>
502 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
503 that is not from display property, accept the row as a "cursor
504 row" if one of the string's character has a non-nil `cursor'
505 property. Fixes cursor positioning when there are newlines in
506 overlay strings, e.g. in icomplete.el. (Bug#11035)
508 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
510 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
512 2012-03-12 Chong Yidong <cyd@gnu.org>
514 * eval.c (inhibit_lisp_code): Rename from
515 inhibit_window_configuration_change_hook; move from window.c.
517 * xfns.c (unwind_create_frame_1, Fx_create_frame):
518 * window.c (run_window_configuration_change_hook)
519 (syms_of_window): Callers changed.
521 2012-03-11 Chong Yidong <cyd@gnu.org>
523 * keymap.c (Fkey_description): Doc fix (Bug#9700).
525 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
527 2012-03-10 Chong Yidong <cyd@gnu.org>
529 * frame.c (other_visible_frames): Don't assume the selected frame
530 is visible (Bug#10955).
532 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
534 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
536 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
538 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
539 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
542 2012-03-03 Glenn Morris <rgm@gnu.org>
544 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
546 2012-03-02 Eli Zaretskii <eliz@gnu.org>
548 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
549 position past the first glyph_row that ends at ZV. (Bug#10902)
550 (redisplay_window, next_element_from_string): Fix typos in
552 (redisplay_window): Pass to move_it_vertically the margin in
553 pixels, not in screen lines.
555 2012-03-02 Glenn Morris <rgm@gnu.org>
557 * buffer.c (buffer-list-update-hook): Doc fix.
559 2012-02-29 Eli Zaretskii <eliz@gnu.org>
561 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
562 push_it before setting up the iterator for the first overlay
563 string, even if we have an empty string loaded.
564 (next_overlay_string): If there's an empty string on the iterator
565 stack, pop the stack. (Bug#10903)
567 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
569 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
570 Suggested by Stefan Monnier in
571 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
572 * alloc.c (widen_to_Lisp_Object): New static function.
573 (mark_memory): Also mark Lisp_Objects by fetching pointer words
574 and widening them to Lisp_Objects. This would work even if
575 USE_LSB_TAG is defined and wide integers are used, which might
576 happen in a future version of Emacs.
578 2012-02-25 Chong Yidong <cyd@gnu.org>
580 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
583 * xselect.c (Fx_selection_exists_p): Doc fix.
584 (x_clipboard_manager_save_all): Print an informative message
585 before saving to clipboard manager.
587 2012-02-24 Chong Yidong <cyd@gnu.org>
589 * keyboard.c (process_special_events): Handle all X selection
590 requests in kbd_buffer, not just the next one (Bug#8869).
592 2012-02-23 Chong Yidong <cyd@gnu.org>
594 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
595 call when setting menu-bar-lines and tool-bar-lines parameters.
596 (unwind_create_frame_1): New helper function.
598 * window.c (inhibit_window_configuration_change_hook): New var.
599 (run_window_configuration_change_hook): Obey it.
600 (syms_of_window): Initialize it.
602 2012-02-22 Chong Yidong <cyd@gnu.org>
604 * xterm.c (x_draw_image_relief): Add missing type check for
605 Vtool_bar_button_margin (Bug#10743).
607 2012-02-21 Chong Yidong <cyd@gnu.org>
609 * fileio.c (Vfile_name_handler_alist): Doc fix.
611 * buffer.c (Fget_file_buffer): Protect against invalid file
612 handler return value.
614 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
616 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
617 when computing $valmask.
619 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
620 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
621 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
622 It's useless in that case, and it can cause problems on hosts
623 that allocate halves of EMACS_INT values separately.
624 Reported by Dan Horák. Diagnosed by Andreas Schwab in
625 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
626 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
627 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
628 it avoids undefined behavior on hosts where shifting right by more
629 than the word width has undefined behavior.
631 2012-02-19 Chong Yidong <cyd@gnu.org>
633 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
634 (Funhandled_file_name_directory, Ffile_name_as_directory)
635 (Fdirectory_file_name, Fexpand_file_name)
636 (Fsubstitute_in_file_name): Protect against invalid file handler
637 return values (Bug#10845).
639 2012-02-18 Eli Zaretskii <eliz@gnu.org>
641 * .gdbinit (pitx): Fix incorrect references to fields of the
644 2012-02-17 Chong Yidong <cyd@gnu.org>
646 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
648 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
650 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
651 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
653 2012-02-15 Chong Yidong <cyd@gnu.org>
655 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
656 marked as special. Also, starting docstrings with * is obsolete.
658 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
660 * gnutls.c (emacs_gnutls_write): Fix last change.
662 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
664 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
667 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
669 * keymap.c (Fsingle_key_description): Handle char ranges.
671 2012-02-12 Chong Yidong <cyd@gnu.org>
673 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
674 as that creates a dangerous corner case.
676 * window.c (Fdelete_window_internal): Invalidate the mouse
677 highlight (Bug#9904).
679 2012-02-12 Glenn Morris <rgm@gnu.org>
681 * xselect.c (Fx_own_selection_internal)
682 (Fx_get_selection_internal, Fx_disown_selection_internal)
683 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
684 * nsselect.m (Fx_own_selection_internal)
685 (Fx_disown_selection_internal, Fx_selection_exists_p)
686 (Fx_selection_owner_p, Fx_get_selection_internal):
687 Sync docs and argument specs with the xselect.c versions.
689 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
691 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
693 2012-02-11 Eli Zaretskii <eliz@gnu.org>
695 * w32select.c (Fx_selection_exists_p): Sync doc string and
696 argument list with xselect.c. (Bug#10783)
698 * w16select.c (Fx_selection_exists_p): Sync doc string and
699 argument list with xselect.c. (Bug#10783)
701 2012-02-10 Glenn Morris <rgm@gnu.org>
703 * fns.c (Fsecure_hash): Doc fix.
705 2012-02-09 Kenichi Handa <handa@m17n.org>
707 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
709 2012-02-07 Chong Yidong <cyd@gnu.org>
711 * buffer.c (Fbuffer_local_variables)
712 (buffer_lisp_local_variables): Handle unbound vars correctly;
713 don't let Qunbound leak into Lisp.
715 2012-02-07 Glenn Morris <rgm@gnu.org>
717 * image.c (Fimagemagick_types): Doc fix.
719 * image.c (imagemagick-render-type): Change it from a lisp object
720 to an integer. Move the doc here from the lisp manual.
721 Treat all values not equal to 0 the same.
723 2012-02-06 Chong Yidong <cyd@gnu.org>
725 * doc.c (store_function_docstring): Avoid applying docstring of
726 alias to base function (Bug#2603).
728 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
730 * .gdbinit (pp1, pv1): Remove redundant defines.
733 2012-02-04 Chong Yidong <cyd@gnu.org>
735 * nsterm.m: Declare a global (Bug#10694).
737 2012-02-04 Eli Zaretskii <eliz@gnu.org>
739 * w32.c (get_emacs_configuration_options):
740 Include --enable-checking, if specified, in the return value.
742 2012-02-04 Martin Rudalics <rudalics@gmx.at>
744 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
745 after rounding frame sizes. (Bug#9723)
747 2012-02-04 Eli Zaretskii <eliz@gnu.org>
749 * keyboard.c (adjust_point_for_property): Don't position point
750 before BEGV. (Bug#10696)
752 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
754 Handle overflow when computing char display width (Bug#9496).
755 * character.c (char_width): Return EMACS_INT, not int.
756 (char_width, c_string_width): Check for overflow when
757 computing the width; this is possible now that individual
758 characters can have unbounded width. Problem introduced
759 by merge from Emacs 23 on 2012-01-19.
761 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
763 * dbusbind.c (Fdbus_register_method): Mention the return value
764 :ignore in the docstring.
766 2012-02-02 Glenn Morris <rgm@gnu.org>
768 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
770 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
771 Unconditionally set to t. (Bug#10673)
772 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
773 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
774 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
776 2012-02-02 Kenichi Handa <handa@m17n.org>
778 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
779 0, do not call append_composite_glyph.
781 2012-02-02 Kenichi Handa <handa@m17n.org>
783 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
785 (x_produce_glyphs): If the component of a composition is a null
786 string, set it->pixel_width to 1 to avoid zero-width glyph.
788 2012-02-01 Eli Zaretskii <eliz@gnu.org>
790 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
791 first 2 arguments are identical. This makes inserting large
792 output from a subprocess an order of magnitude faster on
793 MS-Windows, where all sbrk'ed memory is always contiguous.
795 2012-01-31 Glenn Morris <rgm@gnu.org>
797 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
798 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
799 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
801 2012-01-29 Glenn Morris <rgm@gnu.org>
803 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
805 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
807 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
809 2012-01-28 Chong Yidong <cyd@gnu.org>
811 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
813 2012-01-26 Chong Yidong <cyd@gnu.org>
815 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
817 * search.c (Fsearch_forward, Fsearch_backward): Document negative
818 repeat counts (Bug#10507).
820 2012-01-26 Glenn Morris <rgm@gnu.org>
822 * lread.c (syms_of_lread): Doc fix.
824 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
826 * coding.c (encode_designation_at_bol): Change return value to
829 2012-01-25 Chong Yidong <cyd@gnu.org>
831 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
833 2012-01-21 Chong Yidong <cyd@gnu.org>
835 * floatfns.c (Fcopysign): Make the second argument non-optional,
836 since nil is not allowed anyway.
838 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
840 * process.c (read_process_output): Use p instead of XPROCESS (proc).
841 (send_process): Likewise.
843 2012-01-19 Martin Rudalics <rudalics@gmx.at>
845 * window.c (save_window_save, Fcurrent_window_configuration)
846 (Vwindow_persistent_parameters): Do not use Qstate.
849 2012-01-19 Kenichi Handa <handa@m17n.org>
851 * character.c (char_width): New function.
852 (Fchar_width, c_string_width, lisp_string_width):
853 Use char_width (Bug#9496).
855 2012-01-16 Martin Rudalics <rudalics@gmx.at>
857 * window.c (Vwindow_persistent_parameters): New variable.
858 (Fset_window_configuration, save_window_save): Handle persistent
861 2012-01-14 Eli Zaretskii <eliz@gnu.org>
863 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
864 thrashing the stack of the thread. (Bug#9087)
866 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
868 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
870 2012-01-11 Eli Zaretskii <eliz@gnu.org>
872 * xdisp.c (rows_from_pos_range): Handle the case where the
873 highlight ends on a newline. (Bug#10464)
874 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
875 he end column for display of highlight that ends on a newline
878 2012-01-11 Glenn Morris <rgm@gnu.org>
880 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
881 from load-path also when installation-directory is nil. (Bug#10208)
883 2012-01-10 Glenn Morris <rgm@gnu.org>
885 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
887 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
888 Update template values to be closer to their typical values these days.
890 2012-01-09 Eli Zaretskii <eliz@gnu.org>
892 * xdisp.c (rows_from_pos_range): Accept additional argument
893 DISP_STRING, and accept any glyph in a row whose object is that
894 string as eligible for mouse highlight. Fixes mouse highlight of
895 display strings from overlays. (Bug#10464)
897 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
899 emacs: fix an auto-save permissions race condition (Bug#10400)
900 * fileio.c (auto_saving_dir_umask): New static var.
901 (Fmake_directory_internal): Use it.
902 (do_auto_save_make_dir): Set it, instead of invoking chmod after
903 creating the directory. The old code temporarily assigns
904 too-generous permissions to the directory.
905 (do_auto_save_eh): Clear it.
906 (Fdo_auto_save): Catch all errors, not just file errors, so
907 that the var is always cleared.
909 2012-01-07 Eli Zaretskii <eliz@gnu.org>
911 * search.c (scan_buffer): Pass character positions to
912 know_region_cache, not byte positions. (Bug#6540)
914 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
916 * w32.c (sys_rename): Report EXDEV when rename of a directory
917 fails because the target is on another logical disk. (Bug#10284)
919 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
921 * xterm.c (x_embed_request_focus): New function.
923 * xterm.h: Add prototype.
925 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
927 2012-01-05 Glenn Morris <rgm@gnu.org>
929 * emacs.c (emacs_copyright): Update short copyright year to 2012.
931 2012-01-01 Eli Zaretskii <eliz@gnu.org>
933 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
934 Load gnutls_transport_set_lowat only if GnuTLS version is below
936 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
937 GnuTLS versions below 2.11.1.
939 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
941 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
942 to the doc string advising against its use for altering the way
943 windows are scrolled.
945 2011-12-28 Kenichi Handa <handa@m17n.org>
947 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
948 coding-system ASCII compatible only when it does not produce BOM
949 on encoding (Bug#10383).
951 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
953 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
955 (create_and_show_popup_menu): Always use menu_position_func for
958 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
960 * callint.c (Fcall_interactively): Don't truncate prompt string.
962 2011-12-23 Eli Zaretskii <eliz@gnu.org>
964 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
965 property that ends at ZV, so that the bidi iteration could be
966 resumed from there (after widening). (Bug#10360)
968 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
970 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
972 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
974 * nsterm.m (x_free_frame_resources):
975 Release f->output_data.ns->miniimage.
976 (ns_index_color): Fix indentation. Do not retain
977 color_table->colors[i].
979 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
982 * nsfns.m (x_set_background_color): Assign return value from
983 ns_index_color to face-background instead of NSColor*.
984 (ns_implicitly_set_icon_type): Fix indentation.
985 Change assignment in for loop to comparison.
987 * emacs.c (ns_pool): New variable.
988 (main): Assign ns_pool.
989 (Fkill_emacs): Call ns_release_autorelease_pool.
991 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
992 autorelease fdesc, release fdAttrs and tdict.
993 (ns_get_covering_families): Release charset.
994 (ns_findfonts): Release NSFontDescriptor created with new.
995 (ns_uni_to_glyphs): Fix indentation.
996 (setString): Release attrStr before assigning new value.
998 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1000 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1002 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1003 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1005 2011-12-18 David Reitter <reitter@cmu.edu>
1007 * nsterm.m (ns_term_init): Subscribe for notifications
1008 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1009 to method trackingNotification in EmacsMenu.
1011 * nsmenu.m (trackingMenu): New variable.
1012 (trackingNotification): New method (from Aquamacs).
1013 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1014 from Aquamacs (Bug#7030).
1016 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1018 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1019 (symbol_to_nsstring): Fix indentation.
1020 (ns_symbol_to_pb): New function.
1021 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1022 (Fns_rotate_cut_buffers_internal): Remove.
1023 (Fns_store_selection_internal): Rename from
1024 Fns_store_cut_buffer_internal.
1025 (ns_get_foreign_selection, Fx_own_selection_internal)
1026 (Fx_disown_selection_internal, Fx_selection_exists_p)
1027 (Fns_get_selection_internal, Fns_store_selection_internal):
1028 Use ns_symbol_to_pb and check if return value is nil.
1029 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1030 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1031 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1032 renamed to Sns_store_selection_internal.
1033 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1034 and remove this function.
1035 (ns_handle_selection_clear): Remove, never used.
1036 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1039 2011-12-17 Ken Brown <kbrown@cornell.edu>
1041 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1042 GID is unknown (Bug#10257).
1044 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1046 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1047 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1048 which caused a build failure on GNU/Linux IA-64. This problem was
1049 introduced by my 2011-10-07 patch.
1051 2011-12-15 Juri Linkov <juri@jurta.org>
1053 * image.c (imagemagick_error): New function. (Bug#10112)
1054 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1055 Use `imagemagick_error' where ImageMagick functions return
1057 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1060 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1062 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1063 fill background (Bug#8992).
1065 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1067 * window.c (Vwindow_combination_resize)
1068 (Vwindow_combination_limit): Use t instead of non-nil in
1070 (Vrecenter_redisplay): Add first sentence of doc-string on
1072 (Frecenter): Fix doc-string typo.
1074 2011-12-11 Kenichi Handa <handa@m17n.org>
1076 * coding.c (Funencodable_char_position): Pay attention to the
1077 buffer text relocation (Bug#9389).
1079 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1081 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1082 gtk_init (Bug#10100).
1084 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1086 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1087 IT->string is nil. (Bug#10263)
1089 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1091 * nsterm.h (x_free_frame_resources): Declare.
1093 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1094 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1096 * nsterm.h (ns_get_defaults_value): Declare.
1098 * nsterm.m (ns_default): Call ns_get_defaults_value.
1100 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1102 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1105 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1107 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1108 that where the value of an _OBJC_* symbol points to is in the .bss
1109 section (Bug#10240).
1111 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1113 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1114 after the loop to call ccl_driver at least once (Bug#8619).
1116 2011-12-08 Kenichi Handa <handa@m17n.org>
1118 * ftfont.c (get_adstyle_property): Fix previous change
1121 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1123 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1124 dirs from the default value of EMACSLOADPATH (bug#10208).
1126 2011-12-07 Glenn Morris <rgm@gnu.org>
1128 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1129 installation and source directories as well. (Bug#10208)
1131 2011-12-06 Chong Yidong <cyd@gnu.org>
1133 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1135 2011-12-06 Glenn Morris <rgm@gnu.org>
1137 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1138 as an error, not just -1. (Bug#10217)
1140 2011-12-05 Chong Yidong <cyd@gnu.org>
1142 * keyboard.c (process_special_events): New function.
1143 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1145 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1147 * coding.c (encode_designation_at_bol): Don't use uninitialized
1148 local variable (Bug#9318).
1150 2011-12-05 Kenichi Handa <handa@m17n.org>
1152 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1153 return Qnil (Bug#8046, Bug#10193).
1155 2011-12-05 Kenichi Handa <handa@m17n.org>
1157 * coding.c (encode_designation_at_bol): New args charbuf_end and
1158 dst. Return the number of produced bytes. Callers changed.
1159 (coding_set_source): Return how many bytes coding->source was
1161 (coding_set_destination): Return how many bytes
1162 coding->destination was relocated.
1163 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1164 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1166 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1168 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1169 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1172 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1174 The following changes are to fix Bug#9318.
1176 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1177 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1178 (encode_coding_iso_2022, encode_coding_sjis)
1179 (encode_coding_big5, encode_coding_charset): Use the above macros.
1181 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1183 * lisp.h (process_quit_flag): Fix external declaration.
1185 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1187 Don't macro-inline non-performance-critical code.
1188 * eval.c (process_quit_flag): New function.
1189 * lisp.h (QUIT): Use it.
1191 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1193 * nsfns.m (get_geometry_from_preferences): New function.
1194 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1196 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1198 * emacs.c (Qkill_emacs): Define.
1199 (syms_of_emacs): Initialize it.
1200 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1201 Qquit_flag to `kill-emacs' instead.
1202 (quit_throw_to_read_char): Add parameter `from_signal'.
1203 All callers changed. Call Fkill_emacs if requested and safe.
1204 * lisp.h (QUIT): Call Fkill_emacs if requested.
1206 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1208 * widget.c (update_wm_hints): Return if wmshell is null.
1209 (widget_update_wm_size_hints): New function.
1211 * widget.h (widget_update_wm_size_hints): Declare.
1213 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1214 widget_update_wm_size_hints (Bug#10104).
1216 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1218 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1219 before a newline, prepare the bidi iterator for consuming the
1220 newline, and keep the current paragraph direction. (Bug#10183)
1221 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1223 2011-12-02 Juri Linkov <juri@jurta.org>
1225 * search.c (Fword_search_regexp): New Lisp function created from
1226 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1227 (Fword_search_backward, Fword_search_forward)
1228 (Fword_search_backward_lax, Fword_search_forward_lax):
1229 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1230 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1232 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1234 * fileio.c (Finsert_file_contents): Move after-change-function call
1235 to before the "handled:" label, since all "goto handled" appear in
1236 cases where the *-change-functions have already been properly called
1239 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1241 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1242 waiting for input. (Bug#10169)
1244 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1246 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1247 verifies glyph row's hash code--we have just reallocated the
1248 glyphs, so their contents can be complete garbage. (Bug#10164)
1250 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1252 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1254 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1256 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1257 attributes are tested _before_ calling verify_row_hash, to protect
1258 against GCC re-ordering of the tests. (Bug#10164)
1260 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1262 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1264 * xterm.c (handle_one_xevent): Only set async_visible and friends
1265 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1266 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1267 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1269 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1271 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1272 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1273 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1274 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1275 All uses changed to use GCPRO1 etc.
1276 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1277 Revert to old implementation (i.e., before 2011-03-11).
1279 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1281 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1282 of scroll runs so as to avoid assigning disabled bogus rows and
1283 unnecessary graphics copy operations.
1285 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1287 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1288 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1289 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1290 (malloc, free, realloc, calloc): Redirect to e_* only when
1293 * lisp.h (GCTYPEBITS): Move before first use.
1294 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1295 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1296 this macro definition.
1298 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1301 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1303 * gtkutil.c (xg_create_frame_widgets):
1304 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1305 present with Gtk+ 2.0.
1307 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1309 * fileio.c (Finsert_file_contents): Undo previous change; see
1310 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1312 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1314 Rename locals to avoid shadowing.
1315 * fileio.c (Finsert_file_contents):
1316 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1317 * process.c (wait_reading_process_output):
1318 Rename inner 'proc' to 'p' to avoid shadowing.
1319 Indent for consistency with usual Emacs style.
1321 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1323 * xdisp.c (redisplay_window): If cursor row is not fully visible
1324 after recentering, and scroll-conservatively is set to a large
1325 number, scroll window by a few more lines to make the cursor fully
1326 visible and out of scroll-margin. (Bug#10105)
1327 (start_display): Don't move to the next line if the display should
1328 start at a newline that is part of a display vector or an overlay
1331 2011-11-24 Juri Linkov <juri@jurta.org>
1333 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1334 after the `MagickPingImage' call. (Bug#10112)
1336 2011-11-23 Chong Yidong <cyd@gnu.org>
1338 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1340 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1342 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1343 making another buffer current. (Bug#10114)
1345 2011-11-23 Glenn Morris <rgm@gnu.org>
1347 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1349 2011-11-23 Chong Yidong <cyd@gnu.org>
1351 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1352 using it (Bug#5984).
1354 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1356 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1357 and header-lines, as they don't have one computed for them.
1360 * .gdbinit (prow): Make displayed values more self-explaining.
1361 Add row's hash code.
1363 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1365 * process.c (wait_reading_process_output): Fix asynchrounous
1366 GnuTLS socket handling on some versions of the GnuTLS library.
1367 (wait_reading_process_output): Add comment and URL.
1369 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1371 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1373 2011-11-21 Chong Yidong <cyd@gnu.org>
1375 * window.c (Fnext_window, Fprevious_window): Doc fix.
1377 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1379 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1381 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1383 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1385 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1387 * window.c (Fset_window_combination_limit): Rename argument
1389 (Vwindow_combination_limit): Remove "status" from doc-string.
1391 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1393 * m/ibms390.h: Remove.
1394 * m/ibms390x.h: Don't include "ibms390.h".
1396 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1398 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1399 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1401 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1403 * casetab.c (Fset_case_table):
1404 * charset.c (Fcharset_after): Fix typos.
1406 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1408 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1409 Otherwise, valgrind does not work on some platforms.
1410 Problem reported by Andreas Schwab in
1411 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1412 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1413 is set, removing the need for VIRT_ADDRESS_VARIES.
1414 (PURE_P): Use a more-efficient implementation that needs just one
1415 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1416 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1417 to 4 (xorl, subq, cmpq, setbe).
1418 * alloc.c (pure): Always extern now, since that's the
1419 VIRT_ADDR_VARIES behavior.
1420 (PURE_POINTER_P): Use a single comparison, not two, for
1421 consistency with the new puresize.h.
1422 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1423 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1424 Remove VIRT_ADDR_VARIES no longer needed.
1426 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1428 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1429 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1430 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1431 behave as if the cursor position were at the window margin.
1433 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1434 and the cursor position is out of bounds, behave as if the cursor
1435 position were at the window margin. (Bug#10075)
1437 2011-11-18 Chong Yidong <cyd@gnu.org>
1439 * window.c (Fwindow_combination_limit): Make first argument
1440 non-optional, since it is meaningless for live windows like the
1443 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1445 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1447 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1449 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1450 (graft_intervals_into_buffer): Simplify.
1452 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1454 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1455 hash values of the two rows.
1456 (copy_row_except_pointers): Preserve the used[] arrays and the
1457 hash values of the two rows. (Bug#10035)
1458 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1460 * xdisp.c (row_hash): New function, body extracted from
1461 compute_line_metrics.
1462 (compute_line_metrics): Call row_hash, instead of computing the
1465 * dispnew.c (verify_row_hash): Call row_hash for computing the
1466 hash code of a row, instead of duplicating code from xdisp.c.
1468 * dispextern.h (row_hash): Add prototype.
1470 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1472 * frame.c (delete_frame): Don't delete the terminal when the last
1473 X frame is closed if emacs is built with GTK toolkit.
1475 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1477 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1479 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1481 * window.c (Vwindow_splits): Rename to
1482 Vwindow_combination_resize. Suggested by Juri Linkov.
1483 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1486 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1488 * nsfns.m (Fns_font_name):
1489 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1491 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1493 * window.h (window): Rename slot "nest" to "combination_limit".
1494 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1495 (Fset_window_nest): Rename to Fset_window_combination_limit.
1496 (Vwindow_nest): Rename to Vwindow_combination_limit.
1497 (recombine_windows, make_parent_window, make_window)
1498 (Fsplit_window_internal, saved_window)
1499 (Fset_window_configuration, save_window_save): Rename all
1500 occurrences of window_nest to window_combination_limit.
1502 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1504 * image.c (imagemagick_load_image): Fix typo.
1506 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1508 * xdisp.c (display_line): Move the call to
1509 highlight_trailing_whitespace before the call to
1510 compute_line_metrics, since the latter needs to see the final
1511 faces of all the glyphs to compute ROW's hash value.
1512 Fixes assertion violations in row_equal_p. (Bug#10035)
1514 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1516 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1517 just return (bug#10044).
1519 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1521 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1522 with user-defined heap size. Bump the default size of the temacs
1523 heap to 27MB, to avoid memory warning when running temacs.
1524 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1526 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1527 current_matrix and desired_matrix. (Bug#9990)
1528 (verify_row_hash) [XASSERTS]: New function.
1529 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1530 that the hash value of glyph rows is correct.
1532 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1534 * window.h (window): Remove splits slot.
1535 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1536 (Fdelete_other_windows_internal, make_parent_window)
1537 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1538 (Fset_window_configuration, save_window_save): Don't deal with
1539 split status of windows.
1540 (saved_window): Remove splits slot.
1541 (Vwindow_splits): Rewrite doc-string.
1543 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1545 * xfns.c (unwind_create_frame):
1546 * nsfns.m (unwind_create_frame):
1547 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1548 Vframe_list (Bug#9999).
1550 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1552 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1554 2011-11-11 Kenichi Handa <handa@m17n.org>
1556 * callproc.c (Fcall_process): Set the member dst_multibyte of
1559 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1561 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1562 avoid a crash (bug#9496).
1564 2011-11-09 Chong Yidong <cyd@gnu.org>
1566 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1567 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1569 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1571 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1573 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1575 Avoid some portability problems by eschewing 'extern inline' functions.
1576 The trivial performance wins aren't worth the portability hassles; see
1577 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1579 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1580 (window_box_width, window_box_left, window_box_left_offset)
1581 (window_box_right, window_box_right_offset): Undo previous change,
1582 by removing the "extern"s.
1583 * intervals.c (adjust_intervals_for_insertion)
1584 (adjust_intervals_for_deletion): Undo previous change,
1585 making these static again.
1586 (offset_intervals, temp_set_point_both, temp_set_point)
1587 (copy_intervals_to_string): No longer inline.
1588 * xdisp.c (window_text_bottom_y, window_box_width)
1589 (window_box_height, window_box_left_offset)
1590 (window_box_right_offset, window_box_left, window_box_right)
1591 (window_box): No longer inline.
1593 2011-11-08 Chong Yidong <cyd@gnu.org>
1595 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1596 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1597 Signal an error if not a live window.
1598 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1599 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1601 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1603 * lisp.h (syms_of_abbrev): Remove declaration.
1604 Reported by CHENG Gao <chenggao@royau.me>.
1606 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1608 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1609 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1610 of temacs in GUI mode.
1612 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1614 * window.h: Declare delete_all_child_windows instead of
1615 delete_all_subwindows.
1616 * window.c (Fwindow_nest, Fset_window_nest)
1617 (Fset_window_new_total, Fset_window_new_normal)
1618 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1619 (delete_all_subwindows): Rename to delete_all_child_windows.
1620 (Fdelete_other_windows_internal, Fset_window_configuration):
1621 Call delete_all_child_windows instead of delete_all_subwindows.
1622 * frame.c (delete_frame): Call delete_all_child_windows instead
1623 of delete_all_subwindows.
1625 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1627 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1628 This is also needed for porting to any host where GC_MARK_STACK is
1629 not GC_MAKE_GCPROS_NOOPS.
1630 (which_symbols): Use it.
1632 2011-11-07 Kenichi Handa <handa@m17n.org>
1634 * coding.c (coding_set_destination): Check coding->src_pos only
1635 when coding->src_object is a buffer (bug#9910).
1637 * process.c (send_process): Set the member src_multibyte of coding
1638 to 0 (bug#9911) when sending a unibyte text.
1640 * callproc.c (Fcall_process): Set the member src_multibyte of
1641 process_coding to 0 (bug#9912).
1643 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1645 * xmenu.c (cleanup_widget_value_tree): New function.
1646 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1647 calling free_menubar_widget_value_tree directly (Bug#9830).
1649 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1651 Fix some portability problems with 'inline'.
1652 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1653 (window_box_width, window_box_left, window_box_left_offset)
1654 (window_box_right, window_box_right_offset): Declare extern.
1655 Otherwise, these inline functions do not conform to C99 and
1656 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1657 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1658 * intervals.c (adjust_intervals_for_insertion)
1659 (adjust_intervals_for_deletion): Now extern, because otherwise the
1660 extern inline functions 'offset_intervals' couldn't refer to it.
1661 (static_offset_intervals): Remove.
1662 (offset_intervals): Rewrite using the old contents of
1663 static_offset_intervals. The old version didn't conform to C99
1664 because an extern inline function contained a reference to an
1665 identifier with static linkage.
1667 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1669 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1672 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1674 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1675 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1676 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1677 return Qleft_to_right.
1679 2011-11-06 Chong Yidong <cyd@gnu.org>
1681 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1682 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1683 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1684 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1685 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1686 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1687 (Fwindow_vscroll): Doc fix.
1688 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1689 argument, since it makes no sense to pass a live window and for
1690 consistency with window-child.
1692 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1694 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1697 2011-11-05 Jason Rumney <jasonr@gnu.org>
1699 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1700 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1702 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1703 bitwise arithmetic preventing use of unicode-sip and non-truetype
1706 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1708 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1711 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1712 initialization code to keep similarity to xfns.c after changes
1715 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1717 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1718 (unwind_create_frame): New function (Bug#9943).
1719 (Fx_create_frame): Restructure code to be more similar to the one in
1720 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1721 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1722 Move terminal->reference_count++ just before making the frame official
1725 * nsterm.m (x_free_frame_resources): New function.
1726 (x_destroy_window): Move code to x_free_frame_resources.
1728 * xfns.c (unwind_create_frame): Fix comment.
1729 (Fx_create_frame, x_create_tip_frame):
1730 Move terminal->reference_count++ just before making the frame
1731 official. Move initialization of image_cache_refcount and
1732 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1734 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1736 Support MSVC build with newer versions of Visual Studio.
1737 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1738 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1741 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1742 which are not supported by MSVC.
1743 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1744 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1746 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1748 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1750 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1752 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1754 Support MSVC build with newer versions of Visual Studio.
1755 * w32.c: Don't include w32api.h for MSVC.
1756 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1758 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1759 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1760 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1761 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1763 (alloca) [_MSC_VER]: Define to _alloca.
1765 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1767 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1769 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1771 * xdisp.c (note_mouse_highlight): If either of
1772 previous/next-single-property-change returns nil, treat that as
1773 the beginning or the end of the buffer. (Bug#9955)
1775 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1777 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1778 label is not null (Bug#9951).
1779 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1782 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1784 * window.c (Fwindow_body_size): Mention in the doc string that the
1785 return value is in frame's canonical units. (Bug#9949)
1787 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1789 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1791 * w32fns.c (unwind_create_frame): If needed, free the glyph
1792 matrices of the partially constructed frame. (Bug#9943)
1793 * xfns.c (unwind_create_frame): Likewise.
1795 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1797 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1798 Don't stop backward scan on the continuation glyph, even though
1799 its CHARPOS is positive.
1800 (mouse_face_from_buffer_pos, note_mouse_highlight):
1801 Rename cover_string to disp_string.
1803 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1805 * window.c (temp_output_buffer_show): Don't use
1806 Vtemp_buffer_show_specifiers.
1807 (Vtemp_buffer_show_specifiers): Remove unused variable.
1809 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1811 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1812 past the beginning of the current glyph matrix.
1814 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1816 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1817 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1818 HAVE_GTK3 (Bug#9869).
1820 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1821 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1823 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1825 * xterm.c: Declare x_handle_net_wm_state to return int.
1826 (handle_one_xevent): Check if we are iconified but don't have
1827 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1828 (get_current_wm_state): Return non-zero if not hidden,
1829 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1830 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1831 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1832 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1834 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1836 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1837 so that this new function doesn't get optimized away by a
1838 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1840 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1842 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1844 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1846 Fix the `xbytecode' command.
1847 * .gdbinit (xprintbytestr): New command.
1848 (xwhichsymbols): Rename from `which'; all callers changed.
1849 (xbytecode): Print the byte-code string as well.
1851 2011-10-29 Kim Storm <storm@cua.dk>
1853 * alloc.c (which_symbols): New function.
1855 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1857 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1860 2011-10-29 Glenn Morris <rgm@gnu.org>
1862 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1863 Not clear what it was for, and it causes various bugs. (Bug#9839)
1865 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1867 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1868 possible random value that matches one of those tested as
1869 condition to clear the mouse face.
1871 2011-10-28 Chong Yidong <cyd@gnu.org>
1873 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1875 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1877 * window.c (make_window): Initialize phys_cursor_on_p.
1879 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1881 * lisp.h (struct Lisp_Symbol): Update comments.
1883 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1885 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1887 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1889 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1890 <oslsachem@gmail.com> for helping to debug this.
1892 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1893 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1894 (g_b_init_get_glyph_outline_w): New static variables.
1895 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1896 (GetGlyphOutlineW_Proc): New typedefs.
1897 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1898 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1900 (w32font_open_internal, compute_metrics):
1901 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1902 instead of calling the "wide" APIs directly.
1904 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1906 * w32.h (syms_of_w32font): Add prototype.
1908 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1910 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1911 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1912 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1913 (Fmove_to_window_line): Doc fix.
1915 2011-10-27 Chong Yidong <cyd@gnu.org>
1917 * process.c (make_process): Set gnutls_state to NULL.
1919 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1920 non-NULL, regardless of GNUTLS_INITSTAGE.
1921 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1922 an error. Set process slots as soon as we allocate them.
1924 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1926 2011-10-27 Chong Yidong <cyd@gnu.org>
1928 * gnutls.c (emacs_gnutls_deinit): New function.
1929 Deallocate credentials structures as well as calling gnutls_deinit.
1930 (Fgnutls_deinit, Fgnutls_boot): Use it.
1932 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1933 (deactivate_process): Call emacs_gnutls_deinit.
1935 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1937 * image.c (x_create_x_image_and_pixmap):
1938 * w32.c (sys_rename, w32_delayed_load):
1939 * w32font.c (fill_in_logfont):
1940 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1942 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1944 * w32fns.c (w32_default_color_map): New function,
1945 extracted from Fw32_default_color_map.
1946 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1948 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1950 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1952 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1954 * keyboard.c (test_undefined): New function (bug#9751).
1955 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1957 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1959 * sysdep.c (init_sys_modes): Fix the check for the controlling
1960 terminal (Bug#6649).
1962 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1964 * dispextern.h (struct bidi_it): New member next_en_type.
1966 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1967 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1968 current character, check also for next_en_type being WEAK_EN.
1969 (bidi_resolve_weak): Don't enter the expensive loop if the current
1970 position is before next_en_pos. Record the bidi type of the first
1971 non-ET, non-BN character we find, in addition to its position.
1972 (bidi_level_of_next_char): Invalidate next_en_type when
1973 next_en_pos is over-stepped.
1975 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1977 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1978 * editfns.c: Rewrite current-time-zone so that it invokes
1979 the equivalent of (format-time-string "%Z") to get the time zone name.
1980 This fixes a bug when the time zone name contains characters that
1981 need converting from the system time locale to Emacs internal format.
1982 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1983 that patch fixed format-time-string to do the conversion, but
1984 I forgot to fix current-time-zone.
1985 (format_time_string): New function, containing most of
1986 what Fformat_time_string used to contain.
1987 (Fformat_time_string): Rewrite in terms of format_time_string.
1988 This doesn't change this function's behavior.
1989 (current-time-zone): Rewrite to use format_time_string.
1990 This fixes the bug reported by Michael Schierl in
1991 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1992 Jason Rumney's 2007-06-07 change worked around this bug, but
1994 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1996 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1998 * xdisp.c (start_display): If the character at POS is displayed
1999 via a display vector, reset IT->current.dpvec_index to zero.
2000 (try_window_reusing_current_matrix): If a line ends in a display
2001 vector or the next line starts in a display vector, continue
2002 redrawing the window even though the character position of
2003 start_row was reached.
2006 2011-10-18 Chong Yidong <cyd@gnu.org>
2008 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2009 with nobreak-char-display too.
2011 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2013 Fix part 3 of bug#9771.
2014 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2015 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2016 non-neutral characters if the current character is a paragraph
2017 separator (a.k.a. Newline). This avoids running the same
2018 expensive loop twice, once when we consume the preceding newline
2019 and the other time when the line actually needs to be displayed.
2020 Avoid the loop when we see neutrals on the base embedding level
2021 following a character whose directionality is the same as the
2022 paragraph's. This avoids running the expensive loop when a line
2023 ends in a long sequence of neutrals, like control characters.
2024 Add assertion against STRONG_AL type. Slightly rearrange code
2025 that determines the type of a neutral given the first non-neutral
2027 (bidi_level_of_next_char): Set next_en_pos to zero when
2028 invalidating its info.
2030 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2032 * xdisp.c (push_display_prop): Determine whether to record string
2033 or buffer position by IT->string, not by IT->method. Allow
2034 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2035 (move_it_vertically_backward): Don't look for character position
2036 immediately after the newline when in a continuation line.
2039 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2041 * window.c (coordinates_in_window): Rewrite and delabelize
2042 vertical border check. (Bug#5357) (Bug#9618)
2044 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2046 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2047 errors in XSetWindowBorder (bug#9310).
2049 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2051 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2052 avoid crash when xmalloc overrun checking is enabled.
2054 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2056 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2057 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2058 cursor motion with <left> and <right> arrow keys.
2060 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2061 some callers set that themselves.
2063 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2065 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2066 display string and the previous row comes from the same string and
2067 is empty. (Bug#9739) (Bug#9738)
2069 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2071 * doc.c (get_doc_string): Encode file name (bug#9735).
2073 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2075 * bidi.c (bidi_level_of_next_char):
2076 * xdisp.c (get_visually_first_element): Remove old incorrect
2077 comments regarding the Unicode Line Separator character.
2079 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2081 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2083 * alloc.c (Fgc_status): Do not access beyond zombies array
2084 boundary if nzombies > MAX_ZOMBIES.
2085 * alloc.c (dump_zombies): Add missing format specifier.
2087 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2089 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2090 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2092 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2093 Some packages use them to denote characters with modifiers.
2095 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2097 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2098 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2099 matching a pp-number. Rename parameter var to var1.
2101 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2103 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2105 2011-10-08 Glenn Morris <rgm@gnu.org>
2107 * callint.c (Fcall_interactively): Give a more explicit error for the
2108 'c' case with a non-character input. (Bug#8479)
2110 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2112 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2114 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2115 lines that are hscrolled on the left.
2117 * dispnew.c (buffer_posn_from_coords): Account for a possible
2118 presence of header-line. (Bug#4426)
2120 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2122 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2123 Don't advertise functionality which we discourage or doesn't work.
2125 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2127 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2128 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2129 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2130 this makes Emacs dump core during garbage collection on rare
2131 occasions. sizeof is obviously inferior to offsetof here, so
2132 stick with offsetof.
2133 (GC_POINTER_ALIGNMENT): New macro.
2134 (mark_memory): Omit 3rd (offset) arg; caller changed.
2135 Don't assume EMACS_INT alignment is the same as pointer alignment.
2137 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2139 * keyboard.c (read_key_sequence_remapped): New var.
2140 (read_key_sequence): Compute remapping in the right buffer.
2141 (command_loop_1): Use read_key_sequence's remapping directly.
2143 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2145 * dired.c (file_name_completion): Don't expand file name.
2146 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2147 before checking file name handler.
2149 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2150 they've been requested explicitly (bug#9591).
2152 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2154 * keymap.c (Fsingle_key_description): Use make_specified_string
2155 instead of build_string to build string from push_key_description.
2158 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2160 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2161 This fixes a Y2038 bug on 64-bit hosts.
2162 * buffer.c (reset_buffer):
2163 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2164 (Fclear_buffer_auto_save_failure):
2165 Use 0, not -1, to represent an unset failure time, since time_t
2166 might not be signed.
2168 Remove dependency on glibc malloc internals.
2169 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2170 Move back here from lisp.h, but with their new implementations.
2171 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2172 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2173 * charset.c (charset_table_init): New static var.
2174 (syms_of_charset): Use it instead of xmalloc. This removes a
2175 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2176 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2177 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2178 Move back to alloc.c.
2179 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2180 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2182 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2184 * nsterm.m (windowDidResize): Call x_set_window_size only when
2185 ns_in_resize is true. Otherwise set pixelwidth/height and
2186 call change_frame_size (Bug#9628).
2188 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2190 Port --enable-checking=all to Fedora 14 x86-64.
2191 * charset.c (syms_of_charset): Also account for glibc malloc's
2192 internal overhead when calculating the initial malloc maximum.
2194 Port --enable-checking=all to Fedora 14 x86.
2195 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2197 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2198 (overrun_check_realloc, overrun_check_free):
2199 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2200 That way, xmalloc returns a properly-aligned pointer even if
2201 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2202 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2203 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2204 into account when calculating the initial malloc maximum.
2205 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2206 Move here from alloc.c, so that charset.c can use it too.
2207 Properly align; the old code wasn't right for common 32-bit hosts
2208 when configured with --enable-checking=all.
2209 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2210 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2212 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2214 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2217 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2219 * xdisp.c (compute_display_string_end): If there's no display
2220 string at CHARPOS, return -1.
2222 * bidi.c (bidi_fetch_char): When compute_display_string_end
2223 returns a negative value, treat the character as a normal
2224 character not covered by a display string. (Bug#9624)
2226 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2228 * lread.c (Fread_from_string): Fix typo in docstring.
2230 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2232 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2233 newline, reseat the iterator instead of bidi-iterating there one
2234 character at a time. (Bug#9610)
2235 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2236 TO_CHARPOS if the bidi iterator is at base embedding level.
2238 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2240 * lread.c (readevalloop): Use correct code for NBSP.
2241 (read1): Likewise. (Bug#9608)
2243 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2245 * dbusbind.c (Fdbus_register_signal): When service is not
2246 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2248 2011-09-25 Glenn Morris <rgm@gnu.org>
2250 * buffer.c (truncate-lines): Doc fix.
2252 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2254 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2255 (Fset_window_next_buffers): Doc fix.
2257 2011-09-24 Glenn Morris <rgm@gnu.org>
2259 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2261 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2263 Fix minor problems found by static checking.
2264 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2265 * indent.c (Fvertical_motion): Fix == vs = typo.
2267 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2269 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2270 Default value is now t. Doc fix.
2272 * indent.c (Fvertical_motion): Compute and apply the overshoot
2273 logic when moving up, not only when moving down. Fix the
2274 confusing name and values of the it_overshoot_expected variable;
2275 logic changes accordingly. (Bug#9254) (Bug#9549)
2277 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2278 CHARPOS is covered by a display string which includes newlines.
2279 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2280 is covered by a display string with embedded newlines.
2282 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2284 * dbusbind.c (Fdbus_register_signal): Add match rule to
2285 Vdbus_registered_objects_table. (Bug#9581)
2286 (Fdbus_register_method, Vdbus_registered_objects_table):
2289 2011-09-24 Jim Meyering <meyering@redhat.com>
2291 do not ignore write error for any output size
2292 The previous change was incomplete.
2293 While it makes emacs --batch detect the vast majority of stdout
2294 write failures, errors were still ignored whenever the output size is
2295 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2296 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2297 && echo FAIL: ignored write error
2298 FAIL: ignored write error
2299 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2300 && echo FAIL: ignored write error
2301 FAIL: ignored write error
2302 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2304 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2306 * emacs.c (Fkill_emacs): In noninteractive mode exit
2307 non-successfully if a write error occurred on stdout. (Bug#9574)
2309 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2311 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2314 * dispextern.h (struct it): Update the comment documenting what
2317 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2319 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2320 a display string, extend search for cursor position to end of row.
2321 (find_row_edges): If the row ends in a newline from a display
2322 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2323 Handle the case of a display string with multiple newlines.
2324 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2325 non-empty line. Fixes confusing cursor motion with arrow keys at
2326 the beginning of a line that starts with whitespace.
2328 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2330 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2333 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2335 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2338 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2340 * xdisp.c (display_line): Record maximum and minimum buffer
2341 positions even if no glyphs were produced (e.g., by a zero-width
2342 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2343 buffer positions that will be removed from the glyph row because
2345 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2346 column is beyond frame width: don't subtract 1 "pixel" when
2347 computing width of the stretch.
2348 (reseat_at_next_visible_line_start): Undo the change made on
2349 2011-09-17 that saved paragraph information and restored it after
2350 the call to `reseat'. (Bug#9545)
2352 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2354 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2355 and turn window cursor on if cleared (Bug#9415).
2357 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2359 * search.c (boyer_moore): Take unibyte characters from pattern
2360 literally. (Bug#9458)
2362 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2364 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2366 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2368 Fix minor problem found by static checking.
2369 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2370 initialized, to pacify gcc -Wuninitialized.
2372 * fileio.c: Report proper errno when syscall falls.
2373 (Finsert_file_contents): Save and restore errno,
2374 so that report_file_error outputs the correct diagnostic.
2375 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2377 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2379 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2381 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2383 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2384 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2386 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2388 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2389 about the current paragraph and restore it after the call to reseat.
2391 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2392 (bidi_find_paragraph_start): Search back for paragraph beginning
2393 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2394 (bidi_move_to_visually_next): Only trigger paragraph-related
2395 computations when the last character is a newline or at EOB, not
2396 just any NEUTRAL_B. (Bug#9470)
2398 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2399 truncated lines if point is covered by a display string. (Bug#9524)
2401 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2403 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2404 (cons_to_x_long): New function.
2405 (lisp_data_to_selection_data): Use it. Correct the test for
2406 short-versus-long data; it was negated. Break out of vector
2407 loop, for efficiency, when a long datum is discovered.
2409 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2411 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2413 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2415 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2416 GCC PR/17406) by declaring this function with external scope.
2418 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2420 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2421 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2423 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2425 * editfns.c (Fformat): Correctly handle text properties on "%%".
2427 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2429 * xterm.c (x_draw_composite_glyph_string_foreground):
2430 * w32term.c (x_draw_composite_glyph_string_foreground):
2431 * term.c (encode_terminal_code):
2432 * composite.c (composition_update_it, get_composition_id):
2433 * xdisp.c (get_next_display_element)
2434 (fill_composite_glyph_string): Add comments about special meaning
2435 of TAB characters in a composition.
2437 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2439 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2440 This occurs when processing a multibyte format.
2441 Problem reported by Wolfgang Jenker.
2443 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2445 * xdisp.c (try_cursor_movement): Only check for exact match if
2446 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2448 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2450 Remove unused external symbols.
2451 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2452 * xdisp.c (calc_pixel_width_or_height): Now static.
2453 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2454 * indent.c (check_display_width):
2455 * w32term.c: Fix comment to match code.
2456 * xterm.c, xterm.h (x_catching_errors): Remove.
2458 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2460 * xselect.c: Use signed conversions more consistently (Bug#9498).
2461 (selection_data_to_lisp_data): Assume incoming selection data are
2462 signed integers, not unsigned. This is to be consistent with
2463 outgoing selection data, which was modified to use signed integers
2464 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2465 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2466 expects long, not unsigned long.
2468 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2470 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2471 computation of loop end. Reported by Johan Bockgård
2474 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2476 * frame.c (Fother_visible_frames_p): Function deleted.
2478 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2480 * indent.c (compute_motion): Process display vector front to back
2481 rather than the other way around. (Bug#2496)
2483 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2485 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2487 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2489 * minibuf.c (Fread_from_minibuffer): Doc fix.
2491 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2493 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2494 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2496 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2498 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2499 value for non-existent files.
2501 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2503 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2504 set its "size" to -1. This will set the modtime_size field of
2505 the corresponding buffer to -1, which is what
2506 verify-visited-file-modtime expects for files that do not exist.
2509 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2511 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2513 * lisp.h: ... from here. push_key_description is no longer
2514 defined in keyboard.c, so its declaration should not be in
2515 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2516 logically belongs with push_key_description.
2518 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2520 * buffer.h: Include <sys/types.h> instead of <time.h>.
2521 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2522 Problem reported by Herbert J. Skuhra.
2524 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2526 * xml.c (parse_region): Make the parsing work for
2527 non-comment-starting XML files again (bug#9144).
2529 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2531 * image.c (gif_load): Fix calculation of bottom and right corner.
2534 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2536 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2537 redisplay in small windows.
2539 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2541 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2543 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2545 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2546 Operate on live windows only.
2548 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2550 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2552 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2554 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2555 only under bidi iteration.
2557 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2559 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2561 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2563 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2564 Without this fix, the command to link temacs failed due to an
2565 undefined symbol __builtin_isnan. This is because
2566 /usr/include/iso/math_c99.h #defines isnan(x) to
2567 __builtin_isnan(x), but the bundled gcc, which identifies itself
2568 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2570 * floatfns.c (isnan): #undef, and then #define to a clone of
2572 (Fisnan): Always define, since it's always available now.
2573 (syms_of_floatfns): Always define isnan at the Lisp level.
2575 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2577 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2579 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2581 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2582 The previous code assumed that file offsets (off_t values) fit in
2583 EMACS_INT variables, which is not true on typical 32-bit hosts.
2584 The code messed up by falsely reporting buffer overflow in cases
2585 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2586 when "big" contains more than 2**29 bytes, even though this
2587 inserts just one byte and does not overflow the buffer.
2588 (Finsert_file_contents): Store file offsets as off_t
2589 values, not as EMACS_INT values. Check for overflow when
2590 converting between EMACS_INT and off_t. When checking for
2591 buffer overflow or for overlap, take the offsets into account.
2592 Don't use EMACS_INT for small values where int suffices.
2593 When checking for overlap, fix a typo: ZV was used where
2594 ZV_BYTE was intended.
2595 (Fwrite_region): Don't assume off_t fits into 'long'.
2596 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2598 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2600 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2602 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2604 sprintf-related integer and memory overflow issues (Bug#9412).
2606 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2607 (esprintf, exprintf, evxprintf): New functions.
2608 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2609 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2610 (modify_event_symbol): Do not assume that the length of
2611 name_alist_or_stem is safe to alloca and fits in int.
2612 (Fexecute_extended_command): Likewise for function name and binding.
2613 (Frecursion_depth): Wrap around reliably on integer overflow.
2614 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2615 since some callers pass EMACS_INT values.
2616 (Fsingle_key_description): Don't crash if symbol name contains more
2617 than MAX_ALLOCA bytes.
2618 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2619 (get_minibuffer): Arg is now EMACS_INT, not int.
2620 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2621 (esprintf, exprintf, evxprintf): New decls.
2622 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2624 * dbusbind.c (signature_cat): New function.
2625 (xd_signature, Fdbus_register_signal):
2626 Do not overrun buffer; instead, report string overflow.
2628 * dispnew.c (add_window_display_history): Don't overrun buffer.
2629 Truncate instead; this is OK since it's just a log.
2631 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2632 even if the time zone offset is outlandishly large.
2633 Don't mishandle offset == INT_MIN.
2635 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2636 when creating daemon; the previous buffer-overflow check was incorrect.
2638 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2639 which has the guts of the old verror function.
2641 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2642 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2644 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2645 (font_unparse_xlfd): Don't blindly alloca long strings.
2646 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2647 fits in int, when using sprintf. Use single snprintf to count
2648 length of string rather than counting it via multiple sprintfs;
2649 that's simpler and more reliable.
2650 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2651 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2652 sprintf, in case result does not fit in int.
2654 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2655 (fontset_from_font): Print it.
2657 * frame.c (tty_frame_count): Now printmax_t, not int.
2658 (make_terminal_frame, set_term_frame_name): Print it.
2659 (x_report_frame_params): In X, window IDs are unsigned long,
2660 not signed long, so print them as unsigned.
2661 (validate_x_resource_name): Check for implausibly long names,
2662 and don't assume name length fits in 'int'.
2663 (x_get_resource_string): Don't blindly alloca invocation name;
2664 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2667 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2668 (xg_check_special_colors, xg_set_geometry):
2669 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2671 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2672 Use esprintf, not sprintf, in case result does not fit in int.
2674 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2675 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2676 it as a large positive number.
2677 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2678 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2680 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2681 in case result does not fit in int.
2683 * print.c (float_to_string): Detect width overflow more reliably.
2684 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2685 buffer overrun. Don't assume list length fits in 'int'. Treat
2686 print length of 0 as 0, not as infinity; to be consistent with other
2687 uses of print length in this function. Don't overflow print length
2688 index. Don't assume hash table size fits in 'long', or that
2689 vectorlike size fits in 'unsigned long'.
2691 * process.c (make_process): Use printmax_t, not int, to format
2692 process-name gensyms.
2694 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2696 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2697 to avoid potential buffer overrun.
2699 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2700 if X resource line is longer than 512 bytes.
2702 * xfns.c (x_window): Make sprintf buffer a bit bigger
2703 to avoid potential buffer overrun.
2705 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2707 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2709 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2711 Integer overflow fixes for scrolling, etc.
2712 Without these, Emacs silently mishandles large integers sometimes.
2713 For example, "C-u 4294967297 M-x recenter" was treated as if
2714 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2716 * xdisp.c (try_window_id): Check Emacs fixnum range before
2717 converting to 'int'.
2719 * window.c (window_scroll_line_based, Frecenter):
2720 Check that an Emacs fixnum is in range before assigning it to 'int'.
2721 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2722 values converted from Emacs fixnums.
2723 (Frecenter): Don't wrap around a line count if it is out of 'int'
2724 range; instead, treat it as an extreme value.
2725 (Fset_window_configuration, compare_window_configurations):
2726 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2728 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2729 that can exceed INT_MAX. Check that EMACS_INT value is in range
2730 before assigning it to the (possibly-narrower) index.
2731 (match_limit): Don't assume that a fixnum can fit in 'int'.
2733 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2736 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2737 (Fvertical_motion): Don't wrap around LINES values that don't fit
2738 in 'int'. Instead, treat them as extreme values. This is good
2739 enough for windows, which can't have more than INT_MAX lines anyway.
2741 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2743 * Require libxml/parser.h to avoid compilation warning.
2745 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2747 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2748 since this reportedly can destroy thread storage.
2750 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2752 * syntax.c (find_defun_start): Update all cache variables if
2753 exiting early (Bug#9401).
2755 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2757 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2759 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2760 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2761 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2763 * term.c (tty_append_glyph): New function.
2764 (produce_stretch_glyph): Static function and its prototype deleted.
2766 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2769 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2771 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2772 when checking :margin (Bug#9390).
2773 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2774 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2775 so that the name doesn't mislead. All uses changed.
2777 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2779 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2782 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2784 * xdisp.c (move_it_to): Don't bail out early when reaching
2785 position beyond to_charpos, if we are scanning backwards.
2786 (move_it_vertically_backward): When DY == 0, make sure we get to
2787 the first character in the line after the newline.
2789 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2791 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2792 (ccl_driver): Do not generate an out-of-range pointer.
2793 (Fccl_execute_on_string): Remove unnecessary check for
2794 integer overflow, noted by Stefan Monnier in
2795 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2796 Remove a FIXME that didn't need fixing.
2797 Simplify the newly-introduced buffer reallocation code.
2799 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2801 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2803 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2805 Integer and memory overflow issues (Bug#9196).
2807 * doc.c (get_doc_string): Rework so that
2808 get_doc_string_buffer_size is the actual buffer size, rather than
2809 being 1 less than the actual buffer size; this makes xpalloc more
2812 * image.c (x_allocate_bitmap_record, cache_image):
2813 * xselect.c (Fx_register_dnd_atom):
2814 Simplify previous changes by using xpalloc.
2816 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2817 since either will do and ptrdiff_t is convenient with xpalloc.
2819 * charset.c (charset_table_size)
2820 (struct charset_sort_data.priority): Now ptrdiff_t.
2821 (charset_compare): Don't overflow if priorities differ greatly.
2822 (Fsort_charsets): Don't assume list length fits in int.
2823 Check for size-calculation overflow when allocating sort data.
2824 (syms_of_charset): Allocate an initial charset table that is
2825 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2827 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2829 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2830 The actual value is always <= INT_MAX, and leaving it unsigned made
2831 overflow checking harder.
2833 * dispextern.h (struct glyph_matrix.rows_allocated)
2834 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2835 with xpalloc. The values are still always <= INT_MAX.
2837 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2839 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2840 (SAFE_NALLOCA): New macro.
2842 * region-cache.c (struct boundary.pos, find_cache_boundary)
2843 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2844 (set_cache_region, invalidate_region_cache)
2845 (revalidate_region_cache, know_region_cache, region_cache_forward)
2846 (region_cache_backward, pp_cache):
2847 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2848 so that ptrdiff_t * can be passed to xpalloc.
2849 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2850 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2851 (pp_cache): Don't assume cache_len fits in int.
2852 * region-cache.h: Adjust extern decls to match.
2854 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2855 EMACS_INT, since either will do, for xpalloc.
2857 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2858 (xnmalloc, xnrealloc, xpalloc): New functions.
2860 * bidi.c (bidi_shelve_header_size): New constant.
2861 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2862 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2864 * bidi.c (bidi_cache_shrink):
2865 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2867 Don't update size of array until after memory allocation succeeds,
2868 because xmalloc/xrealloc may not return.
2869 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2870 now that we have proper integer overflow checking.
2871 (record_overlay_string, overlay_strings): Catch overflows when
2872 calculating size of overlay_str_buf.
2874 * callproc.c (Fcall_process): Check for size overflow when
2875 calculating size of args2.
2876 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2877 Normally we prefer signed values, but sticking with ptrdiff_t would
2878 require adding more-complicated checks.
2880 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2881 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2882 Redo buffer-overflow calculations to avoid integer overflow.
2883 Add a FIXME comment where memory seems to be over-allocated.
2885 * character.c (Fstring): Check for size-calculation overflow.
2887 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2888 unnecessary integer overflow. Check for size overflow.
2889 (encode_coding_object): Don't update size until xmalloc succeeds.
2891 * composite.c (get_composition_id): Check for overflow in glyph
2892 length calculations.
2894 Integer and memory overflow fixes for display code.
2895 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2896 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2897 (scrolling_window): Check for overflow in size calculations.
2898 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2899 Don't assume glyph table len fits in int.
2900 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2901 (row_table_size): Now ptrdiff_t, not int.
2902 (scrolling_window): Avoid overflow in size calculations.
2903 Don't update size until allocation succeeds.
2904 * fns.c (concat): Check for overflow in size calculations.
2905 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2906 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2907 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2909 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2910 (get_doc_string): Check for size calculation overflow.
2911 Don't update size until allocation succeeds.
2912 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2913 EMACS_INT, where ptrdiff_t will do.
2914 (Fsubstitute_command_keys): Check for string overflow.
2916 * editfns.c (set_time_zone_rule): Don't assume environment length
2918 (message_length): Now ptrdiff_t, not int.
2919 (Fmessage_box): Don't update size until allocation succeeds.
2920 Don't assume message length fits in int.
2921 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2923 * emacs.c (main): Do not reallocate argv, since there is a null at
2924 the end that can be overwritten, and this way there's no need to
2925 worry about size-calculation overflow.
2926 (sort_args): Check for size-calculation overflow.
2928 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2930 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2932 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2933 (x_set_scroll_bar_width, x_figure_window_size):
2934 Check for integer overflow.
2935 (x_set_alpha): Do not assume XINT fits in int.
2937 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2938 This is for the members text_lines, text_cols, total_lines, total_cols,
2939 where the system imposes an 'int' limit.
2941 * fringe.c (Fdefine_fringe_bitmap):
2942 Don't update size until alloc works.
2944 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2945 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2947 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2948 Check for size-calculation overflow.
2949 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2950 do, as we prefer signed integers.
2951 (id_to_widget.max_size, id_to_widget.used)
2952 (xg_store_widget_in_map, xg_remove_widget_from_map)
2953 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2954 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2955 Use and return ptrdiff_t, not int.
2956 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2957 * gtkutil.h: Change prototypes to match the above.
2959 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2960 are duplicate now that they've been promoted to lisp.h.
2961 (x_allocate_bitmap_record, x_alloc_image_color)
2962 (make_image_cache, cache_image, xpm_load):
2963 Don't update size until alloc is done.
2964 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2966 Check for size calculation overflow.
2967 (ct_colors_allocated_max): New constant.
2968 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2971 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2972 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2973 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2974 Use ptrdiff_t, not int, to count maps.
2975 (read_char_minibuf_menu_prompt): Check for overflow in size
2976 calculations. Don't update size until allocation succeeds.
2977 Redo calculations to avoid overflow.
2978 * keyboard.h: Change prototypes to match the above.
2980 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2982 (current_minor_maps): Check for size calculation overflow.
2983 * keymap.h: Change prototypes to match the above.
2985 * lread.c (read1, init_obarray): Don't update size until alloc done.
2987 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2988 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2990 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2991 Now ptrdiff_t, not int.
2992 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2993 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2995 * process.c (Fnetwork_interface_list): Check for overflow
2996 in size calculation.
2998 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3000 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3001 overflow. Don't bother calling xmalloc when xrealloc will do.
3003 * search.c (Freplace_match): Check for size calculation overflow.
3004 (Fset_match_data): Don't assume list lengths fit in 'int'.
3006 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3007 for command line length. Do not attempt to address one before the
3008 beginning of an array, as that's not portable.
3010 * term.c (max_frame_lines): Remove; unused.
3011 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3013 (encode_terminal_code, calculate_costs): Check for size
3014 calculation overflow.
3015 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3016 table lengths and related sizes. Don't update size until alloc
3017 done. Redo calculations to avoid overflow.
3018 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3020 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3021 subtracting pointers.
3022 (gobble_line): Check for overflow more carefully. Don't update size
3025 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3026 Don't update size until alloc done.
3027 Redo size calculations to avoid overflow.
3028 Check for size calculation overflow.
3029 (main) [DEBUG]: Fix typo in invoking tparam1.
3031 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3032 Use ptrdiff_t, not int, for sizes.
3033 (store_mode_line_noprop_char): Don't update size until alloc done.
3035 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3036 Use ptrdiff_t, not int, for sizes.
3037 (Finternal_make_lisp_face, cache_face):
3038 Check for size calculation overflow.
3039 (cache_face): Treat size calculation overflows as if they were
3040 memory exhaustion (the usual treatment), rather than aborting.
3042 * xfns.c (x_encode_text, x_set_name_internal)
3043 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3044 sizes, since they can exceed INT_MAX in size. Check for size
3045 calculation overflow.
3047 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3048 (xg_select): Check for size calculation overflow.
3049 Don't update size until alloc done.
3051 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3052 as sprintf is limited to int lengths.
3054 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3055 (X_LONG_MIN): New macros.
3056 Use them to make the following changes clearer.
3057 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3058 This change doesn't affect the value now, but it may help remind
3059 future maintainers not to raise the value too much later.
3060 (SELECTION_QUANTUM): Remove, replacing with ...
3061 (selection_quantum): ... new function, which avoids overflow.
3063 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3064 assumption that selection length fits in 'int'.
3065 (x_reply_selection_request, x_handle_selection_request)
3066 (x_get_window_property, receive_incremental_selection)
3067 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3068 (lisp_data_to_selection_data, clean_local_selection_data):
3069 Use ptrdiff_t, not int, to record length of selection.
3070 (x_reply_selection_request, x_get_window_property)
3071 (receive_incremental_selection, x_property_data_to_lisp):
3072 Redo calculations to avoid overflow.
3073 (x_reply_selection_request): When sending hint, ceiling it at
3074 X_LONG_MAX rather than relying on wraparound overflow to send
3076 (x_get_window_property, receive_incremental_selection)
3077 (lisp_data_to_selection_data, x_property_data_to_lisp):
3078 Check for size-calculation overflow.
3079 (x_get_window_property, receive_incremental_selection)
3080 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3081 Don't store size until memory allocation succeeds.
3082 (x_get_window_property): Plug memory leak on memory exhaustion.
3083 Don't double-block input; malloc is safe here. Don't assume 2**34
3084 - 4 fits in unsigned long. Add an xassert to check
3085 XGetWindowProperty overflow. Be more careful about overflow
3086 calculations, and distinguish size from memory overflow better.
3087 (receive_incremental_selection): When tracing, don't assume
3088 unsigned int is less than INT_MAX.
3089 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3090 harmful) conversions of unsigned short to int.
3091 (lisp_data_to_selection_data): Don't assume that integers
3092 in the range -65535 through -1 fit in an X unsigned short.
3093 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3094 result parameters unless successful. Rely on cons_to_unsigned
3095 to report problems with elements; the old code wasn't right anyway.
3096 (x_check_property_data): Check for int overflow; we cannot use
3097 a wider type due to X limits.
3098 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3100 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3102 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3103 (x_term_init): Check for size calculation overflow.
3104 (x_color_cells): Don't store size until memory allocation succeeds.
3105 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3106 Don't assume alloca size is less than MAX_ALLOCA.
3107 (x_term_init): Don't assume length fits in int (sprintf is limited
3110 Use ptrdiff_t for composition IDs.
3111 * character.c (lisp_string_width):
3112 * composite.c (composition_table_size, n_compositions)
3113 (get_composition_id, composition_gstring_from_id):
3114 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3115 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3116 * window.c (Frecenter):
3117 Use ptrdiff_t, not int, for composition IDs.
3118 * composite.c (get_composition_id): Check for integer overflow.
3119 * composite.h: Adjust prototypes to match the above changes.
3121 Use ptrdiff_t for hash table indexes.
3122 * category.c (hash_get_category_set):
3123 * ccl.c (ccl_driver):
3124 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3125 * coding.c (coding_system_charset_list, detect_coding_system):
3126 * coding.h (struct coding_system.id):
3127 * composite.c (get_composition_id, gstring_lookup_cache):
3128 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3129 * image.c (xpm_get_color_table_h):
3130 * lisp.h (hash_lookup, hash_put):
3131 * minibuf.c (Ftest_completion):
3132 Use ptrdiff_t for hash table indexes, not int (which is too
3133 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3134 32-bit --with-wide-int hosts).
3136 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3137 Add a FIXME comment about memory leaks.
3138 (syms_of_charset): Don't assume xmalloc returns.
3140 Don't assume that stated character widths fit in int.
3141 * character.c (Fchar_width, c_string_width, lisp_string_width):
3142 * character.h (CHAR_WIDTH):
3143 * indent.c (MULTIBYTE_BYTES_WIDTH):
3144 Use sanitize_char_width to avoid undefined and/or bad behavior
3145 with outlandish widths.
3146 * character.h (sanitize_tab_width): Rename from sanitize_width,
3147 now that we have two such functions. All uses changed.
3148 (sanitize_char_width): New inline function.
3150 Don't assume that tab-width fits in int.
3151 * character.h (sanitize_width): New inline function.
3152 (SANE_TAB_WIDTH): New macro.
3153 (ASCII_CHAR_WIDTH): Use it.
3154 * indent.c (sane_tab_width): Remove. All uses replaced by
3155 SANE_TAB_WIDTH (current_buffer).
3156 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3158 * fileio.c: Integer overflow issues with file modes.
3159 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3161 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3162 Remove unreachable code.
3163 (read_hex, load_charset_map_from_file): Check for integer overflow.
3165 * xterm.c: Don't go over XClientMessageEvent limit.
3166 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3167 (x_send_scroll_bar_event): Likewise. Check that the size does not
3168 exceed limits imposed by XClientMessageEvent, as well as the usual
3169 ptrdiff_t and size_t limits.
3171 * keyboard.c: Overflow, signedness and related fixes.
3172 (make_lispy_movement): Use same integer type in forward decl
3173 that is used in the definition.
3174 (read_key_sequence, keyremap_step):
3175 Change bufsize argument back to int, undoing my 2011-03-30 change.
3176 We prefer signed types, and int is wide enough here.
3177 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3178 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3179 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3180 length, not size_t. Use ptrdiff_t for index, not int.
3181 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3182 possibility of integer overflow.
3184 Overflow, signedness and related fixes for images.
3186 * dispextern.h (struct it.stack[0].u.image.image_id)
3187 (struct_it.image_id, struct image.id, struct image_cache.size)
3188 (struct image_cache.used, struct image_cache.ref_count):
3189 * gtkutil.c (update_frame_tool_bar):
3190 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3191 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3192 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3193 * nsmenu.m (update_frame_tool_bar):
3194 * xdisp.c (calc_pixel_width_or_height):
3195 * xfns.c (image_cache_refcount):
3196 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3197 on typical 64-bit hosts.
3199 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3200 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3201 Omit unnecessary casts to int.
3202 (parse_image_spec): Check that integers fall into 'int' range
3203 when the callers expect that.
3204 (image_ascent): Redo ascent calculation to avoid int overflow.
3205 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3206 (lookup_image): Remove unnecessary tests.
3207 (xbm_image_p): Locals are now of int, not EMACS_INT,
3208 since parse_image_check makes sure they fit into int.
3209 (png_load, gif_load, svg_load_image):
3210 Prefer int to unsigned where either will do.
3211 (tiff_handler): New function, combining the cores of the
3212 old tiff_error_handler and tiff_warning_handler.
3213 This function is rewritten to use vsnprintf and thereby avoid
3214 stack buffer overflows. It uses only the features of vsnprintf
3215 that are common to both POSIX and native Microsoft.
3216 (tiff_error_handler, tiff_warning_handler): Use it.
3217 (tiff_load, gif_load, imagemagick_load_image):
3218 Don't assume :index value fits in 'int'.
3219 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3220 (imagemagick_load_image): Check that crop parameters fit into
3221 the integer types that MagickCropImage accepts. Don't assume
3222 Vimagemagick_render_type has a nonnegative value. Don't assume
3223 size_t fits in 'long'.
3224 (gs_load): Use printmax_t to print the widest integers possible.
3225 Check for integer overflow when computing image height and width.
3227 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3229 * xdisp.c (redisplay_window): Don't force window start if point
3230 will be invisible in the resulting window. (Bug#9324)
3232 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3234 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3235 the display spec is of the form `(space ...)'.
3236 (handle_display_spec): Return the value returned by
3237 handle_single_display_spec, not just 1 or zero.
3238 (handle_single_display_spec): If the display spec is of the form
3239 `(space ...)', and specifies display in the text area, return 2
3241 (try_cursor_movement): Check for the need to scroll more
3242 accurately, and prefer exact match for point under bidi.
3243 Don't advance `row' beyond the last row of the window.
3245 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3246 into disp_prop; all users changed.
3248 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3249 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3250 for the text covered by the display property.
3252 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3254 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3255 Change return value to nil.
3256 (Frecord_buffer): Delete unused function.
3258 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3260 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3261 buffers, return left-to-right.
3262 (set_cursor_from_row): Consider candidate row a win if its glyph
3263 represents a newline and point is on that newline. Fixes cursor
3264 positioning on the newline at EOL of R2L text within L2R
3265 paragraph, and vice versa.
3266 (try_cursor_movement): Check continued rows, in addition to
3267 continuation rows. Fixes unwarranted scroll when point enters a
3268 continued line of R2L text within an L2R paragraph, or vice versa.
3269 (cursor_row_p): Consider the case of point being equal to
3270 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3271 from the end of a short line to the beginning of a continued line
3272 of R2L text within L2R paragraph.
3273 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3274 composed characters.
3276 * bidi.c (bidi_check_type): Use xassert.
3277 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3280 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3282 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3285 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3287 * nsfont.m (ns_otf_to_script): Fix typo.
3289 2011-08-22 Kenichi Handa <handa@m17n.org>
3291 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3292 extra slot even if the purpose is char-code-property-table.
3294 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3296 * xdisp.c (redisplay_window): When computing centering_position,
3297 account for the height of the header line. (Bug#8874)
3299 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3300 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3301 candidate is selected by the mouse, and that candidate has a
3302 composed character under the mouse.
3304 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3305 coordinates reported by pos-visible-in-window-p for a composed
3306 character in column zero.
3308 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3310 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3312 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3314 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3315 consider it a hit if to_charpos is anywhere in the range of the
3316 composed buffer positions.
3318 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3320 * image.c (gif_load): Don't assume that each subimage has the same
3321 dimensions as the base image. Handle disposal method that is
3322 "undefined" by the gif spec (Bug#9335).
3324 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3326 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3327 (Fcondition_case): Document `debug' symbol in error handler.
3329 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3331 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3332 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3333 from an Org mode buffer to a Speedbar frame.
3335 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3336 a composition, take its buffer position from IT->cmp_it.charpos.
3337 Fixes cursor positioning at the beginning of a line that begins
3338 with a composed character.
3340 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3342 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3343 character bidirectional type, use STRONG_L instead. Fixes crashes
3344 in a buffer produced by `describe-categories'.
3346 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3347 members before the level stack, so they would be saved and
3348 restored when copying iterator state. Fixes incorrect reordering
3349 around TABs covered by display properties.
3351 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3353 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3355 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3357 * eval.c (internal_condition_case, internal_condition_case_1)
3358 (internal_condition_case_2, internal_condition_case_n):
3359 Remove unnecessary aborts (Bug#9081).
3361 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3363 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3364 has no `load' handler, try opening the file locally. (Bug#9311)
3366 2011-08-16 Ken Brown <kbrown@cornell.edu>
3368 * gmalloc.c: Expand comment.
3370 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3372 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3373 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3375 2011-08-16 Ken Brown <kbrown@cornell.edu>
3377 Fix memory allocation problems in Cygwin build (Bug#9273).
3379 * unexcw.c ( __malloc_initialized): Declare external variable.
3380 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3382 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3384 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3386 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3388 [CYGWIN] (special_realloc): New function.
3389 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3390 requests to realloc storage in the static heap.
3392 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3394 * bidi.c (bidi_initialize): Remove unused local.
3396 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3399 * biditype.h: Remove file.
3400 * makefile.w32-in ($(BLD)/bidi.$(O)):
3401 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3403 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3405 * chartab.c: Improve commentary for the uniprop_table API.
3407 * bidi.c (bidi_paragraph_init): Support zero value of
3408 bidi_ignore_explicit_marks_for_paragraph_level.
3409 (bidi_initialize): Use uniprop_table instead of including
3410 biditype.h and bidimirror.h.
3412 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3413 coordinates of the iterator when restoring from ppos_it.
3416 2011-08-14 Kenichi Handa <handa@m17n.org>
3418 * process.c (create_process): Call setup_process_coding_systems
3419 after the pid of the process is set to -1 (Bug#8162).
3421 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3423 * xdisp.c (move_it_in_display_line_to): Don't invoke
3424 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3425 ppos_it. Fixes vertical cursor motion when line beginning is
3426 covered by an image. (Bug#9296)
3428 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3430 * nsterm.h (ns_run_ascript): Declare.
3431 (NSAPP_DATA2_RUNASSCRIPT): Define.
3433 * nsfns.m (as_script, as_result, as_status): New static variables.
3434 (ns_run_ascript): New function.
3435 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3436 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3437 the event loop. Get status from as_status (Bug#7276).
3439 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3440 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3441 the event loop (Bug#7276).
3443 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3445 * gnutls.c (QCgnutls_bootprop_priority)
3446 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3447 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3448 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3449 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3450 (QCgnutls_bootprop_verify_hostname_error)
3451 (QCgnutls_bootprop_callbacks_verify): Rename from
3452 Qgnutls_bootprop_..., all uses changed.
3454 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3457 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3459 * xfaces.c (Qframe_set_background_mode): Now static.
3460 * dispextern.h (Qframe_set_background_mode): Remove decl.
3462 * process.c (Fnetwork_interface_info): Declare local only if needed.
3464 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3466 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3467 (Fnetwork_interface_list): Allocate in increments of bytes instead
3468 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3469 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3471 (struct ifflag_def): notrailers is smart on OSX.
3472 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3473 Get hardware address with getifaddrs if available.
3475 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3477 * xdisp.c (iterate_out_of_display_property): xassert that
3478 IT->position is set to within IT->object's boundaries. Break from
3479 the loop as soon as EOB is reached; avoids infloops in redisplay
3480 when IT->position is set up wrongly due to some bug.
3481 Set IT->current to match the bidi iterator unconditionally.
3482 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3483 entry. Force push_it to save on the stack the current
3484 buffer/string position, to be restored by pop_it. Fix flags in
3485 the iterator structure wrt the object coming from a display
3486 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3487 properties. (Bug#9284)
3489 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3491 * fontset.c (fontset_get_font_group): Add proper type checks.
3494 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3496 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3497 and LC_VERSION_MIN_MACOSX.
3498 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3499 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3501 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3503 * xdisp.c (forward_to_next_line_start): Allow to use the
3504 no-display-properties-and-no-overlays under bidi display.
3505 Set disp_pos in the bidi iterator to avoid searches for display
3506 properties and overlays.
3508 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3510 * editfns.c (Fset_time_zone_rule): Document relationship with the
3513 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3514 the font entity extracted from the cache (Bug#8109).
3516 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3518 * composite.c (autocmp_chars): Don't reset point. That is done by
3519 restore_point_unwind (Bug#5984).
3521 2011-08-07 Juri Linkov <juri@jurta.org>
3523 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3524 to show the arg `TIME' instead of `TIMEVAL'.
3526 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3528 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3529 display property strides EOL and includes a newline, as in
3530 longlines-mode. (Bug#9254)
3531 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3532 word-wrap under bidirectional display. (Bug#9224)
3534 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3535 is non-zero, even if the data buffer is NULL. Fixes a crash in
3536 vertical-motion with longlines-mode. (Bug#9254)
3538 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3540 * bidi.c <bidi_cache_total_alloc>: Now static.
3541 (bidi_initialize): Initialize bidi_cache_total_alloc.
3543 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3546 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3547 amount allocated this far in `bidi_cache_total_alloc'.
3548 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3549 non-zero, only free the data buffer without restoring the cache
3550 contents. All callers changed.
3552 * dispextern.h (bidi_unshelve_cache): Update prototype.
3554 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3555 (move_it_in_display_line, move_it_to)
3556 (move_it_vertically_backward, move_it_by_lines): Replace the call
3557 to xfree to an equivalent call to bidi_unshelve_cache.
3558 (move_it_in_display_line_to): Fix logic of returning
3559 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3561 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3563 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3564 came from a string character with a `cursor' property. (Bug#9229)
3566 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3568 * Makefile.in (LIB_PTHREAD): New variable.
3569 (LIBES): Add LIB_PTHREAD (Bug#9216).
3571 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3572 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3574 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3576 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3578 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3580 * xterm.c (x_find_topmost_parent): New function.
3581 (x_set_frame_alpha): Find topmost parent window with
3582 x_find_topmost_parent and set the property there also (bug#9181).
3583 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3585 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3587 * callproc.c (Fcall_process): Avoid vfork clobbering
3588 the local vars buffer, coding_systems, current_dir.
3590 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3592 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3594 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3596 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3597 so that it is not optimized away.
3599 * xdisp.c (compute_display_string_pos): Remove unused local.
3601 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3603 Fix slow cursor motion and scrolling in large buffers with
3604 selective display, like Org Mode buffers. (Bug#9218)
3606 * dispextern.h (struct bidi_it): New member disp_prop_p.
3608 * xdisp.c: Remove one-slot cache of display string positions.
3609 (compute_display_string_pos): Accept an additional argument
3610 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3611 for a display string or property. If found, set DISP_PROP_P
3614 * bidi.c (bidi_fetch_char): Accept an additional argument
3615 DISP_PROP_P, and pass it to compute_display_string_pos.
3616 Only handle text covered by a display string if DISP_PROP_P is returned
3617 non-zero. All callers of bidi_fetch_char changed.
3619 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3621 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3623 2010-12-03 Don March <don@ohspite.net>
3625 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3626 last character M-[char] is translated to ESC [char] (bug#7541).
3628 2011-08-02 Kenichi Handa <handa@m17n.org>
3630 * lisp.h (uniprop_table): Extern it.
3632 * chartab.c (uniprop_table): Make it non-static.
3634 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3636 * xdisp.c (forward_to_next_line_start): Accept additional argument
3637 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3639 (reseat_at_next_visible_line_start): Use the bidi iterator state
3640 returned by forward_to_next_line_start to restore the state of
3641 it->bidi_it after backing up to previous newline. (Bug#9212)
3643 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3645 * regex.c (re_comp): Protoize.
3646 (re_exec): Fix return type.
3647 (regexec): Fix type of `ret'. (Bug#9203)
3649 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3651 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3652 This is needed if max-image-size is a floating-point number.
3654 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3656 * print.c (print_object): Print empty symbol as ##.
3658 * lread.c (read1): Read ## as empty symbol.
3660 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3662 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3663 setting frame foreground color (Bug#9175).
3664 (x_set_background_color): Likewise.
3666 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3667 contents (Bug#9176).
3668 (EmacsTooltip -init): Remove bezels and add shadows to
3671 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3672 or scroll bar (Bug#8470).
3674 * nsfont.m (nsfont_open): Remove assignment to voffset and
3675 unnecessary vars hshink, expand, hd, full_height, min_height.
3676 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3678 * nsterm.h (nsfont_info): Remove voffset field.
3680 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3682 Implement strike-through and overline on NextStep (Bug#8863).
3684 * nsfont.m (nsfont_open): Use underline position provided by font,
3685 instead of hard-coded value of 2.
3686 (nsfont_draw): Call ns_draw_text_decoration instead.
3688 * nsterm.h: Add declaration for ns_draw_text_decoration.
3690 * nsterm.m (ns_draw_text_decoration): New function for drawing
3691 underline, overline, and strike-through.
3692 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3693 ns_draw_text_decoration. Change treatment of cursor drawing to
3694 accommodate underlining, etc.
3696 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3698 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3701 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3703 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3704 Without this fix, if a signal arrives just after memory fills up,
3705 'malloc' might be invoked reentrantly.
3707 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3708 In other words, assume that every image size is allowed, on non-X
3709 hosts. This assumption is probably wrong, but it lets Emacs compile.
3711 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3713 * regex.c (re_iswctype): Convert return values to boolean.
3715 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3717 * xdisp.c (compute_display_string_pos): Don't use cached display
3718 string position if the buffer had its restriction changed.
3721 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3723 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3725 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3727 Integer signedness and overflow and related fixes. (Bug#9079)
3729 * bidi.c: Integer size and overflow fixes.
3730 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3731 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3732 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3733 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3734 (bidi_find_other_level_edge):
3735 Use ptrdiff_t instead of EMACS_INT where either will do.
3736 This works better on 32-bit hosts configured --with-wide-int.
3737 (bidi_cache_ensure_space): Check for size-calculation overflow.
3738 Use % rather than repeated addition, for better worst-case speed.
3739 Don't set bidi_cache_size until after xrealloc returns, because it
3741 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3742 (bidi_cache_ensure_space): Also check that the bidi cache size
3743 does not exceed that of the largest Lisp string or buffer. See Eli
3744 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3746 * alloc.c (__malloc_size_t): Remove.
3747 All uses replaced by size_t. See Andreas Schwab's note
3748 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3750 * image.c: Improve checking for integer overflow.
3751 (check_image_size): Assume that f is nonnull, since
3752 it is always nonnull in practice. This is one less thing to
3753 worry about when checking for integer overflow later.
3754 (x_check_image_size): New function, which checks for integer
3755 overflow issues inside X.
3756 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3757 This removes the need for a memory_full check.
3758 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3759 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3760 (xbm_read_bitmap_data): Change locals back to 'int', since
3761 their values must fit in 'int'.
3762 (xpm_load_image, png_load, tiff_load):
3763 Invoke x_create_x_image_and_pixmap earlier,
3764 to avoid much needless work if the image is too large.
3765 (tiff_load): Treat overly large images as if
3766 x_create_x_image_and_pixmap failed, not as malloc failures.
3767 (gs_load): Use x_check_image_size.
3769 * gtkutil.c: Omit integer casts.
3770 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3771 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3773 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3775 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3776 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3777 would wrongly return t on a 64-bit host.
3779 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3780 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3781 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3782 and therefore cause GCC to emit a bogus diagnostic in some cases.
3784 * image.c: Integer signedness and overflow and related fixes.
3785 This is not an exhaustive set of fixes, but it's time to
3786 record what I've got.
3787 (lookup_pixel_color, check_image_size): Remove redundant decls.
3788 (check_image_size): Don't assume that arbitrary EMACS_INT values
3789 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3790 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3791 (tiff_load, imagemagick_load_image):
3792 Check for overflow in size calculations.
3793 (x_create_x_image_and_pixmap): Remove unnecessary test for
3794 xmalloc returning NULL; that can't happen.
3795 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3796 (xpm_color_bucket): Use better integer hashing function.
3797 (xpm_cache_color): Don't possibly over-allocate memory.
3798 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3799 (gif_memory_source):
3800 Use ptrdiff_t, not int or size_t, to record sizes.
3801 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3802 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3803 either works, as we prefer signed integers.
3804 (tiff_read_from_memory, tiff_write_from_memory):
3805 Return tsize_t, not size_t, since that's what the TIFF API wants.
3806 (tiff_read_from_memory): Don't fail simply because the read would
3807 go past EOF; instead, return a short read.
3808 (tiff_load): Omit no-longer-needed casts.
3809 (Fimagemagick_types): Don't assume size fits into 'int'.
3811 Improve hashing quality when configured --with-wide-int.
3812 * fns.c (hash_string): New function, taken from sxhash_string.
3813 Do not discard information about ASCII character case; this
3814 discarding is no longer needed.
3815 (sxhash-string): Use it. Change sig to match it. Caller changed.
3816 * lisp.h: Declare it.
3817 * lread.c (hash_string): Remove, since we now use fns.c's version.
3818 The fns.c version returns a wider integer if --with-wide-int is
3819 specified, so this should help the quality of the hashing a bit.
3821 * emacs.c: Integer overflow minor fix.
3822 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3823 Define only if GNU_LINUX.
3824 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3826 * dispnew.c: Integer signedness and overflow fixes.
3827 Remove unnecessary forward decls, that were a maintenance hassle.
3828 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3830 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3831 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3832 (prepare_desired_row, line_draw_cost):
3833 Use int, not unsigned, where either works.
3834 (save_current_matrix, restore_current_matrix):
3835 Use ptrdiff_t, not size_t, where either works.
3836 (init_display): Check for overflow more accurately, and without
3837 relying on undefined behavior.
3839 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3840 Remove, replacing with the new symbols in lisp.h. All uses changed.
3841 * fileio.c (make_temp_name):
3842 * filelock.c (lock_file_1, lock_file):
3843 * xdisp.c (message_dolog):
3844 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3845 Use pMd etc. instead.
3846 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3847 replacing the pWIDE etc. symbols removed from editfns.c.
3849 * keyboard.h (num_input_events): Now uintmax_t.
3850 This is (very slightly) less likely to mess up due to wraparound.
3853 * buffer.c: Integer signedness fixes.
3854 (alloc_buffer_text, enlarge_buffer_text):
3855 Use ptrdiff_t rather than size_t when either will do, as we prefer
3858 * alloc.c: Integer signedness and overflow fixes.
3859 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3860 (__malloc_size_t): Default to size_t, not to int.
3861 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3862 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3863 Prefer ptrdiff_t to size_t when either would do, as we prefer
3865 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3866 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3867 Now const. Initialize with values that are in range even if char
3869 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3870 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3871 These functions do the right thing with sizes > 2**32.
3872 (check_depth): Now ptrdiff_t, not int.
3873 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3874 Adjust to new way of storing sizes. Check for size overflow bugs
3876 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3877 slightly wrong anyway, as it missed one instance of
3878 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3879 (refill_memory_reserve): Omit needless cast to size_t.
3880 (mark_object_loop_halt): Mark as externally visible.
3882 * xselect.c: Integer signedness and overflow fixes.
3883 (Fx_register_dnd_atom, x_handle_dnd_message):
3884 Use ptrdiff_t, not size_t, since we prefer signed.
3885 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3886 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3887 x_dnd_atoms_size and x_dnd_atoms_length.
3889 * doprnt.c: Prefer signed to unsigned when either works.
3891 * doprnt.c (doprnt):
3893 * xdisp.c (vmessage):
3894 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3895 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3896 prefer signed arithmetic to avoid comparison confusion.
3897 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3898 but is a bit tricky.
3900 Assume freestanding C89 headers, string.h, stdlib.h.
3901 * data.c, doprnt.c, floatfns.c, print.c:
3902 Include float.h unconditionally.
3903 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3904 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3905 * regex.c: Likewise for stddef.h, string.h.
3906 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3907 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3908 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3909 (STDC_HEADERS): Remove obsolete defines.
3910 * sysdep.c: Include limits.h unconditionally.
3912 Assume support for memcmp, memcpy, memmove, memset.
3913 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3914 * regex.c (memcmp, memcpy):
3915 Remove; we assume C89 now.
3917 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3918 (__malloc_safe_bcopy): Remove; no longer needed.
3920 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3921 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3922 well either way, and we prefer signed to unsigned.
3924 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3926 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3927 closes the connection while we're reading (bug#9182).
3929 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3931 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3932 are specified (Bug#9168).
3934 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3936 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3937 Found by GCC static checking and --with-wide-int on a 32-bit host.
3939 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3941 * xdisp.c (compute_display_string_pos): Fix logic of caching
3942 previous display string position. Initialize cached_prev_pos to
3943 -1. Fixes slow-down at the beginning of a buffer.
3945 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3947 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3948 for attrs[LFACE_FONTSET_INDEX].
3950 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3952 * xml.c (parse_region): Remove unused local
3953 that was recently introduced.
3955 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3957 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3958 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3960 * xdisp.c (move_it_in_display_line_to): Record the best matching
3961 position for TO_CHARPOS while scanning the line, and restore it on
3962 exit if none of the characters scanned was an exact match.
3963 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3964 when exact match is impossible due to invisible text, and the
3965 lines are truncated.
3967 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3969 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3972 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3974 Fix a significant slow-down of cursor motion with C-n, C-p,
3975 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3976 auto-repeat under bidi redisplay in fontified buffers.
3977 * xdisp.c (compute_stop_pos_backwards): New function.
3978 (next_element_from_buffer): Call compute_stop_pos_backwards to
3979 find a suitable prev_stop when we find ourselves before
3981 (reseat): Don't look for prev_stop, as that could mean a very long
3983 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3984 <cached_disp_overlay_modiff>: Cache for last found display string
3986 (compute_display_string_pos): Return the cached position if asked
3987 about the same buffer in the same area of character positions, and
3988 the buffer wasn't changed since the time the display string
3989 position was cached.
3991 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3993 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3994 is an integer, which is important for empty lines. (Bug#9149)
3996 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3998 * frame.c (Fmodify_frame_parameters): In tty case, update the
3999 default face if necessary (Bug#4238).
4001 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4003 * editfns.c (Fstring_to_char): No need to explain what a character
4004 is in the docstring (Bug#6576).
4006 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4008 * xml.c (parse_region): Make sure we always return a tree.
4010 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4012 * xml.c (parse_region): If a document contains only comments,
4015 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4017 * xml.c (make_dom): Return comments, too.
4019 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4022 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4023 and the surrounding thread.
4024 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4025 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4026 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4028 * s/openbsd.h (BROKEN_SIGIO): Define.
4029 * unexelf.c (unexec) [__OpenBSD__]:
4030 Don't update the .mdebug section of the Alpha COFF symbol table.
4032 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4034 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4037 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4039 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4040 This fixes some race conditions on the permissions of any newly
4043 * alloc.c (valid_pointer_p): Use pipe, not open.
4044 This fixes some permissions issues when debugging.
4046 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4047 If fchown fails to set both uid and gid, try to set just gid,
4048 as that is sometimes allowed. Adjust the file's mode to eliminate
4049 setuid or setgid bits that are inappropriate if fchown fails.
4051 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4053 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4054 to compare Lisp_Objects.
4055 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4056 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4057 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4059 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4061 * lread.c (read_integer): Unread even EOF character.
4062 (read1): Likewise. Properly record start position of symbol.
4064 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4065 symbol character follows.
4067 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4069 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4070 This works around a problem with the previous change to Fcopy_file.
4071 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4072 and without this change, GCC might complain about discarding
4073 fchown's return value.
4075 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4077 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4079 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4081 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4083 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4085 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4086 it's used from the C level.
4088 * process.c: Use the same condition for POLL_FOR_INPUT in both
4089 keyboard.c and process.c (bug#1858).
4091 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4093 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4094 (Fgnutls_boot): Use it.
4096 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4098 * doc.c (Fsubstitute_command_keys): Revert last change.
4100 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4102 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4103 quotes the next character, and doesn't affect other longer
4104 sequences (bug#8935).
4106 * lread.c (syms_of_lread): Clarify that is isn't only
4107 `eval-buffer' and `eval-defun' that's affected by
4108 `lexical-binding' (bug#8460).
4110 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4112 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4113 bidi redisplay when a line includes both an image and is truncated.
4115 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4117 Fix minor problems found by static checking.
4118 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4119 (elsz): Now a signed constant, not a size_t var. We prefer signed
4120 types to unsigned, to avoid integer comparison confusion. Without
4121 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4122 "cannot optimize loop, the loop counter may overflow", a symptom
4124 * indent.c (Fvertical_motion): Mark locals as initialized.
4125 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4127 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4129 * search.c (Fre_search_backward): Mention `case-fold-search' in
4130 all the re_search_* functions (bug#8138).
4132 * keyboard.c (Fopen_dribble_file): Document when the file is
4135 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4137 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4140 Support bidi reordering of display and overlay strings.
4141 * xdisp.c (compute_display_string_pos)
4142 (compute_display_string_end): Accept additional argument STRING.
4143 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4144 (reseat_to_string): Initialize bidi_it->string.s and
4145 bidi_it->string.schars.
4146 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4147 NULL (avoids a crash in bidi_paragraph_init).
4148 Initialize itb.string.lstring.
4149 (init_iterator): Call bidi_init_it only of a valid
4150 buffer position was specified. Initialize paragraph_embedding to
4152 (reseat_to_string): Initialize the bidi iterator.
4153 (display_string): If we need to ignore text properties of
4154 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4155 original value of -1 will not work with bidi.)
4156 (compute_display_string_pos): First arg is now struct
4157 `text_pos *'; all callers changed. Support display properties on
4159 (compute_display_string_end): Support display properties on Lisp
4161 (init_iterator, reseat_1, reseat_to_string): Initialize the
4162 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4163 when iterating on a string not from display properties).
4164 (compute_display_string_pos, compute_display_string_end):
4165 Fix calculation of the object to scan. Fixes an error when using
4167 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4168 base_level_stop; instead, set base_level_stop to BEGV.
4169 Fixes crashes in vertical-motion.
4170 (next_element_from_buffer): Improve commentary for when
4171 the iterator is before prev_stop.
4172 (init_iterator): Initialize bidi_p from the default value of
4173 bidi-display-reordering, not from buffer-local value. Use the
4174 buffer-local value only if initializing for buffer iteration.
4175 (handle_invisible_prop): Support invisible properties on strings
4176 that are being bidi-reordered.
4177 (set_iterator_to_next): Support bidi reordering of C strings and
4179 (next_element_from_string): Support bidi reordering of Lisp
4181 (handle_stop_backwards): Support Lisp strings as well.
4182 (display_string): Support display of R2L glyph rows.
4183 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4184 (init_iterator): Don't initialize it->bidi_p for strings
4186 (reseat_to_string): Initialize it->bidi_p for strings here.
4187 (next_element_from_string, next_element_from_c_string)
4188 (next_element_from_buffer): Add xassert's for correspondence
4189 between IT's object being iterated and it->bidi_it.string
4191 (face_before_or_after_it_pos): Support bidi iteration.
4192 (next_element_from_c_string): Handle the case of the first string
4193 character that is not the first one in the visual order.
4194 (get_visually_first_element): New function, refactored from common
4195 parts of next_element_from_buffer, next_element_from_string, and
4196 next_element_from_c_string.
4197 (tool_bar_lines_needed, redisplay_tool_bar)
4198 (display_menu_bar): Force left-to-right direction. Add a FIXME
4199 comment for making that be controlled by a user option.
4200 (push_it, pop_it): Save and restore the state of the
4201 bidi iterator. Save and restore the bidi_p flag.
4202 (pop_it): Iterate out of display property for string iteration as
4204 (iterate_out_of_display_property): Support iteration over strings.
4205 (handle_single_display_spec): Set up it->bidi_it for iteration
4206 over a display string, and call bidi_init_it.
4207 (handle_single_display_spec, next_overlay_string)
4208 (get_overlay_strings_1, push_display_prop): Set up the bidi
4209 iterator for displaying display or overlay strings.
4210 (forward_to_next_line_start): Don't use the shortcut if
4212 (back_to_previous_visible_line_start): If handle_display_prop
4213 pushed the iterator stack, restore the internal state of the bidi
4214 iterator by calling bidi_pop_it same number of times.
4215 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4216 and we are bidi-iterating, don't decrement the iterator position;
4217 instead, set the first_elt flag in the bidi iterator, to produce
4219 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4220 (push_display_prop): xassert that we are iterating a buffer.
4221 (push_it, pop_it): Save and restore paragraph_embedding member.
4222 (handle_single_display_spec, next_overlay_string)
4223 (get_overlay_strings_1, reseat_1, reseat_to_string)
4224 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4225 correctly. Don't assume unibyte strings are not bidi-reordered.
4226 (compute_display_string_pos)
4227 (compute_display_string_end): Fix handling the case of C string.
4228 (push_it, pop_it): Save and restore from_disp_prop_p.
4229 (handle_single_display_spec, push_display_prop): Set the
4230 from_disp_prop_p flag.
4231 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4232 (pop_it): Call iterate_out_of_display_property only if we are
4233 popping after iteration over a string that came from a display
4234 property. Fix a typo in popping stretch info. Add an assertion
4235 for verifying that the iterator position is in sync with the bidi
4237 (handle_single_display_spec, get_overlay_strings_1)
4238 (push_display_prop): Fix initialization of paragraph direction for
4239 string when that of the parent object is not yet determined.
4240 (reseat_1): Call bidi_init_it to resync the bidi
4241 iterator with IT's position. (Bug#7616)
4242 (find_row_edges): If ROW->start.pos gives position
4243 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4244 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4245 Reset the from_disp_prop_p flag.
4246 (SAVE_IT, RESTORE_IT): New macros.
4247 (pos_visible_p, face_before_or_after_it_pos)
4248 (back_to_previous_visible_line_start)
4249 (move_it_in_display_line_to, move_it_in_display_line)
4250 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4251 (try_scrolling, redisplay_window, display_line): Use them when
4252 saving a temporary copy of the iterator and restoring it back.
4253 (back_to_previous_visible_line_start, reseat_1)
4254 (init_iterator): Empty the bidi cache "stack".
4255 (move_it_in_display_line_to): If iterator ended up at
4256 EOL, but we never saw any buffer positions smaller than
4257 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4258 motion in bidi-reordered lines.
4259 (move_it_in_display_line_to): Record prev_method and prev_pos
4260 immediately before the call to set_iterator_to_next. Fixes cursor
4261 motion in bidi-reordered lines with stretch glyphs and strings
4262 displayed in margins. (Bug#8133) (Bug#8867)
4263 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4265 (pos_visible_p): Support positions in bidi-reordered lines.
4266 Save and restore bidi cache.
4268 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4269 (bidi_paragraph_info): Delete unused struct.
4270 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4271 (bidi_cache_start): New variable.
4272 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4274 (bidi_cache_fetch_state, bidi_cache_search)
4275 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4276 (bidi_cache_find, bidi_peek_at_next_level)
4277 (bidi_level_of_next_char, bidi_find_other_level_edge)
4278 (bidi_move_to_visually_next): Compare cache index with
4279 bidi_cache_start rather than with zero.
4280 (bidi_fetch_char): Accept new argument STRING; all callers
4281 changed. Support iteration over a string. Support strings with
4282 display properties. Support unibyte strings. Fix the type of
4283 `len' according to what STRING_CHAR_AND_LENGTH expects.
4284 (bidi_paragraph_init, bidi_resolve_explicit_1)
4285 (bidi_resolve_explicit, bidi_resolve_weak)
4286 (bidi_level_of_next_char, bidi_move_to_visually_next):
4287 Support iteration over a string.
4288 (bidi_set_sor_type, bidi_resolve_explicit_1)
4289 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4290 can now be zero (for strings); special values 0 and -1 were
4291 changed to -1 and -2, respectively.
4292 (bidi_char_at_pos): New function.
4293 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4294 Call it instead of FETCH_MULTIBYTE_CHAR.
4295 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4296 initialized to valid values.
4297 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4299 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4300 the test for valid cached positions. Fix the logic for looking up
4301 the sentinel state in the cache. GCPRO the Lisp string we are
4303 (bidi_push_it, bidi_pop_it): New functions.
4304 (bidi_initialize): Initialize the bidi cache start stack pointer.
4305 (bidi_cache_ensure_space): New function, refactored from part of
4306 bidi_cache_iterator_state. Don't assume the required size is just
4307 one BIDI_CACHE_CHUNK away.
4308 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4309 (bidi_count_bytes, bidi_char_at_pos): New functions.
4310 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4311 always valid if bidi_cache_idx is valid.
4312 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4313 is valid if it's going to be used.
4314 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4315 (bidi_cache_fetch_state, bidi_cache_search)
4316 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4317 (bidi_cache_iterator_state, bidi_cache_find)
4318 (bidi_find_other_level_edge, bidi_cache_start_stack):
4319 All variables related to cache indices are now EMACS_INT.
4321 * dispextern.h (struct bidi_string_data): New structure.
4322 (struct bidi_it): New member `string'. Make flag members be 1-bit
4323 fields, and put them last in the struct.
4324 (compute_display_string_pos, compute_display_string_end):
4326 (bidi_push_it, bidi_pop_it): Add prototypes.
4327 (struct iterator_stack_entry): New members bidi_p,
4328 paragraph_embedding, and from_disp_prop_p.
4329 (struct it): Member bidi_p is now a bit field 1 bit wide.
4330 (bidi_shelve_cache, bidi_unshelve_cache):
4333 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4334 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4335 and vector-like objects.
4337 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4338 cache around display iteration.
4340 * window.c (Fwindow_end, window_scroll_pixel_based)
4341 (displayed_window_lines, Frecenter): Save and restore the bidi
4342 cache around display iteration.
4344 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4346 * editfns.c (Fdelete_region): Clarify the use of the named
4347 parameters (bug#6788).
4349 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4351 * indent.c (Fvertical_motion): Set and restore w->pointm when
4352 saving and restoring the window's buffer (Bug#9006).
4354 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4356 * editfns.c (Fstring_to_char): Clarify just what is returned
4357 (bug#6576). Text by Eli Zaretskii.
4359 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4361 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4363 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4365 * buffer.c (mmap_find): Fix a typo.
4367 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4369 Fix execution of x selection hooks.
4370 * xselect.c (Qx_lost_selection_functions)
4371 (Qx_sent_selection_functions): New vars.
4372 (syms_of_xselect): DEFSYM them.
4373 (x_handle_selection_request): Pass Qx_sent_selection_functions
4374 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4375 (x_handle_selection_clear,x_clear_frame_selections):
4376 Pass Qx_lost_selection_functions rather than
4377 Vx_lost_selection_functions to Frun_hook_with_args.
4379 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4381 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4382 The old code sometimes used this field without initializing it.
4384 * alloc.c (gc_sweep): Don't read past end of array.
4385 In theory, the old code could also have corrupted Emacs internals,
4386 though it'd be very unlikely.
4388 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4390 * character.c (Fcharacterp): Don't advertise optional ignored
4391 argument. (Bug#4026)
4393 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4395 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4398 * window.c (Fset_window_start): Doc fix (bug#4199).
4399 (Fset_window_hscroll): Ditto.
4401 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4403 Fix minor new problems caught by GCC 4.6.1.
4404 * term.c (init_tty): Remove unused local.
4405 * xsettings.c (store_monospaced_changed): Define this function only
4406 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4409 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4411 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4413 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4415 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4416 are the mini-buffer and the echo area (bug#3320).
4418 * term.c (init_tty): Remove support for supdup, c10 and perq
4419 terminals, which are no longer supported (bug#1482).
4421 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4423 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4425 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4427 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4428 for non-popups (Bug#3642).
4430 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4432 * alloc.c (reset_malloc_hooks): Protoize.
4433 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4434 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4435 * cm.c (losecursor): Likewise.
4436 * data.c (fmod): Likewise.
4437 * dispnew.c (swap_glyphs_in_rows): Likewise.
4438 * emacs.c (memory_warning_signal): Likewise.
4439 * floatfns.c (float_error): Likewise.
4440 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4441 (otf_open, font_otf_capability, generate_otf_features)
4442 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4444 * image.c (pbm_read_file): Likewise.
4445 * indent.c (string_display_width): Likewise.
4446 * intervals.c (check_for_interval, search_for_interval)
4447 (inc_interval_count, count_intervals, root_interval)
4448 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4449 * lread.c (defalias): Likewise.
4450 * ralloc.c (r_alloc_check): Likewise.
4451 * regex.c (set_image_of_range_1, set_image_of_range)
4452 (regex_grow_registers): Likewise.
4453 * sysdep.c (strerror): Likewise.
4454 * termcap.c (valid_filename_p, tprint, main): Likewise.
4455 * tparam.c (main): Likewise.
4456 * unexhp9k800.c (run_time_remap, save_data_space)
4457 (update_file_ptrs, read_header, write_header, calculate_checksum)
4458 (copy_file, copy_rest, display_header): Likewise.
4459 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4461 * xdisp.c (check_it): Likewise.
4462 * xfaces.c (register_color, unregister_color, unregister_colors):
4464 * xfns.c (print_fontset_result): Likewise.
4465 * xrdb.c (member, fatal, main): Likewise.
4467 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4469 Fix minor problems found by static checking (Bug#9031).
4470 * chartab.c (char_table_set_range, map_sub_char_table):
4471 Remove unused locals.
4472 (uniprop_table): Now static.
4473 * composite.c (_work_char): Remove unused static var.
4475 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4477 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4479 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4481 * gtkutil.c (qttip_cb): Remove code without function.
4483 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4485 * w32.c (pthread_sigmask): New stub.
4487 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4489 Use pthread_sigmask, not sigprocmask (Bug#9010).
4490 sigprocmask is portable only for single-threaded applications, and
4491 Emacs can be multi-threaded when it uses GTK.
4492 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4494 * callproc.c (Fcall_process):
4495 * process.c (create_process):
4496 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4497 Use pthread_sigmask, not sigprocmask.
4499 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4501 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4502 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4505 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4507 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4508 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4509 (xg_hide_tooltip): Fix comment.
4511 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4512 in registerServicesMenuSendTypes.
4513 (validRequestorForSendType): Don't check ns_return_types.
4515 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4518 2011-07-08 Jason Rumney <jasonr@gnu.org>
4520 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4521 SH_SHOW for hidden windows (Bug#5482).
4523 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4524 frame struct members of non-existent frames (Bug#6284).
4526 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4528 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4529 variable firstTime not needed on OSX >= 10.6.
4530 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4531 >= 10.5. Use setKnobProportion, setDoubleValue.
4533 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4534 (MAC_OS_X_VERSION_10_5): Define if not defined.
4535 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4536 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4537 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4539 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4540 cString and lossyCString on OSX >= 10.4
4542 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4543 sizeToFit on OSX >= 10.2.
4545 * nsimage.m (allocInitFromFile): Don't use deprecated method
4546 bestRepresentationForDevice on OSX >= 10.6.
4548 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4551 * emacs.c: Declare unexec_init_emacs_zone.
4553 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4555 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4557 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4558 on svcsMenu (Bug#8842).
4560 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4562 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4564 * nsterm.m (QUTF8_STRING): Declare.
4565 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4566 (validRequestorForSendType): Return type is (id).
4567 Change indexOfObjectIdenticalTo to indexOfObject.
4568 Check if we have local selection before returning self (Bug#8842).
4569 (writeSelectionToPasteboard): Put local selection into paste board
4570 if we have a local selection (Bug#8842).
4571 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4573 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4574 (ns_get_local_selection): Declare.
4576 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4578 * keymap.c (describe_map_tree): Don't insert a double newline at
4579 the end of the buffer (bug#1169) and return whether we inserted
4582 * callint.c (Fcall_interactively): Change "reading args" to
4583 "providing args" to try to clarify what it does (bug#1010).
4585 2011-07-07 Kenichi Handa <handa@m17n.org>
4587 * composite.c (composition_compute_stop_pos): Ignore a static
4588 composition starting before CHARPOS (Bug#8915).
4590 * xdisp.c (handle_composition_prop): Likewise.
4592 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4594 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4597 2011-07-07 Kenichi Handa <handa@m17n.org>
4599 * character.h (unicode_category_t): New enum type.
4601 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4602 (Qchar_code_property_table): New variable.
4603 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4604 (UNIPROP_COMPRESSED_FORM_P): New macros.
4605 (char_table_ascii): Uncompress the compressed values.
4606 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4607 Uncompress the compressed values.
4608 (sub_char_table_ref_and_range): Likewise.
4609 (char_table_ref_and_range): Uncompress the compressed values.
4610 (sub_char_table_set): New arg is_uniprop. Callers changed.
4611 Uncompress the compressed values.
4612 (sub_char_table_set_range): Args changed. Callers changed.
4613 (char_table_set_range): Adjuted for the above change.
4614 (map_sub_char_table): Delete args default_val and parent. Add arg
4615 top. Give decoded values to a Lisp function.
4616 (map_char_table): Adjust for the above change. Give decoded
4617 values to a Lisp function. Gcpro more variables.
4618 (uniprop_table_uncompress)
4619 (uniprop_decode_value_run_length): New functions.
4620 (uniprop_decoder, uniprop_decoder_count): New variables.
4621 (uniprop_get_decoder, uniprop_encode_value_character)
4622 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4624 (uniprop_encoder, uniprop_encoder_count): New variables.
4625 (uniprop_get_encoder, uniprop_table)
4626 (Funicode_property_table_internal, Fget_unicode_property_internal)
4627 (Fput_unicode_property_internal): New functions.
4628 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4629 Sunicode_property_table_internal, Sget_unicode_property_internal,
4630 and Sput_unicode_property_internal. Defvar_lisp
4631 char-code-property-alist.
4633 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4634 Vunicode_category_table.
4636 * font.c (font_range): Adjust for the change of
4637 Vunicode_category_table.
4639 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4641 * m/iris4d.h: Remove file, move contents ...
4642 * s/irix6-5.h: ... here.
4644 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4646 Remove unportable assumption about struct layout (Bug#8884).
4647 * alloc.c (mark_buffer):
4648 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4649 (clone_per_buffer_values): Don't assume that
4650 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4651 This isn't true in general, and it's particularly not true
4652 if Emacs is configured with --with-wide-int.
4653 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4654 New macros, used in the buffer.c change.
4656 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4658 * xsettings.c: Use both GConf and GSettings if both are available.
4659 (store_config_changed_event): Add comment.
4660 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4661 (store_tool_bar_style_changed): New functions.
4662 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4663 (struct xsettings): Move font inside HAVE_XFT.
4664 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4665 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4666 Move inside HAVE_XFT.
4667 (something_changed_gsettingsCB): Rename from something_changedCB.
4668 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4670 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4671 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4672 (something_changed_gconfCB): Rename from something_changedCB.
4673 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4674 (parse_settings): Move check for font inside HAVE_XFT.
4675 (read_settings, apply_xft_settings): Add comment.
4676 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4677 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4678 call store_font_name_changed.
4679 (xft_settings_event): Add comment.
4680 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4681 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4682 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4683 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4684 (xsettings_initialize): Call init_gsettings last.
4685 (xsettings_get_system_font, xsettings_get_system_normal_font):
4688 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4690 Random fixes. E.g., (random) never returned negative values.
4691 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4692 subseconds part to the entropy, as that's a bit more random.
4693 Prefer signed to unsigned, since the signedness doesn't matter and
4694 in general we prefer signed. When given a limit, use a
4695 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4696 latter isn't right if USE_2_TAGS_FOR_INTS.
4697 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4698 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4700 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4702 * textprop.c (text_property_stickiness):
4703 Obey Vtext_property_default_nonsticky.
4704 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4705 * w32fns.c (syms_of_w32fns):
4706 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4708 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4710 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4711 This is more efficient than Ffile_directory_p and avoids a minor race.
4713 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4715 * buffer.c (Foverlay_put): Say what the return value is
4718 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4719 is a directory before asking whether to use the file name
4721 (barf_or_query_if_file_exists): Make the "File is a directory"
4722 error be more correct.
4724 * fns.c (Frequire): Remove the mention of the .gz files, since
4725 that's installation-specific, but keep the mention of
4726 `get-load-suffixes'.
4728 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4730 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4731 Report string overflow if the output is too long.
4733 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4735 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4736 (syms_of_gnutls): Remove duplicate DEFSYM for
4737 Qgnutls_bootprop_verify_hostname_error, an error for
4738 Qgnutls_bootprop_verify_error (which is no longer used).
4740 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4741 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4742 Also (re)move comments that are misplaced or no longer relevant.
4744 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4746 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4748 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4750 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4751 and background color parameters if they have been changed.
4753 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4755 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4757 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4759 * xsettings.c (SYSTEM_FONT): Define only when used.
4760 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4762 * keymap.c (access_keymap_1): Now static.
4764 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4766 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4767 leave any prefix arg for the up event (Bug#1586).
4769 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4771 * lread.c (syms_of_lread): Mention single symbols defined by
4772 `defvar' or `defconst' (bug#7154).
4774 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4775 (Frequire): Mention get-load-suffixes.
4777 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4779 * window.h (window): Remove clone_number slot.
4780 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4782 (make_parent_window, make_window, saved_window)
4783 (Fset_window_configuration, save_window_save): Don't deal with
4785 * buffer.c (Qclone_number): Remove declaration.
4786 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4788 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4790 Add multiple inheritance to keymaps.
4791 * keymap.c (Fmake_composed_keymap): New function.
4792 (Fset_keymap_parent): Simplify.
4793 (fix_submap_inheritance): Remove.
4794 (access_keymap_1): New function extracted from access_keymap to handle
4795 embedded parents and handle lists of maps.
4796 (access_keymap): Use it.
4797 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4798 (Fcopy_keymap): Handle embedded parents.
4799 (Fcommand_remapping, define_as_prefix): Simplify.
4800 (Fkey_binding): Simplify.
4801 (syms_of_keymap): Move minibuffer-local-completion-map,
4802 minibuffer-local-filename-completion-map,
4803 minibuffer-local-must-match-map, and
4804 minibuffer-local-filename-must-match-map to Elisp.
4805 (syms_of_keymap): Defsubr make-composed-keymap.
4806 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4807 (parse_menu_item): Trivial simplification.
4809 2011-07-01 Glenn Morris <rgm@gnu.org>
4811 * Makefile.in (SETTINGS_LIBS): Fix typo.
4813 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4815 * coding.c (Fencode_coding_string): Record the last coding system
4816 used, as the function doc string says (bug#8738).
4818 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4820 * xsettings.c (store_monospaced_changed): Take new font as arg and
4821 check for change against current_mono_font.
4822 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4823 (emacs_settings_constructor, emacs_settings_get_property)
4824 (emacs_settings_set_property, emacs_settings_class_init)
4825 (emacs_settings_init, gsettings_obj): Remove.
4826 (something_changedCB): New function for HAVE_GSETTINGS.
4827 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4828 with value as argument.
4829 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4830 g_settings_new (Bug#8967). Do not create gsettings_obj.
4831 Remove calls to g_settings_bind. Connect something_changedCB to
4834 * xgselect.c: Add defined (HAVE_GSETTINGS).
4835 (xgselect_initialize): Ditto.
4837 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4838 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4841 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4843 * eval.c (struct backtrace): Simplify and port the data structure.
4844 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4845 signed bit field, as this assumption is not portable and it makes
4846 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4847 "char debug_on_exit : 1" as this is not portable either; instead,
4848 use the portable "unsigned int debug_on_exit : 1". Remove unused
4849 member evalargs. Remove obsolete comments about cc bombing out.
4851 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4853 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4854 Let HAVE_GSETTINGS override HAVE_GCONF.
4855 (store_monospaced_changed): New function.
4856 (EMACS_SETTINGS): A new type derived from GObject to handle
4857 GSettings notifications.
4858 (emacs_settings_constructor, emacs_settings_get_property)
4859 (emacs_settings_set_property, emacs_settings_class_init):
4861 (gsettings_client, gsettings_obj): New variables.
4862 (GSETTINGS_SCHEMA): New define.
4863 (something_changedCB): Call store_monospaced_changed.
4864 (init_gsettings): New function.
4865 (xsettings_initialize): Call init_gsettings.
4866 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4869 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4872 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4874 * window.c (resize_root_window, grow_mini_window)
4875 (shrink_mini_window): Rename Qresize_root_window to
4876 Qwindow_resize_root_window and Qresize_root_window_vertically to
4877 Qwindow_resize_root_window_vertically.
4879 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4881 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4883 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4885 * makefile.w32-in: Redesign dependencies so they reflect more
4886 clearly which files are directly included by each source file,
4887 and not through other includes.
4889 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4891 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4892 (sort_overlays, overlay_strings): When an overlay's clone number
4893 matches the window's clone number process the overlay even if
4894 the overlay's window property doesn't match the current window.
4896 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4897 (Fwindow_hchild): Rename to Fwindow_left_child.
4898 (Fwindow_next): Rename to Fwindow_next_sibling.
4899 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4900 (resize_window_check): Rename to window_resize_check.
4901 (resize_window_apply): Rename to window_resize_apply.
4902 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4903 (Fdelete_other_windows_internal, resize_frame_windows)
4904 (Fsplit_window_internal, Fdelete_window_internal)
4905 (grow_mini_window, shrink_mini_window)
4906 (Fresize_mini_window_internal): Fix callers accordingly.
4908 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4910 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4911 (emacs_fixed_set_min_size): Remove.
4912 (emacs_fixed_new): Take frame as argument.
4914 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4915 (_EmacsFixedPrivate): Remove minwidth/height.
4916 Add struct frame *f.
4917 (emacs_fixed_init): Initialize priv->f.
4918 (get_parent_class, emacs_fixed_set_min_size): Remove.
4919 (emacs_fixed_new): Set priv->f to argument.
4920 (emacs_fixed_get_preferred_width)
4921 (emacs_fixed_get_preferred_height): Use min_width/height from
4922 frames size_hint to set minimum and natural (Bug#8919).
4923 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4924 and use min_width/height from frames size_hint to set
4925 min_width/height (Bug#8919).
4927 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4928 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4931 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4933 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4934 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4937 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4939 * process.c (wait_reading_process_output): Bypass select if
4940 waiting for a cell while ignoring keyboard input, and input is
4941 pending. Suggested by Jan Djärv (Bug#8869).
4943 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4945 Use gnulib's dup2 module instead of rolling our own.
4946 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4948 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4950 * dispnew.c (scrolling_window): Before scrolling, turn off a
4951 mouse-highlight in the window being scrolled.
4953 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4955 Move DEFSYM to lisp.h and use everywhere.
4957 * character.h (DEFSYM): Move declaration...
4958 * lisp.h (DEFSYM): ...here.
4964 * w32select.c: Don't include character.h.
4966 * alloc.c (syms_of_alloc):
4967 * buffer.c (syms_of_buffer):
4968 * bytecode.c (syms_of_bytecode):
4969 * callint.c (syms_of_callint):
4970 * casefiddle.c (syms_of_casefiddle):
4971 * casetab.c (init_casetab_once):
4972 * category.c (init_category_once, syms_of_category):
4973 * ccl.c (syms_of_ccl):
4974 * cmds.c (syms_of_cmds):
4975 * composite.c (syms_of_composite):
4976 * dbusbind.c (syms_of_dbusbind):
4977 * dired.c (syms_of_dired):
4978 * dispnew.c (syms_of_display):
4979 * doc.c (syms_of_doc):
4980 * editfns.c (syms_of_editfns):
4981 * emacs.c (syms_of_emacs):
4982 * eval.c (syms_of_eval):
4983 * fileio.c (syms_of_fileio):
4984 * fns.c (syms_of_fns):
4985 * frame.c (syms_of_frame):
4986 * fringe.c (syms_of_fringe):
4987 * insdel.c (syms_of_insdel):
4988 * keymap.c (syms_of_keymap):
4989 * lread.c (init_obarray, syms_of_lread):
4990 * macros.c (syms_of_macros):
4991 * msdos.c (syms_of_msdos):
4992 * print.c (syms_of_print):
4993 * process.c (syms_of_process):
4994 * search.c (syms_of_search):
4995 * sound.c (syms_of_sound):
4996 * syntax.c (init_syntax_once, syms_of_syntax):
4997 * terminal.c (syms_of_terminal):
4998 * textprop.c (syms_of_textprop):
4999 * undo.c (syms_of_undo):
5000 * w32.c (globals_of_w32):
5001 * window.c (syms_of_window):
5002 * xdisp.c (syms_of_xdisp):
5003 * xfaces.c (syms_of_xfaces):
5004 * xfns.c (syms_of_xfns):
5005 * xmenu.c (syms_of_xmenu):
5006 * xsettings.c (syms_of_xsettings):
5007 * xterm.c (syms_of_xterm): Use DEFSYM.
5009 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5011 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5013 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5015 Integer and buffer overflow fixes (Bug#8873).
5017 * print.c (printchar, strout): Check for string overflow.
5018 (PRINTPREPARE, printchar, strout):
5019 Don't set size unless allocation succeeds.
5021 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5022 for sizes. Check for string overflow more accurately.
5023 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5025 * macros.c: Integer and buffer overflow fixes.
5026 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5027 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5028 Use ptrdiff_t, not int, for sizes.
5029 Don't increment bufsize until after realloc succeeds.
5030 Check for size-calculation overflow.
5031 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5033 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5035 * lread.c: Integer overflow fixes.
5036 (read_integer): Radix is now EMACS_INT, not int,
5037 to improve quality of diagnostics for out-of-range radices.
5038 Calculate buffer size correctly for out-of-range radices.
5039 (read1): Check for integer overflow in radices, and in
5040 read-circle numbers.
5041 (read_escape): Avoid int overflow.
5042 (Fload, openp, read_buffer_size, read1)
5043 (substitute_object_recurse, read_vector, read_list, map_obarray):
5044 Use ptrdiff_t, not int, for sizes.
5045 (read1): Use EMACS_INT, not int, for sizes.
5046 Check for size overflow.
5048 * image.c (cache_image): Check for size arithmetic overflow.
5050 * lread.c: Integer overflow issues.
5051 (saved_doc_string_size, saved_doc_string_length)
5052 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5053 Now ptrdiff_t, not int.
5054 (read1): Don't assume doc string length fits in int. Check for
5055 out-of-range doc string lengths.
5056 (read_list): Don't assume file position fits in int.
5057 (read_escape): Check for hex character overflow.
5059 2011-06-22 Leo Liu <sdl.web@gmail.com>
5061 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5062 Move to minibuffer.el.
5064 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5066 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5067 The following patches are for when GLYPH_DEBUG && !XASSERT.
5068 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5069 * dispnew.c (flush_stdout):
5070 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5071 Mark as externally visible.
5072 * dispnew.c (check_window_matrix_pointers): Now static.
5073 * dispnew.c (window_to_frame_vpos):
5074 * xfns.c (unwind_create_frame):
5075 * xterm.c (x_check_font): Remove unused local.
5076 * scroll.c (CHECK_BOUNDS):
5077 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5078 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5079 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5080 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5081 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5083 (debug_method_add): Use va_list and vsprintf rather than relying
5084 on undefined behavior with wrong number of arguments.
5085 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5086 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5087 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5088 since we're not interested in debugging glyphs with old libraries.
5089 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5090 GCC 4.6.0's static checking.
5092 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5094 Integer overflow and signedness fixes (Bug#8873).
5095 A few related buffer overrun fixes, too.
5097 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5099 * dispextern.h (struct face.stipple):
5100 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5101 (x_bitmap_mask, x_allocate_bitmap_record)
5102 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5103 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5104 (x_create_bitmap_from_xpm_data):
5105 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5106 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5108 * xfaces.c (load_pixmap):
5109 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5110 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5111 (.bitmaps_last, struct x_output.icon_bitmap):
5112 Use ptrdiff_t, not int, for bitmap indexes.
5113 (x_allocate_bitmap_record): Check for size overflow.
5114 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5116 Use ptrdiff_t, not int, for overlay counts.
5117 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5118 * editfns.c (overlays_around, get_pos_property):
5119 * textprop.c (get_char_property_and_overlay):
5120 * xdisp.c (next_overlay_change, note_mouse_highlight):
5121 * xfaces.c (face_at_buffer_position):
5122 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5123 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5124 (Fnext_overlay_change, Fprevious_overlay_change)
5125 (mouse_face_overlay_overlaps, Foverlays_in):
5126 Use ptrdiff_t, not int, for sizes.
5127 (overlays_at, overlays_in): Check for size-calculation overflow.
5129 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5131 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5132 (x_session_initialize): Do not assume string length fits in int.
5134 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5135 This is unlikely, but can occur if DPI is outlandish.
5137 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5138 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5140 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5141 * xrdb.c (magic_file_p, search_magic_path):
5142 Omit last arg SUFFIX; it was always 0. All callers changed.
5143 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5145 * xfont.c (xfont_match): Avoid need for strlen.
5147 * xfns.c: Don't assume strlen fits in int.
5148 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5150 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5151 not unsigned long, as we prefer signed integers. All callers changed.
5152 Detect integer overflow in repeat count.
5153 (message_dolog): Don't assume print length fits in 39 bytes.
5154 (display_mode_element): Don't assume strlen fits in int.
5156 * termcap.c: Don't assume sizes fit in int and never overflow.
5157 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5158 (gobble_line): Check for size-calculation overflow.
5160 * minibuf.c (Fread_buffer):
5161 * lread.c (intern, intern_c_string):
5162 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5163 Don't assume string length fits in int.
5165 * keyboard.c (parse_tool_bar_item):
5166 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5168 * font.c: Don't assume string length fits in int.
5169 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5170 Use ptrdiff_t, not int.
5171 (font_intern_prop): Don't assume string length fits in int.
5172 Don't assume integer property fits in fixnum.
5173 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5175 * filelock.c: Fix some buffer overrun and integer overflow issues.
5176 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5177 Reformulate so as not to need the command string.
5178 Invoke gzip -cd rather than gunzip, as it's more portable.
5179 (lock_info_type, lock_file_1, lock_file):
5180 Don't assume pid_t and time_t fit in unsigned long.
5181 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5182 (current_lock_owner): Prefer signed type for sizes.
5183 Use memcpy, not strncpy, where memcpy is what is really wanted.
5184 Don't assume (via atoi) that time_t and pid_t fit in int.
5185 Check for time_t and/or pid_t out of range, e.g., via a network share.
5186 Don't alloca where an auto var works fine.
5188 * fileio.c: Fix some integer overflow issues.
5189 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5190 Don't assume string length fits in int.
5191 (directory_file_name): Don't assume string length fits in long.
5192 (make_temp_name): Don't assume pid fits in int, or that its print
5193 length is less than 20.
5195 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5197 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5199 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5201 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5202 We prefer signed integers, even for size calculations.
5204 * emacs.c: Don't assume string length fits in 'int'.
5205 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5206 (main): Don't invoke strlen when not needed.
5208 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5209 (XD_DEBUG_MESSAGE): Don't waste a byte.
5211 * callproc.c (getenv_internal_1, getenv_internal)
5213 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5215 * lread.c (invalid_syntax): Omit length argument.
5216 All uses changed. This doesn't fix a bug, but it simplifies the
5217 code away from its former Hollerith-constant appearance, and it's
5218 one less 'int' to worry about when looking at integer-overflow issues.
5219 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5221 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5222 This didn't break anything, but it didn't help either.
5223 It's confusing to put a bogus integer in a place where the actual
5224 value does not matter.
5225 (LIST_END_P): Remove unused macro and its bogus comment.
5226 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5228 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5229 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5231 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5232 We prefer signed types, and the value cannot exceed the EMACS_INT
5233 range anyway (because otherwise the length would not be representable).
5234 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5235 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5236 This avoids a GCC warning when WIDE_EMACS_INT.
5238 * indent.c (sane_tab_width): New function.
5239 (current_column, scan_for_column, Findent_to, position_indentation)
5240 (compute_motion): Use it. This is just for clarity.
5241 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5243 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5245 * lisp.h (lint_assume): New macro.
5246 * composite.c (composition_gstring_put_cache):
5247 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5249 * editfns.c, insdel.c:
5250 Omit unnecessary forward decls, to simplify future changes.
5252 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5254 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5256 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5257 Use much-faster test for byte-length change.
5258 Don't assume string byte-length fits in 'int'.
5259 Check that character arg fits in 'int'.
5260 (mapcar1): Declare byte as byte, for clarity.
5262 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5264 * fns.c (concat): Catch string overflow earlier.
5265 Do not rely on integer wraparound.
5267 * dispextern.h (struct it.overlay_strings_charpos)
5268 (struct it.selective): Now EMACS_INT, not int.
5269 * xdisp.c (forward_to_next_line_start)
5270 (back_to_previous_visible_line_start)
5271 (reseat_at_next_visible_line_start, next_element_from_buffer):
5272 Don't arbitrarily truncate the value of 'selective' to int.
5274 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5276 * composite.c: Don't truncate sizes to 'int'.
5277 (composition_gstring_p, composition_reseat_it)
5278 (composition_adjust_point): Use EMACS_INT, not int.
5279 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5280 not EMACS_UINT, for indexes.
5282 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5284 * buffer.c: Include <verify.h>.
5285 (struct sortvec.priority, struct sortstr.priority):
5286 Now EMACS_INT, not int.
5287 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5288 (struct sortstr.size, record_overlay_string)
5289 (struct sortstrlist.size, struct sortlist.used):
5290 Don't truncate size to int.
5291 (record_overlay_string): Check for size-calculation overflow.
5292 (init_buffer_once): Check at compile-time, not run-time.
5294 2011-06-22 Jim Meyering <meyering@redhat.com>
5296 Don't leak an XBM-image-sized buffer
5297 * image.c (xbm_load): Free the image buffer after using it.
5299 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5302 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5303 that Sun C diagnosed.
5304 * fns.c (secure_hash): Fix pointer signedness issue.
5305 * intervals.c (static_offset_intervals): New function.
5306 (offset_intervals): Use it.
5308 2011-06-21 Leo Liu <sdl.web@gmail.com>
5311 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5314 * fns.c (secure_hash): Rename from crypto_hash_function and change
5315 the first arg to accept symbols.
5316 (Fsecure_hash): New primitive.
5317 (syms_of_fns): New symbols.
5319 2011-06-20 Deniz Dogan <deniz@dogan.se>
5321 * process.c (Fset_process_buffer): Clarify return value in
5324 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5326 * dispnew.c (add_window_display_history): Use BVAR.
5328 * xdisp.c (debug_method_add): Use BVAR.
5329 (check_window_end, dump_glyph_matrix, dump_glyph)
5330 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5332 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5335 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5336 check till after the cache is created in init_frame_faces.
5338 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5340 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5342 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5344 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5345 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5346 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5348 Improve buffer-overflow checking (Bug#8873).
5349 * fileio.c (Finsert_file_contents):
5350 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5351 Remove the old (too-loose) buffer overflow checks.
5352 They weren't needed, since make_gap checks for buffer overflow.
5353 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5354 The old code merely checked for Emacs fixnum overflow, and relied
5355 on undefined (wraparound) behavior. The new code avoids undefined
5356 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5358 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5359 Tune. Don't use wider integers than needed. Don't use alloca.
5360 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5362 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5364 * insdel.c, lisp.h (buffer_overflow): New function.
5365 (insert_from_buffer_1, replace_range, replace_range_2):
5366 * insdel.c (make_gap_larger):
5367 * editfns.c (Finsert_char):
5368 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5370 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5372 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5374 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5376 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5377 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5379 * fileio.c: Don't assume EMACS_INT fits in off_t.
5380 (emacs_lseek): New static function.
5381 (Finsert_file_contents, Fwrite_region): Use it.
5382 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5384 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5386 * fns.c: Don't overflow int when computing a list length.
5387 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5388 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5389 truncation on 64-bit hosts. Check for QUIT every
5390 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5391 faster and is responsive enough.
5392 (Flength): Report an error instead of overflowing an integer.
5393 (Fsafe_length): Return a float if the value is not representable
5394 as a fixnum. This shouldn't happen except in contrived situations.
5395 (Fnthcdr, Fsort): Don't assume list length fits in int.
5396 (Fcopy_sequence): Don't assume vector length fits in int.
5398 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5399 (header_size, word_size): New constants.
5400 (allocate_vectorlike): Don't check size overflow here.
5401 (allocate_vector): Check it here instead, since this is the only
5402 caller of allocate_vectorlike that could cause overflow.
5403 Check that the new vector's length is representable as a fixnum.
5405 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5406 The previous code was bogus. For example, next_almost_prime (32)
5407 returned 39, which is undesirable as it is a multiple of 3; and
5408 next_almost_prime (24) returned 25, which is a multiple of 5 so
5409 why was the code bothering to check for multiples of 7?
5411 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5413 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5415 Variadic C functions now count arguments with ptrdiff_t.
5416 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5417 Back then I didn't know that the Emacs coding style prefers signed int.
5418 Also, in the meantime I found a few more instances where arguments
5419 were being counted with int, which may truncate counts on 64-bit
5420 machines, or EMACS_INT, which may be unnecessarily wide.
5421 * lisp.h (struct Lisp_Subr.function.aMANY)
5422 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5423 Arg counts are now ptrdiff_t, not size_t.
5424 All variadic functions and their callers changed accordingly.
5425 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5426 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5427 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5428 * callint.c (Fcall_interactively): Check arg count for overflow,
5429 to avoid potential buffer overrun. Use signed char, not 'int',
5430 for 'varies' array, so that we needn't bother to check its size
5431 calculation for overflow.
5432 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5433 * eval.c (apply_lambda):
5434 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5435 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5436 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5438 * callint.c (Fcall_interactively): Don't use index var as event count.
5440 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5441 * mem-limits.h (SIZE): Remove; no longer used.
5443 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5445 Remove unnecessary casts.
5446 * xterm.c (x_term_init):
5447 * xfns.c (x_set_border_pixel):
5448 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5449 These aren't needed now that we assume ANSI C.
5451 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5452 It's more likely to cause problems (due to unsigned overflow)
5455 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5457 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5459 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5461 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5463 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5465 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5467 GLYPH_CODE_FACE returns EMACS_INT, not int.
5468 * dispextern.h (merge_faces):
5469 * xfaces.c (merge_faces):
5470 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5471 Don't assume EMACS_INT fits in int.
5473 * character.h (CHAR_VALID_P): Remove unused parameter.
5474 * fontset.c, lisp.h, xdisp.c: All uses changed.
5476 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5478 * fns.c (concat): Minor tuning based on overflow analysis.
5479 This doesn't fix any bugs. Use int to hold character, instead
5480 of constantly refetching from Emacs object. Use XFASTINT, not
5481 XINT, for value known to be a character. Don't bother comparing
5482 a single byte to 0400, as it's always less.
5484 * floatfns.c (Fexpt):
5485 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5487 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5490 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5492 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5493 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5494 incorrectly succeed when S was a string, because 4294967386 was
5495 truncated before it was used.
5497 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5498 Otherwise, an out-of-range integer could cause undefined behavior
5501 * composite.c: Use int, not EMACS_INT, for characters.
5502 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5503 EMACS_INT, for values that are known to be in character range.
5504 This doesn't fix any bugs but is the usual style inside Emacs and
5505 may generate better code on 32-bit machines.
5507 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5508 This is for reasons similar to the recent CHAR_STRING fix.
5509 * charset.c (Fencode_char): Check that character arg is actually
5510 a character. Pass an int to ENCODE_CHAR.
5511 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5512 wider than 'int', as a compile-time check to prevent future regressions
5515 * character.c (char_string): Remove unnecessary casts.
5517 Make sure a 64-bit char is never passed to CHAR_STRING.
5518 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5519 by silently ignoring the top 32 bits, allowing some values
5520 that were far too large to be valid characters.
5521 * character.h: Include <verify.h>.
5522 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5523 arguments are no wider than unsigned, as a compile-time check
5524 to prevent future regressions in this area.
5526 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5527 (Fsubst_char_in_region):
5529 * xdisp.c (decode_mode_spec_coding):
5530 Adjust to CHAR_STRING's new requirement.
5531 * editfns.c (Finsert_char, Fsubst_char_in_region):
5532 * fns.c (concat): Check that character args are actually
5533 characters. Without this test, these functions did the wrong
5534 thing with wildly out-of-range values on 64-bit hosts.
5536 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5537 These casts should not be needed on 32-bit hosts, either.
5538 * keyboard.c (read_char):
5539 * lread.c (Fload): Remove casts to unsigned.
5541 * lisp.h (UNSIGNED_CMP): New macro.
5542 This fixes comparison bugs on 64-bit hosts.
5543 (ASCII_CHAR_P): Use it.
5544 * casefiddle.c (casify_object):
5545 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5546 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5547 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5548 * dispextern.h (FACE_FROM_ID):
5549 * keyboard.c (read_char): Use UNSIGNED_CMP.
5551 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5552 not to EMACS_INT, to avoid GCC warning.
5554 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5556 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5557 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5558 isn't needed on 32-bit machines.
5560 * buffer.c (Fgenerate_new_buffer_name):
5561 Use EMACS_INT for count, not int.
5562 (advance_to_char_boundary): Return EMACS_INT, not int.
5564 * data.c (Qcompiled_function): Now static.
5566 * window.c (window_body_lines): Now static.
5568 * image.c (gif_load): Rename local to avoid shadowing.
5570 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5571 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5572 * alloc.c (make_save_value): Integer argument is now of type
5574 (mark_object): Use ptrdiff_t, not int.
5575 * lisp.h (pD): New macro.
5576 * print.c (print_object): Use it.
5578 * alloc.c: Use EMACS_INT, not int, to count objects.
5579 (total_conses, total_markers, total_symbols, total_vector_size)
5580 (total_free_conses, total_free_markers, total_free_symbols)
5581 (total_free_floats, total_floats, total_free_intervals)
5582 (total_intervals, total_strings, total_free_strings):
5583 Now EMACS_INT, not int. All uses changed.
5584 (Fgarbage_collect): Compute overall total using a double, so that
5585 integer overflow is less likely to be a problem. Check for overflow
5586 when converting back to an integer.
5587 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5588 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5589 These were 'int' variables that could overflow on 64-bit hosts;
5590 they were never used, so remove them instead of repairing them.
5591 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5592 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5593 Previously, this ceilinged at INT_MAX, but that doesn't work on
5595 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5597 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5598 (allocate_vectorlike): Check for ptrdiff_t overflow.
5599 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5600 when a (possibly-narrower) signed value would do just as well.
5601 We prefer using signed arithmetic, to avoid comparison confusion.
5603 * alloc.c: Catch some string size overflows that we were missing.
5604 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5605 for convenience in STRING_BYTES_MAX.
5606 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5607 The definition here is exact; the one in lisp.h was approximate.
5608 (allocate_string_data): Check for string overflow. This catches
5609 some instances we weren't catching before. Also, it catches
5610 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5611 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5612 and ptrdiff_t and EMACS_INT are both 64 bits.
5614 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5615 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5616 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5618 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5620 * alloc.c (Fmake_string): Check for out-of-range init.
5622 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5624 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5626 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5628 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5629 xg_get_default_scrollbar_width.
5631 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5632 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5633 (style_changed_cb): Call update_theme_scrollbar_width and call
5634 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5635 all frames (Bug#8505).
5636 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5637 Call gtk_window_set_resizable if HAVE_GTK3.
5638 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5639 and height if HAVE_GTK3 (Bug#8505).
5640 (scroll_bar_width_for_theme): New variable.
5641 (update_theme_scrollbar_width): New function.
5642 (xg_get_default_scrollbar_width): Move code to
5643 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5644 (xg_initialize): Call update_theme_scrollbar_width.
5646 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5648 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5650 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5652 * frame.c (make_frame): Call other_buffer_safely instead of
5655 * window.c (temp_output_buffer_show): Call display_buffer with
5656 second argument Vtemp_buffer_show_specifiers and reset latter
5657 immediately after the call.
5658 (Vtemp_buffer_show_specifiers): New variable.
5659 (auto_window_vscroll_p, next_screen_context_lines)
5660 (Vscroll_preserve_screen_position): Remove leading asterisks from
5663 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5665 Fix minor problems found by GCC 4.6.0 static checking.
5666 * buffer.c (Qclone_number): Remove for now, as it's unused.
5667 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5668 (record_buffer): Remove unused local.
5669 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5670 (set_frame_buffer_list): Remove; unused.
5671 * frame.h (other_visible_frames): Remove decl.
5672 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5673 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5674 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5676 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5677 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5678 Define only if HAVE_GPM.
5679 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5680 (update_hints_inhibit): Remove; never set. All uses removed.
5681 * widgetprv.h (emacsFrameClassRec): Remove decl.
5682 * window.c (delete_deletable_window): Now returns void, since it
5683 wasn't returning anything.
5684 (compare_window_configurations): Remove unused locals.
5685 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5686 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5687 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5688 the same widths as pointers. This follows up on the 2011-05-06 patch.
5689 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5690 * xterm.h: Likewise.
5691 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5693 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5695 * makefile.w32-in: Update dependencies.
5696 (LISP_H): Add lib/intprops.h.
5698 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5700 * image.c (gif_load): Add animation frame delay to the metadata.
5701 (syms_of_image): Use DEFSYM. New symbol `delay'.
5703 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5705 * window.c (delete_deletable_window): Re-add.
5706 (Fset_window_configuration): Rewrite to handle dead buffers and
5707 consequently deletable windows.
5708 (window_tree, Fwindow_tree): Remove. Supply functionality in
5710 (compare_window_configurations): Simplify code.
5712 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5714 * image.c (imagemagick_load_image): Fix type mismatch.
5715 (Fimagemagick_types): Likewise.
5717 * window.h (replace_buffer_in_windows): Declare.
5719 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5721 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5722 Qclone_number. Remove external declaration of Qdelete_window.
5723 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5725 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5726 Run Qbuffer_list_update_hook if allowed.
5727 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5728 buffer list implementation.
5729 (other_buffer_safely): New function.
5730 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5731 calls to replace_buffer_in_windows and
5732 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5734 (record_buffer): Inhibit quitting and rewrite using quittable
5735 functions. Run Qbuffer_list_update_hook if allowed.
5736 (Frecord_buffer, Funrecord_buffer): New functions.
5737 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5738 Move switch-to-buffer to window.el.
5739 (bury-buffer): Move to window.el.
5740 (Vbuffer_list_update_hook): New variable.
5742 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5745 * window.h (resize_frame_windows): Move up in code.
5746 (Fwindow_frame): Remove EXFUN.
5747 (replace_buffer_in_all_windows): Remove prototype.
5748 (replace_buffer_in_windows_safely): Add prototype.
5750 * window.c: Declare Qdelete_window static again. Move down
5751 declaration of select_count.
5752 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5753 (Fother_window): Move to window.el.
5754 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5755 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5756 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5758 (replace_buffer_in_windows): Implement by calling
5759 Qreplace_buffer_in_windows.
5760 (replace_buffer_in_all_windows): Remove with some functionality
5761 moved into replace_buffer_in_windows_safely.
5762 (replace_buffer_in_windows_safely): New function.
5763 (select_window_norecord, select_frame_norecord): Move in front
5764 of run_window_configuration_change_hook. Remove now obsolete
5766 (Fset_window_buffer): Rewrite doc-string.
5767 Call Qrecord_window_buffer.
5768 (keys_of_window): Move binding for other-window to window.el.
5770 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5772 * dispextern.h (struct image): Replace data member, whose int_val
5773 and ptr_val fields were not used by anything, with a single
5776 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5777 (gif_clear_image, gif_load, imagemagick_load_image)
5778 (gs_clear_image, gs_load): Callers changed.
5780 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5782 * buffer.h: Include <time.h>, for time_t.
5783 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5785 Fix minor problems found by static checking.
5787 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5789 Make identifiers static if they are not used in other modules.
5790 * data.c (Qcompiled_function, Qframe, Qvector):
5791 * image.c (QimageMagick, Qsvg):
5792 * minibuf.c (Qmetadata):
5793 * window.c (resize_window_check, resize_root_window): Now static.
5794 * window.h (resize_window_check, resize_root_window): Remove decls.
5796 * window.c (window_deletion_count, delete_deletable_window):
5798 (window_body_lines): Now static.
5799 (Fdelete_other_windows_internal): Mark vars as initialized.
5800 Make sure 'resize_failed' is initialized.
5801 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5802 (resize_window_apply): Remove unused local.
5803 * window.h (delete_deletable_window): Remove decl.
5805 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5806 (imagemagick_load_image): Fix pointer signedness problem by changing
5807 last arg from unsigned char * to char *. All uses changed.
5808 Also, fix a local for similar reasons.
5809 Remove unused locals. Remove locals to avoid shadowing.
5810 (fn_rsvg_handle_free): Remove; unused.
5811 (svg_load, svg_load_image): Fix pointer signedness problem.
5812 (imagemagick_load_image): Don't use garbage pointer image_wand.
5814 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5816 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5818 * image.c (gif_load): Fix omitted cast error introduced by
5821 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5823 * window.h (resize_proportionally, orig_total_lines)
5824 (orig_top_line): Remove from window structure.
5825 (set_window_height, set_window_width, change_window_heights)
5826 (Fdelete_window): Remove prototypes.
5827 (resize_frame_windows): Remove duplicate declaration.
5829 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5831 * window.h (resize_frame_windows, resize_window_check)
5832 (delete_deletable_window, resize_root_window)
5833 (resize_frame_windows): Declare prototypes.
5835 * window.c (resize_window_apply): Make definition be "static" to
5836 match the prototype.
5838 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5840 * window.c: Remove declarations of Qwindow_size_fixed,
5841 window_min_size_1, window_min_size_2, window_min_size,
5842 size_window, window_fixed_size_p, enlarge_window, delete_window.
5843 Remove static from declaration of Qdelete_window, it's
5844 temporarily needed by Fbury_buffer.
5845 (replace_window): Don't assign orig_top_line and
5847 (Fdelete_window, delete_window): Remove. Window deletion is
5848 handled by window.el.
5849 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5850 Replace Fdelete_window calls with calls to Qdelete_window.
5851 (Fdelete_other_windows): Remove. Deleting other windows is
5852 handled by window.el.
5853 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5854 handled in window.el.
5855 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5856 Window minimum sizes are handled in window.el.
5857 (shrink_windows, size_window, set_window_height)
5858 (set_window_width, change_window_heights, window_height)
5859 (window_width, CURBEG, CURSIZE, enlarge_window)
5860 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5861 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5862 handled in window.el.
5863 (make_dummy_parent): Rename to make_parent_window and give it a
5864 second argument horflag.
5865 (make_window): Don't set resize_proportionally any more.
5866 (Fsplit_window): Remove. Windows are split in window.el.
5867 (save_restore_action, save_restore_orig_size)
5868 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5869 Resize mini windows in window.el.
5870 (grow_mini_window, shrink_mini_window): Implement by calling
5871 Qresize_root_window_vertically, resize_window_check and
5872 resize_window_apply.
5873 (saved_window, Fset_window_configuration, save_window_save):
5874 Do not handle orig_top_line, orig_total_lines, and
5875 resize_proportionally.
5876 (window_min_height, window_min_width): Move to window.el.
5877 (keys_of_window): Move bindings for delete-other-windows,
5878 split-window, delete-window and enlarge-window to window.el.
5880 * buffer.c: Temporarily extern Qdelete_window.
5881 (Fbury_buffer): Temporarily call Qdelete_window instead of
5882 Fdelete_window (Fbury_buffer will move to window.el soon).
5884 * frame.c (set_menu_bar_lines_1): Remove code handling
5885 orig_top_line and orig_total_lines.
5887 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5888 set_window_height but set heights directly.
5889 (change_frame_size_1): Use resize_frame_windows.
5891 * xdisp.c (init_xdisp): Don't use set_window_height but set
5894 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5895 Use resize_frame_windows instead of change_window_heights and run
5896 run_window_configuration_change_hook.
5898 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5899 instead of change_window_heights and run
5900 run_window_configuration_change_hook.
5902 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5904 * window.c (replace_window): Rename second argument REPLACEMENT to
5905 NEW. New third argument SETFLAG. Rewrite.
5906 (delete_window, make_dummy_parent): Call replace_window with
5908 (window_list_1): Move down in code.
5909 (run_window_configuration_change_hook): Move set_buffer part
5910 before select_frame_norecord part in order to unwind correctly.
5911 Rename count1 to count.
5912 (recombine_windows, delete_deletable_window, resize_root_window)
5913 (Fdelete_other_windows_internal)
5914 (Frun_window_configuration_change_hook, make_parent_window)
5915 (resize_window_check, resize_window_apply, Fresize_window_apply)
5916 (resize_frame_windows, Fsplit_window_internal)
5917 (Fdelete_window_internal, Fresize_mini_window_internal):
5919 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5921 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5923 * window.h (window): Add some new members to window structure -
5924 normal_lines, normal_cols, new_total, new_normal, clone_number,
5925 splits, nest, prev_buffers, next_buffers.
5926 (WINDOW_TOTAL_SIZE): Move here from window.c.
5927 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5929 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5931 (make_dummy_parent): Set new members of windows structure.
5932 (make_window): Move down in code. Handle new members of window
5934 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5935 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5936 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5937 (Fset_window_prev_buffers, Fwindow_next_buffers)
5938 (Fset_window_next_buffers, Fset_window_clone_number):
5940 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5941 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5943 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5944 Argument WINDOW can be now internal window too.
5945 (Fwindow_use_time): Move up in code.
5946 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5948 (Fset_window_configuration, saved_window)
5949 (Fcurrent_window_configuration, save_window_save): Handle new
5950 members of window structure.
5951 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5952 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5953 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5954 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5955 Qget_mru_window, Qresize_root_window,
5956 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5957 Qauto_buffer_name; staticpro them.
5959 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5961 * window.c (Fwindow_total_size, Fwindow_left_column)
5962 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5963 (Fwindow_list_1): New functions.
5964 (window_box_text_cols): Replace with window_body_cols.
5965 (Fwindow_width, Fscroll_left, Fscroll_right):
5966 Use window_body_cols instead of window_box_text_cols.
5967 (delete_window, Fset_window_configuration):
5968 Call delete_all_subwindows with window as argument.
5969 (delete_all_subwindows): Take a window as argument and not a
5971 (window_loop): Remove handling of GET_LRU_WINDOW and
5973 (Fget_lru_window, Fget_largest_window): Move to window.el.
5975 * window.h: Extern window_body_cols instead of
5976 window_box_text_cols. delete_all_subwindows now takes a
5977 Lisp_Object as argument.
5979 * indent.c (compute_motion, Fcompute_motion):
5980 Use window_body_cols instead of window_box_text_cols.
5982 * frame.c (delete_frame): Call delete_all_subwindows with root
5985 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5987 * fns.c (Fputhash): Document return value.
5989 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5991 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5993 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5995 Cons<->int and similar integer overflow fixes (Bug#8794).
5997 Check for overflow when converting integer to cons and back.
5998 * charset.c (Fdefine_charset_internal, Fdecode_char):
5999 Use cons_to_unsigned to catch overflow.
6000 (Fencode_char): Use INTEGER_TO_CONS.
6001 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6002 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6003 * data.c (long_to_cons, cons_to_long): Remove.
6004 (cons_to_unsigned, cons_to_signed): New functions.
6005 These signal an error for invalid or out-of-range values.
6006 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6007 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6008 * font.c (Ffont_variation_glyphs):
6009 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6010 * lisp.h: Include <intprops.h>.
6011 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6012 (cons_to_signed, cons_to_unsigned): New decls.
6013 (long_to_cons, cons_to_long): Remove decls.
6014 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6015 (Fprimitive_undo): Use CONS_TO_INTEGER.
6016 * xfns.c (Fx_window_property): Likewise.
6017 * xselect.c: Include <limits.h>.
6018 (x_own_selection, selection_data_to_lisp_data):
6019 Use INTEGER_TO_CONS.
6020 (x_handle_selection_request, x_handle_selection_clear)
6021 (x_get_foreign_selection, Fx_disown_selection_internal)
6022 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6023 (lisp_data_to_selection_data): Use cons_to_unsigned.
6024 (x_fill_property_data): Use cons_to_signed.
6025 Report values out of range.
6027 Check for buffer and string overflow more precisely.
6028 * buffer.h (BUF_BYTES_MAX): New macro.
6029 * lisp.h (STRING_BYTES_MAX): New macro.
6030 * alloc.c (Fmake_string):
6031 * character.c (string_escape_byte8):
6032 * coding.c (coding_alloc_by_realloc):
6033 * doprnt.c (doprnt):
6034 * editfns.c (Fformat):
6036 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6037 since they may not be the same number.
6038 * editfns.c (Finsert_char):
6039 * fileio.c (Finsert_file_contents):
6040 Likewise for BUF_BYTES_MAX.
6042 * image.c: Use ptrdiff_t, not int, for sizes.
6043 (slurp_file): Switch from int to ptrdiff_t.
6045 (slurp_file): Check that file size fits in both size_t (for
6046 malloc) and ptrdiff_t (for sanity and safety).
6048 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6049 if b->modtime has its maximal value.
6051 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6053 Don't assume time_t can fit into int.
6054 * buffer.h (struct buffer.modtime): Now time_t, not int.
6055 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6056 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6058 Minor fixes for signed vs unsigned integers.
6059 * character.h (MAYBE_UNIFY_CHAR):
6060 * charset.c (maybe_unify_char):
6061 * keyboard.c (read_char, reorder_modifiers):
6062 XINT -> XFASTINT, since the integer must be nonnegative.
6063 * ftfont.c (ftfont_spec_pattern):
6064 * keymap.c (access_keymap, silly_event_symbol_error):
6065 XUINT -> XFASTINT, since the integer must be nonnegative.
6066 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6067 since it makes no difference and we prefer signed.
6068 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6069 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6072 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6074 * window.h (Fwindow_frame): Declare.
6076 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6078 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6079 (SPARE_MEMORY): Always define.
6080 (LARGE_REQUEST): Remove.
6081 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6083 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6085 * lisp.h: Move EXFUNS for Fframe_root_window,
6086 Fframe_first_window and Fset_frame_selected_window to window.h.
6088 * window.h: Move EXFUNS for Fframe_root_window,
6089 Fframe_first_window and Fset_frame_selected_window here from
6092 * frame.c (Fwindow_frame, Fframe_first_window)
6093 (Fframe_root_window, Fframe_selected_window)
6094 (Fset_frame_selected_window): Move to window.c.
6095 (Factive_minibuffer_window): Move to minibuf.c.
6096 (Fother_visible_frames_p): New function.
6098 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6100 * window.c (decode_window, decode_any_window): Move up in code.
6101 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6102 (inhibit_frame_unsplittable): Remove unused variable.
6103 (Fwindow_buffer): Move up and rewrite doc-string.
6104 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6105 (Fwindow_prev): New functions.
6106 (Fwindow_frame): Move here from frame.c. Accept any window as
6108 (Fframe_root_window, Fframe_first_window)
6109 (Fframe_selected_window): Move here from frame.c. Accept frame
6110 or arbitrary window as argument. Update doc-strings.
6111 (Fminibuffer_window): Move up in code.
6112 (Fwindow_minibuffer_p): Move up in code and simplify.
6113 (Fset_frame_selected_window): Move here from frame.c.
6115 (Fselected_window, select_window, Fselect_window): Move up in
6116 code. Minor doc-string fixes.
6118 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6120 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6121 Do not assume that spare memory exists; that assumption is valid
6122 only if SYSTEM_MALLOC.
6123 (LARGE_REQUEST): New macro, so that the issue of large requests
6124 is separated from the issue of spare memory.
6126 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6128 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6131 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6133 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6136 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6138 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6140 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6142 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6143 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6145 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6147 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6149 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6151 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6152 (x_clipboard_manager_save): Add return value.
6153 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6155 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6156 Obey Vx_select_enable_clipboard_manager. Catch errors in
6157 x_clipboard_manager_save (Bug#8779).
6158 (Vx_select_enable_clipboard_manager): New variable.
6159 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6161 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6163 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6165 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6167 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6168 in the current matrix if keep_current_p is non-zero.
6170 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6172 * bidi.c (bidi_level_of_next_char): Fix last change.
6174 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6176 Support bidi reordering of text covered by display properties.
6178 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6179 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6180 (bidi_cache_search, bidi_cache_iterator_state)
6181 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6182 (bidi_level_of_next_char, bidi_move_to_visually_next):
6183 Support character positions inside a run of characters covered by a
6185 (bidi_paragraph_init, bidi_resolve_explicit_1)
6186 (bidi_level_of_next_char): Call bidi_fetch_char and
6187 bidi_fetch_char_advance instead of FETCH_CHAR and
6189 (bidi_init_it): Initialize new members.
6190 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6192 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6193 instead of using explicit *_CHAR codes.
6194 (bidi_resolve_explicit, bidi_resolve_weak):
6195 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6196 bidirectional text is supported only in multibyte buffers.
6197 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6198 it to initialize the frame_window_p member of struct bidi_it.
6199 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6200 (bidi_resolve_explicit, bidi_resolve_weak)
6201 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6202 bidi_it->nchars is non-positive.
6203 (bidi_level_of_next_char): Don't try to lookup the cache for the
6204 next/previous character if nothing is cached there yet, or if we
6205 were just reseat()'ed to a new position.
6207 * xdisp.c (set_cursor_from_row): Set start and stop points
6208 according to the row's direction when priming the loop that looks
6209 for the glyph on which to display cursor.
6210 (single_display_spec_intangible_p): Function deleted.
6211 (display_prop_intangible_p): Reimplement to call
6212 handle_display_spec instead of single_display_spec_intangible_p.
6213 Accept 3 additional arguments needed by handle_display_spec.
6214 This fixes incorrect cursor motion across display property with complex
6215 values: lists, `(when COND...)' forms, etc.
6216 (single_display_spec_string_p): Support property values that are
6217 lists with the argument STRING its top-level element.
6218 (display_prop_string_p): Fix the condition for processing a
6219 property that is a list to be consistent with handle_display_spec.
6220 (handle_display_spec): New function, refactored from the
6221 last portion of handle_display_prop.
6222 (compute_display_string_pos): Accept additional argument
6223 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6224 value of a `display' property is a "replacing spec".
6225 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6226 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6227 the display property, but just return a value indicating whether
6228 the display property will replace the characters it covers.
6229 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6230 frame_window_p members of struct bidi_it.
6231 (compute_display_string_pos, compute_display_string_end):
6233 (push_it): Accept second argument POSITION, where pop_it should
6234 jump to continue iteration.
6235 (reseat_1): Initialize bidi_it.disp_pos.
6237 * keyboard.c (adjust_point_for_property): Adjust the call to
6238 display_prop_intangible_p to its new signature.
6240 * dispextern.h (struct bidi_it): New member frame_window_p.
6241 (bidi_init_it): Update prototypes.
6242 (display_prop_intangible_p): Update prototype.
6243 (compute_display_string_pos, compute_display_string_end):
6245 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6248 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6250 Malloc failure behavior now depends on size of allocation.
6251 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6252 * lisp.h: Change signatures accordingly.
6253 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6254 All callers changed. (Bug#8762)
6256 * gnutls.c: Use Emacs's memory allocators.
6257 Without this change, the gnutls library would invoke malloc etc.
6258 directly, which causes problems on non-SYNC_INPUT hosts, and which
6259 runs afoul of improving memory_full behavior. (Bug#8761)
6260 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6261 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6262 xfree instead of the default malloc, realloc, free.
6263 (Fgnutls_boot): No need to check for memory allocation failure,
6264 since xmalloc does that for us.
6266 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6267 * category.c (hash_get_category_set):
6268 * ccl.c (ccl_driver):
6269 * charset.c (Fdefine_charset_internal):
6270 * charset.h (struct charset.hash_index):
6271 * composite.c (get_composition_id, gstring_lookup_cache)
6272 (composition_gstring_put_cache):
6273 * composite.h (struct composition.hash_index):
6274 * dispextern.h (struct image.hash):
6275 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6276 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6277 (hashfn_equal, hashfn_user_defined, make_hash_table)
6278 (maybe_resize_hash_table, hash_lookup, hash_put)
6279 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6280 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6281 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6282 * image.c (make_image, search_image_cache, lookup_image)
6283 (xpm_put_color_table_h):
6284 * lisp.h (struct Lisp_Hash_Table):
6285 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6286 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6287 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6288 * alloc.c (allocate_vectorlike):
6289 Check for overflow in vector size calculations.
6290 * ccl.c (ccl_driver):
6291 Check for overflow when converting EMACS_INT to int.
6292 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6293 need to be updated by these changes.
6294 * fns.c (make_hash_table, maybe_resize_hash_table):
6295 Check for integer overflow with large hash tables.
6296 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6297 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6298 (SXHASH_REDUCE): New macro.
6299 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6300 Use it instead of discarding useful hash info with large hash values.
6301 (sxhash_float): New function.
6302 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6303 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6304 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6305 Rewrite to use FIXNUM_BITS, as this simplifies things.
6306 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6307 Adjust signatures to match updated version of code.
6308 (consing_since_gc): Now EMACS_INT, since a single hash table can
6309 use more than INT_MAX bytes.
6311 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6313 Make it possible to build with GCC-4.6+ -O2 -flto.
6315 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6317 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6319 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6320 Call minibuffer-inactive-mode.
6322 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6324 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6325 Update dependencies.
6327 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6329 * data.c (init_data): Remove code for UTS, this system is not
6332 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6334 Don't force ./temacs to start in terminal mode.
6336 * frame.c (make_initial_frame): Initialize faces in all cases, not
6337 only when CANNOT_DUMP is defined.
6338 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6340 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6342 * dispnew.c (add_window_display_history): Use const for the string
6343 pointer. Remove declaration, not needed.
6345 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6347 Use 'inline', not 'INLINE'.
6348 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6349 * alloc.c, fontset.c (INLINE): Remove.
6350 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6351 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6352 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6353 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6354 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6356 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6358 Make it possible to run ./temacs.
6360 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6361 syms_of_callproc does the same thing. Remove test for
6362 "initialized", do it in the caller.
6363 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6365 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6367 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6368 (read_minibuf): Use get_minibuffer.
6369 (syms_of_minibuf): Use DEFSYM.
6370 (Qmetadata): New var.
6371 * data.c (Qbuffer): Don't make it static.
6372 (syms_of_data): Use DEFSYM.
6374 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6376 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6377 (CCL_CODE_MIN): New macro.
6379 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6381 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6383 * eval.c (Qdebug): Now static.
6384 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6385 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6386 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6388 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6390 * image.c: Various fixes to ImageMagick code comments.
6391 (Fimagemagick_types): Doc fix.
6393 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6395 Minor fixes prompted by GCC 4.6.0 warnings.
6397 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6399 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6400 (x_clipboard_manager_save_all): Move extern decl to ...
6401 * xterm.h: ... here, so that it can be checked for consistency.
6403 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6405 * xselect.c (x_clipboard_manager_save_frame)
6406 (x_clipboard_manager_save_all): New functions.
6407 (Fx_clipboard_manager_save): Lisp function deleted.
6409 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6410 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6412 * xterm.h: Update prototype.
6414 2011-05-28 William Xu <william.xwl@gmail.com>
6416 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6419 2011-05-28 Jim Meyering <meyering@redhat.com>
6421 Avoid a sign-extension bug in crypto_hash_function.
6422 * fns.c (to_uchar): Define.
6423 (crypto_hash_function): Use it to convert some newly-signed
6424 variables to unsigned, to avoid sign-extension bugs. For example,
6425 without this change, (md5 "truc") would evaluate to
6426 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6427 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6428 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6430 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6432 Integer overflow fixes.
6434 * dbusbind.c: Serial number integer overflow fixes.
6435 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6436 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6437 to hold a serial number that is too large for a fixnum.
6438 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6439 Check for serial numbers out of range. Decode any serial number
6440 that was so large that it became a float. (Bug#8722)
6442 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6443 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6444 Use XFASTINT rather than XUINT when numbers are nonnegative.
6445 (xd_append_arg, Fdbus_method_return_internal):
6446 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6447 arguments, check that Lisp number is nonnegative, rather than
6448 silently wrapping negative numbers around. (Bug#8722)
6449 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6452 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6454 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6456 ccl: Add integer overflow checks.
6457 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6458 (IN_INT_RANGE): New macros.
6459 (ccl_driver): Use them to check for integer overflow when
6460 decoding a CCL program. Many of the new checks are whether XINT (x)
6461 fits in int; it doesn't always, on 64-bit hosts. The new version
6462 doesn't catch all possible integer overflows, but it's an
6463 improvement. (Bug#8719)
6465 * alloc.c (make_event_array): Use XINT, not XUINT.
6466 There's no need for unsigned here.
6468 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6469 This follows up to the 2011-05-06 change that substituted uintptr_t
6470 for EMACS_INT. This case wasn't caught back then.
6472 Rework Fformat to avoid integer overflow issues.
6473 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6474 now (part of C89). Include <verify.h>.
6475 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6476 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6477 (Fformat): Avoid the prepass trying to compute sizes; it was only
6478 approximate and thus did not catch overflow reliably. Instead, walk
6479 through the format just once, formatting and computing sizes as we go,
6480 checking for integer overflow at every step, and allocating a larger
6481 buffer as needed. Keep track separately whether the format is
6482 multibyte. Keep only the most-recently calculated precision, rather
6483 than them all. Record whether each argument has been converted to
6484 string. Use EMACS_INT, not int, for byte and char and arg counts.
6485 Support field widths and precisions larger than INT_MAX. Avoid
6486 sprintf's undefined behavior with conversion specifications such as %#d
6487 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6488 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6489 formatting out-of-range floating point numbers with int
6492 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6494 * data.c: Avoid integer truncation in expressions involving floats.
6495 * data.c: Include <intprops.h>.
6496 (arith_driver): When there's an integer overflow in an expression
6497 involving floating point, convert the integers to floating point
6498 so that the resulting value does not suffer from catastrophic
6499 integer truncation. For example, on a 64-bit host (* 4
6500 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6501 Do not rely on undefined behavior after integer overflow.
6503 merge count_size_as_multibyte, parse_str_to_multibyte
6504 * character.c, character.h (count_size_as_multibyte):
6505 Rename from parse_str_to_multibyte; all uses changed.
6506 Check for integer overflow.
6507 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6508 since it's now a duplicate of the other. This is more of
6509 a character than a buffer op, so better that it's in character.c.
6510 * fns.c, print.c: Adjust to above changes.
6512 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6514 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6516 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6518 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6519 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6520 (x_clipboard_manager_save): Now static.
6521 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6523 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6524 (crypto_hash_function): Now static.
6525 Fix pointer signedness problems. Avoid unnecessary initializations.
6527 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6529 * termhooks.h (Vselection_alist): Make it terminal-local.
6531 * terminal.c (create_terminal): Initialize it.
6533 * xselect.c: Support for clipboard managers.
6534 (Vselection_alist): Move to termhooks.h as terminal-local var.
6535 (LOCAL_SELECTION): New macro.
6536 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6537 (symbol_to_x_atom): Remove gratuitous arg.
6538 (x_handle_selection_request, lisp_data_to_selection_data)
6539 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6540 (x_own_selection, x_get_local_selection, x_convert_selection):
6541 New arg, specifying work frame. Use terminal-local Vselection_alist.
6542 (some_frame_on_display): Delete unused function.
6543 (Fx_own_selection_internal, Fx_get_selection_internal)
6544 (Fx_disown_selection_internal, Fx_selection_owner_p)
6545 (Fx_selection_exists_p): New optional frame arg.
6546 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6547 (x_handle_selection_clear): Don't treat other terminals with the
6548 same keyboard specially. Use the terminal-local Vselection_alist.
6549 (x_clear_frame_selections): Use Frun_hook_with_args.
6551 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6553 * xterm.h: Add support for those atoms.
6555 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6557 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6558 (converted_selections, conversion_fail_tag): New global variables.
6559 (x_selection_request_lisp_error): Free the above.
6560 (x_get_local_selection): Remove unnecessary code.
6561 (x_reply_selection_request): Args changed; handle arbitrary array
6562 of converted selections stored in converted_selections.
6563 Separate the XChangeProperty and SelectionNotify steps.
6564 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6565 (x_convert_selection): New function.
6566 (x_handle_selection_event): Simplify.
6567 (x_get_foreign_selection): Don't ignore incoming requests while
6568 waiting for an answer; this will fail when we implement
6569 SAVE_TARGETS, and seems unnecessary anyway.
6570 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6571 (Vx_sent_selection_functions): Doc fix.
6573 2011-05-26 Leo Liu <sdl.web@gmail.com>
6575 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6577 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6579 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6581 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6582 for fringe update if it has periodic bitmap.
6583 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6584 and fringe_bitmap_periodic_p.
6586 * fringe.c (get_fringe_bitmap_data): New function.
6587 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6588 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6589 row. Mark glyph row for fringe update if periodicity changed.
6591 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6592 for fringe update unless it has periodic bitmap.
6594 2011-05-25 Kenichi Handa <handa@m17n.org>
6596 * xdisp.c (get_next_display_element): Set correct it->face_id for
6597 a static composition.
6599 2011-05-24 Leo Liu <sdl.web@gmail.com>
6602 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6604 * fns.c (crypto_hash_function, Fsha1): New function.
6605 (Fmd5): Use crypto_hash_function.
6606 (syms_of_fns): Add Ssha1.
6608 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6610 * gnutls.c: Remove unused macros.
6611 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6612 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6613 Remove macros that are defined and never used.
6614 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6616 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6618 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6619 (Fx_get_selection_internal): Minor cleanup.
6620 (Fx_own_selection_internal): Rename arguments for consistency with
6623 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6625 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6627 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6629 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6631 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6633 * dispnew.c (scrolling_window): Don't exclude the case that the
6634 last enabled row in the desired matrix touches the bottom boundary.
6636 2011-05-21 Glenn Morris <rgm@gnu.org>
6638 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6639 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6640 and add some more files.
6642 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6644 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6645 report_file_error introduced by the change from 2011-05-07.
6647 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6649 * systime.h (Time): Define only if emacs is defined.
6650 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6651 where the include path doesn't have X11/X.h by default. See
6652 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6654 2011-05-20 Kenichi Handa <handa@m17n.org>
6656 * composite.c (find_automatic_composition): Fix previous change.
6658 2011-05-20 Glenn Morris <rgm@gnu.org>
6660 * lisp.mk: New file, split from Makefile.in.
6661 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6662 (shortlisp): Remove.
6663 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6665 2011-05-19 Glenn Morris <rgm@gnu.org>
6667 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6668 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6669 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6670 (lisp): Set the order to that of loadup.el.
6671 (shortlisp): Make it a copy of $lisp.
6672 (SOME_MACHINE_LISP): Remove.
6673 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6674 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6676 2011-05-18 Kenichi Handa <handa@m17n.org>
6678 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6679 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6680 (find_automatic_composition): Mostly rewrite for efficiency.
6682 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6684 * makefile.w32-in: Update dependencies.
6686 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6688 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6689 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6691 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6693 Fix some integer overflow issues, such as string length overflow.
6695 * insdel.c (count_size_as_multibyte): Check for string overflow.
6697 * character.c (lisp_string_width): Check for string overflow.
6698 Use EMACS_INT, not int, for string indexes and lengths; in
6699 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6700 the resulting string length overflows an EMACS_INT; instead,
6701 report a string overflow if no precision given. When checking for
6702 precision exhaustion, use a check that cannot possibly have
6703 integer overflow. (Bug#8675)
6704 * character.h (lisp_string_width): Adjust to new signature.
6706 * alloc.c (string_overflow): New function.
6707 (Fmake_string): Use it. This doesn't change behavior, but saves
6708 a few bytes and will simplify future changes.
6709 * character.c (string_escape_byte8): Likewise.
6710 * lisp.h (string_overflow): New decl.
6712 Fixups, following up to the user-interface timestamp change.
6713 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6714 for UI timestamps, instead of unsigned long.
6715 * msdos.c (mouse_get_pos): Likewise.
6716 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6717 * w32gui.h (Time): Define by including "systime.h" rather than by
6718 declaring it ourselves. (Bug#8664)
6720 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6721 * image.c (clear_image_cache): Likewise.
6723 * term.c (term_mouse_position): Don't assume time_t wraparound.
6725 Be more systematic about user-interface timestamps.
6726 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6727 and sometimes 'EMACS_UINT', to represent these timestamps.
6728 This change causes it to use 'Time' uniformly, as that's what X uses.
6729 This makes the code easier to follow, and makes it easier to catch
6730 integer overflow bugs such as Bug#8664.
6731 * frame.c (Fmouse_position, Fmouse_pixel_position):
6732 Use Time, not unsigned long, for user-interface timestamps.
6733 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6734 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6735 * keyboard.h (last_event_timestamp): Likewise.
6736 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6737 * menu.h (xmenu_show): Likewise.
6738 * term.c (term_mouse_position): Likewise.
6739 * termhooks.h (struct input_event.timestamp): Likewise.
6740 (struct terminal.mouse_position_hook): Likewise.
6741 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6742 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6743 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6744 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6746 * menu.h, termhooks.h: Include "systime.h", for Time.
6748 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6749 Don't assume that the difference between two unsigned long values
6750 can fit into an integer. At this point, we know button_down_time
6751 <= event->timestamp, so the difference must be nonnegative, so
6752 there's no need to cast the result if double-click-time is
6753 nonnegative, as it should be; check that it's nonnegative, just in
6754 case. This bug is triggered when events are more than 2**31 ms
6755 apart (about 25 days). (Bug#8664)
6757 * xselect.c (last_event_timestamp): Remove duplicate decl.
6758 (x_own_selection): Remove needless cast to unsigned long.
6760 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6761 that always fit in int. Use a sentinel instead of a counter, to
6762 avoid a temp and to allay GCC's concerns about possible int overflow.
6763 * frame.h (struct frame): Use int for menu_bar_items_used
6764 instead of EMACS_INT, since it always fits in int.
6766 * menu.c (grow_menu_items): Check for int overflow.
6768 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6770 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6771 Before, the code was not consistent. These values cannot exceed
6772 2**31 - 1 so there's no need to make them unsigned.
6773 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6774 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6775 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6777 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6779 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6780 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6781 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6782 presumably because the widths might not match.
6784 * window.c (size_window): Avoid needless test at loop start.
6786 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6788 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6790 2011-05-12 Drew Adams <drew.adams@oracle.com>
6792 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6794 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6796 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6797 `width' to `bar_area_x' and `bar_area_width', respectively.
6798 (x_scroll_run): Take account of fringe background extension.
6800 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6801 Rename local vars `left' and `width' to `bar_area_x' and
6802 `bar_area_width', respectively.
6803 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6804 background extension.
6806 2011-05-10 Jim Meyering <meyering@redhat.com>
6808 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6810 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6812 * image.c (Finit_image_library): Return t for built-in image types,
6813 like pbm and xbm. (Bug#8640)
6815 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6817 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6819 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6821 * w32console.c (Fset_screen_color): Doc fix.
6822 (Fget_screen_color): New function.
6823 (syms_of_ntterm): Defsubr it.
6825 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6826 unlink the temporary file if Fcall_process didn't create it in the
6828 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6829 child process will be redirected to a file specified with `:file'.
6830 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6831 cue to call_process_cleanup not to close that handle.
6833 2011-05-07 Ben Key <bkey76@gmail.com>
6835 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6836 one of two shell specific rules, either bootstrap-temacs-CMD or
6837 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6838 to the previous implementation of the bootstrap-temacs rule.
6839 The bootstrap-temacs-CMD rule is similar to the previous
6840 implementation of the bootstrap-temacs rule except that it
6841 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6844 These changes, along with some changes to nt/configure.bat,
6845 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6846 earlier fix to add support for --cflags and --ldflags options
6847 that include quotes so that it works whether make uses cmd or
6850 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6852 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6853 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6855 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6856 a string. Handle both cases.
6857 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6858 (Fdbus_register_method): Use Qinvalid_function.
6860 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6862 * makefile.w32-in: Update dependencies.
6863 (LISP_H): Add inttypes.h and stdin.h.
6864 (PROCESS_H): Add unistd.h.
6866 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6868 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6869 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6871 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6873 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6875 * term.c (vfatal): Remove stray call to va_end.
6876 It's not needed and the C Standard doesn't allow it here anyway.
6878 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6879 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6881 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6884 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6886 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6888 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6890 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6892 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6894 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6895 * charset.c (Fdefine_charset_internal): Don't initialize
6896 charset.code_space[15]. The value was garbage, on hosts with
6897 32-bit int (Bug#8600).
6899 * lread.c (read_integer): Be more consistent with string-to-number.
6900 Use string_to_number to do the actual conversion; this avoids
6901 rounding errors and fixes some other screwups. Without this fix,
6902 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6903 (digit_to_number): Move earlier, for benefit of read_integer.
6904 Return -1 if the digit is out of range for the base, -2 if it is
6905 not a digit in any supported base. (Bug#8602)
6907 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6909 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6910 to match comment at start of function. This also removes a
6911 GCC warning about overflow in a 32+64-bit port.
6913 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6915 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6916 Reported by Stefan Monnier in
6917 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6918 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6919 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6921 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6922 (EMACS_UINTPTR): Likewise, with uintptr_t.
6924 * lisp.h: Prefer 64-bit EMACS_INT if available.
6925 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6926 on 32-bit hosts that have 64-bit int, so that they can access
6928 However, temporarily disable this change unless the temporary
6929 symbol WIDE_EMACS_INT is defined.
6931 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6933 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6934 This removes an assumption that EMACS_INT and long are the same
6935 width as pointers. The assumption is true for Emacs porting targets
6936 now, but we want to make other targets possible.
6937 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6938 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6939 In the rest of the code, change types of integers that hold casted
6940 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6941 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6942 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6943 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6944 No need to cast type when ORing.
6945 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6946 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6947 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6948 assume EMACS_INT is the same width as char *.
6949 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6950 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6951 Remove no-longer-needed casts.
6952 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6953 (xg_tool_bar_help_callback, xg_make_tool_item):
6954 Use EMACS_INTPTR to hold an integer
6955 that will be cast to void *; this can avoid a GCC warning
6956 if EMACS_INT is not the same width as void *.
6957 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6958 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6959 (current_message_1, set_message_1):
6960 Use a local to convert to proper width without a cast.
6961 * xmenu.c (dialog_selection_callback): Likewise.
6963 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6964 Also, don't assume VALBITS / RAND_BITS is less than 5,
6965 and don't rely on undefined behavior when shifting a 1 left into
6967 * lisp.h (get_random): Change signature to match.
6969 * lread.c (hash_string): Use size_t, not int, for hash computation.
6970 Normally we prefer signed values; but hashing is special, because
6971 it's better to use unsigned division on hash table sizes so that
6972 the remainder is nonnegative. Also, size_t is the natural width
6973 for hashing into memory. The previous code used 'int', which doesn't
6974 retain enough info to hash well into very large tables.
6975 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6977 * dbusbind.c: Don't possibly lose pointer info when converting.
6978 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6979 Use XPNTR rather than XHASH, so that the high-order bits of
6980 the pointer aren't lost when converting through void *.
6982 * eval.c (Fautoload): Don't double-shift a pointer.
6984 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6986 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6988 * gnutls.c (DEF_GNUTLS_FN):
6989 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6991 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6993 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6996 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6998 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6999 New version that can reserve upto 2GB of heap space.
7001 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7003 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7005 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7007 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7008 `gnutls_certificate_set_x509_key_file'.
7010 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7012 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7013 Update dependencies.
7015 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7017 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7018 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7019 Remove unused parameter `fildes'.
7020 * process.c (read_process_output, send_process): Don't pass it.
7022 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7024 Fix previous change: the library cache is defined in w32.c.
7025 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7026 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7028 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7030 Implement dynamic loading of GnuTLS on Windows.
7032 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7033 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7034 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7037 * gnutls.c (Qgnutls_dll): Define.
7038 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7039 (gnutls_*): Declare function pointers.
7040 (init_gnutls_functions): New function to initialize function pointers.
7041 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7042 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7043 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7044 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7045 (emacs_gnutls_write, emacs_gnutls_read)
7046 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7047 (Fgnutls_available_p): New function.
7048 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7049 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7050 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7052 * image.c: Include w32.h.
7053 (Vimage_type_cache): Delete.
7054 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7055 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7056 (w32_delayed_load): Move to w32.c.
7058 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7060 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7061 (w32_delayed_load): Move from image.c. When loading a library, record
7062 its filename in the :loaded-from property of the library id.
7063 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7064 Initialize and staticpro them.
7065 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7067 * process.c: Include lisp.h before w32.h, not after.
7068 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7069 instead of gnutls_record_check_pending.
7071 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7073 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7075 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7076 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7079 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7081 * xterm.c (x_set_frame_alpha): Do not set property on anything
7082 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7084 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7086 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7088 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7090 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7091 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7092 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7093 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7094 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7095 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7096 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7097 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7098 (Qgnutls_bootprop_callbacks_verify): Make static.
7100 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7102 * callproc.c: Indentation fixup.
7104 * sysdep.c (wait_for_termination_1): Make static.
7105 (wait_for_termination, interruptible_wait_for_termination):
7106 Move after wait_for_termination_1.
7108 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7110 * sysdep.c (interruptible_wait_for_termination): New function
7111 which is like wait_for_termination, but allows keyboard
7114 * callproc.c (Fcall_process): Add (:file "file") as an option for
7116 (Fcall_process_region): Ditto.
7118 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7120 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7121 rather than `XVECTOR (FOO)->size'.
7123 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7124 inttypes.h, as a gnulib replacement is used if it not available in
7127 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7129 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7130 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7131 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7133 * coding.c (coding_alloc_by_realloc): Error out if destination
7134 will grow beyond MOST_POSITIVE_FIXNUM.
7135 (decode_coding_emacs_mule): Abort if there isn't enough place in
7136 charbuf for the composition carryover bytes. Reserve an extra
7137 space for up to 2 characters produced in a loop.
7138 (decode_coding_iso_2022): Abort if there isn't enough place in
7139 charbuf for the composition carryover bytes.
7141 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7143 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7144 aborting when %lld or %lll format is passed.
7145 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7146 %llo or %llx format is passed. (Bug#8545)
7148 * window.c (window_scroll_line_based): Use a marker instead of
7149 simple variables to record original value of point. (Bug#7952)
7151 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7152 produced by %s or %c overflows available buffer space. (Bug#8545)
7154 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7156 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7157 (SIZE_MAX): Move defn after all includes, as they might #define it.
7159 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7161 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7163 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7165 * keyboard.c (Qdelayed_warnings_hook): Define.
7166 (command_loop_1): Run `delayed-warnings-hook'
7167 if Vdelayed_warnings_list is non-nil.
7168 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7169 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7171 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7173 * doprnt.c (doprnt): Don't return value smaller than the buffer
7174 size if the message was truncated. (Bug#8545).
7176 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7178 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7179 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7181 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7183 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7185 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7187 * makefile.w32-in: Update dependencies.
7189 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7191 Improve `doprnt' and its usage. (Bug#8545)
7192 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7193 `format_end'. Remove support for %l as a conversion specifier.
7194 Don't use xrealloc. Improve diagnostics when the %l size modifier
7195 is used. Update the commentary.
7197 * eval.c (verror): Simplify calculation of size_t.
7199 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7202 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7204 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7207 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7209 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7210 This makes this file independent of the recent pseudovector change.
7212 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7214 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7216 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7217 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7218 Remove unused local.
7219 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7221 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7222 GCC 4.6.0 optimizes based on type-based alias analysis.
7223 For example, if b is of type struct buffer * and v of type struct
7224 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7225 != &v->size, and therefore "v->size = 1; b->size = 2; return
7226 v->size;" must therefore return 1. This assumption is incorrect
7227 for Emacs, since it type-puns struct Lisp_Vector * with many other
7228 types. To fix this problem, this patch adds a new type struct
7229 vectorlike_header that documents the constraints on layout of vectors
7230 and pseudovectors, and helps optimizing compilers not get fooled
7231 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7232 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7233 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7235 (XSETPVECTYPE): Rewrite in terms of new macro.
7236 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7237 This is a bit clearer, and further avoids the possibility of
7238 undesirable aliasing.
7239 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7240 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7241 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7242 since Lisp_Subr is a special case (no "next" field).
7243 (ASIZE): Now uses header.size rather than size.
7244 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7245 to avoid the hassle of writing XVECTOR (foo)->header.size.
7246 (struct vectorlike_header): New type.
7247 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7248 object, to help avoid aliasing.
7249 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7250 (SUBRP): Likewise, since Lisp_Subr is a special case.
7251 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7252 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7253 (struct Lisp_Hash_Table): Combine first two members into a single
7254 struct vectorlike_header member. All uses of "size" and "next" members
7255 changed to be "header.size" and "header.next".
7256 * buffer.h (struct buffer): Likewise.
7257 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7258 * frame.h (struct frame): Likewise.
7259 * process.h (struct Lisp_Process): Likewise.
7260 * termhooks.h (struct terminal): Likewise.
7261 * window.c (struct save_window_data, struct saved_window): Likewise.
7262 * window.h (struct window): Likewise.
7263 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7264 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7265 * buffer.c (init_buffer_once): Likewise.
7266 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7268 * process.c (Fformat_network_address): Use local var for size,
7271 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7273 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7274 * data.c (atof): Remove decl; no longer used or needed.
7275 (digit_to_number): Move to lread.c.
7276 (Fstring_to_number): Use new string_to_number function, to be
7277 consistent with how the Lisp reader treats infinities and NaNs.
7278 Do not assume that floating-point numbers represent EMACS_INT
7279 without losing information; this is not true on most 64-bit hosts.
7280 Avoid double-rounding errors, by insisting on integers when
7281 parsing non-base-10 numbers, as the documentation specifies.
7282 * lisp.h (string_to_number): New decl, replacing ...
7283 (isfloat_string): Remove.
7284 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7285 (read1): Do not accept +. and -. as integers; this
7286 appears to have been a coding error. Similarly, do not accept
7287 strings like +-1e0 as floating point numbers. Do not report
7288 overflow for integer overflows unless the base is not 10 which
7289 means we have no simple and reliable way to continue.
7290 Break out the floating-point parsing into a new
7291 function string_to_number, so that Fstring_to_number parses
7292 floating point numbers consistently with the Lisp reader.
7293 (digit_to_number): Move here from data.c. Make it static inline.
7294 (E_CHAR, EXP_INT): Remove, replacing with ...
7295 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7296 (string_to_number): New function, replacing isfloat_string.
7297 This function checks for valid syntax and produces the resulting
7298 Lisp float number too. Rework it so that string-to-number
7299 no longer mishandles examples like "1.0e+". Use strtoumax,
7300 so that overflow for non-base-10 numbers is reported only when
7301 there's no portable and simple way to convert to floating point.
7303 * textprop.c (set_text_properties_1): Rewrite for clarity,
7304 and to avoid GCC warning about integer overflow.
7306 * intervals.h (struct interval): Use EMACS_INT for members
7307 where EMACS_UINT might cause problems. See
7308 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7309 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7310 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7312 (offset_intervals): Tell GCC not to worry about length overflow
7313 when negating a negative length.
7315 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7316 (overrun_check_free): Likewise.
7318 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7319 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7322 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7323 (gnutls_make_error): Rename local to avoid shadowing.
7324 (gnutls_emacs_global_deinit): ifdef out; not used.
7325 (Fgnutls_boot): Use const for pointer to readonly storage.
7326 Comment out unused local. Fix pointer signedness problems.
7328 * lread.c (openp): Don't stuff size_t into an 'int'.
7329 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7330 about possible signed overflow.
7332 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7333 (GDK_KEY_g): Don't define if already defined.
7334 (xg_prepare_tooltip): Avoid pointer signedness problem.
7335 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7337 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7338 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7340 * xfns.c (Fx_window_property): Simplify a bit,
7341 to make a bit faster and to avoid GCC 4.6.0 warning.
7342 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7344 * fns.c (internal_equal): Don't assume size_t fits in int.
7346 * alloc.c (compact_small_strings): Tighten assertion a little.
7348 Replace pEd with more-general pI, and fix some printf arg casts.
7349 * lisp.h (pI): New macro, generalizing old pEd macro to other
7350 conversion specifiers. For example, use "...%"pI"d..." rather
7351 than "...%"pEd"...".
7352 (pEd): Remove. All uses replaced with similar uses of pI.
7353 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7354 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7355 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7356 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7357 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7358 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7359 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7361 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7362 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7363 * print.c (safe_debug_print, print_object): Likewise.
7364 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7366 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7367 avoiding the 0 flag, which is not portable.
7368 * process.c (Fmake_network_process): Use pI to avoid cast.
7369 * region-cache.c (pp_cache): Likewise.
7370 * xdisp.c (decode_mode_spec): Likewise.
7371 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7372 behavior on 64-bit hosts with printf arg.
7373 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7374 (x_stop_queuing_selection_requests): Likewise.
7375 (x_get_window_property): Don't truncate byte count to an 'int'
7378 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7379 here, since it parses constructs like leading '-' and spaces,
7380 which are not wanted; and it overflows with large numbers.
7381 Instead, simply match F[0-9]+, which is what is wanted anyway.
7383 * alloc.c: Remove unportable assumptions about struct layout.
7384 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7385 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7386 (allocate_vectorlike, make_pure_vector): Use the new macros,
7387 plus offsetof, to remove unportable assumptions about struct layout.
7388 These assumptions hold on all porting targets that I know of, but
7389 they are not guaranteed, they're easy to remove, and removing them
7390 makes further changes easier.
7392 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7393 This doesn't fix a bug but makes the code clearer.
7394 (string_overrun_cookie): Now const. Use initializers that
7395 don't formally overflow signed char, to avoid warnings.
7396 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7397 can cause Emacs to crash when string overrun checking is enabled.
7398 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7399 multiple of sizeof (EMACS_INT); it need not be, if
7400 alignof(EMACS_INT) < sizeof (EMACS_INT).
7401 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7403 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7405 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7407 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7409 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7410 supposed to be handshaking. (Bug#8556)
7411 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7413 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7415 * lisp.h (Qdebug): List symbol.
7416 * eval.c (Qdebug): Restore global linkage.
7417 * keyboard.c (debug-on-event): New variable.
7418 (handle_user_signal): Break into debugger when debug-on-event
7419 matches the current signal symbol.
7421 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7423 * alloc.c (check_sblock, check_string_bytes)
7424 (check_string_free_list): Convert to standard C.
7426 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7428 * w32.c (emacs_gnutls_push): Fix typo.
7430 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7432 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7433 "cast to pointer from integer of different size".
7435 Improve doprnt and its use in verror. (Bug#8545)
7436 * doprnt.c (doprnt): Document the set of format control sequences
7437 supported by the function. Use SAFE_ALLOCA instead of always
7440 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7441 is one byte too soon. Don't use xrealloc; instead xfree and
7444 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7446 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7449 * gnutls.c: Renamed global_initialized to
7450 gnutls_global_initialized. Added internals for the
7451 :verify-hostname-error, :verify-error, and :verify-flags
7452 parameters of `gnutls-boot' and documented those parameters in the
7453 docstring. Start callback support.
7454 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7455 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7456 on error. Return error code.
7457 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7458 (emacs_gnutls_read): Likewise.
7459 (Fgnutls_boot): Return handshake error code.
7460 (emacs_gnutls_handle_error): New function.
7461 (wsaerror_to_errno): Likewise.
7463 * w32.h (emacs_gnutls_pull): Add prototype.
7464 (emacs_gnutls_push): Likewise.
7466 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7467 (emacs_gnutls_push): Likewise.
7469 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7471 * process.c (wait_reading_process_output): Check if GnuTLS
7472 buffered some data internally if no FDs are set for TLS
7475 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7476 (LIBS): Link to USER_LIBS.
7477 ($(BLD)/gnutls.$(0)): New target.
7479 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7481 * xdisp.c (handle_single_display_spec): Rename the
7482 display_replaced_before_p argument into display_replaced_p, to
7483 make it consistent with the commentary. Fix typos in the
7486 * textprop.c (syms_of_textprop): Remove dead code.
7487 (copy_text_properties): Delete obsolete commentary about an
7488 interface that was deleted long ago. Fix typos in the description
7491 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7492 to changes in oldXMenu/XMenu.h from 2011-04-16.
7493 <menu_help_message, prev_menu_help_message>: Constify.
7494 (IT_menu_make_room): menu->help_text is now `const char **';
7497 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7498 to changes in oldXMenu/XMenu.h from 2011-04-16.
7499 (struct XMenu): Declare `help_text' `const char **'.
7501 * xfaces.c <Qunspecified>: Make extern again.
7503 * syntax.c: Include sys/types.h before including regex.h, as
7506 * doc.c (get_doc_string): Improve the format passed to `error'.
7508 * doprnt.c (doprnt): Improve commentary.
7510 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7512 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7515 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7516 changes in globals.h immediately force recompilation.
7517 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7518 $(CURDIR)/s/ms-w32.h.
7519 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7521 * character.c (Fchar_direction): Function deleted.
7522 (syms_of_character): Don't defsubr it.
7523 <char-direction-table>: Deleted.
7525 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7527 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7528 * doprnt.c: Include limits.h.
7529 (SIZE_MAX): New macro.
7530 (doprnt): Return a size_t value. 2nd arg is now size_t.
7531 Many local variables are now size_t instead of int or unsigned.
7532 Improve overflow protection. Support `l' modifier for integer
7533 conversions. Support %l conversion. Don't assume an EMACS_INT
7534 argument for integer conversions and for %c.
7536 * lisp.h (doprnt): Restore prototype.
7538 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7541 * Makefile.in (base_obj): Add back doprnt.o.
7543 * deps.mk (doprnt.o): Add back prerequisites.
7544 (callint.o): Depend on character.h.
7546 * eval.c (internal_lisp_condition_case): Include the handler
7547 representation in the error message.
7548 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7549 when breaking from the loop.
7551 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7553 * callint.c (Fcall_interactively): When displaying error message
7554 about invalid control letter, pass the character's codepoint, not
7555 a pointer to its multibyte form. Improve display of the character
7556 in octal and display also its hex code.
7558 * character.c (char_string): Use %x to display the (unsigned)
7559 codepoint of an invalid character, to avoid displaying a bogus
7562 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7563 `error', not SYMBOL_NAME itself.
7565 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7566 character arguments to `error'.
7568 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7569 to `error' in error message about FINAL_CHAR argument. Make sure
7570 FINAL_CHAR is a character, and use %c when it is passed as
7571 argument to `error'.
7573 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7575 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7577 * w32.c: Include <time.h>.
7578 (sys_localtime): New function.
7580 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7582 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7584 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7586 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7588 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7591 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7593 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7594 gl_state.e_property when gl_state.object is Qt.
7596 * insdel.c (make_gap_larger): Remove limitation of buffer size
7599 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7601 * xdisp.c (lookup_glyphless_char_display)
7602 (produce_glyphless_glyph): Handle cons cell entry in
7603 glyphless-char-display.
7604 (Vglyphless_char_display): Document it.
7606 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7607 glyphless-char-display.
7609 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7611 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7613 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7615 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7616 definition for no-X builds.
7618 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7620 Static checks with GCC 4.6.0 and non-default toolkits.
7622 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7624 * process.c (keyboard_bit_set): Define only if SIGIO.
7625 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7626 (send_process): Repair possible setjmp clobbering.
7628 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7630 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7632 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7634 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7635 Define only if needed.
7637 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7638 by pacifying GCC about it. Maybe it's time to retire it?
7639 * xfaces.c (USG, __TIMEVAL__): Likewise.
7641 * dispextern.h (struct redisplay_interface): Rename param
7643 * termhooks.h (struct terminal): Likewise.
7644 * xterm.c (xembed_send_message): Likewise.
7646 * insdel.c (make_gap_smaller): Define only if
7647 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7649 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7652 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7653 so that we aren't warned about unused symbols.
7655 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7657 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7659 * xfns.c (x_real_positions): Mark locals as initialized.
7661 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7663 * xterm.c: Fix problems found by static analysis with other toolkits.
7664 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7665 (x_dispatch_event): Declare static if USE_GTK, and
7666 define if USE_GTK || USE_X_TOOLKIT.
7667 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7668 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7669 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7670 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7672 * xmenu.c (menu_help_callback): Pointer type fixes.
7673 Use const pointers when pointing at readonly data. Avoid pointer
7675 (FALSE): Remove unused macro.
7676 (update_frame_menubar): Remove unused decl.
7678 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7680 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7681 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7682 (single_menu_item): Rename local to avoid shadowing.
7684 * keyboard.c (make_lispy_event): Remove unused local var.
7686 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7687 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7689 * bitmaps: Change bitmaps from unsigned char back to the X11
7690 compatible char. Avoid the old compiler warnings about
7691 out-of-range initializers by using, for example, '\xab' rather
7694 * xgselect.c (xgselect_initialize): Check vs interface
7695 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7697 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7699 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7700 to read-only memory.
7702 * fns.c (vector): Remove; this old hack is no longer needed.
7704 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7706 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7708 * xrdb.c (x_load_resources): Omit unused local.
7710 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7711 (x_window): Rename locals to avoid shadowing.
7712 (USG): Use the kludged USG macro, to pacify gcc.
7714 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7715 (x_term_init): Remove local to avoid shadowing.
7717 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7719 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7720 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7722 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7724 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7726 Fix regex.c, syntax.c and friends for buffers > 2GB.
7727 * syntax.h (struct gl_state_s): Declare character position members
7730 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7732 * textprop.c (verify_interval_modification, interval_of):
7733 Declare arguments EMACS_INT.
7735 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7738 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7740 * indent.c (Fvertical_motion): Local variable it_start is now
7743 * regex.c (re_match, re_match_2, re_match_2_internal)
7744 (bcmp_translate, regcomp, regexec, print_double_string)
7745 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7746 (re_compile_pattern, re_exec): Declare arguments and local
7747 variables `size_t' and `ssize_t' and return values `regoff_t', as
7749 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7750 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7751 <compile_stack_type>: `size' and `avail' are now `size_t'.
7753 * regex.h <regoff_t>: Use ssize_t, not int.
7754 (re_search, re_search_2, re_match, re_match_2): Arguments that
7755 specify buffer/string position and length are now ssize_t and
7756 size_t. Return type is regoff_t.
7758 2011-04-16 Ben Key <bkey76@gmail.com>
7760 * nsfont.m: Fixed bugs in ns_get_family and
7761 ns_descriptor_to_entity that were caused by using free to
7762 deallocate memory blocks that were allocated by xmalloc (via
7763 xstrdup). This caused Emacs to crash when compiled with
7764 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7765 --enable-checking=xmallocoverrun). xfree is now used to
7766 deallocate these memory blocks.
7768 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7770 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7772 emacs_write: Accept and return EMACS_INT for sizes.
7773 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7775 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7776 Accept and return EMACS_INT.
7777 (emacs_gnutls_write): Return the number of bytes written on
7779 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7780 (emacs_read, emacs_write): Remove check for negative size, as the
7781 Emacs source code has been audited now.
7782 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7783 (emacs_read, emacs_write): Use it.
7784 * process.c (send_process): Adjust to the new signatures of
7785 emacs_write and emacs_gnutls_write. Do not attempt to store
7786 a byte offset into an 'int'; it might overflow.
7787 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7789 * sound.c: Don't assume sizes fit in 'int'.
7790 (struct sound_device.period_size, alsa_period_size):
7791 Return EMACS_INT, not int.
7792 (struct sound_device.write, vox_write, alsa_write):
7793 Accept EMACS_INT, not int.
7794 (wav_play, au_play): Use EMACS_INT to store sizes and to
7795 record read return values.
7797 2011-04-15 Ben Key <bkey76@gmail.com>
7799 * keyboard.c (Qundefined): Don't declare static since it is used
7801 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7802 static since they are used in nsfont.m.
7804 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7806 * process.c (Qprocessp): Don't declare static.
7807 * lisp.h (Qprocessp): Declare again.
7809 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7811 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7813 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7815 Improve C-level modularity by making more things 'static'.
7817 Don't publish debugger-only interfaces to other modules.
7818 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7819 (verify_bytepos, count_markers): Move decls to the only modules
7821 * region-cache.h (pp_cache): Likewise.
7822 * window.h (check_all_windows): Likewise.
7823 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7825 * sysdep.c (croak): Now static, if
7826 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7827 * syssignal.h (croak): Declare only if not static.
7829 * alloc.c (refill_memory_reserve): Now static if
7830 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7831 * lisp.h (refill_memory_reserve): Declare only if not static.
7833 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7834 Define only if USE_LUCID.
7836 * xrdb.c (x_customization_string, x_rm_string): Now static.
7838 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7839 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7841 * xdisp.c (draw_row_with_mouse_face): Now static.
7842 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7844 * window.h (check_all_windows): Mark externally visible.
7846 * window.c (window_deletion_count): Now static.
7848 * undo.c: Make symbols static if they're not exported.
7849 (last_undo_buffer, last_boundary_position, pending_boundary):
7852 * textprop.c (interval_insert_behind_hooks): Now static.
7853 (interval_insert_in_front_hooks): Likewise.
7855 * term.c: Make symbols static if they're not exported.
7856 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7857 (max_frame_lines, tty_set_terminal_modes):
7858 (tty_reset_terminal_modes, tty_turn_off_highlight):
7859 (get_tty_terminal): Now static.
7860 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7861 * termhooks.h (term_mouse_moveto): Do not declare if
7863 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7864 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7866 * sysdep.c: Make symbols static if they're not exported.
7867 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7869 (sigprocmask_set, full_mask): Remove; unused.
7870 (wait_debugging): Mark as visible.
7871 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7872 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7874 * syntax.c (syntax_temp): Define only if !__GNUC__.
7876 * sound.c (current_sound_device, current_sound): Now static.
7878 * search.c (searchbufs, searchbuf_head): Now static.
7880 * scroll.c (scroll_cost): Remove; unused.
7881 * dispextern.h (scroll_cost): Remove decl.
7883 * region-cache.h (pp_cache): Mark as externally visible.
7885 * process.c: Make symbols static if they're not exported.
7886 (process_tick, update_tick, create_process, chan_process):
7887 (Vprocess_alist, proc_buffered_char, datagram_access):
7888 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7889 (deactivate_process): Mark defn as static, as well as decl.
7890 * lisp.h (create_process): Remove decl.
7891 * process.h (chan_process, Vprocess_alist): Remove decls.
7893 * print.c: Make symbols static if they're not exported.
7894 (print_depth, new_backquote_output, being_printed, print_buffer):
7895 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7896 (print_interval, print_number_index, initial_stderr_stream):
7898 * lisp.h (Fprinc): Remove decl.
7899 (debug_output_compilation_hack): Mark as externally visible.
7901 * sysdep.c (croak): Move decl from here to syssignal.h.
7902 * syssignal.h (croak): Put it here, so the API can be checked when
7903 'croak' is called from dissociate_if_controlling_tty.
7905 * minibuf.c: Make symbols static if they're not exported.
7906 (minibuf_save_list, choose_minibuf_frame): Now static.
7907 * lisp.h (choose_minibuf_frame): Remove decl.
7909 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7911 * lread.c: Make symbols static if they're not exported.
7912 (read_objects, initial_obarray, oblookup_last_bucket_number):
7914 (make_symbol): Remove; unused.
7915 * lisp.h (initial_obarray, make_symbol): Remove decls.
7917 * keyboard.c: Make symbols static if they're not exported.
7918 (single_kboard, recent_keys_index, total_keys, recent_keys):
7919 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7920 (this_single_command_key_start, echoing, last_auto_save):
7921 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7922 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7923 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7924 (Vlispy_mouse_stem, double_click_count):
7926 (force_auto_save_soon): Define only if SIGDANGER.
7927 (ignore_mouse_drag_p): Now static if
7928 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7929 (print_help): Remove; unused.
7930 (stop_character, last_timer_event): Mark as externally visible.
7931 * keyboard.h (ignore_mouse_drag_p): Declare only if
7932 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7933 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7934 * lisp.h (echoing): Remove decl.
7935 (force_auto_save_soon): Declare only if SIGDANGER.
7936 * xdisp.c (redisplay_window): Simplify code, to make it more
7937 obvious that ignore_mouse_drag_p is not accessed if !defined
7938 USE_GTK && !defined HAVE_NS.
7940 * intervals.c: Make symbols static if they're not exported.
7941 (merge_properties_sticky, merge_interval_right, delete_interval):
7943 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7945 * insdel.c: Make symbols static if they're not exported.
7946 However, leave prepare_to_modify_buffer alone. It's never
7947 called from outside this function, but that appears to be a bug.
7948 (combine_after_change_list, combine_after_change_buffer):
7949 (adjust_after_replace, signal_before_change): Now static.
7950 (adjust_after_replace_noundo): Remove; unused.
7951 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7952 (signal_before_change): Remove decls.
7954 * indent.c (val_compute_motion, val_vmotion): Now static.
7956 * image.c: Make symbols static if they're not exported.
7957 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7959 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7960 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7962 * fringe.c (standard_bitmaps): Now static.
7963 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7965 * frame.c: Make symbols static if they're not exported.
7966 (x_report_frame_params, make_terminal_frame): Now static.
7967 (get_frame_param): Now static, unless HAVE_NS.
7968 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7969 (x_get_resource_string): Remove; not used.
7970 * frame.h (make_terminal_frame, x_report_frame_params):
7971 (x_get_resource_string); Remove decls.
7972 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7973 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7975 * font.c, fontset.c: Make symbols static if they're not exported.
7976 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7977 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7978 * font.c (font_close_object): Now static.
7979 * font.h (font_close_object): Remove.
7980 * fontset.c (FONTSET_OBJLIST): Remove.
7981 (free_realized_fontset) #if-0 the body, which does nothing.
7982 (face_suitable_for_char_p): #if-0, as it's never called.
7983 * fontset.h (face_suitable_for_char_p): Remove decl.
7984 * xfaces.c (face_at_string_position):
7985 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7986 since 0 is always ASCII.
7988 * fns.c (weak_hash_tables): Now static.
7990 * fileio.c: Make symbols static if they're not exported.
7991 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7992 (Vwrite_region_annotation_buffers): Now static.
7994 * eval.c: Make symbols static if they're not exported.
7995 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7996 * lisp.h (backtrace_list): Remove decl.
7998 * emacs.c: Make symbols static if they're not exported.
7999 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8000 (fatal_error_code, fatal_error_signal_hook, standard_args):
8002 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8003 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8004 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8005 * lisp.h (fatal_error_signal_hook): Remove decl.
8006 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8008 * editfns.c: Move a (normally-unused) function to its only use.
8009 * editfns.c, lisp.h (get_operating_system_release): Remove.
8010 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8011 worth the hassle of breaking this out.
8013 * xterm.c: Make symbols static if they're not exported.
8014 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8015 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8016 (x_destroy_window, x_delete_display):
8018 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8019 (x_mouse_leave): Remove; unused.
8020 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8021 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8022 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8024 (x_mouse_leave): Declare only if WINDOWSNT.
8025 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8026 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8029 * ftxfont.c: Make symbols static if they're not exported.
8030 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8032 * font.h (ftxfont_driver): Likewise.
8034 * xfns.c: Make symbols static if they're not exported.
8035 (x_last_font_name, x_display_info_for_name):
8036 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8037 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8038 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8039 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8040 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8041 (last_show_tip_args): Now static.
8042 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8043 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8044 (x_screen_planes): Remove; unused.
8045 * dispextern.h (x_screen_planes): Remove decl.
8047 * dispnew.c: Make symbols static if they're not exported.
8048 * dispextern.h (redraw_garbaged_frames, scrolling):
8049 (increment_row_positions): Remove.
8050 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8051 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8053 (redraw_garbaged_frames): Remove; unused.
8055 * xfaces.c: Make symbols static if they're not exported.
8056 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8058 * xterm.h (defined_color): Remove decls.
8059 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8060 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8061 (menu_face_changed_default, defined_color, free_realized_face):
8062 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8063 (ascii_face_of_lisp_face): Remove; unused.
8065 * xdisp.c: Make symbols static if they're not exported.
8066 * dispextern.h (scratch_glyph_row, window_box_edges):
8067 (glyph_to_pixel_coords, set_cursor_from_row):
8068 (get_next_display_element, set_iterator_to_next):
8069 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8070 (show_mouse_face): Remove decls
8071 * frame.h (message_buf_print): Likewise.
8072 * lisp.h (pop_message, set_message, check_point_in_composition):
8074 * xterm.h (set_vertical_scroll_bar): Likewise.
8075 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8076 (message_buf_print, scratch_glyph_row, displayed_buffer):
8077 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8078 (get_next_display_element, show_mouse_face, window_box_edges):
8079 (frame_to_window_pixel_xy, check_point_in_composition):
8080 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8081 (glyph_to_pixel_coords): Remove; unused.
8083 * dired.c (file_name_completion): Now static.
8085 * dbusbind.c (xd_in_read_queued_messages): Now static.
8087 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8088 * data.c (circular_list_error): Remove.
8090 * commands.h (last_point_position, last_point_position_buffer):
8091 (last_point_position_window): Remove decls.
8092 * keyboard.c: Make these variables static.
8094 * coding.h (coding, code_convert_region, encode_coding_gap):
8096 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8097 (iso_code_class, detect_coding, code_convert_region): Now static.
8098 (encode_coding_gap): Remove; unused.
8100 * chartab.c (chartab_chars, chartab_bits): Now static.
8102 * charset.h (charset_iso_8859_1): Remove decl.
8103 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8106 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8107 * ccl.c (Vccl_program_table): Now static.
8108 (check_ccl_update): Remove; unused.
8110 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8111 * category.h: ... from here.
8112 * category.c (check_category_table, set_category_set): Now static.
8114 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8115 * lisp.h: Remove these decls.
8117 * buffer.c (buffer_count): Remove unused var.
8119 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8120 so that it's not optimized away.
8121 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8122 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8123 exported only to the debugger.
8125 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8126 * atimer.h (run_all_atimers): Remove; not exported.
8128 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8129 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8130 was inaccessible from Lisp.
8131 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8132 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8134 alloc.c: Import and export fewer symbols, and remove unused items.
8135 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8137 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8138 it's not optimized away by whole-program optimization.
8139 (message_enable_multibyte, free_misc): Remove.
8140 (catchlist, handlerlist, mark_backtrace):
8141 Declare only if BYTE_MARK_STACK.
8142 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8143 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8144 (message_enable_multibyte): Remove decl.
8145 (free_misc, interval_free_list, float_block, float_block_index):
8146 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8147 (cons_free_list, last_marked_index):
8149 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8150 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8151 (mark_backtrace): Define only if BYTE_MARK_STACK.
8152 * xdisp.c (message_enable_multibyte): Now static.
8154 Declare Lisp_Object Q* variables to be 'static' if not exported.
8155 This makes it easier for human readers (and static analyzers)
8156 to see whether these variables are used from other modules.
8157 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8158 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8159 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8160 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8161 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8162 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8163 * xmenu.c, xselect.c:
8164 Declare Q* vars static if they are not used in other modules.
8165 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8166 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8167 Remove decls of unexported vars.
8168 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8170 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8172 Make Emacs functions such as Fatom 'static' by default.
8173 This makes it easier for human readers (and static analyzers)
8174 to see whether these functions can be called from other modules.
8175 DEFUN now defines a static function. To make the function external
8176 so that it can be used in other C modules, use the new macro DEFUE.
8177 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8178 (Finit_image_library):
8179 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8180 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8181 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8182 Remove decls, since these functions are now static.
8183 (Funintern, Fget_internal_run_time): New decls, since these functions
8184 were already external.
8186 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8187 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8188 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8189 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8190 * keyboard.c, keymap.c, lread.c:
8191 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8192 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8193 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8194 Mark functions with DEFUE instead of DEFUN,
8195 if they are used in other modules.
8196 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8197 decls for now-static functions.
8198 * buffer.h (Fdelete_overlay): Remove decl.
8199 * callproc.c (Fgetenv_internal): Mark as internal.
8200 * composite.c (Fremove_list_of_text_properties): Remove decl.
8201 (Fcomposition_get_gstring): New forward static decl.
8202 * composite.h (Fcomposite_get_gstring): Remove decl.
8203 * dired.c (Ffile_attributes): New forward static decl.
8204 * doc.c (Fdocumntation_property): New forward static decl.
8205 * eval.c (Ffetch_bytecode): New forward static decl.
8206 (Funintern): Remove extern decl; now in .h file where it belongs.
8207 * fileio.c (Fmake_symbolic_link): New forward static decl.
8208 * image.c (Finit_image_library): New forward static decl.
8209 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8210 * intervals.h (Fprevious_property_change):
8211 (Fremove_list_of_text_properties): Remove decls.
8212 * keyboard.c (Fthis_command_keys): Remove decl.
8213 (Fcommand_execute): New forward static decl.
8214 * keymap.c (Flookup_key): New forward static decl.
8215 (Fcopy_keymap): Now static.
8216 * keymap.h (Flookup_key): Remove decl.
8217 * process.c (Fget_process): New forward static decl.
8218 (Fprocess_datagram_address): Mark as internal.
8219 * syntax.c (Fsyntax_table_p): New forward static decl.
8220 (skip_chars): Remove duplicate decl.
8221 * textprop.c (Fprevious_property_change): New forward static decl.
8222 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8224 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8225 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8227 * editfns.c (Fformat): Remove unreachable code.
8229 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8231 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8234 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8236 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8237 when at ZV. (Bug#8487)
8239 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8241 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8243 * keyboard.c (parse_tool_bar_item): Likewise.
8244 * sound.c (sound_cleanup, alsa_close): Likewise.
8245 * termcap.c (tgetent): Likewise.
8246 * xfns.c (x_default_font_parameter): Likewise.
8247 * xsettings.c (read_and_apply_settings): Likewise.
8249 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8250 (overrun_check_free): Protoize.
8252 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8254 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8255 since callers should never pass a negative size.
8256 Change the signature to match that of plain 'read' and 'write'; see
8257 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8258 * lisp.h: Update prototypes of emacs_write and emacs_read.
8260 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8262 * xdisp.c (redisplay_window): Don't try to determine the character
8263 position of the scroll margin if the window start point w->startp
8264 is outside the buffer's accessible region. (Bug#8468)
8266 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8268 Fix write-region and its subroutines for buffers > 2GB.
8269 * fileio.c (a_write, e_write): Modify declaration of arguments and
8270 local variables to support buffers larger than 2GB.
8271 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8273 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8274 argument, local variables, and return value.
8276 * lisp.h: Update prototypes of emacs_write and emacs_read.
8278 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8280 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8282 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8284 Fix more problems found by GCC 4.6.0's static checks.
8286 * xdisp.c (vmessage): Use a better test for character truncation.
8288 * charset.c (load_charset_map): <, not <=, for optimization,
8289 and to avoid potential problems with integer overflow.
8290 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8291 * casetab.c (set_identity, shuffle): Likewise.
8292 * editfns.c (Fformat): Likewise.
8293 * syntax.c (skip_chars): Likewise.
8295 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8296 This also lets GCC 4.6.0 generate slightly better loop code.
8298 * callint.c (Fcall_interactively): <, not <=, for optimization.
8299 (Fcall_interactively): Count the number of arguments produced,
8300 not the number of arguments given. This is simpler and lets GCC
8301 4.6.0 generate slightly better code.
8303 * ftfont.c: Distingish more carefully between FcChar8 and char.
8304 The previous code passed unsigned char * to a functions like
8305 strlen and xstrcasecmp that expect char *, which does not
8306 conform to the C standard.
8307 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8308 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8309 char * when the C standard requires it.
8311 * keyboard.c (read_char): Remove unused var.
8313 * eval.c: Port to Windows vsnprintf (Bug#8435).
8315 (SIZE_MAX): Define if the headers do not.
8316 (verror): Do not give up if vsnprintf returns a negative count.
8317 Instead, grow the buffer. This ports to Windows vsnprintf, which
8318 does not conform to C99. Problem reported by Eli Zaretskii.
8319 Also, simplify the allocation scheme, by avoiding the need for
8320 calling realloc, and removing the ALLOCATED variable.
8322 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8324 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8325 But keep the doprint source code for now, as we might revamp it
8326 and use it again (Bug#8435).
8327 * lisp.h (doprnt): Remove.
8328 * Makefile.in (base_obj): Remove doprnt.o.
8329 * deps.mk (doprnt.o): Remove.
8331 error: Print 32- and 64-bit integers portably (Bug#8435).
8332 Without this change, on typical 64-bit hosts error ("...%d...", N)
8333 was used to print both 32- and 64-bit integers N, which relied on
8335 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8336 * lisp.h (error, verror): Mark as printf-like functions.
8337 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8338 Report overflow in size calculations when allocating printf buffer.
8339 Do not truncate output string at its first null byte.
8340 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8341 Truncate the output at a character boundary, since vsnprintf does not
8343 * charset.c (check_iso_charset_parameter): Convert internal
8344 character to string before calling 'error', since %c now has the
8346 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8347 overflow when computing char to be passed to 'error'. Do not
8348 pass Lisp_Object to 'error'; pass the integer instead.
8349 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8350 formatted with plain %d.
8352 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8354 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8356 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8358 * xterm.c (x_catch_errors): Remove duplicate declaration.
8360 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8362 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8364 2011-04-10 Jim Meyering <meyering@redhat.com>
8366 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8367 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8368 return ssize_t not "int", and use size_t as the buffer length.
8369 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8370 * gnutls.h: Update declarations.
8371 * process.c (read_process_output): Use ssize_t, to match.
8372 (send_process): Likewise.
8374 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8376 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8378 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8380 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8381 Use unsigned char, to match FcChar8 type definition.
8383 * xterm.c (handle_one_xevent):
8384 * xmenu.c (create_and_show_popup_menu):
8385 * xselect.c (x_decline_selection_request)
8386 (x_reply_selection_request): Avoid type-punned deref of X events.
8388 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8390 Fix some uses of `int' instead of EMACS_INT.
8391 * search.c (string_match_1, fast_string_match)
8392 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8393 (scan_buffer, find_next_newline_no_quit)
8394 (find_before_next_newline, search_command, Freplace_match)
8395 (Fmatch_data): Make some `int' variables be EMACS_INT.
8397 * xdisp.c (display_count_lines): 3rd argument and return value now
8398 EMACS_INT. All callers changed.
8399 (pint2hrstr): Last argument is now EMACS_INT.
8401 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8402 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8403 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8404 (decode_coding_utf_16, decode_coding_emacs_mule)
8405 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8406 (decode_coding_ccl, decode_coding_charset)
8407 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8408 (decode_coding_iso_2022, decode_coding_emacs_mule)
8409 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8410 <char_offset, last_offset>: Declare EMACS_INT.
8411 (encode_coding_utf_8, encode_coding_utf_16)
8412 (encode_coding_emacs_mule, encode_invocation_designation)
8413 (encode_designation_at_bol, encode_coding_iso_2022)
8414 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8415 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8417 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8418 (encode_invocation_designation): Last argument P_NCHARS is now
8420 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8421 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8423 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8426 * ccl.c (Fccl_execute_on_string): Declare some variables
8429 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8431 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8433 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8435 * process.c (Fformat_network_address): Doc fix.
8437 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8439 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8441 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8443 * keyboard.c (read_char): Call Lisp function help-form-show,
8444 instead of using internal_with_output_to_temp_buffer.
8445 (Qhelp_form_show): New var.
8446 (syms_of_keyboard): Use DEFSYM macro.
8448 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8450 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8452 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8454 * process.c (Flist_processes): Remove to Lisp.
8455 (list_processes_1): Delete.
8457 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8459 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8461 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8463 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8465 Fix more problems found by GCC 4.6.0's static checks.
8467 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8469 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8471 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8473 * xdisp.c (vmessage): Mark as a printf-like function.
8475 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8477 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8479 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8480 printf-like functions.
8481 (tiff_load): Add casts to remove these marks before passing them
8482 to system-supplied API.
8484 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8486 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8487 This avoids several warnings with gcc -Wstrict-overflow.
8488 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8489 directly, rather than having caller test rule sign. This avoids
8490 some unnecessary tests.
8491 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8492 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8493 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8495 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8496 (xfont_open): Avoid unnecessary tests.
8498 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8500 * composite.h, composite.c (composition_gstring_put_cache):
8501 Use EMACS_INT, not int, for length.
8503 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8504 breaking out part of COMPOSITION_DECODE_RULE.
8505 (COMPOSITION_DECODE_RULE): Use it.
8506 * composite.c (get_composition_id): Remove unused local vars,
8507 by using the new macro.
8509 * textprop.c (set_text_properties_1): Change while to do-while,
8510 since the condition is always true at first.
8512 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8513 (interval_deletion_adjustment): Return unsigned value.
8516 * process.c (list_processes_1, create_pty, read_process_output):
8517 (exec_sentinel): Remove vars that were set but not used.
8518 (create_pty): Remove unnecessary "volatile"s.
8519 (Fnetwork_interface_info): Avoid possibility of int overflow.
8520 (read_process_output): Do adaptive read buffering even if carryover.
8521 (read_process_output): Simplify nbytes computation if buffered.
8523 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8525 * syntax.c (scan_words): Remove var that was set but not used.
8526 (update_syntax_table): Use unsigned instead of int.
8528 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8529 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8530 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8532 * print.c (print_error_message): Avoid int overflow.
8534 * font.c (font_list_entities): Redo for clarity,
8535 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8537 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8538 (font_score): Avoid potential overflow in diff calculation.
8540 * fns.c (substring_both): Remove var that is set but not used.
8541 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8543 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8545 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8546 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8547 can always succeed if overflow has undefined behavior.
8549 * search.c (boyer_moore, wordify): Remove vars set but not used.
8550 (wordify): Omit three unnecessary tests.
8552 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8553 All callers changed. This avoids the need for an unused var.
8555 * casefiddle.c (casify_region): Remove var that is set but not used.
8557 * dired.c (file_name_completion): Remove var that is set but not used.
8559 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8561 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8562 (Finsert_file_contents): Remove unnecessary code checking fd.
8564 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8565 Check for integer overflow on size calculations.
8567 * buffer.c (Fprevious_overlay_change): Remove var that is set
8570 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8571 Remove vars that are set but not used.
8572 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8573 (timer_check_2): Mark vars as initialized.
8575 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8577 * image.c (lookup_image): Remove var that is set but not used.
8578 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8580 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8581 that are set but not used.
8583 * xfns.c (make_invisible_cursor): Don't return garbage
8584 if XCreateBitmapFromData fails (Bug#8410).
8586 * xselect.c (x_get_local_selection, x_handle_property_notify):
8587 Remove vars that are set but not used.
8589 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8590 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8592 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8593 Remove var that is set but not used.
8594 (scroll_bar_windows_size): Now size_t, not int.
8595 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8598 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8599 (map_tty_color) [!defined MSDOS]: Likewise.
8601 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8603 * coding.c: Remove vars that are set but not used.
8604 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8605 All callers changed.
8606 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8607 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8608 (decode_coding_charset): Remove vars that are set but not used.
8610 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8611 that is set but not used.
8613 * print.c (print_object): Remove var that is set but not used.
8615 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8616 The gnulib version avoids calling malloc in the usual case,
8617 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8618 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8619 * filelock.c (current_lock_owner): Likewise.
8620 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8621 * sysdep.c: Include allocator.h, careadlinkat.h.
8622 (emacs_no_realloc_allocator): New static constant.
8623 (emacs_readlink): New function.
8624 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8625 ../lib/careadlinkat.h.
8627 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8629 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8630 first non-nil return value).
8632 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8634 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8635 if not defined (Bug#8403).
8637 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8639 * xdisp.c (display_count_lines): Remove parameter `start',
8640 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8641 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8642 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8643 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8644 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8645 and thereabouts. All callers changed.
8646 (get_per_char_metric): Remove parameter `f', unused since
8647 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8649 2011-04-02 Jim Meyering <meyering@redhat.com>
8651 do not dereference NULL upon failed strdup
8652 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8653 (ns_get_family): Likewise.
8655 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8657 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8659 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8661 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8664 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8666 Add lexical binding.
8668 * window.c (Ftemp_output_buffer_show): New fun.
8669 (Fsave_window_excursion):
8670 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8672 * lread.c (lisp_file_lexically_bound_p): New function.
8673 (Fload): Bind Qlexical_binding.
8674 (readevalloop): Remove `evalfun' arg.
8675 Bind Qinternal_interpreter_environment.
8676 (Feval_buffer): Bind Qlexical_binding.
8677 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8679 (syms_of_lread): Declare `lexical-binding'.
8681 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8683 * keyboard.c (eval_dyn): New fun.
8684 (menu_item_eval_property): Use it.
8686 * image.c (parse_image_spec): Use Ffunctionp.
8688 * fns.c (concat, mapcar1): Accept byte-code-functions.
8690 * eval.c (Fsetq): Handle lexical vars.
8691 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8692 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8693 (FletX, Flet): Obey lexical binding.
8694 (Fcommandp): Handle closures.
8695 (Feval): New `lexical' arg.
8696 (eval_sub): New function extracted from Feval. Use it almost
8697 everywhere where Feval was used. Look up vars in lexical env.
8699 (Ffunctionp): Move from subr.el.
8700 (Ffuncall): Handle closures.
8701 (apply_lambda): Remove `eval_flags'.
8702 (funcall_lambda): Handle closures and new byte-code-functions.
8703 (Fspecial_variable_p): New function.
8704 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8705 but without exporting it to Lisp.
8707 * doc.c (Fdocumentation, store_function_docstring):
8708 * data.c (Finteractive_form): Handle closures.
8710 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8713 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8715 (exec_byte_code): New function extracted from Fbyte_code to handle new
8716 calling convention for byte-code-functions. Add new byte-codes.
8718 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8720 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8722 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8724 * xdisp.c (redisplay_internal): Fix prototype.
8726 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8728 * xdisp.c (SCROLL_LIMIT): New macro.
8729 (try_scrolling): Use it when setting scroll_limit.
8730 Limit scrolling to 100 screen lines.
8731 (redisplay_window): Even when falling back on "recentering",
8732 position point in the window according to scroll-conservatively,
8733 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8735 (try_scrolling): When point is above the window, allow searching
8736 as far as scroll_max, or one screenful, to compute vertical
8737 distance from PT to the scroll margin position. This prevents
8738 try_scrolling from unnecessarily failing when
8739 scroll-conservatively is set to a value slightly larger than the
8740 window height. Clean up the case of PT below the margin at bottom
8741 of window: scroll_max can no longer be INT_MAX. When aggressive
8742 scrolling is in use, don't let point enter the opposite scroll
8743 margin as result of the scroll.
8744 (syms_of_xdisp) <scroll-conservatively>: Document the
8745 threshold of 100 lines for never-recentering scrolling.
8747 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8749 * dispextern.h (move_it_by_lines):
8750 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8751 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8752 (message_log_check_duplicate): Remove parameters `prev_bol' and
8753 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8754 (redisplay_internal): Remove parameter `preserve_echo_area',
8755 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8757 * indent.c (Fvertical_motion):
8758 * window.c (window_scroll_pixel_based, Frecenter):
8759 Don't pass `need_y_p' to `move_it_by_lines'.
8761 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8763 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8764 steal a few bits to be more compact.
8765 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8766 Remove unneeded casts.
8768 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8770 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8772 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8773 binding" message (bug#7967).
8775 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8777 Fix more problems found by GCC 4.6.0's static checks.
8779 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8780 Remove unused local var.
8782 * editfns.c (Fmessage_box): Remove unused local var.
8784 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8785 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8786 Omit unused local vars.
8787 * window.c (shrink_windows): Omit unused local var.
8788 * menu.c (digest_single_submenu): Omit unused local var.
8789 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8790 Omit unused local var.
8792 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8793 Don't assume string length fits in int.
8794 (keyremap_step, read_key_sequence): Use size_t for sizes.
8795 (read_key_sequence): Don't check last_real_key_start redundantly.
8797 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8798 instead of alloca (Bug#8344).
8800 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8801 (Fbacktrace_frame): Don't assume nframes fits in int.
8803 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8805 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8808 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8810 * cm.c (calccost): Turn while-do into do-while, for clarity.
8812 * keyboard.c (syms_of_keyboard): Use the same style as later
8813 in this function when indexing through an array. This also
8814 works around GCC bug 48267.
8816 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8818 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8820 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8821 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8823 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8824 This avoids undefined behavior on integer overflow, and is a bit
8825 more convenient anyway since it is compared to a size_t variable.
8827 Variadic C functions now count arguments with size_t, not int.
8828 This avoids an unnecessary limitation on 64-bit machines, which
8829 caused (substring ...) to crash on large vectors (Bug#8344).
8830 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8831 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8832 All variadic functions and their callers changed accordingly.
8833 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8834 * data.c (arith_driver, float_arith_driver): Likewise.
8835 * editfns.c (general_insert_function): Likewise.
8836 * eval.c (struct backtrace.nargs, interactive_p)
8837 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8838 (funcall_lambda, mark_backtrace): Likewise.
8839 * fns.c (concat): Likewise.
8840 * frame.c (x_set_frame_parameters): Likewise.
8841 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8842 0 if not found, not -1. All callers changed.
8844 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8845 (stack_copy_size): Now size_t, not int.
8846 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8848 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8850 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8851 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8852 All callers changed.
8854 * lisp.h (multibyte_char_to_unibyte):
8855 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8856 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8857 * character.h (CHAR_TO_BYTE8):
8858 * cmds.c (internal_self_insert):
8859 * editfns.c (general_insert_function):
8860 * keymap.c (push_key_description):
8861 * search.c (Freplace_match):
8862 * xdisp.c (message_dolog, set_message_1): All callers changed.
8864 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8866 * keyboard.c (safe_run_hook_funcall): New function.
8867 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8868 don't set the hook to nil, but remove the offending function instead.
8869 (Qcommand_hook_internal): Remove, unused.
8870 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8871 Vcommand_hook_internal.
8873 * eval.c (enum run_hooks_condition): Remove.
8874 (funcall_nil, funcall_not): New functions.
8875 (run_hook_with_args): Call each function through a `funcall' argument.
8876 Remove `cond' argument, now redundant.
8877 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8878 (Frun_hook_with_args_until_failure): Adjust accordingly.
8879 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8881 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8883 * dispextern.h (string_buffer_position): Remove declaration.
8885 * print.c (strout): Remove parameter `multibyte', unused since
8886 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8888 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8889 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8890 All callers changed.
8892 * w32.c (_wsa_errlist): Use braces for struct initializers.
8894 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8895 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8896 All callers changed.
8897 (string_buffer_position): Likewise. Also, make static (it's never
8898 used outside xdisp.c).
8899 (cursor_row_p): Remove parameter `w', unused since
8900 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8901 (decode_mode_spec): Remove parameter `precision', introduced during
8902 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8903 All callers changed.
8905 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8907 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8909 2011-03-27 Anders Lindgren <andlind@gmail.com>
8911 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8912 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8913 (ns_update_auto_hide_menu_bar): New functions.
8914 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8915 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8916 ns_constrain_all_frames.
8917 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8918 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8920 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8922 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8924 2011-03-27 Glenn Morris <rgm@gnu.org>
8926 * syssignal.h: Replace RETSIGTYPE with void.
8927 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8928 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8929 Replace SIGTYPE with void everywhere.
8930 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8931 * s/template.h (SIGTYPE): Remove commented out definition.
8933 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8935 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8936 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8938 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8940 * w32.c (read_unc_volume): Use parameter `henum', instead of
8941 global variable `wget_enum_handle'.
8943 * keymap.c (describe_vector): Remove parameters `indices' and
8944 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8945 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8947 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8949 * keyboard.c (timer_check): Remove parameter `do_it_now',
8950 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8951 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8952 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8954 * keyboard.c (read_char):
8955 * w32menu.c (w32_menu_display_help):
8956 * xmenu.c (show_help_event, menu_help_callback):
8957 Adjust calls to `show_help_echo'.
8959 * gtkutil.c (xg_maybe_add_timer):
8960 * keyboard.c (readable_events):
8961 * process.c (wait_reading_process_output):
8962 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8964 * insdel.c (adjust_markers_gap_motion):
8965 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8966 (gap_left, gap_right): Don't call it.
8968 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8970 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8971 incurred during fontification.
8973 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8975 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8976 (DEFVAR_PER_BUFFER): Don't pass it.
8978 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8979 (scrolling_window): Don't pass it.
8981 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8983 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8985 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8987 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8988 of variables specific to SELinux and computation of `encoded_absname'.
8990 * image.c (XPutPixel): Remove unused variable `height'.
8992 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8994 * unexw32.c (get_section_info): Remove unused variable `section'.
8996 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8997 (system_process_attributes): Remove unused variable `sess'.
8998 (sys_read): Remove unused variable `err'.
9000 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9001 (w32_wnd_proc): Remove unused variable `isdead'.
9002 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9003 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9004 (x_create_tip_frame): Remove unused variable `tem'.
9006 * w32inevt.c (w32_console_read_socket):
9007 Remove unused variable `no_events'.
9009 * w32term.c (x_draw_composite_glyph_string_foreground):
9010 Remove unused variable `width'.
9012 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9014 * w32term.c (x_set_glyph_string_clipping):
9015 Don't pass uninitialized region to CombineRgn.
9017 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9019 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9020 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9021 (Fx_close_connection): Remove unused variable `i'.
9023 * w32font.c (w32font_draw): Return number of glyphs.
9024 (w32font_open_internal): Remove unused variable `i'.
9025 (w32font_driver): Add missing initializer.
9027 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9028 (fill_in_menu): Remove unused variable `items_added'.
9030 * w32term.c (last_mouse_press_frame): Remove static global variable.
9031 (w32_clip_to_row): Remove unused variable `f'.
9032 (x_delete_terminal): Remove unused variable `i'.
9034 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9035 (NOTHING): Remove unused static global variable.
9036 (uniscribe_check_otf): Remove unused variable `table'.
9037 (uniscribe_font_driver): Add missing initializers.
9039 2011-03-23 Julien Danjou <julien@danjou.info>
9041 * term.c (Fsuspend_tty, Fresume_tty):
9042 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9043 * window.c (temp_output_buffer_show):
9044 * insdel.c (signal_before_change):
9045 * frame.c (Fhandle_switch_frame):
9046 * fileio.c (Fdo_auto_save):
9047 * emacs.c (Fkill_emacs):
9048 * editfns.c (save_excursion_restore):
9049 * cmds.c (internal_self_insert):
9050 * callint.c (Fcall_interactively):
9051 * buffer.c (Fkill_all_local_variables):
9052 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9054 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9055 unconditionally since it does the check itself.
9057 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9059 Fix more problems found by GCC 4.5.2's static checks.
9061 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9062 the first time through the loop, since we know p0 < p1 then.
9063 This also avoids a gcc -Wstrict-overflow warning.
9065 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9066 leading to a memory leak, possible in functions like
9067 load_charset_map_from_file that can allocate an unbounded number
9068 of objects (Bug#8318).
9070 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9071 that could (at least in theory) be that large.
9073 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9074 This is less likely to overflow, and avoids undefined behavior if
9075 overflow does occur. All callers changed. Use strtoul to scan
9076 for the unsigned long integer.
9077 (pint2hrstr): Simplify and tune code slightly.
9078 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9080 * scroll.c (do_scrolling): Work around GCC bug 48228.
9081 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9083 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9084 This also avoids a warning with gcc -Wstrict-overflow.
9085 (validate_x_resource_name): Simplify count usage.
9086 This also avoids a warning with gcc -Wstrict-overflow.
9088 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9091 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9093 * process.c (Fmake_network_process): Use socklen_t, not int,
9094 where POSIX says socklen_t is required in portable programs.
9095 This fixes a porting bug on hosts like 64-bit HP-UX, where
9096 socklen_t is wider than int (Bug#8277).
9097 (Fmake_network_process, server_accept_connection):
9098 (wait_reading_process_output, read_process_output):
9101 * process.c: Rename or move locals to avoid shadowing.
9102 (list_processes_1, Fmake_network_process):
9103 (read_process_output_error_handler, exec_sentinel_error_handler):
9104 Rename or move locals.
9105 (Fmake_network_process): Define label "retry_connect" only if needed.
9106 (Fnetwork_interface_info): Fix pointer signedness.
9107 (process_send_signal): Add cast to avoid pointer signedness problem.
9108 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9109 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9111 Make tparam.h and terminfo.c consistent.
9112 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9113 Include tparam.h instead, since it declares them.
9114 * cm.h (PC): Remove extern decl; tparam.h now does this.
9115 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9116 * terminfo.c: Include tparam.h, to check interfaces.
9117 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9118 (tparam): Adjust signature to match interface in tparam.h;
9119 this removes some undefined behavior. Check that outstring and len
9120 are zero, which they always are with Emacs.
9121 * tparam.h (PC, BC, UP): New extern decls.
9123 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9124 (xftfont_open): Rename locals to avoid shadowing.
9126 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9127 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9128 (OTF_TAG_SYM): Omit macro if not needed.
9129 (ftfont_list): Remove unused local.
9130 (get_adstyle_property, ftfont_pattern_entity):
9131 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9132 Rename locals to avoid shadowing.
9134 * xfont.c (xfont_list_family): Mark var as initialized.
9136 * xml.c (make_dom): Now static.
9138 * composite.c (composition_compute_stop_pos): Rename local to
9140 (composition_reseat_it): Remove unused locals.
9141 (find_automatic_composition, composition_adjust_point): Likewise.
9142 (composition_update_it): Mark var as initialized.
9143 (find_automatic_composition): Mark vars as initialized,
9144 with a FIXME (Bug#8290).
9146 character.h: Rename locals to avoid shadowing.
9147 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9148 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9149 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9150 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9153 * textprop.c (property_change_between_p): Remove; unused.
9155 * intervals.c (interval_start_pos): Now static.
9157 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9159 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9160 Rename locals to avoid shadowing.
9162 * sound.c (wav_play, au_play, Fplay_sound_internal):
9163 Fix pointer signedness.
9164 (alsa_choose_format): Remove unused local var.
9165 (wav_play): Initialize a variable to 0, to prevent undefined
9166 behavior (Bug#8278).
9168 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9170 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9172 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9173 clobbering (Bug#8298).
9174 * sysdep.c (sys_subshell): Likewise.
9175 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9177 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9178 This should get cleaned up, so that child_setup has the
9179 same signature on all platforms.
9181 * callproc.c (call_process_cleanup): Now static.
9182 (relocate_fd): Rename locals to avoid shadowing.
9184 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9186 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9187 not to be necessary, and produces flickering.
9189 2011-03-20 Glenn Morris <rgm@gnu.org>
9191 * config.in: Remove file.
9193 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9195 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9196 are now in src/globals.h.
9197 (syms_of_minibuf): Remove spurious & from previous change.
9199 2011-03-20 Leo Liu <sdl.web@gmail.com>
9201 * minibuf.c (completing-read-function): New variable.
9202 (completing-read-default): Rename from completing-read.
9203 (completing-read): Call completing-read-function.
9205 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9207 * xfaces.c (Fx_load_color_file):
9208 Read color file from absolute filename (bug#8250).
9210 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9212 * makefile.w32-in: Update dependencies.
9214 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9216 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9218 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9220 Fix more problems found by GCC 4.5.2's static checks.
9222 * process.c (make_serial_process_unwind, send_process_trap):
9223 (sigchld_handler): Now static.
9225 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9226 That way, the code declares only the vars that it needs.
9227 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9228 * s/cygwin.h (PTY_ITERATION): Likewise.
9229 * s/darwin.h (PTY_ITERATION): Likewise.
9230 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9232 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9233 * process.c (allocate_pty): Don't declare stb unless it's needed.
9235 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9236 (CONSTANTLIM): Remove; unused.
9237 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9238 Define only if needed.
9240 * unexelf.c (unexec): Name an expression,
9241 to avoid gcc -Wbad-function-cast warning.
9242 Use a different way to cause a compilation error if anyone uses
9243 n rather than nn, a way that does not involve shadowing.
9244 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9246 * deps.mk (unexalpha.o): Remove; unused.
9248 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9249 * unexec.h: New file.
9250 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9251 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9253 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9254 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9255 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9256 Change as necessary to match prototype in unexec.h.
9258 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9260 (back_comment, skip_chars): Mark vars as initialized.
9262 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9263 Rename locals to avoid shadowing.
9265 * lread.c (read1): Rewrite so as not to use empty "else".
9266 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9268 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9270 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9271 warning when compiling print.c.
9273 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9274 instead of using an uninitialized var.
9275 (font_sort_entities): Mark var as initialized.
9277 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9279 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9280 pointers to constants.
9281 (font_parse_fcname): Remove unused vars.
9282 (font_delete_unmatched): Now static.
9283 (font_get_spec): Remove; unused.
9284 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9285 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9286 Rename or move locals to avoid shadowing.
9288 * fns.c (require_nesting_list, require_unwind): Now static.
9289 (Ffillarray): Rename locals to avoid shadowing.
9291 * floatfns.c (domain_error2): Define only if needed.
9292 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9294 * alloc.c (mark_backtrace): Move decl from here ...
9295 * lisp.h: ... to here, so that it can be checked.
9297 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9298 (Fdefvar): Rewrite so as not to use empty "else".
9299 (lisp_indirect_variable): Name an expression,
9300 to avoid gcc -Wbad-function-cast warning.
9301 (Fdefvar): Rename locals to avoid shadowing.
9303 * callint.c (quotify_arg, quotify_args): Now static.
9304 (Fcall_interactively): Rename locals to avoid shadowing.
9305 Use const pointer when appropriate.
9307 * lisp.h (get_system_name, get_operating_system_release):
9308 Move decls here, to check interfaces.
9309 * process.c (get_operating_system_release): Move decl to lisp.h.
9310 * xrdb.c (get_system_name): Likewise.
9311 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9312 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9313 some of which prompt warnings from gcc -Wbad-function-cast.
9314 (Fformat_time_string, Fencode_time, Finsert_char):
9315 (Ftranslate_region_internal, Fformat):
9316 Rename or remove local vars to avoid shadowing.
9317 (Ftranslate_region_internal): Mark var as initialized.
9319 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9322 * lisp.h (eassert): Check that the argument compiles, even if
9323 ENABLE_CHECKING is not defined.
9325 * data.c (Findirect_variable): Name an expression, to avoid
9326 gcc -Wbad-function-cast warning.
9327 (default_value, arithcompare, arith_driver, arith_error): Now static.
9328 (store_symval_forwarding): Rename local to avoid shadowing.
9329 (Fmake_variable_buffer_local, Fmake_local_variable):
9330 Mark variables as initialized.
9331 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9333 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9334 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9335 Rename locals to avoid shadowing.
9336 (mark_stack): Move local variables into the #ifdef region where
9338 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9339 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9341 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9342 (GC_STRING_CHARS): Remove; not used.
9343 (Fmemory_limit): Cast sbrk's returned value to char *.
9345 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9346 avoids undefined behavior in theory.
9348 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9350 Use functions, not macros, for up- and down-casing (Bug#8254).
9351 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9352 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9353 to use the following functions instead of these macros.
9354 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9355 EMACS_INT, since callers assume the returned value fits in int.
9356 (upcase1): Likewise, for UPCASE_TABLE.
9357 (uppercasep, lowercasep, upcase): New static inline functions.
9358 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9359 the race-condition problem in the old DOWNCASE.
9361 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9362 Rename locals to avoid shadowing.
9363 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9364 (regex_compile, re_search_2, re_match_2_internal):
9365 Remove unused local vars.
9366 (FREE_VAR): Rewrite so as not to use empty "else",
9367 which gcc can warn about.
9368 (regex_compile, re_match_2_internal): Mark locals as initialized.
9369 (RETALLOC_IF): Define only if needed.
9370 (WORDCHAR_P): Likewise. This one is never needed, but is used
9371 only in a comment talking about a compiler bug, so put inside
9372 the #if 0 of that comment.
9373 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9374 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9377 * search.c (boyer_moore): Rename locals to avoid shadowing.
9378 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9379 (PREV_CHAR_BOUNDARY): Likewise.
9381 * search.c (simple_search): Remove unused var.
9383 * dired.c (compile_pattern): Move decl from here ...
9384 * lisp.h: ... to here, so that it can be checked.
9385 (struct re_registers): New forward decl.
9387 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9389 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9391 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9392 Rename locals to avoid shadowing.
9393 (Fvertical_motion): Mark locals as initialized.
9395 * casefiddle.c (casify_object, casify_region): Now static.
9396 (casify_region): Mark local as initialized.
9398 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9400 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9401 New macros, so that the caller can use some names other than
9402 gcpro1, gcpro2, etc.
9403 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9405 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9406 argument, for consistency with GCPRO2_VAR, etc: it is now the
9407 prefix of the variable, not the variable itself. All uses
9409 * dired.c (directory_files_internal, file_name_completion):
9410 Rename locals to avoid shadowing.
9412 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9413 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9414 dired.c's scmp function, had undefined behavior.
9415 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9416 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9417 * buffer.h: ... to here, because these macros use current_buffer,
9418 and the new implementation with inline functions needs to have
9419 current_buffer in scope now, rather than later when the macros
9421 (downcase, upcase1): New static inline functions.
9422 (DOWNCASE, UPCASE1): Reimplement using these functions.
9423 This avoids undefined behavior in expressions like
9424 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9425 from race conditions in accessing the global variables
9426 case_temp1 and case_temp2.
9427 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9428 * lisp.h (case_temp1, case_temp2): Remove their decls.
9429 * character.h (ASCII_CHAR_P): Move from here ...
9430 * lisp.h: ... to here, so that the inline functions mentioned
9433 * dired.c (directory_files_internal_unwind): Now static.
9435 * fileio.c (file_name_as_directory, directory_file_name):
9436 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9438 (file_name_as_directory): Use const pointers when appropriate.
9439 (Fexpand_file_name): Likewise. In particular, newdir might
9440 point at constant storage, so make it a const pointer.
9441 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9442 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9444 (Fset_file_times, Finsert_file_contents, auto_save_error):
9445 Rename locals to avoid shadowing.
9447 * minibuf.c (choose_minibuf_frame_1): Now static.
9448 (Ftry_completion, Fall_completions): Rename or remove locals
9451 * marker.c (bytepos_to_charpos): Remove; unused.
9453 * lisp.h (verify_bytepos, count_markers): New decls,
9454 so that gcc does not warn that these functions aren't declared.
9456 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9457 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9458 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9459 (copy_text): Remove unused local var.
9461 * filelock.c (within_one_second): Now static.
9462 (lock_file_1): Rename local to avoid shadowing.
9464 * buffer.c (fix_overlays_before): Mark locals as initialized.
9465 (fix_start_end_in_overlays): Likewise. This function should be
9466 simplified by using pointers-to-pointers, but that's a different
9468 (switch_to_buffer_1): Now static.
9469 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9470 (report_overlay_modification): Rename locals to avoid shadowing.
9472 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9473 Fix pointer signedness issue.
9474 (sys_subshell): Mark local as volatile if checking for lint,
9475 to suppress a gcc -Wclobbered warning that does not seem to be right.
9476 (MAXPATHLEN): Define only if needed.
9478 * process.c (serial_open, serial_configure): Move decls from here ...
9479 * systty.h: ... to here, so that they can be checked.
9481 * fns.c (get_random, seed_random): Move extern decls from here ...
9482 * lisp.h: ... to here, so that they can be checked.
9484 * sysdep.c (reset_io): Now static.
9485 (wait_for_termination_signal): Remove; unused.
9487 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9488 (copy_keymap_item, append_key, push_text_char_description):
9490 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9491 (DENSE_TABLE_SIZE): Remove; unused.
9492 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9493 (describe_map_tree):
9494 Rename locals to avoid shadowing.
9496 * keyboard.c: Declare functions static if they are not used elsewhere.
9497 (echo_char, echo_dash, cmd_error, top_level_2):
9498 (poll_for_input, handle_async_input): Now static.
9499 (read_char, kbd_buffer_get_event, make_lispy_position):
9500 (make_lispy_event, make_lispy_movement, apply_modifiers):
9501 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9502 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9503 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9504 (read_key_sequence, read_char): Mark locals as initialized.
9505 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9507 * keyboard.h (make_ctrl_char): New decl.
9508 (mark_kboards): Move decl here ...
9509 * alloc.c (mark_kboards): ... from here.
9511 * lisp.h (force_auto_save_soon): New decl.
9513 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9514 (DEFINE_DUMMY_FUNCTION): New macro.
9515 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9517 (main): Add casts to avoid warnings
9518 if GCC considers string literals to be constants.
9520 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9522 * dbusbind.c: Pointer signedness fixes.
9523 (xd_signature, xd_append_arg, xd_initialize):
9524 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9525 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9526 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9527 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9529 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9530 if GCC considers string literals to be constants.
9531 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9533 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9535 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9536 (print_preprocess, print_object): New macro to fix last change.
9538 * print.c (print_preprocess): Don't forget font objects.
9540 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9542 * emacs.c (USAGE3): Doc fixes.
9544 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9546 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9549 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9551 * lisp.h (VWindow_system, Qfile_name_history):
9552 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9553 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9554 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9556 * w32select.c: Don't #include "keyboard.h".
9557 (run_protected): Add extern declaration for waiting_for_input.
9559 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9560 * w32console.c (detect_input_pending, read_input_pending)
9561 (encode_terminal_code):
9562 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9563 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9564 (w32_system_caret_y, Qfile_name_history):
9565 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9566 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9567 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9568 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9569 * w32proc.c (Qlocal, report_file_error):
9570 * w32term.c (Vwindow_system, updating_frame):
9571 * w32uniscribe.c (initialized, uniscribe_font_driver):
9572 Remove unneeded extern declarations.
9574 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9576 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9578 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9580 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9581 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9582 These macros can no longer be used for assignment.
9584 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9585 Assign struct members directly, instead of using BUF_BEGV etc.
9586 (record_buffer_markers, fetch_buffer_markers): New functions for
9587 recording and fetching special buffer markers.
9588 (set_buffer_internal_1, set_buffer_temp): Use them.
9590 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9592 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9594 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9595 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9597 * xdisp.c (hscroll_window_tree):
9598 (reconsider_clip_changes): Use PT instead of BUF_PT.
9600 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9602 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9603 $(EMACS_ROOT)/lib/intprops.h.
9605 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9607 Fix more problems found by GCC 4.5.2's static checks.
9609 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9610 to unsigned char * to avoid compiler diagnostic.
9611 (xg_free_frame_widgets): Make it clear that a local variable is
9612 needed only if USE_GTK_TOOLTIP.
9613 (gdk_window_get_screen): Make it clear that this macro is needed
9614 only if USE_GTK_TOOLTIP.
9615 (int_gtk_range_get_value): New function, which avoids a diagnostic
9616 from gcc -Wbad-function-cast.
9617 (xg_set_toolkit_scroll_bar_thumb): Use it.
9618 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9619 diagnostic from gcc -Wbad-function-cast.
9620 (get_utf8_string, xg_get_file_with_chooser):
9621 Rename locals to avoid shadowing.
9622 (create_dialog): Move locals to avoid shadowing.
9624 * xgselect.c (xg_select): Remove unused var.
9626 * image.c (four_corners_best): Mark locals as initialized.
9627 (gif_load): Initialize transparent_p to zero (Bug#8238).
9628 Mark another local as initialized.
9629 (my_png_error, my_error_exit): Mark with NO_RETURN.
9631 * image.c (clear_image_cache): Now static.
9632 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9633 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9634 (x_edge_detection): Remove unnecessary cast that
9635 gcc -Wbad-function-cast diagnoses.
9636 (gif_load): Fix pointer signedness.
9637 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9638 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9640 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9642 Improve quality of tests for time stamp overflow.
9643 For example, without this patch (encode-time 0 0 0 1 1
9644 1152921504606846976) returns the obviously-bogus value (-948597
9645 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9646 reports time overflow. See
9647 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9648 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9649 * editfns.c: Include limits.h and intprops.h.
9650 (TIME_T_MIN, TIME_T_MAX): New macros.
9651 (time_overflow): Move earlier, to before first use.
9652 (hi_time, lo_time): New functions, for an accurate test for
9654 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9655 (Fget_internal_run_time): Don't assume time_t fits in int.
9656 (make_time): Use list2 instead of Fcons twice.
9657 (Fdecode_time): More accurate test for out-of-range times.
9658 (check_tm_member): New function.
9659 (Fencode_time): Use it, to test for out-of-range times.
9660 (lisp_time_argument): Don't rely on undefined left-shift and
9661 right-shift behavior when checking for time stamp overflow.
9663 * editfns.c (time_overflow): New function, refactoring common code.
9664 (Fformat_time_string, Fdecode_time, Fencode_time):
9665 (Fcurrent_time_string): Use it.
9667 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9668 * dired.c (make_time): Move to ...
9669 * editfns.c (make_time): ... here.
9670 * systime.h: Note the move.
9672 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9674 * fringe.c (update_window_fringes): Remove unused variables.
9676 * unexmacosx.c (copy_data_segment): Also copy __got section.
9679 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9681 * termcap.c [MSDOS]: Include "msdos.h".
9682 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9683 Constify `char *' arguments and their references according to
9684 prototypes in tparam.h.
9686 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9688 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9689 Adapt all references accordingly.
9691 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9693 2011-03-11 Tom Tromey <tromey@redhat.com>
9695 * buffer.c (syms_of_buffer): Remove obsolete comment.
9697 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9699 * termhooks.h (encode_terminal_code): Declare prototype.
9701 * msdos.c (encode_terminal_code): Don't declare prototype.
9703 * term.c (encode_terminal_code): Now external again, used by
9704 w32console.c and msdos.c.
9706 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9707 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9709 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9711 Fix some minor problems found by GCC 4.5.2's static checks.
9713 * fringe.c (update_window_fringes): Mark locals as initialized
9715 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9717 * alloc.c (mark_fringe_data): Move decl from here ...
9718 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9719 to check its interface.
9720 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9722 * fontset.c (free_realized_fontset): Now static.
9723 (Fset_fontset_font): Rename local to avoid shadowing.
9724 (fontset_font): Mark local as initialized.
9725 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9727 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9729 * xselect.c (x_disown_buffer_selections): Remove; not used.
9730 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9731 (x_own_selection, Fx_disown_selection_internal): Rename locals
9733 (x_handle_dnd_message): Remove local to avoid shadowing.
9735 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9736 so that the caller can use some name other than gcpro1.
9737 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9738 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9739 (Fx_backspace_delete_keys_p):
9740 Use them to avoid shadowing, and rename vars to avoid shadowing.
9741 (x_decode_color, x_set_name, x_window): Now static.
9742 (Fx_create_frame): Add braces to silence GCC warning.
9743 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9744 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9745 Remove unused locals.
9746 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9747 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9748 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9751 * xterm.h (x_mouse_leave): New decl.
9753 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9754 Remove unused functions.
9755 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9756 (x_calc_absolute_position): Now static.
9757 (XTread_socket): Don't define label "out" unless it's used.
9758 Don't declare local "event" unless it's used.
9759 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9760 unless they are used.
9761 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9762 (x_fatal_error_signal): Remove; not used.
9763 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9764 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9765 (x_error_catcher, x_connection_closed, x_error_handler):
9766 (x_error_quitter, xembed_send_message, x_iconify_frame):
9767 (my_log_handler): Rename locals to avoid shadowing.
9768 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9769 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9771 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9772 Rename or move locals to avoid shadowing.
9773 (tty_defined_color, merge_face_heights): Now static.
9774 (free_realized_faces_for_fontset): Remove; not used.
9775 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9776 does not deduce is never used uninitialized.
9777 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9778 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9780 * terminal.c (store_terminal_param): Now static.
9782 * xmenu.c (menu_highlight_callback): Now static.
9783 (set_frame_menubar): Remove unused local.
9784 (xmenu_show): Rename parameter to avoid shadowing.
9785 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9786 since they might point to immutable storage.
9787 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9788 since it's unused otherwise.
9790 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9791 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9792 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9793 avoids a gcc -Wuninitialized diagnostic.
9794 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9795 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9796 does not deduce are never used uninitialized.
9798 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9800 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9801 * window.c (window_loop, size_window):
9802 (run_window_configuration_change_hook, enlarge_window): Likewise.
9804 * window.c (display_buffer): Now static.
9805 (size_window): Mark variables that gcc -Wuninitialized
9806 does not deduce are never used uninitialized.
9807 * window.h (check_all_windows): New decl, to forestall
9808 gcc -Wmissing-prototypes diagnostic.
9809 * dispextern.h (bidi_dump_cached_states): Likewise.
9811 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9813 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9815 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9816 and to avoid gcc -Wuninitialized warning.
9817 (load_charset_map): Mark variables that gcc -Wuninitialized
9818 does not deduce are never used uninitialized.
9819 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9821 * coding.c (coding_set_source, coding_set_destination):
9822 Use "else { /* comment */ }" rather than "else /* comment */;"
9823 for clarity, and to avoid gcc -Wempty-body warning.
9824 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9825 a block, when the outer 'i' will do.
9826 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9827 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9828 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9829 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9830 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9831 Rename locals to avoid shadowing.
9832 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9833 * coding.c (emacs_mule_char, encode_invocation_designation):
9834 Now static, since they're not used elsewhere.
9835 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9836 (decode_coding_object, encode_coding_object, detect_coding_system):
9837 (decode_coding_emacs_mule): Mark variables that gcc
9838 -Wuninitialized does not deduce are never used uninitialized.
9839 (detect_coding_iso_2022): Initialize a local variable that might
9840 be used uninitialized. Leave a FIXME because it's not clear that
9841 this initialization is needed. (Bug#8211)
9842 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9843 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9844 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9845 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9846 Remove unused macros.
9848 * category.c (hash_get_category_set): Remove unused local var.
9849 (copy_category_table): Now static, since it's not used elsewhere.
9850 * character.c (string_count_byte8): Likewise.
9852 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9853 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9855 * chartab.c (copy_sub_char_table): Now static, since it's not used
9857 (sub_char_table_ref_and_range, char_table_ref_and_range):
9858 Rename locals to avoid shadowing.
9859 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9861 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9862 (BIDI_BOB): Remove unused macro.
9864 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9865 deduce are never used uninitialized.
9866 * term.c (encode_terminal_code): Likewise.
9868 * term.c (encode_terminal_code): Now static. Remove unused local.
9870 * tparam.h: New file.
9871 * term.c, tparam.h: Include it.
9872 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9873 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9874 Move these decls to tparam.h, and make them agree with what
9875 is actually in tparam.c. The previous trick of using incompatible
9876 decls in different modules does not conform to the C standard.
9877 All callers of tparam changed to use tparam's actual API.
9878 * tparam.c (tparam1, tparam, tgoto):
9879 Use const pointers where appropriate.
9881 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9882 * cm.h (struct cm): Likewise.
9883 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9884 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9885 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9886 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9887 (turn_on_face, init_tty): Likewise.
9888 * termchar.h (struct tty_display_info): Likewise.
9890 * term.c (term_mouse_position): Rename local to avoid shadowing.
9892 * alloc.c (mark_ttys): Move decl from here ...
9893 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9895 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9897 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9899 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9901 * search.c (compile_pattern_1): Remove argument regp, unused since
9902 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9903 (compile_pattern): Don't pass it.
9905 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9907 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9908 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9910 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9912 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9914 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9915 gdk_window_get_screen, gdk_window_get_geometry,
9916 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9917 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9918 (xg_get_pixbuf_from_pixmap): New function.
9919 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9920 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9921 Call xg_get_pixbuf_from_pixmap instead of
9922 gdk_pixbuf_get_from_drawable.
9923 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9924 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9925 (xg_check_special_colors): Use GtkStyleContext and its functions
9927 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9928 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9929 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9930 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9931 Call gtk_widget_get_preferred_size.
9932 (xg_frame_resized): gdk_window_get_geometry only takes 5
9934 (xg_win_to_widget, xg_event_is_for_menubar):
9935 Call gdk_x11_window_lookup_for_display.
9936 (xg_set_widget_bg): New function.
9937 (delete_cb): New function.
9938 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9939 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9940 (xg_set_background_color): Call xg_set_widget_bg.
9941 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9942 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9943 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9944 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9946 (update_frame_tool_bar): Call gtk_widget_hide.
9947 (xg_initialize): Use GDK_KEY_g.
9949 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9951 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9953 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9954 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9955 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9957 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9959 * w32xfns.c (select_palette): Check success of RealizePalette against
9960 GDI_ERROR, not zero.
9962 See ChangeLog.11 for earlier changes.
9968 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9970 This file is part of GNU Emacs.
9972 GNU Emacs is free software: you can redistribute it and/or modify
9973 it under the terms of the GNU General Public License as published by
9974 the Free Software Foundation, either version 3 of the License, or
9975 (at your option) any later version.
9977 GNU Emacs is distributed in the hope that it will be useful,
9978 but WITHOUT ANY WARRANTY; without even the implied warranty of
9979 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9980 GNU General Public License for more details.
9982 You should have received a copy of the GNU General Public License
9983 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.