1 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3 Use ptrdiff_t for hash table indexes.
4 * category.c (hash_get_category_set):
6 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7 * coding.c (coding_system_charset_list, detect_coding_system):
8 * coding.h (struct coding_system.id):
9 * composite.c (get_composition_id, gstring_lookup_cache):
10 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
11 * image.c (xpm_get_color_table_h):
12 * lisp.h (hash_lookup, hash_put):
13 * minibuf.c (Ftest_completion):
14 Use ptrdiff_t for hash table indexes, not int (which is too
15 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
16 32-bit --with-wide-int hosts).
18 * charset.c (Fdefine_charset_internal): Check for integer overflow.
19 Add a FIXME comment about memory leaks.
20 (syms_of_charset): Don't assume xmalloc returns.
22 Don't assume that stated character widths fit in int.
23 * character.c (Fchar_width, c_string_width, lisp_string_width):
24 * character.h (CHAR_WIDTH):
25 * indent.c (MULTIBYTE_BYTES_WIDTH):
26 Use sanitize_char_width to avoid undefined and/or bad behavior
27 with outlandish widths.
28 * character.h (sanitize_tab_width): Renamed from sanitize_width,
29 now that we have two such functions. All uses changed.
30 (sanitize_char_width): New inline function.
32 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
34 Don't assume that tab-width fits in int.
35 * character.h (sanitize_width): New inline function.
36 (SANE_TAB_WIDTH): New macro.
37 (ASCII_CHAR_WIDTH): Use it.
38 * indent.c (sane_tab_width): Remove. All uses replaced by
39 SANE_TAB_WIDTH (current_buffer).
40 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
42 * fileio.c: Integer overflow issues with file modes.
43 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
45 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
46 Remove unreachable code.
47 (read_hex, load_charset_map_from_file): Check for integer overflow.
49 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
51 * xterm.c: don't go over XClientMessageEvent limit
52 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
53 (x_send_scroll_bar_event): Likewise. Check that the size does not
54 exceed limits imposed by XClientMessageEvent, as well as the usual
55 ptrdiff_t and size_t limits.
57 * keyboard.c: Overflow, signedness and related fixes.
58 (make_lispy_movement): Use same integer type in forward decl
59 that is used in the definition.
60 (read_key_sequence, keyremap_step):
61 Change bufsize argument back to int, undoing my 2011-03-30 change.
62 We prefer signed types, and int is wide enough here.
63 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
64 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
65 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
66 length, not size_t. Use ptrdiff_t for index, not int.
67 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
68 possibility of integer overflow.
70 Overflow, signedness and related fixes for images.
72 * dispextern.h (struct it.stack[0].u.image.image_id)
73 (struct_it.image_id, struct image.id, struct image_cache.size)
74 (struct image_cache.used, struct image_cache.ref_count):
75 * gtkutil.c (update_frame_tool_bar):
76 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
77 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
78 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
79 * nsmenu.m (update_frame_tool_bar):
80 * xdisp.c (calc_pixel_width_or_height):
81 * xfns.c (image_cache_refcount):
82 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
83 on typical 64-bit hosts.
85 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
86 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
87 Omit unnecessary casts to int.
88 (parse_image_spec): Check that integers fall into 'int' range
89 when the callers expect that.
90 (image_ascent): Redo ascent calculation to avoid int overflow.
91 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
92 (lookup_image): Remove unnecessary tests.
93 (xbm_image_p): Locals are now of int, not EMACS_INT,
94 since parse_image_check makes sure they fit into int.
95 (png_load, gif_load, svg_load_image):
96 Prefer int to unsigned where either will do.
97 (tiff_handler): New function, combining the cores of the
98 old tiff_error_handler and tiff_warning_handler. This
99 function is rewritten to use vsnprintf and thereby avoid
100 stack buffer overflows. It uses only the features of vsnprintf
101 that are common to both POSIX and native Microsoft.
102 (tiff_error_handler, tiff_warning_handler): Use it.
103 (tiff_load, gif_load, imagemagick_load_image):
104 Don't assume :index value fits in 'int'.
105 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
106 (imagemagick_load_image): Check that crop parameters fit into
107 the integer types that MagickCropImage accepts. Don't assume
108 Vimagemagick_render_type has a nonnegative value. Don't assume
109 size_t fits in 'long'.
110 (gs_load): Use printmax_t to print the widest integers possible.
111 Check for integer overflow when computing image height and width.
113 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
115 Integer signedness and overflow and related fixes. (Bug#9079)
117 * bidi.c: Integer size and overflow fixes.
118 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
119 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
120 (bidi_cache_find_level_change, bidi_cache_ensure_space)
121 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
122 (bidi_find_other_level_edge):
123 Use ptrdiff_t instead of EMACS_INT where either will do.
124 This works better on 32-bit hosts configured --with-wide-int.
125 (bidi_cache_ensure_space): Check for size-calculation overflow.
126 Use % rather than repeated addition, for better worst-case speed.
127 Don't set bidi_cache_size until after xrealloc returns, because it
129 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
130 (bidi_cache_ensure_space): Also check that the bidi cache size
131 does not exceed that of the largest Lisp string or buffer. See Eli
132 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
134 * alloc.c (__malloc_size_t): Remove.
135 All uses replaced by size_t. See Andreas Schwab's note
136 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
138 * image.c: Improve checking for integer overflow.
139 (check_image_size): Assume that f is nonnull, since
140 it is always nonnull in practice. This is one less thing to
141 worry about when checking for integer overflow later.
142 (x_check_image_size): New function, which checks for integer
143 overflow issues inside X.
144 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
145 This removes the need for a memory_full check.
146 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
147 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
148 (xbm_read_bitmap_data): Change locals back to 'int', since
149 their values must fit in 'int'.
150 (xpm_load_image, png_load, tiff_load):
151 Invoke x_create_x_image_and_pixmap earlier,
152 to avoid much needless work if the image is too large.
153 (tiff_load): Treat overly large images as if
154 x_create_x_image_and_pixmap failed, not as malloc failures.
155 (gs_load): Use x_check_image_size.
157 * gtkutil.c: Omit integer casts.
158 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
159 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
161 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
163 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
164 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
165 would wrongly return t on a 64-bit host.
167 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
168 The plain *_OVERFLOW macros run afoul of GCC bug 49705
169 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
170 and therefore cause GCC to emit a bogus diagnostic in some cases.
172 * image.c: Integer signedness and overflow and related fixes.
173 This is not an exhaustive set of fixes, but it's time to
174 record what I've got.
175 (lookup_pixel_color, check_image_size): Remove redundant decls.
176 (check_image_size): Don't assume that arbitrary EMACS_INT values
177 fit in 'int', or that arbitrary 'double' values fit in 'int'.
178 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
179 (tiff_load, imagemagick_load_image):
180 Check for overflow in size calculations.
181 (x_create_x_image_and_pixmap): Remove unnecessary test for
182 xmalloc returning NULL; that can't happen.
183 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
184 (xpm_color_bucket): Use better integer hashing function.
185 (xpm_cache_color): Don't possibly over-allocate memory.
186 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
188 Use ptrdiff_t, not int or size_t, to record sizes.
189 (png_load): Don't assume values greater than 2**31 fit in 'int'.
190 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
191 either works, as we prefer signed integers.
192 (tiff_read_from_memory, tiff_write_from_memory):
193 Return tsize_t, not size_t, since that's what the TIFF API wants.
194 (tiff_read_from_memory): Don't fail simply because the read would
195 go past EOF; instead, return a short read.
196 (tiff_load): Omit no-longer-needed casts.
197 (Fimagemagick_types): Don't assume size fits into 'int'.
199 Improve hashing quality when configured --with-wide-int.
200 * fns.c (hash_string): New function, taken from sxhash_string.
201 Do not discard information about ASCII character case; this
202 discarding is no longer needed.
203 (sxhash-string): Use it. Change sig to match it. Caller changed.
204 * lisp.h: Declare it.
205 * lread.c (hash_string): Remove, since we now use fns.c's version.
206 The fns.c version returns a wider integer if --with-wide-int is
207 specified, so this should help the quality of the hashing a bit.
209 * emacs.c: Integer overflow minor fix.
210 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
211 Define only if GNU_LINUX.
212 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
214 * dispnew.c: Integer signedness and overflow fixes.
215 Remove unnecessary forward decls, that were a maintenance hassle.
216 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
218 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
219 (scrolling_window): Use ptrdiff_t, not int, for byte count.
220 (prepare_desired_row, line_draw_cost):
221 Use int, not unsigned, where either works.
222 (save_current_matrix, restore_current_matrix):
223 Use ptrdiff_t, not size_t, where either works.
224 (init_display): Check for overflow more accurately, and without
225 relying on undefined behavior.
227 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
228 Remove, replacing with the new symbols in lisp.h. All uses changed.
229 * fileio.c (make_temp_name):
230 * filelock.c (lock_file_1, lock_file):
231 * xdisp.c (message_dolog):
232 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
233 Use pMd etc. instead.
234 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
235 replacing the pWIDE etc. symbols removed from editfns.c.
237 * keyboard.h (num_input_events): Now uintmax_t.
238 This is (very slightly) less likely to mess up due to wraparound.
241 * buffer.c: Integer signedness fixes.
242 (alloc_buffer_text, enlarge_buffer_text):
243 Use ptrdiff_t rather than size_t when either will do, as we prefer
246 * alloc.c: Integer signedness and overflow fixes.
247 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
248 (__malloc_size_t): Default to size_t, not to int.
249 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
250 (Fgarbage_collect, mark_object_loop_halt, mark_object):
251 Prefer ptrdiff_t to size_t when either would do, as we prefer
253 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
254 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
255 Now const. Initialize with values that are in range even if char
257 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
258 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
259 These functions do the right thing with sizes > 2**32.
260 (check_depth): Now ptrdiff_t, not int.
261 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
262 Adjust to new way of storing sizes. Check for size overflow bugs
264 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
265 slightly wrong anyway, as it missed one instance of
266 XMALLOC_OVERRUN_CHECK_OVERHEAD.
267 (refill_memory_reserve): Omit needless cast to size_t.
268 (mark_object_loop_halt): Mark as externally visible.
270 * xselect.c: Integer signedness and overflow fixes.
271 (Fx_register_dnd_atom, x_handle_dnd_message):
272 Use ptrdiff_t, not size_t, since we prefer signed.
273 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
274 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
275 x_dnd_atoms_size and x_dnd_atoms_length.
277 * doprnt.c: Prefer signed to unsigned when either works.
281 * xdisp.c (vmessage):
282 Use ptrdiff_t, not size_t, when using or implementing doprnt,
283 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
284 prefer signed arithmetic to avoid comparison confusion.
285 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
288 Assume freestanding C89 headers, string.h, stdlib.h.
289 * data.c, doprnt.c, floatfns.c, print.c:
290 Include float.h unconditionally.
291 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
292 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
293 * regex.c: Likewise for stddef.h, string.h.
294 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
295 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
296 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
297 (STDC_HEADERS): Remove obsolete defines.
298 * sysdep.c: Include limits.h unconditionally.
300 Assume support for memcmp, memcpy, memmove, memset.
301 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
302 * regex.c (memcmp, memcpy):
303 Remove; we assume C89 now.
305 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
306 (__malloc_safe_bcopy): Remove; no longer needed.
308 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
309 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
310 well either way, and we prefer signed to unsigned.
312 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
314 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
315 This works around a problem with the previous change to Fcopy_file.
316 Recent glibc declares fchown with __attribute__((warn_unused_result)),
317 and without this change, GCC might complain about discarding
318 fchown's return value.
320 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
322 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
324 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
326 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
328 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
330 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
331 it's used from the C level.
333 * process.c: Use the same condition for POLL_FOR_INPUT in both
334 keyboard.c and process.c (bug#1858).
336 2011-07-09 Lawrence Mitchell <wence@gmx.li>
338 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
339 (Fgnutls_boot): Use it.
341 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
343 * doc.c (Fsubstitute_command_keys): Revert last change.
345 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
347 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
348 quotes the next character, and doesn't affect other longer
349 sequences (bug#8935).
351 * lread.c (syms_of_lread): Clarify that is isn't only
352 `eval-buffer' and `eval-defun' that's affected by
353 `lexical-binding' (bug#8460).
355 2011-07-15 Eli Zaretskii <eliz@gnu.org>
357 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
358 bidi redisplay when a line includes both an image and is
361 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
363 Fix minor problems found by static checking.
364 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
365 (elsz): Now a signed constant, not a size_t var. We prefer signed
366 types to unsigned, to avoid integer comparison confusion. Without
367 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
368 "cannot optimize loop, the loop counter may overflow", a symptom
370 * indent.c (Fvertical_motion): Mark locals as initialized.
371 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
373 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
375 * search.c (Fre_search_backward): Mention `case-fold-search' in
376 all the re_search_* functions (bug#8138).
378 * keyboard.c (Fopen_dribble_file): Document when the file is
381 2011-07-14 Eli Zaretskii <eliz@gnu.org>
383 * bidi.c (bidi_dump_cached_states): Fix format of displaying
386 Support bidi reordering of display and overlay strings.
387 * xdisp.c (compute_display_string_pos)
388 (compute_display_string_end): Accept additional argument STRING.
389 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
390 (reseat_to_string): Initialize bidi_it->string.s and
391 bidi_it->string.schars.
392 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
393 NULL (avoids a crash in bidi_paragraph_init). Initialize
395 (init_iterator): Call bidi_init_it only of a valid
396 buffer position was specified. Initialize paragraph_embedding to
398 (reseat_to_string): Initialize the bidi iterator.
399 (display_string): If we need to ignore text properties of
400 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
401 original value of -1 will not work with bidi.)
402 (compute_display_string_pos): First arg is now struct
403 `text_pos *'; all callers changed. Support display properties on
405 (compute_display_string_end): Support display properties on Lisp
407 (init_iterator, reseat_1, reseat_to_string): Initialize the
408 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
409 when iterating on a string not from display properties).
410 (compute_display_string_pos, compute_display_string_end): Fix
411 calculation of the object to scan. Fixes an error when using
413 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
414 base_level_stop; instead, set base_level_stop to BEGV. Fixes
415 crashes in vertical-motion.
416 (next_element_from_buffer): Improve commentary for when
417 the iterator is before prev_stop.
418 (init_iterator): Initialize bidi_p from the default value of
419 bidi-display-reordering, not from buffer-local value. Use the
420 buffer-local value only if initializing for buffer iteration.
421 (handle_invisible_prop): Support invisible properties on strings
422 that are being bidi-reordered.
423 (set_iterator_to_next): Support bidi reordering of C strings and
425 (next_element_from_string): Support bidi reordering of Lisp
427 (handle_stop_backwards): Support Lisp strings as well.
428 (display_string): Support display of R2L glyph rows. Use
429 IT_STRING_CHARPOS when displaying from a Lisp string.
430 (init_iterator): Don't initialize it->bidi_p for strings
432 (reseat_to_string): Initialize it->bidi_p for strings here.
433 (next_element_from_string, next_element_from_c_string)
434 (next_element_from_buffer): Add xassert's for correspondence
435 between IT's object being iterated and it->bidi_it.string
437 (face_before_or_after_it_pos): Support bidi iteration.
438 (next_element_from_c_string): Handle the case of the first string
439 character that is not the first one in the visual order.
440 (get_visually_first_element): New function, refactored from common
441 parts of next_element_from_buffer, next_element_from_string, and
442 next_element_from_c_string.
443 (tool_bar_lines_needed, redisplay_tool_bar)
444 (display_menu_bar): Force left-to-right direction. Add a FIXME
445 comment for making that be controlled by a user option.
446 (push_it, pop_it): Save and restore the state of the
447 bidi iterator. Save and restore the bidi_p flag.
448 (pop_it): Iterate out of display property for string iteration as
450 (iterate_out_of_display_property): Support iteration over strings.
451 (handle_single_display_spec): Set up it->bidi_it for iteration
452 over a display string, and call bidi_init_it.
453 (handle_single_display_spec, next_overlay_string)
454 (get_overlay_strings_1, push_display_prop): Set up the bidi
455 iterator for displaying display or overlay strings.
456 (forward_to_next_line_start): Don't use the shortcut if
458 (back_to_previous_visible_line_start): If handle_display_prop
459 pushed the iterator stack, restore the internal state of the bidi
460 iterator by calling bidi_pop_it same number of times.
461 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
462 and we are bidi-iterating, don't decrement the iterator position;
463 instead, set the first_elt flag in the bidi iterator, to produce
465 (reseat_1): Remove redundant setting of string_from_display_prop_p.
466 (push_display_prop): xassert that we are iterating a buffer.
467 (push_it, pop_it): Save and restore paragraph_embedding member.
468 (handle_single_display_spec, next_overlay_string)
469 (get_overlay_strings_1, reseat_1, reseat_to_string)
470 (push_display_prop): Set up the `unibyte' member of bidi_it.string
471 correctly. Don't assume unibyte strings are not bidi-reordered.
472 (compute_display_string_pos)
473 (compute_display_string_end): Fix handling the case of C string.
474 (push_it, pop_it): Save and restore from_disp_prop_p.
475 (handle_single_display_spec, push_display_prop): Set the
476 from_disp_prop_p flag.
477 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
478 (pop_it): Call iterate_out_of_display_property only if we are
479 popping after iteration over a string that came from a display
480 property. Fix a typo in popping stretch info. Add an assertion
481 for verifying that the iterator position is in sync with the bidi
483 (handle_single_display_spec, get_overlay_strings_1)
484 (push_display_prop): Fix initialization of paragraph direction for
485 string when that of the parent object is not yet determined.
486 (reseat_1): Call bidi_init_it to resync the bidi
487 iterator with IT's position. (Bug#7616)
488 (find_row_edges): If ROW->start.pos gives position
489 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
490 (handle_stop, back_to_previous_visible_line_start, reseat_1):
491 Reset the from_disp_prop_p flag.
492 (SAVE_IT, RESTORE_IT): New macros.
493 (pos_visible_p, face_before_or_after_it_pos)
494 (back_to_previous_visible_line_start)
495 (move_it_in_display_line_to, move_it_in_display_line)
496 (move_it_to, move_it_vertically_backward, move_it_by_lines)
497 (try_scrolling, redisplay_window, display_line): Use them when
498 saving a temporary copy of the iterator and restoring it back.
499 (back_to_previous_visible_line_start, reseat_1)
500 (init_iterator): Empty the bidi cache "stack".
501 (move_it_in_display_line_to): If iterator ended up at
502 EOL, but we never saw any buffer positions smaller than
503 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
504 motion in bidi-reordered lines.
505 (move_it_in_display_line_to): Record prev_method and prev_pos
506 immediately before the call to set_iterator_to_next. Fixes cursor
507 motion in bidi-reordered lines with stretch glyphs and strings
508 displayed in margins. (Bug#8133) (Bug#8867)
509 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
511 (pos_visible_p): Support positions in bidi-reordered lines. Save
512 and restore bidi cache.
514 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
515 (bidi_paragraph_info): Delete unused struct.
516 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
517 (bidi_cache_start): New variable.
518 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
520 (bidi_cache_fetch_state, bidi_cache_search)
521 (bidi_cache_find_level_change, bidi_cache_iterator_state)
522 (bidi_cache_find, bidi_peek_at_next_level)
523 (bidi_level_of_next_char, bidi_find_other_level_edge)
524 (bidi_move_to_visually_next): Compare cache index with
525 bidi_cache_start rather than with zero.
526 (bidi_fetch_char): Accept new argument STRING; all callers
527 changed. Support iteration over a string. Support strings with
528 display properties. Support unibyte strings. Fix the type of
529 `len' according to what STRING_CHAR_AND_LENGTH expects.
530 (bidi_paragraph_init, bidi_resolve_explicit_1)
531 (bidi_resolve_explicit, bidi_resolve_weak)
532 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
533 iteration over a string.
534 (bidi_set_sor_type, bidi_resolve_explicit_1)
535 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
536 can now be zero (for strings); special values 0 and -1 were
537 changed to -1 and -2, respectively.
538 (bidi_char_at_pos): New function.
539 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
540 Call it instead of FETCH_MULTIBYTE_CHAR.
541 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
542 initialized to valid values.
543 (bidi_init_it): Don't initialize charpos and bytepos with invalid
545 (bidi_level_of_next_char): Allow the sentinel "position" to pass
546 the test for valid cached positions. Fix the logic for looking up
547 the sentinel state in the cache. GCPRO the Lisp string we are
549 (bidi_push_it, bidi_pop_it): New functions.
550 (bidi_initialize): Initialize the bidi cache start stack pointer.
551 (bidi_cache_ensure_space): New function, refactored from part of
552 bidi_cache_iterator_state. Don't assume the required size is just
553 one BIDI_CACHE_CHUNK away.
554 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
555 (bidi_count_bytes, bidi_char_at_pos): New functions.
556 (bidi_cache_search): Don't assume bidi_cache_last_idx is
557 always valid if bidi_cache_idx is valid.
558 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
559 is valid if it's going to be used.
560 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
561 (bidi_cache_fetch_state, bidi_cache_search)
562 (bidi_cache_find_level_change, bidi_cache_ensure_space)
563 (bidi_cache_iterator_state, bidi_cache_find)
564 (bidi_find_other_level_edge, bidi_cache_start_stack): All
565 variables related to cache indices are now EMACS_INT.
567 * dispextern.h (struct bidi_string_data): New structure.
568 (struct bidi_it): New member `string'. Make flag members be 1-bit
569 fields, and put them last in the struct.
570 (compute_display_string_pos, compute_display_string_end): Update
572 (bidi_push_it, bidi_pop_it): Add prototypes.
573 (struct iterator_stack_entry): New members bidi_p,
574 paragraph_embedding, and from_disp_prop_p.
575 (struct it): Member bidi_p is now a bit field 1 bit wide.
576 (bidi_shelve_cache, bidi_unshelve_cache): Declare
579 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
580 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
581 and vector-like objects.
583 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
584 cache around display iteration.
586 * window.c (Fwindow_end, window_scroll_pixel_based)
587 (displayed_window_lines, Frecenter): Save and restore the bidi
588 cache around display iteration.
590 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
592 * editfns.c (Fdelete_region): Clarify the use of the named
593 parameters (bug#6788).
595 2011-07-14 Martin Rudalics <rudalics@gmx.at>
597 * indent.c (Fvertical_motion): Set and restore w->pointm when
598 saving and restoring the window's buffer (Bug#9006).
600 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
602 * editfns.c (Fstring_to_char): Clarify just what is returned
603 (bug#6576). Text by Eli Zaretskii.
605 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
607 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
609 2011-07-13 Eli Zaretskii <eliz@gnu.org>
611 * buffer.c (mmap_find): Fix a typo.
613 2011-07-13 Johan Bockgård <bojohan@gnu.org>
615 Fix execution of x selection hooks.
616 * xselect.c (Qx_lost_selection_functions)
617 (Qx_sent_selection_functions): New vars.
618 (syms_of_xselect): DEFSYM them.
619 (x_handle_selection_request): Pass Qx_sent_selection_functions
620 rather than Vx_sent_selection_functions to Frun_hook_with_args.
621 (x_handle_selection_clear,x_clear_frame_selections):
622 Pass Qx_lost_selection_functions rather than
623 Vx_lost_selection_functions to Frun_hook_with_args.
625 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
627 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
628 The old code sometimes used this field without initializing it.
630 * alloc.c (gc_sweep): Don't read past end of array.
631 In theory, the old code could also have corrupted Emacs internals,
632 though it'd be very unlikely.
634 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
636 * character.c (Fcharacterp): Don't advertise optional ignored
639 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
641 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
644 * window.c (Fset_window_start): Doc fix (bug#4199).
645 (Fset_window_hscroll): Ditto.
647 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
649 Fix minor new problems caught by GCC 4.6.1.
650 * term.c (init_tty): Remove unused local.
651 * xsettings.c (store_monospaced_changed): Define this function only
652 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
655 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
657 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
659 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
661 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
662 are the mini-buffer and the echo area (bug#3320).
664 * term.c (init_tty): Remove support for supdup, c10 and perq
665 terminals, which are no longer supported (bug#1482).
667 2011-07-10 Johan Bockgård <bojohan@gnu.org>
669 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
671 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
673 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
674 for non-popups (Bug#3642).
676 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
678 * alloc.c (reset_malloc_hooks): Protoize.
679 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
680 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
681 * cm.c (losecursor): Likewise.
682 * data.c (fmod): Likewise.
683 * dispnew.c (swap_glyphs_in_rows): Likewise.
684 * emacs.c (memory_warning_signal): Likewise.
685 * floatfns.c (float_error): Likewise.
686 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
687 (otf_open, font_otf_capability, generate_otf_features)
688 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
690 * image.c (pbm_read_file): Likewise.
691 * indent.c (string_display_width): Likewise.
692 * intervals.c (check_for_interval, search_for_interval)
693 (inc_interval_count, count_intervals, root_interval)
694 (adjust_intervals_for_insertion, make_new_interval): Likewise.
695 * lread.c (defalias): Likewise.
696 * ralloc.c (r_alloc_check): Likewise.
697 * regex.c (set_image_of_range_1, set_image_of_range)
698 (regex_grow_registers): Likewise.
699 * sysdep.c (strerror): Likewise.
700 * termcap.c (valid_filename_p, tprint, main): Likewise.
701 * tparam.c (main): Likewise.
702 * unexhp9k800.c (run_time_remap, save_data_space)
703 (update_file_ptrs, read_header, write_header, calculate_checksum)
704 (copy_file, copy_rest, display_header): Likewise.
705 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
707 * xdisp.c (check_it): Likewise.
708 * xfaces.c (register_color, unregister_color, unregister_colors):
710 * xfns.c (print_fontset_result): Likewise.
711 * xrdb.c (member, fatal, main): Likewise.
713 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
715 Fix minor problems found by static checking (Bug#9031).
716 * chartab.c (char_table_set_range, map_sub_char_table):
717 Remove unused locals.
718 (uniprop_table): Now static.
719 * composite.c (_work_char): Remove unused static var.
721 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
723 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
725 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
727 * gtkutil.c (qttip_cb): Remove code without function.
729 2011-07-09 Eli Zaretskii <eliz@gnu.org>
731 * w32.c (pthread_sigmask): New stub.
733 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
735 Use pthread_sigmask, not sigprocmask (Bug#9010).
736 sigprocmask is portable only for single-threaded applications, and
737 Emacs can be multi-threaded when it uses GTK.
738 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
740 * callproc.c (Fcall_process):
741 * process.c (create_process):
742 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
743 Use pthread_sigmask, not sigprocmask.
745 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
747 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
748 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
751 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
753 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
754 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
755 (xg_hide_tooltip): Fix comment.
757 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
758 in registerServicesMenuSendTypes.
759 (validRequestorForSendType): Don't check ns_return_types.
761 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
764 2011-07-08 Jason Rumney <jasonr@gnu.org>
766 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
767 frame struct members of non-existent frames (Bug#6284).
769 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
771 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
772 variable firstTime not needed on OSX >= 10.6.
773 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
774 >= 10.5. Use setKnobProportion, setDoubleValue.
776 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
777 (MAC_OS_X_VERSION_10_5): Define if not defined.
778 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
779 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
780 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
782 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
783 cString and lossyCString on OSX >= 10.4
785 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
786 sizeToFit on OSX >= 10.2.
788 * nsimage.m (allocInitFromFile): Don't use deprecated method
789 bestRepresentationForDevice on OSX >= 10.6.
791 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
794 * emacs.c: Declare unexec_init_emacs_zone.
796 * nsgui.h: Fix compiler warning about gnulib redefining verify.
798 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
800 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
801 on svcsMenu (Bug#8842).
803 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
805 (Fns_list_services): Just return Qnil on 10.6, code not working there.
807 * nsterm.m (QUTF8_STRING): Declare.
808 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
809 (validRequestorForSendType): Return type is (id).
810 Change indexOfObjectIdenticalTo to indexOfObject.
811 Check if we have local selection before returning self (Bug#8842).
812 (writeSelectionToPasteboard): Put local selection into paste board
813 if we have a local selection (Bug#8842).
814 (syms_of_nsterm): DEFSYM QUTF8_STRING.
816 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
817 (ns_get_local_selection): Declare.
819 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
821 * keymap.c (describe_map_tree): Don't insert a double newline at
822 the end of the buffer (bug#1169) and return whether we inserted
825 * callint.c (Fcall_interactively): Change "reading args" to
826 "providing args" to try to clarify what it does (bug#1010).
828 2011-07-07 Kenichi Handa <handa@m17n.org>
830 * composite.c (composition_compute_stop_pos): Ignore a static
831 composition starting before CHARPOS (Bug#8915).
833 * xdisp.c (handle_composition_prop): Likewise.
835 2011-07-07 Eli Zaretskii <eliz@gnu.org>
837 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
840 2011-07-07 Kenichi Handa <handa@m17n.org>
842 * character.h (unicode_category_t): New enum type.
844 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
845 (Qchar_code_property_table): New variable.
846 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
847 (UNIPROP_COMPRESSED_FORM_P): New macros.
848 (char_table_ascii): Uncompress the compressed values.
849 (sub_char_table_ref): New arg is_uniprop. Callers changed.
850 Uncompress the compressed values.
851 (sub_char_table_ref_and_range): Likewise.
852 (char_table_ref_and_range): Uncompress the compressed values.
853 (sub_char_table_set): New arg is_uniprop. Callers changed.
854 Uncompress the compressed values.
855 (sub_char_table_set_range): Args changed. Callers changed.
856 (char_table_set_range): Adjuted for the above change.
857 (map_sub_char_table): Delete args default_val and parent. Add arg
858 top. Give decoded values to a Lisp function.
859 (map_char_table): Adjusted for the above change. Give decoded
860 values to a Lisp function. Gcpro more variables.
861 (uniprop_table_uncompress)
862 (uniprop_decode_value_run_length): New functions.
863 (uniprop_decoder, uniprop_decoder_count): New variables.
864 (uniprop_get_decoder, uniprop_encode_value_character)
865 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
867 (uniprop_encoder, uniprop_encoder_count): New variables.
868 (uniprop_get_encoder, uniprop_table)
869 (Funicode_property_table_internal, Fget_unicode_property_internal)
870 (Fput_unicode_property_internal): New functions.
871 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
872 Sunicode_property_table_internal, Sget_unicode_property_internal,
873 and Sput_unicode_property_internal. Defvar_lisp
874 char-code-property-alist.
876 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
877 Vunicode_category_table.
879 * font.c (font_range): Adjusted for the change of
880 Vunicode_category_table.
882 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
884 * m/iris4d.h: Remove file, move contents ...
885 * s/irix6-5.h: ... here.
887 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
889 Remove unportable assumption about struct layout (Bug#8884).
890 * alloc.c (mark_buffer):
891 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
892 (clone_per_buffer_values): Don't assume that
893 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
894 This isn't true in general, and it's particularly not true
895 if Emacs is configured with --with-wide-int.
896 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
897 New macros, used in the buffer.c change.
899 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
901 * xsettings.c: Use both GConf and GSettings if both are available.
902 (store_config_changed_event): Add comment.
903 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
904 (store_tool_bar_style_changed): New functions.
905 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
906 (struct xsettings): Move font inside HAVE_XFT.
907 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
908 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
909 Move inside HAVE_XFT.
910 (something_changed_gsettingsCB): Renamed from something_changedCB.
911 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
913 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
914 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
915 (something_changed_gconfCB): Renamed from something_changedCB.
916 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
917 (parse_settings): Move check for font inside HAVE_XFT.
918 (read_settings, apply_xft_settings): Add comment.
919 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
920 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
921 call store_font_name_changed.
922 (xft_settings_event): Add comment.
923 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
924 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
925 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
926 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
927 (xsettings_initialize): Call init_gsettings last.
928 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
931 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
933 Random fixes. E.g., (random) never returned negative values.
934 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
935 subseconds part to the entropy, as that's a bit more random.
936 Prefer signed to unsigned, since the signedness doesn't matter and
937 in general we prefer signed. When given a limit, use a
938 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
939 latter isn't right if USE_2_TAGS_FOR_INTS.
940 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
941 not 0..VALMASK. Don't discard "excess" bits that random () returns.
943 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
945 * textprop.c (text_property_stickiness):
946 Obey Vtext_property_default_nonsticky.
947 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
948 * w32fns.c (syms_of_w32fns):
949 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
951 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
953 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
954 This is more efficient than Ffile_directory_p and avoids a minor race.
956 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
958 * buffer.c (Foverlay_put): Say what the return value is
961 * fileio.c (barf_or_query_if_file_exists): Check first if the file
962 is a directory before asking whether to use the file name
964 (barf_or_query_if_file_exists): Make the "File is a directory"
965 error be more correct.
967 * fns.c (Frequire): Remove the mention of the .gz files, since
968 that's installation-specific, but keep the mention of
971 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
973 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
974 Report string overflow if the output is too long.
976 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
978 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
979 (syms_of_gnutls): Remove duplicate DEFSYM for
980 Qgnutls_bootprop_verify_hostname_error, an error for
981 Qgnutls_bootprop_verify_error (which is no longer used).
983 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
984 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
985 Also (re)move comments that are misplaced or no longer relevant.
987 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
989 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
991 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
993 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
994 and background color parameters if they have been changed.
996 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
998 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1000 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1002 * xsettings.c (SYSTEM_FONT): Define only when used.
1003 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1005 * keymap.c (access_keymap_1): Now static.
1007 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1009 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1010 leave any prefix arg for the up event (Bug#1586).
1012 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1014 * lread.c (syms_of_lread): Mention single symbols defined by
1015 `defvar' or `defconst' (bug#7154).
1017 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1018 (Frequire): Mention get-load-suffixes.
1020 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1022 * window.h (window): Remove clone_number slot.
1023 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1025 (make_parent_window, make_window, saved_window)
1026 (Fset_window_configuration, save_window_save): Don't deal with
1028 * buffer.c (Qclone_number): Remove declaration.
1029 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1031 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1033 Add multiple inheritance to keymaps.
1034 * keymap.c (Fmake_composed_keymap): New function.
1035 (Fset_keymap_parent): Simplify.
1036 (fix_submap_inheritance): Remove.
1037 (access_keymap_1): New function extracted from access_keymap to handle
1038 embedded parents and handle lists of maps.
1039 (access_keymap): Use it.
1040 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1041 (Fcopy_keymap): Handle embedded parents.
1042 (Fcommand_remapping, define_as_prefix): Simplify.
1043 (Fkey_binding): Simplify.
1044 (syms_of_keymap): Move minibuffer-local-completion-map,
1045 minibuffer-local-filename-completion-map,
1046 minibuffer-local-must-match-map, and
1047 minibuffer-local-filename-must-match-map to Elisp.
1048 (syms_of_keymap): Defsubr make-composed-keymap.
1049 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1050 (parse_menu_item): Trivial simplification.
1052 2011-07-01 Glenn Morris <rgm@gnu.org>
1054 * Makefile.in (SETTINGS_LIBS): Fix typo.
1056 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1058 * coding.c (Fencode_coding_string): Record the last coding system
1059 used, as the function doc string says (bug#8738).
1061 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1063 * xsettings.c (store_monospaced_changed): Take new font as arg and
1064 check for change against current_mono_font.
1065 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1066 (emacs_settings_constructor, emacs_settings_get_property)
1067 (emacs_settings_set_property, emacs_settings_class_init)
1068 (emacs_settings_init, gsettings_obj): Remove.
1069 (something_changedCB): New function for HAVE_GSETTINGS.
1070 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1071 with value as argument.
1072 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1073 g_settings_new (Bug#8967). Do not create gsettings_obj.
1074 Remove calls to g_settings_bind. Connect something_changedCB to
1077 * xgselect.c: Add defined (HAVE_GSETTINGS).
1078 (xgselect_initialize): Ditto.
1080 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1081 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1084 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1086 * eval.c (struct backtrace): Simplify and port the data structure.
1087 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1088 signed bit field, as this assumption is not portable and it makes
1089 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1090 "char debug_on_exit : 1" as this is not portable either; instead,
1091 use the portable "unsigned int debug_on_exit : 1". Remove unused
1092 member evalargs. Remove obsolete comments about cc bombing out.
1094 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1096 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1097 Let HAVE_GSETTINGS override HAVE_GCONF.
1098 (store_monospaced_changed): New function.
1099 (EMACS_SETTINGS): A new type derived from GObject to handle
1100 GSettings notifications.
1101 (emacs_settings_constructor, emacs_settings_get_property)
1102 (emacs_settings_set_property, emacs_settings_class_init):
1104 (gsettings_client, gsettings_obj): New variables.
1105 (GSETTINGS_SCHEMA): New define.
1106 (something_changedCB): Call store_monospaced_changed.
1107 (init_gsettings): New function.
1108 (xsettings_initialize): Call init_gsettings.
1109 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1112 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1115 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1117 * window.c (resize_root_window, grow_mini_window)
1118 (shrink_mini_window): Rename Qresize_root_window to
1119 Qwindow_resize_root_window and Qresize_root_window_vertically to
1120 Qwindow_resize_root_window_vertically.
1122 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1124 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1126 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1128 * makefile.w32-in: Redesign dependencies so they reflect more
1129 clearly which files are directly included by each source file,
1130 and not through other includes.
1132 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1134 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1135 (sort_overlays, overlay_strings): When an overlay's clone number
1136 matches the window's clone number process the overlay even if
1137 the overlay's window property doesn't match the current window.
1139 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1140 (Fwindow_hchild): Rename to Fwindow_left_child.
1141 (Fwindow_next): Rename to Fwindow_next_sibling.
1142 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1143 (resize_window_check): Rename to window_resize_check.
1144 (resize_window_apply): Rename to window_resize_apply.
1145 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1146 (Fdelete_other_windows_internal, resize_frame_windows)
1147 (Fsplit_window_internal, Fdelete_window_internal)
1148 (grow_mini_window, shrink_mini_window)
1149 (Fresize_mini_window_internal): Fix callers accordingly.
1151 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1153 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1154 (emacs_fixed_set_min_size): Remove.
1155 (emacs_fixed_new): Take frame as argument.
1157 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1158 (_EmacsFixedPrivate): Remove minwidth/height.
1159 Add struct frame *f.
1160 (emacs_fixed_init): Initialize priv->f.
1161 (get_parent_class, emacs_fixed_set_min_size): Remove.
1162 (emacs_fixed_new): Set priv->f to argument.
1163 (emacs_fixed_get_preferred_width)
1164 (emacs_fixed_get_preferred_height): Use min_width/height from
1165 frames size_hint to set minimum and natural (Bug#8919).
1166 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1167 and use min_width/height from frames size_hint to set
1168 min_width/height (Bug#8919).
1170 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1171 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1174 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1176 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1177 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1180 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1182 * process.c (wait_reading_process_output): Bypass select if
1183 waiting for a cell while ignoring keyboard input, and input is
1184 pending. Suggested by Jan Djärv (Bug#8869).
1186 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1188 Use gnulib's dup2 module instead of rolling our own.
1189 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1191 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1193 * dispnew.c (scrolling_window): Before scrolling, turn off a
1194 mouse-highlight in the window being scrolled.
1196 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1198 Move DEFSYM to lisp.h and use everywhere.
1200 * character.h (DEFSYM): Move declaration...
1201 * lisp.h (DEFSYM): ...here.
1207 * w32select.c: Don't include character.h.
1209 * alloc.c (syms_of_alloc):
1210 * buffer.c (syms_of_buffer):
1211 * bytecode.c (syms_of_bytecode):
1212 * callint.c (syms_of_callint):
1213 * casefiddle.c (syms_of_casefiddle):
1214 * casetab.c (init_casetab_once):
1215 * category.c (init_category_once, syms_of_category):
1216 * ccl.c (syms_of_ccl):
1217 * cmds.c (syms_of_cmds):
1218 * composite.c (syms_of_composite):
1219 * dbusbind.c (syms_of_dbusbind):
1220 * dired.c (syms_of_dired):
1221 * dispnew.c (syms_of_display):
1222 * doc.c (syms_of_doc):
1223 * editfns.c (syms_of_editfns):
1224 * emacs.c (syms_of_emacs):
1225 * eval.c (syms_of_eval):
1226 * fileio.c (syms_of_fileio):
1227 * fns.c (syms_of_fns):
1228 * frame.c (syms_of_frame):
1229 * fringe.c (syms_of_fringe):
1230 * insdel.c (syms_of_insdel):
1231 * keymap.c (syms_of_keymap):
1232 * lread.c (init_obarray, syms_of_lread):
1233 * macros.c (syms_of_macros):
1234 * msdos.c (syms_of_msdos):
1235 * print.c (syms_of_print):
1236 * process.c (syms_of_process):
1237 * search.c (syms_of_search):
1238 * sound.c (syms_of_sound):
1239 * syntax.c (init_syntax_once, syms_of_syntax):
1240 * terminal.c (syms_of_terminal):
1241 * textprop.c (syms_of_textprop):
1242 * undo.c (syms_of_undo):
1243 * w32.c (globals_of_w32):
1244 * window.c (syms_of_window):
1245 * xdisp.c (syms_of_xdisp):
1246 * xfaces.c (syms_of_xfaces):
1247 * xfns.c (syms_of_xfns):
1248 * xmenu.c (syms_of_xmenu):
1249 * xsettings.c (syms_of_xsettings):
1250 * xterm.c (syms_of_xterm): Use DEFSYM.
1252 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1254 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1256 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1258 Integer and buffer overflow fixes (Bug#8873).
1260 * print.c (printchar, strout): Check for string overflow.
1261 (PRINTPREPARE, printchar, strout):
1262 Don't set size unless allocation succeeds.
1264 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1265 for sizes. Check for string overflow more accurately.
1266 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1268 * macros.c: Integer and buffer overflow fixes.
1269 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1270 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1271 Use ptrdiff_t, not int, for sizes.
1272 Don't increment bufsize until after realloc succeeds.
1273 Check for size-calculation overflow.
1274 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1276 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1278 * lread.c: Integer overflow fixes.
1279 (read_integer): Radix is now EMACS_INT, not int,
1280 to improve quality of diagnostics for out-of-range radices.
1281 Calculate buffer size correctly for out-of-range radices.
1282 (read1): Check for integer overflow in radices, and in
1283 read-circle numbers.
1284 (read_escape): Avoid int overflow.
1285 (Fload, openp, read_buffer_size, read1)
1286 (substitute_object_recurse, read_vector, read_list, map_obarray):
1287 Use ptrdiff_t, not int, for sizes.
1288 (read1): Use EMACS_INT, not int, for sizes.
1289 Check for size overflow.
1291 * image.c (cache_image): Check for size arithmetic overflow.
1293 * lread.c: Integer overflow issues.
1294 (saved_doc_string_size, saved_doc_string_length)
1295 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1296 Now ptrdiff_t, not int.
1297 (read1): Don't assume doc string length fits in int. Check for
1298 out-of-range doc string lengths.
1299 (read_list): Don't assume file position fits in int.
1300 (read_escape): Check for hex character overflow.
1302 2011-06-22 Leo Liu <sdl.web@gmail.com>
1304 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1305 Move to minibuffer.el.
1307 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1309 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1310 The following patches are for when GLYPH_DEBUG && !XASSERT.
1311 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1312 * dispnew.c (flush_stdout):
1313 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1314 Mark as externally visible.
1315 * dispnew.c (check_window_matrix_pointers): Now static.
1316 * dispnew.c (window_to_frame_vpos):
1317 * xfns.c (unwind_create_frame):
1318 * xterm.c (x_check_font): Remove unused local.
1319 * scroll.c (CHECK_BOUNDS):
1320 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1321 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1322 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1323 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1324 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1326 (debug_method_add): Use va_list and vsprintf rather than relying
1327 on undefined behavior with wrong number of arguments.
1328 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1329 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1330 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1331 since we're not interested in debugging glyphs with old libraries.
1332 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1333 GCC 4.6.0's static checking.
1335 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1337 Integer overflow and signedness fixes (Bug#8873).
1338 A few related buffer overrun fixes, too.
1340 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1342 * dispextern.h (struct face.stipple):
1343 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1344 (x_bitmap_mask, x_allocate_bitmap_record)
1345 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1346 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1347 (x_create_bitmap_from_xpm_data):
1348 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1349 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1351 * xfaces.c (load_pixmap):
1352 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1353 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1354 (.bitmaps_last, struct x_output.icon_bitmap):
1355 Use ptrdiff_t, not int, for bitmap indexes.
1356 (x_allocate_bitmap_record): Check for size overflow.
1357 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1359 Use ptrdiff_t, not int, for overlay counts.
1360 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1361 * editfns.c (overlays_around, get_pos_property):
1362 * textprop.c (get_char_property_and_overlay):
1363 * xdisp.c (next_overlay_change, note_mouse_highlight):
1364 * xfaces.c (face_at_buffer_position):
1365 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1366 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1367 (Fnext_overlay_change, Fprevious_overlay_change)
1368 (mouse_face_overlay_overlaps, Foverlays_in):
1369 Use ptrdiff_t, not int, for sizes.
1370 (overlays_at, overlays_in): Check for size-calculation overflow.
1372 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1374 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1375 (x_session_initialize): Do not assume string length fits in int.
1377 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1378 This is unlikely, but can occur if DPI is outlandish.
1380 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1381 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1383 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1384 * xrdb.c (magic_file_p, search_magic_path):
1385 Omit last arg SUFFIX; it was always 0. All callers changed.
1386 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1388 * xfont.c (xfont_match): Avoid need for strlen.
1390 * xfns.c: Don't assume strlen fits in int.
1391 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1393 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1394 not unsigned long, as we prefer signed integers. All callers changed.
1395 Detect integer overflow in repeat count.
1396 (message_dolog): Don't assume print length fits in 39 bytes.
1397 (display_mode_element): Don't assume strlen fits in int.
1399 * termcap.c: Don't assume sizes fit in int and never overflow.
1400 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1401 (gobble_line): Check for size-calculation overflow.
1403 * minibuf.c (Fread_buffer):
1404 * lread.c (intern, intern_c_string):
1405 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1406 Don't assume string length fits in int.
1408 * keyboard.c (parse_tool_bar_item):
1409 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1411 * font.c: Don't assume string length fits in int.
1412 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1413 Use ptrdiff_t, not int.
1414 (font_intern_prop): Don't assume string length fits in int.
1415 Don't assume integer property fits in fixnum.
1416 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1418 * filelock.c: Fix some buffer overrun and integer overflow issues.
1419 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1420 Reformulate so as not to need the command string.
1421 Invoke gzip -cd rather than gunzip, as it's more portable.
1422 (lock_info_type, lock_file_1, lock_file):
1423 Don't assume pid_t and time_t fit in unsigned long.
1424 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1425 (current_lock_owner): Prefer signed type for sizes.
1426 Use memcpy, not strncpy, where memcpy is what is really wanted.
1427 Don't assume (via atoi) that time_t and pid_t fit in int.
1428 Check for time_t and/or pid_t out of range, e.g., via a network share.
1429 Don't alloca where an auto var works fine.
1431 * fileio.c: Fix some integer overflow issues.
1432 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1433 Don't assume string length fits in int.
1434 (directory_file_name): Don't assume string length fits in long.
1435 (make_temp_name): Don't assume pid fits in int, or that its print
1436 length is less than 20.
1438 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1440 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1442 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1444 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1445 We prefer signed integers, even for size calculations.
1447 * emacs.c: Don't assume string length fits in 'int'.
1448 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1449 (main): Don't invoke strlen when not needed.
1451 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1452 (XD_DEBUG_MESSAGE): Don't waste a byte.
1454 * callproc.c (getenv_internal_1, getenv_internal)
1456 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1458 * lread.c (invalid_syntax): Omit length argument.
1459 All uses changed. This doesn't fix a bug, but it simplifies the
1460 code away from its former Hollerith-constant appearance, and it's
1461 one less 'int' to worry about when looking at integer-overflow issues.
1462 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1464 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1465 This didn't break anything, but it didn't help either.
1466 It's confusing to put a bogus integer in a place where the actual
1467 value does not matter.
1468 (LIST_END_P): Remove unused macro and its bogus comment.
1469 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1471 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1472 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1474 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1475 We prefer signed types, and the value cannot exceed the EMACS_INT
1476 range anyway (because otherwise the length would not be representable).
1477 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1478 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1479 This avoids a GCC warning when WIDE_EMACS_INT.
1481 * indent.c (sane_tab_width): New function.
1482 (current_column, scan_for_column, Findent_to, position_indentation)
1483 (compute_motion): Use it. This is just for clarity.
1484 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1486 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1488 * lisp.h (lint_assume): New macro.
1489 * composite.c (composition_gstring_put_cache):
1490 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1492 * editfns.c, insdel.c:
1493 Omit unnecessary forward decls, to simplify future changes.
1495 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1497 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1499 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1500 Use much-faster test for byte-length change.
1501 Don't assume string byte-length fits in 'int'.
1502 Check that character arg fits in 'int'.
1503 (mapcar1): Declare byte as byte, for clarity.
1505 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1507 * fns.c (concat): Catch string overflow earlier.
1508 Do not rely on integer wraparound.
1510 * dispextern.h (struct it.overlay_strings_charpos)
1511 (struct it.selective): Now EMACS_INT, not int.
1512 * xdisp.c (forward_to_next_line_start)
1513 (back_to_previous_visible_line_start)
1514 (reseat_at_next_visible_line_start, next_element_from_buffer):
1515 Don't arbitrarily truncate the value of 'selective' to int.
1517 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1519 * composite.c: Don't truncate sizes to 'int'.
1520 (composition_gstring_p, composition_reseat_it)
1521 (composition_adjust_point): Use EMACS_INT, not int.
1522 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1523 not EMACS_UINT, for indexes.
1525 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1527 * buffer.c: Include <verify.h>.
1528 (struct sortvec.priority, struct sortstr.priority):
1529 Now EMACS_INT, not int.
1530 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1531 (struct sortstr.size, record_overlay_string)
1532 (struct sortstrlist.size, struct sortlist.used):
1533 Don't truncate size to int.
1534 (record_overlay_string): Check for size-calculation overflow.
1535 (init_buffer_once): Check at compile-time, not run-time.
1537 2011-06-22 Jim Meyering <meyering@redhat.com>
1539 Don't leak an XBM-image-sized buffer
1540 * image.c (xbm_load): Free the image buffer after using it.
1542 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1545 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1546 that Sun C diagnosed.
1547 * fns.c (secure_hash): Fix pointer signedness issue.
1548 * intervals.c (static_offset_intervals): New function.
1549 (offset_intervals): Use it.
1551 2011-06-21 Leo Liu <sdl.web@gmail.com>
1554 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1557 * fns.c (secure_hash): Rename from crypto_hash_function and change
1558 the first arg to accept symbols.
1559 (Fsecure_hash): New primitive.
1560 (syms_of_fns): New symbols.
1562 2011-06-20 Deniz Dogan <deniz@dogan.se>
1564 * process.c (Fset_process_buffer): Clarify return value in
1567 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1569 * dispnew.c (add_window_display_history): Use BVAR.
1571 * xdisp.c (debug_method_add): Use BVAR.
1572 (check_window_end, dump_glyph_matrix, dump_glyph)
1573 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1575 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1578 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1579 check till after the cache is created in init_frame_faces.
1581 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1583 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1585 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1587 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1588 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1589 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1591 Improve buffer-overflow checking (Bug#8873).
1592 * fileio.c (Finsert_file_contents):
1593 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1594 Remove the old (too-loose) buffer overflow checks.
1595 They weren't needed, since make_gap checks for buffer overflow.
1596 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1597 The old code merely checked for Emacs fixnum overflow, and relied
1598 on undefined (wraparound) behavior. The new code avoids undefined
1599 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1601 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1602 Tune. Don't use wider integers than needed. Don't use alloca.
1603 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1605 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1607 * insdel.c, lisp.h (buffer_overflow): New function.
1608 (insert_from_buffer_1, replace_range, replace_range_2):
1609 * insdel.c (make_gap_larger):
1610 * editfns.c (Finsert_char):
1611 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1613 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1615 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1617 Integer overflow and signedness fixes (Bug#8873).
1619 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1620 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1622 * fileio.c: Don't assume EMACS_INT fits in off_t.
1623 (emacs_lseek): New static function.
1624 (Finsert_file_contents, Fwrite_region): Use it.
1625 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1627 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1629 * fns.c: Don't overflow int when computing a list length.
1630 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1631 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1632 truncation on 64-bit hosts. Check for QUIT every
1633 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1634 faster and is responsive enough.
1635 (Flength): Report an error instead of overflowing an integer.
1636 (Fsafe_length): Return a float if the value is not representable
1637 as a fixnum. This shouldn't happen except in contrived situations.
1638 (Fnthcdr, Fsort): Don't assume list length fits in int.
1639 (Fcopy_sequence): Don't assume vector length fits in int.
1641 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1642 (header_size, word_size): New constants.
1643 (allocate_vectorlike): Don't check size overflow here.
1644 (allocate_vector): Check it here instead, since this is the only
1645 caller of allocate_vectorlike that could cause overflow.
1646 Check that the new vector's length is representable as a fixnum.
1648 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1649 The previous code was bogus. For example, next_almost_prime (32)
1650 returned 39, which is undesirable as it is a multiple of 3; and
1651 next_almost_prime (24) returned 25, which is a multiple of 5 so
1652 why was the code bothering to check for multiples of 7?
1654 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1656 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1658 Variadic C functions now count arguments with ptrdiff_t.
1659 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1660 Back then I didn't know that the Emacs coding style prefers signed int.
1661 Also, in the meantime I found a few more instances where arguments
1662 were being counted with int, which may truncate counts on 64-bit
1663 machines, or EMACS_INT, which may be unnecessarily wide.
1664 * lisp.h (struct Lisp_Subr.function.aMANY)
1665 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1666 Arg counts are now ptrdiff_t, not size_t.
1667 All variadic functions and their callers changed accordingly.
1668 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1669 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1670 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1671 * callint.c (Fcall_interactively): Check arg count for overflow,
1672 to avoid potential buffer overrun. Use signed char, not 'int',
1673 for 'varies' array, so that we needn't bother to check its size
1674 calculation for overflow.
1675 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1676 * eval.c (apply_lambda):
1677 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1678 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1679 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1681 * callint.c (Fcall_interactively): Don't use index var as event count.
1683 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1684 * mem-limits.h (SIZE): Remove; no longer used.
1686 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1688 Remove unnecessary casts.
1689 * xterm.c (x_term_init):
1690 * xfns.c (x_set_border_pixel):
1691 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1692 These aren't needed now that we assume ANSI C.
1694 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1695 It's more likely to cause problems (due to unsigned overflow)
1698 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1700 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1702 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1704 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1706 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1708 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1710 GLYPH_CODE_FACE returns EMACS_INT, not int.
1711 * dispextern.h (merge_faces):
1712 * xfaces.c (merge_faces):
1713 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1714 Don't assume EMACS_INT fits in int.
1716 * character.h (CHAR_VALID_P): Remove unused parameter.
1717 * fontset.c, lisp.h, xdisp.c: All uses changed.
1719 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1721 * fns.c (concat): Minor tuning based on overflow analysis.
1722 This doesn't fix any bugs. Use int to hold character, instead
1723 of constantly refetching from Emacs object. Use XFASTINT, not
1724 XINT, for value known to be a character. Don't bother comparing
1725 a single byte to 0400, as it's always less.
1727 * floatfns.c (Fexpt):
1728 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1730 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1733 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1735 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1736 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1737 incorrectly succeed when S was a string, because 4294967386 was
1738 truncated before it was used.
1740 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1741 Otherwise, an out-of-range integer could cause undefined behavior
1744 * composite.c: Use int, not EMACS_INT, for characters.
1745 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1746 EMACS_INT, for values that are known to be in character range.
1747 This doesn't fix any bugs but is the usual style inside Emacs and
1748 may generate better code on 32-bit machines.
1750 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1751 This is for reasons similar to the recent CHAR_STRING fix.
1752 * charset.c (Fencode_char): Check that character arg is actually
1753 a character. Pass an int to ENCODE_CHAR.
1754 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1755 wider than 'int', as a compile-time check to prevent future regressions
1758 * character.c (char_string): Remove unnecessary casts.
1760 Make sure a 64-bit char is never passed to CHAR_STRING.
1761 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1762 by silently ignoring the top 32 bits, allowing some values
1763 that were far too large to be valid characters.
1764 * character.h: Include <verify.h>.
1765 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1766 arguments are no wider than unsigned, as a compile-time check
1767 to prevent future regressions in this area.
1769 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1770 (Fsubst_char_in_region):
1772 * xdisp.c (decode_mode_spec_coding):
1773 Adjust to CHAR_STRING's new requirement.
1774 * editfns.c (Finsert_char, Fsubst_char_in_region):
1775 * fns.c (concat): Check that character args are actually
1776 characters. Without this test, these functions did the wrong
1777 thing with wildly out-of-range values on 64-bit hosts.
1779 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1780 These casts should not be needed on 32-bit hosts, either.
1781 * keyboard.c (read_char):
1782 * lread.c (Fload): Remove casts to unsigned.
1784 * lisp.h (UNSIGNED_CMP): New macro.
1785 This fixes comparison bugs on 64-bit hosts.
1786 (ASCII_CHAR_P): Use it.
1787 * casefiddle.c (casify_object):
1788 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1789 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1790 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1791 * dispextern.h (FACE_FROM_ID):
1792 * keyboard.c (read_char): Use UNSIGNED_CMP.
1794 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1795 not to EMACS_INT, to avoid GCC warning.
1797 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1799 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1800 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1801 isn't needed on 32-bit machines.
1803 * buffer.c (Fgenerate_new_buffer_name):
1804 Use EMACS_INT for count, not int.
1805 (advance_to_char_boundary): Return EMACS_INT, not int.
1807 * data.c (Qcompiled_function): Now static.
1809 * window.c (window_body_lines): Now static.
1811 * image.c (gif_load): Rename local to avoid shadowing.
1813 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1814 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1815 * alloc.c (make_save_value): Integer argument is now of type
1817 (mark_object): Use ptrdiff_t, not int.
1818 * lisp.h (pD): New macro.
1819 * print.c (print_object): Use it.
1821 * alloc.c: Use EMACS_INT, not int, to count objects.
1822 (total_conses, total_markers, total_symbols, total_vector_size)
1823 (total_free_conses, total_free_markers, total_free_symbols)
1824 (total_free_floats, total_floats, total_free_intervals)
1825 (total_intervals, total_strings, total_free_strings):
1826 Now EMACS_INT, not int. All uses changed.
1827 (Fgarbage_collect): Compute overall total using a double, so that
1828 integer overflow is less likely to be a problem. Check for overflow
1829 when converting back to an integer.
1830 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1831 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1832 These were 'int' variables that could overflow on 64-bit hosts;
1833 they were never used, so remove them instead of repairing them.
1834 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1835 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1836 Previously, this ceilinged at INT_MAX, but that doesn't work on
1838 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1840 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1841 (allocate_vectorlike): Check for ptrdiff_t overflow.
1842 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1843 when a (possibly-narrower) signed value would do just as well.
1844 We prefer using signed arithmetic, to avoid comparison confusion.
1846 * alloc.c: Catch some string size overflows that we were missing.
1847 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1848 for convenience in STRING_BYTES_MAX.
1849 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1850 The definition here is exact; the one in lisp.h was approximate.
1851 (allocate_string_data): Check for string overflow. This catches
1852 some instances we weren't catching before. Also, it catches
1853 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1854 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1855 and ptrdiff_t and EMACS_INT are both 64 bits.
1857 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1858 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1859 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1861 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1863 * alloc.c (Fmake_string): Check for out-of-range init.
1865 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1867 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1869 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1871 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1872 xg_get_default_scrollbar_width.
1874 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1875 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1876 (style_changed_cb): Call update_theme_scrollbar_width and call
1877 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1878 all frames (Bug#8505).
1879 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1880 Call gtk_window_set_resizable if HAVE_GTK3.
1881 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1882 and height if HAVE_GTK3 (Bug#8505).
1883 (scroll_bar_width_for_theme): New variable.
1884 (update_theme_scrollbar_width): New function.
1885 (xg_get_default_scrollbar_width): Move code to
1886 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1887 (xg_initialize): Call update_theme_scrollbar_width.
1889 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1891 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1893 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1895 * frame.c (make_frame): Call other_buffer_safely instead of
1898 * window.c (temp_output_buffer_show): Call display_buffer with
1899 second argument Vtemp_buffer_show_specifiers and reset latter
1900 immediately after the call.
1901 (Vtemp_buffer_show_specifiers): New variable.
1902 (auto_window_vscroll_p, next_screen_context_lines)
1903 (Vscroll_preserve_screen_position): Remove leading asterisks from
1906 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1908 Fix minor problems found by GCC 4.6.0 static checking.
1909 * buffer.c (Qclone_number): Remove for now, as it's unused.
1910 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1911 (record_buffer): Remove unused local.
1912 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1913 (set_frame_buffer_list): Remove; unused.
1914 * frame.h (other_visible_frames): Remove decl.
1915 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1916 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1917 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1919 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1920 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1921 Define only if HAVE_GPM.
1922 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1923 (update_hints_inhibit): Remove; never set. All uses removed.
1924 * widgetprv.h (emacsFrameClassRec): Remove decl.
1925 * window.c (delete_deletable_window): Now returns void, since it
1926 wasn't returning anything.
1927 (compare_window_configurations): Remove unused locals.
1928 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1929 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1930 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1931 the same widths as pointers. This follows up on the 2011-05-06 patch.
1932 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1933 * xterm.h: Likewise.
1934 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1936 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1938 * makefile.w32-in: Update dependencies.
1939 (LISP_H): Add lib/intprops.h.
1941 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1943 * image.c (gif_load): Add animation frame delay to the metadata.
1944 (syms_of_image): Use DEFSYM. New symbol `delay'.
1946 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1948 * window.c (delete_deletable_window): Re-add.
1949 (Fset_window_configuration): Rewrite to handle dead buffers and
1950 consequently deletable windows.
1951 (window_tree, Fwindow_tree): Remove. Supply functionality in
1953 (compare_window_configurations): Simplify code.
1955 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1957 * image.c (imagemagick_load_image): Fix type mismatch.
1958 (Fimagemagick_types): Likewise.
1960 * window.h (replace_buffer_in_windows): Declare.
1962 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1964 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1965 Qclone_number. Remove external declaration of Qdelete_window.
1966 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1968 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1969 Qbuffer_list_update_hook if allowed.
1970 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1971 buffer list implementation.
1972 (other_buffer_safely): New function.
1973 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1974 calls to replace_buffer_in_windows and
1975 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1977 (record_buffer): Inhibit quitting and rewrite using quittable
1978 functions. Run Qbuffer_list_update_hook if allowed.
1979 (Frecord_buffer, Funrecord_buffer): New functions.
1980 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1981 switch-to-buffer to window.el.
1982 (bury-buffer): Move to window.el.
1983 (Vbuffer_list_update_hook): New variable.
1985 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1988 * window.h (resize_frame_windows): Move up in code.
1989 (Fwindow_frame): Remove EXFUN.
1990 (replace_buffer_in_all_windows): Remove prototype.
1991 (replace_buffer_in_windows_safely): Add prototype.
1993 * window.c: Declare Qdelete_window static again. Move down
1994 declaration of select_count.
1995 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1996 (Fother_window): Move to window.el.
1997 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1998 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1999 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2001 (replace_buffer_in_windows): Implement by calling
2002 Qreplace_buffer_in_windows.
2003 (replace_buffer_in_all_windows): Remove with some functionality
2004 moved into replace_buffer_in_windows_safely.
2005 (replace_buffer_in_windows_safely): New function.
2006 (select_window_norecord, select_frame_norecord): Move in front
2007 of run_window_configuration_change_hook. Remove now obsolete
2009 (Fset_window_buffer): Rewrite doc-string. Call
2010 Qrecord_window_buffer.
2011 (keys_of_window): Move binding for other-window to window.el.
2013 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2015 * dispextern.h (struct image): Replace data member, whose int_val
2016 and ptr_val fields were not used by anything, with a single
2019 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2020 (gif_clear_image, gif_load, imagemagick_load_image)
2021 (gs_clear_image, gs_load): Callers changed.
2023 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2025 * buffer.h: Include <time.h>, for time_t.
2026 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2028 Fix minor problems found by static checking.
2030 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2032 Make identifiers static if they are not used in other modules.
2033 * data.c (Qcompiled_function, Qframe, Qvector):
2034 * image.c (QimageMagick, Qsvg):
2035 * minibuf.c (Qmetadata):
2036 * window.c (resize_window_check, resize_root_window): Now static.
2037 * window.h (resize_window_check, resize_root_window): Remove decls.
2039 * window.c (window_deletion_count, delete_deletable_window):
2041 (window_body_lines): Now static.
2042 (Fdelete_other_windows_internal): Mark vars as initialized.
2043 Make sure 'resize_failed' is initialized.
2044 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2045 (resize_window_apply): Remove unused local.
2046 * window.h (delete_deletable_window): Remove decl.
2048 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2049 (imagemagick_load_image): Fix pointer signedness problem by changing
2050 last arg from unsigned char * to char *. All uses changed.
2051 Also, fix a local for similar reasons.
2052 Remove unused locals. Remove locals to avoid shadowing.
2053 (fn_rsvg_handle_free): Remove; unused.
2054 (svg_load, svg_load_image): Fix pointer signedness problem.
2055 (imagemagick_load_image): Don't use garbage pointer image_wand.
2057 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2059 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2061 * image.c (gif_load): Fix omitted cast error introduced by
2064 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2066 * window.h (resize_proportionally, orig_total_lines)
2067 (orig_top_line): Remove from window structure.
2068 (set_window_height, set_window_width, change_window_heights)
2069 (Fdelete_window): Remove prototypes.
2070 (resize_frame_windows): Remove duplicate declaration.
2072 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2074 * window.h (resize_frame_windows, resize_window_check)
2075 (delete_deletable_window, resize_root_window)
2076 (resize_frame_windows): Declare prototypes.
2078 * window.c (resize_window_apply): Make definition be "static" to
2079 match the prototype.
2081 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2083 * window.c: Remove declarations of Qwindow_size_fixed,
2084 window_min_size_1, window_min_size_2, window_min_size,
2085 size_window, window_fixed_size_p, enlarge_window, delete_window.
2086 Remove static from declaration of Qdelete_window, it's
2087 temporarily needed by Fbury_buffer.
2088 (replace_window): Don't assign orig_top_line and
2090 (Fdelete_window, delete_window): Remove. Window deletion is
2091 handled by window.el.
2092 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2093 Fdelete_window calls with calls to Qdelete_window.
2094 (Fdelete_other_windows): Remove. Deleting other windows is
2095 handled by window.el.
2096 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2097 handled in window.el.
2098 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2099 Window minimum sizes are handled in window.el.
2100 (shrink_windows, size_window, set_window_height)
2101 (set_window_width, change_window_heights, window_height)
2102 (window_width, CURBEG, CURSIZE, enlarge_window)
2103 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2104 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2105 handled in window.el.
2106 (make_dummy_parent): Rename to make_parent_window and give it a
2107 second argument horflag.
2108 (make_window): Don't set resize_proportionally any more.
2109 (Fsplit_window): Remove. Windows are split in window.el.
2110 (save_restore_action, save_restore_orig_size)
2111 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2112 Resize mini windows in window.el.
2113 (grow_mini_window, shrink_mini_window): Implement by calling
2114 Qresize_root_window_vertically, resize_window_check and
2115 resize_window_apply.
2116 (saved_window, Fset_window_configuration, save_window_save): Do
2117 not handle orig_top_line, orig_total_lines, and
2118 resize_proportionally.
2119 (window_min_height, window_min_width): Move to window.el.
2120 (keys_of_window): Move bindings for delete-other-windows,
2121 split-window, delete-window and enlarge-window to window.el.
2123 * buffer.c: Temporarily extern Qdelete_window.
2124 (Fbury_buffer): Temporarily call Qdelete_window instead of
2125 Fdelete_window (Fbury_buffer will move to window.el soon).
2127 * frame.c (set_menu_bar_lines_1): Remove code handling
2128 orig_top_line and orig_total_lines.
2130 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2131 set_window_height but set heights directly.
2132 (change_frame_size_1): Use resize_frame_windows.
2134 * xdisp.c (init_xdisp): Don't use set_window_height but set
2137 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2138 resize_frame_windows instead of change_window_heights and run
2139 run_window_configuration_change_hook.
2141 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2142 instead of change_window_heights and run
2143 run_window_configuration_change_hook.
2145 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2147 * window.c (replace_window): Rename second argument REPLACEMENT to
2148 NEW. New third argument SETFLAG. Rewrite.
2149 (delete_window, make_dummy_parent): Call replace_window with
2151 (window_list_1): Move down in code.
2152 (run_window_configuration_change_hook): Move set_buffer part
2153 before select_frame_norecord part in order to unwind correctly.
2154 Rename count1 to count.
2155 (recombine_windows, delete_deletable_window, resize_root_window)
2156 (Fdelete_other_windows_internal)
2157 (Frun_window_configuration_change_hook, make_parent_window)
2158 (resize_window_check, resize_window_apply, Fresize_window_apply)
2159 (resize_frame_windows, Fsplit_window_internal)
2160 (Fdelete_window_internal, Fresize_mini_window_internal): New
2162 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2164 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2166 * window.h (window): Add some new members to window structure -
2167 normal_lines, normal_cols, new_total, new_normal, clone_number,
2168 splits, nest, prev_buffers, next_buffers.
2169 (WINDOW_TOTAL_SIZE): Move here from window.c.
2170 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2172 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2174 (make_dummy_parent): Set new members of windows structure.
2175 (make_window): Move down in code. Handle new members of window
2177 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2178 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2179 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2180 (Fset_window_prev_buffers, Fwindow_next_buffers)
2181 (Fset_window_next_buffers, Fset_window_clone_number): New
2183 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2184 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2186 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2187 Argument WINDOW can be now internal window too.
2188 (Fwindow_use_time): Move up in code.
2189 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2191 (Fset_window_configuration, saved_window)
2192 (Fcurrent_window_configuration, save_window_save): Handle new
2193 members of window structure.
2194 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2195 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2196 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2197 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2198 Qget_mru_window, Qresize_root_window,
2199 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2200 Qauto_buffer_name; staticpro them.
2202 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2204 * window.c (Fwindow_total_size, Fwindow_left_column)
2205 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2206 (Fwindow_list_1): New functions.
2207 (window_box_text_cols): Replace with window_body_cols.
2208 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2209 window_body_cols instead of window_box_text_cols.
2210 (delete_window, Fset_window_configuration): Call
2211 delete_all_subwindows with window as argument.
2212 (delete_all_subwindows): Take a window as argument and not a
2214 (window_loop): Remove handling of GET_LRU_WINDOW and
2216 (Fget_lru_window, Fget_largest_window): Move to window.el.
2218 * window.h: Extern window_body_cols instead of
2219 window_box_text_cols. delete_all_subwindows now takes a
2220 Lisp_Object as argument.
2222 * indent.c (compute_motion, Fcompute_motion): Use
2223 window_body_cols instead of window_box_text_cols.
2225 * frame.c (delete_frame): Call delete_all_subwindows with root
2228 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2230 * fns.c (Fputhash): Document return value.
2232 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2234 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2236 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2238 Cons<->int and similar integer overflow fixes (Bug#8794).
2240 Check for overflow when converting integer to cons and back.
2241 * charset.c (Fdefine_charset_internal, Fdecode_char):
2242 Use cons_to_unsigned to catch overflow.
2243 (Fencode_char): Use INTEGER_TO_CONS.
2244 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2245 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2246 * data.c (long_to_cons, cons_to_long): Remove.
2247 (cons_to_unsigned, cons_to_signed): New functions.
2248 These signal an error for invalid or out-of-range values.
2249 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2250 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2251 * font.c (Ffont_variation_glyphs):
2252 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2253 * lisp.h: Include <intprops.h>.
2254 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2255 (cons_to_signed, cons_to_unsigned): New decls.
2256 (long_to_cons, cons_to_long): Remove decls.
2257 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2258 (Fprimitive_undo): Use CONS_TO_INTEGER.
2259 * xfns.c (Fx_window_property): Likewise.
2260 * xselect.c: Include <limits.h>.
2261 (x_own_selection, selection_data_to_lisp_data):
2262 Use INTEGER_TO_CONS.
2263 (x_handle_selection_request, x_handle_selection_clear)
2264 (x_get_foreign_selection, Fx_disown_selection_internal)
2265 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2266 (lisp_data_to_selection_data): Use cons_to_unsigned.
2267 (x_fill_property_data): Use cons_to_signed.
2268 Report values out of range.
2270 Check for buffer and string overflow more precisely.
2271 * buffer.h (BUF_BYTES_MAX): New macro.
2272 * lisp.h (STRING_BYTES_MAX): New macro.
2273 * alloc.c (Fmake_string):
2274 * character.c (string_escape_byte8):
2275 * coding.c (coding_alloc_by_realloc):
2276 * doprnt.c (doprnt):
2277 * editfns.c (Fformat):
2279 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2280 since they may not be the same number.
2281 * editfns.c (Finsert_char):
2282 * fileio.c (Finsert_file_contents):
2283 Likewise for BUF_BYTES_MAX.
2285 * image.c: Use ptrdiff_t, not int, for sizes.
2286 (slurp_file): Switch from int to ptrdiff_t.
2288 (slurp_file): Check that file size fits in both size_t (for
2289 malloc) and ptrdiff_t (for sanity and safety).
2291 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2292 if b->modtime has its maximal value.
2294 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2296 Don't assume time_t can fit into int.
2297 * buffer.h (struct buffer.modtime): Now time_t, not int.
2298 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2299 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2301 Minor fixes for signed vs unsigned integers.
2302 * character.h (MAYBE_UNIFY_CHAR):
2303 * charset.c (maybe_unify_char):
2304 * keyboard.c (read_char, reorder_modifiers):
2305 XINT -> XFASTINT, since the integer must be nonnegative.
2306 * ftfont.c (ftfont_spec_pattern):
2307 * keymap.c (access_keymap, silly_event_symbol_error):
2308 XUINT -> XFASTINT, since the integer must be nonnegative.
2309 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2310 since it makes no difference and we prefer signed.
2311 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2312 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2315 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2317 * window.h (Fwindow_frame): Declare.
2319 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2321 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2322 (SPARE_MEMORY): Always define.
2323 (LARGE_REQUEST): Remove.
2324 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2326 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2328 * lisp.h: Move EXFUNS for Fframe_root_window,
2329 Fframe_first_window and Fset_frame_selected_window to window.h.
2331 * window.h: Move EXFUNS for Fframe_root_window,
2332 Fframe_first_window and Fset_frame_selected_window here from
2335 * frame.c (Fwindow_frame, Fframe_first_window)
2336 (Fframe_root_window, Fframe_selected_window)
2337 (Fset_frame_selected_window): Move to window.c.
2338 (Factive_minibuffer_window): Move to minibuf.c.
2339 (Fother_visible_frames_p): New function.
2341 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2343 * window.c (decode_window, decode_any_window): Move up in code.
2344 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2345 (inhibit_frame_unsplittable): Remove unused variable.
2346 (Fwindow_buffer): Move up and rewrite doc-string.
2347 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2348 (Fwindow_prev): New functions.
2349 (Fwindow_frame): Move here from frame.c. Accept any window as
2351 (Fframe_root_window, Fframe_first_window)
2352 (Fframe_selected_window): Move here from frame.c. Accept frame
2353 or arbitrary window as argument. Update doc-strings.
2354 (Fminibuffer_window): Move up in code.
2355 (Fwindow_minibuffer_p): Move up in code and simplify.
2356 (Fset_frame_selected_window): Move here from frame.c.
2358 (Fselected_window, select_window, Fselect_window): Move up in
2359 code. Minor doc-string fixes.
2361 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2363 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2364 Do not assume that spare memory exists; that assumption is valid
2365 only if SYSTEM_MALLOC.
2366 (LARGE_REQUEST): New macro, so that the issue of large requests
2367 is separated from the issue of spare memory.
2369 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2371 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2374 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2376 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2379 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2381 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2383 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2385 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2386 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2388 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2390 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2392 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2394 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2395 (x_clipboard_manager_save): Add return value.
2396 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2398 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2399 Obey Vx_select_enable_clipboard_manager. Catch errors in
2400 x_clipboard_manager_save (Bug#8779).
2401 (Vx_select_enable_clipboard_manager): New variable.
2402 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2404 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2406 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2408 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2410 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2411 in the current matrix if keep_current_p is non-zero.
2413 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2415 * bidi.c (bidi_level_of_next_char): Fix last change.
2417 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2419 Support bidi reordering of text covered by display properties.
2421 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2422 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2423 (bidi_cache_search, bidi_cache_iterator_state)
2424 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2425 (bidi_level_of_next_char, bidi_move_to_visually_next):
2426 Support character positions inside a run of characters covered by a
2428 (bidi_paragraph_init, bidi_resolve_explicit_1)
2429 (bidi_level_of_next_char): Call bidi_fetch_char and
2430 bidi_fetch_char_advance instead of FETCH_CHAR and
2432 (bidi_init_it): Initialize new members.
2433 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2435 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2436 instead of using explicit *_CHAR codes.
2437 (bidi_resolve_explicit, bidi_resolve_weak):
2438 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2439 bidirectional text is supported only in multibyte buffers.
2440 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2441 it to initialize the frame_window_p member of struct bidi_it.
2442 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2443 (bidi_resolve_explicit, bidi_resolve_weak)
2444 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2445 bidi_it->nchars is non-positive.
2446 (bidi_level_of_next_char): Don't try to lookup the cache for the
2447 next/previous character if nothing is cached there yet, or if we
2448 were just reseat()'ed to a new position.
2450 * xdisp.c (set_cursor_from_row): Set start and stop points
2451 according to the row's direction when priming the loop that looks
2452 for the glyph on which to display cursor.
2453 (single_display_spec_intangible_p): Function deleted.
2454 (display_prop_intangible_p): Reimplement to call
2455 handle_display_spec instead of single_display_spec_intangible_p.
2456 Accept 3 additional arguments needed by handle_display_spec.
2457 This fixes incorrect cursor motion across display property with complex
2458 values: lists, `(when COND...)' forms, etc.
2459 (single_display_spec_string_p): Support property values that are
2460 lists with the argument STRING its top-level element.
2461 (display_prop_string_p): Fix the condition for processing a
2462 property that is a list to be consistent with handle_display_spec.
2463 (handle_display_spec): New function, refactored from the
2464 last portion of handle_display_prop.
2465 (compute_display_string_pos): Accept additional argument
2466 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2467 value of a `display' property is a "replacing spec".
2468 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2469 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2470 the display property, but just return a value indicating whether
2471 the display property will replace the characters it covers.
2472 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2473 frame_window_p members of struct bidi_it.
2474 (compute_display_string_pos, compute_display_string_end):
2476 (push_it): Accept second argument POSITION, where pop_it should
2477 jump to continue iteration.
2478 (reseat_1): Initialize bidi_it.disp_pos.
2480 * keyboard.c (adjust_point_for_property): Adjust the call to
2481 display_prop_intangible_p to its new signature.
2483 * dispextern.h (struct bidi_it): New member frame_window_p.
2484 (bidi_init_it): Update prototypes.
2485 (display_prop_intangible_p): Update prototype.
2486 (compute_display_string_pos, compute_display_string_end):
2488 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2491 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2493 Malloc failure behavior now depends on size of allocation.
2494 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2495 * lisp.h: Change signatures accordingly.
2496 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2497 All callers changed. (Bug#8762)
2499 * gnutls.c: Use Emacs's memory allocators.
2500 Without this change, the gnutls library would invoke malloc etc.
2501 directly, which causes problems on non-SYNC_INPUT hosts, and which
2502 runs afoul of improving memory_full behavior. (Bug#8761)
2503 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2504 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2505 xfree instead of the default malloc, realloc, free.
2506 (Fgnutls_boot): No need to check for memory allocation failure,
2507 since xmalloc does that for us.
2509 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2510 * category.c (hash_get_category_set):
2511 * ccl.c (ccl_driver):
2512 * charset.c (Fdefine_charset_internal):
2513 * charset.h (struct charset.hash_index):
2514 * composite.c (get_composition_id, gstring_lookup_cache)
2515 (composition_gstring_put_cache):
2516 * composite.h (struct composition.hash_index):
2517 * dispextern.h (struct image.hash):
2518 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2519 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2520 (hashfn_equal, hashfn_user_defined, make_hash_table)
2521 (maybe_resize_hash_table, hash_lookup, hash_put)
2522 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2523 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2524 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2525 * image.c (make_image, search_image_cache, lookup_image)
2526 (xpm_put_color_table_h):
2527 * lisp.h (struct Lisp_Hash_Table):
2528 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2529 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2530 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2531 * alloc.c (allocate_vectorlike):
2532 Check for overflow in vector size calculations.
2533 * ccl.c (ccl_driver):
2534 Check for overflow when converting EMACS_INT to int.
2535 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2536 need to be updated by these changes.
2537 * fns.c (make_hash_table, maybe_resize_hash_table):
2538 Check for integer overflow with large hash tables.
2539 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2540 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2541 (SXHASH_REDUCE): New macro.
2542 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2543 Use it instead of discarding useful hash info with large hash values.
2544 (sxhash_float): New function.
2545 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2546 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2547 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2548 Rewrite to use FIXNUM_BITS, as this simplifies things.
2549 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2550 Adjust signatures to match updated version of code.
2551 (consing_since_gc): Now EMACS_INT, since a single hash table can
2552 use more than INT_MAX bytes.
2554 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2556 Make it possible to build with GCC-4.6+ -O2 -flto.
2558 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2560 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2562 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2563 Call minibuffer-inactive-mode.
2565 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2567 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2568 Update dependencies.
2570 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2572 * data.c (init_data): Remove code for UTS, this system is not
2575 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2577 Don't force ./temacs to start in terminal mode.
2579 * frame.c (make_initial_frame): Initialize faces in all cases, not
2580 only when CANNOT_DUMP is defined.
2581 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2583 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2585 * dispnew.c (add_window_display_history): Use const for the string
2586 pointer. Remove declaration, not needed.
2588 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2590 Use 'inline', not 'INLINE'.
2591 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2592 * alloc.c, fontset.c (INLINE): Remove.
2593 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2594 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2595 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2596 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2597 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2599 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2601 Make it possible to run ./temacs.
2603 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2604 syms_of_callproc does the same thing. Remove test for
2605 "initialized", do it in the caller.
2606 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2608 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2610 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2611 (read_minibuf): Use get_minibuffer.
2612 (syms_of_minibuf): Use DEFSYM.
2613 (Qmetadata): New var.
2614 * data.c (Qbuffer): Don't make it static.
2615 (syms_of_data): Use DEFSYM.
2617 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2619 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2620 (CCL_CODE_MIN): New macro.
2622 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2624 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2626 * eval.c (Qdebug): Now static.
2627 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2628 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2629 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2631 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2633 * image.c: Various fixes to ImageMagick code comments.
2634 (Fimagemagick_types): Doc fix.
2636 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2638 Minor fixes prompted by GCC 4.6.0 warnings.
2640 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2642 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2643 (x_clipboard_manager_save_all): Move extern decl to ...
2644 * xterm.h: ... here, so that it can be checked for consistency.
2646 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2648 * xselect.c (x_clipboard_manager_save_frame)
2649 (x_clipboard_manager_save_all): New functions.
2650 (Fx_clipboard_manager_save): Lisp function deleted.
2652 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2653 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2655 * xterm.h: Update prototype.
2657 2011-05-28 William Xu <william.xwl@gmail.com>
2659 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2662 2011-05-28 Jim Meyering <meyering@redhat.com>
2664 Avoid a sign-extension bug in crypto_hash_function.
2665 * fns.c (to_uchar): Define.
2666 (crypto_hash_function): Use it to convert some newly-signed
2667 variables to unsigned, to avoid sign-extension bugs. For example,
2668 without this change, (md5 "truc") would evaluate to
2669 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2670 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2671 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2673 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2675 Integer overflow fixes.
2677 * dbusbind.c: Serial number integer overflow fixes.
2678 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2679 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2680 to hold a serial number that is too large for a fixnum.
2681 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2682 Check for serial numbers out of range. Decode any serial number
2683 that was so large that it became a float. (Bug#8722)
2685 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2686 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2687 Use XFASTINT rather than XUINT when numbers are nonnegative.
2688 (xd_append_arg, Fdbus_method_return_internal):
2689 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2690 arguments, check that Lisp number is nonnegative, rather than
2691 silently wrapping negative numbers around. (Bug#8722)
2692 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2695 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2697 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2699 ccl: add integer overflow checks
2700 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2701 (IN_INT_RANGE): New macros.
2702 (ccl_driver): Use them to check for integer overflow when
2703 decoding a CCL program. Many of the new checks are whether XINT (x)
2704 fits in int; it doesn't always, on 64-bit hosts. The new version
2705 doesn't catch all possible integer overflows, but it's an
2706 improvement. (Bug#8719)
2708 * alloc.c (make_event_array): Use XINT, not XUINT.
2709 There's no need for unsigned here.
2711 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2712 This follows up to the 2011-05-06 change that substituted uintptr_t
2713 for EMACS_INT. This case wasn't caught back then.
2715 Rework Fformat to avoid integer overflow issues.
2716 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2717 now (part of C89). Include <verify.h>.
2718 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2719 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2720 (Fformat): Avoid the prepass trying to compute sizes; it was only
2721 approximate and thus did not catch overflow reliably. Instead, walk
2722 through the format just once, formatting and computing sizes as we go,
2723 checking for integer overflow at every step, and allocating a larger
2724 buffer as needed. Keep track separately whether the format is
2725 multibyte. Keep only the most-recently calculated precision, rather
2726 than them all. Record whether each argument has been converted to
2727 string. Use EMACS_INT, not int, for byte and char and arg counts.
2728 Support field widths and precisions larger than INT_MAX. Avoid
2729 sprintf's undefined behavior with conversion specifications such as %#d
2730 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2731 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2732 formatting out-of-range floating point numbers with int
2735 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2737 * data.c: Avoid integer truncation in expressions involving floats.
2738 * data.c: Include <intprops.h>.
2739 (arith_driver): When there's an integer overflow in an expression
2740 involving floating point, convert the integers to floating point
2741 so that the resulting value does not suffer from catastrophic
2742 integer truncation. For example, on a 64-bit host (* 4
2743 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2744 Do not rely on undefined behavior after integer overflow.
2746 merge count_size_as_multibyte, parse_str_to_multibyte
2747 * character.c, character.h (count_size_as_multibyte):
2748 Rename from parse_str_to_multibyte; all uses changed.
2749 Check for integer overflow.
2750 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2751 since it's now a duplicate of the other. This is more of
2752 a character than a buffer op, so better that it's in character.c.
2753 * fns.c, print.c: Adjust to above changes.
2755 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2757 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2759 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2761 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2762 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2763 (x_clipboard_manager_save): Now static.
2764 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2766 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2767 (crypto_hash_function): Now static.
2768 Fix pointer signedness problems. Avoid unnecessary initializations.
2770 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2772 * termhooks.h (Vselection_alist): Make it terminal-local.
2774 * terminal.c (create_terminal): Initialize it.
2776 * xselect.c: Support for clipboard managers.
2777 (Vselection_alist): Move to termhooks.h as terminal-local var.
2778 (LOCAL_SELECTION): New macro.
2779 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2780 (symbol_to_x_atom): Remove gratuitous arg.
2781 (x_handle_selection_request, lisp_data_to_selection_data)
2782 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2783 (x_own_selection, x_get_local_selection, x_convert_selection):
2784 New arg, specifying work frame. Use terminal-local Vselection_alist.
2785 (some_frame_on_display): Delete unused function.
2786 (Fx_own_selection_internal, Fx_get_selection_internal)
2787 (Fx_disown_selection_internal, Fx_selection_owner_p)
2788 (Fx_selection_exists_p): New optional frame arg.
2789 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2790 (x_handle_selection_clear): Don't treat other terminals with the
2791 same keyboard specially. Use the terminal-local Vselection_alist.
2792 (x_clear_frame_selections): Use Frun_hook_with_args.
2794 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2796 * xterm.h: Add support for those atoms.
2798 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2800 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2801 (converted_selections, conversion_fail_tag): New global variables.
2802 (x_selection_request_lisp_error): Free the above.
2803 (x_get_local_selection): Remove unnecessary code.
2804 (x_reply_selection_request): Args changed; handle arbitrary array
2805 of converted selections stored in converted_selections.
2806 Separate the XChangeProperty and SelectionNotify steps.
2807 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2808 (x_convert_selection): New function.
2809 (x_handle_selection_event): Simplify.
2810 (x_get_foreign_selection): Don't ignore incoming requests while
2811 waiting for an answer; this will fail when we implement
2812 SAVE_TARGETS, and seems unnecessary anyway.
2813 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2814 (Vx_sent_selection_functions): Doc fix.
2816 2011-05-26 Leo Liu <sdl.web@gmail.com>
2818 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2820 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2822 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2824 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2825 for fringe update if it has periodic bitmap.
2826 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2827 and fringe_bitmap_periodic_p.
2829 * fringe.c (get_fringe_bitmap_data): New function.
2830 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2831 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2832 row. Mark glyph row for fringe update if periodicity changed.
2834 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2835 for fringe update unless it has periodic bitmap.
2837 2011-05-25 Kenichi Handa <handa@m17n.org>
2839 * xdisp.c (get_next_display_element): Set correct it->face_id for
2840 a static composition.
2842 2011-05-24 Leo Liu <sdl.web@gmail.com>
2845 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2847 * fns.c (crypto_hash_function, Fsha1): New function.
2848 (Fmd5): Use crypto_hash_function.
2849 (syms_of_fns): Add Ssha1.
2851 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2853 * gnutls.c: Remove unused macros.
2854 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2855 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2856 Remove macros that are defined and never used.
2857 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2859 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2861 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2862 (Fx_get_selection_internal): Minor cleanup.
2863 (Fx_own_selection_internal): Rename arguments for consistency with
2866 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2868 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2870 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2872 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2874 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2876 * dispnew.c (scrolling_window): Don't exclude the case that the
2877 last enabled row in the desired matrix touches the bottom boundary.
2879 2011-05-21 Glenn Morris <rgm@gnu.org>
2881 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2882 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2883 and add some more files.
2885 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2887 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2888 report_file_error introduced by the change from 2011-05-07.
2890 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2892 * systime.h (Time): Define only if emacs is defined.
2893 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2894 where the include path doesn't have X11/X.h by default. See
2895 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2897 2011-05-20 Kenichi Handa <handa@m17n.org>
2899 * composite.c (find_automatic_composition): Fix previous change.
2901 2011-05-20 Glenn Morris <rgm@gnu.org>
2903 * lisp.mk: New file, split from Makefile.in.
2904 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2905 (shortlisp): Remove.
2906 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2908 2011-05-19 Glenn Morris <rgm@gnu.org>
2910 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2911 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2912 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2913 (lisp): Set the order to that of loadup.el.
2914 (shortlisp): Make it a copy of $lisp.
2915 (SOME_MACHINE_LISP): Remove.
2916 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2917 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2919 2011-05-18 Kenichi Handa <handa@m17n.org>
2921 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2922 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2923 (find_automatic_composition): Mostly rewrite for efficiency.
2925 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2927 * makefile.w32-in: Update dependencies.
2929 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2931 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2932 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2934 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2936 Fix some integer overflow issues, such as string length overflow.
2938 * insdel.c (count_size_as_multibyte): Check for string overflow.
2940 * character.c (lisp_string_width): Check for string overflow.
2941 Use EMACS_INT, not int, for string indexes and lengths; in
2942 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2943 the resulting string length overflows an EMACS_INT; instead,
2944 report a string overflow if no precision given. When checking for
2945 precision exhaustion, use a check that cannot possibly have
2946 integer overflow. (Bug#8675)
2947 * character.h (lisp_string_width): Adjust to new signature.
2949 * alloc.c (string_overflow): New function.
2950 (Fmake_string): Use it. This doesn't change behavior, but saves
2951 a few bytes and will simplify future changes.
2952 * character.c (string_escape_byte8): Likewise.
2953 * lisp.h (string_overflow): New decl.
2955 Fixups, following up to the user-interface timestamp change.
2956 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2957 for UI timestamps, instead of unsigned long.
2958 * msdos.c (mouse_get_pos): Likewise.
2959 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2960 * w32gui.h (Time): Define by including "systime.h" rather than by
2961 declaring it ourselves. (Bug#8664)
2963 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2964 * image.c (clear_image_cache): Likewise.
2966 * term.c (term_mouse_position): Don't assume time_t wraparound.
2968 Be more systematic about user-interface timestamps.
2969 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2970 and sometimes 'EMACS_UINT', to represent these timestamps.
2971 This change causes it to use 'Time' uniformly, as that's what X uses.
2972 This makes the code easier to follow, and makes it easier to catch
2973 integer overflow bugs such as Bug#8664.
2974 * frame.c (Fmouse_position, Fmouse_pixel_position):
2975 Use Time, not unsigned long, for user-interface timestamps.
2976 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2977 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2978 * keyboard.h (last_event_timestamp): Likewise.
2979 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2980 * menu.h (xmenu_show): Likewise.
2981 * term.c (term_mouse_position): Likewise.
2982 * termhooks.h (struct input_event.timestamp): Likewise.
2983 (struct terminal.mouse_position_hook): Likewise.
2984 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2985 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2986 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2987 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2989 * menu.h, termhooks.h: Include "systime.h", for Time.
2991 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2992 Don't assume that the difference between two unsigned long values
2993 can fit into an integer. At this point, we know button_down_time
2994 <= event->timestamp, so the difference must be nonnegative, so
2995 there's no need to cast the result if double-click-time is
2996 nonnegative, as it should be; check that it's nonnegative, just in
2997 case. This bug is triggered when events are more than 2**31 ms
2998 apart (about 25 days). (Bug#8664)
3000 * xselect.c (last_event_timestamp): Remove duplicate decl.
3001 (x_own_selection): Remove needless cast to unsigned long.
3003 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3004 that always fit in int. Use a sentinel instead of a counter, to
3005 avoid a temp and to allay GCC's concerns about possible int overflow.
3006 * frame.h (struct frame): Use int for menu_bar_items_used
3007 instead of EMACS_INT, since it always fits in int.
3009 * menu.c (grow_menu_items): Check for int overflow.
3011 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3013 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3014 Before, the code was not consistent. These values cannot exceed
3015 2**31 - 1 so there's no need to make them unsigned.
3016 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3017 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3018 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3020 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3022 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3023 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3024 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3025 presumably because the widths might not match.
3027 * window.c (size_window): Avoid needless test at loop start.
3029 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3031 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3033 2011-05-12 Drew Adams <drew.adams@oracle.com>
3035 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3037 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3039 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3040 `width' to `bar_area_x' and `bar_area_width', respectively.
3041 (x_scroll_run): Take account of fringe background extension.
3043 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3044 Rename local vars `left' and `width' to `bar_area_x' and
3045 `bar_area_width', respectively.
3046 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3047 background extension.
3049 2011-05-10 Jim Meyering <meyering@redhat.com>
3051 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3053 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3055 * image.c (Finit_image_library): Return t for built-in image types,
3056 like pbm and xbm. (Bug#8640)
3058 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3060 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3062 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3064 * w32console.c (Fset_screen_color): Doc fix.
3065 (Fget_screen_color): New function.
3066 (syms_of_ntterm): Defsubr it.
3068 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3069 unlink the temporary file if Fcall_process didn't create it in the
3071 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3072 child process will be redirected to a file specified with `:file'.
3073 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3074 cue to call_process_cleanup not to close that handle.
3076 2011-05-07 Ben Key <bkey76@gmail.com>
3078 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3079 one of two shell specific rules, either bootstrap-temacs-CMD or
3080 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3081 to the previous implementation of the bootstrap-temacs rule.
3082 The bootstrap-temacs-CMD rule is similar to the previous
3083 implementation of the bootstrap-temacs rule except that it
3084 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3087 These changes, along with some changes to nt/configure.bat,
3088 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3089 earlier fix to add support for --cflags and --ldflags options
3090 that include quotes so that it works whether make uses cmd or
3093 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3095 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3096 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3098 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3099 a string. Handle both cases.
3100 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3101 (Fdbus_register_method): Use Qinvalid_function.
3103 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3105 * makefile.w32-in: Update dependencies.
3106 (LISP_H): Add inttypes.h and stdin.h.
3107 (PROCESS_H): Add unistd.h.
3109 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3111 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3112 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3114 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3116 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3118 * term.c (vfatal): Remove stray call to va_end.
3119 It's not needed and the C Standard doesn't allow it here anyway.
3121 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3122 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3124 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3127 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3129 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3131 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3133 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3135 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3137 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3138 * charset.c (Fdefine_charset_internal): Don't initialize
3139 charset.code_space[15]. The value was garbage, on hosts with
3140 32-bit int (Bug#8600).
3142 * lread.c (read_integer): Be more consistent with string-to-number.
3143 Use string_to_number to do the actual conversion; this avoids
3144 rounding errors and fixes some other screwups. Without this fix,
3145 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3146 (digit_to_number): Move earlier, for benefit of read_integer.
3147 Return -1 if the digit is out of range for the base, -2 if it is
3148 not a digit in any supported base. (Bug#8602)
3150 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3152 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3153 to match comment at start of function. This also removes a
3154 GCC warning about overflow in a 32+64-bit port.
3156 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3158 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3159 Reported by Stefan Monnier in
3160 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3161 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3162 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3164 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3165 (EMACS_UINTPTR): Likewise, with uintptr_t.
3167 * lisp.h: Prefer 64-bit EMACS_INT if available.
3168 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3169 on 32-bit hosts that have 64-bit int, so that they can access
3171 However, temporarily disable this change unless the temporary
3172 symbol WIDE_EMACS_INT is defined.
3174 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3176 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3177 This removes an assumption that EMACS_INT and long are the same
3178 width as pointers. The assumption is true for Emacs porting targets
3179 now, but we want to make other targets possible.
3180 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3181 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3182 In the rest of the code, change types of integers that hold casted
3183 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3184 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3185 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3186 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3187 No need to cast type when ORing.
3188 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3189 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3190 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3191 assume EMACS_INT is the same width as char *.
3192 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3193 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3194 Remove no-longer-needed casts.
3195 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3196 (xg_tool_bar_help_callback, xg_make_tool_item):
3197 Use EMACS_INTPTR to hold an integer
3198 that will be cast to void *; this can avoid a GCC warning
3199 if EMACS_INT is not the same width as void *.
3200 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3201 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3202 (current_message_1, set_message_1):
3203 Use a local to convert to proper width without a cast.
3204 * xmenu.c (dialog_selection_callback): Likewise.
3206 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3207 Also, don't assume VALBITS / RAND_BITS is less than 5,
3208 and don't rely on undefined behavior when shifting a 1 left into
3210 * lisp.h (get_random): Change signature to match.
3212 * lread.c (hash_string): Use size_t, not int, for hash computation.
3213 Normally we prefer signed values; but hashing is special, because
3214 it's better to use unsigned division on hash table sizes so that
3215 the remainder is nonnegative. Also, size_t is the natural width
3216 for hashing into memory. The previous code used 'int', which doesn't
3217 retain enough info to hash well into very large tables.
3218 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3220 * dbusbind.c: Don't possibly lose pointer info when converting.
3221 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3222 Use XPNTR rather than XHASH, so that the high-order bits of
3223 the pointer aren't lost when converting through void *.
3225 * eval.c (Fautoload): Don't double-shift a pointer.
3227 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3229 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3231 * gnutls.c (DEF_GNUTLS_FN):
3232 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3234 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3236 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3239 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3241 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3242 New version that can reserve upto 2GB of heap space.
3244 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3246 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3248 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3250 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3251 `gnutls_certificate_set_x509_key_file'.
3253 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3255 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3256 Update dependencies.
3258 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3260 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3261 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3262 Remove unused parameter `fildes'.
3263 * process.c (read_process_output, send_process): Don't pass it.
3265 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3267 Fix previous change: the library cache is defined in w32.c.
3268 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3269 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3271 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3273 Implement dynamic loading of GnuTLS on Windows.
3275 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3276 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3277 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3280 * gnutls.c (Qgnutls_dll): Define.
3281 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3282 (gnutls_*): Declare function pointers.
3283 (init_gnutls_functions): New function to initialize function pointers.
3284 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3285 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3286 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3287 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3288 (emacs_gnutls_write, emacs_gnutls_read)
3289 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3290 (Fgnutls_available_p): New function.
3291 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3292 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3293 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3295 * image.c: Include w32.h.
3296 (Vimage_type_cache): Delete.
3297 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3298 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3299 (w32_delayed_load): Move to w32.c.
3301 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3303 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3304 (w32_delayed_load): Move from image.c. When loading a library, record
3305 its filename in the :loaded-from property of the library id.
3306 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3307 Initialize and staticpro them.
3308 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3310 * process.c: Include lisp.h before w32.h, not after.
3311 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3312 instead of gnutls_record_check_pending.
3314 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3316 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3318 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3319 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3322 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3324 * xterm.c (x_set_frame_alpha): Do not set property on anything
3325 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3327 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3329 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3331 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3333 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3334 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3335 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3336 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3337 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3338 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3339 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3340 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3341 (Qgnutls_bootprop_callbacks_verify): Make static.
3343 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3345 * callproc.c: Indentation fixup.
3347 * sysdep.c (wait_for_termination_1): Make static.
3348 (wait_for_termination, interruptible_wait_for_termination):
3349 Move after wait_for_termination_1.
3351 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3353 * sysdep.c (interruptible_wait_for_termination): New function
3354 which is like wait_for_termination, but allows keyboard
3357 * callproc.c (Fcall_process): Add (:file "file") as an option for
3359 (Fcall_process_region): Ditto.
3361 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3363 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3364 rather than `XVECTOR (FOO)->size'.
3366 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3367 inttypes.h, as a gnulib replacement is used if it not available in
3370 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3372 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3373 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3374 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3376 * coding.c (coding_alloc_by_realloc): Error out if destination
3377 will grow beyond MOST_POSITIVE_FIXNUM.
3378 (decode_coding_emacs_mule): Abort if there isn't enough place in
3379 charbuf for the composition carryover bytes. Reserve an extra
3380 space for up to 2 characters produced in a loop.
3381 (decode_coding_iso_2022): Abort if there isn't enough place in
3382 charbuf for the composition carryover bytes.
3384 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3386 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3387 aborting when %lld or %lll format is passed.
3388 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3389 %llo or %llx format is passed. (Bug#8545)
3391 * window.c (window_scroll_line_based): Use a marker instead of
3392 simple variables to record original value of point. (Bug#7952)
3394 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3395 produced by %s or %c overflows available buffer space. (Bug#8545)
3397 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3399 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3400 (SIZE_MAX): Move defn after all includes, as they might #define it.
3402 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3404 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3406 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3408 * keyboard.c (Qdelayed_warnings_hook): Define.
3409 (command_loop_1): Run `delayed-warnings-hook'
3410 if Vdelayed_warnings_list is non-nil.
3411 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3412 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3414 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3416 * doprnt.c (doprnt): Don't return value smaller than the buffer
3417 size if the message was truncated. (Bug#8545).
3419 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3421 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3422 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3424 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3426 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3428 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3430 * makefile.w32-in: Update dependencies.
3432 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3434 Improve `doprnt' and its usage. (Bug#8545)
3435 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3436 `format_end'. Remove support for %l as a conversion specifier.
3437 Don't use xrealloc. Improve diagnostics when the %l size modifier
3438 is used. Update the commentary.
3440 * eval.c (verror): Simplify calculation of size_t.
3442 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3445 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3447 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3450 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3452 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3453 This makes this file independent of the recent pseudovector change.
3455 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3457 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3459 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3460 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3461 Remove unused local.
3462 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3464 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3465 GCC 4.6.0 optimizes based on type-based alias analysis.
3466 For example, if b is of type struct buffer * and v of type struct
3467 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3468 != &v->size, and therefore "v->size = 1; b->size = 2; return
3469 v->size;" must therefore return 1. This assumption is incorrect
3470 for Emacs, since it type-puns struct Lisp_Vector * with many other
3471 types. To fix this problem, this patch adds a new type struct
3472 vectorlike_header that documents the constraints on layout of vectors
3473 and pseudovectors, and helps optimizing compilers not get fooled
3474 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3475 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3476 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3478 (XSETPVECTYPE): Rewrite in terms of new macro.
3479 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3480 This is a bit clearer, and further avoids the possibility of
3481 undesirable aliasing.
3482 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3483 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3484 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3485 since Lisp_Subr is a special case (no "next" field).
3486 (ASIZE): Now uses header.size rather than size.
3487 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3488 to avoid the hassle of writing XVECTOR (foo)->header.size.
3489 (struct vectorlike_header): New type.
3490 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3491 object, to help avoid aliasing.
3492 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3493 (SUBRP): Likewise, since Lisp_Subr is a special case.
3494 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3495 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3496 (struct Lisp_Hash_Table): Combine first two members into a single
3497 struct vectorlike_header member. All uses of "size" and "next" members
3498 changed to be "header.size" and "header.next".
3499 * buffer.h (struct buffer): Likewise.
3500 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3501 * frame.h (struct frame): Likewise.
3502 * process.h (struct Lisp_Process): Likewise.
3503 * termhooks.h (struct terminal): Likewise.
3504 * window.c (struct save_window_data, struct saved_window): Likewise.
3505 * window.h (struct window): Likewise.
3506 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3507 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3508 * buffer.c (init_buffer_once): Likewise.
3509 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3511 * process.c (Fformat_network_address): Use local var for size,
3514 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3516 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3517 * data.c (atof): Remove decl; no longer used or needed.
3518 (digit_to_number): Move to lread.c.
3519 (Fstring_to_number): Use new string_to_number function, to be
3520 consistent with how the Lisp reader treats infinities and NaNs.
3521 Do not assume that floating-point numbers represent EMACS_INT
3522 without losing information; this is not true on most 64-bit hosts.
3523 Avoid double-rounding errors, by insisting on integers when
3524 parsing non-base-10 numbers, as the documentation specifies.
3525 * lisp.h (string_to_number): New decl, replacing ...
3526 (isfloat_string): Remove.
3527 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3528 (read1): Do not accept +. and -. as integers; this
3529 appears to have been a coding error. Similarly, do not accept
3530 strings like +-1e0 as floating point numbers. Do not report
3531 overflow for integer overflows unless the base is not 10 which
3532 means we have no simple and reliable way to continue.
3533 Break out the floating-point parsing into a new
3534 function string_to_number, so that Fstring_to_number parses
3535 floating point numbers consistently with the Lisp reader.
3536 (digit_to_number): Move here from data.c. Make it static inline.
3537 (E_CHAR, EXP_INT): Remove, replacing with ...
3538 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3539 (string_to_number): New function, replacing isfloat_string.
3540 This function checks for valid syntax and produces the resulting
3541 Lisp float number too. Rework it so that string-to-number
3542 no longer mishandles examples like "1.0e+". Use strtoumax,
3543 so that overflow for non-base-10 numbers is reported only when
3544 there's no portable and simple way to convert to floating point.
3546 * textprop.c (set_text_properties_1): Rewrite for clarity,
3547 and to avoid GCC warning about integer overflow.
3549 * intervals.h (struct interval): Use EMACS_INT for members
3550 where EMACS_UINT might cause problems. See
3551 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3552 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3553 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3555 (offset_intervals): Tell GCC not to worry about length overflow
3556 when negating a negative length.
3558 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3559 (overrun_check_free): Likewise.
3561 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3562 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3565 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3566 (gnutls_make_error): Rename local to avoid shadowing.
3567 (gnutls_emacs_global_deinit): ifdef out; not used.
3568 (Fgnutls_boot): Use const for pointer to readonly storage.
3569 Comment out unused local. Fix pointer signedness problems.
3571 * lread.c (openp): Don't stuff size_t into an 'int'.
3572 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3573 about possible signed overflow.
3575 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3576 (GDK_KEY_g): Don't define if already defined.
3577 (xg_prepare_tooltip): Avoid pointer signedness problem.
3578 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3580 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3581 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3583 * xfns.c (Fx_window_property): Simplify a bit,
3584 to make a bit faster and to avoid GCC 4.6.0 warning.
3585 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3587 * fns.c (internal_equal): Don't assume size_t fits in int.
3589 * alloc.c (compact_small_strings): Tighten assertion a little.
3591 Replace pEd with more-general pI, and fix some printf arg casts.
3592 * lisp.h (pI): New macro, generalizing old pEd macro to other
3593 conversion specifiers. For example, use "...%"pI"d..." rather
3594 than "...%"pEd"...".
3595 (pEd): Remove. All uses replaced with similar uses of pI.
3596 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3597 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3598 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3599 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3600 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3601 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3602 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3604 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3605 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3606 * print.c (safe_debug_print, print_object): Likewise.
3607 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3609 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3610 avoiding the 0 flag, which is not portable.
3611 * process.c (Fmake_network_process): Use pI to avoid cast.
3612 * region-cache.c (pp_cache): Likewise.
3613 * xdisp.c (decode_mode_spec): Likewise.
3614 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3615 behavior on 64-bit hosts with printf arg.
3616 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3617 (x_stop_queuing_selection_requests): Likewise.
3618 (x_get_window_property): Don't truncate byte count to an 'int'
3621 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3622 here, since it parses constructs like leading '-' and spaces,
3623 which are not wanted; and it overflows with large numbers.
3624 Instead, simply match F[0-9]+, which is what is wanted anyway.
3626 * alloc.c: Remove unportable assumptions about struct layout.
3627 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3628 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3629 (allocate_vectorlike, make_pure_vector): Use the new macros,
3630 plus offsetof, to remove unportable assumptions about struct layout.
3631 These assumptions hold on all porting targets that I know of, but
3632 they are not guaranteed, they're easy to remove, and removing them
3633 makes further changes easier.
3635 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3636 This doesn't fix a bug but makes the code clearer.
3637 (string_overrun_cookie): Now const. Use initializers that
3638 don't formally overflow signed char, to avoid warnings.
3639 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3640 can cause Emacs to crash when string overrun checking is enabled.
3641 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3642 multiple of sizeof (EMACS_INT); it need not be, if
3643 alignof(EMACS_INT) < sizeof (EMACS_INT).
3644 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3646 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3648 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3650 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3652 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3653 supposed to be handshaking. (Bug#8556)
3654 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3656 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3658 * lisp.h (Qdebug): List symbol.
3659 * eval.c (Qdebug): Restore global linkage.
3660 * keyboard.c (debug-on-event): New variable.
3661 (handle_user_signal): Break into debugger when debug-on-event
3662 matches the current signal symbol.
3664 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3666 * alloc.c (check_sblock, check_string_bytes)
3667 (check_string_free_list): Convert to standard C.
3669 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3671 * w32.c (emacs_gnutls_push): Fix typo.
3673 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3675 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3676 "cast to pointer from integer of different size".
3678 Improve doprnt and its use in verror. (Bug#8545)
3679 * doprnt.c (doprnt): Document the set of format control sequences
3680 supported by the function. Use SAFE_ALLOCA instead of always
3683 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3684 is one byte too soon. Don't use xrealloc; instead xfree and
3687 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3689 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3692 * gnutls.c: Renamed global_initialized to
3693 gnutls_global_initialized. Added internals for the
3694 :verify-hostname-error, :verify-error, and :verify-flags
3695 parameters of `gnutls-boot' and documented those parameters in the
3696 docstring. Start callback support.
3697 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3698 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3699 on error. Return error code.
3700 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3701 (emacs_gnutls_read): Likewise.
3702 (Fgnutls_boot): Return handshake error code.
3703 (emacs_gnutls_handle_error): New function.
3704 (wsaerror_to_errno): Likewise.
3706 * w32.h (emacs_gnutls_pull): Add prototype.
3707 (emacs_gnutls_push): Likewise.
3709 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3710 (emacs_gnutls_push): Likewise.
3712 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3714 * process.c (wait_reading_process_output): Check if GnuTLS
3715 buffered some data internally if no FDs are set for TLS
3718 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3719 (LIBS): Link to USER_LIBS.
3720 ($(BLD)/gnutls.$(0)): New target.
3722 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3724 * xdisp.c (handle_single_display_spec): Rename the
3725 display_replaced_before_p argument into display_replaced_p, to
3726 make it consistent with the commentary. Fix typos in the
3729 * textprop.c (syms_of_textprop): Remove dead code.
3730 (copy_text_properties): Delete obsolete commentary about an
3731 interface that was deleted long ago. Fix typos in the description
3734 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3735 to changes in oldXMenu/XMenu.h from 2011-04-16.
3736 <menu_help_message, prev_menu_help_message>: Constify.
3737 (IT_menu_make_room): menu->help_text is now `const char **';
3740 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3741 to changes in oldXMenu/XMenu.h from 2011-04-16.
3742 (struct XMenu): Declare `help_text' `const char **'.
3744 * xfaces.c <Qunspecified>: Make extern again.
3746 * syntax.c: Include sys/types.h before including regex.h, as
3749 * doc.c (get_doc_string): Improve the format passed to `error'.
3751 * doprnt.c (doprnt): Improve commentary.
3753 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3755 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3758 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3759 changes in globals.h immediately force recompilation.
3760 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3761 $(CURDIR)/s/ms-w32.h.
3762 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3764 * character.c (Fchar_direction): Function deleted.
3765 (syms_of_character): Don't defsubr it.
3766 <char-direction-table>: Deleted.
3768 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3770 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3771 * doprnt.c: Include limits.h.
3772 (SIZE_MAX): New macro.
3773 (doprnt): Return a size_t value. 2nd arg is now size_t.
3774 Many local variables are now size_t instead of int or unsigned.
3775 Improve overflow protection. Support `l' modifier for integer
3776 conversions. Support %l conversion. Don't assume an EMACS_INT
3777 argument for integer conversions and for %c.
3779 * lisp.h (doprnt): Restore prototype.
3781 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3784 * Makefile.in (base_obj): Add back doprnt.o.
3786 * deps.mk (doprnt.o): Add back prerequisites.
3787 (callint.o): Depend on character.h.
3789 * eval.c (internal_lisp_condition_case): Include the handler
3790 representation in the error message.
3791 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3792 when breaking from the loop.
3794 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3796 * callint.c (Fcall_interactively): When displaying error message
3797 about invalid control letter, pass the character's codepoint, not
3798 a pointer to its multibyte form. Improve display of the character
3799 in octal and display also its hex code.
3801 * character.c (char_string): Use %x to display the (unsigned)
3802 codepoint of an invalid character, to avoid displaying a bogus
3805 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3806 `error', not SYMBOL_NAME itself.
3808 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3809 character arguments to `error'.
3811 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3812 to `error' in error message about FINAL_CHAR argument. Make sure
3813 FINAL_CHAR is a character, and use %c when it is passed as
3814 argument to `error'.
3816 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3818 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3820 * w32.c: Include <time.h>.
3821 (sys_localtime): New function.
3823 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3825 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3827 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3829 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3831 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3834 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3836 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3837 gl_state.e_property when gl_state.object is Qt.
3839 * insdel.c (make_gap_larger): Remove limitation of buffer size
3842 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3844 * xdisp.c (lookup_glyphless_char_display)
3845 (produce_glyphless_glyph): Handle cons cell entry in
3846 glyphless-char-display.
3847 (Vglyphless_char_display): Document it.
3849 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3850 glyphless-char-display.
3852 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3854 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3856 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3858 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3859 definition for no-X builds.
3861 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3863 Static checks with GCC 4.6.0 and non-default toolkits.
3865 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3867 * process.c (keyboard_bit_set): Define only if SIGIO.
3868 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3869 (send_process): Repair possible setjmp clobbering.
3871 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3873 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3875 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3877 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3878 Define only if needed.
3880 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3881 by pacifying GCC about it. Maybe it's time to retire it?
3882 * xfaces.c (USG, __TIMEVAL__): Likewise.
3884 * dispextern.h (struct redisplay_interface): Rename param
3886 * termhooks.h (struct terminal): Likewise.
3887 * xterm.c (xembed_send_message): Likewise.
3889 * insdel.c (make_gap_smaller): Define only if
3890 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3892 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3895 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3896 so that we aren't warned about unused symbols.
3898 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3900 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3902 * xfns.c (x_real_positions): Mark locals as initialized.
3904 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3906 * xterm.c: Fix problems found by static analysis with other toolkits.
3907 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3908 (x_dispatch_event): Declare static if USE_GTK, and
3909 define if USE_GTK || USE_X_TOOLKIT.
3910 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3911 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3912 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3913 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3915 * xmenu.c (menu_help_callback): Pointer type fixes.
3916 Use const pointers when pointing at readonly data. Avoid pointer
3918 (FALSE): Remove unused macro.
3919 (update_frame_menubar): Remove unused decl.
3921 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3923 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3924 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3925 (single_menu_item): Rename local to avoid shadowing.
3927 * keyboard.c (make_lispy_event): Remove unused local var.
3929 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3930 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3932 * bitmaps: Change bitmaps from unsigned char back to the X11
3933 compatible char. Avoid the old compiler warnings about
3934 out-of-range initializers by using, for example, '\xab' rather
3937 * xgselect.c (xgselect_initialize): Check vs interface
3938 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3940 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3942 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3943 to read-only memory.
3945 * fns.c (vector): Remove; this old hack is no longer needed.
3947 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3949 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3951 * xrdb.c (x_load_resources): Omit unused local.
3953 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3954 (x_window): Rename locals to avoid shadowing.
3955 (USG): Use the kludged USG macro, to pacify gcc.
3957 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3958 (x_term_init): Remove local to avoid shadowing.
3960 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3962 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3963 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3965 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3967 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3969 Fix regex.c, syntax.c and friends for buffers > 2GB.
3970 * syntax.h (struct gl_state_s): Declare character position members
3973 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3975 * textprop.c (verify_interval_modification, interval_of):
3976 Declare arguments EMACS_INT.
3978 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3981 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3983 * indent.c (Fvertical_motion): Local variable it_start is now
3986 * regex.c (re_match, re_match_2, re_match_2_internal)
3987 (bcmp_translate, regcomp, regexec, print_double_string)
3988 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3989 (re_compile_pattern, re_exec): Declare arguments and local
3990 variables `size_t' and `ssize_t' and return values `regoff_t', as
3992 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3993 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3994 <compile_stack_type>: `size' and `avail' are now `size_t'.
3996 * regex.h <regoff_t>: Use ssize_t, not int.
3997 (re_search, re_search_2, re_match, re_match_2): Arguments that
3998 specify buffer/string position and length are now ssize_t and
3999 size_t. Return type is regoff_t.
4001 2011-04-16 Ben Key <bkey76@gmail.com>
4003 * nsfont.m: Fixed bugs in ns_get_family and
4004 ns_descriptor_to_entity that were caused by using free to
4005 deallocate memory blocks that were allocated by xmalloc (via
4006 xstrdup). This caused Emacs to crash when compiled with
4007 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4008 --enable-checking=xmallocoverrun). xfree is now used to
4009 deallocate these memory blocks.
4011 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4013 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4015 emacs_write: Accept and return EMACS_INT for sizes.
4016 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4018 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4019 Accept and return EMACS_INT.
4020 (emacs_gnutls_write): Return the number of bytes written on
4022 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4023 (emacs_read, emacs_write): Remove check for negative size, as the
4024 Emacs source code has been audited now.
4025 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4026 (emacs_read, emacs_write): Use it.
4027 * process.c (send_process): Adjust to the new signatures of
4028 emacs_write and emacs_gnutls_write. Do not attempt to store
4029 a byte offset into an 'int'; it might overflow.
4030 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4032 * sound.c: Don't assume sizes fit in 'int'.
4033 (struct sound_device.period_size, alsa_period_size):
4034 Return EMACS_INT, not int.
4035 (struct sound_device.write, vox_write, alsa_write):
4036 Accept EMACS_INT, not int.
4037 (wav_play, au_play): Use EMACS_INT to store sizes and to
4038 record read return values.
4040 2011-04-15 Ben Key <bkey76@gmail.com>
4042 * keyboard.c (Qundefined): Don't declare static since it is used
4044 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4045 static since they are used in nsfont.m.
4047 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4049 * process.c (Qprocessp): Don't declare static.
4050 * lisp.h (Qprocessp): Declare again.
4052 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4054 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4056 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4058 Improve C-level modularity by making more things 'static'.
4060 Don't publish debugger-only interfaces to other modules.
4061 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4062 (verify_bytepos, count_markers): Move decls to the only modules
4064 * region-cache.h (pp_cache): Likewise.
4065 * window.h (check_all_windows): Likewise.
4066 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4068 * sysdep.c (croak): Now static, if
4069 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4070 * syssignal.h (croak): Declare only if not static.
4072 * alloc.c (refill_memory_reserve): Now static if
4073 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4074 * lisp.h (refill_memory_reserve): Declare only if not static.
4076 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4077 Define only if USE_LUCID.
4079 * xrdb.c (x_customization_string, x_rm_string): Now static.
4081 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4082 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4084 * xdisp.c (draw_row_with_mouse_face): Now static.
4085 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4087 * window.h (check_all_windows): Mark externally visible.
4089 * window.c (window_deletion_count): Now static.
4091 * undo.c: Make symbols static if they're not exported.
4092 (last_undo_buffer, last_boundary_position, pending_boundary):
4095 * textprop.c (interval_insert_behind_hooks): Now static.
4096 (interval_insert_in_front_hooks): Likewise.
4098 * term.c: Make symbols static if they're not exported.
4099 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4100 (max_frame_lines, tty_set_terminal_modes):
4101 (tty_reset_terminal_modes, tty_turn_off_highlight):
4102 (get_tty_terminal): Now static.
4103 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4104 * termhooks.h (term_mouse_moveto): Do not declare if
4106 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4107 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4109 * sysdep.c: Make symbols static if they're not exported.
4110 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4112 (sigprocmask_set, full_mask): Remove; unused.
4113 (wait_debugging): Mark as visible.
4114 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4115 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4117 * syntax.c (syntax_temp): Define only if !__GNUC__.
4119 * sound.c (current_sound_device, current_sound): Now static.
4121 * search.c (searchbufs, searchbuf_head): Now static.
4123 * scroll.c (scroll_cost): Remove; unused.
4124 * dispextern.h (scroll_cost): Remove decl.
4126 * region-cache.h (pp_cache): Mark as externally visible.
4128 * process.c: Make symbols static if they're not exported.
4129 (process_tick, update_tick, create_process, chan_process):
4130 (Vprocess_alist, proc_buffered_char, datagram_access):
4131 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4132 (deactivate_process): Mark defn as static, as well as decl.
4133 * lisp.h (create_process): Remove decl.
4134 * process.h (chan_process, Vprocess_alist): Remove decls.
4136 * print.c: Make symbols static if they're not exported.
4137 (print_depth, new_backquote_output, being_printed, print_buffer):
4138 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4139 (print_interval, print_number_index, initial_stderr_stream):
4141 * lisp.h (Fprinc): Remove decl.
4142 (debug_output_compilation_hack): Mark as externally visible.
4144 * sysdep.c (croak): Move decl from here to syssignal.h.
4145 * syssignal.h (croak): Put it here, so the API can be checked when
4146 'croak' is called from dissociate_if_controlling_tty.
4148 * minibuf.c: Make symbols static if they're not exported.
4149 (minibuf_save_list, choose_minibuf_frame): Now static.
4150 * lisp.h (choose_minibuf_frame): Remove decl.
4152 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4154 * lread.c: Make symbols static if they're not exported.
4155 (read_objects, initial_obarray, oblookup_last_bucket_number):
4157 (make_symbol): Remove; unused.
4158 * lisp.h (initial_obarray, make_symbol): Remove decls.
4160 * keyboard.c: Make symbols static if they're not exported.
4161 (single_kboard, recent_keys_index, total_keys, recent_keys):
4162 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4163 (this_single_command_key_start, echoing, last_auto_save):
4164 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4165 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4166 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4167 (Vlispy_mouse_stem, double_click_count):
4169 (force_auto_save_soon): Define only if SIGDANGER.
4170 (ignore_mouse_drag_p): Now static if
4171 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4172 (print_help): Remove; unused.
4173 (stop_character, last_timer_event): Mark as externally visible.
4174 * keyboard.h (ignore_mouse_drag_p): Declare only if
4175 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4176 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4177 * lisp.h (echoing): Remove decl.
4178 (force_auto_save_soon): Declare only if SIGDANGER.
4179 * xdisp.c (redisplay_window): Simplify code, to make it more
4180 obvious that ignore_mouse_drag_p is not accessed if !defined
4181 USE_GTK && !defined HAVE_NS.
4183 * intervals.c: Make symbols static if they're not exported.
4184 (merge_properties_sticky, merge_interval_right, delete_interval):
4186 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4188 * insdel.c: Make symbols static if they're not exported.
4189 However, leave prepare_to_modify_buffer alone. It's never
4190 called from outside this function, but that appears to be a bug.
4191 (combine_after_change_list, combine_after_change_buffer):
4192 (adjust_after_replace, signal_before_change): Now static.
4193 (adjust_after_replace_noundo): Remove; unused.
4194 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4195 (signal_before_change): Remove decls.
4197 * indent.c (val_compute_motion, val_vmotion): Now static.
4199 * image.c: Make symbols static if they're not exported.
4200 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4202 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4203 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4205 * fringe.c (standard_bitmaps): Now static.
4206 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4208 * frame.c: Make symbols static if they're not exported.
4209 (x_report_frame_params, make_terminal_frame): Now static.
4210 (get_frame_param): Now static, unless HAVE_NS.
4211 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4212 (x_get_resource_string): Remove; not used.
4213 * frame.h (make_terminal_frame, x_report_frame_params):
4214 (x_get_resource_string); Remove decls.
4215 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4216 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4218 * font.c, fontset.c: Make symbols static if they're not exported.
4219 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4220 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4221 * font.c (font_close_object): Now static.
4222 * font.h (font_close_object): Remove.
4223 * fontset.c (FONTSET_OBJLIST): Remove.
4224 (free_realized_fontset) #if-0 the body, which does nothing.
4225 (face_suitable_for_char_p): #if-0, as it's never called.
4226 * fontset.h (face_suitable_for_char_p): Remove decl.
4227 * xfaces.c (face_at_string_position):
4228 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4229 since 0 is always ASCII.
4231 * fns.c (weak_hash_tables): Now static.
4233 * fileio.c: Make symbols static if they're not exported.
4234 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4235 (Vwrite_region_annotation_buffers): Now static.
4237 * eval.c: Make symbols static if they're not exported.
4238 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4239 * lisp.h (backtrace_list): Remove decl.
4241 * emacs.c: Make symbols static if they're not exported.
4242 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4243 (fatal_error_code, fatal_error_signal_hook, standard_args):
4245 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4246 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4247 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4248 * lisp.h (fatal_error_signal_hook): Remove decl.
4249 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4251 * editfns.c: Move a (normally-unused) function to its only use.
4252 * editfns.c, lisp.h (get_operating_system_release): Remove.
4253 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4254 worth the hassle of breaking this out.
4256 * xterm.c: Make symbols static if they're not exported.
4257 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4258 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4259 (x_destroy_window, x_delete_display):
4261 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4262 (x_mouse_leave): Remove; unused.
4263 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4264 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4265 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4267 (x_mouse_leave): Declare only if WINDOWSNT.
4268 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4269 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4272 * ftxfont.c: Make symbols static if they're not exported.
4273 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4275 * font.h (ftxfont_driver): Likewise.
4277 * xfns.c: Make symbols static if they're not exported.
4278 (x_last_font_name, x_display_info_for_name):
4279 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4280 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4281 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4282 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4283 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4284 (last_show_tip_args): Now static.
4285 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4286 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4287 (x_screen_planes): Remove; unused.
4288 * dispextern.h (x_screen_planes): Remove decl.
4290 * dispnew.c: Make symbols static if they're not exported.
4291 * dispextern.h (redraw_garbaged_frames, scrolling):
4292 (increment_row_positions): Remove.
4293 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4294 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4296 (redraw_garbaged_frames): Remove; unused.
4298 * xfaces.c: Make symbols static if they're not exported.
4299 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4301 * xterm.h (defined_color): Remove decls.
4302 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4303 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4304 (menu_face_changed_default, defined_color, free_realized_face):
4305 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4306 (ascii_face_of_lisp_face): Remove; unused.
4308 * xdisp.c: Make symbols static if they're not exported.
4309 * dispextern.h (scratch_glyph_row, window_box_edges):
4310 (glyph_to_pixel_coords, set_cursor_from_row):
4311 (get_next_display_element, set_iterator_to_next):
4312 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4313 (show_mouse_face): Remove decls
4314 * frame.h (message_buf_print): Likewise.
4315 * lisp.h (pop_message, set_message, check_point_in_composition):
4317 * xterm.h (set_vertical_scroll_bar): Likewise.
4318 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4319 (message_buf_print, scratch_glyph_row, displayed_buffer):
4320 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4321 (get_next_display_element, show_mouse_face, window_box_edges):
4322 (frame_to_window_pixel_xy, check_point_in_composition):
4323 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4324 (glyph_to_pixel_coords): Remove; unused.
4326 * dired.c (file_name_completion): Now static.
4328 * dbusbind.c (xd_in_read_queued_messages): Now static.
4330 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4331 * data.c (circular_list_error): Remove.
4333 * commands.h (last_point_position, last_point_position_buffer):
4334 (last_point_position_window): Remove decls.
4335 * keyboard.c: Make these variables static.
4337 * coding.h (coding, code_convert_region, encode_coding_gap):
4339 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4340 (iso_code_class, detect_coding, code_convert_region): Now static.
4341 (encode_coding_gap): Remove; unused.
4343 * chartab.c (chartab_chars, chartab_bits): Now static.
4345 * charset.h (charset_iso_8859_1): Remove decl.
4346 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4349 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4350 * ccl.c (Vccl_program_table): Now static.
4351 (check_ccl_update): Remove; unused.
4353 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4354 * category.h: ... from here.
4355 * category.c (check_category_table, set_category_set): Now static.
4357 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4358 * lisp.h: Remove these decls.
4360 * buffer.c (buffer_count): Remove unused var.
4362 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4363 so that it's not optimized away.
4364 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4365 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4366 exported only to the debugger.
4368 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4369 * atimer.h (run_all_atimers): Remove; not exported.
4371 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4372 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4373 was inaccessible from Lisp.
4374 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4375 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4377 alloc.c: Import and export fewer symbols, and remove unused items.
4378 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4380 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4381 it's not optimized away by whole-program optimization.
4382 (message_enable_multibyte, free_misc): Remove.
4383 (catchlist, handlerlist, mark_backtrace):
4384 Declare only if BYTE_MARK_STACK.
4385 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4386 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4387 (message_enable_multibyte): Remove decl.
4388 (free_misc, interval_free_list, float_block, float_block_index):
4389 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4390 (cons_free_list, last_marked_index):
4392 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4393 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4394 (mark_backtrace): Define only if BYTE_MARK_STACK.
4395 * xdisp.c (message_enable_multibyte): Now static.
4397 Declare Lisp_Object Q* variables to be 'static' if not exported.
4398 This makes it easier for human readers (and static analyzers)
4399 to see whether these variables are used from other modules.
4400 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4401 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4402 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4403 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4404 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4405 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4406 * xmenu.c, xselect.c:
4407 Declare Q* vars static if they are not used in other modules.
4408 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4409 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4410 Remove decls of unexported vars.
4411 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4413 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4415 Make Emacs functions such as Fatom 'static' by default.
4416 This makes it easier for human readers (and static analyzers)
4417 to see whether these functions can be called from other modules.
4418 DEFUN now defines a static function. To make the function external
4419 so that it can be used in other C modules, use the new macro DEFUE.
4420 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4421 (Finit_image_library):
4422 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4423 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4424 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4425 Remove decls, since these functions are now static.
4426 (Funintern, Fget_internal_run_time): New decls, since these functions
4427 were already external.
4429 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4430 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4431 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4432 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4433 * keyboard.c, keymap.c, lread.c:
4434 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4435 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4436 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4437 Mark functions with DEFUE instead of DEFUN,
4438 if they are used in other modules.
4439 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4440 decls for now-static functions.
4441 * buffer.h (Fdelete_overlay): Remove decl.
4442 * callproc.c (Fgetenv_internal): Mark as internal.
4443 * composite.c (Fremove_list_of_text_properties): Remove decl.
4444 (Fcomposition_get_gstring): New forward static decl.
4445 * composite.h (Fcomposite_get_gstring): Remove decl.
4446 * dired.c (Ffile_attributes): New forward static decl.
4447 * doc.c (Fdocumntation_property): New forward static decl.
4448 * eval.c (Ffetch_bytecode): New forward static decl.
4449 (Funintern): Remove extern decl; now in .h file where it belongs.
4450 * fileio.c (Fmake_symbolic_link): New forward static decl.
4451 * image.c (Finit_image_library): New forward static decl.
4452 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4453 * intervals.h (Fprevious_property_change):
4454 (Fremove_list_of_text_properties): Remove decls.
4455 * keyboard.c (Fthis_command_keys): Remove decl.
4456 (Fcommand_execute): New forward static decl.
4457 * keymap.c (Flookup_key): New forward static decl.
4458 (Fcopy_keymap): Now static.
4459 * keymap.h (Flookup_key): Remove decl.
4460 * process.c (Fget_process): New forward static decl.
4461 (Fprocess_datagram_address): Mark as internal.
4462 * syntax.c (Fsyntax_table_p): New forward static decl.
4463 (skip_chars): Remove duplicate decl.
4464 * textprop.c (Fprevious_property_change): New forward static decl.
4465 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4467 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4468 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4470 * editfns.c (Fformat): Remove unreachable code.
4472 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4474 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4477 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4479 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4480 when at ZV. (Bug#8487)
4482 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4484 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4486 * keyboard.c (parse_tool_bar_item): Likewise.
4487 * sound.c (sound_cleanup, alsa_close): Likewise.
4488 * termcap.c (tgetent): Likewise.
4489 * xfns.c (x_default_font_parameter): Likewise.
4490 * xsettings.c (read_and_apply_settings): Likewise.
4492 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4493 (overrun_check_free): Protoize.
4495 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4497 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4498 since callers should never pass a negative size.
4499 Change the signature to match that of plain 'read' and 'write'; see
4500 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4501 * lisp.h: Update prototypes of emacs_write and emacs_read.
4503 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4505 * xdisp.c (redisplay_window): Don't try to determine the character
4506 position of the scroll margin if the window start point w->startp
4507 is outside the buffer's accessible region. (Bug#8468)
4509 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4511 Fix write-region and its subroutines for buffers > 2GB.
4512 * fileio.c (a_write, e_write): Modify declaration of arguments and
4513 local variables to support buffers larger than 2GB.
4514 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4516 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4517 argument, local variables, and return value.
4519 * lisp.h: Update prototypes of emacs_write and emacs_read.
4521 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4523 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4525 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4527 Fix more problems found by GCC 4.6.0's static checks.
4529 * xdisp.c (vmessage): Use a better test for character truncation.
4531 * charset.c (load_charset_map): <, not <=, for optimization,
4532 and to avoid potential problems with integer overflow.
4533 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4534 * casetab.c (set_identity, shuffle): Likewise.
4535 * editfns.c (Fformat): Likewise.
4536 * syntax.c (skip_chars): Likewise.
4538 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4539 This also lets GCC 4.6.0 generate slightly better loop code.
4541 * callint.c (Fcall_interactively): <, not <=, for optimization.
4542 (Fcall_interactively): Count the number of arguments produced,
4543 not the number of arguments given. This is simpler and lets GCC
4544 4.6.0 generate slightly better code.
4546 * ftfont.c: Distingish more carefully between FcChar8 and char.
4547 The previous code passed unsigned char * to a functions like
4548 strlen and xstrcasecmp that expect char *, which does not
4549 conform to the C standard.
4550 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4551 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4552 char * when the C standard requires it.
4554 * keyboard.c (read_char): Remove unused var.
4556 * eval.c: Port to Windows vsnprintf (Bug#8435).
4558 (SIZE_MAX): Define if the headers do not.
4559 (verror): Do not give up if vsnprintf returns a negative count.
4560 Instead, grow the buffer. This ports to Windows vsnprintf, which
4561 does not conform to C99. Problem reported by Eli Zaretskii.
4562 Also, simplify the allocation scheme, by avoiding the need for
4563 calling realloc, and removing the ALLOCATED variable.
4565 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4567 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4568 But keep the doprint source code for now, as we might revamp it
4569 and use it again (Bug#8435).
4570 * lisp.h (doprnt): Remove.
4571 * Makefile.in (base_obj): Remove doprnt.o.
4572 * deps.mk (doprnt.o): Remove.
4574 error: Print 32- and 64-bit integers portably (Bug#8435).
4575 Without this change, on typical 64-bit hosts error ("...%d...", N)
4576 was used to print both 32- and 64-bit integers N, which relied on
4578 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4580 * lisp.h (error, verror): Mark as printf-like functions.
4581 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4582 Report overflow in size calculations when allocating printf buffer.
4583 Do not truncate output string at its first null byte.
4584 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4585 Truncate the output at a character boundary, since vsnprintf does not
4587 * charset.c (check_iso_charset_parameter): Convert internal
4588 character to string before calling 'error', since %c now has the
4590 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4591 overflow when computing char to be passed to 'error'. Do not
4592 pass Lisp_Object to 'error'; pass the integer instead.
4593 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4594 formatted with plain %d.
4596 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4598 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4600 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4602 * xterm.c (x_catch_errors): Remove duplicate declaration.
4604 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4606 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4608 2011-04-10 Jim Meyering <meyering@redhat.com>
4610 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4611 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4612 return ssize_t not "int", and use size_t as the buffer length.
4613 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4614 * gnutls.h: Update declarations.
4615 * process.c (read_process_output): Use ssize_t, to match.
4616 (send_process): Likewise.
4618 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4620 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4622 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4624 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4625 Use unsigned char, to match FcChar8 type definition.
4627 * xterm.c (handle_one_xevent):
4628 * xmenu.c (create_and_show_popup_menu):
4629 * xselect.c (x_decline_selection_request)
4630 (x_reply_selection_request): Avoid type-punned deref of X events.
4632 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4634 Fix some uses of `int' instead of EMACS_INT.
4635 * search.c (string_match_1, fast_string_match)
4636 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4637 (scan_buffer, find_next_newline_no_quit)
4638 (find_before_next_newline, search_command, Freplace_match)
4639 (Fmatch_data): Make some `int' variables be EMACS_INT.
4641 * xdisp.c (display_count_lines): 3rd argument and return value now
4642 EMACS_INT. All callers changed.
4643 (pint2hrstr): Last argument is now EMACS_INT.
4645 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4646 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4647 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4648 (decode_coding_utf_16, decode_coding_emacs_mule)
4649 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4650 (decode_coding_ccl, decode_coding_charset)
4651 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4652 (decode_coding_iso_2022, decode_coding_emacs_mule)
4653 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4654 <char_offset, last_offset>: Declare EMACS_INT.
4655 (encode_coding_utf_8, encode_coding_utf_16)
4656 (encode_coding_emacs_mule, encode_invocation_designation)
4657 (encode_designation_at_bol, encode_coding_iso_2022)
4658 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4659 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4661 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4662 (encode_invocation_designation): Last argument P_NCHARS is now
4664 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4665 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4667 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4670 * ccl.c (Fccl_execute_on_string): Declare some variables
4673 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4675 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4677 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4679 * process.c (Fformat_network_address): Doc fix.
4681 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4683 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4685 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4687 * keyboard.c (read_char): Call Lisp function help-form-show,
4688 instead of using internal_with_output_to_temp_buffer.
4689 (Qhelp_form_show): New var.
4690 (syms_of_keyboard): Use DEFSYM macro.
4692 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4694 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4696 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4698 * process.c (Flist_processes): Remove to Lisp.
4699 (list_processes_1): Delete.
4701 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4703 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4705 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4707 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4709 Fix more problems found by GCC 4.6.0's static checks.
4711 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4713 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4715 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4717 * xdisp.c (vmessage): Mark as a printf-like function.
4719 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4721 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4723 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4724 printf-like functions.
4725 (tiff_load): Add casts to remove these marks before passing them
4726 to system-supplied API.
4728 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4730 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4731 This avoids several warnings with gcc -Wstrict-overflow.
4732 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4733 directly, rather than having caller test rule sign. This avoids
4734 some unnecessary tests.
4735 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4736 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4737 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4739 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4740 (xfont_open): Avoid unnecessary tests.
4742 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4744 * composite.h, composite.c (composition_gstring_put_cache):
4745 Use EMACS_INT, not int, for length.
4747 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4748 breaking out part of COMPOSITION_DECODE_RULE.
4749 (COMPOSITION_DECODE_RULE): Use it.
4750 * composite.c (get_composition_id): Remove unused local vars,
4751 by using the new macro.
4753 * textprop.c (set_text_properties_1): Change while to do-while,
4754 since the condition is always true at first.
4756 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4757 (interval_deletion_adjustment): Return unsigned value.
4760 * process.c (list_processes_1, create_pty, read_process_output):
4761 (exec_sentinel): Remove vars that were set but not used.
4762 (create_pty): Remove unnecessary "volatile"s.
4763 (Fnetwork_interface_info): Avoid possibility of int overflow.
4764 (read_process_output): Do adaptive read buffering even if carryover.
4765 (read_process_output): Simplify nbytes computation if buffered.
4767 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4769 * syntax.c (scan_words): Remove var that was set but not used.
4770 (update_syntax_table): Use unsigned instead of int.
4772 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4773 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4774 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4776 * print.c (print_error_message): Avoid int overflow.
4778 * font.c (font_list_entities): Redo for clarity,
4779 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4781 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4782 (font_score): Avoid potential overflow in diff calculation.
4784 * fns.c (substring_both): Remove var that is set but not used.
4785 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4787 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4789 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4790 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4791 can always succeed if overflow has undefined behavior.
4793 * search.c (boyer_moore, wordify): Remove vars set but not used.
4794 (wordify): Omit three unnecessary tests.
4796 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4797 All callers changed. This avoids the need for an unused var.
4799 * casefiddle.c (casify_region): Remove var that is set but not used.
4801 * dired.c (file_name_completion): Remove var that is set but not used.
4803 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4805 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4806 (Finsert_file_contents): Remove unnecessary code checking fd.
4808 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4809 Check for integer overflow on size calculations.
4811 * buffer.c (Fprevious_overlay_change): Remove var that is set
4814 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4815 Remove vars that are set but not used.
4816 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4817 (timer_check_2): Mark vars as initialized.
4819 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4821 * image.c (lookup_image): Remove var that is set but not used.
4822 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4824 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4825 that are set but not used.
4827 * xfns.c (make_invisible_cursor): Don't return garbage
4828 if XCreateBitmapFromData fails (Bug#8410).
4830 * xselect.c (x_get_local_selection, x_handle_property_notify):
4831 Remove vars that are set but not used.
4833 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4834 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4836 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4837 Remove var that is set but not used.
4838 (scroll_bar_windows_size): Now size_t, not int.
4839 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4842 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4843 (map_tty_color) [!defined MSDOS]: Likewise.
4845 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4847 * coding.c: Remove vars that are set but not used.
4848 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4849 All callers changed.
4850 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4851 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4852 (decode_coding_charset): Remove vars that are set but not used.
4854 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4855 that is set but not used.
4857 * print.c (print_object): Remove var that is set but not used.
4859 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4860 The gnulib version avoids calling malloc in the usual case,
4861 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4862 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4863 * filelock.c (current_lock_owner): Likewise.
4864 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4865 * sysdep.c: Include allocator.h, careadlinkat.h.
4866 (emacs_no_realloc_allocator): New static constant.
4867 (emacs_readlink): New function.
4868 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4869 ../lib/careadlinkat.h.
4871 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4873 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4874 first non-nil return value).
4876 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4878 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4879 if not defined (Bug#8403).
4881 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4883 * xdisp.c (display_count_lines): Remove parameter `start',
4884 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4885 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4886 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4887 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4888 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4889 and thereabouts. All callers changed.
4890 (get_per_char_metric): Remove parameter `f', unused since
4891 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4893 2011-04-02 Jim Meyering <meyering@redhat.com>
4895 do not dereference NULL upon failed strdup
4896 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4897 (ns_get_family): Likewise.
4899 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4901 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4903 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4905 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4908 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4910 Add lexical binding.
4912 * window.c (Ftemp_output_buffer_show): New fun.
4913 (Fsave_window_excursion):
4914 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4916 * lread.c (lisp_file_lexically_bound_p): New function.
4917 (Fload): Bind Qlexical_binding.
4918 (readevalloop): Remove `evalfun' arg.
4919 Bind Qinternal_interpreter_environment.
4920 (Feval_buffer): Bind Qlexical_binding.
4921 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4923 (syms_of_lread): Declare `lexical-binding'.
4925 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4927 * keyboard.c (eval_dyn): New fun.
4928 (menu_item_eval_property): Use it.
4930 * image.c (parse_image_spec): Use Ffunctionp.
4932 * fns.c (concat, mapcar1): Accept byte-code-functions.
4934 * eval.c (Fsetq): Handle lexical vars.
4935 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4936 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4937 (FletX, Flet): Obey lexical binding.
4938 (Fcommandp): Handle closures.
4939 (Feval): New `lexical' arg.
4940 (eval_sub): New function extracted from Feval. Use it almost
4941 everywhere where Feval was used. Look up vars in lexical env.
4943 (Ffunctionp): Move from subr.el.
4944 (Ffuncall): Handle closures.
4945 (apply_lambda): Remove `eval_flags'.
4946 (funcall_lambda): Handle closures and new byte-code-functions.
4947 (Fspecial_variable_p): New function.
4948 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4949 but without exporting it to Lisp.
4951 * doc.c (Fdocumentation, store_function_docstring):
4952 * data.c (Finteractive_form): Handle closures.
4954 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4957 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4959 (exec_byte_code): New function extracted from Fbyte_code to handle new
4960 calling convention for byte-code-functions. Add new byte-codes.
4962 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4964 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4966 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4968 * xdisp.c (redisplay_internal): Fix prototype.
4970 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4972 * xdisp.c (SCROLL_LIMIT): New macro.
4973 (try_scrolling): Use it when setting scroll_limit.
4974 Limit scrolling to 100 screen lines.
4975 (redisplay_window): Even when falling back on "recentering",
4976 position point in the window according to scroll-conservatively,
4977 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4979 (try_scrolling): When point is above the window, allow searching
4980 as far as scroll_max, or one screenful, to compute vertical
4981 distance from PT to the scroll margin position. This prevents
4982 try_scrolling from unnecessarily failing when
4983 scroll-conservatively is set to a value slightly larger than the
4984 window height. Clean up the case of PT below the margin at bottom
4985 of window: scroll_max can no longer be INT_MAX. When aggressive
4986 scrolling is in use, don't let point enter the opposite scroll
4987 margin as result of the scroll.
4988 (syms_of_xdisp) <scroll-conservatively>: Document the
4989 threshold of 100 lines for never-recentering scrolling.
4991 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4993 * dispextern.h (move_it_by_lines):
4994 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4995 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4996 (message_log_check_duplicate): Remove parameters `prev_bol' and
4997 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4998 (redisplay_internal): Remove parameter `preserve_echo_area',
4999 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5001 * indent.c (Fvertical_motion):
5002 * window.c (window_scroll_pixel_based, Frecenter):
5003 Don't pass `need_y_p' to `move_it_by_lines'.
5005 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5007 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5008 steal a few bits to be more compact.
5009 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5010 Remove unneeded casts.
5012 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5014 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5016 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5017 binding" message (bug#7967).
5019 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5021 Fix more problems found by GCC 4.6.0's static checks.
5023 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5024 Remove unused local var.
5026 * editfns.c (Fmessage_box): Remove unused local var.
5028 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5029 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5030 Omit unused local vars.
5031 * window.c (shrink_windows): Omit unused local var.
5032 * menu.c (digest_single_submenu): Omit unused local var.
5033 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5034 Omit unused local var.
5036 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5037 Don't assume string length fits in int.
5038 (keyremap_step, read_key_sequence): Use size_t for sizes.
5039 (read_key_sequence): Don't check last_real_key_start redundantly.
5041 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5042 instead of alloca (Bug#8344).
5044 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5045 (Fbacktrace_frame): Don't assume nframes fits in int.
5047 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5049 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5052 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5054 * cm.c (calccost): Turn while-do into do-while, for clarity.
5056 * keyboard.c (syms_of_keyboard): Use the same style as later
5057 in this function when indexing through an array. This also
5058 works around GCC bug 48267.
5060 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5062 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5064 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5065 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5067 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5068 This avoids undefined behavior on integer overflow, and is a bit
5069 more convenient anyway since it is compared to a size_t variable.
5071 Variadic C functions now count arguments with size_t, not int.
5072 This avoids an unnecessary limitation on 64-bit machines, which
5073 caused (substring ...) to crash on large vectors (Bug#8344).
5074 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5075 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5076 All variadic functions and their callers changed accordingly.
5077 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5078 * data.c (arith_driver, float_arith_driver): Likewise.
5079 * editfns.c (general_insert_function): Likewise.
5080 * eval.c (struct backtrace.nargs, interactive_p)
5081 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5082 (funcall_lambda, mark_backtrace): Likewise.
5083 * fns.c (concat): Likewise.
5084 * frame.c (x_set_frame_parameters): Likewise.
5085 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5086 0 if not found, not -1. All callers changed.
5088 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5089 (stack_copy_size): Now size_t, not int.
5090 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5092 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5094 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5095 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5096 All callers changed.
5098 * lisp.h (multibyte_char_to_unibyte):
5099 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5100 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5101 * character.h (CHAR_TO_BYTE8):
5102 * cmds.c (internal_self_insert):
5103 * editfns.c (general_insert_function):
5104 * keymap.c (push_key_description):
5105 * search.c (Freplace_match):
5106 * xdisp.c (message_dolog, set_message_1): All callers changed.
5108 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5110 * keyboard.c (safe_run_hook_funcall): New function.
5111 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5112 don't set the hook to nil, but remove the offending function instead.
5113 (Qcommand_hook_internal): Remove, unused.
5114 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5115 Vcommand_hook_internal.
5117 * eval.c (enum run_hooks_condition): Remove.
5118 (funcall_nil, funcall_not): New functions.
5119 (run_hook_with_args): Call each function through a `funcall' argument.
5120 Remove `cond' argument, now redundant.
5121 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5122 (Frun_hook_with_args_until_failure): Adjust accordingly.
5123 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5125 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5127 * dispextern.h (string_buffer_position): Remove declaration.
5129 * print.c (strout): Remove parameter `multibyte', unused since
5130 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5132 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5133 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5134 All callers changed.
5136 * w32.c (_wsa_errlist): Use braces for struct initializers.
5138 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5139 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5140 All callers changed.
5141 (string_buffer_position): Likewise. Also, make static (it's never
5142 used outside xdisp.c).
5143 (cursor_row_p): Remove parameter `w', unused since
5144 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5145 (decode_mode_spec): Remove parameter `precision', introduced during
5146 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5147 All callers changed.
5149 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5151 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5153 2011-03-27 Anders Lindgren <andlind@gmail.com>
5155 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5156 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5157 (ns_update_auto_hide_menu_bar): New functions.
5158 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5159 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5160 ns_constrain_all_frames.
5161 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5162 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5164 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5166 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5168 2011-03-27 Glenn Morris <rgm@gnu.org>
5170 * syssignal.h: Replace RETSIGTYPE with void.
5171 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5172 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5173 Replace SIGTYPE with void everywhere.
5174 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5175 * s/template.h (SIGTYPE): Remove commented out definition.
5177 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5179 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5180 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5182 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5184 * w32.c (read_unc_volume): Use parameter `henum', instead of
5185 global variable `wget_enum_handle'.
5187 * keymap.c (describe_vector): Remove parameters `indices' and
5188 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5189 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5191 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5193 * keyboard.c (timer_check): Remove parameter `do_it_now',
5194 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5195 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5196 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5198 * keyboard.c (read_char):
5199 * w32menu.c (w32_menu_display_help):
5200 * xmenu.c (show_help_event, menu_help_callback):
5201 Adjust calls to `show_help_echo'.
5203 * gtkutil.c (xg_maybe_add_timer):
5204 * keyboard.c (readable_events):
5205 * process.c (wait_reading_process_output):
5206 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5208 * insdel.c (adjust_markers_gap_motion):
5209 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5210 (gap_left, gap_right): Don't call it.
5212 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5214 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5215 incurred during fontification.
5217 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5219 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5220 (DEFVAR_PER_BUFFER): Don't pass it.
5222 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5223 (scrolling_window): Don't pass it.
5225 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5227 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5229 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5231 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5232 of variables specific to SELinux and computation of `encoded_absname'.
5234 * image.c (XPutPixel): Remove unused variable `height'.
5236 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5238 * unexw32.c (get_section_info): Remove unused variable `section'.
5240 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5241 (system_process_attributes): Remove unused variable `sess'.
5242 (sys_read): Remove unused variable `err'.
5244 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5245 (w32_wnd_proc): Remove unused variable `isdead'.
5246 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5247 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5248 (x_create_tip_frame): Remove unused variable `tem'.
5250 * w32inevt.c (w32_console_read_socket):
5251 Remove unused variable `no_events'.
5253 * w32term.c (x_draw_composite_glyph_string_foreground):
5254 Remove unused variable `width'.
5256 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5258 * w32term.c (x_set_glyph_string_clipping):
5259 Don't pass uninitialized region to CombineRgn.
5261 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5263 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5264 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5265 (Fx_close_connection): Remove unused variable `i'.
5267 * w32font.c (w32font_draw): Return number of glyphs.
5268 (w32font_open_internal): Remove unused variable `i'.
5269 (w32font_driver): Add missing initializer.
5271 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5272 (fill_in_menu): Remove unused variable `items_added'.
5274 * w32term.c (last_mouse_press_frame): Remove static global variable.
5275 (w32_clip_to_row): Remove unused variable `f'.
5276 (x_delete_terminal): Remove unused variable `i'.
5278 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5279 (NOTHING): Remove unused static global variable.
5280 (uniscribe_check_otf): Remove unused variable `table'.
5281 (uniscribe_font_driver): Add missing initializers.
5283 2011-03-23 Julien Danjou <julien@danjou.info>
5285 * term.c (Fsuspend_tty, Fresume_tty):
5286 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5287 * window.c (temp_output_buffer_show):
5288 * insdel.c (signal_before_change):
5289 * frame.c (Fhandle_switch_frame):
5290 * fileio.c (Fdo_auto_save):
5291 * emacs.c (Fkill_emacs):
5292 * editfns.c (save_excursion_restore):
5293 * cmds.c (internal_self_insert):
5294 * callint.c (Fcall_interactively):
5295 * buffer.c (Fkill_all_local_variables):
5296 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5298 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5299 unconditionnaly since it does the check itself.
5301 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5303 Fix more problems found by GCC 4.5.2's static checks.
5305 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5306 the first time through the loop, since we know p0 < p1 then.
5307 This also avoids a gcc -Wstrict-overflow warning.
5309 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5310 leading to a memory leak, possible in functions like
5311 load_charset_map_from_file that can allocate an unbounded number
5312 of objects (Bug#8318).
5314 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5315 that could (at least in theory) be that large.
5317 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5318 This is less likely to overflow, and avoids undefined behavior if
5319 overflow does occur. All callers changed. Use strtoul to scan
5320 for the unsigned long integer.
5321 (pint2hrstr): Simplify and tune code slightly.
5322 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5324 * scroll.c (do_scrolling): Work around GCC bug 48228.
5325 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5327 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5328 This also avoids a warning with gcc -Wstrict-overflow.
5329 (validate_x_resource_name): Simplify count usage.
5330 This also avoids a warning with gcc -Wstrict-overflow.
5332 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5335 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5337 * process.c (Fmake_network_process): Use socklen_t, not int,
5338 where POSIX says socklen_t is required in portable programs.
5339 This fixes a porting bug on hosts like 64-bit HP-UX, where
5340 socklen_t is wider than int (Bug#8277).
5341 (Fmake_network_process, server_accept_connection):
5342 (wait_reading_process_output, read_process_output):
5345 * process.c: Rename or move locals to avoid shadowing.
5346 (list_processes_1, Fmake_network_process):
5347 (read_process_output_error_handler, exec_sentinel_error_handler):
5348 Rename or move locals.
5349 (Fmake_network_process): Define label "retry_connect" only if needed.
5350 (Fnetwork_interface_info): Fix pointer signedness.
5351 (process_send_signal): Add cast to avoid pointer signedness problem.
5352 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5353 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5355 Make tparam.h and terminfo.c consistent.
5356 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5357 Include tparam.h instead, since it declares them.
5358 * cm.h (PC): Remove extern decl; tparam.h now does this.
5359 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5360 * terminfo.c: Include tparam.h, to check interfaces.
5361 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5362 (tparam): Adjust signature to match interface in tparam.h;
5363 this removes some undefined behavior. Check that outstring and len
5364 are zero, which they always are with Emacs.
5365 * tparam.h (PC, BC, UP): New extern decls.
5367 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5368 (xftfont_open): Rename locals to avoid shadowing.
5370 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5371 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5372 (OTF_TAG_SYM): Omit macro if not needed.
5373 (ftfont_list): Remove unused local.
5374 (get_adstyle_property, ftfont_pattern_entity):
5375 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5376 Rename locals to avoid shadowing.
5378 * xfont.c (xfont_list_family): Mark var as initialized.
5380 * xml.c (make_dom): Now static.
5382 * composite.c (composition_compute_stop_pos): Rename local to
5384 (composition_reseat_it): Remove unused locals.
5385 (find_automatic_composition, composition_adjust_point): Likewise.
5386 (composition_update_it): Mark var as initialized.
5387 (find_automatic_composition): Mark vars as initialized,
5388 with a FIXME (Bug#8290).
5390 character.h: Rename locals to avoid shadowing.
5391 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5392 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5393 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5394 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5397 * textprop.c (property_change_between_p): Remove; unused.
5399 * intervals.c (interval_start_pos): Now static.
5401 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5403 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5404 Rename locals to avoid shadowing.
5406 * sound.c (wav_play, au_play, Fplay_sound_internal):
5407 Fix pointer signedness.
5408 (alsa_choose_format): Remove unused local var.
5409 (wav_play): Initialize a variable to 0, to prevent undefined
5410 behavior (Bug#8278).
5412 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5414 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5416 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5417 clobbering (Bug#8298).
5418 * sysdep.c (sys_subshell): Likewise.
5419 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5421 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5422 This should get cleaned up, so that child_setup has the
5423 same signature on all platforms.
5425 * callproc.c (call_process_cleanup): Now static.
5426 (relocate_fd): Rename locals to avoid shadowing.
5428 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5430 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5431 not to be necessary, and produces flickering.
5433 2011-03-20 Glenn Morris <rgm@gnu.org>
5435 * config.in: Remove file.
5437 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5439 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5440 are now in src/globals.h.
5441 (syms_of_minibuf): Remove spurious & from previous change.
5443 2011-03-20 Leo <sdl.web@gmail.com>
5445 * minibuf.c (completing-read-function): New variable.
5446 (completing-read-default): Rename from completing-read.
5447 (completing-read): Call completing-read-function.
5449 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5451 * xfaces.c (Fx_load_color_file):
5452 Read color file from absolute filename (bug#8250).
5454 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5456 * makefile.w32-in: Update dependencies.
5458 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5460 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5462 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5464 Fix more problems found by GCC 4.5.2's static checks.
5466 * process.c (make_serial_process_unwind, send_process_trap):
5467 (sigchld_handler): Now static.
5469 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5470 That way, the code declares only the vars that it needs.
5471 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5472 * s/cygwin.h (PTY_ITERATION): Likewise.
5473 * s/darwin.h (PTY_ITERATION): Likewise.
5474 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5476 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5477 * process.c (allocate_pty): Don't declare stb unless it's needed.
5479 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5480 (CONSTANTLIM): Remove; unused.
5481 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5482 Define only if needed.
5484 * unexelf.c (unexec): Name an expression,
5485 to avoid gcc -Wbad-function-cast warning.
5486 Use a different way to cause a compilation error if anyone uses
5487 n rather than nn, a way that does not involve shadowing.
5488 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5490 * deps.mk (unexalpha.o): Remove; unused.
5492 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5493 * unexec.h: New file.
5494 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5495 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5497 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5498 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5499 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5500 Change as necessary to match prototype in unexec.h.
5502 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5504 (back_comment, skip_chars): Mark vars as initialized.
5506 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5507 Rename locals to avoid shadowing.
5509 * lread.c (read1): Rewrite so as not to use empty "else".
5510 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5512 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5514 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5515 warning when compiling print.c.
5517 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5518 instead of using an uninitialized var.
5519 (font_sort_entities): Mark var as initialized.
5521 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5523 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5524 pointers to constants.
5525 (font_parse_fcname): Remove unused vars.
5526 (font_delete_unmatched): Now static.
5527 (font_get_spec): Remove; unused.
5528 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5529 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5530 Rename or move locals to avoid shadowing.
5532 * fns.c (require_nesting_list, require_unwind): Now static.
5533 (Ffillarray): Rename locals to avoid shadowing.
5535 * floatfns.c (domain_error2): Define only if needed.
5536 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5538 * alloc.c (mark_backtrace): Move decl from here ...
5539 * lisp.h: ... to here, so that it can be checked.
5541 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5542 (Fdefvar): Rewrite so as not to use empty "else".
5543 (lisp_indirect_variable): Name an expression,
5544 to avoid gcc -Wbad-function-cast warning.
5545 (Fdefvar): Rename locals to avoid shadowing.
5547 * callint.c (quotify_arg, quotify_args): Now static.
5548 (Fcall_interactively): Rename locals to avoid shadowing.
5549 Use const pointer when appropriate.
5551 * lisp.h (get_system_name, get_operating_system_release):
5552 Move decls here, to check interfaces.
5553 * process.c (get_operating_system_release): Move decl to lisp.h.
5554 * xrdb.c (get_system_name): Likewise.
5555 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5556 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5557 some of which prompt warnings from gcc -Wbad-function-cast.
5558 (Fformat_time_string, Fencode_time, Finsert_char):
5559 (Ftranslate_region_internal, Fformat):
5560 Rename or remove local vars to avoid shadowing.
5561 (Ftranslate_region_internal): Mark var as initialized.
5563 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5566 * lisp.h (eassert): Check that the argument compiles, even if
5567 ENABLE_CHECKING is not defined.
5569 * data.c (Findirect_variable): Name an expression, to avoid
5570 gcc -Wbad-function-cast warning.
5571 (default_value, arithcompare, arith_driver, arith_error): Now static.
5572 (store_symval_forwarding): Rename local to avoid shadowing.
5573 (Fmake_variable_buffer_local, Fmake_local_variable):
5574 Mark variables as initialized.
5575 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5577 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5578 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5579 Rename locals to avoid shadowing.
5580 (mark_stack): Move local variables into the #ifdef region where
5582 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5583 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5585 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5586 (GC_STRING_CHARS): Remove; not used.
5587 (Fmemory_limit): Cast sbrk's returned value to char *.
5589 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5590 avoids undefined behavior in theory.
5592 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5594 Use functions, not macros, for up- and down-casing (Bug#8254).
5595 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5596 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5597 to use the following functions instead of these macros.
5598 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5599 EMACS_INT, since callers assume the returned value fits in int.
5600 (upcase1): Likewise, for UPCASE_TABLE.
5601 (uppercasep, lowercasep, upcase): New static inline functions.
5602 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5603 the race-condition problem in the old DOWNCASE.
5605 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5606 Rename locals to avoid shadowing.
5607 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5608 (regex_compile, re_search_2, re_match_2_internal):
5609 Remove unused local vars.
5610 (FREE_VAR): Rewrite so as not to use empty "else",
5611 which gcc can warn about.
5612 (regex_compile, re_match_2_internal): Mark locals as initialized.
5613 (RETALLOC_IF): Define only if needed.
5614 (WORDCHAR_P): Likewise. This one is never needed, but is used
5615 only in a comment talking about a compiler bug, so put inside
5616 the #if 0 of that comment.
5617 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5618 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5621 * search.c (boyer_moore): Rename locals to avoid shadowing.
5622 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5623 (PREV_CHAR_BOUNDARY): Likewise.
5625 * search.c (simple_search): Remove unused var.
5627 * dired.c (compile_pattern): Move decl from here ...
5628 * lisp.h: ... to here, so that it can be checked.
5629 (struct re_registers): New forward decl.
5631 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5633 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5635 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5636 Rename locals to avoid shadowing.
5637 (Fvertical_motion): Mark locals as initialized.
5639 * casefiddle.c (casify_object, casify_region): Now static.
5640 (casify_region): Mark local as initialized.
5642 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5644 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5645 New macros, so that the caller can use some names other than
5646 gcpro1, gcpro2, etc.
5647 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5649 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5650 argument, for consistency with GCPRO2_VAR, etc: it is now the
5651 prefix of the variable, not the variable itself. All uses
5653 * dired.c (directory_files_internal, file_name_completion):
5654 Rename locals to avoid shadowing.
5656 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5657 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5658 dired.c's scmp function, had undefined behavior.
5659 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5660 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5661 * buffer.h: ... to here, because these macros use current_buffer,
5662 and the new implementation with inline functions needs to have
5663 current_buffer in scope now, rather than later when the macros
5665 (downcase, upcase1): New static inline functions.
5666 (DOWNCASE, UPCASE1): Reimplement using these functions.
5667 This avoids undefined behavior in expressions like
5668 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5669 from race conditions in accessing the global variables
5670 case_temp1 and case_temp2.
5671 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5672 * lisp.h (case_temp1, case_temp2): Remove their decls.
5673 * character.h (ASCII_CHAR_P): Move from here ...
5674 * lisp.h: ... to here, so that the inline functions mentioned
5677 * dired.c (directory_files_internal_unwind): Now static.
5679 * fileio.c (file_name_as_directory, directory_file_name):
5680 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5682 (file_name_as_directory): Use const pointers when appropriate.
5683 (Fexpand_file_name): Likewise. In particular, newdir might
5684 point at constant storage, so make it a const pointer.
5685 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5686 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5688 (Fset_file_times, Finsert_file_contents, auto_save_error):
5689 Rename locals to avoid shadowing.
5691 * minibuf.c (choose_minibuf_frame_1): Now static.
5692 (Ftry_completion, Fall_completions): Rename or remove locals
5695 * marker.c (bytepos_to_charpos): Remove; unused.
5697 * lisp.h (verify_bytepos, count_markers): New decls,
5698 so that gcc does not warn that these functions aren't declared.
5700 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5701 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5702 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5703 (copy_text): Remove unused local var.
5705 * filelock.c (within_one_second): Now static.
5706 (lock_file_1): Rename local to avoid shadowing.
5708 * buffer.c (fix_overlays_before): Mark locals as initialized.
5709 (fix_start_end_in_overlays): Likewise. This function should be
5710 simplified by using pointers-to-pointers, but that's a different
5712 (switch_to_buffer_1): Now static.
5713 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5714 (report_overlay_modification): Rename locals to avoid shadowing.
5716 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5717 Fix pointer signedness issue.
5718 (sys_subshell): Mark local as volatile if checking for lint,
5719 to suppress a gcc -Wclobbered warning that does not seem to be right.
5720 (MAXPATHLEN): Define only if needed.
5722 * process.c (serial_open, serial_configure): Move decls from here ...
5723 * systty.h: ... to here, so that they can be checked.
5725 * fns.c (get_random, seed_random): Move extern decls from here ...
5726 * lisp.h: ... to here, so that they can be checked.
5728 * sysdep.c (reset_io): Now static.
5729 (wait_for_termination_signal): Remove; unused.
5731 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5732 (copy_keymap_item, append_key, push_text_char_description):
5734 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5735 (DENSE_TABLE_SIZE): Remove; unused.
5736 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5737 (describe_map_tree):
5738 Rename locals to avoid shadowing.
5740 * keyboard.c: Declare functions static if they are not used elsewhere.
5741 (echo_char, echo_dash, cmd_error, top_level_2):
5742 (poll_for_input, handle_async_input): Now static.
5743 (read_char, kbd_buffer_get_event, make_lispy_position):
5744 (make_lispy_event, make_lispy_movement, apply_modifiers):
5745 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5746 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5747 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5748 (read_key_sequence, read_char): Mark locals as initialized.
5749 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5751 * keyboard.h (make_ctrl_char): New decl.
5752 (mark_kboards): Move decl here ...
5753 * alloc.c (mark_kboards): ... from here.
5755 * lisp.h (force_auto_save_soon): New decl.
5757 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5758 (DEFINE_DUMMY_FUNCTION): New macro.
5759 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5761 (main): Add casts to avoid warnings
5762 if GCC considers string literals to be constants.
5764 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5766 * dbusbind.c: Pointer signedness fixes.
5767 (xd_signature, xd_append_arg, xd_initialize):
5768 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5769 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5770 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5771 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5773 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5774 if GCC considers string literals to be constants.
5775 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5777 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5779 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5780 (print_preprocess, print_object): New macro to fix last change.
5782 * print.c (print_preprocess): Don't forget font objects.
5784 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5786 * emacs.c (USAGE3): Doc fixes.
5788 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5790 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5793 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5795 * lisp.h (VWindow_system, Qfile_name_history):
5796 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5797 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5798 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5800 * w32select.c: Don't #include "keyboard.h".
5801 (run_protected): Add extern declaration for waiting_for_input.
5803 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5804 * w32console.c (detect_input_pending, read_input_pending)
5805 (encode_terminal_code):
5806 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5807 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5808 (w32_system_caret_y, Qfile_name_history):
5809 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5810 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5811 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5812 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5813 * w32proc.c (Qlocal, report_file_error):
5814 * w32term.c (Vwindow_system, updating_frame):
5815 * w32uniscribe.c (initialized, uniscribe_font_driver):
5816 Remove unneeded extern declarations.
5818 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5820 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5822 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5824 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5825 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5826 These macros can no longer be used for assignment.
5828 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5829 Assign struct members directly, instead of using BUF_BEGV etc.
5830 (record_buffer_markers, fetch_buffer_markers): New functions for
5831 recording and fetching special buffer markers.
5832 (set_buffer_internal_1, set_buffer_temp): Use them.
5834 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5836 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5838 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5839 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5841 * xdisp.c (hscroll_window_tree):
5842 (reconsider_clip_changes): Use PT instead of BUF_PT.
5844 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5846 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5847 $(EMACS_ROOT)/lib/intprops.h.
5849 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5851 Fix more problems found by GCC 4.5.2's static checks.
5853 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5854 to unsigned char * to avoid compiler diagnostic.
5855 (xg_free_frame_widgets): Make it clear that a local variable is
5856 needed only if USE_GTK_TOOLTIP.
5857 (gdk_window_get_screen): Make it clear that this macro is needed
5858 only if USE_GTK_TOOLTIP.
5859 (int_gtk_range_get_value): New function, which avoids a diagnostic
5860 from gcc -Wbad-function-cast.
5861 (xg_set_toolkit_scroll_bar_thumb): Use it.
5862 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5863 diagnostic from gcc -Wbad-function-cast.
5864 (get_utf8_string, xg_get_file_with_chooser):
5865 Rename locals to avoid shadowing.
5866 (create_dialog): Move locals to avoid shadowing.
5868 * xgselect.c (xg_select): Remove unused var.
5870 * image.c (four_corners_best): Mark locals as initialized.
5871 (gif_load): Initialize transparent_p to zero (Bug#8238).
5872 Mark another local as initialized.
5873 (my_png_error, my_error_exit): Mark with NO_RETURN.
5875 * image.c (clear_image_cache): Now static.
5876 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5877 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5878 (x_edge_detection): Remove unnecessary cast that
5879 gcc -Wbad-function-cast diagnoses.
5880 (gif_load): Fix pointer signedness.
5881 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5882 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5884 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5886 Improve quality of tests for time stamp overflow.
5887 For example, without this patch (encode-time 0 0 0 1 1
5888 1152921504606846976) returns the obviously-bogus value (-948597
5889 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5890 reports time overflow. See
5891 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5892 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5893 * editfns.c: Include limits.h and intprops.h.
5894 (TIME_T_MIN, TIME_T_MAX): New macros.
5895 (time_overflow): Move earlier, to before first use.
5896 (hi_time, lo_time): New functions, for an accurate test for
5898 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5899 (Fget_internal_run_time): Don't assume time_t fits in int.
5900 (make_time): Use list2 instead of Fcons twice.
5901 (Fdecode_time): More accurate test for out-of-range times.
5902 (check_tm_member): New function.
5903 (Fencode_time): Use it, to test for out-of-range times.
5904 (lisp_time_argument): Don't rely on undefined left-shift and
5905 right-shift behavior when checking for time stamp overflow.
5907 * editfns.c (time_overflow): New function, refactoring common code.
5908 (Fformat_time_string, Fdecode_time, Fencode_time):
5909 (Fcurrent_time_string): Use it.
5911 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5912 * dired.c (make_time): Move to ...
5913 * editfns.c (make_time): ... here.
5914 * systime.h: Note the move.
5916 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5918 * fringe.c (update_window_fringes): Remove unused variables.
5920 * unexmacosx.c (copy_data_segment): Also copy __got section.
5923 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5925 * termcap.c [MSDOS]: Include "msdos.h".
5926 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5927 Constify `char *' arguments and their references according to
5928 prototypes in tparam.h.
5930 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5932 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5933 Adapt all references accordingly.
5935 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5937 2011-03-11 Tom Tromey <tromey@redhat.com>
5939 * buffer.c (syms_of_buffer): Remove obsolete comment.
5941 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5943 * termhooks.h (encode_terminal_code): Declare prototype.
5945 * msdos.c (encode_terminal_code): Don't declare prototype.
5947 * term.c (encode_terminal_code): Now external again, used by
5948 w32console.c and msdos.c.
5950 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5951 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5953 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5955 Fix some minor problems found by GCC 4.5.2's static checks.
5957 * fringe.c (update_window_fringes): Mark locals as initialized
5959 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5961 * alloc.c (mark_fringe_data): Move decl from here ...
5962 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5963 to check its interface.
5964 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5966 * fontset.c (free_realized_fontset): Now static.
5967 (Fset_fontset_font): Rename local to avoid shadowing.
5968 (fontset_font): Mark local as initialized.
5969 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5971 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5973 * xselect.c (x_disown_buffer_selections): Remove; not used.
5974 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5975 (x_own_selection, Fx_disown_selection_internal): Rename locals
5977 (x_handle_dnd_message): Remove local to avoid shadowing.
5979 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5980 so that the caller can use some name other than gcpro1.
5981 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5982 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5983 (Fx_backspace_delete_keys_p):
5984 Use them to avoid shadowing, and rename vars to avoid shadowing.
5985 (x_decode_color, x_set_name, x_window): Now static.
5986 (Fx_create_frame): Add braces to silence GCC warning.
5987 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5988 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5989 Remove unused locals.
5990 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5991 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5992 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5995 * xterm.h (x_mouse_leave): New decl.
5997 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5998 Remove unused functions.
5999 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6000 (x_calc_absolute_position): Now static.
6001 (XTread_socket): Don't define label "out" unless it's used.
6002 Don't declare local "event" unless it's used.
6003 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6004 unless they are used.
6005 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6006 (x_fatal_error_signal): Remove; not used.
6007 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6008 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6009 (x_error_catcher, x_connection_closed, x_error_handler):
6010 (x_error_quitter, xembed_send_message, x_iconify_frame):
6011 (my_log_handler): Rename locals to avoid shadowing.
6012 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6013 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6015 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6016 Rename or move locals to avoid shadowing.
6017 (tty_defined_color, merge_face_heights): Now static.
6018 (free_realized_faces_for_fontset): Remove; not used.
6019 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6020 does not deduce is never used uninitialized.
6021 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6022 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6024 * terminal.c (store_terminal_param): Now static.
6026 * xmenu.c (menu_highlight_callback): Now static.
6027 (set_frame_menubar): Remove unused local.
6028 (xmenu_show): Rename parameter to avoid shadowing.
6029 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6030 since they might point to immutable storage.
6031 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6032 since it's unused otherwise.
6034 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6035 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6036 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6037 avoids a gcc -Wuninitialized diagnostic.
6038 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6039 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6040 does not deduce are never used uninitialized.
6042 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6044 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6045 * window.c (window_loop, size_window):
6046 (run_window_configuration_change_hook, enlarge_window): Likewise.
6048 * window.c (display_buffer): Now static.
6049 (size_window): Mark variables that gcc -Wuninitialized
6050 does not deduce are never used uninitialized.
6051 * window.h (check_all_windows): New decl, to forestall
6052 gcc -Wmissing-prototypes diagnostic.
6053 * dispextern.h (bidi_dump_cached_states): Likewise.
6055 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6057 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6059 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6060 and to avoid gcc -Wuninitialized warning.
6061 (load_charset_map): Mark variables that gcc -Wuninitialized
6062 does not deduce are never used uninitialized.
6063 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6065 * coding.c (coding_set_source, coding_set_destination):
6066 Use "else { /* comment */ }" rather than "else /* comment */;"
6067 for clarity, and to avoid gcc -Wempty-body warning.
6068 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6069 a block, when the outer 'i' will do.
6070 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6071 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6072 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6073 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6074 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6075 Rename locals to avoid shadowing.
6076 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6077 * coding.c (emacs_mule_char, encode_invocation_designation):
6078 Now static, since they're not used elsewhere.
6079 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6080 (decode_coding_object, encode_coding_object, detect_coding_system):
6081 (decode_coding_emacs_mule): Mark variables that gcc
6082 -Wuninitialized does not deduce are never used uninitialized.
6083 (detect_coding_iso_2022): Initialize a local variable that might
6084 be used uninitialized. Leave a FIXME because it's not clear that
6085 this initialization is needed. (Bug#8211)
6086 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6087 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6088 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6089 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6090 Remove unused macros.
6092 * category.c (hash_get_category_set): Remove unused local var.
6093 (copy_category_table): Now static, since it's not used elsewhere.
6094 * character.c (string_count_byte8): Likewise.
6096 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6097 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6099 * chartab.c (copy_sub_char_table): Now static, since it's not used
6101 (sub_char_table_ref_and_range, char_table_ref_and_range):
6102 Rename locals to avoid shadowing.
6103 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6105 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6106 (BIDI_BOB): Remove unused macro.
6108 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6109 deduce are never used uninitialized.
6110 * term.c (encode_terminal_code): Likewise.
6112 * term.c (encode_terminal_code): Now static. Remove unused local.
6114 * tparam.h: New file.
6115 * term.c, tparam.h: Include it.
6116 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6117 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6118 Move these decls to tparam.h, and make them agree with what
6119 is actually in tparam.c. The previous trick of using incompatible
6120 decls in different modules does not conform to the C standard.
6121 All callers of tparam changed to use tparam's actual API.
6122 * tparam.c (tparam1, tparam, tgoto):
6123 Use const pointers where appropriate.
6125 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6126 * cm.h (struct cm): Likewise.
6127 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6128 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6129 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6130 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6131 (turn_on_face, init_tty): Likewise.
6132 * termchar.h (struct tty_display_info): Likewise.
6134 * term.c (term_mouse_position): Rename local to avoid shadowing.
6136 * alloc.c (mark_ttys): Move decl from here ...
6137 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6139 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6141 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6143 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6145 * search.c (compile_pattern_1): Remove argument regp, unused since
6146 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6147 (compile_pattern): Don't pass it.
6149 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6151 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6152 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6154 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6156 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6158 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6159 gdk_window_get_screen, gdk_window_get_geometry,
6160 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6161 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6162 (xg_get_pixbuf_from_pixmap): New function.
6163 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6164 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6165 Call xg_get_pixbuf_from_pixmap instead of
6166 gdk_pixbuf_get_from_drawable.
6167 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6168 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6169 (xg_check_special_colors): Use GtkStyleContext and its functions
6171 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6172 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6173 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6174 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6175 Call gtk_widget_get_preferred_size.
6176 (xg_frame_resized): gdk_window_get_geometry only takes 5
6178 (xg_win_to_widget, xg_event_is_for_menubar):
6179 Call gdk_x11_window_lookup_for_display.
6180 (xg_set_widget_bg): New function.
6181 (delete_cb): New function.
6182 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6183 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6184 (xg_set_background_color): Call xg_set_widget_bg.
6185 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6186 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6187 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6188 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6190 (update_frame_tool_bar): Call gtk_widget_hide.
6191 (xg_initialize): Use GDK_KEY_g.
6193 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6195 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6197 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6198 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6199 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6201 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6203 * w32xfns.c (select_palette): Check success of RealizePalette against
6204 GDI_ERROR, not zero.
6206 See ChangeLog.11 for earlier changes.
6212 Copyright (C) 2011 Free Software Foundation, Inc.
6214 This file is part of GNU Emacs.
6216 GNU Emacs is free software: you can redistribute it and/or modify
6217 it under the terms of the GNU General Public License as published by
6218 the Free Software Foundation, either version 3 of the License, or
6219 (at your option) any later version.
6221 GNU Emacs is distributed in the hope that it will be useful,
6222 but WITHOUT ANY WARRANTY; without even the implied warranty of
6223 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6224 GNU General Public License for more details.
6226 You should have received a copy of the GNU General Public License
6227 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.