* doc.c (get_doc_string): Rework so that
[bpt/emacs.git] / src / ChangeLog
1 2011-08-16 Paul Eggert <eggert@cs.ucla.edu>
2
3 Integer and memory overflow issues (Bug#9196).
4
5 * doc.c (get_doc_string): Rework so that
6 get_doc_string_buffer_size is the actual buffer size, rather than
7 being 1 less than the actual buffer size; this makes xpalloc more
8 convenient.
9
10 * image.c (x_allocate_bitmap_record, cache_image):
11 * xselect.c (Fx_register_dnd_atom):
12 Simplify previous changes by using xpalloc.
13
14 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
15 since either will do and ptrdiff_t is convenient with xpalloc.
16
17 * charset.c (charset_table_size)
18 (struct charset_sort_data.priority): Now ptrdiff_t.
19 (charset_compare): Don't overflow if priorities differ greatly.
20 (Fsort_charsets): Don't assume list length fits in int.
21 Check for size-calculation overflow when allocating sort data.
22 (syms_of_charset): Allocate an initial charset table that is
23 just under 64 KiB, to avoid problems with glibc malloc and mmap.
24
25 * cmds.c (internal_self_insert): Check for size-calculation overflow.
26
27 * composite.h (struct composition.glyph_len): Now int, not unsigned.
28 The actual value is always <= INT_MAX, and leaving it unsigned made
29 overflow checking harder.
30
31 * dispextern.h (struct glyph_matrix.rows_allocated)
32 (struct face_cache.size): Now ptrdiff_t, for convenience in use
33 with xpalloc. The values are still always <= INT_MAX.
34
35 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
36
37 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
38 (SAFE_NALLOCA): New macro.
39
40 * region-cache.c (struct boundary.pos, find_cache_boundary)
41 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
42 (set_cache_region, invalidate_region_cache)
43 (revalidate_region_cache, know_region_cache, region_cache_forward)
44 (region_cache_backward, pp_cache):
45 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
46 so that ptrdiff_t * can be passed to xpalloc.
47 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
48 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
49 (pp_cache): Don't assume cache_len fits in int.
50 * region-cache.h: Adjust extern decls to match.
51
52 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
53 EMACS_INT, since either will do, for xpalloc.
54
55 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
56 (xnmalloc, xnrealloc, xpalloc): New functions.
57
58 * bidi.c (bidi_shelve_header_size): New constant.
59 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
60 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
61
62 * buffer.c (overlays_at, overlays_in, record_overlay_string)
63 (overlay_strings):
64 Don't update size of array until after memory allocation succeeds,
65 because xmalloc/xrealloc may not return.
66 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
67 now that we have proper integer overflow checking.
68 (record_overlay_string, overlay_strings): Catch overflows when
69 calculating size of overlay_str_buf.
70
71 * callproc.c (Fcall_process): Check for size overflow when
72 calculating size of args2.
73 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
74 Normally we prefer signed values, but sticking with ptrdiff_t would
75 require adding more-complicated checks.
76
77 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
78 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
79 Redo buffer-overflow calculations to avoid integer overflow.
80 Add a FIXME comment where memory seems to be over-allocated.
81
82 * character.c (Fstring): Check for size-calculation overflow.
83
84 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
85 unnecessary integer overflow. Check for size overflow.
86 (encode_coding_object): Don't update size until xmalloc succeeds.
87
88 * composite.c (get_composition_id): Check for overflow in glyph
89 length calculations.
90
91 Integer and memory overflow fixes for display code.
92 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
93 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
94 (scrolling_window): Check for overflow in size calculations.
95 (line_draw_cost, realloc_glyph_pool, add_row_entry):
96 Don't assume glyph table len fits in int.
97 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
98 (row_table_size): Now ptrdiff_t, not int.
99 (scrolling_window): Avoid overflow in size calculations.
100 Don't update size until allocation succeeds.
101 * fns.c (concat): Check for overflow in size calculations.
102 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
103 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
104 (NEXT_ALMOST_PRIME_LIMIT): New constant.
105
106 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
107 (get_doc_string): Check for size calculation overflow.
108 Don't update size until allocation succeeds.
109 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
110 EMACS_INT, where ptrdiff_t will do.
111 (Fsubstitute_command_keys): Check for string overflow.
112
113 * editfns.c (set_time_zone_rule): Don't assume environment length
114 fits in int.
115 (message_length): Now ptrdiff_t, not int.
116 (Fmessage_box): Don't update size until allocation succeeds.
117 Don't assume message length fits in int.
118 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
119
120 * emacs.c (main): Do not reallocate argv, since there is a null at
121 the end that can be overwritten, and this way there's no need to
122 worry about size-calculation overflow.
123 (sort_args): Check for size-calculation overflow.
124
125 * eval.c (init_eval_once, grow_specpdl): Don't update size until
126 alloc succeeds.
127 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
128
129 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
130 (x_set_scroll_bar_width, x_figure_window_size):
131 Check for integer overflow.
132 (x_set_alpha): Do not assume XINT fits in int.
133
134 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
135 This is for the members text_lines, text_cols, total_lines, total_cols,
136 where the system imposes an 'int' limit.
137
138 * fringe.c (Fdefine_fringe_bitmap):
139 Don't update size until alloc works.
140
141 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
142 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
143
144 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
145 Check for size-calculation overflow.
146 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
147 do, as we prefer signed integers.
148 (id_to_widget.max_size, id_to_widget.used)
149 (xg_store_widget_in_map, xg_remove_widget_from_map)
150 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
151 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
152 Use and return ptrdiff_t, not int.
153 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
154 * gtkutil.h: Change prototypes to match the above.
155
156 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
157 are duplicate now that they've been promoted to lisp.h.
158 (x_allocate_bitmap_record, x_alloc_image_color)
159 (make_image_cache, cache_image, xpm_load):
160 Don't update size until alloc is done.
161 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
162 (x_detect_edges):
163 Check for size calculation overflow.
164 (ct_colors_allocated_max): New constant.
165 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
166 overflow.
167
168 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
169 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
170 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
171 Use ptrdiff_t, not int, to count maps.
172 (read_char_minibuf_menu_prompt): Check for overflow in size
173 calculations. Don't update size until allocation succeeds. Redo
174 calculations to avoid overflow.
175 * keyboard.h: Change prototypes to match the above.
176
177 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
178 to count maps.
179 (current_minor_maps): Check for size calculation overflow.
180 * keymap.h: Change prototypes to match the above.
181
182 * lread.c (read1, init_obarray): Don't update size until alloc done.
183
184 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
185 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
186
187 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
188 Now ptrdiff_t, not int.
189 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
190 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
191
192 * process.c (Fnetwork_interface_list): Check for overflow
193 in size calculation.
194
195 * region-cache.c (move_cache_gap): Check for size calculation overflow.
196
197 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
198 overflow. Don't bother calling xmalloc when xrealloc will do.
199
200 * search.c (Freplace_match): Check for size calculation overflow.
201 (Fset_match_data): Don't assume list lengths fit in 'int'.
202
203 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
204 for command line length. Do not attempt to address one before the
205 beginning of an array, as that's not portable.
206
207 * term.c (max_frame_lines): Remove; unused.
208 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
209 not int.
210 (encode_terminal_code, calculate_costs): Check for size
211 calculation overflow.
212 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
213 table lengths and related sizes. Don't update size until alloc
214 done. Redo calculations to avoid overflow.
215 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
216
217 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
218 subtracting pointers.
219 (gobble_line): Check for overflow more carefully. Don't update size
220 until alloc done.
221
222 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
223 Don't update size until alloc done.
224 Redo size calculations to avoid overflow.
225 Check for size calculation overflow.
226 (main) [DEBUG]: Fix typo in invoking tparam1.
227
228 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
229 Use ptrdiff_t, not int, for sizes.
230 (store_mode_line_noprop_char): Don't update size until alloc done.
231
232 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
233 Use ptrdiff_t, not int, for sizes.
234 (Finternal_make_lisp_face, cache_face):
235 Check for size calculation overflow.
236 (cache_face): Treat size calculation overflows as if they were
237 memory exhaustion (the usual treatment), rather than aborting.
238
239 * xfns.c (x_encode_text, x_set_name_internal)
240 (Fx_change_window_property): Use ptrdiff_t, not int, to count
241 sizes, since they can exceed INT_MAX in size. Check for size
242 calculation overflow.
243
244 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
245 (xg_select): Check for size calculation overflow.
246 Don't update size until alloc done.
247
248 * xrdb.c (get_environ_db): Don't assume path length fits in int,
249 as sprintf is limited to int lengths.
250
251 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
252 (X_LONG_MIN): New macros.
253 Use them to make the following changes clearer.
254 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
255 This change doesn't affect the value now, but it may help remind
256 future maintainers not to raise the value too much later.
257 (SELECTION_QUANTUM): Remove, replacing with ...
258 (selection_quantum): ... new function, which avoids overflow.
259 All uses changed.
260 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
261 assumption that selection length fits in 'int'.
262 (x_reply_selection_request, x_handle_selection_request)
263 (x_get_window_property, receive_incremental_selection)
264 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
265 (lisp_data_to_selection_data, clean_local_selection_data):
266 Use ptrdiff_t, not int, to record length of selection.
267 (x_reply_selection_request, x_get_window_property)
268 (receive_incremental_selection, x_property_data_to_lisp):
269 Redo calculations to avoid overflow.
270 (x_reply_selection_request): When sending hint, ceiling it at
271 X_LONG_MAX rather than relying on wraparound overflow to send
272 something.
273 (x_get_window_property, receive_incremental_selection)
274 (lisp_data_to_selection_data, x_property_data_to_lisp):
275 Check for size-calculation overflow.
276 (x_get_window_property, receive_incremental_selection)
277 (lisp_data_to_selection_data, Fx_register_dnd_atom):
278 Don't store size until memory allocation succeeds.
279 (x_get_window_property): Plug memory leak on memory exhaustion.
280 Don't double-block input; malloc is safe here. Don't assume 2**34
281 - 4 fits in unsigned long. Add an xassert to check
282 XGetWindowProperty overflow. Be more careful about overflow
283 calculations, and distinguish size from memory overflow better.
284 (receive_incremental_selection): When tracing, don't assume
285 unsigned int is less than INT_MAX.
286 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
287 harmful) conversions of unsigned short to int.
288 (lisp_data_to_selection_data): Don't assume that integers
289 in the range -65535 through -1 fit in an X unsigned short.
290 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
291 result parameters unless successful. Rely on cons_to_unsigned
292 to report problems with elements; the old code wasn't right anyway.
293 (x_check_property_data): Check for int overflow; we cannot use
294 a wider type due to X limits.
295 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
296
297 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
298
299 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
300 (x_term_init): Check for size calculation overflow.
301 (x_color_cells): Don't store size until memory allocation succeeds.
302 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
303 Don't assume alloca size is less than MAX_ALLOCA.
304 (x_term_init): Don't assume length fits in int (sprintf is limited
305 to int size).
306
307 Use ptrdiff_t for composition IDs.
308 * character.c (lisp_string_width):
309 * composite.c (composition_table_size, n_compositions)
310 (get_composition_id, composition_gstring_from_id):
311 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
312 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
313 * window.c (Frecenter):
314 Use ptrdiff_t, not int, for composition IDs.
315 * composite.c (get_composition_id): Check for integer overflow.
316 * composite.h: Adjust prototypes to match the above changes.
317
318 Use ptrdiff_t for hash table indexes.
319 * category.c (hash_get_category_set):
320 * ccl.c (ccl_driver):
321 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
322 * coding.c (coding_system_charset_list, detect_coding_system):
323 * coding.h (struct coding_system.id):
324 * composite.c (get_composition_id, gstring_lookup_cache):
325 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
326 * image.c (xpm_get_color_table_h):
327 * lisp.h (hash_lookup, hash_put):
328 * minibuf.c (Ftest_completion):
329 Use ptrdiff_t for hash table indexes, not int (which is too
330 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
331 32-bit --with-wide-int hosts).
332
333 * charset.c (Fdefine_charset_internal): Check for integer overflow.
334 Add a FIXME comment about memory leaks.
335 (syms_of_charset): Don't assume xmalloc returns.
336
337 Don't assume that stated character widths fit in int.
338 * character.c (Fchar_width, c_string_width, lisp_string_width):
339 * character.h (CHAR_WIDTH):
340 * indent.c (MULTIBYTE_BYTES_WIDTH):
341 Use sanitize_char_width to avoid undefined and/or bad behavior
342 with outlandish widths.
343 * character.h (sanitize_tab_width): Renamed from sanitize_width,
344 now that we have two such functions. All uses changed.
345 (sanitize_char_width): New inline function.
346
347 Don't assume that tab-width fits in int.
348 * character.h (sanitize_width): New inline function.
349 (SANE_TAB_WIDTH): New macro.
350 (ASCII_CHAR_WIDTH): Use it.
351 * indent.c (sane_tab_width): Remove. All uses replaced by
352 SANE_TAB_WIDTH (current_buffer).
353 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
354
355 * fileio.c: Integer overflow issues with file modes.
356 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
357
358 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
359 Remove unreachable code.
360 (read_hex, load_charset_map_from_file): Check for integer overflow.
361
362 * xterm.c: don't go over XClientMessageEvent limit
363 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
364 (x_send_scroll_bar_event): Likewise. Check that the size does not
365 exceed limits imposed by XClientMessageEvent, as well as the usual
366 ptrdiff_t and size_t limits.
367
368 * keyboard.c: Overflow, signedness and related fixes.
369 (make_lispy_movement): Use same integer type in forward decl
370 that is used in the definition.
371 (read_key_sequence, keyremap_step):
372 Change bufsize argument back to int, undoing my 2011-03-30 change.
373 We prefer signed types, and int is wide enough here.
374 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
375 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
376 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
377 length, not size_t. Use ptrdiff_t for index, not int.
378 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
379 possibility of integer overflow.
380
381 Overflow, signedness and related fixes for images.
382
383 * dispextern.h (struct it.stack[0].u.image.image_id)
384 (struct_it.image_id, struct image.id, struct image_cache.size)
385 (struct image_cache.used, struct image_cache.ref_count):
386 * gtkutil.c (update_frame_tool_bar):
387 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
388 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
389 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
390 * nsmenu.m (update_frame_tool_bar):
391 * xdisp.c (calc_pixel_width_or_height):
392 * xfns.c (image_cache_refcount):
393 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
394 on typical 64-bit hosts.
395
396 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
397 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
398 Omit unnecessary casts to int.
399 (parse_image_spec): Check that integers fall into 'int' range
400 when the callers expect that.
401 (image_ascent): Redo ascent calculation to avoid int overflow.
402 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
403 (lookup_image): Remove unnecessary tests.
404 (xbm_image_p): Locals are now of int, not EMACS_INT,
405 since parse_image_check makes sure they fit into int.
406 (png_load, gif_load, svg_load_image):
407 Prefer int to unsigned where either will do.
408 (tiff_handler): New function, combining the cores of the
409 old tiff_error_handler and tiff_warning_handler. This
410 function is rewritten to use vsnprintf and thereby avoid
411 stack buffer overflows. It uses only the features of vsnprintf
412 that are common to both POSIX and native Microsoft.
413 (tiff_error_handler, tiff_warning_handler): Use it.
414 (tiff_load, gif_load, imagemagick_load_image):
415 Don't assume :index value fits in 'int'.
416 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
417 (imagemagick_load_image): Check that crop parameters fit into
418 the integer types that MagickCropImage accepts. Don't assume
419 Vimagemagick_render_type has a nonnegative value. Don't assume
420 size_t fits in 'long'.
421 (gs_load): Use printmax_t to print the widest integers possible.
422 Check for integer overflow when computing image height and width.
423
424 2011-08-16 Eli Zaretskii <eliz@gnu.org>
425
426 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
427 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
428
429 2011-08-16 Ken Brown <kbrown@cornell.edu>
430
431 Fix memory allocation problems in Cygwin build (Bug#9273).
432
433 * unexcw.c ( __malloc_initialized): Declare external variable.
434 (fixup_executable): Force the dumped emacs to reinitialize malloc.
435
436 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
437 variables.
438 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
439 dumped emacs.
440 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
441 in the static heap.
442 [CYGWIN] (special_realloc): New function.
443 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
444 requests to realloc storage in the static heap.
445
446 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
447
448 * bidi.c (bidi_initialize): Remove unused local.
449
450 2011-08-15 Eli Zaretskii <eliz@gnu.org>
451
452 * biditype.h: File removed.
453
454 * bidimirror.h: File removed.
455
456 * deps.mk (bidi.o): Remove biditype.h and
457 bidimirror.h.
458
459 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
460 bidimirror.h.
461
462 * dispextern.h: Fix a typo in the comment to bidi_type_t.
463
464 * chartab.c: Improve commentary for the uniprop_table API.
465
466 * bidi.c (bidi_paragraph_init): Support zero value of
467 bidi_ignore_explicit_marks_for_paragraph_level.
468 (bidi_initialize): Use uniprop_table instead of including
469 biditype.h and bidimirror.h.
470
471 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
472 coordinates of the iterator when restoring from ppos_it.
473 (Bug#9296)
474
475 2011-08-14 Kenichi Handa <handa@m17n.org>
476
477 * process.c (create_process): Call setup_process_coding_systems
478 after the pid of the process is set to -1.
479
480 2011-08-14 Eli Zaretskii <eliz@gnu.org>
481
482 * xdisp.c (move_it_in_display_line_to): Don't invoke
483 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
484 ppos_it. Fixes vertical cursor motion when line beginning is
485 covered by an image. (Bug#9296)
486
487 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
488
489 * nsterm.h (ns_run_ascript): Declare.
490 (NSAPP_DATA2_RUNASSCRIPT): Define.
491
492 * nsfns.m (as_script, as_result, as_status): New static variables.
493 (ns_run_ascript): New function.
494 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
495 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
496 the event loop. Get status from as_status (Bug#7276).
497
498 * nsterm.m (sendEvent): If event is NSApplicationDefined and
499 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
500 the event loop (Bug#7276).
501
502 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
503
504 * gnutls.c (QCgnutls_bootprop_priority)
505 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
506 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
507 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
508 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
509 (QCgnutls_bootprop_verify_hostname_error)
510 (QCgnutls_bootprop_callbacks_verify): Rename from
511 Qgnutls_bootprop_..., all uses changed.
512
513 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
514 uses changed.
515
516 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
517
518 * xfaces.c (Qframe_set_background_mode): Now static.
519 * dispextern.h (Qframe_set_background_mode): Remove decl.
520
521 * process.c (Fnetwork_interface_info): Declare local only if needed.
522
523 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
524
525 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
526 (Fnetwork_interface_list): Allocate in increments of bytes instead
527 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
528 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
529 sockaddr.
530 (struct ifflag_def): notrailers is smart on OSX.
531 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
532 Get hardware address with getifaddrs if available.
533
534 2011-08-12 Eli Zaretskii <eliz@gnu.org>
535
536 * xdisp.c (iterate_out_of_display_property): xassert that
537 IT->position is set to within IT->object's boundaries. Break from
538 the loop as soon as EOB is reached; avoids infloops in redisplay
539 when IT->position is set up wrongly due to some bug. Set
540 IT->current to match the bidi iterator unconditionally.
541 (push_display_prop): Allow GET_FROM_STRING as IT->method on
542 entry. Force push_it to save on the stack the current
543 buffer/string position, to be restored by pop_it. Fix flags in
544 the iterator structure wrt the object coming from a display
545 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
546 properties. (Bug#9284)
547
548 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
549
550 * fontset.c (fontset_get_font_group): Add proper type checks.
551 (Bug#9172)
552
553 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
554
555 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
556 and LC_VERSION_MIN_MACOSX.
557 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
558 (dump_it) [LC_FUNCTION_STARTS]: Use it.
559
560 2011-08-08 Eli Zaretskii <eliz@gnu.org>
561
562 * xdisp.c (forward_to_next_line_start): Allow to use the
563 no-display-properties-and-no-overlays under bidi display. Set
564 disp_pos in the bidi iterator to avoid searches for display
565 properties and overlays.
566
567 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
568
569 * editfns.c (Fset_time_zone_rule): Document relationship with the
570 setenv function.
571
572 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
573 the font entity extracted from the cache (Bug#8109).
574
575 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
576
577 * composite.c (autocmp_chars): Don't reset point. That is done by
578 restore_point_unwind (Bug#5984).
579
580 2011-08-07 Juri Linkov <juri@jurta.org>
581
582 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
583 to show the arg `TIME' instead of `TIMEVAL'.
584
585 2011-08-06 Eli Zaretskii <eliz@gnu.org>
586
587 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
588 display property strides EOL and includes a newline, as in
589 longlines-mode. (Bug#9254)
590 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
591 word-wrap under bidirectional display. (Bug#9224)
592
593 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
594 is non-zero, even if the data buffer is NULL. Fixes a crash in
595 vertical-motion with longlines-mode. (Bug#9254)
596
597 2011-08-05 Eli Zaretskii <eliz@gnu.org>
598
599 * bidi.c <bidi_cache_total_alloc>: Now static.
600 (bidi_initialize): Initialize bidi_cache_total_alloc.
601
602 *xdisp.c (display_line): Release buffer allocated for shelved bidi
603 cache. (Bug#9221)
604
605 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
606 amount allocated this far in `bidi_cache_total_alloc'.
607 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
608 non-zero, only free the data buffer without restoring the cache
609 contents. All callers changed.
610
611 * dispextern.h (bidi_unshelve_cache): Update prototype.
612
613 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
614 (move_it_in_display_line, move_it_to)
615 (move_it_vertically_backward, move_it_by_lines): Replace the call
616 to xfree to an equivalent call to bidi_unshelve_cache.
617 (move_it_in_display_line_to): Fix logic of returning
618 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
619
620 2011-08-05 Eli Zaretskii <eliz@gnu.org>
621
622 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
623 came from a string character with a `cursor' property. (Bug#9229)
624
625 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
626
627 * Makefile.in (LIB_PTHREAD): New variable.
628 (LIBES): Add LIB_PTHREAD (Bug#9216).
629
630 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
631 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
632
633 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
634
635 * regex.c (re_iswctype): Remove some redundant boolean
636 conversions.
637
638 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
639
640 * xterm.c (x_find_topmost_parent): New function.
641 (x_set_frame_alpha): Find topmost parent window with
642 x_find_topmost_parent and set the property there also (bug#9181).
643 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
644
645 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
646
647 * callproc.c (Fcall_process): Avoid vfork clobbering
648 the local vars buffer, coding_systems, current_dir.
649
650 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
651
652 * keymap.c (Fmake_composed_keymap): Move to subr.el.
653
654 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
655
656 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
657 so that it is not optimized away.
658
659 * xdisp.c (compute_display_string_pos): Remove unused local.
660
661 2011-08-02 Eli Zaretskii <eliz@gnu.org>
662
663 Fix slow cursor motion and scrolling in large buffers with
664 selective display, like Org Mode buffers. (Bug#9218)
665
666 * dispextern.h (struct bidi_it): New member disp_prop_p.
667
668 * xdisp.c: Remove one-slot cache of display string positions.
669 (compute_display_string_pos): Accept an additional argument
670 DISP_PROP_P; callers changed. Scan at most 5K characters forward
671 for a display string or property. If found, set DISP_PROP_P
672 non-zero.
673
674 * bidi.c (bidi_fetch_char): Accept an additional argument
675 DISP_PROP_P, and pass it to compute_display_string_pos.
676 Only handle text covered by a display string if DISP_PROP_P is returned
677 non-zero. All callers of bidi_fetch_char changed.
678
679 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
680
681 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
682
683 2010-12-03 Don March <don@ohspite.net>
684
685 * keymap.c (Fdefine_key): Fix non-prefix key error message when
686 last character M-[char] is translated to ESC [char] (bug#7541).
687
688 2011-08-02 Kenichi Handa <handa@m17n.org>
689
690 * lisp.h (uniprop_table): Extern it.
691
692 * chartab.c (uniprop_table): Make it non-static.
693
694 2011-08-01 Eli Zaretskii <eliz@gnu.org>
695
696 * xdisp.c (forward_to_next_line_start): Accept additional argument
697 BIDI_IT_PREV, and store into it the state of the bidi iterator had
698 on the newline.
699 (reseat_at_next_visible_line_start): Use the bidi iterator state
700 returned by forward_to_next_line_start to restore the state of
701 it->bidi_it after backing up to previous newline. (Bug#9212)
702
703 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
704
705 * regex.c (re_comp): Protoize.
706 (re_exec): Fix return type.
707 (regexec): Fix type of `ret'. (Bug#9203)
708
709 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
710
711 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
712 This is needed if max-image-size is a floating-point number.
713
714 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
715
716 * print.c (print_object): Print empty symbol as ##.
717
718 * lread.c (read1): Read ## as empty symbol.
719
720 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
721
722 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
723 setting frame foreground color (Bug#9175).
724 (x_set_background_color): Likewise.
725
726 * nsmenu.m (-setText): Size tooltip dimensions precisely to
727 contents (Bug#9176).
728 (EmacsTooltip -init): Remove bezels and add shadows to
729 tooltip windows.
730
731 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
732 or scroll bar (Bug#8470).
733
734 * nsfont.m (nsfont_open): Remove assignment to voffset and
735 unnecessary vars hshink, expand, hd, full_height, min_height.
736 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
737
738 * nsterm.h (nsfont_info): Remove voffset field.
739
740 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
741
742 Implement strike-through and overline on NextStep (Bug#8863).
743
744 * nsfont.m (nsfont_open): Use underline position provided by font,
745 instead of hard-coded value of 2.
746 (nsfont_draw): Call ns_draw_text_decoration instead.
747
748 * nsterm.h: Add declaration for ns_draw_text_decoration.
749
750 * nsterm.m (ns_draw_text_decoration): New function for drawing
751 underline, overline, and strike-through.
752 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
753 ns_draw_text_decoration. Change treatment of cursor drawing to
754 accomodate underlining, etc.
755
756 2011-07-28 Eli Zaretskii <eliz@gnu.org>
757
758 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
759 default.
760
761 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
762
763 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
764 Without this fix, if a signal arrives just after memory fills up,
765 'malloc' might be invoked reentrantly.
766
767 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
768 In other words, assume that every image size is allowed, on non-X
769 hosts. This assumption is probably wrong, but it lets Emacs compile.
770
771 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
772
773 * regex.c (re_iswctype): Convert return values to boolean.
774
775 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
776
777 * xdisp.c (compute_display_string_pos): Don't use cached display
778 string position if the buffer had its restriction changed.
779 (Bug#9184)
780
781 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
782
783 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
784
785 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
786
787 Integer signedness and overflow and related fixes. (Bug#9079)
788
789 * bidi.c: Integer size and overflow fixes.
790 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
791 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
792 (bidi_cache_find_level_change, bidi_cache_ensure_space)
793 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
794 (bidi_find_other_level_edge):
795 Use ptrdiff_t instead of EMACS_INT where either will do.
796 This works better on 32-bit hosts configured --with-wide-int.
797 (bidi_cache_ensure_space): Check for size-calculation overflow.
798 Use % rather than repeated addition, for better worst-case speed.
799 Don't set bidi_cache_size until after xrealloc returns, because it
800 might not return.
801 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
802 (bidi_cache_ensure_space): Also check that the bidi cache size
803 does not exceed that of the largest Lisp string or buffer. See Eli
804 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
805
806 * alloc.c (__malloc_size_t): Remove.
807 All uses replaced by size_t. See Andreas Schwab's note
808 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
809
810 * image.c: Improve checking for integer overflow.
811 (check_image_size): Assume that f is nonnull, since
812 it is always nonnull in practice. This is one less thing to
813 worry about when checking for integer overflow later.
814 (x_check_image_size): New function, which checks for integer
815 overflow issues inside X.
816 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
817 This removes the need for a memory_full check.
818 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
819 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
820 (xbm_read_bitmap_data): Change locals back to 'int', since
821 their values must fit in 'int'.
822 (xpm_load_image, png_load, tiff_load):
823 Invoke x_create_x_image_and_pixmap earlier,
824 to avoid much needless work if the image is too large.
825 (tiff_load): Treat overly large images as if
826 x_create_x_image_and_pixmap failed, not as malloc failures.
827 (gs_load): Use x_check_image_size.
828
829 * gtkutil.c: Omit integer casts.
830 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
831 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
832
833 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
834
835 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
836 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
837 would wrongly return t on a 64-bit host.
838
839 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
840 The plain *_OVERFLOW macros run afoul of GCC bug 49705
841 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
842 and therefore cause GCC to emit a bogus diagnostic in some cases.
843
844 * image.c: Integer signedness and overflow and related fixes.
845 This is not an exhaustive set of fixes, but it's time to
846 record what I've got.
847 (lookup_pixel_color, check_image_size): Remove redundant decls.
848 (check_image_size): Don't assume that arbitrary EMACS_INT values
849 fit in 'int', or that arbitrary 'double' values fit in 'int'.
850 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
851 (tiff_load, imagemagick_load_image):
852 Check for overflow in size calculations.
853 (x_create_x_image_and_pixmap): Remove unnecessary test for
854 xmalloc returning NULL; that can't happen.
855 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
856 (xpm_color_bucket): Use better integer hashing function.
857 (xpm_cache_color): Don't possibly over-allocate memory.
858 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
859 (gif_memory_source):
860 Use ptrdiff_t, not int or size_t, to record sizes.
861 (png_load): Don't assume values greater than 2**31 fit in 'int'.
862 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
863 either works, as we prefer signed integers.
864 (tiff_read_from_memory, tiff_write_from_memory):
865 Return tsize_t, not size_t, since that's what the TIFF API wants.
866 (tiff_read_from_memory): Don't fail simply because the read would
867 go past EOF; instead, return a short read.
868 (tiff_load): Omit no-longer-needed casts.
869 (Fimagemagick_types): Don't assume size fits into 'int'.
870
871 Improve hashing quality when configured --with-wide-int.
872 * fns.c (hash_string): New function, taken from sxhash_string.
873 Do not discard information about ASCII character case; this
874 discarding is no longer needed.
875 (sxhash-string): Use it. Change sig to match it. Caller changed.
876 * lisp.h: Declare it.
877 * lread.c (hash_string): Remove, since we now use fns.c's version.
878 The fns.c version returns a wider integer if --with-wide-int is
879 specified, so this should help the quality of the hashing a bit.
880
881 * emacs.c: Integer overflow minor fix.
882 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
883 Define only if GNU_LINUX.
884 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
885
886 * dispnew.c: Integer signedness and overflow fixes.
887 Remove unnecessary forward decls, that were a maintenance hassle.
888 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
889 All uses changed.
890 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
891 (scrolling_window): Use ptrdiff_t, not int, for byte count.
892 (prepare_desired_row, line_draw_cost):
893 Use int, not unsigned, where either works.
894 (save_current_matrix, restore_current_matrix):
895 Use ptrdiff_t, not size_t, where either works.
896 (init_display): Check for overflow more accurately, and without
897 relying on undefined behavior.
898
899 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
900 Remove, replacing with the new symbols in lisp.h. All uses changed.
901 * fileio.c (make_temp_name):
902 * filelock.c (lock_file_1, lock_file):
903 * xdisp.c (message_dolog):
904 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
905 Use pMd etc. instead.
906 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
907 replacing the pWIDE etc. symbols removed from editfns.c.
908
909 * keyboard.h (num_input_events): Now uintmax_t.
910 This is (very slightly) less likely to mess up due to wraparound.
911 All uses changed.
912
913 * buffer.c: Integer signedness fixes.
914 (alloc_buffer_text, enlarge_buffer_text):
915 Use ptrdiff_t rather than size_t when either will do, as we prefer
916 signed integers.
917
918 * alloc.c: Integer signedness and overflow fixes.
919 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
920 (__malloc_size_t): Default to size_t, not to int.
921 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
922 (Fgarbage_collect, mark_object_loop_halt, mark_object):
923 Prefer ptrdiff_t to size_t when either would do, as we prefer
924 signed integers.
925 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
926 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
927 Now const. Initialize with values that are in range even if char
928 is signed.
929 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
930 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
931 These functions do the right thing with sizes > 2**32.
932 (check_depth): Now ptrdiff_t, not int.
933 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
934 Adjust to new way of storing sizes. Check for size overflow bugs
935 in rest of code.
936 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
937 slightly wrong anyway, as it missed one instance of
938 XMALLOC_OVERRUN_CHECK_OVERHEAD.
939 (refill_memory_reserve): Omit needless cast to size_t.
940 (mark_object_loop_halt): Mark as externally visible.
941
942 * xselect.c: Integer signedness and overflow fixes.
943 (Fx_register_dnd_atom, x_handle_dnd_message):
944 Use ptrdiff_t, not size_t, since we prefer signed.
945 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
946 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
947 x_dnd_atoms_size and x_dnd_atoms_length.
948
949 * doprnt.c: Prefer signed to unsigned when either works.
950 * eval.c (verror):
951 * doprnt.c (doprnt):
952 * lisp.h (doprnt):
953 * xdisp.c (vmessage):
954 Use ptrdiff_t, not size_t, when using or implementing doprnt,
955 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
956 prefer signed arithmetic to avoid comparison confusion.
957 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
958 but is a bit tricky.
959
960 Assume freestanding C89 headers, string.h, stdlib.h.
961 * data.c, doprnt.c, floatfns.c, print.c:
962 Include float.h unconditionally.
963 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
964 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
965 * regex.c: Likewise for stddef.h, string.h.
966 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
967 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
968 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
969 (STDC_HEADERS): Remove obsolete defines.
970 * sysdep.c: Include limits.h unconditionally.
971
972 Assume support for memcmp, memcpy, memmove, memset.
973 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
974 * regex.c (memcmp, memcpy):
975 Remove; we assume C89 now.
976
977 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
978 (__malloc_safe_bcopy): Remove; no longer needed.
979
980 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
981 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
982 well either way, and we prefer signed to unsigned.
983
984 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
985
986 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
987 closes the connection while we're reading (bug#9182).
988
989 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
990
991 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
992 are specified (Bug#9168).
993
994 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
995
996 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
997 Found by GCC static checking and --with-wide-int on a 32-bit host.
998
999 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1000
1001 * xdisp.c (compute_display_string_pos): Fix logic of caching
1002 previous display string position. Initialize cached_prev_pos to
1003 -1. Fixes slow-down at the beginning of a buffer.
1004
1005 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1006
1007 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1008 for attrs[LFACE_FONTSET_INDEX].
1009
1010 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1011
1012 * xml.c (parse_region): Remove unused local
1013 that was recently introduced.
1014
1015 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1016
1017 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1018 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1019
1020 * xdisp.c (move_it_in_display_line_to): Record the best matching
1021 position for TO_CHARPOS while scanning the line, and restore it on
1022 exit if none of the characters scanned was an exact match.
1023 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1024 when exact match is impossible due to invisible text, and the
1025 lines are truncated.
1026
1027 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1028
1029 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1030 for OSX >= 10.7.
1031
1032 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1033
1034 Fix a significant slow-down of cursor motion with C-n, C-p,
1035 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1036 auto-repeat under bidi redisplay in fontified buffers.
1037 * xdisp.c (compute_stop_pos_backwards): New function.
1038 (next_element_from_buffer): Call compute_stop_pos_backwards to
1039 find a suitable prev_stop when we find ourselves before
1040 base_level_stop.
1041 (reseat): Don't look for prev_stop, as that could mean a very long
1042 run.
1043 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1044 <cached_disp_overlay_modiff>: Cache for last found display string
1045 position.
1046 (compute_display_string_pos): Return the cached position if asked
1047 about the same buffer in the same area of character positions, and
1048 the buffer wasn't changed since the time the display string
1049 position was cached.
1050
1051 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1052
1053 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1054 is an integer, which is important for empty lines. (Bug#9149)
1055
1056 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1057
1058 * frame.c (Fmodify_frame_parameters): In tty case, update the
1059 default face if necessary (Bug#4238).
1060
1061 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1062
1063 * editfns.c (Fstring_to_char): No need to explain what a character
1064 is in the docstring (Bug#6576).
1065
1066 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1067
1068 * xml.c (parse_region): Make sure we always return a tree.
1069
1070 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1071
1072 * xml.c (parse_region): If a document contains only comments,
1073 return that, too.
1074
1075 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1076
1077 * xml.c (make_dom): Return comments, too.
1078
1079 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 Port to OpenBSD.
1082 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1083 and the surrounding thread.
1084 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1085 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1086 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1087 timer goes off.
1088 * s/openbsd.h (BROKEN_SIGIO): Define.
1089 * unexelf.c (unexec) [__OpenBSD__]:
1090 Don't update the .mdebug section of the Alpha COFF symbol table.
1091
1092 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1093
1094 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1095 (bug#8460).
1096
1097 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1098
1099 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1100 This fixes some race conditions on the permissions of any newly
1101 created file.
1102
1103 * alloc.c (valid_pointer_p): Use pipe, not open.
1104 This fixes some permissions issues when debugging.
1105
1106 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1107 If fchown fails to set both uid and gid, try to set just gid,
1108 as that is sometimes allowed. Adjust the file's mode to eliminate
1109 setuid or setgid bits that are inappropriate if fchown fails.
1110
1111 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1112
1113 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1114 to compare Lisp_Objects.
1115 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1116 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1117 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1118
1119 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1120
1121 * lread.c (read_integer): Unread even EOF character.
1122 (read1): Likewise. Properly record start position of symbol.
1123
1124 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1125 symbol character follows.
1126
1127 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1128
1129 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1130 This works around a problem with the previous change to Fcopy_file.
1131 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1132 and without this change, GCC might complain about discarding
1133 fchown's return value.
1134
1135 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1136
1137 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1138
1139 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1140
1141 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1142
1143 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1144
1145 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1146 it's used from the C level.
1147
1148 * process.c: Use the same condition for POLL_FOR_INPUT in both
1149 keyboard.c and process.c (bug#1858).
1150
1151 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1152
1153 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1154 (Fgnutls_boot): Use it.
1155
1156 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1157
1158 * doc.c (Fsubstitute_command_keys): Revert last change.
1159
1160 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1161
1162 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1163 quotes the next character, and doesn't affect other longer
1164 sequences (bug#8935).
1165
1166 * lread.c (syms_of_lread): Clarify that is isn't only
1167 `eval-buffer' and `eval-defun' that's affected by
1168 `lexical-binding' (bug#8460).
1169
1170 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1171
1172 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1173 bidi redisplay when a line includes both an image and is
1174 truncated.
1175
1176 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 Fix minor problems found by static checking.
1179 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1180 (elsz): Now a signed constant, not a size_t var. We prefer signed
1181 types to unsigned, to avoid integer comparison confusion. Without
1182 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1183 "cannot optimize loop, the loop counter may overflow", a symptom
1184 of the confusion.
1185 * indent.c (Fvertical_motion): Mark locals as initialized.
1186 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1187
1188 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1189
1190 * search.c (Fre_search_backward): Mention `case-fold-search' in
1191 all the re_search_* functions (bug#8138).
1192
1193 * keyboard.c (Fopen_dribble_file): Document when the file is
1194 closed (bug#8056).
1195
1196 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1197
1198 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1199 bidi_cache_idx.
1200
1201 Support bidi reordering of display and overlay strings.
1202 * xdisp.c (compute_display_string_pos)
1203 (compute_display_string_end): Accept additional argument STRING.
1204 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1205 (reseat_to_string): Initialize bidi_it->string.s and
1206 bidi_it->string.schars.
1207 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1208 NULL (avoids a crash in bidi_paragraph_init).
1209 Initialize itb.string.lstring.
1210 (init_iterator): Call bidi_init_it only of a valid
1211 buffer position was specified. Initialize paragraph_embedding to
1212 L2R.
1213 (reseat_to_string): Initialize the bidi iterator.
1214 (display_string): If we need to ignore text properties of
1215 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1216 original value of -1 will not work with bidi.)
1217 (compute_display_string_pos): First arg is now struct
1218 `text_pos *'; all callers changed. Support display properties on
1219 Lisp strings.
1220 (compute_display_string_end): Support display properties on Lisp
1221 strings.
1222 (init_iterator, reseat_1, reseat_to_string): Initialize the
1223 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1224 when iterating on a string not from display properties).
1225 (compute_display_string_pos, compute_display_string_end):
1226 Fix calculation of the object to scan. Fixes an error when using
1227 arrow keys.
1228 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1229 base_level_stop; instead, set base_level_stop to BEGV.
1230 Fixes crashes in vertical-motion.
1231 (next_element_from_buffer): Improve commentary for when
1232 the iterator is before prev_stop.
1233 (init_iterator): Initialize bidi_p from the default value of
1234 bidi-display-reordering, not from buffer-local value. Use the
1235 buffer-local value only if initializing for buffer iteration.
1236 (handle_invisible_prop): Support invisible properties on strings
1237 that are being bidi-reordered.
1238 (set_iterator_to_next): Support bidi reordering of C strings and
1239 Lisp strings.
1240 (next_element_from_string): Support bidi reordering of Lisp
1241 strings.
1242 (handle_stop_backwards): Support Lisp strings as well.
1243 (display_string): Support display of R2L glyph rows.
1244 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1245 (init_iterator): Don't initialize it->bidi_p for strings
1246 here.
1247 (reseat_to_string): Initialize it->bidi_p for strings here.
1248 (next_element_from_string, next_element_from_c_string)
1249 (next_element_from_buffer): Add xassert's for correspondence
1250 between IT's object being iterated and it->bidi_it.string
1251 structure.
1252 (face_before_or_after_it_pos): Support bidi iteration.
1253 (next_element_from_c_string): Handle the case of the first string
1254 character that is not the first one in the visual order.
1255 (get_visually_first_element): New function, refactored from common
1256 parts of next_element_from_buffer, next_element_from_string, and
1257 next_element_from_c_string.
1258 (tool_bar_lines_needed, redisplay_tool_bar)
1259 (display_menu_bar): Force left-to-right direction. Add a FIXME
1260 comment for making that be controlled by a user option.
1261 (push_it, pop_it): Save and restore the state of the
1262 bidi iterator. Save and restore the bidi_p flag.
1263 (pop_it): Iterate out of display property for string iteration as
1264 well.
1265 (iterate_out_of_display_property): Support iteration over strings.
1266 (handle_single_display_spec): Set up it->bidi_it for iteration
1267 over a display string, and call bidi_init_it.
1268 (handle_single_display_spec, next_overlay_string)
1269 (get_overlay_strings_1, push_display_prop): Set up the bidi
1270 iterator for displaying display or overlay strings.
1271 (forward_to_next_line_start): Don't use the shortcut if
1272 bidi-iterating.
1273 (back_to_previous_visible_line_start): If handle_display_prop
1274 pushed the iterator stack, restore the internal state of the bidi
1275 iterator by calling bidi_pop_it same number of times.
1276 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1277 and we are bidi-iterating, don't decrement the iterator position;
1278 instead, set the first_elt flag in the bidi iterator, to produce
1279 the same effect.
1280 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1281 (push_display_prop): xassert that we are iterating a buffer.
1282 (push_it, pop_it): Save and restore paragraph_embedding member.
1283 (handle_single_display_spec, next_overlay_string)
1284 (get_overlay_strings_1, reseat_1, reseat_to_string)
1285 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1286 correctly. Don't assume unibyte strings are not bidi-reordered.
1287 (compute_display_string_pos)
1288 (compute_display_string_end): Fix handling the case of C string.
1289 (push_it, pop_it): Save and restore from_disp_prop_p.
1290 (handle_single_display_spec, push_display_prop): Set the
1291 from_disp_prop_p flag.
1292 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1293 (pop_it): Call iterate_out_of_display_property only if we are
1294 popping after iteration over a string that came from a display
1295 property. Fix a typo in popping stretch info. Add an assertion
1296 for verifying that the iterator position is in sync with the bidi
1297 iterator.
1298 (handle_single_display_spec, get_overlay_strings_1)
1299 (push_display_prop): Fix initialization of paragraph direction for
1300 string when that of the parent object is not yet determined.
1301 (reseat_1): Call bidi_init_it to resync the bidi
1302 iterator with IT's position. (Bug#7616)
1303 (find_row_edges): If ROW->start.pos gives position
1304 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1305 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1306 Reset the from_disp_prop_p flag.
1307 (SAVE_IT, RESTORE_IT): New macros.
1308 (pos_visible_p, face_before_or_after_it_pos)
1309 (back_to_previous_visible_line_start)
1310 (move_it_in_display_line_to, move_it_in_display_line)
1311 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1312 (try_scrolling, redisplay_window, display_line): Use them when
1313 saving a temporary copy of the iterator and restoring it back.
1314 (back_to_previous_visible_line_start, reseat_1)
1315 (init_iterator): Empty the bidi cache "stack".
1316 (move_it_in_display_line_to): If iterator ended up at
1317 EOL, but we never saw any buffer positions smaller than
1318 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1319 motion in bidi-reordered lines.
1320 (move_it_in_display_line_to): Record prev_method and prev_pos
1321 immediately before the call to set_iterator_to_next. Fixes cursor
1322 motion in bidi-reordered lines with stretch glyphs and strings
1323 displayed in margins. (Bug#8133) (Bug#8867)
1324 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1325 TO_CHARPOS.
1326 (pos_visible_p): Support positions in bidi-reordered lines.
1327 Save and restore bidi cache.
1328
1329 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1330 (bidi_paragraph_info): Delete unused struct.
1331 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1332 (bidi_cache_start): New variable.
1333 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1334 to zero.
1335 (bidi_cache_fetch_state, bidi_cache_search)
1336 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1337 (bidi_cache_find, bidi_peek_at_next_level)
1338 (bidi_level_of_next_char, bidi_find_other_level_edge)
1339 (bidi_move_to_visually_next): Compare cache index with
1340 bidi_cache_start rather than with zero.
1341 (bidi_fetch_char): Accept new argument STRING; all callers
1342 changed. Support iteration over a string. Support strings with
1343 display properties. Support unibyte strings. Fix the type of
1344 `len' according to what STRING_CHAR_AND_LENGTH expects.
1345 (bidi_paragraph_init, bidi_resolve_explicit_1)
1346 (bidi_resolve_explicit, bidi_resolve_weak)
1347 (bidi_level_of_next_char, bidi_move_to_visually_next):
1348 Support iteration over a string.
1349 (bidi_set_sor_type, bidi_resolve_explicit_1)
1350 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1351 can now be zero (for strings); special values 0 and -1 were
1352 changed to -1 and -2, respectively.
1353 (bidi_char_at_pos): New function.
1354 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1355 Call it instead of FETCH_MULTIBYTE_CHAR.
1356 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1357 initialized to valid values.
1358 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1359 values.
1360 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1361 the test for valid cached positions. Fix the logic for looking up
1362 the sentinel state in the cache. GCPRO the Lisp string we are
1363 iterating.
1364 (bidi_push_it, bidi_pop_it): New functions.
1365 (bidi_initialize): Initialize the bidi cache start stack pointer.
1366 (bidi_cache_ensure_space): New function, refactored from part of
1367 bidi_cache_iterator_state. Don't assume the required size is just
1368 one BIDI_CACHE_CHUNK away.
1369 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1370 (bidi_count_bytes, bidi_char_at_pos): New functions.
1371 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1372 always valid if bidi_cache_idx is valid.
1373 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1374 is valid if it's going to be used.
1375 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1376 (bidi_cache_fetch_state, bidi_cache_search)
1377 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1378 (bidi_cache_iterator_state, bidi_cache_find)
1379 (bidi_find_other_level_edge, bidi_cache_start_stack):
1380 All variables related to cache indices are now EMACS_INT.
1381
1382 * dispextern.h (struct bidi_string_data): New structure.
1383 (struct bidi_it): New member `string'. Make flag members be 1-bit
1384 fields, and put them last in the struct.
1385 (compute_display_string_pos, compute_display_string_end):
1386 Update prototypes.
1387 (bidi_push_it, bidi_pop_it): Add prototypes.
1388 (struct iterator_stack_entry): New members bidi_p,
1389 paragraph_embedding, and from_disp_prop_p.
1390 (struct it): Member bidi_p is now a bit field 1 bit wide.
1391 (bidi_shelve_cache, bidi_unshelve_cache):
1392 Declare prototypes.
1393
1394 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1395 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1396 and vector-like objects.
1397
1398 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1399 cache around display iteration.
1400
1401 * window.c (Fwindow_end, window_scroll_pixel_based)
1402 (displayed_window_lines, Frecenter): Save and restore the bidi
1403 cache around display iteration.
1404
1405 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1406
1407 * editfns.c (Fdelete_region): Clarify the use of the named
1408 parameters (bug#6788).
1409
1410 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1411
1412 * indent.c (Fvertical_motion): Set and restore w->pointm when
1413 saving and restoring the window's buffer (Bug#9006).
1414
1415 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1416
1417 * editfns.c (Fstring_to_char): Clarify just what is returned
1418 (bug#6576). Text by Eli Zaretskii.
1419
1420 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1421
1422 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1423
1424 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1425
1426 * buffer.c (mmap_find): Fix a typo.
1427
1428 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1429
1430 Fix execution of x selection hooks.
1431 * xselect.c (Qx_lost_selection_functions)
1432 (Qx_sent_selection_functions): New vars.
1433 (syms_of_xselect): DEFSYM them.
1434 (x_handle_selection_request): Pass Qx_sent_selection_functions
1435 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1436 (x_handle_selection_clear,x_clear_frame_selections):
1437 Pass Qx_lost_selection_functions rather than
1438 Vx_lost_selection_functions to Frun_hook_with_args.
1439
1440 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1443 The old code sometimes used this field without initializing it.
1444
1445 * alloc.c (gc_sweep): Don't read past end of array.
1446 In theory, the old code could also have corrupted Emacs internals,
1447 though it'd be very unlikely.
1448
1449 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1450
1451 * character.c (Fcharacterp): Don't advertise optional ignored
1452 argument. (Bug#4026)
1453
1454 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1455
1456 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1457 key" (bug#4257).
1458
1459 * window.c (Fset_window_start): Doc fix (bug#4199).
1460 (Fset_window_hscroll): Ditto.
1461
1462 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1463
1464 Fix minor new problems caught by GCC 4.6.1.
1465 * term.c (init_tty): Remove unused local.
1466 * xsettings.c (store_monospaced_changed): Define this function only
1467 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1468 not used otherwise.
1469
1470 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1471
1472 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1473
1474 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1475
1476 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1477 are the mini-buffer and the echo area (bug#3320).
1478
1479 * term.c (init_tty): Remove support for supdup, c10 and perq
1480 terminals, which are no longer supported (bug#1482).
1481
1482 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1483
1484 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1485
1486 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1487
1488 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1489 for non-popups (Bug#3642).
1490
1491 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1492
1493 * alloc.c (reset_malloc_hooks): Protoize.
1494 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1495 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1496 * cm.c (losecursor): Likewise.
1497 * data.c (fmod): Likewise.
1498 * dispnew.c (swap_glyphs_in_rows): Likewise.
1499 * emacs.c (memory_warning_signal): Likewise.
1500 * floatfns.c (float_error): Likewise.
1501 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1502 (otf_open, font_otf_capability, generate_otf_features)
1503 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1504 Likewise.
1505 * image.c (pbm_read_file): Likewise.
1506 * indent.c (string_display_width): Likewise.
1507 * intervals.c (check_for_interval, search_for_interval)
1508 (inc_interval_count, count_intervals, root_interval)
1509 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1510 * lread.c (defalias): Likewise.
1511 * ralloc.c (r_alloc_check): Likewise.
1512 * regex.c (set_image_of_range_1, set_image_of_range)
1513 (regex_grow_registers): Likewise.
1514 * sysdep.c (strerror): Likewise.
1515 * termcap.c (valid_filename_p, tprint, main): Likewise.
1516 * tparam.c (main): Likewise.
1517 * unexhp9k800.c (run_time_remap, save_data_space)
1518 (update_file_ptrs, read_header, write_header, calculate_checksum)
1519 (copy_file, copy_rest, display_header): Likewise.
1520 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1521 Likewise.
1522 * xdisp.c (check_it): Likewise.
1523 * xfaces.c (register_color, unregister_color, unregister_colors):
1524 Likewise.
1525 * xfns.c (print_fontset_result): Likewise.
1526 * xrdb.c (member, fatal, main): Likewise.
1527
1528 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1529
1530 Fix minor problems found by static checking (Bug#9031).
1531 * chartab.c (char_table_set_range, map_sub_char_table):
1532 Remove unused locals.
1533 (uniprop_table): Now static.
1534 * composite.c (_work_char): Remove unused static var.
1535
1536 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1537
1538 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1539
1540 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1541
1542 * gtkutil.c (qttip_cb): Remove code without function.
1543
1544 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1545
1546 * w32.c (pthread_sigmask): New stub.
1547
1548 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1549
1550 Use pthread_sigmask, not sigprocmask (Bug#9010).
1551 sigprocmask is portable only for single-threaded applications, and
1552 Emacs can be multi-threaded when it uses GTK.
1553 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1554 (LIBES): Use it.
1555 * callproc.c (Fcall_process):
1556 * process.c (create_process):
1557 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1558 Use pthread_sigmask, not sigprocmask.
1559
1560 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1561
1562 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1563 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1564 wrong (Bug#8591).
1565
1566 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1567
1568 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1569 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1570 (xg_hide_tooltip): Fix comment.
1571
1572 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1573 in registerServicesMenuSendTypes.
1574 (validRequestorForSendType): Don't check ns_return_types.
1575
1576 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1577 ns_return_type.
1578
1579 2011-07-08 Jason Rumney <jasonr@gnu.org>
1580
1581 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1582 frame struct members of non-existent frames (Bug#6284).
1583
1584 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1585
1586 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1587 variable firstTime not needed on OSX >= 10.6.
1588 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1589 >= 10.5. Use setKnobProportion, setDoubleValue.
1590
1591 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1592 (MAC_OS_X_VERSION_10_5): Define if not defined.
1593 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1594 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1595 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1596
1597 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1598 cString and lossyCString on OSX >= 10.4
1599
1600 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1601 sizeToFit on OSX >= 10.2.
1602
1603 * nsimage.m (allocInitFromFile): Don't use deprecated method
1604 bestRepresentationForDevice on OSX >= 10.6.
1605
1606 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1607 to avoid warning.
1608
1609 * emacs.c: Declare unexec_init_emacs_zone.
1610
1611 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1612
1613 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1614
1615 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1616 on svcsMenu (Bug#8842).
1617
1618 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1619 ns_return_types.
1620 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1621
1622 * nsterm.m (QUTF8_STRING): Declare.
1623 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1624 (validRequestorForSendType): Return type is (id).
1625 Change indexOfObjectIdenticalTo to indexOfObject.
1626 Check if we have local selection before returning self (Bug#8842).
1627 (writeSelectionToPasteboard): Put local selection into paste board
1628 if we have a local selection (Bug#8842).
1629 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1630
1631 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1632 (ns_get_local_selection): Declare.
1633
1634 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1635
1636 * keymap.c (describe_map_tree): Don't insert a double newline at
1637 the end of the buffer (bug#1169) and return whether we inserted
1638 something.
1639
1640 * callint.c (Fcall_interactively): Change "reading args" to
1641 "providing args" to try to clarify what it does (bug#1010).
1642
1643 2011-07-07 Kenichi Handa <handa@m17n.org>
1644
1645 * composite.c (composition_compute_stop_pos): Ignore a static
1646 composition starting before CHARPOS (Bug#8915).
1647
1648 * xdisp.c (handle_composition_prop): Likewise.
1649
1650 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1651
1652 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1653 (Bug#9015)
1654
1655 2011-07-07 Kenichi Handa <handa@m17n.org>
1656
1657 * character.h (unicode_category_t): New enum type.
1658
1659 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1660 (Qchar_code_property_table): New variable.
1661 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1662 (UNIPROP_COMPRESSED_FORM_P): New macros.
1663 (char_table_ascii): Uncompress the compressed values.
1664 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1665 Uncompress the compressed values.
1666 (sub_char_table_ref_and_range): Likewise.
1667 (char_table_ref_and_range): Uncompress the compressed values.
1668 (sub_char_table_set): New arg is_uniprop. Callers changed.
1669 Uncompress the compressed values.
1670 (sub_char_table_set_range): Args changed. Callers changed.
1671 (char_table_set_range): Adjuted for the above change.
1672 (map_sub_char_table): Delete args default_val and parent. Add arg
1673 top. Give decoded values to a Lisp function.
1674 (map_char_table): Adjust for the above change. Give decoded
1675 values to a Lisp function. Gcpro more variables.
1676 (uniprop_table_uncompress)
1677 (uniprop_decode_value_run_length): New functions.
1678 (uniprop_decoder, uniprop_decoder_count): New variables.
1679 (uniprop_get_decoder, uniprop_encode_value_character)
1680 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1681 New functions.
1682 (uniprop_encoder, uniprop_encoder_count): New variables.
1683 (uniprop_get_encoder, uniprop_table)
1684 (Funicode_property_table_internal, Fget_unicode_property_internal)
1685 (Fput_unicode_property_internal): New functions.
1686 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1687 Sunicode_property_table_internal, Sget_unicode_property_internal,
1688 and Sput_unicode_property_internal. Defvar_lisp
1689 char-code-property-alist.
1690
1691 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1692 Vunicode_category_table.
1693
1694 * font.c (font_range): Adjust for the change of
1695 Vunicode_category_table.
1696
1697 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1698
1699 * m/iris4d.h: Remove file, move contents ...
1700 * s/irix6-5.h: ... here.
1701
1702 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1703
1704 Remove unportable assumption about struct layout (Bug#8884).
1705 * alloc.c (mark_buffer):
1706 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1707 (clone_per_buffer_values): Don't assume that
1708 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1709 This isn't true in general, and it's particularly not true
1710 if Emacs is configured with --with-wide-int.
1711 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1712 New macros, used in the buffer.c change.
1713
1714 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1715
1716 * xsettings.c: Use both GConf and GSettings if both are available.
1717 (store_config_changed_event): Add comment.
1718 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1719 (store_tool_bar_style_changed): New functions.
1720 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1721 (struct xsettings): Move font inside HAVE_XFT.
1722 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1723 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1724 Move inside HAVE_XFT.
1725 (something_changed_gsettingsCB): Rename from something_changedCB.
1726 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1727 also.
1728 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1729 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1730 (something_changed_gconfCB): Rename from something_changedCB.
1731 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1732 (parse_settings): Move check for font inside HAVE_XFT.
1733 (read_settings, apply_xft_settings): Add comment.
1734 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1735 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1736 call store_font_name_changed.
1737 (xft_settings_event): Add comment.
1738 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1739 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1740 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1741 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1742 (xsettings_initialize): Call init_gsettings last.
1743 (xsettings_get_system_font, xsettings_get_system_normal_font):
1744 Add comment.
1745
1746 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1747
1748 Random fixes. E.g., (random) never returned negative values.
1749 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1750 subseconds part to the entropy, as that's a bit more random.
1751 Prefer signed to unsigned, since the signedness doesn't matter and
1752 in general we prefer signed. When given a limit, use a
1753 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1754 latter isn't right if USE_2_TAGS_FOR_INTS.
1755 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1756 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1757
1758 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1759
1760 * textprop.c (text_property_stickiness):
1761 Obey Vtext_property_default_nonsticky.
1762 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1763 * w32fns.c (syms_of_w32fns):
1764 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1765
1766 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1767
1768 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1769 This is more efficient than Ffile_directory_p and avoids a minor race.
1770
1771 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1772
1773 * buffer.c (Foverlay_put): Say what the return value is
1774 (bug#7835).
1775
1776 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1777 is a directory before asking whether to use the file name
1778 (bug#7564).
1779 (barf_or_query_if_file_exists): Make the "File is a directory"
1780 error be more correct.
1781
1782 * fns.c (Frequire): Remove the mention of the .gz files, since
1783 that's installation-specific, but keep the mention of
1784 `get-load-suffixes'.
1785
1786 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1789 Report string overflow if the output is too long.
1790
1791 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1792
1793 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1794 (syms_of_gnutls): Remove duplicate DEFSYM for
1795 Qgnutls_bootprop_verify_hostname_error, an error for
1796 Qgnutls_bootprop_verify_error (which is no longer used).
1797
1798 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1799 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1800 Also (re)move comments that are misplaced or no longer relevant.
1801
1802 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1803
1804 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1805
1806 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1807
1808 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1809 and background color parameters if they have been changed.
1810
1811 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1812
1813 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1814
1815 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 * xsettings.c (SYSTEM_FONT): Define only when used.
1818 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1819
1820 * keymap.c (access_keymap_1): Now static.
1821
1822 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1823
1824 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1825 leave any prefix arg for the up event (Bug#1586).
1826
1827 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1828
1829 * lread.c (syms_of_lread): Mention single symbols defined by
1830 `defvar' or `defconst' (bug#7154).
1831
1832 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1833 (Frequire): Mention get-load-suffixes.
1834
1835 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1836
1837 * window.h (window): Remove clone_number slot.
1838 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1839 Remove.
1840 (make_parent_window, make_window, saved_window)
1841 (Fset_window_configuration, save_window_save): Don't deal with
1842 clone numbers.
1843 * buffer.c (Qclone_number): Remove declaration.
1844 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1845
1846 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1847
1848 Add multiple inheritance to keymaps.
1849 * keymap.c (Fmake_composed_keymap): New function.
1850 (Fset_keymap_parent): Simplify.
1851 (fix_submap_inheritance): Remove.
1852 (access_keymap_1): New function extracted from access_keymap to handle
1853 embedded parents and handle lists of maps.
1854 (access_keymap): Use it.
1855 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1856 (Fcopy_keymap): Handle embedded parents.
1857 (Fcommand_remapping, define_as_prefix): Simplify.
1858 (Fkey_binding): Simplify.
1859 (syms_of_keymap): Move minibuffer-local-completion-map,
1860 minibuffer-local-filename-completion-map,
1861 minibuffer-local-must-match-map, and
1862 minibuffer-local-filename-must-match-map to Elisp.
1863 (syms_of_keymap): Defsubr make-composed-keymap.
1864 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1865 (parse_menu_item): Trivial simplification.
1866
1867 2011-07-01 Glenn Morris <rgm@gnu.org>
1868
1869 * Makefile.in (SETTINGS_LIBS): Fix typo.
1870
1871 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1872
1873 * coding.c (Fencode_coding_string): Record the last coding system
1874 used, as the function doc string says (bug#8738).
1875
1876 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1877
1878 * xsettings.c (store_monospaced_changed): Take new font as arg and
1879 check for change against current_mono_font.
1880 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1881 (emacs_settings_constructor, emacs_settings_get_property)
1882 (emacs_settings_set_property, emacs_settings_class_init)
1883 (emacs_settings_init, gsettings_obj): Remove.
1884 (something_changedCB): New function for HAVE_GSETTINGS.
1885 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1886 with value as argument.
1887 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1888 g_settings_new (Bug#8967). Do not create gsettings_obj.
1889 Remove calls to g_settings_bind. Connect something_changedCB to
1890 "changed".
1891
1892 * xgselect.c: Add defined (HAVE_GSETTINGS).
1893 (xgselect_initialize): Ditto.
1894
1895 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1896 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1897 xg_select.
1898
1899 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1900
1901 * eval.c (struct backtrace): Simplify and port the data structure.
1902 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1903 signed bit field, as this assumption is not portable and it makes
1904 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1905 "char debug_on_exit : 1" as this is not portable either; instead,
1906 use the portable "unsigned int debug_on_exit : 1". Remove unused
1907 member evalargs. Remove obsolete comments about cc bombing out.
1908
1909 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1910
1911 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1912 Let HAVE_GSETTINGS override HAVE_GCONF.
1913 (store_monospaced_changed): New function.
1914 (EMACS_SETTINGS): A new type derived from GObject to handle
1915 GSettings notifications.
1916 (emacs_settings_constructor, emacs_settings_get_property)
1917 (emacs_settings_set_property, emacs_settings_class_init):
1918 New functions.
1919 (gsettings_client, gsettings_obj): New variables.
1920 (GSETTINGS_SCHEMA): New define.
1921 (something_changedCB): Call store_monospaced_changed.
1922 (init_gsettings): New function.
1923 (xsettings_initialize): Call init_gsettings.
1924 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1925 to NULL.
1926
1927 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1928 GCONF_CFLAGS/LIBS.
1929
1930 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1931
1932 * window.c (resize_root_window, grow_mini_window)
1933 (shrink_mini_window): Rename Qresize_root_window to
1934 Qwindow_resize_root_window and Qresize_root_window_vertically to
1935 Qwindow_resize_root_window_vertically.
1936
1937 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1938
1939 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1940
1941 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1942
1943 * makefile.w32-in: Redesign dependencies so they reflect more
1944 clearly which files are directly included by each source file,
1945 and not through other includes.
1946
1947 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1948
1949 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1950 (sort_overlays, overlay_strings): When an overlay's clone number
1951 matches the window's clone number process the overlay even if
1952 the overlay's window property doesn't match the current window.
1953
1954 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1955 (Fwindow_hchild): Rename to Fwindow_left_child.
1956 (Fwindow_next): Rename to Fwindow_next_sibling.
1957 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1958 (resize_window_check): Rename to window_resize_check.
1959 (resize_window_apply): Rename to window_resize_apply.
1960 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1961 (Fdelete_other_windows_internal, resize_frame_windows)
1962 (Fsplit_window_internal, Fdelete_window_internal)
1963 (grow_mini_window, shrink_mini_window)
1964 (Fresize_mini_window_internal): Fix callers accordingly.
1965
1966 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1967
1968 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1969 (emacs_fixed_set_min_size): Remove.
1970 (emacs_fixed_new): Take frame as argument.
1971
1972 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1973 (_EmacsFixedPrivate): Remove minwidth/height.
1974 Add struct frame *f.
1975 (emacs_fixed_init): Initialize priv->f.
1976 (get_parent_class, emacs_fixed_set_min_size): Remove.
1977 (emacs_fixed_new): Set priv->f to argument.
1978 (emacs_fixed_get_preferred_width)
1979 (emacs_fixed_get_preferred_height): Use min_width/height from
1980 frames size_hint to set minimum and natural (Bug#8919).
1981 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1982 and use min_width/height from frames size_hint to set
1983 min_width/height (Bug#8919).
1984
1985 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1986 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1987 Fix indentation.
1988
1989 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1990
1991 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1992 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1993 called at ZV.
1994
1995 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1996
1997 * process.c (wait_reading_process_output): Bypass select if
1998 waiting for a cell while ignoring keyboard input, and input is
1999 pending. Suggested by Jan Djärv (Bug#8869).
2000
2001 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 Use gnulib's dup2 module instead of rolling our own.
2004 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2005
2006 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2007
2008 * dispnew.c (scrolling_window): Before scrolling, turn off a
2009 mouse-highlight in the window being scrolled.
2010
2011 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2012
2013 Move DEFSYM to lisp.h and use everywhere.
2014
2015 * character.h (DEFSYM): Move declaration...
2016 * lisp.h (DEFSYM): ...here.
2017
2018 * gnutls.c:
2019 * minibuf.c:
2020 * w32menu.c:
2021 * w32proc.c:
2022 * w32select.c: Don't include character.h.
2023
2024 * alloc.c (syms_of_alloc):
2025 * buffer.c (syms_of_buffer):
2026 * bytecode.c (syms_of_bytecode):
2027 * callint.c (syms_of_callint):
2028 * casefiddle.c (syms_of_casefiddle):
2029 * casetab.c (init_casetab_once):
2030 * category.c (init_category_once, syms_of_category):
2031 * ccl.c (syms_of_ccl):
2032 * cmds.c (syms_of_cmds):
2033 * composite.c (syms_of_composite):
2034 * dbusbind.c (syms_of_dbusbind):
2035 * dired.c (syms_of_dired):
2036 * dispnew.c (syms_of_display):
2037 * doc.c (syms_of_doc):
2038 * editfns.c (syms_of_editfns):
2039 * emacs.c (syms_of_emacs):
2040 * eval.c (syms_of_eval):
2041 * fileio.c (syms_of_fileio):
2042 * fns.c (syms_of_fns):
2043 * frame.c (syms_of_frame):
2044 * fringe.c (syms_of_fringe):
2045 * insdel.c (syms_of_insdel):
2046 * keymap.c (syms_of_keymap):
2047 * lread.c (init_obarray, syms_of_lread):
2048 * macros.c (syms_of_macros):
2049 * msdos.c (syms_of_msdos):
2050 * print.c (syms_of_print):
2051 * process.c (syms_of_process):
2052 * search.c (syms_of_search):
2053 * sound.c (syms_of_sound):
2054 * syntax.c (init_syntax_once, syms_of_syntax):
2055 * terminal.c (syms_of_terminal):
2056 * textprop.c (syms_of_textprop):
2057 * undo.c (syms_of_undo):
2058 * w32.c (globals_of_w32):
2059 * window.c (syms_of_window):
2060 * xdisp.c (syms_of_xdisp):
2061 * xfaces.c (syms_of_xfaces):
2062 * xfns.c (syms_of_xfns):
2063 * xmenu.c (syms_of_xmenu):
2064 * xsettings.c (syms_of_xsettings):
2065 * xterm.c (syms_of_xterm): Use DEFSYM.
2066
2067 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2068
2069 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2070
2071 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 Integer and buffer overflow fixes (Bug#8873).
2074
2075 * print.c (printchar, strout): Check for string overflow.
2076 (PRINTPREPARE, printchar, strout):
2077 Don't set size unless allocation succeeds.
2078
2079 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2080 for sizes. Check for string overflow more accurately.
2081 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2082
2083 * macros.c: Integer and buffer overflow fixes.
2084 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2085 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2086 Use ptrdiff_t, not int, for sizes.
2087 Don't increment bufsize until after realloc succeeds.
2088 Check for size-calculation overflow.
2089 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2090
2091 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2092
2093 * lread.c: Integer overflow fixes.
2094 (read_integer): Radix is now EMACS_INT, not int,
2095 to improve quality of diagnostics for out-of-range radices.
2096 Calculate buffer size correctly for out-of-range radices.
2097 (read1): Check for integer overflow in radices, and in
2098 read-circle numbers.
2099 (read_escape): Avoid int overflow.
2100 (Fload, openp, read_buffer_size, read1)
2101 (substitute_object_recurse, read_vector, read_list, map_obarray):
2102 Use ptrdiff_t, not int, for sizes.
2103 (read1): Use EMACS_INT, not int, for sizes.
2104 Check for size overflow.
2105
2106 * image.c (cache_image): Check for size arithmetic overflow.
2107
2108 * lread.c: Integer overflow issues.
2109 (saved_doc_string_size, saved_doc_string_length)
2110 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2111 Now ptrdiff_t, not int.
2112 (read1): Don't assume doc string length fits in int. Check for
2113 out-of-range doc string lengths.
2114 (read_list): Don't assume file position fits in int.
2115 (read_escape): Check for hex character overflow.
2116
2117 2011-06-22 Leo Liu <sdl.web@gmail.com>
2118
2119 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2120 Move to minibuffer.el.
2121
2122 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2123
2124 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2125 The following patches are for when GLYPH_DEBUG && !XASSERT.
2126 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2127 * dispnew.c (flush_stdout):
2128 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2129 Mark as externally visible.
2130 * dispnew.c (check_window_matrix_pointers): Now static.
2131 * dispnew.c (window_to_frame_vpos):
2132 * xfns.c (unwind_create_frame):
2133 * xterm.c (x_check_font): Remove unused local.
2134 * scroll.c (CHECK_BOUNDS):
2135 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2136 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2137 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2138 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2139 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2140 Now static.
2141 (debug_method_add): Use va_list and vsprintf rather than relying
2142 on undefined behavior with wrong number of arguments.
2143 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2144 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2145 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2146 since we're not interested in debugging glyphs with old libraries.
2147 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2148 GCC 4.6.0's static checking.
2149
2150 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2151
2152 Integer overflow and signedness fixes (Bug#8873).
2153 A few related buffer overrun fixes, too.
2154
2155 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2156
2157 * dispextern.h (struct face.stipple):
2158 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2159 (x_bitmap_mask, x_allocate_bitmap_record)
2160 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2161 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2162 (x_create_bitmap_from_xpm_data):
2163 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2164 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2165 (.bitmaps_last):
2166 * xfaces.c (load_pixmap):
2167 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2168 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2169 (.bitmaps_last, struct x_output.icon_bitmap):
2170 Use ptrdiff_t, not int, for bitmap indexes.
2171 (x_allocate_bitmap_record): Check for size overflow.
2172 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2173
2174 Use ptrdiff_t, not int, for overlay counts.
2175 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2176 * editfns.c (overlays_around, get_pos_property):
2177 * textprop.c (get_char_property_and_overlay):
2178 * xdisp.c (next_overlay_change, note_mouse_highlight):
2179 * xfaces.c (face_at_buffer_position):
2180 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2181 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2182 (Fnext_overlay_change, Fprevious_overlay_change)
2183 (mouse_face_overlay_overlaps, Foverlays_in):
2184 Use ptrdiff_t, not int, for sizes.
2185 (overlays_at, overlays_in): Check for size-calculation overflow.
2186
2187 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2188
2189 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2190 (x_session_initialize): Do not assume string length fits in int.
2191
2192 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2193 This is unlikely, but can occur if DPI is outlandish.
2194
2195 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2196 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2197
2198 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2199 * xrdb.c (magic_file_p, search_magic_path):
2200 Omit last arg SUFFIX; it was always 0. All callers changed.
2201 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2202
2203 * xfont.c (xfont_match): Avoid need for strlen.
2204
2205 * xfns.c: Don't assume strlen fits in int.
2206 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2207
2208 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2209 not unsigned long, as we prefer signed integers. All callers changed.
2210 Detect integer overflow in repeat count.
2211 (message_dolog): Don't assume print length fits in 39 bytes.
2212 (display_mode_element): Don't assume strlen fits in int.
2213
2214 * termcap.c: Don't assume sizes fit in int and never overflow.
2215 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2216 (gobble_line): Check for size-calculation overflow.
2217
2218 * minibuf.c (Fread_buffer):
2219 * lread.c (intern, intern_c_string):
2220 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2221 Don't assume string length fits in int.
2222
2223 * keyboard.c (parse_tool_bar_item):
2224 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2225
2226 * font.c: Don't assume string length fits in int.
2227 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2228 Use ptrdiff_t, not int.
2229 (font_intern_prop): Don't assume string length fits in int.
2230 Don't assume integer property fits in fixnum.
2231 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2232
2233 * filelock.c: Fix some buffer overrun and integer overflow issues.
2234 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2235 Reformulate so as not to need the command string.
2236 Invoke gzip -cd rather than gunzip, as it's more portable.
2237 (lock_info_type, lock_file_1, lock_file):
2238 Don't assume pid_t and time_t fit in unsigned long.
2239 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2240 (current_lock_owner): Prefer signed type for sizes.
2241 Use memcpy, not strncpy, where memcpy is what is really wanted.
2242 Don't assume (via atoi) that time_t and pid_t fit in int.
2243 Check for time_t and/or pid_t out of range, e.g., via a network share.
2244 Don't alloca where an auto var works fine.
2245
2246 * fileio.c: Fix some integer overflow issues.
2247 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2248 Don't assume string length fits in int.
2249 (directory_file_name): Don't assume string length fits in long.
2250 (make_temp_name): Don't assume pid fits in int, or that its print
2251 length is less than 20.
2252
2253 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2254
2255 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2256
2257 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2258
2259 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2260 We prefer signed integers, even for size calculations.
2261
2262 * emacs.c: Don't assume string length fits in 'int'.
2263 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2264 (main): Don't invoke strlen when not needed.
2265
2266 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2267 (XD_DEBUG_MESSAGE): Don't waste a byte.
2268
2269 * callproc.c (getenv_internal_1, getenv_internal)
2270 (Fgetenv_internal):
2271 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2272
2273 * lread.c (invalid_syntax): Omit length argument.
2274 All uses changed. This doesn't fix a bug, but it simplifies the
2275 code away from its former Hollerith-constant appearance, and it's
2276 one less 'int' to worry about when looking at integer-overflow issues.
2277 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2278
2279 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2280 This didn't break anything, but it didn't help either.
2281 It's confusing to put a bogus integer in a place where the actual
2282 value does not matter.
2283 (LIST_END_P): Remove unused macro and its bogus comment.
2284 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2285
2286 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2287 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2288 implementation.
2289 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2290 We prefer signed types, and the value cannot exceed the EMACS_INT
2291 range anyway (because otherwise the length would not be representable).
2292 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2293 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2294 This avoids a GCC warning when WIDE_EMACS_INT.
2295
2296 * indent.c (sane_tab_width): New function.
2297 (current_column, scan_for_column, Findent_to, position_indentation)
2298 (compute_motion): Use it. This is just for clarity.
2299 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2300
2301 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2302
2303 * lisp.h (lint_assume): New macro.
2304 * composite.c (composition_gstring_put_cache):
2305 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2306
2307 * editfns.c, insdel.c:
2308 Omit unnecessary forward decls, to simplify future changes.
2309
2310 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2311
2312 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2313
2314 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2315 Use much-faster test for byte-length change.
2316 Don't assume string byte-length fits in 'int'.
2317 Check that character arg fits in 'int'.
2318 (mapcar1): Declare byte as byte, for clarity.
2319
2320 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2321
2322 * fns.c (concat): Catch string overflow earlier.
2323 Do not rely on integer wraparound.
2324
2325 * dispextern.h (struct it.overlay_strings_charpos)
2326 (struct it.selective): Now EMACS_INT, not int.
2327 * xdisp.c (forward_to_next_line_start)
2328 (back_to_previous_visible_line_start)
2329 (reseat_at_next_visible_line_start, next_element_from_buffer):
2330 Don't arbitrarily truncate the value of 'selective' to int.
2331
2332 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2333
2334 * composite.c: Don't truncate sizes to 'int'.
2335 (composition_gstring_p, composition_reseat_it)
2336 (composition_adjust_point): Use EMACS_INT, not int.
2337 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2338 not EMACS_UINT, for indexes.
2339
2340 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2341
2342 * buffer.c: Include <verify.h>.
2343 (struct sortvec.priority, struct sortstr.priority):
2344 Now EMACS_INT, not int.
2345 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2346 (struct sortstr.size, record_overlay_string)
2347 (struct sortstrlist.size, struct sortlist.used):
2348 Don't truncate size to int.
2349 (record_overlay_string): Check for size-calculation overflow.
2350 (init_buffer_once): Check at compile-time, not run-time.
2351
2352 2011-06-22 Jim Meyering <meyering@redhat.com>
2353
2354 Don't leak an XBM-image-sized buffer
2355 * image.c (xbm_load): Free the image buffer after using it.
2356
2357 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2358
2359 Port to Sun C.
2360 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2361 that Sun C diagnosed.
2362 * fns.c (secure_hash): Fix pointer signedness issue.
2363 * intervals.c (static_offset_intervals): New function.
2364 (offset_intervals): Use it.
2365
2366 2011-06-21 Leo Liu <sdl.web@gmail.com>
2367
2368 * deps.mk (fns.o):
2369 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2370 sha512.h.
2371
2372 * fns.c (secure_hash): Rename from crypto_hash_function and change
2373 the first arg to accept symbols.
2374 (Fsecure_hash): New primitive.
2375 (syms_of_fns): New symbols.
2376
2377 2011-06-20 Deniz Dogan <deniz@dogan.se>
2378
2379 * process.c (Fset_process_buffer): Clarify return value in
2380 docstring.
2381
2382 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2383
2384 * dispnew.c (add_window_display_history): Use BVAR.
2385
2386 * xdisp.c (debug_method_add): Use BVAR.
2387 (check_window_end, dump_glyph_matrix, dump_glyph)
2388 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2389
2390 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2391 Likewise.
2392
2393 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2394 check till after the cache is created in init_frame_faces.
2395
2396 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2397
2398 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2399
2400 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2401
2402 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2403 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2404 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2405
2406 Improve buffer-overflow checking (Bug#8873).
2407 * fileio.c (Finsert_file_contents):
2408 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2409 Remove the old (too-loose) buffer overflow checks.
2410 They weren't needed, since make_gap checks for buffer overflow.
2411 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2412 The old code merely checked for Emacs fixnum overflow, and relied
2413 on undefined (wraparound) behavior. The new code avoids undefined
2414 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2415
2416 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2417 Tune. Don't use wider integers than needed. Don't use alloca.
2418 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2419
2420 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2421
2422 * insdel.c, lisp.h (buffer_overflow): New function.
2423 (insert_from_buffer_1, replace_range, replace_range_2):
2424 * insdel.c (make_gap_larger):
2425 * editfns.c (Finsert_char):
2426 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2427
2428 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2429
2430 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2431
2432 Integer overflow and signedness fixes (Bug#8873).
2433
2434 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2435 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2436
2437 * fileio.c: Don't assume EMACS_INT fits in off_t.
2438 (emacs_lseek): New static function.
2439 (Finsert_file_contents, Fwrite_region): Use it.
2440 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2441
2442 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2443
2444 * fns.c: Don't overflow int when computing a list length.
2445 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2446 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2447 truncation on 64-bit hosts. Check for QUIT every
2448 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2449 faster and is responsive enough.
2450 (Flength): Report an error instead of overflowing an integer.
2451 (Fsafe_length): Return a float if the value is not representable
2452 as a fixnum. This shouldn't happen except in contrived situations.
2453 (Fnthcdr, Fsort): Don't assume list length fits in int.
2454 (Fcopy_sequence): Don't assume vector length fits in int.
2455
2456 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2457 (header_size, word_size): New constants.
2458 (allocate_vectorlike): Don't check size overflow here.
2459 (allocate_vector): Check it here instead, since this is the only
2460 caller of allocate_vectorlike that could cause overflow.
2461 Check that the new vector's length is representable as a fixnum.
2462
2463 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2464 The previous code was bogus. For example, next_almost_prime (32)
2465 returned 39, which is undesirable as it is a multiple of 3; and
2466 next_almost_prime (24) returned 25, which is a multiple of 5 so
2467 why was the code bothering to check for multiples of 7?
2468
2469 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2470
2471 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2472
2473 Variadic C functions now count arguments with ptrdiff_t.
2474 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2475 Back then I didn't know that the Emacs coding style prefers signed int.
2476 Also, in the meantime I found a few more instances where arguments
2477 were being counted with int, which may truncate counts on 64-bit
2478 machines, or EMACS_INT, which may be unnecessarily wide.
2479 * lisp.h (struct Lisp_Subr.function.aMANY)
2480 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2481 Arg counts are now ptrdiff_t, not size_t.
2482 All variadic functions and their callers changed accordingly.
2483 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2484 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2485 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2486 * callint.c (Fcall_interactively): Check arg count for overflow,
2487 to avoid potential buffer overrun. Use signed char, not 'int',
2488 for 'varies' array, so that we needn't bother to check its size
2489 calculation for overflow.
2490 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2491 * eval.c (apply_lambda):
2492 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2493 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2494 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2495
2496 * callint.c (Fcall_interactively): Don't use index var as event count.
2497
2498 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2499 * mem-limits.h (SIZE): Remove; no longer used.
2500
2501 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2502
2503 Remove unnecessary casts.
2504 * xterm.c (x_term_init):
2505 * xfns.c (x_set_border_pixel):
2506 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2507 These aren't needed now that we assume ANSI C.
2508
2509 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2510 It's more likely to cause problems (due to unsigned overflow)
2511 than to cure them.
2512
2513 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2514
2515 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2516
2517 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2518
2519 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2520
2521 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2522
2523 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2524
2525 GLYPH_CODE_FACE returns EMACS_INT, not int.
2526 * dispextern.h (merge_faces):
2527 * xfaces.c (merge_faces):
2528 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2529 Don't assume EMACS_INT fits in int.
2530
2531 * character.h (CHAR_VALID_P): Remove unused parameter.
2532 * fontset.c, lisp.h, xdisp.c: All uses changed.
2533
2534 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2535
2536 * fns.c (concat): Minor tuning based on overflow analysis.
2537 This doesn't fix any bugs. Use int to hold character, instead
2538 of constantly refetching from Emacs object. Use XFASTINT, not
2539 XINT, for value known to be a character. Don't bother comparing
2540 a single byte to 0400, as it's always less.
2541
2542 * floatfns.c (Fexpt):
2543 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2544
2545 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2546 for characters.
2547
2548 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2549
2550 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2551 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2552 incorrectly succeed when S was a string, because 4294967386 was
2553 truncated before it was used.
2554
2555 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2556 Otherwise, an out-of-range integer could cause undefined behavior
2557 on a 64-bit host.
2558
2559 * composite.c: Use int, not EMACS_INT, for characters.
2560 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2561 EMACS_INT, for values that are known to be in character range.
2562 This doesn't fix any bugs but is the usual style inside Emacs and
2563 may generate better code on 32-bit machines.
2564
2565 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2566 This is for reasons similar to the recent CHAR_STRING fix.
2567 * charset.c (Fencode_char): Check that character arg is actually
2568 a character. Pass an int to ENCODE_CHAR.
2569 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2570 wider than 'int', as a compile-time check to prevent future regressions
2571 in this area.
2572
2573 * character.c (char_string): Remove unnecessary casts.
2574
2575 Make sure a 64-bit char is never passed to CHAR_STRING.
2576 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2577 by silently ignoring the top 32 bits, allowing some values
2578 that were far too large to be valid characters.
2579 * character.h: Include <verify.h>.
2580 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2581 arguments are no wider than unsigned, as a compile-time check
2582 to prevent future regressions in this area.
2583 * data.c (Faset):
2584 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2585 (Fsubst_char_in_region):
2586 * fns.c (concat):
2587 * xdisp.c (decode_mode_spec_coding):
2588 Adjust to CHAR_STRING's new requirement.
2589 * editfns.c (Finsert_char, Fsubst_char_in_region):
2590 * fns.c (concat): Check that character args are actually
2591 characters. Without this test, these functions did the wrong
2592 thing with wildly out-of-range values on 64-bit hosts.
2593
2594 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2595 These casts should not be needed on 32-bit hosts, either.
2596 * keyboard.c (read_char):
2597 * lread.c (Fload): Remove casts to unsigned.
2598
2599 * lisp.h (UNSIGNED_CMP): New macro.
2600 This fixes comparison bugs on 64-bit hosts.
2601 (ASCII_CHAR_P): Use it.
2602 * casefiddle.c (casify_object):
2603 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2604 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2605 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2606 * dispextern.h (FACE_FROM_ID):
2607 * keyboard.c (read_char): Use UNSIGNED_CMP.
2608
2609 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2610 not to EMACS_INT, to avoid GCC warning.
2611
2612 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2613
2614 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2615 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2616 isn't needed on 32-bit machines.
2617
2618 * buffer.c (Fgenerate_new_buffer_name):
2619 Use EMACS_INT for count, not int.
2620 (advance_to_char_boundary): Return EMACS_INT, not int.
2621
2622 * data.c (Qcompiled_function): Now static.
2623
2624 * window.c (window_body_lines): Now static.
2625
2626 * image.c (gif_load): Rename local to avoid shadowing.
2627
2628 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2629 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2630 * alloc.c (make_save_value): Integer argument is now of type
2631 ptrdiff_t, not int.
2632 (mark_object): Use ptrdiff_t, not int.
2633 * lisp.h (pD): New macro.
2634 * print.c (print_object): Use it.
2635
2636 * alloc.c: Use EMACS_INT, not int, to count objects.
2637 (total_conses, total_markers, total_symbols, total_vector_size)
2638 (total_free_conses, total_free_markers, total_free_symbols)
2639 (total_free_floats, total_floats, total_free_intervals)
2640 (total_intervals, total_strings, total_free_strings):
2641 Now EMACS_INT, not int. All uses changed.
2642 (Fgarbage_collect): Compute overall total using a double, so that
2643 integer overflow is less likely to be a problem. Check for overflow
2644 when converting back to an integer.
2645 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2646 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2647 These were 'int' variables that could overflow on 64-bit hosts;
2648 they were never used, so remove them instead of repairing them.
2649 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2650 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2651 Previously, this ceilinged at INT_MAX, but that doesn't work on
2652 64-bit machines.
2653 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2654
2655 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2656 (allocate_vectorlike): Check for ptrdiff_t overflow.
2657 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2658 when a (possibly-narrower) signed value would do just as well.
2659 We prefer using signed arithmetic, to avoid comparison confusion.
2660
2661 * alloc.c: Catch some string size overflows that we were missing.
2662 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2663 for convenience in STRING_BYTES_MAX.
2664 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2665 The definition here is exact; the one in lisp.h was approximate.
2666 (allocate_string_data): Check for string overflow. This catches
2667 some instances we weren't catching before. Also, it catches
2668 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2669 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2670 and ptrdiff_t and EMACS_INT are both 64 bits.
2671
2672 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2673 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2674 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2675
2676 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2677
2678 * alloc.c (Fmake_string): Check for out-of-range init.
2679
2680 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2681
2682 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2683
2684 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2685
2686 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2687 xg_get_default_scrollbar_width.
2688
2689 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2690 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2691 (style_changed_cb): Call update_theme_scrollbar_width and call
2692 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2693 all frames (Bug#8505).
2694 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2695 Call gtk_window_set_resizable if HAVE_GTK3.
2696 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2697 and height if HAVE_GTK3 (Bug#8505).
2698 (scroll_bar_width_for_theme): New variable.
2699 (update_theme_scrollbar_width): New function.
2700 (xg_get_default_scrollbar_width): Move code to
2701 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2702 (xg_initialize): Call update_theme_scrollbar_width.
2703
2704 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2705
2706 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2707
2708 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2709
2710 * frame.c (make_frame): Call other_buffer_safely instead of
2711 other_buffer.
2712
2713 * window.c (temp_output_buffer_show): Call display_buffer with
2714 second argument Vtemp_buffer_show_specifiers and reset latter
2715 immediately after the call.
2716 (Vtemp_buffer_show_specifiers): New variable.
2717 (auto_window_vscroll_p, next_screen_context_lines)
2718 (Vscroll_preserve_screen_position): Remove leading asterisks from
2719 doc-strings.
2720
2721 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2722
2723 Fix minor problems found by GCC 4.6.0 static checking.
2724 * buffer.c (Qclone_number): Remove for now, as it's unused.
2725 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2726 (record_buffer): Remove unused local.
2727 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2728 (set_frame_buffer_list): Remove; unused.
2729 * frame.h (other_visible_frames): Remove decl.
2730 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2731 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2732 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2733 if HAVE_GPM.
2734 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2735 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2736 Define only if HAVE_GPM.
2737 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2738 (update_hints_inhibit): Remove; never set. All uses removed.
2739 * widgetprv.h (emacsFrameClassRec): Remove decl.
2740 * window.c (delete_deletable_window): Now returns void, since it
2741 wasn't returning anything.
2742 (compare_window_configurations): Remove unused locals.
2743 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2744 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2745 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2746 the same widths as pointers. This follows up on the 2011-05-06 patch.
2747 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2748 * xterm.h: Likewise.
2749 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2750
2751 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2752
2753 * makefile.w32-in: Update dependencies.
2754 (LISP_H): Add lib/intprops.h.
2755
2756 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2757
2758 * image.c (gif_load): Add animation frame delay to the metadata.
2759 (syms_of_image): Use DEFSYM. New symbol `delay'.
2760
2761 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2762
2763 * window.c (delete_deletable_window): Re-add.
2764 (Fset_window_configuration): Rewrite to handle dead buffers and
2765 consequently deletable windows.
2766 (window_tree, Fwindow_tree): Remove. Supply functionality in
2767 window.el.
2768 (compare_window_configurations): Simplify code.
2769
2770 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2771
2772 * image.c (imagemagick_load_image): Fix type mismatch.
2773 (Fimagemagick_types): Likewise.
2774
2775 * window.h (replace_buffer_in_windows): Declare.
2776
2777 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2778
2779 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2780 Qclone_number. Remove external declaration of Qdelete_window.
2781 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2782 code.
2783 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2784 Run Qbuffer_list_update_hook if allowed.
2785 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2786 buffer list implementation.
2787 (other_buffer_safely): New function.
2788 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2789 calls to replace_buffer_in_windows and
2790 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2791 if allowed.
2792 (record_buffer): Inhibit quitting and rewrite using quittable
2793 functions. Run Qbuffer_list_update_hook if allowed.
2794 (Frecord_buffer, Funrecord_buffer): New functions.
2795 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2796 Move switch-to-buffer to window.el.
2797 (bury-buffer): Move to window.el.
2798 (Vbuffer_list_update_hook): New variable.
2799
2800 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2801 section.
2802
2803 * window.h (resize_frame_windows): Move up in code.
2804 (Fwindow_frame): Remove EXFUN.
2805 (replace_buffer_in_all_windows): Remove prototype.
2806 (replace_buffer_in_windows_safely): Add prototype.
2807
2808 * window.c: Declare Qdelete_window static again. Move down
2809 declaration of select_count.
2810 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2811 (Fother_window): Move to window.el.
2812 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2813 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2814 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2815 window.el.
2816 (replace_buffer_in_windows): Implement by calling
2817 Qreplace_buffer_in_windows.
2818 (replace_buffer_in_all_windows): Remove with some functionality
2819 moved into replace_buffer_in_windows_safely.
2820 (replace_buffer_in_windows_safely): New function.
2821 (select_window_norecord, select_frame_norecord): Move in front
2822 of run_window_configuration_change_hook. Remove now obsolete
2823 declarations.
2824 (Fset_window_buffer): Rewrite doc-string.
2825 Call Qrecord_window_buffer.
2826 (keys_of_window): Move binding for other-window to window.el.
2827
2828 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2829
2830 * dispextern.h (struct image): Replace data member, whose int_val
2831 and ptr_val fields were not used by anything, with a single
2832 lisp_val object.
2833
2834 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2835 (gif_clear_image, gif_load, imagemagick_load_image)
2836 (gs_clear_image, gs_load): Callers changed.
2837
2838 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2839
2840 * buffer.h: Include <time.h>, for time_t.
2841 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2842
2843 Fix minor problems found by static checking.
2844
2845 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2846
2847 Make identifiers static if they are not used in other modules.
2848 * data.c (Qcompiled_function, Qframe, Qvector):
2849 * image.c (QimageMagick, Qsvg):
2850 * minibuf.c (Qmetadata):
2851 * window.c (resize_window_check, resize_root_window): Now static.
2852 * window.h (resize_window_check, resize_root_window): Remove decls.
2853
2854 * window.c (window_deletion_count, delete_deletable_window):
2855 Remove; unused.
2856 (window_body_lines): Now static.
2857 (Fdelete_other_windows_internal): Mark vars as initialized.
2858 Make sure 'resize_failed' is initialized.
2859 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2860 (resize_window_apply): Remove unused local.
2861 * window.h (delete_deletable_window): Remove decl.
2862
2863 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2864 (imagemagick_load_image): Fix pointer signedness problem by changing
2865 last arg from unsigned char * to char *. All uses changed.
2866 Also, fix a local for similar reasons.
2867 Remove unused locals. Remove locals to avoid shadowing.
2868 (fn_rsvg_handle_free): Remove; unused.
2869 (svg_load, svg_load_image): Fix pointer signedness problem.
2870 (imagemagick_load_image): Don't use garbage pointer image_wand.
2871
2872 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2873
2874 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2875
2876 * image.c (gif_load): Fix omitted cast error introduced by
2877 2011-06-06 change.
2878
2879 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2880
2881 * window.h (resize_proportionally, orig_total_lines)
2882 (orig_top_line): Remove from window structure.
2883 (set_window_height, set_window_width, change_window_heights)
2884 (Fdelete_window): Remove prototypes.
2885 (resize_frame_windows): Remove duplicate declaration.
2886
2887 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2888
2889 * window.h (resize_frame_windows, resize_window_check)
2890 (delete_deletable_window, resize_root_window)
2891 (resize_frame_windows): Declare prototypes.
2892
2893 * window.c (resize_window_apply): Make definition be "static" to
2894 match the prototype.
2895
2896 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2897
2898 * window.c: Remove declarations of Qwindow_size_fixed,
2899 window_min_size_1, window_min_size_2, window_min_size,
2900 size_window, window_fixed_size_p, enlarge_window, delete_window.
2901 Remove static from declaration of Qdelete_window, it's
2902 temporarily needed by Fbury_buffer.
2903 (replace_window): Don't assign orig_top_line and
2904 orig_total_lines.
2905 (Fdelete_window, delete_window): Remove. Window deletion is
2906 handled by window.el.
2907 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2908 Replace Fdelete_window calls with calls to Qdelete_window.
2909 (Fdelete_other_windows): Remove. Deleting other windows is
2910 handled by window.el.
2911 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2912 handled in window.el.
2913 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2914 Window minimum sizes are handled in window.el.
2915 (shrink_windows, size_window, set_window_height)
2916 (set_window_width, change_window_heights, window_height)
2917 (window_width, CURBEG, CURSIZE, enlarge_window)
2918 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2919 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2920 handled in window.el.
2921 (make_dummy_parent): Rename to make_parent_window and give it a
2922 second argument horflag.
2923 (make_window): Don't set resize_proportionally any more.
2924 (Fsplit_window): Remove. Windows are split in window.el.
2925 (save_restore_action, save_restore_orig_size)
2926 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2927 Resize mini windows in window.el.
2928 (grow_mini_window, shrink_mini_window): Implement by calling
2929 Qresize_root_window_vertically, resize_window_check and
2930 resize_window_apply.
2931 (saved_window, Fset_window_configuration, save_window_save):
2932 Do not handle orig_top_line, orig_total_lines, and
2933 resize_proportionally.
2934 (window_min_height, window_min_width): Move to window.el.
2935 (keys_of_window): Move bindings for delete-other-windows,
2936 split-window, delete-window and enlarge-window to window.el.
2937
2938 * buffer.c: Temporarily extern Qdelete_window.
2939 (Fbury_buffer): Temporarily call Qdelete_window instead of
2940 Fdelete_window (Fbury_buffer will move to window.el soon).
2941
2942 * frame.c (set_menu_bar_lines_1): Remove code handling
2943 orig_top_line and orig_total_lines.
2944
2945 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2946 set_window_height but set heights directly.
2947 (change_frame_size_1): Use resize_frame_windows.
2948
2949 * xdisp.c (init_xdisp): Don't use set_window_height but set
2950 heights directly.
2951
2952 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2953 Use resize_frame_windows instead of change_window_heights and run
2954 run_window_configuration_change_hook.
2955
2956 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2957 instead of change_window_heights and run
2958 run_window_configuration_change_hook.
2959
2960 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2961
2962 * window.c (replace_window): Rename second argument REPLACEMENT to
2963 NEW. New third argument SETFLAG. Rewrite.
2964 (delete_window, make_dummy_parent): Call replace_window with
2965 third argument 1.
2966 (window_list_1): Move down in code.
2967 (run_window_configuration_change_hook): Move set_buffer part
2968 before select_frame_norecord part in order to unwind correctly.
2969 Rename count1 to count.
2970 (recombine_windows, delete_deletable_window, resize_root_window)
2971 (Fdelete_other_windows_internal)
2972 (Frun_window_configuration_change_hook, make_parent_window)
2973 (resize_window_check, resize_window_apply, Fresize_window_apply)
2974 (resize_frame_windows, Fsplit_window_internal)
2975 (Fdelete_window_internal, Fresize_mini_window_internal):
2976 New functions.
2977 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2978
2979 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2980
2981 * window.h (window): Add some new members to window structure -
2982 normal_lines, normal_cols, new_total, new_normal, clone_number,
2983 splits, nest, prev_buffers, next_buffers.
2984 (WINDOW_TOTAL_SIZE): Move here from window.c.
2985 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2986
2987 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2988 Remove.
2989 (make_dummy_parent): Set new members of windows structure.
2990 (make_window): Move down in code. Handle new members of window
2991 structure.
2992 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2993 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2994 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2995 (Fset_window_prev_buffers, Fwindow_next_buffers)
2996 (Fset_window_next_buffers, Fset_window_clone_number):
2997 New functions.
2998 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2999 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3000 Doc-string fixes.
3001 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3002 Argument WINDOW can be now internal window too.
3003 (Fwindow_use_time): Move up in code.
3004 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3005 Rewrite doc-string.
3006 (Fset_window_configuration, saved_window)
3007 (Fcurrent_window_configuration, save_window_save): Handle new
3008 members of window structure.
3009 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3010 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3011 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3012 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3013 Qget_mru_window, Qresize_root_window,
3014 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3015 Qauto_buffer_name; staticpro them.
3016
3017 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3018
3019 * window.c (Fwindow_total_size, Fwindow_left_column)
3020 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3021 (Fwindow_list_1): New functions.
3022 (window_box_text_cols): Replace with window_body_cols.
3023 (Fwindow_width, Fscroll_left, Fscroll_right):
3024 Use window_body_cols instead of window_box_text_cols.
3025 (delete_window, Fset_window_configuration):
3026 Call delete_all_subwindows with window as argument.
3027 (delete_all_subwindows): Take a window as argument and not a
3028 structure. Rewrite.
3029 (window_loop): Remove handling of GET_LRU_WINDOW and
3030 GET_LARGEST_WINDOW.
3031 (Fget_lru_window, Fget_largest_window): Move to window.el.
3032
3033 * window.h: Extern window_body_cols instead of
3034 window_box_text_cols. delete_all_subwindows now takes a
3035 Lisp_Object as argument.
3036
3037 * indent.c (compute_motion, Fcompute_motion):
3038 Use window_body_cols instead of window_box_text_cols.
3039
3040 * frame.c (delete_frame): Call delete_all_subwindows with root
3041 window as argument.
3042
3043 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3044
3045 * fns.c (Fputhash): Document return value.
3046
3047 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3048
3049 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3050
3051 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3052
3053 Cons<->int and similar integer overflow fixes (Bug#8794).
3054
3055 Check for overflow when converting integer to cons and back.
3056 * charset.c (Fdefine_charset_internal, Fdecode_char):
3057 Use cons_to_unsigned to catch overflow.
3058 (Fencode_char): Use INTEGER_TO_CONS.
3059 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3060 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3061 * data.c (long_to_cons, cons_to_long): Remove.
3062 (cons_to_unsigned, cons_to_signed): New functions.
3063 These signal an error for invalid or out-of-range values.
3064 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3065 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3066 * font.c (Ffont_variation_glyphs):
3067 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3068 * lisp.h: Include <intprops.h>.
3069 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3070 (cons_to_signed, cons_to_unsigned): New decls.
3071 (long_to_cons, cons_to_long): Remove decls.
3072 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3073 (Fprimitive_undo): Use CONS_TO_INTEGER.
3074 * xfns.c (Fx_window_property): Likewise.
3075 * xselect.c: Include <limits.h>.
3076 (x_own_selection, selection_data_to_lisp_data):
3077 Use INTEGER_TO_CONS.
3078 (x_handle_selection_request, x_handle_selection_clear)
3079 (x_get_foreign_selection, Fx_disown_selection_internal)
3080 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3081 (lisp_data_to_selection_data): Use cons_to_unsigned.
3082 (x_fill_property_data): Use cons_to_signed.
3083 Report values out of range.
3084
3085 Check for buffer and string overflow more precisely.
3086 * buffer.h (BUF_BYTES_MAX): New macro.
3087 * lisp.h (STRING_BYTES_MAX): New macro.
3088 * alloc.c (Fmake_string):
3089 * character.c (string_escape_byte8):
3090 * coding.c (coding_alloc_by_realloc):
3091 * doprnt.c (doprnt):
3092 * editfns.c (Fformat):
3093 * eval.c (verror):
3094 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3095 since they may not be the same number.
3096 * editfns.c (Finsert_char):
3097 * fileio.c (Finsert_file_contents):
3098 Likewise for BUF_BYTES_MAX.
3099
3100 * image.c: Use ptrdiff_t, not int, for sizes.
3101 (slurp_file): Switch from int to ptrdiff_t.
3102 All uses changed.
3103 (slurp_file): Check that file size fits in both size_t (for
3104 malloc) and ptrdiff_t (for sanity and safety).
3105
3106 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3107 if b->modtime has its maximal value.
3108
3109 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3110
3111 Don't assume time_t can fit into int.
3112 * buffer.h (struct buffer.modtime): Now time_t, not int.
3113 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3114 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3115
3116 Minor fixes for signed vs unsigned integers.
3117 * character.h (MAYBE_UNIFY_CHAR):
3118 * charset.c (maybe_unify_char):
3119 * keyboard.c (read_char, reorder_modifiers):
3120 XINT -> XFASTINT, since the integer must be nonnegative.
3121 * ftfont.c (ftfont_spec_pattern):
3122 * keymap.c (access_keymap, silly_event_symbol_error):
3123 XUINT -> XFASTINT, since the integer must be nonnegative.
3124 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3125 since it makes no difference and we prefer signed.
3126 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3127 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3128 nonnegative.
3129
3130 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3131
3132 * window.h (Fwindow_frame): Declare.
3133
3134 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3135
3136 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3137 (SPARE_MEMORY): Always define.
3138 (LARGE_REQUEST): Remove.
3139 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3140
3141 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3142
3143 * lisp.h: Move EXFUNS for Fframe_root_window,
3144 Fframe_first_window and Fset_frame_selected_window to window.h.
3145
3146 * window.h: Move EXFUNS for Fframe_root_window,
3147 Fframe_first_window and Fset_frame_selected_window here from
3148 lisp.h.
3149
3150 * frame.c (Fwindow_frame, Fframe_first_window)
3151 (Fframe_root_window, Fframe_selected_window)
3152 (Fset_frame_selected_window): Move to window.c.
3153 (Factive_minibuffer_window): Move to minibuf.c.
3154 (Fother_visible_frames_p): New function.
3155
3156 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3157
3158 * window.c (decode_window, decode_any_window): Move up in code.
3159 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3160 (inhibit_frame_unsplittable): Remove unused variable.
3161 (Fwindow_buffer): Move up and rewrite doc-string.
3162 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3163 (Fwindow_prev): New functions.
3164 (Fwindow_frame): Move here from frame.c. Accept any window as
3165 argument.
3166 (Fframe_root_window, Fframe_first_window)
3167 (Fframe_selected_window): Move here from frame.c. Accept frame
3168 or arbitrary window as argument. Update doc-strings.
3169 (Fminibuffer_window): Move up in code.
3170 (Fwindow_minibuffer_p): Move up in code and simplify.
3171 (Fset_frame_selected_window): Move here from frame.c.
3172 Marginal rewrite.
3173 (Fselected_window, select_window, Fselect_window): Move up in
3174 code. Minor doc-string fixes.
3175
3176 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3177
3178 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3179 Do not assume that spare memory exists; that assumption is valid
3180 only if SYSTEM_MALLOC.
3181 (LARGE_REQUEST): New macro, so that the issue of large requests
3182 is separated from the issue of spare memory.
3183
3184 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3185
3186 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3187 format. (Bug#8806)
3188
3189 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3190
3191 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3192 before statements.
3193
3194 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3195
3196 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3197
3198 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3199
3200 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3201 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3202
3203 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3204
3205 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3206
3207 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3208
3209 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3210 (x_clipboard_manager_save): Add return value.
3211 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3212 New error handlers.
3213 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3214 Obey Vx_select_enable_clipboard_manager. Catch errors in
3215 x_clipboard_manager_save (Bug#8779).
3216 (Vx_select_enable_clipboard_manager): New variable.
3217 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3218
3219 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3220
3221 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3222
3223 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3224
3225 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3226 in the current matrix if keep_current_p is non-zero.
3227
3228 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3229
3230 * bidi.c (bidi_level_of_next_char): Fix last change.
3231
3232 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3233
3234 Support bidi reordering of text covered by display properties.
3235
3236 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3237 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3238 (bidi_cache_search, bidi_cache_iterator_state)
3239 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3240 (bidi_level_of_next_char, bidi_move_to_visually_next):
3241 Support character positions inside a run of characters covered by a
3242 display string.
3243 (bidi_paragraph_init, bidi_resolve_explicit_1)
3244 (bidi_level_of_next_char): Call bidi_fetch_char and
3245 bidi_fetch_char_advance instead of FETCH_CHAR and
3246 FETCH_CHAR_ADVANCE.
3247 (bidi_init_it): Initialize new members.
3248 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3249 definitions.
3250 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3251 instead of using explicit *_CHAR codes.
3252 (bidi_resolve_explicit, bidi_resolve_weak):
3253 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3254 bidirectional text is supported only in multibyte buffers.
3255 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3256 it to initialize the frame_window_p member of struct bidi_it.
3257 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3258 (bidi_resolve_explicit, bidi_resolve_weak)
3259 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3260 bidi_it->nchars is non-positive.
3261 (bidi_level_of_next_char): Don't try to lookup the cache for the
3262 next/previous character if nothing is cached there yet, or if we
3263 were just reseat()'ed to a new position.
3264
3265 * xdisp.c (set_cursor_from_row): Set start and stop points
3266 according to the row's direction when priming the loop that looks
3267 for the glyph on which to display cursor.
3268 (single_display_spec_intangible_p): Function deleted.
3269 (display_prop_intangible_p): Reimplement to call
3270 handle_display_spec instead of single_display_spec_intangible_p.
3271 Accept 3 additional arguments needed by handle_display_spec.
3272 This fixes incorrect cursor motion across display property with complex
3273 values: lists, `(when COND...)' forms, etc.
3274 (single_display_spec_string_p): Support property values that are
3275 lists with the argument STRING its top-level element.
3276 (display_prop_string_p): Fix the condition for processing a
3277 property that is a list to be consistent with handle_display_spec.
3278 (handle_display_spec): New function, refactored from the
3279 last portion of handle_display_prop.
3280 (compute_display_string_pos): Accept additional argument
3281 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3282 value of a `display' property is a "replacing spec".
3283 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3284 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3285 the display property, but just return a value indicating whether
3286 the display property will replace the characters it covers.
3287 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3288 frame_window_p members of struct bidi_it.
3289 (compute_display_string_pos, compute_display_string_end):
3290 New functions.
3291 (push_it): Accept second argument POSITION, where pop_it should
3292 jump to continue iteration.
3293 (reseat_1): Initialize bidi_it.disp_pos.
3294
3295 * keyboard.c (adjust_point_for_property): Adjust the call to
3296 display_prop_intangible_p to its new signature.
3297
3298 * dispextern.h (struct bidi_it): New member frame_window_p.
3299 (bidi_init_it): Update prototypes.
3300 (display_prop_intangible_p): Update prototype.
3301 (compute_display_string_pos, compute_display_string_end):
3302 Declare prototypes.
3303 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3304 EMACS_INT.
3305
3306 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3307
3308 Malloc failure behavior now depends on size of allocation.
3309 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3310 * lisp.h: Change signatures accordingly.
3311 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3312 All callers changed. (Bug#8762)
3313
3314 * gnutls.c: Use Emacs's memory allocators.
3315 Without this change, the gnutls library would invoke malloc etc.
3316 directly, which causes problems on non-SYNC_INPUT hosts, and which
3317 runs afoul of improving memory_full behavior. (Bug#8761)
3318 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3319 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3320 xfree instead of the default malloc, realloc, free.
3321 (Fgnutls_boot): No need to check for memory allocation failure,
3322 since xmalloc does that for us.
3323
3324 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3325 * category.c (hash_get_category_set):
3326 * ccl.c (ccl_driver):
3327 * charset.c (Fdefine_charset_internal):
3328 * charset.h (struct charset.hash_index):
3329 * composite.c (get_composition_id, gstring_lookup_cache)
3330 (composition_gstring_put_cache):
3331 * composite.h (struct composition.hash_index):
3332 * dispextern.h (struct image.hash):
3333 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3334 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3335 (hashfn_equal, hashfn_user_defined, make_hash_table)
3336 (maybe_resize_hash_table, hash_lookup, hash_put)
3337 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3338 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3339 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3340 * image.c (make_image, search_image_cache, lookup_image)
3341 (xpm_put_color_table_h):
3342 * lisp.h (struct Lisp_Hash_Table):
3343 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3344 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3345 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3346 * alloc.c (allocate_vectorlike):
3347 Check for overflow in vector size calculations.
3348 * ccl.c (ccl_driver):
3349 Check for overflow when converting EMACS_INT to int.
3350 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3351 need to be updated by these changes.
3352 * fns.c (make_hash_table, maybe_resize_hash_table):
3353 Check for integer overflow with large hash tables.
3354 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3355 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3356 (SXHASH_REDUCE): New macro.
3357 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3358 Use it instead of discarding useful hash info with large hash values.
3359 (sxhash_float): New function.
3360 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3361 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3362 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3363 Rewrite to use FIXNUM_BITS, as this simplifies things.
3364 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3365 Adjust signatures to match updated version of code.
3366 (consing_since_gc): Now EMACS_INT, since a single hash table can
3367 use more than INT_MAX bytes.
3368
3369 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3370
3371 Make it possible to build with GCC-4.6+ -O2 -flto.
3372
3373 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3374
3375 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3376
3377 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3378 Call minibuffer-inactive-mode.
3379
3380 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3381
3382 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3383 Update dependencies.
3384
3385 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3386
3387 * data.c (init_data): Remove code for UTS, this system is not
3388 supported anymore.
3389
3390 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3391
3392 Don't force ./temacs to start in terminal mode.
3393
3394 * frame.c (make_initial_frame): Initialize faces in all cases, not
3395 only when CANNOT_DUMP is defined.
3396 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3397
3398 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3399
3400 * dispnew.c (add_window_display_history): Use const for the string
3401 pointer. Remove declaration, not needed.
3402
3403 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3404
3405 Use 'inline', not 'INLINE'.
3406 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3407 * alloc.c, fontset.c (INLINE): Remove.
3408 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3409 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3410 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3411 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3412 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3413
3414 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3415
3416 Make it possible to run ./temacs.
3417
3418 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3419 syms_of_callproc does the same thing. Remove test for
3420 "initialized", do it in the caller.
3421 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3422
3423 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3424
3425 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3426 (read_minibuf): Use get_minibuffer.
3427 (syms_of_minibuf): Use DEFSYM.
3428 (Qmetadata): New var.
3429 * data.c (Qbuffer): Don't make it static.
3430 (syms_of_data): Use DEFSYM.
3431
3432 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3433
3434 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3435 (CCL_CODE_MIN): New macro.
3436
3437 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3438
3439 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3440
3441 * eval.c (Qdebug): Now static.
3442 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3443 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3444 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3445
3446 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3447
3448 * image.c: Various fixes to ImageMagick code comments.
3449 (Fimagemagick_types): Doc fix.
3450
3451 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3452
3453 Minor fixes prompted by GCC 4.6.0 warnings.
3454
3455 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3456
3457 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3458 (x_clipboard_manager_save_all): Move extern decl to ...
3459 * xterm.h: ... here, so that it can be checked for consistency.
3460
3461 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3462
3463 * xselect.c (x_clipboard_manager_save_frame)
3464 (x_clipboard_manager_save_all): New functions.
3465 (Fx_clipboard_manager_save): Lisp function deleted.
3466
3467 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3468 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3469
3470 * xterm.h: Update prototype.
3471
3472 2011-05-28 William Xu <william.xwl@gmail.com>
3473
3474 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3475 exiting (Bug#8239).
3476
3477 2011-05-28 Jim Meyering <meyering@redhat.com>
3478
3479 Avoid a sign-extension bug in crypto_hash_function.
3480 * fns.c (to_uchar): Define.
3481 (crypto_hash_function): Use it to convert some newly-signed
3482 variables to unsigned, to avoid sign-extension bugs. For example,
3483 without this change, (md5 "truc") would evaluate to
3484 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3485 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3486 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3487
3488 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3489
3490 Integer overflow fixes.
3491
3492 * dbusbind.c: Serial number integer overflow fixes.
3493 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3494 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3495 to hold a serial number that is too large for a fixnum.
3496 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3497 Check for serial numbers out of range. Decode any serial number
3498 that was so large that it became a float. (Bug#8722)
3499
3500 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3501 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3502 Use XFASTINT rather than XUINT when numbers are nonnegative.
3503 (xd_append_arg, Fdbus_method_return_internal):
3504 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3505 arguments, check that Lisp number is nonnegative, rather than
3506 silently wrapping negative numbers around. (Bug#8722)
3507 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3508 (Bug#8722)
3509
3510 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3511
3512 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3513
3514 ccl: add integer overflow checks
3515 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3516 (IN_INT_RANGE): New macros.
3517 (ccl_driver): Use them to check for integer overflow when
3518 decoding a CCL program. Many of the new checks are whether XINT (x)
3519 fits in int; it doesn't always, on 64-bit hosts. The new version
3520 doesn't catch all possible integer overflows, but it's an
3521 improvement. (Bug#8719)
3522
3523 * alloc.c (make_event_array): Use XINT, not XUINT.
3524 There's no need for unsigned here.
3525
3526 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3527 This follows up to the 2011-05-06 change that substituted uintptr_t
3528 for EMACS_INT. This case wasn't caught back then.
3529
3530 Rework Fformat to avoid integer overflow issues.
3531 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3532 now (part of C89). Include <verify.h>.
3533 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3534 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3535 (Fformat): Avoid the prepass trying to compute sizes; it was only
3536 approximate and thus did not catch overflow reliably. Instead, walk
3537 through the format just once, formatting and computing sizes as we go,
3538 checking for integer overflow at every step, and allocating a larger
3539 buffer as needed. Keep track separately whether the format is
3540 multibyte. Keep only the most-recently calculated precision, rather
3541 than them all. Record whether each argument has been converted to
3542 string. Use EMACS_INT, not int, for byte and char and arg counts.
3543 Support field widths and precisions larger than INT_MAX. Avoid
3544 sprintf's undefined behavior with conversion specifications such as %#d
3545 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3546 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3547 formatting out-of-range floating point numbers with int
3548 formats. (Bug#8668)
3549
3550 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3551
3552 * data.c: Avoid integer truncation in expressions involving floats.
3553 * data.c: Include <intprops.h>.
3554 (arith_driver): When there's an integer overflow in an expression
3555 involving floating point, convert the integers to floating point
3556 so that the resulting value does not suffer from catastrophic
3557 integer truncation. For example, on a 64-bit host (* 4
3558 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3559 Do not rely on undefined behavior after integer overflow.
3560
3561 merge count_size_as_multibyte, parse_str_to_multibyte
3562 * character.c, character.h (count_size_as_multibyte):
3563 Rename from parse_str_to_multibyte; all uses changed.
3564 Check for integer overflow.
3565 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3566 since it's now a duplicate of the other. This is more of
3567 a character than a buffer op, so better that it's in character.c.
3568 * fns.c, print.c: Adjust to above changes.
3569
3570 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3571
3572 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3573
3574 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3575
3576 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3577 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3578 (x_clipboard_manager_save): Now static.
3579 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3580
3581 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3582 (crypto_hash_function): Now static.
3583 Fix pointer signedness problems. Avoid unnecessary initializations.
3584
3585 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3586
3587 * termhooks.h (Vselection_alist): Make it terminal-local.
3588
3589 * terminal.c (create_terminal): Initialize it.
3590
3591 * xselect.c: Support for clipboard managers.
3592 (Vselection_alist): Move to termhooks.h as terminal-local var.
3593 (LOCAL_SELECTION): New macro.
3594 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3595 (symbol_to_x_atom): Remove gratuitous arg.
3596 (x_handle_selection_request, lisp_data_to_selection_data)
3597 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3598 (x_own_selection, x_get_local_selection, x_convert_selection):
3599 New arg, specifying work frame. Use terminal-local Vselection_alist.
3600 (some_frame_on_display): Delete unused function.
3601 (Fx_own_selection_internal, Fx_get_selection_internal)
3602 (Fx_disown_selection_internal, Fx_selection_owner_p)
3603 (Fx_selection_exists_p): New optional frame arg.
3604 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3605 (x_handle_selection_clear): Don't treat other terminals with the
3606 same keyboard specially. Use the terminal-local Vselection_alist.
3607 (x_clear_frame_selections): Use Frun_hook_with_args.
3608
3609 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3610
3611 * xterm.h: Add support for those atoms.
3612
3613 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3614
3615 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3616 (converted_selections, conversion_fail_tag): New global variables.
3617 (x_selection_request_lisp_error): Free the above.
3618 (x_get_local_selection): Remove unnecessary code.
3619 (x_reply_selection_request): Args changed; handle arbitrary array
3620 of converted selections stored in converted_selections.
3621 Separate the XChangeProperty and SelectionNotify steps.
3622 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3623 (x_convert_selection): New function.
3624 (x_handle_selection_event): Simplify.
3625 (x_get_foreign_selection): Don't ignore incoming requests while
3626 waiting for an answer; this will fail when we implement
3627 SAVE_TARGETS, and seems unnecessary anyway.
3628 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3629 (Vx_sent_selection_functions): Doc fix.
3630
3631 2011-05-26 Leo Liu <sdl.web@gmail.com>
3632
3633 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3634
3635 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3636
3637 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3638
3639 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3640 for fringe update if it has periodic bitmap.
3641 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3642 and fringe_bitmap_periodic_p.
3643
3644 * fringe.c (get_fringe_bitmap_data): New function.
3645 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3646 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3647 row. Mark glyph row for fringe update if periodicity changed.
3648
3649 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3650 for fringe update unless it has periodic bitmap.
3651
3652 2011-05-25 Kenichi Handa <handa@m17n.org>
3653
3654 * xdisp.c (get_next_display_element): Set correct it->face_id for
3655 a static composition.
3656
3657 2011-05-24 Leo Liu <sdl.web@gmail.com>
3658
3659 * deps.mk (fns.o):
3660 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3661
3662 * fns.c (crypto_hash_function, Fsha1): New function.
3663 (Fmd5): Use crypto_hash_function.
3664 (syms_of_fns): Add Ssha1.
3665
3666 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3667
3668 * gnutls.c: Remove unused macros.
3669 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3670 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3671 Remove macros that are defined and never used.
3672 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3673
3674 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3675
3676 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3677 (Fx_get_selection_internal): Minor cleanup.
3678 (Fx_own_selection_internal): Rename arguments for consistency with
3679 select.el.
3680
3681 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3684
3685 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3686
3687 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3688
3689 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3690
3691 * dispnew.c (scrolling_window): Don't exclude the case that the
3692 last enabled row in the desired matrix touches the bottom boundary.
3693
3694 2011-05-21 Glenn Morris <rgm@gnu.org>
3695
3696 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3697 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3698 and add some more files.
3699
3700 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3701
3702 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3703 report_file_error introduced by the change from 2011-05-07.
3704
3705 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 * systime.h (Time): Define only if emacs is defined.
3708 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3709 where the include path doesn't have X11/X.h by default. See
3710 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3711
3712 2011-05-20 Kenichi Handa <handa@m17n.org>
3713
3714 * composite.c (find_automatic_composition): Fix previous change.
3715
3716 2011-05-20 Glenn Morris <rgm@gnu.org>
3717
3718 * lisp.mk: New file, split from Makefile.in.
3719 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3720 (shortlisp): Remove.
3721 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3722
3723 2011-05-19 Glenn Morris <rgm@gnu.org>
3724
3725 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3726 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3727 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3728 (lisp): Set the order to that of loadup.el.
3729 (shortlisp): Make it a copy of $lisp.
3730 (SOME_MACHINE_LISP): Remove.
3731 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3732 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3733
3734 2011-05-18 Kenichi Handa <handa@m17n.org>
3735
3736 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3737 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3738 (find_automatic_composition): Mostly rewrite for efficiency.
3739
3740 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3741
3742 * makefile.w32-in: Update dependencies.
3743
3744 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3745
3746 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3747 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3748
3749 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3750
3751 Fix some integer overflow issues, such as string length overflow.
3752
3753 * insdel.c (count_size_as_multibyte): Check for string overflow.
3754
3755 * character.c (lisp_string_width): Check for string overflow.
3756 Use EMACS_INT, not int, for string indexes and lengths; in
3757 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3758 the resulting string length overflows an EMACS_INT; instead,
3759 report a string overflow if no precision given. When checking for
3760 precision exhaustion, use a check that cannot possibly have
3761 integer overflow. (Bug#8675)
3762 * character.h (lisp_string_width): Adjust to new signature.
3763
3764 * alloc.c (string_overflow): New function.
3765 (Fmake_string): Use it. This doesn't change behavior, but saves
3766 a few bytes and will simplify future changes.
3767 * character.c (string_escape_byte8): Likewise.
3768 * lisp.h (string_overflow): New decl.
3769
3770 Fixups, following up to the user-interface timestamp change.
3771 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3772 for UI timestamps, instead of unsigned long.
3773 * msdos.c (mouse_get_pos): Likewise.
3774 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3775 * w32gui.h (Time): Define by including "systime.h" rather than by
3776 declaring it ourselves. (Bug#8664)
3777
3778 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3779 * image.c (clear_image_cache): Likewise.
3780
3781 * term.c (term_mouse_position): Don't assume time_t wraparound.
3782
3783 Be more systematic about user-interface timestamps.
3784 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3785 and sometimes 'EMACS_UINT', to represent these timestamps.
3786 This change causes it to use 'Time' uniformly, as that's what X uses.
3787 This makes the code easier to follow, and makes it easier to catch
3788 integer overflow bugs such as Bug#8664.
3789 * frame.c (Fmouse_position, Fmouse_pixel_position):
3790 Use Time, not unsigned long, for user-interface timestamps.
3791 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3792 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3793 * keyboard.h (last_event_timestamp): Likewise.
3794 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3795 * menu.h (xmenu_show): Likewise.
3796 * term.c (term_mouse_position): Likewise.
3797 * termhooks.h (struct input_event.timestamp): Likewise.
3798 (struct terminal.mouse_position_hook): Likewise.
3799 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3800 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3801 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3802 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3803 what it was before.
3804 * menu.h, termhooks.h: Include "systime.h", for Time.
3805
3806 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3807 Don't assume that the difference between two unsigned long values
3808 can fit into an integer. At this point, we know button_down_time
3809 <= event->timestamp, so the difference must be nonnegative, so
3810 there's no need to cast the result if double-click-time is
3811 nonnegative, as it should be; check that it's nonnegative, just in
3812 case. This bug is triggered when events are more than 2**31 ms
3813 apart (about 25 days). (Bug#8664)
3814
3815 * xselect.c (last_event_timestamp): Remove duplicate decl.
3816 (x_own_selection): Remove needless cast to unsigned long.
3817
3818 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3819 that always fit in int. Use a sentinel instead of a counter, to
3820 avoid a temp and to allay GCC's concerns about possible int overflow.
3821 * frame.h (struct frame): Use int for menu_bar_items_used
3822 instead of EMACS_INT, since it always fits in int.
3823
3824 * menu.c (grow_menu_items): Check for int overflow.
3825
3826 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3827
3828 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3829 Before, the code was not consistent. These values cannot exceed
3830 2**31 - 1 so there's no need to make them unsigned.
3831 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3832 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3833 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3834 as modifiers.
3835 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3836
3837 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3838 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3839 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3840 presumably because the widths might not match.
3841
3842 * window.c (size_window): Avoid needless test at loop start.
3843
3844 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3845
3846 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3847
3848 2011-05-12 Drew Adams <drew.adams@oracle.com>
3849
3850 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3851
3852 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3853
3854 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3855 `width' to `bar_area_x' and `bar_area_width', respectively.
3856 (x_scroll_run): Take account of fringe background extension.
3857
3858 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3859 Rename local vars `left' and `width' to `bar_area_x' and
3860 `bar_area_width', respectively.
3861 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3862 background extension.
3863
3864 2011-05-10 Jim Meyering <meyering@redhat.com>
3865
3866 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3867
3868 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3869
3870 * image.c (Finit_image_library): Return t for built-in image types,
3871 like pbm and xbm. (Bug#8640)
3872
3873 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3874
3875 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3876
3877 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3878
3879 * w32console.c (Fset_screen_color): Doc fix.
3880 (Fget_screen_color): New function.
3881 (syms_of_ntterm): Defsubr it.
3882
3883 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3884 unlink the temporary file if Fcall_process didn't create it in the
3885 first place.
3886 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3887 child process will be redirected to a file specified with `:file'.
3888 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3889 cue to call_process_cleanup not to close that handle.
3890
3891 2011-05-07 Ben Key <bkey76@gmail.com>
3892
3893 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3894 one of two shell specific rules, either bootstrap-temacs-CMD or
3895 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3896 to the previous implementation of the bootstrap-temacs rule.
3897 The bootstrap-temacs-CMD rule is similar to the previous
3898 implementation of the bootstrap-temacs rule except that it
3899 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3900 variable.
3901
3902 These changes, along with some changes to nt/configure.bat,
3903 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3904 earlier fix to add support for --cflags and --ldflags options
3905 that include quotes so that it works whether make uses cmd or
3906 sh as the shell.
3907
3908 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3909
3910 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3911 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3912 is a constant.
3913 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3914 a string. Handle both cases.
3915 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3916 (Fdbus_register_method): Use Qinvalid_function.
3917
3918 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3919
3920 * makefile.w32-in: Update dependencies.
3921 (LISP_H): Add inttypes.h and stdin.h.
3922 (PROCESS_H): Add unistd.h.
3923
3924 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3925
3926 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3927 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3928
3929 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3930
3931 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3932
3933 * term.c (vfatal): Remove stray call to va_end.
3934 It's not needed and the C Standard doesn't allow it here anyway.
3935
3936 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3937 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3938
3939 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3940 bytes.
3941
3942 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3943
3944 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3945
3946 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3947
3948 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3949
3950 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3951
3952 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3953 * charset.c (Fdefine_charset_internal): Don't initialize
3954 charset.code_space[15]. The value was garbage, on hosts with
3955 32-bit int (Bug#8600).
3956
3957 * lread.c (read_integer): Be more consistent with string-to-number.
3958 Use string_to_number to do the actual conversion; this avoids
3959 rounding errors and fixes some other screwups. Without this fix,
3960 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3961 (digit_to_number): Move earlier, for benefit of read_integer.
3962 Return -1 if the digit is out of range for the base, -2 if it is
3963 not a digit in any supported base. (Bug#8602)
3964
3965 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3966
3967 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3968 to match comment at start of function. This also removes a
3969 GCC warning about overflow in a 32+64-bit port.
3970
3971 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3972
3973 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3974 Reported by Stefan Monnier in
3975 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3976 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3977 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3978
3979 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3980 (EMACS_UINTPTR): Likewise, with uintptr_t.
3981
3982 * lisp.h: Prefer 64-bit EMACS_INT if available.
3983 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3984 on 32-bit hosts that have 64-bit int, so that they can access
3985 large files.
3986 However, temporarily disable this change unless the temporary
3987 symbol WIDE_EMACS_INT is defined.
3988
3989 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3990
3991 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3992 This removes an assumption that EMACS_INT and long are the same
3993 width as pointers. The assumption is true for Emacs porting targets
3994 now, but we want to make other targets possible.
3995 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3996 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3997 In the rest of the code, change types of integers that hold casted
3998 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3999 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4000 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4001 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4002 No need to cast type when ORing.
4003 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4004 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4005 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4006 assume EMACS_INT is the same width as char *.
4007 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4008 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4009 Remove no-longer-needed casts.
4010 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4011 (xg_tool_bar_help_callback, xg_make_tool_item):
4012 Use EMACS_INTPTR to hold an integer
4013 that will be cast to void *; this can avoid a GCC warning
4014 if EMACS_INT is not the same width as void *.
4015 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4016 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4017 (current_message_1, set_message_1):
4018 Use a local to convert to proper width without a cast.
4019 * xmenu.c (dialog_selection_callback): Likewise.
4020
4021 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4022 Also, don't assume VALBITS / RAND_BITS is less than 5,
4023 and don't rely on undefined behavior when shifting a 1 left into
4024 the sign bit.
4025 * lisp.h (get_random): Change signature to match.
4026
4027 * lread.c (hash_string): Use size_t, not int, for hash computation.
4028 Normally we prefer signed values; but hashing is special, because
4029 it's better to use unsigned division on hash table sizes so that
4030 the remainder is nonnegative. Also, size_t is the natural width
4031 for hashing into memory. The previous code used 'int', which doesn't
4032 retain enough info to hash well into very large tables.
4033 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4034
4035 * dbusbind.c: Don't possibly lose pointer info when converting.
4036 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4037 Use XPNTR rather than XHASH, so that the high-order bits of
4038 the pointer aren't lost when converting through void *.
4039
4040 * eval.c (Fautoload): Don't double-shift a pointer.
4041
4042 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4043
4044 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4045
4046 * gnutls.c (DEF_GNUTLS_FN):
4047 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4048
4049 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4050
4051 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4052 marker. (Bug#8610)
4053
4054 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4055
4056 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4057 New version that can reserve upto 2GB of heap space.
4058
4059 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4060
4061 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4062
4063 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4064
4065 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4066 `gnutls_certificate_set_x509_key_file'.
4067
4068 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4069
4070 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4071 Update dependencies.
4072
4073 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4074
4075 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4076 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4077 Remove unused parameter `fildes'.
4078 * process.c (read_process_output, send_process): Don't pass it.
4079
4080 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4081
4082 Fix previous change: the library cache is defined in w32.c.
4083 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4084 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4085
4086 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4087
4088 Implement dynamic loading of GnuTLS on Windows.
4089
4090 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4091 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4092 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4093 Declare.
4094
4095 * gnutls.c (Qgnutls_dll): Define.
4096 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4097 (gnutls_*): Declare function pointers.
4098 (init_gnutls_functions): New function to initialize function pointers.
4099 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4100 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4101 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4102 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4103 (emacs_gnutls_write, emacs_gnutls_read)
4104 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4105 (Fgnutls_available_p): New function.
4106 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4107 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4108 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4109
4110 * image.c: Include w32.h.
4111 (Vimage_type_cache): Delete.
4112 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4113 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4114 (w32_delayed_load): Move to w32.c.
4115
4116 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4117
4118 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4119 (w32_delayed_load): Move from image.c. When loading a library, record
4120 its filename in the :loaded-from property of the library id.
4121 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4122 Initialize and staticpro them.
4123 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4124
4125 * process.c: Include lisp.h before w32.h, not after.
4126 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4127 instead of gnutls_record_check_pending.
4128
4129 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4130
4131 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4132
4133 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4134 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4135 as passed in.
4136
4137 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4138
4139 * xterm.c (x_set_frame_alpha): Do not set property on anything
4140 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4141
4142 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4143
4144 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4145
4146 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4147
4148 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4149 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4150 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4151 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4152 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4153 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4154 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4155 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4156 (Qgnutls_bootprop_callbacks_verify): Make static.
4157
4158 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4159
4160 * callproc.c: Indentation fixup.
4161
4162 * sysdep.c (wait_for_termination_1): Make static.
4163 (wait_for_termination, interruptible_wait_for_termination):
4164 Move after wait_for_termination_1.
4165
4166 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4167
4168 * sysdep.c (interruptible_wait_for_termination): New function
4169 which is like wait_for_termination, but allows keyboard
4170 interruptions.
4171
4172 * callproc.c (Fcall_process): Add (:file "file") as an option for
4173 the STDOUT buffer.
4174 (Fcall_process_region): Ditto.
4175
4176 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4177
4178 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4179 rather than `XVECTOR (FOO)->size'.
4180
4181 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4182 inttypes.h, as a gnulib replacement is used if it not available in
4183 system headers.
4184
4185 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4186
4187 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4188 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4189 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4190
4191 * coding.c (coding_alloc_by_realloc): Error out if destination
4192 will grow beyond MOST_POSITIVE_FIXNUM.
4193 (decode_coding_emacs_mule): Abort if there isn't enough place in
4194 charbuf for the composition carryover bytes. Reserve an extra
4195 space for up to 2 characters produced in a loop.
4196 (decode_coding_iso_2022): Abort if there isn't enough place in
4197 charbuf for the composition carryover bytes.
4198
4199 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4200
4201 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4202 aborting when %lld or %lll format is passed.
4203 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4204 %llo or %llx format is passed. (Bug#8545)
4205
4206 * window.c (window_scroll_line_based): Use a marker instead of
4207 simple variables to record original value of point. (Bug#7952)
4208
4209 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4210 produced by %s or %c overflows available buffer space. (Bug#8545)
4211
4212 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4213
4214 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4215 (SIZE_MAX): Move defn after all includes, as they might #define it.
4216
4217 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4218
4219 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4220
4221 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4222
4223 * keyboard.c (Qdelayed_warnings_hook): Define.
4224 (command_loop_1): Run `delayed-warnings-hook'
4225 if Vdelayed_warnings_list is non-nil.
4226 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4227 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4228
4229 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4230
4231 * doprnt.c (doprnt): Don't return value smaller than the buffer
4232 size if the message was truncated. (Bug#8545).
4233
4234 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4235
4236 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4237 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4238
4239 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4240
4241 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4242
4243 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4244
4245 * makefile.w32-in: Update dependencies.
4246
4247 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4248
4249 Improve `doprnt' and its usage. (Bug#8545)
4250 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4251 `format_end'. Remove support for %l as a conversion specifier.
4252 Don't use xrealloc. Improve diagnostics when the %l size modifier
4253 is used. Update the commentary.
4254
4255 * eval.c (verror): Simplify calculation of size_t.
4256
4257 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4258 messages.
4259
4260 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4261
4262 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4263 change.
4264
4265 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4266
4267 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4268 This makes this file independent of the recent pseudovector change.
4269
4270 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4271
4272 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4273
4274 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4275 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4276 Remove unused local.
4277 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4278
4279 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4280 GCC 4.6.0 optimizes based on type-based alias analysis.
4281 For example, if b is of type struct buffer * and v of type struct
4282 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4283 != &v->size, and therefore "v->size = 1; b->size = 2; return
4284 v->size;" must therefore return 1. This assumption is incorrect
4285 for Emacs, since it type-puns struct Lisp_Vector * with many other
4286 types. To fix this problem, this patch adds a new type struct
4287 vectorlike_header that documents the constraints on layout of vectors
4288 and pseudovectors, and helps optimizing compilers not get fooled
4289 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4290 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4291 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4292 the size member.
4293 (XSETPVECTYPE): Rewrite in terms of new macro.
4294 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4295 This is a bit clearer, and further avoids the possibility of
4296 undesirable aliasing.
4297 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4298 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4299 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4300 since Lisp_Subr is a special case (no "next" field).
4301 (ASIZE): Now uses header.size rather than size.
4302 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4303 to avoid the hassle of writing XVECTOR (foo)->header.size.
4304 (struct vectorlike_header): New type.
4305 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4306 object, to help avoid aliasing.
4307 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4308 (SUBRP): Likewise, since Lisp_Subr is a special case.
4309 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4310 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4311 (struct Lisp_Hash_Table): Combine first two members into a single
4312 struct vectorlike_header member. All uses of "size" and "next" members
4313 changed to be "header.size" and "header.next".
4314 * buffer.h (struct buffer): Likewise.
4315 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4316 * frame.h (struct frame): Likewise.
4317 * process.h (struct Lisp_Process): Likewise.
4318 * termhooks.h (struct terminal): Likewise.
4319 * window.c (struct save_window_data, struct saved_window): Likewise.
4320 * window.h (struct window): Likewise.
4321 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4322 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4323 * buffer.c (init_buffer_once): Likewise.
4324 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4325 special case.
4326 * process.c (Fformat_network_address): Use local var for size,
4327 for brevity.
4328
4329 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4330
4331 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4332 * data.c (atof): Remove decl; no longer used or needed.
4333 (digit_to_number): Move to lread.c.
4334 (Fstring_to_number): Use new string_to_number function, to be
4335 consistent with how the Lisp reader treats infinities and NaNs.
4336 Do not assume that floating-point numbers represent EMACS_INT
4337 without losing information; this is not true on most 64-bit hosts.
4338 Avoid double-rounding errors, by insisting on integers when
4339 parsing non-base-10 numbers, as the documentation specifies.
4340 * lisp.h (string_to_number): New decl, replacing ...
4341 (isfloat_string): Remove.
4342 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4343 (read1): Do not accept +. and -. as integers; this
4344 appears to have been a coding error. Similarly, do not accept
4345 strings like +-1e0 as floating point numbers. Do not report
4346 overflow for integer overflows unless the base is not 10 which
4347 means we have no simple and reliable way to continue.
4348 Break out the floating-point parsing into a new
4349 function string_to_number, so that Fstring_to_number parses
4350 floating point numbers consistently with the Lisp reader.
4351 (digit_to_number): Move here from data.c. Make it static inline.
4352 (E_CHAR, EXP_INT): Remove, replacing with ...
4353 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4354 (string_to_number): New function, replacing isfloat_string.
4355 This function checks for valid syntax and produces the resulting
4356 Lisp float number too. Rework it so that string-to-number
4357 no longer mishandles examples like "1.0e+". Use strtoumax,
4358 so that overflow for non-base-10 numbers is reported only when
4359 there's no portable and simple way to convert to floating point.
4360
4361 * textprop.c (set_text_properties_1): Rewrite for clarity,
4362 and to avoid GCC warning about integer overflow.
4363
4364 * intervals.h (struct interval): Use EMACS_INT for members
4365 where EMACS_UINT might cause problems. See
4366 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4367 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4368 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4369 All uses changed.
4370 (offset_intervals): Tell GCC not to worry about length overflow
4371 when negating a negative length.
4372
4373 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4374 (overrun_check_free): Likewise.
4375
4376 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4377 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4378 word size.
4379
4380 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4381 (gnutls_make_error): Rename local to avoid shadowing.
4382 (gnutls_emacs_global_deinit): ifdef out; not used.
4383 (Fgnutls_boot): Use const for pointer to readonly storage.
4384 Comment out unused local. Fix pointer signedness problems.
4385
4386 * lread.c (openp): Don't stuff size_t into an 'int'.
4387 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4388 about possible signed overflow.
4389
4390 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4391 (GDK_KEY_g): Don't define if already defined.
4392 (xg_prepare_tooltip): Avoid pointer signedness problem.
4393 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4394
4395 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4396 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4397
4398 * xfns.c (Fx_window_property): Simplify a bit,
4399 to make a bit faster and to avoid GCC 4.6.0 warning.
4400 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4401
4402 * fns.c (internal_equal): Don't assume size_t fits in int.
4403
4404 * alloc.c (compact_small_strings): Tighten assertion a little.
4405
4406 Replace pEd with more-general pI, and fix some printf arg casts.
4407 * lisp.h (pI): New macro, generalizing old pEd macro to other
4408 conversion specifiers. For example, use "...%"pI"d..." rather
4409 than "...%"pEd"...".
4410 (pEd): Remove. All uses replaced with similar uses of pI.
4411 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4412 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4413 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4414 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4415 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4416 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4417 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4418 64-bit hosts.
4419 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4420 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4421 * print.c (safe_debug_print, print_object): Likewise.
4422 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4423 to int.
4424 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4425 avoiding the 0 flag, which is not portable.
4426 * process.c (Fmake_network_process): Use pI to avoid cast.
4427 * region-cache.c (pp_cache): Likewise.
4428 * xdisp.c (decode_mode_spec): Likewise.
4429 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4430 behavior on 64-bit hosts with printf arg.
4431 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4432 (x_stop_queuing_selection_requests): Likewise.
4433 (x_get_window_property): Don't truncate byte count to an 'int'
4434 when tracing.
4435
4436 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4437 here, since it parses constructs like leading '-' and spaces,
4438 which are not wanted; and it overflows with large numbers.
4439 Instead, simply match F[0-9]+, which is what is wanted anyway.
4440
4441 * alloc.c: Remove unportable assumptions about struct layout.
4442 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4443 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4444 (allocate_vectorlike, make_pure_vector): Use the new macros,
4445 plus offsetof, to remove unportable assumptions about struct layout.
4446 These assumptions hold on all porting targets that I know of, but
4447 they are not guaranteed, they're easy to remove, and removing them
4448 makes further changes easier.
4449
4450 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4451 This doesn't fix a bug but makes the code clearer.
4452 (string_overrun_cookie): Now const. Use initializers that
4453 don't formally overflow signed char, to avoid warnings.
4454 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4455 can cause Emacs to crash when string overrun checking is enabled.
4456 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4457 multiple of sizeof (EMACS_INT); it need not be, if
4458 alignof(EMACS_INT) < sizeof (EMACS_INT).
4459 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4460
4461 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4462
4463 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4464
4465 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4466
4467 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4468 supposed to be handshaking. (Bug#8556)
4469 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4470
4471 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4472
4473 * lisp.h (Qdebug): List symbol.
4474 * eval.c (Qdebug): Restore global linkage.
4475 * keyboard.c (debug-on-event): New variable.
4476 (handle_user_signal): Break into debugger when debug-on-event
4477 matches the current signal symbol.
4478
4479 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4480
4481 * alloc.c (check_sblock, check_string_bytes)
4482 (check_string_free_list): Convert to standard C.
4483
4484 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4485
4486 * w32.c (emacs_gnutls_push): Fix typo.
4487
4488 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4489
4490 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4491 "cast to pointer from integer of different size".
4492
4493 Improve doprnt and its use in verror. (Bug#8545)
4494 * doprnt.c (doprnt): Document the set of format control sequences
4495 supported by the function. Use SAFE_ALLOCA instead of always
4496 using `alloca'.
4497
4498 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4499 is one byte too soon. Don't use xrealloc; instead xfree and
4500 xmalloc anew.
4501
4502 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4503
4504 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4505 callbacks stage.
4506
4507 * gnutls.c: Renamed global_initialized to
4508 gnutls_global_initialized. Added internals for the
4509 :verify-hostname-error, :verify-error, and :verify-flags
4510 parameters of `gnutls-boot' and documented those parameters in the
4511 docstring. Start callback support.
4512 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4513 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4514 on error. Return error code.
4515 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4516 (emacs_gnutls_read): Likewise.
4517 (Fgnutls_boot): Return handshake error code.
4518 (emacs_gnutls_handle_error): New function.
4519 (wsaerror_to_errno): Likewise.
4520
4521 * w32.h (emacs_gnutls_pull): Add prototype.
4522 (emacs_gnutls_push): Likewise.
4523
4524 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4525 (emacs_gnutls_push): Likewise.
4526
4527 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4528
4529 * process.c (wait_reading_process_output): Check if GnuTLS
4530 buffered some data internally if no FDs are set for TLS
4531 connections.
4532
4533 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4534 (LIBS): Link to USER_LIBS.
4535 ($(BLD)/gnutls.$(0)): New target.
4536
4537 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4538
4539 * xdisp.c (handle_single_display_spec): Rename the
4540 display_replaced_before_p argument into display_replaced_p, to
4541 make it consistent with the commentary. Fix typos in the
4542 commentary.
4543
4544 * textprop.c (syms_of_textprop): Remove dead code.
4545 (copy_text_properties): Delete obsolete commentary about an
4546 interface that was deleted long ago. Fix typos in the description
4547 of arguments.
4548
4549 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4550 to changes in oldXMenu/XMenu.h from 2011-04-16.
4551 <menu_help_message, prev_menu_help_message>: Constify.
4552 (IT_menu_make_room): menu->help_text is now `const char **';
4553 adjust.
4554
4555 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4556 to changes in oldXMenu/XMenu.h from 2011-04-16.
4557 (struct XMenu): Declare `help_text' `const char **'.
4558
4559 * xfaces.c <Qunspecified>: Make extern again.
4560
4561 * syntax.c: Include sys/types.h before including regex.h, as
4562 required by Posix.
4563
4564 * doc.c (get_doc_string): Improve the format passed to `error'.
4565
4566 * doprnt.c (doprnt): Improve commentary.
4567
4568 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4569
4570 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4571 them with etags.
4572
4573 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4574 changes in globals.h immediately force recompilation.
4575 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4576 $(CURDIR)/s/ms-w32.h.
4577 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4578
4579 * character.c (Fchar_direction): Function deleted.
4580 (syms_of_character): Don't defsubr it.
4581 <char-direction-table>: Deleted.
4582
4583 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4584
4585 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4586 * doprnt.c: Include limits.h.
4587 (SIZE_MAX): New macro.
4588 (doprnt): Return a size_t value. 2nd arg is now size_t.
4589 Many local variables are now size_t instead of int or unsigned.
4590 Improve overflow protection. Support `l' modifier for integer
4591 conversions. Support %l conversion. Don't assume an EMACS_INT
4592 argument for integer conversions and for %c.
4593
4594 * lisp.h (doprnt): Restore prototype.
4595
4596 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4597 $(SRC)/character.h.
4598
4599 * Makefile.in (base_obj): Add back doprnt.o.
4600
4601 * deps.mk (doprnt.o): Add back prerequisites.
4602 (callint.o): Depend on character.h.
4603
4604 * eval.c (internal_lisp_condition_case): Include the handler
4605 representation in the error message.
4606 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4607 when breaking from the loop.
4608
4609 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4610
4611 * callint.c (Fcall_interactively): When displaying error message
4612 about invalid control letter, pass the character's codepoint, not
4613 a pointer to its multibyte form. Improve display of the character
4614 in octal and display also its hex code.
4615
4616 * character.c (char_string): Use %x to display the (unsigned)
4617 codepoint of an invalid character, to avoid displaying a bogus
4618 negative value.
4619
4620 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4621 `error', not SYMBOL_NAME itself.
4622
4623 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4624 character arguments to `error'.
4625
4626 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4627 to `error' in error message about FINAL_CHAR argument. Make sure
4628 FINAL_CHAR is a character, and use %c when it is passed as
4629 argument to `error'.
4630
4631 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4632
4633 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4634
4635 * w32.c: Include <time.h>.
4636 (sys_localtime): New function.
4637
4638 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4639
4640 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4641
4642 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4643
4644 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4645
4646 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4647 zombies (Bug#8467).
4648
4649 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4650
4651 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4652 gl_state.e_property when gl_state.object is Qt.
4653
4654 * insdel.c (make_gap_larger): Remove limitation of buffer size
4655 to <= INT_MAX.
4656
4657 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4658
4659 * xdisp.c (lookup_glyphless_char_display)
4660 (produce_glyphless_glyph): Handle cons cell entry in
4661 glyphless-char-display.
4662 (Vglyphless_char_display): Document it.
4663
4664 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4665 glyphless-char-display.
4666
4667 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4668
4669 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4670
4671 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4672
4673 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4674 definition for no-X builds.
4675
4676 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4677
4678 Static checks with GCC 4.6.0 and non-default toolkits.
4679
4680 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4681
4682 * process.c (keyboard_bit_set): Define only if SIGIO.
4683 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4684 (send_process): Repair possible setjmp clobbering.
4685
4686 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4687
4688 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4689
4690 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4691
4692 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4693 Define only if needed.
4694
4695 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4696 by pacifying GCC about it. Maybe it's time to retire it?
4697 * xfaces.c (USG, __TIMEVAL__): Likewise.
4698
4699 * dispextern.h (struct redisplay_interface): Rename param
4700 to avoid shadowing.
4701 * termhooks.h (struct terminal): Likewise.
4702 * xterm.c (xembed_send_message): Likewise.
4703
4704 * insdel.c (make_gap_smaller): Define only if
4705 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4706
4707 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4708 it.
4709
4710 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4711 so that we aren't warned about unused symbols.
4712
4713 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4714
4715 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4716
4717 * xfns.c (x_real_positions): Mark locals as initialized.
4718
4719 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4720
4721 * xterm.c: Fix problems found by static analysis with other toolkits.
4722 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4723 (x_dispatch_event): Declare static if USE_GTK, and
4724 define if USE_GTK || USE_X_TOOLKIT.
4725 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4726 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4727 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4728 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4729
4730 * xmenu.c (menu_help_callback): Pointer type fixes.
4731 Use const pointers when pointing at readonly data. Avoid pointer
4732 signedness clashes.
4733 (FALSE): Remove unused macro.
4734 (update_frame_menubar): Remove unused decl.
4735
4736 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4737
4738 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4739 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4740 (single_menu_item): Rename local to avoid shadowing.
4741
4742 * keyboard.c (make_lispy_event): Remove unused local var.
4743
4744 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4745 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4746
4747 * bitmaps: Change bitmaps from unsigned char back to the X11
4748 compatible char. Avoid the old compiler warnings about
4749 out-of-range initializers by using, for example, '\xab' rather
4750 than 0xab.
4751
4752 * xgselect.c (xgselect_initialize): Check vs interface
4753 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4754
4755 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4756
4757 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4758 to read-only memory.
4759
4760 * fns.c (vector): Remove; this old hack is no longer needed.
4761
4762 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4763 Remove unused var.
4764 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4765
4766 * xrdb.c (x_load_resources): Omit unused local.
4767
4768 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4769 (x_window): Rename locals to avoid shadowing.
4770 (USG): Use the kludged USG macro, to pacify gcc.
4771
4772 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4773 (x_term_init): Remove local to avoid shadowing.
4774
4775 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4776
4777 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4778 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4779
4780 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4781
4782 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4783
4784 Fix regex.c, syntax.c and friends for buffers > 2GB.
4785 * syntax.h (struct gl_state_s): Declare character position members
4786 EMACS_INT.
4787
4788 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4789
4790 * textprop.c (verify_interval_modification, interval_of):
4791 Declare arguments EMACS_INT.
4792
4793 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4794 EMACS_INT.
4795
4796 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4797
4798 * indent.c (Fvertical_motion): Local variable it_start is now
4799 EMACS_INT.
4800
4801 * regex.c (re_match, re_match_2, re_match_2_internal)
4802 (bcmp_translate, regcomp, regexec, print_double_string)
4803 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4804 (re_compile_pattern, re_exec): Declare arguments and local
4805 variables `size_t' and `ssize_t' and return values `regoff_t', as
4806 appropriate.
4807 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4808 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4809 <compile_stack_type>: `size' and `avail' are now `size_t'.
4810
4811 * regex.h <regoff_t>: Use ssize_t, not int.
4812 (re_search, re_search_2, re_match, re_match_2): Arguments that
4813 specify buffer/string position and length are now ssize_t and
4814 size_t. Return type is regoff_t.
4815
4816 2011-04-16 Ben Key <bkey76@gmail.com>
4817
4818 * nsfont.m: Fixed bugs in ns_get_family and
4819 ns_descriptor_to_entity that were caused by using free to
4820 deallocate memory blocks that were allocated by xmalloc (via
4821 xstrdup). This caused Emacs to crash when compiled with
4822 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4823 --enable-checking=xmallocoverrun). xfree is now used to
4824 deallocate these memory blocks.
4825
4826 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4827
4828 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4829
4830 emacs_write: Accept and return EMACS_INT for sizes.
4831 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4832 et seq.
4833 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4834 Accept and return EMACS_INT.
4835 (emacs_gnutls_write): Return the number of bytes written on
4836 partial writes.
4837 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4838 (emacs_read, emacs_write): Remove check for negative size, as the
4839 Emacs source code has been audited now.
4840 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4841 (emacs_read, emacs_write): Use it.
4842 * process.c (send_process): Adjust to the new signatures of
4843 emacs_write and emacs_gnutls_write. Do not attempt to store
4844 a byte offset into an 'int'; it might overflow.
4845 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4846
4847 * sound.c: Don't assume sizes fit in 'int'.
4848 (struct sound_device.period_size, alsa_period_size):
4849 Return EMACS_INT, not int.
4850 (struct sound_device.write, vox_write, alsa_write):
4851 Accept EMACS_INT, not int.
4852 (wav_play, au_play): Use EMACS_INT to store sizes and to
4853 record read return values.
4854
4855 2011-04-15 Ben Key <bkey76@gmail.com>
4856
4857 * keyboard.c (Qundefined): Don't declare static since it is used
4858 in nsfns.m.
4859 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4860 static since they are used in nsfont.m.
4861
4862 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4863
4864 * process.c (Qprocessp): Don't declare static.
4865 * lisp.h (Qprocessp): Declare again.
4866
4867 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4868
4869 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4870
4871 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4872
4873 Improve C-level modularity by making more things 'static'.
4874
4875 Don't publish debugger-only interfaces to other modules.
4876 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4877 (verify_bytepos, count_markers): Move decls to the only modules
4878 that need them.
4879 * region-cache.h (pp_cache): Likewise.
4880 * window.h (check_all_windows): Likewise.
4881 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4882
4883 * sysdep.c (croak): Now static, if
4884 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4885 * syssignal.h (croak): Declare only if not static.
4886
4887 * alloc.c (refill_memory_reserve): Now static if
4888 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4889 * lisp.h (refill_memory_reserve): Declare only if not static.
4890
4891 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4892 Define only if USE_LUCID.
4893
4894 * xrdb.c (x_customization_string, x_rm_string): Now static.
4895
4896 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4897 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4898
4899 * xdisp.c (draw_row_with_mouse_face): Now static.
4900 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4901
4902 * window.h (check_all_windows): Mark externally visible.
4903
4904 * window.c (window_deletion_count): Now static.
4905
4906 * undo.c: Make symbols static if they're not exported.
4907 (last_undo_buffer, last_boundary_position, pending_boundary):
4908 Now static.
4909
4910 * textprop.c (interval_insert_behind_hooks): Now static.
4911 (interval_insert_in_front_hooks): Likewise.
4912
4913 * term.c: Make symbols static if they're not exported.
4914 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4915 (max_frame_lines, tty_set_terminal_modes):
4916 (tty_reset_terminal_modes, tty_turn_off_highlight):
4917 (get_tty_terminal): Now static.
4918 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4919 * termhooks.h (term_mouse_moveto): Do not declare if
4920 HAVE_WINDOW_SYSTEM.
4921 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4922 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4923
4924 * sysdep.c: Make symbols static if they're not exported.
4925 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4926 Now static.
4927 (sigprocmask_set, full_mask): Remove; unused.
4928 (wait_debugging): Mark as visible.
4929 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4930 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4931
4932 * syntax.c (syntax_temp): Define only if !__GNUC__.
4933
4934 * sound.c (current_sound_device, current_sound): Now static.
4935
4936 * search.c (searchbufs, searchbuf_head): Now static.
4937
4938 * scroll.c (scroll_cost): Remove; unused.
4939 * dispextern.h (scroll_cost): Remove decl.
4940
4941 * region-cache.h (pp_cache): Mark as externally visible.
4942
4943 * process.c: Make symbols static if they're not exported.
4944 (process_tick, update_tick, create_process, chan_process):
4945 (Vprocess_alist, proc_buffered_char, datagram_access):
4946 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4947 (deactivate_process): Mark defn as static, as well as decl.
4948 * lisp.h (create_process): Remove decl.
4949 * process.h (chan_process, Vprocess_alist): Remove decls.
4950
4951 * print.c: Make symbols static if they're not exported.
4952 (print_depth, new_backquote_output, being_printed, print_buffer):
4953 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4954 (print_interval, print_number_index, initial_stderr_stream):
4955 Now static.
4956 * lisp.h (Fprinc): Remove decl.
4957 (debug_output_compilation_hack): Mark as externally visible.
4958
4959 * sysdep.c (croak): Move decl from here to syssignal.h.
4960 * syssignal.h (croak): Put it here, so the API can be checked when
4961 'croak' is called from dissociate_if_controlling_tty.
4962
4963 * minibuf.c: Make symbols static if they're not exported.
4964 (minibuf_save_list, choose_minibuf_frame): Now static.
4965 * lisp.h (choose_minibuf_frame): Remove decl.
4966
4967 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4968
4969 * lread.c: Make symbols static if they're not exported.
4970 (read_objects, initial_obarray, oblookup_last_bucket_number):
4971 Now static.
4972 (make_symbol): Remove; unused.
4973 * lisp.h (initial_obarray, make_symbol): Remove decls.
4974
4975 * keyboard.c: Make symbols static if they're not exported.
4976 (single_kboard, recent_keys_index, total_keys, recent_keys):
4977 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4978 (this_single_command_key_start, echoing, last_auto_save):
4979 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4980 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4981 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4982 (Vlispy_mouse_stem, double_click_count):
4983 Now static.
4984 (force_auto_save_soon): Define only if SIGDANGER.
4985 (ignore_mouse_drag_p): Now static if
4986 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4987 (print_help): Remove; unused.
4988 (stop_character, last_timer_event): Mark as externally visible.
4989 * keyboard.h (ignore_mouse_drag_p): Declare only if
4990 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4991 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4992 * lisp.h (echoing): Remove decl.
4993 (force_auto_save_soon): Declare only if SIGDANGER.
4994 * xdisp.c (redisplay_window): Simplify code, to make it more
4995 obvious that ignore_mouse_drag_p is not accessed if !defined
4996 USE_GTK && !defined HAVE_NS.
4997
4998 * intervals.c: Make symbols static if they're not exported.
4999 (merge_properties_sticky, merge_interval_right, delete_interval):
5000 Now static.
5001 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5002
5003 * insdel.c: Make symbols static if they're not exported.
5004 However, leave prepare_to_modify_buffer alone. It's never
5005 called from outside this function, but that appears to be a bug.
5006 (combine_after_change_list, combine_after_change_buffer):
5007 (adjust_after_replace, signal_before_change): Now static.
5008 (adjust_after_replace_noundo): Remove; unused.
5009 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5010 (signal_before_change): Remove decls.
5011
5012 * indent.c (val_compute_motion, val_vmotion): Now static.
5013
5014 * image.c: Make symbols static if they're not exported.
5015 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5016 if USE_GTK.
5017 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5018 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5019
5020 * fringe.c (standard_bitmaps): Now static.
5021 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5022
5023 * frame.c: Make symbols static if they're not exported.
5024 (x_report_frame_params, make_terminal_frame): Now static.
5025 (get_frame_param): Now static, unless HAVE_NS.
5026 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5027 (x_get_resource_string): Remove; not used.
5028 * frame.h (make_terminal_frame, x_report_frame_params):
5029 (x_get_resource_string); Remove decls.
5030 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5031 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5032
5033 * font.c, fontset.c: Make symbols static if they're not exported.
5034 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5035 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5036 * font.c (font_close_object): Now static.
5037 * font.h (font_close_object): Remove.
5038 * fontset.c (FONTSET_OBJLIST): Remove.
5039 (free_realized_fontset) #if-0 the body, which does nothing.
5040 (face_suitable_for_char_p): #if-0, as it's never called.
5041 * fontset.h (face_suitable_for_char_p): Remove decl.
5042 * xfaces.c (face_at_string_position):
5043 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5044 since 0 is always ASCII.
5045
5046 * fns.c (weak_hash_tables): Now static.
5047
5048 * fileio.c: Make symbols static if they're not exported.
5049 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5050 (Vwrite_region_annotation_buffers): Now static.
5051
5052 * eval.c: Make symbols static if they're not exported.
5053 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5054 * lisp.h (backtrace_list): Remove decl.
5055
5056 * emacs.c: Make symbols static if they're not exported.
5057 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5058 (fatal_error_code, fatal_error_signal_hook, standard_args):
5059 Now static.
5060 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5061 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5062 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5063 * lisp.h (fatal_error_signal_hook): Remove decl.
5064 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5065
5066 * editfns.c: Move a (normally-unused) function to its only use.
5067 * editfns.c, lisp.h (get_operating_system_release): Remove.
5068 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5069 worth the hassle of breaking this out.
5070
5071 * xterm.c: Make symbols static if they're not exported.
5072 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5073 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5074 (x_destroy_window, x_delete_display):
5075 Now static.
5076 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5077 (x_mouse_leave): Remove; unused.
5078 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5079 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5080 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5081 Remove decls.
5082 (x_mouse_leave): Declare only if WINDOWSNT.
5083 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5084 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5085 USE_X_TOOLKIT.
5086
5087 * ftxfont.c: Make symbols static if they're not exported.
5088 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5089 HAVE_FREETYPE.
5090 * font.h (ftxfont_driver): Likewise.
5091
5092 * xfns.c: Make symbols static if they're not exported.
5093 (x_last_font_name, x_display_info_for_name):
5094 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5095 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5096 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5097 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5098 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5099 (last_show_tip_args): Now static.
5100 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5101 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5102 (x_screen_planes): Remove; unused.
5103 * dispextern.h (x_screen_planes): Remove decl.
5104
5105 * dispnew.c: Make symbols static if they're not exported.
5106 * dispextern.h (redraw_garbaged_frames, scrolling):
5107 (increment_row_positions): Remove.
5108 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5109 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5110 Now static.
5111 (redraw_garbaged_frames): Remove; unused.
5112
5113 * xfaces.c: Make symbols static if they're not exported.
5114 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5115 Remove decls.
5116 * xterm.h (defined_color): Remove decls.
5117 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5118 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5119 (menu_face_changed_default, defined_color, free_realized_face):
5120 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5121 (ascii_face_of_lisp_face): Remove; unused.
5122
5123 * xdisp.c: Make symbols static if they're not exported.
5124 * dispextern.h (scratch_glyph_row, window_box_edges):
5125 (glyph_to_pixel_coords, set_cursor_from_row):
5126 (get_next_display_element, set_iterator_to_next):
5127 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5128 (show_mouse_face): Remove decls
5129 * frame.h (message_buf_print): Likewise.
5130 * lisp.h (pop_message, set_message, check_point_in_composition):
5131 Likewise.
5132 * xterm.h (set_vertical_scroll_bar): Likewise.
5133 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5134 (message_buf_print, scratch_glyph_row, displayed_buffer):
5135 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5136 (get_next_display_element, show_mouse_face, window_box_edges):
5137 (frame_to_window_pixel_xy, check_point_in_composition):
5138 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5139 (glyph_to_pixel_coords): Remove; unused.
5140
5141 * dired.c (file_name_completion): Now static.
5142
5143 * dbusbind.c (xd_in_read_queued_messages): Now static.
5144
5145 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5146 * data.c (circular_list_error): Remove.
5147
5148 * commands.h (last_point_position, last_point_position_buffer):
5149 (last_point_position_window): Remove decls.
5150 * keyboard.c: Make these variables static.
5151
5152 * coding.h (coding, code_convert_region, encode_coding_gap):
5153 Remove decls.
5154 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5155 (iso_code_class, detect_coding, code_convert_region): Now static.
5156 (encode_coding_gap): Remove; unused.
5157
5158 * chartab.c (chartab_chars, chartab_bits): Now static.
5159
5160 * charset.h (charset_iso_8859_1): Remove decl.
5161 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5162 Now static.
5163
5164 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5165 * ccl.c (Vccl_program_table): Now static.
5166 (check_ccl_update): Remove; unused.
5167
5168 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5169 * category.h: ... from here.
5170 * category.c (check_category_table, set_category_set): Now static.
5171
5172 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5173 * lisp.h: Remove these decls.
5174
5175 * buffer.c (buffer_count): Remove unused var.
5176
5177 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5178 so that it's not optimized away.
5179 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5180 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5181 exported only to the debugger.
5182
5183 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5184 * atimer.h (run_all_atimers): Remove; not exported.
5185
5186 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5187 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5188 was inaccessible from Lisp.
5189 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5190 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5191
5192 alloc.c: Import and export fewer symbols, and remove unused items.
5193 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5194 is defined.
5195 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5196 it's not optimized away by whole-program optimization.
5197 (message_enable_multibyte, free_misc): Remove.
5198 (catchlist, handlerlist, mark_backtrace):
5199 Declare only if BYTE_MARK_STACK.
5200 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5201 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5202 (message_enable_multibyte): Remove decl.
5203 (free_misc, interval_free_list, float_block, float_block_index):
5204 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5205 (cons_free_list, last_marked_index):
5206 Now static.
5207 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5208 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5209 (mark_backtrace): Define only if BYTE_MARK_STACK.
5210 * xdisp.c (message_enable_multibyte): Now static.
5211
5212 Declare Lisp_Object Q* variables to be 'static' if not exported.
5213 This makes it easier for human readers (and static analyzers)
5214 to see whether these variables are used from other modules.
5215 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5216 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5217 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5218 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5219 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5220 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5221 * xmenu.c, xselect.c:
5222 Declare Q* vars static if they are not used in other modules.
5223 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5224 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5225 Remove decls of unexported vars.
5226 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5227
5228 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5229
5230 Make Emacs functions such as Fatom 'static' by default.
5231 This makes it easier for human readers (and static analyzers)
5232 to see whether these functions can be called from other modules.
5233 DEFUN now defines a static function. To make the function external
5234 so that it can be used in other C modules, use the new macro DEFUE.
5235 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5236 (Finit_image_library):
5237 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5238 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5239 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5240 Remove decls, since these functions are now static.
5241 (Funintern, Fget_internal_run_time): New decls, since these functions
5242 were already external.
5243
5244 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5245 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5246 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5247 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5248 * keyboard.c, keymap.c, lread.c:
5249 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5250 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5251 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5252 Mark functions with DEFUE instead of DEFUN,
5253 if they are used in other modules.
5254 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5255 decls for now-static functions.
5256 * buffer.h (Fdelete_overlay): Remove decl.
5257 * callproc.c (Fgetenv_internal): Mark as internal.
5258 * composite.c (Fremove_list_of_text_properties): Remove decl.
5259 (Fcomposition_get_gstring): New forward static decl.
5260 * composite.h (Fcomposite_get_gstring): Remove decl.
5261 * dired.c (Ffile_attributes): New forward static decl.
5262 * doc.c (Fdocumntation_property): New forward static decl.
5263 * eval.c (Ffetch_bytecode): New forward static decl.
5264 (Funintern): Remove extern decl; now in .h file where it belongs.
5265 * fileio.c (Fmake_symbolic_link): New forward static decl.
5266 * image.c (Finit_image_library): New forward static decl.
5267 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5268 * intervals.h (Fprevious_property_change):
5269 (Fremove_list_of_text_properties): Remove decls.
5270 * keyboard.c (Fthis_command_keys): Remove decl.
5271 (Fcommand_execute): New forward static decl.
5272 * keymap.c (Flookup_key): New forward static decl.
5273 (Fcopy_keymap): Now static.
5274 * keymap.h (Flookup_key): Remove decl.
5275 * process.c (Fget_process): New forward static decl.
5276 (Fprocess_datagram_address): Mark as internal.
5277 * syntax.c (Fsyntax_table_p): New forward static decl.
5278 (skip_chars): Remove duplicate decl.
5279 * textprop.c (Fprevious_property_change): New forward static decl.
5280 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5281 Now internal.
5282 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5283 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5284
5285 * editfns.c (Fformat): Remove unreachable code.
5286
5287 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5288
5289 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5290 change. (Bug#8496)
5291
5292 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5293
5294 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5295 when at ZV. (Bug#8487)
5296
5297 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5298
5299 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5300 (Bug#8437)
5301 * keyboard.c (parse_tool_bar_item): Likewise.
5302 * sound.c (sound_cleanup, alsa_close): Likewise.
5303 * termcap.c (tgetent): Likewise.
5304 * xfns.c (x_default_font_parameter): Likewise.
5305 * xsettings.c (read_and_apply_settings): Likewise.
5306
5307 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5308 (overrun_check_free): Protoize.
5309
5310 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5311
5312 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5313 since callers should never pass a negative size.
5314 Change the signature to match that of plain 'read' and 'write'; see
5315 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5316 * lisp.h: Update prototypes of emacs_write and emacs_read.
5317
5318 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5319
5320 * xdisp.c (redisplay_window): Don't try to determine the character
5321 position of the scroll margin if the window start point w->startp
5322 is outside the buffer's accessible region. (Bug#8468)
5323
5324 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5325
5326 Fix write-region and its subroutines for buffers > 2GB.
5327 * fileio.c (a_write, e_write): Modify declaration of arguments and
5328 local variables to support buffers larger than 2GB.
5329 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5330
5331 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5332 argument, local variables, and return value.
5333
5334 * lisp.h: Update prototypes of emacs_write and emacs_read.
5335
5336 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5337
5338 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5339
5340 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5341
5342 Fix more problems found by GCC 4.6.0's static checks.
5343
5344 * xdisp.c (vmessage): Use a better test for character truncation.
5345
5346 * charset.c (load_charset_map): <, not <=, for optimization,
5347 and to avoid potential problems with integer overflow.
5348 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5349 * casetab.c (set_identity, shuffle): Likewise.
5350 * editfns.c (Fformat): Likewise.
5351 * syntax.c (skip_chars): Likewise.
5352
5353 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5354 This also lets GCC 4.6.0 generate slightly better loop code.
5355
5356 * callint.c (Fcall_interactively): <, not <=, for optimization.
5357 (Fcall_interactively): Count the number of arguments produced,
5358 not the number of arguments given. This is simpler and lets GCC
5359 4.6.0 generate slightly better code.
5360
5361 * ftfont.c: Distingish more carefully between FcChar8 and char.
5362 The previous code passed unsigned char * to a functions like
5363 strlen and xstrcasecmp that expect char *, which does not
5364 conform to the C standard.
5365 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5366 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5367 char * when the C standard requires it.
5368
5369 * keyboard.c (read_char): Remove unused var.
5370
5371 * eval.c: Port to Windows vsnprintf (Bug#8435).
5372 Include <limits.h>.
5373 (SIZE_MAX): Define if the headers do not.
5374 (verror): Do not give up if vsnprintf returns a negative count.
5375 Instead, grow the buffer. This ports to Windows vsnprintf, which
5376 does not conform to C99. Problem reported by Eli Zaretskii.
5377 Also, simplify the allocation scheme, by avoiding the need for
5378 calling realloc, and removing the ALLOCATED variable.
5379
5380 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5381
5382 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5383 But keep the doprint source code for now, as we might revamp it
5384 and use it again (Bug#8435).
5385 * lisp.h (doprnt): Remove.
5386 * Makefile.in (base_obj): Remove doprnt.o.
5387 * deps.mk (doprnt.o): Remove.
5388
5389 error: Print 32- and 64-bit integers portably (Bug#8435).
5390 Without this change, on typical 64-bit hosts error ("...%d...", N)
5391 was used to print both 32- and 64-bit integers N, which relied on
5392 undefined behavior.
5393 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5394 New macro.
5395 * lisp.h (error, verror): Mark as printf-like functions.
5396 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5397 Report overflow in size calculations when allocating printf buffer.
5398 Do not truncate output string at its first null byte.
5399 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5400 Truncate the output at a character boundary, since vsnprintf does not
5401 do that.
5402 * charset.c (check_iso_charset_parameter): Convert internal
5403 character to string before calling 'error', since %c now has the
5404 printf meaning.
5405 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5406 overflow when computing char to be passed to 'error'. Do not
5407 pass Lisp_Object to 'error'; pass the integer instead.
5408 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5409 formatted with plain %d.
5410
5411 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5412
5413 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5414
5415 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5416
5417 * xterm.c (x_catch_errors): Remove duplicate declaration.
5418
5419 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5420
5421 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5422
5423 2011-04-10 Jim Meyering <meyering@redhat.com>
5424
5425 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5426 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5427 return ssize_t not "int", and use size_t as the buffer length.
5428 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5429 * gnutls.h: Update declarations.
5430 * process.c (read_process_output): Use ssize_t, to match.
5431 (send_process): Likewise.
5432
5433 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5434
5435 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5436
5437 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5438
5439 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5440 Use unsigned char, to match FcChar8 type definition.
5441
5442 * xterm.c (handle_one_xevent):
5443 * xmenu.c (create_and_show_popup_menu):
5444 * xselect.c (x_decline_selection_request)
5445 (x_reply_selection_request): Avoid type-punned deref of X events.
5446
5447 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5448
5449 Fix some uses of `int' instead of EMACS_INT.
5450 * search.c (string_match_1, fast_string_match)
5451 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5452 (scan_buffer, find_next_newline_no_quit)
5453 (find_before_next_newline, search_command, Freplace_match)
5454 (Fmatch_data): Make some `int' variables be EMACS_INT.
5455
5456 * xdisp.c (display_count_lines): 3rd argument and return value now
5457 EMACS_INT. All callers changed.
5458 (pint2hrstr): Last argument is now EMACS_INT.
5459
5460 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5461 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5462 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5463 (decode_coding_utf_16, decode_coding_emacs_mule)
5464 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5465 (decode_coding_ccl, decode_coding_charset)
5466 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5467 (decode_coding_iso_2022, decode_coding_emacs_mule)
5468 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5469 <char_offset, last_offset>: Declare EMACS_INT.
5470 (encode_coding_utf_8, encode_coding_utf_16)
5471 (encode_coding_emacs_mule, encode_invocation_designation)
5472 (encode_designation_at_bol, encode_coding_iso_2022)
5473 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5474 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5475 Declare EMACS_INT.
5476 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5477 (encode_invocation_designation): Last argument P_NCHARS is now
5478 EMACS_INT.
5479 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5480 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5481
5482 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5483 All users changed.
5484
5485 * ccl.c (Fccl_execute_on_string): Declare some variables
5486 EMACS_INT.
5487
5488 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5489
5490 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5491
5492 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5493
5494 * process.c (Fformat_network_address): Doc fix.
5495
5496 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5497
5498 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5499
5500 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5501
5502 * keyboard.c (read_char): Call Lisp function help-form-show,
5503 instead of using internal_with_output_to_temp_buffer.
5504 (Qhelp_form_show): New var.
5505 (syms_of_keyboard): Use DEFSYM macro.
5506
5507 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5508
5509 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5510
5511 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5512
5513 * process.c (Flist_processes): Remove to Lisp.
5514 (list_processes_1): Delete.
5515
5516 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5517
5518 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5519
5520 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5521
5522 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5523
5524 Fix more problems found by GCC 4.6.0's static checks.
5525
5526 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5527
5528 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5529
5530 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5531
5532 * xdisp.c (vmessage): Mark as a printf-like function.
5533
5534 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5535
5536 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5537
5538 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5539 printf-like functions.
5540 (tiff_load): Add casts to remove these marks before passing them
5541 to system-supplied API.
5542
5543 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5544
5545 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5546 This avoids several warnings with gcc -Wstrict-overflow.
5547 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5548 directly, rather than having caller test rule sign. This avoids
5549 some unnecessary tests.
5550 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5551 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5552 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5553
5554 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5555 (xfont_open): Avoid unnecessary tests.
5556
5557 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5558
5559 * composite.h, composite.c (composition_gstring_put_cache):
5560 Use EMACS_INT, not int, for length.
5561
5562 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5563 breaking out part of COMPOSITION_DECODE_RULE.
5564 (COMPOSITION_DECODE_RULE): Use it.
5565 * composite.c (get_composition_id): Remove unused local vars,
5566 by using the new macro.
5567
5568 * textprop.c (set_text_properties_1): Change while to do-while,
5569 since the condition is always true at first.
5570
5571 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5572 (interval_deletion_adjustment): Return unsigned value.
5573 All uses changed.
5574
5575 * process.c (list_processes_1, create_pty, read_process_output):
5576 (exec_sentinel): Remove vars that were set but not used.
5577 (create_pty): Remove unnecessary "volatile"s.
5578 (Fnetwork_interface_info): Avoid possibility of int overflow.
5579 (read_process_output): Do adaptive read buffering even if carryover.
5580 (read_process_output): Simplify nbytes computation if buffered.
5581
5582 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5583
5584 * syntax.c (scan_words): Remove var that was set but not used.
5585 (update_syntax_table): Use unsigned instead of int.
5586
5587 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5588 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5589 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5590
5591 * print.c (print_error_message): Avoid int overflow.
5592
5593 * font.c (font_list_entities): Redo for clarity,
5594 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5595
5596 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5597 (font_score): Avoid potential overflow in diff calculation.
5598
5599 * fns.c (substring_both): Remove var that is set but not used.
5600 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5601
5602 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5603
5604 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5605 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5606 can always succeed if overflow has undefined behavior.
5607
5608 * search.c (boyer_moore, wordify): Remove vars set but not used.
5609 (wordify): Omit three unnecessary tests.
5610
5611 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5612 All callers changed. This avoids the need for an unused var.
5613
5614 * casefiddle.c (casify_region): Remove var that is set but not used.
5615
5616 * dired.c (file_name_completion): Remove var that is set but not used.
5617
5618 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5619
5620 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5621 (Finsert_file_contents): Remove unnecessary code checking fd.
5622
5623 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5624 Check for integer overflow on size calculations.
5625
5626 * buffer.c (Fprevious_overlay_change): Remove var that is set
5627 but not used.
5628
5629 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5630 Remove vars that are set but not used.
5631 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5632 (timer_check_2): Mark vars as initialized.
5633
5634 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5635
5636 * image.c (lookup_image): Remove var that is set but not used.
5637 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5638
5639 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5640 that are set but not used.
5641
5642 * xfns.c (make_invisible_cursor): Don't return garbage
5643 if XCreateBitmapFromData fails (Bug#8410).
5644
5645 * xselect.c (x_get_local_selection, x_handle_property_notify):
5646 Remove vars that are set but not used.
5647
5648 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5649 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5650
5651 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5652 Remove var that is set but not used.
5653 (scroll_bar_windows_size): Now size_t, not int.
5654 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5655 Check for overflow.
5656
5657 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5658 (map_tty_color) [!defined MSDOS]: Likewise.
5659
5660 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5661
5662 * coding.c: Remove vars that are set but not used.
5663 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5664 All callers changed.
5665 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5666 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5667 (decode_coding_charset): Remove vars that are set but not used.
5668
5669 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5670 that is set but not used.
5671
5672 * print.c (print_object): Remove var that is set but not used.
5673
5674 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5675 The gnulib version avoids calling malloc in the usual case,
5676 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5677 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5678 * filelock.c (current_lock_owner): Likewise.
5679 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5680 * sysdep.c: Include allocator.h, careadlinkat.h.
5681 (emacs_no_realloc_allocator): New static constant.
5682 (emacs_readlink): New function.
5683 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5684 ../lib/careadlinkat.h.
5685
5686 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5687
5688 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5689 first non-nil return value).
5690
5691 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5692
5693 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5694 if not defined (Bug#8403).
5695
5696 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5697
5698 * xdisp.c (display_count_lines): Remove parameter `start',
5699 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5700 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5701 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5702 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5703 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5704 and thereabouts. All callers changed.
5705 (get_per_char_metric): Remove parameter `f', unused since
5706 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5707
5708 2011-04-02 Jim Meyering <meyering@redhat.com>
5709
5710 do not dereference NULL upon failed strdup
5711 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5712 (ns_get_family): Likewise.
5713
5714 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5715
5716 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5717
5718 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5719
5720 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5721 later (Bug#8403).
5722
5723 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5724
5725 Add lexical binding.
5726
5727 * window.c (Ftemp_output_buffer_show): New fun.
5728 (Fsave_window_excursion):
5729 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5730
5731 * lread.c (lisp_file_lexically_bound_p): New function.
5732 (Fload): Bind Qlexical_binding.
5733 (readevalloop): Remove `evalfun' arg.
5734 Bind Qinternal_interpreter_environment.
5735 (Feval_buffer): Bind Qlexical_binding.
5736 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5737 Mark as dynamic.
5738 (syms_of_lread): Declare `lexical-binding'.
5739
5740 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5741
5742 * keyboard.c (eval_dyn): New fun.
5743 (menu_item_eval_property): Use it.
5744
5745 * image.c (parse_image_spec): Use Ffunctionp.
5746
5747 * fns.c (concat, mapcar1): Accept byte-code-functions.
5748
5749 * eval.c (Fsetq): Handle lexical vars.
5750 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5751 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5752 (FletX, Flet): Obey lexical binding.
5753 (Fcommandp): Handle closures.
5754 (Feval): New `lexical' arg.
5755 (eval_sub): New function extracted from Feval. Use it almost
5756 everywhere where Feval was used. Look up vars in lexical env.
5757 Handle closures.
5758 (Ffunctionp): Move from subr.el.
5759 (Ffuncall): Handle closures.
5760 (apply_lambda): Remove `eval_flags'.
5761 (funcall_lambda): Handle closures and new byte-code-functions.
5762 (Fspecial_variable_p): New function.
5763 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5764 but without exporting it to Lisp.
5765
5766 * doc.c (Fdocumentation, store_function_docstring):
5767 * data.c (Finteractive_form): Handle closures.
5768
5769 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5770 interactive spec.
5771
5772 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5773 New byte-codes.
5774 (exec_byte_code): New function extracted from Fbyte_code to handle new
5775 calling convention for byte-code-functions. Add new byte-codes.
5776
5777 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5778
5779 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5780
5781 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5782
5783 * xdisp.c (redisplay_internal): Fix prototype.
5784
5785 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5786
5787 * xdisp.c (SCROLL_LIMIT): New macro.
5788 (try_scrolling): Use it when setting scroll_limit.
5789 Limit scrolling to 100 screen lines.
5790 (redisplay_window): Even when falling back on "recentering",
5791 position point in the window according to scroll-conservatively,
5792 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5793
5794 (try_scrolling): When point is above the window, allow searching
5795 as far as scroll_max, or one screenful, to compute vertical
5796 distance from PT to the scroll margin position. This prevents
5797 try_scrolling from unnecessarily failing when
5798 scroll-conservatively is set to a value slightly larger than the
5799 window height. Clean up the case of PT below the margin at bottom
5800 of window: scroll_max can no longer be INT_MAX. When aggressive
5801 scrolling is in use, don't let point enter the opposite scroll
5802 margin as result of the scroll.
5803 (syms_of_xdisp) <scroll-conservatively>: Document the
5804 threshold of 100 lines for never-recentering scrolling.
5805
5806 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5807
5808 * dispextern.h (move_it_by_lines):
5809 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5810 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5811 (message_log_check_duplicate): Remove parameters `prev_bol' and
5812 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5813 (redisplay_internal): Remove parameter `preserve_echo_area',
5814 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5815
5816 * indent.c (Fvertical_motion):
5817 * window.c (window_scroll_pixel_based, Frecenter):
5818 Don't pass `need_y_p' to `move_it_by_lines'.
5819
5820 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5821
5822 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5823 steal a few bits to be more compact.
5824 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5825 Remove unneeded casts.
5826
5827 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5828
5829 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5830
5831 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5832 binding" message (bug#7967).
5833
5834 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5835
5836 Fix more problems found by GCC 4.6.0's static checks.
5837
5838 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5839 Remove unused local var.
5840
5841 * editfns.c (Fmessage_box): Remove unused local var.
5842
5843 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5844 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5845 Omit unused local vars.
5846 * window.c (shrink_windows): Omit unused local var.
5847 * menu.c (digest_single_submenu): Omit unused local var.
5848 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5849 Omit unused local var.
5850
5851 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5852 Don't assume string length fits in int.
5853 (keyremap_step, read_key_sequence): Use size_t for sizes.
5854 (read_key_sequence): Don't check last_real_key_start redundantly.
5855
5856 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5857 instead of alloca (Bug#8344).
5858
5859 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5860 (Fbacktrace_frame): Don't assume nframes fits in int.
5861
5862 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5863
5864 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5865 concerns.
5866
5867 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5868
5869 * cm.c (calccost): Turn while-do into do-while, for clarity.
5870
5871 * keyboard.c (syms_of_keyboard): Use the same style as later
5872 in this function when indexing through an array. This also
5873 works around GCC bug 48267.
5874
5875 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5876
5877 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5878
5879 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5880 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5881
5882 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5883 This avoids undefined behavior on integer overflow, and is a bit
5884 more convenient anyway since it is compared to a size_t variable.
5885
5886 Variadic C functions now count arguments with size_t, not int.
5887 This avoids an unnecessary limitation on 64-bit machines, which
5888 caused (substring ...) to crash on large vectors (Bug#8344).
5889 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5890 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5891 All variadic functions and their callers changed accordingly.
5892 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5893 * data.c (arith_driver, float_arith_driver): Likewise.
5894 * editfns.c (general_insert_function): Likewise.
5895 * eval.c (struct backtrace.nargs, interactive_p)
5896 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5897 (funcall_lambda, mark_backtrace): Likewise.
5898 * fns.c (concat): Likewise.
5899 * frame.c (x_set_frame_parameters): Likewise.
5900 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5901 0 if not found, not -1. All callers changed.
5902
5903 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5904 (stack_copy_size): Now size_t, not int.
5905 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5906
5907 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5908
5909 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5910 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5911 All callers changed.
5912
5913 * lisp.h (multibyte_char_to_unibyte):
5914 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5915 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5916 * character.h (CHAR_TO_BYTE8):
5917 * cmds.c (internal_self_insert):
5918 * editfns.c (general_insert_function):
5919 * keymap.c (push_key_description):
5920 * search.c (Freplace_match):
5921 * xdisp.c (message_dolog, set_message_1): All callers changed.
5922
5923 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5924
5925 * keyboard.c (safe_run_hook_funcall): New function.
5926 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5927 don't set the hook to nil, but remove the offending function instead.
5928 (Qcommand_hook_internal): Remove, unused.
5929 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5930 Vcommand_hook_internal.
5931
5932 * eval.c (enum run_hooks_condition): Remove.
5933 (funcall_nil, funcall_not): New functions.
5934 (run_hook_with_args): Call each function through a `funcall' argument.
5935 Remove `cond' argument, now redundant.
5936 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5937 (Frun_hook_with_args_until_failure): Adjust accordingly.
5938 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5939
5940 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5941
5942 * dispextern.h (string_buffer_position): Remove declaration.
5943
5944 * print.c (strout): Remove parameter `multibyte', unused since
5945 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5946
5947 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5948 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5949 All callers changed.
5950
5951 * w32.c (_wsa_errlist): Use braces for struct initializers.
5952
5953 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5954 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5955 All callers changed.
5956 (string_buffer_position): Likewise. Also, make static (it's never
5957 used outside xdisp.c).
5958 (cursor_row_p): Remove parameter `w', unused since
5959 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5960 (decode_mode_spec): Remove parameter `precision', introduced during
5961 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5962 All callers changed.
5963
5964 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5965
5966 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5967
5968 2011-03-27 Anders Lindgren <andlind@gmail.com>
5969
5970 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5971 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5972 (ns_update_auto_hide_menu_bar): New functions.
5973 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5974 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5975 ns_constrain_all_frames.
5976 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5977 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5978
5979 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5980
5981 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5982
5983 2011-03-27 Glenn Morris <rgm@gnu.org>
5984
5985 * syssignal.h: Replace RETSIGTYPE with void.
5986 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5987 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5988 Replace SIGTYPE with void everywhere.
5989 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5990 * s/template.h (SIGTYPE): Remove commented out definition.
5991
5992 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5993
5994 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5995 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5996
5997 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5998
5999 * w32.c (read_unc_volume): Use parameter `henum', instead of
6000 global variable `wget_enum_handle'.
6001
6002 * keymap.c (describe_vector): Remove parameters `indices' and
6003 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6004 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6005
6006 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6007
6008 * keyboard.c (timer_check): Remove parameter `do_it_now',
6009 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6010 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6011 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6012
6013 * keyboard.c (read_char):
6014 * w32menu.c (w32_menu_display_help):
6015 * xmenu.c (show_help_event, menu_help_callback):
6016 Adjust calls to `show_help_echo'.
6017
6018 * gtkutil.c (xg_maybe_add_timer):
6019 * keyboard.c (readable_events):
6020 * process.c (wait_reading_process_output):
6021 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6022
6023 * insdel.c (adjust_markers_gap_motion):
6024 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6025 (gap_left, gap_right): Don't call it.
6026
6027 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6028
6029 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6030 incurred during fontification.
6031
6032 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6033
6034 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6035 (DEFVAR_PER_BUFFER): Don't pass it.
6036
6037 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6038 (scrolling_window): Don't pass it.
6039
6040 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6041
6042 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6043
6044 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6045 and `suffix'.
6046 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6047 of variables specific to SELinux and computation of `encoded_absname'.
6048
6049 * image.c (XPutPixel): Remove unused variable `height'.
6050
6051 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6052
6053 * unexw32.c (get_section_info): Remove unused variable `section'.
6054
6055 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6056 (system_process_attributes): Remove unused variable `sess'.
6057 (sys_read): Remove unused variable `err'.
6058
6059 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6060 (w32_wnd_proc): Remove unused variable `isdead'.
6061 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6062 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6063 (x_create_tip_frame): Remove unused variable `tem'.
6064
6065 * w32inevt.c (w32_console_read_socket):
6066 Remove unused variable `no_events'.
6067
6068 * w32term.c (x_draw_composite_glyph_string_foreground):
6069 Remove unused variable `width'.
6070
6071 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6072
6073 * w32term.c (x_set_glyph_string_clipping):
6074 Don't pass uninitialized region to CombineRgn.
6075
6076 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6077
6078 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6079 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6080 (Fx_close_connection): Remove unused variable `i'.
6081
6082 * w32font.c (w32font_draw): Return number of glyphs.
6083 (w32font_open_internal): Remove unused variable `i'.
6084 (w32font_driver): Add missing initializer.
6085
6086 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6087 (fill_in_menu): Remove unused variable `items_added'.
6088
6089 * w32term.c (last_mouse_press_frame): Remove static global variable.
6090 (w32_clip_to_row): Remove unused variable `f'.
6091 (x_delete_terminal): Remove unused variable `i'.
6092
6093 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6094 (NOTHING): Remove unused static global variable.
6095 (uniscribe_check_otf): Remove unused variable `table'.
6096 (uniscribe_font_driver): Add missing initializers.
6097
6098 2011-03-23 Julien Danjou <julien@danjou.info>
6099
6100 * term.c (Fsuspend_tty, Fresume_tty):
6101 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6102 * window.c (temp_output_buffer_show):
6103 * insdel.c (signal_before_change):
6104 * frame.c (Fhandle_switch_frame):
6105 * fileio.c (Fdo_auto_save):
6106 * emacs.c (Fkill_emacs):
6107 * editfns.c (save_excursion_restore):
6108 * cmds.c (internal_self_insert):
6109 * callint.c (Fcall_interactively):
6110 * buffer.c (Fkill_all_local_variables):
6111 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6112 Use Frun_hooks.
6113 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6114 unconditionnaly since it does the check itself.
6115
6116 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6117
6118 Fix more problems found by GCC 4.5.2's static checks.
6119
6120 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6121 the first time through the loop, since we know p0 < p1 then.
6122 This also avoids a gcc -Wstrict-overflow warning.
6123
6124 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6125 leading to a memory leak, possible in functions like
6126 load_charset_map_from_file that can allocate an unbounded number
6127 of objects (Bug#8318).
6128
6129 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6130 that could (at least in theory) be that large.
6131
6132 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6133 This is less likely to overflow, and avoids undefined behavior if
6134 overflow does occur. All callers changed. Use strtoul to scan
6135 for the unsigned long integer.
6136 (pint2hrstr): Simplify and tune code slightly.
6137 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6138
6139 * scroll.c (do_scrolling): Work around GCC bug 48228.
6140 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6141
6142 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6143 This also avoids a warning with gcc -Wstrict-overflow.
6144 (validate_x_resource_name): Simplify count usage.
6145 This also avoids a warning with gcc -Wstrict-overflow.
6146
6147 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6148 fail (Bug#8306).
6149
6150 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6151
6152 * process.c (Fmake_network_process): Use socklen_t, not int,
6153 where POSIX says socklen_t is required in portable programs.
6154 This fixes a porting bug on hosts like 64-bit HP-UX, where
6155 socklen_t is wider than int (Bug#8277).
6156 (Fmake_network_process, server_accept_connection):
6157 (wait_reading_process_output, read_process_output):
6158 Likewise.
6159
6160 * process.c: Rename or move locals to avoid shadowing.
6161 (list_processes_1, Fmake_network_process):
6162 (read_process_output_error_handler, exec_sentinel_error_handler):
6163 Rename or move locals.
6164 (Fmake_network_process): Define label "retry_connect" only if needed.
6165 (Fnetwork_interface_info): Fix pointer signedness.
6166 (process_send_signal): Add cast to avoid pointer signedness problem.
6167 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6168 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6169
6170 Make tparam.h and terminfo.c consistent.
6171 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6172 Include tparam.h instead, since it declares them.
6173 * cm.h (PC): Remove extern decl; tparam.h now does this.
6174 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6175 * terminfo.c: Include tparam.h, to check interfaces.
6176 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6177 (tparam): Adjust signature to match interface in tparam.h;
6178 this removes some undefined behavior. Check that outstring and len
6179 are zero, which they always are with Emacs.
6180 * tparam.h (PC, BC, UP): New extern decls.
6181
6182 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6183 (xftfont_open): Rename locals to avoid shadowing.
6184
6185 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6186 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6187 (OTF_TAG_SYM): Omit macro if not needed.
6188 (ftfont_list): Remove unused local.
6189 (get_adstyle_property, ftfont_pattern_entity):
6190 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6191 Rename locals to avoid shadowing.
6192
6193 * xfont.c (xfont_list_family): Mark var as initialized.
6194
6195 * xml.c (make_dom): Now static.
6196
6197 * composite.c (composition_compute_stop_pos): Rename local to
6198 avoid shadowing.
6199 (composition_reseat_it): Remove unused locals.
6200 (find_automatic_composition, composition_adjust_point): Likewise.
6201 (composition_update_it): Mark var as initialized.
6202 (find_automatic_composition): Mark vars as initialized,
6203 with a FIXME (Bug#8290).
6204
6205 character.h: Rename locals to avoid shadowing.
6206 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6207 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6208 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6209 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6210 to avoid shadowing.
6211
6212 * textprop.c (property_change_between_p): Remove; unused.
6213
6214 * intervals.c (interval_start_pos): Now static.
6215
6216 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6217
6218 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6219 Rename locals to avoid shadowing.
6220
6221 * sound.c (wav_play, au_play, Fplay_sound_internal):
6222 Fix pointer signedness.
6223 (alsa_choose_format): Remove unused local var.
6224 (wav_play): Initialize a variable to 0, to prevent undefined
6225 behavior (Bug#8278).
6226
6227 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6228
6229 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6230
6231 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6232 clobbering (Bug#8298).
6233 * sysdep.c (sys_subshell): Likewise.
6234 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6235
6236 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6237 This should get cleaned up, so that child_setup has the
6238 same signature on all platforms.
6239
6240 * callproc.c (call_process_cleanup): Now static.
6241 (relocate_fd): Rename locals to avoid shadowing.
6242
6243 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6244
6245 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6246 not to be necessary, and produces flickering.
6247
6248 2011-03-20 Glenn Morris <rgm@gnu.org>
6249
6250 * config.in: Remove file.
6251
6252 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6253
6254 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6255 are now in src/globals.h.
6256 (syms_of_minibuf): Remove spurious & from previous change.
6257
6258 2011-03-20 Leo <sdl.web@gmail.com>
6259
6260 * minibuf.c (completing-read-function): New variable.
6261 (completing-read-default): Rename from completing-read.
6262 (completing-read): Call completing-read-function.
6263
6264 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6265
6266 * xfaces.c (Fx_load_color_file):
6267 Read color file from absolute filename (bug#8250).
6268
6269 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6270
6271 * makefile.w32-in: Update dependencies.
6272
6273 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6274
6275 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6276
6277 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6278
6279 Fix more problems found by GCC 4.5.2's static checks.
6280
6281 * process.c (make_serial_process_unwind, send_process_trap):
6282 (sigchld_handler): Now static.
6283
6284 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6285 That way, the code declares only the vars that it needs.
6286 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6287 * s/cygwin.h (PTY_ITERATION): Likewise.
6288 * s/darwin.h (PTY_ITERATION): Likewise.
6289 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6290
6291 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6292 * process.c (allocate_pty): Don't declare stb unless it's needed.
6293
6294 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6295 (CONSTANTLIM): Remove; unused.
6296 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6297 Define only if needed.
6298
6299 * unexelf.c (unexec): Name an expression,
6300 to avoid gcc -Wbad-function-cast warning.
6301 Use a different way to cause a compilation error if anyone uses
6302 n rather than nn, a way that does not involve shadowing.
6303 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6304
6305 * deps.mk (unexalpha.o): Remove; unused.
6306
6307 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6308 * unexec.h: New file.
6309 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6310 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6311 Depend on unexec.h.
6312 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6313 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6314 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6315 Change as necessary to match prototype in unexec.h.
6316
6317 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6318 shadowing.
6319 (back_comment, skip_chars): Mark vars as initialized.
6320
6321 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6322 Rename locals to avoid shadowing.
6323
6324 * lread.c (read1): Rewrite so as not to use empty "else".
6325 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6326
6327 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6328
6329 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6330 warning when compiling print.c.
6331
6332 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6333 instead of using an uninitialized var.
6334 (font_sort_entities): Mark var as initialized.
6335
6336 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6337
6338 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6339 pointers to constants.
6340 (font_parse_fcname): Remove unused vars.
6341 (font_delete_unmatched): Now static.
6342 (font_get_spec): Remove; unused.
6343 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6344 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6345 Rename or move locals to avoid shadowing.
6346
6347 * fns.c (require_nesting_list, require_unwind): Now static.
6348 (Ffillarray): Rename locals to avoid shadowing.
6349
6350 * floatfns.c (domain_error2): Define only if needed.
6351 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6352
6353 * alloc.c (mark_backtrace): Move decl from here ...
6354 * lisp.h: ... to here, so that it can be checked.
6355
6356 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6357 (Fdefvar): Rewrite so as not to use empty "else".
6358 (lisp_indirect_variable): Name an expression,
6359 to avoid gcc -Wbad-function-cast warning.
6360 (Fdefvar): Rename locals to avoid shadowing.
6361
6362 * callint.c (quotify_arg, quotify_args): Now static.
6363 (Fcall_interactively): Rename locals to avoid shadowing.
6364 Use const pointer when appropriate.
6365
6366 * lisp.h (get_system_name, get_operating_system_release):
6367 Move decls here, to check interfaces.
6368 * process.c (get_operating_system_release): Move decl to lisp.h.
6369 * xrdb.c (get_system_name): Likewise.
6370 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6371 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6372 some of which prompt warnings from gcc -Wbad-function-cast.
6373 (Fformat_time_string, Fencode_time, Finsert_char):
6374 (Ftranslate_region_internal, Fformat):
6375 Rename or remove local vars to avoid shadowing.
6376 (Ftranslate_region_internal): Mark var as initialized.
6377
6378 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6379 avoid shadowing.
6380
6381 * lisp.h (eassert): Check that the argument compiles, even if
6382 ENABLE_CHECKING is not defined.
6383
6384 * data.c (Findirect_variable): Name an expression, to avoid
6385 gcc -Wbad-function-cast warning.
6386 (default_value, arithcompare, arith_driver, arith_error): Now static.
6387 (store_symval_forwarding): Rename local to avoid shadowing.
6388 (Fmake_variable_buffer_local, Fmake_local_variable):
6389 Mark variables as initialized.
6390 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6391
6392 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6393 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6394 Rename locals to avoid shadowing.
6395 (mark_stack): Move local variables into the #ifdef region where
6396 they're used.
6397 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6398 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6399 needed otherwise.
6400 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6401 (GC_STRING_CHARS): Remove; not used.
6402 (Fmemory_limit): Cast sbrk's returned value to char *.
6403
6404 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6405 avoids undefined behavior in theory.
6406
6407 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6408
6409 Use functions, not macros, for up- and down-casing (Bug#8254).
6410 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6411 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6412 to use the following functions instead of these macros.
6413 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6414 EMACS_INT, since callers assume the returned value fits in int.
6415 (upcase1): Likewise, for UPCASE_TABLE.
6416 (uppercasep, lowercasep, upcase): New static inline functions.
6417 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6418 the race-condition problem in the old DOWNCASE.
6419
6420 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6421 Rename locals to avoid shadowing.
6422 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6423 (regex_compile, re_search_2, re_match_2_internal):
6424 Remove unused local vars.
6425 (FREE_VAR): Rewrite so as not to use empty "else",
6426 which gcc can warn about.
6427 (regex_compile, re_match_2_internal): Mark locals as initialized.
6428 (RETALLOC_IF): Define only if needed.
6429 (WORDCHAR_P): Likewise. This one is never needed, but is used
6430 only in a comment talking about a compiler bug, so put inside
6431 the #if 0 of that comment.
6432 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6433 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6434 Remove; unused.
6435
6436 * search.c (boyer_moore): Rename locals to avoid shadowing.
6437 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6438 (PREV_CHAR_BOUNDARY): Likewise.
6439
6440 * search.c (simple_search): Remove unused var.
6441
6442 * dired.c (compile_pattern): Move decl from here ...
6443 * lisp.h: ... to here, so that it can be checked.
6444 (struct re_registers): New forward decl.
6445
6446 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6447
6448 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6449 All uses changed.
6450 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6451 Rename locals to avoid shadowing.
6452 (Fvertical_motion): Mark locals as initialized.
6453
6454 * casefiddle.c (casify_object, casify_region): Now static.
6455 (casify_region): Mark local as initialized.
6456
6457 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6458
6459 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6460 New macros, so that the caller can use some names other than
6461 gcpro1, gcpro2, etc.
6462 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6463 of the new macros.
6464 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6465 argument, for consistency with GCPRO2_VAR, etc: it is now the
6466 prefix of the variable, not the variable itself. All uses
6467 changed.
6468 * dired.c (directory_files_internal, file_name_completion):
6469 Rename locals to avoid shadowing.
6470
6471 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6472 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6473 dired.c's scmp function, had undefined behavior.
6474 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6475 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6476 * buffer.h: ... to here, because these macros use current_buffer,
6477 and the new implementation with inline functions needs to have
6478 current_buffer in scope now, rather than later when the macros
6479 are used.
6480 (downcase, upcase1): New static inline functions.
6481 (DOWNCASE, UPCASE1): Reimplement using these functions.
6482 This avoids undefined behavior in expressions like
6483 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6484 from race conditions in accessing the global variables
6485 case_temp1 and case_temp2.
6486 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6487 * lisp.h (case_temp1, case_temp2): Remove their decls.
6488 * character.h (ASCII_CHAR_P): Move from here ...
6489 * lisp.h: ... to here, so that the inline functions mentioned
6490 above can use them.
6491
6492 * dired.c (directory_files_internal_unwind): Now static.
6493
6494 * fileio.c (file_name_as_directory, directory_file_name):
6495 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6496 Now static.
6497 (file_name_as_directory): Use const pointers when appropriate.
6498 (Fexpand_file_name): Likewise. In particular, newdir might
6499 point at constant storage, so make it a const pointer.
6500 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6501 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6502 signedness issues.
6503 (Fset_file_times, Finsert_file_contents, auto_save_error):
6504 Rename locals to avoid shadowing.
6505
6506 * minibuf.c (choose_minibuf_frame_1): Now static.
6507 (Ftry_completion, Fall_completions): Rename or remove locals
6508 to avoid shadowing.
6509
6510 * marker.c (bytepos_to_charpos): Remove; unused.
6511
6512 * lisp.h (verify_bytepos, count_markers): New decls,
6513 so that gcc does not warn that these functions aren't declared.
6514
6515 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6516 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6517 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6518 (copy_text): Remove unused local var.
6519
6520 * filelock.c (within_one_second): Now static.
6521 (lock_file_1): Rename local to avoid shadowing.
6522
6523 * buffer.c (fix_overlays_before): Mark locals as initialized.
6524 (fix_start_end_in_overlays): Likewise. This function should be
6525 simplified by using pointers-to-pointers, but that's a different
6526 matter.
6527 (switch_to_buffer_1): Now static.
6528 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6529 (report_overlay_modification): Rename locals to avoid shadowing.
6530
6531 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6532 Fix pointer signedness issue.
6533 (sys_subshell): Mark local as volatile if checking for lint,
6534 to suppress a gcc -Wclobbered warning that does not seem to be right.
6535 (MAXPATHLEN): Define only if needed.
6536
6537 * process.c (serial_open, serial_configure): Move decls from here ...
6538 * systty.h: ... to here, so that they can be checked.
6539
6540 * fns.c (get_random, seed_random): Move extern decls from here ...
6541 * lisp.h: ... to here, so that they can be checked.
6542
6543 * sysdep.c (reset_io): Now static.
6544 (wait_for_termination_signal): Remove; unused.
6545
6546 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6547 (copy_keymap_item, append_key, push_text_char_description):
6548 Now static.
6549 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6550 (DENSE_TABLE_SIZE): Remove; unused.
6551 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6552 (describe_map_tree):
6553 Rename locals to avoid shadowing.
6554
6555 * keyboard.c: Declare functions static if they are not used elsewhere.
6556 (echo_char, echo_dash, cmd_error, top_level_2):
6557 (poll_for_input, handle_async_input): Now static.
6558 (read_char, kbd_buffer_get_event, make_lispy_position):
6559 (make_lispy_event, make_lispy_movement, apply_modifiers):
6560 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6561 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6562 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6563 (read_key_sequence, read_char): Mark locals as initialized.
6564 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6565
6566 * keyboard.h (make_ctrl_char): New decl.
6567 (mark_kboards): Move decl here ...
6568 * alloc.c (mark_kboards): ... from here.
6569
6570 * lisp.h (force_auto_save_soon): New decl.
6571
6572 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6573 (DEFINE_DUMMY_FUNCTION): New macro.
6574 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6575 Use it.
6576 (main): Add casts to avoid warnings
6577 if GCC considers string literals to be constants.
6578
6579 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6580
6581 * dbusbind.c: Pointer signedness fixes.
6582 (xd_signature, xd_append_arg, xd_initialize):
6583 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6584 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6585 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6586 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6587
6588 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6589 if GCC considers string literals to be constants.
6590 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6591
6592 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6593
6594 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6595 (print_preprocess, print_object): New macro to fix last change.
6596
6597 * print.c (print_preprocess): Don't forget font objects.
6598
6599 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6600
6601 * emacs.c (USAGE3): Doc fixes.
6602
6603 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6604
6605 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6606 structure.
6607
6608 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6609
6610 * lisp.h (VWindow_system, Qfile_name_history):
6611 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6612 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6613 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6614
6615 * w32select.c: Don't #include "keyboard.h".
6616 (run_protected): Add extern declaration for waiting_for_input.
6617
6618 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6619 * w32console.c (detect_input_pending, read_input_pending)
6620 (encode_terminal_code):
6621 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6622 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6623 (w32_system_caret_y, Qfile_name_history):
6624 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6625 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6626 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6627 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6628 * w32proc.c (Qlocal, report_file_error):
6629 * w32term.c (Vwindow_system, updating_frame):
6630 * w32uniscribe.c (initialized, uniscribe_font_driver):
6631 Remove unneeded extern declarations.
6632
6633 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6634
6635 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6636
6637 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6638
6639 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6640 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6641 These macros can no longer be used for assignment.
6642
6643 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6644 Assign struct members directly, instead of using BUF_BEGV etc.
6645 (record_buffer_markers, fetch_buffer_markers): New functions for
6646 recording and fetching special buffer markers.
6647 (set_buffer_internal_1, set_buffer_temp): Use them.
6648
6649 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6650
6651 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6652
6653 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6654 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6655
6656 * xdisp.c (hscroll_window_tree):
6657 (reconsider_clip_changes): Use PT instead of BUF_PT.
6658
6659 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6660
6661 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6662 $(EMACS_ROOT)/lib/intprops.h.
6663
6664 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6665
6666 Fix more problems found by GCC 4.5.2's static checks.
6667
6668 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6669 to unsigned char * to avoid compiler diagnostic.
6670 (xg_free_frame_widgets): Make it clear that a local variable is
6671 needed only if USE_GTK_TOOLTIP.
6672 (gdk_window_get_screen): Make it clear that this macro is needed
6673 only if USE_GTK_TOOLTIP.
6674 (int_gtk_range_get_value): New function, which avoids a diagnostic
6675 from gcc -Wbad-function-cast.
6676 (xg_set_toolkit_scroll_bar_thumb): Use it.
6677 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6678 diagnostic from gcc -Wbad-function-cast.
6679 (get_utf8_string, xg_get_file_with_chooser):
6680 Rename locals to avoid shadowing.
6681 (create_dialog): Move locals to avoid shadowing.
6682
6683 * xgselect.c (xg_select): Remove unused var.
6684
6685 * image.c (four_corners_best): Mark locals as initialized.
6686 (gif_load): Initialize transparent_p to zero (Bug#8238).
6687 Mark another local as initialized.
6688 (my_png_error, my_error_exit): Mark with NO_RETURN.
6689
6690 * image.c (clear_image_cache): Now static.
6691 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6692 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6693 (x_edge_detection): Remove unnecessary cast that
6694 gcc -Wbad-function-cast diagnoses.
6695 (gif_load): Fix pointer signedness.
6696 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6697 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6698
6699 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6700
6701 Improve quality of tests for time stamp overflow.
6702 For example, without this patch (encode-time 0 0 0 1 1
6703 1152921504606846976) returns the obviously-bogus value (-948597
6704 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6705 reports time overflow. See
6706 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6707 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6708 * editfns.c: Include limits.h and intprops.h.
6709 (TIME_T_MIN, TIME_T_MAX): New macros.
6710 (time_overflow): Move earlier, to before first use.
6711 (hi_time, lo_time): New functions, for an accurate test for
6712 out-of-range times.
6713 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6714 (Fget_internal_run_time): Don't assume time_t fits in int.
6715 (make_time): Use list2 instead of Fcons twice.
6716 (Fdecode_time): More accurate test for out-of-range times.
6717 (check_tm_member): New function.
6718 (Fencode_time): Use it, to test for out-of-range times.
6719 (lisp_time_argument): Don't rely on undefined left-shift and
6720 right-shift behavior when checking for time stamp overflow.
6721
6722 * editfns.c (time_overflow): New function, refactoring common code.
6723 (Fformat_time_string, Fdecode_time, Fencode_time):
6724 (Fcurrent_time_string): Use it.
6725
6726 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6727 * dired.c (make_time): Move to ...
6728 * editfns.c (make_time): ... here.
6729 * systime.h: Note the move.
6730
6731 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6732
6733 * fringe.c (update_window_fringes): Remove unused variables.
6734
6735 * unexmacosx.c (copy_data_segment): Also copy __got section.
6736 (Bug#8223)
6737
6738 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6739
6740 * termcap.c [MSDOS]: Include "msdos.h".
6741 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6742 Constify `char *' arguments and their references according to
6743 prototypes in tparam.h.
6744
6745 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6746
6747 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6748 Adapt all references accordingly.
6749
6750 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6751
6752 2011-03-11 Tom Tromey <tromey@redhat.com>
6753
6754 * buffer.c (syms_of_buffer): Remove obsolete comment.
6755
6756 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6757
6758 * termhooks.h (encode_terminal_code): Declare prototype.
6759
6760 * msdos.c (encode_terminal_code): Don't declare prototype.
6761
6762 * term.c (encode_terminal_code): Now external again, used by
6763 w32console.c and msdos.c.
6764
6765 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6766 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6767
6768 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6769
6770 Fix some minor problems found by GCC 4.5.2's static checks.
6771
6772 * fringe.c (update_window_fringes): Mark locals as initialized
6773 (Bug#8227).
6774 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6775
6776 * alloc.c (mark_fringe_data): Move decl from here ...
6777 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6778 to check its interface.
6779 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6780
6781 * fontset.c (free_realized_fontset): Now static.
6782 (Fset_fontset_font): Rename local to avoid shadowing.
6783 (fontset_font): Mark local as initialized.
6784 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6785
6786 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6787
6788 * xselect.c (x_disown_buffer_selections): Remove; not used.
6789 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6790 (x_own_selection, Fx_disown_selection_internal): Rename locals
6791 to avoid shadowing.
6792 (x_handle_dnd_message): Remove local to avoid shadowing.
6793
6794 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6795 so that the caller can use some name other than gcpro1.
6796 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6797 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6798 (Fx_backspace_delete_keys_p):
6799 Use them to avoid shadowing, and rename vars to avoid shadowing.
6800 (x_decode_color, x_set_name, x_window): Now static.
6801 (Fx_create_frame): Add braces to silence GCC warning.
6802 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6803 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6804 Remove unused locals.
6805 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6806 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6807 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6808 macros.
6809
6810 * xterm.h (x_mouse_leave): New decl.
6811
6812 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6813 Remove unused functions.
6814 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6815 (x_calc_absolute_position): Now static.
6816 (XTread_socket): Don't define label "out" unless it's used.
6817 Don't declare local "event" unless it's used.
6818 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6819 unless they are used.
6820 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6821 (x_fatal_error_signal): Remove; not used.
6822 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6823 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6824 (x_error_catcher, x_connection_closed, x_error_handler):
6825 (x_error_quitter, xembed_send_message, x_iconify_frame):
6826 (my_log_handler): Rename locals to avoid shadowing.
6827 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6828 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6829
6830 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6831 Rename or move locals to avoid shadowing.
6832 (tty_defined_color, merge_face_heights): Now static.
6833 (free_realized_faces_for_fontset): Remove; not used.
6834 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6835 does not deduce is never used uninitialized.
6836 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6837 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6838
6839 * terminal.c (store_terminal_param): Now static.
6840
6841 * xmenu.c (menu_highlight_callback): Now static.
6842 (set_frame_menubar): Remove unused local.
6843 (xmenu_show): Rename parameter to avoid shadowing.
6844 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6845 since they might point to immutable storage.
6846 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6847 since it's unused otherwise.
6848
6849 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6850 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6851 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6852 avoids a gcc -Wuninitialized diagnostic.
6853 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6854 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6855 does not deduce are never used uninitialized.
6856
6857 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6858
6859 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6860 * window.c (window_loop, size_window):
6861 (run_window_configuration_change_hook, enlarge_window): Likewise.
6862
6863 * window.c (display_buffer): Now static.
6864 (size_window): Mark variables that gcc -Wuninitialized
6865 does not deduce are never used uninitialized.
6866 * window.h (check_all_windows): New decl, to forestall
6867 gcc -Wmissing-prototypes diagnostic.
6868 * dispextern.h (bidi_dump_cached_states): Likewise.
6869
6870 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6871 shadowing.
6872 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6873 Include <limits.h>.
6874 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6875 and to avoid gcc -Wuninitialized warning.
6876 (load_charset_map): Mark variables that gcc -Wuninitialized
6877 does not deduce are never used uninitialized.
6878 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6879
6880 * coding.c (coding_set_source, coding_set_destination):
6881 Use "else { /* comment */ }" rather than "else /* comment */;"
6882 for clarity, and to avoid gcc -Wempty-body warning.
6883 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6884 a block, when the outer 'i' will do.
6885 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6886 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6887 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6888 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6889 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6890 Rename locals to avoid shadowing.
6891 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6892 * coding.c (emacs_mule_char, encode_invocation_designation):
6893 Now static, since they're not used elsewhere.
6894 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6895 (decode_coding_object, encode_coding_object, detect_coding_system):
6896 (decode_coding_emacs_mule): Mark variables that gcc
6897 -Wuninitialized does not deduce are never used uninitialized.
6898 (detect_coding_iso_2022): Initialize a local variable that might
6899 be used uninitialized. Leave a FIXME because it's not clear that
6900 this initialization is needed. (Bug#8211)
6901 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6902 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6903 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6904 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6905 Remove unused macros.
6906
6907 * category.c (hash_get_category_set): Remove unused local var.
6908 (copy_category_table): Now static, since it's not used elsewhere.
6909 * character.c (string_count_byte8): Likewise.
6910
6911 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6912 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6913
6914 * chartab.c (copy_sub_char_table): Now static, since it's not used
6915 elsewhere.
6916 (sub_char_table_ref_and_range, char_table_ref_and_range):
6917 Rename locals to avoid shadowing.
6918 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6919
6920 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6921 (BIDI_BOB): Remove unused macro.
6922
6923 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6924 deduce are never used uninitialized.
6925 * term.c (encode_terminal_code): Likewise.
6926
6927 * term.c (encode_terminal_code): Now static. Remove unused local.
6928
6929 * tparam.h: New file.
6930 * term.c, tparam.h: Include it.
6931 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6932 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6933 Move these decls to tparam.h, and make them agree with what
6934 is actually in tparam.c. The previous trick of using incompatible
6935 decls in different modules does not conform to the C standard.
6936 All callers of tparam changed to use tparam's actual API.
6937 * tparam.c (tparam1, tparam, tgoto):
6938 Use const pointers where appropriate.
6939
6940 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6941 * cm.h (struct cm): Likewise.
6942 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6943 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6944 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6945 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6946 (turn_on_face, init_tty): Likewise.
6947 * termchar.h (struct tty_display_info): Likewise.
6948
6949 * term.c (term_mouse_position): Rename local to avoid shadowing.
6950
6951 * alloc.c (mark_ttys): Move decl from here ...
6952 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6953
6954 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6955
6956 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6957
6958 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6959
6960 * search.c (compile_pattern_1): Remove argument regp, unused since
6961 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6962 (compile_pattern): Don't pass it.
6963
6964 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6965
6966 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6967 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6968 for ! HAVE_GTK3.
6969 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6970
6971 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6972
6973 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6974 gdk_window_get_screen, gdk_window_get_geometry,
6975 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6976 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6977 (xg_get_pixbuf_from_pixmap): New function.
6978 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6979 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6980 Call xg_get_pixbuf_from_pixmap instead of
6981 gdk_pixbuf_get_from_drawable.
6982 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6983 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6984 (xg_check_special_colors): Use GtkStyleContext and its functions
6985 for HAVE_GTK3.
6986 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6987 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6988 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6989 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6990 Call gtk_widget_get_preferred_size.
6991 (xg_frame_resized): gdk_window_get_geometry only takes 5
6992 parameters.
6993 (xg_win_to_widget, xg_event_is_for_menubar):
6994 Call gdk_x11_window_lookup_for_display.
6995 (xg_set_widget_bg): New function.
6996 (delete_cb): New function.
6997 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6998 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6999 (xg_set_background_color): Call xg_set_widget_bg.
7000 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7001 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7002 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7003 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7004 if ! HAVE_GTK3.
7005 (update_frame_tool_bar): Call gtk_widget_hide.
7006 (xg_initialize): Use GDK_KEY_g.
7007
7008 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7009 if ! HAVE_GTK3
7010 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7011
7012 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7013 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7014 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7015
7016 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7017
7018 * w32xfns.c (select_palette): Check success of RealizePalette against
7019 GDI_ERROR, not zero.
7020
7021 See ChangeLog.11 for earlier changes.
7022
7023 ;; Local Variables:
7024 ;; coding: utf-8
7025 ;; End:
7026
7027 Copyright (C) 2011 Free Software Foundation, Inc.
7028
7029 This file is part of GNU Emacs.
7030
7031 GNU Emacs is free software: you can redistribute it and/or modify
7032 it under the terms of the GNU General Public License as published by
7033 the Free Software Foundation, either version 3 of the License, or
7034 (at your option) any later version.
7035
7036 GNU Emacs is distributed in the hope that it will be useful,
7037 but WITHOUT ANY WARRANTY; without even the implied warranty of
7038 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7039 GNU General Public License for more details.
7040
7041 You should have received a copy of the GNU General Public License
7042 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.