1 2012-03-12 Chong Yidong <cyd@gnu.org>
3 * eval.c (inhibit_lisp_code): Rename from
4 inhibit_window_configuration_change_hook; move from window.c.
6 * xfns.c (unwind_create_frame_1, Fx_create_frame):
7 * window.c (run_window_configuration_change_hook)
8 (syms_of_window): Callers changed.
10 2012-03-11 Chong Yidong <cyd@gnu.org>
12 * keymap.c (Fkey_description): Doc fix (Bug#9700).
14 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
16 2012-03-10 Chong Yidong <cyd@gnu.org>
18 * frame.c (other_visible_frames): Don't assume the selected frame
19 is visible (Bug#10955).
21 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
23 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
25 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
27 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
28 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
31 2012-03-03 Glenn Morris <rgm@gnu.org>
33 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
35 2012-03-02 Eli Zaretskii <eliz@gnu.org>
37 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
38 position past the first glyph_row that ends at ZV. (Bug#10902)
39 (redisplay_window, next_element_from_string): Fix typos in
41 (redisplay_window): Pass to move_it_vertically the margin in
42 pixels, not in screen lines.
44 2012-03-02 Glenn Morris <rgm@gnu.org>
46 * buffer.c (buffer-list-update-hook): Doc fix.
48 2012-02-29 Eli Zaretskii <eliz@gnu.org>
50 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
51 push_it before setting up the iterator for the first overlay
52 string, even if we have an empty string loaded.
53 (next_overlay_string): If there's an empty string on the iterator
54 stack, pop the stack. (Bug#10903)
56 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
58 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
59 Suggested by Stefan Monnier in
60 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
61 * alloc.c (widen_to_Lisp_Object): New static function.
62 (mark_memory): Also mark Lisp_Objects by fetching pointer words
63 and widening them to Lisp_Objects. This would work even if
64 USE_LSB_TAG is defined and wide integers are used, which might
65 happen in a future version of Emacs.
67 2012-02-25 Chong Yidong <cyd@gnu.org>
69 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
72 * xselect.c (Fx_selection_exists_p): Doc fix.
73 (x_clipboard_manager_save_all): Print an informative message
74 before saving to clipboard manager.
76 2012-02-24 Chong Yidong <cyd@gnu.org>
78 * keyboard.c (process_special_events): Handle all X selection
79 requests in kbd_buffer, not just the next one (Bug#8869).
81 2012-02-23 Chong Yidong <cyd@gnu.org>
83 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
84 call when setting menu-bar-lines and tool-bar-lines parameters.
85 (unwind_create_frame_1): New helper function.
87 * window.c (inhibit_window_configuration_change_hook): New var.
88 (run_window_configuration_change_hook): Obey it.
89 (syms_of_window): Initialize it.
91 2012-02-22 Chong Yidong <cyd@gnu.org>
93 * xterm.c (x_draw_image_relief): Add missing type check for
94 Vtool_bar_button_margin (Bug#10743).
96 2012-02-21 Chong Yidong <cyd@gnu.org>
98 * fileio.c (Vfile_name_handler_alist): Doc fix.
100 * buffer.c (Fget_file_buffer): Protect against invalid file
101 handler return value.
103 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
105 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
106 when computing $valmask.
108 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
109 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
110 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
111 It's useless in that case, and it can cause problems on hosts
112 that allocate halves of EMACS_INT values separately.
113 Reported by Dan Horák. Diagnosed by Andreas Schwab in
114 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
115 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
116 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
117 it avoids undefined behavior on hosts where shifting right by more
118 than the word width has undefined behavior.
120 2012-02-19 Chong Yidong <cyd@gnu.org>
122 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
123 (Funhandled_file_name_directory, Ffile_name_as_directory)
124 (Fdirectory_file_name, Fexpand_file_name)
125 (Fsubstitute_in_file_name): Protect against invalid file handler
126 return values (Bug#10845).
128 2012-02-18 Eli Zaretskii <eliz@gnu.org>
130 * .gdbinit (pitx): Fix incorrect references to fields of the
133 2012-02-17 Chong Yidong <cyd@gnu.org>
135 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
137 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
139 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
140 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
142 2012-02-15 Chong Yidong <cyd@gnu.org>
144 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
145 marked as special. Also, starting docstrings with * is obsolete.
147 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
149 * gnutls.c (emacs_gnutls_write): Fix last change.
151 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
153 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
156 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
158 * keymap.c (Fsingle_key_description): Handle char ranges.
160 2012-02-12 Chong Yidong <cyd@gnu.org>
162 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
163 as that creates a dangerous corner case.
165 * window.c (Fdelete_window_internal): Invalidate the mouse
166 highlight (Bug#9904).
168 2012-02-12 Glenn Morris <rgm@gnu.org>
170 * xselect.c (Fx_own_selection_internal)
171 (Fx_get_selection_internal, Fx_disown_selection_internal)
172 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
173 * nsselect.m (Fx_own_selection_internal)
174 (Fx_disown_selection_internal, Fx_selection_exists_p)
175 (Fx_selection_owner_p, Fx_get_selection_internal):
176 Sync docs and argument specs with the xselect.c versions.
178 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
180 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
182 2012-02-11 Eli Zaretskii <eliz@gnu.org>
184 * w32select.c (Fx_selection_exists_p): Sync doc string and
185 argument list with xselect.c. (Bug#10783)
187 * w16select.c (Fx_selection_exists_p): Sync doc string and
188 argument list with xselect.c. (Bug#10783)
190 2012-02-10 Glenn Morris <rgm@gnu.org>
192 * fns.c (Fsecure_hash): Doc fix.
194 2012-02-09 Kenichi Handa <handa@m17n.org>
196 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
198 2012-02-07 Chong Yidong <cyd@gnu.org>
200 * buffer.c (Fbuffer_local_variables)
201 (buffer_lisp_local_variables): Handle unbound vars correctly;
202 don't let Qunbound leak into Lisp.
204 2012-02-07 Glenn Morris <rgm@gnu.org>
206 * image.c (Fimagemagick_types): Doc fix.
208 * image.c (imagemagick-render-type): Change it from a lisp object
209 to an integer. Move the doc here from the lisp manual.
210 Treat all values not equal to 0 the same.
212 2012-02-06 Chong Yidong <cyd@gnu.org>
214 * doc.c (store_function_docstring): Avoid applying docstring of
215 alias to base function (Bug#2603).
217 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
219 * .gdbinit (pp1, pv1): Remove redundant defines.
222 2012-02-04 Chong Yidong <cyd@gnu.org>
224 * nsterm.m: Declare a global (Bug#10694).
226 2012-02-04 Eli Zaretskii <eliz@gnu.org>
228 * w32.c (get_emacs_configuration_options):
229 Include --enable-checking, if specified, in the return value.
231 2012-02-04 Martin Rudalics <rudalics@gmx.at>
233 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
234 after rounding frame sizes. (Bug#9723)
236 2012-02-04 Eli Zaretskii <eliz@gnu.org>
238 * keyboard.c (adjust_point_for_property): Don't position point
239 before BEGV. (Bug#10696)
241 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
243 Handle overflow when computing char display width (Bug#9496).
244 * character.c (char_width): Return EMACS_INT, not int.
245 (char_width, c_string_width): Check for overflow when
246 computing the width; this is possible now that individual
247 characters can have unbounded width. Problem introduced
248 by merge from Emacs 23 on 2012-01-19.
250 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
252 * dbusbind.c (Fdbus_register_method): Mention the return value
253 :ignore in the docstring.
255 2012-02-02 Glenn Morris <rgm@gnu.org>
257 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
259 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
260 Unconditionally set to t. (Bug#10673)
261 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
262 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
263 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
265 2012-02-02 Kenichi Handa <handa@m17n.org>
267 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
268 0, do not call append_composite_glyph.
270 2012-02-02 Kenichi Handa <handa@m17n.org>
272 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
274 (x_produce_glyphs): If the component of a composition is a null
275 string, set it->pixel_width to 1 to avoid zero-width glyph.
277 2012-02-01 Eli Zaretskii <eliz@gnu.org>
279 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
280 first 2 arguments are identical. This makes inserting large
281 output from a subprocess an order of magnitude faster on
282 MS-Windows, where all sbrk'ed memory is always contiguous.
284 2012-01-31 Glenn Morris <rgm@gnu.org>
286 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
287 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
288 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
290 2012-01-29 Glenn Morris <rgm@gnu.org>
292 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
294 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
296 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
298 2012-01-28 Chong Yidong <cyd@gnu.org>
300 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
302 2012-01-26 Chong Yidong <cyd@gnu.org>
304 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
306 * search.c (Fsearch_forward, Fsearch_backward): Document negative
307 repeat counts (Bug#10507).
309 2012-01-26 Glenn Morris <rgm@gnu.org>
311 * lread.c (syms_of_lread): Doc fix.
313 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
315 * coding.c (encode_designation_at_bol): Change return value to
318 2012-01-25 Chong Yidong <cyd@gnu.org>
320 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
322 2012-01-21 Chong Yidong <cyd@gnu.org>
324 * floatfns.c (Fcopysign): Make the second argument non-optional,
325 since nil is not allowed anyway.
327 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
329 * process.c (read_process_output): Use p instead of XPROCESS (proc).
330 (send_process): Likewise.
332 2012-01-19 Martin Rudalics <rudalics@gmx.at>
334 * window.c (save_window_save, Fcurrent_window_configuration)
335 (Vwindow_persistent_parameters): Do not use Qstate.
338 2012-01-19 Kenichi Handa <handa@m17n.org>
340 * character.c (char_width): New function.
341 (Fchar_width, c_string_width, lisp_string_width):
342 Use char_width (Bug#9496).
344 2012-01-16 Martin Rudalics <rudalics@gmx.at>
346 * window.c (Vwindow_persistent_parameters): New variable.
347 (Fset_window_configuration, save_window_save): Handle persistent
350 2012-01-14 Eli Zaretskii <eliz@gnu.org>
352 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
353 thrashing the stack of the thread. (Bug#9087)
355 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
357 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
359 2012-01-11 Eli Zaretskii <eliz@gnu.org>
361 * xdisp.c (rows_from_pos_range): Handle the case where the
362 highlight ends on a newline. (Bug#10464)
363 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
364 he end column for display of highlight that ends on a newline
367 2012-01-11 Glenn Morris <rgm@gnu.org>
369 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
370 from load-path also when installation-directory is nil. (Bug#10208)
372 2012-01-10 Glenn Morris <rgm@gnu.org>
374 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
376 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
377 Update template values to be closer to their typical values these days.
379 2012-01-09 Eli Zaretskii <eliz@gnu.org>
381 * xdisp.c (rows_from_pos_range): Accept additional argument
382 DISP_STRING, and accept any glyph in a row whose object is that
383 string as eligible for mouse highlight. Fixes mouse highlight of
384 display strings from overlays. (Bug#10464)
386 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
388 emacs: fix an auto-save permissions race condition (Bug#10400)
389 * fileio.c (auto_saving_dir_umask): New static var.
390 (Fmake_directory_internal): Use it.
391 (do_auto_save_make_dir): Set it, instead of invoking chmod after
392 creating the directory. The old code temporarily assigns
393 too-generous permissions to the directory.
394 (do_auto_save_eh): Clear it.
395 (Fdo_auto_save): Catch all errors, not just file errors, so
396 that the var is always cleared.
398 2012-01-07 Eli Zaretskii <eliz@gnu.org>
400 * search.c (scan_buffer): Pass character positions to
401 know_region_cache, not byte positions. (Bug#6540)
403 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
405 * w32.c (sys_rename): Report EXDEV when rename of a directory
406 fails because the target is on another logical disk. (Bug#10284)
408 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
410 * xterm.c (x_embed_request_focus): New function.
412 * xterm.h: Add prototype.
414 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
416 2012-01-05 Glenn Morris <rgm@gnu.org>
418 * emacs.c (emacs_copyright): Update short copyright year to 2012.
420 2012-01-01 Eli Zaretskii <eliz@gnu.org>
422 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
423 Load gnutls_transport_set_lowat only if GnuTLS version is below
425 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
426 GnuTLS versions below 2.11.1.
428 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
430 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
431 to the doc string advising against its use for altering the way
432 windows are scrolled.
434 2011-12-28 Kenichi Handa <handa@m17n.org>
436 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
437 coding-system ASCII compatible only when it does not produce BOM
438 on encoding (Bug#10383).
440 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
442 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
444 (create_and_show_popup_menu): Always use menu_position_func for
447 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
449 * callint.c (Fcall_interactively): Don't truncate prompt string.
451 2011-12-23 Eli Zaretskii <eliz@gnu.org>
453 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
454 property that ends at ZV, so that the bidi iteration could be
455 resumed from there (after widening). (Bug#10360)
457 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
459 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
461 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
463 * nsterm.m (x_free_frame_resources):
464 Release f->output_data.ns->miniimage.
465 (ns_index_color): Fix indentation. Do not retain
466 color_table->colors[i].
468 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
471 * nsfns.m (x_set_background_color): Assign return value from
472 ns_index_color to face-background instead of NSColor*.
473 (ns_implicitly_set_icon_type): Fix indentation.
474 Change assignment in for loop to comparison.
476 * emacs.c (ns_pool): New variable.
477 (main): Assign ns_pool.
478 (Fkill_emacs): Call ns_release_autorelease_pool.
480 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
481 autorelease fdesc, release fdAttrs and tdict.
482 (ns_get_covering_families): Release charset.
483 (ns_findfonts): Release NSFontDescriptor created with new.
484 (ns_uni_to_glyphs): Fix indentation.
485 (setString): Release attrStr before assigning new value.
487 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
489 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
491 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
492 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
494 2011-12-18 David Reitter <reitter@cmu.edu>
496 * nsterm.m (ns_term_init): Subscribe for notifications
497 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
498 to method trackingNotification in EmacsMenu.
500 * nsmenu.m (trackingMenu): New variable.
501 (trackingNotification): New method (from Aquamacs).
502 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
503 from Aquamacs (Bug#7030).
505 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
507 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
508 (symbol_to_nsstring): Fix indentation.
509 (ns_symbol_to_pb): New function.
510 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
511 (Fns_rotate_cut_buffers_internal): Remove.
512 (Fns_store_selection_internal): Rename from
513 Fns_store_cut_buffer_internal.
514 (ns_get_foreign_selection, Fx_own_selection_internal)
515 (Fx_disown_selection_internal, Fx_selection_exists_p)
516 (Fns_get_selection_internal, Fns_store_selection_internal):
517 Use ns_symbol_to_pb and check if return value is nil.
518 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
519 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
520 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
521 renamed to Sns_store_selection_internal.
522 (ns_handle_selection_request): Move code to Fx_own_selection_internal
523 and remove this function.
524 (ns_handle_selection_clear): Remove, never used.
525 (Fx_own_selection_internal): Move code from ns_handle_selection_request
528 2011-12-17 Ken Brown <kbrown@cornell.edu>
530 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
531 GID is unknown (Bug#10257).
533 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
535 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
536 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
537 which caused a build failure on GNU/Linux IA-64. This problem was
538 introduced by my 2011-10-07 patch.
540 2011-12-15 Juri Linkov <juri@jurta.org>
542 * image.c (imagemagick_error): New function. (Bug#10112)
543 (imagemagick_load_image): Comment out `MagickSetResolution' call.
544 Use `imagemagick_error' where ImageMagick functions return
546 (Fimagemagick_types): Add `Fnreverse' to return the list in the
549 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
551 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
552 fill background (Bug#8992).
554 2011-12-13 Martin Rudalics <rudalics@gmx.at>
556 * window.c (Vwindow_combination_resize)
557 (Vwindow_combination_limit): Use t instead of non-nil in
559 (Vrecenter_redisplay): Add first sentence of doc-string on
561 (Frecenter): Fix doc-string typo.
563 2011-12-11 Kenichi Handa <handa@m17n.org>
565 * coding.c (Funencodable_char_position): Pay attention to the
566 buffer text relocation (Bug#9389).
568 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
570 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
571 gtk_init (Bug#10100).
573 2011-12-10 Eli Zaretskii <eliz@gnu.org>
575 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
576 IT->string is nil. (Bug#10263)
578 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
580 * nsterm.h (x_free_frame_resources): Declare.
582 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
583 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
585 * nsterm.h (ns_get_defaults_value): Declare.
587 * nsterm.m (ns_default): Call ns_get_defaults_value.
589 2011-12-09 Eli Zaretskii <eliz@gnu.org>
591 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
594 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
596 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
597 that where the value of an _OBJC_* symbol points to is in the .bss
600 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
602 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
603 after the loop to call ccl_driver at least once (Bug#8619).
605 2011-12-08 Kenichi Handa <handa@m17n.org>
607 * ftfont.c (get_adstyle_property): Fix previous change
610 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
612 * w32.c (init_environment): If no_site_lisp, remove site-lisp
613 dirs from the default value of EMACSLOADPATH (bug#10208).
615 2011-12-07 Glenn Morris <rgm@gnu.org>
617 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
618 installation and source directories as well. (Bug#10208)
620 2011-12-06 Chong Yidong <cyd@gnu.org>
622 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
624 2011-12-06 Glenn Morris <rgm@gnu.org>
626 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
627 as an error, not just -1. (Bug#10217)
629 2011-12-05 Chong Yidong <cyd@gnu.org>
631 * keyboard.c (process_special_events): New function.
632 (swallow_events, Finput_pending_p): Use it (Bug#10195).
634 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
636 * coding.c (encode_designation_at_bol): Don't use uninitialized
637 local variable (Bug#9318).
639 2011-12-05 Kenichi Handa <handa@m17n.org>
641 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
642 return Qnil (Bug#8046, Bug#10193).
644 2011-12-05 Kenichi Handa <handa@m17n.org>
646 * coding.c (encode_designation_at_bol): New args charbuf_end and
647 dst. Return the number of produced bytes. Callers changed.
648 (coding_set_source): Return how many bytes coding->source was
650 (coding_set_destination): Return how many bytes
651 coding->destination was relocated.
652 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
653 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
655 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
657 * coding.c (CODING_CHAR_CHARSET_P): New macro.
658 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
661 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
663 The following changes are to fix Bug#9318.
665 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
666 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
667 (encode_coding_iso_2022, encode_coding_sjis)
668 (encode_coding_big5, encode_coding_charset): Use the above macros.
670 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
672 * lisp.h (process_quit_flag): Fix external declaration.
674 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
676 Don't macro-inline non-performance-critical code.
677 * eval.c (process_quit_flag): New function.
678 * lisp.h (QUIT): Use it.
680 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
682 * nsfns.m (get_geometry_from_preferences): New function.
683 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
685 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
687 * emacs.c (Qkill_emacs): Define.
688 (syms_of_emacs): Initialize it.
689 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
690 Qquit_flag to `kill-emacs' instead.
691 (quit_throw_to_read_char): Add parameter `from_signal'.
692 All callers changed. Call Fkill_emacs if requested and safe.
693 * lisp.h (QUIT): Call Fkill_emacs if requested.
695 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
697 * widget.c (update_wm_hints): Return if wmshell is null.
698 (widget_update_wm_size_hints): New function.
700 * widget.h (widget_update_wm_size_hints): Declare.
702 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
703 widget_update_wm_size_hints (Bug#10104).
705 2011-12-03 Eli Zaretskii <eliz@gnu.org>
707 * xdisp.c (handle_invisible_prop): If the invisible text ends just
708 before a newline, prepare the bidi iterator for consuming the
709 newline, and keep the current paragraph direction. (Bug#10183)
710 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
712 2011-12-02 Juri Linkov <juri@jurta.org>
714 * search.c (Fword_search_regexp): New Lisp function created from
715 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
716 (Fword_search_backward, Fword_search_forward)
717 (Fword_search_backward_lax, Fword_search_forward_lax):
718 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
719 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
721 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
723 * fileio.c (Finsert_file_contents): Move after-change-function call
724 to before the "handled:" label, since all "goto handled" appear in
725 cases where the *-change-functions have already been properly called
728 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
730 * keyboard.c (interrupt_signal): Don't call kill-emacs when
731 waiting for input. (Bug#10169)
733 2011-11-30 Eli Zaretskii <eliz@gnu.org>
735 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
736 verifies glyph row's hash code--we have just reallocated the
737 glyphs, so their contents can be complete garbage. (Bug#10164)
739 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
741 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
743 2011-11-30 Eli Zaretskii <eliz@gnu.org>
745 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
746 attributes are tested _before_ calling verify_row_hash, to protect
747 against GCC re-ordering of the tests. (Bug#10164)
749 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
751 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
753 * xterm.c (handle_one_xevent): Only set async_visible and friends
754 if net_wm_state_hidden_seen is non-zero (Bug#10002)
755 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
756 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
758 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
760 Remove GCPRO-related macros that exist only to avoid shadowing locals.
761 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
762 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
763 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
764 All uses changed to use GCPRO1 etc.
765 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
766 Revert to old implementation (i.e., before 2011-03-11).
768 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
770 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
771 of scroll runs so as to avoid assigning disabled bogus rows and
772 unnecessary graphics copy operations.
774 2011-11-27 Eli Zaretskii <eliz@gnu.org>
776 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
777 (snprintf) [_MSC_VER]: Redirect to _snprintf.
778 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
779 (malloc, free, realloc, calloc): Redirect to e_* only when
782 * lisp.h (GCTYPEBITS): Move before first use.
783 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
784 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
785 this macro definition.
787 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
790 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
792 * gtkutil.c (xg_create_frame_widgets):
793 Call gtk_window_set_has_resize_grip (FALSE) if that function is
794 present with Gtk+ 2.0.
796 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
798 * fileio.c (Finsert_file_contents): Undo previous change; see
799 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
801 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
803 Rename locals to avoid shadowing.
804 * fileio.c (Finsert_file_contents):
805 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
806 * process.c (wait_reading_process_output):
807 Rename inner 'proc' to 'p' to avoid shadowing.
808 Indent for consistency with usual Emacs style.
810 2011-11-25 Eli Zaretskii <eliz@gnu.org>
812 * xdisp.c (redisplay_window): If cursor row is not fully visible
813 after recentering, and scroll-conservatively is set to a large
814 number, scroll window by a few more lines to make the cursor fully
815 visible and out of scroll-margin. (Bug#10105)
816 (start_display): Don't move to the next line if the display should
817 start at a newline that is part of a display vector or an overlay
820 2011-11-24 Juri Linkov <juri@jurta.org>
822 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
823 after the `MagickPingImage' call. (Bug#10112)
825 2011-11-23 Chong Yidong <cyd@gnu.org>
827 * window.c (Fcoordinates_in_window_p): Accept only live windows.
829 2011-11-23 Martin Rudalics <rudalics@gmx.at>
831 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
832 making another buffer current. (Bug#10114)
834 2011-11-23 Glenn Morris <rgm@gnu.org>
836 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
838 2011-11-23 Chong Yidong <cyd@gnu.org>
840 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
843 2011-11-22 Eli Zaretskii <eliz@gnu.org>
845 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
846 and header-lines, as they don't have one computed for them.
849 * .gdbinit (prow): Make displayed values more self-explaining.
852 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
854 * process.c (wait_reading_process_output): Fix asynchrounous
855 GnuTLS socket handling on some versions of the GnuTLS library.
856 (wait_reading_process_output): Add comment and URL.
858 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
860 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
862 2011-11-21 Chong Yidong <cyd@gnu.org>
864 * window.c (Fnext_window, Fprevious_window): Doc fix.
866 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
868 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
870 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
872 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
874 2011-11-20 Martin Rudalics <rudalics@gmx.at>
876 * window.c (Fset_window_combination_limit): Rename argument
878 (Vwindow_combination_limit): Remove "status" from doc-string.
880 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
882 * m/ibms390.h: Remove.
883 * m/ibms390x.h: Don't include "ibms390.h".
885 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
887 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
888 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
890 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
892 * casetab.c (Fset_case_table):
893 * charset.c (Fcharset_after): Fix typos.
895 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
897 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
898 Otherwise, valgrind does not work on some platforms.
899 Problem reported by Andreas Schwab in
900 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
901 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
902 is set, removing the need for VIRT_ADDRESS_VARIES.
903 (PURE_P): Use a more-efficient implementation that needs just one
904 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
905 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
906 to 4 (xorl, subq, cmpq, setbe).
907 * alloc.c (pure): Always extern now, since that's the
908 VIRT_ADDR_VARIES behavior.
909 (PURE_POINTER_P): Use a single comparison, not two, for
910 consistency with the new puresize.h.
911 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
912 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
913 Remove VIRT_ADDR_VARIES no longer needed.
915 2011-11-19 Eli Zaretskii <eliz@gnu.org>
917 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
918 (erase_phys_cursor, update_window_cursor, show_mouse_face)
919 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
920 behave as if the cursor position were at the window margin.
922 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
923 and the cursor position is out of bounds, behave as if the cursor
924 position were at the window margin. (Bug#10075)
926 2011-11-18 Chong Yidong <cyd@gnu.org>
928 * window.c (Fwindow_combination_limit): Make first argument
929 non-optional, since it is meaningless for live windows like the
932 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
934 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
936 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
938 * intervals.c: Fix grafting over the whole buffer (bug#10071).
939 (graft_intervals_into_buffer): Simplify.
941 2011-11-18 Eli Zaretskii <eliz@gnu.org>
943 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
944 hash values of the two rows.
945 (copy_row_except_pointers): Preserve the used[] arrays and the
946 hash values of the two rows. (Bug#10035)
947 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
949 * xdisp.c (row_hash): New function, body extracted from
950 compute_line_metrics.
951 (compute_line_metrics): Call row_hash, instead of computing the
954 * dispnew.c (verify_row_hash): Call row_hash for computing the
955 hash code of a row, instead of duplicating code from xdisp.c.
957 * dispextern.h (row_hash): Add prototype.
959 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
961 * frame.c (delete_frame): Don't delete the terminal when the last
962 X frame is closed if emacs is built with GTK toolkit.
964 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
966 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
968 2011-11-17 Martin Rudalics <rudalics@gmx.at>
970 * window.c (Vwindow_splits): Rename to
971 Vwindow_combination_resize. Suggested by Juri Linkov.
972 (Fsplit_window_internal): Use Vwindow_combination_resize instead
975 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
977 * nsfns.m (Fns_font_name):
978 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
980 2011-11-16 Martin Rudalics <rudalics@gmx.at>
982 * window.h (window): Rename slot "nest" to "combination_limit".
983 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
984 (Fset_window_nest): Rename to Fset_window_combination_limit.
985 (Vwindow_nest): Rename to Vwindow_combination_limit.
986 (recombine_windows, make_parent_window, make_window)
987 (Fsplit_window_internal, saved_window)
988 (Fset_window_configuration, save_window_save): Rename all
989 occurrences of window_nest to window_combination_limit.
991 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
993 * image.c (imagemagick_load_image): Fix typo.
995 2011-11-14 Eli Zaretskii <eliz@gnu.org>
997 * xdisp.c (display_line): Move the call to
998 highlight_trailing_whitespace before the call to
999 compute_line_metrics, since the latter needs to see the final
1000 faces of all the glyphs to compute ROW's hash value.
1001 Fixes assertion violations in row_equal_p. (Bug#10035)
1003 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1005 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1006 just return (bug#10044).
1008 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1010 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1011 with user-defined heap size. Bump the default size of the temacs
1012 heap to 27MB, to avoid memory warning when running temacs.
1013 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1015 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1016 current_matrix and desired_matrix. (Bug#9990)
1017 (verify_row_hash) [XASSERTS]: New function.
1018 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1019 that the hash value of glyph rows is correct.
1021 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1023 * window.h (window): Remove splits slot.
1024 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1025 (Fdelete_other_windows_internal, make_parent_window)
1026 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1027 (Fset_window_configuration, save_window_save): Don't deal with
1028 split status of windows.
1029 (saved_window): Remove splits slot.
1030 (Vwindow_splits): Rewrite doc-string.
1032 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1034 * xfns.c (unwind_create_frame):
1035 * nsfns.m (unwind_create_frame):
1036 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1037 Vframe_list (Bug#9999).
1039 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1041 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1043 2011-11-11 Kenichi Handa <handa@m17n.org>
1045 * callproc.c (Fcall_process): Set the member dst_multibyte of
1048 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1050 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1051 avoid a crash (bug#9496).
1053 2011-11-09 Chong Yidong <cyd@gnu.org>
1055 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1056 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1058 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1060 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1062 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1064 Avoid some portability problems by eschewing 'extern inline' functions.
1065 The trivial performance wins aren't worth the portability hassles; see
1066 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1068 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1069 (window_box_width, window_box_left, window_box_left_offset)
1070 (window_box_right, window_box_right_offset): Undo previous change,
1071 by removing the "extern"s.
1072 * intervals.c (adjust_intervals_for_insertion)
1073 (adjust_intervals_for_deletion): Undo previous change,
1074 making these static again.
1075 (offset_intervals, temp_set_point_both, temp_set_point)
1076 (copy_intervals_to_string): No longer inline.
1077 * xdisp.c (window_text_bottom_y, window_box_width)
1078 (window_box_height, window_box_left_offset)
1079 (window_box_right_offset, window_box_left, window_box_right)
1080 (window_box): No longer inline.
1082 2011-11-08 Chong Yidong <cyd@gnu.org>
1084 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1085 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1086 Signal an error if not a live window.
1087 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1088 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1090 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1092 * lisp.h (syms_of_abbrev): Remove declaration.
1093 Reported by CHENG Gao <chenggao@royau.me>.
1095 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1097 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1098 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1099 of temacs in GUI mode.
1101 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1103 * window.h: Declare delete_all_child_windows instead of
1104 delete_all_subwindows.
1105 * window.c (Fwindow_nest, Fset_window_nest)
1106 (Fset_window_new_total, Fset_window_new_normal)
1107 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1108 (delete_all_subwindows): Rename to delete_all_child_windows.
1109 (Fdelete_other_windows_internal, Fset_window_configuration):
1110 Call delete_all_child_windows instead of delete_all_subwindows.
1111 * frame.c (delete_frame): Call delete_all_child_windows instead
1112 of delete_all_subwindows.
1114 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1116 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1117 This is also needed for porting to any host where GC_MARK_STACK is
1118 not GC_MAKE_GCPROS_NOOPS.
1119 (which_symbols): Use it.
1121 2011-11-07 Kenichi Handa <handa@m17n.org>
1123 * coding.c (coding_set_destination): Check coding->src_pos only
1124 when coding->src_object is a buffer (bug#9910).
1126 * process.c (send_process): Set the member src_multibyte of coding
1127 to 0 (bug#9911) when sending a unibyte text.
1129 * callproc.c (Fcall_process): Set the member src_multibyte of
1130 process_coding to 0 (bug#9912).
1132 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1134 * xmenu.c (cleanup_widget_value_tree): New function.
1135 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1136 calling free_menubar_widget_value_tree directly (Bug#9830).
1138 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1140 Fix some portability problems with 'inline'.
1141 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1142 (window_box_width, window_box_left, window_box_left_offset)
1143 (window_box_right, window_box_right_offset): Declare extern.
1144 Otherwise, these inline functions do not conform to C99 and
1145 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1146 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1147 * intervals.c (adjust_intervals_for_insertion)
1148 (adjust_intervals_for_deletion): Now extern, because otherwise the
1149 extern inline functions 'offset_intervals' couldn't refer to it.
1150 (static_offset_intervals): Remove.
1151 (offset_intervals): Rewrite using the old contents of
1152 static_offset_intervals. The old version didn't conform to C99
1153 because an extern inline function contained a reference to an
1154 identifier with static linkage.
1156 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1158 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1161 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1163 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1164 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1165 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1166 return Qleft_to_right.
1168 2011-11-06 Chong Yidong <cyd@gnu.org>
1170 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1171 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1172 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1173 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1174 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1175 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1176 (Fwindow_vscroll): Doc fix.
1177 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1178 argument, since it makes no sense to pass a live window and for
1179 consistency with window-child.
1181 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1183 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1186 2011-11-05 Jason Rumney <jasonr@gnu.org>
1188 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1189 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1191 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1192 bitwise arithmetic preventing use of unicode-sip and non-truetype
1195 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1197 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1200 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1201 initialization code to keep similarity to xfns.c after changes
1204 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1206 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1207 (unwind_create_frame): New function (Bug#9943).
1208 (Fx_create_frame): Restructure code to be more similar to the one in
1209 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1210 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1211 Move terminal->reference_count++ just before making the frame official
1214 * nsterm.m (x_free_frame_resources): New function.
1215 (x_destroy_window): Move code to x_free_frame_resources.
1217 * xfns.c (unwind_create_frame): Fix comment.
1218 (Fx_create_frame, x_create_tip_frame):
1219 Move terminal->reference_count++ just before making the frame
1220 official. Move initialization of image_cache_refcount and
1221 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1223 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1225 Support MSVC build with newer versions of Visual Studio.
1226 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1227 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1230 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1231 which are not supported by MSVC.
1232 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1233 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1235 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1237 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1239 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1241 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1243 Support MSVC build with newer versions of Visual Studio.
1244 * w32.c: Don't include w32api.h for MSVC.
1245 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1247 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1248 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1249 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1250 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1252 (alloca) [_MSC_VER]: Define to _alloca.
1254 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1256 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1258 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1260 * xdisp.c (note_mouse_highlight): If either of
1261 previous/next-single-property-change returns nil, treat that as
1262 the beginning or the end of the buffer. (Bug#9955)
1264 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1266 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1267 label is not null (Bug#9951).
1268 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1271 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1273 * window.c (Fwindow_body_size): Mention in the doc string that the
1274 return value is in frame's canonical units. (Bug#9949)
1276 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1278 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1280 * w32fns.c (unwind_create_frame): If needed, free the glyph
1281 matrices of the partially constructed frame. (Bug#9943)
1282 * xfns.c (unwind_create_frame): Likewise.
1284 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1286 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1287 Don't stop backward scan on the continuation glyph, even though
1288 its CHARPOS is positive.
1289 (mouse_face_from_buffer_pos, note_mouse_highlight):
1290 Rename cover_string to disp_string.
1292 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1294 * window.c (temp_output_buffer_show): Don't use
1295 Vtemp_buffer_show_specifiers.
1296 (Vtemp_buffer_show_specifiers): Remove unused variable.
1298 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1300 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1301 past the beginning of the current glyph matrix.
1303 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1305 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1306 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1307 HAVE_GTK3 (Bug#9869).
1309 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1310 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1312 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1314 * xterm.c: Declare x_handle_net_wm_state to return int.
1315 (handle_one_xevent): Check if we are iconified but don't have
1316 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1317 (get_current_wm_state): Return non-zero if not hidden,
1318 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1319 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1320 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1321 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1323 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1325 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1326 so that this new function doesn't get optimized away by a
1327 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1329 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1331 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1333 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1335 Fix the `xbytecode' command.
1336 * .gdbinit (xprintbytestr): New command.
1337 (xwhichsymbols): Rename from `which'; all callers changed.
1338 (xbytecode): Print the byte-code string as well.
1340 2011-10-29 Kim Storm <storm@cua.dk>
1342 * alloc.c (which_symbols): New function.
1344 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1346 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1349 2011-10-29 Glenn Morris <rgm@gnu.org>
1351 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1352 Not clear what it was for, and it causes various bugs. (Bug#9839)
1354 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1356 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1357 possible random value that matches one of those tested as
1358 condition to clear the mouse face.
1360 2011-10-28 Chong Yidong <cyd@gnu.org>
1362 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1364 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1366 * window.c (make_window): Initialize phys_cursor_on_p.
1368 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1370 * lisp.h (struct Lisp_Symbol): Update comments.
1372 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1374 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1376 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1378 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1379 <oslsachem@gmail.com> for helping to debug this.
1381 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1382 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1383 (g_b_init_get_glyph_outline_w): New static variables.
1384 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1385 (GetGlyphOutlineW_Proc): New typedefs.
1386 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1387 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1389 (w32font_open_internal, compute_metrics):
1390 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1391 instead of calling the "wide" APIs directly.
1393 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1395 * w32.h (syms_of_w32font): Add prototype.
1397 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1399 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1400 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1401 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1402 (Fmove_to_window_line): Doc fix.
1404 2011-10-27 Chong Yidong <cyd@gnu.org>
1406 * process.c (make_process): Set gnutls_state to NULL.
1408 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1409 non-NULL, regardless of GNUTLS_INITSTAGE.
1410 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1411 an error. Set process slots as soon as we allocate them.
1413 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1415 2011-10-27 Chong Yidong <cyd@gnu.org>
1417 * gnutls.c (emacs_gnutls_deinit): New function.
1418 Deallocate credentials structures as well as calling gnutls_deinit.
1419 (Fgnutls_deinit, Fgnutls_boot): Use it.
1421 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1422 (deactivate_process): Call emacs_gnutls_deinit.
1424 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1426 * image.c (x_create_x_image_and_pixmap):
1427 * w32.c (sys_rename, w32_delayed_load):
1428 * w32font.c (fill_in_logfont):
1429 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1431 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1433 * w32fns.c (w32_default_color_map): New function,
1434 extracted from Fw32_default_color_map.
1435 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1437 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1439 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1441 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1443 * keyboard.c (test_undefined): New function (bug#9751).
1444 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1446 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1448 * sysdep.c (init_sys_modes): Fix the check for the controlling
1449 terminal (Bug#6649).
1451 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1453 * dispextern.h (struct bidi_it): New member next_en_type.
1455 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1456 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1457 current character, check also for next_en_type being WEAK_EN.
1458 (bidi_resolve_weak): Don't enter the expensive loop if the current
1459 position is before next_en_pos. Record the bidi type of the first
1460 non-ET, non-BN character we find, in addition to its position.
1461 (bidi_level_of_next_char): Invalidate next_en_type when
1462 next_en_pos is over-stepped.
1464 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1466 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1467 * editfns.c: Rewrite current-time-zone so that it invokes
1468 the equivalent of (format-time-string "%Z") to get the time zone name.
1469 This fixes a bug when the time zone name contains characters that
1470 need converting from the system time locale to Emacs internal format.
1471 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1472 that patch fixed format-time-string to do the conversion, but
1473 I forgot to fix current-time-zone.
1474 (format_time_string): New function, containing most of
1475 what Fformat_time_string used to contain.
1476 (Fformat_time_string): Rewrite in terms of format_time_string.
1477 This doesn't change this function's behavior.
1478 (current-time-zone): Rewrite to use format_time_string.
1479 This fixes the bug reported by Michael Schierl in
1480 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1481 Jason Rumney's 2007-06-07 change worked around this bug, but
1483 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1485 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1487 * xdisp.c (start_display): If the character at POS is displayed
1488 via a display vector, reset IT->current.dpvec_index to zero.
1489 (try_window_reusing_current_matrix): If a line ends in a display
1490 vector or the next line starts in a display vector, continue
1491 redrawing the window even though the character position of
1492 start_row was reached.
1495 2011-10-18 Chong Yidong <cyd@gnu.org>
1497 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1498 with nobreak-char-display too.
1500 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1502 Fix part 3 of bug#9771.
1503 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1504 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1505 non-neutral characters if the current character is a paragraph
1506 separator (a.k.a. Newline). This avoids running the same
1507 expensive loop twice, once when we consume the preceding newline
1508 and the other time when the line actually needs to be displayed.
1509 Avoid the loop when we see neutrals on the base embedding level
1510 following a character whose directionality is the same as the
1511 paragraph's. This avoids running the expensive loop when a line
1512 ends in a long sequence of neutrals, like control characters.
1513 Add assertion against STRONG_AL type. Slightly rearrange code
1514 that determines the type of a neutral given the first non-neutral
1516 (bidi_level_of_next_char): Set next_en_pos to zero when
1517 invalidating its info.
1519 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1521 * xdisp.c (push_display_prop): Determine whether to record string
1522 or buffer position by IT->string, not by IT->method. Allow
1523 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1524 (move_it_vertically_backward): Don't look for character position
1525 immediately after the newline when in a continuation line.
1528 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1530 * window.c (coordinates_in_window): Rewrite and delabelize
1531 vertical border check. (Bug#5357) (Bug#9618)
1533 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1535 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1536 errors in XSetWindowBorder (bug#9310).
1538 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1540 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1541 avoid crash when xmalloc overrun checking is enabled.
1543 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1545 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1546 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1547 cursor motion with <left> and <right> arrow keys.
1549 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1550 some callers set that themselves.
1552 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1554 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1555 display string and the previous row comes from the same string and
1556 is empty. (Bug#9739) (Bug#9738)
1558 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1560 * doc.c (get_doc_string): Encode file name (bug#9735).
1562 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1564 * bidi.c (bidi_level_of_next_char):
1565 * xdisp.c (get_visually_first_element): Remove old incorrect
1566 comments regarding the Unicode Line Separator character.
1568 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1570 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1572 * alloc.c (Fgc_status): Do not access beyond zombies array
1573 boundary if nzombies > MAX_ZOMBIES.
1574 * alloc.c (dump_zombies): Add missing format specifier.
1576 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1578 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1579 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1581 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1582 Some packages use them to denote characters with modifiers.
1584 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1586 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1587 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1588 matching a pp-number. Rename parameter var to var1.
1590 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1592 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1594 2011-10-08 Glenn Morris <rgm@gnu.org>
1596 * callint.c (Fcall_interactively): Give a more explicit error for the
1597 'c' case with a non-character input. (Bug#8479)
1599 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1601 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1603 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1604 lines that are hscrolled on the left.
1606 * dispnew.c (buffer_posn_from_coords): Account for a possible
1607 presence of header-line. (Bug#4426)
1609 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1611 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1612 Don't advertise functionality which we discourage or doesn't work.
1614 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1616 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1617 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1618 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1619 this makes Emacs dump core during garbage collection on rare
1620 occasions. sizeof is obviously inferior to offsetof here, so
1621 stick with offsetof.
1622 (GC_POINTER_ALIGNMENT): New macro.
1623 (mark_memory): Omit 3rd (offset) arg; caller changed.
1624 Don't assume EMACS_INT alignment is the same as pointer alignment.
1626 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1628 * keyboard.c (read_key_sequence_remapped): New var.
1629 (read_key_sequence): Compute remapping in the right buffer.
1630 (command_loop_1): Use read_key_sequence's remapping directly.
1632 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1634 * dired.c (file_name_completion): Don't expand file name.
1635 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1636 before checking file name handler.
1638 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1639 they've been requested explicitly (bug#9591).
1641 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1643 * keymap.c (Fsingle_key_description): Use make_specified_string
1644 instead of build_string to build string from push_key_description.
1647 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1649 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1650 This fixes a Y2038 bug on 64-bit hosts.
1651 * buffer.c (reset_buffer):
1652 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1653 (Fclear_buffer_auto_save_failure):
1654 Use 0, not -1, to represent an unset failure time, since time_t
1655 might not be signed.
1657 Remove dependency on glibc malloc internals.
1658 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1659 Move back here from lisp.h, but with their new implementations.
1660 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1661 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1662 * charset.c (charset_table_init): New static var.
1663 (syms_of_charset): Use it instead of xmalloc. This removes a
1664 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1665 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1666 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1667 Move back to alloc.c.
1668 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1669 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1671 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1673 * nsterm.m (windowDidResize): Call x_set_window_size only when
1674 ns_in_resize is true. Otherwise set pixelwidth/height and
1675 call change_frame_size (Bug#9628).
1677 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1679 Port --enable-checking=all to Fedora 14 x86-64.
1680 * charset.c (syms_of_charset): Also account for glibc malloc's
1681 internal overhead when calculating the initial malloc maximum.
1683 Port --enable-checking=all to Fedora 14 x86.
1684 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1686 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1687 (overrun_check_realloc, overrun_check_free):
1688 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1689 That way, xmalloc returns a properly-aligned pointer even if
1690 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1691 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1692 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1693 into account when calculating the initial malloc maximum.
1694 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1695 Move here from alloc.c, so that charset.c can use it too.
1696 Properly align; the old code wasn't right for common 32-bit hosts
1697 when configured with --enable-checking=all.
1698 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1699 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1701 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1703 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1706 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1708 * xdisp.c (compute_display_string_end): If there's no display
1709 string at CHARPOS, return -1.
1711 * bidi.c (bidi_fetch_char): When compute_display_string_end
1712 returns a negative value, treat the character as a normal
1713 character not covered by a display string. (Bug#9624)
1715 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1717 * lread.c (Fread_from_string): Fix typo in docstring.
1719 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1721 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1722 newline, reseat the iterator instead of bidi-iterating there one
1723 character at a time. (Bug#9610)
1724 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1725 TO_CHARPOS if the bidi iterator is at base embedding level.
1727 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1729 * lread.c (readevalloop): Use correct code for NBSP.
1730 (read1): Likewise. (Bug#9608)
1732 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1734 * dbusbind.c (Fdbus_register_signal): When service is not
1735 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1737 2011-09-25 Glenn Morris <rgm@gnu.org>
1739 * buffer.c (truncate-lines): Doc fix.
1741 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1743 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1744 (Fset_window_next_buffers): Doc fix.
1746 2011-09-24 Glenn Morris <rgm@gnu.org>
1748 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1750 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1752 Fix minor problems found by static checking.
1753 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1754 * indent.c (Fvertical_motion): Fix == vs = typo.
1756 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1758 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1759 Default value is now t. Doc fix.
1761 * indent.c (Fvertical_motion): Compute and apply the overshoot
1762 logic when moving up, not only when moving down. Fix the
1763 confusing name and values of the it_overshoot_expected variable;
1764 logic changes accordingly. (Bug#9254) (Bug#9549)
1766 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1767 CHARPOS is covered by a display string which includes newlines.
1768 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1769 is covered by a display string with embedded newlines.
1771 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1773 * dbusbind.c (Fdbus_register_signal): Add match rule to
1774 Vdbus_registered_objects_table. (Bug#9581)
1775 (Fdbus_register_method, Vdbus_registered_objects_table):
1778 2011-09-24 Jim Meyering <meyering@redhat.com>
1780 do not ignore write error for any output size
1781 The previous change was incomplete.
1782 While it makes emacs --batch detect the vast majority of stdout
1783 write failures, errors were still ignored whenever the output size is
1784 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1785 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1786 && echo FAIL: ignored write error
1787 FAIL: ignored write error
1788 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1789 && echo FAIL: ignored write error
1790 FAIL: ignored write error
1791 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1793 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1795 * emacs.c (Fkill_emacs): In noninteractive mode exit
1796 non-successfully if a write error occurred on stdout. (Bug#9574)
1798 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1800 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1803 * dispextern.h (struct it): Update the comment documenting what
1806 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1808 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1809 a display string, extend search for cursor position to end of row.
1810 (find_row_edges): If the row ends in a newline from a display
1811 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1812 Handle the case of a display string with multiple newlines.
1813 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1814 non-empty line. Fixes confusing cursor motion with arrow keys at
1815 the beginning of a line that starts with whitespace.
1817 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1819 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1822 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1824 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1827 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1829 * xdisp.c (display_line): Record maximum and minimum buffer
1830 positions even if no glyphs were produced (e.g., by a zero-width
1831 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1832 buffer positions that will be removed from the glyph row because
1834 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1835 column is beyond frame width: don't subtract 1 "pixel" when
1836 computing width of the stretch.
1837 (reseat_at_next_visible_line_start): Undo the change made on
1838 2011-09-17 that saved paragraph information and restored it after
1839 the call to `reseat'. (Bug#9545)
1841 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1843 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1844 and turn window cursor on if cleared (Bug#9415).
1846 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1848 * search.c (boyer_moore): Take unibyte characters from pattern
1849 literally. (Bug#9458)
1851 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1853 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1855 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1857 Fix minor problem found by static checking.
1858 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1859 initialized, to pacify gcc -Wuninitialized.
1861 * fileio.c: Report proper errno when syscall falls.
1862 (Finsert_file_contents): Save and restore errno,
1863 so that report_file_error outputs the correct diagnostic.
1864 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1866 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1868 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1870 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1872 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1873 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1875 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1877 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1878 about the current paragraph and restore it after the call to reseat.
1880 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1881 (bidi_find_paragraph_start): Search back for paragraph beginning
1882 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1883 (bidi_move_to_visually_next): Only trigger paragraph-related
1884 computations when the last character is a newline or at EOB, not
1885 just any NEUTRAL_B. (Bug#9470)
1887 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1888 truncated lines if point is covered by a display string. (Bug#9524)
1890 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1892 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1893 (cons_to_x_long): New function.
1894 (lisp_data_to_selection_data): Use it. Correct the test for
1895 short-versus-long data; it was negated. Break out of vector
1896 loop, for efficiency, when a long datum is discovered.
1898 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1900 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1902 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1904 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1905 GCC PR/17406) by declaring this function with external scope.
1907 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1909 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1910 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1912 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1914 * editfns.c (Fformat): Correctly handle text properties on "%%".
1916 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1918 * xterm.c (x_draw_composite_glyph_string_foreground):
1919 * w32term.c (x_draw_composite_glyph_string_foreground):
1920 * term.c (encode_terminal_code):
1921 * composite.c (composition_update_it, get_composition_id):
1922 * xdisp.c (get_next_display_element)
1923 (fill_composite_glyph_string): Add comments about special meaning
1924 of TAB characters in a composition.
1926 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1928 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1929 This occurs when processing a multibyte format.
1930 Problem reported by Wolfgang Jenker.
1932 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1934 * xdisp.c (try_cursor_movement): Only check for exact match if
1935 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1937 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1939 Remove unused external symbols.
1940 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1941 * xdisp.c (calc_pixel_width_or_height): Now static.
1942 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1943 * indent.c (check_display_width):
1944 * w32term.c: Fix comment to match code.
1945 * xterm.c, xterm.h (x_catching_errors): Remove.
1947 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1949 * xselect.c: Use signed conversions more consistently (Bug#9498).
1950 (selection_data_to_lisp_data): Assume incoming selection data are
1951 signed integers, not unsigned. This is to be consistent with
1952 outgoing selection data, which was modified to use signed integers
1953 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1954 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1955 expects long, not unsigned long.
1957 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1959 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1960 computation of loop end. Reported by Johan Bockgård
1963 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1965 * frame.c (Fother_visible_frames_p): Function deleted.
1967 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1969 * indent.c (compute_motion): Process display vector front to back
1970 rather than the other way around. (Bug#2496)
1972 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1974 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1976 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1978 * minibuf.c (Fread_from_minibuffer): Doc fix.
1980 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1982 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1983 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1985 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1987 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1988 value for non-existent files.
1990 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1992 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1993 set its "size" to -1. This will set the modtime_size field of
1994 the corresponding buffer to -1, which is what
1995 verify-visited-file-modtime expects for files that do not exist.
1998 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2000 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2002 * lisp.h: ... from here. push_key_description is no longer
2003 defined in keyboard.c, so its declaration should not be in
2004 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2005 logically belongs with push_key_description.
2007 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2009 * buffer.h: Include <sys/types.h> instead of <time.h>.
2010 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2011 Problem reported by Herbert J. Skuhra.
2013 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2015 * xml.c (parse_region): Make the parsing work for
2016 non-comment-starting XML files again (bug#9144).
2018 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2020 * image.c (gif_load): Fix calculation of bottom and right corner.
2023 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2025 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2026 redisplay in small windows.
2028 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2030 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2032 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2034 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2035 Operate on live windows only.
2037 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2039 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2041 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2043 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2044 only under bidi iteration.
2046 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2048 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2050 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2052 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2053 Without this fix, the command to link temacs failed due to an
2054 undefined symbol __builtin_isnan. This is because
2055 /usr/include/iso/math_c99.h #defines isnan(x) to
2056 __builtin_isnan(x), but the bundled gcc, which identifies itself
2057 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2059 * floatfns.c (isnan): #undef, and then #define to a clone of
2061 (Fisnan): Always define, since it's always available now.
2062 (syms_of_floatfns): Always define isnan at the Lisp level.
2064 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2066 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2068 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2070 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2071 The previous code assumed that file offsets (off_t values) fit in
2072 EMACS_INT variables, which is not true on typical 32-bit hosts.
2073 The code messed up by falsely reporting buffer overflow in cases
2074 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2075 when "big" contains more than 2**29 bytes, even though this
2076 inserts just one byte and does not overflow the buffer.
2077 (Finsert_file_contents): Store file offsets as off_t
2078 values, not as EMACS_INT values. Check for overflow when
2079 converting between EMACS_INT and off_t. When checking for
2080 buffer overflow or for overlap, take the offsets into account.
2081 Don't use EMACS_INT for small values where int suffices.
2082 When checking for overlap, fix a typo: ZV was used where
2083 ZV_BYTE was intended.
2084 (Fwrite_region): Don't assume off_t fits into 'long'.
2085 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2087 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2089 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2091 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2093 sprintf-related integer and memory overflow issues (Bug#9412).
2095 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2096 (esprintf, exprintf, evxprintf): New functions.
2097 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2098 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2099 (modify_event_symbol): Do not assume that the length of
2100 name_alist_or_stem is safe to alloca and fits in int.
2101 (Fexecute_extended_command): Likewise for function name and binding.
2102 (Frecursion_depth): Wrap around reliably on integer overflow.
2103 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2104 since some callers pass EMACS_INT values.
2105 (Fsingle_key_description): Don't crash if symbol name contains more
2106 than MAX_ALLOCA bytes.
2107 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2108 (get_minibuffer): Arg is now EMACS_INT, not int.
2109 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2110 (esprintf, exprintf, evxprintf): New decls.
2111 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2113 * dbusbind.c (signature_cat): New function.
2114 (xd_signature, Fdbus_register_signal):
2115 Do not overrun buffer; instead, report string overflow.
2117 * dispnew.c (add_window_display_history): Don't overrun buffer.
2118 Truncate instead; this is OK since it's just a log.
2120 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2121 even if the time zone offset is outlandishly large.
2122 Don't mishandle offset == INT_MIN.
2124 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2125 when creating daemon; the previous buffer-overflow check was incorrect.
2127 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2128 which has the guts of the old verror function.
2130 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2131 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2133 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2134 (font_unparse_xlfd): Don't blindly alloca long strings.
2135 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2136 fits in int, when using sprintf. Use single snprintf to count
2137 length of string rather than counting it via multiple sprintfs;
2138 that's simpler and more reliable.
2139 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2140 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2141 sprintf, in case result does not fit in int.
2143 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2144 (fontset_from_font): Print it.
2146 * frame.c (tty_frame_count): Now printmax_t, not int.
2147 (make_terminal_frame, set_term_frame_name): Print it.
2148 (x_report_frame_params): In X, window IDs are unsigned long,
2149 not signed long, so print them as unsigned.
2150 (validate_x_resource_name): Check for implausibly long names,
2151 and don't assume name length fits in 'int'.
2152 (x_get_resource_string): Don't blindly alloca invocation name;
2153 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2156 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2157 (xg_check_special_colors, xg_set_geometry):
2158 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2160 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2161 Use esprintf, not sprintf, in case result does not fit in int.
2163 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2164 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2165 it as a large positive number.
2166 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2167 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2169 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2170 in case result does not fit in int.
2172 * print.c (float_to_string): Detect width overflow more reliably.
2173 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2174 buffer overrun. Don't assume list length fits in 'int'. Treat
2175 print length of 0 as 0, not as infinity; to be consistent with other
2176 uses of print length in this function. Don't overflow print length
2177 index. Don't assume hash table size fits in 'long', or that
2178 vectorlike size fits in 'unsigned long'.
2180 * process.c (make_process): Use printmax_t, not int, to format
2181 process-name gensyms.
2183 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2185 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2186 to avoid potential buffer overrun.
2188 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2189 if X resource line is longer than 512 bytes.
2191 * xfns.c (x_window): Make sprintf buffer a bit bigger
2192 to avoid potential buffer overrun.
2194 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2196 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2198 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2200 Integer overflow fixes for scrolling, etc.
2201 Without these, Emacs silently mishandles large integers sometimes.
2202 For example, "C-u 4294967297 M-x recenter" was treated as if
2203 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2205 * xdisp.c (try_window_id): Check Emacs fixnum range before
2206 converting to 'int'.
2208 * window.c (window_scroll_line_based, Frecenter):
2209 Check that an Emacs fixnum is in range before assigning it to 'int'.
2210 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2211 values converted from Emacs fixnums.
2212 (Frecenter): Don't wrap around a line count if it is out of 'int'
2213 range; instead, treat it as an extreme value.
2214 (Fset_window_configuration, compare_window_configurations):
2215 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2217 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2218 that can exceed INT_MAX. Check that EMACS_INT value is in range
2219 before assigning it to the (possibly-narrower) index.
2220 (match_limit): Don't assume that a fixnum can fit in 'int'.
2222 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2225 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2226 (Fvertical_motion): Don't wrap around LINES values that don't fit
2227 in 'int'. Instead, treat them as extreme values. This is good
2228 enough for windows, which can't have more than INT_MAX lines anyway.
2230 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2232 * Require libxml/parser.h to avoid compilation warning.
2234 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2236 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2237 since this reportedly can destroy thread storage.
2239 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2241 * syntax.c (find_defun_start): Update all cache variables if
2242 exiting early (Bug#9401).
2244 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2246 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2248 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2249 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2250 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2252 * term.c (tty_append_glyph): New function.
2253 (produce_stretch_glyph): Static function and its prototype deleted.
2255 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2258 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2260 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2261 when checking :margin (Bug#9390).
2262 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2263 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2264 so that the name doesn't mislead. All uses changed.
2266 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2268 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2271 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2273 * xdisp.c (move_it_to): Don't bail out early when reaching
2274 position beyond to_charpos, if we are scanning backwards.
2275 (move_it_vertically_backward): When DY == 0, make sure we get to
2276 the first character in the line after the newline.
2278 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2280 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2281 (ccl_driver): Do not generate an out-of-range pointer.
2282 (Fccl_execute_on_string): Remove unnecessary check for
2283 integer overflow, noted by Stefan Monnier in
2284 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2285 Remove a FIXME that didn't need fixing.
2286 Simplify the newly-introduced buffer reallocation code.
2288 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2290 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2292 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2294 Integer and memory overflow issues (Bug#9196).
2296 * doc.c (get_doc_string): Rework so that
2297 get_doc_string_buffer_size is the actual buffer size, rather than
2298 being 1 less than the actual buffer size; this makes xpalloc more
2301 * image.c (x_allocate_bitmap_record, cache_image):
2302 * xselect.c (Fx_register_dnd_atom):
2303 Simplify previous changes by using xpalloc.
2305 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2306 since either will do and ptrdiff_t is convenient with xpalloc.
2308 * charset.c (charset_table_size)
2309 (struct charset_sort_data.priority): Now ptrdiff_t.
2310 (charset_compare): Don't overflow if priorities differ greatly.
2311 (Fsort_charsets): Don't assume list length fits in int.
2312 Check for size-calculation overflow when allocating sort data.
2313 (syms_of_charset): Allocate an initial charset table that is
2314 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2316 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2318 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2319 The actual value is always <= INT_MAX, and leaving it unsigned made
2320 overflow checking harder.
2322 * dispextern.h (struct glyph_matrix.rows_allocated)
2323 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2324 with xpalloc. The values are still always <= INT_MAX.
2326 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2328 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2329 (SAFE_NALLOCA): New macro.
2331 * region-cache.c (struct boundary.pos, find_cache_boundary)
2332 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2333 (set_cache_region, invalidate_region_cache)
2334 (revalidate_region_cache, know_region_cache, region_cache_forward)
2335 (region_cache_backward, pp_cache):
2336 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2337 so that ptrdiff_t * can be passed to xpalloc.
2338 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2339 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2340 (pp_cache): Don't assume cache_len fits in int.
2341 * region-cache.h: Adjust extern decls to match.
2343 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2344 EMACS_INT, since either will do, for xpalloc.
2346 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2347 (xnmalloc, xnrealloc, xpalloc): New functions.
2349 * bidi.c (bidi_shelve_header_size): New constant.
2350 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2351 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2353 * bidi.c (bidi_cache_shrink):
2354 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2356 Don't update size of array until after memory allocation succeeds,
2357 because xmalloc/xrealloc may not return.
2358 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2359 now that we have proper integer overflow checking.
2360 (record_overlay_string, overlay_strings): Catch overflows when
2361 calculating size of overlay_str_buf.
2363 * callproc.c (Fcall_process): Check for size overflow when
2364 calculating size of args2.
2365 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2366 Normally we prefer signed values, but sticking with ptrdiff_t would
2367 require adding more-complicated checks.
2369 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2370 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2371 Redo buffer-overflow calculations to avoid integer overflow.
2372 Add a FIXME comment where memory seems to be over-allocated.
2374 * character.c (Fstring): Check for size-calculation overflow.
2376 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2377 unnecessary integer overflow. Check for size overflow.
2378 (encode_coding_object): Don't update size until xmalloc succeeds.
2380 * composite.c (get_composition_id): Check for overflow in glyph
2381 length calculations.
2383 Integer and memory overflow fixes for display code.
2384 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2385 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2386 (scrolling_window): Check for overflow in size calculations.
2387 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2388 Don't assume glyph table len fits in int.
2389 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2390 (row_table_size): Now ptrdiff_t, not int.
2391 (scrolling_window): Avoid overflow in size calculations.
2392 Don't update size until allocation succeeds.
2393 * fns.c (concat): Check for overflow in size calculations.
2394 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2395 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2396 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2398 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2399 (get_doc_string): Check for size calculation overflow.
2400 Don't update size until allocation succeeds.
2401 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2402 EMACS_INT, where ptrdiff_t will do.
2403 (Fsubstitute_command_keys): Check for string overflow.
2405 * editfns.c (set_time_zone_rule): Don't assume environment length
2407 (message_length): Now ptrdiff_t, not int.
2408 (Fmessage_box): Don't update size until allocation succeeds.
2409 Don't assume message length fits in int.
2410 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2412 * emacs.c (main): Do not reallocate argv, since there is a null at
2413 the end that can be overwritten, and this way there's no need to
2414 worry about size-calculation overflow.
2415 (sort_args): Check for size-calculation overflow.
2417 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2419 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2421 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2422 (x_set_scroll_bar_width, x_figure_window_size):
2423 Check for integer overflow.
2424 (x_set_alpha): Do not assume XINT fits in int.
2426 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2427 This is for the members text_lines, text_cols, total_lines, total_cols,
2428 where the system imposes an 'int' limit.
2430 * fringe.c (Fdefine_fringe_bitmap):
2431 Don't update size until alloc works.
2433 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2434 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2436 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2437 Check for size-calculation overflow.
2438 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2439 do, as we prefer signed integers.
2440 (id_to_widget.max_size, id_to_widget.used)
2441 (xg_store_widget_in_map, xg_remove_widget_from_map)
2442 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2443 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2444 Use and return ptrdiff_t, not int.
2445 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2446 * gtkutil.h: Change prototypes to match the above.
2448 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2449 are duplicate now that they've been promoted to lisp.h.
2450 (x_allocate_bitmap_record, x_alloc_image_color)
2451 (make_image_cache, cache_image, xpm_load):
2452 Don't update size until alloc is done.
2453 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2455 Check for size calculation overflow.
2456 (ct_colors_allocated_max): New constant.
2457 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2460 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2461 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2462 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2463 Use ptrdiff_t, not int, to count maps.
2464 (read_char_minibuf_menu_prompt): Check for overflow in size
2465 calculations. Don't update size until allocation succeeds.
2466 Redo calculations to avoid overflow.
2467 * keyboard.h: Change prototypes to match the above.
2469 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2471 (current_minor_maps): Check for size calculation overflow.
2472 * keymap.h: Change prototypes to match the above.
2474 * lread.c (read1, init_obarray): Don't update size until alloc done.
2476 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2477 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2479 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2480 Now ptrdiff_t, not int.
2481 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2482 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2484 * process.c (Fnetwork_interface_list): Check for overflow
2485 in size calculation.
2487 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2489 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2490 overflow. Don't bother calling xmalloc when xrealloc will do.
2492 * search.c (Freplace_match): Check for size calculation overflow.
2493 (Fset_match_data): Don't assume list lengths fit in 'int'.
2495 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2496 for command line length. Do not attempt to address one before the
2497 beginning of an array, as that's not portable.
2499 * term.c (max_frame_lines): Remove; unused.
2500 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2502 (encode_terminal_code, calculate_costs): Check for size
2503 calculation overflow.
2504 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2505 table lengths and related sizes. Don't update size until alloc
2506 done. Redo calculations to avoid overflow.
2507 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2509 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2510 subtracting pointers.
2511 (gobble_line): Check for overflow more carefully. Don't update size
2514 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2515 Don't update size until alloc done.
2516 Redo size calculations to avoid overflow.
2517 Check for size calculation overflow.
2518 (main) [DEBUG]: Fix typo in invoking tparam1.
2520 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2521 Use ptrdiff_t, not int, for sizes.
2522 (store_mode_line_noprop_char): Don't update size until alloc done.
2524 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2525 Use ptrdiff_t, not int, for sizes.
2526 (Finternal_make_lisp_face, cache_face):
2527 Check for size calculation overflow.
2528 (cache_face): Treat size calculation overflows as if they were
2529 memory exhaustion (the usual treatment), rather than aborting.
2531 * xfns.c (x_encode_text, x_set_name_internal)
2532 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2533 sizes, since they can exceed INT_MAX in size. Check for size
2534 calculation overflow.
2536 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2537 (xg_select): Check for size calculation overflow.
2538 Don't update size until alloc done.
2540 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2541 as sprintf is limited to int lengths.
2543 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2544 (X_LONG_MIN): New macros.
2545 Use them to make the following changes clearer.
2546 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2547 This change doesn't affect the value now, but it may help remind
2548 future maintainers not to raise the value too much later.
2549 (SELECTION_QUANTUM): Remove, replacing with ...
2550 (selection_quantum): ... new function, which avoids overflow.
2552 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2553 assumption that selection length fits in 'int'.
2554 (x_reply_selection_request, x_handle_selection_request)
2555 (x_get_window_property, receive_incremental_selection)
2556 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2557 (lisp_data_to_selection_data, clean_local_selection_data):
2558 Use ptrdiff_t, not int, to record length of selection.
2559 (x_reply_selection_request, x_get_window_property)
2560 (receive_incremental_selection, x_property_data_to_lisp):
2561 Redo calculations to avoid overflow.
2562 (x_reply_selection_request): When sending hint, ceiling it at
2563 X_LONG_MAX rather than relying on wraparound overflow to send
2565 (x_get_window_property, receive_incremental_selection)
2566 (lisp_data_to_selection_data, x_property_data_to_lisp):
2567 Check for size-calculation overflow.
2568 (x_get_window_property, receive_incremental_selection)
2569 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2570 Don't store size until memory allocation succeeds.
2571 (x_get_window_property): Plug memory leak on memory exhaustion.
2572 Don't double-block input; malloc is safe here. Don't assume 2**34
2573 - 4 fits in unsigned long. Add an xassert to check
2574 XGetWindowProperty overflow. Be more careful about overflow
2575 calculations, and distinguish size from memory overflow better.
2576 (receive_incremental_selection): When tracing, don't assume
2577 unsigned int is less than INT_MAX.
2578 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2579 harmful) conversions of unsigned short to int.
2580 (lisp_data_to_selection_data): Don't assume that integers
2581 in the range -65535 through -1 fit in an X unsigned short.
2582 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2583 result parameters unless successful. Rely on cons_to_unsigned
2584 to report problems with elements; the old code wasn't right anyway.
2585 (x_check_property_data): Check for int overflow; we cannot use
2586 a wider type due to X limits.
2587 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2589 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2591 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2592 (x_term_init): Check for size calculation overflow.
2593 (x_color_cells): Don't store size until memory allocation succeeds.
2594 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2595 Don't assume alloca size is less than MAX_ALLOCA.
2596 (x_term_init): Don't assume length fits in int (sprintf is limited
2599 Use ptrdiff_t for composition IDs.
2600 * character.c (lisp_string_width):
2601 * composite.c (composition_table_size, n_compositions)
2602 (get_composition_id, composition_gstring_from_id):
2603 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2604 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2605 * window.c (Frecenter):
2606 Use ptrdiff_t, not int, for composition IDs.
2607 * composite.c (get_composition_id): Check for integer overflow.
2608 * composite.h: Adjust prototypes to match the above changes.
2610 Use ptrdiff_t for hash table indexes.
2611 * category.c (hash_get_category_set):
2612 * ccl.c (ccl_driver):
2613 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2614 * coding.c (coding_system_charset_list, detect_coding_system):
2615 * coding.h (struct coding_system.id):
2616 * composite.c (get_composition_id, gstring_lookup_cache):
2617 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2618 * image.c (xpm_get_color_table_h):
2619 * lisp.h (hash_lookup, hash_put):
2620 * minibuf.c (Ftest_completion):
2621 Use ptrdiff_t for hash table indexes, not int (which is too
2622 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2623 32-bit --with-wide-int hosts).
2625 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2626 Add a FIXME comment about memory leaks.
2627 (syms_of_charset): Don't assume xmalloc returns.
2629 Don't assume that stated character widths fit in int.
2630 * character.c (Fchar_width, c_string_width, lisp_string_width):
2631 * character.h (CHAR_WIDTH):
2632 * indent.c (MULTIBYTE_BYTES_WIDTH):
2633 Use sanitize_char_width to avoid undefined and/or bad behavior
2634 with outlandish widths.
2635 * character.h (sanitize_tab_width): Rename from sanitize_width,
2636 now that we have two such functions. All uses changed.
2637 (sanitize_char_width): New inline function.
2639 Don't assume that tab-width fits in int.
2640 * character.h (sanitize_width): New inline function.
2641 (SANE_TAB_WIDTH): New macro.
2642 (ASCII_CHAR_WIDTH): Use it.
2643 * indent.c (sane_tab_width): Remove. All uses replaced by
2644 SANE_TAB_WIDTH (current_buffer).
2645 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2647 * fileio.c: Integer overflow issues with file modes.
2648 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2650 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2651 Remove unreachable code.
2652 (read_hex, load_charset_map_from_file): Check for integer overflow.
2654 * xterm.c: Don't go over XClientMessageEvent limit.
2655 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2656 (x_send_scroll_bar_event): Likewise. Check that the size does not
2657 exceed limits imposed by XClientMessageEvent, as well as the usual
2658 ptrdiff_t and size_t limits.
2660 * keyboard.c: Overflow, signedness and related fixes.
2661 (make_lispy_movement): Use same integer type in forward decl
2662 that is used in the definition.
2663 (read_key_sequence, keyremap_step):
2664 Change bufsize argument back to int, undoing my 2011-03-30 change.
2665 We prefer signed types, and int is wide enough here.
2666 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2667 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2668 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2669 length, not size_t. Use ptrdiff_t for index, not int.
2670 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2671 possibility of integer overflow.
2673 Overflow, signedness and related fixes for images.
2675 * dispextern.h (struct it.stack[0].u.image.image_id)
2676 (struct_it.image_id, struct image.id, struct image_cache.size)
2677 (struct image_cache.used, struct image_cache.ref_count):
2678 * gtkutil.c (update_frame_tool_bar):
2679 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2680 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2681 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2682 * nsmenu.m (update_frame_tool_bar):
2683 * xdisp.c (calc_pixel_width_or_height):
2684 * xfns.c (image_cache_refcount):
2685 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2686 on typical 64-bit hosts.
2688 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2689 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2690 Omit unnecessary casts to int.
2691 (parse_image_spec): Check that integers fall into 'int' range
2692 when the callers expect that.
2693 (image_ascent): Redo ascent calculation to avoid int overflow.
2694 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2695 (lookup_image): Remove unnecessary tests.
2696 (xbm_image_p): Locals are now of int, not EMACS_INT,
2697 since parse_image_check makes sure they fit into int.
2698 (png_load, gif_load, svg_load_image):
2699 Prefer int to unsigned where either will do.
2700 (tiff_handler): New function, combining the cores of the
2701 old tiff_error_handler and tiff_warning_handler.
2702 This function is rewritten to use vsnprintf and thereby avoid
2703 stack buffer overflows. It uses only the features of vsnprintf
2704 that are common to both POSIX and native Microsoft.
2705 (tiff_error_handler, tiff_warning_handler): Use it.
2706 (tiff_load, gif_load, imagemagick_load_image):
2707 Don't assume :index value fits in 'int'.
2708 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2709 (imagemagick_load_image): Check that crop parameters fit into
2710 the integer types that MagickCropImage accepts. Don't assume
2711 Vimagemagick_render_type has a nonnegative value. Don't assume
2712 size_t fits in 'long'.
2713 (gs_load): Use printmax_t to print the widest integers possible.
2714 Check for integer overflow when computing image height and width.
2716 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2718 * xdisp.c (redisplay_window): Don't force window start if point
2719 will be invisible in the resulting window. (Bug#9324)
2721 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2723 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2724 the display spec is of the form `(space ...)'.
2725 (handle_display_spec): Return the value returned by
2726 handle_single_display_spec, not just 1 or zero.
2727 (handle_single_display_spec): If the display spec is of the form
2728 `(space ...)', and specifies display in the text area, return 2
2730 (try_cursor_movement): Check for the need to scroll more
2731 accurately, and prefer exact match for point under bidi.
2732 Don't advance `row' beyond the last row of the window.
2734 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2735 into disp_prop; all users changed.
2737 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2738 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2739 for the text covered by the display property.
2741 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2743 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2744 Change return value to nil.
2745 (Frecord_buffer): Delete unused function.
2747 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2749 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2750 buffers, return left-to-right.
2751 (set_cursor_from_row): Consider candidate row a win if its glyph
2752 represents a newline and point is on that newline. Fixes cursor
2753 positioning on the newline at EOL of R2L text within L2R
2754 paragraph, and vice versa.
2755 (try_cursor_movement): Check continued rows, in addition to
2756 continuation rows. Fixes unwarranted scroll when point enters a
2757 continued line of R2L text within an L2R paragraph, or vice versa.
2758 (cursor_row_p): Consider the case of point being equal to
2759 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2760 from the end of a short line to the beginning of a continued line
2761 of R2L text within L2R paragraph.
2762 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2763 composed characters.
2765 * bidi.c (bidi_check_type): Use xassert.
2766 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2769 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2771 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2774 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2776 * nsfont.m (ns_otf_to_script): Fix typo.
2778 2011-08-22 Kenichi Handa <handa@m17n.org>
2780 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2781 extra slot even if the purpose is char-code-property-table.
2783 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2785 * xdisp.c (redisplay_window): When computing centering_position,
2786 account for the height of the header line. (Bug#8874)
2788 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2789 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2790 candidate is selected by the mouse, and that candidate has a
2791 composed character under the mouse.
2793 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2794 coordinates reported by pos-visible-in-window-p for a composed
2795 character in column zero.
2797 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2799 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2801 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2803 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2804 consider it a hit if to_charpos is anywhere in the range of the
2805 composed buffer positions.
2807 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2809 * image.c (gif_load): Don't assume that each subimage has the same
2810 dimensions as the base image. Handle disposal method that is
2811 "undefined" by the gif spec (Bug#9335).
2813 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2815 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2816 (Fcondition_case): Document `debug' symbol in error handler.
2818 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2820 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2821 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2822 from an Org mode buffer to a Speedbar frame.
2824 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2825 a composition, take its buffer position from IT->cmp_it.charpos.
2826 Fixes cursor positioning at the beginning of a line that begins
2827 with a composed character.
2829 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2831 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2832 character bidirectional type, use STRONG_L instead. Fixes crashes
2833 in a buffer produced by `describe-categories'.
2835 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2836 members before the level stack, so they would be saved and
2837 restored when copying iterator state. Fixes incorrect reordering
2838 around TABs covered by display properties.
2840 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2842 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2844 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2846 * eval.c (internal_condition_case, internal_condition_case_1)
2847 (internal_condition_case_2, internal_condition_case_n):
2848 Remove unnecessary aborts (Bug#9081).
2850 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2852 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2853 has no `load' handler, try opening the file locally. (Bug#9311)
2855 2011-08-16 Ken Brown <kbrown@cornell.edu>
2857 * gmalloc.c: Expand comment.
2859 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2861 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2862 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2864 2011-08-16 Ken Brown <kbrown@cornell.edu>
2866 Fix memory allocation problems in Cygwin build (Bug#9273).
2868 * unexcw.c ( __malloc_initialized): Declare external variable.
2869 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2871 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2873 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2875 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2877 [CYGWIN] (special_realloc): New function.
2878 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2879 requests to realloc storage in the static heap.
2881 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2883 * bidi.c (bidi_initialize): Remove unused local.
2885 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2888 * biditype.h: Remove file.
2889 * makefile.w32-in ($(BLD)/bidi.$(O)):
2890 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2892 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2894 * chartab.c: Improve commentary for the uniprop_table API.
2896 * bidi.c (bidi_paragraph_init): Support zero value of
2897 bidi_ignore_explicit_marks_for_paragraph_level.
2898 (bidi_initialize): Use uniprop_table instead of including
2899 biditype.h and bidimirror.h.
2901 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2902 coordinates of the iterator when restoring from ppos_it.
2905 2011-08-14 Kenichi Handa <handa@m17n.org>
2907 * process.c (create_process): Call setup_process_coding_systems
2908 after the pid of the process is set to -1 (Bug#8162).
2910 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2912 * xdisp.c (move_it_in_display_line_to): Don't invoke
2913 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2914 ppos_it. Fixes vertical cursor motion when line beginning is
2915 covered by an image. (Bug#9296)
2917 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2919 * nsterm.h (ns_run_ascript): Declare.
2920 (NSAPP_DATA2_RUNASSCRIPT): Define.
2922 * nsfns.m (as_script, as_result, as_status): New static variables.
2923 (ns_run_ascript): New function.
2924 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2925 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2926 the event loop. Get status from as_status (Bug#7276).
2928 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2929 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2930 the event loop (Bug#7276).
2932 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2934 * gnutls.c (QCgnutls_bootprop_priority)
2935 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2936 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2937 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2938 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2939 (QCgnutls_bootprop_verify_hostname_error)
2940 (QCgnutls_bootprop_callbacks_verify): Rename from
2941 Qgnutls_bootprop_..., all uses changed.
2943 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2946 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2948 * xfaces.c (Qframe_set_background_mode): Now static.
2949 * dispextern.h (Qframe_set_background_mode): Remove decl.
2951 * process.c (Fnetwork_interface_info): Declare local only if needed.
2953 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2955 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2956 (Fnetwork_interface_list): Allocate in increments of bytes instead
2957 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2958 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2960 (struct ifflag_def): notrailers is smart on OSX.
2961 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2962 Get hardware address with getifaddrs if available.
2964 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2966 * xdisp.c (iterate_out_of_display_property): xassert that
2967 IT->position is set to within IT->object's boundaries. Break from
2968 the loop as soon as EOB is reached; avoids infloops in redisplay
2969 when IT->position is set up wrongly due to some bug.
2970 Set IT->current to match the bidi iterator unconditionally.
2971 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2972 entry. Force push_it to save on the stack the current
2973 buffer/string position, to be restored by pop_it. Fix flags in
2974 the iterator structure wrt the object coming from a display
2975 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2976 properties. (Bug#9284)
2978 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2980 * fontset.c (fontset_get_font_group): Add proper type checks.
2983 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2985 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2986 and LC_VERSION_MIN_MACOSX.
2987 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2988 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2990 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2992 * xdisp.c (forward_to_next_line_start): Allow to use the
2993 no-display-properties-and-no-overlays under bidi display.
2994 Set disp_pos in the bidi iterator to avoid searches for display
2995 properties and overlays.
2997 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2999 * editfns.c (Fset_time_zone_rule): Document relationship with the
3002 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3003 the font entity extracted from the cache (Bug#8109).
3005 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3007 * composite.c (autocmp_chars): Don't reset point. That is done by
3008 restore_point_unwind (Bug#5984).
3010 2011-08-07 Juri Linkov <juri@jurta.org>
3012 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3013 to show the arg `TIME' instead of `TIMEVAL'.
3015 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3017 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3018 display property strides EOL and includes a newline, as in
3019 longlines-mode. (Bug#9254)
3020 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3021 word-wrap under bidirectional display. (Bug#9224)
3023 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3024 is non-zero, even if the data buffer is NULL. Fixes a crash in
3025 vertical-motion with longlines-mode. (Bug#9254)
3027 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3029 * bidi.c <bidi_cache_total_alloc>: Now static.
3030 (bidi_initialize): Initialize bidi_cache_total_alloc.
3032 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3035 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3036 amount allocated this far in `bidi_cache_total_alloc'.
3037 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3038 non-zero, only free the data buffer without restoring the cache
3039 contents. All callers changed.
3041 * dispextern.h (bidi_unshelve_cache): Update prototype.
3043 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3044 (move_it_in_display_line, move_it_to)
3045 (move_it_vertically_backward, move_it_by_lines): Replace the call
3046 to xfree to an equivalent call to bidi_unshelve_cache.
3047 (move_it_in_display_line_to): Fix logic of returning
3048 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3050 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3052 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3053 came from a string character with a `cursor' property. (Bug#9229)
3055 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3057 * Makefile.in (LIB_PTHREAD): New variable.
3058 (LIBES): Add LIB_PTHREAD (Bug#9216).
3060 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3061 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3063 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3065 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3067 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3069 * xterm.c (x_find_topmost_parent): New function.
3070 (x_set_frame_alpha): Find topmost parent window with
3071 x_find_topmost_parent and set the property there also (bug#9181).
3072 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3074 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3076 * callproc.c (Fcall_process): Avoid vfork clobbering
3077 the local vars buffer, coding_systems, current_dir.
3079 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3081 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3083 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3085 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3086 so that it is not optimized away.
3088 * xdisp.c (compute_display_string_pos): Remove unused local.
3090 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3092 Fix slow cursor motion and scrolling in large buffers with
3093 selective display, like Org Mode buffers. (Bug#9218)
3095 * dispextern.h (struct bidi_it): New member disp_prop_p.
3097 * xdisp.c: Remove one-slot cache of display string positions.
3098 (compute_display_string_pos): Accept an additional argument
3099 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3100 for a display string or property. If found, set DISP_PROP_P
3103 * bidi.c (bidi_fetch_char): Accept an additional argument
3104 DISP_PROP_P, and pass it to compute_display_string_pos.
3105 Only handle text covered by a display string if DISP_PROP_P is returned
3106 non-zero. All callers of bidi_fetch_char changed.
3108 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3110 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3112 2010-12-03 Don March <don@ohspite.net>
3114 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3115 last character M-[char] is translated to ESC [char] (bug#7541).
3117 2011-08-02 Kenichi Handa <handa@m17n.org>
3119 * lisp.h (uniprop_table): Extern it.
3121 * chartab.c (uniprop_table): Make it non-static.
3123 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3125 * xdisp.c (forward_to_next_line_start): Accept additional argument
3126 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3128 (reseat_at_next_visible_line_start): Use the bidi iterator state
3129 returned by forward_to_next_line_start to restore the state of
3130 it->bidi_it after backing up to previous newline. (Bug#9212)
3132 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3134 * regex.c (re_comp): Protoize.
3135 (re_exec): Fix return type.
3136 (regexec): Fix type of `ret'. (Bug#9203)
3138 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3140 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3141 This is needed if max-image-size is a floating-point number.
3143 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3145 * print.c (print_object): Print empty symbol as ##.
3147 * lread.c (read1): Read ## as empty symbol.
3149 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3151 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3152 setting frame foreground color (Bug#9175).
3153 (x_set_background_color): Likewise.
3155 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3156 contents (Bug#9176).
3157 (EmacsTooltip -init): Remove bezels and add shadows to
3160 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3161 or scroll bar (Bug#8470).
3163 * nsfont.m (nsfont_open): Remove assignment to voffset and
3164 unnecessary vars hshink, expand, hd, full_height, min_height.
3165 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3167 * nsterm.h (nsfont_info): Remove voffset field.
3169 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3171 Implement strike-through and overline on NextStep (Bug#8863).
3173 * nsfont.m (nsfont_open): Use underline position provided by font,
3174 instead of hard-coded value of 2.
3175 (nsfont_draw): Call ns_draw_text_decoration instead.
3177 * nsterm.h: Add declaration for ns_draw_text_decoration.
3179 * nsterm.m (ns_draw_text_decoration): New function for drawing
3180 underline, overline, and strike-through.
3181 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3182 ns_draw_text_decoration. Change treatment of cursor drawing to
3183 accommodate underlining, etc.
3185 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3187 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3190 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3192 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3193 Without this fix, if a signal arrives just after memory fills up,
3194 'malloc' might be invoked reentrantly.
3196 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3197 In other words, assume that every image size is allowed, on non-X
3198 hosts. This assumption is probably wrong, but it lets Emacs compile.
3200 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3202 * regex.c (re_iswctype): Convert return values to boolean.
3204 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3206 * xdisp.c (compute_display_string_pos): Don't use cached display
3207 string position if the buffer had its restriction changed.
3210 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3212 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3214 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3216 Integer signedness and overflow and related fixes. (Bug#9079)
3218 * bidi.c: Integer size and overflow fixes.
3219 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3220 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3221 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3222 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3223 (bidi_find_other_level_edge):
3224 Use ptrdiff_t instead of EMACS_INT where either will do.
3225 This works better on 32-bit hosts configured --with-wide-int.
3226 (bidi_cache_ensure_space): Check for size-calculation overflow.
3227 Use % rather than repeated addition, for better worst-case speed.
3228 Don't set bidi_cache_size until after xrealloc returns, because it
3230 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3231 (bidi_cache_ensure_space): Also check that the bidi cache size
3232 does not exceed that of the largest Lisp string or buffer. See Eli
3233 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3235 * alloc.c (__malloc_size_t): Remove.
3236 All uses replaced by size_t. See Andreas Schwab's note
3237 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3239 * image.c: Improve checking for integer overflow.
3240 (check_image_size): Assume that f is nonnull, since
3241 it is always nonnull in practice. This is one less thing to
3242 worry about when checking for integer overflow later.
3243 (x_check_image_size): New function, which checks for integer
3244 overflow issues inside X.
3245 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3246 This removes the need for a memory_full check.
3247 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3248 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3249 (xbm_read_bitmap_data): Change locals back to 'int', since
3250 their values must fit in 'int'.
3251 (xpm_load_image, png_load, tiff_load):
3252 Invoke x_create_x_image_and_pixmap earlier,
3253 to avoid much needless work if the image is too large.
3254 (tiff_load): Treat overly large images as if
3255 x_create_x_image_and_pixmap failed, not as malloc failures.
3256 (gs_load): Use x_check_image_size.
3258 * gtkutil.c: Omit integer casts.
3259 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3260 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3262 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3264 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3265 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3266 would wrongly return t on a 64-bit host.
3268 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3269 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3270 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3271 and therefore cause GCC to emit a bogus diagnostic in some cases.
3273 * image.c: Integer signedness and overflow and related fixes.
3274 This is not an exhaustive set of fixes, but it's time to
3275 record what I've got.
3276 (lookup_pixel_color, check_image_size): Remove redundant decls.
3277 (check_image_size): Don't assume that arbitrary EMACS_INT values
3278 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3279 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3280 (tiff_load, imagemagick_load_image):
3281 Check for overflow in size calculations.
3282 (x_create_x_image_and_pixmap): Remove unnecessary test for
3283 xmalloc returning NULL; that can't happen.
3284 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3285 (xpm_color_bucket): Use better integer hashing function.
3286 (xpm_cache_color): Don't possibly over-allocate memory.
3287 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3288 (gif_memory_source):
3289 Use ptrdiff_t, not int or size_t, to record sizes.
3290 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3291 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3292 either works, as we prefer signed integers.
3293 (tiff_read_from_memory, tiff_write_from_memory):
3294 Return tsize_t, not size_t, since that's what the TIFF API wants.
3295 (tiff_read_from_memory): Don't fail simply because the read would
3296 go past EOF; instead, return a short read.
3297 (tiff_load): Omit no-longer-needed casts.
3298 (Fimagemagick_types): Don't assume size fits into 'int'.
3300 Improve hashing quality when configured --with-wide-int.
3301 * fns.c (hash_string): New function, taken from sxhash_string.
3302 Do not discard information about ASCII character case; this
3303 discarding is no longer needed.
3304 (sxhash-string): Use it. Change sig to match it. Caller changed.
3305 * lisp.h: Declare it.
3306 * lread.c (hash_string): Remove, since we now use fns.c's version.
3307 The fns.c version returns a wider integer if --with-wide-int is
3308 specified, so this should help the quality of the hashing a bit.
3310 * emacs.c: Integer overflow minor fix.
3311 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3312 Define only if GNU_LINUX.
3313 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3315 * dispnew.c: Integer signedness and overflow fixes.
3316 Remove unnecessary forward decls, that were a maintenance hassle.
3317 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3319 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3320 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3321 (prepare_desired_row, line_draw_cost):
3322 Use int, not unsigned, where either works.
3323 (save_current_matrix, restore_current_matrix):
3324 Use ptrdiff_t, not size_t, where either works.
3325 (init_display): Check for overflow more accurately, and without
3326 relying on undefined behavior.
3328 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3329 Remove, replacing with the new symbols in lisp.h. All uses changed.
3330 * fileio.c (make_temp_name):
3331 * filelock.c (lock_file_1, lock_file):
3332 * xdisp.c (message_dolog):
3333 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3334 Use pMd etc. instead.
3335 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3336 replacing the pWIDE etc. symbols removed from editfns.c.
3338 * keyboard.h (num_input_events): Now uintmax_t.
3339 This is (very slightly) less likely to mess up due to wraparound.
3342 * buffer.c: Integer signedness fixes.
3343 (alloc_buffer_text, enlarge_buffer_text):
3344 Use ptrdiff_t rather than size_t when either will do, as we prefer
3347 * alloc.c: Integer signedness and overflow fixes.
3348 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3349 (__malloc_size_t): Default to size_t, not to int.
3350 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3351 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3352 Prefer ptrdiff_t to size_t when either would do, as we prefer
3354 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3355 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3356 Now const. Initialize with values that are in range even if char
3358 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3359 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3360 These functions do the right thing with sizes > 2**32.
3361 (check_depth): Now ptrdiff_t, not int.
3362 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3363 Adjust to new way of storing sizes. Check for size overflow bugs
3365 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3366 slightly wrong anyway, as it missed one instance of
3367 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3368 (refill_memory_reserve): Omit needless cast to size_t.
3369 (mark_object_loop_halt): Mark as externally visible.
3371 * xselect.c: Integer signedness and overflow fixes.
3372 (Fx_register_dnd_atom, x_handle_dnd_message):
3373 Use ptrdiff_t, not size_t, since we prefer signed.
3374 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3375 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3376 x_dnd_atoms_size and x_dnd_atoms_length.
3378 * doprnt.c: Prefer signed to unsigned when either works.
3380 * doprnt.c (doprnt):
3382 * xdisp.c (vmessage):
3383 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3384 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3385 prefer signed arithmetic to avoid comparison confusion.
3386 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3387 but is a bit tricky.
3389 Assume freestanding C89 headers, string.h, stdlib.h.
3390 * data.c, doprnt.c, floatfns.c, print.c:
3391 Include float.h unconditionally.
3392 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3393 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3394 * regex.c: Likewise for stddef.h, string.h.
3395 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3396 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3397 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3398 (STDC_HEADERS): Remove obsolete defines.
3399 * sysdep.c: Include limits.h unconditionally.
3401 Assume support for memcmp, memcpy, memmove, memset.
3402 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3403 * regex.c (memcmp, memcpy):
3404 Remove; we assume C89 now.
3406 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3407 (__malloc_safe_bcopy): Remove; no longer needed.
3409 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3410 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3411 well either way, and we prefer signed to unsigned.
3413 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3415 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3416 closes the connection while we're reading (bug#9182).
3418 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3420 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3421 are specified (Bug#9168).
3423 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3425 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3426 Found by GCC static checking and --with-wide-int on a 32-bit host.
3428 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3430 * xdisp.c (compute_display_string_pos): Fix logic of caching
3431 previous display string position. Initialize cached_prev_pos to
3432 -1. Fixes slow-down at the beginning of a buffer.
3434 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3436 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3437 for attrs[LFACE_FONTSET_INDEX].
3439 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3441 * xml.c (parse_region): Remove unused local
3442 that was recently introduced.
3444 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3446 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3447 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3449 * xdisp.c (move_it_in_display_line_to): Record the best matching
3450 position for TO_CHARPOS while scanning the line, and restore it on
3451 exit if none of the characters scanned was an exact match.
3452 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3453 when exact match is impossible due to invisible text, and the
3454 lines are truncated.
3456 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3458 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3461 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3463 Fix a significant slow-down of cursor motion with C-n, C-p,
3464 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3465 auto-repeat under bidi redisplay in fontified buffers.
3466 * xdisp.c (compute_stop_pos_backwards): New function.
3467 (next_element_from_buffer): Call compute_stop_pos_backwards to
3468 find a suitable prev_stop when we find ourselves before
3470 (reseat): Don't look for prev_stop, as that could mean a very long
3472 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3473 <cached_disp_overlay_modiff>: Cache for last found display string
3475 (compute_display_string_pos): Return the cached position if asked
3476 about the same buffer in the same area of character positions, and
3477 the buffer wasn't changed since the time the display string
3478 position was cached.
3480 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3482 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3483 is an integer, which is important for empty lines. (Bug#9149)
3485 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3487 * frame.c (Fmodify_frame_parameters): In tty case, update the
3488 default face if necessary (Bug#4238).
3490 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3492 * editfns.c (Fstring_to_char): No need to explain what a character
3493 is in the docstring (Bug#6576).
3495 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3497 * xml.c (parse_region): Make sure we always return a tree.
3499 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3501 * xml.c (parse_region): If a document contains only comments,
3504 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3506 * xml.c (make_dom): Return comments, too.
3508 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3511 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3512 and the surrounding thread.
3513 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3514 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3515 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3517 * s/openbsd.h (BROKEN_SIGIO): Define.
3518 * unexelf.c (unexec) [__OpenBSD__]:
3519 Don't update the .mdebug section of the Alpha COFF symbol table.
3521 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3523 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3526 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3528 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3529 This fixes some race conditions on the permissions of any newly
3532 * alloc.c (valid_pointer_p): Use pipe, not open.
3533 This fixes some permissions issues when debugging.
3535 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3536 If fchown fails to set both uid and gid, try to set just gid,
3537 as that is sometimes allowed. Adjust the file's mode to eliminate
3538 setuid or setgid bits that are inappropriate if fchown fails.
3540 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3542 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3543 to compare Lisp_Objects.
3544 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3545 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3546 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3548 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3550 * lread.c (read_integer): Unread even EOF character.
3551 (read1): Likewise. Properly record start position of symbol.
3553 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3554 symbol character follows.
3556 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3558 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3559 This works around a problem with the previous change to Fcopy_file.
3560 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3561 and without this change, GCC might complain about discarding
3562 fchown's return value.
3564 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3566 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3568 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3570 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3572 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3574 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3575 it's used from the C level.
3577 * process.c: Use the same condition for POLL_FOR_INPUT in both
3578 keyboard.c and process.c (bug#1858).
3580 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3582 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3583 (Fgnutls_boot): Use it.
3585 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3587 * doc.c (Fsubstitute_command_keys): Revert last change.
3589 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3591 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3592 quotes the next character, and doesn't affect other longer
3593 sequences (bug#8935).
3595 * lread.c (syms_of_lread): Clarify that is isn't only
3596 `eval-buffer' and `eval-defun' that's affected by
3597 `lexical-binding' (bug#8460).
3599 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3601 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3602 bidi redisplay when a line includes both an image and is truncated.
3604 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3606 Fix minor problems found by static checking.
3607 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3608 (elsz): Now a signed constant, not a size_t var. We prefer signed
3609 types to unsigned, to avoid integer comparison confusion. Without
3610 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3611 "cannot optimize loop, the loop counter may overflow", a symptom
3613 * indent.c (Fvertical_motion): Mark locals as initialized.
3614 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3616 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3618 * search.c (Fre_search_backward): Mention `case-fold-search' in
3619 all the re_search_* functions (bug#8138).
3621 * keyboard.c (Fopen_dribble_file): Document when the file is
3624 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3626 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3629 Support bidi reordering of display and overlay strings.
3630 * xdisp.c (compute_display_string_pos)
3631 (compute_display_string_end): Accept additional argument STRING.
3632 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3633 (reseat_to_string): Initialize bidi_it->string.s and
3634 bidi_it->string.schars.
3635 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3636 NULL (avoids a crash in bidi_paragraph_init).
3637 Initialize itb.string.lstring.
3638 (init_iterator): Call bidi_init_it only of a valid
3639 buffer position was specified. Initialize paragraph_embedding to
3641 (reseat_to_string): Initialize the bidi iterator.
3642 (display_string): If we need to ignore text properties of
3643 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3644 original value of -1 will not work with bidi.)
3645 (compute_display_string_pos): First arg is now struct
3646 `text_pos *'; all callers changed. Support display properties on
3648 (compute_display_string_end): Support display properties on Lisp
3650 (init_iterator, reseat_1, reseat_to_string): Initialize the
3651 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3652 when iterating on a string not from display properties).
3653 (compute_display_string_pos, compute_display_string_end):
3654 Fix calculation of the object to scan. Fixes an error when using
3656 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3657 base_level_stop; instead, set base_level_stop to BEGV.
3658 Fixes crashes in vertical-motion.
3659 (next_element_from_buffer): Improve commentary for when
3660 the iterator is before prev_stop.
3661 (init_iterator): Initialize bidi_p from the default value of
3662 bidi-display-reordering, not from buffer-local value. Use the
3663 buffer-local value only if initializing for buffer iteration.
3664 (handle_invisible_prop): Support invisible properties on strings
3665 that are being bidi-reordered.
3666 (set_iterator_to_next): Support bidi reordering of C strings and
3668 (next_element_from_string): Support bidi reordering of Lisp
3670 (handle_stop_backwards): Support Lisp strings as well.
3671 (display_string): Support display of R2L glyph rows.
3672 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3673 (init_iterator): Don't initialize it->bidi_p for strings
3675 (reseat_to_string): Initialize it->bidi_p for strings here.
3676 (next_element_from_string, next_element_from_c_string)
3677 (next_element_from_buffer): Add xassert's for correspondence
3678 between IT's object being iterated and it->bidi_it.string
3680 (face_before_or_after_it_pos): Support bidi iteration.
3681 (next_element_from_c_string): Handle the case of the first string
3682 character that is not the first one in the visual order.
3683 (get_visually_first_element): New function, refactored from common
3684 parts of next_element_from_buffer, next_element_from_string, and
3685 next_element_from_c_string.
3686 (tool_bar_lines_needed, redisplay_tool_bar)
3687 (display_menu_bar): Force left-to-right direction. Add a FIXME
3688 comment for making that be controlled by a user option.
3689 (push_it, pop_it): Save and restore the state of the
3690 bidi iterator. Save and restore the bidi_p flag.
3691 (pop_it): Iterate out of display property for string iteration as
3693 (iterate_out_of_display_property): Support iteration over strings.
3694 (handle_single_display_spec): Set up it->bidi_it for iteration
3695 over a display string, and call bidi_init_it.
3696 (handle_single_display_spec, next_overlay_string)
3697 (get_overlay_strings_1, push_display_prop): Set up the bidi
3698 iterator for displaying display or overlay strings.
3699 (forward_to_next_line_start): Don't use the shortcut if
3701 (back_to_previous_visible_line_start): If handle_display_prop
3702 pushed the iterator stack, restore the internal state of the bidi
3703 iterator by calling bidi_pop_it same number of times.
3704 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3705 and we are bidi-iterating, don't decrement the iterator position;
3706 instead, set the first_elt flag in the bidi iterator, to produce
3708 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3709 (push_display_prop): xassert that we are iterating a buffer.
3710 (push_it, pop_it): Save and restore paragraph_embedding member.
3711 (handle_single_display_spec, next_overlay_string)
3712 (get_overlay_strings_1, reseat_1, reseat_to_string)
3713 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3714 correctly. Don't assume unibyte strings are not bidi-reordered.
3715 (compute_display_string_pos)
3716 (compute_display_string_end): Fix handling the case of C string.
3717 (push_it, pop_it): Save and restore from_disp_prop_p.
3718 (handle_single_display_spec, push_display_prop): Set the
3719 from_disp_prop_p flag.
3720 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3721 (pop_it): Call iterate_out_of_display_property only if we are
3722 popping after iteration over a string that came from a display
3723 property. Fix a typo in popping stretch info. Add an assertion
3724 for verifying that the iterator position is in sync with the bidi
3726 (handle_single_display_spec, get_overlay_strings_1)
3727 (push_display_prop): Fix initialization of paragraph direction for
3728 string when that of the parent object is not yet determined.
3729 (reseat_1): Call bidi_init_it to resync the bidi
3730 iterator with IT's position. (Bug#7616)
3731 (find_row_edges): If ROW->start.pos gives position
3732 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3733 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3734 Reset the from_disp_prop_p flag.
3735 (SAVE_IT, RESTORE_IT): New macros.
3736 (pos_visible_p, face_before_or_after_it_pos)
3737 (back_to_previous_visible_line_start)
3738 (move_it_in_display_line_to, move_it_in_display_line)
3739 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3740 (try_scrolling, redisplay_window, display_line): Use them when
3741 saving a temporary copy of the iterator and restoring it back.
3742 (back_to_previous_visible_line_start, reseat_1)
3743 (init_iterator): Empty the bidi cache "stack".
3744 (move_it_in_display_line_to): If iterator ended up at
3745 EOL, but we never saw any buffer positions smaller than
3746 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3747 motion in bidi-reordered lines.
3748 (move_it_in_display_line_to): Record prev_method and prev_pos
3749 immediately before the call to set_iterator_to_next. Fixes cursor
3750 motion in bidi-reordered lines with stretch glyphs and strings
3751 displayed in margins. (Bug#8133) (Bug#8867)
3752 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3754 (pos_visible_p): Support positions in bidi-reordered lines.
3755 Save and restore bidi cache.
3757 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3758 (bidi_paragraph_info): Delete unused struct.
3759 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3760 (bidi_cache_start): New variable.
3761 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3763 (bidi_cache_fetch_state, bidi_cache_search)
3764 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3765 (bidi_cache_find, bidi_peek_at_next_level)
3766 (bidi_level_of_next_char, bidi_find_other_level_edge)
3767 (bidi_move_to_visually_next): Compare cache index with
3768 bidi_cache_start rather than with zero.
3769 (bidi_fetch_char): Accept new argument STRING; all callers
3770 changed. Support iteration over a string. Support strings with
3771 display properties. Support unibyte strings. Fix the type of
3772 `len' according to what STRING_CHAR_AND_LENGTH expects.
3773 (bidi_paragraph_init, bidi_resolve_explicit_1)
3774 (bidi_resolve_explicit, bidi_resolve_weak)
3775 (bidi_level_of_next_char, bidi_move_to_visually_next):
3776 Support iteration over a string.
3777 (bidi_set_sor_type, bidi_resolve_explicit_1)
3778 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3779 can now be zero (for strings); special values 0 and -1 were
3780 changed to -1 and -2, respectively.
3781 (bidi_char_at_pos): New function.
3782 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3783 Call it instead of FETCH_MULTIBYTE_CHAR.
3784 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3785 initialized to valid values.
3786 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3788 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3789 the test for valid cached positions. Fix the logic for looking up
3790 the sentinel state in the cache. GCPRO the Lisp string we are
3792 (bidi_push_it, bidi_pop_it): New functions.
3793 (bidi_initialize): Initialize the bidi cache start stack pointer.
3794 (bidi_cache_ensure_space): New function, refactored from part of
3795 bidi_cache_iterator_state. Don't assume the required size is just
3796 one BIDI_CACHE_CHUNK away.
3797 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3798 (bidi_count_bytes, bidi_char_at_pos): New functions.
3799 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3800 always valid if bidi_cache_idx is valid.
3801 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3802 is valid if it's going to be used.
3803 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3804 (bidi_cache_fetch_state, bidi_cache_search)
3805 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3806 (bidi_cache_iterator_state, bidi_cache_find)
3807 (bidi_find_other_level_edge, bidi_cache_start_stack):
3808 All variables related to cache indices are now EMACS_INT.
3810 * dispextern.h (struct bidi_string_data): New structure.
3811 (struct bidi_it): New member `string'. Make flag members be 1-bit
3812 fields, and put them last in the struct.
3813 (compute_display_string_pos, compute_display_string_end):
3815 (bidi_push_it, bidi_pop_it): Add prototypes.
3816 (struct iterator_stack_entry): New members bidi_p,
3817 paragraph_embedding, and from_disp_prop_p.
3818 (struct it): Member bidi_p is now a bit field 1 bit wide.
3819 (bidi_shelve_cache, bidi_unshelve_cache):
3822 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3823 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3824 and vector-like objects.
3826 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3827 cache around display iteration.
3829 * window.c (Fwindow_end, window_scroll_pixel_based)
3830 (displayed_window_lines, Frecenter): Save and restore the bidi
3831 cache around display iteration.
3833 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3835 * editfns.c (Fdelete_region): Clarify the use of the named
3836 parameters (bug#6788).
3838 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3840 * indent.c (Fvertical_motion): Set and restore w->pointm when
3841 saving and restoring the window's buffer (Bug#9006).
3843 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3845 * editfns.c (Fstring_to_char): Clarify just what is returned
3846 (bug#6576). Text by Eli Zaretskii.
3848 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3850 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3852 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3854 * buffer.c (mmap_find): Fix a typo.
3856 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3858 Fix execution of x selection hooks.
3859 * xselect.c (Qx_lost_selection_functions)
3860 (Qx_sent_selection_functions): New vars.
3861 (syms_of_xselect): DEFSYM them.
3862 (x_handle_selection_request): Pass Qx_sent_selection_functions
3863 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3864 (x_handle_selection_clear,x_clear_frame_selections):
3865 Pass Qx_lost_selection_functions rather than
3866 Vx_lost_selection_functions to Frun_hook_with_args.
3868 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3870 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3871 The old code sometimes used this field without initializing it.
3873 * alloc.c (gc_sweep): Don't read past end of array.
3874 In theory, the old code could also have corrupted Emacs internals,
3875 though it'd be very unlikely.
3877 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3879 * character.c (Fcharacterp): Don't advertise optional ignored
3880 argument. (Bug#4026)
3882 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3884 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3887 * window.c (Fset_window_start): Doc fix (bug#4199).
3888 (Fset_window_hscroll): Ditto.
3890 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3892 Fix minor new problems caught by GCC 4.6.1.
3893 * term.c (init_tty): Remove unused local.
3894 * xsettings.c (store_monospaced_changed): Define this function only
3895 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3898 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3900 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3902 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3904 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3905 are the mini-buffer and the echo area (bug#3320).
3907 * term.c (init_tty): Remove support for supdup, c10 and perq
3908 terminals, which are no longer supported (bug#1482).
3910 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3912 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3914 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3916 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3917 for non-popups (Bug#3642).
3919 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3921 * alloc.c (reset_malloc_hooks): Protoize.
3922 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3923 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3924 * cm.c (losecursor): Likewise.
3925 * data.c (fmod): Likewise.
3926 * dispnew.c (swap_glyphs_in_rows): Likewise.
3927 * emacs.c (memory_warning_signal): Likewise.
3928 * floatfns.c (float_error): Likewise.
3929 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3930 (otf_open, font_otf_capability, generate_otf_features)
3931 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3933 * image.c (pbm_read_file): Likewise.
3934 * indent.c (string_display_width): Likewise.
3935 * intervals.c (check_for_interval, search_for_interval)
3936 (inc_interval_count, count_intervals, root_interval)
3937 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3938 * lread.c (defalias): Likewise.
3939 * ralloc.c (r_alloc_check): Likewise.
3940 * regex.c (set_image_of_range_1, set_image_of_range)
3941 (regex_grow_registers): Likewise.
3942 * sysdep.c (strerror): Likewise.
3943 * termcap.c (valid_filename_p, tprint, main): Likewise.
3944 * tparam.c (main): Likewise.
3945 * unexhp9k800.c (run_time_remap, save_data_space)
3946 (update_file_ptrs, read_header, write_header, calculate_checksum)
3947 (copy_file, copy_rest, display_header): Likewise.
3948 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3950 * xdisp.c (check_it): Likewise.
3951 * xfaces.c (register_color, unregister_color, unregister_colors):
3953 * xfns.c (print_fontset_result): Likewise.
3954 * xrdb.c (member, fatal, main): Likewise.
3956 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3958 Fix minor problems found by static checking (Bug#9031).
3959 * chartab.c (char_table_set_range, map_sub_char_table):
3960 Remove unused locals.
3961 (uniprop_table): Now static.
3962 * composite.c (_work_char): Remove unused static var.
3964 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3966 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3968 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3970 * gtkutil.c (qttip_cb): Remove code without function.
3972 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3974 * w32.c (pthread_sigmask): New stub.
3976 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3978 Use pthread_sigmask, not sigprocmask (Bug#9010).
3979 sigprocmask is portable only for single-threaded applications, and
3980 Emacs can be multi-threaded when it uses GTK.
3981 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3983 * callproc.c (Fcall_process):
3984 * process.c (create_process):
3985 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3986 Use pthread_sigmask, not sigprocmask.
3988 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3990 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3991 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3994 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3996 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3997 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3998 (xg_hide_tooltip): Fix comment.
4000 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4001 in registerServicesMenuSendTypes.
4002 (validRequestorForSendType): Don't check ns_return_types.
4004 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4007 2011-07-08 Jason Rumney <jasonr@gnu.org>
4009 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4010 SH_SHOW for hidden windows (Bug#5482).
4012 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4013 frame struct members of non-existent frames (Bug#6284).
4015 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4017 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4018 variable firstTime not needed on OSX >= 10.6.
4019 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4020 >= 10.5. Use setKnobProportion, setDoubleValue.
4022 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4023 (MAC_OS_X_VERSION_10_5): Define if not defined.
4024 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4025 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4026 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4028 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4029 cString and lossyCString on OSX >= 10.4
4031 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4032 sizeToFit on OSX >= 10.2.
4034 * nsimage.m (allocInitFromFile): Don't use deprecated method
4035 bestRepresentationForDevice on OSX >= 10.6.
4037 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4040 * emacs.c: Declare unexec_init_emacs_zone.
4042 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4044 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4046 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4047 on svcsMenu (Bug#8842).
4049 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4051 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4053 * nsterm.m (QUTF8_STRING): Declare.
4054 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4055 (validRequestorForSendType): Return type is (id).
4056 Change indexOfObjectIdenticalTo to indexOfObject.
4057 Check if we have local selection before returning self (Bug#8842).
4058 (writeSelectionToPasteboard): Put local selection into paste board
4059 if we have a local selection (Bug#8842).
4060 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4062 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4063 (ns_get_local_selection): Declare.
4065 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4067 * keymap.c (describe_map_tree): Don't insert a double newline at
4068 the end of the buffer (bug#1169) and return whether we inserted
4071 * callint.c (Fcall_interactively): Change "reading args" to
4072 "providing args" to try to clarify what it does (bug#1010).
4074 2011-07-07 Kenichi Handa <handa@m17n.org>
4076 * composite.c (composition_compute_stop_pos): Ignore a static
4077 composition starting before CHARPOS (Bug#8915).
4079 * xdisp.c (handle_composition_prop): Likewise.
4081 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4083 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4086 2011-07-07 Kenichi Handa <handa@m17n.org>
4088 * character.h (unicode_category_t): New enum type.
4090 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4091 (Qchar_code_property_table): New variable.
4092 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4093 (UNIPROP_COMPRESSED_FORM_P): New macros.
4094 (char_table_ascii): Uncompress the compressed values.
4095 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4096 Uncompress the compressed values.
4097 (sub_char_table_ref_and_range): Likewise.
4098 (char_table_ref_and_range): Uncompress the compressed values.
4099 (sub_char_table_set): New arg is_uniprop. Callers changed.
4100 Uncompress the compressed values.
4101 (sub_char_table_set_range): Args changed. Callers changed.
4102 (char_table_set_range): Adjuted for the above change.
4103 (map_sub_char_table): Delete args default_val and parent. Add arg
4104 top. Give decoded values to a Lisp function.
4105 (map_char_table): Adjust for the above change. Give decoded
4106 values to a Lisp function. Gcpro more variables.
4107 (uniprop_table_uncompress)
4108 (uniprop_decode_value_run_length): New functions.
4109 (uniprop_decoder, uniprop_decoder_count): New variables.
4110 (uniprop_get_decoder, uniprop_encode_value_character)
4111 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4113 (uniprop_encoder, uniprop_encoder_count): New variables.
4114 (uniprop_get_encoder, uniprop_table)
4115 (Funicode_property_table_internal, Fget_unicode_property_internal)
4116 (Fput_unicode_property_internal): New functions.
4117 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4118 Sunicode_property_table_internal, Sget_unicode_property_internal,
4119 and Sput_unicode_property_internal. Defvar_lisp
4120 char-code-property-alist.
4122 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4123 Vunicode_category_table.
4125 * font.c (font_range): Adjust for the change of
4126 Vunicode_category_table.
4128 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4130 * m/iris4d.h: Remove file, move contents ...
4131 * s/irix6-5.h: ... here.
4133 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4135 Remove unportable assumption about struct layout (Bug#8884).
4136 * alloc.c (mark_buffer):
4137 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4138 (clone_per_buffer_values): Don't assume that
4139 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4140 This isn't true in general, and it's particularly not true
4141 if Emacs is configured with --with-wide-int.
4142 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4143 New macros, used in the buffer.c change.
4145 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4147 * xsettings.c: Use both GConf and GSettings if both are available.
4148 (store_config_changed_event): Add comment.
4149 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4150 (store_tool_bar_style_changed): New functions.
4151 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4152 (struct xsettings): Move font inside HAVE_XFT.
4153 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4154 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4155 Move inside HAVE_XFT.
4156 (something_changed_gsettingsCB): Rename from something_changedCB.
4157 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4159 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4160 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4161 (something_changed_gconfCB): Rename from something_changedCB.
4162 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4163 (parse_settings): Move check for font inside HAVE_XFT.
4164 (read_settings, apply_xft_settings): Add comment.
4165 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4166 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4167 call store_font_name_changed.
4168 (xft_settings_event): Add comment.
4169 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4170 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4171 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4172 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4173 (xsettings_initialize): Call init_gsettings last.
4174 (xsettings_get_system_font, xsettings_get_system_normal_font):
4177 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4179 Random fixes. E.g., (random) never returned negative values.
4180 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4181 subseconds part to the entropy, as that's a bit more random.
4182 Prefer signed to unsigned, since the signedness doesn't matter and
4183 in general we prefer signed. When given a limit, use a
4184 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4185 latter isn't right if USE_2_TAGS_FOR_INTS.
4186 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4187 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4189 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4191 * textprop.c (text_property_stickiness):
4192 Obey Vtext_property_default_nonsticky.
4193 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4194 * w32fns.c (syms_of_w32fns):
4195 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4197 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4199 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4200 This is more efficient than Ffile_directory_p and avoids a minor race.
4202 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4204 * buffer.c (Foverlay_put): Say what the return value is
4207 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4208 is a directory before asking whether to use the file name
4210 (barf_or_query_if_file_exists): Make the "File is a directory"
4211 error be more correct.
4213 * fns.c (Frequire): Remove the mention of the .gz files, since
4214 that's installation-specific, but keep the mention of
4215 `get-load-suffixes'.
4217 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4219 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4220 Report string overflow if the output is too long.
4222 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4224 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4225 (syms_of_gnutls): Remove duplicate DEFSYM for
4226 Qgnutls_bootprop_verify_hostname_error, an error for
4227 Qgnutls_bootprop_verify_error (which is no longer used).
4229 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4230 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4231 Also (re)move comments that are misplaced or no longer relevant.
4233 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4235 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4237 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4239 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4240 and background color parameters if they have been changed.
4242 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4244 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4246 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4248 * xsettings.c (SYSTEM_FONT): Define only when used.
4249 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4251 * keymap.c (access_keymap_1): Now static.
4253 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4255 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4256 leave any prefix arg for the up event (Bug#1586).
4258 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4260 * lread.c (syms_of_lread): Mention single symbols defined by
4261 `defvar' or `defconst' (bug#7154).
4263 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4264 (Frequire): Mention get-load-suffixes.
4266 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4268 * window.h (window): Remove clone_number slot.
4269 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4271 (make_parent_window, make_window, saved_window)
4272 (Fset_window_configuration, save_window_save): Don't deal with
4274 * buffer.c (Qclone_number): Remove declaration.
4275 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4277 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4279 Add multiple inheritance to keymaps.
4280 * keymap.c (Fmake_composed_keymap): New function.
4281 (Fset_keymap_parent): Simplify.
4282 (fix_submap_inheritance): Remove.
4283 (access_keymap_1): New function extracted from access_keymap to handle
4284 embedded parents and handle lists of maps.
4285 (access_keymap): Use it.
4286 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4287 (Fcopy_keymap): Handle embedded parents.
4288 (Fcommand_remapping, define_as_prefix): Simplify.
4289 (Fkey_binding): Simplify.
4290 (syms_of_keymap): Move minibuffer-local-completion-map,
4291 minibuffer-local-filename-completion-map,
4292 minibuffer-local-must-match-map, and
4293 minibuffer-local-filename-must-match-map to Elisp.
4294 (syms_of_keymap): Defsubr make-composed-keymap.
4295 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4296 (parse_menu_item): Trivial simplification.
4298 2011-07-01 Glenn Morris <rgm@gnu.org>
4300 * Makefile.in (SETTINGS_LIBS): Fix typo.
4302 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4304 * coding.c (Fencode_coding_string): Record the last coding system
4305 used, as the function doc string says (bug#8738).
4307 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4309 * xsettings.c (store_monospaced_changed): Take new font as arg and
4310 check for change against current_mono_font.
4311 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4312 (emacs_settings_constructor, emacs_settings_get_property)
4313 (emacs_settings_set_property, emacs_settings_class_init)
4314 (emacs_settings_init, gsettings_obj): Remove.
4315 (something_changedCB): New function for HAVE_GSETTINGS.
4316 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4317 with value as argument.
4318 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4319 g_settings_new (Bug#8967). Do not create gsettings_obj.
4320 Remove calls to g_settings_bind. Connect something_changedCB to
4323 * xgselect.c: Add defined (HAVE_GSETTINGS).
4324 (xgselect_initialize): Ditto.
4326 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4327 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4330 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4332 * eval.c (struct backtrace): Simplify and port the data structure.
4333 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4334 signed bit field, as this assumption is not portable and it makes
4335 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4336 "char debug_on_exit : 1" as this is not portable either; instead,
4337 use the portable "unsigned int debug_on_exit : 1". Remove unused
4338 member evalargs. Remove obsolete comments about cc bombing out.
4340 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4342 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4343 Let HAVE_GSETTINGS override HAVE_GCONF.
4344 (store_monospaced_changed): New function.
4345 (EMACS_SETTINGS): A new type derived from GObject to handle
4346 GSettings notifications.
4347 (emacs_settings_constructor, emacs_settings_get_property)
4348 (emacs_settings_set_property, emacs_settings_class_init):
4350 (gsettings_client, gsettings_obj): New variables.
4351 (GSETTINGS_SCHEMA): New define.
4352 (something_changedCB): Call store_monospaced_changed.
4353 (init_gsettings): New function.
4354 (xsettings_initialize): Call init_gsettings.
4355 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4358 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4361 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4363 * window.c (resize_root_window, grow_mini_window)
4364 (shrink_mini_window): Rename Qresize_root_window to
4365 Qwindow_resize_root_window and Qresize_root_window_vertically to
4366 Qwindow_resize_root_window_vertically.
4368 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4370 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4372 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4374 * makefile.w32-in: Redesign dependencies so they reflect more
4375 clearly which files are directly included by each source file,
4376 and not through other includes.
4378 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4380 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4381 (sort_overlays, overlay_strings): When an overlay's clone number
4382 matches the window's clone number process the overlay even if
4383 the overlay's window property doesn't match the current window.
4385 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4386 (Fwindow_hchild): Rename to Fwindow_left_child.
4387 (Fwindow_next): Rename to Fwindow_next_sibling.
4388 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4389 (resize_window_check): Rename to window_resize_check.
4390 (resize_window_apply): Rename to window_resize_apply.
4391 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4392 (Fdelete_other_windows_internal, resize_frame_windows)
4393 (Fsplit_window_internal, Fdelete_window_internal)
4394 (grow_mini_window, shrink_mini_window)
4395 (Fresize_mini_window_internal): Fix callers accordingly.
4397 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4399 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4400 (emacs_fixed_set_min_size): Remove.
4401 (emacs_fixed_new): Take frame as argument.
4403 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4404 (_EmacsFixedPrivate): Remove minwidth/height.
4405 Add struct frame *f.
4406 (emacs_fixed_init): Initialize priv->f.
4407 (get_parent_class, emacs_fixed_set_min_size): Remove.
4408 (emacs_fixed_new): Set priv->f to argument.
4409 (emacs_fixed_get_preferred_width)
4410 (emacs_fixed_get_preferred_height): Use min_width/height from
4411 frames size_hint to set minimum and natural (Bug#8919).
4412 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4413 and use min_width/height from frames size_hint to set
4414 min_width/height (Bug#8919).
4416 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4417 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4420 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4422 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4423 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4426 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4428 * process.c (wait_reading_process_output): Bypass select if
4429 waiting for a cell while ignoring keyboard input, and input is
4430 pending. Suggested by Jan Djärv (Bug#8869).
4432 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4434 Use gnulib's dup2 module instead of rolling our own.
4435 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4437 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4439 * dispnew.c (scrolling_window): Before scrolling, turn off a
4440 mouse-highlight in the window being scrolled.
4442 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4444 Move DEFSYM to lisp.h and use everywhere.
4446 * character.h (DEFSYM): Move declaration...
4447 * lisp.h (DEFSYM): ...here.
4453 * w32select.c: Don't include character.h.
4455 * alloc.c (syms_of_alloc):
4456 * buffer.c (syms_of_buffer):
4457 * bytecode.c (syms_of_bytecode):
4458 * callint.c (syms_of_callint):
4459 * casefiddle.c (syms_of_casefiddle):
4460 * casetab.c (init_casetab_once):
4461 * category.c (init_category_once, syms_of_category):
4462 * ccl.c (syms_of_ccl):
4463 * cmds.c (syms_of_cmds):
4464 * composite.c (syms_of_composite):
4465 * dbusbind.c (syms_of_dbusbind):
4466 * dired.c (syms_of_dired):
4467 * dispnew.c (syms_of_display):
4468 * doc.c (syms_of_doc):
4469 * editfns.c (syms_of_editfns):
4470 * emacs.c (syms_of_emacs):
4471 * eval.c (syms_of_eval):
4472 * fileio.c (syms_of_fileio):
4473 * fns.c (syms_of_fns):
4474 * frame.c (syms_of_frame):
4475 * fringe.c (syms_of_fringe):
4476 * insdel.c (syms_of_insdel):
4477 * keymap.c (syms_of_keymap):
4478 * lread.c (init_obarray, syms_of_lread):
4479 * macros.c (syms_of_macros):
4480 * msdos.c (syms_of_msdos):
4481 * print.c (syms_of_print):
4482 * process.c (syms_of_process):
4483 * search.c (syms_of_search):
4484 * sound.c (syms_of_sound):
4485 * syntax.c (init_syntax_once, syms_of_syntax):
4486 * terminal.c (syms_of_terminal):
4487 * textprop.c (syms_of_textprop):
4488 * undo.c (syms_of_undo):
4489 * w32.c (globals_of_w32):
4490 * window.c (syms_of_window):
4491 * xdisp.c (syms_of_xdisp):
4492 * xfaces.c (syms_of_xfaces):
4493 * xfns.c (syms_of_xfns):
4494 * xmenu.c (syms_of_xmenu):
4495 * xsettings.c (syms_of_xsettings):
4496 * xterm.c (syms_of_xterm): Use DEFSYM.
4498 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4500 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4502 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4504 Integer and buffer overflow fixes (Bug#8873).
4506 * print.c (printchar, strout): Check for string overflow.
4507 (PRINTPREPARE, printchar, strout):
4508 Don't set size unless allocation succeeds.
4510 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4511 for sizes. Check for string overflow more accurately.
4512 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4514 * macros.c: Integer and buffer overflow fixes.
4515 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4516 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4517 Use ptrdiff_t, not int, for sizes.
4518 Don't increment bufsize until after realloc succeeds.
4519 Check for size-calculation overflow.
4520 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4522 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4524 * lread.c: Integer overflow fixes.
4525 (read_integer): Radix is now EMACS_INT, not int,
4526 to improve quality of diagnostics for out-of-range radices.
4527 Calculate buffer size correctly for out-of-range radices.
4528 (read1): Check for integer overflow in radices, and in
4529 read-circle numbers.
4530 (read_escape): Avoid int overflow.
4531 (Fload, openp, read_buffer_size, read1)
4532 (substitute_object_recurse, read_vector, read_list, map_obarray):
4533 Use ptrdiff_t, not int, for sizes.
4534 (read1): Use EMACS_INT, not int, for sizes.
4535 Check for size overflow.
4537 * image.c (cache_image): Check for size arithmetic overflow.
4539 * lread.c: Integer overflow issues.
4540 (saved_doc_string_size, saved_doc_string_length)
4541 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4542 Now ptrdiff_t, not int.
4543 (read1): Don't assume doc string length fits in int. Check for
4544 out-of-range doc string lengths.
4545 (read_list): Don't assume file position fits in int.
4546 (read_escape): Check for hex character overflow.
4548 2011-06-22 Leo Liu <sdl.web@gmail.com>
4550 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4551 Move to minibuffer.el.
4553 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4555 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4556 The following patches are for when GLYPH_DEBUG && !XASSERT.
4557 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4558 * dispnew.c (flush_stdout):
4559 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4560 Mark as externally visible.
4561 * dispnew.c (check_window_matrix_pointers): Now static.
4562 * dispnew.c (window_to_frame_vpos):
4563 * xfns.c (unwind_create_frame):
4564 * xterm.c (x_check_font): Remove unused local.
4565 * scroll.c (CHECK_BOUNDS):
4566 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4567 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4568 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4569 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4570 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4572 (debug_method_add): Use va_list and vsprintf rather than relying
4573 on undefined behavior with wrong number of arguments.
4574 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4575 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4576 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4577 since we're not interested in debugging glyphs with old libraries.
4578 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4579 GCC 4.6.0's static checking.
4581 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4583 Integer overflow and signedness fixes (Bug#8873).
4584 A few related buffer overrun fixes, too.
4586 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4588 * dispextern.h (struct face.stipple):
4589 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4590 (x_bitmap_mask, x_allocate_bitmap_record)
4591 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4592 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4593 (x_create_bitmap_from_xpm_data):
4594 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4595 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4597 * xfaces.c (load_pixmap):
4598 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4599 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4600 (.bitmaps_last, struct x_output.icon_bitmap):
4601 Use ptrdiff_t, not int, for bitmap indexes.
4602 (x_allocate_bitmap_record): Check for size overflow.
4603 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4605 Use ptrdiff_t, not int, for overlay counts.
4606 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4607 * editfns.c (overlays_around, get_pos_property):
4608 * textprop.c (get_char_property_and_overlay):
4609 * xdisp.c (next_overlay_change, note_mouse_highlight):
4610 * xfaces.c (face_at_buffer_position):
4611 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4612 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4613 (Fnext_overlay_change, Fprevious_overlay_change)
4614 (mouse_face_overlay_overlaps, Foverlays_in):
4615 Use ptrdiff_t, not int, for sizes.
4616 (overlays_at, overlays_in): Check for size-calculation overflow.
4618 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4620 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4621 (x_session_initialize): Do not assume string length fits in int.
4623 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4624 This is unlikely, but can occur if DPI is outlandish.
4626 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4627 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4629 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4630 * xrdb.c (magic_file_p, search_magic_path):
4631 Omit last arg SUFFIX; it was always 0. All callers changed.
4632 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4634 * xfont.c (xfont_match): Avoid need for strlen.
4636 * xfns.c: Don't assume strlen fits in int.
4637 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4639 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4640 not unsigned long, as we prefer signed integers. All callers changed.
4641 Detect integer overflow in repeat count.
4642 (message_dolog): Don't assume print length fits in 39 bytes.
4643 (display_mode_element): Don't assume strlen fits in int.
4645 * termcap.c: Don't assume sizes fit in int and never overflow.
4646 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4647 (gobble_line): Check for size-calculation overflow.
4649 * minibuf.c (Fread_buffer):
4650 * lread.c (intern, intern_c_string):
4651 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4652 Don't assume string length fits in int.
4654 * keyboard.c (parse_tool_bar_item):
4655 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4657 * font.c: Don't assume string length fits in int.
4658 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4659 Use ptrdiff_t, not int.
4660 (font_intern_prop): Don't assume string length fits in int.
4661 Don't assume integer property fits in fixnum.
4662 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4664 * filelock.c: Fix some buffer overrun and integer overflow issues.
4665 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4666 Reformulate so as not to need the command string.
4667 Invoke gzip -cd rather than gunzip, as it's more portable.
4668 (lock_info_type, lock_file_1, lock_file):
4669 Don't assume pid_t and time_t fit in unsigned long.
4670 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4671 (current_lock_owner): Prefer signed type for sizes.
4672 Use memcpy, not strncpy, where memcpy is what is really wanted.
4673 Don't assume (via atoi) that time_t and pid_t fit in int.
4674 Check for time_t and/or pid_t out of range, e.g., via a network share.
4675 Don't alloca where an auto var works fine.
4677 * fileio.c: Fix some integer overflow issues.
4678 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4679 Don't assume string length fits in int.
4680 (directory_file_name): Don't assume string length fits in long.
4681 (make_temp_name): Don't assume pid fits in int, or that its print
4682 length is less than 20.
4684 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4686 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4688 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4690 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4691 We prefer signed integers, even for size calculations.
4693 * emacs.c: Don't assume string length fits in 'int'.
4694 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4695 (main): Don't invoke strlen when not needed.
4697 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4698 (XD_DEBUG_MESSAGE): Don't waste a byte.
4700 * callproc.c (getenv_internal_1, getenv_internal)
4702 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4704 * lread.c (invalid_syntax): Omit length argument.
4705 All uses changed. This doesn't fix a bug, but it simplifies the
4706 code away from its former Hollerith-constant appearance, and it's
4707 one less 'int' to worry about when looking at integer-overflow issues.
4708 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4710 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4711 This didn't break anything, but it didn't help either.
4712 It's confusing to put a bogus integer in a place where the actual
4713 value does not matter.
4714 (LIST_END_P): Remove unused macro and its bogus comment.
4715 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4717 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4718 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4720 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4721 We prefer signed types, and the value cannot exceed the EMACS_INT
4722 range anyway (because otherwise the length would not be representable).
4723 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4724 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4725 This avoids a GCC warning when WIDE_EMACS_INT.
4727 * indent.c (sane_tab_width): New function.
4728 (current_column, scan_for_column, Findent_to, position_indentation)
4729 (compute_motion): Use it. This is just for clarity.
4730 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4732 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4734 * lisp.h (lint_assume): New macro.
4735 * composite.c (composition_gstring_put_cache):
4736 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4738 * editfns.c, insdel.c:
4739 Omit unnecessary forward decls, to simplify future changes.
4741 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4743 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4745 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4746 Use much-faster test for byte-length change.
4747 Don't assume string byte-length fits in 'int'.
4748 Check that character arg fits in 'int'.
4749 (mapcar1): Declare byte as byte, for clarity.
4751 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4753 * fns.c (concat): Catch string overflow earlier.
4754 Do not rely on integer wraparound.
4756 * dispextern.h (struct it.overlay_strings_charpos)
4757 (struct it.selective): Now EMACS_INT, not int.
4758 * xdisp.c (forward_to_next_line_start)
4759 (back_to_previous_visible_line_start)
4760 (reseat_at_next_visible_line_start, next_element_from_buffer):
4761 Don't arbitrarily truncate the value of 'selective' to int.
4763 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4765 * composite.c: Don't truncate sizes to 'int'.
4766 (composition_gstring_p, composition_reseat_it)
4767 (composition_adjust_point): Use EMACS_INT, not int.
4768 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4769 not EMACS_UINT, for indexes.
4771 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4773 * buffer.c: Include <verify.h>.
4774 (struct sortvec.priority, struct sortstr.priority):
4775 Now EMACS_INT, not int.
4776 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4777 (struct sortstr.size, record_overlay_string)
4778 (struct sortstrlist.size, struct sortlist.used):
4779 Don't truncate size to int.
4780 (record_overlay_string): Check for size-calculation overflow.
4781 (init_buffer_once): Check at compile-time, not run-time.
4783 2011-06-22 Jim Meyering <meyering@redhat.com>
4785 Don't leak an XBM-image-sized buffer
4786 * image.c (xbm_load): Free the image buffer after using it.
4788 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4791 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4792 that Sun C diagnosed.
4793 * fns.c (secure_hash): Fix pointer signedness issue.
4794 * intervals.c (static_offset_intervals): New function.
4795 (offset_intervals): Use it.
4797 2011-06-21 Leo Liu <sdl.web@gmail.com>
4800 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4803 * fns.c (secure_hash): Rename from crypto_hash_function and change
4804 the first arg to accept symbols.
4805 (Fsecure_hash): New primitive.
4806 (syms_of_fns): New symbols.
4808 2011-06-20 Deniz Dogan <deniz@dogan.se>
4810 * process.c (Fset_process_buffer): Clarify return value in
4813 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4815 * dispnew.c (add_window_display_history): Use BVAR.
4817 * xdisp.c (debug_method_add): Use BVAR.
4818 (check_window_end, dump_glyph_matrix, dump_glyph)
4819 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4821 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4824 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4825 check till after the cache is created in init_frame_faces.
4827 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4829 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4831 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4833 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4834 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4835 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4837 Improve buffer-overflow checking (Bug#8873).
4838 * fileio.c (Finsert_file_contents):
4839 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4840 Remove the old (too-loose) buffer overflow checks.
4841 They weren't needed, since make_gap checks for buffer overflow.
4842 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4843 The old code merely checked for Emacs fixnum overflow, and relied
4844 on undefined (wraparound) behavior. The new code avoids undefined
4845 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4847 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4848 Tune. Don't use wider integers than needed. Don't use alloca.
4849 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4851 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4853 * insdel.c, lisp.h (buffer_overflow): New function.
4854 (insert_from_buffer_1, replace_range, replace_range_2):
4855 * insdel.c (make_gap_larger):
4856 * editfns.c (Finsert_char):
4857 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4859 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4861 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4863 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4865 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4866 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4868 * fileio.c: Don't assume EMACS_INT fits in off_t.
4869 (emacs_lseek): New static function.
4870 (Finsert_file_contents, Fwrite_region): Use it.
4871 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4873 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4875 * fns.c: Don't overflow int when computing a list length.
4876 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4877 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4878 truncation on 64-bit hosts. Check for QUIT every
4879 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4880 faster and is responsive enough.
4881 (Flength): Report an error instead of overflowing an integer.
4882 (Fsafe_length): Return a float if the value is not representable
4883 as a fixnum. This shouldn't happen except in contrived situations.
4884 (Fnthcdr, Fsort): Don't assume list length fits in int.
4885 (Fcopy_sequence): Don't assume vector length fits in int.
4887 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4888 (header_size, word_size): New constants.
4889 (allocate_vectorlike): Don't check size overflow here.
4890 (allocate_vector): Check it here instead, since this is the only
4891 caller of allocate_vectorlike that could cause overflow.
4892 Check that the new vector's length is representable as a fixnum.
4894 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4895 The previous code was bogus. For example, next_almost_prime (32)
4896 returned 39, which is undesirable as it is a multiple of 3; and
4897 next_almost_prime (24) returned 25, which is a multiple of 5 so
4898 why was the code bothering to check for multiples of 7?
4900 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4902 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4904 Variadic C functions now count arguments with ptrdiff_t.
4905 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4906 Back then I didn't know that the Emacs coding style prefers signed int.
4907 Also, in the meantime I found a few more instances where arguments
4908 were being counted with int, which may truncate counts on 64-bit
4909 machines, or EMACS_INT, which may be unnecessarily wide.
4910 * lisp.h (struct Lisp_Subr.function.aMANY)
4911 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4912 Arg counts are now ptrdiff_t, not size_t.
4913 All variadic functions and their callers changed accordingly.
4914 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4915 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4916 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4917 * callint.c (Fcall_interactively): Check arg count for overflow,
4918 to avoid potential buffer overrun. Use signed char, not 'int',
4919 for 'varies' array, so that we needn't bother to check its size
4920 calculation for overflow.
4921 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4922 * eval.c (apply_lambda):
4923 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4924 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4925 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4927 * callint.c (Fcall_interactively): Don't use index var as event count.
4929 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4930 * mem-limits.h (SIZE): Remove; no longer used.
4932 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4934 Remove unnecessary casts.
4935 * xterm.c (x_term_init):
4936 * xfns.c (x_set_border_pixel):
4937 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4938 These aren't needed now that we assume ANSI C.
4940 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4941 It's more likely to cause problems (due to unsigned overflow)
4944 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4946 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4948 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4950 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4952 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4954 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4956 GLYPH_CODE_FACE returns EMACS_INT, not int.
4957 * dispextern.h (merge_faces):
4958 * xfaces.c (merge_faces):
4959 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4960 Don't assume EMACS_INT fits in int.
4962 * character.h (CHAR_VALID_P): Remove unused parameter.
4963 * fontset.c, lisp.h, xdisp.c: All uses changed.
4965 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4967 * fns.c (concat): Minor tuning based on overflow analysis.
4968 This doesn't fix any bugs. Use int to hold character, instead
4969 of constantly refetching from Emacs object. Use XFASTINT, not
4970 XINT, for value known to be a character. Don't bother comparing
4971 a single byte to 0400, as it's always less.
4973 * floatfns.c (Fexpt):
4974 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4976 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4979 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4981 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4982 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4983 incorrectly succeed when S was a string, because 4294967386 was
4984 truncated before it was used.
4986 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4987 Otherwise, an out-of-range integer could cause undefined behavior
4990 * composite.c: Use int, not EMACS_INT, for characters.
4991 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4992 EMACS_INT, for values that are known to be in character range.
4993 This doesn't fix any bugs but is the usual style inside Emacs and
4994 may generate better code on 32-bit machines.
4996 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4997 This is for reasons similar to the recent CHAR_STRING fix.
4998 * charset.c (Fencode_char): Check that character arg is actually
4999 a character. Pass an int to ENCODE_CHAR.
5000 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5001 wider than 'int', as a compile-time check to prevent future regressions
5004 * character.c (char_string): Remove unnecessary casts.
5006 Make sure a 64-bit char is never passed to CHAR_STRING.
5007 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5008 by silently ignoring the top 32 bits, allowing some values
5009 that were far too large to be valid characters.
5010 * character.h: Include <verify.h>.
5011 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5012 arguments are no wider than unsigned, as a compile-time check
5013 to prevent future regressions in this area.
5015 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5016 (Fsubst_char_in_region):
5018 * xdisp.c (decode_mode_spec_coding):
5019 Adjust to CHAR_STRING's new requirement.
5020 * editfns.c (Finsert_char, Fsubst_char_in_region):
5021 * fns.c (concat): Check that character args are actually
5022 characters. Without this test, these functions did the wrong
5023 thing with wildly out-of-range values on 64-bit hosts.
5025 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5026 These casts should not be needed on 32-bit hosts, either.
5027 * keyboard.c (read_char):
5028 * lread.c (Fload): Remove casts to unsigned.
5030 * lisp.h (UNSIGNED_CMP): New macro.
5031 This fixes comparison bugs on 64-bit hosts.
5032 (ASCII_CHAR_P): Use it.
5033 * casefiddle.c (casify_object):
5034 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5035 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5036 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5037 * dispextern.h (FACE_FROM_ID):
5038 * keyboard.c (read_char): Use UNSIGNED_CMP.
5040 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5041 not to EMACS_INT, to avoid GCC warning.
5043 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5045 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5046 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5047 isn't needed on 32-bit machines.
5049 * buffer.c (Fgenerate_new_buffer_name):
5050 Use EMACS_INT for count, not int.
5051 (advance_to_char_boundary): Return EMACS_INT, not int.
5053 * data.c (Qcompiled_function): Now static.
5055 * window.c (window_body_lines): Now static.
5057 * image.c (gif_load): Rename local to avoid shadowing.
5059 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5060 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5061 * alloc.c (make_save_value): Integer argument is now of type
5063 (mark_object): Use ptrdiff_t, not int.
5064 * lisp.h (pD): New macro.
5065 * print.c (print_object): Use it.
5067 * alloc.c: Use EMACS_INT, not int, to count objects.
5068 (total_conses, total_markers, total_symbols, total_vector_size)
5069 (total_free_conses, total_free_markers, total_free_symbols)
5070 (total_free_floats, total_floats, total_free_intervals)
5071 (total_intervals, total_strings, total_free_strings):
5072 Now EMACS_INT, not int. All uses changed.
5073 (Fgarbage_collect): Compute overall total using a double, so that
5074 integer overflow is less likely to be a problem. Check for overflow
5075 when converting back to an integer.
5076 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5077 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5078 These were 'int' variables that could overflow on 64-bit hosts;
5079 they were never used, so remove them instead of repairing them.
5080 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5081 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5082 Previously, this ceilinged at INT_MAX, but that doesn't work on
5084 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5086 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5087 (allocate_vectorlike): Check for ptrdiff_t overflow.
5088 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5089 when a (possibly-narrower) signed value would do just as well.
5090 We prefer using signed arithmetic, to avoid comparison confusion.
5092 * alloc.c: Catch some string size overflows that we were missing.
5093 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5094 for convenience in STRING_BYTES_MAX.
5095 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5096 The definition here is exact; the one in lisp.h was approximate.
5097 (allocate_string_data): Check for string overflow. This catches
5098 some instances we weren't catching before. Also, it catches
5099 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5100 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5101 and ptrdiff_t and EMACS_INT are both 64 bits.
5103 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5104 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5105 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5107 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5109 * alloc.c (Fmake_string): Check for out-of-range init.
5111 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5113 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5115 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5117 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5118 xg_get_default_scrollbar_width.
5120 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5121 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5122 (style_changed_cb): Call update_theme_scrollbar_width and call
5123 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5124 all frames (Bug#8505).
5125 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5126 Call gtk_window_set_resizable if HAVE_GTK3.
5127 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5128 and height if HAVE_GTK3 (Bug#8505).
5129 (scroll_bar_width_for_theme): New variable.
5130 (update_theme_scrollbar_width): New function.
5131 (xg_get_default_scrollbar_width): Move code to
5132 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5133 (xg_initialize): Call update_theme_scrollbar_width.
5135 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5137 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5139 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5141 * frame.c (make_frame): Call other_buffer_safely instead of
5144 * window.c (temp_output_buffer_show): Call display_buffer with
5145 second argument Vtemp_buffer_show_specifiers and reset latter
5146 immediately after the call.
5147 (Vtemp_buffer_show_specifiers): New variable.
5148 (auto_window_vscroll_p, next_screen_context_lines)
5149 (Vscroll_preserve_screen_position): Remove leading asterisks from
5152 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5154 Fix minor problems found by GCC 4.6.0 static checking.
5155 * buffer.c (Qclone_number): Remove for now, as it's unused.
5156 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5157 (record_buffer): Remove unused local.
5158 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5159 (set_frame_buffer_list): Remove; unused.
5160 * frame.h (other_visible_frames): Remove decl.
5161 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5162 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5163 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5165 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5166 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5167 Define only if HAVE_GPM.
5168 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5169 (update_hints_inhibit): Remove; never set. All uses removed.
5170 * widgetprv.h (emacsFrameClassRec): Remove decl.
5171 * window.c (delete_deletable_window): Now returns void, since it
5172 wasn't returning anything.
5173 (compare_window_configurations): Remove unused locals.
5174 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5175 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5176 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5177 the same widths as pointers. This follows up on the 2011-05-06 patch.
5178 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5179 * xterm.h: Likewise.
5180 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5182 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5184 * makefile.w32-in: Update dependencies.
5185 (LISP_H): Add lib/intprops.h.
5187 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5189 * image.c (gif_load): Add animation frame delay to the metadata.
5190 (syms_of_image): Use DEFSYM. New symbol `delay'.
5192 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5194 * window.c (delete_deletable_window): Re-add.
5195 (Fset_window_configuration): Rewrite to handle dead buffers and
5196 consequently deletable windows.
5197 (window_tree, Fwindow_tree): Remove. Supply functionality in
5199 (compare_window_configurations): Simplify code.
5201 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5203 * image.c (imagemagick_load_image): Fix type mismatch.
5204 (Fimagemagick_types): Likewise.
5206 * window.h (replace_buffer_in_windows): Declare.
5208 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5210 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5211 Qclone_number. Remove external declaration of Qdelete_window.
5212 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5214 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5215 Run Qbuffer_list_update_hook if allowed.
5216 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5217 buffer list implementation.
5218 (other_buffer_safely): New function.
5219 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5220 calls to replace_buffer_in_windows and
5221 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5223 (record_buffer): Inhibit quitting and rewrite using quittable
5224 functions. Run Qbuffer_list_update_hook if allowed.
5225 (Frecord_buffer, Funrecord_buffer): New functions.
5226 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5227 Move switch-to-buffer to window.el.
5228 (bury-buffer): Move to window.el.
5229 (Vbuffer_list_update_hook): New variable.
5231 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5234 * window.h (resize_frame_windows): Move up in code.
5235 (Fwindow_frame): Remove EXFUN.
5236 (replace_buffer_in_all_windows): Remove prototype.
5237 (replace_buffer_in_windows_safely): Add prototype.
5239 * window.c: Declare Qdelete_window static again. Move down
5240 declaration of select_count.
5241 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5242 (Fother_window): Move to window.el.
5243 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5244 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5245 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5247 (replace_buffer_in_windows): Implement by calling
5248 Qreplace_buffer_in_windows.
5249 (replace_buffer_in_all_windows): Remove with some functionality
5250 moved into replace_buffer_in_windows_safely.
5251 (replace_buffer_in_windows_safely): New function.
5252 (select_window_norecord, select_frame_norecord): Move in front
5253 of run_window_configuration_change_hook. Remove now obsolete
5255 (Fset_window_buffer): Rewrite doc-string.
5256 Call Qrecord_window_buffer.
5257 (keys_of_window): Move binding for other-window to window.el.
5259 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5261 * dispextern.h (struct image): Replace data member, whose int_val
5262 and ptr_val fields were not used by anything, with a single
5265 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5266 (gif_clear_image, gif_load, imagemagick_load_image)
5267 (gs_clear_image, gs_load): Callers changed.
5269 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5271 * buffer.h: Include <time.h>, for time_t.
5272 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5274 Fix minor problems found by static checking.
5276 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5278 Make identifiers static if they are not used in other modules.
5279 * data.c (Qcompiled_function, Qframe, Qvector):
5280 * image.c (QimageMagick, Qsvg):
5281 * minibuf.c (Qmetadata):
5282 * window.c (resize_window_check, resize_root_window): Now static.
5283 * window.h (resize_window_check, resize_root_window): Remove decls.
5285 * window.c (window_deletion_count, delete_deletable_window):
5287 (window_body_lines): Now static.
5288 (Fdelete_other_windows_internal): Mark vars as initialized.
5289 Make sure 'resize_failed' is initialized.
5290 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5291 (resize_window_apply): Remove unused local.
5292 * window.h (delete_deletable_window): Remove decl.
5294 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5295 (imagemagick_load_image): Fix pointer signedness problem by changing
5296 last arg from unsigned char * to char *. All uses changed.
5297 Also, fix a local for similar reasons.
5298 Remove unused locals. Remove locals to avoid shadowing.
5299 (fn_rsvg_handle_free): Remove; unused.
5300 (svg_load, svg_load_image): Fix pointer signedness problem.
5301 (imagemagick_load_image): Don't use garbage pointer image_wand.
5303 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5305 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5307 * image.c (gif_load): Fix omitted cast error introduced by
5310 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5312 * window.h (resize_proportionally, orig_total_lines)
5313 (orig_top_line): Remove from window structure.
5314 (set_window_height, set_window_width, change_window_heights)
5315 (Fdelete_window): Remove prototypes.
5316 (resize_frame_windows): Remove duplicate declaration.
5318 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5320 * window.h (resize_frame_windows, resize_window_check)
5321 (delete_deletable_window, resize_root_window)
5322 (resize_frame_windows): Declare prototypes.
5324 * window.c (resize_window_apply): Make definition be "static" to
5325 match the prototype.
5327 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5329 * window.c: Remove declarations of Qwindow_size_fixed,
5330 window_min_size_1, window_min_size_2, window_min_size,
5331 size_window, window_fixed_size_p, enlarge_window, delete_window.
5332 Remove static from declaration of Qdelete_window, it's
5333 temporarily needed by Fbury_buffer.
5334 (replace_window): Don't assign orig_top_line and
5336 (Fdelete_window, delete_window): Remove. Window deletion is
5337 handled by window.el.
5338 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5339 Replace Fdelete_window calls with calls to Qdelete_window.
5340 (Fdelete_other_windows): Remove. Deleting other windows is
5341 handled by window.el.
5342 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5343 handled in window.el.
5344 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5345 Window minimum sizes are handled in window.el.
5346 (shrink_windows, size_window, set_window_height)
5347 (set_window_width, change_window_heights, window_height)
5348 (window_width, CURBEG, CURSIZE, enlarge_window)
5349 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5350 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5351 handled in window.el.
5352 (make_dummy_parent): Rename to make_parent_window and give it a
5353 second argument horflag.
5354 (make_window): Don't set resize_proportionally any more.
5355 (Fsplit_window): Remove. Windows are split in window.el.
5356 (save_restore_action, save_restore_orig_size)
5357 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5358 Resize mini windows in window.el.
5359 (grow_mini_window, shrink_mini_window): Implement by calling
5360 Qresize_root_window_vertically, resize_window_check and
5361 resize_window_apply.
5362 (saved_window, Fset_window_configuration, save_window_save):
5363 Do not handle orig_top_line, orig_total_lines, and
5364 resize_proportionally.
5365 (window_min_height, window_min_width): Move to window.el.
5366 (keys_of_window): Move bindings for delete-other-windows,
5367 split-window, delete-window and enlarge-window to window.el.
5369 * buffer.c: Temporarily extern Qdelete_window.
5370 (Fbury_buffer): Temporarily call Qdelete_window instead of
5371 Fdelete_window (Fbury_buffer will move to window.el soon).
5373 * frame.c (set_menu_bar_lines_1): Remove code handling
5374 orig_top_line and orig_total_lines.
5376 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5377 set_window_height but set heights directly.
5378 (change_frame_size_1): Use resize_frame_windows.
5380 * xdisp.c (init_xdisp): Don't use set_window_height but set
5383 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5384 Use resize_frame_windows instead of change_window_heights and run
5385 run_window_configuration_change_hook.
5387 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5388 instead of change_window_heights and run
5389 run_window_configuration_change_hook.
5391 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5393 * window.c (replace_window): Rename second argument REPLACEMENT to
5394 NEW. New third argument SETFLAG. Rewrite.
5395 (delete_window, make_dummy_parent): Call replace_window with
5397 (window_list_1): Move down in code.
5398 (run_window_configuration_change_hook): Move set_buffer part
5399 before select_frame_norecord part in order to unwind correctly.
5400 Rename count1 to count.
5401 (recombine_windows, delete_deletable_window, resize_root_window)
5402 (Fdelete_other_windows_internal)
5403 (Frun_window_configuration_change_hook, make_parent_window)
5404 (resize_window_check, resize_window_apply, Fresize_window_apply)
5405 (resize_frame_windows, Fsplit_window_internal)
5406 (Fdelete_window_internal, Fresize_mini_window_internal):
5408 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5410 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5412 * window.h (window): Add some new members to window structure -
5413 normal_lines, normal_cols, new_total, new_normal, clone_number,
5414 splits, nest, prev_buffers, next_buffers.
5415 (WINDOW_TOTAL_SIZE): Move here from window.c.
5416 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5418 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5420 (make_dummy_parent): Set new members of windows structure.
5421 (make_window): Move down in code. Handle new members of window
5423 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5424 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5425 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5426 (Fset_window_prev_buffers, Fwindow_next_buffers)
5427 (Fset_window_next_buffers, Fset_window_clone_number):
5429 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5430 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5432 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5433 Argument WINDOW can be now internal window too.
5434 (Fwindow_use_time): Move up in code.
5435 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5437 (Fset_window_configuration, saved_window)
5438 (Fcurrent_window_configuration, save_window_save): Handle new
5439 members of window structure.
5440 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5441 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5442 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5443 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5444 Qget_mru_window, Qresize_root_window,
5445 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5446 Qauto_buffer_name; staticpro them.
5448 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5450 * window.c (Fwindow_total_size, Fwindow_left_column)
5451 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5452 (Fwindow_list_1): New functions.
5453 (window_box_text_cols): Replace with window_body_cols.
5454 (Fwindow_width, Fscroll_left, Fscroll_right):
5455 Use window_body_cols instead of window_box_text_cols.
5456 (delete_window, Fset_window_configuration):
5457 Call delete_all_subwindows with window as argument.
5458 (delete_all_subwindows): Take a window as argument and not a
5460 (window_loop): Remove handling of GET_LRU_WINDOW and
5462 (Fget_lru_window, Fget_largest_window): Move to window.el.
5464 * window.h: Extern window_body_cols instead of
5465 window_box_text_cols. delete_all_subwindows now takes a
5466 Lisp_Object as argument.
5468 * indent.c (compute_motion, Fcompute_motion):
5469 Use window_body_cols instead of window_box_text_cols.
5471 * frame.c (delete_frame): Call delete_all_subwindows with root
5474 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5476 * fns.c (Fputhash): Document return value.
5478 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5480 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5482 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5484 Cons<->int and similar integer overflow fixes (Bug#8794).
5486 Check for overflow when converting integer to cons and back.
5487 * charset.c (Fdefine_charset_internal, Fdecode_char):
5488 Use cons_to_unsigned to catch overflow.
5489 (Fencode_char): Use INTEGER_TO_CONS.
5490 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5491 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5492 * data.c (long_to_cons, cons_to_long): Remove.
5493 (cons_to_unsigned, cons_to_signed): New functions.
5494 These signal an error for invalid or out-of-range values.
5495 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5496 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5497 * font.c (Ffont_variation_glyphs):
5498 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5499 * lisp.h: Include <intprops.h>.
5500 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5501 (cons_to_signed, cons_to_unsigned): New decls.
5502 (long_to_cons, cons_to_long): Remove decls.
5503 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5504 (Fprimitive_undo): Use CONS_TO_INTEGER.
5505 * xfns.c (Fx_window_property): Likewise.
5506 * xselect.c: Include <limits.h>.
5507 (x_own_selection, selection_data_to_lisp_data):
5508 Use INTEGER_TO_CONS.
5509 (x_handle_selection_request, x_handle_selection_clear)
5510 (x_get_foreign_selection, Fx_disown_selection_internal)
5511 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5512 (lisp_data_to_selection_data): Use cons_to_unsigned.
5513 (x_fill_property_data): Use cons_to_signed.
5514 Report values out of range.
5516 Check for buffer and string overflow more precisely.
5517 * buffer.h (BUF_BYTES_MAX): New macro.
5518 * lisp.h (STRING_BYTES_MAX): New macro.
5519 * alloc.c (Fmake_string):
5520 * character.c (string_escape_byte8):
5521 * coding.c (coding_alloc_by_realloc):
5522 * doprnt.c (doprnt):
5523 * editfns.c (Fformat):
5525 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5526 since they may not be the same number.
5527 * editfns.c (Finsert_char):
5528 * fileio.c (Finsert_file_contents):
5529 Likewise for BUF_BYTES_MAX.
5531 * image.c: Use ptrdiff_t, not int, for sizes.
5532 (slurp_file): Switch from int to ptrdiff_t.
5534 (slurp_file): Check that file size fits in both size_t (for
5535 malloc) and ptrdiff_t (for sanity and safety).
5537 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5538 if b->modtime has its maximal value.
5540 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5542 Don't assume time_t can fit into int.
5543 * buffer.h (struct buffer.modtime): Now time_t, not int.
5544 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5545 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5547 Minor fixes for signed vs unsigned integers.
5548 * character.h (MAYBE_UNIFY_CHAR):
5549 * charset.c (maybe_unify_char):
5550 * keyboard.c (read_char, reorder_modifiers):
5551 XINT -> XFASTINT, since the integer must be nonnegative.
5552 * ftfont.c (ftfont_spec_pattern):
5553 * keymap.c (access_keymap, silly_event_symbol_error):
5554 XUINT -> XFASTINT, since the integer must be nonnegative.
5555 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5556 since it makes no difference and we prefer signed.
5557 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5558 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5561 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5563 * window.h (Fwindow_frame): Declare.
5565 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5567 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5568 (SPARE_MEMORY): Always define.
5569 (LARGE_REQUEST): Remove.
5570 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5572 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5574 * lisp.h: Move EXFUNS for Fframe_root_window,
5575 Fframe_first_window and Fset_frame_selected_window to window.h.
5577 * window.h: Move EXFUNS for Fframe_root_window,
5578 Fframe_first_window and Fset_frame_selected_window here from
5581 * frame.c (Fwindow_frame, Fframe_first_window)
5582 (Fframe_root_window, Fframe_selected_window)
5583 (Fset_frame_selected_window): Move to window.c.
5584 (Factive_minibuffer_window): Move to minibuf.c.
5585 (Fother_visible_frames_p): New function.
5587 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5589 * window.c (decode_window, decode_any_window): Move up in code.
5590 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5591 (inhibit_frame_unsplittable): Remove unused variable.
5592 (Fwindow_buffer): Move up and rewrite doc-string.
5593 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5594 (Fwindow_prev): New functions.
5595 (Fwindow_frame): Move here from frame.c. Accept any window as
5597 (Fframe_root_window, Fframe_first_window)
5598 (Fframe_selected_window): Move here from frame.c. Accept frame
5599 or arbitrary window as argument. Update doc-strings.
5600 (Fminibuffer_window): Move up in code.
5601 (Fwindow_minibuffer_p): Move up in code and simplify.
5602 (Fset_frame_selected_window): Move here from frame.c.
5604 (Fselected_window, select_window, Fselect_window): Move up in
5605 code. Minor doc-string fixes.
5607 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5609 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5610 Do not assume that spare memory exists; that assumption is valid
5611 only if SYSTEM_MALLOC.
5612 (LARGE_REQUEST): New macro, so that the issue of large requests
5613 is separated from the issue of spare memory.
5615 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5617 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5620 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5622 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5625 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5627 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5629 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5631 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5632 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5634 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5636 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5638 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5640 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5641 (x_clipboard_manager_save): Add return value.
5642 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5644 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5645 Obey Vx_select_enable_clipboard_manager. Catch errors in
5646 x_clipboard_manager_save (Bug#8779).
5647 (Vx_select_enable_clipboard_manager): New variable.
5648 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5650 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5652 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5654 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5656 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5657 in the current matrix if keep_current_p is non-zero.
5659 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5661 * bidi.c (bidi_level_of_next_char): Fix last change.
5663 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5665 Support bidi reordering of text covered by display properties.
5667 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5668 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5669 (bidi_cache_search, bidi_cache_iterator_state)
5670 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5671 (bidi_level_of_next_char, bidi_move_to_visually_next):
5672 Support character positions inside a run of characters covered by a
5674 (bidi_paragraph_init, bidi_resolve_explicit_1)
5675 (bidi_level_of_next_char): Call bidi_fetch_char and
5676 bidi_fetch_char_advance instead of FETCH_CHAR and
5678 (bidi_init_it): Initialize new members.
5679 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5681 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5682 instead of using explicit *_CHAR codes.
5683 (bidi_resolve_explicit, bidi_resolve_weak):
5684 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5685 bidirectional text is supported only in multibyte buffers.
5686 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5687 it to initialize the frame_window_p member of struct bidi_it.
5688 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5689 (bidi_resolve_explicit, bidi_resolve_weak)
5690 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5691 bidi_it->nchars is non-positive.
5692 (bidi_level_of_next_char): Don't try to lookup the cache for the
5693 next/previous character if nothing is cached there yet, or if we
5694 were just reseat()'ed to a new position.
5696 * xdisp.c (set_cursor_from_row): Set start and stop points
5697 according to the row's direction when priming the loop that looks
5698 for the glyph on which to display cursor.
5699 (single_display_spec_intangible_p): Function deleted.
5700 (display_prop_intangible_p): Reimplement to call
5701 handle_display_spec instead of single_display_spec_intangible_p.
5702 Accept 3 additional arguments needed by handle_display_spec.
5703 This fixes incorrect cursor motion across display property with complex
5704 values: lists, `(when COND...)' forms, etc.
5705 (single_display_spec_string_p): Support property values that are
5706 lists with the argument STRING its top-level element.
5707 (display_prop_string_p): Fix the condition for processing a
5708 property that is a list to be consistent with handle_display_spec.
5709 (handle_display_spec): New function, refactored from the
5710 last portion of handle_display_prop.
5711 (compute_display_string_pos): Accept additional argument
5712 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5713 value of a `display' property is a "replacing spec".
5714 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5715 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5716 the display property, but just return a value indicating whether
5717 the display property will replace the characters it covers.
5718 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5719 frame_window_p members of struct bidi_it.
5720 (compute_display_string_pos, compute_display_string_end):
5722 (push_it): Accept second argument POSITION, where pop_it should
5723 jump to continue iteration.
5724 (reseat_1): Initialize bidi_it.disp_pos.
5726 * keyboard.c (adjust_point_for_property): Adjust the call to
5727 display_prop_intangible_p to its new signature.
5729 * dispextern.h (struct bidi_it): New member frame_window_p.
5730 (bidi_init_it): Update prototypes.
5731 (display_prop_intangible_p): Update prototype.
5732 (compute_display_string_pos, compute_display_string_end):
5734 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5737 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5739 Malloc failure behavior now depends on size of allocation.
5740 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5741 * lisp.h: Change signatures accordingly.
5742 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5743 All callers changed. (Bug#8762)
5745 * gnutls.c: Use Emacs's memory allocators.
5746 Without this change, the gnutls library would invoke malloc etc.
5747 directly, which causes problems on non-SYNC_INPUT hosts, and which
5748 runs afoul of improving memory_full behavior. (Bug#8761)
5749 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5750 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5751 xfree instead of the default malloc, realloc, free.
5752 (Fgnutls_boot): No need to check for memory allocation failure,
5753 since xmalloc does that for us.
5755 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5756 * category.c (hash_get_category_set):
5757 * ccl.c (ccl_driver):
5758 * charset.c (Fdefine_charset_internal):
5759 * charset.h (struct charset.hash_index):
5760 * composite.c (get_composition_id, gstring_lookup_cache)
5761 (composition_gstring_put_cache):
5762 * composite.h (struct composition.hash_index):
5763 * dispextern.h (struct image.hash):
5764 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5765 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5766 (hashfn_equal, hashfn_user_defined, make_hash_table)
5767 (maybe_resize_hash_table, hash_lookup, hash_put)
5768 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5769 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5770 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5771 * image.c (make_image, search_image_cache, lookup_image)
5772 (xpm_put_color_table_h):
5773 * lisp.h (struct Lisp_Hash_Table):
5774 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5775 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5776 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5777 * alloc.c (allocate_vectorlike):
5778 Check for overflow in vector size calculations.
5779 * ccl.c (ccl_driver):
5780 Check for overflow when converting EMACS_INT to int.
5781 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5782 need to be updated by these changes.
5783 * fns.c (make_hash_table, maybe_resize_hash_table):
5784 Check for integer overflow with large hash tables.
5785 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5786 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5787 (SXHASH_REDUCE): New macro.
5788 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5789 Use it instead of discarding useful hash info with large hash values.
5790 (sxhash_float): New function.
5791 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5792 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5793 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5794 Rewrite to use FIXNUM_BITS, as this simplifies things.
5795 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5796 Adjust signatures to match updated version of code.
5797 (consing_since_gc): Now EMACS_INT, since a single hash table can
5798 use more than INT_MAX bytes.
5800 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5802 Make it possible to build with GCC-4.6+ -O2 -flto.
5804 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5806 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5808 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5809 Call minibuffer-inactive-mode.
5811 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5813 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5814 Update dependencies.
5816 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5818 * data.c (init_data): Remove code for UTS, this system is not
5821 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5823 Don't force ./temacs to start in terminal mode.
5825 * frame.c (make_initial_frame): Initialize faces in all cases, not
5826 only when CANNOT_DUMP is defined.
5827 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5829 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5831 * dispnew.c (add_window_display_history): Use const for the string
5832 pointer. Remove declaration, not needed.
5834 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5836 Use 'inline', not 'INLINE'.
5837 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5838 * alloc.c, fontset.c (INLINE): Remove.
5839 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5840 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5841 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5842 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5843 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5845 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5847 Make it possible to run ./temacs.
5849 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5850 syms_of_callproc does the same thing. Remove test for
5851 "initialized", do it in the caller.
5852 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5854 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5856 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5857 (read_minibuf): Use get_minibuffer.
5858 (syms_of_minibuf): Use DEFSYM.
5859 (Qmetadata): New var.
5860 * data.c (Qbuffer): Don't make it static.
5861 (syms_of_data): Use DEFSYM.
5863 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5865 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5866 (CCL_CODE_MIN): New macro.
5868 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5870 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5872 * eval.c (Qdebug): Now static.
5873 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5874 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5875 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5877 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5879 * image.c: Various fixes to ImageMagick code comments.
5880 (Fimagemagick_types): Doc fix.
5882 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5884 Minor fixes prompted by GCC 4.6.0 warnings.
5886 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5888 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5889 (x_clipboard_manager_save_all): Move extern decl to ...
5890 * xterm.h: ... here, so that it can be checked for consistency.
5892 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5894 * xselect.c (x_clipboard_manager_save_frame)
5895 (x_clipboard_manager_save_all): New functions.
5896 (Fx_clipboard_manager_save): Lisp function deleted.
5898 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5899 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5901 * xterm.h: Update prototype.
5903 2011-05-28 William Xu <william.xwl@gmail.com>
5905 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5908 2011-05-28 Jim Meyering <meyering@redhat.com>
5910 Avoid a sign-extension bug in crypto_hash_function.
5911 * fns.c (to_uchar): Define.
5912 (crypto_hash_function): Use it to convert some newly-signed
5913 variables to unsigned, to avoid sign-extension bugs. For example,
5914 without this change, (md5 "truc") would evaluate to
5915 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5916 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5917 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5919 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5921 Integer overflow fixes.
5923 * dbusbind.c: Serial number integer overflow fixes.
5924 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5925 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5926 to hold a serial number that is too large for a fixnum.
5927 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5928 Check for serial numbers out of range. Decode any serial number
5929 that was so large that it became a float. (Bug#8722)
5931 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5932 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5933 Use XFASTINT rather than XUINT when numbers are nonnegative.
5934 (xd_append_arg, Fdbus_method_return_internal):
5935 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5936 arguments, check that Lisp number is nonnegative, rather than
5937 silently wrapping negative numbers around. (Bug#8722)
5938 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5941 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5943 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5945 ccl: Add integer overflow checks.
5946 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5947 (IN_INT_RANGE): New macros.
5948 (ccl_driver): Use them to check for integer overflow when
5949 decoding a CCL program. Many of the new checks are whether XINT (x)
5950 fits in int; it doesn't always, on 64-bit hosts. The new version
5951 doesn't catch all possible integer overflows, but it's an
5952 improvement. (Bug#8719)
5954 * alloc.c (make_event_array): Use XINT, not XUINT.
5955 There's no need for unsigned here.
5957 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5958 This follows up to the 2011-05-06 change that substituted uintptr_t
5959 for EMACS_INT. This case wasn't caught back then.
5961 Rework Fformat to avoid integer overflow issues.
5962 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5963 now (part of C89). Include <verify.h>.
5964 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5965 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5966 (Fformat): Avoid the prepass trying to compute sizes; it was only
5967 approximate and thus did not catch overflow reliably. Instead, walk
5968 through the format just once, formatting and computing sizes as we go,
5969 checking for integer overflow at every step, and allocating a larger
5970 buffer as needed. Keep track separately whether the format is
5971 multibyte. Keep only the most-recently calculated precision, rather
5972 than them all. Record whether each argument has been converted to
5973 string. Use EMACS_INT, not int, for byte and char and arg counts.
5974 Support field widths and precisions larger than INT_MAX. Avoid
5975 sprintf's undefined behavior with conversion specifications such as %#d
5976 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5977 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5978 formatting out-of-range floating point numbers with int
5981 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5983 * data.c: Avoid integer truncation in expressions involving floats.
5984 * data.c: Include <intprops.h>.
5985 (arith_driver): When there's an integer overflow in an expression
5986 involving floating point, convert the integers to floating point
5987 so that the resulting value does not suffer from catastrophic
5988 integer truncation. For example, on a 64-bit host (* 4
5989 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5990 Do not rely on undefined behavior after integer overflow.
5992 merge count_size_as_multibyte, parse_str_to_multibyte
5993 * character.c, character.h (count_size_as_multibyte):
5994 Rename from parse_str_to_multibyte; all uses changed.
5995 Check for integer overflow.
5996 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5997 since it's now a duplicate of the other. This is more of
5998 a character than a buffer op, so better that it's in character.c.
5999 * fns.c, print.c: Adjust to above changes.
6001 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6003 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6005 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6007 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6008 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6009 (x_clipboard_manager_save): Now static.
6010 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6012 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6013 (crypto_hash_function): Now static.
6014 Fix pointer signedness problems. Avoid unnecessary initializations.
6016 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6018 * termhooks.h (Vselection_alist): Make it terminal-local.
6020 * terminal.c (create_terminal): Initialize it.
6022 * xselect.c: Support for clipboard managers.
6023 (Vselection_alist): Move to termhooks.h as terminal-local var.
6024 (LOCAL_SELECTION): New macro.
6025 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6026 (symbol_to_x_atom): Remove gratuitous arg.
6027 (x_handle_selection_request, lisp_data_to_selection_data)
6028 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6029 (x_own_selection, x_get_local_selection, x_convert_selection):
6030 New arg, specifying work frame. Use terminal-local Vselection_alist.
6031 (some_frame_on_display): Delete unused function.
6032 (Fx_own_selection_internal, Fx_get_selection_internal)
6033 (Fx_disown_selection_internal, Fx_selection_owner_p)
6034 (Fx_selection_exists_p): New optional frame arg.
6035 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6036 (x_handle_selection_clear): Don't treat other terminals with the
6037 same keyboard specially. Use the terminal-local Vselection_alist.
6038 (x_clear_frame_selections): Use Frun_hook_with_args.
6040 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6042 * xterm.h: Add support for those atoms.
6044 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6046 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6047 (converted_selections, conversion_fail_tag): New global variables.
6048 (x_selection_request_lisp_error): Free the above.
6049 (x_get_local_selection): Remove unnecessary code.
6050 (x_reply_selection_request): Args changed; handle arbitrary array
6051 of converted selections stored in converted_selections.
6052 Separate the XChangeProperty and SelectionNotify steps.
6053 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6054 (x_convert_selection): New function.
6055 (x_handle_selection_event): Simplify.
6056 (x_get_foreign_selection): Don't ignore incoming requests while
6057 waiting for an answer; this will fail when we implement
6058 SAVE_TARGETS, and seems unnecessary anyway.
6059 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6060 (Vx_sent_selection_functions): Doc fix.
6062 2011-05-26 Leo Liu <sdl.web@gmail.com>
6064 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6066 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6068 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6070 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6071 for fringe update if it has periodic bitmap.
6072 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6073 and fringe_bitmap_periodic_p.
6075 * fringe.c (get_fringe_bitmap_data): New function.
6076 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6077 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6078 row. Mark glyph row for fringe update if periodicity changed.
6080 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6081 for fringe update unless it has periodic bitmap.
6083 2011-05-25 Kenichi Handa <handa@m17n.org>
6085 * xdisp.c (get_next_display_element): Set correct it->face_id for
6086 a static composition.
6088 2011-05-24 Leo Liu <sdl.web@gmail.com>
6091 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6093 * fns.c (crypto_hash_function, Fsha1): New function.
6094 (Fmd5): Use crypto_hash_function.
6095 (syms_of_fns): Add Ssha1.
6097 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6099 * gnutls.c: Remove unused macros.
6100 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6101 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6102 Remove macros that are defined and never used.
6103 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6105 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6107 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6108 (Fx_get_selection_internal): Minor cleanup.
6109 (Fx_own_selection_internal): Rename arguments for consistency with
6112 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6114 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6116 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6118 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6120 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6122 * dispnew.c (scrolling_window): Don't exclude the case that the
6123 last enabled row in the desired matrix touches the bottom boundary.
6125 2011-05-21 Glenn Morris <rgm@gnu.org>
6127 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6128 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6129 and add some more files.
6131 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6133 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6134 report_file_error introduced by the change from 2011-05-07.
6136 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6138 * systime.h (Time): Define only if emacs is defined.
6139 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6140 where the include path doesn't have X11/X.h by default. See
6141 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6143 2011-05-20 Kenichi Handa <handa@m17n.org>
6145 * composite.c (find_automatic_composition): Fix previous change.
6147 2011-05-20 Glenn Morris <rgm@gnu.org>
6149 * lisp.mk: New file, split from Makefile.in.
6150 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6151 (shortlisp): Remove.
6152 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6154 2011-05-19 Glenn Morris <rgm@gnu.org>
6156 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6157 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6158 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6159 (lisp): Set the order to that of loadup.el.
6160 (shortlisp): Make it a copy of $lisp.
6161 (SOME_MACHINE_LISP): Remove.
6162 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6163 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6165 2011-05-18 Kenichi Handa <handa@m17n.org>
6167 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6168 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6169 (find_automatic_composition): Mostly rewrite for efficiency.
6171 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6173 * makefile.w32-in: Update dependencies.
6175 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6177 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6178 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6180 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6182 Fix some integer overflow issues, such as string length overflow.
6184 * insdel.c (count_size_as_multibyte): Check for string overflow.
6186 * character.c (lisp_string_width): Check for string overflow.
6187 Use EMACS_INT, not int, for string indexes and lengths; in
6188 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6189 the resulting string length overflows an EMACS_INT; instead,
6190 report a string overflow if no precision given. When checking for
6191 precision exhaustion, use a check that cannot possibly have
6192 integer overflow. (Bug#8675)
6193 * character.h (lisp_string_width): Adjust to new signature.
6195 * alloc.c (string_overflow): New function.
6196 (Fmake_string): Use it. This doesn't change behavior, but saves
6197 a few bytes and will simplify future changes.
6198 * character.c (string_escape_byte8): Likewise.
6199 * lisp.h (string_overflow): New decl.
6201 Fixups, following up to the user-interface timestamp change.
6202 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6203 for UI timestamps, instead of unsigned long.
6204 * msdos.c (mouse_get_pos): Likewise.
6205 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6206 * w32gui.h (Time): Define by including "systime.h" rather than by
6207 declaring it ourselves. (Bug#8664)
6209 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6210 * image.c (clear_image_cache): Likewise.
6212 * term.c (term_mouse_position): Don't assume time_t wraparound.
6214 Be more systematic about user-interface timestamps.
6215 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6216 and sometimes 'EMACS_UINT', to represent these timestamps.
6217 This change causes it to use 'Time' uniformly, as that's what X uses.
6218 This makes the code easier to follow, and makes it easier to catch
6219 integer overflow bugs such as Bug#8664.
6220 * frame.c (Fmouse_position, Fmouse_pixel_position):
6221 Use Time, not unsigned long, for user-interface timestamps.
6222 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6223 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6224 * keyboard.h (last_event_timestamp): Likewise.
6225 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6226 * menu.h (xmenu_show): Likewise.
6227 * term.c (term_mouse_position): Likewise.
6228 * termhooks.h (struct input_event.timestamp): Likewise.
6229 (struct terminal.mouse_position_hook): Likewise.
6230 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6231 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6232 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6233 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6235 * menu.h, termhooks.h: Include "systime.h", for Time.
6237 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6238 Don't assume that the difference between two unsigned long values
6239 can fit into an integer. At this point, we know button_down_time
6240 <= event->timestamp, so the difference must be nonnegative, so
6241 there's no need to cast the result if double-click-time is
6242 nonnegative, as it should be; check that it's nonnegative, just in
6243 case. This bug is triggered when events are more than 2**31 ms
6244 apart (about 25 days). (Bug#8664)
6246 * xselect.c (last_event_timestamp): Remove duplicate decl.
6247 (x_own_selection): Remove needless cast to unsigned long.
6249 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6250 that always fit in int. Use a sentinel instead of a counter, to
6251 avoid a temp and to allay GCC's concerns about possible int overflow.
6252 * frame.h (struct frame): Use int for menu_bar_items_used
6253 instead of EMACS_INT, since it always fits in int.
6255 * menu.c (grow_menu_items): Check for int overflow.
6257 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6259 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6260 Before, the code was not consistent. These values cannot exceed
6261 2**31 - 1 so there's no need to make them unsigned.
6262 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6263 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6264 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6266 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6268 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6269 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6270 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6271 presumably because the widths might not match.
6273 * window.c (size_window): Avoid needless test at loop start.
6275 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6277 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6279 2011-05-12 Drew Adams <drew.adams@oracle.com>
6281 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6283 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6285 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6286 `width' to `bar_area_x' and `bar_area_width', respectively.
6287 (x_scroll_run): Take account of fringe background extension.
6289 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6290 Rename local vars `left' and `width' to `bar_area_x' and
6291 `bar_area_width', respectively.
6292 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6293 background extension.
6295 2011-05-10 Jim Meyering <meyering@redhat.com>
6297 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6299 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6301 * image.c (Finit_image_library): Return t for built-in image types,
6302 like pbm and xbm. (Bug#8640)
6304 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6306 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6308 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6310 * w32console.c (Fset_screen_color): Doc fix.
6311 (Fget_screen_color): New function.
6312 (syms_of_ntterm): Defsubr it.
6314 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6315 unlink the temporary file if Fcall_process didn't create it in the
6317 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6318 child process will be redirected to a file specified with `:file'.
6319 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6320 cue to call_process_cleanup not to close that handle.
6322 2011-05-07 Ben Key <bkey76@gmail.com>
6324 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6325 one of two shell specific rules, either bootstrap-temacs-CMD or
6326 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6327 to the previous implementation of the bootstrap-temacs rule.
6328 The bootstrap-temacs-CMD rule is similar to the previous
6329 implementation of the bootstrap-temacs rule except that it
6330 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6333 These changes, along with some changes to nt/configure.bat,
6334 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6335 earlier fix to add support for --cflags and --ldflags options
6336 that include quotes so that it works whether make uses cmd or
6339 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6341 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6342 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6344 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6345 a string. Handle both cases.
6346 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6347 (Fdbus_register_method): Use Qinvalid_function.
6349 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6351 * makefile.w32-in: Update dependencies.
6352 (LISP_H): Add inttypes.h and stdin.h.
6353 (PROCESS_H): Add unistd.h.
6355 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6357 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6358 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6360 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6362 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6364 * term.c (vfatal): Remove stray call to va_end.
6365 It's not needed and the C Standard doesn't allow it here anyway.
6367 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6368 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6370 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6373 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6375 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6377 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6379 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6381 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6383 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6384 * charset.c (Fdefine_charset_internal): Don't initialize
6385 charset.code_space[15]. The value was garbage, on hosts with
6386 32-bit int (Bug#8600).
6388 * lread.c (read_integer): Be more consistent with string-to-number.
6389 Use string_to_number to do the actual conversion; this avoids
6390 rounding errors and fixes some other screwups. Without this fix,
6391 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6392 (digit_to_number): Move earlier, for benefit of read_integer.
6393 Return -1 if the digit is out of range for the base, -2 if it is
6394 not a digit in any supported base. (Bug#8602)
6396 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6398 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6399 to match comment at start of function. This also removes a
6400 GCC warning about overflow in a 32+64-bit port.
6402 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6404 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6405 Reported by Stefan Monnier in
6406 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6407 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6408 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6410 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6411 (EMACS_UINTPTR): Likewise, with uintptr_t.
6413 * lisp.h: Prefer 64-bit EMACS_INT if available.
6414 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6415 on 32-bit hosts that have 64-bit int, so that they can access
6417 However, temporarily disable this change unless the temporary
6418 symbol WIDE_EMACS_INT is defined.
6420 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6422 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6423 This removes an assumption that EMACS_INT and long are the same
6424 width as pointers. The assumption is true for Emacs porting targets
6425 now, but we want to make other targets possible.
6426 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6427 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6428 In the rest of the code, change types of integers that hold casted
6429 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6430 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6431 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6432 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6433 No need to cast type when ORing.
6434 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6435 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6436 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6437 assume EMACS_INT is the same width as char *.
6438 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6439 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6440 Remove no-longer-needed casts.
6441 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6442 (xg_tool_bar_help_callback, xg_make_tool_item):
6443 Use EMACS_INTPTR to hold an integer
6444 that will be cast to void *; this can avoid a GCC warning
6445 if EMACS_INT is not the same width as void *.
6446 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6447 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6448 (current_message_1, set_message_1):
6449 Use a local to convert to proper width without a cast.
6450 * xmenu.c (dialog_selection_callback): Likewise.
6452 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6453 Also, don't assume VALBITS / RAND_BITS is less than 5,
6454 and don't rely on undefined behavior when shifting a 1 left into
6456 * lisp.h (get_random): Change signature to match.
6458 * lread.c (hash_string): Use size_t, not int, for hash computation.
6459 Normally we prefer signed values; but hashing is special, because
6460 it's better to use unsigned division on hash table sizes so that
6461 the remainder is nonnegative. Also, size_t is the natural width
6462 for hashing into memory. The previous code used 'int', which doesn't
6463 retain enough info to hash well into very large tables.
6464 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6466 * dbusbind.c: Don't possibly lose pointer info when converting.
6467 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6468 Use XPNTR rather than XHASH, so that the high-order bits of
6469 the pointer aren't lost when converting through void *.
6471 * eval.c (Fautoload): Don't double-shift a pointer.
6473 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6475 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6477 * gnutls.c (DEF_GNUTLS_FN):
6478 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6480 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6482 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6485 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6487 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6488 New version that can reserve upto 2GB of heap space.
6490 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6492 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6494 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6496 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6497 `gnutls_certificate_set_x509_key_file'.
6499 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6501 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6502 Update dependencies.
6504 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6506 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6507 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6508 Remove unused parameter `fildes'.
6509 * process.c (read_process_output, send_process): Don't pass it.
6511 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6513 Fix previous change: the library cache is defined in w32.c.
6514 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6515 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6517 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6519 Implement dynamic loading of GnuTLS on Windows.
6521 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6522 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6523 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6526 * gnutls.c (Qgnutls_dll): Define.
6527 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6528 (gnutls_*): Declare function pointers.
6529 (init_gnutls_functions): New function to initialize function pointers.
6530 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6531 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6532 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6533 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6534 (emacs_gnutls_write, emacs_gnutls_read)
6535 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6536 (Fgnutls_available_p): New function.
6537 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6538 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6539 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6541 * image.c: Include w32.h.
6542 (Vimage_type_cache): Delete.
6543 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6544 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6545 (w32_delayed_load): Move to w32.c.
6547 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6549 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6550 (w32_delayed_load): Move from image.c. When loading a library, record
6551 its filename in the :loaded-from property of the library id.
6552 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6553 Initialize and staticpro them.
6554 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6556 * process.c: Include lisp.h before w32.h, not after.
6557 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6558 instead of gnutls_record_check_pending.
6560 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6562 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6564 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6565 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6568 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6570 * xterm.c (x_set_frame_alpha): Do not set property on anything
6571 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6573 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6575 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6577 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6579 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6580 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6581 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6582 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6583 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6584 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6585 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6586 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6587 (Qgnutls_bootprop_callbacks_verify): Make static.
6589 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6591 * callproc.c: Indentation fixup.
6593 * sysdep.c (wait_for_termination_1): Make static.
6594 (wait_for_termination, interruptible_wait_for_termination):
6595 Move after wait_for_termination_1.
6597 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6599 * sysdep.c (interruptible_wait_for_termination): New function
6600 which is like wait_for_termination, but allows keyboard
6603 * callproc.c (Fcall_process): Add (:file "file") as an option for
6605 (Fcall_process_region): Ditto.
6607 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6609 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6610 rather than `XVECTOR (FOO)->size'.
6612 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6613 inttypes.h, as a gnulib replacement is used if it not available in
6616 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6618 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6619 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6620 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6622 * coding.c (coding_alloc_by_realloc): Error out if destination
6623 will grow beyond MOST_POSITIVE_FIXNUM.
6624 (decode_coding_emacs_mule): Abort if there isn't enough place in
6625 charbuf for the composition carryover bytes. Reserve an extra
6626 space for up to 2 characters produced in a loop.
6627 (decode_coding_iso_2022): Abort if there isn't enough place in
6628 charbuf for the composition carryover bytes.
6630 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6632 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6633 aborting when %lld or %lll format is passed.
6634 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6635 %llo or %llx format is passed. (Bug#8545)
6637 * window.c (window_scroll_line_based): Use a marker instead of
6638 simple variables to record original value of point. (Bug#7952)
6640 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6641 produced by %s or %c overflows available buffer space. (Bug#8545)
6643 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6645 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6646 (SIZE_MAX): Move defn after all includes, as they might #define it.
6648 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6650 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6652 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6654 * keyboard.c (Qdelayed_warnings_hook): Define.
6655 (command_loop_1): Run `delayed-warnings-hook'
6656 if Vdelayed_warnings_list is non-nil.
6657 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6658 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6660 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6662 * doprnt.c (doprnt): Don't return value smaller than the buffer
6663 size if the message was truncated. (Bug#8545).
6665 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6667 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6668 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6670 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6672 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6674 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6676 * makefile.w32-in: Update dependencies.
6678 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6680 Improve `doprnt' and its usage. (Bug#8545)
6681 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6682 `format_end'. Remove support for %l as a conversion specifier.
6683 Don't use xrealloc. Improve diagnostics when the %l size modifier
6684 is used. Update the commentary.
6686 * eval.c (verror): Simplify calculation of size_t.
6688 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6691 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6693 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6696 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6698 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6699 This makes this file independent of the recent pseudovector change.
6701 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6703 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6705 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6706 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6707 Remove unused local.
6708 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6710 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6711 GCC 4.6.0 optimizes based on type-based alias analysis.
6712 For example, if b is of type struct buffer * and v of type struct
6713 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6714 != &v->size, and therefore "v->size = 1; b->size = 2; return
6715 v->size;" must therefore return 1. This assumption is incorrect
6716 for Emacs, since it type-puns struct Lisp_Vector * with many other
6717 types. To fix this problem, this patch adds a new type struct
6718 vectorlike_header that documents the constraints on layout of vectors
6719 and pseudovectors, and helps optimizing compilers not get fooled
6720 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6721 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6722 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6724 (XSETPVECTYPE): Rewrite in terms of new macro.
6725 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6726 This is a bit clearer, and further avoids the possibility of
6727 undesirable aliasing.
6728 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6729 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6730 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6731 since Lisp_Subr is a special case (no "next" field).
6732 (ASIZE): Now uses header.size rather than size.
6733 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6734 to avoid the hassle of writing XVECTOR (foo)->header.size.
6735 (struct vectorlike_header): New type.
6736 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6737 object, to help avoid aliasing.
6738 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6739 (SUBRP): Likewise, since Lisp_Subr is a special case.
6740 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6741 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6742 (struct Lisp_Hash_Table): Combine first two members into a single
6743 struct vectorlike_header member. All uses of "size" and "next" members
6744 changed to be "header.size" and "header.next".
6745 * buffer.h (struct buffer): Likewise.
6746 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6747 * frame.h (struct frame): Likewise.
6748 * process.h (struct Lisp_Process): Likewise.
6749 * termhooks.h (struct terminal): Likewise.
6750 * window.c (struct save_window_data, struct saved_window): Likewise.
6751 * window.h (struct window): Likewise.
6752 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6753 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6754 * buffer.c (init_buffer_once): Likewise.
6755 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6757 * process.c (Fformat_network_address): Use local var for size,
6760 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6762 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6763 * data.c (atof): Remove decl; no longer used or needed.
6764 (digit_to_number): Move to lread.c.
6765 (Fstring_to_number): Use new string_to_number function, to be
6766 consistent with how the Lisp reader treats infinities and NaNs.
6767 Do not assume that floating-point numbers represent EMACS_INT
6768 without losing information; this is not true on most 64-bit hosts.
6769 Avoid double-rounding errors, by insisting on integers when
6770 parsing non-base-10 numbers, as the documentation specifies.
6771 * lisp.h (string_to_number): New decl, replacing ...
6772 (isfloat_string): Remove.
6773 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6774 (read1): Do not accept +. and -. as integers; this
6775 appears to have been a coding error. Similarly, do not accept
6776 strings like +-1e0 as floating point numbers. Do not report
6777 overflow for integer overflows unless the base is not 10 which
6778 means we have no simple and reliable way to continue.
6779 Break out the floating-point parsing into a new
6780 function string_to_number, so that Fstring_to_number parses
6781 floating point numbers consistently with the Lisp reader.
6782 (digit_to_number): Move here from data.c. Make it static inline.
6783 (E_CHAR, EXP_INT): Remove, replacing with ...
6784 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6785 (string_to_number): New function, replacing isfloat_string.
6786 This function checks for valid syntax and produces the resulting
6787 Lisp float number too. Rework it so that string-to-number
6788 no longer mishandles examples like "1.0e+". Use strtoumax,
6789 so that overflow for non-base-10 numbers is reported only when
6790 there's no portable and simple way to convert to floating point.
6792 * textprop.c (set_text_properties_1): Rewrite for clarity,
6793 and to avoid GCC warning about integer overflow.
6795 * intervals.h (struct interval): Use EMACS_INT for members
6796 where EMACS_UINT might cause problems. See
6797 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6798 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6799 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6801 (offset_intervals): Tell GCC not to worry about length overflow
6802 when negating a negative length.
6804 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6805 (overrun_check_free): Likewise.
6807 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6808 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6811 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6812 (gnutls_make_error): Rename local to avoid shadowing.
6813 (gnutls_emacs_global_deinit): ifdef out; not used.
6814 (Fgnutls_boot): Use const for pointer to readonly storage.
6815 Comment out unused local. Fix pointer signedness problems.
6817 * lread.c (openp): Don't stuff size_t into an 'int'.
6818 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6819 about possible signed overflow.
6821 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6822 (GDK_KEY_g): Don't define if already defined.
6823 (xg_prepare_tooltip): Avoid pointer signedness problem.
6824 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6826 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6827 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6829 * xfns.c (Fx_window_property): Simplify a bit,
6830 to make a bit faster and to avoid GCC 4.6.0 warning.
6831 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6833 * fns.c (internal_equal): Don't assume size_t fits in int.
6835 * alloc.c (compact_small_strings): Tighten assertion a little.
6837 Replace pEd with more-general pI, and fix some printf arg casts.
6838 * lisp.h (pI): New macro, generalizing old pEd macro to other
6839 conversion specifiers. For example, use "...%"pI"d..." rather
6840 than "...%"pEd"...".
6841 (pEd): Remove. All uses replaced with similar uses of pI.
6842 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6843 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6844 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6845 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6846 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6847 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6848 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6850 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6851 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6852 * print.c (safe_debug_print, print_object): Likewise.
6853 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6855 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6856 avoiding the 0 flag, which is not portable.
6857 * process.c (Fmake_network_process): Use pI to avoid cast.
6858 * region-cache.c (pp_cache): Likewise.
6859 * xdisp.c (decode_mode_spec): Likewise.
6860 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6861 behavior on 64-bit hosts with printf arg.
6862 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6863 (x_stop_queuing_selection_requests): Likewise.
6864 (x_get_window_property): Don't truncate byte count to an 'int'
6867 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6868 here, since it parses constructs like leading '-' and spaces,
6869 which are not wanted; and it overflows with large numbers.
6870 Instead, simply match F[0-9]+, which is what is wanted anyway.
6872 * alloc.c: Remove unportable assumptions about struct layout.
6873 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6874 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6875 (allocate_vectorlike, make_pure_vector): Use the new macros,
6876 plus offsetof, to remove unportable assumptions about struct layout.
6877 These assumptions hold on all porting targets that I know of, but
6878 they are not guaranteed, they're easy to remove, and removing them
6879 makes further changes easier.
6881 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6882 This doesn't fix a bug but makes the code clearer.
6883 (string_overrun_cookie): Now const. Use initializers that
6884 don't formally overflow signed char, to avoid warnings.
6885 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6886 can cause Emacs to crash when string overrun checking is enabled.
6887 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6888 multiple of sizeof (EMACS_INT); it need not be, if
6889 alignof(EMACS_INT) < sizeof (EMACS_INT).
6890 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6892 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6894 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6896 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6898 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6899 supposed to be handshaking. (Bug#8556)
6900 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6902 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6904 * lisp.h (Qdebug): List symbol.
6905 * eval.c (Qdebug): Restore global linkage.
6906 * keyboard.c (debug-on-event): New variable.
6907 (handle_user_signal): Break into debugger when debug-on-event
6908 matches the current signal symbol.
6910 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6912 * alloc.c (check_sblock, check_string_bytes)
6913 (check_string_free_list): Convert to standard C.
6915 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6917 * w32.c (emacs_gnutls_push): Fix typo.
6919 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6921 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6922 "cast to pointer from integer of different size".
6924 Improve doprnt and its use in verror. (Bug#8545)
6925 * doprnt.c (doprnt): Document the set of format control sequences
6926 supported by the function. Use SAFE_ALLOCA instead of always
6929 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6930 is one byte too soon. Don't use xrealloc; instead xfree and
6933 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6935 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6938 * gnutls.c: Renamed global_initialized to
6939 gnutls_global_initialized. Added internals for the
6940 :verify-hostname-error, :verify-error, and :verify-flags
6941 parameters of `gnutls-boot' and documented those parameters in the
6942 docstring. Start callback support.
6943 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6944 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6945 on error. Return error code.
6946 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6947 (emacs_gnutls_read): Likewise.
6948 (Fgnutls_boot): Return handshake error code.
6949 (emacs_gnutls_handle_error): New function.
6950 (wsaerror_to_errno): Likewise.
6952 * w32.h (emacs_gnutls_pull): Add prototype.
6953 (emacs_gnutls_push): Likewise.
6955 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6956 (emacs_gnutls_push): Likewise.
6958 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6960 * process.c (wait_reading_process_output): Check if GnuTLS
6961 buffered some data internally if no FDs are set for TLS
6964 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6965 (LIBS): Link to USER_LIBS.
6966 ($(BLD)/gnutls.$(0)): New target.
6968 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6970 * xdisp.c (handle_single_display_spec): Rename the
6971 display_replaced_before_p argument into display_replaced_p, to
6972 make it consistent with the commentary. Fix typos in the
6975 * textprop.c (syms_of_textprop): Remove dead code.
6976 (copy_text_properties): Delete obsolete commentary about an
6977 interface that was deleted long ago. Fix typos in the description
6980 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6981 to changes in oldXMenu/XMenu.h from 2011-04-16.
6982 <menu_help_message, prev_menu_help_message>: Constify.
6983 (IT_menu_make_room): menu->help_text is now `const char **';
6986 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6987 to changes in oldXMenu/XMenu.h from 2011-04-16.
6988 (struct XMenu): Declare `help_text' `const char **'.
6990 * xfaces.c <Qunspecified>: Make extern again.
6992 * syntax.c: Include sys/types.h before including regex.h, as
6995 * doc.c (get_doc_string): Improve the format passed to `error'.
6997 * doprnt.c (doprnt): Improve commentary.
6999 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7001 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7004 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7005 changes in globals.h immediately force recompilation.
7006 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7007 $(CURDIR)/s/ms-w32.h.
7008 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7010 * character.c (Fchar_direction): Function deleted.
7011 (syms_of_character): Don't defsubr it.
7012 <char-direction-table>: Deleted.
7014 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7016 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7017 * doprnt.c: Include limits.h.
7018 (SIZE_MAX): New macro.
7019 (doprnt): Return a size_t value. 2nd arg is now size_t.
7020 Many local variables are now size_t instead of int or unsigned.
7021 Improve overflow protection. Support `l' modifier for integer
7022 conversions. Support %l conversion. Don't assume an EMACS_INT
7023 argument for integer conversions and for %c.
7025 * lisp.h (doprnt): Restore prototype.
7027 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7030 * Makefile.in (base_obj): Add back doprnt.o.
7032 * deps.mk (doprnt.o): Add back prerequisites.
7033 (callint.o): Depend on character.h.
7035 * eval.c (internal_lisp_condition_case): Include the handler
7036 representation in the error message.
7037 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7038 when breaking from the loop.
7040 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7042 * callint.c (Fcall_interactively): When displaying error message
7043 about invalid control letter, pass the character's codepoint, not
7044 a pointer to its multibyte form. Improve display of the character
7045 in octal and display also its hex code.
7047 * character.c (char_string): Use %x to display the (unsigned)
7048 codepoint of an invalid character, to avoid displaying a bogus
7051 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7052 `error', not SYMBOL_NAME itself.
7054 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7055 character arguments to `error'.
7057 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7058 to `error' in error message about FINAL_CHAR argument. Make sure
7059 FINAL_CHAR is a character, and use %c when it is passed as
7060 argument to `error'.
7062 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7064 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7066 * w32.c: Include <time.h>.
7067 (sys_localtime): New function.
7069 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7071 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7073 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7075 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7077 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7080 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7082 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7083 gl_state.e_property when gl_state.object is Qt.
7085 * insdel.c (make_gap_larger): Remove limitation of buffer size
7088 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7090 * xdisp.c (lookup_glyphless_char_display)
7091 (produce_glyphless_glyph): Handle cons cell entry in
7092 glyphless-char-display.
7093 (Vglyphless_char_display): Document it.
7095 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7096 glyphless-char-display.
7098 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7100 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7102 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7104 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7105 definition for no-X builds.
7107 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7109 Static checks with GCC 4.6.0 and non-default toolkits.
7111 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7113 * process.c (keyboard_bit_set): Define only if SIGIO.
7114 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7115 (send_process): Repair possible setjmp clobbering.
7117 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7119 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7121 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7123 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7124 Define only if needed.
7126 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7127 by pacifying GCC about it. Maybe it's time to retire it?
7128 * xfaces.c (USG, __TIMEVAL__): Likewise.
7130 * dispextern.h (struct redisplay_interface): Rename param
7132 * termhooks.h (struct terminal): Likewise.
7133 * xterm.c (xembed_send_message): Likewise.
7135 * insdel.c (make_gap_smaller): Define only if
7136 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7138 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7141 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7142 so that we aren't warned about unused symbols.
7144 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7146 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7148 * xfns.c (x_real_positions): Mark locals as initialized.
7150 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7152 * xterm.c: Fix problems found by static analysis with other toolkits.
7153 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7154 (x_dispatch_event): Declare static if USE_GTK, and
7155 define if USE_GTK || USE_X_TOOLKIT.
7156 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7157 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7158 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7159 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7161 * xmenu.c (menu_help_callback): Pointer type fixes.
7162 Use const pointers when pointing at readonly data. Avoid pointer
7164 (FALSE): Remove unused macro.
7165 (update_frame_menubar): Remove unused decl.
7167 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7169 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7170 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7171 (single_menu_item): Rename local to avoid shadowing.
7173 * keyboard.c (make_lispy_event): Remove unused local var.
7175 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7176 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7178 * bitmaps: Change bitmaps from unsigned char back to the X11
7179 compatible char. Avoid the old compiler warnings about
7180 out-of-range initializers by using, for example, '\xab' rather
7183 * xgselect.c (xgselect_initialize): Check vs interface
7184 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7186 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7188 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7189 to read-only memory.
7191 * fns.c (vector): Remove; this old hack is no longer needed.
7193 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7195 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7197 * xrdb.c (x_load_resources): Omit unused local.
7199 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7200 (x_window): Rename locals to avoid shadowing.
7201 (USG): Use the kludged USG macro, to pacify gcc.
7203 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7204 (x_term_init): Remove local to avoid shadowing.
7206 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7208 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7209 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7211 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7213 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7215 Fix regex.c, syntax.c and friends for buffers > 2GB.
7216 * syntax.h (struct gl_state_s): Declare character position members
7219 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7221 * textprop.c (verify_interval_modification, interval_of):
7222 Declare arguments EMACS_INT.
7224 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7227 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7229 * indent.c (Fvertical_motion): Local variable it_start is now
7232 * regex.c (re_match, re_match_2, re_match_2_internal)
7233 (bcmp_translate, regcomp, regexec, print_double_string)
7234 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7235 (re_compile_pattern, re_exec): Declare arguments and local
7236 variables `size_t' and `ssize_t' and return values `regoff_t', as
7238 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7239 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7240 <compile_stack_type>: `size' and `avail' are now `size_t'.
7242 * regex.h <regoff_t>: Use ssize_t, not int.
7243 (re_search, re_search_2, re_match, re_match_2): Arguments that
7244 specify buffer/string position and length are now ssize_t and
7245 size_t. Return type is regoff_t.
7247 2011-04-16 Ben Key <bkey76@gmail.com>
7249 * nsfont.m: Fixed bugs in ns_get_family and
7250 ns_descriptor_to_entity that were caused by using free to
7251 deallocate memory blocks that were allocated by xmalloc (via
7252 xstrdup). This caused Emacs to crash when compiled with
7253 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7254 --enable-checking=xmallocoverrun). xfree is now used to
7255 deallocate these memory blocks.
7257 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7259 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7261 emacs_write: Accept and return EMACS_INT for sizes.
7262 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7264 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7265 Accept and return EMACS_INT.
7266 (emacs_gnutls_write): Return the number of bytes written on
7268 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7269 (emacs_read, emacs_write): Remove check for negative size, as the
7270 Emacs source code has been audited now.
7271 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7272 (emacs_read, emacs_write): Use it.
7273 * process.c (send_process): Adjust to the new signatures of
7274 emacs_write and emacs_gnutls_write. Do not attempt to store
7275 a byte offset into an 'int'; it might overflow.
7276 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7278 * sound.c: Don't assume sizes fit in 'int'.
7279 (struct sound_device.period_size, alsa_period_size):
7280 Return EMACS_INT, not int.
7281 (struct sound_device.write, vox_write, alsa_write):
7282 Accept EMACS_INT, not int.
7283 (wav_play, au_play): Use EMACS_INT to store sizes and to
7284 record read return values.
7286 2011-04-15 Ben Key <bkey76@gmail.com>
7288 * keyboard.c (Qundefined): Don't declare static since it is used
7290 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7291 static since they are used in nsfont.m.
7293 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7295 * process.c (Qprocessp): Don't declare static.
7296 * lisp.h (Qprocessp): Declare again.
7298 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7300 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7302 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7304 Improve C-level modularity by making more things 'static'.
7306 Don't publish debugger-only interfaces to other modules.
7307 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7308 (verify_bytepos, count_markers): Move decls to the only modules
7310 * region-cache.h (pp_cache): Likewise.
7311 * window.h (check_all_windows): Likewise.
7312 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7314 * sysdep.c (croak): Now static, if
7315 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7316 * syssignal.h (croak): Declare only if not static.
7318 * alloc.c (refill_memory_reserve): Now static if
7319 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7320 * lisp.h (refill_memory_reserve): Declare only if not static.
7322 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7323 Define only if USE_LUCID.
7325 * xrdb.c (x_customization_string, x_rm_string): Now static.
7327 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7328 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7330 * xdisp.c (draw_row_with_mouse_face): Now static.
7331 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7333 * window.h (check_all_windows): Mark externally visible.
7335 * window.c (window_deletion_count): Now static.
7337 * undo.c: Make symbols static if they're not exported.
7338 (last_undo_buffer, last_boundary_position, pending_boundary):
7341 * textprop.c (interval_insert_behind_hooks): Now static.
7342 (interval_insert_in_front_hooks): Likewise.
7344 * term.c: Make symbols static if they're not exported.
7345 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7346 (max_frame_lines, tty_set_terminal_modes):
7347 (tty_reset_terminal_modes, tty_turn_off_highlight):
7348 (get_tty_terminal): Now static.
7349 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7350 * termhooks.h (term_mouse_moveto): Do not declare if
7352 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7353 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7355 * sysdep.c: Make symbols static if they're not exported.
7356 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7358 (sigprocmask_set, full_mask): Remove; unused.
7359 (wait_debugging): Mark as visible.
7360 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7361 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7363 * syntax.c (syntax_temp): Define only if !__GNUC__.
7365 * sound.c (current_sound_device, current_sound): Now static.
7367 * search.c (searchbufs, searchbuf_head): Now static.
7369 * scroll.c (scroll_cost): Remove; unused.
7370 * dispextern.h (scroll_cost): Remove decl.
7372 * region-cache.h (pp_cache): Mark as externally visible.
7374 * process.c: Make symbols static if they're not exported.
7375 (process_tick, update_tick, create_process, chan_process):
7376 (Vprocess_alist, proc_buffered_char, datagram_access):
7377 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7378 (deactivate_process): Mark defn as static, as well as decl.
7379 * lisp.h (create_process): Remove decl.
7380 * process.h (chan_process, Vprocess_alist): Remove decls.
7382 * print.c: Make symbols static if they're not exported.
7383 (print_depth, new_backquote_output, being_printed, print_buffer):
7384 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7385 (print_interval, print_number_index, initial_stderr_stream):
7387 * lisp.h (Fprinc): Remove decl.
7388 (debug_output_compilation_hack): Mark as externally visible.
7390 * sysdep.c (croak): Move decl from here to syssignal.h.
7391 * syssignal.h (croak): Put it here, so the API can be checked when
7392 'croak' is called from dissociate_if_controlling_tty.
7394 * minibuf.c: Make symbols static if they're not exported.
7395 (minibuf_save_list, choose_minibuf_frame): Now static.
7396 * lisp.h (choose_minibuf_frame): Remove decl.
7398 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7400 * lread.c: Make symbols static if they're not exported.
7401 (read_objects, initial_obarray, oblookup_last_bucket_number):
7403 (make_symbol): Remove; unused.
7404 * lisp.h (initial_obarray, make_symbol): Remove decls.
7406 * keyboard.c: Make symbols static if they're not exported.
7407 (single_kboard, recent_keys_index, total_keys, recent_keys):
7408 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7409 (this_single_command_key_start, echoing, last_auto_save):
7410 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7411 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7412 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7413 (Vlispy_mouse_stem, double_click_count):
7415 (force_auto_save_soon): Define only if SIGDANGER.
7416 (ignore_mouse_drag_p): Now static if
7417 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7418 (print_help): Remove; unused.
7419 (stop_character, last_timer_event): Mark as externally visible.
7420 * keyboard.h (ignore_mouse_drag_p): Declare only if
7421 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7422 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7423 * lisp.h (echoing): Remove decl.
7424 (force_auto_save_soon): Declare only if SIGDANGER.
7425 * xdisp.c (redisplay_window): Simplify code, to make it more
7426 obvious that ignore_mouse_drag_p is not accessed if !defined
7427 USE_GTK && !defined HAVE_NS.
7429 * intervals.c: Make symbols static if they're not exported.
7430 (merge_properties_sticky, merge_interval_right, delete_interval):
7432 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7434 * insdel.c: Make symbols static if they're not exported.
7435 However, leave prepare_to_modify_buffer alone. It's never
7436 called from outside this function, but that appears to be a bug.
7437 (combine_after_change_list, combine_after_change_buffer):
7438 (adjust_after_replace, signal_before_change): Now static.
7439 (adjust_after_replace_noundo): Remove; unused.
7440 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7441 (signal_before_change): Remove decls.
7443 * indent.c (val_compute_motion, val_vmotion): Now static.
7445 * image.c: Make symbols static if they're not exported.
7446 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7448 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7449 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7451 * fringe.c (standard_bitmaps): Now static.
7452 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7454 * frame.c: Make symbols static if they're not exported.
7455 (x_report_frame_params, make_terminal_frame): Now static.
7456 (get_frame_param): Now static, unless HAVE_NS.
7457 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7458 (x_get_resource_string): Remove; not used.
7459 * frame.h (make_terminal_frame, x_report_frame_params):
7460 (x_get_resource_string); Remove decls.
7461 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7462 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7464 * font.c, fontset.c: Make symbols static if they're not exported.
7465 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7466 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7467 * font.c (font_close_object): Now static.
7468 * font.h (font_close_object): Remove.
7469 * fontset.c (FONTSET_OBJLIST): Remove.
7470 (free_realized_fontset) #if-0 the body, which does nothing.
7471 (face_suitable_for_char_p): #if-0, as it's never called.
7472 * fontset.h (face_suitable_for_char_p): Remove decl.
7473 * xfaces.c (face_at_string_position):
7474 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7475 since 0 is always ASCII.
7477 * fns.c (weak_hash_tables): Now static.
7479 * fileio.c: Make symbols static if they're not exported.
7480 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7481 (Vwrite_region_annotation_buffers): Now static.
7483 * eval.c: Make symbols static if they're not exported.
7484 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7485 * lisp.h (backtrace_list): Remove decl.
7487 * emacs.c: Make symbols static if they're not exported.
7488 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7489 (fatal_error_code, fatal_error_signal_hook, standard_args):
7491 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7492 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7493 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7494 * lisp.h (fatal_error_signal_hook): Remove decl.
7495 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7497 * editfns.c: Move a (normally-unused) function to its only use.
7498 * editfns.c, lisp.h (get_operating_system_release): Remove.
7499 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7500 worth the hassle of breaking this out.
7502 * xterm.c: Make symbols static if they're not exported.
7503 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7504 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7505 (x_destroy_window, x_delete_display):
7507 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7508 (x_mouse_leave): Remove; unused.
7509 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7510 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7511 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7513 (x_mouse_leave): Declare only if WINDOWSNT.
7514 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7515 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7518 * ftxfont.c: Make symbols static if they're not exported.
7519 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7521 * font.h (ftxfont_driver): Likewise.
7523 * xfns.c: Make symbols static if they're not exported.
7524 (x_last_font_name, x_display_info_for_name):
7525 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7526 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7527 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7528 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7529 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7530 (last_show_tip_args): Now static.
7531 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7532 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7533 (x_screen_planes): Remove; unused.
7534 * dispextern.h (x_screen_planes): Remove decl.
7536 * dispnew.c: Make symbols static if they're not exported.
7537 * dispextern.h (redraw_garbaged_frames, scrolling):
7538 (increment_row_positions): Remove.
7539 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7540 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7542 (redraw_garbaged_frames): Remove; unused.
7544 * xfaces.c: Make symbols static if they're not exported.
7545 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7547 * xterm.h (defined_color): Remove decls.
7548 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7549 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7550 (menu_face_changed_default, defined_color, free_realized_face):
7551 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7552 (ascii_face_of_lisp_face): Remove; unused.
7554 * xdisp.c: Make symbols static if they're not exported.
7555 * dispextern.h (scratch_glyph_row, window_box_edges):
7556 (glyph_to_pixel_coords, set_cursor_from_row):
7557 (get_next_display_element, set_iterator_to_next):
7558 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7559 (show_mouse_face): Remove decls
7560 * frame.h (message_buf_print): Likewise.
7561 * lisp.h (pop_message, set_message, check_point_in_composition):
7563 * xterm.h (set_vertical_scroll_bar): Likewise.
7564 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7565 (message_buf_print, scratch_glyph_row, displayed_buffer):
7566 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7567 (get_next_display_element, show_mouse_face, window_box_edges):
7568 (frame_to_window_pixel_xy, check_point_in_composition):
7569 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7570 (glyph_to_pixel_coords): Remove; unused.
7572 * dired.c (file_name_completion): Now static.
7574 * dbusbind.c (xd_in_read_queued_messages): Now static.
7576 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7577 * data.c (circular_list_error): Remove.
7579 * commands.h (last_point_position, last_point_position_buffer):
7580 (last_point_position_window): Remove decls.
7581 * keyboard.c: Make these variables static.
7583 * coding.h (coding, code_convert_region, encode_coding_gap):
7585 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7586 (iso_code_class, detect_coding, code_convert_region): Now static.
7587 (encode_coding_gap): Remove; unused.
7589 * chartab.c (chartab_chars, chartab_bits): Now static.
7591 * charset.h (charset_iso_8859_1): Remove decl.
7592 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7595 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7596 * ccl.c (Vccl_program_table): Now static.
7597 (check_ccl_update): Remove; unused.
7599 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7600 * category.h: ... from here.
7601 * category.c (check_category_table, set_category_set): Now static.
7603 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7604 * lisp.h: Remove these decls.
7606 * buffer.c (buffer_count): Remove unused var.
7608 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7609 so that it's not optimized away.
7610 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7611 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7612 exported only to the debugger.
7614 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7615 * atimer.h (run_all_atimers): Remove; not exported.
7617 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7618 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7619 was inaccessible from Lisp.
7620 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7621 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7623 alloc.c: Import and export fewer symbols, and remove unused items.
7624 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7626 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7627 it's not optimized away by whole-program optimization.
7628 (message_enable_multibyte, free_misc): Remove.
7629 (catchlist, handlerlist, mark_backtrace):
7630 Declare only if BYTE_MARK_STACK.
7631 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7632 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7633 (message_enable_multibyte): Remove decl.
7634 (free_misc, interval_free_list, float_block, float_block_index):
7635 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7636 (cons_free_list, last_marked_index):
7638 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7639 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7640 (mark_backtrace): Define only if BYTE_MARK_STACK.
7641 * xdisp.c (message_enable_multibyte): Now static.
7643 Declare Lisp_Object Q* variables to be 'static' if not exported.
7644 This makes it easier for human readers (and static analyzers)
7645 to see whether these variables are used from other modules.
7646 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7647 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7648 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7649 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7650 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7651 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7652 * xmenu.c, xselect.c:
7653 Declare Q* vars static if they are not used in other modules.
7654 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7655 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7656 Remove decls of unexported vars.
7657 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7659 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7661 Make Emacs functions such as Fatom 'static' by default.
7662 This makes it easier for human readers (and static analyzers)
7663 to see whether these functions can be called from other modules.
7664 DEFUN now defines a static function. To make the function external
7665 so that it can be used in other C modules, use the new macro DEFUE.
7666 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7667 (Finit_image_library):
7668 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7669 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7670 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7671 Remove decls, since these functions are now static.
7672 (Funintern, Fget_internal_run_time): New decls, since these functions
7673 were already external.
7675 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7676 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7677 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7678 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7679 * keyboard.c, keymap.c, lread.c:
7680 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7681 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7682 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7683 Mark functions with DEFUE instead of DEFUN,
7684 if they are used in other modules.
7685 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7686 decls for now-static functions.
7687 * buffer.h (Fdelete_overlay): Remove decl.
7688 * callproc.c (Fgetenv_internal): Mark as internal.
7689 * composite.c (Fremove_list_of_text_properties): Remove decl.
7690 (Fcomposition_get_gstring): New forward static decl.
7691 * composite.h (Fcomposite_get_gstring): Remove decl.
7692 * dired.c (Ffile_attributes): New forward static decl.
7693 * doc.c (Fdocumntation_property): New forward static decl.
7694 * eval.c (Ffetch_bytecode): New forward static decl.
7695 (Funintern): Remove extern decl; now in .h file where it belongs.
7696 * fileio.c (Fmake_symbolic_link): New forward static decl.
7697 * image.c (Finit_image_library): New forward static decl.
7698 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7699 * intervals.h (Fprevious_property_change):
7700 (Fremove_list_of_text_properties): Remove decls.
7701 * keyboard.c (Fthis_command_keys): Remove decl.
7702 (Fcommand_execute): New forward static decl.
7703 * keymap.c (Flookup_key): New forward static decl.
7704 (Fcopy_keymap): Now static.
7705 * keymap.h (Flookup_key): Remove decl.
7706 * process.c (Fget_process): New forward static decl.
7707 (Fprocess_datagram_address): Mark as internal.
7708 * syntax.c (Fsyntax_table_p): New forward static decl.
7709 (skip_chars): Remove duplicate decl.
7710 * textprop.c (Fprevious_property_change): New forward static decl.
7711 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7713 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7714 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7716 * editfns.c (Fformat): Remove unreachable code.
7718 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7720 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7723 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7725 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7726 when at ZV. (Bug#8487)
7728 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7730 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7732 * keyboard.c (parse_tool_bar_item): Likewise.
7733 * sound.c (sound_cleanup, alsa_close): Likewise.
7734 * termcap.c (tgetent): Likewise.
7735 * xfns.c (x_default_font_parameter): Likewise.
7736 * xsettings.c (read_and_apply_settings): Likewise.
7738 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7739 (overrun_check_free): Protoize.
7741 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7743 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7744 since callers should never pass a negative size.
7745 Change the signature to match that of plain 'read' and 'write'; see
7746 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7747 * lisp.h: Update prototypes of emacs_write and emacs_read.
7749 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7751 * xdisp.c (redisplay_window): Don't try to determine the character
7752 position of the scroll margin if the window start point w->startp
7753 is outside the buffer's accessible region. (Bug#8468)
7755 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7757 Fix write-region and its subroutines for buffers > 2GB.
7758 * fileio.c (a_write, e_write): Modify declaration of arguments and
7759 local variables to support buffers larger than 2GB.
7760 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7762 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7763 argument, local variables, and return value.
7765 * lisp.h: Update prototypes of emacs_write and emacs_read.
7767 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7769 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7771 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7773 Fix more problems found by GCC 4.6.0's static checks.
7775 * xdisp.c (vmessage): Use a better test for character truncation.
7777 * charset.c (load_charset_map): <, not <=, for optimization,
7778 and to avoid potential problems with integer overflow.
7779 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7780 * casetab.c (set_identity, shuffle): Likewise.
7781 * editfns.c (Fformat): Likewise.
7782 * syntax.c (skip_chars): Likewise.
7784 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7785 This also lets GCC 4.6.0 generate slightly better loop code.
7787 * callint.c (Fcall_interactively): <, not <=, for optimization.
7788 (Fcall_interactively): Count the number of arguments produced,
7789 not the number of arguments given. This is simpler and lets GCC
7790 4.6.0 generate slightly better code.
7792 * ftfont.c: Distingish more carefully between FcChar8 and char.
7793 The previous code passed unsigned char * to a functions like
7794 strlen and xstrcasecmp that expect char *, which does not
7795 conform to the C standard.
7796 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7797 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7798 char * when the C standard requires it.
7800 * keyboard.c (read_char): Remove unused var.
7802 * eval.c: Port to Windows vsnprintf (Bug#8435).
7804 (SIZE_MAX): Define if the headers do not.
7805 (verror): Do not give up if vsnprintf returns a negative count.
7806 Instead, grow the buffer. This ports to Windows vsnprintf, which
7807 does not conform to C99. Problem reported by Eli Zaretskii.
7808 Also, simplify the allocation scheme, by avoiding the need for
7809 calling realloc, and removing the ALLOCATED variable.
7811 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7813 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7814 But keep the doprint source code for now, as we might revamp it
7815 and use it again (Bug#8435).
7816 * lisp.h (doprnt): Remove.
7817 * Makefile.in (base_obj): Remove doprnt.o.
7818 * deps.mk (doprnt.o): Remove.
7820 error: Print 32- and 64-bit integers portably (Bug#8435).
7821 Without this change, on typical 64-bit hosts error ("...%d...", N)
7822 was used to print both 32- and 64-bit integers N, which relied on
7824 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7825 * lisp.h (error, verror): Mark as printf-like functions.
7826 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7827 Report overflow in size calculations when allocating printf buffer.
7828 Do not truncate output string at its first null byte.
7829 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7830 Truncate the output at a character boundary, since vsnprintf does not
7832 * charset.c (check_iso_charset_parameter): Convert internal
7833 character to string before calling 'error', since %c now has the
7835 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7836 overflow when computing char to be passed to 'error'. Do not
7837 pass Lisp_Object to 'error'; pass the integer instead.
7838 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7839 formatted with plain %d.
7841 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7843 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7845 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7847 * xterm.c (x_catch_errors): Remove duplicate declaration.
7849 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7851 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7853 2011-04-10 Jim Meyering <meyering@redhat.com>
7855 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7856 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7857 return ssize_t not "int", and use size_t as the buffer length.
7858 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7859 * gnutls.h: Update declarations.
7860 * process.c (read_process_output): Use ssize_t, to match.
7861 (send_process): Likewise.
7863 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7865 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7867 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7869 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7870 Use unsigned char, to match FcChar8 type definition.
7872 * xterm.c (handle_one_xevent):
7873 * xmenu.c (create_and_show_popup_menu):
7874 * xselect.c (x_decline_selection_request)
7875 (x_reply_selection_request): Avoid type-punned deref of X events.
7877 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7879 Fix some uses of `int' instead of EMACS_INT.
7880 * search.c (string_match_1, fast_string_match)
7881 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7882 (scan_buffer, find_next_newline_no_quit)
7883 (find_before_next_newline, search_command, Freplace_match)
7884 (Fmatch_data): Make some `int' variables be EMACS_INT.
7886 * xdisp.c (display_count_lines): 3rd argument and return value now
7887 EMACS_INT. All callers changed.
7888 (pint2hrstr): Last argument is now EMACS_INT.
7890 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7891 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7892 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7893 (decode_coding_utf_16, decode_coding_emacs_mule)
7894 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7895 (decode_coding_ccl, decode_coding_charset)
7896 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7897 (decode_coding_iso_2022, decode_coding_emacs_mule)
7898 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7899 <char_offset, last_offset>: Declare EMACS_INT.
7900 (encode_coding_utf_8, encode_coding_utf_16)
7901 (encode_coding_emacs_mule, encode_invocation_designation)
7902 (encode_designation_at_bol, encode_coding_iso_2022)
7903 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7904 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7906 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7907 (encode_invocation_designation): Last argument P_NCHARS is now
7909 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7910 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7912 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7915 * ccl.c (Fccl_execute_on_string): Declare some variables
7918 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7920 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7922 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7924 * process.c (Fformat_network_address): Doc fix.
7926 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7928 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7930 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7932 * keyboard.c (read_char): Call Lisp function help-form-show,
7933 instead of using internal_with_output_to_temp_buffer.
7934 (Qhelp_form_show): New var.
7935 (syms_of_keyboard): Use DEFSYM macro.
7937 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7939 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7941 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7943 * process.c (Flist_processes): Remove to Lisp.
7944 (list_processes_1): Delete.
7946 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7948 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7950 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7952 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7954 Fix more problems found by GCC 4.6.0's static checks.
7956 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7958 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7960 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7962 * xdisp.c (vmessage): Mark as a printf-like function.
7964 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7966 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7968 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7969 printf-like functions.
7970 (tiff_load): Add casts to remove these marks before passing them
7971 to system-supplied API.
7973 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7975 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7976 This avoids several warnings with gcc -Wstrict-overflow.
7977 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7978 directly, rather than having caller test rule sign. This avoids
7979 some unnecessary tests.
7980 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7981 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7982 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7984 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7985 (xfont_open): Avoid unnecessary tests.
7987 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7989 * composite.h, composite.c (composition_gstring_put_cache):
7990 Use EMACS_INT, not int, for length.
7992 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7993 breaking out part of COMPOSITION_DECODE_RULE.
7994 (COMPOSITION_DECODE_RULE): Use it.
7995 * composite.c (get_composition_id): Remove unused local vars,
7996 by using the new macro.
7998 * textprop.c (set_text_properties_1): Change while to do-while,
7999 since the condition is always true at first.
8001 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8002 (interval_deletion_adjustment): Return unsigned value.
8005 * process.c (list_processes_1, create_pty, read_process_output):
8006 (exec_sentinel): Remove vars that were set but not used.
8007 (create_pty): Remove unnecessary "volatile"s.
8008 (Fnetwork_interface_info): Avoid possibility of int overflow.
8009 (read_process_output): Do adaptive read buffering even if carryover.
8010 (read_process_output): Simplify nbytes computation if buffered.
8012 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8014 * syntax.c (scan_words): Remove var that was set but not used.
8015 (update_syntax_table): Use unsigned instead of int.
8017 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8018 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8019 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8021 * print.c (print_error_message): Avoid int overflow.
8023 * font.c (font_list_entities): Redo for clarity,
8024 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8026 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8027 (font_score): Avoid potential overflow in diff calculation.
8029 * fns.c (substring_both): Remove var that is set but not used.
8030 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8032 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8034 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8035 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8036 can always succeed if overflow has undefined behavior.
8038 * search.c (boyer_moore, wordify): Remove vars set but not used.
8039 (wordify): Omit three unnecessary tests.
8041 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8042 All callers changed. This avoids the need for an unused var.
8044 * casefiddle.c (casify_region): Remove var that is set but not used.
8046 * dired.c (file_name_completion): Remove var that is set but not used.
8048 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8050 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8051 (Finsert_file_contents): Remove unnecessary code checking fd.
8053 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8054 Check for integer overflow on size calculations.
8056 * buffer.c (Fprevious_overlay_change): Remove var that is set
8059 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8060 Remove vars that are set but not used.
8061 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8062 (timer_check_2): Mark vars as initialized.
8064 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8066 * image.c (lookup_image): Remove var that is set but not used.
8067 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8069 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8070 that are set but not used.
8072 * xfns.c (make_invisible_cursor): Don't return garbage
8073 if XCreateBitmapFromData fails (Bug#8410).
8075 * xselect.c (x_get_local_selection, x_handle_property_notify):
8076 Remove vars that are set but not used.
8078 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8079 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8081 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8082 Remove var that is set but not used.
8083 (scroll_bar_windows_size): Now size_t, not int.
8084 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8087 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8088 (map_tty_color) [!defined MSDOS]: Likewise.
8090 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8092 * coding.c: Remove vars that are set but not used.
8093 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8094 All callers changed.
8095 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8096 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8097 (decode_coding_charset): Remove vars that are set but not used.
8099 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8100 that is set but not used.
8102 * print.c (print_object): Remove var that is set but not used.
8104 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8105 The gnulib version avoids calling malloc in the usual case,
8106 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8107 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8108 * filelock.c (current_lock_owner): Likewise.
8109 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8110 * sysdep.c: Include allocator.h, careadlinkat.h.
8111 (emacs_no_realloc_allocator): New static constant.
8112 (emacs_readlink): New function.
8113 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8114 ../lib/careadlinkat.h.
8116 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8118 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8119 first non-nil return value).
8121 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8123 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8124 if not defined (Bug#8403).
8126 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8128 * xdisp.c (display_count_lines): Remove parameter `start',
8129 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8130 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8131 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8132 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8133 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8134 and thereabouts. All callers changed.
8135 (get_per_char_metric): Remove parameter `f', unused since
8136 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8138 2011-04-02 Jim Meyering <meyering@redhat.com>
8140 do not dereference NULL upon failed strdup
8141 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8142 (ns_get_family): Likewise.
8144 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8146 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8148 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8150 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8153 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8155 Add lexical binding.
8157 * window.c (Ftemp_output_buffer_show): New fun.
8158 (Fsave_window_excursion):
8159 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8161 * lread.c (lisp_file_lexically_bound_p): New function.
8162 (Fload): Bind Qlexical_binding.
8163 (readevalloop): Remove `evalfun' arg.
8164 Bind Qinternal_interpreter_environment.
8165 (Feval_buffer): Bind Qlexical_binding.
8166 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8168 (syms_of_lread): Declare `lexical-binding'.
8170 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8172 * keyboard.c (eval_dyn): New fun.
8173 (menu_item_eval_property): Use it.
8175 * image.c (parse_image_spec): Use Ffunctionp.
8177 * fns.c (concat, mapcar1): Accept byte-code-functions.
8179 * eval.c (Fsetq): Handle lexical vars.
8180 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8181 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8182 (FletX, Flet): Obey lexical binding.
8183 (Fcommandp): Handle closures.
8184 (Feval): New `lexical' arg.
8185 (eval_sub): New function extracted from Feval. Use it almost
8186 everywhere where Feval was used. Look up vars in lexical env.
8188 (Ffunctionp): Move from subr.el.
8189 (Ffuncall): Handle closures.
8190 (apply_lambda): Remove `eval_flags'.
8191 (funcall_lambda): Handle closures and new byte-code-functions.
8192 (Fspecial_variable_p): New function.
8193 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8194 but without exporting it to Lisp.
8196 * doc.c (Fdocumentation, store_function_docstring):
8197 * data.c (Finteractive_form): Handle closures.
8199 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8202 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8204 (exec_byte_code): New function extracted from Fbyte_code to handle new
8205 calling convention for byte-code-functions. Add new byte-codes.
8207 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8209 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8211 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8213 * xdisp.c (redisplay_internal): Fix prototype.
8215 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8217 * xdisp.c (SCROLL_LIMIT): New macro.
8218 (try_scrolling): Use it when setting scroll_limit.
8219 Limit scrolling to 100 screen lines.
8220 (redisplay_window): Even when falling back on "recentering",
8221 position point in the window according to scroll-conservatively,
8222 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8224 (try_scrolling): When point is above the window, allow searching
8225 as far as scroll_max, or one screenful, to compute vertical
8226 distance from PT to the scroll margin position. This prevents
8227 try_scrolling from unnecessarily failing when
8228 scroll-conservatively is set to a value slightly larger than the
8229 window height. Clean up the case of PT below the margin at bottom
8230 of window: scroll_max can no longer be INT_MAX. When aggressive
8231 scrolling is in use, don't let point enter the opposite scroll
8232 margin as result of the scroll.
8233 (syms_of_xdisp) <scroll-conservatively>: Document the
8234 threshold of 100 lines for never-recentering scrolling.
8236 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8238 * dispextern.h (move_it_by_lines):
8239 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8240 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8241 (message_log_check_duplicate): Remove parameters `prev_bol' and
8242 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8243 (redisplay_internal): Remove parameter `preserve_echo_area',
8244 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8246 * indent.c (Fvertical_motion):
8247 * window.c (window_scroll_pixel_based, Frecenter):
8248 Don't pass `need_y_p' to `move_it_by_lines'.
8250 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8252 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8253 steal a few bits to be more compact.
8254 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8255 Remove unneeded casts.
8257 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8259 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8261 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8262 binding" message (bug#7967).
8264 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8266 Fix more problems found by GCC 4.6.0's static checks.
8268 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8269 Remove unused local var.
8271 * editfns.c (Fmessage_box): Remove unused local var.
8273 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8274 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8275 Omit unused local vars.
8276 * window.c (shrink_windows): Omit unused local var.
8277 * menu.c (digest_single_submenu): Omit unused local var.
8278 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8279 Omit unused local var.
8281 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8282 Don't assume string length fits in int.
8283 (keyremap_step, read_key_sequence): Use size_t for sizes.
8284 (read_key_sequence): Don't check last_real_key_start redundantly.
8286 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8287 instead of alloca (Bug#8344).
8289 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8290 (Fbacktrace_frame): Don't assume nframes fits in int.
8292 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8294 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8297 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8299 * cm.c (calccost): Turn while-do into do-while, for clarity.
8301 * keyboard.c (syms_of_keyboard): Use the same style as later
8302 in this function when indexing through an array. This also
8303 works around GCC bug 48267.
8305 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8307 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8309 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8310 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8312 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8313 This avoids undefined behavior on integer overflow, and is a bit
8314 more convenient anyway since it is compared to a size_t variable.
8316 Variadic C functions now count arguments with size_t, not int.
8317 This avoids an unnecessary limitation on 64-bit machines, which
8318 caused (substring ...) to crash on large vectors (Bug#8344).
8319 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8320 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8321 All variadic functions and their callers changed accordingly.
8322 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8323 * data.c (arith_driver, float_arith_driver): Likewise.
8324 * editfns.c (general_insert_function): Likewise.
8325 * eval.c (struct backtrace.nargs, interactive_p)
8326 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8327 (funcall_lambda, mark_backtrace): Likewise.
8328 * fns.c (concat): Likewise.
8329 * frame.c (x_set_frame_parameters): Likewise.
8330 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8331 0 if not found, not -1. All callers changed.
8333 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8334 (stack_copy_size): Now size_t, not int.
8335 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8337 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8339 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8340 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8341 All callers changed.
8343 * lisp.h (multibyte_char_to_unibyte):
8344 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8345 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8346 * character.h (CHAR_TO_BYTE8):
8347 * cmds.c (internal_self_insert):
8348 * editfns.c (general_insert_function):
8349 * keymap.c (push_key_description):
8350 * search.c (Freplace_match):
8351 * xdisp.c (message_dolog, set_message_1): All callers changed.
8353 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8355 * keyboard.c (safe_run_hook_funcall): New function.
8356 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8357 don't set the hook to nil, but remove the offending function instead.
8358 (Qcommand_hook_internal): Remove, unused.
8359 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8360 Vcommand_hook_internal.
8362 * eval.c (enum run_hooks_condition): Remove.
8363 (funcall_nil, funcall_not): New functions.
8364 (run_hook_with_args): Call each function through a `funcall' argument.
8365 Remove `cond' argument, now redundant.
8366 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8367 (Frun_hook_with_args_until_failure): Adjust accordingly.
8368 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8370 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8372 * dispextern.h (string_buffer_position): Remove declaration.
8374 * print.c (strout): Remove parameter `multibyte', unused since
8375 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8377 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8378 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8379 All callers changed.
8381 * w32.c (_wsa_errlist): Use braces for struct initializers.
8383 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8384 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8385 All callers changed.
8386 (string_buffer_position): Likewise. Also, make static (it's never
8387 used outside xdisp.c).
8388 (cursor_row_p): Remove parameter `w', unused since
8389 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8390 (decode_mode_spec): Remove parameter `precision', introduced during
8391 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8392 All callers changed.
8394 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8396 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8398 2011-03-27 Anders Lindgren <andlind@gmail.com>
8400 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8401 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8402 (ns_update_auto_hide_menu_bar): New functions.
8403 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8404 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8405 ns_constrain_all_frames.
8406 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8407 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8409 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8411 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8413 2011-03-27 Glenn Morris <rgm@gnu.org>
8415 * syssignal.h: Replace RETSIGTYPE with void.
8416 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8417 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8418 Replace SIGTYPE with void everywhere.
8419 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8420 * s/template.h (SIGTYPE): Remove commented out definition.
8422 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8424 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8425 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8427 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8429 * w32.c (read_unc_volume): Use parameter `henum', instead of
8430 global variable `wget_enum_handle'.
8432 * keymap.c (describe_vector): Remove parameters `indices' and
8433 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8434 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8436 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8438 * keyboard.c (timer_check): Remove parameter `do_it_now',
8439 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8440 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8441 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8443 * keyboard.c (read_char):
8444 * w32menu.c (w32_menu_display_help):
8445 * xmenu.c (show_help_event, menu_help_callback):
8446 Adjust calls to `show_help_echo'.
8448 * gtkutil.c (xg_maybe_add_timer):
8449 * keyboard.c (readable_events):
8450 * process.c (wait_reading_process_output):
8451 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8453 * insdel.c (adjust_markers_gap_motion):
8454 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8455 (gap_left, gap_right): Don't call it.
8457 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8459 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8460 incurred during fontification.
8462 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8464 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8465 (DEFVAR_PER_BUFFER): Don't pass it.
8467 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8468 (scrolling_window): Don't pass it.
8470 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8472 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8474 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8476 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8477 of variables specific to SELinux and computation of `encoded_absname'.
8479 * image.c (XPutPixel): Remove unused variable `height'.
8481 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8483 * unexw32.c (get_section_info): Remove unused variable `section'.
8485 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8486 (system_process_attributes): Remove unused variable `sess'.
8487 (sys_read): Remove unused variable `err'.
8489 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8490 (w32_wnd_proc): Remove unused variable `isdead'.
8491 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8492 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8493 (x_create_tip_frame): Remove unused variable `tem'.
8495 * w32inevt.c (w32_console_read_socket):
8496 Remove unused variable `no_events'.
8498 * w32term.c (x_draw_composite_glyph_string_foreground):
8499 Remove unused variable `width'.
8501 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8503 * w32term.c (x_set_glyph_string_clipping):
8504 Don't pass uninitialized region to CombineRgn.
8506 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8508 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8509 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8510 (Fx_close_connection): Remove unused variable `i'.
8512 * w32font.c (w32font_draw): Return number of glyphs.
8513 (w32font_open_internal): Remove unused variable `i'.
8514 (w32font_driver): Add missing initializer.
8516 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8517 (fill_in_menu): Remove unused variable `items_added'.
8519 * w32term.c (last_mouse_press_frame): Remove static global variable.
8520 (w32_clip_to_row): Remove unused variable `f'.
8521 (x_delete_terminal): Remove unused variable `i'.
8523 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8524 (NOTHING): Remove unused static global variable.
8525 (uniscribe_check_otf): Remove unused variable `table'.
8526 (uniscribe_font_driver): Add missing initializers.
8528 2011-03-23 Julien Danjou <julien@danjou.info>
8530 * term.c (Fsuspend_tty, Fresume_tty):
8531 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8532 * window.c (temp_output_buffer_show):
8533 * insdel.c (signal_before_change):
8534 * frame.c (Fhandle_switch_frame):
8535 * fileio.c (Fdo_auto_save):
8536 * emacs.c (Fkill_emacs):
8537 * editfns.c (save_excursion_restore):
8538 * cmds.c (internal_self_insert):
8539 * callint.c (Fcall_interactively):
8540 * buffer.c (Fkill_all_local_variables):
8541 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8543 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8544 unconditionally since it does the check itself.
8546 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8548 Fix more problems found by GCC 4.5.2's static checks.
8550 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8551 the first time through the loop, since we know p0 < p1 then.
8552 This also avoids a gcc -Wstrict-overflow warning.
8554 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8555 leading to a memory leak, possible in functions like
8556 load_charset_map_from_file that can allocate an unbounded number
8557 of objects (Bug#8318).
8559 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8560 that could (at least in theory) be that large.
8562 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8563 This is less likely to overflow, and avoids undefined behavior if
8564 overflow does occur. All callers changed. Use strtoul to scan
8565 for the unsigned long integer.
8566 (pint2hrstr): Simplify and tune code slightly.
8567 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8569 * scroll.c (do_scrolling): Work around GCC bug 48228.
8570 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8572 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8573 This also avoids a warning with gcc -Wstrict-overflow.
8574 (validate_x_resource_name): Simplify count usage.
8575 This also avoids a warning with gcc -Wstrict-overflow.
8577 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8580 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8582 * process.c (Fmake_network_process): Use socklen_t, not int,
8583 where POSIX says socklen_t is required in portable programs.
8584 This fixes a porting bug on hosts like 64-bit HP-UX, where
8585 socklen_t is wider than int (Bug#8277).
8586 (Fmake_network_process, server_accept_connection):
8587 (wait_reading_process_output, read_process_output):
8590 * process.c: Rename or move locals to avoid shadowing.
8591 (list_processes_1, Fmake_network_process):
8592 (read_process_output_error_handler, exec_sentinel_error_handler):
8593 Rename or move locals.
8594 (Fmake_network_process): Define label "retry_connect" only if needed.
8595 (Fnetwork_interface_info): Fix pointer signedness.
8596 (process_send_signal): Add cast to avoid pointer signedness problem.
8597 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8598 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8600 Make tparam.h and terminfo.c consistent.
8601 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8602 Include tparam.h instead, since it declares them.
8603 * cm.h (PC): Remove extern decl; tparam.h now does this.
8604 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8605 * terminfo.c: Include tparam.h, to check interfaces.
8606 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8607 (tparam): Adjust signature to match interface in tparam.h;
8608 this removes some undefined behavior. Check that outstring and len
8609 are zero, which they always are with Emacs.
8610 * tparam.h (PC, BC, UP): New extern decls.
8612 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8613 (xftfont_open): Rename locals to avoid shadowing.
8615 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8616 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8617 (OTF_TAG_SYM): Omit macro if not needed.
8618 (ftfont_list): Remove unused local.
8619 (get_adstyle_property, ftfont_pattern_entity):
8620 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8621 Rename locals to avoid shadowing.
8623 * xfont.c (xfont_list_family): Mark var as initialized.
8625 * xml.c (make_dom): Now static.
8627 * composite.c (composition_compute_stop_pos): Rename local to
8629 (composition_reseat_it): Remove unused locals.
8630 (find_automatic_composition, composition_adjust_point): Likewise.
8631 (composition_update_it): Mark var as initialized.
8632 (find_automatic_composition): Mark vars as initialized,
8633 with a FIXME (Bug#8290).
8635 character.h: Rename locals to avoid shadowing.
8636 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8637 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8638 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8639 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8642 * textprop.c (property_change_between_p): Remove; unused.
8644 * intervals.c (interval_start_pos): Now static.
8646 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8648 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8649 Rename locals to avoid shadowing.
8651 * sound.c (wav_play, au_play, Fplay_sound_internal):
8652 Fix pointer signedness.
8653 (alsa_choose_format): Remove unused local var.
8654 (wav_play): Initialize a variable to 0, to prevent undefined
8655 behavior (Bug#8278).
8657 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8659 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8661 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8662 clobbering (Bug#8298).
8663 * sysdep.c (sys_subshell): Likewise.
8664 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8666 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8667 This should get cleaned up, so that child_setup has the
8668 same signature on all platforms.
8670 * callproc.c (call_process_cleanup): Now static.
8671 (relocate_fd): Rename locals to avoid shadowing.
8673 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8675 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8676 not to be necessary, and produces flickering.
8678 2011-03-20 Glenn Morris <rgm@gnu.org>
8680 * config.in: Remove file.
8682 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8684 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8685 are now in src/globals.h.
8686 (syms_of_minibuf): Remove spurious & from previous change.
8688 2011-03-20 Leo Liu <sdl.web@gmail.com>
8690 * minibuf.c (completing-read-function): New variable.
8691 (completing-read-default): Rename from completing-read.
8692 (completing-read): Call completing-read-function.
8694 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8696 * xfaces.c (Fx_load_color_file):
8697 Read color file from absolute filename (bug#8250).
8699 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8701 * makefile.w32-in: Update dependencies.
8703 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8705 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8707 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8709 Fix more problems found by GCC 4.5.2's static checks.
8711 * process.c (make_serial_process_unwind, send_process_trap):
8712 (sigchld_handler): Now static.
8714 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8715 That way, the code declares only the vars that it needs.
8716 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8717 * s/cygwin.h (PTY_ITERATION): Likewise.
8718 * s/darwin.h (PTY_ITERATION): Likewise.
8719 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8721 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8722 * process.c (allocate_pty): Don't declare stb unless it's needed.
8724 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8725 (CONSTANTLIM): Remove; unused.
8726 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8727 Define only if needed.
8729 * unexelf.c (unexec): Name an expression,
8730 to avoid gcc -Wbad-function-cast warning.
8731 Use a different way to cause a compilation error if anyone uses
8732 n rather than nn, a way that does not involve shadowing.
8733 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8735 * deps.mk (unexalpha.o): Remove; unused.
8737 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8738 * unexec.h: New file.
8739 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8740 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8742 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8743 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8744 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8745 Change as necessary to match prototype in unexec.h.
8747 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8749 (back_comment, skip_chars): Mark vars as initialized.
8751 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8752 Rename locals to avoid shadowing.
8754 * lread.c (read1): Rewrite so as not to use empty "else".
8755 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8757 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8759 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8760 warning when compiling print.c.
8762 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8763 instead of using an uninitialized var.
8764 (font_sort_entities): Mark var as initialized.
8766 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8768 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8769 pointers to constants.
8770 (font_parse_fcname): Remove unused vars.
8771 (font_delete_unmatched): Now static.
8772 (font_get_spec): Remove; unused.
8773 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8774 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8775 Rename or move locals to avoid shadowing.
8777 * fns.c (require_nesting_list, require_unwind): Now static.
8778 (Ffillarray): Rename locals to avoid shadowing.
8780 * floatfns.c (domain_error2): Define only if needed.
8781 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8783 * alloc.c (mark_backtrace): Move decl from here ...
8784 * lisp.h: ... to here, so that it can be checked.
8786 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8787 (Fdefvar): Rewrite so as not to use empty "else".
8788 (lisp_indirect_variable): Name an expression,
8789 to avoid gcc -Wbad-function-cast warning.
8790 (Fdefvar): Rename locals to avoid shadowing.
8792 * callint.c (quotify_arg, quotify_args): Now static.
8793 (Fcall_interactively): Rename locals to avoid shadowing.
8794 Use const pointer when appropriate.
8796 * lisp.h (get_system_name, get_operating_system_release):
8797 Move decls here, to check interfaces.
8798 * process.c (get_operating_system_release): Move decl to lisp.h.
8799 * xrdb.c (get_system_name): Likewise.
8800 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8801 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8802 some of which prompt warnings from gcc -Wbad-function-cast.
8803 (Fformat_time_string, Fencode_time, Finsert_char):
8804 (Ftranslate_region_internal, Fformat):
8805 Rename or remove local vars to avoid shadowing.
8806 (Ftranslate_region_internal): Mark var as initialized.
8808 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8811 * lisp.h (eassert): Check that the argument compiles, even if
8812 ENABLE_CHECKING is not defined.
8814 * data.c (Findirect_variable): Name an expression, to avoid
8815 gcc -Wbad-function-cast warning.
8816 (default_value, arithcompare, arith_driver, arith_error): Now static.
8817 (store_symval_forwarding): Rename local to avoid shadowing.
8818 (Fmake_variable_buffer_local, Fmake_local_variable):
8819 Mark variables as initialized.
8820 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8822 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8823 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8824 Rename locals to avoid shadowing.
8825 (mark_stack): Move local variables into the #ifdef region where
8827 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8828 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8830 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8831 (GC_STRING_CHARS): Remove; not used.
8832 (Fmemory_limit): Cast sbrk's returned value to char *.
8834 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8835 avoids undefined behavior in theory.
8837 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8839 Use functions, not macros, for up- and down-casing (Bug#8254).
8840 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8841 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8842 to use the following functions instead of these macros.
8843 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8844 EMACS_INT, since callers assume the returned value fits in int.
8845 (upcase1): Likewise, for UPCASE_TABLE.
8846 (uppercasep, lowercasep, upcase): New static inline functions.
8847 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8848 the race-condition problem in the old DOWNCASE.
8850 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8851 Rename locals to avoid shadowing.
8852 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8853 (regex_compile, re_search_2, re_match_2_internal):
8854 Remove unused local vars.
8855 (FREE_VAR): Rewrite so as not to use empty "else",
8856 which gcc can warn about.
8857 (regex_compile, re_match_2_internal): Mark locals as initialized.
8858 (RETALLOC_IF): Define only if needed.
8859 (WORDCHAR_P): Likewise. This one is never needed, but is used
8860 only in a comment talking about a compiler bug, so put inside
8861 the #if 0 of that comment.
8862 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8863 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8866 * search.c (boyer_moore): Rename locals to avoid shadowing.
8867 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8868 (PREV_CHAR_BOUNDARY): Likewise.
8870 * search.c (simple_search): Remove unused var.
8872 * dired.c (compile_pattern): Move decl from here ...
8873 * lisp.h: ... to here, so that it can be checked.
8874 (struct re_registers): New forward decl.
8876 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8878 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8880 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8881 Rename locals to avoid shadowing.
8882 (Fvertical_motion): Mark locals as initialized.
8884 * casefiddle.c (casify_object, casify_region): Now static.
8885 (casify_region): Mark local as initialized.
8887 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8889 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8890 New macros, so that the caller can use some names other than
8891 gcpro1, gcpro2, etc.
8892 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8894 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8895 argument, for consistency with GCPRO2_VAR, etc: it is now the
8896 prefix of the variable, not the variable itself. All uses
8898 * dired.c (directory_files_internal, file_name_completion):
8899 Rename locals to avoid shadowing.
8901 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8902 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8903 dired.c's scmp function, had undefined behavior.
8904 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8905 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8906 * buffer.h: ... to here, because these macros use current_buffer,
8907 and the new implementation with inline functions needs to have
8908 current_buffer in scope now, rather than later when the macros
8910 (downcase, upcase1): New static inline functions.
8911 (DOWNCASE, UPCASE1): Reimplement using these functions.
8912 This avoids undefined behavior in expressions like
8913 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8914 from race conditions in accessing the global variables
8915 case_temp1 and case_temp2.
8916 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8917 * lisp.h (case_temp1, case_temp2): Remove their decls.
8918 * character.h (ASCII_CHAR_P): Move from here ...
8919 * lisp.h: ... to here, so that the inline functions mentioned
8922 * dired.c (directory_files_internal_unwind): Now static.
8924 * fileio.c (file_name_as_directory, directory_file_name):
8925 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8927 (file_name_as_directory): Use const pointers when appropriate.
8928 (Fexpand_file_name): Likewise. In particular, newdir might
8929 point at constant storage, so make it a const pointer.
8930 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8931 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8933 (Fset_file_times, Finsert_file_contents, auto_save_error):
8934 Rename locals to avoid shadowing.
8936 * minibuf.c (choose_minibuf_frame_1): Now static.
8937 (Ftry_completion, Fall_completions): Rename or remove locals
8940 * marker.c (bytepos_to_charpos): Remove; unused.
8942 * lisp.h (verify_bytepos, count_markers): New decls,
8943 so that gcc does not warn that these functions aren't declared.
8945 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8946 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8947 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8948 (copy_text): Remove unused local var.
8950 * filelock.c (within_one_second): Now static.
8951 (lock_file_1): Rename local to avoid shadowing.
8953 * buffer.c (fix_overlays_before): Mark locals as initialized.
8954 (fix_start_end_in_overlays): Likewise. This function should be
8955 simplified by using pointers-to-pointers, but that's a different
8957 (switch_to_buffer_1): Now static.
8958 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8959 (report_overlay_modification): Rename locals to avoid shadowing.
8961 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8962 Fix pointer signedness issue.
8963 (sys_subshell): Mark local as volatile if checking for lint,
8964 to suppress a gcc -Wclobbered warning that does not seem to be right.
8965 (MAXPATHLEN): Define only if needed.
8967 * process.c (serial_open, serial_configure): Move decls from here ...
8968 * systty.h: ... to here, so that they can be checked.
8970 * fns.c (get_random, seed_random): Move extern decls from here ...
8971 * lisp.h: ... to here, so that they can be checked.
8973 * sysdep.c (reset_io): Now static.
8974 (wait_for_termination_signal): Remove; unused.
8976 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8977 (copy_keymap_item, append_key, push_text_char_description):
8979 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8980 (DENSE_TABLE_SIZE): Remove; unused.
8981 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8982 (describe_map_tree):
8983 Rename locals to avoid shadowing.
8985 * keyboard.c: Declare functions static if they are not used elsewhere.
8986 (echo_char, echo_dash, cmd_error, top_level_2):
8987 (poll_for_input, handle_async_input): Now static.
8988 (read_char, kbd_buffer_get_event, make_lispy_position):
8989 (make_lispy_event, make_lispy_movement, apply_modifiers):
8990 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8991 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8992 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8993 (read_key_sequence, read_char): Mark locals as initialized.
8994 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8996 * keyboard.h (make_ctrl_char): New decl.
8997 (mark_kboards): Move decl here ...
8998 * alloc.c (mark_kboards): ... from here.
9000 * lisp.h (force_auto_save_soon): New decl.
9002 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9003 (DEFINE_DUMMY_FUNCTION): New macro.
9004 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9006 (main): Add casts to avoid warnings
9007 if GCC considers string literals to be constants.
9009 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9011 * dbusbind.c: Pointer signedness fixes.
9012 (xd_signature, xd_append_arg, xd_initialize):
9013 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9014 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9015 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9016 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9018 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9019 if GCC considers string literals to be constants.
9020 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9022 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9024 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9025 (print_preprocess, print_object): New macro to fix last change.
9027 * print.c (print_preprocess): Don't forget font objects.
9029 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9031 * emacs.c (USAGE3): Doc fixes.
9033 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9035 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9038 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9040 * lisp.h (VWindow_system, Qfile_name_history):
9041 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9042 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9043 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9045 * w32select.c: Don't #include "keyboard.h".
9046 (run_protected): Add extern declaration for waiting_for_input.
9048 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9049 * w32console.c (detect_input_pending, read_input_pending)
9050 (encode_terminal_code):
9051 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9052 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9053 (w32_system_caret_y, Qfile_name_history):
9054 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9055 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9056 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9057 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9058 * w32proc.c (Qlocal, report_file_error):
9059 * w32term.c (Vwindow_system, updating_frame):
9060 * w32uniscribe.c (initialized, uniscribe_font_driver):
9061 Remove unneeded extern declarations.
9063 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9065 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9067 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9069 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9070 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9071 These macros can no longer be used for assignment.
9073 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9074 Assign struct members directly, instead of using BUF_BEGV etc.
9075 (record_buffer_markers, fetch_buffer_markers): New functions for
9076 recording and fetching special buffer markers.
9077 (set_buffer_internal_1, set_buffer_temp): Use them.
9079 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9081 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9083 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9084 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9086 * xdisp.c (hscroll_window_tree):
9087 (reconsider_clip_changes): Use PT instead of BUF_PT.
9089 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9091 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9092 $(EMACS_ROOT)/lib/intprops.h.
9094 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9096 Fix more problems found by GCC 4.5.2's static checks.
9098 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9099 to unsigned char * to avoid compiler diagnostic.
9100 (xg_free_frame_widgets): Make it clear that a local variable is
9101 needed only if USE_GTK_TOOLTIP.
9102 (gdk_window_get_screen): Make it clear that this macro is needed
9103 only if USE_GTK_TOOLTIP.
9104 (int_gtk_range_get_value): New function, which avoids a diagnostic
9105 from gcc -Wbad-function-cast.
9106 (xg_set_toolkit_scroll_bar_thumb): Use it.
9107 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9108 diagnostic from gcc -Wbad-function-cast.
9109 (get_utf8_string, xg_get_file_with_chooser):
9110 Rename locals to avoid shadowing.
9111 (create_dialog): Move locals to avoid shadowing.
9113 * xgselect.c (xg_select): Remove unused var.
9115 * image.c (four_corners_best): Mark locals as initialized.
9116 (gif_load): Initialize transparent_p to zero (Bug#8238).
9117 Mark another local as initialized.
9118 (my_png_error, my_error_exit): Mark with NO_RETURN.
9120 * image.c (clear_image_cache): Now static.
9121 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9122 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9123 (x_edge_detection): Remove unnecessary cast that
9124 gcc -Wbad-function-cast diagnoses.
9125 (gif_load): Fix pointer signedness.
9126 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9127 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9129 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9131 Improve quality of tests for time stamp overflow.
9132 For example, without this patch (encode-time 0 0 0 1 1
9133 1152921504606846976) returns the obviously-bogus value (-948597
9134 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9135 reports time overflow. See
9136 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9137 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9138 * editfns.c: Include limits.h and intprops.h.
9139 (TIME_T_MIN, TIME_T_MAX): New macros.
9140 (time_overflow): Move earlier, to before first use.
9141 (hi_time, lo_time): New functions, for an accurate test for
9143 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9144 (Fget_internal_run_time): Don't assume time_t fits in int.
9145 (make_time): Use list2 instead of Fcons twice.
9146 (Fdecode_time): More accurate test for out-of-range times.
9147 (check_tm_member): New function.
9148 (Fencode_time): Use it, to test for out-of-range times.
9149 (lisp_time_argument): Don't rely on undefined left-shift and
9150 right-shift behavior when checking for time stamp overflow.
9152 * editfns.c (time_overflow): New function, refactoring common code.
9153 (Fformat_time_string, Fdecode_time, Fencode_time):
9154 (Fcurrent_time_string): Use it.
9156 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9157 * dired.c (make_time): Move to ...
9158 * editfns.c (make_time): ... here.
9159 * systime.h: Note the move.
9161 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9163 * fringe.c (update_window_fringes): Remove unused variables.
9165 * unexmacosx.c (copy_data_segment): Also copy __got section.
9168 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9170 * termcap.c [MSDOS]: Include "msdos.h".
9171 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9172 Constify `char *' arguments and their references according to
9173 prototypes in tparam.h.
9175 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9177 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9178 Adapt all references accordingly.
9180 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9182 2011-03-11 Tom Tromey <tromey@redhat.com>
9184 * buffer.c (syms_of_buffer): Remove obsolete comment.
9186 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9188 * termhooks.h (encode_terminal_code): Declare prototype.
9190 * msdos.c (encode_terminal_code): Don't declare prototype.
9192 * term.c (encode_terminal_code): Now external again, used by
9193 w32console.c and msdos.c.
9195 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9196 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9198 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9200 Fix some minor problems found by GCC 4.5.2's static checks.
9202 * fringe.c (update_window_fringes): Mark locals as initialized
9204 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9206 * alloc.c (mark_fringe_data): Move decl from here ...
9207 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9208 to check its interface.
9209 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9211 * fontset.c (free_realized_fontset): Now static.
9212 (Fset_fontset_font): Rename local to avoid shadowing.
9213 (fontset_font): Mark local as initialized.
9214 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9216 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9218 * xselect.c (x_disown_buffer_selections): Remove; not used.
9219 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9220 (x_own_selection, Fx_disown_selection_internal): Rename locals
9222 (x_handle_dnd_message): Remove local to avoid shadowing.
9224 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9225 so that the caller can use some name other than gcpro1.
9226 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9227 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9228 (Fx_backspace_delete_keys_p):
9229 Use them to avoid shadowing, and rename vars to avoid shadowing.
9230 (x_decode_color, x_set_name, x_window): Now static.
9231 (Fx_create_frame): Add braces to silence GCC warning.
9232 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9233 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9234 Remove unused locals.
9235 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9236 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9237 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9240 * xterm.h (x_mouse_leave): New decl.
9242 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9243 Remove unused functions.
9244 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9245 (x_calc_absolute_position): Now static.
9246 (XTread_socket): Don't define label "out" unless it's used.
9247 Don't declare local "event" unless it's used.
9248 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9249 unless they are used.
9250 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9251 (x_fatal_error_signal): Remove; not used.
9252 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9253 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9254 (x_error_catcher, x_connection_closed, x_error_handler):
9255 (x_error_quitter, xembed_send_message, x_iconify_frame):
9256 (my_log_handler): Rename locals to avoid shadowing.
9257 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9258 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9260 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9261 Rename or move locals to avoid shadowing.
9262 (tty_defined_color, merge_face_heights): Now static.
9263 (free_realized_faces_for_fontset): Remove; not used.
9264 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9265 does not deduce is never used uninitialized.
9266 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9267 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9269 * terminal.c (store_terminal_param): Now static.
9271 * xmenu.c (menu_highlight_callback): Now static.
9272 (set_frame_menubar): Remove unused local.
9273 (xmenu_show): Rename parameter to avoid shadowing.
9274 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9275 since they might point to immutable storage.
9276 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9277 since it's unused otherwise.
9279 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9280 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9281 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9282 avoids a gcc -Wuninitialized diagnostic.
9283 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9284 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9285 does not deduce are never used uninitialized.
9287 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9289 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9290 * window.c (window_loop, size_window):
9291 (run_window_configuration_change_hook, enlarge_window): Likewise.
9293 * window.c (display_buffer): Now static.
9294 (size_window): Mark variables that gcc -Wuninitialized
9295 does not deduce are never used uninitialized.
9296 * window.h (check_all_windows): New decl, to forestall
9297 gcc -Wmissing-prototypes diagnostic.
9298 * dispextern.h (bidi_dump_cached_states): Likewise.
9300 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9302 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9304 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9305 and to avoid gcc -Wuninitialized warning.
9306 (load_charset_map): Mark variables that gcc -Wuninitialized
9307 does not deduce are never used uninitialized.
9308 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9310 * coding.c (coding_set_source, coding_set_destination):
9311 Use "else { /* comment */ }" rather than "else /* comment */;"
9312 for clarity, and to avoid gcc -Wempty-body warning.
9313 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9314 a block, when the outer 'i' will do.
9315 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9316 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9317 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9318 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9319 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9320 Rename locals to avoid shadowing.
9321 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9322 * coding.c (emacs_mule_char, encode_invocation_designation):
9323 Now static, since they're not used elsewhere.
9324 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9325 (decode_coding_object, encode_coding_object, detect_coding_system):
9326 (decode_coding_emacs_mule): Mark variables that gcc
9327 -Wuninitialized does not deduce are never used uninitialized.
9328 (detect_coding_iso_2022): Initialize a local variable that might
9329 be used uninitialized. Leave a FIXME because it's not clear that
9330 this initialization is needed. (Bug#8211)
9331 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9332 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9333 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9334 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9335 Remove unused macros.
9337 * category.c (hash_get_category_set): Remove unused local var.
9338 (copy_category_table): Now static, since it's not used elsewhere.
9339 * character.c (string_count_byte8): Likewise.
9341 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9342 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9344 * chartab.c (copy_sub_char_table): Now static, since it's not used
9346 (sub_char_table_ref_and_range, char_table_ref_and_range):
9347 Rename locals to avoid shadowing.
9348 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9350 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9351 (BIDI_BOB): Remove unused macro.
9353 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9354 deduce are never used uninitialized.
9355 * term.c (encode_terminal_code): Likewise.
9357 * term.c (encode_terminal_code): Now static. Remove unused local.
9359 * tparam.h: New file.
9360 * term.c, tparam.h: Include it.
9361 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9362 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9363 Move these decls to tparam.h, and make them agree with what
9364 is actually in tparam.c. The previous trick of using incompatible
9365 decls in different modules does not conform to the C standard.
9366 All callers of tparam changed to use tparam's actual API.
9367 * tparam.c (tparam1, tparam, tgoto):
9368 Use const pointers where appropriate.
9370 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9371 * cm.h (struct cm): Likewise.
9372 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9373 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9374 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9375 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9376 (turn_on_face, init_tty): Likewise.
9377 * termchar.h (struct tty_display_info): Likewise.
9379 * term.c (term_mouse_position): Rename local to avoid shadowing.
9381 * alloc.c (mark_ttys): Move decl from here ...
9382 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9384 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9386 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9388 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9390 * search.c (compile_pattern_1): Remove argument regp, unused since
9391 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9392 (compile_pattern): Don't pass it.
9394 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9396 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9397 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9399 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9401 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9403 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9404 gdk_window_get_screen, gdk_window_get_geometry,
9405 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9406 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9407 (xg_get_pixbuf_from_pixmap): New function.
9408 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9409 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9410 Call xg_get_pixbuf_from_pixmap instead of
9411 gdk_pixbuf_get_from_drawable.
9412 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9413 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9414 (xg_check_special_colors): Use GtkStyleContext and its functions
9416 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9417 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9418 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9419 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9420 Call gtk_widget_get_preferred_size.
9421 (xg_frame_resized): gdk_window_get_geometry only takes 5
9423 (xg_win_to_widget, xg_event_is_for_menubar):
9424 Call gdk_x11_window_lookup_for_display.
9425 (xg_set_widget_bg): New function.
9426 (delete_cb): New function.
9427 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9428 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9429 (xg_set_background_color): Call xg_set_widget_bg.
9430 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9431 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9432 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9433 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9435 (update_frame_tool_bar): Call gtk_widget_hide.
9436 (xg_initialize): Use GDK_KEY_g.
9438 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9440 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9442 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9443 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9444 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9446 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9448 * w32xfns.c (select_palette): Check success of RealizePalette against
9449 GDI_ERROR, not zero.
9451 See ChangeLog.11 for earlier changes.
9457 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9459 This file is part of GNU Emacs.
9461 GNU Emacs is free software: you can redistribute it and/or modify
9462 it under the terms of the GNU General Public License as published by
9463 the Free Software Foundation, either version 3 of the License, or
9464 (at your option) any later version.
9466 GNU Emacs is distributed in the hope that it will be useful,
9467 but WITHOUT ANY WARRANTY; without even the implied warranty of
9468 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9469 GNU General Public License for more details.
9471 You should have received a copy of the GNU General Public License
9472 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.