mm-bodies.el (mm-decode-content-transfer-encoding): Allow leading whitespace in base6...
[bpt/emacs.git] / src / ChangeLog
1 2011-05-19 Glenn Morris <rgm@gnu.org>
2
3 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6 (lisp): Set the order to that of loadup.el.
7 (shortlisp): Make it a copy of $lisp.
8 (SOME_MACHINE_LISP): Remove.
9 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11
12 2011-05-18 Kenichi Handa <handa@m17n.org>
13
14 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
15 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
16 (find_automatic_composition): Mostly rewrite for efficiency.
17
18 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
19
20 * makefile.w32-in: Update dependencies.
21
22 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
23
24 * menu.c: Include limits.h (fixes the MS-Windows build broken by
25 revision 104625).
26
27 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
28
29 Fix some integer overflow issues, such as string length overflow.
30
31 * insdel.c (count_size_as_multibyte): Check for string overflow.
32
33 * character.c (lisp_string_width): Check for string overflow.
34 Use EMACS_INT, not int, for string indexes and lengths; in
35 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
36 the resulting string length overflows an EMACS_INT; instead,
37 report a string overflow if no precision given. When checking for
38 precision exhaustion, use a check that cannot possibly have
39 integer overflow. (Bug#8675)
40 * character.h (lisp_string_width): Adjust to new signature.
41
42 * alloc.c (string_overflow): New function.
43 (Fmake_string): Use it. This doesn't change behavior, but saves
44 a few bytes and will simplify future changes.
45 * character.c (string_escape_byte8): Likewise.
46 * lisp.h (string_overflow): New decl.
47
48 Fixups, following up to the user-interface timestamp change.
49 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
50 for UI timestamps, instead of unsigned long.
51 * msdos.c (mouse_get_pos): Likewise.
52 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
53 * w32gui.h (Time): Define by including "systime.h" rather than by
54 declaring it ourselves. (Bug#8664)
55
56 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
57 * image.c (clear_image_cache): Likewise.
58
59 * term.c (term_mouse_position): Don't assume time_t wraparound.
60
61 Be more systematic about user-interface timestamps.
62 Before, the code sometimes used 'Time', sometimes 'unsigned long',
63 and sometimes 'EMACS_UINT', to represent these timestamps. This
64 change causes it to use 'Time' uniformly, as that's what X uses.
65 This makes the code easier to follow, and makes it easier to catch
66 integer overflow bugs such as Bug#8664.
67 * frame.c (Fmouse_position, Fmouse_pixel_position):
68 Use Time, not unsigned long, for user-interface timestamps.
69 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
70 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
71 * keyboard.h (last_event_timestamp): Likewise.
72 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
73 * menu.h (xmenu_show): Likewise.
74 * term.c (term_mouse_position): Likewise.
75 * termhooks.h (struct input_event.timestamp): Likewise.
76 (struct terminal.mouse_position_hook): Likewise.
77 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
78 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
79 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
80 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
81 what it was before.
82 * menu.h, termhooks.h: Include "systime.h", for Time.
83
84 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
85 Don't assume that the difference between two unsigned long values
86 can fit into an integer. At this point, we know button_down_time
87 <= event->timestamp, so the difference must be nonnegative, so
88 there's no need to cast the result if double-click-time is
89 nonnegative, as it should be; check that it's nonnegative, just in
90 case. This bug is triggered when events are more than 2**31 ms
91 apart (about 25 days). (Bug#8664)
92
93 * xselect.c (last_event_timestamp): Remove duplicate decl.
94 (x_own_selection): Remove needless cast to unsigned long.
95
96 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
97 that always fit in int. Use a sentinel instead of a counter, to
98 avoid a temp and to allay GCC's concerns about possible int overflow.
99 * frame.h (struct frame): Use int for menu_bar_items_used
100 instead of EMACS_INT, since it always fits in int.
101
102 * menu.c (grow_menu_items): Check for int overflow.
103
104 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
105
106 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
107 Before, the code was not consistent. These values cannot exceed
108 2**31 - 1 so there's no need to make them unsigned.
109 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
110 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
111 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
112 as modifiers.
113 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
114
115 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
116 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
117 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
118 presumably because the widths might not match.
119
120 * window.c (size_window): Avoid needless test at loop start.
121
122 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
123
124 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
125
126 2011-05-12 Drew Adams <drew.adams@oracle.com>
127
128 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
129
130 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
131
132 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
133 `width' to `bar_area_x' and `bar_area_width', respectively.
134 (x_scroll_run): Take account of fringe background extension.
135
136 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
137 Rename local vars `left' and `width' to `bar_area_x' and
138 `bar_area_width', respectively.
139 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
140 background extension.
141
142 2011-05-10 Jim Meyering <meyering@redhat.com>
143
144 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
145
146 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
147
148 * image.c (Finit_image_library): Return t for built-in image types,
149 like pbm and xbm. (Bug#8640)
150
151 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
152
153 * w32menu.c (set_frame_menubar): Fix submenu allocation.
154
155 2011-05-07 Eli Zaretskii <eliz@gnu.org>
156
157 * w32console.c (Fset_screen_color): Doc fix.
158 (Fget_screen_color): New function.
159 (syms_of_ntterm): Defsubr it.
160
161 * callproc.c (call_process_cleanup): Don't close and unlink the
162 temporary file if Fcall_process didn't create it in the first
163 place.
164 (Fcall_process): Don't create tempfile if stdout of the child
165 process will be redirected to a file specified with `:file'.
166 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
167 cue to call_process_cleanup not to close that handle.
168
169 2011-05-07 Ben Key <bkey76@gmail.com>
170
171 * makefile.w32-in: The bootstrap-temacs rule now makes use of
172 one of two shell specific rules, either bootstrap-temacs-CMD or
173 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
174 to the previous implementation of the bootstrap-temacs rule.
175 The bootstrap-temacs-CMD rule is similar to the previous
176 implementation of the bootstrap-temacs rule except that it
177 makes use of the ESC_CFLAGS variable instead of the CFLAGS
178 variable.
179
180 These changes, along with some changes to nt/configure.bat,
181 nt/gmake.defs, and nt/nmake.defs, are required to extend my
182 earlier fix to add support for --cflags and --ldflags options
183 that include quotes so that it works whether make uses cmd or
184 sh as the shell.
185
186 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
187
188 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
189 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
190 is a constant.
191 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
192 a string. Handle both cases.
193 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
194 (Fdbus_register_method): Use Qinvalid_function.
195
196 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
197
198 * makefile.w32-in: Update dependencies.
199 (LISP_H): Add inttypes.h and stdin.h.
200 (PROCESS_H): Add unistd.h.
201
202 2011-05-06 Eli Zaretskii <eliz@gnu.org>
203
204 * lread.c: Include limits.h (fixes the MS-Windows build broken by
205 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
206
207 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
208
209 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
210
211 * term.c (vfatal): Remove stray call to va_end.
212 It's not needed and the C Standard doesn't allow it here anyway.
213
214 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
215 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
216
217 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
218 bytes.
219
220 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
221
222 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
223
224 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
225
226 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
227
228 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
229
230 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
231 * charset.c (Fdefine_charset_internal): Don't initialize
232 charset.code_space[15]. The value was garbage, on hosts with
233 32-bit int (Bug#8600).
234
235 * lread.c (read_integer): Be more consistent with string-to-number.
236 Use string_to_number to do the actual conversion; this avoids
237 rounding errors and fixes some other screwups. Without this fix,
238 for example, #x1fffffffffffffff was misread as -2305843009213693952.
239 (digit_to_number): Move earlier, for benefit of read_integer.
240 Return -1 if the digit is out of range for the base, -2 if it is
241 not a digit in any supported base. (Bug#8602)
242
243 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
244
245 * dispnew.c (scrolling_window): Return 1 if we scrolled,
246 to match comment at start of function. This also removes a
247 GCC warning about overflow in a 32+64-bit port.
248
249 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
250
251 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
252 Reported by Stefan Monnier in
253 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
254 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
255 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
256
257 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
258 (EMACS_UINTPTR): Likewise, with uintptr_t.
259
260 * lisp.h: Prefer 64-bit EMACS_INT if available.
261 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
262 on 32-bit hosts that have 64-bit int, so that they can access
263 large files.
264 However, temporarily disable this change unless the temporary
265 symbol WIDE_EMACS_INT is defined.
266
267 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
268
269 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
270 This removes an assumption that EMACS_INT and long are the same
271 width as pointers. The assumption is true for Emacs porting targets
272 now, but we want to make other targets possible.
273 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
274 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
275 In the rest of the code, change types of integers that hold casted
276 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
277 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
278 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
279 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
280 No need to cast type when ORing.
281 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
282 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
283 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
284 assume EMACS_INT is the same width as char *.
285 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
286 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
287 Remove no-longer-needed casts.
288 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
289 (xg_tool_bar_help_callback, xg_make_tool_item):
290 Use EMACS_INTPTR to hold an integer
291 that will be cast to void *; this can avoid a GCC warning
292 if EMACS_INT is not the same width as void *.
293 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
294 * xdisp.c (display_echo_area_1, resize_mini_window_1):
295 (current_message_1, set_message_1):
296 Use a local to convert to proper width without a cast.
297 * xmenu.c (dialog_selection_callback): Likewise.
298
299 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
300 Also, don't assume VALBITS / RAND_BITS is less than 5,
301 and don't rely on undefined behavior when shifting a 1 left into
302 the sign bit.
303 * lisp.h (get_random): Change signature to match.
304
305 * lread.c (hash_string): Use size_t, not int, for hash computation.
306 Normally we prefer signed values; but hashing is special, because
307 it's better to use unsigned division on hash table sizes so that
308 the remainder is nonnegative. Also, size_t is the natural width
309 for hashing into memory. The previous code used 'int', which doesn't
310 retain enough info to hash well into very large tables.
311 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
312
313 * dbusbind.c: Don't possibly lose pointer info when converting.
314 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
315 Use XPNTR rather than XHASH, so that the high-order bits of
316 the pointer aren't lost when converting through void *.
317
318 * eval.c (Fautoload): Don't double-shift a pointer.
319
320 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
321
322 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
323
324 * gnutls.c (DEF_GNUTLS_FN):
325 * image.c (DEF_IMGLIB_FN): Make function pointers static.
326
327 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
328
329 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
330 marker. (Bug#8610)
331
332 2011-05-05 Eli Zaretskii <eliz@gnu.org>
333
334 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
335 New version that can reserve upto 2GB of heap space.
336
337 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
338
339 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
340
341 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
342
343 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
344 `gnutls_certificate_set_x509_key_file'.
345
346 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
347
348 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
349 Update dependencies.
350
351 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
352
353 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
354 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
355 Remove unused parameter `fildes'.
356 * process.c (read_process_output, send_process): Don't pass it.
357
358 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
359
360 Fix previous change: the library cache is defined in w32.c.
361 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
362 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
363
364 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
365
366 Implement dynamic loading of GnuTLS on Windows.
367
368 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
369 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
370 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
371 Declare.
372
373 * gnutls.c (Qgnutls_dll): Define.
374 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
375 (gnutls_*): Declare function pointers.
376 (init_gnutls_functions): New function to initialize function pointers.
377 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
378 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
379 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
380 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
381 (emacs_gnutls_write, emacs_gnutls_read)
382 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
383 (Fgnutls_available_p): New function.
384 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
385 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
386 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
387
388 * image.c: Include w32.h.
389 (Vimage_type_cache): Delete.
390 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
391 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
392 (w32_delayed_load): Move to w32.c.
393
394 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
395
396 * w32.c (QCloaded_from, Vlibrary_cache): Define.
397 (w32_delayed_load): Move from image.c. When loading a library, record
398 its filename in the :loaded-from property of the library id.
399 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
400 Initialize and staticpro them.
401 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
402
403 * process.c: Include lisp.h before w32.h, not after.
404 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
405 instead of gnutls_record_check_pending.
406
407 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
408
409 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
410
411 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
412 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
413 as passed in.
414
415 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
416
417 * xterm.c (x_set_frame_alpha): Do not set property on anything
418 else than FRAME_X_OUTER_WINDOW (Bug#8608).
419
420 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
421
422 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
423
424 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
425
426 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
427 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
428 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
429 (gnutls_global_initialized, Qgnutls_bootprop_priority)
430 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
431 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
432 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
433 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
434 (Qgnutls_bootprop_callbacks_verify): Make static.
435
436 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
437
438 * callproc.c: Indentation fixup.
439
440 * sysdep.c (wait_for_termination_1): Make static.
441 (wait_for_termination, interruptible_wait_for_termination):
442 Move after wait_for_termination_1.
443
444 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
445
446 * sysdep.c (interruptible_wait_for_termination): New function
447 which is like wait_for_termination, but allows keyboard
448 interruptions.
449
450 * callproc.c (Fcall_process): Add (:file "file") as an option for
451 the STDOUT buffer.
452 (Fcall_process_region): Ditto.
453
454 2011-04-30 Eli Zaretskii <eliz@gnu.org>
455
456 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
457 rather than `XVECTOR (FOO)->size'.
458
459 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
460 inttypes.h, as a gnulib replacement is used if it not available in
461 system headers.
462
463 2011-04-21 Eli Zaretskii <eliz@gnu.org>
464
465 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
466 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
467 of MOST_POSITIVE_FIXNUM. (Bug#8528)
468
469 * coding.c (coding_alloc_by_realloc): Error out if destination
470 will grow beyond MOST_POSITIVE_FIXNUM.
471 (decode_coding_emacs_mule): Abort if there isn't enough place in
472 charbuf for the composition carryover bytes. Reserve an extra
473 space for up to 2 characters produced in a loop.
474 (decode_coding_iso_2022): Abort if there isn't enough place in
475 charbuf for the composition carryover bytes.
476
477 2011-04-21 Eli Zaretskii <eliz@gnu.org>
478
479 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
480 aborting when %lld or %lll format is passed.
481 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
482 %llo or %llx format is passed. (Bug#8545)
483
484 * window.c (window_scroll_line_based): Use a marker instead of
485 simple variables to record original value of point. (Bug#7952)
486
487 * doprnt.c (doprnt): Fix the case where a multibyte sequence
488 produced by %s or %c overflows available buffer space. (Bug#8545)
489
490 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
491
492 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
493 (SIZE_MAX): Move defn after all includes, as they might #define it.
494
495 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
496
497 * w32.c (init_environment): Warn about defaulting HOME to C:\.
498
499 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
500
501 * keyboard.c (Qdelayed_warnings_hook): Define.
502 (command_loop_1): Run `delayed-warnings-hook'
503 if Vdelayed_warnings_list is non-nil.
504 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
505 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
506
507 2011-04-28 Eli Zaretskii <eliz@gnu.org>
508
509 * doprnt.c (doprnt): Don't return value smaller than the buffer
510 size if the message was truncated. (Bug#8545).
511
512 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
513
514 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
515 (Fx_window_property): #if-0 the whole functions, not just the bodies.
516
517 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
518
519 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
520
521 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
522
523 * makefile.w32-in: Update dependencies.
524
525 2011-04-27 Eli Zaretskii <eliz@gnu.org>
526
527 Improve `doprnt' and its usage. (Bug#8545)
528 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
529 `format_end'. Remove support for %l as a conversion specifier.
530 Don't use xrealloc. Improve diagnostics when the %l size modifier
531 is used. Update the commentary.
532
533 * eval.c (verror): Simplify calculation of size_t.
534
535 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
536 messages.
537
538 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
539
540 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
541 change.
542
543 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
544
545 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
546 This makes this file independent of the recent pseudovector change.
547
548 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
549
550 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
551
552 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
553 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
554 Remove unused local.
555 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
556
557 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
558 GCC 4.6.0 optimizes based on type-based alias analysis.
559 For example, if b is of type struct buffer * and v of type struct
560 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
561 != &v->size, and therefore "v->size = 1; b->size = 2; return
562 v->size;" must therefore return 1. This assumption is incorrect
563 for Emacs, since it type-puns struct Lisp_Vector * with many other
564 types. To fix this problem, this patch adds a new type struct
565 vectorlike_header that documents the constraints on layout of vectors
566 and pseudovectors, and helps optimizing compilers not get fooled
567 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
568 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
569 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
570 the size member.
571 (XSETPVECTYPE): Rewrite in terms of new macro.
572 (XSETPVECTYPESIZE): New macro, specifying both type and size.
573 This is a bit clearer, and further avoids the possibility of
574 undesirable aliasing.
575 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
576 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
577 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
578 since Lisp_Subr is a special case (no "next" field).
579 (ASIZE): Now uses header.size rather than size.
580 All previous uses of XVECTOR (foo)->size replaced to use this macro,
581 to avoid the hassle of writing XVECTOR (foo)->header.size.
582 (struct vectorlike_header): New type.
583 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
584 object, to help avoid aliasing.
585 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
586 (SUBRP): Likewise, since Lisp_Subr is a special case.
587 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
588 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
589 (struct Lisp_Hash_Table): Combine first two members into a single
590 struct vectorlike_header member. All uses of "size" and "next" members
591 changed to be "header.size" and "header.next".
592 * buffer.h (struct buffer): Likewise.
593 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
594 * frame.h (struct frame): Likewise.
595 * process.h (struct Lisp_Process): Likewise.
596 * termhooks.h (struct terminal): Likewise.
597 * window.c (struct save_window_data, struct saved_window): Likewise.
598 * window.h (struct window): Likewise.
599 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
600 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
601 * buffer.c (init_buffer_once): Likewise.
602 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
603 special case.
604 * process.c (Fformat_network_address): Use local var for size,
605 for brevity.
606
607 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
608
609 Make the Lisp reader and string-to-float more consistent (Bug#8525)
610 * data.c (atof): Remove decl; no longer used or needed.
611 (digit_to_number): Move to lread.c.
612 (Fstring_to_number): Use new string_to_number function, to be
613 consistent with how the Lisp reader treats infinities and NaNs.
614 Do not assume that floating-point numbers represent EMACS_INT
615 without losing information; this is not true on most 64-bit hosts.
616 Avoid double-rounding errors, by insisting on integers when
617 parsing non-base-10 numbers, as the documentation specifies.
618 * lisp.h (string_to_number): New decl, replacing ...
619 (isfloat_string): Remove.
620 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
621 (read1): Do not accept +. and -. as integers; this
622 appears to have been a coding error. Similarly, do not accept
623 strings like +-1e0 as floating point numbers. Do not report
624 overflow for integer overflows unless the base is not 10 which
625 means we have no simple and reliable way to continue.
626 Break out the floating-point parsing into a new
627 function string_to_number, so that Fstring_to_number parses
628 floating point numbers consistently with the Lisp reader.
629 (digit_to_number): Move here from data.c. Make it static inline.
630 (E_CHAR, EXP_INT): Remove, replacing with ...
631 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
632 (string_to_number): New function, replacing isfloat_string.
633 This function checks for valid syntax and produces the resulting
634 Lisp float number too. Rework it so that string-to-number
635 no longer mishandles examples like "1.0e+". Use strtoumax,
636 so that overflow for non-base-10 numbers is reported only when
637 there's no portable and simple way to convert to floating point.
638
639 * textprop.c (set_text_properties_1): Rewrite for clarity,
640 and to avoid GCC warning about integer overflow.
641
642 * intervals.h (struct interval): Use EMACS_INT for members
643 where EMACS_UINT might cause problems. See
644 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
645 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
646 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
647 All uses changed.
648 (offset_intervals): Tell GCC not to worry about length overflow
649 when negating a negative length.
650
651 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
652 (overrun_check_free): Likewise.
653
654 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
655 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
656 word size.
657
658 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
659 (gnutls_make_error): Rename local to avoid shadowing.
660 (gnutls_emacs_global_deinit): ifdef out; not used.
661 (Fgnutls_boot): Use const for pointer to readonly storage.
662 Comment out unused local. Fix pointer signedness problems.
663
664 * lread.c (openp): Don't stuff size_t into an 'int'.
665 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
666 about possible signed overflow.
667
668 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
669 (GDK_KEY_g): Don't define if already defined.
670 (xg_prepare_tooltip): Avoid pointer signedness problem.
671 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
672
673 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
674 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
675
676 * xfns.c (Fx_window_property): Simplify a bit,
677 to make a bit faster and to avoid GCC 4.6.0 warning.
678 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
679
680 * fns.c (internal_equal): Don't assume size_t fits in int.
681
682 * alloc.c (compact_small_strings): Tighten assertion a little.
683
684 Replace pEd with more-general pI, and fix some printf arg casts.
685 * lisp.h (pI): New macro, generalizing old pEd macro to other
686 conversion specifiers. For example, use "...%"pI"d..." rather
687 than "...%"pEd"...".
688 (pEd): Remove. All uses replaced with similar uses of pI.
689 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
690 * alloc.c (check_pure_size): Don't overflow by converting size to int.
691 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
692 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
693 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
694 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
695 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
696 64-bit hosts.
697 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
698 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
699 * print.c (safe_debug_print, print_object): Likewise.
700 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
701 to int.
702 Use pI instead of if-then-else-abort. Use %p to avoid casts,
703 avoiding the 0 flag, which is not portable.
704 * process.c (Fmake_network_process): Use pI to avoid cast.
705 * region-cache.c (pp_cache): Likewise.
706 * xdisp.c (decode_mode_spec): Likewise.
707 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
708 behavior on 64-bit hosts with printf arg.
709 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
710 (x_stop_queuing_selection_requests): Likewise.
711 (x_get_window_property): Don't truncate byte count to an 'int'
712 when tracing.
713
714 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
715 here, since it parses constructs like leading '-' and spaces,
716 which are not wanted; and it overflows with large numbers.
717 Instead, simply match F[0-9]+, which is what is wanted anyway.
718
719 * alloc.c: Remove unportable assumptions about struct layout.
720 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
721 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
722 (allocate_vectorlike, make_pure_vector): Use the new macros,
723 plus offsetof, to remove unportable assumptions about struct layout.
724 These assumptions hold on all porting targets that I know of, but
725 they are not guaranteed, they're easy to remove, and removing them
726 makes further changes easier.
727
728 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
729 This doesn't fix a bug but makes the code clearer.
730 (string_overrun_cookie): Now const. Use initializers that
731 don't formally overflow signed char, to avoid warnings.
732 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
733 can cause Emacs to crash when string overrun checking is enabled.
734 (allocate_buffer): Don't assume sizeof (struct buffer) is a
735 multiple of sizeof (EMACS_INT); it need not be, if
736 alignof(EMACS_INT) < sizeof (EMACS_INT).
737 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
738
739 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
740
741 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
742
743 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
744
745 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
746 supposed to be handshaking. (Bug#8556)
747 Reported by Paul Eggert <eggert@cs.ucla.edu>.
748
749 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
750
751 * lisp.h (Qdebug): List symbol.
752 * eval.c (Qdebug): Restore global linkage.
753 * keyboard.c (debug-on-event): New variable.
754 (handle_user_signal): Break into debugger when debug-on-event
755 matches the current signal symbol.
756
757 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
758
759 * alloc.c (check_sblock, check_string_bytes)
760 (check_string_free_list): Convert to standard C.
761
762 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
763
764 * w32.c (emacs_gnutls_push): Fix typo.
765
766 2011-04-25 Eli Zaretskii <eliz@gnu.org>
767
768 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
769 "cast to pointer from integer of different size".
770
771 Improve doprnt and its use in verror. (Bug#8545)
772 * doprnt.c (doprnt): Document the set of format control sequences
773 supported by the function. Use SAFE_ALLOCA instead of always
774 using `alloca'.
775
776 * eval.c (verror): Don't limit the buffer size at size_max-1, that
777 is one byte too soon. Don't use xrealloc; instead xfree and
778 xmalloc anew.
779
780 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
781
782 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
783 callbacks stage.
784
785 * gnutls.c: Renamed global_initialized to
786 gnutls_global_initialized. Added internals for the
787 :verify-hostname-error, :verify-error, and :verify-flags
788 parameters of `gnutls-boot' and documented those parameters in the
789 docstring. Start callback support.
790 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
791 unless a fatal error occured. Call gnutls_alert_send_appropriate
792 on error. Return error code.
793 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
794 (emacs_gnutls_read): Likewise.
795 (Fgnutls_boot): Return handshake error code.
796 (emacs_gnutls_handle_error): New function.
797 (wsaerror_to_errno): Likewise.
798
799 * w32.h (emacs_gnutls_pull): Add prototype.
800 (emacs_gnutls_push): Likewise.
801
802 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
803 (emacs_gnutls_push): Likewise.
804
805 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
806
807 * process.c (wait_reading_process_output): Check if GnuTLS
808 buffered some data internally if no FDs are set for TLS
809 connections.
810
811 * makefile.w32-in (OBJ2): Add gnutls.$(O).
812 (LIBS): Link to USER_LIBS.
813 ($(BLD)/gnutls.$(0)): New target.
814
815 2011-04-24 Eli Zaretskii <eliz@gnu.org>
816
817 * xdisp.c (handle_single_display_spec): Rename the
818 display_replaced_before_p argument into display_replaced_p, to
819 make it consistent with the commentary. Fix typos in the
820 commentary.
821
822 * textprop.c (syms_of_textprop): Remove dead code.
823 (copy_text_properties): Delete obsolete commentary about an
824 interface that was deleted long ago. Fix typos in the description
825 of arguments.
826
827 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
828 to changes in oldXMenu/XMenu.h from 2011-04-16.
829 <menu_help_message, prev_menu_help_message>: Constify.
830 (IT_menu_make_room): menu->help_text is now `const char **';
831 adjust.
832
833 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
834 to changes in oldXMenu/XMenu.h from 2011-04-16.
835 (struct XMenu): Declare `help_text' `const char **'.
836
837 * xfaces.c <Qunspecified>: Make extern again.
838
839 * syntax.c: Include sys/types.h before including regex.h, as
840 required by Posix.
841
842 * doc.c (get_doc_string): Improve the format passed to `error'.
843
844 * doprnt.c (doprnt): Improve commentary.
845
846 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
847
848 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
849 them with etags.
850
851 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
852 changes in globals.h immediately force recompilation.
853 (TAGS): Depend on $(CURDIR)/m/intel386.h and
854 $(CURDIR)/s/ms-w32.h.
855 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
856
857 * character.c (Fchar_direction): Function deleted.
858 (syms_of_character): Don't defsubr it.
859 <char-direction-table>: Deleted.
860
861 2011-04-23 Eli Zaretskii <eliz@gnu.org>
862
863 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
864 * doprnt.c: Include limits.h.
865 (SIZE_MAX): New macro.
866 (doprnt): Return a size_t value. 2nd arg is now size_t.
867 Many local variables are now size_t instead of int or unsigned.
868 Improve overflow protection. Support `l' modifier for integer
869 conversions. Support %l conversion. Don't assume an EMACS_INT
870 argument for integer conversions and for %c.
871
872 * lisp.h (doprnt): Restore prototype.
873
874 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
875 $(SRC)/character.h.
876
877 * Makefile.in (base_obj): Add back doprnt.o.
878
879 * deps.mk (doprnt.o): Add back prerequisites.
880 (callint.o): Depend on character.h.
881
882 * eval.c (internal_lisp_condition_case): Include the handler
883 representation in the error message.
884 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
885 when breaking from the loop.
886
887 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
888
889 * callint.c (Fcall_interactively): When displaying error message
890 about invalid control letter, pass the character's codepoint, not
891 a pointer to its multibyte form. Improve display of the character
892 in octal and display also its hex code.
893
894 * character.c (char_string): Use %x to display the (unsigned)
895 codepoint of an invalid character, to avoid displaying a bogus
896 negative value.
897
898 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
899 `error', not SYMBOL_NAME itself.
900
901 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
902 character arguments to `error'.
903
904 * charset.c (check_iso_charset_parameter): Fix incorrect argument
905 to `error' in error message about FINAL_CHAR argument. Make sure
906 FINAL_CHAR is a character, and use %c when it is passed as
907 argument to `error'.
908
909 2011-04-23 Eli Zaretskii <eliz@gnu.org>
910
911 * s/ms-w32.h (localtime): Redirect to sys_localtime.
912
913 * w32.c: Include <time.h>.
914 (sys_localtime): New function.
915
916 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
917
918 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
919
920 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
921
922 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
923
924 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
925 zombies (Bug#8467).
926
927 2011-04-19 Eli Zaretskii <eliz@gnu.org>
928
929 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
930 gl_state.e_property when gl_state.object is Qt.
931
932 * insdel.c (make_gap_larger): Remove limitation of buffer size
933 to <= INT_MAX.
934
935 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
936
937 * xdisp.c (lookup_glyphless_char_display)
938 (produce_glyphless_glyph): Handle cons cell entry in
939 glyphless-char-display.
940 (Vglyphless_char_display): Document it.
941
942 * term.c (produce_glyphless_glyph): Handle cons cell entry in
943 glyphless-char-display.
944
945 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
946
947 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
948
949 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
950
951 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
952 definition for no-X builds.
953
954 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
955
956 Static checks with GCC 4.6.0 and non-default toolkits.
957
958 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
959
960 * process.c (keyboard_bit_set): Define only if SIGIO.
961 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
962 (send_process): Repair possible setjmp clobbering.
963
964 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
965
966 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
967
968 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
969
970 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
971 Define only if needed.
972
973 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
974 by pacifying GCC about it. Maybe it's time to retire it?
975 * xfaces.c (USG, __TIMEVAL__): Likewise.
976
977 * dispextern.h (struct redisplay_interface): Rename param
978 to avoid shadowing.
979 * termhooks.h (struct terminal): Likewise.
980 * xterm.c (xembed_send_message): Likewise.
981
982 * insdel.c (make_gap_smaller): Define only if
983 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
984
985 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
986 it.
987
988 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
989 so that we aren't warned about unused symbols.
990
991 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
992
993 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
994
995 * xfns.c (x_real_positions): Mark locals as initialized.
996
997 * xmenu.c (xmenu_show): Don't use uninitialized vars.
998
999 * xterm.c: Fix problems found by static analysis with other toolkits.
1000 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1001 (x_dispatch_event): Declare static if USE_GTK, and
1002 define if USE_GTK || USE_X_TOOLKIT.
1003 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1004 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1005 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1006 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1007
1008 * xmenu.c (menu_help_callback): Pointer type fixes.
1009 Use const pointers when pointing at readonly data. Avoid pointer
1010 signedness clashes.
1011 (FALSE): Remove unused macro.
1012 (update_frame_menubar): Remove unused decl.
1013
1014 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1015
1016 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1017 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1018 (single_menu_item): Rename local to avoid shadowing.
1019
1020 * keyboard.c (make_lispy_event): Remove unused local var.
1021
1022 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1023 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1024
1025 * bitmaps: Change bitmaps from unsigned char back to the X11
1026 compatible char. Avoid the old compiler warnings about
1027 out-of-range initializers by using, for example, '\xab' rather
1028 than 0xab.
1029
1030 * xgselect.c (xgselect_initialize): Check vs interface
1031 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1032
1033 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1034
1035 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1036 to read-only memory.
1037
1038 * fns.c (vector): Remove; this old hack is no longer needed.
1039
1040 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1041 Remove unused var.
1042 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1043
1044 * xrdb.c (x_load_resources): Omit unused local.
1045
1046 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1047 (x_window): Rename locals to avoid shadowing.
1048 (USG): Use the kludged USG macro, to pacify gcc.
1049
1050 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1051 (x_term_init): Remove local to avoid shadowing.
1052
1053 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1054
1055 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1056 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1057
1058 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1059
1060 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1061
1062 Fix regex.c, syntax.c and friends for buffers > 2GB.
1063 * syntax.h (struct gl_state_s): Declare character position members
1064 EMACS_INT.
1065
1066 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1067
1068 * textprop.c (verify_interval_modification, interval_of):
1069 Declare arguments EMACS_INT.
1070
1071 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1072 EMACS_INT.
1073
1074 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1075
1076 * indent.c (Fvertical_motion): Local variable it_start is now
1077 EMACS_INT.
1078
1079 * regex.c (re_match, re_match_2, re_match_2_internal)
1080 (bcmp_translate, regcomp, regexec, print_double_string)
1081 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1082 (re_compile_pattern, re_exec): Declare arguments and local
1083 variables `size_t' and `ssize_t' and return values `regoff_t', as
1084 appropriate.
1085 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1086 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1087 <compile_stack_type>: `size' and `avail' are now `size_t'.
1088
1089 * regex.h <regoff_t>: Use ssize_t, not int.
1090 (re_search, re_search_2, re_match, re_match_2): Arguments that
1091 specify buffer/string position and length are now ssize_t and
1092 size_t. Return type is regoff_t.
1093
1094 2011-04-16 Ben Key <bkey76@gmail.com>
1095
1096 * nsfont.m: Fixed bugs in ns_get_family and
1097 ns_descriptor_to_entity that were caused by using free to
1098 deallocate memory blocks that were allocated by xmalloc (via
1099 xstrdup). This caused Emacs to crash when compiled with
1100 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1101 --enable-checking=xmallocoverrun). xfree is now used to
1102 deallocate these memory blocks.
1103
1104 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1105
1106 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1107
1108 emacs_write: Accept and return EMACS_INT for sizes.
1109 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1110 et seq.
1111 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1112 Accept and return EMACS_INT.
1113 (emacs_gnutls_write): Return the number of bytes written on
1114 partial writes.
1115 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1116 (emacs_read, emacs_write): Remove check for negative size, as the
1117 Emacs source code has been audited now.
1118 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1119 (emacs_read, emacs_write): Use it.
1120 * process.c (send_process): Adjust to the new signatures of
1121 emacs_write and emacs_gnutls_write. Do not attempt to store
1122 a byte offset into an 'int'; it might overflow.
1123 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1124
1125 * sound.c: Don't assume sizes fit in 'int'.
1126 (struct sound_device.period_size, alsa_period_size):
1127 Return EMACS_INT, not int.
1128 (struct sound_device.write, vox_write, alsa_write):
1129 Accept EMACS_INT, not int.
1130 (wav_play, au_play): Use EMACS_INT to store sizes and to
1131 record read return values.
1132
1133 2011-04-15 Ben Key <bkey76@gmail.com>
1134
1135 * keyboard.c (Qundefined): Don't declare static since it is used
1136 in nsfns.m.
1137 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1138 static since they are used in nsfont.m.
1139
1140 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1141
1142 * process.c (Qprocessp): Don't declare static.
1143 * lisp.h (Qprocessp): Declare again.
1144
1145 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1146
1147 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1148
1149 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1150
1151 Improve C-level modularity by making more things 'static'.
1152
1153 Don't publish debugger-only interfaces to other modules.
1154 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1155 (verify_bytepos, count_markers): Move decls to the only modules
1156 that need them.
1157 * region-cache.h (pp_cache): Likewise.
1158 * window.h (check_all_windows): Likewise.
1159 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1160
1161 * sysdep.c (croak): Now static, if
1162 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1163 * syssignal.h (croak): Declare only if not static.
1164
1165 * alloc.c (refill_memory_reserve): Now static if
1166 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1167 * lisp.h (refill_memory_reserve): Declare only if not static.
1168
1169 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1170 Define only if USE_LUCID.
1171
1172 * xrdb.c (x_customization_string, x_rm_string): Now static.
1173
1174 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1175 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1176
1177 * xdisp.c (draw_row_with_mouse_face): Now static.
1178 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1179
1180 * window.h (check_all_windows): Mark externally visible.
1181
1182 * window.c (window_deletion_count): Now static.
1183
1184 * undo.c: Make symbols static if they're not exported.
1185 (last_undo_buffer, last_boundary_position, pending_boundary):
1186 Now static.
1187
1188 * textprop.c (interval_insert_behind_hooks): Now static.
1189 (interval_insert_in_front_hooks): Likewise.
1190
1191 * term.c: Make symbols static if they're not exported.
1192 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1193 (max_frame_lines, tty_set_terminal_modes):
1194 (tty_reset_terminal_modes, tty_turn_off_highlight):
1195 (get_tty_terminal): Now static.
1196 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1197 * termhooks.h (term_mouse_moveto): Do not declare if
1198 HAVE_WINDOW_SYSTEM.
1199 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1200 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1201
1202 * sysdep.c: Make symbols static if they're not exported.
1203 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1204 Now static.
1205 (sigprocmask_set, full_mask): Remove; unused.
1206 (wait_debugging): Mark as visible.
1207 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1208 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1209
1210 * syntax.c (syntax_temp): Define only if !__GNUC__.
1211
1212 * sound.c (current_sound_device, current_sound): Now static.
1213
1214 * search.c (searchbufs, searchbuf_head): Now static.
1215
1216 * scroll.c (scroll_cost): Remove; unused.
1217 * dispextern.h (scroll_cost): Remove decl.
1218
1219 * region-cache.h (pp_cache): Mark as externally visible.
1220
1221 * process.c: Make symbols static if they're not exported.
1222 (process_tick, update_tick, create_process, chan_process):
1223 (Vprocess_alist, proc_buffered_char, datagram_access):
1224 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1225 (deactivate_process): Mark defn as static, as well as decl.
1226 * lisp.h (create_process): Remove decl.
1227 * process.h (chan_process, Vprocess_alist): Remove decls.
1228
1229 * print.c: Make symbols static if they're not exported.
1230 (print_depth, new_backquote_output, being_printed, print_buffer):
1231 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1232 (print_interval, print_number_index, initial_stderr_stream):
1233 Now static.
1234 * lisp.h (Fprinc): Remove decl.
1235 (debug_output_compilation_hack): Mark as externally visible.
1236
1237 * sysdep.c (croak): Move decl from here to syssignal.h.
1238 * syssignal.h (croak): Put it here, so the API can be checked when
1239 'croak' is called from dissociate_if_controlling_tty.
1240
1241 * minibuf.c: Make symbols static if they're not exported.
1242 (minibuf_save_list, choose_minibuf_frame): Now static.
1243 * lisp.h (choose_minibuf_frame): Remove decl.
1244
1245 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1246
1247 * lread.c: Make symbols static if they're not exported.
1248 (read_objects, initial_obarray, oblookup_last_bucket_number):
1249 Now static.
1250 (make_symbol): Remove; unused.
1251 * lisp.h (initial_obarray, make_symbol): Remove decls.
1252
1253 * keyboard.c: Make symbols static if they're not exported.
1254 (single_kboard, recent_keys_index, total_keys, recent_keys):
1255 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1256 (this_single_command_key_start, echoing, last_auto_save):
1257 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1258 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1259 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1260 (Vlispy_mouse_stem, double_click_count):
1261 Now static.
1262 (force_auto_save_soon): Define only if SIGDANGER.
1263 (ignore_mouse_drag_p): Now static if
1264 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1265 (print_help): Remove; unused.
1266 (stop_character, last_timer_event): Mark as externally visible.
1267 * keyboard.h (ignore_mouse_drag_p): Declare only if
1268 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1269 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1270 * lisp.h (echoing): Remove decl.
1271 (force_auto_save_soon): Declare only if SIGDANGER.
1272 * xdisp.c (redisplay_window): Simplify code, to make it more
1273 obvious that ignore_mouse_drag_p is not accessed if !defined
1274 USE_GTK && !defined HAVE_NS.
1275
1276 * intervals.c: Make symbols static if they're not exported.
1277 (merge_properties_sticky, merge_interval_right, delete_interval):
1278 Now static.
1279 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1280
1281 * insdel.c: Make symbols static if they're not exported.
1282 However, leave prepare_to_modify_buffer alone. It's never
1283 called from outside this function, but that appears to be a bug.
1284 (combine_after_change_list, combine_after_change_buffer):
1285 (adjust_after_replace, signal_before_change): Now static.
1286 (adjust_after_replace_noundo): Remove; unused.
1287 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1288 (signal_before_change): Remove decls.
1289
1290 * indent.c (val_compute_motion, val_vmotion): Now static.
1291
1292 * image.c: Make symbols static if they're not exported.
1293 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1294 if USE_GTK.
1295 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1296 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1297
1298 * fringe.c (standard_bitmaps): Now static.
1299 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1300
1301 * frame.c: Make symbols static if they're not exported.
1302 (x_report_frame_params, make_terminal_frame): Now static.
1303 (get_frame_param): Now static, unless HAVE_NS.
1304 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1305 (x_get_resource_string): Remove; not used.
1306 * frame.h (make_terminal_frame, x_report_frame_params):
1307 (x_get_resource_string); Remove decls.
1308 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1309 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1310
1311 * font.c, fontset.c: Make symbols static if they're not exported.
1312 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1313 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1314 * font.c (font_close_object): Now static.
1315 * font.h (font_close_object): Remove.
1316 * fontset.c (FONTSET_OBJLIST): Remove.
1317 (free_realized_fontset) #if-0 the body, which does nothing.
1318 (face_suitable_for_char_p): #if-0, as it's never called.
1319 * fontset.h (face_suitable_for_char_p): Remove decl.
1320 * xfaces.c (face_at_string_position):
1321 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1322 since 0 is always ASCII.
1323
1324 * fns.c (weak_hash_tables): Now static.
1325
1326 * fileio.c: Make symbols static if they're not exported.
1327 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1328 (Vwrite_region_annotation_buffers): Now static.
1329
1330 * eval.c: Make symbols static if they're not exported.
1331 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1332 * lisp.h (backtrace_list): Remove decl.
1333
1334 * emacs.c: Make symbols static if they're not exported.
1335 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1336 (fatal_error_code, fatal_error_signal_hook, standard_args):
1337 Now static.
1338 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1339 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1340 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1341 * lisp.h (fatal_error_signal_hook): Remove decl.
1342 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1343
1344 * editfns.c: Move a (normally-unused) function to its only use.
1345 * editfns.c, lisp.h (get_operating_system_release): Remove.
1346 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1347 worth the hassle of breaking this out.
1348
1349 * xterm.c: Make symbols static if they're not exported.
1350 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1351 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1352 (x_destroy_window, x_delete_display):
1353 Now static.
1354 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1355 (x_mouse_leave): Remove; unused.
1356 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1357 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1358 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1359 Remove decls.
1360 (x_mouse_leave): Declare only if WINDOWSNT.
1361 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1362 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1363 USE_X_TOOLKIT.
1364
1365 * ftxfont.c: Make symbols static if they're not exported.
1366 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1367 HAVE_FREETYPE.
1368 * font.h (ftxfont_driver): Likewise.
1369
1370 * xfns.c: Make symbols static if they're not exported.
1371 (x_last_font_name, x_display_info_for_name):
1372 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1373 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1374 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1375 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1376 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1377 (last_show_tip_args): Now static.
1378 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1379 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1380 (x_screen_planes): Remove; unused.
1381 * dispextern.h (x_screen_planes): Remove decl.
1382
1383 * dispnew.c: Make symbols static if they're not exported.
1384 * dispextern.h (redraw_garbaged_frames, scrolling):
1385 (increment_row_positions): Remove.
1386 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1387 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1388 Now static.
1389 (redraw_garbaged_frames): Remove; unused.
1390
1391 * xfaces.c: Make symbols static if they're not exported.
1392 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1393 Remove decls.
1394 * xterm.h (defined_color): Remove decls.
1395 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1396 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1397 (menu_face_changed_default, defined_color, free_realized_face):
1398 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1399 (ascii_face_of_lisp_face): Remove; unused.
1400
1401 * xdisp.c: Make symbols static if they're not exported.
1402 * dispextern.h (scratch_glyph_row, window_box_edges):
1403 (glyph_to_pixel_coords, set_cursor_from_row):
1404 (get_next_display_element, set_iterator_to_next):
1405 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1406 (show_mouse_face): Remove decls
1407 * frame.h (message_buf_print): Likewise.
1408 * lisp.h (pop_message, set_message, check_point_in_composition):
1409 Likewise.
1410 * xterm.h (set_vertical_scroll_bar): Likewise.
1411 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1412 (message_buf_print, scratch_glyph_row, displayed_buffer):
1413 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1414 (get_next_display_element, show_mouse_face, window_box_edges):
1415 (frame_to_window_pixel_xy, check_point_in_composition):
1416 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1417 (glyph_to_pixel_coords): Remove; unused.
1418
1419 * dired.c (file_name_completion): Now static.
1420
1421 * dbusbind.c (xd_in_read_queued_messages): Now static.
1422
1423 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1424 * data.c (circular_list_error): Remove.
1425
1426 * commands.h (last_point_position, last_point_position_buffer):
1427 (last_point_position_window): Remove decls.
1428 * keyboard.c: Make these variables static.
1429
1430 * coding.h (coding, code_convert_region, encode_coding_gap):
1431 Remove decls.
1432 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1433 (iso_code_class, detect_coding, code_convert_region): Now static.
1434 (encode_coding_gap): Remove; unused.
1435
1436 * chartab.c (chartab_chars, chartab_bits): Now static.
1437
1438 * charset.h (charset_iso_8859_1): Remove decl.
1439 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1440 Now static.
1441
1442 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1443 * ccl.c (Vccl_program_table): Now static.
1444 (check_ccl_update): Remove; unused.
1445
1446 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1447 * category.h: ... from here.
1448 * category.c (check_category_table, set_category_set): Now static.
1449
1450 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1451 * lisp.h: Remove these decls.
1452
1453 * buffer.c (buffer_count): Remove unused var.
1454
1455 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1456 so that it's not optimized away.
1457 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1458 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1459 exported only to the debugger.
1460
1461 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1462 * atimer.h (run_all_atimers): Remove; not exported.
1463
1464 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1465 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1466 was inaccessible from Lisp.
1467 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1468 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1469
1470 alloc.c: Import and export fewer symbols, and remove unused items.
1471 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1472 is defined.
1473 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1474 it's not optimized away by whole-program optimization.
1475 (message_enable_multibyte, free_misc): Remove.
1476 (catchlist, handlerlist, mark_backtrace):
1477 Declare only if BYTE_MARK_STACK.
1478 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1479 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1480 (message_enable_multibyte): Remove decl.
1481 (free_misc, interval_free_list, float_block, float_block_index):
1482 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1483 (cons_free_list, last_marked_index):
1484 Now static.
1485 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1486 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1487 (mark_backtrace): Define only if BYTE_MARK_STACK.
1488 * xdisp.c (message_enable_multibyte): Now static.
1489
1490 Declare Lisp_Object Q* variables to be 'static' if not exported.
1491 This makes it easier for human readers (and static analyzers)
1492 to see whether these variables are used from other modules.
1493 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1494 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1495 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1496 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1497 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1498 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1499 * xmenu.c, xselect.c:
1500 Declare Q* vars static if they are not used in other modules.
1501 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1502 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1503 Remove decls of unexported vars.
1504 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1505
1506 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1507
1508 Make Emacs functions such as Fatom 'static' by default.
1509 This makes it easier for human readers (and static analyzers)
1510 to see whether these functions can be called from other modules.
1511 DEFUN now defines a static function. To make the function external
1512 so that it can be used in other C modules, use the new macro DEFUE.
1513 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1514 (Finit_image_library):
1515 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1516 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1517 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1518 Remove decls, since these functions are now static.
1519 (Funintern, Fget_internal_run_time): New decls, since these functions
1520 were already external.
1521
1522 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1523 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1524 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1525 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1526 * keyboard.c, keymap.c, lread.c:
1527 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1528 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1529 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1530 Mark functions with DEFUE instead of DEFUN,
1531 if they are used in other modules.
1532 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1533 decls for now-static functions.
1534 * buffer.h (Fdelete_overlay): Remove decl.
1535 * callproc.c (Fgetenv_internal): Mark as internal.
1536 * composite.c (Fremove_list_of_text_properties): Remove decl.
1537 (Fcomposition_get_gstring): New forward static decl.
1538 * composite.h (Fcomposite_get_gstring): Remove decl.
1539 * dired.c (Ffile_attributes): New forward static decl.
1540 * doc.c (Fdocumntation_property): New forward static decl.
1541 * eval.c (Ffetch_bytecode): New forward static decl.
1542 (Funintern): Remove extern decl; now in .h file where it belongs.
1543 * fileio.c (Fmake_symbolic_link): New forward static decl.
1544 * image.c (Finit_image_library): New forward static decl.
1545 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1546 * intervals.h (Fprevious_property_change):
1547 (Fremove_list_of_text_properties): Remove decls.
1548 * keyboard.c (Fthis_command_keys): Remove decl.
1549 (Fcommand_execute): New forward static decl.
1550 * keymap.c (Flookup_key): New forward static decl.
1551 (Fcopy_keymap): Now static.
1552 * keymap.h (Flookup_key): Remove decl.
1553 * process.c (Fget_process): New forward static decl.
1554 (Fprocess_datagram_address): Mark as internal.
1555 * syntax.c (Fsyntax_table_p): New forward static decl.
1556 (skip_chars): Remove duplicate decl.
1557 * textprop.c (Fprevious_property_change): New forward static decl.
1558 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1559 Now internal.
1560 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1561 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1562
1563 * editfns.c (Fformat): Remove unreachable code.
1564
1565 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1566
1567 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1568 change. (Bug#8496)
1569
1570 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1571
1572 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1573 when at ZV. (Bug#8487)
1574
1575 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1576
1577 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1578 (Bug#8437)
1579 * keyboard.c (parse_tool_bar_item): Likewise.
1580 * sound.c (sound_cleanup, alsa_close): Likewise.
1581 * termcap.c (tgetent): Likewise.
1582 * xfns.c (x_default_font_parameter): Likewise.
1583 * xsettings.c (read_and_apply_settings): Likewise.
1584
1585 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1586 (overrun_check_free): Protoize.
1587
1588 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1589
1590 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1591 since callers should never pass a negative size.
1592 Change the signature to match that of plain 'read' and 'write'; see
1593 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1594 * lisp.h: Update prototypes of emacs_write and emacs_read.
1595
1596 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1597
1598 * xdisp.c (redisplay_window): Don't try to determine the character
1599 position of the scroll margin if the window start point w->startp
1600 is outside the buffer's accessible region. (Bug#8468)
1601
1602 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1603
1604 Fix write-region and its subroutines for buffers > 2GB.
1605 * fileio.c (a_write, e_write): Modify declaration of arguments and
1606 local variables to support buffers larger than 2GB.
1607 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1608
1609 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1610 argument, local variables, and return value.
1611
1612 * lisp.h: Update prototypes of emacs_write and emacs_read.
1613
1614 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1615
1616 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1617
1618 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1619
1620 Fix more problems found by GCC 4.6.0's static checks.
1621
1622 * xdisp.c (vmessage): Use a better test for character truncation.
1623
1624 * charset.c (load_charset_map): <, not <=, for optimization,
1625 and to avoid potential problems with integer overflow.
1626 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1627 * casetab.c (set_identity, shuffle): Likewise.
1628 * editfns.c (Fformat): Likewise.
1629 * syntax.c (skip_chars): Likewise.
1630
1631 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1632 This also lets GCC 4.6.0 generate slightly better loop code.
1633
1634 * callint.c (Fcall_interactively): <, not <=, for optimization.
1635 (Fcall_interactively): Count the number of arguments produced,
1636 not the number of arguments given. This is simpler and lets GCC
1637 4.6.0 generate slightly better code.
1638
1639 * ftfont.c: Distingish more carefully between FcChar8 and char.
1640 The previous code passed unsigned char * to a functions like
1641 strlen and xstrcasecmp that expect char *, which does not
1642 conform to the C standard.
1643 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1644 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1645 char * when the C standard requires it.
1646
1647 * keyboard.c (read_char): Remove unused var.
1648
1649 * eval.c: Port to Windows vsnprintf (Bug#8435).
1650 Include <limits.h>.
1651 (SIZE_MAX): Define if the headers do not.
1652 (verror): Do not give up if vsnprintf returns a negative count.
1653 Instead, grow the buffer. This ports to Windows vsnprintf, which
1654 does not conform to C99. Problem reported by Eli Zaretskii.
1655 Also, simplify the allocation scheme, by avoiding the need for
1656 calling realloc, and removing the ALLOCATED variable.
1657
1658 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1659
1660 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1661 But keep the doprint source code for now, as we might revamp it
1662 and use it again (Bug#8435).
1663 * lisp.h (doprnt): Remove.
1664 * Makefile.in (base_obj): Remove doprnt.o.
1665 * deps.mk (doprnt.o): Remove.
1666
1667 error: Print 32- and 64-bit integers portably (Bug#8435).
1668 Without this change, on typical 64-bit hosts error ("...%d...", N)
1669 was used to print both 32- and 64-bit integers N, which relied on
1670 undefined behavior.
1671 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1672 New macro.
1673 * lisp.h (error, verror): Mark as printf-like functions.
1674 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1675 Report overflow in size calculations when allocating printf buffer.
1676 Do not truncate output string at its first null byte.
1677 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1678 Truncate the output at a character boundary, since vsnprintf does not
1679 do that.
1680 * charset.c (check_iso_charset_parameter): Convert internal
1681 character to string before calling 'error', since %c now has the
1682 printf meaning.
1683 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1684 overflow when computing char to be passed to 'error'. Do not
1685 pass Lisp_Object to 'error'; pass the integer instead.
1686 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1687 formatted with plain %d.
1688
1689 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1690
1691 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1692
1693 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1694
1695 * xterm.c (x_catch_errors): Remove duplicate declaration.
1696
1697 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1698
1699 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1700
1701 2011-04-10 Jim Meyering <meyering@redhat.com>
1702
1703 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1704 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1705 return ssize_t not "int", and use size_t as the buffer length.
1706 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1707 * gnutls.h: Update declarations.
1708 * process.c (read_process_output): Use ssize_t, to match.
1709 (send_process): Likewise.
1710
1711 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1712
1713 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1714
1715 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1716
1717 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1718 Use unsigned char, to match FcChar8 type definition.
1719
1720 * xterm.c (handle_one_xevent):
1721 * xmenu.c (create_and_show_popup_menu):
1722 * xselect.c (x_decline_selection_request)
1723 (x_reply_selection_request): Avoid type-punned deref of X events.
1724
1725 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1726
1727 Fix some uses of `int' instead of EMACS_INT.
1728 * search.c (string_match_1, fast_string_match)
1729 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1730 (scan_buffer, find_next_newline_no_quit)
1731 (find_before_next_newline, search_command, Freplace_match)
1732 (Fmatch_data): Make some `int' variables be EMACS_INT.
1733
1734 * xdisp.c (display_count_lines): 3rd argument and return value now
1735 EMACS_INT. All callers changed.
1736 (pint2hrstr): Last argument is now EMACS_INT.
1737
1738 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1739 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1740 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1741 (decode_coding_utf_16, decode_coding_emacs_mule)
1742 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1743 (decode_coding_ccl, decode_coding_charset)
1744 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1745 (decode_coding_iso_2022, decode_coding_emacs_mule)
1746 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1747 <char_offset, last_offset>: Declare EMACS_INT.
1748 (encode_coding_utf_8, encode_coding_utf_16)
1749 (encode_coding_emacs_mule, encode_invocation_designation)
1750 (encode_designation_at_bol, encode_coding_iso_2022)
1751 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1752 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1753 Declare EMACS_INT.
1754 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1755 (encode_invocation_designation): Last argument P_NCHARS is now
1756 EMACS_INT.
1757 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1758 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1759
1760 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1761 All users changed.
1762
1763 * ccl.c (Fccl_execute_on_string): Declare some variables
1764 EMACS_INT.
1765
1766 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1767
1768 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1769
1770 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1771
1772 * process.c (Fformat_network_address): Doc fix.
1773
1774 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1775
1776 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1777
1778 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1779
1780 * keyboard.c (read_char): Call Lisp function help-form-show,
1781 instead of using internal_with_output_to_temp_buffer.
1782 (Qhelp_form_show): New var.
1783 (syms_of_keyboard): Use DEFSYM macro.
1784
1785 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1786
1787 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1788
1789 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1790
1791 * process.c (Flist_processes): Remove to Lisp.
1792 (list_processes_1): Delete.
1793
1794 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1795
1796 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1797
1798 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1799
1800 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1801
1802 Fix more problems found by GCC 4.6.0's static checks.
1803
1804 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1805
1806 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1807
1808 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1809
1810 * xdisp.c (vmessage): Mark as a printf-like function.
1811
1812 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1813
1814 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1815
1816 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1817 printf-like functions.
1818 (tiff_load): Add casts to remove these marks before passing them
1819 to system-supplied API.
1820
1821 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1822
1823 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1824 This avoids several warnings with gcc -Wstrict-overflow.
1825 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1826 directly, rather than having caller test rule sign. This avoids
1827 some unnecessary tests.
1828 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1829 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1830 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1831
1832 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1833 (xfont_open): Avoid unnecessary tests.
1834
1835 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1836
1837 * composite.h, composite.c (composition_gstring_put_cache):
1838 Use EMACS_INT, not int, for length.
1839
1840 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1841 breaking out part of COMPOSITION_DECODE_RULE.
1842 (COMPOSITION_DECODE_RULE): Use it.
1843 * composite.c (get_composition_id): Remove unused local vars,
1844 by using the new macro.
1845
1846 * textprop.c (set_text_properties_1): Change while to do-while,
1847 since the condition is always true at first.
1848
1849 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1850 (interval_deletion_adjustment): Return unsigned value.
1851 All uses changed.
1852
1853 * process.c (list_processes_1, create_pty, read_process_output):
1854 (exec_sentinel): Remove vars that were set but not used.
1855 (create_pty): Remove unnecessary "volatile"s.
1856 (Fnetwork_interface_info): Avoid possibility of int overflow.
1857 (read_process_output): Do adaptive read buffering even if carryover.
1858 (read_process_output): Simplify nbytes computation if buffered.
1859
1860 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1861
1862 * syntax.c (scan_words): Remove var that was set but not used.
1863 (update_syntax_table): Use unsigned instead of int.
1864
1865 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1866 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1867 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1868
1869 * print.c (print_error_message): Avoid int overflow.
1870
1871 * font.c (font_list_entities): Redo for clarity,
1872 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1873
1874 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1875 (font_score): Avoid potential overflow in diff calculation.
1876
1877 * fns.c (substring_both): Remove var that is set but not used.
1878 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1879
1880 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1881
1882 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1883 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1884 can always succeed if overflow has undefined behavior.
1885
1886 * search.c (boyer_moore, wordify): Remove vars set but not used.
1887 (wordify): Omit three unnecessary tests.
1888
1889 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1890 All callers changed. This avoids the need for an unused var.
1891
1892 * casefiddle.c (casify_region): Remove var that is set but not used.
1893
1894 * dired.c (file_name_completion): Remove var that is set but not used.
1895
1896 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1897
1898 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1899 (Finsert_file_contents): Remove unnecessary code checking fd.
1900
1901 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1902 Check for integer overflow on size calculations.
1903
1904 * buffer.c (Fprevious_overlay_change): Remove var that is set
1905 but not used.
1906
1907 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1908 Remove vars that are set but not used.
1909 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1910 (timer_check_2): Mark vars as initialized.
1911
1912 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1913
1914 * image.c (lookup_image): Remove var that is set but not used.
1915 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1916
1917 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1918 that are set but not used.
1919
1920 * xfns.c (make_invisible_cursor): Don't return garbage
1921 if XCreateBitmapFromData fails (Bug#8410).
1922
1923 * xselect.c (x_get_local_selection, x_handle_property_notify):
1924 Remove vars that are set but not used.
1925
1926 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1927 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1928
1929 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1930 Remove var that is set but not used.
1931 (scroll_bar_windows_size): Now size_t, not int.
1932 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1933 Check for overflow.
1934
1935 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1936 (map_tty_color) [!defined MSDOS]: Likewise.
1937
1938 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1939
1940 * coding.c: Remove vars that are set but not used.
1941 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1942 All callers changed.
1943 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1944 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1945 (decode_coding_charset): Remove vars that are set but not used.
1946
1947 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1948 that is set but not used.
1949
1950 * print.c (print_object): Remove var that is set but not used.
1951
1952 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1953 The gnulib version avoids calling malloc in the usual case,
1954 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1955 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1956 * filelock.c (current_lock_owner): Likewise.
1957 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1958 * sysdep.c: Include allocator.h, careadlinkat.h.
1959 (emacs_no_realloc_allocator): New static constant.
1960 (emacs_readlink): New function.
1961 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1962 ../lib/careadlinkat.h.
1963
1964 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1965
1966 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1967 first non-nil return value).
1968
1969 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1970
1971 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1972 if not defined (Bug#8403).
1973
1974 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1975
1976 * xdisp.c (display_count_lines): Remove parameter `start',
1977 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1978 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1979 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1980 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1981 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1982 and thereabouts. All callers changed.
1983 (get_per_char_metric): Remove parameter `f', unused since
1984 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1985
1986 2011-04-02 Jim Meyering <meyering@redhat.com>
1987
1988 do not dereference NULL upon failed strdup
1989 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1990 (ns_get_family): Likewise.
1991
1992 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1993
1994 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1995
1996 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1997
1998 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1999 later (Bug#8403).
2000
2001 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2002
2003 Add lexical binding.
2004
2005 * window.c (Ftemp_output_buffer_show): New fun.
2006 (Fsave_window_excursion):
2007 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2008
2009 * lread.c (lisp_file_lexically_bound_p): New function.
2010 (Fload): Bind Qlexical_binding.
2011 (readevalloop): Remove `evalfun' arg.
2012 Bind Qinternal_interpreter_environment.
2013 (Feval_buffer): Bind Qlexical_binding.
2014 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2015 Mark as dynamic.
2016 (syms_of_lread): Declare `lexical-binding'.
2017
2018 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2019
2020 * keyboard.c (eval_dyn): New fun.
2021 (menu_item_eval_property): Use it.
2022
2023 * image.c (parse_image_spec): Use Ffunctionp.
2024
2025 * fns.c (concat, mapcar1): Accept byte-code-functions.
2026
2027 * eval.c (Fsetq): Handle lexical vars.
2028 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2029 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2030 (FletX, Flet): Obey lexical binding.
2031 (Fcommandp): Handle closures.
2032 (Feval): New `lexical' arg.
2033 (eval_sub): New function extracted from Feval. Use it almost
2034 everywhere where Feval was used. Look up vars in lexical env.
2035 Handle closures.
2036 (Ffunctionp): Move from subr.el.
2037 (Ffuncall): Handle closures.
2038 (apply_lambda): Remove `eval_flags'.
2039 (funcall_lambda): Handle closures and new byte-code-functions.
2040 (Fspecial_variable_p): New function.
2041 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2042 but without exporting it to Lisp.
2043
2044 * doc.c (Fdocumentation, store_function_docstring):
2045 * data.c (Finteractive_form): Handle closures.
2046
2047 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2048 interactive spec.
2049
2050 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2051 New byte-codes.
2052 (exec_byte_code): New function extracted from Fbyte_code to handle new
2053 calling convention for byte-code-functions. Add new byte-codes.
2054
2055 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2056
2057 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2058
2059 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2060
2061 * xdisp.c (redisplay_internal): Fix prototype.
2062
2063 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2064
2065 * xdisp.c (SCROLL_LIMIT): New macro.
2066 (try_scrolling): Use it when setting scroll_limit.
2067 Limit scrolling to 100 screen lines.
2068 (redisplay_window): Even when falling back on "recentering",
2069 position point in the window according to scroll-conservatively,
2070 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2071
2072 (try_scrolling): When point is above the window, allow searching
2073 as far as scroll_max, or one screenful, to compute vertical
2074 distance from PT to the scroll margin position. This prevents
2075 try_scrolling from unnecessarily failing when
2076 scroll-conservatively is set to a value slightly larger than the
2077 window height. Clean up the case of PT below the margin at bottom
2078 of window: scroll_max can no longer be INT_MAX. When aggressive
2079 scrolling is in use, don't let point enter the opposite scroll
2080 margin as result of the scroll.
2081 (syms_of_xdisp) <scroll-conservatively>: Document the
2082 threshold of 100 lines for never-recentering scrolling.
2083
2084 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2085
2086 * dispextern.h (move_it_by_lines):
2087 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2088 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2089 (message_log_check_duplicate): Remove parameters `prev_bol' and
2090 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2091 (redisplay_internal): Remove parameter `preserve_echo_area',
2092 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2093
2094 * indent.c (Fvertical_motion):
2095 * window.c (window_scroll_pixel_based, Frecenter):
2096 Don't pass `need_y_p' to `move_it_by_lines'.
2097
2098 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2099
2100 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2101 steal a few bits to be more compact.
2102 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2103 Remove unneeded casts.
2104
2105 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2106
2107 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2108
2109 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2110 binding" message (bug#7967).
2111
2112 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2113
2114 Fix more problems found by GCC 4.6.0's static checks.
2115
2116 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2117 Remove unused local var.
2118
2119 * editfns.c (Fmessage_box): Remove unused local var.
2120
2121 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2122 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2123 Omit unused local vars.
2124 * window.c (shrink_windows): Omit unused local var.
2125 * menu.c (digest_single_submenu): Omit unused local var.
2126 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2127 Omit unused local var.
2128
2129 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2130 Don't assume string length fits in int.
2131 (keyremap_step, read_key_sequence): Use size_t for sizes.
2132 (read_key_sequence): Don't check last_real_key_start redundantly.
2133
2134 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2135 instead of alloca (Bug#8344).
2136
2137 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2138 (Fbacktrace_frame): Don't assume nframes fits in int.
2139
2140 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2141
2142 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2143 concerns.
2144
2145 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2146
2147 * cm.c (calccost): Turn while-do into do-while, for clarity.
2148
2149 * keyboard.c (syms_of_keyboard): Use the same style as later
2150 in this function when indexing through an array. This also
2151 works around GCC bug 48267.
2152
2153 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2154
2155 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2156
2157 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2158 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2159
2160 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2161 This avoids undefined behavior on integer overflow, and is a bit
2162 more convenient anyway since it is compared to a size_t variable.
2163
2164 Variadic C functions now count arguments with size_t, not int.
2165 This avoids an unnecessary limitation on 64-bit machines, which
2166 caused (substring ...) to crash on large vectors (Bug#8344).
2167 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2168 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2169 All variadic functions and their callers changed accordingly.
2170 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2171 * data.c (arith_driver, float_arith_driver): Likewise.
2172 * editfns.c (general_insert_function): Likewise.
2173 * eval.c (struct backtrace.nargs, interactive_p)
2174 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2175 (funcall_lambda, mark_backtrace): Likewise.
2176 * fns.c (concat): Likewise.
2177 * frame.c (x_set_frame_parameters): Likewise.
2178 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2179 0 if not found, not -1. All callers changed.
2180
2181 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2182 (stack_copy_size): Now size_t, not int.
2183 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2184
2185 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2186
2187 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2188 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2189 All callers changed.
2190
2191 * lisp.h (multibyte_char_to_unibyte):
2192 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2193 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2194 * character.h (CHAR_TO_BYTE8):
2195 * cmds.c (internal_self_insert):
2196 * editfns.c (general_insert_function):
2197 * keymap.c (push_key_description):
2198 * search.c (Freplace_match):
2199 * xdisp.c (message_dolog, set_message_1): All callers changed.
2200
2201 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2202
2203 * keyboard.c (safe_run_hook_funcall): New function.
2204 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2205 don't set the hook to nil, but remove the offending function instead.
2206 (Qcommand_hook_internal): Remove, unused.
2207 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2208 Vcommand_hook_internal.
2209
2210 * eval.c (enum run_hooks_condition): Remove.
2211 (funcall_nil, funcall_not): New functions.
2212 (run_hook_with_args): Call each function through a `funcall' argument.
2213 Remove `cond' argument, now redundant.
2214 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2215 (Frun_hook_with_args_until_failure): Adjust accordingly.
2216 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2217
2218 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2219
2220 * dispextern.h (string_buffer_position): Remove declaration.
2221
2222 * print.c (strout): Remove parameter `multibyte', unused since
2223 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2224
2225 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2226 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2227 All callers changed.
2228
2229 * w32.c (_wsa_errlist): Use braces for struct initializers.
2230
2231 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2232 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2233 All callers changed.
2234 (string_buffer_position): Likewise. Also, make static (it's never
2235 used outside xdisp.c).
2236 (cursor_row_p): Remove parameter `w', unused since
2237 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2238 (decode_mode_spec): Remove parameter `precision', introduced during
2239 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2240 All callers changed.
2241
2242 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2243
2244 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2245
2246 2011-03-27 Anders Lindgren <andlind@gmail.com>
2247
2248 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2249 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2250 (ns_update_auto_hide_menu_bar): New functions.
2251 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2252 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2253 ns_constrain_all_frames.
2254 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2255 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2256
2257 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2258
2259 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2260
2261 2011-03-27 Glenn Morris <rgm@gnu.org>
2262
2263 * syssignal.h: Replace RETSIGTYPE with void.
2264 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2265 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2266 Replace SIGTYPE with void everywhere.
2267 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2268 * s/template.h (SIGTYPE): Remove commented out definition.
2269
2270 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2271
2272 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2273 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2274
2275 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2276
2277 * w32.c (read_unc_volume): Use parameter `henum', instead of
2278 global variable `wget_enum_handle'.
2279
2280 * keymap.c (describe_vector): Remove parameters `indices' and
2281 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2282 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2283
2284 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2285
2286 * keyboard.c (timer_check): Remove parameter `do_it_now',
2287 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2288 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2289 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2290
2291 * keyboard.c (read_char):
2292 * w32menu.c (w32_menu_display_help):
2293 * xmenu.c (show_help_event, menu_help_callback):
2294 Adjust calls to `show_help_echo'.
2295
2296 * gtkutil.c (xg_maybe_add_timer):
2297 * keyboard.c (readable_events):
2298 * process.c (wait_reading_process_output):
2299 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2300
2301 * insdel.c (adjust_markers_gap_motion):
2302 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2303 (gap_left, gap_right): Don't call it.
2304
2305 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2306
2307 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2308 incurred during fontification.
2309
2310 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2311
2312 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2313 (DEFVAR_PER_BUFFER): Don't pass it.
2314
2315 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2316 (scrolling_window): Don't pass it.
2317
2318 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2319
2320 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2321
2322 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2323 and `suffix'.
2324 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2325 of variables specific to SELinux and computation of `encoded_absname'.
2326
2327 * image.c (XPutPixel): Remove unused variable `height'.
2328
2329 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2330
2331 * unexw32.c (get_section_info): Remove unused variable `section'.
2332
2333 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2334 (system_process_attributes): Remove unused variable `sess'.
2335 (sys_read): Remove unused variable `err'.
2336
2337 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2338 (w32_wnd_proc): Remove unused variable `isdead'.
2339 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2340 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2341 (x_create_tip_frame): Remove unused variable `tem'.
2342
2343 * w32inevt.c (w32_console_read_socket):
2344 Remove unused variable `no_events'.
2345
2346 * w32term.c (x_draw_composite_glyph_string_foreground):
2347 Remove unused variable `width'.
2348
2349 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2350
2351 * w32term.c (x_set_glyph_string_clipping):
2352 Don't pass uninitialized region to CombineRgn.
2353
2354 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2355
2356 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2357 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2358 (Fx_close_connection): Remove unused variable `i'.
2359
2360 * w32font.c (w32font_draw): Return number of glyphs.
2361 (w32font_open_internal): Remove unused variable `i'.
2362 (w32font_driver): Add missing initializer.
2363
2364 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2365 (fill_in_menu): Remove unused variable `items_added'.
2366
2367 * w32term.c (last_mouse_press_frame): Remove static global variable.
2368 (w32_clip_to_row): Remove unused variable `f'.
2369 (x_delete_terminal): Remove unused variable `i'.
2370
2371 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2372 (NOTHING): Remove unused static global variable.
2373 (uniscribe_check_otf): Remove unused variable `table'.
2374 (uniscribe_font_driver): Add missing initializers.
2375
2376 2011-03-23 Julien Danjou <julien@danjou.info>
2377
2378 * term.c (Fsuspend_tty, Fresume_tty):
2379 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2380 * window.c (temp_output_buffer_show):
2381 * insdel.c (signal_before_change):
2382 * frame.c (Fhandle_switch_frame):
2383 * fileio.c (Fdo_auto_save):
2384 * emacs.c (Fkill_emacs):
2385 * editfns.c (save_excursion_restore):
2386 * cmds.c (internal_self_insert):
2387 * callint.c (Fcall_interactively):
2388 * buffer.c (Fkill_all_local_variables):
2389 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2390 Use Frun_hooks.
2391 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2392 unconditionnaly since it does the check itself.
2393
2394 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2395
2396 Fix more problems found by GCC 4.5.2's static checks.
2397
2398 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2399 the first time through the loop, since we know p0 < p1 then.
2400 This also avoids a gcc -Wstrict-overflow warning.
2401
2402 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2403 leading to a memory leak, possible in functions like
2404 load_charset_map_from_file that can allocate an unbounded number
2405 of objects (Bug#8318).
2406
2407 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2408 that could (at least in theory) be that large.
2409
2410 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2411 This is less likely to overflow, and avoids undefined behavior if
2412 overflow does occur. All callers changed. Use strtoul to scan
2413 for the unsigned long integer.
2414 (pint2hrstr): Simplify and tune code slightly.
2415 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2416
2417 * scroll.c (do_scrolling): Work around GCC bug 48228.
2418 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2419
2420 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2421 This also avoids a warning with gcc -Wstrict-overflow.
2422 (validate_x_resource_name): Simplify count usage.
2423 This also avoids a warning with gcc -Wstrict-overflow.
2424
2425 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2426 fail (Bug#8306).
2427
2428 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2429
2430 * process.c (Fmake_network_process): Use socklen_t, not int,
2431 where POSIX says socklen_t is required in portable programs.
2432 This fixes a porting bug on hosts like 64-bit HP-UX, where
2433 socklen_t is wider than int (Bug#8277).
2434 (Fmake_network_process, server_accept_connection):
2435 (wait_reading_process_output, read_process_output):
2436 Likewise.
2437
2438 * process.c: Rename or move locals to avoid shadowing.
2439 (list_processes_1, Fmake_network_process):
2440 (read_process_output_error_handler, exec_sentinel_error_handler):
2441 Rename or move locals.
2442 (Fmake_network_process): Define label "retry_connect" only if needed.
2443 (Fnetwork_interface_info): Fix pointer signedness.
2444 (process_send_signal): Add cast to avoid pointer signedness problem.
2445 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2446 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2447
2448 Make tparam.h and terminfo.c consistent.
2449 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2450 Include tparam.h instead, since it declares them.
2451 * cm.h (PC): Remove extern decl; tparam.h now does this.
2452 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2453 * terminfo.c: Include tparam.h, to check interfaces.
2454 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2455 (tparam): Adjust signature to match interface in tparam.h;
2456 this removes some undefined behavior. Check that outstring and len
2457 are zero, which they always are with Emacs.
2458 * tparam.h (PC, BC, UP): New extern decls.
2459
2460 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2461 (xftfont_open): Rename locals to avoid shadowing.
2462
2463 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2464 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2465 (OTF_TAG_SYM): Omit macro if not needed.
2466 (ftfont_list): Remove unused local.
2467 (get_adstyle_property, ftfont_pattern_entity):
2468 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2469 Rename locals to avoid shadowing.
2470
2471 * xfont.c (xfont_list_family): Mark var as initialized.
2472
2473 * xml.c (make_dom): Now static.
2474
2475 * composite.c (composition_compute_stop_pos): Rename local to
2476 avoid shadowing.
2477 (composition_reseat_it): Remove unused locals.
2478 (find_automatic_composition, composition_adjust_point): Likewise.
2479 (composition_update_it): Mark var as initialized.
2480 (find_automatic_composition): Mark vars as initialized,
2481 with a FIXME (Bug#8290).
2482
2483 character.h: Rename locals to avoid shadowing.
2484 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2485 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2486 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2487 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2488 to avoid shadowing.
2489
2490 * textprop.c (property_change_between_p): Remove; unused.
2491
2492 * intervals.c (interval_start_pos): Now static.
2493
2494 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2495
2496 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2497 Rename locals to avoid shadowing.
2498
2499 * sound.c (wav_play, au_play, Fplay_sound_internal):
2500 Fix pointer signedness.
2501 (alsa_choose_format): Remove unused local var.
2502 (wav_play): Initialize a variable to 0, to prevent undefined
2503 behavior (Bug#8278).
2504
2505 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2506
2507 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2508
2509 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2510 clobbering (Bug#8298).
2511 * sysdep.c (sys_subshell): Likewise.
2512 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2513
2514 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2515 This should get cleaned up, so that child_setup has the
2516 same signature on all platforms.
2517
2518 * callproc.c (call_process_cleanup): Now static.
2519 (relocate_fd): Rename locals to avoid shadowing.
2520
2521 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2522
2523 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2524 not to be necessary, and produces flickering.
2525
2526 2011-03-20 Glenn Morris <rgm@gnu.org>
2527
2528 * config.in: Remove file.
2529
2530 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2531
2532 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2533 are now in src/globals.h.
2534 (syms_of_minibuf): Remove spurious & from previous change.
2535
2536 2011-03-20 Leo <sdl.web@gmail.com>
2537
2538 * minibuf.c (completing-read-function): New variable.
2539 (completing-read-default): Rename from completing-read.
2540 (completing-read): Call completing-read-function.
2541
2542 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2543
2544 * xfaces.c (Fx_load_color_file):
2545 Read color file from absolute filename (bug#8250).
2546
2547 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2548
2549 * makefile.w32-in: Update dependencies.
2550
2551 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2552
2553 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2554
2555 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 Fix more problems found by GCC 4.5.2's static checks.
2558
2559 * process.c (make_serial_process_unwind, send_process_trap):
2560 (sigchld_handler): Now static.
2561
2562 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2563 That way, the code declares only the vars that it needs.
2564 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2565 * s/cygwin.h (PTY_ITERATION): Likewise.
2566 * s/darwin.h (PTY_ITERATION): Likewise.
2567 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2568
2569 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2570 * process.c (allocate_pty): Don't declare stb unless it's needed.
2571
2572 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2573 (CONSTANTLIM): Remove; unused.
2574 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2575 Define only if needed.
2576
2577 * unexelf.c (unexec): Name an expression,
2578 to avoid gcc -Wbad-function-cast warning.
2579 Use a different way to cause a compilation error if anyone uses
2580 n rather than nn, a way that does not involve shadowing.
2581 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2582
2583 * deps.mk (unexalpha.o): Remove; unused.
2584
2585 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2586 * unexec.h: New file.
2587 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2588 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2589 Depend on unexec.h.
2590 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2591 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2592 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2593 Change as necessary to match prototype in unexec.h.
2594
2595 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2596 shadowing.
2597 (back_comment, skip_chars): Mark vars as initialized.
2598
2599 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2600 Rename locals to avoid shadowing.
2601
2602 * lread.c (read1): Rewrite so as not to use empty "else".
2603 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2604
2605 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2606
2607 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2608 warning when compiling print.c.
2609
2610 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2611 instead of using an uninitialized var.
2612 (font_sort_entities): Mark var as initialized.
2613
2614 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2615
2616 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2617 pointers to constants.
2618 (font_parse_fcname): Remove unused vars.
2619 (font_delete_unmatched): Now static.
2620 (font_get_spec): Remove; unused.
2621 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2622 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2623 Rename or move locals to avoid shadowing.
2624
2625 * fns.c (require_nesting_list, require_unwind): Now static.
2626 (Ffillarray): Rename locals to avoid shadowing.
2627
2628 * floatfns.c (domain_error2): Define only if needed.
2629 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2630
2631 * alloc.c (mark_backtrace): Move decl from here ...
2632 * lisp.h: ... to here, so that it can be checked.
2633
2634 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2635 (Fdefvar): Rewrite so as not to use empty "else".
2636 (lisp_indirect_variable): Name an expression,
2637 to avoid gcc -Wbad-function-cast warning.
2638 (Fdefvar): Rename locals to avoid shadowing.
2639
2640 * callint.c (quotify_arg, quotify_args): Now static.
2641 (Fcall_interactively): Rename locals to avoid shadowing.
2642 Use const pointer when appropriate.
2643
2644 * lisp.h (get_system_name, get_operating_system_release):
2645 Move decls here, to check interfaces.
2646 * process.c (get_operating_system_release): Move decl to lisp.h.
2647 * xrdb.c (get_system_name): Likewise.
2648 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2649 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2650 some of which prompt warnings from gcc -Wbad-function-cast.
2651 (Fformat_time_string, Fencode_time, Finsert_char):
2652 (Ftranslate_region_internal, Fformat):
2653 Rename or remove local vars to avoid shadowing.
2654 (Ftranslate_region_internal): Mark var as initialized.
2655
2656 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2657 avoid shadowing.
2658
2659 * lisp.h (eassert): Check that the argument compiles, even if
2660 ENABLE_CHECKING is not defined.
2661
2662 * data.c (Findirect_variable): Name an expression, to avoid
2663 gcc -Wbad-function-cast warning.
2664 (default_value, arithcompare, arith_driver, arith_error): Now static.
2665 (store_symval_forwarding): Rename local to avoid shadowing.
2666 (Fmake_variable_buffer_local, Fmake_local_variable):
2667 Mark variables as initialized.
2668 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2669
2670 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2671 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2672 Rename locals to avoid shadowing.
2673 (mark_stack): Move local variables into the #ifdef region where
2674 they're used.
2675 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2676 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2677 needed otherwise.
2678 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2679 (GC_STRING_CHARS): Remove; not used.
2680 (Fmemory_limit): Cast sbrk's returned value to char *.
2681
2682 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2683 avoids undefined behavior in theory.
2684
2685 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2686
2687 Use functions, not macros, for up- and down-casing (Bug#8254).
2688 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2689 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2690 to use the following functions instead of these macros.
2691 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2692 EMACS_INT, since callers assume the returned value fits in int.
2693 (upcase1): Likewise, for UPCASE_TABLE.
2694 (uppercasep, lowercasep, upcase): New static inline functions.
2695 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2696 the race-condition problem in the old DOWNCASE.
2697
2698 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2699 Rename locals to avoid shadowing.
2700 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2701 (regex_compile, re_search_2, re_match_2_internal):
2702 Remove unused local vars.
2703 (FREE_VAR): Rewrite so as not to use empty "else",
2704 which gcc can warn about.
2705 (regex_compile, re_match_2_internal): Mark locals as initialized.
2706 (RETALLOC_IF): Define only if needed.
2707 (WORDCHAR_P): Likewise. This one is never needed, but is used
2708 only in a comment talking about a compiler bug, so put inside
2709 the #if 0 of that comment.
2710 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2711 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2712 Remove; unused.
2713
2714 * search.c (boyer_moore): Rename locals to avoid shadowing.
2715 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2716 (PREV_CHAR_BOUNDARY): Likewise.
2717
2718 * search.c (simple_search): Remove unused var.
2719
2720 * dired.c (compile_pattern): Move decl from here ...
2721 * lisp.h: ... to here, so that it can be checked.
2722 (struct re_registers): New forward decl.
2723
2724 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2725
2726 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2727 All uses changed.
2728 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2729 Rename locals to avoid shadowing.
2730 (Fvertical_motion): Mark locals as initialized.
2731
2732 * casefiddle.c (casify_object, casify_region): Now static.
2733 (casify_region): Mark local as initialized.
2734
2735 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2736
2737 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2738 New macros, so that the caller can use some names other than
2739 gcpro1, gcpro2, etc.
2740 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2741 of the new macros.
2742 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2743 argument, for consistency with GCPRO2_VAR, etc: it is now the
2744 prefix of the variable, not the variable itself. All uses
2745 changed.
2746 * dired.c (directory_files_internal, file_name_completion):
2747 Rename locals to avoid shadowing.
2748
2749 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2750 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2751 dired.c's scmp function, had undefined behavior.
2752 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2753 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2754 * buffer.h: ... to here, because these macros use current_buffer,
2755 and the new implementation with inline functions needs to have
2756 current_buffer in scope now, rather than later when the macros
2757 are used.
2758 (downcase, upcase1): New static inline functions.
2759 (DOWNCASE, UPCASE1): Reimplement using these functions.
2760 This avoids undefined behavior in expressions like
2761 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2762 from race conditions in accessing the global variables
2763 case_temp1 and case_temp2.
2764 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2765 * lisp.h (case_temp1, case_temp2): Remove their decls.
2766 * character.h (ASCII_CHAR_P): Move from here ...
2767 * lisp.h: ... to here, so that the inline functions mentioned
2768 above can use them.
2769
2770 * dired.c (directory_files_internal_unwind): Now static.
2771
2772 * fileio.c (file_name_as_directory, directory_file_name):
2773 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2774 Now static.
2775 (file_name_as_directory): Use const pointers when appropriate.
2776 (Fexpand_file_name): Likewise. In particular, newdir might
2777 point at constant storage, so make it a const pointer.
2778 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2779 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2780 signedness issues.
2781 (Fset_file_times, Finsert_file_contents, auto_save_error):
2782 Rename locals to avoid shadowing.
2783
2784 * minibuf.c (choose_minibuf_frame_1): Now static.
2785 (Ftry_completion, Fall_completions): Rename or remove locals
2786 to avoid shadowing.
2787
2788 * marker.c (bytepos_to_charpos): Remove; unused.
2789
2790 * lisp.h (verify_bytepos, count_markers): New decls,
2791 so that gcc does not warn that these functions aren't declared.
2792
2793 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2794 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2795 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2796 (copy_text): Remove unused local var.
2797
2798 * filelock.c (within_one_second): Now static.
2799 (lock_file_1): Rename local to avoid shadowing.
2800
2801 * buffer.c (fix_overlays_before): Mark locals as initialized.
2802 (fix_start_end_in_overlays): Likewise. This function should be
2803 simplified by using pointers-to-pointers, but that's a different
2804 matter.
2805 (switch_to_buffer_1): Now static.
2806 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2807 (report_overlay_modification): Rename locals to avoid shadowing.
2808
2809 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2810 Fix pointer signedness issue.
2811 (sys_subshell): Mark local as volatile if checking for lint,
2812 to suppress a gcc -Wclobbered warning that does not seem to be right.
2813 (MAXPATHLEN): Define only if needed.
2814
2815 * process.c (serial_open, serial_configure): Move decls from here ...
2816 * systty.h: ... to here, so that they can be checked.
2817
2818 * fns.c (get_random, seed_random): Move extern decls from here ...
2819 * lisp.h: ... to here, so that they can be checked.
2820
2821 * sysdep.c (reset_io): Now static.
2822 (wait_for_termination_signal): Remove; unused.
2823
2824 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2825 (copy_keymap_item, append_key, push_text_char_description):
2826 Now static.
2827 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2828 (DENSE_TABLE_SIZE): Remove; unused.
2829 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2830 (describe_map_tree):
2831 Rename locals to avoid shadowing.
2832
2833 * keyboard.c: Declare functions static if they are not used elsewhere.
2834 (echo_char, echo_dash, cmd_error, top_level_2):
2835 (poll_for_input, handle_async_input): Now static.
2836 (read_char, kbd_buffer_get_event, make_lispy_position):
2837 (make_lispy_event, make_lispy_movement, apply_modifiers):
2838 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2839 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2840 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2841 (read_key_sequence, read_char): Mark locals as initialized.
2842 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2843
2844 * keyboard.h (make_ctrl_char): New decl.
2845 (mark_kboards): Move decl here ...
2846 * alloc.c (mark_kboards): ... from here.
2847
2848 * lisp.h (force_auto_save_soon): New decl.
2849
2850 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2851 (DEFINE_DUMMY_FUNCTION): New macro.
2852 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2853 Use it.
2854 (main): Add casts to avoid warnings
2855 if GCC considers string literals to be constants.
2856
2857 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2858
2859 * dbusbind.c: Pointer signedness fixes.
2860 (xd_signature, xd_append_arg, xd_initialize):
2861 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2862 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2863 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2864 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2865
2866 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2867 if GCC considers string literals to be constants.
2868 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2869
2870 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2871
2872 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2873 (print_preprocess, print_object): New macro to fix last change.
2874
2875 * print.c (print_preprocess): Don't forget font objects.
2876
2877 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2878
2879 * emacs.c (USAGE3): Doc fixes.
2880
2881 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2882
2883 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2884 structure.
2885
2886 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2887
2888 * lisp.h (VWindow_system, Qfile_name_history):
2889 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2890 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2891 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2892
2893 * w32select.c: Don't #include "keyboard.h".
2894 (run_protected): Add extern declaration for waiting_for_input.
2895
2896 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2897 * w32console.c (detect_input_pending, read_input_pending)
2898 (encode_terminal_code):
2899 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2900 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2901 (w32_system_caret_y, Qfile_name_history):
2902 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2903 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2904 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2905 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2906 * w32proc.c (Qlocal, report_file_error):
2907 * w32term.c (Vwindow_system, updating_frame):
2908 * w32uniscribe.c (initialized, uniscribe_font_driver):
2909 Remove unneeded extern declarations.
2910
2911 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2912
2913 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2914
2915 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2916
2917 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2918 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2919 These macros can no longer be used for assignment.
2920
2921 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2922 Assign struct members directly, instead of using BUF_BEGV etc.
2923 (record_buffer_markers, fetch_buffer_markers): New functions for
2924 recording and fetching special buffer markers.
2925 (set_buffer_internal_1, set_buffer_temp): Use them.
2926
2927 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2928
2929 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2930
2931 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2932 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2933
2934 * xdisp.c (hscroll_window_tree):
2935 (reconsider_clip_changes): Use PT instead of BUF_PT.
2936
2937 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2938
2939 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2940 $(EMACS_ROOT)/lib/intprops.h.
2941
2942 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2943
2944 Fix more problems found by GCC 4.5.2's static checks.
2945
2946 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2947 to unsigned char * to avoid compiler diagnostic.
2948 (xg_free_frame_widgets): Make it clear that a local variable is
2949 needed only if USE_GTK_TOOLTIP.
2950 (gdk_window_get_screen): Make it clear that this macro is needed
2951 only if USE_GTK_TOOLTIP.
2952 (int_gtk_range_get_value): New function, which avoids a diagnostic
2953 from gcc -Wbad-function-cast.
2954 (xg_set_toolkit_scroll_bar_thumb): Use it.
2955 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2956 diagnostic from gcc -Wbad-function-cast.
2957 (get_utf8_string, xg_get_file_with_chooser):
2958 Rename locals to avoid shadowing.
2959 (create_dialog): Move locals to avoid shadowing.
2960
2961 * xgselect.c (xg_select): Remove unused var.
2962
2963 * image.c (four_corners_best): Mark locals as initialized.
2964 (gif_load): Initialize transparent_p to zero (Bug#8238).
2965 Mark another local as initialized.
2966 (my_png_error, my_error_exit): Mark with NO_RETURN.
2967
2968 * image.c (clear_image_cache): Now static.
2969 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2970 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2971 (x_edge_detection): Remove unnecessary cast that
2972 gcc -Wbad-function-cast diagnoses.
2973 (gif_load): Fix pointer signedness.
2974 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2975 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2976
2977 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2978
2979 Improve quality of tests for time stamp overflow.
2980 For example, without this patch (encode-time 0 0 0 1 1
2981 1152921504606846976) returns the obviously-bogus value (-948597
2982 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2983 reports time overflow. See
2984 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2985 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2986 * editfns.c: Include limits.h and intprops.h.
2987 (TIME_T_MIN, TIME_T_MAX): New macros.
2988 (time_overflow): Move earlier, to before first use.
2989 (hi_time, lo_time): New functions, for an accurate test for
2990 out-of-range times.
2991 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2992 (Fget_internal_run_time): Don't assume time_t fits in int.
2993 (make_time): Use list2 instead of Fcons twice.
2994 (Fdecode_time): More accurate test for out-of-range times.
2995 (check_tm_member): New function.
2996 (Fencode_time): Use it, to test for out-of-range times.
2997 (lisp_time_argument): Don't rely on undefined left-shift and
2998 right-shift behavior when checking for time stamp overflow.
2999
3000 * editfns.c (time_overflow): New function, refactoring common code.
3001 (Fformat_time_string, Fdecode_time, Fencode_time):
3002 (Fcurrent_time_string): Use it.
3003
3004 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3005 * dired.c (make_time): Move to ...
3006 * editfns.c (make_time): ... here.
3007 * systime.h: Note the move.
3008
3009 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3010
3011 * fringe.c (update_window_fringes): Remove unused variables.
3012
3013 * unexmacosx.c (copy_data_segment): Also copy __got section.
3014 (Bug#8223)
3015
3016 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3017
3018 * termcap.c [MSDOS]: Include "msdos.h".
3019 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3020 Constify `char *' arguments and their references according to
3021 prototypes in tparam.h.
3022
3023 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3024
3025 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3026 Adapt all references accordingly.
3027
3028 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3029
3030 2011-03-11 Tom Tromey <tromey@redhat.com>
3031
3032 * buffer.c (syms_of_buffer): Remove obsolete comment.
3033
3034 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3035
3036 * termhooks.h (encode_terminal_code): Declare prototype.
3037
3038 * msdos.c (encode_terminal_code): Don't declare prototype.
3039
3040 * term.c (encode_terminal_code): Now external again, used by
3041 w32console.c and msdos.c.
3042
3043 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3044 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3045
3046 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3047
3048 Fix some minor problems found by GCC 4.5.2's static checks.
3049
3050 * fringe.c (update_window_fringes): Mark locals as initialized
3051 (Bug#8227).
3052 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3053
3054 * alloc.c (mark_fringe_data): Move decl from here ...
3055 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3056 to check its interface.
3057 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3058
3059 * fontset.c (free_realized_fontset): Now static.
3060 (Fset_fontset_font): Rename local to avoid shadowing.
3061 (fontset_font): Mark local as initialized.
3062 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3063
3064 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3065
3066 * xselect.c (x_disown_buffer_selections): Remove; not used.
3067 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3068 (x_own_selection, Fx_disown_selection_internal): Rename locals
3069 to avoid shadowing.
3070 (x_handle_dnd_message): Remove local to avoid shadowing.
3071
3072 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3073 so that the caller can use some name other than gcpro1.
3074 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3075 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3076 (Fx_backspace_delete_keys_p):
3077 Use them to avoid shadowing, and rename vars to avoid shadowing.
3078 (x_decode_color, x_set_name, x_window): Now static.
3079 (Fx_create_frame): Add braces to silence GCC warning.
3080 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3081 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3082 Remove unused locals.
3083 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3084 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3085 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3086 macros.
3087
3088 * xterm.h (x_mouse_leave): New decl.
3089
3090 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3091 Remove unused functions.
3092 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3093 (x_calc_absolute_position): Now static.
3094 (XTread_socket): Don't define label "out" unless it's used.
3095 Don't declare local "event" unless it's used.
3096 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3097 unless they are used.
3098 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3099 (x_fatal_error_signal): Remove; not used.
3100 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3101 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3102 (x_error_catcher, x_connection_closed, x_error_handler):
3103 (x_error_quitter, xembed_send_message, x_iconify_frame):
3104 (my_log_handler): Rename locals to avoid shadowing.
3105 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3106 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3107
3108 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3109 Rename or move locals to avoid shadowing.
3110 (tty_defined_color, merge_face_heights): Now static.
3111 (free_realized_faces_for_fontset): Remove; not used.
3112 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3113 does not deduce is never used uninitialized.
3114 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3115 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3116
3117 * terminal.c (store_terminal_param): Now static.
3118
3119 * xmenu.c (menu_highlight_callback): Now static.
3120 (set_frame_menubar): Remove unused local.
3121 (xmenu_show): Rename parameter to avoid shadowing.
3122 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3123 since they might point to immutable storage.
3124 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3125 since it's unused otherwise.
3126
3127 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3128 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3129 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3130 avoids a gcc -Wuninitialized diagnostic.
3131 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3132 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3133 does not deduce are never used uninitialized.
3134
3135 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3136
3137 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3138 * window.c (window_loop, size_window):
3139 (run_window_configuration_change_hook, enlarge_window): Likewise.
3140
3141 * window.c (display_buffer): Now static.
3142 (size_window): Mark variables that gcc -Wuninitialized
3143 does not deduce are never used uninitialized.
3144 * window.h (check_all_windows): New decl, to forestall
3145 gcc -Wmissing-prototypes diagnostic.
3146 * dispextern.h (bidi_dump_cached_states): Likewise.
3147
3148 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3149 shadowing.
3150 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3151 Include <limits.h>.
3152 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3153 and to avoid gcc -Wuninitialized warning.
3154 (load_charset_map): Mark variables that gcc -Wuninitialized
3155 does not deduce are never used uninitialized.
3156 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3157
3158 * coding.c (coding_set_source, coding_set_destination):
3159 Use "else { /* comment */ }" rather than "else /* comment */;"
3160 for clarity, and to avoid gcc -Wempty-body warning.
3161 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3162 a block, when the outer 'i' will do.
3163 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3164 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3165 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3166 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3167 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3168 Rename locals to avoid shadowing.
3169 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3170 * coding.c (emacs_mule_char, encode_invocation_designation):
3171 Now static, since they're not used elsewhere.
3172 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3173 (decode_coding_object, encode_coding_object, detect_coding_system):
3174 (decode_coding_emacs_mule): Mark variables that gcc
3175 -Wuninitialized does not deduce are never used uninitialized.
3176 (detect_coding_iso_2022): Initialize a local variable that might
3177 be used uninitialized. Leave a FIXME because it's not clear that
3178 this initialization is needed. (Bug#8211)
3179 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3180 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3181 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3182 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3183 Remove unused macros.
3184
3185 * category.c (hash_get_category_set): Remove unused local var.
3186 (copy_category_table): Now static, since it's not used elsewhere.
3187 * character.c (string_count_byte8): Likewise.
3188
3189 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3190 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3191
3192 * chartab.c (copy_sub_char_table): Now static, since it's not used
3193 elsewhere.
3194 (sub_char_table_ref_and_range, char_table_ref_and_range):
3195 Rename locals to avoid shadowing.
3196 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3197
3198 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3199 (BIDI_BOB): Remove unused macro.
3200
3201 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3202 deduce are never used uninitialized.
3203 * term.c (encode_terminal_code): Likewise.
3204
3205 * term.c (encode_terminal_code): Now static. Remove unused local.
3206
3207 * tparam.h: New file.
3208 * term.c, tparam.h: Include it.
3209 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3210 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3211 Move these decls to tparam.h, and make them agree with what
3212 is actually in tparam.c. The previous trick of using incompatible
3213 decls in different modules does not conform to the C standard.
3214 All callers of tparam changed to use tparam's actual API.
3215 * tparam.c (tparam1, tparam, tgoto):
3216 Use const pointers where appropriate.
3217
3218 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3219 * cm.h (struct cm): Likewise.
3220 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3221 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3222 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3223 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3224 (turn_on_face, init_tty): Likewise.
3225 * termchar.h (struct tty_display_info): Likewise.
3226
3227 * term.c (term_mouse_position): Rename local to avoid shadowing.
3228
3229 * alloc.c (mark_ttys): Move decl from here ...
3230 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3231
3232 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3233
3234 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3235
3236 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3237
3238 * search.c (compile_pattern_1): Remove argument regp, unused since
3239 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3240 (compile_pattern): Don't pass it.
3241
3242 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3243
3244 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3245 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3246 for ! HAVE_GTK3.
3247 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3248
3249 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3250
3251 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3252 gdk_window_get_screen, gdk_window_get_geometry,
3253 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3254 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3255 (xg_get_pixbuf_from_pixmap): New function.
3256 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3257 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3258 Call xg_get_pixbuf_from_pixmap instead of
3259 gdk_pixbuf_get_from_drawable.
3260 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3261 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3262 (xg_check_special_colors): Use GtkStyleContext and its functions
3263 for HAVE_GTK3.
3264 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3265 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3266 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3267 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3268 Call gtk_widget_get_preferred_size.
3269 (xg_frame_resized): gdk_window_get_geometry only takes 5
3270 parameters.
3271 (xg_win_to_widget, xg_event_is_for_menubar):
3272 Call gdk_x11_window_lookup_for_display.
3273 (xg_set_widget_bg): New function.
3274 (delete_cb): New function.
3275 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3276 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3277 (xg_set_background_color): Call xg_set_widget_bg.
3278 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3279 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3280 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3281 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3282 if ! HAVE_GTK3.
3283 (update_frame_tool_bar): Call gtk_widget_hide.
3284 (xg_initialize): Use GDK_KEY_g.
3285
3286 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3287 if ! HAVE_GTK3
3288 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3289
3290 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3291 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3292 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3293
3294 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3295
3296 * w32xfns.c (select_palette): Check success of RealizePalette against
3297 GDI_ERROR, not zero.
3298
3299 See ChangeLog.11 for earlier changes.
3300
3301 ;; Local Variables:
3302 ;; coding: utf-8
3303 ;; End:
3304
3305 Copyright (C) 2011 Free Software Foundation, Inc.
3306
3307 This file is part of GNU Emacs.
3308
3309 GNU Emacs is free software: you can redistribute it and/or modify
3310 it under the terms of the GNU General Public License as published by
3311 the Free Software Foundation, either version 3 of the License, or
3312 (at your option) any later version.
3313
3314 GNU Emacs is distributed in the hope that it will be useful,
3315 but WITHOUT ANY WARRANTY; without even the implied warranty of
3316 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3317 GNU General Public License for more details.
3318
3319 You should have received a copy of the GNU General Public License
3320 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.