* image.c: Make symbols static if they're not exported.
[bpt/emacs.git] / src / ChangeLog
1 2011-04-13 Paul Eggert <eggert@cs.ucla.edu>
2
3 * image.c: Make symbols static if they're not exported.
4 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5 if USE_GTK.
6 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8
9 * fringe.c (standard_bitmaps): Now static.
10 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11
12 * frame.c: Make symbols static if they're not exported.
13 (x_report_frame_params, make_terminal_frame): Now static.
14 (get_frame_param): Now static, unless HAVE_NS.
15 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
16 (x_get_resource_string): Remove; not used.
17 * frame.h (make_terminal_frame, x_report_frame_params):
18 (x_get_resource_string); Remove decls.
19 (x_fullscreen_adjust): Declare only if WINDOWSNT.
20 * lisp.h (get_frame_param): Declare only if HAVE_NS.
21
22 * font.c, fontset.c: Make symbols static if they're not exported.
23 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
24 (FACE_SUITABLE_FOR_CHAR_P): Use it.
25 * font.c (font_close_object): Now static.
26 * font.h (font_close_object): Remove.
27 * fontset.c (FONTSET_OBJLIST): Remove.
28 (free_realized_fontset) #if-0 the body, which does nothing.
29 (face_suitable_for_char_p): #if-0, as it's never called.
30 * fontset.h (face_suitable_for_char_p): Remove decl.
31 * xfaces.c (face_at_string_position): Use
32 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
33 since 0 is always ASCII.
34
35 * fns.c (weak_hash_tables): Now static.
36
37 * fileio.c: Make symbols static if they're not exported.
38 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
39 (Vwrite_region_annotation_buffers): Now static.
40
41 * eval.c: Make symbols static if they're not exported.
42 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
43 * lisp.h (backtrace_list): Remove decl.
44
45 * emacs.c: Make symbols static if they're not exported.
46 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
47 (fatal_error_code, fatal_error_signal_hook, standard_args):
48 Now static.
49 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
50 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
51 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
52 * lisp.h (fatal_error_signal_hook): Remove decl.
53 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
54
55 * editfns.c: Move a (normally-unused) function to its only use.
56 * editfns.c, lisp.h (get_operating_system_release): Remove.
57 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
58 worth the hassle of breaking this out.
59
60 * xterm.c: Make symbols static if they're not exported.
61 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
62 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
63 (x_destroy_window, x_delete_display):
64 Now static.
65 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
66 (x_mouse_leave): Remove; unused.
67 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
68 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
69 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
70 Remove decls.
71 (x_mouse_leave): Declare only if WINDOWSNT.
72 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
73 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
74 USE_X_TOOLKIT.
75
76 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
77
78 * ftxfont.c: Make symbols static if they're not exported.
79 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
80 HAVE_FREETYPE.
81 * font.h (ftxfont_driver): Likewise.
82
83 * xfns.c: Make symbols static if they're not exported.
84 (x_last_font_name, x_display_info_for_name):
85 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
86 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
87 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
88 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
89 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
90 (last_show_tip_args): Now static.
91 (xic_defaut_fontset, xic_create_fontsetname): Define only if
92 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
93 (x_screen_planes): Remove; unused.
94 * dispextern.h (x_screen_planes): Remove decl.
95
96 * dispnew.c: Make symbols static if they're not exported.
97 * dispextern.h (redraw_garbaged_frames, scrolling):
98 (increment_row_positions): Remove.
99 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
100 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
101 Now static.
102 (redraw_garbaged_frames): Remove; unused.
103
104 * xfaces.c: Make symbols static if they're not exported.
105 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
106 Remove decls.
107 * xterm.h (defined_color): Remove decls.
108 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
109 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
110 (menu_face_changed_default, defined_color, free_realized_face):
111 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
112 (ascii_face_of_lisp_face): Remove; unused.
113
114 * xdisp.c: Make symbols static if they're not exported.
115 * dispextern.h (scratch_glyph_row, window_box_edges):
116 (glyph_to_pixel_coords, set_cursor_from_row):
117 (get_next_display_element, set_iterator_to_next):
118 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
119 (show_mouse_face): Remove decls
120 * frame.h (message_buf_print): Likewise.
121 * lisp.h (pop_message, set_message, check_point_in_composition):
122 Likewise.
123 * xterm.h (set_vertical_scroll_bar): Likewise.
124 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
125 (message_buf_print, scratch_glyph_row, displayed_buffer):
126 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
127 (get_next_display_element, show_mouse_face, window_box_edges):
128 (frame_to_window_pixel_xy, check_point_in_composition):
129 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
130 (glyph_to_pixel_coords): Remove; unused.
131
132 * dired.c (file_name_completion): Now static.
133
134 * dbusbind.c (xd_in_read_queued_messages): Now static.
135
136 * lisp.h (circular_list_error, FOREACH): Remove; unused.
137 * data.c (circular_list_error): Remove.
138
139 2011-04-11 Paul Eggert <eggert@cs.ucla.edu>
140
141 * commands.h (last_point_position, last_point_position_buffer):
142 (last_point_position_window): Remove decls.
143 * keyboard.c: Make these variables static.
144
145 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
146 decls.
147 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
148 (iso_code_class, detect_coding, code_convert_region): Now static.
149 (encode_coding_gap): Remove; unused.
150
151 * chartab.c (chartab_chars, chartab_bits): Now static.
152
153 * charset.h (charset_iso_8859_1): Remove decl.
154 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
155 Now static.
156
157 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
158 * ccl.c (Vccl_program_table): Now static.
159 (check_ccl_update): Remove; unused.
160
161 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
162 * category.h: ... from here.
163 * category.c (check_category_table, set_category_set): Now static.
164
165 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
166 * lisp.h: Remove these decls.
167
168 * buffer.c (buffer_count): Remove unused var.
169
170 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
171 so that it's not optimized away.
172 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
173 * dispextern.h (bidi_dump_cached_states): Remove, since it's
174 exported only to the debugger.
175
176 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
177 * atimer.h (run_all_atimers): Removed; not exported.
178
179 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
180 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
181 was inaccessible from Lisp.
182 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
183 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
184
185 alloc.c: Import and export fewer symbols, and remove unused items.
186 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
187 is defined.
188 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
189 it's not optimized away by whole-program optimization.
190 (message_enable_multibyte, free_misc): Remove.
191 (catchlist, handlerlist, mark_backtrace):
192 Declare only if BYTE_MARK_STACK.
193 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
194 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
195 (message_enable_multibyte): Remove decl.
196 (free_misc, interval_free_list, float_block, float_block_index):
197 (n_float_blocks, float_free_list, cons_block, cons_block_index):
198 (cons_free_list, last_marked_index):
199 Now static.
200 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
201 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
202 (mark_backtrace): Define only if BYTE_MARK_STACK.
203 * xdisp.c (message_enable_multibyte): Now static.
204
205 Declare Lisp_Object Q* variables to be 'static' if not exproted.
206 This makes it easier for human readers (and static analyzers)
207 to see whether these variables are used from other modules.
208 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
209 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
210 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
211 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
212 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
213 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
214 * xmenu.c, xselect.c:
215 Declare Q* vars static if they are not used in other modules.
216 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
217 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
218 Remove decls of unexported vars.
219 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
220
221 * lisp.h (DEFINE_FUNC): Make sname 'static'.
222
223 Make Emacs functions such as Fatom 'static' by default.
224 This makes it easier for human readers (and static analyzers)
225 to see whether these functions can be called from other modules.
226 DEFUN now defines a static function. To make the function external
227 so that it can be used in other C modules, use the new macro DEFUE.
228 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
229 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
230 static function definition. Use DEFUE if you want an extern one.
231 (DEFUE, INFUN): New macros.
232 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
233 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
234 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
235 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
236 Remove decls, since these functions are now static.
237 (Funintern, Fget_internal_run_time): New decls, since these functions
238 were already external.
239
240 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
241 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
242 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
243 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
244 * keyboard.c, keymap.c, lread.c:
245 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
246 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
247 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
248 Mark functions with DEFUE instead of DEFUN,
249 if they are used in other modules.
250 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
251 decls for now-static functions.
252 * buffer.h (Fdelete_overlay): Remove decl.
253 * callproc.c (Fgetenv_internal): Mark as internal.
254 * composite.c (Fremove_list_of_text_properties): Remove decl.
255 (Fcomposition_get_gstring): New forward static decl.
256 * composite.h (Fcomposite_get_gstring): Remove decl.
257 * dired.c (Ffile_attributes): New forward static decl.
258 * doc.c (Fdocumntation_property): New forward static decl.
259 * eval.c (Ffetch_bytecode): New forward static decl.
260 (Funintern): Remove extern decl; now in .h file where it belongs.
261 * fileio.c (Fmake_symbolic_link): New forward static decl.
262 * image.c (Finit_image_library): New forward static decl.
263 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
264 * intervals.h (Fprevious_property_change):
265 (Fremove_list_of_text_properties): Remove decls.
266 * keyboard.c (Fthis_command_keys): Remove decl.
267 (Fcommand_execute): New forward static decl.
268 * keymap.c (Flookup_key): New forward static decl.
269 (Fcopy_keymap): Now static.
270 * keymap.h (Flookup_key): Remove decl.
271 * process.c (Fget_process): New forward static decl.
272 (Fprocess_datagram_address): Mark as internal.
273 * syntax.c (Fsyntax_table_p): New forward static decl.
274 (skip_chars): Remove duplicate decl.
275 * textprop.c (Fprevious_property_change): New forward static decl.
276 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
277 Now internal.
278 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
279 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
280
281 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
282
283 * editfns.c (Fformat): Remove unreachable code.
284
285 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
286
287 Fix more problems found by GCC 4.6.0's static checks.
288
289 * xdisp.c (vmessage): Use a better test for character truncation.
290
291 * charset.c (load_charset_map): <, not <=, for optimization,
292 and to avoid potential problems with integer overflow.
293 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
294 * casetab.c (set_identity, shuffle): Likewise.
295 * editfns.c (Fformat): Likewise.
296 * syntax.c (skip_chars): Likewise.
297
298 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
299 This also lets GCC 4.6.0 generate slightly better loop code.
300
301 * callint.c (Fcall_interactively): <, not <=, for optimization.
302 (Fcall_interactively): Count the number of arguments produced,
303 not the number of arguments given. This is simpler and lets GCC
304 4.6.0 generate slightly better code.
305
306 * ftfont.c: Distingish more carefully between FcChar8 and char.
307 The previous code passed unsigned char * to a functions like
308 strlen and xstrcasecmp that expect char *, which does not
309 conform to the C standard.
310 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
311 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
312 char * when the C standard requires it.
313
314 * keyboard.c (read_char): Remove unused var.
315
316 * eval.c: Port to Windows vsnprintf (Bug#8435).
317 Include <limits.h>.
318 (SIZE_MAX): Define if the headers do not.
319 (verror): Do not give up if vsnprintf returns a negative count.
320 Instead, grow the buffer. This ports to Windows vsnprintf, which
321 does not conform to C99. Problem reported by Eli Zaretskii.
322 Also, simplify the allocation scheme, by avoiding the need for
323 calling realloc, and removing the ALLOCATED variable.
324
325 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
326
327 Remove invocations of doprnt, as Emacs now uses vsnprintf.
328 But keep the doprint source code for now, as we might revamp it
329 and use it again (Bug#8435).
330 * lisp.h (doprnt): Remove.
331 * Makefile.in (base_obj): Remove doprnt.o.
332 * deps.mk (doprnt.o): Remove.
333
334 error: Print 32- and 64-bit integers portably (Bug#8435).
335 Without this change, on typical 64-bit hosts error ("...%d...", N)
336 was used to print both 32- and 64-bit integers N, which relied on
337 undefined behavior.
338 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
339 New macro.
340 * lisp.h (error, verror): Mark as printf-like functions.
341 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
342 Report overflow in size calculations when allocating printf buffer.
343 Do not truncate output string at its first null byte.
344 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
345 Truncate the output at a character boundary, since vsnprintf does not
346 do that.
347 * charset.c (check_iso_charset_parameter): Convert internal
348 character to string before calling 'error', since %c now has the
349 printf meaning.
350 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
351 overflow when computing char to be passed to 'error'. Do not
352 pass Lisp_Object to 'error'; pass the integer instead.
353 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
354 formatted with plain %d.
355
356 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
357
358 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
359
360 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
361
362 * xterm.c (x_catch_errors): Remove duplicate declaration.
363
364 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
365
366 * xdisp.c, lisp.h (message_nolog): Remove; unused.
367
368 2011-04-10 Jim Meyering <meyering@redhat.com>
369
370 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
371 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
372 return ssize_t not "int", and use size_t as the buffer length.
373 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
374 * gnutls.h: Update declarations.
375 * process.c (read_process_output): Use ssize_t, to match.
376 (send_process): Likewise.
377
378 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
379
380 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
381
382 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
383
384 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
385 unsigned char, to match FcChar8 type definition.
386
387 * xterm.c (handle_one_xevent):
388 * xmenu.c (create_and_show_popup_menu):
389 * xselect.c (x_decline_selection_request)
390 (x_reply_selection_request): Avoid type-punned deref of X events.
391
392 2011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
393
394 Fix some uses of `int' instead of EMACS_INT.
395 * search.c (string_match_1, fast_string_match)
396 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
397 (scan_buffer, find_next_newline_no_quit)
398 (find_before_next_newline, search_command, Freplace_match)
399 (Fmatch_data): Make some `int' variables be EMACS_INT.
400
401 * xdisp.c (display_count_lines): 3rd argument and return value now
402 EMACS_INT. All callers changed.
403 (pint2hrstr): Last argument is now EMACS_INT.
404
405 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
406 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
407 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
408 (decode_coding_utf_16, decode_coding_emacs_mule)
409 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
410 (decode_coding_ccl, decode_coding_charset)
411 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
412 (decode_coding_iso_2022, decode_coding_emacs_mule)
413 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
414 <char_offset, last_offset>: Declare EMACS_INT.
415 (encode_coding_utf_8, encode_coding_utf_16)
416 (encode_coding_emacs_mule, encode_invocation_designation)
417 (encode_designation_at_bol, encode_coding_iso_2022)
418 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
419 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
420 Declare EMACS_INT.
421 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
422 (encode_invocation_designation): Last argument P_NCHARS is now
423 EMACS_INT.
424 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
425 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
426
427 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
428 All users changed.
429
430 * ccl.c (Fccl_execute_on_string): Declare some variables
431 EMACS_INT.
432
433 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
434
435 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
436
437 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
438
439 * process.c (Fformat_network_address): Doc fix.
440
441 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
442
443 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
444
445 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
446
447 * keyboard.c (read_char): Call Lisp function help-form-show,
448 instead of using internal_with_output_to_temp_buffer.
449 (Qhelp_form_show): New var.
450 (syms_of_keyboard): Use DEFSYM macro.
451
452 * print.c (internal_with_output_to_temp_buffer): Function deleted.
453
454 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
455
456 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
457
458 * process.c (Flist_processes): Removed to Lisp.
459 (list_processes_1): Deleted.
460
461 2011-04-06 Eli Zaretskii <eliz@gnu.org>
462
463 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
464
465 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
466
467 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
468
469 Fix more problems found by GCC 4.6.0's static checks.
470
471 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
472
473 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
474
475 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
476
477 * xdisp.c (vmessage): Mark as a printf-like function.
478
479 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
480
481 * sound.c (sound_warning): Don't crash if arg contains a printf format.
482
483 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
484 printf-like functions.
485 (tiff_load): Add casts to remove these marks before passing them
486 to system-supplied API.
487
488 * eval.c (Fsignal): Remove excess argument to 'fatal'.
489
490 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
491 This avoids several warnings with gcc -Wstrict-overflow.
492 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
493 directly, rather than having caller test rule sign. This avoids
494 some unnecessary tests.
495 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
496 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
497 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
498
499 * xfont.c (xfont_text_extents): Remove var that was set but not used.
500 (xfont_open): Avoid unnecessary tests.
501
502 * composite.c (composition_gstring_put_cache): Use unsigned integer.
503
504 * composite.h, composite.c (composition_gstring_put_cache):
505 Use EMACS_INT, not int, for length.
506
507 * composite.h (COMPOSITION_DECODE_REFS): New macro,
508 breaking out part of COMPOSITION_DECODE_RULE.
509 (COMPOSITION_DECODE_RULE): Use it.
510 * composite.c (get_composition_id): Remove unused local vars,
511 by using the new macro.
512
513 * textprop.c (set_text_properties_1): Change while to do-while,
514 since the condition is always true at first.
515
516 * intervals.c (graft_intervals_into_buffer): Mark var as used.
517 (interval_deletion_adjustment): Return unsigned value.
518 All uses changed.
519
520 * process.c (list_processes_1, create_pty, read_process_output):
521 (exec_sentinel): Remove vars that were set but not used.
522 (create_pty): Remove unnecessary "volatile"s.
523 (Fnetwork_interface_info): Avoid possibility of int overflow.
524 (read_process_output): Do adaptive read buffering even if carryover.
525 (read_process_output): Simplify nbytes computation if buffered.
526
527 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
528
529 * syntax.c (scan_words): Remove var that was set but not used.
530 (update_syntax_table): Use unsigned instead of int.
531
532 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
533 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
534 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
535
536 * print.c (print_error_message): Avoid int overflow.
537
538 * font.c (font_list_entities): Redo for clarity,
539 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
540
541 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
542 (font_score): Avoid potential overflow in diff calculation.
543
544 * fns.c (substring_both): Remove var that is set but not used.
545 (sxhash): Redo loop for clarity and to avoid wraparound warning.
546
547 * eval.c (funcall_lambda): Rename local to avoid shadowing.
548
549 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
550 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
551 can always succeed if overflow has undefined behavior.
552
553 * search.c (boyer_moore, wordify): Remove vars set but not used.
554 (wordify): Omit three unnecessary tests.
555
556 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
557 All callers changed. This avoids the need for an unused var.
558
559 * casefiddle.c (casify_region): Remove var that is set but not used.
560
561 * dired.c (file_name_completion): Remove var that is set but not used.
562
563 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
564
565 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
566 (Finsert_file_contents): Remove unnecessary code checking fd.
567
568 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
569 Check for integer overflow on size calculations.
570
571 * buffer.c (Fprevious_overlay_change): Remove var that is set
572 but not used.
573
574 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
575 Remove vars that are set but not used.
576 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
577 (timer_check_2): Mark vars as initialized.
578
579 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
580
581 * image.c (lookup_image): Remove var that is set but not used.
582 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
583
584 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
585 that are set but not used.
586
587 * xfns.c (make_invisible_cursor): Don't return garbage
588 if XCreateBitmapFromData fails (Bug#8410).
589
590 * xselect.c (x_get_local_selection, x_handle_property_notify):
591 Remove vars that are set but not used.
592
593 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
594 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
595
596 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
597 Remove var that is set but not used.
598 (scroll_bar_windows_size): Now size_t, not int.
599 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
600 Check for overflow.
601
602 * xfaces.c (realize_named_face): Remove vars that are set but not used.
603 (map_tty_color) [!defined MSDOS]: Likewise.
604
605 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
606
607 * coding.c: Remove vars that are set but not used.
608 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
609 All callers changed.
610 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
611 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
612 (decode_coding_charset): Remove vars that are set but not used.
613
614 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
615 that is set but not used.
616
617 * print.c (print_object): Remove var that is set but not used.
618
619 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
620 The gnulib version avoids calling malloc in the usual case,
621 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
622 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
623 * filelock.c (current_lock_owner): Likewise.
624 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
625 * sysdep.c: Include allocator.h, careadlinkat.h.
626 (emacs_no_realloc_allocator): New static constant.
627 (emacs_readlink): New function.
628 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
629 ../lib/careadlinkat.h.
630
631 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
632
633 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
634 first non-nil return value).
635
636 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
637
638 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
639 if not defined (Bug#8403).
640
641 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
642
643 * xdisp.c (display_count_lines): Remove parameter `start',
644 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
645 (get_char_face_and_encoding): Remove parameter `multibyte_p',
646 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
647 (fill_stretch_glyph_string): Remove parameters `row' and `area',
648 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
649 and thereabouts. All callers changed.
650 (get_per_char_metric): Remove parameter `f', unused since
651 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
652
653 2011-04-02 Jim Meyering <meyering@redhat.com>
654
655 do not dereference NULL upon failed strdup
656 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
657 (ns_get_family): Likewise.
658
659 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
660
661 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
662
663 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
664
665 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
666 later (Bug#8403).
667
668 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
669
670 Add lexical binding.
671
672 * window.c (Ftemp_output_buffer_show): New fun.
673 (Fsave_window_excursion):
674 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
675
676 * lread.c (lisp_file_lexically_bound_p): New function.
677 (Fload): Bind Qlexical_binding.
678 (readevalloop): Remove `evalfun' arg.
679 Bind Qinternal_interpreter_environment.
680 (Feval_buffer): Bind Qlexical_binding.
681 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
682 Mark as dynamic.
683 (syms_of_lread): Declare `lexical-binding'.
684
685 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
686
687 * keyboard.c (eval_dyn): New fun.
688 (menu_item_eval_property): Use it.
689
690 * image.c (parse_image_spec): Use Ffunctionp.
691
692 * fns.c (concat, mapcar1): Accept byte-code-functions.
693
694 * eval.c (Fsetq): Handle lexical vars.
695 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
696 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
697 (FletX, Flet): Obey lexical binding.
698 (Fcommandp): Handle closures.
699 (Feval): New `lexical' arg.
700 (eval_sub): New function extracted from Feval. Use it almost
701 everywhere where Feval was used. Look up vars in lexical env.
702 Handle closures.
703 (Ffunctionp): Move from subr.el.
704 (Ffuncall): Handle closures.
705 (apply_lambda): Remove `eval_flags'.
706 (funcall_lambda): Handle closures and new byte-code-functions.
707 (Fspecial_variable_p): New function.
708 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
709 but without exporting it to Lisp.
710
711 * doc.c (Fdocumentation, store_function_docstring):
712 * data.c (Finteractive_form): Handle closures.
713
714 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
715 interactive spec.
716
717 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
718 byte-codes.
719 (exec_byte_code): New function extracted from Fbyte_code to handle new
720 calling convention for byte-code-functions. Add new byte-codes.
721
722 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
723
724 * alloc.c (Fmake_symbol): Init new `declared_special' field.
725
726 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
727
728 * xdisp.c (redisplay_internal): Fix prototype.
729
730 2011-03-31 Eli Zaretskii <eliz@gnu.org>
731
732 * xdisp.c (SCROLL_LIMIT): New macro.
733 (try_scrolling): Use it when setting scroll_limit. Limit
734 scrolling to 100 screen lines.
735 (redisplay_window): Even when falling back on "recentering",
736 position point in the window according to scroll-conservatively,
737 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
738
739 (try_scrolling): When point is above the window, allow searching
740 as far as scroll_max, or one screenful, to compute vertical
741 distance from PT to the scroll margin position. This prevents
742 try_scrolling from unnecessarily failing when
743 scroll-conservatively is set to a value slightly larger than the
744 window height. Clean up the case of PT below the margin at bottom
745 of window: scroll_max can no longer be INT_MAX. When aggressive
746 scrolling is in use, don't let point enter the opposite scroll
747 margin as result of the scroll.
748 (syms_of_xdisp) <scroll-conservatively>: Document the
749 threshold of 100 lines for never-recentering scrolling.
750
751 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
752
753 * dispextern.h (move_it_by_lines):
754 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
755 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
756 (message_log_check_duplicate): Remove parameters `prev_bol' and
757 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
758 (redisplay_internal): Remove parameter `preserve_echo_area',
759 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
760
761 * indent.c (Fvertical_motion):
762 * window.c (window_scroll_pixel_based, Frecenter):
763 Don't pass `need_y_p' to `move_it_by_lines'.
764
765 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
766
767 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
768 steal a few bits to be more compact.
769 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
770 Remove unneeded casts.
771
772 * bytecode.c (Fbyte_code): CAR and CDR can GC.
773
774 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
775
776 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
777 binding" message (bug#7967).
778
779 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
780
781 Fix more problems found by GCC 4.6.0's static checks.
782
783 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
784 Remove unused local var.
785
786 * editfns.c (Fmessage_box): Remove unused local var.
787
788 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
789 (note_mode_line_or_margin_highlight, note_mouse_highlight):
790 Omit unused local vars.
791 * window.c (shrink_windows): Omit unused local var.
792 * menu.c (digest_single_submenu): Omit unused local var.
793 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
794 Omit unused local var.
795
796 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
797 Don't assume string length fits in int.
798 (keyremap_step, read_key_sequence): Use size_t for sizes.
799 (read_key_sequence): Don't check last_real_key_start redundantly.
800
801 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
802 instead of alloca (Bug#8344).
803
804 * eval.c (Fbacktrace): Don't assume nargs fits in int.
805 (Fbacktrace_frame): Don't assume nframes fits in int.
806
807 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
808
809 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
810 concerns.
811
812 * term.c (produce_glyphless_glyph): Remove unnecessary test.
813
814 * cm.c (calccost): Turn while-do into do-while, for clarity.
815
816 * keyboard.c (syms_of_keyboard): Use the same style as later
817 in this function when indexing through an array. This also
818 works around GCC bug 48267.
819
820 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
821
822 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
823
824 * chartab.c (sub_char_table_ref_and_range): Redo for slight
825 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
826
827 * keyboard.c, keyboard.h (num_input_events): Now size_t.
828 This avoids undefined behavior on integer overflow, and is a bit
829 more convenient anyway since it is compared to a size_t variable.
830
831 Variadic C functions now count arguments with size_t, not int.
832 This avoids an unnecessary limitation on 64-bit machines, which
833 caused (substring ...) to crash on large vectors (Bug#8344).
834 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
835 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
836 All variadic functions and their callers changed accordingly.
837 (struct gcpro.nvars): Now size_t, not int. All uses changed.
838 * data.c (arith_driver, float_arith_driver): Likewise.
839 * editfns.c (general_insert_function): Likewise.
840 * eval.c (struct backtrace.nargs, interactive_p)
841 (internal_condition_case_n, run_hook_with_args, apply_lambda)
842 (funcall_lambda, mark_backtrace): Likewise.
843 * fns.c (concat): Likewise.
844 * frame.c (x_set_frame_parameters): Likewise.
845 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
846 0 if not found, not -1. All callers changed.
847
848 * alloc.c (garbage_collect): Don't assume stack size fits in int.
849 (stack_copy_size): Now size_t, not int.
850 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
851
852 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
853
854 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
855 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
856 All callers changed.
857
858 * lisp.h (multibyte_char_to_unibyte):
859 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
860 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
861 * character.h (CHAR_TO_BYTE8):
862 * cmds.c (internal_self_insert):
863 * editfns.c (general_insert_function):
864 * keymap.c (push_key_description):
865 * search.c (Freplace_match):
866 * xdisp.c (message_dolog, set_message_1): All callers changed.
867
868 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
869
870 * keyboard.c (safe_run_hook_funcall): New function.
871 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
872 don't set the hook to nil, but remove the offending function instead.
873 (Qcommand_hook_internal): Remove, unused.
874 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
875 Vcommand_hook_internal.
876
877 * eval.c (enum run_hooks_condition): Remove.
878 (funcall_nil, funcall_not): New functions.
879 (run_hook_with_args): Call each function through a `funcall' argument.
880 Remove `cond' argument, now redundant.
881 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
882 (Frun_hook_with_args_until_failure): Adjust accordingly.
883 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
884
885 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
886
887 * dispextern.h (string_buffer_position): Remove declaration.
888
889 * print.c (strout): Remove parameter `multibyte', unused since
890 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
891
892 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
893 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
894 All callers changed.
895
896 * w32.c (_wsa_errlist): Use braces for struct initializers.
897
898 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
899 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
900 All callers changed.
901 (string_buffer_position): Likewise. Also, make static (it's never
902 used outside xdisp.c).
903 (cursor_row_p): Remove parameter `w', unused since
904 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
905 (decode_mode_spec): Remove parameter `precision', introduced during
906 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
907 All callers changed.
908
909 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
910
911 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
912
913 2011-03-27 Anders Lindgren <andlind@gmail.com>
914
915 * nsterm.m (ns_menu_bar_is_hidden): New variable.
916 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
917 (ns_update_auto_hide_menu_bar): New functions.
918 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
919 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
920 ns_constrain_all_frames.
921 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
922 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
923
924 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
925
926 * nsmenu.m (runDialogAt): Remove argument to timer_check.
927
928 2011-03-27 Glenn Morris <rgm@gnu.org>
929
930 * syssignal.h: Replace RETSIGTYPE with void.
931 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
932 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
933 Replace SIGTYPE with void everywhere.
934 * s/usg5-4-common.h (SIGTYPE): Remove definition.
935 * s/template.h (SIGTYPE): Remove commented out definition.
936
937 2011-03-26 Eli Zaretskii <eliz@gnu.org>
938
939 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
940 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
941
942 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
943
944 * w32.c (read_unc_volume): Use parameter `henum', instead of
945 global variable `wget_enum_handle'.
946
947 * keymap.c (describe_vector): Remove parameters `indices' and
948 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
949 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
950
951 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
952
953 * keyboard.c (timer_check): Remove parameter `do_it_now',
954 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
955 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
956 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
957
958 * keyboard.c (read_char):
959 * w32menu.c (w32_menu_display_help):
960 * xmenu.c (show_help_event, menu_help_callback):
961 Adjust calls to `show_help_echo'.
962
963 * gtkutil.c (xg_maybe_add_timer):
964 * keyboard.c (readable_events):
965 * process.c (wait_reading_process_output):
966 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
967
968 * insdel.c (adjust_markers_gap_motion):
969 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
970 (gap_left, gap_right): Don't call it.
971
972 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
973
974 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
975 incurred during fontification.
976
977 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
978
979 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
980 (DEFVAR_PER_BUFFER): Don't pass it.
981
982 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
983 (scrolling_window): Don't pass it.
984
985 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
986
987 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
988
989 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
990 and `suffix'.
991 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
992 of variables specific to SELinux and computation of `encoded_absname'.
993
994 * image.c (XPutPixel): Remove unused variable `height'.
995
996 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
997
998 * unexw32.c (get_section_info): Remove unused variable `section'.
999
1000 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1001 (system_process_attributes): Remove unused variable `sess'.
1002 (sys_read): Remove unused variable `err'.
1003
1004 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1005 (w32_wnd_proc): Remove unused variable `isdead'.
1006 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1007 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1008 (x_create_tip_frame): Remove unused variable `tem'.
1009
1010 * w32inevt.c (w32_console_read_socket):
1011 Remove unused variable `no_events'.
1012
1013 * w32term.c (x_draw_composite_glyph_string_foreground):
1014 Remove unused variable `width'.
1015
1016 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1017
1018 * w32term.c (x_set_glyph_string_clipping):
1019 Don't pass uninitialized region to CombineRgn.
1020
1021 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1022
1023 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1024 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1025 (Fx_close_connection): Remove unused variable `i'.
1026
1027 * w32font.c (w32font_draw): Return number of glyphs.
1028 (w32font_open_internal): Remove unused variable `i'.
1029 (w32font_driver): Add missing initializer.
1030
1031 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1032 (fill_in_menu): Remove unused variable `items_added'.
1033
1034 * w32term.c (last_mouse_press_frame): Remove static global variable.
1035 (w32_clip_to_row): Remove unused variable `f'.
1036 (x_delete_terminal): Remove unused variable `i'.
1037
1038 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1039 (NOTHING): Remove unused static global variable.
1040 (uniscribe_check_otf): Remove unused variable `table'.
1041 (uniscribe_font_driver): Add missing initializers.
1042
1043 2011-03-23 Julien Danjou <julien@danjou.info>
1044
1045 * term.c (Fsuspend_tty, Fresume_tty):
1046 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1047 * window.c (temp_output_buffer_show):
1048 * insdel.c (signal_before_change):
1049 * frame.c (Fhandle_switch_frame):
1050 * fileio.c (Fdo_auto_save):
1051 * emacs.c (Fkill_emacs):
1052 * editfns.c (save_excursion_restore):
1053 * cmds.c (internal_self_insert):
1054 * callint.c (Fcall_interactively):
1055 * buffer.c (Fkill_all_local_variables):
1056 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1057 Use Frun_hooks.
1058 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1059 unconditionnaly since it does the check itself.
1060
1061 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1062
1063 Fix more problems found by GCC 4.5.2's static checks.
1064
1065 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1066 the first time through the loop, since we know p0 < p1 then.
1067 This also avoids a gcc -Wstrict-overflow warning.
1068
1069 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1070 leading to a memory leak, possible in functions like
1071 load_charset_map_from_file that can allocate an unbounded number
1072 of objects (Bug#8318).
1073
1074 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1075 that could (at least in theory) be that large.
1076
1077 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1078 This is less likely to overflow, and avoids undefined behavior if
1079 overflow does occur. All callers changed. Use strtoul to scan
1080 for the unsigned long integer.
1081 (pint2hrstr): Simplify and tune code slightly.
1082 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1083
1084 * scroll.c (do_scrolling): Work around GCC bug 48228.
1085 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1086
1087 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1088 This also avoids a warning with gcc -Wstrict-overflow.
1089 (validate_x_resource_name): Simplify count usage.
1090 This also avoids a warning with gcc -Wstrict-overflow.
1091
1092 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1093 fail (Bug#8306).
1094
1095 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1096
1097 * process.c (Fmake_network_process): Use socklen_t, not int,
1098 where POSIX says socklen_t is required in portable programs.
1099 This fixes a porting bug on hosts like 64-bit HP-UX, where
1100 socklen_t is wider than int (Bug#8277).
1101 (Fmake_network_process, server_accept_connection):
1102 (wait_reading_process_output, read_process_output):
1103 Likewise.
1104
1105 * process.c: Rename or move locals to avoid shadowing.
1106 (list_processes_1, Fmake_network_process):
1107 (read_process_output_error_handler, exec_sentinel_error_handler):
1108 Rename or move locals.
1109 (Fmake_network_process): Define label "retry_connect" only if needed.
1110 (Fnetwork_interface_info): Fix pointer signedness.
1111 (process_send_signal): Add cast to avoid pointer signedness problem.
1112 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1113 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1114
1115 Make tparam.h and terminfo.c consistent.
1116 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1117 Include tparam.h instead, since it declares them.
1118 * cm.h (PC): Remove extern decl; tparam.h now does this.
1119 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1120 * terminfo.c: Include tparam.h, to check interfaces.
1121 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1122 (tparam): Adjust signature to match interface in tparam.h;
1123 this removes some undefined behavior. Check that outstring and len
1124 are zero, which they always are with Emacs.
1125 * tparam.h (PC, BC, UP): New extern decls.
1126
1127 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1128 (xftfont_open): Rename locals to avoid shadowing.
1129
1130 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1131 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1132 (OTF_TAG_SYM): Omit macro if not needed.
1133 (ftfont_list): Remove unused local.
1134 (get_adstyle_property, ftfont_pattern_entity):
1135 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1136 Rename locals to avoid shadowing.
1137
1138 * xfont.c (xfont_list_family): Mark var as initialized.
1139
1140 * xml.c (make_dom): Now static.
1141
1142 * composite.c (composition_compute_stop_pos): Rename local to
1143 avoid shadowing.
1144 (composition_reseat_it): Remove unused locals.
1145 (find_automatic_composition, composition_adjust_point): Likewise.
1146 (composition_update_it): Mark var as initialized.
1147 (find_automatic_composition): Mark vars as initialized,
1148 with a FIXME (Bug#8290).
1149
1150 character.h: Rename locals to avoid shadowing.
1151 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1152 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1153 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1154 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1155 to avoid shadowing.
1156
1157 * textprop.c (property_change_between_p): Remove; unused.
1158
1159 * intervals.c (interval_start_pos): Now static.
1160
1161 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1162
1163 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1164 Rename locals to avoid shadowing.
1165
1166 * sound.c (wav_play, au_play, Fplay_sound_internal):
1167 Fix pointer signedness.
1168 (alsa_choose_format): Remove unused local var.
1169 (wav_play): Initialize a variable to 0, to prevent undefined
1170 behavior (Bug#8278).
1171
1172 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1173
1174 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1175
1176 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1177 clobbering (Bug#8298).
1178 * sysdep.c (sys_subshell): Likewise.
1179 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1180
1181 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1182 This should get cleaned up, so that child_setup has the
1183 same signature on all platforms.
1184
1185 * callproc.c (call_process_cleanup): Now static.
1186 (relocate_fd): Rename locals to avoid shadowing.
1187
1188 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1189
1190 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1191 not to be necessary, and produces flickering.
1192
1193 2011-03-20 Glenn Morris <rgm@gnu.org>
1194
1195 * config.in: Remove file.
1196
1197 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1198
1199 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1200 are now in src/globals.h.
1201 (syms_of_minibuf): Remove spurious & from previous change.
1202
1203 2011-03-20 Leo <sdl.web@gmail.com>
1204
1205 * minibuf.c (completing-read-function): New variable.
1206 (completing-read-default): Rename from completing-read.
1207 (completing-read): Call completing-read-function.
1208
1209 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1210
1211 * xfaces.c (Fx_load_color_file):
1212 Read color file from absolute filename (bug#8250).
1213
1214 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1215
1216 * makefile.w32-in: Update dependencies.
1217
1218 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1219
1220 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1221
1222 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1223
1224 Fix more problems found by GCC 4.5.2's static checks.
1225
1226 * process.c (make_serial_process_unwind, send_process_trap):
1227 (sigchld_handler): Now static.
1228
1229 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1230 That way, the code declares only the vars that it needs.
1231 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1232 * s/cygwin.h (PTY_ITERATION): Likewise.
1233 * s/darwin.h (PTY_ITERATION): Likewise.
1234 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1235
1236 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1237 * process.c (allocate_pty): Don't declare stb unless it's needed.
1238
1239 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1240 (CONSTANTLIM): Remove; unused.
1241 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1242 Define only if needed.
1243
1244 * unexelf.c (unexec): Name an expression,
1245 to avoid gcc -Wbad-function-cast warning.
1246 Use a different way to cause a compilation error if anyone uses
1247 n rather than nn, a way that does not involve shadowing.
1248 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1249
1250 * deps.mk (unexalpha.o): Remove; unused.
1251
1252 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1253 * unexec.h: New file.
1254 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1255 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1256 Depend on unexec.h.
1257 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1258 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1259 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1260 Change as necessary to match prototype in unexec.h.
1261
1262 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1263 shadowing.
1264 (back_comment, skip_chars): Mark vars as initialized.
1265
1266 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1267 Rename locals to avoid shadowing.
1268
1269 * lread.c (read1): Rewrite so as not to use empty "else".
1270 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1271
1272 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1273
1274 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1275 warning when compiling print.c.
1276
1277 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1278 instead of using an uninitialized var.
1279 (font_sort_entities): Mark var as initialized.
1280
1281 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1282
1283 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1284 pointers to constants.
1285 (font_parse_fcname): Remove unused vars.
1286 (font_delete_unmatched): Now static.
1287 (font_get_spec): Remove; unused.
1288 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1289 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1290 Rename or move locals to avoid shadowing.
1291
1292 * fns.c (require_nesting_list, require_unwind): Now static.
1293 (Ffillarray): Rename locals to avoid shadowing.
1294
1295 * floatfns.c (domain_error2): Define only if needed.
1296 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1297
1298 * alloc.c (mark_backtrace): Move decl from here ...
1299 * lisp.h: ... to here, so that it can be checked.
1300
1301 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1302 (Fdefvar): Rewrite so as not to use empty "else".
1303 (lisp_indirect_variable): Name an expression,
1304 to avoid gcc -Wbad-function-cast warning.
1305 (Fdefvar): Rename locals to avoid shadowing.
1306
1307 * callint.c (quotify_arg, quotify_args): Now static.
1308 (Fcall_interactively): Rename locals to avoid shadowing.
1309 Use const pointer when appropriate.
1310
1311 * lisp.h (get_system_name, get_operating_system_release):
1312 Move decls here, to check interfaces.
1313 * process.c (get_operating_system_release): Move decl to lisp.h.
1314 * xrdb.c (get_system_name): Likewise.
1315 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1316 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1317 some of which prompt warnings from gcc -Wbad-function-cast.
1318 (Fformat_time_string, Fencode_time, Finsert_char):
1319 (Ftranslate_region_internal, Fformat):
1320 Rename or remove local vars to avoid shadowing.
1321 (Ftranslate_region_internal): Mark var as initialized.
1322
1323 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1324 avoid shadowing.
1325
1326 * lisp.h (eassert): Check that the argument compiles, even if
1327 ENABLE_CHECKING is not defined.
1328
1329 * data.c (Findirect_variable): Name an expression, to avoid
1330 gcc -Wbad-function-cast warning.
1331 (default_value, arithcompare, arith_driver, arith_error): Now static.
1332 (store_symval_forwarding): Rename local to avoid shadowing.
1333 (Fmake_variable_buffer_local, Fmake_local_variable):
1334 Mark variables as initialized.
1335 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1336
1337 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1338 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1339 Rename locals to avoid shadowing.
1340 (mark_stack): Move local variables into the #ifdef region where
1341 they're used.
1342 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1343 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1344 needed otherwise.
1345 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1346 (GC_STRING_CHARS): Remove; not used.
1347 (Fmemory_limit): Cast sbrk's returned value to char *.
1348
1349 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1350 avoids undefined behavior in theory.
1351
1352 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1353
1354 Use functions, not macros, for up- and down-casing (Bug#8254).
1355 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1356 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1357 to use the following functions instead of these macros.
1358 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1359 EMACS_INT, since callers assume the returned value fits in int.
1360 (upcase1): Likewise, for UPCASE_TABLE.
1361 (uppercasep, lowercasep, upcase): New static inline functions.
1362 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1363 the race-condition problem in the old DOWNCASE.
1364
1365 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1366 Rename locals to avoid shadowing.
1367 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1368 (regex_compile, re_search_2, re_match_2_internal):
1369 Remove unused local vars.
1370 (FREE_VAR): Rewrite so as not to use empty "else",
1371 which gcc can warn about.
1372 (regex_compile, re_match_2_internal): Mark locals as initialized.
1373 (RETALLOC_IF): Define only if needed.
1374 (WORDCHAR_P): Likewise. This one is never needed, but is used
1375 only in a comment talking about a compiler bug, so put inside
1376 the #if 0 of that comment.
1377 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1378 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1379 Remove; unused.
1380
1381 * search.c (boyer_moore): Rename locals to avoid shadowing.
1382 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1383 (PREV_CHAR_BOUNDARY): Likewise.
1384
1385 * search.c (simple_search): Remove unused var.
1386
1387 * dired.c (compile_pattern): Move decl from here ...
1388 * lisp.h: ... to here, so that it can be checked.
1389 (struct re_registers): New forward decl.
1390
1391 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1392
1393 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1394 All uses changed.
1395 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1396 Rename locals to avoid shadowing.
1397 (Fvertical_motion): Mark locals as initialized.
1398
1399 * casefiddle.c (casify_object, casify_region): Now static.
1400 (casify_region): Mark local as initialized.
1401
1402 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1403
1404 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1405 New macros, so that the caller can use some names other than
1406 gcpro1, gcpro2, etc.
1407 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1408 of the new macros.
1409 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1410 argument, for consistency with GCPRO2_VAR, etc: it is now the
1411 prefix of the variable, not the variable itself. All uses
1412 changed.
1413 * dired.c (directory_files_internal, file_name_completion):
1414 Rename locals to avoid shadowing.
1415
1416 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1417 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1418 dired.c's scmp function, had undefined behavior.
1419 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1420 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1421 * buffer.h: ... to here, because these macros use current_buffer,
1422 and the new implementation with inline functions needs to have
1423 current_buffer in scope now, rather than later when the macros
1424 are used.
1425 (downcase, upcase1): New static inline functions.
1426 (DOWNCASE, UPCASE1): Reimplement using these functions.
1427 This avoids undefined behavior in expressions like
1428 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1429 from race conditions in accessing the global variables
1430 case_temp1 and case_temp2.
1431 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1432 * lisp.h (case_temp1, case_temp2): Remove their decls.
1433 * character.h (ASCII_CHAR_P): Move from here ...
1434 * lisp.h: ... to here, so that the inline functions mentioned
1435 above can use them.
1436
1437 * dired.c (directory_files_internal_unwind): Now static.
1438
1439 * fileio.c (file_name_as_directory, directory_file_name):
1440 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1441 Now static.
1442 (file_name_as_directory): Use const pointers when appropriate.
1443 (Fexpand_file_name): Likewise. In particular, newdir might
1444 point at constant storage, so make it a const pointer.
1445 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1446 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1447 signedness issues.
1448 (Fset_file_times, Finsert_file_contents, auto_save_error):
1449 Rename locals to avoid shadowing.
1450
1451 * minibuf.c (choose_minibuf_frame_1): Now static.
1452 (Ftry_completion, Fall_completions): Rename or remove locals
1453 to avoid shadowing.
1454
1455 * marker.c (bytepos_to_charpos): Remove; unused.
1456
1457 * lisp.h (verify_bytepos, count_markers): New decls,
1458 so that gcc does not warn that these functions aren't declared.
1459
1460 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1461 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1462 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1463 (copy_text): Remove unused local var.
1464
1465 * filelock.c (within_one_second): Now static.
1466 (lock_file_1): Rename local to avoid shadowing.
1467
1468 * buffer.c (fix_overlays_before): Mark locals as initialized.
1469 (fix_start_end_in_overlays): Likewise. This function should be
1470 simplified by using pointers-to-pointers, but that's a different
1471 matter.
1472 (switch_to_buffer_1): Now static.
1473 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1474 (report_overlay_modification): Rename locals to avoid shadowing.
1475
1476 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1477 Fix pointer signedness issue.
1478 (sys_subshell): Mark local as volatile if checking for lint,
1479 to suppress a gcc -Wclobbered warning that does not seem to be right.
1480 (MAXPATHLEN): Define only if needed.
1481
1482 * process.c (serial_open, serial_configure): Move decls from here ...
1483 * systty.h: ... to here, so that they can be checked.
1484
1485 * fns.c (get_random, seed_random): Move extern decls from here ...
1486 * lisp.h: ... to here, so that they can be checked.
1487
1488 * sysdep.c (reset_io): Now static.
1489 (wait_for_termination_signal): Remove; unused.
1490
1491 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1492 (copy_keymap_item, append_key, push_text_char_description):
1493 Now static.
1494 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1495 (DENSE_TABLE_SIZE): Remove; unused.
1496 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1497 (describe_map_tree):
1498 Rename locals to avoid shadowing.
1499
1500 * keyboard.c: Declare functions static if they are not used elsewhere.
1501 (echo_char, echo_dash, cmd_error, top_level_2):
1502 (poll_for_input, handle_async_input): Now static.
1503 (read_char, kbd_buffer_get_event, make_lispy_position):
1504 (make_lispy_event, make_lispy_movement, apply_modifiers):
1505 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1506 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1507 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1508 (read_key_sequence, read_char): Mark locals as initialized.
1509 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1510
1511 * keyboard.h (make_ctrl_char): New decl.
1512 (mark_kboards): Move decl here ...
1513 * alloc.c (mark_kboards): ... from here.
1514
1515 * lisp.h (force_auto_save_soon): New decl.
1516
1517 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1518 (DEFINE_DUMMY_FUNCTION): New macro.
1519 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1520 Use it.
1521 (main): Add casts to avoid warnings
1522 if GCC considers string literals to be constants.
1523
1524 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1525
1526 * dbusbind.c: Pointer signedness fixes.
1527 (xd_signature, xd_append_arg, xd_initialize):
1528 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1529 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1530 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1531 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1532
1533 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1534 if GCC considers string literals to be constants.
1535 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1536
1537 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1538
1539 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1540 (print_preprocess, print_object): New macro to fix last change.
1541
1542 * print.c (print_preprocess): Don't forget font objects.
1543
1544 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1545
1546 * emacs.c (USAGE3): Doc fixes.
1547
1548 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1549
1550 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1551 structure.
1552
1553 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1554
1555 * lisp.h (VWindow_system, Qfile_name_history):
1556 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1557 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1558 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1559
1560 * w32select.c: Don't #include "keyboard.h".
1561 (run_protected): Add extern declaration for waiting_for_input.
1562
1563 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1564 * w32console.c (detect_input_pending, read_input_pending)
1565 (encode_terminal_code):
1566 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1567 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1568 (w32_system_caret_y, Qfile_name_history):
1569 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1570 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1571 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1572 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1573 * w32proc.c (Qlocal, report_file_error):
1574 * w32term.c (Vwindow_system, updating_frame):
1575 * w32uniscribe.c (initialized, uniscribe_font_driver):
1576 Remove unneeded extern declarations.
1577
1578 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1579
1580 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1581
1582 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1583
1584 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1585 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1586 These macros can no longer be used for assignment.
1587
1588 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1589 Assign struct members directly, instead of using BUF_BEGV etc.
1590 (record_buffer_markers, fetch_buffer_markers): New functions for
1591 recording and fetching special buffer markers.
1592 (set_buffer_internal_1, set_buffer_temp): Use them.
1593
1594 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1595
1596 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1597
1598 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1599 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1600
1601 * xdisp.c (hscroll_window_tree):
1602 (reconsider_clip_changes): Use PT instead of BUF_PT.
1603
1604 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1605
1606 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1607 $(EMACS_ROOT)/lib/intprops.h.
1608
1609 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1610
1611 Fix more problems found by GCC 4.5.2's static checks.
1612
1613 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1614 to unsigned char * to avoid compiler diagnostic.
1615 (xg_free_frame_widgets): Make it clear that a local variable is
1616 needed only if USE_GTK_TOOLTIP.
1617 (gdk_window_get_screen): Make it clear that this macro is needed
1618 only if USE_GTK_TOOLTIP.
1619 (int_gtk_range_get_value): New function, which avoids a diagnostic
1620 from gcc -Wbad-function-cast.
1621 (xg_set_toolkit_scroll_bar_thumb): Use it.
1622 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1623 diagnostic from gcc -Wbad-function-cast.
1624 (get_utf8_string, xg_get_file_with_chooser):
1625 Rename locals to avoid shadowing.
1626 (create_dialog): Move locals to avoid shadowing.
1627
1628 * xgselect.c (xg_select): Remove unused var.
1629
1630 * image.c (four_corners_best): Mark locals as initialized.
1631 (gif_load): Initialize transparent_p to zero (Bug#8238).
1632 Mark another local as initialized.
1633 (my_png_error, my_error_exit): Mark with NO_RETURN.
1634
1635 * image.c (clear_image_cache): Now static.
1636 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1637 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1638 (x_edge_detection): Remove unnecessary cast that
1639 gcc -Wbad-function-cast diagnoses.
1640 (gif_load): Fix pointer signedness.
1641 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1642 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1643
1644 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 Improve quality of tests for time stamp overflow.
1647 For example, without this patch (encode-time 0 0 0 1 1
1648 1152921504606846976) returns the obviously-bogus value (-948597
1649 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1650 reports time overflow. See
1651 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1652 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1653 * editfns.c: Include limits.h and intprops.h.
1654 (TIME_T_MIN, TIME_T_MAX): New macros.
1655 (time_overflow): Move earlier, to before first use.
1656 (hi_time, lo_time): New functions, for an accurate test for
1657 out-of-range times.
1658 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1659 (Fget_internal_run_time): Don't assume time_t fits in int.
1660 (make_time): Use list2 instead of Fcons twice.
1661 (Fdecode_time): More accurate test for out-of-range times.
1662 (check_tm_member): New function.
1663 (Fencode_time): Use it, to test for out-of-range times.
1664 (lisp_time_argument): Don't rely on undefined left-shift and
1665 right-shift behavior when checking for time stamp overflow.
1666
1667 * editfns.c (time_overflow): New function, refactoring common code.
1668 (Fformat_time_string, Fdecode_time, Fencode_time):
1669 (Fcurrent_time_string): Use it.
1670
1671 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1672 * dired.c (make_time): Move to ...
1673 * editfns.c (make_time): ... here.
1674 * systime.h: Note the move.
1675
1676 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1677
1678 * fringe.c (update_window_fringes): Remove unused variables.
1679
1680 * unexmacosx.c (copy_data_segment): Also copy __got section.
1681 (Bug#8223)
1682
1683 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1684
1685 * termcap.c [MSDOS]: Include "msdos.h".
1686 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1687 Constify `char *' arguments and their references according to
1688 prototypes in tparam.h.
1689
1690 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1691
1692 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1693 Adapt all references accordingly.
1694
1695 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1696
1697 2011-03-11 Tom Tromey <tromey@redhat.com>
1698
1699 * buffer.c (syms_of_buffer): Remove obsolete comment.
1700
1701 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1702
1703 * termhooks.h (encode_terminal_code): Declare prototype.
1704
1705 * msdos.c (encode_terminal_code): Don't declare prototype.
1706
1707 * term.c (encode_terminal_code): Now external again, used by
1708 w32console.c and msdos.c.
1709
1710 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1711 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1712
1713 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1714
1715 Fix some minor problems found by GCC 4.5.2's static checks.
1716
1717 * fringe.c (update_window_fringes): Mark locals as initialized
1718 (Bug#8227).
1719 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1720
1721 * alloc.c (mark_fringe_data): Move decl from here ...
1722 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1723 to check its interface.
1724 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1725
1726 * fontset.c (free_realized_fontset): Now static.
1727 (Fset_fontset_font): Rename local to avoid shadowing.
1728 (fontset_font): Mark local as initialized.
1729 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1730
1731 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1732
1733 * xselect.c (x_disown_buffer_selections): Remove; not used.
1734 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1735 (x_own_selection, Fx_disown_selection_internal): Rename locals
1736 to avoid shadowing.
1737 (x_handle_dnd_message): Remove local to avoid shadowing.
1738
1739 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1740 so that the caller can use some name other than gcpro1.
1741 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1742 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1743 (Fx_backspace_delete_keys_p):
1744 Use them to avoid shadowing, and rename vars to avoid shadowing.
1745 (x_decode_color, x_set_name, x_window): Now static.
1746 (Fx_create_frame): Add braces to silence GCC warning.
1747 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1748 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1749 Remove unused locals.
1750 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1751 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1752 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1753 macros.
1754
1755 * xterm.h (x_mouse_leave): New decl.
1756
1757 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1758 Remove unused functions.
1759 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1760 (x_calc_absolute_position): Now static.
1761 (XTread_socket): Don't define label "out" unless it's used.
1762 Don't declare local "event" unless it's used.
1763 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1764 unless they are used.
1765 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1766 (x_fatal_error_signal): Remove; not used.
1767 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1768 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1769 (x_error_catcher, x_connection_closed, x_error_handler):
1770 (x_error_quitter, xembed_send_message, x_iconify_frame):
1771 (my_log_handler): Rename locals to avoid shadowing.
1772 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1773 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1774
1775 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1776 Rename or move locals to avoid shadowing.
1777 (tty_defined_color, merge_face_heights): Now static.
1778 (free_realized_faces_for_fontset): Remove; not used.
1779 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1780 does not deduce is never used uninitialized.
1781 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1782 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1783
1784 * terminal.c (store_terminal_param): Now static.
1785
1786 * xmenu.c (menu_highlight_callback): Now static.
1787 (set_frame_menubar): Remove unused local.
1788 (xmenu_show): Rename parameter to avoid shadowing.
1789 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1790 since they might point to immutable storage.
1791 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1792 since it's unused otherwise.
1793
1794 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1795 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1796 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1797 avoids a gcc -Wuninitialized diagnostic.
1798 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1799 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1800 does not deduce are never used uninitialized.
1801
1802 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1803
1804 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1805 * window.c (window_loop, size_window):
1806 (run_window_configuration_change_hook, enlarge_window): Likewise.
1807
1808 * window.c (display_buffer): Now static.
1809 (size_window): Mark variables that gcc -Wuninitialized
1810 does not deduce are never used uninitialized.
1811 * window.h (check_all_windows): New decl, to forestall
1812 gcc -Wmissing-prototypes diagnostic.
1813 * dispextern.h (bidi_dump_cached_states): Likewise.
1814
1815 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1816 shadowing.
1817 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1818 Include <limits.h>.
1819 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1820 and to avoid gcc -Wuninitialized warning.
1821 (load_charset_map): Mark variables that gcc -Wuninitialized
1822 does not deduce are never used uninitialized.
1823 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1824
1825 * coding.c (coding_set_source, coding_set_destination):
1826 Use "else { /* comment */ }" rather than "else /* comment */;"
1827 for clarity, and to avoid gcc -Wempty-body warning.
1828 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1829 a block, when the outer 'i' will do.
1830 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1831 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1832 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1833 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1834 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1835 Rename locals to avoid shadowing.
1836 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1837 * coding.c (emacs_mule_char, encode_invocation_designation):
1838 Now static, since they're not used elsewhere.
1839 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1840 (decode_coding_object, encode_coding_object, detect_coding_system):
1841 (decode_coding_emacs_mule): Mark variables that gcc
1842 -Wuninitialized does not deduce are never used uninitialized.
1843 (detect_coding_iso_2022): Initialize a local variable that might
1844 be used uninitialized. Leave a FIXME because it's not clear that
1845 this initialization is needed. (Bug#8211)
1846 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1847 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1848 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1849 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1850 Remove unused macros.
1851
1852 * category.c (hash_get_category_set): Remove unused local var.
1853 (copy_category_table): Now static, since it's not used elsewhere.
1854 * character.c (string_count_byte8): Likewise.
1855
1856 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1857 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1858
1859 * chartab.c (copy_sub_char_table): Now static, since it's not used
1860 elsewhere.
1861 (sub_char_table_ref_and_range, char_table_ref_and_range):
1862 Rename locals to avoid shadowing.
1863 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1864
1865 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1866 (BIDI_BOB): Remove unused macro.
1867
1868 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1869 deduce are never used uninitialized.
1870 * term.c (encode_terminal_code): Likewise.
1871
1872 * term.c (encode_terminal_code): Now static. Remove unused local.
1873
1874 * tparam.h: New file.
1875 * term.c, tparam.h: Include it.
1876 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1877 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1878 Move these decls to tparam.h, and make them agree with what
1879 is actually in tparam.c. The previous trick of using incompatible
1880 decls in different modules does not conform to the C standard.
1881 All callers of tparam changed to use tparam's actual API.
1882 * tparam.c (tparam1, tparam, tgoto):
1883 Use const pointers where appropriate.
1884
1885 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1886 * cm.h (struct cm): Likewise.
1887 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1888 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1889 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1890 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1891 (turn_on_face, init_tty): Likewise.
1892 * termchar.h (struct tty_display_info): Likewise.
1893
1894 * term.c (term_mouse_position): Rename local to avoid shadowing.
1895
1896 * alloc.c (mark_ttys): Move decl from here ...
1897 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1898
1899 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1900
1901 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1902
1903 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1904
1905 * search.c (compile_pattern_1): Remove argument regp, unused since
1906 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1907 (compile_pattern): Don't pass it.
1908
1909 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1910
1911 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1912 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1913 for ! HAVE_GTK3.
1914 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1915
1916 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1917
1918 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1919 gdk_window_get_screen, gdk_window_get_geometry,
1920 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1921 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1922 (xg_get_pixbuf_from_pixmap): New function.
1923 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1924 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1925 Call xg_get_pixbuf_from_pixmap instead of
1926 gdk_pixbuf_get_from_drawable.
1927 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1928 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1929 (xg_check_special_colors): Use GtkStyleContext and its functions
1930 for HAVE_GTK3.
1931 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1932 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1933 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1934 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1935 Call gtk_widget_get_preferred_size.
1936 (xg_frame_resized): gdk_window_get_geometry only takes 5
1937 parameters.
1938 (xg_win_to_widget, xg_event_is_for_menubar):
1939 Call gdk_x11_window_lookup_for_display.
1940 (xg_set_widget_bg): New function.
1941 (delete_cb): New function.
1942 (xg_create_frame_widgets): connect delete-event to delete_cb.
1943 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1944 (xg_set_background_color): Call xg_set_widget_bg.
1945 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1946 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1947 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1948 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1949 if ! HAVE_GTK3.
1950 (update_frame_tool_bar): Call gtk_widget_hide.
1951 (xg_initialize): Use GDK_KEY_g.
1952
1953 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1954 if ! HAVE_GTK3
1955 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1956
1957 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1958 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1959 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1960
1961 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
1962
1963 * w32xfns.c (select_palette): Check success of RealizePalette against
1964 GDI_ERROR, not zero.
1965
1966 See ChangeLog.11 for earlier changes.
1967
1968 ;; Local Variables:
1969 ;; coding: utf-8
1970 ;; End:
1971
1972 Copyright (C) 2011 Free Software Foundation, Inc.
1973
1974 This file is part of GNU Emacs.
1975
1976 GNU Emacs is free software: you can redistribute it and/or modify
1977 it under the terms of the GNU General Public License as published by
1978 the Free Software Foundation, either version 3 of the License, or
1979 (at your option) any later version.
1980
1981 GNU Emacs is distributed in the hope that it will be useful,
1982 but WITHOUT ANY WARRANTY; without even the implied warranty of
1983 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1984 GNU General Public License for more details.
1985
1986 You should have received a copy of the GNU General Public License
1987 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.