* buffer.h: Include <time.h>, for time_t.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2
3 * buffer.h: Include <time.h>, for time_t.
4 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5
6 Fix minor problems found by static checking.
7
8 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9
10 Make identifiers static if they are not used in other modules.
11 * data.c (Qcompiled_function, Qframe, Qvector):
12 * image.c (QimageMagick, Qsvg):
13 * minibuf.c (Qmetadata):
14 * window.c (resize_window_check, resize_root_window): Now static.
15 * window.h (resize_window_check, resize_root_window): Remove decls.
16
17 * window.c (window_deletion_count, delete_deletable_window):
18 Remove; unused.
19 (window_body_lines): Now static.
20 (Fdelete_other_windows_internal): Mark vars as initialized.
21 Make sure 'resize_failed' is initialized.
22 (run_window_configuration_change_hook): Rename local to avoid shadowing.
23 (resize_window_apply): Remove unused local.
24 * window.h (delete_deletable_window): Remove decl.
25
26 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
27 (imagemagick_load_image): Fix pointer signedness problem by changing
28 last arg from unsigned char * to char *. All uses changed.
29 Also, fix a local for similar reasons.
30 Remove unused locals. Remove locals to avoid shadowing.
31 (fn_rsvg_handle_free): Remove; unused.
32 (svg_load, svg_load_image): Fix pointer signedness problem.
33 (imagemagick_load_image): Don't use garbage pointer image_wand.
34
35 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
36
37 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
38
39 * image.c (gif_load): Fix omitted cast error introduced by
40 2011-06-06 change.
41
42 2011-06-10 Martin Rudalics <rudalics@gmx.at>
43
44 * window.h (resize_proportionally, orig_total_lines)
45 (orig_top_line): Remove from window structure.
46 (set_window_height, set_window_width, change_window_heights)
47 (Fdelete_window): Remove prototypes.
48 (resize_frame_windows): Remove duplicate declaration.
49
50 2011-06-10 Eli Zaretskii <eliz@gnu.org>
51
52 * window.h (resize_frame_windows, resize_window_check)
53 (delete_deletable_window, resize_root_window)
54 (resize_frame_windows): Declare prototypes.
55
56 * window.c (resize_window_apply): Make definition be "static" to
57 match the prototype.
58
59 2011-06-10 Martin Rudalics <rudalics@gmx.at>
60
61 * window.c: Remove declarations of Qwindow_size_fixed,
62 window_min_size_1, window_min_size_2, window_min_size,
63 size_window, window_fixed_size_p, enlarge_window, delete_window.
64 Remove static from declaration of Qdelete_window, it's
65 temporarily needed by Fbury_buffer.
66 (replace_window): Don't assign orig_top_line and
67 orig_total_lines.
68 (Fdelete_window, delete_window): Remove. Window deletion is
69 handled by window.el.
70 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
71 Fdelete_window calls with calls to Qdelete_window.
72 (Fdelete_other_windows): Remove. Deleting other windows is
73 handled by window.el.
74 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
75 handled in window.el.
76 (window_min_size_2, window_min_size_1, window_min_size): Remove.
77 Window minimum sizes are handled in window.el.
78 (shrink_windows, size_window, set_window_height)
79 (set_window_width, change_window_heights, window_height)
80 (window_width, CURBEG, CURSIZE, enlarge_window)
81 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
82 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
83 handled in window.el.
84 (make_dummy_parent): Rename to make_parent_window and give it a
85 second argument horflag.
86 (make_window): Don't set resize_proportionally any more.
87 (Fsplit_window): Remove. Windows are split in window.el.
88 (save_restore_action, save_restore_orig_size)
89 (shrink_window_lowest_first, save_restore_orig_size): Remove.
90 Resize mini windows in window.el.
91 (grow_mini_window, shrink_mini_window): Implement by calling
92 Qresize_root_window_vertically, resize_window_check and
93 resize_window_apply.
94 (saved_window, Fset_window_configuration, save_window_save): Do
95 not handle orig_top_line, orig_total_lines, and
96 resize_proportionally.
97 (window_min_height, window_min_width): Move to window.el.
98 (keys_of_window): Move bindings for delete-other-windows,
99 split-window, delete-window and enlarge-window to window.el.
100
101 * buffer.c: Temporarily extern Qdelete_window.
102 (Fbury_buffer): Temporarily call Qdelete_window instead of
103 Fdelete_window (Fbury_buffer will move to window.el soon).
104
105 * frame.c (set_menu_bar_lines_1): Remove code handling
106 orig_top_line and orig_total_lines.
107
108 * dispnew.c (adjust_frame_glyphs_initially): Don't use
109 set_window_height but set heights directly.
110 (change_frame_size_1): Use resize_frame_windows.
111
112 * xdisp.c (init_xdisp): Don't use set_window_height but set
113 heights directly.
114
115 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
116 resize_frame_windows instead of change_window_heights and run
117 run_window_configuration_change_hook.
118
119 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
120 instead of change_window_heights and run
121 run_window_configuration_change_hook.
122
123 2011-06-09 Martin Rudalics <rudalics@gmx.at>
124
125 * window.c (replace_window): Rename second argument REPLACEMENT to
126 NEW. New third argument SETFLAG. Rewrite.
127 (delete_window, make_dummy_parent): Call replace_window with
128 third argument 1.
129 (window_list_1): Move down in code.
130 (run_window_configuration_change_hook): Move set_buffer part
131 before select_frame_norecord part in order to unwind correctly.
132 Rename count1 to count.
133 (recombine_windows, delete_deletable_window, resize_root_window)
134 (Fdelete_other_windows_internal)
135 (Frun_window_configuration_change_hook, make_parent_window)
136 (resize_window_check, resize_window_apply, Fresize_window_apply)
137 (resize_frame_windows, Fsplit_window_internal)
138 (Fdelete_window_internal, Fresize_mini_window_internal): New
139 functions.
140 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
141
142 2011-06-08 Martin Rudalics <rudalics@gmx.at>
143
144 * window.h (window): Add some new members to window structure -
145 normal_lines, normal_cols, new_total, new_normal, clone_number,
146 splits, nest, prev_buffers, next_buffers.
147 (WINDOW_TOTAL_SIZE): Move here from window.c.
148 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
149
150 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
151 Remove.
152 (make_dummy_parent): Set new members of windows structure.
153 (make_window): Move down in code. Handle new members of window
154 structure.
155 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
156 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
157 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
158 (Fset_window_prev_buffers, Fwindow_next_buffers)
159 (Fset_window_next_buffers, Fset_window_clone_number): New
160 functions.
161 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
162 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
163 Doc-string fixes.
164 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
165 Argument WINDOW can be now internal window too.
166 (Fwindow_use_time): Move up in code.
167 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
168 Rewrite doc-string.
169 (Fset_window_configuration, saved_window)
170 (Fcurrent_window_configuration, save_window_save): Handle new
171 members of window structure.
172 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
173 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
174 (syms_of_window): New Lisp objects Qrecord_window_buffer,
175 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
176 Qget_mru_window, Qresize_root_window,
177 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
178 Qauto_buffer_name; staticpro them.
179
180 2011-06-07 Martin Rudalics <rudalics@gmx.at>
181
182 * window.c (Fwindow_total_size, Fwindow_left_column)
183 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
184 (Fwindow_list_1): New functions.
185 (window_box_text_cols): Replace with window_body_cols.
186 (Fwindow_width, Fscroll_left, Fscroll_right): Use
187 window_body_cols instead of window_box_text_cols.
188 (delete_window, Fset_window_configuration): Call
189 delete_all_subwindows with window as argument.
190 (delete_all_subwindows): Take a window as argument and not a
191 structure. Rewrite.
192 (window_loop): Remove handling of GET_LRU_WINDOW and
193 GET_LARGEST_WINDOW.
194 (Fget_lru_window, Fget_largest_window): Move to window.el.
195
196 * window.h: Extern window_body_cols instead of
197 window_box_text_cols. delete_all_subwindows now takes a
198 Lisp_Object as argument.
199
200 * indent.c (compute_motion, Fcompute_motion): Use
201 window_body_cols instead of window_box_text_cols.
202
203 * frame.c (delete_frame): Call delete_all_subwindows with root
204 window as argument.
205
206 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
207
208 * fns.c (Fputhash): Document return value.
209
210 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
211
212 * image.c (gif_load): Implement gif89a spec "no disposal" method.
213
214 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
215
216 Cons<->int and similar integer overflow fixes (Bug#8794).
217
218 Check for overflow when converting integer to cons and back.
219 * charset.c (Fdefine_charset_internal, Fdecode_char):
220 Use cons_to_unsigned to catch overflow.
221 (Fencode_char): Use INTEGER_TO_CONS.
222 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
223 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
224 * data.c (long_to_cons, cons_to_long): Remove.
225 (cons_to_unsigned, cons_to_signed): New functions.
226 These signal an error for invalid or out-of-range values.
227 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
228 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
229 * font.c (Ffont_variation_glyphs):
230 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
231 * lisp.h: Include <intprops.h>.
232 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
233 (cons_to_signed, cons_to_unsigned): New decls.
234 (long_to_cons, cons_to_long): Remove decls.
235 * undo.c (record_first_change): Use INTEGER_TO_CONS.
236 (Fprimitive_undo): Use CONS_TO_INTEGER.
237 * xfns.c (Fx_window_property): Likewise.
238 * xselect.c: Include <limits.h>.
239 (x_own_selection, selection_data_to_lisp_data):
240 Use INTEGER_TO_CONS.
241 (x_handle_selection_request, x_handle_selection_clear)
242 (x_get_foreign_selection, Fx_disown_selection_internal)
243 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
244 (lisp_data_to_selection_data): Use cons_to_unsigned.
245 (x_fill_property_data): Use cons_to_signed.
246 Report values out of range.
247
248 Check for buffer and string overflow more precisely.
249 * buffer.h (BUF_BYTES_MAX): New macro.
250 * lisp.h (STRING_BYTES_MAX): New macro.
251 * alloc.c (Fmake_string):
252 * character.c (string_escape_byte8):
253 * coding.c (coding_alloc_by_realloc):
254 * doprnt.c (doprnt):
255 * editfns.c (Fformat):
256 * eval.c (verror):
257 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
258 since they may not be the same number.
259 * editfns.c (Finsert_char):
260 * fileio.c (Finsert_file_contents):
261 Likewise for BUF_BYTES_MAX.
262
263 * image.c: Use ptrdiff_t, not int, for sizes.
264 (slurp_file): Switch from int to ptrdiff_t.
265 All uses changed.
266 (slurp_file): Check that file size fits in both size_t (for
267 malloc) and ptrdiff_t (for sanity and safety).
268
269 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
270 if b->modtime has its maximal value.
271
272 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
273
274 Don't assume time_t can fit into int.
275 * buffer.h (struct buffer.modtime): Now time_t, not int.
276 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
277 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
278
279 Minor fixes for signed vs unsigned integers.
280 * character.h (MAYBE_UNIFY_CHAR):
281 * charset.c (maybe_unify_char):
282 * keyboard.c (read_char, reorder_modifiers):
283 XINT -> XFASTINT, since the integer must be nonnegative.
284 * ftfont.c (ftfont_spec_pattern):
285 * keymap.c (access_keymap, silly_event_symbol_error):
286 XUINT -> XFASTINT, since the integer must be nonnegative.
287 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
288 since it makes no difference and we prefer signed.
289 * keyboard.c (record_char): Use XUINT when all the neighbors do.
290 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
291 nonnegative.
292
293 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
294
295 * window.h (Fwindow_frame): Declare.
296
297 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
298
299 * alloc.c: Simplify handling of large-request failures (Bug#8800).
300 (SPARE_MEMORY): Always define.
301 (LARGE_REQUEST): Remove.
302 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
303
304 2011-06-06 Martin Rudalics <rudalics@gmx.at>
305
306 * lisp.h: Move EXFUNS for Fframe_root_window,
307 Fframe_first_window and Fset_frame_selected_window to window.h.
308
309 * window.h: Move EXFUNS for Fframe_root_window,
310 Fframe_first_window and Fset_frame_selected_window here from
311 lisp.h.
312
313 * frame.c (Fwindow_frame, Fframe_first_window)
314 (Fframe_root_window, Fframe_selected_window)
315 (Fset_frame_selected_window): Move to window.c.
316 (Factive_minibuffer_window): Move to minibuf.c.
317 (Fother_visible_frames_p): New function.
318
319 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
320
321 * window.c (decode_window, decode_any_window): Move up in code.
322 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
323 (inhibit_frame_unsplittable): Remove unused variable.
324 (Fwindow_buffer): Move up and rewrite doc-string.
325 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
326 (Fwindow_prev): New functions.
327 (Fwindow_frame): Move here from frame.c. Accept any window as
328 argument.
329 (Fframe_root_window, Fframe_first_window)
330 (Fframe_selected_window): Move here from frame.c. Accept frame
331 or arbitrary window as argument. Update doc-strings.
332 (Fminibuffer_window): Move up in code.
333 (Fwindow_minibuffer_p): Move up in code and simplify.
334 (Fset_frame_selected_window): Move here from frame.c.
335 Marginal rewrite.
336 (Fselected_window, select_window, Fselect_window): Move up in
337 code. Minor doc-string fixes.
338
339 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
340
341 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
342 Do not assume that spare memory exists; that assumption is valid
343 only if SYSTEM_MALLOC.
344 (LARGE_REQUEST): New macro, so that the issue of large requests
345 is separated from the issue of spare memory.
346
347 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
348
349 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
350 format. (Bug#8806)
351
352 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
353
354 * xfns.c (x_set_scroll_bar_default_width): Move declarations
355 before statements.
356
357 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
358
359 * gtkutil.c (xg_get_default_scrollbar_width): New function.
360
361 * gtkutil.h: Declare xg_get_default_scrollbar_width.
362
363 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
364 min width by calling x_set_scroll_bar_default_width (Bug#8505).
365
366 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
367
368 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
369
370 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
371
372 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
373 (x_clipboard_manager_save): Add return value.
374 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
375 New error handlers.
376 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
377 Obey Vx_select_enable_clipboard_manager. Catch errors in
378 x_clipboard_manager_save (Bug#8779).
379 (Vx_select_enable_clipboard_manager): New variable.
380 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
381
382 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
383
384 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
385
386 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
387
388 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
389 in the current matrix if keep_current_p is non-zero.
390
391 2011-06-04 Eli Zaretskii <eliz@gnu.org>
392
393 * bidi.c (bidi_level_of_next_char): Fix last change.
394
395 2011-06-03 Eli Zaretskii <eliz@gnu.org>
396
397 Support bidi reordering of text covered by display properties.
398
399 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
400 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
401 (bidi_cache_search, bidi_cache_iterator_state)
402 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
403 (bidi_level_of_next_char, bidi_move_to_visually_next):
404 Support character positions inside a run of characters covered by a
405 display string.
406 (bidi_paragraph_init, bidi_resolve_explicit_1)
407 (bidi_level_of_next_char): Call bidi_fetch_char and
408 bidi_fetch_char_advance instead of FETCH_CHAR and
409 FETCH_CHAR_ADVANCE.
410 (bidi_init_it): Initialize new members.
411 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
412 definitions.
413 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
414 instead of using explicit *_CHAR codes.
415 (bidi_resolve_explicit, bidi_resolve_weak):
416 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
417 bidirectional text is supported only in multibyte buffers.
418 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
419 it to initialize the frame_window_p member of struct bidi_it.
420 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
421 (bidi_resolve_explicit, bidi_resolve_weak)
422 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
423 bidi_it->nchars is non-positive.
424 (bidi_level_of_next_char): Don't try to lookup the cache for the
425 next/previous character if nothing is cached there yet, or if we
426 were just reseat()'ed to a new position.
427
428 * xdisp.c (set_cursor_from_row): Set start and stop points
429 according to the row's direction when priming the loop that looks
430 for the glyph on which to display cursor.
431 (single_display_spec_intangible_p): Function deleted.
432 (display_prop_intangible_p): Reimplement to call
433 handle_display_spec instead of single_display_spec_intangible_p.
434 Accept 3 additional arguments needed by handle_display_spec.
435 This fixes incorrect cursor motion across display property with complex
436 values: lists, `(when COND...)' forms, etc.
437 (single_display_spec_string_p): Support property values that are
438 lists with the argument STRING its top-level element.
439 (display_prop_string_p): Fix the condition for processing a
440 property that is a list to be consistent with handle_display_spec.
441 (handle_display_spec): New function, refactored from the
442 last portion of handle_display_prop.
443 (compute_display_string_pos): Accept additional argument
444 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
445 value of a `display' property is a "replacing spec".
446 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
447 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
448 the display property, but just return a value indicating whether
449 the display property will replace the characters it covers.
450 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
451 frame_window_p members of struct bidi_it.
452 (compute_display_string_pos, compute_display_string_end):
453 New functions.
454 (push_it): Accept second argument POSITION, where pop_it should
455 jump to continue iteration.
456 (reseat_1): Initialize bidi_it.disp_pos.
457
458 * keyboard.c (adjust_point_for_property): Adjust the call to
459 display_prop_intangible_p to its new signature.
460
461 * dispextern.h (struct bidi_it): New member frame_window_p.
462 (bidi_init_it): Update prototypes.
463 (display_prop_intangible_p): Update prototype.
464 (compute_display_string_pos, compute_display_string_end):
465 Declare prototypes.
466 (struct bidi_it): New members nchars and disp_pos. ch_len is now
467 EMACS_INT.
468
469 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
470
471 Malloc failure behavior now depends on size of allocation.
472 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
473 * lisp.h: Change signatures accordingly.
474 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
475 All callers changed. (Bug#8762)
476
477 * gnutls.c: Use Emacs's memory allocators.
478 Without this change, the gnutls library would invoke malloc etc.
479 directly, which causes problems on non-SYNC_INPUT hosts, and which
480 runs afoul of improving memory_full behavior. (Bug#8761)
481 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
482 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
483 xfree instead of the default malloc, realloc, free.
484 (Fgnutls_boot): No need to check for memory allocation failure,
485 since xmalloc does that for us.
486
487 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
488 * category.c (hash_get_category_set):
489 * ccl.c (ccl_driver):
490 * charset.c (Fdefine_charset_internal):
491 * charset.h (struct charset.hash_index):
492 * composite.c (get_composition_id, gstring_lookup_cache)
493 (composition_gstring_put_cache):
494 * composite.h (struct composition.hash_index):
495 * dispextern.h (struct image.hash):
496 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
497 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
498 (hashfn_equal, hashfn_user_defined, make_hash_table)
499 (maybe_resize_hash_table, hash_lookup, hash_put)
500 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
501 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
502 (Fsxhash, Fgethash, Fputhash, Fmaphash):
503 * image.c (make_image, search_image_cache, lookup_image)
504 (xpm_put_color_table_h):
505 * lisp.h (struct Lisp_Hash_Table):
506 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
507 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
508 for hashes and hash indexes, instead of 'unsigned' and 'int'.
509 * alloc.c (allocate_vectorlike):
510 Check for overflow in vector size calculations.
511 * ccl.c (ccl_driver):
512 Check for overflow when converting EMACS_INT to int.
513 * fns.c, image.c: Remove unnecessary static decls that would otherwise
514 need to be updated by these changes.
515 * fns.c (make_hash_table, maybe_resize_hash_table):
516 Check for integer overflow with large hash tables.
517 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
518 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
519 (SXHASH_REDUCE): New macro.
520 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
521 Use it instead of discarding useful hash info with large hash values.
522 (sxhash_float): New function.
523 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
524 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
525 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
526 Rewrite to use FIXNUM_BITS, as this simplifies things.
527 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
528 Adjust signatures to match updated version of code.
529 (consing_since_gc): Now EMACS_INT, since a single hash table can
530 use more than INT_MAX bytes.
531
532 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
533
534 Make it possible to build with GCC-4.6+ -O2 -flto.
535
536 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
537
538 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
539
540 * minibuf.c (get_minibuffer, read_minibuf_unwind):
541 Call minibuffer-inactive-mode.
542
543 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
544
545 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
546 Update dependencies.
547
548 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
549
550 * data.c (init_data): Remove code for UTS, this system is not
551 supported anymore.
552
553 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
554
555 Don't force ./temacs to start in terminal mode.
556
557 * frame.c (make_initial_frame): Initialize faces in all cases, not
558 only when CANNOT_DUMP is defined.
559 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
560
561 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
562
563 * dispnew.c (add_window_display_history): Use const for the string
564 pointer. Remove declaration, not needed.
565
566 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
567
568 Use 'inline', not 'INLINE'.
569 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
570 * alloc.c, fontset.c (INLINE): Remove.
571 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
572 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
573 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
574 * gmalloc.c (register_heapinfo): Use inline unconditionally.
575 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
576
577 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
578
579 Make it possible to run ./temacs.
580
581 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
582 syms_of_callproc does the same thing. Remove test for
583 "initialized", do it in the caller.
584 * emacs.c (main): Avoid calling set_initial_environment when dumping.
585
586 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
587
588 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
589 (read_minibuf): Use get_minibuffer.
590 (syms_of_minibuf): Use DEFSYM.
591 (Qmetadata): New var.
592 * data.c (Qbuffer): Don't make it static.
593 (syms_of_data): Use DEFSYM.
594
595 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
596
597 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
598 (CCL_CODE_MIN): New macro.
599
600 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
601
602 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
603
604 * eval.c (Qdebug): Now static.
605 * lisp.h (Qdebug): Remove decl. This reverts a part of the
606 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
607 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
608
609 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
610
611 * image.c: Various fixes to ImageMagick code comments.
612 (Fimagemagick_types): Doc fix.
613
614 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
615
616 Minor fixes prompted by GCC 4.6.0 warnings.
617
618 * xselect.c (converted_selections, conversion_fail_tag): Now static.
619
620 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
621 (x_clipboard_manager_save_all): Move extern decl to ...
622 * xterm.h: ... here, so that it can be checked for consistency.
623
624 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
625
626 * xselect.c (x_clipboard_manager_save_frame)
627 (x_clipboard_manager_save_all): New functions.
628 (Fx_clipboard_manager_save): Lisp function deleted.
629
630 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
631 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
632
633 * xterm.h: Update prototype.
634
635 2011-05-28 William Xu <william.xwl@gmail.com>
636
637 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
638 exiting (Bug#8239).
639
640 2011-05-28 Jim Meyering <meyering@redhat.com>
641
642 Avoid a sign-extension bug in crypto_hash_function.
643 * fns.c (to_uchar): Define.
644 (crypto_hash_function): Use it to convert some newly-signed
645 variables to unsigned, to avoid sign-extension bugs. For example,
646 without this change, (md5 "truc") would evaluate to
647 45723a2aff78ff4fff7fff1114760e62 rather than the expected
648 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
649 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
650
651 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
652
653 Integer overflow fixes.
654
655 * dbusbind.c: Serial number integer overflow fixes.
656 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
657 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
658 to hold a serial number that is too large for a fixnum.
659 (Fdbus_method_return_internal, Fdbus_method_error_internal):
660 Check for serial numbers out of range. Decode any serial number
661 that was so large that it became a float. (Bug#8722)
662
663 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
664 (Fdbus_call_method, Fdbus_call_method_asynchronously):
665 Use XFASTINT rather than XUINT when numbers are nonnegative.
666 (xd_append_arg, Fdbus_method_return_internal):
667 (Fdbus_method_error_internal): Likewise. Also, for unsigned
668 arguments, check that Lisp number is nonnegative, rather than
669 silently wrapping negative numbers around. (Bug#8722)
670 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
671 (Bug#8722)
672
673 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
674
675 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
676
677 ccl: add integer overflow checks
678 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
679 (IN_INT_RANGE): New macros.
680 (ccl_driver): Use them to check for integer overflow when
681 decoding a CCL program. Many of the new checks are whether XINT (x)
682 fits in int; it doesn't always, on 64-bit hosts. The new version
683 doesn't catch all possible integer overflows, but it's an
684 improvement. (Bug#8719)
685
686 * alloc.c (make_event_array): Use XINT, not XUINT.
687 There's no need for unsigned here.
688
689 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
690 This follows up to the 2011-05-06 change that substituted uintptr_t
691 for EMACS_INT. This case wasn't caught back then.
692
693 Rework Fformat to avoid integer overflow issues.
694 * editfns.c: Include <float.h> unconditionally, as it's everywhere
695 now (part of C89). Include <verify.h>.
696 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
697 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
698 (Fformat): Avoid the prepass trying to compute sizes; it was only
699 approximate and thus did not catch overflow reliably. Instead, walk
700 through the format just once, formatting and computing sizes as we go,
701 checking for integer overflow at every step, and allocating a larger
702 buffer as needed. Keep track separately whether the format is
703 multibyte. Keep only the most-recently calculated precision, rather
704 than them all. Record whether each argument has been converted to
705 string. Use EMACS_INT, not int, for byte and char and arg counts.
706 Support field widths and precisions larger than INT_MAX. Avoid
707 sprintf's undefined behavior with conversion specifications such as %#d
708 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
709 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
710 formatting out-of-range floating point numbers with int
711 formats. (Bug#8668)
712
713 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
714
715 * data.c: Avoid integer truncation in expressions involving floats.
716 * data.c: Include <intprops.h>.
717 (arith_driver): When there's an integer overflow in an expression
718 involving floating point, convert the integers to floating point
719 so that the resulting value does not suffer from catastrophic
720 integer truncation. For example, on a 64-bit host (* 4
721 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
722 Do not rely on undefined behavior after integer overflow.
723
724 merge count_size_as_multibyte, parse_str_to_multibyte
725 * character.c, character.h (count_size_as_multibyte):
726 Rename from parse_str_to_multibyte; all uses changed.
727 Check for integer overflow.
728 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
729 since it's now a duplicate of the other. This is more of
730 a character than a buffer op, so better that it's in character.c.
731 * fns.c, print.c: Adjust to above changes.
732
733 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
734
735 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
736
737 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
738
739 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
740 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
741 (x_clipboard_manager_save): Now static.
742 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
743
744 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
745 (crypto_hash_function): Now static.
746 Fix pointer signedness problems. Avoid unnecessary initializations.
747
748 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
749
750 * termhooks.h (Vselection_alist): Make it terminal-local.
751
752 * terminal.c (create_terminal): Initialize it.
753
754 * xselect.c: Support for clipboard managers.
755 (Vselection_alist): Move to termhooks.h as terminal-local var.
756 (LOCAL_SELECTION): New macro.
757 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
758 (symbol_to_x_atom): Remove gratuitous arg.
759 (x_handle_selection_request, lisp_data_to_selection_data)
760 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
761 (x_own_selection, x_get_local_selection, x_convert_selection):
762 New arg, specifying work frame. Use terminal-local Vselection_alist.
763 (some_frame_on_display): Delete unused function.
764 (Fx_own_selection_internal, Fx_get_selection_internal)
765 (Fx_disown_selection_internal, Fx_selection_owner_p)
766 (Fx_selection_exists_p): New optional frame arg.
767 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
768 (x_handle_selection_clear): Don't treat other terminals with the
769 same keyboard specially. Use the terminal-local Vselection_alist.
770 (x_clear_frame_selections): Use Frun_hook_with_args.
771
772 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
773
774 * xterm.h: Add support for those atoms.
775
776 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
777
778 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
779 (converted_selections, conversion_fail_tag): New global variables.
780 (x_selection_request_lisp_error): Free the above.
781 (x_get_local_selection): Remove unnecessary code.
782 (x_reply_selection_request): Args changed; handle arbitrary array
783 of converted selections stored in converted_selections.
784 Separate the XChangeProperty and SelectionNotify steps.
785 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
786 (x_convert_selection): New function.
787 (x_handle_selection_event): Simplify.
788 (x_get_foreign_selection): Don't ignore incoming requests while
789 waiting for an answer; this will fail when we implement
790 SAVE_TARGETS, and seems unnecessary anyway.
791 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
792 (Vx_sent_selection_functions): Doc fix.
793
794 2011-05-26 Leo Liu <sdl.web@gmail.com>
795
796 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
797
798 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
799
800 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
801
802 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
803 for fringe update if it has periodic bitmap.
804 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
805 and fringe_bitmap_periodic_p.
806
807 * fringe.c (get_fringe_bitmap_data): New function.
808 (draw_fringe_bitmap_1, update_window_fringes): Use it.
809 (update_window_fringes): Record periodicity of fringe bitmap in glyph
810 row. Mark glyph row for fringe update if periodicity changed.
811
812 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
813 for fringe update unless it has periodic bitmap.
814
815 2011-05-25 Kenichi Handa <handa@m17n.org>
816
817 * xdisp.c (get_next_display_element): Set correct it->face_id for
818 a static composition.
819
820 2011-05-24 Leo Liu <sdl.web@gmail.com>
821
822 * deps.mk (fns.o):
823 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
824
825 * fns.c (crypto_hash_function, Fsha1): New function.
826 (Fmd5): Use crypto_hash_function.
827 (syms_of_fns): Add Ssha1.
828
829 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
830
831 * gnutls.c: Remove unused macros.
832 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
833 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
834 Remove macros that are defined and never used.
835 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
836
837 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
838
839 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
840 (Fx_get_selection_internal): Minor cleanup.
841 (Fx_own_selection_internal): Rename arguments for consistency with
842 select.el.
843
844 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
845
846 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
847
848 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
849
850 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
851
852 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
853
854 * dispnew.c (scrolling_window): Don't exclude the case that the
855 last enabled row in the desired matrix touches the bottom boundary.
856
857 2011-05-21 Glenn Morris <rgm@gnu.org>
858
859 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
860 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
861 and add some more files.
862
863 2011-05-20 Eli Zaretskii <eliz@gnu.org>
864
865 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
866 report_file_error introduced by the change from 2011-05-07.
867
868 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
869
870 * systime.h (Time): Define only if emacs is defined.
871 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
872 where the include path doesn't have X11/X.h by default. See
873 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
874
875 2011-05-20 Kenichi Handa <handa@m17n.org>
876
877 * composite.c (find_automatic_composition): Fix previous change.
878
879 2011-05-20 Glenn Morris <rgm@gnu.org>
880
881 * lisp.mk: New file, split from Makefile.in.
882 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
883 (shortlisp): Remove.
884 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
885
886 2011-05-19 Glenn Morris <rgm@gnu.org>
887
888 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
889 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
890 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
891 (lisp): Set the order to that of loadup.el.
892 (shortlisp): Make it a copy of $lisp.
893 (SOME_MACHINE_LISP): Remove.
894 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
895 Use just $shortlisp, not $SOME_MACHINE_LISP too.
896
897 2011-05-18 Kenichi Handa <handa@m17n.org>
898
899 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
900 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
901 (find_automatic_composition): Mostly rewrite for efficiency.
902
903 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
904
905 * makefile.w32-in: Update dependencies.
906
907 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
908
909 * menu.c: Include limits.h (fixes the MS-Windows build broken by
910 revision 104625).
911
912 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
913
914 Fix some integer overflow issues, such as string length overflow.
915
916 * insdel.c (count_size_as_multibyte): Check for string overflow.
917
918 * character.c (lisp_string_width): Check for string overflow.
919 Use EMACS_INT, not int, for string indexes and lengths; in
920 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
921 the resulting string length overflows an EMACS_INT; instead,
922 report a string overflow if no precision given. When checking for
923 precision exhaustion, use a check that cannot possibly have
924 integer overflow. (Bug#8675)
925 * character.h (lisp_string_width): Adjust to new signature.
926
927 * alloc.c (string_overflow): New function.
928 (Fmake_string): Use it. This doesn't change behavior, but saves
929 a few bytes and will simplify future changes.
930 * character.c (string_escape_byte8): Likewise.
931 * lisp.h (string_overflow): New decl.
932
933 Fixups, following up to the user-interface timestamp change.
934 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
935 for UI timestamps, instead of unsigned long.
936 * msdos.c (mouse_get_pos): Likewise.
937 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
938 * w32gui.h (Time): Define by including "systime.h" rather than by
939 declaring it ourselves. (Bug#8664)
940
941 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
942 * image.c (clear_image_cache): Likewise.
943
944 * term.c (term_mouse_position): Don't assume time_t wraparound.
945
946 Be more systematic about user-interface timestamps.
947 Before, the code sometimes used 'Time', sometimes 'unsigned long',
948 and sometimes 'EMACS_UINT', to represent these timestamps.
949 This change causes it to use 'Time' uniformly, as that's what X uses.
950 This makes the code easier to follow, and makes it easier to catch
951 integer overflow bugs such as Bug#8664.
952 * frame.c (Fmouse_position, Fmouse_pixel_position):
953 Use Time, not unsigned long, for user-interface timestamps.
954 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
955 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
956 * keyboard.h (last_event_timestamp): Likewise.
957 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
958 * menu.h (xmenu_show): Likewise.
959 * term.c (term_mouse_position): Likewise.
960 * termhooks.h (struct input_event.timestamp): Likewise.
961 (struct terminal.mouse_position_hook): Likewise.
962 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
963 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
964 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
965 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
966 what it was before.
967 * menu.h, termhooks.h: Include "systime.h", for Time.
968
969 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
970 Don't assume that the difference between two unsigned long values
971 can fit into an integer. At this point, we know button_down_time
972 <= event->timestamp, so the difference must be nonnegative, so
973 there's no need to cast the result if double-click-time is
974 nonnegative, as it should be; check that it's nonnegative, just in
975 case. This bug is triggered when events are more than 2**31 ms
976 apart (about 25 days). (Bug#8664)
977
978 * xselect.c (last_event_timestamp): Remove duplicate decl.
979 (x_own_selection): Remove needless cast to unsigned long.
980
981 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
982 that always fit in int. Use a sentinel instead of a counter, to
983 avoid a temp and to allay GCC's concerns about possible int overflow.
984 * frame.h (struct frame): Use int for menu_bar_items_used
985 instead of EMACS_INT, since it always fits in int.
986
987 * menu.c (grow_menu_items): Check for int overflow.
988
989 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
990
991 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
992 Before, the code was not consistent. These values cannot exceed
993 2**31 - 1 so there's no need to make them unsigned.
994 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
995 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
996 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
997 as modifiers.
998 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
999
1000 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1001 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1002 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1003 presumably because the widths might not match.
1004
1005 * window.c (size_window): Avoid needless test at loop start.
1006
1007 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1008
1009 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1010
1011 2011-05-12 Drew Adams <drew.adams@oracle.com>
1012
1013 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1014
1015 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1016
1017 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1018 `width' to `bar_area_x' and `bar_area_width', respectively.
1019 (x_scroll_run): Take account of fringe background extension.
1020
1021 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1022 Rename local vars `left' and `width' to `bar_area_x' and
1023 `bar_area_width', respectively.
1024 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1025 background extension.
1026
1027 2011-05-10 Jim Meyering <meyering@redhat.com>
1028
1029 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1030
1031 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1032
1033 * image.c (Finit_image_library): Return t for built-in image types,
1034 like pbm and xbm. (Bug#8640)
1035
1036 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1037
1038 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1039
1040 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1041
1042 * w32console.c (Fset_screen_color): Doc fix.
1043 (Fget_screen_color): New function.
1044 (syms_of_ntterm): Defsubr it.
1045
1046 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1047 unlink the temporary file if Fcall_process didn't create it in the
1048 first place.
1049 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1050 child process will be redirected to a file specified with `:file'.
1051 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1052 cue to call_process_cleanup not to close that handle.
1053
1054 2011-05-07 Ben Key <bkey76@gmail.com>
1055
1056 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1057 one of two shell specific rules, either bootstrap-temacs-CMD or
1058 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1059 to the previous implementation of the bootstrap-temacs rule.
1060 The bootstrap-temacs-CMD rule is similar to the previous
1061 implementation of the bootstrap-temacs rule except that it
1062 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1063 variable.
1064
1065 These changes, along with some changes to nt/configure.bat,
1066 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1067 earlier fix to add support for --cflags and --ldflags options
1068 that include quotes so that it works whether make uses cmd or
1069 sh as the shell.
1070
1071 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1072
1073 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1074 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1075 is a constant.
1076 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1077 a string. Handle both cases.
1078 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1079 (Fdbus_register_method): Use Qinvalid_function.
1080
1081 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1082
1083 * makefile.w32-in: Update dependencies.
1084 (LISP_H): Add inttypes.h and stdin.h.
1085 (PROCESS_H): Add unistd.h.
1086
1087 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1088
1089 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1090 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1091
1092 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1093
1094 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1095
1096 * term.c (vfatal): Remove stray call to va_end.
1097 It's not needed and the C Standard doesn't allow it here anyway.
1098
1099 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1100 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1101
1102 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1103 bytes.
1104
1105 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1106
1107 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1108
1109 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1110
1111 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1112
1113 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1114
1115 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1116 * charset.c (Fdefine_charset_internal): Don't initialize
1117 charset.code_space[15]. The value was garbage, on hosts with
1118 32-bit int (Bug#8600).
1119
1120 * lread.c (read_integer): Be more consistent with string-to-number.
1121 Use string_to_number to do the actual conversion; this avoids
1122 rounding errors and fixes some other screwups. Without this fix,
1123 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1124 (digit_to_number): Move earlier, for benefit of read_integer.
1125 Return -1 if the digit is out of range for the base, -2 if it is
1126 not a digit in any supported base. (Bug#8602)
1127
1128 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1129
1130 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1131 to match comment at start of function. This also removes a
1132 GCC warning about overflow in a 32+64-bit port.
1133
1134 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1135
1136 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1137 Reported by Stefan Monnier in
1138 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1139 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1140 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1141
1142 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1143 (EMACS_UINTPTR): Likewise, with uintptr_t.
1144
1145 * lisp.h: Prefer 64-bit EMACS_INT if available.
1146 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1147 on 32-bit hosts that have 64-bit int, so that they can access
1148 large files.
1149 However, temporarily disable this change unless the temporary
1150 symbol WIDE_EMACS_INT is defined.
1151
1152 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1153
1154 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1155 This removes an assumption that EMACS_INT and long are the same
1156 width as pointers. The assumption is true for Emacs porting targets
1157 now, but we want to make other targets possible.
1158 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1159 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1160 In the rest of the code, change types of integers that hold casted
1161 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1162 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1163 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1164 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1165 No need to cast type when ORing.
1166 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1167 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1168 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1169 assume EMACS_INT is the same width as char *.
1170 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1171 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1172 Remove no-longer-needed casts.
1173 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1174 (xg_tool_bar_help_callback, xg_make_tool_item):
1175 Use EMACS_INTPTR to hold an integer
1176 that will be cast to void *; this can avoid a GCC warning
1177 if EMACS_INT is not the same width as void *.
1178 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1179 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1180 (current_message_1, set_message_1):
1181 Use a local to convert to proper width without a cast.
1182 * xmenu.c (dialog_selection_callback): Likewise.
1183
1184 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1185 Also, don't assume VALBITS / RAND_BITS is less than 5,
1186 and don't rely on undefined behavior when shifting a 1 left into
1187 the sign bit.
1188 * lisp.h (get_random): Change signature to match.
1189
1190 * lread.c (hash_string): Use size_t, not int, for hash computation.
1191 Normally we prefer signed values; but hashing is special, because
1192 it's better to use unsigned division on hash table sizes so that
1193 the remainder is nonnegative. Also, size_t is the natural width
1194 for hashing into memory. The previous code used 'int', which doesn't
1195 retain enough info to hash well into very large tables.
1196 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1197
1198 * dbusbind.c: Don't possibly lose pointer info when converting.
1199 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1200 Use XPNTR rather than XHASH, so that the high-order bits of
1201 the pointer aren't lost when converting through void *.
1202
1203 * eval.c (Fautoload): Don't double-shift a pointer.
1204
1205 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1206
1207 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1208
1209 * gnutls.c (DEF_GNUTLS_FN):
1210 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1211
1212 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1213
1214 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1215 marker. (Bug#8610)
1216
1217 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1218
1219 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1220 New version that can reserve upto 2GB of heap space.
1221
1222 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1223
1224 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1225
1226 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1227
1228 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1229 `gnutls_certificate_set_x509_key_file'.
1230
1231 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1232
1233 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1234 Update dependencies.
1235
1236 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1237
1238 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1239 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1240 Remove unused parameter `fildes'.
1241 * process.c (read_process_output, send_process): Don't pass it.
1242
1243 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1244
1245 Fix previous change: the library cache is defined in w32.c.
1246 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1247 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1248
1249 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1250
1251 Implement dynamic loading of GnuTLS on Windows.
1252
1253 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1254 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1255 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1256 Declare.
1257
1258 * gnutls.c (Qgnutls_dll): Define.
1259 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1260 (gnutls_*): Declare function pointers.
1261 (init_gnutls_functions): New function to initialize function pointers.
1262 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1263 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1264 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1265 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1266 (emacs_gnutls_write, emacs_gnutls_read)
1267 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1268 (Fgnutls_available_p): New function.
1269 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1270 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1271 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1272
1273 * image.c: Include w32.h.
1274 (Vimage_type_cache): Delete.
1275 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1276 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1277 (w32_delayed_load): Move to w32.c.
1278
1279 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1280
1281 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1282 (w32_delayed_load): Move from image.c. When loading a library, record
1283 its filename in the :loaded-from property of the library id.
1284 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1285 Initialize and staticpro them.
1286 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1287
1288 * process.c: Include lisp.h before w32.h, not after.
1289 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1290 instead of gnutls_record_check_pending.
1291
1292 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1293
1294 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1295
1296 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1297 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1298 as passed in.
1299
1300 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1301
1302 * xterm.c (x_set_frame_alpha): Do not set property on anything
1303 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1304
1305 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1306
1307 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1308
1309 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1310
1311 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1312 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1313 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1314 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1315 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1316 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1317 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1318 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1319 (Qgnutls_bootprop_callbacks_verify): Make static.
1320
1321 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1322
1323 * callproc.c: Indentation fixup.
1324
1325 * sysdep.c (wait_for_termination_1): Make static.
1326 (wait_for_termination, interruptible_wait_for_termination):
1327 Move after wait_for_termination_1.
1328
1329 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1330
1331 * sysdep.c (interruptible_wait_for_termination): New function
1332 which is like wait_for_termination, but allows keyboard
1333 interruptions.
1334
1335 * callproc.c (Fcall_process): Add (:file "file") as an option for
1336 the STDOUT buffer.
1337 (Fcall_process_region): Ditto.
1338
1339 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1340
1341 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1342 rather than `XVECTOR (FOO)->size'.
1343
1344 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1345 inttypes.h, as a gnulib replacement is used if it not available in
1346 system headers.
1347
1348 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1349
1350 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1351 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1352 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1353
1354 * coding.c (coding_alloc_by_realloc): Error out if destination
1355 will grow beyond MOST_POSITIVE_FIXNUM.
1356 (decode_coding_emacs_mule): Abort if there isn't enough place in
1357 charbuf for the composition carryover bytes. Reserve an extra
1358 space for up to 2 characters produced in a loop.
1359 (decode_coding_iso_2022): Abort if there isn't enough place in
1360 charbuf for the composition carryover bytes.
1361
1362 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1363
1364 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1365 aborting when %lld or %lll format is passed.
1366 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1367 %llo or %llx format is passed. (Bug#8545)
1368
1369 * window.c (window_scroll_line_based): Use a marker instead of
1370 simple variables to record original value of point. (Bug#7952)
1371
1372 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1373 produced by %s or %c overflows available buffer space. (Bug#8545)
1374
1375 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1376
1377 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1378 (SIZE_MAX): Move defn after all includes, as they might #define it.
1379
1380 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1381
1382 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1383
1384 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1385
1386 * keyboard.c (Qdelayed_warnings_hook): Define.
1387 (command_loop_1): Run `delayed-warnings-hook'
1388 if Vdelayed_warnings_list is non-nil.
1389 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1390 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1391
1392 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1393
1394 * doprnt.c (doprnt): Don't return value smaller than the buffer
1395 size if the message was truncated. (Bug#8545).
1396
1397 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1398
1399 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1400 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1401
1402 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1403
1404 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1405
1406 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1407
1408 * makefile.w32-in: Update dependencies.
1409
1410 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1411
1412 Improve `doprnt' and its usage. (Bug#8545)
1413 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1414 `format_end'. Remove support for %l as a conversion specifier.
1415 Don't use xrealloc. Improve diagnostics when the %l size modifier
1416 is used. Update the commentary.
1417
1418 * eval.c (verror): Simplify calculation of size_t.
1419
1420 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1421 messages.
1422
1423 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1424
1425 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1426 change.
1427
1428 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1429
1430 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1431 This makes this file independent of the recent pseudovector change.
1432
1433 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1434
1435 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1436
1437 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1438 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1439 Remove unused local.
1440 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1441
1442 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1443 GCC 4.6.0 optimizes based on type-based alias analysis.
1444 For example, if b is of type struct buffer * and v of type struct
1445 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1446 != &v->size, and therefore "v->size = 1; b->size = 2; return
1447 v->size;" must therefore return 1. This assumption is incorrect
1448 for Emacs, since it type-puns struct Lisp_Vector * with many other
1449 types. To fix this problem, this patch adds a new type struct
1450 vectorlike_header that documents the constraints on layout of vectors
1451 and pseudovectors, and helps optimizing compilers not get fooled
1452 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1453 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1454 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1455 the size member.
1456 (XSETPVECTYPE): Rewrite in terms of new macro.
1457 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1458 This is a bit clearer, and further avoids the possibility of
1459 undesirable aliasing.
1460 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1461 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1462 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1463 since Lisp_Subr is a special case (no "next" field).
1464 (ASIZE): Now uses header.size rather than size.
1465 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1466 to avoid the hassle of writing XVECTOR (foo)->header.size.
1467 (struct vectorlike_header): New type.
1468 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1469 object, to help avoid aliasing.
1470 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1471 (SUBRP): Likewise, since Lisp_Subr is a special case.
1472 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1473 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1474 (struct Lisp_Hash_Table): Combine first two members into a single
1475 struct vectorlike_header member. All uses of "size" and "next" members
1476 changed to be "header.size" and "header.next".
1477 * buffer.h (struct buffer): Likewise.
1478 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1479 * frame.h (struct frame): Likewise.
1480 * process.h (struct Lisp_Process): Likewise.
1481 * termhooks.h (struct terminal): Likewise.
1482 * window.c (struct save_window_data, struct saved_window): Likewise.
1483 * window.h (struct window): Likewise.
1484 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1485 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1486 * buffer.c (init_buffer_once): Likewise.
1487 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1488 special case.
1489 * process.c (Fformat_network_address): Use local var for size,
1490 for brevity.
1491
1492 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1493
1494 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1495 * data.c (atof): Remove decl; no longer used or needed.
1496 (digit_to_number): Move to lread.c.
1497 (Fstring_to_number): Use new string_to_number function, to be
1498 consistent with how the Lisp reader treats infinities and NaNs.
1499 Do not assume that floating-point numbers represent EMACS_INT
1500 without losing information; this is not true on most 64-bit hosts.
1501 Avoid double-rounding errors, by insisting on integers when
1502 parsing non-base-10 numbers, as the documentation specifies.
1503 * lisp.h (string_to_number): New decl, replacing ...
1504 (isfloat_string): Remove.
1505 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1506 (read1): Do not accept +. and -. as integers; this
1507 appears to have been a coding error. Similarly, do not accept
1508 strings like +-1e0 as floating point numbers. Do not report
1509 overflow for integer overflows unless the base is not 10 which
1510 means we have no simple and reliable way to continue.
1511 Break out the floating-point parsing into a new
1512 function string_to_number, so that Fstring_to_number parses
1513 floating point numbers consistently with the Lisp reader.
1514 (digit_to_number): Move here from data.c. Make it static inline.
1515 (E_CHAR, EXP_INT): Remove, replacing with ...
1516 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1517 (string_to_number): New function, replacing isfloat_string.
1518 This function checks for valid syntax and produces the resulting
1519 Lisp float number too. Rework it so that string-to-number
1520 no longer mishandles examples like "1.0e+". Use strtoumax,
1521 so that overflow for non-base-10 numbers is reported only when
1522 there's no portable and simple way to convert to floating point.
1523
1524 * textprop.c (set_text_properties_1): Rewrite for clarity,
1525 and to avoid GCC warning about integer overflow.
1526
1527 * intervals.h (struct interval): Use EMACS_INT for members
1528 where EMACS_UINT might cause problems. See
1529 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1530 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1531 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1532 All uses changed.
1533 (offset_intervals): Tell GCC not to worry about length overflow
1534 when negating a negative length.
1535
1536 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1537 (overrun_check_free): Likewise.
1538
1539 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1540 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1541 word size.
1542
1543 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1544 (gnutls_make_error): Rename local to avoid shadowing.
1545 (gnutls_emacs_global_deinit): ifdef out; not used.
1546 (Fgnutls_boot): Use const for pointer to readonly storage.
1547 Comment out unused local. Fix pointer signedness problems.
1548
1549 * lread.c (openp): Don't stuff size_t into an 'int'.
1550 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1551 about possible signed overflow.
1552
1553 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1554 (GDK_KEY_g): Don't define if already defined.
1555 (xg_prepare_tooltip): Avoid pointer signedness problem.
1556 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1557
1558 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1559 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1560
1561 * xfns.c (Fx_window_property): Simplify a bit,
1562 to make a bit faster and to avoid GCC 4.6.0 warning.
1563 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1564
1565 * fns.c (internal_equal): Don't assume size_t fits in int.
1566
1567 * alloc.c (compact_small_strings): Tighten assertion a little.
1568
1569 Replace pEd with more-general pI, and fix some printf arg casts.
1570 * lisp.h (pI): New macro, generalizing old pEd macro to other
1571 conversion specifiers. For example, use "...%"pI"d..." rather
1572 than "...%"pEd"...".
1573 (pEd): Remove. All uses replaced with similar uses of pI.
1574 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1575 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1576 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1577 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1578 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1579 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1580 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1581 64-bit hosts.
1582 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1583 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1584 * print.c (safe_debug_print, print_object): Likewise.
1585 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1586 to int.
1587 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1588 avoiding the 0 flag, which is not portable.
1589 * process.c (Fmake_network_process): Use pI to avoid cast.
1590 * region-cache.c (pp_cache): Likewise.
1591 * xdisp.c (decode_mode_spec): Likewise.
1592 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1593 behavior on 64-bit hosts with printf arg.
1594 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1595 (x_stop_queuing_selection_requests): Likewise.
1596 (x_get_window_property): Don't truncate byte count to an 'int'
1597 when tracing.
1598
1599 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1600 here, since it parses constructs like leading '-' and spaces,
1601 which are not wanted; and it overflows with large numbers.
1602 Instead, simply match F[0-9]+, which is what is wanted anyway.
1603
1604 * alloc.c: Remove unportable assumptions about struct layout.
1605 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1606 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1607 (allocate_vectorlike, make_pure_vector): Use the new macros,
1608 plus offsetof, to remove unportable assumptions about struct layout.
1609 These assumptions hold on all porting targets that I know of, but
1610 they are not guaranteed, they're easy to remove, and removing them
1611 makes further changes easier.
1612
1613 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1614 This doesn't fix a bug but makes the code clearer.
1615 (string_overrun_cookie): Now const. Use initializers that
1616 don't formally overflow signed char, to avoid warnings.
1617 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1618 can cause Emacs to crash when string overrun checking is enabled.
1619 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1620 multiple of sizeof (EMACS_INT); it need not be, if
1621 alignof(EMACS_INT) < sizeof (EMACS_INT).
1622 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1623
1624 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1625
1626 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1627
1628 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1629
1630 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1631 supposed to be handshaking. (Bug#8556)
1632 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1633
1634 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1635
1636 * lisp.h (Qdebug): List symbol.
1637 * eval.c (Qdebug): Restore global linkage.
1638 * keyboard.c (debug-on-event): New variable.
1639 (handle_user_signal): Break into debugger when debug-on-event
1640 matches the current signal symbol.
1641
1642 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1643
1644 * alloc.c (check_sblock, check_string_bytes)
1645 (check_string_free_list): Convert to standard C.
1646
1647 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1648
1649 * w32.c (emacs_gnutls_push): Fix typo.
1650
1651 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1652
1653 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1654 "cast to pointer from integer of different size".
1655
1656 Improve doprnt and its use in verror. (Bug#8545)
1657 * doprnt.c (doprnt): Document the set of format control sequences
1658 supported by the function. Use SAFE_ALLOCA instead of always
1659 using `alloca'.
1660
1661 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1662 is one byte too soon. Don't use xrealloc; instead xfree and
1663 xmalloc anew.
1664
1665 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1666
1667 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1668 callbacks stage.
1669
1670 * gnutls.c: Renamed global_initialized to
1671 gnutls_global_initialized. Added internals for the
1672 :verify-hostname-error, :verify-error, and :verify-flags
1673 parameters of `gnutls-boot' and documented those parameters in the
1674 docstring. Start callback support.
1675 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1676 unless a fatal error occured. Call gnutls_alert_send_appropriate
1677 on error. Return error code.
1678 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1679 (emacs_gnutls_read): Likewise.
1680 (Fgnutls_boot): Return handshake error code.
1681 (emacs_gnutls_handle_error): New function.
1682 (wsaerror_to_errno): Likewise.
1683
1684 * w32.h (emacs_gnutls_pull): Add prototype.
1685 (emacs_gnutls_push): Likewise.
1686
1687 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1688 (emacs_gnutls_push): Likewise.
1689
1690 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1691
1692 * process.c (wait_reading_process_output): Check if GnuTLS
1693 buffered some data internally if no FDs are set for TLS
1694 connections.
1695
1696 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1697 (LIBS): Link to USER_LIBS.
1698 ($(BLD)/gnutls.$(0)): New target.
1699
1700 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1701
1702 * xdisp.c (handle_single_display_spec): Rename the
1703 display_replaced_before_p argument into display_replaced_p, to
1704 make it consistent with the commentary. Fix typos in the
1705 commentary.
1706
1707 * textprop.c (syms_of_textprop): Remove dead code.
1708 (copy_text_properties): Delete obsolete commentary about an
1709 interface that was deleted long ago. Fix typos in the description
1710 of arguments.
1711
1712 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1713 to changes in oldXMenu/XMenu.h from 2011-04-16.
1714 <menu_help_message, prev_menu_help_message>: Constify.
1715 (IT_menu_make_room): menu->help_text is now `const char **';
1716 adjust.
1717
1718 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1719 to changes in oldXMenu/XMenu.h from 2011-04-16.
1720 (struct XMenu): Declare `help_text' `const char **'.
1721
1722 * xfaces.c <Qunspecified>: Make extern again.
1723
1724 * syntax.c: Include sys/types.h before including regex.h, as
1725 required by Posix.
1726
1727 * doc.c (get_doc_string): Improve the format passed to `error'.
1728
1729 * doprnt.c (doprnt): Improve commentary.
1730
1731 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1732
1733 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1734 them with etags.
1735
1736 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1737 changes in globals.h immediately force recompilation.
1738 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1739 $(CURDIR)/s/ms-w32.h.
1740 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1741
1742 * character.c (Fchar_direction): Function deleted.
1743 (syms_of_character): Don't defsubr it.
1744 <char-direction-table>: Deleted.
1745
1746 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1747
1748 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1749 * doprnt.c: Include limits.h.
1750 (SIZE_MAX): New macro.
1751 (doprnt): Return a size_t value. 2nd arg is now size_t.
1752 Many local variables are now size_t instead of int or unsigned.
1753 Improve overflow protection. Support `l' modifier for integer
1754 conversions. Support %l conversion. Don't assume an EMACS_INT
1755 argument for integer conversions and for %c.
1756
1757 * lisp.h (doprnt): Restore prototype.
1758
1759 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1760 $(SRC)/character.h.
1761
1762 * Makefile.in (base_obj): Add back doprnt.o.
1763
1764 * deps.mk (doprnt.o): Add back prerequisites.
1765 (callint.o): Depend on character.h.
1766
1767 * eval.c (internal_lisp_condition_case): Include the handler
1768 representation in the error message.
1769 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1770 when breaking from the loop.
1771
1772 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1773
1774 * callint.c (Fcall_interactively): When displaying error message
1775 about invalid control letter, pass the character's codepoint, not
1776 a pointer to its multibyte form. Improve display of the character
1777 in octal and display also its hex code.
1778
1779 * character.c (char_string): Use %x to display the (unsigned)
1780 codepoint of an invalid character, to avoid displaying a bogus
1781 negative value.
1782
1783 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1784 `error', not SYMBOL_NAME itself.
1785
1786 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1787 character arguments to `error'.
1788
1789 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1790 to `error' in error message about FINAL_CHAR argument. Make sure
1791 FINAL_CHAR is a character, and use %c when it is passed as
1792 argument to `error'.
1793
1794 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1795
1796 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1797
1798 * w32.c: Include <time.h>.
1799 (sys_localtime): New function.
1800
1801 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1802
1803 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1804
1805 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1806
1807 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1808
1809 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1810 zombies (Bug#8467).
1811
1812 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1813
1814 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1815 gl_state.e_property when gl_state.object is Qt.
1816
1817 * insdel.c (make_gap_larger): Remove limitation of buffer size
1818 to <= INT_MAX.
1819
1820 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1821
1822 * xdisp.c (lookup_glyphless_char_display)
1823 (produce_glyphless_glyph): Handle cons cell entry in
1824 glyphless-char-display.
1825 (Vglyphless_char_display): Document it.
1826
1827 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1828 glyphless-char-display.
1829
1830 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1831
1832 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1833
1834 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1835
1836 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1837 definition for no-X builds.
1838
1839 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 Static checks with GCC 4.6.0 and non-default toolkits.
1842
1843 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1844
1845 * process.c (keyboard_bit_set): Define only if SIGIO.
1846 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1847 (send_process): Repair possible setjmp clobbering.
1848
1849 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1850
1851 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1852
1853 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1854
1855 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1856 Define only if needed.
1857
1858 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1859 by pacifying GCC about it. Maybe it's time to retire it?
1860 * xfaces.c (USG, __TIMEVAL__): Likewise.
1861
1862 * dispextern.h (struct redisplay_interface): Rename param
1863 to avoid shadowing.
1864 * termhooks.h (struct terminal): Likewise.
1865 * xterm.c (xembed_send_message): Likewise.
1866
1867 * insdel.c (make_gap_smaller): Define only if
1868 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1869
1870 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1871 it.
1872
1873 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1874 so that we aren't warned about unused symbols.
1875
1876 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1877
1878 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1879
1880 * xfns.c (x_real_positions): Mark locals as initialized.
1881
1882 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1883
1884 * xterm.c: Fix problems found by static analysis with other toolkits.
1885 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1886 (x_dispatch_event): Declare static if USE_GTK, and
1887 define if USE_GTK || USE_X_TOOLKIT.
1888 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1889 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1890 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1891 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1892
1893 * xmenu.c (menu_help_callback): Pointer type fixes.
1894 Use const pointers when pointing at readonly data. Avoid pointer
1895 signedness clashes.
1896 (FALSE): Remove unused macro.
1897 (update_frame_menubar): Remove unused decl.
1898
1899 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1900
1901 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1902 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1903 (single_menu_item): Rename local to avoid shadowing.
1904
1905 * keyboard.c (make_lispy_event): Remove unused local var.
1906
1907 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1908 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1909
1910 * bitmaps: Change bitmaps from unsigned char back to the X11
1911 compatible char. Avoid the old compiler warnings about
1912 out-of-range initializers by using, for example, '\xab' rather
1913 than 0xab.
1914
1915 * xgselect.c (xgselect_initialize): Check vs interface
1916 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1917
1918 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1919
1920 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1921 to read-only memory.
1922
1923 * fns.c (vector): Remove; this old hack is no longer needed.
1924
1925 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1926 Remove unused var.
1927 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1928
1929 * xrdb.c (x_load_resources): Omit unused local.
1930
1931 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1932 (x_window): Rename locals to avoid shadowing.
1933 (USG): Use the kludged USG macro, to pacify gcc.
1934
1935 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1936 (x_term_init): Remove local to avoid shadowing.
1937
1938 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1939
1940 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1941 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1942
1943 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1944
1945 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1946
1947 Fix regex.c, syntax.c and friends for buffers > 2GB.
1948 * syntax.h (struct gl_state_s): Declare character position members
1949 EMACS_INT.
1950
1951 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1952
1953 * textprop.c (verify_interval_modification, interval_of):
1954 Declare arguments EMACS_INT.
1955
1956 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1957 EMACS_INT.
1958
1959 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1960
1961 * indent.c (Fvertical_motion): Local variable it_start is now
1962 EMACS_INT.
1963
1964 * regex.c (re_match, re_match_2, re_match_2_internal)
1965 (bcmp_translate, regcomp, regexec, print_double_string)
1966 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1967 (re_compile_pattern, re_exec): Declare arguments and local
1968 variables `size_t' and `ssize_t' and return values `regoff_t', as
1969 appropriate.
1970 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1971 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1972 <compile_stack_type>: `size' and `avail' are now `size_t'.
1973
1974 * regex.h <regoff_t>: Use ssize_t, not int.
1975 (re_search, re_search_2, re_match, re_match_2): Arguments that
1976 specify buffer/string position and length are now ssize_t and
1977 size_t. Return type is regoff_t.
1978
1979 2011-04-16 Ben Key <bkey76@gmail.com>
1980
1981 * nsfont.m: Fixed bugs in ns_get_family and
1982 ns_descriptor_to_entity that were caused by using free to
1983 deallocate memory blocks that were allocated by xmalloc (via
1984 xstrdup). This caused Emacs to crash when compiled with
1985 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1986 --enable-checking=xmallocoverrun). xfree is now used to
1987 deallocate these memory blocks.
1988
1989 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1990
1991 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1992
1993 emacs_write: Accept and return EMACS_INT for sizes.
1994 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1995 et seq.
1996 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1997 Accept and return EMACS_INT.
1998 (emacs_gnutls_write): Return the number of bytes written on
1999 partial writes.
2000 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2001 (emacs_read, emacs_write): Remove check for negative size, as the
2002 Emacs source code has been audited now.
2003 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2004 (emacs_read, emacs_write): Use it.
2005 * process.c (send_process): Adjust to the new signatures of
2006 emacs_write and emacs_gnutls_write. Do not attempt to store
2007 a byte offset into an 'int'; it might overflow.
2008 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2009
2010 * sound.c: Don't assume sizes fit in 'int'.
2011 (struct sound_device.period_size, alsa_period_size):
2012 Return EMACS_INT, not int.
2013 (struct sound_device.write, vox_write, alsa_write):
2014 Accept EMACS_INT, not int.
2015 (wav_play, au_play): Use EMACS_INT to store sizes and to
2016 record read return values.
2017
2018 2011-04-15 Ben Key <bkey76@gmail.com>
2019
2020 * keyboard.c (Qundefined): Don't declare static since it is used
2021 in nsfns.m.
2022 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2023 static since they are used in nsfont.m.
2024
2025 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2026
2027 * process.c (Qprocessp): Don't declare static.
2028 * lisp.h (Qprocessp): Declare again.
2029
2030 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2031
2032 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2033
2034 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2035
2036 Improve C-level modularity by making more things 'static'.
2037
2038 Don't publish debugger-only interfaces to other modules.
2039 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2040 (verify_bytepos, count_markers): Move decls to the only modules
2041 that need them.
2042 * region-cache.h (pp_cache): Likewise.
2043 * window.h (check_all_windows): Likewise.
2044 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2045
2046 * sysdep.c (croak): Now static, if
2047 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2048 * syssignal.h (croak): Declare only if not static.
2049
2050 * alloc.c (refill_memory_reserve): Now static if
2051 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2052 * lisp.h (refill_memory_reserve): Declare only if not static.
2053
2054 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2055 Define only if USE_LUCID.
2056
2057 * xrdb.c (x_customization_string, x_rm_string): Now static.
2058
2059 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2060 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2061
2062 * xdisp.c (draw_row_with_mouse_face): Now static.
2063 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2064
2065 * window.h (check_all_windows): Mark externally visible.
2066
2067 * window.c (window_deletion_count): Now static.
2068
2069 * undo.c: Make symbols static if they're not exported.
2070 (last_undo_buffer, last_boundary_position, pending_boundary):
2071 Now static.
2072
2073 * textprop.c (interval_insert_behind_hooks): Now static.
2074 (interval_insert_in_front_hooks): Likewise.
2075
2076 * term.c: Make symbols static if they're not exported.
2077 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2078 (max_frame_lines, tty_set_terminal_modes):
2079 (tty_reset_terminal_modes, tty_turn_off_highlight):
2080 (get_tty_terminal): Now static.
2081 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2082 * termhooks.h (term_mouse_moveto): Do not declare if
2083 HAVE_WINDOW_SYSTEM.
2084 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2085 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2086
2087 * sysdep.c: Make symbols static if they're not exported.
2088 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2089 Now static.
2090 (sigprocmask_set, full_mask): Remove; unused.
2091 (wait_debugging): Mark as visible.
2092 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2093 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2094
2095 * syntax.c (syntax_temp): Define only if !__GNUC__.
2096
2097 * sound.c (current_sound_device, current_sound): Now static.
2098
2099 * search.c (searchbufs, searchbuf_head): Now static.
2100
2101 * scroll.c (scroll_cost): Remove; unused.
2102 * dispextern.h (scroll_cost): Remove decl.
2103
2104 * region-cache.h (pp_cache): Mark as externally visible.
2105
2106 * process.c: Make symbols static if they're not exported.
2107 (process_tick, update_tick, create_process, chan_process):
2108 (Vprocess_alist, proc_buffered_char, datagram_access):
2109 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2110 (deactivate_process): Mark defn as static, as well as decl.
2111 * lisp.h (create_process): Remove decl.
2112 * process.h (chan_process, Vprocess_alist): Remove decls.
2113
2114 * print.c: Make symbols static if they're not exported.
2115 (print_depth, new_backquote_output, being_printed, print_buffer):
2116 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2117 (print_interval, print_number_index, initial_stderr_stream):
2118 Now static.
2119 * lisp.h (Fprinc): Remove decl.
2120 (debug_output_compilation_hack): Mark as externally visible.
2121
2122 * sysdep.c (croak): Move decl from here to syssignal.h.
2123 * syssignal.h (croak): Put it here, so the API can be checked when
2124 'croak' is called from dissociate_if_controlling_tty.
2125
2126 * minibuf.c: Make symbols static if they're not exported.
2127 (minibuf_save_list, choose_minibuf_frame): Now static.
2128 * lisp.h (choose_minibuf_frame): Remove decl.
2129
2130 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2131
2132 * lread.c: Make symbols static if they're not exported.
2133 (read_objects, initial_obarray, oblookup_last_bucket_number):
2134 Now static.
2135 (make_symbol): Remove; unused.
2136 * lisp.h (initial_obarray, make_symbol): Remove decls.
2137
2138 * keyboard.c: Make symbols static if they're not exported.
2139 (single_kboard, recent_keys_index, total_keys, recent_keys):
2140 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2141 (this_single_command_key_start, echoing, last_auto_save):
2142 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2143 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2144 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2145 (Vlispy_mouse_stem, double_click_count):
2146 Now static.
2147 (force_auto_save_soon): Define only if SIGDANGER.
2148 (ignore_mouse_drag_p): Now static if
2149 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2150 (print_help): Remove; unused.
2151 (stop_character, last_timer_event): Mark as externally visible.
2152 * keyboard.h (ignore_mouse_drag_p): Declare only if
2153 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2154 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2155 * lisp.h (echoing): Remove decl.
2156 (force_auto_save_soon): Declare only if SIGDANGER.
2157 * xdisp.c (redisplay_window): Simplify code, to make it more
2158 obvious that ignore_mouse_drag_p is not accessed if !defined
2159 USE_GTK && !defined HAVE_NS.
2160
2161 * intervals.c: Make symbols static if they're not exported.
2162 (merge_properties_sticky, merge_interval_right, delete_interval):
2163 Now static.
2164 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2165
2166 * insdel.c: Make symbols static if they're not exported.
2167 However, leave prepare_to_modify_buffer alone. It's never
2168 called from outside this function, but that appears to be a bug.
2169 (combine_after_change_list, combine_after_change_buffer):
2170 (adjust_after_replace, signal_before_change): Now static.
2171 (adjust_after_replace_noundo): Remove; unused.
2172 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2173 (signal_before_change): Remove decls.
2174
2175 * indent.c (val_compute_motion, val_vmotion): Now static.
2176
2177 * image.c: Make symbols static if they're not exported.
2178 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2179 if USE_GTK.
2180 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2181 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2182
2183 * fringe.c (standard_bitmaps): Now static.
2184 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2185
2186 * frame.c: Make symbols static if they're not exported.
2187 (x_report_frame_params, make_terminal_frame): Now static.
2188 (get_frame_param): Now static, unless HAVE_NS.
2189 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2190 (x_get_resource_string): Remove; not used.
2191 * frame.h (make_terminal_frame, x_report_frame_params):
2192 (x_get_resource_string); Remove decls.
2193 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2194 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2195
2196 * font.c, fontset.c: Make symbols static if they're not exported.
2197 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2198 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2199 * font.c (font_close_object): Now static.
2200 * font.h (font_close_object): Remove.
2201 * fontset.c (FONTSET_OBJLIST): Remove.
2202 (free_realized_fontset) #if-0 the body, which does nothing.
2203 (face_suitable_for_char_p): #if-0, as it's never called.
2204 * fontset.h (face_suitable_for_char_p): Remove decl.
2205 * xfaces.c (face_at_string_position):
2206 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2207 since 0 is always ASCII.
2208
2209 * fns.c (weak_hash_tables): Now static.
2210
2211 * fileio.c: Make symbols static if they're not exported.
2212 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2213 (Vwrite_region_annotation_buffers): Now static.
2214
2215 * eval.c: Make symbols static if they're not exported.
2216 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2217 * lisp.h (backtrace_list): Remove decl.
2218
2219 * emacs.c: Make symbols static if they're not exported.
2220 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2221 (fatal_error_code, fatal_error_signal_hook, standard_args):
2222 Now static.
2223 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2224 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2225 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2226 * lisp.h (fatal_error_signal_hook): Remove decl.
2227 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2228
2229 * editfns.c: Move a (normally-unused) function to its only use.
2230 * editfns.c, lisp.h (get_operating_system_release): Remove.
2231 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2232 worth the hassle of breaking this out.
2233
2234 * xterm.c: Make symbols static if they're not exported.
2235 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2236 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2237 (x_destroy_window, x_delete_display):
2238 Now static.
2239 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2240 (x_mouse_leave): Remove; unused.
2241 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2242 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2243 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2244 Remove decls.
2245 (x_mouse_leave): Declare only if WINDOWSNT.
2246 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2247 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2248 USE_X_TOOLKIT.
2249
2250 * ftxfont.c: Make symbols static if they're not exported.
2251 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2252 HAVE_FREETYPE.
2253 * font.h (ftxfont_driver): Likewise.
2254
2255 * xfns.c: Make symbols static if they're not exported.
2256 (x_last_font_name, x_display_info_for_name):
2257 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2258 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2259 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2260 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2261 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2262 (last_show_tip_args): Now static.
2263 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2264 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2265 (x_screen_planes): Remove; unused.
2266 * dispextern.h (x_screen_planes): Remove decl.
2267
2268 * dispnew.c: Make symbols static if they're not exported.
2269 * dispextern.h (redraw_garbaged_frames, scrolling):
2270 (increment_row_positions): Remove.
2271 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2272 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2273 Now static.
2274 (redraw_garbaged_frames): Remove; unused.
2275
2276 * xfaces.c: Make symbols static if they're not exported.
2277 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2278 Remove decls.
2279 * xterm.h (defined_color): Remove decls.
2280 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2281 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2282 (menu_face_changed_default, defined_color, free_realized_face):
2283 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2284 (ascii_face_of_lisp_face): Remove; unused.
2285
2286 * xdisp.c: Make symbols static if they're not exported.
2287 * dispextern.h (scratch_glyph_row, window_box_edges):
2288 (glyph_to_pixel_coords, set_cursor_from_row):
2289 (get_next_display_element, set_iterator_to_next):
2290 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2291 (show_mouse_face): Remove decls
2292 * frame.h (message_buf_print): Likewise.
2293 * lisp.h (pop_message, set_message, check_point_in_composition):
2294 Likewise.
2295 * xterm.h (set_vertical_scroll_bar): Likewise.
2296 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2297 (message_buf_print, scratch_glyph_row, displayed_buffer):
2298 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2299 (get_next_display_element, show_mouse_face, window_box_edges):
2300 (frame_to_window_pixel_xy, check_point_in_composition):
2301 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2302 (glyph_to_pixel_coords): Remove; unused.
2303
2304 * dired.c (file_name_completion): Now static.
2305
2306 * dbusbind.c (xd_in_read_queued_messages): Now static.
2307
2308 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2309 * data.c (circular_list_error): Remove.
2310
2311 * commands.h (last_point_position, last_point_position_buffer):
2312 (last_point_position_window): Remove decls.
2313 * keyboard.c: Make these variables static.
2314
2315 * coding.h (coding, code_convert_region, encode_coding_gap):
2316 Remove decls.
2317 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2318 (iso_code_class, detect_coding, code_convert_region): Now static.
2319 (encode_coding_gap): Remove; unused.
2320
2321 * chartab.c (chartab_chars, chartab_bits): Now static.
2322
2323 * charset.h (charset_iso_8859_1): Remove decl.
2324 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2325 Now static.
2326
2327 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2328 * ccl.c (Vccl_program_table): Now static.
2329 (check_ccl_update): Remove; unused.
2330
2331 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2332 * category.h: ... from here.
2333 * category.c (check_category_table, set_category_set): Now static.
2334
2335 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2336 * lisp.h: Remove these decls.
2337
2338 * buffer.c (buffer_count): Remove unused var.
2339
2340 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2341 so that it's not optimized away.
2342 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2343 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2344 exported only to the debugger.
2345
2346 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2347 * atimer.h (run_all_atimers): Remove; not exported.
2348
2349 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2350 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2351 was inaccessible from Lisp.
2352 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2353 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2354
2355 alloc.c: Import and export fewer symbols, and remove unused items.
2356 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2357 is defined.
2358 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2359 it's not optimized away by whole-program optimization.
2360 (message_enable_multibyte, free_misc): Remove.
2361 (catchlist, handlerlist, mark_backtrace):
2362 Declare only if BYTE_MARK_STACK.
2363 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2364 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2365 (message_enable_multibyte): Remove decl.
2366 (free_misc, interval_free_list, float_block, float_block_index):
2367 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2368 (cons_free_list, last_marked_index):
2369 Now static.
2370 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2371 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2372 (mark_backtrace): Define only if BYTE_MARK_STACK.
2373 * xdisp.c (message_enable_multibyte): Now static.
2374
2375 Declare Lisp_Object Q* variables to be 'static' if not exported.
2376 This makes it easier for human readers (and static analyzers)
2377 to see whether these variables are used from other modules.
2378 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2379 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2380 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2381 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2382 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2383 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2384 * xmenu.c, xselect.c:
2385 Declare Q* vars static if they are not used in other modules.
2386 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2387 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2388 Remove decls of unexported vars.
2389 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2390
2391 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2392
2393 Make Emacs functions such as Fatom 'static' by default.
2394 This makes it easier for human readers (and static analyzers)
2395 to see whether these functions can be called from other modules.
2396 DEFUN now defines a static function. To make the function external
2397 so that it can be used in other C modules, use the new macro DEFUE.
2398 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2399 (Finit_image_library):
2400 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2401 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2402 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2403 Remove decls, since these functions are now static.
2404 (Funintern, Fget_internal_run_time): New decls, since these functions
2405 were already external.
2406
2407 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2408 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2409 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2410 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2411 * keyboard.c, keymap.c, lread.c:
2412 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2413 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2414 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2415 Mark functions with DEFUE instead of DEFUN,
2416 if they are used in other modules.
2417 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2418 decls for now-static functions.
2419 * buffer.h (Fdelete_overlay): Remove decl.
2420 * callproc.c (Fgetenv_internal): Mark as internal.
2421 * composite.c (Fremove_list_of_text_properties): Remove decl.
2422 (Fcomposition_get_gstring): New forward static decl.
2423 * composite.h (Fcomposite_get_gstring): Remove decl.
2424 * dired.c (Ffile_attributes): New forward static decl.
2425 * doc.c (Fdocumntation_property): New forward static decl.
2426 * eval.c (Ffetch_bytecode): New forward static decl.
2427 (Funintern): Remove extern decl; now in .h file where it belongs.
2428 * fileio.c (Fmake_symbolic_link): New forward static decl.
2429 * image.c (Finit_image_library): New forward static decl.
2430 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2431 * intervals.h (Fprevious_property_change):
2432 (Fremove_list_of_text_properties): Remove decls.
2433 * keyboard.c (Fthis_command_keys): Remove decl.
2434 (Fcommand_execute): New forward static decl.
2435 * keymap.c (Flookup_key): New forward static decl.
2436 (Fcopy_keymap): Now static.
2437 * keymap.h (Flookup_key): Remove decl.
2438 * process.c (Fget_process): New forward static decl.
2439 (Fprocess_datagram_address): Mark as internal.
2440 * syntax.c (Fsyntax_table_p): New forward static decl.
2441 (skip_chars): Remove duplicate decl.
2442 * textprop.c (Fprevious_property_change): New forward static decl.
2443 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2444 Now internal.
2445 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2446 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2447
2448 * editfns.c (Fformat): Remove unreachable code.
2449
2450 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2451
2452 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2453 change. (Bug#8496)
2454
2455 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2456
2457 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2458 when at ZV. (Bug#8487)
2459
2460 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2461
2462 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2463 (Bug#8437)
2464 * keyboard.c (parse_tool_bar_item): Likewise.
2465 * sound.c (sound_cleanup, alsa_close): Likewise.
2466 * termcap.c (tgetent): Likewise.
2467 * xfns.c (x_default_font_parameter): Likewise.
2468 * xsettings.c (read_and_apply_settings): Likewise.
2469
2470 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2471 (overrun_check_free): Protoize.
2472
2473 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2476 since callers should never pass a negative size.
2477 Change the signature to match that of plain 'read' and 'write'; see
2478 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2479 * lisp.h: Update prototypes of emacs_write and emacs_read.
2480
2481 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2482
2483 * xdisp.c (redisplay_window): Don't try to determine the character
2484 position of the scroll margin if the window start point w->startp
2485 is outside the buffer's accessible region. (Bug#8468)
2486
2487 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2488
2489 Fix write-region and its subroutines for buffers > 2GB.
2490 * fileio.c (a_write, e_write): Modify declaration of arguments and
2491 local variables to support buffers larger than 2GB.
2492 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2493
2494 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2495 argument, local variables, and return value.
2496
2497 * lisp.h: Update prototypes of emacs_write and emacs_read.
2498
2499 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2500
2501 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2504
2505 Fix more problems found by GCC 4.6.0's static checks.
2506
2507 * xdisp.c (vmessage): Use a better test for character truncation.
2508
2509 * charset.c (load_charset_map): <, not <=, for optimization,
2510 and to avoid potential problems with integer overflow.
2511 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2512 * casetab.c (set_identity, shuffle): Likewise.
2513 * editfns.c (Fformat): Likewise.
2514 * syntax.c (skip_chars): Likewise.
2515
2516 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2517 This also lets GCC 4.6.0 generate slightly better loop code.
2518
2519 * callint.c (Fcall_interactively): <, not <=, for optimization.
2520 (Fcall_interactively): Count the number of arguments produced,
2521 not the number of arguments given. This is simpler and lets GCC
2522 4.6.0 generate slightly better code.
2523
2524 * ftfont.c: Distingish more carefully between FcChar8 and char.
2525 The previous code passed unsigned char * to a functions like
2526 strlen and xstrcasecmp that expect char *, which does not
2527 conform to the C standard.
2528 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2529 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2530 char * when the C standard requires it.
2531
2532 * keyboard.c (read_char): Remove unused var.
2533
2534 * eval.c: Port to Windows vsnprintf (Bug#8435).
2535 Include <limits.h>.
2536 (SIZE_MAX): Define if the headers do not.
2537 (verror): Do not give up if vsnprintf returns a negative count.
2538 Instead, grow the buffer. This ports to Windows vsnprintf, which
2539 does not conform to C99. Problem reported by Eli Zaretskii.
2540 Also, simplify the allocation scheme, by avoiding the need for
2541 calling realloc, and removing the ALLOCATED variable.
2542
2543 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2544
2545 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2546 But keep the doprint source code for now, as we might revamp it
2547 and use it again (Bug#8435).
2548 * lisp.h (doprnt): Remove.
2549 * Makefile.in (base_obj): Remove doprnt.o.
2550 * deps.mk (doprnt.o): Remove.
2551
2552 error: Print 32- and 64-bit integers portably (Bug#8435).
2553 Without this change, on typical 64-bit hosts error ("...%d...", N)
2554 was used to print both 32- and 64-bit integers N, which relied on
2555 undefined behavior.
2556 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2557 New macro.
2558 * lisp.h (error, verror): Mark as printf-like functions.
2559 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2560 Report overflow in size calculations when allocating printf buffer.
2561 Do not truncate output string at its first null byte.
2562 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2563 Truncate the output at a character boundary, since vsnprintf does not
2564 do that.
2565 * charset.c (check_iso_charset_parameter): Convert internal
2566 character to string before calling 'error', since %c now has the
2567 printf meaning.
2568 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2569 overflow when computing char to be passed to 'error'. Do not
2570 pass Lisp_Object to 'error'; pass the integer instead.
2571 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2572 formatted with plain %d.
2573
2574 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2575
2576 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2577
2578 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2579
2580 * xterm.c (x_catch_errors): Remove duplicate declaration.
2581
2582 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2583
2584 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2585
2586 2011-04-10 Jim Meyering <meyering@redhat.com>
2587
2588 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2589 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2590 return ssize_t not "int", and use size_t as the buffer length.
2591 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2592 * gnutls.h: Update declarations.
2593 * process.c (read_process_output): Use ssize_t, to match.
2594 (send_process): Likewise.
2595
2596 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2597
2598 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2599
2600 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2601
2602 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2603 Use unsigned char, to match FcChar8 type definition.
2604
2605 * xterm.c (handle_one_xevent):
2606 * xmenu.c (create_and_show_popup_menu):
2607 * xselect.c (x_decline_selection_request)
2608 (x_reply_selection_request): Avoid type-punned deref of X events.
2609
2610 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2611
2612 Fix some uses of `int' instead of EMACS_INT.
2613 * search.c (string_match_1, fast_string_match)
2614 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2615 (scan_buffer, find_next_newline_no_quit)
2616 (find_before_next_newline, search_command, Freplace_match)
2617 (Fmatch_data): Make some `int' variables be EMACS_INT.
2618
2619 * xdisp.c (display_count_lines): 3rd argument and return value now
2620 EMACS_INT. All callers changed.
2621 (pint2hrstr): Last argument is now EMACS_INT.
2622
2623 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2624 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2625 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2626 (decode_coding_utf_16, decode_coding_emacs_mule)
2627 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2628 (decode_coding_ccl, decode_coding_charset)
2629 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2630 (decode_coding_iso_2022, decode_coding_emacs_mule)
2631 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2632 <char_offset, last_offset>: Declare EMACS_INT.
2633 (encode_coding_utf_8, encode_coding_utf_16)
2634 (encode_coding_emacs_mule, encode_invocation_designation)
2635 (encode_designation_at_bol, encode_coding_iso_2022)
2636 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2637 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2638 Declare EMACS_INT.
2639 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2640 (encode_invocation_designation): Last argument P_NCHARS is now
2641 EMACS_INT.
2642 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2643 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2644
2645 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2646 All users changed.
2647
2648 * ccl.c (Fccl_execute_on_string): Declare some variables
2649 EMACS_INT.
2650
2651 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2652
2653 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2654
2655 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2656
2657 * process.c (Fformat_network_address): Doc fix.
2658
2659 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2660
2661 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2662
2663 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2664
2665 * keyboard.c (read_char): Call Lisp function help-form-show,
2666 instead of using internal_with_output_to_temp_buffer.
2667 (Qhelp_form_show): New var.
2668 (syms_of_keyboard): Use DEFSYM macro.
2669
2670 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2671
2672 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2673
2674 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2675
2676 * process.c (Flist_processes): Remove to Lisp.
2677 (list_processes_1): Delete.
2678
2679 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2680
2681 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2682
2683 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2684
2685 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2686
2687 Fix more problems found by GCC 4.6.0's static checks.
2688
2689 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2690
2691 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2692
2693 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2694
2695 * xdisp.c (vmessage): Mark as a printf-like function.
2696
2697 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2698
2699 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2700
2701 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2702 printf-like functions.
2703 (tiff_load): Add casts to remove these marks before passing them
2704 to system-supplied API.
2705
2706 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2707
2708 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2709 This avoids several warnings with gcc -Wstrict-overflow.
2710 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2711 directly, rather than having caller test rule sign. This avoids
2712 some unnecessary tests.
2713 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2714 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2715 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2716
2717 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2718 (xfont_open): Avoid unnecessary tests.
2719
2720 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2721
2722 * composite.h, composite.c (composition_gstring_put_cache):
2723 Use EMACS_INT, not int, for length.
2724
2725 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2726 breaking out part of COMPOSITION_DECODE_RULE.
2727 (COMPOSITION_DECODE_RULE): Use it.
2728 * composite.c (get_composition_id): Remove unused local vars,
2729 by using the new macro.
2730
2731 * textprop.c (set_text_properties_1): Change while to do-while,
2732 since the condition is always true at first.
2733
2734 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2735 (interval_deletion_adjustment): Return unsigned value.
2736 All uses changed.
2737
2738 * process.c (list_processes_1, create_pty, read_process_output):
2739 (exec_sentinel): Remove vars that were set but not used.
2740 (create_pty): Remove unnecessary "volatile"s.
2741 (Fnetwork_interface_info): Avoid possibility of int overflow.
2742 (read_process_output): Do adaptive read buffering even if carryover.
2743 (read_process_output): Simplify nbytes computation if buffered.
2744
2745 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2746
2747 * syntax.c (scan_words): Remove var that was set but not used.
2748 (update_syntax_table): Use unsigned instead of int.
2749
2750 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2751 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2752 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2753
2754 * print.c (print_error_message): Avoid int overflow.
2755
2756 * font.c (font_list_entities): Redo for clarity,
2757 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2758
2759 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2760 (font_score): Avoid potential overflow in diff calculation.
2761
2762 * fns.c (substring_both): Remove var that is set but not used.
2763 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2764
2765 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2766
2767 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2768 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2769 can always succeed if overflow has undefined behavior.
2770
2771 * search.c (boyer_moore, wordify): Remove vars set but not used.
2772 (wordify): Omit three unnecessary tests.
2773
2774 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2775 All callers changed. This avoids the need for an unused var.
2776
2777 * casefiddle.c (casify_region): Remove var that is set but not used.
2778
2779 * dired.c (file_name_completion): Remove var that is set but not used.
2780
2781 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2782
2783 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2784 (Finsert_file_contents): Remove unnecessary code checking fd.
2785
2786 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2787 Check for integer overflow on size calculations.
2788
2789 * buffer.c (Fprevious_overlay_change): Remove var that is set
2790 but not used.
2791
2792 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2793 Remove vars that are set but not used.
2794 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2795 (timer_check_2): Mark vars as initialized.
2796
2797 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2798
2799 * image.c (lookup_image): Remove var that is set but not used.
2800 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2801
2802 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2803 that are set but not used.
2804
2805 * xfns.c (make_invisible_cursor): Don't return garbage
2806 if XCreateBitmapFromData fails (Bug#8410).
2807
2808 * xselect.c (x_get_local_selection, x_handle_property_notify):
2809 Remove vars that are set but not used.
2810
2811 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2812 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2813
2814 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2815 Remove var that is set but not used.
2816 (scroll_bar_windows_size): Now size_t, not int.
2817 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2818 Check for overflow.
2819
2820 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2821 (map_tty_color) [!defined MSDOS]: Likewise.
2822
2823 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2824
2825 * coding.c: Remove vars that are set but not used.
2826 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2827 All callers changed.
2828 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2829 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2830 (decode_coding_charset): Remove vars that are set but not used.
2831
2832 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2833 that is set but not used.
2834
2835 * print.c (print_object): Remove var that is set but not used.
2836
2837 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2838 The gnulib version avoids calling malloc in the usual case,
2839 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2840 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2841 * filelock.c (current_lock_owner): Likewise.
2842 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2843 * sysdep.c: Include allocator.h, careadlinkat.h.
2844 (emacs_no_realloc_allocator): New static constant.
2845 (emacs_readlink): New function.
2846 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2847 ../lib/careadlinkat.h.
2848
2849 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2850
2851 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2852 first non-nil return value).
2853
2854 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2855
2856 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2857 if not defined (Bug#8403).
2858
2859 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2860
2861 * xdisp.c (display_count_lines): Remove parameter `start',
2862 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2863 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2864 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2865 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2866 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2867 and thereabouts. All callers changed.
2868 (get_per_char_metric): Remove parameter `f', unused since
2869 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2870
2871 2011-04-02 Jim Meyering <meyering@redhat.com>
2872
2873 do not dereference NULL upon failed strdup
2874 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2875 (ns_get_family): Likewise.
2876
2877 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2878
2879 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2880
2881 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2882
2883 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2884 later (Bug#8403).
2885
2886 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2887
2888 Add lexical binding.
2889
2890 * window.c (Ftemp_output_buffer_show): New fun.
2891 (Fsave_window_excursion):
2892 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2893
2894 * lread.c (lisp_file_lexically_bound_p): New function.
2895 (Fload): Bind Qlexical_binding.
2896 (readevalloop): Remove `evalfun' arg.
2897 Bind Qinternal_interpreter_environment.
2898 (Feval_buffer): Bind Qlexical_binding.
2899 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2900 Mark as dynamic.
2901 (syms_of_lread): Declare `lexical-binding'.
2902
2903 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2904
2905 * keyboard.c (eval_dyn): New fun.
2906 (menu_item_eval_property): Use it.
2907
2908 * image.c (parse_image_spec): Use Ffunctionp.
2909
2910 * fns.c (concat, mapcar1): Accept byte-code-functions.
2911
2912 * eval.c (Fsetq): Handle lexical vars.
2913 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2914 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2915 (FletX, Flet): Obey lexical binding.
2916 (Fcommandp): Handle closures.
2917 (Feval): New `lexical' arg.
2918 (eval_sub): New function extracted from Feval. Use it almost
2919 everywhere where Feval was used. Look up vars in lexical env.
2920 Handle closures.
2921 (Ffunctionp): Move from subr.el.
2922 (Ffuncall): Handle closures.
2923 (apply_lambda): Remove `eval_flags'.
2924 (funcall_lambda): Handle closures and new byte-code-functions.
2925 (Fspecial_variable_p): New function.
2926 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2927 but without exporting it to Lisp.
2928
2929 * doc.c (Fdocumentation, store_function_docstring):
2930 * data.c (Finteractive_form): Handle closures.
2931
2932 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2933 interactive spec.
2934
2935 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2936 New byte-codes.
2937 (exec_byte_code): New function extracted from Fbyte_code to handle new
2938 calling convention for byte-code-functions. Add new byte-codes.
2939
2940 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2941
2942 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2943
2944 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2945
2946 * xdisp.c (redisplay_internal): Fix prototype.
2947
2948 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2949
2950 * xdisp.c (SCROLL_LIMIT): New macro.
2951 (try_scrolling): Use it when setting scroll_limit.
2952 Limit scrolling to 100 screen lines.
2953 (redisplay_window): Even when falling back on "recentering",
2954 position point in the window according to scroll-conservatively,
2955 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2956
2957 (try_scrolling): When point is above the window, allow searching
2958 as far as scroll_max, or one screenful, to compute vertical
2959 distance from PT to the scroll margin position. This prevents
2960 try_scrolling from unnecessarily failing when
2961 scroll-conservatively is set to a value slightly larger than the
2962 window height. Clean up the case of PT below the margin at bottom
2963 of window: scroll_max can no longer be INT_MAX. When aggressive
2964 scrolling is in use, don't let point enter the opposite scroll
2965 margin as result of the scroll.
2966 (syms_of_xdisp) <scroll-conservatively>: Document the
2967 threshold of 100 lines for never-recentering scrolling.
2968
2969 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2970
2971 * dispextern.h (move_it_by_lines):
2972 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2973 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2974 (message_log_check_duplicate): Remove parameters `prev_bol' and
2975 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2976 (redisplay_internal): Remove parameter `preserve_echo_area',
2977 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2978
2979 * indent.c (Fvertical_motion):
2980 * window.c (window_scroll_pixel_based, Frecenter):
2981 Don't pass `need_y_p' to `move_it_by_lines'.
2982
2983 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2984
2985 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2986 steal a few bits to be more compact.
2987 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2988 Remove unneeded casts.
2989
2990 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2991
2992 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2993
2994 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2995 binding" message (bug#7967).
2996
2997 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2998
2999 Fix more problems found by GCC 4.6.0's static checks.
3000
3001 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3002 Remove unused local var.
3003
3004 * editfns.c (Fmessage_box): Remove unused local var.
3005
3006 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3007 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3008 Omit unused local vars.
3009 * window.c (shrink_windows): Omit unused local var.
3010 * menu.c (digest_single_submenu): Omit unused local var.
3011 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3012 Omit unused local var.
3013
3014 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3015 Don't assume string length fits in int.
3016 (keyremap_step, read_key_sequence): Use size_t for sizes.
3017 (read_key_sequence): Don't check last_real_key_start redundantly.
3018
3019 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3020 instead of alloca (Bug#8344).
3021
3022 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3023 (Fbacktrace_frame): Don't assume nframes fits in int.
3024
3025 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3026
3027 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3028 concerns.
3029
3030 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3031
3032 * cm.c (calccost): Turn while-do into do-while, for clarity.
3033
3034 * keyboard.c (syms_of_keyboard): Use the same style as later
3035 in this function when indexing through an array. This also
3036 works around GCC bug 48267.
3037
3038 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3039
3040 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3041
3042 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3043 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3044
3045 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3046 This avoids undefined behavior on integer overflow, and is a bit
3047 more convenient anyway since it is compared to a size_t variable.
3048
3049 Variadic C functions now count arguments with size_t, not int.
3050 This avoids an unnecessary limitation on 64-bit machines, which
3051 caused (substring ...) to crash on large vectors (Bug#8344).
3052 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3053 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3054 All variadic functions and their callers changed accordingly.
3055 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3056 * data.c (arith_driver, float_arith_driver): Likewise.
3057 * editfns.c (general_insert_function): Likewise.
3058 * eval.c (struct backtrace.nargs, interactive_p)
3059 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3060 (funcall_lambda, mark_backtrace): Likewise.
3061 * fns.c (concat): Likewise.
3062 * frame.c (x_set_frame_parameters): Likewise.
3063 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3064 0 if not found, not -1. All callers changed.
3065
3066 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3067 (stack_copy_size): Now size_t, not int.
3068 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3069
3070 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3071
3072 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3073 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3074 All callers changed.
3075
3076 * lisp.h (multibyte_char_to_unibyte):
3077 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3078 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3079 * character.h (CHAR_TO_BYTE8):
3080 * cmds.c (internal_self_insert):
3081 * editfns.c (general_insert_function):
3082 * keymap.c (push_key_description):
3083 * search.c (Freplace_match):
3084 * xdisp.c (message_dolog, set_message_1): All callers changed.
3085
3086 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3087
3088 * keyboard.c (safe_run_hook_funcall): New function.
3089 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3090 don't set the hook to nil, but remove the offending function instead.
3091 (Qcommand_hook_internal): Remove, unused.
3092 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3093 Vcommand_hook_internal.
3094
3095 * eval.c (enum run_hooks_condition): Remove.
3096 (funcall_nil, funcall_not): New functions.
3097 (run_hook_with_args): Call each function through a `funcall' argument.
3098 Remove `cond' argument, now redundant.
3099 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3100 (Frun_hook_with_args_until_failure): Adjust accordingly.
3101 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3102
3103 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3104
3105 * dispextern.h (string_buffer_position): Remove declaration.
3106
3107 * print.c (strout): Remove parameter `multibyte', unused since
3108 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3109
3110 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3111 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3112 All callers changed.
3113
3114 * w32.c (_wsa_errlist): Use braces for struct initializers.
3115
3116 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3117 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3118 All callers changed.
3119 (string_buffer_position): Likewise. Also, make static (it's never
3120 used outside xdisp.c).
3121 (cursor_row_p): Remove parameter `w', unused since
3122 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3123 (decode_mode_spec): Remove parameter `precision', introduced during
3124 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3125 All callers changed.
3126
3127 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3128
3129 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3130
3131 2011-03-27 Anders Lindgren <andlind@gmail.com>
3132
3133 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3134 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3135 (ns_update_auto_hide_menu_bar): New functions.
3136 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3137 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3138 ns_constrain_all_frames.
3139 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3140 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3141
3142 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3143
3144 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3145
3146 2011-03-27 Glenn Morris <rgm@gnu.org>
3147
3148 * syssignal.h: Replace RETSIGTYPE with void.
3149 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3150 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3151 Replace SIGTYPE with void everywhere.
3152 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3153 * s/template.h (SIGTYPE): Remove commented out definition.
3154
3155 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3156
3157 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3158 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3159
3160 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3161
3162 * w32.c (read_unc_volume): Use parameter `henum', instead of
3163 global variable `wget_enum_handle'.
3164
3165 * keymap.c (describe_vector): Remove parameters `indices' and
3166 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3167 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3168
3169 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3170
3171 * keyboard.c (timer_check): Remove parameter `do_it_now',
3172 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3173 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3174 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3175
3176 * keyboard.c (read_char):
3177 * w32menu.c (w32_menu_display_help):
3178 * xmenu.c (show_help_event, menu_help_callback):
3179 Adjust calls to `show_help_echo'.
3180
3181 * gtkutil.c (xg_maybe_add_timer):
3182 * keyboard.c (readable_events):
3183 * process.c (wait_reading_process_output):
3184 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3185
3186 * insdel.c (adjust_markers_gap_motion):
3187 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3188 (gap_left, gap_right): Don't call it.
3189
3190 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3191
3192 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3193 incurred during fontification.
3194
3195 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3196
3197 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3198 (DEFVAR_PER_BUFFER): Don't pass it.
3199
3200 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3201 (scrolling_window): Don't pass it.
3202
3203 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3204
3205 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3206
3207 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3208 and `suffix'.
3209 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3210 of variables specific to SELinux and computation of `encoded_absname'.
3211
3212 * image.c (XPutPixel): Remove unused variable `height'.
3213
3214 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3215
3216 * unexw32.c (get_section_info): Remove unused variable `section'.
3217
3218 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3219 (system_process_attributes): Remove unused variable `sess'.
3220 (sys_read): Remove unused variable `err'.
3221
3222 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3223 (w32_wnd_proc): Remove unused variable `isdead'.
3224 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3225 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3226 (x_create_tip_frame): Remove unused variable `tem'.
3227
3228 * w32inevt.c (w32_console_read_socket):
3229 Remove unused variable `no_events'.
3230
3231 * w32term.c (x_draw_composite_glyph_string_foreground):
3232 Remove unused variable `width'.
3233
3234 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3235
3236 * w32term.c (x_set_glyph_string_clipping):
3237 Don't pass uninitialized region to CombineRgn.
3238
3239 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3240
3241 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3242 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3243 (Fx_close_connection): Remove unused variable `i'.
3244
3245 * w32font.c (w32font_draw): Return number of glyphs.
3246 (w32font_open_internal): Remove unused variable `i'.
3247 (w32font_driver): Add missing initializer.
3248
3249 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3250 (fill_in_menu): Remove unused variable `items_added'.
3251
3252 * w32term.c (last_mouse_press_frame): Remove static global variable.
3253 (w32_clip_to_row): Remove unused variable `f'.
3254 (x_delete_terminal): Remove unused variable `i'.
3255
3256 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3257 (NOTHING): Remove unused static global variable.
3258 (uniscribe_check_otf): Remove unused variable `table'.
3259 (uniscribe_font_driver): Add missing initializers.
3260
3261 2011-03-23 Julien Danjou <julien@danjou.info>
3262
3263 * term.c (Fsuspend_tty, Fresume_tty):
3264 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3265 * window.c (temp_output_buffer_show):
3266 * insdel.c (signal_before_change):
3267 * frame.c (Fhandle_switch_frame):
3268 * fileio.c (Fdo_auto_save):
3269 * emacs.c (Fkill_emacs):
3270 * editfns.c (save_excursion_restore):
3271 * cmds.c (internal_self_insert):
3272 * callint.c (Fcall_interactively):
3273 * buffer.c (Fkill_all_local_variables):
3274 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3275 Use Frun_hooks.
3276 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3277 unconditionnaly since it does the check itself.
3278
3279 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3280
3281 Fix more problems found by GCC 4.5.2's static checks.
3282
3283 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3284 the first time through the loop, since we know p0 < p1 then.
3285 This also avoids a gcc -Wstrict-overflow warning.
3286
3287 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3288 leading to a memory leak, possible in functions like
3289 load_charset_map_from_file that can allocate an unbounded number
3290 of objects (Bug#8318).
3291
3292 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3293 that could (at least in theory) be that large.
3294
3295 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3296 This is less likely to overflow, and avoids undefined behavior if
3297 overflow does occur. All callers changed. Use strtoul to scan
3298 for the unsigned long integer.
3299 (pint2hrstr): Simplify and tune code slightly.
3300 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3301
3302 * scroll.c (do_scrolling): Work around GCC bug 48228.
3303 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3304
3305 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3306 This also avoids a warning with gcc -Wstrict-overflow.
3307 (validate_x_resource_name): Simplify count usage.
3308 This also avoids a warning with gcc -Wstrict-overflow.
3309
3310 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3311 fail (Bug#8306).
3312
3313 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3314
3315 * process.c (Fmake_network_process): Use socklen_t, not int,
3316 where POSIX says socklen_t is required in portable programs.
3317 This fixes a porting bug on hosts like 64-bit HP-UX, where
3318 socklen_t is wider than int (Bug#8277).
3319 (Fmake_network_process, server_accept_connection):
3320 (wait_reading_process_output, read_process_output):
3321 Likewise.
3322
3323 * process.c: Rename or move locals to avoid shadowing.
3324 (list_processes_1, Fmake_network_process):
3325 (read_process_output_error_handler, exec_sentinel_error_handler):
3326 Rename or move locals.
3327 (Fmake_network_process): Define label "retry_connect" only if needed.
3328 (Fnetwork_interface_info): Fix pointer signedness.
3329 (process_send_signal): Add cast to avoid pointer signedness problem.
3330 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3331 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3332
3333 Make tparam.h and terminfo.c consistent.
3334 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3335 Include tparam.h instead, since it declares them.
3336 * cm.h (PC): Remove extern decl; tparam.h now does this.
3337 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3338 * terminfo.c: Include tparam.h, to check interfaces.
3339 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3340 (tparam): Adjust signature to match interface in tparam.h;
3341 this removes some undefined behavior. Check that outstring and len
3342 are zero, which they always are with Emacs.
3343 * tparam.h (PC, BC, UP): New extern decls.
3344
3345 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3346 (xftfont_open): Rename locals to avoid shadowing.
3347
3348 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3349 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3350 (OTF_TAG_SYM): Omit macro if not needed.
3351 (ftfont_list): Remove unused local.
3352 (get_adstyle_property, ftfont_pattern_entity):
3353 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3354 Rename locals to avoid shadowing.
3355
3356 * xfont.c (xfont_list_family): Mark var as initialized.
3357
3358 * xml.c (make_dom): Now static.
3359
3360 * composite.c (composition_compute_stop_pos): Rename local to
3361 avoid shadowing.
3362 (composition_reseat_it): Remove unused locals.
3363 (find_automatic_composition, composition_adjust_point): Likewise.
3364 (composition_update_it): Mark var as initialized.
3365 (find_automatic_composition): Mark vars as initialized,
3366 with a FIXME (Bug#8290).
3367
3368 character.h: Rename locals to avoid shadowing.
3369 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3370 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3371 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3372 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3373 to avoid shadowing.
3374
3375 * textprop.c (property_change_between_p): Remove; unused.
3376
3377 * intervals.c (interval_start_pos): Now static.
3378
3379 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3380
3381 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3382 Rename locals to avoid shadowing.
3383
3384 * sound.c (wav_play, au_play, Fplay_sound_internal):
3385 Fix pointer signedness.
3386 (alsa_choose_format): Remove unused local var.
3387 (wav_play): Initialize a variable to 0, to prevent undefined
3388 behavior (Bug#8278).
3389
3390 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3391
3392 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3393
3394 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3395 clobbering (Bug#8298).
3396 * sysdep.c (sys_subshell): Likewise.
3397 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3398
3399 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3400 This should get cleaned up, so that child_setup has the
3401 same signature on all platforms.
3402
3403 * callproc.c (call_process_cleanup): Now static.
3404 (relocate_fd): Rename locals to avoid shadowing.
3405
3406 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3407
3408 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3409 not to be necessary, and produces flickering.
3410
3411 2011-03-20 Glenn Morris <rgm@gnu.org>
3412
3413 * config.in: Remove file.
3414
3415 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3416
3417 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3418 are now in src/globals.h.
3419 (syms_of_minibuf): Remove spurious & from previous change.
3420
3421 2011-03-20 Leo <sdl.web@gmail.com>
3422
3423 * minibuf.c (completing-read-function): New variable.
3424 (completing-read-default): Rename from completing-read.
3425 (completing-read): Call completing-read-function.
3426
3427 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3428
3429 * xfaces.c (Fx_load_color_file):
3430 Read color file from absolute filename (bug#8250).
3431
3432 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3433
3434 * makefile.w32-in: Update dependencies.
3435
3436 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3437
3438 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3439
3440 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3441
3442 Fix more problems found by GCC 4.5.2's static checks.
3443
3444 * process.c (make_serial_process_unwind, send_process_trap):
3445 (sigchld_handler): Now static.
3446
3447 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3448 That way, the code declares only the vars that it needs.
3449 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3450 * s/cygwin.h (PTY_ITERATION): Likewise.
3451 * s/darwin.h (PTY_ITERATION): Likewise.
3452 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3453
3454 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3455 * process.c (allocate_pty): Don't declare stb unless it's needed.
3456
3457 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3458 (CONSTANTLIM): Remove; unused.
3459 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3460 Define only if needed.
3461
3462 * unexelf.c (unexec): Name an expression,
3463 to avoid gcc -Wbad-function-cast warning.
3464 Use a different way to cause a compilation error if anyone uses
3465 n rather than nn, a way that does not involve shadowing.
3466 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3467
3468 * deps.mk (unexalpha.o): Remove; unused.
3469
3470 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3471 * unexec.h: New file.
3472 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3473 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3474 Depend on unexec.h.
3475 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3476 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3477 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3478 Change as necessary to match prototype in unexec.h.
3479
3480 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3481 shadowing.
3482 (back_comment, skip_chars): Mark vars as initialized.
3483
3484 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3485 Rename locals to avoid shadowing.
3486
3487 * lread.c (read1): Rewrite so as not to use empty "else".
3488 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3489
3490 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3491
3492 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3493 warning when compiling print.c.
3494
3495 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3496 instead of using an uninitialized var.
3497 (font_sort_entities): Mark var as initialized.
3498
3499 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3500
3501 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3502 pointers to constants.
3503 (font_parse_fcname): Remove unused vars.
3504 (font_delete_unmatched): Now static.
3505 (font_get_spec): Remove; unused.
3506 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3507 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3508 Rename or move locals to avoid shadowing.
3509
3510 * fns.c (require_nesting_list, require_unwind): Now static.
3511 (Ffillarray): Rename locals to avoid shadowing.
3512
3513 * floatfns.c (domain_error2): Define only if needed.
3514 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3515
3516 * alloc.c (mark_backtrace): Move decl from here ...
3517 * lisp.h: ... to here, so that it can be checked.
3518
3519 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3520 (Fdefvar): Rewrite so as not to use empty "else".
3521 (lisp_indirect_variable): Name an expression,
3522 to avoid gcc -Wbad-function-cast warning.
3523 (Fdefvar): Rename locals to avoid shadowing.
3524
3525 * callint.c (quotify_arg, quotify_args): Now static.
3526 (Fcall_interactively): Rename locals to avoid shadowing.
3527 Use const pointer when appropriate.
3528
3529 * lisp.h (get_system_name, get_operating_system_release):
3530 Move decls here, to check interfaces.
3531 * process.c (get_operating_system_release): Move decl to lisp.h.
3532 * xrdb.c (get_system_name): Likewise.
3533 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3534 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3535 some of which prompt warnings from gcc -Wbad-function-cast.
3536 (Fformat_time_string, Fencode_time, Finsert_char):
3537 (Ftranslate_region_internal, Fformat):
3538 Rename or remove local vars to avoid shadowing.
3539 (Ftranslate_region_internal): Mark var as initialized.
3540
3541 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3542 avoid shadowing.
3543
3544 * lisp.h (eassert): Check that the argument compiles, even if
3545 ENABLE_CHECKING is not defined.
3546
3547 * data.c (Findirect_variable): Name an expression, to avoid
3548 gcc -Wbad-function-cast warning.
3549 (default_value, arithcompare, arith_driver, arith_error): Now static.
3550 (store_symval_forwarding): Rename local to avoid shadowing.
3551 (Fmake_variable_buffer_local, Fmake_local_variable):
3552 Mark variables as initialized.
3553 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3554
3555 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3556 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3557 Rename locals to avoid shadowing.
3558 (mark_stack): Move local variables into the #ifdef region where
3559 they're used.
3560 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3561 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3562 needed otherwise.
3563 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3564 (GC_STRING_CHARS): Remove; not used.
3565 (Fmemory_limit): Cast sbrk's returned value to char *.
3566
3567 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3568 avoids undefined behavior in theory.
3569
3570 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3571
3572 Use functions, not macros, for up- and down-casing (Bug#8254).
3573 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3574 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3575 to use the following functions instead of these macros.
3576 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3577 EMACS_INT, since callers assume the returned value fits in int.
3578 (upcase1): Likewise, for UPCASE_TABLE.
3579 (uppercasep, lowercasep, upcase): New static inline functions.
3580 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3581 the race-condition problem in the old DOWNCASE.
3582
3583 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3584 Rename locals to avoid shadowing.
3585 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3586 (regex_compile, re_search_2, re_match_2_internal):
3587 Remove unused local vars.
3588 (FREE_VAR): Rewrite so as not to use empty "else",
3589 which gcc can warn about.
3590 (regex_compile, re_match_2_internal): Mark locals as initialized.
3591 (RETALLOC_IF): Define only if needed.
3592 (WORDCHAR_P): Likewise. This one is never needed, but is used
3593 only in a comment talking about a compiler bug, so put inside
3594 the #if 0 of that comment.
3595 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3596 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3597 Remove; unused.
3598
3599 * search.c (boyer_moore): Rename locals to avoid shadowing.
3600 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3601 (PREV_CHAR_BOUNDARY): Likewise.
3602
3603 * search.c (simple_search): Remove unused var.
3604
3605 * dired.c (compile_pattern): Move decl from here ...
3606 * lisp.h: ... to here, so that it can be checked.
3607 (struct re_registers): New forward decl.
3608
3609 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3610
3611 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3612 All uses changed.
3613 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3614 Rename locals to avoid shadowing.
3615 (Fvertical_motion): Mark locals as initialized.
3616
3617 * casefiddle.c (casify_object, casify_region): Now static.
3618 (casify_region): Mark local as initialized.
3619
3620 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3621
3622 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3623 New macros, so that the caller can use some names other than
3624 gcpro1, gcpro2, etc.
3625 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3626 of the new macros.
3627 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3628 argument, for consistency with GCPRO2_VAR, etc: it is now the
3629 prefix of the variable, not the variable itself. All uses
3630 changed.
3631 * dired.c (directory_files_internal, file_name_completion):
3632 Rename locals to avoid shadowing.
3633
3634 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3635 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3636 dired.c's scmp function, had undefined behavior.
3637 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3638 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3639 * buffer.h: ... to here, because these macros use current_buffer,
3640 and the new implementation with inline functions needs to have
3641 current_buffer in scope now, rather than later when the macros
3642 are used.
3643 (downcase, upcase1): New static inline functions.
3644 (DOWNCASE, UPCASE1): Reimplement using these functions.
3645 This avoids undefined behavior in expressions like
3646 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3647 from race conditions in accessing the global variables
3648 case_temp1 and case_temp2.
3649 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3650 * lisp.h (case_temp1, case_temp2): Remove their decls.
3651 * character.h (ASCII_CHAR_P): Move from here ...
3652 * lisp.h: ... to here, so that the inline functions mentioned
3653 above can use them.
3654
3655 * dired.c (directory_files_internal_unwind): Now static.
3656
3657 * fileio.c (file_name_as_directory, directory_file_name):
3658 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3659 Now static.
3660 (file_name_as_directory): Use const pointers when appropriate.
3661 (Fexpand_file_name): Likewise. In particular, newdir might
3662 point at constant storage, so make it a const pointer.
3663 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3664 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3665 signedness issues.
3666 (Fset_file_times, Finsert_file_contents, auto_save_error):
3667 Rename locals to avoid shadowing.
3668
3669 * minibuf.c (choose_minibuf_frame_1): Now static.
3670 (Ftry_completion, Fall_completions): Rename or remove locals
3671 to avoid shadowing.
3672
3673 * marker.c (bytepos_to_charpos): Remove; unused.
3674
3675 * lisp.h (verify_bytepos, count_markers): New decls,
3676 so that gcc does not warn that these functions aren't declared.
3677
3678 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3679 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3680 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3681 (copy_text): Remove unused local var.
3682
3683 * filelock.c (within_one_second): Now static.
3684 (lock_file_1): Rename local to avoid shadowing.
3685
3686 * buffer.c (fix_overlays_before): Mark locals as initialized.
3687 (fix_start_end_in_overlays): Likewise. This function should be
3688 simplified by using pointers-to-pointers, but that's a different
3689 matter.
3690 (switch_to_buffer_1): Now static.
3691 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3692 (report_overlay_modification): Rename locals to avoid shadowing.
3693
3694 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3695 Fix pointer signedness issue.
3696 (sys_subshell): Mark local as volatile if checking for lint,
3697 to suppress a gcc -Wclobbered warning that does not seem to be right.
3698 (MAXPATHLEN): Define only if needed.
3699
3700 * process.c (serial_open, serial_configure): Move decls from here ...
3701 * systty.h: ... to here, so that they can be checked.
3702
3703 * fns.c (get_random, seed_random): Move extern decls from here ...
3704 * lisp.h: ... to here, so that they can be checked.
3705
3706 * sysdep.c (reset_io): Now static.
3707 (wait_for_termination_signal): Remove; unused.
3708
3709 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3710 (copy_keymap_item, append_key, push_text_char_description):
3711 Now static.
3712 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3713 (DENSE_TABLE_SIZE): Remove; unused.
3714 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3715 (describe_map_tree):
3716 Rename locals to avoid shadowing.
3717
3718 * keyboard.c: Declare functions static if they are not used elsewhere.
3719 (echo_char, echo_dash, cmd_error, top_level_2):
3720 (poll_for_input, handle_async_input): Now static.
3721 (read_char, kbd_buffer_get_event, make_lispy_position):
3722 (make_lispy_event, make_lispy_movement, apply_modifiers):
3723 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3724 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3725 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3726 (read_key_sequence, read_char): Mark locals as initialized.
3727 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3728
3729 * keyboard.h (make_ctrl_char): New decl.
3730 (mark_kboards): Move decl here ...
3731 * alloc.c (mark_kboards): ... from here.
3732
3733 * lisp.h (force_auto_save_soon): New decl.
3734
3735 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3736 (DEFINE_DUMMY_FUNCTION): New macro.
3737 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3738 Use it.
3739 (main): Add casts to avoid warnings
3740 if GCC considers string literals to be constants.
3741
3742 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3743
3744 * dbusbind.c: Pointer signedness fixes.
3745 (xd_signature, xd_append_arg, xd_initialize):
3746 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3747 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3748 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3749 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3750
3751 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3752 if GCC considers string literals to be constants.
3753 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3754
3755 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3756
3757 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3758 (print_preprocess, print_object): New macro to fix last change.
3759
3760 * print.c (print_preprocess): Don't forget font objects.
3761
3762 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3763
3764 * emacs.c (USAGE3): Doc fixes.
3765
3766 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3767
3768 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3769 structure.
3770
3771 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3772
3773 * lisp.h (VWindow_system, Qfile_name_history):
3774 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3775 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3776 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3777
3778 * w32select.c: Don't #include "keyboard.h".
3779 (run_protected): Add extern declaration for waiting_for_input.
3780
3781 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3782 * w32console.c (detect_input_pending, read_input_pending)
3783 (encode_terminal_code):
3784 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3785 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3786 (w32_system_caret_y, Qfile_name_history):
3787 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3788 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3789 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3790 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3791 * w32proc.c (Qlocal, report_file_error):
3792 * w32term.c (Vwindow_system, updating_frame):
3793 * w32uniscribe.c (initialized, uniscribe_font_driver):
3794 Remove unneeded extern declarations.
3795
3796 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3797
3798 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3799
3800 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3801
3802 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3803 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3804 These macros can no longer be used for assignment.
3805
3806 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3807 Assign struct members directly, instead of using BUF_BEGV etc.
3808 (record_buffer_markers, fetch_buffer_markers): New functions for
3809 recording and fetching special buffer markers.
3810 (set_buffer_internal_1, set_buffer_temp): Use them.
3811
3812 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3813
3814 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3815
3816 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3817 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3818
3819 * xdisp.c (hscroll_window_tree):
3820 (reconsider_clip_changes): Use PT instead of BUF_PT.
3821
3822 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3823
3824 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3825 $(EMACS_ROOT)/lib/intprops.h.
3826
3827 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3828
3829 Fix more problems found by GCC 4.5.2's static checks.
3830
3831 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3832 to unsigned char * to avoid compiler diagnostic.
3833 (xg_free_frame_widgets): Make it clear that a local variable is
3834 needed only if USE_GTK_TOOLTIP.
3835 (gdk_window_get_screen): Make it clear that this macro is needed
3836 only if USE_GTK_TOOLTIP.
3837 (int_gtk_range_get_value): New function, which avoids a diagnostic
3838 from gcc -Wbad-function-cast.
3839 (xg_set_toolkit_scroll_bar_thumb): Use it.
3840 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3841 diagnostic from gcc -Wbad-function-cast.
3842 (get_utf8_string, xg_get_file_with_chooser):
3843 Rename locals to avoid shadowing.
3844 (create_dialog): Move locals to avoid shadowing.
3845
3846 * xgselect.c (xg_select): Remove unused var.
3847
3848 * image.c (four_corners_best): Mark locals as initialized.
3849 (gif_load): Initialize transparent_p to zero (Bug#8238).
3850 Mark another local as initialized.
3851 (my_png_error, my_error_exit): Mark with NO_RETURN.
3852
3853 * image.c (clear_image_cache): Now static.
3854 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3855 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3856 (x_edge_detection): Remove unnecessary cast that
3857 gcc -Wbad-function-cast diagnoses.
3858 (gif_load): Fix pointer signedness.
3859 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3860 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3861
3862 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3863
3864 Improve quality of tests for time stamp overflow.
3865 For example, without this patch (encode-time 0 0 0 1 1
3866 1152921504606846976) returns the obviously-bogus value (-948597
3867 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3868 reports time overflow. See
3869 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3870 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3871 * editfns.c: Include limits.h and intprops.h.
3872 (TIME_T_MIN, TIME_T_MAX): New macros.
3873 (time_overflow): Move earlier, to before first use.
3874 (hi_time, lo_time): New functions, for an accurate test for
3875 out-of-range times.
3876 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3877 (Fget_internal_run_time): Don't assume time_t fits in int.
3878 (make_time): Use list2 instead of Fcons twice.
3879 (Fdecode_time): More accurate test for out-of-range times.
3880 (check_tm_member): New function.
3881 (Fencode_time): Use it, to test for out-of-range times.
3882 (lisp_time_argument): Don't rely on undefined left-shift and
3883 right-shift behavior when checking for time stamp overflow.
3884
3885 * editfns.c (time_overflow): New function, refactoring common code.
3886 (Fformat_time_string, Fdecode_time, Fencode_time):
3887 (Fcurrent_time_string): Use it.
3888
3889 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3890 * dired.c (make_time): Move to ...
3891 * editfns.c (make_time): ... here.
3892 * systime.h: Note the move.
3893
3894 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3895
3896 * fringe.c (update_window_fringes): Remove unused variables.
3897
3898 * unexmacosx.c (copy_data_segment): Also copy __got section.
3899 (Bug#8223)
3900
3901 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3902
3903 * termcap.c [MSDOS]: Include "msdos.h".
3904 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3905 Constify `char *' arguments and their references according to
3906 prototypes in tparam.h.
3907
3908 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3909
3910 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3911 Adapt all references accordingly.
3912
3913 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3914
3915 2011-03-11 Tom Tromey <tromey@redhat.com>
3916
3917 * buffer.c (syms_of_buffer): Remove obsolete comment.
3918
3919 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3920
3921 * termhooks.h (encode_terminal_code): Declare prototype.
3922
3923 * msdos.c (encode_terminal_code): Don't declare prototype.
3924
3925 * term.c (encode_terminal_code): Now external again, used by
3926 w32console.c and msdos.c.
3927
3928 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3929 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3930
3931 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3932
3933 Fix some minor problems found by GCC 4.5.2's static checks.
3934
3935 * fringe.c (update_window_fringes): Mark locals as initialized
3936 (Bug#8227).
3937 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3938
3939 * alloc.c (mark_fringe_data): Move decl from here ...
3940 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3941 to check its interface.
3942 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3943
3944 * fontset.c (free_realized_fontset): Now static.
3945 (Fset_fontset_font): Rename local to avoid shadowing.
3946 (fontset_font): Mark local as initialized.
3947 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3948
3949 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3950
3951 * xselect.c (x_disown_buffer_selections): Remove; not used.
3952 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3953 (x_own_selection, Fx_disown_selection_internal): Rename locals
3954 to avoid shadowing.
3955 (x_handle_dnd_message): Remove local to avoid shadowing.
3956
3957 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3958 so that the caller can use some name other than gcpro1.
3959 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3960 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3961 (Fx_backspace_delete_keys_p):
3962 Use them to avoid shadowing, and rename vars to avoid shadowing.
3963 (x_decode_color, x_set_name, x_window): Now static.
3964 (Fx_create_frame): Add braces to silence GCC warning.
3965 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3966 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3967 Remove unused locals.
3968 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3969 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3970 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3971 macros.
3972
3973 * xterm.h (x_mouse_leave): New decl.
3974
3975 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3976 Remove unused functions.
3977 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3978 (x_calc_absolute_position): Now static.
3979 (XTread_socket): Don't define label "out" unless it's used.
3980 Don't declare local "event" unless it's used.
3981 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3982 unless they are used.
3983 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3984 (x_fatal_error_signal): Remove; not used.
3985 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3986 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3987 (x_error_catcher, x_connection_closed, x_error_handler):
3988 (x_error_quitter, xembed_send_message, x_iconify_frame):
3989 (my_log_handler): Rename locals to avoid shadowing.
3990 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3991 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3992
3993 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3994 Rename or move locals to avoid shadowing.
3995 (tty_defined_color, merge_face_heights): Now static.
3996 (free_realized_faces_for_fontset): Remove; not used.
3997 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3998 does not deduce is never used uninitialized.
3999 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4000 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4001
4002 * terminal.c (store_terminal_param): Now static.
4003
4004 * xmenu.c (menu_highlight_callback): Now static.
4005 (set_frame_menubar): Remove unused local.
4006 (xmenu_show): Rename parameter to avoid shadowing.
4007 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4008 since they might point to immutable storage.
4009 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4010 since it's unused otherwise.
4011
4012 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4013 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4014 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4015 avoids a gcc -Wuninitialized diagnostic.
4016 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4017 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4018 does not deduce are never used uninitialized.
4019
4020 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4021
4022 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4023 * window.c (window_loop, size_window):
4024 (run_window_configuration_change_hook, enlarge_window): Likewise.
4025
4026 * window.c (display_buffer): Now static.
4027 (size_window): Mark variables that gcc -Wuninitialized
4028 does not deduce are never used uninitialized.
4029 * window.h (check_all_windows): New decl, to forestall
4030 gcc -Wmissing-prototypes diagnostic.
4031 * dispextern.h (bidi_dump_cached_states): Likewise.
4032
4033 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4034 shadowing.
4035 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4036 Include <limits.h>.
4037 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4038 and to avoid gcc -Wuninitialized warning.
4039 (load_charset_map): Mark variables that gcc -Wuninitialized
4040 does not deduce are never used uninitialized.
4041 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4042
4043 * coding.c (coding_set_source, coding_set_destination):
4044 Use "else { /* comment */ }" rather than "else /* comment */;"
4045 for clarity, and to avoid gcc -Wempty-body warning.
4046 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4047 a block, when the outer 'i' will do.
4048 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4049 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4050 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4051 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4052 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4053 Rename locals to avoid shadowing.
4054 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4055 * coding.c (emacs_mule_char, encode_invocation_designation):
4056 Now static, since they're not used elsewhere.
4057 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4058 (decode_coding_object, encode_coding_object, detect_coding_system):
4059 (decode_coding_emacs_mule): Mark variables that gcc
4060 -Wuninitialized does not deduce are never used uninitialized.
4061 (detect_coding_iso_2022): Initialize a local variable that might
4062 be used uninitialized. Leave a FIXME because it's not clear that
4063 this initialization is needed. (Bug#8211)
4064 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4065 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4066 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4067 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4068 Remove unused macros.
4069
4070 * category.c (hash_get_category_set): Remove unused local var.
4071 (copy_category_table): Now static, since it's not used elsewhere.
4072 * character.c (string_count_byte8): Likewise.
4073
4074 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4075 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4076
4077 * chartab.c (copy_sub_char_table): Now static, since it's not used
4078 elsewhere.
4079 (sub_char_table_ref_and_range, char_table_ref_and_range):
4080 Rename locals to avoid shadowing.
4081 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4082
4083 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4084 (BIDI_BOB): Remove unused macro.
4085
4086 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4087 deduce are never used uninitialized.
4088 * term.c (encode_terminal_code): Likewise.
4089
4090 * term.c (encode_terminal_code): Now static. Remove unused local.
4091
4092 * tparam.h: New file.
4093 * term.c, tparam.h: Include it.
4094 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4095 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4096 Move these decls to tparam.h, and make them agree with what
4097 is actually in tparam.c. The previous trick of using incompatible
4098 decls in different modules does not conform to the C standard.
4099 All callers of tparam changed to use tparam's actual API.
4100 * tparam.c (tparam1, tparam, tgoto):
4101 Use const pointers where appropriate.
4102
4103 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4104 * cm.h (struct cm): Likewise.
4105 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4106 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4107 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4108 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4109 (turn_on_face, init_tty): Likewise.
4110 * termchar.h (struct tty_display_info): Likewise.
4111
4112 * term.c (term_mouse_position): Rename local to avoid shadowing.
4113
4114 * alloc.c (mark_ttys): Move decl from here ...
4115 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4116
4117 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4118
4119 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4120
4121 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4122
4123 * search.c (compile_pattern_1): Remove argument regp, unused since
4124 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4125 (compile_pattern): Don't pass it.
4126
4127 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4128
4129 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4130 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4131 for ! HAVE_GTK3.
4132 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4133
4134 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4135
4136 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4137 gdk_window_get_screen, gdk_window_get_geometry,
4138 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4139 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4140 (xg_get_pixbuf_from_pixmap): New function.
4141 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4142 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4143 Call xg_get_pixbuf_from_pixmap instead of
4144 gdk_pixbuf_get_from_drawable.
4145 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4146 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4147 (xg_check_special_colors): Use GtkStyleContext and its functions
4148 for HAVE_GTK3.
4149 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4150 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4151 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4152 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4153 Call gtk_widget_get_preferred_size.
4154 (xg_frame_resized): gdk_window_get_geometry only takes 5
4155 parameters.
4156 (xg_win_to_widget, xg_event_is_for_menubar):
4157 Call gdk_x11_window_lookup_for_display.
4158 (xg_set_widget_bg): New function.
4159 (delete_cb): New function.
4160 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4161 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4162 (xg_set_background_color): Call xg_set_widget_bg.
4163 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4164 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4165 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4166 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4167 if ! HAVE_GTK3.
4168 (update_frame_tool_bar): Call gtk_widget_hide.
4169 (xg_initialize): Use GDK_KEY_g.
4170
4171 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4172 if ! HAVE_GTK3
4173 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4174
4175 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4176 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4177 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4178
4179 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4180
4181 * w32xfns.c (select_palette): Check success of RealizePalette against
4182 GDI_ERROR, not zero.
4183
4184 See ChangeLog.11 for earlier changes.
4185
4186 ;; Local Variables:
4187 ;; coding: utf-8
4188 ;; End:
4189
4190 Copyright (C) 2011 Free Software Foundation, Inc.
4191
4192 This file is part of GNU Emacs.
4193
4194 GNU Emacs is free software: you can redistribute it and/or modify
4195 it under the terms of the GNU General Public License as published by
4196 the Free Software Foundation, either version 3 of the License, or
4197 (at your option) any later version.
4198
4199 GNU Emacs is distributed in the hope that it will be useful,
4200 but WITHOUT ANY WARRANTY; without even the implied warranty of
4201 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4202 GNU General Public License for more details.
4203
4204 You should have received a copy of the GNU General Public License
4205 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.