In GDB scripts, don't assume that EMACS_INT fits in long.
[bpt/emacs.git] / src / ChangeLog
1 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2
3 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4 when computing $valmask.
5
6 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
7 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
8 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
9 It's useless in that case, and it can cause problems on hosts
10 that allocate halves of EMACS_INT values separately.
11 Reported by Dan Horák. Diagnosed by Andreas Schwab in
12 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
13 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
14 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
15 it avoids undefined behavior on hosts where shifting right by more
16 than the word width has undefined behavior.
17
18 2012-02-19 Chong Yidong <cyd@gnu.org>
19
20 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
21 (Funhandled_file_name_directory, Ffile_name_as_directory)
22 (Fdirectory_file_name, Fexpand_file_name)
23 (Fsubstitute_in_file_name): Protect against invalid file handler
24 return values (Bug#10845).
25
26 2012-02-18 Eli Zaretskii <eliz@gnu.org>
27
28 * .gdbinit (pitx): Fix incorrect references to fields of the
29 iterator stack.
30
31 2012-02-17 Chong Yidong <cyd@gnu.org>
32
33 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
34
35 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
36
37 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
38 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
39
40 2012-02-15 Chong Yidong <cyd@gnu.org>
41
42 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
43 marked as special. Also, starting docstrings with * is obsolete.
44
45 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
46
47 * gnutls.c (emacs_gnutls_write): Fix last change.
48
49 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
50
51 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
52 send_process.
53
54 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
55
56 * keymap.c (Fsingle_key_description): Handle char ranges.
57
58 2012-02-12 Chong Yidong <cyd@gnu.org>
59
60 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
61 as that creates a dangerous corner case.
62
63 * window.c (Fdelete_window_internal): Invalidate the mouse
64 highlight (Bug#9904).
65
66 2012-02-12 Glenn Morris <rgm@gnu.org>
67
68 * xselect.c (Fx_own_selection_internal)
69 (Fx_get_selection_internal, Fx_disown_selection_internal)
70 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
71 * nsselect.m (Fx_own_selection_internal)
72 (Fx_disown_selection_internal, Fx_selection_exists_p)
73 (Fx_selection_owner_p, Fx_get_selection_internal):
74 Sync docs and argument specs with the xselect.c versions.
75
76 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
77
78 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
79
80 2012-02-11 Eli Zaretskii <eliz@gnu.org>
81
82 * w32select.c (Fx_selection_exists_p): Sync doc string and
83 argument list with xselect.c. (Bug#10783)
84
85 * w16select.c (Fx_selection_exists_p): Sync doc string and
86 argument list with xselect.c. (Bug#10783)
87
88 2012-02-10 Glenn Morris <rgm@gnu.org>
89
90 * fns.c (Fsecure_hash): Doc fix.
91
92 2012-02-09 Kenichi Handa <handa@m17n.org>
93
94 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
95
96 2012-02-07 Chong Yidong <cyd@gnu.org>
97
98 * buffer.c (Fbuffer_local_variables)
99 (buffer_lisp_local_variables): Handle unbound vars correctly;
100 don't let Qunbound leak into Lisp.
101
102 2012-02-07 Glenn Morris <rgm@gnu.org>
103
104 * image.c (Fimagemagick_types): Doc fix.
105
106 * image.c (imagemagick-render-type): Change it from a lisp object
107 to an integer. Move the doc here from the lisp manual.
108 Treat all values not equal to 0 the same.
109
110 2012-02-06 Chong Yidong <cyd@gnu.org>
111
112 * doc.c (store_function_docstring): Avoid applying docstring of
113 alias to base function (Bug#2603).
114
115 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
116
117 * .gdbinit (pp1, pv1): Remove redundant defines.
118 (pr): Use pp.
119
120 2012-02-04 Chong Yidong <cyd@gnu.org>
121
122 * nsterm.m: Declare a global (Bug#10694).
123
124 2012-02-04 Eli Zaretskii <eliz@gnu.org>
125
126 * w32.c (get_emacs_configuration_options): Include
127 --enable-checking, if specified, in the return value.
128
129 2012-02-04 Martin Rudalics <rudalics@gmx.at>
130
131 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
132 after rounding frame sizes. (Bug#9723)
133
134 2012-02-04 Eli Zaretskii <eliz@gnu.org>
135
136 * keyboard.c (adjust_point_for_property): Don't position point
137 before BEGV. (Bug#10696)
138
139 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
140
141 Handle overflow when computing char display width (Bug#9496).
142 * character.c (char_width): Return EMACS_INT, not int.
143 (char_width, c_string_width): Check for overflow when
144 computing the width; this is possible now that individual
145 characters can have unbounded width. Problem introduced
146 by merge from Emacs 23 on 2012-01-19.
147
148 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
149
150 * dbusbind.c (Fdbus_register_method): Mention the return value
151 :ignore in the docstring.
152
153 2012-02-02 Glenn Morris <rgm@gnu.org>
154
155 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
156
157 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
158 Unconditionally set to t. (Bug#10673)
159 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
160 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
161 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
162
163 2012-02-02 Kenichi Handa <handa@m17n.org>
164
165 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
166 0, do not call append_composite_glyph.
167
168 2012-02-02 Kenichi Handa <handa@m17n.org>
169
170 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
171 NULL (Bug#6988).
172 (x_produce_glyphs): If the component of a composition is a null
173 string, set it->pixel_width to 1 to avoid zero-width glyph.
174
175 2012-02-01 Eli Zaretskii <eliz@gnu.org>
176
177 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
178 first 2 arguments are identical. This makes inserting large
179 output from a subprocess an order of magnitude faster on
180 MS-Windows, where all sbrk'ed memory is always contiguous.
181
182 2012-01-31 Glenn Morris <rgm@gnu.org>
183
184 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
185 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
186 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
187
188 2012-01-29 Glenn Morris <rgm@gnu.org>
189
190 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
191
192 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
193
194 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
195
196 2012-01-28 Chong Yidong <cyd@gnu.org>
197
198 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
199
200 2012-01-26 Chong Yidong <cyd@gnu.org>
201
202 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
203
204 * search.c (Fsearch_forward, Fsearch_backward): Document negative
205 repeat counts (Bug#10507).
206
207 2012-01-26 Glenn Morris <rgm@gnu.org>
208
209 * lread.c (syms_of_lread): Doc fix.
210
211 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
212
213 * coding.c (encode_designation_at_bol): Change return value to
214 EMACS_INT.
215
216 2012-01-25 Chong Yidong <cyd@gnu.org>
217
218 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
219
220 2012-01-21 Chong Yidong <cyd@gnu.org>
221
222 * floatfns.c (Fcopysign): Make the second argument non-optional,
223 since nil is not allowed anyway.
224
225 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
226
227 * process.c (read_process_output): Use p instead of XPROCESS (proc).
228 (send_process): Likewise.
229
230 2012-01-19 Martin Rudalics <rudalics@gmx.at>
231
232 * window.c (save_window_save, Fcurrent_window_configuration)
233 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
234 doc-strings.
235
236 2012-01-19 Kenichi Handa <handa@m17n.org>
237
238 * character.c (char_width): New function.
239 (Fchar_width, c_string_width, lisp_string_width):
240 Use char_width (Bug#9496).
241
242 2012-01-16 Martin Rudalics <rudalics@gmx.at>
243
244 * window.c (Vwindow_persistent_parameters): New variable.
245 (Fset_window_configuration, save_window_save): Handle persistent
246 window parameters.
247
248 2012-01-14 Eli Zaretskii <eliz@gnu.org>
249
250 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
251 thrashing the stack of the thread. (Bug#9087)
252
253 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
254
255 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
256
257 2012-01-11 Eli Zaretskii <eliz@gnu.org>
258
259 * xdisp.c (rows_from_pos_range): Handle the case where the
260 highlight ends on a newline. (Bug#10464)
261 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
262 he end column for display of highlight that ends on a newline
263 before a R2L line.
264
265 2012-01-11 Glenn Morris <rgm@gnu.org>
266
267 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
268 from load-path also when installation-directory is nil. (Bug#10208)
269
270 2012-01-10 Glenn Morris <rgm@gnu.org>
271
272 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
273
274 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
275 Update template values to be closer to their typical values these days.
276
277 2012-01-09 Eli Zaretskii <eliz@gnu.org>
278
279 * xdisp.c (rows_from_pos_range): Accept additional argument
280 DISP_STRING, and accept any glyph in a row whose object is that
281 string as eligible for mouse highlight. Fixes mouse highlight of
282 display strings from overlays. (Bug#10464)
283
284 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
285
286 emacs: fix an auto-save permissions race condition (Bug#10400)
287 * fileio.c (auto_saving_dir_umask): New static var.
288 (Fmake_directory_internal): Use it.
289 (do_auto_save_make_dir): Set it, instead of invoking chmod after
290 creating the directory. The old code temporarily assigns
291 too-generous permissions to the directory.
292 (do_auto_save_eh): Clear it.
293 (Fdo_auto_save): Catch all errors, not just file errors, so
294 that the var is always cleared.
295
296 2012-01-07 Eli Zaretskii <eliz@gnu.org>
297
298 * search.c (scan_buffer): Pass character positions to
299 know_region_cache, not byte positions. (Bug#6540)
300
301 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
302
303 * w32.c (sys_rename): Report EXDEV when rename of a directory
304 fails because the target is on another logical disk. (Bug#10284)
305
306 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
307
308 * xterm.c (x_embed_request_focus): New function.
309
310 * xterm.h: Add prototype.
311
312 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
313
314 2012-01-05 Glenn Morris <rgm@gnu.org>
315
316 * emacs.c (emacs_copyright): Update short copyright year to 2012.
317
318 2012-01-01 Eli Zaretskii <eliz@gnu.org>
319
320 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
321 Load gnutls_transport_set_lowat only if GnuTLS version is below
322 2.11.1.
323 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
324 GnuTLS versions below 2.11.1.
325
326 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
327
328 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
329 to the doc string advising against its use for altering the way
330 windows are scrolled.
331
332 2011-12-28 Kenichi Handa <handa@m17n.org>
333
334 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
335 coding-system ASCII compatible only when it does not produce BOM
336 on encoding (Bug#10383).
337
338 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
339
340 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
341 can scroll.
342 (create_and_show_popup_menu): Always use menu_position_func for
343 Gtk3 (Bug#10361).
344
345 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
346
347 * callint.c (Fcall_interactively): Don't truncate prompt string.
348
349 2011-12-23 Eli Zaretskii <eliz@gnu.org>
350
351 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
352 property that ends at ZV, so that the bidi iteration could be
353 resumed from there (after widening). (Bug#10360)
354
355 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
356
357 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
358
359 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
360
361 * nsterm.m (x_free_frame_resources):
362 Release f->output_data.ns->miniimage.
363 (ns_index_color): Fix indentation. Do not retain
364 color_table->colors[i].
365
366 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
367 before returning.
368
369 * nsfns.m (x_set_background_color): Assign return value from
370 ns_index_color to face-background instead of NSColor*.
371 (ns_implicitly_set_icon_type): Fix indentation.
372 Change assignment in for loop to comparison.
373
374 * emacs.c (ns_pool): New variable.
375 (main): Assign ns_pool.
376 (Fkill_emacs): Call ns_release_autorelease_pool.
377
378 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
379 autorelease fdesc, release fdAttrs and tdict.
380 (ns_get_covering_families): Release charset.
381 (ns_findfonts): Release NSFontDescriptor created with new.
382 (ns_uni_to_glyphs): Fix indentation.
383 (setString): Release attrStr before assigning new value.
384
385 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
386
387 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
388 and NS_IMPL_COCOA.
389 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
390 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
391
392 2011-12-18 David Reitter <reitter@cmu.edu>
393
394 * nsterm.m (ns_term_init): Subscribe for notifications
395 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
396 to method trackingNotification in EmacsMenu.
397
398 * nsmenu.m (trackingMenu): New variable.
399 (trackingNotification): New method (from Aquamacs).
400 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
401 from Aquamacs (Bug#7030).
402
403 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
404
405 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
406 (symbol_to_nsstring): Fix indentation.
407 (ns_symbol_to_pb): New function.
408 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
409 (Fns_rotate_cut_buffers_internal): Removed.
410 (Fns_store_selection_internal): Renamed from
411 Fns_store_cut_buffer_internal.
412 (ns_get_foreign_selection, Fx_own_selection_internal)
413 (Fx_disown_selection_internal, Fx_selection_exists_p)
414 (Fns_get_selection_internal, Fns_store_selection_internal):
415 Use ns_symbol_to_pb and check if return value is nil.
416 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
417 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
418 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
419 renamed to Sns_store_selection_internal.
420 (ns_handle_selection_request): Move code to Fx_own_selection_internal
421 and remove this function.
422 (ns_handle_selection_clear): Remove, never used.
423 (Fx_own_selection_internal): Move code from ns_handle_selection_request
424 here.
425
426 2011-12-17 Ken Brown <kbrown@cornell.edu>
427
428 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
429 GID is unknown (Bug#10257).
430
431 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
432
433 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
434 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
435 which caused a build failure on GNU/Linux IA-64. This problem was
436 introduced by my 2011-10-07 patch.
437
438 2011-12-15 Juri Linkov <juri@jurta.org>
439
440 * image.c (imagemagick_error): New function. (Bug#10112)
441 (imagemagick_load_image): Comment out `MagickSetResolution' call.
442 Use `imagemagick_error' where ImageMagick functions return
443 `MagickFalse'.
444 (Fimagemagick_types): Add `Fnreverse' to return the list in the
445 proper order.
446
447 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
448
449 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
450 fill background (Bug#8992).
451
452 2011-12-13 Martin Rudalics <rudalics@gmx.at>
453
454 * window.c (Vwindow_combination_resize)
455 (Vwindow_combination_limit): Use t instead of non-nil in
456 doc-strings.
457 (Vrecenter_redisplay): Add first sentence of doc-string on
458 separate line.
459 (Frecenter): Fix doc-string typo.
460
461 2011-12-11 Kenichi Handa <handa@m17n.org>
462
463 * coding.c (Funencodable_char_position): Pay attention to the
464 buffer text relocation (Bug#9389).
465
466 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
467
468 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
469 gtk_init (Bug#10100).
470
471 2011-12-10 Eli Zaretskii <eliz@gnu.org>
472
473 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
474 IT->string is nil. (Bug#10263)
475
476 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
477
478 * nsterm.h (x_free_frame_resources): Declare.
479
480 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
481 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
482
483 * nsterm.h (ns_get_defaults_value): Declare.
484
485 * nsterm.m (ns_default): Call ns_get_defaults_value.
486
487 2011-12-09 Eli Zaretskii <eliz@gnu.org>
488
489 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
490 (Bug#10170)
491
492 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
493
494 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
495 that where the value of an _OBJC_* symbol points to is in the .bss
496 section (Bug#10240).
497
498 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
499
500 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
501 after the loop to call ccl_driver at least once (Bug#8619).
502
503 2011-12-08 Kenichi Handa <handa@m17n.org>
504
505 * ftfont.c (get_adstyle_property): Fix previous change
506 (Bug#10233).
507
508 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
509
510 * w32.c (init_environment): If no_site_lisp, remove site-lisp
511 dirs from the default value of EMACSLOADPATH (bug#10208).
512
513 2011-12-07 Glenn Morris <rgm@gnu.org>
514
515 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
516 installation and source directories as well. (Bug#10208)
517
518 2011-12-06 Chong Yidong <cyd@gnu.org>
519
520 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
521
522 2011-12-06 Glenn Morris <rgm@gnu.org>
523
524 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
525 as an error, not just -1. (Bug#10217)
526
527 2011-12-05 Chong Yidong <cyd@gnu.org>
528
529 * keyboard.c (process_special_events): New function.
530 (swallow_events, Finput_pending_p): Use it (Bug#10195).
531
532 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
533
534 * coding.c (encode_designation_at_bol): Don't use uninitialized
535 local variable (Bug#9318).
536
537 2011-12-05 Kenichi Handa <handa@m17n.org>
538
539 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
540 return Qnil (Bug#8046, Bug#10193).
541
542 2011-12-05 Kenichi Handa <handa@m17n.org>
543
544 * coding.c (encode_designation_at_bol): New args charbuf_end and
545 dst. Return the number of produced bytes. Callers changed.
546 (coding_set_source): Return how many bytes coding->source was
547 relocated.
548 (coding_set_destination): Return how many bytes
549 coding->destination was relocated.
550 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
551 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
552
553 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
554
555 * coding.c (CODING_CHAR_CHARSET_P): New macro.
556 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
557 macro (Bug#9318).
558
559 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
560
561 The following changes are to fix Bug#9318.
562
563 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
564 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
565 (encode_coding_iso_2022, encode_coding_sjis)
566 (encode_coding_big5, encode_coding_charset): Use the above macros.
567
568 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
569
570 * lisp.h (process_quit_flag): Fix external declaration.
571
572 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
573
574 Don't macro-inline non-performance-critical code.
575 * eval.c (process_quit_flag): New function.
576 * lisp.h (QUIT): Use it.
577
578 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
579
580 * nsfns.m (get_geometry_from_preferences): New function.
581 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
582
583 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
584
585 * emacs.c (Qkill_emacs): Define.
586 (syms_of_emacs): Initialize it.
587 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
588 Qquit_flag to `kill-emacs' instead.
589 (quit_throw_to_read_char): Add parameter `from_signal'.
590 All callers changed. Call Fkill_emacs if requested and safe.
591 * lisp.h (QUIT): Call Fkill_emacs if requested.
592
593 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
594
595 * widget.c (update_wm_hints): Return if wmshell is null.
596 (widget_update_wm_size_hints): New function.
597
598 * widget.h (widget_update_wm_size_hints): Declare.
599
600 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
601 widget_update_wm_size_hints (Bug#10104).
602
603 2011-12-03 Eli Zaretskii <eliz@gnu.org>
604
605 * xdisp.c (handle_invisible_prop): If the invisible text ends just
606 before a newline, prepare the bidi iterator for consuming the
607 newline, and keep the current paragraph direction. (Bug#10183)
608 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
609
610 2011-12-02 Juri Linkov <juri@jurta.org>
611
612 * search.c (Fword_search_regexp): New Lisp function created from
613 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
614 (Fword_search_backward, Fword_search_forward)
615 (Fword_search_backward_lax, Fword_search_forward_lax):
616 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
617 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
618
619 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
620
621 * fileio.c (Finsert_file_contents): Move after-change-function call
622 to before the "handled:" label, since all "goto handled" appear in
623 cases where the *-change-functions have already been properly called
624 (bug#10117).
625
626 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
627
628 * keyboard.c (interrupt_signal): Don't call kill-emacs when
629 waiting for input. (Bug#10169)
630
631 2011-11-30 Eli Zaretskii <eliz@gnu.org>
632
633 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
634 verifies glyph row's hash code--we have just reallocated the
635 glyphs, so their contents can be complete garbage. (Bug#10164)
636
637 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
638
639 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
640
641 2011-11-30 Eli Zaretskii <eliz@gnu.org>
642
643 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
644 attributes are tested _before_ calling verify_row_hash, to protect
645 against GCC re-ordering of the tests. (Bug#10164)
646
647 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
648
649 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
650
651 * xterm.c (handle_one_xevent): Only set async_visible and friends
652 if net_wm_state_hidden_seen is non-zero (Bug#10002)
653 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
654 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
655
656 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
657
658 Remove GCPRO-related macros that exist only to avoid shadowing locals.
659 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
660 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
661 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
662 All uses changed to use GCPRO1 etc.
663 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
664 Revert to old implementation (i.e., before 2011-03-11).
665
666 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
667
668 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
669 of scroll runs so as to avoid assigning disabled bogus rows and
670 unnecessary graphics copy operations.
671
672 2011-11-27 Eli Zaretskii <eliz@gnu.org>
673
674 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
675 (snprintf) [_MSC_VER]: Redirect to _snprintf.
676 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
677 (malloc, free, realloc, calloc): Redirect to e_* only when
678 compiling Emacs.
679
680 * lisp.h (GCTYPEBITS): Move before first use.
681 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
682 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
683 this macro definition.
684
685 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
686 _MSC_VER.
687
688 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
689
690 * gtkutil.c (xg_create_frame_widgets):
691 Call gtk_window_set_has_resize_grip (FALSE) if that function is
692 present with Gtk+ 2.0.
693
694 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
695
696 * fileio.c (Finsert_file_contents): Undo previous change; see
697 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
698
699 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
700
701 Rename locals to avoid shadowing.
702 * fileio.c (Finsert_file_contents):
703 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
704 * process.c (wait_reading_process_output):
705 Rename inner 'proc' to 'p' to avoid shadowing.
706 Indent for consistency with usual Emacs style.
707
708 2011-11-25 Eli Zaretskii <eliz@gnu.org>
709
710 * xdisp.c (redisplay_window): If cursor row is not fully visible
711 after recentering, and scroll-conservatively is set to a large
712 number, scroll window by a few more lines to make the cursor fully
713 visible and out of scroll-margin. (Bug#10105)
714 (start_display): Don't move to the next line if the display should
715 start at a newline that is part of a display vector or an overlay
716 string. (Bug#10119)
717
718 2011-11-24 Juri Linkov <juri@jurta.org>
719
720 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
721 after the `MagickPingImage' call. (Bug#10112)
722
723 2011-11-23 Chong Yidong <cyd@gnu.org>
724
725 * window.c (Fcoordinates_in_window_p): Accept only live windows.
726
727 2011-11-23 Martin Rudalics <rudalics@gmx.at>
728
729 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
730 making another buffer current. (Bug#10114)
731
732 2011-11-23 Glenn Morris <rgm@gnu.org>
733
734 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
735
736 2011-11-23 Chong Yidong <cyd@gnu.org>
737
738 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
739 using it (Bug#5984).
740
741 2011-11-22 Eli Zaretskii <eliz@gnu.org>
742
743 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
744 and header-lines, as they don't have one computed for them.
745 (Bug#10098)
746
747 * .gdbinit (prow): Make displayed values more self-explaining.
748 Add row's hash code.
749
750 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
751
752 * process.c (wait_reading_process_output): Fix asynchrounous
753 GnuTLS socket handling on some versions of the GnuTLS library.
754 (wait_reading_process_output): Add comment and URL.
755
756 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
757
758 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
759
760 2011-11-21 Chong Yidong <cyd@gnu.org>
761
762 * window.c (Fnext_window, Fprevious_window): Doc fix.
763
764 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
765
766 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
767
768 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
769
770 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
771
772 2011-11-20 Martin Rudalics <rudalics@gmx.at>
773
774 * window.c (Fset_window_combination_limit): Rename argument
775 STATUS to LIMIT.
776 (Vwindow_combination_limit): Remove "status" from doc-string.
777
778 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
779
780 * m/ibms390.h: Remove.
781 * m/ibms390x.h: Don't include "ibms390.h".
782
783 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
784
785 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
786 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
787
788 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
789
790 * casetab.c (Fset_case_table):
791 * charset.c (Fcharset_after): Fix typos.
792
793 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
794
795 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
796 Otherwise, valgrind does not work on some platforms.
797 Problem reported by Andreas Schwab in
798 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
799 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
800 is set, removing the need for VIRT_ADDRESS_VARIES.
801 (PURE_P): Use a more-efficient implementation that needs just one
802 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
803 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
804 to 4 (xorl, subq, cmpq, setbe).
805 * alloc.c (pure): Always extern now, since that's the
806 VIRT_ADDR_VARIES behavior.
807 (PURE_POINTER_P): Use a single comparison, not two, for
808 consistency with the new puresize.h.
809 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
810 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
811 Remove VIRT_ADDR_VARIES no longer needed.
812
813 2011-11-19 Eli Zaretskii <eliz@gnu.org>
814
815 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
816 (erase_phys_cursor, update_window_cursor, show_mouse_face)
817 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
818 behave as if the cursor position were at the window margin.
819
820 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
821 and the cursor position is out of bounds, behave as if the cursor
822 position were at the window margin. (Bug#10075)
823
824 2011-11-18 Chong Yidong <cyd@gnu.org>
825
826 * window.c (Fwindow_combination_limit): Make first argument
827 non-optional, since it is meaningless for live windows like the
828 selected window.
829
830 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
831
832 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
833
834 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
835
836 * intervals.c: Fix grafting over the whole buffer (bug#10071).
837 (graft_intervals_into_buffer): Simplify.
838
839 2011-11-18 Eli Zaretskii <eliz@gnu.org>
840
841 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
842 hash values of the two rows.
843 (copy_row_except_pointers): Preserve the used[] arrays and the
844 hash values of the two rows. (Bug#10035)
845 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
846
847 * xdisp.c (row_hash): New function, body extracted from
848 compute_line_metrics.
849 (compute_line_metrics): Call row_hash, instead of computing the
850 hash code inline.
851
852 * dispnew.c (verify_row_hash): Call row_hash for computing the
853 hash code of a row, instead of duplicating code from xdisp.c.
854
855 * dispextern.h (row_hash): Add prototype.
856
857 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
858
859 * frame.c (delete_frame): Don't delete the terminal when the last
860 X frame is closed if emacs is built with GTK toolkit.
861
862 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
863
864 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
865
866 2011-11-17 Martin Rudalics <rudalics@gmx.at>
867
868 * window.c (Vwindow_splits): Rename to
869 Vwindow_combination_resize. Suggested by Juri Linkov.
870 (Fsplit_window_internal): Use Vwindow_combination_resize instead
871 of Vwindow_splits.
872
873 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
874
875 * nsfns.m (Fns_font_name):
876 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
877
878 2011-11-16 Martin Rudalics <rudalics@gmx.at>
879
880 * window.h (window): Rename slot "nest" to "combination_limit".
881 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
882 (Fset_window_nest): Rename to Fset_window_combination_limit.
883 (Vwindow_nest): Rename to Vwindow_combination_limit.
884 (recombine_windows, make_parent_window, make_window)
885 (Fsplit_window_internal, saved_window)
886 (Fset_window_configuration, save_window_save): Rename all
887 occurrences of window_nest to window_combination_limit.
888
889 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
890
891 * image.c (imagemagick_load_image): Fix typo.
892
893 2011-11-14 Eli Zaretskii <eliz@gnu.org>
894
895 * xdisp.c (display_line): Move the call to
896 highlight_trailing_whitespace before the call to
897 compute_line_metrics, since the latter needs to see the final
898 faces of all the glyphs to compute ROW's hash value.
899 Fixes assertion violations in row_equal_p. (Bug#10035)
900
901 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
902
903 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
904 just return (bug#10044).
905
906 2011-11-12 Eli Zaretskii <eliz@gnu.org>
907
908 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
909 with user-defined heap size. Bump the default size of the temacs
910 heap to 27MB, to avoid memory warning when running temacs.
911 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
912
913 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
914 current_matrix and desired_matrix. (Bug#9990)
915 (verify_row_hash) [XASSERTS]: New function.
916 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
917 that the hash value of glyph rows is correct.
918
919 2011-11-12 Martin Rudalics <rudalics@gmx.at>
920
921 * window.h (window): Remove splits slot.
922 * window.c (Fwindow_splits, Fset_window_splits): Remove.
923 (Fdelete_other_windows_internal, make_parent_window)
924 (make_window, Fsplit_window_internal, Fdelete_window_internal)
925 (Fset_window_configuration, save_window_save): Don't deal with
926 split status of windows.
927 (saved_window): Remove splits slot.
928 (Vwindow_splits): Rewrite doc-string.
929
930 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
931
932 * xfns.c (unwind_create_frame):
933 * nsfns.m (unwind_create_frame):
934 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
935 Vframe_list (Bug#9999).
936
937 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
938
939 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
940
941 2011-11-11 Kenichi Handa <handa@m17n.org>
942
943 * callproc.c (Fcall_process): Set the member dst_multibyte of
944 process_coding.
945
946 2011-11-11 Johan Bockgård <bojohan@gnu.org>
947
948 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
949 avoid a crash (bug#9496).
950
951 2011-11-09 Chong Yidong <cyd@gnu.org>
952
953 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
954 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
955
956 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
957
958 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
959
960 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
961
962 Avoid some portability problems by eschewing 'extern inline' functions.
963 The trivial performance wins aren't worth the portability hassles; see
964 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
965 et seq.
966 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
967 (window_box_width, window_box_left, window_box_left_offset)
968 (window_box_right, window_box_right_offset): Undo previous change,
969 by removing the "extern"s.
970 * intervals.c (adjust_intervals_for_insertion)
971 (adjust_intervals_for_deletion): Undo previous change,
972 making these static again.
973 (offset_intervals, temp_set_point_both, temp_set_point)
974 (copy_intervals_to_string): No longer inline.
975 * xdisp.c (window_text_bottom_y, window_box_width)
976 (window_box_height, window_box_left_offset)
977 (window_box_right_offset, window_box_left, window_box_right)
978 (window_box): No longer inline.
979
980 2011-11-08 Chong Yidong <cyd@gnu.org>
981
982 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
983 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
984 Signal an error if not a live window.
985 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
986 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
987
988 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
989
990 * lisp.h (syms_of_abbrev): Remove declaration.
991 Reported by CHENG Gao <chenggao@royau.me>.
992
993 2011-11-07 Eli Zaretskii <eliz@gnu.org>
994
995 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
996 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
997 of temacs in GUI mode.
998
999 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1000
1001 * window.h: Declare delete_all_child_windows instead of
1002 delete_all_subwindows.
1003 * window.c (Fwindow_nest, Fset_window_nest)
1004 (Fset_window_new_total, Fset_window_new_normal)
1005 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1006 (delete_all_subwindows): Rename to delete_all_child_windows.
1007 (Fdelete_other_windows_internal, Fset_window_configuration):
1008 Call delete_all_child_windows instead of delete_all_subwindows.
1009 * frame.c (delete_frame): Call delete_all_child_windows instead
1010 of delete_all_subwindows.
1011
1012 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1013
1014 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1015 This is also needed for porting to any host where GC_MARK_STACK is
1016 not GC_MAKE_GCPROS_NOOPS.
1017 (which_symbols): Use it.
1018
1019 2011-11-07 Kenichi Handa <handa@m17n.org>
1020
1021 * coding.c (coding_set_destination): Check coding->src_pos only
1022 when coding->src_object is a buffer (bug#9910).
1023
1024 * process.c (send_process): Set the member src_multibyte of coding
1025 to 0 (bug#9911) when sending a unibyte text.
1026
1027 * callproc.c (Fcall_process): Set the member src_multibyte of
1028 process_coding to 0 (bug#9912).
1029
1030 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1031
1032 * xmenu.c (cleanup_widget_value_tree): New function.
1033 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1034 calling free_menubar_widget_value_tree directly (Bug#9830).
1035
1036 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1037
1038 Fix some portability problems with 'inline'.
1039 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1040 (window_box_width, window_box_left, window_box_left_offset)
1041 (window_box_right, window_box_right_offset): Declare extern.
1042 Otherwise, these inline functions do not conform to C99 and
1043 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1044 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1045 * intervals.c (adjust_intervals_for_insertion)
1046 (adjust_intervals_for_deletion): Now extern, because otherwise the
1047 extern inline functions 'offset_intervals' couldn't refer to it.
1048 (static_offset_intervals): Remove.
1049 (offset_intervals): Rewrite using the old contents of
1050 static_offset_intervals. The old version didn't conform to C99
1051 because an extern inline function contained a reference to an
1052 identifier with static linkage.
1053
1054 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1055
1056 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1057 GC.
1058
1059 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1060
1061 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1062 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1063 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1064 return Qleft_to_right.
1065
1066 2011-11-06 Chong Yidong <cyd@gnu.org>
1067
1068 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1069 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1070 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1071 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1072 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1073 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1074 (Fwindow_vscroll): Doc fix.
1075 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1076 argument, since it makes no sense to pass a live window and for
1077 consistency with window-child.
1078
1079 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1080
1081 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1082 support MSVC.
1083
1084 2011-11-05 Jason Rumney <jasonr@gnu.org>
1085
1086 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1087 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1088 fonts (Bug#6029).
1089 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1090 bitwise arithmetic preventing use of unicode-sip and non-truetype
1091 opentype fonts.
1092
1093 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1094
1095 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1096 "emacs"-only part.
1097
1098 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1099 initialization code to keep similarity to xfns.c after changes
1100 from 2011-11-05.
1101
1102 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1103
1104 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1105 (unwind_create_frame): New function (Bug#9943).
1106 (Fx_create_frame): Restructure code to be more similar to the one in
1107 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1108 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1109 Move terminal->reference_count++ just before making the frame official
1110 (Bug#9943).
1111
1112 * nsterm.m (x_free_frame_resources): New function.
1113 (x_destroy_window): Move code to x_free_frame_resources.
1114
1115 * xfns.c (unwind_create_frame): Fix comment.
1116 (Fx_create_frame, x_create_tip_frame):
1117 Move terminal->reference_count++ just before making the frame
1118 official. Move initialization of image_cache_refcount and
1119 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1120
1121 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1122
1123 Support MSVC build with newer versions of Visual Studio.
1124 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1125 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1126 nt/gmake.defs.
1127
1128 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1129 which are not supported by MSVC.
1130 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1131 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1132 bitfields.
1133 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1134 types in bitfields.
1135 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1136
1137 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1138
1139 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1140
1141 Support MSVC build with newer versions of Visual Studio.
1142 * w32.c: Don't include w32api.h for MSVC.
1143 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1144
1145 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1146 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1147 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1148 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1149 e_* cousins.
1150 (alloca) [_MSC_VER]: Define to _alloca.
1151
1152 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1153
1154 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1155
1156 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1157
1158 * xdisp.c (note_mouse_highlight): If either of
1159 previous/next-single-property-change returns nil, treat that as
1160 the beginning or the end of the buffer. (Bug#9955)
1161
1162 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1163
1164 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1165 label is not null (Bug#9951).
1166 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1167 may be NULL.
1168
1169 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1170
1171 * window.c (Fwindow_body_size): Mention in the doc string that the
1172 return value is in frame's canonical units. (Bug#9949)
1173
1174 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1175
1176 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1177
1178 * w32fns.c (unwind_create_frame): If needed, free the glyph
1179 matrices of the partially constructed frame. (Bug#9943)
1180 * xfns.c (unwind_create_frame): Likewise.
1181
1182 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1183
1184 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1185 Don't stop backward scan on the continuation glyph, even though
1186 its CHARPOS is positive.
1187 (mouse_face_from_buffer_pos, note_mouse_highlight):
1188 Rename cover_string to disp_string.
1189
1190 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1191
1192 * window.c (temp_output_buffer_show): Don't use
1193 Vtemp_buffer_show_specifiers.
1194 (Vtemp_buffer_show_specifiers): Remove unused variable.
1195
1196 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1197
1198 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1199 past the beginning of the current glyph matrix.
1200
1201 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1202
1203 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1204 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1205 HAVE_GTK3 (Bug#9869).
1206
1207 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1208 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1209
1210 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1211
1212 * xterm.c: Declare x_handle_net_wm_state to return int.
1213 (handle_one_xevent): Check if we are iconified but don't have
1214 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1215 (get_current_wm_state): Return non-zero if not hidden,
1216 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1217 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1218 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1219 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1220
1221 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1222
1223 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1224 so that this new function doesn't get optimized away by a
1225 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1226
1227 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1228
1229 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1230
1231 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1232
1233 Fix the `xbytecode' command.
1234 * .gdbinit (xprintbytestr): New command.
1235 (xwhichsymbols): Rename from `which'; all callers changed.
1236 (xbytecode): Print the byte-code string as well.
1237
1238 2011-10-29 Kim Storm <storm@cua.dk>
1239
1240 * alloc.c (which_symbols): New function.
1241
1242 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1243
1244 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1245 line. (Bug#9903)
1246
1247 2011-10-29 Glenn Morris <rgm@gnu.org>
1248
1249 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1250 Not clear what it was for, and it causes various bugs. (Bug#9839)
1251
1252 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1253
1254 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1255 possible random value that matches one of those tested as
1256 condition to clear the mouse face.
1257
1258 2011-10-28 Chong Yidong <cyd@gnu.org>
1259
1260 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1261
1262 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1263
1264 * window.c (make_window): Initialize phys_cursor_on_p.
1265
1266 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1267
1268 * lisp.h (struct Lisp_Symbol): Update comments.
1269
1270 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1271
1272 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1273
1274 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1275
1276 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1277 <oslsachem@gmail.com> for helping to debug this.
1278
1279 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1280 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1281 (g_b_init_get_glyph_outline_w): New static variables.
1282 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1283 (GetGlyphOutlineW_Proc): New typedefs.
1284 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1285 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1286 New functions.
1287 (w32font_open_internal, compute_metrics):
1288 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1289 instead of calling the "wide" APIs directly.
1290
1291 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1292
1293 * w32.h (syms_of_w32font): Add prototype.
1294
1295 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1296
1297 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1298 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1299 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1300 (Fmove_to_window_line): Doc fix.
1301
1302 2011-10-27 Chong Yidong <cyd@gnu.org>
1303
1304 * process.c (make_process): Set gnutls_state to NULL.
1305
1306 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1307 non-NULL, regardless of GNUTLS_INITSTAGE.
1308 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1309 an error. Set process slots as soon as we allocate them.
1310
1311 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1312
1313 2011-10-27 Chong Yidong <cyd@gnu.org>
1314
1315 * gnutls.c (emacs_gnutls_deinit): New function.
1316 Deallocate credentials structures as well as calling gnutls_deinit.
1317 (Fgnutls_deinit, Fgnutls_boot): Use it.
1318
1319 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1320 (deactivate_process): Call emacs_gnutls_deinit.
1321
1322 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1323
1324 * image.c (x_create_x_image_and_pixmap):
1325 * w32.c (sys_rename, w32_delayed_load):
1326 * w32font.c (fill_in_logfont):
1327 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1328
1329 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1330
1331 * w32fns.c (w32_default_color_map): New function,
1332 extracted from Fw32_default_color_map.
1333 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1334
1335 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1336
1337 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1338
1339 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1340
1341 * keyboard.c (test_undefined): New function (bug#9751).
1342 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1343
1344 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1345
1346 * sysdep.c (init_sys_modes): Fix the check for the controlling
1347 terminal (Bug#6649).
1348
1349 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1350
1351 * dispextern.h (struct bidi_it): New member next_en_type.
1352
1353 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1354 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1355 current character, check also for next_en_type being WEAK_EN.
1356 (bidi_resolve_weak): Don't enter the expensive loop if the current
1357 position is before next_en_pos. Record the bidi type of the first
1358 non-ET, non-BN character we find, in addition to its position.
1359 (bidi_level_of_next_char): Invalidate next_en_type when
1360 next_en_pos is over-stepped.
1361
1362 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1363
1364 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1365 * editfns.c: Rewrite current-time-zone so that it invokes
1366 the equivalent of (format-time-string "%Z") to get the time zone name.
1367 This fixes a bug when the time zone name contains characters that
1368 need converting from the system time locale to Emacs internal format.
1369 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1370 that patch fixed format-time-string to do the conversion, but
1371 I forgot to fix current-time-zone.
1372 (format_time_string): New function, containing most of
1373 what Fformat_time_string used to contain.
1374 (Fformat_time_string): Rewrite in terms of format_time_string.
1375 This doesn't change this function's behavior.
1376 (current-time-zone): Rewrite to use format_time_string.
1377 This fixes the bug reported by Michael Schierl in
1378 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1379 Jason Rumney's 2007-06-07 change worked around this bug, but
1380 didn't fix it.
1381 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1382
1383 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1384
1385 * xdisp.c (start_display): If the character at POS is displayed
1386 via a display vector, reset IT->current.dpvec_index to zero.
1387 (try_window_reusing_current_matrix): If a line ends in a display
1388 vector or the next line starts in a display vector, continue
1389 redrawing the window even though the character position of
1390 start_row was reached.
1391 (Bug#9771, part 2)
1392
1393 2011-10-18 Chong Yidong <cyd@gnu.org>
1394
1395 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1396 with nobreak-char-display too.
1397
1398 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1399
1400 Fix part 3 of bug#9771.
1401 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1402 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1403 non-neutral characters if the current character is a paragraph
1404 separator (a.k.a. Newline). This avoids running the same
1405 expensive loop twice, once when we consume the preceding newline
1406 and the other time when the line actually needs to be displayed.
1407 Avoid the loop when we see neutrals on the base embedding level
1408 following a character whose directionality is the same as the
1409 paragraph's. This avoids running the expensive loop when a line
1410 ends in a long sequence of neutrals, like control characters.
1411 Add assertion against STRONG_AL type. Slightly rearrange code
1412 that determines the type of a neutral given the first non-neutral
1413 that follows it.
1414 (bidi_level_of_next_char): Set next_en_pos to zero when
1415 invalidating its info.
1416
1417 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1418
1419 * xdisp.c (push_display_prop): Determine whether to record string
1420 or buffer position by IT->string, not by IT->method. Allow
1421 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1422 (move_it_vertically_backward): Don't look for character position
1423 immediately after the newline when in a continuation line.
1424 (Bug#9771, part 1)
1425
1426 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1427
1428 * window.c (coordinates_in_window): Rewrite and delabelize
1429 vertical border check. (Bug#5357) (Bug#9618)
1430
1431 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1432
1433 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1434 errors in XSetWindowBorder (bug#9310).
1435
1436 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1437
1438 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1439 avoid crash when xmalloc overrun checking is enabled.
1440
1441 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1442
1443 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1444 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1445 cursor motion with <left> and <right> arrow keys.
1446
1447 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1448 some callers set that themselves.
1449
1450 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1451
1452 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1453 display string and the previous row comes from the same string and
1454 is empty. (Bug#9739) (Bug#9738)
1455
1456 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1457
1458 * doc.c (get_doc_string): Encode file name (bug#9735).
1459
1460 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1461
1462 * bidi.c (bidi_level_of_next_char):
1463 * xdisp.c (get_visually_first_element): Remove old incorrect
1464 comments regarding the Unicode Line Separator character.
1465
1466 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1467
1468 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1469
1470 * alloc.c (Fgc_status): Do not access beyond zombies array
1471 boundary if nzombies > MAX_ZOMBIES.
1472 * alloc.c (dump_zombies): Add missing format specifier.
1473
1474 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1477 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1478
1479 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1480 Some packages use them to denote characters with modifiers.
1481
1482 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1483
1484 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1485 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1486 matching a pp-number. Rename parameter var to var1.
1487
1488 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1489
1490 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1491
1492 2011-10-08 Glenn Morris <rgm@gnu.org>
1493
1494 * callint.c (Fcall_interactively): Give a more explicit error for the
1495 'c' case with a non-character input. (Bug#8479)
1496
1497 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1498
1499 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1500 lines.
1501 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1502 lines that are hscrolled on the left.
1503
1504 * dispnew.c (buffer_posn_from_coords): Account for a possible
1505 presence of header-line. (Bug#4426)
1506
1507 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1508
1509 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1510 Don't advertise functionality which we discourage or doesn't work.
1511
1512 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1513
1514 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1515 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1516 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1517 this makes Emacs dump core during garbage collection on rare
1518 occasions. sizeof is obviously inferior to offsetof here, so
1519 stick with offsetof.
1520 (GC_POINTER_ALIGNMENT): New macro.
1521 (mark_memory): Omit 3rd (offset) arg; caller changed.
1522 Don't assume EMACS_INT alignment is the same as pointer alignment.
1523
1524 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1525
1526 * keyboard.c (read_key_sequence_remapped): New var.
1527 (read_key_sequence): Compute remapping in the right buffer.
1528 (command_loop_1): Use read_key_sequence's remapping directly.
1529
1530 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1531
1532 * dired.c (file_name_completion): Don't expand file name.
1533 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1534 before checking file name handler.
1535
1536 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1537 they've been requested explicitly (bug#9591).
1538
1539 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1540
1541 * keymap.c (Fsingle_key_description): Use make_specified_string
1542 instead of build_string to build string from push_key_description.
1543 (Bug#5193)
1544
1545 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1546
1547 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1548 This fixes a Y2038 bug on 64-bit hosts.
1549 * buffer.c (reset_buffer):
1550 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1551 (Fclear_buffer_auto_save_failure):
1552 Use 0, not -1, to represent an unset failure time, since time_t
1553 might not be signed.
1554
1555 Remove dependency on glibc malloc internals.
1556 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1557 Move back here from lisp.h, but with their new implementations.
1558 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1559 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1560 * charset.c (charset_table_init): New static var.
1561 (syms_of_charset): Use it instead of xmalloc. This removes a
1562 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1563 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1564 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1565 Move back to alloc.c.
1566 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1567 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1568
1569 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1570
1571 * nsterm.m (windowDidResize): Call x_set_window_size only when
1572 ns_in_resize is true. Otherwise set pixelwidth/height and
1573 call change_frame_size (Bug#9628).
1574
1575 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 Port --enable-checking=all to Fedora 14 x86-64.
1578 * charset.c (syms_of_charset): Also account for glibc malloc's
1579 internal overhead when calculating the initial malloc maximum.
1580
1581 Port --enable-checking=all to Fedora 14 x86.
1582 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1583 Move to lisp.h.
1584 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1585 (overrun_check_realloc, overrun_check_free):
1586 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1587 That way, xmalloc returns a properly-aligned pointer even if
1588 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1589 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1590 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1591 into account when calculating the initial malloc maximum.
1592 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1593 Move here from alloc.c, so that charset.c can use it too.
1594 Properly align; the old code wasn't right for common 32-bit hosts
1595 when configured with --enable-checking=all.
1596 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1597 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1598
1599 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1600
1601 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1602 use EDOM.
1603
1604 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1605
1606 * xdisp.c (compute_display_string_end): If there's no display
1607 string at CHARPOS, return -1.
1608
1609 * bidi.c (bidi_fetch_char): When compute_display_string_end
1610 returns a negative value, treat the character as a normal
1611 character not covered by a display string. (Bug#9624)
1612
1613 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1614
1615 * lread.c (Fread_from_string): Fix typo in docstring.
1616
1617 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1618
1619 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1620 newline, reseat the iterator instead of bidi-iterating there one
1621 character at a time. (Bug#9610)
1622 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1623 TO_CHARPOS if the bidi iterator is at base embedding level.
1624
1625 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1626
1627 * lread.c (readevalloop): Use correct code for NBSP.
1628 (read1): Likewise. (Bug#9608)
1629
1630 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1631
1632 * dbusbind.c (Fdbus_register_signal): When service is not
1633 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1634
1635 2011-09-25 Glenn Morris <rgm@gnu.org>
1636
1637 * buffer.c (truncate-lines): Doc fix.
1638
1639 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1640
1641 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1642 (Fset_window_next_buffers): Doc fix.
1643
1644 2011-09-24 Glenn Morris <rgm@gnu.org>
1645
1646 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1647
1648 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1649
1650 Fix minor problems found by static checking.
1651 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1652 * indent.c (Fvertical_motion): Fix == vs = typo.
1653
1654 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1655
1656 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1657 Default value is now t. Doc fix.
1658
1659 * indent.c (Fvertical_motion): Compute and apply the overshoot
1660 logic when moving up, not only when moving down. Fix the
1661 confusing name and values of the it_overshoot_expected variable;
1662 logic changes accordingly. (Bug#9254) (Bug#9549)
1663
1664 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1665 CHARPOS is covered by a display string which includes newlines.
1666 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1667 is covered by a display string with embedded newlines.
1668
1669 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1670
1671 * dbusbind.c (Fdbus_register_signal): Add match rule to
1672 Vdbus_registered_objects_table. (Bug#9581)
1673 (Fdbus_register_method, Vdbus_registered_objects_table):
1674 Fix docstring.
1675
1676 2011-09-24 Jim Meyering <meyering@redhat.com>
1677
1678 do not ignore write error for any output size
1679 The previous change was incomplete.
1680 While it makes emacs --batch detect the vast majority of stdout
1681 write failures, errors were still ignored whenever the output size is
1682 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1683 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1684 && echo FAIL: ignored write error
1685 FAIL: ignored write error
1686 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1687 && echo FAIL: ignored write error
1688 FAIL: ignored write error
1689 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1690
1691 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1692
1693 * emacs.c (Fkill_emacs): In noninteractive mode exit
1694 non-successfully if a write error occurred on stdout. (Bug#9574)
1695
1696 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1697
1698 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1699 the xassert test.
1700
1701 * dispextern.h (struct it): Update the comment documenting what
1702 can it->OBJECT be.
1703
1704 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1705
1706 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1707 a display string, extend search for cursor position to end of row.
1708 (find_row_edges): If the row ends in a newline from a display
1709 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1710 Handle the case of a display string with multiple newlines.
1711 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1712 non-empty line. Fixes confusing cursor motion with arrow keys at
1713 the beginning of a line that starts with whitespace.
1714
1715 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1716
1717 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1718 (bug#9493).
1719
1720 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1721
1722 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1723 boolean (Bug#9154).
1724
1725 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1726
1727 * xdisp.c (display_line): Record maximum and minimum buffer
1728 positions even if no glyphs were produced (e.g., by a zero-width
1729 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1730 buffer positions that will be removed from the glyph row because
1731 they don't fit.
1732 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1733 column is beyond frame width: don't subtract 1 "pixel" when
1734 computing width of the stretch.
1735 (reseat_at_next_visible_line_start): Undo the change made on
1736 2011-09-17 that saved paragraph information and restored it after
1737 the call to `reseat'. (Bug#9545)
1738
1739 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1740
1741 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1742 and turn window cursor on if cleared (Bug#9415).
1743
1744 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1745
1746 * search.c (boyer_moore): Take unibyte characters from pattern
1747 literally. (Bug#9458)
1748
1749 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1750
1751 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1752
1753 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1754
1755 Fix minor problem found by static checking.
1756 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1757 initialized, to pacify gcc -Wuninitialized.
1758
1759 * fileio.c: Report proper errno when syscall falls.
1760 (Finsert_file_contents): Save and restore errno,
1761 so that report_file_error outputs the correct diagnostic.
1762 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1763
1764 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1765
1766 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1767
1768 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1769
1770 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1771 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1772
1773 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1774
1775 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1776 about the current paragraph and restore it after the call to reseat.
1777
1778 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1779 (bidi_find_paragraph_start): Search back for paragraph beginning
1780 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1781 (bidi_move_to_visually_next): Only trigger paragraph-related
1782 computations when the last character is a newline or at EOB, not
1783 just any NEUTRAL_B. (Bug#9470)
1784
1785 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1786 truncated lines if point is covered by a display string. (Bug#9524)
1787
1788 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1789
1790 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1791 (cons_to_x_long): New function.
1792 (lisp_data_to_selection_data): Use it. Correct the test for
1793 short-versus-long data; it was negated. Break out of vector
1794 loop, for efficiency, when a long datum is discovered.
1795
1796 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1797
1798 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1799
1800 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1801
1802 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1803 GCC PR/17406) by declaring this function with external scope.
1804
1805 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1806
1807 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1808 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1809
1810 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1811
1812 * editfns.c (Fformat): Correctly handle text properties on "%%".
1813
1814 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1815
1816 * xterm.c (x_draw_composite_glyph_string_foreground):
1817 * w32term.c (x_draw_composite_glyph_string_foreground):
1818 * term.c (encode_terminal_code):
1819 * composite.c (composition_update_it, get_composition_id):
1820 * xdisp.c (get_next_display_element)
1821 (fill_composite_glyph_string): Add comments about special meaning
1822 of TAB characters in a composition.
1823
1824 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1827 This occurs when processing a multibyte format.
1828 Problem reported by Wolfgang Jenker.
1829
1830 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1831
1832 * xdisp.c (try_cursor_movement): Only check for exact match if
1833 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1834
1835 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 Remove unused external symbols.
1838 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1839 * xdisp.c (calc_pixel_width_or_height): Now static.
1840 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1841 * indent.c (check_display_width):
1842 * w32term.c: Fix comment to match code.
1843 * xterm.c, xterm.h (x_catching_errors): Remove.
1844
1845 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1846
1847 * xselect.c: Use signed conversions more consistently (Bug#9498).
1848 (selection_data_to_lisp_data): Assume incoming selection data are
1849 signed integers, not unsigned. This is to be consistent with
1850 outgoing selection data, which was modified to use signed integers
1851 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1852 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1853 expects long, not unsigned long.
1854
1855 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1856
1857 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1858 computation of loop end. Reported by Johan Bockgård
1859 <bojohan@gnu.org>.
1860
1861 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1862
1863 * frame.c (Fother_visible_frames_p): Function deleted.
1864
1865 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1866
1867 * indent.c (compute_motion): Process display vector front to back
1868 rather than the other way around. (Bug#2496)
1869
1870 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1871
1872 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1873
1874 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1875
1876 * minibuf.c (Fread_from_minibuffer): Doc fix.
1877
1878 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1879
1880 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1881 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1882
1883 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1884
1885 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1886 value for non-existent files.
1887
1888 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1889
1890 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1891 set its "size" to -1. This will set the modtime_size field of
1892 the corresponding buffer to -1, which is what
1893 verify-visited-file-modtime expects for files that do not exist.
1894 (Bug#9139)
1895
1896 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1897
1898 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1899 here ...
1900 * lisp.h: ... from here. push_key_description is no longer
1901 defined in keyboard.c, so its declaration should not be in
1902 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1903 logically belongs with push_key_description.
1904
1905 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1906
1907 * buffer.h: Include <sys/types.h> instead of <time.h>.
1908 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1909 Problem reported by Herbert J. Skuhra.
1910
1911 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1912
1913 * xml.c (parse_region): Make the parsing work for
1914 non-comment-starting XML files again (bug#9144).
1915
1916 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1917
1918 * image.c (gif_load): Fix calculation of bottom and right corner.
1919 (Bug#9468)
1920
1921 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1922
1923 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1924 redisplay in small windows.
1925
1926 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1927
1928 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1929
1930 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1931
1932 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1933 Operate on live windows only.
1934
1935 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1936
1937 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1938
1939 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1940
1941 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1942 only under bidi iteration.
1943
1944 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1945
1946 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1947
1948 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1951 Without this fix, the command to link temacs failed due to an
1952 undefined symbol __builtin_isnan. This is because
1953 /usr/include/iso/math_c99.h #defines isnan(x) to
1954 __builtin_isnan(x), but the bundled gcc, which identifies itself
1955 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1956 a __builtin_isnan.
1957 * floatfns.c (isnan): #undef, and then #define to a clone of
1958 what's in data.c.
1959 (Fisnan): Always define, since it's always available now.
1960 (syms_of_floatfns): Always define isnan at the Lisp level.
1961
1962 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1963
1964 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1965
1966 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1967
1968 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1969 The previous code assumed that file offsets (off_t values) fit in
1970 EMACS_INT variables, which is not true on typical 32-bit hosts.
1971 The code messed up by falsely reporting buffer overflow in cases
1972 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1973 when "big" contains more than 2**29 bytes, even though this
1974 inserts just one byte and does not overflow the buffer.
1975 (Finsert_file_contents): Store file offsets as off_t
1976 values, not as EMACS_INT values. Check for overflow when
1977 converting between EMACS_INT and off_t. When checking for
1978 buffer overflow or for overlap, take the offsets into account.
1979 Don't use EMACS_INT for small values where int suffices.
1980 When checking for overlap, fix a typo: ZV was used where
1981 ZV_BYTE was intended.
1982 (Fwrite_region): Don't assume off_t fits into 'long'.
1983 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1984
1985 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1986
1987 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1988
1989 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1990
1991 sprintf-related integer and memory overflow issues (Bug#9412).
1992
1993 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1994 (esprintf, exprintf, evxprintf): New functions.
1995 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1996 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1997 (modify_event_symbol): Do not assume that the length of
1998 name_alist_or_stem is safe to alloca and fits in int.
1999 (Fexecute_extended_command): Likewise for function name and binding.
2000 (Frecursion_depth): Wrap around reliably on integer overflow.
2001 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2002 since some callers pass EMACS_INT values.
2003 (Fsingle_key_description): Don't crash if symbol name contains more
2004 than MAX_ALLOCA bytes.
2005 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2006 (get_minibuffer): Arg is now EMACS_INT, not int.
2007 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2008 (esprintf, exprintf, evxprintf): New decls.
2009 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2010
2011 * dbusbind.c (signature_cat): New function.
2012 (xd_signature, Fdbus_register_signal):
2013 Do not overrun buffer; instead, report string overflow.
2014
2015 * dispnew.c (add_window_display_history): Don't overrun buffer.
2016 Truncate instead; this is OK since it's just a log.
2017
2018 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2019 even if the time zone offset is outlandishly large.
2020 Don't mishandle offset == INT_MIN.
2021
2022 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2023 when creating daemon; the previous buffer-overflow check was incorrect.
2024
2025 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2026 which has the guts of the old verror function.
2027
2028 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2029 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2030
2031 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2032 (font_unparse_xlfd): Don't blindly alloca long strings.
2033 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2034 fits in int, when using sprintf. Use single snprintf to count
2035 length of string rather than counting it via multiple sprintfs;
2036 that's simpler and more reliable.
2037 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2038 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2039 sprintf, in case result does not fit in int.
2040
2041 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2042 (fontset_from_font): Print it.
2043
2044 * frame.c (tty_frame_count): Now printmax_t, not int.
2045 (make_terminal_frame, set_term_frame_name): Print it.
2046 (x_report_frame_params): In X, window IDs are unsigned long,
2047 not signed long, so print them as unsigned.
2048 (validate_x_resource_name): Check for implausibly long names,
2049 and don't assume name length fits in 'int'.
2050 (x_get_resource_string): Don't blindly alloca invocation name;
2051 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2052 not fit in int.
2053
2054 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2055 (xg_check_special_colors, xg_set_geometry):
2056 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2057
2058 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2059 Use esprintf, not sprintf, in case result does not fit in int.
2060
2061 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2062 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2063 it as a large positive number.
2064 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2065 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2066
2067 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2068 in case result does not fit in int.
2069
2070 * print.c (float_to_string): Detect width overflow more reliably.
2071 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2072 buffer overrun. Don't assume list length fits in 'int'. Treat
2073 print length of 0 as 0, not as infinity; to be consistent with other
2074 uses of print length in this function. Don't overflow print length
2075 index. Don't assume hash table size fits in 'long', or that
2076 vectorlike size fits in 'unsigned long'.
2077
2078 * process.c (make_process): Use printmax_t, not int, to format
2079 process-name gensyms.
2080
2081 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2082
2083 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2084 to avoid potential buffer overrun.
2085
2086 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2087 if X resource line is longer than 512 bytes.
2088
2089 * xfns.c (x_window): Make sprintf buffer a bit bigger
2090 to avoid potential buffer overrun.
2091
2092 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2093
2094 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2095
2096 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2097
2098 Integer overflow fixes for scrolling, etc.
2099 Without these, Emacs silently mishandles large integers sometimes.
2100 For example, "C-u 4294967297 M-x recenter" was treated as if
2101 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2102
2103 * xdisp.c (try_window_id): Check Emacs fixnum range before
2104 converting to 'int'.
2105
2106 * window.c (window_scroll_line_based, Frecenter):
2107 Check that an Emacs fixnum is in range before assigning it to 'int'.
2108 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2109 values converted from Emacs fixnums.
2110 (Frecenter): Don't wrap around a line count if it is out of 'int'
2111 range; instead, treat it as an extreme value.
2112 (Fset_window_configuration, compare_window_configurations):
2113 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2114
2115 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2116 that can exceed INT_MAX. Check that EMACS_INT value is in range
2117 before assigning it to the (possibly-narrower) index.
2118 (match_limit): Don't assume that a fixnum can fit in 'int'.
2119
2120 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2121 exceed INT_MAX.
2122
2123 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2124 (Fvertical_motion): Don't wrap around LINES values that don't fit
2125 in 'int'. Instead, treat them as extreme values. This is good
2126 enough for windows, which can't have more than INT_MAX lines anyway.
2127
2128 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2129
2130 * Require libxml/parser.h to avoid compilation warning.
2131
2132 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2133
2134 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2135 since this reportedly can destroy thread storage.
2136
2137 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2138
2139 * syntax.c (find_defun_start): Update all cache variables if
2140 exiting early (Bug#9401).
2141
2142 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2143
2144 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2145
2146 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2147 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2148 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2149
2150 * term.c (tty_append_glyph): New function.
2151 (produce_stretch_glyph): Static function and its prototype deleted.
2152
2153 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2154 Add prototypes.
2155
2156 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2159 when checking :margin (Bug#9390).
2160 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2161 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2162 so that the name doesn't mislead. All uses changed.
2163
2164 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2165
2166 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2167 set_tty_hooks.
2168
2169 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2170
2171 * xdisp.c (move_it_to): Don't bail out early when reaching
2172 position beyond to_charpos, if we are scanning backwards.
2173 (move_it_vertically_backward): When DY == 0, make sure we get to
2174 the first character in the line after the newline.
2175
2176 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2177
2178 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2179 (ccl_driver): Do not generate an out-of-range pointer.
2180 (Fccl_execute_on_string): Remove unnecessary check for
2181 integer overflow, noted by Stefan Monnier in
2182 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2183 Remove a FIXME that didn't need fixing.
2184 Simplify the newly-introduced buffer reallocation code.
2185
2186 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2187
2188 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2189
2190 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2191
2192 Integer and memory overflow issues (Bug#9196).
2193
2194 * doc.c (get_doc_string): Rework so that
2195 get_doc_string_buffer_size is the actual buffer size, rather than
2196 being 1 less than the actual buffer size; this makes xpalloc more
2197 convenient.
2198
2199 * image.c (x_allocate_bitmap_record, cache_image):
2200 * xselect.c (Fx_register_dnd_atom):
2201 Simplify previous changes by using xpalloc.
2202
2203 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2204 since either will do and ptrdiff_t is convenient with xpalloc.
2205
2206 * charset.c (charset_table_size)
2207 (struct charset_sort_data.priority): Now ptrdiff_t.
2208 (charset_compare): Don't overflow if priorities differ greatly.
2209 (Fsort_charsets): Don't assume list length fits in int.
2210 Check for size-calculation overflow when allocating sort data.
2211 (syms_of_charset): Allocate an initial charset table that is
2212 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2213
2214 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2215
2216 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2217 The actual value is always <= INT_MAX, and leaving it unsigned made
2218 overflow checking harder.
2219
2220 * dispextern.h (struct glyph_matrix.rows_allocated)
2221 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2222 with xpalloc. The values are still always <= INT_MAX.
2223
2224 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2225
2226 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2227 (SAFE_NALLOCA): New macro.
2228
2229 * region-cache.c (struct boundary.pos, find_cache_boundary)
2230 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2231 (set_cache_region, invalidate_region_cache)
2232 (revalidate_region_cache, know_region_cache, region_cache_forward)
2233 (region_cache_backward, pp_cache):
2234 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2235 so that ptrdiff_t * can be passed to xpalloc.
2236 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2237 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2238 (pp_cache): Don't assume cache_len fits in int.
2239 * region-cache.h: Adjust extern decls to match.
2240
2241 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2242 EMACS_INT, since either will do, for xpalloc.
2243
2244 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2245 (xnmalloc, xnrealloc, xpalloc): New functions.
2246
2247 * bidi.c (bidi_shelve_header_size): New constant.
2248 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2249 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2250
2251 * bidi.c (bidi_cache_shrink):
2252 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2253 (overlay_strings):
2254 Don't update size of array until after memory allocation succeeds,
2255 because xmalloc/xrealloc may not return.
2256 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2257 now that we have proper integer overflow checking.
2258 (record_overlay_string, overlay_strings): Catch overflows when
2259 calculating size of overlay_str_buf.
2260
2261 * callproc.c (Fcall_process): Check for size overflow when
2262 calculating size of args2.
2263 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2264 Normally we prefer signed values, but sticking with ptrdiff_t would
2265 require adding more-complicated checks.
2266
2267 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2268 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2269 Redo buffer-overflow calculations to avoid integer overflow.
2270 Add a FIXME comment where memory seems to be over-allocated.
2271
2272 * character.c (Fstring): Check for size-calculation overflow.
2273
2274 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2275 unnecessary integer overflow. Check for size overflow.
2276 (encode_coding_object): Don't update size until xmalloc succeeds.
2277
2278 * composite.c (get_composition_id): Check for overflow in glyph
2279 length calculations.
2280
2281 Integer and memory overflow fixes for display code.
2282 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2283 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2284 (scrolling_window): Check for overflow in size calculations.
2285 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2286 Don't assume glyph table len fits in int.
2287 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2288 (row_table_size): Now ptrdiff_t, not int.
2289 (scrolling_window): Avoid overflow in size calculations.
2290 Don't update size until allocation succeeds.
2291 * fns.c (concat): Check for overflow in size calculations.
2292 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2293 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2294 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2295
2296 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2297 (get_doc_string): Check for size calculation overflow.
2298 Don't update size until allocation succeeds.
2299 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2300 EMACS_INT, where ptrdiff_t will do.
2301 (Fsubstitute_command_keys): Check for string overflow.
2302
2303 * editfns.c (set_time_zone_rule): Don't assume environment length
2304 fits in int.
2305 (message_length): Now ptrdiff_t, not int.
2306 (Fmessage_box): Don't update size until allocation succeeds.
2307 Don't assume message length fits in int.
2308 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2309
2310 * emacs.c (main): Do not reallocate argv, since there is a null at
2311 the end that can be overwritten, and this way there's no need to
2312 worry about size-calculation overflow.
2313 (sort_args): Check for size-calculation overflow.
2314
2315 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2316 alloc succeeds.
2317 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2318
2319 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2320 (x_set_scroll_bar_width, x_figure_window_size):
2321 Check for integer overflow.
2322 (x_set_alpha): Do not assume XINT fits in int.
2323
2324 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2325 This is for the members text_lines, text_cols, total_lines, total_cols,
2326 where the system imposes an 'int' limit.
2327
2328 * fringe.c (Fdefine_fringe_bitmap):
2329 Don't update size until alloc works.
2330
2331 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2332 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2333
2334 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2335 Check for size-calculation overflow.
2336 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2337 do, as we prefer signed integers.
2338 (id_to_widget.max_size, id_to_widget.used)
2339 (xg_store_widget_in_map, xg_remove_widget_from_map)
2340 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2341 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2342 Use and return ptrdiff_t, not int.
2343 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2344 * gtkutil.h: Change prototypes to match the above.
2345
2346 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2347 are duplicate now that they've been promoted to lisp.h.
2348 (x_allocate_bitmap_record, x_alloc_image_color)
2349 (make_image_cache, cache_image, xpm_load):
2350 Don't update size until alloc is done.
2351 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2352 (x_detect_edges):
2353 Check for size calculation overflow.
2354 (ct_colors_allocated_max): New constant.
2355 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2356 overflow.
2357
2358 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2359 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2360 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2361 Use ptrdiff_t, not int, to count maps.
2362 (read_char_minibuf_menu_prompt): Check for overflow in size
2363 calculations. Don't update size until allocation succeeds.
2364 Redo calculations to avoid overflow.
2365 * keyboard.h: Change prototypes to match the above.
2366
2367 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2368 to count maps.
2369 (current_minor_maps): Check for size calculation overflow.
2370 * keymap.h: Change prototypes to match the above.
2371
2372 * lread.c (read1, init_obarray): Don't update size until alloc done.
2373
2374 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2375 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2376
2377 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2378 Now ptrdiff_t, not int.
2379 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2380 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2381
2382 * process.c (Fnetwork_interface_list): Check for overflow
2383 in size calculation.
2384
2385 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2386
2387 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2388 overflow. Don't bother calling xmalloc when xrealloc will do.
2389
2390 * search.c (Freplace_match): Check for size calculation overflow.
2391 (Fset_match_data): Don't assume list lengths fit in 'int'.
2392
2393 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2394 for command line length. Do not attempt to address one before the
2395 beginning of an array, as that's not portable.
2396
2397 * term.c (max_frame_lines): Remove; unused.
2398 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2399 not int.
2400 (encode_terminal_code, calculate_costs): Check for size
2401 calculation overflow.
2402 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2403 table lengths and related sizes. Don't update size until alloc
2404 done. Redo calculations to avoid overflow.
2405 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2406
2407 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2408 subtracting pointers.
2409 (gobble_line): Check for overflow more carefully. Don't update size
2410 until alloc done.
2411
2412 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2413 Don't update size until alloc done.
2414 Redo size calculations to avoid overflow.
2415 Check for size calculation overflow.
2416 (main) [DEBUG]: Fix typo in invoking tparam1.
2417
2418 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2419 Use ptrdiff_t, not int, for sizes.
2420 (store_mode_line_noprop_char): Don't update size until alloc done.
2421
2422 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2423 Use ptrdiff_t, not int, for sizes.
2424 (Finternal_make_lisp_face, cache_face):
2425 Check for size calculation overflow.
2426 (cache_face): Treat size calculation overflows as if they were
2427 memory exhaustion (the usual treatment), rather than aborting.
2428
2429 * xfns.c (x_encode_text, x_set_name_internal)
2430 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2431 sizes, since they can exceed INT_MAX in size. Check for size
2432 calculation overflow.
2433
2434 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2435 (xg_select): Check for size calculation overflow.
2436 Don't update size until alloc done.
2437
2438 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2439 as sprintf is limited to int lengths.
2440
2441 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2442 (X_LONG_MIN): New macros.
2443 Use them to make the following changes clearer.
2444 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2445 This change doesn't affect the value now, but it may help remind
2446 future maintainers not to raise the value too much later.
2447 (SELECTION_QUANTUM): Remove, replacing with ...
2448 (selection_quantum): ... new function, which avoids overflow.
2449 All uses changed.
2450 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2451 assumption that selection length fits in 'int'.
2452 (x_reply_selection_request, x_handle_selection_request)
2453 (x_get_window_property, receive_incremental_selection)
2454 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2455 (lisp_data_to_selection_data, clean_local_selection_data):
2456 Use ptrdiff_t, not int, to record length of selection.
2457 (x_reply_selection_request, x_get_window_property)
2458 (receive_incremental_selection, x_property_data_to_lisp):
2459 Redo calculations to avoid overflow.
2460 (x_reply_selection_request): When sending hint, ceiling it at
2461 X_LONG_MAX rather than relying on wraparound overflow to send
2462 something.
2463 (x_get_window_property, receive_incremental_selection)
2464 (lisp_data_to_selection_data, x_property_data_to_lisp):
2465 Check for size-calculation overflow.
2466 (x_get_window_property, receive_incremental_selection)
2467 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2468 Don't store size until memory allocation succeeds.
2469 (x_get_window_property): Plug memory leak on memory exhaustion.
2470 Don't double-block input; malloc is safe here. Don't assume 2**34
2471 - 4 fits in unsigned long. Add an xassert to check
2472 XGetWindowProperty overflow. Be more careful about overflow
2473 calculations, and distinguish size from memory overflow better.
2474 (receive_incremental_selection): When tracing, don't assume
2475 unsigned int is less than INT_MAX.
2476 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2477 harmful) conversions of unsigned short to int.
2478 (lisp_data_to_selection_data): Don't assume that integers
2479 in the range -65535 through -1 fit in an X unsigned short.
2480 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2481 result parameters unless successful. Rely on cons_to_unsigned
2482 to report problems with elements; the old code wasn't right anyway.
2483 (x_check_property_data): Check for int overflow; we cannot use
2484 a wider type due to X limits.
2485 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2486
2487 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2488
2489 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2490 (x_term_init): Check for size calculation overflow.
2491 (x_color_cells): Don't store size until memory allocation succeeds.
2492 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2493 Don't assume alloca size is less than MAX_ALLOCA.
2494 (x_term_init): Don't assume length fits in int (sprintf is limited
2495 to int size).
2496
2497 Use ptrdiff_t for composition IDs.
2498 * character.c (lisp_string_width):
2499 * composite.c (composition_table_size, n_compositions)
2500 (get_composition_id, composition_gstring_from_id):
2501 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2502 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2503 * window.c (Frecenter):
2504 Use ptrdiff_t, not int, for composition IDs.
2505 * composite.c (get_composition_id): Check for integer overflow.
2506 * composite.h: Adjust prototypes to match the above changes.
2507
2508 Use ptrdiff_t for hash table indexes.
2509 * category.c (hash_get_category_set):
2510 * ccl.c (ccl_driver):
2511 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2512 * coding.c (coding_system_charset_list, detect_coding_system):
2513 * coding.h (struct coding_system.id):
2514 * composite.c (get_composition_id, gstring_lookup_cache):
2515 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2516 * image.c (xpm_get_color_table_h):
2517 * lisp.h (hash_lookup, hash_put):
2518 * minibuf.c (Ftest_completion):
2519 Use ptrdiff_t for hash table indexes, not int (which is too
2520 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2521 32-bit --with-wide-int hosts).
2522
2523 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2524 Add a FIXME comment about memory leaks.
2525 (syms_of_charset): Don't assume xmalloc returns.
2526
2527 Don't assume that stated character widths fit in int.
2528 * character.c (Fchar_width, c_string_width, lisp_string_width):
2529 * character.h (CHAR_WIDTH):
2530 * indent.c (MULTIBYTE_BYTES_WIDTH):
2531 Use sanitize_char_width to avoid undefined and/or bad behavior
2532 with outlandish widths.
2533 * character.h (sanitize_tab_width): Rename from sanitize_width,
2534 now that we have two such functions. All uses changed.
2535 (sanitize_char_width): New inline function.
2536
2537 Don't assume that tab-width fits in int.
2538 * character.h (sanitize_width): New inline function.
2539 (SANE_TAB_WIDTH): New macro.
2540 (ASCII_CHAR_WIDTH): Use it.
2541 * indent.c (sane_tab_width): Remove. All uses replaced by
2542 SANE_TAB_WIDTH (current_buffer).
2543 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2544
2545 * fileio.c: Integer overflow issues with file modes.
2546 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2547
2548 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2549 Remove unreachable code.
2550 (read_hex, load_charset_map_from_file): Check for integer overflow.
2551
2552 * xterm.c: Don't go over XClientMessageEvent limit.
2553 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2554 (x_send_scroll_bar_event): Likewise. Check that the size does not
2555 exceed limits imposed by XClientMessageEvent, as well as the usual
2556 ptrdiff_t and size_t limits.
2557
2558 * keyboard.c: Overflow, signedness and related fixes.
2559 (make_lispy_movement): Use same integer type in forward decl
2560 that is used in the definition.
2561 (read_key_sequence, keyremap_step):
2562 Change bufsize argument back to int, undoing my 2011-03-30 change.
2563 We prefer signed types, and int is wide enough here.
2564 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2565 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2566 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2567 length, not size_t. Use ptrdiff_t for index, not int.
2568 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2569 possibility of integer overflow.
2570
2571 Overflow, signedness and related fixes for images.
2572
2573 * dispextern.h (struct it.stack[0].u.image.image_id)
2574 (struct_it.image_id, struct image.id, struct image_cache.size)
2575 (struct image_cache.used, struct image_cache.ref_count):
2576 * gtkutil.c (update_frame_tool_bar):
2577 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2578 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2579 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2580 * nsmenu.m (update_frame_tool_bar):
2581 * xdisp.c (calc_pixel_width_or_height):
2582 * xfns.c (image_cache_refcount):
2583 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2584 on typical 64-bit hosts.
2585
2586 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2587 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2588 Omit unnecessary casts to int.
2589 (parse_image_spec): Check that integers fall into 'int' range
2590 when the callers expect that.
2591 (image_ascent): Redo ascent calculation to avoid int overflow.
2592 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2593 (lookup_image): Remove unnecessary tests.
2594 (xbm_image_p): Locals are now of int, not EMACS_INT,
2595 since parse_image_check makes sure they fit into int.
2596 (png_load, gif_load, svg_load_image):
2597 Prefer int to unsigned where either will do.
2598 (tiff_handler): New function, combining the cores of the
2599 old tiff_error_handler and tiff_warning_handler.
2600 This function is rewritten to use vsnprintf and thereby avoid
2601 stack buffer overflows. It uses only the features of vsnprintf
2602 that are common to both POSIX and native Microsoft.
2603 (tiff_error_handler, tiff_warning_handler): Use it.
2604 (tiff_load, gif_load, imagemagick_load_image):
2605 Don't assume :index value fits in 'int'.
2606 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2607 (imagemagick_load_image): Check that crop parameters fit into
2608 the integer types that MagickCropImage accepts. Don't assume
2609 Vimagemagick_render_type has a nonnegative value. Don't assume
2610 size_t fits in 'long'.
2611 (gs_load): Use printmax_t to print the widest integers possible.
2612 Check for integer overflow when computing image height and width.
2613
2614 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2615
2616 * xdisp.c (redisplay_window): Don't force window start if point
2617 will be invisible in the resulting window. (Bug#9324)
2618
2619 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2620
2621 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2622 the display spec is of the form `(space ...)'.
2623 (handle_display_spec): Return the value returned by
2624 handle_single_display_spec, not just 1 or zero.
2625 (handle_single_display_spec): If the display spec is of the form
2626 `(space ...)', and specifies display in the text area, return 2
2627 rather than 1.
2628 (try_cursor_movement): Check for the need to scroll more
2629 accurately, and prefer exact match for point under bidi.
2630 Don't advance `row' beyond the last row of the window.
2631
2632 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2633 into disp_prop; all users changed.
2634
2635 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2636 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2637 for the text covered by the display property.
2638
2639 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2640
2641 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2642 Change return value to nil.
2643 (Frecord_buffer): Delete unused function.
2644
2645 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2646
2647 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2648 buffers, return left-to-right.
2649 (set_cursor_from_row): Consider candidate row a win if its glyph
2650 represents a newline and point is on that newline. Fixes cursor
2651 positioning on the newline at EOL of R2L text within L2R
2652 paragraph, and vice versa.
2653 (try_cursor_movement): Check continued rows, in addition to
2654 continuation rows. Fixes unwarranted scroll when point enters a
2655 continued line of R2L text within an L2R paragraph, or vice versa.
2656 (cursor_row_p): Consider the case of point being equal to
2657 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2658 from the end of a short line to the beginning of a continued line
2659 of R2L text within L2R paragraph.
2660 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2661 composed characters.
2662
2663 * bidi.c (bidi_check_type): Use xassert.
2664 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2665 members.
2666
2667 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2668
2669 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2670 a character.
2671
2672 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2673
2674 * nsfont.m (ns_otf_to_script): Fix typo.
2675
2676 2011-08-22 Kenichi Handa <handa@m17n.org>
2677
2678 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2679 extra slot even if the purpose is char-code-property-table.
2680
2681 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2682
2683 * xdisp.c (redisplay_window): When computing centering_position,
2684 account for the height of the header line. (Bug#8874)
2685
2686 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2687 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2688 candidate is selected by the mouse, and that candidate has a
2689 composed character under the mouse.
2690
2691 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2692 coordinates reported by pos-visible-in-window-p for a composed
2693 character in column zero.
2694
2695 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2696
2697 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2698
2699 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2700
2701 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2702 consider it a hit if to_charpos is anywhere in the range of the
2703 composed buffer positions.
2704
2705 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2706
2707 * image.c (gif_load): Don't assume that each subimage has the same
2708 dimensions as the base image. Handle disposal method that is
2709 "undefined" by the gif spec (Bug#9335).
2710
2711 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2712
2713 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2714 (Fcondition_case): Document `debug' symbol in error handler.
2715
2716 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2717
2718 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2719 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2720 from an Org mode buffer to a Speedbar frame.
2721
2722 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2723 a composition, take its buffer position from IT->cmp_it.charpos.
2724 Fixes cursor positioning at the beginning of a line that begins
2725 with a composed character.
2726
2727 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2728
2729 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2730 character bidirectional type, use STRONG_L instead. Fixes crashes
2731 in a buffer produced by `describe-categories'.
2732
2733 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2734 members before the level stack, so they would be saved and
2735 restored when copying iterator state. Fixes incorrect reordering
2736 around TABs covered by display properties.
2737
2738 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2739
2740 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2741
2742 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2743
2744 * eval.c (internal_condition_case, internal_condition_case_1)
2745 (internal_condition_case_2, internal_condition_case_n):
2746 Remove unnecessary aborts (Bug#9081).
2747
2748 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2749
2750 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2751 has no `load' handler, try opening the file locally. (Bug#9311)
2752
2753 2011-08-16 Ken Brown <kbrown@cornell.edu>
2754
2755 * gmalloc.c: Expand comment.
2756
2757 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2758
2759 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2760 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2761
2762 2011-08-16 Ken Brown <kbrown@cornell.edu>
2763
2764 Fix memory allocation problems in Cygwin build (Bug#9273).
2765
2766 * unexcw.c ( __malloc_initialized): Declare external variable.
2767 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2768
2769 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2770 New variables.
2771 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2772 dumped emacs.
2773 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2774 in the static heap.
2775 [CYGWIN] (special_realloc): New function.
2776 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2777 requests to realloc storage in the static heap.
2778
2779 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2780
2781 * bidi.c (bidi_initialize): Remove unused local.
2782
2783 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2784
2785 * bidimirror.h:
2786 * biditype.h: Remove file.
2787 * makefile.w32-in ($(BLD)/bidi.$(O)):
2788 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2789
2790 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2791
2792 * chartab.c: Improve commentary for the uniprop_table API.
2793
2794 * bidi.c (bidi_paragraph_init): Support zero value of
2795 bidi_ignore_explicit_marks_for_paragraph_level.
2796 (bidi_initialize): Use uniprop_table instead of including
2797 biditype.h and bidimirror.h.
2798
2799 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2800 coordinates of the iterator when restoring from ppos_it.
2801 (Bug#9296)
2802
2803 2011-08-14 Kenichi Handa <handa@m17n.org>
2804
2805 * process.c (create_process): Call setup_process_coding_systems
2806 after the pid of the process is set to -1 (Bug#8162).
2807
2808 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2809
2810 * xdisp.c (move_it_in_display_line_to): Don't invoke
2811 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2812 ppos_it. Fixes vertical cursor motion when line beginning is
2813 covered by an image. (Bug#9296)
2814
2815 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2816
2817 * nsterm.h (ns_run_ascript): Declare.
2818 (NSAPP_DATA2_RUNASSCRIPT): Define.
2819
2820 * nsfns.m (as_script, as_result, as_status): New static variables.
2821 (ns_run_ascript): New function.
2822 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2823 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2824 the event loop. Get status from as_status (Bug#7276).
2825
2826 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2827 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2828 the event loop (Bug#7276).
2829
2830 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2831
2832 * gnutls.c (QCgnutls_bootprop_priority)
2833 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2834 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2835 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2836 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2837 (QCgnutls_bootprop_verify_hostname_error)
2838 (QCgnutls_bootprop_callbacks_verify): Rename from
2839 Qgnutls_bootprop_..., all uses changed.
2840
2841 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2842 uses changed.
2843
2844 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2845
2846 * xfaces.c (Qframe_set_background_mode): Now static.
2847 * dispextern.h (Qframe_set_background_mode): Remove decl.
2848
2849 * process.c (Fnetwork_interface_info): Declare local only if needed.
2850
2851 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2852
2853 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2854 (Fnetwork_interface_list): Allocate in increments of bytes instead
2855 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2856 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2857 sockaddr.
2858 (struct ifflag_def): notrailers is smart on OSX.
2859 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2860 Get hardware address with getifaddrs if available.
2861
2862 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2863
2864 * xdisp.c (iterate_out_of_display_property): xassert that
2865 IT->position is set to within IT->object's boundaries. Break from
2866 the loop as soon as EOB is reached; avoids infloops in redisplay
2867 when IT->position is set up wrongly due to some bug.
2868 Set IT->current to match the bidi iterator unconditionally.
2869 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2870 entry. Force push_it to save on the stack the current
2871 buffer/string position, to be restored by pop_it. Fix flags in
2872 the iterator structure wrt the object coming from a display
2873 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2874 properties. (Bug#9284)
2875
2876 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2877
2878 * fontset.c (fontset_get_font_group): Add proper type checks.
2879 (Bug#9172)
2880
2881 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2882
2883 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2884 and LC_VERSION_MIN_MACOSX.
2885 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2886 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2887
2888 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2889
2890 * xdisp.c (forward_to_next_line_start): Allow to use the
2891 no-display-properties-and-no-overlays under bidi display.
2892 Set disp_pos in the bidi iterator to avoid searches for display
2893 properties and overlays.
2894
2895 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2896
2897 * editfns.c (Fset_time_zone_rule): Document relationship with the
2898 setenv function.
2899
2900 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2901 the font entity extracted from the cache (Bug#8109).
2902
2903 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2904
2905 * composite.c (autocmp_chars): Don't reset point. That is done by
2906 restore_point_unwind (Bug#5984).
2907
2908 2011-08-07 Juri Linkov <juri@jurta.org>
2909
2910 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2911 to show the arg `TIME' instead of `TIMEVAL'.
2912
2913 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2914
2915 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2916 display property strides EOL and includes a newline, as in
2917 longlines-mode. (Bug#9254)
2918 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2919 word-wrap under bidirectional display. (Bug#9224)
2920
2921 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2922 is non-zero, even if the data buffer is NULL. Fixes a crash in
2923 vertical-motion with longlines-mode. (Bug#9254)
2924
2925 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2926
2927 * bidi.c <bidi_cache_total_alloc>: Now static.
2928 (bidi_initialize): Initialize bidi_cache_total_alloc.
2929
2930 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2931 cache. (Bug#9221)
2932
2933 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2934 amount allocated this far in `bidi_cache_total_alloc'.
2935 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2936 non-zero, only free the data buffer without restoring the cache
2937 contents. All callers changed.
2938
2939 * dispextern.h (bidi_unshelve_cache): Update prototype.
2940
2941 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2942 (move_it_in_display_line, move_it_to)
2943 (move_it_vertically_backward, move_it_by_lines): Replace the call
2944 to xfree to an equivalent call to bidi_unshelve_cache.
2945 (move_it_in_display_line_to): Fix logic of returning
2946 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2947
2948 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2949
2950 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2951 came from a string character with a `cursor' property. (Bug#9229)
2952
2953 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2954
2955 * Makefile.in (LIB_PTHREAD): New variable.
2956 (LIBES): Add LIB_PTHREAD (Bug#9216).
2957
2958 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2959 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2960
2961 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2962
2963 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2964
2965 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2966
2967 * xterm.c (x_find_topmost_parent): New function.
2968 (x_set_frame_alpha): Find topmost parent window with
2969 x_find_topmost_parent and set the property there also (bug#9181).
2970 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2971
2972 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2973
2974 * callproc.c (Fcall_process): Avoid vfork clobbering
2975 the local vars buffer, coding_systems, current_dir.
2976
2977 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2978
2979 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2980
2981 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2982
2983 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2984 so that it is not optimized away.
2985
2986 * xdisp.c (compute_display_string_pos): Remove unused local.
2987
2988 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2989
2990 Fix slow cursor motion and scrolling in large buffers with
2991 selective display, like Org Mode buffers. (Bug#9218)
2992
2993 * dispextern.h (struct bidi_it): New member disp_prop_p.
2994
2995 * xdisp.c: Remove one-slot cache of display string positions.
2996 (compute_display_string_pos): Accept an additional argument
2997 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2998 for a display string or property. If found, set DISP_PROP_P
2999 non-zero.
3000
3001 * bidi.c (bidi_fetch_char): Accept an additional argument
3002 DISP_PROP_P, and pass it to compute_display_string_pos.
3003 Only handle text covered by a display string if DISP_PROP_P is returned
3004 non-zero. All callers of bidi_fetch_char changed.
3005
3006 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3007
3008 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3009
3010 2010-12-03 Don March <don@ohspite.net>
3011
3012 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3013 last character M-[char] is translated to ESC [char] (bug#7541).
3014
3015 2011-08-02 Kenichi Handa <handa@m17n.org>
3016
3017 * lisp.h (uniprop_table): Extern it.
3018
3019 * chartab.c (uniprop_table): Make it non-static.
3020
3021 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3022
3023 * xdisp.c (forward_to_next_line_start): Accept additional argument
3024 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3025 on the newline.
3026 (reseat_at_next_visible_line_start): Use the bidi iterator state
3027 returned by forward_to_next_line_start to restore the state of
3028 it->bidi_it after backing up to previous newline. (Bug#9212)
3029
3030 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3031
3032 * regex.c (re_comp): Protoize.
3033 (re_exec): Fix return type.
3034 (regexec): Fix type of `ret'. (Bug#9203)
3035
3036 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3037
3038 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3039 This is needed if max-image-size is a floating-point number.
3040
3041 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3042
3043 * print.c (print_object): Print empty symbol as ##.
3044
3045 * lread.c (read1): Read ## as empty symbol.
3046
3047 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3048
3049 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3050 setting frame foreground color (Bug#9175).
3051 (x_set_background_color): Likewise.
3052
3053 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3054 contents (Bug#9176).
3055 (EmacsTooltip -init): Remove bezels and add shadows to
3056 tooltip windows.
3057
3058 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3059 or scroll bar (Bug#8470).
3060
3061 * nsfont.m (nsfont_open): Remove assignment to voffset and
3062 unnecessary vars hshink, expand, hd, full_height, min_height.
3063 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3064
3065 * nsterm.h (nsfont_info): Remove voffset field.
3066
3067 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3068
3069 Implement strike-through and overline on NextStep (Bug#8863).
3070
3071 * nsfont.m (nsfont_open): Use underline position provided by font,
3072 instead of hard-coded value of 2.
3073 (nsfont_draw): Call ns_draw_text_decoration instead.
3074
3075 * nsterm.h: Add declaration for ns_draw_text_decoration.
3076
3077 * nsterm.m (ns_draw_text_decoration): New function for drawing
3078 underline, overline, and strike-through.
3079 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3080 ns_draw_text_decoration. Change treatment of cursor drawing to
3081 accommodate underlining, etc.
3082
3083 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3084
3085 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3086 default.
3087
3088 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3089
3090 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3091 Without this fix, if a signal arrives just after memory fills up,
3092 'malloc' might be invoked reentrantly.
3093
3094 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3095 In other words, assume that every image size is allowed, on non-X
3096 hosts. This assumption is probably wrong, but it lets Emacs compile.
3097
3098 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3099
3100 * regex.c (re_iswctype): Convert return values to boolean.
3101
3102 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3103
3104 * xdisp.c (compute_display_string_pos): Don't use cached display
3105 string position if the buffer had its restriction changed.
3106 (Bug#9184)
3107
3108 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3109
3110 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3111
3112 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3113
3114 Integer signedness and overflow and related fixes. (Bug#9079)
3115
3116 * bidi.c: Integer size and overflow fixes.
3117 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3118 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3119 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3120 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3121 (bidi_find_other_level_edge):
3122 Use ptrdiff_t instead of EMACS_INT where either will do.
3123 This works better on 32-bit hosts configured --with-wide-int.
3124 (bidi_cache_ensure_space): Check for size-calculation overflow.
3125 Use % rather than repeated addition, for better worst-case speed.
3126 Don't set bidi_cache_size until after xrealloc returns, because it
3127 might not return.
3128 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3129 (bidi_cache_ensure_space): Also check that the bidi cache size
3130 does not exceed that of the largest Lisp string or buffer. See Eli
3131 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3132
3133 * alloc.c (__malloc_size_t): Remove.
3134 All uses replaced by size_t. See Andreas Schwab's note
3135 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3136
3137 * image.c: Improve checking for integer overflow.
3138 (check_image_size): Assume that f is nonnull, since
3139 it is always nonnull in practice. This is one less thing to
3140 worry about when checking for integer overflow later.
3141 (x_check_image_size): New function, which checks for integer
3142 overflow issues inside X.
3143 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3144 This removes the need for a memory_full check.
3145 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3146 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3147 (xbm_read_bitmap_data): Change locals back to 'int', since
3148 their values must fit in 'int'.
3149 (xpm_load_image, png_load, tiff_load):
3150 Invoke x_create_x_image_and_pixmap earlier,
3151 to avoid much needless work if the image is too large.
3152 (tiff_load): Treat overly large images as if
3153 x_create_x_image_and_pixmap failed, not as malloc failures.
3154 (gs_load): Use x_check_image_size.
3155
3156 * gtkutil.c: Omit integer casts.
3157 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3158 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3159
3160 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3161
3162 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3163 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3164 would wrongly return t on a 64-bit host.
3165
3166 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3167 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3168 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3169 and therefore cause GCC to emit a bogus diagnostic in some cases.
3170
3171 * image.c: Integer signedness and overflow and related fixes.
3172 This is not an exhaustive set of fixes, but it's time to
3173 record what I've got.
3174 (lookup_pixel_color, check_image_size): Remove redundant decls.
3175 (check_image_size): Don't assume that arbitrary EMACS_INT values
3176 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3177 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3178 (tiff_load, imagemagick_load_image):
3179 Check for overflow in size calculations.
3180 (x_create_x_image_and_pixmap): Remove unnecessary test for
3181 xmalloc returning NULL; that can't happen.
3182 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3183 (xpm_color_bucket): Use better integer hashing function.
3184 (xpm_cache_color): Don't possibly over-allocate memory.
3185 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3186 (gif_memory_source):
3187 Use ptrdiff_t, not int or size_t, to record sizes.
3188 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3189 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3190 either works, as we prefer signed integers.
3191 (tiff_read_from_memory, tiff_write_from_memory):
3192 Return tsize_t, not size_t, since that's what the TIFF API wants.
3193 (tiff_read_from_memory): Don't fail simply because the read would
3194 go past EOF; instead, return a short read.
3195 (tiff_load): Omit no-longer-needed casts.
3196 (Fimagemagick_types): Don't assume size fits into 'int'.
3197
3198 Improve hashing quality when configured --with-wide-int.
3199 * fns.c (hash_string): New function, taken from sxhash_string.
3200 Do not discard information about ASCII character case; this
3201 discarding is no longer needed.
3202 (sxhash-string): Use it. Change sig to match it. Caller changed.
3203 * lisp.h: Declare it.
3204 * lread.c (hash_string): Remove, since we now use fns.c's version.
3205 The fns.c version returns a wider integer if --with-wide-int is
3206 specified, so this should help the quality of the hashing a bit.
3207
3208 * emacs.c: Integer overflow minor fix.
3209 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3210 Define only if GNU_LINUX.
3211 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3212
3213 * dispnew.c: Integer signedness and overflow fixes.
3214 Remove unnecessary forward decls, that were a maintenance hassle.
3215 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3216 All uses changed.
3217 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3218 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3219 (prepare_desired_row, line_draw_cost):
3220 Use int, not unsigned, where either works.
3221 (save_current_matrix, restore_current_matrix):
3222 Use ptrdiff_t, not size_t, where either works.
3223 (init_display): Check for overflow more accurately, and without
3224 relying on undefined behavior.
3225
3226 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3227 Remove, replacing with the new symbols in lisp.h. All uses changed.
3228 * fileio.c (make_temp_name):
3229 * filelock.c (lock_file_1, lock_file):
3230 * xdisp.c (message_dolog):
3231 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3232 Use pMd etc. instead.
3233 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3234 replacing the pWIDE etc. symbols removed from editfns.c.
3235
3236 * keyboard.h (num_input_events): Now uintmax_t.
3237 This is (very slightly) less likely to mess up due to wraparound.
3238 All uses changed.
3239
3240 * buffer.c: Integer signedness fixes.
3241 (alloc_buffer_text, enlarge_buffer_text):
3242 Use ptrdiff_t rather than size_t when either will do, as we prefer
3243 signed integers.
3244
3245 * alloc.c: Integer signedness and overflow fixes.
3246 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3247 (__malloc_size_t): Default to size_t, not to int.
3248 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3249 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3250 Prefer ptrdiff_t to size_t when either would do, as we prefer
3251 signed integers.
3252 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3253 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3254 Now const. Initialize with values that are in range even if char
3255 is signed.
3256 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3257 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3258 These functions do the right thing with sizes > 2**32.
3259 (check_depth): Now ptrdiff_t, not int.
3260 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3261 Adjust to new way of storing sizes. Check for size overflow bugs
3262 in rest of code.
3263 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3264 slightly wrong anyway, as it missed one instance of
3265 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3266 (refill_memory_reserve): Omit needless cast to size_t.
3267 (mark_object_loop_halt): Mark as externally visible.
3268
3269 * xselect.c: Integer signedness and overflow fixes.
3270 (Fx_register_dnd_atom, x_handle_dnd_message):
3271 Use ptrdiff_t, not size_t, since we prefer signed.
3272 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3273 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3274 x_dnd_atoms_size and x_dnd_atoms_length.
3275
3276 * doprnt.c: Prefer signed to unsigned when either works.
3277 * eval.c (verror):
3278 * doprnt.c (doprnt):
3279 * lisp.h (doprnt):
3280 * xdisp.c (vmessage):
3281 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3282 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3283 prefer signed arithmetic to avoid comparison confusion.
3284 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3285 but is a bit tricky.
3286
3287 Assume freestanding C89 headers, string.h, stdlib.h.
3288 * data.c, doprnt.c, floatfns.c, print.c:
3289 Include float.h unconditionally.
3290 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3291 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3292 * regex.c: Likewise for stddef.h, string.h.
3293 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3294 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3295 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3296 (STDC_HEADERS): Remove obsolete defines.
3297 * sysdep.c: Include limits.h unconditionally.
3298
3299 Assume support for memcmp, memcpy, memmove, memset.
3300 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3301 * regex.c (memcmp, memcpy):
3302 Remove; we assume C89 now.
3303
3304 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3305 (__malloc_safe_bcopy): Remove; no longer needed.
3306
3307 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3308 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3309 well either way, and we prefer signed to unsigned.
3310
3311 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3312
3313 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3314 closes the connection while we're reading (bug#9182).
3315
3316 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3317
3318 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3319 are specified (Bug#9168).
3320
3321 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3322
3323 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3324 Found by GCC static checking and --with-wide-int on a 32-bit host.
3325
3326 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3327
3328 * xdisp.c (compute_display_string_pos): Fix logic of caching
3329 previous display string position. Initialize cached_prev_pos to
3330 -1. Fixes slow-down at the beginning of a buffer.
3331
3332 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3333
3334 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3335 for attrs[LFACE_FONTSET_INDEX].
3336
3337 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3338
3339 * xml.c (parse_region): Remove unused local
3340 that was recently introduced.
3341
3342 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3343
3344 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3345 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3346
3347 * xdisp.c (move_it_in_display_line_to): Record the best matching
3348 position for TO_CHARPOS while scanning the line, and restore it on
3349 exit if none of the characters scanned was an exact match.
3350 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3351 when exact match is impossible due to invisible text, and the
3352 lines are truncated.
3353
3354 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3355
3356 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3357 for OSX >= 10.7.
3358
3359 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3360
3361 Fix a significant slow-down of cursor motion with C-n, C-p,
3362 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3363 auto-repeat under bidi redisplay in fontified buffers.
3364 * xdisp.c (compute_stop_pos_backwards): New function.
3365 (next_element_from_buffer): Call compute_stop_pos_backwards to
3366 find a suitable prev_stop when we find ourselves before
3367 base_level_stop.
3368 (reseat): Don't look for prev_stop, as that could mean a very long
3369 run.
3370 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3371 <cached_disp_overlay_modiff>: Cache for last found display string
3372 position.
3373 (compute_display_string_pos): Return the cached position if asked
3374 about the same buffer in the same area of character positions, and
3375 the buffer wasn't changed since the time the display string
3376 position was cached.
3377
3378 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3379
3380 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3381 is an integer, which is important for empty lines. (Bug#9149)
3382
3383 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3384
3385 * frame.c (Fmodify_frame_parameters): In tty case, update the
3386 default face if necessary (Bug#4238).
3387
3388 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3389
3390 * editfns.c (Fstring_to_char): No need to explain what a character
3391 is in the docstring (Bug#6576).
3392
3393 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3394
3395 * xml.c (parse_region): Make sure we always return a tree.
3396
3397 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3398
3399 * xml.c (parse_region): If a document contains only comments,
3400 return that, too.
3401
3402 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3403
3404 * xml.c (make_dom): Return comments, too.
3405
3406 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3407
3408 Port to OpenBSD.
3409 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3410 and the surrounding thread.
3411 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3412 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3413 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3414 timer goes off.
3415 * s/openbsd.h (BROKEN_SIGIO): Define.
3416 * unexelf.c (unexec) [__OpenBSD__]:
3417 Don't update the .mdebug section of the Alpha COFF symbol table.
3418
3419 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3420
3421 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3422 (bug#8460).
3423
3424 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3425
3426 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3427 This fixes some race conditions on the permissions of any newly
3428 created file.
3429
3430 * alloc.c (valid_pointer_p): Use pipe, not open.
3431 This fixes some permissions issues when debugging.
3432
3433 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3434 If fchown fails to set both uid and gid, try to set just gid,
3435 as that is sometimes allowed. Adjust the file's mode to eliminate
3436 setuid or setgid bits that are inappropriate if fchown fails.
3437
3438 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3439
3440 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3441 to compare Lisp_Objects.
3442 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3443 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3444 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3445
3446 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3447
3448 * lread.c (read_integer): Unread even EOF character.
3449 (read1): Likewise. Properly record start position of symbol.
3450
3451 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3452 symbol character follows.
3453
3454 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3455
3456 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3457 This works around a problem with the previous change to Fcopy_file.
3458 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3459 and without this change, GCC might complain about discarding
3460 fchown's return value.
3461
3462 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3463
3464 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3465
3466 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3467
3468 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3469
3470 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3471
3472 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3473 it's used from the C level.
3474
3475 * process.c: Use the same condition for POLL_FOR_INPUT in both
3476 keyboard.c and process.c (bug#1858).
3477
3478 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3479
3480 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3481 (Fgnutls_boot): Use it.
3482
3483 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3484
3485 * doc.c (Fsubstitute_command_keys): Revert last change.
3486
3487 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3488
3489 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3490 quotes the next character, and doesn't affect other longer
3491 sequences (bug#8935).
3492
3493 * lread.c (syms_of_lread): Clarify that is isn't only
3494 `eval-buffer' and `eval-defun' that's affected by
3495 `lexical-binding' (bug#8460).
3496
3497 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3498
3499 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3500 bidi redisplay when a line includes both an image and is truncated.
3501
3502 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3503
3504 Fix minor problems found by static checking.
3505 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3506 (elsz): Now a signed constant, not a size_t var. We prefer signed
3507 types to unsigned, to avoid integer comparison confusion. Without
3508 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3509 "cannot optimize loop, the loop counter may overflow", a symptom
3510 of the confusion.
3511 * indent.c (Fvertical_motion): Mark locals as initialized.
3512 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3513
3514 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3515
3516 * search.c (Fre_search_backward): Mention `case-fold-search' in
3517 all the re_search_* functions (bug#8138).
3518
3519 * keyboard.c (Fopen_dribble_file): Document when the file is
3520 closed (bug#8056).
3521
3522 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3523
3524 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3525 bidi_cache_idx.
3526
3527 Support bidi reordering of display and overlay strings.
3528 * xdisp.c (compute_display_string_pos)
3529 (compute_display_string_end): Accept additional argument STRING.
3530 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3531 (reseat_to_string): Initialize bidi_it->string.s and
3532 bidi_it->string.schars.
3533 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3534 NULL (avoids a crash in bidi_paragraph_init).
3535 Initialize itb.string.lstring.
3536 (init_iterator): Call bidi_init_it only of a valid
3537 buffer position was specified. Initialize paragraph_embedding to
3538 L2R.
3539 (reseat_to_string): Initialize the bidi iterator.
3540 (display_string): If we need to ignore text properties of
3541 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3542 original value of -1 will not work with bidi.)
3543 (compute_display_string_pos): First arg is now struct
3544 `text_pos *'; all callers changed. Support display properties on
3545 Lisp strings.
3546 (compute_display_string_end): Support display properties on Lisp
3547 strings.
3548 (init_iterator, reseat_1, reseat_to_string): Initialize the
3549 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3550 when iterating on a string not from display properties).
3551 (compute_display_string_pos, compute_display_string_end):
3552 Fix calculation of the object to scan. Fixes an error when using
3553 arrow keys.
3554 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3555 base_level_stop; instead, set base_level_stop to BEGV.
3556 Fixes crashes in vertical-motion.
3557 (next_element_from_buffer): Improve commentary for when
3558 the iterator is before prev_stop.
3559 (init_iterator): Initialize bidi_p from the default value of
3560 bidi-display-reordering, not from buffer-local value. Use the
3561 buffer-local value only if initializing for buffer iteration.
3562 (handle_invisible_prop): Support invisible properties on strings
3563 that are being bidi-reordered.
3564 (set_iterator_to_next): Support bidi reordering of C strings and
3565 Lisp strings.
3566 (next_element_from_string): Support bidi reordering of Lisp
3567 strings.
3568 (handle_stop_backwards): Support Lisp strings as well.
3569 (display_string): Support display of R2L glyph rows.
3570 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3571 (init_iterator): Don't initialize it->bidi_p for strings
3572 here.
3573 (reseat_to_string): Initialize it->bidi_p for strings here.
3574 (next_element_from_string, next_element_from_c_string)
3575 (next_element_from_buffer): Add xassert's for correspondence
3576 between IT's object being iterated and it->bidi_it.string
3577 structure.
3578 (face_before_or_after_it_pos): Support bidi iteration.
3579 (next_element_from_c_string): Handle the case of the first string
3580 character that is not the first one in the visual order.
3581 (get_visually_first_element): New function, refactored from common
3582 parts of next_element_from_buffer, next_element_from_string, and
3583 next_element_from_c_string.
3584 (tool_bar_lines_needed, redisplay_tool_bar)
3585 (display_menu_bar): Force left-to-right direction. Add a FIXME
3586 comment for making that be controlled by a user option.
3587 (push_it, pop_it): Save and restore the state of the
3588 bidi iterator. Save and restore the bidi_p flag.
3589 (pop_it): Iterate out of display property for string iteration as
3590 well.
3591 (iterate_out_of_display_property): Support iteration over strings.
3592 (handle_single_display_spec): Set up it->bidi_it for iteration
3593 over a display string, and call bidi_init_it.
3594 (handle_single_display_spec, next_overlay_string)
3595 (get_overlay_strings_1, push_display_prop): Set up the bidi
3596 iterator for displaying display or overlay strings.
3597 (forward_to_next_line_start): Don't use the shortcut if
3598 bidi-iterating.
3599 (back_to_previous_visible_line_start): If handle_display_prop
3600 pushed the iterator stack, restore the internal state of the bidi
3601 iterator by calling bidi_pop_it same number of times.
3602 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3603 and we are bidi-iterating, don't decrement the iterator position;
3604 instead, set the first_elt flag in the bidi iterator, to produce
3605 the same effect.
3606 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3607 (push_display_prop): xassert that we are iterating a buffer.
3608 (push_it, pop_it): Save and restore paragraph_embedding member.
3609 (handle_single_display_spec, next_overlay_string)
3610 (get_overlay_strings_1, reseat_1, reseat_to_string)
3611 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3612 correctly. Don't assume unibyte strings are not bidi-reordered.
3613 (compute_display_string_pos)
3614 (compute_display_string_end): Fix handling the case of C string.
3615 (push_it, pop_it): Save and restore from_disp_prop_p.
3616 (handle_single_display_spec, push_display_prop): Set the
3617 from_disp_prop_p flag.
3618 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3619 (pop_it): Call iterate_out_of_display_property only if we are
3620 popping after iteration over a string that came from a display
3621 property. Fix a typo in popping stretch info. Add an assertion
3622 for verifying that the iterator position is in sync with the bidi
3623 iterator.
3624 (handle_single_display_spec, get_overlay_strings_1)
3625 (push_display_prop): Fix initialization of paragraph direction for
3626 string when that of the parent object is not yet determined.
3627 (reseat_1): Call bidi_init_it to resync the bidi
3628 iterator with IT's position. (Bug#7616)
3629 (find_row_edges): If ROW->start.pos gives position
3630 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3631 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3632 Reset the from_disp_prop_p flag.
3633 (SAVE_IT, RESTORE_IT): New macros.
3634 (pos_visible_p, face_before_or_after_it_pos)
3635 (back_to_previous_visible_line_start)
3636 (move_it_in_display_line_to, move_it_in_display_line)
3637 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3638 (try_scrolling, redisplay_window, display_line): Use them when
3639 saving a temporary copy of the iterator and restoring it back.
3640 (back_to_previous_visible_line_start, reseat_1)
3641 (init_iterator): Empty the bidi cache "stack".
3642 (move_it_in_display_line_to): If iterator ended up at
3643 EOL, but we never saw any buffer positions smaller than
3644 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3645 motion in bidi-reordered lines.
3646 (move_it_in_display_line_to): Record prev_method and prev_pos
3647 immediately before the call to set_iterator_to_next. Fixes cursor
3648 motion in bidi-reordered lines with stretch glyphs and strings
3649 displayed in margins. (Bug#8133) (Bug#8867)
3650 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3651 TO_CHARPOS.
3652 (pos_visible_p): Support positions in bidi-reordered lines.
3653 Save and restore bidi cache.
3654
3655 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3656 (bidi_paragraph_info): Delete unused struct.
3657 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3658 (bidi_cache_start): New variable.
3659 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3660 to zero.
3661 (bidi_cache_fetch_state, bidi_cache_search)
3662 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3663 (bidi_cache_find, bidi_peek_at_next_level)
3664 (bidi_level_of_next_char, bidi_find_other_level_edge)
3665 (bidi_move_to_visually_next): Compare cache index with
3666 bidi_cache_start rather than with zero.
3667 (bidi_fetch_char): Accept new argument STRING; all callers
3668 changed. Support iteration over a string. Support strings with
3669 display properties. Support unibyte strings. Fix the type of
3670 `len' according to what STRING_CHAR_AND_LENGTH expects.
3671 (bidi_paragraph_init, bidi_resolve_explicit_1)
3672 (bidi_resolve_explicit, bidi_resolve_weak)
3673 (bidi_level_of_next_char, bidi_move_to_visually_next):
3674 Support iteration over a string.
3675 (bidi_set_sor_type, bidi_resolve_explicit_1)
3676 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3677 can now be zero (for strings); special values 0 and -1 were
3678 changed to -1 and -2, respectively.
3679 (bidi_char_at_pos): New function.
3680 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3681 Call it instead of FETCH_MULTIBYTE_CHAR.
3682 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3683 initialized to valid values.
3684 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3685 values.
3686 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3687 the test for valid cached positions. Fix the logic for looking up
3688 the sentinel state in the cache. GCPRO the Lisp string we are
3689 iterating.
3690 (bidi_push_it, bidi_pop_it): New functions.
3691 (bidi_initialize): Initialize the bidi cache start stack pointer.
3692 (bidi_cache_ensure_space): New function, refactored from part of
3693 bidi_cache_iterator_state. Don't assume the required size is just
3694 one BIDI_CACHE_CHUNK away.
3695 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3696 (bidi_count_bytes, bidi_char_at_pos): New functions.
3697 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3698 always valid if bidi_cache_idx is valid.
3699 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3700 is valid if it's going to be used.
3701 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3702 (bidi_cache_fetch_state, bidi_cache_search)
3703 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3704 (bidi_cache_iterator_state, bidi_cache_find)
3705 (bidi_find_other_level_edge, bidi_cache_start_stack):
3706 All variables related to cache indices are now EMACS_INT.
3707
3708 * dispextern.h (struct bidi_string_data): New structure.
3709 (struct bidi_it): New member `string'. Make flag members be 1-bit
3710 fields, and put them last in the struct.
3711 (compute_display_string_pos, compute_display_string_end):
3712 Update prototypes.
3713 (bidi_push_it, bidi_pop_it): Add prototypes.
3714 (struct iterator_stack_entry): New members bidi_p,
3715 paragraph_embedding, and from_disp_prop_p.
3716 (struct it): Member bidi_p is now a bit field 1 bit wide.
3717 (bidi_shelve_cache, bidi_unshelve_cache):
3718 Declare prototypes.
3719
3720 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3721 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3722 and vector-like objects.
3723
3724 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3725 cache around display iteration.
3726
3727 * window.c (Fwindow_end, window_scroll_pixel_based)
3728 (displayed_window_lines, Frecenter): Save and restore the bidi
3729 cache around display iteration.
3730
3731 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3732
3733 * editfns.c (Fdelete_region): Clarify the use of the named
3734 parameters (bug#6788).
3735
3736 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3737
3738 * indent.c (Fvertical_motion): Set and restore w->pointm when
3739 saving and restoring the window's buffer (Bug#9006).
3740
3741 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3742
3743 * editfns.c (Fstring_to_char): Clarify just what is returned
3744 (bug#6576). Text by Eli Zaretskii.
3745
3746 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3747
3748 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3749
3750 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3751
3752 * buffer.c (mmap_find): Fix a typo.
3753
3754 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3755
3756 Fix execution of x selection hooks.
3757 * xselect.c (Qx_lost_selection_functions)
3758 (Qx_sent_selection_functions): New vars.
3759 (syms_of_xselect): DEFSYM them.
3760 (x_handle_selection_request): Pass Qx_sent_selection_functions
3761 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3762 (x_handle_selection_clear,x_clear_frame_selections):
3763 Pass Qx_lost_selection_functions rather than
3764 Vx_lost_selection_functions to Frun_hook_with_args.
3765
3766 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3767
3768 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3769 The old code sometimes used this field without initializing it.
3770
3771 * alloc.c (gc_sweep): Don't read past end of array.
3772 In theory, the old code could also have corrupted Emacs internals,
3773 though it'd be very unlikely.
3774
3775 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3776
3777 * character.c (Fcharacterp): Don't advertise optional ignored
3778 argument. (Bug#4026)
3779
3780 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3781
3782 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3783 key" (bug#4257).
3784
3785 * window.c (Fset_window_start): Doc fix (bug#4199).
3786 (Fset_window_hscroll): Ditto.
3787
3788 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3789
3790 Fix minor new problems caught by GCC 4.6.1.
3791 * term.c (init_tty): Remove unused local.
3792 * xsettings.c (store_monospaced_changed): Define this function only
3793 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3794 not used otherwise.
3795
3796 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3797
3798 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3799
3800 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3801
3802 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3803 are the mini-buffer and the echo area (bug#3320).
3804
3805 * term.c (init_tty): Remove support for supdup, c10 and perq
3806 terminals, which are no longer supported (bug#1482).
3807
3808 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3809
3810 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3811
3812 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3813
3814 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3815 for non-popups (Bug#3642).
3816
3817 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3818
3819 * alloc.c (reset_malloc_hooks): Protoize.
3820 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3821 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3822 * cm.c (losecursor): Likewise.
3823 * data.c (fmod): Likewise.
3824 * dispnew.c (swap_glyphs_in_rows): Likewise.
3825 * emacs.c (memory_warning_signal): Likewise.
3826 * floatfns.c (float_error): Likewise.
3827 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3828 (otf_open, font_otf_capability, generate_otf_features)
3829 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3830 Likewise.
3831 * image.c (pbm_read_file): Likewise.
3832 * indent.c (string_display_width): Likewise.
3833 * intervals.c (check_for_interval, search_for_interval)
3834 (inc_interval_count, count_intervals, root_interval)
3835 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3836 * lread.c (defalias): Likewise.
3837 * ralloc.c (r_alloc_check): Likewise.
3838 * regex.c (set_image_of_range_1, set_image_of_range)
3839 (regex_grow_registers): Likewise.
3840 * sysdep.c (strerror): Likewise.
3841 * termcap.c (valid_filename_p, tprint, main): Likewise.
3842 * tparam.c (main): Likewise.
3843 * unexhp9k800.c (run_time_remap, save_data_space)
3844 (update_file_ptrs, read_header, write_header, calculate_checksum)
3845 (copy_file, copy_rest, display_header): Likewise.
3846 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3847 Likewise.
3848 * xdisp.c (check_it): Likewise.
3849 * xfaces.c (register_color, unregister_color, unregister_colors):
3850 Likewise.
3851 * xfns.c (print_fontset_result): Likewise.
3852 * xrdb.c (member, fatal, main): Likewise.
3853
3854 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3855
3856 Fix minor problems found by static checking (Bug#9031).
3857 * chartab.c (char_table_set_range, map_sub_char_table):
3858 Remove unused locals.
3859 (uniprop_table): Now static.
3860 * composite.c (_work_char): Remove unused static var.
3861
3862 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3863
3864 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3865
3866 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3867
3868 * gtkutil.c (qttip_cb): Remove code without function.
3869
3870 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3871
3872 * w32.c (pthread_sigmask): New stub.
3873
3874 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 Use pthread_sigmask, not sigprocmask (Bug#9010).
3877 sigprocmask is portable only for single-threaded applications, and
3878 Emacs can be multi-threaded when it uses GTK.
3879 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3880 (LIBES): Use it.
3881 * callproc.c (Fcall_process):
3882 * process.c (create_process):
3883 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3884 Use pthread_sigmask, not sigprocmask.
3885
3886 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3887
3888 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3889 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3890 wrong (Bug#8591).
3891
3892 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3893
3894 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3895 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3896 (xg_hide_tooltip): Fix comment.
3897
3898 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3899 in registerServicesMenuSendTypes.
3900 (validRequestorForSendType): Don't check ns_return_types.
3901
3902 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3903 ns_return_type.
3904
3905 2011-07-08 Jason Rumney <jasonr@gnu.org>
3906
3907 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3908 SH_SHOW for hidden windows (Bug#5482).
3909
3910 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3911 frame struct members of non-existent frames (Bug#6284).
3912
3913 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3914
3915 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3916 variable firstTime not needed on OSX >= 10.6.
3917 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3918 >= 10.5. Use setKnobProportion, setDoubleValue.
3919
3920 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3921 (MAC_OS_X_VERSION_10_5): Define if not defined.
3922 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3923 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3924 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3925
3926 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3927 cString and lossyCString on OSX >= 10.4
3928
3929 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3930 sizeToFit on OSX >= 10.2.
3931
3932 * nsimage.m (allocInitFromFile): Don't use deprecated method
3933 bestRepresentationForDevice on OSX >= 10.6.
3934
3935 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3936 to avoid warning.
3937
3938 * emacs.c: Declare unexec_init_emacs_zone.
3939
3940 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3941
3942 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3943
3944 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3945 on svcsMenu (Bug#8842).
3946
3947 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3948 ns_return_types.
3949 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3950
3951 * nsterm.m (QUTF8_STRING): Declare.
3952 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3953 (validRequestorForSendType): Return type is (id).
3954 Change indexOfObjectIdenticalTo to indexOfObject.
3955 Check if we have local selection before returning self (Bug#8842).
3956 (writeSelectionToPasteboard): Put local selection into paste board
3957 if we have a local selection (Bug#8842).
3958 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3959
3960 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3961 (ns_get_local_selection): Declare.
3962
3963 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3964
3965 * keymap.c (describe_map_tree): Don't insert a double newline at
3966 the end of the buffer (bug#1169) and return whether we inserted
3967 something.
3968
3969 * callint.c (Fcall_interactively): Change "reading args" to
3970 "providing args" to try to clarify what it does (bug#1010).
3971
3972 2011-07-07 Kenichi Handa <handa@m17n.org>
3973
3974 * composite.c (composition_compute_stop_pos): Ignore a static
3975 composition starting before CHARPOS (Bug#8915).
3976
3977 * xdisp.c (handle_composition_prop): Likewise.
3978
3979 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3980
3981 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3982 (Bug#9015)
3983
3984 2011-07-07 Kenichi Handa <handa@m17n.org>
3985
3986 * character.h (unicode_category_t): New enum type.
3987
3988 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3989 (Qchar_code_property_table): New variable.
3990 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3991 (UNIPROP_COMPRESSED_FORM_P): New macros.
3992 (char_table_ascii): Uncompress the compressed values.
3993 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3994 Uncompress the compressed values.
3995 (sub_char_table_ref_and_range): Likewise.
3996 (char_table_ref_and_range): Uncompress the compressed values.
3997 (sub_char_table_set): New arg is_uniprop. Callers changed.
3998 Uncompress the compressed values.
3999 (sub_char_table_set_range): Args changed. Callers changed.
4000 (char_table_set_range): Adjuted for the above change.
4001 (map_sub_char_table): Delete args default_val and parent. Add arg
4002 top. Give decoded values to a Lisp function.
4003 (map_char_table): Adjust for the above change. Give decoded
4004 values to a Lisp function. Gcpro more variables.
4005 (uniprop_table_uncompress)
4006 (uniprop_decode_value_run_length): New functions.
4007 (uniprop_decoder, uniprop_decoder_count): New variables.
4008 (uniprop_get_decoder, uniprop_encode_value_character)
4009 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4010 New functions.
4011 (uniprop_encoder, uniprop_encoder_count): New variables.
4012 (uniprop_get_encoder, uniprop_table)
4013 (Funicode_property_table_internal, Fget_unicode_property_internal)
4014 (Fput_unicode_property_internal): New functions.
4015 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4016 Sunicode_property_table_internal, Sget_unicode_property_internal,
4017 and Sput_unicode_property_internal. Defvar_lisp
4018 char-code-property-alist.
4019
4020 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4021 Vunicode_category_table.
4022
4023 * font.c (font_range): Adjust for the change of
4024 Vunicode_category_table.
4025
4026 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4027
4028 * m/iris4d.h: Remove file, move contents ...
4029 * s/irix6-5.h: ... here.
4030
4031 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4032
4033 Remove unportable assumption about struct layout (Bug#8884).
4034 * alloc.c (mark_buffer):
4035 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4036 (clone_per_buffer_values): Don't assume that
4037 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4038 This isn't true in general, and it's particularly not true
4039 if Emacs is configured with --with-wide-int.
4040 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4041 New macros, used in the buffer.c change.
4042
4043 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4044
4045 * xsettings.c: Use both GConf and GSettings if both are available.
4046 (store_config_changed_event): Add comment.
4047 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4048 (store_tool_bar_style_changed): New functions.
4049 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4050 (struct xsettings): Move font inside HAVE_XFT.
4051 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4052 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4053 Move inside HAVE_XFT.
4054 (something_changed_gsettingsCB): Rename from something_changedCB.
4055 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4056 also.
4057 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4058 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4059 (something_changed_gconfCB): Rename from something_changedCB.
4060 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4061 (parse_settings): Move check for font inside HAVE_XFT.
4062 (read_settings, apply_xft_settings): Add comment.
4063 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4064 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4065 call store_font_name_changed.
4066 (xft_settings_event): Add comment.
4067 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4068 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4069 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4070 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4071 (xsettings_initialize): Call init_gsettings last.
4072 (xsettings_get_system_font, xsettings_get_system_normal_font):
4073 Add comment.
4074
4075 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4076
4077 Random fixes. E.g., (random) never returned negative values.
4078 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4079 subseconds part to the entropy, as that's a bit more random.
4080 Prefer signed to unsigned, since the signedness doesn't matter and
4081 in general we prefer signed. When given a limit, use a
4082 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4083 latter isn't right if USE_2_TAGS_FOR_INTS.
4084 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4085 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4086
4087 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4088
4089 * textprop.c (text_property_stickiness):
4090 Obey Vtext_property_default_nonsticky.
4091 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4092 * w32fns.c (syms_of_w32fns):
4093 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4094
4095 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4096
4097 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4098 This is more efficient than Ffile_directory_p and avoids a minor race.
4099
4100 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4101
4102 * buffer.c (Foverlay_put): Say what the return value is
4103 (bug#7835).
4104
4105 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4106 is a directory before asking whether to use the file name
4107 (bug#7564).
4108 (barf_or_query_if_file_exists): Make the "File is a directory"
4109 error be more correct.
4110
4111 * fns.c (Frequire): Remove the mention of the .gz files, since
4112 that's installation-specific, but keep the mention of
4113 `get-load-suffixes'.
4114
4115 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4116
4117 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4118 Report string overflow if the output is too long.
4119
4120 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4121
4122 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4123 (syms_of_gnutls): Remove duplicate DEFSYM for
4124 Qgnutls_bootprop_verify_hostname_error, an error for
4125 Qgnutls_bootprop_verify_error (which is no longer used).
4126
4127 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4128 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4129 Also (re)move comments that are misplaced or no longer relevant.
4130
4131 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4132
4133 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4134
4135 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4136
4137 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4138 and background color parameters if they have been changed.
4139
4140 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4141
4142 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4143
4144 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4145
4146 * xsettings.c (SYSTEM_FONT): Define only when used.
4147 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4148
4149 * keymap.c (access_keymap_1): Now static.
4150
4151 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4152
4153 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4154 leave any prefix arg for the up event (Bug#1586).
4155
4156 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4157
4158 * lread.c (syms_of_lread): Mention single symbols defined by
4159 `defvar' or `defconst' (bug#7154).
4160
4161 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4162 (Frequire): Mention get-load-suffixes.
4163
4164 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4165
4166 * window.h (window): Remove clone_number slot.
4167 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4168 Remove.
4169 (make_parent_window, make_window, saved_window)
4170 (Fset_window_configuration, save_window_save): Don't deal with
4171 clone numbers.
4172 * buffer.c (Qclone_number): Remove declaration.
4173 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4174
4175 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4176
4177 Add multiple inheritance to keymaps.
4178 * keymap.c (Fmake_composed_keymap): New function.
4179 (Fset_keymap_parent): Simplify.
4180 (fix_submap_inheritance): Remove.
4181 (access_keymap_1): New function extracted from access_keymap to handle
4182 embedded parents and handle lists of maps.
4183 (access_keymap): Use it.
4184 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4185 (Fcopy_keymap): Handle embedded parents.
4186 (Fcommand_remapping, define_as_prefix): Simplify.
4187 (Fkey_binding): Simplify.
4188 (syms_of_keymap): Move minibuffer-local-completion-map,
4189 minibuffer-local-filename-completion-map,
4190 minibuffer-local-must-match-map, and
4191 minibuffer-local-filename-must-match-map to Elisp.
4192 (syms_of_keymap): Defsubr make-composed-keymap.
4193 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4194 (parse_menu_item): Trivial simplification.
4195
4196 2011-07-01 Glenn Morris <rgm@gnu.org>
4197
4198 * Makefile.in (SETTINGS_LIBS): Fix typo.
4199
4200 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4201
4202 * coding.c (Fencode_coding_string): Record the last coding system
4203 used, as the function doc string says (bug#8738).
4204
4205 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4206
4207 * xsettings.c (store_monospaced_changed): Take new font as arg and
4208 check for change against current_mono_font.
4209 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4210 (emacs_settings_constructor, emacs_settings_get_property)
4211 (emacs_settings_set_property, emacs_settings_class_init)
4212 (emacs_settings_init, gsettings_obj): Remove.
4213 (something_changedCB): New function for HAVE_GSETTINGS.
4214 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4215 with value as argument.
4216 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4217 g_settings_new (Bug#8967). Do not create gsettings_obj.
4218 Remove calls to g_settings_bind. Connect something_changedCB to
4219 "changed".
4220
4221 * xgselect.c: Add defined (HAVE_GSETTINGS).
4222 (xgselect_initialize): Ditto.
4223
4224 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4225 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4226 xg_select.
4227
4228 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4229
4230 * eval.c (struct backtrace): Simplify and port the data structure.
4231 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4232 signed bit field, as this assumption is not portable and it makes
4233 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4234 "char debug_on_exit : 1" as this is not portable either; instead,
4235 use the portable "unsigned int debug_on_exit : 1". Remove unused
4236 member evalargs. Remove obsolete comments about cc bombing out.
4237
4238 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4239
4240 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4241 Let HAVE_GSETTINGS override HAVE_GCONF.
4242 (store_monospaced_changed): New function.
4243 (EMACS_SETTINGS): A new type derived from GObject to handle
4244 GSettings notifications.
4245 (emacs_settings_constructor, emacs_settings_get_property)
4246 (emacs_settings_set_property, emacs_settings_class_init):
4247 New functions.
4248 (gsettings_client, gsettings_obj): New variables.
4249 (GSETTINGS_SCHEMA): New define.
4250 (something_changedCB): Call store_monospaced_changed.
4251 (init_gsettings): New function.
4252 (xsettings_initialize): Call init_gsettings.
4253 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4254 to NULL.
4255
4256 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4257 GCONF_CFLAGS/LIBS.
4258
4259 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4260
4261 * window.c (resize_root_window, grow_mini_window)
4262 (shrink_mini_window): Rename Qresize_root_window to
4263 Qwindow_resize_root_window and Qresize_root_window_vertically to
4264 Qwindow_resize_root_window_vertically.
4265
4266 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4267
4268 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4269
4270 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4271
4272 * makefile.w32-in: Redesign dependencies so they reflect more
4273 clearly which files are directly included by each source file,
4274 and not through other includes.
4275
4276 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4277
4278 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4279 (sort_overlays, overlay_strings): When an overlay's clone number
4280 matches the window's clone number process the overlay even if
4281 the overlay's window property doesn't match the current window.
4282
4283 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4284 (Fwindow_hchild): Rename to Fwindow_left_child.
4285 (Fwindow_next): Rename to Fwindow_next_sibling.
4286 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4287 (resize_window_check): Rename to window_resize_check.
4288 (resize_window_apply): Rename to window_resize_apply.
4289 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4290 (Fdelete_other_windows_internal, resize_frame_windows)
4291 (Fsplit_window_internal, Fdelete_window_internal)
4292 (grow_mini_window, shrink_mini_window)
4293 (Fresize_mini_window_internal): Fix callers accordingly.
4294
4295 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4296
4297 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4298 (emacs_fixed_set_min_size): Remove.
4299 (emacs_fixed_new): Take frame as argument.
4300
4301 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4302 (_EmacsFixedPrivate): Remove minwidth/height.
4303 Add struct frame *f.
4304 (emacs_fixed_init): Initialize priv->f.
4305 (get_parent_class, emacs_fixed_set_min_size): Remove.
4306 (emacs_fixed_new): Set priv->f to argument.
4307 (emacs_fixed_get_preferred_width)
4308 (emacs_fixed_get_preferred_height): Use min_width/height from
4309 frames size_hint to set minimum and natural (Bug#8919).
4310 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4311 and use min_width/height from frames size_hint to set
4312 min_width/height (Bug#8919).
4313
4314 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4315 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4316 Fix indentation.
4317
4318 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4319
4320 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4321 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4322 called at ZV.
4323
4324 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4325
4326 * process.c (wait_reading_process_output): Bypass select if
4327 waiting for a cell while ignoring keyboard input, and input is
4328 pending. Suggested by Jan Djärv (Bug#8869).
4329
4330 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4331
4332 Use gnulib's dup2 module instead of rolling our own.
4333 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4334
4335 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4336
4337 * dispnew.c (scrolling_window): Before scrolling, turn off a
4338 mouse-highlight in the window being scrolled.
4339
4340 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4341
4342 Move DEFSYM to lisp.h and use everywhere.
4343
4344 * character.h (DEFSYM): Move declaration...
4345 * lisp.h (DEFSYM): ...here.
4346
4347 * gnutls.c:
4348 * minibuf.c:
4349 * w32menu.c:
4350 * w32proc.c:
4351 * w32select.c: Don't include character.h.
4352
4353 * alloc.c (syms_of_alloc):
4354 * buffer.c (syms_of_buffer):
4355 * bytecode.c (syms_of_bytecode):
4356 * callint.c (syms_of_callint):
4357 * casefiddle.c (syms_of_casefiddle):
4358 * casetab.c (init_casetab_once):
4359 * category.c (init_category_once, syms_of_category):
4360 * ccl.c (syms_of_ccl):
4361 * cmds.c (syms_of_cmds):
4362 * composite.c (syms_of_composite):
4363 * dbusbind.c (syms_of_dbusbind):
4364 * dired.c (syms_of_dired):
4365 * dispnew.c (syms_of_display):
4366 * doc.c (syms_of_doc):
4367 * editfns.c (syms_of_editfns):
4368 * emacs.c (syms_of_emacs):
4369 * eval.c (syms_of_eval):
4370 * fileio.c (syms_of_fileio):
4371 * fns.c (syms_of_fns):
4372 * frame.c (syms_of_frame):
4373 * fringe.c (syms_of_fringe):
4374 * insdel.c (syms_of_insdel):
4375 * keymap.c (syms_of_keymap):
4376 * lread.c (init_obarray, syms_of_lread):
4377 * macros.c (syms_of_macros):
4378 * msdos.c (syms_of_msdos):
4379 * print.c (syms_of_print):
4380 * process.c (syms_of_process):
4381 * search.c (syms_of_search):
4382 * sound.c (syms_of_sound):
4383 * syntax.c (init_syntax_once, syms_of_syntax):
4384 * terminal.c (syms_of_terminal):
4385 * textprop.c (syms_of_textprop):
4386 * undo.c (syms_of_undo):
4387 * w32.c (globals_of_w32):
4388 * window.c (syms_of_window):
4389 * xdisp.c (syms_of_xdisp):
4390 * xfaces.c (syms_of_xfaces):
4391 * xfns.c (syms_of_xfns):
4392 * xmenu.c (syms_of_xmenu):
4393 * xsettings.c (syms_of_xsettings):
4394 * xterm.c (syms_of_xterm): Use DEFSYM.
4395
4396 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4397
4398 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4399
4400 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4401
4402 Integer and buffer overflow fixes (Bug#8873).
4403
4404 * print.c (printchar, strout): Check for string overflow.
4405 (PRINTPREPARE, printchar, strout):
4406 Don't set size unless allocation succeeds.
4407
4408 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4409 for sizes. Check for string overflow more accurately.
4410 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4411
4412 * macros.c: Integer and buffer overflow fixes.
4413 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4414 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4415 Use ptrdiff_t, not int, for sizes.
4416 Don't increment bufsize until after realloc succeeds.
4417 Check for size-calculation overflow.
4418 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4419
4420 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4421
4422 * lread.c: Integer overflow fixes.
4423 (read_integer): Radix is now EMACS_INT, not int,
4424 to improve quality of diagnostics for out-of-range radices.
4425 Calculate buffer size correctly for out-of-range radices.
4426 (read1): Check for integer overflow in radices, and in
4427 read-circle numbers.
4428 (read_escape): Avoid int overflow.
4429 (Fload, openp, read_buffer_size, read1)
4430 (substitute_object_recurse, read_vector, read_list, map_obarray):
4431 Use ptrdiff_t, not int, for sizes.
4432 (read1): Use EMACS_INT, not int, for sizes.
4433 Check for size overflow.
4434
4435 * image.c (cache_image): Check for size arithmetic overflow.
4436
4437 * lread.c: Integer overflow issues.
4438 (saved_doc_string_size, saved_doc_string_length)
4439 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4440 Now ptrdiff_t, not int.
4441 (read1): Don't assume doc string length fits in int. Check for
4442 out-of-range doc string lengths.
4443 (read_list): Don't assume file position fits in int.
4444 (read_escape): Check for hex character overflow.
4445
4446 2011-06-22 Leo Liu <sdl.web@gmail.com>
4447
4448 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4449 Move to minibuffer.el.
4450
4451 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4452
4453 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4454 The following patches are for when GLYPH_DEBUG && !XASSERT.
4455 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4456 * dispnew.c (flush_stdout):
4457 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4458 Mark as externally visible.
4459 * dispnew.c (check_window_matrix_pointers): Now static.
4460 * dispnew.c (window_to_frame_vpos):
4461 * xfns.c (unwind_create_frame):
4462 * xterm.c (x_check_font): Remove unused local.
4463 * scroll.c (CHECK_BOUNDS):
4464 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4465 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4466 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4467 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4468 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4469 Now static.
4470 (debug_method_add): Use va_list and vsprintf rather than relying
4471 on undefined behavior with wrong number of arguments.
4472 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4473 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4474 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4475 since we're not interested in debugging glyphs with old libraries.
4476 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4477 GCC 4.6.0's static checking.
4478
4479 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4480
4481 Integer overflow and signedness fixes (Bug#8873).
4482 A few related buffer overrun fixes, too.
4483
4484 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4485
4486 * dispextern.h (struct face.stipple):
4487 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4488 (x_bitmap_mask, x_allocate_bitmap_record)
4489 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4490 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4491 (x_create_bitmap_from_xpm_data):
4492 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4493 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4494 (.bitmaps_last):
4495 * xfaces.c (load_pixmap):
4496 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4497 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4498 (.bitmaps_last, struct x_output.icon_bitmap):
4499 Use ptrdiff_t, not int, for bitmap indexes.
4500 (x_allocate_bitmap_record): Check for size overflow.
4501 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4502
4503 Use ptrdiff_t, not int, for overlay counts.
4504 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4505 * editfns.c (overlays_around, get_pos_property):
4506 * textprop.c (get_char_property_and_overlay):
4507 * xdisp.c (next_overlay_change, note_mouse_highlight):
4508 * xfaces.c (face_at_buffer_position):
4509 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4510 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4511 (Fnext_overlay_change, Fprevious_overlay_change)
4512 (mouse_face_overlay_overlaps, Foverlays_in):
4513 Use ptrdiff_t, not int, for sizes.
4514 (overlays_at, overlays_in): Check for size-calculation overflow.
4515
4516 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4517
4518 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4519 (x_session_initialize): Do not assume string length fits in int.
4520
4521 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4522 This is unlikely, but can occur if DPI is outlandish.
4523
4524 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4525 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4526
4527 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4528 * xrdb.c (magic_file_p, search_magic_path):
4529 Omit last arg SUFFIX; it was always 0. All callers changed.
4530 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4531
4532 * xfont.c (xfont_match): Avoid need for strlen.
4533
4534 * xfns.c: Don't assume strlen fits in int.
4535 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4536
4537 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4538 not unsigned long, as we prefer signed integers. All callers changed.
4539 Detect integer overflow in repeat count.
4540 (message_dolog): Don't assume print length fits in 39 bytes.
4541 (display_mode_element): Don't assume strlen fits in int.
4542
4543 * termcap.c: Don't assume sizes fit in int and never overflow.
4544 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4545 (gobble_line): Check for size-calculation overflow.
4546
4547 * minibuf.c (Fread_buffer):
4548 * lread.c (intern, intern_c_string):
4549 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4550 Don't assume string length fits in int.
4551
4552 * keyboard.c (parse_tool_bar_item):
4553 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4554
4555 * font.c: Don't assume string length fits in int.
4556 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4557 Use ptrdiff_t, not int.
4558 (font_intern_prop): Don't assume string length fits in int.
4559 Don't assume integer property fits in fixnum.
4560 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4561
4562 * filelock.c: Fix some buffer overrun and integer overflow issues.
4563 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4564 Reformulate so as not to need the command string.
4565 Invoke gzip -cd rather than gunzip, as it's more portable.
4566 (lock_info_type, lock_file_1, lock_file):
4567 Don't assume pid_t and time_t fit in unsigned long.
4568 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4569 (current_lock_owner): Prefer signed type for sizes.
4570 Use memcpy, not strncpy, where memcpy is what is really wanted.
4571 Don't assume (via atoi) that time_t and pid_t fit in int.
4572 Check for time_t and/or pid_t out of range, e.g., via a network share.
4573 Don't alloca where an auto var works fine.
4574
4575 * fileio.c: Fix some integer overflow issues.
4576 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4577 Don't assume string length fits in int.
4578 (directory_file_name): Don't assume string length fits in long.
4579 (make_temp_name): Don't assume pid fits in int, or that its print
4580 length is less than 20.
4581
4582 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4583
4584 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4585
4586 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4587
4588 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4589 We prefer signed integers, even for size calculations.
4590
4591 * emacs.c: Don't assume string length fits in 'int'.
4592 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4593 (main): Don't invoke strlen when not needed.
4594
4595 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4596 (XD_DEBUG_MESSAGE): Don't waste a byte.
4597
4598 * callproc.c (getenv_internal_1, getenv_internal)
4599 (Fgetenv_internal):
4600 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4601
4602 * lread.c (invalid_syntax): Omit length argument.
4603 All uses changed. This doesn't fix a bug, but it simplifies the
4604 code away from its former Hollerith-constant appearance, and it's
4605 one less 'int' to worry about when looking at integer-overflow issues.
4606 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4607
4608 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4609 This didn't break anything, but it didn't help either.
4610 It's confusing to put a bogus integer in a place where the actual
4611 value does not matter.
4612 (LIST_END_P): Remove unused macro and its bogus comment.
4613 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4614
4615 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4616 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4617 implementation.
4618 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4619 We prefer signed types, and the value cannot exceed the EMACS_INT
4620 range anyway (because otherwise the length would not be representable).
4621 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4622 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4623 This avoids a GCC warning when WIDE_EMACS_INT.
4624
4625 * indent.c (sane_tab_width): New function.
4626 (current_column, scan_for_column, Findent_to, position_indentation)
4627 (compute_motion): Use it. This is just for clarity.
4628 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4629
4630 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4631
4632 * lisp.h (lint_assume): New macro.
4633 * composite.c (composition_gstring_put_cache):
4634 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4635
4636 * editfns.c, insdel.c:
4637 Omit unnecessary forward decls, to simplify future changes.
4638
4639 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4640
4641 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4642
4643 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4644 Use much-faster test for byte-length change.
4645 Don't assume string byte-length fits in 'int'.
4646 Check that character arg fits in 'int'.
4647 (mapcar1): Declare byte as byte, for clarity.
4648
4649 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4650
4651 * fns.c (concat): Catch string overflow earlier.
4652 Do not rely on integer wraparound.
4653
4654 * dispextern.h (struct it.overlay_strings_charpos)
4655 (struct it.selective): Now EMACS_INT, not int.
4656 * xdisp.c (forward_to_next_line_start)
4657 (back_to_previous_visible_line_start)
4658 (reseat_at_next_visible_line_start, next_element_from_buffer):
4659 Don't arbitrarily truncate the value of 'selective' to int.
4660
4661 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4662
4663 * composite.c: Don't truncate sizes to 'int'.
4664 (composition_gstring_p, composition_reseat_it)
4665 (composition_adjust_point): Use EMACS_INT, not int.
4666 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4667 not EMACS_UINT, for indexes.
4668
4669 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4670
4671 * buffer.c: Include <verify.h>.
4672 (struct sortvec.priority, struct sortstr.priority):
4673 Now EMACS_INT, not int.
4674 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4675 (struct sortstr.size, record_overlay_string)
4676 (struct sortstrlist.size, struct sortlist.used):
4677 Don't truncate size to int.
4678 (record_overlay_string): Check for size-calculation overflow.
4679 (init_buffer_once): Check at compile-time, not run-time.
4680
4681 2011-06-22 Jim Meyering <meyering@redhat.com>
4682
4683 Don't leak an XBM-image-sized buffer
4684 * image.c (xbm_load): Free the image buffer after using it.
4685
4686 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4687
4688 Port to Sun C.
4689 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4690 that Sun C diagnosed.
4691 * fns.c (secure_hash): Fix pointer signedness issue.
4692 * intervals.c (static_offset_intervals): New function.
4693 (offset_intervals): Use it.
4694
4695 2011-06-21 Leo Liu <sdl.web@gmail.com>
4696
4697 * deps.mk (fns.o):
4698 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4699 sha512.h.
4700
4701 * fns.c (secure_hash): Rename from crypto_hash_function and change
4702 the first arg to accept symbols.
4703 (Fsecure_hash): New primitive.
4704 (syms_of_fns): New symbols.
4705
4706 2011-06-20 Deniz Dogan <deniz@dogan.se>
4707
4708 * process.c (Fset_process_buffer): Clarify return value in
4709 docstring.
4710
4711 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4712
4713 * dispnew.c (add_window_display_history): Use BVAR.
4714
4715 * xdisp.c (debug_method_add): Use BVAR.
4716 (check_window_end, dump_glyph_matrix, dump_glyph)
4717 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4718
4719 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4720 Likewise.
4721
4722 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4723 check till after the cache is created in init_frame_faces.
4724
4725 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4726
4727 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4728
4729 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4730
4731 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4732 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4733 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4734
4735 Improve buffer-overflow checking (Bug#8873).
4736 * fileio.c (Finsert_file_contents):
4737 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4738 Remove the old (too-loose) buffer overflow checks.
4739 They weren't needed, since make_gap checks for buffer overflow.
4740 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4741 The old code merely checked for Emacs fixnum overflow, and relied
4742 on undefined (wraparound) behavior. The new code avoids undefined
4743 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4744
4745 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4746 Tune. Don't use wider integers than needed. Don't use alloca.
4747 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4748
4749 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4750
4751 * insdel.c, lisp.h (buffer_overflow): New function.
4752 (insert_from_buffer_1, replace_range, replace_range_2):
4753 * insdel.c (make_gap_larger):
4754 * editfns.c (Finsert_char):
4755 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4756
4757 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4758
4759 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4760
4761 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4762
4763 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4764 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4765
4766 * fileio.c: Don't assume EMACS_INT fits in off_t.
4767 (emacs_lseek): New static function.
4768 (Finsert_file_contents, Fwrite_region): Use it.
4769 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4770
4771 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4772
4773 * fns.c: Don't overflow int when computing a list length.
4774 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4775 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4776 truncation on 64-bit hosts. Check for QUIT every
4777 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4778 faster and is responsive enough.
4779 (Flength): Report an error instead of overflowing an integer.
4780 (Fsafe_length): Return a float if the value is not representable
4781 as a fixnum. This shouldn't happen except in contrived situations.
4782 (Fnthcdr, Fsort): Don't assume list length fits in int.
4783 (Fcopy_sequence): Don't assume vector length fits in int.
4784
4785 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4786 (header_size, word_size): New constants.
4787 (allocate_vectorlike): Don't check size overflow here.
4788 (allocate_vector): Check it here instead, since this is the only
4789 caller of allocate_vectorlike that could cause overflow.
4790 Check that the new vector's length is representable as a fixnum.
4791
4792 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4793 The previous code was bogus. For example, next_almost_prime (32)
4794 returned 39, which is undesirable as it is a multiple of 3; and
4795 next_almost_prime (24) returned 25, which is a multiple of 5 so
4796 why was the code bothering to check for multiples of 7?
4797
4798 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4799
4800 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4801
4802 Variadic C functions now count arguments with ptrdiff_t.
4803 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4804 Back then I didn't know that the Emacs coding style prefers signed int.
4805 Also, in the meantime I found a few more instances where arguments
4806 were being counted with int, which may truncate counts on 64-bit
4807 machines, or EMACS_INT, which may be unnecessarily wide.
4808 * lisp.h (struct Lisp_Subr.function.aMANY)
4809 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4810 Arg counts are now ptrdiff_t, not size_t.
4811 All variadic functions and their callers changed accordingly.
4812 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4813 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4814 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4815 * callint.c (Fcall_interactively): Check arg count for overflow,
4816 to avoid potential buffer overrun. Use signed char, not 'int',
4817 for 'varies' array, so that we needn't bother to check its size
4818 calculation for overflow.
4819 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4820 * eval.c (apply_lambda):
4821 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4822 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4823 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4824
4825 * callint.c (Fcall_interactively): Don't use index var as event count.
4826
4827 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4828 * mem-limits.h (SIZE): Remove; no longer used.
4829
4830 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4831
4832 Remove unnecessary casts.
4833 * xterm.c (x_term_init):
4834 * xfns.c (x_set_border_pixel):
4835 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4836 These aren't needed now that we assume ANSI C.
4837
4838 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4839 It's more likely to cause problems (due to unsigned overflow)
4840 than to cure them.
4841
4842 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4843
4844 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4845
4846 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4847
4848 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4849
4850 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4851
4852 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4853
4854 GLYPH_CODE_FACE returns EMACS_INT, not int.
4855 * dispextern.h (merge_faces):
4856 * xfaces.c (merge_faces):
4857 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4858 Don't assume EMACS_INT fits in int.
4859
4860 * character.h (CHAR_VALID_P): Remove unused parameter.
4861 * fontset.c, lisp.h, xdisp.c: All uses changed.
4862
4863 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4864
4865 * fns.c (concat): Minor tuning based on overflow analysis.
4866 This doesn't fix any bugs. Use int to hold character, instead
4867 of constantly refetching from Emacs object. Use XFASTINT, not
4868 XINT, for value known to be a character. Don't bother comparing
4869 a single byte to 0400, as it's always less.
4870
4871 * floatfns.c (Fexpt):
4872 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4873
4874 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4875 for characters.
4876
4877 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4878
4879 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4880 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4881 incorrectly succeed when S was a string, because 4294967386 was
4882 truncated before it was used.
4883
4884 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4885 Otherwise, an out-of-range integer could cause undefined behavior
4886 on a 64-bit host.
4887
4888 * composite.c: Use int, not EMACS_INT, for characters.
4889 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4890 EMACS_INT, for values that are known to be in character range.
4891 This doesn't fix any bugs but is the usual style inside Emacs and
4892 may generate better code on 32-bit machines.
4893
4894 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4895 This is for reasons similar to the recent CHAR_STRING fix.
4896 * charset.c (Fencode_char): Check that character arg is actually
4897 a character. Pass an int to ENCODE_CHAR.
4898 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4899 wider than 'int', as a compile-time check to prevent future regressions
4900 in this area.
4901
4902 * character.c (char_string): Remove unnecessary casts.
4903
4904 Make sure a 64-bit char is never passed to CHAR_STRING.
4905 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4906 by silently ignoring the top 32 bits, allowing some values
4907 that were far too large to be valid characters.
4908 * character.h: Include <verify.h>.
4909 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4910 arguments are no wider than unsigned, as a compile-time check
4911 to prevent future regressions in this area.
4912 * data.c (Faset):
4913 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4914 (Fsubst_char_in_region):
4915 * fns.c (concat):
4916 * xdisp.c (decode_mode_spec_coding):
4917 Adjust to CHAR_STRING's new requirement.
4918 * editfns.c (Finsert_char, Fsubst_char_in_region):
4919 * fns.c (concat): Check that character args are actually
4920 characters. Without this test, these functions did the wrong
4921 thing with wildly out-of-range values on 64-bit hosts.
4922
4923 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4924 These casts should not be needed on 32-bit hosts, either.
4925 * keyboard.c (read_char):
4926 * lread.c (Fload): Remove casts to unsigned.
4927
4928 * lisp.h (UNSIGNED_CMP): New macro.
4929 This fixes comparison bugs on 64-bit hosts.
4930 (ASCII_CHAR_P): Use it.
4931 * casefiddle.c (casify_object):
4932 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4933 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4934 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4935 * dispextern.h (FACE_FROM_ID):
4936 * keyboard.c (read_char): Use UNSIGNED_CMP.
4937
4938 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4939 not to EMACS_INT, to avoid GCC warning.
4940
4941 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4942
4943 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4944 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4945 isn't needed on 32-bit machines.
4946
4947 * buffer.c (Fgenerate_new_buffer_name):
4948 Use EMACS_INT for count, not int.
4949 (advance_to_char_boundary): Return EMACS_INT, not int.
4950
4951 * data.c (Qcompiled_function): Now static.
4952
4953 * window.c (window_body_lines): Now static.
4954
4955 * image.c (gif_load): Rename local to avoid shadowing.
4956
4957 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4958 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4959 * alloc.c (make_save_value): Integer argument is now of type
4960 ptrdiff_t, not int.
4961 (mark_object): Use ptrdiff_t, not int.
4962 * lisp.h (pD): New macro.
4963 * print.c (print_object): Use it.
4964
4965 * alloc.c: Use EMACS_INT, not int, to count objects.
4966 (total_conses, total_markers, total_symbols, total_vector_size)
4967 (total_free_conses, total_free_markers, total_free_symbols)
4968 (total_free_floats, total_floats, total_free_intervals)
4969 (total_intervals, total_strings, total_free_strings):
4970 Now EMACS_INT, not int. All uses changed.
4971 (Fgarbage_collect): Compute overall total using a double, so that
4972 integer overflow is less likely to be a problem. Check for overflow
4973 when converting back to an integer.
4974 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4975 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4976 These were 'int' variables that could overflow on 64-bit hosts;
4977 they were never used, so remove them instead of repairing them.
4978 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4979 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4980 Previously, this ceilinged at INT_MAX, but that doesn't work on
4981 64-bit machines.
4982 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4983
4984 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4985 (allocate_vectorlike): Check for ptrdiff_t overflow.
4986 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4987 when a (possibly-narrower) signed value would do just as well.
4988 We prefer using signed arithmetic, to avoid comparison confusion.
4989
4990 * alloc.c: Catch some string size overflows that we were missing.
4991 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4992 for convenience in STRING_BYTES_MAX.
4993 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4994 The definition here is exact; the one in lisp.h was approximate.
4995 (allocate_string_data): Check for string overflow. This catches
4996 some instances we weren't catching before. Also, it catches
4997 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4998 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4999 and ptrdiff_t and EMACS_INT are both 64 bits.
5000
5001 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5002 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5003 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5004
5005 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5006
5007 * alloc.c (Fmake_string): Check for out-of-range init.
5008
5009 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5010
5011 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5012
5013 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5014
5015 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5016 xg_get_default_scrollbar_width.
5017
5018 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5019 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5020 (style_changed_cb): Call update_theme_scrollbar_width and call
5021 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5022 all frames (Bug#8505).
5023 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5024 Call gtk_window_set_resizable if HAVE_GTK3.
5025 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5026 and height if HAVE_GTK3 (Bug#8505).
5027 (scroll_bar_width_for_theme): New variable.
5028 (update_theme_scrollbar_width): New function.
5029 (xg_get_default_scrollbar_width): Move code to
5030 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5031 (xg_initialize): Call update_theme_scrollbar_width.
5032
5033 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5034
5035 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5036
5037 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5038
5039 * frame.c (make_frame): Call other_buffer_safely instead of
5040 other_buffer.
5041
5042 * window.c (temp_output_buffer_show): Call display_buffer with
5043 second argument Vtemp_buffer_show_specifiers and reset latter
5044 immediately after the call.
5045 (Vtemp_buffer_show_specifiers): New variable.
5046 (auto_window_vscroll_p, next_screen_context_lines)
5047 (Vscroll_preserve_screen_position): Remove leading asterisks from
5048 doc-strings.
5049
5050 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5051
5052 Fix minor problems found by GCC 4.6.0 static checking.
5053 * buffer.c (Qclone_number): Remove for now, as it's unused.
5054 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5055 (record_buffer): Remove unused local.
5056 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5057 (set_frame_buffer_list): Remove; unused.
5058 * frame.h (other_visible_frames): Remove decl.
5059 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5060 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5061 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5062 if HAVE_GPM.
5063 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5064 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5065 Define only if HAVE_GPM.
5066 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5067 (update_hints_inhibit): Remove; never set. All uses removed.
5068 * widgetprv.h (emacsFrameClassRec): Remove decl.
5069 * window.c (delete_deletable_window): Now returns void, since it
5070 wasn't returning anything.
5071 (compare_window_configurations): Remove unused locals.
5072 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5073 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5074 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5075 the same widths as pointers. This follows up on the 2011-05-06 patch.
5076 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5077 * xterm.h: Likewise.
5078 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5079
5080 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5081
5082 * makefile.w32-in: Update dependencies.
5083 (LISP_H): Add lib/intprops.h.
5084
5085 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5086
5087 * image.c (gif_load): Add animation frame delay to the metadata.
5088 (syms_of_image): Use DEFSYM. New symbol `delay'.
5089
5090 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5091
5092 * window.c (delete_deletable_window): Re-add.
5093 (Fset_window_configuration): Rewrite to handle dead buffers and
5094 consequently deletable windows.
5095 (window_tree, Fwindow_tree): Remove. Supply functionality in
5096 window.el.
5097 (compare_window_configurations): Simplify code.
5098
5099 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5100
5101 * image.c (imagemagick_load_image): Fix type mismatch.
5102 (Fimagemagick_types): Likewise.
5103
5104 * window.h (replace_buffer_in_windows): Declare.
5105
5106 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5107
5108 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5109 Qclone_number. Remove external declaration of Qdelete_window.
5110 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5111 code.
5112 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5113 Run Qbuffer_list_update_hook if allowed.
5114 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5115 buffer list implementation.
5116 (other_buffer_safely): New function.
5117 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5118 calls to replace_buffer_in_windows and
5119 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5120 if allowed.
5121 (record_buffer): Inhibit quitting and rewrite using quittable
5122 functions. Run Qbuffer_list_update_hook if allowed.
5123 (Frecord_buffer, Funrecord_buffer): New functions.
5124 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5125 Move switch-to-buffer to window.el.
5126 (bury-buffer): Move to window.el.
5127 (Vbuffer_list_update_hook): New variable.
5128
5129 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5130 section.
5131
5132 * window.h (resize_frame_windows): Move up in code.
5133 (Fwindow_frame): Remove EXFUN.
5134 (replace_buffer_in_all_windows): Remove prototype.
5135 (replace_buffer_in_windows_safely): Add prototype.
5136
5137 * window.c: Declare Qdelete_window static again. Move down
5138 declaration of select_count.
5139 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5140 (Fother_window): Move to window.el.
5141 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5142 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5143 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5144 window.el.
5145 (replace_buffer_in_windows): Implement by calling
5146 Qreplace_buffer_in_windows.
5147 (replace_buffer_in_all_windows): Remove with some functionality
5148 moved into replace_buffer_in_windows_safely.
5149 (replace_buffer_in_windows_safely): New function.
5150 (select_window_norecord, select_frame_norecord): Move in front
5151 of run_window_configuration_change_hook. Remove now obsolete
5152 declarations.
5153 (Fset_window_buffer): Rewrite doc-string.
5154 Call Qrecord_window_buffer.
5155 (keys_of_window): Move binding for other-window to window.el.
5156
5157 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5158
5159 * dispextern.h (struct image): Replace data member, whose int_val
5160 and ptr_val fields were not used by anything, with a single
5161 lisp_val object.
5162
5163 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5164 (gif_clear_image, gif_load, imagemagick_load_image)
5165 (gs_clear_image, gs_load): Callers changed.
5166
5167 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5168
5169 * buffer.h: Include <time.h>, for time_t.
5170 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5171
5172 Fix minor problems found by static checking.
5173
5174 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5175
5176 Make identifiers static if they are not used in other modules.
5177 * data.c (Qcompiled_function, Qframe, Qvector):
5178 * image.c (QimageMagick, Qsvg):
5179 * minibuf.c (Qmetadata):
5180 * window.c (resize_window_check, resize_root_window): Now static.
5181 * window.h (resize_window_check, resize_root_window): Remove decls.
5182
5183 * window.c (window_deletion_count, delete_deletable_window):
5184 Remove; unused.
5185 (window_body_lines): Now static.
5186 (Fdelete_other_windows_internal): Mark vars as initialized.
5187 Make sure 'resize_failed' is initialized.
5188 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5189 (resize_window_apply): Remove unused local.
5190 * window.h (delete_deletable_window): Remove decl.
5191
5192 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5193 (imagemagick_load_image): Fix pointer signedness problem by changing
5194 last arg from unsigned char * to char *. All uses changed.
5195 Also, fix a local for similar reasons.
5196 Remove unused locals. Remove locals to avoid shadowing.
5197 (fn_rsvg_handle_free): Remove; unused.
5198 (svg_load, svg_load_image): Fix pointer signedness problem.
5199 (imagemagick_load_image): Don't use garbage pointer image_wand.
5200
5201 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5202
5203 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5204
5205 * image.c (gif_load): Fix omitted cast error introduced by
5206 2011-06-06 change.
5207
5208 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5209
5210 * window.h (resize_proportionally, orig_total_lines)
5211 (orig_top_line): Remove from window structure.
5212 (set_window_height, set_window_width, change_window_heights)
5213 (Fdelete_window): Remove prototypes.
5214 (resize_frame_windows): Remove duplicate declaration.
5215
5216 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5217
5218 * window.h (resize_frame_windows, resize_window_check)
5219 (delete_deletable_window, resize_root_window)
5220 (resize_frame_windows): Declare prototypes.
5221
5222 * window.c (resize_window_apply): Make definition be "static" to
5223 match the prototype.
5224
5225 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5226
5227 * window.c: Remove declarations of Qwindow_size_fixed,
5228 window_min_size_1, window_min_size_2, window_min_size,
5229 size_window, window_fixed_size_p, enlarge_window, delete_window.
5230 Remove static from declaration of Qdelete_window, it's
5231 temporarily needed by Fbury_buffer.
5232 (replace_window): Don't assign orig_top_line and
5233 orig_total_lines.
5234 (Fdelete_window, delete_window): Remove. Window deletion is
5235 handled by window.el.
5236 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5237 Replace Fdelete_window calls with calls to Qdelete_window.
5238 (Fdelete_other_windows): Remove. Deleting other windows is
5239 handled by window.el.
5240 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5241 handled in window.el.
5242 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5243 Window minimum sizes are handled in window.el.
5244 (shrink_windows, size_window, set_window_height)
5245 (set_window_width, change_window_heights, window_height)
5246 (window_width, CURBEG, CURSIZE, enlarge_window)
5247 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5248 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5249 handled in window.el.
5250 (make_dummy_parent): Rename to make_parent_window and give it a
5251 second argument horflag.
5252 (make_window): Don't set resize_proportionally any more.
5253 (Fsplit_window): Remove. Windows are split in window.el.
5254 (save_restore_action, save_restore_orig_size)
5255 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5256 Resize mini windows in window.el.
5257 (grow_mini_window, shrink_mini_window): Implement by calling
5258 Qresize_root_window_vertically, resize_window_check and
5259 resize_window_apply.
5260 (saved_window, Fset_window_configuration, save_window_save):
5261 Do not handle orig_top_line, orig_total_lines, and
5262 resize_proportionally.
5263 (window_min_height, window_min_width): Move to window.el.
5264 (keys_of_window): Move bindings for delete-other-windows,
5265 split-window, delete-window and enlarge-window to window.el.
5266
5267 * buffer.c: Temporarily extern Qdelete_window.
5268 (Fbury_buffer): Temporarily call Qdelete_window instead of
5269 Fdelete_window (Fbury_buffer will move to window.el soon).
5270
5271 * frame.c (set_menu_bar_lines_1): Remove code handling
5272 orig_top_line and orig_total_lines.
5273
5274 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5275 set_window_height but set heights directly.
5276 (change_frame_size_1): Use resize_frame_windows.
5277
5278 * xdisp.c (init_xdisp): Don't use set_window_height but set
5279 heights directly.
5280
5281 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5282 Use resize_frame_windows instead of change_window_heights and run
5283 run_window_configuration_change_hook.
5284
5285 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5286 instead of change_window_heights and run
5287 run_window_configuration_change_hook.
5288
5289 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5290
5291 * window.c (replace_window): Rename second argument REPLACEMENT to
5292 NEW. New third argument SETFLAG. Rewrite.
5293 (delete_window, make_dummy_parent): Call replace_window with
5294 third argument 1.
5295 (window_list_1): Move down in code.
5296 (run_window_configuration_change_hook): Move set_buffer part
5297 before select_frame_norecord part in order to unwind correctly.
5298 Rename count1 to count.
5299 (recombine_windows, delete_deletable_window, resize_root_window)
5300 (Fdelete_other_windows_internal)
5301 (Frun_window_configuration_change_hook, make_parent_window)
5302 (resize_window_check, resize_window_apply, Fresize_window_apply)
5303 (resize_frame_windows, Fsplit_window_internal)
5304 (Fdelete_window_internal, Fresize_mini_window_internal):
5305 New functions.
5306 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5307
5308 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5309
5310 * window.h (window): Add some new members to window structure -
5311 normal_lines, normal_cols, new_total, new_normal, clone_number,
5312 splits, nest, prev_buffers, next_buffers.
5313 (WINDOW_TOTAL_SIZE): Move here from window.c.
5314 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5315
5316 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5317 Remove.
5318 (make_dummy_parent): Set new members of windows structure.
5319 (make_window): Move down in code. Handle new members of window
5320 structure.
5321 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5322 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5323 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5324 (Fset_window_prev_buffers, Fwindow_next_buffers)
5325 (Fset_window_next_buffers, Fset_window_clone_number):
5326 New functions.
5327 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5328 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5329 Doc-string fixes.
5330 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5331 Argument WINDOW can be now internal window too.
5332 (Fwindow_use_time): Move up in code.
5333 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5334 Rewrite doc-string.
5335 (Fset_window_configuration, saved_window)
5336 (Fcurrent_window_configuration, save_window_save): Handle new
5337 members of window structure.
5338 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5339 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5340 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5341 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5342 Qget_mru_window, Qresize_root_window,
5343 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5344 Qauto_buffer_name; staticpro them.
5345
5346 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5347
5348 * window.c (Fwindow_total_size, Fwindow_left_column)
5349 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5350 (Fwindow_list_1): New functions.
5351 (window_box_text_cols): Replace with window_body_cols.
5352 (Fwindow_width, Fscroll_left, Fscroll_right):
5353 Use window_body_cols instead of window_box_text_cols.
5354 (delete_window, Fset_window_configuration):
5355 Call delete_all_subwindows with window as argument.
5356 (delete_all_subwindows): Take a window as argument and not a
5357 structure. Rewrite.
5358 (window_loop): Remove handling of GET_LRU_WINDOW and
5359 GET_LARGEST_WINDOW.
5360 (Fget_lru_window, Fget_largest_window): Move to window.el.
5361
5362 * window.h: Extern window_body_cols instead of
5363 window_box_text_cols. delete_all_subwindows now takes a
5364 Lisp_Object as argument.
5365
5366 * indent.c (compute_motion, Fcompute_motion):
5367 Use window_body_cols instead of window_box_text_cols.
5368
5369 * frame.c (delete_frame): Call delete_all_subwindows with root
5370 window as argument.
5371
5372 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5373
5374 * fns.c (Fputhash): Document return value.
5375
5376 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5377
5378 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5379
5380 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5381
5382 Cons<->int and similar integer overflow fixes (Bug#8794).
5383
5384 Check for overflow when converting integer to cons and back.
5385 * charset.c (Fdefine_charset_internal, Fdecode_char):
5386 Use cons_to_unsigned to catch overflow.
5387 (Fencode_char): Use INTEGER_TO_CONS.
5388 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5389 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5390 * data.c (long_to_cons, cons_to_long): Remove.
5391 (cons_to_unsigned, cons_to_signed): New functions.
5392 These signal an error for invalid or out-of-range values.
5393 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5394 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5395 * font.c (Ffont_variation_glyphs):
5396 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5397 * lisp.h: Include <intprops.h>.
5398 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5399 (cons_to_signed, cons_to_unsigned): New decls.
5400 (long_to_cons, cons_to_long): Remove decls.
5401 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5402 (Fprimitive_undo): Use CONS_TO_INTEGER.
5403 * xfns.c (Fx_window_property): Likewise.
5404 * xselect.c: Include <limits.h>.
5405 (x_own_selection, selection_data_to_lisp_data):
5406 Use INTEGER_TO_CONS.
5407 (x_handle_selection_request, x_handle_selection_clear)
5408 (x_get_foreign_selection, Fx_disown_selection_internal)
5409 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5410 (lisp_data_to_selection_data): Use cons_to_unsigned.
5411 (x_fill_property_data): Use cons_to_signed.
5412 Report values out of range.
5413
5414 Check for buffer and string overflow more precisely.
5415 * buffer.h (BUF_BYTES_MAX): New macro.
5416 * lisp.h (STRING_BYTES_MAX): New macro.
5417 * alloc.c (Fmake_string):
5418 * character.c (string_escape_byte8):
5419 * coding.c (coding_alloc_by_realloc):
5420 * doprnt.c (doprnt):
5421 * editfns.c (Fformat):
5422 * eval.c (verror):
5423 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5424 since they may not be the same number.
5425 * editfns.c (Finsert_char):
5426 * fileio.c (Finsert_file_contents):
5427 Likewise for BUF_BYTES_MAX.
5428
5429 * image.c: Use ptrdiff_t, not int, for sizes.
5430 (slurp_file): Switch from int to ptrdiff_t.
5431 All uses changed.
5432 (slurp_file): Check that file size fits in both size_t (for
5433 malloc) and ptrdiff_t (for sanity and safety).
5434
5435 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5436 if b->modtime has its maximal value.
5437
5438 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5439
5440 Don't assume time_t can fit into int.
5441 * buffer.h (struct buffer.modtime): Now time_t, not int.
5442 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5443 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5444
5445 Minor fixes for signed vs unsigned integers.
5446 * character.h (MAYBE_UNIFY_CHAR):
5447 * charset.c (maybe_unify_char):
5448 * keyboard.c (read_char, reorder_modifiers):
5449 XINT -> XFASTINT, since the integer must be nonnegative.
5450 * ftfont.c (ftfont_spec_pattern):
5451 * keymap.c (access_keymap, silly_event_symbol_error):
5452 XUINT -> XFASTINT, since the integer must be nonnegative.
5453 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5454 since it makes no difference and we prefer signed.
5455 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5456 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5457 nonnegative.
5458
5459 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5460
5461 * window.h (Fwindow_frame): Declare.
5462
5463 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5464
5465 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5466 (SPARE_MEMORY): Always define.
5467 (LARGE_REQUEST): Remove.
5468 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5469
5470 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5471
5472 * lisp.h: Move EXFUNS for Fframe_root_window,
5473 Fframe_first_window and Fset_frame_selected_window to window.h.
5474
5475 * window.h: Move EXFUNS for Fframe_root_window,
5476 Fframe_first_window and Fset_frame_selected_window here from
5477 lisp.h.
5478
5479 * frame.c (Fwindow_frame, Fframe_first_window)
5480 (Fframe_root_window, Fframe_selected_window)
5481 (Fset_frame_selected_window): Move to window.c.
5482 (Factive_minibuffer_window): Move to minibuf.c.
5483 (Fother_visible_frames_p): New function.
5484
5485 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5486
5487 * window.c (decode_window, decode_any_window): Move up in code.
5488 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5489 (inhibit_frame_unsplittable): Remove unused variable.
5490 (Fwindow_buffer): Move up and rewrite doc-string.
5491 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5492 (Fwindow_prev): New functions.
5493 (Fwindow_frame): Move here from frame.c. Accept any window as
5494 argument.
5495 (Fframe_root_window, Fframe_first_window)
5496 (Fframe_selected_window): Move here from frame.c. Accept frame
5497 or arbitrary window as argument. Update doc-strings.
5498 (Fminibuffer_window): Move up in code.
5499 (Fwindow_minibuffer_p): Move up in code and simplify.
5500 (Fset_frame_selected_window): Move here from frame.c.
5501 Marginal rewrite.
5502 (Fselected_window, select_window, Fselect_window): Move up in
5503 code. Minor doc-string fixes.
5504
5505 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5506
5507 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5508 Do not assume that spare memory exists; that assumption is valid
5509 only if SYSTEM_MALLOC.
5510 (LARGE_REQUEST): New macro, so that the issue of large requests
5511 is separated from the issue of spare memory.
5512
5513 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5514
5515 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5516 format. (Bug#8806)
5517
5518 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5519
5520 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5521 before statements.
5522
5523 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5524
5525 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5526
5527 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5528
5529 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5530 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5531
5532 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5533
5534 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5535
5536 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5537
5538 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5539 (x_clipboard_manager_save): Add return value.
5540 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5541 New error handlers.
5542 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5543 Obey Vx_select_enable_clipboard_manager. Catch errors in
5544 x_clipboard_manager_save (Bug#8779).
5545 (Vx_select_enable_clipboard_manager): New variable.
5546 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5547
5548 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5549
5550 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5551
5552 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5553
5554 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5555 in the current matrix if keep_current_p is non-zero.
5556
5557 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5558
5559 * bidi.c (bidi_level_of_next_char): Fix last change.
5560
5561 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5562
5563 Support bidi reordering of text covered by display properties.
5564
5565 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5566 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5567 (bidi_cache_search, bidi_cache_iterator_state)
5568 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5569 (bidi_level_of_next_char, bidi_move_to_visually_next):
5570 Support character positions inside a run of characters covered by a
5571 display string.
5572 (bidi_paragraph_init, bidi_resolve_explicit_1)
5573 (bidi_level_of_next_char): Call bidi_fetch_char and
5574 bidi_fetch_char_advance instead of FETCH_CHAR and
5575 FETCH_CHAR_ADVANCE.
5576 (bidi_init_it): Initialize new members.
5577 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5578 definitions.
5579 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5580 instead of using explicit *_CHAR codes.
5581 (bidi_resolve_explicit, bidi_resolve_weak):
5582 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5583 bidirectional text is supported only in multibyte buffers.
5584 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5585 it to initialize the frame_window_p member of struct bidi_it.
5586 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5587 (bidi_resolve_explicit, bidi_resolve_weak)
5588 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5589 bidi_it->nchars is non-positive.
5590 (bidi_level_of_next_char): Don't try to lookup the cache for the
5591 next/previous character if nothing is cached there yet, or if we
5592 were just reseat()'ed to a new position.
5593
5594 * xdisp.c (set_cursor_from_row): Set start and stop points
5595 according to the row's direction when priming the loop that looks
5596 for the glyph on which to display cursor.
5597 (single_display_spec_intangible_p): Function deleted.
5598 (display_prop_intangible_p): Reimplement to call
5599 handle_display_spec instead of single_display_spec_intangible_p.
5600 Accept 3 additional arguments needed by handle_display_spec.
5601 This fixes incorrect cursor motion across display property with complex
5602 values: lists, `(when COND...)' forms, etc.
5603 (single_display_spec_string_p): Support property values that are
5604 lists with the argument STRING its top-level element.
5605 (display_prop_string_p): Fix the condition for processing a
5606 property that is a list to be consistent with handle_display_spec.
5607 (handle_display_spec): New function, refactored from the
5608 last portion of handle_display_prop.
5609 (compute_display_string_pos): Accept additional argument
5610 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5611 value of a `display' property is a "replacing spec".
5612 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5613 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5614 the display property, but just return a value indicating whether
5615 the display property will replace the characters it covers.
5616 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5617 frame_window_p members of struct bidi_it.
5618 (compute_display_string_pos, compute_display_string_end):
5619 New functions.
5620 (push_it): Accept second argument POSITION, where pop_it should
5621 jump to continue iteration.
5622 (reseat_1): Initialize bidi_it.disp_pos.
5623
5624 * keyboard.c (adjust_point_for_property): Adjust the call to
5625 display_prop_intangible_p to its new signature.
5626
5627 * dispextern.h (struct bidi_it): New member frame_window_p.
5628 (bidi_init_it): Update prototypes.
5629 (display_prop_intangible_p): Update prototype.
5630 (compute_display_string_pos, compute_display_string_end):
5631 Declare prototypes.
5632 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5633 EMACS_INT.
5634
5635 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5636
5637 Malloc failure behavior now depends on size of allocation.
5638 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5639 * lisp.h: Change signatures accordingly.
5640 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5641 All callers changed. (Bug#8762)
5642
5643 * gnutls.c: Use Emacs's memory allocators.
5644 Without this change, the gnutls library would invoke malloc etc.
5645 directly, which causes problems on non-SYNC_INPUT hosts, and which
5646 runs afoul of improving memory_full behavior. (Bug#8761)
5647 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5648 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5649 xfree instead of the default malloc, realloc, free.
5650 (Fgnutls_boot): No need to check for memory allocation failure,
5651 since xmalloc does that for us.
5652
5653 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5654 * category.c (hash_get_category_set):
5655 * ccl.c (ccl_driver):
5656 * charset.c (Fdefine_charset_internal):
5657 * charset.h (struct charset.hash_index):
5658 * composite.c (get_composition_id, gstring_lookup_cache)
5659 (composition_gstring_put_cache):
5660 * composite.h (struct composition.hash_index):
5661 * dispextern.h (struct image.hash):
5662 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5663 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5664 (hashfn_equal, hashfn_user_defined, make_hash_table)
5665 (maybe_resize_hash_table, hash_lookup, hash_put)
5666 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5667 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5668 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5669 * image.c (make_image, search_image_cache, lookup_image)
5670 (xpm_put_color_table_h):
5671 * lisp.h (struct Lisp_Hash_Table):
5672 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5673 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5674 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5675 * alloc.c (allocate_vectorlike):
5676 Check for overflow in vector size calculations.
5677 * ccl.c (ccl_driver):
5678 Check for overflow when converting EMACS_INT to int.
5679 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5680 need to be updated by these changes.
5681 * fns.c (make_hash_table, maybe_resize_hash_table):
5682 Check for integer overflow with large hash tables.
5683 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5684 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5685 (SXHASH_REDUCE): New macro.
5686 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5687 Use it instead of discarding useful hash info with large hash values.
5688 (sxhash_float): New function.
5689 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5690 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5691 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5692 Rewrite to use FIXNUM_BITS, as this simplifies things.
5693 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5694 Adjust signatures to match updated version of code.
5695 (consing_since_gc): Now EMACS_INT, since a single hash table can
5696 use more than INT_MAX bytes.
5697
5698 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5699
5700 Make it possible to build with GCC-4.6+ -O2 -flto.
5701
5702 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5703
5704 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5705
5706 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5707 Call minibuffer-inactive-mode.
5708
5709 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5710
5711 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5712 Update dependencies.
5713
5714 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5715
5716 * data.c (init_data): Remove code for UTS, this system is not
5717 supported anymore.
5718
5719 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5720
5721 Don't force ./temacs to start in terminal mode.
5722
5723 * frame.c (make_initial_frame): Initialize faces in all cases, not
5724 only when CANNOT_DUMP is defined.
5725 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5726
5727 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5728
5729 * dispnew.c (add_window_display_history): Use const for the string
5730 pointer. Remove declaration, not needed.
5731
5732 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5733
5734 Use 'inline', not 'INLINE'.
5735 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5736 * alloc.c, fontset.c (INLINE): Remove.
5737 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5738 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5739 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5740 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5741 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5742
5743 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5744
5745 Make it possible to run ./temacs.
5746
5747 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5748 syms_of_callproc does the same thing. Remove test for
5749 "initialized", do it in the caller.
5750 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5751
5752 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5753
5754 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5755 (read_minibuf): Use get_minibuffer.
5756 (syms_of_minibuf): Use DEFSYM.
5757 (Qmetadata): New var.
5758 * data.c (Qbuffer): Don't make it static.
5759 (syms_of_data): Use DEFSYM.
5760
5761 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5762
5763 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5764 (CCL_CODE_MIN): New macro.
5765
5766 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5767
5768 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5769
5770 * eval.c (Qdebug): Now static.
5771 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5772 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5773 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5774
5775 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5776
5777 * image.c: Various fixes to ImageMagick code comments.
5778 (Fimagemagick_types): Doc fix.
5779
5780 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5781
5782 Minor fixes prompted by GCC 4.6.0 warnings.
5783
5784 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5785
5786 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5787 (x_clipboard_manager_save_all): Move extern decl to ...
5788 * xterm.h: ... here, so that it can be checked for consistency.
5789
5790 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5791
5792 * xselect.c (x_clipboard_manager_save_frame)
5793 (x_clipboard_manager_save_all): New functions.
5794 (Fx_clipboard_manager_save): Lisp function deleted.
5795
5796 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5797 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5798
5799 * xterm.h: Update prototype.
5800
5801 2011-05-28 William Xu <william.xwl@gmail.com>
5802
5803 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5804 exiting (Bug#8239).
5805
5806 2011-05-28 Jim Meyering <meyering@redhat.com>
5807
5808 Avoid a sign-extension bug in crypto_hash_function.
5809 * fns.c (to_uchar): Define.
5810 (crypto_hash_function): Use it to convert some newly-signed
5811 variables to unsigned, to avoid sign-extension bugs. For example,
5812 without this change, (md5 "truc") would evaluate to
5813 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5814 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5815 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5816
5817 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5818
5819 Integer overflow fixes.
5820
5821 * dbusbind.c: Serial number integer overflow fixes.
5822 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5823 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5824 to hold a serial number that is too large for a fixnum.
5825 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5826 Check for serial numbers out of range. Decode any serial number
5827 that was so large that it became a float. (Bug#8722)
5828
5829 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5830 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5831 Use XFASTINT rather than XUINT when numbers are nonnegative.
5832 (xd_append_arg, Fdbus_method_return_internal):
5833 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5834 arguments, check that Lisp number is nonnegative, rather than
5835 silently wrapping negative numbers around. (Bug#8722)
5836 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5837 (Bug#8722)
5838
5839 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5840
5841 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5842
5843 ccl: Add integer overflow checks.
5844 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5845 (IN_INT_RANGE): New macros.
5846 (ccl_driver): Use them to check for integer overflow when
5847 decoding a CCL program. Many of the new checks are whether XINT (x)
5848 fits in int; it doesn't always, on 64-bit hosts. The new version
5849 doesn't catch all possible integer overflows, but it's an
5850 improvement. (Bug#8719)
5851
5852 * alloc.c (make_event_array): Use XINT, not XUINT.
5853 There's no need for unsigned here.
5854
5855 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5856 This follows up to the 2011-05-06 change that substituted uintptr_t
5857 for EMACS_INT. This case wasn't caught back then.
5858
5859 Rework Fformat to avoid integer overflow issues.
5860 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5861 now (part of C89). Include <verify.h>.
5862 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5863 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5864 (Fformat): Avoid the prepass trying to compute sizes; it was only
5865 approximate and thus did not catch overflow reliably. Instead, walk
5866 through the format just once, formatting and computing sizes as we go,
5867 checking for integer overflow at every step, and allocating a larger
5868 buffer as needed. Keep track separately whether the format is
5869 multibyte. Keep only the most-recently calculated precision, rather
5870 than them all. Record whether each argument has been converted to
5871 string. Use EMACS_INT, not int, for byte and char and arg counts.
5872 Support field widths and precisions larger than INT_MAX. Avoid
5873 sprintf's undefined behavior with conversion specifications such as %#d
5874 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5875 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5876 formatting out-of-range floating point numbers with int
5877 formats. (Bug#8668)
5878
5879 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5880
5881 * data.c: Avoid integer truncation in expressions involving floats.
5882 * data.c: Include <intprops.h>.
5883 (arith_driver): When there's an integer overflow in an expression
5884 involving floating point, convert the integers to floating point
5885 so that the resulting value does not suffer from catastrophic
5886 integer truncation. For example, on a 64-bit host (* 4
5887 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5888 Do not rely on undefined behavior after integer overflow.
5889
5890 merge count_size_as_multibyte, parse_str_to_multibyte
5891 * character.c, character.h (count_size_as_multibyte):
5892 Rename from parse_str_to_multibyte; all uses changed.
5893 Check for integer overflow.
5894 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5895 since it's now a duplicate of the other. This is more of
5896 a character than a buffer op, so better that it's in character.c.
5897 * fns.c, print.c: Adjust to above changes.
5898
5899 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5900
5901 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5902
5903 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5904
5905 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5906 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5907 (x_clipboard_manager_save): Now static.
5908 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5909
5910 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5911 (crypto_hash_function): Now static.
5912 Fix pointer signedness problems. Avoid unnecessary initializations.
5913
5914 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5915
5916 * termhooks.h (Vselection_alist): Make it terminal-local.
5917
5918 * terminal.c (create_terminal): Initialize it.
5919
5920 * xselect.c: Support for clipboard managers.
5921 (Vselection_alist): Move to termhooks.h as terminal-local var.
5922 (LOCAL_SELECTION): New macro.
5923 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5924 (symbol_to_x_atom): Remove gratuitous arg.
5925 (x_handle_selection_request, lisp_data_to_selection_data)
5926 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5927 (x_own_selection, x_get_local_selection, x_convert_selection):
5928 New arg, specifying work frame. Use terminal-local Vselection_alist.
5929 (some_frame_on_display): Delete unused function.
5930 (Fx_own_selection_internal, Fx_get_selection_internal)
5931 (Fx_disown_selection_internal, Fx_selection_owner_p)
5932 (Fx_selection_exists_p): New optional frame arg.
5933 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5934 (x_handle_selection_clear): Don't treat other terminals with the
5935 same keyboard specially. Use the terminal-local Vselection_alist.
5936 (x_clear_frame_selections): Use Frun_hook_with_args.
5937
5938 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5939
5940 * xterm.h: Add support for those atoms.
5941
5942 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5943
5944 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5945 (converted_selections, conversion_fail_tag): New global variables.
5946 (x_selection_request_lisp_error): Free the above.
5947 (x_get_local_selection): Remove unnecessary code.
5948 (x_reply_selection_request): Args changed; handle arbitrary array
5949 of converted selections stored in converted_selections.
5950 Separate the XChangeProperty and SelectionNotify steps.
5951 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5952 (x_convert_selection): New function.
5953 (x_handle_selection_event): Simplify.
5954 (x_get_foreign_selection): Don't ignore incoming requests while
5955 waiting for an answer; this will fail when we implement
5956 SAVE_TARGETS, and seems unnecessary anyway.
5957 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5958 (Vx_sent_selection_functions): Doc fix.
5959
5960 2011-05-26 Leo Liu <sdl.web@gmail.com>
5961
5962 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5963
5964 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5965
5966 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5967
5968 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5969 for fringe update if it has periodic bitmap.
5970 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5971 and fringe_bitmap_periodic_p.
5972
5973 * fringe.c (get_fringe_bitmap_data): New function.
5974 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5975 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5976 row. Mark glyph row for fringe update if periodicity changed.
5977
5978 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5979 for fringe update unless it has periodic bitmap.
5980
5981 2011-05-25 Kenichi Handa <handa@m17n.org>
5982
5983 * xdisp.c (get_next_display_element): Set correct it->face_id for
5984 a static composition.
5985
5986 2011-05-24 Leo Liu <sdl.web@gmail.com>
5987
5988 * deps.mk (fns.o):
5989 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5990
5991 * fns.c (crypto_hash_function, Fsha1): New function.
5992 (Fmd5): Use crypto_hash_function.
5993 (syms_of_fns): Add Ssha1.
5994
5995 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5996
5997 * gnutls.c: Remove unused macros.
5998 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5999 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6000 Remove macros that are defined and never used.
6001 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6002
6003 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6004
6005 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6006 (Fx_get_selection_internal): Minor cleanup.
6007 (Fx_own_selection_internal): Rename arguments for consistency with
6008 select.el.
6009
6010 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6011
6012 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6013
6014 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6015
6016 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6017
6018 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6019
6020 * dispnew.c (scrolling_window): Don't exclude the case that the
6021 last enabled row in the desired matrix touches the bottom boundary.
6022
6023 2011-05-21 Glenn Morris <rgm@gnu.org>
6024
6025 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6026 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6027 and add some more files.
6028
6029 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6030
6031 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6032 report_file_error introduced by the change from 2011-05-07.
6033
6034 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6035
6036 * systime.h (Time): Define only if emacs is defined.
6037 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6038 where the include path doesn't have X11/X.h by default. See
6039 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6040
6041 2011-05-20 Kenichi Handa <handa@m17n.org>
6042
6043 * composite.c (find_automatic_composition): Fix previous change.
6044
6045 2011-05-20 Glenn Morris <rgm@gnu.org>
6046
6047 * lisp.mk: New file, split from Makefile.in.
6048 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6049 (shortlisp): Remove.
6050 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6051
6052 2011-05-19 Glenn Morris <rgm@gnu.org>
6053
6054 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6055 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6056 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6057 (lisp): Set the order to that of loadup.el.
6058 (shortlisp): Make it a copy of $lisp.
6059 (SOME_MACHINE_LISP): Remove.
6060 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6061 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6062
6063 2011-05-18 Kenichi Handa <handa@m17n.org>
6064
6065 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6066 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6067 (find_automatic_composition): Mostly rewrite for efficiency.
6068
6069 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6070
6071 * makefile.w32-in: Update dependencies.
6072
6073 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6074
6075 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6076 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6077
6078 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6079
6080 Fix some integer overflow issues, such as string length overflow.
6081
6082 * insdel.c (count_size_as_multibyte): Check for string overflow.
6083
6084 * character.c (lisp_string_width): Check for string overflow.
6085 Use EMACS_INT, not int, for string indexes and lengths; in
6086 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6087 the resulting string length overflows an EMACS_INT; instead,
6088 report a string overflow if no precision given. When checking for
6089 precision exhaustion, use a check that cannot possibly have
6090 integer overflow. (Bug#8675)
6091 * character.h (lisp_string_width): Adjust to new signature.
6092
6093 * alloc.c (string_overflow): New function.
6094 (Fmake_string): Use it. This doesn't change behavior, but saves
6095 a few bytes and will simplify future changes.
6096 * character.c (string_escape_byte8): Likewise.
6097 * lisp.h (string_overflow): New decl.
6098
6099 Fixups, following up to the user-interface timestamp change.
6100 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6101 for UI timestamps, instead of unsigned long.
6102 * msdos.c (mouse_get_pos): Likewise.
6103 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6104 * w32gui.h (Time): Define by including "systime.h" rather than by
6105 declaring it ourselves. (Bug#8664)
6106
6107 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6108 * image.c (clear_image_cache): Likewise.
6109
6110 * term.c (term_mouse_position): Don't assume time_t wraparound.
6111
6112 Be more systematic about user-interface timestamps.
6113 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6114 and sometimes 'EMACS_UINT', to represent these timestamps.
6115 This change causes it to use 'Time' uniformly, as that's what X uses.
6116 This makes the code easier to follow, and makes it easier to catch
6117 integer overflow bugs such as Bug#8664.
6118 * frame.c (Fmouse_position, Fmouse_pixel_position):
6119 Use Time, not unsigned long, for user-interface timestamps.
6120 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6121 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6122 * keyboard.h (last_event_timestamp): Likewise.
6123 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6124 * menu.h (xmenu_show): Likewise.
6125 * term.c (term_mouse_position): Likewise.
6126 * termhooks.h (struct input_event.timestamp): Likewise.
6127 (struct terminal.mouse_position_hook): Likewise.
6128 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6129 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6130 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6131 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6132 what it was before.
6133 * menu.h, termhooks.h: Include "systime.h", for Time.
6134
6135 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6136 Don't assume that the difference between two unsigned long values
6137 can fit into an integer. At this point, we know button_down_time
6138 <= event->timestamp, so the difference must be nonnegative, so
6139 there's no need to cast the result if double-click-time is
6140 nonnegative, as it should be; check that it's nonnegative, just in
6141 case. This bug is triggered when events are more than 2**31 ms
6142 apart (about 25 days). (Bug#8664)
6143
6144 * xselect.c (last_event_timestamp): Remove duplicate decl.
6145 (x_own_selection): Remove needless cast to unsigned long.
6146
6147 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6148 that always fit in int. Use a sentinel instead of a counter, to
6149 avoid a temp and to allay GCC's concerns about possible int overflow.
6150 * frame.h (struct frame): Use int for menu_bar_items_used
6151 instead of EMACS_INT, since it always fits in int.
6152
6153 * menu.c (grow_menu_items): Check for int overflow.
6154
6155 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6156
6157 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6158 Before, the code was not consistent. These values cannot exceed
6159 2**31 - 1 so there's no need to make them unsigned.
6160 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6161 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6162 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6163 as modifiers.
6164 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6165
6166 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6167 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6168 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6169 presumably because the widths might not match.
6170
6171 * window.c (size_window): Avoid needless test at loop start.
6172
6173 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6174
6175 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6176
6177 2011-05-12 Drew Adams <drew.adams@oracle.com>
6178
6179 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6180
6181 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6182
6183 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6184 `width' to `bar_area_x' and `bar_area_width', respectively.
6185 (x_scroll_run): Take account of fringe background extension.
6186
6187 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6188 Rename local vars `left' and `width' to `bar_area_x' and
6189 `bar_area_width', respectively.
6190 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6191 background extension.
6192
6193 2011-05-10 Jim Meyering <meyering@redhat.com>
6194
6195 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6196
6197 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6198
6199 * image.c (Finit_image_library): Return t for built-in image types,
6200 like pbm and xbm. (Bug#8640)
6201
6202 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6203
6204 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6205
6206 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6207
6208 * w32console.c (Fset_screen_color): Doc fix.
6209 (Fget_screen_color): New function.
6210 (syms_of_ntterm): Defsubr it.
6211
6212 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6213 unlink the temporary file if Fcall_process didn't create it in the
6214 first place.
6215 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6216 child process will be redirected to a file specified with `:file'.
6217 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6218 cue to call_process_cleanup not to close that handle.
6219
6220 2011-05-07 Ben Key <bkey76@gmail.com>
6221
6222 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6223 one of two shell specific rules, either bootstrap-temacs-CMD or
6224 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6225 to the previous implementation of the bootstrap-temacs rule.
6226 The bootstrap-temacs-CMD rule is similar to the previous
6227 implementation of the bootstrap-temacs rule except that it
6228 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6229 variable.
6230
6231 These changes, along with some changes to nt/configure.bat,
6232 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6233 earlier fix to add support for --cflags and --ldflags options
6234 that include quotes so that it works whether make uses cmd or
6235 sh as the shell.
6236
6237 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6238
6239 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6240 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6241 is a constant.
6242 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6243 a string. Handle both cases.
6244 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6245 (Fdbus_register_method): Use Qinvalid_function.
6246
6247 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6248
6249 * makefile.w32-in: Update dependencies.
6250 (LISP_H): Add inttypes.h and stdin.h.
6251 (PROCESS_H): Add unistd.h.
6252
6253 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6254
6255 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6256 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6257
6258 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6259
6260 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6261
6262 * term.c (vfatal): Remove stray call to va_end.
6263 It's not needed and the C Standard doesn't allow it here anyway.
6264
6265 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6266 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6267
6268 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6269 bytes.
6270
6271 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6272
6273 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6274
6275 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6276
6277 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6278
6279 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6280
6281 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6282 * charset.c (Fdefine_charset_internal): Don't initialize
6283 charset.code_space[15]. The value was garbage, on hosts with
6284 32-bit int (Bug#8600).
6285
6286 * lread.c (read_integer): Be more consistent with string-to-number.
6287 Use string_to_number to do the actual conversion; this avoids
6288 rounding errors and fixes some other screwups. Without this fix,
6289 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6290 (digit_to_number): Move earlier, for benefit of read_integer.
6291 Return -1 if the digit is out of range for the base, -2 if it is
6292 not a digit in any supported base. (Bug#8602)
6293
6294 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6295
6296 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6297 to match comment at start of function. This also removes a
6298 GCC warning about overflow in a 32+64-bit port.
6299
6300 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6301
6302 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6303 Reported by Stefan Monnier in
6304 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6305 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6306 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6307
6308 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6309 (EMACS_UINTPTR): Likewise, with uintptr_t.
6310
6311 * lisp.h: Prefer 64-bit EMACS_INT if available.
6312 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6313 on 32-bit hosts that have 64-bit int, so that they can access
6314 large files.
6315 However, temporarily disable this change unless the temporary
6316 symbol WIDE_EMACS_INT is defined.
6317
6318 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6319
6320 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6321 This removes an assumption that EMACS_INT and long are the same
6322 width as pointers. The assumption is true for Emacs porting targets
6323 now, but we want to make other targets possible.
6324 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6325 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6326 In the rest of the code, change types of integers that hold casted
6327 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6328 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6329 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6330 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6331 No need to cast type when ORing.
6332 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6333 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6334 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6335 assume EMACS_INT is the same width as char *.
6336 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6337 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6338 Remove no-longer-needed casts.
6339 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6340 (xg_tool_bar_help_callback, xg_make_tool_item):
6341 Use EMACS_INTPTR to hold an integer
6342 that will be cast to void *; this can avoid a GCC warning
6343 if EMACS_INT is not the same width as void *.
6344 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6345 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6346 (current_message_1, set_message_1):
6347 Use a local to convert to proper width without a cast.
6348 * xmenu.c (dialog_selection_callback): Likewise.
6349
6350 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6351 Also, don't assume VALBITS / RAND_BITS is less than 5,
6352 and don't rely on undefined behavior when shifting a 1 left into
6353 the sign bit.
6354 * lisp.h (get_random): Change signature to match.
6355
6356 * lread.c (hash_string): Use size_t, not int, for hash computation.
6357 Normally we prefer signed values; but hashing is special, because
6358 it's better to use unsigned division on hash table sizes so that
6359 the remainder is nonnegative. Also, size_t is the natural width
6360 for hashing into memory. The previous code used 'int', which doesn't
6361 retain enough info to hash well into very large tables.
6362 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6363
6364 * dbusbind.c: Don't possibly lose pointer info when converting.
6365 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6366 Use XPNTR rather than XHASH, so that the high-order bits of
6367 the pointer aren't lost when converting through void *.
6368
6369 * eval.c (Fautoload): Don't double-shift a pointer.
6370
6371 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6372
6373 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6374
6375 * gnutls.c (DEF_GNUTLS_FN):
6376 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6377
6378 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6379
6380 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6381 marker. (Bug#8610)
6382
6383 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6384
6385 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6386 New version that can reserve upto 2GB of heap space.
6387
6388 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6389
6390 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6391
6392 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6393
6394 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6395 `gnutls_certificate_set_x509_key_file'.
6396
6397 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6398
6399 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6400 Update dependencies.
6401
6402 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6403
6404 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6405 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6406 Remove unused parameter `fildes'.
6407 * process.c (read_process_output, send_process): Don't pass it.
6408
6409 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6410
6411 Fix previous change: the library cache is defined in w32.c.
6412 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6413 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6414
6415 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6416
6417 Implement dynamic loading of GnuTLS on Windows.
6418
6419 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6420 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6421 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6422 Declare.
6423
6424 * gnutls.c (Qgnutls_dll): Define.
6425 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6426 (gnutls_*): Declare function pointers.
6427 (init_gnutls_functions): New function to initialize function pointers.
6428 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6429 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6430 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6431 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6432 (emacs_gnutls_write, emacs_gnutls_read)
6433 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6434 (Fgnutls_available_p): New function.
6435 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6436 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6437 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6438
6439 * image.c: Include w32.h.
6440 (Vimage_type_cache): Delete.
6441 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6442 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6443 (w32_delayed_load): Move to w32.c.
6444
6445 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6446
6447 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6448 (w32_delayed_load): Move from image.c. When loading a library, record
6449 its filename in the :loaded-from property of the library id.
6450 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6451 Initialize and staticpro them.
6452 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6453
6454 * process.c: Include lisp.h before w32.h, not after.
6455 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6456 instead of gnutls_record_check_pending.
6457
6458 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6459
6460 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6461
6462 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6463 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6464 as passed in.
6465
6466 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6467
6468 * xterm.c (x_set_frame_alpha): Do not set property on anything
6469 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6470
6471 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6472
6473 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6474
6475 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6476
6477 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6478 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6479 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6480 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6481 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6482 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6483 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6484 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6485 (Qgnutls_bootprop_callbacks_verify): Make static.
6486
6487 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6488
6489 * callproc.c: Indentation fixup.
6490
6491 * sysdep.c (wait_for_termination_1): Make static.
6492 (wait_for_termination, interruptible_wait_for_termination):
6493 Move after wait_for_termination_1.
6494
6495 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6496
6497 * sysdep.c (interruptible_wait_for_termination): New function
6498 which is like wait_for_termination, but allows keyboard
6499 interruptions.
6500
6501 * callproc.c (Fcall_process): Add (:file "file") as an option for
6502 the STDOUT buffer.
6503 (Fcall_process_region): Ditto.
6504
6505 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6506
6507 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6508 rather than `XVECTOR (FOO)->size'.
6509
6510 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6511 inttypes.h, as a gnulib replacement is used if it not available in
6512 system headers.
6513
6514 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6515
6516 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6517 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6518 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6519
6520 * coding.c (coding_alloc_by_realloc): Error out if destination
6521 will grow beyond MOST_POSITIVE_FIXNUM.
6522 (decode_coding_emacs_mule): Abort if there isn't enough place in
6523 charbuf for the composition carryover bytes. Reserve an extra
6524 space for up to 2 characters produced in a loop.
6525 (decode_coding_iso_2022): Abort if there isn't enough place in
6526 charbuf for the composition carryover bytes.
6527
6528 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6529
6530 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6531 aborting when %lld or %lll format is passed.
6532 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6533 %llo or %llx format is passed. (Bug#8545)
6534
6535 * window.c (window_scroll_line_based): Use a marker instead of
6536 simple variables to record original value of point. (Bug#7952)
6537
6538 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6539 produced by %s or %c overflows available buffer space. (Bug#8545)
6540
6541 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6542
6543 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6544 (SIZE_MAX): Move defn after all includes, as they might #define it.
6545
6546 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6547
6548 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6549
6550 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6551
6552 * keyboard.c (Qdelayed_warnings_hook): Define.
6553 (command_loop_1): Run `delayed-warnings-hook'
6554 if Vdelayed_warnings_list is non-nil.
6555 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6556 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6557
6558 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6559
6560 * doprnt.c (doprnt): Don't return value smaller than the buffer
6561 size if the message was truncated. (Bug#8545).
6562
6563 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6564
6565 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6566 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6567
6568 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6569
6570 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6571
6572 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6573
6574 * makefile.w32-in: Update dependencies.
6575
6576 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6577
6578 Improve `doprnt' and its usage. (Bug#8545)
6579 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6580 `format_end'. Remove support for %l as a conversion specifier.
6581 Don't use xrealloc. Improve diagnostics when the %l size modifier
6582 is used. Update the commentary.
6583
6584 * eval.c (verror): Simplify calculation of size_t.
6585
6586 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6587 messages.
6588
6589 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6590
6591 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6592 change.
6593
6594 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6595
6596 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6597 This makes this file independent of the recent pseudovector change.
6598
6599 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6600
6601 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6602
6603 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6604 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6605 Remove unused local.
6606 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6607
6608 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6609 GCC 4.6.0 optimizes based on type-based alias analysis.
6610 For example, if b is of type struct buffer * and v of type struct
6611 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6612 != &v->size, and therefore "v->size = 1; b->size = 2; return
6613 v->size;" must therefore return 1. This assumption is incorrect
6614 for Emacs, since it type-puns struct Lisp_Vector * with many other
6615 types. To fix this problem, this patch adds a new type struct
6616 vectorlike_header that documents the constraints on layout of vectors
6617 and pseudovectors, and helps optimizing compilers not get fooled
6618 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6619 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6620 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6621 the size member.
6622 (XSETPVECTYPE): Rewrite in terms of new macro.
6623 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6624 This is a bit clearer, and further avoids the possibility of
6625 undesirable aliasing.
6626 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6627 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6628 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6629 since Lisp_Subr is a special case (no "next" field).
6630 (ASIZE): Now uses header.size rather than size.
6631 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6632 to avoid the hassle of writing XVECTOR (foo)->header.size.
6633 (struct vectorlike_header): New type.
6634 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6635 object, to help avoid aliasing.
6636 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6637 (SUBRP): Likewise, since Lisp_Subr is a special case.
6638 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6639 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6640 (struct Lisp_Hash_Table): Combine first two members into a single
6641 struct vectorlike_header member. All uses of "size" and "next" members
6642 changed to be "header.size" and "header.next".
6643 * buffer.h (struct buffer): Likewise.
6644 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6645 * frame.h (struct frame): Likewise.
6646 * process.h (struct Lisp_Process): Likewise.
6647 * termhooks.h (struct terminal): Likewise.
6648 * window.c (struct save_window_data, struct saved_window): Likewise.
6649 * window.h (struct window): Likewise.
6650 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6651 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6652 * buffer.c (init_buffer_once): Likewise.
6653 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6654 special case.
6655 * process.c (Fformat_network_address): Use local var for size,
6656 for brevity.
6657
6658 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6659
6660 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6661 * data.c (atof): Remove decl; no longer used or needed.
6662 (digit_to_number): Move to lread.c.
6663 (Fstring_to_number): Use new string_to_number function, to be
6664 consistent with how the Lisp reader treats infinities and NaNs.
6665 Do not assume that floating-point numbers represent EMACS_INT
6666 without losing information; this is not true on most 64-bit hosts.
6667 Avoid double-rounding errors, by insisting on integers when
6668 parsing non-base-10 numbers, as the documentation specifies.
6669 * lisp.h (string_to_number): New decl, replacing ...
6670 (isfloat_string): Remove.
6671 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6672 (read1): Do not accept +. and -. as integers; this
6673 appears to have been a coding error. Similarly, do not accept
6674 strings like +-1e0 as floating point numbers. Do not report
6675 overflow for integer overflows unless the base is not 10 which
6676 means we have no simple and reliable way to continue.
6677 Break out the floating-point parsing into a new
6678 function string_to_number, so that Fstring_to_number parses
6679 floating point numbers consistently with the Lisp reader.
6680 (digit_to_number): Move here from data.c. Make it static inline.
6681 (E_CHAR, EXP_INT): Remove, replacing with ...
6682 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6683 (string_to_number): New function, replacing isfloat_string.
6684 This function checks for valid syntax and produces the resulting
6685 Lisp float number too. Rework it so that string-to-number
6686 no longer mishandles examples like "1.0e+". Use strtoumax,
6687 so that overflow for non-base-10 numbers is reported only when
6688 there's no portable and simple way to convert to floating point.
6689
6690 * textprop.c (set_text_properties_1): Rewrite for clarity,
6691 and to avoid GCC warning about integer overflow.
6692
6693 * intervals.h (struct interval): Use EMACS_INT for members
6694 where EMACS_UINT might cause problems. See
6695 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6696 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6697 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6698 All uses changed.
6699 (offset_intervals): Tell GCC not to worry about length overflow
6700 when negating a negative length.
6701
6702 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6703 (overrun_check_free): Likewise.
6704
6705 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6706 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6707 word size.
6708
6709 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6710 (gnutls_make_error): Rename local to avoid shadowing.
6711 (gnutls_emacs_global_deinit): ifdef out; not used.
6712 (Fgnutls_boot): Use const for pointer to readonly storage.
6713 Comment out unused local. Fix pointer signedness problems.
6714
6715 * lread.c (openp): Don't stuff size_t into an 'int'.
6716 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6717 about possible signed overflow.
6718
6719 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6720 (GDK_KEY_g): Don't define if already defined.
6721 (xg_prepare_tooltip): Avoid pointer signedness problem.
6722 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6723
6724 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6725 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6726
6727 * xfns.c (Fx_window_property): Simplify a bit,
6728 to make a bit faster and to avoid GCC 4.6.0 warning.
6729 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6730
6731 * fns.c (internal_equal): Don't assume size_t fits in int.
6732
6733 * alloc.c (compact_small_strings): Tighten assertion a little.
6734
6735 Replace pEd with more-general pI, and fix some printf arg casts.
6736 * lisp.h (pI): New macro, generalizing old pEd macro to other
6737 conversion specifiers. For example, use "...%"pI"d..." rather
6738 than "...%"pEd"...".
6739 (pEd): Remove. All uses replaced with similar uses of pI.
6740 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6741 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6742 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6743 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6744 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6745 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6746 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6747 64-bit hosts.
6748 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6749 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6750 * print.c (safe_debug_print, print_object): Likewise.
6751 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6752 to int.
6753 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6754 avoiding the 0 flag, which is not portable.
6755 * process.c (Fmake_network_process): Use pI to avoid cast.
6756 * region-cache.c (pp_cache): Likewise.
6757 * xdisp.c (decode_mode_spec): Likewise.
6758 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6759 behavior on 64-bit hosts with printf arg.
6760 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6761 (x_stop_queuing_selection_requests): Likewise.
6762 (x_get_window_property): Don't truncate byte count to an 'int'
6763 when tracing.
6764
6765 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6766 here, since it parses constructs like leading '-' and spaces,
6767 which are not wanted; and it overflows with large numbers.
6768 Instead, simply match F[0-9]+, which is what is wanted anyway.
6769
6770 * alloc.c: Remove unportable assumptions about struct layout.
6771 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6772 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6773 (allocate_vectorlike, make_pure_vector): Use the new macros,
6774 plus offsetof, to remove unportable assumptions about struct layout.
6775 These assumptions hold on all porting targets that I know of, but
6776 they are not guaranteed, they're easy to remove, and removing them
6777 makes further changes easier.
6778
6779 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6780 This doesn't fix a bug but makes the code clearer.
6781 (string_overrun_cookie): Now const. Use initializers that
6782 don't formally overflow signed char, to avoid warnings.
6783 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6784 can cause Emacs to crash when string overrun checking is enabled.
6785 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6786 multiple of sizeof (EMACS_INT); it need not be, if
6787 alignof(EMACS_INT) < sizeof (EMACS_INT).
6788 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6789
6790 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6791
6792 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6793
6794 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6795
6796 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6797 supposed to be handshaking. (Bug#8556)
6798 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6799
6800 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6801
6802 * lisp.h (Qdebug): List symbol.
6803 * eval.c (Qdebug): Restore global linkage.
6804 * keyboard.c (debug-on-event): New variable.
6805 (handle_user_signal): Break into debugger when debug-on-event
6806 matches the current signal symbol.
6807
6808 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6809
6810 * alloc.c (check_sblock, check_string_bytes)
6811 (check_string_free_list): Convert to standard C.
6812
6813 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6814
6815 * w32.c (emacs_gnutls_push): Fix typo.
6816
6817 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6818
6819 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6820 "cast to pointer from integer of different size".
6821
6822 Improve doprnt and its use in verror. (Bug#8545)
6823 * doprnt.c (doprnt): Document the set of format control sequences
6824 supported by the function. Use SAFE_ALLOCA instead of always
6825 using `alloca'.
6826
6827 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6828 is one byte too soon. Don't use xrealloc; instead xfree and
6829 xmalloc anew.
6830
6831 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6832
6833 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6834 callbacks stage.
6835
6836 * gnutls.c: Renamed global_initialized to
6837 gnutls_global_initialized. Added internals for the
6838 :verify-hostname-error, :verify-error, and :verify-flags
6839 parameters of `gnutls-boot' and documented those parameters in the
6840 docstring. Start callback support.
6841 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6842 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6843 on error. Return error code.
6844 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6845 (emacs_gnutls_read): Likewise.
6846 (Fgnutls_boot): Return handshake error code.
6847 (emacs_gnutls_handle_error): New function.
6848 (wsaerror_to_errno): Likewise.
6849
6850 * w32.h (emacs_gnutls_pull): Add prototype.
6851 (emacs_gnutls_push): Likewise.
6852
6853 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6854 (emacs_gnutls_push): Likewise.
6855
6856 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6857
6858 * process.c (wait_reading_process_output): Check if GnuTLS
6859 buffered some data internally if no FDs are set for TLS
6860 connections.
6861
6862 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6863 (LIBS): Link to USER_LIBS.
6864 ($(BLD)/gnutls.$(0)): New target.
6865
6866 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6867
6868 * xdisp.c (handle_single_display_spec): Rename the
6869 display_replaced_before_p argument into display_replaced_p, to
6870 make it consistent with the commentary. Fix typos in the
6871 commentary.
6872
6873 * textprop.c (syms_of_textprop): Remove dead code.
6874 (copy_text_properties): Delete obsolete commentary about an
6875 interface that was deleted long ago. Fix typos in the description
6876 of arguments.
6877
6878 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6879 to changes in oldXMenu/XMenu.h from 2011-04-16.
6880 <menu_help_message, prev_menu_help_message>: Constify.
6881 (IT_menu_make_room): menu->help_text is now `const char **';
6882 adjust.
6883
6884 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6885 to changes in oldXMenu/XMenu.h from 2011-04-16.
6886 (struct XMenu): Declare `help_text' `const char **'.
6887
6888 * xfaces.c <Qunspecified>: Make extern again.
6889
6890 * syntax.c: Include sys/types.h before including regex.h, as
6891 required by Posix.
6892
6893 * doc.c (get_doc_string): Improve the format passed to `error'.
6894
6895 * doprnt.c (doprnt): Improve commentary.
6896
6897 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6898
6899 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6900 them with etags.
6901
6902 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6903 changes in globals.h immediately force recompilation.
6904 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6905 $(CURDIR)/s/ms-w32.h.
6906 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6907
6908 * character.c (Fchar_direction): Function deleted.
6909 (syms_of_character): Don't defsubr it.
6910 <char-direction-table>: Deleted.
6911
6912 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6913
6914 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6915 * doprnt.c: Include limits.h.
6916 (SIZE_MAX): New macro.
6917 (doprnt): Return a size_t value. 2nd arg is now size_t.
6918 Many local variables are now size_t instead of int or unsigned.
6919 Improve overflow protection. Support `l' modifier for integer
6920 conversions. Support %l conversion. Don't assume an EMACS_INT
6921 argument for integer conversions and for %c.
6922
6923 * lisp.h (doprnt): Restore prototype.
6924
6925 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6926 $(SRC)/character.h.
6927
6928 * Makefile.in (base_obj): Add back doprnt.o.
6929
6930 * deps.mk (doprnt.o): Add back prerequisites.
6931 (callint.o): Depend on character.h.
6932
6933 * eval.c (internal_lisp_condition_case): Include the handler
6934 representation in the error message.
6935 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6936 when breaking from the loop.
6937
6938 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6939
6940 * callint.c (Fcall_interactively): When displaying error message
6941 about invalid control letter, pass the character's codepoint, not
6942 a pointer to its multibyte form. Improve display of the character
6943 in octal and display also its hex code.
6944
6945 * character.c (char_string): Use %x to display the (unsigned)
6946 codepoint of an invalid character, to avoid displaying a bogus
6947 negative value.
6948
6949 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6950 `error', not SYMBOL_NAME itself.
6951
6952 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6953 character arguments to `error'.
6954
6955 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6956 to `error' in error message about FINAL_CHAR argument. Make sure
6957 FINAL_CHAR is a character, and use %c when it is passed as
6958 argument to `error'.
6959
6960 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6961
6962 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6963
6964 * w32.c: Include <time.h>.
6965 (sys_localtime): New function.
6966
6967 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6968
6969 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6970
6971 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6972
6973 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6974
6975 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6976 zombies (Bug#8467).
6977
6978 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6979
6980 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6981 gl_state.e_property when gl_state.object is Qt.
6982
6983 * insdel.c (make_gap_larger): Remove limitation of buffer size
6984 to <= INT_MAX.
6985
6986 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6987
6988 * xdisp.c (lookup_glyphless_char_display)
6989 (produce_glyphless_glyph): Handle cons cell entry in
6990 glyphless-char-display.
6991 (Vglyphless_char_display): Document it.
6992
6993 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6994 glyphless-char-display.
6995
6996 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6997
6998 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6999
7000 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7001
7002 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7003 definition for no-X builds.
7004
7005 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7006
7007 Static checks with GCC 4.6.0 and non-default toolkits.
7008
7009 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7010
7011 * process.c (keyboard_bit_set): Define only if SIGIO.
7012 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7013 (send_process): Repair possible setjmp clobbering.
7014
7015 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7016
7017 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7018
7019 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7020
7021 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7022 Define only if needed.
7023
7024 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7025 by pacifying GCC about it. Maybe it's time to retire it?
7026 * xfaces.c (USG, __TIMEVAL__): Likewise.
7027
7028 * dispextern.h (struct redisplay_interface): Rename param
7029 to avoid shadowing.
7030 * termhooks.h (struct terminal): Likewise.
7031 * xterm.c (xembed_send_message): Likewise.
7032
7033 * insdel.c (make_gap_smaller): Define only if
7034 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7035
7036 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7037 it.
7038
7039 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7040 so that we aren't warned about unused symbols.
7041
7042 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7043
7044 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7045
7046 * xfns.c (x_real_positions): Mark locals as initialized.
7047
7048 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7049
7050 * xterm.c: Fix problems found by static analysis with other toolkits.
7051 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7052 (x_dispatch_event): Declare static if USE_GTK, and
7053 define if USE_GTK || USE_X_TOOLKIT.
7054 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7055 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7056 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7057 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7058
7059 * xmenu.c (menu_help_callback): Pointer type fixes.
7060 Use const pointers when pointing at readonly data. Avoid pointer
7061 signedness clashes.
7062 (FALSE): Remove unused macro.
7063 (update_frame_menubar): Remove unused decl.
7064
7065 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7066
7067 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7068 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7069 (single_menu_item): Rename local to avoid shadowing.
7070
7071 * keyboard.c (make_lispy_event): Remove unused local var.
7072
7073 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7074 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7075
7076 * bitmaps: Change bitmaps from unsigned char back to the X11
7077 compatible char. Avoid the old compiler warnings about
7078 out-of-range initializers by using, for example, '\xab' rather
7079 than 0xab.
7080
7081 * xgselect.c (xgselect_initialize): Check vs interface
7082 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7083
7084 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7085
7086 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7087 to read-only memory.
7088
7089 * fns.c (vector): Remove; this old hack is no longer needed.
7090
7091 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7092 Remove unused var.
7093 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7094
7095 * xrdb.c (x_load_resources): Omit unused local.
7096
7097 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7098 (x_window): Rename locals to avoid shadowing.
7099 (USG): Use the kludged USG macro, to pacify gcc.
7100
7101 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7102 (x_term_init): Remove local to avoid shadowing.
7103
7104 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7105
7106 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7107 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7108
7109 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7110
7111 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7112
7113 Fix regex.c, syntax.c and friends for buffers > 2GB.
7114 * syntax.h (struct gl_state_s): Declare character position members
7115 EMACS_INT.
7116
7117 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7118
7119 * textprop.c (verify_interval_modification, interval_of):
7120 Declare arguments EMACS_INT.
7121
7122 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7123 EMACS_INT.
7124
7125 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7126
7127 * indent.c (Fvertical_motion): Local variable it_start is now
7128 EMACS_INT.
7129
7130 * regex.c (re_match, re_match_2, re_match_2_internal)
7131 (bcmp_translate, regcomp, regexec, print_double_string)
7132 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7133 (re_compile_pattern, re_exec): Declare arguments and local
7134 variables `size_t' and `ssize_t' and return values `regoff_t', as
7135 appropriate.
7136 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7137 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7138 <compile_stack_type>: `size' and `avail' are now `size_t'.
7139
7140 * regex.h <regoff_t>: Use ssize_t, not int.
7141 (re_search, re_search_2, re_match, re_match_2): Arguments that
7142 specify buffer/string position and length are now ssize_t and
7143 size_t. Return type is regoff_t.
7144
7145 2011-04-16 Ben Key <bkey76@gmail.com>
7146
7147 * nsfont.m: Fixed bugs in ns_get_family and
7148 ns_descriptor_to_entity that were caused by using free to
7149 deallocate memory blocks that were allocated by xmalloc (via
7150 xstrdup). This caused Emacs to crash when compiled with
7151 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7152 --enable-checking=xmallocoverrun). xfree is now used to
7153 deallocate these memory blocks.
7154
7155 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7156
7157 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7158
7159 emacs_write: Accept and return EMACS_INT for sizes.
7160 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7161 et seq.
7162 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7163 Accept and return EMACS_INT.
7164 (emacs_gnutls_write): Return the number of bytes written on
7165 partial writes.
7166 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7167 (emacs_read, emacs_write): Remove check for negative size, as the
7168 Emacs source code has been audited now.
7169 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7170 (emacs_read, emacs_write): Use it.
7171 * process.c (send_process): Adjust to the new signatures of
7172 emacs_write and emacs_gnutls_write. Do not attempt to store
7173 a byte offset into an 'int'; it might overflow.
7174 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7175
7176 * sound.c: Don't assume sizes fit in 'int'.
7177 (struct sound_device.period_size, alsa_period_size):
7178 Return EMACS_INT, not int.
7179 (struct sound_device.write, vox_write, alsa_write):
7180 Accept EMACS_INT, not int.
7181 (wav_play, au_play): Use EMACS_INT to store sizes and to
7182 record read return values.
7183
7184 2011-04-15 Ben Key <bkey76@gmail.com>
7185
7186 * keyboard.c (Qundefined): Don't declare static since it is used
7187 in nsfns.m.
7188 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7189 static since they are used in nsfont.m.
7190
7191 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7192
7193 * process.c (Qprocessp): Don't declare static.
7194 * lisp.h (Qprocessp): Declare again.
7195
7196 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7197
7198 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7199
7200 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7201
7202 Improve C-level modularity by making more things 'static'.
7203
7204 Don't publish debugger-only interfaces to other modules.
7205 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7206 (verify_bytepos, count_markers): Move decls to the only modules
7207 that need them.
7208 * region-cache.h (pp_cache): Likewise.
7209 * window.h (check_all_windows): Likewise.
7210 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7211
7212 * sysdep.c (croak): Now static, if
7213 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7214 * syssignal.h (croak): Declare only if not static.
7215
7216 * alloc.c (refill_memory_reserve): Now static if
7217 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7218 * lisp.h (refill_memory_reserve): Declare only if not static.
7219
7220 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7221 Define only if USE_LUCID.
7222
7223 * xrdb.c (x_customization_string, x_rm_string): Now static.
7224
7225 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7226 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7227
7228 * xdisp.c (draw_row_with_mouse_face): Now static.
7229 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7230
7231 * window.h (check_all_windows): Mark externally visible.
7232
7233 * window.c (window_deletion_count): Now static.
7234
7235 * undo.c: Make symbols static if they're not exported.
7236 (last_undo_buffer, last_boundary_position, pending_boundary):
7237 Now static.
7238
7239 * textprop.c (interval_insert_behind_hooks): Now static.
7240 (interval_insert_in_front_hooks): Likewise.
7241
7242 * term.c: Make symbols static if they're not exported.
7243 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7244 (max_frame_lines, tty_set_terminal_modes):
7245 (tty_reset_terminal_modes, tty_turn_off_highlight):
7246 (get_tty_terminal): Now static.
7247 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7248 * termhooks.h (term_mouse_moveto): Do not declare if
7249 HAVE_WINDOW_SYSTEM.
7250 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7251 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7252
7253 * sysdep.c: Make symbols static if they're not exported.
7254 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7255 Now static.
7256 (sigprocmask_set, full_mask): Remove; unused.
7257 (wait_debugging): Mark as visible.
7258 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7259 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7260
7261 * syntax.c (syntax_temp): Define only if !__GNUC__.
7262
7263 * sound.c (current_sound_device, current_sound): Now static.
7264
7265 * search.c (searchbufs, searchbuf_head): Now static.
7266
7267 * scroll.c (scroll_cost): Remove; unused.
7268 * dispextern.h (scroll_cost): Remove decl.
7269
7270 * region-cache.h (pp_cache): Mark as externally visible.
7271
7272 * process.c: Make symbols static if they're not exported.
7273 (process_tick, update_tick, create_process, chan_process):
7274 (Vprocess_alist, proc_buffered_char, datagram_access):
7275 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7276 (deactivate_process): Mark defn as static, as well as decl.
7277 * lisp.h (create_process): Remove decl.
7278 * process.h (chan_process, Vprocess_alist): Remove decls.
7279
7280 * print.c: Make symbols static if they're not exported.
7281 (print_depth, new_backquote_output, being_printed, print_buffer):
7282 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7283 (print_interval, print_number_index, initial_stderr_stream):
7284 Now static.
7285 * lisp.h (Fprinc): Remove decl.
7286 (debug_output_compilation_hack): Mark as externally visible.
7287
7288 * sysdep.c (croak): Move decl from here to syssignal.h.
7289 * syssignal.h (croak): Put it here, so the API can be checked when
7290 'croak' is called from dissociate_if_controlling_tty.
7291
7292 * minibuf.c: Make symbols static if they're not exported.
7293 (minibuf_save_list, choose_minibuf_frame): Now static.
7294 * lisp.h (choose_minibuf_frame): Remove decl.
7295
7296 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7297
7298 * lread.c: Make symbols static if they're not exported.
7299 (read_objects, initial_obarray, oblookup_last_bucket_number):
7300 Now static.
7301 (make_symbol): Remove; unused.
7302 * lisp.h (initial_obarray, make_symbol): Remove decls.
7303
7304 * keyboard.c: Make symbols static if they're not exported.
7305 (single_kboard, recent_keys_index, total_keys, recent_keys):
7306 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7307 (this_single_command_key_start, echoing, last_auto_save):
7308 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7309 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7310 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7311 (Vlispy_mouse_stem, double_click_count):
7312 Now static.
7313 (force_auto_save_soon): Define only if SIGDANGER.
7314 (ignore_mouse_drag_p): Now static if
7315 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7316 (print_help): Remove; unused.
7317 (stop_character, last_timer_event): Mark as externally visible.
7318 * keyboard.h (ignore_mouse_drag_p): Declare only if
7319 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7320 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7321 * lisp.h (echoing): Remove decl.
7322 (force_auto_save_soon): Declare only if SIGDANGER.
7323 * xdisp.c (redisplay_window): Simplify code, to make it more
7324 obvious that ignore_mouse_drag_p is not accessed if !defined
7325 USE_GTK && !defined HAVE_NS.
7326
7327 * intervals.c: Make symbols static if they're not exported.
7328 (merge_properties_sticky, merge_interval_right, delete_interval):
7329 Now static.
7330 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7331
7332 * insdel.c: Make symbols static if they're not exported.
7333 However, leave prepare_to_modify_buffer alone. It's never
7334 called from outside this function, but that appears to be a bug.
7335 (combine_after_change_list, combine_after_change_buffer):
7336 (adjust_after_replace, signal_before_change): Now static.
7337 (adjust_after_replace_noundo): Remove; unused.
7338 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7339 (signal_before_change): Remove decls.
7340
7341 * indent.c (val_compute_motion, val_vmotion): Now static.
7342
7343 * image.c: Make symbols static if they're not exported.
7344 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7345 if USE_GTK.
7346 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7347 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7348
7349 * fringe.c (standard_bitmaps): Now static.
7350 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7351
7352 * frame.c: Make symbols static if they're not exported.
7353 (x_report_frame_params, make_terminal_frame): Now static.
7354 (get_frame_param): Now static, unless HAVE_NS.
7355 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7356 (x_get_resource_string): Remove; not used.
7357 * frame.h (make_terminal_frame, x_report_frame_params):
7358 (x_get_resource_string); Remove decls.
7359 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7360 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7361
7362 * font.c, fontset.c: Make symbols static if they're not exported.
7363 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7364 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7365 * font.c (font_close_object): Now static.
7366 * font.h (font_close_object): Remove.
7367 * fontset.c (FONTSET_OBJLIST): Remove.
7368 (free_realized_fontset) #if-0 the body, which does nothing.
7369 (face_suitable_for_char_p): #if-0, as it's never called.
7370 * fontset.h (face_suitable_for_char_p): Remove decl.
7371 * xfaces.c (face_at_string_position):
7372 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7373 since 0 is always ASCII.
7374
7375 * fns.c (weak_hash_tables): Now static.
7376
7377 * fileio.c: Make symbols static if they're not exported.
7378 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7379 (Vwrite_region_annotation_buffers): Now static.
7380
7381 * eval.c: Make symbols static if they're not exported.
7382 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7383 * lisp.h (backtrace_list): Remove decl.
7384
7385 * emacs.c: Make symbols static if they're not exported.
7386 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7387 (fatal_error_code, fatal_error_signal_hook, standard_args):
7388 Now static.
7389 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7390 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7391 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7392 * lisp.h (fatal_error_signal_hook): Remove decl.
7393 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7394
7395 * editfns.c: Move a (normally-unused) function to its only use.
7396 * editfns.c, lisp.h (get_operating_system_release): Remove.
7397 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7398 worth the hassle of breaking this out.
7399
7400 * xterm.c: Make symbols static if they're not exported.
7401 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7402 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7403 (x_destroy_window, x_delete_display):
7404 Now static.
7405 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7406 (x_mouse_leave): Remove; unused.
7407 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7408 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7409 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7410 Remove decls.
7411 (x_mouse_leave): Declare only if WINDOWSNT.
7412 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7413 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7414 USE_X_TOOLKIT.
7415
7416 * ftxfont.c: Make symbols static if they're not exported.
7417 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7418 HAVE_FREETYPE.
7419 * font.h (ftxfont_driver): Likewise.
7420
7421 * xfns.c: Make symbols static if they're not exported.
7422 (x_last_font_name, x_display_info_for_name):
7423 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7424 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7425 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7426 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7427 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7428 (last_show_tip_args): Now static.
7429 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7430 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7431 (x_screen_planes): Remove; unused.
7432 * dispextern.h (x_screen_planes): Remove decl.
7433
7434 * dispnew.c: Make symbols static if they're not exported.
7435 * dispextern.h (redraw_garbaged_frames, scrolling):
7436 (increment_row_positions): Remove.
7437 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7438 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7439 Now static.
7440 (redraw_garbaged_frames): Remove; unused.
7441
7442 * xfaces.c: Make symbols static if they're not exported.
7443 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7444 Remove decls.
7445 * xterm.h (defined_color): Remove decls.
7446 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7447 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7448 (menu_face_changed_default, defined_color, free_realized_face):
7449 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7450 (ascii_face_of_lisp_face): Remove; unused.
7451
7452 * xdisp.c: Make symbols static if they're not exported.
7453 * dispextern.h (scratch_glyph_row, window_box_edges):
7454 (glyph_to_pixel_coords, set_cursor_from_row):
7455 (get_next_display_element, set_iterator_to_next):
7456 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7457 (show_mouse_face): Remove decls
7458 * frame.h (message_buf_print): Likewise.
7459 * lisp.h (pop_message, set_message, check_point_in_composition):
7460 Likewise.
7461 * xterm.h (set_vertical_scroll_bar): Likewise.
7462 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7463 (message_buf_print, scratch_glyph_row, displayed_buffer):
7464 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7465 (get_next_display_element, show_mouse_face, window_box_edges):
7466 (frame_to_window_pixel_xy, check_point_in_composition):
7467 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7468 (glyph_to_pixel_coords): Remove; unused.
7469
7470 * dired.c (file_name_completion): Now static.
7471
7472 * dbusbind.c (xd_in_read_queued_messages): Now static.
7473
7474 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7475 * data.c (circular_list_error): Remove.
7476
7477 * commands.h (last_point_position, last_point_position_buffer):
7478 (last_point_position_window): Remove decls.
7479 * keyboard.c: Make these variables static.
7480
7481 * coding.h (coding, code_convert_region, encode_coding_gap):
7482 Remove decls.
7483 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7484 (iso_code_class, detect_coding, code_convert_region): Now static.
7485 (encode_coding_gap): Remove; unused.
7486
7487 * chartab.c (chartab_chars, chartab_bits): Now static.
7488
7489 * charset.h (charset_iso_8859_1): Remove decl.
7490 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7491 Now static.
7492
7493 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7494 * ccl.c (Vccl_program_table): Now static.
7495 (check_ccl_update): Remove; unused.
7496
7497 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7498 * category.h: ... from here.
7499 * category.c (check_category_table, set_category_set): Now static.
7500
7501 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7502 * lisp.h: Remove these decls.
7503
7504 * buffer.c (buffer_count): Remove unused var.
7505
7506 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7507 so that it's not optimized away.
7508 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7509 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7510 exported only to the debugger.
7511
7512 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7513 * atimer.h (run_all_atimers): Remove; not exported.
7514
7515 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7516 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7517 was inaccessible from Lisp.
7518 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7519 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7520
7521 alloc.c: Import and export fewer symbols, and remove unused items.
7522 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7523 is defined.
7524 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7525 it's not optimized away by whole-program optimization.
7526 (message_enable_multibyte, free_misc): Remove.
7527 (catchlist, handlerlist, mark_backtrace):
7528 Declare only if BYTE_MARK_STACK.
7529 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7530 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7531 (message_enable_multibyte): Remove decl.
7532 (free_misc, interval_free_list, float_block, float_block_index):
7533 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7534 (cons_free_list, last_marked_index):
7535 Now static.
7536 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7537 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7538 (mark_backtrace): Define only if BYTE_MARK_STACK.
7539 * xdisp.c (message_enable_multibyte): Now static.
7540
7541 Declare Lisp_Object Q* variables to be 'static' if not exported.
7542 This makes it easier for human readers (and static analyzers)
7543 to see whether these variables are used from other modules.
7544 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7545 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7546 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7547 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7548 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7549 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7550 * xmenu.c, xselect.c:
7551 Declare Q* vars static if they are not used in other modules.
7552 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7553 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7554 Remove decls of unexported vars.
7555 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7556
7557 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7558
7559 Make Emacs functions such as Fatom 'static' by default.
7560 This makes it easier for human readers (and static analyzers)
7561 to see whether these functions can be called from other modules.
7562 DEFUN now defines a static function. To make the function external
7563 so that it can be used in other C modules, use the new macro DEFUE.
7564 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7565 (Finit_image_library):
7566 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7567 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7568 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7569 Remove decls, since these functions are now static.
7570 (Funintern, Fget_internal_run_time): New decls, since these functions
7571 were already external.
7572
7573 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7574 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7575 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7576 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7577 * keyboard.c, keymap.c, lread.c:
7578 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7579 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7580 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7581 Mark functions with DEFUE instead of DEFUN,
7582 if they are used in other modules.
7583 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7584 decls for now-static functions.
7585 * buffer.h (Fdelete_overlay): Remove decl.
7586 * callproc.c (Fgetenv_internal): Mark as internal.
7587 * composite.c (Fremove_list_of_text_properties): Remove decl.
7588 (Fcomposition_get_gstring): New forward static decl.
7589 * composite.h (Fcomposite_get_gstring): Remove decl.
7590 * dired.c (Ffile_attributes): New forward static decl.
7591 * doc.c (Fdocumntation_property): New forward static decl.
7592 * eval.c (Ffetch_bytecode): New forward static decl.
7593 (Funintern): Remove extern decl; now in .h file where it belongs.
7594 * fileio.c (Fmake_symbolic_link): New forward static decl.
7595 * image.c (Finit_image_library): New forward static decl.
7596 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7597 * intervals.h (Fprevious_property_change):
7598 (Fremove_list_of_text_properties): Remove decls.
7599 * keyboard.c (Fthis_command_keys): Remove decl.
7600 (Fcommand_execute): New forward static decl.
7601 * keymap.c (Flookup_key): New forward static decl.
7602 (Fcopy_keymap): Now static.
7603 * keymap.h (Flookup_key): Remove decl.
7604 * process.c (Fget_process): New forward static decl.
7605 (Fprocess_datagram_address): Mark as internal.
7606 * syntax.c (Fsyntax_table_p): New forward static decl.
7607 (skip_chars): Remove duplicate decl.
7608 * textprop.c (Fprevious_property_change): New forward static decl.
7609 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7610 Now internal.
7611 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7612 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7613
7614 * editfns.c (Fformat): Remove unreachable code.
7615
7616 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7617
7618 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7619 change. (Bug#8496)
7620
7621 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7622
7623 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7624 when at ZV. (Bug#8487)
7625
7626 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7627
7628 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7629 (Bug#8437)
7630 * keyboard.c (parse_tool_bar_item): Likewise.
7631 * sound.c (sound_cleanup, alsa_close): Likewise.
7632 * termcap.c (tgetent): Likewise.
7633 * xfns.c (x_default_font_parameter): Likewise.
7634 * xsettings.c (read_and_apply_settings): Likewise.
7635
7636 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7637 (overrun_check_free): Protoize.
7638
7639 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7640
7641 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7642 since callers should never pass a negative size.
7643 Change the signature to match that of plain 'read' and 'write'; see
7644 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7645 * lisp.h: Update prototypes of emacs_write and emacs_read.
7646
7647 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7648
7649 * xdisp.c (redisplay_window): Don't try to determine the character
7650 position of the scroll margin if the window start point w->startp
7651 is outside the buffer's accessible region. (Bug#8468)
7652
7653 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7654
7655 Fix write-region and its subroutines for buffers > 2GB.
7656 * fileio.c (a_write, e_write): Modify declaration of arguments and
7657 local variables to support buffers larger than 2GB.
7658 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7659
7660 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7661 argument, local variables, and return value.
7662
7663 * lisp.h: Update prototypes of emacs_write and emacs_read.
7664
7665 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7666
7667 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7668
7669 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7670
7671 Fix more problems found by GCC 4.6.0's static checks.
7672
7673 * xdisp.c (vmessage): Use a better test for character truncation.
7674
7675 * charset.c (load_charset_map): <, not <=, for optimization,
7676 and to avoid potential problems with integer overflow.
7677 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7678 * casetab.c (set_identity, shuffle): Likewise.
7679 * editfns.c (Fformat): Likewise.
7680 * syntax.c (skip_chars): Likewise.
7681
7682 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7683 This also lets GCC 4.6.0 generate slightly better loop code.
7684
7685 * callint.c (Fcall_interactively): <, not <=, for optimization.
7686 (Fcall_interactively): Count the number of arguments produced,
7687 not the number of arguments given. This is simpler and lets GCC
7688 4.6.0 generate slightly better code.
7689
7690 * ftfont.c: Distingish more carefully between FcChar8 and char.
7691 The previous code passed unsigned char * to a functions like
7692 strlen and xstrcasecmp that expect char *, which does not
7693 conform to the C standard.
7694 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7695 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7696 char * when the C standard requires it.
7697
7698 * keyboard.c (read_char): Remove unused var.
7699
7700 * eval.c: Port to Windows vsnprintf (Bug#8435).
7701 Include <limits.h>.
7702 (SIZE_MAX): Define if the headers do not.
7703 (verror): Do not give up if vsnprintf returns a negative count.
7704 Instead, grow the buffer. This ports to Windows vsnprintf, which
7705 does not conform to C99. Problem reported by Eli Zaretskii.
7706 Also, simplify the allocation scheme, by avoiding the need for
7707 calling realloc, and removing the ALLOCATED variable.
7708
7709 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7710
7711 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7712 But keep the doprint source code for now, as we might revamp it
7713 and use it again (Bug#8435).
7714 * lisp.h (doprnt): Remove.
7715 * Makefile.in (base_obj): Remove doprnt.o.
7716 * deps.mk (doprnt.o): Remove.
7717
7718 error: Print 32- and 64-bit integers portably (Bug#8435).
7719 Without this change, on typical 64-bit hosts error ("...%d...", N)
7720 was used to print both 32- and 64-bit integers N, which relied on
7721 undefined behavior.
7722 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7723 New macro.
7724 * lisp.h (error, verror): Mark as printf-like functions.
7725 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7726 Report overflow in size calculations when allocating printf buffer.
7727 Do not truncate output string at its first null byte.
7728 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7729 Truncate the output at a character boundary, since vsnprintf does not
7730 do that.
7731 * charset.c (check_iso_charset_parameter): Convert internal
7732 character to string before calling 'error', since %c now has the
7733 printf meaning.
7734 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7735 overflow when computing char to be passed to 'error'. Do not
7736 pass Lisp_Object to 'error'; pass the integer instead.
7737 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7738 formatted with plain %d.
7739
7740 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7741
7742 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7743
7744 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7745
7746 * xterm.c (x_catch_errors): Remove duplicate declaration.
7747
7748 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7749
7750 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7751
7752 2011-04-10 Jim Meyering <meyering@redhat.com>
7753
7754 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7755 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7756 return ssize_t not "int", and use size_t as the buffer length.
7757 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7758 * gnutls.h: Update declarations.
7759 * process.c (read_process_output): Use ssize_t, to match.
7760 (send_process): Likewise.
7761
7762 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7763
7764 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7765
7766 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7767
7768 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7769 Use unsigned char, to match FcChar8 type definition.
7770
7771 * xterm.c (handle_one_xevent):
7772 * xmenu.c (create_and_show_popup_menu):
7773 * xselect.c (x_decline_selection_request)
7774 (x_reply_selection_request): Avoid type-punned deref of X events.
7775
7776 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7777
7778 Fix some uses of `int' instead of EMACS_INT.
7779 * search.c (string_match_1, fast_string_match)
7780 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7781 (scan_buffer, find_next_newline_no_quit)
7782 (find_before_next_newline, search_command, Freplace_match)
7783 (Fmatch_data): Make some `int' variables be EMACS_INT.
7784
7785 * xdisp.c (display_count_lines): 3rd argument and return value now
7786 EMACS_INT. All callers changed.
7787 (pint2hrstr): Last argument is now EMACS_INT.
7788
7789 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7790 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7791 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7792 (decode_coding_utf_16, decode_coding_emacs_mule)
7793 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7794 (decode_coding_ccl, decode_coding_charset)
7795 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7796 (decode_coding_iso_2022, decode_coding_emacs_mule)
7797 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7798 <char_offset, last_offset>: Declare EMACS_INT.
7799 (encode_coding_utf_8, encode_coding_utf_16)
7800 (encode_coding_emacs_mule, encode_invocation_designation)
7801 (encode_designation_at_bol, encode_coding_iso_2022)
7802 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7803 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7804 Declare EMACS_INT.
7805 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7806 (encode_invocation_designation): Last argument P_NCHARS is now
7807 EMACS_INT.
7808 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7809 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7810
7811 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7812 All users changed.
7813
7814 * ccl.c (Fccl_execute_on_string): Declare some variables
7815 EMACS_INT.
7816
7817 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7818
7819 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7820
7821 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7822
7823 * process.c (Fformat_network_address): Doc fix.
7824
7825 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7826
7827 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7828
7829 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7830
7831 * keyboard.c (read_char): Call Lisp function help-form-show,
7832 instead of using internal_with_output_to_temp_buffer.
7833 (Qhelp_form_show): New var.
7834 (syms_of_keyboard): Use DEFSYM macro.
7835
7836 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7837
7838 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7839
7840 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7841
7842 * process.c (Flist_processes): Remove to Lisp.
7843 (list_processes_1): Delete.
7844
7845 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7846
7847 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7848
7849 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7850
7851 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7852
7853 Fix more problems found by GCC 4.6.0's static checks.
7854
7855 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7856
7857 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7858
7859 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7860
7861 * xdisp.c (vmessage): Mark as a printf-like function.
7862
7863 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7864
7865 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7866
7867 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7868 printf-like functions.
7869 (tiff_load): Add casts to remove these marks before passing them
7870 to system-supplied API.
7871
7872 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7873
7874 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7875 This avoids several warnings with gcc -Wstrict-overflow.
7876 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7877 directly, rather than having caller test rule sign. This avoids
7878 some unnecessary tests.
7879 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7880 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7881 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7882
7883 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7884 (xfont_open): Avoid unnecessary tests.
7885
7886 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7887
7888 * composite.h, composite.c (composition_gstring_put_cache):
7889 Use EMACS_INT, not int, for length.
7890
7891 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7892 breaking out part of COMPOSITION_DECODE_RULE.
7893 (COMPOSITION_DECODE_RULE): Use it.
7894 * composite.c (get_composition_id): Remove unused local vars,
7895 by using the new macro.
7896
7897 * textprop.c (set_text_properties_1): Change while to do-while,
7898 since the condition is always true at first.
7899
7900 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7901 (interval_deletion_adjustment): Return unsigned value.
7902 All uses changed.
7903
7904 * process.c (list_processes_1, create_pty, read_process_output):
7905 (exec_sentinel): Remove vars that were set but not used.
7906 (create_pty): Remove unnecessary "volatile"s.
7907 (Fnetwork_interface_info): Avoid possibility of int overflow.
7908 (read_process_output): Do adaptive read buffering even if carryover.
7909 (read_process_output): Simplify nbytes computation if buffered.
7910
7911 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7912
7913 * syntax.c (scan_words): Remove var that was set but not used.
7914 (update_syntax_table): Use unsigned instead of int.
7915
7916 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7917 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7918 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7919
7920 * print.c (print_error_message): Avoid int overflow.
7921
7922 * font.c (font_list_entities): Redo for clarity,
7923 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7924
7925 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7926 (font_score): Avoid potential overflow in diff calculation.
7927
7928 * fns.c (substring_both): Remove var that is set but not used.
7929 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7930
7931 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7932
7933 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7934 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7935 can always succeed if overflow has undefined behavior.
7936
7937 * search.c (boyer_moore, wordify): Remove vars set but not used.
7938 (wordify): Omit three unnecessary tests.
7939
7940 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7941 All callers changed. This avoids the need for an unused var.
7942
7943 * casefiddle.c (casify_region): Remove var that is set but not used.
7944
7945 * dired.c (file_name_completion): Remove var that is set but not used.
7946
7947 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7948
7949 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7950 (Finsert_file_contents): Remove unnecessary code checking fd.
7951
7952 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7953 Check for integer overflow on size calculations.
7954
7955 * buffer.c (Fprevious_overlay_change): Remove var that is set
7956 but not used.
7957
7958 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7959 Remove vars that are set but not used.
7960 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7961 (timer_check_2): Mark vars as initialized.
7962
7963 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7964
7965 * image.c (lookup_image): Remove var that is set but not used.
7966 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7967
7968 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7969 that are set but not used.
7970
7971 * xfns.c (make_invisible_cursor): Don't return garbage
7972 if XCreateBitmapFromData fails (Bug#8410).
7973
7974 * xselect.c (x_get_local_selection, x_handle_property_notify):
7975 Remove vars that are set but not used.
7976
7977 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7978 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7979
7980 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7981 Remove var that is set but not used.
7982 (scroll_bar_windows_size): Now size_t, not int.
7983 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7984 Check for overflow.
7985
7986 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7987 (map_tty_color) [!defined MSDOS]: Likewise.
7988
7989 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7990
7991 * coding.c: Remove vars that are set but not used.
7992 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7993 All callers changed.
7994 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7995 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7996 (decode_coding_charset): Remove vars that are set but not used.
7997
7998 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7999 that is set but not used.
8000
8001 * print.c (print_object): Remove var that is set but not used.
8002
8003 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8004 The gnulib version avoids calling malloc in the usual case,
8005 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8006 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8007 * filelock.c (current_lock_owner): Likewise.
8008 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8009 * sysdep.c: Include allocator.h, careadlinkat.h.
8010 (emacs_no_realloc_allocator): New static constant.
8011 (emacs_readlink): New function.
8012 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8013 ../lib/careadlinkat.h.
8014
8015 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8016
8017 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8018 first non-nil return value).
8019
8020 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8021
8022 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8023 if not defined (Bug#8403).
8024
8025 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8026
8027 * xdisp.c (display_count_lines): Remove parameter `start',
8028 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8029 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8030 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8031 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8032 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8033 and thereabouts. All callers changed.
8034 (get_per_char_metric): Remove parameter `f', unused since
8035 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8036
8037 2011-04-02 Jim Meyering <meyering@redhat.com>
8038
8039 do not dereference NULL upon failed strdup
8040 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8041 (ns_get_family): Likewise.
8042
8043 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8044
8045 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8046
8047 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8048
8049 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8050 later (Bug#8403).
8051
8052 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8053
8054 Add lexical binding.
8055
8056 * window.c (Ftemp_output_buffer_show): New fun.
8057 (Fsave_window_excursion):
8058 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8059
8060 * lread.c (lisp_file_lexically_bound_p): New function.
8061 (Fload): Bind Qlexical_binding.
8062 (readevalloop): Remove `evalfun' arg.
8063 Bind Qinternal_interpreter_environment.
8064 (Feval_buffer): Bind Qlexical_binding.
8065 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8066 Mark as dynamic.
8067 (syms_of_lread): Declare `lexical-binding'.
8068
8069 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8070
8071 * keyboard.c (eval_dyn): New fun.
8072 (menu_item_eval_property): Use it.
8073
8074 * image.c (parse_image_spec): Use Ffunctionp.
8075
8076 * fns.c (concat, mapcar1): Accept byte-code-functions.
8077
8078 * eval.c (Fsetq): Handle lexical vars.
8079 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8080 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8081 (FletX, Flet): Obey lexical binding.
8082 (Fcommandp): Handle closures.
8083 (Feval): New `lexical' arg.
8084 (eval_sub): New function extracted from Feval. Use it almost
8085 everywhere where Feval was used. Look up vars in lexical env.
8086 Handle closures.
8087 (Ffunctionp): Move from subr.el.
8088 (Ffuncall): Handle closures.
8089 (apply_lambda): Remove `eval_flags'.
8090 (funcall_lambda): Handle closures and new byte-code-functions.
8091 (Fspecial_variable_p): New function.
8092 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8093 but without exporting it to Lisp.
8094
8095 * doc.c (Fdocumentation, store_function_docstring):
8096 * data.c (Finteractive_form): Handle closures.
8097
8098 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8099 interactive spec.
8100
8101 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8102 New byte-codes.
8103 (exec_byte_code): New function extracted from Fbyte_code to handle new
8104 calling convention for byte-code-functions. Add new byte-codes.
8105
8106 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8107
8108 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8109
8110 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8111
8112 * xdisp.c (redisplay_internal): Fix prototype.
8113
8114 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8115
8116 * xdisp.c (SCROLL_LIMIT): New macro.
8117 (try_scrolling): Use it when setting scroll_limit.
8118 Limit scrolling to 100 screen lines.
8119 (redisplay_window): Even when falling back on "recentering",
8120 position point in the window according to scroll-conservatively,
8121 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8122
8123 (try_scrolling): When point is above the window, allow searching
8124 as far as scroll_max, or one screenful, to compute vertical
8125 distance from PT to the scroll margin position. This prevents
8126 try_scrolling from unnecessarily failing when
8127 scroll-conservatively is set to a value slightly larger than the
8128 window height. Clean up the case of PT below the margin at bottom
8129 of window: scroll_max can no longer be INT_MAX. When aggressive
8130 scrolling is in use, don't let point enter the opposite scroll
8131 margin as result of the scroll.
8132 (syms_of_xdisp) <scroll-conservatively>: Document the
8133 threshold of 100 lines for never-recentering scrolling.
8134
8135 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8136
8137 * dispextern.h (move_it_by_lines):
8138 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8139 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8140 (message_log_check_duplicate): Remove parameters `prev_bol' and
8141 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8142 (redisplay_internal): Remove parameter `preserve_echo_area',
8143 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8144
8145 * indent.c (Fvertical_motion):
8146 * window.c (window_scroll_pixel_based, Frecenter):
8147 Don't pass `need_y_p' to `move_it_by_lines'.
8148
8149 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8150
8151 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8152 steal a few bits to be more compact.
8153 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8154 Remove unneeded casts.
8155
8156 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8157
8158 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8159
8160 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8161 binding" message (bug#7967).
8162
8163 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8164
8165 Fix more problems found by GCC 4.6.0's static checks.
8166
8167 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8168 Remove unused local var.
8169
8170 * editfns.c (Fmessage_box): Remove unused local var.
8171
8172 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8173 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8174 Omit unused local vars.
8175 * window.c (shrink_windows): Omit unused local var.
8176 * menu.c (digest_single_submenu): Omit unused local var.
8177 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8178 Omit unused local var.
8179
8180 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8181 Don't assume string length fits in int.
8182 (keyremap_step, read_key_sequence): Use size_t for sizes.
8183 (read_key_sequence): Don't check last_real_key_start redundantly.
8184
8185 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8186 instead of alloca (Bug#8344).
8187
8188 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8189 (Fbacktrace_frame): Don't assume nframes fits in int.
8190
8191 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8192
8193 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8194 concerns.
8195
8196 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8197
8198 * cm.c (calccost): Turn while-do into do-while, for clarity.
8199
8200 * keyboard.c (syms_of_keyboard): Use the same style as later
8201 in this function when indexing through an array. This also
8202 works around GCC bug 48267.
8203
8204 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8205
8206 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8207
8208 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8209 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8210
8211 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8212 This avoids undefined behavior on integer overflow, and is a bit
8213 more convenient anyway since it is compared to a size_t variable.
8214
8215 Variadic C functions now count arguments with size_t, not int.
8216 This avoids an unnecessary limitation on 64-bit machines, which
8217 caused (substring ...) to crash on large vectors (Bug#8344).
8218 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8219 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8220 All variadic functions and their callers changed accordingly.
8221 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8222 * data.c (arith_driver, float_arith_driver): Likewise.
8223 * editfns.c (general_insert_function): Likewise.
8224 * eval.c (struct backtrace.nargs, interactive_p)
8225 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8226 (funcall_lambda, mark_backtrace): Likewise.
8227 * fns.c (concat): Likewise.
8228 * frame.c (x_set_frame_parameters): Likewise.
8229 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8230 0 if not found, not -1. All callers changed.
8231
8232 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8233 (stack_copy_size): Now size_t, not int.
8234 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8235
8236 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8237
8238 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8239 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8240 All callers changed.
8241
8242 * lisp.h (multibyte_char_to_unibyte):
8243 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8244 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8245 * character.h (CHAR_TO_BYTE8):
8246 * cmds.c (internal_self_insert):
8247 * editfns.c (general_insert_function):
8248 * keymap.c (push_key_description):
8249 * search.c (Freplace_match):
8250 * xdisp.c (message_dolog, set_message_1): All callers changed.
8251
8252 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8253
8254 * keyboard.c (safe_run_hook_funcall): New function.
8255 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8256 don't set the hook to nil, but remove the offending function instead.
8257 (Qcommand_hook_internal): Remove, unused.
8258 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8259 Vcommand_hook_internal.
8260
8261 * eval.c (enum run_hooks_condition): Remove.
8262 (funcall_nil, funcall_not): New functions.
8263 (run_hook_with_args): Call each function through a `funcall' argument.
8264 Remove `cond' argument, now redundant.
8265 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8266 (Frun_hook_with_args_until_failure): Adjust accordingly.
8267 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8268
8269 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8270
8271 * dispextern.h (string_buffer_position): Remove declaration.
8272
8273 * print.c (strout): Remove parameter `multibyte', unused since
8274 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8275
8276 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8277 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8278 All callers changed.
8279
8280 * w32.c (_wsa_errlist): Use braces for struct initializers.
8281
8282 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8283 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8284 All callers changed.
8285 (string_buffer_position): Likewise. Also, make static (it's never
8286 used outside xdisp.c).
8287 (cursor_row_p): Remove parameter `w', unused since
8288 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8289 (decode_mode_spec): Remove parameter `precision', introduced during
8290 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8291 All callers changed.
8292
8293 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8294
8295 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8296
8297 2011-03-27 Anders Lindgren <andlind@gmail.com>
8298
8299 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8300 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8301 (ns_update_auto_hide_menu_bar): New functions.
8302 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8303 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8304 ns_constrain_all_frames.
8305 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8306 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8307
8308 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8309
8310 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8311
8312 2011-03-27 Glenn Morris <rgm@gnu.org>
8313
8314 * syssignal.h: Replace RETSIGTYPE with void.
8315 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8316 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8317 Replace SIGTYPE with void everywhere.
8318 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8319 * s/template.h (SIGTYPE): Remove commented out definition.
8320
8321 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8322
8323 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8324 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8325
8326 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8327
8328 * w32.c (read_unc_volume): Use parameter `henum', instead of
8329 global variable `wget_enum_handle'.
8330
8331 * keymap.c (describe_vector): Remove parameters `indices' and
8332 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8333 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8334
8335 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8336
8337 * keyboard.c (timer_check): Remove parameter `do_it_now',
8338 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8339 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8340 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8341
8342 * keyboard.c (read_char):
8343 * w32menu.c (w32_menu_display_help):
8344 * xmenu.c (show_help_event, menu_help_callback):
8345 Adjust calls to `show_help_echo'.
8346
8347 * gtkutil.c (xg_maybe_add_timer):
8348 * keyboard.c (readable_events):
8349 * process.c (wait_reading_process_output):
8350 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8351
8352 * insdel.c (adjust_markers_gap_motion):
8353 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8354 (gap_left, gap_right): Don't call it.
8355
8356 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8357
8358 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8359 incurred during fontification.
8360
8361 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8362
8363 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8364 (DEFVAR_PER_BUFFER): Don't pass it.
8365
8366 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8367 (scrolling_window): Don't pass it.
8368
8369 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8370
8371 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8372
8373 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8374 and `suffix'.
8375 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8376 of variables specific to SELinux and computation of `encoded_absname'.
8377
8378 * image.c (XPutPixel): Remove unused variable `height'.
8379
8380 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8381
8382 * unexw32.c (get_section_info): Remove unused variable `section'.
8383
8384 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8385 (system_process_attributes): Remove unused variable `sess'.
8386 (sys_read): Remove unused variable `err'.
8387
8388 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8389 (w32_wnd_proc): Remove unused variable `isdead'.
8390 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8391 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8392 (x_create_tip_frame): Remove unused variable `tem'.
8393
8394 * w32inevt.c (w32_console_read_socket):
8395 Remove unused variable `no_events'.
8396
8397 * w32term.c (x_draw_composite_glyph_string_foreground):
8398 Remove unused variable `width'.
8399
8400 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8401
8402 * w32term.c (x_set_glyph_string_clipping):
8403 Don't pass uninitialized region to CombineRgn.
8404
8405 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8406
8407 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8408 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8409 (Fx_close_connection): Remove unused variable `i'.
8410
8411 * w32font.c (w32font_draw): Return number of glyphs.
8412 (w32font_open_internal): Remove unused variable `i'.
8413 (w32font_driver): Add missing initializer.
8414
8415 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8416 (fill_in_menu): Remove unused variable `items_added'.
8417
8418 * w32term.c (last_mouse_press_frame): Remove static global variable.
8419 (w32_clip_to_row): Remove unused variable `f'.
8420 (x_delete_terminal): Remove unused variable `i'.
8421
8422 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8423 (NOTHING): Remove unused static global variable.
8424 (uniscribe_check_otf): Remove unused variable `table'.
8425 (uniscribe_font_driver): Add missing initializers.
8426
8427 2011-03-23 Julien Danjou <julien@danjou.info>
8428
8429 * term.c (Fsuspend_tty, Fresume_tty):
8430 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8431 * window.c (temp_output_buffer_show):
8432 * insdel.c (signal_before_change):
8433 * frame.c (Fhandle_switch_frame):
8434 * fileio.c (Fdo_auto_save):
8435 * emacs.c (Fkill_emacs):
8436 * editfns.c (save_excursion_restore):
8437 * cmds.c (internal_self_insert):
8438 * callint.c (Fcall_interactively):
8439 * buffer.c (Fkill_all_local_variables):
8440 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8441 Use Frun_hooks.
8442 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8443 unconditionally since it does the check itself.
8444
8445 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8446
8447 Fix more problems found by GCC 4.5.2's static checks.
8448
8449 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8450 the first time through the loop, since we know p0 < p1 then.
8451 This also avoids a gcc -Wstrict-overflow warning.
8452
8453 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8454 leading to a memory leak, possible in functions like
8455 load_charset_map_from_file that can allocate an unbounded number
8456 of objects (Bug#8318).
8457
8458 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8459 that could (at least in theory) be that large.
8460
8461 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8462 This is less likely to overflow, and avoids undefined behavior if
8463 overflow does occur. All callers changed. Use strtoul to scan
8464 for the unsigned long integer.
8465 (pint2hrstr): Simplify and tune code slightly.
8466 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8467
8468 * scroll.c (do_scrolling): Work around GCC bug 48228.
8469 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8470
8471 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8472 This also avoids a warning with gcc -Wstrict-overflow.
8473 (validate_x_resource_name): Simplify count usage.
8474 This also avoids a warning with gcc -Wstrict-overflow.
8475
8476 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8477 fail (Bug#8306).
8478
8479 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8480
8481 * process.c (Fmake_network_process): Use socklen_t, not int,
8482 where POSIX says socklen_t is required in portable programs.
8483 This fixes a porting bug on hosts like 64-bit HP-UX, where
8484 socklen_t is wider than int (Bug#8277).
8485 (Fmake_network_process, server_accept_connection):
8486 (wait_reading_process_output, read_process_output):
8487 Likewise.
8488
8489 * process.c: Rename or move locals to avoid shadowing.
8490 (list_processes_1, Fmake_network_process):
8491 (read_process_output_error_handler, exec_sentinel_error_handler):
8492 Rename or move locals.
8493 (Fmake_network_process): Define label "retry_connect" only if needed.
8494 (Fnetwork_interface_info): Fix pointer signedness.
8495 (process_send_signal): Add cast to avoid pointer signedness problem.
8496 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8497 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8498
8499 Make tparam.h and terminfo.c consistent.
8500 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8501 Include tparam.h instead, since it declares them.
8502 * cm.h (PC): Remove extern decl; tparam.h now does this.
8503 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8504 * terminfo.c: Include tparam.h, to check interfaces.
8505 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8506 (tparam): Adjust signature to match interface in tparam.h;
8507 this removes some undefined behavior. Check that outstring and len
8508 are zero, which they always are with Emacs.
8509 * tparam.h (PC, BC, UP): New extern decls.
8510
8511 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8512 (xftfont_open): Rename locals to avoid shadowing.
8513
8514 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8515 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8516 (OTF_TAG_SYM): Omit macro if not needed.
8517 (ftfont_list): Remove unused local.
8518 (get_adstyle_property, ftfont_pattern_entity):
8519 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8520 Rename locals to avoid shadowing.
8521
8522 * xfont.c (xfont_list_family): Mark var as initialized.
8523
8524 * xml.c (make_dom): Now static.
8525
8526 * composite.c (composition_compute_stop_pos): Rename local to
8527 avoid shadowing.
8528 (composition_reseat_it): Remove unused locals.
8529 (find_automatic_composition, composition_adjust_point): Likewise.
8530 (composition_update_it): Mark var as initialized.
8531 (find_automatic_composition): Mark vars as initialized,
8532 with a FIXME (Bug#8290).
8533
8534 character.h: Rename locals to avoid shadowing.
8535 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8536 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8537 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8538 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8539 to avoid shadowing.
8540
8541 * textprop.c (property_change_between_p): Remove; unused.
8542
8543 * intervals.c (interval_start_pos): Now static.
8544
8545 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8546
8547 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8548 Rename locals to avoid shadowing.
8549
8550 * sound.c (wav_play, au_play, Fplay_sound_internal):
8551 Fix pointer signedness.
8552 (alsa_choose_format): Remove unused local var.
8553 (wav_play): Initialize a variable to 0, to prevent undefined
8554 behavior (Bug#8278).
8555
8556 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8557
8558 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8559
8560 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8561 clobbering (Bug#8298).
8562 * sysdep.c (sys_subshell): Likewise.
8563 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8564
8565 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8566 This should get cleaned up, so that child_setup has the
8567 same signature on all platforms.
8568
8569 * callproc.c (call_process_cleanup): Now static.
8570 (relocate_fd): Rename locals to avoid shadowing.
8571
8572 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8573
8574 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8575 not to be necessary, and produces flickering.
8576
8577 2011-03-20 Glenn Morris <rgm@gnu.org>
8578
8579 * config.in: Remove file.
8580
8581 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8582
8583 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8584 are now in src/globals.h.
8585 (syms_of_minibuf): Remove spurious & from previous change.
8586
8587 2011-03-20 Leo Liu <sdl.web@gmail.com>
8588
8589 * minibuf.c (completing-read-function): New variable.
8590 (completing-read-default): Rename from completing-read.
8591 (completing-read): Call completing-read-function.
8592
8593 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8594
8595 * xfaces.c (Fx_load_color_file):
8596 Read color file from absolute filename (bug#8250).
8597
8598 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8599
8600 * makefile.w32-in: Update dependencies.
8601
8602 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8603
8604 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8605
8606 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8607
8608 Fix more problems found by GCC 4.5.2's static checks.
8609
8610 * process.c (make_serial_process_unwind, send_process_trap):
8611 (sigchld_handler): Now static.
8612
8613 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8614 That way, the code declares only the vars that it needs.
8615 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8616 * s/cygwin.h (PTY_ITERATION): Likewise.
8617 * s/darwin.h (PTY_ITERATION): Likewise.
8618 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8619
8620 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8621 * process.c (allocate_pty): Don't declare stb unless it's needed.
8622
8623 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8624 (CONSTANTLIM): Remove; unused.
8625 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8626 Define only if needed.
8627
8628 * unexelf.c (unexec): Name an expression,
8629 to avoid gcc -Wbad-function-cast warning.
8630 Use a different way to cause a compilation error if anyone uses
8631 n rather than nn, a way that does not involve shadowing.
8632 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8633
8634 * deps.mk (unexalpha.o): Remove; unused.
8635
8636 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8637 * unexec.h: New file.
8638 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8639 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8640 Depend on unexec.h.
8641 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8642 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8643 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8644 Change as necessary to match prototype in unexec.h.
8645
8646 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8647 shadowing.
8648 (back_comment, skip_chars): Mark vars as initialized.
8649
8650 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8651 Rename locals to avoid shadowing.
8652
8653 * lread.c (read1): Rewrite so as not to use empty "else".
8654 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8655
8656 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8657
8658 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8659 warning when compiling print.c.
8660
8661 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8662 instead of using an uninitialized var.
8663 (font_sort_entities): Mark var as initialized.
8664
8665 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8666
8667 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8668 pointers to constants.
8669 (font_parse_fcname): Remove unused vars.
8670 (font_delete_unmatched): Now static.
8671 (font_get_spec): Remove; unused.
8672 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8673 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8674 Rename or move locals to avoid shadowing.
8675
8676 * fns.c (require_nesting_list, require_unwind): Now static.
8677 (Ffillarray): Rename locals to avoid shadowing.
8678
8679 * floatfns.c (domain_error2): Define only if needed.
8680 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8681
8682 * alloc.c (mark_backtrace): Move decl from here ...
8683 * lisp.h: ... to here, so that it can be checked.
8684
8685 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8686 (Fdefvar): Rewrite so as not to use empty "else".
8687 (lisp_indirect_variable): Name an expression,
8688 to avoid gcc -Wbad-function-cast warning.
8689 (Fdefvar): Rename locals to avoid shadowing.
8690
8691 * callint.c (quotify_arg, quotify_args): Now static.
8692 (Fcall_interactively): Rename locals to avoid shadowing.
8693 Use const pointer when appropriate.
8694
8695 * lisp.h (get_system_name, get_operating_system_release):
8696 Move decls here, to check interfaces.
8697 * process.c (get_operating_system_release): Move decl to lisp.h.
8698 * xrdb.c (get_system_name): Likewise.
8699 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8700 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8701 some of which prompt warnings from gcc -Wbad-function-cast.
8702 (Fformat_time_string, Fencode_time, Finsert_char):
8703 (Ftranslate_region_internal, Fformat):
8704 Rename or remove local vars to avoid shadowing.
8705 (Ftranslate_region_internal): Mark var as initialized.
8706
8707 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8708 avoid shadowing.
8709
8710 * lisp.h (eassert): Check that the argument compiles, even if
8711 ENABLE_CHECKING is not defined.
8712
8713 * data.c (Findirect_variable): Name an expression, to avoid
8714 gcc -Wbad-function-cast warning.
8715 (default_value, arithcompare, arith_driver, arith_error): Now static.
8716 (store_symval_forwarding): Rename local to avoid shadowing.
8717 (Fmake_variable_buffer_local, Fmake_local_variable):
8718 Mark variables as initialized.
8719 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8720
8721 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8722 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8723 Rename locals to avoid shadowing.
8724 (mark_stack): Move local variables into the #ifdef region where
8725 they're used.
8726 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8727 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8728 needed otherwise.
8729 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8730 (GC_STRING_CHARS): Remove; not used.
8731 (Fmemory_limit): Cast sbrk's returned value to char *.
8732
8733 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8734 avoids undefined behavior in theory.
8735
8736 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8737
8738 Use functions, not macros, for up- and down-casing (Bug#8254).
8739 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8740 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8741 to use the following functions instead of these macros.
8742 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8743 EMACS_INT, since callers assume the returned value fits in int.
8744 (upcase1): Likewise, for UPCASE_TABLE.
8745 (uppercasep, lowercasep, upcase): New static inline functions.
8746 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8747 the race-condition problem in the old DOWNCASE.
8748
8749 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8750 Rename locals to avoid shadowing.
8751 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8752 (regex_compile, re_search_2, re_match_2_internal):
8753 Remove unused local vars.
8754 (FREE_VAR): Rewrite so as not to use empty "else",
8755 which gcc can warn about.
8756 (regex_compile, re_match_2_internal): Mark locals as initialized.
8757 (RETALLOC_IF): Define only if needed.
8758 (WORDCHAR_P): Likewise. This one is never needed, but is used
8759 only in a comment talking about a compiler bug, so put inside
8760 the #if 0 of that comment.
8761 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8762 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8763 Remove; unused.
8764
8765 * search.c (boyer_moore): Rename locals to avoid shadowing.
8766 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8767 (PREV_CHAR_BOUNDARY): Likewise.
8768
8769 * search.c (simple_search): Remove unused var.
8770
8771 * dired.c (compile_pattern): Move decl from here ...
8772 * lisp.h: ... to here, so that it can be checked.
8773 (struct re_registers): New forward decl.
8774
8775 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8776
8777 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8778 All uses changed.
8779 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8780 Rename locals to avoid shadowing.
8781 (Fvertical_motion): Mark locals as initialized.
8782
8783 * casefiddle.c (casify_object, casify_region): Now static.
8784 (casify_region): Mark local as initialized.
8785
8786 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8787
8788 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8789 New macros, so that the caller can use some names other than
8790 gcpro1, gcpro2, etc.
8791 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8792 of the new macros.
8793 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8794 argument, for consistency with GCPRO2_VAR, etc: it is now the
8795 prefix of the variable, not the variable itself. All uses
8796 changed.
8797 * dired.c (directory_files_internal, file_name_completion):
8798 Rename locals to avoid shadowing.
8799
8800 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8801 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8802 dired.c's scmp function, had undefined behavior.
8803 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8804 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8805 * buffer.h: ... to here, because these macros use current_buffer,
8806 and the new implementation with inline functions needs to have
8807 current_buffer in scope now, rather than later when the macros
8808 are used.
8809 (downcase, upcase1): New static inline functions.
8810 (DOWNCASE, UPCASE1): Reimplement using these functions.
8811 This avoids undefined behavior in expressions like
8812 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8813 from race conditions in accessing the global variables
8814 case_temp1 and case_temp2.
8815 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8816 * lisp.h (case_temp1, case_temp2): Remove their decls.
8817 * character.h (ASCII_CHAR_P): Move from here ...
8818 * lisp.h: ... to here, so that the inline functions mentioned
8819 above can use them.
8820
8821 * dired.c (directory_files_internal_unwind): Now static.
8822
8823 * fileio.c (file_name_as_directory, directory_file_name):
8824 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8825 Now static.
8826 (file_name_as_directory): Use const pointers when appropriate.
8827 (Fexpand_file_name): Likewise. In particular, newdir might
8828 point at constant storage, so make it a const pointer.
8829 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8830 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8831 signedness issues.
8832 (Fset_file_times, Finsert_file_contents, auto_save_error):
8833 Rename locals to avoid shadowing.
8834
8835 * minibuf.c (choose_minibuf_frame_1): Now static.
8836 (Ftry_completion, Fall_completions): Rename or remove locals
8837 to avoid shadowing.
8838
8839 * marker.c (bytepos_to_charpos): Remove; unused.
8840
8841 * lisp.h (verify_bytepos, count_markers): New decls,
8842 so that gcc does not warn that these functions aren't declared.
8843
8844 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8845 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8846 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8847 (copy_text): Remove unused local var.
8848
8849 * filelock.c (within_one_second): Now static.
8850 (lock_file_1): Rename local to avoid shadowing.
8851
8852 * buffer.c (fix_overlays_before): Mark locals as initialized.
8853 (fix_start_end_in_overlays): Likewise. This function should be
8854 simplified by using pointers-to-pointers, but that's a different
8855 matter.
8856 (switch_to_buffer_1): Now static.
8857 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8858 (report_overlay_modification): Rename locals to avoid shadowing.
8859
8860 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8861 Fix pointer signedness issue.
8862 (sys_subshell): Mark local as volatile if checking for lint,
8863 to suppress a gcc -Wclobbered warning that does not seem to be right.
8864 (MAXPATHLEN): Define only if needed.
8865
8866 * process.c (serial_open, serial_configure): Move decls from here ...
8867 * systty.h: ... to here, so that they can be checked.
8868
8869 * fns.c (get_random, seed_random): Move extern decls from here ...
8870 * lisp.h: ... to here, so that they can be checked.
8871
8872 * sysdep.c (reset_io): Now static.
8873 (wait_for_termination_signal): Remove; unused.
8874
8875 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8876 (copy_keymap_item, append_key, push_text_char_description):
8877 Now static.
8878 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8879 (DENSE_TABLE_SIZE): Remove; unused.
8880 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8881 (describe_map_tree):
8882 Rename locals to avoid shadowing.
8883
8884 * keyboard.c: Declare functions static if they are not used elsewhere.
8885 (echo_char, echo_dash, cmd_error, top_level_2):
8886 (poll_for_input, handle_async_input): Now static.
8887 (read_char, kbd_buffer_get_event, make_lispy_position):
8888 (make_lispy_event, make_lispy_movement, apply_modifiers):
8889 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8890 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8891 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8892 (read_key_sequence, read_char): Mark locals as initialized.
8893 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8894
8895 * keyboard.h (make_ctrl_char): New decl.
8896 (mark_kboards): Move decl here ...
8897 * alloc.c (mark_kboards): ... from here.
8898
8899 * lisp.h (force_auto_save_soon): New decl.
8900
8901 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8902 (DEFINE_DUMMY_FUNCTION): New macro.
8903 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8904 Use it.
8905 (main): Add casts to avoid warnings
8906 if GCC considers string literals to be constants.
8907
8908 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8909
8910 * dbusbind.c: Pointer signedness fixes.
8911 (xd_signature, xd_append_arg, xd_initialize):
8912 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8913 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8914 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8915 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8916
8917 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8918 if GCC considers string literals to be constants.
8919 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8920
8921 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8922
8923 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8924 (print_preprocess, print_object): New macro to fix last change.
8925
8926 * print.c (print_preprocess): Don't forget font objects.
8927
8928 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8929
8930 * emacs.c (USAGE3): Doc fixes.
8931
8932 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8933
8934 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8935 structure.
8936
8937 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8938
8939 * lisp.h (VWindow_system, Qfile_name_history):
8940 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8941 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8942 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8943
8944 * w32select.c: Don't #include "keyboard.h".
8945 (run_protected): Add extern declaration for waiting_for_input.
8946
8947 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8948 * w32console.c (detect_input_pending, read_input_pending)
8949 (encode_terminal_code):
8950 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8951 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8952 (w32_system_caret_y, Qfile_name_history):
8953 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8954 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8955 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8956 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8957 * w32proc.c (Qlocal, report_file_error):
8958 * w32term.c (Vwindow_system, updating_frame):
8959 * w32uniscribe.c (initialized, uniscribe_font_driver):
8960 Remove unneeded extern declarations.
8961
8962 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8963
8964 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8965
8966 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8967
8968 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8969 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8970 These macros can no longer be used for assignment.
8971
8972 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8973 Assign struct members directly, instead of using BUF_BEGV etc.
8974 (record_buffer_markers, fetch_buffer_markers): New functions for
8975 recording and fetching special buffer markers.
8976 (set_buffer_internal_1, set_buffer_temp): Use them.
8977
8978 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8979
8980 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8981
8982 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8983 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8984
8985 * xdisp.c (hscroll_window_tree):
8986 (reconsider_clip_changes): Use PT instead of BUF_PT.
8987
8988 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8989
8990 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8991 $(EMACS_ROOT)/lib/intprops.h.
8992
8993 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8994
8995 Fix more problems found by GCC 4.5.2's static checks.
8996
8997 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8998 to unsigned char * to avoid compiler diagnostic.
8999 (xg_free_frame_widgets): Make it clear that a local variable is
9000 needed only if USE_GTK_TOOLTIP.
9001 (gdk_window_get_screen): Make it clear that this macro is needed
9002 only if USE_GTK_TOOLTIP.
9003 (int_gtk_range_get_value): New function, which avoids a diagnostic
9004 from gcc -Wbad-function-cast.
9005 (xg_set_toolkit_scroll_bar_thumb): Use it.
9006 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9007 diagnostic from gcc -Wbad-function-cast.
9008 (get_utf8_string, xg_get_file_with_chooser):
9009 Rename locals to avoid shadowing.
9010 (create_dialog): Move locals to avoid shadowing.
9011
9012 * xgselect.c (xg_select): Remove unused var.
9013
9014 * image.c (four_corners_best): Mark locals as initialized.
9015 (gif_load): Initialize transparent_p to zero (Bug#8238).
9016 Mark another local as initialized.
9017 (my_png_error, my_error_exit): Mark with NO_RETURN.
9018
9019 * image.c (clear_image_cache): Now static.
9020 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9021 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9022 (x_edge_detection): Remove unnecessary cast that
9023 gcc -Wbad-function-cast diagnoses.
9024 (gif_load): Fix pointer signedness.
9025 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9026 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9027
9028 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9029
9030 Improve quality of tests for time stamp overflow.
9031 For example, without this patch (encode-time 0 0 0 1 1
9032 1152921504606846976) returns the obviously-bogus value (-948597
9033 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9034 reports time overflow. See
9035 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9036 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9037 * editfns.c: Include limits.h and intprops.h.
9038 (TIME_T_MIN, TIME_T_MAX): New macros.
9039 (time_overflow): Move earlier, to before first use.
9040 (hi_time, lo_time): New functions, for an accurate test for
9041 out-of-range times.
9042 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9043 (Fget_internal_run_time): Don't assume time_t fits in int.
9044 (make_time): Use list2 instead of Fcons twice.
9045 (Fdecode_time): More accurate test for out-of-range times.
9046 (check_tm_member): New function.
9047 (Fencode_time): Use it, to test for out-of-range times.
9048 (lisp_time_argument): Don't rely on undefined left-shift and
9049 right-shift behavior when checking for time stamp overflow.
9050
9051 * editfns.c (time_overflow): New function, refactoring common code.
9052 (Fformat_time_string, Fdecode_time, Fencode_time):
9053 (Fcurrent_time_string): Use it.
9054
9055 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9056 * dired.c (make_time): Move to ...
9057 * editfns.c (make_time): ... here.
9058 * systime.h: Note the move.
9059
9060 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9061
9062 * fringe.c (update_window_fringes): Remove unused variables.
9063
9064 * unexmacosx.c (copy_data_segment): Also copy __got section.
9065 (Bug#8223)
9066
9067 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9068
9069 * termcap.c [MSDOS]: Include "msdos.h".
9070 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9071 Constify `char *' arguments and their references according to
9072 prototypes in tparam.h.
9073
9074 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9075
9076 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9077 Adapt all references accordingly.
9078
9079 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9080
9081 2011-03-11 Tom Tromey <tromey@redhat.com>
9082
9083 * buffer.c (syms_of_buffer): Remove obsolete comment.
9084
9085 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9086
9087 * termhooks.h (encode_terminal_code): Declare prototype.
9088
9089 * msdos.c (encode_terminal_code): Don't declare prototype.
9090
9091 * term.c (encode_terminal_code): Now external again, used by
9092 w32console.c and msdos.c.
9093
9094 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9095 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9096
9097 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9098
9099 Fix some minor problems found by GCC 4.5.2's static checks.
9100
9101 * fringe.c (update_window_fringes): Mark locals as initialized
9102 (Bug#8227).
9103 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9104
9105 * alloc.c (mark_fringe_data): Move decl from here ...
9106 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9107 to check its interface.
9108 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9109
9110 * fontset.c (free_realized_fontset): Now static.
9111 (Fset_fontset_font): Rename local to avoid shadowing.
9112 (fontset_font): Mark local as initialized.
9113 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9114
9115 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9116
9117 * xselect.c (x_disown_buffer_selections): Remove; not used.
9118 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9119 (x_own_selection, Fx_disown_selection_internal): Rename locals
9120 to avoid shadowing.
9121 (x_handle_dnd_message): Remove local to avoid shadowing.
9122
9123 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9124 so that the caller can use some name other than gcpro1.
9125 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9126 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9127 (Fx_backspace_delete_keys_p):
9128 Use them to avoid shadowing, and rename vars to avoid shadowing.
9129 (x_decode_color, x_set_name, x_window): Now static.
9130 (Fx_create_frame): Add braces to silence GCC warning.
9131 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9132 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9133 Remove unused locals.
9134 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9135 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9136 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9137 macros.
9138
9139 * xterm.h (x_mouse_leave): New decl.
9140
9141 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9142 Remove unused functions.
9143 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9144 (x_calc_absolute_position): Now static.
9145 (XTread_socket): Don't define label "out" unless it's used.
9146 Don't declare local "event" unless it's used.
9147 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9148 unless they are used.
9149 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9150 (x_fatal_error_signal): Remove; not used.
9151 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9152 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9153 (x_error_catcher, x_connection_closed, x_error_handler):
9154 (x_error_quitter, xembed_send_message, x_iconify_frame):
9155 (my_log_handler): Rename locals to avoid shadowing.
9156 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9157 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9158
9159 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9160 Rename or move locals to avoid shadowing.
9161 (tty_defined_color, merge_face_heights): Now static.
9162 (free_realized_faces_for_fontset): Remove; not used.
9163 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9164 does not deduce is never used uninitialized.
9165 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9166 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9167
9168 * terminal.c (store_terminal_param): Now static.
9169
9170 * xmenu.c (menu_highlight_callback): Now static.
9171 (set_frame_menubar): Remove unused local.
9172 (xmenu_show): Rename parameter to avoid shadowing.
9173 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9174 since they might point to immutable storage.
9175 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9176 since it's unused otherwise.
9177
9178 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9179 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9180 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9181 avoids a gcc -Wuninitialized diagnostic.
9182 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9183 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9184 does not deduce are never used uninitialized.
9185
9186 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9187
9188 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9189 * window.c (window_loop, size_window):
9190 (run_window_configuration_change_hook, enlarge_window): Likewise.
9191
9192 * window.c (display_buffer): Now static.
9193 (size_window): Mark variables that gcc -Wuninitialized
9194 does not deduce are never used uninitialized.
9195 * window.h (check_all_windows): New decl, to forestall
9196 gcc -Wmissing-prototypes diagnostic.
9197 * dispextern.h (bidi_dump_cached_states): Likewise.
9198
9199 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9200 shadowing.
9201 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9202 Include <limits.h>.
9203 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9204 and to avoid gcc -Wuninitialized warning.
9205 (load_charset_map): Mark variables that gcc -Wuninitialized
9206 does not deduce are never used uninitialized.
9207 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9208
9209 * coding.c (coding_set_source, coding_set_destination):
9210 Use "else { /* comment */ }" rather than "else /* comment */;"
9211 for clarity, and to avoid gcc -Wempty-body warning.
9212 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9213 a block, when the outer 'i' will do.
9214 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9215 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9216 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9217 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9218 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9219 Rename locals to avoid shadowing.
9220 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9221 * coding.c (emacs_mule_char, encode_invocation_designation):
9222 Now static, since they're not used elsewhere.
9223 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9224 (decode_coding_object, encode_coding_object, detect_coding_system):
9225 (decode_coding_emacs_mule): Mark variables that gcc
9226 -Wuninitialized does not deduce are never used uninitialized.
9227 (detect_coding_iso_2022): Initialize a local variable that might
9228 be used uninitialized. Leave a FIXME because it's not clear that
9229 this initialization is needed. (Bug#8211)
9230 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9231 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9232 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9233 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9234 Remove unused macros.
9235
9236 * category.c (hash_get_category_set): Remove unused local var.
9237 (copy_category_table): Now static, since it's not used elsewhere.
9238 * character.c (string_count_byte8): Likewise.
9239
9240 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9241 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9242
9243 * chartab.c (copy_sub_char_table): Now static, since it's not used
9244 elsewhere.
9245 (sub_char_table_ref_and_range, char_table_ref_and_range):
9246 Rename locals to avoid shadowing.
9247 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9248
9249 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9250 (BIDI_BOB): Remove unused macro.
9251
9252 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9253 deduce are never used uninitialized.
9254 * term.c (encode_terminal_code): Likewise.
9255
9256 * term.c (encode_terminal_code): Now static. Remove unused local.
9257
9258 * tparam.h: New file.
9259 * term.c, tparam.h: Include it.
9260 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9261 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9262 Move these decls to tparam.h, and make them agree with what
9263 is actually in tparam.c. The previous trick of using incompatible
9264 decls in different modules does not conform to the C standard.
9265 All callers of tparam changed to use tparam's actual API.
9266 * tparam.c (tparam1, tparam, tgoto):
9267 Use const pointers where appropriate.
9268
9269 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9270 * cm.h (struct cm): Likewise.
9271 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9272 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9273 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9274 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9275 (turn_on_face, init_tty): Likewise.
9276 * termchar.h (struct tty_display_info): Likewise.
9277
9278 * term.c (term_mouse_position): Rename local to avoid shadowing.
9279
9280 * alloc.c (mark_ttys): Move decl from here ...
9281 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9282
9283 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9284
9285 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9286
9287 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9288
9289 * search.c (compile_pattern_1): Remove argument regp, unused since
9290 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9291 (compile_pattern): Don't pass it.
9292
9293 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9294
9295 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9296 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9297 for ! HAVE_GTK3.
9298 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9299
9300 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9301
9302 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9303 gdk_window_get_screen, gdk_window_get_geometry,
9304 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9305 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9306 (xg_get_pixbuf_from_pixmap): New function.
9307 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9308 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9309 Call xg_get_pixbuf_from_pixmap instead of
9310 gdk_pixbuf_get_from_drawable.
9311 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9312 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9313 (xg_check_special_colors): Use GtkStyleContext and its functions
9314 for HAVE_GTK3.
9315 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9316 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9317 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9318 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9319 Call gtk_widget_get_preferred_size.
9320 (xg_frame_resized): gdk_window_get_geometry only takes 5
9321 parameters.
9322 (xg_win_to_widget, xg_event_is_for_menubar):
9323 Call gdk_x11_window_lookup_for_display.
9324 (xg_set_widget_bg): New function.
9325 (delete_cb): New function.
9326 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9327 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9328 (xg_set_background_color): Call xg_set_widget_bg.
9329 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9330 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9331 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9332 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9333 if ! HAVE_GTK3.
9334 (update_frame_tool_bar): Call gtk_widget_hide.
9335 (xg_initialize): Use GDK_KEY_g.
9336
9337 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9338 if ! HAVE_GTK3
9339 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9340
9341 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9342 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9343 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9344
9345 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9346
9347 * w32xfns.c (select_palette): Check success of RealizePalette against
9348 GDI_ERROR, not zero.
9349
9350 See ChangeLog.11 for earlier changes.
9351
9352 ;; Local Variables:
9353 ;; coding: utf-8
9354 ;; End:
9355
9356 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9357
9358 This file is part of GNU Emacs.
9359
9360 GNU Emacs is free software: you can redistribute it and/or modify
9361 it under the terms of the GNU General Public License as published by
9362 the Free Software Foundation, either version 3 of the License, or
9363 (at your option) any later version.
9364
9365 GNU Emacs is distributed in the hope that it will be useful,
9366 but WITHOUT ANY WARRANTY; without even the implied warranty of
9367 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9368 GNU General Public License for more details.
9369
9370 You should have received a copy of the GNU General Public License
9371 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.