* src/buffer.c (compare_overlays): Avoid qsort's instability.
[bpt/emacs.git] / src / ChangeLog
1 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4
5 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6
7 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
8 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
9 zero (Bug#10954).
10
11 2012-03-03 Glenn Morris <rgm@gnu.org>
12
13 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
14
15 2012-03-02 Eli Zaretskii <eliz@gnu.org>
16
17 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
18 position past the first glyph_row that ends at ZV. (Bug#10902)
19 (redisplay_window, next_element_from_string): Fix typos in
20 comments.
21 (redisplay_window): Pass to move_it_vertically the margin in
22 pixels, not in screen lines.
23
24 2012-03-02 Glenn Morris <rgm@gnu.org>
25
26 * buffer.c (buffer-list-update-hook): Doc fix.
27
28 2012-02-29 Eli Zaretskii <eliz@gnu.org>
29
30 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
31 push_it before setting up the iterator for the first overlay
32 string, even if we have an empty string loaded.
33 (next_overlay_string): If there's an empty string on the iterator
34 stack, pop the stack. (Bug#10903)
35
36 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
37
38 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
39 Suggested by Stefan Monnier in
40 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
41 * alloc.c (widen_to_Lisp_Object): New static function.
42 (mark_memory): Also mark Lisp_Objects by fetching pointer words
43 and widening them to Lisp_Objects. This would work even if
44 USE_LSB_TAG is defined and wide integers are used, which might
45 happen in a future version of Emacs.
46
47 2012-02-25 Chong Yidong <cyd@gnu.org>
48
49 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
50 Doc fix.
51
52 * xselect.c (Fx_selection_exists_p): Doc fix.
53 (x_clipboard_manager_save_all): Print an informative message
54 before saving to clipboard manager.
55
56 2012-02-24 Chong Yidong <cyd@gnu.org>
57
58 * keyboard.c (process_special_events): Handle all X selection
59 requests in kbd_buffer, not just the next one (Bug#8869).
60
61 2012-02-23 Chong Yidong <cyd@gnu.org>
62
63 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
64 call when setting menu-bar-lines and tool-bar-lines parameters.
65 (unwind_create_frame_1): New helper function.
66
67 * window.c (inhibit_window_configuration_change_hook): New var.
68 (run_window_configuration_change_hook): Obey it.
69 (syms_of_window): Initialize it.
70
71 2012-02-22 Chong Yidong <cyd@gnu.org>
72
73 * xterm.c (x_draw_image_relief): Add missing type check for
74 Vtool_bar_button_margin (Bug#10743).
75
76 2012-02-21 Chong Yidong <cyd@gnu.org>
77
78 * fileio.c (Vfile_name_handler_alist): Doc fix.
79
80 * buffer.c (Fget_file_buffer): Protect against invalid file
81 handler return value.
82
83 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
84
85 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
86 when computing $valmask.
87
88 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
89 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
90 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
91 It's useless in that case, and it can cause problems on hosts
92 that allocate halves of EMACS_INT values separately.
93 Reported by Dan Horák. Diagnosed by Andreas Schwab in
94 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
95 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
96 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
97 it avoids undefined behavior on hosts where shifting right by more
98 than the word width has undefined behavior.
99
100 2012-02-19 Chong Yidong <cyd@gnu.org>
101
102 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
103 (Funhandled_file_name_directory, Ffile_name_as_directory)
104 (Fdirectory_file_name, Fexpand_file_name)
105 (Fsubstitute_in_file_name): Protect against invalid file handler
106 return values (Bug#10845).
107
108 2012-02-18 Eli Zaretskii <eliz@gnu.org>
109
110 * .gdbinit (pitx): Fix incorrect references to fields of the
111 iterator stack.
112
113 2012-02-17 Chong Yidong <cyd@gnu.org>
114
115 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
116
117 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
118
119 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
120 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
121
122 2012-02-15 Chong Yidong <cyd@gnu.org>
123
124 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
125 marked as special. Also, starting docstrings with * is obsolete.
126
127 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
128
129 * gnutls.c (emacs_gnutls_write): Fix last change.
130
131 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
132
133 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
134 send_process.
135
136 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
137
138 * keymap.c (Fsingle_key_description): Handle char ranges.
139
140 2012-02-12 Chong Yidong <cyd@gnu.org>
141
142 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
143 as that creates a dangerous corner case.
144
145 * window.c (Fdelete_window_internal): Invalidate the mouse
146 highlight (Bug#9904).
147
148 2012-02-12 Glenn Morris <rgm@gnu.org>
149
150 * xselect.c (Fx_own_selection_internal)
151 (Fx_get_selection_internal, Fx_disown_selection_internal)
152 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
153 * nsselect.m (Fx_own_selection_internal)
154 (Fx_disown_selection_internal, Fx_selection_exists_p)
155 (Fx_selection_owner_p, Fx_get_selection_internal):
156 Sync docs and argument specs with the xselect.c versions.
157
158 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
159
160 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
161
162 2012-02-11 Eli Zaretskii <eliz@gnu.org>
163
164 * w32select.c (Fx_selection_exists_p): Sync doc string and
165 argument list with xselect.c. (Bug#10783)
166
167 * w16select.c (Fx_selection_exists_p): Sync doc string and
168 argument list with xselect.c. (Bug#10783)
169
170 2012-02-10 Glenn Morris <rgm@gnu.org>
171
172 * fns.c (Fsecure_hash): Doc fix.
173
174 2012-02-09 Kenichi Handa <handa@m17n.org>
175
176 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
177
178 2012-02-07 Chong Yidong <cyd@gnu.org>
179
180 * buffer.c (Fbuffer_local_variables)
181 (buffer_lisp_local_variables): Handle unbound vars correctly;
182 don't let Qunbound leak into Lisp.
183
184 2012-02-07 Glenn Morris <rgm@gnu.org>
185
186 * image.c (Fimagemagick_types): Doc fix.
187
188 * image.c (imagemagick-render-type): Change it from a lisp object
189 to an integer. Move the doc here from the lisp manual.
190 Treat all values not equal to 0 the same.
191
192 2012-02-06 Chong Yidong <cyd@gnu.org>
193
194 * doc.c (store_function_docstring): Avoid applying docstring of
195 alias to base function (Bug#2603).
196
197 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
198
199 * .gdbinit (pp1, pv1): Remove redundant defines.
200 (pr): Use pp.
201
202 2012-02-04 Chong Yidong <cyd@gnu.org>
203
204 * nsterm.m: Declare a global (Bug#10694).
205
206 2012-02-04 Eli Zaretskii <eliz@gnu.org>
207
208 * w32.c (get_emacs_configuration_options):
209 Include --enable-checking, if specified, in the return value.
210
211 2012-02-04 Martin Rudalics <rudalics@gmx.at>
212
213 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
214 after rounding frame sizes. (Bug#9723)
215
216 2012-02-04 Eli Zaretskii <eliz@gnu.org>
217
218 * keyboard.c (adjust_point_for_property): Don't position point
219 before BEGV. (Bug#10696)
220
221 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
222
223 Handle overflow when computing char display width (Bug#9496).
224 * character.c (char_width): Return EMACS_INT, not int.
225 (char_width, c_string_width): Check for overflow when
226 computing the width; this is possible now that individual
227 characters can have unbounded width. Problem introduced
228 by merge from Emacs 23 on 2012-01-19.
229
230 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
231
232 * dbusbind.c (Fdbus_register_method): Mention the return value
233 :ignore in the docstring.
234
235 2012-02-02 Glenn Morris <rgm@gnu.org>
236
237 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
238
239 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
240 Unconditionally set to t. (Bug#10673)
241 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
242 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
243 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
244
245 2012-02-02 Kenichi Handa <handa@m17n.org>
246
247 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
248 0, do not call append_composite_glyph.
249
250 2012-02-02 Kenichi Handa <handa@m17n.org>
251
252 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
253 NULL (Bug#6988).
254 (x_produce_glyphs): If the component of a composition is a null
255 string, set it->pixel_width to 1 to avoid zero-width glyph.
256
257 2012-02-01 Eli Zaretskii <eliz@gnu.org>
258
259 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
260 first 2 arguments are identical. This makes inserting large
261 output from a subprocess an order of magnitude faster on
262 MS-Windows, where all sbrk'ed memory is always contiguous.
263
264 2012-01-31 Glenn Morris <rgm@gnu.org>
265
266 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
267 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
268 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
269
270 2012-01-29 Glenn Morris <rgm@gnu.org>
271
272 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
273
274 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
275
276 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
277
278 2012-01-28 Chong Yidong <cyd@gnu.org>
279
280 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
281
282 2012-01-26 Chong Yidong <cyd@gnu.org>
283
284 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
285
286 * search.c (Fsearch_forward, Fsearch_backward): Document negative
287 repeat counts (Bug#10507).
288
289 2012-01-26 Glenn Morris <rgm@gnu.org>
290
291 * lread.c (syms_of_lread): Doc fix.
292
293 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
294
295 * coding.c (encode_designation_at_bol): Change return value to
296 EMACS_INT.
297
298 2012-01-25 Chong Yidong <cyd@gnu.org>
299
300 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
301
302 2012-01-21 Chong Yidong <cyd@gnu.org>
303
304 * floatfns.c (Fcopysign): Make the second argument non-optional,
305 since nil is not allowed anyway.
306
307 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
308
309 * process.c (read_process_output): Use p instead of XPROCESS (proc).
310 (send_process): Likewise.
311
312 2012-01-19 Martin Rudalics <rudalics@gmx.at>
313
314 * window.c (save_window_save, Fcurrent_window_configuration)
315 (Vwindow_persistent_parameters): Do not use Qstate.
316 Rewrite doc-strings.
317
318 2012-01-19 Kenichi Handa <handa@m17n.org>
319
320 * character.c (char_width): New function.
321 (Fchar_width, c_string_width, lisp_string_width):
322 Use char_width (Bug#9496).
323
324 2012-01-16 Martin Rudalics <rudalics@gmx.at>
325
326 * window.c (Vwindow_persistent_parameters): New variable.
327 (Fset_window_configuration, save_window_save): Handle persistent
328 window parameters.
329
330 2012-01-14 Eli Zaretskii <eliz@gnu.org>
331
332 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
333 thrashing the stack of the thread. (Bug#9087)
334
335 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
336
337 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
338
339 2012-01-11 Eli Zaretskii <eliz@gnu.org>
340
341 * xdisp.c (rows_from_pos_range): Handle the case where the
342 highlight ends on a newline. (Bug#10464)
343 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
344 he end column for display of highlight that ends on a newline
345 before a R2L line.
346
347 2012-01-11 Glenn Morris <rgm@gnu.org>
348
349 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
350 from load-path also when installation-directory is nil. (Bug#10208)
351
352 2012-01-10 Glenn Morris <rgm@gnu.org>
353
354 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
355
356 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
357 Update template values to be closer to their typical values these days.
358
359 2012-01-09 Eli Zaretskii <eliz@gnu.org>
360
361 * xdisp.c (rows_from_pos_range): Accept additional argument
362 DISP_STRING, and accept any glyph in a row whose object is that
363 string as eligible for mouse highlight. Fixes mouse highlight of
364 display strings from overlays. (Bug#10464)
365
366 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
367
368 emacs: fix an auto-save permissions race condition (Bug#10400)
369 * fileio.c (auto_saving_dir_umask): New static var.
370 (Fmake_directory_internal): Use it.
371 (do_auto_save_make_dir): Set it, instead of invoking chmod after
372 creating the directory. The old code temporarily assigns
373 too-generous permissions to the directory.
374 (do_auto_save_eh): Clear it.
375 (Fdo_auto_save): Catch all errors, not just file errors, so
376 that the var is always cleared.
377
378 2012-01-07 Eli Zaretskii <eliz@gnu.org>
379
380 * search.c (scan_buffer): Pass character positions to
381 know_region_cache, not byte positions. (Bug#6540)
382
383 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
384
385 * w32.c (sys_rename): Report EXDEV when rename of a directory
386 fails because the target is on another logical disk. (Bug#10284)
387
388 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
389
390 * xterm.c (x_embed_request_focus): New function.
391
392 * xterm.h: Add prototype.
393
394 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
395
396 2012-01-05 Glenn Morris <rgm@gnu.org>
397
398 * emacs.c (emacs_copyright): Update short copyright year to 2012.
399
400 2012-01-01 Eli Zaretskii <eliz@gnu.org>
401
402 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
403 Load gnutls_transport_set_lowat only if GnuTLS version is below
404 2.11.1.
405 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
406 GnuTLS versions below 2.11.1.
407
408 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
409
410 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
411 to the doc string advising against its use for altering the way
412 windows are scrolled.
413
414 2011-12-28 Kenichi Handa <handa@m17n.org>
415
416 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
417 coding-system ASCII compatible only when it does not produce BOM
418 on encoding (Bug#10383).
419
420 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
421
422 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
423 can scroll.
424 (create_and_show_popup_menu): Always use menu_position_func for
425 Gtk3 (Bug#10361).
426
427 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
428
429 * callint.c (Fcall_interactively): Don't truncate prompt string.
430
431 2011-12-23 Eli Zaretskii <eliz@gnu.org>
432
433 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
434 property that ends at ZV, so that the bidi iteration could be
435 resumed from there (after widening). (Bug#10360)
436
437 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
438
439 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
440
441 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
442
443 * nsterm.m (x_free_frame_resources):
444 Release f->output_data.ns->miniimage.
445 (ns_index_color): Fix indentation. Do not retain
446 color_table->colors[i].
447
448 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
449 before returning.
450
451 * nsfns.m (x_set_background_color): Assign return value from
452 ns_index_color to face-background instead of NSColor*.
453 (ns_implicitly_set_icon_type): Fix indentation.
454 Change assignment in for loop to comparison.
455
456 * emacs.c (ns_pool): New variable.
457 (main): Assign ns_pool.
458 (Fkill_emacs): Call ns_release_autorelease_pool.
459
460 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
461 autorelease fdesc, release fdAttrs and tdict.
462 (ns_get_covering_families): Release charset.
463 (ns_findfonts): Release NSFontDescriptor created with new.
464 (ns_uni_to_glyphs): Fix indentation.
465 (setString): Release attrStr before assigning new value.
466
467 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
468
469 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
470 and NS_IMPL_COCOA.
471 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
472 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
473
474 2011-12-18 David Reitter <reitter@cmu.edu>
475
476 * nsterm.m (ns_term_init): Subscribe for notifications
477 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
478 to method trackingNotification in EmacsMenu.
479
480 * nsmenu.m (trackingMenu): New variable.
481 (trackingNotification): New method (from Aquamacs).
482 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
483 from Aquamacs (Bug#7030).
484
485 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
486
487 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
488 (symbol_to_nsstring): Fix indentation.
489 (ns_symbol_to_pb): New function.
490 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
491 (Fns_rotate_cut_buffers_internal): Remove.
492 (Fns_store_selection_internal): Rename from
493 Fns_store_cut_buffer_internal.
494 (ns_get_foreign_selection, Fx_own_selection_internal)
495 (Fx_disown_selection_internal, Fx_selection_exists_p)
496 (Fns_get_selection_internal, Fns_store_selection_internal):
497 Use ns_symbol_to_pb and check if return value is nil.
498 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
499 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
500 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
501 renamed to Sns_store_selection_internal.
502 (ns_handle_selection_request): Move code to Fx_own_selection_internal
503 and remove this function.
504 (ns_handle_selection_clear): Remove, never used.
505 (Fx_own_selection_internal): Move code from ns_handle_selection_request
506 here.
507
508 2011-12-17 Ken Brown <kbrown@cornell.edu>
509
510 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
511 GID is unknown (Bug#10257).
512
513 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
514
515 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
516 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
517 which caused a build failure on GNU/Linux IA-64. This problem was
518 introduced by my 2011-10-07 patch.
519
520 2011-12-15 Juri Linkov <juri@jurta.org>
521
522 * image.c (imagemagick_error): New function. (Bug#10112)
523 (imagemagick_load_image): Comment out `MagickSetResolution' call.
524 Use `imagemagick_error' where ImageMagick functions return
525 `MagickFalse'.
526 (Fimagemagick_types): Add `Fnreverse' to return the list in the
527 proper order.
528
529 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
530
531 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
532 fill background (Bug#8992).
533
534 2011-12-13 Martin Rudalics <rudalics@gmx.at>
535
536 * window.c (Vwindow_combination_resize)
537 (Vwindow_combination_limit): Use t instead of non-nil in
538 doc-strings.
539 (Vrecenter_redisplay): Add first sentence of doc-string on
540 separate line.
541 (Frecenter): Fix doc-string typo.
542
543 2011-12-11 Kenichi Handa <handa@m17n.org>
544
545 * coding.c (Funencodable_char_position): Pay attention to the
546 buffer text relocation (Bug#9389).
547
548 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
549
550 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
551 gtk_init (Bug#10100).
552
553 2011-12-10 Eli Zaretskii <eliz@gnu.org>
554
555 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
556 IT->string is nil. (Bug#10263)
557
558 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
559
560 * nsterm.h (x_free_frame_resources): Declare.
561
562 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
563 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
564
565 * nsterm.h (ns_get_defaults_value): Declare.
566
567 * nsterm.m (ns_default): Call ns_get_defaults_value.
568
569 2011-12-09 Eli Zaretskii <eliz@gnu.org>
570
571 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
572 (Bug#10170)
573
574 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
575
576 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
577 that where the value of an _OBJC_* symbol points to is in the .bss
578 section (Bug#10240).
579
580 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
581
582 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
583 after the loop to call ccl_driver at least once (Bug#8619).
584
585 2011-12-08 Kenichi Handa <handa@m17n.org>
586
587 * ftfont.c (get_adstyle_property): Fix previous change
588 (Bug#10233).
589
590 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
591
592 * w32.c (init_environment): If no_site_lisp, remove site-lisp
593 dirs from the default value of EMACSLOADPATH (bug#10208).
594
595 2011-12-07 Glenn Morris <rgm@gnu.org>
596
597 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
598 installation and source directories as well. (Bug#10208)
599
600 2011-12-06 Chong Yidong <cyd@gnu.org>
601
602 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
603
604 2011-12-06 Glenn Morris <rgm@gnu.org>
605
606 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
607 as an error, not just -1. (Bug#10217)
608
609 2011-12-05 Chong Yidong <cyd@gnu.org>
610
611 * keyboard.c (process_special_events): New function.
612 (swallow_events, Finput_pending_p): Use it (Bug#10195).
613
614 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
615
616 * coding.c (encode_designation_at_bol): Don't use uninitialized
617 local variable (Bug#9318).
618
619 2011-12-05 Kenichi Handa <handa@m17n.org>
620
621 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
622 return Qnil (Bug#8046, Bug#10193).
623
624 2011-12-05 Kenichi Handa <handa@m17n.org>
625
626 * coding.c (encode_designation_at_bol): New args charbuf_end and
627 dst. Return the number of produced bytes. Callers changed.
628 (coding_set_source): Return how many bytes coding->source was
629 relocated.
630 (coding_set_destination): Return how many bytes
631 coding->destination was relocated.
632 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
633 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
634
635 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
636
637 * coding.c (CODING_CHAR_CHARSET_P): New macro.
638 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
639 macro (Bug#9318).
640
641 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
642
643 The following changes are to fix Bug#9318.
644
645 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
646 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
647 (encode_coding_iso_2022, encode_coding_sjis)
648 (encode_coding_big5, encode_coding_charset): Use the above macros.
649
650 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
651
652 * lisp.h (process_quit_flag): Fix external declaration.
653
654 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
655
656 Don't macro-inline non-performance-critical code.
657 * eval.c (process_quit_flag): New function.
658 * lisp.h (QUIT): Use it.
659
660 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
661
662 * nsfns.m (get_geometry_from_preferences): New function.
663 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
664
665 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
666
667 * emacs.c (Qkill_emacs): Define.
668 (syms_of_emacs): Initialize it.
669 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
670 Qquit_flag to `kill-emacs' instead.
671 (quit_throw_to_read_char): Add parameter `from_signal'.
672 All callers changed. Call Fkill_emacs if requested and safe.
673 * lisp.h (QUIT): Call Fkill_emacs if requested.
674
675 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
676
677 * widget.c (update_wm_hints): Return if wmshell is null.
678 (widget_update_wm_size_hints): New function.
679
680 * widget.h (widget_update_wm_size_hints): Declare.
681
682 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
683 widget_update_wm_size_hints (Bug#10104).
684
685 2011-12-03 Eli Zaretskii <eliz@gnu.org>
686
687 * xdisp.c (handle_invisible_prop): If the invisible text ends just
688 before a newline, prepare the bidi iterator for consuming the
689 newline, and keep the current paragraph direction. (Bug#10183)
690 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
691
692 2011-12-02 Juri Linkov <juri@jurta.org>
693
694 * search.c (Fword_search_regexp): New Lisp function created from
695 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
696 (Fword_search_backward, Fword_search_forward)
697 (Fword_search_backward_lax, Fword_search_forward_lax):
698 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
699 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
700
701 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
702
703 * fileio.c (Finsert_file_contents): Move after-change-function call
704 to before the "handled:" label, since all "goto handled" appear in
705 cases where the *-change-functions have already been properly called
706 (bug#10117).
707
708 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
709
710 * keyboard.c (interrupt_signal): Don't call kill-emacs when
711 waiting for input. (Bug#10169)
712
713 2011-11-30 Eli Zaretskii <eliz@gnu.org>
714
715 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
716 verifies glyph row's hash code--we have just reallocated the
717 glyphs, so their contents can be complete garbage. (Bug#10164)
718
719 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
720
721 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
722
723 2011-11-30 Eli Zaretskii <eliz@gnu.org>
724
725 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
726 attributes are tested _before_ calling verify_row_hash, to protect
727 against GCC re-ordering of the tests. (Bug#10164)
728
729 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
730
731 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
732
733 * xterm.c (handle_one_xevent): Only set async_visible and friends
734 if net_wm_state_hidden_seen is non-zero (Bug#10002)
735 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
736 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
737
738 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
739
740 Remove GCPRO-related macros that exist only to avoid shadowing locals.
741 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
742 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
743 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
744 All uses changed to use GCPRO1 etc.
745 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
746 Revert to old implementation (i.e., before 2011-03-11).
747
748 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
749
750 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
751 of scroll runs so as to avoid assigning disabled bogus rows and
752 unnecessary graphics copy operations.
753
754 2011-11-27 Eli Zaretskii <eliz@gnu.org>
755
756 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
757 (snprintf) [_MSC_VER]: Redirect to _snprintf.
758 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
759 (malloc, free, realloc, calloc): Redirect to e_* only when
760 compiling Emacs.
761
762 * lisp.h (GCTYPEBITS): Move before first use.
763 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
764 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
765 this macro definition.
766
767 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
768 _MSC_VER.
769
770 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
771
772 * gtkutil.c (xg_create_frame_widgets):
773 Call gtk_window_set_has_resize_grip (FALSE) if that function is
774 present with Gtk+ 2.0.
775
776 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
777
778 * fileio.c (Finsert_file_contents): Undo previous change; see
779 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
780
781 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
782
783 Rename locals to avoid shadowing.
784 * fileio.c (Finsert_file_contents):
785 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
786 * process.c (wait_reading_process_output):
787 Rename inner 'proc' to 'p' to avoid shadowing.
788 Indent for consistency with usual Emacs style.
789
790 2011-11-25 Eli Zaretskii <eliz@gnu.org>
791
792 * xdisp.c (redisplay_window): If cursor row is not fully visible
793 after recentering, and scroll-conservatively is set to a large
794 number, scroll window by a few more lines to make the cursor fully
795 visible and out of scroll-margin. (Bug#10105)
796 (start_display): Don't move to the next line if the display should
797 start at a newline that is part of a display vector or an overlay
798 string. (Bug#10119)
799
800 2011-11-24 Juri Linkov <juri@jurta.org>
801
802 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
803 after the `MagickPingImage' call. (Bug#10112)
804
805 2011-11-23 Chong Yidong <cyd@gnu.org>
806
807 * window.c (Fcoordinates_in_window_p): Accept only live windows.
808
809 2011-11-23 Martin Rudalics <rudalics@gmx.at>
810
811 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
812 making another buffer current. (Bug#10114)
813
814 2011-11-23 Glenn Morris <rgm@gnu.org>
815
816 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
817
818 2011-11-23 Chong Yidong <cyd@gnu.org>
819
820 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
821 using it (Bug#5984).
822
823 2011-11-22 Eli Zaretskii <eliz@gnu.org>
824
825 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
826 and header-lines, as they don't have one computed for them.
827 (Bug#10098)
828
829 * .gdbinit (prow): Make displayed values more self-explaining.
830 Add row's hash code.
831
832 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
833
834 * process.c (wait_reading_process_output): Fix asynchrounous
835 GnuTLS socket handling on some versions of the GnuTLS library.
836 (wait_reading_process_output): Add comment and URL.
837
838 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
839
840 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
841
842 2011-11-21 Chong Yidong <cyd@gnu.org>
843
844 * window.c (Fnext_window, Fprevious_window): Doc fix.
845
846 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
847
848 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
849
850 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
851
852 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
853
854 2011-11-20 Martin Rudalics <rudalics@gmx.at>
855
856 * window.c (Fset_window_combination_limit): Rename argument
857 STATUS to LIMIT.
858 (Vwindow_combination_limit): Remove "status" from doc-string.
859
860 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
861
862 * m/ibms390.h: Remove.
863 * m/ibms390x.h: Don't include "ibms390.h".
864
865 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
866
867 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
868 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
869
870 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
871
872 * casetab.c (Fset_case_table):
873 * charset.c (Fcharset_after): Fix typos.
874
875 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
876
877 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
878 Otherwise, valgrind does not work on some platforms.
879 Problem reported by Andreas Schwab in
880 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
881 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
882 is set, removing the need for VIRT_ADDRESS_VARIES.
883 (PURE_P): Use a more-efficient implementation that needs just one
884 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
885 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
886 to 4 (xorl, subq, cmpq, setbe).
887 * alloc.c (pure): Always extern now, since that's the
888 VIRT_ADDR_VARIES behavior.
889 (PURE_POINTER_P): Use a single comparison, not two, for
890 consistency with the new puresize.h.
891 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
892 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
893 Remove VIRT_ADDR_VARIES no longer needed.
894
895 2011-11-19 Eli Zaretskii <eliz@gnu.org>
896
897 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
898 (erase_phys_cursor, update_window_cursor, show_mouse_face)
899 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
900 behave as if the cursor position were at the window margin.
901
902 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
903 and the cursor position is out of bounds, behave as if the cursor
904 position were at the window margin. (Bug#10075)
905
906 2011-11-18 Chong Yidong <cyd@gnu.org>
907
908 * window.c (Fwindow_combination_limit): Make first argument
909 non-optional, since it is meaningless for live windows like the
910 selected window.
911
912 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
913
914 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
915
916 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
917
918 * intervals.c: Fix grafting over the whole buffer (bug#10071).
919 (graft_intervals_into_buffer): Simplify.
920
921 2011-11-18 Eli Zaretskii <eliz@gnu.org>
922
923 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
924 hash values of the two rows.
925 (copy_row_except_pointers): Preserve the used[] arrays and the
926 hash values of the two rows. (Bug#10035)
927 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
928
929 * xdisp.c (row_hash): New function, body extracted from
930 compute_line_metrics.
931 (compute_line_metrics): Call row_hash, instead of computing the
932 hash code inline.
933
934 * dispnew.c (verify_row_hash): Call row_hash for computing the
935 hash code of a row, instead of duplicating code from xdisp.c.
936
937 * dispextern.h (row_hash): Add prototype.
938
939 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
940
941 * frame.c (delete_frame): Don't delete the terminal when the last
942 X frame is closed if emacs is built with GTK toolkit.
943
944 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
945
946 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
947
948 2011-11-17 Martin Rudalics <rudalics@gmx.at>
949
950 * window.c (Vwindow_splits): Rename to
951 Vwindow_combination_resize. Suggested by Juri Linkov.
952 (Fsplit_window_internal): Use Vwindow_combination_resize instead
953 of Vwindow_splits.
954
955 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
956
957 * nsfns.m (Fns_font_name):
958 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
959
960 2011-11-16 Martin Rudalics <rudalics@gmx.at>
961
962 * window.h (window): Rename slot "nest" to "combination_limit".
963 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
964 (Fset_window_nest): Rename to Fset_window_combination_limit.
965 (Vwindow_nest): Rename to Vwindow_combination_limit.
966 (recombine_windows, make_parent_window, make_window)
967 (Fsplit_window_internal, saved_window)
968 (Fset_window_configuration, save_window_save): Rename all
969 occurrences of window_nest to window_combination_limit.
970
971 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
972
973 * image.c (imagemagick_load_image): Fix typo.
974
975 2011-11-14 Eli Zaretskii <eliz@gnu.org>
976
977 * xdisp.c (display_line): Move the call to
978 highlight_trailing_whitespace before the call to
979 compute_line_metrics, since the latter needs to see the final
980 faces of all the glyphs to compute ROW's hash value.
981 Fixes assertion violations in row_equal_p. (Bug#10035)
982
983 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
984
985 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
986 just return (bug#10044).
987
988 2011-11-12 Eli Zaretskii <eliz@gnu.org>
989
990 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
991 with user-defined heap size. Bump the default size of the temacs
992 heap to 27MB, to avoid memory warning when running temacs.
993 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
994
995 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
996 current_matrix and desired_matrix. (Bug#9990)
997 (verify_row_hash) [XASSERTS]: New function.
998 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
999 that the hash value of glyph rows is correct.
1000
1001 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1002
1003 * window.h (window): Remove splits slot.
1004 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1005 (Fdelete_other_windows_internal, make_parent_window)
1006 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1007 (Fset_window_configuration, save_window_save): Don't deal with
1008 split status of windows.
1009 (saved_window): Remove splits slot.
1010 (Vwindow_splits): Rewrite doc-string.
1011
1012 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1013
1014 * xfns.c (unwind_create_frame):
1015 * nsfns.m (unwind_create_frame):
1016 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1017 Vframe_list (Bug#9999).
1018
1019 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1020
1021 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1022
1023 2011-11-11 Kenichi Handa <handa@m17n.org>
1024
1025 * callproc.c (Fcall_process): Set the member dst_multibyte of
1026 process_coding.
1027
1028 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1029
1030 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1031 avoid a crash (bug#9496).
1032
1033 2011-11-09 Chong Yidong <cyd@gnu.org>
1034
1035 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1036 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1037
1038 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1039
1040 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1041
1042 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1043
1044 Avoid some portability problems by eschewing 'extern inline' functions.
1045 The trivial performance wins aren't worth the portability hassles; see
1046 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1047 et seq.
1048 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1049 (window_box_width, window_box_left, window_box_left_offset)
1050 (window_box_right, window_box_right_offset): Undo previous change,
1051 by removing the "extern"s.
1052 * intervals.c (adjust_intervals_for_insertion)
1053 (adjust_intervals_for_deletion): Undo previous change,
1054 making these static again.
1055 (offset_intervals, temp_set_point_both, temp_set_point)
1056 (copy_intervals_to_string): No longer inline.
1057 * xdisp.c (window_text_bottom_y, window_box_width)
1058 (window_box_height, window_box_left_offset)
1059 (window_box_right_offset, window_box_left, window_box_right)
1060 (window_box): No longer inline.
1061
1062 2011-11-08 Chong Yidong <cyd@gnu.org>
1063
1064 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1065 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1066 Signal an error if not a live window.
1067 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1068 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1069
1070 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1071
1072 * lisp.h (syms_of_abbrev): Remove declaration.
1073 Reported by CHENG Gao <chenggao@royau.me>.
1074
1075 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1076
1077 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1078 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1079 of temacs in GUI mode.
1080
1081 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1082
1083 * window.h: Declare delete_all_child_windows instead of
1084 delete_all_subwindows.
1085 * window.c (Fwindow_nest, Fset_window_nest)
1086 (Fset_window_new_total, Fset_window_new_normal)
1087 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1088 (delete_all_subwindows): Rename to delete_all_child_windows.
1089 (Fdelete_other_windows_internal, Fset_window_configuration):
1090 Call delete_all_child_windows instead of delete_all_subwindows.
1091 * frame.c (delete_frame): Call delete_all_child_windows instead
1092 of delete_all_subwindows.
1093
1094 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1095
1096 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1097 This is also needed for porting to any host where GC_MARK_STACK is
1098 not GC_MAKE_GCPROS_NOOPS.
1099 (which_symbols): Use it.
1100
1101 2011-11-07 Kenichi Handa <handa@m17n.org>
1102
1103 * coding.c (coding_set_destination): Check coding->src_pos only
1104 when coding->src_object is a buffer (bug#9910).
1105
1106 * process.c (send_process): Set the member src_multibyte of coding
1107 to 0 (bug#9911) when sending a unibyte text.
1108
1109 * callproc.c (Fcall_process): Set the member src_multibyte of
1110 process_coding to 0 (bug#9912).
1111
1112 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1113
1114 * xmenu.c (cleanup_widget_value_tree): New function.
1115 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1116 calling free_menubar_widget_value_tree directly (Bug#9830).
1117
1118 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1119
1120 Fix some portability problems with 'inline'.
1121 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1122 (window_box_width, window_box_left, window_box_left_offset)
1123 (window_box_right, window_box_right_offset): Declare extern.
1124 Otherwise, these inline functions do not conform to C99 and
1125 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1126 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1127 * intervals.c (adjust_intervals_for_insertion)
1128 (adjust_intervals_for_deletion): Now extern, because otherwise the
1129 extern inline functions 'offset_intervals' couldn't refer to it.
1130 (static_offset_intervals): Remove.
1131 (offset_intervals): Rewrite using the old contents of
1132 static_offset_intervals. The old version didn't conform to C99
1133 because an extern inline function contained a reference to an
1134 identifier with static linkage.
1135
1136 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1137
1138 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1139 GC.
1140
1141 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1142
1143 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1144 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1145 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1146 return Qleft_to_right.
1147
1148 2011-11-06 Chong Yidong <cyd@gnu.org>
1149
1150 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1151 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1152 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1153 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1154 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1155 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1156 (Fwindow_vscroll): Doc fix.
1157 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1158 argument, since it makes no sense to pass a live window and for
1159 consistency with window-child.
1160
1161 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1162
1163 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1164 support MSVC.
1165
1166 2011-11-05 Jason Rumney <jasonr@gnu.org>
1167
1168 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1169 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1170 fonts (Bug#6029).
1171 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1172 bitwise arithmetic preventing use of unicode-sip and non-truetype
1173 opentype fonts.
1174
1175 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1176
1177 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1178 "emacs"-only part.
1179
1180 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1181 initialization code to keep similarity to xfns.c after changes
1182 from 2011-11-05.
1183
1184 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1185
1186 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1187 (unwind_create_frame): New function (Bug#9943).
1188 (Fx_create_frame): Restructure code to be more similar to the one in
1189 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1190 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1191 Move terminal->reference_count++ just before making the frame official
1192 (Bug#9943).
1193
1194 * nsterm.m (x_free_frame_resources): New function.
1195 (x_destroy_window): Move code to x_free_frame_resources.
1196
1197 * xfns.c (unwind_create_frame): Fix comment.
1198 (Fx_create_frame, x_create_tip_frame):
1199 Move terminal->reference_count++ just before making the frame
1200 official. Move initialization of image_cache_refcount and
1201 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1202
1203 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1204
1205 Support MSVC build with newer versions of Visual Studio.
1206 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1207 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1208 nt/gmake.defs.
1209
1210 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1211 which are not supported by MSVC.
1212 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1213 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1214 bitfields.
1215 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1216 types in bitfields.
1217 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1218
1219 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1220
1221 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1222
1223 Support MSVC build with newer versions of Visual Studio.
1224 * w32.c: Don't include w32api.h for MSVC.
1225 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1226
1227 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1228 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1229 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1230 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1231 e_* cousins.
1232 (alloca) [_MSC_VER]: Define to _alloca.
1233
1234 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1235
1236 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1237
1238 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1239
1240 * xdisp.c (note_mouse_highlight): If either of
1241 previous/next-single-property-change returns nil, treat that as
1242 the beginning or the end of the buffer. (Bug#9955)
1243
1244 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1245
1246 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1247 label is not null (Bug#9951).
1248 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1249 may be NULL.
1250
1251 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1252
1253 * window.c (Fwindow_body_size): Mention in the doc string that the
1254 return value is in frame's canonical units. (Bug#9949)
1255
1256 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1257
1258 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1259
1260 * w32fns.c (unwind_create_frame): If needed, free the glyph
1261 matrices of the partially constructed frame. (Bug#9943)
1262 * xfns.c (unwind_create_frame): Likewise.
1263
1264 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1265
1266 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1267 Don't stop backward scan on the continuation glyph, even though
1268 its CHARPOS is positive.
1269 (mouse_face_from_buffer_pos, note_mouse_highlight):
1270 Rename cover_string to disp_string.
1271
1272 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1273
1274 * window.c (temp_output_buffer_show): Don't use
1275 Vtemp_buffer_show_specifiers.
1276 (Vtemp_buffer_show_specifiers): Remove unused variable.
1277
1278 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1279
1280 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1281 past the beginning of the current glyph matrix.
1282
1283 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1284
1285 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1286 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1287 HAVE_GTK3 (Bug#9869).
1288
1289 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1290 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1291
1292 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1293
1294 * xterm.c: Declare x_handle_net_wm_state to return int.
1295 (handle_one_xevent): Check if we are iconified but don't have
1296 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1297 (get_current_wm_state): Return non-zero if not hidden,
1298 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1299 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1300 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1301 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1302
1303 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1304
1305 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1306 so that this new function doesn't get optimized away by a
1307 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1308
1309 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1310
1311 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1312
1313 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1314
1315 Fix the `xbytecode' command.
1316 * .gdbinit (xprintbytestr): New command.
1317 (xwhichsymbols): Rename from `which'; all callers changed.
1318 (xbytecode): Print the byte-code string as well.
1319
1320 2011-10-29 Kim Storm <storm@cua.dk>
1321
1322 * alloc.c (which_symbols): New function.
1323
1324 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1325
1326 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1327 line. (Bug#9903)
1328
1329 2011-10-29 Glenn Morris <rgm@gnu.org>
1330
1331 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1332 Not clear what it was for, and it causes various bugs. (Bug#9839)
1333
1334 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1335
1336 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1337 possible random value that matches one of those tested as
1338 condition to clear the mouse face.
1339
1340 2011-10-28 Chong Yidong <cyd@gnu.org>
1341
1342 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1343
1344 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1345
1346 * window.c (make_window): Initialize phys_cursor_on_p.
1347
1348 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1349
1350 * lisp.h (struct Lisp_Symbol): Update comments.
1351
1352 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1353
1354 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1355
1356 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1357
1358 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1359 <oslsachem@gmail.com> for helping to debug this.
1360
1361 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1362 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1363 (g_b_init_get_glyph_outline_w): New static variables.
1364 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1365 (GetGlyphOutlineW_Proc): New typedefs.
1366 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1367 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1368 New functions.
1369 (w32font_open_internal, compute_metrics):
1370 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1371 instead of calling the "wide" APIs directly.
1372
1373 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1374
1375 * w32.h (syms_of_w32font): Add prototype.
1376
1377 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1378
1379 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1380 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1381 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1382 (Fmove_to_window_line): Doc fix.
1383
1384 2011-10-27 Chong Yidong <cyd@gnu.org>
1385
1386 * process.c (make_process): Set gnutls_state to NULL.
1387
1388 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1389 non-NULL, regardless of GNUTLS_INITSTAGE.
1390 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1391 an error. Set process slots as soon as we allocate them.
1392
1393 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1394
1395 2011-10-27 Chong Yidong <cyd@gnu.org>
1396
1397 * gnutls.c (emacs_gnutls_deinit): New function.
1398 Deallocate credentials structures as well as calling gnutls_deinit.
1399 (Fgnutls_deinit, Fgnutls_boot): Use it.
1400
1401 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1402 (deactivate_process): Call emacs_gnutls_deinit.
1403
1404 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1405
1406 * image.c (x_create_x_image_and_pixmap):
1407 * w32.c (sys_rename, w32_delayed_load):
1408 * w32font.c (fill_in_logfont):
1409 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1410
1411 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1412
1413 * w32fns.c (w32_default_color_map): New function,
1414 extracted from Fw32_default_color_map.
1415 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1416
1417 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1418
1419 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1420
1421 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1422
1423 * keyboard.c (test_undefined): New function (bug#9751).
1424 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1425
1426 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1427
1428 * sysdep.c (init_sys_modes): Fix the check for the controlling
1429 terminal (Bug#6649).
1430
1431 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1432
1433 * dispextern.h (struct bidi_it): New member next_en_type.
1434
1435 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1436 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1437 current character, check also for next_en_type being WEAK_EN.
1438 (bidi_resolve_weak): Don't enter the expensive loop if the current
1439 position is before next_en_pos. Record the bidi type of the first
1440 non-ET, non-BN character we find, in addition to its position.
1441 (bidi_level_of_next_char): Invalidate next_en_type when
1442 next_en_pos is over-stepped.
1443
1444 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1445
1446 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1447 * editfns.c: Rewrite current-time-zone so that it invokes
1448 the equivalent of (format-time-string "%Z") to get the time zone name.
1449 This fixes a bug when the time zone name contains characters that
1450 need converting from the system time locale to Emacs internal format.
1451 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1452 that patch fixed format-time-string to do the conversion, but
1453 I forgot to fix current-time-zone.
1454 (format_time_string): New function, containing most of
1455 what Fformat_time_string used to contain.
1456 (Fformat_time_string): Rewrite in terms of format_time_string.
1457 This doesn't change this function's behavior.
1458 (current-time-zone): Rewrite to use format_time_string.
1459 This fixes the bug reported by Michael Schierl in
1460 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1461 Jason Rumney's 2007-06-07 change worked around this bug, but
1462 didn't fix it.
1463 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1464
1465 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1466
1467 * xdisp.c (start_display): If the character at POS is displayed
1468 via a display vector, reset IT->current.dpvec_index to zero.
1469 (try_window_reusing_current_matrix): If a line ends in a display
1470 vector or the next line starts in a display vector, continue
1471 redrawing the window even though the character position of
1472 start_row was reached.
1473 (Bug#9771, part 2)
1474
1475 2011-10-18 Chong Yidong <cyd@gnu.org>
1476
1477 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1478 with nobreak-char-display too.
1479
1480 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1481
1482 Fix part 3 of bug#9771.
1483 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1484 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1485 non-neutral characters if the current character is a paragraph
1486 separator (a.k.a. Newline). This avoids running the same
1487 expensive loop twice, once when we consume the preceding newline
1488 and the other time when the line actually needs to be displayed.
1489 Avoid the loop when we see neutrals on the base embedding level
1490 following a character whose directionality is the same as the
1491 paragraph's. This avoids running the expensive loop when a line
1492 ends in a long sequence of neutrals, like control characters.
1493 Add assertion against STRONG_AL type. Slightly rearrange code
1494 that determines the type of a neutral given the first non-neutral
1495 that follows it.
1496 (bidi_level_of_next_char): Set next_en_pos to zero when
1497 invalidating its info.
1498
1499 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1500
1501 * xdisp.c (push_display_prop): Determine whether to record string
1502 or buffer position by IT->string, not by IT->method. Allow
1503 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1504 (move_it_vertically_backward): Don't look for character position
1505 immediately after the newline when in a continuation line.
1506 (Bug#9771, part 1)
1507
1508 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1509
1510 * window.c (coordinates_in_window): Rewrite and delabelize
1511 vertical border check. (Bug#5357) (Bug#9618)
1512
1513 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1514
1515 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1516 errors in XSetWindowBorder (bug#9310).
1517
1518 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1519
1520 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1521 avoid crash when xmalloc overrun checking is enabled.
1522
1523 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1524
1525 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1526 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1527 cursor motion with <left> and <right> arrow keys.
1528
1529 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1530 some callers set that themselves.
1531
1532 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1533
1534 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1535 display string and the previous row comes from the same string and
1536 is empty. (Bug#9739) (Bug#9738)
1537
1538 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1539
1540 * doc.c (get_doc_string): Encode file name (bug#9735).
1541
1542 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1543
1544 * bidi.c (bidi_level_of_next_char):
1545 * xdisp.c (get_visually_first_element): Remove old incorrect
1546 comments regarding the Unicode Line Separator character.
1547
1548 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1549
1550 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1551
1552 * alloc.c (Fgc_status): Do not access beyond zombies array
1553 boundary if nzombies > MAX_ZOMBIES.
1554 * alloc.c (dump_zombies): Add missing format specifier.
1555
1556 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1557
1558 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1559 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1560
1561 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1562 Some packages use them to denote characters with modifiers.
1563
1564 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1565
1566 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1567 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1568 matching a pp-number. Rename parameter var to var1.
1569
1570 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1571
1572 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1573
1574 2011-10-08 Glenn Morris <rgm@gnu.org>
1575
1576 * callint.c (Fcall_interactively): Give a more explicit error for the
1577 'c' case with a non-character input. (Bug#8479)
1578
1579 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1580
1581 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1582 lines.
1583 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1584 lines that are hscrolled on the left.
1585
1586 * dispnew.c (buffer_posn_from_coords): Account for a possible
1587 presence of header-line. (Bug#4426)
1588
1589 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1590
1591 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1592 Don't advertise functionality which we discourage or doesn't work.
1593
1594 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1597 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1598 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1599 this makes Emacs dump core during garbage collection on rare
1600 occasions. sizeof is obviously inferior to offsetof here, so
1601 stick with offsetof.
1602 (GC_POINTER_ALIGNMENT): New macro.
1603 (mark_memory): Omit 3rd (offset) arg; caller changed.
1604 Don't assume EMACS_INT alignment is the same as pointer alignment.
1605
1606 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1607
1608 * keyboard.c (read_key_sequence_remapped): New var.
1609 (read_key_sequence): Compute remapping in the right buffer.
1610 (command_loop_1): Use read_key_sequence's remapping directly.
1611
1612 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1613
1614 * dired.c (file_name_completion): Don't expand file name.
1615 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1616 before checking file name handler.
1617
1618 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1619 they've been requested explicitly (bug#9591).
1620
1621 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1622
1623 * keymap.c (Fsingle_key_description): Use make_specified_string
1624 instead of build_string to build string from push_key_description.
1625 (Bug#5193)
1626
1627 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1628
1629 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1630 This fixes a Y2038 bug on 64-bit hosts.
1631 * buffer.c (reset_buffer):
1632 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1633 (Fclear_buffer_auto_save_failure):
1634 Use 0, not -1, to represent an unset failure time, since time_t
1635 might not be signed.
1636
1637 Remove dependency on glibc malloc internals.
1638 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1639 Move back here from lisp.h, but with their new implementations.
1640 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1641 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1642 * charset.c (charset_table_init): New static var.
1643 (syms_of_charset): Use it instead of xmalloc. This removes a
1644 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1645 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1646 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1647 Move back to alloc.c.
1648 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1649 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1650
1651 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1652
1653 * nsterm.m (windowDidResize): Call x_set_window_size only when
1654 ns_in_resize is true. Otherwise set pixelwidth/height and
1655 call change_frame_size (Bug#9628).
1656
1657 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1658
1659 Port --enable-checking=all to Fedora 14 x86-64.
1660 * charset.c (syms_of_charset): Also account for glibc malloc's
1661 internal overhead when calculating the initial malloc maximum.
1662
1663 Port --enable-checking=all to Fedora 14 x86.
1664 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1665 Move to lisp.h.
1666 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1667 (overrun_check_realloc, overrun_check_free):
1668 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1669 That way, xmalloc returns a properly-aligned pointer even if
1670 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1671 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1672 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1673 into account when calculating the initial malloc maximum.
1674 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1675 Move here from alloc.c, so that charset.c can use it too.
1676 Properly align; the old code wasn't right for common 32-bit hosts
1677 when configured with --enable-checking=all.
1678 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1679 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1680
1681 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1682
1683 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1684 use EDOM.
1685
1686 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1687
1688 * xdisp.c (compute_display_string_end): If there's no display
1689 string at CHARPOS, return -1.
1690
1691 * bidi.c (bidi_fetch_char): When compute_display_string_end
1692 returns a negative value, treat the character as a normal
1693 character not covered by a display string. (Bug#9624)
1694
1695 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1696
1697 * lread.c (Fread_from_string): Fix typo in docstring.
1698
1699 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1700
1701 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1702 newline, reseat the iterator instead of bidi-iterating there one
1703 character at a time. (Bug#9610)
1704 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1705 TO_CHARPOS if the bidi iterator is at base embedding level.
1706
1707 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1708
1709 * lread.c (readevalloop): Use correct code for NBSP.
1710 (read1): Likewise. (Bug#9608)
1711
1712 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1713
1714 * dbusbind.c (Fdbus_register_signal): When service is not
1715 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1716
1717 2011-09-25 Glenn Morris <rgm@gnu.org>
1718
1719 * buffer.c (truncate-lines): Doc fix.
1720
1721 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1722
1723 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1724 (Fset_window_next_buffers): Doc fix.
1725
1726 2011-09-24 Glenn Morris <rgm@gnu.org>
1727
1728 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1729
1730 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 Fix minor problems found by static checking.
1733 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1734 * indent.c (Fvertical_motion): Fix == vs = typo.
1735
1736 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1737
1738 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1739 Default value is now t. Doc fix.
1740
1741 * indent.c (Fvertical_motion): Compute and apply the overshoot
1742 logic when moving up, not only when moving down. Fix the
1743 confusing name and values of the it_overshoot_expected variable;
1744 logic changes accordingly. (Bug#9254) (Bug#9549)
1745
1746 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1747 CHARPOS is covered by a display string which includes newlines.
1748 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1749 is covered by a display string with embedded newlines.
1750
1751 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1752
1753 * dbusbind.c (Fdbus_register_signal): Add match rule to
1754 Vdbus_registered_objects_table. (Bug#9581)
1755 (Fdbus_register_method, Vdbus_registered_objects_table):
1756 Fix docstring.
1757
1758 2011-09-24 Jim Meyering <meyering@redhat.com>
1759
1760 do not ignore write error for any output size
1761 The previous change was incomplete.
1762 While it makes emacs --batch detect the vast majority of stdout
1763 write failures, errors were still ignored whenever the output size is
1764 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1765 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1766 && echo FAIL: ignored write error
1767 FAIL: ignored write error
1768 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1769 && echo FAIL: ignored write error
1770 FAIL: ignored write error
1771 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1772
1773 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1774
1775 * emacs.c (Fkill_emacs): In noninteractive mode exit
1776 non-successfully if a write error occurred on stdout. (Bug#9574)
1777
1778 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1779
1780 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1781 the xassert test.
1782
1783 * dispextern.h (struct it): Update the comment documenting what
1784 can it->OBJECT be.
1785
1786 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1787
1788 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1789 a display string, extend search for cursor position to end of row.
1790 (find_row_edges): If the row ends in a newline from a display
1791 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1792 Handle the case of a display string with multiple newlines.
1793 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1794 non-empty line. Fixes confusing cursor motion with arrow keys at
1795 the beginning of a line that starts with whitespace.
1796
1797 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1798
1799 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1800 (bug#9493).
1801
1802 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1803
1804 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1805 boolean (Bug#9154).
1806
1807 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1808
1809 * xdisp.c (display_line): Record maximum and minimum buffer
1810 positions even if no glyphs were produced (e.g., by a zero-width
1811 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1812 buffer positions that will be removed from the glyph row because
1813 they don't fit.
1814 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1815 column is beyond frame width: don't subtract 1 "pixel" when
1816 computing width of the stretch.
1817 (reseat_at_next_visible_line_start): Undo the change made on
1818 2011-09-17 that saved paragraph information and restored it after
1819 the call to `reseat'. (Bug#9545)
1820
1821 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1822
1823 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1824 and turn window cursor on if cleared (Bug#9415).
1825
1826 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1827
1828 * search.c (boyer_moore): Take unibyte characters from pattern
1829 literally. (Bug#9458)
1830
1831 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1832
1833 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1834
1835 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 Fix minor problem found by static checking.
1838 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1839 initialized, to pacify gcc -Wuninitialized.
1840
1841 * fileio.c: Report proper errno when syscall falls.
1842 (Finsert_file_contents): Save and restore errno,
1843 so that report_file_error outputs the correct diagnostic.
1844 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1845
1846 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1847
1848 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1849
1850 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1851
1852 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1853 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1854
1855 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1856
1857 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1858 about the current paragraph and restore it after the call to reseat.
1859
1860 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1861 (bidi_find_paragraph_start): Search back for paragraph beginning
1862 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1863 (bidi_move_to_visually_next): Only trigger paragraph-related
1864 computations when the last character is a newline or at EOB, not
1865 just any NEUTRAL_B. (Bug#9470)
1866
1867 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1868 truncated lines if point is covered by a display string. (Bug#9524)
1869
1870 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1871
1872 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1873 (cons_to_x_long): New function.
1874 (lisp_data_to_selection_data): Use it. Correct the test for
1875 short-versus-long data; it was negated. Break out of vector
1876 loop, for efficiency, when a long datum is discovered.
1877
1878 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1879
1880 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1881
1882 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1883
1884 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1885 GCC PR/17406) by declaring this function with external scope.
1886
1887 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1888
1889 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1890 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1891
1892 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1893
1894 * editfns.c (Fformat): Correctly handle text properties on "%%".
1895
1896 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1897
1898 * xterm.c (x_draw_composite_glyph_string_foreground):
1899 * w32term.c (x_draw_composite_glyph_string_foreground):
1900 * term.c (encode_terminal_code):
1901 * composite.c (composition_update_it, get_composition_id):
1902 * xdisp.c (get_next_display_element)
1903 (fill_composite_glyph_string): Add comments about special meaning
1904 of TAB characters in a composition.
1905
1906 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1909 This occurs when processing a multibyte format.
1910 Problem reported by Wolfgang Jenker.
1911
1912 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1913
1914 * xdisp.c (try_cursor_movement): Only check for exact match if
1915 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1916
1917 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1918
1919 Remove unused external symbols.
1920 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1921 * xdisp.c (calc_pixel_width_or_height): Now static.
1922 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1923 * indent.c (check_display_width):
1924 * w32term.c: Fix comment to match code.
1925 * xterm.c, xterm.h (x_catching_errors): Remove.
1926
1927 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1928
1929 * xselect.c: Use signed conversions more consistently (Bug#9498).
1930 (selection_data_to_lisp_data): Assume incoming selection data are
1931 signed integers, not unsigned. This is to be consistent with
1932 outgoing selection data, which was modified to use signed integers
1933 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1934 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1935 expects long, not unsigned long.
1936
1937 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1938
1939 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1940 computation of loop end. Reported by Johan Bockgård
1941 <bojohan@gnu.org>.
1942
1943 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1944
1945 * frame.c (Fother_visible_frames_p): Function deleted.
1946
1947 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1948
1949 * indent.c (compute_motion): Process display vector front to back
1950 rather than the other way around. (Bug#2496)
1951
1952 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1953
1954 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1955
1956 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1957
1958 * minibuf.c (Fread_from_minibuffer): Doc fix.
1959
1960 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1961
1962 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1963 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1964
1965 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1966
1967 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1968 value for non-existent files.
1969
1970 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1971
1972 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1973 set its "size" to -1. This will set the modtime_size field of
1974 the corresponding buffer to -1, which is what
1975 verify-visited-file-modtime expects for files that do not exist.
1976 (Bug#9139)
1977
1978 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1979
1980 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1981 here ...
1982 * lisp.h: ... from here. push_key_description is no longer
1983 defined in keyboard.c, so its declaration should not be in
1984 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1985 logically belongs with push_key_description.
1986
1987 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1988
1989 * buffer.h: Include <sys/types.h> instead of <time.h>.
1990 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1991 Problem reported by Herbert J. Skuhra.
1992
1993 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1994
1995 * xml.c (parse_region): Make the parsing work for
1996 non-comment-starting XML files again (bug#9144).
1997
1998 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1999
2000 * image.c (gif_load): Fix calculation of bottom and right corner.
2001 (Bug#9468)
2002
2003 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2004
2005 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2006 redisplay in small windows.
2007
2008 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2009
2010 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2011
2012 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2013
2014 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2015 Operate on live windows only.
2016
2017 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2018
2019 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2020
2021 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2022
2023 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2024 only under bidi iteration.
2025
2026 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2027
2028 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2029
2030 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2031
2032 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2033 Without this fix, the command to link temacs failed due to an
2034 undefined symbol __builtin_isnan. This is because
2035 /usr/include/iso/math_c99.h #defines isnan(x) to
2036 __builtin_isnan(x), but the bundled gcc, which identifies itself
2037 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2038 a __builtin_isnan.
2039 * floatfns.c (isnan): #undef, and then #define to a clone of
2040 what's in data.c.
2041 (Fisnan): Always define, since it's always available now.
2042 (syms_of_floatfns): Always define isnan at the Lisp level.
2043
2044 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2047
2048 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2051 The previous code assumed that file offsets (off_t values) fit in
2052 EMACS_INT variables, which is not true on typical 32-bit hosts.
2053 The code messed up by falsely reporting buffer overflow in cases
2054 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2055 when "big" contains more than 2**29 bytes, even though this
2056 inserts just one byte and does not overflow the buffer.
2057 (Finsert_file_contents): Store file offsets as off_t
2058 values, not as EMACS_INT values. Check for overflow when
2059 converting between EMACS_INT and off_t. When checking for
2060 buffer overflow or for overlap, take the offsets into account.
2061 Don't use EMACS_INT for small values where int suffices.
2062 When checking for overlap, fix a typo: ZV was used where
2063 ZV_BYTE was intended.
2064 (Fwrite_region): Don't assume off_t fits into 'long'.
2065 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2066
2067 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2068
2069 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2070
2071 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 sprintf-related integer and memory overflow issues (Bug#9412).
2074
2075 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2076 (esprintf, exprintf, evxprintf): New functions.
2077 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2078 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2079 (modify_event_symbol): Do not assume that the length of
2080 name_alist_or_stem is safe to alloca and fits in int.
2081 (Fexecute_extended_command): Likewise for function name and binding.
2082 (Frecursion_depth): Wrap around reliably on integer overflow.
2083 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2084 since some callers pass EMACS_INT values.
2085 (Fsingle_key_description): Don't crash if symbol name contains more
2086 than MAX_ALLOCA bytes.
2087 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2088 (get_minibuffer): Arg is now EMACS_INT, not int.
2089 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2090 (esprintf, exprintf, evxprintf): New decls.
2091 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2092
2093 * dbusbind.c (signature_cat): New function.
2094 (xd_signature, Fdbus_register_signal):
2095 Do not overrun buffer; instead, report string overflow.
2096
2097 * dispnew.c (add_window_display_history): Don't overrun buffer.
2098 Truncate instead; this is OK since it's just a log.
2099
2100 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2101 even if the time zone offset is outlandishly large.
2102 Don't mishandle offset == INT_MIN.
2103
2104 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2105 when creating daemon; the previous buffer-overflow check was incorrect.
2106
2107 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2108 which has the guts of the old verror function.
2109
2110 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2111 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2112
2113 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2114 (font_unparse_xlfd): Don't blindly alloca long strings.
2115 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2116 fits in int, when using sprintf. Use single snprintf to count
2117 length of string rather than counting it via multiple sprintfs;
2118 that's simpler and more reliable.
2119 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2120 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2121 sprintf, in case result does not fit in int.
2122
2123 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2124 (fontset_from_font): Print it.
2125
2126 * frame.c (tty_frame_count): Now printmax_t, not int.
2127 (make_terminal_frame, set_term_frame_name): Print it.
2128 (x_report_frame_params): In X, window IDs are unsigned long,
2129 not signed long, so print them as unsigned.
2130 (validate_x_resource_name): Check for implausibly long names,
2131 and don't assume name length fits in 'int'.
2132 (x_get_resource_string): Don't blindly alloca invocation name;
2133 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2134 not fit in int.
2135
2136 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2137 (xg_check_special_colors, xg_set_geometry):
2138 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2139
2140 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2141 Use esprintf, not sprintf, in case result does not fit in int.
2142
2143 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2144 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2145 it as a large positive number.
2146 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2147 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2148
2149 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2150 in case result does not fit in int.
2151
2152 * print.c (float_to_string): Detect width overflow more reliably.
2153 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2154 buffer overrun. Don't assume list length fits in 'int'. Treat
2155 print length of 0 as 0, not as infinity; to be consistent with other
2156 uses of print length in this function. Don't overflow print length
2157 index. Don't assume hash table size fits in 'long', or that
2158 vectorlike size fits in 'unsigned long'.
2159
2160 * process.c (make_process): Use printmax_t, not int, to format
2161 process-name gensyms.
2162
2163 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2164
2165 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2166 to avoid potential buffer overrun.
2167
2168 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2169 if X resource line is longer than 512 bytes.
2170
2171 * xfns.c (x_window): Make sprintf buffer a bit bigger
2172 to avoid potential buffer overrun.
2173
2174 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2175
2176 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2177
2178 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2179
2180 Integer overflow fixes for scrolling, etc.
2181 Without these, Emacs silently mishandles large integers sometimes.
2182 For example, "C-u 4294967297 M-x recenter" was treated as if
2183 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2184
2185 * xdisp.c (try_window_id): Check Emacs fixnum range before
2186 converting to 'int'.
2187
2188 * window.c (window_scroll_line_based, Frecenter):
2189 Check that an Emacs fixnum is in range before assigning it to 'int'.
2190 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2191 values converted from Emacs fixnums.
2192 (Frecenter): Don't wrap around a line count if it is out of 'int'
2193 range; instead, treat it as an extreme value.
2194 (Fset_window_configuration, compare_window_configurations):
2195 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2196
2197 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2198 that can exceed INT_MAX. Check that EMACS_INT value is in range
2199 before assigning it to the (possibly-narrower) index.
2200 (match_limit): Don't assume that a fixnum can fit in 'int'.
2201
2202 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2203 exceed INT_MAX.
2204
2205 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2206 (Fvertical_motion): Don't wrap around LINES values that don't fit
2207 in 'int'. Instead, treat them as extreme values. This is good
2208 enough for windows, which can't have more than INT_MAX lines anyway.
2209
2210 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2211
2212 * Require libxml/parser.h to avoid compilation warning.
2213
2214 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2215
2216 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2217 since this reportedly can destroy thread storage.
2218
2219 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2220
2221 * syntax.c (find_defun_start): Update all cache variables if
2222 exiting early (Bug#9401).
2223
2224 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2225
2226 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2227
2228 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2229 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2230 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2231
2232 * term.c (tty_append_glyph): New function.
2233 (produce_stretch_glyph): Static function and its prototype deleted.
2234
2235 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2236 Add prototypes.
2237
2238 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2241 when checking :margin (Bug#9390).
2242 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2243 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2244 so that the name doesn't mislead. All uses changed.
2245
2246 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2247
2248 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2249 set_tty_hooks.
2250
2251 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2252
2253 * xdisp.c (move_it_to): Don't bail out early when reaching
2254 position beyond to_charpos, if we are scanning backwards.
2255 (move_it_vertically_backward): When DY == 0, make sure we get to
2256 the first character in the line after the newline.
2257
2258 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2259
2260 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2261 (ccl_driver): Do not generate an out-of-range pointer.
2262 (Fccl_execute_on_string): Remove unnecessary check for
2263 integer overflow, noted by Stefan Monnier in
2264 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2265 Remove a FIXME that didn't need fixing.
2266 Simplify the newly-introduced buffer reallocation code.
2267
2268 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2269
2270 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2271
2272 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2273
2274 Integer and memory overflow issues (Bug#9196).
2275
2276 * doc.c (get_doc_string): Rework so that
2277 get_doc_string_buffer_size is the actual buffer size, rather than
2278 being 1 less than the actual buffer size; this makes xpalloc more
2279 convenient.
2280
2281 * image.c (x_allocate_bitmap_record, cache_image):
2282 * xselect.c (Fx_register_dnd_atom):
2283 Simplify previous changes by using xpalloc.
2284
2285 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2286 since either will do and ptrdiff_t is convenient with xpalloc.
2287
2288 * charset.c (charset_table_size)
2289 (struct charset_sort_data.priority): Now ptrdiff_t.
2290 (charset_compare): Don't overflow if priorities differ greatly.
2291 (Fsort_charsets): Don't assume list length fits in int.
2292 Check for size-calculation overflow when allocating sort data.
2293 (syms_of_charset): Allocate an initial charset table that is
2294 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2295
2296 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2297
2298 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2299 The actual value is always <= INT_MAX, and leaving it unsigned made
2300 overflow checking harder.
2301
2302 * dispextern.h (struct glyph_matrix.rows_allocated)
2303 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2304 with xpalloc. The values are still always <= INT_MAX.
2305
2306 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2307
2308 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2309 (SAFE_NALLOCA): New macro.
2310
2311 * region-cache.c (struct boundary.pos, find_cache_boundary)
2312 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2313 (set_cache_region, invalidate_region_cache)
2314 (revalidate_region_cache, know_region_cache, region_cache_forward)
2315 (region_cache_backward, pp_cache):
2316 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2317 so that ptrdiff_t * can be passed to xpalloc.
2318 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2319 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2320 (pp_cache): Don't assume cache_len fits in int.
2321 * region-cache.h: Adjust extern decls to match.
2322
2323 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2324 EMACS_INT, since either will do, for xpalloc.
2325
2326 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2327 (xnmalloc, xnrealloc, xpalloc): New functions.
2328
2329 * bidi.c (bidi_shelve_header_size): New constant.
2330 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2331 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2332
2333 * bidi.c (bidi_cache_shrink):
2334 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2335 (overlay_strings):
2336 Don't update size of array until after memory allocation succeeds,
2337 because xmalloc/xrealloc may not return.
2338 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2339 now that we have proper integer overflow checking.
2340 (record_overlay_string, overlay_strings): Catch overflows when
2341 calculating size of overlay_str_buf.
2342
2343 * callproc.c (Fcall_process): Check for size overflow when
2344 calculating size of args2.
2345 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2346 Normally we prefer signed values, but sticking with ptrdiff_t would
2347 require adding more-complicated checks.
2348
2349 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2350 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2351 Redo buffer-overflow calculations to avoid integer overflow.
2352 Add a FIXME comment where memory seems to be over-allocated.
2353
2354 * character.c (Fstring): Check for size-calculation overflow.
2355
2356 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2357 unnecessary integer overflow. Check for size overflow.
2358 (encode_coding_object): Don't update size until xmalloc succeeds.
2359
2360 * composite.c (get_composition_id): Check for overflow in glyph
2361 length calculations.
2362
2363 Integer and memory overflow fixes for display code.
2364 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2365 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2366 (scrolling_window): Check for overflow in size calculations.
2367 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2368 Don't assume glyph table len fits in int.
2369 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2370 (row_table_size): Now ptrdiff_t, not int.
2371 (scrolling_window): Avoid overflow in size calculations.
2372 Don't update size until allocation succeeds.
2373 * fns.c (concat): Check for overflow in size calculations.
2374 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2375 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2376 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2377
2378 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2379 (get_doc_string): Check for size calculation overflow.
2380 Don't update size until allocation succeeds.
2381 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2382 EMACS_INT, where ptrdiff_t will do.
2383 (Fsubstitute_command_keys): Check for string overflow.
2384
2385 * editfns.c (set_time_zone_rule): Don't assume environment length
2386 fits in int.
2387 (message_length): Now ptrdiff_t, not int.
2388 (Fmessage_box): Don't update size until allocation succeeds.
2389 Don't assume message length fits in int.
2390 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2391
2392 * emacs.c (main): Do not reallocate argv, since there is a null at
2393 the end that can be overwritten, and this way there's no need to
2394 worry about size-calculation overflow.
2395 (sort_args): Check for size-calculation overflow.
2396
2397 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2398 alloc succeeds.
2399 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2400
2401 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2402 (x_set_scroll_bar_width, x_figure_window_size):
2403 Check for integer overflow.
2404 (x_set_alpha): Do not assume XINT fits in int.
2405
2406 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2407 This is for the members text_lines, text_cols, total_lines, total_cols,
2408 where the system imposes an 'int' limit.
2409
2410 * fringe.c (Fdefine_fringe_bitmap):
2411 Don't update size until alloc works.
2412
2413 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2414 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2415
2416 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2417 Check for size-calculation overflow.
2418 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2419 do, as we prefer signed integers.
2420 (id_to_widget.max_size, id_to_widget.used)
2421 (xg_store_widget_in_map, xg_remove_widget_from_map)
2422 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2423 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2424 Use and return ptrdiff_t, not int.
2425 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2426 * gtkutil.h: Change prototypes to match the above.
2427
2428 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2429 are duplicate now that they've been promoted to lisp.h.
2430 (x_allocate_bitmap_record, x_alloc_image_color)
2431 (make_image_cache, cache_image, xpm_load):
2432 Don't update size until alloc is done.
2433 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2434 (x_detect_edges):
2435 Check for size calculation overflow.
2436 (ct_colors_allocated_max): New constant.
2437 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2438 overflow.
2439
2440 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2441 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2442 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2443 Use ptrdiff_t, not int, to count maps.
2444 (read_char_minibuf_menu_prompt): Check for overflow in size
2445 calculations. Don't update size until allocation succeeds.
2446 Redo calculations to avoid overflow.
2447 * keyboard.h: Change prototypes to match the above.
2448
2449 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2450 to count maps.
2451 (current_minor_maps): Check for size calculation overflow.
2452 * keymap.h: Change prototypes to match the above.
2453
2454 * lread.c (read1, init_obarray): Don't update size until alloc done.
2455
2456 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2457 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2458
2459 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2460 Now ptrdiff_t, not int.
2461 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2462 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2463
2464 * process.c (Fnetwork_interface_list): Check for overflow
2465 in size calculation.
2466
2467 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2468
2469 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2470 overflow. Don't bother calling xmalloc when xrealloc will do.
2471
2472 * search.c (Freplace_match): Check for size calculation overflow.
2473 (Fset_match_data): Don't assume list lengths fit in 'int'.
2474
2475 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2476 for command line length. Do not attempt to address one before the
2477 beginning of an array, as that's not portable.
2478
2479 * term.c (max_frame_lines): Remove; unused.
2480 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2481 not int.
2482 (encode_terminal_code, calculate_costs): Check for size
2483 calculation overflow.
2484 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2485 table lengths and related sizes. Don't update size until alloc
2486 done. Redo calculations to avoid overflow.
2487 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2488
2489 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2490 subtracting pointers.
2491 (gobble_line): Check for overflow more carefully. Don't update size
2492 until alloc done.
2493
2494 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2495 Don't update size until alloc done.
2496 Redo size calculations to avoid overflow.
2497 Check for size calculation overflow.
2498 (main) [DEBUG]: Fix typo in invoking tparam1.
2499
2500 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2501 Use ptrdiff_t, not int, for sizes.
2502 (store_mode_line_noprop_char): Don't update size until alloc done.
2503
2504 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2505 Use ptrdiff_t, not int, for sizes.
2506 (Finternal_make_lisp_face, cache_face):
2507 Check for size calculation overflow.
2508 (cache_face): Treat size calculation overflows as if they were
2509 memory exhaustion (the usual treatment), rather than aborting.
2510
2511 * xfns.c (x_encode_text, x_set_name_internal)
2512 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2513 sizes, since they can exceed INT_MAX in size. Check for size
2514 calculation overflow.
2515
2516 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2517 (xg_select): Check for size calculation overflow.
2518 Don't update size until alloc done.
2519
2520 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2521 as sprintf is limited to int lengths.
2522
2523 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2524 (X_LONG_MIN): New macros.
2525 Use them to make the following changes clearer.
2526 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2527 This change doesn't affect the value now, but it may help remind
2528 future maintainers not to raise the value too much later.
2529 (SELECTION_QUANTUM): Remove, replacing with ...
2530 (selection_quantum): ... new function, which avoids overflow.
2531 All uses changed.
2532 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2533 assumption that selection length fits in 'int'.
2534 (x_reply_selection_request, x_handle_selection_request)
2535 (x_get_window_property, receive_incremental_selection)
2536 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2537 (lisp_data_to_selection_data, clean_local_selection_data):
2538 Use ptrdiff_t, not int, to record length of selection.
2539 (x_reply_selection_request, x_get_window_property)
2540 (receive_incremental_selection, x_property_data_to_lisp):
2541 Redo calculations to avoid overflow.
2542 (x_reply_selection_request): When sending hint, ceiling it at
2543 X_LONG_MAX rather than relying on wraparound overflow to send
2544 something.
2545 (x_get_window_property, receive_incremental_selection)
2546 (lisp_data_to_selection_data, x_property_data_to_lisp):
2547 Check for size-calculation overflow.
2548 (x_get_window_property, receive_incremental_selection)
2549 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2550 Don't store size until memory allocation succeeds.
2551 (x_get_window_property): Plug memory leak on memory exhaustion.
2552 Don't double-block input; malloc is safe here. Don't assume 2**34
2553 - 4 fits in unsigned long. Add an xassert to check
2554 XGetWindowProperty overflow. Be more careful about overflow
2555 calculations, and distinguish size from memory overflow better.
2556 (receive_incremental_selection): When tracing, don't assume
2557 unsigned int is less than INT_MAX.
2558 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2559 harmful) conversions of unsigned short to int.
2560 (lisp_data_to_selection_data): Don't assume that integers
2561 in the range -65535 through -1 fit in an X unsigned short.
2562 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2563 result parameters unless successful. Rely on cons_to_unsigned
2564 to report problems with elements; the old code wasn't right anyway.
2565 (x_check_property_data): Check for int overflow; we cannot use
2566 a wider type due to X limits.
2567 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2568
2569 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2570
2571 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2572 (x_term_init): Check for size calculation overflow.
2573 (x_color_cells): Don't store size until memory allocation succeeds.
2574 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2575 Don't assume alloca size is less than MAX_ALLOCA.
2576 (x_term_init): Don't assume length fits in int (sprintf is limited
2577 to int size).
2578
2579 Use ptrdiff_t for composition IDs.
2580 * character.c (lisp_string_width):
2581 * composite.c (composition_table_size, n_compositions)
2582 (get_composition_id, composition_gstring_from_id):
2583 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2584 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2585 * window.c (Frecenter):
2586 Use ptrdiff_t, not int, for composition IDs.
2587 * composite.c (get_composition_id): Check for integer overflow.
2588 * composite.h: Adjust prototypes to match the above changes.
2589
2590 Use ptrdiff_t for hash table indexes.
2591 * category.c (hash_get_category_set):
2592 * ccl.c (ccl_driver):
2593 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2594 * coding.c (coding_system_charset_list, detect_coding_system):
2595 * coding.h (struct coding_system.id):
2596 * composite.c (get_composition_id, gstring_lookup_cache):
2597 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2598 * image.c (xpm_get_color_table_h):
2599 * lisp.h (hash_lookup, hash_put):
2600 * minibuf.c (Ftest_completion):
2601 Use ptrdiff_t for hash table indexes, not int (which is too
2602 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2603 32-bit --with-wide-int hosts).
2604
2605 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2606 Add a FIXME comment about memory leaks.
2607 (syms_of_charset): Don't assume xmalloc returns.
2608
2609 Don't assume that stated character widths fit in int.
2610 * character.c (Fchar_width, c_string_width, lisp_string_width):
2611 * character.h (CHAR_WIDTH):
2612 * indent.c (MULTIBYTE_BYTES_WIDTH):
2613 Use sanitize_char_width to avoid undefined and/or bad behavior
2614 with outlandish widths.
2615 * character.h (sanitize_tab_width): Rename from sanitize_width,
2616 now that we have two such functions. All uses changed.
2617 (sanitize_char_width): New inline function.
2618
2619 Don't assume that tab-width fits in int.
2620 * character.h (sanitize_width): New inline function.
2621 (SANE_TAB_WIDTH): New macro.
2622 (ASCII_CHAR_WIDTH): Use it.
2623 * indent.c (sane_tab_width): Remove. All uses replaced by
2624 SANE_TAB_WIDTH (current_buffer).
2625 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2626
2627 * fileio.c: Integer overflow issues with file modes.
2628 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2629
2630 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2631 Remove unreachable code.
2632 (read_hex, load_charset_map_from_file): Check for integer overflow.
2633
2634 * xterm.c: Don't go over XClientMessageEvent limit.
2635 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2636 (x_send_scroll_bar_event): Likewise. Check that the size does not
2637 exceed limits imposed by XClientMessageEvent, as well as the usual
2638 ptrdiff_t and size_t limits.
2639
2640 * keyboard.c: Overflow, signedness and related fixes.
2641 (make_lispy_movement): Use same integer type in forward decl
2642 that is used in the definition.
2643 (read_key_sequence, keyremap_step):
2644 Change bufsize argument back to int, undoing my 2011-03-30 change.
2645 We prefer signed types, and int is wide enough here.
2646 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2647 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2648 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2649 length, not size_t. Use ptrdiff_t for index, not int.
2650 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2651 possibility of integer overflow.
2652
2653 Overflow, signedness and related fixes for images.
2654
2655 * dispextern.h (struct it.stack[0].u.image.image_id)
2656 (struct_it.image_id, struct image.id, struct image_cache.size)
2657 (struct image_cache.used, struct image_cache.ref_count):
2658 * gtkutil.c (update_frame_tool_bar):
2659 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2660 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2661 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2662 * nsmenu.m (update_frame_tool_bar):
2663 * xdisp.c (calc_pixel_width_or_height):
2664 * xfns.c (image_cache_refcount):
2665 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2666 on typical 64-bit hosts.
2667
2668 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2669 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2670 Omit unnecessary casts to int.
2671 (parse_image_spec): Check that integers fall into 'int' range
2672 when the callers expect that.
2673 (image_ascent): Redo ascent calculation to avoid int overflow.
2674 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2675 (lookup_image): Remove unnecessary tests.
2676 (xbm_image_p): Locals are now of int, not EMACS_INT,
2677 since parse_image_check makes sure they fit into int.
2678 (png_load, gif_load, svg_load_image):
2679 Prefer int to unsigned where either will do.
2680 (tiff_handler): New function, combining the cores of the
2681 old tiff_error_handler and tiff_warning_handler.
2682 This function is rewritten to use vsnprintf and thereby avoid
2683 stack buffer overflows. It uses only the features of vsnprintf
2684 that are common to both POSIX and native Microsoft.
2685 (tiff_error_handler, tiff_warning_handler): Use it.
2686 (tiff_load, gif_load, imagemagick_load_image):
2687 Don't assume :index value fits in 'int'.
2688 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2689 (imagemagick_load_image): Check that crop parameters fit into
2690 the integer types that MagickCropImage accepts. Don't assume
2691 Vimagemagick_render_type has a nonnegative value. Don't assume
2692 size_t fits in 'long'.
2693 (gs_load): Use printmax_t to print the widest integers possible.
2694 Check for integer overflow when computing image height and width.
2695
2696 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2697
2698 * xdisp.c (redisplay_window): Don't force window start if point
2699 will be invisible in the resulting window. (Bug#9324)
2700
2701 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2702
2703 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2704 the display spec is of the form `(space ...)'.
2705 (handle_display_spec): Return the value returned by
2706 handle_single_display_spec, not just 1 or zero.
2707 (handle_single_display_spec): If the display spec is of the form
2708 `(space ...)', and specifies display in the text area, return 2
2709 rather than 1.
2710 (try_cursor_movement): Check for the need to scroll more
2711 accurately, and prefer exact match for point under bidi.
2712 Don't advance `row' beyond the last row of the window.
2713
2714 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2715 into disp_prop; all users changed.
2716
2717 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2718 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2719 for the text covered by the display property.
2720
2721 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2722
2723 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2724 Change return value to nil.
2725 (Frecord_buffer): Delete unused function.
2726
2727 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2728
2729 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2730 buffers, return left-to-right.
2731 (set_cursor_from_row): Consider candidate row a win if its glyph
2732 represents a newline and point is on that newline. Fixes cursor
2733 positioning on the newline at EOL of R2L text within L2R
2734 paragraph, and vice versa.
2735 (try_cursor_movement): Check continued rows, in addition to
2736 continuation rows. Fixes unwarranted scroll when point enters a
2737 continued line of R2L text within an L2R paragraph, or vice versa.
2738 (cursor_row_p): Consider the case of point being equal to
2739 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2740 from the end of a short line to the beginning of a continued line
2741 of R2L text within L2R paragraph.
2742 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2743 composed characters.
2744
2745 * bidi.c (bidi_check_type): Use xassert.
2746 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2747 members.
2748
2749 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2750
2751 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2752 a character.
2753
2754 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2755
2756 * nsfont.m (ns_otf_to_script): Fix typo.
2757
2758 2011-08-22 Kenichi Handa <handa@m17n.org>
2759
2760 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2761 extra slot even if the purpose is char-code-property-table.
2762
2763 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2764
2765 * xdisp.c (redisplay_window): When computing centering_position,
2766 account for the height of the header line. (Bug#8874)
2767
2768 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2769 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2770 candidate is selected by the mouse, and that candidate has a
2771 composed character under the mouse.
2772
2773 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2774 coordinates reported by pos-visible-in-window-p for a composed
2775 character in column zero.
2776
2777 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2778
2779 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2780
2781 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2782
2783 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2784 consider it a hit if to_charpos is anywhere in the range of the
2785 composed buffer positions.
2786
2787 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2788
2789 * image.c (gif_load): Don't assume that each subimage has the same
2790 dimensions as the base image. Handle disposal method that is
2791 "undefined" by the gif spec (Bug#9335).
2792
2793 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2794
2795 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2796 (Fcondition_case): Document `debug' symbol in error handler.
2797
2798 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2799
2800 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2801 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2802 from an Org mode buffer to a Speedbar frame.
2803
2804 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2805 a composition, take its buffer position from IT->cmp_it.charpos.
2806 Fixes cursor positioning at the beginning of a line that begins
2807 with a composed character.
2808
2809 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2810
2811 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2812 character bidirectional type, use STRONG_L instead. Fixes crashes
2813 in a buffer produced by `describe-categories'.
2814
2815 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2816 members before the level stack, so they would be saved and
2817 restored when copying iterator state. Fixes incorrect reordering
2818 around TABs covered by display properties.
2819
2820 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2821
2822 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2823
2824 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2825
2826 * eval.c (internal_condition_case, internal_condition_case_1)
2827 (internal_condition_case_2, internal_condition_case_n):
2828 Remove unnecessary aborts (Bug#9081).
2829
2830 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2831
2832 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2833 has no `load' handler, try opening the file locally. (Bug#9311)
2834
2835 2011-08-16 Ken Brown <kbrown@cornell.edu>
2836
2837 * gmalloc.c: Expand comment.
2838
2839 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2840
2841 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2842 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2843
2844 2011-08-16 Ken Brown <kbrown@cornell.edu>
2845
2846 Fix memory allocation problems in Cygwin build (Bug#9273).
2847
2848 * unexcw.c ( __malloc_initialized): Declare external variable.
2849 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2850
2851 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2852 New variables.
2853 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2854 dumped emacs.
2855 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2856 in the static heap.
2857 [CYGWIN] (special_realloc): New function.
2858 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2859 requests to realloc storage in the static heap.
2860
2861 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2862
2863 * bidi.c (bidi_initialize): Remove unused local.
2864
2865 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2866
2867 * bidimirror.h:
2868 * biditype.h: Remove file.
2869 * makefile.w32-in ($(BLD)/bidi.$(O)):
2870 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2871
2872 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2873
2874 * chartab.c: Improve commentary for the uniprop_table API.
2875
2876 * bidi.c (bidi_paragraph_init): Support zero value of
2877 bidi_ignore_explicit_marks_for_paragraph_level.
2878 (bidi_initialize): Use uniprop_table instead of including
2879 biditype.h and bidimirror.h.
2880
2881 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2882 coordinates of the iterator when restoring from ppos_it.
2883 (Bug#9296)
2884
2885 2011-08-14 Kenichi Handa <handa@m17n.org>
2886
2887 * process.c (create_process): Call setup_process_coding_systems
2888 after the pid of the process is set to -1 (Bug#8162).
2889
2890 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2891
2892 * xdisp.c (move_it_in_display_line_to): Don't invoke
2893 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2894 ppos_it. Fixes vertical cursor motion when line beginning is
2895 covered by an image. (Bug#9296)
2896
2897 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2898
2899 * nsterm.h (ns_run_ascript): Declare.
2900 (NSAPP_DATA2_RUNASSCRIPT): Define.
2901
2902 * nsfns.m (as_script, as_result, as_status): New static variables.
2903 (ns_run_ascript): New function.
2904 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2905 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2906 the event loop. Get status from as_status (Bug#7276).
2907
2908 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2909 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2910 the event loop (Bug#7276).
2911
2912 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2913
2914 * gnutls.c (QCgnutls_bootprop_priority)
2915 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2916 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2917 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2918 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2919 (QCgnutls_bootprop_verify_hostname_error)
2920 (QCgnutls_bootprop_callbacks_verify): Rename from
2921 Qgnutls_bootprop_..., all uses changed.
2922
2923 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2924 uses changed.
2925
2926 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2927
2928 * xfaces.c (Qframe_set_background_mode): Now static.
2929 * dispextern.h (Qframe_set_background_mode): Remove decl.
2930
2931 * process.c (Fnetwork_interface_info): Declare local only if needed.
2932
2933 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2934
2935 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2936 (Fnetwork_interface_list): Allocate in increments of bytes instead
2937 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2938 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2939 sockaddr.
2940 (struct ifflag_def): notrailers is smart on OSX.
2941 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2942 Get hardware address with getifaddrs if available.
2943
2944 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2945
2946 * xdisp.c (iterate_out_of_display_property): xassert that
2947 IT->position is set to within IT->object's boundaries. Break from
2948 the loop as soon as EOB is reached; avoids infloops in redisplay
2949 when IT->position is set up wrongly due to some bug.
2950 Set IT->current to match the bidi iterator unconditionally.
2951 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2952 entry. Force push_it to save on the stack the current
2953 buffer/string position, to be restored by pop_it. Fix flags in
2954 the iterator structure wrt the object coming from a display
2955 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2956 properties. (Bug#9284)
2957
2958 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2959
2960 * fontset.c (fontset_get_font_group): Add proper type checks.
2961 (Bug#9172)
2962
2963 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2964
2965 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2966 and LC_VERSION_MIN_MACOSX.
2967 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2968 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2969
2970 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2971
2972 * xdisp.c (forward_to_next_line_start): Allow to use the
2973 no-display-properties-and-no-overlays under bidi display.
2974 Set disp_pos in the bidi iterator to avoid searches for display
2975 properties and overlays.
2976
2977 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2978
2979 * editfns.c (Fset_time_zone_rule): Document relationship with the
2980 setenv function.
2981
2982 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2983 the font entity extracted from the cache (Bug#8109).
2984
2985 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2986
2987 * composite.c (autocmp_chars): Don't reset point. That is done by
2988 restore_point_unwind (Bug#5984).
2989
2990 2011-08-07 Juri Linkov <juri@jurta.org>
2991
2992 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2993 to show the arg `TIME' instead of `TIMEVAL'.
2994
2995 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2996
2997 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2998 display property strides EOL and includes a newline, as in
2999 longlines-mode. (Bug#9254)
3000 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3001 word-wrap under bidirectional display. (Bug#9224)
3002
3003 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3004 is non-zero, even if the data buffer is NULL. Fixes a crash in
3005 vertical-motion with longlines-mode. (Bug#9254)
3006
3007 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3008
3009 * bidi.c <bidi_cache_total_alloc>: Now static.
3010 (bidi_initialize): Initialize bidi_cache_total_alloc.
3011
3012 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3013 cache. (Bug#9221)
3014
3015 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3016 amount allocated this far in `bidi_cache_total_alloc'.
3017 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3018 non-zero, only free the data buffer without restoring the cache
3019 contents. All callers changed.
3020
3021 * dispextern.h (bidi_unshelve_cache): Update prototype.
3022
3023 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3024 (move_it_in_display_line, move_it_to)
3025 (move_it_vertically_backward, move_it_by_lines): Replace the call
3026 to xfree to an equivalent call to bidi_unshelve_cache.
3027 (move_it_in_display_line_to): Fix logic of returning
3028 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3029
3030 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3031
3032 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3033 came from a string character with a `cursor' property. (Bug#9229)
3034
3035 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3036
3037 * Makefile.in (LIB_PTHREAD): New variable.
3038 (LIBES): Add LIB_PTHREAD (Bug#9216).
3039
3040 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3041 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3042
3043 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3044
3045 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3046
3047 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3048
3049 * xterm.c (x_find_topmost_parent): New function.
3050 (x_set_frame_alpha): Find topmost parent window with
3051 x_find_topmost_parent and set the property there also (bug#9181).
3052 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3053
3054 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3055
3056 * callproc.c (Fcall_process): Avoid vfork clobbering
3057 the local vars buffer, coding_systems, current_dir.
3058
3059 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3060
3061 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3062
3063 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3064
3065 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3066 so that it is not optimized away.
3067
3068 * xdisp.c (compute_display_string_pos): Remove unused local.
3069
3070 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3071
3072 Fix slow cursor motion and scrolling in large buffers with
3073 selective display, like Org Mode buffers. (Bug#9218)
3074
3075 * dispextern.h (struct bidi_it): New member disp_prop_p.
3076
3077 * xdisp.c: Remove one-slot cache of display string positions.
3078 (compute_display_string_pos): Accept an additional argument
3079 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3080 for a display string or property. If found, set DISP_PROP_P
3081 non-zero.
3082
3083 * bidi.c (bidi_fetch_char): Accept an additional argument
3084 DISP_PROP_P, and pass it to compute_display_string_pos.
3085 Only handle text covered by a display string if DISP_PROP_P is returned
3086 non-zero. All callers of bidi_fetch_char changed.
3087
3088 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3089
3090 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3091
3092 2010-12-03 Don March <don@ohspite.net>
3093
3094 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3095 last character M-[char] is translated to ESC [char] (bug#7541).
3096
3097 2011-08-02 Kenichi Handa <handa@m17n.org>
3098
3099 * lisp.h (uniprop_table): Extern it.
3100
3101 * chartab.c (uniprop_table): Make it non-static.
3102
3103 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3104
3105 * xdisp.c (forward_to_next_line_start): Accept additional argument
3106 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3107 on the newline.
3108 (reseat_at_next_visible_line_start): Use the bidi iterator state
3109 returned by forward_to_next_line_start to restore the state of
3110 it->bidi_it after backing up to previous newline. (Bug#9212)
3111
3112 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3113
3114 * regex.c (re_comp): Protoize.
3115 (re_exec): Fix return type.
3116 (regexec): Fix type of `ret'. (Bug#9203)
3117
3118 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3119
3120 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3121 This is needed if max-image-size is a floating-point number.
3122
3123 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3124
3125 * print.c (print_object): Print empty symbol as ##.
3126
3127 * lread.c (read1): Read ## as empty symbol.
3128
3129 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3130
3131 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3132 setting frame foreground color (Bug#9175).
3133 (x_set_background_color): Likewise.
3134
3135 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3136 contents (Bug#9176).
3137 (EmacsTooltip -init): Remove bezels and add shadows to
3138 tooltip windows.
3139
3140 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3141 or scroll bar (Bug#8470).
3142
3143 * nsfont.m (nsfont_open): Remove assignment to voffset and
3144 unnecessary vars hshink, expand, hd, full_height, min_height.
3145 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3146
3147 * nsterm.h (nsfont_info): Remove voffset field.
3148
3149 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3150
3151 Implement strike-through and overline on NextStep (Bug#8863).
3152
3153 * nsfont.m (nsfont_open): Use underline position provided by font,
3154 instead of hard-coded value of 2.
3155 (nsfont_draw): Call ns_draw_text_decoration instead.
3156
3157 * nsterm.h: Add declaration for ns_draw_text_decoration.
3158
3159 * nsterm.m (ns_draw_text_decoration): New function for drawing
3160 underline, overline, and strike-through.
3161 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3162 ns_draw_text_decoration. Change treatment of cursor drawing to
3163 accommodate underlining, etc.
3164
3165 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3166
3167 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3168 default.
3169
3170 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3171
3172 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3173 Without this fix, if a signal arrives just after memory fills up,
3174 'malloc' might be invoked reentrantly.
3175
3176 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3177 In other words, assume that every image size is allowed, on non-X
3178 hosts. This assumption is probably wrong, but it lets Emacs compile.
3179
3180 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3181
3182 * regex.c (re_iswctype): Convert return values to boolean.
3183
3184 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3185
3186 * xdisp.c (compute_display_string_pos): Don't use cached display
3187 string position if the buffer had its restriction changed.
3188 (Bug#9184)
3189
3190 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3191
3192 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3193
3194 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3195
3196 Integer signedness and overflow and related fixes. (Bug#9079)
3197
3198 * bidi.c: Integer size and overflow fixes.
3199 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3200 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3201 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3202 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3203 (bidi_find_other_level_edge):
3204 Use ptrdiff_t instead of EMACS_INT where either will do.
3205 This works better on 32-bit hosts configured --with-wide-int.
3206 (bidi_cache_ensure_space): Check for size-calculation overflow.
3207 Use % rather than repeated addition, for better worst-case speed.
3208 Don't set bidi_cache_size until after xrealloc returns, because it
3209 might not return.
3210 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3211 (bidi_cache_ensure_space): Also check that the bidi cache size
3212 does not exceed that of the largest Lisp string or buffer. See Eli
3213 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3214
3215 * alloc.c (__malloc_size_t): Remove.
3216 All uses replaced by size_t. See Andreas Schwab's note
3217 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3218
3219 * image.c: Improve checking for integer overflow.
3220 (check_image_size): Assume that f is nonnull, since
3221 it is always nonnull in practice. This is one less thing to
3222 worry about when checking for integer overflow later.
3223 (x_check_image_size): New function, which checks for integer
3224 overflow issues inside X.
3225 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3226 This removes the need for a memory_full check.
3227 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3228 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3229 (xbm_read_bitmap_data): Change locals back to 'int', since
3230 their values must fit in 'int'.
3231 (xpm_load_image, png_load, tiff_load):
3232 Invoke x_create_x_image_and_pixmap earlier,
3233 to avoid much needless work if the image is too large.
3234 (tiff_load): Treat overly large images as if
3235 x_create_x_image_and_pixmap failed, not as malloc failures.
3236 (gs_load): Use x_check_image_size.
3237
3238 * gtkutil.c: Omit integer casts.
3239 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3240 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3241
3242 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3243
3244 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3245 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3246 would wrongly return t on a 64-bit host.
3247
3248 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3249 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3250 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3251 and therefore cause GCC to emit a bogus diagnostic in some cases.
3252
3253 * image.c: Integer signedness and overflow and related fixes.
3254 This is not an exhaustive set of fixes, but it's time to
3255 record what I've got.
3256 (lookup_pixel_color, check_image_size): Remove redundant decls.
3257 (check_image_size): Don't assume that arbitrary EMACS_INT values
3258 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3259 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3260 (tiff_load, imagemagick_load_image):
3261 Check for overflow in size calculations.
3262 (x_create_x_image_and_pixmap): Remove unnecessary test for
3263 xmalloc returning NULL; that can't happen.
3264 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3265 (xpm_color_bucket): Use better integer hashing function.
3266 (xpm_cache_color): Don't possibly over-allocate memory.
3267 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3268 (gif_memory_source):
3269 Use ptrdiff_t, not int or size_t, to record sizes.
3270 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3271 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3272 either works, as we prefer signed integers.
3273 (tiff_read_from_memory, tiff_write_from_memory):
3274 Return tsize_t, not size_t, since that's what the TIFF API wants.
3275 (tiff_read_from_memory): Don't fail simply because the read would
3276 go past EOF; instead, return a short read.
3277 (tiff_load): Omit no-longer-needed casts.
3278 (Fimagemagick_types): Don't assume size fits into 'int'.
3279
3280 Improve hashing quality when configured --with-wide-int.
3281 * fns.c (hash_string): New function, taken from sxhash_string.
3282 Do not discard information about ASCII character case; this
3283 discarding is no longer needed.
3284 (sxhash-string): Use it. Change sig to match it. Caller changed.
3285 * lisp.h: Declare it.
3286 * lread.c (hash_string): Remove, since we now use fns.c's version.
3287 The fns.c version returns a wider integer if --with-wide-int is
3288 specified, so this should help the quality of the hashing a bit.
3289
3290 * emacs.c: Integer overflow minor fix.
3291 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3292 Define only if GNU_LINUX.
3293 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3294
3295 * dispnew.c: Integer signedness and overflow fixes.
3296 Remove unnecessary forward decls, that were a maintenance hassle.
3297 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3298 All uses changed.
3299 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3300 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3301 (prepare_desired_row, line_draw_cost):
3302 Use int, not unsigned, where either works.
3303 (save_current_matrix, restore_current_matrix):
3304 Use ptrdiff_t, not size_t, where either works.
3305 (init_display): Check for overflow more accurately, and without
3306 relying on undefined behavior.
3307
3308 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3309 Remove, replacing with the new symbols in lisp.h. All uses changed.
3310 * fileio.c (make_temp_name):
3311 * filelock.c (lock_file_1, lock_file):
3312 * xdisp.c (message_dolog):
3313 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3314 Use pMd etc. instead.
3315 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3316 replacing the pWIDE etc. symbols removed from editfns.c.
3317
3318 * keyboard.h (num_input_events): Now uintmax_t.
3319 This is (very slightly) less likely to mess up due to wraparound.
3320 All uses changed.
3321
3322 * buffer.c: Integer signedness fixes.
3323 (alloc_buffer_text, enlarge_buffer_text):
3324 Use ptrdiff_t rather than size_t when either will do, as we prefer
3325 signed integers.
3326
3327 * alloc.c: Integer signedness and overflow fixes.
3328 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3329 (__malloc_size_t): Default to size_t, not to int.
3330 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3331 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3332 Prefer ptrdiff_t to size_t when either would do, as we prefer
3333 signed integers.
3334 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3335 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3336 Now const. Initialize with values that are in range even if char
3337 is signed.
3338 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3339 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3340 These functions do the right thing with sizes > 2**32.
3341 (check_depth): Now ptrdiff_t, not int.
3342 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3343 Adjust to new way of storing sizes. Check for size overflow bugs
3344 in rest of code.
3345 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3346 slightly wrong anyway, as it missed one instance of
3347 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3348 (refill_memory_reserve): Omit needless cast to size_t.
3349 (mark_object_loop_halt): Mark as externally visible.
3350
3351 * xselect.c: Integer signedness and overflow fixes.
3352 (Fx_register_dnd_atom, x_handle_dnd_message):
3353 Use ptrdiff_t, not size_t, since we prefer signed.
3354 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3355 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3356 x_dnd_atoms_size and x_dnd_atoms_length.
3357
3358 * doprnt.c: Prefer signed to unsigned when either works.
3359 * eval.c (verror):
3360 * doprnt.c (doprnt):
3361 * lisp.h (doprnt):
3362 * xdisp.c (vmessage):
3363 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3364 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3365 prefer signed arithmetic to avoid comparison confusion.
3366 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3367 but is a bit tricky.
3368
3369 Assume freestanding C89 headers, string.h, stdlib.h.
3370 * data.c, doprnt.c, floatfns.c, print.c:
3371 Include float.h unconditionally.
3372 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3373 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3374 * regex.c: Likewise for stddef.h, string.h.
3375 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3376 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3377 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3378 (STDC_HEADERS): Remove obsolete defines.
3379 * sysdep.c: Include limits.h unconditionally.
3380
3381 Assume support for memcmp, memcpy, memmove, memset.
3382 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3383 * regex.c (memcmp, memcpy):
3384 Remove; we assume C89 now.
3385
3386 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3387 (__malloc_safe_bcopy): Remove; no longer needed.
3388
3389 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3390 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3391 well either way, and we prefer signed to unsigned.
3392
3393 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3394
3395 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3396 closes the connection while we're reading (bug#9182).
3397
3398 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3399
3400 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3401 are specified (Bug#9168).
3402
3403 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3404
3405 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3406 Found by GCC static checking and --with-wide-int on a 32-bit host.
3407
3408 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3409
3410 * xdisp.c (compute_display_string_pos): Fix logic of caching
3411 previous display string position. Initialize cached_prev_pos to
3412 -1. Fixes slow-down at the beginning of a buffer.
3413
3414 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3415
3416 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3417 for attrs[LFACE_FONTSET_INDEX].
3418
3419 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3420
3421 * xml.c (parse_region): Remove unused local
3422 that was recently introduced.
3423
3424 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3425
3426 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3427 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3428
3429 * xdisp.c (move_it_in_display_line_to): Record the best matching
3430 position for TO_CHARPOS while scanning the line, and restore it on
3431 exit if none of the characters scanned was an exact match.
3432 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3433 when exact match is impossible due to invisible text, and the
3434 lines are truncated.
3435
3436 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3437
3438 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3439 for OSX >= 10.7.
3440
3441 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3442
3443 Fix a significant slow-down of cursor motion with C-n, C-p,
3444 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3445 auto-repeat under bidi redisplay in fontified buffers.
3446 * xdisp.c (compute_stop_pos_backwards): New function.
3447 (next_element_from_buffer): Call compute_stop_pos_backwards to
3448 find a suitable prev_stop when we find ourselves before
3449 base_level_stop.
3450 (reseat): Don't look for prev_stop, as that could mean a very long
3451 run.
3452 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3453 <cached_disp_overlay_modiff>: Cache for last found display string
3454 position.
3455 (compute_display_string_pos): Return the cached position if asked
3456 about the same buffer in the same area of character positions, and
3457 the buffer wasn't changed since the time the display string
3458 position was cached.
3459
3460 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3461
3462 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3463 is an integer, which is important for empty lines. (Bug#9149)
3464
3465 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3466
3467 * frame.c (Fmodify_frame_parameters): In tty case, update the
3468 default face if necessary (Bug#4238).
3469
3470 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3471
3472 * editfns.c (Fstring_to_char): No need to explain what a character
3473 is in the docstring (Bug#6576).
3474
3475 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3476
3477 * xml.c (parse_region): Make sure we always return a tree.
3478
3479 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3480
3481 * xml.c (parse_region): If a document contains only comments,
3482 return that, too.
3483
3484 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3485
3486 * xml.c (make_dom): Return comments, too.
3487
3488 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3489
3490 Port to OpenBSD.
3491 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3492 and the surrounding thread.
3493 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3494 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3495 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3496 timer goes off.
3497 * s/openbsd.h (BROKEN_SIGIO): Define.
3498 * unexelf.c (unexec) [__OpenBSD__]:
3499 Don't update the .mdebug section of the Alpha COFF symbol table.
3500
3501 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3502
3503 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3504 (bug#8460).
3505
3506 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3507
3508 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3509 This fixes some race conditions on the permissions of any newly
3510 created file.
3511
3512 * alloc.c (valid_pointer_p): Use pipe, not open.
3513 This fixes some permissions issues when debugging.
3514
3515 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3516 If fchown fails to set both uid and gid, try to set just gid,
3517 as that is sometimes allowed. Adjust the file's mode to eliminate
3518 setuid or setgid bits that are inappropriate if fchown fails.
3519
3520 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3521
3522 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3523 to compare Lisp_Objects.
3524 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3525 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3526 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3527
3528 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3529
3530 * lread.c (read_integer): Unread even EOF character.
3531 (read1): Likewise. Properly record start position of symbol.
3532
3533 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3534 symbol character follows.
3535
3536 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3537
3538 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3539 This works around a problem with the previous change to Fcopy_file.
3540 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3541 and without this change, GCC might complain about discarding
3542 fchown's return value.
3543
3544 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3545
3546 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3547
3548 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3549
3550 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3551
3552 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3553
3554 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3555 it's used from the C level.
3556
3557 * process.c: Use the same condition for POLL_FOR_INPUT in both
3558 keyboard.c and process.c (bug#1858).
3559
3560 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3561
3562 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3563 (Fgnutls_boot): Use it.
3564
3565 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3566
3567 * doc.c (Fsubstitute_command_keys): Revert last change.
3568
3569 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3570
3571 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3572 quotes the next character, and doesn't affect other longer
3573 sequences (bug#8935).
3574
3575 * lread.c (syms_of_lread): Clarify that is isn't only
3576 `eval-buffer' and `eval-defun' that's affected by
3577 `lexical-binding' (bug#8460).
3578
3579 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3580
3581 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3582 bidi redisplay when a line includes both an image and is truncated.
3583
3584 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3585
3586 Fix minor problems found by static checking.
3587 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3588 (elsz): Now a signed constant, not a size_t var. We prefer signed
3589 types to unsigned, to avoid integer comparison confusion. Without
3590 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3591 "cannot optimize loop, the loop counter may overflow", a symptom
3592 of the confusion.
3593 * indent.c (Fvertical_motion): Mark locals as initialized.
3594 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3595
3596 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3597
3598 * search.c (Fre_search_backward): Mention `case-fold-search' in
3599 all the re_search_* functions (bug#8138).
3600
3601 * keyboard.c (Fopen_dribble_file): Document when the file is
3602 closed (bug#8056).
3603
3604 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3605
3606 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3607 bidi_cache_idx.
3608
3609 Support bidi reordering of display and overlay strings.
3610 * xdisp.c (compute_display_string_pos)
3611 (compute_display_string_end): Accept additional argument STRING.
3612 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3613 (reseat_to_string): Initialize bidi_it->string.s and
3614 bidi_it->string.schars.
3615 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3616 NULL (avoids a crash in bidi_paragraph_init).
3617 Initialize itb.string.lstring.
3618 (init_iterator): Call bidi_init_it only of a valid
3619 buffer position was specified. Initialize paragraph_embedding to
3620 L2R.
3621 (reseat_to_string): Initialize the bidi iterator.
3622 (display_string): If we need to ignore text properties of
3623 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3624 original value of -1 will not work with bidi.)
3625 (compute_display_string_pos): First arg is now struct
3626 `text_pos *'; all callers changed. Support display properties on
3627 Lisp strings.
3628 (compute_display_string_end): Support display properties on Lisp
3629 strings.
3630 (init_iterator, reseat_1, reseat_to_string): Initialize the
3631 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3632 when iterating on a string not from display properties).
3633 (compute_display_string_pos, compute_display_string_end):
3634 Fix calculation of the object to scan. Fixes an error when using
3635 arrow keys.
3636 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3637 base_level_stop; instead, set base_level_stop to BEGV.
3638 Fixes crashes in vertical-motion.
3639 (next_element_from_buffer): Improve commentary for when
3640 the iterator is before prev_stop.
3641 (init_iterator): Initialize bidi_p from the default value of
3642 bidi-display-reordering, not from buffer-local value. Use the
3643 buffer-local value only if initializing for buffer iteration.
3644 (handle_invisible_prop): Support invisible properties on strings
3645 that are being bidi-reordered.
3646 (set_iterator_to_next): Support bidi reordering of C strings and
3647 Lisp strings.
3648 (next_element_from_string): Support bidi reordering of Lisp
3649 strings.
3650 (handle_stop_backwards): Support Lisp strings as well.
3651 (display_string): Support display of R2L glyph rows.
3652 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3653 (init_iterator): Don't initialize it->bidi_p for strings
3654 here.
3655 (reseat_to_string): Initialize it->bidi_p for strings here.
3656 (next_element_from_string, next_element_from_c_string)
3657 (next_element_from_buffer): Add xassert's for correspondence
3658 between IT's object being iterated and it->bidi_it.string
3659 structure.
3660 (face_before_or_after_it_pos): Support bidi iteration.
3661 (next_element_from_c_string): Handle the case of the first string
3662 character that is not the first one in the visual order.
3663 (get_visually_first_element): New function, refactored from common
3664 parts of next_element_from_buffer, next_element_from_string, and
3665 next_element_from_c_string.
3666 (tool_bar_lines_needed, redisplay_tool_bar)
3667 (display_menu_bar): Force left-to-right direction. Add a FIXME
3668 comment for making that be controlled by a user option.
3669 (push_it, pop_it): Save and restore the state of the
3670 bidi iterator. Save and restore the bidi_p flag.
3671 (pop_it): Iterate out of display property for string iteration as
3672 well.
3673 (iterate_out_of_display_property): Support iteration over strings.
3674 (handle_single_display_spec): Set up it->bidi_it for iteration
3675 over a display string, and call bidi_init_it.
3676 (handle_single_display_spec, next_overlay_string)
3677 (get_overlay_strings_1, push_display_prop): Set up the bidi
3678 iterator for displaying display or overlay strings.
3679 (forward_to_next_line_start): Don't use the shortcut if
3680 bidi-iterating.
3681 (back_to_previous_visible_line_start): If handle_display_prop
3682 pushed the iterator stack, restore the internal state of the bidi
3683 iterator by calling bidi_pop_it same number of times.
3684 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3685 and we are bidi-iterating, don't decrement the iterator position;
3686 instead, set the first_elt flag in the bidi iterator, to produce
3687 the same effect.
3688 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3689 (push_display_prop): xassert that we are iterating a buffer.
3690 (push_it, pop_it): Save and restore paragraph_embedding member.
3691 (handle_single_display_spec, next_overlay_string)
3692 (get_overlay_strings_1, reseat_1, reseat_to_string)
3693 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3694 correctly. Don't assume unibyte strings are not bidi-reordered.
3695 (compute_display_string_pos)
3696 (compute_display_string_end): Fix handling the case of C string.
3697 (push_it, pop_it): Save and restore from_disp_prop_p.
3698 (handle_single_display_spec, push_display_prop): Set the
3699 from_disp_prop_p flag.
3700 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3701 (pop_it): Call iterate_out_of_display_property only if we are
3702 popping after iteration over a string that came from a display
3703 property. Fix a typo in popping stretch info. Add an assertion
3704 for verifying that the iterator position is in sync with the bidi
3705 iterator.
3706 (handle_single_display_spec, get_overlay_strings_1)
3707 (push_display_prop): Fix initialization of paragraph direction for
3708 string when that of the parent object is not yet determined.
3709 (reseat_1): Call bidi_init_it to resync the bidi
3710 iterator with IT's position. (Bug#7616)
3711 (find_row_edges): If ROW->start.pos gives position
3712 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3713 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3714 Reset the from_disp_prop_p flag.
3715 (SAVE_IT, RESTORE_IT): New macros.
3716 (pos_visible_p, face_before_or_after_it_pos)
3717 (back_to_previous_visible_line_start)
3718 (move_it_in_display_line_to, move_it_in_display_line)
3719 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3720 (try_scrolling, redisplay_window, display_line): Use them when
3721 saving a temporary copy of the iterator and restoring it back.
3722 (back_to_previous_visible_line_start, reseat_1)
3723 (init_iterator): Empty the bidi cache "stack".
3724 (move_it_in_display_line_to): If iterator ended up at
3725 EOL, but we never saw any buffer positions smaller than
3726 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3727 motion in bidi-reordered lines.
3728 (move_it_in_display_line_to): Record prev_method and prev_pos
3729 immediately before the call to set_iterator_to_next. Fixes cursor
3730 motion in bidi-reordered lines with stretch glyphs and strings
3731 displayed in margins. (Bug#8133) (Bug#8867)
3732 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3733 TO_CHARPOS.
3734 (pos_visible_p): Support positions in bidi-reordered lines.
3735 Save and restore bidi cache.
3736
3737 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3738 (bidi_paragraph_info): Delete unused struct.
3739 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3740 (bidi_cache_start): New variable.
3741 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3742 to zero.
3743 (bidi_cache_fetch_state, bidi_cache_search)
3744 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3745 (bidi_cache_find, bidi_peek_at_next_level)
3746 (bidi_level_of_next_char, bidi_find_other_level_edge)
3747 (bidi_move_to_visually_next): Compare cache index with
3748 bidi_cache_start rather than with zero.
3749 (bidi_fetch_char): Accept new argument STRING; all callers
3750 changed. Support iteration over a string. Support strings with
3751 display properties. Support unibyte strings. Fix the type of
3752 `len' according to what STRING_CHAR_AND_LENGTH expects.
3753 (bidi_paragraph_init, bidi_resolve_explicit_1)
3754 (bidi_resolve_explicit, bidi_resolve_weak)
3755 (bidi_level_of_next_char, bidi_move_to_visually_next):
3756 Support iteration over a string.
3757 (bidi_set_sor_type, bidi_resolve_explicit_1)
3758 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3759 can now be zero (for strings); special values 0 and -1 were
3760 changed to -1 and -2, respectively.
3761 (bidi_char_at_pos): New function.
3762 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3763 Call it instead of FETCH_MULTIBYTE_CHAR.
3764 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3765 initialized to valid values.
3766 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3767 values.
3768 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3769 the test for valid cached positions. Fix the logic for looking up
3770 the sentinel state in the cache. GCPRO the Lisp string we are
3771 iterating.
3772 (bidi_push_it, bidi_pop_it): New functions.
3773 (bidi_initialize): Initialize the bidi cache start stack pointer.
3774 (bidi_cache_ensure_space): New function, refactored from part of
3775 bidi_cache_iterator_state. Don't assume the required size is just
3776 one BIDI_CACHE_CHUNK away.
3777 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3778 (bidi_count_bytes, bidi_char_at_pos): New functions.
3779 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3780 always valid if bidi_cache_idx is valid.
3781 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3782 is valid if it's going to be used.
3783 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3784 (bidi_cache_fetch_state, bidi_cache_search)
3785 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3786 (bidi_cache_iterator_state, bidi_cache_find)
3787 (bidi_find_other_level_edge, bidi_cache_start_stack):
3788 All variables related to cache indices are now EMACS_INT.
3789
3790 * dispextern.h (struct bidi_string_data): New structure.
3791 (struct bidi_it): New member `string'. Make flag members be 1-bit
3792 fields, and put them last in the struct.
3793 (compute_display_string_pos, compute_display_string_end):
3794 Update prototypes.
3795 (bidi_push_it, bidi_pop_it): Add prototypes.
3796 (struct iterator_stack_entry): New members bidi_p,
3797 paragraph_embedding, and from_disp_prop_p.
3798 (struct it): Member bidi_p is now a bit field 1 bit wide.
3799 (bidi_shelve_cache, bidi_unshelve_cache):
3800 Declare prototypes.
3801
3802 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3803 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3804 and vector-like objects.
3805
3806 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3807 cache around display iteration.
3808
3809 * window.c (Fwindow_end, window_scroll_pixel_based)
3810 (displayed_window_lines, Frecenter): Save and restore the bidi
3811 cache around display iteration.
3812
3813 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3814
3815 * editfns.c (Fdelete_region): Clarify the use of the named
3816 parameters (bug#6788).
3817
3818 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3819
3820 * indent.c (Fvertical_motion): Set and restore w->pointm when
3821 saving and restoring the window's buffer (Bug#9006).
3822
3823 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3824
3825 * editfns.c (Fstring_to_char): Clarify just what is returned
3826 (bug#6576). Text by Eli Zaretskii.
3827
3828 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3829
3830 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3831
3832 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3833
3834 * buffer.c (mmap_find): Fix a typo.
3835
3836 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3837
3838 Fix execution of x selection hooks.
3839 * xselect.c (Qx_lost_selection_functions)
3840 (Qx_sent_selection_functions): New vars.
3841 (syms_of_xselect): DEFSYM them.
3842 (x_handle_selection_request): Pass Qx_sent_selection_functions
3843 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3844 (x_handle_selection_clear,x_clear_frame_selections):
3845 Pass Qx_lost_selection_functions rather than
3846 Vx_lost_selection_functions to Frun_hook_with_args.
3847
3848 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3849
3850 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3851 The old code sometimes used this field without initializing it.
3852
3853 * alloc.c (gc_sweep): Don't read past end of array.
3854 In theory, the old code could also have corrupted Emacs internals,
3855 though it'd be very unlikely.
3856
3857 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3858
3859 * character.c (Fcharacterp): Don't advertise optional ignored
3860 argument. (Bug#4026)
3861
3862 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3863
3864 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3865 key" (bug#4257).
3866
3867 * window.c (Fset_window_start): Doc fix (bug#4199).
3868 (Fset_window_hscroll): Ditto.
3869
3870 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3871
3872 Fix minor new problems caught by GCC 4.6.1.
3873 * term.c (init_tty): Remove unused local.
3874 * xsettings.c (store_monospaced_changed): Define this function only
3875 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3876 not used otherwise.
3877
3878 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3879
3880 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3881
3882 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3883
3884 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3885 are the mini-buffer and the echo area (bug#3320).
3886
3887 * term.c (init_tty): Remove support for supdup, c10 and perq
3888 terminals, which are no longer supported (bug#1482).
3889
3890 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3891
3892 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3893
3894 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3895
3896 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3897 for non-popups (Bug#3642).
3898
3899 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3900
3901 * alloc.c (reset_malloc_hooks): Protoize.
3902 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3903 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3904 * cm.c (losecursor): Likewise.
3905 * data.c (fmod): Likewise.
3906 * dispnew.c (swap_glyphs_in_rows): Likewise.
3907 * emacs.c (memory_warning_signal): Likewise.
3908 * floatfns.c (float_error): Likewise.
3909 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3910 (otf_open, font_otf_capability, generate_otf_features)
3911 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3912 Likewise.
3913 * image.c (pbm_read_file): Likewise.
3914 * indent.c (string_display_width): Likewise.
3915 * intervals.c (check_for_interval, search_for_interval)
3916 (inc_interval_count, count_intervals, root_interval)
3917 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3918 * lread.c (defalias): Likewise.
3919 * ralloc.c (r_alloc_check): Likewise.
3920 * regex.c (set_image_of_range_1, set_image_of_range)
3921 (regex_grow_registers): Likewise.
3922 * sysdep.c (strerror): Likewise.
3923 * termcap.c (valid_filename_p, tprint, main): Likewise.
3924 * tparam.c (main): Likewise.
3925 * unexhp9k800.c (run_time_remap, save_data_space)
3926 (update_file_ptrs, read_header, write_header, calculate_checksum)
3927 (copy_file, copy_rest, display_header): Likewise.
3928 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3929 Likewise.
3930 * xdisp.c (check_it): Likewise.
3931 * xfaces.c (register_color, unregister_color, unregister_colors):
3932 Likewise.
3933 * xfns.c (print_fontset_result): Likewise.
3934 * xrdb.c (member, fatal, main): Likewise.
3935
3936 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3937
3938 Fix minor problems found by static checking (Bug#9031).
3939 * chartab.c (char_table_set_range, map_sub_char_table):
3940 Remove unused locals.
3941 (uniprop_table): Now static.
3942 * composite.c (_work_char): Remove unused static var.
3943
3944 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3945
3946 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3947
3948 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3949
3950 * gtkutil.c (qttip_cb): Remove code without function.
3951
3952 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3953
3954 * w32.c (pthread_sigmask): New stub.
3955
3956 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 Use pthread_sigmask, not sigprocmask (Bug#9010).
3959 sigprocmask is portable only for single-threaded applications, and
3960 Emacs can be multi-threaded when it uses GTK.
3961 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3962 (LIBES): Use it.
3963 * callproc.c (Fcall_process):
3964 * process.c (create_process):
3965 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3966 Use pthread_sigmask, not sigprocmask.
3967
3968 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3969
3970 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3971 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3972 wrong (Bug#8591).
3973
3974 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3975
3976 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3977 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3978 (xg_hide_tooltip): Fix comment.
3979
3980 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3981 in registerServicesMenuSendTypes.
3982 (validRequestorForSendType): Don't check ns_return_types.
3983
3984 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3985 ns_return_type.
3986
3987 2011-07-08 Jason Rumney <jasonr@gnu.org>
3988
3989 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3990 SH_SHOW for hidden windows (Bug#5482).
3991
3992 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3993 frame struct members of non-existent frames (Bug#6284).
3994
3995 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3996
3997 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3998 variable firstTime not needed on OSX >= 10.6.
3999 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4000 >= 10.5. Use setKnobProportion, setDoubleValue.
4001
4002 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4003 (MAC_OS_X_VERSION_10_5): Define if not defined.
4004 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4005 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4006 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4007
4008 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4009 cString and lossyCString on OSX >= 10.4
4010
4011 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4012 sizeToFit on OSX >= 10.2.
4013
4014 * nsimage.m (allocInitFromFile): Don't use deprecated method
4015 bestRepresentationForDevice on OSX >= 10.6.
4016
4017 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4018 to avoid warning.
4019
4020 * emacs.c: Declare unexec_init_emacs_zone.
4021
4022 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4023
4024 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4025
4026 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4027 on svcsMenu (Bug#8842).
4028
4029 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4030 ns_return_types.
4031 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4032
4033 * nsterm.m (QUTF8_STRING): Declare.
4034 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4035 (validRequestorForSendType): Return type is (id).
4036 Change indexOfObjectIdenticalTo to indexOfObject.
4037 Check if we have local selection before returning self (Bug#8842).
4038 (writeSelectionToPasteboard): Put local selection into paste board
4039 if we have a local selection (Bug#8842).
4040 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4041
4042 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4043 (ns_get_local_selection): Declare.
4044
4045 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4046
4047 * keymap.c (describe_map_tree): Don't insert a double newline at
4048 the end of the buffer (bug#1169) and return whether we inserted
4049 something.
4050
4051 * callint.c (Fcall_interactively): Change "reading args" to
4052 "providing args" to try to clarify what it does (bug#1010).
4053
4054 2011-07-07 Kenichi Handa <handa@m17n.org>
4055
4056 * composite.c (composition_compute_stop_pos): Ignore a static
4057 composition starting before CHARPOS (Bug#8915).
4058
4059 * xdisp.c (handle_composition_prop): Likewise.
4060
4061 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4062
4063 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4064 (Bug#9015)
4065
4066 2011-07-07 Kenichi Handa <handa@m17n.org>
4067
4068 * character.h (unicode_category_t): New enum type.
4069
4070 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4071 (Qchar_code_property_table): New variable.
4072 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4073 (UNIPROP_COMPRESSED_FORM_P): New macros.
4074 (char_table_ascii): Uncompress the compressed values.
4075 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4076 Uncompress the compressed values.
4077 (sub_char_table_ref_and_range): Likewise.
4078 (char_table_ref_and_range): Uncompress the compressed values.
4079 (sub_char_table_set): New arg is_uniprop. Callers changed.
4080 Uncompress the compressed values.
4081 (sub_char_table_set_range): Args changed. Callers changed.
4082 (char_table_set_range): Adjuted for the above change.
4083 (map_sub_char_table): Delete args default_val and parent. Add arg
4084 top. Give decoded values to a Lisp function.
4085 (map_char_table): Adjust for the above change. Give decoded
4086 values to a Lisp function. Gcpro more variables.
4087 (uniprop_table_uncompress)
4088 (uniprop_decode_value_run_length): New functions.
4089 (uniprop_decoder, uniprop_decoder_count): New variables.
4090 (uniprop_get_decoder, uniprop_encode_value_character)
4091 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4092 New functions.
4093 (uniprop_encoder, uniprop_encoder_count): New variables.
4094 (uniprop_get_encoder, uniprop_table)
4095 (Funicode_property_table_internal, Fget_unicode_property_internal)
4096 (Fput_unicode_property_internal): New functions.
4097 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4098 Sunicode_property_table_internal, Sget_unicode_property_internal,
4099 and Sput_unicode_property_internal. Defvar_lisp
4100 char-code-property-alist.
4101
4102 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4103 Vunicode_category_table.
4104
4105 * font.c (font_range): Adjust for the change of
4106 Vunicode_category_table.
4107
4108 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4109
4110 * m/iris4d.h: Remove file, move contents ...
4111 * s/irix6-5.h: ... here.
4112
4113 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4114
4115 Remove unportable assumption about struct layout (Bug#8884).
4116 * alloc.c (mark_buffer):
4117 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4118 (clone_per_buffer_values): Don't assume that
4119 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4120 This isn't true in general, and it's particularly not true
4121 if Emacs is configured with --with-wide-int.
4122 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4123 New macros, used in the buffer.c change.
4124
4125 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4126
4127 * xsettings.c: Use both GConf and GSettings if both are available.
4128 (store_config_changed_event): Add comment.
4129 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4130 (store_tool_bar_style_changed): New functions.
4131 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4132 (struct xsettings): Move font inside HAVE_XFT.
4133 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4134 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4135 Move inside HAVE_XFT.
4136 (something_changed_gsettingsCB): Rename from something_changedCB.
4137 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4138 also.
4139 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4140 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4141 (something_changed_gconfCB): Rename from something_changedCB.
4142 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4143 (parse_settings): Move check for font inside HAVE_XFT.
4144 (read_settings, apply_xft_settings): Add comment.
4145 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4146 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4147 call store_font_name_changed.
4148 (xft_settings_event): Add comment.
4149 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4150 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4151 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4152 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4153 (xsettings_initialize): Call init_gsettings last.
4154 (xsettings_get_system_font, xsettings_get_system_normal_font):
4155 Add comment.
4156
4157 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4158
4159 Random fixes. E.g., (random) never returned negative values.
4160 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4161 subseconds part to the entropy, as that's a bit more random.
4162 Prefer signed to unsigned, since the signedness doesn't matter and
4163 in general we prefer signed. When given a limit, use a
4164 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4165 latter isn't right if USE_2_TAGS_FOR_INTS.
4166 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4167 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4168
4169 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4170
4171 * textprop.c (text_property_stickiness):
4172 Obey Vtext_property_default_nonsticky.
4173 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4174 * w32fns.c (syms_of_w32fns):
4175 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4176
4177 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4178
4179 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4180 This is more efficient than Ffile_directory_p and avoids a minor race.
4181
4182 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4183
4184 * buffer.c (Foverlay_put): Say what the return value is
4185 (bug#7835).
4186
4187 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4188 is a directory before asking whether to use the file name
4189 (bug#7564).
4190 (barf_or_query_if_file_exists): Make the "File is a directory"
4191 error be more correct.
4192
4193 * fns.c (Frequire): Remove the mention of the .gz files, since
4194 that's installation-specific, but keep the mention of
4195 `get-load-suffixes'.
4196
4197 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4198
4199 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4200 Report string overflow if the output is too long.
4201
4202 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4203
4204 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4205 (syms_of_gnutls): Remove duplicate DEFSYM for
4206 Qgnutls_bootprop_verify_hostname_error, an error for
4207 Qgnutls_bootprop_verify_error (which is no longer used).
4208
4209 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4210 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4211 Also (re)move comments that are misplaced or no longer relevant.
4212
4213 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4214
4215 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4216
4217 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4218
4219 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4220 and background color parameters if they have been changed.
4221
4222 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4223
4224 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4225
4226 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4227
4228 * xsettings.c (SYSTEM_FONT): Define only when used.
4229 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4230
4231 * keymap.c (access_keymap_1): Now static.
4232
4233 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4234
4235 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4236 leave any prefix arg for the up event (Bug#1586).
4237
4238 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4239
4240 * lread.c (syms_of_lread): Mention single symbols defined by
4241 `defvar' or `defconst' (bug#7154).
4242
4243 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4244 (Frequire): Mention get-load-suffixes.
4245
4246 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4247
4248 * window.h (window): Remove clone_number slot.
4249 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4250 Remove.
4251 (make_parent_window, make_window, saved_window)
4252 (Fset_window_configuration, save_window_save): Don't deal with
4253 clone numbers.
4254 * buffer.c (Qclone_number): Remove declaration.
4255 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4256
4257 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4258
4259 Add multiple inheritance to keymaps.
4260 * keymap.c (Fmake_composed_keymap): New function.
4261 (Fset_keymap_parent): Simplify.
4262 (fix_submap_inheritance): Remove.
4263 (access_keymap_1): New function extracted from access_keymap to handle
4264 embedded parents and handle lists of maps.
4265 (access_keymap): Use it.
4266 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4267 (Fcopy_keymap): Handle embedded parents.
4268 (Fcommand_remapping, define_as_prefix): Simplify.
4269 (Fkey_binding): Simplify.
4270 (syms_of_keymap): Move minibuffer-local-completion-map,
4271 minibuffer-local-filename-completion-map,
4272 minibuffer-local-must-match-map, and
4273 minibuffer-local-filename-must-match-map to Elisp.
4274 (syms_of_keymap): Defsubr make-composed-keymap.
4275 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4276 (parse_menu_item): Trivial simplification.
4277
4278 2011-07-01 Glenn Morris <rgm@gnu.org>
4279
4280 * Makefile.in (SETTINGS_LIBS): Fix typo.
4281
4282 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4283
4284 * coding.c (Fencode_coding_string): Record the last coding system
4285 used, as the function doc string says (bug#8738).
4286
4287 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4288
4289 * xsettings.c (store_monospaced_changed): Take new font as arg and
4290 check for change against current_mono_font.
4291 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4292 (emacs_settings_constructor, emacs_settings_get_property)
4293 (emacs_settings_set_property, emacs_settings_class_init)
4294 (emacs_settings_init, gsettings_obj): Remove.
4295 (something_changedCB): New function for HAVE_GSETTINGS.
4296 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4297 with value as argument.
4298 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4299 g_settings_new (Bug#8967). Do not create gsettings_obj.
4300 Remove calls to g_settings_bind. Connect something_changedCB to
4301 "changed".
4302
4303 * xgselect.c: Add defined (HAVE_GSETTINGS).
4304 (xgselect_initialize): Ditto.
4305
4306 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4307 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4308 xg_select.
4309
4310 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4311
4312 * eval.c (struct backtrace): Simplify and port the data structure.
4313 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4314 signed bit field, as this assumption is not portable and it makes
4315 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4316 "char debug_on_exit : 1" as this is not portable either; instead,
4317 use the portable "unsigned int debug_on_exit : 1". Remove unused
4318 member evalargs. Remove obsolete comments about cc bombing out.
4319
4320 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4321
4322 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4323 Let HAVE_GSETTINGS override HAVE_GCONF.
4324 (store_monospaced_changed): New function.
4325 (EMACS_SETTINGS): A new type derived from GObject to handle
4326 GSettings notifications.
4327 (emacs_settings_constructor, emacs_settings_get_property)
4328 (emacs_settings_set_property, emacs_settings_class_init):
4329 New functions.
4330 (gsettings_client, gsettings_obj): New variables.
4331 (GSETTINGS_SCHEMA): New define.
4332 (something_changedCB): Call store_monospaced_changed.
4333 (init_gsettings): New function.
4334 (xsettings_initialize): Call init_gsettings.
4335 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4336 to NULL.
4337
4338 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4339 GCONF_CFLAGS/LIBS.
4340
4341 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4342
4343 * window.c (resize_root_window, grow_mini_window)
4344 (shrink_mini_window): Rename Qresize_root_window to
4345 Qwindow_resize_root_window and Qresize_root_window_vertically to
4346 Qwindow_resize_root_window_vertically.
4347
4348 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4349
4350 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4351
4352 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4353
4354 * makefile.w32-in: Redesign dependencies so they reflect more
4355 clearly which files are directly included by each source file,
4356 and not through other includes.
4357
4358 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4359
4360 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4361 (sort_overlays, overlay_strings): When an overlay's clone number
4362 matches the window's clone number process the overlay even if
4363 the overlay's window property doesn't match the current window.
4364
4365 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4366 (Fwindow_hchild): Rename to Fwindow_left_child.
4367 (Fwindow_next): Rename to Fwindow_next_sibling.
4368 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4369 (resize_window_check): Rename to window_resize_check.
4370 (resize_window_apply): Rename to window_resize_apply.
4371 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4372 (Fdelete_other_windows_internal, resize_frame_windows)
4373 (Fsplit_window_internal, Fdelete_window_internal)
4374 (grow_mini_window, shrink_mini_window)
4375 (Fresize_mini_window_internal): Fix callers accordingly.
4376
4377 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4378
4379 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4380 (emacs_fixed_set_min_size): Remove.
4381 (emacs_fixed_new): Take frame as argument.
4382
4383 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4384 (_EmacsFixedPrivate): Remove minwidth/height.
4385 Add struct frame *f.
4386 (emacs_fixed_init): Initialize priv->f.
4387 (get_parent_class, emacs_fixed_set_min_size): Remove.
4388 (emacs_fixed_new): Set priv->f to argument.
4389 (emacs_fixed_get_preferred_width)
4390 (emacs_fixed_get_preferred_height): Use min_width/height from
4391 frames size_hint to set minimum and natural (Bug#8919).
4392 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4393 and use min_width/height from frames size_hint to set
4394 min_width/height (Bug#8919).
4395
4396 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4397 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4398 Fix indentation.
4399
4400 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4401
4402 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4403 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4404 called at ZV.
4405
4406 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4407
4408 * process.c (wait_reading_process_output): Bypass select if
4409 waiting for a cell while ignoring keyboard input, and input is
4410 pending. Suggested by Jan Djärv (Bug#8869).
4411
4412 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4413
4414 Use gnulib's dup2 module instead of rolling our own.
4415 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4416
4417 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4418
4419 * dispnew.c (scrolling_window): Before scrolling, turn off a
4420 mouse-highlight in the window being scrolled.
4421
4422 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4423
4424 Move DEFSYM to lisp.h and use everywhere.
4425
4426 * character.h (DEFSYM): Move declaration...
4427 * lisp.h (DEFSYM): ...here.
4428
4429 * gnutls.c:
4430 * minibuf.c:
4431 * w32menu.c:
4432 * w32proc.c:
4433 * w32select.c: Don't include character.h.
4434
4435 * alloc.c (syms_of_alloc):
4436 * buffer.c (syms_of_buffer):
4437 * bytecode.c (syms_of_bytecode):
4438 * callint.c (syms_of_callint):
4439 * casefiddle.c (syms_of_casefiddle):
4440 * casetab.c (init_casetab_once):
4441 * category.c (init_category_once, syms_of_category):
4442 * ccl.c (syms_of_ccl):
4443 * cmds.c (syms_of_cmds):
4444 * composite.c (syms_of_composite):
4445 * dbusbind.c (syms_of_dbusbind):
4446 * dired.c (syms_of_dired):
4447 * dispnew.c (syms_of_display):
4448 * doc.c (syms_of_doc):
4449 * editfns.c (syms_of_editfns):
4450 * emacs.c (syms_of_emacs):
4451 * eval.c (syms_of_eval):
4452 * fileio.c (syms_of_fileio):
4453 * fns.c (syms_of_fns):
4454 * frame.c (syms_of_frame):
4455 * fringe.c (syms_of_fringe):
4456 * insdel.c (syms_of_insdel):
4457 * keymap.c (syms_of_keymap):
4458 * lread.c (init_obarray, syms_of_lread):
4459 * macros.c (syms_of_macros):
4460 * msdos.c (syms_of_msdos):
4461 * print.c (syms_of_print):
4462 * process.c (syms_of_process):
4463 * search.c (syms_of_search):
4464 * sound.c (syms_of_sound):
4465 * syntax.c (init_syntax_once, syms_of_syntax):
4466 * terminal.c (syms_of_terminal):
4467 * textprop.c (syms_of_textprop):
4468 * undo.c (syms_of_undo):
4469 * w32.c (globals_of_w32):
4470 * window.c (syms_of_window):
4471 * xdisp.c (syms_of_xdisp):
4472 * xfaces.c (syms_of_xfaces):
4473 * xfns.c (syms_of_xfns):
4474 * xmenu.c (syms_of_xmenu):
4475 * xsettings.c (syms_of_xsettings):
4476 * xterm.c (syms_of_xterm): Use DEFSYM.
4477
4478 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4479
4480 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4481
4482 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4483
4484 Integer and buffer overflow fixes (Bug#8873).
4485
4486 * print.c (printchar, strout): Check for string overflow.
4487 (PRINTPREPARE, printchar, strout):
4488 Don't set size unless allocation succeeds.
4489
4490 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4491 for sizes. Check for string overflow more accurately.
4492 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4493
4494 * macros.c: Integer and buffer overflow fixes.
4495 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4496 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4497 Use ptrdiff_t, not int, for sizes.
4498 Don't increment bufsize until after realloc succeeds.
4499 Check for size-calculation overflow.
4500 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4501
4502 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4503
4504 * lread.c: Integer overflow fixes.
4505 (read_integer): Radix is now EMACS_INT, not int,
4506 to improve quality of diagnostics for out-of-range radices.
4507 Calculate buffer size correctly for out-of-range radices.
4508 (read1): Check for integer overflow in radices, and in
4509 read-circle numbers.
4510 (read_escape): Avoid int overflow.
4511 (Fload, openp, read_buffer_size, read1)
4512 (substitute_object_recurse, read_vector, read_list, map_obarray):
4513 Use ptrdiff_t, not int, for sizes.
4514 (read1): Use EMACS_INT, not int, for sizes.
4515 Check for size overflow.
4516
4517 * image.c (cache_image): Check for size arithmetic overflow.
4518
4519 * lread.c: Integer overflow issues.
4520 (saved_doc_string_size, saved_doc_string_length)
4521 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4522 Now ptrdiff_t, not int.
4523 (read1): Don't assume doc string length fits in int. Check for
4524 out-of-range doc string lengths.
4525 (read_list): Don't assume file position fits in int.
4526 (read_escape): Check for hex character overflow.
4527
4528 2011-06-22 Leo Liu <sdl.web@gmail.com>
4529
4530 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4531 Move to minibuffer.el.
4532
4533 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4534
4535 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4536 The following patches are for when GLYPH_DEBUG && !XASSERT.
4537 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4538 * dispnew.c (flush_stdout):
4539 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4540 Mark as externally visible.
4541 * dispnew.c (check_window_matrix_pointers): Now static.
4542 * dispnew.c (window_to_frame_vpos):
4543 * xfns.c (unwind_create_frame):
4544 * xterm.c (x_check_font): Remove unused local.
4545 * scroll.c (CHECK_BOUNDS):
4546 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4547 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4548 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4549 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4550 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4551 Now static.
4552 (debug_method_add): Use va_list and vsprintf rather than relying
4553 on undefined behavior with wrong number of arguments.
4554 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4555 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4556 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4557 since we're not interested in debugging glyphs with old libraries.
4558 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4559 GCC 4.6.0's static checking.
4560
4561 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4562
4563 Integer overflow and signedness fixes (Bug#8873).
4564 A few related buffer overrun fixes, too.
4565
4566 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4567
4568 * dispextern.h (struct face.stipple):
4569 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4570 (x_bitmap_mask, x_allocate_bitmap_record)
4571 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4572 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4573 (x_create_bitmap_from_xpm_data):
4574 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4575 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4576 (.bitmaps_last):
4577 * xfaces.c (load_pixmap):
4578 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4579 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4580 (.bitmaps_last, struct x_output.icon_bitmap):
4581 Use ptrdiff_t, not int, for bitmap indexes.
4582 (x_allocate_bitmap_record): Check for size overflow.
4583 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4584
4585 Use ptrdiff_t, not int, for overlay counts.
4586 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4587 * editfns.c (overlays_around, get_pos_property):
4588 * textprop.c (get_char_property_and_overlay):
4589 * xdisp.c (next_overlay_change, note_mouse_highlight):
4590 * xfaces.c (face_at_buffer_position):
4591 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4592 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4593 (Fnext_overlay_change, Fprevious_overlay_change)
4594 (mouse_face_overlay_overlaps, Foverlays_in):
4595 Use ptrdiff_t, not int, for sizes.
4596 (overlays_at, overlays_in): Check for size-calculation overflow.
4597
4598 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4599
4600 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4601 (x_session_initialize): Do not assume string length fits in int.
4602
4603 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4604 This is unlikely, but can occur if DPI is outlandish.
4605
4606 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4607 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4608
4609 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4610 * xrdb.c (magic_file_p, search_magic_path):
4611 Omit last arg SUFFIX; it was always 0. All callers changed.
4612 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4613
4614 * xfont.c (xfont_match): Avoid need for strlen.
4615
4616 * xfns.c: Don't assume strlen fits in int.
4617 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4618
4619 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4620 not unsigned long, as we prefer signed integers. All callers changed.
4621 Detect integer overflow in repeat count.
4622 (message_dolog): Don't assume print length fits in 39 bytes.
4623 (display_mode_element): Don't assume strlen fits in int.
4624
4625 * termcap.c: Don't assume sizes fit in int and never overflow.
4626 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4627 (gobble_line): Check for size-calculation overflow.
4628
4629 * minibuf.c (Fread_buffer):
4630 * lread.c (intern, intern_c_string):
4631 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4632 Don't assume string length fits in int.
4633
4634 * keyboard.c (parse_tool_bar_item):
4635 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4636
4637 * font.c: Don't assume string length fits in int.
4638 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4639 Use ptrdiff_t, not int.
4640 (font_intern_prop): Don't assume string length fits in int.
4641 Don't assume integer property fits in fixnum.
4642 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4643
4644 * filelock.c: Fix some buffer overrun and integer overflow issues.
4645 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4646 Reformulate so as not to need the command string.
4647 Invoke gzip -cd rather than gunzip, as it's more portable.
4648 (lock_info_type, lock_file_1, lock_file):
4649 Don't assume pid_t and time_t fit in unsigned long.
4650 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4651 (current_lock_owner): Prefer signed type for sizes.
4652 Use memcpy, not strncpy, where memcpy is what is really wanted.
4653 Don't assume (via atoi) that time_t and pid_t fit in int.
4654 Check for time_t and/or pid_t out of range, e.g., via a network share.
4655 Don't alloca where an auto var works fine.
4656
4657 * fileio.c: Fix some integer overflow issues.
4658 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4659 Don't assume string length fits in int.
4660 (directory_file_name): Don't assume string length fits in long.
4661 (make_temp_name): Don't assume pid fits in int, or that its print
4662 length is less than 20.
4663
4664 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4665
4666 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4667
4668 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4669
4670 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4671 We prefer signed integers, even for size calculations.
4672
4673 * emacs.c: Don't assume string length fits in 'int'.
4674 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4675 (main): Don't invoke strlen when not needed.
4676
4677 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4678 (XD_DEBUG_MESSAGE): Don't waste a byte.
4679
4680 * callproc.c (getenv_internal_1, getenv_internal)
4681 (Fgetenv_internal):
4682 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4683
4684 * lread.c (invalid_syntax): Omit length argument.
4685 All uses changed. This doesn't fix a bug, but it simplifies the
4686 code away from its former Hollerith-constant appearance, and it's
4687 one less 'int' to worry about when looking at integer-overflow issues.
4688 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4689
4690 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4691 This didn't break anything, but it didn't help either.
4692 It's confusing to put a bogus integer in a place where the actual
4693 value does not matter.
4694 (LIST_END_P): Remove unused macro and its bogus comment.
4695 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4696
4697 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4698 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4699 implementation.
4700 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4701 We prefer signed types, and the value cannot exceed the EMACS_INT
4702 range anyway (because otherwise the length would not be representable).
4703 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4704 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4705 This avoids a GCC warning when WIDE_EMACS_INT.
4706
4707 * indent.c (sane_tab_width): New function.
4708 (current_column, scan_for_column, Findent_to, position_indentation)
4709 (compute_motion): Use it. This is just for clarity.
4710 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4711
4712 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4713
4714 * lisp.h (lint_assume): New macro.
4715 * composite.c (composition_gstring_put_cache):
4716 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4717
4718 * editfns.c, insdel.c:
4719 Omit unnecessary forward decls, to simplify future changes.
4720
4721 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4722
4723 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4724
4725 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4726 Use much-faster test for byte-length change.
4727 Don't assume string byte-length fits in 'int'.
4728 Check that character arg fits in 'int'.
4729 (mapcar1): Declare byte as byte, for clarity.
4730
4731 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4732
4733 * fns.c (concat): Catch string overflow earlier.
4734 Do not rely on integer wraparound.
4735
4736 * dispextern.h (struct it.overlay_strings_charpos)
4737 (struct it.selective): Now EMACS_INT, not int.
4738 * xdisp.c (forward_to_next_line_start)
4739 (back_to_previous_visible_line_start)
4740 (reseat_at_next_visible_line_start, next_element_from_buffer):
4741 Don't arbitrarily truncate the value of 'selective' to int.
4742
4743 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4744
4745 * composite.c: Don't truncate sizes to 'int'.
4746 (composition_gstring_p, composition_reseat_it)
4747 (composition_adjust_point): Use EMACS_INT, not int.
4748 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4749 not EMACS_UINT, for indexes.
4750
4751 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4752
4753 * buffer.c: Include <verify.h>.
4754 (struct sortvec.priority, struct sortstr.priority):
4755 Now EMACS_INT, not int.
4756 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4757 (struct sortstr.size, record_overlay_string)
4758 (struct sortstrlist.size, struct sortlist.used):
4759 Don't truncate size to int.
4760 (record_overlay_string): Check for size-calculation overflow.
4761 (init_buffer_once): Check at compile-time, not run-time.
4762
4763 2011-06-22 Jim Meyering <meyering@redhat.com>
4764
4765 Don't leak an XBM-image-sized buffer
4766 * image.c (xbm_load): Free the image buffer after using it.
4767
4768 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4769
4770 Port to Sun C.
4771 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4772 that Sun C diagnosed.
4773 * fns.c (secure_hash): Fix pointer signedness issue.
4774 * intervals.c (static_offset_intervals): New function.
4775 (offset_intervals): Use it.
4776
4777 2011-06-21 Leo Liu <sdl.web@gmail.com>
4778
4779 * deps.mk (fns.o):
4780 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4781 sha512.h.
4782
4783 * fns.c (secure_hash): Rename from crypto_hash_function and change
4784 the first arg to accept symbols.
4785 (Fsecure_hash): New primitive.
4786 (syms_of_fns): New symbols.
4787
4788 2011-06-20 Deniz Dogan <deniz@dogan.se>
4789
4790 * process.c (Fset_process_buffer): Clarify return value in
4791 docstring.
4792
4793 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4794
4795 * dispnew.c (add_window_display_history): Use BVAR.
4796
4797 * xdisp.c (debug_method_add): Use BVAR.
4798 (check_window_end, dump_glyph_matrix, dump_glyph)
4799 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4800
4801 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4802 Likewise.
4803
4804 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4805 check till after the cache is created in init_frame_faces.
4806
4807 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4808
4809 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4810
4811 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4812
4813 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4814 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4815 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4816
4817 Improve buffer-overflow checking (Bug#8873).
4818 * fileio.c (Finsert_file_contents):
4819 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4820 Remove the old (too-loose) buffer overflow checks.
4821 They weren't needed, since make_gap checks for buffer overflow.
4822 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4823 The old code merely checked for Emacs fixnum overflow, and relied
4824 on undefined (wraparound) behavior. The new code avoids undefined
4825 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4826
4827 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4828 Tune. Don't use wider integers than needed. Don't use alloca.
4829 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4830
4831 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4832
4833 * insdel.c, lisp.h (buffer_overflow): New function.
4834 (insert_from_buffer_1, replace_range, replace_range_2):
4835 * insdel.c (make_gap_larger):
4836 * editfns.c (Finsert_char):
4837 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4838
4839 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4840
4841 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4842
4843 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4844
4845 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4846 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4847
4848 * fileio.c: Don't assume EMACS_INT fits in off_t.
4849 (emacs_lseek): New static function.
4850 (Finsert_file_contents, Fwrite_region): Use it.
4851 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4852
4853 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4854
4855 * fns.c: Don't overflow int when computing a list length.
4856 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4857 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4858 truncation on 64-bit hosts. Check for QUIT every
4859 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4860 faster and is responsive enough.
4861 (Flength): Report an error instead of overflowing an integer.
4862 (Fsafe_length): Return a float if the value is not representable
4863 as a fixnum. This shouldn't happen except in contrived situations.
4864 (Fnthcdr, Fsort): Don't assume list length fits in int.
4865 (Fcopy_sequence): Don't assume vector length fits in int.
4866
4867 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4868 (header_size, word_size): New constants.
4869 (allocate_vectorlike): Don't check size overflow here.
4870 (allocate_vector): Check it here instead, since this is the only
4871 caller of allocate_vectorlike that could cause overflow.
4872 Check that the new vector's length is representable as a fixnum.
4873
4874 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4875 The previous code was bogus. For example, next_almost_prime (32)
4876 returned 39, which is undesirable as it is a multiple of 3; and
4877 next_almost_prime (24) returned 25, which is a multiple of 5 so
4878 why was the code bothering to check for multiples of 7?
4879
4880 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4881
4882 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4883
4884 Variadic C functions now count arguments with ptrdiff_t.
4885 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4886 Back then I didn't know that the Emacs coding style prefers signed int.
4887 Also, in the meantime I found a few more instances where arguments
4888 were being counted with int, which may truncate counts on 64-bit
4889 machines, or EMACS_INT, which may be unnecessarily wide.
4890 * lisp.h (struct Lisp_Subr.function.aMANY)
4891 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4892 Arg counts are now ptrdiff_t, not size_t.
4893 All variadic functions and their callers changed accordingly.
4894 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4895 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4896 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4897 * callint.c (Fcall_interactively): Check arg count for overflow,
4898 to avoid potential buffer overrun. Use signed char, not 'int',
4899 for 'varies' array, so that we needn't bother to check its size
4900 calculation for overflow.
4901 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4902 * eval.c (apply_lambda):
4903 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4904 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4905 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4906
4907 * callint.c (Fcall_interactively): Don't use index var as event count.
4908
4909 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4910 * mem-limits.h (SIZE): Remove; no longer used.
4911
4912 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4913
4914 Remove unnecessary casts.
4915 * xterm.c (x_term_init):
4916 * xfns.c (x_set_border_pixel):
4917 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4918 These aren't needed now that we assume ANSI C.
4919
4920 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4921 It's more likely to cause problems (due to unsigned overflow)
4922 than to cure them.
4923
4924 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4925
4926 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4927
4928 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4929
4930 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4931
4932 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4933
4934 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4935
4936 GLYPH_CODE_FACE returns EMACS_INT, not int.
4937 * dispextern.h (merge_faces):
4938 * xfaces.c (merge_faces):
4939 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4940 Don't assume EMACS_INT fits in int.
4941
4942 * character.h (CHAR_VALID_P): Remove unused parameter.
4943 * fontset.c, lisp.h, xdisp.c: All uses changed.
4944
4945 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4946
4947 * fns.c (concat): Minor tuning based on overflow analysis.
4948 This doesn't fix any bugs. Use int to hold character, instead
4949 of constantly refetching from Emacs object. Use XFASTINT, not
4950 XINT, for value known to be a character. Don't bother comparing
4951 a single byte to 0400, as it's always less.
4952
4953 * floatfns.c (Fexpt):
4954 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4955
4956 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4957 for characters.
4958
4959 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4960
4961 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4962 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4963 incorrectly succeed when S was a string, because 4294967386 was
4964 truncated before it was used.
4965
4966 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4967 Otherwise, an out-of-range integer could cause undefined behavior
4968 on a 64-bit host.
4969
4970 * composite.c: Use int, not EMACS_INT, for characters.
4971 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4972 EMACS_INT, for values that are known to be in character range.
4973 This doesn't fix any bugs but is the usual style inside Emacs and
4974 may generate better code on 32-bit machines.
4975
4976 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4977 This is for reasons similar to the recent CHAR_STRING fix.
4978 * charset.c (Fencode_char): Check that character arg is actually
4979 a character. Pass an int to ENCODE_CHAR.
4980 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4981 wider than 'int', as a compile-time check to prevent future regressions
4982 in this area.
4983
4984 * character.c (char_string): Remove unnecessary casts.
4985
4986 Make sure a 64-bit char is never passed to CHAR_STRING.
4987 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4988 by silently ignoring the top 32 bits, allowing some values
4989 that were far too large to be valid characters.
4990 * character.h: Include <verify.h>.
4991 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4992 arguments are no wider than unsigned, as a compile-time check
4993 to prevent future regressions in this area.
4994 * data.c (Faset):
4995 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4996 (Fsubst_char_in_region):
4997 * fns.c (concat):
4998 * xdisp.c (decode_mode_spec_coding):
4999 Adjust to CHAR_STRING's new requirement.
5000 * editfns.c (Finsert_char, Fsubst_char_in_region):
5001 * fns.c (concat): Check that character args are actually
5002 characters. Without this test, these functions did the wrong
5003 thing with wildly out-of-range values on 64-bit hosts.
5004
5005 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5006 These casts should not be needed on 32-bit hosts, either.
5007 * keyboard.c (read_char):
5008 * lread.c (Fload): Remove casts to unsigned.
5009
5010 * lisp.h (UNSIGNED_CMP): New macro.
5011 This fixes comparison bugs on 64-bit hosts.
5012 (ASCII_CHAR_P): Use it.
5013 * casefiddle.c (casify_object):
5014 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5015 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5016 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5017 * dispextern.h (FACE_FROM_ID):
5018 * keyboard.c (read_char): Use UNSIGNED_CMP.
5019
5020 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5021 not to EMACS_INT, to avoid GCC warning.
5022
5023 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5024
5025 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5026 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5027 isn't needed on 32-bit machines.
5028
5029 * buffer.c (Fgenerate_new_buffer_name):
5030 Use EMACS_INT for count, not int.
5031 (advance_to_char_boundary): Return EMACS_INT, not int.
5032
5033 * data.c (Qcompiled_function): Now static.
5034
5035 * window.c (window_body_lines): Now static.
5036
5037 * image.c (gif_load): Rename local to avoid shadowing.
5038
5039 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5040 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5041 * alloc.c (make_save_value): Integer argument is now of type
5042 ptrdiff_t, not int.
5043 (mark_object): Use ptrdiff_t, not int.
5044 * lisp.h (pD): New macro.
5045 * print.c (print_object): Use it.
5046
5047 * alloc.c: Use EMACS_INT, not int, to count objects.
5048 (total_conses, total_markers, total_symbols, total_vector_size)
5049 (total_free_conses, total_free_markers, total_free_symbols)
5050 (total_free_floats, total_floats, total_free_intervals)
5051 (total_intervals, total_strings, total_free_strings):
5052 Now EMACS_INT, not int. All uses changed.
5053 (Fgarbage_collect): Compute overall total using a double, so that
5054 integer overflow is less likely to be a problem. Check for overflow
5055 when converting back to an integer.
5056 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5057 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5058 These were 'int' variables that could overflow on 64-bit hosts;
5059 they were never used, so remove them instead of repairing them.
5060 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5061 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5062 Previously, this ceilinged at INT_MAX, but that doesn't work on
5063 64-bit machines.
5064 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5065
5066 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5067 (allocate_vectorlike): Check for ptrdiff_t overflow.
5068 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5069 when a (possibly-narrower) signed value would do just as well.
5070 We prefer using signed arithmetic, to avoid comparison confusion.
5071
5072 * alloc.c: Catch some string size overflows that we were missing.
5073 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5074 for convenience in STRING_BYTES_MAX.
5075 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5076 The definition here is exact; the one in lisp.h was approximate.
5077 (allocate_string_data): Check for string overflow. This catches
5078 some instances we weren't catching before. Also, it catches
5079 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5080 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5081 and ptrdiff_t and EMACS_INT are both 64 bits.
5082
5083 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5084 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5085 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5086
5087 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5088
5089 * alloc.c (Fmake_string): Check for out-of-range init.
5090
5091 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5092
5093 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5094
5095 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5096
5097 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5098 xg_get_default_scrollbar_width.
5099
5100 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5101 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5102 (style_changed_cb): Call update_theme_scrollbar_width and call
5103 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5104 all frames (Bug#8505).
5105 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5106 Call gtk_window_set_resizable if HAVE_GTK3.
5107 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5108 and height if HAVE_GTK3 (Bug#8505).
5109 (scroll_bar_width_for_theme): New variable.
5110 (update_theme_scrollbar_width): New function.
5111 (xg_get_default_scrollbar_width): Move code to
5112 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5113 (xg_initialize): Call update_theme_scrollbar_width.
5114
5115 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5116
5117 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5118
5119 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5120
5121 * frame.c (make_frame): Call other_buffer_safely instead of
5122 other_buffer.
5123
5124 * window.c (temp_output_buffer_show): Call display_buffer with
5125 second argument Vtemp_buffer_show_specifiers and reset latter
5126 immediately after the call.
5127 (Vtemp_buffer_show_specifiers): New variable.
5128 (auto_window_vscroll_p, next_screen_context_lines)
5129 (Vscroll_preserve_screen_position): Remove leading asterisks from
5130 doc-strings.
5131
5132 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5133
5134 Fix minor problems found by GCC 4.6.0 static checking.
5135 * buffer.c (Qclone_number): Remove for now, as it's unused.
5136 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5137 (record_buffer): Remove unused local.
5138 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5139 (set_frame_buffer_list): Remove; unused.
5140 * frame.h (other_visible_frames): Remove decl.
5141 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5142 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5143 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5144 if HAVE_GPM.
5145 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5146 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5147 Define only if HAVE_GPM.
5148 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5149 (update_hints_inhibit): Remove; never set. All uses removed.
5150 * widgetprv.h (emacsFrameClassRec): Remove decl.
5151 * window.c (delete_deletable_window): Now returns void, since it
5152 wasn't returning anything.
5153 (compare_window_configurations): Remove unused locals.
5154 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5155 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5156 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5157 the same widths as pointers. This follows up on the 2011-05-06 patch.
5158 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5159 * xterm.h: Likewise.
5160 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5161
5162 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5163
5164 * makefile.w32-in: Update dependencies.
5165 (LISP_H): Add lib/intprops.h.
5166
5167 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5168
5169 * image.c (gif_load): Add animation frame delay to the metadata.
5170 (syms_of_image): Use DEFSYM. New symbol `delay'.
5171
5172 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5173
5174 * window.c (delete_deletable_window): Re-add.
5175 (Fset_window_configuration): Rewrite to handle dead buffers and
5176 consequently deletable windows.
5177 (window_tree, Fwindow_tree): Remove. Supply functionality in
5178 window.el.
5179 (compare_window_configurations): Simplify code.
5180
5181 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5182
5183 * image.c (imagemagick_load_image): Fix type mismatch.
5184 (Fimagemagick_types): Likewise.
5185
5186 * window.h (replace_buffer_in_windows): Declare.
5187
5188 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5189
5190 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5191 Qclone_number. Remove external declaration of Qdelete_window.
5192 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5193 code.
5194 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5195 Run Qbuffer_list_update_hook if allowed.
5196 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5197 buffer list implementation.
5198 (other_buffer_safely): New function.
5199 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5200 calls to replace_buffer_in_windows and
5201 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5202 if allowed.
5203 (record_buffer): Inhibit quitting and rewrite using quittable
5204 functions. Run Qbuffer_list_update_hook if allowed.
5205 (Frecord_buffer, Funrecord_buffer): New functions.
5206 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5207 Move switch-to-buffer to window.el.
5208 (bury-buffer): Move to window.el.
5209 (Vbuffer_list_update_hook): New variable.
5210
5211 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5212 section.
5213
5214 * window.h (resize_frame_windows): Move up in code.
5215 (Fwindow_frame): Remove EXFUN.
5216 (replace_buffer_in_all_windows): Remove prototype.
5217 (replace_buffer_in_windows_safely): Add prototype.
5218
5219 * window.c: Declare Qdelete_window static again. Move down
5220 declaration of select_count.
5221 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5222 (Fother_window): Move to window.el.
5223 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5224 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5225 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5226 window.el.
5227 (replace_buffer_in_windows): Implement by calling
5228 Qreplace_buffer_in_windows.
5229 (replace_buffer_in_all_windows): Remove with some functionality
5230 moved into replace_buffer_in_windows_safely.
5231 (replace_buffer_in_windows_safely): New function.
5232 (select_window_norecord, select_frame_norecord): Move in front
5233 of run_window_configuration_change_hook. Remove now obsolete
5234 declarations.
5235 (Fset_window_buffer): Rewrite doc-string.
5236 Call Qrecord_window_buffer.
5237 (keys_of_window): Move binding for other-window to window.el.
5238
5239 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5240
5241 * dispextern.h (struct image): Replace data member, whose int_val
5242 and ptr_val fields were not used by anything, with a single
5243 lisp_val object.
5244
5245 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5246 (gif_clear_image, gif_load, imagemagick_load_image)
5247 (gs_clear_image, gs_load): Callers changed.
5248
5249 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5250
5251 * buffer.h: Include <time.h>, for time_t.
5252 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5253
5254 Fix minor problems found by static checking.
5255
5256 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5257
5258 Make identifiers static if they are not used in other modules.
5259 * data.c (Qcompiled_function, Qframe, Qvector):
5260 * image.c (QimageMagick, Qsvg):
5261 * minibuf.c (Qmetadata):
5262 * window.c (resize_window_check, resize_root_window): Now static.
5263 * window.h (resize_window_check, resize_root_window): Remove decls.
5264
5265 * window.c (window_deletion_count, delete_deletable_window):
5266 Remove; unused.
5267 (window_body_lines): Now static.
5268 (Fdelete_other_windows_internal): Mark vars as initialized.
5269 Make sure 'resize_failed' is initialized.
5270 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5271 (resize_window_apply): Remove unused local.
5272 * window.h (delete_deletable_window): Remove decl.
5273
5274 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5275 (imagemagick_load_image): Fix pointer signedness problem by changing
5276 last arg from unsigned char * to char *. All uses changed.
5277 Also, fix a local for similar reasons.
5278 Remove unused locals. Remove locals to avoid shadowing.
5279 (fn_rsvg_handle_free): Remove; unused.
5280 (svg_load, svg_load_image): Fix pointer signedness problem.
5281 (imagemagick_load_image): Don't use garbage pointer image_wand.
5282
5283 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5284
5285 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5286
5287 * image.c (gif_load): Fix omitted cast error introduced by
5288 2011-06-06 change.
5289
5290 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5291
5292 * window.h (resize_proportionally, orig_total_lines)
5293 (orig_top_line): Remove from window structure.
5294 (set_window_height, set_window_width, change_window_heights)
5295 (Fdelete_window): Remove prototypes.
5296 (resize_frame_windows): Remove duplicate declaration.
5297
5298 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5299
5300 * window.h (resize_frame_windows, resize_window_check)
5301 (delete_deletable_window, resize_root_window)
5302 (resize_frame_windows): Declare prototypes.
5303
5304 * window.c (resize_window_apply): Make definition be "static" to
5305 match the prototype.
5306
5307 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5308
5309 * window.c: Remove declarations of Qwindow_size_fixed,
5310 window_min_size_1, window_min_size_2, window_min_size,
5311 size_window, window_fixed_size_p, enlarge_window, delete_window.
5312 Remove static from declaration of Qdelete_window, it's
5313 temporarily needed by Fbury_buffer.
5314 (replace_window): Don't assign orig_top_line and
5315 orig_total_lines.
5316 (Fdelete_window, delete_window): Remove. Window deletion is
5317 handled by window.el.
5318 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5319 Replace Fdelete_window calls with calls to Qdelete_window.
5320 (Fdelete_other_windows): Remove. Deleting other windows is
5321 handled by window.el.
5322 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5323 handled in window.el.
5324 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5325 Window minimum sizes are handled in window.el.
5326 (shrink_windows, size_window, set_window_height)
5327 (set_window_width, change_window_heights, window_height)
5328 (window_width, CURBEG, CURSIZE, enlarge_window)
5329 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5330 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5331 handled in window.el.
5332 (make_dummy_parent): Rename to make_parent_window and give it a
5333 second argument horflag.
5334 (make_window): Don't set resize_proportionally any more.
5335 (Fsplit_window): Remove. Windows are split in window.el.
5336 (save_restore_action, save_restore_orig_size)
5337 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5338 Resize mini windows in window.el.
5339 (grow_mini_window, shrink_mini_window): Implement by calling
5340 Qresize_root_window_vertically, resize_window_check and
5341 resize_window_apply.
5342 (saved_window, Fset_window_configuration, save_window_save):
5343 Do not handle orig_top_line, orig_total_lines, and
5344 resize_proportionally.
5345 (window_min_height, window_min_width): Move to window.el.
5346 (keys_of_window): Move bindings for delete-other-windows,
5347 split-window, delete-window and enlarge-window to window.el.
5348
5349 * buffer.c: Temporarily extern Qdelete_window.
5350 (Fbury_buffer): Temporarily call Qdelete_window instead of
5351 Fdelete_window (Fbury_buffer will move to window.el soon).
5352
5353 * frame.c (set_menu_bar_lines_1): Remove code handling
5354 orig_top_line and orig_total_lines.
5355
5356 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5357 set_window_height but set heights directly.
5358 (change_frame_size_1): Use resize_frame_windows.
5359
5360 * xdisp.c (init_xdisp): Don't use set_window_height but set
5361 heights directly.
5362
5363 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5364 Use resize_frame_windows instead of change_window_heights and run
5365 run_window_configuration_change_hook.
5366
5367 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5368 instead of change_window_heights and run
5369 run_window_configuration_change_hook.
5370
5371 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5372
5373 * window.c (replace_window): Rename second argument REPLACEMENT to
5374 NEW. New third argument SETFLAG. Rewrite.
5375 (delete_window, make_dummy_parent): Call replace_window with
5376 third argument 1.
5377 (window_list_1): Move down in code.
5378 (run_window_configuration_change_hook): Move set_buffer part
5379 before select_frame_norecord part in order to unwind correctly.
5380 Rename count1 to count.
5381 (recombine_windows, delete_deletable_window, resize_root_window)
5382 (Fdelete_other_windows_internal)
5383 (Frun_window_configuration_change_hook, make_parent_window)
5384 (resize_window_check, resize_window_apply, Fresize_window_apply)
5385 (resize_frame_windows, Fsplit_window_internal)
5386 (Fdelete_window_internal, Fresize_mini_window_internal):
5387 New functions.
5388 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5389
5390 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5391
5392 * window.h (window): Add some new members to window structure -
5393 normal_lines, normal_cols, new_total, new_normal, clone_number,
5394 splits, nest, prev_buffers, next_buffers.
5395 (WINDOW_TOTAL_SIZE): Move here from window.c.
5396 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5397
5398 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5399 Remove.
5400 (make_dummy_parent): Set new members of windows structure.
5401 (make_window): Move down in code. Handle new members of window
5402 structure.
5403 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5404 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5405 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5406 (Fset_window_prev_buffers, Fwindow_next_buffers)
5407 (Fset_window_next_buffers, Fset_window_clone_number):
5408 New functions.
5409 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5410 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5411 Doc-string fixes.
5412 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5413 Argument WINDOW can be now internal window too.
5414 (Fwindow_use_time): Move up in code.
5415 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5416 Rewrite doc-string.
5417 (Fset_window_configuration, saved_window)
5418 (Fcurrent_window_configuration, save_window_save): Handle new
5419 members of window structure.
5420 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5421 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5422 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5423 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5424 Qget_mru_window, Qresize_root_window,
5425 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5426 Qauto_buffer_name; staticpro them.
5427
5428 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5429
5430 * window.c (Fwindow_total_size, Fwindow_left_column)
5431 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5432 (Fwindow_list_1): New functions.
5433 (window_box_text_cols): Replace with window_body_cols.
5434 (Fwindow_width, Fscroll_left, Fscroll_right):
5435 Use window_body_cols instead of window_box_text_cols.
5436 (delete_window, Fset_window_configuration):
5437 Call delete_all_subwindows with window as argument.
5438 (delete_all_subwindows): Take a window as argument and not a
5439 structure. Rewrite.
5440 (window_loop): Remove handling of GET_LRU_WINDOW and
5441 GET_LARGEST_WINDOW.
5442 (Fget_lru_window, Fget_largest_window): Move to window.el.
5443
5444 * window.h: Extern window_body_cols instead of
5445 window_box_text_cols. delete_all_subwindows now takes a
5446 Lisp_Object as argument.
5447
5448 * indent.c (compute_motion, Fcompute_motion):
5449 Use window_body_cols instead of window_box_text_cols.
5450
5451 * frame.c (delete_frame): Call delete_all_subwindows with root
5452 window as argument.
5453
5454 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5455
5456 * fns.c (Fputhash): Document return value.
5457
5458 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5459
5460 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5461
5462 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5463
5464 Cons<->int and similar integer overflow fixes (Bug#8794).
5465
5466 Check for overflow when converting integer to cons and back.
5467 * charset.c (Fdefine_charset_internal, Fdecode_char):
5468 Use cons_to_unsigned to catch overflow.
5469 (Fencode_char): Use INTEGER_TO_CONS.
5470 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5471 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5472 * data.c (long_to_cons, cons_to_long): Remove.
5473 (cons_to_unsigned, cons_to_signed): New functions.
5474 These signal an error for invalid or out-of-range values.
5475 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5476 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5477 * font.c (Ffont_variation_glyphs):
5478 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5479 * lisp.h: Include <intprops.h>.
5480 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5481 (cons_to_signed, cons_to_unsigned): New decls.
5482 (long_to_cons, cons_to_long): Remove decls.
5483 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5484 (Fprimitive_undo): Use CONS_TO_INTEGER.
5485 * xfns.c (Fx_window_property): Likewise.
5486 * xselect.c: Include <limits.h>.
5487 (x_own_selection, selection_data_to_lisp_data):
5488 Use INTEGER_TO_CONS.
5489 (x_handle_selection_request, x_handle_selection_clear)
5490 (x_get_foreign_selection, Fx_disown_selection_internal)
5491 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5492 (lisp_data_to_selection_data): Use cons_to_unsigned.
5493 (x_fill_property_data): Use cons_to_signed.
5494 Report values out of range.
5495
5496 Check for buffer and string overflow more precisely.
5497 * buffer.h (BUF_BYTES_MAX): New macro.
5498 * lisp.h (STRING_BYTES_MAX): New macro.
5499 * alloc.c (Fmake_string):
5500 * character.c (string_escape_byte8):
5501 * coding.c (coding_alloc_by_realloc):
5502 * doprnt.c (doprnt):
5503 * editfns.c (Fformat):
5504 * eval.c (verror):
5505 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5506 since they may not be the same number.
5507 * editfns.c (Finsert_char):
5508 * fileio.c (Finsert_file_contents):
5509 Likewise for BUF_BYTES_MAX.
5510
5511 * image.c: Use ptrdiff_t, not int, for sizes.
5512 (slurp_file): Switch from int to ptrdiff_t.
5513 All uses changed.
5514 (slurp_file): Check that file size fits in both size_t (for
5515 malloc) and ptrdiff_t (for sanity and safety).
5516
5517 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5518 if b->modtime has its maximal value.
5519
5520 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5521
5522 Don't assume time_t can fit into int.
5523 * buffer.h (struct buffer.modtime): Now time_t, not int.
5524 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5525 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5526
5527 Minor fixes for signed vs unsigned integers.
5528 * character.h (MAYBE_UNIFY_CHAR):
5529 * charset.c (maybe_unify_char):
5530 * keyboard.c (read_char, reorder_modifiers):
5531 XINT -> XFASTINT, since the integer must be nonnegative.
5532 * ftfont.c (ftfont_spec_pattern):
5533 * keymap.c (access_keymap, silly_event_symbol_error):
5534 XUINT -> XFASTINT, since the integer must be nonnegative.
5535 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5536 since it makes no difference and we prefer signed.
5537 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5538 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5539 nonnegative.
5540
5541 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5542
5543 * window.h (Fwindow_frame): Declare.
5544
5545 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5546
5547 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5548 (SPARE_MEMORY): Always define.
5549 (LARGE_REQUEST): Remove.
5550 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5551
5552 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5553
5554 * lisp.h: Move EXFUNS for Fframe_root_window,
5555 Fframe_first_window and Fset_frame_selected_window to window.h.
5556
5557 * window.h: Move EXFUNS for Fframe_root_window,
5558 Fframe_first_window and Fset_frame_selected_window here from
5559 lisp.h.
5560
5561 * frame.c (Fwindow_frame, Fframe_first_window)
5562 (Fframe_root_window, Fframe_selected_window)
5563 (Fset_frame_selected_window): Move to window.c.
5564 (Factive_minibuffer_window): Move to minibuf.c.
5565 (Fother_visible_frames_p): New function.
5566
5567 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5568
5569 * window.c (decode_window, decode_any_window): Move up in code.
5570 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5571 (inhibit_frame_unsplittable): Remove unused variable.
5572 (Fwindow_buffer): Move up and rewrite doc-string.
5573 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5574 (Fwindow_prev): New functions.
5575 (Fwindow_frame): Move here from frame.c. Accept any window as
5576 argument.
5577 (Fframe_root_window, Fframe_first_window)
5578 (Fframe_selected_window): Move here from frame.c. Accept frame
5579 or arbitrary window as argument. Update doc-strings.
5580 (Fminibuffer_window): Move up in code.
5581 (Fwindow_minibuffer_p): Move up in code and simplify.
5582 (Fset_frame_selected_window): Move here from frame.c.
5583 Marginal rewrite.
5584 (Fselected_window, select_window, Fselect_window): Move up in
5585 code. Minor doc-string fixes.
5586
5587 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5588
5589 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5590 Do not assume that spare memory exists; that assumption is valid
5591 only if SYSTEM_MALLOC.
5592 (LARGE_REQUEST): New macro, so that the issue of large requests
5593 is separated from the issue of spare memory.
5594
5595 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5596
5597 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5598 format. (Bug#8806)
5599
5600 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5601
5602 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5603 before statements.
5604
5605 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5606
5607 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5608
5609 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5610
5611 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5612 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5613
5614 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5615
5616 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5617
5618 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5619
5620 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5621 (x_clipboard_manager_save): Add return value.
5622 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5623 New error handlers.
5624 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5625 Obey Vx_select_enable_clipboard_manager. Catch errors in
5626 x_clipboard_manager_save (Bug#8779).
5627 (Vx_select_enable_clipboard_manager): New variable.
5628 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5629
5630 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5631
5632 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5633
5634 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5635
5636 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5637 in the current matrix if keep_current_p is non-zero.
5638
5639 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5640
5641 * bidi.c (bidi_level_of_next_char): Fix last change.
5642
5643 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5644
5645 Support bidi reordering of text covered by display properties.
5646
5647 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5648 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5649 (bidi_cache_search, bidi_cache_iterator_state)
5650 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5651 (bidi_level_of_next_char, bidi_move_to_visually_next):
5652 Support character positions inside a run of characters covered by a
5653 display string.
5654 (bidi_paragraph_init, bidi_resolve_explicit_1)
5655 (bidi_level_of_next_char): Call bidi_fetch_char and
5656 bidi_fetch_char_advance instead of FETCH_CHAR and
5657 FETCH_CHAR_ADVANCE.
5658 (bidi_init_it): Initialize new members.
5659 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5660 definitions.
5661 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5662 instead of using explicit *_CHAR codes.
5663 (bidi_resolve_explicit, bidi_resolve_weak):
5664 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5665 bidirectional text is supported only in multibyte buffers.
5666 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5667 it to initialize the frame_window_p member of struct bidi_it.
5668 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5669 (bidi_resolve_explicit, bidi_resolve_weak)
5670 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5671 bidi_it->nchars is non-positive.
5672 (bidi_level_of_next_char): Don't try to lookup the cache for the
5673 next/previous character if nothing is cached there yet, or if we
5674 were just reseat()'ed to a new position.
5675
5676 * xdisp.c (set_cursor_from_row): Set start and stop points
5677 according to the row's direction when priming the loop that looks
5678 for the glyph on which to display cursor.
5679 (single_display_spec_intangible_p): Function deleted.
5680 (display_prop_intangible_p): Reimplement to call
5681 handle_display_spec instead of single_display_spec_intangible_p.
5682 Accept 3 additional arguments needed by handle_display_spec.
5683 This fixes incorrect cursor motion across display property with complex
5684 values: lists, `(when COND...)' forms, etc.
5685 (single_display_spec_string_p): Support property values that are
5686 lists with the argument STRING its top-level element.
5687 (display_prop_string_p): Fix the condition for processing a
5688 property that is a list to be consistent with handle_display_spec.
5689 (handle_display_spec): New function, refactored from the
5690 last portion of handle_display_prop.
5691 (compute_display_string_pos): Accept additional argument
5692 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5693 value of a `display' property is a "replacing spec".
5694 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5695 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5696 the display property, but just return a value indicating whether
5697 the display property will replace the characters it covers.
5698 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5699 frame_window_p members of struct bidi_it.
5700 (compute_display_string_pos, compute_display_string_end):
5701 New functions.
5702 (push_it): Accept second argument POSITION, where pop_it should
5703 jump to continue iteration.
5704 (reseat_1): Initialize bidi_it.disp_pos.
5705
5706 * keyboard.c (adjust_point_for_property): Adjust the call to
5707 display_prop_intangible_p to its new signature.
5708
5709 * dispextern.h (struct bidi_it): New member frame_window_p.
5710 (bidi_init_it): Update prototypes.
5711 (display_prop_intangible_p): Update prototype.
5712 (compute_display_string_pos, compute_display_string_end):
5713 Declare prototypes.
5714 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5715 EMACS_INT.
5716
5717 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5718
5719 Malloc failure behavior now depends on size of allocation.
5720 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5721 * lisp.h: Change signatures accordingly.
5722 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5723 All callers changed. (Bug#8762)
5724
5725 * gnutls.c: Use Emacs's memory allocators.
5726 Without this change, the gnutls library would invoke malloc etc.
5727 directly, which causes problems on non-SYNC_INPUT hosts, and which
5728 runs afoul of improving memory_full behavior. (Bug#8761)
5729 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5730 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5731 xfree instead of the default malloc, realloc, free.
5732 (Fgnutls_boot): No need to check for memory allocation failure,
5733 since xmalloc does that for us.
5734
5735 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5736 * category.c (hash_get_category_set):
5737 * ccl.c (ccl_driver):
5738 * charset.c (Fdefine_charset_internal):
5739 * charset.h (struct charset.hash_index):
5740 * composite.c (get_composition_id, gstring_lookup_cache)
5741 (composition_gstring_put_cache):
5742 * composite.h (struct composition.hash_index):
5743 * dispextern.h (struct image.hash):
5744 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5745 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5746 (hashfn_equal, hashfn_user_defined, make_hash_table)
5747 (maybe_resize_hash_table, hash_lookup, hash_put)
5748 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5749 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5750 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5751 * image.c (make_image, search_image_cache, lookup_image)
5752 (xpm_put_color_table_h):
5753 * lisp.h (struct Lisp_Hash_Table):
5754 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5755 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5756 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5757 * alloc.c (allocate_vectorlike):
5758 Check for overflow in vector size calculations.
5759 * ccl.c (ccl_driver):
5760 Check for overflow when converting EMACS_INT to int.
5761 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5762 need to be updated by these changes.
5763 * fns.c (make_hash_table, maybe_resize_hash_table):
5764 Check for integer overflow with large hash tables.
5765 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5766 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5767 (SXHASH_REDUCE): New macro.
5768 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5769 Use it instead of discarding useful hash info with large hash values.
5770 (sxhash_float): New function.
5771 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5772 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5773 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5774 Rewrite to use FIXNUM_BITS, as this simplifies things.
5775 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5776 Adjust signatures to match updated version of code.
5777 (consing_since_gc): Now EMACS_INT, since a single hash table can
5778 use more than INT_MAX bytes.
5779
5780 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5781
5782 Make it possible to build with GCC-4.6+ -O2 -flto.
5783
5784 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5785
5786 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5787
5788 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5789 Call minibuffer-inactive-mode.
5790
5791 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5792
5793 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5794 Update dependencies.
5795
5796 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5797
5798 * data.c (init_data): Remove code for UTS, this system is not
5799 supported anymore.
5800
5801 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5802
5803 Don't force ./temacs to start in terminal mode.
5804
5805 * frame.c (make_initial_frame): Initialize faces in all cases, not
5806 only when CANNOT_DUMP is defined.
5807 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5808
5809 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5810
5811 * dispnew.c (add_window_display_history): Use const for the string
5812 pointer. Remove declaration, not needed.
5813
5814 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5815
5816 Use 'inline', not 'INLINE'.
5817 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5818 * alloc.c, fontset.c (INLINE): Remove.
5819 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5820 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5821 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5822 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5823 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5824
5825 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5826
5827 Make it possible to run ./temacs.
5828
5829 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5830 syms_of_callproc does the same thing. Remove test for
5831 "initialized", do it in the caller.
5832 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5833
5834 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5835
5836 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5837 (read_minibuf): Use get_minibuffer.
5838 (syms_of_minibuf): Use DEFSYM.
5839 (Qmetadata): New var.
5840 * data.c (Qbuffer): Don't make it static.
5841 (syms_of_data): Use DEFSYM.
5842
5843 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5844
5845 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5846 (CCL_CODE_MIN): New macro.
5847
5848 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5849
5850 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5851
5852 * eval.c (Qdebug): Now static.
5853 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5854 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5855 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5856
5857 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5858
5859 * image.c: Various fixes to ImageMagick code comments.
5860 (Fimagemagick_types): Doc fix.
5861
5862 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5863
5864 Minor fixes prompted by GCC 4.6.0 warnings.
5865
5866 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5867
5868 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5869 (x_clipboard_manager_save_all): Move extern decl to ...
5870 * xterm.h: ... here, so that it can be checked for consistency.
5871
5872 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5873
5874 * xselect.c (x_clipboard_manager_save_frame)
5875 (x_clipboard_manager_save_all): New functions.
5876 (Fx_clipboard_manager_save): Lisp function deleted.
5877
5878 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5879 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5880
5881 * xterm.h: Update prototype.
5882
5883 2011-05-28 William Xu <william.xwl@gmail.com>
5884
5885 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5886 exiting (Bug#8239).
5887
5888 2011-05-28 Jim Meyering <meyering@redhat.com>
5889
5890 Avoid a sign-extension bug in crypto_hash_function.
5891 * fns.c (to_uchar): Define.
5892 (crypto_hash_function): Use it to convert some newly-signed
5893 variables to unsigned, to avoid sign-extension bugs. For example,
5894 without this change, (md5 "truc") would evaluate to
5895 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5896 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5897 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5898
5899 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5900
5901 Integer overflow fixes.
5902
5903 * dbusbind.c: Serial number integer overflow fixes.
5904 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5905 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5906 to hold a serial number that is too large for a fixnum.
5907 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5908 Check for serial numbers out of range. Decode any serial number
5909 that was so large that it became a float. (Bug#8722)
5910
5911 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5912 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5913 Use XFASTINT rather than XUINT when numbers are nonnegative.
5914 (xd_append_arg, Fdbus_method_return_internal):
5915 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5916 arguments, check that Lisp number is nonnegative, rather than
5917 silently wrapping negative numbers around. (Bug#8722)
5918 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5919 (Bug#8722)
5920
5921 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5922
5923 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5924
5925 ccl: Add integer overflow checks.
5926 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5927 (IN_INT_RANGE): New macros.
5928 (ccl_driver): Use them to check for integer overflow when
5929 decoding a CCL program. Many of the new checks are whether XINT (x)
5930 fits in int; it doesn't always, on 64-bit hosts. The new version
5931 doesn't catch all possible integer overflows, but it's an
5932 improvement. (Bug#8719)
5933
5934 * alloc.c (make_event_array): Use XINT, not XUINT.
5935 There's no need for unsigned here.
5936
5937 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5938 This follows up to the 2011-05-06 change that substituted uintptr_t
5939 for EMACS_INT. This case wasn't caught back then.
5940
5941 Rework Fformat to avoid integer overflow issues.
5942 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5943 now (part of C89). Include <verify.h>.
5944 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5945 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5946 (Fformat): Avoid the prepass trying to compute sizes; it was only
5947 approximate and thus did not catch overflow reliably. Instead, walk
5948 through the format just once, formatting and computing sizes as we go,
5949 checking for integer overflow at every step, and allocating a larger
5950 buffer as needed. Keep track separately whether the format is
5951 multibyte. Keep only the most-recently calculated precision, rather
5952 than them all. Record whether each argument has been converted to
5953 string. Use EMACS_INT, not int, for byte and char and arg counts.
5954 Support field widths and precisions larger than INT_MAX. Avoid
5955 sprintf's undefined behavior with conversion specifications such as %#d
5956 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5957 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5958 formatting out-of-range floating point numbers with int
5959 formats. (Bug#8668)
5960
5961 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5962
5963 * data.c: Avoid integer truncation in expressions involving floats.
5964 * data.c: Include <intprops.h>.
5965 (arith_driver): When there's an integer overflow in an expression
5966 involving floating point, convert the integers to floating point
5967 so that the resulting value does not suffer from catastrophic
5968 integer truncation. For example, on a 64-bit host (* 4
5969 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5970 Do not rely on undefined behavior after integer overflow.
5971
5972 merge count_size_as_multibyte, parse_str_to_multibyte
5973 * character.c, character.h (count_size_as_multibyte):
5974 Rename from parse_str_to_multibyte; all uses changed.
5975 Check for integer overflow.
5976 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5977 since it's now a duplicate of the other. This is more of
5978 a character than a buffer op, so better that it's in character.c.
5979 * fns.c, print.c: Adjust to above changes.
5980
5981 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5982
5983 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5984
5985 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5986
5987 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5988 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5989 (x_clipboard_manager_save): Now static.
5990 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5991
5992 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5993 (crypto_hash_function): Now static.
5994 Fix pointer signedness problems. Avoid unnecessary initializations.
5995
5996 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5997
5998 * termhooks.h (Vselection_alist): Make it terminal-local.
5999
6000 * terminal.c (create_terminal): Initialize it.
6001
6002 * xselect.c: Support for clipboard managers.
6003 (Vselection_alist): Move to termhooks.h as terminal-local var.
6004 (LOCAL_SELECTION): New macro.
6005 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6006 (symbol_to_x_atom): Remove gratuitous arg.
6007 (x_handle_selection_request, lisp_data_to_selection_data)
6008 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6009 (x_own_selection, x_get_local_selection, x_convert_selection):
6010 New arg, specifying work frame. Use terminal-local Vselection_alist.
6011 (some_frame_on_display): Delete unused function.
6012 (Fx_own_selection_internal, Fx_get_selection_internal)
6013 (Fx_disown_selection_internal, Fx_selection_owner_p)
6014 (Fx_selection_exists_p): New optional frame arg.
6015 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6016 (x_handle_selection_clear): Don't treat other terminals with the
6017 same keyboard specially. Use the terminal-local Vselection_alist.
6018 (x_clear_frame_selections): Use Frun_hook_with_args.
6019
6020 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6021
6022 * xterm.h: Add support for those atoms.
6023
6024 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6025
6026 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6027 (converted_selections, conversion_fail_tag): New global variables.
6028 (x_selection_request_lisp_error): Free the above.
6029 (x_get_local_selection): Remove unnecessary code.
6030 (x_reply_selection_request): Args changed; handle arbitrary array
6031 of converted selections stored in converted_selections.
6032 Separate the XChangeProperty and SelectionNotify steps.
6033 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6034 (x_convert_selection): New function.
6035 (x_handle_selection_event): Simplify.
6036 (x_get_foreign_selection): Don't ignore incoming requests while
6037 waiting for an answer; this will fail when we implement
6038 SAVE_TARGETS, and seems unnecessary anyway.
6039 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6040 (Vx_sent_selection_functions): Doc fix.
6041
6042 2011-05-26 Leo Liu <sdl.web@gmail.com>
6043
6044 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6045
6046 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6047
6048 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6049
6050 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6051 for fringe update if it has periodic bitmap.
6052 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6053 and fringe_bitmap_periodic_p.
6054
6055 * fringe.c (get_fringe_bitmap_data): New function.
6056 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6057 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6058 row. Mark glyph row for fringe update if periodicity changed.
6059
6060 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6061 for fringe update unless it has periodic bitmap.
6062
6063 2011-05-25 Kenichi Handa <handa@m17n.org>
6064
6065 * xdisp.c (get_next_display_element): Set correct it->face_id for
6066 a static composition.
6067
6068 2011-05-24 Leo Liu <sdl.web@gmail.com>
6069
6070 * deps.mk (fns.o):
6071 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6072
6073 * fns.c (crypto_hash_function, Fsha1): New function.
6074 (Fmd5): Use crypto_hash_function.
6075 (syms_of_fns): Add Ssha1.
6076
6077 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6078
6079 * gnutls.c: Remove unused macros.
6080 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6081 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6082 Remove macros that are defined and never used.
6083 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6084
6085 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6086
6087 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6088 (Fx_get_selection_internal): Minor cleanup.
6089 (Fx_own_selection_internal): Rename arguments for consistency with
6090 select.el.
6091
6092 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6093
6094 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6095
6096 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6097
6098 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6099
6100 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6101
6102 * dispnew.c (scrolling_window): Don't exclude the case that the
6103 last enabled row in the desired matrix touches the bottom boundary.
6104
6105 2011-05-21 Glenn Morris <rgm@gnu.org>
6106
6107 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6108 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6109 and add some more files.
6110
6111 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6112
6113 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6114 report_file_error introduced by the change from 2011-05-07.
6115
6116 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6117
6118 * systime.h (Time): Define only if emacs is defined.
6119 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6120 where the include path doesn't have X11/X.h by default. See
6121 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6122
6123 2011-05-20 Kenichi Handa <handa@m17n.org>
6124
6125 * composite.c (find_automatic_composition): Fix previous change.
6126
6127 2011-05-20 Glenn Morris <rgm@gnu.org>
6128
6129 * lisp.mk: New file, split from Makefile.in.
6130 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6131 (shortlisp): Remove.
6132 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6133
6134 2011-05-19 Glenn Morris <rgm@gnu.org>
6135
6136 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6137 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6138 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6139 (lisp): Set the order to that of loadup.el.
6140 (shortlisp): Make it a copy of $lisp.
6141 (SOME_MACHINE_LISP): Remove.
6142 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6143 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6144
6145 2011-05-18 Kenichi Handa <handa@m17n.org>
6146
6147 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6148 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6149 (find_automatic_composition): Mostly rewrite for efficiency.
6150
6151 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6152
6153 * makefile.w32-in: Update dependencies.
6154
6155 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6156
6157 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6158 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6159
6160 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6161
6162 Fix some integer overflow issues, such as string length overflow.
6163
6164 * insdel.c (count_size_as_multibyte): Check for string overflow.
6165
6166 * character.c (lisp_string_width): Check for string overflow.
6167 Use EMACS_INT, not int, for string indexes and lengths; in
6168 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6169 the resulting string length overflows an EMACS_INT; instead,
6170 report a string overflow if no precision given. When checking for
6171 precision exhaustion, use a check that cannot possibly have
6172 integer overflow. (Bug#8675)
6173 * character.h (lisp_string_width): Adjust to new signature.
6174
6175 * alloc.c (string_overflow): New function.
6176 (Fmake_string): Use it. This doesn't change behavior, but saves
6177 a few bytes and will simplify future changes.
6178 * character.c (string_escape_byte8): Likewise.
6179 * lisp.h (string_overflow): New decl.
6180
6181 Fixups, following up to the user-interface timestamp change.
6182 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6183 for UI timestamps, instead of unsigned long.
6184 * msdos.c (mouse_get_pos): Likewise.
6185 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6186 * w32gui.h (Time): Define by including "systime.h" rather than by
6187 declaring it ourselves. (Bug#8664)
6188
6189 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6190 * image.c (clear_image_cache): Likewise.
6191
6192 * term.c (term_mouse_position): Don't assume time_t wraparound.
6193
6194 Be more systematic about user-interface timestamps.
6195 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6196 and sometimes 'EMACS_UINT', to represent these timestamps.
6197 This change causes it to use 'Time' uniformly, as that's what X uses.
6198 This makes the code easier to follow, and makes it easier to catch
6199 integer overflow bugs such as Bug#8664.
6200 * frame.c (Fmouse_position, Fmouse_pixel_position):
6201 Use Time, not unsigned long, for user-interface timestamps.
6202 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6203 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6204 * keyboard.h (last_event_timestamp): Likewise.
6205 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6206 * menu.h (xmenu_show): Likewise.
6207 * term.c (term_mouse_position): Likewise.
6208 * termhooks.h (struct input_event.timestamp): Likewise.
6209 (struct terminal.mouse_position_hook): Likewise.
6210 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6211 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6212 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6213 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6214 what it was before.
6215 * menu.h, termhooks.h: Include "systime.h", for Time.
6216
6217 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6218 Don't assume that the difference between two unsigned long values
6219 can fit into an integer. At this point, we know button_down_time
6220 <= event->timestamp, so the difference must be nonnegative, so
6221 there's no need to cast the result if double-click-time is
6222 nonnegative, as it should be; check that it's nonnegative, just in
6223 case. This bug is triggered when events are more than 2**31 ms
6224 apart (about 25 days). (Bug#8664)
6225
6226 * xselect.c (last_event_timestamp): Remove duplicate decl.
6227 (x_own_selection): Remove needless cast to unsigned long.
6228
6229 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6230 that always fit in int. Use a sentinel instead of a counter, to
6231 avoid a temp and to allay GCC's concerns about possible int overflow.
6232 * frame.h (struct frame): Use int for menu_bar_items_used
6233 instead of EMACS_INT, since it always fits in int.
6234
6235 * menu.c (grow_menu_items): Check for int overflow.
6236
6237 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6238
6239 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6240 Before, the code was not consistent. These values cannot exceed
6241 2**31 - 1 so there's no need to make them unsigned.
6242 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6243 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6244 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6245 as modifiers.
6246 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6247
6248 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6249 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6250 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6251 presumably because the widths might not match.
6252
6253 * window.c (size_window): Avoid needless test at loop start.
6254
6255 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6256
6257 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6258
6259 2011-05-12 Drew Adams <drew.adams@oracle.com>
6260
6261 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6262
6263 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6264
6265 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6266 `width' to `bar_area_x' and `bar_area_width', respectively.
6267 (x_scroll_run): Take account of fringe background extension.
6268
6269 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6270 Rename local vars `left' and `width' to `bar_area_x' and
6271 `bar_area_width', respectively.
6272 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6273 background extension.
6274
6275 2011-05-10 Jim Meyering <meyering@redhat.com>
6276
6277 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6278
6279 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6280
6281 * image.c (Finit_image_library): Return t for built-in image types,
6282 like pbm and xbm. (Bug#8640)
6283
6284 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6285
6286 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6287
6288 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6289
6290 * w32console.c (Fset_screen_color): Doc fix.
6291 (Fget_screen_color): New function.
6292 (syms_of_ntterm): Defsubr it.
6293
6294 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6295 unlink the temporary file if Fcall_process didn't create it in the
6296 first place.
6297 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6298 child process will be redirected to a file specified with `:file'.
6299 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6300 cue to call_process_cleanup not to close that handle.
6301
6302 2011-05-07 Ben Key <bkey76@gmail.com>
6303
6304 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6305 one of two shell specific rules, either bootstrap-temacs-CMD or
6306 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6307 to the previous implementation of the bootstrap-temacs rule.
6308 The bootstrap-temacs-CMD rule is similar to the previous
6309 implementation of the bootstrap-temacs rule except that it
6310 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6311 variable.
6312
6313 These changes, along with some changes to nt/configure.bat,
6314 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6315 earlier fix to add support for --cflags and --ldflags options
6316 that include quotes so that it works whether make uses cmd or
6317 sh as the shell.
6318
6319 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6320
6321 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6322 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6323 is a constant.
6324 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6325 a string. Handle both cases.
6326 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6327 (Fdbus_register_method): Use Qinvalid_function.
6328
6329 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6330
6331 * makefile.w32-in: Update dependencies.
6332 (LISP_H): Add inttypes.h and stdin.h.
6333 (PROCESS_H): Add unistd.h.
6334
6335 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6336
6337 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6338 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6339
6340 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6341
6342 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6343
6344 * term.c (vfatal): Remove stray call to va_end.
6345 It's not needed and the C Standard doesn't allow it here anyway.
6346
6347 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6348 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6349
6350 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6351 bytes.
6352
6353 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6354
6355 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6356
6357 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6358
6359 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6360
6361 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6362
6363 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6364 * charset.c (Fdefine_charset_internal): Don't initialize
6365 charset.code_space[15]. The value was garbage, on hosts with
6366 32-bit int (Bug#8600).
6367
6368 * lread.c (read_integer): Be more consistent with string-to-number.
6369 Use string_to_number to do the actual conversion; this avoids
6370 rounding errors and fixes some other screwups. Without this fix,
6371 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6372 (digit_to_number): Move earlier, for benefit of read_integer.
6373 Return -1 if the digit is out of range for the base, -2 if it is
6374 not a digit in any supported base. (Bug#8602)
6375
6376 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6377
6378 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6379 to match comment at start of function. This also removes a
6380 GCC warning about overflow in a 32+64-bit port.
6381
6382 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6383
6384 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6385 Reported by Stefan Monnier in
6386 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6387 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6388 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6389
6390 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6391 (EMACS_UINTPTR): Likewise, with uintptr_t.
6392
6393 * lisp.h: Prefer 64-bit EMACS_INT if available.
6394 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6395 on 32-bit hosts that have 64-bit int, so that they can access
6396 large files.
6397 However, temporarily disable this change unless the temporary
6398 symbol WIDE_EMACS_INT is defined.
6399
6400 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6401
6402 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6403 This removes an assumption that EMACS_INT and long are the same
6404 width as pointers. The assumption is true for Emacs porting targets
6405 now, but we want to make other targets possible.
6406 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6407 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6408 In the rest of the code, change types of integers that hold casted
6409 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6410 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6411 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6412 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6413 No need to cast type when ORing.
6414 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6415 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6416 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6417 assume EMACS_INT is the same width as char *.
6418 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6419 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6420 Remove no-longer-needed casts.
6421 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6422 (xg_tool_bar_help_callback, xg_make_tool_item):
6423 Use EMACS_INTPTR to hold an integer
6424 that will be cast to void *; this can avoid a GCC warning
6425 if EMACS_INT is not the same width as void *.
6426 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6427 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6428 (current_message_1, set_message_1):
6429 Use a local to convert to proper width without a cast.
6430 * xmenu.c (dialog_selection_callback): Likewise.
6431
6432 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6433 Also, don't assume VALBITS / RAND_BITS is less than 5,
6434 and don't rely on undefined behavior when shifting a 1 left into
6435 the sign bit.
6436 * lisp.h (get_random): Change signature to match.
6437
6438 * lread.c (hash_string): Use size_t, not int, for hash computation.
6439 Normally we prefer signed values; but hashing is special, because
6440 it's better to use unsigned division on hash table sizes so that
6441 the remainder is nonnegative. Also, size_t is the natural width
6442 for hashing into memory. The previous code used 'int', which doesn't
6443 retain enough info to hash well into very large tables.
6444 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6445
6446 * dbusbind.c: Don't possibly lose pointer info when converting.
6447 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6448 Use XPNTR rather than XHASH, so that the high-order bits of
6449 the pointer aren't lost when converting through void *.
6450
6451 * eval.c (Fautoload): Don't double-shift a pointer.
6452
6453 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6454
6455 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6456
6457 * gnutls.c (DEF_GNUTLS_FN):
6458 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6459
6460 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6461
6462 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6463 marker. (Bug#8610)
6464
6465 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6466
6467 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6468 New version that can reserve upto 2GB of heap space.
6469
6470 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6471
6472 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6473
6474 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6475
6476 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6477 `gnutls_certificate_set_x509_key_file'.
6478
6479 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6480
6481 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6482 Update dependencies.
6483
6484 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6485
6486 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6487 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6488 Remove unused parameter `fildes'.
6489 * process.c (read_process_output, send_process): Don't pass it.
6490
6491 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6492
6493 Fix previous change: the library cache is defined in w32.c.
6494 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6495 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6496
6497 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6498
6499 Implement dynamic loading of GnuTLS on Windows.
6500
6501 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6502 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6503 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6504 Declare.
6505
6506 * gnutls.c (Qgnutls_dll): Define.
6507 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6508 (gnutls_*): Declare function pointers.
6509 (init_gnutls_functions): New function to initialize function pointers.
6510 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6511 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6512 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6513 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6514 (emacs_gnutls_write, emacs_gnutls_read)
6515 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6516 (Fgnutls_available_p): New function.
6517 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6518 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6519 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6520
6521 * image.c: Include w32.h.
6522 (Vimage_type_cache): Delete.
6523 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6524 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6525 (w32_delayed_load): Move to w32.c.
6526
6527 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6528
6529 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6530 (w32_delayed_load): Move from image.c. When loading a library, record
6531 its filename in the :loaded-from property of the library id.
6532 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6533 Initialize and staticpro them.
6534 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6535
6536 * process.c: Include lisp.h before w32.h, not after.
6537 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6538 instead of gnutls_record_check_pending.
6539
6540 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6541
6542 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6543
6544 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6545 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6546 as passed in.
6547
6548 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6549
6550 * xterm.c (x_set_frame_alpha): Do not set property on anything
6551 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6552
6553 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6554
6555 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6556
6557 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6558
6559 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6560 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6561 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6562 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6563 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6564 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6565 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6566 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6567 (Qgnutls_bootprop_callbacks_verify): Make static.
6568
6569 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6570
6571 * callproc.c: Indentation fixup.
6572
6573 * sysdep.c (wait_for_termination_1): Make static.
6574 (wait_for_termination, interruptible_wait_for_termination):
6575 Move after wait_for_termination_1.
6576
6577 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6578
6579 * sysdep.c (interruptible_wait_for_termination): New function
6580 which is like wait_for_termination, but allows keyboard
6581 interruptions.
6582
6583 * callproc.c (Fcall_process): Add (:file "file") as an option for
6584 the STDOUT buffer.
6585 (Fcall_process_region): Ditto.
6586
6587 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6588
6589 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6590 rather than `XVECTOR (FOO)->size'.
6591
6592 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6593 inttypes.h, as a gnulib replacement is used if it not available in
6594 system headers.
6595
6596 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6597
6598 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6599 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6600 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6601
6602 * coding.c (coding_alloc_by_realloc): Error out if destination
6603 will grow beyond MOST_POSITIVE_FIXNUM.
6604 (decode_coding_emacs_mule): Abort if there isn't enough place in
6605 charbuf for the composition carryover bytes. Reserve an extra
6606 space for up to 2 characters produced in a loop.
6607 (decode_coding_iso_2022): Abort if there isn't enough place in
6608 charbuf for the composition carryover bytes.
6609
6610 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6611
6612 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6613 aborting when %lld or %lll format is passed.
6614 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6615 %llo or %llx format is passed. (Bug#8545)
6616
6617 * window.c (window_scroll_line_based): Use a marker instead of
6618 simple variables to record original value of point. (Bug#7952)
6619
6620 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6621 produced by %s or %c overflows available buffer space. (Bug#8545)
6622
6623 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6624
6625 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6626 (SIZE_MAX): Move defn after all includes, as they might #define it.
6627
6628 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6629
6630 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6631
6632 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6633
6634 * keyboard.c (Qdelayed_warnings_hook): Define.
6635 (command_loop_1): Run `delayed-warnings-hook'
6636 if Vdelayed_warnings_list is non-nil.
6637 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6638 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6639
6640 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6641
6642 * doprnt.c (doprnt): Don't return value smaller than the buffer
6643 size if the message was truncated. (Bug#8545).
6644
6645 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6646
6647 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6648 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6649
6650 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6651
6652 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6653
6654 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6655
6656 * makefile.w32-in: Update dependencies.
6657
6658 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6659
6660 Improve `doprnt' and its usage. (Bug#8545)
6661 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6662 `format_end'. Remove support for %l as a conversion specifier.
6663 Don't use xrealloc. Improve diagnostics when the %l size modifier
6664 is used. Update the commentary.
6665
6666 * eval.c (verror): Simplify calculation of size_t.
6667
6668 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6669 messages.
6670
6671 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6672
6673 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6674 change.
6675
6676 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6677
6678 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6679 This makes this file independent of the recent pseudovector change.
6680
6681 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6682
6683 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6684
6685 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6686 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6687 Remove unused local.
6688 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6689
6690 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6691 GCC 4.6.0 optimizes based on type-based alias analysis.
6692 For example, if b is of type struct buffer * and v of type struct
6693 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6694 != &v->size, and therefore "v->size = 1; b->size = 2; return
6695 v->size;" must therefore return 1. This assumption is incorrect
6696 for Emacs, since it type-puns struct Lisp_Vector * with many other
6697 types. To fix this problem, this patch adds a new type struct
6698 vectorlike_header that documents the constraints on layout of vectors
6699 and pseudovectors, and helps optimizing compilers not get fooled
6700 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6701 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6702 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6703 the size member.
6704 (XSETPVECTYPE): Rewrite in terms of new macro.
6705 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6706 This is a bit clearer, and further avoids the possibility of
6707 undesirable aliasing.
6708 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6709 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6710 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6711 since Lisp_Subr is a special case (no "next" field).
6712 (ASIZE): Now uses header.size rather than size.
6713 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6714 to avoid the hassle of writing XVECTOR (foo)->header.size.
6715 (struct vectorlike_header): New type.
6716 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6717 object, to help avoid aliasing.
6718 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6719 (SUBRP): Likewise, since Lisp_Subr is a special case.
6720 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6721 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6722 (struct Lisp_Hash_Table): Combine first two members into a single
6723 struct vectorlike_header member. All uses of "size" and "next" members
6724 changed to be "header.size" and "header.next".
6725 * buffer.h (struct buffer): Likewise.
6726 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6727 * frame.h (struct frame): Likewise.
6728 * process.h (struct Lisp_Process): Likewise.
6729 * termhooks.h (struct terminal): Likewise.
6730 * window.c (struct save_window_data, struct saved_window): Likewise.
6731 * window.h (struct window): Likewise.
6732 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6733 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6734 * buffer.c (init_buffer_once): Likewise.
6735 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6736 special case.
6737 * process.c (Fformat_network_address): Use local var for size,
6738 for brevity.
6739
6740 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6741
6742 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6743 * data.c (atof): Remove decl; no longer used or needed.
6744 (digit_to_number): Move to lread.c.
6745 (Fstring_to_number): Use new string_to_number function, to be
6746 consistent with how the Lisp reader treats infinities and NaNs.
6747 Do not assume that floating-point numbers represent EMACS_INT
6748 without losing information; this is not true on most 64-bit hosts.
6749 Avoid double-rounding errors, by insisting on integers when
6750 parsing non-base-10 numbers, as the documentation specifies.
6751 * lisp.h (string_to_number): New decl, replacing ...
6752 (isfloat_string): Remove.
6753 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6754 (read1): Do not accept +. and -. as integers; this
6755 appears to have been a coding error. Similarly, do not accept
6756 strings like +-1e0 as floating point numbers. Do not report
6757 overflow for integer overflows unless the base is not 10 which
6758 means we have no simple and reliable way to continue.
6759 Break out the floating-point parsing into a new
6760 function string_to_number, so that Fstring_to_number parses
6761 floating point numbers consistently with the Lisp reader.
6762 (digit_to_number): Move here from data.c. Make it static inline.
6763 (E_CHAR, EXP_INT): Remove, replacing with ...
6764 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6765 (string_to_number): New function, replacing isfloat_string.
6766 This function checks for valid syntax and produces the resulting
6767 Lisp float number too. Rework it so that string-to-number
6768 no longer mishandles examples like "1.0e+". Use strtoumax,
6769 so that overflow for non-base-10 numbers is reported only when
6770 there's no portable and simple way to convert to floating point.
6771
6772 * textprop.c (set_text_properties_1): Rewrite for clarity,
6773 and to avoid GCC warning about integer overflow.
6774
6775 * intervals.h (struct interval): Use EMACS_INT for members
6776 where EMACS_UINT might cause problems. See
6777 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6778 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6779 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6780 All uses changed.
6781 (offset_intervals): Tell GCC not to worry about length overflow
6782 when negating a negative length.
6783
6784 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6785 (overrun_check_free): Likewise.
6786
6787 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6788 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6789 word size.
6790
6791 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6792 (gnutls_make_error): Rename local to avoid shadowing.
6793 (gnutls_emacs_global_deinit): ifdef out; not used.
6794 (Fgnutls_boot): Use const for pointer to readonly storage.
6795 Comment out unused local. Fix pointer signedness problems.
6796
6797 * lread.c (openp): Don't stuff size_t into an 'int'.
6798 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6799 about possible signed overflow.
6800
6801 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6802 (GDK_KEY_g): Don't define if already defined.
6803 (xg_prepare_tooltip): Avoid pointer signedness problem.
6804 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6805
6806 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6807 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6808
6809 * xfns.c (Fx_window_property): Simplify a bit,
6810 to make a bit faster and to avoid GCC 4.6.0 warning.
6811 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6812
6813 * fns.c (internal_equal): Don't assume size_t fits in int.
6814
6815 * alloc.c (compact_small_strings): Tighten assertion a little.
6816
6817 Replace pEd with more-general pI, and fix some printf arg casts.
6818 * lisp.h (pI): New macro, generalizing old pEd macro to other
6819 conversion specifiers. For example, use "...%"pI"d..." rather
6820 than "...%"pEd"...".
6821 (pEd): Remove. All uses replaced with similar uses of pI.
6822 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6823 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6824 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6825 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6826 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6827 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6828 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6829 64-bit hosts.
6830 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6831 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6832 * print.c (safe_debug_print, print_object): Likewise.
6833 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6834 to int.
6835 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6836 avoiding the 0 flag, which is not portable.
6837 * process.c (Fmake_network_process): Use pI to avoid cast.
6838 * region-cache.c (pp_cache): Likewise.
6839 * xdisp.c (decode_mode_spec): Likewise.
6840 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6841 behavior on 64-bit hosts with printf arg.
6842 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6843 (x_stop_queuing_selection_requests): Likewise.
6844 (x_get_window_property): Don't truncate byte count to an 'int'
6845 when tracing.
6846
6847 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6848 here, since it parses constructs like leading '-' and spaces,
6849 which are not wanted; and it overflows with large numbers.
6850 Instead, simply match F[0-9]+, which is what is wanted anyway.
6851
6852 * alloc.c: Remove unportable assumptions about struct layout.
6853 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6854 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6855 (allocate_vectorlike, make_pure_vector): Use the new macros,
6856 plus offsetof, to remove unportable assumptions about struct layout.
6857 These assumptions hold on all porting targets that I know of, but
6858 they are not guaranteed, they're easy to remove, and removing them
6859 makes further changes easier.
6860
6861 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6862 This doesn't fix a bug but makes the code clearer.
6863 (string_overrun_cookie): Now const. Use initializers that
6864 don't formally overflow signed char, to avoid warnings.
6865 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6866 can cause Emacs to crash when string overrun checking is enabled.
6867 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6868 multiple of sizeof (EMACS_INT); it need not be, if
6869 alignof(EMACS_INT) < sizeof (EMACS_INT).
6870 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6871
6872 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6873
6874 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6875
6876 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6877
6878 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6879 supposed to be handshaking. (Bug#8556)
6880 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6881
6882 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6883
6884 * lisp.h (Qdebug): List symbol.
6885 * eval.c (Qdebug): Restore global linkage.
6886 * keyboard.c (debug-on-event): New variable.
6887 (handle_user_signal): Break into debugger when debug-on-event
6888 matches the current signal symbol.
6889
6890 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6891
6892 * alloc.c (check_sblock, check_string_bytes)
6893 (check_string_free_list): Convert to standard C.
6894
6895 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6896
6897 * w32.c (emacs_gnutls_push): Fix typo.
6898
6899 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6900
6901 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6902 "cast to pointer from integer of different size".
6903
6904 Improve doprnt and its use in verror. (Bug#8545)
6905 * doprnt.c (doprnt): Document the set of format control sequences
6906 supported by the function. Use SAFE_ALLOCA instead of always
6907 using `alloca'.
6908
6909 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6910 is one byte too soon. Don't use xrealloc; instead xfree and
6911 xmalloc anew.
6912
6913 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6914
6915 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6916 callbacks stage.
6917
6918 * gnutls.c: Renamed global_initialized to
6919 gnutls_global_initialized. Added internals for the
6920 :verify-hostname-error, :verify-error, and :verify-flags
6921 parameters of `gnutls-boot' and documented those parameters in the
6922 docstring. Start callback support.
6923 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6924 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6925 on error. Return error code.
6926 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6927 (emacs_gnutls_read): Likewise.
6928 (Fgnutls_boot): Return handshake error code.
6929 (emacs_gnutls_handle_error): New function.
6930 (wsaerror_to_errno): Likewise.
6931
6932 * w32.h (emacs_gnutls_pull): Add prototype.
6933 (emacs_gnutls_push): Likewise.
6934
6935 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6936 (emacs_gnutls_push): Likewise.
6937
6938 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6939
6940 * process.c (wait_reading_process_output): Check if GnuTLS
6941 buffered some data internally if no FDs are set for TLS
6942 connections.
6943
6944 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6945 (LIBS): Link to USER_LIBS.
6946 ($(BLD)/gnutls.$(0)): New target.
6947
6948 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6949
6950 * xdisp.c (handle_single_display_spec): Rename the
6951 display_replaced_before_p argument into display_replaced_p, to
6952 make it consistent with the commentary. Fix typos in the
6953 commentary.
6954
6955 * textprop.c (syms_of_textprop): Remove dead code.
6956 (copy_text_properties): Delete obsolete commentary about an
6957 interface that was deleted long ago. Fix typos in the description
6958 of arguments.
6959
6960 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6961 to changes in oldXMenu/XMenu.h from 2011-04-16.
6962 <menu_help_message, prev_menu_help_message>: Constify.
6963 (IT_menu_make_room): menu->help_text is now `const char **';
6964 adjust.
6965
6966 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6967 to changes in oldXMenu/XMenu.h from 2011-04-16.
6968 (struct XMenu): Declare `help_text' `const char **'.
6969
6970 * xfaces.c <Qunspecified>: Make extern again.
6971
6972 * syntax.c: Include sys/types.h before including regex.h, as
6973 required by Posix.
6974
6975 * doc.c (get_doc_string): Improve the format passed to `error'.
6976
6977 * doprnt.c (doprnt): Improve commentary.
6978
6979 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6980
6981 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6982 them with etags.
6983
6984 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6985 changes in globals.h immediately force recompilation.
6986 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6987 $(CURDIR)/s/ms-w32.h.
6988 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6989
6990 * character.c (Fchar_direction): Function deleted.
6991 (syms_of_character): Don't defsubr it.
6992 <char-direction-table>: Deleted.
6993
6994 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6995
6996 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6997 * doprnt.c: Include limits.h.
6998 (SIZE_MAX): New macro.
6999 (doprnt): Return a size_t value. 2nd arg is now size_t.
7000 Many local variables are now size_t instead of int or unsigned.
7001 Improve overflow protection. Support `l' modifier for integer
7002 conversions. Support %l conversion. Don't assume an EMACS_INT
7003 argument for integer conversions and for %c.
7004
7005 * lisp.h (doprnt): Restore prototype.
7006
7007 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7008 $(SRC)/character.h.
7009
7010 * Makefile.in (base_obj): Add back doprnt.o.
7011
7012 * deps.mk (doprnt.o): Add back prerequisites.
7013 (callint.o): Depend on character.h.
7014
7015 * eval.c (internal_lisp_condition_case): Include the handler
7016 representation in the error message.
7017 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7018 when breaking from the loop.
7019
7020 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7021
7022 * callint.c (Fcall_interactively): When displaying error message
7023 about invalid control letter, pass the character's codepoint, not
7024 a pointer to its multibyte form. Improve display of the character
7025 in octal and display also its hex code.
7026
7027 * character.c (char_string): Use %x to display the (unsigned)
7028 codepoint of an invalid character, to avoid displaying a bogus
7029 negative value.
7030
7031 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7032 `error', not SYMBOL_NAME itself.
7033
7034 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7035 character arguments to `error'.
7036
7037 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7038 to `error' in error message about FINAL_CHAR argument. Make sure
7039 FINAL_CHAR is a character, and use %c when it is passed as
7040 argument to `error'.
7041
7042 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7043
7044 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7045
7046 * w32.c: Include <time.h>.
7047 (sys_localtime): New function.
7048
7049 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7050
7051 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7052
7053 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7054
7055 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7056
7057 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7058 zombies (Bug#8467).
7059
7060 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7061
7062 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7063 gl_state.e_property when gl_state.object is Qt.
7064
7065 * insdel.c (make_gap_larger): Remove limitation of buffer size
7066 to <= INT_MAX.
7067
7068 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7069
7070 * xdisp.c (lookup_glyphless_char_display)
7071 (produce_glyphless_glyph): Handle cons cell entry in
7072 glyphless-char-display.
7073 (Vglyphless_char_display): Document it.
7074
7075 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7076 glyphless-char-display.
7077
7078 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7079
7080 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7081
7082 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7083
7084 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7085 definition for no-X builds.
7086
7087 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7088
7089 Static checks with GCC 4.6.0 and non-default toolkits.
7090
7091 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7092
7093 * process.c (keyboard_bit_set): Define only if SIGIO.
7094 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7095 (send_process): Repair possible setjmp clobbering.
7096
7097 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7098
7099 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7100
7101 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7102
7103 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7104 Define only if needed.
7105
7106 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7107 by pacifying GCC about it. Maybe it's time to retire it?
7108 * xfaces.c (USG, __TIMEVAL__): Likewise.
7109
7110 * dispextern.h (struct redisplay_interface): Rename param
7111 to avoid shadowing.
7112 * termhooks.h (struct terminal): Likewise.
7113 * xterm.c (xembed_send_message): Likewise.
7114
7115 * insdel.c (make_gap_smaller): Define only if
7116 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7117
7118 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7119 it.
7120
7121 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7122 so that we aren't warned about unused symbols.
7123
7124 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7125
7126 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7127
7128 * xfns.c (x_real_positions): Mark locals as initialized.
7129
7130 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7131
7132 * xterm.c: Fix problems found by static analysis with other toolkits.
7133 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7134 (x_dispatch_event): Declare static if USE_GTK, and
7135 define if USE_GTK || USE_X_TOOLKIT.
7136 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7137 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7138 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7139 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7140
7141 * xmenu.c (menu_help_callback): Pointer type fixes.
7142 Use const pointers when pointing at readonly data. Avoid pointer
7143 signedness clashes.
7144 (FALSE): Remove unused macro.
7145 (update_frame_menubar): Remove unused decl.
7146
7147 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7148
7149 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7150 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7151 (single_menu_item): Rename local to avoid shadowing.
7152
7153 * keyboard.c (make_lispy_event): Remove unused local var.
7154
7155 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7156 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7157
7158 * bitmaps: Change bitmaps from unsigned char back to the X11
7159 compatible char. Avoid the old compiler warnings about
7160 out-of-range initializers by using, for example, '\xab' rather
7161 than 0xab.
7162
7163 * xgselect.c (xgselect_initialize): Check vs interface
7164 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7165
7166 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7167
7168 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7169 to read-only memory.
7170
7171 * fns.c (vector): Remove; this old hack is no longer needed.
7172
7173 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7174 Remove unused var.
7175 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7176
7177 * xrdb.c (x_load_resources): Omit unused local.
7178
7179 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7180 (x_window): Rename locals to avoid shadowing.
7181 (USG): Use the kludged USG macro, to pacify gcc.
7182
7183 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7184 (x_term_init): Remove local to avoid shadowing.
7185
7186 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7187
7188 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7189 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7190
7191 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7192
7193 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7194
7195 Fix regex.c, syntax.c and friends for buffers > 2GB.
7196 * syntax.h (struct gl_state_s): Declare character position members
7197 EMACS_INT.
7198
7199 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7200
7201 * textprop.c (verify_interval_modification, interval_of):
7202 Declare arguments EMACS_INT.
7203
7204 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7205 EMACS_INT.
7206
7207 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7208
7209 * indent.c (Fvertical_motion): Local variable it_start is now
7210 EMACS_INT.
7211
7212 * regex.c (re_match, re_match_2, re_match_2_internal)
7213 (bcmp_translate, regcomp, regexec, print_double_string)
7214 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7215 (re_compile_pattern, re_exec): Declare arguments and local
7216 variables `size_t' and `ssize_t' and return values `regoff_t', as
7217 appropriate.
7218 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7219 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7220 <compile_stack_type>: `size' and `avail' are now `size_t'.
7221
7222 * regex.h <regoff_t>: Use ssize_t, not int.
7223 (re_search, re_search_2, re_match, re_match_2): Arguments that
7224 specify buffer/string position and length are now ssize_t and
7225 size_t. Return type is regoff_t.
7226
7227 2011-04-16 Ben Key <bkey76@gmail.com>
7228
7229 * nsfont.m: Fixed bugs in ns_get_family and
7230 ns_descriptor_to_entity that were caused by using free to
7231 deallocate memory blocks that were allocated by xmalloc (via
7232 xstrdup). This caused Emacs to crash when compiled with
7233 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7234 --enable-checking=xmallocoverrun). xfree is now used to
7235 deallocate these memory blocks.
7236
7237 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7238
7239 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7240
7241 emacs_write: Accept and return EMACS_INT for sizes.
7242 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7243 et seq.
7244 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7245 Accept and return EMACS_INT.
7246 (emacs_gnutls_write): Return the number of bytes written on
7247 partial writes.
7248 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7249 (emacs_read, emacs_write): Remove check for negative size, as the
7250 Emacs source code has been audited now.
7251 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7252 (emacs_read, emacs_write): Use it.
7253 * process.c (send_process): Adjust to the new signatures of
7254 emacs_write and emacs_gnutls_write. Do not attempt to store
7255 a byte offset into an 'int'; it might overflow.
7256 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7257
7258 * sound.c: Don't assume sizes fit in 'int'.
7259 (struct sound_device.period_size, alsa_period_size):
7260 Return EMACS_INT, not int.
7261 (struct sound_device.write, vox_write, alsa_write):
7262 Accept EMACS_INT, not int.
7263 (wav_play, au_play): Use EMACS_INT to store sizes and to
7264 record read return values.
7265
7266 2011-04-15 Ben Key <bkey76@gmail.com>
7267
7268 * keyboard.c (Qundefined): Don't declare static since it is used
7269 in nsfns.m.
7270 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7271 static since they are used in nsfont.m.
7272
7273 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7274
7275 * process.c (Qprocessp): Don't declare static.
7276 * lisp.h (Qprocessp): Declare again.
7277
7278 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7279
7280 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7281
7282 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7283
7284 Improve C-level modularity by making more things 'static'.
7285
7286 Don't publish debugger-only interfaces to other modules.
7287 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7288 (verify_bytepos, count_markers): Move decls to the only modules
7289 that need them.
7290 * region-cache.h (pp_cache): Likewise.
7291 * window.h (check_all_windows): Likewise.
7292 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7293
7294 * sysdep.c (croak): Now static, if
7295 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7296 * syssignal.h (croak): Declare only if not static.
7297
7298 * alloc.c (refill_memory_reserve): Now static if
7299 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7300 * lisp.h (refill_memory_reserve): Declare only if not static.
7301
7302 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7303 Define only if USE_LUCID.
7304
7305 * xrdb.c (x_customization_string, x_rm_string): Now static.
7306
7307 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7308 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7309
7310 * xdisp.c (draw_row_with_mouse_face): Now static.
7311 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7312
7313 * window.h (check_all_windows): Mark externally visible.
7314
7315 * window.c (window_deletion_count): Now static.
7316
7317 * undo.c: Make symbols static if they're not exported.
7318 (last_undo_buffer, last_boundary_position, pending_boundary):
7319 Now static.
7320
7321 * textprop.c (interval_insert_behind_hooks): Now static.
7322 (interval_insert_in_front_hooks): Likewise.
7323
7324 * term.c: Make symbols static if they're not exported.
7325 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7326 (max_frame_lines, tty_set_terminal_modes):
7327 (tty_reset_terminal_modes, tty_turn_off_highlight):
7328 (get_tty_terminal): Now static.
7329 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7330 * termhooks.h (term_mouse_moveto): Do not declare if
7331 HAVE_WINDOW_SYSTEM.
7332 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7333 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7334
7335 * sysdep.c: Make symbols static if they're not exported.
7336 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7337 Now static.
7338 (sigprocmask_set, full_mask): Remove; unused.
7339 (wait_debugging): Mark as visible.
7340 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7341 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7342
7343 * syntax.c (syntax_temp): Define only if !__GNUC__.
7344
7345 * sound.c (current_sound_device, current_sound): Now static.
7346
7347 * search.c (searchbufs, searchbuf_head): Now static.
7348
7349 * scroll.c (scroll_cost): Remove; unused.
7350 * dispextern.h (scroll_cost): Remove decl.
7351
7352 * region-cache.h (pp_cache): Mark as externally visible.
7353
7354 * process.c: Make symbols static if they're not exported.
7355 (process_tick, update_tick, create_process, chan_process):
7356 (Vprocess_alist, proc_buffered_char, datagram_access):
7357 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7358 (deactivate_process): Mark defn as static, as well as decl.
7359 * lisp.h (create_process): Remove decl.
7360 * process.h (chan_process, Vprocess_alist): Remove decls.
7361
7362 * print.c: Make symbols static if they're not exported.
7363 (print_depth, new_backquote_output, being_printed, print_buffer):
7364 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7365 (print_interval, print_number_index, initial_stderr_stream):
7366 Now static.
7367 * lisp.h (Fprinc): Remove decl.
7368 (debug_output_compilation_hack): Mark as externally visible.
7369
7370 * sysdep.c (croak): Move decl from here to syssignal.h.
7371 * syssignal.h (croak): Put it here, so the API can be checked when
7372 'croak' is called from dissociate_if_controlling_tty.
7373
7374 * minibuf.c: Make symbols static if they're not exported.
7375 (minibuf_save_list, choose_minibuf_frame): Now static.
7376 * lisp.h (choose_minibuf_frame): Remove decl.
7377
7378 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7379
7380 * lread.c: Make symbols static if they're not exported.
7381 (read_objects, initial_obarray, oblookup_last_bucket_number):
7382 Now static.
7383 (make_symbol): Remove; unused.
7384 * lisp.h (initial_obarray, make_symbol): Remove decls.
7385
7386 * keyboard.c: Make symbols static if they're not exported.
7387 (single_kboard, recent_keys_index, total_keys, recent_keys):
7388 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7389 (this_single_command_key_start, echoing, last_auto_save):
7390 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7391 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7392 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7393 (Vlispy_mouse_stem, double_click_count):
7394 Now static.
7395 (force_auto_save_soon): Define only if SIGDANGER.
7396 (ignore_mouse_drag_p): Now static if
7397 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7398 (print_help): Remove; unused.
7399 (stop_character, last_timer_event): Mark as externally visible.
7400 * keyboard.h (ignore_mouse_drag_p): Declare only if
7401 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7402 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7403 * lisp.h (echoing): Remove decl.
7404 (force_auto_save_soon): Declare only if SIGDANGER.
7405 * xdisp.c (redisplay_window): Simplify code, to make it more
7406 obvious that ignore_mouse_drag_p is not accessed if !defined
7407 USE_GTK && !defined HAVE_NS.
7408
7409 * intervals.c: Make symbols static if they're not exported.
7410 (merge_properties_sticky, merge_interval_right, delete_interval):
7411 Now static.
7412 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7413
7414 * insdel.c: Make symbols static if they're not exported.
7415 However, leave prepare_to_modify_buffer alone. It's never
7416 called from outside this function, but that appears to be a bug.
7417 (combine_after_change_list, combine_after_change_buffer):
7418 (adjust_after_replace, signal_before_change): Now static.
7419 (adjust_after_replace_noundo): Remove; unused.
7420 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7421 (signal_before_change): Remove decls.
7422
7423 * indent.c (val_compute_motion, val_vmotion): Now static.
7424
7425 * image.c: Make symbols static if they're not exported.
7426 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7427 if USE_GTK.
7428 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7429 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7430
7431 * fringe.c (standard_bitmaps): Now static.
7432 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7433
7434 * frame.c: Make symbols static if they're not exported.
7435 (x_report_frame_params, make_terminal_frame): Now static.
7436 (get_frame_param): Now static, unless HAVE_NS.
7437 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7438 (x_get_resource_string): Remove; not used.
7439 * frame.h (make_terminal_frame, x_report_frame_params):
7440 (x_get_resource_string); Remove decls.
7441 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7442 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7443
7444 * font.c, fontset.c: Make symbols static if they're not exported.
7445 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7446 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7447 * font.c (font_close_object): Now static.
7448 * font.h (font_close_object): Remove.
7449 * fontset.c (FONTSET_OBJLIST): Remove.
7450 (free_realized_fontset) #if-0 the body, which does nothing.
7451 (face_suitable_for_char_p): #if-0, as it's never called.
7452 * fontset.h (face_suitable_for_char_p): Remove decl.
7453 * xfaces.c (face_at_string_position):
7454 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7455 since 0 is always ASCII.
7456
7457 * fns.c (weak_hash_tables): Now static.
7458
7459 * fileio.c: Make symbols static if they're not exported.
7460 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7461 (Vwrite_region_annotation_buffers): Now static.
7462
7463 * eval.c: Make symbols static if they're not exported.
7464 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7465 * lisp.h (backtrace_list): Remove decl.
7466
7467 * emacs.c: Make symbols static if they're not exported.
7468 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7469 (fatal_error_code, fatal_error_signal_hook, standard_args):
7470 Now static.
7471 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7472 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7473 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7474 * lisp.h (fatal_error_signal_hook): Remove decl.
7475 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7476
7477 * editfns.c: Move a (normally-unused) function to its only use.
7478 * editfns.c, lisp.h (get_operating_system_release): Remove.
7479 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7480 worth the hassle of breaking this out.
7481
7482 * xterm.c: Make symbols static if they're not exported.
7483 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7484 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7485 (x_destroy_window, x_delete_display):
7486 Now static.
7487 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7488 (x_mouse_leave): Remove; unused.
7489 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7490 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7491 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7492 Remove decls.
7493 (x_mouse_leave): Declare only if WINDOWSNT.
7494 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7495 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7496 USE_X_TOOLKIT.
7497
7498 * ftxfont.c: Make symbols static if they're not exported.
7499 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7500 HAVE_FREETYPE.
7501 * font.h (ftxfont_driver): Likewise.
7502
7503 * xfns.c: Make symbols static if they're not exported.
7504 (x_last_font_name, x_display_info_for_name):
7505 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7506 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7507 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7508 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7509 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7510 (last_show_tip_args): Now static.
7511 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7512 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7513 (x_screen_planes): Remove; unused.
7514 * dispextern.h (x_screen_planes): Remove decl.
7515
7516 * dispnew.c: Make symbols static if they're not exported.
7517 * dispextern.h (redraw_garbaged_frames, scrolling):
7518 (increment_row_positions): Remove.
7519 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7520 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7521 Now static.
7522 (redraw_garbaged_frames): Remove; unused.
7523
7524 * xfaces.c: Make symbols static if they're not exported.
7525 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7526 Remove decls.
7527 * xterm.h (defined_color): Remove decls.
7528 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7529 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7530 (menu_face_changed_default, defined_color, free_realized_face):
7531 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7532 (ascii_face_of_lisp_face): Remove; unused.
7533
7534 * xdisp.c: Make symbols static if they're not exported.
7535 * dispextern.h (scratch_glyph_row, window_box_edges):
7536 (glyph_to_pixel_coords, set_cursor_from_row):
7537 (get_next_display_element, set_iterator_to_next):
7538 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7539 (show_mouse_face): Remove decls
7540 * frame.h (message_buf_print): Likewise.
7541 * lisp.h (pop_message, set_message, check_point_in_composition):
7542 Likewise.
7543 * xterm.h (set_vertical_scroll_bar): Likewise.
7544 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7545 (message_buf_print, scratch_glyph_row, displayed_buffer):
7546 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7547 (get_next_display_element, show_mouse_face, window_box_edges):
7548 (frame_to_window_pixel_xy, check_point_in_composition):
7549 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7550 (glyph_to_pixel_coords): Remove; unused.
7551
7552 * dired.c (file_name_completion): Now static.
7553
7554 * dbusbind.c (xd_in_read_queued_messages): Now static.
7555
7556 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7557 * data.c (circular_list_error): Remove.
7558
7559 * commands.h (last_point_position, last_point_position_buffer):
7560 (last_point_position_window): Remove decls.
7561 * keyboard.c: Make these variables static.
7562
7563 * coding.h (coding, code_convert_region, encode_coding_gap):
7564 Remove decls.
7565 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7566 (iso_code_class, detect_coding, code_convert_region): Now static.
7567 (encode_coding_gap): Remove; unused.
7568
7569 * chartab.c (chartab_chars, chartab_bits): Now static.
7570
7571 * charset.h (charset_iso_8859_1): Remove decl.
7572 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7573 Now static.
7574
7575 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7576 * ccl.c (Vccl_program_table): Now static.
7577 (check_ccl_update): Remove; unused.
7578
7579 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7580 * category.h: ... from here.
7581 * category.c (check_category_table, set_category_set): Now static.
7582
7583 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7584 * lisp.h: Remove these decls.
7585
7586 * buffer.c (buffer_count): Remove unused var.
7587
7588 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7589 so that it's not optimized away.
7590 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7591 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7592 exported only to the debugger.
7593
7594 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7595 * atimer.h (run_all_atimers): Remove; not exported.
7596
7597 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7598 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7599 was inaccessible from Lisp.
7600 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7601 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7602
7603 alloc.c: Import and export fewer symbols, and remove unused items.
7604 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7605 is defined.
7606 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7607 it's not optimized away by whole-program optimization.
7608 (message_enable_multibyte, free_misc): Remove.
7609 (catchlist, handlerlist, mark_backtrace):
7610 Declare only if BYTE_MARK_STACK.
7611 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7612 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7613 (message_enable_multibyte): Remove decl.
7614 (free_misc, interval_free_list, float_block, float_block_index):
7615 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7616 (cons_free_list, last_marked_index):
7617 Now static.
7618 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7619 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7620 (mark_backtrace): Define only if BYTE_MARK_STACK.
7621 * xdisp.c (message_enable_multibyte): Now static.
7622
7623 Declare Lisp_Object Q* variables to be 'static' if not exported.
7624 This makes it easier for human readers (and static analyzers)
7625 to see whether these variables are used from other modules.
7626 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7627 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7628 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7629 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7630 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7631 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7632 * xmenu.c, xselect.c:
7633 Declare Q* vars static if they are not used in other modules.
7634 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7635 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7636 Remove decls of unexported vars.
7637 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7638
7639 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7640
7641 Make Emacs functions such as Fatom 'static' by default.
7642 This makes it easier for human readers (and static analyzers)
7643 to see whether these functions can be called from other modules.
7644 DEFUN now defines a static function. To make the function external
7645 so that it can be used in other C modules, use the new macro DEFUE.
7646 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7647 (Finit_image_library):
7648 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7649 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7650 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7651 Remove decls, since these functions are now static.
7652 (Funintern, Fget_internal_run_time): New decls, since these functions
7653 were already external.
7654
7655 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7656 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7657 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7658 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7659 * keyboard.c, keymap.c, lread.c:
7660 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7661 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7662 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7663 Mark functions with DEFUE instead of DEFUN,
7664 if they are used in other modules.
7665 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7666 decls for now-static functions.
7667 * buffer.h (Fdelete_overlay): Remove decl.
7668 * callproc.c (Fgetenv_internal): Mark as internal.
7669 * composite.c (Fremove_list_of_text_properties): Remove decl.
7670 (Fcomposition_get_gstring): New forward static decl.
7671 * composite.h (Fcomposite_get_gstring): Remove decl.
7672 * dired.c (Ffile_attributes): New forward static decl.
7673 * doc.c (Fdocumntation_property): New forward static decl.
7674 * eval.c (Ffetch_bytecode): New forward static decl.
7675 (Funintern): Remove extern decl; now in .h file where it belongs.
7676 * fileio.c (Fmake_symbolic_link): New forward static decl.
7677 * image.c (Finit_image_library): New forward static decl.
7678 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7679 * intervals.h (Fprevious_property_change):
7680 (Fremove_list_of_text_properties): Remove decls.
7681 * keyboard.c (Fthis_command_keys): Remove decl.
7682 (Fcommand_execute): New forward static decl.
7683 * keymap.c (Flookup_key): New forward static decl.
7684 (Fcopy_keymap): Now static.
7685 * keymap.h (Flookup_key): Remove decl.
7686 * process.c (Fget_process): New forward static decl.
7687 (Fprocess_datagram_address): Mark as internal.
7688 * syntax.c (Fsyntax_table_p): New forward static decl.
7689 (skip_chars): Remove duplicate decl.
7690 * textprop.c (Fprevious_property_change): New forward static decl.
7691 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7692 Now internal.
7693 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7694 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7695
7696 * editfns.c (Fformat): Remove unreachable code.
7697
7698 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7699
7700 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7701 change. (Bug#8496)
7702
7703 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7704
7705 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7706 when at ZV. (Bug#8487)
7707
7708 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7709
7710 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7711 (Bug#8437)
7712 * keyboard.c (parse_tool_bar_item): Likewise.
7713 * sound.c (sound_cleanup, alsa_close): Likewise.
7714 * termcap.c (tgetent): Likewise.
7715 * xfns.c (x_default_font_parameter): Likewise.
7716 * xsettings.c (read_and_apply_settings): Likewise.
7717
7718 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7719 (overrun_check_free): Protoize.
7720
7721 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7722
7723 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7724 since callers should never pass a negative size.
7725 Change the signature to match that of plain 'read' and 'write'; see
7726 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7727 * lisp.h: Update prototypes of emacs_write and emacs_read.
7728
7729 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7730
7731 * xdisp.c (redisplay_window): Don't try to determine the character
7732 position of the scroll margin if the window start point w->startp
7733 is outside the buffer's accessible region. (Bug#8468)
7734
7735 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7736
7737 Fix write-region and its subroutines for buffers > 2GB.
7738 * fileio.c (a_write, e_write): Modify declaration of arguments and
7739 local variables to support buffers larger than 2GB.
7740 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7741
7742 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7743 argument, local variables, and return value.
7744
7745 * lisp.h: Update prototypes of emacs_write and emacs_read.
7746
7747 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7748
7749 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7750
7751 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7752
7753 Fix more problems found by GCC 4.6.0's static checks.
7754
7755 * xdisp.c (vmessage): Use a better test for character truncation.
7756
7757 * charset.c (load_charset_map): <, not <=, for optimization,
7758 and to avoid potential problems with integer overflow.
7759 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7760 * casetab.c (set_identity, shuffle): Likewise.
7761 * editfns.c (Fformat): Likewise.
7762 * syntax.c (skip_chars): Likewise.
7763
7764 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7765 This also lets GCC 4.6.0 generate slightly better loop code.
7766
7767 * callint.c (Fcall_interactively): <, not <=, for optimization.
7768 (Fcall_interactively): Count the number of arguments produced,
7769 not the number of arguments given. This is simpler and lets GCC
7770 4.6.0 generate slightly better code.
7771
7772 * ftfont.c: Distingish more carefully between FcChar8 and char.
7773 The previous code passed unsigned char * to a functions like
7774 strlen and xstrcasecmp that expect char *, which does not
7775 conform to the C standard.
7776 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7777 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7778 char * when the C standard requires it.
7779
7780 * keyboard.c (read_char): Remove unused var.
7781
7782 * eval.c: Port to Windows vsnprintf (Bug#8435).
7783 Include <limits.h>.
7784 (SIZE_MAX): Define if the headers do not.
7785 (verror): Do not give up if vsnprintf returns a negative count.
7786 Instead, grow the buffer. This ports to Windows vsnprintf, which
7787 does not conform to C99. Problem reported by Eli Zaretskii.
7788 Also, simplify the allocation scheme, by avoiding the need for
7789 calling realloc, and removing the ALLOCATED variable.
7790
7791 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7792
7793 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7794 But keep the doprint source code for now, as we might revamp it
7795 and use it again (Bug#8435).
7796 * lisp.h (doprnt): Remove.
7797 * Makefile.in (base_obj): Remove doprnt.o.
7798 * deps.mk (doprnt.o): Remove.
7799
7800 error: Print 32- and 64-bit integers portably (Bug#8435).
7801 Without this change, on typical 64-bit hosts error ("...%d...", N)
7802 was used to print both 32- and 64-bit integers N, which relied on
7803 undefined behavior.
7804 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7805 * lisp.h (error, verror): Mark as printf-like functions.
7806 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7807 Report overflow in size calculations when allocating printf buffer.
7808 Do not truncate output string at its first null byte.
7809 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7810 Truncate the output at a character boundary, since vsnprintf does not
7811 do that.
7812 * charset.c (check_iso_charset_parameter): Convert internal
7813 character to string before calling 'error', since %c now has the
7814 printf meaning.
7815 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7816 overflow when computing char to be passed to 'error'. Do not
7817 pass Lisp_Object to 'error'; pass the integer instead.
7818 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7819 formatted with plain %d.
7820
7821 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7822
7823 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7824
7825 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7826
7827 * xterm.c (x_catch_errors): Remove duplicate declaration.
7828
7829 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7830
7831 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7832
7833 2011-04-10 Jim Meyering <meyering@redhat.com>
7834
7835 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7836 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7837 return ssize_t not "int", and use size_t as the buffer length.
7838 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7839 * gnutls.h: Update declarations.
7840 * process.c (read_process_output): Use ssize_t, to match.
7841 (send_process): Likewise.
7842
7843 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7844
7845 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7846
7847 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7848
7849 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7850 Use unsigned char, to match FcChar8 type definition.
7851
7852 * xterm.c (handle_one_xevent):
7853 * xmenu.c (create_and_show_popup_menu):
7854 * xselect.c (x_decline_selection_request)
7855 (x_reply_selection_request): Avoid type-punned deref of X events.
7856
7857 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7858
7859 Fix some uses of `int' instead of EMACS_INT.
7860 * search.c (string_match_1, fast_string_match)
7861 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7862 (scan_buffer, find_next_newline_no_quit)
7863 (find_before_next_newline, search_command, Freplace_match)
7864 (Fmatch_data): Make some `int' variables be EMACS_INT.
7865
7866 * xdisp.c (display_count_lines): 3rd argument and return value now
7867 EMACS_INT. All callers changed.
7868 (pint2hrstr): Last argument is now EMACS_INT.
7869
7870 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7871 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7872 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7873 (decode_coding_utf_16, decode_coding_emacs_mule)
7874 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7875 (decode_coding_ccl, decode_coding_charset)
7876 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7877 (decode_coding_iso_2022, decode_coding_emacs_mule)
7878 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7879 <char_offset, last_offset>: Declare EMACS_INT.
7880 (encode_coding_utf_8, encode_coding_utf_16)
7881 (encode_coding_emacs_mule, encode_invocation_designation)
7882 (encode_designation_at_bol, encode_coding_iso_2022)
7883 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7884 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7885 Declare EMACS_INT.
7886 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7887 (encode_invocation_designation): Last argument P_NCHARS is now
7888 EMACS_INT.
7889 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7890 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7891
7892 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7893 All users changed.
7894
7895 * ccl.c (Fccl_execute_on_string): Declare some variables
7896 EMACS_INT.
7897
7898 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7899
7900 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7901
7902 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7903
7904 * process.c (Fformat_network_address): Doc fix.
7905
7906 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7907
7908 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7909
7910 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7911
7912 * keyboard.c (read_char): Call Lisp function help-form-show,
7913 instead of using internal_with_output_to_temp_buffer.
7914 (Qhelp_form_show): New var.
7915 (syms_of_keyboard): Use DEFSYM macro.
7916
7917 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7918
7919 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7920
7921 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7922
7923 * process.c (Flist_processes): Remove to Lisp.
7924 (list_processes_1): Delete.
7925
7926 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7927
7928 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7929
7930 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7931
7932 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7933
7934 Fix more problems found by GCC 4.6.0's static checks.
7935
7936 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7937
7938 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7939
7940 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7941
7942 * xdisp.c (vmessage): Mark as a printf-like function.
7943
7944 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7945
7946 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7947
7948 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7949 printf-like functions.
7950 (tiff_load): Add casts to remove these marks before passing them
7951 to system-supplied API.
7952
7953 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7954
7955 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7956 This avoids several warnings with gcc -Wstrict-overflow.
7957 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7958 directly, rather than having caller test rule sign. This avoids
7959 some unnecessary tests.
7960 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7961 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7962 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7963
7964 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7965 (xfont_open): Avoid unnecessary tests.
7966
7967 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7968
7969 * composite.h, composite.c (composition_gstring_put_cache):
7970 Use EMACS_INT, not int, for length.
7971
7972 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7973 breaking out part of COMPOSITION_DECODE_RULE.
7974 (COMPOSITION_DECODE_RULE): Use it.
7975 * composite.c (get_composition_id): Remove unused local vars,
7976 by using the new macro.
7977
7978 * textprop.c (set_text_properties_1): Change while to do-while,
7979 since the condition is always true at first.
7980
7981 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7982 (interval_deletion_adjustment): Return unsigned value.
7983 All uses changed.
7984
7985 * process.c (list_processes_1, create_pty, read_process_output):
7986 (exec_sentinel): Remove vars that were set but not used.
7987 (create_pty): Remove unnecessary "volatile"s.
7988 (Fnetwork_interface_info): Avoid possibility of int overflow.
7989 (read_process_output): Do adaptive read buffering even if carryover.
7990 (read_process_output): Simplify nbytes computation if buffered.
7991
7992 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7993
7994 * syntax.c (scan_words): Remove var that was set but not used.
7995 (update_syntax_table): Use unsigned instead of int.
7996
7997 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7998 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7999 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8000
8001 * print.c (print_error_message): Avoid int overflow.
8002
8003 * font.c (font_list_entities): Redo for clarity,
8004 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8005
8006 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8007 (font_score): Avoid potential overflow in diff calculation.
8008
8009 * fns.c (substring_both): Remove var that is set but not used.
8010 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8011
8012 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8013
8014 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8015 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8016 can always succeed if overflow has undefined behavior.
8017
8018 * search.c (boyer_moore, wordify): Remove vars set but not used.
8019 (wordify): Omit three unnecessary tests.
8020
8021 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8022 All callers changed. This avoids the need for an unused var.
8023
8024 * casefiddle.c (casify_region): Remove var that is set but not used.
8025
8026 * dired.c (file_name_completion): Remove var that is set but not used.
8027
8028 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8029
8030 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8031 (Finsert_file_contents): Remove unnecessary code checking fd.
8032
8033 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8034 Check for integer overflow on size calculations.
8035
8036 * buffer.c (Fprevious_overlay_change): Remove var that is set
8037 but not used.
8038
8039 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8040 Remove vars that are set but not used.
8041 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8042 (timer_check_2): Mark vars as initialized.
8043
8044 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8045
8046 * image.c (lookup_image): Remove var that is set but not used.
8047 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8048
8049 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8050 that are set but not used.
8051
8052 * xfns.c (make_invisible_cursor): Don't return garbage
8053 if XCreateBitmapFromData fails (Bug#8410).
8054
8055 * xselect.c (x_get_local_selection, x_handle_property_notify):
8056 Remove vars that are set but not used.
8057
8058 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8059 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8060
8061 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8062 Remove var that is set but not used.
8063 (scroll_bar_windows_size): Now size_t, not int.
8064 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8065 Check for overflow.
8066
8067 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8068 (map_tty_color) [!defined MSDOS]: Likewise.
8069
8070 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8071
8072 * coding.c: Remove vars that are set but not used.
8073 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8074 All callers changed.
8075 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8076 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8077 (decode_coding_charset): Remove vars that are set but not used.
8078
8079 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8080 that is set but not used.
8081
8082 * print.c (print_object): Remove var that is set but not used.
8083
8084 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8085 The gnulib version avoids calling malloc in the usual case,
8086 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8087 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8088 * filelock.c (current_lock_owner): Likewise.
8089 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8090 * sysdep.c: Include allocator.h, careadlinkat.h.
8091 (emacs_no_realloc_allocator): New static constant.
8092 (emacs_readlink): New function.
8093 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8094 ../lib/careadlinkat.h.
8095
8096 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8097
8098 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8099 first non-nil return value).
8100
8101 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8102
8103 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8104 if not defined (Bug#8403).
8105
8106 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8107
8108 * xdisp.c (display_count_lines): Remove parameter `start',
8109 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8110 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8111 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8112 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8113 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8114 and thereabouts. All callers changed.
8115 (get_per_char_metric): Remove parameter `f', unused since
8116 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8117
8118 2011-04-02 Jim Meyering <meyering@redhat.com>
8119
8120 do not dereference NULL upon failed strdup
8121 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8122 (ns_get_family): Likewise.
8123
8124 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8125
8126 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8127
8128 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8129
8130 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8131 later (Bug#8403).
8132
8133 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8134
8135 Add lexical binding.
8136
8137 * window.c (Ftemp_output_buffer_show): New fun.
8138 (Fsave_window_excursion):
8139 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8140
8141 * lread.c (lisp_file_lexically_bound_p): New function.
8142 (Fload): Bind Qlexical_binding.
8143 (readevalloop): Remove `evalfun' arg.
8144 Bind Qinternal_interpreter_environment.
8145 (Feval_buffer): Bind Qlexical_binding.
8146 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8147 Mark as dynamic.
8148 (syms_of_lread): Declare `lexical-binding'.
8149
8150 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8151
8152 * keyboard.c (eval_dyn): New fun.
8153 (menu_item_eval_property): Use it.
8154
8155 * image.c (parse_image_spec): Use Ffunctionp.
8156
8157 * fns.c (concat, mapcar1): Accept byte-code-functions.
8158
8159 * eval.c (Fsetq): Handle lexical vars.
8160 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8161 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8162 (FletX, Flet): Obey lexical binding.
8163 (Fcommandp): Handle closures.
8164 (Feval): New `lexical' arg.
8165 (eval_sub): New function extracted from Feval. Use it almost
8166 everywhere where Feval was used. Look up vars in lexical env.
8167 Handle closures.
8168 (Ffunctionp): Move from subr.el.
8169 (Ffuncall): Handle closures.
8170 (apply_lambda): Remove `eval_flags'.
8171 (funcall_lambda): Handle closures and new byte-code-functions.
8172 (Fspecial_variable_p): New function.
8173 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8174 but without exporting it to Lisp.
8175
8176 * doc.c (Fdocumentation, store_function_docstring):
8177 * data.c (Finteractive_form): Handle closures.
8178
8179 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8180 interactive spec.
8181
8182 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8183 New byte-codes.
8184 (exec_byte_code): New function extracted from Fbyte_code to handle new
8185 calling convention for byte-code-functions. Add new byte-codes.
8186
8187 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8188
8189 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8190
8191 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8192
8193 * xdisp.c (redisplay_internal): Fix prototype.
8194
8195 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8196
8197 * xdisp.c (SCROLL_LIMIT): New macro.
8198 (try_scrolling): Use it when setting scroll_limit.
8199 Limit scrolling to 100 screen lines.
8200 (redisplay_window): Even when falling back on "recentering",
8201 position point in the window according to scroll-conservatively,
8202 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8203
8204 (try_scrolling): When point is above the window, allow searching
8205 as far as scroll_max, or one screenful, to compute vertical
8206 distance from PT to the scroll margin position. This prevents
8207 try_scrolling from unnecessarily failing when
8208 scroll-conservatively is set to a value slightly larger than the
8209 window height. Clean up the case of PT below the margin at bottom
8210 of window: scroll_max can no longer be INT_MAX. When aggressive
8211 scrolling is in use, don't let point enter the opposite scroll
8212 margin as result of the scroll.
8213 (syms_of_xdisp) <scroll-conservatively>: Document the
8214 threshold of 100 lines for never-recentering scrolling.
8215
8216 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8217
8218 * dispextern.h (move_it_by_lines):
8219 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8220 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8221 (message_log_check_duplicate): Remove parameters `prev_bol' and
8222 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8223 (redisplay_internal): Remove parameter `preserve_echo_area',
8224 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8225
8226 * indent.c (Fvertical_motion):
8227 * window.c (window_scroll_pixel_based, Frecenter):
8228 Don't pass `need_y_p' to `move_it_by_lines'.
8229
8230 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8231
8232 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8233 steal a few bits to be more compact.
8234 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8235 Remove unneeded casts.
8236
8237 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8238
8239 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8240
8241 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8242 binding" message (bug#7967).
8243
8244 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8245
8246 Fix more problems found by GCC 4.6.0's static checks.
8247
8248 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8249 Remove unused local var.
8250
8251 * editfns.c (Fmessage_box): Remove unused local var.
8252
8253 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8254 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8255 Omit unused local vars.
8256 * window.c (shrink_windows): Omit unused local var.
8257 * menu.c (digest_single_submenu): Omit unused local var.
8258 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8259 Omit unused local var.
8260
8261 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8262 Don't assume string length fits in int.
8263 (keyremap_step, read_key_sequence): Use size_t for sizes.
8264 (read_key_sequence): Don't check last_real_key_start redundantly.
8265
8266 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8267 instead of alloca (Bug#8344).
8268
8269 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8270 (Fbacktrace_frame): Don't assume nframes fits in int.
8271
8272 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8273
8274 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8275 concerns.
8276
8277 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8278
8279 * cm.c (calccost): Turn while-do into do-while, for clarity.
8280
8281 * keyboard.c (syms_of_keyboard): Use the same style as later
8282 in this function when indexing through an array. This also
8283 works around GCC bug 48267.
8284
8285 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8286
8287 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8288
8289 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8290 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8291
8292 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8293 This avoids undefined behavior on integer overflow, and is a bit
8294 more convenient anyway since it is compared to a size_t variable.
8295
8296 Variadic C functions now count arguments with size_t, not int.
8297 This avoids an unnecessary limitation on 64-bit machines, which
8298 caused (substring ...) to crash on large vectors (Bug#8344).
8299 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8300 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8301 All variadic functions and their callers changed accordingly.
8302 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8303 * data.c (arith_driver, float_arith_driver): Likewise.
8304 * editfns.c (general_insert_function): Likewise.
8305 * eval.c (struct backtrace.nargs, interactive_p)
8306 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8307 (funcall_lambda, mark_backtrace): Likewise.
8308 * fns.c (concat): Likewise.
8309 * frame.c (x_set_frame_parameters): Likewise.
8310 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8311 0 if not found, not -1. All callers changed.
8312
8313 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8314 (stack_copy_size): Now size_t, not int.
8315 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8316
8317 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8318
8319 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8320 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8321 All callers changed.
8322
8323 * lisp.h (multibyte_char_to_unibyte):
8324 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8325 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8326 * character.h (CHAR_TO_BYTE8):
8327 * cmds.c (internal_self_insert):
8328 * editfns.c (general_insert_function):
8329 * keymap.c (push_key_description):
8330 * search.c (Freplace_match):
8331 * xdisp.c (message_dolog, set_message_1): All callers changed.
8332
8333 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8334
8335 * keyboard.c (safe_run_hook_funcall): New function.
8336 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8337 don't set the hook to nil, but remove the offending function instead.
8338 (Qcommand_hook_internal): Remove, unused.
8339 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8340 Vcommand_hook_internal.
8341
8342 * eval.c (enum run_hooks_condition): Remove.
8343 (funcall_nil, funcall_not): New functions.
8344 (run_hook_with_args): Call each function through a `funcall' argument.
8345 Remove `cond' argument, now redundant.
8346 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8347 (Frun_hook_with_args_until_failure): Adjust accordingly.
8348 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8349
8350 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8351
8352 * dispextern.h (string_buffer_position): Remove declaration.
8353
8354 * print.c (strout): Remove parameter `multibyte', unused since
8355 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8356
8357 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8358 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8359 All callers changed.
8360
8361 * w32.c (_wsa_errlist): Use braces for struct initializers.
8362
8363 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8364 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8365 All callers changed.
8366 (string_buffer_position): Likewise. Also, make static (it's never
8367 used outside xdisp.c).
8368 (cursor_row_p): Remove parameter `w', unused since
8369 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8370 (decode_mode_spec): Remove parameter `precision', introduced during
8371 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8372 All callers changed.
8373
8374 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8375
8376 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8377
8378 2011-03-27 Anders Lindgren <andlind@gmail.com>
8379
8380 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8381 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8382 (ns_update_auto_hide_menu_bar): New functions.
8383 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8384 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8385 ns_constrain_all_frames.
8386 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8387 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8388
8389 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8390
8391 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8392
8393 2011-03-27 Glenn Morris <rgm@gnu.org>
8394
8395 * syssignal.h: Replace RETSIGTYPE with void.
8396 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8397 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8398 Replace SIGTYPE with void everywhere.
8399 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8400 * s/template.h (SIGTYPE): Remove commented out definition.
8401
8402 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8403
8404 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8405 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8406
8407 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8408
8409 * w32.c (read_unc_volume): Use parameter `henum', instead of
8410 global variable `wget_enum_handle'.
8411
8412 * keymap.c (describe_vector): Remove parameters `indices' and
8413 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8414 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8415
8416 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8417
8418 * keyboard.c (timer_check): Remove parameter `do_it_now',
8419 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8420 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8421 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8422
8423 * keyboard.c (read_char):
8424 * w32menu.c (w32_menu_display_help):
8425 * xmenu.c (show_help_event, menu_help_callback):
8426 Adjust calls to `show_help_echo'.
8427
8428 * gtkutil.c (xg_maybe_add_timer):
8429 * keyboard.c (readable_events):
8430 * process.c (wait_reading_process_output):
8431 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8432
8433 * insdel.c (adjust_markers_gap_motion):
8434 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8435 (gap_left, gap_right): Don't call it.
8436
8437 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8438
8439 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8440 incurred during fontification.
8441
8442 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8443
8444 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8445 (DEFVAR_PER_BUFFER): Don't pass it.
8446
8447 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8448 (scrolling_window): Don't pass it.
8449
8450 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8451
8452 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8453
8454 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8455 and `suffix'.
8456 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8457 of variables specific to SELinux and computation of `encoded_absname'.
8458
8459 * image.c (XPutPixel): Remove unused variable `height'.
8460
8461 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8462
8463 * unexw32.c (get_section_info): Remove unused variable `section'.
8464
8465 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8466 (system_process_attributes): Remove unused variable `sess'.
8467 (sys_read): Remove unused variable `err'.
8468
8469 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8470 (w32_wnd_proc): Remove unused variable `isdead'.
8471 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8472 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8473 (x_create_tip_frame): Remove unused variable `tem'.
8474
8475 * w32inevt.c (w32_console_read_socket):
8476 Remove unused variable `no_events'.
8477
8478 * w32term.c (x_draw_composite_glyph_string_foreground):
8479 Remove unused variable `width'.
8480
8481 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8482
8483 * w32term.c (x_set_glyph_string_clipping):
8484 Don't pass uninitialized region to CombineRgn.
8485
8486 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8487
8488 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8489 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8490 (Fx_close_connection): Remove unused variable `i'.
8491
8492 * w32font.c (w32font_draw): Return number of glyphs.
8493 (w32font_open_internal): Remove unused variable `i'.
8494 (w32font_driver): Add missing initializer.
8495
8496 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8497 (fill_in_menu): Remove unused variable `items_added'.
8498
8499 * w32term.c (last_mouse_press_frame): Remove static global variable.
8500 (w32_clip_to_row): Remove unused variable `f'.
8501 (x_delete_terminal): Remove unused variable `i'.
8502
8503 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8504 (NOTHING): Remove unused static global variable.
8505 (uniscribe_check_otf): Remove unused variable `table'.
8506 (uniscribe_font_driver): Add missing initializers.
8507
8508 2011-03-23 Julien Danjou <julien@danjou.info>
8509
8510 * term.c (Fsuspend_tty, Fresume_tty):
8511 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8512 * window.c (temp_output_buffer_show):
8513 * insdel.c (signal_before_change):
8514 * frame.c (Fhandle_switch_frame):
8515 * fileio.c (Fdo_auto_save):
8516 * emacs.c (Fkill_emacs):
8517 * editfns.c (save_excursion_restore):
8518 * cmds.c (internal_self_insert):
8519 * callint.c (Fcall_interactively):
8520 * buffer.c (Fkill_all_local_variables):
8521 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8522 Use Frun_hooks.
8523 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8524 unconditionally since it does the check itself.
8525
8526 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8527
8528 Fix more problems found by GCC 4.5.2's static checks.
8529
8530 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8531 the first time through the loop, since we know p0 < p1 then.
8532 This also avoids a gcc -Wstrict-overflow warning.
8533
8534 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8535 leading to a memory leak, possible in functions like
8536 load_charset_map_from_file that can allocate an unbounded number
8537 of objects (Bug#8318).
8538
8539 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8540 that could (at least in theory) be that large.
8541
8542 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8543 This is less likely to overflow, and avoids undefined behavior if
8544 overflow does occur. All callers changed. Use strtoul to scan
8545 for the unsigned long integer.
8546 (pint2hrstr): Simplify and tune code slightly.
8547 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8548
8549 * scroll.c (do_scrolling): Work around GCC bug 48228.
8550 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8551
8552 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8553 This also avoids a warning with gcc -Wstrict-overflow.
8554 (validate_x_resource_name): Simplify count usage.
8555 This also avoids a warning with gcc -Wstrict-overflow.
8556
8557 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8558 fail (Bug#8306).
8559
8560 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8561
8562 * process.c (Fmake_network_process): Use socklen_t, not int,
8563 where POSIX says socklen_t is required in portable programs.
8564 This fixes a porting bug on hosts like 64-bit HP-UX, where
8565 socklen_t is wider than int (Bug#8277).
8566 (Fmake_network_process, server_accept_connection):
8567 (wait_reading_process_output, read_process_output):
8568 Likewise.
8569
8570 * process.c: Rename or move locals to avoid shadowing.
8571 (list_processes_1, Fmake_network_process):
8572 (read_process_output_error_handler, exec_sentinel_error_handler):
8573 Rename or move locals.
8574 (Fmake_network_process): Define label "retry_connect" only if needed.
8575 (Fnetwork_interface_info): Fix pointer signedness.
8576 (process_send_signal): Add cast to avoid pointer signedness problem.
8577 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8578 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8579
8580 Make tparam.h and terminfo.c consistent.
8581 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8582 Include tparam.h instead, since it declares them.
8583 * cm.h (PC): Remove extern decl; tparam.h now does this.
8584 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8585 * terminfo.c: Include tparam.h, to check interfaces.
8586 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8587 (tparam): Adjust signature to match interface in tparam.h;
8588 this removes some undefined behavior. Check that outstring and len
8589 are zero, which they always are with Emacs.
8590 * tparam.h (PC, BC, UP): New extern decls.
8591
8592 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8593 (xftfont_open): Rename locals to avoid shadowing.
8594
8595 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8596 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8597 (OTF_TAG_SYM): Omit macro if not needed.
8598 (ftfont_list): Remove unused local.
8599 (get_adstyle_property, ftfont_pattern_entity):
8600 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8601 Rename locals to avoid shadowing.
8602
8603 * xfont.c (xfont_list_family): Mark var as initialized.
8604
8605 * xml.c (make_dom): Now static.
8606
8607 * composite.c (composition_compute_stop_pos): Rename local to
8608 avoid shadowing.
8609 (composition_reseat_it): Remove unused locals.
8610 (find_automatic_composition, composition_adjust_point): Likewise.
8611 (composition_update_it): Mark var as initialized.
8612 (find_automatic_composition): Mark vars as initialized,
8613 with a FIXME (Bug#8290).
8614
8615 character.h: Rename locals to avoid shadowing.
8616 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8617 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8618 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8619 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8620 to avoid shadowing.
8621
8622 * textprop.c (property_change_between_p): Remove; unused.
8623
8624 * intervals.c (interval_start_pos): Now static.
8625
8626 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8627
8628 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8629 Rename locals to avoid shadowing.
8630
8631 * sound.c (wav_play, au_play, Fplay_sound_internal):
8632 Fix pointer signedness.
8633 (alsa_choose_format): Remove unused local var.
8634 (wav_play): Initialize a variable to 0, to prevent undefined
8635 behavior (Bug#8278).
8636
8637 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8638
8639 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8640
8641 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8642 clobbering (Bug#8298).
8643 * sysdep.c (sys_subshell): Likewise.
8644 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8645
8646 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8647 This should get cleaned up, so that child_setup has the
8648 same signature on all platforms.
8649
8650 * callproc.c (call_process_cleanup): Now static.
8651 (relocate_fd): Rename locals to avoid shadowing.
8652
8653 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8654
8655 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8656 not to be necessary, and produces flickering.
8657
8658 2011-03-20 Glenn Morris <rgm@gnu.org>
8659
8660 * config.in: Remove file.
8661
8662 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8663
8664 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8665 are now in src/globals.h.
8666 (syms_of_minibuf): Remove spurious & from previous change.
8667
8668 2011-03-20 Leo Liu <sdl.web@gmail.com>
8669
8670 * minibuf.c (completing-read-function): New variable.
8671 (completing-read-default): Rename from completing-read.
8672 (completing-read): Call completing-read-function.
8673
8674 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8675
8676 * xfaces.c (Fx_load_color_file):
8677 Read color file from absolute filename (bug#8250).
8678
8679 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8680
8681 * makefile.w32-in: Update dependencies.
8682
8683 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8684
8685 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8686
8687 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8688
8689 Fix more problems found by GCC 4.5.2's static checks.
8690
8691 * process.c (make_serial_process_unwind, send_process_trap):
8692 (sigchld_handler): Now static.
8693
8694 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8695 That way, the code declares only the vars that it needs.
8696 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8697 * s/cygwin.h (PTY_ITERATION): Likewise.
8698 * s/darwin.h (PTY_ITERATION): Likewise.
8699 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8700
8701 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8702 * process.c (allocate_pty): Don't declare stb unless it's needed.
8703
8704 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8705 (CONSTANTLIM): Remove; unused.
8706 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8707 Define only if needed.
8708
8709 * unexelf.c (unexec): Name an expression,
8710 to avoid gcc -Wbad-function-cast warning.
8711 Use a different way to cause a compilation error if anyone uses
8712 n rather than nn, a way that does not involve shadowing.
8713 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8714
8715 * deps.mk (unexalpha.o): Remove; unused.
8716
8717 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8718 * unexec.h: New file.
8719 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8720 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8721 Depend on unexec.h.
8722 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8723 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8724 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8725 Change as necessary to match prototype in unexec.h.
8726
8727 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8728 shadowing.
8729 (back_comment, skip_chars): Mark vars as initialized.
8730
8731 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8732 Rename locals to avoid shadowing.
8733
8734 * lread.c (read1): Rewrite so as not to use empty "else".
8735 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8736
8737 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8738
8739 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8740 warning when compiling print.c.
8741
8742 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8743 instead of using an uninitialized var.
8744 (font_sort_entities): Mark var as initialized.
8745
8746 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8747
8748 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8749 pointers to constants.
8750 (font_parse_fcname): Remove unused vars.
8751 (font_delete_unmatched): Now static.
8752 (font_get_spec): Remove; unused.
8753 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8754 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8755 Rename or move locals to avoid shadowing.
8756
8757 * fns.c (require_nesting_list, require_unwind): Now static.
8758 (Ffillarray): Rename locals to avoid shadowing.
8759
8760 * floatfns.c (domain_error2): Define only if needed.
8761 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8762
8763 * alloc.c (mark_backtrace): Move decl from here ...
8764 * lisp.h: ... to here, so that it can be checked.
8765
8766 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8767 (Fdefvar): Rewrite so as not to use empty "else".
8768 (lisp_indirect_variable): Name an expression,
8769 to avoid gcc -Wbad-function-cast warning.
8770 (Fdefvar): Rename locals to avoid shadowing.
8771
8772 * callint.c (quotify_arg, quotify_args): Now static.
8773 (Fcall_interactively): Rename locals to avoid shadowing.
8774 Use const pointer when appropriate.
8775
8776 * lisp.h (get_system_name, get_operating_system_release):
8777 Move decls here, to check interfaces.
8778 * process.c (get_operating_system_release): Move decl to lisp.h.
8779 * xrdb.c (get_system_name): Likewise.
8780 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8781 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8782 some of which prompt warnings from gcc -Wbad-function-cast.
8783 (Fformat_time_string, Fencode_time, Finsert_char):
8784 (Ftranslate_region_internal, Fformat):
8785 Rename or remove local vars to avoid shadowing.
8786 (Ftranslate_region_internal): Mark var as initialized.
8787
8788 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8789 avoid shadowing.
8790
8791 * lisp.h (eassert): Check that the argument compiles, even if
8792 ENABLE_CHECKING is not defined.
8793
8794 * data.c (Findirect_variable): Name an expression, to avoid
8795 gcc -Wbad-function-cast warning.
8796 (default_value, arithcompare, arith_driver, arith_error): Now static.
8797 (store_symval_forwarding): Rename local to avoid shadowing.
8798 (Fmake_variable_buffer_local, Fmake_local_variable):
8799 Mark variables as initialized.
8800 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8801
8802 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8803 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8804 Rename locals to avoid shadowing.
8805 (mark_stack): Move local variables into the #ifdef region where
8806 they're used.
8807 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8808 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8809 needed otherwise.
8810 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8811 (GC_STRING_CHARS): Remove; not used.
8812 (Fmemory_limit): Cast sbrk's returned value to char *.
8813
8814 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8815 avoids undefined behavior in theory.
8816
8817 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8818
8819 Use functions, not macros, for up- and down-casing (Bug#8254).
8820 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8821 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8822 to use the following functions instead of these macros.
8823 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8824 EMACS_INT, since callers assume the returned value fits in int.
8825 (upcase1): Likewise, for UPCASE_TABLE.
8826 (uppercasep, lowercasep, upcase): New static inline functions.
8827 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8828 the race-condition problem in the old DOWNCASE.
8829
8830 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8831 Rename locals to avoid shadowing.
8832 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8833 (regex_compile, re_search_2, re_match_2_internal):
8834 Remove unused local vars.
8835 (FREE_VAR): Rewrite so as not to use empty "else",
8836 which gcc can warn about.
8837 (regex_compile, re_match_2_internal): Mark locals as initialized.
8838 (RETALLOC_IF): Define only if needed.
8839 (WORDCHAR_P): Likewise. This one is never needed, but is used
8840 only in a comment talking about a compiler bug, so put inside
8841 the #if 0 of that comment.
8842 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8843 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8844 Remove; unused.
8845
8846 * search.c (boyer_moore): Rename locals to avoid shadowing.
8847 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8848 (PREV_CHAR_BOUNDARY): Likewise.
8849
8850 * search.c (simple_search): Remove unused var.
8851
8852 * dired.c (compile_pattern): Move decl from here ...
8853 * lisp.h: ... to here, so that it can be checked.
8854 (struct re_registers): New forward decl.
8855
8856 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8857
8858 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8859 All uses changed.
8860 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8861 Rename locals to avoid shadowing.
8862 (Fvertical_motion): Mark locals as initialized.
8863
8864 * casefiddle.c (casify_object, casify_region): Now static.
8865 (casify_region): Mark local as initialized.
8866
8867 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8868
8869 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8870 New macros, so that the caller can use some names other than
8871 gcpro1, gcpro2, etc.
8872 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8873 of the new macros.
8874 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8875 argument, for consistency with GCPRO2_VAR, etc: it is now the
8876 prefix of the variable, not the variable itself. All uses
8877 changed.
8878 * dired.c (directory_files_internal, file_name_completion):
8879 Rename locals to avoid shadowing.
8880
8881 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8882 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8883 dired.c's scmp function, had undefined behavior.
8884 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8885 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8886 * buffer.h: ... to here, because these macros use current_buffer,
8887 and the new implementation with inline functions needs to have
8888 current_buffer in scope now, rather than later when the macros
8889 are used.
8890 (downcase, upcase1): New static inline functions.
8891 (DOWNCASE, UPCASE1): Reimplement using these functions.
8892 This avoids undefined behavior in expressions like
8893 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8894 from race conditions in accessing the global variables
8895 case_temp1 and case_temp2.
8896 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8897 * lisp.h (case_temp1, case_temp2): Remove their decls.
8898 * character.h (ASCII_CHAR_P): Move from here ...
8899 * lisp.h: ... to here, so that the inline functions mentioned
8900 above can use them.
8901
8902 * dired.c (directory_files_internal_unwind): Now static.
8903
8904 * fileio.c (file_name_as_directory, directory_file_name):
8905 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8906 Now static.
8907 (file_name_as_directory): Use const pointers when appropriate.
8908 (Fexpand_file_name): Likewise. In particular, newdir might
8909 point at constant storage, so make it a const pointer.
8910 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8911 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8912 signedness issues.
8913 (Fset_file_times, Finsert_file_contents, auto_save_error):
8914 Rename locals to avoid shadowing.
8915
8916 * minibuf.c (choose_minibuf_frame_1): Now static.
8917 (Ftry_completion, Fall_completions): Rename or remove locals
8918 to avoid shadowing.
8919
8920 * marker.c (bytepos_to_charpos): Remove; unused.
8921
8922 * lisp.h (verify_bytepos, count_markers): New decls,
8923 so that gcc does not warn that these functions aren't declared.
8924
8925 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8926 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8927 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8928 (copy_text): Remove unused local var.
8929
8930 * filelock.c (within_one_second): Now static.
8931 (lock_file_1): Rename local to avoid shadowing.
8932
8933 * buffer.c (fix_overlays_before): Mark locals as initialized.
8934 (fix_start_end_in_overlays): Likewise. This function should be
8935 simplified by using pointers-to-pointers, but that's a different
8936 matter.
8937 (switch_to_buffer_1): Now static.
8938 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8939 (report_overlay_modification): Rename locals to avoid shadowing.
8940
8941 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8942 Fix pointer signedness issue.
8943 (sys_subshell): Mark local as volatile if checking for lint,
8944 to suppress a gcc -Wclobbered warning that does not seem to be right.
8945 (MAXPATHLEN): Define only if needed.
8946
8947 * process.c (serial_open, serial_configure): Move decls from here ...
8948 * systty.h: ... to here, so that they can be checked.
8949
8950 * fns.c (get_random, seed_random): Move extern decls from here ...
8951 * lisp.h: ... to here, so that they can be checked.
8952
8953 * sysdep.c (reset_io): Now static.
8954 (wait_for_termination_signal): Remove; unused.
8955
8956 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8957 (copy_keymap_item, append_key, push_text_char_description):
8958 Now static.
8959 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8960 (DENSE_TABLE_SIZE): Remove; unused.
8961 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8962 (describe_map_tree):
8963 Rename locals to avoid shadowing.
8964
8965 * keyboard.c: Declare functions static if they are not used elsewhere.
8966 (echo_char, echo_dash, cmd_error, top_level_2):
8967 (poll_for_input, handle_async_input): Now static.
8968 (read_char, kbd_buffer_get_event, make_lispy_position):
8969 (make_lispy_event, make_lispy_movement, apply_modifiers):
8970 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8971 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8972 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8973 (read_key_sequence, read_char): Mark locals as initialized.
8974 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8975
8976 * keyboard.h (make_ctrl_char): New decl.
8977 (mark_kboards): Move decl here ...
8978 * alloc.c (mark_kboards): ... from here.
8979
8980 * lisp.h (force_auto_save_soon): New decl.
8981
8982 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8983 (DEFINE_DUMMY_FUNCTION): New macro.
8984 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8985 Use it.
8986 (main): Add casts to avoid warnings
8987 if GCC considers string literals to be constants.
8988
8989 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8990
8991 * dbusbind.c: Pointer signedness fixes.
8992 (xd_signature, xd_append_arg, xd_initialize):
8993 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8994 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8995 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8996 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8997
8998 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8999 if GCC considers string literals to be constants.
9000 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9001
9002 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9003
9004 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9005 (print_preprocess, print_object): New macro to fix last change.
9006
9007 * print.c (print_preprocess): Don't forget font objects.
9008
9009 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9010
9011 * emacs.c (USAGE3): Doc fixes.
9012
9013 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9014
9015 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9016 structure.
9017
9018 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9019
9020 * lisp.h (VWindow_system, Qfile_name_history):
9021 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9022 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9023 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9024
9025 * w32select.c: Don't #include "keyboard.h".
9026 (run_protected): Add extern declaration for waiting_for_input.
9027
9028 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9029 * w32console.c (detect_input_pending, read_input_pending)
9030 (encode_terminal_code):
9031 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9032 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9033 (w32_system_caret_y, Qfile_name_history):
9034 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9035 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9036 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9037 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9038 * w32proc.c (Qlocal, report_file_error):
9039 * w32term.c (Vwindow_system, updating_frame):
9040 * w32uniscribe.c (initialized, uniscribe_font_driver):
9041 Remove unneeded extern declarations.
9042
9043 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9044
9045 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9046
9047 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9048
9049 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9050 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9051 These macros can no longer be used for assignment.
9052
9053 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9054 Assign struct members directly, instead of using BUF_BEGV etc.
9055 (record_buffer_markers, fetch_buffer_markers): New functions for
9056 recording and fetching special buffer markers.
9057 (set_buffer_internal_1, set_buffer_temp): Use them.
9058
9059 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9060
9061 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9062
9063 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9064 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9065
9066 * xdisp.c (hscroll_window_tree):
9067 (reconsider_clip_changes): Use PT instead of BUF_PT.
9068
9069 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9070
9071 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9072 $(EMACS_ROOT)/lib/intprops.h.
9073
9074 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9075
9076 Fix more problems found by GCC 4.5.2's static checks.
9077
9078 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9079 to unsigned char * to avoid compiler diagnostic.
9080 (xg_free_frame_widgets): Make it clear that a local variable is
9081 needed only if USE_GTK_TOOLTIP.
9082 (gdk_window_get_screen): Make it clear that this macro is needed
9083 only if USE_GTK_TOOLTIP.
9084 (int_gtk_range_get_value): New function, which avoids a diagnostic
9085 from gcc -Wbad-function-cast.
9086 (xg_set_toolkit_scroll_bar_thumb): Use it.
9087 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9088 diagnostic from gcc -Wbad-function-cast.
9089 (get_utf8_string, xg_get_file_with_chooser):
9090 Rename locals to avoid shadowing.
9091 (create_dialog): Move locals to avoid shadowing.
9092
9093 * xgselect.c (xg_select): Remove unused var.
9094
9095 * image.c (four_corners_best): Mark locals as initialized.
9096 (gif_load): Initialize transparent_p to zero (Bug#8238).
9097 Mark another local as initialized.
9098 (my_png_error, my_error_exit): Mark with NO_RETURN.
9099
9100 * image.c (clear_image_cache): Now static.
9101 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9102 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9103 (x_edge_detection): Remove unnecessary cast that
9104 gcc -Wbad-function-cast diagnoses.
9105 (gif_load): Fix pointer signedness.
9106 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9107 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9108
9109 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9110
9111 Improve quality of tests for time stamp overflow.
9112 For example, without this patch (encode-time 0 0 0 1 1
9113 1152921504606846976) returns the obviously-bogus value (-948597
9114 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9115 reports time overflow. See
9116 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9117 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9118 * editfns.c: Include limits.h and intprops.h.
9119 (TIME_T_MIN, TIME_T_MAX): New macros.
9120 (time_overflow): Move earlier, to before first use.
9121 (hi_time, lo_time): New functions, for an accurate test for
9122 out-of-range times.
9123 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9124 (Fget_internal_run_time): Don't assume time_t fits in int.
9125 (make_time): Use list2 instead of Fcons twice.
9126 (Fdecode_time): More accurate test for out-of-range times.
9127 (check_tm_member): New function.
9128 (Fencode_time): Use it, to test for out-of-range times.
9129 (lisp_time_argument): Don't rely on undefined left-shift and
9130 right-shift behavior when checking for time stamp overflow.
9131
9132 * editfns.c (time_overflow): New function, refactoring common code.
9133 (Fformat_time_string, Fdecode_time, Fencode_time):
9134 (Fcurrent_time_string): Use it.
9135
9136 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9137 * dired.c (make_time): Move to ...
9138 * editfns.c (make_time): ... here.
9139 * systime.h: Note the move.
9140
9141 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9142
9143 * fringe.c (update_window_fringes): Remove unused variables.
9144
9145 * unexmacosx.c (copy_data_segment): Also copy __got section.
9146 (Bug#8223)
9147
9148 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9149
9150 * termcap.c [MSDOS]: Include "msdos.h".
9151 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9152 Constify `char *' arguments and their references according to
9153 prototypes in tparam.h.
9154
9155 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9156
9157 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9158 Adapt all references accordingly.
9159
9160 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9161
9162 2011-03-11 Tom Tromey <tromey@redhat.com>
9163
9164 * buffer.c (syms_of_buffer): Remove obsolete comment.
9165
9166 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9167
9168 * termhooks.h (encode_terminal_code): Declare prototype.
9169
9170 * msdos.c (encode_terminal_code): Don't declare prototype.
9171
9172 * term.c (encode_terminal_code): Now external again, used by
9173 w32console.c and msdos.c.
9174
9175 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9176 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9177
9178 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9179
9180 Fix some minor problems found by GCC 4.5.2's static checks.
9181
9182 * fringe.c (update_window_fringes): Mark locals as initialized
9183 (Bug#8227).
9184 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9185
9186 * alloc.c (mark_fringe_data): Move decl from here ...
9187 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9188 to check its interface.
9189 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9190
9191 * fontset.c (free_realized_fontset): Now static.
9192 (Fset_fontset_font): Rename local to avoid shadowing.
9193 (fontset_font): Mark local as initialized.
9194 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9195
9196 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9197
9198 * xselect.c (x_disown_buffer_selections): Remove; not used.
9199 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9200 (x_own_selection, Fx_disown_selection_internal): Rename locals
9201 to avoid shadowing.
9202 (x_handle_dnd_message): Remove local to avoid shadowing.
9203
9204 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9205 so that the caller can use some name other than gcpro1.
9206 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9207 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9208 (Fx_backspace_delete_keys_p):
9209 Use them to avoid shadowing, and rename vars to avoid shadowing.
9210 (x_decode_color, x_set_name, x_window): Now static.
9211 (Fx_create_frame): Add braces to silence GCC warning.
9212 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9213 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9214 Remove unused locals.
9215 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9216 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9217 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9218 macros.
9219
9220 * xterm.h (x_mouse_leave): New decl.
9221
9222 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9223 Remove unused functions.
9224 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9225 (x_calc_absolute_position): Now static.
9226 (XTread_socket): Don't define label "out" unless it's used.
9227 Don't declare local "event" unless it's used.
9228 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9229 unless they are used.
9230 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9231 (x_fatal_error_signal): Remove; not used.
9232 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9233 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9234 (x_error_catcher, x_connection_closed, x_error_handler):
9235 (x_error_quitter, xembed_send_message, x_iconify_frame):
9236 (my_log_handler): Rename locals to avoid shadowing.
9237 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9238 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9239
9240 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9241 Rename or move locals to avoid shadowing.
9242 (tty_defined_color, merge_face_heights): Now static.
9243 (free_realized_faces_for_fontset): Remove; not used.
9244 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9245 does not deduce is never used uninitialized.
9246 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9247 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9248
9249 * terminal.c (store_terminal_param): Now static.
9250
9251 * xmenu.c (menu_highlight_callback): Now static.
9252 (set_frame_menubar): Remove unused local.
9253 (xmenu_show): Rename parameter to avoid shadowing.
9254 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9255 since they might point to immutable storage.
9256 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9257 since it's unused otherwise.
9258
9259 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9260 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9261 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9262 avoids a gcc -Wuninitialized diagnostic.
9263 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9264 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9265 does not deduce are never used uninitialized.
9266
9267 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9268
9269 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9270 * window.c (window_loop, size_window):
9271 (run_window_configuration_change_hook, enlarge_window): Likewise.
9272
9273 * window.c (display_buffer): Now static.
9274 (size_window): Mark variables that gcc -Wuninitialized
9275 does not deduce are never used uninitialized.
9276 * window.h (check_all_windows): New decl, to forestall
9277 gcc -Wmissing-prototypes diagnostic.
9278 * dispextern.h (bidi_dump_cached_states): Likewise.
9279
9280 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9281 shadowing.
9282 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9283 Include <limits.h>.
9284 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9285 and to avoid gcc -Wuninitialized warning.
9286 (load_charset_map): Mark variables that gcc -Wuninitialized
9287 does not deduce are never used uninitialized.
9288 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9289
9290 * coding.c (coding_set_source, coding_set_destination):
9291 Use "else { /* comment */ }" rather than "else /* comment */;"
9292 for clarity, and to avoid gcc -Wempty-body warning.
9293 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9294 a block, when the outer 'i' will do.
9295 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9296 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9297 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9298 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9299 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9300 Rename locals to avoid shadowing.
9301 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9302 * coding.c (emacs_mule_char, encode_invocation_designation):
9303 Now static, since they're not used elsewhere.
9304 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9305 (decode_coding_object, encode_coding_object, detect_coding_system):
9306 (decode_coding_emacs_mule): Mark variables that gcc
9307 -Wuninitialized does not deduce are never used uninitialized.
9308 (detect_coding_iso_2022): Initialize a local variable that might
9309 be used uninitialized. Leave a FIXME because it's not clear that
9310 this initialization is needed. (Bug#8211)
9311 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9312 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9313 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9314 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9315 Remove unused macros.
9316
9317 * category.c (hash_get_category_set): Remove unused local var.
9318 (copy_category_table): Now static, since it's not used elsewhere.
9319 * character.c (string_count_byte8): Likewise.
9320
9321 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9322 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9323
9324 * chartab.c (copy_sub_char_table): Now static, since it's not used
9325 elsewhere.
9326 (sub_char_table_ref_and_range, char_table_ref_and_range):
9327 Rename locals to avoid shadowing.
9328 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9329
9330 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9331 (BIDI_BOB): Remove unused macro.
9332
9333 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9334 deduce are never used uninitialized.
9335 * term.c (encode_terminal_code): Likewise.
9336
9337 * term.c (encode_terminal_code): Now static. Remove unused local.
9338
9339 * tparam.h: New file.
9340 * term.c, tparam.h: Include it.
9341 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9342 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9343 Move these decls to tparam.h, and make them agree with what
9344 is actually in tparam.c. The previous trick of using incompatible
9345 decls in different modules does not conform to the C standard.
9346 All callers of tparam changed to use tparam's actual API.
9347 * tparam.c (tparam1, tparam, tgoto):
9348 Use const pointers where appropriate.
9349
9350 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9351 * cm.h (struct cm): Likewise.
9352 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9353 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9354 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9355 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9356 (turn_on_face, init_tty): Likewise.
9357 * termchar.h (struct tty_display_info): Likewise.
9358
9359 * term.c (term_mouse_position): Rename local to avoid shadowing.
9360
9361 * alloc.c (mark_ttys): Move decl from here ...
9362 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9363
9364 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9365
9366 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9367
9368 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9369
9370 * search.c (compile_pattern_1): Remove argument regp, unused since
9371 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9372 (compile_pattern): Don't pass it.
9373
9374 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9375
9376 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9377 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9378 for ! HAVE_GTK3.
9379 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9380
9381 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9382
9383 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9384 gdk_window_get_screen, gdk_window_get_geometry,
9385 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9386 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9387 (xg_get_pixbuf_from_pixmap): New function.
9388 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9389 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9390 Call xg_get_pixbuf_from_pixmap instead of
9391 gdk_pixbuf_get_from_drawable.
9392 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9393 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9394 (xg_check_special_colors): Use GtkStyleContext and its functions
9395 for HAVE_GTK3.
9396 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9397 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9398 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9399 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9400 Call gtk_widget_get_preferred_size.
9401 (xg_frame_resized): gdk_window_get_geometry only takes 5
9402 parameters.
9403 (xg_win_to_widget, xg_event_is_for_menubar):
9404 Call gdk_x11_window_lookup_for_display.
9405 (xg_set_widget_bg): New function.
9406 (delete_cb): New function.
9407 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9408 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9409 (xg_set_background_color): Call xg_set_widget_bg.
9410 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9411 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9412 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9413 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9414 if ! HAVE_GTK3.
9415 (update_frame_tool_bar): Call gtk_widget_hide.
9416 (xg_initialize): Use GDK_KEY_g.
9417
9418 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9419 if ! HAVE_GTK3
9420 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9421
9422 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9423 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9424 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9425
9426 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9427
9428 * w32xfns.c (select_palette): Check success of RealizePalette against
9429 GDI_ERROR, not zero.
9430
9431 See ChangeLog.11 for earlier changes.
9432
9433 ;; Local Variables:
9434 ;; coding: utf-8
9435 ;; End:
9436
9437 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9438
9439 This file is part of GNU Emacs.
9440
9441 GNU Emacs is free software: you can redistribute it and/or modify
9442 it under the terms of the GNU General Public License as published by
9443 the Free Software Foundation, either version 3 of the License, or
9444 (at your option) any later version.
9445
9446 GNU Emacs is distributed in the hope that it will be useful,
9447 but WITHOUT ANY WARRANTY; without even the implied warranty of
9448 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9449 GNU General Public License for more details.
9450
9451 You should have received a copy of the GNU General Public License
9452 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.