Integer and memory overflow fixes for display code.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 Integer and memory overflow fixes for display code.
4 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
6 Check for overflow in size calculations.
7 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8 Don't assume glyph table len fits in int.
9 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
10 (row_table_size): Now ptrdiff_t, not int.
11 (scrolling_window): Avoid overflow in size calculations.
12 Don't update size until allocation succeeds.
13 * fns.c (concat): Check for overflow in size calculations.
14 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
15 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
16 (NEXT_ALMOST_PRIME_LIMIT): New constant.
17
18 * composite.c: Integer overflow fixes.
19 (get_composition_id): Check for overflow in glyph length calculations.
20
21 * coding.c: Integer and memory overflow fixes.
22 (produce_chars): Redo buffer-overflow calculations to avoid
23 unnecessary integer overflow. Check for size overflow.
24 (encode_coding_object): Don't update size until xmalloc succeeds.
25
26 * character.c (Fstring): Check for size-calculation overflow.
27
28 * ccl.c: Integer and memory overflow fixes.
29 (Fccl_execute_on_string): Check for memory overflow.
30 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
31 Redo buffer-overflow calculations to avoid integer overflow.
32
33 * callproc.c (child_setup): Don't assume strlen fits in int.
34
35 * buffer.c: Memory overflow fixes.
36 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
37 Don't update size of array until after memory allocation succeeds,
38 because xmalloc/xrealloc may not return.
39
40 * bidi.c: Integer overflow fix.
41 (bidi_shelve_header_size): New constant.
42 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
43 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
44
45 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
46
47 Use ptrdiff_t for composition IDs.
48 * character.c (lisp_string_width):
49 * composite.c (composition_table_size, n_compositions)
50 (get_composition_id, composition_gstring_from_id):
51 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
52 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
53 * window.c (Frecenter):
54 Use ptrdiff_t, not int, for composition IDs.
55 * composite.c (get_composition_id): Check for integer overflow.
56 * composite.h: Adjust prototypes to match the above changes.
57
58 Use ptrdiff_t for hash table indexes.
59 * category.c (hash_get_category_set):
60 * ccl.c (ccl_driver):
61 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
62 * coding.c (coding_system_charset_list, detect_coding_system):
63 * coding.h (struct coding_system.id):
64 * composite.c (get_composition_id, gstring_lookup_cache):
65 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
66 * image.c (xpm_get_color_table_h):
67 * lisp.h (hash_lookup, hash_put):
68 * minibuf.c (Ftest_completion):
69 Use ptrdiff_t for hash table indexes, not int (which is too
70 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
71 32-bit --with-wide-int hosts).
72
73 * charset.c (Fdefine_charset_internal): Check for integer overflow.
74 Add a FIXME comment about memory leaks.
75 (syms_of_charset): Don't assume xmalloc returns.
76
77 Don't assume that stated character widths fit in int.
78 * character.c (Fchar_width, c_string_width, lisp_string_width):
79 * character.h (CHAR_WIDTH):
80 * indent.c (MULTIBYTE_BYTES_WIDTH):
81 Use sanitize_char_width to avoid undefined and/or bad behavior
82 with outlandish widths.
83 * character.h (sanitize_tab_width): Renamed from sanitize_width,
84 now that we have two such functions. All uses changed.
85 (sanitize_char_width): New inline function.
86
87 Don't assume that tab-width fits in int.
88 * character.h (sanitize_width): New inline function.
89 (SANE_TAB_WIDTH): New macro.
90 (ASCII_CHAR_WIDTH): Use it.
91 * indent.c (sane_tab_width): Remove. All uses replaced by
92 SANE_TAB_WIDTH (current_buffer).
93 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
94
95 * fileio.c: Integer overflow issues with file modes.
96 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
97
98 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
99 Remove unreachable code.
100 (read_hex, load_charset_map_from_file): Check for integer overflow.
101
102 * xterm.c: don't go over XClientMessageEvent limit
103 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
104 (x_send_scroll_bar_event): Likewise. Check that the size does not
105 exceed limits imposed by XClientMessageEvent, as well as the usual
106 ptrdiff_t and size_t limits.
107
108 * keyboard.c: Overflow, signedness and related fixes.
109 (make_lispy_movement): Use same integer type in forward decl
110 that is used in the definition.
111 (read_key_sequence, keyremap_step):
112 Change bufsize argument back to int, undoing my 2011-03-30 change.
113 We prefer signed types, and int is wide enough here.
114 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
115 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
116 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
117 length, not size_t. Use ptrdiff_t for index, not int.
118 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
119 possibility of integer overflow.
120
121 Overflow, signedness and related fixes for images.
122
123 * dispextern.h (struct it.stack[0].u.image.image_id)
124 (struct_it.image_id, struct image.id, struct image_cache.size)
125 (struct image_cache.used, struct image_cache.ref_count):
126 * gtkutil.c (update_frame_tool_bar):
127 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
128 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
129 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
130 * nsmenu.m (update_frame_tool_bar):
131 * xdisp.c (calc_pixel_width_or_height):
132 * xfns.c (image_cache_refcount):
133 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
134 on typical 64-bit hosts.
135
136 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
137 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
138 Omit unnecessary casts to int.
139 (parse_image_spec): Check that integers fall into 'int' range
140 when the callers expect that.
141 (image_ascent): Redo ascent calculation to avoid int overflow.
142 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
143 (lookup_image): Remove unnecessary tests.
144 (xbm_image_p): Locals are now of int, not EMACS_INT,
145 since parse_image_check makes sure they fit into int.
146 (png_load, gif_load, svg_load_image):
147 Prefer int to unsigned where either will do.
148 (tiff_handler): New function, combining the cores of the
149 old tiff_error_handler and tiff_warning_handler. This
150 function is rewritten to use vsnprintf and thereby avoid
151 stack buffer overflows. It uses only the features of vsnprintf
152 that are common to both POSIX and native Microsoft.
153 (tiff_error_handler, tiff_warning_handler): Use it.
154 (tiff_load, gif_load, imagemagick_load_image):
155 Don't assume :index value fits in 'int'.
156 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
157 (imagemagick_load_image): Check that crop parameters fit into
158 the integer types that MagickCropImage accepts. Don't assume
159 Vimagemagick_render_type has a nonnegative value. Don't assume
160 size_t fits in 'long'.
161 (gs_load): Use printmax_t to print the widest integers possible.
162 Check for integer overflow when computing image height and width.
163
164 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
165
166 Integer signedness and overflow and related fixes. (Bug#9079)
167
168 * bidi.c: Integer size and overflow fixes.
169 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
170 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
171 (bidi_cache_find_level_change, bidi_cache_ensure_space)
172 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
173 (bidi_find_other_level_edge):
174 Use ptrdiff_t instead of EMACS_INT where either will do.
175 This works better on 32-bit hosts configured --with-wide-int.
176 (bidi_cache_ensure_space): Check for size-calculation overflow.
177 Use % rather than repeated addition, for better worst-case speed.
178 Don't set bidi_cache_size until after xrealloc returns, because it
179 might not return.
180 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
181 (bidi_cache_ensure_space): Also check that the bidi cache size
182 does not exceed that of the largest Lisp string or buffer. See Eli
183 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
184
185 * alloc.c (__malloc_size_t): Remove.
186 All uses replaced by size_t. See Andreas Schwab's note
187 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
188
189 * image.c: Improve checking for integer overflow.
190 (check_image_size): Assume that f is nonnull, since
191 it is always nonnull in practice. This is one less thing to
192 worry about when checking for integer overflow later.
193 (x_check_image_size): New function, which checks for integer
194 overflow issues inside X.
195 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
196 This removes the need for a memory_full check.
197 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
198 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
199 (xbm_read_bitmap_data): Change locals back to 'int', since
200 their values must fit in 'int'.
201 (xpm_load_image, png_load, tiff_load):
202 Invoke x_create_x_image_and_pixmap earlier,
203 to avoid much needless work if the image is too large.
204 (tiff_load): Treat overly large images as if
205 x_create_x_image_and_pixmap failed, not as malloc failures.
206 (gs_load): Use x_check_image_size.
207
208 * gtkutil.c: Omit integer casts.
209 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
210 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
211
212 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
213
214 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
215 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
216 would wrongly return t on a 64-bit host.
217
218 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
219 The plain *_OVERFLOW macros run afoul of GCC bug 49705
220 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
221 and therefore cause GCC to emit a bogus diagnostic in some cases.
222
223 * image.c: Integer signedness and overflow and related fixes.
224 This is not an exhaustive set of fixes, but it's time to
225 record what I've got.
226 (lookup_pixel_color, check_image_size): Remove redundant decls.
227 (check_image_size): Don't assume that arbitrary EMACS_INT values
228 fit in 'int', or that arbitrary 'double' values fit in 'int'.
229 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
230 (tiff_load, imagemagick_load_image):
231 Check for overflow in size calculations.
232 (x_create_x_image_and_pixmap): Remove unnecessary test for
233 xmalloc returning NULL; that can't happen.
234 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
235 (xpm_color_bucket): Use better integer hashing function.
236 (xpm_cache_color): Don't possibly over-allocate memory.
237 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
238 (gif_memory_source):
239 Use ptrdiff_t, not int or size_t, to record sizes.
240 (png_load): Don't assume values greater than 2**31 fit in 'int'.
241 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
242 either works, as we prefer signed integers.
243 (tiff_read_from_memory, tiff_write_from_memory):
244 Return tsize_t, not size_t, since that's what the TIFF API wants.
245 (tiff_read_from_memory): Don't fail simply because the read would
246 go past EOF; instead, return a short read.
247 (tiff_load): Omit no-longer-needed casts.
248 (Fimagemagick_types): Don't assume size fits into 'int'.
249
250 Improve hashing quality when configured --with-wide-int.
251 * fns.c (hash_string): New function, taken from sxhash_string.
252 Do not discard information about ASCII character case; this
253 discarding is no longer needed.
254 (sxhash-string): Use it. Change sig to match it. Caller changed.
255 * lisp.h: Declare it.
256 * lread.c (hash_string): Remove, since we now use fns.c's version.
257 The fns.c version returns a wider integer if --with-wide-int is
258 specified, so this should help the quality of the hashing a bit.
259
260 * emacs.c: Integer overflow minor fix.
261 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
262 Define only if GNU_LINUX.
263 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
264
265 * dispnew.c: Integer signedness and overflow fixes.
266 Remove unnecessary forward decls, that were a maintenance hassle.
267 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
268 All uses changed.
269 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
270 (scrolling_window): Use ptrdiff_t, not int, for byte count.
271 (prepare_desired_row, line_draw_cost):
272 Use int, not unsigned, where either works.
273 (save_current_matrix, restore_current_matrix):
274 Use ptrdiff_t, not size_t, where either works.
275 (init_display): Check for overflow more accurately, and without
276 relying on undefined behavior.
277
278 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
279 Remove, replacing with the new symbols in lisp.h. All uses changed.
280 * fileio.c (make_temp_name):
281 * filelock.c (lock_file_1, lock_file):
282 * xdisp.c (message_dolog):
283 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
284 Use pMd etc. instead.
285 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
286 replacing the pWIDE etc. symbols removed from editfns.c.
287
288 * keyboard.h (num_input_events): Now uintmax_t.
289 This is (very slightly) less likely to mess up due to wraparound.
290 All uses changed.
291
292 * buffer.c: Integer signedness fixes.
293 (alloc_buffer_text, enlarge_buffer_text):
294 Use ptrdiff_t rather than size_t when either will do, as we prefer
295 signed integers.
296
297 * alloc.c: Integer signedness and overflow fixes.
298 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
299 (__malloc_size_t): Default to size_t, not to int.
300 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
301 (Fgarbage_collect, mark_object_loop_halt, mark_object):
302 Prefer ptrdiff_t to size_t when either would do, as we prefer
303 signed integers.
304 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
305 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
306 Now const. Initialize with values that are in range even if char
307 is signed.
308 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
309 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
310 These functions do the right thing with sizes > 2**32.
311 (check_depth): Now ptrdiff_t, not int.
312 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
313 Adjust to new way of storing sizes. Check for size overflow bugs
314 in rest of code.
315 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
316 slightly wrong anyway, as it missed one instance of
317 XMALLOC_OVERRUN_CHECK_OVERHEAD.
318 (refill_memory_reserve): Omit needless cast to size_t.
319 (mark_object_loop_halt): Mark as externally visible.
320
321 * xselect.c: Integer signedness and overflow fixes.
322 (Fx_register_dnd_atom, x_handle_dnd_message):
323 Use ptrdiff_t, not size_t, since we prefer signed.
324 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
325 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
326 x_dnd_atoms_size and x_dnd_atoms_length.
327
328 * doprnt.c: Prefer signed to unsigned when either works.
329 * eval.c (verror):
330 * doprnt.c (doprnt):
331 * lisp.h (doprnt):
332 * xdisp.c (vmessage):
333 Use ptrdiff_t, not size_t, when using or implementing doprnt,
334 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
335 prefer signed arithmetic to avoid comparison confusion.
336 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
337 but is a bit tricky.
338
339 Assume freestanding C89 headers, string.h, stdlib.h.
340 * data.c, doprnt.c, floatfns.c, print.c:
341 Include float.h unconditionally.
342 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
343 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
344 * regex.c: Likewise for stddef.h, string.h.
345 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
346 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
347 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
348 (STDC_HEADERS): Remove obsolete defines.
349 * sysdep.c: Include limits.h unconditionally.
350
351 Assume support for memcmp, memcpy, memmove, memset.
352 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
353 * regex.c (memcmp, memcpy):
354 Remove; we assume C89 now.
355
356 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
357 (__malloc_safe_bcopy): Remove; no longer needed.
358
359 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
360 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
361 well either way, and we prefer signed to unsigned.
362
363 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
364
365 Port to OpenBSD.
366 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
367 and the surrounding thread.
368 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
369 rather than fgets, and retry after EINTR. Otherwise, 'emacs
370 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
371 timer goes off.
372 * s/openbsd.h (BROKEN_SIGIO): Define.
373 * unexelf.c (unexec) [__OpenBSD__]:
374 Don't update the .mdebug section of the Alpha COFF symbol table.
375
376 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
377
378 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
379 (bug#8460).
380
381 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
382
383 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
384 This fixes some race conditions on the permissions of any newly
385 created file.
386
387 * alloc.c (valid_pointer_p): Use pipe, not open.
388 This fixes some permissions issues when debugging.
389
390 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
391 If fchown fails to set both uid and gid, try to set just gid,
392 as that is sometimes allowed. Adjust the file's mode to eliminate
393 setuid or setgid bits that are inappropriate if fchown fails.
394
395 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
396
397 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
398 to compare Lisp_Objects.
399 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
400 global_gnutls_log_level, don't mistake it for a Lisp_Object.
401 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
402
403 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
404
405 * lread.c (read_integer): Unread even EOF character.
406 (read1): Likewise. Properly record start position of symbol.
407
408 * lread.c (read1): Read `#:' as empty uninterned symbol if no
409 symbol character follows.
410
411 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
412
413 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
414 This works around a problem with the previous change to Fcopy_file.
415 Recent glibc declares fchown with __attribute__((warn_unused_result)),
416 and without this change, GCC might complain about discarding
417 fchown's return value.
418
419 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
420
421 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
422
423 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
424
425 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
426
427 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
428
429 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
430 it's used from the C level.
431
432 * process.c: Use the same condition for POLL_FOR_INPUT in both
433 keyboard.c and process.c (bug#1858).
434
435 2011-07-09 Lawrence Mitchell <wence@gmx.li>
436
437 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
438 (Fgnutls_boot): Use it.
439
440 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
441
442 * doc.c (Fsubstitute_command_keys): Revert last change.
443
444 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
445
446 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
447 quotes the next character, and doesn't affect other longer
448 sequences (bug#8935).
449
450 * lread.c (syms_of_lread): Clarify that is isn't only
451 `eval-buffer' and `eval-defun' that's affected by
452 `lexical-binding' (bug#8460).
453
454 2011-07-15 Eli Zaretskii <eliz@gnu.org>
455
456 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
457 bidi redisplay when a line includes both an image and is
458 truncated.
459
460 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
461
462 Fix minor problems found by static checking.
463 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
464 (elsz): Now a signed constant, not a size_t var. We prefer signed
465 types to unsigned, to avoid integer comparison confusion. Without
466 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
467 "cannot optimize loop, the loop counter may overflow", a symptom
468 of the confusion.
469 * indent.c (Fvertical_motion): Mark locals as initialized.
470 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
471
472 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
473
474 * search.c (Fre_search_backward): Mention `case-fold-search' in
475 all the re_search_* functions (bug#8138).
476
477 * keyboard.c (Fopen_dribble_file): Document when the file is
478 closed (bug#8056).
479
480 2011-07-14 Eli Zaretskii <eliz@gnu.org>
481
482 * bidi.c (bidi_dump_cached_states): Fix format of displaying
483 bidi_cache_idx.
484
485 Support bidi reordering of display and overlay strings.
486 * xdisp.c (compute_display_string_pos)
487 (compute_display_string_end): Accept additional argument STRING.
488 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
489 (reseat_to_string): Initialize bidi_it->string.s and
490 bidi_it->string.schars.
491 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
492 NULL (avoids a crash in bidi_paragraph_init). Initialize
493 itb.string.lstring.
494 (init_iterator): Call bidi_init_it only of a valid
495 buffer position was specified. Initialize paragraph_embedding to
496 L2R.
497 (reseat_to_string): Initialize the bidi iterator.
498 (display_string): If we need to ignore text properties of
499 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
500 original value of -1 will not work with bidi.)
501 (compute_display_string_pos): First arg is now struct
502 `text_pos *'; all callers changed. Support display properties on
503 Lisp strings.
504 (compute_display_string_end): Support display properties on Lisp
505 strings.
506 (init_iterator, reseat_1, reseat_to_string): Initialize the
507 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
508 when iterating on a string not from display properties).
509 (compute_display_string_pos, compute_display_string_end): Fix
510 calculation of the object to scan. Fixes an error when using
511 arrow keys.
512 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
513 base_level_stop; instead, set base_level_stop to BEGV. Fixes
514 crashes in vertical-motion.
515 (next_element_from_buffer): Improve commentary for when
516 the iterator is before prev_stop.
517 (init_iterator): Initialize bidi_p from the default value of
518 bidi-display-reordering, not from buffer-local value. Use the
519 buffer-local value only if initializing for buffer iteration.
520 (handle_invisible_prop): Support invisible properties on strings
521 that are being bidi-reordered.
522 (set_iterator_to_next): Support bidi reordering of C strings and
523 Lisp strings.
524 (next_element_from_string): Support bidi reordering of Lisp
525 strings.
526 (handle_stop_backwards): Support Lisp strings as well.
527 (display_string): Support display of R2L glyph rows. Use
528 IT_STRING_CHARPOS when displaying from a Lisp string.
529 (init_iterator): Don't initialize it->bidi_p for strings
530 here.
531 (reseat_to_string): Initialize it->bidi_p for strings here.
532 (next_element_from_string, next_element_from_c_string)
533 (next_element_from_buffer): Add xassert's for correspondence
534 between IT's object being iterated and it->bidi_it.string
535 structure.
536 (face_before_or_after_it_pos): Support bidi iteration.
537 (next_element_from_c_string): Handle the case of the first string
538 character that is not the first one in the visual order.
539 (get_visually_first_element): New function, refactored from common
540 parts of next_element_from_buffer, next_element_from_string, and
541 next_element_from_c_string.
542 (tool_bar_lines_needed, redisplay_tool_bar)
543 (display_menu_bar): Force left-to-right direction. Add a FIXME
544 comment for making that be controlled by a user option.
545 (push_it, pop_it): Save and restore the state of the
546 bidi iterator. Save and restore the bidi_p flag.
547 (pop_it): Iterate out of display property for string iteration as
548 well.
549 (iterate_out_of_display_property): Support iteration over strings.
550 (handle_single_display_spec): Set up it->bidi_it for iteration
551 over a display string, and call bidi_init_it.
552 (handle_single_display_spec, next_overlay_string)
553 (get_overlay_strings_1, push_display_prop): Set up the bidi
554 iterator for displaying display or overlay strings.
555 (forward_to_next_line_start): Don't use the shortcut if
556 bidi-iterating.
557 (back_to_previous_visible_line_start): If handle_display_prop
558 pushed the iterator stack, restore the internal state of the bidi
559 iterator by calling bidi_pop_it same number of times.
560 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
561 and we are bidi-iterating, don't decrement the iterator position;
562 instead, set the first_elt flag in the bidi iterator, to produce
563 the same effect.
564 (reseat_1): Remove redundant setting of string_from_display_prop_p.
565 (push_display_prop): xassert that we are iterating a buffer.
566 (push_it, pop_it): Save and restore paragraph_embedding member.
567 (handle_single_display_spec, next_overlay_string)
568 (get_overlay_strings_1, reseat_1, reseat_to_string)
569 (push_display_prop): Set up the `unibyte' member of bidi_it.string
570 correctly. Don't assume unibyte strings are not bidi-reordered.
571 (compute_display_string_pos)
572 (compute_display_string_end): Fix handling the case of C string.
573 (push_it, pop_it): Save and restore from_disp_prop_p.
574 (handle_single_display_spec, push_display_prop): Set the
575 from_disp_prop_p flag.
576 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
577 (pop_it): Call iterate_out_of_display_property only if we are
578 popping after iteration over a string that came from a display
579 property. Fix a typo in popping stretch info. Add an assertion
580 for verifying that the iterator position is in sync with the bidi
581 iterator.
582 (handle_single_display_spec, get_overlay_strings_1)
583 (push_display_prop): Fix initialization of paragraph direction for
584 string when that of the parent object is not yet determined.
585 (reseat_1): Call bidi_init_it to resync the bidi
586 iterator with IT's position. (Bug#7616)
587 (find_row_edges): If ROW->start.pos gives position
588 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
589 (handle_stop, back_to_previous_visible_line_start, reseat_1):
590 Reset the from_disp_prop_p flag.
591 (SAVE_IT, RESTORE_IT): New macros.
592 (pos_visible_p, face_before_or_after_it_pos)
593 (back_to_previous_visible_line_start)
594 (move_it_in_display_line_to, move_it_in_display_line)
595 (move_it_to, move_it_vertically_backward, move_it_by_lines)
596 (try_scrolling, redisplay_window, display_line): Use them when
597 saving a temporary copy of the iterator and restoring it back.
598 (back_to_previous_visible_line_start, reseat_1)
599 (init_iterator): Empty the bidi cache "stack".
600 (move_it_in_display_line_to): If iterator ended up at
601 EOL, but we never saw any buffer positions smaller than
602 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
603 motion in bidi-reordered lines.
604 (move_it_in_display_line_to): Record prev_method and prev_pos
605 immediately before the call to set_iterator_to_next. Fixes cursor
606 motion in bidi-reordered lines with stretch glyphs and strings
607 displayed in margins. (Bug#8133) (Bug#8867)
608 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
609 TO_CHARPOS.
610 (pos_visible_p): Support positions in bidi-reordered lines. Save
611 and restore bidi cache.
612
613 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
614 (bidi_paragraph_info): Delete unused struct.
615 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
616 (bidi_cache_start): New variable.
617 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
618 to zero.
619 (bidi_cache_fetch_state, bidi_cache_search)
620 (bidi_cache_find_level_change, bidi_cache_iterator_state)
621 (bidi_cache_find, bidi_peek_at_next_level)
622 (bidi_level_of_next_char, bidi_find_other_level_edge)
623 (bidi_move_to_visually_next): Compare cache index with
624 bidi_cache_start rather than with zero.
625 (bidi_fetch_char): Accept new argument STRING; all callers
626 changed. Support iteration over a string. Support strings with
627 display properties. Support unibyte strings. Fix the type of
628 `len' according to what STRING_CHAR_AND_LENGTH expects.
629 (bidi_paragraph_init, bidi_resolve_explicit_1)
630 (bidi_resolve_explicit, bidi_resolve_weak)
631 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
632 iteration over a string.
633 (bidi_set_sor_type, bidi_resolve_explicit_1)
634 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
635 can now be zero (for strings); special values 0 and -1 were
636 changed to -1 and -2, respectively.
637 (bidi_char_at_pos): New function.
638 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
639 Call it instead of FETCH_MULTIBYTE_CHAR.
640 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
641 initialized to valid values.
642 (bidi_init_it): Don't initialize charpos and bytepos with invalid
643 values.
644 (bidi_level_of_next_char): Allow the sentinel "position" to pass
645 the test for valid cached positions. Fix the logic for looking up
646 the sentinel state in the cache. GCPRO the Lisp string we are
647 iterating.
648 (bidi_push_it, bidi_pop_it): New functions.
649 (bidi_initialize): Initialize the bidi cache start stack pointer.
650 (bidi_cache_ensure_space): New function, refactored from part of
651 bidi_cache_iterator_state. Don't assume the required size is just
652 one BIDI_CACHE_CHUNK away.
653 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
654 (bidi_count_bytes, bidi_char_at_pos): New functions.
655 (bidi_cache_search): Don't assume bidi_cache_last_idx is
656 always valid if bidi_cache_idx is valid.
657 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
658 is valid if it's going to be used.
659 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
660 (bidi_cache_fetch_state, bidi_cache_search)
661 (bidi_cache_find_level_change, bidi_cache_ensure_space)
662 (bidi_cache_iterator_state, bidi_cache_find)
663 (bidi_find_other_level_edge, bidi_cache_start_stack): All
664 variables related to cache indices are now EMACS_INT.
665
666 * dispextern.h (struct bidi_string_data): New structure.
667 (struct bidi_it): New member `string'. Make flag members be 1-bit
668 fields, and put them last in the struct.
669 (compute_display_string_pos, compute_display_string_end): Update
670 prototypes.
671 (bidi_push_it, bidi_pop_it): Add prototypes.
672 (struct iterator_stack_entry): New members bidi_p,
673 paragraph_embedding, and from_disp_prop_p.
674 (struct it): Member bidi_p is now a bit field 1 bit wide.
675 (bidi_shelve_cache, bidi_unshelve_cache): Declare
676 prototypes.
677
678 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
679 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
680 and vector-like objects.
681
682 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
683 cache around display iteration.
684
685 * window.c (Fwindow_end, window_scroll_pixel_based)
686 (displayed_window_lines, Frecenter): Save and restore the bidi
687 cache around display iteration.
688
689 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
690
691 * editfns.c (Fdelete_region): Clarify the use of the named
692 parameters (bug#6788).
693
694 2011-07-14 Martin Rudalics <rudalics@gmx.at>
695
696 * indent.c (Fvertical_motion): Set and restore w->pointm when
697 saving and restoring the window's buffer (Bug#9006).
698
699 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
700
701 * editfns.c (Fstring_to_char): Clarify just what is returned
702 (bug#6576). Text by Eli Zaretskii.
703
704 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
705
706 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
707
708 2011-07-13 Eli Zaretskii <eliz@gnu.org>
709
710 * buffer.c (mmap_find): Fix a typo.
711
712 2011-07-13 Johan Bockgård <bojohan@gnu.org>
713
714 Fix execution of x selection hooks.
715 * xselect.c (Qx_lost_selection_functions)
716 (Qx_sent_selection_functions): New vars.
717 (syms_of_xselect): DEFSYM them.
718 (x_handle_selection_request): Pass Qx_sent_selection_functions
719 rather than Vx_sent_selection_functions to Frun_hook_with_args.
720 (x_handle_selection_clear,x_clear_frame_selections):
721 Pass Qx_lost_selection_functions rather than
722 Vx_lost_selection_functions to Frun_hook_with_args.
723
724 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
725
726 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
727 The old code sometimes used this field without initializing it.
728
729 * alloc.c (gc_sweep): Don't read past end of array.
730 In theory, the old code could also have corrupted Emacs internals,
731 though it'd be very unlikely.
732
733 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
734
735 * character.c (Fcharacterp): Don't advertise optional ignored
736 argument. (Bug#4026)
737
738 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
739
740 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
741 key" (bug#4257).
742
743 * window.c (Fset_window_start): Doc fix (bug#4199).
744 (Fset_window_hscroll): Ditto.
745
746 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
747
748 Fix minor new problems caught by GCC 4.6.1.
749 * term.c (init_tty): Remove unused local.
750 * xsettings.c (store_monospaced_changed): Define this function only
751 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
752 not used otherwise.
753
754 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
755
756 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
757
758 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
759
760 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
761 are the mini-buffer and the echo area (bug#3320).
762
763 * term.c (init_tty): Remove support for supdup, c10 and perq
764 terminals, which are no longer supported (bug#1482).
765
766 2011-07-10 Johan Bockgård <bojohan@gnu.org>
767
768 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
769
770 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
771
772 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
773 for non-popups (Bug#3642).
774
775 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
776
777 * alloc.c (reset_malloc_hooks): Protoize.
778 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
779 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
780 * cm.c (losecursor): Likewise.
781 * data.c (fmod): Likewise.
782 * dispnew.c (swap_glyphs_in_rows): Likewise.
783 * emacs.c (memory_warning_signal): Likewise.
784 * floatfns.c (float_error): Likewise.
785 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
786 (otf_open, font_otf_capability, generate_otf_features)
787 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
788 Likewise.
789 * image.c (pbm_read_file): Likewise.
790 * indent.c (string_display_width): Likewise.
791 * intervals.c (check_for_interval, search_for_interval)
792 (inc_interval_count, count_intervals, root_interval)
793 (adjust_intervals_for_insertion, make_new_interval): Likewise.
794 * lread.c (defalias): Likewise.
795 * ralloc.c (r_alloc_check): Likewise.
796 * regex.c (set_image_of_range_1, set_image_of_range)
797 (regex_grow_registers): Likewise.
798 * sysdep.c (strerror): Likewise.
799 * termcap.c (valid_filename_p, tprint, main): Likewise.
800 * tparam.c (main): Likewise.
801 * unexhp9k800.c (run_time_remap, save_data_space)
802 (update_file_ptrs, read_header, write_header, calculate_checksum)
803 (copy_file, copy_rest, display_header): Likewise.
804 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
805 Likewise.
806 * xdisp.c (check_it): Likewise.
807 * xfaces.c (register_color, unregister_color, unregister_colors):
808 Likewise.
809 * xfns.c (print_fontset_result): Likewise.
810 * xrdb.c (member, fatal, main): Likewise.
811
812 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
813
814 Fix minor problems found by static checking (Bug#9031).
815 * chartab.c (char_table_set_range, map_sub_char_table):
816 Remove unused locals.
817 (uniprop_table): Now static.
818 * composite.c (_work_char): Remove unused static var.
819
820 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
821
822 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
823
824 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
825
826 * gtkutil.c (qttip_cb): Remove code without function.
827
828 2011-07-09 Eli Zaretskii <eliz@gnu.org>
829
830 * w32.c (pthread_sigmask): New stub.
831
832 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
833
834 Use pthread_sigmask, not sigprocmask (Bug#9010).
835 sigprocmask is portable only for single-threaded applications, and
836 Emacs can be multi-threaded when it uses GTK.
837 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
838 (LIBES): Use it.
839 * callproc.c (Fcall_process):
840 * process.c (create_process):
841 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
842 Use pthread_sigmask, not sigprocmask.
843
844 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
845
846 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
847 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
848 wrong (Bug#8591).
849
850 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
851
852 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
853 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
854 (xg_hide_tooltip): Fix comment.
855
856 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
857 in registerServicesMenuSendTypes.
858 (validRequestorForSendType): Don't check ns_return_types.
859
860 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
861 ns_return_type.
862
863 2011-07-08 Jason Rumney <jasonr@gnu.org>
864
865 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
866 frame struct members of non-existent frames (Bug#6284).
867
868 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
869
870 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
871 variable firstTime not needed on OSX >= 10.6.
872 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
873 >= 10.5. Use setKnobProportion, setDoubleValue.
874
875 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
876 (MAC_OS_X_VERSION_10_5): Define if not defined.
877 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
878 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
879 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
880
881 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
882 cString and lossyCString on OSX >= 10.4
883
884 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
885 sizeToFit on OSX >= 10.2.
886
887 * nsimage.m (allocInitFromFile): Don't use deprecated method
888 bestRepresentationForDevice on OSX >= 10.6.
889
890 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
891 to avoid warning.
892
893 * emacs.c: Declare unexec_init_emacs_zone.
894
895 * nsgui.h: Fix compiler warning about gnulib redefining verify.
896
897 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
898
899 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
900 on svcsMenu (Bug#8842).
901
902 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
903 ns_return_types.
904 (Fns_list_services): Just return Qnil on 10.6, code not working there.
905
906 * nsterm.m (QUTF8_STRING): Declare.
907 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
908 (validRequestorForSendType): Return type is (id).
909 Change indexOfObjectIdenticalTo to indexOfObject.
910 Check if we have local selection before returning self (Bug#8842).
911 (writeSelectionToPasteboard): Put local selection into paste board
912 if we have a local selection (Bug#8842).
913 (syms_of_nsterm): DEFSYM QUTF8_STRING.
914
915 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
916 (ns_get_local_selection): Declare.
917
918 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
919
920 * keymap.c (describe_map_tree): Don't insert a double newline at
921 the end of the buffer (bug#1169) and return whether we inserted
922 something.
923
924 * callint.c (Fcall_interactively): Change "reading args" to
925 "providing args" to try to clarify what it does (bug#1010).
926
927 2011-07-07 Kenichi Handa <handa@m17n.org>
928
929 * composite.c (composition_compute_stop_pos): Ignore a static
930 composition starting before CHARPOS (Bug#8915).
931
932 * xdisp.c (handle_composition_prop): Likewise.
933
934 2011-07-07 Eli Zaretskii <eliz@gnu.org>
935
936 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
937 (Bug#9015)
938
939 2011-07-07 Kenichi Handa <handa@m17n.org>
940
941 * character.h (unicode_category_t): New enum type.
942
943 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
944 (Qchar_code_property_table): New variable.
945 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
946 (UNIPROP_COMPRESSED_FORM_P): New macros.
947 (char_table_ascii): Uncompress the compressed values.
948 (sub_char_table_ref): New arg is_uniprop. Callers changed.
949 Uncompress the compressed values.
950 (sub_char_table_ref_and_range): Likewise.
951 (char_table_ref_and_range): Uncompress the compressed values.
952 (sub_char_table_set): New arg is_uniprop. Callers changed.
953 Uncompress the compressed values.
954 (sub_char_table_set_range): Args changed. Callers changed.
955 (char_table_set_range): Adjuted for the above change.
956 (map_sub_char_table): Delete args default_val and parent. Add arg
957 top. Give decoded values to a Lisp function.
958 (map_char_table): Adjusted for the above change. Give decoded
959 values to a Lisp function. Gcpro more variables.
960 (uniprop_table_uncompress)
961 (uniprop_decode_value_run_length): New functions.
962 (uniprop_decoder, uniprop_decoder_count): New variables.
963 (uniprop_get_decoder, uniprop_encode_value_character)
964 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
965 New functions.
966 (uniprop_encoder, uniprop_encoder_count): New variables.
967 (uniprop_get_encoder, uniprop_table)
968 (Funicode_property_table_internal, Fget_unicode_property_internal)
969 (Fput_unicode_property_internal): New functions.
970 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
971 Sunicode_property_table_internal, Sget_unicode_property_internal,
972 and Sput_unicode_property_internal. Defvar_lisp
973 char-code-property-alist.
974
975 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
976 Vunicode_category_table.
977
978 * font.c (font_range): Adjusted for the change of
979 Vunicode_category_table.
980
981 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
982
983 * m/iris4d.h: Remove file, move contents ...
984 * s/irix6-5.h: ... here.
985
986 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
987
988 Remove unportable assumption about struct layout (Bug#8884).
989 * alloc.c (mark_buffer):
990 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
991 (clone_per_buffer_values): Don't assume that
992 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
993 This isn't true in general, and it's particularly not true
994 if Emacs is configured with --with-wide-int.
995 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
996 New macros, used in the buffer.c change.
997
998 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
999
1000 * xsettings.c: Use both GConf and GSettings if both are available.
1001 (store_config_changed_event): Add comment.
1002 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1003 (store_tool_bar_style_changed): New functions.
1004 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1005 (struct xsettings): Move font inside HAVE_XFT.
1006 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1007 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1008 Move inside HAVE_XFT.
1009 (something_changed_gsettingsCB): Renamed from something_changedCB.
1010 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1011 also.
1012 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1013 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1014 (something_changed_gconfCB): Renamed from something_changedCB.
1015 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1016 (parse_settings): Move check for font inside HAVE_XFT.
1017 (read_settings, apply_xft_settings): Add comment.
1018 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1019 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1020 call store_font_name_changed.
1021 (xft_settings_event): Add comment.
1022 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1023 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1024 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1025 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1026 (xsettings_initialize): Call init_gsettings last.
1027 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1028 comment.
1029
1030 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 Random fixes. E.g., (random) never returned negative values.
1033 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1034 subseconds part to the entropy, as that's a bit more random.
1035 Prefer signed to unsigned, since the signedness doesn't matter and
1036 in general we prefer signed. When given a limit, use a
1037 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1038 latter isn't right if USE_2_TAGS_FOR_INTS.
1039 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1040 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1041
1042 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1043
1044 * textprop.c (text_property_stickiness):
1045 Obey Vtext_property_default_nonsticky.
1046 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1047 * w32fns.c (syms_of_w32fns):
1048 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1049
1050 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1053 This is more efficient than Ffile_directory_p and avoids a minor race.
1054
1055 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1056
1057 * buffer.c (Foverlay_put): Say what the return value is
1058 (bug#7835).
1059
1060 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1061 is a directory before asking whether to use the file name
1062 (bug#7564).
1063 (barf_or_query_if_file_exists): Make the "File is a directory"
1064 error be more correct.
1065
1066 * fns.c (Frequire): Remove the mention of the .gz files, since
1067 that's installation-specific, but keep the mention of
1068 `get-load-suffixes'.
1069
1070 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1073 Report string overflow if the output is too long.
1074
1075 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1076
1077 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1078 (syms_of_gnutls): Remove duplicate DEFSYM for
1079 Qgnutls_bootprop_verify_hostname_error, an error for
1080 Qgnutls_bootprop_verify_error (which is no longer used).
1081
1082 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1083 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1084 Also (re)move comments that are misplaced or no longer relevant.
1085
1086 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1087
1088 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1089
1090 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1091
1092 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1093 and background color parameters if they have been changed.
1094
1095 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1096
1097 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1098
1099 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 * xsettings.c (SYSTEM_FONT): Define only when used.
1102 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1103
1104 * keymap.c (access_keymap_1): Now static.
1105
1106 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1107
1108 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1109 leave any prefix arg for the up event (Bug#1586).
1110
1111 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1112
1113 * lread.c (syms_of_lread): Mention single symbols defined by
1114 `defvar' or `defconst' (bug#7154).
1115
1116 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1117 (Frequire): Mention get-load-suffixes.
1118
1119 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1120
1121 * window.h (window): Remove clone_number slot.
1122 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1123 Remove.
1124 (make_parent_window, make_window, saved_window)
1125 (Fset_window_configuration, save_window_save): Don't deal with
1126 clone numbers.
1127 * buffer.c (Qclone_number): Remove declaration.
1128 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1129
1130 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1131
1132 Add multiple inheritance to keymaps.
1133 * keymap.c (Fmake_composed_keymap): New function.
1134 (Fset_keymap_parent): Simplify.
1135 (fix_submap_inheritance): Remove.
1136 (access_keymap_1): New function extracted from access_keymap to handle
1137 embedded parents and handle lists of maps.
1138 (access_keymap): Use it.
1139 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1140 (Fcopy_keymap): Handle embedded parents.
1141 (Fcommand_remapping, define_as_prefix): Simplify.
1142 (Fkey_binding): Simplify.
1143 (syms_of_keymap): Move minibuffer-local-completion-map,
1144 minibuffer-local-filename-completion-map,
1145 minibuffer-local-must-match-map, and
1146 minibuffer-local-filename-must-match-map to Elisp.
1147 (syms_of_keymap): Defsubr make-composed-keymap.
1148 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1149 (parse_menu_item): Trivial simplification.
1150
1151 2011-07-01 Glenn Morris <rgm@gnu.org>
1152
1153 * Makefile.in (SETTINGS_LIBS): Fix typo.
1154
1155 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1156
1157 * coding.c (Fencode_coding_string): Record the last coding system
1158 used, as the function doc string says (bug#8738).
1159
1160 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1161
1162 * xsettings.c (store_monospaced_changed): Take new font as arg and
1163 check for change against current_mono_font.
1164 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1165 (emacs_settings_constructor, emacs_settings_get_property)
1166 (emacs_settings_set_property, emacs_settings_class_init)
1167 (emacs_settings_init, gsettings_obj): Remove.
1168 (something_changedCB): New function for HAVE_GSETTINGS.
1169 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1170 with value as argument.
1171 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1172 g_settings_new (Bug#8967). Do not create gsettings_obj.
1173 Remove calls to g_settings_bind. Connect something_changedCB to
1174 "changed".
1175
1176 * xgselect.c: Add defined (HAVE_GSETTINGS).
1177 (xgselect_initialize): Ditto.
1178
1179 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1180 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1181 xg_select.
1182
1183 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * eval.c (struct backtrace): Simplify and port the data structure.
1186 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1187 signed bit field, as this assumption is not portable and it makes
1188 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1189 "char debug_on_exit : 1" as this is not portable either; instead,
1190 use the portable "unsigned int debug_on_exit : 1". Remove unused
1191 member evalargs. Remove obsolete comments about cc bombing out.
1192
1193 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1194
1195 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1196 Let HAVE_GSETTINGS override HAVE_GCONF.
1197 (store_monospaced_changed): New function.
1198 (EMACS_SETTINGS): A new type derived from GObject to handle
1199 GSettings notifications.
1200 (emacs_settings_constructor, emacs_settings_get_property)
1201 (emacs_settings_set_property, emacs_settings_class_init):
1202 New functions.
1203 (gsettings_client, gsettings_obj): New variables.
1204 (GSETTINGS_SCHEMA): New define.
1205 (something_changedCB): Call store_monospaced_changed.
1206 (init_gsettings): New function.
1207 (xsettings_initialize): Call init_gsettings.
1208 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1209 to NULL.
1210
1211 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1212 GCONF_CFLAGS/LIBS.
1213
1214 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1215
1216 * window.c (resize_root_window, grow_mini_window)
1217 (shrink_mini_window): Rename Qresize_root_window to
1218 Qwindow_resize_root_window and Qresize_root_window_vertically to
1219 Qwindow_resize_root_window_vertically.
1220
1221 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1222
1223 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1224
1225 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1226
1227 * makefile.w32-in: Redesign dependencies so they reflect more
1228 clearly which files are directly included by each source file,
1229 and not through other includes.
1230
1231 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1232
1233 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1234 (sort_overlays, overlay_strings): When an overlay's clone number
1235 matches the window's clone number process the overlay even if
1236 the overlay's window property doesn't match the current window.
1237
1238 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1239 (Fwindow_hchild): Rename to Fwindow_left_child.
1240 (Fwindow_next): Rename to Fwindow_next_sibling.
1241 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1242 (resize_window_check): Rename to window_resize_check.
1243 (resize_window_apply): Rename to window_resize_apply.
1244 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1245 (Fdelete_other_windows_internal, resize_frame_windows)
1246 (Fsplit_window_internal, Fdelete_window_internal)
1247 (grow_mini_window, shrink_mini_window)
1248 (Fresize_mini_window_internal): Fix callers accordingly.
1249
1250 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1251
1252 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1253 (emacs_fixed_set_min_size): Remove.
1254 (emacs_fixed_new): Take frame as argument.
1255
1256 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1257 (_EmacsFixedPrivate): Remove minwidth/height.
1258 Add struct frame *f.
1259 (emacs_fixed_init): Initialize priv->f.
1260 (get_parent_class, emacs_fixed_set_min_size): Remove.
1261 (emacs_fixed_new): Set priv->f to argument.
1262 (emacs_fixed_get_preferred_width)
1263 (emacs_fixed_get_preferred_height): Use min_width/height from
1264 frames size_hint to set minimum and natural (Bug#8919).
1265 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1266 and use min_width/height from frames size_hint to set
1267 min_width/height (Bug#8919).
1268
1269 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1270 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1271 Fix indentation.
1272
1273 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1274
1275 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1276 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1277 called at ZV.
1278
1279 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1280
1281 * process.c (wait_reading_process_output): Bypass select if
1282 waiting for a cell while ignoring keyboard input, and input is
1283 pending. Suggested by Jan Djärv (Bug#8869).
1284
1285 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1286
1287 Use gnulib's dup2 module instead of rolling our own.
1288 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1289
1290 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1291
1292 * dispnew.c (scrolling_window): Before scrolling, turn off a
1293 mouse-highlight in the window being scrolled.
1294
1295 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1296
1297 Move DEFSYM to lisp.h and use everywhere.
1298
1299 * character.h (DEFSYM): Move declaration...
1300 * lisp.h (DEFSYM): ...here.
1301
1302 * gnutls.c:
1303 * minibuf.c:
1304 * w32menu.c:
1305 * w32proc.c:
1306 * w32select.c: Don't include character.h.
1307
1308 * alloc.c (syms_of_alloc):
1309 * buffer.c (syms_of_buffer):
1310 * bytecode.c (syms_of_bytecode):
1311 * callint.c (syms_of_callint):
1312 * casefiddle.c (syms_of_casefiddle):
1313 * casetab.c (init_casetab_once):
1314 * category.c (init_category_once, syms_of_category):
1315 * ccl.c (syms_of_ccl):
1316 * cmds.c (syms_of_cmds):
1317 * composite.c (syms_of_composite):
1318 * dbusbind.c (syms_of_dbusbind):
1319 * dired.c (syms_of_dired):
1320 * dispnew.c (syms_of_display):
1321 * doc.c (syms_of_doc):
1322 * editfns.c (syms_of_editfns):
1323 * emacs.c (syms_of_emacs):
1324 * eval.c (syms_of_eval):
1325 * fileio.c (syms_of_fileio):
1326 * fns.c (syms_of_fns):
1327 * frame.c (syms_of_frame):
1328 * fringe.c (syms_of_fringe):
1329 * insdel.c (syms_of_insdel):
1330 * keymap.c (syms_of_keymap):
1331 * lread.c (init_obarray, syms_of_lread):
1332 * macros.c (syms_of_macros):
1333 * msdos.c (syms_of_msdos):
1334 * print.c (syms_of_print):
1335 * process.c (syms_of_process):
1336 * search.c (syms_of_search):
1337 * sound.c (syms_of_sound):
1338 * syntax.c (init_syntax_once, syms_of_syntax):
1339 * terminal.c (syms_of_terminal):
1340 * textprop.c (syms_of_textprop):
1341 * undo.c (syms_of_undo):
1342 * w32.c (globals_of_w32):
1343 * window.c (syms_of_window):
1344 * xdisp.c (syms_of_xdisp):
1345 * xfaces.c (syms_of_xfaces):
1346 * xfns.c (syms_of_xfns):
1347 * xmenu.c (syms_of_xmenu):
1348 * xsettings.c (syms_of_xsettings):
1349 * xterm.c (syms_of_xterm): Use DEFSYM.
1350
1351 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1352
1353 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1354
1355 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1356
1357 Integer and buffer overflow fixes (Bug#8873).
1358
1359 * print.c (printchar, strout): Check for string overflow.
1360 (PRINTPREPARE, printchar, strout):
1361 Don't set size unless allocation succeeds.
1362
1363 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1364 for sizes. Check for string overflow more accurately.
1365 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1366
1367 * macros.c: Integer and buffer overflow fixes.
1368 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1369 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1370 Use ptrdiff_t, not int, for sizes.
1371 Don't increment bufsize until after realloc succeeds.
1372 Check for size-calculation overflow.
1373 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1374
1375 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1376
1377 * lread.c: Integer overflow fixes.
1378 (read_integer): Radix is now EMACS_INT, not int,
1379 to improve quality of diagnostics for out-of-range radices.
1380 Calculate buffer size correctly for out-of-range radices.
1381 (read1): Check for integer overflow in radices, and in
1382 read-circle numbers.
1383 (read_escape): Avoid int overflow.
1384 (Fload, openp, read_buffer_size, read1)
1385 (substitute_object_recurse, read_vector, read_list, map_obarray):
1386 Use ptrdiff_t, not int, for sizes.
1387 (read1): Use EMACS_INT, not int, for sizes.
1388 Check for size overflow.
1389
1390 * image.c (cache_image): Check for size arithmetic overflow.
1391
1392 * lread.c: Integer overflow issues.
1393 (saved_doc_string_size, saved_doc_string_length)
1394 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1395 Now ptrdiff_t, not int.
1396 (read1): Don't assume doc string length fits in int. Check for
1397 out-of-range doc string lengths.
1398 (read_list): Don't assume file position fits in int.
1399 (read_escape): Check for hex character overflow.
1400
1401 2011-06-22 Leo Liu <sdl.web@gmail.com>
1402
1403 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1404 Move to minibuffer.el.
1405
1406 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1407
1408 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1409 The following patches are for when GLYPH_DEBUG && !XASSERT.
1410 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1411 * dispnew.c (flush_stdout):
1412 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1413 Mark as externally visible.
1414 * dispnew.c (check_window_matrix_pointers): Now static.
1415 * dispnew.c (window_to_frame_vpos):
1416 * xfns.c (unwind_create_frame):
1417 * xterm.c (x_check_font): Remove unused local.
1418 * scroll.c (CHECK_BOUNDS):
1419 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1420 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1421 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1422 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1423 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1424 Now static.
1425 (debug_method_add): Use va_list and vsprintf rather than relying
1426 on undefined behavior with wrong number of arguments.
1427 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1428 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1429 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1430 since we're not interested in debugging glyphs with old libraries.
1431 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1432 GCC 4.6.0's static checking.
1433
1434 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 Integer overflow and signedness fixes (Bug#8873).
1437 A few related buffer overrun fixes, too.
1438
1439 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1440
1441 * dispextern.h (struct face.stipple):
1442 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1443 (x_bitmap_mask, x_allocate_bitmap_record)
1444 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1445 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1446 (x_create_bitmap_from_xpm_data):
1447 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1448 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1449 (.bitmaps_last):
1450 * xfaces.c (load_pixmap):
1451 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1452 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1453 (.bitmaps_last, struct x_output.icon_bitmap):
1454 Use ptrdiff_t, not int, for bitmap indexes.
1455 (x_allocate_bitmap_record): Check for size overflow.
1456 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1457
1458 Use ptrdiff_t, not int, for overlay counts.
1459 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1460 * editfns.c (overlays_around, get_pos_property):
1461 * textprop.c (get_char_property_and_overlay):
1462 * xdisp.c (next_overlay_change, note_mouse_highlight):
1463 * xfaces.c (face_at_buffer_position):
1464 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1465 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1466 (Fnext_overlay_change, Fprevious_overlay_change)
1467 (mouse_face_overlay_overlaps, Foverlays_in):
1468 Use ptrdiff_t, not int, for sizes.
1469 (overlays_at, overlays_in): Check for size-calculation overflow.
1470
1471 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1472
1473 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1474 (x_session_initialize): Do not assume string length fits in int.
1475
1476 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1477 This is unlikely, but can occur if DPI is outlandish.
1478
1479 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1480 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1481
1482 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1483 * xrdb.c (magic_file_p, search_magic_path):
1484 Omit last arg SUFFIX; it was always 0. All callers changed.
1485 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1486
1487 * xfont.c (xfont_match): Avoid need for strlen.
1488
1489 * xfns.c: Don't assume strlen fits in int.
1490 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1491
1492 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1493 not unsigned long, as we prefer signed integers. All callers changed.
1494 Detect integer overflow in repeat count.
1495 (message_dolog): Don't assume print length fits in 39 bytes.
1496 (display_mode_element): Don't assume strlen fits in int.
1497
1498 * termcap.c: Don't assume sizes fit in int and never overflow.
1499 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1500 (gobble_line): Check for size-calculation overflow.
1501
1502 * minibuf.c (Fread_buffer):
1503 * lread.c (intern, intern_c_string):
1504 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1505 Don't assume string length fits in int.
1506
1507 * keyboard.c (parse_tool_bar_item):
1508 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1509
1510 * font.c: Don't assume string length fits in int.
1511 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1512 Use ptrdiff_t, not int.
1513 (font_intern_prop): Don't assume string length fits in int.
1514 Don't assume integer property fits in fixnum.
1515 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1516
1517 * filelock.c: Fix some buffer overrun and integer overflow issues.
1518 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1519 Reformulate so as not to need the command string.
1520 Invoke gzip -cd rather than gunzip, as it's more portable.
1521 (lock_info_type, lock_file_1, lock_file):
1522 Don't assume pid_t and time_t fit in unsigned long.
1523 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1524 (current_lock_owner): Prefer signed type for sizes.
1525 Use memcpy, not strncpy, where memcpy is what is really wanted.
1526 Don't assume (via atoi) that time_t and pid_t fit in int.
1527 Check for time_t and/or pid_t out of range, e.g., via a network share.
1528 Don't alloca where an auto var works fine.
1529
1530 * fileio.c: Fix some integer overflow issues.
1531 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1532 Don't assume string length fits in int.
1533 (directory_file_name): Don't assume string length fits in long.
1534 (make_temp_name): Don't assume pid fits in int, or that its print
1535 length is less than 20.
1536
1537 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1538
1539 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1540
1541 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1542
1543 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1544 We prefer signed integers, even for size calculations.
1545
1546 * emacs.c: Don't assume string length fits in 'int'.
1547 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1548 (main): Don't invoke strlen when not needed.
1549
1550 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1551 (XD_DEBUG_MESSAGE): Don't waste a byte.
1552
1553 * callproc.c (getenv_internal_1, getenv_internal)
1554 (Fgetenv_internal):
1555 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1556
1557 * lread.c (invalid_syntax): Omit length argument.
1558 All uses changed. This doesn't fix a bug, but it simplifies the
1559 code away from its former Hollerith-constant appearance, and it's
1560 one less 'int' to worry about when looking at integer-overflow issues.
1561 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1562
1563 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1564 This didn't break anything, but it didn't help either.
1565 It's confusing to put a bogus integer in a place where the actual
1566 value does not matter.
1567 (LIST_END_P): Remove unused macro and its bogus comment.
1568 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1569
1570 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1571 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1572 implementation.
1573 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1574 We prefer signed types, and the value cannot exceed the EMACS_INT
1575 range anyway (because otherwise the length would not be representable).
1576 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1577 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1578 This avoids a GCC warning when WIDE_EMACS_INT.
1579
1580 * indent.c (sane_tab_width): New function.
1581 (current_column, scan_for_column, Findent_to, position_indentation)
1582 (compute_motion): Use it. This is just for clarity.
1583 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1584
1585 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1586
1587 * lisp.h (lint_assume): New macro.
1588 * composite.c (composition_gstring_put_cache):
1589 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1590
1591 * editfns.c, insdel.c:
1592 Omit unnecessary forward decls, to simplify future changes.
1593
1594 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1595
1596 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1597
1598 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1599 Use much-faster test for byte-length change.
1600 Don't assume string byte-length fits in 'int'.
1601 Check that character arg fits in 'int'.
1602 (mapcar1): Declare byte as byte, for clarity.
1603
1604 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1605
1606 * fns.c (concat): Catch string overflow earlier.
1607 Do not rely on integer wraparound.
1608
1609 * dispextern.h (struct it.overlay_strings_charpos)
1610 (struct it.selective): Now EMACS_INT, not int.
1611 * xdisp.c (forward_to_next_line_start)
1612 (back_to_previous_visible_line_start)
1613 (reseat_at_next_visible_line_start, next_element_from_buffer):
1614 Don't arbitrarily truncate the value of 'selective' to int.
1615
1616 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1617
1618 * composite.c: Don't truncate sizes to 'int'.
1619 (composition_gstring_p, composition_reseat_it)
1620 (composition_adjust_point): Use EMACS_INT, not int.
1621 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1622 not EMACS_UINT, for indexes.
1623
1624 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1625
1626 * buffer.c: Include <verify.h>.
1627 (struct sortvec.priority, struct sortstr.priority):
1628 Now EMACS_INT, not int.
1629 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1630 (struct sortstr.size, record_overlay_string)
1631 (struct sortstrlist.size, struct sortlist.used):
1632 Don't truncate size to int.
1633 (record_overlay_string): Check for size-calculation overflow.
1634 (init_buffer_once): Check at compile-time, not run-time.
1635
1636 2011-06-22 Jim Meyering <meyering@redhat.com>
1637
1638 Don't leak an XBM-image-sized buffer
1639 * image.c (xbm_load): Free the image buffer after using it.
1640
1641 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1642
1643 Port to Sun C.
1644 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1645 that Sun C diagnosed.
1646 * fns.c (secure_hash): Fix pointer signedness issue.
1647 * intervals.c (static_offset_intervals): New function.
1648 (offset_intervals): Use it.
1649
1650 2011-06-21 Leo Liu <sdl.web@gmail.com>
1651
1652 * deps.mk (fns.o):
1653 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1654 sha512.h.
1655
1656 * fns.c (secure_hash): Rename from crypto_hash_function and change
1657 the first arg to accept symbols.
1658 (Fsecure_hash): New primitive.
1659 (syms_of_fns): New symbols.
1660
1661 2011-06-20 Deniz Dogan <deniz@dogan.se>
1662
1663 * process.c (Fset_process_buffer): Clarify return value in
1664 docstring.
1665
1666 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1667
1668 * dispnew.c (add_window_display_history): Use BVAR.
1669
1670 * xdisp.c (debug_method_add): Use BVAR.
1671 (check_window_end, dump_glyph_matrix, dump_glyph)
1672 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1673
1674 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1675 Likewise.
1676
1677 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1678 check till after the cache is created in init_frame_faces.
1679
1680 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1681
1682 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1683
1684 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1685
1686 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1687 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1688 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1689
1690 Improve buffer-overflow checking (Bug#8873).
1691 * fileio.c (Finsert_file_contents):
1692 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1693 Remove the old (too-loose) buffer overflow checks.
1694 They weren't needed, since make_gap checks for buffer overflow.
1695 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1696 The old code merely checked for Emacs fixnum overflow, and relied
1697 on undefined (wraparound) behavior. The new code avoids undefined
1698 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1699
1700 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1701 Tune. Don't use wider integers than needed. Don't use alloca.
1702 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1703
1704 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1705
1706 * insdel.c, lisp.h (buffer_overflow): New function.
1707 (insert_from_buffer_1, replace_range, replace_range_2):
1708 * insdel.c (make_gap_larger):
1709 * editfns.c (Finsert_char):
1710 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1711
1712 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1713
1714 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1715
1716 Integer overflow and signedness fixes (Bug#8873).
1717
1718 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1719 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1720
1721 * fileio.c: Don't assume EMACS_INT fits in off_t.
1722 (emacs_lseek): New static function.
1723 (Finsert_file_contents, Fwrite_region): Use it.
1724 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1725
1726 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1727
1728 * fns.c: Don't overflow int when computing a list length.
1729 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1730 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1731 truncation on 64-bit hosts. Check for QUIT every
1732 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1733 faster and is responsive enough.
1734 (Flength): Report an error instead of overflowing an integer.
1735 (Fsafe_length): Return a float if the value is not representable
1736 as a fixnum. This shouldn't happen except in contrived situations.
1737 (Fnthcdr, Fsort): Don't assume list length fits in int.
1738 (Fcopy_sequence): Don't assume vector length fits in int.
1739
1740 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1741 (header_size, word_size): New constants.
1742 (allocate_vectorlike): Don't check size overflow here.
1743 (allocate_vector): Check it here instead, since this is the only
1744 caller of allocate_vectorlike that could cause overflow.
1745 Check that the new vector's length is representable as a fixnum.
1746
1747 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1748 The previous code was bogus. For example, next_almost_prime (32)
1749 returned 39, which is undesirable as it is a multiple of 3; and
1750 next_almost_prime (24) returned 25, which is a multiple of 5 so
1751 why was the code bothering to check for multiples of 7?
1752
1753 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1754
1755 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1756
1757 Variadic C functions now count arguments with ptrdiff_t.
1758 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1759 Back then I didn't know that the Emacs coding style prefers signed int.
1760 Also, in the meantime I found a few more instances where arguments
1761 were being counted with int, which may truncate counts on 64-bit
1762 machines, or EMACS_INT, which may be unnecessarily wide.
1763 * lisp.h (struct Lisp_Subr.function.aMANY)
1764 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1765 Arg counts are now ptrdiff_t, not size_t.
1766 All variadic functions and their callers changed accordingly.
1767 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1768 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1769 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1770 * callint.c (Fcall_interactively): Check arg count for overflow,
1771 to avoid potential buffer overrun. Use signed char, not 'int',
1772 for 'varies' array, so that we needn't bother to check its size
1773 calculation for overflow.
1774 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1775 * eval.c (apply_lambda):
1776 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1777 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1778 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1779
1780 * callint.c (Fcall_interactively): Don't use index var as event count.
1781
1782 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1783 * mem-limits.h (SIZE): Remove; no longer used.
1784
1785 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1786
1787 Remove unnecessary casts.
1788 * xterm.c (x_term_init):
1789 * xfns.c (x_set_border_pixel):
1790 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1791 These aren't needed now that we assume ANSI C.
1792
1793 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1794 It's more likely to cause problems (due to unsigned overflow)
1795 than to cure them.
1796
1797 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1798
1799 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1800
1801 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1802
1803 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1804
1805 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1806
1807 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1808
1809 GLYPH_CODE_FACE returns EMACS_INT, not int.
1810 * dispextern.h (merge_faces):
1811 * xfaces.c (merge_faces):
1812 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1813 Don't assume EMACS_INT fits in int.
1814
1815 * character.h (CHAR_VALID_P): Remove unused parameter.
1816 * fontset.c, lisp.h, xdisp.c: All uses changed.
1817
1818 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1819
1820 * fns.c (concat): Minor tuning based on overflow analysis.
1821 This doesn't fix any bugs. Use int to hold character, instead
1822 of constantly refetching from Emacs object. Use XFASTINT, not
1823 XINT, for value known to be a character. Don't bother comparing
1824 a single byte to 0400, as it's always less.
1825
1826 * floatfns.c (Fexpt):
1827 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1828
1829 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1830 for characters.
1831
1832 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1833
1834 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1835 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1836 incorrectly succeed when S was a string, because 4294967386 was
1837 truncated before it was used.
1838
1839 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1840 Otherwise, an out-of-range integer could cause undefined behavior
1841 on a 64-bit host.
1842
1843 * composite.c: Use int, not EMACS_INT, for characters.
1844 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1845 EMACS_INT, for values that are known to be in character range.
1846 This doesn't fix any bugs but is the usual style inside Emacs and
1847 may generate better code on 32-bit machines.
1848
1849 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1850 This is for reasons similar to the recent CHAR_STRING fix.
1851 * charset.c (Fencode_char): Check that character arg is actually
1852 a character. Pass an int to ENCODE_CHAR.
1853 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1854 wider than 'int', as a compile-time check to prevent future regressions
1855 in this area.
1856
1857 * character.c (char_string): Remove unnecessary casts.
1858
1859 Make sure a 64-bit char is never passed to CHAR_STRING.
1860 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1861 by silently ignoring the top 32 bits, allowing some values
1862 that were far too large to be valid characters.
1863 * character.h: Include <verify.h>.
1864 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1865 arguments are no wider than unsigned, as a compile-time check
1866 to prevent future regressions in this area.
1867 * data.c (Faset):
1868 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1869 (Fsubst_char_in_region):
1870 * fns.c (concat):
1871 * xdisp.c (decode_mode_spec_coding):
1872 Adjust to CHAR_STRING's new requirement.
1873 * editfns.c (Finsert_char, Fsubst_char_in_region):
1874 * fns.c (concat): Check that character args are actually
1875 characters. Without this test, these functions did the wrong
1876 thing with wildly out-of-range values on 64-bit hosts.
1877
1878 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1879 These casts should not be needed on 32-bit hosts, either.
1880 * keyboard.c (read_char):
1881 * lread.c (Fload): Remove casts to unsigned.
1882
1883 * lisp.h (UNSIGNED_CMP): New macro.
1884 This fixes comparison bugs on 64-bit hosts.
1885 (ASCII_CHAR_P): Use it.
1886 * casefiddle.c (casify_object):
1887 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1888 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1889 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1890 * dispextern.h (FACE_FROM_ID):
1891 * keyboard.c (read_char): Use UNSIGNED_CMP.
1892
1893 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1894 not to EMACS_INT, to avoid GCC warning.
1895
1896 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1897
1898 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1899 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1900 isn't needed on 32-bit machines.
1901
1902 * buffer.c (Fgenerate_new_buffer_name):
1903 Use EMACS_INT for count, not int.
1904 (advance_to_char_boundary): Return EMACS_INT, not int.
1905
1906 * data.c (Qcompiled_function): Now static.
1907
1908 * window.c (window_body_lines): Now static.
1909
1910 * image.c (gif_load): Rename local to avoid shadowing.
1911
1912 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1913 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1914 * alloc.c (make_save_value): Integer argument is now of type
1915 ptrdiff_t, not int.
1916 (mark_object): Use ptrdiff_t, not int.
1917 * lisp.h (pD): New macro.
1918 * print.c (print_object): Use it.
1919
1920 * alloc.c: Use EMACS_INT, not int, to count objects.
1921 (total_conses, total_markers, total_symbols, total_vector_size)
1922 (total_free_conses, total_free_markers, total_free_symbols)
1923 (total_free_floats, total_floats, total_free_intervals)
1924 (total_intervals, total_strings, total_free_strings):
1925 Now EMACS_INT, not int. All uses changed.
1926 (Fgarbage_collect): Compute overall total using a double, so that
1927 integer overflow is less likely to be a problem. Check for overflow
1928 when converting back to an integer.
1929 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1930 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1931 These were 'int' variables that could overflow on 64-bit hosts;
1932 they were never used, so remove them instead of repairing them.
1933 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1934 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1935 Previously, this ceilinged at INT_MAX, but that doesn't work on
1936 64-bit machines.
1937 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1938
1939 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1940 (allocate_vectorlike): Check for ptrdiff_t overflow.
1941 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1942 when a (possibly-narrower) signed value would do just as well.
1943 We prefer using signed arithmetic, to avoid comparison confusion.
1944
1945 * alloc.c: Catch some string size overflows that we were missing.
1946 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1947 for convenience in STRING_BYTES_MAX.
1948 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1949 The definition here is exact; the one in lisp.h was approximate.
1950 (allocate_string_data): Check for string overflow. This catches
1951 some instances we weren't catching before. Also, it catches
1952 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1953 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1954 and ptrdiff_t and EMACS_INT are both 64 bits.
1955
1956 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1957 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1958 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1959
1960 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1961
1962 * alloc.c (Fmake_string): Check for out-of-range init.
1963
1964 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1965
1966 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1967
1968 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1969
1970 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1971 xg_get_default_scrollbar_width.
1972
1973 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1974 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1975 (style_changed_cb): Call update_theme_scrollbar_width and call
1976 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1977 all frames (Bug#8505).
1978 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1979 Call gtk_window_set_resizable if HAVE_GTK3.
1980 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1981 and height if HAVE_GTK3 (Bug#8505).
1982 (scroll_bar_width_for_theme): New variable.
1983 (update_theme_scrollbar_width): New function.
1984 (xg_get_default_scrollbar_width): Move code to
1985 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1986 (xg_initialize): Call update_theme_scrollbar_width.
1987
1988 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1989
1990 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1991
1992 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1993
1994 * frame.c (make_frame): Call other_buffer_safely instead of
1995 other_buffer.
1996
1997 * window.c (temp_output_buffer_show): Call display_buffer with
1998 second argument Vtemp_buffer_show_specifiers and reset latter
1999 immediately after the call.
2000 (Vtemp_buffer_show_specifiers): New variable.
2001 (auto_window_vscroll_p, next_screen_context_lines)
2002 (Vscroll_preserve_screen_position): Remove leading asterisks from
2003 doc-strings.
2004
2005 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2006
2007 Fix minor problems found by GCC 4.6.0 static checking.
2008 * buffer.c (Qclone_number): Remove for now, as it's unused.
2009 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2010 (record_buffer): Remove unused local.
2011 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2012 (set_frame_buffer_list): Remove; unused.
2013 * frame.h (other_visible_frames): Remove decl.
2014 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2015 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2016 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2017 if HAVE_GPM.
2018 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2019 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2020 Define only if HAVE_GPM.
2021 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2022 (update_hints_inhibit): Remove; never set. All uses removed.
2023 * widgetprv.h (emacsFrameClassRec): Remove decl.
2024 * window.c (delete_deletable_window): Now returns void, since it
2025 wasn't returning anything.
2026 (compare_window_configurations): Remove unused locals.
2027 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2028 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2029 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2030 the same widths as pointers. This follows up on the 2011-05-06 patch.
2031 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2032 * xterm.h: Likewise.
2033 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2034
2035 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2036
2037 * makefile.w32-in: Update dependencies.
2038 (LISP_H): Add lib/intprops.h.
2039
2040 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2041
2042 * image.c (gif_load): Add animation frame delay to the metadata.
2043 (syms_of_image): Use DEFSYM. New symbol `delay'.
2044
2045 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2046
2047 * window.c (delete_deletable_window): Re-add.
2048 (Fset_window_configuration): Rewrite to handle dead buffers and
2049 consequently deletable windows.
2050 (window_tree, Fwindow_tree): Remove. Supply functionality in
2051 window.el.
2052 (compare_window_configurations): Simplify code.
2053
2054 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2055
2056 * image.c (imagemagick_load_image): Fix type mismatch.
2057 (Fimagemagick_types): Likewise.
2058
2059 * window.h (replace_buffer_in_windows): Declare.
2060
2061 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2062
2063 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2064 Qclone_number. Remove external declaration of Qdelete_window.
2065 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2066 code.
2067 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2068 Qbuffer_list_update_hook if allowed.
2069 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2070 buffer list implementation.
2071 (other_buffer_safely): New function.
2072 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2073 calls to replace_buffer_in_windows and
2074 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2075 if allowed.
2076 (record_buffer): Inhibit quitting and rewrite using quittable
2077 functions. Run Qbuffer_list_update_hook if allowed.
2078 (Frecord_buffer, Funrecord_buffer): New functions.
2079 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2080 switch-to-buffer to window.el.
2081 (bury-buffer): Move to window.el.
2082 (Vbuffer_list_update_hook): New variable.
2083
2084 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2085 section.
2086
2087 * window.h (resize_frame_windows): Move up in code.
2088 (Fwindow_frame): Remove EXFUN.
2089 (replace_buffer_in_all_windows): Remove prototype.
2090 (replace_buffer_in_windows_safely): Add prototype.
2091
2092 * window.c: Declare Qdelete_window static again. Move down
2093 declaration of select_count.
2094 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2095 (Fother_window): Move to window.el.
2096 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2097 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2098 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2099 window.el.
2100 (replace_buffer_in_windows): Implement by calling
2101 Qreplace_buffer_in_windows.
2102 (replace_buffer_in_all_windows): Remove with some functionality
2103 moved into replace_buffer_in_windows_safely.
2104 (replace_buffer_in_windows_safely): New function.
2105 (select_window_norecord, select_frame_norecord): Move in front
2106 of run_window_configuration_change_hook. Remove now obsolete
2107 declarations.
2108 (Fset_window_buffer): Rewrite doc-string. Call
2109 Qrecord_window_buffer.
2110 (keys_of_window): Move binding for other-window to window.el.
2111
2112 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2113
2114 * dispextern.h (struct image): Replace data member, whose int_val
2115 and ptr_val fields were not used by anything, with a single
2116 lisp_val object.
2117
2118 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2119 (gif_clear_image, gif_load, imagemagick_load_image)
2120 (gs_clear_image, gs_load): Callers changed.
2121
2122 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2123
2124 * buffer.h: Include <time.h>, for time_t.
2125 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2126
2127 Fix minor problems found by static checking.
2128
2129 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2130
2131 Make identifiers static if they are not used in other modules.
2132 * data.c (Qcompiled_function, Qframe, Qvector):
2133 * image.c (QimageMagick, Qsvg):
2134 * minibuf.c (Qmetadata):
2135 * window.c (resize_window_check, resize_root_window): Now static.
2136 * window.h (resize_window_check, resize_root_window): Remove decls.
2137
2138 * window.c (window_deletion_count, delete_deletable_window):
2139 Remove; unused.
2140 (window_body_lines): Now static.
2141 (Fdelete_other_windows_internal): Mark vars as initialized.
2142 Make sure 'resize_failed' is initialized.
2143 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2144 (resize_window_apply): Remove unused local.
2145 * window.h (delete_deletable_window): Remove decl.
2146
2147 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2148 (imagemagick_load_image): Fix pointer signedness problem by changing
2149 last arg from unsigned char * to char *. All uses changed.
2150 Also, fix a local for similar reasons.
2151 Remove unused locals. Remove locals to avoid shadowing.
2152 (fn_rsvg_handle_free): Remove; unused.
2153 (svg_load, svg_load_image): Fix pointer signedness problem.
2154 (imagemagick_load_image): Don't use garbage pointer image_wand.
2155
2156 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2157
2158 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2159
2160 * image.c (gif_load): Fix omitted cast error introduced by
2161 2011-06-06 change.
2162
2163 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2164
2165 * window.h (resize_proportionally, orig_total_lines)
2166 (orig_top_line): Remove from window structure.
2167 (set_window_height, set_window_width, change_window_heights)
2168 (Fdelete_window): Remove prototypes.
2169 (resize_frame_windows): Remove duplicate declaration.
2170
2171 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2172
2173 * window.h (resize_frame_windows, resize_window_check)
2174 (delete_deletable_window, resize_root_window)
2175 (resize_frame_windows): Declare prototypes.
2176
2177 * window.c (resize_window_apply): Make definition be "static" to
2178 match the prototype.
2179
2180 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2181
2182 * window.c: Remove declarations of Qwindow_size_fixed,
2183 window_min_size_1, window_min_size_2, window_min_size,
2184 size_window, window_fixed_size_p, enlarge_window, delete_window.
2185 Remove static from declaration of Qdelete_window, it's
2186 temporarily needed by Fbury_buffer.
2187 (replace_window): Don't assign orig_top_line and
2188 orig_total_lines.
2189 (Fdelete_window, delete_window): Remove. Window deletion is
2190 handled by window.el.
2191 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2192 Fdelete_window calls with calls to Qdelete_window.
2193 (Fdelete_other_windows): Remove. Deleting other windows is
2194 handled by window.el.
2195 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2196 handled in window.el.
2197 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2198 Window minimum sizes are handled in window.el.
2199 (shrink_windows, size_window, set_window_height)
2200 (set_window_width, change_window_heights, window_height)
2201 (window_width, CURBEG, CURSIZE, enlarge_window)
2202 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2203 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2204 handled in window.el.
2205 (make_dummy_parent): Rename to make_parent_window and give it a
2206 second argument horflag.
2207 (make_window): Don't set resize_proportionally any more.
2208 (Fsplit_window): Remove. Windows are split in window.el.
2209 (save_restore_action, save_restore_orig_size)
2210 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2211 Resize mini windows in window.el.
2212 (grow_mini_window, shrink_mini_window): Implement by calling
2213 Qresize_root_window_vertically, resize_window_check and
2214 resize_window_apply.
2215 (saved_window, Fset_window_configuration, save_window_save): Do
2216 not handle orig_top_line, orig_total_lines, and
2217 resize_proportionally.
2218 (window_min_height, window_min_width): Move to window.el.
2219 (keys_of_window): Move bindings for delete-other-windows,
2220 split-window, delete-window and enlarge-window to window.el.
2221
2222 * buffer.c: Temporarily extern Qdelete_window.
2223 (Fbury_buffer): Temporarily call Qdelete_window instead of
2224 Fdelete_window (Fbury_buffer will move to window.el soon).
2225
2226 * frame.c (set_menu_bar_lines_1): Remove code handling
2227 orig_top_line and orig_total_lines.
2228
2229 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2230 set_window_height but set heights directly.
2231 (change_frame_size_1): Use resize_frame_windows.
2232
2233 * xdisp.c (init_xdisp): Don't use set_window_height but set
2234 heights directly.
2235
2236 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2237 resize_frame_windows instead of change_window_heights and run
2238 run_window_configuration_change_hook.
2239
2240 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2241 instead of change_window_heights and run
2242 run_window_configuration_change_hook.
2243
2244 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2245
2246 * window.c (replace_window): Rename second argument REPLACEMENT to
2247 NEW. New third argument SETFLAG. Rewrite.
2248 (delete_window, make_dummy_parent): Call replace_window with
2249 third argument 1.
2250 (window_list_1): Move down in code.
2251 (run_window_configuration_change_hook): Move set_buffer part
2252 before select_frame_norecord part in order to unwind correctly.
2253 Rename count1 to count.
2254 (recombine_windows, delete_deletable_window, resize_root_window)
2255 (Fdelete_other_windows_internal)
2256 (Frun_window_configuration_change_hook, make_parent_window)
2257 (resize_window_check, resize_window_apply, Fresize_window_apply)
2258 (resize_frame_windows, Fsplit_window_internal)
2259 (Fdelete_window_internal, Fresize_mini_window_internal): New
2260 functions.
2261 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2262
2263 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2264
2265 * window.h (window): Add some new members to window structure -
2266 normal_lines, normal_cols, new_total, new_normal, clone_number,
2267 splits, nest, prev_buffers, next_buffers.
2268 (WINDOW_TOTAL_SIZE): Move here from window.c.
2269 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2270
2271 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2272 Remove.
2273 (make_dummy_parent): Set new members of windows structure.
2274 (make_window): Move down in code. Handle new members of window
2275 structure.
2276 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2277 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2278 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2279 (Fset_window_prev_buffers, Fwindow_next_buffers)
2280 (Fset_window_next_buffers, Fset_window_clone_number): New
2281 functions.
2282 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2283 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2284 Doc-string fixes.
2285 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2286 Argument WINDOW can be now internal window too.
2287 (Fwindow_use_time): Move up in code.
2288 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2289 Rewrite doc-string.
2290 (Fset_window_configuration, saved_window)
2291 (Fcurrent_window_configuration, save_window_save): Handle new
2292 members of window structure.
2293 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2294 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2295 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2296 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2297 Qget_mru_window, Qresize_root_window,
2298 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2299 Qauto_buffer_name; staticpro them.
2300
2301 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2302
2303 * window.c (Fwindow_total_size, Fwindow_left_column)
2304 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2305 (Fwindow_list_1): New functions.
2306 (window_box_text_cols): Replace with window_body_cols.
2307 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2308 window_body_cols instead of window_box_text_cols.
2309 (delete_window, Fset_window_configuration): Call
2310 delete_all_subwindows with window as argument.
2311 (delete_all_subwindows): Take a window as argument and not a
2312 structure. Rewrite.
2313 (window_loop): Remove handling of GET_LRU_WINDOW and
2314 GET_LARGEST_WINDOW.
2315 (Fget_lru_window, Fget_largest_window): Move to window.el.
2316
2317 * window.h: Extern window_body_cols instead of
2318 window_box_text_cols. delete_all_subwindows now takes a
2319 Lisp_Object as argument.
2320
2321 * indent.c (compute_motion, Fcompute_motion): Use
2322 window_body_cols instead of window_box_text_cols.
2323
2324 * frame.c (delete_frame): Call delete_all_subwindows with root
2325 window as argument.
2326
2327 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2328
2329 * fns.c (Fputhash): Document return value.
2330
2331 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2332
2333 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2334
2335 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2336
2337 Cons<->int and similar integer overflow fixes (Bug#8794).
2338
2339 Check for overflow when converting integer to cons and back.
2340 * charset.c (Fdefine_charset_internal, Fdecode_char):
2341 Use cons_to_unsigned to catch overflow.
2342 (Fencode_char): Use INTEGER_TO_CONS.
2343 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2344 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2345 * data.c (long_to_cons, cons_to_long): Remove.
2346 (cons_to_unsigned, cons_to_signed): New functions.
2347 These signal an error for invalid or out-of-range values.
2348 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2349 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2350 * font.c (Ffont_variation_glyphs):
2351 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2352 * lisp.h: Include <intprops.h>.
2353 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2354 (cons_to_signed, cons_to_unsigned): New decls.
2355 (long_to_cons, cons_to_long): Remove decls.
2356 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2357 (Fprimitive_undo): Use CONS_TO_INTEGER.
2358 * xfns.c (Fx_window_property): Likewise.
2359 * xselect.c: Include <limits.h>.
2360 (x_own_selection, selection_data_to_lisp_data):
2361 Use INTEGER_TO_CONS.
2362 (x_handle_selection_request, x_handle_selection_clear)
2363 (x_get_foreign_selection, Fx_disown_selection_internal)
2364 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2365 (lisp_data_to_selection_data): Use cons_to_unsigned.
2366 (x_fill_property_data): Use cons_to_signed.
2367 Report values out of range.
2368
2369 Check for buffer and string overflow more precisely.
2370 * buffer.h (BUF_BYTES_MAX): New macro.
2371 * lisp.h (STRING_BYTES_MAX): New macro.
2372 * alloc.c (Fmake_string):
2373 * character.c (string_escape_byte8):
2374 * coding.c (coding_alloc_by_realloc):
2375 * doprnt.c (doprnt):
2376 * editfns.c (Fformat):
2377 * eval.c (verror):
2378 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2379 since they may not be the same number.
2380 * editfns.c (Finsert_char):
2381 * fileio.c (Finsert_file_contents):
2382 Likewise for BUF_BYTES_MAX.
2383
2384 * image.c: Use ptrdiff_t, not int, for sizes.
2385 (slurp_file): Switch from int to ptrdiff_t.
2386 All uses changed.
2387 (slurp_file): Check that file size fits in both size_t (for
2388 malloc) and ptrdiff_t (for sanity and safety).
2389
2390 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2391 if b->modtime has its maximal value.
2392
2393 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2394
2395 Don't assume time_t can fit into int.
2396 * buffer.h (struct buffer.modtime): Now time_t, not int.
2397 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2398 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2399
2400 Minor fixes for signed vs unsigned integers.
2401 * character.h (MAYBE_UNIFY_CHAR):
2402 * charset.c (maybe_unify_char):
2403 * keyboard.c (read_char, reorder_modifiers):
2404 XINT -> XFASTINT, since the integer must be nonnegative.
2405 * ftfont.c (ftfont_spec_pattern):
2406 * keymap.c (access_keymap, silly_event_symbol_error):
2407 XUINT -> XFASTINT, since the integer must be nonnegative.
2408 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2409 since it makes no difference and we prefer signed.
2410 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2411 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2412 nonnegative.
2413
2414 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2415
2416 * window.h (Fwindow_frame): Declare.
2417
2418 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2419
2420 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2421 (SPARE_MEMORY): Always define.
2422 (LARGE_REQUEST): Remove.
2423 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2424
2425 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2426
2427 * lisp.h: Move EXFUNS for Fframe_root_window,
2428 Fframe_first_window and Fset_frame_selected_window to window.h.
2429
2430 * window.h: Move EXFUNS for Fframe_root_window,
2431 Fframe_first_window and Fset_frame_selected_window here from
2432 lisp.h.
2433
2434 * frame.c (Fwindow_frame, Fframe_first_window)
2435 (Fframe_root_window, Fframe_selected_window)
2436 (Fset_frame_selected_window): Move to window.c.
2437 (Factive_minibuffer_window): Move to minibuf.c.
2438 (Fother_visible_frames_p): New function.
2439
2440 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2441
2442 * window.c (decode_window, decode_any_window): Move up in code.
2443 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2444 (inhibit_frame_unsplittable): Remove unused variable.
2445 (Fwindow_buffer): Move up and rewrite doc-string.
2446 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2447 (Fwindow_prev): New functions.
2448 (Fwindow_frame): Move here from frame.c. Accept any window as
2449 argument.
2450 (Fframe_root_window, Fframe_first_window)
2451 (Fframe_selected_window): Move here from frame.c. Accept frame
2452 or arbitrary window as argument. Update doc-strings.
2453 (Fminibuffer_window): Move up in code.
2454 (Fwindow_minibuffer_p): Move up in code and simplify.
2455 (Fset_frame_selected_window): Move here from frame.c.
2456 Marginal rewrite.
2457 (Fselected_window, select_window, Fselect_window): Move up in
2458 code. Minor doc-string fixes.
2459
2460 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2461
2462 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2463 Do not assume that spare memory exists; that assumption is valid
2464 only if SYSTEM_MALLOC.
2465 (LARGE_REQUEST): New macro, so that the issue of large requests
2466 is separated from the issue of spare memory.
2467
2468 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2469
2470 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2471 format. (Bug#8806)
2472
2473 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2474
2475 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2476 before statements.
2477
2478 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2479
2480 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2481
2482 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2483
2484 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2485 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2486
2487 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2488
2489 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2490
2491 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2492
2493 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2494 (x_clipboard_manager_save): Add return value.
2495 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2496 New error handlers.
2497 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2498 Obey Vx_select_enable_clipboard_manager. Catch errors in
2499 x_clipboard_manager_save (Bug#8779).
2500 (Vx_select_enable_clipboard_manager): New variable.
2501 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2502
2503 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2504
2505 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2506
2507 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2508
2509 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2510 in the current matrix if keep_current_p is non-zero.
2511
2512 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2513
2514 * bidi.c (bidi_level_of_next_char): Fix last change.
2515
2516 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2517
2518 Support bidi reordering of text covered by display properties.
2519
2520 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2521 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2522 (bidi_cache_search, bidi_cache_iterator_state)
2523 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2524 (bidi_level_of_next_char, bidi_move_to_visually_next):
2525 Support character positions inside a run of characters covered by a
2526 display string.
2527 (bidi_paragraph_init, bidi_resolve_explicit_1)
2528 (bidi_level_of_next_char): Call bidi_fetch_char and
2529 bidi_fetch_char_advance instead of FETCH_CHAR and
2530 FETCH_CHAR_ADVANCE.
2531 (bidi_init_it): Initialize new members.
2532 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2533 definitions.
2534 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2535 instead of using explicit *_CHAR codes.
2536 (bidi_resolve_explicit, bidi_resolve_weak):
2537 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2538 bidirectional text is supported only in multibyte buffers.
2539 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2540 it to initialize the frame_window_p member of struct bidi_it.
2541 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2542 (bidi_resolve_explicit, bidi_resolve_weak)
2543 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2544 bidi_it->nchars is non-positive.
2545 (bidi_level_of_next_char): Don't try to lookup the cache for the
2546 next/previous character if nothing is cached there yet, or if we
2547 were just reseat()'ed to a new position.
2548
2549 * xdisp.c (set_cursor_from_row): Set start and stop points
2550 according to the row's direction when priming the loop that looks
2551 for the glyph on which to display cursor.
2552 (single_display_spec_intangible_p): Function deleted.
2553 (display_prop_intangible_p): Reimplement to call
2554 handle_display_spec instead of single_display_spec_intangible_p.
2555 Accept 3 additional arguments needed by handle_display_spec.
2556 This fixes incorrect cursor motion across display property with complex
2557 values: lists, `(when COND...)' forms, etc.
2558 (single_display_spec_string_p): Support property values that are
2559 lists with the argument STRING its top-level element.
2560 (display_prop_string_p): Fix the condition for processing a
2561 property that is a list to be consistent with handle_display_spec.
2562 (handle_display_spec): New function, refactored from the
2563 last portion of handle_display_prop.
2564 (compute_display_string_pos): Accept additional argument
2565 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2566 value of a `display' property is a "replacing spec".
2567 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2568 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2569 the display property, but just return a value indicating whether
2570 the display property will replace the characters it covers.
2571 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2572 frame_window_p members of struct bidi_it.
2573 (compute_display_string_pos, compute_display_string_end):
2574 New functions.
2575 (push_it): Accept second argument POSITION, where pop_it should
2576 jump to continue iteration.
2577 (reseat_1): Initialize bidi_it.disp_pos.
2578
2579 * keyboard.c (adjust_point_for_property): Adjust the call to
2580 display_prop_intangible_p to its new signature.
2581
2582 * dispextern.h (struct bidi_it): New member frame_window_p.
2583 (bidi_init_it): Update prototypes.
2584 (display_prop_intangible_p): Update prototype.
2585 (compute_display_string_pos, compute_display_string_end):
2586 Declare prototypes.
2587 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2588 EMACS_INT.
2589
2590 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 Malloc failure behavior now depends on size of allocation.
2593 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2594 * lisp.h: Change signatures accordingly.
2595 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2596 All callers changed. (Bug#8762)
2597
2598 * gnutls.c: Use Emacs's memory allocators.
2599 Without this change, the gnutls library would invoke malloc etc.
2600 directly, which causes problems on non-SYNC_INPUT hosts, and which
2601 runs afoul of improving memory_full behavior. (Bug#8761)
2602 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2603 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2604 xfree instead of the default malloc, realloc, free.
2605 (Fgnutls_boot): No need to check for memory allocation failure,
2606 since xmalloc does that for us.
2607
2608 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2609 * category.c (hash_get_category_set):
2610 * ccl.c (ccl_driver):
2611 * charset.c (Fdefine_charset_internal):
2612 * charset.h (struct charset.hash_index):
2613 * composite.c (get_composition_id, gstring_lookup_cache)
2614 (composition_gstring_put_cache):
2615 * composite.h (struct composition.hash_index):
2616 * dispextern.h (struct image.hash):
2617 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2618 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2619 (hashfn_equal, hashfn_user_defined, make_hash_table)
2620 (maybe_resize_hash_table, hash_lookup, hash_put)
2621 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2622 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2623 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2624 * image.c (make_image, search_image_cache, lookup_image)
2625 (xpm_put_color_table_h):
2626 * lisp.h (struct Lisp_Hash_Table):
2627 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2628 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2629 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2630 * alloc.c (allocate_vectorlike):
2631 Check for overflow in vector size calculations.
2632 * ccl.c (ccl_driver):
2633 Check for overflow when converting EMACS_INT to int.
2634 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2635 need to be updated by these changes.
2636 * fns.c (make_hash_table, maybe_resize_hash_table):
2637 Check for integer overflow with large hash tables.
2638 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2639 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2640 (SXHASH_REDUCE): New macro.
2641 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2642 Use it instead of discarding useful hash info with large hash values.
2643 (sxhash_float): New function.
2644 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2645 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2646 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2647 Rewrite to use FIXNUM_BITS, as this simplifies things.
2648 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2649 Adjust signatures to match updated version of code.
2650 (consing_since_gc): Now EMACS_INT, since a single hash table can
2651 use more than INT_MAX bytes.
2652
2653 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2654
2655 Make it possible to build with GCC-4.6+ -O2 -flto.
2656
2657 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2658
2659 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2660
2661 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2662 Call minibuffer-inactive-mode.
2663
2664 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2665
2666 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2667 Update dependencies.
2668
2669 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2670
2671 * data.c (init_data): Remove code for UTS, this system is not
2672 supported anymore.
2673
2674 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2675
2676 Don't force ./temacs to start in terminal mode.
2677
2678 * frame.c (make_initial_frame): Initialize faces in all cases, not
2679 only when CANNOT_DUMP is defined.
2680 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2681
2682 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2683
2684 * dispnew.c (add_window_display_history): Use const for the string
2685 pointer. Remove declaration, not needed.
2686
2687 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 Use 'inline', not 'INLINE'.
2690 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2691 * alloc.c, fontset.c (INLINE): Remove.
2692 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2693 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2694 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2695 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2696 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2697
2698 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2699
2700 Make it possible to run ./temacs.
2701
2702 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2703 syms_of_callproc does the same thing. Remove test for
2704 "initialized", do it in the caller.
2705 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2706
2707 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2708
2709 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2710 (read_minibuf): Use get_minibuffer.
2711 (syms_of_minibuf): Use DEFSYM.
2712 (Qmetadata): New var.
2713 * data.c (Qbuffer): Don't make it static.
2714 (syms_of_data): Use DEFSYM.
2715
2716 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2717
2718 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2719 (CCL_CODE_MIN): New macro.
2720
2721 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2722
2723 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2724
2725 * eval.c (Qdebug): Now static.
2726 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2727 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2728 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2729
2730 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2731
2732 * image.c: Various fixes to ImageMagick code comments.
2733 (Fimagemagick_types): Doc fix.
2734
2735 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 Minor fixes prompted by GCC 4.6.0 warnings.
2738
2739 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2740
2741 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2742 (x_clipboard_manager_save_all): Move extern decl to ...
2743 * xterm.h: ... here, so that it can be checked for consistency.
2744
2745 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2746
2747 * xselect.c (x_clipboard_manager_save_frame)
2748 (x_clipboard_manager_save_all): New functions.
2749 (Fx_clipboard_manager_save): Lisp function deleted.
2750
2751 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2752 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2753
2754 * xterm.h: Update prototype.
2755
2756 2011-05-28 William Xu <william.xwl@gmail.com>
2757
2758 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2759 exiting (Bug#8239).
2760
2761 2011-05-28 Jim Meyering <meyering@redhat.com>
2762
2763 Avoid a sign-extension bug in crypto_hash_function.
2764 * fns.c (to_uchar): Define.
2765 (crypto_hash_function): Use it to convert some newly-signed
2766 variables to unsigned, to avoid sign-extension bugs. For example,
2767 without this change, (md5 "truc") would evaluate to
2768 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2769 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2770 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2771
2772 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2773
2774 Integer overflow fixes.
2775
2776 * dbusbind.c: Serial number integer overflow fixes.
2777 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2778 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2779 to hold a serial number that is too large for a fixnum.
2780 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2781 Check for serial numbers out of range. Decode any serial number
2782 that was so large that it became a float. (Bug#8722)
2783
2784 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2785 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2786 Use XFASTINT rather than XUINT when numbers are nonnegative.
2787 (xd_append_arg, Fdbus_method_return_internal):
2788 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2789 arguments, check that Lisp number is nonnegative, rather than
2790 silently wrapping negative numbers around. (Bug#8722)
2791 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2792 (Bug#8722)
2793
2794 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2795
2796 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2797
2798 ccl: add integer overflow checks
2799 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2800 (IN_INT_RANGE): New macros.
2801 (ccl_driver): Use them to check for integer overflow when
2802 decoding a CCL program. Many of the new checks are whether XINT (x)
2803 fits in int; it doesn't always, on 64-bit hosts. The new version
2804 doesn't catch all possible integer overflows, but it's an
2805 improvement. (Bug#8719)
2806
2807 * alloc.c (make_event_array): Use XINT, not XUINT.
2808 There's no need for unsigned here.
2809
2810 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2811 This follows up to the 2011-05-06 change that substituted uintptr_t
2812 for EMACS_INT. This case wasn't caught back then.
2813
2814 Rework Fformat to avoid integer overflow issues.
2815 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2816 now (part of C89). Include <verify.h>.
2817 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2818 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2819 (Fformat): Avoid the prepass trying to compute sizes; it was only
2820 approximate and thus did not catch overflow reliably. Instead, walk
2821 through the format just once, formatting and computing sizes as we go,
2822 checking for integer overflow at every step, and allocating a larger
2823 buffer as needed. Keep track separately whether the format is
2824 multibyte. Keep only the most-recently calculated precision, rather
2825 than them all. Record whether each argument has been converted to
2826 string. Use EMACS_INT, not int, for byte and char and arg counts.
2827 Support field widths and precisions larger than INT_MAX. Avoid
2828 sprintf's undefined behavior with conversion specifications such as %#d
2829 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2830 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2831 formatting out-of-range floating point numbers with int
2832 formats. (Bug#8668)
2833
2834 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2835
2836 * data.c: Avoid integer truncation in expressions involving floats.
2837 * data.c: Include <intprops.h>.
2838 (arith_driver): When there's an integer overflow in an expression
2839 involving floating point, convert the integers to floating point
2840 so that the resulting value does not suffer from catastrophic
2841 integer truncation. For example, on a 64-bit host (* 4
2842 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2843 Do not rely on undefined behavior after integer overflow.
2844
2845 merge count_size_as_multibyte, parse_str_to_multibyte
2846 * character.c, character.h (count_size_as_multibyte):
2847 Rename from parse_str_to_multibyte; all uses changed.
2848 Check for integer overflow.
2849 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2850 since it's now a duplicate of the other. This is more of
2851 a character than a buffer op, so better that it's in character.c.
2852 * fns.c, print.c: Adjust to above changes.
2853
2854 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2855
2856 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2857
2858 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2859
2860 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2861 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2862 (x_clipboard_manager_save): Now static.
2863 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2864
2865 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2866 (crypto_hash_function): Now static.
2867 Fix pointer signedness problems. Avoid unnecessary initializations.
2868
2869 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2870
2871 * termhooks.h (Vselection_alist): Make it terminal-local.
2872
2873 * terminal.c (create_terminal): Initialize it.
2874
2875 * xselect.c: Support for clipboard managers.
2876 (Vselection_alist): Move to termhooks.h as terminal-local var.
2877 (LOCAL_SELECTION): New macro.
2878 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2879 (symbol_to_x_atom): Remove gratuitous arg.
2880 (x_handle_selection_request, lisp_data_to_selection_data)
2881 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2882 (x_own_selection, x_get_local_selection, x_convert_selection):
2883 New arg, specifying work frame. Use terminal-local Vselection_alist.
2884 (some_frame_on_display): Delete unused function.
2885 (Fx_own_selection_internal, Fx_get_selection_internal)
2886 (Fx_disown_selection_internal, Fx_selection_owner_p)
2887 (Fx_selection_exists_p): New optional frame arg.
2888 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2889 (x_handle_selection_clear): Don't treat other terminals with the
2890 same keyboard specially. Use the terminal-local Vselection_alist.
2891 (x_clear_frame_selections): Use Frun_hook_with_args.
2892
2893 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2894
2895 * xterm.h: Add support for those atoms.
2896
2897 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2898
2899 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2900 (converted_selections, conversion_fail_tag): New global variables.
2901 (x_selection_request_lisp_error): Free the above.
2902 (x_get_local_selection): Remove unnecessary code.
2903 (x_reply_selection_request): Args changed; handle arbitrary array
2904 of converted selections stored in converted_selections.
2905 Separate the XChangeProperty and SelectionNotify steps.
2906 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2907 (x_convert_selection): New function.
2908 (x_handle_selection_event): Simplify.
2909 (x_get_foreign_selection): Don't ignore incoming requests while
2910 waiting for an answer; this will fail when we implement
2911 SAVE_TARGETS, and seems unnecessary anyway.
2912 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2913 (Vx_sent_selection_functions): Doc fix.
2914
2915 2011-05-26 Leo Liu <sdl.web@gmail.com>
2916
2917 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2918
2919 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2920
2921 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2922
2923 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2924 for fringe update if it has periodic bitmap.
2925 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2926 and fringe_bitmap_periodic_p.
2927
2928 * fringe.c (get_fringe_bitmap_data): New function.
2929 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2930 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2931 row. Mark glyph row for fringe update if periodicity changed.
2932
2933 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2934 for fringe update unless it has periodic bitmap.
2935
2936 2011-05-25 Kenichi Handa <handa@m17n.org>
2937
2938 * xdisp.c (get_next_display_element): Set correct it->face_id for
2939 a static composition.
2940
2941 2011-05-24 Leo Liu <sdl.web@gmail.com>
2942
2943 * deps.mk (fns.o):
2944 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2945
2946 * fns.c (crypto_hash_function, Fsha1): New function.
2947 (Fmd5): Use crypto_hash_function.
2948 (syms_of_fns): Add Ssha1.
2949
2950 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 * gnutls.c: Remove unused macros.
2953 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2954 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2955 Remove macros that are defined and never used.
2956 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2957
2958 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2959
2960 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2961 (Fx_get_selection_internal): Minor cleanup.
2962 (Fx_own_selection_internal): Rename arguments for consistency with
2963 select.el.
2964
2965 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2966
2967 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2968
2969 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2970
2971 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2972
2973 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2974
2975 * dispnew.c (scrolling_window): Don't exclude the case that the
2976 last enabled row in the desired matrix touches the bottom boundary.
2977
2978 2011-05-21 Glenn Morris <rgm@gnu.org>
2979
2980 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2981 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2982 and add some more files.
2983
2984 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2985
2986 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2987 report_file_error introduced by the change from 2011-05-07.
2988
2989 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 * systime.h (Time): Define only if emacs is defined.
2992 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2993 where the include path doesn't have X11/X.h by default. See
2994 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2995
2996 2011-05-20 Kenichi Handa <handa@m17n.org>
2997
2998 * composite.c (find_automatic_composition): Fix previous change.
2999
3000 2011-05-20 Glenn Morris <rgm@gnu.org>
3001
3002 * lisp.mk: New file, split from Makefile.in.
3003 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3004 (shortlisp): Remove.
3005 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3006
3007 2011-05-19 Glenn Morris <rgm@gnu.org>
3008
3009 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3010 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3011 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3012 (lisp): Set the order to that of loadup.el.
3013 (shortlisp): Make it a copy of $lisp.
3014 (SOME_MACHINE_LISP): Remove.
3015 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3016 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3017
3018 2011-05-18 Kenichi Handa <handa@m17n.org>
3019
3020 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3021 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3022 (find_automatic_composition): Mostly rewrite for efficiency.
3023
3024 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3025
3026 * makefile.w32-in: Update dependencies.
3027
3028 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3029
3030 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3031 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3032
3033 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3034
3035 Fix some integer overflow issues, such as string length overflow.
3036
3037 * insdel.c (count_size_as_multibyte): Check for string overflow.
3038
3039 * character.c (lisp_string_width): Check for string overflow.
3040 Use EMACS_INT, not int, for string indexes and lengths; in
3041 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3042 the resulting string length overflows an EMACS_INT; instead,
3043 report a string overflow if no precision given. When checking for
3044 precision exhaustion, use a check that cannot possibly have
3045 integer overflow. (Bug#8675)
3046 * character.h (lisp_string_width): Adjust to new signature.
3047
3048 * alloc.c (string_overflow): New function.
3049 (Fmake_string): Use it. This doesn't change behavior, but saves
3050 a few bytes and will simplify future changes.
3051 * character.c (string_escape_byte8): Likewise.
3052 * lisp.h (string_overflow): New decl.
3053
3054 Fixups, following up to the user-interface timestamp change.
3055 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3056 for UI timestamps, instead of unsigned long.
3057 * msdos.c (mouse_get_pos): Likewise.
3058 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3059 * w32gui.h (Time): Define by including "systime.h" rather than by
3060 declaring it ourselves. (Bug#8664)
3061
3062 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3063 * image.c (clear_image_cache): Likewise.
3064
3065 * term.c (term_mouse_position): Don't assume time_t wraparound.
3066
3067 Be more systematic about user-interface timestamps.
3068 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3069 and sometimes 'EMACS_UINT', to represent these timestamps.
3070 This change causes it to use 'Time' uniformly, as that's what X uses.
3071 This makes the code easier to follow, and makes it easier to catch
3072 integer overflow bugs such as Bug#8664.
3073 * frame.c (Fmouse_position, Fmouse_pixel_position):
3074 Use Time, not unsigned long, for user-interface timestamps.
3075 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3076 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3077 * keyboard.h (last_event_timestamp): Likewise.
3078 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3079 * menu.h (xmenu_show): Likewise.
3080 * term.c (term_mouse_position): Likewise.
3081 * termhooks.h (struct input_event.timestamp): Likewise.
3082 (struct terminal.mouse_position_hook): Likewise.
3083 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3084 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3085 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3086 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3087 what it was before.
3088 * menu.h, termhooks.h: Include "systime.h", for Time.
3089
3090 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3091 Don't assume that the difference between two unsigned long values
3092 can fit into an integer. At this point, we know button_down_time
3093 <= event->timestamp, so the difference must be nonnegative, so
3094 there's no need to cast the result if double-click-time is
3095 nonnegative, as it should be; check that it's nonnegative, just in
3096 case. This bug is triggered when events are more than 2**31 ms
3097 apart (about 25 days). (Bug#8664)
3098
3099 * xselect.c (last_event_timestamp): Remove duplicate decl.
3100 (x_own_selection): Remove needless cast to unsigned long.
3101
3102 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3103 that always fit in int. Use a sentinel instead of a counter, to
3104 avoid a temp and to allay GCC's concerns about possible int overflow.
3105 * frame.h (struct frame): Use int for menu_bar_items_used
3106 instead of EMACS_INT, since it always fits in int.
3107
3108 * menu.c (grow_menu_items): Check for int overflow.
3109
3110 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3111
3112 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3113 Before, the code was not consistent. These values cannot exceed
3114 2**31 - 1 so there's no need to make them unsigned.
3115 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3116 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3117 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3118 as modifiers.
3119 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3120
3121 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3122 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3123 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3124 presumably because the widths might not match.
3125
3126 * window.c (size_window): Avoid needless test at loop start.
3127
3128 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3129
3130 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3131
3132 2011-05-12 Drew Adams <drew.adams@oracle.com>
3133
3134 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3135
3136 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3137
3138 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3139 `width' to `bar_area_x' and `bar_area_width', respectively.
3140 (x_scroll_run): Take account of fringe background extension.
3141
3142 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3143 Rename local vars `left' and `width' to `bar_area_x' and
3144 `bar_area_width', respectively.
3145 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3146 background extension.
3147
3148 2011-05-10 Jim Meyering <meyering@redhat.com>
3149
3150 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3151
3152 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3153
3154 * image.c (Finit_image_library): Return t for built-in image types,
3155 like pbm and xbm. (Bug#8640)
3156
3157 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3158
3159 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3160
3161 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3162
3163 * w32console.c (Fset_screen_color): Doc fix.
3164 (Fget_screen_color): New function.
3165 (syms_of_ntterm): Defsubr it.
3166
3167 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3168 unlink the temporary file if Fcall_process didn't create it in the
3169 first place.
3170 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3171 child process will be redirected to a file specified with `:file'.
3172 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3173 cue to call_process_cleanup not to close that handle.
3174
3175 2011-05-07 Ben Key <bkey76@gmail.com>
3176
3177 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3178 one of two shell specific rules, either bootstrap-temacs-CMD or
3179 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3180 to the previous implementation of the bootstrap-temacs rule.
3181 The bootstrap-temacs-CMD rule is similar to the previous
3182 implementation of the bootstrap-temacs rule except that it
3183 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3184 variable.
3185
3186 These changes, along with some changes to nt/configure.bat,
3187 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3188 earlier fix to add support for --cflags and --ldflags options
3189 that include quotes so that it works whether make uses cmd or
3190 sh as the shell.
3191
3192 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3193
3194 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3195 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3196 is a constant.
3197 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3198 a string. Handle both cases.
3199 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3200 (Fdbus_register_method): Use Qinvalid_function.
3201
3202 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3203
3204 * makefile.w32-in: Update dependencies.
3205 (LISP_H): Add inttypes.h and stdin.h.
3206 (PROCESS_H): Add unistd.h.
3207
3208 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3209
3210 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3211 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3212
3213 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3214
3215 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3216
3217 * term.c (vfatal): Remove stray call to va_end.
3218 It's not needed and the C Standard doesn't allow it here anyway.
3219
3220 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3221 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3222
3223 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3224 bytes.
3225
3226 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3227
3228 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3229
3230 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3231
3232 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3233
3234 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3235
3236 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3237 * charset.c (Fdefine_charset_internal): Don't initialize
3238 charset.code_space[15]. The value was garbage, on hosts with
3239 32-bit int (Bug#8600).
3240
3241 * lread.c (read_integer): Be more consistent with string-to-number.
3242 Use string_to_number to do the actual conversion; this avoids
3243 rounding errors and fixes some other screwups. Without this fix,
3244 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3245 (digit_to_number): Move earlier, for benefit of read_integer.
3246 Return -1 if the digit is out of range for the base, -2 if it is
3247 not a digit in any supported base. (Bug#8602)
3248
3249 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3250
3251 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3252 to match comment at start of function. This also removes a
3253 GCC warning about overflow in a 32+64-bit port.
3254
3255 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3256
3257 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3258 Reported by Stefan Monnier in
3259 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3260 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3261 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3262
3263 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3264 (EMACS_UINTPTR): Likewise, with uintptr_t.
3265
3266 * lisp.h: Prefer 64-bit EMACS_INT if available.
3267 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3268 on 32-bit hosts that have 64-bit int, so that they can access
3269 large files.
3270 However, temporarily disable this change unless the temporary
3271 symbol WIDE_EMACS_INT is defined.
3272
3273 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3274
3275 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3276 This removes an assumption that EMACS_INT and long are the same
3277 width as pointers. The assumption is true for Emacs porting targets
3278 now, but we want to make other targets possible.
3279 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3280 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3281 In the rest of the code, change types of integers that hold casted
3282 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3283 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3284 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3285 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3286 No need to cast type when ORing.
3287 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3288 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3289 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3290 assume EMACS_INT is the same width as char *.
3291 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3292 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3293 Remove no-longer-needed casts.
3294 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3295 (xg_tool_bar_help_callback, xg_make_tool_item):
3296 Use EMACS_INTPTR to hold an integer
3297 that will be cast to void *; this can avoid a GCC warning
3298 if EMACS_INT is not the same width as void *.
3299 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3300 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3301 (current_message_1, set_message_1):
3302 Use a local to convert to proper width without a cast.
3303 * xmenu.c (dialog_selection_callback): Likewise.
3304
3305 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3306 Also, don't assume VALBITS / RAND_BITS is less than 5,
3307 and don't rely on undefined behavior when shifting a 1 left into
3308 the sign bit.
3309 * lisp.h (get_random): Change signature to match.
3310
3311 * lread.c (hash_string): Use size_t, not int, for hash computation.
3312 Normally we prefer signed values; but hashing is special, because
3313 it's better to use unsigned division on hash table sizes so that
3314 the remainder is nonnegative. Also, size_t is the natural width
3315 for hashing into memory. The previous code used 'int', which doesn't
3316 retain enough info to hash well into very large tables.
3317 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3318
3319 * dbusbind.c: Don't possibly lose pointer info when converting.
3320 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3321 Use XPNTR rather than XHASH, so that the high-order bits of
3322 the pointer aren't lost when converting through void *.
3323
3324 * eval.c (Fautoload): Don't double-shift a pointer.
3325
3326 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3327
3328 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3329
3330 * gnutls.c (DEF_GNUTLS_FN):
3331 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3332
3333 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3334
3335 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3336 marker. (Bug#8610)
3337
3338 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3339
3340 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3341 New version that can reserve upto 2GB of heap space.
3342
3343 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3344
3345 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3346
3347 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3348
3349 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3350 `gnutls_certificate_set_x509_key_file'.
3351
3352 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3353
3354 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3355 Update dependencies.
3356
3357 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3358
3359 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3360 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3361 Remove unused parameter `fildes'.
3362 * process.c (read_process_output, send_process): Don't pass it.
3363
3364 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3365
3366 Fix previous change: the library cache is defined in w32.c.
3367 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3368 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3369
3370 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3371
3372 Implement dynamic loading of GnuTLS on Windows.
3373
3374 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3375 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3376 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3377 Declare.
3378
3379 * gnutls.c (Qgnutls_dll): Define.
3380 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3381 (gnutls_*): Declare function pointers.
3382 (init_gnutls_functions): New function to initialize function pointers.
3383 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3384 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3385 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3386 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3387 (emacs_gnutls_write, emacs_gnutls_read)
3388 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3389 (Fgnutls_available_p): New function.
3390 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3391 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3392 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3393
3394 * image.c: Include w32.h.
3395 (Vimage_type_cache): Delete.
3396 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3397 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3398 (w32_delayed_load): Move to w32.c.
3399
3400 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3401
3402 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3403 (w32_delayed_load): Move from image.c. When loading a library, record
3404 its filename in the :loaded-from property of the library id.
3405 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3406 Initialize and staticpro them.
3407 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3408
3409 * process.c: Include lisp.h before w32.h, not after.
3410 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3411 instead of gnutls_record_check_pending.
3412
3413 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3414
3415 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3416
3417 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3418 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3419 as passed in.
3420
3421 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3422
3423 * xterm.c (x_set_frame_alpha): Do not set property on anything
3424 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3425
3426 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3427
3428 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3429
3430 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3431
3432 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3433 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3434 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3435 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3436 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3437 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3438 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3439 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3440 (Qgnutls_bootprop_callbacks_verify): Make static.
3441
3442 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3443
3444 * callproc.c: Indentation fixup.
3445
3446 * sysdep.c (wait_for_termination_1): Make static.
3447 (wait_for_termination, interruptible_wait_for_termination):
3448 Move after wait_for_termination_1.
3449
3450 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3451
3452 * sysdep.c (interruptible_wait_for_termination): New function
3453 which is like wait_for_termination, but allows keyboard
3454 interruptions.
3455
3456 * callproc.c (Fcall_process): Add (:file "file") as an option for
3457 the STDOUT buffer.
3458 (Fcall_process_region): Ditto.
3459
3460 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3461
3462 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3463 rather than `XVECTOR (FOO)->size'.
3464
3465 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3466 inttypes.h, as a gnulib replacement is used if it not available in
3467 system headers.
3468
3469 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3470
3471 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3472 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3473 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3474
3475 * coding.c (coding_alloc_by_realloc): Error out if destination
3476 will grow beyond MOST_POSITIVE_FIXNUM.
3477 (decode_coding_emacs_mule): Abort if there isn't enough place in
3478 charbuf for the composition carryover bytes. Reserve an extra
3479 space for up to 2 characters produced in a loop.
3480 (decode_coding_iso_2022): Abort if there isn't enough place in
3481 charbuf for the composition carryover bytes.
3482
3483 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3484
3485 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3486 aborting when %lld or %lll format is passed.
3487 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3488 %llo or %llx format is passed. (Bug#8545)
3489
3490 * window.c (window_scroll_line_based): Use a marker instead of
3491 simple variables to record original value of point. (Bug#7952)
3492
3493 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3494 produced by %s or %c overflows available buffer space. (Bug#8545)
3495
3496 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3497
3498 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3499 (SIZE_MAX): Move defn after all includes, as they might #define it.
3500
3501 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3502
3503 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3504
3505 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3506
3507 * keyboard.c (Qdelayed_warnings_hook): Define.
3508 (command_loop_1): Run `delayed-warnings-hook'
3509 if Vdelayed_warnings_list is non-nil.
3510 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3511 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3512
3513 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3514
3515 * doprnt.c (doprnt): Don't return value smaller than the buffer
3516 size if the message was truncated. (Bug#8545).
3517
3518 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3519
3520 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3521 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3522
3523 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3524
3525 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3526
3527 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * makefile.w32-in: Update dependencies.
3530
3531 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3532
3533 Improve `doprnt' and its usage. (Bug#8545)
3534 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3535 `format_end'. Remove support for %l as a conversion specifier.
3536 Don't use xrealloc. Improve diagnostics when the %l size modifier
3537 is used. Update the commentary.
3538
3539 * eval.c (verror): Simplify calculation of size_t.
3540
3541 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3542 messages.
3543
3544 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3545
3546 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3547 change.
3548
3549 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3550
3551 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3552 This makes this file independent of the recent pseudovector change.
3553
3554 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3555
3556 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3557
3558 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3559 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3560 Remove unused local.
3561 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3562
3563 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3564 GCC 4.6.0 optimizes based on type-based alias analysis.
3565 For example, if b is of type struct buffer * and v of type struct
3566 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3567 != &v->size, and therefore "v->size = 1; b->size = 2; return
3568 v->size;" must therefore return 1. This assumption is incorrect
3569 for Emacs, since it type-puns struct Lisp_Vector * with many other
3570 types. To fix this problem, this patch adds a new type struct
3571 vectorlike_header that documents the constraints on layout of vectors
3572 and pseudovectors, and helps optimizing compilers not get fooled
3573 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3574 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3575 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3576 the size member.
3577 (XSETPVECTYPE): Rewrite in terms of new macro.
3578 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3579 This is a bit clearer, and further avoids the possibility of
3580 undesirable aliasing.
3581 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3582 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3583 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3584 since Lisp_Subr is a special case (no "next" field).
3585 (ASIZE): Now uses header.size rather than size.
3586 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3587 to avoid the hassle of writing XVECTOR (foo)->header.size.
3588 (struct vectorlike_header): New type.
3589 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3590 object, to help avoid aliasing.
3591 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3592 (SUBRP): Likewise, since Lisp_Subr is a special case.
3593 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3594 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3595 (struct Lisp_Hash_Table): Combine first two members into a single
3596 struct vectorlike_header member. All uses of "size" and "next" members
3597 changed to be "header.size" and "header.next".
3598 * buffer.h (struct buffer): Likewise.
3599 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3600 * frame.h (struct frame): Likewise.
3601 * process.h (struct Lisp_Process): Likewise.
3602 * termhooks.h (struct terminal): Likewise.
3603 * window.c (struct save_window_data, struct saved_window): Likewise.
3604 * window.h (struct window): Likewise.
3605 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3606 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3607 * buffer.c (init_buffer_once): Likewise.
3608 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3609 special case.
3610 * process.c (Fformat_network_address): Use local var for size,
3611 for brevity.
3612
3613 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3614
3615 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3616 * data.c (atof): Remove decl; no longer used or needed.
3617 (digit_to_number): Move to lread.c.
3618 (Fstring_to_number): Use new string_to_number function, to be
3619 consistent with how the Lisp reader treats infinities and NaNs.
3620 Do not assume that floating-point numbers represent EMACS_INT
3621 without losing information; this is not true on most 64-bit hosts.
3622 Avoid double-rounding errors, by insisting on integers when
3623 parsing non-base-10 numbers, as the documentation specifies.
3624 * lisp.h (string_to_number): New decl, replacing ...
3625 (isfloat_string): Remove.
3626 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3627 (read1): Do not accept +. and -. as integers; this
3628 appears to have been a coding error. Similarly, do not accept
3629 strings like +-1e0 as floating point numbers. Do not report
3630 overflow for integer overflows unless the base is not 10 which
3631 means we have no simple and reliable way to continue.
3632 Break out the floating-point parsing into a new
3633 function string_to_number, so that Fstring_to_number parses
3634 floating point numbers consistently with the Lisp reader.
3635 (digit_to_number): Move here from data.c. Make it static inline.
3636 (E_CHAR, EXP_INT): Remove, replacing with ...
3637 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3638 (string_to_number): New function, replacing isfloat_string.
3639 This function checks for valid syntax and produces the resulting
3640 Lisp float number too. Rework it so that string-to-number
3641 no longer mishandles examples like "1.0e+". Use strtoumax,
3642 so that overflow for non-base-10 numbers is reported only when
3643 there's no portable and simple way to convert to floating point.
3644
3645 * textprop.c (set_text_properties_1): Rewrite for clarity,
3646 and to avoid GCC warning about integer overflow.
3647
3648 * intervals.h (struct interval): Use EMACS_INT for members
3649 where EMACS_UINT might cause problems. See
3650 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3651 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3652 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3653 All uses changed.
3654 (offset_intervals): Tell GCC not to worry about length overflow
3655 when negating a negative length.
3656
3657 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3658 (overrun_check_free): Likewise.
3659
3660 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3661 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3662 word size.
3663
3664 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3665 (gnutls_make_error): Rename local to avoid shadowing.
3666 (gnutls_emacs_global_deinit): ifdef out; not used.
3667 (Fgnutls_boot): Use const for pointer to readonly storage.
3668 Comment out unused local. Fix pointer signedness problems.
3669
3670 * lread.c (openp): Don't stuff size_t into an 'int'.
3671 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3672 about possible signed overflow.
3673
3674 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3675 (GDK_KEY_g): Don't define if already defined.
3676 (xg_prepare_tooltip): Avoid pointer signedness problem.
3677 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3678
3679 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3680 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3681
3682 * xfns.c (Fx_window_property): Simplify a bit,
3683 to make a bit faster and to avoid GCC 4.6.0 warning.
3684 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3685
3686 * fns.c (internal_equal): Don't assume size_t fits in int.
3687
3688 * alloc.c (compact_small_strings): Tighten assertion a little.
3689
3690 Replace pEd with more-general pI, and fix some printf arg casts.
3691 * lisp.h (pI): New macro, generalizing old pEd macro to other
3692 conversion specifiers. For example, use "...%"pI"d..." rather
3693 than "...%"pEd"...".
3694 (pEd): Remove. All uses replaced with similar uses of pI.
3695 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3696 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3697 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3698 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3699 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3700 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3701 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3702 64-bit hosts.
3703 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3704 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3705 * print.c (safe_debug_print, print_object): Likewise.
3706 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3707 to int.
3708 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3709 avoiding the 0 flag, which is not portable.
3710 * process.c (Fmake_network_process): Use pI to avoid cast.
3711 * region-cache.c (pp_cache): Likewise.
3712 * xdisp.c (decode_mode_spec): Likewise.
3713 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3714 behavior on 64-bit hosts with printf arg.
3715 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3716 (x_stop_queuing_selection_requests): Likewise.
3717 (x_get_window_property): Don't truncate byte count to an 'int'
3718 when tracing.
3719
3720 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3721 here, since it parses constructs like leading '-' and spaces,
3722 which are not wanted; and it overflows with large numbers.
3723 Instead, simply match F[0-9]+, which is what is wanted anyway.
3724
3725 * alloc.c: Remove unportable assumptions about struct layout.
3726 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3727 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3728 (allocate_vectorlike, make_pure_vector): Use the new macros,
3729 plus offsetof, to remove unportable assumptions about struct layout.
3730 These assumptions hold on all porting targets that I know of, but
3731 they are not guaranteed, they're easy to remove, and removing them
3732 makes further changes easier.
3733
3734 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3735 This doesn't fix a bug but makes the code clearer.
3736 (string_overrun_cookie): Now const. Use initializers that
3737 don't formally overflow signed char, to avoid warnings.
3738 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3739 can cause Emacs to crash when string overrun checking is enabled.
3740 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3741 multiple of sizeof (EMACS_INT); it need not be, if
3742 alignof(EMACS_INT) < sizeof (EMACS_INT).
3743 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3744
3745 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3746
3747 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3748
3749 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3750
3751 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3752 supposed to be handshaking. (Bug#8556)
3753 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3754
3755 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3756
3757 * lisp.h (Qdebug): List symbol.
3758 * eval.c (Qdebug): Restore global linkage.
3759 * keyboard.c (debug-on-event): New variable.
3760 (handle_user_signal): Break into debugger when debug-on-event
3761 matches the current signal symbol.
3762
3763 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3764
3765 * alloc.c (check_sblock, check_string_bytes)
3766 (check_string_free_list): Convert to standard C.
3767
3768 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3769
3770 * w32.c (emacs_gnutls_push): Fix typo.
3771
3772 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3773
3774 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3775 "cast to pointer from integer of different size".
3776
3777 Improve doprnt and its use in verror. (Bug#8545)
3778 * doprnt.c (doprnt): Document the set of format control sequences
3779 supported by the function. Use SAFE_ALLOCA instead of always
3780 using `alloca'.
3781
3782 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3783 is one byte too soon. Don't use xrealloc; instead xfree and
3784 xmalloc anew.
3785
3786 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3787
3788 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3789 callbacks stage.
3790
3791 * gnutls.c: Renamed global_initialized to
3792 gnutls_global_initialized. Added internals for the
3793 :verify-hostname-error, :verify-error, and :verify-flags
3794 parameters of `gnutls-boot' and documented those parameters in the
3795 docstring. Start callback support.
3796 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3797 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3798 on error. Return error code.
3799 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3800 (emacs_gnutls_read): Likewise.
3801 (Fgnutls_boot): Return handshake error code.
3802 (emacs_gnutls_handle_error): New function.
3803 (wsaerror_to_errno): Likewise.
3804
3805 * w32.h (emacs_gnutls_pull): Add prototype.
3806 (emacs_gnutls_push): Likewise.
3807
3808 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3809 (emacs_gnutls_push): Likewise.
3810
3811 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3812
3813 * process.c (wait_reading_process_output): Check if GnuTLS
3814 buffered some data internally if no FDs are set for TLS
3815 connections.
3816
3817 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3818 (LIBS): Link to USER_LIBS.
3819 ($(BLD)/gnutls.$(0)): New target.
3820
3821 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3822
3823 * xdisp.c (handle_single_display_spec): Rename the
3824 display_replaced_before_p argument into display_replaced_p, to
3825 make it consistent with the commentary. Fix typos in the
3826 commentary.
3827
3828 * textprop.c (syms_of_textprop): Remove dead code.
3829 (copy_text_properties): Delete obsolete commentary about an
3830 interface that was deleted long ago. Fix typos in the description
3831 of arguments.
3832
3833 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3834 to changes in oldXMenu/XMenu.h from 2011-04-16.
3835 <menu_help_message, prev_menu_help_message>: Constify.
3836 (IT_menu_make_room): menu->help_text is now `const char **';
3837 adjust.
3838
3839 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3840 to changes in oldXMenu/XMenu.h from 2011-04-16.
3841 (struct XMenu): Declare `help_text' `const char **'.
3842
3843 * xfaces.c <Qunspecified>: Make extern again.
3844
3845 * syntax.c: Include sys/types.h before including regex.h, as
3846 required by Posix.
3847
3848 * doc.c (get_doc_string): Improve the format passed to `error'.
3849
3850 * doprnt.c (doprnt): Improve commentary.
3851
3852 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3853
3854 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3855 them with etags.
3856
3857 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3858 changes in globals.h immediately force recompilation.
3859 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3860 $(CURDIR)/s/ms-w32.h.
3861 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3862
3863 * character.c (Fchar_direction): Function deleted.
3864 (syms_of_character): Don't defsubr it.
3865 <char-direction-table>: Deleted.
3866
3867 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3868
3869 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3870 * doprnt.c: Include limits.h.
3871 (SIZE_MAX): New macro.
3872 (doprnt): Return a size_t value. 2nd arg is now size_t.
3873 Many local variables are now size_t instead of int or unsigned.
3874 Improve overflow protection. Support `l' modifier for integer
3875 conversions. Support %l conversion. Don't assume an EMACS_INT
3876 argument for integer conversions and for %c.
3877
3878 * lisp.h (doprnt): Restore prototype.
3879
3880 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3881 $(SRC)/character.h.
3882
3883 * Makefile.in (base_obj): Add back doprnt.o.
3884
3885 * deps.mk (doprnt.o): Add back prerequisites.
3886 (callint.o): Depend on character.h.
3887
3888 * eval.c (internal_lisp_condition_case): Include the handler
3889 representation in the error message.
3890 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3891 when breaking from the loop.
3892
3893 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3894
3895 * callint.c (Fcall_interactively): When displaying error message
3896 about invalid control letter, pass the character's codepoint, not
3897 a pointer to its multibyte form. Improve display of the character
3898 in octal and display also its hex code.
3899
3900 * character.c (char_string): Use %x to display the (unsigned)
3901 codepoint of an invalid character, to avoid displaying a bogus
3902 negative value.
3903
3904 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3905 `error', not SYMBOL_NAME itself.
3906
3907 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3908 character arguments to `error'.
3909
3910 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3911 to `error' in error message about FINAL_CHAR argument. Make sure
3912 FINAL_CHAR is a character, and use %c when it is passed as
3913 argument to `error'.
3914
3915 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3916
3917 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3918
3919 * w32.c: Include <time.h>.
3920 (sys_localtime): New function.
3921
3922 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3923
3924 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3925
3926 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3927
3928 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3929
3930 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3931 zombies (Bug#8467).
3932
3933 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3934
3935 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3936 gl_state.e_property when gl_state.object is Qt.
3937
3938 * insdel.c (make_gap_larger): Remove limitation of buffer size
3939 to <= INT_MAX.
3940
3941 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3942
3943 * xdisp.c (lookup_glyphless_char_display)
3944 (produce_glyphless_glyph): Handle cons cell entry in
3945 glyphless-char-display.
3946 (Vglyphless_char_display): Document it.
3947
3948 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3949 glyphless-char-display.
3950
3951 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3952
3953 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3954
3955 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3956
3957 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3958 definition for no-X builds.
3959
3960 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3961
3962 Static checks with GCC 4.6.0 and non-default toolkits.
3963
3964 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3965
3966 * process.c (keyboard_bit_set): Define only if SIGIO.
3967 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3968 (send_process): Repair possible setjmp clobbering.
3969
3970 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3971
3972 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3973
3974 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3975
3976 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3977 Define only if needed.
3978
3979 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3980 by pacifying GCC about it. Maybe it's time to retire it?
3981 * xfaces.c (USG, __TIMEVAL__): Likewise.
3982
3983 * dispextern.h (struct redisplay_interface): Rename param
3984 to avoid shadowing.
3985 * termhooks.h (struct terminal): Likewise.
3986 * xterm.c (xembed_send_message): Likewise.
3987
3988 * insdel.c (make_gap_smaller): Define only if
3989 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3990
3991 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3992 it.
3993
3994 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3995 so that we aren't warned about unused symbols.
3996
3997 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3998
3999 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4000
4001 * xfns.c (x_real_positions): Mark locals as initialized.
4002
4003 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4004
4005 * xterm.c: Fix problems found by static analysis with other toolkits.
4006 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4007 (x_dispatch_event): Declare static if USE_GTK, and
4008 define if USE_GTK || USE_X_TOOLKIT.
4009 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4010 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4011 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4012 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4013
4014 * xmenu.c (menu_help_callback): Pointer type fixes.
4015 Use const pointers when pointing at readonly data. Avoid pointer
4016 signedness clashes.
4017 (FALSE): Remove unused macro.
4018 (update_frame_menubar): Remove unused decl.
4019
4020 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4021
4022 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4023 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4024 (single_menu_item): Rename local to avoid shadowing.
4025
4026 * keyboard.c (make_lispy_event): Remove unused local var.
4027
4028 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4029 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4030
4031 * bitmaps: Change bitmaps from unsigned char back to the X11
4032 compatible char. Avoid the old compiler warnings about
4033 out-of-range initializers by using, for example, '\xab' rather
4034 than 0xab.
4035
4036 * xgselect.c (xgselect_initialize): Check vs interface
4037 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4038
4039 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4040
4041 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4042 to read-only memory.
4043
4044 * fns.c (vector): Remove; this old hack is no longer needed.
4045
4046 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4047 Remove unused var.
4048 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4049
4050 * xrdb.c (x_load_resources): Omit unused local.
4051
4052 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4053 (x_window): Rename locals to avoid shadowing.
4054 (USG): Use the kludged USG macro, to pacify gcc.
4055
4056 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4057 (x_term_init): Remove local to avoid shadowing.
4058
4059 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4060
4061 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4062 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4063
4064 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4065
4066 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4067
4068 Fix regex.c, syntax.c and friends for buffers > 2GB.
4069 * syntax.h (struct gl_state_s): Declare character position members
4070 EMACS_INT.
4071
4072 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4073
4074 * textprop.c (verify_interval_modification, interval_of):
4075 Declare arguments EMACS_INT.
4076
4077 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4078 EMACS_INT.
4079
4080 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4081
4082 * indent.c (Fvertical_motion): Local variable it_start is now
4083 EMACS_INT.
4084
4085 * regex.c (re_match, re_match_2, re_match_2_internal)
4086 (bcmp_translate, regcomp, regexec, print_double_string)
4087 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4088 (re_compile_pattern, re_exec): Declare arguments and local
4089 variables `size_t' and `ssize_t' and return values `regoff_t', as
4090 appropriate.
4091 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4092 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4093 <compile_stack_type>: `size' and `avail' are now `size_t'.
4094
4095 * regex.h <regoff_t>: Use ssize_t, not int.
4096 (re_search, re_search_2, re_match, re_match_2): Arguments that
4097 specify buffer/string position and length are now ssize_t and
4098 size_t. Return type is regoff_t.
4099
4100 2011-04-16 Ben Key <bkey76@gmail.com>
4101
4102 * nsfont.m: Fixed bugs in ns_get_family and
4103 ns_descriptor_to_entity that were caused by using free to
4104 deallocate memory blocks that were allocated by xmalloc (via
4105 xstrdup). This caused Emacs to crash when compiled with
4106 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4107 --enable-checking=xmallocoverrun). xfree is now used to
4108 deallocate these memory blocks.
4109
4110 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4111
4112 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4113
4114 emacs_write: Accept and return EMACS_INT for sizes.
4115 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4116 et seq.
4117 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4118 Accept and return EMACS_INT.
4119 (emacs_gnutls_write): Return the number of bytes written on
4120 partial writes.
4121 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4122 (emacs_read, emacs_write): Remove check for negative size, as the
4123 Emacs source code has been audited now.
4124 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4125 (emacs_read, emacs_write): Use it.
4126 * process.c (send_process): Adjust to the new signatures of
4127 emacs_write and emacs_gnutls_write. Do not attempt to store
4128 a byte offset into an 'int'; it might overflow.
4129 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4130
4131 * sound.c: Don't assume sizes fit in 'int'.
4132 (struct sound_device.period_size, alsa_period_size):
4133 Return EMACS_INT, not int.
4134 (struct sound_device.write, vox_write, alsa_write):
4135 Accept EMACS_INT, not int.
4136 (wav_play, au_play): Use EMACS_INT to store sizes and to
4137 record read return values.
4138
4139 2011-04-15 Ben Key <bkey76@gmail.com>
4140
4141 * keyboard.c (Qundefined): Don't declare static since it is used
4142 in nsfns.m.
4143 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4144 static since they are used in nsfont.m.
4145
4146 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4147
4148 * process.c (Qprocessp): Don't declare static.
4149 * lisp.h (Qprocessp): Declare again.
4150
4151 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4152
4153 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4154
4155 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4156
4157 Improve C-level modularity by making more things 'static'.
4158
4159 Don't publish debugger-only interfaces to other modules.
4160 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4161 (verify_bytepos, count_markers): Move decls to the only modules
4162 that need them.
4163 * region-cache.h (pp_cache): Likewise.
4164 * window.h (check_all_windows): Likewise.
4165 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4166
4167 * sysdep.c (croak): Now static, if
4168 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4169 * syssignal.h (croak): Declare only if not static.
4170
4171 * alloc.c (refill_memory_reserve): Now static if
4172 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4173 * lisp.h (refill_memory_reserve): Declare only if not static.
4174
4175 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4176 Define only if USE_LUCID.
4177
4178 * xrdb.c (x_customization_string, x_rm_string): Now static.
4179
4180 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4181 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4182
4183 * xdisp.c (draw_row_with_mouse_face): Now static.
4184 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4185
4186 * window.h (check_all_windows): Mark externally visible.
4187
4188 * window.c (window_deletion_count): Now static.
4189
4190 * undo.c: Make symbols static if they're not exported.
4191 (last_undo_buffer, last_boundary_position, pending_boundary):
4192 Now static.
4193
4194 * textprop.c (interval_insert_behind_hooks): Now static.
4195 (interval_insert_in_front_hooks): Likewise.
4196
4197 * term.c: Make symbols static if they're not exported.
4198 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4199 (max_frame_lines, tty_set_terminal_modes):
4200 (tty_reset_terminal_modes, tty_turn_off_highlight):
4201 (get_tty_terminal): Now static.
4202 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4203 * termhooks.h (term_mouse_moveto): Do not declare if
4204 HAVE_WINDOW_SYSTEM.
4205 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4206 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4207
4208 * sysdep.c: Make symbols static if they're not exported.
4209 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4210 Now static.
4211 (sigprocmask_set, full_mask): Remove; unused.
4212 (wait_debugging): Mark as visible.
4213 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4214 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4215
4216 * syntax.c (syntax_temp): Define only if !__GNUC__.
4217
4218 * sound.c (current_sound_device, current_sound): Now static.
4219
4220 * search.c (searchbufs, searchbuf_head): Now static.
4221
4222 * scroll.c (scroll_cost): Remove; unused.
4223 * dispextern.h (scroll_cost): Remove decl.
4224
4225 * region-cache.h (pp_cache): Mark as externally visible.
4226
4227 * process.c: Make symbols static if they're not exported.
4228 (process_tick, update_tick, create_process, chan_process):
4229 (Vprocess_alist, proc_buffered_char, datagram_access):
4230 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4231 (deactivate_process): Mark defn as static, as well as decl.
4232 * lisp.h (create_process): Remove decl.
4233 * process.h (chan_process, Vprocess_alist): Remove decls.
4234
4235 * print.c: Make symbols static if they're not exported.
4236 (print_depth, new_backquote_output, being_printed, print_buffer):
4237 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4238 (print_interval, print_number_index, initial_stderr_stream):
4239 Now static.
4240 * lisp.h (Fprinc): Remove decl.
4241 (debug_output_compilation_hack): Mark as externally visible.
4242
4243 * sysdep.c (croak): Move decl from here to syssignal.h.
4244 * syssignal.h (croak): Put it here, so the API can be checked when
4245 'croak' is called from dissociate_if_controlling_tty.
4246
4247 * minibuf.c: Make symbols static if they're not exported.
4248 (minibuf_save_list, choose_minibuf_frame): Now static.
4249 * lisp.h (choose_minibuf_frame): Remove decl.
4250
4251 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4252
4253 * lread.c: Make symbols static if they're not exported.
4254 (read_objects, initial_obarray, oblookup_last_bucket_number):
4255 Now static.
4256 (make_symbol): Remove; unused.
4257 * lisp.h (initial_obarray, make_symbol): Remove decls.
4258
4259 * keyboard.c: Make symbols static if they're not exported.
4260 (single_kboard, recent_keys_index, total_keys, recent_keys):
4261 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4262 (this_single_command_key_start, echoing, last_auto_save):
4263 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4264 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4265 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4266 (Vlispy_mouse_stem, double_click_count):
4267 Now static.
4268 (force_auto_save_soon): Define only if SIGDANGER.
4269 (ignore_mouse_drag_p): Now static if
4270 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4271 (print_help): Remove; unused.
4272 (stop_character, last_timer_event): Mark as externally visible.
4273 * keyboard.h (ignore_mouse_drag_p): Declare only if
4274 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4275 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4276 * lisp.h (echoing): Remove decl.
4277 (force_auto_save_soon): Declare only if SIGDANGER.
4278 * xdisp.c (redisplay_window): Simplify code, to make it more
4279 obvious that ignore_mouse_drag_p is not accessed if !defined
4280 USE_GTK && !defined HAVE_NS.
4281
4282 * intervals.c: Make symbols static if they're not exported.
4283 (merge_properties_sticky, merge_interval_right, delete_interval):
4284 Now static.
4285 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4286
4287 * insdel.c: Make symbols static if they're not exported.
4288 However, leave prepare_to_modify_buffer alone. It's never
4289 called from outside this function, but that appears to be a bug.
4290 (combine_after_change_list, combine_after_change_buffer):
4291 (adjust_after_replace, signal_before_change): Now static.
4292 (adjust_after_replace_noundo): Remove; unused.
4293 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4294 (signal_before_change): Remove decls.
4295
4296 * indent.c (val_compute_motion, val_vmotion): Now static.
4297
4298 * image.c: Make symbols static if they're not exported.
4299 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4300 if USE_GTK.
4301 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4302 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4303
4304 * fringe.c (standard_bitmaps): Now static.
4305 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4306
4307 * frame.c: Make symbols static if they're not exported.
4308 (x_report_frame_params, make_terminal_frame): Now static.
4309 (get_frame_param): Now static, unless HAVE_NS.
4310 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4311 (x_get_resource_string): Remove; not used.
4312 * frame.h (make_terminal_frame, x_report_frame_params):
4313 (x_get_resource_string); Remove decls.
4314 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4315 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4316
4317 * font.c, fontset.c: Make symbols static if they're not exported.
4318 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4319 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4320 * font.c (font_close_object): Now static.
4321 * font.h (font_close_object): Remove.
4322 * fontset.c (FONTSET_OBJLIST): Remove.
4323 (free_realized_fontset) #if-0 the body, which does nothing.
4324 (face_suitable_for_char_p): #if-0, as it's never called.
4325 * fontset.h (face_suitable_for_char_p): Remove decl.
4326 * xfaces.c (face_at_string_position):
4327 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4328 since 0 is always ASCII.
4329
4330 * fns.c (weak_hash_tables): Now static.
4331
4332 * fileio.c: Make symbols static if they're not exported.
4333 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4334 (Vwrite_region_annotation_buffers): Now static.
4335
4336 * eval.c: Make symbols static if they're not exported.
4337 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4338 * lisp.h (backtrace_list): Remove decl.
4339
4340 * emacs.c: Make symbols static if they're not exported.
4341 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4342 (fatal_error_code, fatal_error_signal_hook, standard_args):
4343 Now static.
4344 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4345 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4346 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4347 * lisp.h (fatal_error_signal_hook): Remove decl.
4348 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4349
4350 * editfns.c: Move a (normally-unused) function to its only use.
4351 * editfns.c, lisp.h (get_operating_system_release): Remove.
4352 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4353 worth the hassle of breaking this out.
4354
4355 * xterm.c: Make symbols static if they're not exported.
4356 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4357 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4358 (x_destroy_window, x_delete_display):
4359 Now static.
4360 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4361 (x_mouse_leave): Remove; unused.
4362 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4363 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4364 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4365 Remove decls.
4366 (x_mouse_leave): Declare only if WINDOWSNT.
4367 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4368 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4369 USE_X_TOOLKIT.
4370
4371 * ftxfont.c: Make symbols static if they're not exported.
4372 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4373 HAVE_FREETYPE.
4374 * font.h (ftxfont_driver): Likewise.
4375
4376 * xfns.c: Make symbols static if they're not exported.
4377 (x_last_font_name, x_display_info_for_name):
4378 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4379 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4380 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4381 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4382 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4383 (last_show_tip_args): Now static.
4384 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4385 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4386 (x_screen_planes): Remove; unused.
4387 * dispextern.h (x_screen_planes): Remove decl.
4388
4389 * dispnew.c: Make symbols static if they're not exported.
4390 * dispextern.h (redraw_garbaged_frames, scrolling):
4391 (increment_row_positions): Remove.
4392 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4393 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4394 Now static.
4395 (redraw_garbaged_frames): Remove; unused.
4396
4397 * xfaces.c: Make symbols static if they're not exported.
4398 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4399 Remove decls.
4400 * xterm.h (defined_color): Remove decls.
4401 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4402 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4403 (menu_face_changed_default, defined_color, free_realized_face):
4404 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4405 (ascii_face_of_lisp_face): Remove; unused.
4406
4407 * xdisp.c: Make symbols static if they're not exported.
4408 * dispextern.h (scratch_glyph_row, window_box_edges):
4409 (glyph_to_pixel_coords, set_cursor_from_row):
4410 (get_next_display_element, set_iterator_to_next):
4411 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4412 (show_mouse_face): Remove decls
4413 * frame.h (message_buf_print): Likewise.
4414 * lisp.h (pop_message, set_message, check_point_in_composition):
4415 Likewise.
4416 * xterm.h (set_vertical_scroll_bar): Likewise.
4417 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4418 (message_buf_print, scratch_glyph_row, displayed_buffer):
4419 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4420 (get_next_display_element, show_mouse_face, window_box_edges):
4421 (frame_to_window_pixel_xy, check_point_in_composition):
4422 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4423 (glyph_to_pixel_coords): Remove; unused.
4424
4425 * dired.c (file_name_completion): Now static.
4426
4427 * dbusbind.c (xd_in_read_queued_messages): Now static.
4428
4429 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4430 * data.c (circular_list_error): Remove.
4431
4432 * commands.h (last_point_position, last_point_position_buffer):
4433 (last_point_position_window): Remove decls.
4434 * keyboard.c: Make these variables static.
4435
4436 * coding.h (coding, code_convert_region, encode_coding_gap):
4437 Remove decls.
4438 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4439 (iso_code_class, detect_coding, code_convert_region): Now static.
4440 (encode_coding_gap): Remove; unused.
4441
4442 * chartab.c (chartab_chars, chartab_bits): Now static.
4443
4444 * charset.h (charset_iso_8859_1): Remove decl.
4445 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4446 Now static.
4447
4448 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4449 * ccl.c (Vccl_program_table): Now static.
4450 (check_ccl_update): Remove; unused.
4451
4452 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4453 * category.h: ... from here.
4454 * category.c (check_category_table, set_category_set): Now static.
4455
4456 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4457 * lisp.h: Remove these decls.
4458
4459 * buffer.c (buffer_count): Remove unused var.
4460
4461 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4462 so that it's not optimized away.
4463 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4464 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4465 exported only to the debugger.
4466
4467 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4468 * atimer.h (run_all_atimers): Remove; not exported.
4469
4470 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4471 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4472 was inaccessible from Lisp.
4473 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4474 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4475
4476 alloc.c: Import and export fewer symbols, and remove unused items.
4477 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4478 is defined.
4479 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4480 it's not optimized away by whole-program optimization.
4481 (message_enable_multibyte, free_misc): Remove.
4482 (catchlist, handlerlist, mark_backtrace):
4483 Declare only if BYTE_MARK_STACK.
4484 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4485 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4486 (message_enable_multibyte): Remove decl.
4487 (free_misc, interval_free_list, float_block, float_block_index):
4488 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4489 (cons_free_list, last_marked_index):
4490 Now static.
4491 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4492 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4493 (mark_backtrace): Define only if BYTE_MARK_STACK.
4494 * xdisp.c (message_enable_multibyte): Now static.
4495
4496 Declare Lisp_Object Q* variables to be 'static' if not exported.
4497 This makes it easier for human readers (and static analyzers)
4498 to see whether these variables are used from other modules.
4499 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4500 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4501 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4502 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4503 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4504 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4505 * xmenu.c, xselect.c:
4506 Declare Q* vars static if they are not used in other modules.
4507 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4508 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4509 Remove decls of unexported vars.
4510 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4511
4512 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4513
4514 Make Emacs functions such as Fatom 'static' by default.
4515 This makes it easier for human readers (and static analyzers)
4516 to see whether these functions can be called from other modules.
4517 DEFUN now defines a static function. To make the function external
4518 so that it can be used in other C modules, use the new macro DEFUE.
4519 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4520 (Finit_image_library):
4521 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4522 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4523 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4524 Remove decls, since these functions are now static.
4525 (Funintern, Fget_internal_run_time): New decls, since these functions
4526 were already external.
4527
4528 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4529 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4530 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4531 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4532 * keyboard.c, keymap.c, lread.c:
4533 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4534 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4535 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4536 Mark functions with DEFUE instead of DEFUN,
4537 if they are used in other modules.
4538 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4539 decls for now-static functions.
4540 * buffer.h (Fdelete_overlay): Remove decl.
4541 * callproc.c (Fgetenv_internal): Mark as internal.
4542 * composite.c (Fremove_list_of_text_properties): Remove decl.
4543 (Fcomposition_get_gstring): New forward static decl.
4544 * composite.h (Fcomposite_get_gstring): Remove decl.
4545 * dired.c (Ffile_attributes): New forward static decl.
4546 * doc.c (Fdocumntation_property): New forward static decl.
4547 * eval.c (Ffetch_bytecode): New forward static decl.
4548 (Funintern): Remove extern decl; now in .h file where it belongs.
4549 * fileio.c (Fmake_symbolic_link): New forward static decl.
4550 * image.c (Finit_image_library): New forward static decl.
4551 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4552 * intervals.h (Fprevious_property_change):
4553 (Fremove_list_of_text_properties): Remove decls.
4554 * keyboard.c (Fthis_command_keys): Remove decl.
4555 (Fcommand_execute): New forward static decl.
4556 * keymap.c (Flookup_key): New forward static decl.
4557 (Fcopy_keymap): Now static.
4558 * keymap.h (Flookup_key): Remove decl.
4559 * process.c (Fget_process): New forward static decl.
4560 (Fprocess_datagram_address): Mark as internal.
4561 * syntax.c (Fsyntax_table_p): New forward static decl.
4562 (skip_chars): Remove duplicate decl.
4563 * textprop.c (Fprevious_property_change): New forward static decl.
4564 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4565 Now internal.
4566 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4567 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4568
4569 * editfns.c (Fformat): Remove unreachable code.
4570
4571 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4572
4573 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4574 change. (Bug#8496)
4575
4576 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4577
4578 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4579 when at ZV. (Bug#8487)
4580
4581 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4582
4583 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4584 (Bug#8437)
4585 * keyboard.c (parse_tool_bar_item): Likewise.
4586 * sound.c (sound_cleanup, alsa_close): Likewise.
4587 * termcap.c (tgetent): Likewise.
4588 * xfns.c (x_default_font_parameter): Likewise.
4589 * xsettings.c (read_and_apply_settings): Likewise.
4590
4591 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4592 (overrun_check_free): Protoize.
4593
4594 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4595
4596 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4597 since callers should never pass a negative size.
4598 Change the signature to match that of plain 'read' and 'write'; see
4599 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4600 * lisp.h: Update prototypes of emacs_write and emacs_read.
4601
4602 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4603
4604 * xdisp.c (redisplay_window): Don't try to determine the character
4605 position of the scroll margin if the window start point w->startp
4606 is outside the buffer's accessible region. (Bug#8468)
4607
4608 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4609
4610 Fix write-region and its subroutines for buffers > 2GB.
4611 * fileio.c (a_write, e_write): Modify declaration of arguments and
4612 local variables to support buffers larger than 2GB.
4613 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4614
4615 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4616 argument, local variables, and return value.
4617
4618 * lisp.h: Update prototypes of emacs_write and emacs_read.
4619
4620 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4621
4622 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4623
4624 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4625
4626 Fix more problems found by GCC 4.6.0's static checks.
4627
4628 * xdisp.c (vmessage): Use a better test for character truncation.
4629
4630 * charset.c (load_charset_map): <, not <=, for optimization,
4631 and to avoid potential problems with integer overflow.
4632 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4633 * casetab.c (set_identity, shuffle): Likewise.
4634 * editfns.c (Fformat): Likewise.
4635 * syntax.c (skip_chars): Likewise.
4636
4637 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4638 This also lets GCC 4.6.0 generate slightly better loop code.
4639
4640 * callint.c (Fcall_interactively): <, not <=, for optimization.
4641 (Fcall_interactively): Count the number of arguments produced,
4642 not the number of arguments given. This is simpler and lets GCC
4643 4.6.0 generate slightly better code.
4644
4645 * ftfont.c: Distingish more carefully between FcChar8 and char.
4646 The previous code passed unsigned char * to a functions like
4647 strlen and xstrcasecmp that expect char *, which does not
4648 conform to the C standard.
4649 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4650 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4651 char * when the C standard requires it.
4652
4653 * keyboard.c (read_char): Remove unused var.
4654
4655 * eval.c: Port to Windows vsnprintf (Bug#8435).
4656 Include <limits.h>.
4657 (SIZE_MAX): Define if the headers do not.
4658 (verror): Do not give up if vsnprintf returns a negative count.
4659 Instead, grow the buffer. This ports to Windows vsnprintf, which
4660 does not conform to C99. Problem reported by Eli Zaretskii.
4661 Also, simplify the allocation scheme, by avoiding the need for
4662 calling realloc, and removing the ALLOCATED variable.
4663
4664 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4665
4666 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4667 But keep the doprint source code for now, as we might revamp it
4668 and use it again (Bug#8435).
4669 * lisp.h (doprnt): Remove.
4670 * Makefile.in (base_obj): Remove doprnt.o.
4671 * deps.mk (doprnt.o): Remove.
4672
4673 error: Print 32- and 64-bit integers portably (Bug#8435).
4674 Without this change, on typical 64-bit hosts error ("...%d...", N)
4675 was used to print both 32- and 64-bit integers N, which relied on
4676 undefined behavior.
4677 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4678 New macro.
4679 * lisp.h (error, verror): Mark as printf-like functions.
4680 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4681 Report overflow in size calculations when allocating printf buffer.
4682 Do not truncate output string at its first null byte.
4683 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4684 Truncate the output at a character boundary, since vsnprintf does not
4685 do that.
4686 * charset.c (check_iso_charset_parameter): Convert internal
4687 character to string before calling 'error', since %c now has the
4688 printf meaning.
4689 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4690 overflow when computing char to be passed to 'error'. Do not
4691 pass Lisp_Object to 'error'; pass the integer instead.
4692 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4693 formatted with plain %d.
4694
4695 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4696
4697 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4698
4699 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4700
4701 * xterm.c (x_catch_errors): Remove duplicate declaration.
4702
4703 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4704
4705 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4706
4707 2011-04-10 Jim Meyering <meyering@redhat.com>
4708
4709 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4710 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4711 return ssize_t not "int", and use size_t as the buffer length.
4712 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4713 * gnutls.h: Update declarations.
4714 * process.c (read_process_output): Use ssize_t, to match.
4715 (send_process): Likewise.
4716
4717 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4718
4719 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4720
4721 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4722
4723 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4724 Use unsigned char, to match FcChar8 type definition.
4725
4726 * xterm.c (handle_one_xevent):
4727 * xmenu.c (create_and_show_popup_menu):
4728 * xselect.c (x_decline_selection_request)
4729 (x_reply_selection_request): Avoid type-punned deref of X events.
4730
4731 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4732
4733 Fix some uses of `int' instead of EMACS_INT.
4734 * search.c (string_match_1, fast_string_match)
4735 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4736 (scan_buffer, find_next_newline_no_quit)
4737 (find_before_next_newline, search_command, Freplace_match)
4738 (Fmatch_data): Make some `int' variables be EMACS_INT.
4739
4740 * xdisp.c (display_count_lines): 3rd argument and return value now
4741 EMACS_INT. All callers changed.
4742 (pint2hrstr): Last argument is now EMACS_INT.
4743
4744 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4745 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4746 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4747 (decode_coding_utf_16, decode_coding_emacs_mule)
4748 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4749 (decode_coding_ccl, decode_coding_charset)
4750 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4751 (decode_coding_iso_2022, decode_coding_emacs_mule)
4752 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4753 <char_offset, last_offset>: Declare EMACS_INT.
4754 (encode_coding_utf_8, encode_coding_utf_16)
4755 (encode_coding_emacs_mule, encode_invocation_designation)
4756 (encode_designation_at_bol, encode_coding_iso_2022)
4757 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4758 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4759 Declare EMACS_INT.
4760 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4761 (encode_invocation_designation): Last argument P_NCHARS is now
4762 EMACS_INT.
4763 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4764 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4765
4766 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4767 All users changed.
4768
4769 * ccl.c (Fccl_execute_on_string): Declare some variables
4770 EMACS_INT.
4771
4772 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4773
4774 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4775
4776 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4777
4778 * process.c (Fformat_network_address): Doc fix.
4779
4780 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4781
4782 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4783
4784 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4785
4786 * keyboard.c (read_char): Call Lisp function help-form-show,
4787 instead of using internal_with_output_to_temp_buffer.
4788 (Qhelp_form_show): New var.
4789 (syms_of_keyboard): Use DEFSYM macro.
4790
4791 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4792
4793 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4794
4795 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4796
4797 * process.c (Flist_processes): Remove to Lisp.
4798 (list_processes_1): Delete.
4799
4800 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4801
4802 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4803
4804 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4805
4806 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4807
4808 Fix more problems found by GCC 4.6.0's static checks.
4809
4810 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4811
4812 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4813
4814 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4815
4816 * xdisp.c (vmessage): Mark as a printf-like function.
4817
4818 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4819
4820 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4821
4822 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4823 printf-like functions.
4824 (tiff_load): Add casts to remove these marks before passing them
4825 to system-supplied API.
4826
4827 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4828
4829 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4830 This avoids several warnings with gcc -Wstrict-overflow.
4831 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4832 directly, rather than having caller test rule sign. This avoids
4833 some unnecessary tests.
4834 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4835 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4836 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4837
4838 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4839 (xfont_open): Avoid unnecessary tests.
4840
4841 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4842
4843 * composite.h, composite.c (composition_gstring_put_cache):
4844 Use EMACS_INT, not int, for length.
4845
4846 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4847 breaking out part of COMPOSITION_DECODE_RULE.
4848 (COMPOSITION_DECODE_RULE): Use it.
4849 * composite.c (get_composition_id): Remove unused local vars,
4850 by using the new macro.
4851
4852 * textprop.c (set_text_properties_1): Change while to do-while,
4853 since the condition is always true at first.
4854
4855 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4856 (interval_deletion_adjustment): Return unsigned value.
4857 All uses changed.
4858
4859 * process.c (list_processes_1, create_pty, read_process_output):
4860 (exec_sentinel): Remove vars that were set but not used.
4861 (create_pty): Remove unnecessary "volatile"s.
4862 (Fnetwork_interface_info): Avoid possibility of int overflow.
4863 (read_process_output): Do adaptive read buffering even if carryover.
4864 (read_process_output): Simplify nbytes computation if buffered.
4865
4866 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4867
4868 * syntax.c (scan_words): Remove var that was set but not used.
4869 (update_syntax_table): Use unsigned instead of int.
4870
4871 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4872 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4873 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4874
4875 * print.c (print_error_message): Avoid int overflow.
4876
4877 * font.c (font_list_entities): Redo for clarity,
4878 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4879
4880 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4881 (font_score): Avoid potential overflow in diff calculation.
4882
4883 * fns.c (substring_both): Remove var that is set but not used.
4884 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4885
4886 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4887
4888 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4889 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4890 can always succeed if overflow has undefined behavior.
4891
4892 * search.c (boyer_moore, wordify): Remove vars set but not used.
4893 (wordify): Omit three unnecessary tests.
4894
4895 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4896 All callers changed. This avoids the need for an unused var.
4897
4898 * casefiddle.c (casify_region): Remove var that is set but not used.
4899
4900 * dired.c (file_name_completion): Remove var that is set but not used.
4901
4902 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4903
4904 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4905 (Finsert_file_contents): Remove unnecessary code checking fd.
4906
4907 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4908 Check for integer overflow on size calculations.
4909
4910 * buffer.c (Fprevious_overlay_change): Remove var that is set
4911 but not used.
4912
4913 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4914 Remove vars that are set but not used.
4915 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4916 (timer_check_2): Mark vars as initialized.
4917
4918 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4919
4920 * image.c (lookup_image): Remove var that is set but not used.
4921 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4922
4923 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4924 that are set but not used.
4925
4926 * xfns.c (make_invisible_cursor): Don't return garbage
4927 if XCreateBitmapFromData fails (Bug#8410).
4928
4929 * xselect.c (x_get_local_selection, x_handle_property_notify):
4930 Remove vars that are set but not used.
4931
4932 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4933 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4934
4935 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4936 Remove var that is set but not used.
4937 (scroll_bar_windows_size): Now size_t, not int.
4938 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4939 Check for overflow.
4940
4941 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4942 (map_tty_color) [!defined MSDOS]: Likewise.
4943
4944 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4945
4946 * coding.c: Remove vars that are set but not used.
4947 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4948 All callers changed.
4949 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4950 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4951 (decode_coding_charset): Remove vars that are set but not used.
4952
4953 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4954 that is set but not used.
4955
4956 * print.c (print_object): Remove var that is set but not used.
4957
4958 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4959 The gnulib version avoids calling malloc in the usual case,
4960 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4961 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4962 * filelock.c (current_lock_owner): Likewise.
4963 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4964 * sysdep.c: Include allocator.h, careadlinkat.h.
4965 (emacs_no_realloc_allocator): New static constant.
4966 (emacs_readlink): New function.
4967 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4968 ../lib/careadlinkat.h.
4969
4970 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4971
4972 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4973 first non-nil return value).
4974
4975 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4976
4977 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4978 if not defined (Bug#8403).
4979
4980 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4981
4982 * xdisp.c (display_count_lines): Remove parameter `start',
4983 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4984 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4985 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4986 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4987 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4988 and thereabouts. All callers changed.
4989 (get_per_char_metric): Remove parameter `f', unused since
4990 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4991
4992 2011-04-02 Jim Meyering <meyering@redhat.com>
4993
4994 do not dereference NULL upon failed strdup
4995 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4996 (ns_get_family): Likewise.
4997
4998 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4999
5000 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5001
5002 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5003
5004 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5005 later (Bug#8403).
5006
5007 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5008
5009 Add lexical binding.
5010
5011 * window.c (Ftemp_output_buffer_show): New fun.
5012 (Fsave_window_excursion):
5013 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5014
5015 * lread.c (lisp_file_lexically_bound_p): New function.
5016 (Fload): Bind Qlexical_binding.
5017 (readevalloop): Remove `evalfun' arg.
5018 Bind Qinternal_interpreter_environment.
5019 (Feval_buffer): Bind Qlexical_binding.
5020 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5021 Mark as dynamic.
5022 (syms_of_lread): Declare `lexical-binding'.
5023
5024 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5025
5026 * keyboard.c (eval_dyn): New fun.
5027 (menu_item_eval_property): Use it.
5028
5029 * image.c (parse_image_spec): Use Ffunctionp.
5030
5031 * fns.c (concat, mapcar1): Accept byte-code-functions.
5032
5033 * eval.c (Fsetq): Handle lexical vars.
5034 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5035 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5036 (FletX, Flet): Obey lexical binding.
5037 (Fcommandp): Handle closures.
5038 (Feval): New `lexical' arg.
5039 (eval_sub): New function extracted from Feval. Use it almost
5040 everywhere where Feval was used. Look up vars in lexical env.
5041 Handle closures.
5042 (Ffunctionp): Move from subr.el.
5043 (Ffuncall): Handle closures.
5044 (apply_lambda): Remove `eval_flags'.
5045 (funcall_lambda): Handle closures and new byte-code-functions.
5046 (Fspecial_variable_p): New function.
5047 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5048 but without exporting it to Lisp.
5049
5050 * doc.c (Fdocumentation, store_function_docstring):
5051 * data.c (Finteractive_form): Handle closures.
5052
5053 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5054 interactive spec.
5055
5056 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5057 New byte-codes.
5058 (exec_byte_code): New function extracted from Fbyte_code to handle new
5059 calling convention for byte-code-functions. Add new byte-codes.
5060
5061 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5062
5063 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5064
5065 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5066
5067 * xdisp.c (redisplay_internal): Fix prototype.
5068
5069 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5070
5071 * xdisp.c (SCROLL_LIMIT): New macro.
5072 (try_scrolling): Use it when setting scroll_limit.
5073 Limit scrolling to 100 screen lines.
5074 (redisplay_window): Even when falling back on "recentering",
5075 position point in the window according to scroll-conservatively,
5076 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5077
5078 (try_scrolling): When point is above the window, allow searching
5079 as far as scroll_max, or one screenful, to compute vertical
5080 distance from PT to the scroll margin position. This prevents
5081 try_scrolling from unnecessarily failing when
5082 scroll-conservatively is set to a value slightly larger than the
5083 window height. Clean up the case of PT below the margin at bottom
5084 of window: scroll_max can no longer be INT_MAX. When aggressive
5085 scrolling is in use, don't let point enter the opposite scroll
5086 margin as result of the scroll.
5087 (syms_of_xdisp) <scroll-conservatively>: Document the
5088 threshold of 100 lines for never-recentering scrolling.
5089
5090 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5091
5092 * dispextern.h (move_it_by_lines):
5093 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5094 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5095 (message_log_check_duplicate): Remove parameters `prev_bol' and
5096 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5097 (redisplay_internal): Remove parameter `preserve_echo_area',
5098 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5099
5100 * indent.c (Fvertical_motion):
5101 * window.c (window_scroll_pixel_based, Frecenter):
5102 Don't pass `need_y_p' to `move_it_by_lines'.
5103
5104 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5105
5106 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5107 steal a few bits to be more compact.
5108 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5109 Remove unneeded casts.
5110
5111 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5112
5113 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5114
5115 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5116 binding" message (bug#7967).
5117
5118 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5119
5120 Fix more problems found by GCC 4.6.0's static checks.
5121
5122 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5123 Remove unused local var.
5124
5125 * editfns.c (Fmessage_box): Remove unused local var.
5126
5127 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5128 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5129 Omit unused local vars.
5130 * window.c (shrink_windows): Omit unused local var.
5131 * menu.c (digest_single_submenu): Omit unused local var.
5132 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5133 Omit unused local var.
5134
5135 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5136 Don't assume string length fits in int.
5137 (keyremap_step, read_key_sequence): Use size_t for sizes.
5138 (read_key_sequence): Don't check last_real_key_start redundantly.
5139
5140 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5141 instead of alloca (Bug#8344).
5142
5143 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5144 (Fbacktrace_frame): Don't assume nframes fits in int.
5145
5146 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5147
5148 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5149 concerns.
5150
5151 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5152
5153 * cm.c (calccost): Turn while-do into do-while, for clarity.
5154
5155 * keyboard.c (syms_of_keyboard): Use the same style as later
5156 in this function when indexing through an array. This also
5157 works around GCC bug 48267.
5158
5159 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5160
5161 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5162
5163 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5164 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5165
5166 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5167 This avoids undefined behavior on integer overflow, and is a bit
5168 more convenient anyway since it is compared to a size_t variable.
5169
5170 Variadic C functions now count arguments with size_t, not int.
5171 This avoids an unnecessary limitation on 64-bit machines, which
5172 caused (substring ...) to crash on large vectors (Bug#8344).
5173 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5174 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5175 All variadic functions and their callers changed accordingly.
5176 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5177 * data.c (arith_driver, float_arith_driver): Likewise.
5178 * editfns.c (general_insert_function): Likewise.
5179 * eval.c (struct backtrace.nargs, interactive_p)
5180 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5181 (funcall_lambda, mark_backtrace): Likewise.
5182 * fns.c (concat): Likewise.
5183 * frame.c (x_set_frame_parameters): Likewise.
5184 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5185 0 if not found, not -1. All callers changed.
5186
5187 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5188 (stack_copy_size): Now size_t, not int.
5189 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5190
5191 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5192
5193 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5194 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5195 All callers changed.
5196
5197 * lisp.h (multibyte_char_to_unibyte):
5198 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5199 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5200 * character.h (CHAR_TO_BYTE8):
5201 * cmds.c (internal_self_insert):
5202 * editfns.c (general_insert_function):
5203 * keymap.c (push_key_description):
5204 * search.c (Freplace_match):
5205 * xdisp.c (message_dolog, set_message_1): All callers changed.
5206
5207 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5208
5209 * keyboard.c (safe_run_hook_funcall): New function.
5210 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5211 don't set the hook to nil, but remove the offending function instead.
5212 (Qcommand_hook_internal): Remove, unused.
5213 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5214 Vcommand_hook_internal.
5215
5216 * eval.c (enum run_hooks_condition): Remove.
5217 (funcall_nil, funcall_not): New functions.
5218 (run_hook_with_args): Call each function through a `funcall' argument.
5219 Remove `cond' argument, now redundant.
5220 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5221 (Frun_hook_with_args_until_failure): Adjust accordingly.
5222 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5223
5224 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5225
5226 * dispextern.h (string_buffer_position): Remove declaration.
5227
5228 * print.c (strout): Remove parameter `multibyte', unused since
5229 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5230
5231 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5232 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5233 All callers changed.
5234
5235 * w32.c (_wsa_errlist): Use braces for struct initializers.
5236
5237 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5238 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5239 All callers changed.
5240 (string_buffer_position): Likewise. Also, make static (it's never
5241 used outside xdisp.c).
5242 (cursor_row_p): Remove parameter `w', unused since
5243 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5244 (decode_mode_spec): Remove parameter `precision', introduced during
5245 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5246 All callers changed.
5247
5248 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5249
5250 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5251
5252 2011-03-27 Anders Lindgren <andlind@gmail.com>
5253
5254 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5255 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5256 (ns_update_auto_hide_menu_bar): New functions.
5257 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5258 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5259 ns_constrain_all_frames.
5260 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5261 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5262
5263 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5264
5265 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5266
5267 2011-03-27 Glenn Morris <rgm@gnu.org>
5268
5269 * syssignal.h: Replace RETSIGTYPE with void.
5270 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5271 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5272 Replace SIGTYPE with void everywhere.
5273 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5274 * s/template.h (SIGTYPE): Remove commented out definition.
5275
5276 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5277
5278 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5279 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5280
5281 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5282
5283 * w32.c (read_unc_volume): Use parameter `henum', instead of
5284 global variable `wget_enum_handle'.
5285
5286 * keymap.c (describe_vector): Remove parameters `indices' and
5287 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5288 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5289
5290 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5291
5292 * keyboard.c (timer_check): Remove parameter `do_it_now',
5293 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5294 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5295 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5296
5297 * keyboard.c (read_char):
5298 * w32menu.c (w32_menu_display_help):
5299 * xmenu.c (show_help_event, menu_help_callback):
5300 Adjust calls to `show_help_echo'.
5301
5302 * gtkutil.c (xg_maybe_add_timer):
5303 * keyboard.c (readable_events):
5304 * process.c (wait_reading_process_output):
5305 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5306
5307 * insdel.c (adjust_markers_gap_motion):
5308 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5309 (gap_left, gap_right): Don't call it.
5310
5311 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5312
5313 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5314 incurred during fontification.
5315
5316 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5317
5318 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5319 (DEFVAR_PER_BUFFER): Don't pass it.
5320
5321 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5322 (scrolling_window): Don't pass it.
5323
5324 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5325
5326 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5327
5328 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5329 and `suffix'.
5330 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5331 of variables specific to SELinux and computation of `encoded_absname'.
5332
5333 * image.c (XPutPixel): Remove unused variable `height'.
5334
5335 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5336
5337 * unexw32.c (get_section_info): Remove unused variable `section'.
5338
5339 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5340 (system_process_attributes): Remove unused variable `sess'.
5341 (sys_read): Remove unused variable `err'.
5342
5343 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5344 (w32_wnd_proc): Remove unused variable `isdead'.
5345 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5346 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5347 (x_create_tip_frame): Remove unused variable `tem'.
5348
5349 * w32inevt.c (w32_console_read_socket):
5350 Remove unused variable `no_events'.
5351
5352 * w32term.c (x_draw_composite_glyph_string_foreground):
5353 Remove unused variable `width'.
5354
5355 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5356
5357 * w32term.c (x_set_glyph_string_clipping):
5358 Don't pass uninitialized region to CombineRgn.
5359
5360 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5361
5362 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5363 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5364 (Fx_close_connection): Remove unused variable `i'.
5365
5366 * w32font.c (w32font_draw): Return number of glyphs.
5367 (w32font_open_internal): Remove unused variable `i'.
5368 (w32font_driver): Add missing initializer.
5369
5370 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5371 (fill_in_menu): Remove unused variable `items_added'.
5372
5373 * w32term.c (last_mouse_press_frame): Remove static global variable.
5374 (w32_clip_to_row): Remove unused variable `f'.
5375 (x_delete_terminal): Remove unused variable `i'.
5376
5377 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5378 (NOTHING): Remove unused static global variable.
5379 (uniscribe_check_otf): Remove unused variable `table'.
5380 (uniscribe_font_driver): Add missing initializers.
5381
5382 2011-03-23 Julien Danjou <julien@danjou.info>
5383
5384 * term.c (Fsuspend_tty, Fresume_tty):
5385 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5386 * window.c (temp_output_buffer_show):
5387 * insdel.c (signal_before_change):
5388 * frame.c (Fhandle_switch_frame):
5389 * fileio.c (Fdo_auto_save):
5390 * emacs.c (Fkill_emacs):
5391 * editfns.c (save_excursion_restore):
5392 * cmds.c (internal_self_insert):
5393 * callint.c (Fcall_interactively):
5394 * buffer.c (Fkill_all_local_variables):
5395 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5396 Use Frun_hooks.
5397 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5398 unconditionnaly since it does the check itself.
5399
5400 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5401
5402 Fix more problems found by GCC 4.5.2's static checks.
5403
5404 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5405 the first time through the loop, since we know p0 < p1 then.
5406 This also avoids a gcc -Wstrict-overflow warning.
5407
5408 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5409 leading to a memory leak, possible in functions like
5410 load_charset_map_from_file that can allocate an unbounded number
5411 of objects (Bug#8318).
5412
5413 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5414 that could (at least in theory) be that large.
5415
5416 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5417 This is less likely to overflow, and avoids undefined behavior if
5418 overflow does occur. All callers changed. Use strtoul to scan
5419 for the unsigned long integer.
5420 (pint2hrstr): Simplify and tune code slightly.
5421 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5422
5423 * scroll.c (do_scrolling): Work around GCC bug 48228.
5424 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5425
5426 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5427 This also avoids a warning with gcc -Wstrict-overflow.
5428 (validate_x_resource_name): Simplify count usage.
5429 This also avoids a warning with gcc -Wstrict-overflow.
5430
5431 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5432 fail (Bug#8306).
5433
5434 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5435
5436 * process.c (Fmake_network_process): Use socklen_t, not int,
5437 where POSIX says socklen_t is required in portable programs.
5438 This fixes a porting bug on hosts like 64-bit HP-UX, where
5439 socklen_t is wider than int (Bug#8277).
5440 (Fmake_network_process, server_accept_connection):
5441 (wait_reading_process_output, read_process_output):
5442 Likewise.
5443
5444 * process.c: Rename or move locals to avoid shadowing.
5445 (list_processes_1, Fmake_network_process):
5446 (read_process_output_error_handler, exec_sentinel_error_handler):
5447 Rename or move locals.
5448 (Fmake_network_process): Define label "retry_connect" only if needed.
5449 (Fnetwork_interface_info): Fix pointer signedness.
5450 (process_send_signal): Add cast to avoid pointer signedness problem.
5451 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5452 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5453
5454 Make tparam.h and terminfo.c consistent.
5455 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5456 Include tparam.h instead, since it declares them.
5457 * cm.h (PC): Remove extern decl; tparam.h now does this.
5458 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5459 * terminfo.c: Include tparam.h, to check interfaces.
5460 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5461 (tparam): Adjust signature to match interface in tparam.h;
5462 this removes some undefined behavior. Check that outstring and len
5463 are zero, which they always are with Emacs.
5464 * tparam.h (PC, BC, UP): New extern decls.
5465
5466 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5467 (xftfont_open): Rename locals to avoid shadowing.
5468
5469 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5470 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5471 (OTF_TAG_SYM): Omit macro if not needed.
5472 (ftfont_list): Remove unused local.
5473 (get_adstyle_property, ftfont_pattern_entity):
5474 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5475 Rename locals to avoid shadowing.
5476
5477 * xfont.c (xfont_list_family): Mark var as initialized.
5478
5479 * xml.c (make_dom): Now static.
5480
5481 * composite.c (composition_compute_stop_pos): Rename local to
5482 avoid shadowing.
5483 (composition_reseat_it): Remove unused locals.
5484 (find_automatic_composition, composition_adjust_point): Likewise.
5485 (composition_update_it): Mark var as initialized.
5486 (find_automatic_composition): Mark vars as initialized,
5487 with a FIXME (Bug#8290).
5488
5489 character.h: Rename locals to avoid shadowing.
5490 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5491 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5492 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5493 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5494 to avoid shadowing.
5495
5496 * textprop.c (property_change_between_p): Remove; unused.
5497
5498 * intervals.c (interval_start_pos): Now static.
5499
5500 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5501
5502 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5503 Rename locals to avoid shadowing.
5504
5505 * sound.c (wav_play, au_play, Fplay_sound_internal):
5506 Fix pointer signedness.
5507 (alsa_choose_format): Remove unused local var.
5508 (wav_play): Initialize a variable to 0, to prevent undefined
5509 behavior (Bug#8278).
5510
5511 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5512
5513 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5514
5515 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5516 clobbering (Bug#8298).
5517 * sysdep.c (sys_subshell): Likewise.
5518 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5519
5520 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5521 This should get cleaned up, so that child_setup has the
5522 same signature on all platforms.
5523
5524 * callproc.c (call_process_cleanup): Now static.
5525 (relocate_fd): Rename locals to avoid shadowing.
5526
5527 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5528
5529 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5530 not to be necessary, and produces flickering.
5531
5532 2011-03-20 Glenn Morris <rgm@gnu.org>
5533
5534 * config.in: Remove file.
5535
5536 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5537
5538 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5539 are now in src/globals.h.
5540 (syms_of_minibuf): Remove spurious & from previous change.
5541
5542 2011-03-20 Leo <sdl.web@gmail.com>
5543
5544 * minibuf.c (completing-read-function): New variable.
5545 (completing-read-default): Rename from completing-read.
5546 (completing-read): Call completing-read-function.
5547
5548 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5549
5550 * xfaces.c (Fx_load_color_file):
5551 Read color file from absolute filename (bug#8250).
5552
5553 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5554
5555 * makefile.w32-in: Update dependencies.
5556
5557 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5558
5559 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5560
5561 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5562
5563 Fix more problems found by GCC 4.5.2's static checks.
5564
5565 * process.c (make_serial_process_unwind, send_process_trap):
5566 (sigchld_handler): Now static.
5567
5568 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5569 That way, the code declares only the vars that it needs.
5570 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5571 * s/cygwin.h (PTY_ITERATION): Likewise.
5572 * s/darwin.h (PTY_ITERATION): Likewise.
5573 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5574
5575 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5576 * process.c (allocate_pty): Don't declare stb unless it's needed.
5577
5578 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5579 (CONSTANTLIM): Remove; unused.
5580 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5581 Define only if needed.
5582
5583 * unexelf.c (unexec): Name an expression,
5584 to avoid gcc -Wbad-function-cast warning.
5585 Use a different way to cause a compilation error if anyone uses
5586 n rather than nn, a way that does not involve shadowing.
5587 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5588
5589 * deps.mk (unexalpha.o): Remove; unused.
5590
5591 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5592 * unexec.h: New file.
5593 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5594 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5595 Depend on unexec.h.
5596 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5597 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5598 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5599 Change as necessary to match prototype in unexec.h.
5600
5601 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5602 shadowing.
5603 (back_comment, skip_chars): Mark vars as initialized.
5604
5605 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5606 Rename locals to avoid shadowing.
5607
5608 * lread.c (read1): Rewrite so as not to use empty "else".
5609 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5610
5611 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5612
5613 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5614 warning when compiling print.c.
5615
5616 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5617 instead of using an uninitialized var.
5618 (font_sort_entities): Mark var as initialized.
5619
5620 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5621
5622 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5623 pointers to constants.
5624 (font_parse_fcname): Remove unused vars.
5625 (font_delete_unmatched): Now static.
5626 (font_get_spec): Remove; unused.
5627 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5628 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5629 Rename or move locals to avoid shadowing.
5630
5631 * fns.c (require_nesting_list, require_unwind): Now static.
5632 (Ffillarray): Rename locals to avoid shadowing.
5633
5634 * floatfns.c (domain_error2): Define only if needed.
5635 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5636
5637 * alloc.c (mark_backtrace): Move decl from here ...
5638 * lisp.h: ... to here, so that it can be checked.
5639
5640 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5641 (Fdefvar): Rewrite so as not to use empty "else".
5642 (lisp_indirect_variable): Name an expression,
5643 to avoid gcc -Wbad-function-cast warning.
5644 (Fdefvar): Rename locals to avoid shadowing.
5645
5646 * callint.c (quotify_arg, quotify_args): Now static.
5647 (Fcall_interactively): Rename locals to avoid shadowing.
5648 Use const pointer when appropriate.
5649
5650 * lisp.h (get_system_name, get_operating_system_release):
5651 Move decls here, to check interfaces.
5652 * process.c (get_operating_system_release): Move decl to lisp.h.
5653 * xrdb.c (get_system_name): Likewise.
5654 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5655 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5656 some of which prompt warnings from gcc -Wbad-function-cast.
5657 (Fformat_time_string, Fencode_time, Finsert_char):
5658 (Ftranslate_region_internal, Fformat):
5659 Rename or remove local vars to avoid shadowing.
5660 (Ftranslate_region_internal): Mark var as initialized.
5661
5662 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5663 avoid shadowing.
5664
5665 * lisp.h (eassert): Check that the argument compiles, even if
5666 ENABLE_CHECKING is not defined.
5667
5668 * data.c (Findirect_variable): Name an expression, to avoid
5669 gcc -Wbad-function-cast warning.
5670 (default_value, arithcompare, arith_driver, arith_error): Now static.
5671 (store_symval_forwarding): Rename local to avoid shadowing.
5672 (Fmake_variable_buffer_local, Fmake_local_variable):
5673 Mark variables as initialized.
5674 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5675
5676 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5677 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5678 Rename locals to avoid shadowing.
5679 (mark_stack): Move local variables into the #ifdef region where
5680 they're used.
5681 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5682 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5683 needed otherwise.
5684 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5685 (GC_STRING_CHARS): Remove; not used.
5686 (Fmemory_limit): Cast sbrk's returned value to char *.
5687
5688 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5689 avoids undefined behavior in theory.
5690
5691 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5692
5693 Use functions, not macros, for up- and down-casing (Bug#8254).
5694 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5695 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5696 to use the following functions instead of these macros.
5697 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5698 EMACS_INT, since callers assume the returned value fits in int.
5699 (upcase1): Likewise, for UPCASE_TABLE.
5700 (uppercasep, lowercasep, upcase): New static inline functions.
5701 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5702 the race-condition problem in the old DOWNCASE.
5703
5704 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5705 Rename locals to avoid shadowing.
5706 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5707 (regex_compile, re_search_2, re_match_2_internal):
5708 Remove unused local vars.
5709 (FREE_VAR): Rewrite so as not to use empty "else",
5710 which gcc can warn about.
5711 (regex_compile, re_match_2_internal): Mark locals as initialized.
5712 (RETALLOC_IF): Define only if needed.
5713 (WORDCHAR_P): Likewise. This one is never needed, but is used
5714 only in a comment talking about a compiler bug, so put inside
5715 the #if 0 of that comment.
5716 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5717 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5718 Remove; unused.
5719
5720 * search.c (boyer_moore): Rename locals to avoid shadowing.
5721 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5722 (PREV_CHAR_BOUNDARY): Likewise.
5723
5724 * search.c (simple_search): Remove unused var.
5725
5726 * dired.c (compile_pattern): Move decl from here ...
5727 * lisp.h: ... to here, so that it can be checked.
5728 (struct re_registers): New forward decl.
5729
5730 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5731
5732 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5733 All uses changed.
5734 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5735 Rename locals to avoid shadowing.
5736 (Fvertical_motion): Mark locals as initialized.
5737
5738 * casefiddle.c (casify_object, casify_region): Now static.
5739 (casify_region): Mark local as initialized.
5740
5741 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5742
5743 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5744 New macros, so that the caller can use some names other than
5745 gcpro1, gcpro2, etc.
5746 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5747 of the new macros.
5748 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5749 argument, for consistency with GCPRO2_VAR, etc: it is now the
5750 prefix of the variable, not the variable itself. All uses
5751 changed.
5752 * dired.c (directory_files_internal, file_name_completion):
5753 Rename locals to avoid shadowing.
5754
5755 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5756 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5757 dired.c's scmp function, had undefined behavior.
5758 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5759 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5760 * buffer.h: ... to here, because these macros use current_buffer,
5761 and the new implementation with inline functions needs to have
5762 current_buffer in scope now, rather than later when the macros
5763 are used.
5764 (downcase, upcase1): New static inline functions.
5765 (DOWNCASE, UPCASE1): Reimplement using these functions.
5766 This avoids undefined behavior in expressions like
5767 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5768 from race conditions in accessing the global variables
5769 case_temp1 and case_temp2.
5770 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5771 * lisp.h (case_temp1, case_temp2): Remove their decls.
5772 * character.h (ASCII_CHAR_P): Move from here ...
5773 * lisp.h: ... to here, so that the inline functions mentioned
5774 above can use them.
5775
5776 * dired.c (directory_files_internal_unwind): Now static.
5777
5778 * fileio.c (file_name_as_directory, directory_file_name):
5779 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5780 Now static.
5781 (file_name_as_directory): Use const pointers when appropriate.
5782 (Fexpand_file_name): Likewise. In particular, newdir might
5783 point at constant storage, so make it a const pointer.
5784 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5785 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5786 signedness issues.
5787 (Fset_file_times, Finsert_file_contents, auto_save_error):
5788 Rename locals to avoid shadowing.
5789
5790 * minibuf.c (choose_minibuf_frame_1): Now static.
5791 (Ftry_completion, Fall_completions): Rename or remove locals
5792 to avoid shadowing.
5793
5794 * marker.c (bytepos_to_charpos): Remove; unused.
5795
5796 * lisp.h (verify_bytepos, count_markers): New decls,
5797 so that gcc does not warn that these functions aren't declared.
5798
5799 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5800 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5801 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5802 (copy_text): Remove unused local var.
5803
5804 * filelock.c (within_one_second): Now static.
5805 (lock_file_1): Rename local to avoid shadowing.
5806
5807 * buffer.c (fix_overlays_before): Mark locals as initialized.
5808 (fix_start_end_in_overlays): Likewise. This function should be
5809 simplified by using pointers-to-pointers, but that's a different
5810 matter.
5811 (switch_to_buffer_1): Now static.
5812 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5813 (report_overlay_modification): Rename locals to avoid shadowing.
5814
5815 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5816 Fix pointer signedness issue.
5817 (sys_subshell): Mark local as volatile if checking for lint,
5818 to suppress a gcc -Wclobbered warning that does not seem to be right.
5819 (MAXPATHLEN): Define only if needed.
5820
5821 * process.c (serial_open, serial_configure): Move decls from here ...
5822 * systty.h: ... to here, so that they can be checked.
5823
5824 * fns.c (get_random, seed_random): Move extern decls from here ...
5825 * lisp.h: ... to here, so that they can be checked.
5826
5827 * sysdep.c (reset_io): Now static.
5828 (wait_for_termination_signal): Remove; unused.
5829
5830 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5831 (copy_keymap_item, append_key, push_text_char_description):
5832 Now static.
5833 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5834 (DENSE_TABLE_SIZE): Remove; unused.
5835 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5836 (describe_map_tree):
5837 Rename locals to avoid shadowing.
5838
5839 * keyboard.c: Declare functions static if they are not used elsewhere.
5840 (echo_char, echo_dash, cmd_error, top_level_2):
5841 (poll_for_input, handle_async_input): Now static.
5842 (read_char, kbd_buffer_get_event, make_lispy_position):
5843 (make_lispy_event, make_lispy_movement, apply_modifiers):
5844 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5845 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5846 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5847 (read_key_sequence, read_char): Mark locals as initialized.
5848 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5849
5850 * keyboard.h (make_ctrl_char): New decl.
5851 (mark_kboards): Move decl here ...
5852 * alloc.c (mark_kboards): ... from here.
5853
5854 * lisp.h (force_auto_save_soon): New decl.
5855
5856 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5857 (DEFINE_DUMMY_FUNCTION): New macro.
5858 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5859 Use it.
5860 (main): Add casts to avoid warnings
5861 if GCC considers string literals to be constants.
5862
5863 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5864
5865 * dbusbind.c: Pointer signedness fixes.
5866 (xd_signature, xd_append_arg, xd_initialize):
5867 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5868 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5869 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5870 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5871
5872 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5873 if GCC considers string literals to be constants.
5874 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5875
5876 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5877
5878 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5879 (print_preprocess, print_object): New macro to fix last change.
5880
5881 * print.c (print_preprocess): Don't forget font objects.
5882
5883 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5884
5885 * emacs.c (USAGE3): Doc fixes.
5886
5887 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5888
5889 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5890 structure.
5891
5892 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5893
5894 * lisp.h (VWindow_system, Qfile_name_history):
5895 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5896 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5897 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5898
5899 * w32select.c: Don't #include "keyboard.h".
5900 (run_protected): Add extern declaration for waiting_for_input.
5901
5902 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5903 * w32console.c (detect_input_pending, read_input_pending)
5904 (encode_terminal_code):
5905 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5906 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5907 (w32_system_caret_y, Qfile_name_history):
5908 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5909 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5910 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5911 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5912 * w32proc.c (Qlocal, report_file_error):
5913 * w32term.c (Vwindow_system, updating_frame):
5914 * w32uniscribe.c (initialized, uniscribe_font_driver):
5915 Remove unneeded extern declarations.
5916
5917 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5918
5919 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5920
5921 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5922
5923 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5924 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5925 These macros can no longer be used for assignment.
5926
5927 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5928 Assign struct members directly, instead of using BUF_BEGV etc.
5929 (record_buffer_markers, fetch_buffer_markers): New functions for
5930 recording and fetching special buffer markers.
5931 (set_buffer_internal_1, set_buffer_temp): Use them.
5932
5933 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5934
5935 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5936
5937 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5938 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5939
5940 * xdisp.c (hscroll_window_tree):
5941 (reconsider_clip_changes): Use PT instead of BUF_PT.
5942
5943 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5944
5945 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5946 $(EMACS_ROOT)/lib/intprops.h.
5947
5948 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5949
5950 Fix more problems found by GCC 4.5.2's static checks.
5951
5952 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5953 to unsigned char * to avoid compiler diagnostic.
5954 (xg_free_frame_widgets): Make it clear that a local variable is
5955 needed only if USE_GTK_TOOLTIP.
5956 (gdk_window_get_screen): Make it clear that this macro is needed
5957 only if USE_GTK_TOOLTIP.
5958 (int_gtk_range_get_value): New function, which avoids a diagnostic
5959 from gcc -Wbad-function-cast.
5960 (xg_set_toolkit_scroll_bar_thumb): Use it.
5961 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5962 diagnostic from gcc -Wbad-function-cast.
5963 (get_utf8_string, xg_get_file_with_chooser):
5964 Rename locals to avoid shadowing.
5965 (create_dialog): Move locals to avoid shadowing.
5966
5967 * xgselect.c (xg_select): Remove unused var.
5968
5969 * image.c (four_corners_best): Mark locals as initialized.
5970 (gif_load): Initialize transparent_p to zero (Bug#8238).
5971 Mark another local as initialized.
5972 (my_png_error, my_error_exit): Mark with NO_RETURN.
5973
5974 * image.c (clear_image_cache): Now static.
5975 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5976 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5977 (x_edge_detection): Remove unnecessary cast that
5978 gcc -Wbad-function-cast diagnoses.
5979 (gif_load): Fix pointer signedness.
5980 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5981 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5982
5983 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5984
5985 Improve quality of tests for time stamp overflow.
5986 For example, without this patch (encode-time 0 0 0 1 1
5987 1152921504606846976) returns the obviously-bogus value (-948597
5988 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5989 reports time overflow. See
5990 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5991 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5992 * editfns.c: Include limits.h and intprops.h.
5993 (TIME_T_MIN, TIME_T_MAX): New macros.
5994 (time_overflow): Move earlier, to before first use.
5995 (hi_time, lo_time): New functions, for an accurate test for
5996 out-of-range times.
5997 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5998 (Fget_internal_run_time): Don't assume time_t fits in int.
5999 (make_time): Use list2 instead of Fcons twice.
6000 (Fdecode_time): More accurate test for out-of-range times.
6001 (check_tm_member): New function.
6002 (Fencode_time): Use it, to test for out-of-range times.
6003 (lisp_time_argument): Don't rely on undefined left-shift and
6004 right-shift behavior when checking for time stamp overflow.
6005
6006 * editfns.c (time_overflow): New function, refactoring common code.
6007 (Fformat_time_string, Fdecode_time, Fencode_time):
6008 (Fcurrent_time_string): Use it.
6009
6010 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6011 * dired.c (make_time): Move to ...
6012 * editfns.c (make_time): ... here.
6013 * systime.h: Note the move.
6014
6015 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6016
6017 * fringe.c (update_window_fringes): Remove unused variables.
6018
6019 * unexmacosx.c (copy_data_segment): Also copy __got section.
6020 (Bug#8223)
6021
6022 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6023
6024 * termcap.c [MSDOS]: Include "msdos.h".
6025 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6026 Constify `char *' arguments and their references according to
6027 prototypes in tparam.h.
6028
6029 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6030
6031 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6032 Adapt all references accordingly.
6033
6034 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6035
6036 2011-03-11 Tom Tromey <tromey@redhat.com>
6037
6038 * buffer.c (syms_of_buffer): Remove obsolete comment.
6039
6040 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6041
6042 * termhooks.h (encode_terminal_code): Declare prototype.
6043
6044 * msdos.c (encode_terminal_code): Don't declare prototype.
6045
6046 * term.c (encode_terminal_code): Now external again, used by
6047 w32console.c and msdos.c.
6048
6049 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6050 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6051
6052 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6053
6054 Fix some minor problems found by GCC 4.5.2's static checks.
6055
6056 * fringe.c (update_window_fringes): Mark locals as initialized
6057 (Bug#8227).
6058 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6059
6060 * alloc.c (mark_fringe_data): Move decl from here ...
6061 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6062 to check its interface.
6063 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6064
6065 * fontset.c (free_realized_fontset): Now static.
6066 (Fset_fontset_font): Rename local to avoid shadowing.
6067 (fontset_font): Mark local as initialized.
6068 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6069
6070 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6071
6072 * xselect.c (x_disown_buffer_selections): Remove; not used.
6073 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6074 (x_own_selection, Fx_disown_selection_internal): Rename locals
6075 to avoid shadowing.
6076 (x_handle_dnd_message): Remove local to avoid shadowing.
6077
6078 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6079 so that the caller can use some name other than gcpro1.
6080 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6081 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6082 (Fx_backspace_delete_keys_p):
6083 Use them to avoid shadowing, and rename vars to avoid shadowing.
6084 (x_decode_color, x_set_name, x_window): Now static.
6085 (Fx_create_frame): Add braces to silence GCC warning.
6086 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6087 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6088 Remove unused locals.
6089 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6090 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6091 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6092 macros.
6093
6094 * xterm.h (x_mouse_leave): New decl.
6095
6096 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6097 Remove unused functions.
6098 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6099 (x_calc_absolute_position): Now static.
6100 (XTread_socket): Don't define label "out" unless it's used.
6101 Don't declare local "event" unless it's used.
6102 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6103 unless they are used.
6104 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6105 (x_fatal_error_signal): Remove; not used.
6106 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6107 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6108 (x_error_catcher, x_connection_closed, x_error_handler):
6109 (x_error_quitter, xembed_send_message, x_iconify_frame):
6110 (my_log_handler): Rename locals to avoid shadowing.
6111 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6112 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6113
6114 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6115 Rename or move locals to avoid shadowing.
6116 (tty_defined_color, merge_face_heights): Now static.
6117 (free_realized_faces_for_fontset): Remove; not used.
6118 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6119 does not deduce is never used uninitialized.
6120 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6121 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6122
6123 * terminal.c (store_terminal_param): Now static.
6124
6125 * xmenu.c (menu_highlight_callback): Now static.
6126 (set_frame_menubar): Remove unused local.
6127 (xmenu_show): Rename parameter to avoid shadowing.
6128 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6129 since they might point to immutable storage.
6130 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6131 since it's unused otherwise.
6132
6133 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6134 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6135 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6136 avoids a gcc -Wuninitialized diagnostic.
6137 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6138 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6139 does not deduce are never used uninitialized.
6140
6141 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6142
6143 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6144 * window.c (window_loop, size_window):
6145 (run_window_configuration_change_hook, enlarge_window): Likewise.
6146
6147 * window.c (display_buffer): Now static.
6148 (size_window): Mark variables that gcc -Wuninitialized
6149 does not deduce are never used uninitialized.
6150 * window.h (check_all_windows): New decl, to forestall
6151 gcc -Wmissing-prototypes diagnostic.
6152 * dispextern.h (bidi_dump_cached_states): Likewise.
6153
6154 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6155 shadowing.
6156 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6157 Include <limits.h>.
6158 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6159 and to avoid gcc -Wuninitialized warning.
6160 (load_charset_map): Mark variables that gcc -Wuninitialized
6161 does not deduce are never used uninitialized.
6162 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6163
6164 * coding.c (coding_set_source, coding_set_destination):
6165 Use "else { /* comment */ }" rather than "else /* comment */;"
6166 for clarity, and to avoid gcc -Wempty-body warning.
6167 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6168 a block, when the outer 'i' will do.
6169 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6170 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6171 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6172 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6173 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6174 Rename locals to avoid shadowing.
6175 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6176 * coding.c (emacs_mule_char, encode_invocation_designation):
6177 Now static, since they're not used elsewhere.
6178 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6179 (decode_coding_object, encode_coding_object, detect_coding_system):
6180 (decode_coding_emacs_mule): Mark variables that gcc
6181 -Wuninitialized does not deduce are never used uninitialized.
6182 (detect_coding_iso_2022): Initialize a local variable that might
6183 be used uninitialized. Leave a FIXME because it's not clear that
6184 this initialization is needed. (Bug#8211)
6185 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6186 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6187 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6188 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6189 Remove unused macros.
6190
6191 * category.c (hash_get_category_set): Remove unused local var.
6192 (copy_category_table): Now static, since it's not used elsewhere.
6193 * character.c (string_count_byte8): Likewise.
6194
6195 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6196 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6197
6198 * chartab.c (copy_sub_char_table): Now static, since it's not used
6199 elsewhere.
6200 (sub_char_table_ref_and_range, char_table_ref_and_range):
6201 Rename locals to avoid shadowing.
6202 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6203
6204 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6205 (BIDI_BOB): Remove unused macro.
6206
6207 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6208 deduce are never used uninitialized.
6209 * term.c (encode_terminal_code): Likewise.
6210
6211 * term.c (encode_terminal_code): Now static. Remove unused local.
6212
6213 * tparam.h: New file.
6214 * term.c, tparam.h: Include it.
6215 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6216 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6217 Move these decls to tparam.h, and make them agree with what
6218 is actually in tparam.c. The previous trick of using incompatible
6219 decls in different modules does not conform to the C standard.
6220 All callers of tparam changed to use tparam's actual API.
6221 * tparam.c (tparam1, tparam, tgoto):
6222 Use const pointers where appropriate.
6223
6224 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6225 * cm.h (struct cm): Likewise.
6226 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6227 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6228 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6229 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6230 (turn_on_face, init_tty): Likewise.
6231 * termchar.h (struct tty_display_info): Likewise.
6232
6233 * term.c (term_mouse_position): Rename local to avoid shadowing.
6234
6235 * alloc.c (mark_ttys): Move decl from here ...
6236 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6237
6238 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6239
6240 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6241
6242 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6243
6244 * search.c (compile_pattern_1): Remove argument regp, unused since
6245 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6246 (compile_pattern): Don't pass it.
6247
6248 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6249
6250 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6251 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6252 for ! HAVE_GTK3.
6253 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6254
6255 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6256
6257 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6258 gdk_window_get_screen, gdk_window_get_geometry,
6259 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6260 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6261 (xg_get_pixbuf_from_pixmap): New function.
6262 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6263 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6264 Call xg_get_pixbuf_from_pixmap instead of
6265 gdk_pixbuf_get_from_drawable.
6266 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6267 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6268 (xg_check_special_colors): Use GtkStyleContext and its functions
6269 for HAVE_GTK3.
6270 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6271 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6272 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6273 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6274 Call gtk_widget_get_preferred_size.
6275 (xg_frame_resized): gdk_window_get_geometry only takes 5
6276 parameters.
6277 (xg_win_to_widget, xg_event_is_for_menubar):
6278 Call gdk_x11_window_lookup_for_display.
6279 (xg_set_widget_bg): New function.
6280 (delete_cb): New function.
6281 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6282 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6283 (xg_set_background_color): Call xg_set_widget_bg.
6284 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6285 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6286 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6287 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6288 if ! HAVE_GTK3.
6289 (update_frame_tool_bar): Call gtk_widget_hide.
6290 (xg_initialize): Use GDK_KEY_g.
6291
6292 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6293 if ! HAVE_GTK3
6294 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6295
6296 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6297 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6298 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6299
6300 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6301
6302 * w32xfns.c (select_palette): Check success of RealizePalette against
6303 GDI_ERROR, not zero.
6304
6305 See ChangeLog.11 for earlier changes.
6306
6307 ;; Local Variables:
6308 ;; coding: utf-8
6309 ;; End:
6310
6311 Copyright (C) 2011 Free Software Foundation, Inc.
6312
6313 This file is part of GNU Emacs.
6314
6315 GNU Emacs is free software: you can redistribute it and/or modify
6316 it under the terms of the GNU General Public License as published by
6317 the Free Software Foundation, either version 3 of the License, or
6318 (at your option) any later version.
6319
6320 GNU Emacs is distributed in the hope that it will be useful,
6321 but WITHOUT ANY WARRANTY; without even the implied warranty of
6322 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6323 GNU General Public License for more details.
6324
6325 You should have received a copy of the GNU General Public License
6326 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.