1 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3 * image.c: Improve checking for integer overflow.
4 (check_image_size): Assume that f is nonnull, since
5 it is always nonnull in practice. This is one less thing to
6 worry about when checking for integer overflow later.
7 (x_check_image_size): New function, which checks for integer
8 overflow issues inside X.
9 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
10 This removes the need for a memory_full check.
11 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
12 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
13 (xbm_read_bitmap_data): Change locals back to 'int', since
14 their values must fit in 'int'.
15 (xpm_load_image, png_load, tiff_load):
16 Invoke x_create_x_image_and_pixmap earlier,
17 to avoid much needless work if the image is too large.
18 (tiff_load): Treat overly large images as if
19 x_create_x_image_and_pixmap failed, not as malloc failures.
20 (gs_load): Use x_check_image_size.
22 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
24 * gtkutil.c: Omit integer casts.
25 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
26 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
28 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
30 * bidi.c (bidi_dump_cached_states): Use pD to print ptrdiff_t.
32 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
33 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
34 would wrongly return t on a 64-bit host.
36 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
37 The plain *_OVERFLOW macros run afoul of GCC bug 49705
38 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
39 and therefore cause GCC to emit a bogus diagnostic in some cases.
41 * image.c: Integer signedness and overflow and related fixes.
42 This is not an exhaustive set of fixes, but it's time to
44 (lookup_pixel_color, check_image_size): Remove redundant decls.
45 (check_image_size): Don't assume that arbitrary EMACS_INT values
46 fit in 'int', or that arbitrary 'double' values fit in 'int'.
47 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
48 (tiff_load, imagemagick_load_image):
49 Check for overflow in size calculations.
50 (x_create_x_image_and_pixmap): Remove unnecessary test for
51 xmalloc returning NULL; that can't happen.
52 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
53 (xpm_color_bucket): Use better integer hashing function.
54 (xpm_cache_color): Don't possibly over-allocate memory.
55 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
57 Use ptrdiff_t, not int or size_t, to record sizes.
58 (png_load): Don't assume values greater than 2**31 fit in 'int'.
59 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
60 either works, as we prefer signed integers.
61 (tiff_read_from_memory, tiff_write_from_memory):
62 Return tsize_t, not size_t, since that's what the TIFF API wants.
63 (tiff_read_from_memory): Don't fail simply because the read would
64 go past EOF; instead, return a short read.
65 (tiff_load): Omit no-longer-needed casts.
66 (Fimagemagick_types): Don't assume size fits into 'int'.
68 Improve hashing quality when configured --with-wide-int.
69 * fns.c (hash_string): New function, taken from sxhash_string.
70 Do not discard information about ASCII character case; this
71 discarding is no longer needed.
72 (sxhash-string): Use it. Change sig to match it. Caller changed.
74 * lread.c (hash_string): Remove, since we now use fns.c's version.
75 The fns.c version returns a wider integer if --with-wide-int is
76 specified, so this should help the quality of the hashing a bit.
78 * emacs.c: Integer overflow minor fix.
79 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
80 Define only if GNU_LINUX.
81 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
83 * dispnew.c: Integer signedness and overflow fixes.
84 Remove unnecessary forward decls, that were a maintenance hassle.
85 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
87 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
88 (scrolling_window): Use ptrdiff_t, not int, for byte count.
89 (prepare_desired_row, line_draw_cost):
90 Use int, not unsigned, where either works.
91 (save_current_matrix, restore_current_matrix):
92 Use ptrdiff_t, not size_t, where either works.
93 (init_display): Check for overflow more accurately, and without
94 relying on undefined behavior.
96 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
97 Remove, replacing with the new symbols in lisp.h. All uses changed.
98 * fileio.c (make_temp_name):
99 * filelock.c (lock_file_1, lock_file):
100 * xdisp.c (message_dolog):
101 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
102 Use pMd etc. instead.
103 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
104 replacing the pWIDE etc. symbols removed from editfns.c.
106 * keyboard.h (num_input_events): Now uintmax_t.
107 This is (very slightly) less likely to mess up due to wraparound.
110 * buffer.c: Integer signedness fixes.
111 (alloc_buffer_text, enlarge_buffer_text):
112 Use ptrdiff_t rather than size_t when either will do, as we prefer
115 * bidi.c: Integer signedness and overflow fixes.
116 (bidi_cache_idx, bidi_cache_last_idx, bidi_cache_fetch_state)
117 (bidi_cache_search, bidi_cache_find_level_change)
118 (bidi_cache_iterator_state, bidi_cache_find)
119 (bidi_find_other_level_edge, bidi_dump_cached_states):
120 Don't arbitrarily limit cache indexes to int; use ptrdiff_t instead.
121 (bidi_cache_size): Use ptrdiff_t rather than size_t, as we prefer
123 (elsz): Make it a (signed) constant.
124 (bidi_cache_iterator_state): Check for size-calculation overflow.
126 * alloc.c: Integer signedness and overflow fixes.
127 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
128 (__malloc_size_t): Default to size_t, not to int.
129 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
130 (Fgarbage_collect, mark_object_loop_halt, mark_object):
131 Prefer ptrdiff_t to size_t when either would do, as we prefer
133 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
134 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
135 Now const. Initialize with values that are in range even if char
137 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
138 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
139 These functions do the right thing with sizes > 2**32.
140 (check_depth): Now ptrdiff_t, not int.
141 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
142 Adjust to new way of storing sizes. Check for size overflow bugs
144 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
145 slightly wrong anyway, as it missed one instance of
146 XMALLOC_OVERRUN_CHECK_OVERHEAD.
147 (refill_memory_reserve): Omit needless cast to size_t.
148 (mark_object_loop_halt): Mark as externally visible.
150 * xselect.c: Integer signedness and overflow fixes.
151 (Fx_register_dnd_atom, x_handle_dnd_message):
152 Use ptrdiff_t, not size_t, since we prefer signed.
153 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
154 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
155 x_dnd_atoms_size and x_dnd_atoms_length.
157 * doprnt.c: Prefer signed to unsigned when either works.
161 * xdisp.c (vmessage):
162 Use ptrdiff_t, not size_t, when using or implementing doprnt,
163 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
164 prefer signed arithmetic to avoid comparison confusion.
165 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
168 Assume freestanding C89 headers, string.h, stdlib.h.
169 * data.c, doprnt.c, floatfns.c, print.c:
170 Include float.h unconditionally.
171 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
172 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
173 * regex.c: Likewise for stddef.h, string.h.
174 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
175 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
176 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
177 (STDC_HEADERS): Remove obsolete defines.
178 * sysdep.c: Include limits.h unconditionally.
180 Assume support for memcmp, memcpy, memmove, memset.
181 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
182 * regex.c (memcmp, memcpy):
183 Remove; we assume C89 now.
185 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
186 (__malloc_safe_bcopy): Remove; no longer needed.
188 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
189 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
190 well either way, and we prefer signed to unsigned.
192 2011-07-13 Johan Bockgård <bojohan@gnu.org>
194 Fix execution of x selection hooks.
195 * xselect.c (Qx_lost_selection_functions)
196 (Qx_sent_selection_functions): New vars.
197 (syms_of_xselect): DEFSYM them.
198 (x_handle_selection_request): Pass Qx_sent_selection_functions
199 rather than Vx_sent_selection_functions to Frun_hook_with_args.
200 (x_handle_selection_clear,x_clear_frame_selections):
201 Pass Qx_lost_selection_functions rather than
202 Vx_lost_selection_functions to Frun_hook_with_args.
204 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
206 * buffer.c (Fget_buffer_create): Initialized inhibit_shrinking.
207 The old code sometimes used this field without initializing it.
209 * alloc.c (gc_sweep): Don't read past end of array.
210 In theory, the old code could also have corrupted Emacs internals,
211 though it'd be very unlikely.
213 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
215 * character.c (Fcharacterp): Don't advertise optional ignored
218 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
220 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
223 * window.c (Fset_window_start): Doc fix (bug#4199).
224 (Fset_window_hscroll): Ditto.
226 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
228 Fix minor new problems caught by GCC 4.6.1.
229 * term.c (init_tty): Remove unused local.
230 * xsettings.c (store_monospaced_changed): Define this function only
231 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
234 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
236 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
238 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
240 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
241 are the mini-buffer and the echo area (bug#3320).
243 * term.c (init_tty): Remove support for supdup, c10 and perq
244 terminals, which are no longer supported (bug#1482).
246 2011-07-10 Johan Bockgård <bojohan@gnu.org>
248 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
250 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
252 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
253 for non-popups (Bug#3642).
255 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
257 * alloc.c (reset_malloc_hooks): Protoize.
258 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
259 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
260 * cm.c (losecursor): Likewise.
261 * data.c (fmod): Likewise.
262 * dispnew.c (swap_glyphs_in_rows): Likewise.
263 * emacs.c (memory_warning_signal): Likewise.
264 * floatfns.c (float_error): Likewise.
265 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
266 (otf_open, font_otf_capability, generate_otf_features)
267 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
269 * image.c (pbm_read_file): Likewise.
270 * indent.c (string_display_width): Likewise.
271 * intervals.c (check_for_interval, search_for_interval)
272 (inc_interval_count, count_intervals, root_interval)
273 (adjust_intervals_for_insertion, make_new_interval): Likewise.
274 * lread.c (defalias): Likewise.
275 * ralloc.c (r_alloc_check): Likewise.
276 * regex.c (set_image_of_range_1, set_image_of_range)
277 (regex_grow_registers): Likewise.
278 * sysdep.c (strerror): Likewise.
279 * termcap.c (valid_filename_p, tprint, main): Likewise.
280 * tparam.c (main): Likewise.
281 * unexhp9k800.c (run_time_remap, save_data_space)
282 (update_file_ptrs, read_header, write_header, calculate_checksum)
283 (copy_file, copy_rest, display_header): Likewise.
284 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
286 * xdisp.c (check_it): Likewise.
287 * xfaces.c (register_color, unregister_color, unregister_colors):
289 * xfns.c (print_fontset_result): Likewise.
290 * xrdb.c (member, fatal, main): Likewise.
292 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
294 Fix minor problems found by static checking (Bug#9031).
295 * chartab.c (char_table_set_range, map_sub_char_table):
296 Remove unused locals.
297 (uniprop_table): Now static.
298 * composite.c (_work_char): Remove unused static var.
300 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
302 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
304 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
306 * gtkutil.c (qttip_cb): Remove code without function.
308 2011-07-09 Eli Zaretskii <eliz@gnu.org>
310 * w32.c (pthread_sigmask): New stub.
312 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
314 Use pthread_sigmask, not sigprocmask (Bug#9010).
315 sigprocmask is portable only for single-threaded applications, and
316 Emacs can be multi-threaded when it uses GTK.
317 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
319 * callproc.c (Fcall_process):
320 * process.c (create_process):
321 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
322 Use pthread_sigmask, not sigprocmask.
324 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
326 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
327 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
330 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
332 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
333 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
334 (xg_hide_tooltip): Fix comment.
336 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
337 in registerServicesMenuSendTypes.
338 (validRequestorForSendType): Don't check ns_return_types.
340 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
343 2011-07-08 Jason Rumney <jasonr@gnu.org>
345 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
346 frame struct members of non-existent frames (Bug#6284).
348 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
350 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
351 variable firstTime not needed on OSX >= 10.6.
352 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
353 >= 10.5. Use setKnobProportion, setDoubleValue.
355 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
356 (MAC_OS_X_VERSION_10_5): Define if not defined.
357 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
358 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
359 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
361 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
362 cString and lossyCString on OSX >= 10.4
364 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
365 sizeToFit on OSX >= 10.2.
367 * nsimage.m (allocInitFromFile): Don't use deprecated method
368 bestRepresentationForDevice on OSX >= 10.6.
370 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
373 * emacs.c: Declare unexec_init_emacs_zone.
375 * nsgui.h: Fix compiler warning about gnulib redefining verify.
377 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
379 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
380 on svcsMenu (Bug#8842).
382 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
384 (Fns_list_services): Just return Qnil on 10.6, code not working there.
386 * nsterm.m (QUTF8_STRING): Declare.
387 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
388 (validRequestorForSendType): Return type is (id).
389 Change indexOfObjectIdenticalTo to indexOfObject.
390 Check if we have local selection before returning self (Bug#8842).
391 (writeSelectionToPasteboard): Put local selection into paste board
392 if we have a local selection (Bug#8842).
393 (syms_of_nsterm): DEFSYM QUTF8_STRING.
395 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
396 (ns_get_local_selection): Declare.
398 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
400 * keymap.c (describe_map_tree): Don't insert a double newline at
401 the end of the buffer (bug#1169) and return whether we inserted
404 * callint.c (Fcall_interactively): Change "reading args" to
405 "providing args" to try to clarify what it does (bug#1010).
407 2011-07-07 Kenichi Handa <handa@m17n.org>
409 * composite.c (composition_compute_stop_pos): Ignore a static
410 composition starting before CHARPOS (Bug#8915).
412 * xdisp.c (handle_composition_prop): Likewise.
414 2011-07-07 Eli Zaretskii <eliz@gnu.org>
416 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
419 2011-07-07 Kenichi Handa <handa@m17n.org>
421 * character.h (unicode_category_t): New enum type.
423 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
424 (Qchar_code_property_table): New variable.
425 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
426 (UNIPROP_COMPRESSED_FORM_P): New macros.
427 (char_table_ascii): Uncompress the compressed values.
428 (sub_char_table_ref): New arg is_uniprop. Callers changed.
429 Uncompress the compressed values.
430 (sub_char_table_ref_and_range): Likewise.
431 (char_table_ref_and_range): Uncompress the compressed values.
432 (sub_char_table_set): New arg is_uniprop. Callers changed.
433 Uncompress the compressed values.
434 (sub_char_table_set_range): Args changed. Callers changed.
435 (char_table_set_range): Adjuted for the above change.
436 (map_sub_char_table): Delete args default_val and parent. Add arg
437 top. Give decoded values to a Lisp function.
438 (map_char_table): Adjusted for the above change. Give decoded
439 values to a Lisp function. Gcpro more variables.
440 (uniprop_table_uncompress)
441 (uniprop_decode_value_run_length): New functions.
442 (uniprop_decoder, uniprop_decoder_count): New variables.
443 (uniprop_get_decoder, uniprop_encode_value_character)
444 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
446 (uniprop_encoder, uniprop_encoder_count): New variables.
447 (uniprop_get_encoder, uniprop_table)
448 (Funicode_property_table_internal, Fget_unicode_property_internal)
449 (Fput_unicode_property_internal): New functions.
450 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
451 Sunicode_property_table_internal, Sget_unicode_property_internal,
452 and Sput_unicode_property_internal. Defvar_lisp
453 char-code-property-alist.
455 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
456 Vunicode_category_table.
458 * font.c (font_range): Adjusted for the change of
459 Vunicode_category_table.
461 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
463 * m/iris4d.h: Remove file, move contents ...
464 * s/irix6-5.h: ... here.
466 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
468 Remove unportable assumption about struct layout (Bug#8884).
469 * alloc.c (mark_buffer):
470 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
471 (clone_per_buffer_values): Don't assume that
472 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
473 This isn't true in general, and it's particularly not true
474 if Emacs is configured with --with-wide-int.
475 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
476 New macros, used in the buffer.c change.
478 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
480 * xsettings.c: Use both GConf and GSettings if both are available.
481 (store_config_changed_event): Add comment.
482 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
483 (store_tool_bar_style_changed): New functions.
484 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
485 (struct xsettings): Move font inside HAVE_XFT.
486 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
487 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
488 Move inside HAVE_XFT.
489 (something_changed_gsettingsCB): Renamed from something_changedCB.
490 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
492 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
493 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
494 (something_changed_gconfCB): Renamed from something_changedCB.
495 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
496 (parse_settings): Move check for font inside HAVE_XFT.
497 (read_settings, apply_xft_settings): Add comment.
498 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
499 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
500 call store_font_name_changed.
501 (xft_settings_event): Add comment.
502 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
503 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
504 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
505 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
506 (xsettings_initialize): Call init_gsettings last.
507 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
510 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
512 Random fixes. E.g., (random) never returned negative values.
513 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
514 subseconds part to the entropy, as that's a bit more random.
515 Prefer signed to unsigned, since the signedness doesn't matter and
516 in general we prefer signed. When given a limit, use a
517 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
518 latter isn't right if USE_2_TAGS_FOR_INTS.
519 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
520 not 0..VALMASK. Don't discard "excess" bits that random () returns.
522 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
524 * textprop.c (text_property_stickiness):
525 Obey Vtext_property_default_nonsticky.
526 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
527 * w32fns.c (syms_of_w32fns):
528 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
530 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
532 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
533 This is more efficient than Ffile_directory_p and avoids a minor race.
535 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
537 * buffer.c (Foverlay_put): Say what the return value is
540 * fileio.c (barf_or_query_if_file_exists): Check first if the file
541 is a directory before asking whether to use the file name
543 (barf_or_query_if_file_exists): Make the "File is a directory"
544 error be more correct.
546 * fns.c (Frequire): Remove the mention of the .gz files, since
547 that's installation-specific, but keep the mention of
550 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
552 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
553 Report string overflow if the output is too long.
555 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
557 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
558 (syms_of_gnutls): Remove duplicate DEFSYM for
559 Qgnutls_bootprop_verify_hostname_error, an error for
560 Qgnutls_bootprop_verify_error (which is no longer used).
562 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
563 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
564 Also (re)move comments that are misplaced or no longer relevant.
566 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
568 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
570 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
572 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
573 and background color parameters if they have been changed.
575 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
577 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
579 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
581 * xsettings.c (SYSTEM_FONT): Define only when used.
582 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
584 * keymap.c (access_keymap_1): Now static.
586 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
588 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
589 leave any prefix arg for the up event (Bug#1586).
591 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
593 * lread.c (syms_of_lread): Mention single symbols defined by
594 `defvar' or `defconst' (bug#7154).
596 * fns.c (Frequire): Mention .el.gz files (bug#7314).
597 (Frequire): Mention get-load-suffixes.
599 2011-07-02 Martin Rudalics <rudalics@gmx.at>
601 * window.h (window): Remove clone_number slot.
602 * window.c (Fwindow_clone_number, Fset_window_clone_number):
604 (make_parent_window, make_window, saved_window)
605 (Fset_window_configuration, save_window_save): Don't deal with
607 * buffer.c (Qclone_number): Remove declaration.
608 (sort_overlays, overlay_strings): Don't deal with clone numbers.
610 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
612 Add multiple inheritance to keymaps.
613 * keymap.c (Fmake_composed_keymap): New function.
614 (Fset_keymap_parent): Simplify.
615 (fix_submap_inheritance): Remove.
616 (access_keymap_1): New function extracted from access_keymap to handle
617 embedded parents and handle lists of maps.
618 (access_keymap): Use it.
619 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
620 (Fcopy_keymap): Handle embedded parents.
621 (Fcommand_remapping, define_as_prefix): Simplify.
622 (Fkey_binding): Simplify.
623 (syms_of_keymap): Move minibuffer-local-completion-map,
624 minibuffer-local-filename-completion-map,
625 minibuffer-local-must-match-map, and
626 minibuffer-local-filename-must-match-map to Elisp.
627 (syms_of_keymap): Defsubr make-composed-keymap.
628 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
629 (parse_menu_item): Trivial simplification.
631 2011-07-01 Glenn Morris <rgm@gnu.org>
633 * Makefile.in (SETTINGS_LIBS): Fix typo.
635 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
637 * coding.c (Fencode_coding_string): Record the last coding system
638 used, as the function doc string says (bug#8738).
640 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
642 * xsettings.c (store_monospaced_changed): Take new font as arg and
643 check for change against current_mono_font.
644 (EMACS_TYPE_SETTINGS): Remove this and related defines.
645 (emacs_settings_constructor, emacs_settings_get_property)
646 (emacs_settings_set_property, emacs_settings_class_init)
647 (emacs_settings_init, gsettings_obj): Remove.
648 (something_changedCB): New function for HAVE_GSETTINGS.
649 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
650 with value as argument.
651 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
652 g_settings_new (Bug#8967). Do not create gsettings_obj.
653 Remove calls to g_settings_bind. Connect something_changedCB to
656 * xgselect.c: Add defined (HAVE_GSETTINGS).
657 (xgselect_initialize): Ditto.
659 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
660 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
663 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
665 * eval.c (struct backtrace): Simplify and port the data structure.
666 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
667 signed bit field, as this assumption is not portable and it makes
668 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
669 "char debug_on_exit : 1" as this is not portable either; instead,
670 use the portable "unsigned int debug_on_exit : 1". Remove unused
671 member evalargs. Remove obsolete comments about cc bombing out.
673 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
675 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
676 Let HAVE_GSETTINGS override HAVE_GCONF.
677 (store_monospaced_changed): New function.
678 (EMACS_SETTINGS): A new type derived from GObject to handle
679 GSettings notifications.
680 (emacs_settings_constructor, emacs_settings_get_property)
681 (emacs_settings_set_property, emacs_settings_class_init):
683 (gsettings_client, gsettings_obj): New variables.
684 (GSETTINGS_SCHEMA): New define.
685 (something_changedCB): Call store_monospaced_changed.
686 (init_gsettings): New function.
687 (xsettings_initialize): Call init_gsettings.
688 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
691 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
694 2011-06-29 Martin Rudalics <rudalics@gmx.at>
696 * window.c (resize_root_window, grow_mini_window)
697 (shrink_mini_window): Rename Qresize_root_window to
698 Qwindow_resize_root_window and Qresize_root_window_vertically to
699 Qwindow_resize_root_window_vertically.
701 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
703 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
705 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
707 * makefile.w32-in: Redesign dependencies so they reflect more
708 clearly which files are directly included by each source file,
709 and not through other includes.
711 2011-06-27 Martin Rudalics <rudalics@gmx.at>
713 * buffer.c (Qclone_number): Declare static and DEFSYM it.
714 (sort_overlays, overlay_strings): When an overlay's clone number
715 matches the window's clone number process the overlay even if
716 the overlay's window property doesn't match the current window.
718 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
719 (Fwindow_hchild): Rename to Fwindow_left_child.
720 (Fwindow_next): Rename to Fwindow_next_sibling.
721 (Fwindow_prev): Rename to Fwindow_prev_sibling.
722 (resize_window_check): Rename to window_resize_check.
723 (resize_window_apply): Rename to window_resize_apply.
724 (Fresize_window_apply): Rename to Fwindow_resize_apply.
725 (Fdelete_other_windows_internal, resize_frame_windows)
726 (Fsplit_window_internal, Fdelete_window_internal)
727 (grow_mini_window, shrink_mini_window)
728 (Fresize_mini_window_internal): Fix callers accordingly.
730 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
732 * emacsgtkfixed.h: State that this is only used with Gtk+3.
733 (emacs_fixed_set_min_size): Remove.
734 (emacs_fixed_new): Take frame as argument.
736 * emacsgtkfixed.c: State that this is only used with Gtk+3.
737 (_EmacsFixedPrivate): Remove minwidth/height.
739 (emacs_fixed_init): Initialize priv->f.
740 (get_parent_class, emacs_fixed_set_min_size): Remove.
741 (emacs_fixed_new): Set priv->f to argument.
742 (emacs_fixed_get_preferred_width)
743 (emacs_fixed_get_preferred_height): Use min_width/height from
744 frames size_hint to set minimum and natural (Bug#8919).
745 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
746 and use min_width/height from frames size_hint to set
747 min_width/height (Bug#8919).
749 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
750 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
753 2011-06-26 Eli Zaretskii <eliz@gnu.org>
755 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
756 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
759 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
761 * process.c (wait_reading_process_output): Bypass select if
762 waiting for a cell while ignoring keyboard input, and input is
763 pending. Suggested by Jan Djärv (Bug#8869).
765 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
767 Use gnulib's dup2 module instead of rolling our own.
768 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
770 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
772 * dispnew.c (scrolling_window): Before scrolling, turn off a
773 mouse-highlight in the window being scrolled.
775 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
777 Move DEFSYM to lisp.h and use everywhere.
779 * character.h (DEFSYM): Move declaration...
780 * lisp.h (DEFSYM): ...here.
786 * w32select.c: Don't include character.h.
788 * alloc.c (syms_of_alloc):
789 * buffer.c (syms_of_buffer):
790 * bytecode.c (syms_of_bytecode):
791 * callint.c (syms_of_callint):
792 * casefiddle.c (syms_of_casefiddle):
793 * casetab.c (init_casetab_once):
794 * category.c (init_category_once, syms_of_category):
795 * ccl.c (syms_of_ccl):
796 * cmds.c (syms_of_cmds):
797 * composite.c (syms_of_composite):
798 * dbusbind.c (syms_of_dbusbind):
799 * dired.c (syms_of_dired):
800 * dispnew.c (syms_of_display):
801 * doc.c (syms_of_doc):
802 * editfns.c (syms_of_editfns):
803 * emacs.c (syms_of_emacs):
804 * eval.c (syms_of_eval):
805 * fileio.c (syms_of_fileio):
806 * fns.c (syms_of_fns):
807 * frame.c (syms_of_frame):
808 * fringe.c (syms_of_fringe):
809 * insdel.c (syms_of_insdel):
810 * keymap.c (syms_of_keymap):
811 * lread.c (init_obarray, syms_of_lread):
812 * macros.c (syms_of_macros):
813 * msdos.c (syms_of_msdos):
814 * print.c (syms_of_print):
815 * process.c (syms_of_process):
816 * search.c (syms_of_search):
817 * sound.c (syms_of_sound):
818 * syntax.c (init_syntax_once, syms_of_syntax):
819 * terminal.c (syms_of_terminal):
820 * textprop.c (syms_of_textprop):
821 * undo.c (syms_of_undo):
822 * w32.c (globals_of_w32):
823 * window.c (syms_of_window):
824 * xdisp.c (syms_of_xdisp):
825 * xfaces.c (syms_of_xfaces):
826 * xfns.c (syms_of_xfns):
827 * xmenu.c (syms_of_xmenu):
828 * xsettings.c (syms_of_xsettings):
829 * xterm.c (syms_of_xterm): Use DEFSYM.
831 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
833 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
835 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
837 Integer and buffer overflow fixes (Bug#8873).
839 * print.c (printchar, strout): Check for string overflow.
840 (PRINTPREPARE, printchar, strout):
841 Don't set size unless allocation succeeds.
843 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
844 for sizes. Check for string overflow more accurately.
845 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
847 * macros.c: Integer and buffer overflow fixes.
848 * keyboard.h (struct keyboard.kbd_macro_bufsize):
849 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
850 Use ptrdiff_t, not int, for sizes.
851 Don't increment bufsize until after realloc succeeds.
852 Check for size-calculation overflow.
853 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
855 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
857 * lread.c: Integer overflow fixes.
858 (read_integer): Radix is now EMACS_INT, not int,
859 to improve quality of diagnostics for out-of-range radices.
860 Calculate buffer size correctly for out-of-range radices.
861 (read1): Check for integer overflow in radices, and in
863 (read_escape): Avoid int overflow.
864 (Fload, openp, read_buffer_size, read1)
865 (substitute_object_recurse, read_vector, read_list, map_obarray):
866 Use ptrdiff_t, not int, for sizes.
867 (read1): Use EMACS_INT, not int, for sizes.
868 Check for size overflow.
870 * image.c (cache_image): Check for size arithmetic overflow.
872 * lread.c: Integer overflow issues.
873 (saved_doc_string_size, saved_doc_string_length)
874 (prev_saved_doc_string_size, prev_saved_doc_string_length):
875 Now ptrdiff_t, not int.
876 (read1): Don't assume doc string length fits in int. Check for
877 out-of-range doc string lengths.
878 (read_list): Don't assume file position fits in int.
879 (read_escape): Check for hex character overflow.
881 2011-06-22 Leo Liu <sdl.web@gmail.com>
883 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
884 Move to minibuffer.el.
886 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
888 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
889 The following patches are for when GLYPH_DEBUG && !XASSERT.
890 * dispextern.h (trace_redisplay_p, dump_glyph_string):
891 * dispnew.c (flush_stdout):
892 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
893 Mark as externally visible.
894 * dispnew.c (check_window_matrix_pointers): Now static.
895 * dispnew.c (window_to_frame_vpos):
896 * xfns.c (unwind_create_frame):
897 * xterm.c (x_check_font): Remove unused local.
898 * scroll.c (CHECK_BOUNDS):
899 * xfaces.c (cache_fache): Rename local to avoid shadowing.
900 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
901 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
902 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
903 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
905 (debug_method_add): Use va_list and vsprintf rather than relying
906 on undefined behavior with wrong number of arguments.
907 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
908 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
909 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
910 since we're not interested in debugging glyphs with old libraries.
911 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
912 GCC 4.6.0's static checking.
914 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
916 Integer overflow and signedness fixes (Bug#8873).
917 A few related buffer overrun fixes, too.
919 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
921 * dispextern.h (struct face.stipple):
922 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
923 (x_bitmap_mask, x_allocate_bitmap_record)
924 (x_create_bitmap_from_data, x_create_bitmap_from_file)
925 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
926 (x_create_bitmap_from_xpm_data):
927 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
928 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
930 * xfaces.c (load_pixmap):
931 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
932 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
933 (.bitmaps_last, struct x_output.icon_bitmap):
934 Use ptrdiff_t, not int, for bitmap indexes.
935 (x_allocate_bitmap_record): Check for size overflow.
936 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
938 Use ptrdiff_t, not int, for overlay counts.
939 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
940 * editfns.c (overlays_around, get_pos_property):
941 * textprop.c (get_char_property_and_overlay):
942 * xdisp.c (next_overlay_change, note_mouse_highlight):
943 * xfaces.c (face_at_buffer_position):
944 * buffer.c (OVERLAY_COUNT_MAX): New macro.
945 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
946 (Fnext_overlay_change, Fprevious_overlay_change)
947 (mouse_face_overlay_overlaps, Foverlays_in):
948 Use ptrdiff_t, not int, for sizes.
949 (overlays_at, overlays_in): Check for size-calculation overflow.
951 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
953 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
954 (x_session_initialize): Do not assume string length fits in int.
956 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
957 This is unlikely, but can occur if DPI is outlandish.
959 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
960 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
962 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
963 * xrdb.c (magic_file_p, search_magic_path):
964 Omit last arg SUFFIX; it was always 0. All callers changed.
965 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
967 * xfont.c (xfont_match): Avoid need for strlen.
969 * xfns.c: Don't assume strlen fits in int.
970 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
972 * xdisp.c (message_log_check_duplicate): Return intmax_t,
973 not unsigned long, as we prefer signed integers. All callers changed.
974 Detect integer overflow in repeat count.
975 (message_dolog): Don't assume print length fits in 39 bytes.
976 (display_mode_element): Don't assume strlen fits in int.
978 * termcap.c: Don't assume sizes fit in int and never overflow.
979 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
980 (gobble_line): Check for size-calculation overflow.
982 * minibuf.c (Fread_buffer):
983 * lread.c (intern, intern_c_string):
984 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
985 Don't assume string length fits in int.
987 * keyboard.c (parse_tool_bar_item):
988 * gtkutil.c (style_changed_cb): Avoid need for strlen.
990 * font.c: Don't assume string length fits in int.
991 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
992 Use ptrdiff_t, not int.
993 (font_intern_prop): Don't assume string length fits in int.
994 Don't assume integer property fits in fixnum.
995 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
997 * filelock.c: Fix some buffer overrun and integer overflow issues.
998 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
999 Reformulate so as not to need the command string.
1000 Invoke gzip -cd rather than gunzip, as it's more portable.
1001 (lock_info_type, lock_file_1, lock_file):
1002 Don't assume pid_t and time_t fit in unsigned long.
1003 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1004 (current_lock_owner): Prefer signed type for sizes.
1005 Use memcpy, not strncpy, where memcpy is what is really wanted.
1006 Don't assume (via atoi) that time_t and pid_t fit in int.
1007 Check for time_t and/or pid_t out of range, e.g., via a network share.
1008 Don't alloca where an auto var works fine.
1010 * fileio.c: Fix some integer overflow issues.
1011 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1012 Don't assume string length fits in int.
1013 (directory_file_name): Don't assume string length fits in long.
1014 (make_temp_name): Don't assume pid fits in int, or that its print
1015 length is less than 20.
1017 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1019 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1021 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1023 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1024 We prefer signed integers, even for size calculations.
1026 * emacs.c: Don't assume string length fits in 'int'.
1027 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1028 (main): Don't invoke strlen when not needed.
1030 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1031 (XD_DEBUG_MESSAGE): Don't waste a byte.
1033 * callproc.c (getenv_internal_1, getenv_internal)
1035 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1037 * lread.c (invalid_syntax): Omit length argument.
1038 All uses changed. This doesn't fix a bug, but it simplifies the
1039 code away from its former Hollerith-constant appearance, and it's
1040 one less 'int' to worry about when looking at integer-overflow issues.
1041 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1043 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1044 This didn't break anything, but it didn't help either.
1045 It's confusing to put a bogus integer in a place where the actual
1046 value does not matter.
1047 (LIST_END_P): Remove unused macro and its bogus comment.
1048 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1050 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1051 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1053 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1054 We prefer signed types, and the value cannot exceed the EMACS_INT
1055 range anyway (because otherwise the length would not be representable).
1056 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1057 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1058 This avoids a GCC warning when WIDE_EMACS_INT.
1060 * indent.c (sane_tab_width): New function.
1061 (current_column, scan_for_column, Findent_to, position_indentation)
1062 (compute_motion): Use it. This is just for clarity.
1063 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1065 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1067 * lisp.h (lint_assume): New macro.
1068 * composite.c (composition_gstring_put_cache):
1069 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1071 * editfns.c, insdel.c:
1072 Omit unnecessary forward decls, to simplify future changes.
1074 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1076 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1078 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1079 Use much-faster test for byte-length change.
1080 Don't assume string byte-length fits in 'int'.
1081 Check that character arg fits in 'int'.
1082 (mapcar1): Declare byte as byte, for clarity.
1084 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1086 * fns.c (concat): Catch string overflow earlier.
1087 Do not rely on integer wraparound.
1089 * dispextern.h (struct it.overlay_strings_charpos)
1090 (struct it.selective): Now EMACS_INT, not int.
1091 * xdisp.c (forward_to_next_line_start)
1092 (back_to_previous_visible_line_start)
1093 (reseat_at_next_visible_line_start, next_element_from_buffer):
1094 Don't arbitrarily truncate the value of 'selective' to int.
1096 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1098 * composite.c: Don't truncate sizes to 'int'.
1099 (composition_gstring_p, composition_reseat_it)
1100 (composition_adjust_point): Use EMACS_INT, not int.
1101 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1102 not EMACS_UINT, for indexes.
1104 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1106 * buffer.c: Include <verify.h>.
1107 (struct sortvec.priority, struct sortstr.priority):
1108 Now EMACS_INT, not int.
1109 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1110 (struct sortstr.size, record_overlay_string)
1111 (struct sortstrlist.size, struct sortlist.used):
1112 Don't truncate size to int.
1113 (record_overlay_string): Check for size-calculation overflow.
1114 (init_buffer_once): Check at compile-time, not run-time.
1116 2011-06-22 Jim Meyering <meyering@redhat.com>
1118 Don't leak an XBM-image-sized buffer
1119 * image.c (xbm_load): Free the image buffer after using it.
1121 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1124 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1125 that Sun C diagnosed.
1126 * fns.c (secure_hash): Fix pointer signedness issue.
1127 * intervals.c (static_offset_intervals): New function.
1128 (offset_intervals): Use it.
1130 2011-06-21 Leo Liu <sdl.web@gmail.com>
1133 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1136 * fns.c (secure_hash): Rename from crypto_hash_function and change
1137 the first arg to accept symbols.
1138 (Fsecure_hash): New primitive.
1139 (syms_of_fns): New symbols.
1141 2011-06-20 Deniz Dogan <deniz@dogan.se>
1143 * process.c (Fset_process_buffer): Clarify return value in
1146 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1148 * dispnew.c (add_window_display_history): Use BVAR.
1150 * xdisp.c (debug_method_add): Use BVAR.
1151 (check_window_end, dump_glyph_matrix, dump_glyph)
1152 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1154 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1157 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1158 check till after the cache is created in init_frame_faces.
1160 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1162 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1164 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1166 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1167 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1168 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1170 Improve buffer-overflow checking (Bug#8873).
1171 * fileio.c (Finsert_file_contents):
1172 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1173 Remove the old (too-loose) buffer overflow checks.
1174 They weren't needed, since make_gap checks for buffer overflow.
1175 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1176 The old code merely checked for Emacs fixnum overflow, and relied
1177 on undefined (wraparound) behavior. The new code avoids undefined
1178 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1180 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1181 Tune. Don't use wider integers than needed. Don't use alloca.
1182 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1184 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1186 * insdel.c, lisp.h (buffer_overflow): New function.
1187 (insert_from_buffer_1, replace_range, replace_range_2):
1188 * insdel.c (make_gap_larger):
1189 * editfns.c (Finsert_char):
1190 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1192 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1194 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1196 Integer overflow and signedness fixes (Bug#8873).
1198 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1199 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1201 * fileio.c: Don't assume EMACS_INT fits in off_t.
1202 (emacs_lseek): New static function.
1203 (Finsert_file_contents, Fwrite_region): Use it.
1204 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1206 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1208 * fns.c: Don't overflow int when computing a list length.
1209 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1210 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1211 truncation on 64-bit hosts. Check for QUIT every
1212 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1213 faster and is responsive enough.
1214 (Flength): Report an error instead of overflowing an integer.
1215 (Fsafe_length): Return a float if the value is not representable
1216 as a fixnum. This shouldn't happen except in contrived situations.
1217 (Fnthcdr, Fsort): Don't assume list length fits in int.
1218 (Fcopy_sequence): Don't assume vector length fits in int.
1220 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1221 (header_size, word_size): New constants.
1222 (allocate_vectorlike): Don't check size overflow here.
1223 (allocate_vector): Check it here instead, since this is the only
1224 caller of allocate_vectorlike that could cause overflow.
1225 Check that the new vector's length is representable as a fixnum.
1227 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1228 The previous code was bogus. For example, next_almost_prime (32)
1229 returned 39, which is undesirable as it is a multiple of 3; and
1230 next_almost_prime (24) returned 25, which is a multiple of 5 so
1231 why was the code bothering to check for multiples of 7?
1233 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1235 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1237 Variadic C functions now count arguments with ptrdiff_t.
1238 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1239 Back then I didn't know that the Emacs coding style prefers signed int.
1240 Also, in the meantime I found a few more instances where arguments
1241 were being counted with int, which may truncate counts on 64-bit
1242 machines, or EMACS_INT, which may be unnecessarily wide.
1243 * lisp.h (struct Lisp_Subr.function.aMANY)
1244 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1245 Arg counts are now ptrdiff_t, not size_t.
1246 All variadic functions and their callers changed accordingly.
1247 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1248 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1249 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1250 * callint.c (Fcall_interactively): Check arg count for overflow,
1251 to avoid potential buffer overrun. Use signed char, not 'int',
1252 for 'varies' array, so that we needn't bother to check its size
1253 calculation for overflow.
1254 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1255 * eval.c (apply_lambda):
1256 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1257 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1258 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1260 * callint.c (Fcall_interactively): Don't use index var as event count.
1262 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1263 * mem-limits.h (SIZE): Remove; no longer used.
1265 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1267 Remove unnecessary casts.
1268 * xterm.c (x_term_init):
1269 * xfns.c (x_set_border_pixel):
1270 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1271 These aren't needed now that we assume ANSI C.
1273 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1274 It's more likely to cause problems (due to unsigned overflow)
1277 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1279 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1281 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1283 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1285 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1287 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1289 GLYPH_CODE_FACE returns EMACS_INT, not int.
1290 * dispextern.h (merge_faces):
1291 * xfaces.c (merge_faces):
1292 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1293 Don't assume EMACS_INT fits in int.
1295 * character.h (CHAR_VALID_P): Remove unused parameter.
1296 * fontset.c, lisp.h, xdisp.c: All uses changed.
1298 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1300 * fns.c (concat): Minor tuning based on overflow analysis.
1301 This doesn't fix any bugs. Use int to hold character, instead
1302 of constantly refetching from Emacs object. Use XFASTINT, not
1303 XINT, for value known to be a character. Don't bother comparing
1304 a single byte to 0400, as it's always less.
1306 * floatfns.c (Fexpt):
1307 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1309 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1312 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1314 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1315 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1316 incorrectly succeed when S was a string, because 4294967386 was
1317 truncated before it was used.
1319 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1320 Otherwise, an out-of-range integer could cause undefined behavior
1323 * composite.c: Use int, not EMACS_INT, for characters.
1324 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1325 EMACS_INT, for values that are known to be in character range.
1326 This doesn't fix any bugs but is the usual style inside Emacs and
1327 may generate better code on 32-bit machines.
1329 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1330 This is for reasons similar to the recent CHAR_STRING fix.
1331 * charset.c (Fencode_char): Check that character arg is actually
1332 a character. Pass an int to ENCODE_CHAR.
1333 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1334 wider than 'int', as a compile-time check to prevent future regressions
1337 * character.c (char_string): Remove unnecessary casts.
1339 Make sure a 64-bit char is never passed to CHAR_STRING.
1340 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1341 by silently ignoring the top 32 bits, allowing some values
1342 that were far too large to be valid characters.
1343 * character.h: Include <verify.h>.
1344 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1345 arguments are no wider than unsigned, as a compile-time check
1346 to prevent future regressions in this area.
1348 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1349 (Fsubst_char_in_region):
1351 * xdisp.c (decode_mode_spec_coding):
1352 Adjust to CHAR_STRING's new requirement.
1353 * editfns.c (Finsert_char, Fsubst_char_in_region):
1354 * fns.c (concat): Check that character args are actually
1355 characters. Without this test, these functions did the wrong
1356 thing with wildly out-of-range values on 64-bit hosts.
1358 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1359 These casts should not be needed on 32-bit hosts, either.
1360 * keyboard.c (read_char):
1361 * lread.c (Fload): Remove casts to unsigned.
1363 * lisp.h (UNSIGNED_CMP): New macro.
1364 This fixes comparison bugs on 64-bit hosts.
1365 (ASCII_CHAR_P): Use it.
1366 * casefiddle.c (casify_object):
1367 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1368 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1369 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1370 * dispextern.h (FACE_FROM_ID):
1371 * keyboard.c (read_char): Use UNSIGNED_CMP.
1373 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1374 not to EMACS_INT, to avoid GCC warning.
1376 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1378 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1379 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1380 isn't needed on 32-bit machines.
1382 * buffer.c (Fgenerate_new_buffer_name):
1383 Use EMACS_INT for count, not int.
1384 (advance_to_char_boundary): Return EMACS_INT, not int.
1386 * data.c (Qcompiled_function): Now static.
1388 * window.c (window_body_lines): Now static.
1390 * image.c (gif_load): Rename local to avoid shadowing.
1392 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1393 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1394 * alloc.c (make_save_value): Integer argument is now of type
1396 (mark_object): Use ptrdiff_t, not int.
1397 * lisp.h (pD): New macro.
1398 * print.c (print_object): Use it.
1400 * alloc.c: Use EMACS_INT, not int, to count objects.
1401 (total_conses, total_markers, total_symbols, total_vector_size)
1402 (total_free_conses, total_free_markers, total_free_symbols)
1403 (total_free_floats, total_floats, total_free_intervals)
1404 (total_intervals, total_strings, total_free_strings):
1405 Now EMACS_INT, not int. All uses changed.
1406 (Fgarbage_collect): Compute overall total using a double, so that
1407 integer overflow is less likely to be a problem. Check for overflow
1408 when converting back to an integer.
1409 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1410 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1411 These were 'int' variables that could overflow on 64-bit hosts;
1412 they were never used, so remove them instead of repairing them.
1413 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1414 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1415 Previously, this ceilinged at INT_MAX, but that doesn't work on
1417 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1419 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1420 (allocate_vectorlike): Check for ptrdiff_t overflow.
1421 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1422 when a (possibly-narrower) signed value would do just as well.
1423 We prefer using signed arithmetic, to avoid comparison confusion.
1425 * alloc.c: Catch some string size overflows that we were missing.
1426 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1427 for convenience in STRING_BYTES_MAX.
1428 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1429 The definition here is exact; the one in lisp.h was approximate.
1430 (allocate_string_data): Check for string overflow. This catches
1431 some instances we weren't catching before. Also, it catches
1432 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1433 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1434 and ptrdiff_t and EMACS_INT are both 64 bits.
1436 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1437 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1438 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1440 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1442 * alloc.c (Fmake_string): Check for out-of-range init.
1444 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1446 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1448 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1450 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1451 xg_get_default_scrollbar_width.
1453 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1454 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1455 (style_changed_cb): Call update_theme_scrollbar_width and call
1456 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1457 all frames (Bug#8505).
1458 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1459 Call gtk_window_set_resizable if HAVE_GTK3.
1460 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1461 and height if HAVE_GTK3 (Bug#8505).
1462 (scroll_bar_width_for_theme): New variable.
1463 (update_theme_scrollbar_width): New function.
1464 (xg_get_default_scrollbar_width): Move code to
1465 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1466 (xg_initialize): Call update_theme_scrollbar_width.
1468 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1470 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1472 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1474 * frame.c (make_frame): Call other_buffer_safely instead of
1477 * window.c (temp_output_buffer_show): Call display_buffer with
1478 second argument Vtemp_buffer_show_specifiers and reset latter
1479 immediately after the call.
1480 (Vtemp_buffer_show_specifiers): New variable.
1481 (auto_window_vscroll_p, next_screen_context_lines)
1482 (Vscroll_preserve_screen_position): Remove leading asterisks from
1485 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1487 Fix minor problems found by GCC 4.6.0 static checking.
1488 * buffer.c (Qclone_number): Remove for now, as it's unused.
1489 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1490 (record_buffer): Remove unused local.
1491 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1492 (set_frame_buffer_list): Remove; unused.
1493 * frame.h (other_visible_frames): Remove decl.
1494 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1495 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1496 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1498 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1499 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1500 Define only if HAVE_GPM.
1501 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1502 (update_hints_inhibit): Remove; never set. All uses removed.
1503 * widgetprv.h (emacsFrameClassRec): Remove decl.
1504 * window.c (delete_deletable_window): Now returns void, since it
1505 wasn't returning anything.
1506 (compare_window_configurations): Remove unused locals.
1507 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1508 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1509 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1510 the same widths as pointers. This follows up on the 2011-05-06 patch.
1511 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1512 * xterm.h: Likewise.
1513 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1515 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1517 * makefile.w32-in: Update dependencies.
1518 (LISP_H): Add lib/intprops.h.
1520 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1522 * image.c (gif_load): Add animation frame delay to the metadata.
1523 (syms_of_image): Use DEFSYM. New symbol `delay'.
1525 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1527 * window.c (delete_deletable_window): Re-add.
1528 (Fset_window_configuration): Rewrite to handle dead buffers and
1529 consequently deletable windows.
1530 (window_tree, Fwindow_tree): Remove. Supply functionality in
1532 (compare_window_configurations): Simplify code.
1534 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1536 * image.c (imagemagick_load_image): Fix type mismatch.
1537 (Fimagemagick_types): Likewise.
1539 * window.h (replace_buffer_in_windows): Declare.
1541 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1543 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1544 Qclone_number. Remove external declaration of Qdelete_window.
1545 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1547 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1548 Qbuffer_list_update_hook if allowed.
1549 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1550 buffer list implementation.
1551 (other_buffer_safely): New function.
1552 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1553 calls to replace_buffer_in_windows and
1554 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1556 (record_buffer): Inhibit quitting and rewrite using quittable
1557 functions. Run Qbuffer_list_update_hook if allowed.
1558 (Frecord_buffer, Funrecord_buffer): New functions.
1559 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1560 switch-to-buffer to window.el.
1561 (bury-buffer): Move to window.el.
1562 (Vbuffer_list_update_hook): New variable.
1564 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1567 * window.h (resize_frame_windows): Move up in code.
1568 (Fwindow_frame): Remove EXFUN.
1569 (replace_buffer_in_all_windows): Remove prototype.
1570 (replace_buffer_in_windows_safely): Add prototype.
1572 * window.c: Declare Qdelete_window static again. Move down
1573 declaration of select_count.
1574 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1575 (Fother_window): Move to window.el.
1576 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1577 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1578 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1580 (replace_buffer_in_windows): Implement by calling
1581 Qreplace_buffer_in_windows.
1582 (replace_buffer_in_all_windows): Remove with some functionality
1583 moved into replace_buffer_in_windows_safely.
1584 (replace_buffer_in_windows_safely): New function.
1585 (select_window_norecord, select_frame_norecord): Move in front
1586 of run_window_configuration_change_hook. Remove now obsolete
1588 (Fset_window_buffer): Rewrite doc-string. Call
1589 Qrecord_window_buffer.
1590 (keys_of_window): Move binding for other-window to window.el.
1592 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1594 * dispextern.h (struct image): Replace data member, whose int_val
1595 and ptr_val fields were not used by anything, with a single
1598 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1599 (gif_clear_image, gif_load, imagemagick_load_image)
1600 (gs_clear_image, gs_load): Callers changed.
1602 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1604 * buffer.h: Include <time.h>, for time_t.
1605 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1607 Fix minor problems found by static checking.
1609 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1611 Make identifiers static if they are not used in other modules.
1612 * data.c (Qcompiled_function, Qframe, Qvector):
1613 * image.c (QimageMagick, Qsvg):
1614 * minibuf.c (Qmetadata):
1615 * window.c (resize_window_check, resize_root_window): Now static.
1616 * window.h (resize_window_check, resize_root_window): Remove decls.
1618 * window.c (window_deletion_count, delete_deletable_window):
1620 (window_body_lines): Now static.
1621 (Fdelete_other_windows_internal): Mark vars as initialized.
1622 Make sure 'resize_failed' is initialized.
1623 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1624 (resize_window_apply): Remove unused local.
1625 * window.h (delete_deletable_window): Remove decl.
1627 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1628 (imagemagick_load_image): Fix pointer signedness problem by changing
1629 last arg from unsigned char * to char *. All uses changed.
1630 Also, fix a local for similar reasons.
1631 Remove unused locals. Remove locals to avoid shadowing.
1632 (fn_rsvg_handle_free): Remove; unused.
1633 (svg_load, svg_load_image): Fix pointer signedness problem.
1634 (imagemagick_load_image): Don't use garbage pointer image_wand.
1636 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1638 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1640 * image.c (gif_load): Fix omitted cast error introduced by
1643 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1645 * window.h (resize_proportionally, orig_total_lines)
1646 (orig_top_line): Remove from window structure.
1647 (set_window_height, set_window_width, change_window_heights)
1648 (Fdelete_window): Remove prototypes.
1649 (resize_frame_windows): Remove duplicate declaration.
1651 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1653 * window.h (resize_frame_windows, resize_window_check)
1654 (delete_deletable_window, resize_root_window)
1655 (resize_frame_windows): Declare prototypes.
1657 * window.c (resize_window_apply): Make definition be "static" to
1658 match the prototype.
1660 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1662 * window.c: Remove declarations of Qwindow_size_fixed,
1663 window_min_size_1, window_min_size_2, window_min_size,
1664 size_window, window_fixed_size_p, enlarge_window, delete_window.
1665 Remove static from declaration of Qdelete_window, it's
1666 temporarily needed by Fbury_buffer.
1667 (replace_window): Don't assign orig_top_line and
1669 (Fdelete_window, delete_window): Remove. Window deletion is
1670 handled by window.el.
1671 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1672 Fdelete_window calls with calls to Qdelete_window.
1673 (Fdelete_other_windows): Remove. Deleting other windows is
1674 handled by window.el.
1675 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1676 handled in window.el.
1677 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1678 Window minimum sizes are handled in window.el.
1679 (shrink_windows, size_window, set_window_height)
1680 (set_window_width, change_window_heights, window_height)
1681 (window_width, CURBEG, CURSIZE, enlarge_window)
1682 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1683 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1684 handled in window.el.
1685 (make_dummy_parent): Rename to make_parent_window and give it a
1686 second argument horflag.
1687 (make_window): Don't set resize_proportionally any more.
1688 (Fsplit_window): Remove. Windows are split in window.el.
1689 (save_restore_action, save_restore_orig_size)
1690 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1691 Resize mini windows in window.el.
1692 (grow_mini_window, shrink_mini_window): Implement by calling
1693 Qresize_root_window_vertically, resize_window_check and
1694 resize_window_apply.
1695 (saved_window, Fset_window_configuration, save_window_save): Do
1696 not handle orig_top_line, orig_total_lines, and
1697 resize_proportionally.
1698 (window_min_height, window_min_width): Move to window.el.
1699 (keys_of_window): Move bindings for delete-other-windows,
1700 split-window, delete-window and enlarge-window to window.el.
1702 * buffer.c: Temporarily extern Qdelete_window.
1703 (Fbury_buffer): Temporarily call Qdelete_window instead of
1704 Fdelete_window (Fbury_buffer will move to window.el soon).
1706 * frame.c (set_menu_bar_lines_1): Remove code handling
1707 orig_top_line and orig_total_lines.
1709 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1710 set_window_height but set heights directly.
1711 (change_frame_size_1): Use resize_frame_windows.
1713 * xdisp.c (init_xdisp): Don't use set_window_height but set
1716 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1717 resize_frame_windows instead of change_window_heights and run
1718 run_window_configuration_change_hook.
1720 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1721 instead of change_window_heights and run
1722 run_window_configuration_change_hook.
1724 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1726 * window.c (replace_window): Rename second argument REPLACEMENT to
1727 NEW. New third argument SETFLAG. Rewrite.
1728 (delete_window, make_dummy_parent): Call replace_window with
1730 (window_list_1): Move down in code.
1731 (run_window_configuration_change_hook): Move set_buffer part
1732 before select_frame_norecord part in order to unwind correctly.
1733 Rename count1 to count.
1734 (recombine_windows, delete_deletable_window, resize_root_window)
1735 (Fdelete_other_windows_internal)
1736 (Frun_window_configuration_change_hook, make_parent_window)
1737 (resize_window_check, resize_window_apply, Fresize_window_apply)
1738 (resize_frame_windows, Fsplit_window_internal)
1739 (Fdelete_window_internal, Fresize_mini_window_internal): New
1741 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1743 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1745 * window.h (window): Add some new members to window structure -
1746 normal_lines, normal_cols, new_total, new_normal, clone_number,
1747 splits, nest, prev_buffers, next_buffers.
1748 (WINDOW_TOTAL_SIZE): Move here from window.c.
1749 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1751 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1753 (make_dummy_parent): Set new members of windows structure.
1754 (make_window): Move down in code. Handle new members of window
1756 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1757 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1758 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1759 (Fset_window_prev_buffers, Fwindow_next_buffers)
1760 (Fset_window_next_buffers, Fset_window_clone_number): New
1762 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1763 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1765 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1766 Argument WINDOW can be now internal window too.
1767 (Fwindow_use_time): Move up in code.
1768 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1770 (Fset_window_configuration, saved_window)
1771 (Fcurrent_window_configuration, save_window_save): Handle new
1772 members of window structure.
1773 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1774 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1775 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1776 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1777 Qget_mru_window, Qresize_root_window,
1778 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1779 Qauto_buffer_name; staticpro them.
1781 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1783 * window.c (Fwindow_total_size, Fwindow_left_column)
1784 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1785 (Fwindow_list_1): New functions.
1786 (window_box_text_cols): Replace with window_body_cols.
1787 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1788 window_body_cols instead of window_box_text_cols.
1789 (delete_window, Fset_window_configuration): Call
1790 delete_all_subwindows with window as argument.
1791 (delete_all_subwindows): Take a window as argument and not a
1793 (window_loop): Remove handling of GET_LRU_WINDOW and
1795 (Fget_lru_window, Fget_largest_window): Move to window.el.
1797 * window.h: Extern window_body_cols instead of
1798 window_box_text_cols. delete_all_subwindows now takes a
1799 Lisp_Object as argument.
1801 * indent.c (compute_motion, Fcompute_motion): Use
1802 window_body_cols instead of window_box_text_cols.
1804 * frame.c (delete_frame): Call delete_all_subwindows with root
1807 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1809 * fns.c (Fputhash): Document return value.
1811 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1813 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1815 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1817 Cons<->int and similar integer overflow fixes (Bug#8794).
1819 Check for overflow when converting integer to cons and back.
1820 * charset.c (Fdefine_charset_internal, Fdecode_char):
1821 Use cons_to_unsigned to catch overflow.
1822 (Fencode_char): Use INTEGER_TO_CONS.
1823 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1824 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1825 * data.c (long_to_cons, cons_to_long): Remove.
1826 (cons_to_unsigned, cons_to_signed): New functions.
1827 These signal an error for invalid or out-of-range values.
1828 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1829 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1830 * font.c (Ffont_variation_glyphs):
1831 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1832 * lisp.h: Include <intprops.h>.
1833 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1834 (cons_to_signed, cons_to_unsigned): New decls.
1835 (long_to_cons, cons_to_long): Remove decls.
1836 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1837 (Fprimitive_undo): Use CONS_TO_INTEGER.
1838 * xfns.c (Fx_window_property): Likewise.
1839 * xselect.c: Include <limits.h>.
1840 (x_own_selection, selection_data_to_lisp_data):
1841 Use INTEGER_TO_CONS.
1842 (x_handle_selection_request, x_handle_selection_clear)
1843 (x_get_foreign_selection, Fx_disown_selection_internal)
1844 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1845 (lisp_data_to_selection_data): Use cons_to_unsigned.
1846 (x_fill_property_data): Use cons_to_signed.
1847 Report values out of range.
1849 Check for buffer and string overflow more precisely.
1850 * buffer.h (BUF_BYTES_MAX): New macro.
1851 * lisp.h (STRING_BYTES_MAX): New macro.
1852 * alloc.c (Fmake_string):
1853 * character.c (string_escape_byte8):
1854 * coding.c (coding_alloc_by_realloc):
1855 * doprnt.c (doprnt):
1856 * editfns.c (Fformat):
1858 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1859 since they may not be the same number.
1860 * editfns.c (Finsert_char):
1861 * fileio.c (Finsert_file_contents):
1862 Likewise for BUF_BYTES_MAX.
1864 * image.c: Use ptrdiff_t, not int, for sizes.
1865 (slurp_file): Switch from int to ptrdiff_t.
1867 (slurp_file): Check that file size fits in both size_t (for
1868 malloc) and ptrdiff_t (for sanity and safety).
1870 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1871 if b->modtime has its maximal value.
1873 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1875 Don't assume time_t can fit into int.
1876 * buffer.h (struct buffer.modtime): Now time_t, not int.
1877 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1878 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1880 Minor fixes for signed vs unsigned integers.
1881 * character.h (MAYBE_UNIFY_CHAR):
1882 * charset.c (maybe_unify_char):
1883 * keyboard.c (read_char, reorder_modifiers):
1884 XINT -> XFASTINT, since the integer must be nonnegative.
1885 * ftfont.c (ftfont_spec_pattern):
1886 * keymap.c (access_keymap, silly_event_symbol_error):
1887 XUINT -> XFASTINT, since the integer must be nonnegative.
1888 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1889 since it makes no difference and we prefer signed.
1890 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1891 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1894 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1896 * window.h (Fwindow_frame): Declare.
1898 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1900 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1901 (SPARE_MEMORY): Always define.
1902 (LARGE_REQUEST): Remove.
1903 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1905 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1907 * lisp.h: Move EXFUNS for Fframe_root_window,
1908 Fframe_first_window and Fset_frame_selected_window to window.h.
1910 * window.h: Move EXFUNS for Fframe_root_window,
1911 Fframe_first_window and Fset_frame_selected_window here from
1914 * frame.c (Fwindow_frame, Fframe_first_window)
1915 (Fframe_root_window, Fframe_selected_window)
1916 (Fset_frame_selected_window): Move to window.c.
1917 (Factive_minibuffer_window): Move to minibuf.c.
1918 (Fother_visible_frames_p): New function.
1920 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1922 * window.c (decode_window, decode_any_window): Move up in code.
1923 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1924 (inhibit_frame_unsplittable): Remove unused variable.
1925 (Fwindow_buffer): Move up and rewrite doc-string.
1926 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1927 (Fwindow_prev): New functions.
1928 (Fwindow_frame): Move here from frame.c. Accept any window as
1930 (Fframe_root_window, Fframe_first_window)
1931 (Fframe_selected_window): Move here from frame.c. Accept frame
1932 or arbitrary window as argument. Update doc-strings.
1933 (Fminibuffer_window): Move up in code.
1934 (Fwindow_minibuffer_p): Move up in code and simplify.
1935 (Fset_frame_selected_window): Move here from frame.c.
1937 (Fselected_window, select_window, Fselect_window): Move up in
1938 code. Minor doc-string fixes.
1940 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1942 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1943 Do not assume that spare memory exists; that assumption is valid
1944 only if SYSTEM_MALLOC.
1945 (LARGE_REQUEST): New macro, so that the issue of large requests
1946 is separated from the issue of spare memory.
1948 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1950 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1953 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1955 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1958 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1960 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1962 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1964 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1965 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1967 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1969 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1971 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1973 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1974 (x_clipboard_manager_save): Add return value.
1975 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1977 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1978 Obey Vx_select_enable_clipboard_manager. Catch errors in
1979 x_clipboard_manager_save (Bug#8779).
1980 (Vx_select_enable_clipboard_manager): New variable.
1981 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1983 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1985 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1987 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1989 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1990 in the current matrix if keep_current_p is non-zero.
1992 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1994 * bidi.c (bidi_level_of_next_char): Fix last change.
1996 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1998 Support bidi reordering of text covered by display properties.
2000 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2001 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2002 (bidi_cache_search, bidi_cache_iterator_state)
2003 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2004 (bidi_level_of_next_char, bidi_move_to_visually_next):
2005 Support character positions inside a run of characters covered by a
2007 (bidi_paragraph_init, bidi_resolve_explicit_1)
2008 (bidi_level_of_next_char): Call bidi_fetch_char and
2009 bidi_fetch_char_advance instead of FETCH_CHAR and
2011 (bidi_init_it): Initialize new members.
2012 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2014 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2015 instead of using explicit *_CHAR codes.
2016 (bidi_resolve_explicit, bidi_resolve_weak):
2017 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2018 bidirectional text is supported only in multibyte buffers.
2019 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2020 it to initialize the frame_window_p member of struct bidi_it.
2021 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2022 (bidi_resolve_explicit, bidi_resolve_weak)
2023 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2024 bidi_it->nchars is non-positive.
2025 (bidi_level_of_next_char): Don't try to lookup the cache for the
2026 next/previous character if nothing is cached there yet, or if we
2027 were just reseat()'ed to a new position.
2029 * xdisp.c (set_cursor_from_row): Set start and stop points
2030 according to the row's direction when priming the loop that looks
2031 for the glyph on which to display cursor.
2032 (single_display_spec_intangible_p): Function deleted.
2033 (display_prop_intangible_p): Reimplement to call
2034 handle_display_spec instead of single_display_spec_intangible_p.
2035 Accept 3 additional arguments needed by handle_display_spec.
2036 This fixes incorrect cursor motion across display property with complex
2037 values: lists, `(when COND...)' forms, etc.
2038 (single_display_spec_string_p): Support property values that are
2039 lists with the argument STRING its top-level element.
2040 (display_prop_string_p): Fix the condition for processing a
2041 property that is a list to be consistent with handle_display_spec.
2042 (handle_display_spec): New function, refactored from the
2043 last portion of handle_display_prop.
2044 (compute_display_string_pos): Accept additional argument
2045 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2046 value of a `display' property is a "replacing spec".
2047 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2048 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2049 the display property, but just return a value indicating whether
2050 the display property will replace the characters it covers.
2051 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2052 frame_window_p members of struct bidi_it.
2053 (compute_display_string_pos, compute_display_string_end):
2055 (push_it): Accept second argument POSITION, where pop_it should
2056 jump to continue iteration.
2057 (reseat_1): Initialize bidi_it.disp_pos.
2059 * keyboard.c (adjust_point_for_property): Adjust the call to
2060 display_prop_intangible_p to its new signature.
2062 * dispextern.h (struct bidi_it): New member frame_window_p.
2063 (bidi_init_it): Update prototypes.
2064 (display_prop_intangible_p): Update prototype.
2065 (compute_display_string_pos, compute_display_string_end):
2067 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2070 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2072 Malloc failure behavior now depends on size of allocation.
2073 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2074 * lisp.h: Change signatures accordingly.
2075 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2076 All callers changed. (Bug#8762)
2078 * gnutls.c: Use Emacs's memory allocators.
2079 Without this change, the gnutls library would invoke malloc etc.
2080 directly, which causes problems on non-SYNC_INPUT hosts, and which
2081 runs afoul of improving memory_full behavior. (Bug#8761)
2082 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2083 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2084 xfree instead of the default malloc, realloc, free.
2085 (Fgnutls_boot): No need to check for memory allocation failure,
2086 since xmalloc does that for us.
2088 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2089 * category.c (hash_get_category_set):
2090 * ccl.c (ccl_driver):
2091 * charset.c (Fdefine_charset_internal):
2092 * charset.h (struct charset.hash_index):
2093 * composite.c (get_composition_id, gstring_lookup_cache)
2094 (composition_gstring_put_cache):
2095 * composite.h (struct composition.hash_index):
2096 * dispextern.h (struct image.hash):
2097 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2098 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2099 (hashfn_equal, hashfn_user_defined, make_hash_table)
2100 (maybe_resize_hash_table, hash_lookup, hash_put)
2101 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2102 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2103 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2104 * image.c (make_image, search_image_cache, lookup_image)
2105 (xpm_put_color_table_h):
2106 * lisp.h (struct Lisp_Hash_Table):
2107 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2108 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2109 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2110 * alloc.c (allocate_vectorlike):
2111 Check for overflow in vector size calculations.
2112 * ccl.c (ccl_driver):
2113 Check for overflow when converting EMACS_INT to int.
2114 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2115 need to be updated by these changes.
2116 * fns.c (make_hash_table, maybe_resize_hash_table):
2117 Check for integer overflow with large hash tables.
2118 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2119 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2120 (SXHASH_REDUCE): New macro.
2121 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2122 Use it instead of discarding useful hash info with large hash values.
2123 (sxhash_float): New function.
2124 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2125 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2126 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2127 Rewrite to use FIXNUM_BITS, as this simplifies things.
2128 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2129 Adjust signatures to match updated version of code.
2130 (consing_since_gc): Now EMACS_INT, since a single hash table can
2131 use more than INT_MAX bytes.
2133 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2135 Make it possible to build with GCC-4.6+ -O2 -flto.
2137 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2139 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2141 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2142 Call minibuffer-inactive-mode.
2144 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2146 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2147 Update dependencies.
2149 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2151 * data.c (init_data): Remove code for UTS, this system is not
2154 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2156 Don't force ./temacs to start in terminal mode.
2158 * frame.c (make_initial_frame): Initialize faces in all cases, not
2159 only when CANNOT_DUMP is defined.
2160 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2162 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2164 * dispnew.c (add_window_display_history): Use const for the string
2165 pointer. Remove declaration, not needed.
2167 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2169 Use 'inline', not 'INLINE'.
2170 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2171 * alloc.c, fontset.c (INLINE): Remove.
2172 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2173 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2174 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2175 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2176 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2178 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2180 Make it possible to run ./temacs.
2182 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2183 syms_of_callproc does the same thing. Remove test for
2184 "initialized", do it in the caller.
2185 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2187 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2189 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2190 (read_minibuf): Use get_minibuffer.
2191 (syms_of_minibuf): Use DEFSYM.
2192 (Qmetadata): New var.
2193 * data.c (Qbuffer): Don't make it static.
2194 (syms_of_data): Use DEFSYM.
2196 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2198 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2199 (CCL_CODE_MIN): New macro.
2201 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2203 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2205 * eval.c (Qdebug): Now static.
2206 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2207 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2208 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2210 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2212 * image.c: Various fixes to ImageMagick code comments.
2213 (Fimagemagick_types): Doc fix.
2215 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2217 Minor fixes prompted by GCC 4.6.0 warnings.
2219 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2221 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2222 (x_clipboard_manager_save_all): Move extern decl to ...
2223 * xterm.h: ... here, so that it can be checked for consistency.
2225 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2227 * xselect.c (x_clipboard_manager_save_frame)
2228 (x_clipboard_manager_save_all): New functions.
2229 (Fx_clipboard_manager_save): Lisp function deleted.
2231 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2232 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2234 * xterm.h: Update prototype.
2236 2011-05-28 William Xu <william.xwl@gmail.com>
2238 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2241 2011-05-28 Jim Meyering <meyering@redhat.com>
2243 Avoid a sign-extension bug in crypto_hash_function.
2244 * fns.c (to_uchar): Define.
2245 (crypto_hash_function): Use it to convert some newly-signed
2246 variables to unsigned, to avoid sign-extension bugs. For example,
2247 without this change, (md5 "truc") would evaluate to
2248 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2249 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2250 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2252 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2254 Integer overflow fixes.
2256 * dbusbind.c: Serial number integer overflow fixes.
2257 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2258 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2259 to hold a serial number that is too large for a fixnum.
2260 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2261 Check for serial numbers out of range. Decode any serial number
2262 that was so large that it became a float. (Bug#8722)
2264 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2265 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2266 Use XFASTINT rather than XUINT when numbers are nonnegative.
2267 (xd_append_arg, Fdbus_method_return_internal):
2268 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2269 arguments, check that Lisp number is nonnegative, rather than
2270 silently wrapping negative numbers around. (Bug#8722)
2271 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2274 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2276 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2278 ccl: add integer overflow checks
2279 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2280 (IN_INT_RANGE): New macros.
2281 (ccl_driver): Use them to check for integer overflow when
2282 decoding a CCL program. Many of the new checks are whether XINT (x)
2283 fits in int; it doesn't always, on 64-bit hosts. The new version
2284 doesn't catch all possible integer overflows, but it's an
2285 improvement. (Bug#8719)
2287 * alloc.c (make_event_array): Use XINT, not XUINT.
2288 There's no need for unsigned here.
2290 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2291 This follows up to the 2011-05-06 change that substituted uintptr_t
2292 for EMACS_INT. This case wasn't caught back then.
2294 Rework Fformat to avoid integer overflow issues.
2295 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2296 now (part of C89). Include <verify.h>.
2297 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2298 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2299 (Fformat): Avoid the prepass trying to compute sizes; it was only
2300 approximate and thus did not catch overflow reliably. Instead, walk
2301 through the format just once, formatting and computing sizes as we go,
2302 checking for integer overflow at every step, and allocating a larger
2303 buffer as needed. Keep track separately whether the format is
2304 multibyte. Keep only the most-recently calculated precision, rather
2305 than them all. Record whether each argument has been converted to
2306 string. Use EMACS_INT, not int, for byte and char and arg counts.
2307 Support field widths and precisions larger than INT_MAX. Avoid
2308 sprintf's undefined behavior with conversion specifications such as %#d
2309 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2310 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2311 formatting out-of-range floating point numbers with int
2314 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2316 * data.c: Avoid integer truncation in expressions involving floats.
2317 * data.c: Include <intprops.h>.
2318 (arith_driver): When there's an integer overflow in an expression
2319 involving floating point, convert the integers to floating point
2320 so that the resulting value does not suffer from catastrophic
2321 integer truncation. For example, on a 64-bit host (* 4
2322 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2323 Do not rely on undefined behavior after integer overflow.
2325 merge count_size_as_multibyte, parse_str_to_multibyte
2326 * character.c, character.h (count_size_as_multibyte):
2327 Rename from parse_str_to_multibyte; all uses changed.
2328 Check for integer overflow.
2329 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2330 since it's now a duplicate of the other. This is more of
2331 a character than a buffer op, so better that it's in character.c.
2332 * fns.c, print.c: Adjust to above changes.
2334 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2336 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2338 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2340 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2341 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2342 (x_clipboard_manager_save): Now static.
2343 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2345 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2346 (crypto_hash_function): Now static.
2347 Fix pointer signedness problems. Avoid unnecessary initializations.
2349 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2351 * termhooks.h (Vselection_alist): Make it terminal-local.
2353 * terminal.c (create_terminal): Initialize it.
2355 * xselect.c: Support for clipboard managers.
2356 (Vselection_alist): Move to termhooks.h as terminal-local var.
2357 (LOCAL_SELECTION): New macro.
2358 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2359 (symbol_to_x_atom): Remove gratuitous arg.
2360 (x_handle_selection_request, lisp_data_to_selection_data)
2361 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2362 (x_own_selection, x_get_local_selection, x_convert_selection):
2363 New arg, specifying work frame. Use terminal-local Vselection_alist.
2364 (some_frame_on_display): Delete unused function.
2365 (Fx_own_selection_internal, Fx_get_selection_internal)
2366 (Fx_disown_selection_internal, Fx_selection_owner_p)
2367 (Fx_selection_exists_p): New optional frame arg.
2368 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2369 (x_handle_selection_clear): Don't treat other terminals with the
2370 same keyboard specially. Use the terminal-local Vselection_alist.
2371 (x_clear_frame_selections): Use Frun_hook_with_args.
2373 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2375 * xterm.h: Add support for those atoms.
2377 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2379 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2380 (converted_selections, conversion_fail_tag): New global variables.
2381 (x_selection_request_lisp_error): Free the above.
2382 (x_get_local_selection): Remove unnecessary code.
2383 (x_reply_selection_request): Args changed; handle arbitrary array
2384 of converted selections stored in converted_selections.
2385 Separate the XChangeProperty and SelectionNotify steps.
2386 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2387 (x_convert_selection): New function.
2388 (x_handle_selection_event): Simplify.
2389 (x_get_foreign_selection): Don't ignore incoming requests while
2390 waiting for an answer; this will fail when we implement
2391 SAVE_TARGETS, and seems unnecessary anyway.
2392 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2393 (Vx_sent_selection_functions): Doc fix.
2395 2011-05-26 Leo Liu <sdl.web@gmail.com>
2397 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2399 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2401 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2403 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2404 for fringe update if it has periodic bitmap.
2405 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2406 and fringe_bitmap_periodic_p.
2408 * fringe.c (get_fringe_bitmap_data): New function.
2409 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2410 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2411 row. Mark glyph row for fringe update if periodicity changed.
2413 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2414 for fringe update unless it has periodic bitmap.
2416 2011-05-25 Kenichi Handa <handa@m17n.org>
2418 * xdisp.c (get_next_display_element): Set correct it->face_id for
2419 a static composition.
2421 2011-05-24 Leo Liu <sdl.web@gmail.com>
2424 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2426 * fns.c (crypto_hash_function, Fsha1): New function.
2427 (Fmd5): Use crypto_hash_function.
2428 (syms_of_fns): Add Ssha1.
2430 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2432 * gnutls.c: Remove unused macros.
2433 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2434 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2435 Remove macros that are defined and never used.
2436 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2438 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2440 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2441 (Fx_get_selection_internal): Minor cleanup.
2442 (Fx_own_selection_internal): Rename arguments for consistency with
2445 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2447 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2449 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2451 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2453 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2455 * dispnew.c (scrolling_window): Don't exclude the case that the
2456 last enabled row in the desired matrix touches the bottom boundary.
2458 2011-05-21 Glenn Morris <rgm@gnu.org>
2460 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2461 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2462 and add some more files.
2464 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2466 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2467 report_file_error introduced by the change from 2011-05-07.
2469 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2471 * systime.h (Time): Define only if emacs is defined.
2472 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2473 where the include path doesn't have X11/X.h by default. See
2474 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2476 2011-05-20 Kenichi Handa <handa@m17n.org>
2478 * composite.c (find_automatic_composition): Fix previous change.
2480 2011-05-20 Glenn Morris <rgm@gnu.org>
2482 * lisp.mk: New file, split from Makefile.in.
2483 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2484 (shortlisp): Remove.
2485 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2487 2011-05-19 Glenn Morris <rgm@gnu.org>
2489 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2490 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2491 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2492 (lisp): Set the order to that of loadup.el.
2493 (shortlisp): Make it a copy of $lisp.
2494 (SOME_MACHINE_LISP): Remove.
2495 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2496 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2498 2011-05-18 Kenichi Handa <handa@m17n.org>
2500 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2501 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2502 (find_automatic_composition): Mostly rewrite for efficiency.
2504 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2506 * makefile.w32-in: Update dependencies.
2508 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2510 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2511 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2513 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2515 Fix some integer overflow issues, such as string length overflow.
2517 * insdel.c (count_size_as_multibyte): Check for string overflow.
2519 * character.c (lisp_string_width): Check for string overflow.
2520 Use EMACS_INT, not int, for string indexes and lengths; in
2521 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2522 the resulting string length overflows an EMACS_INT; instead,
2523 report a string overflow if no precision given. When checking for
2524 precision exhaustion, use a check that cannot possibly have
2525 integer overflow. (Bug#8675)
2526 * character.h (lisp_string_width): Adjust to new signature.
2528 * alloc.c (string_overflow): New function.
2529 (Fmake_string): Use it. This doesn't change behavior, but saves
2530 a few bytes and will simplify future changes.
2531 * character.c (string_escape_byte8): Likewise.
2532 * lisp.h (string_overflow): New decl.
2534 Fixups, following up to the user-interface timestamp change.
2535 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2536 for UI timestamps, instead of unsigned long.
2537 * msdos.c (mouse_get_pos): Likewise.
2538 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2539 * w32gui.h (Time): Define by including "systime.h" rather than by
2540 declaring it ourselves. (Bug#8664)
2542 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2543 * image.c (clear_image_cache): Likewise.
2545 * term.c (term_mouse_position): Don't assume time_t wraparound.
2547 Be more systematic about user-interface timestamps.
2548 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2549 and sometimes 'EMACS_UINT', to represent these timestamps.
2550 This change causes it to use 'Time' uniformly, as that's what X uses.
2551 This makes the code easier to follow, and makes it easier to catch
2552 integer overflow bugs such as Bug#8664.
2553 * frame.c (Fmouse_position, Fmouse_pixel_position):
2554 Use Time, not unsigned long, for user-interface timestamps.
2555 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2556 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2557 * keyboard.h (last_event_timestamp): Likewise.
2558 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2559 * menu.h (xmenu_show): Likewise.
2560 * term.c (term_mouse_position): Likewise.
2561 * termhooks.h (struct input_event.timestamp): Likewise.
2562 (struct terminal.mouse_position_hook): Likewise.
2563 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2564 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2565 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2566 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2568 * menu.h, termhooks.h: Include "systime.h", for Time.
2570 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2571 Don't assume that the difference between two unsigned long values
2572 can fit into an integer. At this point, we know button_down_time
2573 <= event->timestamp, so the difference must be nonnegative, so
2574 there's no need to cast the result if double-click-time is
2575 nonnegative, as it should be; check that it's nonnegative, just in
2576 case. This bug is triggered when events are more than 2**31 ms
2577 apart (about 25 days). (Bug#8664)
2579 * xselect.c (last_event_timestamp): Remove duplicate decl.
2580 (x_own_selection): Remove needless cast to unsigned long.
2582 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2583 that always fit in int. Use a sentinel instead of a counter, to
2584 avoid a temp and to allay GCC's concerns about possible int overflow.
2585 * frame.h (struct frame): Use int for menu_bar_items_used
2586 instead of EMACS_INT, since it always fits in int.
2588 * menu.c (grow_menu_items): Check for int overflow.
2590 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2592 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2593 Before, the code was not consistent. These values cannot exceed
2594 2**31 - 1 so there's no need to make them unsigned.
2595 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2596 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2597 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2599 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2601 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2602 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2603 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2604 presumably because the widths might not match.
2606 * window.c (size_window): Avoid needless test at loop start.
2608 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2610 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2612 2011-05-12 Drew Adams <drew.adams@oracle.com>
2614 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2616 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2618 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2619 `width' to `bar_area_x' and `bar_area_width', respectively.
2620 (x_scroll_run): Take account of fringe background extension.
2622 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2623 Rename local vars `left' and `width' to `bar_area_x' and
2624 `bar_area_width', respectively.
2625 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2626 background extension.
2628 2011-05-10 Jim Meyering <meyering@redhat.com>
2630 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2632 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2634 * image.c (Finit_image_library): Return t for built-in image types,
2635 like pbm and xbm. (Bug#8640)
2637 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2639 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2641 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2643 * w32console.c (Fset_screen_color): Doc fix.
2644 (Fget_screen_color): New function.
2645 (syms_of_ntterm): Defsubr it.
2647 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2648 unlink the temporary file if Fcall_process didn't create it in the
2650 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2651 child process will be redirected to a file specified with `:file'.
2652 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2653 cue to call_process_cleanup not to close that handle.
2655 2011-05-07 Ben Key <bkey76@gmail.com>
2657 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2658 one of two shell specific rules, either bootstrap-temacs-CMD or
2659 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2660 to the previous implementation of the bootstrap-temacs rule.
2661 The bootstrap-temacs-CMD rule is similar to the previous
2662 implementation of the bootstrap-temacs rule except that it
2663 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2666 These changes, along with some changes to nt/configure.bat,
2667 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2668 earlier fix to add support for --cflags and --ldflags options
2669 that include quotes so that it works whether make uses cmd or
2672 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2674 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2675 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2677 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2678 a string. Handle both cases.
2679 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2680 (Fdbus_register_method): Use Qinvalid_function.
2682 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2684 * makefile.w32-in: Update dependencies.
2685 (LISP_H): Add inttypes.h and stdin.h.
2686 (PROCESS_H): Add unistd.h.
2688 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2690 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2691 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2693 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2695 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2697 * term.c (vfatal): Remove stray call to va_end.
2698 It's not needed and the C Standard doesn't allow it here anyway.
2700 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2701 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2703 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2706 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2708 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2710 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2712 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2714 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2716 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2717 * charset.c (Fdefine_charset_internal): Don't initialize
2718 charset.code_space[15]. The value was garbage, on hosts with
2719 32-bit int (Bug#8600).
2721 * lread.c (read_integer): Be more consistent with string-to-number.
2722 Use string_to_number to do the actual conversion; this avoids
2723 rounding errors and fixes some other screwups. Without this fix,
2724 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2725 (digit_to_number): Move earlier, for benefit of read_integer.
2726 Return -1 if the digit is out of range for the base, -2 if it is
2727 not a digit in any supported base. (Bug#8602)
2729 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2731 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2732 to match comment at start of function. This also removes a
2733 GCC warning about overflow in a 32+64-bit port.
2735 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2737 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2738 Reported by Stefan Monnier in
2739 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2740 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2741 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2743 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2744 (EMACS_UINTPTR): Likewise, with uintptr_t.
2746 * lisp.h: Prefer 64-bit EMACS_INT if available.
2747 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2748 on 32-bit hosts that have 64-bit int, so that they can access
2750 However, temporarily disable this change unless the temporary
2751 symbol WIDE_EMACS_INT is defined.
2753 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2755 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2756 This removes an assumption that EMACS_INT and long are the same
2757 width as pointers. The assumption is true for Emacs porting targets
2758 now, but we want to make other targets possible.
2759 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2760 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2761 In the rest of the code, change types of integers that hold casted
2762 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2763 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2764 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2765 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2766 No need to cast type when ORing.
2767 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2768 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2769 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2770 assume EMACS_INT is the same width as char *.
2771 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2772 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2773 Remove no-longer-needed casts.
2774 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2775 (xg_tool_bar_help_callback, xg_make_tool_item):
2776 Use EMACS_INTPTR to hold an integer
2777 that will be cast to void *; this can avoid a GCC warning
2778 if EMACS_INT is not the same width as void *.
2779 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2780 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2781 (current_message_1, set_message_1):
2782 Use a local to convert to proper width without a cast.
2783 * xmenu.c (dialog_selection_callback): Likewise.
2785 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2786 Also, don't assume VALBITS / RAND_BITS is less than 5,
2787 and don't rely on undefined behavior when shifting a 1 left into
2789 * lisp.h (get_random): Change signature to match.
2791 * lread.c (hash_string): Use size_t, not int, for hash computation.
2792 Normally we prefer signed values; but hashing is special, because
2793 it's better to use unsigned division on hash table sizes so that
2794 the remainder is nonnegative. Also, size_t is the natural width
2795 for hashing into memory. The previous code used 'int', which doesn't
2796 retain enough info to hash well into very large tables.
2797 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2799 * dbusbind.c: Don't possibly lose pointer info when converting.
2800 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2801 Use XPNTR rather than XHASH, so that the high-order bits of
2802 the pointer aren't lost when converting through void *.
2804 * eval.c (Fautoload): Don't double-shift a pointer.
2806 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2808 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2810 * gnutls.c (DEF_GNUTLS_FN):
2811 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2813 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2815 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2818 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2820 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2821 New version that can reserve upto 2GB of heap space.
2823 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2825 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2827 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2829 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2830 `gnutls_certificate_set_x509_key_file'.
2832 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2834 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2835 Update dependencies.
2837 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2839 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2840 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2841 Remove unused parameter `fildes'.
2842 * process.c (read_process_output, send_process): Don't pass it.
2844 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2846 Fix previous change: the library cache is defined in w32.c.
2847 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2848 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2850 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2852 Implement dynamic loading of GnuTLS on Windows.
2854 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2855 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2856 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2859 * gnutls.c (Qgnutls_dll): Define.
2860 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2861 (gnutls_*): Declare function pointers.
2862 (init_gnutls_functions): New function to initialize function pointers.
2863 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2864 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2865 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2866 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2867 (emacs_gnutls_write, emacs_gnutls_read)
2868 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2869 (Fgnutls_available_p): New function.
2870 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2871 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2872 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2874 * image.c: Include w32.h.
2875 (Vimage_type_cache): Delete.
2876 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2877 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2878 (w32_delayed_load): Move to w32.c.
2880 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2882 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2883 (w32_delayed_load): Move from image.c. When loading a library, record
2884 its filename in the :loaded-from property of the library id.
2885 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2886 Initialize and staticpro them.
2887 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2889 * process.c: Include lisp.h before w32.h, not after.
2890 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2891 instead of gnutls_record_check_pending.
2893 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2895 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2897 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2898 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2901 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2903 * xterm.c (x_set_frame_alpha): Do not set property on anything
2904 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2906 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2908 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2910 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2912 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2913 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2914 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2915 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2916 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2917 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2918 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2919 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2920 (Qgnutls_bootprop_callbacks_verify): Make static.
2922 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2924 * callproc.c: Indentation fixup.
2926 * sysdep.c (wait_for_termination_1): Make static.
2927 (wait_for_termination, interruptible_wait_for_termination):
2928 Move after wait_for_termination_1.
2930 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2932 * sysdep.c (interruptible_wait_for_termination): New function
2933 which is like wait_for_termination, but allows keyboard
2936 * callproc.c (Fcall_process): Add (:file "file") as an option for
2938 (Fcall_process_region): Ditto.
2940 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2942 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2943 rather than `XVECTOR (FOO)->size'.
2945 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2946 inttypes.h, as a gnulib replacement is used if it not available in
2949 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2951 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2952 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2953 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2955 * coding.c (coding_alloc_by_realloc): Error out if destination
2956 will grow beyond MOST_POSITIVE_FIXNUM.
2957 (decode_coding_emacs_mule): Abort if there isn't enough place in
2958 charbuf for the composition carryover bytes. Reserve an extra
2959 space for up to 2 characters produced in a loop.
2960 (decode_coding_iso_2022): Abort if there isn't enough place in
2961 charbuf for the composition carryover bytes.
2963 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2965 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2966 aborting when %lld or %lll format is passed.
2967 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2968 %llo or %llx format is passed. (Bug#8545)
2970 * window.c (window_scroll_line_based): Use a marker instead of
2971 simple variables to record original value of point. (Bug#7952)
2973 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2974 produced by %s or %c overflows available buffer space. (Bug#8545)
2976 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2978 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2979 (SIZE_MAX): Move defn after all includes, as they might #define it.
2981 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2983 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2985 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2987 * keyboard.c (Qdelayed_warnings_hook): Define.
2988 (command_loop_1): Run `delayed-warnings-hook'
2989 if Vdelayed_warnings_list is non-nil.
2990 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2991 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2993 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2995 * doprnt.c (doprnt): Don't return value smaller than the buffer
2996 size if the message was truncated. (Bug#8545).
2998 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3000 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3001 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3003 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3005 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3007 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3009 * makefile.w32-in: Update dependencies.
3011 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3013 Improve `doprnt' and its usage. (Bug#8545)
3014 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3015 `format_end'. Remove support for %l as a conversion specifier.
3016 Don't use xrealloc. Improve diagnostics when the %l size modifier
3017 is used. Update the commentary.
3019 * eval.c (verror): Simplify calculation of size_t.
3021 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3024 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3026 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3029 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3031 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3032 This makes this file independent of the recent pseudovector change.
3034 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3036 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3038 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3039 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3040 Remove unused local.
3041 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3043 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3044 GCC 4.6.0 optimizes based on type-based alias analysis.
3045 For example, if b is of type struct buffer * and v of type struct
3046 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3047 != &v->size, and therefore "v->size = 1; b->size = 2; return
3048 v->size;" must therefore return 1. This assumption is incorrect
3049 for Emacs, since it type-puns struct Lisp_Vector * with many other
3050 types. To fix this problem, this patch adds a new type struct
3051 vectorlike_header that documents the constraints on layout of vectors
3052 and pseudovectors, and helps optimizing compilers not get fooled
3053 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3054 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3055 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3057 (XSETPVECTYPE): Rewrite in terms of new macro.
3058 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3059 This is a bit clearer, and further avoids the possibility of
3060 undesirable aliasing.
3061 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3062 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3063 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3064 since Lisp_Subr is a special case (no "next" field).
3065 (ASIZE): Now uses header.size rather than size.
3066 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3067 to avoid the hassle of writing XVECTOR (foo)->header.size.
3068 (struct vectorlike_header): New type.
3069 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3070 object, to help avoid aliasing.
3071 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3072 (SUBRP): Likewise, since Lisp_Subr is a special case.
3073 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3074 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3075 (struct Lisp_Hash_Table): Combine first two members into a single
3076 struct vectorlike_header member. All uses of "size" and "next" members
3077 changed to be "header.size" and "header.next".
3078 * buffer.h (struct buffer): Likewise.
3079 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3080 * frame.h (struct frame): Likewise.
3081 * process.h (struct Lisp_Process): Likewise.
3082 * termhooks.h (struct terminal): Likewise.
3083 * window.c (struct save_window_data, struct saved_window): Likewise.
3084 * window.h (struct window): Likewise.
3085 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3086 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3087 * buffer.c (init_buffer_once): Likewise.
3088 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3090 * process.c (Fformat_network_address): Use local var for size,
3093 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3095 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3096 * data.c (atof): Remove decl; no longer used or needed.
3097 (digit_to_number): Move to lread.c.
3098 (Fstring_to_number): Use new string_to_number function, to be
3099 consistent with how the Lisp reader treats infinities and NaNs.
3100 Do not assume that floating-point numbers represent EMACS_INT
3101 without losing information; this is not true on most 64-bit hosts.
3102 Avoid double-rounding errors, by insisting on integers when
3103 parsing non-base-10 numbers, as the documentation specifies.
3104 * lisp.h (string_to_number): New decl, replacing ...
3105 (isfloat_string): Remove.
3106 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3107 (read1): Do not accept +. and -. as integers; this
3108 appears to have been a coding error. Similarly, do not accept
3109 strings like +-1e0 as floating point numbers. Do not report
3110 overflow for integer overflows unless the base is not 10 which
3111 means we have no simple and reliable way to continue.
3112 Break out the floating-point parsing into a new
3113 function string_to_number, so that Fstring_to_number parses
3114 floating point numbers consistently with the Lisp reader.
3115 (digit_to_number): Move here from data.c. Make it static inline.
3116 (E_CHAR, EXP_INT): Remove, replacing with ...
3117 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3118 (string_to_number): New function, replacing isfloat_string.
3119 This function checks for valid syntax and produces the resulting
3120 Lisp float number too. Rework it so that string-to-number
3121 no longer mishandles examples like "1.0e+". Use strtoumax,
3122 so that overflow for non-base-10 numbers is reported only when
3123 there's no portable and simple way to convert to floating point.
3125 * textprop.c (set_text_properties_1): Rewrite for clarity,
3126 and to avoid GCC warning about integer overflow.
3128 * intervals.h (struct interval): Use EMACS_INT for members
3129 where EMACS_UINT might cause problems. See
3130 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3131 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3132 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3134 (offset_intervals): Tell GCC not to worry about length overflow
3135 when negating a negative length.
3137 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3138 (overrun_check_free): Likewise.
3140 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3141 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3144 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3145 (gnutls_make_error): Rename local to avoid shadowing.
3146 (gnutls_emacs_global_deinit): ifdef out; not used.
3147 (Fgnutls_boot): Use const for pointer to readonly storage.
3148 Comment out unused local. Fix pointer signedness problems.
3150 * lread.c (openp): Don't stuff size_t into an 'int'.
3151 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3152 about possible signed overflow.
3154 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3155 (GDK_KEY_g): Don't define if already defined.
3156 (xg_prepare_tooltip): Avoid pointer signedness problem.
3157 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3159 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3160 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3162 * xfns.c (Fx_window_property): Simplify a bit,
3163 to make a bit faster and to avoid GCC 4.6.0 warning.
3164 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3166 * fns.c (internal_equal): Don't assume size_t fits in int.
3168 * alloc.c (compact_small_strings): Tighten assertion a little.
3170 Replace pEd with more-general pI, and fix some printf arg casts.
3171 * lisp.h (pI): New macro, generalizing old pEd macro to other
3172 conversion specifiers. For example, use "...%"pI"d..." rather
3173 than "...%"pEd"...".
3174 (pEd): Remove. All uses replaced with similar uses of pI.
3175 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3176 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3177 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3178 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3179 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3180 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3181 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3183 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3184 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3185 * print.c (safe_debug_print, print_object): Likewise.
3186 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3188 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3189 avoiding the 0 flag, which is not portable.
3190 * process.c (Fmake_network_process): Use pI to avoid cast.
3191 * region-cache.c (pp_cache): Likewise.
3192 * xdisp.c (decode_mode_spec): Likewise.
3193 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3194 behavior on 64-bit hosts with printf arg.
3195 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3196 (x_stop_queuing_selection_requests): Likewise.
3197 (x_get_window_property): Don't truncate byte count to an 'int'
3200 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3201 here, since it parses constructs like leading '-' and spaces,
3202 which are not wanted; and it overflows with large numbers.
3203 Instead, simply match F[0-9]+, which is what is wanted anyway.
3205 * alloc.c: Remove unportable assumptions about struct layout.
3206 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3207 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3208 (allocate_vectorlike, make_pure_vector): Use the new macros,
3209 plus offsetof, to remove unportable assumptions about struct layout.
3210 These assumptions hold on all porting targets that I know of, but
3211 they are not guaranteed, they're easy to remove, and removing them
3212 makes further changes easier.
3214 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3215 This doesn't fix a bug but makes the code clearer.
3216 (string_overrun_cookie): Now const. Use initializers that
3217 don't formally overflow signed char, to avoid warnings.
3218 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3219 can cause Emacs to crash when string overrun checking is enabled.
3220 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3221 multiple of sizeof (EMACS_INT); it need not be, if
3222 alignof(EMACS_INT) < sizeof (EMACS_INT).
3223 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3225 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3227 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3229 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3231 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3232 supposed to be handshaking. (Bug#8556)
3233 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3235 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3237 * lisp.h (Qdebug): List symbol.
3238 * eval.c (Qdebug): Restore global linkage.
3239 * keyboard.c (debug-on-event): New variable.
3240 (handle_user_signal): Break into debugger when debug-on-event
3241 matches the current signal symbol.
3243 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3245 * alloc.c (check_sblock, check_string_bytes)
3246 (check_string_free_list): Convert to standard C.
3248 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3250 * w32.c (emacs_gnutls_push): Fix typo.
3252 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3254 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3255 "cast to pointer from integer of different size".
3257 Improve doprnt and its use in verror. (Bug#8545)
3258 * doprnt.c (doprnt): Document the set of format control sequences
3259 supported by the function. Use SAFE_ALLOCA instead of always
3262 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3263 is one byte too soon. Don't use xrealloc; instead xfree and
3266 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3268 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3271 * gnutls.c: Renamed global_initialized to
3272 gnutls_global_initialized. Added internals for the
3273 :verify-hostname-error, :verify-error, and :verify-flags
3274 parameters of `gnutls-boot' and documented those parameters in the
3275 docstring. Start callback support.
3276 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3277 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3278 on error. Return error code.
3279 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3280 (emacs_gnutls_read): Likewise.
3281 (Fgnutls_boot): Return handshake error code.
3282 (emacs_gnutls_handle_error): New function.
3283 (wsaerror_to_errno): Likewise.
3285 * w32.h (emacs_gnutls_pull): Add prototype.
3286 (emacs_gnutls_push): Likewise.
3288 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3289 (emacs_gnutls_push): Likewise.
3291 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3293 * process.c (wait_reading_process_output): Check if GnuTLS
3294 buffered some data internally if no FDs are set for TLS
3297 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3298 (LIBS): Link to USER_LIBS.
3299 ($(BLD)/gnutls.$(0)): New target.
3301 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3303 * xdisp.c (handle_single_display_spec): Rename the
3304 display_replaced_before_p argument into display_replaced_p, to
3305 make it consistent with the commentary. Fix typos in the
3308 * textprop.c (syms_of_textprop): Remove dead code.
3309 (copy_text_properties): Delete obsolete commentary about an
3310 interface that was deleted long ago. Fix typos in the description
3313 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3314 to changes in oldXMenu/XMenu.h from 2011-04-16.
3315 <menu_help_message, prev_menu_help_message>: Constify.
3316 (IT_menu_make_room): menu->help_text is now `const char **';
3319 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3320 to changes in oldXMenu/XMenu.h from 2011-04-16.
3321 (struct XMenu): Declare `help_text' `const char **'.
3323 * xfaces.c <Qunspecified>: Make extern again.
3325 * syntax.c: Include sys/types.h before including regex.h, as
3328 * doc.c (get_doc_string): Improve the format passed to `error'.
3330 * doprnt.c (doprnt): Improve commentary.
3332 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3334 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3337 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3338 changes in globals.h immediately force recompilation.
3339 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3340 $(CURDIR)/s/ms-w32.h.
3341 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3343 * character.c (Fchar_direction): Function deleted.
3344 (syms_of_character): Don't defsubr it.
3345 <char-direction-table>: Deleted.
3347 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3349 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3350 * doprnt.c: Include limits.h.
3351 (SIZE_MAX): New macro.
3352 (doprnt): Return a size_t value. 2nd arg is now size_t.
3353 Many local variables are now size_t instead of int or unsigned.
3354 Improve overflow protection. Support `l' modifier for integer
3355 conversions. Support %l conversion. Don't assume an EMACS_INT
3356 argument for integer conversions and for %c.
3358 * lisp.h (doprnt): Restore prototype.
3360 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3363 * Makefile.in (base_obj): Add back doprnt.o.
3365 * deps.mk (doprnt.o): Add back prerequisites.
3366 (callint.o): Depend on character.h.
3368 * eval.c (internal_lisp_condition_case): Include the handler
3369 representation in the error message.
3370 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3371 when breaking from the loop.
3373 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3375 * callint.c (Fcall_interactively): When displaying error message
3376 about invalid control letter, pass the character's codepoint, not
3377 a pointer to its multibyte form. Improve display of the character
3378 in octal and display also its hex code.
3380 * character.c (char_string): Use %x to display the (unsigned)
3381 codepoint of an invalid character, to avoid displaying a bogus
3384 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3385 `error', not SYMBOL_NAME itself.
3387 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3388 character arguments to `error'.
3390 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3391 to `error' in error message about FINAL_CHAR argument. Make sure
3392 FINAL_CHAR is a character, and use %c when it is passed as
3393 argument to `error'.
3395 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3397 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3399 * w32.c: Include <time.h>.
3400 (sys_localtime): New function.
3402 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3404 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3406 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3408 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3410 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3413 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3415 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3416 gl_state.e_property when gl_state.object is Qt.
3418 * insdel.c (make_gap_larger): Remove limitation of buffer size
3421 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3423 * xdisp.c (lookup_glyphless_char_display)
3424 (produce_glyphless_glyph): Handle cons cell entry in
3425 glyphless-char-display.
3426 (Vglyphless_char_display): Document it.
3428 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3429 glyphless-char-display.
3431 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3433 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3435 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3437 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3438 definition for no-X builds.
3440 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3442 Static checks with GCC 4.6.0 and non-default toolkits.
3444 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3446 * process.c (keyboard_bit_set): Define only if SIGIO.
3447 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3448 (send_process): Repair possible setjmp clobbering.
3450 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3452 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3454 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3456 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3457 Define only if needed.
3459 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3460 by pacifying GCC about it. Maybe it's time to retire it?
3461 * xfaces.c (USG, __TIMEVAL__): Likewise.
3463 * dispextern.h (struct redisplay_interface): Rename param
3465 * termhooks.h (struct terminal): Likewise.
3466 * xterm.c (xembed_send_message): Likewise.
3468 * insdel.c (make_gap_smaller): Define only if
3469 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3471 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3474 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3475 so that we aren't warned about unused symbols.
3477 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3479 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3481 * xfns.c (x_real_positions): Mark locals as initialized.
3483 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3485 * xterm.c: Fix problems found by static analysis with other toolkits.
3486 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3487 (x_dispatch_event): Declare static if USE_GTK, and
3488 define if USE_GTK || USE_X_TOOLKIT.
3489 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3490 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3491 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3492 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3494 * xmenu.c (menu_help_callback): Pointer type fixes.
3495 Use const pointers when pointing at readonly data. Avoid pointer
3497 (FALSE): Remove unused macro.
3498 (update_frame_menubar): Remove unused decl.
3500 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3502 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3503 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3504 (single_menu_item): Rename local to avoid shadowing.
3506 * keyboard.c (make_lispy_event): Remove unused local var.
3508 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3509 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3511 * bitmaps: Change bitmaps from unsigned char back to the X11
3512 compatible char. Avoid the old compiler warnings about
3513 out-of-range initializers by using, for example, '\xab' rather
3516 * xgselect.c (xgselect_initialize): Check vs interface
3517 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3519 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3521 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3522 to read-only memory.
3524 * fns.c (vector): Remove; this old hack is no longer needed.
3526 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3528 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3530 * xrdb.c (x_load_resources): Omit unused local.
3532 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3533 (x_window): Rename locals to avoid shadowing.
3534 (USG): Use the kludged USG macro, to pacify gcc.
3536 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3537 (x_term_init): Remove local to avoid shadowing.
3539 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3541 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3542 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3544 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3546 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3548 Fix regex.c, syntax.c and friends for buffers > 2GB.
3549 * syntax.h (struct gl_state_s): Declare character position members
3552 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3554 * textprop.c (verify_interval_modification, interval_of):
3555 Declare arguments EMACS_INT.
3557 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3560 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3562 * indent.c (Fvertical_motion): Local variable it_start is now
3565 * regex.c (re_match, re_match_2, re_match_2_internal)
3566 (bcmp_translate, regcomp, regexec, print_double_string)
3567 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3568 (re_compile_pattern, re_exec): Declare arguments and local
3569 variables `size_t' and `ssize_t' and return values `regoff_t', as
3571 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3572 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3573 <compile_stack_type>: `size' and `avail' are now `size_t'.
3575 * regex.h <regoff_t>: Use ssize_t, not int.
3576 (re_search, re_search_2, re_match, re_match_2): Arguments that
3577 specify buffer/string position and length are now ssize_t and
3578 size_t. Return type is regoff_t.
3580 2011-04-16 Ben Key <bkey76@gmail.com>
3582 * nsfont.m: Fixed bugs in ns_get_family and
3583 ns_descriptor_to_entity that were caused by using free to
3584 deallocate memory blocks that were allocated by xmalloc (via
3585 xstrdup). This caused Emacs to crash when compiled with
3586 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3587 --enable-checking=xmallocoverrun). xfree is now used to
3588 deallocate these memory blocks.
3590 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3592 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3594 emacs_write: Accept and return EMACS_INT for sizes.
3595 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3597 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3598 Accept and return EMACS_INT.
3599 (emacs_gnutls_write): Return the number of bytes written on
3601 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3602 (emacs_read, emacs_write): Remove check for negative size, as the
3603 Emacs source code has been audited now.
3604 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3605 (emacs_read, emacs_write): Use it.
3606 * process.c (send_process): Adjust to the new signatures of
3607 emacs_write and emacs_gnutls_write. Do not attempt to store
3608 a byte offset into an 'int'; it might overflow.
3609 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3611 * sound.c: Don't assume sizes fit in 'int'.
3612 (struct sound_device.period_size, alsa_period_size):
3613 Return EMACS_INT, not int.
3614 (struct sound_device.write, vox_write, alsa_write):
3615 Accept EMACS_INT, not int.
3616 (wav_play, au_play): Use EMACS_INT to store sizes and to
3617 record read return values.
3619 2011-04-15 Ben Key <bkey76@gmail.com>
3621 * keyboard.c (Qundefined): Don't declare static since it is used
3623 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3624 static since they are used in nsfont.m.
3626 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3628 * process.c (Qprocessp): Don't declare static.
3629 * lisp.h (Qprocessp): Declare again.
3631 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3633 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3635 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3637 Improve C-level modularity by making more things 'static'.
3639 Don't publish debugger-only interfaces to other modules.
3640 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3641 (verify_bytepos, count_markers): Move decls to the only modules
3643 * region-cache.h (pp_cache): Likewise.
3644 * window.h (check_all_windows): Likewise.
3645 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3647 * sysdep.c (croak): Now static, if
3648 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3649 * syssignal.h (croak): Declare only if not static.
3651 * alloc.c (refill_memory_reserve): Now static if
3652 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3653 * lisp.h (refill_memory_reserve): Declare only if not static.
3655 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3656 Define only if USE_LUCID.
3658 * xrdb.c (x_customization_string, x_rm_string): Now static.
3660 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3661 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3663 * xdisp.c (draw_row_with_mouse_face): Now static.
3664 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3666 * window.h (check_all_windows): Mark externally visible.
3668 * window.c (window_deletion_count): Now static.
3670 * undo.c: Make symbols static if they're not exported.
3671 (last_undo_buffer, last_boundary_position, pending_boundary):
3674 * textprop.c (interval_insert_behind_hooks): Now static.
3675 (interval_insert_in_front_hooks): Likewise.
3677 * term.c: Make symbols static if they're not exported.
3678 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3679 (max_frame_lines, tty_set_terminal_modes):
3680 (tty_reset_terminal_modes, tty_turn_off_highlight):
3681 (get_tty_terminal): Now static.
3682 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3683 * termhooks.h (term_mouse_moveto): Do not declare if
3685 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3686 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3688 * sysdep.c: Make symbols static if they're not exported.
3689 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3691 (sigprocmask_set, full_mask): Remove; unused.
3692 (wait_debugging): Mark as visible.
3693 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3694 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3696 * syntax.c (syntax_temp): Define only if !__GNUC__.
3698 * sound.c (current_sound_device, current_sound): Now static.
3700 * search.c (searchbufs, searchbuf_head): Now static.
3702 * scroll.c (scroll_cost): Remove; unused.
3703 * dispextern.h (scroll_cost): Remove decl.
3705 * region-cache.h (pp_cache): Mark as externally visible.
3707 * process.c: Make symbols static if they're not exported.
3708 (process_tick, update_tick, create_process, chan_process):
3709 (Vprocess_alist, proc_buffered_char, datagram_access):
3710 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3711 (deactivate_process): Mark defn as static, as well as decl.
3712 * lisp.h (create_process): Remove decl.
3713 * process.h (chan_process, Vprocess_alist): Remove decls.
3715 * print.c: Make symbols static if they're not exported.
3716 (print_depth, new_backquote_output, being_printed, print_buffer):
3717 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3718 (print_interval, print_number_index, initial_stderr_stream):
3720 * lisp.h (Fprinc): Remove decl.
3721 (debug_output_compilation_hack): Mark as externally visible.
3723 * sysdep.c (croak): Move decl from here to syssignal.h.
3724 * syssignal.h (croak): Put it here, so the API can be checked when
3725 'croak' is called from dissociate_if_controlling_tty.
3727 * minibuf.c: Make symbols static if they're not exported.
3728 (minibuf_save_list, choose_minibuf_frame): Now static.
3729 * lisp.h (choose_minibuf_frame): Remove decl.
3731 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3733 * lread.c: Make symbols static if they're not exported.
3734 (read_objects, initial_obarray, oblookup_last_bucket_number):
3736 (make_symbol): Remove; unused.
3737 * lisp.h (initial_obarray, make_symbol): Remove decls.
3739 * keyboard.c: Make symbols static if they're not exported.
3740 (single_kboard, recent_keys_index, total_keys, recent_keys):
3741 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3742 (this_single_command_key_start, echoing, last_auto_save):
3743 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3744 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3745 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3746 (Vlispy_mouse_stem, double_click_count):
3748 (force_auto_save_soon): Define only if SIGDANGER.
3749 (ignore_mouse_drag_p): Now static if
3750 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3751 (print_help): Remove; unused.
3752 (stop_character, last_timer_event): Mark as externally visible.
3753 * keyboard.h (ignore_mouse_drag_p): Declare only if
3754 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3755 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3756 * lisp.h (echoing): Remove decl.
3757 (force_auto_save_soon): Declare only if SIGDANGER.
3758 * xdisp.c (redisplay_window): Simplify code, to make it more
3759 obvious that ignore_mouse_drag_p is not accessed if !defined
3760 USE_GTK && !defined HAVE_NS.
3762 * intervals.c: Make symbols static if they're not exported.
3763 (merge_properties_sticky, merge_interval_right, delete_interval):
3765 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3767 * insdel.c: Make symbols static if they're not exported.
3768 However, leave prepare_to_modify_buffer alone. It's never
3769 called from outside this function, but that appears to be a bug.
3770 (combine_after_change_list, combine_after_change_buffer):
3771 (adjust_after_replace, signal_before_change): Now static.
3772 (adjust_after_replace_noundo): Remove; unused.
3773 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3774 (signal_before_change): Remove decls.
3776 * indent.c (val_compute_motion, val_vmotion): Now static.
3778 * image.c: Make symbols static if they're not exported.
3779 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3781 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3782 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3784 * fringe.c (standard_bitmaps): Now static.
3785 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3787 * frame.c: Make symbols static if they're not exported.
3788 (x_report_frame_params, make_terminal_frame): Now static.
3789 (get_frame_param): Now static, unless HAVE_NS.
3790 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3791 (x_get_resource_string): Remove; not used.
3792 * frame.h (make_terminal_frame, x_report_frame_params):
3793 (x_get_resource_string); Remove decls.
3794 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3795 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3797 * font.c, fontset.c: Make symbols static if they're not exported.
3798 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3799 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3800 * font.c (font_close_object): Now static.
3801 * font.h (font_close_object): Remove.
3802 * fontset.c (FONTSET_OBJLIST): Remove.
3803 (free_realized_fontset) #if-0 the body, which does nothing.
3804 (face_suitable_for_char_p): #if-0, as it's never called.
3805 * fontset.h (face_suitable_for_char_p): Remove decl.
3806 * xfaces.c (face_at_string_position):
3807 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3808 since 0 is always ASCII.
3810 * fns.c (weak_hash_tables): Now static.
3812 * fileio.c: Make symbols static if they're not exported.
3813 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3814 (Vwrite_region_annotation_buffers): Now static.
3816 * eval.c: Make symbols static if they're not exported.
3817 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3818 * lisp.h (backtrace_list): Remove decl.
3820 * emacs.c: Make symbols static if they're not exported.
3821 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3822 (fatal_error_code, fatal_error_signal_hook, standard_args):
3824 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3825 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3826 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3827 * lisp.h (fatal_error_signal_hook): Remove decl.
3828 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3830 * editfns.c: Move a (normally-unused) function to its only use.
3831 * editfns.c, lisp.h (get_operating_system_release): Remove.
3832 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3833 worth the hassle of breaking this out.
3835 * xterm.c: Make symbols static if they're not exported.
3836 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3837 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3838 (x_destroy_window, x_delete_display):
3840 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3841 (x_mouse_leave): Remove; unused.
3842 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3843 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3844 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3846 (x_mouse_leave): Declare only if WINDOWSNT.
3847 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3848 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3851 * ftxfont.c: Make symbols static if they're not exported.
3852 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3854 * font.h (ftxfont_driver): Likewise.
3856 * xfns.c: Make symbols static if they're not exported.
3857 (x_last_font_name, x_display_info_for_name):
3858 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3859 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3860 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3861 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3862 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3863 (last_show_tip_args): Now static.
3864 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3865 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3866 (x_screen_planes): Remove; unused.
3867 * dispextern.h (x_screen_planes): Remove decl.
3869 * dispnew.c: Make symbols static if they're not exported.
3870 * dispextern.h (redraw_garbaged_frames, scrolling):
3871 (increment_row_positions): Remove.
3872 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3873 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3875 (redraw_garbaged_frames): Remove; unused.
3877 * xfaces.c: Make symbols static if they're not exported.
3878 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3880 * xterm.h (defined_color): Remove decls.
3881 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3882 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3883 (menu_face_changed_default, defined_color, free_realized_face):
3884 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3885 (ascii_face_of_lisp_face): Remove; unused.
3887 * xdisp.c: Make symbols static if they're not exported.
3888 * dispextern.h (scratch_glyph_row, window_box_edges):
3889 (glyph_to_pixel_coords, set_cursor_from_row):
3890 (get_next_display_element, set_iterator_to_next):
3891 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3892 (show_mouse_face): Remove decls
3893 * frame.h (message_buf_print): Likewise.
3894 * lisp.h (pop_message, set_message, check_point_in_composition):
3896 * xterm.h (set_vertical_scroll_bar): Likewise.
3897 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3898 (message_buf_print, scratch_glyph_row, displayed_buffer):
3899 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3900 (get_next_display_element, show_mouse_face, window_box_edges):
3901 (frame_to_window_pixel_xy, check_point_in_composition):
3902 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3903 (glyph_to_pixel_coords): Remove; unused.
3905 * dired.c (file_name_completion): Now static.
3907 * dbusbind.c (xd_in_read_queued_messages): Now static.
3909 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3910 * data.c (circular_list_error): Remove.
3912 * commands.h (last_point_position, last_point_position_buffer):
3913 (last_point_position_window): Remove decls.
3914 * keyboard.c: Make these variables static.
3916 * coding.h (coding, code_convert_region, encode_coding_gap):
3918 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3919 (iso_code_class, detect_coding, code_convert_region): Now static.
3920 (encode_coding_gap): Remove; unused.
3922 * chartab.c (chartab_chars, chartab_bits): Now static.
3924 * charset.h (charset_iso_8859_1): Remove decl.
3925 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3928 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3929 * ccl.c (Vccl_program_table): Now static.
3930 (check_ccl_update): Remove; unused.
3932 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3933 * category.h: ... from here.
3934 * category.c (check_category_table, set_category_set): Now static.
3936 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3937 * lisp.h: Remove these decls.
3939 * buffer.c (buffer_count): Remove unused var.
3941 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3942 so that it's not optimized away.
3943 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3944 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3945 exported only to the debugger.
3947 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3948 * atimer.h (run_all_atimers): Remove; not exported.
3950 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3951 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3952 was inaccessible from Lisp.
3953 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3954 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3956 alloc.c: Import and export fewer symbols, and remove unused items.
3957 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3959 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3960 it's not optimized away by whole-program optimization.
3961 (message_enable_multibyte, free_misc): Remove.
3962 (catchlist, handlerlist, mark_backtrace):
3963 Declare only if BYTE_MARK_STACK.
3964 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3965 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3966 (message_enable_multibyte): Remove decl.
3967 (free_misc, interval_free_list, float_block, float_block_index):
3968 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3969 (cons_free_list, last_marked_index):
3971 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3972 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3973 (mark_backtrace): Define only if BYTE_MARK_STACK.
3974 * xdisp.c (message_enable_multibyte): Now static.
3976 Declare Lisp_Object Q* variables to be 'static' if not exported.
3977 This makes it easier for human readers (and static analyzers)
3978 to see whether these variables are used from other modules.
3979 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3980 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3981 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3982 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3983 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3984 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3985 * xmenu.c, xselect.c:
3986 Declare Q* vars static if they are not used in other modules.
3987 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3988 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3989 Remove decls of unexported vars.
3990 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3992 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3994 Make Emacs functions such as Fatom 'static' by default.
3995 This makes it easier for human readers (and static analyzers)
3996 to see whether these functions can be called from other modules.
3997 DEFUN now defines a static function. To make the function external
3998 so that it can be used in other C modules, use the new macro DEFUE.
3999 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4000 (Finit_image_library):
4001 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4002 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4003 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4004 Remove decls, since these functions are now static.
4005 (Funintern, Fget_internal_run_time): New decls, since these functions
4006 were already external.
4008 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4009 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4010 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4011 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4012 * keyboard.c, keymap.c, lread.c:
4013 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4014 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4015 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4016 Mark functions with DEFUE instead of DEFUN,
4017 if they are used in other modules.
4018 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4019 decls for now-static functions.
4020 * buffer.h (Fdelete_overlay): Remove decl.
4021 * callproc.c (Fgetenv_internal): Mark as internal.
4022 * composite.c (Fremove_list_of_text_properties): Remove decl.
4023 (Fcomposition_get_gstring): New forward static decl.
4024 * composite.h (Fcomposite_get_gstring): Remove decl.
4025 * dired.c (Ffile_attributes): New forward static decl.
4026 * doc.c (Fdocumntation_property): New forward static decl.
4027 * eval.c (Ffetch_bytecode): New forward static decl.
4028 (Funintern): Remove extern decl; now in .h file where it belongs.
4029 * fileio.c (Fmake_symbolic_link): New forward static decl.
4030 * image.c (Finit_image_library): New forward static decl.
4031 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4032 * intervals.h (Fprevious_property_change):
4033 (Fremove_list_of_text_properties): Remove decls.
4034 * keyboard.c (Fthis_command_keys): Remove decl.
4035 (Fcommand_execute): New forward static decl.
4036 * keymap.c (Flookup_key): New forward static decl.
4037 (Fcopy_keymap): Now static.
4038 * keymap.h (Flookup_key): Remove decl.
4039 * process.c (Fget_process): New forward static decl.
4040 (Fprocess_datagram_address): Mark as internal.
4041 * syntax.c (Fsyntax_table_p): New forward static decl.
4042 (skip_chars): Remove duplicate decl.
4043 * textprop.c (Fprevious_property_change): New forward static decl.
4044 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4046 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4047 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4049 * editfns.c (Fformat): Remove unreachable code.
4051 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4053 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4056 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4058 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4059 when at ZV. (Bug#8487)
4061 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4063 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4065 * keyboard.c (parse_tool_bar_item): Likewise.
4066 * sound.c (sound_cleanup, alsa_close): Likewise.
4067 * termcap.c (tgetent): Likewise.
4068 * xfns.c (x_default_font_parameter): Likewise.
4069 * xsettings.c (read_and_apply_settings): Likewise.
4071 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4072 (overrun_check_free): Protoize.
4074 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4076 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4077 since callers should never pass a negative size.
4078 Change the signature to match that of plain 'read' and 'write'; see
4079 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4080 * lisp.h: Update prototypes of emacs_write and emacs_read.
4082 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4084 * xdisp.c (redisplay_window): Don't try to determine the character
4085 position of the scroll margin if the window start point w->startp
4086 is outside the buffer's accessible region. (Bug#8468)
4088 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4090 Fix write-region and its subroutines for buffers > 2GB.
4091 * fileio.c (a_write, e_write): Modify declaration of arguments and
4092 local variables to support buffers larger than 2GB.
4093 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4095 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4096 argument, local variables, and return value.
4098 * lisp.h: Update prototypes of emacs_write and emacs_read.
4100 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4102 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4104 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4106 Fix more problems found by GCC 4.6.0's static checks.
4108 * xdisp.c (vmessage): Use a better test for character truncation.
4110 * charset.c (load_charset_map): <, not <=, for optimization,
4111 and to avoid potential problems with integer overflow.
4112 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4113 * casetab.c (set_identity, shuffle): Likewise.
4114 * editfns.c (Fformat): Likewise.
4115 * syntax.c (skip_chars): Likewise.
4117 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4118 This also lets GCC 4.6.0 generate slightly better loop code.
4120 * callint.c (Fcall_interactively): <, not <=, for optimization.
4121 (Fcall_interactively): Count the number of arguments produced,
4122 not the number of arguments given. This is simpler and lets GCC
4123 4.6.0 generate slightly better code.
4125 * ftfont.c: Distingish more carefully between FcChar8 and char.
4126 The previous code passed unsigned char * to a functions like
4127 strlen and xstrcasecmp that expect char *, which does not
4128 conform to the C standard.
4129 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4130 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4131 char * when the C standard requires it.
4133 * keyboard.c (read_char): Remove unused var.
4135 * eval.c: Port to Windows vsnprintf (Bug#8435).
4137 (SIZE_MAX): Define if the headers do not.
4138 (verror): Do not give up if vsnprintf returns a negative count.
4139 Instead, grow the buffer. This ports to Windows vsnprintf, which
4140 does not conform to C99. Problem reported by Eli Zaretskii.
4141 Also, simplify the allocation scheme, by avoiding the need for
4142 calling realloc, and removing the ALLOCATED variable.
4144 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4146 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4147 But keep the doprint source code for now, as we might revamp it
4148 and use it again (Bug#8435).
4149 * lisp.h (doprnt): Remove.
4150 * Makefile.in (base_obj): Remove doprnt.o.
4151 * deps.mk (doprnt.o): Remove.
4153 error: Print 32- and 64-bit integers portably (Bug#8435).
4154 Without this change, on typical 64-bit hosts error ("...%d...", N)
4155 was used to print both 32- and 64-bit integers N, which relied on
4157 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4159 * lisp.h (error, verror): Mark as printf-like functions.
4160 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4161 Report overflow in size calculations when allocating printf buffer.
4162 Do not truncate output string at its first null byte.
4163 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4164 Truncate the output at a character boundary, since vsnprintf does not
4166 * charset.c (check_iso_charset_parameter): Convert internal
4167 character to string before calling 'error', since %c now has the
4169 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4170 overflow when computing char to be passed to 'error'. Do not
4171 pass Lisp_Object to 'error'; pass the integer instead.
4172 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4173 formatted with plain %d.
4175 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4177 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4179 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4181 * xterm.c (x_catch_errors): Remove duplicate declaration.
4183 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4185 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4187 2011-04-10 Jim Meyering <meyering@redhat.com>
4189 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4190 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4191 return ssize_t not "int", and use size_t as the buffer length.
4192 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4193 * gnutls.h: Update declarations.
4194 * process.c (read_process_output): Use ssize_t, to match.
4195 (send_process): Likewise.
4197 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4199 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4201 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4203 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4204 Use unsigned char, to match FcChar8 type definition.
4206 * xterm.c (handle_one_xevent):
4207 * xmenu.c (create_and_show_popup_menu):
4208 * xselect.c (x_decline_selection_request)
4209 (x_reply_selection_request): Avoid type-punned deref of X events.
4211 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4213 Fix some uses of `int' instead of EMACS_INT.
4214 * search.c (string_match_1, fast_string_match)
4215 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4216 (scan_buffer, find_next_newline_no_quit)
4217 (find_before_next_newline, search_command, Freplace_match)
4218 (Fmatch_data): Make some `int' variables be EMACS_INT.
4220 * xdisp.c (display_count_lines): 3rd argument and return value now
4221 EMACS_INT. All callers changed.
4222 (pint2hrstr): Last argument is now EMACS_INT.
4224 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4225 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4226 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4227 (decode_coding_utf_16, decode_coding_emacs_mule)
4228 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4229 (decode_coding_ccl, decode_coding_charset)
4230 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4231 (decode_coding_iso_2022, decode_coding_emacs_mule)
4232 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4233 <char_offset, last_offset>: Declare EMACS_INT.
4234 (encode_coding_utf_8, encode_coding_utf_16)
4235 (encode_coding_emacs_mule, encode_invocation_designation)
4236 (encode_designation_at_bol, encode_coding_iso_2022)
4237 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4238 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4240 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4241 (encode_invocation_designation): Last argument P_NCHARS is now
4243 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4244 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4246 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4249 * ccl.c (Fccl_execute_on_string): Declare some variables
4252 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4254 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4256 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4258 * process.c (Fformat_network_address): Doc fix.
4260 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4262 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4264 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4266 * keyboard.c (read_char): Call Lisp function help-form-show,
4267 instead of using internal_with_output_to_temp_buffer.
4268 (Qhelp_form_show): New var.
4269 (syms_of_keyboard): Use DEFSYM macro.
4271 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4273 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4275 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4277 * process.c (Flist_processes): Remove to Lisp.
4278 (list_processes_1): Delete.
4280 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4282 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4284 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4286 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4288 Fix more problems found by GCC 4.6.0's static checks.
4290 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4292 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4294 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4296 * xdisp.c (vmessage): Mark as a printf-like function.
4298 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4300 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4302 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4303 printf-like functions.
4304 (tiff_load): Add casts to remove these marks before passing them
4305 to system-supplied API.
4307 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4309 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4310 This avoids several warnings with gcc -Wstrict-overflow.
4311 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4312 directly, rather than having caller test rule sign. This avoids
4313 some unnecessary tests.
4314 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4315 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4316 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4318 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4319 (xfont_open): Avoid unnecessary tests.
4321 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4323 * composite.h, composite.c (composition_gstring_put_cache):
4324 Use EMACS_INT, not int, for length.
4326 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4327 breaking out part of COMPOSITION_DECODE_RULE.
4328 (COMPOSITION_DECODE_RULE): Use it.
4329 * composite.c (get_composition_id): Remove unused local vars,
4330 by using the new macro.
4332 * textprop.c (set_text_properties_1): Change while to do-while,
4333 since the condition is always true at first.
4335 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4336 (interval_deletion_adjustment): Return unsigned value.
4339 * process.c (list_processes_1, create_pty, read_process_output):
4340 (exec_sentinel): Remove vars that were set but not used.
4341 (create_pty): Remove unnecessary "volatile"s.
4342 (Fnetwork_interface_info): Avoid possibility of int overflow.
4343 (read_process_output): Do adaptive read buffering even if carryover.
4344 (read_process_output): Simplify nbytes computation if buffered.
4346 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4348 * syntax.c (scan_words): Remove var that was set but not used.
4349 (update_syntax_table): Use unsigned instead of int.
4351 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4352 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4353 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4355 * print.c (print_error_message): Avoid int overflow.
4357 * font.c (font_list_entities): Redo for clarity,
4358 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4360 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4361 (font_score): Avoid potential overflow in diff calculation.
4363 * fns.c (substring_both): Remove var that is set but not used.
4364 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4366 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4368 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4369 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4370 can always succeed if overflow has undefined behavior.
4372 * search.c (boyer_moore, wordify): Remove vars set but not used.
4373 (wordify): Omit three unnecessary tests.
4375 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4376 All callers changed. This avoids the need for an unused var.
4378 * casefiddle.c (casify_region): Remove var that is set but not used.
4380 * dired.c (file_name_completion): Remove var that is set but not used.
4382 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4384 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4385 (Finsert_file_contents): Remove unnecessary code checking fd.
4387 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4388 Check for integer overflow on size calculations.
4390 * buffer.c (Fprevious_overlay_change): Remove var that is set
4393 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4394 Remove vars that are set but not used.
4395 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4396 (timer_check_2): Mark vars as initialized.
4398 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4400 * image.c (lookup_image): Remove var that is set but not used.
4401 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4403 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4404 that are set but not used.
4406 * xfns.c (make_invisible_cursor): Don't return garbage
4407 if XCreateBitmapFromData fails (Bug#8410).
4409 * xselect.c (x_get_local_selection, x_handle_property_notify):
4410 Remove vars that are set but not used.
4412 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4413 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4415 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4416 Remove var that is set but not used.
4417 (scroll_bar_windows_size): Now size_t, not int.
4418 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4421 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4422 (map_tty_color) [!defined MSDOS]: Likewise.
4424 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4426 * coding.c: Remove vars that are set but not used.
4427 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4428 All callers changed.
4429 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4430 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4431 (decode_coding_charset): Remove vars that are set but not used.
4433 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4434 that is set but not used.
4436 * print.c (print_object): Remove var that is set but not used.
4438 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4439 The gnulib version avoids calling malloc in the usual case,
4440 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4441 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4442 * filelock.c (current_lock_owner): Likewise.
4443 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4444 * sysdep.c: Include allocator.h, careadlinkat.h.
4445 (emacs_no_realloc_allocator): New static constant.
4446 (emacs_readlink): New function.
4447 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4448 ../lib/careadlinkat.h.
4450 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4452 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4453 first non-nil return value).
4455 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4457 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4458 if not defined (Bug#8403).
4460 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4462 * xdisp.c (display_count_lines): Remove parameter `start',
4463 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4464 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4465 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4466 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4467 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4468 and thereabouts. All callers changed.
4469 (get_per_char_metric): Remove parameter `f', unused since
4470 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4472 2011-04-02 Jim Meyering <meyering@redhat.com>
4474 do not dereference NULL upon failed strdup
4475 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4476 (ns_get_family): Likewise.
4478 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4480 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4482 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4484 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4487 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4489 Add lexical binding.
4491 * window.c (Ftemp_output_buffer_show): New fun.
4492 (Fsave_window_excursion):
4493 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4495 * lread.c (lisp_file_lexically_bound_p): New function.
4496 (Fload): Bind Qlexical_binding.
4497 (readevalloop): Remove `evalfun' arg.
4498 Bind Qinternal_interpreter_environment.
4499 (Feval_buffer): Bind Qlexical_binding.
4500 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4502 (syms_of_lread): Declare `lexical-binding'.
4504 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4506 * keyboard.c (eval_dyn): New fun.
4507 (menu_item_eval_property): Use it.
4509 * image.c (parse_image_spec): Use Ffunctionp.
4511 * fns.c (concat, mapcar1): Accept byte-code-functions.
4513 * eval.c (Fsetq): Handle lexical vars.
4514 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4515 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4516 (FletX, Flet): Obey lexical binding.
4517 (Fcommandp): Handle closures.
4518 (Feval): New `lexical' arg.
4519 (eval_sub): New function extracted from Feval. Use it almost
4520 everywhere where Feval was used. Look up vars in lexical env.
4522 (Ffunctionp): Move from subr.el.
4523 (Ffuncall): Handle closures.
4524 (apply_lambda): Remove `eval_flags'.
4525 (funcall_lambda): Handle closures and new byte-code-functions.
4526 (Fspecial_variable_p): New function.
4527 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4528 but without exporting it to Lisp.
4530 * doc.c (Fdocumentation, store_function_docstring):
4531 * data.c (Finteractive_form): Handle closures.
4533 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4536 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4538 (exec_byte_code): New function extracted from Fbyte_code to handle new
4539 calling convention for byte-code-functions. Add new byte-codes.
4541 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4543 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4545 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4547 * xdisp.c (redisplay_internal): Fix prototype.
4549 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4551 * xdisp.c (SCROLL_LIMIT): New macro.
4552 (try_scrolling): Use it when setting scroll_limit.
4553 Limit scrolling to 100 screen lines.
4554 (redisplay_window): Even when falling back on "recentering",
4555 position point in the window according to scroll-conservatively,
4556 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4558 (try_scrolling): When point is above the window, allow searching
4559 as far as scroll_max, or one screenful, to compute vertical
4560 distance from PT to the scroll margin position. This prevents
4561 try_scrolling from unnecessarily failing when
4562 scroll-conservatively is set to a value slightly larger than the
4563 window height. Clean up the case of PT below the margin at bottom
4564 of window: scroll_max can no longer be INT_MAX. When aggressive
4565 scrolling is in use, don't let point enter the opposite scroll
4566 margin as result of the scroll.
4567 (syms_of_xdisp) <scroll-conservatively>: Document the
4568 threshold of 100 lines for never-recentering scrolling.
4570 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4572 * dispextern.h (move_it_by_lines):
4573 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4574 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4575 (message_log_check_duplicate): Remove parameters `prev_bol' and
4576 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4577 (redisplay_internal): Remove parameter `preserve_echo_area',
4578 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4580 * indent.c (Fvertical_motion):
4581 * window.c (window_scroll_pixel_based, Frecenter):
4582 Don't pass `need_y_p' to `move_it_by_lines'.
4584 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4586 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4587 steal a few bits to be more compact.
4588 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4589 Remove unneeded casts.
4591 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4593 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4595 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4596 binding" message (bug#7967).
4598 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4600 Fix more problems found by GCC 4.6.0's static checks.
4602 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4603 Remove unused local var.
4605 * editfns.c (Fmessage_box): Remove unused local var.
4607 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4608 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4609 Omit unused local vars.
4610 * window.c (shrink_windows): Omit unused local var.
4611 * menu.c (digest_single_submenu): Omit unused local var.
4612 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4613 Omit unused local var.
4615 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4616 Don't assume string length fits in int.
4617 (keyremap_step, read_key_sequence): Use size_t for sizes.
4618 (read_key_sequence): Don't check last_real_key_start redundantly.
4620 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4621 instead of alloca (Bug#8344).
4623 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4624 (Fbacktrace_frame): Don't assume nframes fits in int.
4626 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4628 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4631 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4633 * cm.c (calccost): Turn while-do into do-while, for clarity.
4635 * keyboard.c (syms_of_keyboard): Use the same style as later
4636 in this function when indexing through an array. This also
4637 works around GCC bug 48267.
4639 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4641 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4643 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4644 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4646 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4647 This avoids undefined behavior on integer overflow, and is a bit
4648 more convenient anyway since it is compared to a size_t variable.
4650 Variadic C functions now count arguments with size_t, not int.
4651 This avoids an unnecessary limitation on 64-bit machines, which
4652 caused (substring ...) to crash on large vectors (Bug#8344).
4653 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4654 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4655 All variadic functions and their callers changed accordingly.
4656 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4657 * data.c (arith_driver, float_arith_driver): Likewise.
4658 * editfns.c (general_insert_function): Likewise.
4659 * eval.c (struct backtrace.nargs, interactive_p)
4660 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4661 (funcall_lambda, mark_backtrace): Likewise.
4662 * fns.c (concat): Likewise.
4663 * frame.c (x_set_frame_parameters): Likewise.
4664 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4665 0 if not found, not -1. All callers changed.
4667 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4668 (stack_copy_size): Now size_t, not int.
4669 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4671 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4673 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4674 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4675 All callers changed.
4677 * lisp.h (multibyte_char_to_unibyte):
4678 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4679 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4680 * character.h (CHAR_TO_BYTE8):
4681 * cmds.c (internal_self_insert):
4682 * editfns.c (general_insert_function):
4683 * keymap.c (push_key_description):
4684 * search.c (Freplace_match):
4685 * xdisp.c (message_dolog, set_message_1): All callers changed.
4687 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4689 * keyboard.c (safe_run_hook_funcall): New function.
4690 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4691 don't set the hook to nil, but remove the offending function instead.
4692 (Qcommand_hook_internal): Remove, unused.
4693 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4694 Vcommand_hook_internal.
4696 * eval.c (enum run_hooks_condition): Remove.
4697 (funcall_nil, funcall_not): New functions.
4698 (run_hook_with_args): Call each function through a `funcall' argument.
4699 Remove `cond' argument, now redundant.
4700 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4701 (Frun_hook_with_args_until_failure): Adjust accordingly.
4702 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4704 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4706 * dispextern.h (string_buffer_position): Remove declaration.
4708 * print.c (strout): Remove parameter `multibyte', unused since
4709 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4711 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4712 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4713 All callers changed.
4715 * w32.c (_wsa_errlist): Use braces for struct initializers.
4717 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4718 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4719 All callers changed.
4720 (string_buffer_position): Likewise. Also, make static (it's never
4721 used outside xdisp.c).
4722 (cursor_row_p): Remove parameter `w', unused since
4723 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4724 (decode_mode_spec): Remove parameter `precision', introduced during
4725 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4726 All callers changed.
4728 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4730 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4732 2011-03-27 Anders Lindgren <andlind@gmail.com>
4734 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4735 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4736 (ns_update_auto_hide_menu_bar): New functions.
4737 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4738 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4739 ns_constrain_all_frames.
4740 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4741 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4743 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4745 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4747 2011-03-27 Glenn Morris <rgm@gnu.org>
4749 * syssignal.h: Replace RETSIGTYPE with void.
4750 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4751 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4752 Replace SIGTYPE with void everywhere.
4753 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4754 * s/template.h (SIGTYPE): Remove commented out definition.
4756 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4758 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4759 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4761 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4763 * w32.c (read_unc_volume): Use parameter `henum', instead of
4764 global variable `wget_enum_handle'.
4766 * keymap.c (describe_vector): Remove parameters `indices' and
4767 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4768 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4770 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4772 * keyboard.c (timer_check): Remove parameter `do_it_now',
4773 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4774 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4775 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4777 * keyboard.c (read_char):
4778 * w32menu.c (w32_menu_display_help):
4779 * xmenu.c (show_help_event, menu_help_callback):
4780 Adjust calls to `show_help_echo'.
4782 * gtkutil.c (xg_maybe_add_timer):
4783 * keyboard.c (readable_events):
4784 * process.c (wait_reading_process_output):
4785 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4787 * insdel.c (adjust_markers_gap_motion):
4788 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4789 (gap_left, gap_right): Don't call it.
4791 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4793 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4794 incurred during fontification.
4796 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4798 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4799 (DEFVAR_PER_BUFFER): Don't pass it.
4801 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4802 (scrolling_window): Don't pass it.
4804 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4806 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4808 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4810 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4811 of variables specific to SELinux and computation of `encoded_absname'.
4813 * image.c (XPutPixel): Remove unused variable `height'.
4815 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4817 * unexw32.c (get_section_info): Remove unused variable `section'.
4819 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4820 (system_process_attributes): Remove unused variable `sess'.
4821 (sys_read): Remove unused variable `err'.
4823 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4824 (w32_wnd_proc): Remove unused variable `isdead'.
4825 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4826 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4827 (x_create_tip_frame): Remove unused variable `tem'.
4829 * w32inevt.c (w32_console_read_socket):
4830 Remove unused variable `no_events'.
4832 * w32term.c (x_draw_composite_glyph_string_foreground):
4833 Remove unused variable `width'.
4835 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4837 * w32term.c (x_set_glyph_string_clipping):
4838 Don't pass uninitialized region to CombineRgn.
4840 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4842 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4843 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4844 (Fx_close_connection): Remove unused variable `i'.
4846 * w32font.c (w32font_draw): Return number of glyphs.
4847 (w32font_open_internal): Remove unused variable `i'.
4848 (w32font_driver): Add missing initializer.
4850 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4851 (fill_in_menu): Remove unused variable `items_added'.
4853 * w32term.c (last_mouse_press_frame): Remove static global variable.
4854 (w32_clip_to_row): Remove unused variable `f'.
4855 (x_delete_terminal): Remove unused variable `i'.
4857 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4858 (NOTHING): Remove unused static global variable.
4859 (uniscribe_check_otf): Remove unused variable `table'.
4860 (uniscribe_font_driver): Add missing initializers.
4862 2011-03-23 Julien Danjou <julien@danjou.info>
4864 * term.c (Fsuspend_tty, Fresume_tty):
4865 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4866 * window.c (temp_output_buffer_show):
4867 * insdel.c (signal_before_change):
4868 * frame.c (Fhandle_switch_frame):
4869 * fileio.c (Fdo_auto_save):
4870 * emacs.c (Fkill_emacs):
4871 * editfns.c (save_excursion_restore):
4872 * cmds.c (internal_self_insert):
4873 * callint.c (Fcall_interactively):
4874 * buffer.c (Fkill_all_local_variables):
4875 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4877 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4878 unconditionnaly since it does the check itself.
4880 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4882 Fix more problems found by GCC 4.5.2's static checks.
4884 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4885 the first time through the loop, since we know p0 < p1 then.
4886 This also avoids a gcc -Wstrict-overflow warning.
4888 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4889 leading to a memory leak, possible in functions like
4890 load_charset_map_from_file that can allocate an unbounded number
4891 of objects (Bug#8318).
4893 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4894 that could (at least in theory) be that large.
4896 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4897 This is less likely to overflow, and avoids undefined behavior if
4898 overflow does occur. All callers changed. Use strtoul to scan
4899 for the unsigned long integer.
4900 (pint2hrstr): Simplify and tune code slightly.
4901 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4903 * scroll.c (do_scrolling): Work around GCC bug 48228.
4904 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4906 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4907 This also avoids a warning with gcc -Wstrict-overflow.
4908 (validate_x_resource_name): Simplify count usage.
4909 This also avoids a warning with gcc -Wstrict-overflow.
4911 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4914 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4916 * process.c (Fmake_network_process): Use socklen_t, not int,
4917 where POSIX says socklen_t is required in portable programs.
4918 This fixes a porting bug on hosts like 64-bit HP-UX, where
4919 socklen_t is wider than int (Bug#8277).
4920 (Fmake_network_process, server_accept_connection):
4921 (wait_reading_process_output, read_process_output):
4924 * process.c: Rename or move locals to avoid shadowing.
4925 (list_processes_1, Fmake_network_process):
4926 (read_process_output_error_handler, exec_sentinel_error_handler):
4927 Rename or move locals.
4928 (Fmake_network_process): Define label "retry_connect" only if needed.
4929 (Fnetwork_interface_info): Fix pointer signedness.
4930 (process_send_signal): Add cast to avoid pointer signedness problem.
4931 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4932 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4934 Make tparam.h and terminfo.c consistent.
4935 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4936 Include tparam.h instead, since it declares them.
4937 * cm.h (PC): Remove extern decl; tparam.h now does this.
4938 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4939 * terminfo.c: Include tparam.h, to check interfaces.
4940 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4941 (tparam): Adjust signature to match interface in tparam.h;
4942 this removes some undefined behavior. Check that outstring and len
4943 are zero, which they always are with Emacs.
4944 * tparam.h (PC, BC, UP): New extern decls.
4946 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4947 (xftfont_open): Rename locals to avoid shadowing.
4949 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4950 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4951 (OTF_TAG_SYM): Omit macro if not needed.
4952 (ftfont_list): Remove unused local.
4953 (get_adstyle_property, ftfont_pattern_entity):
4954 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4955 Rename locals to avoid shadowing.
4957 * xfont.c (xfont_list_family): Mark var as initialized.
4959 * xml.c (make_dom): Now static.
4961 * composite.c (composition_compute_stop_pos): Rename local to
4963 (composition_reseat_it): Remove unused locals.
4964 (find_automatic_composition, composition_adjust_point): Likewise.
4965 (composition_update_it): Mark var as initialized.
4966 (find_automatic_composition): Mark vars as initialized,
4967 with a FIXME (Bug#8290).
4969 character.h: Rename locals to avoid shadowing.
4970 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4971 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4972 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4973 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4976 * textprop.c (property_change_between_p): Remove; unused.
4978 * intervals.c (interval_start_pos): Now static.
4980 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4982 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4983 Rename locals to avoid shadowing.
4985 * sound.c (wav_play, au_play, Fplay_sound_internal):
4986 Fix pointer signedness.
4987 (alsa_choose_format): Remove unused local var.
4988 (wav_play): Initialize a variable to 0, to prevent undefined
4989 behavior (Bug#8278).
4991 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4993 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4995 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4996 clobbering (Bug#8298).
4997 * sysdep.c (sys_subshell): Likewise.
4998 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5000 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5001 This should get cleaned up, so that child_setup has the
5002 same signature on all platforms.
5004 * callproc.c (call_process_cleanup): Now static.
5005 (relocate_fd): Rename locals to avoid shadowing.
5007 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5009 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5010 not to be necessary, and produces flickering.
5012 2011-03-20 Glenn Morris <rgm@gnu.org>
5014 * config.in: Remove file.
5016 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5018 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5019 are now in src/globals.h.
5020 (syms_of_minibuf): Remove spurious & from previous change.
5022 2011-03-20 Leo <sdl.web@gmail.com>
5024 * minibuf.c (completing-read-function): New variable.
5025 (completing-read-default): Rename from completing-read.
5026 (completing-read): Call completing-read-function.
5028 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5030 * xfaces.c (Fx_load_color_file):
5031 Read color file from absolute filename (bug#8250).
5033 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5035 * makefile.w32-in: Update dependencies.
5037 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5039 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5041 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5043 Fix more problems found by GCC 4.5.2's static checks.
5045 * process.c (make_serial_process_unwind, send_process_trap):
5046 (sigchld_handler): Now static.
5048 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5049 That way, the code declares only the vars that it needs.
5050 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5051 * s/cygwin.h (PTY_ITERATION): Likewise.
5052 * s/darwin.h (PTY_ITERATION): Likewise.
5053 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5055 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5056 * process.c (allocate_pty): Don't declare stb unless it's needed.
5058 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5059 (CONSTANTLIM): Remove; unused.
5060 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5061 Define only if needed.
5063 * unexelf.c (unexec): Name an expression,
5064 to avoid gcc -Wbad-function-cast warning.
5065 Use a different way to cause a compilation error if anyone uses
5066 n rather than nn, a way that does not involve shadowing.
5067 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5069 * deps.mk (unexalpha.o): Remove; unused.
5071 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5072 * unexec.h: New file.
5073 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5074 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5076 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5077 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5078 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5079 Change as necessary to match prototype in unexec.h.
5081 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5083 (back_comment, skip_chars): Mark vars as initialized.
5085 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5086 Rename locals to avoid shadowing.
5088 * lread.c (read1): Rewrite so as not to use empty "else".
5089 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5091 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5093 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5094 warning when compiling print.c.
5096 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5097 instead of using an uninitialized var.
5098 (font_sort_entities): Mark var as initialized.
5100 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5102 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5103 pointers to constants.
5104 (font_parse_fcname): Remove unused vars.
5105 (font_delete_unmatched): Now static.
5106 (font_get_spec): Remove; unused.
5107 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5108 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5109 Rename or move locals to avoid shadowing.
5111 * fns.c (require_nesting_list, require_unwind): Now static.
5112 (Ffillarray): Rename locals to avoid shadowing.
5114 * floatfns.c (domain_error2): Define only if needed.
5115 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5117 * alloc.c (mark_backtrace): Move decl from here ...
5118 * lisp.h: ... to here, so that it can be checked.
5120 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5121 (Fdefvar): Rewrite so as not to use empty "else".
5122 (lisp_indirect_variable): Name an expression,
5123 to avoid gcc -Wbad-function-cast warning.
5124 (Fdefvar): Rename locals to avoid shadowing.
5126 * callint.c (quotify_arg, quotify_args): Now static.
5127 (Fcall_interactively): Rename locals to avoid shadowing.
5128 Use const pointer when appropriate.
5130 * lisp.h (get_system_name, get_operating_system_release):
5131 Move decls here, to check interfaces.
5132 * process.c (get_operating_system_release): Move decl to lisp.h.
5133 * xrdb.c (get_system_name): Likewise.
5134 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5135 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5136 some of which prompt warnings from gcc -Wbad-function-cast.
5137 (Fformat_time_string, Fencode_time, Finsert_char):
5138 (Ftranslate_region_internal, Fformat):
5139 Rename or remove local vars to avoid shadowing.
5140 (Ftranslate_region_internal): Mark var as initialized.
5142 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5145 * lisp.h (eassert): Check that the argument compiles, even if
5146 ENABLE_CHECKING is not defined.
5148 * data.c (Findirect_variable): Name an expression, to avoid
5149 gcc -Wbad-function-cast warning.
5150 (default_value, arithcompare, arith_driver, arith_error): Now static.
5151 (store_symval_forwarding): Rename local to avoid shadowing.
5152 (Fmake_variable_buffer_local, Fmake_local_variable):
5153 Mark variables as initialized.
5154 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5156 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5157 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5158 Rename locals to avoid shadowing.
5159 (mark_stack): Move local variables into the #ifdef region where
5161 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5162 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5164 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5165 (GC_STRING_CHARS): Remove; not used.
5166 (Fmemory_limit): Cast sbrk's returned value to char *.
5168 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5169 avoids undefined behavior in theory.
5171 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5173 Use functions, not macros, for up- and down-casing (Bug#8254).
5174 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5175 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5176 to use the following functions instead of these macros.
5177 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5178 EMACS_INT, since callers assume the returned value fits in int.
5179 (upcase1): Likewise, for UPCASE_TABLE.
5180 (uppercasep, lowercasep, upcase): New static inline functions.
5181 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5182 the race-condition problem in the old DOWNCASE.
5184 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5185 Rename locals to avoid shadowing.
5186 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5187 (regex_compile, re_search_2, re_match_2_internal):
5188 Remove unused local vars.
5189 (FREE_VAR): Rewrite so as not to use empty "else",
5190 which gcc can warn about.
5191 (regex_compile, re_match_2_internal): Mark locals as initialized.
5192 (RETALLOC_IF): Define only if needed.
5193 (WORDCHAR_P): Likewise. This one is never needed, but is used
5194 only in a comment talking about a compiler bug, so put inside
5195 the #if 0 of that comment.
5196 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5197 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5200 * search.c (boyer_moore): Rename locals to avoid shadowing.
5201 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5202 (PREV_CHAR_BOUNDARY): Likewise.
5204 * search.c (simple_search): Remove unused var.
5206 * dired.c (compile_pattern): Move decl from here ...
5207 * lisp.h: ... to here, so that it can be checked.
5208 (struct re_registers): New forward decl.
5210 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5212 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5214 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5215 Rename locals to avoid shadowing.
5216 (Fvertical_motion): Mark locals as initialized.
5218 * casefiddle.c (casify_object, casify_region): Now static.
5219 (casify_region): Mark local as initialized.
5221 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5223 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5224 New macros, so that the caller can use some names other than
5225 gcpro1, gcpro2, etc.
5226 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5228 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5229 argument, for consistency with GCPRO2_VAR, etc: it is now the
5230 prefix of the variable, not the variable itself. All uses
5232 * dired.c (directory_files_internal, file_name_completion):
5233 Rename locals to avoid shadowing.
5235 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5236 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5237 dired.c's scmp function, had undefined behavior.
5238 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5239 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5240 * buffer.h: ... to here, because these macros use current_buffer,
5241 and the new implementation with inline functions needs to have
5242 current_buffer in scope now, rather than later when the macros
5244 (downcase, upcase1): New static inline functions.
5245 (DOWNCASE, UPCASE1): Reimplement using these functions.
5246 This avoids undefined behavior in expressions like
5247 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5248 from race conditions in accessing the global variables
5249 case_temp1 and case_temp2.
5250 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5251 * lisp.h (case_temp1, case_temp2): Remove their decls.
5252 * character.h (ASCII_CHAR_P): Move from here ...
5253 * lisp.h: ... to here, so that the inline functions mentioned
5256 * dired.c (directory_files_internal_unwind): Now static.
5258 * fileio.c (file_name_as_directory, directory_file_name):
5259 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5261 (file_name_as_directory): Use const pointers when appropriate.
5262 (Fexpand_file_name): Likewise. In particular, newdir might
5263 point at constant storage, so make it a const pointer.
5264 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5265 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5267 (Fset_file_times, Finsert_file_contents, auto_save_error):
5268 Rename locals to avoid shadowing.
5270 * minibuf.c (choose_minibuf_frame_1): Now static.
5271 (Ftry_completion, Fall_completions): Rename or remove locals
5274 * marker.c (bytepos_to_charpos): Remove; unused.
5276 * lisp.h (verify_bytepos, count_markers): New decls,
5277 so that gcc does not warn that these functions aren't declared.
5279 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5280 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5281 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5282 (copy_text): Remove unused local var.
5284 * filelock.c (within_one_second): Now static.
5285 (lock_file_1): Rename local to avoid shadowing.
5287 * buffer.c (fix_overlays_before): Mark locals as initialized.
5288 (fix_start_end_in_overlays): Likewise. This function should be
5289 simplified by using pointers-to-pointers, but that's a different
5291 (switch_to_buffer_1): Now static.
5292 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5293 (report_overlay_modification): Rename locals to avoid shadowing.
5295 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5296 Fix pointer signedness issue.
5297 (sys_subshell): Mark local as volatile if checking for lint,
5298 to suppress a gcc -Wclobbered warning that does not seem to be right.
5299 (MAXPATHLEN): Define only if needed.
5301 * process.c (serial_open, serial_configure): Move decls from here ...
5302 * systty.h: ... to here, so that they can be checked.
5304 * fns.c (get_random, seed_random): Move extern decls from here ...
5305 * lisp.h: ... to here, so that they can be checked.
5307 * sysdep.c (reset_io): Now static.
5308 (wait_for_termination_signal): Remove; unused.
5310 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5311 (copy_keymap_item, append_key, push_text_char_description):
5313 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5314 (DENSE_TABLE_SIZE): Remove; unused.
5315 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5316 (describe_map_tree):
5317 Rename locals to avoid shadowing.
5319 * keyboard.c: Declare functions static if they are not used elsewhere.
5320 (echo_char, echo_dash, cmd_error, top_level_2):
5321 (poll_for_input, handle_async_input): Now static.
5322 (read_char, kbd_buffer_get_event, make_lispy_position):
5323 (make_lispy_event, make_lispy_movement, apply_modifiers):
5324 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5325 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5326 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5327 (read_key_sequence, read_char): Mark locals as initialized.
5328 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5330 * keyboard.h (make_ctrl_char): New decl.
5331 (mark_kboards): Move decl here ...
5332 * alloc.c (mark_kboards): ... from here.
5334 * lisp.h (force_auto_save_soon): New decl.
5336 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5337 (DEFINE_DUMMY_FUNCTION): New macro.
5338 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5340 (main): Add casts to avoid warnings
5341 if GCC considers string literals to be constants.
5343 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5345 * dbusbind.c: Pointer signedness fixes.
5346 (xd_signature, xd_append_arg, xd_initialize):
5347 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5348 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5349 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5350 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5352 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5353 if GCC considers string literals to be constants.
5354 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5356 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5358 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5359 (print_preprocess, print_object): New macro to fix last change.
5361 * print.c (print_preprocess): Don't forget font objects.
5363 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5365 * emacs.c (USAGE3): Doc fixes.
5367 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5369 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5372 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5374 * lisp.h (VWindow_system, Qfile_name_history):
5375 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5376 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5377 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5379 * w32select.c: Don't #include "keyboard.h".
5380 (run_protected): Add extern declaration for waiting_for_input.
5382 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5383 * w32console.c (detect_input_pending, read_input_pending)
5384 (encode_terminal_code):
5385 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5386 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5387 (w32_system_caret_y, Qfile_name_history):
5388 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5389 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5390 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5391 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5392 * w32proc.c (Qlocal, report_file_error):
5393 * w32term.c (Vwindow_system, updating_frame):
5394 * w32uniscribe.c (initialized, uniscribe_font_driver):
5395 Remove unneeded extern declarations.
5397 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5399 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5401 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5403 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5404 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5405 These macros can no longer be used for assignment.
5407 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5408 Assign struct members directly, instead of using BUF_BEGV etc.
5409 (record_buffer_markers, fetch_buffer_markers): New functions for
5410 recording and fetching special buffer markers.
5411 (set_buffer_internal_1, set_buffer_temp): Use them.
5413 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5415 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5417 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5418 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5420 * xdisp.c (hscroll_window_tree):
5421 (reconsider_clip_changes): Use PT instead of BUF_PT.
5423 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5425 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5426 $(EMACS_ROOT)/lib/intprops.h.
5428 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5430 Fix more problems found by GCC 4.5.2's static checks.
5432 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5433 to unsigned char * to avoid compiler diagnostic.
5434 (xg_free_frame_widgets): Make it clear that a local variable is
5435 needed only if USE_GTK_TOOLTIP.
5436 (gdk_window_get_screen): Make it clear that this macro is needed
5437 only if USE_GTK_TOOLTIP.
5438 (int_gtk_range_get_value): New function, which avoids a diagnostic
5439 from gcc -Wbad-function-cast.
5440 (xg_set_toolkit_scroll_bar_thumb): Use it.
5441 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5442 diagnostic from gcc -Wbad-function-cast.
5443 (get_utf8_string, xg_get_file_with_chooser):
5444 Rename locals to avoid shadowing.
5445 (create_dialog): Move locals to avoid shadowing.
5447 * xgselect.c (xg_select): Remove unused var.
5449 * image.c (four_corners_best): Mark locals as initialized.
5450 (gif_load): Initialize transparent_p to zero (Bug#8238).
5451 Mark another local as initialized.
5452 (my_png_error, my_error_exit): Mark with NO_RETURN.
5454 * image.c (clear_image_cache): Now static.
5455 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5456 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5457 (x_edge_detection): Remove unnecessary cast that
5458 gcc -Wbad-function-cast diagnoses.
5459 (gif_load): Fix pointer signedness.
5460 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5461 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5463 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5465 Improve quality of tests for time stamp overflow.
5466 For example, without this patch (encode-time 0 0 0 1 1
5467 1152921504606846976) returns the obviously-bogus value (-948597
5468 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5469 reports time overflow. See
5470 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5471 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5472 * editfns.c: Include limits.h and intprops.h.
5473 (TIME_T_MIN, TIME_T_MAX): New macros.
5474 (time_overflow): Move earlier, to before first use.
5475 (hi_time, lo_time): New functions, for an accurate test for
5477 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5478 (Fget_internal_run_time): Don't assume time_t fits in int.
5479 (make_time): Use list2 instead of Fcons twice.
5480 (Fdecode_time): More accurate test for out-of-range times.
5481 (check_tm_member): New function.
5482 (Fencode_time): Use it, to test for out-of-range times.
5483 (lisp_time_argument): Don't rely on undefined left-shift and
5484 right-shift behavior when checking for time stamp overflow.
5486 * editfns.c (time_overflow): New function, refactoring common code.
5487 (Fformat_time_string, Fdecode_time, Fencode_time):
5488 (Fcurrent_time_string): Use it.
5490 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5491 * dired.c (make_time): Move to ...
5492 * editfns.c (make_time): ... here.
5493 * systime.h: Note the move.
5495 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5497 * fringe.c (update_window_fringes): Remove unused variables.
5499 * unexmacosx.c (copy_data_segment): Also copy __got section.
5502 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5504 * termcap.c [MSDOS]: Include "msdos.h".
5505 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5506 Constify `char *' arguments and their references according to
5507 prototypes in tparam.h.
5509 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5511 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5512 Adapt all references accordingly.
5514 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5516 2011-03-11 Tom Tromey <tromey@redhat.com>
5518 * buffer.c (syms_of_buffer): Remove obsolete comment.
5520 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5522 * termhooks.h (encode_terminal_code): Declare prototype.
5524 * msdos.c (encode_terminal_code): Don't declare prototype.
5526 * term.c (encode_terminal_code): Now external again, used by
5527 w32console.c and msdos.c.
5529 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5530 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5532 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5534 Fix some minor problems found by GCC 4.5.2's static checks.
5536 * fringe.c (update_window_fringes): Mark locals as initialized
5538 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5540 * alloc.c (mark_fringe_data): Move decl from here ...
5541 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5542 to check its interface.
5543 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5545 * fontset.c (free_realized_fontset): Now static.
5546 (Fset_fontset_font): Rename local to avoid shadowing.
5547 (fontset_font): Mark local as initialized.
5548 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5550 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5552 * xselect.c (x_disown_buffer_selections): Remove; not used.
5553 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5554 (x_own_selection, Fx_disown_selection_internal): Rename locals
5556 (x_handle_dnd_message): Remove local to avoid shadowing.
5558 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5559 so that the caller can use some name other than gcpro1.
5560 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5561 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5562 (Fx_backspace_delete_keys_p):
5563 Use them to avoid shadowing, and rename vars to avoid shadowing.
5564 (x_decode_color, x_set_name, x_window): Now static.
5565 (Fx_create_frame): Add braces to silence GCC warning.
5566 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5567 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5568 Remove unused locals.
5569 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5570 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5571 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5574 * xterm.h (x_mouse_leave): New decl.
5576 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5577 Remove unused functions.
5578 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5579 (x_calc_absolute_position): Now static.
5580 (XTread_socket): Don't define label "out" unless it's used.
5581 Don't declare local "event" unless it's used.
5582 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5583 unless they are used.
5584 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5585 (x_fatal_error_signal): Remove; not used.
5586 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5587 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5588 (x_error_catcher, x_connection_closed, x_error_handler):
5589 (x_error_quitter, xembed_send_message, x_iconify_frame):
5590 (my_log_handler): Rename locals to avoid shadowing.
5591 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5592 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5594 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5595 Rename or move locals to avoid shadowing.
5596 (tty_defined_color, merge_face_heights): Now static.
5597 (free_realized_faces_for_fontset): Remove; not used.
5598 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5599 does not deduce is never used uninitialized.
5600 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5601 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5603 * terminal.c (store_terminal_param): Now static.
5605 * xmenu.c (menu_highlight_callback): Now static.
5606 (set_frame_menubar): Remove unused local.
5607 (xmenu_show): Rename parameter to avoid shadowing.
5608 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5609 since they might point to immutable storage.
5610 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5611 since it's unused otherwise.
5613 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5614 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5615 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5616 avoids a gcc -Wuninitialized diagnostic.
5617 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5618 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5619 does not deduce are never used uninitialized.
5621 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5623 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5624 * window.c (window_loop, size_window):
5625 (run_window_configuration_change_hook, enlarge_window): Likewise.
5627 * window.c (display_buffer): Now static.
5628 (size_window): Mark variables that gcc -Wuninitialized
5629 does not deduce are never used uninitialized.
5630 * window.h (check_all_windows): New decl, to forestall
5631 gcc -Wmissing-prototypes diagnostic.
5632 * dispextern.h (bidi_dump_cached_states): Likewise.
5634 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5636 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5638 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5639 and to avoid gcc -Wuninitialized warning.
5640 (load_charset_map): Mark variables that gcc -Wuninitialized
5641 does not deduce are never used uninitialized.
5642 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5644 * coding.c (coding_set_source, coding_set_destination):
5645 Use "else { /* comment */ }" rather than "else /* comment */;"
5646 for clarity, and to avoid gcc -Wempty-body warning.
5647 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5648 a block, when the outer 'i' will do.
5649 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5650 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5651 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5652 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5653 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5654 Rename locals to avoid shadowing.
5655 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5656 * coding.c (emacs_mule_char, encode_invocation_designation):
5657 Now static, since they're not used elsewhere.
5658 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5659 (decode_coding_object, encode_coding_object, detect_coding_system):
5660 (decode_coding_emacs_mule): Mark variables that gcc
5661 -Wuninitialized does not deduce are never used uninitialized.
5662 (detect_coding_iso_2022): Initialize a local variable that might
5663 be used uninitialized. Leave a FIXME because it's not clear that
5664 this initialization is needed. (Bug#8211)
5665 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5666 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5667 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5668 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5669 Remove unused macros.
5671 * category.c (hash_get_category_set): Remove unused local var.
5672 (copy_category_table): Now static, since it's not used elsewhere.
5673 * character.c (string_count_byte8): Likewise.
5675 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5676 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5678 * chartab.c (copy_sub_char_table): Now static, since it's not used
5680 (sub_char_table_ref_and_range, char_table_ref_and_range):
5681 Rename locals to avoid shadowing.
5682 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5684 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5685 (BIDI_BOB): Remove unused macro.
5687 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5688 deduce are never used uninitialized.
5689 * term.c (encode_terminal_code): Likewise.
5691 * term.c (encode_terminal_code): Now static. Remove unused local.
5693 * tparam.h: New file.
5694 * term.c, tparam.h: Include it.
5695 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5696 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5697 Move these decls to tparam.h, and make them agree with what
5698 is actually in tparam.c. The previous trick of using incompatible
5699 decls in different modules does not conform to the C standard.
5700 All callers of tparam changed to use tparam's actual API.
5701 * tparam.c (tparam1, tparam, tgoto):
5702 Use const pointers where appropriate.
5704 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5705 * cm.h (struct cm): Likewise.
5706 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5707 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5708 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5709 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5710 (turn_on_face, init_tty): Likewise.
5711 * termchar.h (struct tty_display_info): Likewise.
5713 * term.c (term_mouse_position): Rename local to avoid shadowing.
5715 * alloc.c (mark_ttys): Move decl from here ...
5716 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5718 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5720 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5722 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5724 * search.c (compile_pattern_1): Remove argument regp, unused since
5725 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5726 (compile_pattern): Don't pass it.
5728 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5730 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5731 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5733 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5735 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5737 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5738 gdk_window_get_screen, gdk_window_get_geometry,
5739 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5740 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5741 (xg_get_pixbuf_from_pixmap): New function.
5742 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5743 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5744 Call xg_get_pixbuf_from_pixmap instead of
5745 gdk_pixbuf_get_from_drawable.
5746 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5747 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5748 (xg_check_special_colors): Use GtkStyleContext and its functions
5750 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5751 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5752 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5753 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5754 Call gtk_widget_get_preferred_size.
5755 (xg_frame_resized): gdk_window_get_geometry only takes 5
5757 (xg_win_to_widget, xg_event_is_for_menubar):
5758 Call gdk_x11_window_lookup_for_display.
5759 (xg_set_widget_bg): New function.
5760 (delete_cb): New function.
5761 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5762 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5763 (xg_set_background_color): Call xg_set_widget_bg.
5764 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5765 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5766 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5767 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5769 (update_frame_tool_bar): Call gtk_widget_hide.
5770 (xg_initialize): Use GDK_KEY_g.
5772 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5774 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5776 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5777 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5778 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5780 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5782 * w32xfns.c (select_palette): Check success of RealizePalette against
5783 GDI_ERROR, not zero.
5785 See ChangeLog.11 for earlier changes.
5791 Copyright (C) 2011 Free Software Foundation, Inc.
5793 This file is part of GNU Emacs.
5795 GNU Emacs is free software: you can redistribute it and/or modify
5796 it under the terms of the GNU General Public License as published by
5797 the Free Software Foundation, either version 3 of the License, or
5798 (at your option) any later version.
5800 GNU Emacs is distributed in the hope that it will be useful,
5801 but WITHOUT ANY WARRANTY; without even the implied warranty of
5802 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5803 GNU General Public License for more details.
5805 You should have received a copy of the GNU General Public License
5806 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.